gdb/ChangeLog

   1 2019-08-16  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_window_base)
   4         <update_source_window>: Declare.
   5         (tui_update_source_window): Don't declare.
   6         * tui/tui-winsource.c
   7         (tui_source_window_base::update_source_window): Rename from
   8         tui_update_source_window.
   9         (tui_source_window_base::rerender): Update.
  10         * tui/tui-source.c (tui_source_window::maybe_update): Update.
  11         * tui/tui-disasm.c (tui_show_disassem)
  12         (tui_show_disassem_and_update_source)
  13         (tui_disasm_window::maybe_update): Update.
  14
  15 2019-08-16  Tom Tromey  <tom@tromey.com>
  16
  17         * tui/tui-winsource.h (struct tui_source_window_base)
  18         <update_source_window_as_is>: Declare.
  19         (tui_update_source_window_as_is): Don't declare.
  20         * tui/tui-winsource.c (tui_update_source_window): Update
  21         (tui_source_window_base::update_source_window_as_is): Rename from
  22         tui_update_source_window_as_is.
  23         (tui_source_window_base::refill): Update.
  24         * tui/tui-source.c (tui_show_symtab_source): Update.
  25         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
  26         Update.
  27
  28 2019-08-16  Tom Tromey  <tom@tromey.com>
  29
  30         * tui/tui-winsource.h (tui_update_source_window)
  31         (tui_update_source_window_as_is): Remove "noerror" parameter.
  32         * tui/tui-winsource.c (tui_update_source_window)
  33         (tui_update_source_window_as_is): Remove "noerror" parameter.
  34         (tui_update_source_windows_with_addr)
  35         (tui_update_source_windows_with_line)
  36         (tui_source_window_base::rerender)
  37         (tui_source_window_base::refill): Update.
  38         * tui/tui-source.h (tui_set_source_content)
  39         (tui_show_symtab_source): Remove "noerror" parameter.
  40         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
  41         parameter.
  42         (tui_show_symtab_source): Likewise.
  43         (tui_source_window::maybe_update): Update.
  44         * tui/tui-disasm.c (tui_show_disassem)
  45         (tui_show_disassem_and_update_source)
  46         (tui_disasm_window::do_scroll_vertical)
  47         (tui_disasm_window::maybe_update): Update.
  48
  49 2019-08-16  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui.c (tui_is_window_visible): Update.
  52         * tui/tui-wingeneral.c (tui_make_window)
  53         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
  54         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
  55         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
  56         (tui_set_win_height_command, parse_scrolling_args): Update.
  57         * tui/tui-source.c (tui_source_window::style_changed): Update.
  58         * tui/tui-regs.c (tui_show_registers)
  59         (tui_data_window::first_data_item_displayed)
  60         (tui_data_window::delete_data_content_windows)
  61         (tui_check_register_values, tui_reg_command): Update.
  62         * tui/tui-disasm.c (tui_show_disassem): Update.
  63         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
  64         method.
  65         <is_visible>: Remove field.
  66         * tui/tui-data.c (tui_next_win, tui_prev_win)
  67         (tui_delete_invisible_windows): Update.
  68
  69 2019-08-16  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-winsource.h (struct tui_source_window_base)
  72         <m_has_locator>: Remove.
  73         * tui/tui-layout.c (show_source_disasm_command, show_data)
  74         (show_source_or_disasm_and_command): Update.
  75
  76 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
  77
  78         * NEWS (Other MI changes): New subsection.
  79         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
  80         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
  81         * arch-utils.c (default_get_pc_address_flags): New function.
  82         * arch-utils.h (default_get_pc_address_flags): New declaration.
  83         * gdbarch.sh: Add get_pc_address_flags.
  84         * gdbarch.c: Regenerate.
  85         * gdbarch.h: Likewise.
  86         * stack.c (print_pc): New function.
  87         (print_frame_info) (print_frame): Call print_pc.
  88
  89 2019-08-16  Tom de Vries  <tdevries@suse.de>
  90
  91         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
  92         print_objfile_section_info.
  93
  94 2019-08-15  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
  97         calling update_cmdwin_start_line.
  98         * tui/tui-winsource.h (struct tui_source_window_base)
  99         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 100         <rerender>: Declare.
 101         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 102         Call rerender.
 103         (tui_source_window_base::set_new_height): Remove.
 104         (tui_source_window_base::rerender): Rename from
 105         do_make_visible_with_new_height.
 106         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 107         resize method.
 108         (tui_win_info::make_invisible_and_set_new_height)
 109         (tui_win_info::make_visible_with_new_height): Remove.
 110         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 111         Declare.
 112         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 113         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 114         do_make_visible_with_new_height>: Don't declare.
 115         <rerender>: Declare.
 116         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 117         set_new_height.
 118         (tui_data_window::do_make_visible_with_new_height): Remove.
 119         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 120         call tui_show_locator_content.
 121         (tui_gen_win_info::resize): Call rerender.
 122         (show_source_or_disasm_and_command): Don't call
 123         tui_show_locator_content.
 124         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 125         method.
 126         (struct tui_win_info) <rerender>: Declare.
 127         <set_new_height, make_invisible_and_set_new_height,
 128         make_visible_with_new_height>: Don't declare.
 129         * tui/tui-data.c (tui_win_list::rerender): New method.
 130         * tui/tui-command.h (struct tui_cmd_window)
 131         <do_make_visible_with_new_height>: Don't declare.
 132         * tui/tui-command.c
 133         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 134
 135 2019-08-15  Tom Tromey  <tromey@adacore.com>
 136
 137         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 138         * ada-lang.c (ada_enum_name): Likewise.
 139
 140 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 141
 142         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 143         leading underscore.
 144         (GdbOutputErrorFile): Likewise.
 145         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 146         accordingly.
 147         (execute_unwinders): Rename to have a leading underscore.
 148         (auto_load_packages): Likewise.
 149         (global scope): Adjust call to auto_load_packages accordingly.
 150         (GdbSetPythonDirectory): Likewise.
 151         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 152         instead of execute_unwinders.
 153
 154 2019-08-15  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 157         (show_data): Don't change window visibility.
 158         (tui_gen_win_info::resize): Remove special case for command
 159         window.  Use wresize, when available.
 160         (show_source_or_disasm_and_command): Don't change window
 161         visibility.
 162         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 163         <make_visible>: New method.
 164         * tui/tui-command.c (tui_cmd_window::resize): New method.
 165
 166 2019-08-15  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 169         (struct tui_source_windows): New.
 170         * tui/tui-winsource.c (tui_display_main): Update.
 171         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 172         (new_height_ok, parse_scrolling_args): Update.
 173         * tui/tui-layout.c (show_layout, show_data): Update.
 174         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 175         (tui_add_to_source_windows): Don't declare.
 176         * tui/tui-data.c (source_windows, tui_source_windows)
 177         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 178
 179 2019-08-15  Tom Tromey  <tom@tromey.com>
 180
 181         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 182         Rename from reset.
 183         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 184         * tui/tui-layout.c (show_source_disasm_command, show_data):
 185         Update.
 186         (tui_gen_win_info::resize): Rename.
 187         (show_source_or_disasm_and_command): Update.
 188         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 189         reset.
 190
 191 2019-08-15  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 194         * tui/tui-interp.c (tui_interp::init): Don't call
 195         tui_initialize_static_data.
 196         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 197
 198 2019-08-15  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 201         examine tui_win_list.
 202
 203 2019-08-15  Tom Tromey  <tom@tromey.com>
 204
 205         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 206         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 207         tui_clear_source_content.
 208         (tui_clear_source_content): Remove.
 209         (tui_source_window_base::do_erase_source_content): Hoist call to
 210         content.clear().
 211         * tui/tui-stack.c (tui_show_frame_info): Don't call
 212         tui_clear_source_content.
 213
 214 2019-08-15  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-winsource.h (struct tui_source_window_base)
 217         <do_erase_source_content>: New method.
 218         <erase_source_content>: New method.
 219         (tui_erase_source_content): Don't declare.
 220         * tui/tui-winsource.c (tui_clear_source_content): Update.
 221         (tui_source_window_base::do_erase_source_content): Rename from
 222         tui_erase_source_content.
 223         (tui_source_window_base::show_source_content): Update.
 224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 225         * tui/tui-source.h (struct tui_source_window)
 226         <erase_source_content>: New method.
 227         * tui/tui-disasm.h (struct tui_disasm_window)
 228         <erase_source_content>: New method.
 229
 230 2019-08-15  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 233         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 234         constructor.
 235         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 236         * tui/tui-source.c (tui_set_source_content): Update.
 237         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 238
 239 2019-08-15  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 242         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 243         tui-source.c.
 244         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 245         Declare.
 246         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 247         method.
 248         (tui_source_window::maybe_update): Update.
 249
 250 2019-08-15  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 253         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 254         tui-disasm.c.
 255         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 256         Declare.
 257         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 258         method.
 259         (tui_disasm_window::maybe_update): Update.
 260
 261 2019-08-15  Tom Tromey  <tom@tromey.com>
 262
 263         * tui/tui-winsource.h (struct tui_source_window_base)
 264         <maybe_update>: Declare.
 265         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 266         method.
 267         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 268         Declare.
 269         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 270         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 271         Declare.
 272         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 273
 274 2019-08-15  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 277
 278 2019-08-15  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-wingeneral.c: Include tui-stack.h.
 281         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 282         (struct tui_locator_window): Move from tui-data.h.
 283         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 284         (tui_initialize_static_data): Move from tui-data.c.
 285         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 286         (struct tui_locator_window): Move to tui-stack.c.
 287         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 288         (tui_initialize_static_data): Move to tui-stack.c.
 289
 290 2019-08-15  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-layout.c (show_source_disasm_command)
 293         (show_source_or_disasm_and_command): Use make_visible method, not
 294         tui_make_window.
 295         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 296         Remove.
 297
 298 2019-08-15  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-wingeneral.h (tui_make_window): Update.
 301         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 302         parameter.
 303         (tui_gen_win_info::make_visible): Update.
 304         * tui/tui-regs.c (tui_data_window::display_registers_from):
 305         Update.
 306         * tui/tui-layout.c (show_source_disasm_command)
 307         (show_source_or_disasm_and_command): Update.
 308         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 309         (enum tui_box): Remove.
 310         (struct tui_win_info) <can_box>: New method.
 311         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 312         method.
 313
 314 2019-08-15  Tom de Vries  <tdevries@suse.de>
 315
 316         * linux-nat-trad.c: Include gdbarch.h.
 317
 318 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 319
 320         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 321         register sizes.
 322
 323 2019-08-14  Tom Tromey  <tromey@adacore.com>
 324
 325         * darwin-nat.c: Include gdbarch.h.
 326         * darwin-nat-info.c: Include gdbarch.h.
 327
 328 2019-08-13  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 331         Remove.
 332         * tui/tui-data.c (tui_initialize_static_data): Update.
 333
 334 2019-08-13  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-winsource.h (struct tui_exec_info_window)
 337         <~tui_exec_info_window, maybe_allocate_content, get_content,
 338         m_content>: Remove.
 339         (struct tui_source_window_base) <set_exec_info_content,
 340         show_exec_info_content>: Don't declare.
 341         * tui/tui-winsource.c
 342         (tui_exec_info_window::maybe_allocate_content): Remove.
 343         (tui_source_window_base::update_exec_info): Rename from
 344         set_exec_info_content.
 345         (tui_source_window_base::show_exec_info_content)
 346         (tui_source_window_base::update_exec_info): Remove.
 347
 348 2019-08-13  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 351         declare.
 352         * tui/tui-winsource.c (tui_update_source_window_as_is)
 353         (tui_update_source_windows_with_addr, tui_erase_source_content):
 354         Update.
 355         (tui_clear_exec_info_content): Remove.
 356
 357 2019-08-13  Tom Tromey  <tom@tromey.com>
 358
 359         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 360         declare.
 361         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 362         call tui_erase_exec_info_content.
 363         (tui_clear_exec_info_content): Rename from
 364         tui_erase_exec_info_content.
 365         (tui_clear_exec_info_content): Delete.
 366
 367 2019-08-13  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-winsource.h (struct tui_source_window_base)
 370         <show_exec_info_content>: Declare.
 371         (tui_show_exec_info_content): Don't declare.
 372         * tui/tui-winsource.c
 373         (tui_source_window_base::show_exec_info_content): Rename from
 374         tui_show_exec_info_content.
 375         (tui_source_window_base::update_exec_info): Update.
 376
 377 2019-08-13  Tom Tromey  <tom@tromey.com>
 378
 379         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 380         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 381         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 382         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 383         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 384         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 385         ... here.
 386
 387 2019-08-13  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-winsource.h (struct tui_source_window_base)
 390         <update_exec_info>: Declare.
 391         (tui_update_exec_info): Don't declare.
 392         * tui/tui-winsource.c (tui_update_source_window_as_is)
 393         (tui_source_window_base::refresh_all)
 394         (tui_update_all_breakpoint_info): Update.
 395         (tui_source_window_base::update_exec_info): Rename from
 396         tui_update_exec_info.
 397         * tui/tui-stack.c (tui_show_frame_info): Update.
 398
 399 2019-08-13  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-winsource.h (struct tui_source_window_base)
 402         <set_exec_info_content>: Declare.
 403         (tui_set_exec_info_content): Don't declare.
 404         * tui/tui-winsource.c
 405         (tui_source_window_base::set_exec_info_content): Rename from
 406         tui_set_exec_info_content.
 407         (tui_update_exec_info): Update.
 408
 409 2019-08-13  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-winsource.h (struct tui_source_window_base)
 412         <show_source_content>: Declare.
 413         (tui_show_source_content): Don't declare.
 414         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 415         (tui_source_window_base::show_source_content): Rename from
 416         tui_show_source_content.
 417         (tui_source_window_base::refresh_all): Update.
 418         * tui/tui-layout.c (show_source_disasm_command)
 419         (show_source_or_disasm_and_command): Update.
 420
 421 2019-08-13  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-winsource.c (tui_erase_source_content)
 424         (tui_show_source_content, tui_source_window_base::refresh_all):
 425         Update.
 426         * tui/tui-wingeneral.h
 427         (tui_check_and_display_highlight_if_needed): Don't declare.
 428         * tui/tui-wingeneral.c
 429         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 430         check_and_display_highlight_if_needed.
 431         * tui/tui-win.c (tui_rehighlight_all)
 432         (tui_win_info::make_visible_with_new_height): Update.
 433         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 434         (tui_data_window::erase_data_content)
 435         (tui_data_window::display_all_data): Update.
 436         * tui/tui-data.h (struct tui_win_info)
 437         <check_and_display_highlight_if_needed>: Declare.
 438
 439 2019-08-13  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-win.c (tui_resize_all): Call
 442         tui_delete_invisible_windows.
 443         * tui/tui-layout.c (show_layout): Call
 444         tui_delete_invisible_windows.
 445         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 446         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 447
 448 2019-08-13  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 451         tui_add_win_to_layout.
 452
 453 2019-08-13  Tom Tromey  <tom@tromey.com>
 454
 455         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 456         * tui/tui-layout.c (tui_default_win_height): Now static.
 457
 458 2019-08-13  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 461         single switch.
 462         (show_source_disasm_command, show_source_or_disasm_and_command):
 463         Don't check current layout.
 464
 465 2019-08-13  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-wingeneral.c (make_all_visible): Remove.
 468         (tui_make_all_invisible): Simplify.
 469         * tui/tui-layout.c (tui_make_all_invisible): Move from
 470         tui-wingeneral.c; simplify.
 471         (show_layout): Hoist call to tui_make_all_invisible.
 472         (show_data): Don't call tui_make_all_invisible.
 473
 474 2019-08-13  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 477         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 478
 479 2019-08-13  Tom Tromey  <tom@tromey.com>
 480
 481         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 482         tui-data.c.
 483         (show_source_disasm_command, show_data)
 484         (show_source_or_disasm_and_command): Don't use
 485         tui_set_current_layout_to.
 486         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 487         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 488         tui-layout.c.
 489         (tui_set_current_layout_to): Remove.
 490
 491 2019-08-13  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-layout.c (tui_set_layout): Update.
 494         * tui/tui-data.h (struct tui_layout_def): Remove.
 495         (tui_layout_def): Don't declare.
 496         * tui/tui-data.c (layout_def): Remove.
 497         (tui_layout_def): Remove.
 498
 499 2019-08-13  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-winsource.h (struct tui_source_window_base)
 502         <clear_detail>: No longer "override".
 503         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 504         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 505         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 506         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 507         Remove.
 508         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 509
 510 2019-08-13  Tom Tromey  <tromey@adacore.com>
 511
 512         * tracepoint.c: Don't include readline.h or history.h.
 513
 514 2019-08-12  Tom Tromey  <tom@tromey.com>
 515
 516         * configure: Rebuild.
 517         * configure.ac: Check for readline 7.
 518         * NEWS: Mention readline 7 requirement.
 519         * README: Update.
 520
 521 2019-08-12  Tom Tromey  <tom@tromey.com>
 522
 523         * mingw-hdep.c (gdb_select): Remove readline hack.
 524
 525 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 526
 527         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 528         when the function fails.
 529
 530 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 531
 532         * s390-tdep.c (s390_type_align): New function.
 533         (s390_gdbarch_init): Set it as type_align gdbarch method.
 534
 535 2019-08-09  Tom de Vries  <tdevries@suse.de>
 536
 537         PR gdb/24591
 538         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 539         pc_low with relocation offset.
 540
 541 2019-08-07  Tom Tromey  <tromey@adacore.com>
 542
 543         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 544         (print_frame_args): Update.
 545         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 546         Update.
 547         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 548         * frame.h (struct frame_arg): Add initializers.
 549         <error>: Now a unique_xmalloc_ptr.
 550
 551 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 552
 553         * NEWS: Expand the Pointer Authentication entry.
 554         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 555         (aarch64_frame_unmask_lr): ... to this.
 556         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 557         Call aarch64_frame_unmask_lr.
 558         * frame.c (struct frame_info): Add "masked" variable.
 559         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 560         (fprint_frame): Check for masked pc.
 561         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 562         declarations.
 563         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 564         * stack.c (print_frame): Check for masked pc.
 565
 566 2019-08-06  Tom Tromey  <tom@tromey.com>
 567
 568         * stabsread.c (patch_block_stabs, read_one_struct_field)
 569         (read_enum_type): Use obstack_strndup.
 570         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 571         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 572         * dwarf2read.c (guess_full_die_structure_name)
 573         (anonymous_struct_prefix): Use obstack_strndup.
 574         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 575         * c-exp.y (yylex): Use obstack_strndup.
 576         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 577         (write_var_or_type): Use obstack_strndup.
 578
 579 2019-08-06  Tom Tromey  <tom@tromey.com>
 580
 581         * symfile.c (reread_symbols): Use obstack_strdup.
 582         * stabsread.c (read_type): Use obstack_strdup.
 583         * gdb_obstack.h (obstack_strdup): New overload.
 584         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 585         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 586         (dwarf2_canonicalize_name): Use obstack_strdup.
 587         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 588         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 589         Use obstack_strdup.
 590
 591 2019-08-06  Tom Tromey  <tom@tromey.com>
 592
 593         * gdb_obstack.h (obstack_strdup): Define.
 594         * gdb_obstack.c (obstack_strdup): Don't define.
 595
 596 2019-08-06  Tom Tromey  <tom@tromey.com>
 597
 598         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 599         obstack_strdup.
 600         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 601         obstack_strdup.
 602         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 603         * stabsread.c (common_block_start): Use obstack_strdup.
 604         * objfiles.c (set_objfile_main_name, objfile): Use
 605         obstack_strdup.
 606         * namespace.c (add_using_directive): Use obstack_strdup.
 607         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 608         * jit.c (finalize_symtab): Use obstack_strdup.
 609         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 610         (guess_partial_die_structure_name, partial_die_info::fixup)
 611         (dwarf2_name): Use obstack_strdup.
 612         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 613         obstack_strdup.
 614         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 615         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 616         obstack_strdup.
 617         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 618
 619 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 620
 621         * unittests/help-doc-selftests.c: New file.
 622         * Makefile.in: Add the new file.
 623
 624 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 625
 626         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 627         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 628         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 629         the trailing '.' is not output, and the first character is uppercased.
 630         (print_help_for_command): Update call to print_doc_line.
 631         (print_doc_of_command): Likewise.
 632         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 633         * cli/cli-option.c (append_indented_doc): Do not append newline.
 634         (build_help_option): Append newline after first appended_indented_doc
 635         only if a second call is done.
 636         (build_help): Append 2 new lines before each option, except the first
 637         one.
 638         * compile/compile.c (_initialize_compile): Add new lines after
 639         %OPTIONS%, when not at the end of the help.
 640         Change help doc or code
 641         producing the help doc to respect the invariants.
 642         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 643         Also removed the new line after 'Options:', as all other commands
 644         do not put an empty line between 'Options:' and the first option.
 645         * printcmd.c (_initialize_printcmd): Likewise.
 646         * stack.c (_initialize_stack): Likewise.
 647         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 648         incorrectly telling COMMAND is optional.
 649         * ada-lang.c (_initialize_ada_language): Change help doc or code
 650         producing the help doc to respect the invariants.
 651         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 652         * breakpoint.c (_initialize_breakpoint): Likewise.
 653         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 654         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 655         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 656         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 657         _initialize_cli_style): Likewise.
 658         * corelow.c (core_target_info): Likewise.
 659         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 660         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 661         * filesystem.c (_initialize_filesystem): Likewise.
 662         * frame.c (_initialize_frame): Likewise.
 663         * gnu-nat.c (add_task_commands): Likewise.
 664         * infcall.c (_initialize_infcall): Likewise.
 665         * infcmd.c (_initialize_infcmd): Likewise.
 666         * interps.c (_initialize_interpreter): Likewise.
 667         * language.c (_initialize_language): Likewise.
 668         * linux-fork.c (_initialize_linux_fork): Likewise.
 669         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 670         * maint.c (_initialize_maint_cmds): Likewise.
 671         * memattr.c (_initialize_mem): Likewise.
 672         * printcmd.c (_initialize_printcmd): Likewise.
 673         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 674         _RegEx): Likewise.
 675         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 676         * record-btrace.c (_initialize_record_btrace): Likewise.
 677         * record-full.c (_initialize_record_full): Likewise.
 678         * record.c (_initialize_record): Likewise.
 679         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 680         * regcache.c (_initialize_regcache): Likewise.
 681         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 682         _initialize_remote): Likewise.
 683         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 684         * serial.c (_initialize_serial): Likewise.
 685         * skip.c (_initialize_step_skip): Likewise.
 686         * source.c (_initialize_source): Likewise.
 687         * stack.c (_initialize_stack): Likewise.
 688         * symfile.c (_initialize_symfile): Likewise.
 689         * symtab.c (_initialize_symtab): Likewise.
 690         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 691         * top.c (init_main): Likewise.
 692         * tracefile-tfile.c (tfile_target_info): Likewise.
 693         * tracepoint.c (_initialize_tracepoint): Likewise.
 694         * tui/tui-win.c (_initialize_tui_win): Likewise.
 695         * utils.c (add_internal_problem_command): Likewise.
 696         * valprint.c (value_print_option_defs): Likewise.
 697
 698 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 699
 700         PR build/24886
 701         * configure.ac: Drop enable-libmcheck support.
 702         * configure, config.in: Rebuild.
 703         * libmcheck.m4: Remove.
 704         * acinclude.m4: Don't include it.
 705         * Makefile.in: Don't distribute it.
 706         * top.c (print_gdb_configuration): Don't mention it.
 707
 708 2019-08-06  Tom Tromey  <tom@tromey.com>
 709
 710         * utils.c (set_output_style): Sometimes pass stream to
 711         emit_style_escape.
 712         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 713         * record-btrace.c (btrace_insn_history): Update.
 714         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 715         method.
 716         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 717         Update initializers.
 718         <m_uiout>: New field.
 719         <m_di>: Move lower.
 720         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 721         Remove "uiout" parameter.
 722         (dump_insns): Update.
 723         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 724         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 725
 726 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 727
 728         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 729         (error_in_psymtab_expansion): Likewise.
 730         (lookup_symbol_via_quick_fns): Likewise.
 731         (basic_lookup_transparent_type_quick): Likewise.
 732         (basic_lookup_transparent_type_1): Likewise.
 733
 734 2019-08-06  Tom Tromey  <tromey@adacore.com>
 735
 736         * source.c (last_source_error): Now bool.
 737         (print_source_lines_base): Make "noprint" bool.  Only open
 738         source file when last_source_visited changes.
 739
 740 2019-08-06  Tom Tromey  <tromey@adacore.com>
 741
 742         * annotate.c (annotate_source_line): Use g_source_cache.
 743         * source-cache.c (source_cache::get_plain_source_lines): Change
 744         parameters.  Populate m_offset_cache.
 745         (source_cache::ensure): New method.
 746         (source_cache::get_line_charpos): New method.
 747         (extract_lines): Move lower.  Change parameters.
 748         (source_cache::get_source_lines): Move lower.
 749         * source-cache.h (class source_cache): Update comment.
 750         <get_line_charpos>: New method.
 751         <get_source_lines>: Update comment.
 752         <clear>: Clear m_offset_cache.
 753         <get_plain_source_lines>: Change parameters.
 754         <ensure>: New method
 755         <m_offset_cache>: New member.
 756         * source.c (forget_cached_source_info_for_objfile): Update.
 757         (info_source_command): Use g_source_cache.
 758         (find_source_lines, open_source_file_with_line_charpos): Remove.
 759         (print_source_lines_base, search_command_helper): Use g_source_cache.
 760         * source.h (open_source_file_with_line_charpos): Don't declare.
 761         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 762         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 763         Use g_source_cache.
 764
 765 2019-08-06  Tom Tromey  <tromey@adacore.com>
 766
 767         * source-cache.c (source_cache::get_plain_source_lines):
 768         Remove "first_line" and "last_line" parameters.
 769         (source_cache::get_source_lines): Cache plain text.
 770         * source-cache.h (class source_cache)
 771         <get_plain_source_lines>: Update.
 772
 773 2019-08-06  Tom Tromey  <tromey@adacore.com>
 774
 775         * source-cache.c (extract_lines): No longer a method.
 776         Changed type of parameter.  Include final newline.
 777         (selftests::extract_lines_test): New function.
 778         (_initialize_source_cache): Likewise.
 779         * source-cache.h (class source_cache)
 780         <extract_lines>: Don't declare.
 781
 782 2019-08-06  Tom Tromey  <tromey@adacore.com>
 783
 784         * breakpoint.c (init_breakpoint_sal): Update.
 785         (breakpoint): Update.
 786         * breakpoint.h (struct breakpoint) <filter>: Now a
 787         unique_xmalloc_ptr.
 788
 789 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 790
 791         * NEWS: Mention dictionary access on blocks.
 792         * python/py-block.c (blpy_getitem): New function.
 793         (block_object_as_mapping): New struct.
 794         (block_object_type): Use new struct for tp_as_mapping field.
 795
 796 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 797
 798         * objfiles.h (objfile): Add a comment describing partial symbols.
 799
 800 2019-08-05  Tom Tromey  <tromey@adacore.com>
 801
 802         * compile/compile.c (_initialize_compile): Use _(), not N_().
 803         * thread.c (_initialize_thread): Use _(), not N_().
 804         * stack.c (_initialize_stack): Use _(), not N_().
 805         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 806
 807 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 808
 809         * dwarf2read.c (struct dw2_symtab_iterator):
 810         <want_specific_block>: Remove.
 811         <block_index>: Change type to gdb::optional.
 812         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 813         change type of BLOCK_INDEX parameter to gdb::optional.
 814         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 815         (dw2_lookup_symbol): Don't pass argument for
 816         WANT_SPECIFIC_BLOCK.
 817         (dw2_expand_symtabs_for_function): Don't pass argument for
 818         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 819         (class dw2_debug_names_iterator)
 820         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 821         parameter, change BLOCK_INDEX type to gdb::optional.
 822         <m_want_specific_block>: Remove.
 823         <m_block_index>: Change type to gdb::optional.
 824         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 825         gdb::optional.  Re-write in function of gdb::optional.
 826         (dw2_debug_names_lookup_symbol): Don't pass argument for
 827         WANT_SPECIFIC_BLOCK.
 828         (dw2_debug_names_expand_symtabs_for_function): Don't pass
 829         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
 830         BLOCK_INDEX.
 831
 832 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 833
 834         * NEWS: Mention changes to "info sources" command.
 835
 836 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 837
 838         * symtab.c (filename_partial_match_opts): New struct type.
 839         (struct output_source_filename_data): New members
 840         regexp, c_regexp, partial_match.
 841         (output_source_filename): Use new members to decide to print file.
 842         (info_sources_option_defs): New variable.
 843         (make_info_sources_options_def_group, print_info_sources_header,
 844         info_sources_command_completer):
 845         New functions.
 846         (info_sources_command): Read new optional arguments.
 847         (_initialize_symtab): Update info sources help.
 848
 849 2019-08-02  Alexandre Oliva <oliva@adacore.com>
 850
 851         * ada-lang.c (exception_support_info_v0): Renamed from...
 852         (default_exception_support_info): ... this.  Create new
 853         definition for v1.
 854         (ada_has_this_exception_support): Look up catch_handlers_sym.
 855         (ada_exception_support_info_sniffer): Try v0 after default.
 856
 857 2019-08-01  Tom Tromey  <tromey@adacore.com>
 858
 859         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
 860         gdbarch.h.
 861
 862 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
 863
 864         * s12z-tdep.c: Fix include path for s12z-opc.h.
 865
 866 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
 867
 868         * NEWS: Require GNU make 3.82.
 869
 870 2019-07-16  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
 873         declare.
 874
 875 2019-07-30  Tom Tromey  <tromey@adacore.com>
 876
 877         * block.c (contained_in): Remove BLOCK_FUNCTION check.
 878
 879 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
 880
 881         * printcmd.c (print_address_symbolic): Print negative offsets.
 882         (build_address_symbolic): Force signed arithmetic when computing
 883         offset.
 884
 885 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
 886
 887         PR/24474: Add a function to lookup static variables.
 888         * NEWS: Mention this new function.
 889         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
 890         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
 891         * python/python.c (python_GdbMethods): Add new function.
 892
 893 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
 894
 895         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
 896         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
 897         (objfpy_lookup_static_symbol): New function.
 898         (objfile_object_methods): Add new functions.
 899
 900 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 901
 902         * NEWS: Mention 'set|show print frame-info'.  Mention new
 903         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
 904         backtrace argument.  Mention that python frame filtering code
 905         is now consistent with what 'backtrace' command prints.
 906
 907 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 908
 909         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
 910         comments.
 911         (print_frame_info_auto, print_frame_info_source_line,
 912         print_frame_info_location, print_frame_info_source_and_location,
 913         print_frame_info_location_and_address, print_frame_info_short_location):
 914         New declarations.
 915         (struct frame_print_options): New member print_frame_info.
 916         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
 917         * stack.h (get_user_print_what_frame_info): New declaration.
 918         (frame_show_address): New declaration.
 919         * stack.c (print_frame_arguments_choices): New value 'presence'.
 920         (print_frame_info_auto, print_frame_info_source_line,
 921         print_frame_info_location, print_frame_info_source_and_location,
 922         print_frame_info_location_and_address, print_frame_info_short_location,
 923         print_frame_info_choices, print_frame_info_print_what): New definitions.
 924         (print_frame_args): Only print dots for args if print frame-arguments
 925         is 'presence'.
 926         (frame_print_option_defs): New element for "frame-info".
 927         (get_user_print_what_frame_info): New function.
 928         (frame_show_address): Make non static.  Move comment to stack.h.
 929         (print_frame_info_to_print_what): New function.
 930         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
 931         to decide what to print.
 932         (backtrace_command_1): Handle the new print_frame_arguments_presence
 933         value.
 934         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
 935         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
 936         (py_print_frame): In non-mi mode, use LOCATION as default for
 937         print_what, similarly to frame information printed directly by
 938         backtrace command. Handle frame-info user option in non MI mode.
 939
 940 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 941
 942         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
 943         Add case for debugging 32-bit target on 64-bit host.  Revise
 944         comment.
 945
 946 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 947
 948         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
 949         instead of find_function_entry_range_from_pc.
 950
 951 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
 952
 953         * stack.c (find_frame_funname): Remove code which preferred
 954         minsym over symtab sym in "certain pathological cases".
 955
 956         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
 957         parameter.  Change type of "do_demangle" to bool.
 958         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 959         Pass suitable "prefer_sym_over_minsym" flag to
 960         build_address_symbolic().  Don't output "+" for negative offsets.
 961         * printcmd.c (print_address_symbolic): Update invocation of
 962         build_address_symbolic to include a "prefer_sym_over_minsym"
 963         flag.
 964         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
 965         Restrict cases in which use of minimal symbol is preferred to that
 966         of a found symbol.  Update comments.
 967
 968         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
 969         for entry pc when entry pc is out of range for that FDE.
 970
 971 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
 972
 973         PR gdb/24839:
 974         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
 975         type.
 976
 977 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
 978
 979         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 980         this function's Python signature.
 981
 982
 983 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 984
 985         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 986         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 987         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 988         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 989         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 990
 991
 992 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 993
 994         * h8300-tdep.c (h8300_register_name_common): New.
 995         h8300_register_name): Use h8300_register_name_common.
 996         (h8300s_register_name): Likewise.
 997         (h8300sx_register_name): Likewise.
 998         (h8300h_register_nam): New.
 999         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1000
1001
1002 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1003
1004         * arm-tdep.c (arm_skip_cmse_entry): New function.
1005         (arm_is_sgstubs_section): New function.
1006         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1007
1008 2019-07-22  Tom Tromey  <tom@tromey.com>
1009
1010         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1011         Don't self-assign.
1012
1013 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1014
1015         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1016         type_print.
1017
1018 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1019
1020         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1021         so that GDB doesn't match any msymbols when searching in the
1022         TYPES_DOMAIN.
1023         (print_symbol_info): Print using typedef_print or type_print based
1024         on the type of the symbol.  Add updated FIXME comment moved from...
1025         (_initialize_symtab): ... move and update FIXME comment to above.
1026
1027 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1028
1029         * NEWS: Mention adding -q option to "info types".
1030         * symtab.c (struct info_types_options): New struct.
1031         (info_types_options_defs): New variable.
1032         (make_info_types_options_def_group): New function.
1033         (info_types_command): Use gdb::option framework to parse options.
1034         (info_types_command_completer): New function.
1035         (_initialize_symtab): Extend the help text on "info types" and
1036         register command completer.
1037
1038 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1039
1040         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1041         (lookup_symbol_in_objfile): Change int to block_enum and add a
1042         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1043
1044 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1045
1046         * MAINTAINERS (Write After Approval): Add self.
1047
1048 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1051         instruction to the dummy code region.
1052
1053 2019-07-19  Tom Tromey  <tromey@adacore.com>
1054
1055         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1056         (ARGSUSED, PARAMS, __func__): Remove rules.
1057
1058 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1059
1060         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1061         * features/arm/arm-with-iwmmxt.c: Remove.
1062         * features/arm/arm-with-iwmmxt.xml: Remove.
1063         * features/arm/arm-with-m-fpa-layout.c: Remove.
1064         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1065         * features/arm/arm-with-m-vfp-d16.c: Remove.
1066         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1067         * features/arm/arm-with-m.c: Remove.
1068         * features/arm/arm-with-m.xml: Remove.
1069         * features/arm/arm-with-neon.c: Remove.
1070         * features/arm/arm-with-neon.xml: Remove.
1071         * features/arm/arm-with-vfpv2.c: Remove.
1072         * features/arm/arm-with-vfpv2.xml: Remove.
1073         * features/arm/arm-with-vfpv3.c: Remove.
1074         * features/arm/arm-with-vfpv3.xml: Remove.
1075
1076 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1077
1078         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1079
1080 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1081
1082         * arch/aarch32.c (aarch32_create_target_description): Create
1083         target descriptions using features.
1084         * arch/arm.c (arm_create_target_description)
1085         (arm_create_mprofile_target_description): Likewise.
1086         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1087
1088 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1089
1090         * Makefile.in: Add new files.
1091         * aarch32-tdep.c: New file.
1092         * aarch32-tdep.h: New file.
1093         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1094         Call aarch32_read_description.
1095         * arch/aarch32.c: New file.
1096         * arch/aarch32.h: New file.
1097         * arch/arm.c (arm_create_target_description)
1098         (arm_create_mprofile_target_description): New function.
1099         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1100         (arm_create_target_description)
1101         (arm_create_mprofile_target_description): New declaration.
1102         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1103         read_description functions.
1104         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1105         Likewise.
1106         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1107         * arm-tdep.c (tdesc_arm_list): New variable.
1108         (arm_register_g_packet_guesses): Call create description functions.
1109         (arm_read_description) (arm_read_mprofile_description): New
1110         function.
1111         * arm-tdep.h (arm_read_description)
1112         (arm_read_mprofile_description): Add declaration.
1113         * configure.tgt: Add new files.
1114
1115 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1116
1117         * top.c (new_ui_command): Open specified terminal just once.
1118
1119 2019-07-18  Tom Tromey  <tromey@adacore.com>
1120
1121         * symtab.c (main_name): Constify return type.
1122         * symfile.c (set_initial_language): Update.
1123         * symtab.h (main_name): Constify return type.
1124
1125 2019-07-17  Tom Tromey  <tom@tromey.com>
1126
1127         * tui/tui-winsource.c (tui_update_source_window)
1128         (tui_update_source_window_as_is)
1129         (tui_update_source_windows_with_line): Remove return.
1130         * tui/tui-disasm.c (tui_show_disassem)
1131         (tui_show_disassem_and_update_source): Remove return.
1132         * tui/tui.c (tui_reset): Remove return.
1133         * tui/tui-wingeneral.c
1134         (tui_check_and_display_highlight_if_needed): Remove return.
1135
1136 2019-07-17  Tom Tromey  <tom@tromey.com>
1137
1138         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1139
1140 2019-07-17  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-winsource.h (struct tui_exec_info_window)
1143         (struct tui_source_window_base): Move from tui-data.h.
1144         * tui/tui-winsource.c: Move many method definitions from
1145         elsewhere.  Remove "structuring" comments.
1146         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1147         (tui_source_window_base::refresh_window): Move to
1148         tui-winsource.c.
1149         * tui/tui-win.c (tui_source_window_base::refresh_all)
1150         (tui_source_window_base::update_tab_width)
1151         (tui_source_window_base::set_new_height)
1152         (tui_source_window_base::do_make_visible_with_new_height): Move to
1153         tui-winsource.c.
1154         * tui/tui-source.h: Update.
1155         * tui/tui-source.c (tui_source_window_base::reset): Move to
1156         tui-winsource.c.
1157         * tui/tui-disasm.h: Update.
1158         * tui/tui-data.h (struct tui_exec_info_window): Move to
1159         tui-winsource.h.
1160         (struct tui_source_window_base): Likewise.
1161         * tui/tui-data.c (tui_source_window_base::clear_detail)
1162         (tui_source_window_base, ~tui_source_window_base): Move to
1163         tui-winsource.c.
1164
1165 2019-07-17  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-win.c (tui_resize_all)
1168         (tui_source_window_base::update_tab_width)
1169         (tui_adjust_win_heights): Update.
1170         (tui_win_info::make_invisible_and_set_new_height): Rename from
1171         make_invisible_and_set_new_height.
1172         * tui/tui-data.h (struct tui_win_info)
1173         <make_invisible_and_set_new_height>: New method.
1174
1175 2019-07-17  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui.c: Update.
1178         * tui/tui-source.h (struct tui_source_window): Move from
1179         tui-data.h.
1180         * tui/tui-layout.c: Update.
1181         * tui/tui-disasm.c: Update.
1182         * tui/tui-data.h (struct tui_source_window): Move to
1183         tui-source.h.
1184
1185 2019-07-17  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1188         tui-data.h.
1189         * tui/tui-data.h (struct tui_disasm_window): Move to
1190         tui-disasm.h.
1191
1192 2019-07-17  Tom Tromey  <tom@tromey.com>
1193
1194         * tui/tui-regs.h (struct tui_data_item_window): Move from
1195         tui-data.h.
1196         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1197         * tui/tui-data.h (struct tui_data_item_window): Move to
1198         tui-regs.h.
1199         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1200
1201 2019-07-17  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui.c: Update.
1204         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1205         (tui_cmd_window::max_height): Move to tui-command.c.
1206         * tui/tui-layout.c: Update.
1207         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1208         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1209         tui-command.c.
1210         * tui/tui-command.h (struct tui_cmd_window): Move from
1211         tui-data.h.
1212         * tui/tui-command.c: Remove "structuring" comments.
1213         (tui_cmd_window::clear_detail)
1214         (tui_cmd_window::do_make_visible_with_new_height)
1215         (tui_cmd_window::max_height): Move from elsewhere.
1216
1217 2019-07-17  Tom Tromey  <tom@tromey.com>
1218
1219         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1220         Now static.
1221         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1222         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1223
1224 2019-07-17  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui.c: Update.
1227         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1228         tui-regs.c.
1229         * tui/tui-windata.h: Remove file.
1230         * tui/tui-windata.c: Remove file.
1231         * tui/tui-win.c (tui_data_window::set_new_height)
1232         (tui_data_window::do_make_visible_with_new_height): Move to
1233         tui-regs.c.
1234         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1235         * tui/tui-regs.c: Remove "structuring" comments.
1236         (tui_data_window::first_data_item_displayed)
1237         (tui_data_window::delete_data_content_windows)
1238         (tui_data_window::erase_data_content)
1239         (tui_data_window::display_all_data)
1240         (tui_data_window::refresh_all)
1241         (tui_data_window::do_scroll_vertical)
1242         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1243         (tui_data_window::do_make_visible_with_new_height)
1244         (tui_data_window::refresh_window): Move from elsewhere.
1245         (_initialize_tui_regs): Move to end of file.
1246         * tui/tui-layout.c: Update.
1247         * tui/tui-hooks.c: Update.
1248         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1249         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1250         tui-regs.c.
1251         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1252
1253 2019-07-17  Tom Tromey  <tom@tromey.com>
1254
1255         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1256         seen.
1257
1258 2019-07-17  Tom Tromey  <tom@tromey.com>
1259
1260         * tui/tui-win.c (tui_source_window_base::set_new_height)
1261         (tui_source_window_base::do_make_visible_with_new_height): Use
1262         m_has_locator field directly.
1263         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1264         method.
1265         (struct tui_source_window_base) <has_locator>: Likewise.
1266
1267 2019-07-17  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1270         Don't declare.
1271         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1272         Remove.
1273         * tui/tui-win.c (tui_source_window_base::set_new_height)
1274         (tui_source_window_base::set_new_height)
1275         (make_invisible_and_set_new_height)
1276         (tui_source_window_base::do_make_visible_with_new_height)
1277         (tui_source_window_base::do_make_visible_with_new_height):
1278         Update.
1279         * tui/tui-layout.c (show_source_disasm_command, show_data)
1280         (show_source_or_disasm_and_command): Update.
1281         * tui/tui-layout.c (show_layout): Update.
1282
1283 2019-07-17  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-layout.c (make_data_window): Remove.
1286         (show_data): Unify creation and re-initialization cases.
1287
1288 2019-07-17  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-layout.c (make_source_window, make_disasm_window):
1291         Remove.
1292         (show_data): Unify creation and re-initialization cases.
1293
1294 2019-07-17  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-layout.c (make_command_window): Remove.
1297         (show_source_disasm_command, show_source_or_disasm_and_command):
1298         Unify creation and re-initialization cases.
1299
1300 2019-07-17  Tom Tromey  <tom@tromey.com>
1301
1302         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1303         creation and re-initialization cases.
1304
1305 2019-07-17  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui-regs.c (tui_get_register): Return void.
1308
1309 2019-07-17  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1312         Simplify.
1313
1314 2019-07-17  Tom Tromey  <tom@tromey.com>
1315
1316         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1317         resetting.
1318
1319 2019-07-17  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1322         * tui/tui-regs.c (tui_reg_layout): New function.
1323         (tui_show_registers, tui_reg_command): Use it.
1324         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1325         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1326         parameters.
1327         (tui_layout_command): Remove.
1328
1329 2019-07-17  Tom Tromey  <tom@tromey.com>
1330
1331         * tui/tui-layout.h (tui/tui-layout): Return void.
1332         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1333
1334 2019-07-17  Tom Tromey  <tom@tromey.com>
1335
1336         * tui/tui-layout.c (show_source_disasm_command, show_data):
1337         Update.
1338         (reset_locator): Remove.
1339         (show_source_or_disasm_and_command): Update.
1340
1341 2019-07-17  Tom Tromey  <tom@tromey.com>
1342
1343         * tui/tui-source.c (tui_source_window_base::reset): Remove
1344         win_type parameter.
1345         * tui/tui-layout.c (make_command_window, make_source_window)
1346         (make_disasm_window, make_data_window)
1347         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1348         (reset_locator, show_source_or_disasm_and_command): Update.
1349         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1350         win_type parameter.
1351         (struct tui_source_window_base) <reset>: Likewise.
1352
1353 2019-07-17  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-layout.c (show_source_disasm_command): Use
1356         reset_locator.
1357         (reset_locator): New function.
1358         (init_and_make_win): Remove.
1359         (show_source_or_disasm_and_command): Use reset_locator.
1360
1361 2019-07-17  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1364         condition.
1365         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1366         Remove condition.
1367         * tui/tui-source.c (tui_source_window_base::reset): New method.
1368         * tui/tui-layout.c (make_command_window): Don't call
1369         init_and_make_win.
1370         (make_source_window, make_disasm_window): Don't call
1371         make_source_or_disasm_window.
1372         (make_data_window): Don't call init_and_make_win.  Change calling
1373         convention.
1374         (show_source_disasm_command, show_data): Simplify.
1375         (make_source_or_disasm_window): Remove.
1376         (show_source_or_disasm_and_command): Simplify.
1377         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1378         (struct tui_source_window_base) <reset>: Likewise.
1379         <execution_info>: Remove initializer.
1380         * tui/tui-data.c (tui_source_window_base): Initialize
1381         execution_info.
1382
1383 2019-07-17  Tom Tromey  <tom@tromey.com>
1384
1385         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1386         variable.
1387
1388 2019-07-17  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui.c (tui_rl_other_window): Update.
1391         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1392         superclass method first.  Always iterate over regs_content.
1393         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1394         method.
1395         * tui/tui-win.c (tui_set_focus_command): Update.
1396
1397 2019-07-17  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-win.c (tui_set_focus_command): Rename from
1400         tui_set_focus.  Call tui_enable.
1401         (tui_set_focus_command): Remove.
1402
1403 2019-07-17  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1406         refresh_window.
1407         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1408         touchwin.
1409         (tui_data_window::refresh_window): Call refresh_window on data
1410         items.  Always call superclass refresh_window.
1411         (tui_win_info::refresh): Remove.
1412         (tui_source_window_base::refresh_window): Update.
1413         (tui_refresh_all): Update.
1414         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1415         refresh_window.
1416         (show_source_or_disasm_and_command): Likewise.
1417         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1418         (struct tui_source_window_base) <refresh>: Likewise.
1419
1420 2019-07-17  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-winsource.c (tui_clear_source_content)
1423         (tui_show_source_content): Update.
1424         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1425         whether content is empty.
1426         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1427         Remove.
1428
1429 2019-07-17  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1432         window's contents.
1433         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1434         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1435
1436 2019-07-17  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1439         (struct tui_data_item_window): Update.
1440
1441 2019-07-17  Tom Tromey  <tom@tromey.com>
1442
1443         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1444         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1445         defines.
1446
1447 2019-07-17  Tom Tromey  <tom@tromey.com>
1448
1449         * tui/tui-winsource.h (tui_erase_source_content)
1450         (tui_clear_source_content): Remove "display_prompt" parameter.
1451         * tui/tui-winsource.c (tui_update_source_window_as_is)
1452         (tui_update_source_windows_with_addr): Update.
1453         (tui_clear_source_content): Remove "display_prompt" parameter.
1454         (tui_erase_source_content): Likewise.  Simplify.
1455         (tui_show_source_content): Update.
1456         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1457         * tui/tui-stack.c (tui_show_frame_info): Update.
1458         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1459         Remove defines.
1460
1461 2019-07-17  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1464         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1465         parameter.
1466         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1467         parameter.
1468
1469 2019-07-17  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.c (tui_clear_source_content)
1472         (tui_show_source_content, tui_show_exec_info_content)
1473         (tui_clear_exec_info_content): Update.
1474         * tui/tui-stack.c (tui_show_locator_content): Update.
1475         (tui_show_frame_info): Update.
1476         * tui/tui-source.h (tui_source_window): Don't declare.
1477         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1478         from tui_source_is_displayed.
1479         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1480         Remove field.
1481         (struct tui_source_window_base) <content_in_use>: New field.  Now
1482         bool.
1483         (struct tui_source_window) <showing_source_p>: New method.
1484         (TUI_SRC_WIN): Change cast.
1485         * tui/tui-data.c (tui_initialize_static_data): Update.
1486
1487 2019-07-17  Tom Tromey  <tom@tromey.com>
1488
1489         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1490         location_matches_p.
1491         * tui/tui-source.c (tui_source_window::location_matches_p): New
1492         method.
1493         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1494         method.
1495         * tui/tui-data.h (struct tui_source_window_base)
1496         <location_matches_p>: New method.
1497         (struct tui_source_window, struct tui_disasm_window)
1498         <location_matches_p>: Likewise.
1499
1500 2019-07-17  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-win.c (tui_set_win_height_command): Rename from
1503         tui_set_win_height.
1504         (tui_set_win_height_command): Remove.
1505
1506 2019-07-17  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui-source.c (tui_source_window): New constructor.  Add
1509         observer.
1510         (~tui_source_window): New destructor.
1511         (tui_source_window::style_changed): New method.
1512         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1513         (tui_attach_detach_observers): Update.
1514         * tui/tui-data.h (struct tui_source_window): Make constructor not
1515         inline.  Add destructor.
1516         (struct tui_source_window) <style_changed>: New method.
1517         <m_observable>: New member.
1518
1519 2019-07-17  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1522         * tui/tui-win.c (tui_resize_all): Fix typo.
1523
1524 2019-07-17  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1527         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1528         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1529         * tui/tui-win.c (window_name_completer): Use foreach.
1530         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1531         (update_tab_width): Likewise.
1532         * tui/tui-layout.c (show_layout): Update.
1533         * tui/tui-data.h (class tui_window_iterator): New.
1534         (struct all_tui_windows): New.
1535         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1536
1537 2019-07-17  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1540         parameter.  Don't reference globals.
1541         (tui_reg_command): Update.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-regs.c (tui_show_registers): Simplify.
1546
1547 2019-07-17  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui-regs.c (tui_show_registers): Update.
1550         (tui_show_register_group): Add win_info parameter.
1551
1552 2019-07-17  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1555         Rename from tui_display_reg_element_at_line.
1556         (tui_data_window::display_registers_from_line): Update.
1557         * tui/tui-data.h (struct tui_data_window)
1558         <display_reg_element_at_line>: New method.
1559
1560 2019-07-17  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-regs.h (tui_display_registers_from)
1563         (tui_display_registers_from_line): Don't declare.
1564         * tui/tui-windata.c (tui_data_window::display_all_data)
1565         (tui_data_window::refresh_all)
1566         (tui_data_window::do_scroll_vertical): Update.
1567         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1568         from tui_display_registers_from.
1569         (tui_display_reg_element_at_line): Update.
1570         (tui_data_window::display_registers_from_line): Rename from
1571         tui_display_registers_from_line.
1572         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1573         display_registers_from_line>: New methods.
1574
1575 2019-07-17  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1578         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1579         from tui_erase_data_content.
1580         (tui_data_window::display_all_data)
1581         (tui_data_window::refresh_all)
1582         (tui_data_window::do_scroll_vertical): Update.
1583         * tui/tui-regs.c (tui_show_registers): Update.
1584         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1585         New method.
1586
1587 2019-07-17  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1590         declare.
1591         * tui/tui-windata.c
1592         (tui_data_window::delete_data_content_windows): Rename from
1593         tui_delete_data_content_windows.
1594         (tui_data_window::display_all_data)
1595         (tui_data_window::do_scroll_vertical): Update.
1596         * tui/tui-data.h (struct tui_data_window)
1597         <delete_data_content_windows>: New method.
1598
1599 2019-07-17  Tom Tromey  <tom@tromey.com>
1600
1601         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1602         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1603
1604 2019-07-17  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1607         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1608         from tui_display_all_data.
1609         * tui/tui-win.c
1610         (tui_data_window::do_make_visible_with_new_height): Update.
1611         * tui/tui-regs.c (tui_show_registers): Update.
1612         * tui/tui-layout.c (tui_set_layout): Update.
1613         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1614         method.
1615
1616 2019-07-17  Tom Tromey  <tom@tromey.com>
1617
1618         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1619         * tui/tui-windata.c (tui_display_data_from): Remove.
1620         (tui_data_window::refresh_all): Update.
1621
1622 2019-07-17  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1625         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1626         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1627         tui_display_registers_from_line.
1628         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1629         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1630         "force_display" parameter.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1635         declare.
1636         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1637         Rename from tui_first_reg_element_no_inline.
1638         (tui_display_reg_element_at_line)
1639         (tui_display_registers_from_line): Update.
1640         * tui/tui-data.h (struct tui_data_window)
1641         <first_reg_element_no_inline>: New method.
1642
1643 2019-07-17  Tom Tromey  <tom@tromey.com>
1644
1645         * tui/tui-windata.c (tui_display_data_from)
1646         (tui_data_window::do_scroll_vertical): Update.
1647         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1648         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1649         Rename from tui_line_from_reg_element_no.
1650         (tui_display_registers_from_line): Update.
1651         * tui/tui-data.h (struct tui_data_window)
1652         <line_from_reg_element_no>: New method.
1653
1654 2019-07-17  Tom Tromey  <tom@tromey.com>
1655
1656         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1657         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1658         tui_last_regs_line_no.
1659         (tui_display_reg_element_at_line)
1660         (tui_display_registers_from_line): Update.
1661         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1662         method.
1663
1664 2019-07-17  Tom Tromey  <tom@tromey.com>
1665
1666         PR tui/24722:
1667         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1668         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1669         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1670         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1671         (tui_update_breakpoint_info): Likewise.
1672         * tui/tui-hooks.c (tui_event_create_breakpoint)
1673         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1674         Update.
1675
1676 2019-07-17  Tom Tromey  <tom@tromey.com>
1677
1678         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1679
1680 2019-07-17  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-winsource.c (tui_update_source_window_as_is)
1683         (tui_update_source_windows_with_addr): Update.
1684         * tui/tui-source.h (tui_set_source_content)
1685         (tui_show_symtab_source): Add "win_info" parameter.
1686         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1687         parameter.
1688         (tui_show_symtab_source): Likewise.
1689
1690 2019-07-17  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-wingeneral.c
1693         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1694
1695 2019-07-17  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1698         (struct tui_cmd_window) <can_scroll>: New method.
1699         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1700         method.
1701
1702 2019-07-17  Tom Tromey  <tromey@adacore.com>
1703
1704         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1705         do_field_signed>: Rename.  Change type of "value".
1706         * ui-out.c (ui_out::field_signed): Rename from field_int.
1707         Change type of "value".
1708         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1709         type of "value".
1710         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1711         do_field_int.  Change type of "value".
1712         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1713         do_field_int.  Change type of "value".
1714         * tracepoint.c (trace_status_mi, tfind_1)
1715         (print_one_static_tracepoint_marker): Update.
1716         * thread.c (print_thread_info_1, print_selected_thread_frame):
1717         Update.
1718         * stack.c (print_frame, print_frame_info): Update.
1719         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1720         Update.
1721         * source.c (print_source_lines_base): Update.
1722         * skip.c (info_skip_command): Update.
1723         * record-btrace.c (btrace_ui_out_decode_error)
1724         (btrace_call_history_src_line): Update.
1725         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1726         Update.
1727         * progspace.c (print_program_space): Update.
1728         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1729         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1730         do_field_int.  Change type of "value".
1731         * mi/mi-out.c (mi_ui_out::do_table_begin)
1732         (mi_ui_out::do_table_header): Update.
1733         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1734         type of "value".
1735         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1736         (mi_cmd_data_list_changed_registers, output_register)
1737         (mi_cmd_data_read_memory, mi_load_progress)
1738         (mi_cmd_trace_frame_collected): Update.
1739         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1740         Update.
1741         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1742         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1743         (mi_cmd_var_list_children, varobj_update_one): Update.
1744         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1745         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1746         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1747         * inferior.c (print_inferior): Update.
1748         * gdb_bfd.c (print_one_bfd): Update.
1749         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1750         Update.
1751         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1752         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1753         do_field_int.  Change type of "value".
1754         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1755         do_field_int.  Change type of "value".
1756         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1757         (print_one_breakpoint_location, print_it_catch_fork)
1758         (print_one_catch_fork, print_it_catch_vfork)
1759         (print_one_catch_vfork, print_it_catch_solib)
1760         (print_it_catch_exec, print_it_ranged_breakpoint)
1761         (print_mention_watchpoint, print_mention_masked_watchpoint)
1762         (bkpt_print_it, update_static_tracepoint): Update.
1763         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1764         * break-catch-syscall.c (print_it_catch_syscall): Update.
1765         * ada-tasks.c (print_ada_task_info): Update.
1766         * ada-lang.c (print_it_exception, print_mention_exception):
1767         Update.
1768
1769 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1770
1771         PR breakpoints/24541
1772         * gdbarch.c: Regenerate.
1773         * gdbarch.h: Regenerate.
1774         * gdbarch.sh: Adjust return type and parameter types for
1775         'stap_adjust_register'.
1776         (i386_stap_adjust_register): Adjust signature and return new
1777         register name.
1778         * stap-probe.c (stap_parse_register_operand): Adjust use of
1779         'gdbarch_stap_adjust_register'.
1780
1781 2019-07-17  Tom Tromey  <tromey@adacore.com>
1782
1783         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1784         declare VEC.
1785         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1786         std::vector.
1787         (struct s390_process_info): Add initializers.
1788         (s390_add_process): Use new.
1789         (s390_linux_nat_target::low_forget_process): Use delete.
1790         (s390_linux_nat_target::low_new_fork)
1791         (s390_linux_nat_target::stopped_by_watchpoint)
1792         (s390_linux_nat_target::low_prepare_to_resume)
1793         (s390_linux_nat_target::insert_watchpoint)
1794         (s390_linux_nat_target::insert_hw_breakpoint)
1795         (s390_linux_nat_target::remove_watchpoint)
1796         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1797
1798 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1799
1800         * aarch64-fbsd-nat.c: Include regcache.h.
1801         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1802         argument.
1803         (aarch64_fbsd_nat_target::fetch_registers)
1804         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1805         variable.
1806         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1807
1808 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1809
1810         * fbsd-nat.c: Include gdbarch.h.
1811
1812 2019-07-15  Tom Tromey  <tromey@adacore.com>
1813
1814         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1815
1816 2019-07-15  Tom Tromey  <tromey@adacore.com>
1817
1818         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1819         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1820         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1821         * cli-out.c (cli_ui_out::do_field_int): New method.
1822         * ui-out.c (ui_out::field_unsigned): New method.
1823         * symfile.c (generic_load): Use field_unsigned.
1824         (print_transfer_performance): Likewise.
1825         * record-btrace.c (ui_out_field_uint): Remove.
1826         (btrace_call_history_insn_range, btrace_call_history): Use
1827         field_unsigned.
1828         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
1829         field_unsigned.
1830         * ui-out.h (class ui_out) <field_unsigned>: New method.
1831         <do_field_unsigned>: Likewise.
1832
1833 2019-07-15  Tom Tromey  <tromey@adacore.com>
1834
1835         * mi/mi-main.c (list_available_thread_groups): Use field_string.
1836         * mi/mi-interp.c (mi_memory_changed): Use field_string.
1837         * target.c (flash_erase_command): Use field_string.
1838         * infrun.c (print_signal_received_reason): Use field_string.
1839         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
1840         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
1841         field_string.
1842         * ada-tasks.c (print_ada_task_info): Use field_string.
1843
1844 2019-07-15  Tom Tromey  <tromey@adacore.com>
1845
1846         * target.c (flash_erase_command): Use field_core_addr.
1847         * symfile.c (generic_load): Use field_core_addr.
1848         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
1849         Use field_core_addr.
1850         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
1851         field_core_addr.
1852
1853 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
1856         value if its desired type is smaller than a CORE_ADDR and signed.
1857
1858 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1859
1860         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
1861         of changes to field names, and use new is_reference field to
1862         decide if a property is a reference or not.
1863         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
1864         field.
1865         (struct dwarf2_property_baton): Update header comment, rename
1866         'referenced_type' to 'property_type' and update comments.
1867         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
1868         default property type, store in property baton, update to take
1869         accound of renamed field.
1870         (read_func_scope): Update call to attr_to_dynamic_prop.
1871         (read_array_type): Likewise.
1872         (dwarf2_per_cu_addr_sized_int_type): New function.
1873         (read_subrange_index_type): Move type finding code to
1874         dwarf2_per_cu_addr_sized_int_type.
1875         (read_subrange_type): Update calls to attr_to_dynamic_prop.
1876         (dwarf2_per_cu_addr_type): New function.
1877         (set_die_type): Update calls to attr_to_dynamic_prop.
1878
1879 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1880
1881         * dwarf2read.c (read_subrange_index_type): New function.
1882         (read_subrange_type): Move code into new function and call it.
1883         * gdbtypes.c (create_range_type): Add some asserts.
1884
1885 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1886
1887         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1888         update return statements.
1889         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1890         declaration, and update comment to match.
1891         * gdbtypes.c (resolve_dynamic_array): Update call to
1892         dwarf2_evaluate_property to match new return type.
1893
1894 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * valarith.c (value_subscripted_rvalue): Change lowerbound
1897         parameter type from int to LONGEST.
1898         * value.h (value_subscripted_rvalue): Likewise in declaration.
1899
1900 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * cli/cli-utils.c (info_print_command_completer): New function.
1903         * cli/cli-utils.h: Add 'completer.h' include, and forward
1904         declaration for 'struct cmd_list_element'.
1905         (info_print_command_completer): Declare.
1906         * stack.c (_initialize_stack): Add completer for 'info locals' and
1907         'info args'.
1908         * symtab.c (_initialize_symtab): Add completer for 'info
1909         variables' and 'info functions'.
1910         * NEWS: Mention completion for additional info commands.
1911
1912 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * cli/cli-utils.c (extract_info_print_args): Delete.
1915         (extract_arg_maybe_quoted): Delete.
1916         (info_print_options_defs): New variable.
1917         (make_info_print_options_def_group): New function.
1918         (extract_info_print_options): Define new function.
1919         * cli/cli-utils.h (extract_info_print_args): Delete.
1920         (struct info_print_options): New structure.
1921         (extract_info_print_options): Declare new function.
1922         * stack.c (info_locals_command): Update to use new
1923         extract_info_print_options, also add a header comment.
1924         (info_args_command): Likewise.
1925         * symtab.c (info_variables_command): Likewise.
1926         (info_functions_command): Likewise.
1927
1928 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1929
1930         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1931         to extract string arguments.
1932         * common/common-utils.c (extract_string_maybe_quoted): New function.
1933         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1934
1935 2019-07-11  Tom Tromey  <tromey@adacore.com>
1936
1937         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1938         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1939         * top.h (gdbinit): Don't declare.
1940         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1941         into...
1942         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1943         * top.c (gdb_init): Don't call init_cli_cmds.
1944         (gdbinit): Remove.
1945         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1946
1947 2019-07-11  Tom Tromey  <tromey@adacore.com>
1948
1949         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1950         after it has been moved.
1951
1952 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1953
1954         * valops.c (value_must_coerce_to_target): Change return type to
1955         bool.
1956         * value.h (value_must_coerce_to_target): Likewise.
1957
1958 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1959
1960         * breakpoint.c (is_hardware_watchpoint): Remove
1961         forward-declaration.
1962         (is_masked_watchpoint): Change return type to bool.
1963         (is_tracepoint): Likewise.
1964         (is_breakpoint): Likewise.
1965         (is_hardware_watchpoint): Likewise.
1966         (is_watchpoint): Likewise.
1967         (is_no_memory_software_watchpoint): Likewise.
1968         (is_catchpoint): Likewise.
1969         (breakpoint_1): Make FILTER parameter's return type bool.
1970         is_masked_watchpoint): Change return type to bool.
1971         (save_breakpoints): Make FILTER parameter's return type bool.
1972         * breakpoint.h (is_breakpoint): Change return type to bool.
1973         (is_watchpoint): Likewise.
1974         (is_catchpoint): Likewise.
1975         (is_tracepoint): Likewise.
1976
1977 2019-07-10  Tom Tromey  <tom@tromey.com>
1978
1979         * defs.h: Don't include gdbarch.h.
1980         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1981         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1982         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1983         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1984         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1985         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1986         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1987         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1988         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1989         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1990         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1991         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1992         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1993         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1994         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1995         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1996         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1997         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1998         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1999         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2000         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2001         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2002         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2003         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2004         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2005         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2006         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2007
2008 2019-07-10  Tom Tromey  <tromey@adacore.com>
2009
2010         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2011         * breakpoint.c (init_ada_exception_breakpoint): Register as
2012         bp_catchpoint.
2013         (print_one_breakpoint_location, print_one_breakpoint): Use
2014         is_ada_exception_catchpoint.
2015         * ada-lang.c (class ada_catchpoint_location): Pass
2016         bp_loc_software_breakpoint to bp_location constructor.
2017         (is_ada_exception_catchpoint): New function.
2018
2019 2019-07-10  Tom Tromey  <tromey@adacore.com>
2020
2021         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2022         VEC.
2023         (struct arm_exidx_entry): New method operator<.
2024         (struct arm_exidx_data) <section_maps>: Change type.
2025         (arm_exidx_data_free): Remove.
2026         (arm_exidx_data_key): Change type.  Move lower.
2027         (arm_exidx_new_objfile): Update.
2028         (arm_compare_exidx_entries): Remove.
2029         (arm_find_exidx_entry, _initialize_arm_tdep)
2030
2031 2019-07-10  Tom Tromey  <tromey@adacore.com>
2032
2033         * solib-spu.c (ocl_program_data_key): Change type.
2034         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2035         Update.
2036
2037 2019-07-10  Tom Tromey  <tromey@adacore.com>
2038
2039         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2040         (struct solib_aix_inferior_data) <library_list>: Change type.
2041         (solib_aix_inferior_data_handle): Change type.
2042         (get_solib_aix_inferior_data): Update.
2043         (solib_aix_free_library_list): Remove.
2044         (library_list_start_library): Update.
2045         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2046         return type.
2047         (solib_aix_get_library_list)
2048         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2049         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2050
2051 2019-07-10  Tom Tromey  <tromey@adacore.com>
2052
2053         * solib-dsbt.c (struct dsbt_info): Add initializers.
2054         (solib_dsbt_pspace_data): Change type.
2055         (dsbt_pspace_data_cleanup): Remove.
2056         (get_dsbt_info, _initialize_dsbt_solib): Update.
2057
2058 2019-07-10  Tom Tromey  <tromey@adacore.com>
2059
2060         * spu-tdep.c (spu_overlay_data): Change type.
2061         (spu_get_overlay_table, spu_overlay_new_objfile)
2062         (_initialize_spu_tdep): Update.
2063
2064 2019-07-10  Tom Tromey  <tromey@adacore.com>
2065
2066         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2067         destructor.
2068         (dbx_objfile_data_key): Change type and declare later.
2069         (DBX_SYMFILE_INFO): Rewrite.
2070         * dbxread.c (dbx_objfile_data_key): Change type.
2071         (dbx_symfile_init): Update.
2072         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2073         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2074         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2075
2076 2019-07-10  Tom Tromey  <tromey@adacore.com>
2077
2078         * jit.c (jit_program_space_key): Change type.  Move lower.
2079         (get_jit_program_space_data): Update.
2080         (jit_program_space_data_cleanup): Remove.
2081         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2082         Update.
2083         (struct jit_program_space_data): Add initializers.
2084
2085 2019-07-10  Tom Tromey  <tromey@adacore.com>
2086
2087         * solib-darwin.c (struct darwin_info): Add initializers.
2088         (solib_darwin_pspace_data): Change type.
2089         (darwin_pspace_data_cleanup): Remove.
2090         (get_darwin_info, _initialize_darwin_solib): Update.
2091
2092 2019-07-10  Tom Tromey  <tromey@adacore.com>
2093
2094         * remote-sim.c (struct sim_inferior_data): Add initializers,
2095         constructor, and destructor.
2096         (sim_inferior_data_key): Change type.  Move lower.
2097         (check_for_duplicate_sim_descriptor): Update.
2098         (get_sim_inferior_data): Use new.  Update.
2099         (~sim_inferior_data_cleanup): Rename from
2100         sim_inferior_data_cleanup.  Simplify.
2101         (gdbsim_close_inferior, simulator_command)
2102         (sim_command_completer, _initialize_remote_sim): Update.
2103         (next_pid, INITIAL_PID): Move earlier.
2104
2105 2019-07-10  Tom Tromey  <tromey@adacore.com>
2106
2107         * python/python-internal.h (create_thread_object): Return
2108         gdbpy_ref.
2109         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2110         * python/py-inferior.c (struct threadlist_entry): Add
2111         constructor.
2112         <thread_obj>: Now a gdbpy_ref.
2113         (thread_to_thread_object): Update.
2114         (add_thread_object): Use new.
2115         (delete_thread_object): Use delete.
2116         (infpy_threads): Update.
2117         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2118         GIL.
2119
2120 2019-07-10  Tom Tromey  <tromey@adacore.com>
2121
2122         * valops.c (value_cast): Specialize error message for Ada.
2123
2124 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2125
2126         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2127
2128 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2129
2130         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2131         bpstat_should_step): Return bool, adjust comments.
2132         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2133         bpstat_should_step): Likewise.
2134
2135 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2136
2137         * features/Makefile: Use feature target descriptions for Arm.
2138         * features/arm/arm-core.c: Generate new file.
2139         * features/arm/arm-fpa.c: Likewise.
2140         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2141         * features/arm/arm-m-profile.c: Likewise.
2142         * features/arm/arm-vfpv2.c: Likewise.
2143         * features/arm/arm-vfpv3.c: Likewise.
2144         * features/arm/xscale-iwmmxt.c: Likewise.
2145         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2146
2147 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2148
2149         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2150         ptrace earlier.
2151
2152 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2153
2154         * features/aarch64-pauth.c: Regenerate.
2155
2156 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2157
2158         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2159         bool.
2160         (bpstat_what): Use false instead of 0.
2161
2162 2019-07-09  Pedro Alves  <palves@redhat.com>
2163
2164         * break-catch-throw.c (is_exception_catchpoint): New.
2165         * breakpoint.c (print_one_breakpoint_location): New parameter
2166         'raw_loc'.  Handle it.  Use
2167         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2168         looking at the breakpoint's type.
2169         (print_one_breakpoint): If handling "maint info breakpoints", also
2170         print locations of exception catchpoints.
2171         * breakpoint.h (is_exception_catchpoint): Declare.
2172
2173 2019-07-09  Pedro Alves  <palves@redhat.com>
2174
2175         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2176         "addr" field.
2177         (allocate_location_exception_catchpoint): New.
2178         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2179         (initialize_throw_catchpoint_ops): Install
2180         allocate_location_exception_catchpoint as allocate_location
2181         method.
2182         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2183         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2184         bp_loc_other.
2185         (breakpoint_address_is_meaningful): Delete.
2186         (bl_address_is_meaningful): New.
2187         (breakpoint_locations_match): Adjust comment.
2188         (bp_location_from_bp_type): New, factored out of...
2189         (bp_location::bp_location(breakpoint *)): ... this.
2190         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2191         factored out of...
2192         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2193         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2194         breakpoint_address_is_meaningful.
2195         (bp_locations_compare): Adjust comment.
2196         (update_global_location_list): Use bl_address_is_meaningful
2197         instead of breakpoint_address_is_meaningful.
2198         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2199         explicit.
2200         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2201         * python/py-breakpoint.c (bppy_get_location): No longer check
2202         whether location is null.
2203
2204 2019-07-09  Pedro Alves  <palves@redhat.com>
2205
2206         PR c++/15468
2207         * breakpoint.c (print_one_breakpoint_location): Remove
2208         single-location assert.
2209
2210 2019-07-09  Tom Tromey  <tom@tromey.com>
2211
2212         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2213         * configure: Rebuild.
2214         * configure.ac: Change common to gdbsupport.
2215         * gdbsupport: Rename from common.
2216         * acinclude.m4: Change common to gdbsupport.
2217         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2218         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2219         gdbsupport.
2220         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2221         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2222         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2223         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2224         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2225         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2226         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2227         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2228         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2229         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2230         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2231         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2232         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2233         coff-pe-read.c, command.h, compile/compile-c-support.c,
2234         compile/compile-c.h, compile/compile-cplus-symbols.c,
2235         compile/compile-cplus-types.c, compile/compile-cplus.h,
2236         compile/compile-loc2c.c, compile/compile.c, completer.c,
2237         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2238         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2239         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2240         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2241         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2242         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2243         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2244         features/aarch64-core.c, features/aarch64-fpu.c,
2245         features/aarch64-pauth.c, features/aarch64-sve.c,
2246         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2247         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2248         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2249         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2250         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2251         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2252         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2253         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2254         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2255         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2256         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2257         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2258         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2259         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2260         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2261         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2262         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2263         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2264         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2265         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2266         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2267         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2268         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2269         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2270         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2271         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2272         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2273         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2274         minsyms.c, mips-linux-tdep.c, namespace.h,
2275         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2276         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2277         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2278         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2279         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2280         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2281         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2282         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2283         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2284         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2285         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2286         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2287         procfs.c, producer.c, progspace.h, psymtab.h,
2288         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2289         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2290         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2291         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2292         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2293         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2294         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2295         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2296         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2297         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2298         target-memory.c, target.c, target.h, target/waitstatus.c,
2299         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2300         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2301         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2302         unittests/array-view-selftests.c,
2303         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2304         unittests/common-utils-selftests.c,
2305         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2306         unittests/format_pieces-selftests.c,
2307         unittests/function-view-selftests.c,
2308         unittests/lookup_name_info-selftests.c,
2309         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2310         unittests/mkdir-recursive-selftests.c,
2311         unittests/observable-selftests.c,
2312         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2313         unittests/parse-connection-spec-selftests.c,
2314         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2315         unittests/scoped_fd-selftests.c,
2316         unittests/scoped_mmap-selftests.c,
2317         unittests/scoped_restore-selftests.c,
2318         unittests/string_view-selftests.c, unittests/style-selftests.c,
2319         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2320         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2321         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2322         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2323         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2324         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2325
2326 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2327
2328         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2329         bool value.
2330         (decode_digits_ordinary): Set explicit_line field in sal.
2331         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2332         symtab_and_line that was set on an explicit line number in
2333         assembler code.  Do always update the recorded symtab and line if
2334         we do skip the prologue.
2335
2336 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2337
2338         * breakpoint.c (set_breakpoint_location_function): Remove
2339         explicit_loc parameter.
2340         (momentary_breakpoint_from_master): Update call to
2341         set_breakpoint_location_function.
2342         (add_location_to_breakpoint): Likewise.
2343
2344 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2345
2346         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2347         required features based on default bfd type when no specific bfd
2348         is present.
2349
2350 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2351
2352         * NEWS: Mention that GDB printf and eval commands can now print
2353         C-style and Ada-style convenience var strings without
2354         calling the inferior.
2355         * printcmd.c (printf_c_string): Locally print GDB internal var
2356         instead of transiting via the inferior.
2357         (printf_wide_c_string): Likewise.
2358
2359 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2360
2361         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2362
2363 2019-07-04  Tom Tromey  <tom@tromey.com>
2364
2365         PR tui/24724:
2366         * tui/tui-winsource.c (tui_clear_source_content): Update.
2367         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2368         (tui_update_breakpoint_info): Update.
2369         (tui_set_exec_info_content): Update.
2370         * tui/tui-source.c (tui_set_source_content_nil): Update.
2371         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2372         has_break.
2373         * tui/tui-data.h (enum tui_bp_flag): New.
2374         (tui_bp_flags): New enum flags type.
2375         (struct tui_source_element) <break_mode>: Change type.  Rename
2376         from has_break.
2377         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2378         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2379         constants.
2380         * tui/tui-winsource.h: Fix comment.
2381
2382 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2383
2384         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2385         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2386         (store_fpregs_to_thread)
2387         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2388         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2389         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2390         (IWMMXT_REGS_SIZE): Add define.
2391         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2392         (fetch_vfp_regs, store_vfp_regs)
2393         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2394         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2395
2396 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2397
2398         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2399         defines.
2400         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2401         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2402         (ARM_INT_REGISTER_SIZE): ...to this.
2403         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2404         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2405         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2406         (arm_linux_collect_gregset, supply_nwfpe_register)
2407         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2408         defines.
2409         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2410         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2411         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2412         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2413         (arm_return_in_memory, arm_store_return_value)
2414         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2415         (arm_record_ld_st_multiple): Likewise.
2416         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2417         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2418
2419 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2420
2421         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2422         AARCH64_DISPLACED_MODIFIED_INSNS.
2423         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2424         (aarch64_displaced_step_copy_insn): Likewise.
2425         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2426         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2427         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2428         ARM_DISPLACED_MODIFIED_INSNS.
2429         * arm-tdep.c (arm_gdbarch_init): Likewise.
2430         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2431         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2432         (struct arm_displaced_step_closure): Use
2433         ARM_DISPLACED_MODIFIED_INSNS.
2434
2435 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2436
2437         * features/Makefile: Remove unused xml files.
2438         * features/aarch64.xml: Remove.
2439         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2440         * features/i386/amd64-avx-avx512.xml: Remove.
2441         * features/i386/amd64-avx-linux.xml: Remove.
2442         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2443         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2444         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2445         * features/i386/amd64-avx-mpx.xml: Remove.
2446         * features/i386/amd64-avx.xml: Remove.
2447         * features/i386/amd64-linux.xml: Remove.
2448         * features/i386/amd64-mpx-linux.xml: Remove.
2449         * features/i386/amd64-mpx.xml: Remove.
2450         * features/i386/amd64.xml: Remove.
2451         * features/i386/i386-avx-avx512-linux.xml: Remove.
2452         * features/i386/i386-avx-avx512.xml: Remove.
2453         * features/i386/i386-avx-linux.xml: Remove.
2454         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2455         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2456         * features/i386/i386-avx-mpx-linux.xml: Remove.
2457         * features/i386/i386-avx-mpx.xml: Remove.
2458         * features/i386/i386-avx.xml: Remove.
2459         * features/i386/i386-linux.xml: Remove.
2460         * features/i386/i386-mmx-linux.xml: Remove.
2461         * features/i386/i386-mmx.xml: Remove.
2462         * features/i386/i386-mpx-linux.xml: Remove.
2463         * features/i386/i386-mpx.xml: Remove.
2464         * features/i386/i386.xml: Remove.
2465         * features/i386/x32-avx-avx512-linux.xml: Remove.
2466         * features/i386/x32-avx-linux.xml: Remove.
2467         * features/i386/x32-linux.xml: Remove.
2468
2469 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2470
2471         * regformats/aarch64.dat: Remove.
2472         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2473         * regformats/i386/amd64-avx-linux.dat: Remove.
2474         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2475         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2476         * regformats/i386/amd64-linux.dat: Remove.
2477         * regformats/i386/amd64-mpx-linux.dat: Remove.
2478         * regformats/i386/amd64.dat: Remove.
2479         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2480         * regformats/i386/i386-avx-linux.dat: Remove.
2481         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2482         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2483         * regformats/i386/i386-linux.dat: Remove.
2484         * regformats/i386/i386-mmx-linux.dat: Remove.
2485         * regformats/i386/i386-mpx-linux.dat: Remove.
2486         * regformats/i386/i386.dat: Remove.
2487         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2488         * regformats/i386/x32-avx-linux.dat: Remove.
2489         * regformats/i386/x32-linux.dat: Remove.
2490
2491 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2492
2493         * aarch64-tdep.c: Remove xml self tests.
2494         * amd64-linux-tdep.c: Likewise.
2495         * amd64-tdep.c: Likewise.
2496         * i386-linux-tdep.c: Likewise.
2497         * i386-tdep.c: Likewise.
2498
2499 2019-07-03  Pedro Alves  <palves@redhat.com>
2500
2501         PR cli/24732
2502         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2503         (pipe_cmd_option_defs): New.
2504         (make_pipe_cmd_options_def_group): New.
2505         (pipe_command): Use gdb::option::process_options.
2506         (pipe_command_completer): New function.
2507         (_initialize_cli_cmds): Install completer for "pipe" command.
2508
2509 2019-07-03  Pedro Alves  <palves@redhat.com>
2510
2511         * cli/cli-option.c (union option_value) <string>: New field.
2512         (struct option_def_and_value): Add ctor, move ctor, dtor and
2513         use DISABLE_COPY_AND_ASSIGN.
2514         (option_def_and_value::clear_value): New.
2515         (parse_option, save_option_value_in_ctx, get_val_type_str)
2516         (add_setshow_cmds_for_options): Handle var_string.
2517         * cli-option.h (union option_def::var_address) <string>: New
2518         field.
2519         (struct string_option_def): New.
2520         * maint-test-options.c (struct test_options_opts): Add default
2521         ctor and use DISABLE_COPY_AND_ASSIGN.
2522         <string_opt>: New field.
2523         (test_options_opts::~test_options_opts): New.
2524         (test_options_opts::dump): Also dump "-string".
2525         (test_options_option_defs): Install "string.
2526
2527 2019-07-03  Pedro Alves  <palves@redhat.com>
2528
2529         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2530         option_value with a null enumeration.
2531         (complete_options): Save the option values in the context.
2532         (save_option_value_in_ctx): New, factored out from ...
2533         (process_options): ... here.
2534         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2535         of the function.
2536         * maint-test-options.c (test_options_opts::dump): New, factored
2537         out from ...
2538         (maintenance_test_options_command_mode): ... here.
2539         (maintenance_test_options_command_completion_result): Delete.
2540         (maintenance_test_options_command_completion_text): Update
2541         comment.
2542         (maintenance_show_test_options_completion_result): Change
2543         prototype.  Just print
2544         maintenance_test_options_command_completion_text.
2545         (save_completion_result): New.
2546         (maintenance_test_options_completer_mode): Pass options context to
2547         complete_options, and then save a dump.
2548         (_initialize_maint_test_options): Use add_cmd to install "maint
2549         show test-options-completion-result".
2550
2551 2019-07-03  Pedro Alves  <palves@redhat.com>
2552
2553         * NEWS (New commands): Mention "with" and "maint with".
2554         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2555         (with_command, with_command_completer): New.
2556         (pipe_command): Adjust to new repeat_previous
2557         interface.
2558         (_initialize_cli_cmds): Install the "with" command and its "w"
2559         alias.
2560         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2561         declarations.
2562         * cli/cli-setshow.c (parse_cli_var_uinteger)
2563         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2564         argument strings for all var_types.
2565         (get_setshow_command_value_string): New, factored out from ...
2566         (do_show_command): ... this.
2567         * cli/cli-setshow.h: Include <string>.
2568         (get_setshow_command_value_string): Declare.
2569         * command.h (repeat_previous): Now returns const char *.  Adjust
2570         comment.
2571         * maint.c: Include "cli/cli-cmds.h".
2572         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2573         (_initialize_maint_cmds): Register the "maintenance with" command.
2574         * top.c (repeat_previous): Move bits from pipe_command here:
2575         Return the saved command line, if any; error out if there's no
2576         command to relaunch.
2577
2578 2019-07-03  Pedro Alves  <palves@redhat.com>
2579
2580         * NEWS (New commands): Mention "maint set/show test-settings"
2581         instead of "maint test-settings".
2582         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2583         (maintenance_test_settings_set_list): Rename to ...
2584         (maintenance_set_test_settings_list): ... this.
2585         (maintenance_test_settings_show_list): Rename to  ...
2586         (maintenance_show_test_settings_list): ... this.
2587         (maintenance_test_settings_cmd): Delete.
2588         (maintenance_test_settings_set_cmd): ...
2589         (maintenance_set_test_settings_cmd): ... this.
2590         (maintenance_test_settings_show_cmd): ...
2591         (maintenance_show_test_settings_cmd): ... this.
2592         (maintenance_test_settings_show_value_cmd):
2593         (maintenance_show_test_settings_value_cmd): ... this.
2594         (_initialize_maint_test_settings): No longer install the "maint
2595         test-settings" prefix command.  Rename "maint test-settings set"
2596         to "maint set test-settings", and "maint test-settings show" to
2597         "maint show test-settings".  Adjust all subcommands.
2598
2599 2019-07-03  Pedro Alves  <palves@redhat.com>
2600
2601         * maint-test-settings.c: Fix file's intro comment.  Replace all
2602         references to "test-options" with references to "test-settings",
2603         in comments.
2604
2605 2019-07-03  Pedro Alves  <palves@redhat.com>
2606
2607         * maint-test-settings.c (maintenance_test_settings_xxx)
2608         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2609         New.
2610         (maintenance_test_settings_enums): Use them.
2611         (maintenance_test_settings_enum): Default to
2612         maintenance_test_settings_xxx.
2613         (_initialize_maint_test_settings): Initialize
2614         MAINTENANCE_TEST_SETTINGS_FILENAME.
2615
2616 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2617
2618         * breakpoint.h (remove_breakpoints_inf): Change return type to
2619         void, move function documentation here.
2620         * breakpoint.c (remove_breakpoints_inf): Change return type to
2621         void, move function documentation to header.
2622
2623 2019-07-02  Pedro Alves  <palves@redhat.com>
2624
2625         * NEWS (Completion improvements): Mention "info threads".
2626         * thread.c (struct info_threads_opts, info_threads_option_defs)
2627         (make_info_threads_options_def_group): New.
2628         (info_threads_command): Use gdb::option::process_options.
2629         (info_threads_command_completer): New.
2630         (_initialize_thread): Use gdb::option::build_help to build the
2631         help text for "info threads".
2632
2633 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2634
2635         * defs.h (generic_load): Move from here...
2636         * symfile.h (generic_load): ... to here.  Rename name parameter
2637         to args.
2638         * symfile.c (generic_load): Add comment.
2639
2640 2019-07-01  Tom Tromey  <tromey@adacore.com>
2641
2642         * dwarf2read.c
2643         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2644         declaration of without_params.  Fix formatting.
2645
2646 2019-07-01  Tom Tromey  <tromey@adacore.com>
2647
2648         * ada-exp.y (find_primitive_type): Update.
2649         * ada-lang.h (ada_lookup_symbol): Update.
2650         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2651         parameter.
2652         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2653
2654 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2655
2656         PR breakpoints/24541
2657         * gdbarch.c: Regenerate.
2658         * gdbarch.h: Regenerate.
2659         * gdbarch.sh: Add 'stap_adjust_register'.
2660         * i386-tdep.c: Include '<unordered_set>'.
2661         (i386_stap_adjust_register): New function.
2662         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2663         * stap-probe.c (stap_parse_register_operand): Call
2664         'gdbarch_stap_adjust_register'.
2665
2666 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2667
2668         PR python/24742
2669         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2670         * python/python.c (do_start_initialization): Use 'xmalloc'
2671         instead of 'PyMem_Malloc'.
2672
2673 2019-06-28  Tom Tromey  <tromey@adacore.com>
2674
2675         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2676         for Ada.
2677
2678 2019-06-27  Tom Tromey  <tromey@adacore.com>
2679
2680         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2681         objfile_key.
2682         (arm_find_mapping_symbol, arm_record_special_symbol)
2683         (_initialize_arm_tdep): Update.
2684         (arm_objfile_data_free): Remove.
2685
2686 2019-06-27  Tom Tromey  <tromey@adacore.com>
2687
2688         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2689         to cp_print_static_field.
2690
2691 2019-06-26  Tom Tromey  <tromey@adacore.com>
2692
2693         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2694         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2695         declare.
2696
2697 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2698
2699         * features/aarch64-core.c (create_feature_aarch64_core):
2700         Regenerate.
2701         * features/aarch64-core.xml: Add cpsr flags.
2702
2703 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2704
2705         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2706         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2707
2708 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2709
2710         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2711         field.
2712         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2713         use.
2714         (arm_record_special_symbol): Don't insert new symbol in sorted
2715         position, push it at the end.
2716
2717 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2718
2719         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2720         (arm_mapping_symbol_s): Remove.
2721         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2722         (arm_mapping_symbol_vec): New typedef.
2723         (struct arm_per_objfile): Add constructor.
2724         <section_maps>: Change type to
2725         std::unique_ptr<arm_mapping_symbol_vec[]>.
2726         (arm_compare_mapping_symbols): Remove.
2727         (arm_find_mapping_symbol): Adjust to section_maps type change.
2728         (arm_objfile_data_free): Call delete on arm_per_objfile.
2729         (arm_record_special_symbol): Adjust to section_maps type change.
2730         Allocate arm_per_objfile with new.
2731
2732 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2733
2734         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2735         with the command prefix.
2736
2737 2019-06-25  Tom Tromey  <tom@tromey.com>
2738
2739         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2740         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2741
2742 2019-06-25  Tom Tromey  <tom@tromey.com>
2743
2744         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2745         type.
2746         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2747         protected.
2748
2749 2019-06-25  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-winsource.c
2752         (tui_source_window_base::set_is_exec_point_at): Add check against
2753         LOA_ADDRESS.
2754
2755 2019-06-25  Tom Tromey  <tom@tromey.com>
2756
2757         * tui/tui-source.c (tui_set_source_content): Don't check before
2758         xfree.
2759         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2760
2761 2019-06-25  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-winsource.h (tui_update_source_window_as_is)
2764         (tui_alloc_source_buffer, tui_line_is_displayed)
2765         (tui_addr_is_displayed): Change type of win_info.
2766         * tui/tui-winsource.c (tui_update_source_window_as_is)
2767         (tui_clear_source_content, tui_show_source_line)
2768         (tui_show_source_content, tui_source_window_base::refill)
2769         (tui_source_window_base::set_is_exec_point_at)
2770         (tui_source_window_base::set_is_exec_point_at)
2771         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2772         (tui_alloc_source_buffer, tui_line_is_displayed)
2773         (tui_addr_is_displayed): Change type of win_info.  Update.
2774         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2775         (tui_source_window_base::do_make_visible_with_new_height):
2776         Update.
2777         * tui/tui-source.c (tui_set_source_content)
2778         (tui_set_source_content_nil)
2779         (tui_source_window::do_scroll_vertical): Update.
2780         * tui/tui-layout.c (show_layout): Update.
2781         * tui/tui-disasm.c (tui_set_disassem_content)
2782         (tui_disasm_window::do_scroll_vertical): Update.
2783         * tui/tui-data.h (tui_win_content): Remove.
2784         (struct tui_gen_win_info) <content, content_size>: Remove.
2785         (struct tui_source_element): Add initializers and destructor.
2786         (union tui_which_element, struct tui_win_element): Remove.
2787         (struct tui_source_window_base) <content>: New field.
2788         (struct tui_data_window): Remove destructor.
2789         (tui_alloc_content, tui_free_win_content)
2790         (tui_free_all_source_wins_content): Don't declare.
2791         * tui/tui-data.c (tui_initialize_static_data): Update.
2792         (init_content_element, tui_alloc_content): Remove.
2793         (~tui_gen_win_info): Update.
2794         (~tui_data_window, tui_free_all_source_wins_content)
2795         (tui_free_win_content, free_content, free_content_elements):
2796         Remove.
2797
2798 2019-06-25  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-winsource.h (tui_clear_source_content)
2801         (tui_erase_source_content, tui_show_source_content): Change type
2802         of win_info.
2803         * tui/tui-winsource.c (tui_clear_source_content)
2804         (tui_erase_source_content, tui_show_source_content): Change type
2805         of win_info.
2806         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2807         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2808         win_info.
2809         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2810         win_info.
2811         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2812
2813 2019-06-25  Tom Tromey  <tom@tromey.com>
2814
2815         * tui/tui-winsource.c (tui_clear_source_content)
2816         (tui_source_window_base::set_is_exec_point_at): Update.
2817         * tui/tui-source.c (tui_set_source_content_nil): Update.
2818         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2819         a bool.
2820         * tui/tui-data.c (init_content_element): Update.
2821
2822 2019-06-25  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2825         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2826         * tui/tui-layout.c (init_and_make_win): Update.
2827         * tui/tui.h (enum tui_win_type): Update.
2828         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
2829         tui_win_is_auxillary.
2830         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
2831         tui_win_is_auxillary.
2832
2833 2019-06-25  Tom Tromey  <tom@tromey.com>
2834
2835         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
2836         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
2837         (tui_delete_data_content_windows, tui_display_all_data)
2838         (tui_data_window::do_scroll_vertical, tui_display_data_from):
2839         Update.
2840         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
2841         * tui/tui-regs.c (tui_last_regs_line_no)
2842         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2843         (tui_show_registers): Update.
2844         (tui_show_register_group): Return void.  Update.
2845         (tui_display_registers_from, tui_display_reg_element_at_line)
2846         (tui_display_registers_from_line, tui_check_register_values):
2847         Update.
2848         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
2849         member.
2850         (struct tui_data_window) <regs_content>: Now a std::vector.
2851         <regs_content_count>: Remove.
2852         (tui_add_content_elements, tui_free_data_content): Don't declare.
2853         * tui/tui-data.c (tui_data_window::clear_detail): Update.
2854         (init_content_element): Remove DATA_WIN case.  Add assert.
2855         (tui_add_content_elements): Remove.
2856         (tui_data_window): Update.
2857         (tui_free_data_content): Remove.
2858         (free_content_elements): Remove DATA_WIN case.
2859
2860 2019-06-25  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui-data.c (tui_data_item_window): Update.
2863         * tui/tui-windata.h (tui_check_data_values): Don't declare.
2864         * tui/tui-windata.c (tui_display_all_data)
2865         (tui_display_data_from_line): Update.
2866         (tui_check_data_values): Remove.
2867         * tui/tui-regs.c (tui_show_register_group)
2868         (tui_display_reg_element_at_line): Update.
2869         * tui/tui-hooks.c (tui_register_changed)
2870         (tui_refresh_frame_and_register_information): Call
2871         tui_check_register_values.
2872         * tui/tui-data.h (struct tui_data_window) <data_content,
2873         data_content_count, data_type>: Remove.
2874         (enum tui_data_type): Remove.
2875
2876         * tui/tui-data.c (tui_data_window::clear_detail)
2877         (~tui_data_window): Update.
2878
2879 2019-06-25  Tom Tromey  <tom@tromey.com>
2880
2881         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2882         declare.
2883         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2884         Rename from tui_first_data_item_displayed.  Update.
2885         (tui_data_window::refresh_all)
2886         (tui_data_window::do_scroll_vertical): Update.
2887         * tui/tui-data.h (struct tui_data_window)
2888         <first_data_item_displayed>: Declare new method.
2889
2890 2019-06-25  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2893         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2894         contents...
2895         (tui_initialize_static_data): ...here.
2896
2897 2019-06-25  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2900         (tui_display_registers_from, tui_check_register_values): Update.
2901         (tui_display_register): Remove win_info parameter; update.
2902         (tui_get_register): Change type of parameters.
2903         * tui/tui-data.h (struct tui_data_element): Remove.
2904         (union tui_which_element) <data>: Remove.
2905         <data_window>: Change type.
2906         (struct tui_data_item_window): New.
2907         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2908         case.  Add assert.
2909         (~tui_data_item_window): New destructor.
2910         (free_content_elements): Remove DATA_ITEM_WIN case.
2911
2912 2019-06-25  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2915         Remove.
2916
2917 2019-06-25  Tom Tromey  <tom@tromey.com>
2918
2919         * tui/tui-data.h (struct tui_command_element): Remove.
2920         (union tui_which_element) <command>: Remove.
2921         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2922         assert.
2923         (free_content_elements): Remove CMD_WIN case.
2924
2925 2019-06-25  Tom Tromey  <tom@tromey.com>
2926
2927         * tui/tui-layout.c (tui_set_layout): Update.
2928         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2929         * tui/tui-data.c (layout_def): Update.
2930
2931 2019-06-25  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2934         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2935         (tui_source_window_base::set_new_height): Update.
2936         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2937         Update.
2938         (tui_set_locator_fullname, tui_set_locator_info)
2939         (tui_show_frame_info): Update.
2940         * tui/tui-source.c (tui_set_source_content)
2941         (tui_source_is_displayed): Update.
2942         * tui/tui-layout.c (show_source_disasm_command, show_data)
2943         (show_source_or_disasm_and_command): Update.
2944         * tui/tui-disasm.c (tui_set_disassem_content)
2945         (tui_get_begin_asm_address): Update.
2946         * tui/tui-data.h (struct tui_locator_element): Remove.
2947         (union tui_which_element) <locator>: Remove.
2948         (struct tui_locator_window): New.
2949         (tui_locator_win_info_ptr): Change return type.
2950         * tui/tui-data.c (_locator): Change type.
2951         (tui_locator_win_info_ptr): Change return type.
2952         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2953         (tui_alloc_content): Add assert.
2954
2955 2019-06-25  Tom Tromey  <tom@tromey.com>
2956
2957         * tui/tui-winsource.c
2958         (tui_exec_info_window::maybe_allocate_content): New method.
2959         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2960         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2961         (make_source_or_disasm_window): Add cast.
2962         * tui/tui-data.h (union tui_which_element) <simple_string>:
2963         Remove.
2964         (struct tui_source_info): New.
2965         (struct tui_source_window_base) <execution_info>: Change type.
2966         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2967         case, and add assert.
2968         (tui_alloc_content): Add assert.
2969
2970 2019-06-25  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2973         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2974         * tui/tui-data.c (tui_alloc_win_info): Remove.
2975
2976 2019-06-25  Tom Tromey  <tom@tromey.com>
2977
2978         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2979         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2980         can_highlight.
2981
2982 2019-06-25  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2985         make_visible_with_new_height method.
2986         (tui_win_info::make_visible_with_new_height): New method.
2987         (tui_source_window_base::do_make_visible_with_new_height)
2988         (tui_data_window::do_make_visible_with_new_height)
2989         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2990         (make_visible_with_new_height): Remove.
2991         (tui_resize_all, tui_adjust_win_heights): Use
2992         make_visible_with_new_height method.
2993         * tui/tui-data.h (struct tui_win_info)
2994         <do_make_visible_with_new_height, make_visible_with_new_height>:
2995         New methods.
2996         (struct tui_source_window_base, struct tui_data_window)
2997         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2998         methods.
2999
3000 2019-06-25  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3003         method.
3004         (update_tab_width): Call update_tab_width method.
3005         * tui/tui-data.h (struct tui_win_info)
3006         (struct tui_source_window_base) <update_tab_width>: New methods.
3007
3008 2019-06-25  Tom Tromey  <tom@tromey.com>
3009
3010         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3011         parameter.
3012         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3013         parameter.
3014         (tui_gen_win_info::make_visible): Update.
3015         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3016         parameter.
3017         * tui/tui-data.h (enum tui_box): New enum.
3018         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3019
3020 2019-06-25  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3023         init_and_make_win for EXEC_INFO_WIN.
3024         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3025         longer inline.
3026         (struct tui_win_info) <~tui_win_info>: Inline.
3027         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3028         Don't declare.
3029         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3030         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3031         Remove.
3032         (tui_initialize_static_data): Update.
3033         (~tui_gen_win_info): Handle more cleanup here.
3034         (~tui_source_window_base): Delete "execution_info".
3035         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3036
3037 2019-06-25  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-layout.c (make_command_window): Don't set
3040         can_highlight.
3041         (show_source_disasm_command): Call the reset method.
3042         (show_data): Don't set can_highlight.  Call the reset method.
3043         (tui_gen_win_info::reset): Rename from init_gen_win_info
3044         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3045         (show_source_or_disasm_and_command): Call the reset method.
3046         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3047         (struct tui_cmd_window): Set can_highlight.
3048
3049 2019-06-25  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3052         from make_visible.
3053         (tui_make_visible, tui_make_invisible): Rewrite.
3054         (tui_win_info::make_visible): Remove.
3055         (tui_source_window_base::make_visible): Update.
3056         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3057         method.  Moved from...
3058         (struct tui_win_info) <make_visible>: ...here.
3059
3060 2019-06-25  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-winsource.c
3063         (tui_source_window_base::do_scroll_horizontal): Remove direction
3064         parameter.
3065         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3066         direction parameter.
3067         * tui/tui-win.c (tui_win_info::forward_scroll)
3068         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3069         (tui_win_info::right_scroll): Update.
3070         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3071         direction parameter.
3072         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3073         direction parameter.
3074         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3075         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3076         Remove direction parameter.
3077         (struct tui_source_window_base, struct tui_source_window)
3078         (struct tui_disasm_window, struct tui_data_window)
3079         (struct tui_cmd_window): Update.
3080
3081 2019-06-25  Tom Tromey  <tom@tromey.com>
3082
3083         * tui/tui-winsource.h (tui_set_exec_info_content)
3084         (tui_show_exec_info_content, tui_erase_exec_info_content)
3085         (tui_clear_exec_info_content, tui_update_exec_info): Change
3086         argument to tui_source_window_base.
3087         * tui/tui-winsource.c (tui_set_exec_info_content)
3088         (tui_show_exec_info_content, tui_erase_exec_info_content)
3089         (tui_clear_exec_info_content, tui_update_exec_info): Change
3090         argument to tui_source_window_base.
3091
3092 2019-06-25  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3095         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3096
3097 2019-06-25  Tom Tromey  <tom@tromey.com>
3098
3099         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3100         check.
3101
3102 2019-06-25  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3105         type to void.
3106         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3107         type to void.
3108         * tui/tui-source.c (tui_set_source_content): Update.
3109         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3110
3111 2019-06-25  Tom Tromey  <tom@tromey.com>
3112
3113         * tui/tui-win.c (window_name_completer, tui_set_focus)
3114         (tui_all_windows_info): Use name method.
3115         * tui/tui-data.h (struct tui_gen_win_info)
3116         (struct tui_source_window, struct tui_disasm_window)
3117         (struct tui_data_window, struct tui_cmd_window) <name>: New
3118         method.
3119         (tui_win_name): Don't declare.
3120         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3121         (tui_win_name): Remove.
3122
3123 2019-06-25  Tom Tromey  <tom@tromey.com>
3124
3125         * tui/tui-winsource.h (tui_update_source_window)
3126         (tui_update_source_window_as_is): Change parameter type.
3127         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3128         to be a tui_source_window_base.
3129         (tui_update_source_window_as_is): Likewise.
3130         * tui/tui-win.c (make_visible_with_new_height): Update.
3131
3132 2019-06-25  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-winsource.c (tui_erase_source_content)
3135         (tui_show_source_content, tui_show_exec_info_content)
3136         (tui_erase_exec_info_content): Use refresh_window method.
3137         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3138         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3139         from tui_refresh_win.
3140         (tui_data_window::refresh_window): New method.
3141         (tui_win_info::refresh, tui_source_window_base::refresh)
3142         (tui_refresh_all): Use refresh_window method.
3143         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3144         method.
3145         * tui/tui-regs.c (tui_display_register): Call refresh_window
3146         method.
3147         * tui/tui-layout.c (show_source_disasm_command)
3148         (show_source_or_disasm_and_command): Call refresh_window method.
3149         * tui/tui-data.h (struct tui_gen_win_info)
3150         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3151         New method.
3152
3153 2019-06-25  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui.c (tui_rl_other_window, tui_enable)
3156         (tui_is_window_visible, tui_get_command_dimension): Update.
3157         * tui/tui-winsource.c (tui_update_source_window_as_is)
3158         (tui_clear_source_content, tui_erase_source_content)
3159         (tui_show_source_line, tui_source_window_base::refill)
3160         (tui_source_window_base::do_scroll_horizontal)
3161         (tui_source_window_base::set_is_exec_point_at)
3162         (tui_update_breakpoint_info, tui_set_exec_info_content)
3163         (tui_alloc_source_buffer, tui_line_is_displayed)
3164         (tui_addr_is_displayed): Update.
3165         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3166         (tui_check_and_display_highlight_if_needed)
3167         (tui_win_info::make_visible, tui_win_info::refresh)
3168         (tui_refresh_all): Update.
3169         * tui/tui-windata.c (tui_first_data_item_displayed)
3170         (tui_delete_data_content_windows, tui_erase_data_content)
3171         (tui_display_all_data, tui_data_window::refresh_all)
3172         (tui_check_data_values): Update.
3173         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3174         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3175         (tui_win_info::backward_scroll, tui_refresh_all_win)
3176         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3177         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3178         (tui_source_window_base::set_new_height)
3179         (tui_data_window::set_new_height)
3180         (make_invisible_and_set_new_height)
3181         (make_visible_with_new_height, new_height_ok)
3182         (parse_scrolling_args): Update.
3183         * tui/tui-stack.c (tui_show_frame_info): Update.
3184         * tui/tui-source.c (tui_set_source_content)
3185         (tui_set_source_content_nil, tui_source_is_displayed)
3186         (tui_source_window::do_scroll_vertical): Update.
3187         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3188         (tui_display_registers_from, tui_display_reg_element_at_line)
3189         (tui_check_register_values, tui_reg_command): Update.
3190         * tui/tui-layout.c (tui_default_win_height)
3191         (show_source_disasm_command, show_data, init_and_make_win)
3192         (show_source_or_disasm_and_command): Update.
3193         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3194         (tui_redisplay_readline, tui_mld_flush)
3195         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3196         (tui_getc): Update.
3197         * tui/tui-disasm.c (tui_set_disassem_content)
3198         (tui_disasm_window::do_scroll_vertical): Update.
3199         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3200         Now virtual.
3201         (struct tui_win_info): Derive from tui_gen_win_info.
3202         <~tui_win_info>: Mark as override.
3203         <generic>: Remove member.
3204         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3205         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3206         (~tui_data_window, ~tui_win_info)
3207         (tui_free_all_source_wins_content): Update.
3208         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3209
3210 2019-06-25  Tom Tromey  <tom@tromey.com>
3211
3212         * tui/tui-layout.c (init_and_make_win): Use new.
3213         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3214         destructor, initializers.
3215         (tui_alloc_generic_win_info): Don't declare.
3216         * tui/tui-data.c (_locator): Add argument to constructor.
3217         (source_win, disasm_win): New globals.
3218         (exec_info): Remove.
3219         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3220         Update.
3221         (tui_alloc_generic_win_info): Remove.
3222         (init_content_element): Use new.
3223         (tui_win_info::tui_win_info): Update.
3224         (free_content_elements) <case DATA_WIN>: Use delete.
3225
3226 2019-06-25  Tom Tromey  <tom@tromey.com>
3227
3228         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3229         * tui/tui-windata.c (tui_first_data_item_displayed)
3230         (tui_delete_data_content_windows): Update.
3231         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3232         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3233         (tui_display_registers_from, tui_check_register_values): Update.
3234         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3235         pointer.
3236         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3237         window.
3238         (tui_free_data_content): Update.
3239         (free_content_elements) <case DATA_WIN>: Free the window.
3240
3241 2019-06-25  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3244         Update.
3245         * tui/tui-layout.c (make_command_window)
3246         (show_source_disasm_command, show_data, init_and_make_win)
3247         (show_source_or_disasm_and_command): Update.
3248         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3249         method.
3250         <can_highight, is_highlighted>: Now bool.
3251         (tui_set_win_highlight): Don't declare.
3252         * tui/tui-data.c (tui_set_win_highlight): Remove.
3253
3254 2019-06-25  Tom Tromey  <tom@tromey.com>
3255
3256         * tui/tui-wingeneral.c (make_visible): Remove check of window
3257         type.
3258
3259 2019-06-25  Tom Tromey  <tom@tromey.com>
3260
3261         * tui/tui-win.c (tui_win_info::max_height)
3262         (tui_cmd_window::max_height): New methods.
3263         (new_height_ok): Call max_height.
3264         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3265         <max_height>: New method.
3266
3267 2019-06-25  Tom Tromey  <tom@tromey.com>
3268
3269         * tui/tui-win.c (tui_source_window_base::set_new_height)
3270         (tui_data_window::set_new_height): New methods.
3271         (make_invisible_and_set_new_height): Call set_new_height method.
3272         * tui/tui-data.h (struct tui_win_info)
3273         (struct tui_source_window_base, struct tui_data_window)
3274         <set_new_height>: New method.
3275
3276 2019-06-25  Tom Tromey  <tom@tromey.com>
3277
3278         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3279         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3280         tui_refresh_data_win.
3281         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3282         method.
3283         (tui_refresh_all_win): Call the refresh_all method.
3284         (tui_set_focus): Likewise.
3285         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3286         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3287         Likewise.
3288
3289 2019-06-25  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-winsource.h (tui_refill_source_window)
3292         (tui_set_is_exec_point_at): Don't declare.
3293         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3294         (tui_source_window_base::refill): Rename from
3295         tui_refill_source_window.
3296         (tui_source_window_base::do_scroll_horizontal): Update.
3297         (tui_source_window_base::set_is_exec_point_at): Rename from
3298         tui_set_is_exec_point_at.
3299         (tui_update_all_breakpoint_info): Update.
3300         * tui/tui-stack.c (tui_show_frame_info): Update.
3301         * tui/tui-layout.c (show_data): Add cast.
3302         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3303         * tui/tui-data.h (struct tui_source_window_base) <refill,
3304         set_is_exec_point_at>: New methods.
3305         (tui_source_windows, tui_add_to_source_windows): Update types.
3306         (tui_add_to_source_windows): Remove redundant declaration.
3307         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3308         (tui_source_windows): Change return type.
3309         (tui_clear_source_windows_detail): Update.
3310         (tui_add_to_source_windows): Change type of parameter.
3311         (tui_free_all_source_wins_content): Update.
3312
3313 2019-06-25  Tom Tromey  <tom@tromey.com>
3314
3315         * tui/tui-wingeneral.c (tui_win_info::refresh)
3316         (tui_source_window_base::refresh): New methods.
3317         (tui_refresh_all): Call the refresh method.
3318         * tui/tui-data.h (struct tui_win_info)
3319         (struct tui_source_window_base) <refresh>: New method.
3320
3321 2019-06-25  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui.h (tui_is_window_visible): Return bool.
3324         * tui/tui.c (tui_is_window_visible): Return bool.
3325         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3326         (tui_make_visible, tui_make_invisible)
3327         (tui_win_info::make_visible)
3328         (tui_source_window_base::make_visible, make_all_visible)
3329         (tui_make_all_visible, tui_make_all_invisible): Update.
3330         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3331         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3332         bool.
3333         (struct tui_win_info, struct tui_source_window_base)
3334         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3335         * tui/tui-data.c (tui_init_generic_part): Update.
3336
3337 2019-06-25  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3340         (tui_source_window_base::make_visible): New methods.
3341         (make_all_visible): Make method call.
3342         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3343         (struct tui_source_window_base, struct tui_cmd_window): Override
3344         make_visible.
3345         (tui_win_is_source_type): Don't declare.
3346         * tui/tui-data.c (tui_win_is_source_type): Remove.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3351         NULL check.
3352
3353 2019-06-25  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3356         Inline constructor.  Add initializers for members.
3357         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3358         constructors; now inline in class.
3359
3360 2019-06-25  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-regs.c (tui_show_registers): Update.
3363         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3364         bool.
3365         * tui/tui-data.c (tui_data_window::clear_detail)
3366         (tui_data_window): Update.
3367
3368 2019-06-25  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-windata.c (tui_display_all_data)
3371         (tui_display_data_from_line, tui_display_data_from)
3372         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3373         Update.
3374         * tui/tui-regs.c (tui_last_regs_line_no)
3375         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3376         (tui_show_registers, tui_show_register_group)
3377         (tui_display_registers_from, tui_display_reg_element_at_line)
3378         (tui_display_registers_from_line, tui_check_register_values)
3379         (tui_reg_next, tui_reg_prev): Update.
3380         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3381         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3382         tui_data_window.
3383         (struct tui_win_info) <detail>: Remove.  Add new fields from
3384         tui_data_info.
3385         (TUI_DATA_WIN): Add cast.
3386         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3387         (~tui_data_window): Simplify.
3388
3389 2019-06-25  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-layout.c (show_source_disasm_command)
3392         (show_source_or_disasm_and_command): Update.
3393         * tui/tui-io.c (update_cmdwin_start_line)
3394         (tui_redisplay_readline): Update.
3395         * tui/tui-data.h (struct tui_command_info): Remove.
3396         (struct tui_win_info) <detail>: Remove command_info member.
3397         (struct tui_data_window) <start_line>: New member, from
3398         tui_command_info.
3399         (TUI_CMD_WIN): Add casts.
3400
3401 2019-06-25  Tom Tromey  <tom@tromey.com>
3402
3403         * tui/tui-winsource.c (tui_update_source_window)
3404         (tui_refill_source_window)
3405         (tui_source_window_base::do_scroll_horizontal)
3406         (tui_update_breakpoint_info, tui_set_exec_info_content)
3407         (tui_show_exec_info_content, tui_erase_exec_info_content)
3408         (tui_clear_exec_info_content): Update.
3409         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3410         Update.
3411         * tui/tui-win.c (make_invisible_and_set_new_height)
3412         (make_visible_with_new_height): Update.
3413         * tui/tui-source.c (tui_set_source_content)
3414         (tui_show_symtab_source): Update.
3415         * tui/tui-layout.c (extract_display_start_addr)
3416         (show_source_disasm_command, show_data)
3417         (make_source_or_disasm_window)
3418         (show_source_or_disasm_and_command): Update.
3419         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3420         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3421         "gdbarch".
3422         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3423         to tui_source_window_base.
3424         (struct tui_win_info) <detail>: Remove source_info member.
3425         (struct tui_source_window_base) <has_locator>: Inline.
3426         Move contents from tui_source_info; rename has_locator member to
3427         m_has_locator.
3428         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3429         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3430         header file.
3431         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3432         Simplify.
3433         (tui_free_all_source_wins_content): Cast to
3434         tui_source_window_base.
3435
3436 2019-06-25  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-win.c (make_invisible_and_set_new_height)
3439         (make_visible_with_new_height): Call has_locator method.
3440         * tui/tui-layout.c (show_source_disasm_command, show_data)
3441         (show_source_or_disasm_and_command): Update for bool change.
3442         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3443         (tui_win_info) <has_locator>: New method.
3444         (struct tui_source_window_base) <has_locator>: New method.
3445         (tui_win_has_locator): Don't declare.
3446         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3447         from tui_win_has_locator.
3448         (tui_source_window_base): Use false, not FALSE.
3449
3450 2019-06-25  Tom Tromey  <tom@tromey.com>
3451
3452         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3453         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3454         clear_detail method directly.
3455         (tui_clear_win_detail): Remove.
3456
3457 2019-06-25  Tom Tromey  <tom@tromey.com>
3458
3459         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3460         "this", not TUI_DISASM_WIN.
3461
3462 2019-06-25  Tom Tromey  <tom@tromey.com>
3463
3464         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3465         declare.
3466         * tui/tui-winsource.c
3467         (tui_source_window_base::do_scroll_horizontal): Rename from
3468         tui_horizontal_source_scroll.
3469         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3470         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3471         from tui_vertical_data_scroll.
3472         * tui/tui-win.h (tui_scroll): Don't declare.
3473         * tui/tui-win.c (tui_win_info::forward_scroll)
3474         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3475         (tui_win_info::right_scroll): Rename and update.
3476         (tui_scroll_forward_command, tui_scroll_backward_command)
3477         (tui_scroll_left_command, tui_scroll_right_command): Update.
3478         (tui_scroll): Remove.
3479         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3480         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3481         from tui_vertical_source_scroll.
3482         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3483         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3484         from tui_vertical_disassem_scroll.
3485         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3486         do_scroll_horizontal>: New methods.
3487         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3488         Likewise.
3489         (struct tui_source_window_base): Add do_scroll_horizontal.
3490         (struct tui_source_window, struct tui_disasm_window): Add
3491         do_scroll_vertical.
3492         (struct tui_data_window, struct tui_cmd_window): Add
3493         do_scroll_horizontal and do_scroll_vertical.
3494         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3495
3496 2019-06-25  Tom Tromey  <tom@tromey.com>
3497
3498         * tui/tui-data.h (struct tui_source_window_base): New struct.
3499         (struct tui_source_window): Derive from tui_source_window_base.
3500         (struct tui_disasm_window): New struct.
3501         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3502         from tui_source_window::clear_detail.
3503         (tui_source_window_base): Rename from tui_source_window.
3504         (~tui_source_window_base): Rename from ~tui_source_window.
3505         (tui_alloc_win_info): Create a tui_disasm_window.
3506
3507 2019-06-25  Tom Tromey  <tom@tromey.com>
3508
3509         * tui/tui-data.h (struct tui_source_window)
3510         (struct tui_data_window): Declare destructors.
3511         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3512         destructors.
3513         (tui_win_info): Simplify.
3514
3515 2019-06-25  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-winsource.c (tui_display_main)
3518         (tui_update_source_windows_with_addr)
3519         (tui_update_all_breakpoint_info): Update.
3520         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3521         (new_height_ok, parse_scrolling_args): Update.
3522         * tui/tui-stack.c (tui_show_frame_info): Update.
3523         * tui/tui-data.h (struct tui_list): Remove.
3524         (tui_source_windows): Return a reference to a std::vector.
3525         * tui/tui-data.c (source_windows): Now a std::vector.
3526         (tui_source_windows): Change return type.
3527         (tui_clear_source_windows): Rewrite.
3528         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3529         (tui_free_all_source_wins_content): Rewrite.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3534         (struct tui_data_window, struct tui_cmd_window): Declare
3535         clear_detail method.
3536         * tui/tui-data.c (tui_source_window::clear_detail)
3537         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3538         methods.
3539         (tui_clear_win_detail): Simplify.
3540
3541 2019-06-25  Tom Tromey  <tom@tromey.com>
3542
3543         * tui/tui-layout.c (make_source_window, make_disasm_window)
3544         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3545         Return the new window.
3546         (show_source_disasm_command, show_data)
3547         (show_source_or_disasm_and_command): Update.
3548
3549 2019-06-25  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3552         parameter.  Return the new window.
3553         (show_source_disasm_command): Update and remove NULL check.
3554         (show_source_or_disasm_and_command): Update.
3555
3556 2019-06-25  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3559
3560 2019-06-25  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-data.h (struct tui_win_info): Make constructor
3563         protected.  Make destructor virtual.  Add initializers.
3564         (tui_source_window, tui_data_window, tui_cmd_window): New
3565         classes.
3566         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3567         constructor.  Add "type" parameter.
3568         (tui_source_window, tui_data_window, tui_cmd_window): New
3569         constructors.
3570         (tui_alloc_win_info): Instantiate the appropriate subclass.
3571
3572 2019-06-25  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-win.c (tui_resize_all): Use delete.
3575         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3576         destructor.
3577         (tui_free_window): Don't declare.
3578         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3579         Update.
3580
3581 2019-06-25  Tom Tromey  <tom@tromey.com>
3582
3583         * tui/tui-data.h (struct tui_win_info): Add constructor.
3584         * tui/tui-data.c (tui_alloc_win_info): Use new.
3585         (tui_free_window): Use delete.
3586
3587 2019-06-22  Tom Tromey  <tom@tromey.com>
3588
3589         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3590         declare.
3591         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3592
3593 2019-06-22  Tom Tromey  <tom@tromey.com>
3594
3595         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3596         declare.
3597         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3598
3599 2019-06-22  Tom de Vries  <tdevries@suse.de>
3600
3601         * dwarf2read.c (create_addrmap_from_aranges)
3602         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3603         instead of '%zu'.
3604
3605 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3606
3607         * dwarf2read.h (dwarf2_section_info_def): Remove.
3608         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3609         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3610         std::vector<dwarf2_section_info>.
3611         (struct dwo_file) <~dwo_file>: Remove.
3612         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3613         types field.
3614         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3615         (dwarf2_read_debug_names): Likewise.
3616         (create_debug_types_hash_table): Change parameter type to
3617         array_view, adjust code accordingly.
3618         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3619         (partial_die_info::fixup): Likewise.
3620         (determine_prefix): Likewise.
3621         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3622
3623 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3624
3625         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3626         gdb_bfd_ref_ptr.
3627         <~dwo_file>: Remove call to gdb_bfd_unref.
3628         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3629         gdb_bfd_ref_ptr::get.
3630
3631 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3632
3633         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3634         type to htab_up.
3635         * dwarf2read.c (struct dwo_file): Initialize fields.
3636         <~dwo_file>: New.
3637         (free_dwo_file): Remove, move content to ~dwo_file.
3638         (struct dwo_file_deleter): Remove.
3639         (dwo_file_up>: Remove custom deleter.
3640         (free_dwo_files): Remove.
3641         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3642         dwo_files.
3643         (process_skeletonless_type_units): Call unique_ptr::get.
3644         (allocate_dwo_file_hash_table): Add deleter to created hash
3645         table.  Change return type to htab_up.
3646         (lookup_dwo_file_slot): Don't memset dwo_file, call
3647         unique_ptr::get.
3648         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3649         (create_dwo_unit_in_dwp_v2): Likewise.
3650         (open_and_init_dwo_file): Likewise.
3651         (free_dwo_file_from_slot): Remove.
3652
3653 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3654
3655         * dwarf2read.h (struct dwarf2_section_info) <readin,
3656         is_virtual>: Change type to bool.
3657         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3658         true instead of 1.
3659
3660 2019-06-19  Tom Tromey  <tom@tromey.com>
3661
3662         * tui/tui-data.h (tui_init_content_element): Don't declare.
3663
3664 2019-06-19  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui-data.h (tui_init_win_info): Don't declare.
3667
3668 2019-06-19  Tom de Vries  <tdevries@suse.de>
3669
3670         * dwarf2read.h (abstract_to_concrete): Change type to
3671         std::unordered_map<sect_offset, std::vector<sect_offset>,
3672         gdb::hash_enum<sect_offset>>.
3673
3674 2019-06-19  Tom Tromey  <tromey@adacore.com>
3675
3676         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3677         EVAL_AVOID_SIDE_EFFECTS specially.
3678
3679 2019-06-19  Tom Tromey  <tromey@adacore.com>
3680
3681         * source-cache.c (highlighter): New global.
3682         (source_cache::get_source_lines): Create a highlighter on demand.
3683
3684 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3685
3686         * defs.h (deprecated_interactive_hook): Delete declaration.
3687         * interps.c (clear_interpreter_hooks): Remove use of
3688         deprecated_interactive_hook.
3689         * top.c (deprecated_interactive_hook): Delete definition.
3690         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3691
3692 2019-06-18  Tom de Vries  <tdevries@suse.de>
3693
3694         PR gdb/24515
3695         * dwarf2read.h (abstract_to_concrete): Change type from
3696         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3697         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3698         * dwarf2read.c (read_variable): Update.
3699         (dwarf2_fetch_die_loc_sect_off): Update.
3700
3701 2019-06-17  Tom de Vries  <tdevries@suse.de>
3702
3703         PR gdb/24617
3704         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3705         accessing parent[parent_len - 1].
3706
3707 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3708
3709         PR gdb/24364
3710         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3711         call dtrace_process_dof with NULL dof.
3712
3713 2019-06-16  Tom de Vries  <tdevries@suse.de>
3714
3715         PR gdb/24445
3716         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3717
3718 2019-06-16  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3721         (make_all_visible): Use address of member.
3722
3723 2019-06-16  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3726         (tui_free_window, free_content, free_content_elements): Remove
3727         unnecessary cast.
3728         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3729         cast.
3730         * tui/tui-regs.c (tui_show_register_group)
3731         (tui_display_registers_from, tui_display_reg_element_at_line):
3732         Remove unnecessary cast.
3733
3734 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * linux-nat.c (normal_mask): Delete.
3737         (_initialize_linux_nat): Don't initialise normal_mask.
3738
3739 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3740
3741         PR gdb/24445
3742         * dwarf-index-write.h (write_psymtabs_to_index): Add
3743         dwz_basename parameter.
3744         * dwarf-index-write.c (write_gdbindex): Move file writing to
3745         write_gdbindex_1.  Change return type void.
3746         (assert_file_size): Move up, remove filename parameter.
3747         (write_gdbindex_1): New function.
3748         (write_debug_names): Change return type to void, call
3749         assert_file_size.
3750         (struct index_wip_file): New struct.
3751         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3752         file logic to index_wip_file.  Write index for dwz file if
3753         needed.
3754         (save_gdb_index_command): Pass basename of dwz file, if present.
3755         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3756         build-id of dwz file, if present.
3757         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3758         (dwarf2_get_dwz_file): Likewise.
3759         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3760         (dwarf2_get_dwz_file): Likewise.
3761
3762 2019-06-16  Tom Tromey  <tom@tromey.com>
3763
3764         * coffread.c (process_coff_symbol): Use xstrdup.
3765         * value.c (create_internalvar): Use xstrdup.
3766
3767 2019-06-16  Tom Tromey  <tom@tromey.com>
3768
3769         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3770         * breakpoint.c (stopin_command, stopat_command)
3771         (until_break_command, decode_location_default): Remove unnecessary
3772         cast.
3773         * utils.c (subset_compare): Remove unnecessary cast.
3774         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3775         cast.
3776         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3777         cast.
3778         * infcmd.c (path_command): Remove unnecessary cast.
3779         * coffread.c (decode_type): Remove unnecessary cast.
3780         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3781         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3782         * tui/tui-stack.c (tui_show_locator_content)
3783         (tui_show_frame_info): Remove unnecessary cast.
3784         * tui/tui-win.c (tui_scroll_forward_command)
3785         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3786         (parse_scrolling_args): Remove unnecessary cast.
3787         * tui/tui-data.c (init_win_info, tui_del_window)
3788         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3789         (free_content_elements): Remove unnecessary cast.
3790         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3791         unnecessary cast.
3792         * tui/tui-source.c (tui_set_source_content)
3793         (tui_vertical_source_scroll): Remove unnecessary cast.
3794         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3795         cast.
3796         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3797         * tui/tui-regs.c (tui_display_registers_from)
3798         (tui_display_register): Remove unnecessary cast.
3799         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3800         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3801         (make_visible): Remove unnecessary cast.
3802         * tui/tui-winsource.c (tui_erase_source_content)
3803         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3804         unnecessary cast.
3805         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3806         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3807         * stabsread.c (read_type, read_array_type, read_range_type):
3808         Remove unnecessary cast.
3809         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3810         (parse_symbol, parse_type, upgrade_type, parse_external)
3811         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3812         unnecessary cast.
3813         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3814
3815 2019-06-16  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-data.c (tui_alloc_generic_win_info)
3818         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3819         checks.
3820
3821 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3822             Andrew Burgess  <andrew.burgess@embecosm.com>
3823
3824         * f-typeprint.c (f_print_type): Don't return early for not
3825         associated or not allocated types.
3826         (f_type_print_varspec_suffix): Add print_rank parameter and print
3827         ranks of array types in case they dangling.
3828         (f_type_print_base): Add print_rank parameter.
3829
3830 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * NEWS: Mention new MI commands.
3833         * break-catch-throw.c (enum exception_event_kind): Move to
3834         breakpoint.h.
3835         (print_mention_exception_catchpoint): Output text as a single
3836         message.
3837         (catch_exception_command_1): Rename to...
3838         (catch_exception_event): ...this, make non-static, update header
3839         command, and change some parameter types.
3840         (catch_catch_command): Update for changes to
3841         catch_exception_command_1.
3842         (catch_throw_command): Likewise.
3843         (catch_rethrow_command): Likewise.
3844         * breakpoint.c (enum exception_event_kind): Delete.
3845         * breakpoint.h (enum exception_event_kind): Moved here from
3846         break-catch-throw.c.
3847         (catch_exception_event): Declare.
3848         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
3849         (mi_cmd_catch_throw): New function.
3850         (mi_cmd_catch_rethrow): New function.
3851         (mi_cmd_catch_catch): New function.
3852         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
3853         'catch-catch' entries.
3854         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
3855         (mi_cmd_catch_rethrow): Declare.
3856         (mi_cmd_catch_catch): Declare.
3857
3858 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * annotate.c (annotate_source_line): Change return type to void,
3861         update implementation to match.
3862         * annotate.h (annotate_source_line): Change return type to void,
3863         update header comment.
3864         * stack.c (print_frame_info): Don't change what frame information
3865         is printed based on whether annotations are on or not.
3866
3867 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
3870         (annotate_source): Make static.
3871         (annotate_source_line): Moved from source.c and renamed from
3872         identify_source_line.  Update the return type.
3873         * annotate.h (annotate_source): Delete declaration.
3874         (annotate_source_line): Declaration moved from source.h, and
3875         renamed from identify_source_line.  Return type updated.
3876         * source.c (identify_source_line): Moved to annotate.c and renamed
3877         to annotate_source_line.
3878         (info_line_command): Remove check of annotation_level.
3879         * source.h (identify_source_line): Move declaration to annotate.h
3880         and rename to annotate_source_line.
3881         * stack.c: Add 'annotate.h' include.
3882         (print_frame_info): Remove check of annotation_level before
3883         calling annotate_source_line.
3884
3885 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3886
3887         * source-cache.c (source_cache::get_plain_source_lines): Use
3888         open_source_file_with_line_charpos instead of just
3889         open_source_file, remove call to find_source_lines.
3890         (source_cache::get_source_lines): Likewise.
3891         * source.c (find_source_lines): Make static.
3892         (get_filename_and_charpos): Renamed into...
3893         (open_source_file_with_line_charpos): ..this along with changes to
3894         return a scoped_fd, and some other minor clean ups.
3895         (identify_source_line): Use open_source_file_with_line_charpos.
3896         (search_command_helper): Use open_source_file_with_line_charpos
3897         instead of just open_source_file, remove call to
3898         find_source_lines.
3899         * source.h (open_source_file_with_line_charpos): Declare new
3900         function.
3901         (find_source_lines): Delete declaration.
3902
3903 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3904
3905         * source.c (get_filename_and_charpos): Remove fullname
3906         parameter.
3907         (identify_source_line): Update call to get_filename_and_charpos.
3908
3909 2019-06-14  Tom Tromey  <tromey@adacore.com>
3910
3911         PR gdb/24502:
3912         * ui-style.h (skip_ansi_escape): Update comment.
3913         * ui-file.h (class no_terminal_escape_file): New class.
3914         * ui-file.c (no_terminal_escape_file::write)
3915         (no_terminal_escape_file::puts): New methods.
3916         * cli/cli-logging.c (handle_redirections): Use
3917         no_terminal_escape_file.
3918
3919 2019-06-14  Tom Tromey  <tromey@adacore.com>
3920
3921         * NEWS: Move convenience variable news above Python news.
3922
3923 2019-06-14  Tom Tromey  <tom@tromey.com>
3924
3925         * gnulib: Move directory to top-level.
3926         * configure.ac: Don't configure gnulib.
3927         * configure: Rebuild.
3928         * common/common-defs.h: Use new path to gnulib.
3929         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3930         (GNULIB_H): Remove.
3931         (INCGNU): Look in new gnulib location.
3932         (HFILES_NO_SRCDIR): Remove gnulib files.
3933         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3934         (generated_files): Remove GNULIB_H.
3935         ($(LIBGNU), all-lib): Remove targets.
3936         (distclean): Don't mention GNULIB_BUILDDIR.
3937         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3938
3939 2019-06-14  Tom Tromey  <tromey@adacore.com>
3940
3941         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3942         Warn if symbol file does not provide any symbols.
3943
3944 2019-06-14  Tom Tromey  <tromey@adacore.com>
3945
3946         * source.c (find_and_open_source): Respect basenames_may_differ.
3947
3948 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3949
3950         * annotate.c (annotate_breakpoints_invalid): Make use of
3951         scoped_restore_terminal_state.
3952         (annotate_frames_invalid): Likewise.
3953
3954 2019-06-14  Tom Tromey  <tromey@adacore.com>
3955
3956         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3957         allow assignment to an internalvar.
3958
3959 2019-06-14  Tom Tromey  <tromey@adacore.com>
3960
3961         * ada-lex.l: Allow "_" in attribute names.
3962
3963 2019-06-14  Tom Tromey  <tromey@adacore.com>
3964
3965         PR gdb/24653:
3966         * regcache.c (registers_changed): Don't call alloca.
3967         * top.c (execute_command): Don't call alloca.
3968
3969 2019-06-13  Pedro Alves  <palves@redhat.com>
3970
3971         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3972         'expression'.  When parsing an expression, error out if there's
3973         junk after "unlimited".
3974         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3975         (do_set_command): Adjust calls to is_unlimited_literal.
3976
3977 2019-06-13  Pedro Alves  <palves@redhat.com>
3978
3979         * compile/compile.c (make_compile_options_def_group): Add braces
3980         around array_view initializer.
3981         * thread.c (make_thread_apply_all_options_def_group)
3982         (make_thread_apply_all_options_def_group): Likewise.
3983
3984 2019-06-13  Pedro Alves  <palves@redhat.com>
3985
3986         * NEWS (New commands): Mention "maint test-options
3987         require-delimiter", "maint test-options unknown-is-error", "maint
3988         test-options unknown-is-operand" and "maint show
3989         test-options-completion-result".
3990         (New command options, command completion): New section.
3991         (Completion improvements): New section.
3992         Mention that you can abbreviate "unlimited".
3993
3994 2019-06-13  Pedro Alves  <palves@redhat.com>
3995
3996         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3997         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3998         * unittests/cli-utils-selftests.c (test_parse_flags)
3999         (test_parse_flags_qcs): Delete.
4000         (test_cli_utils): Don't call deleted functions.
4001
4002 2019-06-13  Pedro Alves  <palves@redhat.com>
4003
4004         * thread.c: Include "cli/cli-option.h".
4005         (tp_array_compar_ascending): Global.
4006         (tp_array_compar): Delete function.
4007         (tp_array_compar_ascending, tp_array_compar_descending): New
4008         functions.
4009         (ascending_option_def, qcs_flag_option_def)
4010         (thr_qcs_flags_option_defs)
4011         (make_thread_apply_all_options_def_group)
4012         (make_thread_apply_options_def_group): New.
4013         (thread_apply_all_command): Use gdb::option::process_options.
4014         (thread_apply_command_completer)
4015         (thread_apply_all_command_completer): New.
4016         (thread_apply_command): Use gdb::option::process_options.
4017         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4018         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4019         to generate help text of "thread apply".  Adjust "taas"'s help.
4020         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4021         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4022
4023 2019-06-13  Pedro Alves  <palves@redhat.com>
4024
4025         * thread.c (thread_apply_command): Check for invalid TID with
4026         isdigit instead of !isalpha.
4027
4028 2019-06-13  Pedro Alves  <palves@redhat.com>
4029
4030         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4031         (validate_flags_qcs): New.
4032         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4033         (validate_flags_qcs): Declare.
4034         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4035         (make_frame_apply_options_def_group): New.
4036         (frame_apply_command_count): Process options with
4037         gdb::option::process_options.
4038         (frame_apply_completer): New.
4039         (frame_apply_level_completer, frame_apply_all_completer)
4040         (frame_apply_completer): New.
4041         (_initialize_stack): Update help of "frame apply", "frame apply
4042         level", "frame apply all" and "faas" to mention supported options
4043         and install command completers.
4044         * stack.h (frame_apply_all_completer): Declare.
4045         * thread.c: Include "stack.h".
4046         (tfaas_command): Add "--".
4047         (_initialize_thread): Update help "tfaas" to mention supported
4048         options and install command completer.
4049
4050 2019-06-13  Pedro Alves  <palves@redhat.com>
4051
4052         * completer.c (complete_nested_command_line): New.
4053         (gdb_completion_word_break_characters_throw): Add assertion.
4054         * completer.h (complete_nested_command_line): Declare.
4055
4056 2019-06-13  Pedro Alves  <palves@redhat.com>
4057
4058         * stack.c (parse_backtrace_qualifiers): New.
4059         (backtrace_command): Use it.
4060         (backtrace_command_completer): Complete on qualifiers.
4061
4062 2019-06-13  Pedro Alves  <palves@redhat.com>
4063
4064         * frame.c: Include "cli/cli-option.h.
4065         (user_set_backtrace_options): New.
4066         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4067         Delete.
4068         (get_prev_frame): Adjust.
4069         (boolean_option_def, uinteger_option_def)
4070         (set_backtrace_option_defs): New.
4071         (_initialize_frame): Adjust and use
4072         gdb::option::add_setshow_cmds_for_options to install "set
4073         backtrace past-main" and "set backtrace past-entry".
4074         * frame.h: Include "cli/cli-option.h".
4075         (struct frame_print_options): Forward declare.
4076         (print_frame_arguments_all, print_frame_arguments_scalars)
4077         (print_frame_arguments_none): Declare.
4078         (print_entry_values): Delete declaration.
4079         (struct frame_print_options, user_frame_print_options): New.
4080         (struct set_backtrace_options): New.
4081         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4082         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4083         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4084         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4085         (list_args_or_locals): Add frame_print_options parameter.
4086         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4087         * python/py-framefilter.c (enumerate_args): Pass down
4088         USER_FRAME_PRINT_OPTIONS.
4089         * stack.c: Include "cli/cli-option.h".
4090         (print_frame_arguments_all, print_frame_arguments_scalars)
4091         (print_frame_arguments_none): Declare.
4092         (print_raw_frame_arguments, print_entry_values): Delete.
4093         (user_frame_print_options): New.
4094         (boolean_option_def, enum_option_def, frame_print_option_defs):
4095         New.
4096         (struct backtrace_cmd_options): New.
4097         (bt_flag_option_def): New.
4098         (backtrace_command_option_defs): New.
4099         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4100         (print_frame_arg, read_frame_arg, print_frame_args)
4101         (print_frame_info, print_frame): Add frame_print_options parameter
4102         and use it.
4103         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4104         (backtrace_command_1): Add frame_print_options and
4105         backtrace_cmd_options parameters and use them.
4106         (make_backtrace_options_def_group): New.
4107         (backtrace_command): Process command options with
4108         gdb::option::process_options.
4109         (backtrace_command_completer): New.
4110         (_initialize_stack): Extend "backtrace"'s help to mention
4111         supported options.  Install completer for "backtrace".
4112         Install some settings commands with add_setshow_cmds_for_options.
4113
4114 2019-06-13  Pedro Alves  <palves@redhat.com>
4115
4116         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4117         and that "set/show print raw frame-arguments" are now deprecated.
4118
4119         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4120         command.
4121         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4122         * stack.c (_initialize_stack): Install "set/show print
4123         raw-frame-arguments", and deprecate "set/show print raw
4124         frame-arguments".
4125         * valprint.c (_initialize_valprint): Deprecate "set/show print
4126         raw".
4127
4128 2019-06-13  Pedro Alves  <palves@redhat.com>
4129
4130         * compile/compile.c (struct compile_options): New.
4131         (compile_flag_option_def, compile_command_option_defs)
4132         (make_compile_options_def_group): New.
4133         (compile_file_command): Handle options with
4134         gdb::option::process_options.
4135         (compile_file_command_completer): New function.
4136         (compile_code_command): Handle options with
4137         gdb::option::process_options.
4138         (compile_code_command_completer): New function.
4139         (_initialize_compiler): Install completers for "compile code" and
4140         "compile file".  Mention available options in "compile code" and
4141         "compile code"'s help.
4142         * completer.c (advance_to_completion_word): New, factored out from
4143         ...
4144         (advance_to_expression_complete_word_point): ... this.
4145         (advance_to_filename_complete_word_point): New.
4146         * completer.h (advance_to_filename_complete_word_point): New
4147         declaration.
4148
4149 2019-06-13  Pedro Alves  <palves@redhat.com>
4150
4151         * compile/compile.c: Include "cli/cli-option.h".
4152         (compile_print_value): Scope data pointer is now a
4153         value_print_options pointer; adjust.
4154         (compile_print_command): Process options.  Scope data pointer is
4155         now a value_print_options pointer; adjust.
4156         (_initialize_compile): Update "compile print"'s help to include
4157         supported options.  Install a completer for "compile print".
4158         * cp-valprint.c (show_vtblprint, show_objectprint)
4159         (show_static_field_print): Delete.
4160         (_initialize_cp_valprint): Don't install "set print
4161         static-members", "set print vtbl", "set print object" here.
4162         * printcmd.c: Include "cli/cli-option.h" and
4163         "common/gdb_optional.h".
4164         (print_command_parse_format): Rework to fill in a
4165         value_print_options instead of a format_data.
4166         (print_value): Change parameter type from format_data pointer to
4167         value_print_options reference.  Adjust.
4168         (print_command_1): Process options.  Adjust to pass down a
4169         value_print_options.
4170         (print_command_completer): New.
4171         (_initialize_printcmd): Install print_command_completer as
4172         handle_brkchars completer for the "print" command.  Update
4173         "print"'s help to include supported options.
4174         * valprint.c: Include "cli/cli-option.h".
4175         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4176         here from cp-valprint.c.
4177         (boolean_option_def, uinteger_option_def)
4178         (value_print_option_defs, make_value_print_options_def_group):
4179         New.  Use gdb::option::add_setshow_cmds_for_options to install
4180         "set print elements", "set print null-stop", "set print repeats",
4181         "set print pretty", "set print union", "set print array", "set
4182         print address", "set print symbol", "set print array-indexes".
4183         * valprint.h: Include <string> and "cli/cli-option.h".
4184         (make_value_print_options_def_group): Declare.
4185         (print_value): Change parameter type from format_data pointer to
4186         value_print_options reference.
4187         (print_command_completer): Declare.
4188
4189 2019-06-13  Pedro Alves  <palves@redhat.com>
4190
4191         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4192         (COMMON_SFILES): Add maint-test-settings.c.
4193         * cli/cli-decode.c (boolean_enums): New global, factored out from
4194         ...
4195         (add_setshow_boolean_cmd): ... here.
4196         * cli/cli-decode.h (boolean_enums): Declare.
4197         * cli/cli-option.c: New file.
4198         * cli/cli-option.h: New file.
4199         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4200         factored out from ...
4201         (parse_cli_boolean_value(const char *)): ... this.
4202         (is_unlimited_literal): Change parameter type to pointer to
4203         pointer.  Adjust and advance ARG pointer.
4204         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4205         (parse_cli_var_enum): New, factored out from ...
4206         (do_set_command): ... this.  Adjust.
4207         * cli/cli-setshow.h (parse_cli_boolean_value)
4208         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4209         (parse_cli_var_enum): Declare.
4210         * cli/cli-utils.c: Include "cli/cli-option.h".
4211         (get_ulongest): New.
4212         * cli/cli-utils.h (get_ulongest): Declare.
4213         (check_for_argument): New overloads.
4214         * maint-test-options.c: New file.
4215
4216 2019-06-13  Pedro Alves  <palves@redhat.com>
4217
4218         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4219         parse a range if "-" is at the end of the string.
4220
4221 2019-06-13  Pedro Alves  <palves@redhat.com>
4222
4223         * cli/cli-setshow.c (parse_auto_binary_operation)
4224         (parse_cli_boolean_value): Don't allow "o".
4225
4226 2019-06-13  Pedro Alves  <palves@redhat.com>
4227
4228         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4229         * NEWS: Mention maint test-settings KIND.
4230         * maint-test-settings.c: New file.
4231
4232 2019-06-13  Pedro Alves  <palves@redhat.com>
4233
4234         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4235         completer.
4236         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4237         "set" completers.
4238
4239 2019-06-13  Pedro Alves  <palves@redhat.com>
4240
4241         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4242         after item.
4243
4244 2019-06-13  Pedro Alves  <palves@redhat.com>
4245
4246         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4247
4248 2019-06-13  Pedro Alves <palves@redhat.com>
4249
4250         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4251         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4252         call.
4253         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4254         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4255         calls.
4256         (check_for_argument): Skip spaces after argument.
4257
4258 2019-06-13  Pedro Alves  <palves@redhat.com>
4259
4260         * thread.c (thread_apply_command): Adjust TID parsing.
4261         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4262         detected before end of string.
4263         (tid_is_in_list): Error out if LIST is invalid.
4264
4265 2019-06-13  Pedro Alves  <palves@redhat.com>
4266
4267         * completer.c (complete_line_internal_1): Rewind completion word
4268         point.
4269         (completion_tracker::advance_custom_word_point_by): Change
4270         parameter type to int.
4271         * completer.h (completion_tracker::advance_custom_word_point_by):
4272         Likewise.
4273
4274 2019-06-13  Pedro Alves  <palves@redhat.com>
4275
4276         * completer.c (advance_to_completion_word): Handle delimiters.
4277
4278 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4279
4280         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4281
4282 2019-06-11  Tom Tromey  <tom@tromey.com>
4283
4284         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4285         (xmalloc_failed): Move to alloc.c.
4286         * alloc.c: New file.
4287         * Makefile.in (COMMON_SFILES): Add alloc.c.
4288
4289 2019-06-11  Tom Tromey  <tom@tromey.com>
4290
4291         * nat/linux-waitpid.c: Don't include server.h.
4292         (linux_debug): Remove.
4293         (my_waitpid): Update.
4294
4295 2019-06-11  Tom Tromey  <tromey@adacore.com>
4296
4297         * infcall.c (_initialize_infcall): Remove trailing newline from
4298         help.
4299         * user-regs.c (_initialize_user_regs): Remove trailing newline
4300         from help.
4301         * typeprint.c (_initialize_typeprint): Remove trailing newline
4302         from help.
4303         * reverse.c (_initialize_reverse): Remove trailing newlines from
4304         help.
4305         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4306         from help.
4307         * language.c (add_set_language_command): Remove trailing newline
4308         from help.
4309         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4310         help.
4311         * disasm.c (_initialize_disasm): Remove trailing newline from
4312         help.
4313         * top.c (init_main): Remove trailing newline from help.
4314         * interps.c (_initialize_interpreter): Remove trailing newline
4315         from help.
4316         * btrace.c (_initialize_btrace): Remove trailing newlines from
4317         help.
4318         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4319         from help.
4320         * python/python.c (_initialize_python): Remove trailing newline
4321         from help.
4322         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4323         help.
4324         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4325         from help.  Reformat some text.
4326         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4327         from help.
4328         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4329         newline from help.
4330
4331 2019-06-11  Tom Tromey  <tromey@adacore.com>
4332
4333         * darwin-nat.c (darwin_decode_exception_message)
4334         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4335
4336 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4337
4338         * valops.c (value_slice): Check for not allocated or not
4339         associated values.
4340
4341 2019-06-10  Tom de Vries  <tdevries@suse.de>
4342
4343         PR gdb/24618
4344         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4345         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4346         invalid.
4347
4348 2019-06-10  Tom de Vries  <tdevries@suse.de>
4349
4350         PR gdb/24611
4351         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4352         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4353
4354 2019-06-10  Tom de Vries  <tdevries@suse.de>
4355
4356         PR symtab/24545
4357         * symtab.c (struct demangled_name_entry): Add language field.
4358         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4359         static minimal symbol".  Set and use language field.
4360
4361 2019-06-10  Tom Tromey  <tromey@adacore.com>
4362
4363         * ada-lang.c (_initialize_ada_language): Update help text.
4364
4365 2019-06-10  Tom Tromey  <tromey@adacore.com>
4366
4367         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4368         with a newline.
4369         * guile/guile.c (handle_boot_error): Don't end warning with a
4370         newline.
4371         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4372         warning with a newline.
4373         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4374         newline.
4375         (s12z_frame_cache): Likewise.
4376         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4377         a newline.
4378         * solib-svr4.c (disable_probes_interface): Don't end warning with
4379         a newline.
4380         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4381         newline.
4382         * python/python.c (do_finish_initialization): Don't end warning
4383         with a newline.
4384
4385 2019-06-10  Tom Tromey  <tom@tromey.com>
4386
4387         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4388         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4389         gdbpy_enter.
4390
4391 2019-06-10  Tom Tromey  <tromey@adacore.com>
4392
4393         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4394         data.
4395         (elf_new_init): Don't call stabsread_new_init.
4396         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4397         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4398         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4399
4400 2019-06-10  Tom de Vries  <tdevries@suse.de>
4401
4402         PR symtab/16264
4403         PR symtab/24517
4404         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4405
4406 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4407
4408         * source.c (find_and_open_source): Also rewrite relative file
4409         names.
4410
4411 2019-04-26  Amos Bird  <amosbird@gmail.com>
4412
4413         * annotate.c (annotate_thread_exited): Add "thread-exited"
4414         annotation.
4415
4416 2019-06-06  Tom Tromey  <tromey@adacore.com>
4417
4418         * maint.h (class scoped_command_stats): Use
4419         DISABLE_COPY_AND_ASSIGN.
4420         <print_time>: New method.
4421         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4422         print_time.
4423         (scoped_command_stats::print_time): New method.
4424
4425 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4426
4427         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4428         instructions of lengths 6 or 8 bytes.
4429
4430 2019-06-04  Pedro Alves  <palves@redhat.com>
4431
4432         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4433
4434         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4435         * breakpoint.c (condition_completer): Likewise.
4436         * cli/cli-dump.c (scan_expression): Likewise.
4437         * common/filestuff.c (mkdir_recursive): Likewise.
4438         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4439         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4440         (gdb_abspath): Likewise.
4441         * compile/compile-cplus-types.c
4442         (compile_cplus_instance::decl_name): Likewise.
4443         * completer.c (complete_explicit_location):
4444         (signal_completer, reg_or_group_completer_1): Likewise.
4445         * cp-support.c (cp_remove_params_if_any): Likewise.
4446         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4447         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4448         * infcmd.c (strip_bg_char): Likewise.
4449         * linespec.c (copy_token_string): Likewise.
4450         * mi/mi-main.c (output_cores): Likewise.
4451         * psymtab.c (psymtab_search_name):
4452         * symfile.c (test_set_ext_lang_command): Likewise.
4453         * target.c (target_fileio_read_stralloc): Likewise.
4454         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4455         * value.c (complete_internalvar): Likewise.
4456
4457 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4458
4459         Add objfile property to gdb.Type.
4460         * NEWS: Mention Python API addition.
4461         * python/py-type.c (typy_get_objfile): New method.
4462
4463 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4464
4465         * NEWS: Mention the new set|show style [title|highlight].
4466         Mention changes to "show style", "help" and "apropos".
4467
4468 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4469
4470         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4471         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4472         instead of print_help_for_command.
4473         (print_doc_of_command): New function.
4474         (help_list): Add 'apropos -v word' suggestion.
4475         (print_help_for_command): Style the command name using title style.
4476         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4477         (_initialize_cli_cmds): Describe -v in apropos_command help.
4478
4479 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4480
4481         * cli/cli-style.h (cli_style_option): Add name in constructor,
4482         add m_name class member, add constructor with intensity,
4483         add name class function.
4484         (cli_style_option::add_setshow_commands): Remove name argument.
4485         (highlight_style, title_style): New styles.
4486         * cli/cli-style.c (do_show): New function that shows a style
4487         characteristic styling the style name with itself.
4488         (set_style_name): New function.
4489         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4490         Update all callers according to the changes in cli/cli-style.h.
4491         * utils.h (fputs_highlighted): New function.
4492         * utils.c (fputs_highlighted): Likewise.
4493
4494 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4495
4496         * NEWS: Mention new pipe command and new convenience variables.
4497
4498 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4499
4500         * cli/cli-cmds.c (pipe_command): New function.
4501         (_initialize_cli_cmds): Call add_com for pipe_command.
4502         Define | as an alias for pipe.
4503         (exit_status_set_internal_vars): New function.
4504         (shell_escape): Call exit_status_set_internal_vars.
4505         cli/cli-decode.c (find_command_name_length): Recognize | as
4506         a single character command.
4507
4508 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4509
4510         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4511         top.c (execute_command_to_ui_file): New function, mostly a copy
4512         of execute_command_to_string.
4513         (execute_command_to_string): Implement by calling
4514         execute_command_to_ui_file.
4515
4516 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4517
4518         * top.h (saved_command_line): Remove declaration.
4519         * top.c (previous_saved_command_line, previous_repeat_arguments):
4520         New variables.
4521         (saved_command_line): Make static, define together with other
4522         'repeat variables'.
4523         (dont_repeat): Clear repeat_arguments.
4524         (repeat_previous, get_saved_command_line, save_command_line):
4525         New functions.
4526         (gdb_init): Initialize saved_command_line
4527         and previous_saved_command_line.
4528         * main.c (captured_main_1): Remove saved_command_line initialization.
4529         * event-top.c (handle_line_of_input): Update to use
4530         the new 'repeat' related functions instead of direct access to
4531         saved_command_line.
4532         * command.h (repeat_previous, get_saved_command_line,
4533         save_command_line): New declarations.
4534         (dont_repeat): Add comment.
4535
4536 2019-05-30  Tom Tromey  <tromey@adacore.com>
4537
4538         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4539         Fix comment.
4540         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4541
4542 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4543
4544         PR cli/24587
4545         * completer.c (complete): Initialize variable word.
4546
4547 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4548
4549         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4550         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4551         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4552         'body' is NULL to the outter 'if', protecting the '!is_define'
4553         situation as well.
4554
4555 2019-05-29  Tom Tromey  <tromey@adacore.com>
4556
4557         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4558         (dwarf_unknown): New function.
4559         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4560         (dwarf_type_encoding_name): Use dwarf_unknown.
4561
4562 2019-05-29  Tom Tromey  <tromey@adacore.com>
4563
4564         PR c++/20020:
4565         * cp-valprint.c (cp_print_value_fields): Call
4566         cp_print_static_field inside "try".
4567
4568 2019-05-29  Tom Tromey  <tromey@adacore.com>
4569
4570         * inflow.c (struct terminal_info): Add default operator=.
4571         * configure: Rebuild.
4572         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4573         -Wdeprecated-copy-dtor, -Wredundant-move.
4574
4575 2019-05-29  Tom Tromey  <tromey@adacore.com>
4576
4577         * NEWS: Add entry.
4578         * infcmd.c (print_return_value_1): Handle finish_print
4579         option.
4580         (show_print_finish): New function.
4581         (_initialize_infcmd): Add "set/show print finish" commands.
4582         * valprint.c (user_print_options): Initialize new member.
4583         * valprint.h (struct value_print_options) <finish_print>: New
4584         member.
4585
4586 2019-05-28  Tom Tromey  <tromey@adacore.com>
4587
4588         * ada-lang.c (ada_remove_Xbn_suffix)
4589         (find_old_style_renaming_symbol)
4590         (parse_old_style_renaming): Remove.
4591         (ada_find_renaming_symbol): Don't call
4592         find_old_style_renaming_symbol.
4593         (ada_is_renaming_symbol): Rename from
4594         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4595         bool.  Now static.
4596         (ada_read_var_value): Update and simplify.
4597         * ada-exp.y (write_var_or_type): Remove old code.
4598
4599 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4600
4601         * event-top.c: Remove include comment.
4602         * inflow.c (class scoped_ignore_sigttou): Move from here...
4603         * inflow.h (class scoped_ignore_sigttou): ...to here.
4604         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4605         * top.c:  Remove include comment.
4606
4607 2019-05-27  Tom Tromey  <tom@tromey.com>
4608
4609         * NEWS: Fix typo.
4610
4611 2019-05-22  Tom Tromey  <tromey@adacore.com>
4612
4613         * target.c (target_follow_exec): Constify parameter.
4614         * target-delegates.c: Rebuild.
4615         * remote.c (remote_target::follow_exec): Constify parameter.
4616         * infrun.c (follow_exec): Constify parameter.
4617         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4618         (target_follow_exec): Likewise.
4619
4620 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4621
4622         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4623         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4624
4625 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4626
4627         * NEWS: Add debugredirect and testsuite sections.
4628
4629 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4630
4631         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4632         target descriptions using exclusively floating point register name
4633         aliases.
4634
4635 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4636
4637         PR gdb/18644:
4638         * f-lang.c (build_fortran_types): Handle the case where
4639         gdbarch_floatformat_for_type returns a nullptr.
4640
4641 2019-05-21  Tom de Vries  <tdevries@suse.de>
4642
4643         PR cli/24587
4644         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4645
4646 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4647
4648         PR gdb/18644:
4649         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4650         16-byte floats.
4651         * i386-tdep.c (i386_floatformat_for_type): Use
4652         floatformats_ia64_quad for the 16-byte floating point component
4653         within a fortran 32-byte complex number.
4654
4655 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4656
4657         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4658         delete default constructor.
4659         (find_partial_die): Update to return const struct.
4660         (partial_die_parent_scope): Move variable declaration into scope
4661         of its use and change its type to auto.
4662         (guess_partial_die_structure_name): Likewise.
4663         (partial_die_info::fixup): Likewise.
4664
4665 2019-05-17  Tom Tromey  <tromey@adacore.com>
4666
4667         * source.c (find_and_open_source): Remove cast.
4668
4669 2019-05-17  Tom Tromey  <tromey@adacore.com>
4670
4671         * annotate.c (annotate_source): Make "filename" const.
4672         * annotate.h (annotate_source): Use const.
4673
4674 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4675
4676         * disasm.c (set_disassembler_options): Send errors to stderr.
4677
4678 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4679
4680         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4681         (cli_interp_base::set_logging): Check debug_redirect.
4682         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4683         * cli/cli-logging.c (debug_redirect): Add static variable.
4684         (pop_output_files): Add default param.
4685         (handle_redirections): Print debug setting.
4686         (show_logging_command): Likewise.
4687         (_initialize_cli_logging): Add debugredirect command.
4688         * interps.c (current_interp_set_logging): Add debug_redirect
4689         parameter.
4690         * interps.h (set_logging): Add debug_redirect parameter.
4691         (current_interp_set_logging): Likewise.
4692         * mi/mi-common.h: Likewise.
4693         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4694
4695 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4696             Tom Tromey  <tromey@adacore.com>
4697
4698         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4699         directly.
4700         * cli/cli-interp.h (make_logging_output): Remove declaration.
4701         * cli/cli-logging.c (make_logging_output): Remove function.
4702         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4703         directly.
4704         * ui-file.c (tee_file::tee_file): Remove bools.
4705         (tee_file::~tee_file): Remove deletes.
4706         * ui-file.h (tee_file): Remove bools.
4707
4708 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4709
4710         * mi/mi-cmds.h (mi_cmd_complete): New function.
4711         * mi/mi-main.c (mi_cmd_complete): Likewise.
4712         * mi/mi-cmds.c: Define new MI command -complete.
4713         * NEWS: Mention new -complete command.
4714
4715 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4716
4717         * completer.h (complete): New function.
4718         * completer.c (complete): Likewise.
4719         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4720         function defined in completer.h.
4721
4722 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4723
4724         * MAINTAINERS (Write After Approval): Add myself.
4725
4726 2019-05-17  Tom de Vries  <tdevries@suse.de>
4727
4728         PR gdb/24094
4729         * dwarf2read.c (struct cu_partial_die_info): New struct.
4730         (find_partial_die): Return cu_partial_die_info.
4731         (partial_die_parent_scope, guess_partial_die_structure_name)
4732         (partial_die_info::fixup): Handle new return type of find_partial_die.
4733
4734 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4735
4736         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4737         "std::string", simplifying the algorithm.
4738
4739 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4740
4741         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4742         (stap_static_probe_ops::get_probes): Likewise.
4743
4744 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4745
4746         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4747         '-')" and "else if".
4748         (stap_parse_single_operand): Join checks for
4749         "gdbarch_stap_parse_special_token_p" and
4750         "gdbarch_stap_parse_special_token" in the same "if" statement.
4751         Invert check when verifying for operation on register
4752         displacement.
4753
4754 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4755
4756         * stap-probe.c (stap_get_opcode): Update comment.
4757         (stap_get_expected_argument_type): Likewise.
4758         (handle_stap_probe): Likewise.
4759
4760 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4761
4762         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4763         return type to 'bool'.  Adjust comment.  Use 'bool' when
4764         appropriate.
4765         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4766         * stap-probe.c (stap_parse_argument_1): Likewise.
4767         (stap_is_operator): Likewise.
4768         (stap_is_generic_prefix): Likewise.
4769         (stap_is_register_prefix): Likewise.
4770         (stap_is_register_indirection_prefix): Likewise.
4771         (stap_is_integer_prefix): Likewise.
4772         (stap_generic_check_suffix): Likewise.
4773         (stap_check_integer_suffix): Likewise.
4774         (stap_check_register_suffix): Likewise.
4775         (stap_check_register_indirection_suffix): Likewise.
4776         (stap_parse_register_operand): Likewise.
4777         (stap_parse_single_operand): Likewise.
4778         (stap_parse_argument_1): Likewise.
4779         (stap_probe::get_argument_count): Likewise.
4780         (stap_is_operator): Likewise.
4781
4782 2019-05-16  Tom Tromey  <tromey@adacore.com>
4783
4784         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4785         keyword to foreach.
4786
4787 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4788
4789         * linux-thread-db.c (try_thread_db_load_1): Change return type
4790         to bool.
4791         (try_thread_db_load): Likewise.
4792         (try_thread_db_load_from_pdir_1): Likewise.
4793         (try_thread_db_load_from_pdir): Likewise.
4794         (try_thread_db_load_from_sdir): Likewise.
4795         (try_thread_db_load_from_dir): Likewise.
4796         (thread_db_load_search): Likewise.
4797         (has_libpthread): Likewise.
4798         (thread_db_load): Likewise.
4799
4800 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4801
4802         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4803         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4804         NULL, and complain/return if that's the case.
4805
4806 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4807
4808         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4809         (advance, posn, abstract_read_memory): New functions.
4810         [struct mem_read_abstraction]: New struct.
4811         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4812
4813 2019-05-14  Tom Tromey  <tromey@adacore.com>
4814
4815         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4816         value is not lval_memory.
4817
4818 2019-05-14  Tom Tromey  <tromey@adacore.com>
4819
4820         * solib.c (info_sharedlibrary_command): Style the file name.
4821
4822 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4823
4824         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4825         (aarch64_vnv_type): Likewise.
4826         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4827         * common/tdesc.c: Likewise.
4828         * common/tdesc.h (enum tdesc_type_kind): Likewise.
4829         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
4830         * features/aarch64-fpu.xml: Add ieee half view.
4831         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
4832         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
4833         * gdbtypes.h (struct builtin_type): Likewise.
4834         (struct objfile_type): Likewise.
4835
4836 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
4837
4838         * language.c (language_sniff_from_mangled_name): Fix "langauge"
4839         typo.
4840         * location.h (string_to_event_location): Likewise.
4841
4842 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
4843
4844         GDB 8.3 released.
4845
4846 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4847
4848         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
4849         New variable declaration.
4850         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
4851         New variable.
4852         (print_one_breakpoint): Use ui_out::test_flags and new global
4853         variable to compute use_fixed_output.
4854         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
4855         Remove.
4856         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
4857         (mi_multi_location_breakpoint_output_fixed): Remove.
4858         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
4859         new variable.
4860         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
4861         fix_multi_location_breakpoint_output flag if version >= 3.
4862         * ui-out.h (enum ui_out_flag)
4863         <fix_multi_location_breakpoint_output>: New enumerator.
4864
4865 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
4866
4867         * contrib/cc-with-tweaks.sh: Validate dwz's work.
4868
4869 2019-05-10  Tom Tromey  <tromey@adacore.com>
4870
4871         * ada-lang.c (catch_ada_completer): New function.
4872         (_initialize_ada_language): Use it.
4873
4874 2019-05-10  Tom Tromey  <tromey@adacore.com>
4875
4876         * thread.c (print_thread_info): Make "requested_threads" const.
4877         * gdbthread.h (print_thread_info): Make "requested_threads"
4878         const.
4879         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4880         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4881
4882 2019-05-08  Tom Tromey  <tom@tromey.com>
4883
4884         * gdbtypes.c (objfile_type_data): Change type.
4885         (objfile_type, _initialize_gdbtypes): Update.
4886
4887 2019-05-08  Tom Tromey  <tom@tromey.com>
4888
4889         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4890         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4891         (_initialize_dwarf2_frame): Update.
4892
4893 2019-05-08  Tom Tromey  <tom@tromey.com>
4894
4895         * objc-lang.c (objc_objfile_data): Change type.
4896         (find_methods): Update.
4897         (_initialize_objc_lang): Remove.
4898
4899 2019-05-08  Tom Tromey  <tom@tromey.com>
4900
4901         * stabsread.c (rs6000_builtin_type_data): Change type.
4902         (rs6000_builtin_type, _initialize_stabsread): Update.
4903
4904 2019-05-08  Tom Tromey  <tom@tromey.com>
4905
4906         * mips-tdep.c (mips_pdr_data): Remove.
4907         (_initialize_mips_tdep): Update.
4908
4909 2019-05-08  Tom Tromey  <tom@tromey.com>
4910
4911         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4912         (hppa_init_objfile_priv_data, read_unwind_info)
4913         (find_unwind_entry, _initialize_hppa_tdep): Update.
4914
4915 2019-05-08  Tom Tromey  <tom@tromey.com>
4916
4917         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4918         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4919         on obstack.
4920         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4921
4922 2019-05-08  Tom Tromey  <tom@tromey.com>
4923
4924         * mdebugread.c (basic_type_data): Change type.
4925         (basic_type, _initialize_mdebugread): Update.
4926
4927 2019-05-08  Tom Tromey  <tom@tromey.com>
4928
4929         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4930
4931 2019-05-08  Tom Tromey  <tom@tromey.com>
4932
4933         * nto-tdep.c (nto_inferior_data_reg): Change type.
4934         (nto_inferior_data): Update.
4935         (nto_inferior_data_cleanup, nto_new_inferior_data)
4936         (_initialize_nto_tdep): Remove.
4937         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4938
4939 2019-05-08  Tom Tromey  <tom@tromey.com>
4940
4941         * ada-lang.c (struct ada_inferior_data): Add initializers.
4942         (ada_inferior_data): Change type.
4943         (ada_inferior_data_cleanup): Remove.
4944         (get_ada_inferior_data, ada_inferior_exit)
4945         (struct ada_pspace_data): Add initializers, destructor.
4946         (ada_pspace_data_handle): Change type.
4947         (get_ada_pspace_data): Update.
4948         (ada_pspace_data_cleanup): Remove.
4949
4950 2019-05-08  Tom Tromey  <tom@tromey.com>
4951
4952         * coffread.c (struct coff_symfile_info): Add initializers.
4953         (coff_objfile_data_key): Move lower.  Change type.
4954         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4955         Update.
4956         (coff_free_info): Remove.
4957
4958 2019-05-08  Tom Tromey  <tom@tromey.com>
4959
4960         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4961         (fbsd_pspace_data_handle): Move lower.  Change type.
4962         (get_fbsd_pspace_data): Update.
4963         (fbsd_pspace_data_cleanup): Remove.
4964         (_initialize_fbsd_tdep): Update.
4965
4966 2019-05-08  Tom Tromey  <tom@tromey.com>
4967
4968         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4969         (get_ada_tasks_pspace_data): Update.
4970         (ada_tasks_pspace_data_cleanup): Remove.
4971         (_initialize_tasks): Update.
4972         (ada_tasks_inferior_data_handle): Change type.
4973         (get_ada_tasks_inferior_data): Update.
4974         (ada_tasks_inferior_data_cleanup): Remove.
4975         (struct ada_tasks_pspace_data): Add initializers.
4976
4977 2019-05-08  Tom Tromey  <tom@tromey.com>
4978
4979         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4980         * symfile-debug.c (debug_sym_get_probes): Change type.
4981         * stap-probe.c (handle_stap_probe):
4982         (stap_static_probe_ops::get_probes): Change type.
4983         * probe.h (class static_probe_ops) <get_probes>: Change type.
4984         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4985         (parse_probes_in_pspace): Update.
4986         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4987         Update.
4988         (any_static_probe_ops::get_probes): Change type.
4989         * elfread.c (elfread_data): New typedef.
4990         (probe_key): Change type.
4991         (elf_get_probes): Likewise.  Update.
4992         (probe_key_free): Remove.
4993         (_initialize_elfread): Update.
4994         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4995         Change type.
4996         (dtrace_process_dof_probe, dtrace_process_dof)
4997         (dtrace_static_probe_ops::get_probe): Change type.
4998
4999 2019-05-08  Tom Tromey  <tom@tromey.com>
5000
5001         * xcoffread.c (struct xcoff_symfile_info): Rename from
5002         coff_symfile_info.  Add initializers.
5003         (xcoff_objfile_data_key): Move lower.  Change type.
5004         (XCOFF_DATA): Rewrite.
5005         (xcoff_free_info): Remove.
5006         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5007         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5008         (xcoff_initial_scan): Update.
5009
5010 2019-05-08  Tom Tromey  <tom@tromey.com>
5011
5012         * solib-svr4.c (struct svr4_info): Add initializers and
5013         destructor.
5014         <probes_table>: Now an htab_up.
5015         (solib_svr4_pspace_data): Change type.
5016         (free_probes_table): Simplify.
5017         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5018         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5019         (probes_table_remove_objfile_probes, register_solib_event_probe)
5020         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5021         (_initialize_svr4_solib): Update.
5022
5023 2019-05-08  Tom Tromey  <tom@tromey.com>
5024
5025         * remote.c (remote_pspace_data): Change type.
5026         (remote_pspace_data_cleanup): Remove.
5027         (get_remote_exec_file, set_pspace_remote_exec_file)
5028         (_initialize_remote): Update.
5029
5030 2019-05-08  Tom Tromey  <tom@tromey.com>
5031
5032         * breakpoint.c (breakpoint_objfile_key): Change type.
5033         (get_breakpoint_objfile_data): Update.
5034         (free_breakpoint_objfile_data): Remove.
5035         (_initialize_breakpoint): Update.
5036
5037 2019-05-08  Tom Tromey  <tom@tromey.com>
5038
5039         * linux-tdep.c (struct linux_info): Add initializers.
5040         (linux_inferior_data): Move.  Change type.
5041         (invalidate_linux_cache_inf): Update.
5042         (linux_inferior_data_cleanup): Remove.
5043         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5044
5045 2019-05-08  Tom Tromey  <tom@tromey.com>
5046
5047         * auxv.c (auxv_inferior_data): Move.  Change type.
5048         (auxv_inferior_data_cleanup): Remove.
5049         (invalidate_auxv_cache_inf): Rewrite.
5050         (get_auxv_inferior_data, _initialize_auxv): Update.
5051
5052 2019-05-08  Tom Tromey  <tom@tromey.com>
5053
5054         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5055         (symfile_debug_objfile_data_key): Change type.
5056         (symfile_debug_installed, debug_qf_has_symbols)
5057         (debug_qf_find_last_source_symtab)
5058         (debug_qf_forget_cached_source_info)
5059         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5060         (debug_qf_print_stats, debug_qf_dump)
5061         (debug_qf_expand_symtabs_for_function)
5062         (debug_qf_expand_all_symtabs)
5063         (debug_qf_expand_symtabs_with_fullname)
5064         (debug_qf_map_matching_symbols)
5065         (debug_qf_expand_symtabs_matching)
5066         (debug_qf_find_pc_sect_compunit_symtab)
5067         (debug_qf_map_symbol_filenames)
5068         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5069         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5070         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5071         (debug_sym_read_linetable, debug_sym_relocate): Update.
5072         (symfile_debug_free_objfile): Remove.
5073         (install_symfile_debug_logging, _initialize_symfile_debug):
5074         Update.
5075
5076 2019-05-08  Tom Tromey  <tom@tromey.com>
5077
5078         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5079         allocate_on_obstack.
5080         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5081         (get_dwarf2_per_objfile): Update.
5082         (set_dwarf2_per_objfile): Remove.
5083         (dwarf2_has_info, dwarf2_get_section_info): Update.
5084         (dwarf2_free_objfile): Remove.
5085         (_initialize_dwarf2_read): Update.
5086
5087 2019-05-08  Tom Tromey  <tom@tromey.com>
5088
5089         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5090         initializers.
5091         <unsupported_script_warning_printed,
5092         script_not_found_warning_printed>: Now bool.
5093         (auto_load_pspace_data): Change type.
5094         (~auto_load_pspace_info): Rename from
5095         auto_load_pspace_data_cleanup.
5096         (get_auto_load_pspace_data, init_loaded_scripts_info)
5097         (clear_section_scripts, maybe_print_unsupported_script_warning)
5098         (maybe_print_script_not_found_warning, _initialize_auto_load):
5099         Update.
5100
5101 2019-05-08  Tom Tromey  <tom@tromey.com>
5102
5103         * objfiles.c (objfile_pspace_info): Add destructor and
5104         initializers.
5105         (objfiles_pspace_data): Change type.
5106         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5107         (get_objfile_pspace_data): Update.
5108         (objfiles_bfd_data): Change type.
5109         (get_objfile_bfd_data): Update.
5110         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5111
5112 2019-05-08  Tom Tromey  <tom@tromey.com>
5113
5114         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5115         Change type.
5116         (get_catch_syscall_inferior_data): Update.
5117         (catch_syscall_inferior_data_cleanup): Remove.
5118         (_initialize_break_catch_syscall): Update.
5119
5120 2019-05-08  Tom Tromey  <tom@tromey.com>
5121
5122         * inflow.c (struct terminal_info): Add destructor and
5123         initializers.
5124         (inflow_inferior_data): Change type.
5125         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5126         (get_inflow_inferior_data, inflow_inferior_exit)
5127         (swap_terminal_info, _initialize_inflow): Update.
5128
5129 2019-05-08  Tom Tromey  <tom@tromey.com>
5130
5131         * target-dcache.c (target_dcache_cleanup): Remove.
5132         (target_dcache_aspace_key): Change type.
5133         (target_dcache_init_p, target_dcache_invalidate)
5134         (target_dcache_get, target_dcache_get_or_init)
5135         (_initialize_target_dcache): Update.
5136         * dcache.h (struct dcache_deleter): New.
5137
5138 2019-05-08  Tom Tromey  <tom@tromey.com>
5139
5140         * symtab.c (struct symbol_cache): Add destructor and
5141         initializers.
5142         (symbol_cache_key): Move.  Change type.
5143         (make_symbol_cache, free_symbol_cache): Remove.
5144         (get_symbol_cache): Update.
5145         (symbol_cache_cleanup): Remove.
5146         (ALL_PSPACES, symbol_cache_flush)
5147         (maintenance_print_symbol_cache)
5148         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5149         Update.
5150
5151 2019-05-08  Tom Tromey  <tom@tromey.com>
5152
5153         * symtab.c (struct main_info): Add destructor and initializers.
5154         (main_progspace_key): Move.  Change type.
5155         (get_main_info): Update.
5156         (main_info_cleanup): Remove.
5157         (_initialize_symtab): Update.
5158
5159 2019-05-08  Tom Tromey  <tom@tromey.com>
5160
5161         * registry.h (DECLARE_REGISTRY): Define the _key class.
5162
5163 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5164
5165         * NEWS: Merge two 'New commands' sections.
5166
5167 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5168
5169         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5170         parameter and use Ada language definition instead.
5171         (ada_val_print_ptr): Remove unused language parameter.
5172         (ada_val_print_num): Remove language parameter and use Ada language
5173         definition instead.
5174         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5175         parameter.
5176         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5177         parameter and use Ada language definition instead.
5178         (ada_val_print_1): Update all ada_val_print_xxx calls.
5179         Remove language parameter.
5180         (ada_val_print): Update ada_val_print_1 call.
5181
5182 2019-05-08  Tom Tromey  <tromey@adacore.com>
5183
5184         * remote.c (remote_hw_watchpoint_limit)
5185         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5186         Now static.
5187
5188 2019-05-08  Tom Tromey  <tromey@adacore.com>
5189
5190         * maint.c (_initialize_maint_cmds): Move initialization code to
5191         remote.c.
5192         (watchdog, show_watchdog): Move to remote.c.
5193         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5194         "watchdog" static.
5195         (_initialize_remote): Move initialization code from maint.c.
5196         * defs.h (watchdog): Don't declare.
5197
5198 2019-05-08  Tom Tromey  <tromey@adacore.com>
5199
5200         * tui/tui-interp.c: Include main.h.
5201         * interps.c: Include main.h.
5202         * main.h (interpreter_p): Declare.
5203         * defs.h (interpreter_p): Don't declare.
5204
5205 2019-05-08  Tom Tromey  <tromey@adacore.com>
5206
5207         * dwarf2loc.c: Include dwarf2read.h.
5208         * defs.h (read_unsigned_leb128): Don't declare.
5209         * dwarf2read.h (read_unsigned_leb128): Declare.
5210
5211 2019-05-08  Tom Tromey  <tromey@adacore.com>
5212
5213         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5214         method.
5215
5216 2019-05-08  Tom Tromey  <tromey@adacore.com>
5217
5218         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5219         when no wrap column is set.
5220
5221 2019-05-08  Tom Tromey  <tromey@adacore.com>
5222
5223         * c-lang.c (c_get_string): Handle non-C-style arrays.
5224
5225 2019-05-08  Tom Tromey  <tromey@adacore.com>
5226
5227         * typeprint.c (print_offset_data::update): Print the bit offset,
5228         not the number of bits remaining.
5229
5230 2019-05-08  Tom Tromey  <tromey@adacore.com>
5231
5232         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5233         padding at end of comment.
5234
5235 2019-05-08  Tom Tromey  <tromey@adacore.com>
5236
5237         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5238         Compare main types.
5239
5240 2019-05-06  Tom Tromey  <tom@tromey.com>
5241
5242         * common/scoped_mmap.c: Include common-defs.h.
5243         * common/scoped_mmap.h: Don't include config.h.
5244
5245 2019-05-04  Tom Tromey  <tom@tromey.com>
5246
5247         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5248         (struct aarch64_call_info): Add initializers.
5249         <si>: Now a std::vector.
5250         (pass_on_stack, aarch64_push_dummy_call): Update.
5251
5252 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5253             Tom Tromey  <tom@tromey.com>
5254
5255         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5256         (ppc_threads): Now a std::vector.  Now static.
5257         (hwdebug_find_thread_points_by_tid)
5258         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5259         Update.
5260
5261 2019-05-04  Tom Tromey  <tom@tromey.com>
5262
5263         * arc-tdep.c (arc_tdesc_init): Return bool.
5264
5265 2019-05-04  Tom Tromey  <tom@tromey.com>
5266
5267         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5268         Use gdb_assert_not_reached.
5269
5270 2019-05-04  Tom Tromey  <tom@tromey.com>
5271
5272         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5273         "false".
5274
5275 2019-05-04  Tom Tromey  <tom@tromey.com>
5276
5277         * arc-tdep.c (arc_tdesc_init): Use bool.
5278
5279 2019-05-04  Tom Tromey  <tom@tromey.com>
5280
5281         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5282
5283 2019-05-04  Tom Tromey  <tom@tromey.com>
5284
5285         * cli/cli-cmds.c (valid_command_p): Return bool.
5286
5287 2019-05-04  Tom Tromey  <tom@tromey.com>
5288
5289         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5290         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5291
5292 2019-05-04  Raul Tambre  <raul@tambre.ee>
5293
5294         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5295         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5296         operator for comparison.
5297
5298 2019-05-04  Tom Tromey  <tom@tromey.com>
5299
5300         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5301         (lookup_partial_symbol, print_partial_symbols)
5302         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5303         (psymbol_compare): Update.
5304         (add_psymbol_to_bcache): Clear the entire psymbol.
5305         (maintenance_check_psymtabs): Update.
5306         * psympriv.h (struct partial_symbol): Don't derive from
5307         general_symbol_info.
5308         <obj_section, unrelocated_address, address,
5309         set_unrelocated_address>: Update.
5310         <ginfo>: New member.
5311         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5312         (debug_names::write_psymbols): Update.
5313
5314 2019-05-04  Tom de Vries  <tdevries@suse.de>
5315
5316         * contrib/cc-with-tweaks.sh: Support -n arg.
5317
5318 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5319
5320         * corelow.c (core_target::detach): Ensure frame cache and
5321         register caches are cleared.
5322         inferior.c (exit_inferior_1): Likewise.
5323
5324 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5325             Tom Tromey  <tom@tromey.com>
5326
5327         * dictionary.c (collate_pending_symbols_by_language): Remove
5328         "struct" from foreach.
5329         * symtab.c (lookup_global_symbol_from_objfile)
5330         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5331         foreach.
5332         * ser-tcp.c (net_open): Remove "struct" from foreach.
5333         * objfiles.c (objfile_relocate, objfile_rebase)
5334         (objfile_has_symbols): Remove "struct" from foreach.
5335         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5336         from foreach.
5337         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5338         foreach.
5339         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5340         "struct" from foreach.
5341         * ada-lang.c (create_excep_cond_exprs)
5342         (ada_exception_catchpoint_cond_string): Remove "struct" from
5343         foreach.
5344
5345 2019-05-03  Tom Tromey  <tromey@adacore.com>
5346
5347         * ada-exp.y (convert_char_literal): Check suffix of each
5348         enumerator.
5349
5350 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5351
5352         PR ada/21406:
5353         * ada-exp.y (yywrap): Don't define.
5354         * ada-lex.l (%option): Add noyywrap
5355         (yywrap): Remove.
5356
5357 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5358
5359         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5360         _WIN32_WINNT to the XP level, unless already defined to a higher
5361         level.
5362
5363         * unittests/parse-connection-spec-selftests.c:
5364         * ser-tcp.c:
5365         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5366         override.
5367
5368         * symfile.c (find_separate_debug_file): Remove colon from the
5369         drive spec of DOS/Windows file names of the target, so that the
5370         file name produced from DEBUGDIR and the target's directory will
5371         be valid on DOS/Windows systems.
5372
5373 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5374
5375         * rust-lang.c (val_print_struct): Handle printing structures
5376         containing strings.
5377
5378 2019-05-02  Tom Tromey  <tromey@adacore.com>
5379
5380         * valarith.c (_initialize_valarith): Remove.
5381
5382 2019-05-01  Tom Tromey  <tromey@adacore.com>
5383
5384         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5385         bitfields.
5386
5387 2019-05-01  Tom Tromey  <tromey@adacore.com>
5388
5389         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5390         for big-endian copies.
5391
5392 2019-04-30  Ali Tamur  <tamur@google.com>
5393         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5394         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5395         (read_3_bytes): New function.
5396
5397 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5398
5399         * windows-nat.c (main_thread_id): Delete.
5400         (handle_output_debug_string): Replace main_thread_id by
5401         current_event.dwThreadId.
5402         (fake_create_process): Likewise.
5403         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5404         Do not set main_thread_id.
5405         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5406         current_event.dwThreadId.
5407         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5408
5409 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5410
5411         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5412         Use current_event.dwThreadId instead of main_thread_id.
5413
5414 2019-04-30  Tom Tromey  <tromey@adacore.com>
5415
5416         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5417         (create_excep_cond_exprs): Iterate over program spaces.
5418         (ada_exception_catchpoint_cond_string): Examine all minimal
5419         symbols for exception types.
5420
5421 2019-04-30  Tom Tromey  <tromey@adacore.com>
5422
5423         PR c++/24470:
5424         * dwarf2read.c (process_structure_scope): Handle case where type
5425         has template parameters but no symbol was created.
5426
5427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5428             Chris January  <chris.january@arm.com>
5429
5430         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5431         qualifier.
5432         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5433
5434 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5435
5436         * f-typeprint.c (f_print_type): Update rules for printing
5437         whitespace.
5438         (f_type_print_varspec_suffix): Likewise.
5439
5440 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5441             Chris January  <chris.january@arm.com>
5442
5443         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5444         function arguments.
5445
5446 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5447
5448         * f-lang.c (build_fortran_types): Change name of void type to
5449         lower case.
5450         * f-typeprint.c (f_type_print_base): Print the name of the void
5451         type, rather than a fixed string.
5452         * f-valprint.c (f_decorations): Use lower case void string.
5453
5454 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5455             Chris January  <chris.january@arm.com>
5456
5457         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5458         types for Fortran.
5459
5460 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5461             Chris January  <chris.january@arm.com>
5462             David Lecomber  <david.lecomber@arm.com>
5463
5464         * f-exp.y (BINOP_INTRINSIC): New token.
5465         (exp): New parser rule handling BINOP_INTRINSIC.
5466         (f77_keywords): Add new builtin procedures.
5467         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5468         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5469         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5470         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5471         (print_unop_subexp_f): New function.
5472         (print_binop_subexp_f): New function.
5473         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5474         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5475         (dump_subexp_body_f): Likewise.
5476         (operator_check_f): Likewise.
5477         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5478         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5479
5480 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5481
5482         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5483         UNOP_KIND.
5484         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5485         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5486         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5487         (operator_length_f): New fuction.
5488         (print_subexp_f): New function.
5489         (op_name_f): New function.
5490         (dump_subexp_body_f): New function.
5491         (operator_check_f): New function.
5492         (exp_descriptor_f): Replace standard expression handling functions
5493         with new functions.
5494         * gdb/fortran-operator.def: New file.
5495         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5496         * gdb/std-operator.def: Remove UNOP_KIND.
5497
5498 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5499
5500         * std-operator.def: Remove unbalanced, stray double quote
5501         character.
5502
5503 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5504             Chris January  <chris.january@arm.com>
5505             Daniel Everett  <daniel.everett@arm.com>
5506             Nick Forrington  <nick.forrington@arm.com>
5507             Richard Bunt  <richard.bunt@arm.com>
5508
5509         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5510         of depth when printing anonymous structs or unions.
5511         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5512         Don't print either the top-level value, or the children if the
5513         max-depth is exceeded.
5514         (ppscm_print_children): When printing the key of a map, allow one
5515         extra level of depth.
5516         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5517         print either the top-level value, or the children if the max-depth
5518         is exceeded.
5519         (print_children): When printing the key of a map, allow one extra
5520         level of depth.
5521         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5522         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5523         (user_print_options): Initialise max_depth field.
5524         (val_print_scalar_or_string_type_p): New function.
5525         (val_print): Check to see if the max depth has been reached.
5526         (val_print_check_max_depth): Define new function.
5527         (show_print_max_depth): New function.
5528         (_initialize_valprint): Add 'print max-depth' option.
5529         * valprint.h (struct value_print_options) <max_depth>: New field.
5530         (val_print_check_max_depth): Declare new function.
5531         * NEWS: Document new feature.
5532
5533 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5534
5535         * ada-lang.c (ada_language_defn): Initialise new field.
5536         * c-lang.c (c_is_string_type_p): New function.
5537         (c_language_defn): Initialise new field.
5538         (cplus_language_defn): Initialise new field.
5539         (asm_language_defn): Initialise new field.
5540         (minimal_language_defn): Initialise new field.
5541         * c-lang.h (c_is_string_type_p): Declare new function.
5542         * d-lang.c (d_language_defn): Initialise new field.
5543         * f-lang.c (f_is_string_type_p): New function.
5544         (f_language_defn): Initialise new field.
5545         * go-lang.c (go_is_string_type_p): New function.
5546         (go_language_defn): Initialise new field.
5547         * language.c (default_is_string_type_p): New function.
5548         (unknown_language_defn): Initialise new field.
5549         (auto_language_defn): Initialise new field.
5550         * language.h (struct language_defn) <la_is_string_type_p>: New
5551         member variable.
5552         (default_is_string_type_p): Declare new function.
5553         * m2-lang.c (m2_language_defn): Initialise new field.
5554         * objc-lang.c (objc_language_defn): Initialise new field.
5555         * opencl-lang.c (opencl_language_defn): Initialise new field.
5556         * p-lang.c (pascal_is_string_type_p): New function.
5557         (pascal_language_defn): Initialise new field.
5558         * rust-lang.c (rust_is_string_type_p): New function.
5559         (rust_language_defn): Initialise new field.
5560
5561 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5562
5563         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5564         New field.
5565         * ada-lang.c (ada_language_defn): Initialise new field.
5566         * c-lang.c (c_language_defn): Likewise.
5567         (cplus_language_defn): Likewise.
5568         (asm_language_defn): Likewise.
5569         (minimal_language_defn): Likewise.
5570         * d-lang.c (d_language_defn): Likewise.
5571         * f-lang.c (f_language_defn): Likewise.
5572         * go-lang.c (go_language_defn): Likewise.
5573         * language.c (unknown_language_defn): Likewise.
5574         (auto_language_defn): Likewise.
5575         * m2-lang.c (m2_language_defn): Likewise.
5576         * objc-lang.c (objc_language_defn): Likewise.
5577         * opencl-lang.c (opencl_language_defn): Likewise.
5578         * p-lang.c (pascal_language_defn): Likewise.
5579         * rust-lang.c (rust_language_defn): Likewise.
5580
5581 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * ada-lang.c (ada_is_character_type): Change return type to bool.
5584         (ada_is_string_type): Likewise.
5585         * ada-lang.h (ada_is_character_type): Update declaration
5586         (ada_is_string_type): Likewise.
5587
5588 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5589
5590         Support style in 'frame|thread apply'
5591
5592         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5593         * record.c (record_start, record_stop): Update callers of
5594         execute_command_to_string with false.
5595         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5596         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5597         methods.
5598         (class string_file): New constructor with term_out parameter.
5599         Override methods term_out and can_emit_style_escape.  New member
5600         term_out.
5601         (class stdio_file): Override can_emit_style_escape.
5602         (class tee_file): Override term_out and can_emit_style_escape.
5603         * utils.h (can_emit_style_escape): Remove.
5604         * utils.c (can_emit_style_escape): Likewise.
5605         Update all callers of can_emit_style_escape (SOMESTREAM) to
5606         SOMESTREAM->can_emit_style_escape.
5607         * source-cache.c (source_cache::get_source_lines): Likewise.
5608         * stack.c (frame_apply_command_count): Call execute_command_to_string
5609         passing the term_out characteristic of the current gdb_stdout.
5610         * thread.c (thr_try_catch_cmd): Likewise.
5611         * top.c (execute_command_to_string): pass term_out parameter
5612         to construct the string_file for the command output.
5613         * ui-file.c (term_cli_styling): New function (most code moved
5614         from utils.c can_emit_style_escape).
5615         (string_file::string_file, string_file::can_emit_style_escape,
5616         stdio_file::can_emit_style_escape, tee_file::term_out,
5617         tee_file::can_emit_style_escape): New functions.
5618
5619 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5620
5621         * NEWS: Mention the new set|show may-call-functions.
5622         * infcall.c (may_call_functions_p): New variable.
5623         (show_may_call_functions_p): New function.
5624         (call_function_by_hand_dummy): Throws an error if not
5625         may-call-functions.
5626         (_initialize_infcall): Call add_setshow_boolean_cmd for
5627         may-call-functions.
5628
5629 2019-04-25  Keith Seitz  <keiths@redhat.com>
5630
5631         PR c++/24367
5632         * cp-support.c (inspect_type): Don't attempt substitutions
5633         of symbol with the same name.
5634
5635 2019-04-25  Tom Tromey  <tromey@adacore.com>
5636
5637         PR gdb/24475:
5638         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5639         static.
5640
5641 2019-04-25  Tom Tromey  <tromey@adacore.com>
5642
5643         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5644         rvalue reference.
5645         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5646         (gdb_xml_parser::parse): Use std::move.
5647         * python/python-internal.h (gdbpy_convert_exception): Take a const
5648         reference.
5649         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5650         std::move.
5651         * python/py-utils.c (gdbpy_convert_exception): Take a const
5652         reference.
5653         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5654         Use std::move.
5655         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5656         Use std::move.
5657         * mi/mi-main.c (mi_print_exception): Take a const reference.
5658         * main.c (handle_command_errors): Take a const reference.
5659         * linespec.c (parse_linespec): Use std::move.
5660         * infcall.c (run_inferior_call): Use std::move.
5661         (call_function_by_hand_dummy): Use std::move.
5662         * exec.c (try_open_exec_file): Use std::move.
5663         * exceptions.h (exception_print, exception_fprintf)
5664         (exception_print_same): Update.
5665         * exceptions.c (print_exception, exception_print)
5666         (exception_fprintf, exception_print_same): Change parameters to
5667         const reference.
5668         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5669         * common/new-op.c: Use std::move.
5670         * common/common-exceptions.h (struct gdb_exception): Add move
5671         constructor.
5672         (struct gdb_exception_error, struct gdb_exception_quit, struct
5673         gdb_quit_bad_alloc): Change constructor to move constructor.
5674         (throw_exception): Change parameter to rvalue reference.
5675         * common/common-exceptions.c (throw_exception): Take rvalue
5676         reference.
5677         * cli/cli-interp.c (safe_execute_command): Use std::move.
5678         * breakpoint.c (insert_bp_location, location_to_sals): Use
5679         std::move.
5680
5681 2019-04-25  Tom Tromey  <tromey@adacore.com>
5682
5683         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5684         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5685         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5686         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5687         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5688         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5689         guile/scm-value.c: Use unpack.
5690         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5691         gdbscm_gdb_exception.
5692         (gdbscm_throw_gdb_exception): Likewise.
5693         (struct gdbscm_gdb_exception): New.
5694         (unpack): New function.
5695         (gdbscm_wrap): Use unpack.
5696
5697 2019-04-25  Tom Tromey  <tromey@adacore.com>
5698
5699         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5700         (gdb_rl_callback_handler): Use std::move.
5701         * common/common-exceptions.h (struct gdb_exception): Add move
5702         assignment operator.
5703         (throw_exception_sjlj): Change "exception" to const reference.
5704         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5705         (throw_exception_sjlj): Change "exception" to const reference.
5706
5707 2019-04-25  Tom Tromey  <tromey@adacore.com>
5708
5709         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5710         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5711         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5712         Update.
5713         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5714         Update.
5715         * mi/mi-interp.c (mi_interp::exec): Update.
5716         * linespec.c (parse_linespec): Update.
5717         * infcall.c (run_inferior_call): Update.
5718         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5719         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5720         (gdbscm_lookup_global_symbol): Update.
5721         * guile/scm-param.c (gdbscm_parameter_value): Update.
5722         * guile/scm-frame.c (gdbscm_frame_read_register)
5723         (gdbscm_frame_read_var): Update.
5724         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5725         * exec.c (try_open_exec_file): Update.
5726         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5727         (gdb_rl_callback_handler): Update.
5728         * common/common-exceptions.h (exception_none): Don't declare.
5729         * common/common-exceptions.c (exception_none): Don't define.
5730         (struct catcher) <exception>: Update.
5731         * cli/cli-interp.c (safe_execute_command): Update.
5732         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5733
5734 2019-04-25  Ali Tamur  <tamur@google.com>
5735
5736         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5737         (read_attribute_value): Likewise.
5738         (dwarf2_read_addr_index): Update comment.
5739         (read_str_index): Add DW_FORM_strx.
5740         (dwarf2_string_attr): Likewise.
5741         (dwarf2_const_value_attr): Likewise.
5742         (dump_die_shallow): Likewise.
5743         (dwarf2_fetch_constant_bytes): Likewise.
5744         (skip_form_bytes): Likewise.
5745         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5746
5747 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5748
5749         PR corefiles/11608
5750         PR corefiles/18187
5751         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5752         OFFSET.  Verify if current mapping contains an ELF header.
5753         (linux_find_memory_regions_full): Adjust call to
5754         dump_mapping_p.
5755
5756 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5757             Kang Li <kanglictf@gmail.com>
5758
5759         PR gdb/21600
5760
5761         * dwarf2-frame.c (read_initial_length): Be consistent about using
5762         unsigned representation of length.
5763         (decode_frame_entry_1): Likewise.  Check for wraparound of
5764         end pointer as well as buffer overflow.
5765
5766 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5767
5768         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5769         "vq".
5770
5771 2019-04-24  Tom Tromey  <tromey@adacore.com>
5772
5773         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5774
5775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5776
5777         * s12z-tdep.c (s12z_unwind_pc): Delete.
5778         (s12z_unwind_sp): Delete.
5779         (s12z_gdbarch_init): Don't register deleted functions with
5780         gdbarch.
5781
5782 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5783
5784         * rl78-tdep.c (rl78_unwind_sp): Delete.
5785         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5786
5787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5788
5789         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5790         (xstormy16_unwind_pc): Delete.
5791         (xstormy16_dummy_id): Delete.
5792         (xstormy16_gdbarch_init): Don't register deleted functions with
5793         gdbarch.
5794
5795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5796
5797         * vax-tdep.c (vax_unwind_pc): Delete.
5798         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5799
5800 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5801
5802         * v850-tdep.c (v850_unwind_sp): Delete.
5803         (v850_unwind_pc): Delete.
5804         (v850_dummy_id): Delete.
5805         (v850_gdbarch_init): Don't register deleted functions with
5806         gdbarch.
5807
5808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5809
5810         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5811         (tilegx_unwind_pc): Delete.
5812         (tilegx_unwind_dummy_id): Delete.
5813         (tilegx_gdbarch_init): Don't register deleted functions with
5814         gdbarch.
5815
5816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5817
5818         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5819         (tic6x_dummy_id): Delete.
5820         (tic6x_gdbarch_init): Don't register deleted functions with
5821         gdbarch.
5822
5823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5824
5825         * sparc-tdep.c (sparc_unwind_pc): Delete.
5826         (sparc32_gdbarch_init): Don't register deleted function with
5827         gdbarch.
5828
5829 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5830
5831         * sh-tdep.c (sh_unwind_sp): Delete.
5832         (sh_unwind_pc): Delete.
5833         (sh_dummy_id): Delete.
5834         (sh_gdbarch_init): Don't register deleted functions with
5835         gdbarch.
5836
5837 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5838
5839         * score-tdep.c (score_unwind_sp): Delete.
5840         (score_unwind_pc): Delete.
5841         (score_dummy_id): Delete.
5842         (score_gdbarch_init): Don't register deleted functions with
5843         gdbarch.
5844
5845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5846
5847         * rx-tdep.c (rx_unwind_pc): Delete.
5848         (rx_unwind_sp): Delete.
5849         (rx_dummy_id): Delete.
5850         (rx_gdbarch_init): Don't register deleted functions with
5851         gdbarch.  Update comment.
5852
5853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5854
5855         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
5856         (rs6000_dummy_id): Delete.
5857         (rs6000_gdbarch_init): Don't register deleted functions with
5858         gdbarch.
5859
5860 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5861
5862         * or1k-tdep.c (or1k_dummy_id): Delete.
5863         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
5864
5865 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5866
5867         * nios2-tdep.c (nios2_dummy_id): Delete.
5868         (nios2_unwind_sp): Delete.
5869         (nios2_gdbarch_init): Don't register deleted functions with
5870         gdbarch.
5871
5872 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5873
5874         * nds32-tdep.c (nds32_dummy_id): Delete.
5875         (nds32_unwind_pc): Delete.
5876         (nds32_unwind_sp): Delete.
5877         (nds32_gdbarch_init): Don't register deleted functions with
5878         gdbarch.
5879
5880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5881
5882         * msp430-tdep.c (msp430_unwind_pc): Delete.
5883         (msp430_unwind_sp): Delete.
5884         (msp430_dummy_id): Delete.
5885         (msp430_gdbarch_init): Don't register deleted functions with
5886         gdbarch.
5887
5888 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5889
5890         * moxie-tdep.c (moxie_unwind_sp): Delete.
5891         (moxie_unwind_pc): Delete.
5892         (moxie_dummy_id): Delete.
5893         (moxie_gdbarch_init): Don't register deleted functions with
5894         gdbarch.
5895
5896 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5897
5898         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5899         (mn10300_unwind_pc): Delete.
5900         (mn10300_unwind_sp): Delete.
5901         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5902         mn10300_unwind_sp.
5903         (mn10300_frame_unwind_init): Don't register deleted functions with
5904         gdbarch.
5905
5906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5907
5908         * mep-tdep.c (mep_unwind_pc): Delete.
5909         (mep_unwind_sp): Delete.
5910         (mep_dummy_id): Delete.
5911         (mep_gdbarch_init): Don't register deleted functions with
5912         gdbarch.
5913
5914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5915
5916         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5917         (m68hc11_unwind_sp): Delete.
5918         (m68hc11_gdbarch_init): Don't register deleted functions with
5919         gdbarch.
5920
5921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5922
5923         * m32r-tdep.c (m32r_unwind_sp): Delete.
5924         (m32r_unwind_pc): Delete.
5925         (m32r_dummy_id): Delete.
5926         (m32r_gdbarch_init): Don't register deleted functions with
5927         gdbarch.
5928
5929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5930
5931         * m32c-tdep.c (m32c_unwind_pc): Delete.
5932         (m32c_unwind_sp): Delete.
5933         (m32c_dummy_id): Delete.
5934         (m32c_gdbarch_init): Don't register deleted functions with
5935         gdbarch.
5936
5937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5938
5939         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5940         (lm32_unwind_pc): Delete.
5941         (lm32_dummy_id): Delete.
5942         (lm32_gdbarch_init): Don't register deleted functions with
5943         gdbarch.
5944
5945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5946
5947         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5948         (iq2000_unwind_pc): Delete.
5949         (iq2000_dummy_id): Delete.
5950         (iq2000_gdbarch_init): Don't register deleted functions with
5951         gdbarch.
5952
5953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * nds32-tdep.c (nds32_type_align): Delete.
5956         (nds32_push_dummy_call): Use type_align instead.
5957
5958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5959
5960         * arm-tdep.c (arm_type_align): Only handle vector override case.
5961         (arm_push_dummy_call): Use type_align.
5962         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5963
5964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5965
5966         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5967         case.
5968         (pass_on_stack): Use type_align.
5969         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5970         function.
5971
5972 2019-04-23  Tom Tromey  <tromey@adacore.com>
5973
5974         * dwarf2read.c (line_header::file_name_at): Remove unused
5975         overload.
5976
5977 2019-04-23  Tom de Vries  <tdevries@suse.de>
5978
5979         PR gdb/24438
5980         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5981         invocation.
5982
5983
5984 2019-03-27  Ali Tamur  <tamur@google.com>
5985
5986         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5987         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5988         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5989         (dwarf_expr_context::get_addr_index): Likewise
5990         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5991         (symbol_needs_eval_context::get_addr_index): Likewise
5992         (disassemble_dwarf_expression): Add DW_OP_addrx
5993         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5994         (read_cutu_die_from_dwo): Update comment
5995         (skip_one_die): Add DW_FORM_addrx
5996         (read_attribute_value): Likewise
5997         (var_decode_location): Add DW_OP_addrx
5998         (dwarf2_const_value_attr): Add DW_FORM_addrx
5999         (dump_die_shallow): Likewise
6000         (dwarf2_fetch_constant_bytes): Likewise
6001         (decode_locdesc): Add DW_OP_addrx
6002         (skip_form_bytes): Add DW_FORM_addrx
6003
6004 2019-04-22  Ali Tamur  <tamur@google.com>
6005
6006         * MAINTAINERS (Write After Approval): Add self.
6007
6008 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6009
6010         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6011         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6012         (open_symbol_file_object): Likewise.
6013         (svr4_default_sos): Add info parameter.
6014         (svr4_read_so_list): Likewise.
6015         (svr4_current_sos_direct): Adjust functions calls to pass down
6016         info.
6017         (svr4_current_sos_1): Add info parameter.
6018         (svr4_current_sos): Call get_svr4_info, pass info down to
6019         svr4_current_sos_1.
6020         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6021         get_svr4_info.
6022         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6023         get_svr4_info.
6024         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6025         to get_svr4_info.
6026         (probes_table_remove_objfile_probes): Likewise.
6027         (register_solib_event_probe): Add info parameter.
6028         (solist_update_incremental): Pass info parameter down to
6029         svr4_read_so_list.
6030         (disable_probes_interface): Add info parameter.
6031         (svr4_handle_solib_event): Pass current_program_space to
6032         get_svr4_info.  Adjust disable_probes_interface cleanup.
6033         (svr4_create_probe_breakpoints): Add info parameter, pass it
6034         down to register_solib_event_probe.
6035         (svr4_create_solib_event_breakpoints): Add info parameter,
6036         pass it down to svr4_create_probe_breakpoints.
6037         (enable_break): Pass info down to
6038         svr4_create_solib_event_breakpoints.
6039         (svr4_solib_create_inferior_hook): Pass current_program_space to
6040         get_svr4_info.
6041         (svr4_clear_solib): Likewise.
6042
6043 2019-04-22  Pedro Alves  <palves@redhat.com>
6044
6045         * solib-svr4.c (svr4_free_objfile_observer): New.
6046         (probe_and_action::objfile): New field.
6047         (probes_table_htab_remove_objfile_probes)
6048         (probes_table_remove_objfile_probes): New functions.
6049         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6050         in the new probe_and_action.  Don't store the probe in 'lookup'.
6051         (svr4_create_probe_breakpoints): Pass objfile to
6052         register_solib_event_probe.
6053         (_initialize_svr4_solib): Register a free_objfile observer.
6054
6055 2019-04-19  Tom Tromey  <tom@tromey.com>
6056
6057         * common/queue.h: Remove.
6058
6059 2019-04-19  Tom Tromey  <tom@tromey.com>
6060
6061         * event-loop.c: Don't include "common/queue.h".
6062
6063 2019-04-19  Tom Tromey  <tom@tromey.com>
6064
6065         * remote.c (remote_target): Use delete.
6066         * remote-notif.h: Include <list>, not "common/queue.h".
6067         (notif_client_p): Remove typedef.
6068         (remote_notif_state): Add constructor, destructor, initializer.
6069         <notif_queue>: Now a std::list.
6070         (remote_notif_state_xfree): Don't declare.
6071         * remote-notif.c (remote_notif_process, handle_notification)
6072         (remote_notif_state_allocate): Update.
6073         (~remote_notif_state): Rename from remote_notif_state_xfree.
6074
6075 2019-04-19  Tom Tromey  <tom@tromey.com>
6076
6077         * symfile.c (reread_symbols): Update.
6078         * objfiles.c (objfile_register_static_link)
6079         (objfile_lookup_static_link): Update
6080         (~objfile) Don't delete static_links.
6081         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6082
6083 2019-04-19  Tom Tromey  <tom@tromey.com>
6084
6085         * type-stack.h (struct type_stack) <insert>: Constify string.
6086         * type-stack.c (type_stack::insert): Constify string.
6087         * gdbtypes.h (lookup_template_type): Update.
6088         (address_space_name_to_int): Update.
6089         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6090         const.
6091         (lookup_template_type): Make name const.
6092         * c-exp.y: Update rules.
6093         (lex_one_token, classify_name, classify_inner_name)
6094         (c_print_token): Update.
6095         * p-exp.y: Update rules.
6096         (yylex): Update.
6097         * f-exp.y: Update rules.
6098         (yylex): Update.
6099         * d-exp.y: Update rules.
6100         (lex_one_token, classify_name, classify_inner_name): Update.
6101         * parse.c (write_dollar_variable, copy_name): Return std::string.
6102         * parser-defs.h (copy_name): Change return type.
6103         * m2-exp.y: Update rules.
6104         (yylex): Update.
6105         * go-exp.y (lex_one_token): Update.
6106         Update rules.
6107         (classify_unsafe_function, classify_packaged_name)
6108         (classify_name, yylex): Update.
6109
6110 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6111
6112         * configure.ac: add --enable-source-highlight switch.
6113         * configure: Regenerate.
6114         * top.c (print_gdb_version): plumb --enable-source-highlight
6115         status to "show configuration".
6116
6117 2019-04-19  Tom Tromey  <tromey@adacore.com>
6118
6119         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6120         Check ADA_TYPE_P.
6121         (empty_record, ada_template_to_fixed_record_type_1)
6122         (template_to_static_fixed_type)
6123         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6124         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6125         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6126         macros.
6127
6128 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6129
6130         PR symtab/24423:
6131         * source.c (print_source_lines_base): Advance "iter" when a
6132         control character is seen.
6133
6134 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6135
6136         * inferior.h (struct infcall_suspend_state_deleter):
6137         Catch exception in destructor to avoid crash.
6138
6139 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6140
6141         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6142         close to the add_com "shell".
6143
6144 2019-04-18  Tom Tromey  <tromey@adacore.com>
6145
6146         * process-stratum-target.h (class process_stratum_target)
6147         <stratum>: Add "final".
6148
6149 2019-04-17  Tom Tromey  <tromey@adacore.com>
6150
6151         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6152         against nullptr before use.
6153
6154 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6155
6156         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6157
6158 2019-04-17  Jim Wilson  <jimw@sifive.com>
6159             Andrew Burgess  <andrew.burgess@embecosm.com>
6160
6161         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6162         code read might fail, assume 4-byte breakpoint in that case.
6163
6164 2019-04-15  Leszek Swirski  <leszeks@google.com>
6165
6166         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6167         rather than a hand-rolled POD check when checking for forced MEMORY
6168         classification.
6169
6170 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6171
6172         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6173         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6174         function.
6175         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6176         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6177         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6178         declaration.
6179
6180 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6181
6182         * aarch64-linux-nat.c
6183         (aarch64_linux_nat_target::thread_architecture): Add override.
6184         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6185         each VQ.
6186
6187 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6188
6189         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6190
6191 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6192
6193         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6194         target types of size 96-bits, add some additional comments, and
6195         check that the builtin type we found was the correct size.
6196
6197 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6198
6199         * utils.c (prompt_for_continue): Don't restore the styling at the
6200         end, as applied_style has the wrong value.  This fixes styling in
6201         long lists of file names that are interrupted by the "Continue?"
6202         prompt.
6203
6204 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6205
6206         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6207         * c-lang.c (c_language_defn): Likewise.
6208         (cplus_language_defn): Likewise.
6209         (asm_language_defn): Likewise.
6210         (minimal_language_defn): Likewise.
6211         * d-lang.c (d_language_defn): Likewise.
6212         * f-lang.c (f_language_defn): Likewise.
6213         * go-lang.c (go_language_defn): Likewise.
6214         * language.c (unknown_language_defn): Likewise.
6215         (auto_language_defn): Likewise.
6216         * language.h (struct language_defn): Remove la_magic field.
6217         (LANG_MAGIC): Delete.
6218         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6219         * objc-lang.c (objc_language_defn): Likewise.
6220         * opencl-lang.c (opencl_language_defn): Likewise.
6221         * p-lang.c (pascal_language_defn): Likewise.
6222         * rust-lang.c (rust_language_defn): Likewise.
6223
6224 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * riscv-tdep.c (riscv_type_align): New function.
6227         (riscv_type_alignment): Delete.
6228         (riscv_arg_location): Use 'type_align'.
6229         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6230
6231 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6232
6233         * gdbtypes.c (type_align): A struct with no non-static fields also
6234         has alignment of 1.
6235
6236 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6237
6238         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6239         component to 0.
6240         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6241         member.
6242         (riscv_struct_info::analyse): New implementation using new
6243         analyse_inner member function.
6244         (riscv_struct_info::field_offset): New member function.
6245         (riscv_struct_info::m_offsets): New member variable.
6246         (riscv_struct_info::analyse_inner): New private member function,
6247         takes the old implementation of riscv_struct_info::analyse but
6248         extended to track field offsets.
6249         (riscv_call_arg_struct): Update the struct folding special cases
6250         to handle cases where empty C++ structs, which are non-zero
6251         length, are found.
6252         (riscv_arg_location): Initialise the length of each location, a
6253         non-zero length now indicates the location is in use.
6254         (riscv_push_dummy_call): Allow for the first location having a
6255         non-zero offset when setting up arguments.
6256         (riscv_return_value): Likewise, but for return values.
6257
6258 2019-04-11  Tom Tromey  <tromey@adacore.com>
6259
6260         * utils.c (internal_vproblem): Make "msg" const.
6261
6262 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6263
6264         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6265         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6266         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6267         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6268
6269 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6270
6271         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6272         function.
6273         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6274         of amd64_collect_native_gregset.
6275         (amd64_linux_nat_target::store_registers): Likewise.
6276
6277 2019-04-10  Tom Tromey  <tom@tromey.com>
6278
6279         * symtab.c (lookup_global_symbol_from_objfile)
6280         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6281         * objfiles.h (class separate_debug_iterator): New.
6282         (class separate_debug_range): New.
6283         (struct objfile) <separate_debug_objfiles>: New method.
6284         (objfile_separate_debug_iterate): Don't declare.
6285         * objfiles.c (separate_debug_iterator::operator++): Rename from
6286         objfile_separate_debug_iterate.
6287         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6288         iterator.
6289         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6290         iterator.
6291
6292 2019-04-10  Tom Tromey  <tom@tromey.com>
6293
6294         * symfile.c (reread_symbols): Remove old comment.
6295         * objfiles.c (free_all_objfiles): Fix a typo.
6296
6297 2019-04-10  Tom Tromey  <tom@tromey.com>
6298
6299         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6300         * minsyms.c (lookup_minimal_symbol): Use foreach.
6301         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6302         (lookup_minimal_symbol_solib_trampoline): Likewise.
6303         * symfile.c (reread_symbols): Use foreach.
6304
6305 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6306             Tom Tromey  <tromey@adacore.com>
6307
6308         PR rust/24414:
6309         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6310         (rust_lex_int_test): Change "value" to be LONGEST.
6311         (rust_lex_tests): Add test for long integer literal.
6312
6313 2019-04-09  Tom Tromey  <tromey@adacore.com>
6314
6315         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6316         to bool.
6317         (extended_remote_target::attach): Update.
6318         (remote_target::remote_notice_new_inferior): Update.
6319         (remote_target::add_current_inferior_and_thread): Update.
6320         * inferior.c (exit_inferior_1): Use "false".
6321         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6322
6323 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6324
6325         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6326         the "start" command.
6327
6328 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6329
6330         * python/py-inferior.c (infpy_thread_from_thread_handle):
6331         Adjust comments to reflect renaming of thread_from_thread_handle
6332         to thread_from_handle.  Adjust keywords.  Fix type error message.
6333         (inferior_object_methods): Add thread_from_handle.  Retain
6334         thread_from_thread_handle, but mark it as deprecated.
6335
6336 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6337
6338         * gdbthread.h (find_thread_by_handle): Revise declaration.
6339         * thread.c (find_thread_by_handle): Likewise.  Adjust
6340         implementation too.
6341         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6342         support for buffer objects as handles.
6343
6344 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6345
6346         * python/py-infthread.c (thpy_thread_handle): New function.
6347         (thread_object_methods): Register thpy_thread_handle.
6348
6349 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6350
6351         * gdbthread.h (thread_to_thread_handle): Declare.
6352         * thread.c (gdbtypes.h): Include.
6353         (thread_to_thread_handle): New function.
6354
6355         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6356         (target_thread_info_to_thread_handle): Declare.
6357         * target.c (target_thread_info_to_thread_handle): New function.
6358         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6359         * target-delegates.c: Regenerate.
6360
6361         * linux-thread-db.c (class thread_db_target): Add method
6362         thread_info_to_thread_handle.
6363         (thread_db_target::thread_info_to_thread_handle): Define.
6364         * remote.c (class remote_target): Add new method
6365         thread_info_to_thread_handle.
6366         (remote_target::thread_info_to_thread_handle): Define.
6367
6368 2019-04-08  Pedro Alves  <palves@redhat.com>
6369
6370         * common/common-exceptions.c (throw_exception): Don't create
6371         named object to throw; throw directly.
6372         (throw_it): Likewise.  Don't initialize gdb_exception::message
6373         here, with new; pass FMT and AP to the ctor instead.
6374         * common/common-exceptions.h: Include <string>.
6375         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6376         const char *, va_list)): New ctor.  Use std::make_shared.
6377         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6378         errors)): Delete.
6379         (gdb_exception_error::gdb_exception_error(enum errors, const char
6380         *, va_list)): New.
6381         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6382         Add assertion.
6383         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6384         errors)): Delete.
6385         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6386         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6387         Add assertion.
6388
6389 2019-04-08  Tom Tromey  <tom@tromey.com>
6390
6391         * valops.c (value_rtti_indirect_type): Replace throw_exception
6392         with throw.
6393         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6394         with throw.
6395         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6396         throw.
6397         * target.c (target_translate_tls_address): Replace throw_exception
6398         with throw.
6399         * stack.c (frame_apply_command_count): Replace throw_exception
6400         with throw.
6401         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6402         throw.
6403         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6404         with throw.
6405         * rs6000-tdep.c (rs6000_frame_cache)
6406         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6407         * remote.c: Replace throw_exception with throw.
6408         * record-full.c (record_full_message, record_full_wait_1)
6409         (record_full_restore): Replace throw_exception with throw.
6410         * record-btrace.c:
6411         (get_thread_current_frame_id, record_btrace_start_replaying)
6412         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6413         (cmd_record_btrace_start): Replace throw_exception with throw.
6414         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6415         throw.
6416         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6417         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6418         * linespec.c:
6419         (find_linespec_symbols): Replace throw_exception with throw.
6420         * infrun.c (displaced_step_prepare, resume): Replace
6421         throw_exception with throw.
6422         * infcmd.c (post_create_inferior): Replace throw_exception with
6423         throw.
6424         * inf-loop.c (inferior_event_handler): Replace throw_exception
6425         with throw.
6426         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6427         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6428         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6429         (get_prev_frame_always, get_frame_pc_if_available)
6430         (get_frame_address_in_block_if_available, get_frame_language):
6431         Replace throw_exception with throw.
6432         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6433         throw_exception with throw.
6434         * eval.c (fetch_subexp_value, evaluate_var_value)
6435         (evaluate_funcall, evaluate_subexp_standard): Replace
6436         throw_exception with throw.
6437         * dwarf2loc.c (call_site_find_chain)
6438         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6439         Replace throw_exception with throw.
6440         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6441         with throw.
6442         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6443         throw.
6444         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6445         * completer.c (complete_line_internal): Replace throw_exception
6446         with throw.
6447         * compile/compile-object-run.c (compile_object_run): Replace
6448         throw_exception with throw.
6449         * cli/cli-script.c (process_next_line): Replace throw_exception
6450         with throw.
6451         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6452         (btrace_enable, btrace_maint_update_pt_packets): Replace
6453         throw_exception with throw.
6454         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6455         throw_exception with throw.
6456         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6457         throw_exception with throw.
6458         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6459         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6460         * aarch64-tdep.c (aarch64_make_prologue_cache)
6461         (aarch64_make_stub_cache): Replace throw_exception with throw.
6462
6463 2019-04-08  Tom Tromey  <tom@tromey.com>
6464
6465         * common/common-exceptions.c (throw_exception): Rename from
6466         throw_exception_cxx.  Remove old copy.  Make argument const.
6467         (throw_it): Create and throw exception objects directly.
6468         * common/common-exceptions.h (throw_exception): Make argument
6469         const.
6470         (struct gdb_exception_error): Add constructor.
6471         (struct gdb_exception_quit): Add constructor.
6472
6473 2019-04-08  Tom Tromey  <tom@tromey.com>
6474
6475         * common/common-exceptions.h (exception_rethrow): Don't declare.
6476         (TRY_SJLJ): Update comment.
6477         (TRY, CATCH, END_CATCH): Remove.
6478         * common/common-exceptions.c (exception_rethrow): Remove.
6479
6480 2019-04-08  Tom Tromey  <tom@tromey.com>
6481
6482         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6483         Remove.
6484         (gdb_exception_error): Rename from
6485         gdb_exception_RETURN_MASK_ERROR.
6486         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6487         (gdb_quit_bad_alloc): Update.
6488         * aarch64-tdep.c: Update.
6489         * ada-lang.c: Update.
6490         * ada-typeprint.c: Update.
6491         * ada-valprint.c: Update.
6492         * amd64-tdep.c: Update.
6493         * arch-utils.c: Update.
6494         * break-catch-throw.c: Update.
6495         * breakpoint.c: Update.
6496         * btrace.c: Update.
6497         * c-varobj.c: Update.
6498         * cli/cli-cmds.c: Update.
6499         * cli/cli-interp.c: Update.
6500         * cli/cli-script.c: Update.
6501         * common/common-exceptions.c: Update.
6502         * common/new-op.c: Update.
6503         * common/selftest.c: Update.
6504         * compile/compile-c-symbols.c: Update.
6505         * compile/compile-cplus-symbols.c: Update.
6506         * compile/compile-object-load.c: Update.
6507         * compile/compile-object-run.c: Update.
6508         * completer.c: Update.
6509         * corelow.c: Update.
6510         * cp-abi.c: Update.
6511         * cp-support.c: Update.
6512         * cp-valprint.c: Update.
6513         * darwin-nat.c: Update.
6514         * disasm-selftests.c: Update.
6515         * dtrace-probe.c: Update.
6516         * dwarf-index-cache.c: Update.
6517         * dwarf-index-write.c: Update.
6518         * dwarf2-frame-tailcall.c: Update.
6519         * dwarf2-frame.c: Update.
6520         * dwarf2loc.c: Update.
6521         * dwarf2read.c: Update.
6522         * eval.c: Update.
6523         * event-loop.c: Update.
6524         * event-top.c: Update.
6525         * exec.c: Update.
6526         * f-valprint.c: Update.
6527         * fbsd-tdep.c: Update.
6528         * frame-unwind.c: Update.
6529         * frame.c: Update.
6530         * gdbtypes.c: Update.
6531         * gnu-v3-abi.c: Update.
6532         * guile/guile-internal.h: Update.
6533         * guile/scm-block.c: Update.
6534         * guile/scm-breakpoint.c: Update.
6535         * guile/scm-cmd.c: Update.
6536         * guile/scm-disasm.c: Update.
6537         * guile/scm-frame.c: Update.
6538         * guile/scm-lazy-string.c: Update.
6539         * guile/scm-math.c: Update.
6540         * guile/scm-param.c: Update.
6541         * guile/scm-ports.c: Update.
6542         * guile/scm-pretty-print.c: Update.
6543         * guile/scm-symbol.c: Update.
6544         * guile/scm-symtab.c: Update.
6545         * guile/scm-type.c: Update.
6546         * guile/scm-value.c: Update.
6547         * i386-linux-tdep.c: Update.
6548         * i386-tdep.c: Update.
6549         * inf-loop.c: Update.
6550         * infcall.c: Update.
6551         * infcmd.c: Update.
6552         * infrun.c: Update.
6553         * jit.c: Update.
6554         * language.c: Update.
6555         * linespec.c: Update.
6556         * linux-fork.c: Update.
6557         * linux-nat.c: Update.
6558         * linux-tdep.c: Update.
6559         * linux-thread-db.c: Update.
6560         * main.c: Update.
6561         * mi/mi-cmd-break.c: Update.
6562         * mi/mi-cmd-stack.c: Update.
6563         * mi/mi-interp.c: Update.
6564         * mi/mi-main.c: Update.
6565         * objc-lang.c: Update.
6566         * p-valprint.c: Update.
6567         * parse.c: Update.
6568         * ppc-linux-tdep.c: Update.
6569         * printcmd.c: Update.
6570         * python/py-arch.c: Update.
6571         * python/py-breakpoint.c: Update.
6572         * python/py-cmd.c: Update.
6573         * python/py-finishbreakpoint.c: Update.
6574         * python/py-frame.c: Update.
6575         * python/py-framefilter.c: Update.
6576         * python/py-gdb-readline.c: Update.
6577         * python/py-inferior.c: Update.
6578         * python/py-infthread.c: Update.
6579         * python/py-lazy-string.c: Update.
6580         * python/py-linetable.c: Update.
6581         * python/py-objfile.c: Update.
6582         * python/py-param.c: Update.
6583         * python/py-prettyprint.c: Update.
6584         * python/py-progspace.c: Update.
6585         * python/py-record-btrace.c: Update.
6586         * python/py-record.c: Update.
6587         * python/py-symbol.c: Update.
6588         * python/py-type.c: Update.
6589         * python/py-unwind.c: Update.
6590         * python/py-utils.c: Update.
6591         * python/py-value.c: Update.
6592         * python/python.c: Update.
6593         * record-btrace.c: Update.
6594         * record-full.c: Update.
6595         * remote-fileio.c: Update.
6596         * remote.c: Update.
6597         * riscv-tdep.c: Update.
6598         * rs6000-aix-tdep.c: Update.
6599         * rs6000-tdep.c: Update.
6600         * rust-exp.y: Update.
6601         * rust-lang.c: Update.
6602         * s390-tdep.c: Update.
6603         * selftest-arch.c: Update.
6604         * solib-dsbt.c: Update.
6605         * solib-frv.c: Update.
6606         * solib-spu.c: Update.
6607         * solib-svr4.c: Update.
6608         * solib.c: Update.
6609         * sparc64-linux-tdep.c: Update.
6610         * stack.c: Update.
6611         * symfile-mem.c: Update.
6612         * symmisc.c: Update.
6613         * target.c: Update.
6614         * thread.c: Update.
6615         * top.c: Update.
6616         * tracefile-tfile.c: Update.
6617         * tui/tui.c: Update.
6618         * typeprint.c: Update.
6619         * unittests/cli-utils-selftests.c: Update.
6620         * unittests/parse-connection-spec-selftests.c: Update.
6621         * valops.c: Update.
6622         * valprint.c: Update.
6623         * value.c: Update.
6624         * varobj.c: Update.
6625         * windows-nat.c: Update.
6626         * x86-linux-nat.c: Update.
6627         * xml-support.c: Update.
6628
6629 2019-04-08  Tom Tromey  <tom@tromey.com>
6630
6631         * xml-support.c: Use C++ exception handling.
6632         * x86-linux-nat.c: Use C++ exception handling.
6633         * windows-nat.c: Use C++ exception handling.
6634         * varobj.c: Use C++ exception handling.
6635         * value.c: Use C++ exception handling.
6636         * valprint.c: Use C++ exception handling.
6637         * valops.c: Use C++ exception handling.
6638         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6639         handling.
6640         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6641         * typeprint.c: Use C++ exception handling.
6642         * tui/tui.c: Use C++ exception handling.
6643         * tracefile-tfile.c: Use C++ exception handling.
6644         * top.c: Use C++ exception handling.
6645         * thread.c: Use C++ exception handling.
6646         * target.c: Use C++ exception handling.
6647         * symmisc.c: Use C++ exception handling.
6648         * symfile-mem.c: Use C++ exception handling.
6649         * stack.c: Use C++ exception handling.
6650         * sparc64-linux-tdep.c: Use C++ exception handling.
6651         * solib.c: Use C++ exception handling.
6652         * solib-svr4.c: Use C++ exception handling.
6653         * solib-spu.c: Use C++ exception handling.
6654         * solib-frv.c: Use C++ exception handling.
6655         * solib-dsbt.c: Use C++ exception handling.
6656         * selftest-arch.c: Use C++ exception handling.
6657         * s390-tdep.c: Use C++ exception handling.
6658         * rust-lang.c: Use C++ exception handling.
6659         * rust-exp.y: Use C++ exception handling.
6660         * rs6000-tdep.c: Use C++ exception handling.
6661         * rs6000-aix-tdep.c: Use C++ exception handling.
6662         * riscv-tdep.c: Use C++ exception handling.
6663         * remote.c: Use C++ exception handling.
6664         * remote-fileio.c: Use C++ exception handling.
6665         * record-full.c: Use C++ exception handling.
6666         * record-btrace.c: Use C++ exception handling.
6667         * python/python.c: Use C++ exception handling.
6668         * python/py-value.c: Use C++ exception handling.
6669         * python/py-utils.c: Use C++ exception handling.
6670         * python/py-unwind.c: Use C++ exception handling.
6671         * python/py-type.c: Use C++ exception handling.
6672         * python/py-symbol.c: Use C++ exception handling.
6673         * python/py-record.c: Use C++ exception handling.
6674         * python/py-record-btrace.c: Use C++ exception handling.
6675         * python/py-progspace.c: Use C++ exception handling.
6676         * python/py-prettyprint.c: Use C++ exception handling.
6677         * python/py-param.c: Use C++ exception handling.
6678         * python/py-objfile.c: Use C++ exception handling.
6679         * python/py-linetable.c: Use C++ exception handling.
6680         * python/py-lazy-string.c: Use C++ exception handling.
6681         * python/py-infthread.c: Use C++ exception handling.
6682         * python/py-inferior.c: Use C++ exception handling.
6683         * python/py-gdb-readline.c: Use C++ exception handling.
6684         * python/py-framefilter.c: Use C++ exception handling.
6685         * python/py-frame.c: Use C++ exception handling.
6686         * python/py-finishbreakpoint.c: Use C++ exception handling.
6687         * python/py-cmd.c: Use C++ exception handling.
6688         * python/py-breakpoint.c: Use C++ exception handling.
6689         * python/py-arch.c: Use C++ exception handling.
6690         * printcmd.c: Use C++ exception handling.
6691         * ppc-linux-tdep.c: Use C++ exception handling.
6692         * parse.c: Use C++ exception handling.
6693         * p-valprint.c: Use C++ exception handling.
6694         * objc-lang.c: Use C++ exception handling.
6695         * mi/mi-main.c: Use C++ exception handling.
6696         * mi/mi-interp.c: Use C++ exception handling.
6697         * mi/mi-cmd-stack.c: Use C++ exception handling.
6698         * mi/mi-cmd-break.c: Use C++ exception handling.
6699         * main.c: Use C++ exception handling.
6700         * linux-thread-db.c: Use C++ exception handling.
6701         * linux-tdep.c: Use C++ exception handling.
6702         * linux-nat.c: Use C++ exception handling.
6703         * linux-fork.c: Use C++ exception handling.
6704         * linespec.c: Use C++ exception handling.
6705         * language.c: Use C++ exception handling.
6706         * jit.c: Use C++ exception handling.
6707         * infrun.c: Use C++ exception handling.
6708         * infcmd.c: Use C++ exception handling.
6709         * infcall.c: Use C++ exception handling.
6710         * inf-loop.c: Use C++ exception handling.
6711         * i386-tdep.c: Use C++ exception handling.
6712         * i386-linux-tdep.c: Use C++ exception handling.
6713         * guile/scm-value.c: Use C++ exception handling.
6714         * guile/scm-type.c: Use C++ exception handling.
6715         * guile/scm-symtab.c: Use C++ exception handling.
6716         * guile/scm-symbol.c: Use C++ exception handling.
6717         * guile/scm-pretty-print.c: Use C++ exception handling.
6718         * guile/scm-ports.c: Use C++ exception handling.
6719         * guile/scm-param.c: Use C++ exception handling.
6720         * guile/scm-math.c: Use C++ exception handling.
6721         * guile/scm-lazy-string.c: Use C++ exception handling.
6722         * guile/scm-frame.c: Use C++ exception handling.
6723         * guile/scm-disasm.c: Use C++ exception handling.
6724         * guile/scm-cmd.c: Use C++ exception handling.
6725         * guile/scm-breakpoint.c: Use C++ exception handling.
6726         * guile/scm-block.c: Use C++ exception handling.
6727         * guile/guile-internal.h: Use C++ exception handling.
6728         * gnu-v3-abi.c: Use C++ exception handling.
6729         * gdbtypes.c: Use C++ exception handling.
6730         * frame.c: Use C++ exception handling.
6731         * frame-unwind.c: Use C++ exception handling.
6732         * fbsd-tdep.c: Use C++ exception handling.
6733         * f-valprint.c: Use C++ exception handling.
6734         * exec.c: Use C++ exception handling.
6735         * event-top.c: Use C++ exception handling.
6736         * event-loop.c: Use C++ exception handling.
6737         * eval.c: Use C++ exception handling.
6738         * dwarf2read.c: Use C++ exception handling.
6739         * dwarf2loc.c: Use C++ exception handling.
6740         * dwarf2-frame.c: Use C++ exception handling.
6741         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6742         * dwarf-index-write.c: Use C++ exception handling.
6743         * dwarf-index-cache.c: Use C++ exception handling.
6744         * dtrace-probe.c: Use C++ exception handling.
6745         * disasm-selftests.c: Use C++ exception handling.
6746         * darwin-nat.c: Use C++ exception handling.
6747         * cp-valprint.c: Use C++ exception handling.
6748         * cp-support.c: Use C++ exception handling.
6749         * cp-abi.c: Use C++ exception handling.
6750         * corelow.c: Use C++ exception handling.
6751         * completer.c: Use C++ exception handling.
6752         * compile/compile-object-run.c: Use C++ exception handling.
6753         * compile/compile-object-load.c: Use C++ exception handling.
6754         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6755         * compile/compile-c-symbols.c: Use C++ exception handling.
6756         * common/selftest.c: Use C++ exception handling.
6757         * common/new-op.c: Use C++ exception handling.
6758         * cli/cli-script.c: Use C++ exception handling.
6759         * cli/cli-interp.c: Use C++ exception handling.
6760         * cli/cli-cmds.c: Use C++ exception handling.
6761         * c-varobj.c: Use C++ exception handling.
6762         * btrace.c: Use C++ exception handling.
6763         * breakpoint.c: Use C++ exception handling.
6764         * break-catch-throw.c: Use C++ exception handling.
6765         * arch-utils.c: Use C++ exception handling.
6766         * amd64-tdep.c: Use C++ exception handling.
6767         * ada-valprint.c: Use C++ exception handling.
6768         * ada-typeprint.c: Use C++ exception handling.
6769         * ada-lang.c: Use C++ exception handling.
6770         * aarch64-tdep.c: Use C++ exception handling.
6771
6772 2019-04-08  Tom Tromey  <tom@tromey.com>
6773
6774         * xml-support.c (gdb_xml_parser::parse): Update.
6775         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6776         * value.c (show_convenience): Update.
6777         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6778         (test_parse_flags_qcs): Update.
6779         * thread.c (thr_try_catch_cmd): Update.
6780         * target.c (target_translate_tls_address): Update.
6781         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6782         (info_frame_command_core, frame_apply_command_count): Update.
6783         * rust-exp.y (rust_lex_exception_test): Update.
6784         * riscv-tdep.c (riscv_print_one_register_info): Update.
6785         * remote.c (remote_target::enable_btrace): Update.
6786         * record-btrace.c (record_btrace_enable_warn): Update.
6787         * python/py-utils.c (gdbpy_convert_exception): Update.
6788         * printcmd.c (do_one_display, print_variable_and_value): Update.
6789         * mi/mi-main.c (mi_print_exception): Update.
6790         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6791         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6792         * linux-nat.c (linux_nat_target::attach): Update.
6793         * linux-fork.c (class scoped_switch_fork_info): Update.
6794         * infrun.c (displaced_step_prepare): Update.
6795         * infcall.c (call_function_by_hand_dummy): Update.
6796         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6797         * gnu-v3-abi.c (print_one_vtable): Update.
6798         * frame.c (get_prev_frame_always): Update.
6799         * f-valprint.c (info_common_command_for_block): Update.
6800         * exec.c (try_open_exec_file): Update.
6801         * exceptions.c (print_exception, exception_print)
6802         (exception_fprintf, exception_print_same): Update.
6803         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6804         * dwarf-index-cache.c (index_cache::store)
6805         (index_cache::lookup_gdb_index): Update.
6806         * darwin-nat.c (maybe_cache_shell): Update.
6807         * cp-valprint.c (cp_print_value_fields): Update.
6808         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6809         (gcc_cplus_symbol_address): Update.
6810         * compile/compile-c-symbols.c (gcc_convert_symbol)
6811         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6812         * common/selftest.c: Update.
6813         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6814         a std::string.
6815         (exception_try_scope_entry, exception_try_scope_exit): Don't
6816         declare.
6817         (struct exception_try_scope): Remove.
6818         (TRY): Don't use exception_try_scope.
6819         (struct gdb_exception): Add constructor, operator=.
6820         <what>: New method.
6821         (struct gdb_exception_RETURN_MASK_ALL)
6822         (struct gdb_exception_RETURN_MASK_ERROR)
6823         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6824         (struct gdb_quit_bad_alloc): Update.
6825         * common/common-exceptions.c (exception_none): Change
6826         initializer.
6827         (struct catcher) <state, exception>: Initialize inline.
6828         <prev>: Remove member.
6829         (current_catcher): Remove.
6830         (catchers): New global.
6831         (exceptions_state_mc_init): Simplify.
6832         (catcher_pop): Remove.
6833         (exceptions_state_mc, exceptions_state_mc_catch): Update.
6834         (try_scope_depth, exception_try_scope_entry)
6835         (exception_try_scope_exit): Remove.
6836         (throw_exception_sjlj): Update.
6837         (exception_messages, exception_messages_size): Remove.
6838         (throw_it): Simplify.
6839         (gdb_exception_sliced_copy): Remove.
6840         (throw_exception_cxx): Update.
6841         * cli/cli-script.c (script_from_file): Update.
6842         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
6843         Update.
6844         * ada-valprint.c (ada_val_print): Update.
6845         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
6846         (create_excep_cond_exprs): Update.
6847
6848 2019-04-08  Tom Tromey  <tom@tromey.com>
6849
6850         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
6851         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
6852         (TRY, CATCH, END_CATCH): Remove some definitions.
6853         * common/common-exceptions.c: Don't use GDB_XCPT.
6854         (catcher_list_size): Remove.
6855         (throw_exception, throw_it): Simplify.
6856
6857 2019-04-05  Tom Tromey  <tom@tromey.com>
6858
6859         Revert the header-sorting patch.
6860         * ft32-tdep.c: Revert.
6861         * frv-tdep.c: Revert.
6862         * frv-linux-tdep.c: Revert.
6863         * frame.c: Revert.
6864         * frame-unwind.c: Revert.
6865         * frame-base.c: Revert.
6866         * fork-child.c: Revert.
6867         * findvar.c: Revert.
6868         * findcmd.c: Revert.
6869         * filesystem.c: Revert.
6870         * filename-seen-cache.h: Revert.
6871         * filename-seen-cache.c: Revert.
6872         * fbsd-tdep.c: Revert.
6873         * fbsd-nat.h: Revert.
6874         * fbsd-nat.c: Revert.
6875         * f-valprint.c: Revert.
6876         * f-typeprint.c: Revert.
6877         * f-lang.c: Revert.
6878         * extension.h: Revert.
6879         * extension.c: Revert.
6880         * extension-priv.h: Revert.
6881         * expprint.c: Revert.
6882         * exec.h: Revert.
6883         * exec.c: Revert.
6884         * exceptions.c: Revert.
6885         * event-top.c: Revert.
6886         * event-loop.c: Revert.
6887         * eval.c: Revert.
6888         * elfread.c: Revert.
6889         * dwarf2read.h: Revert.
6890         * dwarf2read.c: Revert.
6891         * dwarf2loc.c: Revert.
6892         * dwarf2expr.h: Revert.
6893         * dwarf2expr.c: Revert.
6894         * dwarf2-frame.c: Revert.
6895         * dwarf2-frame-tailcall.c: Revert.
6896         * dwarf-index-write.h: Revert.
6897         * dwarf-index-write.c: Revert.
6898         * dwarf-index-common.c: Revert.
6899         * dwarf-index-cache.h: Revert.
6900         * dwarf-index-cache.c: Revert.
6901         * dummy-frame.c: Revert.
6902         * dtrace-probe.c: Revert.
6903         * disasm.h: Revert.
6904         * disasm.c: Revert.
6905         * disasm-selftests.c: Revert.
6906         * dictionary.c: Revert.
6907         * dicos-tdep.c: Revert.
6908         * demangle.c: Revert.
6909         * dcache.h: Revert.
6910         * dcache.c: Revert.
6911         * darwin-nat.h: Revert.
6912         * darwin-nat.c: Revert.
6913         * darwin-nat-info.c: Revert.
6914         * d-valprint.c: Revert.
6915         * d-namespace.c: Revert.
6916         * d-lang.c: Revert.
6917         * ctf.c: Revert.
6918         * csky-tdep.c: Revert.
6919         * csky-linux-tdep.c: Revert.
6920         * cris-tdep.c: Revert.
6921         * cris-linux-tdep.c: Revert.
6922         * cp-valprint.c: Revert.
6923         * cp-support.c: Revert.
6924         * cp-namespace.c: Revert.
6925         * cp-abi.c: Revert.
6926         * corelow.c: Revert.
6927         * corefile.c: Revert.
6928         * continuations.c: Revert.
6929         * completer.h: Revert.
6930         * completer.c: Revert.
6931         * complaints.c: Revert.
6932         * coffread.c: Revert.
6933         * coff-pe-read.c: Revert.
6934         * cli-out.h: Revert.
6935         * cli-out.c: Revert.
6936         * charset.c: Revert.
6937         * c-varobj.c: Revert.
6938         * c-valprint.c: Revert.
6939         * c-typeprint.c: Revert.
6940         * c-lang.c: Revert.
6941         * buildsym.c: Revert.
6942         * buildsym-legacy.c: Revert.
6943         * build-id.h: Revert.
6944         * build-id.c: Revert.
6945         * btrace.c: Revert.
6946         * bsd-uthread.c: Revert.
6947         * breakpoint.h: Revert.
6948         * breakpoint.c: Revert.
6949         * break-catch-throw.c: Revert.
6950         * break-catch-syscall.c: Revert.
6951         * break-catch-sig.c: Revert.
6952         * blockframe.c: Revert.
6953         * block.c: Revert.
6954         * bfin-tdep.c: Revert.
6955         * bfin-linux-tdep.c: Revert.
6956         * bfd-target.c: Revert.
6957         * bcache.c: Revert.
6958         * ax-general.c: Revert.
6959         * ax-gdb.h: Revert.
6960         * ax-gdb.c: Revert.
6961         * avr-tdep.c: Revert.
6962         * auxv.c: Revert.
6963         * auto-load.c: Revert.
6964         * arm-wince-tdep.c: Revert.
6965         * arm-tdep.c: Revert.
6966         * arm-symbian-tdep.c: Revert.
6967         * arm-pikeos-tdep.c: Revert.
6968         * arm-obsd-tdep.c: Revert.
6969         * arm-nbsd-tdep.c: Revert.
6970         * arm-nbsd-nat.c: Revert.
6971         * arm-linux-tdep.c: Revert.
6972         * arm-linux-nat.c: Revert.
6973         * arm-fbsd-tdep.c: Revert.
6974         * arm-fbsd-nat.c: Revert.
6975         * arm-bsd-tdep.c: Revert.
6976         * arch-utils.c: Revert.
6977         * arc-tdep.c: Revert.
6978         * arc-newlib-tdep.c: Revert.
6979         * annotate.h: Revert.
6980         * annotate.c: Revert.
6981         * amd64-windows-tdep.c: Revert.
6982         * amd64-windows-nat.c: Revert.
6983         * amd64-tdep.c: Revert.
6984         * amd64-sol2-tdep.c: Revert.
6985         * amd64-obsd-tdep.c: Revert.
6986         * amd64-obsd-nat.c: Revert.
6987         * amd64-nbsd-tdep.c: Revert.
6988         * amd64-nbsd-nat.c: Revert.
6989         * amd64-nat.c: Revert.
6990         * amd64-linux-tdep.c: Revert.
6991         * amd64-linux-nat.c: Revert.
6992         * amd64-fbsd-tdep.c: Revert.
6993         * amd64-fbsd-nat.c: Revert.
6994         * amd64-dicos-tdep.c: Revert.
6995         * amd64-darwin-tdep.c: Revert.
6996         * amd64-bsd-nat.c: Revert.
6997         * alpha-tdep.c: Revert.
6998         * alpha-obsd-tdep.c: Revert.
6999         * alpha-nbsd-tdep.c: Revert.
7000         * alpha-mdebug-tdep.c: Revert.
7001         * alpha-linux-tdep.c: Revert.
7002         * alpha-linux-nat.c: Revert.
7003         * alpha-bsd-tdep.c: Revert.
7004         * alpha-bsd-nat.c: Revert.
7005         * aix-thread.c: Revert.
7006         * agent.c: Revert.
7007         * addrmap.c: Revert.
7008         * ada-varobj.c: Revert.
7009         * ada-valprint.c: Revert.
7010         * ada-typeprint.c: Revert.
7011         * ada-tasks.c: Revert.
7012         * ada-lang.c: Revert.
7013         * aarch64-tdep.c: Revert.
7014         * aarch64-ravenscar-thread.c: Revert.
7015         * aarch64-newlib-tdep.c: Revert.
7016         * aarch64-linux-tdep.c: Revert.
7017         * aarch64-linux-nat.c: Revert.
7018         * aarch64-fbsd-tdep.c: Revert.
7019         * aarch64-fbsd-nat.c: Revert.
7020         * aarch32-linux-nat.c: Revert.
7021
7022 2019-04-05  Tom Tromey  <tom@tromey.com>
7023
7024         * ft32-tdep.c: Sort headers.
7025         * frv-tdep.c: Sort headers.
7026         * frv-linux-tdep.c: Sort headers.
7027         * frame.c: Sort headers.
7028         * frame-unwind.c: Sort headers.
7029         * frame-base.c: Sort headers.
7030         * fork-child.c: Sort headers.
7031         * findvar.c: Sort headers.
7032         * findcmd.c: Sort headers.
7033         * filesystem.c: Sort headers.
7034         * filename-seen-cache.h: Sort headers.
7035         * filename-seen-cache.c: Sort headers.
7036         * fbsd-tdep.c: Sort headers.
7037         * fbsd-nat.h: Sort headers.
7038         * fbsd-nat.c: Sort headers.
7039         * f-valprint.c: Sort headers.
7040         * f-typeprint.c: Sort headers.
7041         * f-lang.c: Sort headers.
7042         * extension.h: Sort headers.
7043         * extension.c: Sort headers.
7044         * extension-priv.h: Sort headers.
7045         * expprint.c: Sort headers.
7046         * exec.h: Sort headers.
7047         * exec.c: Sort headers.
7048         * exceptions.c: Sort headers.
7049         * event-top.c: Sort headers.
7050         * event-loop.c: Sort headers.
7051         * eval.c: Sort headers.
7052         * elfread.c: Sort headers.
7053         * dwarf2read.h: Sort headers.
7054         * dwarf2read.c: Sort headers.
7055         * dwarf2loc.c: Sort headers.
7056         * dwarf2expr.h: Sort headers.
7057         * dwarf2expr.c: Sort headers.
7058         * dwarf2-frame.c: Sort headers.
7059         * dwarf2-frame-tailcall.c: Sort headers.
7060         * dwarf-index-write.h: Sort headers.
7061         * dwarf-index-write.c: Sort headers.
7062         * dwarf-index-common.c: Sort headers.
7063         * dwarf-index-cache.h: Sort headers.
7064         * dwarf-index-cache.c: Sort headers.
7065         * dummy-frame.c: Sort headers.
7066         * dtrace-probe.c: Sort headers.
7067         * disasm.h: Sort headers.
7068         * disasm.c: Sort headers.
7069         * disasm-selftests.c: Sort headers.
7070         * dictionary.c: Sort headers.
7071         * dicos-tdep.c: Sort headers.
7072         * demangle.c: Sort headers.
7073         * dcache.h: Sort headers.
7074         * dcache.c: Sort headers.
7075         * darwin-nat.h: Sort headers.
7076         * darwin-nat.c: Sort headers.
7077         * darwin-nat-info.c: Sort headers.
7078         * d-valprint.c: Sort headers.
7079         * d-namespace.c: Sort headers.
7080         * d-lang.c: Sort headers.
7081         * ctf.c: Sort headers.
7082         * csky-tdep.c: Sort headers.
7083         * csky-linux-tdep.c: Sort headers.
7084         * cris-tdep.c: Sort headers.
7085         * cris-linux-tdep.c: Sort headers.
7086         * cp-valprint.c: Sort headers.
7087         * cp-support.c: Sort headers.
7088         * cp-namespace.c: Sort headers.
7089         * cp-abi.c: Sort headers.
7090         * corelow.c: Sort headers.
7091         * corefile.c: Sort headers.
7092         * continuations.c: Sort headers.
7093         * completer.h: Sort headers.
7094         * completer.c: Sort headers.
7095         * complaints.c: Sort headers.
7096         * coffread.c: Sort headers.
7097         * coff-pe-read.c: Sort headers.
7098         * cli-out.h: Sort headers.
7099         * cli-out.c: Sort headers.
7100         * charset.c: Sort headers.
7101         * c-varobj.c: Sort headers.
7102         * c-valprint.c: Sort headers.
7103         * c-typeprint.c: Sort headers.
7104         * c-lang.c: Sort headers.
7105         * buildsym.c: Sort headers.
7106         * buildsym-legacy.c: Sort headers.
7107         * build-id.h: Sort headers.
7108         * build-id.c: Sort headers.
7109         * btrace.c: Sort headers.
7110         * bsd-uthread.c: Sort headers.
7111         * breakpoint.h: Sort headers.
7112         * breakpoint.c: Sort headers.
7113         * break-catch-throw.c: Sort headers.
7114         * break-catch-syscall.c: Sort headers.
7115         * break-catch-sig.c: Sort headers.
7116         * blockframe.c: Sort headers.
7117         * block.c: Sort headers.
7118         * bfin-tdep.c: Sort headers.
7119         * bfin-linux-tdep.c: Sort headers.
7120         * bfd-target.c: Sort headers.
7121         * bcache.c: Sort headers.
7122         * ax-general.c: Sort headers.
7123         * ax-gdb.h: Sort headers.
7124         * ax-gdb.c: Sort headers.
7125         * avr-tdep.c: Sort headers.
7126         * auxv.c: Sort headers.
7127         * auto-load.c: Sort headers.
7128         * arm-wince-tdep.c: Sort headers.
7129         * arm-tdep.c: Sort headers.
7130         * arm-symbian-tdep.c: Sort headers.
7131         * arm-pikeos-tdep.c: Sort headers.
7132         * arm-obsd-tdep.c: Sort headers.
7133         * arm-nbsd-tdep.c: Sort headers.
7134         * arm-nbsd-nat.c: Sort headers.
7135         * arm-linux-tdep.c: Sort headers.
7136         * arm-linux-nat.c: Sort headers.
7137         * arm-fbsd-tdep.c: Sort headers.
7138         * arm-fbsd-nat.c: Sort headers.
7139         * arm-bsd-tdep.c: Sort headers.
7140         * arch-utils.c: Sort headers.
7141         * arc-tdep.c: Sort headers.
7142         * arc-newlib-tdep.c: Sort headers.
7143         * annotate.h: Sort headers.
7144         * annotate.c: Sort headers.
7145         * amd64-windows-tdep.c: Sort headers.
7146         * amd64-windows-nat.c: Sort headers.
7147         * amd64-tdep.c: Sort headers.
7148         * amd64-sol2-tdep.c: Sort headers.
7149         * amd64-obsd-tdep.c: Sort headers.
7150         * amd64-obsd-nat.c: Sort headers.
7151         * amd64-nbsd-tdep.c: Sort headers.
7152         * amd64-nbsd-nat.c: Sort headers.
7153         * amd64-nat.c: Sort headers.
7154         * amd64-linux-tdep.c: Sort headers.
7155         * amd64-linux-nat.c: Sort headers.
7156         * amd64-fbsd-tdep.c: Sort headers.
7157         * amd64-fbsd-nat.c: Sort headers.
7158         * amd64-dicos-tdep.c: Sort headers.
7159         * amd64-darwin-tdep.c: Sort headers.
7160         * amd64-bsd-nat.c: Sort headers.
7161         * alpha-tdep.c: Sort headers.
7162         * alpha-obsd-tdep.c: Sort headers.
7163         * alpha-nbsd-tdep.c: Sort headers.
7164         * alpha-mdebug-tdep.c: Sort headers.
7165         * alpha-linux-tdep.c: Sort headers.
7166         * alpha-linux-nat.c: Sort headers.
7167         * alpha-bsd-tdep.c: Sort headers.
7168         * alpha-bsd-nat.c: Sort headers.
7169         * aix-thread.c: Sort headers.
7170         * agent.c: Sort headers.
7171         * addrmap.c: Sort headers.
7172         * ada-varobj.c: Sort headers.
7173         * ada-valprint.c: Sort headers.
7174         * ada-typeprint.c: Sort headers.
7175         * ada-tasks.c: Sort headers.
7176         * ada-lang.c: Sort headers.
7177         * aarch64-tdep.c: Sort headers.
7178         * aarch64-ravenscar-thread.c: Sort headers.
7179         * aarch64-newlib-tdep.c: Sort headers.
7180         * aarch64-linux-tdep.c: Sort headers.
7181         * aarch64-linux-nat.c: Sort headers.
7182         * aarch64-fbsd-tdep.c: Sort headers.
7183         * aarch64-fbsd-nat.c: Sort headers.
7184         * aarch32-linux-nat.c: Sort headers.
7185
7186 2019-04-04  Tom Tromey  <tom@tromey.com>
7187
7188         * varobj.c (varobj_create): Update.
7189         * rust-exp.y (struct rust_parser) <update_innermost_block,
7190         lookup_symbol>: New methods.
7191         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7192         Rename.
7193         (rust_parser::rust_lookup_type)
7194         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7195         * printcmd.c (display_command, do_one_display): Update.
7196         * parser-defs.h (struct parser_state) <parser_state>: Add
7197         "tracker" parameter.
7198         (block_tracker): New member.
7199         (class innermost_block_tracker) <innermost_block_tracker>: Add
7200         "types" parameter.
7201         <reset>: Remove method.
7202         (innermost_block): Don't declare.
7203         (null_post_parser): Update.
7204         * parse.c (innermost_block): Remove global.
7205         (write_dollar_variable): Update.
7206         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7207         Remove "tracker_types" parameter.
7208         (parse_expression): Add "tracker" parameter.
7209         (parse_expression_for_completion): Update.
7210         (null_post_parser): Add "tracker" parameter.
7211         * p-exp.y: Update rules.
7212         * m2-exp.y: Update rules.
7213         * language.h (struct language_defn) <la_post_parser>: Add
7214         "tracker" parameter.
7215         * go-exp.y: Update rules.
7216         * f-exp.y: Update rules.
7217         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7218         parameter.
7219         * d-exp.y: Update rules.
7220         * c-exp.y: Update rules.
7221         * breakpoint.c (set_breakpoint_condition): Create an
7222         innermost_block_tracker.
7223         (watch_command_1): Likewise.
7224         * ada-lang.c (resolve): Add "tracker" parameter.
7225         (resolve_subexp): Likewise.
7226         * ada-exp.y (write_var_from_sym): Update.
7227
7228 2019-04-04  Tom Tromey  <tom@tromey.com>
7229
7230         * type-stack.h: New file.
7231         * type-stack.c: New file.
7232         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7233         type-stack.h.
7234         (insert_into_type_stack, insert_type, push_type, push_type_int)
7235         (insert_type_address_space, pop_type, pop_type_int)
7236         (pop_typelist, pop_type_stack, append_type_stack)
7237         (push_type_stack, get_type_stack, push_typelist)
7238         (follow_type_instance_flags, follow_types): Don't declare.
7239         * parse.c (type_stack): Remove global.
7240         (parse_exp_in_context): Update.
7241         (insert_into_type_stack, insert_type, push_type, push_type_int)
7242         (insert_type_address_space, pop_type, pop_type_int)
7243         (pop_typelist, pop_type_stack, append_type_stack)
7244         (push_type_stack, get_type_stack, push_typelist)
7245         (follow_type_instance_flags, follow_types): Remove (moved to
7246         type-stack.c).
7247         * f-exp.y (type_stack): New global.
7248         Update rules.
7249         (push_kind_type, f_parse): Update.
7250         * d-exp.y (type_stack): New global.
7251         Update rules.
7252         (d_parse): Update.
7253         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7254         Update rules.
7255         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7256         (HFILES_NO_SRCDIR): Add type-stack.h.
7257
7258 2019-04-04  Tom Tromey  <tom@tromey.com>
7259
7260         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7261         (rust_parser::convert_ast_to_expression, rust_parse)
7262         (rust_lex_test_completion, rust_lex_tests): Update.
7263         * parser-defs.h (struct expr_completion_state): New.
7264         (struct parser_state) <parser_state>: Add completion parameter.
7265         <mark_struct_expression, mark_completion_tag>: New methods.
7266         <parse_completion, m_completion_state>: New members.
7267         (prefixify_expression, null_post_parser): Update.
7268         (mark_struct_expression, mark_completion_tag): Don't declare.
7269         * parse.c (parse_completion, expout_last_struct)
7270         (expout_tag_completion_type, expout_completion_name): Remove
7271         globals.
7272         (parser_state::mark_struct_expression)
7273         (parser_state::mark_completion_tag): Now methods.
7274         (prefixify_expression): Add last_struct parameter.
7275         (prefixify_subexp): Likewise.
7276         (parse_exp_1): Update.
7277         (parse_exp_in_context): Add cstate parameter.  Update.
7278         (parse_expression_for_completion): Create an
7279         expr_completion_state.
7280         (null_post_parser): Add "completion" parameter.
7281         * p-exp.y: Update rules.
7282         (yylex): Update.
7283         * language.h (struct language_defn) <la_post_parser>: Add
7284         "completing" parameter.
7285         * go-exp.y: Update rules.
7286         (lex_one_token): Update.
7287         * expression.h (parse_completion): Don't declare.
7288         * d-exp.y: Update rules.
7289         (lex_one_token): Update rules.
7290         * c-exp.y: Update rules.
7291         (lex_one_token): Update.
7292         * ada-lang.c (resolve): Add "parse_completion" parameter.
7293         (resolve_subexp): Likewise.
7294         (ada_resolve_function): Likewise.
7295
7296 2019-04-04  Tom Tromey  <tom@tromey.com>
7297
7298         * parser-defs.h (struct parser_state) <start_arglist,
7299         end_arglist>: New methods.
7300         <arglist_len, m_funcall_chain>: New members.
7301         (arglist_len, start_arglist, end_arglist): Don't declare.
7302         * parse.c (arglist_len, funcall_chain): Remove global.
7303         (start_arglist, end_arglist): Remove functions.
7304         (parse_exp_in_context): Update.
7305         * p-exp.y: Update rules.
7306         * m2-exp.y: Update rules.
7307         * go-exp.y: Update rules.
7308         * f-exp.y: Update rules.
7309         * d-exp.y: Update rules.
7310         * c-exp.y: Update rules.
7311
7312 2019-04-04  Tom Tromey  <tom@tromey.com>
7313
7314         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7315         lex_operator, push_back>: New methods.
7316         Update all rules.
7317         (rust_parser::lex_hex, lex_escape): Rename and update.
7318         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7319         (rust_parser::lex_operator): Rename and update.
7320         (rust_parser::lex_number, rustyylex, rustyyerror)
7321         (rust_lex_test_init, rust_lex_test_sequence)
7322         (rust_lex_test_push_back, rust_lex_tests): Update.
7323         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7324         parameter.
7325         <lexptr, prev_lexptr>: New members.
7326         (lexptr, prev_lexptr): Don't declare.
7327         * parse.c (lexptr, prev_lexptr): Remove globals.
7328         (parse_exp_in_context): Update.
7329         * p-exp.y (yylex, yyerror): Update.
7330         * m2-exp.y (parse_number, yylex, yyerror): Update.
7331         * go-exp.y (lex_one_token, yyerror): Update.
7332         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7333         * d-exp.y (lex_one_token, yyerror): Update.
7334         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7335         (lex_one_token, yyerror): Update.
7336         * ada-lex.l (YY_INPUT): Update.
7337         (rewind_to_char): Update.
7338         * ada-exp.y (yyerror): Update.
7339
7340 2019-04-04  Tom Tromey  <tom@tromey.com>
7341
7342         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7343         * parser-defs.h (struct parser_state) <parser_state>: Add new
7344         parameter.
7345         <comma_terminates>: New member.
7346         (comma_terminates): Don't declare global.
7347         * parse.c (comma_terminates): Remove global.
7348         (parse_exp_in_context): Update.
7349         * p-exp.y (yylex): Update.
7350         * m2-exp.y (yylex): Update.
7351         * go-exp.y (lex_one_token): Update.
7352         * f-exp.y (yylex): Update.
7353         * d-exp.y (lex_one_token): Update.
7354         * c-exp.y (lex_one_token): Update.
7355         * ada-lex.l: Update.
7356
7357 2019-04-04  Tom Tromey  <tom@tromey.com>
7358
7359         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7360         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7361         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7362         * parser-defs.h (paren_depth): Don't declare.
7363         * parse.c (paren_depth): Remove global.
7364         (parse_exp_in_context): Update.
7365         * p-exp.y (paren_depth): New global.
7366         (pascal_parse): Initialize it.
7367         * m2-exp.y (paren_depth): New global.
7368         (m2_parse): Initialize it.
7369         * go-exp.y (paren_depth): New global.
7370         (go_parse): Initialize it.
7371         * f-exp.y (paren_depth): New global.
7372         (f_parse): Initialize it.
7373         * d-exp.y (paren_depth): New global.
7374         (d_parse): Initialize it.
7375         * c-exp.y (paren_depth): New global.
7376         (c_parse): Initialize it.
7377         * ada-lex.l (paren_depth): New global.
7378         (lexer_init): Initialize it.
7379
7380 2019-04-04  Tom Tromey  <tom@tromey.com>
7381
7382         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7383         (rust_parser::convert_ast_to_type)
7384         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7385         * parser-defs.h (struct parser_state) <parser_state>: Add
7386         parameters.  Initialize new members.
7387         <expression_context_block, expression_context_pc>: New members.
7388         * parse.c (expression_context_block, expression_context_pc):
7389         Remove globals.
7390         (parse_exp_in_context): Update.
7391         * p-exp.y: Update all rules.
7392         (yylex): Update.
7393         * m2-exp.y: Update all rules.
7394         (yylex): Update.
7395         * go-exp.y (yylex): Update.
7396         * f-exp.y (yylex): Update.
7397         * d-exp.y: Update all rules.
7398         (yylex): Update.
7399         * c-exp.y: Update all rules.
7400         (lex_one_token, classify_name, yylex, c_parse): Update.
7401         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7402
7403 2019-04-04  Tom Tromey  <tom@tromey.com>
7404
7405         * gdbarch.h, gdbarch.c: Rebuild.
7406         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7407         * stap-probe.h:
7408         (struct stap_parse_info): Replace "parser_state" with
7409         "expr_builder".
7410         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7411         (parser_state): New class.
7412         * parse.c (expr_builder): Rename.
7413         (expr_builder::release): Rename.
7414         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7415         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7416         (write_exp_elt_longcst, write_exp_elt_floatcst)
7417         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7418         (write_exp_string_vector, write_exp_bitstring)
7419         (write_exp_msymbol, mark_struct_expression)
7420         (write_dollar_variable)
7421         (insert_type_address_space, increase_expout_size): Replace
7422         "parser_state" with "expr_builder".
7423         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7424         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7425         "parser_state" with "expr_builder".
7426
7427 2019-04-04  Tom Tromey  <tom@tromey.com>
7428
7429         * rust-exp.y: Replace "parse_language" with method call.
7430         * p-exp.y:
7431         (yylex): Replace "parse_language" with method call.
7432         * m2-exp.y:
7433         (yylex): Replace "parse_language" with method call.
7434         * go-exp.y (classify_name): Replace "parse_language" with method
7435         call.
7436         * f-exp.y (yylex): Replace "parse_language" with method call.
7437         * d-exp.y (lex_one_token): Replace "parse_language" with method
7438         call.
7439         * c-exp.y:
7440         (lex_one_token, classify_name, yylex): Replace "parse_language"
7441         with method call.
7442         * ada-exp.y (find_primitive_type, type_char)
7443         (type_system_address): Replace "parse_language" with method call.
7444
7445 2019-04-04  Tom Tromey  <tom@tromey.com>
7446
7447         * rust-exp.y: Replace "parse_gdbarch" with method call.
7448         * parse.c (write_dollar_variable, insert_type_address_space):
7449         Replace "parse_gdbarch" with method call.
7450         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7451         call.
7452         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7453         call.
7454         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7455         "parse_gdbarch" with method call.
7456         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7457         with method call.
7458         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7459         "parse_gdbarch" with method call.
7460         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7461         "parse_gdbarch" with method call.
7462         * c-exp.y (parse_type, parse_number, classify_name): Replace
7463         "parse_gdbarch" with method call.
7464         * ada-lex.l: Replace "parse_gdbarch" with method call.
7465         * ada-exp.y (parse_type, find_primitive_type, type_char)
7466         (type_system_address): Replace "parse_gdbarch" with method call.
7467
7468 2019-04-04  Tom Tromey  <tom@tromey.com>
7469
7470         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7471         * stap-probe.c (stap_parse_argument): Update.
7472         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7473         initial_size parameter.
7474         * rust-exp.y (rust_lex_tests): Update.
7475         * parse.c (parser_state): Update.
7476         (parse_exp_in_context): Update.
7477         * parser-defs.h (struct parser_state) <parser_state>: Remove
7478         "initial_size" parameter.
7479
7480 2019-04-04  Tom Tromey  <tom@tromey.com>
7481
7482         * parser-defs.h (increase_expout_size): Don't declare.
7483         * parse.c (increase_expout_size): Now static.
7484
7485 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7486
7487         * gnu-nat.c (gnu_nat_target::wait): Fix
7488         target_waitstatus_to_string call.
7489
7490 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7491
7492         * eval.c (evaluate_subexp_standard): Handle internal functions
7493         during Fortran function call handling.
7494
7495 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * NEWS: Mention new internal functions.
7498         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7499         (read_base_type): Use dwarf2_init_complex_target_type.
7500         * value.c (creal_internal_fn): New function.
7501         (cimag_internal_fn): New function.
7502         (_initialize_values): Register new internal functions.
7503
7504 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7505
7506         * infrun.c (stop_all_threads): If debug_infrun, always
7507         trace the wait status after wait_one, using
7508         target_waitstatus_to_string and target_pid_to_str.
7509         (handle_inferior_event): Replace various trace of
7510         wait status kind by a single trace.
7511         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7512         wait status kind image by target_waitstatus_to_string.
7513         * target/waitstatus.c (target_waitstatus_to_string): Fix
7514         obsolete comment.
7515
7516 2019-04-01  Tom Tromey  <tromey@adacore.com>
7517
7518         PR symtab/23331:
7519         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7520
7521 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7522             Pedro Alves  <palves@redhat.com>
7523
7524         * top.c (quit_force): Call 'finalize_values'.
7525         * value.c (finalize_values): New function.
7526         * value.h (finalize_values): Declare.
7527
7528 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7529
7530         * NEWS: Announce $_gdb_major and $_gdb_minor.
7531
7532         * top.c (init_gdb_version_vars): New function.
7533         (gdb_init): Call init_gdb_version_vars.
7534
7535 2019-03-29  Tom Tromey  <tromey@adacore.com>
7536
7537         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7538         help text.  Remove dead code.
7539
7540 2019-03-29  Keith Seitz  <keiths@redhat.com>
7541
7542         From Siddhesh Poyarekar:
7543         * f-lang.h (f77_get_upperbound): Return LONGEST.
7544         (f77_get_lowerbound): Likewise.
7545         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7546         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7547         print them.
7548         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7549         plongest to format print it.
7550         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7551         (f77_get_upperbound): Likewise.
7552         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7553         LOWER_BOUND to LONGEST.
7554         (f77_create_arrayprint_offset_tbl): Likewise.
7555
7556 2019-03-29  Keith Seitz  <keiths@redhat.com>
7557
7558         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7559         %s/pulongest for TYPE_LENGTH instead of %d in format
7560         strings.
7561         * ada-typerint.c (ada_print_type): Likewise.
7562         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7563         * compile/compile-c-support.c (generate_register_struct): Likewise.
7564         * gdbtypes.c (recursive_dump_type): Likewise.
7565         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7566         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7567         instead of %d in format strings.
7568         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7569         to std::min to ULONGEST.
7570         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7571         instead of %d in format strings.
7572         * tracepoint.c (info_scope_command): Likewise.
7573         * typeprint.c (print_offset_data::update)
7574         (print_offset_data::finish): Likewise.
7575         * xtensa-tdep.c (xtensa_store_return_value)
7576         (xtensa_push_dummy_call): Likewise.
7577
7578 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7579
7580         * windows-nat.c (display_selector): Fixed format specifications
7581         for 64-bit Cygwin.
7582
7583 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7584
7585         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7586
7587 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7588
7589         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7590         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7591         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7592         (nios2_linux_init_abi): Install it.
7593
7594 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7595
7596         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7597
7598 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7599
7600         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7601
7602 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7603             Tom Tromey  <tromey@adacore.com>
7604
7605         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7606
7607 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7608
7609         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7610         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7611         method to compute the bounds of range types. Also print "[evaluated]"
7612         if the bounds' values come from a dynamic evaluation.
7613
7614 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7615
7616         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7617         whitespace when pretty printing is on.
7618
7619 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7620
7621         * ppc-linux-nat.c: Add include.
7622
7623 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7624
7625         * NEWS: Mention AArch64 Pointer Authentication.
7626
7627 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7628
7629         * arm-linux-nat.c: Add include.
7630
7631 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7632
7633         * source-cache.c (source_cache::get_source_lines): Re-read
7634         fullname after calling open_source_file.
7635
7636 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7637
7638         * NEWS: Mention TLS support for FreeBSD.
7639
7640 2019-03-25  Tom Tromey  <tromey@adacore.com>
7641
7642         * minsyms.c (BUNCH_SIZE): Update comment.
7643         (~minimal_symbol_reader): Remove old comment.
7644         (compact_minimal_symbols): Update comment.
7645         (minimal_symbol_reader::install): Remove old comment.  Update
7646         other comments.
7647
7648 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7649
7650         * s390-linux-nat.c: Add include.
7651
7652 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7653
7654         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7655         Call linux_get_hwcap.
7656         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7657         Likewise.
7658         (aarch64_linux_get_hwcap): Remove function.
7659         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7660         declaration.
7661         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7662         linux_get_hwcap.
7663         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7664         * linux-tdep.c (linux_get_hwcap): Add function.
7665         (linux_get_hwcap2): Likewise.
7666         * linux-tdep.h (linux_get_hwcap): Add declaration.
7667         (linux_get_hwcap2): Likewise.
7668         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7669         (ppc_linux_get_hwcap2): Likewise.
7670         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7671         linux_get_hwcap.
7672         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7673         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7674         (ppc_linux_nat_target::read_description): Likewise.
7675         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7676         * s390-linux-nat.c: Likewise.
7677         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7678
7679 2019-03-24  Tom Tromey  <tom@tromey.com>
7680
7681         * ada-lang.c (standard_lookup): Simplify initialization.
7682         (ada_lookup_symbol_nonlocal): Simplify return.
7683         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7684         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7685         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7686         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7687         initialization.
7688         * solib.c (solib_global_lookup): Simplify.
7689         * symtab.c (null_block_symbol): Remove.
7690         (symbol_cache_lookup): Simplify returns.
7691         (lookup_language_this): Simplify returns.
7692         (lookup_symbol_aux): Simplify return.
7693         (lookup_local_symbol): Simplify returns.
7694         (lookup_global_symbol_from_objfile): Simplify return.
7695         (lookup_symbol_in_objfile_symtabs)
7696         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7697         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7698         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7699         * cp-namespace.c (cp_lookup_bare_symbol)
7700         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7701         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7702         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7703         (cp_lookup_symbol_via_imports): Simplify initialization.
7704         (find_symbol_in_baseclass): Likewise.
7705         * symtab.h (null_block_symbol): Remove.
7706         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7707         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7708         (d_lookup_symbol_module): Likewise.
7709         (find_symbol_in_baseclass): Simplify initialization.
7710
7711 2019-03-24  Tom Tromey  <tom@tromey.com>
7712
7713         * expression.h: Don't include symtab.h.
7714         (struct block): Forward declare.
7715
7716 2019-03-24  Tom Tromey  <tom@tromey.com>
7717
7718         * c-exp.y (typebase): Remove casts.
7719         * gdbtypes.c (lookup_unsigned_typename, )
7720         (lookup_signed_typename): Remove cast.
7721         * eval.c (parse_to_comma_and_eval): Remove cast.
7722         * parse.c (write_dollar_variable): Remove cast.
7723         * block.h (struct block) <superblock>: Now const.
7724         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7725         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7726         (map_block): Make "block" const.
7727         * symfile.h (struct quick_symbol_functions)
7728         <map_matching_symbols>: Constify block argument to "callback".
7729         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7730         const.
7731         (find_pc_sect_compunit_symtab): Make "b" const.
7732         (find_symbol_at_address): Likewise.
7733         (search_symbols): Likewise.
7734         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7735         (dw2_debug_names_lookup_symbol): Likewise.
7736         (dw2_map_matching_symbols): Update.
7737         * p-valprint.c (pascal_val_print): Remove "block".
7738         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7739         (aux_add_nonlocal_symbols): Make "block" const.
7740         (resolve_subexp): Remove cast.
7741         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7742         const.
7743         (iterate_over_file_blocks): Likewise.
7744         * f-exp.y (%union) <bval>: Remove.
7745         * coffread.c (patch_opaque_types): Make "b" const.
7746         * spu-tdep.c (spu_catch_start): Make "block" const.
7747         * c-valprint.c (print_unpacked_pointer): Remove "block".
7748         * symmisc.c (dump_symtab_1): Make "b" const.
7749         (block_depth): Make "block" const.
7750         * d-exp.y (%union) <bval>: Remove.
7751         * cp-support.h (cp_lookup_rtti_type): Update.
7752         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7753         * psymtab.c (psym_lookup_symbol): Make "block" const.
7754         (maintenance_check_psymtabs): Make "b" const.
7755         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7756         (enumerate_locals, enumerate_args): Update.
7757         * python/py-symtab.c (stpy_global_block): Make "block" const.
7758         (stpy_static_block): Likewise.
7759         * inline-frame.c (block_starting_point_at): Make "new_block"
7760         const.
7761         * block.c (find_block_in_blockvector): Make return type const.
7762         (blockvector_for_pc_sect): Make "b" const.
7763         (find_block_in_blockvector): Make "b" const.
7764
7765 2019-03-23  Tom Tromey  <tom@tromey.com>
7766
7767         * varobj.c (varobj_create): Update.
7768         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7769         * printcmd.c (display_command, do_one_display): Don't reset
7770         innermost_block.
7771         * parser-defs.h (enum innermost_block_tracker_type): Move to
7772         expression.h.
7773         (innermost_block): Update comment.
7774         * parse.c (parse_exp_1): Add tracker_types parameter.
7775         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7776         tracker_types parameter.  Reset innermost_block.
7777         (parse_exp_in_context): Remove.
7778         (parse_expression_for_completion): Update.
7779         * objfiles.c (~objfile): Don't reset expression_context_block or
7780         innermost_block.
7781         * expression.h (enum innermost_block_tracker_type): Move from
7782         parser-defs.h.
7783         (parse_exp_1): Add tracker_types parameter.
7784         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7785         reset innermost_block.
7786
7787 2019-03-23  Tom Tromey  <tom@tromey.com>
7788
7789         * objfiles.h: Include bcache.h.
7790
7791 2019-03-23  Tom Tromey  <tom@tromey.com>
7792
7793         * linespec.c (get_current_search_block): Use
7794         scoped_restore_current_language.
7795         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7796
7797 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7798             Jiong Wang  <jiong.wang@arm.com>
7799
7800         * aarch64-linux-tdep.c
7801         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7802         section.
7803         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7804
7805 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7806             Jiong Wang  <jiong.wang@arm.com>
7807
7808         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7809         instructions.
7810         (aarch64_analyze_prologue_test): Add PACIASP test.
7811         (aarch64_prologue_prev_register): Unmask PC value.
7812
7813 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7814             Jiong Wang  <jiong.wang@arm.com>
7815
7816         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7817         (aarch64_dwarf2_prev_register): Unmask PC value.
7818         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7819         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7820         DW_CFA_AARCH64_negate_ra_state.
7821         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7822
7823 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7824             Jiong Wang  <jiong.wang@arm.com>
7825
7826         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7827         registers.
7828         (aarch64_pseudo_register_name): Likewise.
7829         (aarch64_pseudo_register_type): Likewise.
7830         (aarch64_pseudo_register_reggroup_p): Likewise.
7831         (aarch64_gdbarch_init): Add pauth registers.
7832         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
7833         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
7834         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
7835         (struct gdbarch_tdep): Add regnum for ra_state.
7836
7837 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7838             Jiong Wang  <jiong.wang@arm.com>
7839
7840         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
7841
7842 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7843             Jiong Wang  <jiong.wang@arm.com>
7844
7845         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
7846         function.
7847         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
7848         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
7849         (aarch64_gdbarch_init): Add puth registers.
7850         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
7851         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
7852         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
7853
7854 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7855             Jiong Wang  <jiong.wang@arm.com>
7856
7857         * aarch64-linux-nat.c
7858         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
7859         * aarch64-linux-tdep.c
7860         (aarch64_linux_core_read_description): Likewise.
7861         (aarch64_linux_get_hwcap): New function.
7862         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
7863         (aarch64_linux_get_hwcap): New declaration.
7864
7865 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7866             Jiong Wang  <jiong.wang@arm.com>
7867
7868         * aarch64-linux-nat.c
7869         (aarch64_linux_nat_target::read_description): Add pauth param.
7870         * aarch64-linux-tdep.c
7871         (aarch64_linux_core_read_description): Likewise.
7872         * aarch64-tdep.c (struct target_desc): Add in pauth.
7873         (aarch64_read_description): Add pauth param.
7874         (aarch64_gdbarch_init): Likewise.
7875         * aarch64-tdep.h (aarch64_read_description): Likewise.
7876         * arch/aarch64.c (aarch64_create_target_description): Likewise.
7877         * arch/aarch64.h (aarch64_create_target_description): Likewise.
7878         * features/Makefile: Add new files.
7879         * features/aarch64-pauth.c: New file.
7880         * features/aarch64-pauth.xml: New file.
7881
7882 2019-03-20  Tom Tromey  <tromey@adacore.com>
7883
7884         * infrun.c (handle_inferior_event): Rename from
7885         handle_inferior_event_1.  Create a scoped_value_mark.
7886         (handle_inferior_event): Remove.
7887
7888 2019-03-19  Tom Tromey  <tromey@adacore.com>
7889
7890         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7891         * infrun.h (print_stop_event): Add "displays" parameter.
7892         * infrun.c (print_stop_event): Add "displays" parameter.
7893
7894 2019-03-19  Pedro Alves  <palves@redhat.com>
7895
7896         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7897         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7898         to -1.  Fix TABs vs spaces.
7899         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7900         * tui/tui-out.h (tui_ui_out) Add intro comments.
7901         <m_line, m_start_of_line>: In-class initialize, and add describing
7902         comment.
7903
7904 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7905
7906         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7907         variable names.
7908         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7909
7910 2019-03-18  Pedro Alves  <palves@redhat.com>
7911             Eli Zaretskii <eliz@gnu.org>
7912
7913         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7914         m_line and m_start_of_line.
7915
7916 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7917
7918         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7919         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7920         it returns a newline.  This fixes a regression in TU mode, whereby
7921         the next line is output on the same screen line as the user input.
7922
7923 2019-03-18  Tom Tromey  <tromey@adacore.com>
7924
7925         * minsyms.c (minimal_symbol_reader::install): Remove call to
7926         obstack_blank.
7927
7928 2019-03-18  Pedro Alves  <palves@redhat.com>
7929
7930         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7931         New globals.
7932         (apply_style): New, factored out from ...
7933         (apply_ansi_escape): ... this.  Handle reverse video mode.
7934         (tui_set_reverse_mode): New function.
7935         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7936         * tui/tui-winsource.c (tui_show_source_line): Use
7937         tui_set_reverse_mode instead of setting A_STANDOUT.
7938         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7939         New setter methods.
7940
7941 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7942
7943         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7944         Handle tabs.
7945
7946 2019-03-18  Tom Tromey  <tromey@adacore.com>
7947
7948         * ada-lang.c (empty_array): Add "high" parameter.
7949         (ada_evaluate_subexp): Update.
7950
7951 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7952
7953         * unittests/string_view-selftests.c: Define
7954         _initialize_string_view_selftests unconditionally.
7955
7956 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7957
7958         PR gdb/24350
7959         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7960
7961 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7962
7963         PR gdb/24351
7964         * windows-nat.c (display_selector): Fix format specifiers.
7965
7966 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7967
7968         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7969         tui_refill_source_window instead of tui_refresh_win, to update the
7970         current execution line.  This fixes redisplay of the current line
7971         when stepping through the code with "next" or "step".
7972
7973 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7974
7975         * source-cache.c (source_cache::get_source_lines): Call
7976         find_source_lines to initialize s->nlines.  This fixes vertical
7977         scrolling of TUI source window when the DOWN arrow is pressed.
7978
7979 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7980
7981         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7982         linux-thread-db.c (_initialize_thread_db): Likewise.
7983
7984 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7985
7986         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7987         wclrtoeol in tui_show_source_line".  This reverts changes made in
7988         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7989
7990 2019-03-15  Tom Tromey  <tom@tromey.com>
7991
7992         * symtab.h (struct minimal_symbol): Derive from
7993         general_symbol_info.
7994         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7995         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7996         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7997         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7998         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7999         (MSYMBOL_SEARCH_NAME): Update.
8000         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8001         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8002         * minsyms.c (minimal_symbol_reader::record_full): Update.
8003
8004 2019-03-15  Tom Tromey  <tom@tromey.com>
8005
8006         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8007
8008 2019-03-15  Tom Tromey  <tom@tromey.com>
8009
8010         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8011         unique_xmalloc_ptr.
8012         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8013         Update.
8014         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8015         (build_minimal_symbol_hash_tables)
8016         (minimal_symbol_reader::install): Update.
8017
8018 2019-03-15  Tom Tromey  <tom@tromey.com>
8019
8020         * symtab.c (create_demangled_names_hash): Update.
8021         (symbol_set_names): Update.
8022         * objfiles.h (struct objfile_per_bfd_storage)
8023         <demangled_names_hash>: Now an htab_up.
8024         * objfiles.c (objfile_per_bfd_storage): Simplify.
8025
8026 2019-03-15  Tom Tromey  <tom@tromey.com>
8027
8028         * objfiles.h (struct objfile_per_bfd_storage): Declare
8029         destructor.
8030         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8031         New.
8032         (get_objfile_bfd_data): Use new.  Don't initialize
8033         language_of_main.
8034         (free_objfile_per_bfd_storage): Remove.
8035         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8036
8037 2019-03-15  Tom Tromey  <tom@tromey.com>
8038
8039         * symfile.c (reread_symbols): Update.
8040         * objfiles.c (objfile::objfile): Update.
8041         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8042         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8043         comment.
8044         (minimal_symbol_reader::install): Update.
8045         (terminate_minimal_symbol_table): Remove.
8046         * jit.c (jit_object_close_impl): Update.
8047
8048 2019-03-15  Tom Tromey  <tom@tromey.com>
8049
8050         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8051         initializations.
8052
8053 2019-03-15  Tom Tromey  <tom@tromey.com>
8054
8055         * objfiles.h (struct objfile_per_bfd_storage)
8056         <demangled_hash_languages>: Now a bitset.
8057         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8058         (lookup_minimal_symbol): Update.
8059
8060 2019-03-15  Tom Tromey  <tom@tromey.com>
8061
8062         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8063         Don't return the symbol.
8064         * coffread.c (record_minimal_symbol): Use record_full.
8065
8066 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8067
8068         The MS-Windows port of ncurses fails to switch to a color pair if
8069         one or both of the colors are the implicit default colors.  This
8070         change records the default colors when TUI is initialized, and
8071         then specifies them explicitly when a color pair uses the default
8072         colors.  This allows color styling in TUI mode on MS-Windows.
8073
8074         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8075         ncurses_norm_attr.
8076         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8077         colors in ncurses_norm_attr.
8078         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8079         "none", replace it with the default color recorded in
8080         ncurses_norm_attr.
8081
8082 2019-03-14  Tom Tromey  <tromey@adacore.com>
8083
8084         * source-cache.h (class source_cache) <get_source_lines>: Return
8085         std::string.
8086         * source-cache.c (source_cache::extract_lines): Handle case where
8087         first_pos==npos.  Return std::string.
8088         (source_cache::get_source_lines): Update.
8089
8090 2019-03-14  Tom Tromey  <tromey@adacore.com>
8091
8092         * NEWS: Add item for "style sources" commands.
8093         * source-cache.c (source_cache::get_source_lines): Check
8094         source_styling.
8095         * cli/cli-style.c (source_styling): New global.
8096         (_initialize_cli_style): Add "style sources" commands.
8097         (show_style_sources): New function.
8098         * cli/cli-style.h (source_styling): Declare.
8099
8100 2019-03-14  Pedro Alves  <palves@redhat.com>
8101             Tom Tromey  <tromey@adacore.com>
8102
8103         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8104         * tui/tui-winsource.c (tui_refill_source_window): New function,
8105         from...
8106         (tui_horizontal_source_scroll): ... here.  Move some logic.
8107         * cli/cli-style.c (set_style_enabled): Notify new observable.
8108         * tui/tui-hooks.c (tui_redisplay_source): New function.
8109         (tui_attach_detach_observers): Attach or detach
8110         tui_redisplay_source.
8111         * observable.h (source_styling_changed): New observable.
8112         * observable.c: Define source_styling_changed observable.
8113
8114 2019-03-13  Tom Tromey  <tromey@adacore.com>
8115
8116         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8117         (i386_gnu_nat_target::store_registers): Update.
8118         * target-debug.h (target_debug_print_std_string): New macro.
8119         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8120         * windows-tdep.c (display_one_tib): Update.
8121         * tui/tui-stack.c (tui_make_status_line): Update.
8122         * top.c (print_inferior_quit_action): Update.
8123         * thread.c (thr_try_catch_cmd): Update.
8124         (add_thread_with_info): Update.
8125         (thread_target_id_str): Update.
8126         (thr_try_catch_cmd): Update.
8127         (thread_command): Update.
8128         (thread_find_command): Update.
8129         * record-btrace.c (record_btrace_target::info_record)
8130         (record_btrace_resume_thread, record_btrace_target::resume)
8131         (record_btrace_cancel_resume, record_btrace_step_thread)
8132         (record_btrace_target::wait, record_btrace_target::wait)
8133         (record_btrace_target::wait, record_btrace_target::stop): Update.
8134         * progspace.c (print_program_space): Update.
8135         * process-stratum-target.c
8136         (process_stratum_target::thread_address_space): Update.
8137         * linux-fork.c (linux_fork_mourn_inferior)
8138         (detach_checkpoint_command, info_checkpoints_command)
8139         (linux_fork_context): Update.
8140         (linux_fork_detach): Update.
8141         (class scoped_switch_fork_info): Update.
8142         (delete_checkpoint_command): Update.
8143         * infrun.c (follow_fork_inferior): Update.
8144         (follow_fork_inferior): Update.
8145         (proceed_after_vfork_done): Update.
8146         (handle_vfork_child_exec_or_exit): Update.
8147         (follow_exec): Update.
8148         (displaced_step_prepare_throw): Update.
8149         (displaced_step_restore): Update.
8150         (start_step_over): Update.
8151         (resume_1): Update.
8152         (clear_proceed_status_thread): Update.
8153         (proceed): Update.
8154         (print_target_wait_results): Update.
8155         (do_target_wait): Update.
8156         (context_switch): Update.
8157         (stop_all_threads): Update.
8158         (restart_threads): Update.
8159         (finish_step_over): Update.
8160         (handle_signal_stop): Update.
8161         (switch_back_to_stepped_thread): Update.
8162         (keep_going_pass_signal): Update.
8163         (print_exited_reason): Update.
8164         (normal_stop): Update.
8165         * inferior.c (inferior_pid_to_str): Change return type.
8166         (print_selected_inferior): Update.
8167         (add_inferior): Update.
8168         (detach_inferior): Update.
8169         * dummy-frame.c (fprint_dummy_frames): Update.
8170         * dcache.c (dcache_info_1): Update.
8171         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8172         (btrace_fetch, btrace_clear): Update.
8173         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8174         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8175         type.
8176         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8177         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8178         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8179         * gdbarch.c, gdbarch.h: Rebuild.
8180         * gdbarch.sh (core_pid_to_str): Change return type.
8181         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8182         return type.
8183         (windows_nat_target::pid_to_str): Change return type.
8184         (windows_delete_thread): Update.
8185         (windows_nat_target::attach): Update.
8186         (windows_nat_target::files_info): Update.
8187         * target-delegates.c: Rebuild.
8188         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8189         return type.
8190         (sol_thread_target::pid_to_str): Change return type.
8191         * remote.c (class remote_target) <pid_to_str>: Change return
8192         type.
8193         (remote_target::pid_to_str): Change return type.
8194         (extended_remote_target::attach, remote_target::remote_stop_ns)
8195         (remote_target::remote_notif_remove_queued_reply)
8196         (remote_target::push_stop_reply, remote_target::disable_btrace):
8197         Update.
8198         (extended_remote_target::attach): Update.
8199         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8200         type.
8201         (gdbsim_target::pid_to_str): Change return type.
8202         * ravenscar-thread.c (struct ravenscar_thread_target)
8203         <pid_to_str>: Change return type.
8204         (ravenscar_thread_target::pid_to_str): Change return type.
8205         * procfs.c (class procfs_target) <pid_to_str>: Change return
8206         type.
8207         (procfs_target::pid_to_str): Change return type.
8208         (procfs_target::attach): Update.
8209         (procfs_target::detach): Update.
8210         (procfs_target::fetch_registers): Update.
8211         (procfs_target::store_registers): Update.
8212         (procfs_target::wait): Update.
8213         (procfs_target::files_info): Update.
8214         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8215         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8216         return type.
8217         (nto_procfs_target::pid_to_str): Change return type.
8218         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8219         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8220         return type.
8221         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8222         (exit_lwp): Update.
8223         (attach_proc_task_lwp_callback, get_detach_signal)
8224         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8225         (linux_nat_target::resume, wait_lwp, stop_callback)
8226         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8227         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8228         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8229         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8230         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8231         type.
8232         (inf_ptrace_target::attach): Update.
8233         (inf_ptrace_target::files_info): Update.
8234         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8235         type.
8236         (go32_nat_target::pid_to_str): Change return type.
8237         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8238         (gnu_nat_target::wait): Update.
8239         (gnu_nat_target::wait): Update.
8240         (gnu_nat_target::resume): Update.
8241         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8242         (fbsd_nat_target::wait): Update.
8243         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8244         type.
8245         (darwin_nat_target::attach): Update.
8246         * corelow.c (class core_target) <pid_to_str>: Change return type.
8247         (core_target::pid_to_str): Change return type.
8248         * target.c (normal_pid_to_str): Change return type.
8249         (default_pid_to_str): Likewise.
8250         (target_pid_to_str): Change return type.
8251         (target_translate_tls_address): Update.
8252         (target_announce_detach): Update.
8253         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8254         return type.
8255         (bsd_uthread_target::pid_to_str): Change return type.
8256         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8257         type.
8258         (bsd_kvm_target::pid_to_str): Change return type.
8259         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8260         return type.
8261         (aix_thread_target::pid_to_str): Change return type.
8262         * target.h (struct target_ops) <pid_to_str>: Change return type.
8263         (target_pid_to_str, normal_pid_to_str): Likewise.
8264         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8265         type.
8266         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8267         type.
8268         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8269         return type.
8270         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8271         type.
8272         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8273         type.
8274         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8275         return type.
8276
8277 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8278
8279         * NEWS: Mention that the new default MI version is 3.  Mention
8280         changes to the output of commands and events that deal with
8281         multi-location breakpoints.
8282         * breakpoint.c: Include "mi/mi-out.h".
8283         (print_one_breakpoint): Change output syntax if using MI version
8284         >= 3.
8285         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8286         New.
8287         (mi_multi_location_breakpoint_output_fixed): New.
8288         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8289         (mi_cmd_fix_multi_location_breakpoint_output): New.
8290         (mi_multi_location_breakpoint_output_fixed): New.
8291         * mi/mi-cmds.c (mi_cmds): Register command
8292         -fix-multi-location-breakpoint-output.
8293         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8294         interpreter "mi".
8295
8296 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8297
8298         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8299         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8300         instantiate mi_ui_out based on interpreter name.
8301         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8302         * mi/mi-main.c (mi_load_progress): Likewise.
8303
8304 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8305
8306         * NEWS: Combine separate "New targets" sections for 8.3.
8307
8308 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8309
8310         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8311         (ppcfbsd_init_abi): Install gdbarch
8312         "fetch_tls_load_module_address" and "get_thread_local_address"
8313         methods.
8314
8315 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8316
8317         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8318         (riscv_fbsd_init_abi): Install gdbarch
8319         "fetch_tls_load_module_address" and "get_thread_local_address"
8320         methods.
8321
8322 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8323
8324         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8325         (i386fbsd_init_abi): Install gdbarch
8326         "fetch_tls_load_module_address" and "get_thread_local_address"
8327         methods.
8328
8329 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8330
8331         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8332         (amd64fbsd_init_abi): Install gdbarch
8333         "fetch_tls_load_module_address" and "get_thread_local_address"
8334         methods.
8335
8336 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8337
8338         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8339         (struct fbsd_pspace_data): New type.
8340         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8341         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8342         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8343         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8344         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8345
8346 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8347
8348         * gdbtypes.c (lookup_struct_elt): New function.
8349         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8350         * gdbtypes.h (struct struct_elt): New type.
8351         (lookup_struct_elt): New prototype.
8352
8353 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8354
8355         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8356         remove disabled code block.
8357
8358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8359
8360         * gdbarch.sh (get_thread_local_address): New method.
8361         * gdbarch.h, gdbarch.c: Regenerate.
8362         * target.c (target_translate_tls_address): Use
8363         gdbarch_get_thread_local_address if present instead of
8364         target::get_thread_local_address.
8365
8366 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8367
8368         * target.h (target::get_thread_local_address): Update comment.
8369
8370 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8371
8372         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8373         objfile->separate_debug_objfile_backlink if not NULL.
8374
8375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8376
8377         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8378         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8379         (amd64bsd_store_inferior_registers): Likewise.
8380         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8381         Enable segment base registers.
8382         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8383         PT_GETFSBASE and PT_GETGSBASE.
8384         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8385         PT_SETGSBASE.
8386         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8387         segment base registers.
8388         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8389
8390 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8391
8392         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8393         Update calls to i386_target_description to add 'segments'
8394         parameter.
8395         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8396         add segment base registers.
8397         * arch/i386.c (i386_create_target_description): Add 'segments'
8398         parameter to enable segment base registers.
8399         * arch/i386.h (i386_create_target_description): Likewise.
8400         * features/i386/32bit-segments.xml: New file.
8401         * features/i386/32bit-segments.c: Generate.
8402         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8403         call to i386_target_description to add 'segments' parameter.
8404         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8405         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8406         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8407         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8408         if feature is present.
8409         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8410         Add 'segments' parameter to call to i386_target_description.
8411         (i386_target_description): Add 'segments' parameter to enable
8412         segment base registers.
8413         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8414         to call to i386_target_description.
8415         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8416         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8417         Define I386_NUM_REGS.
8418         (i386_target_description): Add 'segments' parameter to enable
8419         segment base registers.
8420
8421 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8422
8423         PR/24325
8424         * source-cache.c: #undef open and close, to avoid unresolved
8425         externals during linking.
8426
8427 2019-03-12  Tom Tromey  <tromey@adacore.com>
8428
8429         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8430         const.  Add initializers.
8431         (_initialize_remote): Don't initialize ptid globals.
8432
8433 2019-03-12  Pedro Alves  <palves@redhat.com>
8434
8435         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8436
8437 2019-03-12  Pedro Alves  <palves@redhat.com>
8438
8439         * cp-name-parser.y (main): Remove unused 'len' variable.
8440
8441 2019-03-12  Tom Tromey  <tromey@adacore.com>
8442
8443         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8444         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8445
8446 2019-03-12  Tom Tromey  <tromey@adacore.com>
8447
8448         * linux-nat.c (iterate_over_lwps): Update.
8449         (stop_callback): Remove parameter.
8450         (stop_wait_callback, detach_callback, resume_set_callback)
8451         (select_singlestep_lwp_callback, set_ignore_sigint)
8452         (status_callback, resumed_callback, resume_clear_callback)
8453         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8454         data parameter.
8455         (linux_nat_target::detach, linux_nat_target::resume)
8456         (linux_stop_and_wait_all_lwps, select_event_lwp)
8457         (linux_nat_filter_event, linux_nat_wait_1)
8458         (linux_nat_target::kill, linux_nat_target::stop)
8459         (linux_nat_target::stop): Update.
8460         (linux_nat_resume_callback): Change type.
8461         (resume_stopped_resumed_lwps, count_events_callback)
8462         (select_event_lwp_callback): Likewise.
8463         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8464         * arm-linux-nat.c (struct update_registers_data): Remove.
8465         (update_registers_callback): Change type.
8466         (arm_linux_insert_hw_breakpoint1): Update.
8467         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8468         parameter.
8469         (x86_linux_dr_set_addr): Update.
8470         (x86_linux_dr_set_control): Update.
8471         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8472         (iterate_over_lwps): Use gdb::function_view.
8473         * nat/aarch64-linux-hw-point.c (struct
8474         aarch64_dr_update_callback_param): Remove.
8475         (debug_reg_change_callback): Change type.
8476         (aarch64_notify_debug_reg_change): Update.
8477         * s390-linux-nat.c (s390_refresh_per_info): Update.
8478
8479 2019-03-11  Tom Tromey  <tromey@adacore.com>
8480
8481         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8482         redundant assignment to "this_cu".
8483
8484 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8485
8486         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8487
8488 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8489
8490         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8491         from...
8492         (rank_one_type): ... this.
8493
8494 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8495
8496         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8497         from...
8498         (rank_one_type): ... this.
8499
8500 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8501
8502         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8503         from...
8504         (rank_one_type): ... this.
8505
8506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8507
8508         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8509         from...
8510         (rank_one_type): ... this.
8511
8512 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8513
8514         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8515         from...
8516         (rank_one_type): ... this.
8517
8518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8519
8520         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8521         from...
8522         (rank_one_type): ... this.
8523
8524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8525
8526         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8527         from...
8528         (rank_one_type): ... this.
8529
8530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8531
8532         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8533         from...
8534         (rank_one_type): ... this.
8535
8536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8537
8538         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8539         from...
8540         (rank_one_type): ... this.
8541
8542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8543
8544         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8545         from...
8546         (rank_one_type): ... this.
8547
8548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8549
8550         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8551         from...
8552         (rank_one_type): ... this.
8553
8554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8555
8556         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8557         from...
8558         (rank_one_type): ... this.
8559
8560 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8561
8562         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8563         inferior-events' shows the example events.
8564
8565 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8566
8567         Support styling on native MS-Windows console
8568
8569         PR/24315
8570         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8571         on MS-Windows if $TERM is not defined.
8572
8573         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8574
8575         * posix-hdep.c (gdb_console_fputs):
8576         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8577         functions.
8578         * ui-file.h (gdb_console_fputs): Add prototype.
8579
8580         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8581         back to fputs only if the former returns zero.
8582
8583 2019-03-07  Tom Tromey  <tom@tromey.com>
8584
8585         * symmisc.c (print_symbol_bcache_statistics): Update.
8586         (print_objfile_statistics): Update.
8587         * symfile.c (allocate_symtab): Update.
8588         * stabsread.c: Don't include bcache.h.
8589         * psymtab.h (struct psymbol_bcache): Don't declare.
8590         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8591         (psymbol_bcache_init, psymbol_bcache_free)
8592         (psymbol_bcache_get_bcache): Don't declare.
8593         * psymtab.c (struct psymbol_bcache): Remove.
8594         (psymtab_storage::psymtab_storage): Update.
8595         (psymtab_storage::~psymtab_storage): Update.
8596         (psymbol_bcache_init, psymbol_bcache_free)
8597         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8598         (add_psymbol_to_bcache): Update.
8599         (allocate_psymtab): Update.
8600         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8601         macro_cache>: No longer pointers.
8602         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8603         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8604         * macrotab.c (macro_bcache): Update.
8605         * macroexp.c: Don't include bcache.h.
8606         * gdbtypes.c (check_types_worklist): Update.
8607         (types_deeply_equal): Remove TRY/CATCH.  Update.
8608         * elfread.c (elf_symtab_read): Update.
8609         * dwarf2read.c: Don't include bcache.h.
8610         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8611         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8612         (print_bcache_statistics, bcache_memory_used): Don't declare.
8613         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8614         methods.  Rename all data members.
8615         * bcache.c (struct bcache): Move to bcache.h.
8616         (bcache::expand_hash_table): Rename from expand_hash_table.
8617         (bcache): Remove.
8618         (bcache::insert): Rename from bcache_full.
8619         (bcache::compare): Rename from bcache_compare.
8620         (bcache_xmalloc): Remove.
8621         (bcache::~bcache): Rename from bcache_xfree.
8622         (bcache::print_statistics): Rename from print_bcache_statistics.
8623         (bcache::memory_used): Rename from bcache_memory_used.
8624
8625 2019-03-07  Pedro Alves  <palves@redhat.com>
8626
8627         * infrun.c (normal_stop): Also check for
8628         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8629
8630 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8631
8632         * f-lang.c (value_from_host_double): Moved to...
8633         * value.c (value_from_host_double): ...here.
8634         * value.h (value_from_host_double): Declare.
8635         * guile/scm-math.c (vlscm_convert_typed_number): Use
8636         value_from_host_double.
8637         (vlscm_convert_number): Likewise.
8638         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8639         * python/py-value.c (convert_value_from_python): Likewise.
8640
8641 2019-03-06  Tom Tromey  <tom@tromey.com>
8642
8643         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8644
8645 2019-03-06  Tom Tromey  <tom@tromey.com>
8646
8647         * utils.h (free_current_contents): Don't declare.
8648         * utils.c (free_current_contents): Remove.
8649
8650 2019-03-06  Tom Tromey  <tom@tromey.com>
8651
8652         * top.c (quit_force): Update.
8653         * main.c (captured_command_loop): Update.
8654         * common/new-op.c (operator new): Update.
8655         * common/common-exceptions.c (struct catcher)
8656         <save_cleanup_chain>: Remove member.
8657         (exceptions_state_mc_init): Update.
8658         (exception_try_scope_entry): Return nullptr.
8659         (exception_try_scope_exit, exception_rethrow)
8660         (throw_exception_sjlj, throw_exception_cxx): Update.
8661         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8662         (all_cleanups, do_cleanups, discard_cleanups)
8663         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8664         (restore_cleanups, restore_final_cleanups): Don't declare.
8665         (do_final_cleanups): Remove parameter.
8666         * common/cleanups.c (cleanup_chain, make_cleanup)
8667         (make_cleanup_dtor, all_cleanups, do_cleanups)
8668         (discard_my_cleanups, discard_cleanups)
8669         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8670         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8671         (null_cleanup): Remove.
8672         (do_final_cleanups): Remove parameter.
8673
8674 2019-03-06  Tom Tromey  <tom@tromey.com>
8675
8676         * remote.c (remote_target::remote_parse_stop_reply): Use
8677         unique_xmalloc_ptr.
8678
8679 2019-03-06  Tom Tromey  <tom@tromey.com>
8680
8681         * stabsread.c (struct stabs_field_info): Rename from field_info.
8682         <list, fnlist>: Add initializers.
8683         <obstack>: New member.
8684         (read_member_functions, read_struct_fields, read_baseclasses):
8685         Allocate on obstack.  Don't use cleanups.
8686         (read_one_struct_field, read_member_functions, read_struct_fields)
8687         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8688         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8689         (read_struct_type): Update.
8690
8691 2019-03-06  Tom Tromey  <tom@tromey.com>
8692
8693         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8694         * common/filestuff.h (make_cleanup_close): Don't declare.
8695         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8696         Remove.
8697
8698 2019-03-06  Tom Tromey  <tom@tromey.com>
8699
8700         * solib-aix.c: Use make_scope_exit.
8701
8702 2019-03-06  Tom Tromey  <tom@tromey.com>
8703
8704         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8705         Use make_scope_exit.
8706
8707 2019-03-06  Tom Tromey  <tom@tromey.com>
8708
8709         * solib-svr4.c (disable_probes_interface): Remove parameter.
8710         (svr4_handle_solib_event): Use make_scope_exit.
8711
8712 2019-03-06  Tom Tromey  <tom@tromey.com>
8713
8714         * remote.c (struct stop_reply_deleter): Remove.
8715         (stop_reply_up): Update.
8716         (struct stop_reply): Derive from notif_event.  Don't typedef.
8717         <regcache>: Now a std::vector.
8718         (stop_reply_xfree): Remove.
8719         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8720         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8721         (remote_target::discard_pending_stop_replies): Use delete.
8722         (remote_target::remote_parse_stop_reply): Update.
8723         (remote_target::process_stop_reply): Update.
8724         * remote-notif.h (struct notif_event): Add virtual destructor.
8725         Remove "dtr" member.
8726         (struct notif_client) <alloc_event>: Return a unique_ptr.
8727         (notif_event_xfree): Don't declare.
8728         (notif_event_up): New typedef.
8729         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8730         (notif_event_xfree, do_notif_event_xfree): Remove.
8731         (remote_notif_state_xfree): Update.
8732
8733 2019-03-06  Tom Tromey  <tom@tromey.com>
8734
8735         * infrun.c (displaced_step_clear_cleanup): Now a
8736         forward_scope_exit type.
8737         (displaced_step_prepare_throw): Update.
8738         (displaced_step_fixup): Update.
8739
8740 2019-03-06  Tom Tromey  <tom@tromey.com>
8741
8742         * inferior.h (class inferior): Update comment.
8743         * gdbthread.h (class thread_info): Update comment.
8744
8745 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8746             Tom Tromey  <tom@tromey.com>
8747
8748         * stabsread.h (struct stab_section_list): Remove.
8749         (coffstab_build_psymtabs): Update.
8750         * dbxread.c (symbuf_sections): Now a std::vector.
8751         (sect_idx): New global.
8752         (fill_symbuf): Update.
8753         (coffstab_build_psymtabs): Change type of stabsects parameter.
8754         Update.
8755         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8756         std::vector.
8757         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8758         (coff_locate_sections): Update.
8759         (coff_symfile_read): Remove cleanups.  Update.
8760         (init_stringtab): Add storage parameter.
8761         (free_stringtab, free_stringtab_cleanup): Remove.
8762         (init_lineno): Add storage parameter.
8763         (free_linetab, free_linetab_cleanup): Remove.
8764
8765 2019-03-06  Pedro Alves  <palves@redhat.com>
8766
8767         * linux-fork.c (fork_info::clobber_regs): Delete.
8768         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8769         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8770         comment.  Adjust.
8771         (scoped_switch_fork_info::scoped_switch_fork_info)
8772         (checkpoint_command, linux_fork_context): Adjust
8773         fork_save_infrun_state calls.
8774
8775 2019-03-06  Pedro Alves  <palves@redhat.com>
8776
8777         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8778         (inf_has_multiple_threads): Return 'bool' and rewrite using
8779         inferior_info::threads().
8780
8781 2019-03-06  Pedro Alves  <palves@redhat.com>
8782
8783         * linux-fork.c: Include <list>.
8784         (fork_list): Now a std::list instance.
8785         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8786         (forks_exist_p, find_last_fork): Adjust.
8787         (new_fork): Delete.
8788         (one_fork_p): New.
8789         (add_fork): Adjust.
8790         (free_fork): Delete, folded into fork_info::~fork_info().
8791         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8792         Adjust.
8793         (init_fork_list): Delete.
8794         (linux_fork_killall, linux_fork_mourn_inferior)
8795         (linux_fork_detach, info_checkpoints_command): Adjust.
8796         (_initialize_linux_fork): No longer call init_fork_list.
8797
8798 2019-03-06  Pedro Alves  <palves@redhat.com>
8799
8800         * linux-fork.c (new_fork): New, split out of ...
8801         (add_fork): ... this.  Return void.  Move "first fork" special
8802         case from here, to ...
8803         (checkpoint_command): ... here.
8804         * linux-linux.h (add_fork): Return void.
8805
8806 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8807
8808         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8809
8810 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8811             Chris January  <chris.january@arm.com>
8812             David Lecomber  <david.lecomber@arm.com>
8813
8814         * f-exp.y: New token, UNOP_INTRINSIC.
8815         (exp): New pattern using UNOP_INTRINSIC token.
8816         (f77_keywords): Add 'abs' keyword.
8817         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8818         (value_from_host_double): New function.
8819         (evaluate_subexp_f): Support UNOP_ABS.
8820
8821 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8822
8823         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8824         types.
8825
8826 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8827
8828         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
8829         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
8830         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
8831
8832 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * f-exp.y (convert_to_kind_type): Handle more type kinds.
8835
8836 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8837             Chris January  <chris.january@arm.com>
8838
8839         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
8840         * f-exp.y: Define 'KIND' token.
8841         (exp): New pattern for KIND expressions.
8842         (ptype): Handle types with a kind extension.
8843         (direct_abs_decl): Extend to spot kind extensions.
8844         (f77_keywords): Add 'kind' to the list.
8845         (push_kind_type): New function.
8846         (convert_to_kind_type): New function.
8847         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
8848         * parse.c (operator_length_standard): Likewise.
8849         * parser-defs.h (enum type_pieces): Add tp_kind.
8850         * std-operator.def: Add UNOP_KIND.
8851
8852 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8853
8854         * f-exp.y (f_parse): Set yydebug.
8855
8856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8857
8858         * f-lang.c (evaluate_subexp_f): New function.
8859         (exp_descriptor_f): New global.
8860         (f_language_defn): Use exp_descriptor_f instead of
8861         exp_descriptor_standard.
8862
8863 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8864
8865         * f-exp.y (struct token): Add comments.
8866         (dot_ops): Remove uppercase versions and the end marker.
8867         (f77_keywords): Likewise.
8868         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
8869         entries in the dot_ops array are case insensitive, and use
8870         strncasecmp to compare strings.  Also some whitespace cleanup in
8871         this area.  Similar for the f77_keywords array, except entries in
8872         this list might be case sensitive.
8873
8874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8875
8876         * f-exp.y (struct f77_boolean_val): Add comments.
8877         (boolean_values): Remove uppercase versions, and end marker.
8878         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
8879         and use strncasecmp to achieve case insensitivity.  Additionally,
8880         perform whitespace cleanup around this code.
8881
8882 2019-03-06  Tom Tromey  <tromey@adacore.com>
8883
8884         * remote-sim.c (gdbsim_target_open): Use result of
8885         gdb_argv::release.
8886
8887 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8888         Dirk Schubert  <dirk.schubert@arm.com>
8889         Chris January  <chris.january@arm.com>
8890
8891         * eval.c (evaluate_subexp_standard): Call Fortran argument
8892         wrapping logic.
8893         * f-lang.c (struct value): A value which can be passed into a
8894         Fortran function call.
8895         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8896         where appropriate.
8897         (struct type): Value ready for a Fortran function call.
8898         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8899         is needed.
8900         * f-lang.h (fortran_argument_convert): Declaration.
8901         (fortran_preserve_arg_pointer): Declaration.
8902         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8903
8904 2019-03-05  Tom Tromey  <tromey@adacore.com>
8905
8906         * python/py-prettyprint.c (print_string_repr): Remove #if.
8907         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8908
8909 2019-03-05  Tom Tromey  <tromey@adacore.com>
8910
8911         * target.c (the_dummy_target): Move later.  Change type to
8912         "dummy_target".
8913         (initialize_targets): Don't initialize the_dummy_target.
8914
8915 2019-03-05  Tom Tromey  <tromey@adacore.com>
8916
8917         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8918         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8919
8920 2019-03-05  Tom Tromey  <tromey@adacore.com>
8921
8922         * windows-nat.c (windows_nat_target::attach)
8923         (windows_nat_target::detach): Don't call gdb_flush.
8924         * valprint.c (generic_val_print, val_print, val_print_string):
8925         Don't call gdb_flush.
8926         * utils.c (defaulted_query): Don't call gdb_flush.
8927         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8928         * target.c (target_announce_detach): Don't call gdb_flush.
8929         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8930         * remote.c (extended_remote_target::attach): Don't call
8931         gdb_flush.
8932         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8933         * printcmd.c (do_examine): Don't call gdb_flush.
8934         (info_display_command): Don't call gdb_flush.
8935         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8936         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8937         * memattr.c (info_mem_command): Don't call gdb_flush.
8938         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8939         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8940         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8941         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8942         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8943         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8944         (gnu_nat_target::detach): Don't call gdb_flush.
8945         * f-valprint.c (f_val_print): Don't call gdb_flush.
8946         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8947         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8948         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8949         gdb_flush.
8950         * c-valprint.c (c_val_print): Don't call gdb_flush.
8951         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8952
8953 2019-03-05  Tom Tromey  <tromey@adacore.com>
8954
8955         * varobj.c (update_dynamic_varobj_children): Update.
8956         (install_default_visualizer): Use reset, not release.
8957         * value.c (set_internalvar): Update.
8958         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8959         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8960         ATTRIBUTE_UNUSED_RESULT.
8961
8962 2019-03-05  Tom Tromey  <tromey@adacore.com>
8963
8964         * remote.c (class scoped_remote_fd) <release>: Add
8965         ATTRIBUTE_UNUSED_RESULT.
8966
8967 2019-03-05  Tom Tromey  <tromey@adacore.com>
8968
8969         * macroexp.c (struct macro_buffer) <release>: Add
8970         ATTRIBUTE_UNUSED_RESULT.
8971
8972 2019-03-05  Tom Tromey  <tromey@adacore.com>
8973
8974         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8975         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8976         ATTRIBUTE_UNUSED_RESULT.
8977
8978 2019-03-05  Tom Tromey  <tromey@adacore.com>
8979
8980         * common/scoped_fd.h (class scoped_fd) <release>: Add
8981         ATTRIBUTE_UNUSED_RESULT.
8982
8983 2019-03-05  Tom Tromey  <tromey@adacore.com>
8984
8985         * parser-defs.h (struct parser_state) <release>: Add
8986         ATTRIBUTE_UNUSED_RESULT.
8987
8988 2019-03-05  Tom Tromey  <tromey@adacore.com>
8989
8990         * utils.h (class gdb_argv) <release>: Add
8991         ATTRIBUTE_UNUSED_RESULT.
8992         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8993
8994 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8995
8996         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8997         for-loop range, to avoid compiler warnings.
8998
8999         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9000         avoid compiler warnings about unused variables.
9001
9002         * NEWS: Mention end of support for native debugging on MS-Windows
9003         before XP.
9004
9005         PR gdb/24292
9006         * common/netstuff.c:
9007         * gdbserver/gdbreplay.c
9008         * gdbserver/remote-utils.c:
9009         * ser-tcp.c:
9010         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9011         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9012         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9013         'getaddrinfo' and 'freeaddrinfo' were not available before
9014         Windows XP, and mingw.org's MinGW headers by default define
9015         _WIN32_WINNT to 0x500.
9016
9017 2019-03-01  Gary Benson <gbenson@redhat.com>
9018
9019         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9020
9021 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9022             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9023
9024         PR gdb/8527
9025         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9026         set_sigint_trap, clear_sigint_trap.
9027
9028 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9029
9030         * target.c (target_detach): Clear the regcache and the
9031         frame cache.
9032
9033 2019-02-27  Pedro Alves  <palves@redhat.com>
9034
9035         * utils.c (set_screen_size): When we cap the height/width sizes,
9036         tweak the corresponding command variable to show "unlimited":
9037
9038 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9039             Pedro Alves  <palves@redhat.com>
9040
9041         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9042         before calling rl_set_screen_size.
9043
9044 2019-02-27  Tom Tromey  <tromey@adacore.com>
9045
9046         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9047         define.
9048         * python/py-value.c: Remove Python 2.4 workaround.
9049         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9050         workaround.
9051         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9052         Python 2.4 workaround.
9053         * python/python-internal.h: Remove Python 2.4 comment.
9054         (Py_ssize_t): Don't define.
9055         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9056         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9057         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9058         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9059         * python/python.c (do_start_initialization): Remove Python 2.4
9060         workaround.
9061         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9062         (print_children): Remove Python 2.4 workaround.
9063         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9064         workaround.
9065         (CHARBUFFERPROC_NAME): Remove.
9066         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9067         Python 2.4 workaround.
9068
9069 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9070
9071         * NEWS: Note minimum Python version.
9072
9073 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9074
9075         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9076         code from these functions.  Remove corresponding ifdefs.  Use
9077         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9078         Remove gotos and target of gotos.
9079         (infpy_search_memory): Likewise.
9080
9081 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9082
9083         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9084         (hppa_gdbarch_init): Don't register deleted functions with
9085         gdbarch.
9086
9087 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9088
9089         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9090         (h8300_unwind_sp): Delete.
9091         (h8300_dummy_id): Delete.
9092         (h8300_gdbarch_init): Don't register deleted functions with
9093         gdbarch.
9094
9095 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9096
9097         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9098         (ft32_unwind_pc): Delete.
9099         (ft32_unwind_sp): Delete.
9100         (ft32_gdbarch_init): Don't register deleted functions with
9101         gdbarch.
9102
9103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9104
9105         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9106         (frv_unwind_pc): Delete.
9107         (frv_unwind_sp): Delete.
9108         (frv_gdbarch_init): Don't register deleted functions with
9109         gdbarch.
9110
9111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9112
9113         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9114         (riscv_unwind_pc): Delete.
9115         (riscv_unwind_sp): Delete.
9116         (riscv_gdbarch_init): Don't register deleted functions with
9117         gdbarch.
9118
9119 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9120
9121         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9122         (csky_unwind_pc): Delete.
9123         (csky_unwind_sp): Delete.
9124         (csky_gdbarch_init): Don't register deleted functions with
9125         gdbarch.
9126
9127 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9128
9129         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9130         (cris_unwind_pc): Delete.
9131         (cris_unwind_sp): Delete.
9132         (cris_gdbarch_init): Don't register deleted functions with
9133         gdbarch.
9134
9135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9136
9137         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9138         (bfin_unwind_pc): Delete.
9139         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9140
9141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9142
9143         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9144         (arm_unwind_pc): Delete.
9145         (arm_unwind_sp): Delete.
9146         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9147
9148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9149
9150         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9151         (arc_unwind_pc): Delete.
9152         (arc_unwind_sp): Delete.
9153         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9154
9155 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9156
9157         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9158         (alpha_unwind_pc): Delete.
9159         (alpha_gdbarch_init): Don't register deleted functions with
9160         gdbarch.
9161
9162 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9163
9164         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9165         (aarch64_unwind_pc): Delete.
9166         (aarch64_unwind_sp): Delete.
9167         (aarch64_gdbarch_init): Don't register deleted functions with
9168         gdbarch.
9169
9170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9171
9172         * gdbtypes.c (type_align): Don't consider static members when
9173         computing structure alignment.
9174
9175 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9176
9177         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9178         return 0 for other types.
9179         * arch-utils.c (default_type_align): Always return 0.
9180         * gdbarch.h: Regenerate.
9181         * gdbarch.sh (type_align): Extend comment.
9182         * gdbtypes.c (type_align): Add additional comments, always call
9183         gdbarch_type_align before applying the default rules.
9184         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9185         generic code will then apply a suitable default.
9186         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9187         types, return 0 for other types.
9188
9189 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9190
9191         * NEWS: Create a new section for the next release branch.
9192         Rename the section of the current branch, now that it has
9193         been cut.
9194
9195 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9196
9197         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9198         * version.in: Bump version to 8.3.50.DATE-git.
9199
9200 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9201
9202         * aix-thread.c (ptid_cmp): Remove unused variable.
9203         (get_signaled_thread): Likewise.
9204         (store_regs_user_thread): Likewise.
9205         (store_regs_kernel_thread): Likewise.
9206         (fetch_regs_kernel_thread): Remove shadowed variable.
9207
9208 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9209
9210         * features/riscv/32bit-cpu.xml: Add register numbers.
9211         * features/riscv/32bit-fpu.c: Regenerate.
9212         * features/riscv/32bit-fpu.xml: Add register numbers.
9213         * features/riscv/64bit-cpu.xml: Add register numbers.
9214         * features/riscv/64bit-fpu.c: Regenerate.
9215         * features/riscv/64bit-fpu.xml: Add register numbers.
9216
9217 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9218
9219         * NEWS: Mention two argument form of gdb.Value constructor.
9220         * python/py-value.c (convert_buffer_and_type_to_value): New
9221         function.
9222         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9223         Add support for handling an optional second argument.  Call
9224         convert_buffer_and_type_to_value as appropriate.
9225         * python/python-internal.h (Py_buffer_deleter): New struct.
9226         (Py_buffer_up): New typedef.
9227
9228 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9229
9230         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9231         instead of releasing ownership.
9232
9233 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9234
9235         * dwarf2read.c (open_and_init_dwp_file): Call
9236         elf_numsections instead of bfd_count_sections to initialize
9237         dwp_file->num_sections.
9238
9239 2019-02-25  Tom Tromey  <tromey@adacore.com>
9240
9241         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9242
9243 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9244
9245         * gcore.in: Add '--readnever' option when invoking GDB.
9246
9247 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9248
9249         * MAINTAINERS: Update my email address.
9250
9251 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9252
9253         * build-id.c (build_id_to_debug_bfd_1): New function.
9254         (build_id_to_debug_bfd): Look for separate debug file in
9255         sysroot.
9256
9257 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9258
9259         * gdbarch.sh: Update the copyright year range that is placed into
9260         generated files.
9261
9262 2019-02-22  Keith Seitz  <keiths@redhat.com>
9263
9264         PR symtab/23853
9265         * linespec.c (create_sals_line_offset): Search for the default
9266         symtab's filename instead of its fullname.
9267
9268 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9269
9270         * NEWS: Update style defaults.
9271
9272 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9273
9274         * main.c (captured_main_1): Disable styling in batch mode.
9275
9276 2019-02-20  Tom Tromey  <tom@tromey.com>
9277
9278         * symtab.c (symtab_symbol_info): Fix typos.
9279
9280 2019-02-20  Tom Tromey  <tromey@adacore.com>
9281
9282         * findcmd.c (_initialize_mem_search): Use upper case for
9283         metasyntactic variables.
9284
9285 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9286
9287         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9288         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9289
9290 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9291
9292         * top.h (source_file_name): Change to std::string.
9293         * top.c (source_file_name): Likewise.
9294         (command_line_input): Adjust.
9295         * cli/cli-script.c (script_from_file): Adjust.
9296
9297 2019-02-19  Tom Tromey  <tromey@adacore.com>
9298
9299         * ravenscar-thread.c
9300         (ravenscar_thread_target::update_thread_list): Don't call
9301         ada_build_task_list.
9302         * ada-lang.h (ada_build_task_list): Don't declare.
9303         * ada-tasks.c (struct ada_tasks_inferior_data)
9304         <task_list_valid_p>: Now bool.
9305         (read_known_tasks, ada_task_list_changed)
9306         (ada_tasks_invalidate_inferior_data): Update.
9307         (read_known_tasks_array): Return bool.
9308         (read_known_tasks_list): Likewise.
9309         (read_known_tasks): Return void.
9310         (ada_build_task_list): Now static.
9311
9312 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9315         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9316
9317 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9318
9319         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9320         variant for ada_tasks_pspace_data_handle and
9321         ada_tasks_inferior_data_handle.
9322         (ada_tasks_pspace_data_cleanup): New function.
9323         (ada_tasks_inferior_data_cleanup): New function.
9324
9325 2019-02-17  Tom Tromey  <tom@tromey.com>
9326
9327         * macrotab.h (macro_source_fullname): Return a std::string.
9328         * macrotab.c (macro_include, check_for_redefinition)
9329         (macro_undef, macro_lookup_definition, foreach_macro)
9330         (foreach_macro_in_scope): Update.
9331         (macro_source_fullname): Return a std::string.
9332         * macrocmd.c (show_pp_source_pos): Update.
9333
9334 2019-02-17  Tom Tromey  <tom@tromey.com>
9335
9336         * macrocmd.c (show_pp_source_pos): Style the file names.
9337
9338 2019-02-17  Tom Tromey  <tom@tromey.com>
9339
9340         PR tui/24197:
9341         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9342
9343 2019-02-17  Tom Tromey  <tom@tromey.com>
9344
9345         * ada-lang.c (user_select_syms): Use filtered printing.
9346         * utils.c (wrap_style): New global.
9347         (desired_style): Remove.
9348         (emit_style_escape): Add stream parameter.
9349         (set_output_style, reset_terminal_style, prompt_for_continue):
9350         Update.
9351         (flush_wrap_buffer): Only flush gdb_stdout.
9352         (wrap_here): Set wrap_style.
9353         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9354         treat escape sequences as a character.  Change when wrap buffer is
9355         flushed.
9356         (fputs_styled): Do not set the output style when the default is
9357         requested.
9358         * ui-style.h (struct ui_file_style) <is_default>: New method.
9359         * source.c (print_source_lines_base): Emit escape sequences in one
9360         piece.
9361
9362 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9363
9364         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9365         integers and enumeration types.
9366
9367 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9368
9369         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9370         instead of lookup_symbol_in_language
9371         (do_exact_match): New function.
9372         (ada_get_symbol_name_matcher): Return do_exact_match when
9373         doing a verbatim match.
9374
9375 2019-02-15  Tom Tromey  <tromey@adacore.com>
9376
9377         * ravenscar-thread.c (ravenscar_thread_target::resume)
9378         (ravenscar_thread_target::wait): Special case wildcard requests.
9379
9380 2019-02-15  Tom Tromey  <tromey@adacore.com>
9381
9382         * ravenscar-thread.c (base_ptid): Remove.
9383         (struct ravenscar_thread_target) <close>: New method.
9384         <m_base_ptid>: New member.
9385         <update_inferior_ptid, active_task, task_is_currently_active,
9386         runtime_initialized>: Declare methods.
9387         <ravenscar_thread_target>: Add constructor.
9388         (ravenscar_thread_target::task_is_currently_active)
9389         (ravenscar_thread_target::update_inferior_ptid)
9390         (ravenscar_runtime_initialized): Rename.  Now methods.
9391         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9392         (ravenscar_thread_target::update_thread_list): Update.
9393         (ravenscar_thread_target::active_task): Now method.
9394         (ravenscar_thread_target::store_registers)
9395         (ravenscar_thread_target::prepare_to_store)
9396         (ravenscar_thread_target::prepare_to_store)
9397         (ravenscar_thread_target::mourn_inferior): Update.
9398         (ravenscar_inferior_created): Use "new" to create target.
9399         (ravenscar_thread_target::get_ada_task_ptid): Update.
9400         (_initialize_ravenscar): Don't initialize base_ptid.
9401         (ravenscar_ops): Remove global.
9402
9403 2019-02-15  Tom Tromey  <tromey@adacore.com>
9404
9405         * target.h (push_target): Declare new overload.
9406         * target.c (push_target): New overload, taking an rvalue reference.
9407         * remote.c (remote_target::open_1): Use push_target overload.
9408         * corelow.c (core_target_open): Use push_target overload.
9409
9410 2019-02-15  Tom Tromey  <tromey@adacore.com>
9411
9412         * ravenscar-thread.c (is_ravenscar_task)
9413         (ravenscar_task_is_currently_active): Return bool.
9414         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9415         (_initialize_ravenscar): Remove "(void)".
9416         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9417         Return bool.
9418
9419 2019-02-15  Tom Tromey  <tromey@adacore.com>
9420
9421         * ravenscar-thread.c (ravenscar_runtime_initializer)
9422         (has_ravenscar_runtime, get_running_thread_id)
9423         (ravenscar_thread_target::resume): Fix indentation.
9424
9425 2019-02-15  Tom Tromey  <tromey@adacore.com>
9426
9427         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9428         from ravenscar_arch_ops.
9429         (sparc_ravenscar_ops::fetch_registers)
9430         (sparc_ravenscar_ops::store_registers): Now methods.
9431         (sparc_ravenscar_prepare_to_store): Remove.
9432         (sparc_ravenscar_ops): Redefine.
9433         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9434         methods and destructor.  Remove members.
9435         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9436         (ravenscar_thread_target::store_registers)
9437         (ravenscar_thread_target::prepare_to_store): Update.
9438         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9439         Remove.
9440         (struct ppc_ravenscar_powerpc_ops): Derive from
9441         ravenscar_arch_ops.
9442         (ppc_ravenscar_powerpc_ops::fetch_registers)
9443         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9444         (ppc_ravenscar_powerpc_ops): Redefine.
9445         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9446         (ppc_ravenscar_e500_ops::fetch_registers)
9447         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9448         (ppc_ravenscar_e500_ops): Redefine.
9449         * aarch64-ravenscar-thread.c
9450         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9451         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9452         (aarch64_ravenscar_fetch_registers)
9453         (aarch64_ravenscar_store_registers): Now methods.
9454         (aarch64_ravenscar_ops): Redefine.
9455
9456 2019-02-15  Tom Tromey  <tromey@adacore.com>
9457
9458         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9459         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9460         (ravenscar_thread_target::stopped_by_watchpoint)
9461         (ravenscar_thread_target::stopped_data_address)
9462         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9463
9464 2019-02-15  Tom Tromey  <tromey@adacore.com>
9465
9466         * ravenscar-thread.c: Fix some typos.
9467
9468 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9469             Tom Tromey  <tromey@adacore.com>
9470
9471         * ada-lang.c (ada_exception_sal): Change addr_string to a
9472         std::string.
9473         (create_ada_exception_catchpoint): Update.
9474
9475 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9476             Tom Tromey  <tromey@adacore.com>
9477
9478         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9479         (bp_location_ops): Remove.
9480         (base_breakpoint_allocate_location): Update.
9481         (free_bp_location): Update.
9482         * ada-lang.c (class ada_catchpoint_location)
9483         <ada_catchpoint_location>: Remove ops parameter.
9484         (ada_catchpoint_location_dtor): Remove.
9485         (ada_catchpoint_location_ops): Remove.
9486         (allocate_location_exception): Update.
9487         * breakpoint.h (struct bp_location_ops): Remove.
9488         (class bp_location) <bp_location>: Remove bp_location_ops
9489         parameter.
9490         <~bp_location>: Add destructor.
9491         <ops>: Remove.
9492
9493 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9494             Pedro Alves  <palves@redhat.com>
9495
9496         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9497         'PATH_MAX'.
9498
9499 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9500             Samuel Thibault  <samuel.thibault@gnu.org>
9501             Thomas Schwinge  <thomas@codesourcery.com>
9502
9503         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9504         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9505
9506 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9507
9508         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9509         (check_empty): Use "const char *".
9510
9511         * gnu-nat.c (gnu_nat_target::detach): Instead of
9512         'detach_inferior (pid)' call
9513         'detach_inferior (find_inferior_pid (pid))'.
9514
9515         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9516         'nat/fork-inferior.o'.
9517         * gnu-nat.c: #include "nat/fork-inferior.h".
9518
9519         * gnu-nat.c (gnu_nat_target::detach): Instead of
9520         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9521         * gnu-nat.h: #include "inf-child.h".
9522         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9523         'i386_gnu_nat_target::fetch_registers'.
9524         (gnu_store_registers): Rename/move to
9525         'i386_gnu_nat_target::store_registers'.
9526
9527         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9528         * gnu-nat.h (mach_thread_info): New function.
9529         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9530
9531         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9532
9533 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9534
9535         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9536
9537 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9538
9539         * windows-nat.c (windows_add_thread): Add new parameter
9540         "main_thread_p" with default value set to false.  Update
9541         function documentation as well as all callers.
9542         (windows_delete_thread): Likewise.
9543         (fake_create_process): Update call to windows_add_thread.
9544         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9545         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9546         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9547         call to windows_delete_thread.
9548
9549 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9550
9551         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9552
9553 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9554
9555         * symfile.c (find_separate_debug_file): Use canonical path of
9556         sysroot with child_path instead of gdb_sysroot if it is valid.
9557
9558 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9559
9560         * symfile.c (find_separate_debug_file): Use child_path to
9561         determine if an object file is under a sysroot.
9562
9563 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9564
9565         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9566         unittests/child-path-selftests.c.
9567         * common/pathstuff.c (child_path): New function.
9568         * common/pathstuff.h (child_path): New prototype.
9569         * unittests/child-path-selftests.c: New file.
9570
9571 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9572
9573         * symfile.c (find_separate_debug_file): Look for separate debug
9574         files in debug directories under the sysroot.
9575
9576 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9577
9578         * symtab.h (struct minimal_symbol data_p): New const method.
9579         (struct minimal_symbol text_p): Likewise.
9580         * symtab.c (output_source_filename): Use file name style
9581         to print file name.
9582         (print_symbol_info): Likewise.
9583         (print_msymbol_info): Use address style to print addresses.
9584         Use function name style to print executable text symbols.
9585         (expand_symtab_containing_pc): Use data_p.
9586         (find_pc_sect_compunit_symtab): Likewise.
9587
9588 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9589
9590         * breakpoint.c (describe_other_breakpoints): Use address style
9591         to print addresses.
9592         (say_where): Likewise.
9593
9594 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9595
9596         * ada-typeprint.c (print_func_type): Print function name
9597         style to print function name.
9598         * c-typeprint.c (c_print_type_1): Likewise.
9599
9600 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9601
9602         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9603         for execve.
9604
9605 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9606
9607         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9608         type_stack.
9609
9610 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9611
9612         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9613         TYPE_CODE_REF types.
9614
9615 2019-02-08  Jim Wilson  <jimw@sifive.com>
9616
9617         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9618         (riscv_linux_fregset): New.
9619         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9620
9621 2019-02-07  Tom Tromey  <tom@tromey.com>
9622
9623         * thread.c (thread_cancel_execution_command): Update.
9624         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9625         methods.
9626         (struct thread_fsm_ops): Remove.
9627         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9628         (thread_fsm_should_stop, thread_fsm_return_value)
9629         (thread_fsm_set_finished, thread_fsm_finished_p)
9630         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9631         Don't declare.
9632         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9633         * infrun.c (clear_proceed_status_thread)
9634         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9635         (print_stop_event): Update.
9636         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9637         Add constructor.
9638         (step_command_fsm_ops): Remove.
9639         (new_step_command_fsm): Remove.
9640         (step_1): Update.
9641         (step_command_fsm::should_stop): Rename from
9642         step_command_fsm_should_stop.
9643         (step_command_fsm::clean_up): Rename from
9644         step_command_fsm_clean_up.
9645         (step_command_fsm::do_async_reply_reason): Rename from
9646         step_command_fsm_async_reply_reason.
9647         (struct until_next_fsm): Inherit from thread_fsm.  Add
9648         constructor.
9649         (until_next_fsm_ops): Remove.
9650         (new_until_next_fsm): Remove.
9651         (until_next_fsm::should_stop): Rename from
9652         until_next_fsm_should_stop.
9653         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9654         (until_next_fsm::do_async_reply_reason): Rename from
9655         until_next_fsm_async_reply_reason.
9656         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9657         constructor.  Change type of breakpoint.
9658         (finish_command_fsm_ops): Remove.
9659         (new_finish_command_fsm): Remove.
9660         (finish_command_fsm::should_stop): Rename from
9661         finish_command_fsm_should_stop.
9662         (finish_command_fsm::clean_up): Rename from
9663         finish_command_fsm_clean_up.
9664         (finish_command_fsm::return_value): Rename from
9665         finish_command_fsm_return_value.
9666         (finish_command_fsm::do_async_reply_reason): Rename from
9667         finish_command_fsm_async_reply_reason.
9668         (finish_command): Update.
9669         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9670         Add constructor.
9671         (call_thread_fsm_ops): Remove.
9672         (call_thread_fsm::call_thread_fsm): Rename from
9673         new_call_thread_fsm.
9674         (call_thread_fsm::should_stop): Rename from
9675         call_thread_fsm_should_stop.
9676         (call_thread_fsm::should_notify_stop): Rename from
9677         call_thread_fsm_should_notify_stop.
9678         (run_inferior_call, call_function_by_hand_dummy): Update.
9679         * cli/cli-interp.c (should_print_stop_to_console): Update.
9680         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9681         Add constructor.  Change type of location_breakpoint,
9682         caller_breakpoint.
9683         (until_break_fsm_ops): Remove.
9684         (new_until_break_fsm): Remove.
9685         (until_break_fsm::should_stop): Rename from
9686         until_break_fsm_should_stop.
9687         (until_break_fsm::clean_up): Rename from
9688         until_break_fsm_clean_up.
9689         (until_break_fsm::do_async_reply_reason): Rename from
9690         until_break_fsm_async_reply_reason.
9691         (until_break_command): Update.
9692         * thread-fsm.c: Remove.
9693         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9694
9695 2019-02-07  Tom Tromey  <tom@tromey.com>
9696
9697         * yy-remap.h: Add include guard.
9698         * xtensa-tdep.h: Add include guard.
9699         * xcoffread.h: Rename include guard.
9700         * varobj-iter.h: Add include guard.
9701         * tui/tui.h: Rename include guard.
9702         * tui/tui-winsource.h: Rename include guard.
9703         * tui/tui-wingeneral.h: Rename include guard.
9704         * tui/tui-windata.h: Rename include guard.
9705         * tui/tui-win.h: Rename include guard.
9706         * tui/tui-stack.h: Rename include guard.
9707         * tui/tui-source.h: Rename include guard.
9708         * tui/tui-regs.h: Rename include guard.
9709         * tui/tui-out.h: Rename include guard.
9710         * tui/tui-layout.h: Rename include guard.
9711         * tui/tui-io.h: Rename include guard.
9712         * tui/tui-hooks.h: Rename include guard.
9713         * tui/tui-file.h: Rename include guard.
9714         * tui/tui-disasm.h: Rename include guard.
9715         * tui/tui-data.h: Rename include guard.
9716         * tui/tui-command.h: Rename include guard.
9717         * tic6x-tdep.h: Add include guard.
9718         * target/waitstatus.h: Rename include guard.
9719         * target/wait.h: Rename include guard.
9720         * target/target.h: Rename include guard.
9721         * target/resume.h: Rename include guard.
9722         * target-float.h: Rename include guard.
9723         * stabsread.h: Add include guard.
9724         * rs6000-tdep.h: Add include guard.
9725         * riscv-fbsd-tdep.h: Add include guard.
9726         * regformats/regdef.h: Rename include guard.
9727         * record.h: Rename include guard.
9728         * python/python.h: Rename include guard.
9729         * python/python-internal.h: Rename include guard.
9730         * python/py-stopevent.h: Rename include guard.
9731         * python/py-ref.h: Rename include guard.
9732         * python/py-record.h: Rename include guard.
9733         * python/py-record-full.h: Rename include guard.
9734         * python/py-record-btrace.h: Rename include guard.
9735         * python/py-instruction.h: Rename include guard.
9736         * python/py-events.h: Rename include guard.
9737         * python/py-event.h: Rename include guard.
9738         * procfs.h: Add include guard.
9739         * proc-utils.h: Add include guard.
9740         * p-lang.h: Add include guard.
9741         * or1k-tdep.h: Rename include guard.
9742         * observable.h: Rename include guard.
9743         * nto-tdep.h: Rename include guard.
9744         * nat/x86-linux.h: Rename include guard.
9745         * nat/x86-linux-dregs.h: Rename include guard.
9746         * nat/x86-gcc-cpuid.h: Add include guard.
9747         * nat/x86-dregs.h: Rename include guard.
9748         * nat/x86-cpuid.h: Rename include guard.
9749         * nat/ppc-linux.h: Rename include guard.
9750         * nat/mips-linux-watch.h: Rename include guard.
9751         * nat/linux-waitpid.h: Rename include guard.
9752         * nat/linux-ptrace.h: Rename include guard.
9753         * nat/linux-procfs.h: Rename include guard.
9754         * nat/linux-osdata.h: Rename include guard.
9755         * nat/linux-nat.h: Rename include guard.
9756         * nat/linux-namespaces.h: Rename include guard.
9757         * nat/linux-btrace.h: Rename include guard.
9758         * nat/glibc_thread_db.h: Rename include guard.
9759         * nat/gdb_thread_db.h: Rename include guard.
9760         * nat/gdb_ptrace.h: Rename include guard.
9761         * nat/fork-inferior.h: Rename include guard.
9762         * nat/amd64-linux-siginfo.h: Rename include guard.
9763         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9764         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9765         * nat/aarch64-linux.h: Rename include guard.
9766         * nat/aarch64-linux-hw-point.h: Rename include guard.
9767         * mn10300-tdep.h: Add include guard.
9768         * mips-linux-tdep.h: Add include guard.
9769         * mi/mi-parse.h: Rename include guard.
9770         * mi/mi-out.h: Rename include guard.
9771         * mi/mi-main.h: Rename include guard.
9772         * mi/mi-interp.h: Rename include guard.
9773         * mi/mi-getopt.h: Rename include guard.
9774         * mi/mi-console.h: Rename include guard.
9775         * mi/mi-common.h: Rename include guard.
9776         * mi/mi-cmds.h: Rename include guard.
9777         * mi/mi-cmd-break.h: Rename include guard.
9778         * m2-lang.h: Add include guard.
9779         * location.h: Rename include guard.
9780         * linux-record.h: Rename include guard.
9781         * linux-nat.h: Add include guard.
9782         * linux-fork.h: Add include guard.
9783         * i386-darwin-tdep.h: Rename include guard.
9784         * hppa-linux-offsets.h: Add include guard.
9785         * guile/guile.h: Rename include guard.
9786         * guile/guile-internal.h: Rename include guard.
9787         * gnu-nat.h: Rename include guard.
9788         * gdb-stabs.h: Rename include guard.
9789         * frv-tdep.h: Add include guard.
9790         * f-lang.h: Add include guard.
9791         * event-loop.h: Add include guard.
9792         * darwin-nat.h: Rename include guard.
9793         * cp-abi.h: Rename include guard.
9794         * config/sparc/nm-sol2.h: Rename include guard.
9795         * config/nm-nto.h: Rename include guard.
9796         * config/nm-linux.h: Add include guard.
9797         * config/i386/nm-i386gnu.h: Rename include guard.
9798         * config/djgpp/nl_types.h: Rename include guard.
9799         * config/djgpp/langinfo.h: Rename include guard.
9800         * compile/gcc-cp-plugin.h: Add include guard.
9801         * compile/gcc-c-plugin.h: Add include guard.
9802         * compile/compile.h: Rename include guard.
9803         * compile/compile-object-run.h: Rename include guard.
9804         * compile/compile-object-load.h: Rename include guard.
9805         * compile/compile-internal.h: Rename include guard.
9806         * compile/compile-cplus.h: Rename include guard.
9807         * compile/compile-c.h: Rename include guard.
9808         * common/xml-utils.h: Rename include guard.
9809         * common/x86-xstate.h: Rename include guard.
9810         * common/version.h: Rename include guard.
9811         * common/vec.h: Rename include guard.
9812         * common/tdesc.h: Rename include guard.
9813         * common/selftest.h: Rename include guard.
9814         * common/scoped_restore.h: Rename include guard.
9815         * common/scoped_mmap.h: Rename include guard.
9816         * common/scoped_fd.h: Rename include guard.
9817         * common/safe-iterator.h: Rename include guard.
9818         * common/run-time-clock.h: Rename include guard.
9819         * common/refcounted-object.h: Rename include guard.
9820         * common/queue.h: Rename include guard.
9821         * common/ptid.h: Rename include guard.
9822         * common/print-utils.h: Rename include guard.
9823         * common/preprocessor.h: Rename include guard.
9824         * common/pathstuff.h: Rename include guard.
9825         * common/observable.h: Rename include guard.
9826         * common/netstuff.h: Rename include guard.
9827         * common/job-control.h: Rename include guard.
9828         * common/host-defs.h: Rename include guard.
9829         * common/gdb_wait.h: Rename include guard.
9830         * common/gdb_vecs.h: Rename include guard.
9831         * common/gdb_unlinker.h: Rename include guard.
9832         * common/gdb_unique_ptr.h: Rename include guard.
9833         * common/gdb_tilde_expand.h: Rename include guard.
9834         * common/gdb_sys_time.h: Rename include guard.
9835         * common/gdb_string_view.h: Rename include guard.
9836         * common/gdb_splay_tree.h: Rename include guard.
9837         * common/gdb_setjmp.h: Rename include guard.
9838         * common/gdb_ref_ptr.h: Rename include guard.
9839         * common/gdb_optional.h: Rename include guard.
9840         * common/gdb_locale.h: Rename include guard.
9841         * common/gdb_assert.h: Rename include guard.
9842         * common/filtered-iterator.h: Rename include guard.
9843         * common/filestuff.h: Rename include guard.
9844         * common/fileio.h: Rename include guard.
9845         * common/environ.h: Rename include guard.
9846         * common/common-utils.h: Rename include guard.
9847         * common/common-types.h: Rename include guard.
9848         * common/common-regcache.h: Rename include guard.
9849         * common/common-inferior.h: Rename include guard.
9850         * common/common-gdbthread.h: Rename include guard.
9851         * common/common-exceptions.h: Rename include guard.
9852         * common/common-defs.h: Rename include guard.
9853         * common/common-debug.h: Rename include guard.
9854         * common/cleanups.h: Rename include guard.
9855         * common/buffer.h: Rename include guard.
9856         * common/btrace-common.h: Rename include guard.
9857         * common/break-common.h: Rename include guard.
9858         * cli/cli-utils.h: Rename include guard.
9859         * cli/cli-style.h: Rename include guard.
9860         * cli/cli-setshow.h: Rename include guard.
9861         * cli/cli-script.h: Rename include guard.
9862         * cli/cli-interp.h: Rename include guard.
9863         * cli/cli-decode.h: Rename include guard.
9864         * cli/cli-cmds.h: Rename include guard.
9865         * charset-list.h: Add include guard.
9866         * buildsym-legacy.h: Rename include guard.
9867         * bfin-tdep.h: Add include guard.
9868         * ax.h: Rename include guard.
9869         * arm-linux-tdep.h: Add include guard.
9870         * arm-fbsd-tdep.h: Add include guard.
9871         * arch/xtensa.h: Rename include guard.
9872         * arch/tic6x.h: Add include guard.
9873         * arch/i386.h: Add include guard.
9874         * arch/arm.h: Rename include guard.
9875         * arch/arm-linux.h: Rename include guard.
9876         * arch/arm-get-next-pcs.h: Rename include guard.
9877         * arch/amd64.h: Add include guard.
9878         * arch/aarch64-insn.h: Rename include guard.
9879         * arch-utils.h: Rename include guard.
9880         * annotate.h: Add include guard.
9881         * amd64-darwin-tdep.h: Rename include guard.
9882         * aarch64-linux-tdep.h: Add include guard.
9883         * aarch64-fbsd-tdep.h: Add include guard.
9884         * aarch32-linux-nat.h: Add include guard.
9885
9886 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9887
9888         * macrotab.c (macro_define_internal): New function that
9889         factorizes macro_define_object_internal and macro_define_function
9890         code.
9891         (macro_define_object_internal): Use macro_define_internal.
9892         (macro_define_function): Likewise.
9893
9894 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9895
9896         * macrocmd.c (extract_identifier): Return
9897         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9898         callers.
9899
9900 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9901
9902         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9903
9904 2019-02-05  Tom Tromey  <tom@tromey.com>
9905
9906         * target.c (target_stack::unpush): Move assertion earlier.
9907
9908 2019-01-30  Tom Tromey  <tom@tromey.com>
9909
9910         PR python/23615:
9911         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9912         (gdbpy_parse_and_eval): Likewise.
9913         * python/python-internal.h (gdbpy_allow_threads): New class.
9914
9915 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9916
9917         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9918         (aarch64_fbsd_fpregmap): Move earlier.
9919         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9920         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9921         instead of individual calls to trad_frame_set_reg_addr.
9922         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9923         earlier.
9924         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9925         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9926         instead of individual calls to trad_frame_set_reg_addr.
9927
9928 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9929
9930         * CONTRIBUTE: Replace contribution list with wiki link.
9931
9932 2019-01-25  Tom Tromey  <tom@tromey.com>
9933
9934         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9935
9936 2019-01-25  Tom Tromey  <tom@tromey.com>
9937
9938         * xtensa-linux-nat.c: Fix common/ includes.
9939         * xml-support.h: Fix common/ includes.
9940         * xml-support.c: Fix common/ includes.
9941         * x86-linux-nat.c: Fix common/ includes.
9942         * windows-nat.c: Fix common/ includes.
9943         * varobj.h: Fix common/ includes.
9944         * varobj.c: Fix common/ includes.
9945         * value.c: Fix common/ includes.
9946         * valops.c: Fix common/ includes.
9947         * utils.c: Fix common/ includes.
9948         * unittests/xml-utils-selftests.c: Fix common/ includes.
9949         * unittests/utils-selftests.c: Fix common/ includes.
9950         * unittests/unpack-selftests.c: Fix common/ includes.
9951         * unittests/tracepoint-selftests.c: Fix common/ includes.
9952         * unittests/style-selftests.c: Fix common/ includes.
9953         * unittests/string_view-selftests.c: Fix common/ includes.
9954         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9955         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9956         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9957         * unittests/rsp-low-selftests.c: Fix common/ includes.
9958         * unittests/parse-connection-spec-selftests.c: Fix common/
9959         includes.
9960         * unittests/optional-selftests.c: Fix common/ includes.
9961         * unittests/offset-type-selftests.c: Fix common/ includes.
9962         * unittests/observable-selftests.c: Fix common/ includes.
9963         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9964         * unittests/memrange-selftests.c: Fix common/ includes.
9965         * unittests/memory-map-selftests.c: Fix common/ includes.
9966         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9967         * unittests/function-view-selftests.c: Fix common/ includes.
9968         * unittests/environ-selftests.c: Fix common/ includes.
9969         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9970         * unittests/common-utils-selftests.c: Fix common/ includes.
9971         * unittests/cli-utils-selftests.c: Fix common/ includes.
9972         * unittests/array-view-selftests.c: Fix common/ includes.
9973         * ui-file.c: Fix common/ includes.
9974         * tui/tui-io.c: Fix common/ includes.
9975         * tracepoint.h: Fix common/ includes.
9976         * tracepoint.c: Fix common/ includes.
9977         * tracefile-tfile.c: Fix common/ includes.
9978         * top.h: Fix common/ includes.
9979         * top.c: Fix common/ includes.
9980         * thread.c: Fix common/ includes.
9981         * target/waitstatus.h: Fix common/ includes.
9982         * target/waitstatus.c: Fix common/ includes.
9983         * target.h: Fix common/ includes.
9984         * target.c: Fix common/ includes.
9985         * target-memory.c: Fix common/ includes.
9986         * target-descriptions.c: Fix common/ includes.
9987         * symtab.h: Fix common/ includes.
9988         * symfile.c: Fix common/ includes.
9989         * stap-probe.c: Fix common/ includes.
9990         * spu-linux-nat.c: Fix common/ includes.
9991         * sparc-nat.c: Fix common/ includes.
9992         * source.c: Fix common/ includes.
9993         * solib.c: Fix common/ includes.
9994         * solib-target.c: Fix common/ includes.
9995         * ser-unix.c: Fix common/ includes.
9996         * ser-tcp.c: Fix common/ includes.
9997         * ser-pipe.c: Fix common/ includes.
9998         * ser-base.c: Fix common/ includes.
9999         * selftest-arch.c: Fix common/ includes.
10000         * s12z-tdep.c: Fix common/ includes.
10001         * rust-exp.y: Fix common/ includes.
10002         * rs6000-aix-tdep.c: Fix common/ includes.
10003         * riscv-tdep.c: Fix common/ includes.
10004         * remote.c: Fix common/ includes.
10005         * remote-notif.h: Fix common/ includes.
10006         * remote-fileio.h: Fix common/ includes.
10007         * remote-fileio.c: Fix common/ includes.
10008         * regcache.h: Fix common/ includes.
10009         * regcache.c: Fix common/ includes.
10010         * record-btrace.c: Fix common/ includes.
10011         * python/python.c: Fix common/ includes.
10012         * python/py-type.c: Fix common/ includes.
10013         * python/py-inferior.c: Fix common/ includes.
10014         * progspace.h: Fix common/ includes.
10015         * producer.c: Fix common/ includes.
10016         * procfs.c: Fix common/ includes.
10017         * proc-api.c: Fix common/ includes.
10018         * printcmd.c: Fix common/ includes.
10019         * ppc-linux-nat.c: Fix common/ includes.
10020         * parser-defs.h: Fix common/ includes.
10021         * osdata.c: Fix common/ includes.
10022         * obsd-nat.c: Fix common/ includes.
10023         * nat/x86-linux.c: Fix common/ includes.
10024         * nat/x86-linux-dregs.c: Fix common/ includes.
10025         * nat/x86-dregs.h: Fix common/ includes.
10026         * nat/x86-dregs.c: Fix common/ includes.
10027         * nat/ppc-linux.c: Fix common/ includes.
10028         * nat/mips-linux-watch.h: Fix common/ includes.
10029         * nat/mips-linux-watch.c: Fix common/ includes.
10030         * nat/linux-waitpid.c: Fix common/ includes.
10031         * nat/linux-ptrace.h: Fix common/ includes.
10032         * nat/linux-ptrace.c: Fix common/ includes.
10033         * nat/linux-procfs.c: Fix common/ includes.
10034         * nat/linux-personality.c: Fix common/ includes.
10035         * nat/linux-osdata.c: Fix common/ includes.
10036         * nat/linux-namespaces.c: Fix common/ includes.
10037         * nat/linux-btrace.h: Fix common/ includes.
10038         * nat/linux-btrace.c: Fix common/ includes.
10039         * nat/fork-inferior.c: Fix common/ includes.
10040         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10041         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10042         * nat/aarch64-linux.c: Fix common/ includes.
10043         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10044         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10045         * namespace.h: Fix common/ includes.
10046         * mips-linux-tdep.c: Fix common/ includes.
10047         * minsyms.c: Fix common/ includes.
10048         * mi/mi-parse.h: Fix common/ includes.
10049         * mi/mi-main.c: Fix common/ includes.
10050         * mi/mi-cmd-env.c: Fix common/ includes.
10051         * memrange.h: Fix common/ includes.
10052         * memattr.c: Fix common/ includes.
10053         * maint.h: Fix common/ includes.
10054         * maint.c: Fix common/ includes.
10055         * main.c: Fix common/ includes.
10056         * machoread.c: Fix common/ includes.
10057         * location.c: Fix common/ includes.
10058         * linux-thread-db.c: Fix common/ includes.
10059         * linux-nat.c: Fix common/ includes.
10060         * linux-fork.c: Fix common/ includes.
10061         * inline-frame.c: Fix common/ includes.
10062         * infrun.c: Fix common/ includes.
10063         * inflow.c: Fix common/ includes.
10064         * inferior.h: Fix common/ includes.
10065         * inferior.c: Fix common/ includes.
10066         * infcmd.c: Fix common/ includes.
10067         * inf-ptrace.c: Fix common/ includes.
10068         * inf-child.c: Fix common/ includes.
10069         * ia64-linux-nat.c: Fix common/ includes.
10070         * i387-tdep.c: Fix common/ includes.
10071         * i386-tdep.c: Fix common/ includes.
10072         * i386-linux-tdep.c: Fix common/ includes.
10073         * i386-linux-nat.c: Fix common/ includes.
10074         * i386-go32-tdep.c: Fix common/ includes.
10075         * i386-fbsd-tdep.c: Fix common/ includes.
10076         * i386-fbsd-nat.c: Fix common/ includes.
10077         * guile/scm-type.c: Fix common/ includes.
10078         * guile/guile.c: Fix common/ includes.
10079         * go32-nat.c: Fix common/ includes.
10080         * gnu-nat.c: Fix common/ includes.
10081         * gdbthread.h: Fix common/ includes.
10082         * gdbarch-selftests.c: Fix common/ includes.
10083         * gdb_usleep.c: Fix common/ includes.
10084         * gdb_select.h: Fix common/ includes.
10085         * gdb_bfd.c: Fix common/ includes.
10086         * gcore.c: Fix common/ includes.
10087         * fork-child.c: Fix common/ includes.
10088         * findvar.c: Fix common/ includes.
10089         * fbsd-nat.c: Fix common/ includes.
10090         * event-top.c: Fix common/ includes.
10091         * event-loop.c: Fix common/ includes.
10092         * dwarf2read.c: Fix common/ includes.
10093         * dwarf2loc.c: Fix common/ includes.
10094         * dwarf2-frame.c: Fix common/ includes.
10095         * dwarf-index-cache.c: Fix common/ includes.
10096         * dtrace-probe.c: Fix common/ includes.
10097         * disasm-selftests.c: Fix common/ includes.
10098         * defs.h: Fix common/ includes.
10099         * csky-tdep.c: Fix common/ includes.
10100         * cp-valprint.c: Fix common/ includes.
10101         * cp-support.h: Fix common/ includes.
10102         * cp-support.c: Fix common/ includes.
10103         * corelow.c: Fix common/ includes.
10104         * completer.h: Fix common/ includes.
10105         * completer.c: Fix common/ includes.
10106         * compile/compile.c: Fix common/ includes.
10107         * compile/compile-loc2c.c: Fix common/ includes.
10108         * compile/compile-cplus-types.c: Fix common/ includes.
10109         * compile/compile-cplus-symbols.c: Fix common/ includes.
10110         * command.h: Fix common/ includes.
10111         * cli/cli-dump.c: Fix common/ includes.
10112         * cli/cli-cmds.c: Fix common/ includes.
10113         * charset.c: Fix common/ includes.
10114         * build-id.c: Fix common/ includes.
10115         * btrace.h: Fix common/ includes.
10116         * btrace.c: Fix common/ includes.
10117         * breakpoint.h: Fix common/ includes.
10118         * breakpoint.c: Fix common/ includes.
10119         * ax.h:
10120         (enum agent_op): Fix common/ includes.
10121         * ax-general.c (struct aop_map): Fix common/ includes.
10122         * ax-gdb.c: Fix common/ includes.
10123         * auxv.c: Fix common/ includes.
10124         * auto-load.c: Fix common/ includes.
10125         * arm-tdep.c: Fix common/ includes.
10126         * arch/riscv.c: Fix common/ includes.
10127         * arch/ppc-linux-common.c: Fix common/ includes.
10128         * arch/i386.c: Fix common/ includes.
10129         * arch/arm.c: Fix common/ includes.
10130         * arch/arm-linux.c: Fix common/ includes.
10131         * arch/arm-get-next-pcs.c: Fix common/ includes.
10132         * arch/amd64.c: Fix common/ includes.
10133         * arch/aarch64.c: Fix common/ includes.
10134         * arch/aarch64-insn.c: Fix common/ includes.
10135         * arch-utils.c: Fix common/ includes.
10136         * amd64-windows-tdep.c: Fix common/ includes.
10137         * amd64-tdep.c: Fix common/ includes.
10138         * amd64-sol2-tdep.c: Fix common/ includes.
10139         * amd64-obsd-tdep.c: Fix common/ includes.
10140         * amd64-nbsd-tdep.c: Fix common/ includes.
10141         * amd64-linux-tdep.c: Fix common/ includes.
10142         * amd64-linux-nat.c: Fix common/ includes.
10143         * amd64-fbsd-tdep.c: Fix common/ includes.
10144         * amd64-fbsd-nat.c: Fix common/ includes.
10145         * amd64-dicos-tdep.c: Fix common/ includes.
10146         * amd64-darwin-tdep.c: Fix common/ includes.
10147         * agent.c: Fix common/ includes.
10148         * ada-lang.h: Fix common/ includes.
10149         * ada-lang.c: Fix common/ includes.
10150         * aarch64-tdep.c: Fix common/ includes.
10151
10152 2019-01-25  Tom Tromey  <tom@tromey.com>
10153
10154         * common/create-version.sh: Use common/version.h.
10155
10156 2019-01-24  Pedro Alves  <palves@redhat.com>
10157
10158         * infrun.c (signal_stop, signal_print, signal_program)
10159         (signal_catch, signal_pass): Now arrays instead of pointers.
10160         (update_signals_program_target, do_target_resume)
10161         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10162         * linux-nat.c (linux_nat_target::pass_signals)
10163         (linux_nat_target::create_inferior, linux_nat_target::attach):
10164         Adjust.
10165         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10166         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10167         * procfs.c (procfs_target::pass_signals): Adjust.
10168         * record-full.c (record_full_target::resume): Adjust.
10169         * remote.c (remote_target::pass_signals)
10170         (remote_target::program_signals): Adjust.
10171         * target-debug.h (target_debug_print_signals): Now takes a
10172         gdb::array_view as parameter.  Adjust.
10173         * target.h (target_ops) <pass_signals, program_signals>: Replace
10174         pointer and length parameters with gdb::array_view.
10175         (target_pass_signals, target_program_signals): Likewise.
10176         * target-delegates.c: Regenerate.
10177
10178 2019-01-24  Pedro Alves  <palves@redhat.com>
10179
10180         * common/forward-scope-exit.h
10181         (forward_scope_exit::forward_scope_exit): Pass arguments to
10182         m_bind_function directly, instead of creating a std::bind and
10183         copying that.
10184
10185 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10186
10187         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10188         for static members.
10189         (pass_in_v_vfp_candidate): Likewise.
10190
10191 2019-01-23  Tom Tromey  <tom@tromey.com>
10192             Pedro Alves  <palves@redhat.com>
10193
10194         * regcache.c (class regcache_invalidator): Remove.
10195         (regcache::raw_write): Use make_scope_exit.
10196
10197 2019-01-23  Tom Tromey  <tom@tromey.com>
10198
10199         * ui-out.h (class ui_out_emit_type): Update comment.
10200
10201 2019-01-23  Tom Tromey  <tom@tromey.com>
10202
10203         * infrun.c (fetch_inferior_event): Update comment.
10204
10205 2019-01-23  Tom Tromey  <tom@tromey.com>
10206             Pedro Alves  <palves@redhat.com>
10207
10208         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10209         parameter.
10210         (fetch_inferior_event): Use SCOPE_EXIT.
10211
10212
10213 2019-01-23  Tom Tromey  <tom@tromey.com>
10214             Pedro Alves  <palves@redhat.com>
10215
10216         * infrun.c (disable_thread_events): Delete.
10217         (stop_all_threads): Use SCOPE_EXIT.
10218
10219 2019-01-23  Tom Tromey  <tom@tromey.com>
10220             Pedro Alves  <palves@redhat.com>
10221
10222         * symfile.c: Include forward-scope-exit.h.
10223         (clear_symtab_users_cleanup): Replace forward declaration with
10224         a FORWARD_SCOPE_EXIT.
10225         (syms_from_objfile_1): Use the forward_scope_exit and
10226         gdb::optional instead of cleanup_function.
10227         (reread_symbols): Use the forward_scope_exit instead of
10228         cleanup_function.
10229         (clear_symtab_users_cleanup): Remove function.
10230
10231 2019-01-23  Tom Tromey  <tom@tromey.com>
10232             Pedro Alves  <palves@redhat.com>
10233
10234         * linux-nat.c: Include scope-exit.h.
10235         (cleanup_target_stop): Remove.
10236         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10237         SCOPE_EXIT.
10238
10239 2019-01-23  Tom Tromey  <tom@tromey.com>
10240             Pedro Alves  <palves@redhat.com>
10241
10242         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10243         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10244
10245 2019-01-23  Tom Tromey  <tom@tromey.com>
10246             Andrew Burgess  <andrew.burgess@embecosm.com>
10247             Pedro Alves  <palves@redhat.com>
10248
10249         * infrun.c (fetch_inferior_event): Use scope_exit.
10250         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10251         * top.c (execute_command): Use scope_exit.
10252         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10253         * utils.c (do_bpstat_clear_actions_cleanup)
10254         (make_bpstat_clear_actions_cleanup): Remove.
10255
10256 2019-01-23  Tom Tromey  <tom@tromey.com>
10257             Pedro Alves  <palves@redhat.com>
10258
10259         * infrun.c: Include "common/scope-exit.h"
10260         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10261         (wait_for_inferior): Use SCOPE_EXIT.
10262         (fetch_inferior_event): Use scope_exit.
10263
10264 2019-01-23  Tom Tromey  <tom@tromey.com>
10265             Pedro Alves  <palves@redhat.com>
10266
10267         * breakpoint.c (create_breakpoint): Remove cleanup.
10268
10269 2019-01-23  Tom Tromey  <tom@tromey.com>
10270             Andrew Burgess  <andrew.burgess@embecosm.com>
10271             Pedro Alves  <palves@redhat.com>
10272
10273 2019-01-23  Pedro Alves  <palves@redhat.com>
10274
10275         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10276
10277 2019-01-23  Pedro Alves  <palves@redhat.com>
10278             Andrew Burgess  <andrew.burgess@embecosm.com>
10279
10280         * gdbthread.h: Include "common/forward-scope-exit.h".
10281         (scoped_finish_thread_state): Redefine custom class in terms of
10282         forward_scope_exit.
10283
10284 2019-01-23  Pedro Alves  <palves@redhat.com>
10285             Andrew Burgess  <andrew.burgess@embecosm.com>
10286
10287         * common/forward-scope-exit.h: New file.
10288
10289 2019-01-23  Pedro Alves  <palves@redhat.com>
10290             Andrew Burgess  <andrew.burgess@embecosm.com>
10291             Tom Tromey  <tom@tromey.com>
10292
10293         * common/scope-exit.h: New file.
10294
10295 2019-01-23  Pedro Alves  <palves@redhat.com>
10296
10297         * common/preprocessor.h (ESC): Rename to ...
10298         (ESC_PARENS): ... this.
10299         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10300         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10301
10302 2019-01-23  Tom Tromey  <tom@tromey.com>
10303
10304         * language.h (class scoped_switch_to_sym_language_if_auto):
10305         Initialize m_lang in both cases.
10306
10307 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10308
10309         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10310         with XCNEW.
10311
10312 2019-01-22  Tom Tromey  <tom@tromey.com>
10313
10314         * corelow.c: Do not include sys/file.h.
10315
10316 2019-01-22  Tom Tromey  <tom@tromey.com>
10317
10318         * tui/tui-wingeneral.h: Include gdb_curses.h.
10319
10320 2019-01-22  Tom Tromey  <tom@tromey.com>
10321
10322         * source-cache.h (class source_cache) <get_source_lines,
10323         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10324
10325 2019-01-22  Tom Tromey  <tom@tromey.com>
10326
10327         * remote-fileio.h (struct remote_target): Declare.
10328
10329 2019-01-22  Tom Tromey  <tom@tromey.com>
10330
10331         * python/py-arch.c: Do not include py-ref.h.
10332         * python/py-bpevent.c: Do not include py-ref.h.
10333         * python/py-cmd.c: Do not include py-ref.h.
10334         * python/py-continueevent.c: Do not include py-ref.h.
10335         * python/py-event.h: Do not include py-ref.h.
10336         * python/py-evtregistry.c: Do not include py-ref.h.
10337         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10338         * python/py-frame.c: Do not include py-ref.h.
10339         * python/py-framefilter.c: Do not include py-ref.h.
10340         * python/py-function.c: Do not include py-ref.h.
10341         * python/py-infevents.c: Do not include py-ref.h.
10342         * python/py-linetable.c: Do not include py-ref.h.
10343         * python/py-objfile.c: Do not include py-ref.h.
10344         * python/py-param.c: Do not include py-ref.h.
10345         * python/py-prettyprint.c: Do not include py-ref.h.
10346         * python/py-progspace.c: Do not include py-ref.h.
10347         * python/py-symbol.c: Do not include py-ref.h.
10348         * python/py-symtab.c: Do not include py-ref.h.
10349         * python/py-type.c: Do not include py-ref.h.
10350         * python/py-unwind.c: Do not include py-ref.h.
10351         * python/py-utils.c: Do not include py-ref.h.
10352         * python/py-value.c: Do not include py-ref.h.
10353         * python/py-varobj.c: Do not include py-ref.h.
10354         * python/py-xmethods.c: Do not include py-ref.h.
10355         * python/python.c: Do not include py-ref.h.
10356         * varobj.c: Do not include py-ref.h.
10357
10358 2019-01-22  Tom Tromey  <tom@tromey.com>
10359
10360         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10361         keyword for bcache.
10362
10363 2019-01-22  Tom Tromey  <tom@tromey.com>
10364
10365         * compile/compile-cplus-types.c: Remove a comment by #include.
10366
10367 2019-01-22  Tom Tromey  <tom@tromey.com>
10368
10369         * compile/gcc-c-plugin.h: Include compile-internal.h.
10370
10371 2019-01-22  Tom Tromey  <tom@tromey.com>
10372
10373         * stabsread.c (EXTERN): Do not define.
10374         (symnum, next_symbol_text_func, processing_gcc_compilation)
10375         (within_function, global_sym_chain, global_stabs)
10376         (previous_stab_code, this_object_header_files)
10377         (n_this_object_header_files)
10378         (n_allocated_this_object_header_files): Define.
10379         * stabsread.h (EXTERN): Never define.  Use "extern".
10380
10381 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10382
10383         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10384         history_value.
10385
10386 2019-01-21  Tom Tromey  <tom@tromey.com>
10387
10388         * ui-out.c: Fix includes.
10389         * tui/tui-source.c: Fix includes.
10390         * target.c: Fix includes.
10391         * remote.c: Fix includes.
10392         * regcache.c: Fix includes.
10393         * python/py-block.c: Fix includes.
10394         * printcmd.c: Fix includes.
10395         * or1k-tdep.c: Fix includes.
10396         * mi/mi-main.c: Fix includes.
10397         * m32r-tdep.c: Fix includes.
10398         * csky-tdep.c: Fix includes.
10399         * compile/compile-cplus-types.c: Fix includes.
10400         * cli/cli-interp.c: Fix includes.
10401
10402 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10403
10404         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10405         for padding.
10406
10407 2019-01-16  Tom Tromey  <tom@tromey.com>
10408
10409         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10410         earlier.
10411         (struct objfile) <msymbols_range>: Move from top level.
10412         <msymbols>: New method.
10413         (class objfile_msymbols): Remove.
10414         * symtab.c (default_collect_symbol_completion_matches_break_on):
10415         Update.
10416         * symmisc.c (dump_msymbols): Update.
10417         * stabsread.c (scan_file_globals): Update.
10418         * objc-lang.c (info_selectors_command, info_classes_command)
10419         (find_methods): Update.
10420         * minsyms.c (find_solib_trampoline_target): Update.
10421         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10422         * coffread.c (coff_symfile_read): Update.
10423         * ada-lang.c (ada_lookup_simple_minsym)
10424         (ada_collect_symbol_completion_matches): Update.
10425
10426 2019-01-16  Tom Tromey  <tom@tromey.com>
10427
10428         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10429         type.  Remove no-argument constructor.
10430         <iterator::operator++>: Simplify.
10431         <begin>: Update.
10432         <end>: Use minimal_symbol_count.
10433
10434 2019-01-16  Tom Tromey  <tom@tromey.com>
10435
10436         * objfiles.h (struct objfile) <psymtabs>: New method.
10437         (class objfile_psymtabs): Remove.
10438         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10439         typedef.
10440         <range>: New method.
10441         (require_partial_symbols): Change return type.
10442         * psymtab.c (require_partial_symbols)
10443         (psym_expand_symtabs_matching): Update.
10444         * mdebugread.c (parse_partial_symbols): Update.
10445         * dbxread.c (dbx_end_psymtab): Update.
10446
10447 2019-01-15  Tom Tromey  <tom@tromey.com>
10448
10449         * symtab.c (lookup_objfile_from_block)
10450         (lookup_symbol_in_objfile_symtabs)
10451         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10452         (find_line_symtab, info_sources_command)
10453         (default_collect_symbol_completion_matches_break_on)
10454         (make_source_files_completion_list): Update.
10455         * symmisc.c (print_objfile_statistics, dump_objfile)
10456         (maintenance_print_symbols, maintenance_info_symtabs)
10457         (maintenance_check_symtabs, maintenance_info_line_tables):
10458         Update.
10459         * source.c (select_source_symtab)
10460         (forget_cached_source_info_for_objfile): Update.
10461         * objfiles.h (class objfile_compunits): Remove.
10462         (struct objfile) <compunits_range>: New typedef.
10463         (compunits): New method.
10464         * objfiles.c (objfile_relocate1): Update.
10465         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10466         * maint.c (count_symtabs_and_blocks): Update.
10467         * linespec.c (iterate_over_all_matching_symtabs): Update.
10468         * cp-support.c (add_symbol_overload_list_qualified): Update.
10469         * coffread.c (coff_symtab_read): Update.
10470         * ada-lang.c (add_nonlocal_symbols)
10471         (ada_collect_symbol_completion_matches)
10472         (ada_add_global_exceptions): Update.
10473
10474 2019-01-15  Tom Tromey  <tom@tromey.com>
10475
10476         * progspace.h (program_space) <objfiles_safe_range>: New
10477         typedef.
10478         <objfiles_safe>: New method.
10479         * objfiles.h (class all_objfiles_safe): Remove.
10480         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10481         * jit.c (jit_inferior_exit_hook): Update.
10482
10483 2019-01-17  Tom Tromey  <tom@tromey.com>
10484
10485         * progspace.h (program_space) <objfiles_range>: New typedef.
10486         <objfiles>: New method.
10487         <objfiles_head>: Rename from objfiles.
10488         (object_files): Update.
10489         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10490         * guile/scm-pretty-print.c
10491         (ppscm_find_pretty_printer_from_objfiles): Update.
10492         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10493         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10494         Update.
10495         * python/py-progspace.c (pspy_get_objfiles): Update.
10496         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10497         Update.
10498         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10499         (objfpy_lookup_objfile_by_build_id): Update.
10500         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10501         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10502         Update.
10503         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10504         (expand_symtab_containing_pc, lookup_objfile_from_block)
10505         (lookup_static_symbol, basic_lookup_transparent_type)
10506         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10507         (find_line_symtab, info_sources_command)
10508         (default_collect_symbol_completion_matches_break_on)
10509         (make_source_files_completion_list, find_main_name): Update.
10510         * symmisc.c (print_symbol_bcache_statistics)
10511         (print_objfile_statistics, maintenance_print_symbols)
10512         (maintenance_print_msymbols, maintenance_print_objfiles)
10513         (maintenance_info_symtabs, maintenance_check_symtabs)
10514         (maintenance_expand_symtabs, maintenance_info_line_tables):
10515         Update.
10516         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10517         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10518         (map_overlay_command, unmap_overlay_command)
10519         (simple_overlay_update, expand_symtabs_matching)
10520         (map_symbol_filenames): Update.
10521         * symfile-debug.c (set_debug_symfile): Update.
10522         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10523         Update.
10524         * source.c (select_source_symtab, forget_cached_source_info):
10525         Update.
10526         * solib.c (solib_read_symbols): Update.
10527         * solib-spu.c (append_ocl_sos): Update.
10528         * psymtab.c (maintenance_print_psymbols)
10529         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10530         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10531         * printcmd.c (info_symbol_command): Update.
10532         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10533         Update.
10534         * objfiles.h (class all_objfiles): Remove.
10535         * objfiles.c (have_partial_symbols, have_full_symbols)
10536         (have_minimal_symbols, qsort_cmp, update_section_map)
10537         (shared_objfile_contains_address_p)
10538         (default_iterate_over_objfiles_in_search_order): Update.
10539         * objc-lang.c (info_selectors_command, info_classes_command)
10540         (find_methods): Update.
10541         * minsyms.c (find_solib_trampoline_target): Update.
10542         * maint.c (maintenance_info_sections)
10543         (maintenance_translate_address, count_symtabs_and_blocks):
10544         Update.
10545         * main.c (captured_main_1): Update.
10546         * linux-thread-db.c (try_thread_db_load_from_pdir)
10547         (has_libpthread): Update.
10548         * linespec.c (iterate_over_all_matching_symtabs)
10549         (search_minsyms_for_name): Update.
10550         * jit.c (jit_find_objf_with_entry_addr): Update.
10551         * hppa-tdep.c (find_unwind_entry)
10552         (hppa_lookup_stub_minimal_symbol): Update.
10553         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10554         Update.
10555         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10556         (elf_gnu_ifunc_resolve_by_got): Update.
10557         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10558         * dwarf-index-write.c (save_gdb_index_command): Update.
10559         * cp-support.c (add_symbol_overload_list_qualified): Update.
10560         * breakpoint.c (create_overlay_event_breakpoint)
10561         (create_longjmp_master_breakpoint)
10562         (create_std_terminate_master_breakpoint)
10563         (create_exception_master_breakpoint): Update.
10564         * blockframe.c (find_pc_partial_function): Update.
10565         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10566         (ada_collect_symbol_completion_matches)
10567         (ada_add_global_exceptions): Update.
10568
10569 2019-01-17  Tom Tromey  <tom@tromey.com>
10570
10571         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10572         declare VEC.
10573         (solib_target_parse_libraries): Change return type.
10574         (library_list_start_segment, library_list_start_section)
10575         (library_list_end_library, library_list_start_library); Update.
10576         (solib_target_free_library_list): Remove.
10577         (solib_target_parse_libraries): Remove cleanup.  Change return
10578         type.
10579         (solib_target_current_sos): Update.
10580
10581 2019-01-17  Tom Tromey  <tromey@bapiya>
10582
10583         * valprint.c: Replace "the the" with "the".
10584         * symtab.c: Replace "the the" with "the".
10585         * solib.c: Replace "the the" with "the".
10586         * solib-dsbt.c: Replace "the the" with "the".
10587         * linespec.c: Replace "the the" with "the".
10588         * dwarf2loc.h: Replace "the the" with "the".
10589         * amd64-windows-tdep.c: Replace "the the" with "the".
10590         * aarch64-tdep.c: Replace "the the" with "the".
10591
10592 2019-01-16  Keith Seitz  <keiths@redhat.com>
10593
10594         PR gdb/23773
10595         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10596         <builder>: Rename to ..
10597         <m_builder>: ... this and make private.
10598         (dwarf2_cu::get_builder): New method.  Change all users of
10599         `builder' to use this method.
10600         (dwarf2_start_symtab): Move to ...
10601         (dwarf2_cu::start_symtab): ... here.  Update all callers
10602         (setup_type_unit_groups): Move to ...
10603         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10604         callers.
10605         (dwarf2_cu::reset_builder): New method.
10606         (process_full_compunit, process_full_type_unit): Use
10607         dwarf2_cu::reset_builder.
10608         (follow_die_offset): Record the ancestor CU if it is different
10609         from the followed DIE's CU.
10610         (follow_die_sig_1): Likewise.
10611
10612 2019-01-15  Tom Tromey  <tom@tromey.com>
10613
10614         * remote.c (class remote_state) <buf>: Now a char_vector.
10615         <buf_size>: Remove.
10616         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10617         parameter.
10618         (remote_target::getpkt_or_notif_sane_1)
10619         (remote_target::getpkt_sane)
10620         (remote_target::getpkt_or_notif_sane): Likewise.
10621         (class remote_target) <putpkt>: New overload.
10622         (remote_target::read_frame): Change type of "buf_p".  Remove
10623         sizeof_p parameter.
10624         (packet_ok): New overload.
10625         (packet_check_result): New overload.
10626         Update all uses.
10627
10628 2019-01-14  Tom Tromey  <tom@tromey.com>
10629
10630         * remote-notif.c (handle_notification, remote_notif_ack)
10631         (remote_notif_parse): Make "buf" const.
10632         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10633         const.
10634         (remote_notif_parse, remote_notif_ack, handle_notification):
10635         Likewise.
10636         * remote.c (remote_notif_stop_parse): Make "buf" const.
10637         (remote_target::remote_parse_stop_reply): Make "buf" const.
10638         (remote_notif_stop_ack): Make "buf" const.
10639
10640 2019-01-14  Tom Tromey  <tom@tromey.com>
10641
10642         * remote.c (remote_console_output): Make parameter const.
10643
10644 2019-01-14  Tom Tromey  <tom@tromey.com>
10645
10646         * target-debug.h (target_debug_print_signals): Constify.
10647         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10648         * procfs.c (procfs_target::pass_signals): Update.
10649         * linux-nat.c (linux_nat_target::pass_signals): Update.
10650         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10651         * target-delegates.c: Rebuild.
10652         * remote.c (remote_target::program_signals): Update.
10653         (remote_target::pass_signals): Update.
10654         * target.c (target_pass_signals): Constify argument.
10655         (target_program_signals): Likewise.
10656         * target.h (struct target_ops) <pass_signals, program_signals>:
10657         Constify argument.
10658         (target_pass_signals, target_program_signals): Constify argument.
10659
10660 2019-01-14  Tom Tromey  <tom@tromey.com>
10661
10662         PR tui/28819:
10663         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10664
10665 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10666
10667         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10668         field.
10669         * rs6000-tdep.c: Include reggroups.h.
10670         (IS_V_ALIAS_PSEUDOREG): Define.
10671         (rs6000_register_name): Return names for the "vX" aliases.
10672         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10673         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10674         aliases.  Call default_register_reggroup_p for all other
10675         pseudo-registers.
10676         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10677         New functions.
10678         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10679         Handle "vX" aliases.
10680         (v_alias_pseudo_register_collect): New function.
10681         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10682         (rs6000_gdbarch_init): Initialize "vX" aliases as
10683         pseudo-registers.  Restore registration of
10684         rs6000_pseudo_register_reggroup_p with
10685         set_tdesc_pseudo_register_reggroup_p.
10686
10687 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10688
10689         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10690         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10691         set_gdbarch_num_pseudo_regs.
10692
10693 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10694
10695         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10696         Remove arg prefixname, add do_set and do_show.
10697         Add member functions set_list and show_list.
10698         * cli/cli-style.c (class cli_style_option): Update accordingly.
10699         (style_set_list): Move to file scope.
10700         (style_show_list): Likewise.
10701         (set_style): Call help_list.
10702         (show_style): Call cmd_show_list.
10703         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10704         Update to use the new macro.
10705
10706 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10707
10708         * ada-lang.c (_initialize_ada_language): Expand the help text
10709         for the "catch exception" command.
10710
10711 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10712
10713         * symtab.c (matching_obj_sections): Initialize obj,
10714         declare it closer to its usage.
10715
10716 2019-01-10  Tom Tromey  <tom@tromey.com>
10717
10718         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10719         (basic_inf_threads_range): Remove.
10720         (inf_threads_range, inf_non_exited_threads_range)
10721         (safe_inf_threads_range): Use next_adapter.
10722
10723 2019-01-10  Keith Seitz  <keiths@redhat.com>
10724
10725         PR gdb/23712
10726         PR symtab/23010
10727         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10728         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10729
10730 2019-01-10  Keith Seitz  <keiths@redhat.com>
10731
10732         PR gdb/23712
10733         PR symtab/23010
10734         * dictionary.c (pending_to_vector): Remove.
10735         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10736         Remove _1 suffix, replacing functions of the same name.  Update
10737         all callers.
10738         (dict_create_hashed, dict_create_hashed_expandable)
10739         (dict_create_linear, dict_create_linear_expandable, dict_free)
10740         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10741         Make functions static.
10742
10743 2019-01-10  Keith Seitz  <keiths@redhat.com>
10744
10745         PR gdb/23712
10746         PR symtab/23010
10747         * dictionary.h (struct dictionary): Replace declaration with
10748         multidictionary.
10749         (dict_create_hashed, dict_create_hashed_expandable)
10750         (dict_create_linear, dict_create_linear_expandable)
10751         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10752         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10753         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10754         taking multidictionary argument.
10755         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10756         * block.h (struct block) <dict>: Change to multidictionary
10757         and rename `multidict'.
10758         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10759         symmisc.c: Update all dictionary references to multidictionary.
10760
10761 2019-01-10  Keith Seitz  <keiths@redhat.com>
10762
10763         PR gdb/23712
10764         PR symtab/23010
10765         * dictionary.c: Include unordered_map.
10766         (pending_to_vector): New function.
10767         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10768         Rewrite the non-"_1" functions to take vector instead
10769         of linked list.
10770         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10771         "new" _1 versions of the same name.
10772         (multidictionary): Define.
10773         (std::hash<enum language): New definition.
10774         (collate_pending_symbols_by_language, mdict_create_hashed)
10775         (mdict_create_hashed_expandable, mdict_create_linear)
10776         (mdict_create_linear_expandable, mdict_free)
10777         (find_language_dictionary, create_new_language_dictionary)
10778         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10779         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10780         (mdict_size, mdict_empty): New functions.
10781         * dictionary.h (mdict_iterator): Define.
10782
10783 2019-01-10  Pedro Alves  <palves@redhat.com>
10784
10785         * breakpoint.c (read_uploaded_action)
10786         (create_tracepoint_from_upload): Adjust to use
10787         gdb::unique_xmalloc_ptr.
10788         * ctf.c (ctf_write_uploaded_tp):
10789         (SET_ARRAY_FIELD): Use emplace_back.
10790         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10791         * tracefile-tfile.c (tfile_write_uploaded_tp):
10792         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10793         gdb::unique_xmalloc_ptr.
10794         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10795         at_string, cond_string, cmd_strings>: Replace char pointers
10796         with gdb::unique_xmalloc_ptr.
10797
10798 2019-01-10  Pedro Alves  <palves@redhat.com>
10799
10800         * solib-target.c (library_list_start_library): Don't xstrdup name.
10801
10802 2019-01-10  Pedro Alves  <palves@redhat.com>
10803
10804         * mdebugread.c (parse_partial_symbols): Use
10805         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10806
10807 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * linux-fork.c (scoped_switch_fork_info)
10810         <~scoped_switch_fork_info>: Fix incorrect variable name.
10811
10812 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10813
10814         * linux-fork.c (scoped_switch_fork_info)
10815         <scoped_switch_fork_info>: Make explicit.
10816         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10817
10818 2019-01-10  Tom Tromey  <tom@tromey.com>
10819
10820         * objfiles.h (objfile::reset_psymtabs): Update.
10821         * objfiles.c (objfile::objfile): Update.
10822         * psymtab.h (psymtab_storage::obstack): Update.
10823         (psymtab_storage::m_obstack): Use gdb::optional.
10824         (class psymtab_storage): Update comment.  Remove objfile
10825         parameter.
10826         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10827
10828 2019-01-10  Tom Tromey  <tom@tromey.com>
10829
10830         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
10831         <free_psymtabs>: Now private.
10832         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
10833         (allocate_psymtab): Use new method.
10834
10835 2019-01-10  Tom Tromey  <tom@tromey.com>
10836
10837         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
10838         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
10839         * mdebugread.c (parse_partial_symbols): Use
10840         allocate_dependencies.
10841         * dwarf2read.c (dwarf2_create_include_psymtab): Use
10842         allocate_dependencies.
10843         (process_psymtab_comp_unit_reader)
10844         (build_type_psymtab_dependencies): Likewise.
10845         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
10846
10847 2019-01-10  Tom Tromey  <tom@tromey.com>
10848
10849         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
10850         PSYMBOL_SET_LANGUAGE.
10851         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
10852
10853 2019-01-10  Tom Tromey  <tom@tromey.com>
10854
10855         * psymtab.h (psymtab_storage::obstack): New method.
10856         <m_obstack>: Rename from obstack; now private.
10857         * psymtab.c (psymtab_storage): Update.
10858         * dwarf2read.c (create_addrmap_from_index)
10859         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
10860         Update.
10861
10862 2019-01-10  Tom Tromey  <tom@tromey.com>
10863
10864         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
10865         * objfiles.h (objfile::reset_psymtabs): New method.
10866
10867 2019-01-10  Tom Tromey  <tom@tromey.com>
10868
10869         * symmisc.c (print_symbol_bcache_statistics): Update.
10870         (print_objfile_statistics): Update.
10871         * symfile.c (reread_symbols): Update.
10872         * psymtab.h (class psymtab_storage): New.
10873         * psymtab.c (psymtab_storage): New constructor.
10874         (~psymtab_storage): New destructor.
10875         (require_partial_symbols): Update.
10876         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
10877         (find_pc_sect_psymtab, find_pc_sect_psymbol)
10878         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
10879         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10880         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10881         (start_psymtab_common, end_psymtab_common)
10882         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10883         (allocate_psymtab): Update.
10884         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10885         Update.
10886         (dump_psymtab_addrmap, maintenance_print_psymbols)
10887         (maintenance_check_psymtabs): Update.
10888         (class objfile_psymtabs): Move to objfiles.h.
10889         * psympriv.h (discard_psymtab): Now inline.
10890         (psymtab_discarder::psymtab_discarder): Update.
10891         (psymtab_discarder::~psymtab_discarder): Update.
10892         (ALL_OBJFILE_PSYMTABS): Rewrite.
10893         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10894         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10895         Remove fields.
10896         <partial_symtabs>: New field.
10897         (class objfile_psymtabs): Move from psymtab.h.  Update.
10898         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10899         psymbol_cache.
10900         (objfile::~objfile): Don't destroy psymbol_cache.
10901         * mdebugread.c (parse_partial_symbols): Update.
10902         * dwarf2read.c (create_addrmap_from_index)
10903         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10904         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10905         (add_partial_subprogram, dwarf2_ranges_read): Update.
10906         * dwarf-index-write.c (write_address_map)
10907         (write_one_signatured_type, recursively_write_psymbols)
10908         (class debug_names, class debug_names, write_psymtabs_to_index):
10909         Update.
10910
10911 2019-01-10  Tom Tromey  <tom@tromey.com>
10912
10913         * symtab.h (SYMBOL_SET_NAMES): Update.
10914         (symbol_set_names): Update.
10915         (MSYMBOL_SET_NAMES): Update.
10916         * symtab.c (symbol_set_names): Change argument to be an
10917         objfile_per_bfd_storage.
10918         * psymtab.c (add_psymbol_to_bcache): Update.
10919         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10920
10921 2019-01-10  Tom Tromey  <tom@tromey.com>
10922
10923         * symtab.c (create_demangled_names_hash): Change argument to be an
10924         objfile_per_bfd_storage.
10925         (symbol_set_names): Update.
10926
10927 2019-01-10  Tom Tromey  <tom@tromey.com>
10928
10929         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10930         init_psymbol_list.
10931         * psymtab.c (init_psymbol_list): Do nothing if already called.
10932         * psympriv.h (init_psymbol_list): Add comment.
10933         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10934         init_psymbol_list.
10935         * dbxread.c (dbx_symfile_read): Unconditionally call
10936         init_psymbol_list.
10937
10938 2019-01-10  Tom Tromey  <tom@tromey.com>
10939
10940         * xcoffread.c (scan_xcoff_symtab): Update.
10941         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10942         "where".
10943         * mdebugread.c (parse_partial_symbols)
10944         (handle_psymbol_enumerators): Update.
10945         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10946         * dbxread.c (read_dbx_symtab): Update.
10947         * psympriv.h (psymbol_placement): New enum.
10948         (add_psymbol_to_list): Update.
10949
10950 2019-01-10  Tom Tromey  <tom@tromey.com>
10951
10952         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10953         static_psymbols parameters.
10954         (scan_xcoff_symtab): Update.
10955         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10956         static_psymbols parameters.
10957         * psympriv.h (start_psymtab_common): Update.
10958         * mdebugread.c (parse_partial_symbols): Update.
10959         * dwarf2read.c (create_partial_symtab): Update.
10960         * dbxread.c (read_dbx_symtab): Update.
10961         (start_psymtab): Remove global_psymbols and static_psymbols
10962         parameters.
10963
10964 2019-01-10  Tom Tromey  <tom@tromey.com>
10965
10966         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10967         * psymtab.c (allocate_psymtab): Add comment.
10968         * psympriv.h (allocate_psymtab): Add comment.
10969         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10970         initializations.
10971         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10972
10973 2019-01-10  Tom Tromey  <tom@tromey.com>
10974
10975         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10976         Don't declare.
10977         * mipsread.c: Include mdebugread.h.
10978         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10979         Declare.
10980         * elfread.c: Include mdebugread.h.
10981
10982 2019-01-09  Tom Tromey  <tom@tromey.com>
10983
10984         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10985         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10986         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10987         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10988         (psym_lookup_symbol, psym_find_last_source_symtab)
10989         (psym_forget_cached_source_info, psym_print_stats)
10990         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10991         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10992         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10993         (psym_find_compunit_symtab_by_address)
10994         (maintenance_print_psymbols, maintenance_info_psymtabs)
10995         (maintenance_check_psymtabs): Use ranged for.
10996         * psymtab.h (class objfile_psymtabs): New.
10997         (require_partial_symbols): Return objfile_psymtabs.
10998         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10999
11000 2019-01-09  Tom Tromey  <tom@tromey.com>
11001
11002         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11003         (find_pc_mapped_section, list_overlays_command)
11004         (map_overlay_command, unmap_overlay_command)
11005         (simple_overlay_update): Use all_objfiles.
11006         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11007         * printcmd.c (info_symbol_command): Use all_objfiles.
11008         * objfiles.h (ALL_OBJSECTIONS): Remove.
11009         * maint.c (maintenance_translate_address): Use all_objfiles.
11010         * gcore.c (gcore_create_callback): Use all_objfiles.
11011         (objfile_find_memory_regions): Likewise.
11012
11013 2019-01-09  Tom Tromey  <tom@tromey.com>
11014
11015         * symtab.c (find_line_symtab, info_sources_command)
11016         (make_source_files_completion_list): Use objfile_compunits.
11017         * source.c (select_source_symtab): Use objfile_compunits.
11018         * objfiles.h (struct objfile): Update comment.
11019         (ALL_OBJFILES): Remove.
11020         (ALL_FILETABS): Remove.
11021         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11022         objfile_compunits.
11023
11024 2019-01-09  Tom Tromey  <tom@tromey.com>
11025
11026         * symmisc.c (print_objfile_statistics, dump_objfile)
11027         (maintenance_print_symbols): Use compunit_filetabs.
11028         * source.c (forget_cached_source_info_for_objfile): Use
11029         compunit_filetabs.
11030         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11031         (ALL_FILETABS): Use compunit_filetabs.
11032         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11033         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11034
11035 2019-01-09  Tom Tromey  <tom@tromey.com>
11036
11037         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11038         (compunit_filetabs): New.
11039         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11040         compunit_filetabs.
11041         (info_sources_command, make_source_files_completion_list): Remove
11042         declaration.
11043         * symmisc.c (print_objfile_statistics, dump_objfile)
11044         (maintenance_print_symbols): Remove declaration.
11045         (maintenance_info_symtabs): Use compunit_filetabs.
11046         (maintenance_info_line_tables): Likewise.
11047         * source.c (select_source_symtab): Change local variable name.
11048         (forget_cached_source_info_for_objfile): Remove declaration.
11049         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11050         * objfiles.c (objfile_relocate1): Remove declaration.
11051         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11052         declaration.
11053         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11054         * coffread.c (coff_symtab_read): Remove declaration.
11055         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11056         compunit_filetabs.
11057
11058 2019-01-09  Tom Tromey  <tom@tromey.com>
11059
11060         * symtab.c (lookup_objfile_from_block)
11061         (find_pc_sect_compunit_symtab, search_symbols)
11062         (default_collect_symbol_completion_matches_break_on): Use
11063         objfile_compunits.
11064         * objfiles.h (ALL_COMPUNITS): Remove.
11065         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11066         * cp-support.c (add_symbol_overload_list_qualified): Use
11067         objfile_compunits.
11068         * ada-lang.c (ada_collect_symbol_completion_matches)
11069         (ada_add_global_exceptions): Use objfile_compunits.
11070
11071 2019-01-09  Tom Tromey  <tom@tromey.com>
11072
11073         * source.c (select_source_symtab)
11074         (forget_cached_source_info_for_objfile): Remove declaration.
11075         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11076         declaration.
11077         * maint.c (count_symtabs_and_blocks): Remove declaration.
11078         * cp-support.c (add_symbol_overload_list_qualified): Remove
11079         declaration.
11080         * coffread.c (coff_symtab_read): Remove declaration.
11081         * symtab.c (lookup_symbol_in_objfile_symtabs)
11082         (basic_lookup_transparent_type_1): Use objfile_compunits.
11083         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11084         (info_sources_command, search_symbols)
11085         (default_collect_symbol_completion_matches_break_on)
11086         (make_source_files_completion_list): Remove declaration.
11087         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11088         (ada_collect_symbol_completion_matches)
11089         (ada_add_global_exceptions): Remove declaration.
11090         * linespec.c (iterate_over_all_matching_symtabs): Use
11091         objfile_compunits.
11092         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11093         (class objfile_compunits): New.
11094         (ALL_COMPUNITS): Use objfile_compunits.
11095         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11096         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11097         objfile_compunits.
11098         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11099
11100 2019-01-09  Tom Tromey  <tom@tromey.com>
11101
11102         * symtab.c (search_symbols)
11103         (default_collect_symbol_completion_matches_break_on): Use
11104         objfile_msymbols.
11105         * ada-lang.c (ada_lookup_simple_minsym)
11106         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11107         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11108         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11109         objfile_msymbols.
11110         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11111         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11112         * objc-lang.c (find_methods): Use objfile_msymbols.
11113         (info_selectors_command, info_classes_command): Likewise.
11114         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11115         * objfiles.h (class objfile_msymbols): New.
11116         (ALL_OBJFILE_MSYMBOLS): Remove.
11117         (ALL_MSYMBOLS): Remove.
11118
11119 2019-01-09  Tom Tromey  <tom@tromey.com>
11120
11121         * common/next-iterator.h (next_adapter): Add Iterator template
11122         parameter.
11123         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11124         (class all_objfiles_safe): New.
11125         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11126         * objfiles.c (put_objfile_before): Update comment.
11127         (add_separate_debug_objfile): Likewise.
11128         (free_all_objfiles): Use all_objfiles_safe.
11129         (objfile_purge_solibs): Likewise.
11130
11131 2019-01-09  Tom Tromey  <tom@tromey.com>
11132
11133         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11134         (expand_symtab_containing_pc, lookup_static_symbol)
11135         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11136         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11137         all_objfiles.
11138         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11139         * breakpoint.c (create_overlay_event_breakpoint)
11140         (create_longjmp_master_breakpoint)
11141         (create_std_terminate_master_breakpoint)
11142         (create_exception_master_breakpoint): Use all_objfiles.
11143         * linux-thread-db.c (try_thread_db_load_from_pdir)
11144         (has_libpthread): Use all_objfiles.
11145         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11146         * linespec.c (iterate_over_all_matching_symtabs)
11147         (search_minsyms_for_name): Use all_objfiles.
11148         * maint.c (maintenance_info_sections): Use all_objfiles.
11149         * main.c (captured_main_1): Use all_objfiles.
11150         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11151         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11152         * guile/scm-pretty-print.c
11153         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11154         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11155         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11156         (maintenance_print_msymbols): Use all_objfiles.
11157         * source.c (select_source_symtab): Use all_objfiles.
11158         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11159         * symfile.c (remove_symbol_file_command)
11160         (expand_symtabs_matching, map_symbol_filenames): Use
11161         all_objfiles.
11162         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11163         all_objfiles.
11164         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11165         * objc-lang.c (find_methods): Use all_objfiles.
11166         * objfiles.c (have_partial_symbols, have_full_symbols)
11167         (have_minimal_symbols, qsort_cmp)
11168         (default_iterate_over_objfiles_in_search_order): Use
11169         all_objfiles.
11170         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11171         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11172         (maintenance_check_psymtabs): Use all_objfiles.
11173         (ALL_PSYMTABS): Remove.
11174         * compile/compile-object-run.c (do_module_cleanup): Use
11175         all_objfiles.
11176         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11177         * cp-support.c (add_symbol_overload_list_qualified): Use
11178         all_objfiles.
11179         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11180         Use all_objfiles.
11181         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11182         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11183         all_objfiles.
11184         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11185         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11186         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11187         Uses all_objfiles.
11188         * solib.c (solib_read_symbols): Use all_objfiles
11189
11190 2019-01-09  Tom Tromey  <tom@tromey.com>
11191
11192         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11193         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11194         all_objfiles.
11195         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11196         * symmisc.c (print_symbol_bcache_statistics)
11197         (print_objfile_statistics, maintenance_print_objfiles)
11198         (maintenance_info_symtabs, maintenance_check_symtabs)
11199         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11200         all_objfiles.
11201         * source.c (forget_cached_source_info): Use all_objfiles.
11202         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11203         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11204         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11205         * objfiles.c (update_section_map): Use all_objfiles.
11206         (shared_objfile_contains_address_p): Likewise.
11207         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11208         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11209
11210 2019-01-09  Tom Tromey  <tom@tromey.com>
11211
11212         * common/next-iterator.h: New file.
11213         * objfiles.h (class all_objfiles): New.
11214         (struct objfile_iterator): New.
11215
11216 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11217
11218         * NEWS: Move the description of the changed "frame", "select-frame",
11219          and "info frame" commands to the Changed commands section.
11220
11221 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11222
11223         * gdbtypes.c (check_stub_method_group): Remove handling of old
11224         mangling schemes.
11225         * linespec.c (find_methods): Likewise.
11226         * stabsread.c (read_member_functions): Likewise.
11227         * valops.c (search_struct_method): Likewise.
11228         (value_struct_elt_for_reference): Likewise.
11229         * NEWS: Mention this change.
11230
11231 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11232
11233         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11234         print_source_lines.
11235         * source.c (print_source_lines_base): Update line number check.
11236         (print_source_lines): New function.
11237         (source_lines_range::source_lines_range): New function.
11238         * source.h (class source_lines_range): New class.
11239         (print_source_lines): New declaration.
11240
11241 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11242
11243         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11244
11245 2019-01-08  Tom Tromey  <tom@tromey.com>
11246             Simon Marchi  <simon.marchi@ericsson.com>
11247
11248         PR gdb/24060
11249         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11250         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11251         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11252         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11253         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11254         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11255
11256 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11257
11258         * source.c (select_source_symtab): Move header comment to
11259         declaration in source.h.
11260         (forget_cached_source_info_for_objfile): Likewise.
11261         (forget_cached_source_info): Likewise.
11262         (identify_source_line): Likewise.
11263         * source.h (identify_source_line): Move declaration from symtab.h
11264         and add comment from source.c
11265         (print_source_lines): Likewise.
11266         (forget_cached_source_info_for_objfile): Likewise.
11267         (forget_cached_source_info): Likewise.
11268         (select_source_symtab): Likewise.
11269         (enum print_source_lines_flag): Move definition from symtab.h.
11270         * symtab.h (identify_source_line): Move declaration to source.h.
11271         (print_source_lines): Likewise.
11272         (forget_cached_source_info_for_objfile): Likewise.
11273         (forget_cached_source_info): Likewise.
11274         (select_source_symtab): Likewise.
11275         (enum print_source_lines_flag): Move definition to source.h.
11276         * tui/tui-hooks.c: Add 'source.h' include.
11277
11278 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11279
11280         * source.c (print_source_lines_base): Handle requests to print
11281         reverse line number sequences, and guard against empty lines
11282         string.
11283
11284 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11285
11286         * source.c (print_source_lines_base): Fix skip of '\r' if next
11287         character is '\n'.
11288
11289 2019-01-06  Tom Tromey  <tom@tromey.com>
11290
11291         * c-exp.y (struct c_parse_state) <macro_original_text,
11292         expansion_obstack>: New member.
11293         (macro_original_text, expansion_obstack): Remove globals.
11294         (scan_macro_expansion, scanning_macro_expansion)
11295         (finished_macro_expansion): Update.
11296         (scan_macro_cleanup): Remove.
11297         (yylex, c_parse): Update.
11298
11299 2019-01-06  Tom Tromey  <tom@tromey.com>
11300
11301         * c-exp.y (struct c_parse_state) <strings>: New member.
11302         (operator_stoken): Update.
11303
11304 2019-01-06  Tom Tromey  <tom@tromey.com>
11305
11306         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11307         (union type_stack_elt) <typelist_val>: Now a pointer to
11308         std::vector.
11309         (type_stack_cleanup): Don't declare.
11310         (push_typelist): Update.
11311         * parse.c (pop_typelist): Return a std::vector.
11312         (push_typelist): Take a std::vector.
11313         (follow_types): Update.  Do not free args.
11314         (type_stack_cleanup): Remove.
11315         * c-exp.y (struct c_parse_state): New.
11316         (cpstate): New global.
11317         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11318         (nonempty_typelist): Update.
11319         (func_mod): Create a new vector.
11320         (c_parse): Create a c_parse_state.
11321         (check_parameter_typelist): Do not delete params.
11322         (function_method): Update.  Do not delete type_list.
11323
11324 2019-01-06  Tom Tromey  <tom@tromey.com>
11325
11326         PR gdb/28155:
11327         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11328         check_typedef.
11329         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11330         (print_return_value): Likewise.
11331
11332 2019-01-05  Tom Tromey  <tom@tromey.com>
11333
11334         * contrib/cleanup_check.py: Remove.
11335         * contrib/gcc-with-excheck: Remove.
11336         * contrib/exsummary.py: Remove.
11337         * contrib/excheck.py: Remove.
11338
11339 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11340
11341         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11342         NULL. Initialize tpprev to NULL instead of assigning it
11343         to NULL on the next statement.
11344         * windows-nat.c (windows_delete_thread): Remove check for
11345         main_thread_id before printing thread exit notifications.
11346         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11347         Remove thread ID check against main_thread_id.
11348         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11349         windows_delete_thread.
11350         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11351
11352 2019-01-04  Tom Tromey  <tom@tromey.com>
11353
11354         * compile/compile.c (_initialize_compile): Use upper case for
11355         metasyntactic variables.
11356         * symmisc.c (_initialize_symmisc): Use upper case for
11357         metasyntactic variables.
11358         * psymtab.c (_initialize_psymtab): Use upper case for
11359         metasyntactic variables.
11360         * demangle.c (demangle_command): Use upper case for metasyntactic
11361         variables.
11362         (_initialize_demangler): Likewise.
11363         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11364         variables.
11365
11366 2019-01-03  Tom Tromey  <tom@tromey.com>
11367
11368         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11369
11370 2019-01-03  Tom Tromey  <tom@tromey.com>
11371
11372         * python/py-symtab.c (salpy_str): Update.
11373         (struct salpy_sal_object) <symtab>: Now a PyObject.
11374         (salpy_dealloc): Update.
11375         (del_objfile_sal): Use gdbpy_ref.
11376
11377 2019-01-03  Tom Tromey  <tom@tromey.com>
11378
11379         * python/py-type.c (convert_field): Use new_reference.  Return
11380         gdbpy_ref.
11381         (make_fielditem): Return gdbpy_ref.
11382         (typy_fields): Update.
11383         (typy_getitem): Update.
11384         (field_name): Return gdbpy_ref.  Use new_reference.
11385         (typy_iterator_iternext): Update.
11386
11387 2019-01-03  Tom Tromey  <tom@tromey.com>
11388
11389         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11390
11391 2019-01-03  Tom Tromey  <tom@tromey.com>
11392
11393         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11394         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11395         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11396         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11397         (pspy_set_type_printers): Likewise.
11398         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11399         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11400         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11401         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11402         (objfpy_set_type_printers): Likewise.
11403
11404 2019-01-03  Tom Tromey  <tom@tromey.com>
11405
11406         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11407         (gdbpy_print_stack): Use gdbpy_err_fetch.
11408         * python/python-internal.h (class gdbpy_err_fetch): New class.
11409         (class gdbpy_enter) <m_error_type, m_error_value,
11410         m_error_traceback>: Remove.
11411         <m_error>: New member.
11412         (gdbpy_exception_to_string): Don't declare.
11413         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11414         * python/py-value.c (convert_value_from_python): Use
11415         gdbpy_err_fetch.
11416         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11417         gdbpy_exception_to_string.
11418         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11419         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11420         gdbpy_err_fetch.
11421
11422 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11423
11424         * linux-nat.c (delete_lwp_cleanup): Delete.
11425         (struct lwp_deleter): New struct.
11426         (lwp_info_up): New typedef.
11427         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11428         lwp_info_up.
11429
11430 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11431
11432         * linux-fork.c (class scoped_switch_fork_info): New class.
11433         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11434
11435 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11436
11437         * valops.c (find_overload_match): Remove use of null_cleanup, and
11438         calls to do_cleanups.
11439
11440 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11441
11442         * compile/compile-cplus-types.c
11443         (compile_cplus_instance::decl_name): Handle changes to
11444         cp_func_name.
11445         * cp-support.c (cp_func_name): Update header comment, update
11446         return type.
11447         * cp-support.h (cp_func_name): Update return type in declaration.
11448         * valops.c (find_overload_match): Move temp_func local to top
11449         level of function and change its type.  Use temp_func to hold and
11450         delete temporary string obtained from cp_func_name.
11451
11452 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11453
11454         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11455         gdb::char_vector, remove cleanup, and update uses of `msg`.
11456
11457 2019-01-03  Jim Wilson  <jimw@sifive.com>
11458
11459         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11460
11461 2019-01-02  Tom Tromey  <tom@tromey.com>
11462
11463         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11464         (tdesc_parse_xml): Remove cleanups.
11465         * target-descriptions.h (make_cleanup_free_target_description):
11466         Don't declare.
11467         (target_desc_deleter): New struct.
11468         (target_desc_up): New typedef.
11469         * target-descriptions.c (target_desc_deleter::operator()): Rename
11470         from free_target_description.
11471         (make_cleanup_free_target_description): Remove.
11472
11473 2019-01-02  Tom Tromey  <tom@tromey.com>
11474
11475         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11476         constructor, destructor.
11477         (linespec_parser): Remove typedef.
11478         (~linespec_parser): Rename from linespec_parser_delete.
11479         (linespec_lex_to_end, linespec_complete_label)
11480         (linespec_complete): Update.
11481         (decode_line_full): Remove cleanups.
11482         (decode_line_1): Update.
11483
11484 2019-01-02  Tom Tromey  <tom@tromey.com>
11485
11486         * python/python-internal.h (inferior_to_inferior_object): Change
11487         return type.
11488         * python/py-exitedevent.c (create_exited_event_object): Update.
11489         * python/py-inferior.c (inferior_to_inferior_object): Return
11490         gdbpy_ref.
11491         (python_new_inferior, python_inferior_deleted)
11492         (thread_to_thread_object, delete_thread_object)
11493         (build_inferior_list, gdbpy_selected_inferior): Update.
11494         * python/py-infthread.c (create_thread_object): Update.  Also fail
11495         if inferior_to_inferior_object fails.
11496
11497 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11498
11499         * inferior.h (class inferior) <displaced_step_state>: New field.
11500         * infrun.h (struct displaced_step_state): Move here from
11501         infrun.c.  Initialize fields, add constructor.
11502         <inf>: Remove field.
11503         <reset>: New method.
11504         * infrun.c (struct displaced_step_inferior_state): Move to
11505         infrun.h.
11506         (displaced_step_inferior_states): Remove.
11507         (get_displaced_stepping_state): Adust.
11508         (displaced_step_in_progress_any_inferior): Adjust.
11509         (displaced_step_in_progress_thread): Adjust.
11510         (displaced_step_in_progress): Adjust.
11511         (add_displaced_stepping_state): Remove.
11512         (get_displaced_step_closure_by_addr): Adjust.
11513         (remove_displaced_stepping_state): Remove.
11514         (infrun_inferior_exit): Call displaced_step_state.reset.
11515         (use_displaced_stepping): Don't check for NULL.
11516         (displaced_step_prepare_throw): Call
11517         get_displaced_stepping_state.
11518         (displaced_step_fixup): Don't check for NULL.
11519         (prepare_for_detach): Don't check for NULL.
11520
11521 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11522
11523         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11524          in case of call that did not complete.
11525
11526 2019-01-02  Andrey Utkin  <autkin@undo.io>
11527
11528         * symfile.c (find_separate_debug_file): Fix search of debug files for
11529         remote debuggee.
11530
11531 2019-01-02  Tom Tromey  <tom@tromey.com>
11532
11533         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11534         indentation.
11535         * python/py-frame.c (frapy_older): Remove cast.
11536         (frapy_newer): Likewise.
11537         * python/py-breakpoint.c (local_setattro): Remove cast.
11538         * python/py-arch.c (archpy_name): Remove local variable.
11539         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11540
11541 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11542
11543         * unittests/basic_string_view/element_access/char/empty.cc:
11544         Fix year range in copyright header.
11545
11546 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11547
11548         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11549         Delete.
11550         <operator==>: Update with for removed field.
11551         <hash>: Likewise.
11552         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11553         <isa_features>: ...this.
11554         <abi_features>: New field.
11555         (riscv_isa_flen): Update comment.
11556         (riscv_abi_xlen): New declaration.
11557         (riscv_abi_flen): New declaration.
11558         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11559         isa_features.
11560         (riscv_abi_xlen): New function.
11561         (riscv_isa_flen): Update to get answer from isa_features.
11562         (riscv_abi_flen): New function.
11563         (riscv_has_fp_abi): Update to get answer from abi_features.
11564         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11565         xlen and flen.
11566         (riscv_call_info) <xlen, flen>: Update comment.
11567         (riscv_call_arg_struct): Remove invalid assertions
11568         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11569         is removed.
11570         (riscv_gdbarch_init): Gather isa features and abi features
11571         separately, ensure both match on the gdbarch when reusing an old
11572         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11573         a target with 64-bit float hardware.
11574
11575 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11576
11577         * source.c (search_command_helper): Stop reverse search
11578         when line 1 has been searched.
11579
11580 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11581
11582         * record-full.c (record_full_base_target::close): Rewrite
11583         record_full_core_buf_list free logic.
11584
11585 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11586
11587         * break-catch-syscall.c (print_one_catch_syscall): xfree
11588         the last text.
11589
11590 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11591
11592         * top.c (print_gdb_version): Update Copyright year in version
11593         message.
11594
11595 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11596
11597         Update copyright year range in all GDB files.
11598
11599 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11600
11601         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11602
11603 For older changes see ChangeLog-2018.
11604 \f
11605 Local Variables:
11606 mode: change-log
11607 left-margin: 8
11608 fill-column: 74
11609 version-control: never
11610 coding: utf-8
11611 End:
11612