gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * xcoffread.c (struct xcoff_symfile_info): Rename from
   4         coff_symfile_info.  Add initializers.
   5         (xcoff_objfile_data_key): Move lower.  Change type.
   6         (XCOFF_DATA): Rewrite.
   7         (xcoff_free_info): Remove.
   8         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
   9         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
  10         (xcoff_initial_scan): Update.
  11
  12 2019-05-08  Tom Tromey  <tom@tromey.com>
  13
  14         * solib-svr4.c (struct svr4_info): Add initializers and
  15         destructor.
  16         <probes_table>: Now an htab_up.
  17         (solib_svr4_pspace_data): Change type.
  18         (free_probes_table): Simplify.
  19         (~svr4_info): Rename from svr4_pspace_data_cleanup.
  20         (get_svr4_info, probes_table_htab_remove_objfile_probes)
  21         (probes_table_remove_objfile_probes, register_solib_event_probe)
  22         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
  23         (_initialize_svr4_solib): Update.
  24
  25 2019-05-08  Tom Tromey  <tom@tromey.com>
  26
  27         * remote.c (remote_pspace_data): Change type.
  28         (remote_pspace_data_cleanup): Remove.
  29         (get_remote_exec_file, set_pspace_remote_exec_file)
  30         (_initialize_remote): Update.
  31
  32 2019-05-08  Tom Tromey  <tom@tromey.com>
  33
  34         * breakpoint.c (breakpoint_objfile_key): Change type.
  35         (get_breakpoint_objfile_data): Update.
  36         (free_breakpoint_objfile_data): Remove.
  37         (_initialize_breakpoint): Update.
  38
  39 2019-05-08  Tom Tromey  <tom@tromey.com>
  40
  41         * linux-tdep.c (struct linux_info): Add initializers.
  42         (linux_inferior_data): Move.  Change type.
  43         (invalidate_linux_cache_inf): Update.
  44         (linux_inferior_data_cleanup): Remove.
  45         (get_linux_inferior_data, _initialize_linux_tdep): Update.
  46
  47 2019-05-08  Tom Tromey  <tom@tromey.com>
  48
  49         * auxv.c (auxv_inferior_data): Move.  Change type.
  50         (auxv_inferior_data_cleanup): Remove.
  51         (invalidate_auxv_cache_inf): Rewrite.
  52         (get_auxv_inferior_data, _initialize_auxv): Update.
  53
  54 2019-05-08  Tom Tromey  <tom@tromey.com>
  55
  56         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
  57         (symfile_debug_objfile_data_key): Change type.
  58         (symfile_debug_installed, debug_qf_has_symbols)
  59         (debug_qf_find_last_source_symtab)
  60         (debug_qf_forget_cached_source_info)
  61         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
  62         (debug_qf_print_stats, debug_qf_dump)
  63         (debug_qf_expand_symtabs_for_function)
  64         (debug_qf_expand_all_symtabs)
  65         (debug_qf_expand_symtabs_with_fullname)
  66         (debug_qf_map_matching_symbols)
  67         (debug_qf_expand_symtabs_matching)
  68         (debug_qf_find_pc_sect_compunit_symtab)
  69         (debug_qf_map_symbol_filenames)
  70         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
  71         (debug_sym_new_init, debug_sym_init, debug_sym_read)
  72         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
  73         (debug_sym_read_linetable, debug_sym_relocate): Update.
  74         (symfile_debug_free_objfile): Remove.
  75         (install_symfile_debug_logging, _initialize_symfile_debug):
  76         Update.
  77
  78 2019-05-08  Tom Tromey  <tom@tromey.com>
  79
  80         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
  81         allocate_on_obstack.
  82         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
  83         (get_dwarf2_per_objfile): Update.
  84         (set_dwarf2_per_objfile): Remove.
  85         (dwarf2_has_info, dwarf2_get_section_info): Update.
  86         (dwarf2_free_objfile): Remove.
  87         (_initialize_dwarf2_read): Update.
  88
  89 2019-05-08  Tom Tromey  <tom@tromey.com>
  90
  91         * auto-load.c (struct auto_load_pspace_info): Add destructor and
  92         initializers.
  93         <unsupported_script_warning_printed,
  94         script_not_found_warning_printed>: Now bool.
  95         (auto_load_pspace_data): Change type.
  96         (~auto_load_pspace_info): Rename from
  97         auto_load_pspace_data_cleanup.
  98         (get_auto_load_pspace_data, init_loaded_scripts_info)
  99         (clear_section_scripts, maybe_print_unsupported_script_warning)
 100         (maybe_print_script_not_found_warning, _initialize_auto_load):
 101         Update.
 102
 103 2019-05-08  Tom Tromey  <tom@tromey.com>
 104
 105         * objfiles.c (objfile_pspace_info): Add destructor and
 106         initializers.
 107         (objfiles_pspace_data): Change type.
 108         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 109         (get_objfile_pspace_data): Update.
 110         (objfiles_bfd_data): Change type.
 111         (get_objfile_bfd_data): Update.
 112         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 113
 114 2019-05-08  Tom Tromey  <tom@tromey.com>
 115
 116         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 117         Change type.
 118         (get_catch_syscall_inferior_data): Update.
 119         (catch_syscall_inferior_data_cleanup): Remove.
 120         (_initialize_break_catch_syscall): Update.
 121
 122 2019-05-08  Tom Tromey  <tom@tromey.com>
 123
 124         * inflow.c (struct terminal_info): Add destructor and
 125         initializers.
 126         (inflow_inferior_data): Change type.
 127         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 128         (get_inflow_inferior_data, inflow_inferior_exit)
 129         (swap_terminal_info, _initialize_inflow): Update.
 130
 131 2019-05-08  Tom Tromey  <tom@tromey.com>
 132
 133         * target-dcache.c (target_dcache_cleanup): Remove.
 134         (target_dcache_aspace_key): Change type.
 135         (target_dcache_init_p, target_dcache_invalidate)
 136         (target_dcache_get, target_dcache_get_or_init)
 137         (_initialize_target_dcache): Update.
 138         * dcache.h (struct dcache_deleter): New.
 139
 140 2019-05-08  Tom Tromey  <tom@tromey.com>
 141
 142         * symtab.c (struct symbol_cache): Add destructor and
 143         initializers.
 144         (symbol_cache_key): Move.  Change type.
 145         (make_symbol_cache, free_symbol_cache): Remove.
 146         (get_symbol_cache): Update.
 147         (symbol_cache_cleanup): Remove.
 148         (ALL_PSPACES, symbol_cache_flush)
 149         (maintenance_print_symbol_cache)
 150         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 151         Update.
 152
 153 2019-05-08  Tom Tromey  <tom@tromey.com>
 154
 155         * symtab.c (struct main_info): Add destructor and initializers.
 156         (main_progspace_key): Move.  Change type.
 157         (get_main_info): Update.
 158         (main_info_cleanup): Remove.
 159         (_initialize_symtab): Update.
 160
 161 2019-05-08  Tom Tromey  <tom@tromey.com>
 162
 163         * registry.h (DECLARE_REGISTRY): Define the _key class.
 164
 165 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 166
 167         * NEWS: Merge two 'New commands' sections.
 168
 169 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 170
 171         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 172         parameter and use Ada language definition instead.
 173         (ada_val_print_ptr): Remove unused language parameter.
 174         (ada_val_print_num): Remove language parameter and use Ada language
 175         definition instead.
 176         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 177         parameter.
 178         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 179         parameter and use Ada language definition instead.
 180         (ada_val_print_1): Update all ada_val_print_xxx calls.
 181         Remove language parameter.
 182         (ada_val_print): Update ada_val_print_1 call.
 183
 184 2019-05-08  Tom Tromey  <tromey@adacore.com>
 185
 186         * remote.c (remote_hw_watchpoint_limit)
 187         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 188         Now static.
 189
 190 2019-05-08  Tom Tromey  <tromey@adacore.com>
 191
 192         * maint.c (_initialize_maint_cmds): Move initialization code to
 193         remote.c.
 194         (watchdog, show_watchdog): Move to remote.c.
 195         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 196         "watchdog" static.
 197         (_initialize_remote): Move initialization code from maint.c.
 198         * defs.h (watchdog): Don't declare.
 199
 200 2019-05-08  Tom Tromey  <tromey@adacore.com>
 201
 202         * tui/tui-interp.c: Include main.h.
 203         * interps.c: Include main.h.
 204         * main.h (interpreter_p): Declare.
 205         * defs.h (interpreter_p): Don't declare.
 206
 207 2019-05-08  Tom Tromey  <tromey@adacore.com>
 208
 209         * dwarf2loc.c: Include dwarf2read.h.
 210         * defs.h (read_unsigned_leb128): Don't declare.
 211         * dwarf2read.h (read_unsigned_leb128): Declare.
 212
 213 2019-05-08  Tom Tromey  <tromey@adacore.com>
 214
 215         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 216         method.
 217
 218 2019-05-08  Tom Tromey  <tromey@adacore.com>
 219
 220         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 221         when no wrap column is set.
 222
 223 2019-05-08  Tom Tromey  <tromey@adacore.com>
 224
 225         * c-lang.c (c_get_string): Handle non-C-style arrays.
 226
 227 2019-05-08  Tom Tromey  <tromey@adacore.com>
 228
 229         * typeprint.c (print_offset_data::update): Print the bit offset,
 230         not the number of bits remaining.
 231
 232 2019-05-08  Tom Tromey  <tromey@adacore.com>
 233
 234         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 235         padding at end of comment.
 236
 237 2019-05-08  Tom Tromey  <tromey@adacore.com>
 238
 239         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 240         Compare main types.
 241
 242 2019-05-06  Tom Tromey  <tom@tromey.com>
 243
 244         * common/scoped_mmap.c: Include common-defs.h.
 245         * common/scoped_mmap.h: Don't include config.h.
 246
 247 2019-05-04  Tom Tromey  <tom@tromey.com>
 248
 249         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 250         (struct aarch64_call_info): Add initializers.
 251         <si>: Now a std::vector.
 252         (pass_on_stack, aarch64_push_dummy_call): Update.
 253
 254 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 255             Tom Tromey  <tom@tromey.com>
 256
 257         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 258         (ppc_threads): Now a std::vector.  Now static.
 259         (hwdebug_find_thread_points_by_tid)
 260         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 261         Update.
 262
 263 2019-05-04  Tom Tromey  <tom@tromey.com>
 264
 265         * arc-tdep.c (arc_tdesc_init): Return bool.
 266
 267 2019-05-04  Tom Tromey  <tom@tromey.com>
 268
 269         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 270         Use gdb_assert_not_reached.
 271
 272 2019-05-04  Tom Tromey  <tom@tromey.com>
 273
 274         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 275         "false".
 276
 277 2019-05-04  Tom Tromey  <tom@tromey.com>
 278
 279         * arc-tdep.c (arc_tdesc_init): Use bool.
 280
 281 2019-05-04  Tom Tromey  <tom@tromey.com>
 282
 283         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 284
 285 2019-05-04  Tom Tromey  <tom@tromey.com>
 286
 287         * cli/cli-cmds.c (valid_command_p): Return bool.
 288
 289 2019-05-04  Tom Tromey  <tom@tromey.com>
 290
 291         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 292         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 293
 294 2019-05-04  Raul Tambre  <raul@tambre.ee>
 295
 296         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 297         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 298         operator for comparison.
 299
 300 2019-05-04  Tom Tromey  <tom@tromey.com>
 301
 302         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 303         (lookup_partial_symbol, print_partial_symbols)
 304         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 305         (psymbol_compare): Update.
 306         (add_psymbol_to_bcache): Clear the entire psymbol.
 307         (maintenance_check_psymtabs): Update.
 308         * psympriv.h (struct partial_symbol): Don't derive from
 309         general_symbol_info.
 310         <obj_section, unrelocated_address, address,
 311         set_unrelocated_address>: Update.
 312         <ginfo>: New member.
 313         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 314         (debug_names::write_psymbols): Update.
 315
 316 2019-05-04  Tom de Vries  <tdevries@suse.de>
 317
 318         * contrib/cc-with-tweaks.sh: Support -n arg.
 319
 320 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 321
 322         * corelow.c (core_target::detach): Ensure frame cache and
 323         register caches are cleared.
 324         inferior.c (exit_inferior_1): Likewise.
 325
 326 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 327             Tom Tromey  <tom@tromey.com>
 328
 329         * dictionary.c (collate_pending_symbols_by_language): Remove
 330         "struct" from foreach.
 331         * symtab.c (lookup_global_symbol_from_objfile)
 332         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 333         foreach.
 334         * ser-tcp.c (net_open): Remove "struct" from foreach.
 335         * objfiles.c (objfile_relocate, objfile_rebase)
 336         (objfile_has_symbols): Remove "struct" from foreach.
 337         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 338         from foreach.
 339         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 340         foreach.
 341         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 342         "struct" from foreach.
 343         * ada-lang.c (create_excep_cond_exprs)
 344         (ada_exception_catchpoint_cond_string): Remove "struct" from
 345         foreach.
 346
 347 2019-05-03  Tom Tromey  <tromey@adacore.com>
 348
 349         * ada-exp.y (convert_char_literal): Check suffix of each
 350         enumerator.
 351
 352 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 353
 354         PR ada/21406:
 355         * ada-exp.y (yywrap): Don't define.
 356         * ada-lex.l (%option): Add noyywrap
 357         (yywrap): Remove.
 358
 359 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 360
 361         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 362         _WIN32_WINNT to the XP level, unless already defined to a higher
 363         level.
 364
 365         * unittests/parse-connection-spec-selftests.c:
 366         * ser-tcp.c:
 367         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 368         override.
 369
 370         * symfile.c (find_separate_debug_file): Remove colon from the
 371         drive spec of DOS/Windows file names of the target, so that the
 372         file name produced from DEBUGDIR and the target's directory will
 373         be valid on DOS/Windows systems.
 374
 375 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 376
 377         * rust-lang.c (val_print_struct): Handle printing structures
 378         containing strings.
 379
 380 2019-05-02  Tom Tromey  <tromey@adacore.com>
 381
 382         * valarith.c (_initialize_valarith): Remove.
 383
 384 2019-05-01  Tom Tromey  <tromey@adacore.com>
 385
 386         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 387         bitfields.
 388
 389 2019-05-01  Tom Tromey  <tromey@adacore.com>
 390
 391         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 392         for big-endian copies.
 393
 394 2019-04-30  Ali Tamur  <tamur@google.com>
 395         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 396         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 397         (read_3_bytes): New function.
 398
 399 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 400
 401         * windows-nat.c (main_thread_id): Delete.
 402         (handle_output_debug_string): Replace main_thread_id by
 403         current_event.dwThreadId.
 404         (fake_create_process): Likewise.
 405         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 406         Do not set main_thread_id.
 407         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 408         current_event.dwThreadId.
 409         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 410
 411 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 412
 413         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 414         Use current_event.dwThreadId instead of main_thread_id.
 415
 416 2019-04-30  Tom Tromey  <tromey@adacore.com>
 417
 418         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 419         (create_excep_cond_exprs): Iterate over program spaces.
 420         (ada_exception_catchpoint_cond_string): Examine all minimal
 421         symbols for exception types.
 422
 423 2019-04-30  Tom Tromey  <tromey@adacore.com>
 424
 425         PR c++/24470:
 426         * dwarf2read.c (process_structure_scope): Handle case where type
 427         has template parameters but no symbol was created.
 428
 429 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 430             Chris January  <chris.january@arm.com>
 431
 432         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 433         qualifier.
 434         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 435
 436 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 437
 438         * f-typeprint.c (f_print_type): Update rules for printing
 439         whitespace.
 440         (f_type_print_varspec_suffix): Likewise.
 441
 442 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 443             Chris January  <chris.january@arm.com>
 444
 445         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 446         function arguments.
 447
 448 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 449
 450         * f-lang.c (build_fortran_types): Change name of void type to
 451         lower case.
 452         * f-typeprint.c (f_type_print_base): Print the name of the void
 453         type, rather than a fixed string.
 454         * f-valprint.c (f_decorations): Use lower case void string.
 455
 456 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 457             Chris January  <chris.january@arm.com>
 458
 459         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 460         types for Fortran.
 461
 462 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 463             Chris January  <chris.january@arm.com>
 464             David Lecomber  <david.lecomber@arm.com>
 465
 466         * f-exp.y (BINOP_INTRINSIC): New token.
 467         (exp): New parser rule handling BINOP_INTRINSIC.
 468         (f77_keywords): Add new builtin procedures.
 469         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 470         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 471         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 472         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 473         (print_unop_subexp_f): New function.
 474         (print_binop_subexp_f): New function.
 475         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 476         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 477         (dump_subexp_body_f): Likewise.
 478         (operator_check_f): Likewise.
 479         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 480         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 481
 482 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 483
 484         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 485         UNOP_KIND.
 486         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 487         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 488         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 489         (operator_length_f): New fuction.
 490         (print_subexp_f): New function.
 491         (op_name_f): New function.
 492         (dump_subexp_body_f): New function.
 493         (operator_check_f): New function.
 494         (exp_descriptor_f): Replace standard expression handling functions
 495         with new functions.
 496         * gdb/fortran-operator.def: New file.
 497         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 498         * gdb/std-operator.def: Remove UNOP_KIND.
 499
 500 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * std-operator.def: Remove unbalanced, stray double quote
 503         character.
 504
 505 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 506             Chris January  <chris.january@arm.com>
 507             Daniel Everett  <daniel.everett@arm.com>
 508             Nick Forrington  <nick.forrington@arm.com>
 509             Richard Bunt  <richard.bunt@arm.com>
 510
 511         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 512         of depth when printing anonymous structs or unions.
 513         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 514         Don't print either the top-level value, or the children if the
 515         max-depth is exceeded.
 516         (ppscm_print_children): When printing the key of a map, allow one
 517         extra level of depth.
 518         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 519         print either the top-level value, or the children if the max-depth
 520         is exceeded.
 521         (print_children): When printing the key of a map, allow one extra
 522         level of depth.
 523         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 524         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 525         (user_print_options): Initialise max_depth field.
 526         (val_print_scalar_or_string_type_p): New function.
 527         (val_print): Check to see if the max depth has been reached.
 528         (val_print_check_max_depth): Define new function.
 529         (show_print_max_depth): New function.
 530         (_initialize_valprint): Add 'print max-depth' option.
 531         * valprint.h (struct value_print_options) <max_depth>: New field.
 532         (val_print_check_max_depth): Declare new function.
 533         * NEWS: Document new feature.
 534
 535 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 536
 537         * ada-lang.c (ada_language_defn): Initialise new field.
 538         * c-lang.c (c_is_string_type_p): New function.
 539         (c_language_defn): Initialise new field.
 540         (cplus_language_defn): Initialise new field.
 541         (asm_language_defn): Initialise new field.
 542         (minimal_language_defn): Initialise new field.
 543         * c-lang.h (c_is_string_type_p): Declare new function.
 544         * d-lang.c (d_language_defn): Initialise new field.
 545         * f-lang.c (f_is_string_type_p): New function.
 546         (f_language_defn): Initialise new field.
 547         * go-lang.c (go_is_string_type_p): New function.
 548         (go_language_defn): Initialise new field.
 549         * language.c (default_is_string_type_p): New function.
 550         (unknown_language_defn): Initialise new field.
 551         (auto_language_defn): Initialise new field.
 552         * language.h (struct language_defn) <la_is_string_type_p>: New
 553         member variable.
 554         (default_is_string_type_p): Declare new function.
 555         * m2-lang.c (m2_language_defn): Initialise new field.
 556         * objc-lang.c (objc_language_defn): Initialise new field.
 557         * opencl-lang.c (opencl_language_defn): Initialise new field.
 558         * p-lang.c (pascal_is_string_type_p): New function.
 559         (pascal_language_defn): Initialise new field.
 560         * rust-lang.c (rust_is_string_type_p): New function.
 561         (rust_language_defn): Initialise new field.
 562
 563 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 564
 565         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 566         New field.
 567         * ada-lang.c (ada_language_defn): Initialise new field.
 568         * c-lang.c (c_language_defn): Likewise.
 569         (cplus_language_defn): Likewise.
 570         (asm_language_defn): Likewise.
 571         (minimal_language_defn): Likewise.
 572         * d-lang.c (d_language_defn): Likewise.
 573         * f-lang.c (f_language_defn): Likewise.
 574         * go-lang.c (go_language_defn): Likewise.
 575         * language.c (unknown_language_defn): Likewise.
 576         (auto_language_defn): Likewise.
 577         * m2-lang.c (m2_language_defn): Likewise.
 578         * objc-lang.c (objc_language_defn): Likewise.
 579         * opencl-lang.c (opencl_language_defn): Likewise.
 580         * p-lang.c (pascal_language_defn): Likewise.
 581         * rust-lang.c (rust_language_defn): Likewise.
 582
 583 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 584
 585         * ada-lang.c (ada_is_character_type): Change return type to bool.
 586         (ada_is_string_type): Likewise.
 587         * ada-lang.h (ada_is_character_type): Update declaration
 588         (ada_is_string_type): Likewise.
 589
 590 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 591
 592         Support style in 'frame|thread apply'
 593
 594         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 595         * record.c (record_start, record_stop): Update callers of
 596         execute_command_to_string with false.
 597         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 598         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 599         methods.
 600         (class string_file): New constructor with term_out parameter.
 601         Override methods term_out and can_emit_style_escape.  New member
 602         term_out.
 603         (class stdio_file): Override can_emit_style_escape.
 604         (class tee_file): Override term_out and can_emit_style_escape.
 605         * utils.h (can_emit_style_escape): Remove.
 606         * utils.c (can_emit_style_escape): Likewise.
 607         Update all callers of can_emit_style_escape (SOMESTREAM) to
 608         SOMESTREAM->can_emit_style_escape.
 609         * source-cache.c (source_cache::get_source_lines): Likewise.
 610         * stack.c (frame_apply_command_count): Call execute_command_to_string
 611         passing the term_out characteristic of the current gdb_stdout.
 612         * thread.c (thr_try_catch_cmd): Likewise.
 613         * top.c (execute_command_to_string): pass term_out parameter
 614         to construct the string_file for the command output.
 615         * ui-file.c (term_cli_styling): New function (most code moved
 616         from utils.c can_emit_style_escape).
 617         (string_file::string_file, string_file::can_emit_style_escape,
 618         stdio_file::can_emit_style_escape, tee_file::term_out,
 619         tee_file::can_emit_style_escape): New functions.
 620
 621 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 622
 623         * NEWS: Mention the new set|show may-call-functions.
 624         * infcall.c (may_call_functions_p): New variable.
 625         (show_may_call_functions_p): New function.
 626         (call_function_by_hand_dummy): Throws an error if not
 627         may-call-functions.
 628         (_initialize_infcall): Call add_setshow_boolean_cmd for
 629         may-call-functions.
 630
 631 2019-04-25  Keith Seitz  <keiths@redhat.com>
 632
 633         PR c++/24367
 634         * cp-support.c (inspect_type): Don't attempt substitutions
 635         of symbol with the same name.
 636
 637 2019-04-25  Tom Tromey  <tromey@adacore.com>
 638
 639         PR gdb/24475:
 640         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 641         static.
 642
 643 2019-04-25  Tom Tromey  <tromey@adacore.com>
 644
 645         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 646         rvalue reference.
 647         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 648         (gdb_xml_parser::parse): Use std::move.
 649         * python/python-internal.h (gdbpy_convert_exception): Take a const
 650         reference.
 651         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 652         std::move.
 653         * python/py-utils.c (gdbpy_convert_exception): Take a const
 654         reference.
 655         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 656         Use std::move.
 657         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 658         Use std::move.
 659         * mi/mi-main.c (mi_print_exception): Take a const reference.
 660         * main.c (handle_command_errors): Take a const reference.
 661         * linespec.c (parse_linespec): Use std::move.
 662         * infcall.c (run_inferior_call): Use std::move.
 663         (call_function_by_hand_dummy): Use std::move.
 664         * exec.c (try_open_exec_file): Use std::move.
 665         * exceptions.h (exception_print, exception_fprintf)
 666         (exception_print_same): Update.
 667         * exceptions.c (print_exception, exception_print)
 668         (exception_fprintf, exception_print_same): Change parameters to
 669         const reference.
 670         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 671         * common/new-op.c: Use std::move.
 672         * common/common-exceptions.h (struct gdb_exception): Add move
 673         constructor.
 674         (struct gdb_exception_error, struct gdb_exception_quit, struct
 675         gdb_quit_bad_alloc): Change constructor to move constructor.
 676         (throw_exception): Change parameter to rvalue reference.
 677         * common/common-exceptions.c (throw_exception): Take rvalue
 678         reference.
 679         * cli/cli-interp.c (safe_execute_command): Use std::move.
 680         * breakpoint.c (insert_bp_location, location_to_sals): Use
 681         std::move.
 682
 683 2019-04-25  Tom Tromey  <tromey@adacore.com>
 684
 685         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 686         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 687         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 688         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 689         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 690         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 691         guile/scm-value.c: Use unpack.
 692         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 693         gdbscm_gdb_exception.
 694         (gdbscm_throw_gdb_exception): Likewise.
 695         (struct gdbscm_gdb_exception): New.
 696         (unpack): New function.
 697         (gdbscm_wrap): Use unpack.
 698
 699 2019-04-25  Tom Tromey  <tromey@adacore.com>
 700
 701         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 702         (gdb_rl_callback_handler): Use std::move.
 703         * common/common-exceptions.h (struct gdb_exception): Add move
 704         assignment operator.
 705         (throw_exception_sjlj): Change "exception" to const reference.
 706         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 707         (throw_exception_sjlj): Change "exception" to const reference.
 708
 709 2019-04-25  Tom Tromey  <tromey@adacore.com>
 710
 711         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 712         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 713         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 714         Update.
 715         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 716         Update.
 717         * mi/mi-interp.c (mi_interp::exec): Update.
 718         * linespec.c (parse_linespec): Update.
 719         * infcall.c (run_inferior_call): Update.
 720         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 721         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 722         (gdbscm_lookup_global_symbol): Update.
 723         * guile/scm-param.c (gdbscm_parameter_value): Update.
 724         * guile/scm-frame.c (gdbscm_frame_read_register)
 725         (gdbscm_frame_read_var): Update.
 726         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 727         * exec.c (try_open_exec_file): Update.
 728         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 729         (gdb_rl_callback_handler): Update.
 730         * common/common-exceptions.h (exception_none): Don't declare.
 731         * common/common-exceptions.c (exception_none): Don't define.
 732         (struct catcher) <exception>: Update.
 733         * cli/cli-interp.c (safe_execute_command): Update.
 734         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 735
 736 2019-04-25  Ali Tamur  <tamur@google.com>
 737
 738         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 739         (read_attribute_value): Likewise.
 740         (dwarf2_read_addr_index): Update comment.
 741         (read_str_index): Add DW_FORM_strx.
 742         (dwarf2_string_attr): Likewise.
 743         (dwarf2_const_value_attr): Likewise.
 744         (dump_die_shallow): Likewise.
 745         (dwarf2_fetch_constant_bytes): Likewise.
 746         (skip_form_bytes): Likewise.
 747         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 748
 749 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 750
 751         PR corefiles/11608
 752         PR corefiles/18187
 753         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 754         OFFSET.  Verify if current mapping contains an ELF header.
 755         (linux_find_memory_regions_full): Adjust call to
 756         dump_mapping_p.
 757
 758 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 759             Kang Li <kanglictf@gmail.com>
 760
 761         PR gdb/21600
 762
 763         * dwarf2-frame.c (read_initial_length): Be consistent about using
 764         unsigned representation of length.
 765         (decode_frame_entry_1): Likewise.  Check for wraparound of
 766         end pointer as well as buffer overflow.
 767
 768 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 769
 770         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 771         "vq".
 772
 773 2019-04-24  Tom Tromey  <tromey@adacore.com>
 774
 775         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 776
 777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * s12z-tdep.c (s12z_unwind_pc): Delete.
 780         (s12z_unwind_sp): Delete.
 781         (s12z_gdbarch_init): Don't register deleted functions with
 782         gdbarch.
 783
 784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * rl78-tdep.c (rl78_unwind_sp): Delete.
 787         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 788
 789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 790
 791         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 792         (xstormy16_unwind_pc): Delete.
 793         (xstormy16_dummy_id): Delete.
 794         (xstormy16_gdbarch_init): Don't register deleted functions with
 795         gdbarch.
 796
 797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 798
 799         * vax-tdep.c (vax_unwind_pc): Delete.
 800         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 801
 802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 803
 804         * v850-tdep.c (v850_unwind_sp): Delete.
 805         (v850_unwind_pc): Delete.
 806         (v850_dummy_id): Delete.
 807         (v850_gdbarch_init): Don't register deleted functions with
 808         gdbarch.
 809
 810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 813         (tilegx_unwind_pc): Delete.
 814         (tilegx_unwind_dummy_id): Delete.
 815         (tilegx_gdbarch_init): Don't register deleted functions with
 816         gdbarch.
 817
 818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 821         (tic6x_dummy_id): Delete.
 822         (tic6x_gdbarch_init): Don't register deleted functions with
 823         gdbarch.
 824
 825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * sparc-tdep.c (sparc_unwind_pc): Delete.
 828         (sparc32_gdbarch_init): Don't register deleted function with
 829         gdbarch.
 830
 831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 832
 833         * sh-tdep.c (sh_unwind_sp): Delete.
 834         (sh_unwind_pc): Delete.
 835         (sh_dummy_id): Delete.
 836         (sh_gdbarch_init): Don't register deleted functions with
 837         gdbarch.
 838
 839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * score-tdep.c (score_unwind_sp): Delete.
 842         (score_unwind_pc): Delete.
 843         (score_dummy_id): Delete.
 844         (score_gdbarch_init): Don't register deleted functions with
 845         gdbarch.
 846
 847 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * rx-tdep.c (rx_unwind_pc): Delete.
 850         (rx_unwind_sp): Delete.
 851         (rx_dummy_id): Delete.
 852         (rx_gdbarch_init): Don't register deleted functions with
 853         gdbarch.  Update comment.
 854
 855 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 856
 857         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 858         (rs6000_dummy_id): Delete.
 859         (rs6000_gdbarch_init): Don't register deleted functions with
 860         gdbarch.
 861
 862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * or1k-tdep.c (or1k_dummy_id): Delete.
 865         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 866
 867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * nios2-tdep.c (nios2_dummy_id): Delete.
 870         (nios2_unwind_sp): Delete.
 871         (nios2_gdbarch_init): Don't register deleted functions with
 872         gdbarch.
 873
 874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * nds32-tdep.c (nds32_dummy_id): Delete.
 877         (nds32_unwind_pc): Delete.
 878         (nds32_unwind_sp): Delete.
 879         (nds32_gdbarch_init): Don't register deleted functions with
 880         gdbarch.
 881
 882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * msp430-tdep.c (msp430_unwind_pc): Delete.
 885         (msp430_unwind_sp): Delete.
 886         (msp430_dummy_id): Delete.
 887         (msp430_gdbarch_init): Don't register deleted functions with
 888         gdbarch.
 889
 890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * moxie-tdep.c (moxie_unwind_sp): Delete.
 893         (moxie_unwind_pc): Delete.
 894         (moxie_dummy_id): Delete.
 895         (moxie_gdbarch_init): Don't register deleted functions with
 896         gdbarch.
 897
 898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 899
 900         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 901         (mn10300_unwind_pc): Delete.
 902         (mn10300_unwind_sp): Delete.
 903         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 904         mn10300_unwind_sp.
 905         (mn10300_frame_unwind_init): Don't register deleted functions with
 906         gdbarch.
 907
 908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 909
 910         * mep-tdep.c (mep_unwind_pc): Delete.
 911         (mep_unwind_sp): Delete.
 912         (mep_dummy_id): Delete.
 913         (mep_gdbarch_init): Don't register deleted functions with
 914         gdbarch.
 915
 916 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 917
 918         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 919         (m68hc11_unwind_sp): Delete.
 920         (m68hc11_gdbarch_init): Don't register deleted functions with
 921         gdbarch.
 922
 923 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 924
 925         * m32r-tdep.c (m32r_unwind_sp): Delete.
 926         (m32r_unwind_pc): Delete.
 927         (m32r_dummy_id): Delete.
 928         (m32r_gdbarch_init): Don't register deleted functions with
 929         gdbarch.
 930
 931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 932
 933         * m32c-tdep.c (m32c_unwind_pc): Delete.
 934         (m32c_unwind_sp): Delete.
 935         (m32c_dummy_id): Delete.
 936         (m32c_gdbarch_init): Don't register deleted functions with
 937         gdbarch.
 938
 939 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 940
 941         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 942         (lm32_unwind_pc): Delete.
 943         (lm32_dummy_id): Delete.
 944         (lm32_gdbarch_init): Don't register deleted functions with
 945         gdbarch.
 946
 947 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 950         (iq2000_unwind_pc): Delete.
 951         (iq2000_dummy_id): Delete.
 952         (iq2000_gdbarch_init): Don't register deleted functions with
 953         gdbarch.
 954
 955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 956
 957         * nds32-tdep.c (nds32_type_align): Delete.
 958         (nds32_push_dummy_call): Use type_align instead.
 959
 960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 961
 962         * arm-tdep.c (arm_type_align): Only handle vector override case.
 963         (arm_push_dummy_call): Use type_align.
 964         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 965
 966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 967
 968         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 969         case.
 970         (pass_on_stack): Use type_align.
 971         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 972         function.
 973
 974 2019-04-23  Tom Tromey  <tromey@adacore.com>
 975
 976         * dwarf2read.c (line_header::file_name_at): Remove unused
 977         overload.
 978
 979 2019-04-23  Tom de Vries  <tdevries@suse.de>
 980
 981         PR gdb/24438
 982         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 983         invocation.
 984
 985
 986 2019-03-27  Ali Tamur  <tamur@google.com>
 987
 988         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 989         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 990         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 991         (dwarf_expr_context::get_addr_index): Likewise
 992         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 993         (symbol_needs_eval_context::get_addr_index): Likewise
 994         (disassemble_dwarf_expression): Add DW_OP_addrx
 995         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 996         (read_cutu_die_from_dwo): Update comment
 997         (skip_one_die): Add DW_FORM_addrx
 998         (read_attribute_value): Likewise
 999         (var_decode_location): Add DW_OP_addrx
1000         (dwarf2_const_value_attr): Add DW_FORM_addrx
1001         (dump_die_shallow): Likewise
1002         (dwarf2_fetch_constant_bytes): Likewise
1003         (decode_locdesc): Add DW_OP_addrx
1004         (skip_form_bytes): Add DW_FORM_addrx
1005
1006 2019-04-22  Ali Tamur  <tamur@google.com>
1007
1008         * MAINTAINERS (Write After Approval): Add self.
1009
1010 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1011
1012         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1013         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1014         (open_symbol_file_object): Likewise.
1015         (svr4_default_sos): Add info parameter.
1016         (svr4_read_so_list): Likewise.
1017         (svr4_current_sos_direct): Adjust functions calls to pass down
1018         info.
1019         (svr4_current_sos_1): Add info parameter.
1020         (svr4_current_sos): Call get_svr4_info, pass info down to
1021         svr4_current_sos_1.
1022         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1023         get_svr4_info.
1024         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1025         get_svr4_info.
1026         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1027         to get_svr4_info.
1028         (probes_table_remove_objfile_probes): Likewise.
1029         (register_solib_event_probe): Add info parameter.
1030         (solist_update_incremental): Pass info parameter down to
1031         svr4_read_so_list.
1032         (disable_probes_interface): Add info parameter.
1033         (svr4_handle_solib_event): Pass current_program_space to
1034         get_svr4_info.  Adjust disable_probes_interface cleanup.
1035         (svr4_create_probe_breakpoints): Add info parameter, pass it
1036         down to register_solib_event_probe.
1037         (svr4_create_solib_event_breakpoints): Add info parameter,
1038         pass it down to svr4_create_probe_breakpoints.
1039         (enable_break): Pass info down to
1040         svr4_create_solib_event_breakpoints.
1041         (svr4_solib_create_inferior_hook): Pass current_program_space to
1042         get_svr4_info.
1043         (svr4_clear_solib): Likewise.
1044
1045 2019-04-22  Pedro Alves  <palves@redhat.com>
1046
1047         * solib-svr4.c (svr4_free_objfile_observer): New.
1048         (probe_and_action::objfile): New field.
1049         (probes_table_htab_remove_objfile_probes)
1050         (probes_table_remove_objfile_probes): New functions.
1051         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1052         in the new probe_and_action.  Don't store the probe in 'lookup'.
1053         (svr4_create_probe_breakpoints): Pass objfile to
1054         register_solib_event_probe.
1055         (_initialize_svr4_solib): Register a free_objfile observer.
1056
1057 2019-04-19  Tom Tromey  <tom@tromey.com>
1058
1059         * common/queue.h: Remove.
1060
1061 2019-04-19  Tom Tromey  <tom@tromey.com>
1062
1063         * event-loop.c: Don't include "common/queue.h".
1064
1065 2019-04-19  Tom Tromey  <tom@tromey.com>
1066
1067         * remote.c (remote_target): Use delete.
1068         * remote-notif.h: Include <list>, not "common/queue.h".
1069         (notif_client_p): Remove typedef.
1070         (remote_notif_state): Add constructor, destructor, initializer.
1071         <notif_queue>: Now a std::list.
1072         (remote_notif_state_xfree): Don't declare.
1073         * remote-notif.c (remote_notif_process, handle_notification)
1074         (remote_notif_state_allocate): Update.
1075         (~remote_notif_state): Rename from remote_notif_state_xfree.
1076
1077 2019-04-19  Tom Tromey  <tom@tromey.com>
1078
1079         * symfile.c (reread_symbols): Update.
1080         * objfiles.c (objfile_register_static_link)
1081         (objfile_lookup_static_link): Update
1082         (~objfile) Don't delete static_links.
1083         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1084
1085 2019-04-19  Tom Tromey  <tom@tromey.com>
1086
1087         * type-stack.h (struct type_stack) <insert>: Constify string.
1088         * type-stack.c (type_stack::insert): Constify string.
1089         * gdbtypes.h (lookup_template_type): Update.
1090         (address_space_name_to_int): Update.
1091         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1092         const.
1093         (lookup_template_type): Make name const.
1094         * c-exp.y: Update rules.
1095         (lex_one_token, classify_name, classify_inner_name)
1096         (c_print_token): Update.
1097         * p-exp.y: Update rules.
1098         (yylex): Update.
1099         * f-exp.y: Update rules.
1100         (yylex): Update.
1101         * d-exp.y: Update rules.
1102         (lex_one_token, classify_name, classify_inner_name): Update.
1103         * parse.c (write_dollar_variable, copy_name): Return std::string.
1104         * parser-defs.h (copy_name): Change return type.
1105         * m2-exp.y: Update rules.
1106         (yylex): Update.
1107         * go-exp.y (lex_one_token): Update.
1108         Update rules.
1109         (classify_unsafe_function, classify_packaged_name)
1110         (classify_name, yylex): Update.
1111
1112 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1113
1114         * configure.ac: add --enable-source-highlight switch.
1115         * configure: Regenerate.
1116         * top.c (print_gdb_version): plumb --enable-source-highlight
1117         status to "show configuration".
1118
1119 2019-04-19  Tom Tromey  <tromey@adacore.com>
1120
1121         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1122         Check ADA_TYPE_P.
1123         (empty_record, ada_template_to_fixed_record_type_1)
1124         (template_to_static_fixed_type)
1125         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1126         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1127         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1128         macros.
1129
1130 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1131
1132         PR symtab/24423:
1133         * source.c (print_source_lines_base): Advance "iter" when a
1134         control character is seen.
1135
1136 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1137
1138         * inferior.h (struct infcall_suspend_state_deleter):
1139         Catch exception in destructor to avoid crash.
1140
1141 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1142
1143         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1144         close to the add_com "shell".
1145
1146 2019-04-18  Tom Tromey  <tromey@adacore.com>
1147
1148         * process-stratum-target.h (class process_stratum_target)
1149         <stratum>: Add "final".
1150
1151 2019-04-17  Tom Tromey  <tromey@adacore.com>
1152
1153         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1154         against nullptr before use.
1155
1156 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1157
1158         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1159
1160 2019-04-17  Jim Wilson  <jimw@sifive.com>
1161             Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1164         code read might fail, assume 4-byte breakpoint in that case.
1165
1166 2019-04-15  Leszek Swirski  <leszeks@google.com>
1167
1168         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1169         rather than a hand-rolled POD check when checking for forced MEMORY
1170         classification.
1171
1172 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1173
1174         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1175         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1176         function.
1177         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1178         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1179         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1180         declaration.
1181
1182 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1183
1184         * aarch64-linux-nat.c
1185         (aarch64_linux_nat_target::thread_architecture): Add override.
1186         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1187         each VQ.
1188
1189 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1190
1191         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1192
1193 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1194
1195         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1196         target types of size 96-bits, add some additional comments, and
1197         check that the builtin type we found was the correct size.
1198
1199 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1200
1201         * utils.c (prompt_for_continue): Don't restore the styling at the
1202         end, as applied_style has the wrong value.  This fixes styling in
1203         long lists of file names that are interrupted by the "Continue?"
1204         prompt.
1205
1206 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1207
1208         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1209         * c-lang.c (c_language_defn): Likewise.
1210         (cplus_language_defn): Likewise.
1211         (asm_language_defn): Likewise.
1212         (minimal_language_defn): Likewise.
1213         * d-lang.c (d_language_defn): Likewise.
1214         * f-lang.c (f_language_defn): Likewise.
1215         * go-lang.c (go_language_defn): Likewise.
1216         * language.c (unknown_language_defn): Likewise.
1217         (auto_language_defn): Likewise.
1218         * language.h (struct language_defn): Remove la_magic field.
1219         (LANG_MAGIC): Delete.
1220         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1221         * objc-lang.c (objc_language_defn): Likewise.
1222         * opencl-lang.c (opencl_language_defn): Likewise.
1223         * p-lang.c (pascal_language_defn): Likewise.
1224         * rust-lang.c (rust_language_defn): Likewise.
1225
1226 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * riscv-tdep.c (riscv_type_align): New function.
1229         (riscv_type_alignment): Delete.
1230         (riscv_arg_location): Use 'type_align'.
1231         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1232
1233 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1234
1235         * gdbtypes.c (type_align): A struct with no non-static fields also
1236         has alignment of 1.
1237
1238 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1241         component to 0.
1242         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1243         member.
1244         (riscv_struct_info::analyse): New implementation using new
1245         analyse_inner member function.
1246         (riscv_struct_info::field_offset): New member function.
1247         (riscv_struct_info::m_offsets): New member variable.
1248         (riscv_struct_info::analyse_inner): New private member function,
1249         takes the old implementation of riscv_struct_info::analyse but
1250         extended to track field offsets.
1251         (riscv_call_arg_struct): Update the struct folding special cases
1252         to handle cases where empty C++ structs, which are non-zero
1253         length, are found.
1254         (riscv_arg_location): Initialise the length of each location, a
1255         non-zero length now indicates the location is in use.
1256         (riscv_push_dummy_call): Allow for the first location having a
1257         non-zero offset when setting up arguments.
1258         (riscv_return_value): Likewise, but for return values.
1259
1260 2019-04-11  Tom Tromey  <tromey@adacore.com>
1261
1262         * utils.c (internal_vproblem): Make "msg" const.
1263
1264 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1265
1266         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1267         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1268         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1269         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1270
1271 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1272
1273         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1274         function.
1275         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1276         of amd64_collect_native_gregset.
1277         (amd64_linux_nat_target::store_registers): Likewise.
1278
1279 2019-04-10  Tom Tromey  <tom@tromey.com>
1280
1281         * symtab.c (lookup_global_symbol_from_objfile)
1282         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1283         * objfiles.h (class separate_debug_iterator): New.
1284         (class separate_debug_range): New.
1285         (struct objfile) <separate_debug_objfiles>: New method.
1286         (objfile_separate_debug_iterate): Don't declare.
1287         * objfiles.c (separate_debug_iterator::operator++): Rename from
1288         objfile_separate_debug_iterate.
1289         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1290         iterator.
1291         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1292         iterator.
1293
1294 2019-04-10  Tom Tromey  <tom@tromey.com>
1295
1296         * symfile.c (reread_symbols): Remove old comment.
1297         * objfiles.c (free_all_objfiles): Fix a typo.
1298
1299 2019-04-10  Tom Tromey  <tom@tromey.com>
1300
1301         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1302         * minsyms.c (lookup_minimal_symbol): Use foreach.
1303         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1304         (lookup_minimal_symbol_solib_trampoline): Likewise.
1305         * symfile.c (reread_symbols): Use foreach.
1306
1307 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1308             Tom Tromey  <tromey@adacore.com>
1309
1310         PR rust/24414:
1311         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1312         (rust_lex_int_test): Change "value" to be LONGEST.
1313         (rust_lex_tests): Add test for long integer literal.
1314
1315 2019-04-09  Tom Tromey  <tromey@adacore.com>
1316
1317         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1318         to bool.
1319         (extended_remote_target::attach): Update.
1320         (remote_target::remote_notice_new_inferior): Update.
1321         (remote_target::add_current_inferior_and_thread): Update.
1322         * inferior.c (exit_inferior_1): Use "false".
1323         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1324
1325 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1326
1327         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1328         the "start" command.
1329
1330 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1331
1332         * python/py-inferior.c (infpy_thread_from_thread_handle):
1333         Adjust comments to reflect renaming of thread_from_thread_handle
1334         to thread_from_handle.  Adjust keywords.  Fix type error message.
1335         (inferior_object_methods): Add thread_from_handle.  Retain
1336         thread_from_thread_handle, but mark it as deprecated.
1337
1338 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1339
1340         * gdbthread.h (find_thread_by_handle): Revise declaration.
1341         * thread.c (find_thread_by_handle): Likewise.  Adjust
1342         implementation too.
1343         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1344         support for buffer objects as handles.
1345
1346 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1347
1348         * python/py-infthread.c (thpy_thread_handle): New function.
1349         (thread_object_methods): Register thpy_thread_handle.
1350
1351 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1352
1353         * gdbthread.h (thread_to_thread_handle): Declare.
1354         * thread.c (gdbtypes.h): Include.
1355         (thread_to_thread_handle): New function.
1356
1357         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1358         (target_thread_info_to_thread_handle): Declare.
1359         * target.c (target_thread_info_to_thread_handle): New function.
1360         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1361         * target-delegates.c: Regenerate.
1362
1363         * linux-thread-db.c (class thread_db_target): Add method
1364         thread_info_to_thread_handle.
1365         (thread_db_target::thread_info_to_thread_handle): Define.
1366         * remote.c (class remote_target): Add new method
1367         thread_info_to_thread_handle.
1368         (remote_target::thread_info_to_thread_handle): Define.
1369
1370 2019-04-08  Pedro Alves  <palves@redhat.com>
1371
1372         * common/common-exceptions.c (throw_exception): Don't create
1373         named object to throw; throw directly.
1374         (throw_it): Likewise.  Don't initialize gdb_exception::message
1375         here, with new; pass FMT and AP to the ctor instead.
1376         * common/common-exceptions.h: Include <string>.
1377         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1378         const char *, va_list)): New ctor.  Use std::make_shared.
1379         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1380         errors)): Delete.
1381         (gdb_exception_error::gdb_exception_error(enum errors, const char
1382         *, va_list)): New.
1383         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1384         Add assertion.
1385         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1386         errors)): Delete.
1387         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1388         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1389         Add assertion.
1390
1391 2019-04-08  Tom Tromey  <tom@tromey.com>
1392
1393         * valops.c (value_rtti_indirect_type): Replace throw_exception
1394         with throw.
1395         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1396         with throw.
1397         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1398         throw.
1399         * target.c (target_translate_tls_address): Replace throw_exception
1400         with throw.
1401         * stack.c (frame_apply_command_count): Replace throw_exception
1402         with throw.
1403         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1404         throw.
1405         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1406         with throw.
1407         * rs6000-tdep.c (rs6000_frame_cache)
1408         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1409         * remote.c: Replace throw_exception with throw.
1410         * record-full.c (record_full_message, record_full_wait_1)
1411         (record_full_restore): Replace throw_exception with throw.
1412         * record-btrace.c:
1413         (get_thread_current_frame_id, record_btrace_start_replaying)
1414         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1415         (cmd_record_btrace_start): Replace throw_exception with throw.
1416         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1417         throw.
1418         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1419         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1420         * linespec.c:
1421         (find_linespec_symbols): Replace throw_exception with throw.
1422         * infrun.c (displaced_step_prepare, resume): Replace
1423         throw_exception with throw.
1424         * infcmd.c (post_create_inferior): Replace throw_exception with
1425         throw.
1426         * inf-loop.c (inferior_event_handler): Replace throw_exception
1427         with throw.
1428         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1429         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1430         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1431         (get_prev_frame_always, get_frame_pc_if_available)
1432         (get_frame_address_in_block_if_available, get_frame_language):
1433         Replace throw_exception with throw.
1434         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1435         throw_exception with throw.
1436         * eval.c (fetch_subexp_value, evaluate_var_value)
1437         (evaluate_funcall, evaluate_subexp_standard): Replace
1438         throw_exception with throw.
1439         * dwarf2loc.c (call_site_find_chain)
1440         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1441         Replace throw_exception with throw.
1442         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1443         with throw.
1444         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1445         throw.
1446         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1447         * completer.c (complete_line_internal): Replace throw_exception
1448         with throw.
1449         * compile/compile-object-run.c (compile_object_run): Replace
1450         throw_exception with throw.
1451         * cli/cli-script.c (process_next_line): Replace throw_exception
1452         with throw.
1453         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1454         (btrace_enable, btrace_maint_update_pt_packets): Replace
1455         throw_exception with throw.
1456         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1457         throw_exception with throw.
1458         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1459         throw_exception with throw.
1460         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1461         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1462         * aarch64-tdep.c (aarch64_make_prologue_cache)
1463         (aarch64_make_stub_cache): Replace throw_exception with throw.
1464
1465 2019-04-08  Tom Tromey  <tom@tromey.com>
1466
1467         * common/common-exceptions.c (throw_exception): Rename from
1468         throw_exception_cxx.  Remove old copy.  Make argument const.
1469         (throw_it): Create and throw exception objects directly.
1470         * common/common-exceptions.h (throw_exception): Make argument
1471         const.
1472         (struct gdb_exception_error): Add constructor.
1473         (struct gdb_exception_quit): Add constructor.
1474
1475 2019-04-08  Tom Tromey  <tom@tromey.com>
1476
1477         * common/common-exceptions.h (exception_rethrow): Don't declare.
1478         (TRY_SJLJ): Update comment.
1479         (TRY, CATCH, END_CATCH): Remove.
1480         * common/common-exceptions.c (exception_rethrow): Remove.
1481
1482 2019-04-08  Tom Tromey  <tom@tromey.com>
1483
1484         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1485         Remove.
1486         (gdb_exception_error): Rename from
1487         gdb_exception_RETURN_MASK_ERROR.
1488         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1489         (gdb_quit_bad_alloc): Update.
1490         * aarch64-tdep.c: Update.
1491         * ada-lang.c: Update.
1492         * ada-typeprint.c: Update.
1493         * ada-valprint.c: Update.
1494         * amd64-tdep.c: Update.
1495         * arch-utils.c: Update.
1496         * break-catch-throw.c: Update.
1497         * breakpoint.c: Update.
1498         * btrace.c: Update.
1499         * c-varobj.c: Update.
1500         * cli/cli-cmds.c: Update.
1501         * cli/cli-interp.c: Update.
1502         * cli/cli-script.c: Update.
1503         * common/common-exceptions.c: Update.
1504         * common/new-op.c: Update.
1505         * common/selftest.c: Update.
1506         * compile/compile-c-symbols.c: Update.
1507         * compile/compile-cplus-symbols.c: Update.
1508         * compile/compile-object-load.c: Update.
1509         * compile/compile-object-run.c: Update.
1510         * completer.c: Update.
1511         * corelow.c: Update.
1512         * cp-abi.c: Update.
1513         * cp-support.c: Update.
1514         * cp-valprint.c: Update.
1515         * darwin-nat.c: Update.
1516         * disasm-selftests.c: Update.
1517         * dtrace-probe.c: Update.
1518         * dwarf-index-cache.c: Update.
1519         * dwarf-index-write.c: Update.
1520         * dwarf2-frame-tailcall.c: Update.
1521         * dwarf2-frame.c: Update.
1522         * dwarf2loc.c: Update.
1523         * dwarf2read.c: Update.
1524         * eval.c: Update.
1525         * event-loop.c: Update.
1526         * event-top.c: Update.
1527         * exec.c: Update.
1528         * f-valprint.c: Update.
1529         * fbsd-tdep.c: Update.
1530         * frame-unwind.c: Update.
1531         * frame.c: Update.
1532         * gdbtypes.c: Update.
1533         * gnu-v3-abi.c: Update.
1534         * guile/guile-internal.h: Update.
1535         * guile/scm-block.c: Update.
1536         * guile/scm-breakpoint.c: Update.
1537         * guile/scm-cmd.c: Update.
1538         * guile/scm-disasm.c: Update.
1539         * guile/scm-frame.c: Update.
1540         * guile/scm-lazy-string.c: Update.
1541         * guile/scm-math.c: Update.
1542         * guile/scm-param.c: Update.
1543         * guile/scm-ports.c: Update.
1544         * guile/scm-pretty-print.c: Update.
1545         * guile/scm-symbol.c: Update.
1546         * guile/scm-symtab.c: Update.
1547         * guile/scm-type.c: Update.
1548         * guile/scm-value.c: Update.
1549         * i386-linux-tdep.c: Update.
1550         * i386-tdep.c: Update.
1551         * inf-loop.c: Update.
1552         * infcall.c: Update.
1553         * infcmd.c: Update.
1554         * infrun.c: Update.
1555         * jit.c: Update.
1556         * language.c: Update.
1557         * linespec.c: Update.
1558         * linux-fork.c: Update.
1559         * linux-nat.c: Update.
1560         * linux-tdep.c: Update.
1561         * linux-thread-db.c: Update.
1562         * main.c: Update.
1563         * mi/mi-cmd-break.c: Update.
1564         * mi/mi-cmd-stack.c: Update.
1565         * mi/mi-interp.c: Update.
1566         * mi/mi-main.c: Update.
1567         * objc-lang.c: Update.
1568         * p-valprint.c: Update.
1569         * parse.c: Update.
1570         * ppc-linux-tdep.c: Update.
1571         * printcmd.c: Update.
1572         * python/py-arch.c: Update.
1573         * python/py-breakpoint.c: Update.
1574         * python/py-cmd.c: Update.
1575         * python/py-finishbreakpoint.c: Update.
1576         * python/py-frame.c: Update.
1577         * python/py-framefilter.c: Update.
1578         * python/py-gdb-readline.c: Update.
1579         * python/py-inferior.c: Update.
1580         * python/py-infthread.c: Update.
1581         * python/py-lazy-string.c: Update.
1582         * python/py-linetable.c: Update.
1583         * python/py-objfile.c: Update.
1584         * python/py-param.c: Update.
1585         * python/py-prettyprint.c: Update.
1586         * python/py-progspace.c: Update.
1587         * python/py-record-btrace.c: Update.
1588         * python/py-record.c: Update.
1589         * python/py-symbol.c: Update.
1590         * python/py-type.c: Update.
1591         * python/py-unwind.c: Update.
1592         * python/py-utils.c: Update.
1593         * python/py-value.c: Update.
1594         * python/python.c: Update.
1595         * record-btrace.c: Update.
1596         * record-full.c: Update.
1597         * remote-fileio.c: Update.
1598         * remote.c: Update.
1599         * riscv-tdep.c: Update.
1600         * rs6000-aix-tdep.c: Update.
1601         * rs6000-tdep.c: Update.
1602         * rust-exp.y: Update.
1603         * rust-lang.c: Update.
1604         * s390-tdep.c: Update.
1605         * selftest-arch.c: Update.
1606         * solib-dsbt.c: Update.
1607         * solib-frv.c: Update.
1608         * solib-spu.c: Update.
1609         * solib-svr4.c: Update.
1610         * solib.c: Update.
1611         * sparc64-linux-tdep.c: Update.
1612         * stack.c: Update.
1613         * symfile-mem.c: Update.
1614         * symmisc.c: Update.
1615         * target.c: Update.
1616         * thread.c: Update.
1617         * top.c: Update.
1618         * tracefile-tfile.c: Update.
1619         * tui/tui.c: Update.
1620         * typeprint.c: Update.
1621         * unittests/cli-utils-selftests.c: Update.
1622         * unittests/parse-connection-spec-selftests.c: Update.
1623         * valops.c: Update.
1624         * valprint.c: Update.
1625         * value.c: Update.
1626         * varobj.c: Update.
1627         * windows-nat.c: Update.
1628         * x86-linux-nat.c: Update.
1629         * xml-support.c: Update.
1630
1631 2019-04-08  Tom Tromey  <tom@tromey.com>
1632
1633         * xml-support.c: Use C++ exception handling.
1634         * x86-linux-nat.c: Use C++ exception handling.
1635         * windows-nat.c: Use C++ exception handling.
1636         * varobj.c: Use C++ exception handling.
1637         * value.c: Use C++ exception handling.
1638         * valprint.c: Use C++ exception handling.
1639         * valops.c: Use C++ exception handling.
1640         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1641         handling.
1642         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1643         * typeprint.c: Use C++ exception handling.
1644         * tui/tui.c: Use C++ exception handling.
1645         * tracefile-tfile.c: Use C++ exception handling.
1646         * top.c: Use C++ exception handling.
1647         * thread.c: Use C++ exception handling.
1648         * target.c: Use C++ exception handling.
1649         * symmisc.c: Use C++ exception handling.
1650         * symfile-mem.c: Use C++ exception handling.
1651         * stack.c: Use C++ exception handling.
1652         * sparc64-linux-tdep.c: Use C++ exception handling.
1653         * solib.c: Use C++ exception handling.
1654         * solib-svr4.c: Use C++ exception handling.
1655         * solib-spu.c: Use C++ exception handling.
1656         * solib-frv.c: Use C++ exception handling.
1657         * solib-dsbt.c: Use C++ exception handling.
1658         * selftest-arch.c: Use C++ exception handling.
1659         * s390-tdep.c: Use C++ exception handling.
1660         * rust-lang.c: Use C++ exception handling.
1661         * rust-exp.y: Use C++ exception handling.
1662         * rs6000-tdep.c: Use C++ exception handling.
1663         * rs6000-aix-tdep.c: Use C++ exception handling.
1664         * riscv-tdep.c: Use C++ exception handling.
1665         * remote.c: Use C++ exception handling.
1666         * remote-fileio.c: Use C++ exception handling.
1667         * record-full.c: Use C++ exception handling.
1668         * record-btrace.c: Use C++ exception handling.
1669         * python/python.c: Use C++ exception handling.
1670         * python/py-value.c: Use C++ exception handling.
1671         * python/py-utils.c: Use C++ exception handling.
1672         * python/py-unwind.c: Use C++ exception handling.
1673         * python/py-type.c: Use C++ exception handling.
1674         * python/py-symbol.c: Use C++ exception handling.
1675         * python/py-record.c: Use C++ exception handling.
1676         * python/py-record-btrace.c: Use C++ exception handling.
1677         * python/py-progspace.c: Use C++ exception handling.
1678         * python/py-prettyprint.c: Use C++ exception handling.
1679         * python/py-param.c: Use C++ exception handling.
1680         * python/py-objfile.c: Use C++ exception handling.
1681         * python/py-linetable.c: Use C++ exception handling.
1682         * python/py-lazy-string.c: Use C++ exception handling.
1683         * python/py-infthread.c: Use C++ exception handling.
1684         * python/py-inferior.c: Use C++ exception handling.
1685         * python/py-gdb-readline.c: Use C++ exception handling.
1686         * python/py-framefilter.c: Use C++ exception handling.
1687         * python/py-frame.c: Use C++ exception handling.
1688         * python/py-finishbreakpoint.c: Use C++ exception handling.
1689         * python/py-cmd.c: Use C++ exception handling.
1690         * python/py-breakpoint.c: Use C++ exception handling.
1691         * python/py-arch.c: Use C++ exception handling.
1692         * printcmd.c: Use C++ exception handling.
1693         * ppc-linux-tdep.c: Use C++ exception handling.
1694         * parse.c: Use C++ exception handling.
1695         * p-valprint.c: Use C++ exception handling.
1696         * objc-lang.c: Use C++ exception handling.
1697         * mi/mi-main.c: Use C++ exception handling.
1698         * mi/mi-interp.c: Use C++ exception handling.
1699         * mi/mi-cmd-stack.c: Use C++ exception handling.
1700         * mi/mi-cmd-break.c: Use C++ exception handling.
1701         * main.c: Use C++ exception handling.
1702         * linux-thread-db.c: Use C++ exception handling.
1703         * linux-tdep.c: Use C++ exception handling.
1704         * linux-nat.c: Use C++ exception handling.
1705         * linux-fork.c: Use C++ exception handling.
1706         * linespec.c: Use C++ exception handling.
1707         * language.c: Use C++ exception handling.
1708         * jit.c: Use C++ exception handling.
1709         * infrun.c: Use C++ exception handling.
1710         * infcmd.c: Use C++ exception handling.
1711         * infcall.c: Use C++ exception handling.
1712         * inf-loop.c: Use C++ exception handling.
1713         * i386-tdep.c: Use C++ exception handling.
1714         * i386-linux-tdep.c: Use C++ exception handling.
1715         * guile/scm-value.c: Use C++ exception handling.
1716         * guile/scm-type.c: Use C++ exception handling.
1717         * guile/scm-symtab.c: Use C++ exception handling.
1718         * guile/scm-symbol.c: Use C++ exception handling.
1719         * guile/scm-pretty-print.c: Use C++ exception handling.
1720         * guile/scm-ports.c: Use C++ exception handling.
1721         * guile/scm-param.c: Use C++ exception handling.
1722         * guile/scm-math.c: Use C++ exception handling.
1723         * guile/scm-lazy-string.c: Use C++ exception handling.
1724         * guile/scm-frame.c: Use C++ exception handling.
1725         * guile/scm-disasm.c: Use C++ exception handling.
1726         * guile/scm-cmd.c: Use C++ exception handling.
1727         * guile/scm-breakpoint.c: Use C++ exception handling.
1728         * guile/scm-block.c: Use C++ exception handling.
1729         * guile/guile-internal.h: Use C++ exception handling.
1730         * gnu-v3-abi.c: Use C++ exception handling.
1731         * gdbtypes.c: Use C++ exception handling.
1732         * frame.c: Use C++ exception handling.
1733         * frame-unwind.c: Use C++ exception handling.
1734         * fbsd-tdep.c: Use C++ exception handling.
1735         * f-valprint.c: Use C++ exception handling.
1736         * exec.c: Use C++ exception handling.
1737         * event-top.c: Use C++ exception handling.
1738         * event-loop.c: Use C++ exception handling.
1739         * eval.c: Use C++ exception handling.
1740         * dwarf2read.c: Use C++ exception handling.
1741         * dwarf2loc.c: Use C++ exception handling.
1742         * dwarf2-frame.c: Use C++ exception handling.
1743         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1744         * dwarf-index-write.c: Use C++ exception handling.
1745         * dwarf-index-cache.c: Use C++ exception handling.
1746         * dtrace-probe.c: Use C++ exception handling.
1747         * disasm-selftests.c: Use C++ exception handling.
1748         * darwin-nat.c: Use C++ exception handling.
1749         * cp-valprint.c: Use C++ exception handling.
1750         * cp-support.c: Use C++ exception handling.
1751         * cp-abi.c: Use C++ exception handling.
1752         * corelow.c: Use C++ exception handling.
1753         * completer.c: Use C++ exception handling.
1754         * compile/compile-object-run.c: Use C++ exception handling.
1755         * compile/compile-object-load.c: Use C++ exception handling.
1756         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1757         * compile/compile-c-symbols.c: Use C++ exception handling.
1758         * common/selftest.c: Use C++ exception handling.
1759         * common/new-op.c: Use C++ exception handling.
1760         * cli/cli-script.c: Use C++ exception handling.
1761         * cli/cli-interp.c: Use C++ exception handling.
1762         * cli/cli-cmds.c: Use C++ exception handling.
1763         * c-varobj.c: Use C++ exception handling.
1764         * btrace.c: Use C++ exception handling.
1765         * breakpoint.c: Use C++ exception handling.
1766         * break-catch-throw.c: Use C++ exception handling.
1767         * arch-utils.c: Use C++ exception handling.
1768         * amd64-tdep.c: Use C++ exception handling.
1769         * ada-valprint.c: Use C++ exception handling.
1770         * ada-typeprint.c: Use C++ exception handling.
1771         * ada-lang.c: Use C++ exception handling.
1772         * aarch64-tdep.c: Use C++ exception handling.
1773
1774 2019-04-08  Tom Tromey  <tom@tromey.com>
1775
1776         * xml-support.c (gdb_xml_parser::parse): Update.
1777         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1778         * value.c (show_convenience): Update.
1779         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1780         (test_parse_flags_qcs): Update.
1781         * thread.c (thr_try_catch_cmd): Update.
1782         * target.c (target_translate_tls_address): Update.
1783         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1784         (info_frame_command_core, frame_apply_command_count): Update.
1785         * rust-exp.y (rust_lex_exception_test): Update.
1786         * riscv-tdep.c (riscv_print_one_register_info): Update.
1787         * remote.c (remote_target::enable_btrace): Update.
1788         * record-btrace.c (record_btrace_enable_warn): Update.
1789         * python/py-utils.c (gdbpy_convert_exception): Update.
1790         * printcmd.c (do_one_display, print_variable_and_value): Update.
1791         * mi/mi-main.c (mi_print_exception): Update.
1792         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1793         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1794         * linux-nat.c (linux_nat_target::attach): Update.
1795         * linux-fork.c (class scoped_switch_fork_info): Update.
1796         * infrun.c (displaced_step_prepare): Update.
1797         * infcall.c (call_function_by_hand_dummy): Update.
1798         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1799         * gnu-v3-abi.c (print_one_vtable): Update.
1800         * frame.c (get_prev_frame_always): Update.
1801         * f-valprint.c (info_common_command_for_block): Update.
1802         * exec.c (try_open_exec_file): Update.
1803         * exceptions.c (print_exception, exception_print)
1804         (exception_fprintf, exception_print_same): Update.
1805         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1806         * dwarf-index-cache.c (index_cache::store)
1807         (index_cache::lookup_gdb_index): Update.
1808         * darwin-nat.c (maybe_cache_shell): Update.
1809         * cp-valprint.c (cp_print_value_fields): Update.
1810         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1811         (gcc_cplus_symbol_address): Update.
1812         * compile/compile-c-symbols.c (gcc_convert_symbol)
1813         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1814         * common/selftest.c: Update.
1815         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1816         a std::string.
1817         (exception_try_scope_entry, exception_try_scope_exit): Don't
1818         declare.
1819         (struct exception_try_scope): Remove.
1820         (TRY): Don't use exception_try_scope.
1821         (struct gdb_exception): Add constructor, operator=.
1822         <what>: New method.
1823         (struct gdb_exception_RETURN_MASK_ALL)
1824         (struct gdb_exception_RETURN_MASK_ERROR)
1825         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1826         (struct gdb_quit_bad_alloc): Update.
1827         * common/common-exceptions.c (exception_none): Change
1828         initializer.
1829         (struct catcher) <state, exception>: Initialize inline.
1830         <prev>: Remove member.
1831         (current_catcher): Remove.
1832         (catchers): New global.
1833         (exceptions_state_mc_init): Simplify.
1834         (catcher_pop): Remove.
1835         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1836         (try_scope_depth, exception_try_scope_entry)
1837         (exception_try_scope_exit): Remove.
1838         (throw_exception_sjlj): Update.
1839         (exception_messages, exception_messages_size): Remove.
1840         (throw_it): Simplify.
1841         (gdb_exception_sliced_copy): Remove.
1842         (throw_exception_cxx): Update.
1843         * cli/cli-script.c (script_from_file): Update.
1844         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1845         Update.
1846         * ada-valprint.c (ada_val_print): Update.
1847         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1848         (create_excep_cond_exprs): Update.
1849
1850 2019-04-08  Tom Tromey  <tom@tromey.com>
1851
1852         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1853         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1854         (TRY, CATCH, END_CATCH): Remove some definitions.
1855         * common/common-exceptions.c: Don't use GDB_XCPT.
1856         (catcher_list_size): Remove.
1857         (throw_exception, throw_it): Simplify.
1858
1859 2019-04-05  Tom Tromey  <tom@tromey.com>
1860
1861         Revert the header-sorting patch.
1862         * ft32-tdep.c: Revert.
1863         * frv-tdep.c: Revert.
1864         * frv-linux-tdep.c: Revert.
1865         * frame.c: Revert.
1866         * frame-unwind.c: Revert.
1867         * frame-base.c: Revert.
1868         * fork-child.c: Revert.
1869         * findvar.c: Revert.
1870         * findcmd.c: Revert.
1871         * filesystem.c: Revert.
1872         * filename-seen-cache.h: Revert.
1873         * filename-seen-cache.c: Revert.
1874         * fbsd-tdep.c: Revert.
1875         * fbsd-nat.h: Revert.
1876         * fbsd-nat.c: Revert.
1877         * f-valprint.c: Revert.
1878         * f-typeprint.c: Revert.
1879         * f-lang.c: Revert.
1880         * extension.h: Revert.
1881         * extension.c: Revert.
1882         * extension-priv.h: Revert.
1883         * expprint.c: Revert.
1884         * exec.h: Revert.
1885         * exec.c: Revert.
1886         * exceptions.c: Revert.
1887         * event-top.c: Revert.
1888         * event-loop.c: Revert.
1889         * eval.c: Revert.
1890         * elfread.c: Revert.
1891         * dwarf2read.h: Revert.
1892         * dwarf2read.c: Revert.
1893         * dwarf2loc.c: Revert.
1894         * dwarf2expr.h: Revert.
1895         * dwarf2expr.c: Revert.
1896         * dwarf2-frame.c: Revert.
1897         * dwarf2-frame-tailcall.c: Revert.
1898         * dwarf-index-write.h: Revert.
1899         * dwarf-index-write.c: Revert.
1900         * dwarf-index-common.c: Revert.
1901         * dwarf-index-cache.h: Revert.
1902         * dwarf-index-cache.c: Revert.
1903         * dummy-frame.c: Revert.
1904         * dtrace-probe.c: Revert.
1905         * disasm.h: Revert.
1906         * disasm.c: Revert.
1907         * disasm-selftests.c: Revert.
1908         * dictionary.c: Revert.
1909         * dicos-tdep.c: Revert.
1910         * demangle.c: Revert.
1911         * dcache.h: Revert.
1912         * dcache.c: Revert.
1913         * darwin-nat.h: Revert.
1914         * darwin-nat.c: Revert.
1915         * darwin-nat-info.c: Revert.
1916         * d-valprint.c: Revert.
1917         * d-namespace.c: Revert.
1918         * d-lang.c: Revert.
1919         * ctf.c: Revert.
1920         * csky-tdep.c: Revert.
1921         * csky-linux-tdep.c: Revert.
1922         * cris-tdep.c: Revert.
1923         * cris-linux-tdep.c: Revert.
1924         * cp-valprint.c: Revert.
1925         * cp-support.c: Revert.
1926         * cp-namespace.c: Revert.
1927         * cp-abi.c: Revert.
1928         * corelow.c: Revert.
1929         * corefile.c: Revert.
1930         * continuations.c: Revert.
1931         * completer.h: Revert.
1932         * completer.c: Revert.
1933         * complaints.c: Revert.
1934         * coffread.c: Revert.
1935         * coff-pe-read.c: Revert.
1936         * cli-out.h: Revert.
1937         * cli-out.c: Revert.
1938         * charset.c: Revert.
1939         * c-varobj.c: Revert.
1940         * c-valprint.c: Revert.
1941         * c-typeprint.c: Revert.
1942         * c-lang.c: Revert.
1943         * buildsym.c: Revert.
1944         * buildsym-legacy.c: Revert.
1945         * build-id.h: Revert.
1946         * build-id.c: Revert.
1947         * btrace.c: Revert.
1948         * bsd-uthread.c: Revert.
1949         * breakpoint.h: Revert.
1950         * breakpoint.c: Revert.
1951         * break-catch-throw.c: Revert.
1952         * break-catch-syscall.c: Revert.
1953         * break-catch-sig.c: Revert.
1954         * blockframe.c: Revert.
1955         * block.c: Revert.
1956         * bfin-tdep.c: Revert.
1957         * bfin-linux-tdep.c: Revert.
1958         * bfd-target.c: Revert.
1959         * bcache.c: Revert.
1960         * ax-general.c: Revert.
1961         * ax-gdb.h: Revert.
1962         * ax-gdb.c: Revert.
1963         * avr-tdep.c: Revert.
1964         * auxv.c: Revert.
1965         * auto-load.c: Revert.
1966         * arm-wince-tdep.c: Revert.
1967         * arm-tdep.c: Revert.
1968         * arm-symbian-tdep.c: Revert.
1969         * arm-pikeos-tdep.c: Revert.
1970         * arm-obsd-tdep.c: Revert.
1971         * arm-nbsd-tdep.c: Revert.
1972         * arm-nbsd-nat.c: Revert.
1973         * arm-linux-tdep.c: Revert.
1974         * arm-linux-nat.c: Revert.
1975         * arm-fbsd-tdep.c: Revert.
1976         * arm-fbsd-nat.c: Revert.
1977         * arm-bsd-tdep.c: Revert.
1978         * arch-utils.c: Revert.
1979         * arc-tdep.c: Revert.
1980         * arc-newlib-tdep.c: Revert.
1981         * annotate.h: Revert.
1982         * annotate.c: Revert.
1983         * amd64-windows-tdep.c: Revert.
1984         * amd64-windows-nat.c: Revert.
1985         * amd64-tdep.c: Revert.
1986         * amd64-sol2-tdep.c: Revert.
1987         * amd64-obsd-tdep.c: Revert.
1988         * amd64-obsd-nat.c: Revert.
1989         * amd64-nbsd-tdep.c: Revert.
1990         * amd64-nbsd-nat.c: Revert.
1991         * amd64-nat.c: Revert.
1992         * amd64-linux-tdep.c: Revert.
1993         * amd64-linux-nat.c: Revert.
1994         * amd64-fbsd-tdep.c: Revert.
1995         * amd64-fbsd-nat.c: Revert.
1996         * amd64-dicos-tdep.c: Revert.
1997         * amd64-darwin-tdep.c: Revert.
1998         * amd64-bsd-nat.c: Revert.
1999         * alpha-tdep.c: Revert.
2000         * alpha-obsd-tdep.c: Revert.
2001         * alpha-nbsd-tdep.c: Revert.
2002         * alpha-mdebug-tdep.c: Revert.
2003         * alpha-linux-tdep.c: Revert.
2004         * alpha-linux-nat.c: Revert.
2005         * alpha-bsd-tdep.c: Revert.
2006         * alpha-bsd-nat.c: Revert.
2007         * aix-thread.c: Revert.
2008         * agent.c: Revert.
2009         * addrmap.c: Revert.
2010         * ada-varobj.c: Revert.
2011         * ada-valprint.c: Revert.
2012         * ada-typeprint.c: Revert.
2013         * ada-tasks.c: Revert.
2014         * ada-lang.c: Revert.
2015         * aarch64-tdep.c: Revert.
2016         * aarch64-ravenscar-thread.c: Revert.
2017         * aarch64-newlib-tdep.c: Revert.
2018         * aarch64-linux-tdep.c: Revert.
2019         * aarch64-linux-nat.c: Revert.
2020         * aarch64-fbsd-tdep.c: Revert.
2021         * aarch64-fbsd-nat.c: Revert.
2022         * aarch32-linux-nat.c: Revert.
2023
2024 2019-04-05  Tom Tromey  <tom@tromey.com>
2025
2026         * ft32-tdep.c: Sort headers.
2027         * frv-tdep.c: Sort headers.
2028         * frv-linux-tdep.c: Sort headers.
2029         * frame.c: Sort headers.
2030         * frame-unwind.c: Sort headers.
2031         * frame-base.c: Sort headers.
2032         * fork-child.c: Sort headers.
2033         * findvar.c: Sort headers.
2034         * findcmd.c: Sort headers.
2035         * filesystem.c: Sort headers.
2036         * filename-seen-cache.h: Sort headers.
2037         * filename-seen-cache.c: Sort headers.
2038         * fbsd-tdep.c: Sort headers.
2039         * fbsd-nat.h: Sort headers.
2040         * fbsd-nat.c: Sort headers.
2041         * f-valprint.c: Sort headers.
2042         * f-typeprint.c: Sort headers.
2043         * f-lang.c: Sort headers.
2044         * extension.h: Sort headers.
2045         * extension.c: Sort headers.
2046         * extension-priv.h: Sort headers.
2047         * expprint.c: Sort headers.
2048         * exec.h: Sort headers.
2049         * exec.c: Sort headers.
2050         * exceptions.c: Sort headers.
2051         * event-top.c: Sort headers.
2052         * event-loop.c: Sort headers.
2053         * eval.c: Sort headers.
2054         * elfread.c: Sort headers.
2055         * dwarf2read.h: Sort headers.
2056         * dwarf2read.c: Sort headers.
2057         * dwarf2loc.c: Sort headers.
2058         * dwarf2expr.h: Sort headers.
2059         * dwarf2expr.c: Sort headers.
2060         * dwarf2-frame.c: Sort headers.
2061         * dwarf2-frame-tailcall.c: Sort headers.
2062         * dwarf-index-write.h: Sort headers.
2063         * dwarf-index-write.c: Sort headers.
2064         * dwarf-index-common.c: Sort headers.
2065         * dwarf-index-cache.h: Sort headers.
2066         * dwarf-index-cache.c: Sort headers.
2067         * dummy-frame.c: Sort headers.
2068         * dtrace-probe.c: Sort headers.
2069         * disasm.h: Sort headers.
2070         * disasm.c: Sort headers.
2071         * disasm-selftests.c: Sort headers.
2072         * dictionary.c: Sort headers.
2073         * dicos-tdep.c: Sort headers.
2074         * demangle.c: Sort headers.
2075         * dcache.h: Sort headers.
2076         * dcache.c: Sort headers.
2077         * darwin-nat.h: Sort headers.
2078         * darwin-nat.c: Sort headers.
2079         * darwin-nat-info.c: Sort headers.
2080         * d-valprint.c: Sort headers.
2081         * d-namespace.c: Sort headers.
2082         * d-lang.c: Sort headers.
2083         * ctf.c: Sort headers.
2084         * csky-tdep.c: Sort headers.
2085         * csky-linux-tdep.c: Sort headers.
2086         * cris-tdep.c: Sort headers.
2087         * cris-linux-tdep.c: Sort headers.
2088         * cp-valprint.c: Sort headers.
2089         * cp-support.c: Sort headers.
2090         * cp-namespace.c: Sort headers.
2091         * cp-abi.c: Sort headers.
2092         * corelow.c: Sort headers.
2093         * corefile.c: Sort headers.
2094         * continuations.c: Sort headers.
2095         * completer.h: Sort headers.
2096         * completer.c: Sort headers.
2097         * complaints.c: Sort headers.
2098         * coffread.c: Sort headers.
2099         * coff-pe-read.c: Sort headers.
2100         * cli-out.h: Sort headers.
2101         * cli-out.c: Sort headers.
2102         * charset.c: Sort headers.
2103         * c-varobj.c: Sort headers.
2104         * c-valprint.c: Sort headers.
2105         * c-typeprint.c: Sort headers.
2106         * c-lang.c: Sort headers.
2107         * buildsym.c: Sort headers.
2108         * buildsym-legacy.c: Sort headers.
2109         * build-id.h: Sort headers.
2110         * build-id.c: Sort headers.
2111         * btrace.c: Sort headers.
2112         * bsd-uthread.c: Sort headers.
2113         * breakpoint.h: Sort headers.
2114         * breakpoint.c: Sort headers.
2115         * break-catch-throw.c: Sort headers.
2116         * break-catch-syscall.c: Sort headers.
2117         * break-catch-sig.c: Sort headers.
2118         * blockframe.c: Sort headers.
2119         * block.c: Sort headers.
2120         * bfin-tdep.c: Sort headers.
2121         * bfin-linux-tdep.c: Sort headers.
2122         * bfd-target.c: Sort headers.
2123         * bcache.c: Sort headers.
2124         * ax-general.c: Sort headers.
2125         * ax-gdb.h: Sort headers.
2126         * ax-gdb.c: Sort headers.
2127         * avr-tdep.c: Sort headers.
2128         * auxv.c: Sort headers.
2129         * auto-load.c: Sort headers.
2130         * arm-wince-tdep.c: Sort headers.
2131         * arm-tdep.c: Sort headers.
2132         * arm-symbian-tdep.c: Sort headers.
2133         * arm-pikeos-tdep.c: Sort headers.
2134         * arm-obsd-tdep.c: Sort headers.
2135         * arm-nbsd-tdep.c: Sort headers.
2136         * arm-nbsd-nat.c: Sort headers.
2137         * arm-linux-tdep.c: Sort headers.
2138         * arm-linux-nat.c: Sort headers.
2139         * arm-fbsd-tdep.c: Sort headers.
2140         * arm-fbsd-nat.c: Sort headers.
2141         * arm-bsd-tdep.c: Sort headers.
2142         * arch-utils.c: Sort headers.
2143         * arc-tdep.c: Sort headers.
2144         * arc-newlib-tdep.c: Sort headers.
2145         * annotate.h: Sort headers.
2146         * annotate.c: Sort headers.
2147         * amd64-windows-tdep.c: Sort headers.
2148         * amd64-windows-nat.c: Sort headers.
2149         * amd64-tdep.c: Sort headers.
2150         * amd64-sol2-tdep.c: Sort headers.
2151         * amd64-obsd-tdep.c: Sort headers.
2152         * amd64-obsd-nat.c: Sort headers.
2153         * amd64-nbsd-tdep.c: Sort headers.
2154         * amd64-nbsd-nat.c: Sort headers.
2155         * amd64-nat.c: Sort headers.
2156         * amd64-linux-tdep.c: Sort headers.
2157         * amd64-linux-nat.c: Sort headers.
2158         * amd64-fbsd-tdep.c: Sort headers.
2159         * amd64-fbsd-nat.c: Sort headers.
2160         * amd64-dicos-tdep.c: Sort headers.
2161         * amd64-darwin-tdep.c: Sort headers.
2162         * amd64-bsd-nat.c: Sort headers.
2163         * alpha-tdep.c: Sort headers.
2164         * alpha-obsd-tdep.c: Sort headers.
2165         * alpha-nbsd-tdep.c: Sort headers.
2166         * alpha-mdebug-tdep.c: Sort headers.
2167         * alpha-linux-tdep.c: Sort headers.
2168         * alpha-linux-nat.c: Sort headers.
2169         * alpha-bsd-tdep.c: Sort headers.
2170         * alpha-bsd-nat.c: Sort headers.
2171         * aix-thread.c: Sort headers.
2172         * agent.c: Sort headers.
2173         * addrmap.c: Sort headers.
2174         * ada-varobj.c: Sort headers.
2175         * ada-valprint.c: Sort headers.
2176         * ada-typeprint.c: Sort headers.
2177         * ada-tasks.c: Sort headers.
2178         * ada-lang.c: Sort headers.
2179         * aarch64-tdep.c: Sort headers.
2180         * aarch64-ravenscar-thread.c: Sort headers.
2181         * aarch64-newlib-tdep.c: Sort headers.
2182         * aarch64-linux-tdep.c: Sort headers.
2183         * aarch64-linux-nat.c: Sort headers.
2184         * aarch64-fbsd-tdep.c: Sort headers.
2185         * aarch64-fbsd-nat.c: Sort headers.
2186         * aarch32-linux-nat.c: Sort headers.
2187
2188 2019-04-04  Tom Tromey  <tom@tromey.com>
2189
2190         * varobj.c (varobj_create): Update.
2191         * rust-exp.y (struct rust_parser) <update_innermost_block,
2192         lookup_symbol>: New methods.
2193         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2194         Rename.
2195         (rust_parser::rust_lookup_type)
2196         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2197         * printcmd.c (display_command, do_one_display): Update.
2198         * parser-defs.h (struct parser_state) <parser_state>: Add
2199         "tracker" parameter.
2200         (block_tracker): New member.
2201         (class innermost_block_tracker) <innermost_block_tracker>: Add
2202         "types" parameter.
2203         <reset>: Remove method.
2204         (innermost_block): Don't declare.
2205         (null_post_parser): Update.
2206         * parse.c (innermost_block): Remove global.
2207         (write_dollar_variable): Update.
2208         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2209         Remove "tracker_types" parameter.
2210         (parse_expression): Add "tracker" parameter.
2211         (parse_expression_for_completion): Update.
2212         (null_post_parser): Add "tracker" parameter.
2213         * p-exp.y: Update rules.
2214         * m2-exp.y: Update rules.
2215         * language.h (struct language_defn) <la_post_parser>: Add
2216         "tracker" parameter.
2217         * go-exp.y: Update rules.
2218         * f-exp.y: Update rules.
2219         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2220         parameter.
2221         * d-exp.y: Update rules.
2222         * c-exp.y: Update rules.
2223         * breakpoint.c (set_breakpoint_condition): Create an
2224         innermost_block_tracker.
2225         (watch_command_1): Likewise.
2226         * ada-lang.c (resolve): Add "tracker" parameter.
2227         (resolve_subexp): Likewise.
2228         * ada-exp.y (write_var_from_sym): Update.
2229
2230 2019-04-04  Tom Tromey  <tom@tromey.com>
2231
2232         * type-stack.h: New file.
2233         * type-stack.c: New file.
2234         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2235         type-stack.h.
2236         (insert_into_type_stack, insert_type, push_type, push_type_int)
2237         (insert_type_address_space, pop_type, pop_type_int)
2238         (pop_typelist, pop_type_stack, append_type_stack)
2239         (push_type_stack, get_type_stack, push_typelist)
2240         (follow_type_instance_flags, follow_types): Don't declare.
2241         * parse.c (type_stack): Remove global.
2242         (parse_exp_in_context): Update.
2243         (insert_into_type_stack, insert_type, push_type, push_type_int)
2244         (insert_type_address_space, pop_type, pop_type_int)
2245         (pop_typelist, pop_type_stack, append_type_stack)
2246         (push_type_stack, get_type_stack, push_typelist)
2247         (follow_type_instance_flags, follow_types): Remove (moved to
2248         type-stack.c).
2249         * f-exp.y (type_stack): New global.
2250         Update rules.
2251         (push_kind_type, f_parse): Update.
2252         * d-exp.y (type_stack): New global.
2253         Update rules.
2254         (d_parse): Update.
2255         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2256         Update rules.
2257         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2258         (HFILES_NO_SRCDIR): Add type-stack.h.
2259
2260 2019-04-04  Tom Tromey  <tom@tromey.com>
2261
2262         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2263         (rust_parser::convert_ast_to_expression, rust_parse)
2264         (rust_lex_test_completion, rust_lex_tests): Update.
2265         * parser-defs.h (struct expr_completion_state): New.
2266         (struct parser_state) <parser_state>: Add completion parameter.
2267         <mark_struct_expression, mark_completion_tag>: New methods.
2268         <parse_completion, m_completion_state>: New members.
2269         (prefixify_expression, null_post_parser): Update.
2270         (mark_struct_expression, mark_completion_tag): Don't declare.
2271         * parse.c (parse_completion, expout_last_struct)
2272         (expout_tag_completion_type, expout_completion_name): Remove
2273         globals.
2274         (parser_state::mark_struct_expression)
2275         (parser_state::mark_completion_tag): Now methods.
2276         (prefixify_expression): Add last_struct parameter.
2277         (prefixify_subexp): Likewise.
2278         (parse_exp_1): Update.
2279         (parse_exp_in_context): Add cstate parameter.  Update.
2280         (parse_expression_for_completion): Create an
2281         expr_completion_state.
2282         (null_post_parser): Add "completion" parameter.
2283         * p-exp.y: Update rules.
2284         (yylex): Update.
2285         * language.h (struct language_defn) <la_post_parser>: Add
2286         "completing" parameter.
2287         * go-exp.y: Update rules.
2288         (lex_one_token): Update.
2289         * expression.h (parse_completion): Don't declare.
2290         * d-exp.y: Update rules.
2291         (lex_one_token): Update rules.
2292         * c-exp.y: Update rules.
2293         (lex_one_token): Update.
2294         * ada-lang.c (resolve): Add "parse_completion" parameter.
2295         (resolve_subexp): Likewise.
2296         (ada_resolve_function): Likewise.
2297
2298 2019-04-04  Tom Tromey  <tom@tromey.com>
2299
2300         * parser-defs.h (struct parser_state) <start_arglist,
2301         end_arglist>: New methods.
2302         <arglist_len, m_funcall_chain>: New members.
2303         (arglist_len, start_arglist, end_arglist): Don't declare.
2304         * parse.c (arglist_len, funcall_chain): Remove global.
2305         (start_arglist, end_arglist): Remove functions.
2306         (parse_exp_in_context): Update.
2307         * p-exp.y: Update rules.
2308         * m2-exp.y: Update rules.
2309         * go-exp.y: Update rules.
2310         * f-exp.y: Update rules.
2311         * d-exp.y: Update rules.
2312         * c-exp.y: Update rules.
2313
2314 2019-04-04  Tom Tromey  <tom@tromey.com>
2315
2316         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2317         lex_operator, push_back>: New methods.
2318         Update all rules.
2319         (rust_parser::lex_hex, lex_escape): Rename and update.
2320         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2321         (rust_parser::lex_operator): Rename and update.
2322         (rust_parser::lex_number, rustyylex, rustyyerror)
2323         (rust_lex_test_init, rust_lex_test_sequence)
2324         (rust_lex_test_push_back, rust_lex_tests): Update.
2325         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2326         parameter.
2327         <lexptr, prev_lexptr>: New members.
2328         (lexptr, prev_lexptr): Don't declare.
2329         * parse.c (lexptr, prev_lexptr): Remove globals.
2330         (parse_exp_in_context): Update.
2331         * p-exp.y (yylex, yyerror): Update.
2332         * m2-exp.y (parse_number, yylex, yyerror): Update.
2333         * go-exp.y (lex_one_token, yyerror): Update.
2334         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2335         * d-exp.y (lex_one_token, yyerror): Update.
2336         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2337         (lex_one_token, yyerror): Update.
2338         * ada-lex.l (YY_INPUT): Update.
2339         (rewind_to_char): Update.
2340         * ada-exp.y (yyerror): Update.
2341
2342 2019-04-04  Tom Tromey  <tom@tromey.com>
2343
2344         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2345         * parser-defs.h (struct parser_state) <parser_state>: Add new
2346         parameter.
2347         <comma_terminates>: New member.
2348         (comma_terminates): Don't declare global.
2349         * parse.c (comma_terminates): Remove global.
2350         (parse_exp_in_context): Update.
2351         * p-exp.y (yylex): Update.
2352         * m2-exp.y (yylex): Update.
2353         * go-exp.y (lex_one_token): Update.
2354         * f-exp.y (yylex): Update.
2355         * d-exp.y (lex_one_token): Update.
2356         * c-exp.y (lex_one_token): Update.
2357         * ada-lex.l: Update.
2358
2359 2019-04-04  Tom Tromey  <tom@tromey.com>
2360
2361         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2362         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2363         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2364         * parser-defs.h (paren_depth): Don't declare.
2365         * parse.c (paren_depth): Remove global.
2366         (parse_exp_in_context): Update.
2367         * p-exp.y (paren_depth): New global.
2368         (pascal_parse): Initialize it.
2369         * m2-exp.y (paren_depth): New global.
2370         (m2_parse): Initialize it.
2371         * go-exp.y (paren_depth): New global.
2372         (go_parse): Initialize it.
2373         * f-exp.y (paren_depth): New global.
2374         (f_parse): Initialize it.
2375         * d-exp.y (paren_depth): New global.
2376         (d_parse): Initialize it.
2377         * c-exp.y (paren_depth): New global.
2378         (c_parse): Initialize it.
2379         * ada-lex.l (paren_depth): New global.
2380         (lexer_init): Initialize it.
2381
2382 2019-04-04  Tom Tromey  <tom@tromey.com>
2383
2384         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2385         (rust_parser::convert_ast_to_type)
2386         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2387         * parser-defs.h (struct parser_state) <parser_state>: Add
2388         parameters.  Initialize new members.
2389         <expression_context_block, expression_context_pc>: New members.
2390         * parse.c (expression_context_block, expression_context_pc):
2391         Remove globals.
2392         (parse_exp_in_context): Update.
2393         * p-exp.y: Update all rules.
2394         (yylex): Update.
2395         * m2-exp.y: Update all rules.
2396         (yylex): Update.
2397         * go-exp.y (yylex): Update.
2398         * f-exp.y (yylex): Update.
2399         * d-exp.y: Update all rules.
2400         (yylex): Update.
2401         * c-exp.y: Update all rules.
2402         (lex_one_token, classify_name, yylex, c_parse): Update.
2403         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2404
2405 2019-04-04  Tom Tromey  <tom@tromey.com>
2406
2407         * gdbarch.h, gdbarch.c: Rebuild.
2408         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2409         * stap-probe.h:
2410         (struct stap_parse_info): Replace "parser_state" with
2411         "expr_builder".
2412         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2413         (parser_state): New class.
2414         * parse.c (expr_builder): Rename.
2415         (expr_builder::release): Rename.
2416         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2417         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2418         (write_exp_elt_longcst, write_exp_elt_floatcst)
2419         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2420         (write_exp_string_vector, write_exp_bitstring)
2421         (write_exp_msymbol, mark_struct_expression)
2422         (write_dollar_variable)
2423         (insert_type_address_space, increase_expout_size): Replace
2424         "parser_state" with "expr_builder".
2425         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2426         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2427         "parser_state" with "expr_builder".
2428
2429 2019-04-04  Tom Tromey  <tom@tromey.com>
2430
2431         * rust-exp.y: Replace "parse_language" with method call.
2432         * p-exp.y:
2433         (yylex): Replace "parse_language" with method call.
2434         * m2-exp.y:
2435         (yylex): Replace "parse_language" with method call.
2436         * go-exp.y (classify_name): Replace "parse_language" with method
2437         call.
2438         * f-exp.y (yylex): Replace "parse_language" with method call.
2439         * d-exp.y (lex_one_token): Replace "parse_language" with method
2440         call.
2441         * c-exp.y:
2442         (lex_one_token, classify_name, yylex): Replace "parse_language"
2443         with method call.
2444         * ada-exp.y (find_primitive_type, type_char)
2445         (type_system_address): Replace "parse_language" with method call.
2446
2447 2019-04-04  Tom Tromey  <tom@tromey.com>
2448
2449         * rust-exp.y: Replace "parse_gdbarch" with method call.
2450         * parse.c (write_dollar_variable, insert_type_address_space):
2451         Replace "parse_gdbarch" with method call.
2452         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2453         call.
2454         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2455         call.
2456         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2457         "parse_gdbarch" with method call.
2458         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2459         with method call.
2460         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2461         "parse_gdbarch" with method call.
2462         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2463         "parse_gdbarch" with method call.
2464         * c-exp.y (parse_type, parse_number, classify_name): Replace
2465         "parse_gdbarch" with method call.
2466         * ada-lex.l: Replace "parse_gdbarch" with method call.
2467         * ada-exp.y (parse_type, find_primitive_type, type_char)
2468         (type_system_address): Replace "parse_gdbarch" with method call.
2469
2470 2019-04-04  Tom Tromey  <tom@tromey.com>
2471
2472         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2473         * stap-probe.c (stap_parse_argument): Update.
2474         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2475         initial_size parameter.
2476         * rust-exp.y (rust_lex_tests): Update.
2477         * parse.c (parser_state): Update.
2478         (parse_exp_in_context): Update.
2479         * parser-defs.h (struct parser_state) <parser_state>: Remove
2480         "initial_size" parameter.
2481
2482 2019-04-04  Tom Tromey  <tom@tromey.com>
2483
2484         * parser-defs.h (increase_expout_size): Don't declare.
2485         * parse.c (increase_expout_size): Now static.
2486
2487 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2488
2489         * gnu-nat.c (gnu_nat_target::wait): Fix
2490         target_waitstatus_to_string call.
2491
2492 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2493
2494         * eval.c (evaluate_subexp_standard): Handle internal functions
2495         during Fortran function call handling.
2496
2497 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2498
2499         * NEWS: Mention new internal functions.
2500         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2501         (read_base_type): Use dwarf2_init_complex_target_type.
2502         * value.c (creal_internal_fn): New function.
2503         (cimag_internal_fn): New function.
2504         (_initialize_values): Register new internal functions.
2505
2506 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2507
2508         * infrun.c (stop_all_threads): If debug_infrun, always
2509         trace the wait status after wait_one, using
2510         target_waitstatus_to_string and target_pid_to_str.
2511         (handle_inferior_event): Replace various trace of
2512         wait status kind by a single trace.
2513         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2514         wait status kind image by target_waitstatus_to_string.
2515         * target/waitstatus.c (target_waitstatus_to_string): Fix
2516         obsolete comment.
2517
2518 2019-04-01  Tom Tromey  <tromey@adacore.com>
2519
2520         PR symtab/23331:
2521         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2522
2523 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2524             Pedro Alves  <palves@redhat.com>
2525
2526         * top.c (quit_force): Call 'finalize_values'.
2527         * value.c (finalize_values): New function.
2528         * value.h (finalize_values): Declare.
2529
2530 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2531
2532         * NEWS: Announce $_gdb_major and $_gdb_minor.
2533
2534         * top.c (init_gdb_version_vars): New function.
2535         (gdb_init): Call init_gdb_version_vars.
2536
2537 2019-03-29  Tom Tromey  <tromey@adacore.com>
2538
2539         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2540         help text.  Remove dead code.
2541
2542 2019-03-29  Keith Seitz  <keiths@redhat.com>
2543
2544         From Siddhesh Poyarekar:
2545         * f-lang.h (f77_get_upperbound): Return LONGEST.
2546         (f77_get_lowerbound): Likewise.
2547         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2548         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2549         print them.
2550         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2551         plongest to format print it.
2552         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2553         (f77_get_upperbound): Likewise.
2554         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2555         LOWER_BOUND to LONGEST.
2556         (f77_create_arrayprint_offset_tbl): Likewise.
2557
2558 2019-03-29  Keith Seitz  <keiths@redhat.com>
2559
2560         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2561         %s/pulongest for TYPE_LENGTH instead of %d in format
2562         strings.
2563         * ada-typerint.c (ada_print_type): Likewise.
2564         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2565         * compile/compile-c-support.c (generate_register_struct): Likewise.
2566         * gdbtypes.c (recursive_dump_type): Likewise.
2567         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2568         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2569         instead of %d in format strings.
2570         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2571         to std::min to ULONGEST.
2572         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2573         instead of %d in format strings.
2574         * tracepoint.c (info_scope_command): Likewise.
2575         * typeprint.c (print_offset_data::update)
2576         (print_offset_data::finish): Likewise.
2577         * xtensa-tdep.c (xtensa_store_return_value)
2578         (xtensa_push_dummy_call): Likewise.
2579
2580 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2581
2582         * windows-nat.c (display_selector): Fixed format specifications
2583         for 64-bit Cygwin.
2584
2585 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2586
2587         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2588
2589 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2590
2591         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2592         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2593         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2594         (nios2_linux_init_abi): Install it.
2595
2596 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2597
2598         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2599
2600 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2601
2602         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2603
2604 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2605             Tom Tromey  <tromey@adacore.com>
2606
2607         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2608
2609 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2610
2611         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2612         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2613         method to compute the bounds of range types. Also print "[evaluated]"
2614         if the bounds' values come from a dynamic evaluation.
2615
2616 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2619         whitespace when pretty printing is on.
2620
2621 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2622
2623         * ppc-linux-nat.c: Add include.
2624
2625 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2626
2627         * NEWS: Mention AArch64 Pointer Authentication.
2628
2629 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2630
2631         * arm-linux-nat.c: Add include.
2632
2633 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2634
2635         * source-cache.c (source_cache::get_source_lines): Re-read
2636         fullname after calling open_source_file.
2637
2638 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2639
2640         * NEWS: Mention TLS support for FreeBSD.
2641
2642 2019-03-25  Tom Tromey  <tromey@adacore.com>
2643
2644         * minsyms.c (BUNCH_SIZE): Update comment.
2645         (~minimal_symbol_reader): Remove old comment.
2646         (compact_minimal_symbols): Update comment.
2647         (minimal_symbol_reader::install): Remove old comment.  Update
2648         other comments.
2649
2650 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2651
2652         * s390-linux-nat.c: Add include.
2653
2654 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2655
2656         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2657         Call linux_get_hwcap.
2658         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2659         Likewise.
2660         (aarch64_linux_get_hwcap): Remove function.
2661         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2662         declaration.
2663         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2664         linux_get_hwcap.
2665         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2666         * linux-tdep.c (linux_get_hwcap): Add function.
2667         (linux_get_hwcap2): Likewise.
2668         * linux-tdep.h (linux_get_hwcap): Add declaration.
2669         (linux_get_hwcap2): Likewise.
2670         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2671         (ppc_linux_get_hwcap2): Likewise.
2672         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2673         linux_get_hwcap.
2674         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2675         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2676         (ppc_linux_nat_target::read_description): Likewise.
2677         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2678         * s390-linux-nat.c: Likewise.
2679         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2680
2681 2019-03-24  Tom Tromey  <tom@tromey.com>
2682
2683         * ada-lang.c (standard_lookup): Simplify initialization.
2684         (ada_lookup_symbol_nonlocal): Simplify return.
2685         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2686         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2687         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2688         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2689         initialization.
2690         * solib.c (solib_global_lookup): Simplify.
2691         * symtab.c (null_block_symbol): Remove.
2692         (symbol_cache_lookup): Simplify returns.
2693         (lookup_language_this): Simplify returns.
2694         (lookup_symbol_aux): Simplify return.
2695         (lookup_local_symbol): Simplify returns.
2696         (lookup_global_symbol_from_objfile): Simplify return.
2697         (lookup_symbol_in_objfile_symtabs)
2698         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2699         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2700         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2701         * cp-namespace.c (cp_lookup_bare_symbol)
2702         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2703         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2704         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2705         (cp_lookup_symbol_via_imports): Simplify initialization.
2706         (find_symbol_in_baseclass): Likewise.
2707         * symtab.h (null_block_symbol): Remove.
2708         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2709         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2710         (d_lookup_symbol_module): Likewise.
2711         (find_symbol_in_baseclass): Simplify initialization.
2712
2713 2019-03-24  Tom Tromey  <tom@tromey.com>
2714
2715         * expression.h: Don't include symtab.h.
2716         (struct block): Forward declare.
2717
2718 2019-03-24  Tom Tromey  <tom@tromey.com>
2719
2720         * c-exp.y (typebase): Remove casts.
2721         * gdbtypes.c (lookup_unsigned_typename, )
2722         (lookup_signed_typename): Remove cast.
2723         * eval.c (parse_to_comma_and_eval): Remove cast.
2724         * parse.c (write_dollar_variable): Remove cast.
2725         * block.h (struct block) <superblock>: Now const.
2726         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2727         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2728         (map_block): Make "block" const.
2729         * symfile.h (struct quick_symbol_functions)
2730         <map_matching_symbols>: Constify block argument to "callback".
2731         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2732         const.
2733         (find_pc_sect_compunit_symtab): Make "b" const.
2734         (find_symbol_at_address): Likewise.
2735         (search_symbols): Likewise.
2736         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2737         (dw2_debug_names_lookup_symbol): Likewise.
2738         (dw2_map_matching_symbols): Update.
2739         * p-valprint.c (pascal_val_print): Remove "block".
2740         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2741         (aux_add_nonlocal_symbols): Make "block" const.
2742         (resolve_subexp): Remove cast.
2743         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2744         const.
2745         (iterate_over_file_blocks): Likewise.
2746         * f-exp.y (%union) <bval>: Remove.
2747         * coffread.c (patch_opaque_types): Make "b" const.
2748         * spu-tdep.c (spu_catch_start): Make "block" const.
2749         * c-valprint.c (print_unpacked_pointer): Remove "block".
2750         * symmisc.c (dump_symtab_1): Make "b" const.
2751         (block_depth): Make "block" const.
2752         * d-exp.y (%union) <bval>: Remove.
2753         * cp-support.h (cp_lookup_rtti_type): Update.
2754         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2755         * psymtab.c (psym_lookup_symbol): Make "block" const.
2756         (maintenance_check_psymtabs): Make "b" const.
2757         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2758         (enumerate_locals, enumerate_args): Update.
2759         * python/py-symtab.c (stpy_global_block): Make "block" const.
2760         (stpy_static_block): Likewise.
2761         * inline-frame.c (block_starting_point_at): Make "new_block"
2762         const.
2763         * block.c (find_block_in_blockvector): Make return type const.
2764         (blockvector_for_pc_sect): Make "b" const.
2765         (find_block_in_blockvector): Make "b" const.
2766
2767 2019-03-23  Tom Tromey  <tom@tromey.com>
2768
2769         * varobj.c (varobj_create): Update.
2770         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2771         * printcmd.c (display_command, do_one_display): Don't reset
2772         innermost_block.
2773         * parser-defs.h (enum innermost_block_tracker_type): Move to
2774         expression.h.
2775         (innermost_block): Update comment.
2776         * parse.c (parse_exp_1): Add tracker_types parameter.
2777         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2778         tracker_types parameter.  Reset innermost_block.
2779         (parse_exp_in_context): Remove.
2780         (parse_expression_for_completion): Update.
2781         * objfiles.c (~objfile): Don't reset expression_context_block or
2782         innermost_block.
2783         * expression.h (enum innermost_block_tracker_type): Move from
2784         parser-defs.h.
2785         (parse_exp_1): Add tracker_types parameter.
2786         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2787         reset innermost_block.
2788
2789 2019-03-23  Tom Tromey  <tom@tromey.com>
2790
2791         * objfiles.h: Include bcache.h.
2792
2793 2019-03-23  Tom Tromey  <tom@tromey.com>
2794
2795         * linespec.c (get_current_search_block): Use
2796         scoped_restore_current_language.
2797         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2798
2799 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2800             Jiong Wang  <jiong.wang@arm.com>
2801
2802         * aarch64-linux-tdep.c
2803         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2804         section.
2805         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2806
2807 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2808             Jiong Wang  <jiong.wang@arm.com>
2809
2810         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2811         instructions.
2812         (aarch64_analyze_prologue_test): Add PACIASP test.
2813         (aarch64_prologue_prev_register): Unmask PC value.
2814
2815 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2816             Jiong Wang  <jiong.wang@arm.com>
2817
2818         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2819         (aarch64_dwarf2_prev_register): Unmask PC value.
2820         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2821         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2822         DW_CFA_AARCH64_negate_ra_state.
2823         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2824
2825 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2826             Jiong Wang  <jiong.wang@arm.com>
2827
2828         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2829         registers.
2830         (aarch64_pseudo_register_name): Likewise.
2831         (aarch64_pseudo_register_type): Likewise.
2832         (aarch64_pseudo_register_reggroup_p): Likewise.
2833         (aarch64_gdbarch_init): Add pauth registers.
2834         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2835         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2836         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2837         (struct gdbarch_tdep): Add regnum for ra_state.
2838
2839 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2840             Jiong Wang  <jiong.wang@arm.com>
2841
2842         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2843
2844 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2845             Jiong Wang  <jiong.wang@arm.com>
2846
2847         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2848         function.
2849         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2850         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2851         (aarch64_gdbarch_init): Add puth registers.
2852         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2853         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2854         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2855
2856 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2857             Jiong Wang  <jiong.wang@arm.com>
2858
2859         * aarch64-linux-nat.c
2860         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2861         * aarch64-linux-tdep.c
2862         (aarch64_linux_core_read_description): Likewise.
2863         (aarch64_linux_get_hwcap): New function.
2864         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2865         (aarch64_linux_get_hwcap): New declaration.
2866
2867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2868             Jiong Wang  <jiong.wang@arm.com>
2869
2870         * aarch64-linux-nat.c
2871         (aarch64_linux_nat_target::read_description): Add pauth param.
2872         * aarch64-linux-tdep.c
2873         (aarch64_linux_core_read_description): Likewise.
2874         * aarch64-tdep.c (struct target_desc): Add in pauth.
2875         (aarch64_read_description): Add pauth param.
2876         (aarch64_gdbarch_init): Likewise.
2877         * aarch64-tdep.h (aarch64_read_description): Likewise.
2878         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2879         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2880         * features/Makefile: Add new files.
2881         * features/aarch64-pauth.c: New file.
2882         * features/aarch64-pauth.xml: New file.
2883
2884 2019-03-20  Tom Tromey  <tromey@adacore.com>
2885
2886         * infrun.c (handle_inferior_event): Rename from
2887         handle_inferior_event_1.  Create a scoped_value_mark.
2888         (handle_inferior_event): Remove.
2889
2890 2019-03-19  Tom Tromey  <tromey@adacore.com>
2891
2892         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2893         * infrun.h (print_stop_event): Add "displays" parameter.
2894         * infrun.c (print_stop_event): Add "displays" parameter.
2895
2896 2019-03-19  Pedro Alves  <palves@redhat.com>
2897
2898         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2899         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2900         to -1.  Fix TABs vs spaces.
2901         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2902         * tui/tui-out.h (tui_ui_out) Add intro comments.
2903         <m_line, m_start_of_line>: In-class initialize, and add describing
2904         comment.
2905
2906 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2907
2908         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2909         variable names.
2910         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2911
2912 2019-03-18  Pedro Alves  <palves@redhat.com>
2913             Eli Zaretskii <eliz@gnu.org>
2914
2915         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2916         m_line and m_start_of_line.
2917
2918 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2919
2920         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2921         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2922         it returns a newline.  This fixes a regression in TU mode, whereby
2923         the next line is output on the same screen line as the user input.
2924
2925 2019-03-18  Tom Tromey  <tromey@adacore.com>
2926
2927         * minsyms.c (minimal_symbol_reader::install): Remove call to
2928         obstack_blank.
2929
2930 2019-03-18  Pedro Alves  <palves@redhat.com>
2931
2932         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2933         New globals.
2934         (apply_style): New, factored out from ...
2935         (apply_ansi_escape): ... this.  Handle reverse video mode.
2936         (tui_set_reverse_mode): New function.
2937         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2938         * tui/tui-winsource.c (tui_show_source_line): Use
2939         tui_set_reverse_mode instead of setting A_STANDOUT.
2940         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2941         New setter methods.
2942
2943 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2944
2945         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2946         Handle tabs.
2947
2948 2019-03-18  Tom Tromey  <tromey@adacore.com>
2949
2950         * ada-lang.c (empty_array): Add "high" parameter.
2951         (ada_evaluate_subexp): Update.
2952
2953 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2954
2955         * unittests/string_view-selftests.c: Define
2956         _initialize_string_view_selftests unconditionally.
2957
2958 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2959
2960         PR gdb/24350
2961         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2962
2963 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2964
2965         PR gdb/24351
2966         * windows-nat.c (display_selector): Fix format specifiers.
2967
2968 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2969
2970         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2971         tui_refill_source_window instead of tui_refresh_win, to update the
2972         current execution line.  This fixes redisplay of the current line
2973         when stepping through the code with "next" or "step".
2974
2975 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2976
2977         * source-cache.c (source_cache::get_source_lines): Call
2978         find_source_lines to initialize s->nlines.  This fixes vertical
2979         scrolling of TUI source window when the DOWN arrow is pressed.
2980
2981 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2982
2983         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2984         linux-thread-db.c (_initialize_thread_db): Likewise.
2985
2986 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2987
2988         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2989         wclrtoeol in tui_show_source_line".  This reverts changes made in
2990         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2991
2992 2019-03-15  Tom Tromey  <tom@tromey.com>
2993
2994         * symtab.h (struct minimal_symbol): Derive from
2995         general_symbol_info.
2996         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2997         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2998         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2999         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3000         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3001         (MSYMBOL_SEARCH_NAME): Update.
3002         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3003         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3004         * minsyms.c (minimal_symbol_reader::record_full): Update.
3005
3006 2019-03-15  Tom Tromey  <tom@tromey.com>
3007
3008         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3009
3010 2019-03-15  Tom Tromey  <tom@tromey.com>
3011
3012         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3013         unique_xmalloc_ptr.
3014         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3015         Update.
3016         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3017         (build_minimal_symbol_hash_tables)
3018         (minimal_symbol_reader::install): Update.
3019
3020 2019-03-15  Tom Tromey  <tom@tromey.com>
3021
3022         * symtab.c (create_demangled_names_hash): Update.
3023         (symbol_set_names): Update.
3024         * objfiles.h (struct objfile_per_bfd_storage)
3025         <demangled_names_hash>: Now an htab_up.
3026         * objfiles.c (objfile_per_bfd_storage): Simplify.
3027
3028 2019-03-15  Tom Tromey  <tom@tromey.com>
3029
3030         * objfiles.h (struct objfile_per_bfd_storage): Declare
3031         destructor.
3032         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3033         New.
3034         (get_objfile_bfd_data): Use new.  Don't initialize
3035         language_of_main.
3036         (free_objfile_per_bfd_storage): Remove.
3037         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3038
3039 2019-03-15  Tom Tromey  <tom@tromey.com>
3040
3041         * symfile.c (reread_symbols): Update.
3042         * objfiles.c (objfile::objfile): Update.
3043         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3044         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3045         comment.
3046         (minimal_symbol_reader::install): Update.
3047         (terminate_minimal_symbol_table): Remove.
3048         * jit.c (jit_object_close_impl): Update.
3049
3050 2019-03-15  Tom Tromey  <tom@tromey.com>
3051
3052         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3053         initializations.
3054
3055 2019-03-15  Tom Tromey  <tom@tromey.com>
3056
3057         * objfiles.h (struct objfile_per_bfd_storage)
3058         <demangled_hash_languages>: Now a bitset.
3059         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3060         (lookup_minimal_symbol): Update.
3061
3062 2019-03-15  Tom Tromey  <tom@tromey.com>
3063
3064         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3065         Don't return the symbol.
3066         * coffread.c (record_minimal_symbol): Use record_full.
3067
3068 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3069
3070         The MS-Windows port of ncurses fails to switch to a color pair if
3071         one or both of the colors are the implicit default colors.  This
3072         change records the default colors when TUI is initialized, and
3073         then specifies them explicitly when a color pair uses the default
3074         colors.  This allows color styling in TUI mode on MS-Windows.
3075
3076         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3077         ncurses_norm_attr.
3078         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3079         colors in ncurses_norm_attr.
3080         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3081         "none", replace it with the default color recorded in
3082         ncurses_norm_attr.
3083
3084 2019-03-14  Tom Tromey  <tromey@adacore.com>
3085
3086         * source-cache.h (class source_cache) <get_source_lines>: Return
3087         std::string.
3088         * source-cache.c (source_cache::extract_lines): Handle case where
3089         first_pos==npos.  Return std::string.
3090         (source_cache::get_source_lines): Update.
3091
3092 2019-03-14  Tom Tromey  <tromey@adacore.com>
3093
3094         * NEWS: Add item for "style sources" commands.
3095         * source-cache.c (source_cache::get_source_lines): Check
3096         source_styling.
3097         * cli/cli-style.c (source_styling): New global.
3098         (_initialize_cli_style): Add "style sources" commands.
3099         (show_style_sources): New function.
3100         * cli/cli-style.h (source_styling): Declare.
3101
3102 2019-03-14  Pedro Alves  <palves@redhat.com>
3103             Tom Tromey  <tromey@adacore.com>
3104
3105         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3106         * tui/tui-winsource.c (tui_refill_source_window): New function,
3107         from...
3108         (tui_horizontal_source_scroll): ... here.  Move some logic.
3109         * cli/cli-style.c (set_style_enabled): Notify new observable.
3110         * tui/tui-hooks.c (tui_redisplay_source): New function.
3111         (tui_attach_detach_observers): Attach or detach
3112         tui_redisplay_source.
3113         * observable.h (source_styling_changed): New observable.
3114         * observable.c: Define source_styling_changed observable.
3115
3116 2019-03-13  Tom Tromey  <tromey@adacore.com>
3117
3118         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3119         (i386_gnu_nat_target::store_registers): Update.
3120         * target-debug.h (target_debug_print_std_string): New macro.
3121         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3122         * windows-tdep.c (display_one_tib): Update.
3123         * tui/tui-stack.c (tui_make_status_line): Update.
3124         * top.c (print_inferior_quit_action): Update.
3125         * thread.c (thr_try_catch_cmd): Update.
3126         (add_thread_with_info): Update.
3127         (thread_target_id_str): Update.
3128         (thr_try_catch_cmd): Update.
3129         (thread_command): Update.
3130         (thread_find_command): Update.
3131         * record-btrace.c (record_btrace_target::info_record)
3132         (record_btrace_resume_thread, record_btrace_target::resume)
3133         (record_btrace_cancel_resume, record_btrace_step_thread)
3134         (record_btrace_target::wait, record_btrace_target::wait)
3135         (record_btrace_target::wait, record_btrace_target::stop): Update.
3136         * progspace.c (print_program_space): Update.
3137         * process-stratum-target.c
3138         (process_stratum_target::thread_address_space): Update.
3139         * linux-fork.c (linux_fork_mourn_inferior)
3140         (detach_checkpoint_command, info_checkpoints_command)
3141         (linux_fork_context): Update.
3142         (linux_fork_detach): Update.
3143         (class scoped_switch_fork_info): Update.
3144         (delete_checkpoint_command): Update.
3145         * infrun.c (follow_fork_inferior): Update.
3146         (follow_fork_inferior): Update.
3147         (proceed_after_vfork_done): Update.
3148         (handle_vfork_child_exec_or_exit): Update.
3149         (follow_exec): Update.
3150         (displaced_step_prepare_throw): Update.
3151         (displaced_step_restore): Update.
3152         (start_step_over): Update.
3153         (resume_1): Update.
3154         (clear_proceed_status_thread): Update.
3155         (proceed): Update.
3156         (print_target_wait_results): Update.
3157         (do_target_wait): Update.
3158         (context_switch): Update.
3159         (stop_all_threads): Update.
3160         (restart_threads): Update.
3161         (finish_step_over): Update.
3162         (handle_signal_stop): Update.
3163         (switch_back_to_stepped_thread): Update.
3164         (keep_going_pass_signal): Update.
3165         (print_exited_reason): Update.
3166         (normal_stop): Update.
3167         * inferior.c (inferior_pid_to_str): Change return type.
3168         (print_selected_inferior): Update.
3169         (add_inferior): Update.
3170         (detach_inferior): Update.
3171         * dummy-frame.c (fprint_dummy_frames): Update.
3172         * dcache.c (dcache_info_1): Update.
3173         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3174         (btrace_fetch, btrace_clear): Update.
3175         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3176         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3177         type.
3178         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3179         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3180         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3181         * gdbarch.c, gdbarch.h: Rebuild.
3182         * gdbarch.sh (core_pid_to_str): Change return type.
3183         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3184         return type.
3185         (windows_nat_target::pid_to_str): Change return type.
3186         (windows_delete_thread): Update.
3187         (windows_nat_target::attach): Update.
3188         (windows_nat_target::files_info): Update.
3189         * target-delegates.c: Rebuild.
3190         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3191         return type.
3192         (sol_thread_target::pid_to_str): Change return type.
3193         * remote.c (class remote_target) <pid_to_str>: Change return
3194         type.
3195         (remote_target::pid_to_str): Change return type.
3196         (extended_remote_target::attach, remote_target::remote_stop_ns)
3197         (remote_target::remote_notif_remove_queued_reply)
3198         (remote_target::push_stop_reply, remote_target::disable_btrace):
3199         Update.
3200         (extended_remote_target::attach): Update.
3201         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3202         type.
3203         (gdbsim_target::pid_to_str): Change return type.
3204         * ravenscar-thread.c (struct ravenscar_thread_target)
3205         <pid_to_str>: Change return type.
3206         (ravenscar_thread_target::pid_to_str): Change return type.
3207         * procfs.c (class procfs_target) <pid_to_str>: Change return
3208         type.
3209         (procfs_target::pid_to_str): Change return type.
3210         (procfs_target::attach): Update.
3211         (procfs_target::detach): Update.
3212         (procfs_target::fetch_registers): Update.
3213         (procfs_target::store_registers): Update.
3214         (procfs_target::wait): Update.
3215         (procfs_target::files_info): Update.
3216         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3217         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3218         return type.
3219         (nto_procfs_target::pid_to_str): Change return type.
3220         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3221         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3222         return type.
3223         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3224         (exit_lwp): Update.
3225         (attach_proc_task_lwp_callback, get_detach_signal)
3226         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3227         (linux_nat_target::resume, wait_lwp, stop_callback)
3228         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3229         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3230         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3231         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3232         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3233         type.
3234         (inf_ptrace_target::attach): Update.
3235         (inf_ptrace_target::files_info): Update.
3236         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3237         type.
3238         (go32_nat_target::pid_to_str): Change return type.
3239         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3240         (gnu_nat_target::wait): Update.
3241         (gnu_nat_target::wait): Update.
3242         (gnu_nat_target::resume): Update.
3243         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3244         (fbsd_nat_target::wait): Update.
3245         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3246         type.
3247         (darwin_nat_target::attach): Update.
3248         * corelow.c (class core_target) <pid_to_str>: Change return type.
3249         (core_target::pid_to_str): Change return type.
3250         * target.c (normal_pid_to_str): Change return type.
3251         (default_pid_to_str): Likewise.
3252         (target_pid_to_str): Change return type.
3253         (target_translate_tls_address): Update.
3254         (target_announce_detach): Update.
3255         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3256         return type.
3257         (bsd_uthread_target::pid_to_str): Change return type.
3258         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3259         type.
3260         (bsd_kvm_target::pid_to_str): Change return type.
3261         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3262         return type.
3263         (aix_thread_target::pid_to_str): Change return type.
3264         * target.h (struct target_ops) <pid_to_str>: Change return type.
3265         (target_pid_to_str, normal_pid_to_str): Likewise.
3266         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3267         type.
3268         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3269         type.
3270         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3271         return type.
3272         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3273         type.
3274         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3275         type.
3276         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3277         return type.
3278
3279 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3280
3281         * NEWS: Mention that the new default MI version is 3.  Mention
3282         changes to the output of commands and events that deal with
3283         multi-location breakpoints.
3284         * breakpoint.c: Include "mi/mi-out.h".
3285         (print_one_breakpoint): Change output syntax if using MI version
3286         >= 3.
3287         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3288         New.
3289         (mi_multi_location_breakpoint_output_fixed): New.
3290         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3291         (mi_cmd_fix_multi_location_breakpoint_output): New.
3292         (mi_multi_location_breakpoint_output_fixed): New.
3293         * mi/mi-cmds.c (mi_cmds): Register command
3294         -fix-multi-location-breakpoint-output.
3295         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3296         interpreter "mi".
3297
3298 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3299
3300         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3301         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3302         instantiate mi_ui_out based on interpreter name.
3303         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3304         * mi/mi-main.c (mi_load_progress): Likewise.
3305
3306 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3307
3308         * NEWS: Combine separate "New targets" sections for 8.3.
3309
3310 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3311
3312         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3313         (ppcfbsd_init_abi): Install gdbarch
3314         "fetch_tls_load_module_address" and "get_thread_local_address"
3315         methods.
3316
3317 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3318
3319         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3320         (riscv_fbsd_init_abi): Install gdbarch
3321         "fetch_tls_load_module_address" and "get_thread_local_address"
3322         methods.
3323
3324 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3325
3326         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3327         (i386fbsd_init_abi): Install gdbarch
3328         "fetch_tls_load_module_address" and "get_thread_local_address"
3329         methods.
3330
3331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3332
3333         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3334         (amd64fbsd_init_abi): Install gdbarch
3335         "fetch_tls_load_module_address" and "get_thread_local_address"
3336         methods.
3337
3338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3339
3340         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3341         (struct fbsd_pspace_data): New type.
3342         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3343         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3344         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3345         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3346         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3347
3348 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3349
3350         * gdbtypes.c (lookup_struct_elt): New function.
3351         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3352         * gdbtypes.h (struct struct_elt): New type.
3353         (lookup_struct_elt): New prototype.
3354
3355 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3356
3357         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3358         remove disabled code block.
3359
3360 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3361
3362         * gdbarch.sh (get_thread_local_address): New method.
3363         * gdbarch.h, gdbarch.c: Regenerate.
3364         * target.c (target_translate_tls_address): Use
3365         gdbarch_get_thread_local_address if present instead of
3366         target::get_thread_local_address.
3367
3368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3369
3370         * target.h (target::get_thread_local_address): Update comment.
3371
3372 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3373
3374         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3375         objfile->separate_debug_objfile_backlink if not NULL.
3376
3377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3378
3379         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3380         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3381         (amd64bsd_store_inferior_registers): Likewise.
3382         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3383         Enable segment base registers.
3384         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3385         PT_GETFSBASE and PT_GETGSBASE.
3386         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3387         PT_SETGSBASE.
3388         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3389         segment base registers.
3390         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3391
3392 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3393
3394         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3395         Update calls to i386_target_description to add 'segments'
3396         parameter.
3397         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3398         add segment base registers.
3399         * arch/i386.c (i386_create_target_description): Add 'segments'
3400         parameter to enable segment base registers.
3401         * arch/i386.h (i386_create_target_description): Likewise.
3402         * features/i386/32bit-segments.xml: New file.
3403         * features/i386/32bit-segments.c: Generate.
3404         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3405         call to i386_target_description to add 'segments' parameter.
3406         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3407         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3408         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3409         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3410         if feature is present.
3411         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3412         Add 'segments' parameter to call to i386_target_description.
3413         (i386_target_description): Add 'segments' parameter to enable
3414         segment base registers.
3415         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3416         to call to i386_target_description.
3417         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3418         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3419         Define I386_NUM_REGS.
3420         (i386_target_description): Add 'segments' parameter to enable
3421         segment base registers.
3422
3423 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3424
3425         PR/24325
3426         * source-cache.c: #undef open and close, to avoid unresolved
3427         externals during linking.
3428
3429 2019-03-12  Tom Tromey  <tromey@adacore.com>
3430
3431         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3432         const.  Add initializers.
3433         (_initialize_remote): Don't initialize ptid globals.
3434
3435 2019-03-12  Pedro Alves  <palves@redhat.com>
3436
3437         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3438
3439 2019-03-12  Pedro Alves  <palves@redhat.com>
3440
3441         * cp-name-parser.y (main): Remove unused 'len' variable.
3442
3443 2019-03-12  Tom Tromey  <tromey@adacore.com>
3444
3445         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3446         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3447
3448 2019-03-12  Tom Tromey  <tromey@adacore.com>
3449
3450         * linux-nat.c (iterate_over_lwps): Update.
3451         (stop_callback): Remove parameter.
3452         (stop_wait_callback, detach_callback, resume_set_callback)
3453         (select_singlestep_lwp_callback, set_ignore_sigint)
3454         (status_callback, resumed_callback, resume_clear_callback)
3455         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3456         data parameter.
3457         (linux_nat_target::detach, linux_nat_target::resume)
3458         (linux_stop_and_wait_all_lwps, select_event_lwp)
3459         (linux_nat_filter_event, linux_nat_wait_1)
3460         (linux_nat_target::kill, linux_nat_target::stop)
3461         (linux_nat_target::stop): Update.
3462         (linux_nat_resume_callback): Change type.
3463         (resume_stopped_resumed_lwps, count_events_callback)
3464         (select_event_lwp_callback): Likewise.
3465         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3466         * arm-linux-nat.c (struct update_registers_data): Remove.
3467         (update_registers_callback): Change type.
3468         (arm_linux_insert_hw_breakpoint1): Update.
3469         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3470         parameter.
3471         (x86_linux_dr_set_addr): Update.
3472         (x86_linux_dr_set_control): Update.
3473         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3474         (iterate_over_lwps): Use gdb::function_view.
3475         * nat/aarch64-linux-hw-point.c (struct
3476         aarch64_dr_update_callback_param): Remove.
3477         (debug_reg_change_callback): Change type.
3478         (aarch64_notify_debug_reg_change): Update.
3479         * s390-linux-nat.c (s390_refresh_per_info): Update.
3480
3481 2019-03-11  Tom Tromey  <tromey@adacore.com>
3482
3483         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3484         redundant assignment to "this_cu".
3485
3486 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3487
3488         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3489
3490 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3491
3492         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3493         from...
3494         (rank_one_type): ... this.
3495
3496 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3497
3498         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3499         from...
3500         (rank_one_type): ... this.
3501
3502 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3503
3504         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3505         from...
3506         (rank_one_type): ... this.
3507
3508 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3509
3510         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3511         from...
3512         (rank_one_type): ... this.
3513
3514 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3515
3516         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3517         from...
3518         (rank_one_type): ... this.
3519
3520 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3521
3522         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3523         from...
3524         (rank_one_type): ... this.
3525
3526 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3527
3528         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3529         from...
3530         (rank_one_type): ... this.
3531
3532 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3533
3534         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3535         from...
3536         (rank_one_type): ... this.
3537
3538 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3539
3540         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3541         from...
3542         (rank_one_type): ... this.
3543
3544 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3545
3546         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3547         from...
3548         (rank_one_type): ... this.
3549
3550 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3551
3552         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3553         from...
3554         (rank_one_type): ... this.
3555
3556 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3557
3558         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3559         from...
3560         (rank_one_type): ... this.
3561
3562 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3563
3564         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3565         inferior-events' shows the example events.
3566
3567 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3568
3569         Support styling on native MS-Windows console
3570
3571         PR/24315
3572         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3573         on MS-Windows if $TERM is not defined.
3574
3575         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3576
3577         * posix-hdep.c (gdb_console_fputs):
3578         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3579         functions.
3580         * ui-file.h (gdb_console_fputs): Add prototype.
3581
3582         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3583         back to fputs only if the former returns zero.
3584
3585 2019-03-07  Tom Tromey  <tom@tromey.com>
3586
3587         * symmisc.c (print_symbol_bcache_statistics): Update.
3588         (print_objfile_statistics): Update.
3589         * symfile.c (allocate_symtab): Update.
3590         * stabsread.c: Don't include bcache.h.
3591         * psymtab.h (struct psymbol_bcache): Don't declare.
3592         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3593         (psymbol_bcache_init, psymbol_bcache_free)
3594         (psymbol_bcache_get_bcache): Don't declare.
3595         * psymtab.c (struct psymbol_bcache): Remove.
3596         (psymtab_storage::psymtab_storage): Update.
3597         (psymtab_storage::~psymtab_storage): Update.
3598         (psymbol_bcache_init, psymbol_bcache_free)
3599         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3600         (add_psymbol_to_bcache): Update.
3601         (allocate_psymtab): Update.
3602         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3603         macro_cache>: No longer pointers.
3604         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3605         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3606         * macrotab.c (macro_bcache): Update.
3607         * macroexp.c: Don't include bcache.h.
3608         * gdbtypes.c (check_types_worklist): Update.
3609         (types_deeply_equal): Remove TRY/CATCH.  Update.
3610         * elfread.c (elf_symtab_read): Update.
3611         * dwarf2read.c: Don't include bcache.h.
3612         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3613         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3614         (print_bcache_statistics, bcache_memory_used): Don't declare.
3615         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3616         methods.  Rename all data members.
3617         * bcache.c (struct bcache): Move to bcache.h.
3618         (bcache::expand_hash_table): Rename from expand_hash_table.
3619         (bcache): Remove.
3620         (bcache::insert): Rename from bcache_full.
3621         (bcache::compare): Rename from bcache_compare.
3622         (bcache_xmalloc): Remove.
3623         (bcache::~bcache): Rename from bcache_xfree.
3624         (bcache::print_statistics): Rename from print_bcache_statistics.
3625         (bcache::memory_used): Rename from bcache_memory_used.
3626
3627 2019-03-07  Pedro Alves  <palves@redhat.com>
3628
3629         * infrun.c (normal_stop): Also check for
3630         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3631
3632 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3633
3634         * f-lang.c (value_from_host_double): Moved to...
3635         * value.c (value_from_host_double): ...here.
3636         * value.h (value_from_host_double): Declare.
3637         * guile/scm-math.c (vlscm_convert_typed_number): Use
3638         value_from_host_double.
3639         (vlscm_convert_number): Likewise.
3640         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3641         * python/py-value.c (convert_value_from_python): Likewise.
3642
3643 2019-03-06  Tom Tromey  <tom@tromey.com>
3644
3645         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3646
3647 2019-03-06  Tom Tromey  <tom@tromey.com>
3648
3649         * utils.h (free_current_contents): Don't declare.
3650         * utils.c (free_current_contents): Remove.
3651
3652 2019-03-06  Tom Tromey  <tom@tromey.com>
3653
3654         * top.c (quit_force): Update.
3655         * main.c (captured_command_loop): Update.
3656         * common/new-op.c (operator new): Update.
3657         * common/common-exceptions.c (struct catcher)
3658         <save_cleanup_chain>: Remove member.
3659         (exceptions_state_mc_init): Update.
3660         (exception_try_scope_entry): Return nullptr.
3661         (exception_try_scope_exit, exception_rethrow)
3662         (throw_exception_sjlj, throw_exception_cxx): Update.
3663         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3664         (all_cleanups, do_cleanups, discard_cleanups)
3665         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3666         (restore_cleanups, restore_final_cleanups): Don't declare.
3667         (do_final_cleanups): Remove parameter.
3668         * common/cleanups.c (cleanup_chain, make_cleanup)
3669         (make_cleanup_dtor, all_cleanups, do_cleanups)
3670         (discard_my_cleanups, discard_cleanups)
3671         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3672         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3673         (null_cleanup): Remove.
3674         (do_final_cleanups): Remove parameter.
3675
3676 2019-03-06  Tom Tromey  <tom@tromey.com>
3677
3678         * remote.c (remote_target::remote_parse_stop_reply): Use
3679         unique_xmalloc_ptr.
3680
3681 2019-03-06  Tom Tromey  <tom@tromey.com>
3682
3683         * stabsread.c (struct stabs_field_info): Rename from field_info.
3684         <list, fnlist>: Add initializers.
3685         <obstack>: New member.
3686         (read_member_functions, read_struct_fields, read_baseclasses):
3687         Allocate on obstack.  Don't use cleanups.
3688         (read_one_struct_field, read_member_functions, read_struct_fields)
3689         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3690         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3691         (read_struct_type): Update.
3692
3693 2019-03-06  Tom Tromey  <tom@tromey.com>
3694
3695         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3696         * common/filestuff.h (make_cleanup_close): Don't declare.
3697         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3698         Remove.
3699
3700 2019-03-06  Tom Tromey  <tom@tromey.com>
3701
3702         * solib-aix.c: Use make_scope_exit.
3703
3704 2019-03-06  Tom Tromey  <tom@tromey.com>
3705
3706         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3707         Use make_scope_exit.
3708
3709 2019-03-06  Tom Tromey  <tom@tromey.com>
3710
3711         * solib-svr4.c (disable_probes_interface): Remove parameter.
3712         (svr4_handle_solib_event): Use make_scope_exit.
3713
3714 2019-03-06  Tom Tromey  <tom@tromey.com>
3715
3716         * remote.c (struct stop_reply_deleter): Remove.
3717         (stop_reply_up): Update.
3718         (struct stop_reply): Derive from notif_event.  Don't typedef.
3719         <regcache>: Now a std::vector.
3720         (stop_reply_xfree): Remove.
3721         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3722         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3723         (remote_target::discard_pending_stop_replies): Use delete.
3724         (remote_target::remote_parse_stop_reply): Update.
3725         (remote_target::process_stop_reply): Update.
3726         * remote-notif.h (struct notif_event): Add virtual destructor.
3727         Remove "dtr" member.
3728         (struct notif_client) <alloc_event>: Return a unique_ptr.
3729         (notif_event_xfree): Don't declare.
3730         (notif_event_up): New typedef.
3731         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3732         (notif_event_xfree, do_notif_event_xfree): Remove.
3733         (remote_notif_state_xfree): Update.
3734
3735 2019-03-06  Tom Tromey  <tom@tromey.com>
3736
3737         * infrun.c (displaced_step_clear_cleanup): Now a
3738         forward_scope_exit type.
3739         (displaced_step_prepare_throw): Update.
3740         (displaced_step_fixup): Update.
3741
3742 2019-03-06  Tom Tromey  <tom@tromey.com>
3743
3744         * inferior.h (class inferior): Update comment.
3745         * gdbthread.h (class thread_info): Update comment.
3746
3747 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3748             Tom Tromey  <tom@tromey.com>
3749
3750         * stabsread.h (struct stab_section_list): Remove.
3751         (coffstab_build_psymtabs): Update.
3752         * dbxread.c (symbuf_sections): Now a std::vector.
3753         (sect_idx): New global.
3754         (fill_symbuf): Update.
3755         (coffstab_build_psymtabs): Change type of stabsects parameter.
3756         Update.
3757         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3758         std::vector.
3759         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3760         (coff_locate_sections): Update.
3761         (coff_symfile_read): Remove cleanups.  Update.
3762         (init_stringtab): Add storage parameter.
3763         (free_stringtab, free_stringtab_cleanup): Remove.
3764         (init_lineno): Add storage parameter.
3765         (free_linetab, free_linetab_cleanup): Remove.
3766
3767 2019-03-06  Pedro Alves  <palves@redhat.com>
3768
3769         * linux-fork.c (fork_info::clobber_regs): Delete.
3770         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3771         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3772         comment.  Adjust.
3773         (scoped_switch_fork_info::scoped_switch_fork_info)
3774         (checkpoint_command, linux_fork_context): Adjust
3775         fork_save_infrun_state calls.
3776
3777 2019-03-06  Pedro Alves  <palves@redhat.com>
3778
3779         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3780         (inf_has_multiple_threads): Return 'bool' and rewrite using
3781         inferior_info::threads().
3782
3783 2019-03-06  Pedro Alves  <palves@redhat.com>
3784
3785         * linux-fork.c: Include <list>.
3786         (fork_list): Now a std::list instance.
3787         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3788         (forks_exist_p, find_last_fork): Adjust.
3789         (new_fork): Delete.
3790         (one_fork_p): New.
3791         (add_fork): Adjust.
3792         (free_fork): Delete, folded into fork_info::~fork_info().
3793         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3794         Adjust.
3795         (init_fork_list): Delete.
3796         (linux_fork_killall, linux_fork_mourn_inferior)
3797         (linux_fork_detach, info_checkpoints_command): Adjust.
3798         (_initialize_linux_fork): No longer call init_fork_list.
3799
3800 2019-03-06  Pedro Alves  <palves@redhat.com>
3801
3802         * linux-fork.c (new_fork): New, split out of ...
3803         (add_fork): ... this.  Return void.  Move "first fork" special
3804         case from here, to ...
3805         (checkpoint_command): ... here.
3806         * linux-linux.h (add_fork): Return void.
3807
3808 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3809
3810         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3811
3812 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3813             Chris January  <chris.january@arm.com>
3814             David Lecomber  <david.lecomber@arm.com>
3815
3816         * f-exp.y: New token, UNOP_INTRINSIC.
3817         (exp): New pattern using UNOP_INTRINSIC token.
3818         (f77_keywords): Add 'abs' keyword.
3819         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3820         (value_from_host_double): New function.
3821         (evaluate_subexp_f): Support UNOP_ABS.
3822
3823 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3826         types.
3827
3828 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3829
3830         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3831         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3832         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3833
3834 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3837
3838 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3839             Chris January  <chris.january@arm.com>
3840
3841         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3842         * f-exp.y: Define 'KIND' token.
3843         (exp): New pattern for KIND expressions.
3844         (ptype): Handle types with a kind extension.
3845         (direct_abs_decl): Extend to spot kind extensions.
3846         (f77_keywords): Add 'kind' to the list.
3847         (push_kind_type): New function.
3848         (convert_to_kind_type): New function.
3849         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3850         * parse.c (operator_length_standard): Likewise.
3851         * parser-defs.h (enum type_pieces): Add tp_kind.
3852         * std-operator.def: Add UNOP_KIND.
3853
3854 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * f-exp.y (f_parse): Set yydebug.
3857
3858 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3859
3860         * f-lang.c (evaluate_subexp_f): New function.
3861         (exp_descriptor_f): New global.
3862         (f_language_defn): Use exp_descriptor_f instead of
3863         exp_descriptor_standard.
3864
3865 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         * f-exp.y (struct token): Add comments.
3868         (dot_ops): Remove uppercase versions and the end marker.
3869         (f77_keywords): Likewise.
3870         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3871         entries in the dot_ops array are case insensitive, and use
3872         strncasecmp to compare strings.  Also some whitespace cleanup in
3873         this area.  Similar for the f77_keywords array, except entries in
3874         this list might be case sensitive.
3875
3876 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * f-exp.y (struct f77_boolean_val): Add comments.
3879         (boolean_values): Remove uppercase versions, and end marker.
3880         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3881         and use strncasecmp to achieve case insensitivity.  Additionally,
3882         perform whitespace cleanup around this code.
3883
3884 2019-03-06  Tom Tromey  <tromey@adacore.com>
3885
3886         * remote-sim.c (gdbsim_target_open): Use result of
3887         gdb_argv::release.
3888
3889 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3890         Dirk Schubert  <dirk.schubert@arm.com>
3891         Chris January  <chris.january@arm.com>
3892
3893         * eval.c (evaluate_subexp_standard): Call Fortran argument
3894         wrapping logic.
3895         * f-lang.c (struct value): A value which can be passed into a
3896         Fortran function call.
3897         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3898         where appropriate.
3899         (struct type): Value ready for a Fortran function call.
3900         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3901         is needed.
3902         * f-lang.h (fortran_argument_convert): Declaration.
3903         (fortran_preserve_arg_pointer): Declaration.
3904         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3905
3906 2019-03-05  Tom Tromey  <tromey@adacore.com>
3907
3908         * python/py-prettyprint.c (print_string_repr): Remove #if.
3909         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3910
3911 2019-03-05  Tom Tromey  <tromey@adacore.com>
3912
3913         * target.c (the_dummy_target): Move later.  Change type to
3914         "dummy_target".
3915         (initialize_targets): Don't initialize the_dummy_target.
3916
3917 2019-03-05  Tom Tromey  <tromey@adacore.com>
3918
3919         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3920         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3921
3922 2019-03-05  Tom Tromey  <tromey@adacore.com>
3923
3924         * windows-nat.c (windows_nat_target::attach)
3925         (windows_nat_target::detach): Don't call gdb_flush.
3926         * valprint.c (generic_val_print, val_print, val_print_string):
3927         Don't call gdb_flush.
3928         * utils.c (defaulted_query): Don't call gdb_flush.
3929         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3930         * target.c (target_announce_detach): Don't call gdb_flush.
3931         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3932         * remote.c (extended_remote_target::attach): Don't call
3933         gdb_flush.
3934         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3935         * printcmd.c (do_examine): Don't call gdb_flush.
3936         (info_display_command): Don't call gdb_flush.
3937         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3938         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3939         * memattr.c (info_mem_command): Don't call gdb_flush.
3940         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3941         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3942         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3943         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3944         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3945         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3946         (gnu_nat_target::detach): Don't call gdb_flush.
3947         * f-valprint.c (f_val_print): Don't call gdb_flush.
3948         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3949         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3950         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3951         gdb_flush.
3952         * c-valprint.c (c_val_print): Don't call gdb_flush.
3953         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3954
3955 2019-03-05  Tom Tromey  <tromey@adacore.com>
3956
3957         * varobj.c (update_dynamic_varobj_children): Update.
3958         (install_default_visualizer): Use reset, not release.
3959         * value.c (set_internalvar): Update.
3960         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3961         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3962         ATTRIBUTE_UNUSED_RESULT.
3963
3964 2019-03-05  Tom Tromey  <tromey@adacore.com>
3965
3966         * remote.c (class scoped_remote_fd) <release>: Add
3967         ATTRIBUTE_UNUSED_RESULT.
3968
3969 2019-03-05  Tom Tromey  <tromey@adacore.com>
3970
3971         * macroexp.c (struct macro_buffer) <release>: Add
3972         ATTRIBUTE_UNUSED_RESULT.
3973
3974 2019-03-05  Tom Tromey  <tromey@adacore.com>
3975
3976         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3977         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3978         ATTRIBUTE_UNUSED_RESULT.
3979
3980 2019-03-05  Tom Tromey  <tromey@adacore.com>
3981
3982         * common/scoped_fd.h (class scoped_fd) <release>: Add
3983         ATTRIBUTE_UNUSED_RESULT.
3984
3985 2019-03-05  Tom Tromey  <tromey@adacore.com>
3986
3987         * parser-defs.h (struct parser_state) <release>: Add
3988         ATTRIBUTE_UNUSED_RESULT.
3989
3990 2019-03-05  Tom Tromey  <tromey@adacore.com>
3991
3992         * utils.h (class gdb_argv) <release>: Add
3993         ATTRIBUTE_UNUSED_RESULT.
3994         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3995
3996 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3997
3998         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3999         for-loop range, to avoid compiler warnings.
4000
4001         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4002         avoid compiler warnings about unused variables.
4003
4004         * NEWS: Mention end of support for native debugging on MS-Windows
4005         before XP.
4006
4007         PR gdb/24292
4008         * common/netstuff.c:
4009         * gdbserver/gdbreplay.c
4010         * gdbserver/remote-utils.c:
4011         * ser-tcp.c:
4012         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4013         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4014         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4015         'getaddrinfo' and 'freeaddrinfo' were not available before
4016         Windows XP, and mingw.org's MinGW headers by default define
4017         _WIN32_WINNT to 0x500.
4018
4019 2019-03-01  Gary Benson <gbenson@redhat.com>
4020
4021         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4022
4023 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4024             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4025
4026         PR gdb/8527
4027         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4028         set_sigint_trap, clear_sigint_trap.
4029
4030 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * target.c (target_detach): Clear the regcache and the
4033         frame cache.
4034
4035 2019-02-27  Pedro Alves  <palves@redhat.com>
4036
4037         * utils.c (set_screen_size): When we cap the height/width sizes,
4038         tweak the corresponding command variable to show "unlimited":
4039
4040 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4041             Pedro Alves  <palves@redhat.com>
4042
4043         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4044         before calling rl_set_screen_size.
4045
4046 2019-02-27  Tom Tromey  <tromey@adacore.com>
4047
4048         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4049         define.
4050         * python/py-value.c: Remove Python 2.4 workaround.
4051         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4052         workaround.
4053         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4054         Python 2.4 workaround.
4055         * python/python-internal.h: Remove Python 2.4 comment.
4056         (Py_ssize_t): Don't define.
4057         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4058         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4059         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4060         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4061         * python/python.c (do_start_initialization): Remove Python 2.4
4062         workaround.
4063         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4064         (print_children): Remove Python 2.4 workaround.
4065         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4066         workaround.
4067         (CHARBUFFERPROC_NAME): Remove.
4068         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4069         Python 2.4 workaround.
4070
4071 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4072
4073         * NEWS: Note minimum Python version.
4074
4075 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4076
4077         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4078         code from these functions.  Remove corresponding ifdefs.  Use
4079         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4080         Remove gotos and target of gotos.
4081         (infpy_search_memory): Likewise.
4082
4083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4084
4085         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4086         (hppa_gdbarch_init): Don't register deleted functions with
4087         gdbarch.
4088
4089 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4092         (h8300_unwind_sp): Delete.
4093         (h8300_dummy_id): Delete.
4094         (h8300_gdbarch_init): Don't register deleted functions with
4095         gdbarch.
4096
4097 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4100         (ft32_unwind_pc): Delete.
4101         (ft32_unwind_sp): Delete.
4102         (ft32_gdbarch_init): Don't register deleted functions with
4103         gdbarch.
4104
4105 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4108         (frv_unwind_pc): Delete.
4109         (frv_unwind_sp): Delete.
4110         (frv_gdbarch_init): Don't register deleted functions with
4111         gdbarch.
4112
4113 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4116         (riscv_unwind_pc): Delete.
4117         (riscv_unwind_sp): Delete.
4118         (riscv_gdbarch_init): Don't register deleted functions with
4119         gdbarch.
4120
4121 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4122
4123         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4124         (csky_unwind_pc): Delete.
4125         (csky_unwind_sp): Delete.
4126         (csky_gdbarch_init): Don't register deleted functions with
4127         gdbarch.
4128
4129 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4130
4131         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4132         (cris_unwind_pc): Delete.
4133         (cris_unwind_sp): Delete.
4134         (cris_gdbarch_init): Don't register deleted functions with
4135         gdbarch.
4136
4137 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4140         (bfin_unwind_pc): Delete.
4141         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4142
4143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4144
4145         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4146         (arm_unwind_pc): Delete.
4147         (arm_unwind_sp): Delete.
4148         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4149
4150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4151
4152         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4153         (arc_unwind_pc): Delete.
4154         (arc_unwind_sp): Delete.
4155         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4156
4157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4160         (alpha_unwind_pc): Delete.
4161         (alpha_gdbarch_init): Don't register deleted functions with
4162         gdbarch.
4163
4164 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4167         (aarch64_unwind_pc): Delete.
4168         (aarch64_unwind_sp): Delete.
4169         (aarch64_gdbarch_init): Don't register deleted functions with
4170         gdbarch.
4171
4172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4173
4174         * gdbtypes.c (type_align): Don't consider static members when
4175         computing structure alignment.
4176
4177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4178
4179         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4180         return 0 for other types.
4181         * arch-utils.c (default_type_align): Always return 0.
4182         * gdbarch.h: Regenerate.
4183         * gdbarch.sh (type_align): Extend comment.
4184         * gdbtypes.c (type_align): Add additional comments, always call
4185         gdbarch_type_align before applying the default rules.
4186         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4187         generic code will then apply a suitable default.
4188         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4189         types, return 0 for other types.
4190
4191 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4192
4193         * NEWS: Create a new section for the next release branch.
4194         Rename the section of the current branch, now that it has
4195         been cut.
4196
4197 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4198
4199         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4200         * version.in: Bump version to 8.3.50.DATE-git.
4201
4202 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4203
4204         * aix-thread.c (ptid_cmp): Remove unused variable.
4205         (get_signaled_thread): Likewise.
4206         (store_regs_user_thread): Likewise.
4207         (store_regs_kernel_thread): Likewise.
4208         (fetch_regs_kernel_thread): Remove shadowed variable.
4209
4210 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4211
4212         * features/riscv/32bit-cpu.xml: Add register numbers.
4213         * features/riscv/32bit-fpu.c: Regenerate.
4214         * features/riscv/32bit-fpu.xml: Add register numbers.
4215         * features/riscv/64bit-cpu.xml: Add register numbers.
4216         * features/riscv/64bit-fpu.c: Regenerate.
4217         * features/riscv/64bit-fpu.xml: Add register numbers.
4218
4219 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4220
4221         * NEWS: Mention two argument form of gdb.Value constructor.
4222         * python/py-value.c (convert_buffer_and_type_to_value): New
4223         function.
4224         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4225         Add support for handling an optional second argument.  Call
4226         convert_buffer_and_type_to_value as appropriate.
4227         * python/python-internal.h (Py_buffer_deleter): New struct.
4228         (Py_buffer_up): New typedef.
4229
4230 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4231
4232         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4233         instead of releasing ownership.
4234
4235 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4236
4237         * dwarf2read.c (open_and_init_dwp_file): Call
4238         elf_numsections instead of bfd_count_sections to initialize
4239         dwp_file->num_sections.
4240
4241 2019-02-25  Tom Tromey  <tromey@adacore.com>
4242
4243         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4244
4245 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4246
4247         * gcore.in: Add '--readnever' option when invoking GDB.
4248
4249 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4250
4251         * MAINTAINERS: Update my email address.
4252
4253 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4254
4255         * build-id.c (build_id_to_debug_bfd_1): New function.
4256         (build_id_to_debug_bfd): Look for separate debug file in
4257         sysroot.
4258
4259 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * gdbarch.sh: Update the copyright year range that is placed into
4262         generated files.
4263
4264 2019-02-22  Keith Seitz  <keiths@redhat.com>
4265
4266         PR symtab/23853
4267         * linespec.c (create_sals_line_offset): Search for the default
4268         symtab's filename instead of its fullname.
4269
4270 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4271
4272         * NEWS: Update style defaults.
4273
4274 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4275
4276         * main.c (captured_main_1): Disable styling in batch mode.
4277
4278 2019-02-20  Tom Tromey  <tom@tromey.com>
4279
4280         * symtab.c (symtab_symbol_info): Fix typos.
4281
4282 2019-02-20  Tom Tromey  <tromey@adacore.com>
4283
4284         * findcmd.c (_initialize_mem_search): Use upper case for
4285         metasyntactic variables.
4286
4287 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4288
4289         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4290         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4291
4292 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4293
4294         * top.h (source_file_name): Change to std::string.
4295         * top.c (source_file_name): Likewise.
4296         (command_line_input): Adjust.
4297         * cli/cli-script.c (script_from_file): Adjust.
4298
4299 2019-02-19  Tom Tromey  <tromey@adacore.com>
4300
4301         * ravenscar-thread.c
4302         (ravenscar_thread_target::update_thread_list): Don't call
4303         ada_build_task_list.
4304         * ada-lang.h (ada_build_task_list): Don't declare.
4305         * ada-tasks.c (struct ada_tasks_inferior_data)
4306         <task_list_valid_p>: Now bool.
4307         (read_known_tasks, ada_task_list_changed)
4308         (ada_tasks_invalidate_inferior_data): Update.
4309         (read_known_tasks_array): Return bool.
4310         (read_known_tasks_list): Likewise.
4311         (read_known_tasks): Return void.
4312         (ada_build_task_list): Now static.
4313
4314 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4315
4316         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4317         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4318
4319 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4320
4321         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4322         variant for ada_tasks_pspace_data_handle and
4323         ada_tasks_inferior_data_handle.
4324         (ada_tasks_pspace_data_cleanup): New function.
4325         (ada_tasks_inferior_data_cleanup): New function.
4326
4327 2019-02-17  Tom Tromey  <tom@tromey.com>
4328
4329         * macrotab.h (macro_source_fullname): Return a std::string.
4330         * macrotab.c (macro_include, check_for_redefinition)
4331         (macro_undef, macro_lookup_definition, foreach_macro)
4332         (foreach_macro_in_scope): Update.
4333         (macro_source_fullname): Return a std::string.
4334         * macrocmd.c (show_pp_source_pos): Update.
4335
4336 2019-02-17  Tom Tromey  <tom@tromey.com>
4337
4338         * macrocmd.c (show_pp_source_pos): Style the file names.
4339
4340 2019-02-17  Tom Tromey  <tom@tromey.com>
4341
4342         PR tui/24197:
4343         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4344
4345 2019-02-17  Tom Tromey  <tom@tromey.com>
4346
4347         * ada-lang.c (user_select_syms): Use filtered printing.
4348         * utils.c (wrap_style): New global.
4349         (desired_style): Remove.
4350         (emit_style_escape): Add stream parameter.
4351         (set_output_style, reset_terminal_style, prompt_for_continue):
4352         Update.
4353         (flush_wrap_buffer): Only flush gdb_stdout.
4354         (wrap_here): Set wrap_style.
4355         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4356         treat escape sequences as a character.  Change when wrap buffer is
4357         flushed.
4358         (fputs_styled): Do not set the output style when the default is
4359         requested.
4360         * ui-style.h (struct ui_file_style) <is_default>: New method.
4361         * source.c (print_source_lines_base): Emit escape sequences in one
4362         piece.
4363
4364 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4365
4366         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4367         integers and enumeration types.
4368
4369 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4370
4371         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4372         instead of lookup_symbol_in_language
4373         (do_exact_match): New function.
4374         (ada_get_symbol_name_matcher): Return do_exact_match when
4375         doing a verbatim match.
4376
4377 2019-02-15  Tom Tromey  <tromey@adacore.com>
4378
4379         * ravenscar-thread.c (ravenscar_thread_target::resume)
4380         (ravenscar_thread_target::wait): Special case wildcard requests.
4381
4382 2019-02-15  Tom Tromey  <tromey@adacore.com>
4383
4384         * ravenscar-thread.c (base_ptid): Remove.
4385         (struct ravenscar_thread_target) <close>: New method.
4386         <m_base_ptid>: New member.
4387         <update_inferior_ptid, active_task, task_is_currently_active,
4388         runtime_initialized>: Declare methods.
4389         <ravenscar_thread_target>: Add constructor.
4390         (ravenscar_thread_target::task_is_currently_active)
4391         (ravenscar_thread_target::update_inferior_ptid)
4392         (ravenscar_runtime_initialized): Rename.  Now methods.
4393         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4394         (ravenscar_thread_target::update_thread_list): Update.
4395         (ravenscar_thread_target::active_task): Now method.
4396         (ravenscar_thread_target::store_registers)
4397         (ravenscar_thread_target::prepare_to_store)
4398         (ravenscar_thread_target::prepare_to_store)
4399         (ravenscar_thread_target::mourn_inferior): Update.
4400         (ravenscar_inferior_created): Use "new" to create target.
4401         (ravenscar_thread_target::get_ada_task_ptid): Update.
4402         (_initialize_ravenscar): Don't initialize base_ptid.
4403         (ravenscar_ops): Remove global.
4404
4405 2019-02-15  Tom Tromey  <tromey@adacore.com>
4406
4407         * target.h (push_target): Declare new overload.
4408         * target.c (push_target): New overload, taking an rvalue reference.
4409         * remote.c (remote_target::open_1): Use push_target overload.
4410         * corelow.c (core_target_open): Use push_target overload.
4411
4412 2019-02-15  Tom Tromey  <tromey@adacore.com>
4413
4414         * ravenscar-thread.c (is_ravenscar_task)
4415         (ravenscar_task_is_currently_active): Return bool.
4416         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4417         (_initialize_ravenscar): Remove "(void)".
4418         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4419         Return bool.
4420
4421 2019-02-15  Tom Tromey  <tromey@adacore.com>
4422
4423         * ravenscar-thread.c (ravenscar_runtime_initializer)
4424         (has_ravenscar_runtime, get_running_thread_id)
4425         (ravenscar_thread_target::resume): Fix indentation.
4426
4427 2019-02-15  Tom Tromey  <tromey@adacore.com>
4428
4429         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4430         from ravenscar_arch_ops.
4431         (sparc_ravenscar_ops::fetch_registers)
4432         (sparc_ravenscar_ops::store_registers): Now methods.
4433         (sparc_ravenscar_prepare_to_store): Remove.
4434         (sparc_ravenscar_ops): Redefine.
4435         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4436         methods and destructor.  Remove members.
4437         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4438         (ravenscar_thread_target::store_registers)
4439         (ravenscar_thread_target::prepare_to_store): Update.
4440         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4441         Remove.
4442         (struct ppc_ravenscar_powerpc_ops): Derive from
4443         ravenscar_arch_ops.
4444         (ppc_ravenscar_powerpc_ops::fetch_registers)
4445         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4446         (ppc_ravenscar_powerpc_ops): Redefine.
4447         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4448         (ppc_ravenscar_e500_ops::fetch_registers)
4449         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4450         (ppc_ravenscar_e500_ops): Redefine.
4451         * aarch64-ravenscar-thread.c
4452         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4453         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4454         (aarch64_ravenscar_fetch_registers)
4455         (aarch64_ravenscar_store_registers): Now methods.
4456         (aarch64_ravenscar_ops): Redefine.
4457
4458 2019-02-15  Tom Tromey  <tromey@adacore.com>
4459
4460         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4461         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4462         (ravenscar_thread_target::stopped_by_watchpoint)
4463         (ravenscar_thread_target::stopped_data_address)
4464         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4465
4466 2019-02-15  Tom Tromey  <tromey@adacore.com>
4467
4468         * ravenscar-thread.c: Fix some typos.
4469
4470 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4471             Tom Tromey  <tromey@adacore.com>
4472
4473         * ada-lang.c (ada_exception_sal): Change addr_string to a
4474         std::string.
4475         (create_ada_exception_catchpoint): Update.
4476
4477 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4478             Tom Tromey  <tromey@adacore.com>
4479
4480         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4481         (bp_location_ops): Remove.
4482         (base_breakpoint_allocate_location): Update.
4483         (free_bp_location): Update.
4484         * ada-lang.c (class ada_catchpoint_location)
4485         <ada_catchpoint_location>: Remove ops parameter.
4486         (ada_catchpoint_location_dtor): Remove.
4487         (ada_catchpoint_location_ops): Remove.
4488         (allocate_location_exception): Update.
4489         * breakpoint.h (struct bp_location_ops): Remove.
4490         (class bp_location) <bp_location>: Remove bp_location_ops
4491         parameter.
4492         <~bp_location>: Add destructor.
4493         <ops>: Remove.
4494
4495 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4496             Pedro Alves  <palves@redhat.com>
4497
4498         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4499         'PATH_MAX'.
4500
4501 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4502             Samuel Thibault  <samuel.thibault@gnu.org>
4503             Thomas Schwinge  <thomas@codesourcery.com>
4504
4505         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4506         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4507
4508 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4509
4510         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4511         (check_empty): Use "const char *".
4512
4513         * gnu-nat.c (gnu_nat_target::detach): Instead of
4514         'detach_inferior (pid)' call
4515         'detach_inferior (find_inferior_pid (pid))'.
4516
4517         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4518         'nat/fork-inferior.o'.
4519         * gnu-nat.c: #include "nat/fork-inferior.h".
4520
4521         * gnu-nat.c (gnu_nat_target::detach): Instead of
4522         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4523         * gnu-nat.h: #include "inf-child.h".
4524         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4525         'i386_gnu_nat_target::fetch_registers'.
4526         (gnu_store_registers): Rename/move to
4527         'i386_gnu_nat_target::store_registers'.
4528
4529         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4530         * gnu-nat.h (mach_thread_info): New function.
4531         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4532
4533         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4534
4535 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4536
4537         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4538
4539 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4540
4541         * windows-nat.c (windows_add_thread): Add new parameter
4542         "main_thread_p" with default value set to false.  Update
4543         function documentation as well as all callers.
4544         (windows_delete_thread): Likewise.
4545         (fake_create_process): Update call to windows_add_thread.
4546         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4547         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4548         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4549         call to windows_delete_thread.
4550
4551 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4552
4553         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4554
4555 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4556
4557         * symfile.c (find_separate_debug_file): Use canonical path of
4558         sysroot with child_path instead of gdb_sysroot if it is valid.
4559
4560 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4561
4562         * symfile.c (find_separate_debug_file): Use child_path to
4563         determine if an object file is under a sysroot.
4564
4565 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4566
4567         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4568         unittests/child-path-selftests.c.
4569         * common/pathstuff.c (child_path): New function.
4570         * common/pathstuff.h (child_path): New prototype.
4571         * unittests/child-path-selftests.c: New file.
4572
4573 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4574
4575         * symfile.c (find_separate_debug_file): Look for separate debug
4576         files in debug directories under the sysroot.
4577
4578 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4579
4580         * symtab.h (struct minimal_symbol data_p): New const method.
4581         (struct minimal_symbol text_p): Likewise.
4582         * symtab.c (output_source_filename): Use file name style
4583         to print file name.
4584         (print_symbol_info): Likewise.
4585         (print_msymbol_info): Use address style to print addresses.
4586         Use function name style to print executable text symbols.
4587         (expand_symtab_containing_pc): Use data_p.
4588         (find_pc_sect_compunit_symtab): Likewise.
4589
4590 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4591
4592         * breakpoint.c (describe_other_breakpoints): Use address style
4593         to print addresses.
4594         (say_where): Likewise.
4595
4596 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4597
4598         * ada-typeprint.c (print_func_type): Print function name
4599         style to print function name.
4600         * c-typeprint.c (c_print_type_1): Likewise.
4601
4602 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4603
4604         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4605         for execve.
4606
4607 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4608
4609         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4610         type_stack.
4611
4612 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4613
4614         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4615         TYPE_CODE_REF types.
4616
4617 2019-02-08  Jim Wilson  <jimw@sifive.com>
4618
4619         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4620         (riscv_linux_fregset): New.
4621         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4622
4623 2019-02-07  Tom Tromey  <tom@tromey.com>
4624
4625         * thread.c (thread_cancel_execution_command): Update.
4626         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4627         methods.
4628         (struct thread_fsm_ops): Remove.
4629         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4630         (thread_fsm_should_stop, thread_fsm_return_value)
4631         (thread_fsm_set_finished, thread_fsm_finished_p)
4632         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4633         Don't declare.
4634         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4635         * infrun.c (clear_proceed_status_thread)
4636         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4637         (print_stop_event): Update.
4638         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4639         Add constructor.
4640         (step_command_fsm_ops): Remove.
4641         (new_step_command_fsm): Remove.
4642         (step_1): Update.
4643         (step_command_fsm::should_stop): Rename from
4644         step_command_fsm_should_stop.
4645         (step_command_fsm::clean_up): Rename from
4646         step_command_fsm_clean_up.
4647         (step_command_fsm::do_async_reply_reason): Rename from
4648         step_command_fsm_async_reply_reason.
4649         (struct until_next_fsm): Inherit from thread_fsm.  Add
4650         constructor.
4651         (until_next_fsm_ops): Remove.
4652         (new_until_next_fsm): Remove.
4653         (until_next_fsm::should_stop): Rename from
4654         until_next_fsm_should_stop.
4655         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4656         (until_next_fsm::do_async_reply_reason): Rename from
4657         until_next_fsm_async_reply_reason.
4658         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4659         constructor.  Change type of breakpoint.
4660         (finish_command_fsm_ops): Remove.
4661         (new_finish_command_fsm): Remove.
4662         (finish_command_fsm::should_stop): Rename from
4663         finish_command_fsm_should_stop.
4664         (finish_command_fsm::clean_up): Rename from
4665         finish_command_fsm_clean_up.
4666         (finish_command_fsm::return_value): Rename from
4667         finish_command_fsm_return_value.
4668         (finish_command_fsm::do_async_reply_reason): Rename from
4669         finish_command_fsm_async_reply_reason.
4670         (finish_command): Update.
4671         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4672         Add constructor.
4673         (call_thread_fsm_ops): Remove.
4674         (call_thread_fsm::call_thread_fsm): Rename from
4675         new_call_thread_fsm.
4676         (call_thread_fsm::should_stop): Rename from
4677         call_thread_fsm_should_stop.
4678         (call_thread_fsm::should_notify_stop): Rename from
4679         call_thread_fsm_should_notify_stop.
4680         (run_inferior_call, call_function_by_hand_dummy): Update.
4681         * cli/cli-interp.c (should_print_stop_to_console): Update.
4682         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4683         Add constructor.  Change type of location_breakpoint,
4684         caller_breakpoint.
4685         (until_break_fsm_ops): Remove.
4686         (new_until_break_fsm): Remove.
4687         (until_break_fsm::should_stop): Rename from
4688         until_break_fsm_should_stop.
4689         (until_break_fsm::clean_up): Rename from
4690         until_break_fsm_clean_up.
4691         (until_break_fsm::do_async_reply_reason): Rename from
4692         until_break_fsm_async_reply_reason.
4693         (until_break_command): Update.
4694         * thread-fsm.c: Remove.
4695         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4696
4697 2019-02-07  Tom Tromey  <tom@tromey.com>
4698
4699         * yy-remap.h: Add include guard.
4700         * xtensa-tdep.h: Add include guard.
4701         * xcoffread.h: Rename include guard.
4702         * varobj-iter.h: Add include guard.
4703         * tui/tui.h: Rename include guard.
4704         * tui/tui-winsource.h: Rename include guard.
4705         * tui/tui-wingeneral.h: Rename include guard.
4706         * tui/tui-windata.h: Rename include guard.
4707         * tui/tui-win.h: Rename include guard.
4708         * tui/tui-stack.h: Rename include guard.
4709         * tui/tui-source.h: Rename include guard.
4710         * tui/tui-regs.h: Rename include guard.
4711         * tui/tui-out.h: Rename include guard.
4712         * tui/tui-layout.h: Rename include guard.
4713         * tui/tui-io.h: Rename include guard.
4714         * tui/tui-hooks.h: Rename include guard.
4715         * tui/tui-file.h: Rename include guard.
4716         * tui/tui-disasm.h: Rename include guard.
4717         * tui/tui-data.h: Rename include guard.
4718         * tui/tui-command.h: Rename include guard.
4719         * tic6x-tdep.h: Add include guard.
4720         * target/waitstatus.h: Rename include guard.
4721         * target/wait.h: Rename include guard.
4722         * target/target.h: Rename include guard.
4723         * target/resume.h: Rename include guard.
4724         * target-float.h: Rename include guard.
4725         * stabsread.h: Add include guard.
4726         * rs6000-tdep.h: Add include guard.
4727         * riscv-fbsd-tdep.h: Add include guard.
4728         * regformats/regdef.h: Rename include guard.
4729         * record.h: Rename include guard.
4730         * python/python.h: Rename include guard.
4731         * python/python-internal.h: Rename include guard.
4732         * python/py-stopevent.h: Rename include guard.
4733         * python/py-ref.h: Rename include guard.
4734         * python/py-record.h: Rename include guard.
4735         * python/py-record-full.h: Rename include guard.
4736         * python/py-record-btrace.h: Rename include guard.
4737         * python/py-instruction.h: Rename include guard.
4738         * python/py-events.h: Rename include guard.
4739         * python/py-event.h: Rename include guard.
4740         * procfs.h: Add include guard.
4741         * proc-utils.h: Add include guard.
4742         * p-lang.h: Add include guard.
4743         * or1k-tdep.h: Rename include guard.
4744         * observable.h: Rename include guard.
4745         * nto-tdep.h: Rename include guard.
4746         * nat/x86-linux.h: Rename include guard.
4747         * nat/x86-linux-dregs.h: Rename include guard.
4748         * nat/x86-gcc-cpuid.h: Add include guard.
4749         * nat/x86-dregs.h: Rename include guard.
4750         * nat/x86-cpuid.h: Rename include guard.
4751         * nat/ppc-linux.h: Rename include guard.
4752         * nat/mips-linux-watch.h: Rename include guard.
4753         * nat/linux-waitpid.h: Rename include guard.
4754         * nat/linux-ptrace.h: Rename include guard.
4755         * nat/linux-procfs.h: Rename include guard.
4756         * nat/linux-osdata.h: Rename include guard.
4757         * nat/linux-nat.h: Rename include guard.
4758         * nat/linux-namespaces.h: Rename include guard.
4759         * nat/linux-btrace.h: Rename include guard.
4760         * nat/glibc_thread_db.h: Rename include guard.
4761         * nat/gdb_thread_db.h: Rename include guard.
4762         * nat/gdb_ptrace.h: Rename include guard.
4763         * nat/fork-inferior.h: Rename include guard.
4764         * nat/amd64-linux-siginfo.h: Rename include guard.
4765         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4766         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4767         * nat/aarch64-linux.h: Rename include guard.
4768         * nat/aarch64-linux-hw-point.h: Rename include guard.
4769         * mn10300-tdep.h: Add include guard.
4770         * mips-linux-tdep.h: Add include guard.
4771         * mi/mi-parse.h: Rename include guard.
4772         * mi/mi-out.h: Rename include guard.
4773         * mi/mi-main.h: Rename include guard.
4774         * mi/mi-interp.h: Rename include guard.
4775         * mi/mi-getopt.h: Rename include guard.
4776         * mi/mi-console.h: Rename include guard.
4777         * mi/mi-common.h: Rename include guard.
4778         * mi/mi-cmds.h: Rename include guard.
4779         * mi/mi-cmd-break.h: Rename include guard.
4780         * m2-lang.h: Add include guard.
4781         * location.h: Rename include guard.
4782         * linux-record.h: Rename include guard.
4783         * linux-nat.h: Add include guard.
4784         * linux-fork.h: Add include guard.
4785         * i386-darwin-tdep.h: Rename include guard.
4786         * hppa-linux-offsets.h: Add include guard.
4787         * guile/guile.h: Rename include guard.
4788         * guile/guile-internal.h: Rename include guard.
4789         * gnu-nat.h: Rename include guard.
4790         * gdb-stabs.h: Rename include guard.
4791         * frv-tdep.h: Add include guard.
4792         * f-lang.h: Add include guard.
4793         * event-loop.h: Add include guard.
4794         * darwin-nat.h: Rename include guard.
4795         * cp-abi.h: Rename include guard.
4796         * config/sparc/nm-sol2.h: Rename include guard.
4797         * config/nm-nto.h: Rename include guard.
4798         * config/nm-linux.h: Add include guard.
4799         * config/i386/nm-i386gnu.h: Rename include guard.
4800         * config/djgpp/nl_types.h: Rename include guard.
4801         * config/djgpp/langinfo.h: Rename include guard.
4802         * compile/gcc-cp-plugin.h: Add include guard.
4803         * compile/gcc-c-plugin.h: Add include guard.
4804         * compile/compile.h: Rename include guard.
4805         * compile/compile-object-run.h: Rename include guard.
4806         * compile/compile-object-load.h: Rename include guard.
4807         * compile/compile-internal.h: Rename include guard.
4808         * compile/compile-cplus.h: Rename include guard.
4809         * compile/compile-c.h: Rename include guard.
4810         * common/xml-utils.h: Rename include guard.
4811         * common/x86-xstate.h: Rename include guard.
4812         * common/version.h: Rename include guard.
4813         * common/vec.h: Rename include guard.
4814         * common/tdesc.h: Rename include guard.
4815         * common/selftest.h: Rename include guard.
4816         * common/scoped_restore.h: Rename include guard.
4817         * common/scoped_mmap.h: Rename include guard.
4818         * common/scoped_fd.h: Rename include guard.
4819         * common/safe-iterator.h: Rename include guard.
4820         * common/run-time-clock.h: Rename include guard.
4821         * common/refcounted-object.h: Rename include guard.
4822         * common/queue.h: Rename include guard.
4823         * common/ptid.h: Rename include guard.
4824         * common/print-utils.h: Rename include guard.
4825         * common/preprocessor.h: Rename include guard.
4826         * common/pathstuff.h: Rename include guard.
4827         * common/observable.h: Rename include guard.
4828         * common/netstuff.h: Rename include guard.
4829         * common/job-control.h: Rename include guard.
4830         * common/host-defs.h: Rename include guard.
4831         * common/gdb_wait.h: Rename include guard.
4832         * common/gdb_vecs.h: Rename include guard.
4833         * common/gdb_unlinker.h: Rename include guard.
4834         * common/gdb_unique_ptr.h: Rename include guard.
4835         * common/gdb_tilde_expand.h: Rename include guard.
4836         * common/gdb_sys_time.h: Rename include guard.
4837         * common/gdb_string_view.h: Rename include guard.
4838         * common/gdb_splay_tree.h: Rename include guard.
4839         * common/gdb_setjmp.h: Rename include guard.
4840         * common/gdb_ref_ptr.h: Rename include guard.
4841         * common/gdb_optional.h: Rename include guard.
4842         * common/gdb_locale.h: Rename include guard.
4843         * common/gdb_assert.h: Rename include guard.
4844         * common/filtered-iterator.h: Rename include guard.
4845         * common/filestuff.h: Rename include guard.
4846         * common/fileio.h: Rename include guard.
4847         * common/environ.h: Rename include guard.
4848         * common/common-utils.h: Rename include guard.
4849         * common/common-types.h: Rename include guard.
4850         * common/common-regcache.h: Rename include guard.
4851         * common/common-inferior.h: Rename include guard.
4852         * common/common-gdbthread.h: Rename include guard.
4853         * common/common-exceptions.h: Rename include guard.
4854         * common/common-defs.h: Rename include guard.
4855         * common/common-debug.h: Rename include guard.
4856         * common/cleanups.h: Rename include guard.
4857         * common/buffer.h: Rename include guard.
4858         * common/btrace-common.h: Rename include guard.
4859         * common/break-common.h: Rename include guard.
4860         * cli/cli-utils.h: Rename include guard.
4861         * cli/cli-style.h: Rename include guard.
4862         * cli/cli-setshow.h: Rename include guard.
4863         * cli/cli-script.h: Rename include guard.
4864         * cli/cli-interp.h: Rename include guard.
4865         * cli/cli-decode.h: Rename include guard.
4866         * cli/cli-cmds.h: Rename include guard.
4867         * charset-list.h: Add include guard.
4868         * buildsym-legacy.h: Rename include guard.
4869         * bfin-tdep.h: Add include guard.
4870         * ax.h: Rename include guard.
4871         * arm-linux-tdep.h: Add include guard.
4872         * arm-fbsd-tdep.h: Add include guard.
4873         * arch/xtensa.h: Rename include guard.
4874         * arch/tic6x.h: Add include guard.
4875         * arch/i386.h: Add include guard.
4876         * arch/arm.h: Rename include guard.
4877         * arch/arm-linux.h: Rename include guard.
4878         * arch/arm-get-next-pcs.h: Rename include guard.
4879         * arch/amd64.h: Add include guard.
4880         * arch/aarch64-insn.h: Rename include guard.
4881         * arch-utils.h: Rename include guard.
4882         * annotate.h: Add include guard.
4883         * amd64-darwin-tdep.h: Rename include guard.
4884         * aarch64-linux-tdep.h: Add include guard.
4885         * aarch64-fbsd-tdep.h: Add include guard.
4886         * aarch32-linux-nat.h: Add include guard.
4887
4888 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4889
4890         * macrotab.c (macro_define_internal): New function that
4891         factorizes macro_define_object_internal and macro_define_function
4892         code.
4893         (macro_define_object_internal): Use macro_define_internal.
4894         (macro_define_function): Likewise.
4895
4896 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4897
4898         * macrocmd.c (extract_identifier): Return
4899         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4900         callers.
4901
4902 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4903
4904         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4905
4906 2019-02-05  Tom Tromey  <tom@tromey.com>
4907
4908         * target.c (target_stack::unpush): Move assertion earlier.
4909
4910 2019-01-30  Tom Tromey  <tom@tromey.com>
4911
4912         PR python/23615:
4913         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4914         (gdbpy_parse_and_eval): Likewise.
4915         * python/python-internal.h (gdbpy_allow_threads): New class.
4916
4917 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4918
4919         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4920         (aarch64_fbsd_fpregmap): Move earlier.
4921         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4922         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4923         instead of individual calls to trad_frame_set_reg_addr.
4924         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4925         earlier.
4926         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4927         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4928         instead of individual calls to trad_frame_set_reg_addr.
4929
4930 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4931
4932         * CONTRIBUTE: Replace contribution list with wiki link.
4933
4934 2019-01-25  Tom Tromey  <tom@tromey.com>
4935
4936         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4937
4938 2019-01-25  Tom Tromey  <tom@tromey.com>
4939
4940         * xtensa-linux-nat.c: Fix common/ includes.
4941         * xml-support.h: Fix common/ includes.
4942         * xml-support.c: Fix common/ includes.
4943         * x86-linux-nat.c: Fix common/ includes.
4944         * windows-nat.c: Fix common/ includes.
4945         * varobj.h: Fix common/ includes.
4946         * varobj.c: Fix common/ includes.
4947         * value.c: Fix common/ includes.
4948         * valops.c: Fix common/ includes.
4949         * utils.c: Fix common/ includes.
4950         * unittests/xml-utils-selftests.c: Fix common/ includes.
4951         * unittests/utils-selftests.c: Fix common/ includes.
4952         * unittests/unpack-selftests.c: Fix common/ includes.
4953         * unittests/tracepoint-selftests.c: Fix common/ includes.
4954         * unittests/style-selftests.c: Fix common/ includes.
4955         * unittests/string_view-selftests.c: Fix common/ includes.
4956         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4957         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4958         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4959         * unittests/rsp-low-selftests.c: Fix common/ includes.
4960         * unittests/parse-connection-spec-selftests.c: Fix common/
4961         includes.
4962         * unittests/optional-selftests.c: Fix common/ includes.
4963         * unittests/offset-type-selftests.c: Fix common/ includes.
4964         * unittests/observable-selftests.c: Fix common/ includes.
4965         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4966         * unittests/memrange-selftests.c: Fix common/ includes.
4967         * unittests/memory-map-selftests.c: Fix common/ includes.
4968         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4969         * unittests/function-view-selftests.c: Fix common/ includes.
4970         * unittests/environ-selftests.c: Fix common/ includes.
4971         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4972         * unittests/common-utils-selftests.c: Fix common/ includes.
4973         * unittests/cli-utils-selftests.c: Fix common/ includes.
4974         * unittests/array-view-selftests.c: Fix common/ includes.
4975         * ui-file.c: Fix common/ includes.
4976         * tui/tui-io.c: Fix common/ includes.
4977         * tracepoint.h: Fix common/ includes.
4978         * tracepoint.c: Fix common/ includes.
4979         * tracefile-tfile.c: Fix common/ includes.
4980         * top.h: Fix common/ includes.
4981         * top.c: Fix common/ includes.
4982         * thread.c: Fix common/ includes.
4983         * target/waitstatus.h: Fix common/ includes.
4984         * target/waitstatus.c: Fix common/ includes.
4985         * target.h: Fix common/ includes.
4986         * target.c: Fix common/ includes.
4987         * target-memory.c: Fix common/ includes.
4988         * target-descriptions.c: Fix common/ includes.
4989         * symtab.h: Fix common/ includes.
4990         * symfile.c: Fix common/ includes.
4991         * stap-probe.c: Fix common/ includes.
4992         * spu-linux-nat.c: Fix common/ includes.
4993         * sparc-nat.c: Fix common/ includes.
4994         * source.c: Fix common/ includes.
4995         * solib.c: Fix common/ includes.
4996         * solib-target.c: Fix common/ includes.
4997         * ser-unix.c: Fix common/ includes.
4998         * ser-tcp.c: Fix common/ includes.
4999         * ser-pipe.c: Fix common/ includes.
5000         * ser-base.c: Fix common/ includes.
5001         * selftest-arch.c: Fix common/ includes.
5002         * s12z-tdep.c: Fix common/ includes.
5003         * rust-exp.y: Fix common/ includes.
5004         * rs6000-aix-tdep.c: Fix common/ includes.
5005         * riscv-tdep.c: Fix common/ includes.
5006         * remote.c: Fix common/ includes.
5007         * remote-notif.h: Fix common/ includes.
5008         * remote-fileio.h: Fix common/ includes.
5009         * remote-fileio.c: Fix common/ includes.
5010         * regcache.h: Fix common/ includes.
5011         * regcache.c: Fix common/ includes.
5012         * record-btrace.c: Fix common/ includes.
5013         * python/python.c: Fix common/ includes.
5014         * python/py-type.c: Fix common/ includes.
5015         * python/py-inferior.c: Fix common/ includes.
5016         * progspace.h: Fix common/ includes.
5017         * producer.c: Fix common/ includes.
5018         * procfs.c: Fix common/ includes.
5019         * proc-api.c: Fix common/ includes.
5020         * printcmd.c: Fix common/ includes.
5021         * ppc-linux-nat.c: Fix common/ includes.
5022         * parser-defs.h: Fix common/ includes.
5023         * osdata.c: Fix common/ includes.
5024         * obsd-nat.c: Fix common/ includes.
5025         * nat/x86-linux.c: Fix common/ includes.
5026         * nat/x86-linux-dregs.c: Fix common/ includes.
5027         * nat/x86-dregs.h: Fix common/ includes.
5028         * nat/x86-dregs.c: Fix common/ includes.
5029         * nat/ppc-linux.c: Fix common/ includes.
5030         * nat/mips-linux-watch.h: Fix common/ includes.
5031         * nat/mips-linux-watch.c: Fix common/ includes.
5032         * nat/linux-waitpid.c: Fix common/ includes.
5033         * nat/linux-ptrace.h: Fix common/ includes.
5034         * nat/linux-ptrace.c: Fix common/ includes.
5035         * nat/linux-procfs.c: Fix common/ includes.
5036         * nat/linux-personality.c: Fix common/ includes.
5037         * nat/linux-osdata.c: Fix common/ includes.
5038         * nat/linux-namespaces.c: Fix common/ includes.
5039         * nat/linux-btrace.h: Fix common/ includes.
5040         * nat/linux-btrace.c: Fix common/ includes.
5041         * nat/fork-inferior.c: Fix common/ includes.
5042         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5043         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5044         * nat/aarch64-linux.c: Fix common/ includes.
5045         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5046         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5047         * namespace.h: Fix common/ includes.
5048         * mips-linux-tdep.c: Fix common/ includes.
5049         * minsyms.c: Fix common/ includes.
5050         * mi/mi-parse.h: Fix common/ includes.
5051         * mi/mi-main.c: Fix common/ includes.
5052         * mi/mi-cmd-env.c: Fix common/ includes.
5053         * memrange.h: Fix common/ includes.
5054         * memattr.c: Fix common/ includes.
5055         * maint.h: Fix common/ includes.
5056         * maint.c: Fix common/ includes.
5057         * main.c: Fix common/ includes.
5058         * machoread.c: Fix common/ includes.
5059         * location.c: Fix common/ includes.
5060         * linux-thread-db.c: Fix common/ includes.
5061         * linux-nat.c: Fix common/ includes.
5062         * linux-fork.c: Fix common/ includes.
5063         * inline-frame.c: Fix common/ includes.
5064         * infrun.c: Fix common/ includes.
5065         * inflow.c: Fix common/ includes.
5066         * inferior.h: Fix common/ includes.
5067         * inferior.c: Fix common/ includes.
5068         * infcmd.c: Fix common/ includes.
5069         * inf-ptrace.c: Fix common/ includes.
5070         * inf-child.c: Fix common/ includes.
5071         * ia64-linux-nat.c: Fix common/ includes.
5072         * i387-tdep.c: Fix common/ includes.
5073         * i386-tdep.c: Fix common/ includes.
5074         * i386-linux-tdep.c: Fix common/ includes.
5075         * i386-linux-nat.c: Fix common/ includes.
5076         * i386-go32-tdep.c: Fix common/ includes.
5077         * i386-fbsd-tdep.c: Fix common/ includes.
5078         * i386-fbsd-nat.c: Fix common/ includes.
5079         * guile/scm-type.c: Fix common/ includes.
5080         * guile/guile.c: Fix common/ includes.
5081         * go32-nat.c: Fix common/ includes.
5082         * gnu-nat.c: Fix common/ includes.
5083         * gdbthread.h: Fix common/ includes.
5084         * gdbarch-selftests.c: Fix common/ includes.
5085         * gdb_usleep.c: Fix common/ includes.
5086         * gdb_select.h: Fix common/ includes.
5087         * gdb_bfd.c: Fix common/ includes.
5088         * gcore.c: Fix common/ includes.
5089         * fork-child.c: Fix common/ includes.
5090         * findvar.c: Fix common/ includes.
5091         * fbsd-nat.c: Fix common/ includes.
5092         * event-top.c: Fix common/ includes.
5093         * event-loop.c: Fix common/ includes.
5094         * dwarf2read.c: Fix common/ includes.
5095         * dwarf2loc.c: Fix common/ includes.
5096         * dwarf2-frame.c: Fix common/ includes.
5097         * dwarf-index-cache.c: Fix common/ includes.
5098         * dtrace-probe.c: Fix common/ includes.
5099         * disasm-selftests.c: Fix common/ includes.
5100         * defs.h: Fix common/ includes.
5101         * csky-tdep.c: Fix common/ includes.
5102         * cp-valprint.c: Fix common/ includes.
5103         * cp-support.h: Fix common/ includes.
5104         * cp-support.c: Fix common/ includes.
5105         * corelow.c: Fix common/ includes.
5106         * completer.h: Fix common/ includes.
5107         * completer.c: Fix common/ includes.
5108         * compile/compile.c: Fix common/ includes.
5109         * compile/compile-loc2c.c: Fix common/ includes.
5110         * compile/compile-cplus-types.c: Fix common/ includes.
5111         * compile/compile-cplus-symbols.c: Fix common/ includes.
5112         * command.h: Fix common/ includes.
5113         * cli/cli-dump.c: Fix common/ includes.
5114         * cli/cli-cmds.c: Fix common/ includes.
5115         * charset.c: Fix common/ includes.
5116         * build-id.c: Fix common/ includes.
5117         * btrace.h: Fix common/ includes.
5118         * btrace.c: Fix common/ includes.
5119         * breakpoint.h: Fix common/ includes.
5120         * breakpoint.c: Fix common/ includes.
5121         * ax.h:
5122         (enum agent_op): Fix common/ includes.
5123         * ax-general.c (struct aop_map): Fix common/ includes.
5124         * ax-gdb.c: Fix common/ includes.
5125         * auxv.c: Fix common/ includes.
5126         * auto-load.c: Fix common/ includes.
5127         * arm-tdep.c: Fix common/ includes.
5128         * arch/riscv.c: Fix common/ includes.
5129         * arch/ppc-linux-common.c: Fix common/ includes.
5130         * arch/i386.c: Fix common/ includes.
5131         * arch/arm.c: Fix common/ includes.
5132         * arch/arm-linux.c: Fix common/ includes.
5133         * arch/arm-get-next-pcs.c: Fix common/ includes.
5134         * arch/amd64.c: Fix common/ includes.
5135         * arch/aarch64.c: Fix common/ includes.
5136         * arch/aarch64-insn.c: Fix common/ includes.
5137         * arch-utils.c: Fix common/ includes.
5138         * amd64-windows-tdep.c: Fix common/ includes.
5139         * amd64-tdep.c: Fix common/ includes.
5140         * amd64-sol2-tdep.c: Fix common/ includes.
5141         * amd64-obsd-tdep.c: Fix common/ includes.
5142         * amd64-nbsd-tdep.c: Fix common/ includes.
5143         * amd64-linux-tdep.c: Fix common/ includes.
5144         * amd64-linux-nat.c: Fix common/ includes.
5145         * amd64-fbsd-tdep.c: Fix common/ includes.
5146         * amd64-fbsd-nat.c: Fix common/ includes.
5147         * amd64-dicos-tdep.c: Fix common/ includes.
5148         * amd64-darwin-tdep.c: Fix common/ includes.
5149         * agent.c: Fix common/ includes.
5150         * ada-lang.h: Fix common/ includes.
5151         * ada-lang.c: Fix common/ includes.
5152         * aarch64-tdep.c: Fix common/ includes.
5153
5154 2019-01-25  Tom Tromey  <tom@tromey.com>
5155
5156         * common/create-version.sh: Use common/version.h.
5157
5158 2019-01-24  Pedro Alves  <palves@redhat.com>
5159
5160         * infrun.c (signal_stop, signal_print, signal_program)
5161         (signal_catch, signal_pass): Now arrays instead of pointers.
5162         (update_signals_program_target, do_target_resume)
5163         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5164         * linux-nat.c (linux_nat_target::pass_signals)
5165         (linux_nat_target::create_inferior, linux_nat_target::attach):
5166         Adjust.
5167         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5168         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5169         * procfs.c (procfs_target::pass_signals): Adjust.
5170         * record-full.c (record_full_target::resume): Adjust.
5171         * remote.c (remote_target::pass_signals)
5172         (remote_target::program_signals): Adjust.
5173         * target-debug.h (target_debug_print_signals): Now takes a
5174         gdb::array_view as parameter.  Adjust.
5175         * target.h (target_ops) <pass_signals, program_signals>: Replace
5176         pointer and length parameters with gdb::array_view.
5177         (target_pass_signals, target_program_signals): Likewise.
5178         * target-delegates.c: Regenerate.
5179
5180 2019-01-24  Pedro Alves  <palves@redhat.com>
5181
5182         * common/forward-scope-exit.h
5183         (forward_scope_exit::forward_scope_exit): Pass arguments to
5184         m_bind_function directly, instead of creating a std::bind and
5185         copying that.
5186
5187 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5188
5189         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5190         for static members.
5191         (pass_in_v_vfp_candidate): Likewise.
5192
5193 2019-01-23  Tom Tromey  <tom@tromey.com>
5194             Pedro Alves  <palves@redhat.com>
5195
5196         * regcache.c (class regcache_invalidator): Remove.
5197         (regcache::raw_write): Use make_scope_exit.
5198
5199 2019-01-23  Tom Tromey  <tom@tromey.com>
5200
5201         * ui-out.h (class ui_out_emit_type): Update comment.
5202
5203 2019-01-23  Tom Tromey  <tom@tromey.com>
5204
5205         * infrun.c (fetch_inferior_event): Update comment.
5206
5207 2019-01-23  Tom Tromey  <tom@tromey.com>
5208             Pedro Alves  <palves@redhat.com>
5209
5210         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5211         parameter.
5212         (fetch_inferior_event): Use SCOPE_EXIT.
5213
5214
5215 2019-01-23  Tom Tromey  <tom@tromey.com>
5216             Pedro Alves  <palves@redhat.com>
5217
5218         * infrun.c (disable_thread_events): Delete.
5219         (stop_all_threads): Use SCOPE_EXIT.
5220
5221 2019-01-23  Tom Tromey  <tom@tromey.com>
5222             Pedro Alves  <palves@redhat.com>
5223
5224         * symfile.c: Include forward-scope-exit.h.
5225         (clear_symtab_users_cleanup): Replace forward declaration with
5226         a FORWARD_SCOPE_EXIT.
5227         (syms_from_objfile_1): Use the forward_scope_exit and
5228         gdb::optional instead of cleanup_function.
5229         (reread_symbols): Use the forward_scope_exit instead of
5230         cleanup_function.
5231         (clear_symtab_users_cleanup): Remove function.
5232
5233 2019-01-23  Tom Tromey  <tom@tromey.com>
5234             Pedro Alves  <palves@redhat.com>
5235
5236         * linux-nat.c: Include scope-exit.h.
5237         (cleanup_target_stop): Remove.
5238         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5239         SCOPE_EXIT.
5240
5241 2019-01-23  Tom Tromey  <tom@tromey.com>
5242             Pedro Alves  <palves@redhat.com>
5243
5244         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5245         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5246
5247 2019-01-23  Tom Tromey  <tom@tromey.com>
5248             Andrew Burgess  <andrew.burgess@embecosm.com>
5249             Pedro Alves  <palves@redhat.com>
5250
5251         * infrun.c (fetch_inferior_event): Use scope_exit.
5252         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5253         * top.c (execute_command): Use scope_exit.
5254         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5255         * utils.c (do_bpstat_clear_actions_cleanup)
5256         (make_bpstat_clear_actions_cleanup): Remove.
5257
5258 2019-01-23  Tom Tromey  <tom@tromey.com>
5259             Pedro Alves  <palves@redhat.com>
5260
5261         * infrun.c: Include "common/scope-exit.h"
5262         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5263         (wait_for_inferior): Use SCOPE_EXIT.
5264         (fetch_inferior_event): Use scope_exit.
5265
5266 2019-01-23  Tom Tromey  <tom@tromey.com>
5267             Pedro Alves  <palves@redhat.com>
5268
5269         * breakpoint.c (create_breakpoint): Remove cleanup.
5270
5271 2019-01-23  Tom Tromey  <tom@tromey.com>
5272             Andrew Burgess  <andrew.burgess@embecosm.com>
5273             Pedro Alves  <palves@redhat.com>
5274
5275 2019-01-23  Pedro Alves  <palves@redhat.com>
5276
5277         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5278
5279 2019-01-23  Pedro Alves  <palves@redhat.com>
5280             Andrew Burgess  <andrew.burgess@embecosm.com>
5281
5282         * gdbthread.h: Include "common/forward-scope-exit.h".
5283         (scoped_finish_thread_state): Redefine custom class in terms of
5284         forward_scope_exit.
5285
5286 2019-01-23  Pedro Alves  <palves@redhat.com>
5287             Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * common/forward-scope-exit.h: New file.
5290
5291 2019-01-23  Pedro Alves  <palves@redhat.com>
5292             Andrew Burgess  <andrew.burgess@embecosm.com>
5293             Tom Tromey  <tom@tromey.com>
5294
5295         * common/scope-exit.h: New file.
5296
5297 2019-01-23  Pedro Alves  <palves@redhat.com>
5298
5299         * common/preprocessor.h (ESC): Rename to ...
5300         (ESC_PARENS): ... this.
5301         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5302         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5303
5304 2019-01-23  Tom Tromey  <tom@tromey.com>
5305
5306         * language.h (class scoped_switch_to_sym_language_if_auto):
5307         Initialize m_lang in both cases.
5308
5309 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5310
5311         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5312         with XCNEW.
5313
5314 2019-01-22  Tom Tromey  <tom@tromey.com>
5315
5316         * corelow.c: Do not include sys/file.h.
5317
5318 2019-01-22  Tom Tromey  <tom@tromey.com>
5319
5320         * tui/tui-wingeneral.h: Include gdb_curses.h.
5321
5322 2019-01-22  Tom Tromey  <tom@tromey.com>
5323
5324         * source-cache.h (class source_cache) <get_source_lines,
5325         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5326
5327 2019-01-22  Tom Tromey  <tom@tromey.com>
5328
5329         * remote-fileio.h (struct remote_target): Declare.
5330
5331 2019-01-22  Tom Tromey  <tom@tromey.com>
5332
5333         * python/py-arch.c: Do not include py-ref.h.
5334         * python/py-bpevent.c: Do not include py-ref.h.
5335         * python/py-cmd.c: Do not include py-ref.h.
5336         * python/py-continueevent.c: Do not include py-ref.h.
5337         * python/py-event.h: Do not include py-ref.h.
5338         * python/py-evtregistry.c: Do not include py-ref.h.
5339         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5340         * python/py-frame.c: Do not include py-ref.h.
5341         * python/py-framefilter.c: Do not include py-ref.h.
5342         * python/py-function.c: Do not include py-ref.h.
5343         * python/py-infevents.c: Do not include py-ref.h.
5344         * python/py-linetable.c: Do not include py-ref.h.
5345         * python/py-objfile.c: Do not include py-ref.h.
5346         * python/py-param.c: Do not include py-ref.h.
5347         * python/py-prettyprint.c: Do not include py-ref.h.
5348         * python/py-progspace.c: Do not include py-ref.h.
5349         * python/py-symbol.c: Do not include py-ref.h.
5350         * python/py-symtab.c: Do not include py-ref.h.
5351         * python/py-type.c: Do not include py-ref.h.
5352         * python/py-unwind.c: Do not include py-ref.h.
5353         * python/py-utils.c: Do not include py-ref.h.
5354         * python/py-value.c: Do not include py-ref.h.
5355         * python/py-varobj.c: Do not include py-ref.h.
5356         * python/py-xmethods.c: Do not include py-ref.h.
5357         * python/python.c: Do not include py-ref.h.
5358         * varobj.c: Do not include py-ref.h.
5359
5360 2019-01-22  Tom Tromey  <tom@tromey.com>
5361
5362         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5363         keyword for bcache.
5364
5365 2019-01-22  Tom Tromey  <tom@tromey.com>
5366
5367         * compile/compile-cplus-types.c: Remove a comment by #include.
5368
5369 2019-01-22  Tom Tromey  <tom@tromey.com>
5370
5371         * compile/gcc-c-plugin.h: Include compile-internal.h.
5372
5373 2019-01-22  Tom Tromey  <tom@tromey.com>
5374
5375         * stabsread.c (EXTERN): Do not define.
5376         (symnum, next_symbol_text_func, processing_gcc_compilation)
5377         (within_function, global_sym_chain, global_stabs)
5378         (previous_stab_code, this_object_header_files)
5379         (n_this_object_header_files)
5380         (n_allocated_this_object_header_files): Define.
5381         * stabsread.h (EXTERN): Never define.  Use "extern".
5382
5383 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5384
5385         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5386         history_value.
5387
5388 2019-01-21  Tom Tromey  <tom@tromey.com>
5389
5390         * ui-out.c: Fix includes.
5391         * tui/tui-source.c: Fix includes.
5392         * target.c: Fix includes.
5393         * remote.c: Fix includes.
5394         * regcache.c: Fix includes.
5395         * python/py-block.c: Fix includes.
5396         * printcmd.c: Fix includes.
5397         * or1k-tdep.c: Fix includes.
5398         * mi/mi-main.c: Fix includes.
5399         * m32r-tdep.c: Fix includes.
5400         * csky-tdep.c: Fix includes.
5401         * compile/compile-cplus-types.c: Fix includes.
5402         * cli/cli-interp.c: Fix includes.
5403
5404 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5405
5406         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5407         for padding.
5408
5409 2019-01-16  Tom Tromey  <tom@tromey.com>
5410
5411         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5412         earlier.
5413         (struct objfile) <msymbols_range>: Move from top level.
5414         <msymbols>: New method.
5415         (class objfile_msymbols): Remove.
5416         * symtab.c (default_collect_symbol_completion_matches_break_on):
5417         Update.
5418         * symmisc.c (dump_msymbols): Update.
5419         * stabsread.c (scan_file_globals): Update.
5420         * objc-lang.c (info_selectors_command, info_classes_command)
5421         (find_methods): Update.
5422         * minsyms.c (find_solib_trampoline_target): Update.
5423         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5424         * coffread.c (coff_symfile_read): Update.
5425         * ada-lang.c (ada_lookup_simple_minsym)
5426         (ada_collect_symbol_completion_matches): Update.
5427
5428 2019-01-16  Tom Tromey  <tom@tromey.com>
5429
5430         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5431         type.  Remove no-argument constructor.
5432         <iterator::operator++>: Simplify.
5433         <begin>: Update.
5434         <end>: Use minimal_symbol_count.
5435
5436 2019-01-16  Tom Tromey  <tom@tromey.com>
5437
5438         * objfiles.h (struct objfile) <psymtabs>: New method.
5439         (class objfile_psymtabs): Remove.
5440         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5441         typedef.
5442         <range>: New method.
5443         (require_partial_symbols): Change return type.
5444         * psymtab.c (require_partial_symbols)
5445         (psym_expand_symtabs_matching): Update.
5446         * mdebugread.c (parse_partial_symbols): Update.
5447         * dbxread.c (dbx_end_psymtab): Update.
5448
5449 2019-01-15  Tom Tromey  <tom@tromey.com>
5450
5451         * symtab.c (lookup_objfile_from_block)
5452         (lookup_symbol_in_objfile_symtabs)
5453         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5454         (find_line_symtab, info_sources_command)
5455         (default_collect_symbol_completion_matches_break_on)
5456         (make_source_files_completion_list): Update.
5457         * symmisc.c (print_objfile_statistics, dump_objfile)
5458         (maintenance_print_symbols, maintenance_info_symtabs)
5459         (maintenance_check_symtabs, maintenance_info_line_tables):
5460         Update.
5461         * source.c (select_source_symtab)
5462         (forget_cached_source_info_for_objfile): Update.
5463         * objfiles.h (class objfile_compunits): Remove.
5464         (struct objfile) <compunits_range>: New typedef.
5465         (compunits): New method.
5466         * objfiles.c (objfile_relocate1): Update.
5467         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5468         * maint.c (count_symtabs_and_blocks): Update.
5469         * linespec.c (iterate_over_all_matching_symtabs): Update.
5470         * cp-support.c (add_symbol_overload_list_qualified): Update.
5471         * coffread.c (coff_symtab_read): Update.
5472         * ada-lang.c (add_nonlocal_symbols)
5473         (ada_collect_symbol_completion_matches)
5474         (ada_add_global_exceptions): Update.
5475
5476 2019-01-15  Tom Tromey  <tom@tromey.com>
5477
5478         * progspace.h (program_space) <objfiles_safe_range>: New
5479         typedef.
5480         <objfiles_safe>: New method.
5481         * objfiles.h (class all_objfiles_safe): Remove.
5482         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5483         * jit.c (jit_inferior_exit_hook): Update.
5484
5485 2019-01-17  Tom Tromey  <tom@tromey.com>
5486
5487         * progspace.h (program_space) <objfiles_range>: New typedef.
5488         <objfiles>: New method.
5489         <objfiles_head>: Rename from objfiles.
5490         (object_files): Update.
5491         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5492         * guile/scm-pretty-print.c
5493         (ppscm_find_pretty_printer_from_objfiles): Update.
5494         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5495         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5496         Update.
5497         * python/py-progspace.c (pspy_get_objfiles): Update.
5498         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5499         Update.
5500         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5501         (objfpy_lookup_objfile_by_build_id): Update.
5502         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5503         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5504         Update.
5505         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5506         (expand_symtab_containing_pc, lookup_objfile_from_block)
5507         (lookup_static_symbol, basic_lookup_transparent_type)
5508         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5509         (find_line_symtab, info_sources_command)
5510         (default_collect_symbol_completion_matches_break_on)
5511         (make_source_files_completion_list, find_main_name): Update.
5512         * symmisc.c (print_symbol_bcache_statistics)
5513         (print_objfile_statistics, maintenance_print_symbols)
5514         (maintenance_print_msymbols, maintenance_print_objfiles)
5515         (maintenance_info_symtabs, maintenance_check_symtabs)
5516         (maintenance_expand_symtabs, maintenance_info_line_tables):
5517         Update.
5518         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5519         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5520         (map_overlay_command, unmap_overlay_command)
5521         (simple_overlay_update, expand_symtabs_matching)
5522         (map_symbol_filenames): Update.
5523         * symfile-debug.c (set_debug_symfile): Update.
5524         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5525         Update.
5526         * source.c (select_source_symtab, forget_cached_source_info):
5527         Update.
5528         * solib.c (solib_read_symbols): Update.
5529         * solib-spu.c (append_ocl_sos): Update.
5530         * psymtab.c (maintenance_print_psymbols)
5531         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5532         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5533         * printcmd.c (info_symbol_command): Update.
5534         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5535         Update.
5536         * objfiles.h (class all_objfiles): Remove.
5537         * objfiles.c (have_partial_symbols, have_full_symbols)
5538         (have_minimal_symbols, qsort_cmp, update_section_map)
5539         (shared_objfile_contains_address_p)
5540         (default_iterate_over_objfiles_in_search_order): Update.
5541         * objc-lang.c (info_selectors_command, info_classes_command)
5542         (find_methods): Update.
5543         * minsyms.c (find_solib_trampoline_target): Update.
5544         * maint.c (maintenance_info_sections)
5545         (maintenance_translate_address, count_symtabs_and_blocks):
5546         Update.
5547         * main.c (captured_main_1): Update.
5548         * linux-thread-db.c (try_thread_db_load_from_pdir)
5549         (has_libpthread): Update.
5550         * linespec.c (iterate_over_all_matching_symtabs)
5551         (search_minsyms_for_name): Update.
5552         * jit.c (jit_find_objf_with_entry_addr): Update.
5553         * hppa-tdep.c (find_unwind_entry)
5554         (hppa_lookup_stub_minimal_symbol): Update.
5555         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5556         Update.
5557         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5558         (elf_gnu_ifunc_resolve_by_got): Update.
5559         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5560         * dwarf-index-write.c (save_gdb_index_command): Update.
5561         * cp-support.c (add_symbol_overload_list_qualified): Update.
5562         * breakpoint.c (create_overlay_event_breakpoint)
5563         (create_longjmp_master_breakpoint)
5564         (create_std_terminate_master_breakpoint)
5565         (create_exception_master_breakpoint): Update.
5566         * blockframe.c (find_pc_partial_function): Update.
5567         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5568         (ada_collect_symbol_completion_matches)
5569         (ada_add_global_exceptions): Update.
5570
5571 2019-01-17  Tom Tromey  <tom@tromey.com>
5572
5573         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5574         declare VEC.
5575         (solib_target_parse_libraries): Change return type.
5576         (library_list_start_segment, library_list_start_section)
5577         (library_list_end_library, library_list_start_library); Update.
5578         (solib_target_free_library_list): Remove.
5579         (solib_target_parse_libraries): Remove cleanup.  Change return
5580         type.
5581         (solib_target_current_sos): Update.
5582
5583 2019-01-17  Tom Tromey  <tromey@bapiya>
5584
5585         * valprint.c: Replace "the the" with "the".
5586         * symtab.c: Replace "the the" with "the".
5587         * solib.c: Replace "the the" with "the".
5588         * solib-dsbt.c: Replace "the the" with "the".
5589         * linespec.c: Replace "the the" with "the".
5590         * dwarf2loc.h: Replace "the the" with "the".
5591         * amd64-windows-tdep.c: Replace "the the" with "the".
5592         * aarch64-tdep.c: Replace "the the" with "the".
5593
5594 2019-01-16  Keith Seitz  <keiths@redhat.com>
5595
5596         PR gdb/23773
5597         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5598         <builder>: Rename to ..
5599         <m_builder>: ... this and make private.
5600         (dwarf2_cu::get_builder): New method.  Change all users of
5601         `builder' to use this method.
5602         (dwarf2_start_symtab): Move to ...
5603         (dwarf2_cu::start_symtab): ... here.  Update all callers
5604         (setup_type_unit_groups): Move to ...
5605         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5606         callers.
5607         (dwarf2_cu::reset_builder): New method.
5608         (process_full_compunit, process_full_type_unit): Use
5609         dwarf2_cu::reset_builder.
5610         (follow_die_offset): Record the ancestor CU if it is different
5611         from the followed DIE's CU.
5612         (follow_die_sig_1): Likewise.
5613
5614 2019-01-15  Tom Tromey  <tom@tromey.com>
5615
5616         * remote.c (class remote_state) <buf>: Now a char_vector.
5617         <buf_size>: Remove.
5618         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5619         parameter.
5620         (remote_target::getpkt_or_notif_sane_1)
5621         (remote_target::getpkt_sane)
5622         (remote_target::getpkt_or_notif_sane): Likewise.
5623         (class remote_target) <putpkt>: New overload.
5624         (remote_target::read_frame): Change type of "buf_p".  Remove
5625         sizeof_p parameter.
5626         (packet_ok): New overload.
5627         (packet_check_result): New overload.
5628         Update all uses.
5629
5630 2019-01-14  Tom Tromey  <tom@tromey.com>
5631
5632         * remote-notif.c (handle_notification, remote_notif_ack)
5633         (remote_notif_parse): Make "buf" const.
5634         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5635         const.
5636         (remote_notif_parse, remote_notif_ack, handle_notification):
5637         Likewise.
5638         * remote.c (remote_notif_stop_parse): Make "buf" const.
5639         (remote_target::remote_parse_stop_reply): Make "buf" const.
5640         (remote_notif_stop_ack): Make "buf" const.
5641
5642 2019-01-14  Tom Tromey  <tom@tromey.com>
5643
5644         * remote.c (remote_console_output): Make parameter const.
5645
5646 2019-01-14  Tom Tromey  <tom@tromey.com>
5647
5648         * target-debug.h (target_debug_print_signals): Constify.
5649         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5650         * procfs.c (procfs_target::pass_signals): Update.
5651         * linux-nat.c (linux_nat_target::pass_signals): Update.
5652         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5653         * target-delegates.c: Rebuild.
5654         * remote.c (remote_target::program_signals): Update.
5655         (remote_target::pass_signals): Update.
5656         * target.c (target_pass_signals): Constify argument.
5657         (target_program_signals): Likewise.
5658         * target.h (struct target_ops) <pass_signals, program_signals>:
5659         Constify argument.
5660         (target_pass_signals, target_program_signals): Constify argument.
5661
5662 2019-01-14  Tom Tromey  <tom@tromey.com>
5663
5664         PR tui/28819:
5665         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5666
5667 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5668
5669         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5670         field.
5671         * rs6000-tdep.c: Include reggroups.h.
5672         (IS_V_ALIAS_PSEUDOREG): Define.
5673         (rs6000_register_name): Return names for the "vX" aliases.
5674         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5675         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5676         aliases.  Call default_register_reggroup_p for all other
5677         pseudo-registers.
5678         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5679         New functions.
5680         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5681         Handle "vX" aliases.
5682         (v_alias_pseudo_register_collect): New function.
5683         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5684         (rs6000_gdbarch_init): Initialize "vX" aliases as
5685         pseudo-registers.  Restore registration of
5686         rs6000_pseudo_register_reggroup_p with
5687         set_tdesc_pseudo_register_reggroup_p.
5688
5689 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5690
5691         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5692         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5693         set_gdbarch_num_pseudo_regs.
5694
5695 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5696
5697         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5698         Remove arg prefixname, add do_set and do_show.
5699         Add member functions set_list and show_list.
5700         * cli/cli-style.c (class cli_style_option): Update accordingly.
5701         (style_set_list): Move to file scope.
5702         (style_show_list): Likewise.
5703         (set_style): Call help_list.
5704         (show_style): Call cmd_show_list.
5705         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5706         Update to use the new macro.
5707
5708 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5709
5710         * ada-lang.c (_initialize_ada_language): Expand the help text
5711         for the "catch exception" command.
5712
5713 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5714
5715         * symtab.c (matching_obj_sections): Initialize obj,
5716         declare it closer to its usage.
5717
5718 2019-01-10  Tom Tromey  <tom@tromey.com>
5719
5720         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5721         (basic_inf_threads_range): Remove.
5722         (inf_threads_range, inf_non_exited_threads_range)
5723         (safe_inf_threads_range): Use next_adapter.
5724
5725 2019-01-10  Keith Seitz  <keiths@redhat.com>
5726
5727         PR gdb/23712
5728         PR symtab/23010
5729         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5730         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5731
5732 2019-01-10  Keith Seitz  <keiths@redhat.com>
5733
5734         PR gdb/23712
5735         PR symtab/23010
5736         * dictionary.c (pending_to_vector): Remove.
5737         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5738         Remove _1 suffix, replacing functions of the same name.  Update
5739         all callers.
5740         (dict_create_hashed, dict_create_hashed_expandable)
5741         (dict_create_linear, dict_create_linear_expandable, dict_free)
5742         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5743         Make functions static.
5744
5745 2019-01-10  Keith Seitz  <keiths@redhat.com>
5746
5747         PR gdb/23712
5748         PR symtab/23010
5749         * dictionary.h (struct dictionary): Replace declaration with
5750         multidictionary.
5751         (dict_create_hashed, dict_create_hashed_expandable)
5752         (dict_create_linear, dict_create_linear_expandable)
5753         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5754         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5755         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5756         taking multidictionary argument.
5757         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5758         * block.h (struct block) <dict>: Change to multidictionary
5759         and rename `multidict'.
5760         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5761         symmisc.c: Update all dictionary references to multidictionary.
5762
5763 2019-01-10  Keith Seitz  <keiths@redhat.com>
5764
5765         PR gdb/23712
5766         PR symtab/23010
5767         * dictionary.c: Include unordered_map.
5768         (pending_to_vector): New function.
5769         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5770         Rewrite the non-"_1" functions to take vector instead
5771         of linked list.
5772         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5773         "new" _1 versions of the same name.
5774         (multidictionary): Define.
5775         (std::hash<enum language): New definition.
5776         (collate_pending_symbols_by_language, mdict_create_hashed)
5777         (mdict_create_hashed_expandable, mdict_create_linear)
5778         (mdict_create_linear_expandable, mdict_free)
5779         (find_language_dictionary, create_new_language_dictionary)
5780         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5781         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5782         (mdict_size, mdict_empty): New functions.
5783         * dictionary.h (mdict_iterator): Define.
5784
5785 2019-01-10  Pedro Alves  <palves@redhat.com>
5786
5787         * breakpoint.c (read_uploaded_action)
5788         (create_tracepoint_from_upload): Adjust to use
5789         gdb::unique_xmalloc_ptr.
5790         * ctf.c (ctf_write_uploaded_tp):
5791         (SET_ARRAY_FIELD): Use emplace_back.
5792         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5793         * tracefile-tfile.c (tfile_write_uploaded_tp):
5794         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5795         gdb::unique_xmalloc_ptr.
5796         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5797         at_string, cond_string, cmd_strings>: Replace char pointers
5798         with gdb::unique_xmalloc_ptr.
5799
5800 2019-01-10  Pedro Alves  <palves@redhat.com>
5801
5802         * solib-target.c (library_list_start_library): Don't xstrdup name.
5803
5804 2019-01-10  Pedro Alves  <palves@redhat.com>
5805
5806         * mdebugread.c (parse_partial_symbols): Use
5807         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5808
5809 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5810
5811         * linux-fork.c (scoped_switch_fork_info)
5812         <~scoped_switch_fork_info>: Fix incorrect variable name.
5813
5814 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5815
5816         * linux-fork.c (scoped_switch_fork_info)
5817         <scoped_switch_fork_info>: Make explicit.
5818         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5819
5820 2019-01-10  Tom Tromey  <tom@tromey.com>
5821
5822         * objfiles.h (objfile::reset_psymtabs): Update.
5823         * objfiles.c (objfile::objfile): Update.
5824         * psymtab.h (psymtab_storage::obstack): Update.
5825         (psymtab_storage::m_obstack): Use gdb::optional.
5826         (class psymtab_storage): Update comment.  Remove objfile
5827         parameter.
5828         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5829
5830 2019-01-10  Tom Tromey  <tom@tromey.com>
5831
5832         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5833         <free_psymtabs>: Now private.
5834         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5835         (allocate_psymtab): Use new method.
5836
5837 2019-01-10  Tom Tromey  <tom@tromey.com>
5838
5839         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5840         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5841         * mdebugread.c (parse_partial_symbols): Use
5842         allocate_dependencies.
5843         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5844         allocate_dependencies.
5845         (process_psymtab_comp_unit_reader)
5846         (build_type_psymtab_dependencies): Likewise.
5847         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5848
5849 2019-01-10  Tom Tromey  <tom@tromey.com>
5850
5851         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5852         PSYMBOL_SET_LANGUAGE.
5853         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5854
5855 2019-01-10  Tom Tromey  <tom@tromey.com>
5856
5857         * psymtab.h (psymtab_storage::obstack): New method.
5858         <m_obstack>: Rename from obstack; now private.
5859         * psymtab.c (psymtab_storage): Update.
5860         * dwarf2read.c (create_addrmap_from_index)
5861         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5862         Update.
5863
5864 2019-01-10  Tom Tromey  <tom@tromey.com>
5865
5866         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5867         * objfiles.h (objfile::reset_psymtabs): New method.
5868
5869 2019-01-10  Tom Tromey  <tom@tromey.com>
5870
5871         * symmisc.c (print_symbol_bcache_statistics): Update.
5872         (print_objfile_statistics): Update.
5873         * symfile.c (reread_symbols): Update.
5874         * psymtab.h (class psymtab_storage): New.
5875         * psymtab.c (psymtab_storage): New constructor.
5876         (~psymtab_storage): New destructor.
5877         (require_partial_symbols): Update.
5878         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5879         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5880         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5881         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5882         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5883         (start_psymtab_common, end_psymtab_common)
5884         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5885         (allocate_psymtab): Update.
5886         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5887         Update.
5888         (dump_psymtab_addrmap, maintenance_print_psymbols)
5889         (maintenance_check_psymtabs): Update.
5890         (class objfile_psymtabs): Move to objfiles.h.
5891         * psympriv.h (discard_psymtab): Now inline.
5892         (psymtab_discarder::psymtab_discarder): Update.
5893         (psymtab_discarder::~psymtab_discarder): Update.
5894         (ALL_OBJFILE_PSYMTABS): Rewrite.
5895         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5896         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5897         Remove fields.
5898         <partial_symtabs>: New field.
5899         (class objfile_psymtabs): Move from psymtab.h.  Update.
5900         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5901         psymbol_cache.
5902         (objfile::~objfile): Don't destroy psymbol_cache.
5903         * mdebugread.c (parse_partial_symbols): Update.
5904         * dwarf2read.c (create_addrmap_from_index)
5905         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5906         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5907         (add_partial_subprogram, dwarf2_ranges_read): Update.
5908         * dwarf-index-write.c (write_address_map)
5909         (write_one_signatured_type, recursively_write_psymbols)
5910         (class debug_names, class debug_names, write_psymtabs_to_index):
5911         Update.
5912
5913 2019-01-10  Tom Tromey  <tom@tromey.com>
5914
5915         * symtab.h (SYMBOL_SET_NAMES): Update.
5916         (symbol_set_names): Update.
5917         (MSYMBOL_SET_NAMES): Update.
5918         * symtab.c (symbol_set_names): Change argument to be an
5919         objfile_per_bfd_storage.
5920         * psymtab.c (add_psymbol_to_bcache): Update.
5921         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5922
5923 2019-01-10  Tom Tromey  <tom@tromey.com>
5924
5925         * symtab.c (create_demangled_names_hash): Change argument to be an
5926         objfile_per_bfd_storage.
5927         (symbol_set_names): Update.
5928
5929 2019-01-10  Tom Tromey  <tom@tromey.com>
5930
5931         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5932         init_psymbol_list.
5933         * psymtab.c (init_psymbol_list): Do nothing if already called.
5934         * psympriv.h (init_psymbol_list): Add comment.
5935         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5936         init_psymbol_list.
5937         * dbxread.c (dbx_symfile_read): Unconditionally call
5938         init_psymbol_list.
5939
5940 2019-01-10  Tom Tromey  <tom@tromey.com>
5941
5942         * xcoffread.c (scan_xcoff_symtab): Update.
5943         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5944         "where".
5945         * mdebugread.c (parse_partial_symbols)
5946         (handle_psymbol_enumerators): Update.
5947         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5948         * dbxread.c (read_dbx_symtab): Update.
5949         * psympriv.h (psymbol_placement): New enum.
5950         (add_psymbol_to_list): Update.
5951
5952 2019-01-10  Tom Tromey  <tom@tromey.com>
5953
5954         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5955         static_psymbols parameters.
5956         (scan_xcoff_symtab): Update.
5957         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5958         static_psymbols parameters.
5959         * psympriv.h (start_psymtab_common): Update.
5960         * mdebugread.c (parse_partial_symbols): Update.
5961         * dwarf2read.c (create_partial_symtab): Update.
5962         * dbxread.c (read_dbx_symtab): Update.
5963         (start_psymtab): Remove global_psymbols and static_psymbols
5964         parameters.
5965
5966 2019-01-10  Tom Tromey  <tom@tromey.com>
5967
5968         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5969         * psymtab.c (allocate_psymtab): Add comment.
5970         * psympriv.h (allocate_psymtab): Add comment.
5971         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5972         initializations.
5973         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5974
5975 2019-01-10  Tom Tromey  <tom@tromey.com>
5976
5977         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5978         Don't declare.
5979         * mipsread.c: Include mdebugread.h.
5980         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5981         Declare.
5982         * elfread.c: Include mdebugread.h.
5983
5984 2019-01-09  Tom Tromey  <tom@tromey.com>
5985
5986         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5987         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5988         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5989         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5990         (psym_lookup_symbol, psym_find_last_source_symtab)
5991         (psym_forget_cached_source_info, psym_print_stats)
5992         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5993         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5994         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5995         (psym_find_compunit_symtab_by_address)
5996         (maintenance_print_psymbols, maintenance_info_psymtabs)
5997         (maintenance_check_psymtabs): Use ranged for.
5998         * psymtab.h (class objfile_psymtabs): New.
5999         (require_partial_symbols): Return objfile_psymtabs.
6000         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6001
6002 2019-01-09  Tom Tromey  <tom@tromey.com>
6003
6004         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6005         (find_pc_mapped_section, list_overlays_command)
6006         (map_overlay_command, unmap_overlay_command)
6007         (simple_overlay_update): Use all_objfiles.
6008         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6009         * printcmd.c (info_symbol_command): Use all_objfiles.
6010         * objfiles.h (ALL_OBJSECTIONS): Remove.
6011         * maint.c (maintenance_translate_address): Use all_objfiles.
6012         * gcore.c (gcore_create_callback): Use all_objfiles.
6013         (objfile_find_memory_regions): Likewise.
6014
6015 2019-01-09  Tom Tromey  <tom@tromey.com>
6016
6017         * symtab.c (find_line_symtab, info_sources_command)
6018         (make_source_files_completion_list): Use objfile_compunits.
6019         * source.c (select_source_symtab): Use objfile_compunits.
6020         * objfiles.h (struct objfile): Update comment.
6021         (ALL_OBJFILES): Remove.
6022         (ALL_FILETABS): Remove.
6023         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6024         objfile_compunits.
6025
6026 2019-01-09  Tom Tromey  <tom@tromey.com>
6027
6028         * symmisc.c (print_objfile_statistics, dump_objfile)
6029         (maintenance_print_symbols): Use compunit_filetabs.
6030         * source.c (forget_cached_source_info_for_objfile): Use
6031         compunit_filetabs.
6032         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6033         (ALL_FILETABS): Use compunit_filetabs.
6034         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6035         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6036
6037 2019-01-09  Tom Tromey  <tom@tromey.com>
6038
6039         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6040         (compunit_filetabs): New.
6041         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6042         compunit_filetabs.
6043         (info_sources_command, make_source_files_completion_list): Remove
6044         declaration.
6045         * symmisc.c (print_objfile_statistics, dump_objfile)
6046         (maintenance_print_symbols): Remove declaration.
6047         (maintenance_info_symtabs): Use compunit_filetabs.
6048         (maintenance_info_line_tables): Likewise.
6049         * source.c (select_source_symtab): Change local variable name.
6050         (forget_cached_source_info_for_objfile): Remove declaration.
6051         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6052         * objfiles.c (objfile_relocate1): Remove declaration.
6053         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6054         declaration.
6055         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6056         * coffread.c (coff_symtab_read): Remove declaration.
6057         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6058         compunit_filetabs.
6059
6060 2019-01-09  Tom Tromey  <tom@tromey.com>
6061
6062         * symtab.c (lookup_objfile_from_block)
6063         (find_pc_sect_compunit_symtab, search_symbols)
6064         (default_collect_symbol_completion_matches_break_on): Use
6065         objfile_compunits.
6066         * objfiles.h (ALL_COMPUNITS): Remove.
6067         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6068         * cp-support.c (add_symbol_overload_list_qualified): Use
6069         objfile_compunits.
6070         * ada-lang.c (ada_collect_symbol_completion_matches)
6071         (ada_add_global_exceptions): Use objfile_compunits.
6072
6073 2019-01-09  Tom Tromey  <tom@tromey.com>
6074
6075         * source.c (select_source_symtab)
6076         (forget_cached_source_info_for_objfile): Remove declaration.
6077         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6078         declaration.
6079         * maint.c (count_symtabs_and_blocks): Remove declaration.
6080         * cp-support.c (add_symbol_overload_list_qualified): Remove
6081         declaration.
6082         * coffread.c (coff_symtab_read): Remove declaration.
6083         * symtab.c (lookup_symbol_in_objfile_symtabs)
6084         (basic_lookup_transparent_type_1): Use objfile_compunits.
6085         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6086         (info_sources_command, search_symbols)
6087         (default_collect_symbol_completion_matches_break_on)
6088         (make_source_files_completion_list): Remove declaration.
6089         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6090         (ada_collect_symbol_completion_matches)
6091         (ada_add_global_exceptions): Remove declaration.
6092         * linespec.c (iterate_over_all_matching_symtabs): Use
6093         objfile_compunits.
6094         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6095         (class objfile_compunits): New.
6096         (ALL_COMPUNITS): Use objfile_compunits.
6097         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6098         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6099         objfile_compunits.
6100         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6101
6102 2019-01-09  Tom Tromey  <tom@tromey.com>
6103
6104         * symtab.c (search_symbols)
6105         (default_collect_symbol_completion_matches_break_on): Use
6106         objfile_msymbols.
6107         * ada-lang.c (ada_lookup_simple_minsym)
6108         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6109         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6110         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6111         objfile_msymbols.
6112         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6113         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6114         * objc-lang.c (find_methods): Use objfile_msymbols.
6115         (info_selectors_command, info_classes_command): Likewise.
6116         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6117         * objfiles.h (class objfile_msymbols): New.
6118         (ALL_OBJFILE_MSYMBOLS): Remove.
6119         (ALL_MSYMBOLS): Remove.
6120
6121 2019-01-09  Tom Tromey  <tom@tromey.com>
6122
6123         * common/next-iterator.h (next_adapter): Add Iterator template
6124         parameter.
6125         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6126         (class all_objfiles_safe): New.
6127         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6128         * objfiles.c (put_objfile_before): Update comment.
6129         (add_separate_debug_objfile): Likewise.
6130         (free_all_objfiles): Use all_objfiles_safe.
6131         (objfile_purge_solibs): Likewise.
6132
6133 2019-01-09  Tom Tromey  <tom@tromey.com>
6134
6135         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6136         (expand_symtab_containing_pc, lookup_static_symbol)
6137         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6138         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6139         all_objfiles.
6140         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6141         * breakpoint.c (create_overlay_event_breakpoint)
6142         (create_longjmp_master_breakpoint)
6143         (create_std_terminate_master_breakpoint)
6144         (create_exception_master_breakpoint): Use all_objfiles.
6145         * linux-thread-db.c (try_thread_db_load_from_pdir)
6146         (has_libpthread): Use all_objfiles.
6147         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6148         * linespec.c (iterate_over_all_matching_symtabs)
6149         (search_minsyms_for_name): Use all_objfiles.
6150         * maint.c (maintenance_info_sections): Use all_objfiles.
6151         * main.c (captured_main_1): Use all_objfiles.
6152         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6153         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6154         * guile/scm-pretty-print.c
6155         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6156         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6157         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6158         (maintenance_print_msymbols): Use all_objfiles.
6159         * source.c (select_source_symtab): Use all_objfiles.
6160         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6161         * symfile.c (remove_symbol_file_command)
6162         (expand_symtabs_matching, map_symbol_filenames): Use
6163         all_objfiles.
6164         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6165         all_objfiles.
6166         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6167         * objc-lang.c (find_methods): Use all_objfiles.
6168         * objfiles.c (have_partial_symbols, have_full_symbols)
6169         (have_minimal_symbols, qsort_cmp)
6170         (default_iterate_over_objfiles_in_search_order): Use
6171         all_objfiles.
6172         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6173         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6174         (maintenance_check_psymtabs): Use all_objfiles.
6175         (ALL_PSYMTABS): Remove.
6176         * compile/compile-object-run.c (do_module_cleanup): Use
6177         all_objfiles.
6178         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6179         * cp-support.c (add_symbol_overload_list_qualified): Use
6180         all_objfiles.
6181         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6182         Use all_objfiles.
6183         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6184         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6185         all_objfiles.
6186         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6187         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6188         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6189         Uses all_objfiles.
6190         * solib.c (solib_read_symbols): Use all_objfiles
6191
6192 2019-01-09  Tom Tromey  <tom@tromey.com>
6193
6194         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6195         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6196         all_objfiles.
6197         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6198         * symmisc.c (print_symbol_bcache_statistics)
6199         (print_objfile_statistics, maintenance_print_objfiles)
6200         (maintenance_info_symtabs, maintenance_check_symtabs)
6201         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6202         all_objfiles.
6203         * source.c (forget_cached_source_info): Use all_objfiles.
6204         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6205         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6206         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6207         * objfiles.c (update_section_map): Use all_objfiles.
6208         (shared_objfile_contains_address_p): Likewise.
6209         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6210         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6211
6212 2019-01-09  Tom Tromey  <tom@tromey.com>
6213
6214         * common/next-iterator.h: New file.
6215         * objfiles.h (class all_objfiles): New.
6216         (struct objfile_iterator): New.
6217
6218 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6219
6220         * NEWS: Move the description of the changed "frame", "select-frame",
6221          and "info frame" commands to the Changed commands section.
6222
6223 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6224
6225         * gdbtypes.c (check_stub_method_group): Remove handling of old
6226         mangling schemes.
6227         * linespec.c (find_methods): Likewise.
6228         * stabsread.c (read_member_functions): Likewise.
6229         * valops.c (search_struct_method): Likewise.
6230         (value_struct_elt_for_reference): Likewise.
6231         * NEWS: Mention this change.
6232
6233 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6236         print_source_lines.
6237         * source.c (print_source_lines_base): Update line number check.
6238         (print_source_lines): New function.
6239         (source_lines_range::source_lines_range): New function.
6240         * source.h (class source_lines_range): New class.
6241         (print_source_lines): New declaration.
6242
6243 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6244
6245         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6246
6247 2019-01-08  Tom Tromey  <tom@tromey.com>
6248             Simon Marchi  <simon.marchi@ericsson.com>
6249
6250         PR gdb/24060
6251         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6252         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6253         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6254         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6255         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6256         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6257
6258 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6259
6260         * source.c (select_source_symtab): Move header comment to
6261         declaration in source.h.
6262         (forget_cached_source_info_for_objfile): Likewise.
6263         (forget_cached_source_info): Likewise.
6264         (identify_source_line): Likewise.
6265         * source.h (identify_source_line): Move declaration from symtab.h
6266         and add comment from source.c
6267         (print_source_lines): Likewise.
6268         (forget_cached_source_info_for_objfile): Likewise.
6269         (forget_cached_source_info): Likewise.
6270         (select_source_symtab): Likewise.
6271         (enum print_source_lines_flag): Move definition from symtab.h.
6272         * symtab.h (identify_source_line): Move declaration to source.h.
6273         (print_source_lines): Likewise.
6274         (forget_cached_source_info_for_objfile): Likewise.
6275         (forget_cached_source_info): Likewise.
6276         (select_source_symtab): Likewise.
6277         (enum print_source_lines_flag): Move definition to source.h.
6278         * tui/tui-hooks.c: Add 'source.h' include.
6279
6280 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6281
6282         * source.c (print_source_lines_base): Handle requests to print
6283         reverse line number sequences, and guard against empty lines
6284         string.
6285
6286 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6287
6288         * source.c (print_source_lines_base): Fix skip of '\r' if next
6289         character is '\n'.
6290
6291 2019-01-06  Tom Tromey  <tom@tromey.com>
6292
6293         * c-exp.y (struct c_parse_state) <macro_original_text,
6294         expansion_obstack>: New member.
6295         (macro_original_text, expansion_obstack): Remove globals.
6296         (scan_macro_expansion, scanning_macro_expansion)
6297         (finished_macro_expansion): Update.
6298         (scan_macro_cleanup): Remove.
6299         (yylex, c_parse): Update.
6300
6301 2019-01-06  Tom Tromey  <tom@tromey.com>
6302
6303         * c-exp.y (struct c_parse_state) <strings>: New member.
6304         (operator_stoken): Update.
6305
6306 2019-01-06  Tom Tromey  <tom@tromey.com>
6307
6308         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6309         (union type_stack_elt) <typelist_val>: Now a pointer to
6310         std::vector.
6311         (type_stack_cleanup): Don't declare.
6312         (push_typelist): Update.
6313         * parse.c (pop_typelist): Return a std::vector.
6314         (push_typelist): Take a std::vector.
6315         (follow_types): Update.  Do not free args.
6316         (type_stack_cleanup): Remove.
6317         * c-exp.y (struct c_parse_state): New.
6318         (cpstate): New global.
6319         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6320         (nonempty_typelist): Update.
6321         (func_mod): Create a new vector.
6322         (c_parse): Create a c_parse_state.
6323         (check_parameter_typelist): Do not delete params.
6324         (function_method): Update.  Do not delete type_list.
6325
6326 2019-01-06  Tom Tromey  <tom@tromey.com>
6327
6328         PR gdb/28155:
6329         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6330         check_typedef.
6331         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6332         (print_return_value): Likewise.
6333
6334 2019-01-05  Tom Tromey  <tom@tromey.com>
6335
6336         * contrib/cleanup_check.py: Remove.
6337         * contrib/gcc-with-excheck: Remove.
6338         * contrib/exsummary.py: Remove.
6339         * contrib/excheck.py: Remove.
6340
6341 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6342
6343         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6344         NULL. Initialize tpprev to NULL instead of assigning it
6345         to NULL on the next statement.
6346         * windows-nat.c (windows_delete_thread): Remove check for
6347         main_thread_id before printing thread exit notifications.
6348         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6349         Remove thread ID check against main_thread_id.
6350         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6351         windows_delete_thread.
6352         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6353
6354 2019-01-04  Tom Tromey  <tom@tromey.com>
6355
6356         * compile/compile.c (_initialize_compile): Use upper case for
6357         metasyntactic variables.
6358         * symmisc.c (_initialize_symmisc): Use upper case for
6359         metasyntactic variables.
6360         * psymtab.c (_initialize_psymtab): Use upper case for
6361         metasyntactic variables.
6362         * demangle.c (demangle_command): Use upper case for metasyntactic
6363         variables.
6364         (_initialize_demangler): Likewise.
6365         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6366         variables.
6367
6368 2019-01-03  Tom Tromey  <tom@tromey.com>
6369
6370         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6371
6372 2019-01-03  Tom Tromey  <tom@tromey.com>
6373
6374         * python/py-symtab.c (salpy_str): Update.
6375         (struct salpy_sal_object) <symtab>: Now a PyObject.
6376         (salpy_dealloc): Update.
6377         (del_objfile_sal): Use gdbpy_ref.
6378
6379 2019-01-03  Tom Tromey  <tom@tromey.com>
6380
6381         * python/py-type.c (convert_field): Use new_reference.  Return
6382         gdbpy_ref.
6383         (make_fielditem): Return gdbpy_ref.
6384         (typy_fields): Update.
6385         (typy_getitem): Update.
6386         (field_name): Return gdbpy_ref.  Use new_reference.
6387         (typy_iterator_iternext): Update.
6388
6389 2019-01-03  Tom Tromey  <tom@tromey.com>
6390
6391         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6392
6393 2019-01-03  Tom Tromey  <tom@tromey.com>
6394
6395         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6396         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6397         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6398         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6399         (pspy_set_type_printers): Likewise.
6400         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6401         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6402         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6403         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6404         (objfpy_set_type_printers): Likewise.
6405
6406 2019-01-03  Tom Tromey  <tom@tromey.com>
6407
6408         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6409         (gdbpy_print_stack): Use gdbpy_err_fetch.
6410         * python/python-internal.h (class gdbpy_err_fetch): New class.
6411         (class gdbpy_enter) <m_error_type, m_error_value,
6412         m_error_traceback>: Remove.
6413         <m_error>: New member.
6414         (gdbpy_exception_to_string): Don't declare.
6415         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6416         * python/py-value.c (convert_value_from_python): Use
6417         gdbpy_err_fetch.
6418         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6419         gdbpy_exception_to_string.
6420         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6421         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6422         gdbpy_err_fetch.
6423
6424 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6425
6426         * linux-nat.c (delete_lwp_cleanup): Delete.
6427         (struct lwp_deleter): New struct.
6428         (lwp_info_up): New typedef.
6429         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6430         lwp_info_up.
6431
6432 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6433
6434         * linux-fork.c (class scoped_switch_fork_info): New class.
6435         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6436
6437 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6438
6439         * valops.c (find_overload_match): Remove use of null_cleanup, and
6440         calls to do_cleanups.
6441
6442 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * compile/compile-cplus-types.c
6445         (compile_cplus_instance::decl_name): Handle changes to
6446         cp_func_name.
6447         * cp-support.c (cp_func_name): Update header comment, update
6448         return type.
6449         * cp-support.h (cp_func_name): Update return type in declaration.
6450         * valops.c (find_overload_match): Move temp_func local to top
6451         level of function and change its type.  Use temp_func to hold and
6452         delete temporary string obtained from cp_func_name.
6453
6454 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6455
6456         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6457         gdb::char_vector, remove cleanup, and update uses of `msg`.
6458
6459 2019-01-03  Jim Wilson  <jimw@sifive.com>
6460
6461         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6462
6463 2019-01-02  Tom Tromey  <tom@tromey.com>
6464
6465         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6466         (tdesc_parse_xml): Remove cleanups.
6467         * target-descriptions.h (make_cleanup_free_target_description):
6468         Don't declare.
6469         (target_desc_deleter): New struct.
6470         (target_desc_up): New typedef.
6471         * target-descriptions.c (target_desc_deleter::operator()): Rename
6472         from free_target_description.
6473         (make_cleanup_free_target_description): Remove.
6474
6475 2019-01-02  Tom Tromey  <tom@tromey.com>
6476
6477         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6478         constructor, destructor.
6479         (linespec_parser): Remove typedef.
6480         (~linespec_parser): Rename from linespec_parser_delete.
6481         (linespec_lex_to_end, linespec_complete_label)
6482         (linespec_complete): Update.
6483         (decode_line_full): Remove cleanups.
6484         (decode_line_1): Update.
6485
6486 2019-01-02  Tom Tromey  <tom@tromey.com>
6487
6488         * python/python-internal.h (inferior_to_inferior_object): Change
6489         return type.
6490         * python/py-exitedevent.c (create_exited_event_object): Update.
6491         * python/py-inferior.c (inferior_to_inferior_object): Return
6492         gdbpy_ref.
6493         (python_new_inferior, python_inferior_deleted)
6494         (thread_to_thread_object, delete_thread_object)
6495         (build_inferior_list, gdbpy_selected_inferior): Update.
6496         * python/py-infthread.c (create_thread_object): Update.  Also fail
6497         if inferior_to_inferior_object fails.
6498
6499 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6500
6501         * inferior.h (class inferior) <displaced_step_state>: New field.
6502         * infrun.h (struct displaced_step_state): Move here from
6503         infrun.c.  Initialize fields, add constructor.
6504         <inf>: Remove field.
6505         <reset>: New method.
6506         * infrun.c (struct displaced_step_inferior_state): Move to
6507         infrun.h.
6508         (displaced_step_inferior_states): Remove.
6509         (get_displaced_stepping_state): Adust.
6510         (displaced_step_in_progress_any_inferior): Adjust.
6511         (displaced_step_in_progress_thread): Adjust.
6512         (displaced_step_in_progress): Adjust.
6513         (add_displaced_stepping_state): Remove.
6514         (get_displaced_step_closure_by_addr): Adjust.
6515         (remove_displaced_stepping_state): Remove.
6516         (infrun_inferior_exit): Call displaced_step_state.reset.
6517         (use_displaced_stepping): Don't check for NULL.
6518         (displaced_step_prepare_throw): Call
6519         get_displaced_stepping_state.
6520         (displaced_step_fixup): Don't check for NULL.
6521         (prepare_for_detach): Don't check for NULL.
6522
6523 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6524
6525         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6526          in case of call that did not complete.
6527
6528 2019-01-02  Andrey Utkin  <autkin@undo.io>
6529
6530         * symfile.c (find_separate_debug_file): Fix search of debug files for
6531         remote debuggee.
6532
6533 2019-01-02  Tom Tromey  <tom@tromey.com>
6534
6535         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6536         indentation.
6537         * python/py-frame.c (frapy_older): Remove cast.
6538         (frapy_newer): Likewise.
6539         * python/py-breakpoint.c (local_setattro): Remove cast.
6540         * python/py-arch.c (archpy_name): Remove local variable.
6541         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6542
6543 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6544
6545         * unittests/basic_string_view/element_access/char/empty.cc:
6546         Fix year range in copyright header.
6547
6548 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6549
6550         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6551         Delete.
6552         <operator==>: Update with for removed field.
6553         <hash>: Likewise.
6554         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6555         <isa_features>: ...this.
6556         <abi_features>: New field.
6557         (riscv_isa_flen): Update comment.
6558         (riscv_abi_xlen): New declaration.
6559         (riscv_abi_flen): New declaration.
6560         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6561         isa_features.
6562         (riscv_abi_xlen): New function.
6563         (riscv_isa_flen): Update to get answer from isa_features.
6564         (riscv_abi_flen): New function.
6565         (riscv_has_fp_abi): Update to get answer from abi_features.
6566         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6567         xlen and flen.
6568         (riscv_call_info) <xlen, flen>: Update comment.
6569         (riscv_call_arg_struct): Remove invalid assertions
6570         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6571         is removed.
6572         (riscv_gdbarch_init): Gather isa features and abi features
6573         separately, ensure both match on the gdbarch when reusing an old
6574         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6575         a target with 64-bit float hardware.
6576
6577 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6578
6579         * source.c (search_command_helper): Stop reverse search
6580         when line 1 has been searched.
6581
6582 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6583
6584         * record-full.c (record_full_base_target::close): Rewrite
6585         record_full_core_buf_list free logic.
6586
6587 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6588
6589         * break-catch-syscall.c (print_one_catch_syscall): xfree
6590         the last text.
6591
6592 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6593
6594         * top.c (print_gdb_version): Update Copyright year in version
6595         message.
6596
6597 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6598
6599         Update copyright year range in all GDB files.
6600
6601 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6602
6603         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6604
6605 For older changes see ChangeLog-2018.
6606 \f
6607 Local Variables:
6608 mode: change-log
6609 left-margin: 8
6610 fill-column: 74
6611 version-control: never
6612 coding: utf-8
6613 End:
6614