gdb/ChangeLog

   1 2020-03-13  Tom Tromey  <tom@tromey.com>
   2
   3         * riscv-tdep.c (riscv_print_one_register_info): Use
   4         common_val_print.
   5
   6 2020-03-13  Tom Tromey  <tom@tromey.com>
   7
   8         * mi/mi-main.c (output_register): Use common_val_print.
   9
  10 2020-03-13  Tom Tromey  <tom@tromey.com>
  11
  12         * infcmd.c (default_print_one_register_info): Use
  13         common_val_print.
  14
  15 2020-03-13  Tom Tromey  <tom@tromey.com>
  16
  17         * valprint.h (common_val_print_checked): Declare.
  18         * valprint.c (common_val_print_checked): New function.
  19         * stack.c (print_frame_arg): Use common_val_print_checked.
  20
  21 2020-03-13  Tom Tromey  <tom@tromey.com>
  22
  23         * valprint.c (do_val_print): New function, from val_print.
  24         (val_print): Use do_val_print.
  25         (common_val_print): Use do_val_print.
  26
  27 2020-03-13  Tom Tromey  <tom@tromey.com>
  28
  29         * valprint.c (value_print): Use scoped_value_mark.
  30
  31 2020-03-13  Tom de Vries  <tdevries@suse.de>
  32
  33         PR symtab/25646
  34         * psymtab.c (partial_symtab::partial_symtab): Don't set
  35         globals_offset and statics_offset.  Push element onto
  36         current_global_psymbols and current_static_psymbols stacks.
  37         (concat): New function.
  38         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
  39         element from current_global_psymbols and current_static_psymbols
  40         stacks.  Concat popped elements to global_psymbols and
  41         static_symbols.
  42         (add_psymbol_to_list): Use current_global_psymbols and
  43         current_static_psymbols stacks.
  44         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
  45         current_static_psymbols fields.
  46
  47 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
  48
  49         * corelow.c (sniff_core_bfd): Remove.
  50         (class core_target) <m_core_vec>: Remove.
  51         (core_target::core_target): Update.
  52         (core_file_fns): Remove.
  53         (deprecated_add_core_fns): Remove.
  54         (default_core_sniffer): Remove.
  55         (sniff_core_bfd): Remove.
  56         (default_check_format): Remove.
  57         (gdb_check_format): Remove.
  58         (core_target_open): Update.
  59         (core_target::get_core_register_section): Update.
  60         (get_core_registers_cb): Update.
  61         (core_target::fetch_registers): Update.
  62         * gdbcore.h (struct core_fns): Remove.
  63         (deprecated_add_core_fns): Remove.
  64         (default_core_sniffer): Remove.
  65         (default_check_format): Remove.
  66
  67 2020-03-12  Tom Tromey  <tom@tromey.com>
  68
  69         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
  70         CORE_ADDR.
  71         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
  72
  73 2020-03-12  Tom Tromey  <tom@tromey.com>
  74
  75         * remote.c (remote_target::download_tracepoint)
  76         (remote_target::enable_tracepoint)
  77         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
  78         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
  79         sprintf_vma.
  80
  81 2020-03-12  Tom Tromey  <tom@tromey.com>
  82
  83         * symfile-mem.c: Update CORE_ADDR size assert.
  84
  85 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
  86
  87         * selftest.m4: Move to gdbsupport/.
  88         * acinclude.m4: Update path to selftest.m4.
  89
  90 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
  91
  92         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
  93         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
  94         gdbarch-selfselftests.c and selftest-arch.c.
  95         (SUBDIR_UNITTESTS_OBS): Rename to...
  96         (SELFTESTS_OBS): ... this.
  97         (COMMON_SFILES): Remove disasm-selftests.c and
  98         gdbarch-selftests.c.
  99         * configure.ac: Don't add selftest-arch.{c,o} to
 100         CONFIG_{SRCS,OBS}.
 101         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
 102         preprocessor conditions.
 103
 104 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 105
 106         * configure.ac: Don't source bfd/development.sh.
 107         * selftest.m4: Modify comment.
 108         * configure: Re-generate.
 109
 110 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
 111
 112         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
 113         not "true" or "false".
 114         * configure: Re-generate.
 115
 116 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
 117
 118         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
 119         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
 120         renamed to arm_nbsd_supply_gregset.
 121         (fetch_register): Update to call arm_nbsd_supply_gregset.
 122         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
 123         (arm_netbsd_nat_target::fetch_registers): Update.
 124         (fetch_elfcore_registers): Removed.
 125         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
 126         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
 127         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
 128         not require NetBSD system headers.
 129         (arm_nbsd_regset): New struct.
 130         (arm_nbsd_iterate_over_regset_sections): New function.
 131         (arm_netbsd_init_abi_common): Updated to call
 132         set_gdbarch_iterate_over_regset_sections.
 133         * arm-nbsd-tdep.h: New file.
 134
 135 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
 136
 137         * symtab.c (find_pc_sect_line): Add check which prevents infinite
 138         recursion.
 139
 140 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
 141
 142         * configure: Re-generate.
 143
 144 2020-03-11  Tom Tromey  <tromey@adacore.com>
 145
 146         * ada-typeprint.c (print_choices): Fix comment.
 147
 148 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 149
 150         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
 151         previous item in the list, when the list has no items.
 152
 153 2020-03-11  Tom de Vries  <tdevries@suse.de>
 154
 155         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
 156         PROP_LOCLIST handling code.
 157
 158 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 159
 160         * buildsym-legacy.c (record_line): Pass extra parameter to
 161         record_line.
 162         * buildsym.c (buildsym_compunit::record_line): Take an extra
 163         parameter, reduce duplication in the line table, and record the
 164         is_stmt flag in the line table.
 165         * buildsym.h (buildsym_compunit::record_line): Add extra
 166         parameter.
 167         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
 168         non-statement lines.
 169         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
 170         this to the symtab builder.
 171         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
 172         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
 173         through to dwarf_record_line_1.
 174         * infrun.c (process_event_stop_test): When stepping, don't stop at
 175         a non-statement instruction, and only refresh the step info when
 176         we land in the middle of a line's range.  Also add an extra
 177         comment.
 178         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
 179         field.
 180         * record-btrace.c (btrace_find_line_range): Only record lines
 181         marked as is-statement.
 182         * stack.c (frame_show_address): Show the frame address if we are
 183         in a non-statement sal.
 184         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
 185         (maintenance_print_one_line_table): Print a header for the is_stmt
 186         column, and include is_stmt information in the output.
 187         * symtab.c (find_pc_sect_line): Find lines marked as statements in
 188         preference to non-statements.
 189         (find_pcs_for_symtab_line): Prefer is-statement entries.
 190         (find_line_common): Likewise.
 191         * symtab.h (struct linetable_entry): Add is_stmt field.
 192         (struct symtab_and_line): Likewise.
 193         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
 194         arranging the line table.
 195
 196 2020-03-07  Tom de Vries  <tdevries@suse.de>
 197
 198         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
 199         DIE.
 200
 201 2020-03-07  Tom Tromey  <tom@tromey.com>
 202
 203         * valops.c (value_literal_complex): Remove obsolete comment.
 204         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
 205         comment.
 206
 207 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
 208
 209         * infrun.h: Forward-declare thread_info.
 210         (set_step_info): Add thread_info parameter, add doc.
 211         * infrun.c (set_step_info): Add thread_info parameter, move doc
 212         to header.
 213         * infrun.c (process_event_stop_test): Pass thread to
 214         set_step_info call.
 215         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
 216         set_step_info.
 217         (prepare_one_step): Add thread_info parameter, pass it to
 218         set_step_frame and prepare_one_step (recursive) call.
 219         (step_1): Pass thread to prepare_one_step call.
 220         (step_command_fsm::should_stop): Pass thread to
 221         prepare_one_step.
 222         (until_next_fsm): Pass thread to set_step_frame call.
 223         (finish_command): Pass thread to set_step_info call.
 224
 225 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
 226
 227         * windows-tdep.c (windows_solib_create_inferior_hook):
 228         Check if inferior is running.
 229
 230 2020-03-06  Tom de Vries  <tdevries@suse.de>
 231
 232         * NEWS: Fix "the the".
 233         * ctfread.c: Same.
 234
 235 2020-03-06  Tom de Vries  <tdevries@suse.de>
 236
 237         * psymtab.c (psymtab_to_symtab): Don't print "done.".
 238
 239 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 240
 241         * .dir-locals.el: Add a comment referencing the other copies of
 242         this file.
 243
 244 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
 245
 246         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
 247         psargs.
 248
 249 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 250
 251         * .gitattributes: New file.
 252
 253 2020-03-04  Tom Tromey  <tom@tromey.com>
 254
 255         * symmisc.c (print_symbol_bcache_statistics)
 256         (print_objfile_statistics): Update.
 257         * symfile.c (allocate_symtab): Use intern.
 258         * psymtab.c (partial_symtab::partial_symtab): Use intern.
 259         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 260         macro_cache>: Remove.
 261         <string_cache>: New member.
 262         (struct objfile) <intern>: New methods.
 263         * elfread.c (elf_symtab_read): Use intern.
 264         * dwarf2/read.c (fixup_go_packaging): Intern package name.
 265         (dwarf2_compute_name, dwarf2_physname)
 266         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
 267         names.
 268         (guess_partial_die_structure_name): Update.
 269         (partial_die_info::fixup): Intern name.
 270         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
 271         name.
 272         (dwarf2_name): Intern name.  Update.
 273         * buildsym.c (buildsym_compunit::get_macro_table): Use
 274         string_cache.
 275
 276 2020-03-04  Tom Tromey  <tom@tromey.com>
 277
 278         * jit.c (bfd_open_from_target_memory): Make "target" const.
 279         * corefile.c (gnutarget): Now const.
 280         * gdbcore.h (gnutarget): Now const.
 281
 282 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
 283
 284         * NEWS: Mention support for WOW64 processes.
 285         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
 286         (amd64_windows_segment_register_p): Remove static.
 287         (_initialize_amd64_windows_nat): Update.
 288         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
 289         * i386-windows-nat.c (context_offset): Update.
 290         (i386_mappings): Rename and remove static.
 291         (i386_windows_segment_register_p): Remove static.
 292         (_initialize_i386_windows_nat): Update.
 293         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
 294         (STATUS_WX86_SINGLE_STEP): New macro.
 295         (EnumProcessModulesEx): New macro.
 296         (Wow64SuspendThread): New macro.
 297         (Wow64GetThreadContext): New macro.
 298         (Wow64SetThreadContext): New macro.
 299         (Wow64GetThreadSelectorEntry): New macro.
 300         (windows_set_context_register_offsets): Add static.
 301         (windows_set_segment_register_p): Likewise.
 302         (windows_add_thread): Adapt for WOW64 processes.
 303         (windows_fetch_one_register): Likewise.
 304         (windows_nat_target::fetch_registers): Likewise.
 305         (windows_store_one_register): Likewise.
 306         (display_selector): Likewise.
 307         (display_selectors): Likewise.
 308         (handle_exception): Likewise.
 309         (windows_continue): Likewise.
 310         (windows_nat_target::resume): Likewise.
 311         (windows_add_all_dlls): Likewise.
 312         (do_initial_windows_stuff): Likewise.
 313         (windows_nat_target::attach): Likewise.
 314         (windows_get_exec_module_filename): Likewise.
 315         (windows_nat_target::create_inferior): Likewise.
 316         (windows_xfer_siginfo): Likewise.
 317         (_initialize_loadable): Initialize Wow64SuspendThread,
 318         Wow64GetThreadContext, Wow64SetThreadContext,
 319         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
 320         * windows-nat.h (windows_set_context_register_offsets):
 321         Remove declaration.
 322         (windows_set_segment_register_p): Likewise.
 323         (i386_windows_segment_register_p): Add declaration.
 324         (amd64_windows_segment_register_p): Likewise.
 325
 326 2020-03-04  Luis Machado  <luis.machado@linaro.org>
 327
 328         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
 329         in "info registers" for AArch64/ARM.
 330
 331         The change caused "info registers" to not print GPR's.
 332
 333         gdb/ChangeLog:
 334
 335         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 336
 337         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 338         when reg->group is empty and reggroup is not.
 339
 340 2020-03-03  Tom Tromey  <tromey@adacore.com>
 341
 342         * dwarf2/frame.c (struct dwarf2_frame_cache)
 343         <checked_tailcall_bottom, entry_cfa_sp_offset,
 344         entry_cfa_sp_offset_p>: Remove members.
 345         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
 346         (dwarf2_frame_prev_register): Don't call
 347         dwarf2_tailcall_sniffer_first.
 348         (dwarf2_append_unwinders): Don't append tailcall unwinder.
 349         * frame-unwind.c (add_unwinder): New fuction.
 350         (frame_unwind_init): Use it.  Add tailcall unwinder.
 351
 352 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 353             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 354
 355         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
 356         value should be printed as true.
 357
 358 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
 359
 360         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
 361         (windows_init_abi): Set and use windows_so_ops.
 362
 363 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
 364
 365         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
 366         when verifying if dealing with a convenience variable.
 367
 368 2020-03-03  Luis Machado  <luis.machado@linaro.org>
 369
 370         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
 371
 372 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 373
 374         * infrun.c (gdbarch_supports_displaced_stepping): New.
 375         (use_displaced_stepping): Break up conditions in smaller pieces.
 376         Use gdbarch_supports_displaced_stepping.
 377         (displaced_step_prepare_throw): Use
 378         gdbarch_supports_displaced_stepping.
 379
 380 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 381
 382         * NEWS: Mention new behaviour of the history filename.
 383         * top.c (write_history_p): Add comment.
 384         (show_write_history_p): Add header comment, give a different
 385         message when history writing is on, but the history filename is
 386         empty.
 387         (history_filename): Add comment.
 388         (history_filename_empty): New function.
 389         (show_history_filename): Add header comment, give a different
 390         message when the filename is empty.
 391         (init_history): Compare history_filename against nullptr, and only
 392         read history if the filename is not empty.
 393         (set_history_filename): Add header comment, and only make
 394         non-empty filenames absolute.
 395         (init_main): Make the filename argument to 'set history filename'
 396         optional.
 397
 398 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
 399
 400         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
 401         (arm_supply_vfpregset): ...this, and update to use VFP registers.
 402         (fetch_fp_register): Update.
 403         (fetch_fp_regs): Update.
 404         (store_fp_register): Update.
 405         (store_fp_regs): Update.
 406         (arm_netbsd_nat_target::read_description): New function.
 407         (fetch_elfcore_registers): Update.
 408
 409 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 410
 411         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
 412         general_thread if the stop reply is missing a thread-id.
 413         (remote_target::process_stop_reply): Use the first non-exited
 414         thread if the target didn't pass a thread-id.
 415         * infrun.c (do_target_wait): Move call to
 416         switch_to_inferior_no_thread to ....
 417         (do_target_wait_1): ... here.
 418
 419 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
 420
 421         * debuginfod-support.c: Include defs.h first.
 422
 423 2020-02-28  Tom de Vries  <tdevries@suse.de>
 424
 425         * symfile.c (set_initial_language): Use default language for lookup.
 426
 427 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
 428
 429         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
 430         reader variable, pass `this` to read_cutu_die_from_dwo.
 431
 432 2020-02-27  Aaron Merey  <amerey@redhat.com>
 433
 434         * source.c (open_source_file): Check for nullptr when computing
 435         srcpath.
 436
 437 2020-02-27  Tom Tromey  <tromey@adacore.com>
 438
 439         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
 440         member.
 441         (dwarf2_add_field): Don't update nfields.
 442         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
 443
 444 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
 447         abs.
 448
 449 2020-02-26  Tom Tromey  <tom@tromey.com>
 450
 451         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
 452         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
 453         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
 454         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
 455         per_cu_data.
 456
 457 2020-02-26  Tom Tromey  <tom@tromey.com>
 458
 459         * dwarf2/index-write.c (psym_index_map): Change type.
 460         (add_address_entry_worker, write_one_signatured_type)
 461         (recursively_count_psymbols, recursively_write_psymbols)
 462         (class debug_names, psyms_seen_size, write_gdbindex)
 463         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
 464
 465 2020-02-26  Aaron Merey  <amerey@redhat.com>
 466
 467         * Makefile.in: Handle optional debuginfod support.
 468         * NEWS: Update.
 469         * README: Add --with-debuginfod summary.
 470         * config.in: Regenerate.
 471         * configure: Regenerate.
 472         * configure.ac: Handle optional debuginfod support.
 473         * debuginfod-support.c: debuginfod helper functions.
 474         * debuginfod-support.h: Ditto.
 475         * doc/gdb.texinfo: Add --with-debuginfod to configure options
 476         summary.
 477         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
 478         when a dwz file cannot be found.
 479         * elfread.c (elf_symfile_read): Query debuginfod servers when a
 480         debuginfo file cannot be found.
 481         * source.c (open_source_file): Query debuginfod servers when a
 482         source file cannot be found.
 483         * top.c (print_gdb_configuration): Include
 484         --{with,without}-debuginfod in the output.
 485
 486 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
 487
 488         * thread.c (thr_try_catch_cmd): Print thread name.
 489
 490 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
 491
 492         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
 493         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 494         dwarf2_fetch_die_type_sect_off): Move to...
 495         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
 496         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 497         dwarf2_fetch_die_type_sect_off): ... here.
 498         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
 499         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
 500         dwarf2_fetch_die_type_sect_off): Move doc to header file.
 501
 502 2020-02-26  Tom de Vries  <tdevries@suse.de>
 503
 504         PR gdb/25603
 505         * symfile.c (set_initial_language): Exit-early if
 506         language_mode == language_mode_manual.
 507
 508 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 509
 510         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
 511         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
 512         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
 513
 514 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 515
 516         * gdbtypes.c (create_array_type_with_stride): Handle negative
 517         array strides.
 518         * valarith.c (value_subscripted_rvalue): Likewise.
 519
 520 2020-02-25  Luis Machado  <luis.machado@linaro.org>
 521
 522         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
 523
 524 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
 525
 526         * loc.h (dwarf2_get_die_type): Move to...
 527         * read.h (dwarf2_get_die_type): ... here.
 528         * read.c (dwarf2_get_die_type): Move doc to header.
 529
 530 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
 531
 532         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
 533         'gnulib/Makefile.in' to the list.
 534
 535 2020-02-24  Tom Tromey  <tom@tromey.com>
 536
 537         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
 538         Remove.
 539         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
 540         XOBNEWVEC.
 541
 542 2020-02-24  Tom Tromey  <tom@tromey.com>
 543
 544         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
 545         New method.
 546         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
 547         (dw2_do_instantiate_symtab, dw2_get_file_names)
 548         (build_type_psymtab_dependencies, load_full_type_unit): Update.
 549
 550 2020-02-24  Tom Tromey  <tom@tromey.com>
 551
 552         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
 553         make_scoped_restore.
 554         (dwarf2_psymtab::read_symtab): Don't clear
 555         reading_partial_symbols.
 556
 557 2020-02-24  Tom de Vries  <tdevries@suse.de>
 558
 559         PR gdb/25592
 560         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
 561
 562 2020-02-24  Tom de Vries  <tdevries@suse.de>
 563
 564         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
 565         commands layout next/prev/regs.
 566
 567 2020-02-22  Tom Tromey  <tom@tromey.com>
 568
 569         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
 570         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
 571
 572 2020-02-22  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
 575
 576 2020-02-22  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-win.c (_initialize_tui_win): Add usage text.
 579         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
 580         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
 581         * tui/tui.c (_initialize_tui): Add usage text.
 582
 583 2020-02-22  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-win.c (tui_set_focus_command)
 586         (tui_set_win_height_command): Use error_no_arg.
 587         (_initialize_tui_win): Update help text.
 588         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
 589
 590 2020-02-22  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
 593         * tui/tui-disasm.h (struct tui_disasm_window)
 594         <display_start_addr>: Declare.
 595         * tui/tui-source.h (struct tui_source_window)
 596         <display_start_addr>: Declare.
 597         * tui/tui-winsource.h (struct tui_source_window_base)
 598         <show_source_line, display_start_addr>: New methods.
 599         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
 600         Rename and move to protected section.
 601         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 602         (tui_source_window_base::do_erase_source_content): Update.
 603         (tui_source_window_base::show_source_line): Now a method.
 604         (tui_source_window_base::show_source_content)
 605         (tui_source_window_base::tui_source_window_base)
 606         (tui_source_window_base::rerender)
 607         (tui_source_window_base::refill)
 608         (tui_source_window_base::do_scroll_horizontal)
 609         (tui_source_window_base::set_is_exec_point_at)
 610         (tui_source_window_base::update_breakpoint_info)
 611         (tui_source_window_base::update_exec_info): Update.
 612         * tui/tui-source.c (tui_source_window::set_contents)
 613         (tui_source_window::showing_source_p)
 614         (tui_source_window::do_scroll_vertical)
 615         (tui_source_window::location_matches_p)
 616         (tui_source_window::line_is_displayed): Update.
 617         (tui_source_window::display_start_addr): New method.
 618         * tui/tui-disasm.c (tui_disasm_window::set_contents)
 619         (tui_disasm_window::do_scroll_vertical)
 620         (tui_disasm_window::location_matches_p): Update.
 621         (tui_disasm_window::display_start_addr): New method.
 622
 623 2020-02-22  Tom Tromey  <tom@tromey.com>
 624
 625         * NEWS: Add entry for gdb.register_window_type.
 626         * tui/tui-layout.h (window_factory): New typedef.
 627         (tui_register_window): Declare.
 628         * tui/tui-layout.c (saved_tui_windows): New global.
 629         (tui_apply_current_layout): Use it.
 630         (tui_register_window): New function.
 631         * python/python.c (do_start_initialization): Call
 632         gdbpy_initialize_tui.
 633         (python_GdbMethods): Add "register_window_type" function.
 634         * python/python-internal.h (gdbpy_register_tui_window)
 635         (gdbpy_initialize_tui): Declare.
 636         * python/py-tui.c: New file.
 637         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
 638
 639 2020-02-22  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
 642
 643 2020-02-22  Tom Tromey  <tom@tromey.com>
 644
 645         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
 646         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
 647         * tui/tui-data.c (tui_set_win_with_focus): Remove.
 648         (tui_set_win_focus_to): Move from tui-win.c.
 649
 650 2020-02-22  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-layout.c (make_standard_window, get_locator_window): New
 653         functions.
 654         (known_window_types): New global.
 655         (tui_get_window_by_name): Reimplement.
 656         (initialize_known_windows): New function.
 657         (validate_window_name): Rewrite.
 658         (_initialize_tui_layout): Call initialize_known_windows.
 659
 660 2020-02-22  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
 663         Remove constants.
 664         * tui/tui-winsource.h (struct tui_source_window_base)
 665         <tui_source_window_base>: Remove parameter.
 666         * tui/tui-winsource.c
 667         (tui_source_window_base::tui_source_window_base): Remove
 668         parameter.
 669         (tui_source_window_base::refill): Update.
 670         * tui/tui-stack.h (struct tui_locator_window)
 671         <tui_locator_window>: Update.
 672         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
 673         Default the constructor.
 674         * tui/tui-regs.h (struct tui_data_item_window)
 675         <tui_data_item_window>: Default the constructor.
 676         (struct tui_data_window) <tui_data_window>: Likewise.
 677         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
 678         Default the constructor.
 679         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
 680         Default the constructor.
 681         <type>: Remove.
 682         (struct tui_win_info) <tui_win_info>: Default the constructor.
 683         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
 684         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 685         Default the constructor.
 686
 687 2020-02-22  Tom Tromey  <tom@tromey.com>
 688
 689         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
 690         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
 691         * tui/tui-win.c (tui_resize_all): Don't call
 692         tui_delete_invisible_windows.
 693         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
 694         done.
 695         (tui_set_layout): Update.
 696         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
 697         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
 698         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
 699
 700 2020-02-22  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
 703         correctly.
 704
 705 2020-02-22  Tom Tromey  <tom@tromey.com>
 706
 707         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
 708
 709 2020-02-22  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-winsource.h (struct tui_source_window_iterator)
 712         <inner_iterator>: New etytypedef.
 713         <tui_source_window_iterator>: Take "end" parameter.
 714         <tui_source_window_iterator>: Take iterator.
 715         <operator*, advance>: Update.
 716         <m_iter>: Change type.
 717         <m_end>: New field.
 718         (struct tui_source_windows) <begin, end>: Update.
 719         * tui/tui-layout.c (tui_windows): New global.
 720         (tui_apply_current_layout): Clear tui_windows.
 721         (tui_layout_window::apply): Update tui_windows.
 722         * tui/tui-data.h (tui_windows): Declare.
 723         (all_tui_windows): Now inline function.
 724         (class tui_window_iterator, struct all_tui_windows): Remove.
 725
 726 2020-02-22  Tom Tromey  <tom@tromey.com>
 727
 728         PR tui/17850:
 729         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
 730         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
 731         "height" argument.
 732         (class tui_layout_window) <get_sizes>: Likewise.
 733         (class tui_layout_split) <tui_layout_split>: Add "vertical"
 734         argument.
 735         <get_sizes>: Add "height" argument.
 736         <m_vertical>: New field.
 737         * tui/tui-layout.c (tui_layout_split::clone): Update.
 738         (tui_layout_split::get_sizes): Add "height" argument.
 739         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
 740         (tui_new_layout_command): Parse "-horizontal".
 741         (_initialize_tui_layout): Update help string.
 742         (tui_layout_split::specification): Add "-horizontal" when needed.
 743         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
 744         argument.
 745         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
 746         New methods.
 747
 748 2020-02-22  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-layout.h (enum tui_adjust_result): New.
 751         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
 752         (class tui_layout_window) <adjust_size>: Return
 753         tui_adjust_result.  Rewrite.
 754         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
 755         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
 756
 757 2020-02-22  Tom Tromey  <tom@tromey.com>
 758
 759         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
 760         parameter and return types.
 761         (class tui_layout_base) <specification>: Add "depth".
 762         (class tui_layout_window) <specification>: Add "depth".
 763         (class tui_layout_split) <specification>: Add "depth".
 764         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
 765         and return types.
 766         (tui_new_layout_command): Parse sub-layouts.
 767         (_initialize_tui_layout): Update help string.
 768         (tui_layout_window::specification): Add "depth".
 769         (add_layout_command): Update.
 770
 771 2020-02-22  Tom Tromey  <tom@tromey.com>
 772
 773         * NEWS: Add "tui new-layout" item.
 774         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
 775         Add new-layout command to help text.
 776         (validate_window_name): New function.
 777         (tui_new_layout_command): New function.
 778         (_initialize_tui_layout): Register "new-layout".
 779         (tui_layout_window::specification): New method.
 780         (tui_layout_window::specification): New method.
 781         * tui/tui-layout.h (class tui_layout_base) <specification>: New
 782         method.
 783         (class tui_layout_window) <specification>: New method.
 784         (class tui_layout_split) <specification>: New method.
 785
 786 2020-02-22  Tom Tromey  <tom@tromey.com>
 787
 788         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
 789         * tui/tui-win.c (window_name_completer): Update comment.
 790         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
 791         Declare method.
 792         (class tui_layout_window) <replace_window>: Likewise.
 793         (class tui_layout_split) <replace_window>: Likewise.
 794         (tui_set_layout): Don't declare.
 795         (tui_set_initial_layout): Declare function.
 796         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
 797         (asm_regs_layout): New globals.
 798         (tui_current_layout, show_layout): Remove.
 799         (tui_set_layout, tui_add_win_to_layout): Rewrite.
 800         (find_layout, tui_apply_layout): New function.
 801         (layout_completer): Remove.
 802         (tui_next_layout): Reimplement.
 803         (tui_next_layout_command): New function.
 804         (tui_set_initial_layout, tui_prev_layout_command): New functions.
 805         (tui_regs_layout): Reimplement.
 806         (tui_regs_layout_command): New function.
 807         (extract_display_start_addr): Rewrite.
 808         (next_layout, prev_layout): Remove.
 809         (tui_layout_window::replace_window): New method.
 810         (tui_layout_split::replace_window): New method.
 811         (destroy_layout): New function.
 812         (layout_list): New global.
 813         (add_layout_command): New function.
 814         (initialize_layouts): Update.
 815         (tui_layout_command): New function.
 816         (_initialize_tui_layout): Install "layout" commands.
 817         * tui/tui-data.h (enum tui_layout_type): Remove.
 818         (tui_current_layout): Don't declare.
 819
 820 2020-02-22  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-regs.c (tui_reg_layout): Remove.
 823         (tui_reg_command): Use tui_regs_layout.
 824         * tui/tui-layout.h (tui_reg_command): Declare.
 825         * tui/tui-layout.c (tui_reg_command): New function.
 826
 827 2020-02-22  Tom Tromey  <tom@tromey.com>
 828
 829         * tui/tui.c (tui_rl_delete_other_windows): Call
 830         tui_remove_some_windows.
 831         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
 832         Declare method.
 833         (class tui_layout_window) <remove_windows>: New method.
 834         (class tui_layout_split) <remove_windows>: Declare.
 835         (tui_remove_some_windows): Declare.
 836         * tui/tui-layout.c (tui_remove_some_windows): New function.
 837         (tui_layout_split::remove_windows): New method.
 838
 839 2020-02-22  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
 842         * tui/tui-layout.h (tui_next_layout): Declare.
 843         * tui/tui-layout.c (tui_next_layout): New function.
 844
 845 2020-02-22  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
 848         correct coordinates.
 849
 850 2020-02-22  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
 853         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
 854         DATA_WIN case.
 855
 856 2020-02-22  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
 859         TUI_DISASM_WIN, not tui_win_list.
 860
 861 2020-02-22  Tom Tromey  <tom@tromey.com>
 862
 863         * valprint.c (generic_val_print_enum_1)
 864         (val_print_type_code_flags): Style member names.
 865         * rust-lang.c (val_print_struct, rust_print_enum)
 866         (rust_print_struct_def, rust_internal_print_type): Style member
 867         names.
 868         * p-valprint.c (pascal_object_print_value_fields): Style member
 869         names.  Only call fprintf_symbol_filtered for static members.
 870         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
 871         * f-valprint.c (f_val_print): Style member names.
 872         * f-typeprint.c (f_type_print_base): Style member names.
 873         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
 874         call fprintf_symbol_filtered for static members.
 875         (cp_print_class_member): Style member names.
 876         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
 877         member names.
 878         * ada-valprint.c (ada_print_scalar): Style enum names.
 879         (ada_val_print_enum): Likewise.
 880         * ada-typeprint.c (print_enum_type): Style enum names.
 881
 882 2020-02-21  Tom Tromey  <tom@tromey.com>
 883
 884         * psympriv.h (struct partial_symtab): Update comment.
 885
 886 2020-02-21  Tom Tromey  <tromey@adacore.com>
 887
 888         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
 889         type is CORE_ADDR.
 890
 891 2020-02-21  Tom de Vries  <tdevries@suse.de>
 892
 893         PR gdb/25534
 894         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
 895         if dependencies[i]->user != NULL.
 896
 897 2020-02-21  Ali Tamur  <tamur@google.com>
 898
 899         * dwarf2/read.c (dwarf2_name): Add null check.
 900
 901 2020-02-20  Tom Tromey  <tom@tromey.com>
 902
 903         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
 904         ">=", in binary search.
 905         (dwarf2_find_containing_comp_unit): New overload.
 906         (run_test): New self-test.
 907         (_initialize_dwarf2_read): Register new test.
 908
 909 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
 910
 911         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
 912         * riscv-tdep.h: Likewise.
 913         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
 914         rv32-only CSR.
 915         * features/riscv/64bit-csr.xml: Regenerated.
 916
 917 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
 918             Tom Tromey  <tom@tromey.com>
 919
 920         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
 921         of 'fputc_unfiltered'.
 922         (putchar_unfiltered): Call 'fputc_unfiltered'.
 923         (fputc_unfiltered): Call 'fputs_unfiltered'.
 924
 925 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * config.in: Regenerate.
 928         * configure: Regenerate.
 929         * configure.ac: Add --with-python-libdir option.
 930         * main.c: Use WITH_PYTHON_LIBDIR.
 931
 932 2020-02-19  Tom Tromey  <tom@tromey.com>
 933
 934         * symtab.c (general_symbol_info::compute_and_set_names): Use
 935         obstack_strndup.  Simplify call to symbol_set_demangled_name.
 936
 937 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
 938
 939         * dwarf2/read.c (allocate_signatured_type_table,
 940         allocate_dwo_unit_table, allocate_type_unit_groups_table,
 941         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
 942         Remove objfile parameter, update all callers.
 943
 944 2020-02-19  Doug Evans  <dje@google.com>
 945
 946         PR rust/25535
 947         * rust-lang.c (rust_print_enum): Apply embedded_offset to
 948         rust_enum_variant calculation.
 949
 950 2020-02-19  Tom Tromey  <tromey@adacore.com>
 951
 952         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
 953
 954 2020-02-19  Tom Tromey  <tromey@adacore.com>
 955
 956         * ada-lang.c (cache_symbol): Use obstack_strdup.
 957
 958 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * configure: Regenerate.
 961
 962 2020-02-19  Tom Tromey  <tromey@adacore.com>
 963
 964         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
 965         NULL check.
 966
 967 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
 968
 969         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
 970
 971 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 972
 973         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
 974         if GDBSERVER is not defined.
 975         (riscv_tdesc_cache): Likewise, also store const target_desc.
 976         (STATIC_IN_GDB): Define.
 977         (riscv_create_target_description): Update declaration with
 978         STATIC_IN_GDB.
 979         (riscv_lookup_target_description): New function, only define if
 980         GDBSERVER is not defined.
 981         * arch/riscv.h (riscv_create_target_description): Declare only
 982         when GDBSERVER is defined.
 983         (riscv_lookup_target_description): New declaration when GDBSERVER
 984         is not defined.
 985         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
 986         (riscv_linux_read_features): ...this, and return
 987         riscv_gdbarch_features instead of target_desc.
 988         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
 989         (riscv_linux_read_description): Rename to...
 990         (riscv_linux_read_features): ...this.
 991         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 992         Update to use riscv_gdbarch_features and
 993         riscv_lookup_target_description.
 994         * riscv-tdep.c (riscv_find_default_target_description): Use
 995         riscv_lookup_target_description instead of
 996         riscv_create_target_description.
 997
 998 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 999
1000         * valprint.c (generic_val_print_enum_1): When printing a flag
1001         enum with value 0 and there is no enumerator with value 0, print
1002         just "0" instead of "(unknown: 0x0)".
1003
1004 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1005
1006         * valprint.c (generic_val_print_enum_1): Print unknown part of
1007         flag enum in hex.
1008
1009 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1010
1011         * dwarf2/read.c (update_enumeration_type_from_children): Allow
1012         flag enums to contain duplicate enumerators.
1013         * valprint.c (generic_val_print_enum_1): Update comment.
1014
1015 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1016
1017         * dwarf2/read.c: Include "count-one-bits.h".
1018         (update_enumeration_type_from_children): If an enumerator has
1019         multiple bits set, don't treat the enumeration as a "flag enum".
1020         * valprint.c (generic_val_print_enum_1): Assert that enumerators
1021         of flag enums have 0 or 1 bit set.
1022
1023 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1024
1025         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
1026         conversion.
1027         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1028         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1029         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1030         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1031         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1032
1033 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
1034
1035         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
1036
1037 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1038
1039         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
1040         displaced_step_closure_up.
1041         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1042         (struct displaced_step_closure_up):
1043         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1044         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1045         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
1046         Likewise.
1047         * gdbarch.sh (displaced_step_copy_insn): Likewise.
1048         * gdbarch.c, gdbarch.h: Re-generate.
1049         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
1050         displaced_step_closure_up.
1051         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1052         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1053         * infrun.h (displaced_step_closure_up): New type alias.
1054         (struct displaced_step_inferior_state) <step_closure>: Change
1055         type to displaced_step_closure_up.
1056         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
1057         displaced_step_closure_up.
1058         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1059
1060 2020-02-14  Tom Tromey  <tom@tromey.com>
1061
1062         * minidebug.c (gnu_debug_key): New global.
1063         (find_separate_debug_file_in_section): Use it.
1064
1065 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1066
1067         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
1068         std::unique_ptr.
1069         * gdbarch.c: Re-generate.
1070         * gdbarch.h: Re-generate.
1071         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
1072         change.
1073         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
1074         type to std::unique_ptr.
1075         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
1076         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
1077         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
1078         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
1079         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
1080         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
1081         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
1082         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
1083         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
1084
1085 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1086
1087         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
1088         std::unique_ptr.
1089         (displaced_step_clear): Rename to...
1090         (displaced_step_reset): ... this.  Just call displaced->reset ().
1091         (displaced_step_clear_cleanup): Rename to...
1092         (displaced_step_reset_cleanup): ... this.
1093         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
1094         (displaced_step_fixup): Likewise.
1095         (resume_1): Likewise.
1096         (handle_inferior_event): Restore child's memory before calling
1097         displaced_step_fixup on the parent.
1098         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
1099         to std::unique_ptr.
1100         <step_closure>: Change type to std::unique_ptr.
1101
1102 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
1103
1104         * arm-tdep.c: Include count-one-bits.h.
1105         (cleanup_block_store_pc): Use count_one_bits.
1106         (cleanup_block_load_pc): Use count_one_bits.
1107         (arm_copy_block_xfer): Use count_one_bits.
1108         (thumb2_copy_block_xfer): Use count_one_bits.
1109         (thumb_copy_pop_pc_16bit): Use count_one_bits.
1110         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
1111         (thumb_get_next_pcs_raw): Use count_one_bits.
1112         (arm_get_next_pcs_raw): Use count_one_bits_l.
1113         * arch/arm.c (bitcount): Remove.
1114         * arch/arm.h (bitcount): Remove.
1115
1116 2020-02-14  Tom Tromey  <tromey@adacore.com>
1117
1118         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
1119         Update.
1120         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
1121         * dwarf2/loc.c (call_site_find_chain_1): Return
1122         unique_xmalloc_ptr.
1123         (call_site_find_chain): Likewise.
1124
1125 2020-02-14  Richard Biener  <rguenther@suse.de>
1126
1127         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
1128         on expression with division operators.
1129
1130 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1131
1132         * MAINTAINERS (Write After Approval): Adding myself.
1133
1134 2020-02-12  Tom Tromey  <tom@tromey.com>
1135
1136         * event-loop.c (event_data, gdb_event, event_handler_func):
1137         Remove.
1138
1139 2020-02-12  Tom Tromey  <tom@tromey.com>
1140
1141         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
1142         (dwarf2_frame_objfile_data): Add comment.
1143         (find_comp_unit, set_comp_unit): New functions.
1144         (dwarf2_frame_find_fde): Use find_comp_unit.
1145         (dwarf2_build_frame_info): Use set_comp_unit.
1146
1147 2020-02-12  Tom Tromey  <tom@tromey.com>
1148
1149         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
1150         (comp_unit): Don't initialize objfile.
1151         (execute_cfa_program): Add text_offset parameter.
1152         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
1153         (dwarf2_frame_cache): Update.
1154         (dwarf2_build_frame_info): Don't set "objfile" member.
1155
1156 2020-02-12  Tom Tromey  <tom@tromey.com>
1157
1158         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
1159         (decode_frame_entry): Likewise.
1160         (dwarf2_build_frame_info): Update.
1161
1162 2020-02-12  Tom Tromey  <tom@tromey.com>
1163
1164         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
1165         (decode_frame_entry_1): Use the comp_unit obstack.
1166
1167 2020-02-12  Tom Tromey  <tom@tromey.com>
1168
1169         * dwarf2/frame.c (struct comp_unit): Add initializers and
1170         constructor.
1171         (dwarf2_frame_objfile_data): Store a comp_unit.
1172         (dwarf2_frame_find_fde): Update.
1173         (dwarf2_build_frame_info): Use "new".
1174
1175 2020-02-12  Tom Tromey  <tom@tromey.com>
1176
1177         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
1178         (dwarf2_fde_table): Typedef for std::vector.
1179         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
1180         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
1181         (decode_frame_entry): Update.
1182         (dwarf2_build_frame_info): Use "new".
1183
1184 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1185
1186         * arm-tdep.c (arm_gdbarch_init): Update.
1187         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
1188         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
1189         have_neon, is_m>: Change to bool.
1190
1191 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
1192
1193         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
1194
1195 2020-02-12  Tom Tromey  <tom@tromey.com>
1196
1197         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
1198
1199 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
1200
1201         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
1202         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
1203
1204 2020-02-11  Tom Tromey  <tom@tromey.com>
1205
1206         * psymtab.h: Update comment.
1207
1208 2020-02-11  Tom Tromey  <tom@tromey.com>
1209
1210         * gdb_obstack.h (struct auto_obstack): Use
1211         DISABLE_COPY_AND_ASSIGN.
1212
1213 2020-02-11  Tom Tromey  <tom@tromey.com>
1214
1215         * dwarf2/frame.h (struct objfile): Don't forward declare.
1216
1217 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1218
1219         * cris-tdep.c (cris_supply_gregset): Change signature to match
1220         what struct regset expects.
1221         (cris_regset): New struct.
1222         (fetch_core_registers): Remove.
1223         (cris_iterate_over_regset_sections): New function.
1224         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
1225         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
1226
1227 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1228
1229         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
1230         registers.
1231
1232 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
1233
1234         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
1235
1236 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1237
1238         * configure: Re-generate.
1239
1240 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1241
1242         * configure: Re-generate.
1243
1244 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
1245
1246         * acinclude: Update warning.m4 path.
1247         * warning.m4: Move to gdbsupport.
1248
1249 2020-02-11  Tom Tromey  <tromey@adacore.com>
1250
1251         * remote.c (remote_console_output): Update.
1252         * printcmd.c (printf_command): Update.
1253         * event-loop.c (gdb_wait_for_event): Update.
1254         * linux-nat.c (sigchld_handler): Update.
1255         * remote-sim.c (gdb_os_write_stdout): Update.
1256         (gdb_os_flush_stdout): Update.
1257         (gdb_os_flush_stderr): Update.
1258         (gdb_os_write_stderr): Update.
1259         * exceptions.c (print_exception): Update.
1260         * remote-fileio.c (remote_fileio_func_read): Update.
1261         (remote_fileio_func_write): Update.
1262         * tui/tui.c (tui_enable): Update.
1263         * tui/tui-interp.c (tui_interp::init): Update.
1264         * utils.c (init_page_info): Update.
1265         (putchar_unfiltered, fputc_unfiltered): Update.
1266         (gdb_flush): Update.
1267         (emit_style_escape): Update.
1268         (flush_wrap_buffer, fputs_maybe_filtered): Update.
1269         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
1270         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
1271         (stderr_file::write): Update.
1272         (stderr_file::puts): Update.
1273         * ui-file.h (ui_file_isatty, ui_file_write)
1274         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
1275         (ui_file_puts): Don't declare.
1276
1277 2020-02-10  Tom de Vries  <tdevries@suse.de>
1278
1279         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
1280         sentinel to char *.
1281
1282 2020-02-09  Tom de Vries  <tdevries@suse.de>
1283
1284         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
1285         filename if it matches "<artificial>".
1286
1287 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1288
1289         * windows-tdep.c (struct enum_value_name): New struct.
1290         (create_enum): New function.
1291         (windows_get_siginfo_type): Create and use enum types.
1292
1293 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
1294
1295         * NEWS: Mention $_siginfo support for Windows.
1296         * windows-nat.c (handle_exception): Set siginfo_er.
1297         (windows_nat_target::mourn_inferior): Reset siginfo_er.
1298         (windows_xfer_siginfo): New function.
1299         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
1300         * windows-tdep.c (struct windows_gdbarch_data): New struct.
1301         (init_windows_gdbarch_data): New function.
1302         (get_windows_gdbarch_data): New function.
1303         (windows_get_siginfo_type): New function.
1304         (windows_init_abi): Register windows_get_siginfo_type.
1305         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
1306
1307 2020-02-08  Tom Tromey  <tom@tromey.com>
1308
1309         * dwarf2/read.c (class cutu_reader) <cutu_reader,
1310         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
1311         <keep>: Declare method.
1312         <m_keep>: Remove member.
1313         <~cutu_reader>: Remove.
1314         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1315         (cutu_reader::cutu_reader): Update.
1316         (cutu_reader::keep): Rename from ~cutu_reader.
1317         (process_psymtab_comp_unit, build_type_psymtabs_1)
1318         (process_skeletonless_type_unit, load_partial_comp_unit)
1319         (load_full_comp_unit, dwarf2_read_addr_index)
1320         (read_signatured_type): Update.
1321
1322 2020-02-08  Tom Tromey  <tom@tromey.com>
1323
1324         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
1325         "want_partial_unit" parameter.
1326         (process_psymtab_comp_unit): Change want_partial_unit to bool.
1327         Inline check for DW_TAG_partial_unit.
1328         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
1329
1330 2020-02-08  Tom Tromey  <tom@tromey.com>
1331
1332         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
1333         read.c.
1334         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
1335         read.c.
1336
1337 2020-02-08  Tom Tromey  <tom@tromey.com>
1338
1339         * dwarf2/read.c (read_address): Move to comp-unit.c.
1340         (dwarf2_rnglists_process, dwarf2_ranges_process)
1341         (read_attribute_value, dwarf_decode_lines_1)
1342         (var_decode_location, decode_locdesc): Update.
1343         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
1344         read.c.  Remove "cu" parameter.
1345         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
1346         method.
1347
1348 2020-02-08  Tom Tromey  <tom@tromey.com>
1349
1350         * dwarf2/read.c (read_attribute_value, read_indirect_string)
1351         (read_indirect_line_string): Update.
1352         * dwarf2/comp-unit.c (read_offset): Remove.
1353         (read_comp_unit_head): Update.
1354         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
1355         method.
1356         (read_offset): Don't declare.
1357
1358 2020-02-08  Tom Tromey  <tom@tromey.com>
1359
1360         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
1361         * dwarf2/read.c (struct comp_unit_head): Move to
1362         dwarf2/comp-unit.h.
1363         (enum class rcuh_kind): Move to comp-unit.h.
1364         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
1365         (read_comp_unit_head, error_check_comp_unit_head)
1366         (read_and_check_comp_unit_head): Move to comp-unit.c.
1367         (read_offset, dwarf_unit_type_name): Likewise.
1368         (create_debug_type_hash_table, read_cutu_die_from_dwo)
1369         (cutu_reader::cutu_reader, read_call_site_scope)
1370         (find_partial_die, follow_die_offset): Update.
1371         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
1372
1373 2020-02-08  Tom Tromey  <tom@tromey.com>
1374
1375         * dwarf2/read.c (read_offset_1): Move to leb.c.
1376         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
1377         (dwarf_decode_macro_bytes): Update.
1378         * dwarf2/leb.c (read_offset): Rename; move from read.c.
1379         * dwarf2/leb.h (read_offset): Declare.
1380
1381 2020-02-08  Tom Tromey  <tom@tromey.com>
1382
1383         * dwarf2/read.c (dwarf2_section_size): Remove.
1384         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
1385         Update.
1386         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
1387
1388 2020-02-08  Tom Tromey  <tom@tromey.com>
1389
1390         * dwarf2/read.c (read_initial_length): Move to leb.c.
1391         * dwarf2/leb.h (read_initial_length): Declare.
1392         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
1393         handle_nonstd parameter.
1394         * dwarf2/frame.c (read_initial_length): Remove.
1395         (decode_frame_entry_1): Update.
1396
1397 2020-02-08  Tom Tromey  <tom@tromey.com>
1398
1399         * dwarf2/loc.c (dwarf2_find_location_expression)
1400         (dwarf_evaluate_loc_desc::get_tls_address)
1401         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
1402         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
1403         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
1404         (dwarf2_compile_property_to_c)
1405         (dwarf2_loc_desc_get_symbol_read_needs)
1406         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
1407         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
1408         (loclist_describe_location, loclist_tracepoint_var_ref)
1409         (loclist_generate_c_location): Update.
1410         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1411         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
1412         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
1413         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
1414         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
1415         (dwarf2_per_cu_data::addr_size)
1416         (dwarf2_per_cu_data::ref_addr_size)
1417         (dwarf2_per_cu_data::text_offset)
1418         (dwarf2_per_cu_data::addr_type): Now methods.
1419         (per_cu_header_read_in): Make per_cu "const".
1420         (dwarf2_version): Remove.
1421         (dwarf2_per_cu_data::int_type): Now a method.
1422         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
1423         (set_die_type, read_array_type, read_subrange_index_type)
1424         (read_tag_string_type, read_subrange_type): Update.
1425         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
1426         offset_size, ref_addr_size, text_offset, addr_type, version,
1427         objfile, int_type, addr_sized_int_type>: Declare methods.
1428
1429 2020-02-08  Tom Tromey  <tom@tromey.com>
1430
1431         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
1432         Move earlier.
1433
1434 2020-02-08  Tom Tromey  <tom@tromey.com>
1435
1436         * dwarf2/read.h (dwarf_line_debug): Declare.
1437         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
1438         * dwarf2/read.c: Move line_header code to new files.
1439         (dwarf_line_debug): No longer static.
1440         * dwarf2/line-header.c: New file.
1441         * dwarf2/line-header.h: New file.
1442
1443 2020-02-08  Tom Tromey  <tom@tromey.com>
1444
1445         * dwarf2/read.c (struct line_header) <file_full_name,
1446         file_file_name>: Return unique_xmalloc_ptr.
1447         (line_header::file_file_name): Update.
1448         (line_header::file_full_name): Update.
1449         (dw2_get_file_names_reader): Update.
1450         (macro_start_file): Update.
1451
1452 2020-02-08  Tom Tromey  <tom@tromey.com>
1453
1454         * dwarf2/read.c (struct line_header) <file_full_name,
1455         file_file_name>: Declare methods.
1456         (dw2_get_file_names_reader): Update.
1457         (file_file_name): Now a method.
1458         (file_full_name): Likewise.
1459         (macro_start_file): Update.
1460
1461 2020-02-08  Tom Tromey  <tom@tromey.com>
1462
1463         * dwarf2/read.c (dwarf_always_disassemble)
1464         (show_dwarf_always_disassemble): Move to loc.c.
1465         (_initialize_dwarf2_read): Move "always-disassemble" registration
1466         to loc.c.
1467         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
1468         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
1469         static.
1470         (show_dwarf_always_disassemble): Move from read.c.
1471         (_initialize_dwarf2loc): Move always-disassemble from read.c.
1472
1473 2020-02-08  Tom Tromey  <tom@tromey.com>
1474
1475         * dwarf2/read.c (~dwarf2_per_objfile): Update.
1476         (create_quick_file_names_table): Return htab_up.
1477         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
1478         Update.
1479         * dwarf2/read.h (struct dwarf2_per_objfile)
1480         <quick_file_names_table>: Now htab_up.
1481
1482 2020-02-08  Tom Tromey  <tom@tromey.com>
1483
1484         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
1485
1486 2020-02-08  Tom Tromey  <tom@tromey.com>
1487
1488         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
1489         Rewrite.
1490         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
1491         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
1492         (abbrev_table::abbrev_table): No longer inline.
1493         (ABBREV_HASH_SIZE): Remove.
1494         (abbrev_table::m_abbrevs): Now an htab_up.
1495
1496 2020-02-08  Tom Tromey  <tom@tromey.com>
1497
1498         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
1499         (cutu_reader): Update.
1500         (build_type_psymtabs_1): Update.
1501         * dwarf2/abbrev.c (abbrev_table::read): Rename.
1502         (abbrev_table::alloc_abbrev): Update.
1503         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
1504         (abbrev_table::read): New static method, renamed from
1505         abbrev_table_read_table.
1506         (abbrev_table::alloc_abbrev)
1507         (abbrev_table::add_abbrev): Now private.
1508         (abbrev_table::abbrev_table): Now private.
1509         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
1510
1511 2020-02-08  Tom Tromey  <tom@tromey.com>
1512
1513         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
1514         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
1515         htab_up.
1516
1517 2020-02-08  Tom Tromey  <tom@tromey.com>
1518
1519         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
1520         htab_up.
1521         (lookup_dwo_unit_in_dwp): Update.
1522         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
1523         on obstack.
1524
1525 2020-02-08  Tom Tromey  <tom@tromey.com>
1526
1527         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
1528         obstack.
1529
1530 2020-02-08  Tom Tromey  <tom@tromey.com>
1531
1532         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
1533         line_header_hash.
1534         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
1535         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
1536         Change type to htab_up.
1537
1538 2020-02-08  Tom Tromey  <tom@tromey.com>
1539
1540         * dwarf2/read.c (allocate_type_unit_groups_table): Return
1541         htab_up.  Don't allocate on obstack.
1542         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
1543         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
1544         Change type to htab_up.
1545
1546 2020-02-08  Tom Tromey  <tom@tromey.com>
1547
1548         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
1549         Change type to htab_up.
1550         * dwarf2/read.c (create_signatured_type_table_from_index)
1551         (create_signatured_type_table_from_debug_names)
1552         (create_all_type_units, add_type_unit)
1553         (lookup_dwo_signatured_type, lookup_signatured_type)
1554         (process_skeletonless_type_unit): Update.
1555         (create_debug_type_hash_table, create_debug_types_hash_table):
1556         Change type of types_htab.
1557         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
1558         htab_up.  Don't allocate on obstack.
1559         (create_cus_hash_table): Change type of cus_htab parameter.
1560         (struct dwo_file) <cus, tus>: Now htab_up.
1561         (lookup_dwo_signatured_type, lookup_dwo_cutu)
1562         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
1563         (queue_and_load_all_dwo_tus): Update.
1564         * dwarf2/index-write.c (write_gdbindex): Update.
1565         (write_debug_names): Update.
1566
1567 2020-02-08  Tom Tromey  <tom@tromey.com>
1568
1569         * dwarf2/read.h (struct dwarf2_queue_item): Move from
1570         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
1571         destructor.
1572         (struct dwarf2_per_objfile) <queue>: New member.
1573         * dwarf2/read.c (struct dwarf2_queue_item): Move to
1574         dwarf2/read.h.
1575         (dwarf2_queue, dwarf2_queue_tail): Remove.
1576         (class dwarf2_queue_guard): Add parameter to constructor.  Use
1577         DISABLE_COPY_AND_ASSIGN.
1578         <m_per_objfile>: New member.
1579         <~dwarf2_queue_guard>: Rewrite.
1580         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
1581         Update.
1582         (~dwarf2_queue_item): New.
1583
1584 2020-02-08  Tom Tromey  <tom@tromey.com>
1585
1586         * dwarf2/read.c (struct die_info) <has_children>: New member.
1587         (dw2_get_file_names_reader): Remove has_children.
1588         (dw2_get_file_names): Update.
1589         (read_cutu_die_from_dwo): Remove has_children.
1590         (cutu_reader::init_tu_and_read_dwo_dies)
1591         (cutu_reader::cutu_reader): Update.
1592         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
1593         Remove has_children.
1594         (build_type_psymtabs_1, process_skeletonless_type_unit)
1595         (load_partial_comp_unit, load_full_comp_unit): Update.
1596         (create_dwo_cu_reader): Remove has_children.
1597         (create_cus_hash_table, read_die_and_children): Update.
1598         (read_full_die_1,read_full_die): Remove has_children.
1599         (read_signatured_type): Update.
1600         (class cutu_reader) <has_children>: Remove.
1601
1602 2020-02-08  Tom Tromey  <tom@tromey.com>
1603
1604         * dwarf2/expr.c: Rename from dwarf2expr.c.
1605         * dwarf2/expr.h: Rename from dwarf2expr.h.
1606         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
1607         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
1608         * dwarf2/frame.c: Rename from dwarf2-frame.c.
1609         * dwarf2/frame.h: Rename from dwarf2-frame.h.
1610         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
1611         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
1612         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
1613         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
1614         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
1615         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
1616         * dwarf2/loc.c: Rename from dwarf2loc.c.
1617         * dwarf2/loc.h: Rename from dwarf2loc.h.
1618         * dwarf2/read.c: Rename from dwarf2read.c.
1619         * dwarf2/read.h: Rename from dwarf2read.h.
1620         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
1621         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
1622         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
1623         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
1624         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
1625         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
1626         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
1627         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
1628         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
1629         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
1630         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
1631         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
1632         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
1633         Update.
1634         * Makefile.in (COMMON_SFILES): Update.
1635         (HFILES_NO_SRCDIR): Update.
1636
1637 2020-02-08  Tom Tromey  <tom@tromey.com>
1638
1639         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
1640         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
1641
1642 2020-02-08  Tom Tromey  <tom@tromey.com>
1643
1644         * dwarf2read.h (struct die_info): Don't declare.
1645
1646 2020-02-08  Tom Tromey  <tom@tromey.com>
1647
1648         * dwarf2read.h (die_info_ptr): Remove typedef.
1649
1650 2020-02-08  Tom Tromey  <tom@tromey.com>
1651
1652         * dwarf2read.c (read_call_site_scope)
1653         (handle_data_member_location, dwarf2_add_member_fn)
1654         (mark_common_block_symbol_computed, read_common_block)
1655         (attr_to_dynamic_prop, partial_die_info::read)
1656         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
1657         (dwarf2_symbol_mark_computed, set_die_type): Update.
1658         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
1659         method.
1660         (attr_form_is_block): Don't declare.
1661         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
1662
1663 2020-02-08  Tom Tromey  <tom@tromey.com>
1664
1665         * dwarf2read.c (dwarf2_find_base_address, )
1666         (read_call_site_scope, rust_containing_type)
1667         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
1668         (handle_data_member_location, dwarf2_add_member_fn)
1669         (get_alignment, read_structure_type, process_structure_scope)
1670         (mark_common_block_symbol_computed, read_common_block)
1671         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
1672         (partial_die_info::read, read_attribute_value, new_symbol)
1673         (lookup_die_type, dwarf2_get_ref_die_offset)
1674         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
1675         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
1676         (dwarf2_symbol_mark_computed): Update.
1677         * dwarf2/attribute.h (struct attribute) <value_as_address,
1678         form_is_section_offset, form_is_constant, form_is_ref>: Declare
1679         methods.
1680         (value_as_address, attr_form_is_section_offset)
1681         (attr_form_is_constant, attr_form_is_ref): Don't declare.
1682         * dwarf2/attribute.c (attribute::value_as_address)
1683         (attribute::form_is_section_offset, attribute::form_is_constant)
1684         (attribute::form_is_ref): Now methods.
1685
1686 2020-02-08  Tom Tromey  <tom@tromey.com>
1687
1688         * dwarf2read.c (struct attribute, DW_STRING)
1689         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
1690         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
1691         (attr_form_is_block, attr_form_is_section_offset)
1692         (attr_form_is_constant, attr_form_is_ref): Move.
1693         * dwarf2/attribute.h: New file.
1694         * dwarf2/attribute.c: New file, from dwarf2read.c.
1695         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
1696
1697 2020-02-08  Tom Tromey  <tom@tromey.com>
1698
1699         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
1700         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
1701         Move.
1702         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
1703         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
1704         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
1705         abbrev.c.
1706         * dwarf2/abbrev.h: New file.
1707         * dwarf2/abbrev.c: New file, from dwarf2read.c.
1708         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
1709
1710 2020-02-08  Tom Tromey  <tom@tromey.com>
1711
1712         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
1713         (dwarf2_section_size, dwarf2_get_section_info)
1714         (create_signatured_type_table_from_debug_names)
1715         (create_addrmap_from_aranges, read_debug_names_from_section)
1716         (get_gdb_index_contents_from_section, read_comp_unit_head)
1717         (error_check_comp_unit_head, read_abbrev_offset)
1718         (create_debug_type_hash_table, init_cu_die_reader)
1719         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
1720         (read_comp_units_from_section, create_cus_hash_table)
1721         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1722         (create_dwp_v2_section, dwarf2_rnglists_process)
1723         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
1724         (abbrev_table_read_table, read_indirect_string_at_offset_from)
1725         (read_indirect_string_from_dwz, read_addr_index_1)
1726         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
1727         (dwarf_decode_macro_bytes, dwarf_decode_macros)
1728         (fill_in_loclist_baton): Update.
1729         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
1730         get_containing_section, get_bfd_owner, get_bfd_section,
1731         get_file_name, get_id, get_flags, empty, read>: Declare methods.
1732         (dwarf2_read_section, get_section_name, get_section_file_name)
1733         (get_containing_section, get_section_bfd_owner)
1734         (get_section_bfd_section, get_section_name, get_section_file_name)
1735         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
1736         declare.
1737         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
1738         (dwarf2_section_info::get_bfd_owner)
1739         (dwarf2_section_info::get_bfd_section)
1740         (dwarf2_section_info::get_name)
1741         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
1742         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
1743         (dwarf2_section_info::read): Now methods.
1744         * dwarf-index-write.c (class debug_names): Update.
1745
1746 2020-02-08  Tom Tromey  <tom@tromey.com>
1747
1748         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
1749         Move to dwarf2/section.h.
1750         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
1751         (get_section_bfd_section, get_section_name)
1752         (get_section_file_name, get_section_id, get_section_flags)
1753         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
1754         dwarf2/section.c.
1755         * dwarf2/section.h: New file.
1756         * dwarf2/section.c: New file, from dwarf2read.c.
1757         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
1758
1759 2020-02-08  Tom Tromey  <tom@tromey.com>
1760
1761         * dwarf2read.h (read_unsigned_leb128): Don't declare.
1762         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
1763         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
1764         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
1765         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
1766         * dwarf2/leb.h: New file, from dwarf2read.c.
1767         * dwarf2/leb.c: New file, from dwarf2read.c.
1768         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
1769         Remove.
1770         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
1771         (COMMON_SFILES): Add dwarf2/leb.c.
1772
1773 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
1774
1775         GDB 9.1 released.
1776
1777 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1778
1779         PR gdb/25190:
1780         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
1781         * gdb/remote.c (remote_console_output): Update.
1782         * gdb/ui-file.c (fputs_unfiltered): Rename to...
1783         (ui_file_puts): ...this.
1784         * gdb/ui-file.h (ui_file_puts): Add declaration.
1785         * gdb/utils.c (emit_style_escape): Update.
1786         (flush_wrap_buffer): Update.
1787         (fputs_maybe_filtered): Update.
1788         (fputs_unfiltered): Add function.
1789
1790 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1791
1792         * gdb/event-loop.c (gdb_wait_for_event): Update.
1793         * gdb/printcmd.c (printf_command): Update.
1794         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
1795         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
1796         (gdb_os_flush_stderr): Update.
1797         * gdb/remote.c (remote_console_output): Update.
1798         * gdb/ui-file.c (gdb_flush): Rename to...
1799         (ui_file_flush): ...this.
1800         (stderr_file::write): Update.
1801         (stderr_file::puts): Update.
1802         * gdb/ui-file.h (gdb_flush): Rename to...
1803         (ui_file_flush): ...this.
1804         * gdb/utils.c (gdb_flush): Add function.
1805         * gdb/utils.h (gdb_flush): Add declaration.
1806
1807 2020-02-07  Tom Tromey  <tromey@adacore.com>
1808
1809         PR breakpoints/24915:
1810         * source.c (find_and_open_source): Do not check basenames_may_differ.
1811
1812 2020-02-07  Tom Tromey  <tom@tromey.com>
1813
1814         * README: Update gdbserver documentation.
1815         * gdbserver: Move to top level.
1816         * configure.tgt (build_gdbserver): Remove.
1817         * configure.ac: Remove --enable-gdbserver.
1818         * configure: Rebuild.
1819         * Makefile.in (distclean): Don't mention gdbserver.
1820
1821 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1822
1823         * source-cache.c (source_cache::ensure): Surround
1824         get_plain_source_lines with a try/catch.
1825         (source_cache::get_line_charpos): Get rid of try/catch
1826         and only check for the return value of "ensure".
1827         * tui/tui-source.c (tui_source_window::set_contents):
1828         Simplify "nlines" calculation.
1829
1830 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1831
1832         * MAINTAINERS (Write After Approval): Add myself.
1833
1834 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1835
1836         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
1837         function call.
1838
1839 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1840
1841         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
1842
1843 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
1844
1845         * nat/riscv-linux-tdesc.h: New file.
1846         * nat/riscv-linux-tdesc.c: New file, taking code from...
1847         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1848         ... here.
1849         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
1850         NATDEPFILES.
1851
1852 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1853
1854         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
1855         we don't set the fake simulator ptid to the null_ptid.
1856
1857 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
1858
1859         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
1860         * gdbthread.h (class thread_info) <resumed>: Likewise.
1861         * infrun.c (resume_1): Likewise.
1862         (proceed): Likewise.
1863         (infrun_thread_stop_requested): Likewise.
1864         (stop_all_threads): Likewise.
1865         (handle_inferior_event): Likewise.
1866         (restart_threads): Likewise.
1867         (finish_step_over): Likewise.
1868         (keep_going_stepped_thread): Likewise.
1869         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
1870         (linux_handle_extended_wait): Likewise.
1871         * record-btrace.c (get_thread_current_frame_id): Likewise.
1872         * record-full.c (record_full_wait_1): Likewise.
1873         * remote.c (remote_target::process_initial_stop_replies): Likewise.
1874         * target.c (target_resume): Likewise.
1875         * thread.c (set_running_thread): Likewise.
1876
1877 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1878
1879         * f-valprint.c (f77_print_array_1): Changed datatype of index
1880         variable to LONGEST from int to enable it to contain bound
1881         values correctly.
1882
1883 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
1884
1885         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
1886         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
1887         offsets according to FLEN determined.
1888         (riscv_linux_nat_target::read_description): Determine FLEN
1889         dynamically.
1890         (riscv_linux_nat_target::fetch_registers): Size regset buffer
1891         according to FLEN determined.
1892         (riscv_linux_nat_target::store_registers): Likewise.
1893
1894 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1895
1896         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1897         when reg->group is empty and reggroup is not.
1898
1899 2020-01-31  Tom Tromey  <tromey@adacore.com>
1900
1901         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
1902         Call beneath target's mourn_inferior after unpushing.
1903
1904 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1905
1906         PR tui/9765
1907         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
1908         have enough lines to fill the screen, still return the lowest
1909         address we found.
1910
1911 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1912
1913         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
1914         '-', '<', and '>' commands.
1915
1916 2020-01-29  Pedro Alves  <palves@redhat.com>
1917             Sergio Durigan Junior  <sergiodj@redhat.com>
1918
1919         * infcmd.c (construct_inferior_arguments): Assert that
1920         'argc' is greater than 0.
1921
1922 2020-01-29  Luis Machado  <luis.machado@linaro.org>
1923
1924         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
1925         (BRK_INSN_MASK): Define to 0xd4200000.
1926         (aarch64_program_breakpoint_here_p): New function.
1927         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
1928         * arch-utils.c (default_program_breakpoint_here_p): Moved from
1929         breakpoint.c.
1930         * arch-utils.h (default_program_breakpoint_here_p): Moved from
1931         breakpoint.h
1932         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
1933         call gdbarch_program_breakpoint_here_p.
1934         (program_breakpoint_here): Moved to arch-utils.c, renamed to
1935         default_program_breakpoint_here_p, changed return type to bool and
1936         simplified.
1937         * breakpoint.h (program_breakpoint_here): Moved prototype to
1938         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
1939         return type to bool.
1940         * gdbarch.c: Regenerate.
1941         * gdbarch.h: Regenerate.
1942         * gdbarch.sh (program_breakpoint_here_p): New method.
1943         * infrun.c (handle_signal_stop): Call
1944         gdbarch_program_breakpoint_here_p.
1945
1946 2020-01-26  Tom Tromey  <tom@tromey.com>
1947
1948         * ctfread.c (struct ctf_fp_info): Reindent.
1949         (_initialize_ctfread): Remove.
1950
1951 2020-01-26  Tom Tromey  <tom@tromey.com>
1952
1953         * psymtab.c (partial_map_expand_apply)
1954         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1955         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1956         (psym_print_stats, psym_expand_symtabs_for_function)
1957         (psym_map_symbol_filenames, psym_map_matching_symbols)
1958         (psym_expand_symtabs_matching)
1959         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1960         (maintenance_check_psymtabs): Use new methods.
1961         * psympriv.h (struct partial_symtab) <readin_p,
1962         get_compunit_symtab>: New methods.
1963         <readin, compunit_symtab>: Remove members.
1964         (struct standard_psymtab): New.
1965         (struct legacy_psymtab): Derive from standard_psymtab.
1966         * dwarf2read.h (struct dwarf2_psymtab): Derive from
1967         standard_psymtab.
1968         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
1969
1970 2020-01-26  Tom Tromey  <tom@tromey.com>
1971
1972         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
1973         read_dependencies.  Add assert.
1974         * psymtab.c (partial_symtab::read_dependencies): New method.
1975         * psympriv.h (struct partial_symtab) <read_dependencies>: New
1976         method.
1977         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
1978         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
1979         read_dependencies.
1980         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
1981         Add assert.
1982
1983 2020-01-26  Tom Tromey  <tom@tromey.com>
1984
1985         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
1986         Call expand_psymtab.
1987         (xcoff_read_symtab): Call expand_psymtab.
1988         (xcoff_start_psymtab, xcoff_end_psymtab): Set
1989         legacy_expand_psymtab.
1990         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
1991         method.
1992         (struct legacy_psymtab) <expand_psymtab>: Implement.
1993         <legacy_expand_psymtab>: New member.
1994         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
1995         (parse_partial_symbols): Set legacy_expand_psymtab.
1996         (psymtab_to_symtab_1): Change argument order.  Call
1997         expand_psymtab.
1998         (new_psymtab): Set legacy_expand_psymtab.
1999         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
2000         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
2001         expand_psymtab.
2002         (dwarf2_psymtab::expand_psymtab): Rename from
2003         psymtab_to_symtab_1.  Call expand_psymtab.
2004         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
2005         (dbx_end_psymtab): Likewise.
2006         (dbx_psymtab_to_symtab_1): Change argument order. Call
2007         expand_psymtab.
2008         (dbx_read_symtab): Call expand_psymtab.
2009         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
2010         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
2011         (ctf_psymtab::read_symtab): Call expand_psymtab.
2012
2013 2020-01-26  Tom Tromey  <tom@tromey.com>
2014
2015         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
2016         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
2017         messages.
2018         * mdebugread.c (mdebug_read_symtab): Remove prints.
2019         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
2020         assert.
2021         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
2022
2023 2020-01-26  Tom Tromey  <tom@tromey.com>
2024
2025         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
2026         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
2027         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
2028         legacy_symtab.
2029         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
2030         * psymtab.c (psymtab_to_symtab): Call method.
2031         (dump_psymtab): Update.
2032         * psympriv.h (struct partial_symtab): Add virtual destructor.
2033         <read_symtab>: New method.
2034         (struct legacy_symtab): New.
2035         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
2036         (struct pst_map) <pst>: Now a legacy_psymtab.
2037         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
2038         (new_psymtab): Use legacy_psymtab.
2039         * dwarf2read.h (struct dwarf2_psymtab): New.
2040         (struct dwarf2_per_cu_data) <psymtab>: Use it.
2041         * dwarf2read.c (dwarf2_create_include_psymtab)
2042         (dwarf2_build_include_psymtabs, create_type_unit_group)
2043         (create_partial_symtab, process_psymtab_comp_unit_reader)
2044         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
2045         (set_partial_user): Use dwarf2_psymtab.
2046         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
2047         (psymtab_to_symtab_1, process_full_comp_unit)
2048         (process_full_type_unit, dwarf2_ranges_read)
2049         (dwarf2_get_pc_bounds, psymtab_include_file_name)
2050         (dwarf_decode_lines): Use dwarf2_psymtab.
2051         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
2052         (add_address_entry_worker, write_one_signatured_type)
2053         (recursively_count_psymbols, recursively_write_psymbols)
2054         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
2055         (write_debug_names): Likewise.
2056         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
2057         <pst>: Now a legacy_psymtab.
2058         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
2059         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
2060         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
2061         * ctfread.c (struct ctf_psymtab): New.
2062         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
2063         ctf_psymtab.
2064         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
2065         (create_partial_symtab): Return a ctf_psymtab.
2066         (scan_partial_symbols): Update.
2067
2068 2020-01-26  Tom Tromey  <tom@tromey.com>
2069
2070         * xcoffread.c (xcoff_start_psymtab): Use new.
2071         * psymtab.c (partial_symtab::partial_symtab): New constructor,
2072         renamed from start_psymtab_common.
2073         * psympriv.h (struct partial_symtab): Add new constructor.
2074         (start_psymtab_common): Don't declare.
2075         * mdebugread.c (parse_partial_symbols): Use new.
2076         * dwarf2read.c (create_partial_symtab): Use new.
2077         * dbxread.c (start_psymtab): Use new.
2078         * ctfread.c (create_partial_symtab): Use new.
2079
2080 2020-01-26  Tom Tromey  <tom@tromey.com>
2081
2082         * xcoffread.c (xcoff_end_psymtab): Use new.
2083         * psymtab.c (start_psymtab_common): Use new.
2084         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
2085         Update.
2086         * psympriv.h (struct partial_symtab): Add parameters to
2087         constructor.  Don't inline.
2088         (allocate_psymtab): Don't declare.
2089         * mdebugread.c (new_psymtab): Use new.
2090         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
2091         * dbxread.c (dbx_end_psymtab): Use new.
2092
2093 2020-01-26  Tom Tromey  <tom@tromey.com>
2094
2095         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
2096         allocate_psymtab.  Update documentation.
2097         * psymtab.c (psymtab_storage::install_psymtab): Rename from
2098         allocate_psymtab.  Do not use new.
2099         (allocate_psymtab): Use new.  Update.
2100
2101 2020-01-26  Tom Tromey  <tom@tromey.com>
2102
2103         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2104         * psymtab.c (psym_print_stats): Update.
2105         * psympriv.h (struct partial_symtab) <readin,
2106         psymtabs_addrmap_supported, anonymous>: Now bool.
2107         * mdebugread.c (psymtab_to_symtab_1): Update.
2108         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
2109         (build_type_psymtabs_reader, psymtab_to_symtab_1)
2110         (process_full_comp_unit, process_full_type_unit): Update.
2111         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2112         * ctfread.c (psymtab_to_symtab): Update.
2113
2114 2020-01-26  Tom Tromey  <tom@tromey.com>
2115
2116         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
2117         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
2118         * psymtab.c (psymtab_storage): Delete psymtabs.
2119         (psymtab_storage::allocate_psymtab): Use new.
2120         (psymtab_storage::discard_psymtab): Use delete.
2121         * psympriv.h (struct partial_symtab): Add constructor and
2122         initializers.
2123
2124 2020-01-26  Tom Tromey  <tom@tromey.com>
2125
2126         * machoread.c: Do not include psympriv.h.
2127
2128 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2129
2130         * NEWS: Mention the new option and the set/show commands.
2131
2132 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2133
2134         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
2135         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
2136         (validate_exec_file): New variables, enums, functions.
2137         (exec_file_locate_attach, print_section_info): Style the filenames.
2138         (_initialize_exec): Install show_exec_file_mismatch_command and
2139          set_exec_file_mismatch_command.
2140         * gdbcore.h (validate_exec_file): Declare.
2141         * infcmd.c (attach_command): Call validate_exec_file.
2142         * remote.c ( remote_target::remote_add_inferior): Likewise.
2143
2144 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2145
2146         * frame.c (find_frame_sal): Move call to get_next_frame into more
2147         inner scope.
2148         * inline-frame.c (inilne_state) <inline_state>: Update argument
2149         types.
2150         (inilne_state) <skipped_symbol>: Rename to...
2151         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
2152         (skip_inline_frames): Build vector of skipped symbols and use this
2153         to reate the inline_state.
2154         (inline_skipped_symbol): Add a comment and some assertions, fetch
2155         skipped symbol from the list.
2156
2157 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * buildsym.c (lte_is_less_than): Delete.
2160         (buildsym_compunit::end_symtab_with_blockvector): Create local
2161         lambda function to sort line table entries, and use
2162         std::stable_sort instead of std::sort.
2163         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
2164         markers when looking for a previous line.
2165
2166 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * dwarf2read.c (lnp_state_machine::record_line): Include
2169         end_sequence parameter in debug print out.  Record the line if we
2170         are at an end_sequence marker even if it's not the start of a
2171         statement.
2172         * symmisc.c (maintenance_print_one_line_table): Print end of
2173         sequence markers with 'END' not '0'.
2174
2175 2020-01-24  Pedro Alves  <palves@redhat.com>
2176
2177         PR gdb/25410
2178         * thread.c (scoped_restore_current_thread::restore): Use
2179         switch_to_inferior_no_thread.
2180         * exec.c: Include "progspace-and-thread.h".
2181         (add_target_sections, remove_target_sections):
2182         scoped_restore_current_pspace_and_thread instead of
2183         scoped_restore_current_thread.
2184         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
2185         and aspace to the inferior before calling clone_program_space.
2186         Remove stale comment.
2187
2188 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2189
2190         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
2191         (arm_netbsd_nat_target::fetch_registers): ...this.
2192         (arm_nbsd_nat_target::store_registers): Rename to...
2193         (arm_netbsd_nat_target::store_registers): ...this.
2194
2195 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2196
2197         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2198         register_t.
2199
2200 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
2201
2202         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
2203         Update comment.
2204         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
2205         Likewise.
2206         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
2207         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
2208         the correct replacement (iterate_over_regset_sections).
2209         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
2210         Update comment.
2211
2212 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
2213
2214         PR gdb/23718
2215         * gdb/python/python.c (execute_gdb_command): Call
2216         async_enable_stdin in catch block.
2217
2218 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2219
2220         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
2221         SWITCH_THRU_ALL_UIS.
2222
2223 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         PR tui/9765
2226         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
2227         comment, add extra parameter, and update to store previous symbol
2228         when appropriate.
2229         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
2230         add extra parameter.
2231         * tui/tui-disasm.c (tui_disassemble): Update header comment,
2232         remove unneeded parameter, add try/catch around gdb_print_insn,
2233         rewrite to add items to asm_lines vector.
2234         (tui_find_backward_disassembly_start_address): New function.
2235         (tui_find_disassembly_address): Updated throughout.
2236         (tui_disasm_window::set_contents): Update for changes to
2237         tui_disassemble.
2238         (tui_disasm_window::do_scroll_vertical): No need to adjust the
2239         number of lines to scroll.
2240
2241 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
2242
2243         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
2244         (SECT_OFF_DATA): Likewise.
2245         (SECT_OFF_RODATA): Likewise.
2246         (SECT_OFF_TEXT): Likewise.
2247         (SECT_OFF_BSS): Likewise.
2248         (struct objfile) <text_section_offset, data_section_offset>: New
2249         methods.
2250         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
2251         objfile::text_section_offset.
2252         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
2253         * coffread.c (coff_symtab_read): Likewise.
2254         (enter_linenos): Likewise.
2255         (process_coff_symbol): Likewise.
2256         * ctfread.c (get_objfile_text_range): Likewise.
2257         * dtrace-probe.c (dtrace_probe::get_relocated_address):
2258         Use objfile::data_section_offset.
2259         * dwarf2-frame.c (execute_cfa_program): Use
2260         objfile::text_section_offset.
2261         (dwarf2_frame_find_fde): Likewise.
2262         * dwarf2read.c (create_addrmap_from_index): Likewise.
2263         (create_addrmap_from_aranges): Likewise.
2264         (dw2_find_pc_sect_compunit_symtab): Likewise.
2265         (process_psymtab_comp_unit_reader): Likewise.
2266         (add_partial_symbol): Likewise.
2267         (add_partial_subprogram): Likewise.
2268         (process_full_comp_unit): Likewise.
2269         (read_file_scope): Likewise.
2270         (read_func_scope): Likewise.
2271         (read_lexical_block_scope): Likewise.
2272         (read_call_site_scope): Likewise.
2273         (dwarf2_rnglists_process): Likewise.
2274         (dwarf2_ranges_process): Likewise.
2275         (dwarf2_ranges_read): Likewise.
2276         (dwarf_decode_lines_1): Likewise.
2277         (new_symbol): Likewise.
2278         (dwarf2_fetch_die_loc_sect_off): Likewise.
2279         (dwarf2_per_cu_text_offset): Likewise.
2280         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
2281         * hppa-tdep.c (read_unwind_info): Likewise.
2282         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
2283         * psympriv.h (struct partial_symtab): Likewise.
2284         * psymtab.c (find_pc_sect_psymtab): Likewise.
2285         * solib-svr4.c (enable_break): Likewise.
2286         * stap-probe.c (relocate_address): Use
2287         objfile::data_section_offset.
2288         * xcoffread.c (enter_line_range): Use
2289         objfile::text_section_offset.
2290         (read_xcoff_symtab): Likewise.
2291
2292 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2293
2294         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
2295         declaration to narrower scopes.
2296
2297 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
2298
2299         * darwin-nat.h (struct darwin_exception_msg, enum
2300         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
2301         Move up.
2302         (class darwin_nat_target) <wait_1, check_new_threads,
2303         decode_exception_message, decode_message, stop_inferior,
2304         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
2305         * darwin-nat.c (darwin_check_new_threads): Rename to...
2306         (darwin_nat_target::check_new_threads): ... this.
2307         (darwin_suspend_inferior_it): Remove.
2308         (darwin_decode_exception_message): Rename to...
2309         (darwin_nat_target::decode_exception_message): ... this.
2310         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
2311         (darwin_decode_message): Rename to...
2312         (darwin_nat_target::decode_message): ... this.
2313         (cancel_breakpoint): Rename to...
2314         (darwin_nat_target::cancel_breakpoint): ... this.
2315         (darwin_wait): Rename to...
2316         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
2317         instead of iterate_over_inferiors.
2318         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
2319         (darwin_stop_inferior): Rename to...
2320         (darwin_nat_target::stop_inferior): ... this.
2321         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
2322         (darwin_init_thread_list): Rename to...
2323         (darwin_nat_target::init_thread_list): ... this.
2324         (darwin_ptrace_him): Rename to...
2325         (darwin_nat_target::ptrace_him): ... this.
2326         (darwin_nat_target::create_inferior): Pass lambda function to
2327         fork_inferior.
2328         (darwin_nat_target::detach): Call stop_inferior instead of
2329         darwin_stop_inferior.
2330         * fork-inferior.h (fork_inferior): Change init_trace_fun
2331         parameter to gdb::function_view.
2332         * fork-inferior.c (fork_inferior): Likewise.
2333
2334 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
2335
2336         * i386-cygwin-tdep.c (core_process_module_section): Update.
2337         * windows-nat.c (struct lm_info_windows): Add text_offset.
2338         (windows_xfer_shared_libraries): Update.
2339         * windows-tdep.c (windows_xfer_shared_library):
2340         Add text_offset_cached argument.
2341         * windows-tdep.h (windows_xfer_shared_library): Update.
2342
2343 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2344
2345         * gdbarch.sh: Add declaration for _initialize_gdbarch.
2346
2347 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2348
2349         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
2350         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
2351         replace with range-based for.
2352         (gdbsim_interrupt_inferior): Remove.
2353         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
2354         with a range-based for.  Inline code from
2355         gdbsim_interrupt_inferior.
2356
2357 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
2358
2359         * infrun.c (proceed): Fix indentation.
2360
2361 2020-01-21  Tom Tromey  <tromey@adacore.com>
2362
2363         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
2364         * python/python.c (python_extension_ops): Update.
2365         (gdbpy_colorize): New function.
2366         * python/lib/gdb/__init__.py (colorize): New function.
2367         * extension.h (ext_lang_colorize): Declare.
2368         * extension.c (ext_lang_colorize): New function.
2369         * extension-priv.h (struct extension_language_ops) <colorize>: New
2370         member.
2371         * cli/cli-style.c (_initialize_cli_style): Update help text.
2372
2373 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2374
2375         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
2376         <cond>: Change type to bool.
2377         (aarch64_displaced_step_b_cond): Update cond to use bool type.
2378         (aarch64_displaced_step_cb): Likewise.
2379         (aarch64_displaced_step_tb): Likewise.
2380
2381 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2382
2383         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
2384         output.
2385
2386 2020-01-21  Luis Machado  <luis.machado@linaro.org>
2387
2388         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
2389         <pc_adjust>: Adjust the documentation.
2390         (aarch64_displaced_step_fixup): Check if PC really moved before
2391         adjusting it.
2392
2393 2020-01-19  Tom Tromey  <tom@tromey.com>
2394
2395         * disasm.c (~gdb_disassembler): New destructor.
2396         (gdb_buffered_insn_length): Call disassemble_free_target.
2397         * disasm.h (class gdb_disassembler): Declare destructor.  Use
2398         DISABLE_COPY_AND_ASSIGN.
2399
2400 2020-01-19  Tom Tromey  <tom@tromey.com>
2401
2402         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
2403         (die_reader_func_ftype): Remove.
2404         (cutu_reader): New class.
2405         (dw2_get_file_names_reader): Remove "data" parameter.
2406         (dw2_get_file_names): Use cutu_reader.
2407         (create_debug_type_hash_table): Update.
2408         (read_cutu_die_from_dwo): Update comment.
2409         (lookup_dwo_unit): Add dwo_name parameter.
2410         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
2411         die_reader_func_ftype and data parameters.
2412         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
2413         Remove die_reader_func_ftype and data parameters.
2414         (~cutu_reader): New; from init_cutu_and_read_dies.
2415         (cutu_reader::cutu_reader): Rename from
2416         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
2417         and data parameters.
2418         (init_cutu_and_read_dies_simple): Remove.
2419         (struct process_psymtab_comp_unit_data): Remove.
2420         (process_psymtab_comp_unit_reader): Remove data parameter; add
2421         want_partial_unit and pretend_language parameters.
2422         (process_psymtab_comp_unit): Use cutu_reader.
2423         (build_type_psymtabs_reader): Remove data parameter.
2424         (build_type_psymtabs_1): Use cutu_reader.
2425         (process_skeletonless_type_unit): Likewise.
2426         (load_partial_comp_unit_reader): Remove.
2427         (load_partial_comp_unit): Use cutu_reader.
2428         (load_full_comp_unit_reader): Remove.
2429         (load_full_comp_unit): Use cutu_reader.
2430         (struct create_dwo_cu_data): Remove.
2431         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
2432         dwo_unit parameters.
2433         (create_cus_hash_table): Use cutu_reader.
2434         (struct dwarf2_read_addr_index_data): Remove.
2435         (dwarf2_read_addr_index_reader): Remove.
2436         (dwarf2_read_addr_index): Use cutu_reader.
2437         (read_signatured_type_reader): Remove.
2438         (read_signatured_type): Use cutu_reader.
2439
2440 2020-01-19  Tom Tromey  <tom@tromey.com>
2441
2442         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
2443         * tui/tui-wingeneral.h (class tui_suppress_output): New.
2444         (tui_wrefresh): Declare.
2445         * tui/tui-wingeneral.c (suppress_output): New global.
2446         (tui_suppress_output, ~tui_suppress_output): New constructor and
2447         destructor.
2448         (tui_wrefresh): New function.
2449         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
2450         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
2451         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
2452         method.
2453         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
2454         tui_wrefresh.
2455         (tui_data_window::no_refresh): New method.
2456         (tui_data_item_window::refresh_window): Call tui_wrefresh.
2457         (tui_reg_command): Use tui_suppress_output
2458         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
2459         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
2460         method.
2461         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
2462
2463 2020-01-19  Tom Tromey  <tom@tromey.com>
2464
2465         * tui/tui-winsource.c (tui_update_source_windows_with_line):
2466         Handle case where symtab is null.
2467
2468 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
2469
2470         * linux-fork.c (one_fork_p): Simplify.
2471
2472 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2473
2474         * top.c (struct qt_args): Remove.
2475         (kill_or_detach): Change return type to void, replace `void *`
2476         parameter with a proper one.
2477         (print_inferior_quit_action):  Likewise.
2478         (quit_confirm): Use range-based for loop to iterate over inferiors.
2479         (quit_force): Likewise.
2480
2481 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2482
2483         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
2484         `void *` parameter with proper parameters.
2485         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
2486         (print_one_inferior): Change return type to void, replace `void *`
2487         parameter with proper parameters.
2488         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
2489         inferiors.
2490         (get_other_inferior): Remove.
2491         (mi_cmd_remove_inferior): Use range-based loop to iterate over
2492         inferiors.
2493
2494 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2495
2496         * mi/mi-interp.c (report_initial_inferior): Remove.
2497         (mi_interp::init): Use range-based for to iterate over inferiors.
2498
2499 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
2500
2501         * python/py-inferior.c (build_inferior_list): Remove.
2502         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
2503
2504 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
2505
2506         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
2507         (btrace_stitch_trace): Likewise.
2508         * charset.c (intermediate_encoding): Likewise (vaild).
2509         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
2510         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
2511         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
2512
2513 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
2514
2515         * windows-tdep.c (windows_get_tlb_type):
2516         Add rtl_user_process_parameters type.
2517
2518 2020-01-16  Pedro Alves  <palves@redhat.com>
2519             Norbert Lange  <nolange79@gmail.com>
2520
2521         PR build/24805
2522         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
2523         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
2524         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
2525         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
2526         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
2527         (ps_plog): Redeclare exported functions with default visibility.
2528
2529 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
2530
2531         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
2532         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
2533
2534 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
2535
2536         * infcmd.c (post_create_inferior): Use get_thread_regcache
2537         instead of get_current_regcache.
2538
2539 2020-01-14  Tom Tromey  <tom@tromey.com>
2540
2541         PR symtab/12535:
2542         * python/python.c (gdbpy_decode_line): Treat empty string the same
2543         as no argument.
2544
2545 2020-01-14  Tom Tromey  <tom@tromey.com>
2546
2547         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
2548
2549 2020-01-14  Tom Tromey  <tom@tromey.com>
2550
2551         * nat/linux-btrace.c: Don't include <config.h>.
2552         * nat/linux-ptrace.c: Don't include <config.h>.
2553         * nat/x86-linux-dregs.c: Don't include <config.h>.
2554
2555 2020-01-14  Tom Tromey  <tom@tromey.com>
2556
2557         * configure: Rebuild.
2558         * configure.ac: Move many checks to ../gdbsupport/common.m4.
2559
2560 2020-01-14  Tom Tromey  <tom@tromey.com>
2561
2562         * nat/x86-linux-dregs.c: Include configh.h.
2563         * nat/linux-ptrace.c: Include configh.h.
2564         * nat/linux-btrace.c: Include configh.h.
2565         * defs.h: Include config.h, bfd.h.
2566         * configure.ac: Don't source common.host.
2567         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
2568         * configure: Rebuild.
2569         * acinclude.m4: Update path.
2570         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
2571         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
2572         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
2573         (CLIBS): Add LIBSUPPORT.
2574         (CDEPS): Likewise.
2575         (COMMON_SFILES): Remove gdbsupport files.
2576         (HFILES_NO_SRCDIR): Likewise.
2577         (stamp-version): Update path to create-version.sh.
2578         (ALLDEPFILES): Remove gdbsupport files.
2579
2580 2020-01-14  Tom Tromey  <tom@tromey.com>
2581
2582         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
2583         USE_WIN32API when needed.
2584         * configure.ac (USE_WIN32API): Don't define.
2585         (WIN32LIBS): Use WIN32APILIBS.
2586         * configure: Rebuild.
2587
2588 2020-01-14  Tom Tromey  <tom@tromey.com>
2589
2590         * configure: Rebuild.
2591         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
2592
2593 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2594
2595         * skip.c (skip_function_command): Make skip w/o arguments use the
2596         name of the inlined function if pc is inside any inlined function.
2597
2598 2020-01-14  Luis Machado  <luis.machado@linaro.org>
2599
2600         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
2601         * infrun.c (resume_1): Likewise.
2602         (handle_inferior_event): Remove stale comment.
2603         * linux-nat.c (linux_nat_target::resume): Update comments.
2604         (save_stop_reason): Likewise.
2605         (linux_nat_filter_event): Likewise.
2606         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
2607
2608 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2609
2610         * elfread.c (record_minimal_symbol): Set section index to 0 for
2611         non-allocatable sections.
2612
2613
2614 2020-01-13  Ali Tamur <tamur@google.com>
2615
2616         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
2617         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
2618         to gdb::optional.  Update comments.
2619         (dwo_file): Update comments.
2620         (read_attribute): Update API to take an additional out parameter,
2621         need_reprocess.  This is used to mark attributes that need other
2622         attributes (e.g. str_offsets_base) for correct computation which may not
2623         have been read yet.
2624         (read_attribute_reprocess): New function declaration.
2625         (read_addr_index): Likewise.
2626         (read_dwo_str_index): Likewise.
2627         (read_stub_str_index): Likewise.
2628         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
2629         (lookup_addr_base): New function definition.
2630         (lookup_ranges_base): Likewise.
2631         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
2632         lookup_ranges_base.
2633         (init_cutu_and_read_dies): Update comments.
2634         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
2635         unit.  This is used to inherit parent's str_offsets_base and addr_base.
2636         Update comments.
2637         (init_cutu_and_read_dies_simple): Reflect API changes.
2638         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
2639         (create_cus_hash_table): Change API to take parent compile unit.
2640         Reflect API changes.
2641         (open_and_init_dwo_file): Reflect API changes.
2642         (dwarf2_get_pc_bounds): Update comments.
2643         (dwarf2_record_block_ranges): Likewise.
2644         (read_full_die_1): Change implementation to reprocess attributes that
2645         need str_offsets_base and addr_base.
2646         (partial_die_info::read): Likewise.
2647         (read_attribute_reprocess): New function definition.
2648         (read_attribute_value): Change API to take an additional out parameter,
2649         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
2650         when a non-dwo compile unit has index based attributes.
2651         (read_attribute): Reflect API changes.
2652         (read_addr_index_1): Reflect API changes.  Update comments.
2653         (dwarf2_read_addr_index_data): Reflect API changes.
2654         (dwarf2_read_addr_index): Likewise.
2655         (read_str_index): Change API and implementation.  This becomes a helper
2656         to be used by the new string index related methods.  Update error
2657         message and comments.
2658         (read_dwo_str_index): New function definition.
2659         (read_stub_str_index): Likewise.
2660         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
2661         * symfile.h (dwarf2_debug_sections): Likewise.
2662         * xcoffread.c (dwarf2_debug_sections): Likewise.
2663
2664 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2665
2666         * gdbcore.h (struct core_fns) <core_read_registers>: Change
2667         core_reg_sect type to gdb_byte *.
2668         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
2669         * cris-tdep.c (fetch_core_registers): Likewise.
2670         * corelow.c (core_target::get_core_register_section): Change
2671         type of `contents` to gdb::byte_vector.
2672
2673 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * tui/tui-wingeneral.c (box_win): Position the title in the center
2676         of the border.
2677
2678 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2679
2680         * corelow.c (core_target::get_core_register_section): Use
2681           std::vector instead of alloca.
2682
2683 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2684
2685         * warning.m4: Add -Wmissing-declarations to build_warnings.
2686         * configure: Re-generate.
2687
2688 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2689
2690         * python/python.c (init__gdb_module): Add declaration.
2691
2692 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2693
2694         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
2695         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
2696         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
2697         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
2698         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
2699         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
2700         * ada-exp.y (_initialize_ada_exp): Add declaration.
2701         * ada-lang.c (_initialize_ada_language): Add declaration.
2702         * ada-tasks.c (_initialize_tasks): Add declaration.
2703         * agent.c (_initialize_agent): Add declaration.
2704         * aix-thread.c (_initialize_aix_thread): Add declaration.
2705         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
2706         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
2707         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
2708         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
2709         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
2710         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
2711         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
2712         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
2713         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
2714         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
2715         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
2716         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
2717         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
2718         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
2719         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
2720         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
2721         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
2722         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
2723         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
2724         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
2725         * annotate.c (_initialize_annotate): Add declaration.
2726         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
2727         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
2728         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
2729         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
2730         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
2731         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
2732         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
2733         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
2734         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
2735         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
2736         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
2737         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
2738         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
2739         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
2740         * auto-load.c (_initialize_auto_load): Add declaration.
2741         * auxv.c (_initialize_auxv): Add declaration.
2742         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
2743         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
2744         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
2745         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
2746         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
2747         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
2748         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
2749         * breakpoint.c (_initialize_breakpoint): Add declaration.
2750         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
2751         * btrace.c (_initialize_btrace): Add declaration.
2752         * charset.c (_initialize_charset): Add declaration.
2753         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
2754         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
2755         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
2756         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
2757         * cli/cli-script.c (_initialize_cli_script): Add declaration.
2758         * cli/cli-style.c (_initialize_cli_style): Add declaration.
2759         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
2760         * coffread.c (_initialize_coffread): Add declaration.
2761         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
2762         * compile/compile.c (_initialize_compile): Add declaration.
2763         * complaints.c (_initialize_complaints): Add declaration.
2764         * completer.c (_initialize_completer): Add declaration.
2765         * copying.c (_initialize_copying): Add declaration.
2766         * corefile.c (_initialize_core): Add declaration.
2767         * corelow.c (_initialize_corelow): Add declaration.
2768         * cp-abi.c (_initialize_cp_abi): Add declaration.
2769         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
2770         * cp-support.c (_initialize_cp_support): Add declaration.
2771         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
2772         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
2773         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
2774         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
2775         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
2776         * ctfread.c (_initialize_ctfread): Add declaration.
2777         * d-lang.c (_initialize_d_language): Add declaration.
2778         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
2779         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
2780         * dbxread.c (_initialize_dbxread): Add declaration.
2781         * dcache.c (_initialize_dcache): Add declaration.
2782         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
2783         * disasm.c (_initialize_disasm): Add declaration.
2784         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
2785         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
2786         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
2787         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
2788         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
2789         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
2790         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
2791         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
2792         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
2793         * elfread.c (_initialize_elfread): Add declaration.
2794         * exec.c (_initialize_exec): Add declaration.
2795         * extension.c (_initialize_extension): Add declaration.
2796         * f-lang.c (_initialize_f_language): Add declaration.
2797         * f-valprint.c (_initialize_f_valprint): Add declaration.
2798         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
2799         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
2800         * filesystem.c (_initialize_filesystem): Add declaration.
2801         * findcmd.c (_initialize_mem_search): Add declaration.
2802         * findvar.c (_initialize_findvar): Add declaration.
2803         * fork-child.c (_initialize_fork_child): Add declaration.
2804         * frame-base.c (_initialize_frame_base): Add declaration.
2805         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
2806         * frame.c (_initialize_frame): Add declaration.
2807         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
2808         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
2809         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
2810         * gcore.c (_initialize_gcore): Add declaration.
2811         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
2812         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
2813         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
2814         * gdbarch.c (_initialize_gdbarch): Add declaration.
2815         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
2816         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
2817         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
2818         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
2819         * go-lang.c (_initialize_go_language): Add declaration.
2820         * go32-nat.c (_initialize_go32_nat): Add declaration.
2821         * guile/guile.c (_initialize_guile): Add declaration.
2822         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
2823         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
2824         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
2825         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
2826         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
2827         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
2828         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
2829         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
2830         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
2831         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
2832         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
2833         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
2834         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
2835         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
2836         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
2837         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
2838         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
2839         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
2840         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
2841         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
2842         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
2843         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
2844         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
2845         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
2846         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
2847         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
2848         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
2849         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
2850         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
2851         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
2852         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
2853         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
2854         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
2855         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
2856         * infcall.c (_initialize_infcall): Add declaration.
2857         * infcmd.c (_initialize_infcmd): Add declaration.
2858         * inflow.c (_initialize_inflow): Add declaration.
2859         * infrun.c (_initialize_infrun): Add declaration.
2860         * interps.c (_initialize_interpreter): Add declaration.
2861         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
2862         * jit.c (_initialize_jit): Add declaration.
2863         * language.c (_initialize_language): Add declaration.
2864         * linux-fork.c (_initialize_linux_fork): Add declaration.
2865         * linux-nat.c (_initialize_linux_nat): Add declaration.
2866         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
2867         * linux-thread-db.c (_initialize_thread_db): Add declaration.
2868         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
2869         * m2-lang.c (_initialize_m2_language): Add declaration.
2870         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
2871         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
2872         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
2873         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
2874         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
2875         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
2876         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
2877         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
2878         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
2879         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
2880         * machoread.c (_initialize_machoread): Add declaration.
2881         * macrocmd.c (_initialize_macrocmd): Add declaration.
2882         * macroscope.c (_initialize_macroscope): Add declaration.
2883         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
2884         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
2885         * maint.c (_initialize_maint_cmds): Add declaration.
2886         * mdebugread.c (_initialize_mdebugread): Add declaration.
2887         * memattr.c (_initialize_mem): Add declaration.
2888         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
2889         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
2890         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
2891         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
2892         * mi/mi-main.c (_initialize_mi_main): Add declaration.
2893         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
2894         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
2895         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
2896         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
2897         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
2898         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
2899         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
2900         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
2901         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
2902         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
2903         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
2904         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
2905         * mipsread.c (_initialize_mipsread): Add declaration.
2906         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
2907         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
2908         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
2909         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
2910         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
2911         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
2912         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
2913         * nto-procfs.c (_initialize_procfs): Add declaration.
2914         * objc-lang.c (_initialize_objc_language): Add declaration.
2915         * observable.c (_initialize_observer): Add declaration.
2916         * opencl-lang.c (_initialize_opencl_language): Add declaration.
2917         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
2918         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
2919         * osabi.c (_initialize_gdb_osabi): Add declaration.
2920         * osdata.c (_initialize_osdata): Add declaration.
2921         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
2922         * parse.c (_initialize_parse): Add declaration.
2923         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
2924         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
2925         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
2926         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
2927         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
2928         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
2929         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
2930         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
2931         * printcmd.c (_initialize_printcmd): Add declaration.
2932         * probe.c (_initialize_probe): Add declaration.
2933         * proc-api.c (_initialize_proc_api): Add declaration.
2934         * proc-events.c (_initialize_proc_events): Add declaration.
2935         * proc-service.c (_initialize_proc_service): Add declaration.
2936         * procfs.c (_initialize_procfs): Add declaration.
2937         * producer.c (_initialize_producer): Add declaration.
2938         * psymtab.c (_initialize_psymtab): Add declaration.
2939         * python/python.c (_initialize_python): Add declaration.
2940         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
2941         * record-btrace.c (_initialize_record_btrace): Add declaration.
2942         * record-full.c (_initialize_record_full): Add declaration.
2943         * record.c (_initialize_record): Add declaration.
2944         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
2945         * regcache.c (_initialize_regcache): Add declaration.
2946         * reggroups.c (_initialize_reggroup): Add declaration.
2947         * remote-notif.c (_initialize_notif): Add declaration.
2948         * remote-sim.c (_initialize_remote_sim): Add declaration.
2949         * remote.c (_initialize_remote): Add declaration.
2950         * reverse.c (_initialize_reverse): Add declaration.
2951         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
2952         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
2953         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
2954         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
2955         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
2956         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
2957         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
2958         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
2959         Add declaration.
2960         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
2961         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
2962         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
2963         * rust-exp.y (_initialize_rust_exp): Add declaration.
2964         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
2965         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
2966         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
2967         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
2968         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
2969         * score-tdep.c (_initialize_score_tdep): Add declaration.
2970         * ser-go32.c (_initialize_ser_dos): Add declaration.
2971         * ser-mingw.c (_initialize_ser_windows): Add declaration.
2972         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
2973         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
2974         * ser-uds.c (_initialize_ser_socket): Add declaration.
2975         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
2976         * serial.c (_initialize_serial): Add declaration.
2977         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
2978         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
2979         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
2980         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
2981         * skip.c (_initialize_step_skip): Add declaration.
2982         * sol-thread.c (_initialize_sol_thread): Add declaration.
2983         * solib-aix.c (_initialize_solib_aix): Add declaration.
2984         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
2985         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
2986         * solib-frv.c (_initialize_frv_solib): Add declaration.
2987         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
2988         * solib-target.c (_initialize_solib_target): Add declaration.
2989         * solib.c (_initialize_solib): Add declaration.
2990         * source-cache.c (_initialize_source_cache): Add declaration.
2991         * source.c (_initialize_source): Add declaration.
2992         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
2993         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
2994         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
2995         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
2996         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
2997         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
2998         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
2999         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
3000         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
3001         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
3002         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
3003         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
3004         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
3005         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
3006         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
3007         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
3008         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
3009         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
3010         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
3011         * stabsread.c (_initialize_stabsread): Add declaration.
3012         * stack.c (_initialize_stack): Add declaration.
3013         * stap-probe.c (_initialize_stap_probe): Add declaration.
3014         * std-regs.c (_initialize_frame_reg): Add declaration.
3015         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
3016         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
3017         * symfile.c (_initialize_symfile): Add declaration.
3018         * symmisc.c (_initialize_symmisc): Add declaration.
3019         * symtab.c (_initialize_symtab): Add declaration.
3020         * target.c (_initialize_target): Add declaration.
3021         * target-connection.c (_initialize_target_connection): Add
3022         declaration.
3023         * target-dcache.c (_initialize_target_dcache): Add declaration.
3024         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
3025         * thread.c (_initialize_thread): Add declaration.
3026         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
3027         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
3028         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
3029         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
3030         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
3031         * tracectf.c (_initialize_ctf): Add declaration.
3032         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
3033         * tracefile.c (_initialize_tracefile): Add declaration.
3034         * tracepoint.c (_initialize_tracepoint): Add declaration.
3035         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
3036         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
3037         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
3038         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
3039         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
3040         * tui/tui-win.c (_initialize_tui_win): Add declaration.
3041         * tui/tui.c (_initialize_tui): Add declaration.
3042         * typeprint.c (_initialize_typeprint): Add declaration.
3043         * ui-style.c (_initialize_ui_style): Add declaration.
3044         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
3045         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
3046         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
3047         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
3048         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
3049         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
3050         * unittests/filtered_iterator-selftests.c
3051         (_initialize_filtered_iterator_selftests): Add declaration.
3052         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
3053         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
3054         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
3055         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
3056         * unittests/main-thread-selftests.c
3057         (_initialize_main_thread_selftests): Add declaration.
3058         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
3059         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
3060         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
3061         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
3062         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
3063         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
3064         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
3065         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
3066         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
3067         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
3068         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
3069         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
3070         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
3071         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
3072         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
3073         declaration.
3074         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
3075         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
3076         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
3077         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
3078         * user-regs.c (_initialize_user_regs): Add declaration.
3079         * utils.c (_initialize_utils): Add declaration.
3080         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
3081         * valops.c (_initialize_valops): Add declaration.
3082         * valprint.c (_initialize_valprint): Add declaration.
3083         * value.c (_initialize_values): Add declaration.
3084         * varobj.c (_initialize_varobj): Add declaration.
3085         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
3086         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
3087         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
3088         * windows-nat.c (_initialize_windows_nat): Add declaration.
3089         (_initialize_check_for_gdb_ini): Add declaration.
3090         (_initialize_loadable): Add declaration.
3091         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
3092         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
3093         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
3094         * xcoffread.c (_initialize_xcoffread): Add declaration.
3095         * xml-support.c (_initialize_xml_support): Add declaration.
3096         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
3097         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
3098         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
3099         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
3100
3101 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3102
3103         * regformats/regdat.sh: Generate declaration for init function.
3104
3105 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
3106
3107         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
3108         up.
3109         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
3110         close_one_inferior>: New methods.
3111         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
3112         pass down target to find_inferior_pid.
3113         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
3114         Pass down target to find_inferior_ptid.
3115         (gdbsim_target::create_inferior): Pass down target to
3116         add_thread_silent.
3117         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
3118         target down to find_inferior_ptid and switch_to_thread.
3119         (gdbsim_target::close): Update to call close_one_inferior.
3120         (struct resume_data): Remove.
3121         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
3122         directly, rather than through a void pointer.
3123         (gdbsim_target::resume): Update to call resume_one_inferior.
3124
3125 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
3126
3127         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
3128
3129 2020-01-12  Pedro Alves  <palves@redhat.com>
3130
3131         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
3132         directly for the current inferior instead of
3133         discard_all_inferiors.
3134         (discard_all_inferiors): Delete.
3135
3136 2020-01-11  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui-wingeneral.c (box_win): Check cli_styling.
3139         * tui/tui-winsource.c (tui_source_window_base::refill): Use
3140         deprecated_safe_get_selected_frame.
3141
3142 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3143
3144         * inferior.c (print_inferior): Switch inferior before printing it.
3145
3146 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
3147             Pedro Alves  <palves@redhat.com>
3148
3149         * progspace-and-thread.c (switch_to_program_space_and_thread):
3150         Assert there's an inferior for PSPACE.  Use
3151         switch_to_inferior_no_thread to switch the inferior too.
3152         * progspace.c (program_space::~program_space): Call
3153         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
3154         (program_space::free_all_objfiles): Don't call clear_symtab_users
3155         here.
3156         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
3157
3158 2020-01-10  Pedro Alves  <palves@redhat.com>
3159
3160         * NEWS: Mention multi-target debugging, "info connections", and
3161         "add-inferior -no-connection".
3162
3163 2020-01-10  Pedro Alves  <palves@redhat.com>
3164
3165         * infrun.c: Include "target-connection.h".
3166         (check_multi_target_resumption): New.
3167         (proceed): Call it.
3168         * target-connection.c (make_target_connection_string): Make
3169         extern.
3170         * target-connection.h (make_target_connection_string): Declare.
3171
3172 2020-01-10  Pedro Alves  <palves@redhat.com>
3173
3174         * Makefile.in (COMMON_SFILES): Add target-connection.c.
3175         * inferior.c (uiout_field_connection): New function.
3176         (print_inferior): Add new "connection-id" column.
3177         (add_inferior_command): Show connection number/string of added
3178         inferior.
3179         * process-stratum-target.h
3180         (process_stratum_target::connection_string): New virtual method.
3181         (process_stratum_target::connection_number): New field.
3182         * remote.c (remote_target::connection_string): New override.
3183         * target-connection.c: New file.
3184         * target-connection.h: New file.
3185         * target.c (decref_target): Remove process_stratum targets from
3186         the connection list.
3187         (target_stack::push): Add process_stratum targets to the
3188         connection list.
3189
3190 2020-01-10  Pedro Alves  <palves@redhat.com>
3191
3192         Revert:
3193         2016-04-12  Pedro Alves  <palves@redhat.com>
3194         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
3195         Remove references to name.
3196         * serial.h (struct serial) <name>: Delete.
3197
3198 2020-01-10  Pedro Alves  <palves@redhat.com>
3199
3200         * gdbarch-selftests.c (register_to_value_test): Remove "target
3201         already pushed" check.
3202
3203 2020-01-10  Pedro Alves  <palves@redhat.com>
3204             John Baldwin  <jhb@FreeBSD.org>
3205
3206         * aarch64-linux-nat.c
3207         (aarch64_linux_nat_target::thread_architecture): Adjust.
3208         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
3209         (task_command_1): Likewise.
3210         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
3211         (aix_thread_target::wait, aix_thread_target::fetch_registers)
3212         (aix_thread_target::store_registers)
3213         (aix_thread_target::thread_alive): Adjust.
3214         * amd64-fbsd-tdep.c: Include "inferior.h".
3215         (amd64fbsd_get_thread_local_address): Pass down target.
3216         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
3217         thread's gdbarch instead of target_gdbarch.
3218         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
3219         get_last_target_status.
3220         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
3221         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
3222         inferiors.
3223         (update_inserted_breakpoint_locations): Skip if inferiors with no
3224         execution.
3225         (update_global_location_list): When handling moribund locations,
3226         find representative inferior for location's pspace, and use thread
3227         count of its process_stratum target.
3228         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
3229         * bsd-uthread.c (bsd_uthread_target::wait): Use
3230         as_process_stratum_target and adjust thread_change_ptid and
3231         add_thread calls.
3232         (bsd_uthread_target::update_thread_list): Use
3233         as_process_stratum_target and adjust find_thread_ptid,
3234         thread_change_ptid and add_thread calls.
3235         * btrace.c (maint_btrace_packet_history_cmd): Adjust
3236         find_thread_ptid call.
3237         * corelow.c (add_to_thread_list): Adjust add_thread call.
3238         (core_target_open): Adjust add_thread_silent and thread_count
3239         calls.
3240         (core_target::pid_to_str): Adjust find_inferior_ptid call.
3241         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
3242         * event-top.c (async_disconnect): Pop targets from all inferiors.
3243         * exec.c (add_target_sections): Push exec target on all inferiors
3244         sharing the program space.
3245         (remove_target_sections): Remove the exec target from all
3246         inferiors sharing the program space.
3247         (exec_on_vfork): New.
3248         * exec.h (exec_on_vfork): Declare.
3249         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
3250         Pass it down.
3251         (fbsd_nat_target::update_thread_list): Adjust.
3252         (fbsd_nat_target::resume): Adjust.
3253         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
3254         down.
3255         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
3256         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
3257         get_thread_arch_regcache call.
3258         * fork-child.c (gdb_startup_inferior): Pass target down to
3259         startup_inferior and set_executing.
3260         * gdbthread.h (struct process_stratum_target): Forward declare.
3261         (add_thread, add_thread_silent, add_thread_with_info)
3262         (in_thread_list): Add process_stratum_target parameter.
3263         (find_thread_ptid(inferior*, ptid_t)): New overload.
3264         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
3265         parameter.
3266         (all_threads()): Delete overload.
3267         (all_threads, all_non_exited_threads): Add process_stratum_target
3268         parameter.
3269         (all_threads_safe): Use brace initialization.
3270         (thread_count): Add process_stratum_target parameter.
3271         (set_resumed, set_running, set_stop_requested, set_executing)
3272         (threads_are_executing, finish_thread_state): Add
3273         process_stratum_target parameter.
3274         (switch_to_thread): Use is_current_thread.
3275         * i386-fbsd-tdep.c: Include "inferior.h".
3276         (i386fbsd_get_thread_local_address): Pass down target.
3277         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
3278         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
3279         have_inferiors check.
3280         * inf-ptrace.c (inf_ptrace_target::create_inferior)
3281         (inf_ptrace_target::attach): Adjust.
3282         * infcall.c (run_inferior_call): Adjust.
3283         * infcmd.c (run_command_1): Pass target to
3284         scoped_finish_thread_state.
3285         (proceed_thread_callback): Skip inferiors with no execution.
3286         (continue_command): Rename 'all_threads' local to avoid hiding
3287         'all_threads' function.  Adjust get_last_target_status call.
3288         (prepare_one_step): Adjust set_running call.
3289         (signal_command): Use user_visible_resume_target.  Compare thread
3290         pointers instead of inferior_ptid.
3291         (info_program_command): Adjust to pass down target.
3292         (attach_command): Mark target's 'thread_executing' flag.
3293         (stop_current_target_threads_ns): New, factored out from ...
3294         (interrupt_target_1): ... this.  Switch inferior before making
3295         target calls.
3296         * inferior-iter.h
3297         (struct all_inferiors_iterator, struct all_inferiors_range)
3298         (struct all_inferiors_safe_range)
3299         (struct all_non_exited_inferiors_range): Filter on
3300         process_stratum_target too.  Remove explicit.
3301         * inferior.c (inferior::inferior): Push dummy target on target
3302         stack.
3303         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
3304         Add process_stratum_target parameter, and pass it down.
3305         (have_live_inferiors): Adjust.
3306         (switch_to_inferior_and_push_target): New.
3307         (add_inferior_command, clone_inferior_command): Handle
3308         "-no-connection" parameter.  Use
3309         switch_to_inferior_and_push_target.
3310         (_initialize_inferior): Mention "-no-connection" option in
3311         the help of "add-inferior" and "clone-inferior" commands.
3312         * inferior.h: Include "process-stratum-target.h".
3313         (interrupt_target_1): Use bool.
3314         (struct inferior) <push_target, unpush_target, target_is_pushed,
3315         find_target_beneath, top_target, process_target, target_at,
3316         m_stack>: New.
3317         (discard_all_inferiors): Delete.
3318         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
3319         (all_inferiors, all_non_exited_inferiors): Add
3320         process_stratum_target parameter.
3321         * infrun.c: Include "gdb_select.h" and <unordered_map>.
3322         (target_last_proc_target): New global.
3323         (follow_fork_inferior): Push target on new inferior.  Pass target
3324         to add_thread_silent.  Call exec_on_vfork.  Handle target's
3325         reference count.
3326         (follow_fork): Adjust get_last_target_status call.  Also consider
3327         target.
3328         (follow_exec): Push target on new inferior.
3329         (struct execution_control_state) <target>: New field.
3330         (user_visible_resume_target): New.
3331         (do_target_resume): Call target_async.
3332         (resume_1): Set target's threads_executing flag.  Consider resume
3333         target.
3334         (commit_resume_all_targets): New.
3335         (proceed): Also consider resume target.  Skip threads of inferiors
3336         with no execution.  Commit resumtion in all targets.
3337         (start_remote): Pass current inferior to wait_for_inferior.
3338         (infrun_thread_stop_requested): Consider target as well.  Pass
3339         thread_info pointer to clear_inline_frame_state instead of ptid.
3340         (infrun_thread_thread_exit): Consider target as well.
3341         (random_pending_event_thread): New inferior parameter.  Use it.
3342         (do_target_wait): Rename to ...
3343         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
3344         down.
3345         (threads_are_resumed_pending_p, do_target_wait): New.
3346         (prepare_for_detach): Adjust calls.
3347         (wait_for_inferior): New inferior parameter.  Handle it.  Use
3348         do_target_wait_1 instead of do_target_wait.
3349         (fetch_inferior_event): Adjust.  Switch to representative
3350         inferior.  Pass target down.
3351         (set_last_target_status): Add process_stratum_target parameter.
3352         Save target in global.
3353         (get_last_target_status): Add process_stratum_target parameter and
3354         handle it.
3355         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
3356         (context_switch): Check inferior_ptid == null_ptid before calling
3357         inferior_thread().
3358         (get_inferior_stop_soon): Pass down target.
3359         (wait_one): Rename to ...
3360         (poll_one_curr_target): ... this.
3361         (struct wait_one_event): New.
3362         (wait_one): New.
3363         (stop_all_threads): Adjust.
3364         (handle_no_resumed, handle_inferior_event): Adjust to consider the
3365         event's target.
3366         (switch_back_to_stepped_thread): Also consider target.
3367         (print_stop_event): Update.
3368         (normal_stop): Update.  Also consider the resume target.
3369         * infrun.h (wait_for_inferior): Remove declaration.
3370         (user_visible_resume_target): New declaration.
3371         (get_last_target_status, set_last_target_status): New
3372         process_stratum_target parameter.
3373         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3374         process_stratum_target parameter, and use it.
3375         (clear_inline_frame_state (thread_info*)): New.
3376         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
3377         process_stratum_target parameter.
3378         (clear_inline_frame_state (thread_info*)): Declare.
3379         * linux-fork.c (delete_checkpoint_command): Pass target down to
3380         find_thread_ptid.
3381         (checkpoint_command): Adjust.
3382         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
3383         instead of just tweaking inferior_ptid.
3384         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
3385         (exit_lwp): Pass target down to find_thread_ptid.
3386         (attach_proc_task_lwp_callback): Pass target down to
3387         add_thread/set_running/set_executing.
3388         (linux_nat_target::attach): Pass target down to
3389         thread_change_ptid.
3390         (get_detach_signal): Pass target down to find_thread_ptid.
3391         Consider last target status's target.
3392         (linux_resume_one_lwp_throw, resume_lwp)
3393         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
3394         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
3395         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
3396         (linux_nat_target::async_wait_fd): New.
3397         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
3398         target down.
3399         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
3400         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
3401         * linux-thread-db.c (struct thread_db_info::process_target): New
3402         field.
3403         (add_thread_db_info): Save target.
3404         (get_thread_db_info): New process_stratum_target parameter.  Also
3405         match target.
3406         (delete_thread_db_info): New process_stratum_target parameter.
3407         Also match target.
3408         (thread_from_lwp): Adjust to pass down target.
3409         (thread_db_notice_clone): Pass down target.
3410         (check_thread_db_callback): Pass down target.
3411         (try_thread_db_load_1): Always push the thread_db target.
3412         (try_thread_db_load, record_thread): Pass target down.
3413         (thread_db_target::detach): Pass target down.  Always unpush the
3414         thread_db target.
3415         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
3416         target down.  Always unpush the thread_db target.
3417         (find_new_threads_callback, thread_db_find_new_threads_2)
3418         (thread_db_target::update_thread_list): Pass target down.
3419         (thread_db_target::pid_to_str): Pass current inferior down.
3420         (thread_db_target::get_thread_local_address): Pass target down.
3421         (thread_db_target::resume, maintenance_check_libthread_db): Pass
3422         target down.
3423         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
3424         * procfs.c (procfs_target::procfs_init_inferior): Declare.
3425         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
3426         (procfs_init_inferior): Rename to ...
3427         (procfs_target::procfs_init_inferior): ... this and adjust.
3428         (procfs_target::create_inferior, procfs_notice_thread)
3429         (procfs_do_thread_registers): Adjust.
3430         * ppc-fbsd-tdep.c: Include "inferior.h".
3431         (ppcfbsd_get_thread_local_address): Pass down target.
3432         * proc-service.c (ps_xfer_memory): Switch current inferior and
3433         program space as well.
3434         (get_ps_regcache): Pass target down.
3435         * process-stratum-target.c
3436         (process_stratum_target::thread_address_space)
3437         (process_stratum_target::thread_architecture): Pass target down.
3438         * process-stratum-target.h
3439         (process_stratum_target::threads_executing): New field.
3440         (as_process_stratum_target): New.
3441         * ravenscar-thread.c
3442         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
3443         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
3444         down.
3445         * record-btrace.c (record_btrace_target::info_record): Adjust.
3446         (record_btrace_target::record_method)
3447         (record_btrace_target::record_is_replaying)
3448         (record_btrace_target::fetch_registers)
3449         (get_thread_current_frame_id, record_btrace_target::resume)
3450         (record_btrace_target::wait, record_btrace_target::stop): Pass
3451         target down.
3452         * record-full.c (record_full_wait_1): Switch to event thread.
3453         Pass target down.
3454         * regcache.c (regcache::regcache)
3455         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
3456         process_stratum_target parameter and handle it.
3457         (current_thread_target): New global.
3458         (get_thread_regcache): Add process_stratum_target parameter and
3459         handle it.  Switch inferior before calling target method.
3460         (get_thread_regcache): Pass target down.
3461         (get_thread_regcache_for_ptid): Pass target down.
3462         (registers_changed_ptid): Add process_stratum_target parameter and
3463         handle it.
3464         (registers_changed_thread, registers_changed): Pass target down.
3465         (test_get_thread_arch_aspace_regcache): New.
3466         (current_regcache_test): Define a couple local test_target_ops
3467         instances and use them for testing.
3468         (readwrite_regcache): Pass process_stratum_target parameter.
3469         (cooked_read_test, cooked_write_test): Pass mock_target down.
3470         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
3471         (get_thread_arch_aspace_regcache): Add process_stratum_target
3472         parameter.
3473         (regcache::target): New method.
3474         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
3475         (regcache::registers_changed_ptid): Add process_stratum_target
3476         parameter.
3477         (regcache::m_target): New field.
3478         (registers_changed_ptid): Add process_stratum_target parameter.
3479         * remote.c (remote_state::supports_vCont_probed): New field.
3480         (remote_target::async_wait_fd): New method.
3481         (remote_unpush_and_throw): Add remote_target parameter.
3482         (get_current_remote_target): Adjust.
3483         (remote_target::remote_add_inferior): Push target.
3484         (remote_target::remote_add_thread)
3485         (remote_target::remote_notice_new_inferior)
3486         (get_remote_thread_info): Pass target down.
3487         (remote_target::update_thread_list): Skip threads of inferiors
3488         bound to other targets.  (remote_target::close): Don't discard
3489         inferiors.  (remote_target::add_current_inferior_and_thread)
3490         (remote_target::process_initial_stop_replies)
3491         (remote_target::start_remote)
3492         (remote_target::remote_serial_quit_handler): Pass down target.
3493         (remote_target::remote_unpush_target): New remote_target
3494         parameter.  Unpush the target from all inferiors.
3495         (remote_target::remote_unpush_and_throw): New remote_target
3496         parameter.  Pass it down.
3497         (remote_target::open_1): Check whether the current inferior has
3498         execution instead of checking whether any inferior is live.  Pass
3499         target down.
3500         (remote_target::remote_detach_1): Pass down target.  Use
3501         remote_unpush_target.
3502         (extended_remote_target::attach): Pass down target.
3503         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
3504         (remote_target::append_resumption): Pass down target.
3505         (remote_target::append_pending_thread_resumptions)
3506         (remote_target::remote_resume_with_hc, remote_target::resume)
3507         (remote_target::commit_resume): Pass down target.
3508         (remote_target::remote_stop_ns): Check supports_vCont_probed.
3509         (remote_target::interrupt_query)
3510         (remote_target::remove_new_fork_children)
3511         (remote_target::check_pending_events_prevent_wildcard_vcont)
3512         (remote_target::remote_parse_stop_reply)
3513         (remote_target::process_stop_reply): Pass down target.
3514         (first_remote_resumed_thread): New remote_target parameter.  Pass
3515         it down.
3516         (remote_target::wait_as): Pass down target.
3517         (unpush_and_perror): New remote_target parameter.  Pass it down.
3518         (remote_target::readchar, remote_target::remote_serial_write)
3519         (remote_target::getpkt_or_notif_sane_1)
3520         (remote_target::kill_new_fork_children, remote_target::kill): Pass
3521         down target.
3522         (remote_target::mourn_inferior): Pass down target.  Use
3523         remote_unpush_target.
3524         (remote_target::core_of_thread)
3525         (remote_target::remote_btrace_maybe_reopen): Pass down target.
3526         (remote_target::pid_to_exec_file)
3527         (remote_target::thread_handle_to_thread_info): Pass down target.
3528         (remote_target::async_wait_fd): New.
3529         * riscv-fbsd-tdep.c: Include "inferior.h".
3530         (riscv_fbsd_get_thread_local_address): Pass down target.
3531         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
3532         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
3533         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
3534         Adjust.
3535         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
3536         * solib-svr4.c (enable_break): Pass down target.
3537         * spu-multiarch.c (parse_spufs_run): Pass down target.
3538         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
3539         * target-delegates.c: Regenerate.
3540         * target.c (g_target_stack): Delete.
3541         (current_top_target): Return the current inferior's top target.
3542         (target_has_execution_1): Refer to the passed-in inferior's top
3543         target.
3544         (target_supports_terminal_ours): Check whether the initial
3545         inferior was already created.
3546         (decref_target): New.
3547         (target_stack::push): Incref/decref the target.
3548         (push_target, push_target, unpush_target): Adjust.
3549         (target_stack::unpush): Defref target.
3550         (target_is_pushed): Return bool.  Adjust to refer to the current
3551         inferior's target stack.
3552         (dispose_inferior): Delete, and inline parts ...
3553         (target_preopen): ... here.  Only dispose of the current inferior.
3554         (target_detach): Hold strong target reference while detaching.
3555         Pass target down.
3556         (target_thread_name): Add assertion.
3557         (target_resume): Pass down target.
3558         (target_ops::beneath, find_target_at): Adjust to refer to the
3559         current inferior's target stack.
3560         (get_dummy_target): New.
3561         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
3562         has a thread running.
3563         (initialize_targets): Rename to ...
3564         (_initialize_target): ... this.
3565         * target.h: Include "gdbsupport/refcounted-object.h".
3566         (struct target_ops): Inherit refcounted_object.
3567         (target_ops::shortname, target_ops::longname): Make const.
3568         (target_ops::async_wait_fd): New method.
3569         (decref_target): Declare.
3570         (struct target_ops_ref_policy): New.
3571         (target_ops_ref): New typedef.
3572         (get_dummy_target): Declare function.
3573         (target_is_pushed): Return bool.
3574         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
3575         (all_matching_threads_iterator::all_matching_threads_iterator):
3576         Handle filter target.
3577         * thread-iter.h (struct all_matching_threads_iterator, struct
3578         all_matching_threads_range, class all_non_exited_threads_range):
3579         Filter by target too.  Remove explicit.
3580         * thread.c (threads_executing): Delete.
3581         (inferior_thread): Pass down current inferior.
3582         (clear_thread_inferior_resources): Pass down thread pointer
3583         instead of ptid_t.
3584         (add_thread_silent, add_thread_with_info, add_thread): Add
3585         process_stratum_target parameter.  Use it for thread and inferior
3586         searches.
3587         (is_current_thread): New.
3588         (thread_info::deletable): Use it.
3589         (find_thread_ptid, thread_count, in_thread_list)
3590         (thread_change_ptid, set_resumed, set_running): New
3591         process_stratum_target parameter.  Pass it down.
3592         (set_executing): New process_stratum_target parameter.  Pass it
3593         down.  Adjust reference to 'threads_executing'.
3594         (threads_are_executing): New process_stratum_target parameter.
3595         Adjust reference to 'threads_executing'.
3596         (set_stop_requested, finish_thread_state): New
3597         process_stratum_target parameter.  Pass it down.
3598         (switch_to_thread): Also match inferior.
3599         (switch_to_thread): New process_stratum_target parameter.  Pass it
3600         down.
3601         (update_threads_executing): Reimplement.
3602         * top.c (quit_force): Pop targets from all inferior.
3603         (gdb_init): Don't call initialize_targets.
3604         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
3605         Declare.
3606         (windows_add_thread, windows_delete_thread): Adjust.
3607         (get_windows_debug_event): Rename to ...
3608         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
3609         * tracefile-tfile.c (tfile_target_open): Pass down target.
3610         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
3611         Forward declare.
3612         (switch_to_thread): Add process_stratum_target parameter.
3613         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
3614         parameter.  Use it.
3615         (mi_on_resume): Pass target down.
3616         * nat/fork-inferior.c (startup_inferior): Add
3617         process_stratum_target parameter.  Pass it down.
3618         * nat/fork-inferior.h (startup_inferior): Add
3619         process_stratum_target parameter.
3620         * python/py-threadevent.c (py_get_event_thread): Pass target down.
3621
3622 2020-01-10  Pedro Alves  <palves@redhat.com>
3623
3624         * remote.c (remote_target::start_remote): Don't set inferior_ptid
3625         directly.  Instead find the first thread in the thread list and
3626         use switch_to_thread.
3627
3628 2020-01-10  Pedro Alves  <palves@redhat.com>
3629
3630         * remote.c (remote_target::remote_add_inferior): Don't bind a
3631         process to the current inferior if the current inferior is already
3632         bound to a process.
3633
3634 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3635             Pedro Alves  <palves@redhat.com>
3636
3637         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
3638         If no process is specified, return null_ptid instead of
3639         inferior_ptid.
3640         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
3641         TARGET_WAITKIND_SIGNALLED with no pid.
3642
3643 2020-01-10  Pedro Alves  <palves@redhat.com>
3644
3645         * remote.c (first_remote_resumed_thread): New.
3646         (remote_target::wait_as): Use it as default event_ptid instead of
3647         inferior_ptid.
3648
3649 2020-01-10  Pedro Alves  <palves@redhat.com>
3650
3651         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
3652
3653 2020-01-10  Pedro Alves  <palves@redhat.com>
3654
3655         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
3656         not -1.
3657
3658 2020-01-10  Pedro Alves  <palves@redhat.com>
3659
3660         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
3661         ptid to get_last_target_status.
3662         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
3663         ptid to get_last_target_status.
3664         * infcmd.c (continue_command): Don't pass a target_waitstatus to
3665         get_last_target_status.
3666         (info_program_command): Don't pass a target_waitstatus to
3667         get_last_target_status.
3668         * infrun.c (init_wait_for_inferior): Use
3669         nullify_last_target_wait_ptid.
3670         (get_last_target_status): Handle nullptr arguments.
3671         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
3672         (print_stop_event): Don't pass a ptid to get_last_target_status.
3673         (normal_stop): Don't pass a ptid to get_last_target_status.
3674         * infrun.h (get_last_target_status, set_last_target_status): Move
3675         comments here and update.
3676         (nullify_last_target_wait_ptid): Declare.
3677         * linux-fork.c (fork_load_infrun_state): Remove local extern
3678         declaration of nullify_last_target_wait_ptid.
3679         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
3680         to get_last_target_status.
3681
3682 2020-01-10  Pedro Alves  <palves@redhat.com>
3683
3684         * gdbthread.h (scoped_restore_current_thread)
3685         <dont_restore, restore, m_dont_restore>: Declare.
3686         * thread.c (thread_alive): Add assertion.  Return bool.
3687         (switch_to_thread_if_alive): New.
3688         (prune_threads): Switch inferior/thread.
3689         (print_thread_info_1): Switch thread before calling target methods.
3690         (scoped_restore_current_thread::restore): New, factored out from
3691         ...
3692         (scoped_restore_current_thread::~scoped_restore_current_thread):
3693         ... this.
3694         (scoped_restore_current_thread::scoped_restore_current_thread):
3695         Add assertion.
3696         (thread_apply_all_command, thread_select): Use
3697         switch_to_thread_if_alive.
3698         * infrun.c (proceed, restart_threads, handle_signal_stop)
3699         (switch_back_to_stepped_thread): Switch current thread before
3700         calling target methods.
3701
3702 2020-01-10  Pedro Alves <palves@redhat.com>
3703
3704         * inferior.c (switch_to_inferior_no_thread): New function,
3705         factored out from ...
3706         (inferior_command): ... here.
3707         * inferior.h (switch_to_inferior_no_thread): Declare.
3708         * mi/mi-main.c (run_one_inferior): Use
3709         switch_to_inferior_no_thread.
3710
3711 2020-01-10  Pedro Alves  <palves@redhat.com>
3712
3713         * infcmd.c (kill_command): Remove dead code.
3714
3715 2020-01-10  Pedro Alves  <palves@redhat.com>
3716
3717         * remote.c (remote_target::mourn_inferior): No longer check
3718         whether the target is running.
3719
3720 2020-01-10  Pedro Alves  <palves@redhat.com>
3721
3722         * corelow.c (core_target::has_execution): Change parameter type to
3723         inferior pointer.
3724         * inferior.c (number_of_live_inferiors): Use
3725         inferior::has_execution instead of target_has_execution_1.
3726         * inferior.h (inferior::has_execution): New.
3727         * linux-thread-db.c (thread_db_target::update_thread_list): Use
3728         inferior::has_execution instead of target_has_execution_1.
3729         * process-stratum-target.c
3730         (process_stratum_target::has_execution): Change parameter type to
3731         inferior pointer.  Check the inferior's PID instead of
3732         inferior_ptid.
3733         * process-stratum-target.h
3734         (process_stratum_target::has_execution): Change parameter type to
3735         inferior pointer.
3736         * record-full.c (record_full_core_target::has_execution): Change
3737         parameter type to inferior pointer.
3738         * target.c (target_has_execution_1): Change parameter type to
3739         inferior pointer.
3740         (target_has_execution_current): Adjust.
3741         * target.h (target_ops::has_execution): Change parameter type to
3742         inferior pointer.
3743         (target_has_execution_1): Change parameter type to inferior
3744         pointer.  Change return type to bool.
3745         * tracefile.h (tracefile_target::has_execution): Change parameter
3746         type to inferior pointer.
3747
3748 2020-01-10  Pedro Alves  <palves@redhat.com>
3749
3750         * exceptions.c (print_flush): Remove current_top_target() check.
3751
3752 2020-01-10  Pedro Alves  <palves@redhat.com>
3753
3754         * remote.c (show_remote_exec_file): Show the current inferior's
3755         exec-file instead of the command variable's value.
3756
3757 2020-01-10  Pedro Alves  <palves@redhat.com>
3758
3759         * record-full.c (record_full_resume_ptid): New global.
3760         (record_full_target::resume): Set it.
3761         (record_full_wait_1): Use record_full_resume_ptid instead of
3762         inferior_ptid.
3763
3764 2020-01-10  Pedro Alves  <palves@redhat.com>
3765
3766         * gdbthread.h (scoped_restore_current_thread)
3767         <dont_restore, restore, m_dont_restore>: Declare.
3768         * thread.c (thread_alive): Add assertion.  Return bool.
3769         (switch_to_thread_if_alive): New.
3770         (prune_threads): Switch inferior/thread.
3771         (print_thread_info_1): Switch thread before calling target methods.
3772         (scoped_restore_current_thread::restore): New, factored out from
3773         ...
3774         (scoped_restore_current_thread::~scoped_restore_current_thread):
3775         ... this.
3776         (scoped_restore_current_thread::scoped_restore_current_thread):
3777         Add assertion.
3778         (thread_apply_all_command, thread_select): Use
3779         switch_to_thread_if_alive.
3780
3781 2020-01-10  George Barrett  <bob@bob131.so>
3782
3783         * stap-probe.c (stap_modify_semaphore): Don't check for null
3784         semaphores.
3785         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
3786         for null semaphores.
3787
3788 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3789
3790         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
3791         all source windows, and maintain horizontal scroll status while
3792         doing so.
3793
3794 2020-01-09  Tom Tromey  <tom@tromey.com>
3795
3796         PR tui/18932:
3797         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
3798         update_source_window, not print_source_lines.
3799
3800 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         * tui/tui.c (tui_enable): Register tui hooks after calling
3803         tui_display_main.
3804
3805 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3806
3807         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
3808
3809 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
3810
3811         * thread.c (print_thread_info_1): Fix indentation.
3812
3813 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3814
3815         * symtab.c (general_symbol_info::compute_and_set_names): Move the
3816         unique_xmalloc_ptr outside the if to always free the demangled name.
3817
3818 2020-01-08  Tom Tromey  <tromey@adacore.com>
3819
3820         * xcoffread.c (enter_line_range, read_xcoff_symtab)
3821         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
3822         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
3823         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
3824         Remove.
3825         (section_offsets): New typedef.
3826         * symtab.c (fixup_section, get_msymbol_address): Update.
3827         * symmisc.c (dump_msymbols): Update.
3828         * symfile.h (relative_addr_info_to_section_offsets)
3829         (symfile_map_offsets_to_segments): Update.
3830         * symfile.c (build_section_addr_info_from_objfile)
3831         (init_objfile_sect_indices): Update.
3832         (struct place_section_arg): Change type of "offsets".
3833         (place_section): Update.
3834         (relative_addr_info_to_section_offsets): Change type of
3835         "section_offsets".  Remove "num_sections" parameter.
3836         (default_symfile_offsets, syms_from_objfile_1)
3837         (set_objfile_default_section_offset): Update.
3838         (reread_symbols): No need to preserve section offsets by hand.
3839         (symfile_map_offsets_to_segments): Change type of "offsets".
3840         * stap-probe.c (relocate_address): Update.
3841         * stabsread.h (process_one_symbol): Update.
3842         * solib-target.c (struct lm_info_target) <offsets>: Change type.
3843         (solib_target_relocate_section_addresses): Update.
3844         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
3845         Update.
3846         * solib-frv.c (frv_relocate_main_executable): Update.
3847         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
3848         * solib-aix.c (solib_aix_get_section_offsets): Change return
3849         type.
3850         (solib_aix_solib_create_inferior_hook): Update.
3851         * remote.c (remote_target::get_offsets): Update.
3852         * psymtab.c (find_pc_sect_psymtab): Update.
3853         * psympriv.h (struct partial_symbol) <address, text_low,
3854         text_high>: Update.
3855         * objfiles.h (obj_section_offset): Update.
3856         (struct objfile) <section_offsets>: Change type.
3857         <num_sections>: Remove.
3858         (objfile_relocate): Update.
3859         * objfiles.c (entry_point_address_query): Update
3860         (relocate_one_symbol): Change type of "section_offsets".
3861         (objfile_relocate1, objfile_relocate1): Change type of
3862         "new_offsets".
3863         (objfile_rebase1): Update.
3864         * mipsread.c (mipscoff_symfile_read): Update.
3865         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
3866         parameter.
3867         * mdebugread.c (parse_symbol): Change type of "section_offsets".
3868         (parse_external, psymtab_to_symtab_1): Update.
3869         * machoread.c (macho_symfile_offsets): Update.
3870         * ia64-tdep.c (ia64_find_unwind_table): Update.
3871         * hppa-tdep.c (read_unwind_info): Update.
3872         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
3873         * dwarf2read.c (create_addrmap_from_index)
3874         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3875         (process_psymtab_comp_unit_reader, add_partial_symbol)
3876         (add_partial_subprogram, process_full_comp_unit)
3877         (read_file_scope, read_func_scope, read_lexical_block_scope)
3878         (read_call_site_scope, dwarf2_rnglists_process)
3879         (dwarf2_ranges_process, dwarf2_ranges_read)
3880         (dwarf_decode_lines_1, var_decode_location, new_symbol)
3881         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
3882         Update.
3883         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
3884         Update.
3885         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
3886         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
3887         (process_one_symbol): Change type of "section_offsets".
3888         * ctfread.c (get_objfile_text_range): Update.
3889         * coffread.c (coff_symtab_read, enter_linenos)
3890         (process_coff_symbol): Update.
3891         * coff-pe-read.c (add_pe_forwarded_sym): Update.
3892         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
3893
3894 2020-01-08  Tom Tromey  <tromey@adacore.com>
3895
3896         * dwarf2read.c (parse_macro_definition): Use std::string.
3897         (parse_macro_definition): Likewise.
3898
3899 2020-01-08  Tom Tromey  <tromey@adacore.com>
3900
3901         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
3902         (ATTR_ALLOC_CHUNK): Remove.
3903
3904 2020-01-08  Tom Tromey  <tromey@adacore.com>
3905
3906         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
3907
3908 2020-01-08  Tom Tromey  <tromey@adacore.com>
3909
3910         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
3911         (dwarf2_compute_name, open_dwo_file): Likewise.
3912         (process_enumeration_scope): Use std::vector.
3913         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
3914         (partial_die_info::fixup, dwarf2_start_subfile)
3915         (guess_full_die_structure_name, dwarf2_name): Likewise.
3916         (determine_prefix): Update.
3917         (guess_full_die_structure_name): Make return type const.
3918         (partial_die_full_name): Return unique_xmalloc_ptr.
3919         (DW_FIELD_ALLOC_CHUNK): Remove.
3920
3921 2020-01-07  Tom Tromey  <tromey@adacore.com>
3922
3923         PR build/24937:
3924         * stap-probe.c (class stap_static_probe_ops): Add constructor.
3925
3926 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3927
3928         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
3929
3930 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3931
3932         * stack.c (print_frame_info): Move disassemble_next_line code
3933         inside source_print block.
3934
3935 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3936
3937         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
3938         gdb/signals.h, as we are now using native signal symbols.
3939
3940 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3941
3942         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
3943         overflow by an early check of content vs threshold.
3944         * tui/tui-source.c (tui_source_window::line_is_displayed):
3945         Likewise.
3946
3947 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3948
3949         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
3950
3951 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3952
3953         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
3954         export table if no section contains it's RVA.
3955
3956 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3957
3958         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
3959
3960 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
3961
3962         * source.c (print_source_lines_base): Set last_line_listed.
3963
3964 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3965
3966         * tui/tui-disasm.c: Remove trailing spaces.
3967
3968 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3969             Pedro Alves  <palves@redhat.com>
3970
3971         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
3972         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
3973         (windows_gdb_signal_to_target): New function, uses the above
3974         enumeration to convert GDB internal signal codes to equivalent
3975         Windows codes.
3976         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
3977         * windows-nat.c: Include "gdb_wait.h".
3978         (get_windows_debug_event): Extract the fatal exception from the
3979         exit status and convert to the equivalent Posix signal number.
3980         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
3981         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
3982         * gdbsupport/gdb_wait.c: New file, implements
3983         windows_status_to_termsig.
3984         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
3985         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
3986
3987 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3988
3989         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
3990         show_layout.
3991
3992 2020-01-05  Luis Machado  <luis.machado@linaro.org>
3993
3994         * aarch64-linux-nat.c
3995         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
3996         and bfd_mach_aarch64.
3997
3998 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3999
4000         * ui-file.c (stdio_file::can_emit_style_escape)
4001         (tee_file::can_emit_style_escape): Ensure style is used also on
4002         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
4003         to gdb_stdout.
4004         * main.c (set_gdb_data_directory): Use file style to output the
4005         warning that the given pathname is not a directory.
4006         * top.c (show_history_filename, gdb_safe_append_history)
4007         (show_gdb_datadir): Use file style.
4008
4009 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4010
4011         * solib-target.c (struct lm_info_target):
4012         Change offsets to be a unique_xmalloc_ptr.
4013         (solib_target_relocate_section_addresses): Update.
4014
4015 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
4016
4017         * windows-nat.c (windows_clear_solib): Free so_list linked list.
4018
4019 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4020
4021         * MAINTAINERS (Write After Approval): Add myself.
4022
4023 2020-01-02  Luis Machado  <luis.machado@linaro.org>
4024
4025         * proc-service.c (get_ps_regcache): Remove reference to obsolete
4026         Cell BE architecture.
4027         * target.h (struct target_ops) <thread_architecture>: Likewise.
4028
4029 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4030
4031         * Makefile.in: Use INSTALL_PROGRAM_ENV.
4032
4033 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
4034
4035         * MAINTAINERS (Write After Approval): Add myself.
4036
4037 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4038
4039         * gdbarch.sh: Update copyright year range of generated files.
4040
4041 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4042
4043         Update copyright year range in all GDB files.
4044
4045 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4046
4047         * copyright.py: Convert to Python 3.
4048
4049 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4050
4051         * copyright.py: Adapt after move of gnulib directory from gdb
4052         directory to toplevel directory.
4053
4054 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4055
4056         * copyright.py (main): Exit if run from the wrong directory.
4057
4058 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4059
4060         * top.c (print_gdb_version): Change copyright year to 2020.
4061
4062 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
4063
4064         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
4065
4066 For older changes see ChangeLog-2019.
4067 \f
4068 Local Variables:
4069 mode: change-log
4070 left-margin: 8
4071 fill-column: 74
4072 version-control: never
4073 coding: utf-8
4074 End: