gdb/ChangeLog

   1 2019-06-14  Tom Tromey  <tromey@adacore.com>
   2
   3         PR gdb/24502:
   4         * ui-style.h (skip_ansi_escape): Update comment.
   5         * ui-file.h (class no_terminal_escape_file): New class.
   6         * ui-file.c (no_terminal_escape_file::write)
   7         (no_terminal_escape_file::puts): New methods.
   8         * cli/cli-logging.c (handle_redirections): Use
   9         no_terminal_escape_file.
  10
  11 2019-06-14  Tom Tromey  <tromey@adacore.com>
  12
  13         * NEWS: Move convenience variable news above Python news.
  14
  15 2019-06-14  Tom Tromey  <tom@tromey.com>
  16
  17         * gnulib: Move directory to top-level.
  18         * configure.ac: Don't configure gnulib.
  19         * configure: Rebuild.
  20         * common/common-defs.h: Use new path to gnulib.
  21         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
  22         (GNULIB_H): Remove.
  23         (INCGNU): Look in new gnulib location.
  24         (HFILES_NO_SRCDIR): Remove gnulib files.
  25         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
  26         (generated_files): Remove GNULIB_H.
  27         ($(LIBGNU), all-lib): Remove targets.
  28         (distclean): Don't mention GNULIB_BUILDDIR.
  29         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
  30
  31 2019-06-14  Tom Tromey  <tromey@adacore.com>
  32
  33         * symfile.c (add_symbol_file_command): Remove obsolete comment.
  34         Warn if symbol file does not provide any symbols.
  35
  36 2019-06-14  Tom Tromey  <tromey@adacore.com>
  37
  38         * source.c (find_and_open_source): Respect basenames_may_differ.
  39
  40 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
  41
  42         * annotate.c (annotate_breakpoints_invalid): Make use of
  43         scoped_restore_terminal_state.
  44         (annotate_frames_invalid): Likewise.
  45
  46 2019-06-14  Tom Tromey  <tromey@adacore.com>
  47
  48         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
  49         allow assignment to an internalvar.
  50
  51 2019-06-14  Tom Tromey  <tromey@adacore.com>
  52
  53         * ada-lex.l: Allow "_" in attribute names.
  54
  55 2019-06-14  Tom Tromey  <tromey@adacore.com>
  56
  57         PR gdb/24653:
  58         * regcache.c (registers_changed): Don't call alloca.
  59         * top.c (execute_command): Don't call alloca.
  60
  61 2019-06-13  Pedro Alves  <palves@redhat.com>
  62
  63         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
  64         'expression'.  When parsing an expression, error out if there's
  65         junk after "unlimited".
  66         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  67         (do_set_command): Adjust calls to is_unlimited_literal.
  68
  69 2019-06-13  Pedro Alves  <palves@redhat.com>
  70
  71         * compile/compile.c (make_compile_options_def_group): Add braces
  72         around array_view initializer.
  73         * thread.c (make_thread_apply_all_options_def_group)
  74         (make_thread_apply_all_options_def_group): Likewise.
  75
  76 2019-06-13  Pedro Alves  <palves@redhat.com>
  77
  78         * NEWS (New commands): Mention "maint test-options
  79         require-delimiter", "maint test-options unknown-is-error", "maint
  80         test-options unknown-is-operand" and "maint show
  81         test-options-completion-result".
  82         (New command options, command completion): New section.
  83         (Completion improvements): New section.
  84         Mention that you can abbreviate "unlimited".
  85
  86 2019-06-13  Pedro Alves  <palves@redhat.com>
  87
  88         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
  89         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
  90         * unittests/cli-utils-selftests.c (test_parse_flags)
  91         (test_parse_flags_qcs): Delete.
  92         (test_cli_utils): Don't call deleted functions.
  93
  94 2019-06-13  Pedro Alves  <palves@redhat.com>
  95
  96         * thread.c: Include "cli/cli-option.h".
  97         (tp_array_compar_ascending): Global.
  98         (tp_array_compar): Delete function.
  99         (tp_array_compar_ascending, tp_array_compar_descending): New
 100         functions.
 101         (ascending_option_def, qcs_flag_option_def)
 102         (thr_qcs_flags_option_defs)
 103         (make_thread_apply_all_options_def_group)
 104         (make_thread_apply_options_def_group): New.
 105         (thread_apply_all_command): Use gdb::option::process_options.
 106         (thread_apply_command_completer)
 107         (thread_apply_all_command_completer): New.
 108         (thread_apply_command): Use gdb::option::process_options.
 109         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 110         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 111         to generate help text of "thread apply".  Adjust "taas"'s help.
 112         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 113         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 114
 115 2019-06-13  Pedro Alves  <palves@redhat.com>
 116
 117         * thread.c (thread_apply_command): Check for invalid TID with
 118         isdigit instead of !isalpha.
 119
 120 2019-06-13  Pedro Alves  <palves@redhat.com>
 121
 122         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 123         (validate_flags_qcs): New.
 124         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 125         (validate_flags_qcs): Declare.
 126         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 127         (make_frame_apply_options_def_group): New.
 128         (frame_apply_command_count): Process options with
 129         gdb::option::process_options.
 130         (frame_apply_completer): New.
 131         (frame_apply_level_completer, frame_apply_all_completer)
 132         (frame_apply_completer): New.
 133         (_initialize_stack): Update help of "frame apply", "frame apply
 134         level", "frame apply all" and "faas" to mention supported options
 135         and install command completers.
 136         * stack.h (frame_apply_all_completer): Declare.
 137         * thread.c: Include "stack.h".
 138         (tfaas_command): Add "--".
 139         (_initialize_thread): Update help "tfaas" to mention supported
 140         options and install command completer.
 141
 142 2019-06-13  Pedro Alves  <palves@redhat.com>
 143
 144         * completer.c (complete_nested_command_line): New.
 145         (gdb_completion_word_break_characters_throw): Add assertion.
 146         * completer.h (complete_nested_command_line): Declare.
 147
 148 2019-06-13  Pedro Alves  <palves@redhat.com>
 149
 150         * stack.c (parse_backtrace_qualifiers): New.
 151         (backtrace_command): Use it.
 152         (backtrace_command_completer): Complete on qualifiers.
 153
 154 2019-06-13  Pedro Alves  <palves@redhat.com>
 155
 156         * frame.c: Include "cli/cli-option.h.
 157         (user_set_backtrace_options): New.
 158         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 159         Delete.
 160         (get_prev_frame): Adjust.
 161         (boolean_option_def, uinteger_option_def)
 162         (set_backtrace_option_defs): New.
 163         (_initialize_frame): Adjust and use
 164         gdb::option::add_setshow_cmds_for_options to install "set
 165         backtrace past-main" and "set backtrace past-entry".
 166         * frame.h: Include "cli/cli-option.h".
 167         (struct frame_print_options): Forward declare.
 168         (print_frame_arguments_all, print_frame_arguments_scalars)
 169         (print_frame_arguments_none): Declare.
 170         (print_entry_values): Delete declaration.
 171         (struct frame_print_options, user_frame_print_options): New.
 172         (struct set_backtrace_options): New.
 173         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 174         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 175         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 176         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 177         (list_args_or_locals): Add frame_print_options parameter.
 178         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 179         * python/py-framefilter.c (enumerate_args): Pass down
 180         USER_FRAME_PRINT_OPTIONS.
 181         * stack.c: Include "cli/cli-option.h".
 182         (print_frame_arguments_all, print_frame_arguments_scalars)
 183         (print_frame_arguments_none): Declare.
 184         (print_raw_frame_arguments, print_entry_values): Delete.
 185         (user_frame_print_options): New.
 186         (boolean_option_def, enum_option_def, frame_print_option_defs):
 187         New.
 188         (struct backtrace_cmd_options): New.
 189         (bt_flag_option_def): New.
 190         (backtrace_command_option_defs): New.
 191         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 192         (print_frame_arg, read_frame_arg, print_frame_args)
 193         (print_frame_info, print_frame): Add frame_print_options parameter
 194         and use it.
 195         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 196         (backtrace_command_1): Add frame_print_options and
 197         backtrace_cmd_options parameters and use them.
 198         (make_backtrace_options_def_group): New.
 199         (backtrace_command): Process command options with
 200         gdb::option::process_options.
 201         (backtrace_command_completer): New.
 202         (_initialize_stack): Extend "backtrace"'s help to mention
 203         supported options.  Install completer for "backtrace".
 204         Install some settings commands with add_setshow_cmds_for_options.
 205
 206 2019-06-13  Pedro Alves  <palves@redhat.com>
 207
 208         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 209         and that "set/show print raw frame-arguments" are now deprecated.
 210
 211         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 212         command.
 213         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 214         * stack.c (_initialize_stack): Install "set/show print
 215         raw-frame-arguments", and deprecate "set/show print raw
 216         frame-arguments".
 217         * valprint.c (_initialize_valprint): Deprecate "set/show print
 218         raw".
 219
 220 2019-06-13  Pedro Alves  <palves@redhat.com>
 221
 222         * compile/compile.c (struct compile_options): New.
 223         (compile_flag_option_def, compile_command_option_defs)
 224         (make_compile_options_def_group): New.
 225         (compile_file_command): Handle options with
 226         gdb::option::process_options.
 227         (compile_file_command_completer): New function.
 228         (compile_code_command): Handle options with
 229         gdb::option::process_options.
 230         (compile_code_command_completer): New function.
 231         (_initialize_compiler): Install completers for "compile code" and
 232         "compile file".  Mention available options in "compile code" and
 233         "compile code"'s help.
 234         * completer.c (advance_to_completion_word): New, factored out from
 235         ...
 236         (advance_to_expression_complete_word_point): ... this.
 237         (advance_to_filename_complete_word_point): New.
 238         * completer.h (advance_to_filename_complete_word_point): New
 239         declaration.
 240
 241 2019-06-13  Pedro Alves  <palves@redhat.com>
 242
 243         * compile/compile.c: Include "cli/cli-option.h".
 244         (compile_print_value): Scope data pointer is now a
 245         value_print_options pointer; adjust.
 246         (compile_print_command): Process options.  Scope data pointer is
 247         now a value_print_options pointer; adjust.
 248         (_initialize_compile): Update "compile print"'s help to include
 249         supported options.  Install a completer for "compile print".
 250         * cp-valprint.c (show_vtblprint, show_objectprint)
 251         (show_static_field_print): Delete.
 252         (_initialize_cp_valprint): Don't install "set print
 253         static-members", "set print vtbl", "set print object" here.
 254         * printcmd.c: Include "cli/cli-option.h" and
 255         "common/gdb_optional.h".
 256         (print_command_parse_format): Rework to fill in a
 257         value_print_options instead of a format_data.
 258         (print_value): Change parameter type from format_data pointer to
 259         value_print_options reference.  Adjust.
 260         (print_command_1): Process options.  Adjust to pass down a
 261         value_print_options.
 262         (print_command_completer): New.
 263         (_initialize_printcmd): Install print_command_completer as
 264         handle_brkchars completer for the "print" command.  Update
 265         "print"'s help to include supported options.
 266         * valprint.c: Include "cli/cli-option.h".
 267         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 268         here from cp-valprint.c.
 269         (boolean_option_def, uinteger_option_def)
 270         (value_print_option_defs, make_value_print_options_def_group):
 271         New.  Use gdb::option::add_setshow_cmds_for_options to install
 272         "set print elements", "set print null-stop", "set print repeats",
 273         "set print pretty", "set print union", "set print array", "set
 274         print address", "set print symbol", "set print array-indexes".
 275         * valprint.h: Include <string> and "cli/cli-option.h".
 276         (make_value_print_options_def_group): Declare.
 277         (print_value): Change parameter type from format_data pointer to
 278         value_print_options reference.
 279         (print_command_completer): Declare.
 280
 281 2019-06-13  Pedro Alves  <palves@redhat.com>
 282
 283         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 284         (COMMON_SFILES): Add maint-test-settings.c.
 285         * cli/cli-decode.c (boolean_enums): New global, factored out from
 286         ...
 287         (add_setshow_boolean_cmd): ... here.
 288         * cli/cli-decode.h (boolean_enums): Declare.
 289         * cli/cli-option.c: New file.
 290         * cli/cli-option.h: New file.
 291         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 292         factored out from ...
 293         (parse_cli_boolean_value(const char *)): ... this.
 294         (is_unlimited_literal): Change parameter type to pointer to
 295         pointer.  Adjust and advance ARG pointer.
 296         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 297         (parse_cli_var_enum): New, factored out from ...
 298         (do_set_command): ... this.  Adjust.
 299         * cli/cli-setshow.h (parse_cli_boolean_value)
 300         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 301         (parse_cli_var_enum): Declare.
 302         * cli/cli-utils.c: Include "cli/cli-option.h".
 303         (get_ulongest): New.
 304         * cli/cli-utils.h (get_ulongest): Declare.
 305         (check_for_argument): New overloads.
 306         * maint-test-options.c: New file.
 307
 308 2019-06-13  Pedro Alves  <palves@redhat.com>
 309
 310         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 311         parse a range if "-" is at the end of the string.
 312
 313 2019-06-13  Pedro Alves  <palves@redhat.com>
 314
 315         * cli/cli-setshow.c (parse_auto_binary_operation)
 316         (parse_cli_boolean_value): Don't allow "o".
 317
 318 2019-06-13  Pedro Alves  <palves@redhat.com>
 319
 320         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 321         * NEWS: Mention maint test-settings KIND.
 322         * maint-test-settings.c: New file.
 323
 324 2019-06-13  Pedro Alves  <palves@redhat.com>
 325
 326         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 327         completer.
 328         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 329         "set" completers.
 330
 331 2019-06-13  Pedro Alves  <palves@redhat.com>
 332
 333         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 334         after item.
 335
 336 2019-06-13  Pedro Alves  <palves@redhat.com>
 337
 338         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 339
 340 2019-06-13  Pedro Alves <palves@redhat.com>
 341
 342         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 343         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 344         call.
 345         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 346         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 347         calls.
 348         (check_for_argument): Skip spaces after argument.
 349
 350 2019-06-13  Pedro Alves  <palves@redhat.com>
 351
 352         * thread.c (thread_apply_command): Adjust TID parsing.
 353         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 354         detected before end of string.
 355         (tid_is_in_list): Error out if LIST is invalid.
 356
 357 2019-06-13  Pedro Alves  <palves@redhat.com>
 358
 359         * completer.c (complete_line_internal_1): Rewind completion word
 360         point.
 361         (completion_tracker::advance_custom_word_point_by): Change
 362         parameter type to int.
 363         * completer.h (completion_tracker::advance_custom_word_point_by):
 364         Likewise.
 365
 366 2019-06-13  Pedro Alves  <palves@redhat.com>
 367
 368         * completer.c (advance_to_completion_word): Handle delimiters.
 369
 370 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 371
 372         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 373
 374 2019-06-11  Tom Tromey  <tom@tromey.com>
 375
 376         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 377         (xmalloc_failed): Move to alloc.c.
 378         * alloc.c: New file.
 379         * Makefile.in (COMMON_SFILES): Add alloc.c.
 380
 381 2019-06-11  Tom Tromey  <tom@tromey.com>
 382
 383         * nat/linux-waitpid.c: Don't include server.h.
 384         (linux_debug): Remove.
 385         (my_waitpid): Update.
 386
 387 2019-06-11  Tom Tromey  <tromey@adacore.com>
 388
 389         * infcall.c (_initialize_infcall): Remove trailing newline from
 390         help.
 391         * user-regs.c (_initialize_user_regs): Remove trailing newline
 392         from help.
 393         * typeprint.c (_initialize_typeprint): Remove trailing newline
 394         from help.
 395         * reverse.c (_initialize_reverse): Remove trailing newlines from
 396         help.
 397         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 398         from help.
 399         * language.c (add_set_language_command): Remove trailing newline
 400         from help.
 401         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 402         help.
 403         * disasm.c (_initialize_disasm): Remove trailing newline from
 404         help.
 405         * top.c (init_main): Remove trailing newline from help.
 406         * interps.c (_initialize_interpreter): Remove trailing newline
 407         from help.
 408         * btrace.c (_initialize_btrace): Remove trailing newlines from
 409         help.
 410         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 411         from help.
 412         * python/python.c (_initialize_python): Remove trailing newline
 413         from help.
 414         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 415         help.
 416         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 417         from help.  Reformat some text.
 418         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 419         from help.
 420         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 421         newline from help.
 422
 423 2019-06-11  Tom Tromey  <tromey@adacore.com>
 424
 425         * darwin-nat.c (darwin_decode_exception_message)
 426         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 427
 428 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * valops.c (value_slice): Check for not allocated or not
 431         associated values.
 432
 433 2019-06-10  Tom de Vries  <tdevries@suse.de>
 434
 435         PR gdb/24618
 436         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 437         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 438         invalid.
 439
 440 2019-06-10  Tom de Vries  <tdevries@suse.de>
 441
 442         PR gdb/24611
 443         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 444         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 445
 446 2019-06-10  Tom de Vries  <tdevries@suse.de>
 447
 448         PR symtab/24545
 449         * symtab.c (struct demangled_name_entry): Add language field.
 450         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 451         static minimal symbol".  Set and use language field.
 452
 453 2019-06-10  Tom Tromey  <tromey@adacore.com>
 454
 455         * ada-lang.c (_initialize_ada_language): Update help text.
 456
 457 2019-06-10  Tom Tromey  <tromey@adacore.com>
 458
 459         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 460         with a newline.
 461         * guile/guile.c (handle_boot_error): Don't end warning with a
 462         newline.
 463         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 464         warning with a newline.
 465         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 466         newline.
 467         (s12z_frame_cache): Likewise.
 468         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 469         a newline.
 470         * solib-svr4.c (disable_probes_interface): Don't end warning with
 471         a newline.
 472         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 473         newline.
 474         * python/python.c (do_finish_initialization): Don't end warning
 475         with a newline.
 476
 477 2019-06-10  Tom Tromey  <tom@tromey.com>
 478
 479         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 480         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 481         gdbpy_enter.
 482
 483 2019-06-10  Tom Tromey  <tromey@adacore.com>
 484
 485         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 486         data.
 487         (elf_new_init): Don't call stabsread_new_init.
 488         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 489         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 490         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 491
 492 2019-06-10  Tom de Vries  <tdevries@suse.de>
 493
 494         PR symtab/16264
 495         PR symtab/24517
 496         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 497
 498 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 499
 500         * source.c (find_and_open_source): Also rewrite relative file
 501         names.
 502
 503 2019-04-26  Amos Bird  <amosbird@gmail.com>
 504
 505         * annotate.c (annotate_thread_exited): Add "thread-exited"
 506         annotation.
 507
 508 2019-06-06  Tom Tromey  <tromey@adacore.com>
 509
 510         * maint.h (class scoped_command_stats): Use
 511         DISABLE_COPY_AND_ASSIGN.
 512         <print_time>: New method.
 513         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 514         print_time.
 515         (scoped_command_stats::print_time): New method.
 516
 517 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 518
 519         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 520         instructions of lengths 6 or 8 bytes.
 521
 522 2019-06-04  Pedro Alves  <palves@redhat.com>
 523
 524         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 525
 526         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 527         * breakpoint.c (condition_completer): Likewise.
 528         * cli/cli-dump.c (scan_expression): Likewise.
 529         * common/filestuff.c (mkdir_recursive): Likewise.
 530         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 531         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 532         (gdb_abspath): Likewise.
 533         * compile/compile-cplus-types.c
 534         (compile_cplus_instance::decl_name): Likewise.
 535         * completer.c (complete_explicit_location):
 536         (signal_completer, reg_or_group_completer_1): Likewise.
 537         * cp-support.c (cp_remove_params_if_any): Likewise.
 538         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 539         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 540         * infcmd.c (strip_bg_char): Likewise.
 541         * linespec.c (copy_token_string): Likewise.
 542         * mi/mi-main.c (output_cores): Likewise.
 543         * psymtab.c (psymtab_search_name):
 544         * symfile.c (test_set_ext_lang_command): Likewise.
 545         * target.c (target_fileio_read_stralloc): Likewise.
 546         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 547         * value.c (complete_internalvar): Likewise.
 548
 549 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 550
 551         Add objfile property to gdb.Type.
 552         * NEWS: Mention Python API addition.
 553         * python/py-type.c (typy_get_objfile): New method.
 554
 555 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 556
 557         * NEWS: Mention the new set|show style [title|highlight].
 558         Mention changes to "show style", "help" and "apropos".
 559
 560 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 561
 562         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 563         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 564         instead of print_help_for_command.
 565         (print_doc_of_command): New function.
 566         (help_list): Add 'apropos -v word' suggestion.
 567         (print_help_for_command): Style the command name using title style.
 568         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 569         (_initialize_cli_cmds): Describe -v in apropos_command help.
 570
 571 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 572
 573         * cli/cli-style.h (cli_style_option): Add name in constructor,
 574         add m_name class member, add constructor with intensity,
 575         add name class function.
 576         (cli_style_option::add_setshow_commands): Remove name argument.
 577         (highlight_style, title_style): New styles.
 578         * cli/cli-style.c (do_show): New function that shows a style
 579         characteristic styling the style name with itself.
 580         (set_style_name): New function.
 581         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 582         Update all callers according to the changes in cli/cli-style.h.
 583         * utils.h (fputs_highlighted): New function.
 584         * utils.c (fputs_highlighted): Likewise.
 585
 586 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 587
 588         * NEWS: Mention new pipe command and new convenience variables.
 589
 590 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 591
 592         * cli/cli-cmds.c (pipe_command): New function.
 593         (_initialize_cli_cmds): Call add_com for pipe_command.
 594         Define | as an alias for pipe.
 595         (exit_status_set_internal_vars): New function.
 596         (shell_escape): Call exit_status_set_internal_vars.
 597         cli/cli-decode.c (find_command_name_length): Recognize | as
 598         a single character command.
 599
 600 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 601
 602         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 603         top.c (execute_command_to_ui_file): New function, mostly a copy
 604         of execute_command_to_string.
 605         (execute_command_to_string): Implement by calling
 606         execute_command_to_ui_file.
 607
 608 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 609
 610         * top.h (saved_command_line): Remove declaration.
 611         * top.c (previous_saved_command_line, previous_repeat_arguments):
 612         New variables.
 613         (saved_command_line): Make static, define together with other
 614         'repeat variables'.
 615         (dont_repeat): Clear repeat_arguments.
 616         (repeat_previous, get_saved_command_line, save_command_line):
 617         New functions.
 618         (gdb_init): Initialize saved_command_line
 619         and previous_saved_command_line.
 620         * main.c (captured_main_1): Remove saved_command_line initialization.
 621         * event-top.c (handle_line_of_input): Update to use
 622         the new 'repeat' related functions instead of direct access to
 623         saved_command_line.
 624         * command.h (repeat_previous, get_saved_command_line,
 625         save_command_line): New declarations.
 626         (dont_repeat): Add comment.
 627
 628 2019-05-30  Tom Tromey  <tromey@adacore.com>
 629
 630         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 631         Fix comment.
 632         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 633
 634 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 635
 636         PR cli/24587
 637         * completer.c (complete): Initialize variable word.
 638
 639 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 640
 641         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 642         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 643         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 644         'body' is NULL to the outter 'if', protecting the '!is_define'
 645         situation as well.
 646
 647 2019-05-29  Tom Tromey  <tromey@adacore.com>
 648
 649         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 650         (dwarf_unknown): New function.
 651         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 652         (dwarf_type_encoding_name): Use dwarf_unknown.
 653
 654 2019-05-29  Tom Tromey  <tromey@adacore.com>
 655
 656         PR c++/20020:
 657         * cp-valprint.c (cp_print_value_fields): Call
 658         cp_print_static_field inside "try".
 659
 660 2019-05-29  Tom Tromey  <tromey@adacore.com>
 661
 662         * inflow.c (struct terminal_info): Add default operator=.
 663         * configure: Rebuild.
 664         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 665         -Wdeprecated-copy-dtor, -Wredundant-move.
 666
 667 2019-05-29  Tom Tromey  <tromey@adacore.com>
 668
 669         * NEWS: Add entry.
 670         * infcmd.c (print_return_value_1): Handle finish_print
 671         option.
 672         (show_print_finish): New function.
 673         (_initialize_infcmd): Add "set/show print finish" commands.
 674         * valprint.c (user_print_options): Initialize new member.
 675         * valprint.h (struct value_print_options) <finish_print>: New
 676         member.
 677
 678 2019-05-28  Tom Tromey  <tromey@adacore.com>
 679
 680         * ada-lang.c (ada_remove_Xbn_suffix)
 681         (find_old_style_renaming_symbol)
 682         (parse_old_style_renaming): Remove.
 683         (ada_find_renaming_symbol): Don't call
 684         find_old_style_renaming_symbol.
 685         (ada_is_renaming_symbol): Rename from
 686         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 687         bool.  Now static.
 688         (ada_read_var_value): Update and simplify.
 689         * ada-exp.y (write_var_or_type): Remove old code.
 690
 691 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 692
 693         * event-top.c: Remove include comment.
 694         * inflow.c (class scoped_ignore_sigttou): Move from here...
 695         * inflow.h (class scoped_ignore_sigttou): ...to here.
 696         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 697         * top.c:  Remove include comment.
 698
 699 2019-05-27  Tom Tromey  <tom@tromey.com>
 700
 701         * NEWS: Fix typo.
 702
 703 2019-05-22  Tom Tromey  <tromey@adacore.com>
 704
 705         * target.c (target_follow_exec): Constify parameter.
 706         * target-delegates.c: Rebuild.
 707         * remote.c (remote_target::follow_exec): Constify parameter.
 708         * infrun.c (follow_exec): Constify parameter.
 709         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 710         (target_follow_exec): Likewise.
 711
 712 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 713
 714         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 715         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 716
 717 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 718
 719         * NEWS: Add debugredirect and testsuite sections.
 720
 721 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 722
 723         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 724         target descriptions using exclusively floating point register name
 725         aliases.
 726
 727 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 728
 729         PR gdb/18644:
 730         * f-lang.c (build_fortran_types): Handle the case where
 731         gdbarch_floatformat_for_type returns a nullptr.
 732
 733 2019-05-21  Tom de Vries  <tdevries@suse.de>
 734
 735         PR cli/24587
 736         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 737
 738 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 739
 740         PR gdb/18644:
 741         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 742         16-byte floats.
 743         * i386-tdep.c (i386_floatformat_for_type): Use
 744         floatformats_ia64_quad for the 16-byte floating point component
 745         within a fortran 32-byte complex number.
 746
 747 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 748
 749         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 750         delete default constructor.
 751         (find_partial_die): Update to return const struct.
 752         (partial_die_parent_scope): Move variable declaration into scope
 753         of its use and change its type to auto.
 754         (guess_partial_die_structure_name): Likewise.
 755         (partial_die_info::fixup): Likewise.
 756
 757 2019-05-17  Tom Tromey  <tromey@adacore.com>
 758
 759         * source.c (find_and_open_source): Remove cast.
 760
 761 2019-05-17  Tom Tromey  <tromey@adacore.com>
 762
 763         * annotate.c (annotate_source): Make "filename" const.
 764         * annotate.h (annotate_source): Use const.
 765
 766 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 767
 768         * disasm.c (set_disassembler_options): Send errors to stderr.
 769
 770 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 771
 772         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 773         (cli_interp_base::set_logging): Check debug_redirect.
 774         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 775         * cli/cli-logging.c (debug_redirect): Add static variable.
 776         (pop_output_files): Add default param.
 777         (handle_redirections): Print debug setting.
 778         (show_logging_command): Likewise.
 779         (_initialize_cli_logging): Add debugredirect command.
 780         * interps.c (current_interp_set_logging): Add debug_redirect
 781         parameter.
 782         * interps.h (set_logging): Add debug_redirect parameter.
 783         (current_interp_set_logging): Likewise.
 784         * mi/mi-common.h: Likewise.
 785         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 786
 787 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 788             Tom Tromey  <tromey@adacore.com>
 789
 790         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 791         directly.
 792         * cli/cli-interp.h (make_logging_output): Remove declaration.
 793         * cli/cli-logging.c (make_logging_output): Remove function.
 794         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 795         directly.
 796         * ui-file.c (tee_file::tee_file): Remove bools.
 797         (tee_file::~tee_file): Remove deletes.
 798         * ui-file.h (tee_file): Remove bools.
 799
 800 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 801
 802         * mi/mi-cmds.h (mi_cmd_complete): New function.
 803         * mi/mi-main.c (mi_cmd_complete): Likewise.
 804         * mi/mi-cmds.c: Define new MI command -complete.
 805         * NEWS: Mention new -complete command.
 806
 807 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 808
 809         * completer.h (complete): New function.
 810         * completer.c (complete): Likewise.
 811         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 812         function defined in completer.h.
 813
 814 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 815
 816        * MAINTAINERS (Write After Approval): Add myself.
 817
 818 2019-05-17  Tom de Vries  <tdevries@suse.de>
 819
 820         PR gdb/24094
 821         * dwarf2read.c (struct cu_partial_die_info): New struct.
 822         (find_partial_die): Return cu_partial_die_info.
 823         (partial_die_parent_scope, guess_partial_die_structure_name)
 824         (partial_die_info::fixup): Handle new return type of find_partial_die.
 825
 826 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 827
 828         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 829         "std::string", simplifying the algorithm.
 830
 831 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 832
 833         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 834         (stap_static_probe_ops::get_probes): Likewise.
 835
 836 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 837
 838         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 839         '-')" and "else if".
 840         (stap_parse_single_operand): Join checks for
 841         "gdbarch_stap_parse_special_token_p" and
 842         "gdbarch_stap_parse_special_token" in the same "if" statement.
 843         Invert check when verifying for operation on register
 844         displacement.
 845
 846 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 847
 848         * stap-probe.c (stap_get_opcode): Update comment.
 849         (stap_get_expected_argument_type): Likewise.
 850         (handle_stap_probe): Likewise.
 851
 852 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 853
 854         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 855         return type to 'bool'.  Adjust comment.  Use 'bool' when
 856         appropriate.
 857         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 858         * stap-probe.c (stap_parse_argument_1): Likewise.
 859         (stap_is_operator): Likewise.
 860         (stap_is_generic_prefix): Likewise.
 861         (stap_is_register_prefix): Likewise.
 862         (stap_is_register_indirection_prefix): Likewise.
 863         (stap_is_integer_prefix): Likewise.
 864         (stap_generic_check_suffix): Likewise.
 865         (stap_check_integer_suffix): Likewise.
 866         (stap_check_register_suffix): Likewise.
 867         (stap_check_register_indirection_suffix): Likewise.
 868         (stap_parse_register_operand): Likewise.
 869         (stap_parse_single_operand): Likewise.
 870         (stap_parse_argument_1): Likewise.
 871         (stap_probe::get_argument_count): Likewise.
 872         (stap_is_operator): Likewise.
 873
 874 2019-05-16  Tom Tromey  <tromey@adacore.com>
 875
 876         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 877         keyword to foreach.
 878
 879 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 880
 881         * linux-thread-db.c (try_thread_db_load_1): Change return type
 882         to bool.
 883         (try_thread_db_load): Likewise.
 884         (try_thread_db_load_from_pdir_1): Likewise.
 885         (try_thread_db_load_from_pdir): Likewise.
 886         (try_thread_db_load_from_sdir): Likewise.
 887         (try_thread_db_load_from_dir): Likewise.
 888         (thread_db_load_search): Likewise.
 889         (has_libpthread): Likewise.
 890         (thread_db_load): Likewise.
 891
 892 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 893
 894         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 895         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 896         NULL, and complain/return if that's the case.
 897
 898 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 899
 900         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 901         (advance, posn, abstract_read_memory): New functions.
 902         [struct mem_read_abstraction]: New struct.
 903         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 904
 905 2019-05-14  Tom Tromey  <tromey@adacore.com>
 906
 907         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 908         value is not lval_memory.
 909
 910 2019-05-14  Tom Tromey  <tromey@adacore.com>
 911
 912         * solib.c (info_sharedlibrary_command): Style the file name.
 913
 914 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 915
 916         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 917         (aarch64_vnv_type): Likewise.
 918         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 919         * common/tdesc.c: Likewise.
 920         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 921         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 922         * features/aarch64-fpu.xml: Add ieee half view.
 923         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 924         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 925         * gdbtypes.h (struct builtin_type): Likewise.
 926         (struct objfile_type): Likewise.
 927
 928 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 929
 930         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 931         typo.
 932         * location.h (string_to_event_location): Likewise.
 933
 934 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 935
 936         GDB 8.3 released.
 937
 938 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 939
 940         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 941         New variable declaration.
 942         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 943         New variable.
 944         (print_one_breakpoint): Use ui_out::test_flags and new global
 945         variable to compute use_fixed_output.
 946         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 947         Remove.
 948         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 949         (mi_multi_location_breakpoint_output_fixed): Remove.
 950         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 951         new variable.
 952         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 953         fix_multi_location_breakpoint_output flag if version >= 3.
 954         * ui-out.h (enum ui_out_flag)
 955         <fix_multi_location_breakpoint_output>: New enumerator.
 956
 957 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 958
 959         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 960
 961 2019-05-10  Tom Tromey  <tromey@adacore.com>
 962
 963         * ada-lang.c (catch_ada_completer): New function.
 964         (_initialize_ada_language): Use it.
 965
 966 2019-05-10  Tom Tromey  <tromey@adacore.com>
 967
 968         * thread.c (print_thread_info): Make "requested_threads" const.
 969         * gdbthread.h (print_thread_info): Make "requested_threads"
 970         const.
 971         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 972         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 973
 974 2019-05-08  Tom Tromey  <tom@tromey.com>
 975
 976         * gdbtypes.c (objfile_type_data): Change type.
 977         (objfile_type, _initialize_gdbtypes): Update.
 978
 979 2019-05-08  Tom Tromey  <tom@tromey.com>
 980
 981         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 982         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 983         (_initialize_dwarf2_frame): Update.
 984
 985 2019-05-08  Tom Tromey  <tom@tromey.com>
 986
 987         * objc-lang.c (objc_objfile_data): Change type.
 988         (find_methods): Update.
 989         (_initialize_objc_lang): Remove.
 990
 991 2019-05-08  Tom Tromey  <tom@tromey.com>
 992
 993         * stabsread.c (rs6000_builtin_type_data): Change type.
 994         (rs6000_builtin_type, _initialize_stabsread): Update.
 995
 996 2019-05-08  Tom Tromey  <tom@tromey.com>
 997
 998         * mips-tdep.c (mips_pdr_data): Remove.
 999         (_initialize_mips_tdep): Update.
1000
1001 2019-05-08  Tom Tromey  <tom@tromey.com>
1002
1003         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1004         (hppa_init_objfile_priv_data, read_unwind_info)
1005         (find_unwind_entry, _initialize_hppa_tdep): Update.
1006
1007 2019-05-08  Tom Tromey  <tom@tromey.com>
1008
1009         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1010         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1011         on obstack.
1012         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1013
1014 2019-05-08  Tom Tromey  <tom@tromey.com>
1015
1016         * mdebugread.c (basic_type_data): Change type.
1017         (basic_type, _initialize_mdebugread): Update.
1018
1019 2019-05-08  Tom Tromey  <tom@tromey.com>
1020
1021         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1022
1023 2019-05-08  Tom Tromey  <tom@tromey.com>
1024
1025         * nto-tdep.c (nto_inferior_data_reg): Change type.
1026         (nto_inferior_data): Update.
1027         (nto_inferior_data_cleanup, nto_new_inferior_data)
1028         (_initialize_nto_tdep): Remove.
1029         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1030
1031 2019-05-08  Tom Tromey  <tom@tromey.com>
1032
1033         * ada-lang.c (struct ada_inferior_data): Add initializers.
1034         (ada_inferior_data): Change type.
1035         (ada_inferior_data_cleanup): Remove.
1036         (get_ada_inferior_data, ada_inferior_exit)
1037         (struct ada_pspace_data): Add initializers, destructor.
1038         (ada_pspace_data_handle): Change type.
1039         (get_ada_pspace_data): Update.
1040         (ada_pspace_data_cleanup): Remove.
1041
1042 2019-05-08  Tom Tromey  <tom@tromey.com>
1043
1044         * coffread.c (struct coff_symfile_info): Add initializers.
1045         (coff_objfile_data_key): Move lower.  Change type.
1046         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1047         Update.
1048         (coff_free_info): Remove.
1049
1050 2019-05-08  Tom Tromey  <tom@tromey.com>
1051
1052         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1053         (fbsd_pspace_data_handle): Move lower.  Change type.
1054         (get_fbsd_pspace_data): Update.
1055         (fbsd_pspace_data_cleanup): Remove.
1056         (_initialize_fbsd_tdep): Update.
1057
1058 2019-05-08  Tom Tromey  <tom@tromey.com>
1059
1060         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1061         (get_ada_tasks_pspace_data): Update.
1062         (ada_tasks_pspace_data_cleanup): Remove.
1063         (_initialize_tasks): Update.
1064         (ada_tasks_inferior_data_handle): Change type.
1065         (get_ada_tasks_inferior_data): Update.
1066         (ada_tasks_inferior_data_cleanup): Remove.
1067         (struct ada_tasks_pspace_data): Add initializers.
1068
1069 2019-05-08  Tom Tromey  <tom@tromey.com>
1070
1071         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1072         * symfile-debug.c (debug_sym_get_probes): Change type.
1073         * stap-probe.c (handle_stap_probe):
1074         (stap_static_probe_ops::get_probes): Change type.
1075         * probe.h (class static_probe_ops) <get_probes>: Change type.
1076         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1077         (parse_probes_in_pspace): Update.
1078         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1079         Update.
1080         (any_static_probe_ops::get_probes): Change type.
1081         * elfread.c (elfread_data): New typedef.
1082         (probe_key): Change type.
1083         (elf_get_probes): Likewise.  Update.
1084         (probe_key_free): Remove.
1085         (_initialize_elfread): Update.
1086         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1087         Change type.
1088         (dtrace_process_dof_probe, dtrace_process_dof)
1089         (dtrace_static_probe_ops::get_probe): Change type.
1090
1091 2019-05-08  Tom Tromey  <tom@tromey.com>
1092
1093         * xcoffread.c (struct xcoff_symfile_info): Rename from
1094         coff_symfile_info.  Add initializers.
1095         (xcoff_objfile_data_key): Move lower.  Change type.
1096         (XCOFF_DATA): Rewrite.
1097         (xcoff_free_info): Remove.
1098         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1099         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1100         (xcoff_initial_scan): Update.
1101
1102 2019-05-08  Tom Tromey  <tom@tromey.com>
1103
1104         * solib-svr4.c (struct svr4_info): Add initializers and
1105         destructor.
1106         <probes_table>: Now an htab_up.
1107         (solib_svr4_pspace_data): Change type.
1108         (free_probes_table): Simplify.
1109         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1110         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1111         (probes_table_remove_objfile_probes, register_solib_event_probe)
1112         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1113         (_initialize_svr4_solib): Update.
1114
1115 2019-05-08  Tom Tromey  <tom@tromey.com>
1116
1117         * remote.c (remote_pspace_data): Change type.
1118         (remote_pspace_data_cleanup): Remove.
1119         (get_remote_exec_file, set_pspace_remote_exec_file)
1120         (_initialize_remote): Update.
1121
1122 2019-05-08  Tom Tromey  <tom@tromey.com>
1123
1124         * breakpoint.c (breakpoint_objfile_key): Change type.
1125         (get_breakpoint_objfile_data): Update.
1126         (free_breakpoint_objfile_data): Remove.
1127         (_initialize_breakpoint): Update.
1128
1129 2019-05-08  Tom Tromey  <tom@tromey.com>
1130
1131         * linux-tdep.c (struct linux_info): Add initializers.
1132         (linux_inferior_data): Move.  Change type.
1133         (invalidate_linux_cache_inf): Update.
1134         (linux_inferior_data_cleanup): Remove.
1135         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1136
1137 2019-05-08  Tom Tromey  <tom@tromey.com>
1138
1139         * auxv.c (auxv_inferior_data): Move.  Change type.
1140         (auxv_inferior_data_cleanup): Remove.
1141         (invalidate_auxv_cache_inf): Rewrite.
1142         (get_auxv_inferior_data, _initialize_auxv): Update.
1143
1144 2019-05-08  Tom Tromey  <tom@tromey.com>
1145
1146         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1147         (symfile_debug_objfile_data_key): Change type.
1148         (symfile_debug_installed, debug_qf_has_symbols)
1149         (debug_qf_find_last_source_symtab)
1150         (debug_qf_forget_cached_source_info)
1151         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1152         (debug_qf_print_stats, debug_qf_dump)
1153         (debug_qf_expand_symtabs_for_function)
1154         (debug_qf_expand_all_symtabs)
1155         (debug_qf_expand_symtabs_with_fullname)
1156         (debug_qf_map_matching_symbols)
1157         (debug_qf_expand_symtabs_matching)
1158         (debug_qf_find_pc_sect_compunit_symtab)
1159         (debug_qf_map_symbol_filenames)
1160         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1161         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1162         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1163         (debug_sym_read_linetable, debug_sym_relocate): Update.
1164         (symfile_debug_free_objfile): Remove.
1165         (install_symfile_debug_logging, _initialize_symfile_debug):
1166         Update.
1167
1168 2019-05-08  Tom Tromey  <tom@tromey.com>
1169
1170         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1171         allocate_on_obstack.
1172         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1173         (get_dwarf2_per_objfile): Update.
1174         (set_dwarf2_per_objfile): Remove.
1175         (dwarf2_has_info, dwarf2_get_section_info): Update.
1176         (dwarf2_free_objfile): Remove.
1177         (_initialize_dwarf2_read): Update.
1178
1179 2019-05-08  Tom Tromey  <tom@tromey.com>
1180
1181         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1182         initializers.
1183         <unsupported_script_warning_printed,
1184         script_not_found_warning_printed>: Now bool.
1185         (auto_load_pspace_data): Change type.
1186         (~auto_load_pspace_info): Rename from
1187         auto_load_pspace_data_cleanup.
1188         (get_auto_load_pspace_data, init_loaded_scripts_info)
1189         (clear_section_scripts, maybe_print_unsupported_script_warning)
1190         (maybe_print_script_not_found_warning, _initialize_auto_load):
1191         Update.
1192
1193 2019-05-08  Tom Tromey  <tom@tromey.com>
1194
1195         * objfiles.c (objfile_pspace_info): Add destructor and
1196         initializers.
1197         (objfiles_pspace_data): Change type.
1198         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1199         (get_objfile_pspace_data): Update.
1200         (objfiles_bfd_data): Change type.
1201         (get_objfile_bfd_data): Update.
1202         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1203
1204 2019-05-08  Tom Tromey  <tom@tromey.com>
1205
1206         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1207         Change type.
1208         (get_catch_syscall_inferior_data): Update.
1209         (catch_syscall_inferior_data_cleanup): Remove.
1210         (_initialize_break_catch_syscall): Update.
1211
1212 2019-05-08  Tom Tromey  <tom@tromey.com>
1213
1214         * inflow.c (struct terminal_info): Add destructor and
1215         initializers.
1216         (inflow_inferior_data): Change type.
1217         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1218         (get_inflow_inferior_data, inflow_inferior_exit)
1219         (swap_terminal_info, _initialize_inflow): Update.
1220
1221 2019-05-08  Tom Tromey  <tom@tromey.com>
1222
1223         * target-dcache.c (target_dcache_cleanup): Remove.
1224         (target_dcache_aspace_key): Change type.
1225         (target_dcache_init_p, target_dcache_invalidate)
1226         (target_dcache_get, target_dcache_get_or_init)
1227         (_initialize_target_dcache): Update.
1228         * dcache.h (struct dcache_deleter): New.
1229
1230 2019-05-08  Tom Tromey  <tom@tromey.com>
1231
1232         * symtab.c (struct symbol_cache): Add destructor and
1233         initializers.
1234         (symbol_cache_key): Move.  Change type.
1235         (make_symbol_cache, free_symbol_cache): Remove.
1236         (get_symbol_cache): Update.
1237         (symbol_cache_cleanup): Remove.
1238         (ALL_PSPACES, symbol_cache_flush)
1239         (maintenance_print_symbol_cache)
1240         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1241         Update.
1242
1243 2019-05-08  Tom Tromey  <tom@tromey.com>
1244
1245         * symtab.c (struct main_info): Add destructor and initializers.
1246         (main_progspace_key): Move.  Change type.
1247         (get_main_info): Update.
1248         (main_info_cleanup): Remove.
1249         (_initialize_symtab): Update.
1250
1251 2019-05-08  Tom Tromey  <tom@tromey.com>
1252
1253         * registry.h (DECLARE_REGISTRY): Define the _key class.
1254
1255 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1256
1257         * NEWS: Merge two 'New commands' sections.
1258
1259 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1260
1261         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1262         parameter and use Ada language definition instead.
1263         (ada_val_print_ptr): Remove unused language parameter.
1264         (ada_val_print_num): Remove language parameter and use Ada language
1265         definition instead.
1266         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1267         parameter.
1268         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1269         parameter and use Ada language definition instead.
1270         (ada_val_print_1): Update all ada_val_print_xxx calls.
1271         Remove language parameter.
1272         (ada_val_print): Update ada_val_print_1 call.
1273
1274 2019-05-08  Tom Tromey  <tromey@adacore.com>
1275
1276         * remote.c (remote_hw_watchpoint_limit)
1277         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1278         Now static.
1279
1280 2019-05-08  Tom Tromey  <tromey@adacore.com>
1281
1282         * maint.c (_initialize_maint_cmds): Move initialization code to
1283         remote.c.
1284         (watchdog, show_watchdog): Move to remote.c.
1285         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1286         "watchdog" static.
1287         (_initialize_remote): Move initialization code from maint.c.
1288         * defs.h (watchdog): Don't declare.
1289
1290 2019-05-08  Tom Tromey  <tromey@adacore.com>
1291
1292         * tui/tui-interp.c: Include main.h.
1293         * interps.c: Include main.h.
1294         * main.h (interpreter_p): Declare.
1295         * defs.h (interpreter_p): Don't declare.
1296
1297 2019-05-08  Tom Tromey  <tromey@adacore.com>
1298
1299         * dwarf2loc.c: Include dwarf2read.h.
1300         * defs.h (read_unsigned_leb128): Don't declare.
1301         * dwarf2read.h (read_unsigned_leb128): Declare.
1302
1303 2019-05-08  Tom Tromey  <tromey@adacore.com>
1304
1305         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1306         method.
1307
1308 2019-05-08  Tom Tromey  <tromey@adacore.com>
1309
1310         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1311         when no wrap column is set.
1312
1313 2019-05-08  Tom Tromey  <tromey@adacore.com>
1314
1315         * c-lang.c (c_get_string): Handle non-C-style arrays.
1316
1317 2019-05-08  Tom Tromey  <tromey@adacore.com>
1318
1319         * typeprint.c (print_offset_data::update): Print the bit offset,
1320         not the number of bits remaining.
1321
1322 2019-05-08  Tom Tromey  <tromey@adacore.com>
1323
1324         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1325         padding at end of comment.
1326
1327 2019-05-08  Tom Tromey  <tromey@adacore.com>
1328
1329         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1330         Compare main types.
1331
1332 2019-05-06  Tom Tromey  <tom@tromey.com>
1333
1334         * common/scoped_mmap.c: Include common-defs.h.
1335         * common/scoped_mmap.h: Don't include config.h.
1336
1337 2019-05-04  Tom Tromey  <tom@tromey.com>
1338
1339         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1340         (struct aarch64_call_info): Add initializers.
1341         <si>: Now a std::vector.
1342         (pass_on_stack, aarch64_push_dummy_call): Update.
1343
1344 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1345             Tom Tromey  <tom@tromey.com>
1346
1347         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1348         (ppc_threads): Now a std::vector.  Now static.
1349         (hwdebug_find_thread_points_by_tid)
1350         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1351         Update.
1352
1353 2019-05-04  Tom Tromey  <tom@tromey.com>
1354
1355         * arc-tdep.c (arc_tdesc_init): Return bool.
1356
1357 2019-05-04  Tom Tromey  <tom@tromey.com>
1358
1359         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1360         Use gdb_assert_not_reached.
1361
1362 2019-05-04  Tom Tromey  <tom@tromey.com>
1363
1364         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1365         "false".
1366
1367 2019-05-04  Tom Tromey  <tom@tromey.com>
1368
1369         * arc-tdep.c (arc_tdesc_init): Use bool.
1370
1371 2019-05-04  Tom Tromey  <tom@tromey.com>
1372
1373         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1374
1375 2019-05-04  Tom Tromey  <tom@tromey.com>
1376
1377         * cli/cli-cmds.c (valid_command_p): Return bool.
1378
1379 2019-05-04  Tom Tromey  <tom@tromey.com>
1380
1381         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1382         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1383
1384 2019-05-04  Raul Tambre  <raul@tambre.ee>
1385
1386         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1387         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1388         operator for comparison.
1389
1390 2019-05-04  Tom Tromey  <tom@tromey.com>
1391
1392         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1393         (lookup_partial_symbol, print_partial_symbols)
1394         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1395         (psymbol_compare): Update.
1396         (add_psymbol_to_bcache): Clear the entire psymbol.
1397         (maintenance_check_psymtabs): Update.
1398         * psympriv.h (struct partial_symbol): Don't derive from
1399         general_symbol_info.
1400         <obj_section, unrelocated_address, address,
1401         set_unrelocated_address>: Update.
1402         <ginfo>: New member.
1403         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1404         (debug_names::write_psymbols): Update.
1405
1406 2019-05-04  Tom de Vries  <tdevries@suse.de>
1407
1408         * contrib/cc-with-tweaks.sh: Support -n arg.
1409
1410 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1411
1412         * corelow.c (core_target::detach): Ensure frame cache and
1413         register caches are cleared.
1414         inferior.c (exit_inferior_1): Likewise.
1415
1416 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1417             Tom Tromey  <tom@tromey.com>
1418
1419         * dictionary.c (collate_pending_symbols_by_language): Remove
1420         "struct" from foreach.
1421         * symtab.c (lookup_global_symbol_from_objfile)
1422         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1423         foreach.
1424         * ser-tcp.c (net_open): Remove "struct" from foreach.
1425         * objfiles.c (objfile_relocate, objfile_rebase)
1426         (objfile_has_symbols): Remove "struct" from foreach.
1427         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1428         from foreach.
1429         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1430         foreach.
1431         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1432         "struct" from foreach.
1433         * ada-lang.c (create_excep_cond_exprs)
1434         (ada_exception_catchpoint_cond_string): Remove "struct" from
1435         foreach.
1436
1437 2019-05-03  Tom Tromey  <tromey@adacore.com>
1438
1439         * ada-exp.y (convert_char_literal): Check suffix of each
1440         enumerator.
1441
1442 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1443
1444         PR ada/21406:
1445         * ada-exp.y (yywrap): Don't define.
1446         * ada-lex.l (%option): Add noyywrap
1447         (yywrap): Remove.
1448
1449 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1450
1451         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1452         _WIN32_WINNT to the XP level, unless already defined to a higher
1453         level.
1454
1455         * unittests/parse-connection-spec-selftests.c:
1456         * ser-tcp.c:
1457         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1458         override.
1459
1460         * symfile.c (find_separate_debug_file): Remove colon from the
1461         drive spec of DOS/Windows file names of the target, so that the
1462         file name produced from DEBUGDIR and the target's directory will
1463         be valid on DOS/Windows systems.
1464
1465 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1466
1467         * rust-lang.c (val_print_struct): Handle printing structures
1468         containing strings.
1469
1470 2019-05-02  Tom Tromey  <tromey@adacore.com>
1471
1472         * valarith.c (_initialize_valarith): Remove.
1473
1474 2019-05-01  Tom Tromey  <tromey@adacore.com>
1475
1476         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1477         bitfields.
1478
1479 2019-05-01  Tom Tromey  <tromey@adacore.com>
1480
1481         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1482         for big-endian copies.
1483
1484 2019-04-30  Ali Tamur  <tamur@google.com>
1485         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1486         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1487         (read_3_bytes): New function.
1488
1489 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1490
1491         * windows-nat.c (main_thread_id): Delete.
1492         (handle_output_debug_string): Replace main_thread_id by
1493         current_event.dwThreadId.
1494         (fake_create_process): Likewise.
1495         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1496         Do not set main_thread_id.
1497         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1498         current_event.dwThreadId.
1499         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1500
1501 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1502
1503         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1504         Use current_event.dwThreadId instead of main_thread_id.
1505
1506 2019-04-30  Tom Tromey  <tromey@adacore.com>
1507
1508         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1509         (create_excep_cond_exprs): Iterate over program spaces.
1510         (ada_exception_catchpoint_cond_string): Examine all minimal
1511         symbols for exception types.
1512
1513 2019-04-30  Tom Tromey  <tromey@adacore.com>
1514
1515         PR c++/24470:
1516         * dwarf2read.c (process_structure_scope): Handle case where type
1517         has template parameters but no symbol was created.
1518
1519 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1520             Chris January  <chris.january@arm.com>
1521
1522         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1523         qualifier.
1524         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1525
1526 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1527
1528         * f-typeprint.c (f_print_type): Update rules for printing
1529         whitespace.
1530         (f_type_print_varspec_suffix): Likewise.
1531
1532 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1533             Chris January  <chris.january@arm.com>
1534
1535         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1536         function arguments.
1537
1538 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * f-lang.c (build_fortran_types): Change name of void type to
1541         lower case.
1542         * f-typeprint.c (f_type_print_base): Print the name of the void
1543         type, rather than a fixed string.
1544         * f-valprint.c (f_decorations): Use lower case void string.
1545
1546 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1547             Chris January  <chris.january@arm.com>
1548
1549         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1550         types for Fortran.
1551
1552 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1553             Chris January  <chris.january@arm.com>
1554             David Lecomber  <david.lecomber@arm.com>
1555
1556         * f-exp.y (BINOP_INTRINSIC): New token.
1557         (exp): New parser rule handling BINOP_INTRINSIC.
1558         (f77_keywords): Add new builtin procedures.
1559         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1560         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1561         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1562         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1563         (print_unop_subexp_f): New function.
1564         (print_binop_subexp_f): New function.
1565         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1566         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1567         (dump_subexp_body_f): Likewise.
1568         (operator_check_f): Likewise.
1569         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1570         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1571
1572 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1575         UNOP_KIND.
1576         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1577         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1578         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1579         (operator_length_f): New fuction.
1580         (print_subexp_f): New function.
1581         (op_name_f): New function.
1582         (dump_subexp_body_f): New function.
1583         (operator_check_f): New function.
1584         (exp_descriptor_f): Replace standard expression handling functions
1585         with new functions.
1586         * gdb/fortran-operator.def: New file.
1587         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1588         * gdb/std-operator.def: Remove UNOP_KIND.
1589
1590 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1591
1592         * std-operator.def: Remove unbalanced, stray double quote
1593         character.
1594
1595 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1596             Chris January  <chris.january@arm.com>
1597             Daniel Everett  <daniel.everett@arm.com>
1598             Nick Forrington  <nick.forrington@arm.com>
1599             Richard Bunt  <richard.bunt@arm.com>
1600
1601         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1602         of depth when printing anonymous structs or unions.
1603         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1604         Don't print either the top-level value, or the children if the
1605         max-depth is exceeded.
1606         (ppscm_print_children): When printing the key of a map, allow one
1607         extra level of depth.
1608         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1609         print either the top-level value, or the children if the max-depth
1610         is exceeded.
1611         (print_children): When printing the key of a map, allow one extra
1612         level of depth.
1613         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1614         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1615         (user_print_options): Initialise max_depth field.
1616         (val_print_scalar_or_string_type_p): New function.
1617         (val_print): Check to see if the max depth has been reached.
1618         (val_print_check_max_depth): Define new function.
1619         (show_print_max_depth): New function.
1620         (_initialize_valprint): Add 'print max-depth' option.
1621         * valprint.h (struct value_print_options) <max_depth>: New field.
1622         (val_print_check_max_depth): Declare new function.
1623         * NEWS: Document new feature.
1624
1625 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1626
1627         * ada-lang.c (ada_language_defn): Initialise new field.
1628         * c-lang.c (c_is_string_type_p): New function.
1629         (c_language_defn): Initialise new field.
1630         (cplus_language_defn): Initialise new field.
1631         (asm_language_defn): Initialise new field.
1632         (minimal_language_defn): Initialise new field.
1633         * c-lang.h (c_is_string_type_p): Declare new function.
1634         * d-lang.c (d_language_defn): Initialise new field.
1635         * f-lang.c (f_is_string_type_p): New function.
1636         (f_language_defn): Initialise new field.
1637         * go-lang.c (go_is_string_type_p): New function.
1638         (go_language_defn): Initialise new field.
1639         * language.c (default_is_string_type_p): New function.
1640         (unknown_language_defn): Initialise new field.
1641         (auto_language_defn): Initialise new field.
1642         * language.h (struct language_defn) <la_is_string_type_p>: New
1643         member variable.
1644         (default_is_string_type_p): Declare new function.
1645         * m2-lang.c (m2_language_defn): Initialise new field.
1646         * objc-lang.c (objc_language_defn): Initialise new field.
1647         * opencl-lang.c (opencl_language_defn): Initialise new field.
1648         * p-lang.c (pascal_is_string_type_p): New function.
1649         (pascal_language_defn): Initialise new field.
1650         * rust-lang.c (rust_is_string_type_p): New function.
1651         (rust_language_defn): Initialise new field.
1652
1653 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1654
1655         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1656         New field.
1657         * ada-lang.c (ada_language_defn): Initialise new field.
1658         * c-lang.c (c_language_defn): Likewise.
1659         (cplus_language_defn): Likewise.
1660         (asm_language_defn): Likewise.
1661         (minimal_language_defn): Likewise.
1662         * d-lang.c (d_language_defn): Likewise.
1663         * f-lang.c (f_language_defn): Likewise.
1664         * go-lang.c (go_language_defn): Likewise.
1665         * language.c (unknown_language_defn): Likewise.
1666         (auto_language_defn): Likewise.
1667         * m2-lang.c (m2_language_defn): Likewise.
1668         * objc-lang.c (objc_language_defn): Likewise.
1669         * opencl-lang.c (opencl_language_defn): Likewise.
1670         * p-lang.c (pascal_language_defn): Likewise.
1671         * rust-lang.c (rust_language_defn): Likewise.
1672
1673 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1674
1675         * ada-lang.c (ada_is_character_type): Change return type to bool.
1676         (ada_is_string_type): Likewise.
1677         * ada-lang.h (ada_is_character_type): Update declaration
1678         (ada_is_string_type): Likewise.
1679
1680 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1681
1682         Support style in 'frame|thread apply'
1683
1684         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1685         * record.c (record_start, record_stop): Update callers of
1686         execute_command_to_string with false.
1687         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1688         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1689         methods.
1690         (class string_file): New constructor with term_out parameter.
1691         Override methods term_out and can_emit_style_escape.  New member
1692         term_out.
1693         (class stdio_file): Override can_emit_style_escape.
1694         (class tee_file): Override term_out and can_emit_style_escape.
1695         * utils.h (can_emit_style_escape): Remove.
1696         * utils.c (can_emit_style_escape): Likewise.
1697         Update all callers of can_emit_style_escape (SOMESTREAM) to
1698         SOMESTREAM->can_emit_style_escape.
1699         * source-cache.c (source_cache::get_source_lines): Likewise.
1700         * stack.c (frame_apply_command_count): Call execute_command_to_string
1701         passing the term_out characteristic of the current gdb_stdout.
1702         * thread.c (thr_try_catch_cmd): Likewise.
1703         * top.c (execute_command_to_string): pass term_out parameter
1704         to construct the string_file for the command output.
1705         * ui-file.c (term_cli_styling): New function (most code moved
1706         from utils.c can_emit_style_escape).
1707         (string_file::string_file, string_file::can_emit_style_escape,
1708         stdio_file::can_emit_style_escape, tee_file::term_out,
1709         tee_file::can_emit_style_escape): New functions.
1710
1711 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1712
1713         * NEWS: Mention the new set|show may-call-functions.
1714         * infcall.c (may_call_functions_p): New variable.
1715         (show_may_call_functions_p): New function.
1716         (call_function_by_hand_dummy): Throws an error if not
1717         may-call-functions.
1718         (_initialize_infcall): Call add_setshow_boolean_cmd for
1719         may-call-functions.
1720
1721 2019-04-25  Keith Seitz  <keiths@redhat.com>
1722
1723         PR c++/24367
1724         * cp-support.c (inspect_type): Don't attempt substitutions
1725         of symbol with the same name.
1726
1727 2019-04-25  Tom Tromey  <tromey@adacore.com>
1728
1729         PR gdb/24475:
1730         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1731         static.
1732
1733 2019-04-25  Tom Tromey  <tromey@adacore.com>
1734
1735         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1736         rvalue reference.
1737         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1738         (gdb_xml_parser::parse): Use std::move.
1739         * python/python-internal.h (gdbpy_convert_exception): Take a const
1740         reference.
1741         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1742         std::move.
1743         * python/py-utils.c (gdbpy_convert_exception): Take a const
1744         reference.
1745         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1746         Use std::move.
1747         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1748         Use std::move.
1749         * mi/mi-main.c (mi_print_exception): Take a const reference.
1750         * main.c (handle_command_errors): Take a const reference.
1751         * linespec.c (parse_linespec): Use std::move.
1752         * infcall.c (run_inferior_call): Use std::move.
1753         (call_function_by_hand_dummy): Use std::move.
1754         * exec.c (try_open_exec_file): Use std::move.
1755         * exceptions.h (exception_print, exception_fprintf)
1756         (exception_print_same): Update.
1757         * exceptions.c (print_exception, exception_print)
1758         (exception_fprintf, exception_print_same): Change parameters to
1759         const reference.
1760         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1761         * common/new-op.c: Use std::move.
1762         * common/common-exceptions.h (struct gdb_exception): Add move
1763         constructor.
1764         (struct gdb_exception_error, struct gdb_exception_quit, struct
1765         gdb_quit_bad_alloc): Change constructor to move constructor.
1766         (throw_exception): Change parameter to rvalue reference.
1767         * common/common-exceptions.c (throw_exception): Take rvalue
1768         reference.
1769         * cli/cli-interp.c (safe_execute_command): Use std::move.
1770         * breakpoint.c (insert_bp_location, location_to_sals): Use
1771         std::move.
1772
1773 2019-04-25  Tom Tromey  <tromey@adacore.com>
1774
1775         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1776         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1777         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1778         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1779         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1780         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1781         guile/scm-value.c: Use unpack.
1782         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1783         gdbscm_gdb_exception.
1784         (gdbscm_throw_gdb_exception): Likewise.
1785         (struct gdbscm_gdb_exception): New.
1786         (unpack): New function.
1787         (gdbscm_wrap): Use unpack.
1788
1789 2019-04-25  Tom Tromey  <tromey@adacore.com>
1790
1791         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1792         (gdb_rl_callback_handler): Use std::move.
1793         * common/common-exceptions.h (struct gdb_exception): Add move
1794         assignment operator.
1795         (throw_exception_sjlj): Change "exception" to const reference.
1796         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1797         (throw_exception_sjlj): Change "exception" to const reference.
1798
1799 2019-04-25  Tom Tromey  <tromey@adacore.com>
1800
1801         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1802         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1803         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1804         Update.
1805         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1806         Update.
1807         * mi/mi-interp.c (mi_interp::exec): Update.
1808         * linespec.c (parse_linespec): Update.
1809         * infcall.c (run_inferior_call): Update.
1810         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1811         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1812         (gdbscm_lookup_global_symbol): Update.
1813         * guile/scm-param.c (gdbscm_parameter_value): Update.
1814         * guile/scm-frame.c (gdbscm_frame_read_register)
1815         (gdbscm_frame_read_var): Update.
1816         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1817         * exec.c (try_open_exec_file): Update.
1818         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1819         (gdb_rl_callback_handler): Update.
1820         * common/common-exceptions.h (exception_none): Don't declare.
1821         * common/common-exceptions.c (exception_none): Don't define.
1822         (struct catcher) <exception>: Update.
1823         * cli/cli-interp.c (safe_execute_command): Update.
1824         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1825
1826 2019-04-25  Ali Tamur  <tamur@google.com>
1827
1828         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1829         (read_attribute_value): Likewise.
1830         (dwarf2_read_addr_index): Update comment.
1831         (read_str_index): Add DW_FORM_strx.
1832         (dwarf2_string_attr): Likewise.
1833         (dwarf2_const_value_attr): Likewise.
1834         (dump_die_shallow): Likewise.
1835         (dwarf2_fetch_constant_bytes): Likewise.
1836         (skip_form_bytes): Likewise.
1837         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1838
1839 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1840
1841         PR corefiles/11608
1842         PR corefiles/18187
1843         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1844         OFFSET.  Verify if current mapping contains an ELF header.
1845         (linux_find_memory_regions_full): Adjust call to
1846         dump_mapping_p.
1847
1848 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1849             Kang Li <kanglictf@gmail.com>
1850
1851         PR gdb/21600
1852
1853         * dwarf2-frame.c (read_initial_length): Be consistent about using
1854         unsigned representation of length.
1855         (decode_frame_entry_1): Likewise.  Check for wraparound of
1856         end pointer as well as buffer overflow.
1857
1858 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1859
1860         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1861         "vq".
1862
1863 2019-04-24  Tom Tromey  <tromey@adacore.com>
1864
1865         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1866
1867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1868
1869         * s12z-tdep.c (s12z_unwind_pc): Delete.
1870         (s12z_unwind_sp): Delete.
1871         (s12z_gdbarch_init): Don't register deleted functions with
1872         gdbarch.
1873
1874 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1875
1876         * rl78-tdep.c (rl78_unwind_sp): Delete.
1877         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1878
1879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1880
1881         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1882         (xstormy16_unwind_pc): Delete.
1883         (xstormy16_dummy_id): Delete.
1884         (xstormy16_gdbarch_init): Don't register deleted functions with
1885         gdbarch.
1886
1887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1888
1889         * vax-tdep.c (vax_unwind_pc): Delete.
1890         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1891
1892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1893
1894         * v850-tdep.c (v850_unwind_sp): Delete.
1895         (v850_unwind_pc): Delete.
1896         (v850_dummy_id): Delete.
1897         (v850_gdbarch_init): Don't register deleted functions with
1898         gdbarch.
1899
1900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1901
1902         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1903         (tilegx_unwind_pc): Delete.
1904         (tilegx_unwind_dummy_id): Delete.
1905         (tilegx_gdbarch_init): Don't register deleted functions with
1906         gdbarch.
1907
1908 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1909
1910         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1911         (tic6x_dummy_id): Delete.
1912         (tic6x_gdbarch_init): Don't register deleted functions with
1913         gdbarch.
1914
1915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1916
1917         * sparc-tdep.c (sparc_unwind_pc): Delete.
1918         (sparc32_gdbarch_init): Don't register deleted function with
1919         gdbarch.
1920
1921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * sh-tdep.c (sh_unwind_sp): Delete.
1924         (sh_unwind_pc): Delete.
1925         (sh_dummy_id): Delete.
1926         (sh_gdbarch_init): Don't register deleted functions with
1927         gdbarch.
1928
1929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1930
1931         * score-tdep.c (score_unwind_sp): Delete.
1932         (score_unwind_pc): Delete.
1933         (score_dummy_id): Delete.
1934         (score_gdbarch_init): Don't register deleted functions with
1935         gdbarch.
1936
1937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1938
1939         * rx-tdep.c (rx_unwind_pc): Delete.
1940         (rx_unwind_sp): Delete.
1941         (rx_dummy_id): Delete.
1942         (rx_gdbarch_init): Don't register deleted functions with
1943         gdbarch.  Update comment.
1944
1945 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1946
1947         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1948         (rs6000_dummy_id): Delete.
1949         (rs6000_gdbarch_init): Don't register deleted functions with
1950         gdbarch.
1951
1952 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1953
1954         * or1k-tdep.c (or1k_dummy_id): Delete.
1955         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1956
1957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1958
1959         * nios2-tdep.c (nios2_dummy_id): Delete.
1960         (nios2_unwind_sp): Delete.
1961         (nios2_gdbarch_init): Don't register deleted functions with
1962         gdbarch.
1963
1964 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1965
1966         * nds32-tdep.c (nds32_dummy_id): Delete.
1967         (nds32_unwind_pc): Delete.
1968         (nds32_unwind_sp): Delete.
1969         (nds32_gdbarch_init): Don't register deleted functions with
1970         gdbarch.
1971
1972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1973
1974         * msp430-tdep.c (msp430_unwind_pc): Delete.
1975         (msp430_unwind_sp): Delete.
1976         (msp430_dummy_id): Delete.
1977         (msp430_gdbarch_init): Don't register deleted functions with
1978         gdbarch.
1979
1980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * moxie-tdep.c (moxie_unwind_sp): Delete.
1983         (moxie_unwind_pc): Delete.
1984         (moxie_dummy_id): Delete.
1985         (moxie_gdbarch_init): Don't register deleted functions with
1986         gdbarch.
1987
1988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1989
1990         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1991         (mn10300_unwind_pc): Delete.
1992         (mn10300_unwind_sp): Delete.
1993         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1994         mn10300_unwind_sp.
1995         (mn10300_frame_unwind_init): Don't register deleted functions with
1996         gdbarch.
1997
1998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         * mep-tdep.c (mep_unwind_pc): Delete.
2001         (mep_unwind_sp): Delete.
2002         (mep_dummy_id): Delete.
2003         (mep_gdbarch_init): Don't register deleted functions with
2004         gdbarch.
2005
2006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2007
2008         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2009         (m68hc11_unwind_sp): Delete.
2010         (m68hc11_gdbarch_init): Don't register deleted functions with
2011         gdbarch.
2012
2013 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2014
2015         * m32r-tdep.c (m32r_unwind_sp): Delete.
2016         (m32r_unwind_pc): Delete.
2017         (m32r_dummy_id): Delete.
2018         (m32r_gdbarch_init): Don't register deleted functions with
2019         gdbarch.
2020
2021 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * m32c-tdep.c (m32c_unwind_pc): Delete.
2024         (m32c_unwind_sp): Delete.
2025         (m32c_dummy_id): Delete.
2026         (m32c_gdbarch_init): Don't register deleted functions with
2027         gdbarch.
2028
2029 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2030
2031         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2032         (lm32_unwind_pc): Delete.
2033         (lm32_dummy_id): Delete.
2034         (lm32_gdbarch_init): Don't register deleted functions with
2035         gdbarch.
2036
2037 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2038
2039         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2040         (iq2000_unwind_pc): Delete.
2041         (iq2000_dummy_id): Delete.
2042         (iq2000_gdbarch_init): Don't register deleted functions with
2043         gdbarch.
2044
2045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2046
2047         * nds32-tdep.c (nds32_type_align): Delete.
2048         (nds32_push_dummy_call): Use type_align instead.
2049
2050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * arm-tdep.c (arm_type_align): Only handle vector override case.
2053         (arm_push_dummy_call): Use type_align.
2054         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2055
2056 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2059         case.
2060         (pass_on_stack): Use type_align.
2061         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2062         function.
2063
2064 2019-04-23  Tom Tromey  <tromey@adacore.com>
2065
2066         * dwarf2read.c (line_header::file_name_at): Remove unused
2067         overload.
2068
2069 2019-04-23  Tom de Vries  <tdevries@suse.de>
2070
2071         PR gdb/24438
2072         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2073         invocation.
2074
2075
2076 2019-03-27  Ali Tamur  <tamur@google.com>
2077
2078         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2079         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2080         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2081         (dwarf_expr_context::get_addr_index): Likewise
2082         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2083         (symbol_needs_eval_context::get_addr_index): Likewise
2084         (disassemble_dwarf_expression): Add DW_OP_addrx
2085         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2086         (read_cutu_die_from_dwo): Update comment
2087         (skip_one_die): Add DW_FORM_addrx
2088         (read_attribute_value): Likewise
2089         (var_decode_location): Add DW_OP_addrx
2090         (dwarf2_const_value_attr): Add DW_FORM_addrx
2091         (dump_die_shallow): Likewise
2092         (dwarf2_fetch_constant_bytes): Likewise
2093         (decode_locdesc): Add DW_OP_addrx
2094         (skip_form_bytes): Add DW_FORM_addrx
2095
2096 2019-04-22  Ali Tamur  <tamur@google.com>
2097
2098         * MAINTAINERS (Write After Approval): Add self.
2099
2100 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2101
2102         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2103         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2104         (open_symbol_file_object): Likewise.
2105         (svr4_default_sos): Add info parameter.
2106         (svr4_read_so_list): Likewise.
2107         (svr4_current_sos_direct): Adjust functions calls to pass down
2108         info.
2109         (svr4_current_sos_1): Add info parameter.
2110         (svr4_current_sos): Call get_svr4_info, pass info down to
2111         svr4_current_sos_1.
2112         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2113         get_svr4_info.
2114         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2115         get_svr4_info.
2116         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2117         to get_svr4_info.
2118         (probes_table_remove_objfile_probes): Likewise.
2119         (register_solib_event_probe): Add info parameter.
2120         (solist_update_incremental): Pass info parameter down to
2121         svr4_read_so_list.
2122         (disable_probes_interface): Add info parameter.
2123         (svr4_handle_solib_event): Pass current_program_space to
2124         get_svr4_info.  Adjust disable_probes_interface cleanup.
2125         (svr4_create_probe_breakpoints): Add info parameter, pass it
2126         down to register_solib_event_probe.
2127         (svr4_create_solib_event_breakpoints): Add info parameter,
2128         pass it down to svr4_create_probe_breakpoints.
2129         (enable_break): Pass info down to
2130         svr4_create_solib_event_breakpoints.
2131         (svr4_solib_create_inferior_hook): Pass current_program_space to
2132         get_svr4_info.
2133         (svr4_clear_solib): Likewise.
2134
2135 2019-04-22  Pedro Alves  <palves@redhat.com>
2136
2137         * solib-svr4.c (svr4_free_objfile_observer): New.
2138         (probe_and_action::objfile): New field.
2139         (probes_table_htab_remove_objfile_probes)
2140         (probes_table_remove_objfile_probes): New functions.
2141         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2142         in the new probe_and_action.  Don't store the probe in 'lookup'.
2143         (svr4_create_probe_breakpoints): Pass objfile to
2144         register_solib_event_probe.
2145         (_initialize_svr4_solib): Register a free_objfile observer.
2146
2147 2019-04-19  Tom Tromey  <tom@tromey.com>
2148
2149         * common/queue.h: Remove.
2150
2151 2019-04-19  Tom Tromey  <tom@tromey.com>
2152
2153         * event-loop.c: Don't include "common/queue.h".
2154
2155 2019-04-19  Tom Tromey  <tom@tromey.com>
2156
2157         * remote.c (remote_target): Use delete.
2158         * remote-notif.h: Include <list>, not "common/queue.h".
2159         (notif_client_p): Remove typedef.
2160         (remote_notif_state): Add constructor, destructor, initializer.
2161         <notif_queue>: Now a std::list.
2162         (remote_notif_state_xfree): Don't declare.
2163         * remote-notif.c (remote_notif_process, handle_notification)
2164         (remote_notif_state_allocate): Update.
2165         (~remote_notif_state): Rename from remote_notif_state_xfree.
2166
2167 2019-04-19  Tom Tromey  <tom@tromey.com>
2168
2169         * symfile.c (reread_symbols): Update.
2170         * objfiles.c (objfile_register_static_link)
2171         (objfile_lookup_static_link): Update
2172         (~objfile) Don't delete static_links.
2173         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2174
2175 2019-04-19  Tom Tromey  <tom@tromey.com>
2176
2177         * type-stack.h (struct type_stack) <insert>: Constify string.
2178         * type-stack.c (type_stack::insert): Constify string.
2179         * gdbtypes.h (lookup_template_type): Update.
2180         (address_space_name_to_int): Update.
2181         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2182         const.
2183         (lookup_template_type): Make name const.
2184         * c-exp.y: Update rules.
2185         (lex_one_token, classify_name, classify_inner_name)
2186         (c_print_token): Update.
2187         * p-exp.y: Update rules.
2188         (yylex): Update.
2189         * f-exp.y: Update rules.
2190         (yylex): Update.
2191         * d-exp.y: Update rules.
2192         (lex_one_token, classify_name, classify_inner_name): Update.
2193         * parse.c (write_dollar_variable, copy_name): Return std::string.
2194         * parser-defs.h (copy_name): Change return type.
2195         * m2-exp.y: Update rules.
2196         (yylex): Update.
2197         * go-exp.y (lex_one_token): Update.
2198         Update rules.
2199         (classify_unsafe_function, classify_packaged_name)
2200         (classify_name, yylex): Update.
2201
2202 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2203
2204         * configure.ac: add --enable-source-highlight switch.
2205         * configure: Regenerate.
2206         * top.c (print_gdb_version): plumb --enable-source-highlight
2207         status to "show configuration".
2208
2209 2019-04-19  Tom Tromey  <tromey@adacore.com>
2210
2211         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2212         Check ADA_TYPE_P.
2213         (empty_record, ada_template_to_fixed_record_type_1)
2214         (template_to_static_fixed_type)
2215         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2216         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2217         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2218         macros.
2219
2220 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2221
2222         PR symtab/24423:
2223         * source.c (print_source_lines_base): Advance "iter" when a
2224         control character is seen.
2225
2226 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2227
2228         * inferior.h (struct infcall_suspend_state_deleter):
2229         Catch exception in destructor to avoid crash.
2230
2231 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2232
2233         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2234         close to the add_com "shell".
2235
2236 2019-04-18  Tom Tromey  <tromey@adacore.com>
2237
2238         * process-stratum-target.h (class process_stratum_target)
2239         <stratum>: Add "final".
2240
2241 2019-04-17  Tom Tromey  <tromey@adacore.com>
2242
2243         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2244         against nullptr before use.
2245
2246 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2247
2248         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2249
2250 2019-04-17  Jim Wilson  <jimw@sifive.com>
2251             Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2254         code read might fail, assume 4-byte breakpoint in that case.
2255
2256 2019-04-15  Leszek Swirski  <leszeks@google.com>
2257
2258         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2259         rather than a hand-rolled POD check when checking for forced MEMORY
2260         classification.
2261
2262 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2263
2264         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2265         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2266         function.
2267         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2268         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2269         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2270         declaration.
2271
2272 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2273
2274         * aarch64-linux-nat.c
2275         (aarch64_linux_nat_target::thread_architecture): Add override.
2276         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2277         each VQ.
2278
2279 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2280
2281         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2282
2283 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2284
2285         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2286         target types of size 96-bits, add some additional comments, and
2287         check that the builtin type we found was the correct size.
2288
2289 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2290
2291         * utils.c (prompt_for_continue): Don't restore the styling at the
2292         end, as applied_style has the wrong value.  This fixes styling in
2293         long lists of file names that are interrupted by the "Continue?"
2294         prompt.
2295
2296 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2297
2298         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2299         * c-lang.c (c_language_defn): Likewise.
2300         (cplus_language_defn): Likewise.
2301         (asm_language_defn): Likewise.
2302         (minimal_language_defn): Likewise.
2303         * d-lang.c (d_language_defn): Likewise.
2304         * f-lang.c (f_language_defn): Likewise.
2305         * go-lang.c (go_language_defn): Likewise.
2306         * language.c (unknown_language_defn): Likewise.
2307         (auto_language_defn): Likewise.
2308         * language.h (struct language_defn): Remove la_magic field.
2309         (LANG_MAGIC): Delete.
2310         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2311         * objc-lang.c (objc_language_defn): Likewise.
2312         * opencl-lang.c (opencl_language_defn): Likewise.
2313         * p-lang.c (pascal_language_defn): Likewise.
2314         * rust-lang.c (rust_language_defn): Likewise.
2315
2316 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * riscv-tdep.c (riscv_type_align): New function.
2319         (riscv_type_alignment): Delete.
2320         (riscv_arg_location): Use 'type_align'.
2321         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2322
2323 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * gdbtypes.c (type_align): A struct with no non-static fields also
2326         has alignment of 1.
2327
2328 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2331         component to 0.
2332         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2333         member.
2334         (riscv_struct_info::analyse): New implementation using new
2335         analyse_inner member function.
2336         (riscv_struct_info::field_offset): New member function.
2337         (riscv_struct_info::m_offsets): New member variable.
2338         (riscv_struct_info::analyse_inner): New private member function,
2339         takes the old implementation of riscv_struct_info::analyse but
2340         extended to track field offsets.
2341         (riscv_call_arg_struct): Update the struct folding special cases
2342         to handle cases where empty C++ structs, which are non-zero
2343         length, are found.
2344         (riscv_arg_location): Initialise the length of each location, a
2345         non-zero length now indicates the location is in use.
2346         (riscv_push_dummy_call): Allow for the first location having a
2347         non-zero offset when setting up arguments.
2348         (riscv_return_value): Likewise, but for return values.
2349
2350 2019-04-11  Tom Tromey  <tromey@adacore.com>
2351
2352         * utils.c (internal_vproblem): Make "msg" const.
2353
2354 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2355
2356         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2357         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2358         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2359         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2360
2361 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2362
2363         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2364         function.
2365         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2366         of amd64_collect_native_gregset.
2367         (amd64_linux_nat_target::store_registers): Likewise.
2368
2369 2019-04-10  Tom Tromey  <tom@tromey.com>
2370
2371         * symtab.c (lookup_global_symbol_from_objfile)
2372         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2373         * objfiles.h (class separate_debug_iterator): New.
2374         (class separate_debug_range): New.
2375         (struct objfile) <separate_debug_objfiles>: New method.
2376         (objfile_separate_debug_iterate): Don't declare.
2377         * objfiles.c (separate_debug_iterator::operator++): Rename from
2378         objfile_separate_debug_iterate.
2379         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2380         iterator.
2381         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2382         iterator.
2383
2384 2019-04-10  Tom Tromey  <tom@tromey.com>
2385
2386         * symfile.c (reread_symbols): Remove old comment.
2387         * objfiles.c (free_all_objfiles): Fix a typo.
2388
2389 2019-04-10  Tom Tromey  <tom@tromey.com>
2390
2391         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2392         * minsyms.c (lookup_minimal_symbol): Use foreach.
2393         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2394         (lookup_minimal_symbol_solib_trampoline): Likewise.
2395         * symfile.c (reread_symbols): Use foreach.
2396
2397 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2398             Tom Tromey  <tromey@adacore.com>
2399
2400         PR rust/24414:
2401         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2402         (rust_lex_int_test): Change "value" to be LONGEST.
2403         (rust_lex_tests): Add test for long integer literal.
2404
2405 2019-04-09  Tom Tromey  <tromey@adacore.com>
2406
2407         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2408         to bool.
2409         (extended_remote_target::attach): Update.
2410         (remote_target::remote_notice_new_inferior): Update.
2411         (remote_target::add_current_inferior_and_thread): Update.
2412         * inferior.c (exit_inferior_1): Use "false".
2413         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2414
2415 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2416
2417         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2418         the "start" command.
2419
2420 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2421
2422         * python/py-inferior.c (infpy_thread_from_thread_handle):
2423         Adjust comments to reflect renaming of thread_from_thread_handle
2424         to thread_from_handle.  Adjust keywords.  Fix type error message.
2425         (inferior_object_methods): Add thread_from_handle.  Retain
2426         thread_from_thread_handle, but mark it as deprecated.
2427
2428 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2429
2430         * gdbthread.h (find_thread_by_handle): Revise declaration.
2431         * thread.c (find_thread_by_handle): Likewise.  Adjust
2432         implementation too.
2433         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2434         support for buffer objects as handles.
2435
2436 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2437
2438         * python/py-infthread.c (thpy_thread_handle): New function.
2439         (thread_object_methods): Register thpy_thread_handle.
2440
2441 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2442
2443         * gdbthread.h (thread_to_thread_handle): Declare.
2444         * thread.c (gdbtypes.h): Include.
2445         (thread_to_thread_handle): New function.
2446
2447         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2448         (target_thread_info_to_thread_handle): Declare.
2449         * target.c (target_thread_info_to_thread_handle): New function.
2450         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2451         * target-delegates.c: Regenerate.
2452
2453         * linux-thread-db.c (class thread_db_target): Add method
2454         thread_info_to_thread_handle.
2455         (thread_db_target::thread_info_to_thread_handle): Define.
2456         * remote.c (class remote_target): Add new method
2457         thread_info_to_thread_handle.
2458         (remote_target::thread_info_to_thread_handle): Define.
2459
2460 2019-04-08  Pedro Alves  <palves@redhat.com>
2461
2462         * common/common-exceptions.c (throw_exception): Don't create
2463         named object to throw; throw directly.
2464         (throw_it): Likewise.  Don't initialize gdb_exception::message
2465         here, with new; pass FMT and AP to the ctor instead.
2466         * common/common-exceptions.h: Include <string>.
2467         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2468         const char *, va_list)): New ctor.  Use std::make_shared.
2469         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2470         errors)): Delete.
2471         (gdb_exception_error::gdb_exception_error(enum errors, const char
2472         *, va_list)): New.
2473         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2474         Add assertion.
2475         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2476         errors)): Delete.
2477         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2478         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2479         Add assertion.
2480
2481 2019-04-08  Tom Tromey  <tom@tromey.com>
2482
2483         * valops.c (value_rtti_indirect_type): Replace throw_exception
2484         with throw.
2485         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2486         with throw.
2487         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2488         throw.
2489         * target.c (target_translate_tls_address): Replace throw_exception
2490         with throw.
2491         * stack.c (frame_apply_command_count): Replace throw_exception
2492         with throw.
2493         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2494         throw.
2495         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2496         with throw.
2497         * rs6000-tdep.c (rs6000_frame_cache)
2498         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2499         * remote.c: Replace throw_exception with throw.
2500         * record-full.c (record_full_message, record_full_wait_1)
2501         (record_full_restore): Replace throw_exception with throw.
2502         * record-btrace.c:
2503         (get_thread_current_frame_id, record_btrace_start_replaying)
2504         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2505         (cmd_record_btrace_start): Replace throw_exception with throw.
2506         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2507         throw.
2508         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2509         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2510         * linespec.c:
2511         (find_linespec_symbols): Replace throw_exception with throw.
2512         * infrun.c (displaced_step_prepare, resume): Replace
2513         throw_exception with throw.
2514         * infcmd.c (post_create_inferior): Replace throw_exception with
2515         throw.
2516         * inf-loop.c (inferior_event_handler): Replace throw_exception
2517         with throw.
2518         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2519         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2520         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2521         (get_prev_frame_always, get_frame_pc_if_available)
2522         (get_frame_address_in_block_if_available, get_frame_language):
2523         Replace throw_exception with throw.
2524         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2525         throw_exception with throw.
2526         * eval.c (fetch_subexp_value, evaluate_var_value)
2527         (evaluate_funcall, evaluate_subexp_standard): Replace
2528         throw_exception with throw.
2529         * dwarf2loc.c (call_site_find_chain)
2530         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2531         Replace throw_exception with throw.
2532         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2533         with throw.
2534         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2535         throw.
2536         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2537         * completer.c (complete_line_internal): Replace throw_exception
2538         with throw.
2539         * compile/compile-object-run.c (compile_object_run): Replace
2540         throw_exception with throw.
2541         * cli/cli-script.c (process_next_line): Replace throw_exception
2542         with throw.
2543         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2544         (btrace_enable, btrace_maint_update_pt_packets): Replace
2545         throw_exception with throw.
2546         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2547         throw_exception with throw.
2548         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2549         throw_exception with throw.
2550         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2551         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2552         * aarch64-tdep.c (aarch64_make_prologue_cache)
2553         (aarch64_make_stub_cache): Replace throw_exception with throw.
2554
2555 2019-04-08  Tom Tromey  <tom@tromey.com>
2556
2557         * common/common-exceptions.c (throw_exception): Rename from
2558         throw_exception_cxx.  Remove old copy.  Make argument const.
2559         (throw_it): Create and throw exception objects directly.
2560         * common/common-exceptions.h (throw_exception): Make argument
2561         const.
2562         (struct gdb_exception_error): Add constructor.
2563         (struct gdb_exception_quit): Add constructor.
2564
2565 2019-04-08  Tom Tromey  <tom@tromey.com>
2566
2567         * common/common-exceptions.h (exception_rethrow): Don't declare.
2568         (TRY_SJLJ): Update comment.
2569         (TRY, CATCH, END_CATCH): Remove.
2570         * common/common-exceptions.c (exception_rethrow): Remove.
2571
2572 2019-04-08  Tom Tromey  <tom@tromey.com>
2573
2574         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2575         Remove.
2576         (gdb_exception_error): Rename from
2577         gdb_exception_RETURN_MASK_ERROR.
2578         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2579         (gdb_quit_bad_alloc): Update.
2580         * aarch64-tdep.c: Update.
2581         * ada-lang.c: Update.
2582         * ada-typeprint.c: Update.
2583         * ada-valprint.c: Update.
2584         * amd64-tdep.c: Update.
2585         * arch-utils.c: Update.
2586         * break-catch-throw.c: Update.
2587         * breakpoint.c: Update.
2588         * btrace.c: Update.
2589         * c-varobj.c: Update.
2590         * cli/cli-cmds.c: Update.
2591         * cli/cli-interp.c: Update.
2592         * cli/cli-script.c: Update.
2593         * common/common-exceptions.c: Update.
2594         * common/new-op.c: Update.
2595         * common/selftest.c: Update.
2596         * compile/compile-c-symbols.c: Update.
2597         * compile/compile-cplus-symbols.c: Update.
2598         * compile/compile-object-load.c: Update.
2599         * compile/compile-object-run.c: Update.
2600         * completer.c: Update.
2601         * corelow.c: Update.
2602         * cp-abi.c: Update.
2603         * cp-support.c: Update.
2604         * cp-valprint.c: Update.
2605         * darwin-nat.c: Update.
2606         * disasm-selftests.c: Update.
2607         * dtrace-probe.c: Update.
2608         * dwarf-index-cache.c: Update.
2609         * dwarf-index-write.c: Update.
2610         * dwarf2-frame-tailcall.c: Update.
2611         * dwarf2-frame.c: Update.
2612         * dwarf2loc.c: Update.
2613         * dwarf2read.c: Update.
2614         * eval.c: Update.
2615         * event-loop.c: Update.
2616         * event-top.c: Update.
2617         * exec.c: Update.
2618         * f-valprint.c: Update.
2619         * fbsd-tdep.c: Update.
2620         * frame-unwind.c: Update.
2621         * frame.c: Update.
2622         * gdbtypes.c: Update.
2623         * gnu-v3-abi.c: Update.
2624         * guile/guile-internal.h: Update.
2625         * guile/scm-block.c: Update.
2626         * guile/scm-breakpoint.c: Update.
2627         * guile/scm-cmd.c: Update.
2628         * guile/scm-disasm.c: Update.
2629         * guile/scm-frame.c: Update.
2630         * guile/scm-lazy-string.c: Update.
2631         * guile/scm-math.c: Update.
2632         * guile/scm-param.c: Update.
2633         * guile/scm-ports.c: Update.
2634         * guile/scm-pretty-print.c: Update.
2635         * guile/scm-symbol.c: Update.
2636         * guile/scm-symtab.c: Update.
2637         * guile/scm-type.c: Update.
2638         * guile/scm-value.c: Update.
2639         * i386-linux-tdep.c: Update.
2640         * i386-tdep.c: Update.
2641         * inf-loop.c: Update.
2642         * infcall.c: Update.
2643         * infcmd.c: Update.
2644         * infrun.c: Update.
2645         * jit.c: Update.
2646         * language.c: Update.
2647         * linespec.c: Update.
2648         * linux-fork.c: Update.
2649         * linux-nat.c: Update.
2650         * linux-tdep.c: Update.
2651         * linux-thread-db.c: Update.
2652         * main.c: Update.
2653         * mi/mi-cmd-break.c: Update.
2654         * mi/mi-cmd-stack.c: Update.
2655         * mi/mi-interp.c: Update.
2656         * mi/mi-main.c: Update.
2657         * objc-lang.c: Update.
2658         * p-valprint.c: Update.
2659         * parse.c: Update.
2660         * ppc-linux-tdep.c: Update.
2661         * printcmd.c: Update.
2662         * python/py-arch.c: Update.
2663         * python/py-breakpoint.c: Update.
2664         * python/py-cmd.c: Update.
2665         * python/py-finishbreakpoint.c: Update.
2666         * python/py-frame.c: Update.
2667         * python/py-framefilter.c: Update.
2668         * python/py-gdb-readline.c: Update.
2669         * python/py-inferior.c: Update.
2670         * python/py-infthread.c: Update.
2671         * python/py-lazy-string.c: Update.
2672         * python/py-linetable.c: Update.
2673         * python/py-objfile.c: Update.
2674         * python/py-param.c: Update.
2675         * python/py-prettyprint.c: Update.
2676         * python/py-progspace.c: Update.
2677         * python/py-record-btrace.c: Update.
2678         * python/py-record.c: Update.
2679         * python/py-symbol.c: Update.
2680         * python/py-type.c: Update.
2681         * python/py-unwind.c: Update.
2682         * python/py-utils.c: Update.
2683         * python/py-value.c: Update.
2684         * python/python.c: Update.
2685         * record-btrace.c: Update.
2686         * record-full.c: Update.
2687         * remote-fileio.c: Update.
2688         * remote.c: Update.
2689         * riscv-tdep.c: Update.
2690         * rs6000-aix-tdep.c: Update.
2691         * rs6000-tdep.c: Update.
2692         * rust-exp.y: Update.
2693         * rust-lang.c: Update.
2694         * s390-tdep.c: Update.
2695         * selftest-arch.c: Update.
2696         * solib-dsbt.c: Update.
2697         * solib-frv.c: Update.
2698         * solib-spu.c: Update.
2699         * solib-svr4.c: Update.
2700         * solib.c: Update.
2701         * sparc64-linux-tdep.c: Update.
2702         * stack.c: Update.
2703         * symfile-mem.c: Update.
2704         * symmisc.c: Update.
2705         * target.c: Update.
2706         * thread.c: Update.
2707         * top.c: Update.
2708         * tracefile-tfile.c: Update.
2709         * tui/tui.c: Update.
2710         * typeprint.c: Update.
2711         * unittests/cli-utils-selftests.c: Update.
2712         * unittests/parse-connection-spec-selftests.c: Update.
2713         * valops.c: Update.
2714         * valprint.c: Update.
2715         * value.c: Update.
2716         * varobj.c: Update.
2717         * windows-nat.c: Update.
2718         * x86-linux-nat.c: Update.
2719         * xml-support.c: Update.
2720
2721 2019-04-08  Tom Tromey  <tom@tromey.com>
2722
2723         * xml-support.c: Use C++ exception handling.
2724         * x86-linux-nat.c: Use C++ exception handling.
2725         * windows-nat.c: Use C++ exception handling.
2726         * varobj.c: Use C++ exception handling.
2727         * value.c: Use C++ exception handling.
2728         * valprint.c: Use C++ exception handling.
2729         * valops.c: Use C++ exception handling.
2730         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2731         handling.
2732         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2733         * typeprint.c: Use C++ exception handling.
2734         * tui/tui.c: Use C++ exception handling.
2735         * tracefile-tfile.c: Use C++ exception handling.
2736         * top.c: Use C++ exception handling.
2737         * thread.c: Use C++ exception handling.
2738         * target.c: Use C++ exception handling.
2739         * symmisc.c: Use C++ exception handling.
2740         * symfile-mem.c: Use C++ exception handling.
2741         * stack.c: Use C++ exception handling.
2742         * sparc64-linux-tdep.c: Use C++ exception handling.
2743         * solib.c: Use C++ exception handling.
2744         * solib-svr4.c: Use C++ exception handling.
2745         * solib-spu.c: Use C++ exception handling.
2746         * solib-frv.c: Use C++ exception handling.
2747         * solib-dsbt.c: Use C++ exception handling.
2748         * selftest-arch.c: Use C++ exception handling.
2749         * s390-tdep.c: Use C++ exception handling.
2750         * rust-lang.c: Use C++ exception handling.
2751         * rust-exp.y: Use C++ exception handling.
2752         * rs6000-tdep.c: Use C++ exception handling.
2753         * rs6000-aix-tdep.c: Use C++ exception handling.
2754         * riscv-tdep.c: Use C++ exception handling.
2755         * remote.c: Use C++ exception handling.
2756         * remote-fileio.c: Use C++ exception handling.
2757         * record-full.c: Use C++ exception handling.
2758         * record-btrace.c: Use C++ exception handling.
2759         * python/python.c: Use C++ exception handling.
2760         * python/py-value.c: Use C++ exception handling.
2761         * python/py-utils.c: Use C++ exception handling.
2762         * python/py-unwind.c: Use C++ exception handling.
2763         * python/py-type.c: Use C++ exception handling.
2764         * python/py-symbol.c: Use C++ exception handling.
2765         * python/py-record.c: Use C++ exception handling.
2766         * python/py-record-btrace.c: Use C++ exception handling.
2767         * python/py-progspace.c: Use C++ exception handling.
2768         * python/py-prettyprint.c: Use C++ exception handling.
2769         * python/py-param.c: Use C++ exception handling.
2770         * python/py-objfile.c: Use C++ exception handling.
2771         * python/py-linetable.c: Use C++ exception handling.
2772         * python/py-lazy-string.c: Use C++ exception handling.
2773         * python/py-infthread.c: Use C++ exception handling.
2774         * python/py-inferior.c: Use C++ exception handling.
2775         * python/py-gdb-readline.c: Use C++ exception handling.
2776         * python/py-framefilter.c: Use C++ exception handling.
2777         * python/py-frame.c: Use C++ exception handling.
2778         * python/py-finishbreakpoint.c: Use C++ exception handling.
2779         * python/py-cmd.c: Use C++ exception handling.
2780         * python/py-breakpoint.c: Use C++ exception handling.
2781         * python/py-arch.c: Use C++ exception handling.
2782         * printcmd.c: Use C++ exception handling.
2783         * ppc-linux-tdep.c: Use C++ exception handling.
2784         * parse.c: Use C++ exception handling.
2785         * p-valprint.c: Use C++ exception handling.
2786         * objc-lang.c: Use C++ exception handling.
2787         * mi/mi-main.c: Use C++ exception handling.
2788         * mi/mi-interp.c: Use C++ exception handling.
2789         * mi/mi-cmd-stack.c: Use C++ exception handling.
2790         * mi/mi-cmd-break.c: Use C++ exception handling.
2791         * main.c: Use C++ exception handling.
2792         * linux-thread-db.c: Use C++ exception handling.
2793         * linux-tdep.c: Use C++ exception handling.
2794         * linux-nat.c: Use C++ exception handling.
2795         * linux-fork.c: Use C++ exception handling.
2796         * linespec.c: Use C++ exception handling.
2797         * language.c: Use C++ exception handling.
2798         * jit.c: Use C++ exception handling.
2799         * infrun.c: Use C++ exception handling.
2800         * infcmd.c: Use C++ exception handling.
2801         * infcall.c: Use C++ exception handling.
2802         * inf-loop.c: Use C++ exception handling.
2803         * i386-tdep.c: Use C++ exception handling.
2804         * i386-linux-tdep.c: Use C++ exception handling.
2805         * guile/scm-value.c: Use C++ exception handling.
2806         * guile/scm-type.c: Use C++ exception handling.
2807         * guile/scm-symtab.c: Use C++ exception handling.
2808         * guile/scm-symbol.c: Use C++ exception handling.
2809         * guile/scm-pretty-print.c: Use C++ exception handling.
2810         * guile/scm-ports.c: Use C++ exception handling.
2811         * guile/scm-param.c: Use C++ exception handling.
2812         * guile/scm-math.c: Use C++ exception handling.
2813         * guile/scm-lazy-string.c: Use C++ exception handling.
2814         * guile/scm-frame.c: Use C++ exception handling.
2815         * guile/scm-disasm.c: Use C++ exception handling.
2816         * guile/scm-cmd.c: Use C++ exception handling.
2817         * guile/scm-breakpoint.c: Use C++ exception handling.
2818         * guile/scm-block.c: Use C++ exception handling.
2819         * guile/guile-internal.h: Use C++ exception handling.
2820         * gnu-v3-abi.c: Use C++ exception handling.
2821         * gdbtypes.c: Use C++ exception handling.
2822         * frame.c: Use C++ exception handling.
2823         * frame-unwind.c: Use C++ exception handling.
2824         * fbsd-tdep.c: Use C++ exception handling.
2825         * f-valprint.c: Use C++ exception handling.
2826         * exec.c: Use C++ exception handling.
2827         * event-top.c: Use C++ exception handling.
2828         * event-loop.c: Use C++ exception handling.
2829         * eval.c: Use C++ exception handling.
2830         * dwarf2read.c: Use C++ exception handling.
2831         * dwarf2loc.c: Use C++ exception handling.
2832         * dwarf2-frame.c: Use C++ exception handling.
2833         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2834         * dwarf-index-write.c: Use C++ exception handling.
2835         * dwarf-index-cache.c: Use C++ exception handling.
2836         * dtrace-probe.c: Use C++ exception handling.
2837         * disasm-selftests.c: Use C++ exception handling.
2838         * darwin-nat.c: Use C++ exception handling.
2839         * cp-valprint.c: Use C++ exception handling.
2840         * cp-support.c: Use C++ exception handling.
2841         * cp-abi.c: Use C++ exception handling.
2842         * corelow.c: Use C++ exception handling.
2843         * completer.c: Use C++ exception handling.
2844         * compile/compile-object-run.c: Use C++ exception handling.
2845         * compile/compile-object-load.c: Use C++ exception handling.
2846         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2847         * compile/compile-c-symbols.c: Use C++ exception handling.
2848         * common/selftest.c: Use C++ exception handling.
2849         * common/new-op.c: Use C++ exception handling.
2850         * cli/cli-script.c: Use C++ exception handling.
2851         * cli/cli-interp.c: Use C++ exception handling.
2852         * cli/cli-cmds.c: Use C++ exception handling.
2853         * c-varobj.c: Use C++ exception handling.
2854         * btrace.c: Use C++ exception handling.
2855         * breakpoint.c: Use C++ exception handling.
2856         * break-catch-throw.c: Use C++ exception handling.
2857         * arch-utils.c: Use C++ exception handling.
2858         * amd64-tdep.c: Use C++ exception handling.
2859         * ada-valprint.c: Use C++ exception handling.
2860         * ada-typeprint.c: Use C++ exception handling.
2861         * ada-lang.c: Use C++ exception handling.
2862         * aarch64-tdep.c: Use C++ exception handling.
2863
2864 2019-04-08  Tom Tromey  <tom@tromey.com>
2865
2866         * xml-support.c (gdb_xml_parser::parse): Update.
2867         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2868         * value.c (show_convenience): Update.
2869         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2870         (test_parse_flags_qcs): Update.
2871         * thread.c (thr_try_catch_cmd): Update.
2872         * target.c (target_translate_tls_address): Update.
2873         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2874         (info_frame_command_core, frame_apply_command_count): Update.
2875         * rust-exp.y (rust_lex_exception_test): Update.
2876         * riscv-tdep.c (riscv_print_one_register_info): Update.
2877         * remote.c (remote_target::enable_btrace): Update.
2878         * record-btrace.c (record_btrace_enable_warn): Update.
2879         * python/py-utils.c (gdbpy_convert_exception): Update.
2880         * printcmd.c (do_one_display, print_variable_and_value): Update.
2881         * mi/mi-main.c (mi_print_exception): Update.
2882         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2883         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2884         * linux-nat.c (linux_nat_target::attach): Update.
2885         * linux-fork.c (class scoped_switch_fork_info): Update.
2886         * infrun.c (displaced_step_prepare): Update.
2887         * infcall.c (call_function_by_hand_dummy): Update.
2888         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2889         * gnu-v3-abi.c (print_one_vtable): Update.
2890         * frame.c (get_prev_frame_always): Update.
2891         * f-valprint.c (info_common_command_for_block): Update.
2892         * exec.c (try_open_exec_file): Update.
2893         * exceptions.c (print_exception, exception_print)
2894         (exception_fprintf, exception_print_same): Update.
2895         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2896         * dwarf-index-cache.c (index_cache::store)
2897         (index_cache::lookup_gdb_index): Update.
2898         * darwin-nat.c (maybe_cache_shell): Update.
2899         * cp-valprint.c (cp_print_value_fields): Update.
2900         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2901         (gcc_cplus_symbol_address): Update.
2902         * compile/compile-c-symbols.c (gcc_convert_symbol)
2903         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2904         * common/selftest.c: Update.
2905         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2906         a std::string.
2907         (exception_try_scope_entry, exception_try_scope_exit): Don't
2908         declare.
2909         (struct exception_try_scope): Remove.
2910         (TRY): Don't use exception_try_scope.
2911         (struct gdb_exception): Add constructor, operator=.
2912         <what>: New method.
2913         (struct gdb_exception_RETURN_MASK_ALL)
2914         (struct gdb_exception_RETURN_MASK_ERROR)
2915         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2916         (struct gdb_quit_bad_alloc): Update.
2917         * common/common-exceptions.c (exception_none): Change
2918         initializer.
2919         (struct catcher) <state, exception>: Initialize inline.
2920         <prev>: Remove member.
2921         (current_catcher): Remove.
2922         (catchers): New global.
2923         (exceptions_state_mc_init): Simplify.
2924         (catcher_pop): Remove.
2925         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2926         (try_scope_depth, exception_try_scope_entry)
2927         (exception_try_scope_exit): Remove.
2928         (throw_exception_sjlj): Update.
2929         (exception_messages, exception_messages_size): Remove.
2930         (throw_it): Simplify.
2931         (gdb_exception_sliced_copy): Remove.
2932         (throw_exception_cxx): Update.
2933         * cli/cli-script.c (script_from_file): Update.
2934         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2935         Update.
2936         * ada-valprint.c (ada_val_print): Update.
2937         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2938         (create_excep_cond_exprs): Update.
2939
2940 2019-04-08  Tom Tromey  <tom@tromey.com>
2941
2942         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2943         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2944         (TRY, CATCH, END_CATCH): Remove some definitions.
2945         * common/common-exceptions.c: Don't use GDB_XCPT.
2946         (catcher_list_size): Remove.
2947         (throw_exception, throw_it): Simplify.
2948
2949 2019-04-05  Tom Tromey  <tom@tromey.com>
2950
2951         Revert the header-sorting patch.
2952         * ft32-tdep.c: Revert.
2953         * frv-tdep.c: Revert.
2954         * frv-linux-tdep.c: Revert.
2955         * frame.c: Revert.
2956         * frame-unwind.c: Revert.
2957         * frame-base.c: Revert.
2958         * fork-child.c: Revert.
2959         * findvar.c: Revert.
2960         * findcmd.c: Revert.
2961         * filesystem.c: Revert.
2962         * filename-seen-cache.h: Revert.
2963         * filename-seen-cache.c: Revert.
2964         * fbsd-tdep.c: Revert.
2965         * fbsd-nat.h: Revert.
2966         * fbsd-nat.c: Revert.
2967         * f-valprint.c: Revert.
2968         * f-typeprint.c: Revert.
2969         * f-lang.c: Revert.
2970         * extension.h: Revert.
2971         * extension.c: Revert.
2972         * extension-priv.h: Revert.
2973         * expprint.c: Revert.
2974         * exec.h: Revert.
2975         * exec.c: Revert.
2976         * exceptions.c: Revert.
2977         * event-top.c: Revert.
2978         * event-loop.c: Revert.
2979         * eval.c: Revert.
2980         * elfread.c: Revert.
2981         * dwarf2read.h: Revert.
2982         * dwarf2read.c: Revert.
2983         * dwarf2loc.c: Revert.
2984         * dwarf2expr.h: Revert.
2985         * dwarf2expr.c: Revert.
2986         * dwarf2-frame.c: Revert.
2987         * dwarf2-frame-tailcall.c: Revert.
2988         * dwarf-index-write.h: Revert.
2989         * dwarf-index-write.c: Revert.
2990         * dwarf-index-common.c: Revert.
2991         * dwarf-index-cache.h: Revert.
2992         * dwarf-index-cache.c: Revert.
2993         * dummy-frame.c: Revert.
2994         * dtrace-probe.c: Revert.
2995         * disasm.h: Revert.
2996         * disasm.c: Revert.
2997         * disasm-selftests.c: Revert.
2998         * dictionary.c: Revert.
2999         * dicos-tdep.c: Revert.
3000         * demangle.c: Revert.
3001         * dcache.h: Revert.
3002         * dcache.c: Revert.
3003         * darwin-nat.h: Revert.
3004         * darwin-nat.c: Revert.
3005         * darwin-nat-info.c: Revert.
3006         * d-valprint.c: Revert.
3007         * d-namespace.c: Revert.
3008         * d-lang.c: Revert.
3009         * ctf.c: Revert.
3010         * csky-tdep.c: Revert.
3011         * csky-linux-tdep.c: Revert.
3012         * cris-tdep.c: Revert.
3013         * cris-linux-tdep.c: Revert.
3014         * cp-valprint.c: Revert.
3015         * cp-support.c: Revert.
3016         * cp-namespace.c: Revert.
3017         * cp-abi.c: Revert.
3018         * corelow.c: Revert.
3019         * corefile.c: Revert.
3020         * continuations.c: Revert.
3021         * completer.h: Revert.
3022         * completer.c: Revert.
3023         * complaints.c: Revert.
3024         * coffread.c: Revert.
3025         * coff-pe-read.c: Revert.
3026         * cli-out.h: Revert.
3027         * cli-out.c: Revert.
3028         * charset.c: Revert.
3029         * c-varobj.c: Revert.
3030         * c-valprint.c: Revert.
3031         * c-typeprint.c: Revert.
3032         * c-lang.c: Revert.
3033         * buildsym.c: Revert.
3034         * buildsym-legacy.c: Revert.
3035         * build-id.h: Revert.
3036         * build-id.c: Revert.
3037         * btrace.c: Revert.
3038         * bsd-uthread.c: Revert.
3039         * breakpoint.h: Revert.
3040         * breakpoint.c: Revert.
3041         * break-catch-throw.c: Revert.
3042         * break-catch-syscall.c: Revert.
3043         * break-catch-sig.c: Revert.
3044         * blockframe.c: Revert.
3045         * block.c: Revert.
3046         * bfin-tdep.c: Revert.
3047         * bfin-linux-tdep.c: Revert.
3048         * bfd-target.c: Revert.
3049         * bcache.c: Revert.
3050         * ax-general.c: Revert.
3051         * ax-gdb.h: Revert.
3052         * ax-gdb.c: Revert.
3053         * avr-tdep.c: Revert.
3054         * auxv.c: Revert.
3055         * auto-load.c: Revert.
3056         * arm-wince-tdep.c: Revert.
3057         * arm-tdep.c: Revert.
3058         * arm-symbian-tdep.c: Revert.
3059         * arm-pikeos-tdep.c: Revert.
3060         * arm-obsd-tdep.c: Revert.
3061         * arm-nbsd-tdep.c: Revert.
3062         * arm-nbsd-nat.c: Revert.
3063         * arm-linux-tdep.c: Revert.
3064         * arm-linux-nat.c: Revert.
3065         * arm-fbsd-tdep.c: Revert.
3066         * arm-fbsd-nat.c: Revert.
3067         * arm-bsd-tdep.c: Revert.
3068         * arch-utils.c: Revert.
3069         * arc-tdep.c: Revert.
3070         * arc-newlib-tdep.c: Revert.
3071         * annotate.h: Revert.
3072         * annotate.c: Revert.
3073         * amd64-windows-tdep.c: Revert.
3074         * amd64-windows-nat.c: Revert.
3075         * amd64-tdep.c: Revert.
3076         * amd64-sol2-tdep.c: Revert.
3077         * amd64-obsd-tdep.c: Revert.
3078         * amd64-obsd-nat.c: Revert.
3079         * amd64-nbsd-tdep.c: Revert.
3080         * amd64-nbsd-nat.c: Revert.
3081         * amd64-nat.c: Revert.
3082         * amd64-linux-tdep.c: Revert.
3083         * amd64-linux-nat.c: Revert.
3084         * amd64-fbsd-tdep.c: Revert.
3085         * amd64-fbsd-nat.c: Revert.
3086         * amd64-dicos-tdep.c: Revert.
3087         * amd64-darwin-tdep.c: Revert.
3088         * amd64-bsd-nat.c: Revert.
3089         * alpha-tdep.c: Revert.
3090         * alpha-obsd-tdep.c: Revert.
3091         * alpha-nbsd-tdep.c: Revert.
3092         * alpha-mdebug-tdep.c: Revert.
3093         * alpha-linux-tdep.c: Revert.
3094         * alpha-linux-nat.c: Revert.
3095         * alpha-bsd-tdep.c: Revert.
3096         * alpha-bsd-nat.c: Revert.
3097         * aix-thread.c: Revert.
3098         * agent.c: Revert.
3099         * addrmap.c: Revert.
3100         * ada-varobj.c: Revert.
3101         * ada-valprint.c: Revert.
3102         * ada-typeprint.c: Revert.
3103         * ada-tasks.c: Revert.
3104         * ada-lang.c: Revert.
3105         * aarch64-tdep.c: Revert.
3106         * aarch64-ravenscar-thread.c: Revert.
3107         * aarch64-newlib-tdep.c: Revert.
3108         * aarch64-linux-tdep.c: Revert.
3109         * aarch64-linux-nat.c: Revert.
3110         * aarch64-fbsd-tdep.c: Revert.
3111         * aarch64-fbsd-nat.c: Revert.
3112         * aarch32-linux-nat.c: Revert.
3113
3114 2019-04-05  Tom Tromey  <tom@tromey.com>
3115
3116         * ft32-tdep.c: Sort headers.
3117         * frv-tdep.c: Sort headers.
3118         * frv-linux-tdep.c: Sort headers.
3119         * frame.c: Sort headers.
3120         * frame-unwind.c: Sort headers.
3121         * frame-base.c: Sort headers.
3122         * fork-child.c: Sort headers.
3123         * findvar.c: Sort headers.
3124         * findcmd.c: Sort headers.
3125         * filesystem.c: Sort headers.
3126         * filename-seen-cache.h: Sort headers.
3127         * filename-seen-cache.c: Sort headers.
3128         * fbsd-tdep.c: Sort headers.
3129         * fbsd-nat.h: Sort headers.
3130         * fbsd-nat.c: Sort headers.
3131         * f-valprint.c: Sort headers.
3132         * f-typeprint.c: Sort headers.
3133         * f-lang.c: Sort headers.
3134         * extension.h: Sort headers.
3135         * extension.c: Sort headers.
3136         * extension-priv.h: Sort headers.
3137         * expprint.c: Sort headers.
3138         * exec.h: Sort headers.
3139         * exec.c: Sort headers.
3140         * exceptions.c: Sort headers.
3141         * event-top.c: Sort headers.
3142         * event-loop.c: Sort headers.
3143         * eval.c: Sort headers.
3144         * elfread.c: Sort headers.
3145         * dwarf2read.h: Sort headers.
3146         * dwarf2read.c: Sort headers.
3147         * dwarf2loc.c: Sort headers.
3148         * dwarf2expr.h: Sort headers.
3149         * dwarf2expr.c: Sort headers.
3150         * dwarf2-frame.c: Sort headers.
3151         * dwarf2-frame-tailcall.c: Sort headers.
3152         * dwarf-index-write.h: Sort headers.
3153         * dwarf-index-write.c: Sort headers.
3154         * dwarf-index-common.c: Sort headers.
3155         * dwarf-index-cache.h: Sort headers.
3156         * dwarf-index-cache.c: Sort headers.
3157         * dummy-frame.c: Sort headers.
3158         * dtrace-probe.c: Sort headers.
3159         * disasm.h: Sort headers.
3160         * disasm.c: Sort headers.
3161         * disasm-selftests.c: Sort headers.
3162         * dictionary.c: Sort headers.
3163         * dicos-tdep.c: Sort headers.
3164         * demangle.c: Sort headers.
3165         * dcache.h: Sort headers.
3166         * dcache.c: Sort headers.
3167         * darwin-nat.h: Sort headers.
3168         * darwin-nat.c: Sort headers.
3169         * darwin-nat-info.c: Sort headers.
3170         * d-valprint.c: Sort headers.
3171         * d-namespace.c: Sort headers.
3172         * d-lang.c: Sort headers.
3173         * ctf.c: Sort headers.
3174         * csky-tdep.c: Sort headers.
3175         * csky-linux-tdep.c: Sort headers.
3176         * cris-tdep.c: Sort headers.
3177         * cris-linux-tdep.c: Sort headers.
3178         * cp-valprint.c: Sort headers.
3179         * cp-support.c: Sort headers.
3180         * cp-namespace.c: Sort headers.
3181         * cp-abi.c: Sort headers.
3182         * corelow.c: Sort headers.
3183         * corefile.c: Sort headers.
3184         * continuations.c: Sort headers.
3185         * completer.h: Sort headers.
3186         * completer.c: Sort headers.
3187         * complaints.c: Sort headers.
3188         * coffread.c: Sort headers.
3189         * coff-pe-read.c: Sort headers.
3190         * cli-out.h: Sort headers.
3191         * cli-out.c: Sort headers.
3192         * charset.c: Sort headers.
3193         * c-varobj.c: Sort headers.
3194         * c-valprint.c: Sort headers.
3195         * c-typeprint.c: Sort headers.
3196         * c-lang.c: Sort headers.
3197         * buildsym.c: Sort headers.
3198         * buildsym-legacy.c: Sort headers.
3199         * build-id.h: Sort headers.
3200         * build-id.c: Sort headers.
3201         * btrace.c: Sort headers.
3202         * bsd-uthread.c: Sort headers.
3203         * breakpoint.h: Sort headers.
3204         * breakpoint.c: Sort headers.
3205         * break-catch-throw.c: Sort headers.
3206         * break-catch-syscall.c: Sort headers.
3207         * break-catch-sig.c: Sort headers.
3208         * blockframe.c: Sort headers.
3209         * block.c: Sort headers.
3210         * bfin-tdep.c: Sort headers.
3211         * bfin-linux-tdep.c: Sort headers.
3212         * bfd-target.c: Sort headers.
3213         * bcache.c: Sort headers.
3214         * ax-general.c: Sort headers.
3215         * ax-gdb.h: Sort headers.
3216         * ax-gdb.c: Sort headers.
3217         * avr-tdep.c: Sort headers.
3218         * auxv.c: Sort headers.
3219         * auto-load.c: Sort headers.
3220         * arm-wince-tdep.c: Sort headers.
3221         * arm-tdep.c: Sort headers.
3222         * arm-symbian-tdep.c: Sort headers.
3223         * arm-pikeos-tdep.c: Sort headers.
3224         * arm-obsd-tdep.c: Sort headers.
3225         * arm-nbsd-tdep.c: Sort headers.
3226         * arm-nbsd-nat.c: Sort headers.
3227         * arm-linux-tdep.c: Sort headers.
3228         * arm-linux-nat.c: Sort headers.
3229         * arm-fbsd-tdep.c: Sort headers.
3230         * arm-fbsd-nat.c: Sort headers.
3231         * arm-bsd-tdep.c: Sort headers.
3232         * arch-utils.c: Sort headers.
3233         * arc-tdep.c: Sort headers.
3234         * arc-newlib-tdep.c: Sort headers.
3235         * annotate.h: Sort headers.
3236         * annotate.c: Sort headers.
3237         * amd64-windows-tdep.c: Sort headers.
3238         * amd64-windows-nat.c: Sort headers.
3239         * amd64-tdep.c: Sort headers.
3240         * amd64-sol2-tdep.c: Sort headers.
3241         * amd64-obsd-tdep.c: Sort headers.
3242         * amd64-obsd-nat.c: Sort headers.
3243         * amd64-nbsd-tdep.c: Sort headers.
3244         * amd64-nbsd-nat.c: Sort headers.
3245         * amd64-nat.c: Sort headers.
3246         * amd64-linux-tdep.c: Sort headers.
3247         * amd64-linux-nat.c: Sort headers.
3248         * amd64-fbsd-tdep.c: Sort headers.
3249         * amd64-fbsd-nat.c: Sort headers.
3250         * amd64-dicos-tdep.c: Sort headers.
3251         * amd64-darwin-tdep.c: Sort headers.
3252         * amd64-bsd-nat.c: Sort headers.
3253         * alpha-tdep.c: Sort headers.
3254         * alpha-obsd-tdep.c: Sort headers.
3255         * alpha-nbsd-tdep.c: Sort headers.
3256         * alpha-mdebug-tdep.c: Sort headers.
3257         * alpha-linux-tdep.c: Sort headers.
3258         * alpha-linux-nat.c: Sort headers.
3259         * alpha-bsd-tdep.c: Sort headers.
3260         * alpha-bsd-nat.c: Sort headers.
3261         * aix-thread.c: Sort headers.
3262         * agent.c: Sort headers.
3263         * addrmap.c: Sort headers.
3264         * ada-varobj.c: Sort headers.
3265         * ada-valprint.c: Sort headers.
3266         * ada-typeprint.c: Sort headers.
3267         * ada-tasks.c: Sort headers.
3268         * ada-lang.c: Sort headers.
3269         * aarch64-tdep.c: Sort headers.
3270         * aarch64-ravenscar-thread.c: Sort headers.
3271         * aarch64-newlib-tdep.c: Sort headers.
3272         * aarch64-linux-tdep.c: Sort headers.
3273         * aarch64-linux-nat.c: Sort headers.
3274         * aarch64-fbsd-tdep.c: Sort headers.
3275         * aarch64-fbsd-nat.c: Sort headers.
3276         * aarch32-linux-nat.c: Sort headers.
3277
3278 2019-04-04  Tom Tromey  <tom@tromey.com>
3279
3280         * varobj.c (varobj_create): Update.
3281         * rust-exp.y (struct rust_parser) <update_innermost_block,
3282         lookup_symbol>: New methods.
3283         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3284         Rename.
3285         (rust_parser::rust_lookup_type)
3286         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3287         * printcmd.c (display_command, do_one_display): Update.
3288         * parser-defs.h (struct parser_state) <parser_state>: Add
3289         "tracker" parameter.
3290         (block_tracker): New member.
3291         (class innermost_block_tracker) <innermost_block_tracker>: Add
3292         "types" parameter.
3293         <reset>: Remove method.
3294         (innermost_block): Don't declare.
3295         (null_post_parser): Update.
3296         * parse.c (innermost_block): Remove global.
3297         (write_dollar_variable): Update.
3298         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3299         Remove "tracker_types" parameter.
3300         (parse_expression): Add "tracker" parameter.
3301         (parse_expression_for_completion): Update.
3302         (null_post_parser): Add "tracker" parameter.
3303         * p-exp.y: Update rules.
3304         * m2-exp.y: Update rules.
3305         * language.h (struct language_defn) <la_post_parser>: Add
3306         "tracker" parameter.
3307         * go-exp.y: Update rules.
3308         * f-exp.y: Update rules.
3309         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3310         parameter.
3311         * d-exp.y: Update rules.
3312         * c-exp.y: Update rules.
3313         * breakpoint.c (set_breakpoint_condition): Create an
3314         innermost_block_tracker.
3315         (watch_command_1): Likewise.
3316         * ada-lang.c (resolve): Add "tracker" parameter.
3317         (resolve_subexp): Likewise.
3318         * ada-exp.y (write_var_from_sym): Update.
3319
3320 2019-04-04  Tom Tromey  <tom@tromey.com>
3321
3322         * type-stack.h: New file.
3323         * type-stack.c: New file.
3324         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3325         type-stack.h.
3326         (insert_into_type_stack, insert_type, push_type, push_type_int)
3327         (insert_type_address_space, pop_type, pop_type_int)
3328         (pop_typelist, pop_type_stack, append_type_stack)
3329         (push_type_stack, get_type_stack, push_typelist)
3330         (follow_type_instance_flags, follow_types): Don't declare.
3331         * parse.c (type_stack): Remove global.
3332         (parse_exp_in_context): Update.
3333         (insert_into_type_stack, insert_type, push_type, push_type_int)
3334         (insert_type_address_space, pop_type, pop_type_int)
3335         (pop_typelist, pop_type_stack, append_type_stack)
3336         (push_type_stack, get_type_stack, push_typelist)
3337         (follow_type_instance_flags, follow_types): Remove (moved to
3338         type-stack.c).
3339         * f-exp.y (type_stack): New global.
3340         Update rules.
3341         (push_kind_type, f_parse): Update.
3342         * d-exp.y (type_stack): New global.
3343         Update rules.
3344         (d_parse): Update.
3345         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3346         Update rules.
3347         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3348         (HFILES_NO_SRCDIR): Add type-stack.h.
3349
3350 2019-04-04  Tom Tromey  <tom@tromey.com>
3351
3352         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3353         (rust_parser::convert_ast_to_expression, rust_parse)
3354         (rust_lex_test_completion, rust_lex_tests): Update.
3355         * parser-defs.h (struct expr_completion_state): New.
3356         (struct parser_state) <parser_state>: Add completion parameter.
3357         <mark_struct_expression, mark_completion_tag>: New methods.
3358         <parse_completion, m_completion_state>: New members.
3359         (prefixify_expression, null_post_parser): Update.
3360         (mark_struct_expression, mark_completion_tag): Don't declare.
3361         * parse.c (parse_completion, expout_last_struct)
3362         (expout_tag_completion_type, expout_completion_name): Remove
3363         globals.
3364         (parser_state::mark_struct_expression)
3365         (parser_state::mark_completion_tag): Now methods.
3366         (prefixify_expression): Add last_struct parameter.
3367         (prefixify_subexp): Likewise.
3368         (parse_exp_1): Update.
3369         (parse_exp_in_context): Add cstate parameter.  Update.
3370         (parse_expression_for_completion): Create an
3371         expr_completion_state.
3372         (null_post_parser): Add "completion" parameter.
3373         * p-exp.y: Update rules.
3374         (yylex): Update.
3375         * language.h (struct language_defn) <la_post_parser>: Add
3376         "completing" parameter.
3377         * go-exp.y: Update rules.
3378         (lex_one_token): Update.
3379         * expression.h (parse_completion): Don't declare.
3380         * d-exp.y: Update rules.
3381         (lex_one_token): Update rules.
3382         * c-exp.y: Update rules.
3383         (lex_one_token): Update.
3384         * ada-lang.c (resolve): Add "parse_completion" parameter.
3385         (resolve_subexp): Likewise.
3386         (ada_resolve_function): Likewise.
3387
3388 2019-04-04  Tom Tromey  <tom@tromey.com>
3389
3390         * parser-defs.h (struct parser_state) <start_arglist,
3391         end_arglist>: New methods.
3392         <arglist_len, m_funcall_chain>: New members.
3393         (arglist_len, start_arglist, end_arglist): Don't declare.
3394         * parse.c (arglist_len, funcall_chain): Remove global.
3395         (start_arglist, end_arglist): Remove functions.
3396         (parse_exp_in_context): Update.
3397         * p-exp.y: Update rules.
3398         * m2-exp.y: Update rules.
3399         * go-exp.y: Update rules.
3400         * f-exp.y: Update rules.
3401         * d-exp.y: Update rules.
3402         * c-exp.y: Update rules.
3403
3404 2019-04-04  Tom Tromey  <tom@tromey.com>
3405
3406         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3407         lex_operator, push_back>: New methods.
3408         Update all rules.
3409         (rust_parser::lex_hex, lex_escape): Rename and update.
3410         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3411         (rust_parser::lex_operator): Rename and update.
3412         (rust_parser::lex_number, rustyylex, rustyyerror)
3413         (rust_lex_test_init, rust_lex_test_sequence)
3414         (rust_lex_test_push_back, rust_lex_tests): Update.
3415         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3416         parameter.
3417         <lexptr, prev_lexptr>: New members.
3418         (lexptr, prev_lexptr): Don't declare.
3419         * parse.c (lexptr, prev_lexptr): Remove globals.
3420         (parse_exp_in_context): Update.
3421         * p-exp.y (yylex, yyerror): Update.
3422         * m2-exp.y (parse_number, yylex, yyerror): Update.
3423         * go-exp.y (lex_one_token, yyerror): Update.
3424         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3425         * d-exp.y (lex_one_token, yyerror): Update.
3426         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3427         (lex_one_token, yyerror): Update.
3428         * ada-lex.l (YY_INPUT): Update.
3429         (rewind_to_char): Update.
3430         * ada-exp.y (yyerror): Update.
3431
3432 2019-04-04  Tom Tromey  <tom@tromey.com>
3433
3434         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3435         * parser-defs.h (struct parser_state) <parser_state>: Add new
3436         parameter.
3437         <comma_terminates>: New member.
3438         (comma_terminates): Don't declare global.
3439         * parse.c (comma_terminates): Remove global.
3440         (parse_exp_in_context): Update.
3441         * p-exp.y (yylex): Update.
3442         * m2-exp.y (yylex): Update.
3443         * go-exp.y (lex_one_token): Update.
3444         * f-exp.y (yylex): Update.
3445         * d-exp.y (lex_one_token): Update.
3446         * c-exp.y (lex_one_token): Update.
3447         * ada-lex.l: Update.
3448
3449 2019-04-04  Tom Tromey  <tom@tromey.com>
3450
3451         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3452         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3453         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3454         * parser-defs.h (paren_depth): Don't declare.
3455         * parse.c (paren_depth): Remove global.
3456         (parse_exp_in_context): Update.
3457         * p-exp.y (paren_depth): New global.
3458         (pascal_parse): Initialize it.
3459         * m2-exp.y (paren_depth): New global.
3460         (m2_parse): Initialize it.
3461         * go-exp.y (paren_depth): New global.
3462         (go_parse): Initialize it.
3463         * f-exp.y (paren_depth): New global.
3464         (f_parse): Initialize it.
3465         * d-exp.y (paren_depth): New global.
3466         (d_parse): Initialize it.
3467         * c-exp.y (paren_depth): New global.
3468         (c_parse): Initialize it.
3469         * ada-lex.l (paren_depth): New global.
3470         (lexer_init): Initialize it.
3471
3472 2019-04-04  Tom Tromey  <tom@tromey.com>
3473
3474         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3475         (rust_parser::convert_ast_to_type)
3476         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3477         * parser-defs.h (struct parser_state) <parser_state>: Add
3478         parameters.  Initialize new members.
3479         <expression_context_block, expression_context_pc>: New members.
3480         * parse.c (expression_context_block, expression_context_pc):
3481         Remove globals.
3482         (parse_exp_in_context): Update.
3483         * p-exp.y: Update all rules.
3484         (yylex): Update.
3485         * m2-exp.y: Update all rules.
3486         (yylex): Update.
3487         * go-exp.y (yylex): Update.
3488         * f-exp.y (yylex): Update.
3489         * d-exp.y: Update all rules.
3490         (yylex): Update.
3491         * c-exp.y: Update all rules.
3492         (lex_one_token, classify_name, yylex, c_parse): Update.
3493         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3494
3495 2019-04-04  Tom Tromey  <tom@tromey.com>
3496
3497         * gdbarch.h, gdbarch.c: Rebuild.
3498         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3499         * stap-probe.h:
3500         (struct stap_parse_info): Replace "parser_state" with
3501         "expr_builder".
3502         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3503         (parser_state): New class.
3504         * parse.c (expr_builder): Rename.
3505         (expr_builder::release): Rename.
3506         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3507         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3508         (write_exp_elt_longcst, write_exp_elt_floatcst)
3509         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3510         (write_exp_string_vector, write_exp_bitstring)
3511         (write_exp_msymbol, mark_struct_expression)
3512         (write_dollar_variable)
3513         (insert_type_address_space, increase_expout_size): Replace
3514         "parser_state" with "expr_builder".
3515         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3516         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3517         "parser_state" with "expr_builder".
3518
3519 2019-04-04  Tom Tromey  <tom@tromey.com>
3520
3521         * rust-exp.y: Replace "parse_language" with method call.
3522         * p-exp.y:
3523         (yylex): Replace "parse_language" with method call.
3524         * m2-exp.y:
3525         (yylex): Replace "parse_language" with method call.
3526         * go-exp.y (classify_name): Replace "parse_language" with method
3527         call.
3528         * f-exp.y (yylex): Replace "parse_language" with method call.
3529         * d-exp.y (lex_one_token): Replace "parse_language" with method
3530         call.
3531         * c-exp.y:
3532         (lex_one_token, classify_name, yylex): Replace "parse_language"
3533         with method call.
3534         * ada-exp.y (find_primitive_type, type_char)
3535         (type_system_address): Replace "parse_language" with method call.
3536
3537 2019-04-04  Tom Tromey  <tom@tromey.com>
3538
3539         * rust-exp.y: Replace "parse_gdbarch" with method call.
3540         * parse.c (write_dollar_variable, insert_type_address_space):
3541         Replace "parse_gdbarch" with method call.
3542         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3543         call.
3544         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3545         call.
3546         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3547         "parse_gdbarch" with method call.
3548         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3549         with method call.
3550         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3551         "parse_gdbarch" with method call.
3552         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3553         "parse_gdbarch" with method call.
3554         * c-exp.y (parse_type, parse_number, classify_name): Replace
3555         "parse_gdbarch" with method call.
3556         * ada-lex.l: Replace "parse_gdbarch" with method call.
3557         * ada-exp.y (parse_type, find_primitive_type, type_char)
3558         (type_system_address): Replace "parse_gdbarch" with method call.
3559
3560 2019-04-04  Tom Tromey  <tom@tromey.com>
3561
3562         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3563         * stap-probe.c (stap_parse_argument): Update.
3564         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3565         initial_size parameter.
3566         * rust-exp.y (rust_lex_tests): Update.
3567         * parse.c (parser_state): Update.
3568         (parse_exp_in_context): Update.
3569         * parser-defs.h (struct parser_state) <parser_state>: Remove
3570         "initial_size" parameter.
3571
3572 2019-04-04  Tom Tromey  <tom@tromey.com>
3573
3574         * parser-defs.h (increase_expout_size): Don't declare.
3575         * parse.c (increase_expout_size): Now static.
3576
3577 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3578
3579         * gnu-nat.c (gnu_nat_target::wait): Fix
3580         target_waitstatus_to_string call.
3581
3582 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3583
3584         * eval.c (evaluate_subexp_standard): Handle internal functions
3585         during Fortran function call handling.
3586
3587 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * NEWS: Mention new internal functions.
3590         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3591         (read_base_type): Use dwarf2_init_complex_target_type.
3592         * value.c (creal_internal_fn): New function.
3593         (cimag_internal_fn): New function.
3594         (_initialize_values): Register new internal functions.
3595
3596 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3597
3598         * infrun.c (stop_all_threads): If debug_infrun, always
3599         trace the wait status after wait_one, using
3600         target_waitstatus_to_string and target_pid_to_str.
3601         (handle_inferior_event): Replace various trace of
3602         wait status kind by a single trace.
3603         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3604         wait status kind image by target_waitstatus_to_string.
3605         * target/waitstatus.c (target_waitstatus_to_string): Fix
3606         obsolete comment.
3607
3608 2019-04-01  Tom Tromey  <tromey@adacore.com>
3609
3610         PR symtab/23331:
3611         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3612
3613 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3614             Pedro Alves  <palves@redhat.com>
3615
3616         * top.c (quit_force): Call 'finalize_values'.
3617         * value.c (finalize_values): New function.
3618         * value.h (finalize_values): Declare.
3619
3620 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3621
3622         * NEWS: Announce $_gdb_major and $_gdb_minor.
3623
3624         * top.c (init_gdb_version_vars): New function.
3625         (gdb_init): Call init_gdb_version_vars.
3626
3627 2019-03-29  Tom Tromey  <tromey@adacore.com>
3628
3629         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3630         help text.  Remove dead code.
3631
3632 2019-03-29  Keith Seitz  <keiths@redhat.com>
3633
3634         From Siddhesh Poyarekar:
3635         * f-lang.h (f77_get_upperbound): Return LONGEST.
3636         (f77_get_lowerbound): Likewise.
3637         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3638         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3639         print them.
3640         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3641         plongest to format print it.
3642         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3643         (f77_get_upperbound): Likewise.
3644         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3645         LOWER_BOUND to LONGEST.
3646         (f77_create_arrayprint_offset_tbl): Likewise.
3647
3648 2019-03-29  Keith Seitz  <keiths@redhat.com>
3649
3650         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3651         %s/pulongest for TYPE_LENGTH instead of %d in format
3652         strings.
3653         * ada-typerint.c (ada_print_type): Likewise.
3654         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3655         * compile/compile-c-support.c (generate_register_struct): Likewise.
3656         * gdbtypes.c (recursive_dump_type): Likewise.
3657         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3658         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3659         instead of %d in format strings.
3660         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3661         to std::min to ULONGEST.
3662         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3663         instead of %d in format strings.
3664         * tracepoint.c (info_scope_command): Likewise.
3665         * typeprint.c (print_offset_data::update)
3666         (print_offset_data::finish): Likewise.
3667         * xtensa-tdep.c (xtensa_store_return_value)
3668         (xtensa_push_dummy_call): Likewise.
3669
3670 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3671
3672         * windows-nat.c (display_selector): Fixed format specifications
3673         for 64-bit Cygwin.
3674
3675 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3676
3677         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3678
3679 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3680
3681         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3682         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3683         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3684         (nios2_linux_init_abi): Install it.
3685
3686 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3687
3688         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3689
3690 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3691
3692         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3693
3694 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3695             Tom Tromey  <tromey@adacore.com>
3696
3697         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3698
3699 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3700
3701         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3702         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3703         method to compute the bounds of range types. Also print "[evaluated]"
3704         if the bounds' values come from a dynamic evaluation.
3705
3706 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3709         whitespace when pretty printing is on.
3710
3711 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3712
3713         * ppc-linux-nat.c: Add include.
3714
3715 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3716
3717         * NEWS: Mention AArch64 Pointer Authentication.
3718
3719 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3720
3721         * arm-linux-nat.c: Add include.
3722
3723 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3724
3725         * source-cache.c (source_cache::get_source_lines): Re-read
3726         fullname after calling open_source_file.
3727
3728 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3729
3730         * NEWS: Mention TLS support for FreeBSD.
3731
3732 2019-03-25  Tom Tromey  <tromey@adacore.com>
3733
3734         * minsyms.c (BUNCH_SIZE): Update comment.
3735         (~minimal_symbol_reader): Remove old comment.
3736         (compact_minimal_symbols): Update comment.
3737         (minimal_symbol_reader::install): Remove old comment.  Update
3738         other comments.
3739
3740 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3741
3742         * s390-linux-nat.c: Add include.
3743
3744 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3745
3746         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3747         Call linux_get_hwcap.
3748         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3749         Likewise.
3750         (aarch64_linux_get_hwcap): Remove function.
3751         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3752         declaration.
3753         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3754         linux_get_hwcap.
3755         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3756         * linux-tdep.c (linux_get_hwcap): Add function.
3757         (linux_get_hwcap2): Likewise.
3758         * linux-tdep.h (linux_get_hwcap): Add declaration.
3759         (linux_get_hwcap2): Likewise.
3760         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3761         (ppc_linux_get_hwcap2): Likewise.
3762         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3763         linux_get_hwcap.
3764         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3765         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3766         (ppc_linux_nat_target::read_description): Likewise.
3767         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3768         * s390-linux-nat.c: Likewise.
3769         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3770
3771 2019-03-24  Tom Tromey  <tom@tromey.com>
3772
3773         * ada-lang.c (standard_lookup): Simplify initialization.
3774         (ada_lookup_symbol_nonlocal): Simplify return.
3775         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3776         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3777         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3778         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3779         initialization.
3780         * solib.c (solib_global_lookup): Simplify.
3781         * symtab.c (null_block_symbol): Remove.
3782         (symbol_cache_lookup): Simplify returns.
3783         (lookup_language_this): Simplify returns.
3784         (lookup_symbol_aux): Simplify return.
3785         (lookup_local_symbol): Simplify returns.
3786         (lookup_global_symbol_from_objfile): Simplify return.
3787         (lookup_symbol_in_objfile_symtabs)
3788         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3789         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3790         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3791         * cp-namespace.c (cp_lookup_bare_symbol)
3792         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3793         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3794         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3795         (cp_lookup_symbol_via_imports): Simplify initialization.
3796         (find_symbol_in_baseclass): Likewise.
3797         * symtab.h (null_block_symbol): Remove.
3798         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3799         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3800         (d_lookup_symbol_module): Likewise.
3801         (find_symbol_in_baseclass): Simplify initialization.
3802
3803 2019-03-24  Tom Tromey  <tom@tromey.com>
3804
3805         * expression.h: Don't include symtab.h.
3806         (struct block): Forward declare.
3807
3808 2019-03-24  Tom Tromey  <tom@tromey.com>
3809
3810         * c-exp.y (typebase): Remove casts.
3811         * gdbtypes.c (lookup_unsigned_typename, )
3812         (lookup_signed_typename): Remove cast.
3813         * eval.c (parse_to_comma_and_eval): Remove cast.
3814         * parse.c (write_dollar_variable): Remove cast.
3815         * block.h (struct block) <superblock>: Now const.
3816         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3817         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3818         (map_block): Make "block" const.
3819         * symfile.h (struct quick_symbol_functions)
3820         <map_matching_symbols>: Constify block argument to "callback".
3821         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3822         const.
3823         (find_pc_sect_compunit_symtab): Make "b" const.
3824         (find_symbol_at_address): Likewise.
3825         (search_symbols): Likewise.
3826         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3827         (dw2_debug_names_lookup_symbol): Likewise.
3828         (dw2_map_matching_symbols): Update.
3829         * p-valprint.c (pascal_val_print): Remove "block".
3830         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3831         (aux_add_nonlocal_symbols): Make "block" const.
3832         (resolve_subexp): Remove cast.
3833         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3834         const.
3835         (iterate_over_file_blocks): Likewise.
3836         * f-exp.y (%union) <bval>: Remove.
3837         * coffread.c (patch_opaque_types): Make "b" const.
3838         * spu-tdep.c (spu_catch_start): Make "block" const.
3839         * c-valprint.c (print_unpacked_pointer): Remove "block".
3840         * symmisc.c (dump_symtab_1): Make "b" const.
3841         (block_depth): Make "block" const.
3842         * d-exp.y (%union) <bval>: Remove.
3843         * cp-support.h (cp_lookup_rtti_type): Update.
3844         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3845         * psymtab.c (psym_lookup_symbol): Make "block" const.
3846         (maintenance_check_psymtabs): Make "b" const.
3847         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3848         (enumerate_locals, enumerate_args): Update.
3849         * python/py-symtab.c (stpy_global_block): Make "block" const.
3850         (stpy_static_block): Likewise.
3851         * inline-frame.c (block_starting_point_at): Make "new_block"
3852         const.
3853         * block.c (find_block_in_blockvector): Make return type const.
3854         (blockvector_for_pc_sect): Make "b" const.
3855         (find_block_in_blockvector): Make "b" const.
3856
3857 2019-03-23  Tom Tromey  <tom@tromey.com>
3858
3859         * varobj.c (varobj_create): Update.
3860         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3861         * printcmd.c (display_command, do_one_display): Don't reset
3862         innermost_block.
3863         * parser-defs.h (enum innermost_block_tracker_type): Move to
3864         expression.h.
3865         (innermost_block): Update comment.
3866         * parse.c (parse_exp_1): Add tracker_types parameter.
3867         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3868         tracker_types parameter.  Reset innermost_block.
3869         (parse_exp_in_context): Remove.
3870         (parse_expression_for_completion): Update.
3871         * objfiles.c (~objfile): Don't reset expression_context_block or
3872         innermost_block.
3873         * expression.h (enum innermost_block_tracker_type): Move from
3874         parser-defs.h.
3875         (parse_exp_1): Add tracker_types parameter.
3876         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3877         reset innermost_block.
3878
3879 2019-03-23  Tom Tromey  <tom@tromey.com>
3880
3881         * objfiles.h: Include bcache.h.
3882
3883 2019-03-23  Tom Tromey  <tom@tromey.com>
3884
3885         * linespec.c (get_current_search_block): Use
3886         scoped_restore_current_language.
3887         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3888
3889 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3890             Jiong Wang  <jiong.wang@arm.com>
3891
3892         * aarch64-linux-tdep.c
3893         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3894         section.
3895         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3896
3897 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3898             Jiong Wang  <jiong.wang@arm.com>
3899
3900         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3901         instructions.
3902         (aarch64_analyze_prologue_test): Add PACIASP test.
3903         (aarch64_prologue_prev_register): Unmask PC value.
3904
3905 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3906             Jiong Wang  <jiong.wang@arm.com>
3907
3908         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3909         (aarch64_dwarf2_prev_register): Unmask PC value.
3910         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3911         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3912         DW_CFA_AARCH64_negate_ra_state.
3913         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3914
3915 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3916             Jiong Wang  <jiong.wang@arm.com>
3917
3918         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3919         registers.
3920         (aarch64_pseudo_register_name): Likewise.
3921         (aarch64_pseudo_register_type): Likewise.
3922         (aarch64_pseudo_register_reggroup_p): Likewise.
3923         (aarch64_gdbarch_init): Add pauth registers.
3924         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3925         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3926         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3927         (struct gdbarch_tdep): Add regnum for ra_state.
3928
3929 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3930             Jiong Wang  <jiong.wang@arm.com>
3931
3932         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3933
3934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3935             Jiong Wang  <jiong.wang@arm.com>
3936
3937         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3938         function.
3939         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3940         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3941         (aarch64_gdbarch_init): Add puth registers.
3942         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3943         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3944         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3945
3946 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3947             Jiong Wang  <jiong.wang@arm.com>
3948
3949         * aarch64-linux-nat.c
3950         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3951         * aarch64-linux-tdep.c
3952         (aarch64_linux_core_read_description): Likewise.
3953         (aarch64_linux_get_hwcap): New function.
3954         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3955         (aarch64_linux_get_hwcap): New declaration.
3956
3957 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3958             Jiong Wang  <jiong.wang@arm.com>
3959
3960         * aarch64-linux-nat.c
3961         (aarch64_linux_nat_target::read_description): Add pauth param.
3962         * aarch64-linux-tdep.c
3963         (aarch64_linux_core_read_description): Likewise.
3964         * aarch64-tdep.c (struct target_desc): Add in pauth.
3965         (aarch64_read_description): Add pauth param.
3966         (aarch64_gdbarch_init): Likewise.
3967         * aarch64-tdep.h (aarch64_read_description): Likewise.
3968         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3969         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3970         * features/Makefile: Add new files.
3971         * features/aarch64-pauth.c: New file.
3972         * features/aarch64-pauth.xml: New file.
3973
3974 2019-03-20  Tom Tromey  <tromey@adacore.com>
3975
3976         * infrun.c (handle_inferior_event): Rename from
3977         handle_inferior_event_1.  Create a scoped_value_mark.
3978         (handle_inferior_event): Remove.
3979
3980 2019-03-19  Tom Tromey  <tromey@adacore.com>
3981
3982         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3983         * infrun.h (print_stop_event): Add "displays" parameter.
3984         * infrun.c (print_stop_event): Add "displays" parameter.
3985
3986 2019-03-19  Pedro Alves  <palves@redhat.com>
3987
3988         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3989         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3990         to -1.  Fix TABs vs spaces.
3991         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3992         * tui/tui-out.h (tui_ui_out) Add intro comments.
3993         <m_line, m_start_of_line>: In-class initialize, and add describing
3994         comment.
3995
3996 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3997
3998         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3999         variable names.
4000         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4001
4002 2019-03-18  Pedro Alves  <palves@redhat.com>
4003             Eli Zaretskii <eliz@gnu.org>
4004
4005         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4006         m_line and m_start_of_line.
4007
4008 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4009
4010         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4011         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4012         it returns a newline.  This fixes a regression in TU mode, whereby
4013         the next line is output on the same screen line as the user input.
4014
4015 2019-03-18  Tom Tromey  <tromey@adacore.com>
4016
4017         * minsyms.c (minimal_symbol_reader::install): Remove call to
4018         obstack_blank.
4019
4020 2019-03-18  Pedro Alves  <palves@redhat.com>
4021
4022         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4023         New globals.
4024         (apply_style): New, factored out from ...
4025         (apply_ansi_escape): ... this.  Handle reverse video mode.
4026         (tui_set_reverse_mode): New function.
4027         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4028         * tui/tui-winsource.c (tui_show_source_line): Use
4029         tui_set_reverse_mode instead of setting A_STANDOUT.
4030         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4031         New setter methods.
4032
4033 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4034
4035         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4036         Handle tabs.
4037
4038 2019-03-18  Tom Tromey  <tromey@adacore.com>
4039
4040         * ada-lang.c (empty_array): Add "high" parameter.
4041         (ada_evaluate_subexp): Update.
4042
4043 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4044
4045         * unittests/string_view-selftests.c: Define
4046         _initialize_string_view_selftests unconditionally.
4047
4048 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4049
4050         PR gdb/24350
4051         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4052
4053 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4054
4055         PR gdb/24351
4056         * windows-nat.c (display_selector): Fix format specifiers.
4057
4058 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4059
4060         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4061         tui_refill_source_window instead of tui_refresh_win, to update the
4062         current execution line.  This fixes redisplay of the current line
4063         when stepping through the code with "next" or "step".
4064
4065 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4066
4067         * source-cache.c (source_cache::get_source_lines): Call
4068         find_source_lines to initialize s->nlines.  This fixes vertical
4069         scrolling of TUI source window when the DOWN arrow is pressed.
4070
4071 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4072
4073         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4074         linux-thread-db.c (_initialize_thread_db): Likewise.
4075
4076 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4077
4078         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4079         wclrtoeol in tui_show_source_line".  This reverts changes made in
4080         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4081
4082 2019-03-15  Tom Tromey  <tom@tromey.com>
4083
4084         * symtab.h (struct minimal_symbol): Derive from
4085         general_symbol_info.
4086         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4087         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4088         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4089         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4090         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4091         (MSYMBOL_SEARCH_NAME): Update.
4092         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4093         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4094         * minsyms.c (minimal_symbol_reader::record_full): Update.
4095
4096 2019-03-15  Tom Tromey  <tom@tromey.com>
4097
4098         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4099
4100 2019-03-15  Tom Tromey  <tom@tromey.com>
4101
4102         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4103         unique_xmalloc_ptr.
4104         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4105         Update.
4106         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4107         (build_minimal_symbol_hash_tables)
4108         (minimal_symbol_reader::install): Update.
4109
4110 2019-03-15  Tom Tromey  <tom@tromey.com>
4111
4112         * symtab.c (create_demangled_names_hash): Update.
4113         (symbol_set_names): Update.
4114         * objfiles.h (struct objfile_per_bfd_storage)
4115         <demangled_names_hash>: Now an htab_up.
4116         * objfiles.c (objfile_per_bfd_storage): Simplify.
4117
4118 2019-03-15  Tom Tromey  <tom@tromey.com>
4119
4120         * objfiles.h (struct objfile_per_bfd_storage): Declare
4121         destructor.
4122         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4123         New.
4124         (get_objfile_bfd_data): Use new.  Don't initialize
4125         language_of_main.
4126         (free_objfile_per_bfd_storage): Remove.
4127         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4128
4129 2019-03-15  Tom Tromey  <tom@tromey.com>
4130
4131         * symfile.c (reread_symbols): Update.
4132         * objfiles.c (objfile::objfile): Update.
4133         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4134         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4135         comment.
4136         (minimal_symbol_reader::install): Update.
4137         (terminate_minimal_symbol_table): Remove.
4138         * jit.c (jit_object_close_impl): Update.
4139
4140 2019-03-15  Tom Tromey  <tom@tromey.com>
4141
4142         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4143         initializations.
4144
4145 2019-03-15  Tom Tromey  <tom@tromey.com>
4146
4147         * objfiles.h (struct objfile_per_bfd_storage)
4148         <demangled_hash_languages>: Now a bitset.
4149         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4150         (lookup_minimal_symbol): Update.
4151
4152 2019-03-15  Tom Tromey  <tom@tromey.com>
4153
4154         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4155         Don't return the symbol.
4156         * coffread.c (record_minimal_symbol): Use record_full.
4157
4158 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4159
4160         The MS-Windows port of ncurses fails to switch to a color pair if
4161         one or both of the colors are the implicit default colors.  This
4162         change records the default colors when TUI is initialized, and
4163         then specifies them explicitly when a color pair uses the default
4164         colors.  This allows color styling in TUI mode on MS-Windows.
4165
4166         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4167         ncurses_norm_attr.
4168         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4169         colors in ncurses_norm_attr.
4170         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4171         "none", replace it with the default color recorded in
4172         ncurses_norm_attr.
4173
4174 2019-03-14  Tom Tromey  <tromey@adacore.com>
4175
4176         * source-cache.h (class source_cache) <get_source_lines>: Return
4177         std::string.
4178         * source-cache.c (source_cache::extract_lines): Handle case where
4179         first_pos==npos.  Return std::string.
4180         (source_cache::get_source_lines): Update.
4181
4182 2019-03-14  Tom Tromey  <tromey@adacore.com>
4183
4184         * NEWS: Add item for "style sources" commands.
4185         * source-cache.c (source_cache::get_source_lines): Check
4186         source_styling.
4187         * cli/cli-style.c (source_styling): New global.
4188         (_initialize_cli_style): Add "style sources" commands.
4189         (show_style_sources): New function.
4190         * cli/cli-style.h (source_styling): Declare.
4191
4192 2019-03-14  Pedro Alves  <palves@redhat.com>
4193             Tom Tromey  <tromey@adacore.com>
4194
4195         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4196         * tui/tui-winsource.c (tui_refill_source_window): New function,
4197         from...
4198         (tui_horizontal_source_scroll): ... here.  Move some logic.
4199         * cli/cli-style.c (set_style_enabled): Notify new observable.
4200         * tui/tui-hooks.c (tui_redisplay_source): New function.
4201         (tui_attach_detach_observers): Attach or detach
4202         tui_redisplay_source.
4203         * observable.h (source_styling_changed): New observable.
4204         * observable.c: Define source_styling_changed observable.
4205
4206 2019-03-13  Tom Tromey  <tromey@adacore.com>
4207
4208         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4209         (i386_gnu_nat_target::store_registers): Update.
4210         * target-debug.h (target_debug_print_std_string): New macro.
4211         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4212         * windows-tdep.c (display_one_tib): Update.
4213         * tui/tui-stack.c (tui_make_status_line): Update.
4214         * top.c (print_inferior_quit_action): Update.
4215         * thread.c (thr_try_catch_cmd): Update.
4216         (add_thread_with_info): Update.
4217         (thread_target_id_str): Update.
4218         (thr_try_catch_cmd): Update.
4219         (thread_command): Update.
4220         (thread_find_command): Update.
4221         * record-btrace.c (record_btrace_target::info_record)
4222         (record_btrace_resume_thread, record_btrace_target::resume)
4223         (record_btrace_cancel_resume, record_btrace_step_thread)
4224         (record_btrace_target::wait, record_btrace_target::wait)
4225         (record_btrace_target::wait, record_btrace_target::stop): Update.
4226         * progspace.c (print_program_space): Update.
4227         * process-stratum-target.c
4228         (process_stratum_target::thread_address_space): Update.
4229         * linux-fork.c (linux_fork_mourn_inferior)
4230         (detach_checkpoint_command, info_checkpoints_command)
4231         (linux_fork_context): Update.
4232         (linux_fork_detach): Update.
4233         (class scoped_switch_fork_info): Update.
4234         (delete_checkpoint_command): Update.
4235         * infrun.c (follow_fork_inferior): Update.
4236         (follow_fork_inferior): Update.
4237         (proceed_after_vfork_done): Update.
4238         (handle_vfork_child_exec_or_exit): Update.
4239         (follow_exec): Update.
4240         (displaced_step_prepare_throw): Update.
4241         (displaced_step_restore): Update.
4242         (start_step_over): Update.
4243         (resume_1): Update.
4244         (clear_proceed_status_thread): Update.
4245         (proceed): Update.
4246         (print_target_wait_results): Update.
4247         (do_target_wait): Update.
4248         (context_switch): Update.
4249         (stop_all_threads): Update.
4250         (restart_threads): Update.
4251         (finish_step_over): Update.
4252         (handle_signal_stop): Update.
4253         (switch_back_to_stepped_thread): Update.
4254         (keep_going_pass_signal): Update.
4255         (print_exited_reason): Update.
4256         (normal_stop): Update.
4257         * inferior.c (inferior_pid_to_str): Change return type.
4258         (print_selected_inferior): Update.
4259         (add_inferior): Update.
4260         (detach_inferior): Update.
4261         * dummy-frame.c (fprint_dummy_frames): Update.
4262         * dcache.c (dcache_info_1): Update.
4263         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4264         (btrace_fetch, btrace_clear): Update.
4265         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4266         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4267         type.
4268         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4269         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4270         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4271         * gdbarch.c, gdbarch.h: Rebuild.
4272         * gdbarch.sh (core_pid_to_str): Change return type.
4273         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4274         return type.
4275         (windows_nat_target::pid_to_str): Change return type.
4276         (windows_delete_thread): Update.
4277         (windows_nat_target::attach): Update.
4278         (windows_nat_target::files_info): Update.
4279         * target-delegates.c: Rebuild.
4280         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4281         return type.
4282         (sol_thread_target::pid_to_str): Change return type.
4283         * remote.c (class remote_target) <pid_to_str>: Change return
4284         type.
4285         (remote_target::pid_to_str): Change return type.
4286         (extended_remote_target::attach, remote_target::remote_stop_ns)
4287         (remote_target::remote_notif_remove_queued_reply)
4288         (remote_target::push_stop_reply, remote_target::disable_btrace):
4289         Update.
4290         (extended_remote_target::attach): Update.
4291         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4292         type.
4293         (gdbsim_target::pid_to_str): Change return type.
4294         * ravenscar-thread.c (struct ravenscar_thread_target)
4295         <pid_to_str>: Change return type.
4296         (ravenscar_thread_target::pid_to_str): Change return type.
4297         * procfs.c (class procfs_target) <pid_to_str>: Change return
4298         type.
4299         (procfs_target::pid_to_str): Change return type.
4300         (procfs_target::attach): Update.
4301         (procfs_target::detach): Update.
4302         (procfs_target::fetch_registers): Update.
4303         (procfs_target::store_registers): Update.
4304         (procfs_target::wait): Update.
4305         (procfs_target::files_info): Update.
4306         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4307         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4308         return type.
4309         (nto_procfs_target::pid_to_str): Change return type.
4310         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4311         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4312         return type.
4313         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4314         (exit_lwp): Update.
4315         (attach_proc_task_lwp_callback, get_detach_signal)
4316         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4317         (linux_nat_target::resume, wait_lwp, stop_callback)
4318         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4319         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4320         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4321         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4322         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4323         type.
4324         (inf_ptrace_target::attach): Update.
4325         (inf_ptrace_target::files_info): Update.
4326         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4327         type.
4328         (go32_nat_target::pid_to_str): Change return type.
4329         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4330         (gnu_nat_target::wait): Update.
4331         (gnu_nat_target::wait): Update.
4332         (gnu_nat_target::resume): Update.
4333         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4334         (fbsd_nat_target::wait): Update.
4335         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4336         type.
4337         (darwin_nat_target::attach): Update.
4338         * corelow.c (class core_target) <pid_to_str>: Change return type.
4339         (core_target::pid_to_str): Change return type.
4340         * target.c (normal_pid_to_str): Change return type.
4341         (default_pid_to_str): Likewise.
4342         (target_pid_to_str): Change return type.
4343         (target_translate_tls_address): Update.
4344         (target_announce_detach): Update.
4345         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4346         return type.
4347         (bsd_uthread_target::pid_to_str): Change return type.
4348         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4349         type.
4350         (bsd_kvm_target::pid_to_str): Change return type.
4351         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4352         return type.
4353         (aix_thread_target::pid_to_str): Change return type.
4354         * target.h (struct target_ops) <pid_to_str>: Change return type.
4355         (target_pid_to_str, normal_pid_to_str): Likewise.
4356         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4357         type.
4358         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4359         type.
4360         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4361         return type.
4362         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4363         type.
4364         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4365         type.
4366         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4367         return type.
4368
4369 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4370
4371         * NEWS: Mention that the new default MI version is 3.  Mention
4372         changes to the output of commands and events that deal with
4373         multi-location breakpoints.
4374         * breakpoint.c: Include "mi/mi-out.h".
4375         (print_one_breakpoint): Change output syntax if using MI version
4376         >= 3.
4377         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4378         New.
4379         (mi_multi_location_breakpoint_output_fixed): New.
4380         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4381         (mi_cmd_fix_multi_location_breakpoint_output): New.
4382         (mi_multi_location_breakpoint_output_fixed): New.
4383         * mi/mi-cmds.c (mi_cmds): Register command
4384         -fix-multi-location-breakpoint-output.
4385         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4386         interpreter "mi".
4387
4388 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4389
4390         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4391         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4392         instantiate mi_ui_out based on interpreter name.
4393         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4394         * mi/mi-main.c (mi_load_progress): Likewise.
4395
4396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4397
4398         * NEWS: Combine separate "New targets" sections for 8.3.
4399
4400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4401
4402         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4403         (ppcfbsd_init_abi): Install gdbarch
4404         "fetch_tls_load_module_address" and "get_thread_local_address"
4405         methods.
4406
4407 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4408
4409         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4410         (riscv_fbsd_init_abi): Install gdbarch
4411         "fetch_tls_load_module_address" and "get_thread_local_address"
4412         methods.
4413
4414 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4415
4416         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4417         (i386fbsd_init_abi): Install gdbarch
4418         "fetch_tls_load_module_address" and "get_thread_local_address"
4419         methods.
4420
4421 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4422
4423         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4424         (amd64fbsd_init_abi): Install gdbarch
4425         "fetch_tls_load_module_address" and "get_thread_local_address"
4426         methods.
4427
4428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4429
4430         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4431         (struct fbsd_pspace_data): New type.
4432         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4433         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4434         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4435         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4436         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4437
4438 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4439
4440         * gdbtypes.c (lookup_struct_elt): New function.
4441         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4442         * gdbtypes.h (struct struct_elt): New type.
4443         (lookup_struct_elt): New prototype.
4444
4445 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4446
4447         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4448         remove disabled code block.
4449
4450 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4451
4452         * gdbarch.sh (get_thread_local_address): New method.
4453         * gdbarch.h, gdbarch.c: Regenerate.
4454         * target.c (target_translate_tls_address): Use
4455         gdbarch_get_thread_local_address if present instead of
4456         target::get_thread_local_address.
4457
4458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4459
4460         * target.h (target::get_thread_local_address): Update comment.
4461
4462 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4463
4464         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4465         objfile->separate_debug_objfile_backlink if not NULL.
4466
4467 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4468
4469         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4470         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4471         (amd64bsd_store_inferior_registers): Likewise.
4472         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4473         Enable segment base registers.
4474         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4475         PT_GETFSBASE and PT_GETGSBASE.
4476         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4477         PT_SETGSBASE.
4478         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4479         segment base registers.
4480         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4481
4482 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4483
4484         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4485         Update calls to i386_target_description to add 'segments'
4486         parameter.
4487         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4488         add segment base registers.
4489         * arch/i386.c (i386_create_target_description): Add 'segments'
4490         parameter to enable segment base registers.
4491         * arch/i386.h (i386_create_target_description): Likewise.
4492         * features/i386/32bit-segments.xml: New file.
4493         * features/i386/32bit-segments.c: Generate.
4494         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4495         call to i386_target_description to add 'segments' parameter.
4496         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4497         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4498         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4499         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4500         if feature is present.
4501         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4502         Add 'segments' parameter to call to i386_target_description.
4503         (i386_target_description): Add 'segments' parameter to enable
4504         segment base registers.
4505         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4506         to call to i386_target_description.
4507         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4508         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4509         Define I386_NUM_REGS.
4510         (i386_target_description): Add 'segments' parameter to enable
4511         segment base registers.
4512
4513 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4514
4515         PR/24325
4516         * source-cache.c: #undef open and close, to avoid unresolved
4517         externals during linking.
4518
4519 2019-03-12  Tom Tromey  <tromey@adacore.com>
4520
4521         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4522         const.  Add initializers.
4523         (_initialize_remote): Don't initialize ptid globals.
4524
4525 2019-03-12  Pedro Alves  <palves@redhat.com>
4526
4527         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4528
4529 2019-03-12  Pedro Alves  <palves@redhat.com>
4530
4531         * cp-name-parser.y (main): Remove unused 'len' variable.
4532
4533 2019-03-12  Tom Tromey  <tromey@adacore.com>
4534
4535         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4536         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4537
4538 2019-03-12  Tom Tromey  <tromey@adacore.com>
4539
4540         * linux-nat.c (iterate_over_lwps): Update.
4541         (stop_callback): Remove parameter.
4542         (stop_wait_callback, detach_callback, resume_set_callback)
4543         (select_singlestep_lwp_callback, set_ignore_sigint)
4544         (status_callback, resumed_callback, resume_clear_callback)
4545         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4546         data parameter.
4547         (linux_nat_target::detach, linux_nat_target::resume)
4548         (linux_stop_and_wait_all_lwps, select_event_lwp)
4549         (linux_nat_filter_event, linux_nat_wait_1)
4550         (linux_nat_target::kill, linux_nat_target::stop)
4551         (linux_nat_target::stop): Update.
4552         (linux_nat_resume_callback): Change type.
4553         (resume_stopped_resumed_lwps, count_events_callback)
4554         (select_event_lwp_callback): Likewise.
4555         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4556         * arm-linux-nat.c (struct update_registers_data): Remove.
4557         (update_registers_callback): Change type.
4558         (arm_linux_insert_hw_breakpoint1): Update.
4559         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4560         parameter.
4561         (x86_linux_dr_set_addr): Update.
4562         (x86_linux_dr_set_control): Update.
4563         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4564         (iterate_over_lwps): Use gdb::function_view.
4565         * nat/aarch64-linux-hw-point.c (struct
4566         aarch64_dr_update_callback_param): Remove.
4567         (debug_reg_change_callback): Change type.
4568         (aarch64_notify_debug_reg_change): Update.
4569         * s390-linux-nat.c (s390_refresh_per_info): Update.
4570
4571 2019-03-11  Tom Tromey  <tromey@adacore.com>
4572
4573         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4574         redundant assignment to "this_cu".
4575
4576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4577
4578         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4579
4580 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4581
4582         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4583         from...
4584         (rank_one_type): ... this.
4585
4586 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4587
4588         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4589         from...
4590         (rank_one_type): ... this.
4591
4592 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4593
4594         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4595         from...
4596         (rank_one_type): ... this.
4597
4598 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4599
4600         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4601         from...
4602         (rank_one_type): ... this.
4603
4604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4605
4606         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4607         from...
4608         (rank_one_type): ... this.
4609
4610 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4611
4612         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4613         from...
4614         (rank_one_type): ... this.
4615
4616 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4617
4618         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4619         from...
4620         (rank_one_type): ... this.
4621
4622 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4623
4624         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4625         from...
4626         (rank_one_type): ... this.
4627
4628 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4629
4630         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4631         from...
4632         (rank_one_type): ... this.
4633
4634 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4635
4636         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4637         from...
4638         (rank_one_type): ... this.
4639
4640 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4641
4642         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4643         from...
4644         (rank_one_type): ... this.
4645
4646 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4647
4648         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4649         from...
4650         (rank_one_type): ... this.
4651
4652 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4653
4654         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4655         inferior-events' shows the example events.
4656
4657 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4658
4659         Support styling on native MS-Windows console
4660
4661         PR/24315
4662         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4663         on MS-Windows if $TERM is not defined.
4664
4665         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4666
4667         * posix-hdep.c (gdb_console_fputs):
4668         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4669         functions.
4670         * ui-file.h (gdb_console_fputs): Add prototype.
4671
4672         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4673         back to fputs only if the former returns zero.
4674
4675 2019-03-07  Tom Tromey  <tom@tromey.com>
4676
4677         * symmisc.c (print_symbol_bcache_statistics): Update.
4678         (print_objfile_statistics): Update.
4679         * symfile.c (allocate_symtab): Update.
4680         * stabsread.c: Don't include bcache.h.
4681         * psymtab.h (struct psymbol_bcache): Don't declare.
4682         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4683         (psymbol_bcache_init, psymbol_bcache_free)
4684         (psymbol_bcache_get_bcache): Don't declare.
4685         * psymtab.c (struct psymbol_bcache): Remove.
4686         (psymtab_storage::psymtab_storage): Update.
4687         (psymtab_storage::~psymtab_storage): Update.
4688         (psymbol_bcache_init, psymbol_bcache_free)
4689         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4690         (add_psymbol_to_bcache): Update.
4691         (allocate_psymtab): Update.
4692         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4693         macro_cache>: No longer pointers.
4694         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4695         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4696         * macrotab.c (macro_bcache): Update.
4697         * macroexp.c: Don't include bcache.h.
4698         * gdbtypes.c (check_types_worklist): Update.
4699         (types_deeply_equal): Remove TRY/CATCH.  Update.
4700         * elfread.c (elf_symtab_read): Update.
4701         * dwarf2read.c: Don't include bcache.h.
4702         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4703         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4704         (print_bcache_statistics, bcache_memory_used): Don't declare.
4705         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4706         methods.  Rename all data members.
4707         * bcache.c (struct bcache): Move to bcache.h.
4708         (bcache::expand_hash_table): Rename from expand_hash_table.
4709         (bcache): Remove.
4710         (bcache::insert): Rename from bcache_full.
4711         (bcache::compare): Rename from bcache_compare.
4712         (bcache_xmalloc): Remove.
4713         (bcache::~bcache): Rename from bcache_xfree.
4714         (bcache::print_statistics): Rename from print_bcache_statistics.
4715         (bcache::memory_used): Rename from bcache_memory_used.
4716
4717 2019-03-07  Pedro Alves  <palves@redhat.com>
4718
4719         * infrun.c (normal_stop): Also check for
4720         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4721
4722 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4723
4724         * f-lang.c (value_from_host_double): Moved to...
4725         * value.c (value_from_host_double): ...here.
4726         * value.h (value_from_host_double): Declare.
4727         * guile/scm-math.c (vlscm_convert_typed_number): Use
4728         value_from_host_double.
4729         (vlscm_convert_number): Likewise.
4730         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4731         * python/py-value.c (convert_value_from_python): Likewise.
4732
4733 2019-03-06  Tom Tromey  <tom@tromey.com>
4734
4735         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4736
4737 2019-03-06  Tom Tromey  <tom@tromey.com>
4738
4739         * utils.h (free_current_contents): Don't declare.
4740         * utils.c (free_current_contents): Remove.
4741
4742 2019-03-06  Tom Tromey  <tom@tromey.com>
4743
4744         * top.c (quit_force): Update.
4745         * main.c (captured_command_loop): Update.
4746         * common/new-op.c (operator new): Update.
4747         * common/common-exceptions.c (struct catcher)
4748         <save_cleanup_chain>: Remove member.
4749         (exceptions_state_mc_init): Update.
4750         (exception_try_scope_entry): Return nullptr.
4751         (exception_try_scope_exit, exception_rethrow)
4752         (throw_exception_sjlj, throw_exception_cxx): Update.
4753         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4754         (all_cleanups, do_cleanups, discard_cleanups)
4755         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4756         (restore_cleanups, restore_final_cleanups): Don't declare.
4757         (do_final_cleanups): Remove parameter.
4758         * common/cleanups.c (cleanup_chain, make_cleanup)
4759         (make_cleanup_dtor, all_cleanups, do_cleanups)
4760         (discard_my_cleanups, discard_cleanups)
4761         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4762         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4763         (null_cleanup): Remove.
4764         (do_final_cleanups): Remove parameter.
4765
4766 2019-03-06  Tom Tromey  <tom@tromey.com>
4767
4768         * remote.c (remote_target::remote_parse_stop_reply): Use
4769         unique_xmalloc_ptr.
4770
4771 2019-03-06  Tom Tromey  <tom@tromey.com>
4772
4773         * stabsread.c (struct stabs_field_info): Rename from field_info.
4774         <list, fnlist>: Add initializers.
4775         <obstack>: New member.
4776         (read_member_functions, read_struct_fields, read_baseclasses):
4777         Allocate on obstack.  Don't use cleanups.
4778         (read_one_struct_field, read_member_functions, read_struct_fields)
4779         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4780         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4781         (read_struct_type): Update.
4782
4783 2019-03-06  Tom Tromey  <tom@tromey.com>
4784
4785         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4786         * common/filestuff.h (make_cleanup_close): Don't declare.
4787         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4788         Remove.
4789
4790 2019-03-06  Tom Tromey  <tom@tromey.com>
4791
4792         * solib-aix.c: Use make_scope_exit.
4793
4794 2019-03-06  Tom Tromey  <tom@tromey.com>
4795
4796         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4797         Use make_scope_exit.
4798
4799 2019-03-06  Tom Tromey  <tom@tromey.com>
4800
4801         * solib-svr4.c (disable_probes_interface): Remove parameter.
4802         (svr4_handle_solib_event): Use make_scope_exit.
4803
4804 2019-03-06  Tom Tromey  <tom@tromey.com>
4805
4806         * remote.c (struct stop_reply_deleter): Remove.
4807         (stop_reply_up): Update.
4808         (struct stop_reply): Derive from notif_event.  Don't typedef.
4809         <regcache>: Now a std::vector.
4810         (stop_reply_xfree): Remove.
4811         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4812         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4813         (remote_target::discard_pending_stop_replies): Use delete.
4814         (remote_target::remote_parse_stop_reply): Update.
4815         (remote_target::process_stop_reply): Update.
4816         * remote-notif.h (struct notif_event): Add virtual destructor.
4817         Remove "dtr" member.
4818         (struct notif_client) <alloc_event>: Return a unique_ptr.
4819         (notif_event_xfree): Don't declare.
4820         (notif_event_up): New typedef.
4821         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4822         (notif_event_xfree, do_notif_event_xfree): Remove.
4823         (remote_notif_state_xfree): Update.
4824
4825 2019-03-06  Tom Tromey  <tom@tromey.com>
4826
4827         * infrun.c (displaced_step_clear_cleanup): Now a
4828         forward_scope_exit type.
4829         (displaced_step_prepare_throw): Update.
4830         (displaced_step_fixup): Update.
4831
4832 2019-03-06  Tom Tromey  <tom@tromey.com>
4833
4834         * inferior.h (class inferior): Update comment.
4835         * gdbthread.h (class thread_info): Update comment.
4836
4837 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4838             Tom Tromey  <tom@tromey.com>
4839
4840         * stabsread.h (struct stab_section_list): Remove.
4841         (coffstab_build_psymtabs): Update.
4842         * dbxread.c (symbuf_sections): Now a std::vector.
4843         (sect_idx): New global.
4844         (fill_symbuf): Update.
4845         (coffstab_build_psymtabs): Change type of stabsects parameter.
4846         Update.
4847         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4848         std::vector.
4849         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4850         (coff_locate_sections): Update.
4851         (coff_symfile_read): Remove cleanups.  Update.
4852         (init_stringtab): Add storage parameter.
4853         (free_stringtab, free_stringtab_cleanup): Remove.
4854         (init_lineno): Add storage parameter.
4855         (free_linetab, free_linetab_cleanup): Remove.
4856
4857 2019-03-06  Pedro Alves  <palves@redhat.com>
4858
4859         * linux-fork.c (fork_info::clobber_regs): Delete.
4860         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4861         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4862         comment.  Adjust.
4863         (scoped_switch_fork_info::scoped_switch_fork_info)
4864         (checkpoint_command, linux_fork_context): Adjust
4865         fork_save_infrun_state calls.
4866
4867 2019-03-06  Pedro Alves  <palves@redhat.com>
4868
4869         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4870         (inf_has_multiple_threads): Return 'bool' and rewrite using
4871         inferior_info::threads().
4872
4873 2019-03-06  Pedro Alves  <palves@redhat.com>
4874
4875         * linux-fork.c: Include <list>.
4876         (fork_list): Now a std::list instance.
4877         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4878         (forks_exist_p, find_last_fork): Adjust.
4879         (new_fork): Delete.
4880         (one_fork_p): New.
4881         (add_fork): Adjust.
4882         (free_fork): Delete, folded into fork_info::~fork_info().
4883         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4884         Adjust.
4885         (init_fork_list): Delete.
4886         (linux_fork_killall, linux_fork_mourn_inferior)
4887         (linux_fork_detach, info_checkpoints_command): Adjust.
4888         (_initialize_linux_fork): No longer call init_fork_list.
4889
4890 2019-03-06  Pedro Alves  <palves@redhat.com>
4891
4892         * linux-fork.c (new_fork): New, split out of ...
4893         (add_fork): ... this.  Return void.  Move "first fork" special
4894         case from here, to ...
4895         (checkpoint_command): ... here.
4896         * linux-linux.h (add_fork): Return void.
4897
4898 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4899
4900         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4901
4902 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4903             Chris January  <chris.january@arm.com>
4904             David Lecomber  <david.lecomber@arm.com>
4905
4906         * f-exp.y: New token, UNOP_INTRINSIC.
4907         (exp): New pattern using UNOP_INTRINSIC token.
4908         (f77_keywords): Add 'abs' keyword.
4909         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4910         (value_from_host_double): New function.
4911         (evaluate_subexp_f): Support UNOP_ABS.
4912
4913 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4916         types.
4917
4918 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4919
4920         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4921         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4922         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4923
4924 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4927
4928 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4929             Chris January  <chris.january@arm.com>
4930
4931         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4932         * f-exp.y: Define 'KIND' token.
4933         (exp): New pattern for KIND expressions.
4934         (ptype): Handle types with a kind extension.
4935         (direct_abs_decl): Extend to spot kind extensions.
4936         (f77_keywords): Add 'kind' to the list.
4937         (push_kind_type): New function.
4938         (convert_to_kind_type): New function.
4939         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4940         * parse.c (operator_length_standard): Likewise.
4941         * parser-defs.h (enum type_pieces): Add tp_kind.
4942         * std-operator.def: Add UNOP_KIND.
4943
4944 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4945
4946         * f-exp.y (f_parse): Set yydebug.
4947
4948 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4949
4950         * f-lang.c (evaluate_subexp_f): New function.
4951         (exp_descriptor_f): New global.
4952         (f_language_defn): Use exp_descriptor_f instead of
4953         exp_descriptor_standard.
4954
4955 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * f-exp.y (struct token): Add comments.
4958         (dot_ops): Remove uppercase versions and the end marker.
4959         (f77_keywords): Likewise.
4960         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4961         entries in the dot_ops array are case insensitive, and use
4962         strncasecmp to compare strings.  Also some whitespace cleanup in
4963         this area.  Similar for the f77_keywords array, except entries in
4964         this list might be case sensitive.
4965
4966 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4967
4968         * f-exp.y (struct f77_boolean_val): Add comments.
4969         (boolean_values): Remove uppercase versions, and end marker.
4970         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4971         and use strncasecmp to achieve case insensitivity.  Additionally,
4972         perform whitespace cleanup around this code.
4973
4974 2019-03-06  Tom Tromey  <tromey@adacore.com>
4975
4976         * remote-sim.c (gdbsim_target_open): Use result of
4977         gdb_argv::release.
4978
4979 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4980         Dirk Schubert  <dirk.schubert@arm.com>
4981         Chris January  <chris.january@arm.com>
4982
4983         * eval.c (evaluate_subexp_standard): Call Fortran argument
4984         wrapping logic.
4985         * f-lang.c (struct value): A value which can be passed into a
4986         Fortran function call.
4987         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4988         where appropriate.
4989         (struct type): Value ready for a Fortran function call.
4990         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4991         is needed.
4992         * f-lang.h (fortran_argument_convert): Declaration.
4993         (fortran_preserve_arg_pointer): Declaration.
4994         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4995
4996 2019-03-05  Tom Tromey  <tromey@adacore.com>
4997
4998         * python/py-prettyprint.c (print_string_repr): Remove #if.
4999         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5000
5001 2019-03-05  Tom Tromey  <tromey@adacore.com>
5002
5003         * target.c (the_dummy_target): Move later.  Change type to
5004         "dummy_target".
5005         (initialize_targets): Don't initialize the_dummy_target.
5006
5007 2019-03-05  Tom Tromey  <tromey@adacore.com>
5008
5009         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5010         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5011
5012 2019-03-05  Tom Tromey  <tromey@adacore.com>
5013
5014         * windows-nat.c (windows_nat_target::attach)
5015         (windows_nat_target::detach): Don't call gdb_flush.
5016         * valprint.c (generic_val_print, val_print, val_print_string):
5017         Don't call gdb_flush.
5018         * utils.c (defaulted_query): Don't call gdb_flush.
5019         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5020         * target.c (target_announce_detach): Don't call gdb_flush.
5021         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5022         * remote.c (extended_remote_target::attach): Don't call
5023         gdb_flush.
5024         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5025         * printcmd.c (do_examine): Don't call gdb_flush.
5026         (info_display_command): Don't call gdb_flush.
5027         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5028         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5029         * memattr.c (info_mem_command): Don't call gdb_flush.
5030         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5031         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5032         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5033         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5034         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5035         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5036         (gnu_nat_target::detach): Don't call gdb_flush.
5037         * f-valprint.c (f_val_print): Don't call gdb_flush.
5038         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5039         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5040         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5041         gdb_flush.
5042         * c-valprint.c (c_val_print): Don't call gdb_flush.
5043         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5044
5045 2019-03-05  Tom Tromey  <tromey@adacore.com>
5046
5047         * varobj.c (update_dynamic_varobj_children): Update.
5048         (install_default_visualizer): Use reset, not release.
5049         * value.c (set_internalvar): Update.
5050         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5051         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5052         ATTRIBUTE_UNUSED_RESULT.
5053
5054 2019-03-05  Tom Tromey  <tromey@adacore.com>
5055
5056         * remote.c (class scoped_remote_fd) <release>: Add
5057         ATTRIBUTE_UNUSED_RESULT.
5058
5059 2019-03-05  Tom Tromey  <tromey@adacore.com>
5060
5061         * macroexp.c (struct macro_buffer) <release>: Add
5062         ATTRIBUTE_UNUSED_RESULT.
5063
5064 2019-03-05  Tom Tromey  <tromey@adacore.com>
5065
5066         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5067         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5068         ATTRIBUTE_UNUSED_RESULT.
5069
5070 2019-03-05  Tom Tromey  <tromey@adacore.com>
5071
5072         * common/scoped_fd.h (class scoped_fd) <release>: Add
5073         ATTRIBUTE_UNUSED_RESULT.
5074
5075 2019-03-05  Tom Tromey  <tromey@adacore.com>
5076
5077         * parser-defs.h (struct parser_state) <release>: Add
5078         ATTRIBUTE_UNUSED_RESULT.
5079
5080 2019-03-05  Tom Tromey  <tromey@adacore.com>
5081
5082         * utils.h (class gdb_argv) <release>: Add
5083         ATTRIBUTE_UNUSED_RESULT.
5084         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5085
5086 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5087
5088         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5089         for-loop range, to avoid compiler warnings.
5090
5091         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5092         avoid compiler warnings about unused variables.
5093
5094         * NEWS: Mention end of support for native debugging on MS-Windows
5095         before XP.
5096
5097         PR gdb/24292
5098         * common/netstuff.c:
5099         * gdbserver/gdbreplay.c
5100         * gdbserver/remote-utils.c:
5101         * ser-tcp.c:
5102         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5103         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5104         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5105         'getaddrinfo' and 'freeaddrinfo' were not available before
5106         Windows XP, and mingw.org's MinGW headers by default define
5107         _WIN32_WINNT to 0x500.
5108
5109 2019-03-01  Gary Benson <gbenson@redhat.com>
5110
5111         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5112
5113 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5114             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5115
5116         PR gdb/8527
5117         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5118         set_sigint_trap, clear_sigint_trap.
5119
5120 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5121
5122         * target.c (target_detach): Clear the regcache and the
5123         frame cache.
5124
5125 2019-02-27  Pedro Alves  <palves@redhat.com>
5126
5127         * utils.c (set_screen_size): When we cap the height/width sizes,
5128         tweak the corresponding command variable to show "unlimited":
5129
5130 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5131             Pedro Alves  <palves@redhat.com>
5132
5133         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5134         before calling rl_set_screen_size.
5135
5136 2019-02-27  Tom Tromey  <tromey@adacore.com>
5137
5138         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5139         define.
5140         * python/py-value.c: Remove Python 2.4 workaround.
5141         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5142         workaround.
5143         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5144         Python 2.4 workaround.
5145         * python/python-internal.h: Remove Python 2.4 comment.
5146         (Py_ssize_t): Don't define.
5147         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5148         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5149         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5150         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5151         * python/python.c (do_start_initialization): Remove Python 2.4
5152         workaround.
5153         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5154         (print_children): Remove Python 2.4 workaround.
5155         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5156         workaround.
5157         (CHARBUFFERPROC_NAME): Remove.
5158         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5159         Python 2.4 workaround.
5160
5161 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5162
5163         * NEWS: Note minimum Python version.
5164
5165 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5166
5167         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5168         code from these functions.  Remove corresponding ifdefs.  Use
5169         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5170         Remove gotos and target of gotos.
5171         (infpy_search_memory): Likewise.
5172
5173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5174
5175         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5176         (hppa_gdbarch_init): Don't register deleted functions with
5177         gdbarch.
5178
5179 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5180
5181         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5182         (h8300_unwind_sp): Delete.
5183         (h8300_dummy_id): Delete.
5184         (h8300_gdbarch_init): Don't register deleted functions with
5185         gdbarch.
5186
5187 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5188
5189         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5190         (ft32_unwind_pc): Delete.
5191         (ft32_unwind_sp): Delete.
5192         (ft32_gdbarch_init): Don't register deleted functions with
5193         gdbarch.
5194
5195 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5196
5197         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5198         (frv_unwind_pc): Delete.
5199         (frv_unwind_sp): Delete.
5200         (frv_gdbarch_init): Don't register deleted functions with
5201         gdbarch.
5202
5203 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5204
5205         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5206         (riscv_unwind_pc): Delete.
5207         (riscv_unwind_sp): Delete.
5208         (riscv_gdbarch_init): Don't register deleted functions with
5209         gdbarch.
5210
5211 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5212
5213         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5214         (csky_unwind_pc): Delete.
5215         (csky_unwind_sp): Delete.
5216         (csky_gdbarch_init): Don't register deleted functions with
5217         gdbarch.
5218
5219 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5220
5221         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5222         (cris_unwind_pc): Delete.
5223         (cris_unwind_sp): Delete.
5224         (cris_gdbarch_init): Don't register deleted functions with
5225         gdbarch.
5226
5227 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5228
5229         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5230         (bfin_unwind_pc): Delete.
5231         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5232
5233 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5234
5235         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5236         (arm_unwind_pc): Delete.
5237         (arm_unwind_sp): Delete.
5238         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5239
5240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5241
5242         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5243         (arc_unwind_pc): Delete.
5244         (arc_unwind_sp): Delete.
5245         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5246
5247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5248
5249         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5250         (alpha_unwind_pc): Delete.
5251         (alpha_gdbarch_init): Don't register deleted functions with
5252         gdbarch.
5253
5254 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5255
5256         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5257         (aarch64_unwind_pc): Delete.
5258         (aarch64_unwind_sp): Delete.
5259         (aarch64_gdbarch_init): Don't register deleted functions with
5260         gdbarch.
5261
5262 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5263
5264         * gdbtypes.c (type_align): Don't consider static members when
5265         computing structure alignment.
5266
5267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5268
5269         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5270         return 0 for other types.
5271         * arch-utils.c (default_type_align): Always return 0.
5272         * gdbarch.h: Regenerate.
5273         * gdbarch.sh (type_align): Extend comment.
5274         * gdbtypes.c (type_align): Add additional comments, always call
5275         gdbarch_type_align before applying the default rules.
5276         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5277         generic code will then apply a suitable default.
5278         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5279         types, return 0 for other types.
5280
5281 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5282
5283         * NEWS: Create a new section for the next release branch.
5284         Rename the section of the current branch, now that it has
5285         been cut.
5286
5287 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5288
5289         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5290         * version.in: Bump version to 8.3.50.DATE-git.
5291
5292 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5293
5294         * aix-thread.c (ptid_cmp): Remove unused variable.
5295         (get_signaled_thread): Likewise.
5296         (store_regs_user_thread): Likewise.
5297         (store_regs_kernel_thread): Likewise.
5298         (fetch_regs_kernel_thread): Remove shadowed variable.
5299
5300 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5301
5302         * features/riscv/32bit-cpu.xml: Add register numbers.
5303         * features/riscv/32bit-fpu.c: Regenerate.
5304         * features/riscv/32bit-fpu.xml: Add register numbers.
5305         * features/riscv/64bit-cpu.xml: Add register numbers.
5306         * features/riscv/64bit-fpu.c: Regenerate.
5307         * features/riscv/64bit-fpu.xml: Add register numbers.
5308
5309 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5310
5311         * NEWS: Mention two argument form of gdb.Value constructor.
5312         * python/py-value.c (convert_buffer_and_type_to_value): New
5313         function.
5314         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5315         Add support for handling an optional second argument.  Call
5316         convert_buffer_and_type_to_value as appropriate.
5317         * python/python-internal.h (Py_buffer_deleter): New struct.
5318         (Py_buffer_up): New typedef.
5319
5320 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5321
5322         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5323         instead of releasing ownership.
5324
5325 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5326
5327         * dwarf2read.c (open_and_init_dwp_file): Call
5328         elf_numsections instead of bfd_count_sections to initialize
5329         dwp_file->num_sections.
5330
5331 2019-02-25  Tom Tromey  <tromey@adacore.com>
5332
5333         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5334
5335 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5336
5337         * gcore.in: Add '--readnever' option when invoking GDB.
5338
5339 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5340
5341         * MAINTAINERS: Update my email address.
5342
5343 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5344
5345         * build-id.c (build_id_to_debug_bfd_1): New function.
5346         (build_id_to_debug_bfd): Look for separate debug file in
5347         sysroot.
5348
5349 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5350
5351         * gdbarch.sh: Update the copyright year range that is placed into
5352         generated files.
5353
5354 2019-02-22  Keith Seitz  <keiths@redhat.com>
5355
5356         PR symtab/23853
5357         * linespec.c (create_sals_line_offset): Search for the default
5358         symtab's filename instead of its fullname.
5359
5360 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5361
5362         * NEWS: Update style defaults.
5363
5364 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5365
5366         * main.c (captured_main_1): Disable styling in batch mode.
5367
5368 2019-02-20  Tom Tromey  <tom@tromey.com>
5369
5370         * symtab.c (symtab_symbol_info): Fix typos.
5371
5372 2019-02-20  Tom Tromey  <tromey@adacore.com>
5373
5374         * findcmd.c (_initialize_mem_search): Use upper case for
5375         metasyntactic variables.
5376
5377 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5378
5379         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5380         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5381
5382 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5383
5384         * top.h (source_file_name): Change to std::string.
5385         * top.c (source_file_name): Likewise.
5386         (command_line_input): Adjust.
5387         * cli/cli-script.c (script_from_file): Adjust.
5388
5389 2019-02-19  Tom Tromey  <tromey@adacore.com>
5390
5391         * ravenscar-thread.c
5392         (ravenscar_thread_target::update_thread_list): Don't call
5393         ada_build_task_list.
5394         * ada-lang.h (ada_build_task_list): Don't declare.
5395         * ada-tasks.c (struct ada_tasks_inferior_data)
5396         <task_list_valid_p>: Now bool.
5397         (read_known_tasks, ada_task_list_changed)
5398         (ada_tasks_invalidate_inferior_data): Update.
5399         (read_known_tasks_array): Return bool.
5400         (read_known_tasks_list): Likewise.
5401         (read_known_tasks): Return void.
5402         (ada_build_task_list): Now static.
5403
5404 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5405
5406         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5407         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5408
5409 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5410
5411         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5412         variant for ada_tasks_pspace_data_handle and
5413         ada_tasks_inferior_data_handle.
5414         (ada_tasks_pspace_data_cleanup): New function.
5415         (ada_tasks_inferior_data_cleanup): New function.
5416
5417 2019-02-17  Tom Tromey  <tom@tromey.com>
5418
5419         * macrotab.h (macro_source_fullname): Return a std::string.
5420         * macrotab.c (macro_include, check_for_redefinition)
5421         (macro_undef, macro_lookup_definition, foreach_macro)
5422         (foreach_macro_in_scope): Update.
5423         (macro_source_fullname): Return a std::string.
5424         * macrocmd.c (show_pp_source_pos): Update.
5425
5426 2019-02-17  Tom Tromey  <tom@tromey.com>
5427
5428         * macrocmd.c (show_pp_source_pos): Style the file names.
5429
5430 2019-02-17  Tom Tromey  <tom@tromey.com>
5431
5432         PR tui/24197:
5433         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5434
5435 2019-02-17  Tom Tromey  <tom@tromey.com>
5436
5437         * ada-lang.c (user_select_syms): Use filtered printing.
5438         * utils.c (wrap_style): New global.
5439         (desired_style): Remove.
5440         (emit_style_escape): Add stream parameter.
5441         (set_output_style, reset_terminal_style, prompt_for_continue):
5442         Update.
5443         (flush_wrap_buffer): Only flush gdb_stdout.
5444         (wrap_here): Set wrap_style.
5445         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5446         treat escape sequences as a character.  Change when wrap buffer is
5447         flushed.
5448         (fputs_styled): Do not set the output style when the default is
5449         requested.
5450         * ui-style.h (struct ui_file_style) <is_default>: New method.
5451         * source.c (print_source_lines_base): Emit escape sequences in one
5452         piece.
5453
5454 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5455
5456         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5457         integers and enumeration types.
5458
5459 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5460
5461         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5462         instead of lookup_symbol_in_language
5463         (do_exact_match): New function.
5464         (ada_get_symbol_name_matcher): Return do_exact_match when
5465         doing a verbatim match.
5466
5467 2019-02-15  Tom Tromey  <tromey@adacore.com>
5468
5469         * ravenscar-thread.c (ravenscar_thread_target::resume)
5470         (ravenscar_thread_target::wait): Special case wildcard requests.
5471
5472 2019-02-15  Tom Tromey  <tromey@adacore.com>
5473
5474         * ravenscar-thread.c (base_ptid): Remove.
5475         (struct ravenscar_thread_target) <close>: New method.
5476         <m_base_ptid>: New member.
5477         <update_inferior_ptid, active_task, task_is_currently_active,
5478         runtime_initialized>: Declare methods.
5479         <ravenscar_thread_target>: Add constructor.
5480         (ravenscar_thread_target::task_is_currently_active)
5481         (ravenscar_thread_target::update_inferior_ptid)
5482         (ravenscar_runtime_initialized): Rename.  Now methods.
5483         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5484         (ravenscar_thread_target::update_thread_list): Update.
5485         (ravenscar_thread_target::active_task): Now method.
5486         (ravenscar_thread_target::store_registers)
5487         (ravenscar_thread_target::prepare_to_store)
5488         (ravenscar_thread_target::prepare_to_store)
5489         (ravenscar_thread_target::mourn_inferior): Update.
5490         (ravenscar_inferior_created): Use "new" to create target.
5491         (ravenscar_thread_target::get_ada_task_ptid): Update.
5492         (_initialize_ravenscar): Don't initialize base_ptid.
5493         (ravenscar_ops): Remove global.
5494
5495 2019-02-15  Tom Tromey  <tromey@adacore.com>
5496
5497         * target.h (push_target): Declare new overload.
5498         * target.c (push_target): New overload, taking an rvalue reference.
5499         * remote.c (remote_target::open_1): Use push_target overload.
5500         * corelow.c (core_target_open): Use push_target overload.
5501
5502 2019-02-15  Tom Tromey  <tromey@adacore.com>
5503
5504         * ravenscar-thread.c (is_ravenscar_task)
5505         (ravenscar_task_is_currently_active): Return bool.
5506         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5507         (_initialize_ravenscar): Remove "(void)".
5508         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5509         Return bool.
5510
5511 2019-02-15  Tom Tromey  <tromey@adacore.com>
5512
5513         * ravenscar-thread.c (ravenscar_runtime_initializer)
5514         (has_ravenscar_runtime, get_running_thread_id)
5515         (ravenscar_thread_target::resume): Fix indentation.
5516
5517 2019-02-15  Tom Tromey  <tromey@adacore.com>
5518
5519         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5520         from ravenscar_arch_ops.
5521         (sparc_ravenscar_ops::fetch_registers)
5522         (sparc_ravenscar_ops::store_registers): Now methods.
5523         (sparc_ravenscar_prepare_to_store): Remove.
5524         (sparc_ravenscar_ops): Redefine.
5525         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5526         methods and destructor.  Remove members.
5527         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5528         (ravenscar_thread_target::store_registers)
5529         (ravenscar_thread_target::prepare_to_store): Update.
5530         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5531         Remove.
5532         (struct ppc_ravenscar_powerpc_ops): Derive from
5533         ravenscar_arch_ops.
5534         (ppc_ravenscar_powerpc_ops::fetch_registers)
5535         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5536         (ppc_ravenscar_powerpc_ops): Redefine.
5537         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5538         (ppc_ravenscar_e500_ops::fetch_registers)
5539         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5540         (ppc_ravenscar_e500_ops): Redefine.
5541         * aarch64-ravenscar-thread.c
5542         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5543         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5544         (aarch64_ravenscar_fetch_registers)
5545         (aarch64_ravenscar_store_registers): Now methods.
5546         (aarch64_ravenscar_ops): Redefine.
5547
5548 2019-02-15  Tom Tromey  <tromey@adacore.com>
5549
5550         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5551         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5552         (ravenscar_thread_target::stopped_by_watchpoint)
5553         (ravenscar_thread_target::stopped_data_address)
5554         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5555
5556 2019-02-15  Tom Tromey  <tromey@adacore.com>
5557
5558         * ravenscar-thread.c: Fix some typos.
5559
5560 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5561             Tom Tromey  <tromey@adacore.com>
5562
5563         * ada-lang.c (ada_exception_sal): Change addr_string to a
5564         std::string.
5565         (create_ada_exception_catchpoint): Update.
5566
5567 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5568             Tom Tromey  <tromey@adacore.com>
5569
5570         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5571         (bp_location_ops): Remove.
5572         (base_breakpoint_allocate_location): Update.
5573         (free_bp_location): Update.
5574         * ada-lang.c (class ada_catchpoint_location)
5575         <ada_catchpoint_location>: Remove ops parameter.
5576         (ada_catchpoint_location_dtor): Remove.
5577         (ada_catchpoint_location_ops): Remove.
5578         (allocate_location_exception): Update.
5579         * breakpoint.h (struct bp_location_ops): Remove.
5580         (class bp_location) <bp_location>: Remove bp_location_ops
5581         parameter.
5582         <~bp_location>: Add destructor.
5583         <ops>: Remove.
5584
5585 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5586             Pedro Alves  <palves@redhat.com>
5587
5588         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5589         'PATH_MAX'.
5590
5591 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5592             Samuel Thibault  <samuel.thibault@gnu.org>
5593             Thomas Schwinge  <thomas@codesourcery.com>
5594
5595         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5596         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5597
5598 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5599
5600         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5601         (check_empty): Use "const char *".
5602
5603         * gnu-nat.c (gnu_nat_target::detach): Instead of
5604         'detach_inferior (pid)' call
5605         'detach_inferior (find_inferior_pid (pid))'.
5606
5607         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5608         'nat/fork-inferior.o'.
5609         * gnu-nat.c: #include "nat/fork-inferior.h".
5610
5611         * gnu-nat.c (gnu_nat_target::detach): Instead of
5612         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5613         * gnu-nat.h: #include "inf-child.h".
5614         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5615         'i386_gnu_nat_target::fetch_registers'.
5616         (gnu_store_registers): Rename/move to
5617         'i386_gnu_nat_target::store_registers'.
5618
5619         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5620         * gnu-nat.h (mach_thread_info): New function.
5621         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5622
5623         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5624
5625 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5626
5627         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5628
5629 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5630
5631         * windows-nat.c (windows_add_thread): Add new parameter
5632         "main_thread_p" with default value set to false.  Update
5633         function documentation as well as all callers.
5634         (windows_delete_thread): Likewise.
5635         (fake_create_process): Update call to windows_add_thread.
5636         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5637         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5638         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5639         call to windows_delete_thread.
5640
5641 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5642
5643         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5644
5645 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5646
5647         * symfile.c (find_separate_debug_file): Use canonical path of
5648         sysroot with child_path instead of gdb_sysroot if it is valid.
5649
5650 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5651
5652         * symfile.c (find_separate_debug_file): Use child_path to
5653         determine if an object file is under a sysroot.
5654
5655 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5656
5657         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5658         unittests/child-path-selftests.c.
5659         * common/pathstuff.c (child_path): New function.
5660         * common/pathstuff.h (child_path): New prototype.
5661         * unittests/child-path-selftests.c: New file.
5662
5663 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5664
5665         * symfile.c (find_separate_debug_file): Look for separate debug
5666         files in debug directories under the sysroot.
5667
5668 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5669
5670         * symtab.h (struct minimal_symbol data_p): New const method.
5671         (struct minimal_symbol text_p): Likewise.
5672         * symtab.c (output_source_filename): Use file name style
5673         to print file name.
5674         (print_symbol_info): Likewise.
5675         (print_msymbol_info): Use address style to print addresses.
5676         Use function name style to print executable text symbols.
5677         (expand_symtab_containing_pc): Use data_p.
5678         (find_pc_sect_compunit_symtab): Likewise.
5679
5680 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5681
5682         * breakpoint.c (describe_other_breakpoints): Use address style
5683         to print addresses.
5684         (say_where): Likewise.
5685
5686 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5687
5688         * ada-typeprint.c (print_func_type): Print function name
5689         style to print function name.
5690         * c-typeprint.c (c_print_type_1): Likewise.
5691
5692 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5693
5694         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5695         for execve.
5696
5697 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5698
5699         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5700         type_stack.
5701
5702 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5703
5704         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5705         TYPE_CODE_REF types.
5706
5707 2019-02-08  Jim Wilson  <jimw@sifive.com>
5708
5709         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5710         (riscv_linux_fregset): New.
5711         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5712
5713 2019-02-07  Tom Tromey  <tom@tromey.com>
5714
5715         * thread.c (thread_cancel_execution_command): Update.
5716         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5717         methods.
5718         (struct thread_fsm_ops): Remove.
5719         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5720         (thread_fsm_should_stop, thread_fsm_return_value)
5721         (thread_fsm_set_finished, thread_fsm_finished_p)
5722         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5723         Don't declare.
5724         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5725         * infrun.c (clear_proceed_status_thread)
5726         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5727         (print_stop_event): Update.
5728         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5729         Add constructor.
5730         (step_command_fsm_ops): Remove.
5731         (new_step_command_fsm): Remove.
5732         (step_1): Update.
5733         (step_command_fsm::should_stop): Rename from
5734         step_command_fsm_should_stop.
5735         (step_command_fsm::clean_up): Rename from
5736         step_command_fsm_clean_up.
5737         (step_command_fsm::do_async_reply_reason): Rename from
5738         step_command_fsm_async_reply_reason.
5739         (struct until_next_fsm): Inherit from thread_fsm.  Add
5740         constructor.
5741         (until_next_fsm_ops): Remove.
5742         (new_until_next_fsm): Remove.
5743         (until_next_fsm::should_stop): Rename from
5744         until_next_fsm_should_stop.
5745         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5746         (until_next_fsm::do_async_reply_reason): Rename from
5747         until_next_fsm_async_reply_reason.
5748         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5749         constructor.  Change type of breakpoint.
5750         (finish_command_fsm_ops): Remove.
5751         (new_finish_command_fsm): Remove.
5752         (finish_command_fsm::should_stop): Rename from
5753         finish_command_fsm_should_stop.
5754         (finish_command_fsm::clean_up): Rename from
5755         finish_command_fsm_clean_up.
5756         (finish_command_fsm::return_value): Rename from
5757         finish_command_fsm_return_value.
5758         (finish_command_fsm::do_async_reply_reason): Rename from
5759         finish_command_fsm_async_reply_reason.
5760         (finish_command): Update.
5761         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5762         Add constructor.
5763         (call_thread_fsm_ops): Remove.
5764         (call_thread_fsm::call_thread_fsm): Rename from
5765         new_call_thread_fsm.
5766         (call_thread_fsm::should_stop): Rename from
5767         call_thread_fsm_should_stop.
5768         (call_thread_fsm::should_notify_stop): Rename from
5769         call_thread_fsm_should_notify_stop.
5770         (run_inferior_call, call_function_by_hand_dummy): Update.
5771         * cli/cli-interp.c (should_print_stop_to_console): Update.
5772         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5773         Add constructor.  Change type of location_breakpoint,
5774         caller_breakpoint.
5775         (until_break_fsm_ops): Remove.
5776         (new_until_break_fsm): Remove.
5777         (until_break_fsm::should_stop): Rename from
5778         until_break_fsm_should_stop.
5779         (until_break_fsm::clean_up): Rename from
5780         until_break_fsm_clean_up.
5781         (until_break_fsm::do_async_reply_reason): Rename from
5782         until_break_fsm_async_reply_reason.
5783         (until_break_command): Update.
5784         * thread-fsm.c: Remove.
5785         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5786
5787 2019-02-07  Tom Tromey  <tom@tromey.com>
5788
5789         * yy-remap.h: Add include guard.
5790         * xtensa-tdep.h: Add include guard.
5791         * xcoffread.h: Rename include guard.
5792         * varobj-iter.h: Add include guard.
5793         * tui/tui.h: Rename include guard.
5794         * tui/tui-winsource.h: Rename include guard.
5795         * tui/tui-wingeneral.h: Rename include guard.
5796         * tui/tui-windata.h: Rename include guard.
5797         * tui/tui-win.h: Rename include guard.
5798         * tui/tui-stack.h: Rename include guard.
5799         * tui/tui-source.h: Rename include guard.
5800         * tui/tui-regs.h: Rename include guard.
5801         * tui/tui-out.h: Rename include guard.
5802         * tui/tui-layout.h: Rename include guard.
5803         * tui/tui-io.h: Rename include guard.
5804         * tui/tui-hooks.h: Rename include guard.
5805         * tui/tui-file.h: Rename include guard.
5806         * tui/tui-disasm.h: Rename include guard.
5807         * tui/tui-data.h: Rename include guard.
5808         * tui/tui-command.h: Rename include guard.
5809         * tic6x-tdep.h: Add include guard.
5810         * target/waitstatus.h: Rename include guard.
5811         * target/wait.h: Rename include guard.
5812         * target/target.h: Rename include guard.
5813         * target/resume.h: Rename include guard.
5814         * target-float.h: Rename include guard.
5815         * stabsread.h: Add include guard.
5816         * rs6000-tdep.h: Add include guard.
5817         * riscv-fbsd-tdep.h: Add include guard.
5818         * regformats/regdef.h: Rename include guard.
5819         * record.h: Rename include guard.
5820         * python/python.h: Rename include guard.
5821         * python/python-internal.h: Rename include guard.
5822         * python/py-stopevent.h: Rename include guard.
5823         * python/py-ref.h: Rename include guard.
5824         * python/py-record.h: Rename include guard.
5825         * python/py-record-full.h: Rename include guard.
5826         * python/py-record-btrace.h: Rename include guard.
5827         * python/py-instruction.h: Rename include guard.
5828         * python/py-events.h: Rename include guard.
5829         * python/py-event.h: Rename include guard.
5830         * procfs.h: Add include guard.
5831         * proc-utils.h: Add include guard.
5832         * p-lang.h: Add include guard.
5833         * or1k-tdep.h: Rename include guard.
5834         * observable.h: Rename include guard.
5835         * nto-tdep.h: Rename include guard.
5836         * nat/x86-linux.h: Rename include guard.
5837         * nat/x86-linux-dregs.h: Rename include guard.
5838         * nat/x86-gcc-cpuid.h: Add include guard.
5839         * nat/x86-dregs.h: Rename include guard.
5840         * nat/x86-cpuid.h: Rename include guard.
5841         * nat/ppc-linux.h: Rename include guard.
5842         * nat/mips-linux-watch.h: Rename include guard.
5843         * nat/linux-waitpid.h: Rename include guard.
5844         * nat/linux-ptrace.h: Rename include guard.
5845         * nat/linux-procfs.h: Rename include guard.
5846         * nat/linux-osdata.h: Rename include guard.
5847         * nat/linux-nat.h: Rename include guard.
5848         * nat/linux-namespaces.h: Rename include guard.
5849         * nat/linux-btrace.h: Rename include guard.
5850         * nat/glibc_thread_db.h: Rename include guard.
5851         * nat/gdb_thread_db.h: Rename include guard.
5852         * nat/gdb_ptrace.h: Rename include guard.
5853         * nat/fork-inferior.h: Rename include guard.
5854         * nat/amd64-linux-siginfo.h: Rename include guard.
5855         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5856         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5857         * nat/aarch64-linux.h: Rename include guard.
5858         * nat/aarch64-linux-hw-point.h: Rename include guard.
5859         * mn10300-tdep.h: Add include guard.
5860         * mips-linux-tdep.h: Add include guard.
5861         * mi/mi-parse.h: Rename include guard.
5862         * mi/mi-out.h: Rename include guard.
5863         * mi/mi-main.h: Rename include guard.
5864         * mi/mi-interp.h: Rename include guard.
5865         * mi/mi-getopt.h: Rename include guard.
5866         * mi/mi-console.h: Rename include guard.
5867         * mi/mi-common.h: Rename include guard.
5868         * mi/mi-cmds.h: Rename include guard.
5869         * mi/mi-cmd-break.h: Rename include guard.
5870         * m2-lang.h: Add include guard.
5871         * location.h: Rename include guard.
5872         * linux-record.h: Rename include guard.
5873         * linux-nat.h: Add include guard.
5874         * linux-fork.h: Add include guard.
5875         * i386-darwin-tdep.h: Rename include guard.
5876         * hppa-linux-offsets.h: Add include guard.
5877         * guile/guile.h: Rename include guard.
5878         * guile/guile-internal.h: Rename include guard.
5879         * gnu-nat.h: Rename include guard.
5880         * gdb-stabs.h: Rename include guard.
5881         * frv-tdep.h: Add include guard.
5882         * f-lang.h: Add include guard.
5883         * event-loop.h: Add include guard.
5884         * darwin-nat.h: Rename include guard.
5885         * cp-abi.h: Rename include guard.
5886         * config/sparc/nm-sol2.h: Rename include guard.
5887         * config/nm-nto.h: Rename include guard.
5888         * config/nm-linux.h: Add include guard.
5889         * config/i386/nm-i386gnu.h: Rename include guard.
5890         * config/djgpp/nl_types.h: Rename include guard.
5891         * config/djgpp/langinfo.h: Rename include guard.
5892         * compile/gcc-cp-plugin.h: Add include guard.
5893         * compile/gcc-c-plugin.h: Add include guard.
5894         * compile/compile.h: Rename include guard.
5895         * compile/compile-object-run.h: Rename include guard.
5896         * compile/compile-object-load.h: Rename include guard.
5897         * compile/compile-internal.h: Rename include guard.
5898         * compile/compile-cplus.h: Rename include guard.
5899         * compile/compile-c.h: Rename include guard.
5900         * common/xml-utils.h: Rename include guard.
5901         * common/x86-xstate.h: Rename include guard.
5902         * common/version.h: Rename include guard.
5903         * common/vec.h: Rename include guard.
5904         * common/tdesc.h: Rename include guard.
5905         * common/selftest.h: Rename include guard.
5906         * common/scoped_restore.h: Rename include guard.
5907         * common/scoped_mmap.h: Rename include guard.
5908         * common/scoped_fd.h: Rename include guard.
5909         * common/safe-iterator.h: Rename include guard.
5910         * common/run-time-clock.h: Rename include guard.
5911         * common/refcounted-object.h: Rename include guard.
5912         * common/queue.h: Rename include guard.
5913         * common/ptid.h: Rename include guard.
5914         * common/print-utils.h: Rename include guard.
5915         * common/preprocessor.h: Rename include guard.
5916         * common/pathstuff.h: Rename include guard.
5917         * common/observable.h: Rename include guard.
5918         * common/netstuff.h: Rename include guard.
5919         * common/job-control.h: Rename include guard.
5920         * common/host-defs.h: Rename include guard.
5921         * common/gdb_wait.h: Rename include guard.
5922         * common/gdb_vecs.h: Rename include guard.
5923         * common/gdb_unlinker.h: Rename include guard.
5924         * common/gdb_unique_ptr.h: Rename include guard.
5925         * common/gdb_tilde_expand.h: Rename include guard.
5926         * common/gdb_sys_time.h: Rename include guard.
5927         * common/gdb_string_view.h: Rename include guard.
5928         * common/gdb_splay_tree.h: Rename include guard.
5929         * common/gdb_setjmp.h: Rename include guard.
5930         * common/gdb_ref_ptr.h: Rename include guard.
5931         * common/gdb_optional.h: Rename include guard.
5932         * common/gdb_locale.h: Rename include guard.
5933         * common/gdb_assert.h: Rename include guard.
5934         * common/filtered-iterator.h: Rename include guard.
5935         * common/filestuff.h: Rename include guard.
5936         * common/fileio.h: Rename include guard.
5937         * common/environ.h: Rename include guard.
5938         * common/common-utils.h: Rename include guard.
5939         * common/common-types.h: Rename include guard.
5940         * common/common-regcache.h: Rename include guard.
5941         * common/common-inferior.h: Rename include guard.
5942         * common/common-gdbthread.h: Rename include guard.
5943         * common/common-exceptions.h: Rename include guard.
5944         * common/common-defs.h: Rename include guard.
5945         * common/common-debug.h: Rename include guard.
5946         * common/cleanups.h: Rename include guard.
5947         * common/buffer.h: Rename include guard.
5948         * common/btrace-common.h: Rename include guard.
5949         * common/break-common.h: Rename include guard.
5950         * cli/cli-utils.h: Rename include guard.
5951         * cli/cli-style.h: Rename include guard.
5952         * cli/cli-setshow.h: Rename include guard.
5953         * cli/cli-script.h: Rename include guard.
5954         * cli/cli-interp.h: Rename include guard.
5955         * cli/cli-decode.h: Rename include guard.
5956         * cli/cli-cmds.h: Rename include guard.
5957         * charset-list.h: Add include guard.
5958         * buildsym-legacy.h: Rename include guard.
5959         * bfin-tdep.h: Add include guard.
5960         * ax.h: Rename include guard.
5961         * arm-linux-tdep.h: Add include guard.
5962         * arm-fbsd-tdep.h: Add include guard.
5963         * arch/xtensa.h: Rename include guard.
5964         * arch/tic6x.h: Add include guard.
5965         * arch/i386.h: Add include guard.
5966         * arch/arm.h: Rename include guard.
5967         * arch/arm-linux.h: Rename include guard.
5968         * arch/arm-get-next-pcs.h: Rename include guard.
5969         * arch/amd64.h: Add include guard.
5970         * arch/aarch64-insn.h: Rename include guard.
5971         * arch-utils.h: Rename include guard.
5972         * annotate.h: Add include guard.
5973         * amd64-darwin-tdep.h: Rename include guard.
5974         * aarch64-linux-tdep.h: Add include guard.
5975         * aarch64-fbsd-tdep.h: Add include guard.
5976         * aarch32-linux-nat.h: Add include guard.
5977
5978 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5979
5980         * macrotab.c (macro_define_internal): New function that
5981         factorizes macro_define_object_internal and macro_define_function
5982         code.
5983         (macro_define_object_internal): Use macro_define_internal.
5984         (macro_define_function): Likewise.
5985
5986 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5987
5988         * macrocmd.c (extract_identifier): Return
5989         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5990         callers.
5991
5992 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5993
5994         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5995
5996 2019-02-05  Tom Tromey  <tom@tromey.com>
5997
5998         * target.c (target_stack::unpush): Move assertion earlier.
5999
6000 2019-01-30  Tom Tromey  <tom@tromey.com>
6001
6002         PR python/23615:
6003         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6004         (gdbpy_parse_and_eval): Likewise.
6005         * python/python-internal.h (gdbpy_allow_threads): New class.
6006
6007 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6008
6009         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6010         (aarch64_fbsd_fpregmap): Move earlier.
6011         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6012         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6013         instead of individual calls to trad_frame_set_reg_addr.
6014         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6015         earlier.
6016         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6017         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6018         instead of individual calls to trad_frame_set_reg_addr.
6019
6020 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6021
6022         * CONTRIBUTE: Replace contribution list with wiki link.
6023
6024 2019-01-25  Tom Tromey  <tom@tromey.com>
6025
6026         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6027
6028 2019-01-25  Tom Tromey  <tom@tromey.com>
6029
6030         * xtensa-linux-nat.c: Fix common/ includes.
6031         * xml-support.h: Fix common/ includes.
6032         * xml-support.c: Fix common/ includes.
6033         * x86-linux-nat.c: Fix common/ includes.
6034         * windows-nat.c: Fix common/ includes.
6035         * varobj.h: Fix common/ includes.
6036         * varobj.c: Fix common/ includes.
6037         * value.c: Fix common/ includes.
6038         * valops.c: Fix common/ includes.
6039         * utils.c: Fix common/ includes.
6040         * unittests/xml-utils-selftests.c: Fix common/ includes.
6041         * unittests/utils-selftests.c: Fix common/ includes.
6042         * unittests/unpack-selftests.c: Fix common/ includes.
6043         * unittests/tracepoint-selftests.c: Fix common/ includes.
6044         * unittests/style-selftests.c: Fix common/ includes.
6045         * unittests/string_view-selftests.c: Fix common/ includes.
6046         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6047         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6048         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6049         * unittests/rsp-low-selftests.c: Fix common/ includes.
6050         * unittests/parse-connection-spec-selftests.c: Fix common/
6051         includes.
6052         * unittests/optional-selftests.c: Fix common/ includes.
6053         * unittests/offset-type-selftests.c: Fix common/ includes.
6054         * unittests/observable-selftests.c: Fix common/ includes.
6055         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6056         * unittests/memrange-selftests.c: Fix common/ includes.
6057         * unittests/memory-map-selftests.c: Fix common/ includes.
6058         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6059         * unittests/function-view-selftests.c: Fix common/ includes.
6060         * unittests/environ-selftests.c: Fix common/ includes.
6061         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6062         * unittests/common-utils-selftests.c: Fix common/ includes.
6063         * unittests/cli-utils-selftests.c: Fix common/ includes.
6064         * unittests/array-view-selftests.c: Fix common/ includes.
6065         * ui-file.c: Fix common/ includes.
6066         * tui/tui-io.c: Fix common/ includes.
6067         * tracepoint.h: Fix common/ includes.
6068         * tracepoint.c: Fix common/ includes.
6069         * tracefile-tfile.c: Fix common/ includes.
6070         * top.h: Fix common/ includes.
6071         * top.c: Fix common/ includes.
6072         * thread.c: Fix common/ includes.
6073         * target/waitstatus.h: Fix common/ includes.
6074         * target/waitstatus.c: Fix common/ includes.
6075         * target.h: Fix common/ includes.
6076         * target.c: Fix common/ includes.
6077         * target-memory.c: Fix common/ includes.
6078         * target-descriptions.c: Fix common/ includes.
6079         * symtab.h: Fix common/ includes.
6080         * symfile.c: Fix common/ includes.
6081         * stap-probe.c: Fix common/ includes.
6082         * spu-linux-nat.c: Fix common/ includes.
6083         * sparc-nat.c: Fix common/ includes.
6084         * source.c: Fix common/ includes.
6085         * solib.c: Fix common/ includes.
6086         * solib-target.c: Fix common/ includes.
6087         * ser-unix.c: Fix common/ includes.
6088         * ser-tcp.c: Fix common/ includes.
6089         * ser-pipe.c: Fix common/ includes.
6090         * ser-base.c: Fix common/ includes.
6091         * selftest-arch.c: Fix common/ includes.
6092         * s12z-tdep.c: Fix common/ includes.
6093         * rust-exp.y: Fix common/ includes.
6094         * rs6000-aix-tdep.c: Fix common/ includes.
6095         * riscv-tdep.c: Fix common/ includes.
6096         * remote.c: Fix common/ includes.
6097         * remote-notif.h: Fix common/ includes.
6098         * remote-fileio.h: Fix common/ includes.
6099         * remote-fileio.c: Fix common/ includes.
6100         * regcache.h: Fix common/ includes.
6101         * regcache.c: Fix common/ includes.
6102         * record-btrace.c: Fix common/ includes.
6103         * python/python.c: Fix common/ includes.
6104         * python/py-type.c: Fix common/ includes.
6105         * python/py-inferior.c: Fix common/ includes.
6106         * progspace.h: Fix common/ includes.
6107         * producer.c: Fix common/ includes.
6108         * procfs.c: Fix common/ includes.
6109         * proc-api.c: Fix common/ includes.
6110         * printcmd.c: Fix common/ includes.
6111         * ppc-linux-nat.c: Fix common/ includes.
6112         * parser-defs.h: Fix common/ includes.
6113         * osdata.c: Fix common/ includes.
6114         * obsd-nat.c: Fix common/ includes.
6115         * nat/x86-linux.c: Fix common/ includes.
6116         * nat/x86-linux-dregs.c: Fix common/ includes.
6117         * nat/x86-dregs.h: Fix common/ includes.
6118         * nat/x86-dregs.c: Fix common/ includes.
6119         * nat/ppc-linux.c: Fix common/ includes.
6120         * nat/mips-linux-watch.h: Fix common/ includes.
6121         * nat/mips-linux-watch.c: Fix common/ includes.
6122         * nat/linux-waitpid.c: Fix common/ includes.
6123         * nat/linux-ptrace.h: Fix common/ includes.
6124         * nat/linux-ptrace.c: Fix common/ includes.
6125         * nat/linux-procfs.c: Fix common/ includes.
6126         * nat/linux-personality.c: Fix common/ includes.
6127         * nat/linux-osdata.c: Fix common/ includes.
6128         * nat/linux-namespaces.c: Fix common/ includes.
6129         * nat/linux-btrace.h: Fix common/ includes.
6130         * nat/linux-btrace.c: Fix common/ includes.
6131         * nat/fork-inferior.c: Fix common/ includes.
6132         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6133         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6134         * nat/aarch64-linux.c: Fix common/ includes.
6135         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6136         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6137         * namespace.h: Fix common/ includes.
6138         * mips-linux-tdep.c: Fix common/ includes.
6139         * minsyms.c: Fix common/ includes.
6140         * mi/mi-parse.h: Fix common/ includes.
6141         * mi/mi-main.c: Fix common/ includes.
6142         * mi/mi-cmd-env.c: Fix common/ includes.
6143         * memrange.h: Fix common/ includes.
6144         * memattr.c: Fix common/ includes.
6145         * maint.h: Fix common/ includes.
6146         * maint.c: Fix common/ includes.
6147         * main.c: Fix common/ includes.
6148         * machoread.c: Fix common/ includes.
6149         * location.c: Fix common/ includes.
6150         * linux-thread-db.c: Fix common/ includes.
6151         * linux-nat.c: Fix common/ includes.
6152         * linux-fork.c: Fix common/ includes.
6153         * inline-frame.c: Fix common/ includes.
6154         * infrun.c: Fix common/ includes.
6155         * inflow.c: Fix common/ includes.
6156         * inferior.h: Fix common/ includes.
6157         * inferior.c: Fix common/ includes.
6158         * infcmd.c: Fix common/ includes.
6159         * inf-ptrace.c: Fix common/ includes.
6160         * inf-child.c: Fix common/ includes.
6161         * ia64-linux-nat.c: Fix common/ includes.
6162         * i387-tdep.c: Fix common/ includes.
6163         * i386-tdep.c: Fix common/ includes.
6164         * i386-linux-tdep.c: Fix common/ includes.
6165         * i386-linux-nat.c: Fix common/ includes.
6166         * i386-go32-tdep.c: Fix common/ includes.
6167         * i386-fbsd-tdep.c: Fix common/ includes.
6168         * i386-fbsd-nat.c: Fix common/ includes.
6169         * guile/scm-type.c: Fix common/ includes.
6170         * guile/guile.c: Fix common/ includes.
6171         * go32-nat.c: Fix common/ includes.
6172         * gnu-nat.c: Fix common/ includes.
6173         * gdbthread.h: Fix common/ includes.
6174         * gdbarch-selftests.c: Fix common/ includes.
6175         * gdb_usleep.c: Fix common/ includes.
6176         * gdb_select.h: Fix common/ includes.
6177         * gdb_bfd.c: Fix common/ includes.
6178         * gcore.c: Fix common/ includes.
6179         * fork-child.c: Fix common/ includes.
6180         * findvar.c: Fix common/ includes.
6181         * fbsd-nat.c: Fix common/ includes.
6182         * event-top.c: Fix common/ includes.
6183         * event-loop.c: Fix common/ includes.
6184         * dwarf2read.c: Fix common/ includes.
6185         * dwarf2loc.c: Fix common/ includes.
6186         * dwarf2-frame.c: Fix common/ includes.
6187         * dwarf-index-cache.c: Fix common/ includes.
6188         * dtrace-probe.c: Fix common/ includes.
6189         * disasm-selftests.c: Fix common/ includes.
6190         * defs.h: Fix common/ includes.
6191         * csky-tdep.c: Fix common/ includes.
6192         * cp-valprint.c: Fix common/ includes.
6193         * cp-support.h: Fix common/ includes.
6194         * cp-support.c: Fix common/ includes.
6195         * corelow.c: Fix common/ includes.
6196         * completer.h: Fix common/ includes.
6197         * completer.c: Fix common/ includes.
6198         * compile/compile.c: Fix common/ includes.
6199         * compile/compile-loc2c.c: Fix common/ includes.
6200         * compile/compile-cplus-types.c: Fix common/ includes.
6201         * compile/compile-cplus-symbols.c: Fix common/ includes.
6202         * command.h: Fix common/ includes.
6203         * cli/cli-dump.c: Fix common/ includes.
6204         * cli/cli-cmds.c: Fix common/ includes.
6205         * charset.c: Fix common/ includes.
6206         * build-id.c: Fix common/ includes.
6207         * btrace.h: Fix common/ includes.
6208         * btrace.c: Fix common/ includes.
6209         * breakpoint.h: Fix common/ includes.
6210         * breakpoint.c: Fix common/ includes.
6211         * ax.h:
6212         (enum agent_op): Fix common/ includes.
6213         * ax-general.c (struct aop_map): Fix common/ includes.
6214         * ax-gdb.c: Fix common/ includes.
6215         * auxv.c: Fix common/ includes.
6216         * auto-load.c: Fix common/ includes.
6217         * arm-tdep.c: Fix common/ includes.
6218         * arch/riscv.c: Fix common/ includes.
6219         * arch/ppc-linux-common.c: Fix common/ includes.
6220         * arch/i386.c: Fix common/ includes.
6221         * arch/arm.c: Fix common/ includes.
6222         * arch/arm-linux.c: Fix common/ includes.
6223         * arch/arm-get-next-pcs.c: Fix common/ includes.
6224         * arch/amd64.c: Fix common/ includes.
6225         * arch/aarch64.c: Fix common/ includes.
6226         * arch/aarch64-insn.c: Fix common/ includes.
6227         * arch-utils.c: Fix common/ includes.
6228         * amd64-windows-tdep.c: Fix common/ includes.
6229         * amd64-tdep.c: Fix common/ includes.
6230         * amd64-sol2-tdep.c: Fix common/ includes.
6231         * amd64-obsd-tdep.c: Fix common/ includes.
6232         * amd64-nbsd-tdep.c: Fix common/ includes.
6233         * amd64-linux-tdep.c: Fix common/ includes.
6234         * amd64-linux-nat.c: Fix common/ includes.
6235         * amd64-fbsd-tdep.c: Fix common/ includes.
6236         * amd64-fbsd-nat.c: Fix common/ includes.
6237         * amd64-dicos-tdep.c: Fix common/ includes.
6238         * amd64-darwin-tdep.c: Fix common/ includes.
6239         * agent.c: Fix common/ includes.
6240         * ada-lang.h: Fix common/ includes.
6241         * ada-lang.c: Fix common/ includes.
6242         * aarch64-tdep.c: Fix common/ includes.
6243
6244 2019-01-25  Tom Tromey  <tom@tromey.com>
6245
6246         * common/create-version.sh: Use common/version.h.
6247
6248 2019-01-24  Pedro Alves  <palves@redhat.com>
6249
6250         * infrun.c (signal_stop, signal_print, signal_program)
6251         (signal_catch, signal_pass): Now arrays instead of pointers.
6252         (update_signals_program_target, do_target_resume)
6253         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6254         * linux-nat.c (linux_nat_target::pass_signals)
6255         (linux_nat_target::create_inferior, linux_nat_target::attach):
6256         Adjust.
6257         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6258         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6259         * procfs.c (procfs_target::pass_signals): Adjust.
6260         * record-full.c (record_full_target::resume): Adjust.
6261         * remote.c (remote_target::pass_signals)
6262         (remote_target::program_signals): Adjust.
6263         * target-debug.h (target_debug_print_signals): Now takes a
6264         gdb::array_view as parameter.  Adjust.
6265         * target.h (target_ops) <pass_signals, program_signals>: Replace
6266         pointer and length parameters with gdb::array_view.
6267         (target_pass_signals, target_program_signals): Likewise.
6268         * target-delegates.c: Regenerate.
6269
6270 2019-01-24  Pedro Alves  <palves@redhat.com>
6271
6272         * common/forward-scope-exit.h
6273         (forward_scope_exit::forward_scope_exit): Pass arguments to
6274         m_bind_function directly, instead of creating a std::bind and
6275         copying that.
6276
6277 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6278
6279         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6280         for static members.
6281         (pass_in_v_vfp_candidate): Likewise.
6282
6283 2019-01-23  Tom Tromey  <tom@tromey.com>
6284             Pedro Alves  <palves@redhat.com>
6285
6286         * regcache.c (class regcache_invalidator): Remove.
6287         (regcache::raw_write): Use make_scope_exit.
6288
6289 2019-01-23  Tom Tromey  <tom@tromey.com>
6290
6291         * ui-out.h (class ui_out_emit_type): Update comment.
6292
6293 2019-01-23  Tom Tromey  <tom@tromey.com>
6294
6295         * infrun.c (fetch_inferior_event): Update comment.
6296
6297 2019-01-23  Tom Tromey  <tom@tromey.com>
6298             Pedro Alves  <palves@redhat.com>
6299
6300         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6301         parameter.
6302         (fetch_inferior_event): Use SCOPE_EXIT.
6303
6304
6305 2019-01-23  Tom Tromey  <tom@tromey.com>
6306             Pedro Alves  <palves@redhat.com>
6307
6308         * infrun.c (disable_thread_events): Delete.
6309         (stop_all_threads): Use SCOPE_EXIT.
6310
6311 2019-01-23  Tom Tromey  <tom@tromey.com>
6312             Pedro Alves  <palves@redhat.com>
6313
6314         * symfile.c: Include forward-scope-exit.h.
6315         (clear_symtab_users_cleanup): Replace forward declaration with
6316         a FORWARD_SCOPE_EXIT.
6317         (syms_from_objfile_1): Use the forward_scope_exit and
6318         gdb::optional instead of cleanup_function.
6319         (reread_symbols): Use the forward_scope_exit instead of
6320         cleanup_function.
6321         (clear_symtab_users_cleanup): Remove function.
6322
6323 2019-01-23  Tom Tromey  <tom@tromey.com>
6324             Pedro Alves  <palves@redhat.com>
6325
6326         * linux-nat.c: Include scope-exit.h.
6327         (cleanup_target_stop): Remove.
6328         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6329         SCOPE_EXIT.
6330
6331 2019-01-23  Tom Tromey  <tom@tromey.com>
6332             Pedro Alves  <palves@redhat.com>
6333
6334         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6335         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6336
6337 2019-01-23  Tom Tromey  <tom@tromey.com>
6338             Andrew Burgess  <andrew.burgess@embecosm.com>
6339             Pedro Alves  <palves@redhat.com>
6340
6341         * infrun.c (fetch_inferior_event): Use scope_exit.
6342         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6343         * top.c (execute_command): Use scope_exit.
6344         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6345         * utils.c (do_bpstat_clear_actions_cleanup)
6346         (make_bpstat_clear_actions_cleanup): Remove.
6347
6348 2019-01-23  Tom Tromey  <tom@tromey.com>
6349             Pedro Alves  <palves@redhat.com>
6350
6351         * infrun.c: Include "common/scope-exit.h"
6352         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6353         (wait_for_inferior): Use SCOPE_EXIT.
6354         (fetch_inferior_event): Use scope_exit.
6355
6356 2019-01-23  Tom Tromey  <tom@tromey.com>
6357             Pedro Alves  <palves@redhat.com>
6358
6359         * breakpoint.c (create_breakpoint): Remove cleanup.
6360
6361 2019-01-23  Tom Tromey  <tom@tromey.com>
6362             Andrew Burgess  <andrew.burgess@embecosm.com>
6363             Pedro Alves  <palves@redhat.com>
6364
6365 2019-01-23  Pedro Alves  <palves@redhat.com>
6366
6367         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6368
6369 2019-01-23  Pedro Alves  <palves@redhat.com>
6370             Andrew Burgess  <andrew.burgess@embecosm.com>
6371
6372         * gdbthread.h: Include "common/forward-scope-exit.h".
6373         (scoped_finish_thread_state): Redefine custom class in terms of
6374         forward_scope_exit.
6375
6376 2019-01-23  Pedro Alves  <palves@redhat.com>
6377             Andrew Burgess  <andrew.burgess@embecosm.com>
6378
6379         * common/forward-scope-exit.h: New file.
6380
6381 2019-01-23  Pedro Alves  <palves@redhat.com>
6382             Andrew Burgess  <andrew.burgess@embecosm.com>
6383             Tom Tromey  <tom@tromey.com>
6384
6385         * common/scope-exit.h: New file.
6386
6387 2019-01-23  Pedro Alves  <palves@redhat.com>
6388
6389         * common/preprocessor.h (ESC): Rename to ...
6390         (ESC_PARENS): ... this.
6391         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6392         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6393
6394 2019-01-23  Tom Tromey  <tom@tromey.com>
6395
6396         * language.h (class scoped_switch_to_sym_language_if_auto):
6397         Initialize m_lang in both cases.
6398
6399 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6400
6401         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6402         with XCNEW.
6403
6404 2019-01-22  Tom Tromey  <tom@tromey.com>
6405
6406         * corelow.c: Do not include sys/file.h.
6407
6408 2019-01-22  Tom Tromey  <tom@tromey.com>
6409
6410         * tui/tui-wingeneral.h: Include gdb_curses.h.
6411
6412 2019-01-22  Tom Tromey  <tom@tromey.com>
6413
6414         * source-cache.h (class source_cache) <get_source_lines,
6415         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6416
6417 2019-01-22  Tom Tromey  <tom@tromey.com>
6418
6419         * remote-fileio.h (struct remote_target): Declare.
6420
6421 2019-01-22  Tom Tromey  <tom@tromey.com>
6422
6423         * python/py-arch.c: Do not include py-ref.h.
6424         * python/py-bpevent.c: Do not include py-ref.h.
6425         * python/py-cmd.c: Do not include py-ref.h.
6426         * python/py-continueevent.c: Do not include py-ref.h.
6427         * python/py-event.h: Do not include py-ref.h.
6428         * python/py-evtregistry.c: Do not include py-ref.h.
6429         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6430         * python/py-frame.c: Do not include py-ref.h.
6431         * python/py-framefilter.c: Do not include py-ref.h.
6432         * python/py-function.c: Do not include py-ref.h.
6433         * python/py-infevents.c: Do not include py-ref.h.
6434         * python/py-linetable.c: Do not include py-ref.h.
6435         * python/py-objfile.c: Do not include py-ref.h.
6436         * python/py-param.c: Do not include py-ref.h.
6437         * python/py-prettyprint.c: Do not include py-ref.h.
6438         * python/py-progspace.c: Do not include py-ref.h.
6439         * python/py-symbol.c: Do not include py-ref.h.
6440         * python/py-symtab.c: Do not include py-ref.h.
6441         * python/py-type.c: Do not include py-ref.h.
6442         * python/py-unwind.c: Do not include py-ref.h.
6443         * python/py-utils.c: Do not include py-ref.h.
6444         * python/py-value.c: Do not include py-ref.h.
6445         * python/py-varobj.c: Do not include py-ref.h.
6446         * python/py-xmethods.c: Do not include py-ref.h.
6447         * python/python.c: Do not include py-ref.h.
6448         * varobj.c: Do not include py-ref.h.
6449
6450 2019-01-22  Tom Tromey  <tom@tromey.com>
6451
6452         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6453         keyword for bcache.
6454
6455 2019-01-22  Tom Tromey  <tom@tromey.com>
6456
6457         * compile/compile-cplus-types.c: Remove a comment by #include.
6458
6459 2019-01-22  Tom Tromey  <tom@tromey.com>
6460
6461         * compile/gcc-c-plugin.h: Include compile-internal.h.
6462
6463 2019-01-22  Tom Tromey  <tom@tromey.com>
6464
6465         * stabsread.c (EXTERN): Do not define.
6466         (symnum, next_symbol_text_func, processing_gcc_compilation)
6467         (within_function, global_sym_chain, global_stabs)
6468         (previous_stab_code, this_object_header_files)
6469         (n_this_object_header_files)
6470         (n_allocated_this_object_header_files): Define.
6471         * stabsread.h (EXTERN): Never define.  Use "extern".
6472
6473 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6474
6475         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6476         history_value.
6477
6478 2019-01-21  Tom Tromey  <tom@tromey.com>
6479
6480         * ui-out.c: Fix includes.
6481         * tui/tui-source.c: Fix includes.
6482         * target.c: Fix includes.
6483         * remote.c: Fix includes.
6484         * regcache.c: Fix includes.
6485         * python/py-block.c: Fix includes.
6486         * printcmd.c: Fix includes.
6487         * or1k-tdep.c: Fix includes.
6488         * mi/mi-main.c: Fix includes.
6489         * m32r-tdep.c: Fix includes.
6490         * csky-tdep.c: Fix includes.
6491         * compile/compile-cplus-types.c: Fix includes.
6492         * cli/cli-interp.c: Fix includes.
6493
6494 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6495
6496         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6497         for padding.
6498
6499 2019-01-16  Tom Tromey  <tom@tromey.com>
6500
6501         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6502         earlier.
6503         (struct objfile) <msymbols_range>: Move from top level.
6504         <msymbols>: New method.
6505         (class objfile_msymbols): Remove.
6506         * symtab.c (default_collect_symbol_completion_matches_break_on):
6507         Update.
6508         * symmisc.c (dump_msymbols): Update.
6509         * stabsread.c (scan_file_globals): Update.
6510         * objc-lang.c (info_selectors_command, info_classes_command)
6511         (find_methods): Update.
6512         * minsyms.c (find_solib_trampoline_target): Update.
6513         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6514         * coffread.c (coff_symfile_read): Update.
6515         * ada-lang.c (ada_lookup_simple_minsym)
6516         (ada_collect_symbol_completion_matches): Update.
6517
6518 2019-01-16  Tom Tromey  <tom@tromey.com>
6519
6520         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6521         type.  Remove no-argument constructor.
6522         <iterator::operator++>: Simplify.
6523         <begin>: Update.
6524         <end>: Use minimal_symbol_count.
6525
6526 2019-01-16  Tom Tromey  <tom@tromey.com>
6527
6528         * objfiles.h (struct objfile) <psymtabs>: New method.
6529         (class objfile_psymtabs): Remove.
6530         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6531         typedef.
6532         <range>: New method.
6533         (require_partial_symbols): Change return type.
6534         * psymtab.c (require_partial_symbols)
6535         (psym_expand_symtabs_matching): Update.
6536         * mdebugread.c (parse_partial_symbols): Update.
6537         * dbxread.c (dbx_end_psymtab): Update.
6538
6539 2019-01-15  Tom Tromey  <tom@tromey.com>
6540
6541         * symtab.c (lookup_objfile_from_block)
6542         (lookup_symbol_in_objfile_symtabs)
6543         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6544         (find_line_symtab, info_sources_command)
6545         (default_collect_symbol_completion_matches_break_on)
6546         (make_source_files_completion_list): Update.
6547         * symmisc.c (print_objfile_statistics, dump_objfile)
6548         (maintenance_print_symbols, maintenance_info_symtabs)
6549         (maintenance_check_symtabs, maintenance_info_line_tables):
6550         Update.
6551         * source.c (select_source_symtab)
6552         (forget_cached_source_info_for_objfile): Update.
6553         * objfiles.h (class objfile_compunits): Remove.
6554         (struct objfile) <compunits_range>: New typedef.
6555         (compunits): New method.
6556         * objfiles.c (objfile_relocate1): Update.
6557         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6558         * maint.c (count_symtabs_and_blocks): Update.
6559         * linespec.c (iterate_over_all_matching_symtabs): Update.
6560         * cp-support.c (add_symbol_overload_list_qualified): Update.
6561         * coffread.c (coff_symtab_read): Update.
6562         * ada-lang.c (add_nonlocal_symbols)
6563         (ada_collect_symbol_completion_matches)
6564         (ada_add_global_exceptions): Update.
6565
6566 2019-01-15  Tom Tromey  <tom@tromey.com>
6567
6568         * progspace.h (program_space) <objfiles_safe_range>: New
6569         typedef.
6570         <objfiles_safe>: New method.
6571         * objfiles.h (class all_objfiles_safe): Remove.
6572         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6573         * jit.c (jit_inferior_exit_hook): Update.
6574
6575 2019-01-17  Tom Tromey  <tom@tromey.com>
6576
6577         * progspace.h (program_space) <objfiles_range>: New typedef.
6578         <objfiles>: New method.
6579         <objfiles_head>: Rename from objfiles.
6580         (object_files): Update.
6581         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6582         * guile/scm-pretty-print.c
6583         (ppscm_find_pretty_printer_from_objfiles): Update.
6584         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6585         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6586         Update.
6587         * python/py-progspace.c (pspy_get_objfiles): Update.
6588         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6589         Update.
6590         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6591         (objfpy_lookup_objfile_by_build_id): Update.
6592         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6593         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6594         Update.
6595         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6596         (expand_symtab_containing_pc, lookup_objfile_from_block)
6597         (lookup_static_symbol, basic_lookup_transparent_type)
6598         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6599         (find_line_symtab, info_sources_command)
6600         (default_collect_symbol_completion_matches_break_on)
6601         (make_source_files_completion_list, find_main_name): Update.
6602         * symmisc.c (print_symbol_bcache_statistics)
6603         (print_objfile_statistics, maintenance_print_symbols)
6604         (maintenance_print_msymbols, maintenance_print_objfiles)
6605         (maintenance_info_symtabs, maintenance_check_symtabs)
6606         (maintenance_expand_symtabs, maintenance_info_line_tables):
6607         Update.
6608         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6609         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6610         (map_overlay_command, unmap_overlay_command)
6611         (simple_overlay_update, expand_symtabs_matching)
6612         (map_symbol_filenames): Update.
6613         * symfile-debug.c (set_debug_symfile): Update.
6614         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6615         Update.
6616         * source.c (select_source_symtab, forget_cached_source_info):
6617         Update.
6618         * solib.c (solib_read_symbols): Update.
6619         * solib-spu.c (append_ocl_sos): Update.
6620         * psymtab.c (maintenance_print_psymbols)
6621         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6622         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6623         * printcmd.c (info_symbol_command): Update.
6624         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6625         Update.
6626         * objfiles.h (class all_objfiles): Remove.
6627         * objfiles.c (have_partial_symbols, have_full_symbols)
6628         (have_minimal_symbols, qsort_cmp, update_section_map)
6629         (shared_objfile_contains_address_p)
6630         (default_iterate_over_objfiles_in_search_order): Update.
6631         * objc-lang.c (info_selectors_command, info_classes_command)
6632         (find_methods): Update.
6633         * minsyms.c (find_solib_trampoline_target): Update.
6634         * maint.c (maintenance_info_sections)
6635         (maintenance_translate_address, count_symtabs_and_blocks):
6636         Update.
6637         * main.c (captured_main_1): Update.
6638         * linux-thread-db.c (try_thread_db_load_from_pdir)
6639         (has_libpthread): Update.
6640         * linespec.c (iterate_over_all_matching_symtabs)
6641         (search_minsyms_for_name): Update.
6642         * jit.c (jit_find_objf_with_entry_addr): Update.
6643         * hppa-tdep.c (find_unwind_entry)
6644         (hppa_lookup_stub_minimal_symbol): Update.
6645         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6646         Update.
6647         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6648         (elf_gnu_ifunc_resolve_by_got): Update.
6649         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6650         * dwarf-index-write.c (save_gdb_index_command): Update.
6651         * cp-support.c (add_symbol_overload_list_qualified): Update.
6652         * breakpoint.c (create_overlay_event_breakpoint)
6653         (create_longjmp_master_breakpoint)
6654         (create_std_terminate_master_breakpoint)
6655         (create_exception_master_breakpoint): Update.
6656         * blockframe.c (find_pc_partial_function): Update.
6657         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6658         (ada_collect_symbol_completion_matches)
6659         (ada_add_global_exceptions): Update.
6660
6661 2019-01-17  Tom Tromey  <tom@tromey.com>
6662
6663         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6664         declare VEC.
6665         (solib_target_parse_libraries): Change return type.
6666         (library_list_start_segment, library_list_start_section)
6667         (library_list_end_library, library_list_start_library); Update.
6668         (solib_target_free_library_list): Remove.
6669         (solib_target_parse_libraries): Remove cleanup.  Change return
6670         type.
6671         (solib_target_current_sos): Update.
6672
6673 2019-01-17  Tom Tromey  <tromey@bapiya>
6674
6675         * valprint.c: Replace "the the" with "the".
6676         * symtab.c: Replace "the the" with "the".
6677         * solib.c: Replace "the the" with "the".
6678         * solib-dsbt.c: Replace "the the" with "the".
6679         * linespec.c: Replace "the the" with "the".
6680         * dwarf2loc.h: Replace "the the" with "the".
6681         * amd64-windows-tdep.c: Replace "the the" with "the".
6682         * aarch64-tdep.c: Replace "the the" with "the".
6683
6684 2019-01-16  Keith Seitz  <keiths@redhat.com>
6685
6686         PR gdb/23773
6687         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6688         <builder>: Rename to ..
6689         <m_builder>: ... this and make private.
6690         (dwarf2_cu::get_builder): New method.  Change all users of
6691         `builder' to use this method.
6692         (dwarf2_start_symtab): Move to ...
6693         (dwarf2_cu::start_symtab): ... here.  Update all callers
6694         (setup_type_unit_groups): Move to ...
6695         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6696         callers.
6697         (dwarf2_cu::reset_builder): New method.
6698         (process_full_compunit, process_full_type_unit): Use
6699         dwarf2_cu::reset_builder.
6700         (follow_die_offset): Record the ancestor CU if it is different
6701         from the followed DIE's CU.
6702         (follow_die_sig_1): Likewise.
6703
6704 2019-01-15  Tom Tromey  <tom@tromey.com>
6705
6706         * remote.c (class remote_state) <buf>: Now a char_vector.
6707         <buf_size>: Remove.
6708         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6709         parameter.
6710         (remote_target::getpkt_or_notif_sane_1)
6711         (remote_target::getpkt_sane)
6712         (remote_target::getpkt_or_notif_sane): Likewise.
6713         (class remote_target) <putpkt>: New overload.
6714         (remote_target::read_frame): Change type of "buf_p".  Remove
6715         sizeof_p parameter.
6716         (packet_ok): New overload.
6717         (packet_check_result): New overload.
6718         Update all uses.
6719
6720 2019-01-14  Tom Tromey  <tom@tromey.com>
6721
6722         * remote-notif.c (handle_notification, remote_notif_ack)
6723         (remote_notif_parse): Make "buf" const.
6724         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6725         const.
6726         (remote_notif_parse, remote_notif_ack, handle_notification):
6727         Likewise.
6728         * remote.c (remote_notif_stop_parse): Make "buf" const.
6729         (remote_target::remote_parse_stop_reply): Make "buf" const.
6730         (remote_notif_stop_ack): Make "buf" const.
6731
6732 2019-01-14  Tom Tromey  <tom@tromey.com>
6733
6734         * remote.c (remote_console_output): Make parameter const.
6735
6736 2019-01-14  Tom Tromey  <tom@tromey.com>
6737
6738         * target-debug.h (target_debug_print_signals): Constify.
6739         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6740         * procfs.c (procfs_target::pass_signals): Update.
6741         * linux-nat.c (linux_nat_target::pass_signals): Update.
6742         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6743         * target-delegates.c: Rebuild.
6744         * remote.c (remote_target::program_signals): Update.
6745         (remote_target::pass_signals): Update.
6746         * target.c (target_pass_signals): Constify argument.
6747         (target_program_signals): Likewise.
6748         * target.h (struct target_ops) <pass_signals, program_signals>:
6749         Constify argument.
6750         (target_pass_signals, target_program_signals): Constify argument.
6751
6752 2019-01-14  Tom Tromey  <tom@tromey.com>
6753
6754         PR tui/28819:
6755         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6756
6757 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6758
6759         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6760         field.
6761         * rs6000-tdep.c: Include reggroups.h.
6762         (IS_V_ALIAS_PSEUDOREG): Define.
6763         (rs6000_register_name): Return names for the "vX" aliases.
6764         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6765         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6766         aliases.  Call default_register_reggroup_p for all other
6767         pseudo-registers.
6768         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6769         New functions.
6770         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6771         Handle "vX" aliases.
6772         (v_alias_pseudo_register_collect): New function.
6773         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6774         (rs6000_gdbarch_init): Initialize "vX" aliases as
6775         pseudo-registers.  Restore registration of
6776         rs6000_pseudo_register_reggroup_p with
6777         set_tdesc_pseudo_register_reggroup_p.
6778
6779 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6780
6781         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6782         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6783         set_gdbarch_num_pseudo_regs.
6784
6785 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6786
6787         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6788         Remove arg prefixname, add do_set and do_show.
6789         Add member functions set_list and show_list.
6790         * cli/cli-style.c (class cli_style_option): Update accordingly.
6791         (style_set_list): Move to file scope.
6792         (style_show_list): Likewise.
6793         (set_style): Call help_list.
6794         (show_style): Call cmd_show_list.
6795         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6796         Update to use the new macro.
6797
6798 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6799
6800         * ada-lang.c (_initialize_ada_language): Expand the help text
6801         for the "catch exception" command.
6802
6803 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6804
6805         * symtab.c (matching_obj_sections): Initialize obj,
6806         declare it closer to its usage.
6807
6808 2019-01-10  Tom Tromey  <tom@tromey.com>
6809
6810         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6811         (basic_inf_threads_range): Remove.
6812         (inf_threads_range, inf_non_exited_threads_range)
6813         (safe_inf_threads_range): Use next_adapter.
6814
6815 2019-01-10  Keith Seitz  <keiths@redhat.com>
6816
6817         PR gdb/23712
6818         PR symtab/23010
6819         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6820         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6821
6822 2019-01-10  Keith Seitz  <keiths@redhat.com>
6823
6824         PR gdb/23712
6825         PR symtab/23010
6826         * dictionary.c (pending_to_vector): Remove.
6827         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6828         Remove _1 suffix, replacing functions of the same name.  Update
6829         all callers.
6830         (dict_create_hashed, dict_create_hashed_expandable)
6831         (dict_create_linear, dict_create_linear_expandable, dict_free)
6832         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6833         Make functions static.
6834
6835 2019-01-10  Keith Seitz  <keiths@redhat.com>
6836
6837         PR gdb/23712
6838         PR symtab/23010
6839         * dictionary.h (struct dictionary): Replace declaration with
6840         multidictionary.
6841         (dict_create_hashed, dict_create_hashed_expandable)
6842         (dict_create_linear, dict_create_linear_expandable)
6843         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6844         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6845         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6846         taking multidictionary argument.
6847         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6848         * block.h (struct block) <dict>: Change to multidictionary
6849         and rename `multidict'.
6850         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6851         symmisc.c: Update all dictionary references to multidictionary.
6852
6853 2019-01-10  Keith Seitz  <keiths@redhat.com>
6854
6855         PR gdb/23712
6856         PR symtab/23010
6857         * dictionary.c: Include unordered_map.
6858         (pending_to_vector): New function.
6859         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6860         Rewrite the non-"_1" functions to take vector instead
6861         of linked list.
6862         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6863         "new" _1 versions of the same name.
6864         (multidictionary): Define.
6865         (std::hash<enum language): New definition.
6866         (collate_pending_symbols_by_language, mdict_create_hashed)
6867         (mdict_create_hashed_expandable, mdict_create_linear)
6868         (mdict_create_linear_expandable, mdict_free)
6869         (find_language_dictionary, create_new_language_dictionary)
6870         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6871         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6872         (mdict_size, mdict_empty): New functions.
6873         * dictionary.h (mdict_iterator): Define.
6874
6875 2019-01-10  Pedro Alves  <palves@redhat.com>
6876
6877         * breakpoint.c (read_uploaded_action)
6878         (create_tracepoint_from_upload): Adjust to use
6879         gdb::unique_xmalloc_ptr.
6880         * ctf.c (ctf_write_uploaded_tp):
6881         (SET_ARRAY_FIELD): Use emplace_back.
6882         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6883         * tracefile-tfile.c (tfile_write_uploaded_tp):
6884         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6885         gdb::unique_xmalloc_ptr.
6886         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6887         at_string, cond_string, cmd_strings>: Replace char pointers
6888         with gdb::unique_xmalloc_ptr.
6889
6890 2019-01-10  Pedro Alves  <palves@redhat.com>
6891
6892         * solib-target.c (library_list_start_library): Don't xstrdup name.
6893
6894 2019-01-10  Pedro Alves  <palves@redhat.com>
6895
6896         * mdebugread.c (parse_partial_symbols): Use
6897         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6898
6899 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6900
6901         * linux-fork.c (scoped_switch_fork_info)
6902         <~scoped_switch_fork_info>: Fix incorrect variable name.
6903
6904 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6905
6906         * linux-fork.c (scoped_switch_fork_info)
6907         <scoped_switch_fork_info>: Make explicit.
6908         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6909
6910 2019-01-10  Tom Tromey  <tom@tromey.com>
6911
6912         * objfiles.h (objfile::reset_psymtabs): Update.
6913         * objfiles.c (objfile::objfile): Update.
6914         * psymtab.h (psymtab_storage::obstack): Update.
6915         (psymtab_storage::m_obstack): Use gdb::optional.
6916         (class psymtab_storage): Update comment.  Remove objfile
6917         parameter.
6918         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6919
6920 2019-01-10  Tom Tromey  <tom@tromey.com>
6921
6922         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6923         <free_psymtabs>: Now private.
6924         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6925         (allocate_psymtab): Use new method.
6926
6927 2019-01-10  Tom Tromey  <tom@tromey.com>
6928
6929         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6930         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6931         * mdebugread.c (parse_partial_symbols): Use
6932         allocate_dependencies.
6933         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6934         allocate_dependencies.
6935         (process_psymtab_comp_unit_reader)
6936         (build_type_psymtab_dependencies): Likewise.
6937         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6938
6939 2019-01-10  Tom Tromey  <tom@tromey.com>
6940
6941         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6942         PSYMBOL_SET_LANGUAGE.
6943         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6944
6945 2019-01-10  Tom Tromey  <tom@tromey.com>
6946
6947         * psymtab.h (psymtab_storage::obstack): New method.
6948         <m_obstack>: Rename from obstack; now private.
6949         * psymtab.c (psymtab_storage): Update.
6950         * dwarf2read.c (create_addrmap_from_index)
6951         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6952         Update.
6953
6954 2019-01-10  Tom Tromey  <tom@tromey.com>
6955
6956         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6957         * objfiles.h (objfile::reset_psymtabs): New method.
6958
6959 2019-01-10  Tom Tromey  <tom@tromey.com>
6960
6961         * symmisc.c (print_symbol_bcache_statistics): Update.
6962         (print_objfile_statistics): Update.
6963         * symfile.c (reread_symbols): Update.
6964         * psymtab.h (class psymtab_storage): New.
6965         * psymtab.c (psymtab_storage): New constructor.
6966         (~psymtab_storage): New destructor.
6967         (require_partial_symbols): Update.
6968         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6969         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6970         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6971         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6972         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6973         (start_psymtab_common, end_psymtab_common)
6974         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6975         (allocate_psymtab): Update.
6976         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6977         Update.
6978         (dump_psymtab_addrmap, maintenance_print_psymbols)
6979         (maintenance_check_psymtabs): Update.
6980         (class objfile_psymtabs): Move to objfiles.h.
6981         * psympriv.h (discard_psymtab): Now inline.
6982         (psymtab_discarder::psymtab_discarder): Update.
6983         (psymtab_discarder::~psymtab_discarder): Update.
6984         (ALL_OBJFILE_PSYMTABS): Rewrite.
6985         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6986         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6987         Remove fields.
6988         <partial_symtabs>: New field.
6989         (class objfile_psymtabs): Move from psymtab.h.  Update.
6990         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6991         psymbol_cache.
6992         (objfile::~objfile): Don't destroy psymbol_cache.
6993         * mdebugread.c (parse_partial_symbols): Update.
6994         * dwarf2read.c (create_addrmap_from_index)
6995         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6996         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6997         (add_partial_subprogram, dwarf2_ranges_read): Update.
6998         * dwarf-index-write.c (write_address_map)
6999         (write_one_signatured_type, recursively_write_psymbols)
7000         (class debug_names, class debug_names, write_psymtabs_to_index):
7001         Update.
7002
7003 2019-01-10  Tom Tromey  <tom@tromey.com>
7004
7005         * symtab.h (SYMBOL_SET_NAMES): Update.
7006         (symbol_set_names): Update.
7007         (MSYMBOL_SET_NAMES): Update.
7008         * symtab.c (symbol_set_names): Change argument to be an
7009         objfile_per_bfd_storage.
7010         * psymtab.c (add_psymbol_to_bcache): Update.
7011         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7012
7013 2019-01-10  Tom Tromey  <tom@tromey.com>
7014
7015         * symtab.c (create_demangled_names_hash): Change argument to be an
7016         objfile_per_bfd_storage.
7017         (symbol_set_names): Update.
7018
7019 2019-01-10  Tom Tromey  <tom@tromey.com>
7020
7021         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7022         init_psymbol_list.
7023         * psymtab.c (init_psymbol_list): Do nothing if already called.
7024         * psympriv.h (init_psymbol_list): Add comment.
7025         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7026         init_psymbol_list.
7027         * dbxread.c (dbx_symfile_read): Unconditionally call
7028         init_psymbol_list.
7029
7030 2019-01-10  Tom Tromey  <tom@tromey.com>
7031
7032         * xcoffread.c (scan_xcoff_symtab): Update.
7033         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7034         "where".
7035         * mdebugread.c (parse_partial_symbols)
7036         (handle_psymbol_enumerators): Update.
7037         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7038         * dbxread.c (read_dbx_symtab): Update.
7039         * psympriv.h (psymbol_placement): New enum.
7040         (add_psymbol_to_list): Update.
7041
7042 2019-01-10  Tom Tromey  <tom@tromey.com>
7043
7044         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7045         static_psymbols parameters.
7046         (scan_xcoff_symtab): Update.
7047         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7048         static_psymbols parameters.
7049         * psympriv.h (start_psymtab_common): Update.
7050         * mdebugread.c (parse_partial_symbols): Update.
7051         * dwarf2read.c (create_partial_symtab): Update.
7052         * dbxread.c (read_dbx_symtab): Update.
7053         (start_psymtab): Remove global_psymbols and static_psymbols
7054         parameters.
7055
7056 2019-01-10  Tom Tromey  <tom@tromey.com>
7057
7058         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7059         * psymtab.c (allocate_psymtab): Add comment.
7060         * psympriv.h (allocate_psymtab): Add comment.
7061         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7062         initializations.
7063         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7064
7065 2019-01-10  Tom Tromey  <tom@tromey.com>
7066
7067         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7068         Don't declare.
7069         * mipsread.c: Include mdebugread.h.
7070         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7071         Declare.
7072         * elfread.c: Include mdebugread.h.
7073
7074 2019-01-09  Tom Tromey  <tom@tromey.com>
7075
7076         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7077         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7078         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7079         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7080         (psym_lookup_symbol, psym_find_last_source_symtab)
7081         (psym_forget_cached_source_info, psym_print_stats)
7082         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7083         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7084         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7085         (psym_find_compunit_symtab_by_address)
7086         (maintenance_print_psymbols, maintenance_info_psymtabs)
7087         (maintenance_check_psymtabs): Use ranged for.
7088         * psymtab.h (class objfile_psymtabs): New.
7089         (require_partial_symbols): Return objfile_psymtabs.
7090         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7091
7092 2019-01-09  Tom Tromey  <tom@tromey.com>
7093
7094         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7095         (find_pc_mapped_section, list_overlays_command)
7096         (map_overlay_command, unmap_overlay_command)
7097         (simple_overlay_update): Use all_objfiles.
7098         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7099         * printcmd.c (info_symbol_command): Use all_objfiles.
7100         * objfiles.h (ALL_OBJSECTIONS): Remove.
7101         * maint.c (maintenance_translate_address): Use all_objfiles.
7102         * gcore.c (gcore_create_callback): Use all_objfiles.
7103         (objfile_find_memory_regions): Likewise.
7104
7105 2019-01-09  Tom Tromey  <tom@tromey.com>
7106
7107         * symtab.c (find_line_symtab, info_sources_command)
7108         (make_source_files_completion_list): Use objfile_compunits.
7109         * source.c (select_source_symtab): Use objfile_compunits.
7110         * objfiles.h (struct objfile): Update comment.
7111         (ALL_OBJFILES): Remove.
7112         (ALL_FILETABS): Remove.
7113         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7114         objfile_compunits.
7115
7116 2019-01-09  Tom Tromey  <tom@tromey.com>
7117
7118         * symmisc.c (print_objfile_statistics, dump_objfile)
7119         (maintenance_print_symbols): Use compunit_filetabs.
7120         * source.c (forget_cached_source_info_for_objfile): Use
7121         compunit_filetabs.
7122         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7123         (ALL_FILETABS): Use compunit_filetabs.
7124         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7125         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7126
7127 2019-01-09  Tom Tromey  <tom@tromey.com>
7128
7129         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7130         (compunit_filetabs): New.
7131         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7132         compunit_filetabs.
7133         (info_sources_command, make_source_files_completion_list): Remove
7134         declaration.
7135         * symmisc.c (print_objfile_statistics, dump_objfile)
7136         (maintenance_print_symbols): Remove declaration.
7137         (maintenance_info_symtabs): Use compunit_filetabs.
7138         (maintenance_info_line_tables): Likewise.
7139         * source.c (select_source_symtab): Change local variable name.
7140         (forget_cached_source_info_for_objfile): Remove declaration.
7141         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7142         * objfiles.c (objfile_relocate1): Remove declaration.
7143         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7144         declaration.
7145         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7146         * coffread.c (coff_symtab_read): Remove declaration.
7147         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7148         compunit_filetabs.
7149
7150 2019-01-09  Tom Tromey  <tom@tromey.com>
7151
7152         * symtab.c (lookup_objfile_from_block)
7153         (find_pc_sect_compunit_symtab, search_symbols)
7154         (default_collect_symbol_completion_matches_break_on): Use
7155         objfile_compunits.
7156         * objfiles.h (ALL_COMPUNITS): Remove.
7157         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7158         * cp-support.c (add_symbol_overload_list_qualified): Use
7159         objfile_compunits.
7160         * ada-lang.c (ada_collect_symbol_completion_matches)
7161         (ada_add_global_exceptions): Use objfile_compunits.
7162
7163 2019-01-09  Tom Tromey  <tom@tromey.com>
7164
7165         * source.c (select_source_symtab)
7166         (forget_cached_source_info_for_objfile): Remove declaration.
7167         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7168         declaration.
7169         * maint.c (count_symtabs_and_blocks): Remove declaration.
7170         * cp-support.c (add_symbol_overload_list_qualified): Remove
7171         declaration.
7172         * coffread.c (coff_symtab_read): Remove declaration.
7173         * symtab.c (lookup_symbol_in_objfile_symtabs)
7174         (basic_lookup_transparent_type_1): Use objfile_compunits.
7175         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7176         (info_sources_command, search_symbols)
7177         (default_collect_symbol_completion_matches_break_on)
7178         (make_source_files_completion_list): Remove declaration.
7179         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7180         (ada_collect_symbol_completion_matches)
7181         (ada_add_global_exceptions): Remove declaration.
7182         * linespec.c (iterate_over_all_matching_symtabs): Use
7183         objfile_compunits.
7184         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7185         (class objfile_compunits): New.
7186         (ALL_COMPUNITS): Use objfile_compunits.
7187         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7188         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7189         objfile_compunits.
7190         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7191
7192 2019-01-09  Tom Tromey  <tom@tromey.com>
7193
7194         * symtab.c (search_symbols)
7195         (default_collect_symbol_completion_matches_break_on): Use
7196         objfile_msymbols.
7197         * ada-lang.c (ada_lookup_simple_minsym)
7198         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7199         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7200         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7201         objfile_msymbols.
7202         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7203         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7204         * objc-lang.c (find_methods): Use objfile_msymbols.
7205         (info_selectors_command, info_classes_command): Likewise.
7206         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7207         * objfiles.h (class objfile_msymbols): New.
7208         (ALL_OBJFILE_MSYMBOLS): Remove.
7209         (ALL_MSYMBOLS): Remove.
7210
7211 2019-01-09  Tom Tromey  <tom@tromey.com>
7212
7213         * common/next-iterator.h (next_adapter): Add Iterator template
7214         parameter.
7215         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7216         (class all_objfiles_safe): New.
7217         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7218         * objfiles.c (put_objfile_before): Update comment.
7219         (add_separate_debug_objfile): Likewise.
7220         (free_all_objfiles): Use all_objfiles_safe.
7221         (objfile_purge_solibs): Likewise.
7222
7223 2019-01-09  Tom Tromey  <tom@tromey.com>
7224
7225         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7226         (expand_symtab_containing_pc, lookup_static_symbol)
7227         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7228         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7229         all_objfiles.
7230         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7231         * breakpoint.c (create_overlay_event_breakpoint)
7232         (create_longjmp_master_breakpoint)
7233         (create_std_terminate_master_breakpoint)
7234         (create_exception_master_breakpoint): Use all_objfiles.
7235         * linux-thread-db.c (try_thread_db_load_from_pdir)
7236         (has_libpthread): Use all_objfiles.
7237         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7238         * linespec.c (iterate_over_all_matching_symtabs)
7239         (search_minsyms_for_name): Use all_objfiles.
7240         * maint.c (maintenance_info_sections): Use all_objfiles.
7241         * main.c (captured_main_1): Use all_objfiles.
7242         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7243         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7244         * guile/scm-pretty-print.c
7245         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7246         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7247         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7248         (maintenance_print_msymbols): Use all_objfiles.
7249         * source.c (select_source_symtab): Use all_objfiles.
7250         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7251         * symfile.c (remove_symbol_file_command)
7252         (expand_symtabs_matching, map_symbol_filenames): Use
7253         all_objfiles.
7254         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7255         all_objfiles.
7256         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7257         * objc-lang.c (find_methods): Use all_objfiles.
7258         * objfiles.c (have_partial_symbols, have_full_symbols)
7259         (have_minimal_symbols, qsort_cmp)
7260         (default_iterate_over_objfiles_in_search_order): Use
7261         all_objfiles.
7262         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7263         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7264         (maintenance_check_psymtabs): Use all_objfiles.
7265         (ALL_PSYMTABS): Remove.
7266         * compile/compile-object-run.c (do_module_cleanup): Use
7267         all_objfiles.
7268         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7269         * cp-support.c (add_symbol_overload_list_qualified): Use
7270         all_objfiles.
7271         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7272         Use all_objfiles.
7273         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7274         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7275         all_objfiles.
7276         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7277         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7278         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7279         Uses all_objfiles.
7280         * solib.c (solib_read_symbols): Use all_objfiles
7281
7282 2019-01-09  Tom Tromey  <tom@tromey.com>
7283
7284         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7285         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7286         all_objfiles.
7287         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7288         * symmisc.c (print_symbol_bcache_statistics)
7289         (print_objfile_statistics, maintenance_print_objfiles)
7290         (maintenance_info_symtabs, maintenance_check_symtabs)
7291         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7292         all_objfiles.
7293         * source.c (forget_cached_source_info): Use all_objfiles.
7294         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7295         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7296         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7297         * objfiles.c (update_section_map): Use all_objfiles.
7298         (shared_objfile_contains_address_p): Likewise.
7299         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7300         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7301
7302 2019-01-09  Tom Tromey  <tom@tromey.com>
7303
7304         * common/next-iterator.h: New file.
7305         * objfiles.h (class all_objfiles): New.
7306         (struct objfile_iterator): New.
7307
7308 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7309
7310         * NEWS: Move the description of the changed "frame", "select-frame",
7311          and "info frame" commands to the Changed commands section.
7312
7313 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7314
7315         * gdbtypes.c (check_stub_method_group): Remove handling of old
7316         mangling schemes.
7317         * linespec.c (find_methods): Likewise.
7318         * stabsread.c (read_member_functions): Likewise.
7319         * valops.c (search_struct_method): Likewise.
7320         (value_struct_elt_for_reference): Likewise.
7321         * NEWS: Mention this change.
7322
7323 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7324
7325         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7326         print_source_lines.
7327         * source.c (print_source_lines_base): Update line number check.
7328         (print_source_lines): New function.
7329         (source_lines_range::source_lines_range): New function.
7330         * source.h (class source_lines_range): New class.
7331         (print_source_lines): New declaration.
7332
7333 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7334
7335         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7336
7337 2019-01-08  Tom Tromey  <tom@tromey.com>
7338             Simon Marchi  <simon.marchi@ericsson.com>
7339
7340         PR gdb/24060
7341         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7342         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7343         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7344         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7345         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7346         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7347
7348 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7349
7350         * source.c (select_source_symtab): Move header comment to
7351         declaration in source.h.
7352         (forget_cached_source_info_for_objfile): Likewise.
7353         (forget_cached_source_info): Likewise.
7354         (identify_source_line): Likewise.
7355         * source.h (identify_source_line): Move declaration from symtab.h
7356         and add comment from source.c
7357         (print_source_lines): Likewise.
7358         (forget_cached_source_info_for_objfile): Likewise.
7359         (forget_cached_source_info): Likewise.
7360         (select_source_symtab): Likewise.
7361         (enum print_source_lines_flag): Move definition from symtab.h.
7362         * symtab.h (identify_source_line): Move declaration to source.h.
7363         (print_source_lines): Likewise.
7364         (forget_cached_source_info_for_objfile): Likewise.
7365         (forget_cached_source_info): Likewise.
7366         (select_source_symtab): Likewise.
7367         (enum print_source_lines_flag): Move definition to source.h.
7368         * tui/tui-hooks.c: Add 'source.h' include.
7369
7370 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7371
7372         * source.c (print_source_lines_base): Handle requests to print
7373         reverse line number sequences, and guard against empty lines
7374         string.
7375
7376 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7377
7378         * source.c (print_source_lines_base): Fix skip of '\r' if next
7379         character is '\n'.
7380
7381 2019-01-06  Tom Tromey  <tom@tromey.com>
7382
7383         * c-exp.y (struct c_parse_state) <macro_original_text,
7384         expansion_obstack>: New member.
7385         (macro_original_text, expansion_obstack): Remove globals.
7386         (scan_macro_expansion, scanning_macro_expansion)
7387         (finished_macro_expansion): Update.
7388         (scan_macro_cleanup): Remove.
7389         (yylex, c_parse): Update.
7390
7391 2019-01-06  Tom Tromey  <tom@tromey.com>
7392
7393         * c-exp.y (struct c_parse_state) <strings>: New member.
7394         (operator_stoken): Update.
7395
7396 2019-01-06  Tom Tromey  <tom@tromey.com>
7397
7398         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7399         (union type_stack_elt) <typelist_val>: Now a pointer to
7400         std::vector.
7401         (type_stack_cleanup): Don't declare.
7402         (push_typelist): Update.
7403         * parse.c (pop_typelist): Return a std::vector.
7404         (push_typelist): Take a std::vector.
7405         (follow_types): Update.  Do not free args.
7406         (type_stack_cleanup): Remove.
7407         * c-exp.y (struct c_parse_state): New.
7408         (cpstate): New global.
7409         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7410         (nonempty_typelist): Update.
7411         (func_mod): Create a new vector.
7412         (c_parse): Create a c_parse_state.
7413         (check_parameter_typelist): Do not delete params.
7414         (function_method): Update.  Do not delete type_list.
7415
7416 2019-01-06  Tom Tromey  <tom@tromey.com>
7417
7418         PR gdb/28155:
7419         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7420         check_typedef.
7421         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7422         (print_return_value): Likewise.
7423
7424 2019-01-05  Tom Tromey  <tom@tromey.com>
7425
7426         * contrib/cleanup_check.py: Remove.
7427         * contrib/gcc-with-excheck: Remove.
7428         * contrib/exsummary.py: Remove.
7429         * contrib/excheck.py: Remove.
7430
7431 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7432
7433         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7434         NULL. Initialize tpprev to NULL instead of assigning it
7435         to NULL on the next statement.
7436         * windows-nat.c (windows_delete_thread): Remove check for
7437         main_thread_id before printing thread exit notifications.
7438         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7439         Remove thread ID check against main_thread_id.
7440         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7441         windows_delete_thread.
7442         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7443
7444 2019-01-04  Tom Tromey  <tom@tromey.com>
7445
7446         * compile/compile.c (_initialize_compile): Use upper case for
7447         metasyntactic variables.
7448         * symmisc.c (_initialize_symmisc): Use upper case for
7449         metasyntactic variables.
7450         * psymtab.c (_initialize_psymtab): Use upper case for
7451         metasyntactic variables.
7452         * demangle.c (demangle_command): Use upper case for metasyntactic
7453         variables.
7454         (_initialize_demangler): Likewise.
7455         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7456         variables.
7457
7458 2019-01-03  Tom Tromey  <tom@tromey.com>
7459
7460         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7461
7462 2019-01-03  Tom Tromey  <tom@tromey.com>
7463
7464         * python/py-symtab.c (salpy_str): Update.
7465         (struct salpy_sal_object) <symtab>: Now a PyObject.
7466         (salpy_dealloc): Update.
7467         (del_objfile_sal): Use gdbpy_ref.
7468
7469 2019-01-03  Tom Tromey  <tom@tromey.com>
7470
7471         * python/py-type.c (convert_field): Use new_reference.  Return
7472         gdbpy_ref.
7473         (make_fielditem): Return gdbpy_ref.
7474         (typy_fields): Update.
7475         (typy_getitem): Update.
7476         (field_name): Return gdbpy_ref.  Use new_reference.
7477         (typy_iterator_iternext): Update.
7478
7479 2019-01-03  Tom Tromey  <tom@tromey.com>
7480
7481         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7482
7483 2019-01-03  Tom Tromey  <tom@tromey.com>
7484
7485         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7486         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7487         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7488         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7489         (pspy_set_type_printers): Likewise.
7490         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7491         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7492         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7493         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7494         (objfpy_set_type_printers): Likewise.
7495
7496 2019-01-03  Tom Tromey  <tom@tromey.com>
7497
7498         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7499         (gdbpy_print_stack): Use gdbpy_err_fetch.
7500         * python/python-internal.h (class gdbpy_err_fetch): New class.
7501         (class gdbpy_enter) <m_error_type, m_error_value,
7502         m_error_traceback>: Remove.
7503         <m_error>: New member.
7504         (gdbpy_exception_to_string): Don't declare.
7505         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7506         * python/py-value.c (convert_value_from_python): Use
7507         gdbpy_err_fetch.
7508         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7509         gdbpy_exception_to_string.
7510         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7511         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7512         gdbpy_err_fetch.
7513
7514 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7515
7516         * linux-nat.c (delete_lwp_cleanup): Delete.
7517         (struct lwp_deleter): New struct.
7518         (lwp_info_up): New typedef.
7519         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7520         lwp_info_up.
7521
7522 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * linux-fork.c (class scoped_switch_fork_info): New class.
7525         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7526
7527 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7528
7529         * valops.c (find_overload_match): Remove use of null_cleanup, and
7530         calls to do_cleanups.
7531
7532 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7533
7534         * compile/compile-cplus-types.c
7535         (compile_cplus_instance::decl_name): Handle changes to
7536         cp_func_name.
7537         * cp-support.c (cp_func_name): Update header comment, update
7538         return type.
7539         * cp-support.h (cp_func_name): Update return type in declaration.
7540         * valops.c (find_overload_match): Move temp_func local to top
7541         level of function and change its type.  Use temp_func to hold and
7542         delete temporary string obtained from cp_func_name.
7543
7544 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7545
7546         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7547         gdb::char_vector, remove cleanup, and update uses of `msg`.
7548
7549 2019-01-03  Jim Wilson  <jimw@sifive.com>
7550
7551         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7552
7553 2019-01-02  Tom Tromey  <tom@tromey.com>
7554
7555         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7556         (tdesc_parse_xml): Remove cleanups.
7557         * target-descriptions.h (make_cleanup_free_target_description):
7558         Don't declare.
7559         (target_desc_deleter): New struct.
7560         (target_desc_up): New typedef.
7561         * target-descriptions.c (target_desc_deleter::operator()): Rename
7562         from free_target_description.
7563         (make_cleanup_free_target_description): Remove.
7564
7565 2019-01-02  Tom Tromey  <tom@tromey.com>
7566
7567         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7568         constructor, destructor.
7569         (linespec_parser): Remove typedef.
7570         (~linespec_parser): Rename from linespec_parser_delete.
7571         (linespec_lex_to_end, linespec_complete_label)
7572         (linespec_complete): Update.
7573         (decode_line_full): Remove cleanups.
7574         (decode_line_1): Update.
7575
7576 2019-01-02  Tom Tromey  <tom@tromey.com>
7577
7578         * python/python-internal.h (inferior_to_inferior_object): Change
7579         return type.
7580         * python/py-exitedevent.c (create_exited_event_object): Update.
7581         * python/py-inferior.c (inferior_to_inferior_object): Return
7582         gdbpy_ref.
7583         (python_new_inferior, python_inferior_deleted)
7584         (thread_to_thread_object, delete_thread_object)
7585         (build_inferior_list, gdbpy_selected_inferior): Update.
7586         * python/py-infthread.c (create_thread_object): Update.  Also fail
7587         if inferior_to_inferior_object fails.
7588
7589 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7590
7591         * inferior.h (class inferior) <displaced_step_state>: New field.
7592         * infrun.h (struct displaced_step_state): Move here from
7593         infrun.c.  Initialize fields, add constructor.
7594         <inf>: Remove field.
7595         <reset>: New method.
7596         * infrun.c (struct displaced_step_inferior_state): Move to
7597         infrun.h.
7598         (displaced_step_inferior_states): Remove.
7599         (get_displaced_stepping_state): Adust.
7600         (displaced_step_in_progress_any_inferior): Adjust.
7601         (displaced_step_in_progress_thread): Adjust.
7602         (displaced_step_in_progress): Adjust.
7603         (add_displaced_stepping_state): Remove.
7604         (get_displaced_step_closure_by_addr): Adjust.
7605         (remove_displaced_stepping_state): Remove.
7606         (infrun_inferior_exit): Call displaced_step_state.reset.
7607         (use_displaced_stepping): Don't check for NULL.
7608         (displaced_step_prepare_throw): Call
7609         get_displaced_stepping_state.
7610         (displaced_step_fixup): Don't check for NULL.
7611         (prepare_for_detach): Don't check for NULL.
7612
7613 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7614
7615         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7616          in case of call that did not complete.
7617
7618 2019-01-02  Andrey Utkin  <autkin@undo.io>
7619
7620         * symfile.c (find_separate_debug_file): Fix search of debug files for
7621         remote debuggee.
7622
7623 2019-01-02  Tom Tromey  <tom@tromey.com>
7624
7625         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7626         indentation.
7627         * python/py-frame.c (frapy_older): Remove cast.
7628         (frapy_newer): Likewise.
7629         * python/py-breakpoint.c (local_setattro): Remove cast.
7630         * python/py-arch.c (archpy_name): Remove local variable.
7631         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7632
7633 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7634
7635         * unittests/basic_string_view/element_access/char/empty.cc:
7636         Fix year range in copyright header.
7637
7638 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7639
7640         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7641         Delete.
7642         <operator==>: Update with for removed field.
7643         <hash>: Likewise.
7644         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7645         <isa_features>: ...this.
7646         <abi_features>: New field.
7647         (riscv_isa_flen): Update comment.
7648         (riscv_abi_xlen): New declaration.
7649         (riscv_abi_flen): New declaration.
7650         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7651         isa_features.
7652         (riscv_abi_xlen): New function.
7653         (riscv_isa_flen): Update to get answer from isa_features.
7654         (riscv_abi_flen): New function.
7655         (riscv_has_fp_abi): Update to get answer from abi_features.
7656         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7657         xlen and flen.
7658         (riscv_call_info) <xlen, flen>: Update comment.
7659         (riscv_call_arg_struct): Remove invalid assertions
7660         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7661         is removed.
7662         (riscv_gdbarch_init): Gather isa features and abi features
7663         separately, ensure both match on the gdbarch when reusing an old
7664         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7665         a target with 64-bit float hardware.
7666
7667 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7668
7669         * source.c (search_command_helper): Stop reverse search
7670         when line 1 has been searched.
7671
7672 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7673
7674         * record-full.c (record_full_base_target::close): Rewrite
7675         record_full_core_buf_list free logic.
7676
7677 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7678
7679         * break-catch-syscall.c (print_one_catch_syscall): xfree
7680         the last text.
7681
7682 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7683
7684         * top.c (print_gdb_version): Update Copyright year in version
7685         message.
7686
7687 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7688
7689         Update copyright year range in all GDB files.
7690
7691 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7692
7693         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7694
7695 For older changes see ChangeLog-2018.
7696 \f
7697 Local Variables:
7698 mode: change-log
7699 left-margin: 8
7700 fill-column: 74
7701 version-control: never
7702 coding: utf-8
7703 End:
7704