gdb/ChangeLog

   1 2020-06-18  Pedro Alves  <palves@redhat.com>
   2
   3         * tracefile-tfile.c (tfile_target_open): Don't write to
   4         inferior_ptid directly, instead switch to added thread.
   5         (tfile_target::close): Use switch_to_no_thread instead of writing
   6         to inferior_ptid directly.
   7
   8 2020-06-18  Pedro Alves  <palves@redhat.com>
   9
  10         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
  11         (procfs_target::detach): Use switch_to_no_thread
  12         instead of writing to inferior_ptid directly.
  13         (do_attach): Change return type to void.  Switch to the added
  14         thread.
  15         (procfs_target::create_inferior): Switch to the added thread.
  16         (procfs_do_thread_registers): Don't write to inferior_ptid.
  17
  18 2020-06-18  Pedro Alves  <palves@redhat.com>
  19
  20         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
  21         of writing to inferior_ptid.
  22         (scoped_restore_exited_inferior): Delete.
  23         (handle_vfork_child_exec_or_exit): Simplify using
  24         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
  25         instead of writing to inferior_ptid.
  26         (THREAD_STOPPED_BY): Delete.
  27         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
  28         (thread_stopped_by_hw_breakpoint): Delete.
  29         (save_waitstatus): Use
  30         scoped_restore_current_thread+switch_to_thread, and call
  31         target_stopped_by_watchpoint instead of
  32         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
  33         instead of thread_stopped_by_sw_breakpoint, and
  34         target_stopped_by_hw_breakpoint instead of
  35         thread_stopped_by_hw_breakpoint.
  36         (handle_inferior_event)
  37         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
  38         inferior_ptid directly, nor
  39         set_current_inferior/set_current_program_space.  Use
  40         switch_to_thread / switch_to_inferior_no_thread instead.
  41
  42 2020-06-18  Pedro Alves  <palves@redhat.com>
  43
  44         * target.c (generic_mourn_inferior): Use switch_to_no_thread
  45         instead of writing to inferior_ptid.
  46
  47 2020-06-18  Pedro Alves  <palves@redhat.com>
  48
  49         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
  50         added thread.
  51         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
  52         to the added thread.
  53         (inf_ptrace_target::detach_success): Use switch_to_no_thread
  54         instead of writing to inferior_ptid.
  55
  56 2020-06-18  Pedro Alves  <palves@redhat.com>
  57
  58         * gdbarch-selftests.c: Include "progspace-and-thread.h".
  59         (register_to_value_test): Mock a program_space too.  Heap-allocate
  60         the address space.  Don't write to inferior_ptid.  Use
  61         switch_to_thread instead.
  62
  63 2020-06-18  Pedro Alves  <palves@redhat.com>
  64
  65         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
  66         Delete.
  67         (find_signalled_thread()): New, factored out from
  68         linux_make_corefile_notes and adjusted to handle exited threads.
  69         (linux_make_corefile_notes): Adjust to use the new
  70         find_signalled_thread.
  71
  72 2020-06-18  Pedro Alves  <palves@redhat.com>
  73
  74         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
  75         of saving/restoring inferior_ptid.
  76
  77 2020-06-17  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
  80         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
  81         declare.
  82         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
  83
  84 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
  85
  86         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
  87         of partial symtabs.
  88
  89 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
  90
  91         * regformats/reg-arm.dat: Remove.
  92         * regformats/reg-bfin.dat: Remove.
  93         * regformats/reg-cris.dat: Remove.
  94         * regformats/reg-crisv32.dat: Remove.
  95         * regformats/reg-m32r.dat: Remove.
  96         * regformats/reg-tilegx.dat: Remove.
  97         * regformats/reg-tilegx32.dat: Remove.
  98
  99 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 100
 101         * features/Makefile (WHICH): Remove arm files.
 102         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 103         * regformats/arm/arm-with-neon.dat: Remove.
 104         * regformats/arm/arm-with-vfpv2.dat: Remove.
 105         * regformats/arm/arm-with-vfpv3.dat: Remove.
 106
 107 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 108
 109         * features/Makefile (XMLTOC): Remove rx.xml.
 110
 111 2020-06-17  Pedro Alves  <palves@redhat.com>
 112
 113         * gdbthread.h (thread_control_state) <trap_expected> Update
 114         comments.
 115
 116 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
 119         ada_language::lookup_symbol_nonlocal.
 120         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
 121         (ada_language::lookup_symbol_nonlocal): New member function,
 122         implementation from ada_lookup_symbol_nonlocal.
 123         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
 124         initializer.
 125         (cplus_language_data): Delete la_lookup_symbol_nonlocal
 126         initializer.
 127         (cplus_language::lookup_symbol_nonlocal): New member function.
 128         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
 129         (minimal_language_data) Likewise.
 130         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
 131         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
 132         initializer.
 133         (d_language::lookup_symbol_nonlocal): New member function.
 134         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
 135         initializer.
 136         (f_language::lookup_symbol_nonlocal): New member function.
 137         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
 138         initializer.
 139         * language.c (unknown_language_data): Likewise.
 140         (auto_language_data): Likewise.
 141         * language.h (language_data): Delete la_lookup_symbol_nonlocal
 142         field.
 143         (language_defn::lookup_symbol_nonlocal): New member function.
 144         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
 145         initializer.
 146         * objc-lang.c (objc_language_data): Likewise.
 147         * opencl-lang.c (opencl_language_data): Likewise.
 148         * p-lang.c (pascal_language_data): Likewise.
 149         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
 150         rust_language::lookup_symbol_nonlocal.
 151         (rust_language_data): Delete la_lookup_symbol_nonlocal
 152         initializer.
 153         (rust_language::lookup_symbol_nonlocal): New member function,
 154         implementation from rust_lookup_symbol_nonlocal.
 155         * symtab.c (lookup_symbol_aux): Update call to
 156         lookup_symbol_nonlocal.
 157         (basic_lookup_symbol_nonlocal): Rename to...
 158         (language_defn::lookup_symbol_nonlocal): ...this, and update
 159         header comment.  Remove language_defn parameter, and replace with
 160         uses of `this'.
 161         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
 162
 163 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 164
 165         * ada-lang.c (ada_language_data): Delete la_value_print_inner
 166         initializer.
 167         (ada_language::value_print_inner): New member function.
 168         * c-lang.c (c_language_data): Delete la_value_print_inner
 169         initializer.
 170         (cplus_language_data): Likewise.
 171         (asm_language_data): Likewise.
 172         (minimal_language_data): Likewise.
 173         * d-lang.c (d_language_data): Likewise.
 174         (d_language::value_print_inner): New member function.
 175         * f-lang.c (f_language_data): Delete la_value_print_inner
 176         initializer.
 177         (f_language::value_print_inner): New member function.
 178         * f-lang.h (f_value_print_innner): Rename to...
 179         (f_value_print_inner): ...this (note spelling of 'inner').
 180         * f-valprint.c (f_value_print_innner): Rename to...
 181         (f_value_print_inner): ...this (note spelling of 'inner').
 182         * go-lang.c (go_language_data): Delete la_value_print_inner
 183         initializer.
 184         (go_language::value_print_inner): New member function.
 185         * language.c (language_defn::value_print_inner): Define new member
 186         function.
 187         (unk_lang_value_print_inner): Delete.
 188         (unknown_language_data): Delete la_value_print_inner initializer.
 189         (unknown_language::value_print_inner): New member function.
 190         (auto_language_data): Delete la_value_print_inner initializer.
 191         (auto_language::value_print_inner): New member function.
 192         * language.h (language_data): Delete la_value_print_inner field.
 193         (language_defn::value_print_inner): Delcare new member function.
 194         * m2-lang.c (m2_language_data): Delete la_value_print_inner
 195         initializer.
 196         (m2_language::value_print_inner): New member function.
 197         * objc-lang.c (objc_language_data): Delete la_value_print_inner
 198         initializer.
 199         * opencl-lang.c (opencl_language_data): Likewise.
 200         * p-lang.c (pascal_language_data): Likewise.
 201         (pascal_language::value_print_inner): New member function.
 202         * rust-lang.c (rust_language_data): Delete la_value_print_inner
 203         initializer.
 204         (rust_language::value_print_inner): New member function.
 205         * valprint.c (do_val_print): Update call to value_print_inner.
 206
 207 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * ada-lang.c (ada_language_data): Delete la_value_print
 210         initializer.
 211         (ada_language::value_print): New member function.
 212         * c-lang.c (c_language_data): Delete la_value_print initializer.
 213         (cplus_language_data): Likewise.
 214         (asm_language_data): Likewise.
 215         (minimal_language_data): Likewise.
 216         * d-lang.c (d_language_data): Likewise.
 217         * f-lang.c (f_language_data): Likewise.
 218         * go-lang.c (go_language_data): Likewise.
 219         * language.c (unk_lang_value_print): Delete.
 220         (language_defn::value_print): Define new member function.
 221         (unknown_language_data): Delete la_value_print initializer.
 222         (unknown_language::value_print): New member function.
 223         (auto_language_data): Delete la_value_print initializer.
 224         (auto_language::value_print): New member function.
 225         * language.h (language_data): Delete la_value_print field.
 226         (language_defn::value_print): Declare new member function.
 227         (LA_VALUE_PRINT): Update call to value_print.
 228         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
 229         * objc-lang.c (objc_language_data): Likewise.
 230         * opencl-lang.c (opencl_language_data): Likewise.
 231         * p-lang.c (pascal_language_data): Likewise.
 232         (pascal_language::value_print): New member function.
 233         * rust-lang.c (rust_language_data): Delete la_value_print
 234         initializer.
 235
 236 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 237
 238         * ada-lang.c (ada_watch_location_expression): Rename to
 239         ada_language::watch_location_expression.
 240         (ada_language_data): Delete la_watch_location_expression
 241         initializer.
 242         (ada_language::watch_location_expression): New member function,
 243         implementation from ada_watch_location_expression.
 244         * breakpoint.c (watch_command_1): Update call to
 245         watch_location_expression.
 246         * c-lang.c (c_watch_location_expression): Rename to
 247         language_defn::watch_location_expression.
 248         (c_language_data): Delete la_watch_location_expression
 249         initializer.
 250         (cplus_language_data): Likewise.
 251         (asm_language_data): Likewise.
 252         (minimal_language_data): Likewise.
 253         * c-lang.h (c_watch_location_expression): Delete declaration.
 254         * d-lang.c (d_language_data): Delete la_watch_location_expression
 255         initializer.
 256         * f-lang.c (f_language_data): Likewise.
 257         * go-lang.c (go_language_data): Likewise.
 258         * language.c (language_defn::watch_location_expression): Member
 259         function implementation from c_watch_location_expression.
 260         (unknown_language_data): Delete la_watch_location_expression
 261         initializer.
 262         (auto_language_data): Likewise.
 263         * language.h (language_data): Delete la_watch_location_expression
 264         field.
 265         (language_defn::watch_location_expression): Declare new member
 266         function.
 267         * m2-lang.c (m2_language_data): Delete
 268         la_watch_location_expression initializer.
 269         * objc-lang.c (objc_language_data): Likewise.
 270         * opencl-lang.c (opencl_language_data): Likewise.
 271         * p-lang.c (pascal_language_data): Likewise.
 272         * rust-lang.c (rust_watch_location_expression): Rename to
 273         rust_language::watch_location_expression.
 274         (rust_language_data): Delete la_watch_location_expression
 275         initializer.
 276         (rust_language::watch_location_expression): New member function,
 277         implementation from rust_watch_location_expression.
 278
 279 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 280
 281         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
 282         ada_language::collect_symbol_completion_matches.
 283         (ada_language_data): Delete la_collect_symbol_completion_matches
 284         initializer.
 285         (ada_language::collect_symbol_completion_matches): New member
 286         function, implementation from
 287         ada_collect_symbol_completion_matches.
 288         * c-lang.c (c_language_data): Delete
 289         la_collect_symbol_completion_matches initializer.
 290         (cplus_language_data): Likewise.
 291         (asm_language_data): Likewise.
 292         (minimal_language_data): Likewise.
 293         * d-lang.c (d_language_data): Likewise.
 294         * f-lang.c (f_collect_symbol_completion_matches): Rename to
 295         f_language::collect_symbol_completion_matches.
 296         (f_language_data): Delete la_collect_symbol_completion_matches
 297         initializer.
 298         (f_language::collect_symbol_completion_matches) New member
 299         function, implementation from f_collect_symbol_completion_matches.
 300         * go-lang.c (go_language_data): Delete
 301         la_collect_symbol_completion_matches initializer.
 302         * language.c (unknown_language_data): Likewise.
 303         (auto_language_data): Likewise.
 304         * language.h (language_data): Delete
 305         la_collect_symbol_completion_matches field.
 306         (language_defn::collect_symbol_completion_matches): New member
 307         function.
 308         * m2-lang.c (m2_language_data): Delete
 309         la_collect_symbol_completion_matches initializer.
 310         * objc-lang.c (objc_language_data): Likewise.
 311         * opencl-lang.c (opencl_language_data): Likewise.
 312         * p-lang.c (pascal_language_data): Likewise.
 313         * rust-lang.c (rust_language_data): Likewise.
 314         * symtab.c (default_collect_symbol_completion_matches): Delete.
 315         (collect_symbol_completion_matches): Update call to
 316         collect_symbol_completion_matches.
 317         (collect_symbol_completion_matches_type): Likewise.
 318         * symtab.h (default_collect_symbol_completion_matches): Delete
 319         declaration.
 320
 321 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 322
 323         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
 324         (ada_language_data): Delete la_word_break_characters initializer.
 325         (ada_language::word_break_characters): New member function.
 326         * c-lang.c (c_language_data): Delete la_word_break_characters
 327         initializer.
 328         (cplus_language_data): Likewise.
 329         (asm_language_data): Likewise.
 330         (minimal_language_data): Likewise.
 331         * completer.c: Update global comment.
 332         (advance_to_expression_complete_word_point): Update call to
 333         word_break_characters.
 334         (complete_files_symbols): Likewise.
 335         (complete_line_internal_1): Likewise.
 336         (default_completer_handle_brkchars): Likewise.
 337         (skip_quoted_chars): Likewise.
 338         * d-lang.c (d_language_data): Delete la_word_break_characters
 339         initializer.
 340         * f-lang.c (f_word_break_characters): Delete.
 341         (f_language_data): Delete la_word_break_characters initializer.
 342         (f_language::word_break_characters): New member function.
 343         * go-lang.c (go_language_data): Delete la_word_break_characters
 344         initializer.
 345         * language.c (unknown_language_data): Likewise.
 346         (auto_language_data): Likewise.
 347         * language.h (default_word_break_characters): Move declaration to
 348         earlier in the file.
 349         (language_data): Delete la_word_break_characters field.
 350         (language_defn::word_break_characters): New member function.
 351         * m2-lang.c (m2_language_data): Delete la_word_break_characters
 352         initializer.
 353         * objc-lang.c (objc_language_data): Likewise.
 354         * opencl-lang.c (opencl_language_data): Likewise.
 355         * p-lang.c (pascal_language_data): Likewise.
 356         * rust-lang.c (rust_language_data): Likewise.
 357
 358 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 359
 360         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
 361         (ada_language_data): Delete la_get_symbol_name_matcher
 362         initializer.
 363         (language_defn::get_symbol_name_matcher_inner): New member
 364         function.
 365         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
 366         initializer.
 367         (cplus_language_data): Likewise.
 368         (cplus_language::get_symbol_name_matcher_inner): New member
 369         function.
 370         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
 371         (minimal_language_data): Likewise.
 372         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
 373         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
 374         initializer.
 375         * dictionary.c (iter_match_first_hashed): Update call to
 376         get_symbol_name_matcher.
 377         (iter_match_next_hashed): Likewise.
 378         (iter_match_next_linear): Likewise.
 379         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
 380         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
 381         initializer.
 382         (f_language::get_symbol_name_matcher_inner): New member function.
 383         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
 384         initializer.
 385         * language.c (default_symbol_name_matcher): Update header comment,
 386         make static.
 387         (language_defn::get_symbol_name_matcher): New definition.
 388         (language_defn::get_symbol_name_matcher_inner): Likewise.
 389         (get_symbol_name_matcher): Delete.
 390         (unknown_language_data): Delete la_get_symbol_name_matcher
 391         initializer.
 392         (auto_language_data): Likewise.
 393         * language.h (language_data): Delete la_get_symbol_name_matcher
 394         field.
 395         (language_defn::get_symbol_name_matcher): New member function.
 396         (language_defn::get_symbol_name_matcher_inner): Likewise.
 397         (default_symbol_name_matcher): Delete declaration.
 398         * linespec.c (find_methods): Update call to
 399         get_symbol_name_matcher.
 400         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
 401         initializer.
 402         * minsyms.c (lookup_minimal_symbol): Update call to
 403         get_symbol_name_matcher.
 404         (iterate_over_minimal_symbols): Likewise.
 405         * objc-lang.c (objc_language_data): Delete
 406         la_get_symbol_name_matcher initializer.
 407         * opencl-lang.c (opencl_language_data): Likewise.
 408         * p-lang.c (pascal_language_data): Likewise.
 409         * psymtab.c (psymbol_name_matches): Update call to
 410         get_symbol_name_matcher.
 411         * rust-lang.c (rust_language_data): Delete
 412         la_get_symbol_name_matcher initializer.
 413         * symtab.c (symbol_matches_search_name): Update call to
 414         get_symbol_name_matcher.
 415         (compare_symbol_name): Likewise.
 416
 417 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * ada-lang.c (ada_language_data): Delete la_compute_program
 420         initializer.
 421         * c-lang.c (c_language_data): Likewise.
 422         (c_language::compute_program): New member function.
 423         (cplus_language_data): Delete la_compute_program initializer.
 424         (cplus_language::compute_program): New member function.
 425         (asm_language_data): Delete la_compute_program initializer.
 426         (minimal_language_data): Likewise.
 427         * c-lang.h (c_compute_program): Update comment.
 428         (cplus_compute_program): Likewise.
 429         * compile/compile-c-support.c (c_compute_program): Likewise.
 430         (cplus_compute_program): Likewise.
 431         * compile/compile.c (compile_to_object): Update call to
 432         la_compute_program.
 433         * d-lang.c (d_language_data): Delete la_compute_program
 434         initializer.
 435         * f-lang.c (f_language_data): Likewise.
 436         * go-lang.c (go_language_data): Likewise.
 437         * language.c (unknown_language_data): Likewise.
 438         (auto_language_data): Likewise.
 439         * language.h (language_data): Delete la_compute_program field.
 440         (language_defn::compute_program): New member function.
 441         * m2-lang.c (m2_language_data): Delete la_compute_program
 442         initializer.
 443         * objc-lang.c (objc_language_data): Likewise.
 444         * opencl-lang.c (opencl_language_data): Likewise.
 445         * p-lang.c (pascal_language_data): Likewise.
 446         * rust-lang.c (rust_language_data): Likewise.
 447
 448 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 449
 450         * ada-lang.c (ada_language_data) Delete
 451         la_class_name_from_physname initializer.
 452         * c-lang.c (c_language_data): Likewise.
 453         (cplus_language_data): Likewise.
 454         (cplus_language::class_name_from_physname): New member function.
 455         (asm_language_data): Delete la_class_name_from_physname
 456         initializer.
 457         (minimal_language_data): Likewise.
 458         * d-lang.c (d_language_data): Likewise.
 459         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
 460         method on language_defn class.
 461         (guess_full_die_structure_name): Likewise.
 462         * f-lang.c (f_language_data): Delete la_class_name_from_physname
 463         initializer.
 464         * go-lang.c (go_language_data): Likewise.
 465         * language.c (language_class_name_from_physname): Delete.
 466         (unk_lang_class_name): Delete.
 467         (unknown_language_data): Delete la_class_name_from_physname
 468         initializer.
 469         (auto_language_data): Likewise.
 470         * language.h (language_data): Delete la_class_name_from_physname
 471         field.
 472         (language_defn::class_name_from_physname): New function.
 473         (language_class_name_from_physname): Delete declaration.
 474         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
 475         initializer.
 476         * objc-lang.c (objc_language_data): Likewise.
 477         * opencl-lang.c (opencl_language_data): Likewise.
 478         * p-lang.c (pascal_language_data): Likewise.
 479         * rust-lang.c (rust_language_data): Likewise.
 480
 481 2020-06-16  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-data.h (STATUS_NAME): New macro.
 484         * tui/tui-layout.c (tui_remove_some_windows)
 485         (initialize_known_windows, tui_register_window)
 486         (tui_layout_split::remove_windows, initialize_layouts)
 487         (tui_new_layout_command): Don't use hard-coded window names.
 488
 489 2020-06-16  Tom Tromey  <tom@tromey.com>
 490
 491         PR tui/25348:
 492         * tui/tui.c (tui_ensure_readline_initialized): Rename from
 493         tui_initialize_readline.  Only run once.  Call rl_initialize.
 494         * tui/tui.h (tui_ensure_readline_initialized): Rename from
 495         tui_initialize_readline.
 496         * tui/tui-io.c (tui_setup_io): Call
 497         tui_ensure_readline_initialized.
 498         * tui/tui-interp.c (tui_interp::init): Update.
 499
 500 2020-06-16  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
 503         Also preserve the status window.
 504
 505 2020-06-16  Tom Tromey  <tom@tromey.com>
 506
 507         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
 508         where m_window==nullptr.
 509
 510 2020-06-15  Tom Tromey  <tromey@adacore.com>
 511
 512         * windows-nat.c (windows_nat::handle_output_debug_string):
 513         Update.
 514         (windows_nat::handle_ms_vc_exception): Update.
 515         * target.h (target_read_string): Change API.
 516         * target.c (target_read_string): Change API.
 517         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
 518         Update.
 519         * solib-frv.c (frv_current_sos): Update.
 520         * solib-dsbt.c (dsbt_current_sos): Update.
 521         * solib-darwin.c (darwin_current_sos): Update.
 522         * linux-thread-db.c (inferior_has_bug): Update.
 523         * expprint.c (print_subexp_standard): Update.
 524         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
 525         (ada_exception_message_1): Update.
 526
 527 2020-06-15  Tom Tromey  <tromey@adacore.com>
 528
 529         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
 530
 531 2020-06-15  Tom Tromey  <tromey@adacore.com>
 532
 533         * valprint.c (read_string): Update comment.
 534         * target.c (MIN): Remove.
 535         (target_read_string): Rewrite.
 536
 537 2020-06-15  Tom Tromey  <tromey@adacore.com>
 538
 539         * corefile.c (read_memory_string): Remove.
 540         * ada-valprint.c (ada_value_print_ptr): Update.
 541         * ada-lang.h (ada_tag_name): Change return type.
 542         * ada-lang.c (type_from_tag): Update.
 543         (ada_tag_name_from_tsd): Change return type.  Use
 544         target_read_string.
 545         (ada_tag_name): Likewise.
 546         * gdbcore.h (read_memory_string): Don't declare.
 547
 548 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
 549
 550         * symtab.c (rbreak_command): Ignore Windows drive colon.
 551
 552 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
 553
 554         * NEWS: Mention removed GDBserver host support.
 555
 556 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
 557
 558         * features/riscv/rebuild-csr-xml.sh: Updated.
 559
 560 2020-06-11  Tom Tromey  <tom@tromey.com>
 561
 562         PR gdb/18318:
 563         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
 564
 565 2020-06-09  Jonny Grant  <jg@jguk.org>
 566 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
 567
 568         * main.c (captured_main_1): Don't print new line after help.
 569         (print_gdb_help): add mailing list and IRC channel information
 570         to --help.  Add new lines between items in the footer.  Remove
 571         quotes around bug url.
 572
 573 2020-06-11  Keith Seitz  <keiths@redhat.com>
 574
 575         PR gdb/21356
 576         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
 577         Resolve typedefs for type length calculations.
 578
 579 2020-06-10  Tom de Vries  <tdevries@suse.de>
 580
 581         PR ada/24713
 582         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
 583         (write_psymbols): Enable .gdb_index for ada.
 584         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
 585         ada.
 586
 587 2020-06-10  Tom de Vries  <tdevries@suse.de>
 588
 589         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
 590         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
 591         namei" instead of "const char *name" argument.
 592         (dw2_map_matching_symbols): Use "offset_type namei" variant of
 593         dw2_symtab_iter_init.
 594
 595 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 596
 597         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
 598         to use type::field and field::type instead.
 599
 600 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 601
 602         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
 603         to use field::type instead.
 604
 605 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 606
 607         * gdbtypes.h (struct field) <type, set_type>: New methods.
 608         Rename `type` field to...
 609         <m_type>: ... this.  Change references throughout to use type or
 610         set_type methods.
 611         (FIELD_TYPE): Use field::type.  Change call sites that modify
 612         the field's type to use field::set_type instead.
 613
 614 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 615
 616         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
 617         to use type::index_type instead.
 618
 619 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 620
 621         * gdbtypes.h (struct type) <index_type, set_index_type>: New
 622         methods.
 623         (TYPE_INDEX_TYPE): Use type::index_type.
 624         * gdbtypes.c (create_array_type_with_stride): Likewise.
 625
 626 2020-06-07  Tom Tromey  <tom@tromey.com>
 627
 628         * valprint.c (generic_val_print_float): Remove "embedded_offset"
 629         parameter.
 630         (generic_value_print): Update.
 631
 632 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         Revert commit 982a38f60b0.
 635         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
 636
 637 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
 640         avoid use after free.
 641
 642 2020-06-05  Tom de Vries  <tdevries@suse.de>
 643
 644         * NEWS: Fix typos.
 645
 646 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
 647
 648         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
 649         the per_bfd object.
 650         (dwarf2_read_debug_names): Likewise.
 651         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
 652         object when re-using a per_bfd object with an index.
 653
 654 2020-06-03  Tom de Vries  <tdevries@suse.de>
 655
 656         PR symtab/26046
 657         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
 658         children for C++.
 659         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
 660         DW_TAG_subprogram.
 661
 662 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 663
 664         * ada-lang.c (ada_language_data): Delete skip_trampoline
 665         initializer.
 666         * c-lang.c (c_language_data): Likewise.
 667         (cplus_language_data): Likewise.
 668         (cplus_language::skip_trampoline): New member function.
 669         (asm_language_data): Delete skip_trampoline initializer.
 670         (minimal_language_data): Likewise.
 671         * d-lang.c (d_language_data): Likewise.
 672         * f-lang.c (f_language_data): Likewise.
 673         * go-lang.c (go_language_data): Likewise.
 674         * language.c (unk_lang_trampoline): Delete function.
 675         (skip_language_trampoline): Update.
 676         (unknown_language_data): Delete skip_trampoline initializer.
 677         (auto_language_data): Likewise.
 678         * language.h (language_data): Delete skip_trampoline field.
 679         (language_defn::skip_trampoline): New function.
 680         * m2-lang.c (m2_language_data): Delete skip_trampoline
 681         initializer.
 682         * objc-lang.c (objc_skip_trampoline): Delete function, move
 683         implementation to objc_language::skip_trampoline.
 684         (objc_language_data): Delete skip_trampoline initializer.
 685         (objc_language::skip_trampoline): New member function with
 686         implementation from objc_skip_trampoline.
 687         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
 688         initializer.
 689         * p-lang.c (pascal_language_data): Likewise.
 690         * rust-lang.c (rust_language_data): Likewise.
 691
 692 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 693
 694         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
 695         (ada_language::demangle): New member function.
 696         * c-lang.c (c_language_data): Delete la_demangle initializer.
 697         (cplus_language_data): Delete la_demangle initializer.
 698         (cplus_language::demangle): New member function.
 699         (asm_language_data): Delete la_demangle initializer.
 700         (minimal_language_data): Delete la_demangle initializer.
 701         * d-lang.c (d_language_data): Delete la_demangle initializer.
 702         (d_language::demangle): New member function.
 703         * f-lang.c (f_language_data): Delete la_demangle initializer.
 704         (f_language::demangle): New member function.
 705         * go-lang.c (go_language_data): Delete la_demangle initializer.
 706         (go_language::demangle): New member function.
 707         * language.c (language_demangle): Update.
 708         (unk_lang_demangle): Delete.
 709         (unknown_language_data): Delete la_demangle initializer.
 710         (unknown_language::demangle): New member function.
 711         (auto_language_data): Delete la_demangle initializer.
 712         (auto_language::demangle): New member function.
 713         * language.h (language_data): Delete la_demangle field.
 714         (language_defn::demangle): New function.
 715         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
 716         * objc-lang.c (objc_language_data): Delete la_demangle
 717         initializer.
 718         (objc_language::demangle): New member function.
 719         * opencl-lang.c (opencl_language_data): Delete la_demangle
 720         initializer.
 721         * p-lang.c (pascal_language_data): Likewise.
 722         * rust-lang.c (rust_language_data): Likewise.
 723         (rust_language::demangle): New member function.
 724
 725 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 726
 727         * ada-lang.c (ada_language_data): Delete la_print_type
 728         initializer.
 729         (ada_language::print_type): New member function.
 730         * c-lang.c (c_language_data): Delete la_print_type initializer.
 731         (c_language::print_type): New member function.
 732         (cplus_language_data): Delete la_print_type initializer.
 733         (cplus_language::print_type): New member function.
 734         (asm_language_data): Delete la_print_type initializer.
 735         (asm_language::print_type): New member function.
 736         (minimal_language_data): Delete la_print_type initializer.
 737         (minimal_language::print_type): New member function.
 738         * d-lang.c (d_language_data): Delete la_print_type initializer.
 739         (d_language::print_type): New member function.
 740         * f-lang.c (f_language_data): Delete la_print_type initializer.
 741         (f_language::print_type): New member function.
 742         * go-lang.c (go_language_data): Delete la_print_type initializer.
 743         (go_language::print_type): New member function.
 744         * language.c (unk_lang_print_type): Delete.
 745         (unknown_language_data): Delete la_print_type initializer.
 746         (unknown_language::print_type): New member function.
 747         (auto_language_data): Delete la_print_type initializer.
 748         (auto_language::print_type): New member function.
 749         * language.h (language_data): Delete la_print_type field.
 750         (language_defn::print_type): New function.
 751         (LA_PRINT_TYPE): Update.
 752         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
 753         (m2_language::print_type): New member function.
 754         * objc-lang.c (objc_language_data): Delete la_print_type
 755         initializer.
 756         (objc_language::print_type): New member function.
 757         * opencl-lang.c (opencl_print_type): Delete, implementation moved
 758         to opencl_language::print_type.
 759         (opencl_language_data): Delete la_print_type initializer.
 760         (opencl_language::print_type): New member function, implementation
 761         from opencl_print_type.
 762         * p-lang.c (pascal_language_data): Delete la_print_type
 763         initializer.
 764         (pascal_language::print_type): New member function.
 765         * rust-lang.c (rust_print_type): Delete, implementation moved to
 766         rust_language::print_type.
 767         (rust_language_data): Delete la_print_type initializer.
 768         (rust_language::print_type): New member function, implementation
 769         from rust_print_type.
 770
 771 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
 774         implementation moves to...
 775         (ada_language::sniff_from_mangled_name): ...here.  Update return
 776         type.
 777         (ada_language_data): Delete la_sniff_from_mangled_name
 778         initializer.
 779         * c-lang.c (c_language_data): Likewise.
 780         (cplus_language_data): Likewise.
 781         (cplus_language::sniff_from_mangled_name): New member function,
 782         implementation taken from gdb_sniff_from_mangled_name.
 783         (asm_language_data): Delete la_sniff_from_mangled_name
 784         initializer.
 785         (minimal_language_data): Likewise.
 786         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
 787         implementation moves to cplus_language::sniff_from_mangled_name.
 788         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
 789         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
 790         moves to...
 791         (d_language::sniff_from_mangled_name): ...here.
 792         (d_language_data): Delete la_sniff_from_mangled_name initializer.
 793         * f-lang.c (f_language_data): Likewise.
 794         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
 795         moves to...
 796         (go_language::sniff_from_mangled_name): ...here.
 797         (go_language_data): Delete la_sniff_from_mangled_name initializer.
 798         * language.c (language_sniff_from_mangled_name): Delete.
 799         (unknown_language_data): Delete la_sniff_from_mangled_name
 800         initializer.
 801         (auto_language_data): Likewise.
 802         * language.h (language_data): Delete la_sniff_from_mangled_name
 803         field.
 804         (language_defn::sniff_from_mangled_name): New function.
 805         (language_sniff_from_mangled_name): Delete declaration.
 806         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
 807         field.
 808         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
 809         implementation moves to...
 810         (objc_language::sniff_from_mangled_name): ...here.
 811         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
 812         * opencl-lang.c (opencl_language_data): Likewise.
 813         * p-lang.c (pascal_language_data): Likewise.
 814         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
 815         implementation moves to...
 816         (rust_language::sniff_from_mangled_name): ...here.
 817         (rust_language_data): Delete la_sniff_from_mangled_name
 818         initializer.
 819         * symtab.c (symbol_find_demangled_name): Call
 820         sniff_from_mangled_name member function.
 821
 822 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 823
 824         * ada-lang.c (ada_language_data): Delete la_search_name_hash
 825         initializer.
 826         * c-lang.c (c_language_data): Likewise.
 827         (cplus_language_data): Likewise.
 828         (cplus_language::search_name_hash): New member function.
 829         (asm_language_data): Delete la_search_name_hash initializer.
 830         (minimal_language_data): Likewise.
 831         * d-lang.c (d_language_data): Likewise.
 832         * dictionary.c (default_search_name_hash): Rename to...
 833         (language_defn::search_name_hash): ...this.
 834         * f-lang.c (f_language_data): Likewise.
 835         (f_language::search_name_hash): New member function.
 836         * go-lang.c (go_language_data): Delete la_search_name_hash
 837         initializer.
 838         * language.c (unknown_language_data): Likewise.
 839         (auto_language_data): Likewise.
 840         * language.h (struct language_data): Delete la_search_name_hash
 841         field.
 842         (language_defn::search_name_hash): Declare new member function.
 843         (default_search_name_hash): Delete declaration.
 844         * m2-lang.c (m2_language_data): Delete la_search_name_hash
 845         initializer.
 846         * objc-lang.c (objc_language_data): Likewise.
 847         * opencl-lang.c (opencl_language_data): Likewise.
 848         * p-lang.c (pascal_language_data): Likewise.
 849         * rust-lang.c (rust_language_data): Likewise.
 850         * symtab.c (search_name_hash): Update call.
 851
 852 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
 855         initializer.
 856         * c-lang.c (class compile_instance): Declare.
 857         (c_language_data): Delete la_get_compile_instance initializer.
 858         (c_language::get_compile_instance): New member function.
 859         (cplus_language_data): Delete la_get_compile_instance initializer.
 860         (cplus_language::get_compile_instance): New member function.
 861         (asm_language_data): Delete la_get_compile_instance initializer.
 862         (minimal_language_data): Likewise.
 863         * c-lang.h (c_get_compile_context): Update comment.
 864         (cplus_get_compile_context): Update comment.
 865         * compile/compile.c (compile_to_object): Update calls, don't rely
 866         on function pointer being NULL.
 867         * d-lang.c (d_language_data): Delete la_get_compile_instance
 868         initializer.
 869         * f-lang.c (f_language_data): Likewise.
 870         * go-lang.c (go_language_data): Likewise.
 871         * language.c (unknown_language_data): Likewise.
 872         (auto_language_data): Likewise.
 873         * language.h (language_data): Delete la_get_compile_instance field.
 874         (language_defn::get_compile_instance): New member function.
 875         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
 876         initializer.
 877         * objc-lang.c (objc_language_data): Likewise.
 878         * opencl-lang.c (opencl_language_data): Likewise.
 879         * p-lang.c (pascal_language_data): Likewise.
 880         * rust-lang.c (rust_language_data): Likewise.
 881
 882 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 883
 884         * ada-lang.c (ada_add_all_symbols): Update comment.
 885         (ada_iterate_over_symbols): Delete, move implementation to...
 886         (ada_language::iterate_over_symbols): ...here, a new member
 887         function, rewrite to use range based for loop.
 888         (ada_language_data): Delete la_iterate_over_symbols initializer.
 889         * c-lang.c (c_language_data): Likewise.
 890         (cplus_language_data): Likewise.
 891         (asm_language_data): Likewise.
 892         (minimal_language_data): Likewise.
 893         * d-lang.c (d_language_data): Likewise.
 894         * f-lang.c (f_language_data): Likewise.
 895         * go-lang.c (go_language_data): Likewise.
 896         * language.c (unknown_language_data): Likewise.
 897         (auto_language_data): Likewise.
 898         * language.h (language_data): Delete la_iterate_over_symbols field.
 899         (language_defn::iterate_over_symbols): New member function.
 900         (LA_ITERATE_OVER_SYMBOLS): Update.
 901         * linespec.c (iterate_over_all_matching_symtabs): Update.
 902         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
 903         initializer.
 904         * objc-lang.c (objc_language_data): Likewise.
 905         * opencl-lang.c (opencl_language_data): Likewise.
 906         * p-lang.c (pascal_language_data): Likewise.
 907         * rust-lang.c (rust_language_data): Likewise.
 908
 909 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 910
 911         * ada-lang.c (ada_language_data): Delete
 912         la_lookup_transparent_type initializer.
 913         * c-lang.c (c_language_data): Likewise.
 914         (cplus_language_data): Likewise.
 915         (cplus_language::lookup_transparent_type): New member function.
 916         (asm_language_data): Delete la_lookup_transparent_type
 917         initializer.
 918         (minimal_language_data): Likewise.
 919         * d-lang.c (d_language_data): Likewise.
 920         * f-lang.c (f_language_data): Likewise.
 921         * go-lang.c (go_language_data): Likewise.
 922         * language.c (unknown_language_data): Likewise.
 923         (auto_language_data): Likewise.
 924         * language.h (struct language_data): Delete
 925         la_lookup_transparent_type field.
 926         (language_defn::lookup_transparent_type): New member function.
 927         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
 928         initializer.
 929         * objc-lang.c (objc_language_data): Likewise.
 930         * opencl-lang.c (opencl_language_data): Likewise.
 931         * p-lang.c (pascal_language_data): Likewise.
 932         * rust-lang.c (rust_language_data): Likewise.
 933         * symtab.c (symbol_matches_domain): Update call.
 934
 935 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 936
 937         * ada-lang.c (ada_language_arch_info): Delete function, move
 938         implementation to...
 939         (ada_language::language_arch_info): ...here, a new member
 940         function.
 941         (ada_language_data): Delete la_language_arch_info.
 942         * c-lang.c (c_language_data): Likewise.
 943         (c_language::language_arch_info): New member function.
 944         (cplus_language_arch_info): Delete function, move
 945         implementation to...
 946         (cplus_language::language_arch_info): ...here, a new member
 947         function.
 948         (cplus_language_data): Delete la_language_arch_info.
 949         (asm_language_data): Likewise.
 950         (asm_language::language_arch_info): New member function.
 951         (minimal_language_data): Delete la_language_arch_info.
 952         (minimal_language::language_arch_info): New member function.
 953         * d-lang.c (d_language_arch_info): Delete function, move
 954         implementation to...
 955         (d_language::language_arch_info): ...here, a new member
 956         function.
 957         (d_language_data): Delete la_language_arch_info.
 958         * f-lang.c (f_language_arch_info): Delete function, move
 959         implementation to...
 960         (f_language::language_arch_info): ...here, a new member
 961         function.
 962         (f_language_data): Delete la_language_arch_info.
 963         * go-lang.c (go_language_arch_info): Delete function, move
 964         implementation to...
 965         (go_language::language_arch_info): ...here, a new member
 966         function.
 967         (go_language_data): Delete la_language_arch_info.
 968         * language.c (unknown_language_data): Likewise.
 969         (unknown_language::language_arch_info): New member function.
 970         (auto_language_data): Delete la_language_arch_info.
 971         (auto_language::language_arch_info): New member function.
 972         (language_gdbarch_post_init): Update call to
 973         la_language_arch_info.
 974         * language.h (language_data): Delete la_language_arch_info
 975         function pointer.
 976         (language_defn::language_arch_info): New function.
 977         * m2-lang.c (m2_language_arch_info): Delete function, move
 978         implementation to...
 979         (m2_language::language_arch_info): ...here, a new member
 980         function.
 981         (m2_language_data): Delete la_language_arch_info.
 982         * objc-lang.c (objc_language_arch_info): Delete function, move
 983         implementation to...
 984         (objc_language::language_arch_info): ...here, a new member
 985         function.
 986         (objc_language_data): Delete la_language_arch_info.
 987         * opencl-lang.c (opencl_language_arch_info): Delete function, move
 988         implementation to...
 989         (opencl_language::language_arch_info): ...here, a new member
 990         function.
 991         (opencl_language_data): Delete la_language_arch_info.
 992         * p-lang.c (pascal_language_arch_info): Delete function, move
 993         implementation to...
 994         (pascal_language::language_arch_info): ...here, a new member
 995         function.
 996         (pascal_language_data): Delete la_language_arch_info.
 997         * rust-lang.c (rust_language_arch_info): Delete function, move
 998         implementation to...
 999         (rust_language::language_arch_info): ...here, a new member
1000         function.
1001         (rust_language_data): Delete la_language_arch_info.
1002
1003 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1006         initializer.
1007         * c-lang.c (c_language_data): Likewise.
1008         (cplus_language_data): Likewise.
1009         (cplus_language::pass_by_reference_info): New method.
1010         (asm_language_data): Delete la_pass_by_reference initializer.
1011         (minimal_language_data): Likewise.
1012         * cp-abi.c (cp_pass_by_reference): Remove use of
1013         default_pass_by_reference.
1014         * d-lang.c (d_language_data): Likewise.
1015         * f-lang.c (f_language_data): Likewise.
1016         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1017         default_pass_by_reference.
1018         * go-lang.c (go_language_data): Likewise.
1019         * language.c (language_pass_by_reference): Update.
1020         (default_pass_by_reference): Delete.
1021         (unknown_language_data): Delete la_pass_by_reference
1022         initializer.
1023         (auto_language_data): Likewise.
1024         * language.h (struct language_data): Delete la_pass_by_reference
1025         field.
1026         (language_defn::pass_by_reference_info): New member function.
1027         (default_pass_by_reference): Delete declaration.
1028         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1029         initializer.
1030         * objc-lang.c (objc_language_data): Likewise.
1031         * opencl-lang.c (opencl_language_data): Likewise.
1032         * p-lang.c (pascal_language_data): Likewise.
1033         * rust-lang.c (rust_language_data): Likewise.
1034
1035 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1036
1037         * ada-lang.c (ada_read_var_value): Delete function, move
1038         implementation to...
1039         (ada_language::read_var_value): ...here.
1040         (ada_language_data): Delete la_read_var_value initializer.
1041         * c-lang.c (c_language_data): Likewise.
1042         (cplus_language_data): Likewise.
1043         (minimal_language_data): Likewise.
1044         * d-lang.c (d_language_data): Likewise.
1045         * f-lang.c (f_language_data): Likewise.
1046         * findvar.c (default_read_var_value): Rename to...
1047         (language_defn::read_var_value): ...this.
1048         * findvar.c (read_var_value): Update header comment, and change to
1049         call member function instead of function pointer.
1050         * go-lang.c (go_language_data): Likewise.
1051         * language.c (unknown_language_data): Delete la_read_var_value
1052         initializer.
1053         (auto_language_data): Likewise.
1054         * language.h (struct language_data): Delete la_read_var_value
1055         field.
1056         (language_defn::read_var_value): New member function.
1057         (default_read_var_value): Delete declaration.
1058         * m2-lang.c (m2_language_data): Delete la_read_var_value
1059         initializer.
1060         * objc-lang.c (objc_language_data): Likewise.
1061         * opencl-lang.c (opencl_language_data): Likewise.
1062         * p-lang.c (pascal_language_data): Likewise.
1063         * rust-lang.c (rust_language_data): Likewise.
1064         * value.h (default_read_var_value): Delete declaration.
1065
1066 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1067
1068         * ada-lang.c (ada_print_array_index): Delete function, move
1069         implementation to...
1070         (ada_language::print_array_index): ...here.
1071         (ada_language_data): Delete la_print_array_index initializer.
1072         * c-lang.c (c_language_data): Likewise.
1073         (cplus_language_data): Likewise.
1074         (minimal_language_data): Likewise.
1075         * d-lang.c (d_language_data): Likewise.
1076         * f-lang.c (f_language_data): Likewise.
1077         * go-lang.c (go_language_data): Likewise.
1078         * language.c (default_print_array_index): Delete function, move
1079         implementation to...
1080         (language_defn::print_array_index): ...here.
1081         (unknown_language_data): Delete la_print_array_index initializer.
1082         (auto_language_data): Likewise.
1083         * language.h (struct language_data): Delete la_print_array_index
1084         field.
1085         (language_defn::print_array_index): New member function.
1086         (LA_PRINT_ARRAY_INDEX): Update.
1087         (default_print_array_index): Delete declaration.
1088         * m2-lang.c (m2_language_data): Delete la_print_array_index
1089         initializer.
1090         * objc-lang.c (objc_language_data): Likewise.
1091         * opencl-lang.c (opencl_language_data): Likewise.
1092         * p-lang.c (pascal_language_data): Likewise.
1093         * rust-lang.c (rust_language_data): Likewise.
1094
1095 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * gdb/ada-lang.c (ada_language_defn): Convert to...
1098         (ada_language_data): ...this.
1099         (class ada_language): New class.
1100         (ada_language_defn): New static global.
1101         * gdb/c-lang.c (c_language_defn): Convert to...
1102         (c_language_data): ...this.
1103         (class c_language): New class.
1104         (c_language_defn): New static global.
1105         (cplus_language_defn): Convert to...
1106         (cplus_language_data): ...this.
1107         (class cplus_language): New class.
1108         (cplus_language_defn): New static global.
1109         (asm_language_defn): Convert to...
1110         (asm_language_data): ...this.
1111         (class asm_language): New class.
1112         (asm_language_defn): New static global.
1113         (minimal_language_defn): Convert to...
1114         (minimal_language_data): ...this.
1115         (class minimal_language): New class.
1116         (minimal_language_defn): New static global.
1117         * gdb/d-lang.c (d_language_defn): Convert to...
1118         (d_language_data): ...this.
1119         (class d_language): New class.
1120         (d_language_defn): New static global.
1121         * gdb/f-lang.c (f_language_defn): Convert to...
1122         (f_language_data): ...this.
1123         (class f_language): New class.
1124         (f_language_defn): New static global.
1125         * gdb/go-lang.c (go_language_defn): Convert to...
1126         (go_language_data): ...this.
1127         (class go_language): New class.
1128         (go_language_defn): New static global.
1129         * gdb/language.c (unknown_language_defn): Remove declaration.
1130         (current_language): Initialize to nullptr, real initialization is
1131         moved to _initialize_language.
1132         (languages): Delete global.
1133         (language_defn::languages): Define.
1134         (set_language_command): Use language_defn::languages.
1135         (set_language): Likewise.
1136         (range_error): Likewise.
1137         (language_enum): Likewise.
1138         (language_def): Likewise.
1139         (add_set_language_command): Use language_def::languages for the
1140         language list, and language_def to lookup language pointers.
1141         (skip_language_trampoline): Use language_defn::languages.
1142         (unknown_language_defn): Convert to...
1143         (unknown_language_data): ...this.
1144         (class unknown_language): New class.
1145         (unknown_language_defn): New static global.
1146         (auto_language_defn): Convert to...
1147         (auto_language_data): ...this.
1148         (class auto_language): New class.
1149         (auto_language_defn): New static global.
1150         (language_gdbarch_post_init): Use language_defn::languages.
1151         (_initialize_language): Initialize current_language.
1152         * gdb/language.h (struct language_defn): Rename to...
1153         (struct language_data): ...this.
1154         (struct language_defn): New.
1155         (auto_language_defn): Delete.
1156         (unknown_language_defn): Delete.
1157         (minimal_language_defn): Delete.
1158         (ada_language_defn): Delete.
1159         (asm_language_defn): Delete.
1160         (c_language_defn): Delete.
1161         (cplus_language_defn): Delete.
1162         (d_language_defn): Delete.
1163         (f_language_defn): Delete.
1164         (go_language_defn): Delete.
1165         (m2_language_defn): Delete.
1166         (objc_language_defn): Delete.
1167         (opencl_language_defn): Delete.
1168         (pascal_language_defn): Delete.
1169         (rust_language_defn): Delete.
1170         * gdb/m2-lang.c (m2_language_defn): Convert to...
1171         (m2_language_data): ...this.
1172         (class m2_language): New class.
1173         (m2_language_defn): New static global.
1174         * gdb/objc-lang.c (objc_language_defn): Convert to...
1175         (objc_language_data): ...this.
1176         (class objc_language): New class.
1177         (objc_language_defn): New static global.
1178         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
1179         (opencl_language_data): ...this.
1180         (class opencl_language): New class.
1181         (opencl_language_defn): New static global.
1182         * gdb/p-lang.c (pascal_language_defn): Convert to...
1183         (pascal_language_data): ...this.
1184         (class pascal_language): New class.
1185         (pascal_language_defn): New static global.
1186         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
1187         language pointer, update comment format.
1188         * gdb/rust-lang.c (rust_language_defn): Convert to...
1189         (rust_language_data): ...this.
1190         (class rust_language): New class.
1191         (rust_language_defn): New static global.
1192
1193 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1194
1195         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
1196         member variable.
1197         <m_stmt_at_address>: New member variable.
1198         (lnp_state_machine::record_line): Don't record some lines, update
1199         tracking of is_stmt at the same address.
1200         (lnp_state_machine::lnp_state_machine): Initialise new member
1201         variables.
1202
1203 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1204
1205         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
1206         "-include gnu-nat-mig.h".
1207         * gnu-nat-mig.h: New file.
1208         * gnu-nat.c: Include "gnu-nat-mig.h".
1209         (exc_server, msg_reply_server, notify_server,
1210         process_reply_server): Remove declarations.
1211
1212 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1213
1214         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
1215         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
1216         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
1217         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
1218         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
1219         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
1220         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
1221         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
1222         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
1223         to gnu_nat_target class.
1224         * gnu-nat.c: Likewise.
1225         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
1226         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
1227         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
1228         object.
1229         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
1230         instead of `gnu_target'.
1231
1232 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1233
1234         * i386-gnu-tdep.c: Include "gdbcore.h"
1235         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
1236         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
1237         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
1238         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
1239         i386_gnu_sigcontext_addr): New functions
1240         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
1241         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
1242         tdep.
1243
1244 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1245
1246         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
1247         before fork_inferior call. Avoid calling it if target_is_pushed returns
1248         true.
1249
1250 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1251
1252         * gnu-nat.h (gnu_target): New variable declaration.
1253         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
1254         gnu_target.
1255         * gnu-nat.c (gnu_target): New variable.
1256         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
1257         add_thread_silent, and add_thread calls.
1258         (gnu_nat_target::create_inferior): Pass gnu_target to
1259         add_thread_silent, thread_change_ptid call.
1260         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
1261         call.
1262
1263 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1264
1265         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
1266         (gnu_nat_target::find_memory_regions): Remove unused
1267         `old_address' variable.
1268
1269 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1270
1271         * gnu-nat.c: Include "gdbarch.h".
1272
1273 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1274
1275         * reply_mig_hack.awk (Error return): Cast function through
1276         void *, to bypass compiler function call check.
1277
1278 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1279
1280         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
1281         $(srcdir)/reply_mig_hack.awk.
1282
1283 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1284
1285         * gnu-nat.h (gnu_debug_flag): Set type to bool.
1286
1287 2020-05-30  Jonny Grant  <jg@jguk.org>
1288
1289         * configure.ac (ACX_BUGURL): change bug URL to https.
1290
1291 2020-05-30  Pedro Alves  <palves@redhat.com>
1292
1293         * cp-support.c (replace_typedefs_template): New.
1294         (replace_typedefs_qualified_name): Handle
1295         DEMANGLE_COMPONENT_TEMPLATE.
1296
1297 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
1298
1299         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
1300         dwarf2/index-cache.h, dwarf2/index-write.c,
1301         dwarf2/index-write.h, dwarf2/line-header.c,
1302         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
1303         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
1304         variables and fields from `dwarf2_per_objfile` to just
1305         `per_objfile` throughout.
1306
1307 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
1308
1309         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1310         <push_dwarf_reg_entry_value>: Add comment.
1311
1312 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
1313             Keith Seitz  <keiths@redhat.com>
1314
1315         * python/python.c (do_start_initialization): Call PyEval_SaveThread
1316         instead of PyEval_ReleaseLock.
1317         (class gdbpy_gil): Move to earlier in file.
1318         (finalize_python): Set gdb_python_initialized.
1319         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
1320         when not initialized.
1321
1322 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
1323
1324         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1325         <push_dwarf_reg_entry_value>: Remove assert.  Override
1326         per_objfile with caller_per_objfile.
1327
1328 2020-05-28  Tom de Vries  <tdevries@suse.de>
1329
1330         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
1331         PR gold/15646 workaround to symbol kind "type".
1332
1333 2020-05-27  Tom Tromey  <tromey@adacore.com>
1334
1335         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
1336
1337 2020-05-27  Tom Tromey  <tromey@adacore.com>
1338
1339         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
1340         Use htab_find_with_hash.
1341         <add_abbrev>: Remove "abbrev_number" parameter.
1342         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
1343         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
1344         (hash_abbrev): Add comment.
1345         (abbrev_table::lookup_abbrev): Move to header file.
1346         (abbrev_table::read): Update.
1347
1348 2020-05-27  Tom Tromey  <tromey@adacore.com>
1349
1350         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
1351         method.
1352         <canonical_name>: New member.
1353         <raw_name>: Rename from "name".
1354         (partial_die_info): Initialize canonical_name.
1355         (scan_partial_symbols): Check raw_name.
1356         (partial_die_parent_scope, partial_die_full_name)
1357         (add_partial_symbol, add_partial_subprogram)
1358         (add_partial_enumeration, load_partial_dies): Use "name" method.
1359         (partial_die_info::name): New method.
1360         (partial_die_info::read, guess_partial_die_structure_name)
1361         (partial_die_info::fixup): Update.
1362
1363 2020-05-27  Tom Tromey  <tromey@adacore.com>
1364
1365         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
1366         <get_ref_die_offset>: Inline.
1367         <get_ref_die_offset_complaint>: New method.
1368         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
1369         (attribute::get_ref_die_offset_complaint): Rename from
1370         get_ref_die_offset.  Just issue complaint.
1371
1372 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1373
1374         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
1375
1376 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1377
1378         * exec.c (exec_file_attach): Use errno value of first openp failure.
1379
1380 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1381
1382         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
1383         Don't close thread handle.
1384
1385 2020-05-27  Tom Tromey  <tom@tromey.com>
1386             Simon Marchi  <simon.marchi@efficios.com>
1387
1388         * objfiles.h (struct objfile) <partial_symtabs>: Now a
1389         shared_ptr.
1390         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
1391         member.
1392         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
1393         dwarf2_per_bfd_objfile_data_key>: New globals.
1394         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
1395         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
1396         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
1397         shared.
1398         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
1399         short-circuit when sharing.
1400         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
1401         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
1402
1403 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1404
1405         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
1406         to...
1407         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
1408         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
1409
1410 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1411
1412         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
1413         build_name_components, find_name_components_bounds>:
1414         Add per_objfile parameter.
1415         (struct mapped_index) <symbol_name_at>: Likewise.
1416         (struct mapped_debug_names): Remove constructor.
1417         <dwarf2_per_objfile>: Remove field.
1418         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
1419         (mapped_index_base::find_name_components_bounds,
1420         mapped_index_base::build_name_components,
1421         dw2_expand_symtabs_matching_symbol): Likewise.
1422         (class mock_mapped_index) <symbol_name_at>: Likewise.
1423         (check_match): Likewise.
1424         (check_find_bounds_finds): Likewise.
1425         (test_mapped_index_find_name_component_bounds): Update.
1426         (CHECK_MATCH): Update.
1427         (dw2_expand_symtabs_matching): Update.
1428         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
1429         per_objfile parameter.
1430         <find_vec_in_debug_names>: Likewise.
1431         <m_per_objfile>: New field.
1432         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
1433         parameter.
1434         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
1435         (dw2_debug_names_iterator::next): Update.
1436         (dw2_debug_names_lookup_symbol): Update.
1437         (dw2_debug_names_expand_symtabs_for_function): Update.
1438         (dw2_debug_names_map_matching_symbols): Update.
1439         (dw2_debug_names_expand_symtabs_matching): Update.
1440         (dwarf2_read_debug_names): Update.
1441
1442 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1443
1444         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
1445         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
1446         move to dwarf2_per_objfile.
1447         <read_in_chain>: Remove.
1448         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
1449         remove_all_cus, age_comp_units>: New methods.
1450         <m_dwarf2_cus>: New member.
1451         (struct dwarf2_per_cu_data) <cu>: Remove.
1452         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
1453         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
1454         moved to methods of dwarf2_per_objfile.
1455         (dwarf2_clear_marks): Remove.
1456         (dwarf2_queue_item::~dwarf2_queue_item): Update.
1457         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
1458         (dwarf2_per_bfd::free_cached_comp_units): Remove.
1459         (dwarf2_per_objfile::remove_all_cus): New.
1460         (class free_cached_comp_units) <~free_cached_comp_units>:
1461         Update.
1462         (load_cu): Update.
1463         (dw2_do_instantiate_symtab): Adjust.
1464         (fill_in_sig_entry_from_dwo_entry): Adjust.
1465         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1466         (cutu_reader::cutu_reader): Likewise.
1467         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
1468         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
1469         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
1470         and dwarf2_per_objfile::age_comp_units.
1471         (load_partial_comp_unit): Update.
1472         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
1473         (process_queue): Likewise.
1474         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
1475         backlink.
1476         (dwarf2_read_addr_index): Likewise.
1477         (follow_die_offset): Likewise.
1478         (dwarf2_fetch_die_loc_sect_off): Likewise.
1479         (dwarf2_fetch_constant_bytes): Likewise.
1480         (dwarf2_fetch_die_type_sect_off): Likewise.
1481         (follow_die_sig_1): Likewise.
1482         (load_full_type_unit): Likewise.
1483         (read_signatured_type): Likewise.
1484         (dwarf2_cu::dwarf2_cu): Don't set cu field.
1485         (dwarf2_cu::~dwarf2_cu): Remove.
1486         (dwarf2_per_objfile::get_cu): New.
1487         (dwarf2_per_objfile::set_cu): New.
1488         (age_cached_comp_units): Rename to...
1489         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
1490         to std::unordered_map.
1491         (free_one_cached_comp_unit): Rename to...
1492         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
1493         to std::unordered_map.
1494         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
1495         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
1496         a dwarf2_per_objfile in data.
1497         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
1498         (dwarf2_clear_marks): Remove.
1499
1500 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1501
1502         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
1503         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
1504         (init_tu_and_read_dwo_dies): Likewise.
1505         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
1506         (cutu_reader::cutu_reader): Likewise.
1507         (load_partial_comp_unit): Likewise.
1508         (process_psymtab_comp_unit): Update.
1509         (build_type_psymtabs_1): Update.
1510         (process_skeletonless_type_unit): Update.
1511         (load_full_comp_unit): Update.
1512         (find_partial_die): Update.
1513         (dwarf2_read_addr_index): Update.
1514         (read_signatured_type): Update.
1515
1516 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1517
1518         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
1519         m_header_read_in>: New fields.
1520         <get_header>: New method.
1521         * dwarf2/read.c (per_cu_header_read_in): Remove.
1522         (dwarf2_per_cu_data::get_header): New.
1523         (dwarf2_per_cu_data::addr_size): Update.
1524         (dwarf2_per_cu_data::offset_size): Update.
1525         (dwarf2_per_cu_data::ref_addr_size): Update.
1526
1527 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1528
1529         * dwarf2/read.c (load_cu): Return dwarf2_cu.
1530         (dw2_do_instantiate_symtab): Update.
1531         (queue_and_load_all_dwo_tus): Change parameter from
1532         dwarf2_per_cu_data to dwarf2_cu.
1533         (dwarf2_fetch_die_loc_sect_off): Update.
1534         (dwarf2_fetch_constant_bytes): Update.
1535         (dwarf2_fetch_die_type_sect_off): Update.
1536
1537 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1538
1539         * dwarf2/read.c (process_full_comp_unit,
1540         process_full_type_unit): Remove per_cu, per_objfile paramters.
1541         Add dwarf2_cu parameter.
1542         (process_queue): Update.
1543
1544 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1545
1546         * dwarf2/read.c (create_cu_from_index_list): Replace
1547         dwarf2_per_objfile parameter with dwarf2_per_bfd.
1548         (create_cus_from_index_list): Likewise.
1549         (create_cus_from_index): Likewise.
1550         (create_signatured_type_table_from_index): Likewise.
1551         (create_cus_from_debug_names_list): Likewise.
1552         (create_cus_from_debug_names): Likewise.
1553         (dwarf2_read_gdb_index): Update.
1554         (dwarf2_read_debug_names): Update.
1555
1556 2020-05-27  Tom Tromey  <tom@tromey.com>
1557             Simon Marchi  <simon.marchi@efficios.com>
1558
1559         * dwarf2/read.h (struct dwarf2_per_objfile)
1560         <get_type_for_signatured_type, set_type_for_signatured_type>:
1561         New methods.
1562         <m_type_map>: New member.
1563         (struct signatured_type) <type>: Remove.
1564         * dwarf2/read.c
1565         (dwarf2_per_objfile::get_type_for_signatured_type,
1566         dwarf2_per_objfile::set_type_for_signatured_type): New.
1567         (get_signatured_type): Use new methods.
1568
1569 2020-05-27  Tom Tromey  <tom@tromey.com>
1570             Simon Marchi  <simon.marchi@efficios.com>
1571
1572         * dwarf2/read.h (struct type_unit_group_unshareable): New.
1573         (struct dwarf2_per_objfile) <type_units>: New member.
1574         <get_type_unit_group_unshareable>: New method.
1575         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
1576         num_symtabs, symtabs>: Remove; move to
1577         type_unit_group_unshareable.
1578         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
1579         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
1580         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
1581
1582 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1583
1584         * dwarf2/read.h (struct dwarf2_per_cu_data):
1585         <dwarf2_per_objfile>: Remove.
1586         * dwarf2/read.c (create_cu_from_index_list): Don't assign
1587         dwarf2_per_objfile.
1588         (create_signatured_type_table_from_index): Likewise.
1589         (create_signatured_type_table_from_debug_names): Likewise.
1590         (create_debug_type_hash_table): Likewise.
1591         (fill_in_sig_entry_from_dwo_entry): Likewise.
1592         (create_type_unit_group): Likewise.
1593         (read_comp_units_from_section): Likewise.
1594         (create_cus_hash_table): Likewise.
1595
1596 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1597
1598         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
1599         dwarf2_per_cu_data::dwarf2_per_objfile.
1600         (compute_compunit_symtab_includes): Likewise.
1601         (dwarf2_cu::start_symtab): Likewise.
1602
1603 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1604
1605         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
1606         parameter.
1607         * dwarf2/read.c (get_die_type_at_offset): Likewise.
1608         (read_namespace_alias): Update.
1609         (lookup_die_type): Update.
1610         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
1611         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
1612         Update.
1613         (disassemble_dwarf_expression): Update.
1614
1615 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1616
1617         * dwarf2/read.h (struct dwarf2_queue_item): Add
1618         dwarf2_per_objfile parameter, assign new parameter.
1619         <per_objfile>: New field.
1620         * dwarf2/read.c (free_one_cached_comp_unit): Add
1621         dwarf2_per_objfile parameter.
1622         (queue_comp_unit): Likewise.
1623         (dw2_do_instantiate_symtab): Update.
1624         (process_psymtab_comp_unit): Update.
1625         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
1626         (process_imported_unit_die): Update.
1627         (queue_and_load_dwo_tu): Update.
1628         (follow_die_offset): Update.
1629         (follow_die_sig_1): Update.
1630
1631 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1632
1633         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
1634         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
1635         (read_call_site_scope): Assign per_objfile.
1636         (dwarf2_per_cu_data::objfile): Remove.
1637         * gdbtypes.h (struct call_site) <per_objfile>: New member.
1638         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
1639         dwarf2_per_objfile parameter.
1640         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
1641         dwarf2_per_objfile parameter.
1642         (dwarf_expr_reg_to_entry_parameter): Add output
1643         dwarf2_per_objfile parameter.
1644         (locexpr_get_frame_base): Update.
1645         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
1646         <push_dwarf_reg_entry_value>: Update.
1647         <call_site_to_target_addr>: Update.
1648         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
1649         parameter.
1650         (value_of_dwarf_reg_entry): Update.
1651         (rw_pieced_value): Update.
1652         (indirect_synthetic_pointer): Update.
1653         (dwarf2_evaluate_property): Update.
1654         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
1655         parameter.
1656         (locexpr_read_variable): Update.
1657         (locexpr_get_symbol_read_needs): Update.
1658         (loclist_read_variable): Update.
1659
1660 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1661
1662         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
1663         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1664         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1665         parameter.
1666         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
1667         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1668         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1669         parameter.
1670         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
1671         sect_variable_value): Add dwarf2_per_objfile parameter.
1672         (class dwarf_evaluate_loc_desc) <dwarf_call,
1673         dwarf_variable_value>: Update.
1674         (fetch_const_value_from_synthetic_pointer): Add
1675         dwarf2_per_objfile parameter.
1676         (fetch_const_value_from_synthetic_pointer): Update.
1677         (coerced_pieced_ref): Update.
1678         (class symbol_needs_eval_context) <dwarf_call,
1679         dwarf_variable_value>: Update.
1680         (dwarf2_compile_expr_to_ax): Update.
1681
1682 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1683
1684         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
1685         parameter.
1686         (dwarf2_evaluate_loc_desc_full): Update.
1687
1688 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1689
1690         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
1691         parameter.
1692         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
1693         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
1694         dwarf2_per_objfile parameter.
1695         (decode_debug_loc_dwo_addresses): Likewise.
1696         (dwarf2_find_location_expression): Update.
1697         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
1698         (locexpr_describe_location_piece): Add dwarf2_per_objfile
1699         parameter.
1700         (disassemble_dwarf_expression): Add dwarf2_per_objfile
1701         parameter.
1702         (locexpr_describe_location_1): Likewise.
1703         (locexpr_describe_location): Update.
1704
1705 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1706
1707         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
1708         Remove.
1709         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
1710         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
1711         (dwarf2_compile_property_to_c): Update.
1712         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
1713         use text offset from objfile.
1714         (locexpr_tracepoint_var_ref): Update.
1715         (locexpr_generate_c_location): Update.
1716         (loclist_describe_location): Update.
1717         (loclist_tracepoint_var_ref): Update.
1718         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
1719         dwarf2_per_objfile parameter.
1720         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
1721         use text offset from objfile.
1722         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
1723
1724 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1725
1726         * dwarf2/expr.h (struct dwarf_expr_context)
1727         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
1728         <offset>: Remove.
1729         <per_objfile>: New member.
1730         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
1731         dwarf2_per_objfile parameter.  Don't set offset, set
1732         per_objfile.
1733         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
1734         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
1735         a dwarf2_per_objfile object instead of an offset.
1736         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
1737         constructor.
1738         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
1739         to dwarf2_expr_executor constructor.  Don't set offset.
1740         (dwarf2_fetch_cfa_info): Update.
1741         (struct dwarf2_frame_cache) <text_offset>: Remove.
1742         <per_objfile>: New field.
1743         (dwarf2_frame_cache): Update.
1744         (dwarf2_frame_prev_register): Update.
1745         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1746         <dwarf_evaluate_loc_desc>: Add constructor.
1747         (dwarf2_evaluate_loc_desc_full): Update.
1748         (dwarf2_locexpr_baton_eval): Update.
1749         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
1750         Add constructor.
1751         (dwarf2_loc_desc_get_symbol_read_needs): Update.
1752
1753 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1754
1755         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
1756         addr_sized_int_type>: Move to dwarf2_cu.
1757         <int_type>: Move to dwarf2_per_objfile.
1758         (struct dwarf2_per_objfile) <int_type>: Move here.
1759         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
1760         addr_sized_int_type>: Move here.
1761         (read_func_scope): Update.
1762         (read_array_type): Update.
1763         (read_tag_string_type): Update.
1764         (attr_to_dynamic_prop): Update.
1765         (dwarf2_per_cu_data::int_type): Rename to...
1766         (dwarf2_per_objfile::int_type): ... this.
1767         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
1768         (dwarf2_cu::addr_sized_int_type): ... this.
1769         (read_subrange_type): Update.
1770         (dwarf2_per_cu_data::addr_type): Rename to...
1771         (dwarf2_cu::addr_type): ... this.
1772         (set_die_type): Update.
1773
1774 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1775
1776         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
1777         data through per_cu->cu.
1778
1779 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1780
1781         * dwarf2/read.c (lookup_dwo_comp_unit): Change
1782         dwarf2_per_cu_data parameter fo dwarf2_cu.
1783         (lookup_dwo_type_unit): Likewise.
1784         (read_cutu_die_from_dwo): Likewise.
1785         (lookup_dwo_unit): Likewise.
1786         (open_and_init_dwo_file): Likewise.
1787         (lookup_dwo_cutu): Likewise.
1788         (lookup_dwo_comp_unit): Likewise.
1789         (lookup_dwo_type_unit): Likewise.
1790         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1791         (cutu_reader::cutu_reader): Update.
1792
1793 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1794
1795         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
1796         parameter.
1797         (process_full_type_unit): Likewise.
1798         (process_queue): Update.
1799
1800 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1801
1802         * dwarf2/read.c (recursively_compute_inclusions): Add
1803         dwarf2_per_objfile parameter.
1804         (compute_compunit_symtab_includes): Likewise.
1805         (process_cu_includes): Update.
1806
1807 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1808
1809         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
1810         parameter.
1811         (create_type_unit_group): Update.
1812         (process_psymtab_comp_unit_reader): Update.
1813         (build_type_psymtabs_reader): Update.
1814
1815 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1816
1817         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
1818         object through m_this_cu->cu.
1819
1820 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1821
1822         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
1823         the info parameter.
1824         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
1825
1826 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1827
1828         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
1829         per_objfile parameter.
1830         (load_full_type_unit): Add per_objfile parameter.
1831         (read_signatured_type): Likewise.
1832         (load_full_comp_unit): Likewise.
1833         (load_cu): Likewise.
1834         (dw2_do_instantiate_symtab): Likewise.
1835         (dw2_get_file_names): Likewise.
1836         (dw2_map_symtabs_matching_filename): Update.
1837         (dw_expand_symtabs_matching_file_matcher): Update.
1838         (dw2_map_symbol_filenames): Update.
1839         (process_psymtab_comp_unit): Add per_objfile parameter.
1840         (build_type_psymtabs_1): Update.
1841         (process_skeletonless_type_unit): Update.
1842         (dwarf2_build_psymtabs_hard): Update.
1843         (load_partial_comp_unit): Add per_objfile parameter.
1844         (scan_partial_symbols): Update.
1845         (load_full_comp_unit): Add per_objfile parameter.
1846         (process_imported_unit_die): Update.
1847         (create_cus_hash_table): Update.
1848         (find_partial_die): Update.
1849         (dwarf2_read_addr_index): Update.
1850         (follow_die_offset): Update.
1851         (dwarf2_fetch_die_loc_sect_off): Update.
1852         (dwarf2_fetch_constant_bytes): Update.
1853         (dwarf2_fetch_die_type_sect_off): Update.
1854         (follow_die_sig_1): Update.
1855         (load_full_type_unit): Add per_objfile parameter.
1856         (read_signatured_type): Likewise.
1857
1858 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1859
1860         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
1861         of objfile_name.
1862
1863 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1864
1865         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
1866         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1867         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
1868         field.
1869         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1870         (create_cus_from_index): Update.
1871         (dwarf2_read_gdb_index): Update.
1872         (create_cus_from_debug_names): Update.
1873         (dwarf2_read_debug_names): Update.
1874         (get_abbrev_section_for_cu): Update.
1875         (create_all_comp_units): Update.
1876         (read_attribute_value): Update.
1877         (get_debug_line_section): Update.
1878         * dwarf2/index-cache.c (index_cache::store): Update.
1879         * dwarf2/index-write.c (save_gdb_index_command): Update.
1880         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
1881
1882 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1883
1884         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
1885         member.
1886         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
1887         dwarf2_per_cu_data::per_bfd.
1888         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
1889         (create_type_unit_group): Likewise.
1890         (queue_comp_unit): Remove reference to
1891         per_cu->dwarf2_per_objfile.
1892         (maybe_queue_comp_unit): Likewise.
1893         (fill_in_sig_entry_from_dwo_entry): Assign new field.
1894         (create_cus_hash_table): Assign new field.
1895
1896 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1897
1898         * dwarf2/read.c: Replace
1899         dwarf2_cu->per_cu->dwarf2_per_objfile references with
1900         dwarf2_cu->per_objfile throughout.
1901
1902 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1903
1904         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
1905         parameter, don't use per_cu->dwarf2_per_objfile.
1906         (dw2_instantiate_symtab): Likewise.
1907         (dw2_find_last_source_symtab): Update.
1908         (dw2_map_expand_apply): Update.
1909         (dw2_lookup_symbol): Update.
1910         (dw2_expand_symtabs_for_function): Update.
1911         (dw2_expand_all_symtabs): Update.
1912         (dw2_expand_symtabs_with_fullname): Update.
1913         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
1914         don't use per_cu->dwarf2_per_objfile.
1915         (dw2_expand_marked_cus): Update.
1916         (dw2_find_pc_sect_compunit_symtab): Update.
1917         (dw2_debug_names_lookup_symbol): Update.
1918         (dw2_debug_names_expand_symtabs_for_function): Update.
1919         (dw2_debug_names_map_matching_symbols): Update.
1920         (dwarf2_psymtab::expand_psymtab): Update.
1921
1922 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1923
1924         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
1925         <per_objfile>: New member.
1926         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
1927         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
1928         call to dwarf2_cu.
1929         (cutu_reader::cutu_reader): Update.
1930         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
1931
1932 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1933
1934         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
1935         struct dwarf2_per_objfile.
1936         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
1937         dwarf2_per_bfd.
1938         * dwarf2/read.c (set_die_type): Update.
1939         (get_die_type_at_offset): Update.
1940
1941 2020-05-27  Tom Tromey  <tom@tromey.com>
1942             Simon Marchi  <simon.marchi@efficios.com>
1943
1944         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
1945         method.
1946         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
1947         get_symtab, set_symtab>: New methods.
1948         <m_symtabs>: New field.
1949         (struct dwarf2_psymtab): Derive from partial_symtab.
1950         <readin_p, get_compunit_symtab>: Declare methods.
1951         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
1952         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
1953         New methods.
1954         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
1955         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
1956         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
1957         (dw2_symtab_iter_next, dw2_print_stats)
1958         (dw2_expand_symtabs_with_fullname)
1959         (dw2_expand_symtabs_matching_one)
1960         (dw_expand_symtabs_matching_file_matcher)
1961         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
1962         (dw2_debug_names_iterator::next)
1963         (dw2_debug_names_map_matching_symbols)
1964         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
1965         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
1966         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
1967         New methods.
1968         (get_compunit_symtab, process_full_comp_unit)
1969         (process_full_type_unit): Update.
1970         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
1971
1972 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1973
1974         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
1975         then introduce a new dwarf2_per_objfile type.
1976         <read_line_string>: Move to the new dwarf2_per_objfile type.
1977         <objfile>: Likewise.
1978         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
1979         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
1980         dwarf2_per_objfile->per_bfd.
1981         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
1982         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
1983         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
1984         (dwarf2_per_bfd::free_cached_comp_units): ... this.
1985         (dwarf2_has_info): Allocate dwarf2_per_bfd.
1986         (dwarf2_per_objfile::locate_sections): Rename to...
1987         (dwarf2_per_bfd::locate_sections): ... this.
1988         (dwarf2_per_objfile::get_cutu): Rename to...
1989         (dwarf2_per_bfd::get_cutu): ... this.
1990         (dwarf2_per_objfile::get_cu): Rename to...
1991         (dwarf2_per_bfd::get_cu): ... this.
1992         (dwarf2_per_objfile::get_tu): Rename to...
1993         (dwarf2_per_bfd::get_tu): ... this.
1994         (dwarf2_per_objfile::allocate_per_cu): Rename to...
1995         (dwarf2_per_bfd::allocate_per_cu): ... this.
1996         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
1997         (dwarf2_per_bfd::allocate_signatured_type): ... this.
1998         (get_gdb_index_contents_ftype): Change parameter from
1999         dwarf2_per_objfile to dwarf2_per_bfd.
2000         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2001         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2002
2003 2020-05-27  Tom Tromey  <tom@tromey.com>
2004             Simon Marchi  <simon.marchi@efficios.com>
2005
2006         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2007         (allocate_piece_closure): Set "per_objfile" member.
2008         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2009         (locexpr_describe_location, loclist_describe_location): Use new
2010         member.
2011         * dwarf2/read.c (read_call_site_scope)
2012         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2013         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2014         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2015         handle_data_member_location): Set per_objfile member.
2016         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2017         member.
2018         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2019
2020 2020-05-27  Tom Tromey  <tom@tromey.com>
2021
2022         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2023         allocate_signatured_type>: Declare new methods.
2024         <m_num_psymtabs>: New member.
2025         (struct dwarf2_per_cu_data) <index>: New member.
2026         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2027         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2028         (create_cu_from_index_list): Use allocate_per_cu.
2029         (create_signatured_type_table_from_index)
2030         (create_signatured_type_table_from_debug_names)
2031         (create_debug_type_hash_table, add_type_unit)
2032         (read_comp_units_from_section): Use allocate_signatured_type.
2033
2034 2020-05-27  Tom Tromey  <tom@tromey.com>
2035
2036         * psymtab.c (partial_map_expand_apply)
2037         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2038         (psym_lookup_global_symbol_language)
2039         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2040         (psym_print_stats, psym_expand_symtabs_for_function)
2041         (psym_map_symbol_filenames, psym_map_matching_symbols)
2042         (psym_expand_symtabs_matching)
2043         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2044         (maintenance_check_psymtabs): Update.
2045         * psympriv.h (struct partial_symtab) <readin_p,
2046         get_compunit_symtab>: Add objfile parameter.
2047         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2048         Likewise.
2049         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2050         get_compunit_symtab>: Likewise.
2051         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2052
2053 2020-05-27  Tom Tromey  <tom@tromey.com>
2054
2055         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2056         member.
2057         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2058         (create_cu_from_index_list)
2059         (create_signatured_type_table_from_index)
2060         (create_signatured_type_table_from_debug_names)
2061         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2062         (dwarf2_create_include_psymtab)
2063         (create_debug_type_hash_table, add_type_unit)
2064         (create_type_unit_group, read_comp_units_from_section)
2065         (dwarf2_compute_name, create_cus_hash_table)
2066         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2067         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2068         obstack.
2069         (dw2_get_real_path): Likewise.  Change argument to
2070         dwarf2_per_objfile.
2071
2072 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2073
2074         PR tdep/26000
2075         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2076         for ldrd (immediate).
2077
2078 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2079
2080         * command.h: Add comment giving the name of class_tui.
2081         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2082         create the fake command for the help for class_tui.
2083
2084 2020-05-26  Tom Tromey  <tromey@adacore.com>
2085
2086         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2087         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2088         (val_atr): New function.
2089         (value_val_atr): Use it.
2090         * ada-valprint.c (print_optional_low_bound): Change low bound
2091         handling for enums.
2092         (val_print_packed_array_elements): Don't call discrete_position.
2093         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2094         discrete_position for enum types.
2095         * language.c (default_print_array_index): Change type.
2096         * language.h (struct language_defn) <la_print_array_index>: Add
2097         index_type parameter, change type of index_value.
2098         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2099         (default_print_array_index): Update.
2100         * valprint.c (maybe_print_array_index): Don't call
2101         value_from_longest.  Update.
2102         (value_print_array_elements): Don't call discrete_position.
2103
2104 2020-05-26  Tom Tromey  <tromey@adacore.com>
2105
2106         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2107         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2108
2109 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2110
2111         PR gdb/13519
2112         * avr-tdep.c (avr_integer_to_address): Return data or code
2113         address accordingly to the second 'type' argument of the
2114         function.
2115
2116 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2117
2118         * infcmd.c, inferior.h: (construct_inferior_arguments):
2119         Moved function from here to gdbsupport/common-inferior.{h,cc}
2120
2121 2020-05-23  Tom Tromey  <tom@tromey.com>
2122
2123         Revert commit eca1f90c:
2124         * NEWS: Remove entry for completion styling.
2125         * completer.c (_rl_completion_prefix_display_length): Move
2126         declaration later.
2127         (gdb_fnprint): Revert.
2128         (gdb_display_match_list_1): Likewise.
2129         * cli/cli-style.c (completion_prefix_style)
2130         (completion_difference_style, completion_suffix_style): Remove.
2131         (_initialize_cli_style): Revert.
2132         * cli/cli-style.h (completion_prefix_style)
2133         (completion_difference_style, completion_suffix_style): Don't
2134         declare.
2135
2136 2020-05-24  Pedro Alves  <palves@redhat.com>
2137
2138         * symtab.c (completion_list_add_name): Return boolean indication
2139         of whether the symbol matched.
2140         (completion_list_add_symbol): Don't try to remove C++ aliases if
2141         the symbol didn't match in the first place.
2142         * symtab.h (completion_list_add_name): Return bool.
2143
2144 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2145
2146         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2147         type::field.
2148
2149 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2150
2151         GDB 9.2 released.
2152
2153 2020-05-23  Tom Tromey  <tom@tromey.com>
2154
2155         * NEWS: Add entry for completion styling.
2156         * completer.c (_rl_completion_prefix_display_length): Move
2157         declaration earlier.
2158         (gdb_fnprint): Use completion_style.
2159         (gdb_display_match_list_1): Likewise.
2160         * cli/cli-style.c (completion_prefix_style)
2161         (completion_difference_style, completion_suffix_style): New
2162         globals.
2163         (_initialize_cli_style): Register new globals.
2164         * cli/cli-style.h (completion_prefix_style)
2165         (completion_difference_style, completion_suffix_style): Declare.
2166
2167 2020-05-23  Pedro Alves  <palves@redhat.com>
2168
2169         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2170         (parse_escape): Use ISDIGIT instead of isdigit.
2171         (puts_debug): Use gdb_isprint instead of isprint.
2172         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2173         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
2174         ISSPACE instead of isspace.
2175         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
2176         instead of isspace.
2177         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
2178         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
2179         instead of isxdigit and ISDIGIT instead of isdigit.
2180
2181 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2182
2183         * gdbtypes.h (struct type) <field>: New method.
2184         (TYPE_FIELDS): Remove, replace all uses with either type::fields
2185         or type::field.
2186
2187 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2188
2189         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
2190         (TYPE_FIELDS): Use type::fields.  Change all call sites that
2191         modify the propery to use type::set_fields instead.
2192
2193 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2194
2195         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
2196         type::num_fields instead.
2197
2198 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2199
2200         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
2201         methods.
2202         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
2203         that modify the number of fields to use type::set_num_fields
2204         instead.
2205
2206 2020-05-22  Tom Tromey  <tromey@adacore.com>
2207
2208         * compile/compile-object-load.h (munmap_list_free): Don't
2209         declare.
2210
2211 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2212
2213         * annotate.c (annotate_source_line): Update return type, add call
2214         to update current symtab and line.
2215         * annotate.h (annotate_source_line): Update return type, and
2216         extend header comment.
2217         * source.c (info_line_command): Check annotation_level before
2218         calling annotate_source_line.
2219         * stack.c (print_frame_info): If calling annotate_source_line
2220         returns true, then don't print any other source line information.
2221
2222 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2223
2224         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
2225
2226 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2227
2228         * coffread.c (patch_type): Remove NULL check before xfree.
2229         * corefile.c (set_gnutarget): Likewise.
2230         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
2231         * exec.c (build_section_table): Likewise.
2232         * remote.c (remote_target::pass_signals): Likewise.
2233         * utils.c (n_spaces): Likewise.
2234         * cli/cli-script.c (document_command): Likewise.
2235         * i386-windows-tdep.c (core_process_module_section): Likewise.
2236         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
2237
2238 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
2239
2240         * symfile.c (reread_symbols): Clear objfile's section_offsets
2241         vector and section indices, re-compute them by calling
2242         sym_offsets.
2243
2244 2020-05-20  Tom Tromey  <tromey@adacore.com>
2245
2246         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
2247         (desc_one_bound, desc_index_type): Compute field name.
2248
2249 2020-05-20  Tom de Vries  <tdevries@suse.de>
2250
2251         PR symtab/25833
2252         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
2253
2254 2020-05-20  Alan Modra  <amodra@gmail.com>
2255
2256         PR 25993
2257         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
2258         bfd_set_filename.
2259         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
2260         passed to bfd_set_filename.
2261         * symfile-mem.c (add_vsyscall_page): Likewise for string
2262         passed to symbol_file_add_from_memory.
2263         (symbol_file_add_from_memory): Make name param a const char* and
2264         don't strdup.
2265
2266 2020-05-20  Alan Modra  <amodra@gmail.com>
2267
2268         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
2269         rather than accessing bfd->filename directly.
2270         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
2271         and use bfd_section_name.
2272         * dwarf2/frame.c (decode_frame_entry): Likewise.
2273         * exec.c (exec_set_section_address): Likewise.
2274         * solib-aix.c (solib_aix_bfd_open): Likewise.
2275         * stap-probe.c (get_stap_base_address): Likewise.
2276         * symfile.c (reread_symbols): Likewise.
2277
2278 2020-05-19  Tom Tromey  <tromey@adacore.com>
2279
2280         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
2281
2282 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2283
2284         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
2285
2286 2020-05-19  Pedro Alves  <palves@redhat.com>
2287
2288         * NEWS (set exec-file-mismatch): Adjust entry.
2289         * exec.c: Include "build-id.h".
2290         (validate_exec_file): Try to match build IDs instead of filenames.
2291         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
2292         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
2293         and pass down 'warn_if_slow'.
2294         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
2295         gdb_bfd_open_closure to pass it down.
2296         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
2297
2298 2020-05-19  Pedro Alves  <palves@redhat.com>
2299
2300         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
2301         * target.c (target_fileio_open_1): Rename to target_fileio_open
2302         and make extern.  Use bool.
2303         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
2304         (target_fileio_read_alloc_1): Adjust.
2305         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
2306         (target_fileio_open_warn_if_slow): Delete declaration.
2307
2308 2020-05-19  Pedro Alves  <palves@redhat.com>
2309
2310         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
2311         Adjust all callers.
2312
2313 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
2314
2315         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
2316         whether disp is negative.
2317
2318 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2319
2320         * symfile.h (struct symfile_segment_data)
2321         <~symfile_segment_data>: Remove.
2322         <segment_info>: Change to std::vector.
2323         * symfile.c (default_symfile_segments): Update.
2324         * elfread.c (elf_symfile_segments): Update.
2325
2326 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2327
2328         * symfile.h (struct symfile_segment_data) <struct segment>: New.
2329         <segments>: New.
2330         <segment_bases, segment_sizes>: Remove.
2331         * symfile.c (default_symfile_segments): Update.
2332         * elfread.c (elf_symfile_segments): Update.
2333         * remote.c (remote_target::get_offsets): Update.
2334         * solib-target.c (solib_target_relocate_section_addresses):
2335         Update.
2336
2337 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2338
2339         * symfile.h (struct symfile_segment_data): Initialize fields.
2340         <~symfile_segment_data>: Add.
2341         (symfile_segment_data_up): New.
2342         (struct sym_fns) <sym_segments>: Return a
2343         symfile_segment_data_up.
2344         (default_symfile_segments): Return a symfile_segment_data_up.
2345         (free_symfile_segment_data): Remove.
2346         (get_symfile_segment_data): Return a symfile_segment_data_up.
2347         * symfile.c (default_symfile_segments): Likewise.
2348         (get_symfile_segment_data): Likewise.
2349         (free_symfile_segment_data): Remove.
2350         (symfile_find_segment_sections): Update.
2351         * elfread.c (elf_symfile_segments): Return a
2352         symfile_segment_data_up.
2353         * remote.c (remote_target::get_offsets): Update.
2354         * solib-target.c (solib_target_relocate_section_addresses):
2355         Update.
2356         * symfile-debug.c (debug_sym_segments): Return a
2357         symfile_segment_data_up.
2358
2359 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2360
2361         PR build/25981
2362         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
2363         Hardcode register numbers.
2364
2365         PR build/25981
2366         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
2367         procfs_find_LDT_entry): Remove.
2368         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
2369         procfs_find_LDT_entry): Remove.
2370         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
2371         Remove.
2372
2373 2020-05-17  Pedro Alves  <palves@redhat.com>
2374             Andrew Burgess  <andrew.burgess@embecosm.com>
2375             Keno Fischer  <keno@juliacomputing.com>
2376
2377         PR gdb/25741
2378         * breakpoint.c (build_target_condition_list): Update comments.
2379         (build_target_command_list): Update comments and skip matching
2380         locations.
2381         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
2382         a separate function.  Simplify "set breakpoint auto-hw off"
2383         handling.
2384         (insert_breakpoints): Update comment.
2385         (tracepoint_locations_match): New parameter.  For breakpoints,
2386         compare location types too, if the caller wants to.
2387         (handle_automatic_hardware_breakpoints): New functions.
2388         (bp_location_is_less_than): Also sort by location type and
2389         hardware breakpoint length.
2390         (update_global_location_list): Handle "set breakpoint auto-hw on"
2391         here.
2392         (update_breakpoint_locations): Ask breakpoint_locations_match to
2393         ignore location types.
2394
2395 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2396
2397         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
2398         type::name instead.
2399
2400 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2401
2402         * gdbtypes.h (struct type) <name, set_name>: New methods.
2403         (TYPE_CODE): Use type::name.  Change all call sites used to set
2404         the name to use type::set_name instead.
2405
2406 2020-05-16  Tom Tromey  <tom@tromey.com>
2407
2408         * top.c (quit_force): Update.
2409         * infrun.c (handle_no_resumed): Update.
2410         * top.h (all_uis): New function.
2411         (ALL_UIS): Remove.
2412
2413 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2414
2415         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
2416
2417 2020-05-16  Pedro Alves  <palves@redhat.com>
2418
2419         * ia64-linux-nat.c
2420         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
2421         Declare method.
2422         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
2423
2424 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
2425
2426         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
2427         (sparc64_adi_info): Likewise.
2428
2429 2020-05-15  Tom Tromey  <tom@tromey.com>
2430
2431         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
2432         block_objfile.
2433         (lookup_objfile_from_block): Remove.
2434         (lookup_symbol_in_block, lookup_symbol_in_static_block)
2435         (lookup_global_symbol): Use block_objfile.
2436         * symtab.h (lookup_objfile_from_block): Don't declare.
2437         * printcmd.c (clear_dangling_display_expressions): Use
2438         block_objfile.
2439         * parse.c (operator_check_standard): Use block_objfile.
2440
2441 2020-05-15  Tom Tromey  <tom@tromey.com>
2442
2443         * language.c (language_alloc_type_symbol): Set
2444         SYMBOL_SECTION.
2445         * symtab.c (initialize_objfile_symbol): Remove.
2446         (allocate_symbol): Remove.
2447         (allocate_template_symbol): Remove.
2448         * dwarf2/read.c (fixup_go_packaging): Use "new".
2449         (new_symbol): Use "new".
2450         (read_variable): Don't call initialize_objfile_symbol.  Use
2451         "new".
2452         (read_func_scope): Use "new".
2453         * xcoffread.c (process_xcoff_symbol): Don't call
2454         initialize_objfile_symbol.
2455         (SYMBOL_DUP): Remove.
2456         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
2457         "new".
2458         * symtab.h (allocate_symbol, initialize_objfile_symbol)
2459         (allocate_template_symbol): Don't declare.
2460         (struct symbol): Add copy constructor.  Change defaults.
2461         * jit.c (finalize_symtab): Use "new".
2462         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
2463         Use "new".
2464         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
2465         (common_block_end): Use "new".
2466         * mdebugread.c (parse_symbol): Use "new".
2467         (new_symbol): Likewise.
2468
2469 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2470
2471         * NEWS: Mention changes to help and apropos.
2472
2473 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2474
2475         * command.h (enum command_class): Improve comments, document
2476         that class_alias is for user-defined aliases, give the class
2477         name for each class, remove unused class_xdb.
2478         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
2479         * breakpoint.c (_initialize_breakpoint): Replace class_alias
2480         by a precise class.
2481         * infcmd.c (_initialize_infcmd): Likewise.
2482         * reverse.c (_initialize_reverse): Likewise.
2483         * stack.c (_initialize_stack): Likewise.
2484         * symfile.c (_initialize_symfile): Likewise.
2485         * tracepoint.c (_initialize_tracepoint): Likewise.
2486
2487 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2488
2489         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
2490         when their aliased command is traversed.
2491         (help_cmd): Add fput_command_names_styled call to
2492         output command name and aliases when command has an alias.
2493
2494 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2495
2496         * cli/cli-decode.h (help_cmd_list): Remove declaration.
2497         * cli/cli-decode.c (help_cmd_list): Declare as static,
2498         remove prefix argument, use bool for recurse arg, rework to show the aliases of
2499         a command together with the command.
2500         (fput_command_name_styled, fput_command_names_styled): New functions.
2501         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
2502         fput_command_name_styled.
2503         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
2504         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
2505
2506 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2507
2508         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
2509         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
2510         * command.h (cmd_show_list): Likewise.
2511         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
2512         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
2513
2514 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2515
2516         * unittests/command-def-selftests.c (traverse_command_structure):
2517         Verify all commands of a list have the same prefix command and
2518         that only the top cmdlist commands have a null prefix.
2519
2520 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2521
2522         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
2523         as prefix, not one of its aliases.
2524         (set_cmd_prefix): Remove.
2525         (do_add_cmd): Centralize the setting of the prefix of a command, when
2526         command is defined after its full chain of prefix commands.
2527         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
2528         (add_setshow_cmd_full): Likewise.
2529         (update_prefix_field_of_prefixed_commands): New function.
2530         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
2531         update_prefix_field_of_prefixed_commands.
2532         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
2533         addresses of remote_set_cmdlist and remote_show_cmdlist given
2534         as argument, not the address of an argument.
2535         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
2536         * gdb/remote.c (_initialize_remote): Likewise.
2537
2538 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2539
2540         * cli/cli-cmds.c (alias_command): Check for an existing alias
2541         using lookup_cmd_composition, as valid_command_p is too strict
2542         and forbids aliases that are the prefix of an existing alias
2543         or command.
2544         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
2545         command is properly recognised as a valid command.
2546
2547 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2548
2549         * unittests/help-doc-selftests.c: Rename to
2550         unittests/command-def-selftests.c
2551         * unittests/command-def-selftests.c (help_doc_tests): Update some
2552         comments.
2553         (command_structure_tests, traverse_command_structure): New namespace
2554         and function.
2555         (command_structure_invariants_tests): New function.
2556         (_initialize_command_def_selftests) Renamed from
2557         _initialize_help_doc_selftests, register command_structure_invariants
2558         selftest.
2559
2560 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2561
2562         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
2563         an alias of 'show'.
2564
2565 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
2566
2567         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
2568         ada_is_fixed_point_type.  Update all callers.
2569         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
2570         all callers.
2571         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
2572         Update all callers.
2573         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
2574         print_fixed_point_type.  Update all callers.
2575         * ada-valprint.c (ada_value_print_num): Replace call to
2576         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
2577
2578 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
2579
2580         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
2581         processors.
2582         (cpu_supports_bts): Add CV_AMD case.
2583
2584 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
2585             Simon Marchi  <simon.marchi@efficios.com>
2586
2587         * infrun.c (stop_all_threads): Collect multiple wait events at
2588         each pass.
2589
2590 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2591
2592         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
2593         type::code instead.
2594
2595 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2596
2597         * gdbtypes.h (struct type) <code, set_code>: New methods.
2598         (TYPE_CODE): Use type::code.  Change all call sites used to set
2599         the code to use type::set_code instead.
2600
2601 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2602             Tom de Vries  <tdevries@suse.de>
2603             Pedro Alves  <palves@redhat.com>
2604
2605         PR threads/25478
2606         * infrun.c (stop_all_threads): Do NOT ignore
2607         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
2608         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
2609         received.
2610         (handle_no_resumed): Remove code handling a live inferior with no
2611         threads.
2612         * remote.c (has_single_non_exited_thread): New.
2613         (remote_target::update_thread_list): Do not delete a thread if is
2614         the last thread of the process.
2615         * thread.c (thread_select): Call delete_exited_threads instead of
2616         prune_threads.
2617
2618 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2619
2620         * infrun.c (stop_all_threads): Enable/disable thread events of all
2621         targets.  Move a debug message denoting the end of the function
2622         into the SCOPED_EXIT block.
2623
2624 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2625
2626         * process-stratum-target.h: Include <set>.
2627         (all_non_exited_process_targets, switch_to_target_no_thread): New
2628         function declarations.
2629         * process-stratum-target.c (all_non_exited_process_targets)
2630         (switch_to_target_no_thread): New function implementations.
2631
2632 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2633
2634         * infrun.c (handle_inferior_event): Extract out a piece of code
2635         into...
2636         (mark_non_executing_threads): ...this new function.
2637
2638 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2639
2640         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
2641         use.
2642
2643 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2644
2645         * regcache.c (regcache_read_pc_protected): New function
2646         implementation that returns 0 if the PC cannot read via
2647         'regcache_read_pc'.
2648         * infrun.c (proceed): Call 'regcache_read_pc_protected'
2649         instead of 'regcache_read_pc'.
2650         (keep_going_pass_signal): Ditto.
2651
2652 2020-05-13  Tom Tromey  <tromey@adacore.com>
2653
2654         * ada-lang.c (align_value): Remove.
2655         (ada_template_to_fixed_record_type_1): Use align_up.
2656
2657 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2658
2659         * async-event.c: Update the copyright year.
2660         * async-event.h: Update the copyright year.
2661
2662 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
2663
2664         * objfiles.h (is_addr_in_objfile,
2665         shared_objfile_contains_address_p): Return bool.
2666         * objfile.c (is_addr_in_objfile,
2667         shared_objfile_contains_address_p): Return bool.
2668
2669 2020-05-11  Tom Tromey  <tromey@adacore.com>
2670
2671         * cli/cli-cmds.c (info_command): Restore.
2672         (_initialize_cli_cmds): Use add_prefix_command for "info".
2673         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
2674
2675 2020-05-11  Tom Tromey  <tromey@adacore.com>
2676
2677         * ada-lang.c (ada_value_primitive_field): Now public.
2678         * ada-lang.h (ada_value_primitive_field): Declare.
2679         * ada-valprint.c (print_field_values): Use
2680         ada_value_primitive_field for wrapper fields.
2681
2682 2020-05-11  Tom de Vries  <tdevries@suse.de>
2683
2684         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
2685         MODULE_DOMAIN.
2686
2687 2020-05-11  Tom de Vries  <tdevries@suse.de>
2688
2689         PR symtab/25941
2690         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
2691         with length 0, if not gdb-produced.
2692         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
2693
2694 2020-05-09  Tom de Vries  <tdevries@suse.de>
2695
2696         PR gdb/25955
2697         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
2698         calculation.
2699
2700 2020-05-09  Tom Tromey  <tom@tromey.com>
2701
2702         * top.c (server_command): Now bool.
2703         * top.h (server_command): Now bool.
2704
2705 2020-05-08  Tom Tromey  <tromey@adacore.com>
2706
2707         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
2708         already being processed.
2709
2710 2020-05-08  Tom Tromey  <tom@tromey.com>
2711
2712         * printcmd.c (struct display) <next>: Remove.
2713         <display>: New constructor.
2714         <exp_string>: Now a std::string.
2715         <enabled_p>: Now a bool.
2716         (display_number): Move definition earlier.
2717         (displays): Rename from display_chain.  Now a std::vector.
2718         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
2719         (display_command): Update.
2720         (do_one_display, disable_display)
2721         (enable_disable_display_command, do_enable_disable_display):
2722         Update.
2723         (free_display): Remove.
2724         (clear_displays): Rewrite.
2725         (delete_display): Update.
2726         (map_display_numbers): Use function_view.  Remove "data"
2727         parameter.  Update.
2728         (do_delete_display): Remove.
2729         (undisplay_command): Update.
2730         (do_one_display, do_displays, disable_display)
2731         (info_display_command): Update.
2732         (do_enable_disable_display): Remove.
2733         (enable_disable_display_command)
2734         (clear_dangling_display_expressions): Update.
2735
2736 2020-05-08  Tom Tromey  <tom@tromey.com>
2737
2738         * symtab.c (set_symbol_cache_size)
2739         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
2740         (maintenance_print_symbol_cache_statistics): Update.
2741         * symmisc.c (print_symbol_bcache_statistics)
2742         (print_objfile_statistics, maintenance_print_objfiles)
2743         (maintenance_info_symtabs, maintenance_check_symtabs)
2744         (maintenance_expand_symtabs, maintenance_info_line_tables):
2745         Update.
2746         * symfile-debug.c (set_debug_symfile): Update.
2747         * source.c (forget_cached_source_info): Update.
2748         * python/python.c (gdbpy_progspaces): Update.
2749         * psymtab.c (maintenance_info_psymtabs): Update.
2750         * probe.c (parse_probes): Update.
2751         * linespec.c (iterate_over_all_matching_symtabs)
2752         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
2753         * guile/scm-progspace.c (gdbscm_progspaces): Update.
2754         * exec.c (exec_target::close): Update.
2755         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
2756         * breakpoint.c (print_one_breakpoint_location)
2757         (create_longjmp_master_breakpoint)
2758         (create_std_terminate_master_breakpoint): Update.
2759         * progspace.c (program_spaces): Now a std::vector.
2760         (maybe_new_address_space): Update.
2761         (add_program_space): Remove.
2762         (program_space::program_space): Update.
2763         (remove_program_space): Update.
2764         (number_of_program_spaces): Remove.
2765         (print_program_space, update_address_spaces): Update.
2766         * progspace.h (program_spaces): Change type.
2767         (ALL_PSPACES): Remove.
2768         (number_of_program_spaces): Don't declare.
2769         (struct program_space) <next>: Remove.
2770
2771 2020-05-08  Tom Tromey  <tom@tromey.com>
2772
2773         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
2774         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
2775         (enable_break): Update.
2776         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
2777         (frv_fdpic_find_canonical_descriptor): Update.
2778         (frv_fetch_objfile_link_map): Update.
2779         * progspace.c (program_space::free_all_objfiles): Update.
2780         (program_space::solibs): New method.
2781         * progspace.h (struct program_space) <solibs>: New method.
2782         * solist.h (master_so_list): Don't declare.
2783         (ALL_SO_LIBS): Remove.
2784         * solib.h (so_list_head): Remove.
2785         (update_solib_list): Update comment.
2786         * solib.c (master_so_list): Remove.
2787         (solib_used, update_solib_list, solib_add)
2788         (info_sharedlibrary_command, clear_solib)
2789         (reload_shared_libraries_1, remove_user_added_objfile): Update.
2790
2791 2020-05-08  Tom Tromey  <tom@tromey.com>
2792
2793         * extension.c (extension_languages): Now a std::array.
2794         (ALL_EXTENSION_LANGUAGES): Remove.
2795         (get_ext_lang_defn, get_ext_lang_of_file)
2796         (eval_ext_lang_from_control_command): Update.
2797         (finish_ext_lang_initialization)
2798         (auto_load_ext_lang_scripts_for_objfile)
2799         (ext_lang_type_printers::ext_lang_type_printers)
2800         (apply_ext_lang_type_printers)
2801         (ext_lang_type_printers::~ext_lang_type_printers)
2802         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
2803         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
2804         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
2805         (get_matching_xmethod_workers, ext_lang_colorize)
2806         (ext_lang_before_prompt): Update.
2807         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
2808
2809 2020-05-08  Tom Tromey  <tom@tromey.com>
2810
2811         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
2812         overload.
2813         <swap_string, m_string>: Remove.
2814         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
2815         Update.
2816         * stabsread.c (define_symbol, read_type): Update.
2817         * linespec.c (find_linespec_symbols): Update.
2818         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
2819         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
2820         * dbxread.c (read_dbx_symtab): Update.
2821         * cp-support.h (cp_canonicalize_string_full)
2822         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
2823         Return unique_xmalloc_ptr.
2824         * cp-support.c (inspect_type): Update.
2825         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
2826         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
2827         Likewise.
2828         * c-typeprint.c (print_name_maybe_canonical): Update.
2829         * break-catch-throw.c (check_status_exception_catchpoint):
2830         Update.
2831
2832 2020-05-08  Tom de Vries  <tdevries@suse.de>
2833
2834         * infrun.c (follow_fork): Copy current_line and current_symtab to
2835         child thread.
2836
2837 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2838
2839         * async-event.c (struct async_signal_handler, struct
2840         async_event_handler): Reformat, remove typedef.
2841
2842 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2843
2844         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
2845         access thistype->main_type->dyn_prop_list directly.
2846
2847 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2848
2849         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
2850         (remove_dyn_prop): Remove.  Update all users to use
2851         type::remove_dyn_prop.
2852         * gdbtypes.c (remove_dyn_prop): Rename to...
2853         (type::remove_dyn_prop): ... this.
2854
2855 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
2856
2857         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
2858         (add_dyn_prop): Remove.  Update all users to use
2859         type::add_dyn_prop.
2860         * gdbtypes.c (add_dyn_prop): Rename to...
2861         (type::add_dyn_prop): ... this.
2862
2863 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2864
2865         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
2866         (get_dyn_prop): Remove.  Update all users to use
2867         type::dyn_prop.
2868         * gdbtypes.c (get_dyn_prop): Rename to...
2869         (type::dyn_prop): ... this.
2870
2871 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2872
2873         * gdbtypes.h (struct main_type) <flag_static>: Remove.
2874
2875 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2876
2877         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
2878         instruction, skip it if it's there.
2879
2880 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
2881
2882         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
2883
2884 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
2885
2886         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
2887         * gdbtypes.c (recursive_dump_type): Remove use of
2888         TYPE_INCOMPLETE.
2889
2890 2020-05-03  Tom Tromey  <tom@tromey.com>
2891
2892         * breakpoint.c (catch_command, tcatch_command): Remove.
2893         (_initialize_breakpoint): Use add_basic_prefix_cmd,
2894         add_show_prefix_cmd.
2895         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
2896         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
2897         Remove.
2898         (add_internal_problem_command): Use add_basic_prefix_cmd,
2899         add_show_prefix_cmd.
2900         * mips-tdep.c (set_mipsfpu_command): Remove.
2901         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
2902         * dwarf2/index-cache.c (set_index_cache_command): Remove.
2903         (_initialize_index_cache): Use add_basic_prefix_cmd.
2904         * memattr.c (dummy_cmd): Remove.
2905         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
2906         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
2907         (_initialize_tui_win): Use add_basic_prefix_cmd,
2908         add_show_prefix_cmd.
2909         * cli/cli-logging.c (set_logging_command): Remove.
2910         (_initialize_cli_logging): Use add_basic_prefix_cmd,
2911         add_show_prefix_cmd.
2912         (show_logging_command): Remove.
2913         * target.c (target_command): Remove.
2914         (add_target): Use add_basic_prefix_cmd.
2915
2916 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
2917
2918         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
2919
2920 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2921
2922         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
2923         info_command.
2924
2925 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
2926
2927         * nbsd-nat.c (nbsd_enable_proc_events)
2928         (nbsd_nat_target::post_startup_inferior): Add.
2929         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
2930         (nbsd_nat_target::update_thread_list): Rewrite.
2931         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
2932         "PTRACE_LWP_CREATE".
2933         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
2934
2935 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2936
2937         * stack.c (_initialize_stack): Remove duplicated creation
2938         of "frame" command and "f" alias.
2939
2940 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2941
2942         PR gdb/18706
2943         * gdbtypes.c (check_typedef): Calculate size of array of
2944         stubbed type.
2945
2946 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2947
2948         PR gdb/15559
2949         * i386-tdep.c (i386_push_dummy_call): Call
2950         i386_thiscall_push_dummy_call.
2951         (i386_thiscall_push_dummy_call): New function.
2952         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
2953         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
2954         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
2955
2956 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2957
2958         * gdbarch.sh (do_read): Add shellcheck disable directive for
2959         warning SC2162.
2960
2961 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2962
2963         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
2964         "referenced but not assigned" warning.
2965
2966 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2967
2968         * gdbarch.sh: Remove code that sets fallbackdefault.
2969
2970 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2971
2972         * gdbarch.sh: Use shell operators && and || instead of
2973         -a and -o.
2974
2975 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2976
2977         * gdbarch.sh: Use $(...) instead of `...`.
2978
2979 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2980
2981         * gdbarch.sh: Use double quotes around variables.
2982
2983 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
2984
2985         * gdbarch.sh: Use %s with printf, instead of variables in the
2986         format string.
2987
2988 2020-04-29  Tom Tromey  <tromey@adacore.com>
2989
2990         PR ada/25875:
2991         * dwarf2/read.c (update_enumeration_type_from_children): Compute
2992         type fields here.
2993         (read_enumeration_type): Call
2994         update_enumeration_type_from_children later.  Update comments.
2995         (process_enumeration_scope): Don't create type fields.
2996
2997 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
2998
2999         * nbsd-tdep.c: Include "xml-syscall.h".
3000         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3001
3002 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3003
3004         * nbsd-nat.c: Include "sys/wait.h".
3005         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3006         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3007         (nbsd_nat_target::remove_exec_catchpoint)
3008         (nbsd_nat_target::set_syscall_catchpoint): Add.
3009         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3010         (nbsd_nat_target::insert_exec_catchpoint)
3011         (nbsd_nat_target::remove_exec_catchpoint)
3012         (nbsd_nat_target::set_syscall_catchpoint): Add.
3013         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3014         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3015         `nbsd_get_syscall_number'.
3016
3017 2020-04-29  Tom Tromey  <tom@tromey.com>
3018
3019         * stack.c (print_block_frame_labels): Remove.
3020
3021 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3022
3023         PR gdb/17320
3024         * ada-valprint.c (val_print_packed_array_elements): Move array
3025         end bracket to new line.
3026         (ada_val_print_string): Remove extra spaces before first array
3027         element.
3028         * c-valprint.c (c_value_print_array): Likewise.
3029         * m2-valprint.c (m2_print_array_contents): Likewise.
3030         (m2_value_print_inner): Likewise.
3031         * p-valprint.c (pascal_value_print_inner): Likewise.
3032         * valprint.c (generic_val_print_array): Likewise.
3033         (value_print_array_elements): Move first array element and array
3034         end bracket to new line.
3035
3036 2020-04-29  Tom de Vries  <tdevries@suse.de>
3037
3038         PR symtab/25889
3039         * linespec.c (find_method): Fix ix calculation.
3040
3041 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3042
3043         * syscalls/update-netbsd.sh: New file.
3044         * syscalls/netbsd.xml: Regenerate.
3045         * data-directory/Makefile.in: Register `netbsd.xml' in
3046         `SYSCALLS_FILES'.
3047
3048 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3049
3050         * syscalls/update-freebsd.sh: Add double quotes.
3051
3052 2020-04-28  Tom Tromey  <tom@tromey.com>
3053
3054         * NEWS: Update.
3055         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3056         (cmdpy_init): Allow class_tui.
3057
3058 2020-04-28 Mark Williams <mark@myosotissp.com>
3059
3060         PR gdb/24480
3061         * dwarf2read.c: Add missing assingments to list_in_scope when
3062         start_symtab was already called.
3063
3064 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3065
3066         PR gdb/25881
3067         * dwarf2/read.c (offset_map_type): Use
3068         gdb:hash_enum<sect_offset> as hash function.
3069
3070 2020-04-28  Tom de Vries  <tdevries@suse.de>
3071
3072         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3073         with DW_AT_signature.
3074
3075 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3076
3077         * configure.ac: Remove check for fs_base/gs_base in
3078         user_regs_struct.
3079         * configure: Re-generate.
3080         * config.in: Re-generate.
3081         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3082         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3083         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3084
3085 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3086
3087         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3088         problematic inline frame unwinding situation.
3089         * frame.c (frame_id_computed_p): New function.
3090         * frame.h (frame_id_computed_p): New prototype.
3091
3092 2020-04-26  Tom Tromey  <tom@tromey.com>
3093
3094         * command.h (enum command_class) <class_pseudo>: Remove.
3095
3096 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3097
3098         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3099         and whitespace.
3100
3101 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3102
3103         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3104         `PT_GET_PROCESS_STATE' block.
3105
3106 2020-04-24  Tom Tromey  <tom@tromey.com>
3107
3108         * symtab.h (symbol_get_demangled_name): Don't declare.
3109         * symtab.c (symbol_get_demangled_name): Remove.
3110         (general_symbol_info::natural_name)
3111         (general_symbol_info::demangled_name): Update.
3112
3113 2020-04-24  Tom Tromey  <tom@tromey.com>
3114
3115         PR rust/25025:
3116         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3117
3118 2020-04-24  Tom Tromey  <tom@tromey.com>
3119
3120         PR symtab/12707:
3121         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3122         exists.
3123         (new_symbol): Likewise.
3124         * compile/compile-object-load.c (get_out_value_type): Use
3125         symbol_matches_search_name.
3126
3127 2020-04-24  Tom Tromey  <tom@tromey.com>
3128
3129         * dwarf2/read.c (add_partial_symbol): Do not call
3130         compute_and_set_names.
3131
3132 2020-04-24  Tom Tromey  <tom@tromey.com>
3133
3134         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3135         overload.
3136
3137 2020-04-24  Tom Tromey  <tom@tromey.com>
3138
3139         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3140         (add_psymbol_to_list): New overload.  Make old overload call new
3141         one.
3142         * psympriv.h (add_psymbol_to_list): New overload.
3143
3144 2020-04-24  Tom Tromey  <tom@tromey.com>
3145
3146         * dwarf2/read.c (partial_die_info::read) <case
3147         DW_AT_linkage_name>: Use value_as_string.
3148         (dwarf2_string_attr): Use value_as_string.
3149         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3150         method.
3151         * dwarf2/attribute.c (attribute::value_as_string): New method.
3152
3153 2020-04-24  Tom Tromey  <tom@tromey.com>
3154
3155         * symtab.c (general_symbol_info::natural_name)
3156         (general_symbol_info::demangled_name): Check for language_rust.
3157
3158 2020-04-24  Tom Tromey  <tom@tromey.com>
3159
3160         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3161         (dwarf2_physname): ... from here.
3162         (partial_die_info::read): Add Rust "{" hack.
3163
3164 2020-04-24  Tom Tromey  <tom@tromey.com>
3165
3166         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3167         method.
3168         (symbol_set_demangled_name): Don't declare.
3169         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3170         symbol_set_demangled_name.
3171         (general_symbol_info::set_language)
3172         (general_symbol_info::compute_and_set_names): Update.
3173         * minsyms.c (minimal_symbol_reader::install): Update.
3174         * dwarf2/read.c (new_symbol): Update.
3175
3176 2020-04-24  Tom Tromey  <tromey@adacore.com>
3177
3178         PR python/23662:
3179         * python/py-type.c (convert_field): Handle
3180         FIELD_LOC_KIND_DWARF_BLOCK.
3181         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
3182         (typy_get_dynamic): Nw function.
3183         (type_object_getset): Add "dynamic".
3184         * NEWS: Add entry.
3185
3186 2020-04-24  Tom Tromey  <tromey@adacore.com>
3187
3188         * ada-typeprint.c (print_choices, print_variant_part)
3189         (print_record_field_types_dynamic): New functions.
3190         (print_record_field_types): Use print_record_field_types_dynamic.
3191
3192 2020-04-24  Tom Tromey  <tromey@adacore.com>
3193
3194         * dwarf2/read.c (handle_data_member_location): New overload.
3195         (dwarf2_add_field): Use it.
3196         (decode_locdesc): Add "computed" parameter.  Update comment.
3197         * gdbtypes.c (is_dynamic_type_internal): Also look for
3198         FIELD_LOC_KIND_DWARF_BLOCK.
3199         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
3200         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
3201         virtual base classes.
3202         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
3203         FIELD_LOC_KIND_DWARF_BLOCK.
3204
3205 2020-04-24  Tom Tromey  <tromey@adacore.com>
3206
3207         * dwarf2/read.c (read_structure_type): Handle dynamic length.
3208         * gdbtypes.c (is_dynamic_type_internal): Check
3209         TYPE_HAS_DYNAMIC_LENGTH.
3210         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
3211         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
3212         New macros.
3213         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
3214         constant.
3215
3216 2020-04-24  Tom Tromey  <tromey@adacore.com>
3217
3218         * dwarf2/read.c (struct variant_field): Rewrite.
3219         (struct variant_part_builder): New.
3220         (struct nextfield): Remove "variant" field.  Add "offset".
3221         (struct field_info): Add "current_variant_part" and
3222         "variant_parts".
3223         (alloc_discriminant_info): Remove.
3224         (alloc_rust_variant): New function.
3225         (quirk_rust_enum): Update.
3226         (dwarf2_add_field): Set "offset" member.  Don't handle
3227         DW_TAG_variant_part.
3228         (offset_map_type): New typedef.
3229         (convert_variant_range, create_one_variant)
3230         (create_one_variant_part, create_variant_parts)
3231         (add_variant_property): New functions.
3232         (dwarf2_attach_fields_to_type): Call add_variant_property.
3233         (read_structure_type): Don't handle DW_TAG_variant_part.
3234         (handle_variant_part, handle_variant): New functions.
3235         (handle_struct_member_die): Use them.
3236         (process_structure_scope): Don't handle variant parts.
3237         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
3238         (struct discriminant_info): Remove.
3239         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
3240         (struct main_type) <flag_discriminated_union>: Remove.
3241         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
3242         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
3243         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
3244         Update.
3245         * valops.c (value_union_variant): Remove.
3246         * value.h (value_union_variant): Don't declare.
3247
3248 2020-04-24  Tom Tromey  <tromey@adacore.com>
3249
3250         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
3251         (ada_value_primitive_packed_val): Update.
3252         * ada-valprint.c (ada_value_print_1): Update.
3253         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
3254         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
3255         just an address.  Use evaluate_for_locexpr_baton.
3256         (dwarf2_evaluate_property): Update.
3257         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
3258         array_view.
3259         * findvar.c (default_read_var_value): Update.
3260         * gdbtypes.c (compute_variant_fields_inner)
3261         (resolve_dynamic_type_internal): Update.
3262         (resolve_dynamic_type): Change type of valaddr parameter.
3263         * gdbtypes.h (resolve_dynamic_type): Update.
3264         * valarith.c (value_subscripted_rvalue): Update.
3265         * value.c (value_from_contents_and_address): Update.
3266
3267 2020-04-24  Tom Tromey  <tromey@adacore.com>
3268
3269         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
3270         "push_initial_value" parameter.
3271         (dwarf2_evaluate_property): Likewise.
3272         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
3273
3274 2020-04-24  Tom Tromey  <tromey@adacore.com>
3275
3276         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
3277         (variant::matches, compute_variant_fields_recurse)
3278         (compute_variant_fields_inner, compute_variant_fields): New
3279         functions.
3280         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
3281         Use resolved_type after type is made.
3282         (operator==): Add new cases.
3283         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
3284         (struct discriminant_range, struct variant, struct variant_part):
3285         New.
3286         (union dynamic_prop_data) <variant_parts, original_type>: New
3287         members.
3288         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
3289         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
3290         constants.
3291         * value.c (unpack_bits_as_long): Now public.
3292         * value.h (unpack_bits_as_long): Declare.
3293
3294 2020-04-24  Tom Tromey  <tromey@adacore.com>
3295
3296         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
3297         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
3298
3299 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
3300
3301         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
3302
3303 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
3304
3305         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
3306         (remove_fork_catchpoint, post_startup_inferior)
3307         (post_attach): Move...
3308         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
3309         (remove_fork_catchpoint, post_startup_inferior)
3310         (post_attach): ...here.
3311         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
3312         (remove_fork_catchpoint, post_startup_inferior)
3313         (post_attach): Move...
3314         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
3315         (remove_fork_catchpoint, post_startup_inferior)
3316         (post_attach): ...here.
3317
3318 2020-04-24  Tom Tromey  <tromey@adacore.com>
3319
3320         * nat/windows-nat.h (struct windows_thread_info)
3321         <pc_adjusted>: New member.
3322         * windows-nat.c (windows_fetch_one_register): Check
3323         pc_adjusted.
3324         (windows_nat_target::get_windows_debug_event)
3325         (windows_nat_target::wait): Set pc_adjusted.
3326
3327 2020-04-24  Tom de Vries  <tdevries@suse.de>
3328
3329         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
3330         Run gdb-add-index inside temp dir.
3331
3332 2020-04-23  Tom Tromey  <tromey@adacore.com>
3333
3334         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
3335         in loop.
3336
3337 2020-04-23  Luis Machado  <luis.machado@linaro.org>
3338
3339         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
3340         get_frame_register instead of gdbarch_unwind_pc.
3341
3342 2020-04-23  Tom de Vries  <tdevries@suse.de>
3343
3344         * symtab.c (lookup_global_symbol): Prefer def over decl.
3345
3346 2020-04-23  Tom de Vries  <tdevries@suse.de>
3347
3348         PR symtab/25807
3349         * block.c (best_symbol, better_symbol): Promote to external.
3350         * block.h (best_symbol, better_symbol): Declare.
3351         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
3352         decl.
3353
3354 2020-04-23  Tom Tromey  <tromey@adacore.com>
3355
3356         PR ada/25837:
3357         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
3358         "const char *", not a "const std::string &".
3359         <name_and_matcher::operator==>: Update.
3360         * unittests/lookup_name_info-selftests.c: Change type of
3361         "result".
3362
3363 2020-04-23  Tom Tromey  <tom@tromey.com>
3364
3365         * inferior.h (iterate_over_inferiors): Don't declare.
3366         * inferior.c (iterate_over_inferiors): Remove.
3367         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
3368         Remove.
3369         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
3370         use iterate_over_inferiors.
3371         (darwin_resume_inferior_it)
3372         (struct resume_inferior_threads_param)
3373         (darwin_resume_inferior_threads_it): Remove.
3374         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
3375
3376 2020-04-23  Tom de Vries  <tdevries@suse.de>
3377
3378         * blockframe.c (find_pc_partial_function): Use
3379         find_pc_sect_compunit_symtab rather than
3380         objfile->sf->qf->find_pc_sect_compunit_symtab.
3381
3382 2020-04-22  Tom de Vries  <tdevries@suse.de>
3383
3384         PR symtab/25764
3385         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
3386         in psymtabs.
3387
3388 2020-04-22  Tom de Vries  <tdevries@suse.de>
3389
3390         PR symtab/25801
3391         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
3392         symtabs.
3393
3394 2020-04-22  Tom de Vries  <tdevries@suse.de>
3395
3396         PR symtab/25700
3397         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
3398         CU if already created.
3399
3400 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3401
3402         * infrun.c (displaced_step_fixup): Switch to the event_thread
3403         before calling displaced_step_restore, not after.
3404
3405 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3406
3407         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
3408         its inferior is not recorded by us.
3409         (record_btrace_target_open): Replace call to
3410         all_non_exited_threads () with call to current_inferior
3411         ()->non_exited_threads ().
3412         (record_btrace_target::stop_recording): Likewise.
3413         (record_btrace_target::close): Likewise.
3414         (record_btrace_target::wait): Likewise.
3415         (record_btrace_target::record_stop_replaying): Likewise.
3416
3417 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3418
3419         * btrace.c (btrace_enable): Throw an error on double enables and
3420         when enabling recording fails.
3421         (btrace_disable): Throw an error if the thread is not recorded.
3422
3423 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3424
3425         * record-btrace.c (record_btrace_target::fetch_registers): Forward
3426         request if we do not have a thread_info.
3427
3428 2020-04-21  Tom de Vries  <tdevries@suse.de>
3429
3430         PR gdb/25471
3431         * thread.c
3432         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
3433         exception in get_frame_id.
3434
3435 2020-04-20  Tom Tromey  <tromey@adacore.com>
3436
3437         * python/python.c (struct gdbpy_event): Mark move constructor as
3438         noexcept.
3439         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
3440         constructor as noexcept.
3441         * completer.h (struct completion_result): Mark move constructor as
3442         noexcept.
3443         * completer.c (completion_result::completion_result): Use
3444         initialization style.  Don't call reset_match_list.
3445
3446 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
3447
3448         * MAINTAINERS (Write After Approval): Add myself.
3449
3450 2020-04-18  Tom Tromey  <tom@tromey.com>
3451
3452         * windows-tdep.c (init_w32_command_list)
3453         (w32_prefix_command_valid): Restore.
3454         (_initialize_windows_tdep): Call init_w32_command_list.
3455
3456 2020-04-18  Tom Tromey  <tom@tromey.com>
3457
3458         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
3459         * value.c (value_fn_field): Update.
3460         * valops.c (find_function_in_inferior)
3461         (value_allocate_space_in_inferior): Update.
3462         * tui/tui-winsource.c (tui_update_source_windows_with_line):
3463         Update.
3464         * tui/tui-source.c (tui_source_window::set_contents): Update.
3465         * symtab.c (lookup_global_or_static_symbol)
3466         (find_function_start_sal_1, skip_prologue_sal)
3467         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
3468         * symmisc.c (dump_msymbols, dump_symtab_1)
3469         (maintenance_print_one_line_table): Update.
3470         * symfile.c (init_entry_point_info, section_is_mapped)
3471         (list_overlays_command, simple_read_overlay_table)
3472         (simple_overlay_update_1): Update.
3473         * stap-probe.c (handle_stap_probe): Update.
3474         * stabsread.c (dbx_init_float_type, define_symbol)
3475         (read_one_struct_field, read_enum_type, read_range_type): Update.
3476         * source.c (info_line_command): Update.
3477         * python/python.c (gdbpy_source_objfile_script)
3478         (gdbpy_execute_objfile_script): Update.
3479         * python/py-type.c (save_objfile_types): Update.
3480         * python/py-objfile.c (py_free_objfile): Update.
3481         * python/py-inferior.c (python_new_objfile): Update.
3482         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
3483         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
3484         (maintenance_check_psymtabs): Update.
3485         * printcmd.c (info_address_command): Update.
3486         * objfiles.h (struct objfile) <arch>: New method, from
3487         get_objfile_arch.
3488         (get_objfile_arch): Don't declare.
3489         * objfiles.c (get_objfile_arch): Remove.
3490         (filter_overlapping_sections): Update.
3491         * minsyms.c (msymbol_is_function): Update.
3492         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
3493         (output_nondebug_symbol): Update.
3494         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
3495         (mdebug_expand_psymtab): Update.
3496         * machoread.c (macho_add_oso_symfile): Update.
3497         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
3498         Update.
3499         * linux-fork.c (checkpoint_command): Update.
3500         * linespec.c (convert_linespec_to_sals): Update.
3501         * jit.c (finalize_symtab): Update.
3502         * infrun.c (insert_exception_resume_from_probe): Update.
3503         * ia64-tdep.c (ia64_find_unwind_table): Update.
3504         * hppa-tdep.c (internalize_unwinds): Update.
3505         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
3506         Update.
3507         * gcore.c (call_target_sbrk): Update.
3508         * elfread.c (record_minimal_symbol, elf_symtab_read)
3509         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
3510         (elf_gnu_ifunc_resolve_by_got): Update.
3511         * dwarf2/read.c (create_addrmap_from_index)
3512         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3513         (read_debug_names_from_section)
3514         (process_psymtab_comp_unit_reader, add_partial_symbol)
3515         (add_partial_subprogram, process_full_comp_unit)
3516         (read_file_scope, read_func_scope, read_lexical_block_scope)
3517         (read_call_site_scope, dwarf2_ranges_read)
3518         (dwarf2_record_block_ranges, dwarf2_add_field)
3519         (mark_common_block_symbol_computed, read_tag_pointer_type)
3520         (read_tag_string_type, dwarf2_init_float_type)
3521         (dwarf2_init_complex_target_type, read_base_type)
3522         (partial_die_info::read, partial_die_info::read)
3523         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
3524         (dwarf2_fetch_die_loc_sect_off): Update.
3525         * dwarf2/loc.c (dwarf2_find_location_expression)
3526         (class dwarf_evaluate_loc_desc, rw_pieced_value)
3527         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
3528         (dwarf2_loc_desc_get_symbol_read_needs)
3529         (locexpr_describe_location_piece, locexpr_describe_location_1)
3530         (loclist_describe_location): Update.
3531         * dwarf2/index-write.c (write_debug_names): Update.
3532         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
3533         * dtrace-probe.c (dtrace_process_dof): Update.
3534         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
3535         (process_one_symbol): Update.
3536         * ctfread.c (ctf_init_float_type, read_base_type): Update.
3537         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
3538         (coff_read_enum_type): Update.
3539         * cli/cli-cmds.c (edit_command, list_command): Update.
3540         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
3541         * breakpoint.c (create_overlay_event_breakpoint)
3542         (create_longjmp_master_breakpoint)
3543         (create_std_terminate_master_breakpoint)
3544         (create_exception_master_breakpoint, get_sal_arch): Update.
3545         * block.c (block_gdbarch): Update.
3546         * annotate.c (annotate_source_line): Update.
3547
3548 2020-04-17  Tom Tromey  <tromey@adacore.com>
3549
3550         * auto-load.c (show_auto_load_cmd): Remove.
3551         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
3552         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
3553         (maintenance_print_arc_command): Remove.
3554         * tui/tui-win.c (tui_command): Remove.
3555         (tui_get_cmd_list): Use add_basic_prefix_cmd.
3556         * tui/tui-layout.c (tui_layout_command): Remove.
3557         (_initialize_tui_layout): Use add_basic_prefix_cmd.
3558         * python/python.c (user_set_python, user_show_python): Remove.
3559         (_initialize_python): Use add_basic_prefix_cmd,
3560         add_show_prefix_cmd.
3561         * guile/guile.c (set_guile_command, show_guile_command): Remove.
3562         (install_gdb_commands): Use add_basic_prefix_cmd,
3563         add_show_prefix_cmd.
3564         (info_guile_command): Remove.
3565         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
3566         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
3567         add_show_prefix_cmd.
3568         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
3569         Remove do_set and do_show parameters.
3570         * cli/cli-style.c (set_style, show_style): Remove.
3571         (_initialize_cli_style): Use add_basic_prefix_cmd,
3572         add_show_prefix_cmd.
3573         (cli_style_option::add_setshow_commands): Remove do_set and
3574         do_show parameters.
3575         (cli_style_option::add_setshow_commands): Use
3576         add_basic_prefix_cmd, add_show_prefix_cmd.
3577         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
3578         (set_style_name): Remove.
3579         * cli/cli-dump.c (dump_command, append_command): Remove.
3580         (srec_dump_command, ihex_dump_command, verilog_dump_command)
3581         (tekhex_dump_command, binary_dump_command)
3582         (binary_append_command): Remove.
3583         (_initialize_cli_dump): Use add_basic_prefix_cmd.
3584         * windows-tdep.c (w32_prefix_command_valid): Remove global.
3585         (init_w32_command_list): Remove; move into ...
3586         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
3587         * valprint.c (set_print, show_print, set_print_raw)
3588         (show_print_raw): Remove.
3589         (_initialize_valprint): Use add_basic_prefix_cmd,
3590         add_show_prefix_cmd.
3591         * typeprint.c (set_print_type, show_print_type): Remove.
3592         (_initialize_typeprint): Use add_basic_prefix_cmd,
3593         add_show_prefix_cmd.
3594         * record.c (set_record_command, show_record_command): Remove.
3595         (_initialize_record): Use add_basic_prefix_cmd,
3596         add_show_prefix_cmd.
3597         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
3598         add_show_prefix_cmd.
3599         (info_command, show_command, set_debug, show_debug): Remove.
3600         * top.h (set_history, show_history): Don't declare.
3601         * top.c (set_history, show_history): Remove.
3602         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
3603         (unset_tdesc_cmd): Remove.
3604         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
3605         add_show_prefix_cmd.
3606         * symtab.c (info_module_command): Remove.
3607         (_initialize_symtab): Use add_basic_prefix_cmd.
3608         * symfile.c (overlay_command): Remove.
3609         (_initialize_symfile): Use add_basic_prefix_cmd.
3610         * sparc64-tdep.c (info_adi_command): Remove.
3611         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
3612         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
3613         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
3614         add_show_prefix_cmd.
3615         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
3616         (_initialize_serial): Use add_basic_prefix_cmd,
3617         add_show_prefix_cmd.
3618         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
3619         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
3620         add_show_prefix_cmd.
3621         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
3622         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
3623         add_show_prefix_cmd.
3624         * riscv-tdep.c (show_riscv_command, set_riscv_command)
3625         (show_debug_riscv_command, set_debug_riscv_command): Remove.
3626         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
3627         add_show_prefix_cmd.
3628         * remote.c (remote_command, set_remote_cmd): Remove.
3629         (_initialize_remote): Use add_basic_prefix_cmd.
3630         * record-full.c (set_record_full_command)
3631         (show_record_full_command): Remove.
3632         (_initialize_record_full): Use add_basic_prefix_cmd,
3633         add_show_prefix_cmd.
3634         * record-btrace.c (cmd_set_record_btrace)
3635         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
3636         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
3637         (cmd_show_record_btrace_pt): Remove.
3638         (_initialize_record_btrace): Use add_basic_prefix_cmd,
3639         add_show_prefix_cmd.
3640         * ravenscar-thread.c (set_ravenscar_command)
3641         (show_ravenscar_command): Remove.
3642         (_initialize_ravenscar): Use add_basic_prefix_cmd,
3643         add_show_prefix_cmd.
3644         * mips-tdep.c (show_mips_command, set_mips_command)
3645         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
3646         add_show_prefix_cmd.
3647         * maint.c (maintenance_command, maintenance_info_command)
3648         (maintenance_check_command, maintenance_print_command)
3649         (maintenance_set_cmd, maintenance_show_cmd): Remove.
3650         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
3651         add_show_prefix_cmd.
3652         (show_per_command_cmd): Remove.
3653         * maint-test-settings.c (maintenance_set_test_settings_cmd):
3654         Remove.
3655         (maintenance_show_test_settings_cmd): Remove.
3656         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
3657         add_show_prefix_cmd.
3658         * maint-test-options.c (maintenance_test_options_command):
3659         Remove.
3660         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
3661         * macrocmd.c (macro_command): Remove
3662         (_initialize_macrocmd): Use add_basic_prefix_cmd.
3663         * language.c (set_check, show_check): Remove.
3664         (_initialize_language): Use add_basic_prefix_cmd,
3665         add_show_prefix_cmd.
3666         * infcmd.c (unset_command): Remove.
3667         (_initialize_infcmd): Use add_basic_prefix_cmd.
3668         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
3669         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
3670         add_show_prefix_cmd.
3671         * go32-nat.c (go32_info_dos_command): Remove.
3672         (_initialize_go32_nat): Use add_basic_prefix_cmd.
3673         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
3674         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
3675         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
3676         (_initialize_frame): Use add_basic_prefix_cmd,
3677         add_show_prefix_cmd.
3678         * dcache.c (set_dcache_command, show_dcache_command): Remove.
3679         (_initialize_dcache): Use add_basic_prefix_cmd,
3680         add_show_prefix_cmd.
3681         * cp-support.c (maint_cplus_command): Remove.
3682         (_initialize_cp_support): Use add_basic_prefix_cmd.
3683         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
3684         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
3685         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
3686         add_basic_prefix_cmd, add_show_prefix_cmd.
3687         * breakpoint.c (save_command): Remove.
3688         (_initialize_breakpoint): Use add_basic_prefix_cmd.
3689         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
3690         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
3691         add_show_prefix_cmd.
3692         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
3693         (set_ada_command, show_ada_command): Remove.
3694         (_initialize_ada_language): Use add_basic_prefix_cmd,
3695         add_show_prefix_cmd.
3696         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
3697
3698 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
3699
3700         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
3701         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
3702
3703 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3704
3705         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
3706         warning messages.
3707
3708 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3709
3710         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
3711         import table is not at beginning of .idata section.
3712
3713 2020-04-16  Pedro Alves  <palves@redhat.com>
3714
3715         * inferior.c (delete_inferior): Use delete operator directly
3716         instead of delete_program_space.
3717         * progspace.c (add_program_space): New, factored out from
3718         program_space::program_space.
3719         (remove_program_space): New, factored out from
3720         delete_program_space.
3721         (program_space::program_space): Remove intro comment.  Rewrite.
3722         (program_space::~program_space): Remove intro comment.  Call
3723         remove_program_space.
3724         (delete_program_space): Delete.
3725         * progspace.h (program_space::program_space): Make explicit.  Move
3726         intro comment here, adjusted.
3727         (program_space::~program_space): Move intro comment here,
3728         adjusted.
3729         (delete_program_space): Remove.
3730
3731 2020-04-16  Tom Tromey  <tromey@adacore.com>
3732
3733         * windows-nat.c (windows_nat::handle_access_violation): New
3734         function.
3735         * nat/windows-nat.h (handle_access_violation): Declare.
3736         * nat/windows-nat.c (handle_exception): Move Cygwin code to
3737         windows-nat.c.  Call handle_access_violation.
3738
3739 2020-04-16  Tom de Vries  <tdevries@suse.de>
3740
3741         PR symtab/25791
3742         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
3743         CUs without psymtab.
3744
3745 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
3746
3747         * python/python.c (do_start_initialization): Don't call
3748         PyEval_InitThreads for Python 3.9 and beyond.
3749
3750 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
3751
3752         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
3753         thread functions.
3754         (obsd_nat_target::wait): Likewise.
3755
3756 2020-04-15  Tom Tromey  <tromey@adacore.com>
3757
3758         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
3759         (DEBUG_EXCEPT): Use debug_printf.
3760
3761 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3762
3763         * completer.c (class completion_tracker::completion_hash_entry)
3764         <hash_name>: New member function.
3765         (completion_tracker::discard_completions): New callback to hash a
3766         completion_hash_entry, pass this to htab_create_alloc.
3767
3768 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
3769
3770         * windows-nat.c (windows_make_so): Warn rather than stopping with
3771         an error if realpath() fails.
3772
3773 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
3774
3775         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
3776         (nbsd_nat_target::info_proc): Add do_status.
3777
3778 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
3779             Tom de Vries  <tdevries@suse.de>
3780
3781         PR symtab/25718
3782         * psympriv.h (struct partial_symtab::read_symtab)
3783         (struct partial_symtab::expand_psymtab)
3784         (struct partial_symtab::read_dependencies): Update comments.
3785         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
3786         read_symtab for includer.
3787         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
3788         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
3789         (struct dwarf2_include_psymtab::m_readin): Remove.
3790         (struct dwarf2_include_psymtab::includer): New member function.
3791         (dwarf2_psymtab::expand_psymtab): Assert !readin.
3792
3793 2020-04-14  Tom de Vries  <tdevries@suse.de>
3794
3795         PR symtab/25720
3796         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
3797         with NULL symbol_matcher and lookup_name.
3798         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
3799         and lookup_name.
3800         * dwarf2/read.c (dw2_expand_symtabs_matching)
3801         (dw2_debug_names_expand_symtabs_matching): Same.
3802         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
3803         Make lookup_name a pointer.  Update comment.
3804         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
3805         lookup_name being a pointer.
3806         * symfile.c (expand_symtabs_matching): Same.
3807         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
3808         * linespec.c (iterate_over_all_matching_symtabs): Same.
3809
3810 2020-04-13  Tom Tromey  <tom@tromey.com>
3811
3812         * run-on-main-thread.c: Update include.
3813         * unittests/main-thread-selftests.c: Update include.
3814         * tui/tui-win.c: Update include.
3815         * tui/tui-io.c: Update include.
3816         * tui/tui-interp.c: Update include.
3817         * tui/tui-hooks.c: Update include.
3818         * top.h: Update include.
3819         * top.c: Update include.
3820         * ser-base.c: Update include.
3821         * remote.c: Update include.
3822         * remote-notif.c: Update include.
3823         * remote-fileio.c: Update include.
3824         * record-full.c: Update include.
3825         * record-btrace.c: Update include.
3826         * python/python.c: Update include.
3827         * posix-hdep.c: Update include.
3828         * mingw-hdep.c: Update include.
3829         * mi/mi-main.c: Update include.
3830         * mi/mi-interp.c: Update include.
3831         * main.c: Update include.
3832         * linux-nat.c: Update include.
3833         * interps.c: Update include.
3834         * infrun.c: Update include.
3835         * inf-loop.c: Update include.
3836         * event-top.c: Update include.
3837         * event-loop.c: Move to ../gdbsupport/.
3838         * event-loop.h: Move to ../gdbsupport/.
3839         * async-event.h: Update include.
3840         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
3841
3842 2020-04-13  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-win.c: Include async-event.h.
3845         * remote.c: Include async-event.h.
3846         * remote-notif.c: Include async-event.h.
3847         * record-full.c: Include async-event.h.
3848         * record-btrace.c: Include async-event.h.
3849         * infrun.c: Include async-event.h.
3850         * event-top.c: Include async-event.h.
3851         * event-loop.h: Move some declarations to async-event.h.
3852         * event-loop.c: Don't include ser-event.h or top.h.  Move some
3853         code to async-event.c.
3854         * async-event.h: New file.
3855         * async-event.c: New file.
3856         * Makefile.in (COMMON_SFILES): Add async-event.c.
3857         (HFILES_NO_SRCDIR): Add async-event.h.
3858
3859 2020-04-13  Tom Tromey  <tom@tromey.com>
3860
3861         * utils.c (flush_streams): New function.
3862         * event-loop.c (gdb_wait_for_event): Call flush_streams.
3863
3864 2020-04-13  Tom Tromey  <tom@tromey.com>
3865
3866         * event-loop.c (handle_file_event): Use warning, not
3867         printf_unfiltered.
3868
3869 2020-04-13  Tom Tromey  <tom@tromey.com>
3870
3871         * event-loop.c: Include <chrono>.
3872
3873 2020-04-13  Tom Tromey  <tom@tromey.com>
3874
3875         * gdb_select.h: Move to ../gdbsupport/.
3876         * event-loop.c: Update include path.
3877         * top.c: Update include path.
3878         * ser-base.c: Update include path.
3879         * ui-file.c: Update include path.
3880         * ser-tcp.c: Update include path.
3881         * guile/scm-ports.c: Update include path.
3882         * posix-hdep.c: Update include path.
3883         * ser-unix.c: Update include path.
3884         * gdb_usleep.c: Update include path.
3885         * mingw-hdep.c: Update include path.
3886         * inflow.c: Update include path.
3887         * infrun.c: Update include path.
3888         * event-top.c: Update include path.
3889
3890 2020-04-13  Tom Tromey  <tom@tromey.com>
3891
3892         * configure: Rebuild.
3893         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
3894
3895 2020-04-13  Tom Tromey  <tom@tromey.com>
3896
3897         * event-loop.h (start_event_loop): Don't declare.
3898         * event-loop.c (start_event_loop): Move...
3899         * main.c (start_event_loop): ...here.  Now static.
3900
3901 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
3902
3903         * MAINTAINERS: Update my email address.
3904
3905 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3906
3907         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
3908         IP_ALL.
3909
3910 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3911
3912         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
3913         (nbsd_nat_target::info_proc): Add do_cmdline.
3914
3915 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3916
3917         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
3918         (nbsd_nat_target::info_proc): Add do_cwd.
3919
3920 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3921
3922         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
3923
3924 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
3925
3926         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
3927         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
3928         (nbsd_nat_target::info_proc): New functions.
3929         * nbsd-nat.c (kinfo_get_vmmap): New function.
3930         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
3931         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
3932         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
3933         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
3934         functions.
3935         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
3936         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
3937         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
3938         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
3939         (KINFO_VME_FLAG_GROWS_DOWN): New.
3940
3941 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
3942
3943         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
3944         bit shift.
3945
3946 2020-04-10  Tom Tromey  <tromey@adacore.com>
3947
3948         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
3949
3950 2020-04-10  Tom Tromey  <tromey@adacore.com>
3951
3952         * symtab.c (get_symbol_address, get_msymbol_address): Skip
3953         separate debug files.
3954
3955 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
3956
3957         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
3958         Move to...
3959         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
3960         ... here.
3961         * windows-nat.c (windows_nat_target::get_windows_debug_event):
3962         Check for STATUS_WX86_BREAKPOINT.
3963         (windows_nat_target::wait): Same.
3964
3965 2020-04-10  Tom de Vries  <tdevries@suse.de>
3966
3967         PR cli/25808
3968         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
3969
3970 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
3971
3972         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
3973         (Write After Approval): Remove Tom de Vries.
3974
3975 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3976
3977         revert partially:
3978         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3979
3980         * buildsym.c (record_line): Fix undefined behavior and preserve
3981         lines at eof.
3982
3983 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
3984
3985         * auxv.h (svr4_auxv_parse): New.
3986         * auxv.c (default_auxv_parse): Split into default_auxv_parse
3987         and generic_auxv_parse.
3988         (svr4_auxv_parse): Add.
3989         * obsd-tdep.c: Include "auxv.h".
3990         (obsd_auxv_parse): Remove.
3991         (obsd_init_abi): Remove comment.
3992         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
3993         from `obsd_auxv_parse' to `svr4_auxv_parse'.
3994         * nbsd-tdep.c: Include "auxv.h".
3995         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
3996
3997 2020-04-08  Tom Tromey  <tromey@adacore.com>
3998
3999         * nat/windows-nat.h (last_wait_event): Don't declare.
4000         (wait_for_debug_event): Update comment.
4001         * nat/windows-nat.c (last_wait_event): Now static.
4002
4003 2020-04-08  Tom Tromey  <tromey@adacore.com>
4004
4005         * windows-nat.c (wait_for_debug_event): Move to
4006         nat/windows-nat.c.
4007         * nat/windows-nat.h (wait_for_debug_event): Declare.
4008         * nat/windows-nat.c (wait_for_debug_event): Move from
4009         windows-nat.c.  No longer static.
4010
4011 2020-04-08  Tom Tromey  <tromey@adacore.com>
4012
4013         * windows-nat.c (get_windows_debug_event): Use
4014         fetch_pending_stop.
4015         * nat/windows-nat.h (fetch_pending_stop): Declare.
4016         * nat/windows-nat.c (fetch_pending_stop): New function.
4017
4018 2020-04-08  Tom Tromey  <tromey@adacore.com>
4019
4020         * windows-nat.c (windows_continue): Use matching_pending_stop and
4021         continue_last_debug_event.
4022         * nat/windows-nat.h (matching_pending_stop)
4023         (continue_last_debug_event): Declare.
4024         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4025         (matching_pending_stop, continue_last_debug_event): New
4026         functions.
4027
4028 2020-04-08  Tom Tromey  <tromey@adacore.com>
4029
4030         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4031         (handle_exception_result): Move to nat/windows-nat.h.
4032         (DEBUG_EXCEPTION_SIMPLE): Remove.
4033         (windows_nat::handle_ms_vc_exception): New function.
4034         (handle_exception): Move to nat/windows-nat.c.
4035         (get_windows_debug_event): Update.
4036         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4037         nat/windows-nat.c.
4038         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4039         (handle_exception_result): Move from windows-nat.c.
4040         (handle_exception): Declare.
4041         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4042         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4043         windows-nat.c.
4044
4045 2020-04-08  Tom Tromey  <tromey@adacore.com>
4046
4047         * windows-nat.c (exception_count, event_count): Remove.
4048         (handle_exception, get_windows_debug_event)
4049         (do_initial_windows_stuff): Update.
4050
4051 2020-04-08  Tom Tromey  <tromey@adacore.com>
4052
4053         * windows-nat.c (windows_nat::handle_load_dll)
4054         (windows_nat::handle_unload_dll): Rename.  No longer static.
4055         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4056         Declare.
4057
4058 2020-04-08  Tom Tromey  <tromey@adacore.com>
4059
4060         * complaints.h (stop_whining): Declare at top-level.
4061         (complaint): Don't declare stop_whining.
4062
4063 2020-04-08  Tom Tromey  <tromey@adacore.com>
4064
4065         * windows-nat.c (windows_nat::handle_output_debug_string):
4066         Rename.  No longer static.
4067         * nat/windows-nat.h (handle_output_debug_string): Declare.
4068
4069 2020-04-08  Tom Tromey  <tromey@adacore.com>
4070
4071         * windows-nat.c (current_process_handle, current_process_id)
4072         (main_thread_id, last_sig, current_event, last_wait_event)
4073         (current_windows_thread, desired_stop_thread_id, pending_stops)
4074         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4075         (display_selectors, fake_create_process)
4076         (get_windows_debug_event): Update.
4077         * nat/windows-nat.h (current_process_handle, current_process_id)
4078         (main_thread_id, last_sig, current_event, last_wait_event)
4079         (current_windows_thread, desired_stop_thread_id, pending_stops)
4080         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4081         * nat/windows-nat.c (current_process_handle, current_process_id)
4082         (main_thread_id, last_sig, current_event, last_wait_event)
4083         (current_windows_thread, desired_stop_thread_id, pending_stops)
4084         (siginfo_er): New globals.  Move from windows-nat.c.
4085
4086 2020-04-08  Tom Tromey  <tromey@adacore.com>
4087
4088         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4089         (handle_load_dll): Update.
4090         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4091
4092 2020-04-08  Tom Tromey  <tromey@adacore.com>
4093
4094         * windows-nat.c (enum thread_disposition_type): Move to
4095         nat/windows-nat.h.
4096         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4097         static.
4098         (windows_add_thread, windows_nat_target::fetch_registers)
4099         (windows_nat_target::store_registers, handle_exception)
4100         (windows_nat_target::resume, get_windows_debug_event)
4101         (windows_nat_target::get_tib_address)
4102         (windows_nat_target::thread_name)
4103         (windows_nat_target::thread_alive): Update.
4104         * nat/windows-nat.h (enum thread_disposition_type): Move from
4105         windows-nat.c.
4106         (thread_rec): Declare.
4107
4108 2020-04-08  Tom Tromey  <tromey@adacore.com>
4109
4110         * windows-nat.c: Add "using namespace".
4111         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4112         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4113
4114 2020-04-08  Tom Tromey  <tromey@adacore.com>
4115
4116         * nat/windows-nat.h (struct windows_thread_info): Declare
4117         destructor.
4118         * nat/windows-nat.c (~windows_thread_info): New.
4119
4120 2020-04-08  Tom Tromey  <tromey@adacore.com>
4121
4122         PR gdb/22992
4123         * windows-nat.c (current_event): Update comment.
4124         (last_wait_event, desired_stop_thread_id): New globals.
4125         (struct pending_stop): New.
4126         (pending_stops): New global.
4127         (windows_nat_target) <stopped_by_sw_breakpoint>
4128         <supports_stopped_by_sw_breakpoint>: New methods.
4129         (windows_fetch_one_register): Add assertions.  Adjust PC.
4130         (windows_continue): Handle pending stops.  Suspend other threads
4131         when stepping.  Use last_wait_event
4132         (wait_for_debug_event): New function.
4133         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4134         pending stops.  Queue spurious stops.
4135         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4136         (windows_nat_target::kill): Use wait_for_debug_event.
4137         * nat/windows-nat.h (struct windows_thread_info)
4138         <stopped_at_software_breakpoint>: New field.
4139         * nat/windows-nat.c (windows_thread_info::resume): Clear
4140         stopped_at_software_breakpoint.
4141
4142 2020-04-08  Tom Tromey  <tromey@adacore.com>
4143
4144         * windows-nat.c (enum thread_disposition_type): New.
4145         (thread_rec): Replace "get_context" parameter with "disposition";
4146         change type.
4147         (windows_add_thread, windows_nat_target::fetch_registers)
4148         (windows_nat_target::store_registers, handle_exception)
4149         (windows_nat_target::resume, get_windows_debug_event)
4150         (windows_nat_target::get_tib_address)
4151         (windows_nat_target::thread_name)
4152         (windows_nat_target::thread_alive): Update.
4153
4154 2020-04-08  Tom Tromey  <tromey@adacore.com>
4155
4156         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4157         (windows_continue): Use windows_continue::resume.
4158         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4159         resume>: Declare new methods.
4160         * nat/windows-nat.c: New file.
4161         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4162
4163 2020-04-08  Tom Tromey  <tromey@adacore.com>
4164
4165         * windows-nat.c (windows_add_thread, windows_delete_thread)
4166         (windows_nat_target::fetch_registers)
4167         (windows_nat_target::store_registers, fake_create_process)
4168         (windows_nat_target::resume, windows_nat_target::resume)
4169         (get_windows_debug_event, windows_nat_target::wait)
4170         (windows_nat_target::pid_to_str)
4171         (windows_nat_target::get_tib_address)
4172         (windows_nat_target::get_ada_task_ptid)
4173         (windows_nat_target::thread_name)
4174         (windows_nat_target::thread_alive): Use lwp, not tid.
4175
4176 2020-04-08  Tom Tromey  <tromey@adacore.com>
4177
4178         * windows-nat.c (handle_exception)
4179         (windows_nat_target::thread_name): Update.
4180         * nat/windows-nat.h (windows_thread_info): Remove destructor.
4181         <name>: Now unique_xmalloc_ptr.
4182
4183 2020-04-08  Tom Tromey  <tromey@adacore.com>
4184
4185         * windows-nat.c (thread_rec)
4186         (windows_nat_target::fetch_registers): Update.
4187         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
4188         Update comment.
4189         <debug_registers_changed, reload_context>: Now bool.
4190
4191 2020-04-08  Tom Tromey  <tromey@adacore.com>
4192
4193         * windows-nat.c (windows_add_thread): Use new.
4194         (windows_init_thread_list, windows_delete_thread): Use delete.
4195         (get_windows_debug_event): Update.
4196         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
4197         destructor, and initializers.
4198
4199 2020-04-08  Tom Tromey  <tromey@adacore.com>
4200
4201         * windows-nat.c (struct windows_thread_info): Remove.
4202         * nat/windows-nat.h: New file.
4203
4204 2020-04-08  Tom Tromey  <tromey@adacore.com>
4205
4206         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
4207         (thread_rec, windows_add_thread, windows_delete_thread)
4208         (windows_continue): Update.
4209
4210 2020-04-08  Tom Tromey  <tromey@adacore.com>
4211
4212         * windows-nat.c (struct windows_thread_info): Remove typedef.
4213         (thread_head): Remove.
4214         (thread_list): New global.
4215         (thread_rec, windows_add_thread, windows_init_thread_list)
4216         (windows_delete_thread, windows_continue): Update.
4217
4218 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4219
4220         * windows-tdep.h (windows_init_abi): Add comment.
4221         (cygwin_init_abi): New declaration.
4222         * windows-tdep.c: Split signal enumeration in two, one for
4223         Windows and one for Cygwin.
4224         (windows_gdb_signal_to_target): Only deal with signal of the
4225         Windows OS ABI.
4226         (cygwin_gdb_signal_to_target): New function.
4227         (windows_init_abi): Rename to windows_init_abi_common, don't set
4228         gdb_signal_to_target gdbarch method.  Add new new function with
4229         this name.
4230         (cygwin_init_abi): New function.
4231         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
4232         comment.  Don't call windows_init_abi.
4233         (amd64_windows_init_abi): Add comment, call windows_init_abi.
4234         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
4235         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
4236         i386_windows_init_abi_common, don't call windows_init_abi.  Add
4237         a new function of this name.
4238         (i386_cygwin_init_abi): New function.
4239         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
4240         OS ABI Cygwin.
4241
4242 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4243
4244         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
4245         parameter.c.
4246         (dwarf2_read_gdb_index): Update.
4247
4248 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
4249
4250         * nbsd-tdep.c: Include "objfiles.h".
4251         (nbsd_skip_solib_resolver): New.
4252         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
4253
4254 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4255
4256         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
4257         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
4258         with DW_LLE_base_addressx are being emitted in DWARFv5.
4259         Add the newly added kind DW_LOC_OFFSET_PAIR also.
4260         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
4261         unsigned integer.
4262
4263 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4264
4265         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
4266         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
4267         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
4268         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
4269         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
4270         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
4271         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
4272
4273
4274 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4275
4276         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
4277         (read_loclist_index): New function definition.
4278         (lookup_loclist_base): New function definition.
4279         (read_loclist_header): New function definition.
4280         (dwarf2_cu): Add loclist_base and loclist_header field.
4281         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
4282         (read_full_die_1): Read the value of DW_AT_loclists_base.
4283         (read_attribute_reprocess): Handle DW_FORM_loclistx.
4284         (read_attribute_value): Handle DW_FORM_loclistx.
4285         (skip_one_die): Handle DW_FORM_loclistx.
4286         (loclist_header): New structure declaration.
4287         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
4288
4289 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4290
4291         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
4292         constructor.  Remove `addr` parameter from other constructor and
4293         add `per_cu` parameter.
4294         * dwarf2/read.c (create_partial_symtab): Update.
4295
4296 2020-04-07  Tom de Vries  <tdevries@suse.de>
4297
4298         PR symtab/25796
4299         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
4300         (partial_die_info::fixup): Inherit has_const_value.
4301
4302 2020-04-07  Tom de Vries  <tdevries@suse.de>
4303
4304         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
4305         symbols without address.
4306
4307 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4308
4309         * nbsd-nat.h (struct thread_info): Add forward declaration.
4310         (nbsd_nat_target::thread_alive): Add.
4311         (nbsd_nat_target::thread_name): Likewise.
4312         (nbsd_nat_target::update_thread_list): Likewise.
4313         (update_thread_list::post_attach): Likewise.
4314         (post_attach::pid_to_str): Likewise.
4315         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
4316         (nbsd_thread_lister): Add.
4317         (nbsd_nat_target::thread_alive): Likewise.
4318         (nbsd_nat_target::thread_name): Likewise.
4319         (nbsd_add_threads): Likewise.
4320         (update_thread_list::post_attach): Likewise.
4321         (nbsd_nat_target::update_thread_list): Likewise.
4322         (post_attach::pid_to_str): Likewise.
4323
4324 2020-04-06  Tom Tromey  <tromey@adacore.com>
4325
4326         * ada-valprint.c (print_variant_part): Extract the variant field.
4327         (print_field_values): Use the field as the outer value when
4328         recursing.
4329
4330 2020-04-06  Tom Tromey  <tromey@adacore.com>
4331
4332         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
4333         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
4334         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
4335         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
4336         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
4337
4338 2020-04-06  Tom Tromey  <tromey@adacore.com>
4339
4340         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
4341         TYPE_CODE_ERROR.
4342
4343 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4344
4345         * nbsd-tdep.c: Include "gdbarch.h".
4346         Define enum with NetBSD signal numbers.
4347         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
4348         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
4349         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
4350         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
4351         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
4352         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
4353         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
4354         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
4355         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
4356         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
4357         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
4358         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
4359
4360 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
4361
4362         PR gdb/25325
4363         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
4364
4365 2020-04-03  Tom Tromey  <tromey@adacore.com>
4366
4367         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
4368         Read constant block.
4369
4370 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4371
4372         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
4373         (gdb_bfd_get_full_section_contents): New declaration.
4374         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
4375         * windows-tdep.c (is_linked_with_cygwin_dll): Use
4376         gdb_bfd_get_full_section_contents.
4377
4378 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4379
4380         * exec.c (build_section_table): Replace internal_error with
4381         gdb_assert.
4382         (section_table_xfer_memory_partial): Likewise.
4383         * mdebugread.c (parse_partial_symbols): Likewise.
4384         * psymtab.c (lookup_partial_symbol): Likewise.
4385         * utils.c (wrap_here): Likewise.
4386
4387 2020-04-02  Tom Tromey  <tromey@adacore.com>
4388
4389         * f-lang.c (build_fortran_types): Use arch_type to initialize
4390         builtin_complex_s32 in the TYPE_CODE_ERROR case.
4391
4392 2020-04-02  Tom Tromey  <tromey@adacore.com>
4393
4394         * dwarf2/read.c (partial_die_info::read): Do not create a vector
4395         of attributes.
4396
4397 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4398             Bernd Edlinger <bernd.edlinger@hotmail.de>
4399             Tom Tromey  <tromey@adacore.com>
4400
4401         * buildsym.c (buildsym_compunit::record_line): Remove
4402         deduplication code.
4403
4404 2020-04-02  Tom de Vries  <tdevries@suse.de>
4405
4406         PR ada/24671
4407         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
4408
4409 2020-04-02  Tom de Vries  <tdevries@suse.de>
4410
4411         * dwarf2/read.c (dwarf2_gdb_index_functions,
4412         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
4413         NULL.
4414         * psymtab.c (psym_lookup_global_symbol_language): New function.
4415         (psym_functions): Init psym_lookup_global_symbol_language with
4416         psym_lookup_global_symbol_language.
4417         * symfile-debug.c (debug_sym_quick_functions): Init
4418         lookup_global_symbol_language with NULL.
4419         * symfile.c (set_initial_language): Remove fixme comment.
4420         * symfile.h (struct quick_symbol_functions): Add
4421         lookup_global_symbol_language.
4422         * symtab.c (find_quick_global_symbol_language): New function.
4423         (find_main_name): Use find_quick_global_symbol_language.
4424
4425 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4426
4427         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
4428
4429 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4430
4431         * buildsym.c (record_line): Fix undefined behavior and preserve
4432         lines at eof.
4433
4434 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4435
4436         * buildsym.c (record_line): Fix the resizing condition.
4437
4438 2020-04-01  Tom Tromey  <tom@tromey.com>
4439
4440         * value.h (value_literal_complex): Add comment.
4441         * valops.c (value_literal_complex): Refer to value.h.
4442
4443 2020-04-01  Tom Tromey  <tom@tromey.com>
4444
4445         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
4446         (scalar_type): New rule, from typebase.
4447         (typebase): Use scalar_type.  Recognize complex types.
4448         (field_name): Handle FLOAT_KEYWORD.
4449         (ident_tokens): Add _Complex and __complex__.
4450
4451 2020-04-01  Tom Tromey  <tom@tromey.com>
4452
4453         PR exp/25299:
4454         * valarith.c (promotion_type, complex_binop): New functions.
4455         (scalar_binop): Handle complex numbers.  Use promotion_type.
4456         (value_pos, value_neg, value_complement): Handle complex numbers.
4457
4458 2020-04-01  Tom Tromey  <tom@tromey.com>
4459
4460         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
4461         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
4462         (parse_number): Handle complex numbers.
4463
4464 2020-04-01  Tom Tromey  <tom@tromey.com>
4465
4466         * c-valprint.c (c_decorations): Change complex suffix to "i".
4467
4468 2020-04-01  Tom Tromey  <tom@tromey.com>
4469
4470         * valprint.c (generic_value_print_complex): Use accessors.
4471         * value.h (value_real_part, value_imaginary_part): Declare.
4472         * valops.c (value_real_part, value_imaginary_part): New
4473         functions.
4474         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
4475
4476 2020-04-01  Tom Tromey  <tom@tromey.com>
4477
4478         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
4479         (read_range_type): Update.
4480         * mdebugread.c (basic_type): Update.
4481         * go-lang.c (build_go_types): Use init_complex_type.
4482         * gdbtypes.h (struct main_type) <complex_type>: New member.
4483         (init_complex_type): Update.
4484         (arch_complex_type): Don't declare.
4485         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
4486         Make name if none given.  Use alloc_type_copy.  Look for cached
4487         complex type.
4488         (arch_complex_type): Remove.
4489         (gdbtypes_post_init): Use init_complex_type.
4490         * f-lang.c (build_fortran_types): Use init_complex_type.
4491         * dwarf2/read.c (read_base_type): Update.
4492         * d-lang.c (build_d_types): Use init_complex_type.
4493         * ctfread.c (read_base_type): Update.
4494
4495 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4496
4497         * infrun.c (stop_all_threads): Update assertion, plus when
4498         stopping threads, take into account that we might be trying
4499         to stop an all-stop target.
4500         (stop_waiting): Call 'stop_all_threads' if there exists a
4501         non-stop target.
4502
4503 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4504
4505         * target.h (exists_non_stop_target): New function declaration.
4506         * target.c (exists_non_stop_target): New function.
4507
4508 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
4509
4510         PR gdb/24789
4511         * eval.c (is_integral_or_integral_reference): New function.
4512         (evaluate_subexp_standard): Allow integer references in
4513         pointer arithmetic.
4514
4515 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4516
4517         * remote.c (remote_target::remote_parse_stop_reply): Remove the
4518         check for no ptid in the stop reply when the target is non-stop.
4519
4520 2020-04-01  Tom Tromey  <tromey@adacore.com>
4521
4522         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
4523         "name" parameter to rvalue reference.  Initialize m_name_holder.
4524         <lookup_name_info>: New overloads.
4525         <name>: Return gdb::string_view.
4526         <c_str>: New method.
4527         <make_ignore_params>: Update.
4528         <search_name_hash>: Update.
4529         <language_lookup_name>: Return const char *.
4530         <m_name>: Change type.
4531         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
4532         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
4533         (lookup_name_info::match_any): Update.
4534         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
4535         Update.
4536         * minsyms.c (linkage_name_str): Update.
4537         * language.c (default_symbol_name_matcher): Update.
4538         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
4539         Update.
4540         * ada-lang.c (ada_fold_name): Change parameter to string_view.
4541         (ada_lookup_name_info::ada_lookup_name_info): Update.
4542         (literal_symbol_name_matcher): Update.
4543
4544 2020-04-01  Tom Tromey  <tromey@adacore.com>
4545
4546         * psymtab.c (psymtab_search_name): Remove function.
4547         (psym_lookup_symbol): Create search name and lookup name here.
4548         (lookup_partial_symbol): Remove "name" parameter; add
4549         lookup_name.
4550         (psym_expand_symtabs_for_function): Update.
4551
4552 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
4553
4554         PR tui/25597:
4555         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
4556
4557 2020-03-31  Tom Tromey  <tromey@adacore.com>
4558
4559         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
4560         memcpy.
4561
4562 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
4563
4564         * features/riscv/32bit-csr.xml: Regenerated.
4565         * features/riscv/64bit-csr.xml: Regenerated.
4566
4567 2020-03-30  Tom Tromey  <tromey@adacore.com>
4568
4569         * ada-valprint.c (print_variant_part): Update.
4570         * ada-lang.h (ada_which_variant_applies): Update.
4571         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
4572         outer_valaddr parameters; replace with "outer" value parameter.
4573         (to_fixed_variant_branch_type): Update.
4574
4575 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4576
4577         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
4578         <list>.  Remove inclusion of observable.h.
4579         (PPC_DEBUG_CURRENT_VERSION): Move up define.
4580         (struct arch_lwp_info): New struct.
4581         (class ppc_linux_dreg_interface): New class.
4582         (struct ppc_linux_process_info): New struct.
4583         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
4584         <low_new_clone, low_forget_process, low_prepare_to_resume>
4585         <copy_thread_dreg_state, mark_thread_stale>
4586         <mark_debug_registers_changed, register_hw_breakpoint>
4587         <clear_hw_breakpoint, register_wp, clear_wp>
4588         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
4589         <num_memory_accesses, get_trigger_type>
4590         <create_watchpoint_request, hwdebug_point_cmp>
4591         <init_arch_lwp_info, get_arch_lwp_info>
4592         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
4593         methods.
4594         <struct ptid_hash>: New inner struct.
4595         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
4596         members.
4597         (saved_dabr_value, hwdebug_info, max_slots_number)
4598         (struct hw_break_tuple, struct thread_points, ppc_threads)
4599         (have_ptrace_hwdebug_interface)
4600         (hwdebug_find_thread_points_by_tid)
4601         (hwdebug_insert_point, hwdebug_remove_point): Remove.
4602         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
4603         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
4604         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
4605         use m_dreg_interface.
4606         (hwdebug_point_cmp): Change to...
4607         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
4608         reference arguments instead of pointers.
4609         (ppc_linux_nat_target::ranged_break_num_registers): Use
4610         m_dreg_interface.
4611         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
4612         m_dreg_interface.  Call register_hw_breakpoint.
4613         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
4614         m_dreg_interface.  Call clear_hw_breakpoint.
4615         (get_trigger_type): Change to...
4616         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
4617         comment.
4618         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
4619         use m_dreg_interface.  Call register_hw_breakpoint.
4620         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
4621         use m_dreg_interface.  Call clear_hw_breakpoint.
4622         (can_use_watchpoint_cond_accel): Change to...
4623         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
4624         method.  Update comment, use m_dreg_interface and
4625         m_process_info.
4626         (calculate_dvc): Change to...
4627         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
4628         m_dreg_interface.
4629         (num_memory_accesses): Change to...
4630         (ppc_linux_nat_target::num_memory_accesses): ...this method.
4631         (check_condition): Change to...
4632         (ppc_linux_nat_target::check_condition): ...this method.
4633         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
4634         comment, use m_dreg_interface.
4635         (create_watchpoint_request): Change to...
4636         (ppc_linux_nat_target::create_watchpoint_request): ...this
4637         method.  Use m_dreg_interface.
4638         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
4639         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
4640         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
4641         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
4642         (ppc_linux_nat_target::low_forget_process)
4643         (ppc_linux_nat_target::low_new_fork)
4644         (ppc_linux_nat_target::low_new_clone)
4645         (ppc_linux_nat_target::low_delete_thread)
4646         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
4647         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
4648         only call mark_thread_stale.
4649         (ppc_linux_thread_exit): Remove.
4650         (ppc_linux_nat_target::stopped_data_address): Change to...
4651         (ppc_linux_nat_target::low_stopped_data_address): This. Add
4652         comment, use m_dreg_interface and m_thread_hw_breakpoints.
4653         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
4654         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
4655         comment.  Call low_stopped_data_address.
4656         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
4657         m_dreg_interface.
4658         (ppc_linux_nat_target::masked_watch_num_registers): Use
4659         m_dreg_interface.
4660         (ppc_linux_nat_target::copy_thread_dreg_state)
4661         (ppc_linux_nat_target::mark_thread_stale)
4662         (ppc_linux_nat_target::mark_debug_registers_changed)
4663         (ppc_linux_nat_target::register_hw_breakpoint)
4664         (ppc_linux_nat_target::clear_hw_breakpoint)
4665         (ppc_linux_nat_target::register_wp)
4666         (ppc_linux_nat_target::clear_wp)
4667         (ppc_linux_nat_target::init_arch_lwp_info)
4668         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
4669         (_initialize_ppc_linux_nat): Remove observer callback.
4670
4671 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4672
4673         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
4674         (ppc_linux_nat_target::auxv_parse)
4675         (ppc_linux_nat_target::read_description)
4676         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
4677         Move up.
4678
4679 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4680
4681         * linux-nat.h (low_new_clone): New method.
4682         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
4683
4684 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4685
4686         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
4687         (dbx_expand_psymtab): ... this.
4688         (start_psymtab): Update.
4689         * mdebugread.c (psymtab_to_symtab_1): Rename to...
4690         (mdebug_expand_psymtab): ... this.
4691         (parse_partial_symbols): Update.
4692         (new_psymtab): Update.
4693         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
4694         (xcoff_expand_psymtab): ... this.
4695         (xcoff_start_psymtab): Update.
4696
4697 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4698
4699         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
4700         <expand_dependencies>: ... this.
4701         * psymtab.c (partial_symtab::read_dependencies): Rename to...
4702         (partial_symtab::expand_dependencies): ... this.
4703         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
4704         Update.
4705         (dwarf2_psymtab::expand_psymtab): Update.
4706         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
4707         * mdebugread.c (psymtab_to_symtab_1): Update.
4708         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
4709
4710 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4711
4712         * psympriv.h (discard_psymtab): Remove.
4713         * dbxread.c (dbx_end_psymtab): Update.
4714         * xcoffread.c (xcoff_end_psymtab): Update.
4715
4716 2020-03-28  Tom Tromey  <tom@tromey.com>
4717
4718         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
4719         comment.
4720
4721 2020-03-28  Tom Tromey  <tom@tromey.com>
4722
4723         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
4724
4725 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
4726
4727         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4728
4729 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
4730
4731         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
4732
4733 2020-03-26  Tom Tromey  <tom@tromey.com>
4734
4735         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
4736         (mark_common_block_symbol_computed, read_tag_string_type)
4737         (attr_to_dynamic_prop, read_subrange_type): Update.
4738         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
4739         to be methods on struct attribute.
4740         (skip_one_die, process_imported_unit_die, read_namespace_alias)
4741         (read_call_site_scope, partial_die_info::read)
4742         (partial_die_info::read, lookup_die_type, follow_die_ref):
4743         Update.
4744         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
4745         from dwarf2_get_ref_die_offset.
4746         (attribute::constant_value): New method, from
4747         dwarf2_get_attr_constant_value.
4748         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
4749         Declare method.
4750         <constant_value>: New method.
4751
4752 2020-03-26  Tom Tromey  <tom@tromey.com>
4753
4754         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
4755         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
4756         (dwarf_type_encoding_name): Move to stringify.c.
4757         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
4758         * dwarf2/stringify.c: New file.
4759         * dwarf2/stringify.h: New file.
4760
4761 2020-03-26  Tom Tromey  <tom@tromey.com>
4762
4763         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
4764         Rewrite.
4765
4766 2020-03-26  Tom Tromey  <tom@tromey.com>
4767
4768         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
4769         methods.
4770         * dwarf2/read.c (lookup_addr_base): Move to die.h.
4771         (lookup_ranges_base): Likewise.
4772         (read_cutu_die_from_dwo, read_full_die_1): Update.
4773
4774 2020-03-26  Tom Tromey  <tom@tromey.com>
4775
4776         * dwarf2/read.c (read_import_statement, read_file_scope)
4777         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
4778         (read_lexical_block_scope, read_call_site_scope)
4779         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
4780         (handle_struct_member_die, process_structure_scope)
4781         (update_enumeration_type_from_children)
4782         (process_enumeration_scope, read_array_type, read_common_block)
4783         (read_namespace, read_module, read_subroutine_type): Update.
4784         (sibling_die): Remove.
4785
4786 2020-03-26  Tom Tromey  <tom@tromey.com>
4787
4788         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
4789         (build_type_psymtabs_reader, read_structure_type)
4790         (read_enumeration_type, read_full_die_1): Update.
4791         (dwarf2_attr_no_follow): Move to die.h.
4792         * dwarf2/die.h (struct die_info) <attr>: New method.
4793
4794 2020-03-26  Tom Tromey  <tom@tromey.com>
4795
4796         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
4797         <base_address>: Now an optional.
4798         (dwarf2_find_base_address, dwarf2_rnglists_process)
4799         (dwarf2_ranges_process, fill_in_loclist_baton)
4800         (dwarf2_symbol_mark_computed): Update.
4801
4802 2020-03-26  Tom Tromey  <tom@tromey.com>
4803
4804         * dwarf2/read.c (struct die_info): Move to die.h.
4805         * dwarf2/die.h: New file.
4806
4807 2020-03-26  Tom Tromey  <tom@tromey.com>
4808
4809         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
4810         * dwarf2/read.c
4811         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4812         Move to line-header.c.
4813         (read_checked_initial_length_and_offset, read_formatted_entries):
4814         Likewise.
4815         (dwarf_decode_line_header): Split into two.
4816         * dwarf2/line-header.c
4817         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4818         Move from read.c.
4819         (read_checked_initial_length_and_offset, read_formatted_entries):
4820         Likewise.
4821         (dwarf_decode_line_header): New function, split from read.c.
4822
4823 2020-03-26  Tom Tromey  <tom@tromey.com>
4824
4825         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
4826         Declare method.
4827         * dwarf2/read.c (read_attribute_value): Update.
4828         (dwarf2_per_objfile::read_line_string): Rename from
4829         read_indirect_line_string.
4830         (read_formatted_entries): Update.
4831
4832 2020-03-26  Tom Tromey  <tom@tromey.com>
4833
4834         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
4835         variable.
4836
4837 2020-03-26  Tom Tromey  <tom@tromey.com>
4838
4839         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
4840         const.
4841         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
4842         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
4843         parameter const.
4844
4845 2020-03-26  Tom Tromey  <tom@tromey.com>
4846
4847         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
4848         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
4849         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
4850         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
4851
4852 2020-03-26  Tom Tromey  <tom@tromey.com>
4853
4854         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
4855         file_names_size, file_full_name, file_file_name>: Use const.
4856         <file_name_at, file_names>: Add const overload.
4857         * dwarf2/line-header.c (line_header::file_file_name)
4858         (line_header::file_full_name): Update.
4859
4860 2020-03-26  Tom Tromey  <tom@tromey.com>
4861
4862         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
4863         (macro_start_file, consume_improper_spaces)
4864         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
4865         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
4866         (dwarf_decode_macros): Move to macro.c.
4867         * dwarf2/macro.c: New file.
4868         * dwarf2/macro.h: New file.
4869         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
4870
4871 2020-03-26  Tom Tromey  <tom@tromey.com>
4872
4873         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
4874         method.
4875         * dwarf2/section.c: New method.  From
4876         read_indirect_string_at_offset_from.
4877         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
4878         (read_indirect_string_at_offset_from): Move to section.c.
4879         (read_indirect_string_at_offset): Rewrite.
4880         (read_indirect_line_string_at_offset): Remove.
4881         (read_indirect_string, read_indirect_line_string)
4882         (dwarf_decode_macro_bytes): Update.
4883
4884 2020-03-26  Tom Tromey  <tom@tromey.com>
4885
4886         * dwarf2/section.h (struct dwarf2_section_info)
4887         <overload_complaint>: Declare.
4888         (dwarf2_section_buffer_overflow_complaint): Don't declare.
4889         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
4890         Rename from dwarf2_section_buffer_overflow_complaint.
4891         * dwarf2/read.c (skip_one_die, partial_die_info::read)
4892         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
4893
4894 2020-03-26  Tom Tromey  <tom@tromey.com>
4895
4896         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
4897         Declare.
4898         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
4899         Move from read.c.
4900         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
4901         to section.c.
4902
4903 2020-03-26  Tom Tromey  <tom@tromey.com>
4904
4905         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
4906
4907 2020-03-26  Tom Tromey  <tom@tromey.com>
4908
4909         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
4910         "builder".
4911         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
4912         parameter.
4913         (dwarf_decode_macros): Update.
4914
4915 2020-03-26  Tom Tromey  <tom@tromey.com>
4916
4917         * dwarf2/read.c (read_attribute_value): Update.
4918         (read_indirect_string_from_dwz): Move to dwz.c; change into
4919         method.
4920         (dwarf_decode_macro_bytes): Update.
4921         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
4922         * dwarf2/dwz.c: New file.
4923         * Makefile.in (COMMON_SFILES): Add dwz.c.
4924
4925 2020-03-26  Tom Tromey  <tom@tromey.com>
4926
4927         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
4928         * dwarf2/read.c: Add include.
4929         * dwarf2/index-write.c: Add include.
4930         * dwarf2/index-cache.c: Add include.
4931         * dwarf2/dwz.h: New file.
4932
4933 2020-03-25  Tom Tromey  <tom@tromey.com>
4934
4935         * compile/compile-object-load.c (get_out_value_type): Mention
4936         correct symbol name in error message.
4937
4938 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
4939
4940         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4941
4942 2020-03-25  Tom de Vries  <tdevries@suse.de>
4943
4944         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
4945         * symmisc.c (dump_symtab_1): Print user and includes fields.
4946         (maintenance_info_symtabs): Same.
4947
4948 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
4949
4950         PR gdb/25534
4951         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
4952         (riscv_regcache_cooked_write): New function.
4953         (riscv_push_dummy_call): Use new function.
4954         (riscv_return_value): Likewise.
4955
4956 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
4957
4958         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
4959         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
4960         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
4961         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
4962         * infrun.c (follow_fork): Likewise.
4963         (follow_fork_inferior): Likewise.
4964         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
4965         * linux-nat.h (class linux_nat_target): Likewise.
4966         * remote.c (class remote_target) <follow_fork>: Likewise.
4967         (remote_target::follow_fork): Likewise.
4968         * target-delegates.c: Re-generate.
4969         * target.c (default_follow_fork): Likewise.
4970         (target_follow_fork): Likewise.
4971         * target.h (struct target_ops) <follow_fork>: Likewise.
4972         (target_follow_fork): Likewise.
4973
4974 2020-03-24  Tom de Vries  <tdevries@suse.de>
4975
4976         * psymtab.c (maintenance_info_psymtabs): Print user field.
4977
4978 2020-03-20  Tom Tromey  <tromey@adacore.com>
4979
4980         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
4981         const.
4982         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
4983         const.
4984
4985 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
4986
4987         * ptrace.m4: Don't check for ptrace declaration.
4988         * config.in: Re-generate.
4989         * configure: Re-generate.
4990         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
4991         not defined.
4992
4993 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
4994
4995         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
4996         `PTRACE_TYPE_RET'.
4997         * i386-bsd-nat.c (gdb_ptrace): Likewise.
4998         * sparc-nat.c (gdb_ptrace): Likewise.
4999         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5000
5001 2020-03-20  Tom Tromey  <tromey@adacore.com>
5002
5003         * c-exp.y (lex_one_token): Fix assert.
5004
5005 2020-03-20  Tom Tromey  <tromey@adacore.com>
5006
5007         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5008         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5009         strncpy call.
5010
5011 2020-03-20  Tom Tromey  <tromey@adacore.com>
5012
5013         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5014
5015 2020-03-20  Tom Tromey  <tromey@adacore.com>
5016
5017         * ada-valprint.c (print_variant_part): Remove parameters; switch
5018         to value-based API.
5019         (print_field_values): Likewise.
5020         (ada_val_print_struct_union): Likewise.
5021         (ada_value_print_1): Update.
5022
5023 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5024
5025         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5026         nbsd_nat_target instead of inf_ptrace_target.
5027         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5028         nbsd_nat_target.
5029
5030 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5031
5032         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5033         it to the ptrace call.
5034         * (store_registers): Likewise.
5035
5036 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5037
5038         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5039         it to the ptrace call.
5040         * (store_registers): Likewise.
5041
5042 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5043
5044         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5045         valid, fetch vg value from ptrace.
5046
5047 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5048         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5049         * inf-ptrace.c: Likewise.
5050         * (gdb_ptrace): Add.
5051         * (inf_ptrace_target::resume): Update.
5052         * (inf_ptrace_target::xfer_partial): Likewise.
5053         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5054         * (inf_ptrace_peek_poke): Update.
5055
5056 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5057
5058         * x86-bsd-nat.c (gdb_ptrace): New.
5059         * (x86bsd_dr_set): Add new argument `ptid'.
5060         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5061         x86bsd_dr_set_addr): Update.
5062
5063 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5064
5065         * remote.c (remote_target::process_stop_reply): Handle events for
5066         all threads differently.
5067
5068 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * completer.c (completion_tracker::remove_completion): Define new
5071         function.
5072         * completer.h (completion_tracker::remove_completion): Declare new
5073         function.
5074         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5075         when adding a C++ function symbol.
5076
5077 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5078
5079         * completer.c (completion_tracker::completion_hash_entry): Define
5080         new class.
5081         (advance_to_filename_complete_word_point): Call
5082         recompute_lowest_common_denominator.
5083         (completion_tracker::completion_tracker): Call discard_completions
5084         to setup the hash table.
5085         (completion_tracker::discard_completions): Allow for being called
5086         from the constructor, pass new equal function, and element deleter
5087         when constructing the hash table.  Initialise new class member
5088         variables.
5089         (completion_tracker::maybe_add_completion): Remove use of
5090         m_entries_vec, and store more information into m_entries_hash.
5091         (completion_tracker::recompute_lcd_visitor): New function, most
5092         content taken from...
5093         (completion_tracker::recompute_lowest_common_denominator):
5094         ...here, this now just visits each item in the hash calling the
5095         above visitor.
5096         (completion_tracker::build_completion_result): Remove use of
5097         m_entries_vec, call recompute_lowest_common_denominator.
5098         * completer.h (completion_tracker::have_completions): Remove use
5099         of m_entries_vec.
5100         (completion_tracker::completion_hash_entry): Declare new class.
5101         (completion_tracker::recompute_lowest_common_denominator): Change
5102         function signature.
5103         (completion_tracker::recompute_lcd_visitor): Declare new function.
5104         (completion_tracker::m_entries_vec): Delete.
5105         (completion_tracker::m_entries_hash): Initialize to NULL.
5106         (completion_tracker::m_lowest_common_denominator_valid): New
5107         member variable.
5108         (completion_tracker::m_lowest_common_denominator_max_length): New
5109         member variable.
5110
5111 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5112
5113         * regformats/regdef.h: Put reg in gdb namespace.
5114
5115 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5116
5117         * i386-bsd-nat.c (gdb_ptrace): New.
5118         * (i386bsd_fetch_inferior_registers,
5119         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5120         * (i386bsd_fetch_inferior_registers,
5121         i386bsd_store_inferior_registers) Use gdb_ptrace.
5122
5123 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5124
5125         * amd64-bsd-nat.c (gdb_ptrace): New.
5126         * (amd64bsd_fetch_inferior_registers,
5127         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5128         * (amd64bsd_fetch_inferior_registers,
5129         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5130
5131 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5132
5133         * user-regs.c (user_reg::read): Rename to...
5134         (user_reg::xread): ...this.
5135         * (append_user_reg): Rename argument `read' to `xread'.
5136         * (user_reg_add_builtin): Likewise.
5137         * (user_reg_add): Likewise.
5138         * (value_of_user_reg): Likewise.
5139
5140 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5141
5142         * sparc-nat.c (gdb_ptrace): New.
5143         * sparc-nat.c (sparc_fetch_inferior_registers)
5144         (sparc_store_inferior_registers) Remove obsolete comment.
5145         * sparc-nat.c (sparc_fetch_inferior_registers)
5146         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5147         * sparc-nat.c (sparc_fetch_inferior_registers)
5148         (sparc_store_inferior_registers) Use gdb_ptrace.
5149
5150 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5151
5152         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5153         it to the ptrace call.
5154         * sh-nbsd-nat.c (store_registers): Likewise.
5155
5156 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5157
5158         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5159         nbsd_nat_target instead of inf_ptrace_target.
5160         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5161         nbsd_nat_target.
5162
5163 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5164
5165         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5166
5167 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5168
5169         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5170         <sys/sysctl.h>.
5171         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5172
5173 2020-03-17  Tom de Vries  <tdevries@suse.de>
5174
5175         PR gdb/23710
5176         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
5177         fields.
5178         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
5179         fields.
5180         (process_imported_unit_die): Skip import of c++ CUs.
5181
5182 2020-03-16  Tom Tromey  <tom@tromey.com>
5183
5184         * p-valprint.c (pascal_object_print_value): Initialize
5185         base_value.
5186
5187 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
5188             Shahab Vahedi  <shahab@synopsys.com>
5189
5190         * Makefile.in: Add arch/arc.o
5191         * configure.tgt: Likewise.
5192         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
5193         (_initialize_arc_tdep): Don't initialize old target descriptions.
5194         (arc_read_description): New function to cache target descriptions.
5195         * arc-tdep.h (arc_read_description): Add proto type.
5196         * arch/arc.c: New file.
5197         * arch/arc.h: Likewise.
5198         * features/Makefile: Replace old target descriptions with new.
5199         * features/arc-arcompact.c: Remove.
5200         * features/arc-arcompact.xml: Likewise.
5201         * features/arc-v2.c: Likewise
5202         * features/arc-v2.xml: Likewise
5203         * features/arc/aux-arcompact.xml: New file.
5204         * features/arc/aux-v2.xml: Likewise.
5205         * features/arc/core-arcompact.xml: Likewise.
5206         * features/arc/core-v2.xml: Likewise.
5207         * features/arc/aux-arcompact.c: Generate.
5208         * features/arc/aux-v2.c: Likewise.
5209         * features/arc/core-arcompact.c: Likewise.
5210         * features/arc/core-v2.c: Likewise.
5211         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
5212
5213 2020-03-16  Tom Tromey  <tromey@adacore.com>
5214
5215         PR gdb/25663:
5216         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
5217         putting value into bcache.
5218
5219 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5220
5221         PR gdb/21500
5222         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
5223         to...
5224         (amd64_windows_init_abi_common): ... this.  Don't set size of
5225         long type.
5226         (amd64_windows_init_abi): New function.
5227         (amd64_cygwin_init_abi): New function.
5228         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
5229         the Cygwin OS ABI.
5230         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
5231         comment.
5232
5233 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5234
5235         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
5236         * windows-tdep.c (CYGWIN_DLL_NAME): New.
5237         (pe_import_directory_entry): New struct type.
5238         (is_linked_with_cygwin_dll): New function.
5239         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
5240         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
5241         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
5242
5243 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5244
5245         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
5246         i386_cygwin_core_osabi_sniffer.
5247
5248 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5249
5250         * i386-cygwin-tdep.c: Rename to...
5251         * i386-windows-tdep.c: ... this.
5252         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
5253         i386-windows-tdep.c.
5254         * configure.tgt: Likewise.
5255
5256 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5257
5258         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
5259         * osabi.c (gdb_osabi_names): Add "Windows".
5260         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
5261         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
5262         (i386_cygwin_core_osabi_sniffer): New function, extracted from
5263         i386_cygwin_osabi_sniffer.
5264         (_initialize_i386_cygwin_tdep): Register OS ABI
5265         GDB_OSABI_WINDOWS for i386.
5266         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
5267         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
5268         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
5269         for x86-64.
5270         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
5271         when the target matches '*-*-mingw*'.
5272
5273 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5274
5275         * defs.h (enum gdb_osabi): Move to...
5276         * osabi.h (enum gdb_osabi): ... here.
5277         * gdbarch.sh: Include osabi.h in gdbarch.h.
5278         * gdbarch.h: Re-generate.
5279
5280 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5281
5282         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
5283         function.
5284         (_initialize_amd64_windows_tdep): Register osabi sniffer.
5285
5286 2020-03-14  Tom Tromey  <tom@tromey.com>
5287
5288         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
5289         for C++.
5290         (c_type_print_modifier): Likewise.  Add "language" parameter.
5291         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
5292         (c_type_print_base_1): Update.
5293         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
5294         constants.
5295         * type-stack.c (type_stack::insert): Handle tp_atomic and
5296         tp_restrict.
5297         (type_stack::follow_type_instance_flags): Likewise.
5298         (type_stack::follow_types): Likewise.  Merge type-following code.
5299         * c-exp.y (RESTRICT, ATOMIC): New tokens.
5300         (space_identifier, cv_with_space_id)
5301         (const_or_volatile_or_space_identifier_noopt)
5302         (const_or_volatile_or_space_identifier): Remove.
5303         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
5304         rules.
5305         (ptr_operator, typebase): Update.
5306         (enum token_flag) <FLAG_C>: New constant.
5307         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
5308         "_Atomic".
5309         (lex_one_token): Handle FLAG_C.
5310
5311 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5312
5313         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
5314         it to the ptrace call.
5315         * m68k-bsd-nat.c (store_registers): Likewise.
5316
5317 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5318
5319         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
5320         gdb_byte *.
5321         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
5322         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
5323         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
5324
5325 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5326
5327         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
5328         nbsd_nat_target instead of inf_ptrace_target.
5329         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5330         nbsd_nat_target.
5331
5332 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5333
5334         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
5335         register_t.
5336
5337 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5338
5339         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
5340         it to the ptrace call.
5341         * alpha-bsd-nat.c (store_registers): Likewise.
5342
5343 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5344
5345         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
5346         includes.
5347         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
5348         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
5349         fill_fpregset): Likewise.
5350
5351 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5352
5353         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
5354         nbsd_nat_target instead of inf_ptrace_target.
5355         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5356         nbsd_nat_target.
5357
5358 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5359
5360         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
5361         register_t.
5362
5363 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5364
5365         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
5366         it to the ptrace call.
5367         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
5368         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
5369         * arm-nbsd-nat.c (store_register): Likewise.
5370         * arm-nbsd-nat.c (store_regs): Likewise.
5371         * arm-nbsd-nat.c (store_fp_register): Likewise.
5372         * arm-nbsd-nat.c (store_fp_regs): Likewise.
5373
5374 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5375
5376         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
5377         nbsd_nat_target instead of inf_ptrace_target.
5378         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5379         nbsd_nat_target.
5380
5381 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5382
5383         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
5384         it to the ptrace call.
5385         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
5386
5387 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5388
5389         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
5390         it to the ptrace call.
5391         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
5392
5393 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5394
5395         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
5396         gdb_byte *.
5397         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
5398
5399 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5400
5401         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
5402         instead of inf_ptrace_target.
5403         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5404         nbsd_nat_target.
5405
5406 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5407
5408         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5409         register_t.
5410
5411 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5412
5413         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5414         register_t.
5415
5416 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5417
5418         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
5419         register_t.
5420
5421 2020-03-13  Tom Tromey  <tom@tromey.com>
5422
5423         * value.h (val_print): Don't declare.
5424         * valprint.h (val_print_array_elements)
5425         (val_print_scalar_formatted, generic_val_print): Don't declare.
5426         * valprint.c (generic_val_print_array): Take a struct value.
5427         (generic_val_print_ptr, generic_val_print_memberptr)
5428         (generic_val_print_bool, generic_val_print_int)
5429         (generic_val_print_char, generic_val_print_complex)
5430         (generic_val_print): Remove.
5431         (generic_value_print): Update.
5432         (do_val_print): Remove unused parameters.  Don't call
5433         la_val_print.
5434         (val_print): Remove.
5435         (common_val_print): Update.  Don't call value_check_printable.
5436         (val_print_scalar_formatted, val_print_array_elements): Remove.
5437         * rust-lang.c (rust_val_print): Remove.
5438         (rust_language_defn): Update.
5439         * p-valprint.c (pascal_val_print): Remove.
5440         (pascal_value_print_inner): Update.
5441         (pascal_object_print_val_fields, pascal_object_print_val):
5442         Remove.
5443         (pascal_object_print_static_field): Update.
5444         * p-lang.h (pascal_val_print): Don't declare.
5445         * p-lang.c (pascal_language_defn): Update.
5446         * opencl-lang.c (opencl_language_defn): Update.
5447         * objc-lang.c (objc_language_defn): Update.
5448         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
5449         * m2-lang.h (m2_val_print): Don't declare.
5450         * m2-lang.c (m2_language_defn): Update.
5451         * language.h (struct language_defn) <la_val_print>: Remove.
5452         * language.c (unk_lang_value_print_inner): Rename.  Change
5453         argument types.
5454         (unknown_language_defn, auto_language_defn): Update.
5455         * go-valprint.c (go_val_print): Remove.
5456         * go-lang.h (go_val_print): Don't declare.
5457         * go-lang.c (go_language_defn): Update.
5458         * f-valprint.c (f_val_print): Remove.
5459         * f-lang.h (f_value_print): Don't declare.
5460         * f-lang.c (f_language_defn): Update.
5461         * d-valprint.c (d_val_print): Remove.
5462         * d-lang.h (d_value_print): Don't declare.
5463         * d-lang.c (d_language_defn): Update.
5464         * cp-valprint.c (cp_print_value_fields)
5465         (cp_print_value_fields_rtti, cp_print_value): Remove.
5466         (cp_print_static_field): Update.
5467         * c-valprint.c (c_val_print_array, c_val_print_ptr)
5468         (c_val_print_struct, c_val_print_union, c_val_print_int)
5469         (c_val_print_memberptr, c_val_print): Remove.
5470         * c-lang.h (c_val_print_array, cp_print_value_fields)
5471         (cp_print_value_fields_rtti): Don't declare.
5472         * c-lang.c (c_language_defn, cplus_language_defn)
5473         (asm_language_defn, minimal_language_defn): Update.
5474         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
5475         (ada_val_print_enum): Take a struct value.
5476         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
5477         (ada_val_print): Remove.
5478         (ada_value_print_1): Update.
5479         (printable_val_type): Remove.
5480         * ada-lang.h (ada_val_print): Don't declare.
5481         * ada-lang.c (ada_language_defn): Update.
5482
5483 2020-03-13  Tom Tromey  <tom@tromey.com>
5484
5485         * valprint.c (do_val_print): Update.
5486         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
5487         a struct value.
5488         (value_to_value_object_no_release): Declare.
5489         * python/py-value.c (value_to_value_object_no_release): New
5490         function.
5491         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
5492         struct value.
5493         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
5494         function.
5495         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
5496         a struct value.
5497         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
5498         Declare.
5499         (gdbscm_apply_val_pretty_printer): Take a struct value.
5500         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
5501         value.
5502         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
5503         value.
5504         * extension-priv.h (struct extension_language_ops)
5505         <apply_val_pretty_printer>: Take a struct value.
5506         * cp-valprint.c (cp_print_value): Create a struct value.
5507         (cp_print_value): Update.
5508
5509 2020-03-13  Tom Tromey  <tom@tromey.com>
5510
5511         * ada-valprint.c (print_field_values): Call common_val_print.
5512
5513 2020-03-13  Tom Tromey  <tom@tromey.com>
5514
5515         * ada-valprint.c (val_print_packed_array_elements): Remove
5516         bitoffset and val parameters.  Call common_val_print.
5517         (ada_val_print_string): Remove offset, address, and original_value
5518         parameters.
5519         (ada_val_print_array): Update.
5520         (ada_value_print_array): New function.
5521         (ada_value_print_1): Call it.
5522
5523 2020-03-13  Tom Tromey  <tom@tromey.com>
5524
5525         * ada-valprint.c (ada_value_print): Use common_val_print.
5526
5527 2020-03-13  Tom Tromey  <tom@tromey.com>
5528
5529         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
5530
5531 2020-03-13  Tom Tromey  <tom@tromey.com>
5532
5533         * ada-valprint.c (ada_value_print_num): New function.
5534         (ada_value_print_1): Use it.
5535
5536 2020-03-13  Tom Tromey  <tom@tromey.com>
5537
5538         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
5539
5540 2020-03-13  Tom Tromey  <tom@tromey.com>
5541
5542         * ada-valprint.c (ada_value_print_ptr): New function.
5543         (ada_value_print_1): Use it.
5544
5545 2020-03-13  Tom Tromey  <tom@tromey.com>
5546
5547         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
5548         call common_val_print.
5549         (ada_val_print_1): Update.
5550         (ada_value_print_1): New function.
5551         (ada_value_print_inner): Rewrite.
5552
5553 2020-03-13  Tom Tromey  <tom@tromey.com>
5554
5555         * cp-valprint.c (cp_print_value_fields): Update.
5556         (cp_print_value): New function.
5557
5558 2020-03-13  Tom Tromey  <tom@tromey.com>
5559
5560         * m2-valprint.c (m2_value_print_inner): Use
5561         cp_print_value_fields.
5562         * cp-valprint.c (cp_print_value_fields): New function.
5563         * c-valprint.c (c_value_print_struct): New function.
5564         (c_value_print_inner): Use c_value_print_struct.
5565         * c-lang.h (cp_print_value_fields): Declare.
5566
5567 2020-03-13  Tom Tromey  <tom@tromey.com>
5568
5569         * c-valprint.c (c_value_print_array): New function.
5570         (c_value_print_inner): Use it.
5571
5572 2020-03-13  Tom Tromey  <tom@tromey.com>
5573
5574         * c-valprint.c (c_value_print_memberptr): New function.
5575         (c_value_print_inner): Use it.
5576
5577 2020-03-13  Tom Tromey  <tom@tromey.com>
5578
5579         * c-valprint.c (c_value_print_int): New function.
5580         (c_value_print_inner): Use it.
5581
5582 2020-03-13  Tom Tromey  <tom@tromey.com>
5583
5584         * c-valprint.c (c_value_print_ptr): New function.
5585         (c_value_print_inner): Use it.
5586
5587 2020-03-13  Tom Tromey  <tom@tromey.com>
5588
5589         * c-valprint.c (c_value_print_inner): Rewrite.
5590
5591 2020-03-13  Tom Tromey  <tom@tromey.com>
5592
5593         * valprint.c (generic_value_print_complex): New function.
5594         (generic_value_print): Use it.
5595
5596 2020-03-13  Tom Tromey  <tom@tromey.com>
5597
5598         * valprint.c (generic_val_print_float): Don't call
5599         val_print_scalar_formatted.
5600         (generic_val_print, generic_value_print): Update.
5601
5602 2020-03-13  Tom Tromey  <tom@tromey.com>
5603
5604         * valprint.c (generic_value_print_char): New function
5605         (generic_value_print): Use it.
5606
5607 2020-03-13  Tom Tromey  <tom@tromey.com>
5608
5609         * valprint.c (generic_value_print_int): New function.
5610         (generic_value_print): Use it.
5611
5612 2020-03-13  Tom Tromey  <tom@tromey.com>
5613
5614         * valprint.c (generic_value_print_bool): New function.
5615         (generic_value_print): Use it.
5616
5617 2020-03-13  Tom Tromey  <tom@tromey.com>
5618
5619         * valprint.c (generic_val_print_func): Simplify.
5620         (generic_val_print, generic_value_print): Update.
5621
5622 2020-03-13  Tom Tromey  <tom@tromey.com>
5623
5624         * valprint.c (generic_val_print_flags): Remove.
5625         (generic_val_print, generic_value_print): Update.
5626         (val_print_type_code_flags): Add original_value parameter.
5627
5628 2020-03-13  Tom Tromey  <tom@tromey.com>
5629
5630         * valprint.c (generic_val_print): Update.
5631         (generic_value_print): Update.
5632         * valprint.c (generic_val_print_enum): Don't call
5633         val_print_scalar_formatted.
5634
5635 2020-03-13  Tom Tromey  <tom@tromey.com>
5636
5637         * valprint.c (generic_value_print): Call generic_value_print_ptr.
5638         * valprint.c (generic_value_print_ptr): New function.
5639
5640 2020-03-13  Tom Tromey  <tom@tromey.com>
5641
5642         * valprint.c (generic_value_print): Rewrite.
5643
5644 2020-03-13  Tom Tromey  <tom@tromey.com>
5645
5646         * p-valprint.c (pascal_object_print_value_fields)
5647         (pascal_object_print_value): New functions.
5648
5649 2020-03-13  Tom Tromey  <tom@tromey.com>
5650
5651         * p-valprint.c (pascal_value_print_inner): Rewrite.
5652
5653 2020-03-13  Tom Tromey  <tom@tromey.com>
5654
5655         * f-valprint.c (f_value_print_innner): Rewrite.
5656
5657 2020-03-13  Tom Tromey  <tom@tromey.com>
5658
5659         * m2-valprint.c (m2_print_unbounded_array): New overload.
5660         (m2_print_unbounded_array): Update.
5661         (m2_print_array_contents): Take a struct value.
5662         (m2_value_print_inner): Rewrite.
5663
5664 2020-03-13  Tom Tromey  <tom@tromey.com>
5665
5666         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
5667         (d_value_print_inner): New function.
5668         * d-lang.h (d_value_print_inner): Declare.
5669         * d-lang.c (d_language_defn): Use d_value_print_inner.
5670
5671 2020-03-13  Tom Tromey  <tom@tromey.com>
5672
5673         * go-valprint.c (go_value_print_inner): New function.
5674         * go-lang.h (go_value_print_inner): Declare.
5675         * go-lang.c (go_language_defn): Use go_value_print_inner.
5676
5677 2020-03-13  Tom Tromey  <tom@tromey.com>
5678
5679         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
5680         API.
5681         (rust_val_print): Rewrite.
5682         (rust_value_print_inner): New function, from rust_val_print.
5683         (rust_language_defn): Use rust_value_print_inner.
5684
5685 2020-03-13  Tom Tromey  <tom@tromey.com>
5686
5687         * ada-valprint.c (ada_value_print_inner): New function.
5688         * ada-lang.h (ada_value_print_inner): Declare.
5689         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
5690
5691 2020-03-13  Tom Tromey  <tom@tromey.com>
5692
5693         * f-valprint.c (f_value_print_innner): New function.
5694         * f-lang.h (f_value_print_innner): Declare.
5695         * f-lang.c (f_language_defn): Use f_value_print_innner.
5696
5697 2020-03-13  Tom Tromey  <tom@tromey.com>
5698
5699         * p-valprint.c (pascal_value_print_inner): New function.
5700         * p-lang.h (pascal_value_print_inner): Declare.
5701         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
5702
5703 2020-03-13  Tom Tromey  <tom@tromey.com>
5704
5705         * m2-valprint.c (m2_value_print_inner): New function.
5706         * m2-lang.h (m2_value_print_inner): Declare.
5707         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
5708
5709 2020-03-13  Tom Tromey  <tom@tromey.com>
5710
5711         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
5712         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
5713         * c-valprint.c (c_value_print_inner): New function.
5714         * c-lang.h (c_value_print_inner): Declare.
5715         * c-lang.c (c_language_defn, cplus_language_defn)
5716         (asm_language_defn, minimal_language_defn): Use
5717         c_value_print_inner.
5718
5719 2020-03-13  Tom Tromey  <tom@tromey.com>
5720
5721         * p-valprint.c (pascal_object_print_value_fields): Now static.
5722         * p-lang.h (pascal_object_print_value_fields): Don't declare.
5723
5724 2020-03-13  Tom Tromey  <tom@tromey.com>
5725
5726         * c-valprint.c (c_val_print_array): Simplify.
5727
5728 2020-03-13  Tom Tromey  <tom@tromey.com>
5729
5730         * valprint.c (value_print_array_elements): New function.
5731         * valprint.h (value_print_array_elements): Declare.
5732
5733 2020-03-13  Tom Tromey  <tom@tromey.com>
5734
5735         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
5736         * mips-tdep.c (mips_print_register): Use
5737         value_print_scalar_formatted.
5738
5739 2020-03-13  Tom Tromey  <tom@tromey.com>
5740
5741         * valprint.h (value_print_scalar_formatted): Declare.
5742         * valprint.c (value_print_scalar_formatted): New function.
5743
5744 2020-03-13  Tom Tromey  <tom@tromey.com>
5745
5746         * valprint.h (generic_value_print): Declare.
5747         * valprint.c (generic_value_print): New function.
5748
5749 2020-03-13  Tom Tromey  <tom@tromey.com>
5750
5751         * valprint.c (do_val_print): Call la_value_print_inner, if
5752         available.
5753         * rust-lang.c (rust_language_defn): Update.
5754         * p-lang.c (pascal_language_defn): Update.
5755         * opencl-lang.c (opencl_language_defn): Update.
5756         * objc-lang.c (objc_language_defn): Update.
5757         * m2-lang.c (m2_language_defn): Update.
5758         * language.h (struct language_defn) <la_value_print_inner>: New
5759         member.
5760         * language.c (unknown_language_defn, auto_language_defn): Update.
5761         * go-lang.c (go_language_defn): Update.
5762         * f-lang.c (f_language_defn): Update.
5763         * d-lang.c (d_language_defn): Update.
5764         * c-lang.c (c_language_defn, cplus_language_defn)
5765         (asm_language_defn, minimal_language_defn): Update.
5766         * ada-lang.c (ada_language_defn): Update.
5767
5768 2020-03-13  Tom Tromey  <tom@tromey.com>
5769
5770         * c-valprint.c (c_value_print): Use common_val_print.
5771
5772 2020-03-13  Tom Tromey  <tom@tromey.com>
5773
5774         * cp-valprint.c (cp_print_static_field): Use common_val_print.
5775
5776 2020-03-13  Tom Tromey  <tom@tromey.com>
5777
5778         * f-valprint.c (f77_print_array_1, f_val_print): Use
5779         common_val_print.
5780
5781 2020-03-13  Tom Tromey  <tom@tromey.com>
5782
5783         * riscv-tdep.c (riscv_print_one_register_info): Use
5784         common_val_print.
5785
5786 2020-03-13  Tom Tromey  <tom@tromey.com>
5787
5788         * mi/mi-main.c (output_register): Use common_val_print.
5789
5790 2020-03-13  Tom Tromey  <tom@tromey.com>
5791
5792         * infcmd.c (default_print_one_register_info): Use
5793         common_val_print.
5794
5795 2020-03-13  Tom Tromey  <tom@tromey.com>
5796
5797         * valprint.h (common_val_print_checked): Declare.
5798         * valprint.c (common_val_print_checked): New function.
5799         * stack.c (print_frame_arg): Use common_val_print_checked.
5800
5801 2020-03-13  Tom Tromey  <tom@tromey.com>
5802
5803         * valprint.c (do_val_print): New function, from val_print.
5804         (val_print): Use do_val_print.
5805         (common_val_print): Use do_val_print.
5806
5807 2020-03-13  Tom Tromey  <tom@tromey.com>
5808
5809         * valprint.c (value_print): Use scoped_value_mark.
5810
5811 2020-03-13  Tom de Vries  <tdevries@suse.de>
5812
5813         PR symtab/25646
5814         * psymtab.c (partial_symtab::partial_symtab): Don't set
5815         globals_offset and statics_offset.  Push element onto
5816         current_global_psymbols and current_static_psymbols stacks.
5817         (concat): New function.
5818         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
5819         element from current_global_psymbols and current_static_psymbols
5820         stacks.  Concat popped elements to global_psymbols and
5821         static_symbols.
5822         (add_psymbol_to_list): Use current_global_psymbols and
5823         current_static_psymbols stacks.
5824         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
5825         current_static_psymbols fields.
5826
5827 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5828
5829         * corelow.c (sniff_core_bfd): Remove.
5830         (class core_target) <m_core_vec>: Remove.
5831         (core_target::core_target): Update.
5832         (core_file_fns): Remove.
5833         (deprecated_add_core_fns): Remove.
5834         (default_core_sniffer): Remove.
5835         (sniff_core_bfd): Remove.
5836         (default_check_format): Remove.
5837         (gdb_check_format): Remove.
5838         (core_target_open): Update.
5839         (core_target::get_core_register_section): Update.
5840         (get_core_registers_cb): Update.
5841         (core_target::fetch_registers): Update.
5842         * gdbcore.h (struct core_fns): Remove.
5843         (deprecated_add_core_fns): Remove.
5844         (default_core_sniffer): Remove.
5845         (default_check_format): Remove.
5846
5847 2020-03-12  Tom Tromey  <tom@tromey.com>
5848
5849         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
5850         CORE_ADDR.
5851         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
5852
5853 2020-03-12  Tom Tromey  <tom@tromey.com>
5854
5855         * remote.c (remote_target::download_tracepoint)
5856         (remote_target::enable_tracepoint)
5857         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
5858         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
5859         sprintf_vma.
5860
5861 2020-03-12  Tom Tromey  <tom@tromey.com>
5862
5863         * symfile-mem.c: Update CORE_ADDR size assert.
5864
5865 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5866
5867         * selftest.m4: Move to gdbsupport/.
5868         * acinclude.m4: Update path to selftest.m4.
5869
5870 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5871
5872         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
5873         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
5874         gdbarch-selfselftests.c and selftest-arch.c.
5875         (SUBDIR_UNITTESTS_OBS): Rename to...
5876         (SELFTESTS_OBS): ... this.
5877         (COMMON_SFILES): Remove disasm-selftests.c and
5878         gdbarch-selftests.c.
5879         * configure.ac: Don't add selftest-arch.{c,o} to
5880         CONFIG_{SRCS,OBS}.
5881         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
5882         preprocessor conditions.
5883
5884 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5885
5886         * configure.ac: Don't source bfd/development.sh.
5887         * selftest.m4: Modify comment.
5888         * configure: Re-generate.
5889
5890 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5891
5892         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
5893         not "true" or "false".
5894         * configure: Re-generate.
5895
5896 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5897
5898         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
5899         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
5900         renamed to arm_nbsd_supply_gregset.
5901         (fetch_register): Update to call arm_nbsd_supply_gregset.
5902         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
5903         (arm_netbsd_nat_target::fetch_registers): Update.
5904         (fetch_elfcore_registers): Removed.
5905         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
5906         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
5907         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
5908         not require NetBSD system headers.
5909         (arm_nbsd_regset): New struct.
5910         (arm_nbsd_iterate_over_regset_sections): New function.
5911         (arm_netbsd_init_abi_common): Updated to call
5912         set_gdbarch_iterate_over_regset_sections.
5913         * arm-nbsd-tdep.h: New file.
5914
5915 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
5916
5917         * symtab.c (find_pc_sect_line): Add check which prevents infinite
5918         recursion.
5919
5920 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
5921
5922         * configure: Re-generate.
5923
5924 2020-03-11  Tom Tromey  <tromey@adacore.com>
5925
5926         * ada-typeprint.c (print_choices): Fix comment.
5927
5928 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
5931         previous item in the list, when the list has no items.
5932
5933 2020-03-11  Tom de Vries  <tdevries@suse.de>
5934
5935         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
5936         PROP_LOCLIST handling code.
5937
5938 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5939
5940         * buildsym-legacy.c (record_line): Pass extra parameter to
5941         record_line.
5942         * buildsym.c (buildsym_compunit::record_line): Take an extra
5943         parameter, reduce duplication in the line table, and record the
5944         is_stmt flag in the line table.
5945         * buildsym.h (buildsym_compunit::record_line): Add extra
5946         parameter.
5947         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
5948         non-statement lines.
5949         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
5950         this to the symtab builder.
5951         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
5952         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
5953         through to dwarf_record_line_1.
5954         * infrun.c (process_event_stop_test): When stepping, don't stop at
5955         a non-statement instruction, and only refresh the step info when
5956         we land in the middle of a line's range.  Also add an extra
5957         comment.
5958         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
5959         field.
5960         * record-btrace.c (btrace_find_line_range): Only record lines
5961         marked as is-statement.
5962         * stack.c (frame_show_address): Show the frame address if we are
5963         in a non-statement sal.
5964         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
5965         (maintenance_print_one_line_table): Print a header for the is_stmt
5966         column, and include is_stmt information in the output.
5967         * symtab.c (find_pc_sect_line): Find lines marked as statements in
5968         preference to non-statements.
5969         (find_pcs_for_symtab_line): Prefer is-statement entries.
5970         (find_line_common): Likewise.
5971         * symtab.h (struct linetable_entry): Add is_stmt field.
5972         (struct symtab_and_line): Likewise.
5973         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
5974         arranging the line table.
5975
5976 2020-03-07  Tom de Vries  <tdevries@suse.de>
5977
5978         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
5979         DIE.
5980
5981 2020-03-07  Tom Tromey  <tom@tromey.com>
5982
5983         * valops.c (value_literal_complex): Remove obsolete comment.
5984         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
5985         comment.
5986
5987 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
5988
5989         * infrun.h: Forward-declare thread_info.
5990         (set_step_info): Add thread_info parameter, add doc.
5991         * infrun.c (set_step_info): Add thread_info parameter, move doc
5992         to header.
5993         * infrun.c (process_event_stop_test): Pass thread to
5994         set_step_info call.
5995         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
5996         set_step_info.
5997         (prepare_one_step): Add thread_info parameter, pass it to
5998         set_step_frame and prepare_one_step (recursive) call.
5999         (step_1): Pass thread to prepare_one_step call.
6000         (step_command_fsm::should_stop): Pass thread to
6001         prepare_one_step.
6002         (until_next_fsm): Pass thread to set_step_frame call.
6003         (finish_command): Pass thread to set_step_info call.
6004
6005 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6006
6007         * windows-tdep.c (windows_solib_create_inferior_hook):
6008         Check if inferior is running.
6009
6010 2020-03-06  Tom de Vries  <tdevries@suse.de>
6011
6012         * NEWS: Fix "the the".
6013         * ctfread.c: Same.
6014
6015 2020-03-06  Tom de Vries  <tdevries@suse.de>
6016
6017         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6018
6019 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6020
6021         * .dir-locals.el: Add a comment referencing the other copies of
6022         this file.
6023
6024 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6025
6026         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6027         psargs.
6028
6029 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6030
6031         * .gitattributes: New file.
6032
6033 2020-03-04  Tom Tromey  <tom@tromey.com>
6034
6035         * symmisc.c (print_symbol_bcache_statistics)
6036         (print_objfile_statistics): Update.
6037         * symfile.c (allocate_symtab): Use intern.
6038         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6039         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6040         macro_cache>: Remove.
6041         <string_cache>: New member.
6042         (struct objfile) <intern>: New methods.
6043         * elfread.c (elf_symtab_read): Use intern.
6044         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6045         (dwarf2_compute_name, dwarf2_physname)
6046         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6047         names.
6048         (guess_partial_die_structure_name): Update.
6049         (partial_die_info::fixup): Intern name.
6050         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6051         name.
6052         (dwarf2_name): Intern name.  Update.
6053         * buildsym.c (buildsym_compunit::get_macro_table): Use
6054         string_cache.
6055
6056 2020-03-04  Tom Tromey  <tom@tromey.com>
6057
6058         * jit.c (bfd_open_from_target_memory): Make "target" const.
6059         * corefile.c (gnutarget): Now const.
6060         * gdbcore.h (gnutarget): Now const.
6061
6062 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6063
6064         * NEWS: Mention support for WOW64 processes.
6065         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6066         (amd64_windows_segment_register_p): Remove static.
6067         (_initialize_amd64_windows_nat): Update.
6068         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6069         * i386-windows-nat.c (context_offset): Update.
6070         (i386_mappings): Rename and remove static.
6071         (i386_windows_segment_register_p): Remove static.
6072         (_initialize_i386_windows_nat): Update.
6073         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6074         (STATUS_WX86_SINGLE_STEP): New macro.
6075         (EnumProcessModulesEx): New macro.
6076         (Wow64SuspendThread): New macro.
6077         (Wow64GetThreadContext): New macro.
6078         (Wow64SetThreadContext): New macro.
6079         (Wow64GetThreadSelectorEntry): New macro.
6080         (windows_set_context_register_offsets): Add static.
6081         (windows_set_segment_register_p): Likewise.
6082         (windows_add_thread): Adapt for WOW64 processes.
6083         (windows_fetch_one_register): Likewise.
6084         (windows_nat_target::fetch_registers): Likewise.
6085         (windows_store_one_register): Likewise.
6086         (display_selector): Likewise.
6087         (display_selectors): Likewise.
6088         (handle_exception): Likewise.
6089         (windows_continue): Likewise.
6090         (windows_nat_target::resume): Likewise.
6091         (windows_add_all_dlls): Likewise.
6092         (do_initial_windows_stuff): Likewise.
6093         (windows_nat_target::attach): Likewise.
6094         (windows_get_exec_module_filename): Likewise.
6095         (windows_nat_target::create_inferior): Likewise.
6096         (windows_xfer_siginfo): Likewise.
6097         (_initialize_loadable): Initialize Wow64SuspendThread,
6098         Wow64GetThreadContext, Wow64SetThreadContext,
6099         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6100         * windows-nat.h (windows_set_context_register_offsets):
6101         Remove declaration.
6102         (windows_set_segment_register_p): Likewise.
6103         (i386_windows_segment_register_p): Add declaration.
6104         (amd64_windows_segment_register_p): Likewise.
6105
6106 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6107
6108         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6109         in "info registers" for AArch64/ARM.
6110
6111         The change caused "info registers" to not print GPR's.
6112
6113         gdb/ChangeLog:
6114
6115         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6116
6117         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6118         when reg->group is empty and reggroup is not.
6119
6120 2020-03-03  Tom Tromey  <tromey@adacore.com>
6121
6122         * dwarf2/frame.c (struct dwarf2_frame_cache)
6123         <checked_tailcall_bottom, entry_cfa_sp_offset,
6124         entry_cfa_sp_offset_p>: Remove members.
6125         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6126         (dwarf2_frame_prev_register): Don't call
6127         dwarf2_tailcall_sniffer_first.
6128         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6129         * frame-unwind.c (add_unwinder): New fuction.
6130         (frame_unwind_init): Use it.  Add tailcall unwinder.
6131
6132 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6133             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6134
6135         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6136         value should be printed as true.
6137
6138 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6139
6140         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6141         (windows_init_abi): Set and use windows_so_ops.
6142
6143 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6144
6145         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6146         when verifying if dealing with a convenience variable.
6147
6148 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6149
6150         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6151
6152 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6153
6154         * infrun.c (gdbarch_supports_displaced_stepping): New.
6155         (use_displaced_stepping): Break up conditions in smaller pieces.
6156         Use gdbarch_supports_displaced_stepping.
6157         (displaced_step_prepare_throw): Use
6158         gdbarch_supports_displaced_stepping.
6159
6160 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6161
6162         * NEWS: Mention new behaviour of the history filename.
6163         * top.c (write_history_p): Add comment.
6164         (show_write_history_p): Add header comment, give a different
6165         message when history writing is on, but the history filename is
6166         empty.
6167         (history_filename): Add comment.
6168         (history_filename_empty): New function.
6169         (show_history_filename): Add header comment, give a different
6170         message when the filename is empty.
6171         (init_history): Compare history_filename against nullptr, and only
6172         read history if the filename is not empty.
6173         (set_history_filename): Add header comment, and only make
6174         non-empty filenames absolute.
6175         (init_main): Make the filename argument to 'set history filename'
6176         optional.
6177
6178 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
6179
6180         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
6181         (arm_supply_vfpregset): ...this, and update to use VFP registers.
6182         (fetch_fp_register): Update.
6183         (fetch_fp_regs): Update.
6184         (store_fp_register): Update.
6185         (store_fp_regs): Update.
6186         (arm_netbsd_nat_target::read_description): New function.
6187         (fetch_elfcore_registers): Update.
6188
6189 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6190
6191         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
6192         general_thread if the stop reply is missing a thread-id.
6193         (remote_target::process_stop_reply): Use the first non-exited
6194         thread if the target didn't pass a thread-id.
6195         * infrun.c (do_target_wait): Move call to
6196         switch_to_inferior_no_thread to ....
6197         (do_target_wait_1): ... here.
6198
6199 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
6200
6201         * debuginfod-support.c: Include defs.h first.
6202
6203 2020-02-28  Tom de Vries  <tdevries@suse.de>
6204
6205         * symfile.c (set_initial_language): Use default language for lookup.
6206
6207 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
6208
6209         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
6210         reader variable, pass `this` to read_cutu_die_from_dwo.
6211
6212 2020-02-27  Aaron Merey  <amerey@redhat.com>
6213
6214         * source.c (open_source_file): Check for nullptr when computing
6215         srcpath.
6216
6217 2020-02-27  Tom Tromey  <tromey@adacore.com>
6218
6219         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
6220         member.
6221         (dwarf2_add_field): Don't update nfields.
6222         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
6223
6224 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6225
6226         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
6227         abs.
6228
6229 2020-02-26  Tom Tromey  <tom@tromey.com>
6230
6231         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
6232         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
6233         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
6234         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
6235         per_cu_data.
6236
6237 2020-02-26  Tom Tromey  <tom@tromey.com>
6238
6239         * dwarf2/index-write.c (psym_index_map): Change type.
6240         (add_address_entry_worker, write_one_signatured_type)
6241         (recursively_count_psymbols, recursively_write_psymbols)
6242         (class debug_names, psyms_seen_size, write_gdbindex)
6243         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
6244
6245 2020-02-26  Aaron Merey  <amerey@redhat.com>
6246
6247         * Makefile.in: Handle optional debuginfod support.
6248         * NEWS: Update.
6249         * README: Add --with-debuginfod summary.
6250         * config.in: Regenerate.
6251         * configure: Regenerate.
6252         * configure.ac: Handle optional debuginfod support.
6253         * debuginfod-support.c: debuginfod helper functions.
6254         * debuginfod-support.h: Ditto.
6255         * doc/gdb.texinfo: Add --with-debuginfod to configure options
6256         summary.
6257         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
6258         when a dwz file cannot be found.
6259         * elfread.c (elf_symfile_read): Query debuginfod servers when a
6260         debuginfo file cannot be found.
6261         * source.c (open_source_file): Query debuginfod servers when a
6262         source file cannot be found.
6263         * top.c (print_gdb_configuration): Include
6264         --{with,without}-debuginfod in the output.
6265
6266 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
6267
6268         * thread.c (thr_try_catch_cmd): Print thread name.
6269
6270 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
6271
6272         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
6273         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6274         dwarf2_fetch_die_type_sect_off): Move to...
6275         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
6276         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6277         dwarf2_fetch_die_type_sect_off): ... here.
6278         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
6279         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6280         dwarf2_fetch_die_type_sect_off): Move doc to header file.
6281
6282 2020-02-26  Tom de Vries  <tdevries@suse.de>
6283
6284         PR gdb/25603
6285         * symfile.c (set_initial_language): Exit-early if
6286         language_mode == language_mode_manual.
6287
6288 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6289
6290         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
6291         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
6292         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
6293
6294 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * gdbtypes.c (create_array_type_with_stride): Handle negative
6297         array strides.
6298         * valarith.c (value_subscripted_rvalue): Likewise.
6299
6300 2020-02-25  Luis Machado  <luis.machado@linaro.org>
6301
6302         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
6303
6304 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6305
6306         * loc.h (dwarf2_get_die_type): Move to...
6307         * read.h (dwarf2_get_die_type): ... here.
6308         * read.c (dwarf2_get_die_type): Move doc to header.
6309
6310 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
6311
6312         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
6313         'gnulib/Makefile.in' to the list.
6314
6315 2020-02-24  Tom Tromey  <tom@tromey.com>
6316
6317         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
6318         Remove.
6319         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
6320         XOBNEWVEC.
6321
6322 2020-02-24  Tom Tromey  <tom@tromey.com>
6323
6324         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
6325         New method.
6326         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
6327         (dw2_do_instantiate_symtab, dw2_get_file_names)
6328         (build_type_psymtab_dependencies, load_full_type_unit): Update.
6329
6330 2020-02-24  Tom Tromey  <tom@tromey.com>
6331
6332         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
6333         make_scoped_restore.
6334         (dwarf2_psymtab::read_symtab): Don't clear
6335         reading_partial_symbols.
6336
6337 2020-02-24  Tom de Vries  <tdevries@suse.de>
6338
6339         PR gdb/25592
6340         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
6341
6342 2020-02-24  Tom de Vries  <tdevries@suse.de>
6343
6344         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
6345         commands layout next/prev/regs.
6346
6347 2020-02-22  Tom Tromey  <tom@tromey.com>
6348
6349         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
6350         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
6351
6352 2020-02-22  Tom Tromey  <tom@tromey.com>
6353
6354         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
6355
6356 2020-02-22  Tom Tromey  <tom@tromey.com>
6357
6358         * tui/tui-win.c (_initialize_tui_win): Add usage text.
6359         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
6360         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
6361         * tui/tui.c (_initialize_tui): Add usage text.
6362
6363 2020-02-22  Tom Tromey  <tom@tromey.com>
6364
6365         * tui/tui-win.c (tui_set_focus_command)
6366         (tui_set_win_height_command): Use error_no_arg.
6367         (_initialize_tui_win): Update help text.
6368         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
6369
6370 2020-02-22  Tom Tromey  <tom@tromey.com>
6371
6372         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
6373         * tui/tui-disasm.h (struct tui_disasm_window)
6374         <display_start_addr>: Declare.
6375         * tui/tui-source.h (struct tui_source_window)
6376         <display_start_addr>: Declare.
6377         * tui/tui-winsource.h (struct tui_source_window_base)
6378         <show_source_line, display_start_addr>: New methods.
6379         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
6380         Rename and move to protected section.
6381         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
6382         (tui_source_window_base::do_erase_source_content): Update.
6383         (tui_source_window_base::show_source_line): Now a method.
6384         (tui_source_window_base::show_source_content)
6385         (tui_source_window_base::tui_source_window_base)
6386         (tui_source_window_base::rerender)
6387         (tui_source_window_base::refill)
6388         (tui_source_window_base::do_scroll_horizontal)
6389         (tui_source_window_base::set_is_exec_point_at)
6390         (tui_source_window_base::update_breakpoint_info)
6391         (tui_source_window_base::update_exec_info): Update.
6392         * tui/tui-source.c (tui_source_window::set_contents)
6393         (tui_source_window::showing_source_p)
6394         (tui_source_window::do_scroll_vertical)
6395         (tui_source_window::location_matches_p)
6396         (tui_source_window::line_is_displayed): Update.
6397         (tui_source_window::display_start_addr): New method.
6398         * tui/tui-disasm.c (tui_disasm_window::set_contents)
6399         (tui_disasm_window::do_scroll_vertical)
6400         (tui_disasm_window::location_matches_p): Update.
6401         (tui_disasm_window::display_start_addr): New method.
6402
6403 2020-02-22  Tom Tromey  <tom@tromey.com>
6404
6405         * NEWS: Add entry for gdb.register_window_type.
6406         * tui/tui-layout.h (window_factory): New typedef.
6407         (tui_register_window): Declare.
6408         * tui/tui-layout.c (saved_tui_windows): New global.
6409         (tui_apply_current_layout): Use it.
6410         (tui_register_window): New function.
6411         * python/python.c (do_start_initialization): Call
6412         gdbpy_initialize_tui.
6413         (python_GdbMethods): Add "register_window_type" function.
6414         * python/python-internal.h (gdbpy_register_tui_window)
6415         (gdbpy_initialize_tui): Declare.
6416         * python/py-tui.c: New file.
6417         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
6418
6419 2020-02-22  Tom Tromey  <tom@tromey.com>
6420
6421         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
6422
6423 2020-02-22  Tom Tromey  <tom@tromey.com>
6424
6425         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
6426         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
6427         * tui/tui-data.c (tui_set_win_with_focus): Remove.
6428         (tui_set_win_focus_to): Move from tui-win.c.
6429
6430 2020-02-22  Tom Tromey  <tom@tromey.com>
6431
6432         * tui/tui-layout.c (make_standard_window, get_locator_window): New
6433         functions.
6434         (known_window_types): New global.
6435         (tui_get_window_by_name): Reimplement.
6436         (initialize_known_windows): New function.
6437         (validate_window_name): Rewrite.
6438         (_initialize_tui_layout): Call initialize_known_windows.
6439
6440 2020-02-22  Tom Tromey  <tom@tromey.com>
6441
6442         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
6443         Remove constants.
6444         * tui/tui-winsource.h (struct tui_source_window_base)
6445         <tui_source_window_base>: Remove parameter.
6446         * tui/tui-winsource.c
6447         (tui_source_window_base::tui_source_window_base): Remove
6448         parameter.
6449         (tui_source_window_base::refill): Update.
6450         * tui/tui-stack.h (struct tui_locator_window)
6451         <tui_locator_window>: Update.
6452         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
6453         Default the constructor.
6454         * tui/tui-regs.h (struct tui_data_item_window)
6455         <tui_data_item_window>: Default the constructor.
6456         (struct tui_data_window) <tui_data_window>: Likewise.
6457         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
6458         Default the constructor.
6459         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
6460         Default the constructor.
6461         <type>: Remove.
6462         (struct tui_win_info) <tui_win_info>: Default the constructor.
6463         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
6464         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
6465         Default the constructor.
6466
6467 2020-02-22  Tom Tromey  <tom@tromey.com>
6468
6469         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
6470         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
6471         * tui/tui-win.c (tui_resize_all): Don't call
6472         tui_delete_invisible_windows.
6473         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
6474         done.
6475         (tui_set_layout): Update.
6476         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
6477         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
6478         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
6479
6480 2020-02-22  Tom Tromey  <tom@tromey.com>
6481
6482         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
6483         correctly.
6484
6485 2020-02-22  Tom Tromey  <tom@tromey.com>
6486
6487         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
6488
6489 2020-02-22  Tom Tromey  <tom@tromey.com>
6490
6491         * tui/tui-winsource.h (struct tui_source_window_iterator)
6492         <inner_iterator>: New etytypedef.
6493         <tui_source_window_iterator>: Take "end" parameter.
6494         <tui_source_window_iterator>: Take iterator.
6495         <operator*, advance>: Update.
6496         <m_iter>: Change type.
6497         <m_end>: New field.
6498         (struct tui_source_windows) <begin, end>: Update.
6499         * tui/tui-layout.c (tui_windows): New global.
6500         (tui_apply_current_layout): Clear tui_windows.
6501         (tui_layout_window::apply): Update tui_windows.
6502         * tui/tui-data.h (tui_windows): Declare.
6503         (all_tui_windows): Now inline function.
6504         (class tui_window_iterator, struct all_tui_windows): Remove.
6505
6506 2020-02-22  Tom Tromey  <tom@tromey.com>
6507
6508         PR tui/17850:
6509         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
6510         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
6511         "height" argument.
6512         (class tui_layout_window) <get_sizes>: Likewise.
6513         (class tui_layout_split) <tui_layout_split>: Add "vertical"
6514         argument.
6515         <get_sizes>: Add "height" argument.
6516         <m_vertical>: New field.
6517         * tui/tui-layout.c (tui_layout_split::clone): Update.
6518         (tui_layout_split::get_sizes): Add "height" argument.
6519         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
6520         (tui_new_layout_command): Parse "-horizontal".
6521         (_initialize_tui_layout): Update help string.
6522         (tui_layout_split::specification): Add "-horizontal" when needed.
6523         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
6524         argument.
6525         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
6526         New methods.
6527
6528 2020-02-22  Tom Tromey  <tom@tromey.com>
6529
6530         * tui/tui-layout.h (enum tui_adjust_result): New.
6531         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
6532         (class tui_layout_window) <adjust_size>: Return
6533         tui_adjust_result.  Rewrite.
6534         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
6535         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
6536
6537 2020-02-22  Tom Tromey  <tom@tromey.com>
6538
6539         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
6540         parameter and return types.
6541         (class tui_layout_base) <specification>: Add "depth".
6542         (class tui_layout_window) <specification>: Add "depth".
6543         (class tui_layout_split) <specification>: Add "depth".
6544         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
6545         and return types.
6546         (tui_new_layout_command): Parse sub-layouts.
6547         (_initialize_tui_layout): Update help string.
6548         (tui_layout_window::specification): Add "depth".
6549         (add_layout_command): Update.
6550
6551 2020-02-22  Tom Tromey  <tom@tromey.com>
6552
6553         * NEWS: Add "tui new-layout" item.
6554         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
6555         Add new-layout command to help text.
6556         (validate_window_name): New function.
6557         (tui_new_layout_command): New function.
6558         (_initialize_tui_layout): Register "new-layout".
6559         (tui_layout_window::specification): New method.
6560         (tui_layout_window::specification): New method.
6561         * tui/tui-layout.h (class tui_layout_base) <specification>: New
6562         method.
6563         (class tui_layout_window) <specification>: New method.
6564         (class tui_layout_split) <specification>: New method.
6565
6566 2020-02-22  Tom Tromey  <tom@tromey.com>
6567
6568         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
6569         * tui/tui-win.c (window_name_completer): Update comment.
6570         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
6571         Declare method.
6572         (class tui_layout_window) <replace_window>: Likewise.
6573         (class tui_layout_split) <replace_window>: Likewise.
6574         (tui_set_layout): Don't declare.
6575         (tui_set_initial_layout): Declare function.
6576         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
6577         (asm_regs_layout): New globals.
6578         (tui_current_layout, show_layout): Remove.
6579         (tui_set_layout, tui_add_win_to_layout): Rewrite.
6580         (find_layout, tui_apply_layout): New function.
6581         (layout_completer): Remove.
6582         (tui_next_layout): Reimplement.
6583         (tui_next_layout_command): New function.
6584         (tui_set_initial_layout, tui_prev_layout_command): New functions.
6585         (tui_regs_layout): Reimplement.
6586         (tui_regs_layout_command): New function.
6587         (extract_display_start_addr): Rewrite.
6588         (next_layout, prev_layout): Remove.
6589         (tui_layout_window::replace_window): New method.
6590         (tui_layout_split::replace_window): New method.
6591         (destroy_layout): New function.
6592         (layout_list): New global.
6593         (add_layout_command): New function.
6594         (initialize_layouts): Update.
6595         (tui_layout_command): New function.
6596         (_initialize_tui_layout): Install "layout" commands.
6597         * tui/tui-data.h (enum tui_layout_type): Remove.
6598         (tui_current_layout): Don't declare.
6599
6600 2020-02-22  Tom Tromey  <tom@tromey.com>
6601
6602         * tui/tui-regs.c (tui_reg_layout): Remove.
6603         (tui_reg_command): Use tui_regs_layout.
6604         * tui/tui-layout.h (tui_reg_command): Declare.
6605         * tui/tui-layout.c (tui_reg_command): New function.
6606
6607 2020-02-22  Tom Tromey  <tom@tromey.com>
6608
6609         * tui/tui.c (tui_rl_delete_other_windows): Call
6610         tui_remove_some_windows.
6611         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
6612         Declare method.
6613         (class tui_layout_window) <remove_windows>: New method.
6614         (class tui_layout_split) <remove_windows>: Declare.
6615         (tui_remove_some_windows): Declare.
6616         * tui/tui-layout.c (tui_remove_some_windows): New function.
6617         (tui_layout_split::remove_windows): New method.
6618
6619 2020-02-22  Tom Tromey  <tom@tromey.com>
6620
6621         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
6622         * tui/tui-layout.h (tui_next_layout): Declare.
6623         * tui/tui-layout.c (tui_next_layout): New function.
6624
6625 2020-02-22  Tom Tromey  <tom@tromey.com>
6626
6627         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
6628         correct coordinates.
6629
6630 2020-02-22  Tom Tromey  <tom@tromey.com>
6631
6632         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
6633         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
6634         DATA_WIN case.
6635
6636 2020-02-22  Tom Tromey  <tom@tromey.com>
6637
6638         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
6639         TUI_DISASM_WIN, not tui_win_list.
6640
6641 2020-02-22  Tom Tromey  <tom@tromey.com>
6642
6643         * valprint.c (generic_val_print_enum_1)
6644         (val_print_type_code_flags): Style member names.
6645         * rust-lang.c (val_print_struct, rust_print_enum)
6646         (rust_print_struct_def, rust_internal_print_type): Style member
6647         names.
6648         * p-valprint.c (pascal_object_print_value_fields): Style member
6649         names.  Only call fprintf_symbol_filtered for static members.
6650         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
6651         * f-valprint.c (f_val_print): Style member names.
6652         * f-typeprint.c (f_type_print_base): Style member names.
6653         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
6654         call fprintf_symbol_filtered for static members.
6655         (cp_print_class_member): Style member names.
6656         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
6657         member names.
6658         * ada-valprint.c (ada_print_scalar): Style enum names.
6659         (ada_val_print_enum): Likewise.
6660         * ada-typeprint.c (print_enum_type): Style enum names.
6661
6662 2020-02-21  Tom Tromey  <tom@tromey.com>
6663
6664         * psympriv.h (struct partial_symtab): Update comment.
6665
6666 2020-02-21  Tom Tromey  <tromey@adacore.com>
6667
6668         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
6669         type is CORE_ADDR.
6670
6671 2020-02-21  Tom de Vries  <tdevries@suse.de>
6672
6673         PR gdb/25534
6674         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
6675         if dependencies[i]->user != NULL.
6676
6677 2020-02-21  Ali Tamur  <tamur@google.com>
6678
6679         * dwarf2/read.c (dwarf2_name): Add null check.
6680
6681 2020-02-20  Tom Tromey  <tom@tromey.com>
6682
6683         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
6684         ">=", in binary search.
6685         (dwarf2_find_containing_comp_unit): New overload.
6686         (run_test): New self-test.
6687         (_initialize_dwarf2_read): Register new test.
6688
6689 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
6690
6691         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
6692         * riscv-tdep.h: Likewise.
6693         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
6694         rv32-only CSR.
6695         * features/riscv/64bit-csr.xml: Regenerated.
6696
6697 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
6698             Tom Tromey  <tom@tromey.com>
6699
6700         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
6701         of 'fputc_unfiltered'.
6702         (putchar_unfiltered): Call 'fputc_unfiltered'.
6703         (fputc_unfiltered): Call 'fputs_unfiltered'.
6704
6705 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
6706
6707         * config.in: Regenerate.
6708         * configure: Regenerate.
6709         * configure.ac: Add --with-python-libdir option.
6710         * main.c: Use WITH_PYTHON_LIBDIR.
6711
6712 2020-02-19  Tom Tromey  <tom@tromey.com>
6713
6714         * symtab.c (general_symbol_info::compute_and_set_names): Use
6715         obstack_strndup.  Simplify call to symbol_set_demangled_name.
6716
6717 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
6718
6719         * dwarf2/read.c (allocate_signatured_type_table,
6720         allocate_dwo_unit_table, allocate_type_unit_groups_table,
6721         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
6722         Remove objfile parameter, update all callers.
6723
6724 2020-02-19  Doug Evans  <dje@google.com>
6725
6726         PR rust/25535
6727         * rust-lang.c (rust_print_enum): Apply embedded_offset to
6728         rust_enum_variant calculation.
6729
6730 2020-02-19  Tom Tromey  <tromey@adacore.com>
6731
6732         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
6733
6734 2020-02-19  Tom Tromey  <tromey@adacore.com>
6735
6736         * ada-lang.c (cache_symbol): Use obstack_strdup.
6737
6738 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * configure: Regenerate.
6741
6742 2020-02-19  Tom Tromey  <tromey@adacore.com>
6743
6744         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
6745         NULL check.
6746
6747 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
6748
6749         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
6750
6751 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6752
6753         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
6754         if GDBSERVER is not defined.
6755         (riscv_tdesc_cache): Likewise, also store const target_desc.
6756         (STATIC_IN_GDB): Define.
6757         (riscv_create_target_description): Update declaration with
6758         STATIC_IN_GDB.
6759         (riscv_lookup_target_description): New function, only define if
6760         GDBSERVER is not defined.
6761         * arch/riscv.h (riscv_create_target_description): Declare only
6762         when GDBSERVER is defined.
6763         (riscv_lookup_target_description): New declaration when GDBSERVER
6764         is not defined.
6765         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
6766         (riscv_linux_read_features): ...this, and return
6767         riscv_gdbarch_features instead of target_desc.
6768         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
6769         (riscv_linux_read_description): Rename to...
6770         (riscv_linux_read_features): ...this.
6771         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
6772         Update to use riscv_gdbarch_features and
6773         riscv_lookup_target_description.
6774         * riscv-tdep.c (riscv_find_default_target_description): Use
6775         riscv_lookup_target_description instead of
6776         riscv_create_target_description.
6777
6778 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6779
6780         * valprint.c (generic_val_print_enum_1): When printing a flag
6781         enum with value 0 and there is no enumerator with value 0, print
6782         just "0" instead of "(unknown: 0x0)".
6783
6784 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6785
6786         * valprint.c (generic_val_print_enum_1): Print unknown part of
6787         flag enum in hex.
6788
6789 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6790
6791         * dwarf2/read.c (update_enumeration_type_from_children): Allow
6792         flag enums to contain duplicate enumerators.
6793         * valprint.c (generic_val_print_enum_1): Update comment.
6794
6795 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6796
6797         * dwarf2/read.c: Include "count-one-bits.h".
6798         (update_enumeration_type_from_children): If an enumerator has
6799         multiple bits set, don't treat the enumeration as a "flag enum".
6800         * valprint.c (generic_val_print_enum_1): Assert that enumerators
6801         of flag enums have 0 or 1 bit set.
6802
6803 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6804
6805         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
6806         conversion.
6807         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6808         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6809         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6810         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6811         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6812
6813 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6814
6815         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
6816
6817 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6818
6819         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
6820         displaced_step_closure_up.
6821         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6822         (struct displaced_step_closure_up):
6823         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6824         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6825         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
6826         Likewise.
6827         * gdbarch.sh (displaced_step_copy_insn): Likewise.
6828         * gdbarch.c, gdbarch.h: Re-generate.
6829         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
6830         displaced_step_closure_up.
6831         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6832         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6833         * infrun.h (displaced_step_closure_up): New type alias.
6834         (struct displaced_step_inferior_state) <step_closure>: Change
6835         type to displaced_step_closure_up.
6836         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
6837         displaced_step_closure_up.
6838         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6839
6840 2020-02-14  Tom Tromey  <tom@tromey.com>
6841
6842         * minidebug.c (gnu_debug_key): New global.
6843         (find_separate_debug_file_in_section): Use it.
6844
6845 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6846
6847         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
6848         std::unique_ptr.
6849         * gdbarch.c: Re-generate.
6850         * gdbarch.h: Re-generate.
6851         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
6852         change.
6853         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
6854         type to std::unique_ptr.
6855         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6856         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6857         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6858         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6859         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
6860         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6861         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6862         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6863         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6864
6865 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6866
6867         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
6868         std::unique_ptr.
6869         (displaced_step_clear): Rename to...
6870         (displaced_step_reset): ... this.  Just call displaced->reset ().
6871         (displaced_step_clear_cleanup): Rename to...
6872         (displaced_step_reset_cleanup): ... this.
6873         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
6874         (displaced_step_fixup): Likewise.
6875         (resume_1): Likewise.
6876         (handle_inferior_event): Restore child's memory before calling
6877         displaced_step_fixup on the parent.
6878         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
6879         to std::unique_ptr.
6880         <step_closure>: Change type to std::unique_ptr.
6881
6882 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6883
6884         * arm-tdep.c: Include count-one-bits.h.
6885         (cleanup_block_store_pc): Use count_one_bits.
6886         (cleanup_block_load_pc): Use count_one_bits.
6887         (arm_copy_block_xfer): Use count_one_bits.
6888         (thumb2_copy_block_xfer): Use count_one_bits.
6889         (thumb_copy_pop_pc_16bit): Use count_one_bits.
6890         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
6891         (thumb_get_next_pcs_raw): Use count_one_bits.
6892         (arm_get_next_pcs_raw): Use count_one_bits_l.
6893         * arch/arm.c (bitcount): Remove.
6894         * arch/arm.h (bitcount): Remove.
6895
6896 2020-02-14  Tom Tromey  <tromey@adacore.com>
6897
6898         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
6899         Update.
6900         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
6901         * dwarf2/loc.c (call_site_find_chain_1): Return
6902         unique_xmalloc_ptr.
6903         (call_site_find_chain): Likewise.
6904
6905 2020-02-14  Richard Biener  <rguenther@suse.de>
6906
6907         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
6908         on expression with division operators.
6909
6910 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6911
6912         * MAINTAINERS (Write After Approval): Adding myself.
6913
6914 2020-02-12  Tom Tromey  <tom@tromey.com>
6915
6916         * event-loop.c (event_data, gdb_event, event_handler_func):
6917         Remove.
6918
6919 2020-02-12  Tom Tromey  <tom@tromey.com>
6920
6921         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
6922         (dwarf2_frame_objfile_data): Add comment.
6923         (find_comp_unit, set_comp_unit): New functions.
6924         (dwarf2_frame_find_fde): Use find_comp_unit.
6925         (dwarf2_build_frame_info): Use set_comp_unit.
6926
6927 2020-02-12  Tom Tromey  <tom@tromey.com>
6928
6929         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
6930         (comp_unit): Don't initialize objfile.
6931         (execute_cfa_program): Add text_offset parameter.
6932         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
6933         (dwarf2_frame_cache): Update.
6934         (dwarf2_build_frame_info): Don't set "objfile" member.
6935
6936 2020-02-12  Tom Tromey  <tom@tromey.com>
6937
6938         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
6939         (decode_frame_entry): Likewise.
6940         (dwarf2_build_frame_info): Update.
6941
6942 2020-02-12  Tom Tromey  <tom@tromey.com>
6943
6944         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
6945         (decode_frame_entry_1): Use the comp_unit obstack.
6946
6947 2020-02-12  Tom Tromey  <tom@tromey.com>
6948
6949         * dwarf2/frame.c (struct comp_unit): Add initializers and
6950         constructor.
6951         (dwarf2_frame_objfile_data): Store a comp_unit.
6952         (dwarf2_frame_find_fde): Update.
6953         (dwarf2_build_frame_info): Use "new".
6954
6955 2020-02-12  Tom Tromey  <tom@tromey.com>
6956
6957         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
6958         (dwarf2_fde_table): Typedef for std::vector.
6959         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
6960         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
6961         (decode_frame_entry): Update.
6962         (dwarf2_build_frame_info): Use "new".
6963
6964 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
6965
6966         * arm-tdep.c (arm_gdbarch_init): Update.
6967         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
6968         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
6969         have_neon, is_m>: Change to bool.
6970
6971 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
6972
6973         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
6974
6975 2020-02-12  Tom Tromey  <tom@tromey.com>
6976
6977         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
6978
6979 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
6980
6981         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
6982         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
6983
6984 2020-02-11  Tom Tromey  <tom@tromey.com>
6985
6986         * psymtab.h: Update comment.
6987
6988 2020-02-11  Tom Tromey  <tom@tromey.com>
6989
6990         * gdb_obstack.h (struct auto_obstack): Use
6991         DISABLE_COPY_AND_ASSIGN.
6992
6993 2020-02-11  Tom Tromey  <tom@tromey.com>
6994
6995         * dwarf2/frame.h (struct objfile): Don't forward declare.
6996
6997 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
6998
6999         * cris-tdep.c (cris_supply_gregset): Change signature to match
7000         what struct regset expects.
7001         (cris_regset): New struct.
7002         (fetch_core_registers): Remove.
7003         (cris_iterate_over_regset_sections): New function.
7004         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7005         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7006
7007 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7008
7009         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7010         registers.
7011
7012 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7013
7014         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7015
7016 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7017
7018         * configure: Re-generate.
7019
7020 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7021
7022         * configure: Re-generate.
7023
7024 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7025
7026         * acinclude: Update warning.m4 path.
7027         * warning.m4: Move to gdbsupport.
7028
7029 2020-02-11  Tom Tromey  <tromey@adacore.com>
7030
7031         * remote.c (remote_console_output): Update.
7032         * printcmd.c (printf_command): Update.
7033         * event-loop.c (gdb_wait_for_event): Update.
7034         * linux-nat.c (sigchld_handler): Update.
7035         * remote-sim.c (gdb_os_write_stdout): Update.
7036         (gdb_os_flush_stdout): Update.
7037         (gdb_os_flush_stderr): Update.
7038         (gdb_os_write_stderr): Update.
7039         * exceptions.c (print_exception): Update.
7040         * remote-fileio.c (remote_fileio_func_read): Update.
7041         (remote_fileio_func_write): Update.
7042         * tui/tui.c (tui_enable): Update.
7043         * tui/tui-interp.c (tui_interp::init): Update.
7044         * utils.c (init_page_info): Update.
7045         (putchar_unfiltered, fputc_unfiltered): Update.
7046         (gdb_flush): Update.
7047         (emit_style_escape): Update.
7048         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7049         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7050         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7051         (stderr_file::write): Update.
7052         (stderr_file::puts): Update.
7053         * ui-file.h (ui_file_isatty, ui_file_write)
7054         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7055         (ui_file_puts): Don't declare.
7056
7057 2020-02-10  Tom de Vries  <tdevries@suse.de>
7058
7059         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7060         sentinel to char *.
7061
7062 2020-02-09  Tom de Vries  <tdevries@suse.de>
7063
7064         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7065         filename if it matches "<artificial>".
7066
7067 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7068
7069         * windows-tdep.c (struct enum_value_name): New struct.
7070         (create_enum): New function.
7071         (windows_get_siginfo_type): Create and use enum types.
7072
7073 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7074
7075         * NEWS: Mention $_siginfo support for Windows.
7076         * windows-nat.c (handle_exception): Set siginfo_er.
7077         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7078         (windows_xfer_siginfo): New function.
7079         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7080         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7081         (init_windows_gdbarch_data): New function.
7082         (get_windows_gdbarch_data): New function.
7083         (windows_get_siginfo_type): New function.
7084         (windows_init_abi): Register windows_get_siginfo_type.
7085         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7086
7087 2020-02-08  Tom Tromey  <tom@tromey.com>
7088
7089         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7090         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7091         <keep>: Declare method.
7092         <m_keep>: Remove member.
7093         <~cutu_reader>: Remove.
7094         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7095         (cutu_reader::cutu_reader): Update.
7096         (cutu_reader::keep): Rename from ~cutu_reader.
7097         (process_psymtab_comp_unit, build_type_psymtabs_1)
7098         (process_skeletonless_type_unit, load_partial_comp_unit)
7099         (load_full_comp_unit, dwarf2_read_addr_index)
7100         (read_signatured_type): Update.
7101
7102 2020-02-08  Tom Tromey  <tom@tromey.com>
7103
7104         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7105         "want_partial_unit" parameter.
7106         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7107         Inline check for DW_TAG_partial_unit.
7108         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7109
7110 2020-02-08  Tom Tromey  <tom@tromey.com>
7111
7112         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7113         read.c.
7114         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7115         read.c.
7116
7117 2020-02-08  Tom Tromey  <tom@tromey.com>
7118
7119         * dwarf2/read.c (read_address): Move to comp-unit.c.
7120         (dwarf2_rnglists_process, dwarf2_ranges_process)
7121         (read_attribute_value, dwarf_decode_lines_1)
7122         (var_decode_location, decode_locdesc): Update.
7123         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7124         read.c.  Remove "cu" parameter.
7125         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7126         method.
7127
7128 2020-02-08  Tom Tromey  <tom@tromey.com>
7129
7130         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7131         (read_indirect_line_string): Update.
7132         * dwarf2/comp-unit.c (read_offset): Remove.
7133         (read_comp_unit_head): Update.
7134         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7135         method.
7136         (read_offset): Don't declare.
7137
7138 2020-02-08  Tom Tromey  <tom@tromey.com>
7139
7140         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7141         * dwarf2/read.c (struct comp_unit_head): Move to
7142         dwarf2/comp-unit.h.
7143         (enum class rcuh_kind): Move to comp-unit.h.
7144         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7145         (read_comp_unit_head, error_check_comp_unit_head)
7146         (read_and_check_comp_unit_head): Move to comp-unit.c.
7147         (read_offset, dwarf_unit_type_name): Likewise.
7148         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7149         (cutu_reader::cutu_reader, read_call_site_scope)
7150         (find_partial_die, follow_die_offset): Update.
7151         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7152
7153 2020-02-08  Tom Tromey  <tom@tromey.com>
7154
7155         * dwarf2/read.c (read_offset_1): Move to leb.c.
7156         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7157         (dwarf_decode_macro_bytes): Update.
7158         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7159         * dwarf2/leb.h (read_offset): Declare.
7160
7161 2020-02-08  Tom Tromey  <tom@tromey.com>
7162
7163         * dwarf2/read.c (dwarf2_section_size): Remove.
7164         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7165         Update.
7166         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7167
7168 2020-02-08  Tom Tromey  <tom@tromey.com>
7169
7170         * dwarf2/read.c (read_initial_length): Move to leb.c.
7171         * dwarf2/leb.h (read_initial_length): Declare.
7172         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7173         handle_nonstd parameter.
7174         * dwarf2/frame.c (read_initial_length): Remove.
7175         (decode_frame_entry_1): Update.
7176
7177 2020-02-08  Tom Tromey  <tom@tromey.com>
7178
7179         * dwarf2/loc.c (dwarf2_find_location_expression)
7180         (dwarf_evaluate_loc_desc::get_tls_address)
7181         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
7182         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
7183         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
7184         (dwarf2_compile_property_to_c)
7185         (dwarf2_loc_desc_get_symbol_read_needs)
7186         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
7187         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
7188         (loclist_describe_location, loclist_tracepoint_var_ref)
7189         (loclist_generate_c_location): Update.
7190         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
7191         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
7192         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
7193         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
7194         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
7195         (dwarf2_per_cu_data::addr_size)
7196         (dwarf2_per_cu_data::ref_addr_size)
7197         (dwarf2_per_cu_data::text_offset)
7198         (dwarf2_per_cu_data::addr_type): Now methods.
7199         (per_cu_header_read_in): Make per_cu "const".
7200         (dwarf2_version): Remove.
7201         (dwarf2_per_cu_data::int_type): Now a method.
7202         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
7203         (set_die_type, read_array_type, read_subrange_index_type)
7204         (read_tag_string_type, read_subrange_type): Update.
7205         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
7206         offset_size, ref_addr_size, text_offset, addr_type, version,
7207         objfile, int_type, addr_sized_int_type>: Declare methods.
7208
7209 2020-02-08  Tom Tromey  <tom@tromey.com>
7210
7211         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
7212         Move earlier.
7213
7214 2020-02-08  Tom Tromey  <tom@tromey.com>
7215
7216         * dwarf2/read.h (dwarf_line_debug): Declare.
7217         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
7218         * dwarf2/read.c: Move line_header code to new files.
7219         (dwarf_line_debug): No longer static.
7220         * dwarf2/line-header.c: New file.
7221         * dwarf2/line-header.h: New file.
7222
7223 2020-02-08  Tom Tromey  <tom@tromey.com>
7224
7225         * dwarf2/read.c (struct line_header) <file_full_name,
7226         file_file_name>: Return unique_xmalloc_ptr.
7227         (line_header::file_file_name): Update.
7228         (line_header::file_full_name): Update.
7229         (dw2_get_file_names_reader): Update.
7230         (macro_start_file): Update.
7231
7232 2020-02-08  Tom Tromey  <tom@tromey.com>
7233
7234         * dwarf2/read.c (struct line_header) <file_full_name,
7235         file_file_name>: Declare methods.
7236         (dw2_get_file_names_reader): Update.
7237         (file_file_name): Now a method.
7238         (file_full_name): Likewise.
7239         (macro_start_file): Update.
7240
7241 2020-02-08  Tom Tromey  <tom@tromey.com>
7242
7243         * dwarf2/read.c (dwarf_always_disassemble)
7244         (show_dwarf_always_disassemble): Move to loc.c.
7245         (_initialize_dwarf2_read): Move "always-disassemble" registration
7246         to loc.c.
7247         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
7248         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
7249         static.
7250         (show_dwarf_always_disassemble): Move from read.c.
7251         (_initialize_dwarf2loc): Move always-disassemble from read.c.
7252
7253 2020-02-08  Tom Tromey  <tom@tromey.com>
7254
7255         * dwarf2/read.c (~dwarf2_per_objfile): Update.
7256         (create_quick_file_names_table): Return htab_up.
7257         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
7258         Update.
7259         * dwarf2/read.h (struct dwarf2_per_objfile)
7260         <quick_file_names_table>: Now htab_up.
7261
7262 2020-02-08  Tom Tromey  <tom@tromey.com>
7263
7264         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
7265
7266 2020-02-08  Tom Tromey  <tom@tromey.com>
7267
7268         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
7269         Rewrite.
7270         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
7271         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
7272         (abbrev_table::abbrev_table): No longer inline.
7273         (ABBREV_HASH_SIZE): Remove.
7274         (abbrev_table::m_abbrevs): Now an htab_up.
7275
7276 2020-02-08  Tom Tromey  <tom@tromey.com>
7277
7278         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
7279         (cutu_reader): Update.
7280         (build_type_psymtabs_1): Update.
7281         * dwarf2/abbrev.c (abbrev_table::read): Rename.
7282         (abbrev_table::alloc_abbrev): Update.
7283         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
7284         (abbrev_table::read): New static method, renamed from
7285         abbrev_table_read_table.
7286         (abbrev_table::alloc_abbrev)
7287         (abbrev_table::add_abbrev): Now private.
7288         (abbrev_table::abbrev_table): Now private.
7289         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
7290
7291 2020-02-08  Tom Tromey  <tom@tromey.com>
7292
7293         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
7294         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
7295         htab_up.
7296
7297 2020-02-08  Tom Tromey  <tom@tromey.com>
7298
7299         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
7300         htab_up.
7301         (lookup_dwo_unit_in_dwp): Update.
7302         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
7303         on obstack.
7304
7305 2020-02-08  Tom Tromey  <tom@tromey.com>
7306
7307         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
7308         obstack.
7309
7310 2020-02-08  Tom Tromey  <tom@tromey.com>
7311
7312         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
7313         line_header_hash.
7314         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
7315         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
7316         Change type to htab_up.
7317
7318 2020-02-08  Tom Tromey  <tom@tromey.com>
7319
7320         * dwarf2/read.c (allocate_type_unit_groups_table): Return
7321         htab_up.  Don't allocate on obstack.
7322         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
7323         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
7324         Change type to htab_up.
7325
7326 2020-02-08  Tom Tromey  <tom@tromey.com>
7327
7328         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
7329         Change type to htab_up.
7330         * dwarf2/read.c (create_signatured_type_table_from_index)
7331         (create_signatured_type_table_from_debug_names)
7332         (create_all_type_units, add_type_unit)
7333         (lookup_dwo_signatured_type, lookup_signatured_type)
7334         (process_skeletonless_type_unit): Update.
7335         (create_debug_type_hash_table, create_debug_types_hash_table):
7336         Change type of types_htab.
7337         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
7338         htab_up.  Don't allocate on obstack.
7339         (create_cus_hash_table): Change type of cus_htab parameter.
7340         (struct dwo_file) <cus, tus>: Now htab_up.
7341         (lookup_dwo_signatured_type, lookup_dwo_cutu)
7342         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
7343         (queue_and_load_all_dwo_tus): Update.
7344         * dwarf2/index-write.c (write_gdbindex): Update.
7345         (write_debug_names): Update.
7346
7347 2020-02-08  Tom Tromey  <tom@tromey.com>
7348
7349         * dwarf2/read.h (struct dwarf2_queue_item): Move from
7350         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
7351         destructor.
7352         (struct dwarf2_per_objfile) <queue>: New member.
7353         * dwarf2/read.c (struct dwarf2_queue_item): Move to
7354         dwarf2/read.h.
7355         (dwarf2_queue, dwarf2_queue_tail): Remove.
7356         (class dwarf2_queue_guard): Add parameter to constructor.  Use
7357         DISABLE_COPY_AND_ASSIGN.
7358         <m_per_objfile>: New member.
7359         <~dwarf2_queue_guard>: Rewrite.
7360         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
7361         Update.
7362         (~dwarf2_queue_item): New.
7363
7364 2020-02-08  Tom Tromey  <tom@tromey.com>
7365
7366         * dwarf2/read.c (struct die_info) <has_children>: New member.
7367         (dw2_get_file_names_reader): Remove has_children.
7368         (dw2_get_file_names): Update.
7369         (read_cutu_die_from_dwo): Remove has_children.
7370         (cutu_reader::init_tu_and_read_dwo_dies)
7371         (cutu_reader::cutu_reader): Update.
7372         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
7373         Remove has_children.
7374         (build_type_psymtabs_1, process_skeletonless_type_unit)
7375         (load_partial_comp_unit, load_full_comp_unit): Update.
7376         (create_dwo_cu_reader): Remove has_children.
7377         (create_cus_hash_table, read_die_and_children): Update.
7378         (read_full_die_1,read_full_die): Remove has_children.
7379         (read_signatured_type): Update.
7380         (class cutu_reader) <has_children>: Remove.
7381
7382 2020-02-08  Tom Tromey  <tom@tromey.com>
7383
7384         * dwarf2/expr.c: Rename from dwarf2expr.c.
7385         * dwarf2/expr.h: Rename from dwarf2expr.h.
7386         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
7387         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
7388         * dwarf2/frame.c: Rename from dwarf2-frame.c.
7389         * dwarf2/frame.h: Rename from dwarf2-frame.h.
7390         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
7391         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
7392         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
7393         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
7394         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
7395         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
7396         * dwarf2/loc.c: Rename from dwarf2loc.c.
7397         * dwarf2/loc.h: Rename from dwarf2loc.h.
7398         * dwarf2/read.c: Rename from dwarf2read.c.
7399         * dwarf2/read.h: Rename from dwarf2read.h.
7400         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
7401         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
7402         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
7403         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
7404         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
7405         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
7406         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
7407         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
7408         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
7409         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
7410         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
7411         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
7412         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
7413         Update.
7414         * Makefile.in (COMMON_SFILES): Update.
7415         (HFILES_NO_SRCDIR): Update.
7416
7417 2020-02-08  Tom Tromey  <tom@tromey.com>
7418
7419         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
7420         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
7421
7422 2020-02-08  Tom Tromey  <tom@tromey.com>
7423
7424         * dwarf2read.h (struct die_info): Don't declare.
7425
7426 2020-02-08  Tom Tromey  <tom@tromey.com>
7427
7428         * dwarf2read.h (die_info_ptr): Remove typedef.
7429
7430 2020-02-08  Tom Tromey  <tom@tromey.com>
7431
7432         * dwarf2read.c (read_call_site_scope)
7433         (handle_data_member_location, dwarf2_add_member_fn)
7434         (mark_common_block_symbol_computed, read_common_block)
7435         (attr_to_dynamic_prop, partial_die_info::read)
7436         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
7437         (dwarf2_symbol_mark_computed, set_die_type): Update.
7438         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
7439         method.
7440         (attr_form_is_block): Don't declare.
7441         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
7442
7443 2020-02-08  Tom Tromey  <tom@tromey.com>
7444
7445         * dwarf2read.c (dwarf2_find_base_address, )
7446         (read_call_site_scope, rust_containing_type)
7447         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
7448         (handle_data_member_location, dwarf2_add_member_fn)
7449         (get_alignment, read_structure_type, process_structure_scope)
7450         (mark_common_block_symbol_computed, read_common_block)
7451         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
7452         (partial_die_info::read, read_attribute_value, new_symbol)
7453         (lookup_die_type, dwarf2_get_ref_die_offset)
7454         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
7455         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
7456         (dwarf2_symbol_mark_computed): Update.
7457         * dwarf2/attribute.h (struct attribute) <value_as_address,
7458         form_is_section_offset, form_is_constant, form_is_ref>: Declare
7459         methods.
7460         (value_as_address, attr_form_is_section_offset)
7461         (attr_form_is_constant, attr_form_is_ref): Don't declare.
7462         * dwarf2/attribute.c (attribute::value_as_address)
7463         (attribute::form_is_section_offset, attribute::form_is_constant)
7464         (attribute::form_is_ref): Now methods.
7465
7466 2020-02-08  Tom Tromey  <tom@tromey.com>
7467
7468         * dwarf2read.c (struct attribute, DW_STRING)
7469         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
7470         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
7471         (attr_form_is_block, attr_form_is_section_offset)
7472         (attr_form_is_constant, attr_form_is_ref): Move.
7473         * dwarf2/attribute.h: New file.
7474         * dwarf2/attribute.c: New file, from dwarf2read.c.
7475         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
7476
7477 2020-02-08  Tom Tromey  <tom@tromey.com>
7478
7479         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
7480         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
7481         Move.
7482         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
7483         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
7484         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
7485         abbrev.c.
7486         * dwarf2/abbrev.h: New file.
7487         * dwarf2/abbrev.c: New file, from dwarf2read.c.
7488         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
7489
7490 2020-02-08  Tom Tromey  <tom@tromey.com>
7491
7492         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
7493         (dwarf2_section_size, dwarf2_get_section_info)
7494         (create_signatured_type_table_from_debug_names)
7495         (create_addrmap_from_aranges, read_debug_names_from_section)
7496         (get_gdb_index_contents_from_section, read_comp_unit_head)
7497         (error_check_comp_unit_head, read_abbrev_offset)
7498         (create_debug_type_hash_table, init_cu_die_reader)
7499         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
7500         (read_comp_units_from_section, create_cus_hash_table)
7501         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
7502         (create_dwp_v2_section, dwarf2_rnglists_process)
7503         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
7504         (abbrev_table_read_table, read_indirect_string_at_offset_from)
7505         (read_indirect_string_from_dwz, read_addr_index_1)
7506         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
7507         (dwarf_decode_macro_bytes, dwarf_decode_macros)
7508         (fill_in_loclist_baton): Update.
7509         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
7510         get_containing_section, get_bfd_owner, get_bfd_section,
7511         get_file_name, get_id, get_flags, empty, read>: Declare methods.
7512         (dwarf2_read_section, get_section_name, get_section_file_name)
7513         (get_containing_section, get_section_bfd_owner)
7514         (get_section_bfd_section, get_section_name, get_section_file_name)
7515         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
7516         declare.
7517         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
7518         (dwarf2_section_info::get_bfd_owner)
7519         (dwarf2_section_info::get_bfd_section)
7520         (dwarf2_section_info::get_name)
7521         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
7522         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
7523         (dwarf2_section_info::read): Now methods.
7524         * dwarf-index-write.c (class debug_names): Update.
7525
7526 2020-02-08  Tom Tromey  <tom@tromey.com>
7527
7528         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
7529         Move to dwarf2/section.h.
7530         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
7531         (get_section_bfd_section, get_section_name)
7532         (get_section_file_name, get_section_id, get_section_flags)
7533         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
7534         dwarf2/section.c.
7535         * dwarf2/section.h: New file.
7536         * dwarf2/section.c: New file, from dwarf2read.c.
7537         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
7538
7539 2020-02-08  Tom Tromey  <tom@tromey.com>
7540
7541         * dwarf2read.h (read_unsigned_leb128): Don't declare.
7542         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
7543         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
7544         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
7545         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
7546         * dwarf2/leb.h: New file, from dwarf2read.c.
7547         * dwarf2/leb.c: New file, from dwarf2read.c.
7548         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
7549         Remove.
7550         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
7551         (COMMON_SFILES): Add dwarf2/leb.c.
7552
7553 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
7554
7555         GDB 9.1 released.
7556
7557 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7558
7559         PR gdb/25190:
7560         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
7561         * gdb/remote.c (remote_console_output): Update.
7562         * gdb/ui-file.c (fputs_unfiltered): Rename to...
7563         (ui_file_puts): ...this.
7564         * gdb/ui-file.h (ui_file_puts): Add declaration.
7565         * gdb/utils.c (emit_style_escape): Update.
7566         (flush_wrap_buffer): Update.
7567         (fputs_maybe_filtered): Update.
7568         (fputs_unfiltered): Add function.
7569
7570 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7571
7572         * gdb/event-loop.c (gdb_wait_for_event): Update.
7573         * gdb/printcmd.c (printf_command): Update.
7574         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
7575         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
7576         (gdb_os_flush_stderr): Update.
7577         * gdb/remote.c (remote_console_output): Update.
7578         * gdb/ui-file.c (gdb_flush): Rename to...
7579         (ui_file_flush): ...this.
7580         (stderr_file::write): Update.
7581         (stderr_file::puts): Update.
7582         * gdb/ui-file.h (gdb_flush): Rename to...
7583         (ui_file_flush): ...this.
7584         * gdb/utils.c (gdb_flush): Add function.
7585         * gdb/utils.h (gdb_flush): Add declaration.
7586
7587 2020-02-07  Tom Tromey  <tromey@adacore.com>
7588
7589         PR breakpoints/24915:
7590         * source.c (find_and_open_source): Do not check basenames_may_differ.
7591
7592 2020-02-07  Tom Tromey  <tom@tromey.com>
7593
7594         * README: Update gdbserver documentation.
7595         * gdbserver: Move to top level.
7596         * configure.tgt (build_gdbserver): Remove.
7597         * configure.ac: Remove --enable-gdbserver.
7598         * configure: Rebuild.
7599         * Makefile.in (distclean): Don't mention gdbserver.
7600
7601 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7602
7603         * source-cache.c (source_cache::ensure): Surround
7604         get_plain_source_lines with a try/catch.
7605         (source_cache::get_line_charpos): Get rid of try/catch
7606         and only check for the return value of "ensure".
7607         * tui/tui-source.c (tui_source_window::set_contents):
7608         Simplify "nlines" calculation.
7609
7610 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7611
7612         * MAINTAINERS (Write After Approval): Add myself.
7613
7614 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7615
7616         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
7617         function call.
7618
7619 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7620
7621         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
7622
7623 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
7624
7625         * nat/riscv-linux-tdesc.h: New file.
7626         * nat/riscv-linux-tdesc.c: New file, taking code from...
7627         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7628         ... here.
7629         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
7630         NATDEPFILES.
7631
7632 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
7635         we don't set the fake simulator ptid to the null_ptid.
7636
7637 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
7638
7639         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
7640         * gdbthread.h (class thread_info) <resumed>: Likewise.
7641         * infrun.c (resume_1): Likewise.
7642         (proceed): Likewise.
7643         (infrun_thread_stop_requested): Likewise.
7644         (stop_all_threads): Likewise.
7645         (handle_inferior_event): Likewise.
7646         (restart_threads): Likewise.
7647         (finish_step_over): Likewise.
7648         (keep_going_stepped_thread): Likewise.
7649         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
7650         (linux_handle_extended_wait): Likewise.
7651         * record-btrace.c (get_thread_current_frame_id): Likewise.
7652         * record-full.c (record_full_wait_1): Likewise.
7653         * remote.c (remote_target::process_initial_stop_replies): Likewise.
7654         * target.c (target_resume): Likewise.
7655         * thread.c (set_running_thread): Likewise.
7656
7657 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7658
7659         * f-valprint.c (f77_print_array_1): Changed datatype of index
7660         variable to LONGEST from int to enable it to contain bound
7661         values correctly.
7662
7663 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
7664
7665         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
7666         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
7667         offsets according to FLEN determined.
7668         (riscv_linux_nat_target::read_description): Determine FLEN
7669         dynamically.
7670         (riscv_linux_nat_target::fetch_registers): Size regset buffer
7671         according to FLEN determined.
7672         (riscv_linux_nat_target::store_registers): Likewise.
7673
7674 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
7675
7676         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7677         when reg->group is empty and reggroup is not.
7678
7679 2020-01-31  Tom Tromey  <tromey@adacore.com>
7680
7681         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
7682         Call beneath target's mourn_inferior after unpushing.
7683
7684 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         PR tui/9765
7687         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
7688         have enough lines to fill the screen, still return the lowest
7689         address we found.
7690
7691 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
7694         '-', '<', and '>' commands.
7695
7696 2020-01-29  Pedro Alves  <palves@redhat.com>
7697             Sergio Durigan Junior  <sergiodj@redhat.com>
7698
7699         * infcmd.c (construct_inferior_arguments): Assert that
7700         'argc' is greater than 0.
7701
7702 2020-01-29  Luis Machado  <luis.machado@linaro.org>
7703
7704         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
7705         (BRK_INSN_MASK): Define to 0xd4200000.
7706         (aarch64_program_breakpoint_here_p): New function.
7707         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
7708         * arch-utils.c (default_program_breakpoint_here_p): Moved from
7709         breakpoint.c.
7710         * arch-utils.h (default_program_breakpoint_here_p): Moved from
7711         breakpoint.h
7712         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
7713         call gdbarch_program_breakpoint_here_p.
7714         (program_breakpoint_here): Moved to arch-utils.c, renamed to
7715         default_program_breakpoint_here_p, changed return type to bool and
7716         simplified.
7717         * breakpoint.h (program_breakpoint_here): Moved prototype to
7718         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
7719         return type to bool.
7720         * gdbarch.c: Regenerate.
7721         * gdbarch.h: Regenerate.
7722         * gdbarch.sh (program_breakpoint_here_p): New method.
7723         * infrun.c (handle_signal_stop): Call
7724         gdbarch_program_breakpoint_here_p.
7725
7726 2020-01-26  Tom Tromey  <tom@tromey.com>
7727
7728         * ctfread.c (struct ctf_fp_info): Reindent.
7729         (_initialize_ctfread): Remove.
7730
7731 2020-01-26  Tom Tromey  <tom@tromey.com>
7732
7733         * psymtab.c (partial_map_expand_apply)
7734         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
7735         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
7736         (psym_print_stats, psym_expand_symtabs_for_function)
7737         (psym_map_symbol_filenames, psym_map_matching_symbols)
7738         (psym_expand_symtabs_matching)
7739         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
7740         (maintenance_check_psymtabs): Use new methods.
7741         * psympriv.h (struct partial_symtab) <readin_p,
7742         get_compunit_symtab>: New methods.
7743         <readin, compunit_symtab>: Remove members.
7744         (struct standard_psymtab): New.
7745         (struct legacy_psymtab): Derive from standard_psymtab.
7746         * dwarf2read.h (struct dwarf2_psymtab): Derive from
7747         standard_psymtab.
7748         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
7749
7750 2020-01-26  Tom Tromey  <tom@tromey.com>
7751
7752         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
7753         read_dependencies.  Add assert.
7754         * psymtab.c (partial_symtab::read_dependencies): New method.
7755         * psympriv.h (struct partial_symtab) <read_dependencies>: New
7756         method.
7757         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
7758         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
7759         read_dependencies.
7760         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
7761         Add assert.
7762
7763 2020-01-26  Tom Tromey  <tom@tromey.com>
7764
7765         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
7766         Call expand_psymtab.
7767         (xcoff_read_symtab): Call expand_psymtab.
7768         (xcoff_start_psymtab, xcoff_end_psymtab): Set
7769         legacy_expand_psymtab.
7770         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
7771         method.
7772         (struct legacy_psymtab) <expand_psymtab>: Implement.
7773         <legacy_expand_psymtab>: New member.
7774         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
7775         (parse_partial_symbols): Set legacy_expand_psymtab.
7776         (psymtab_to_symtab_1): Change argument order.  Call
7777         expand_psymtab.
7778         (new_psymtab): Set legacy_expand_psymtab.
7779         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
7780         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
7781         expand_psymtab.
7782         (dwarf2_psymtab::expand_psymtab): Rename from
7783         psymtab_to_symtab_1.  Call expand_psymtab.
7784         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
7785         (dbx_end_psymtab): Likewise.
7786         (dbx_psymtab_to_symtab_1): Change argument order. Call
7787         expand_psymtab.
7788         (dbx_read_symtab): Call expand_psymtab.
7789         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
7790         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
7791         (ctf_psymtab::read_symtab): Call expand_psymtab.
7792
7793 2020-01-26  Tom Tromey  <tom@tromey.com>
7794
7795         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
7796         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
7797         messages.
7798         * mdebugread.c (mdebug_read_symtab): Remove prints.
7799         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
7800         assert.
7801         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
7802
7803 2020-01-26  Tom Tromey  <tom@tromey.com>
7804
7805         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
7806         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
7807         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
7808         legacy_symtab.
7809         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
7810         * psymtab.c (psymtab_to_symtab): Call method.
7811         (dump_psymtab): Update.
7812         * psympriv.h (struct partial_symtab): Add virtual destructor.
7813         <read_symtab>: New method.
7814         (struct legacy_symtab): New.
7815         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
7816         (struct pst_map) <pst>: Now a legacy_psymtab.
7817         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
7818         (new_psymtab): Use legacy_psymtab.
7819         * dwarf2read.h (struct dwarf2_psymtab): New.
7820         (struct dwarf2_per_cu_data) <psymtab>: Use it.
7821         * dwarf2read.c (dwarf2_create_include_psymtab)
7822         (dwarf2_build_include_psymtabs, create_type_unit_group)
7823         (create_partial_symtab, process_psymtab_comp_unit_reader)
7824         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
7825         (set_partial_user): Use dwarf2_psymtab.
7826         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
7827         (psymtab_to_symtab_1, process_full_comp_unit)
7828         (process_full_type_unit, dwarf2_ranges_read)
7829         (dwarf2_get_pc_bounds, psymtab_include_file_name)
7830         (dwarf_decode_lines): Use dwarf2_psymtab.
7831         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
7832         (add_address_entry_worker, write_one_signatured_type)
7833         (recursively_count_psymbols, recursively_write_psymbols)
7834         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
7835         (write_debug_names): Likewise.
7836         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
7837         <pst>: Now a legacy_psymtab.
7838         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
7839         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
7840         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
7841         * ctfread.c (struct ctf_psymtab): New.
7842         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
7843         ctf_psymtab.
7844         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
7845         (create_partial_symtab): Return a ctf_psymtab.
7846         (scan_partial_symbols): Update.
7847
7848 2020-01-26  Tom Tromey  <tom@tromey.com>
7849
7850         * xcoffread.c (xcoff_start_psymtab): Use new.
7851         * psymtab.c (partial_symtab::partial_symtab): New constructor,
7852         renamed from start_psymtab_common.
7853         * psympriv.h (struct partial_symtab): Add new constructor.
7854         (start_psymtab_common): Don't declare.
7855         * mdebugread.c (parse_partial_symbols): Use new.
7856         * dwarf2read.c (create_partial_symtab): Use new.
7857         * dbxread.c (start_psymtab): Use new.
7858         * ctfread.c (create_partial_symtab): Use new.
7859
7860 2020-01-26  Tom Tromey  <tom@tromey.com>
7861
7862         * xcoffread.c (xcoff_end_psymtab): Use new.
7863         * psymtab.c (start_psymtab_common): Use new.
7864         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
7865         Update.
7866         * psympriv.h (struct partial_symtab): Add parameters to
7867         constructor.  Don't inline.
7868         (allocate_psymtab): Don't declare.
7869         * mdebugread.c (new_psymtab): Use new.
7870         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
7871         * dbxread.c (dbx_end_psymtab): Use new.
7872
7873 2020-01-26  Tom Tromey  <tom@tromey.com>
7874
7875         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
7876         allocate_psymtab.  Update documentation.
7877         * psymtab.c (psymtab_storage::install_psymtab): Rename from
7878         allocate_psymtab.  Do not use new.
7879         (allocate_psymtab): Use new.  Update.
7880
7881 2020-01-26  Tom Tromey  <tom@tromey.com>
7882
7883         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
7884         * psymtab.c (psym_print_stats): Update.
7885         * psympriv.h (struct partial_symtab) <readin,
7886         psymtabs_addrmap_supported, anonymous>: Now bool.
7887         * mdebugread.c (psymtab_to_symtab_1): Update.
7888         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
7889         (build_type_psymtabs_reader, psymtab_to_symtab_1)
7890         (process_full_comp_unit, process_full_type_unit): Update.
7891         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
7892         * ctfread.c (psymtab_to_symtab): Update.
7893
7894 2020-01-26  Tom Tromey  <tom@tromey.com>
7895
7896         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
7897         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
7898         * psymtab.c (psymtab_storage): Delete psymtabs.
7899         (psymtab_storage::allocate_psymtab): Use new.
7900         (psymtab_storage::discard_psymtab): Use delete.
7901         * psympriv.h (struct partial_symtab): Add constructor and
7902         initializers.
7903
7904 2020-01-26  Tom Tromey  <tom@tromey.com>
7905
7906         * machoread.c: Do not include psympriv.h.
7907
7908 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7909
7910         * NEWS: Mention the new option and the set/show commands.
7911
7912 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7913
7914         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
7915         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
7916         (validate_exec_file): New variables, enums, functions.
7917         (exec_file_locate_attach, print_section_info): Style the filenames.
7918         (_initialize_exec): Install show_exec_file_mismatch_command and
7919          set_exec_file_mismatch_command.
7920         * gdbcore.h (validate_exec_file): Declare.
7921         * infcmd.c (attach_command): Call validate_exec_file.
7922         * remote.c ( remote_target::remote_add_inferior): Likewise.
7923
7924 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7925
7926         * frame.c (find_frame_sal): Move call to get_next_frame into more
7927         inner scope.
7928         * inline-frame.c (inilne_state) <inline_state>: Update argument
7929         types.
7930         (inilne_state) <skipped_symbol>: Rename to...
7931         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
7932         (skip_inline_frames): Build vector of skipped symbols and use this
7933         to reate the inline_state.
7934         (inline_skipped_symbol): Add a comment and some assertions, fetch
7935         skipped symbol from the list.
7936
7937 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7938
7939         * buildsym.c (lte_is_less_than): Delete.
7940         (buildsym_compunit::end_symtab_with_blockvector): Create local
7941         lambda function to sort line table entries, and use
7942         std::stable_sort instead of std::sort.
7943         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
7944         markers when looking for a previous line.
7945
7946 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7947
7948         * dwarf2read.c (lnp_state_machine::record_line): Include
7949         end_sequence parameter in debug print out.  Record the line if we
7950         are at an end_sequence marker even if it's not the start of a
7951         statement.
7952         * symmisc.c (maintenance_print_one_line_table): Print end of
7953         sequence markers with 'END' not '0'.
7954
7955 2020-01-24  Pedro Alves  <palves@redhat.com>
7956
7957         PR gdb/25410
7958         * thread.c (scoped_restore_current_thread::restore): Use
7959         switch_to_inferior_no_thread.
7960         * exec.c: Include "progspace-and-thread.h".
7961         (add_target_sections, remove_target_sections):
7962         scoped_restore_current_pspace_and_thread instead of
7963         scoped_restore_current_thread.
7964         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
7965         and aspace to the inferior before calling clone_program_space.
7966         Remove stale comment.
7967
7968 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7969
7970         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
7971         (arm_netbsd_nat_target::fetch_registers): ...this.
7972         (arm_nbsd_nat_target::store_registers): Rename to...
7973         (arm_netbsd_nat_target::store_registers): ...this.
7974
7975 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7976
7977         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
7978         register_t.
7979
7980 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
7981
7982         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
7983         Update comment.
7984         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
7985         Likewise.
7986         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
7987         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
7988         the correct replacement (iterate_over_regset_sections).
7989         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
7990         Update comment.
7991
7992 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
7993
7994         PR gdb/23718
7995         * gdb/python/python.c (execute_gdb_command): Call
7996         async_enable_stdin in catch block.
7997
7998 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7999
8000         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8001         SWITCH_THRU_ALL_UIS.
8002
8003 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8004
8005         PR tui/9765
8006         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8007         comment, add extra parameter, and update to store previous symbol
8008         when appropriate.
8009         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8010         add extra parameter.
8011         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8012         remove unneeded parameter, add try/catch around gdb_print_insn,
8013         rewrite to add items to asm_lines vector.
8014         (tui_find_backward_disassembly_start_address): New function.
8015         (tui_find_disassembly_address): Updated throughout.
8016         (tui_disasm_window::set_contents): Update for changes to
8017         tui_disassemble.
8018         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8019         number of lines to scroll.
8020
8021 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8022
8023         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8024         (SECT_OFF_DATA): Likewise.
8025         (SECT_OFF_RODATA): Likewise.
8026         (SECT_OFF_TEXT): Likewise.
8027         (SECT_OFF_BSS): Likewise.
8028         (struct objfile) <text_section_offset, data_section_offset>: New
8029         methods.
8030         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8031         objfile::text_section_offset.
8032         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8033         * coffread.c (coff_symtab_read): Likewise.
8034         (enter_linenos): Likewise.
8035         (process_coff_symbol): Likewise.
8036         * ctfread.c (get_objfile_text_range): Likewise.
8037         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8038         Use objfile::data_section_offset.
8039         * dwarf2-frame.c (execute_cfa_program): Use
8040         objfile::text_section_offset.
8041         (dwarf2_frame_find_fde): Likewise.
8042         * dwarf2read.c (create_addrmap_from_index): Likewise.
8043         (create_addrmap_from_aranges): Likewise.
8044         (dw2_find_pc_sect_compunit_symtab): Likewise.
8045         (process_psymtab_comp_unit_reader): Likewise.
8046         (add_partial_symbol): Likewise.
8047         (add_partial_subprogram): Likewise.
8048         (process_full_comp_unit): Likewise.
8049         (read_file_scope): Likewise.
8050         (read_func_scope): Likewise.
8051         (read_lexical_block_scope): Likewise.
8052         (read_call_site_scope): Likewise.
8053         (dwarf2_rnglists_process): Likewise.
8054         (dwarf2_ranges_process): Likewise.
8055         (dwarf2_ranges_read): Likewise.
8056         (dwarf_decode_lines_1): Likewise.
8057         (new_symbol): Likewise.
8058         (dwarf2_fetch_die_loc_sect_off): Likewise.
8059         (dwarf2_per_cu_text_offset): Likewise.
8060         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8061         * hppa-tdep.c (read_unwind_info): Likewise.
8062         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8063         * psympriv.h (struct partial_symtab): Likewise.
8064         * psymtab.c (find_pc_sect_psymtab): Likewise.
8065         * solib-svr4.c (enable_break): Likewise.
8066         * stap-probe.c (relocate_address): Use
8067         objfile::data_section_offset.
8068         * xcoffread.c (enter_line_range): Use
8069         objfile::text_section_offset.
8070         (read_xcoff_symtab): Likewise.
8071
8072 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8073
8074         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8075         declaration to narrower scopes.
8076
8077 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8078
8079         * darwin-nat.h (struct darwin_exception_msg, enum
8080         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8081         Move up.
8082         (class darwin_nat_target) <wait_1, check_new_threads,
8083         decode_exception_message, decode_message, stop_inferior,
8084         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8085         * darwin-nat.c (darwin_check_new_threads): Rename to...
8086         (darwin_nat_target::check_new_threads): ... this.
8087         (darwin_suspend_inferior_it): Remove.
8088         (darwin_decode_exception_message): Rename to...
8089         (darwin_nat_target::decode_exception_message): ... this.
8090         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8091         (darwin_decode_message): Rename to...
8092         (darwin_nat_target::decode_message): ... this.
8093         (cancel_breakpoint): Rename to...
8094         (darwin_nat_target::cancel_breakpoint): ... this.
8095         (darwin_wait): Rename to...
8096         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8097         instead of iterate_over_inferiors.
8098         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8099         (darwin_stop_inferior): Rename to...
8100         (darwin_nat_target::stop_inferior): ... this.
8101         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8102         (darwin_init_thread_list): Rename to...
8103         (darwin_nat_target::init_thread_list): ... this.
8104         (darwin_ptrace_him): Rename to...
8105         (darwin_nat_target::ptrace_him): ... this.
8106         (darwin_nat_target::create_inferior): Pass lambda function to
8107         fork_inferior.
8108         (darwin_nat_target::detach): Call stop_inferior instead of
8109         darwin_stop_inferior.
8110         * fork-inferior.h (fork_inferior): Change init_trace_fun
8111         parameter to gdb::function_view.
8112         * fork-inferior.c (fork_inferior): Likewise.
8113
8114 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8115
8116         * i386-cygwin-tdep.c (core_process_module_section): Update.
8117         * windows-nat.c (struct lm_info_windows): Add text_offset.
8118         (windows_xfer_shared_libraries): Update.
8119         * windows-tdep.c (windows_xfer_shared_library):
8120         Add text_offset_cached argument.
8121         * windows-tdep.h (windows_xfer_shared_library): Update.
8122
8123 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8124
8125         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8126
8127 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8128
8129         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8130         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8131         replace with range-based for.
8132         (gdbsim_interrupt_inferior): Remove.
8133         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8134         with a range-based for.  Inline code from
8135         gdbsim_interrupt_inferior.
8136
8137 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8138
8139         * infrun.c (proceed): Fix indentation.
8140
8141 2020-01-21  Tom Tromey  <tromey@adacore.com>
8142
8143         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8144         * python/python.c (python_extension_ops): Update.
8145         (gdbpy_colorize): New function.
8146         * python/lib/gdb/__init__.py (colorize): New function.
8147         * extension.h (ext_lang_colorize): Declare.
8148         * extension.c (ext_lang_colorize): New function.
8149         * extension-priv.h (struct extension_language_ops) <colorize>: New
8150         member.
8151         * cli/cli-style.c (_initialize_cli_style): Update help text.
8152
8153 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8154
8155         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8156         <cond>: Change type to bool.
8157         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8158         (aarch64_displaced_step_cb): Likewise.
8159         (aarch64_displaced_step_tb): Likewise.
8160
8161 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8162
8163         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8164         output.
8165
8166 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8167
8168         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8169         <pc_adjust>: Adjust the documentation.
8170         (aarch64_displaced_step_fixup): Check if PC really moved before
8171         adjusting it.
8172
8173 2020-01-19  Tom Tromey  <tom@tromey.com>
8174
8175         * disasm.c (~gdb_disassembler): New destructor.
8176         (gdb_buffered_insn_length): Call disassemble_free_target.
8177         * disasm.h (class gdb_disassembler): Declare destructor.  Use
8178         DISABLE_COPY_AND_ASSIGN.
8179
8180 2020-01-19  Tom Tromey  <tom@tromey.com>
8181
8182         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
8183         (die_reader_func_ftype): Remove.
8184         (cutu_reader): New class.
8185         (dw2_get_file_names_reader): Remove "data" parameter.
8186         (dw2_get_file_names): Use cutu_reader.
8187         (create_debug_type_hash_table): Update.
8188         (read_cutu_die_from_dwo): Update comment.
8189         (lookup_dwo_unit): Add dwo_name parameter.
8190         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
8191         die_reader_func_ftype and data parameters.
8192         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
8193         Remove die_reader_func_ftype and data parameters.
8194         (~cutu_reader): New; from init_cutu_and_read_dies.
8195         (cutu_reader::cutu_reader): Rename from
8196         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
8197         and data parameters.
8198         (init_cutu_and_read_dies_simple): Remove.
8199         (struct process_psymtab_comp_unit_data): Remove.
8200         (process_psymtab_comp_unit_reader): Remove data parameter; add
8201         want_partial_unit and pretend_language parameters.
8202         (process_psymtab_comp_unit): Use cutu_reader.
8203         (build_type_psymtabs_reader): Remove data parameter.
8204         (build_type_psymtabs_1): Use cutu_reader.
8205         (process_skeletonless_type_unit): Likewise.
8206         (load_partial_comp_unit_reader): Remove.
8207         (load_partial_comp_unit): Use cutu_reader.
8208         (load_full_comp_unit_reader): Remove.
8209         (load_full_comp_unit): Use cutu_reader.
8210         (struct create_dwo_cu_data): Remove.
8211         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
8212         dwo_unit parameters.
8213         (create_cus_hash_table): Use cutu_reader.
8214         (struct dwarf2_read_addr_index_data): Remove.
8215         (dwarf2_read_addr_index_reader): Remove.
8216         (dwarf2_read_addr_index): Use cutu_reader.
8217         (read_signatured_type_reader): Remove.
8218         (read_signatured_type): Use cutu_reader.
8219
8220 2020-01-19  Tom Tromey  <tom@tromey.com>
8221
8222         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
8223         * tui/tui-wingeneral.h (class tui_suppress_output): New.
8224         (tui_wrefresh): Declare.
8225         * tui/tui-wingeneral.c (suppress_output): New global.
8226         (tui_suppress_output, ~tui_suppress_output): New constructor and
8227         destructor.
8228         (tui_wrefresh): New function.
8229         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
8230         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
8231         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
8232         method.
8233         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
8234         tui_wrefresh.
8235         (tui_data_window::no_refresh): New method.
8236         (tui_data_item_window::refresh_window): Call tui_wrefresh.
8237         (tui_reg_command): Use tui_suppress_output
8238         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
8239         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
8240         method.
8241         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
8242
8243 2020-01-19  Tom Tromey  <tom@tromey.com>
8244
8245         * tui/tui-winsource.c (tui_update_source_windows_with_line):
8246         Handle case where symtab is null.
8247
8248 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
8249
8250         * linux-fork.c (one_fork_p): Simplify.
8251
8252 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8253
8254         * top.c (struct qt_args): Remove.
8255         (kill_or_detach): Change return type to void, replace `void *`
8256         parameter with a proper one.
8257         (print_inferior_quit_action):  Likewise.
8258         (quit_confirm): Use range-based for loop to iterate over inferiors.
8259         (quit_force): Likewise.
8260
8261 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8262
8263         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
8264         `void *` parameter with proper parameters.
8265         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
8266         (print_one_inferior): Change return type to void, replace `void *`
8267         parameter with proper parameters.
8268         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
8269         inferiors.
8270         (get_other_inferior): Remove.
8271         (mi_cmd_remove_inferior): Use range-based loop to iterate over
8272         inferiors.
8273
8274 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8275
8276         * mi/mi-interp.c (report_initial_inferior): Remove.
8277         (mi_interp::init): Use range-based for to iterate over inferiors.
8278
8279 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8280
8281         * python/py-inferior.c (build_inferior_list): Remove.
8282         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
8283
8284 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
8285
8286         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
8287         (btrace_stitch_trace): Likewise.
8288         * charset.c (intermediate_encoding): Likewise (vaild).
8289         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
8290         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
8291         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
8292
8293 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
8294
8295         * windows-tdep.c (windows_get_tlb_type):
8296         Add rtl_user_process_parameters type.
8297
8298 2020-01-16  Pedro Alves  <palves@redhat.com>
8299             Norbert Lange  <nolange79@gmail.com>
8300
8301         PR build/24805
8302         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
8303         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
8304         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
8305         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
8306         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
8307         (ps_plog): Redeclare exported functions with default visibility.
8308
8309 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
8310
8311         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
8312         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
8313
8314 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
8315
8316         * infcmd.c (post_create_inferior): Use get_thread_regcache
8317         instead of get_current_regcache.
8318
8319 2020-01-14  Tom Tromey  <tom@tromey.com>
8320
8321         PR symtab/12535:
8322         * python/python.c (gdbpy_decode_line): Treat empty string the same
8323         as no argument.
8324
8325 2020-01-14  Tom Tromey  <tom@tromey.com>
8326
8327         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
8328
8329 2020-01-14  Tom Tromey  <tom@tromey.com>
8330
8331         * nat/linux-btrace.c: Don't include <config.h>.
8332         * nat/linux-ptrace.c: Don't include <config.h>.
8333         * nat/x86-linux-dregs.c: Don't include <config.h>.
8334
8335 2020-01-14  Tom Tromey  <tom@tromey.com>
8336
8337         * configure: Rebuild.
8338         * configure.ac: Move many checks to ../gdbsupport/common.m4.
8339
8340 2020-01-14  Tom Tromey  <tom@tromey.com>
8341
8342         * nat/x86-linux-dregs.c: Include configh.h.
8343         * nat/linux-ptrace.c: Include configh.h.
8344         * nat/linux-btrace.c: Include configh.h.
8345         * defs.h: Include config.h, bfd.h.
8346         * configure.ac: Don't source common.host.
8347         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
8348         * configure: Rebuild.
8349         * acinclude.m4: Update path.
8350         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
8351         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
8352         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
8353         (CLIBS): Add LIBSUPPORT.
8354         (CDEPS): Likewise.
8355         (COMMON_SFILES): Remove gdbsupport files.
8356         (HFILES_NO_SRCDIR): Likewise.
8357         (stamp-version): Update path to create-version.sh.
8358         (ALLDEPFILES): Remove gdbsupport files.
8359
8360 2020-01-14  Tom Tromey  <tom@tromey.com>
8361
8362         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
8363         USE_WIN32API when needed.
8364         * configure.ac (USE_WIN32API): Don't define.
8365         (WIN32LIBS): Use WIN32APILIBS.
8366         * configure: Rebuild.
8367
8368 2020-01-14  Tom Tromey  <tom@tromey.com>
8369
8370         * configure: Rebuild.
8371         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
8372
8373 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8374
8375         * skip.c (skip_function_command): Make skip w/o arguments use the
8376         name of the inlined function if pc is inside any inlined function.
8377
8378 2020-01-14  Luis Machado  <luis.machado@linaro.org>
8379
8380         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
8381         * infrun.c (resume_1): Likewise.
8382         (handle_inferior_event): Remove stale comment.
8383         * linux-nat.c (linux_nat_target::resume): Update comments.
8384         (save_stop_reason): Likewise.
8385         (linux_nat_filter_event): Likewise.
8386         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
8387
8388 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8389
8390         * elfread.c (record_minimal_symbol): Set section index to 0 for
8391         non-allocatable sections.
8392
8393
8394 2020-01-13  Ali Tamur <tamur@google.com>
8395
8396         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
8397         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
8398         to gdb::optional.  Update comments.
8399         (dwo_file): Update comments.
8400         (read_attribute): Update API to take an additional out parameter,
8401         need_reprocess.  This is used to mark attributes that need other
8402         attributes (e.g. str_offsets_base) for correct computation which may not
8403         have been read yet.
8404         (read_attribute_reprocess): New function declaration.
8405         (read_addr_index): Likewise.
8406         (read_dwo_str_index): Likewise.
8407         (read_stub_str_index): Likewise.
8408         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
8409         (lookup_addr_base): New function definition.
8410         (lookup_ranges_base): Likewise.
8411         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
8412         lookup_ranges_base.
8413         (init_cutu_and_read_dies): Update comments.
8414         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
8415         unit.  This is used to inherit parent's str_offsets_base and addr_base.
8416         Update comments.
8417         (init_cutu_and_read_dies_simple): Reflect API changes.
8418         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
8419         (create_cus_hash_table): Change API to take parent compile unit.
8420         Reflect API changes.
8421         (open_and_init_dwo_file): Reflect API changes.
8422         (dwarf2_get_pc_bounds): Update comments.
8423         (dwarf2_record_block_ranges): Likewise.
8424         (read_full_die_1): Change implementation to reprocess attributes that
8425         need str_offsets_base and addr_base.
8426         (partial_die_info::read): Likewise.
8427         (read_attribute_reprocess): New function definition.
8428         (read_attribute_value): Change API to take an additional out parameter,
8429         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
8430         when a non-dwo compile unit has index based attributes.
8431         (read_attribute): Reflect API changes.
8432         (read_addr_index_1): Reflect API changes.  Update comments.
8433         (dwarf2_read_addr_index_data): Reflect API changes.
8434         (dwarf2_read_addr_index): Likewise.
8435         (read_str_index): Change API and implementation.  This becomes a helper
8436         to be used by the new string index related methods.  Update error
8437         message and comments.
8438         (read_dwo_str_index): New function definition.
8439         (read_stub_str_index): Likewise.
8440         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
8441         * symfile.h (dwarf2_debug_sections): Likewise.
8442         * xcoffread.c (dwarf2_debug_sections): Likewise.
8443
8444 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8445
8446         * gdbcore.h (struct core_fns) <core_read_registers>: Change
8447         core_reg_sect type to gdb_byte *.
8448         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
8449         * cris-tdep.c (fetch_core_registers): Likewise.
8450         * corelow.c (core_target::get_core_register_section): Change
8451         type of `contents` to gdb::byte_vector.
8452
8453 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8454
8455         * tui/tui-wingeneral.c (box_win): Position the title in the center
8456         of the border.
8457
8458 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8459
8460         * corelow.c (core_target::get_core_register_section): Use
8461           std::vector instead of alloca.
8462
8463 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8464
8465         * warning.m4: Add -Wmissing-declarations to build_warnings.
8466         * configure: Re-generate.
8467
8468 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8469
8470         * python/python.c (init__gdb_module): Add declaration.
8471
8472 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8473
8474         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
8475         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
8476         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
8477         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
8478         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
8479         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
8480         * ada-exp.y (_initialize_ada_exp): Add declaration.
8481         * ada-lang.c (_initialize_ada_language): Add declaration.
8482         * ada-tasks.c (_initialize_tasks): Add declaration.
8483         * agent.c (_initialize_agent): Add declaration.
8484         * aix-thread.c (_initialize_aix_thread): Add declaration.
8485         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
8486         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
8487         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
8488         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
8489         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
8490         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
8491         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
8492         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
8493         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
8494         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
8495         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
8496         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
8497         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
8498         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
8499         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
8500         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
8501         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
8502         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
8503         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
8504         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
8505         * annotate.c (_initialize_annotate): Add declaration.
8506         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
8507         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
8508         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
8509         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
8510         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
8511         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
8512         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
8513         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
8514         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
8515         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
8516         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
8517         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
8518         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
8519         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
8520         * auto-load.c (_initialize_auto_load): Add declaration.
8521         * auxv.c (_initialize_auxv): Add declaration.
8522         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
8523         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
8524         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
8525         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
8526         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
8527         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
8528         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
8529         * breakpoint.c (_initialize_breakpoint): Add declaration.
8530         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
8531         * btrace.c (_initialize_btrace): Add declaration.
8532         * charset.c (_initialize_charset): Add declaration.
8533         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
8534         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
8535         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
8536         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
8537         * cli/cli-script.c (_initialize_cli_script): Add declaration.
8538         * cli/cli-style.c (_initialize_cli_style): Add declaration.
8539         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
8540         * coffread.c (_initialize_coffread): Add declaration.
8541         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
8542         * compile/compile.c (_initialize_compile): Add declaration.
8543         * complaints.c (_initialize_complaints): Add declaration.
8544         * completer.c (_initialize_completer): Add declaration.
8545         * copying.c (_initialize_copying): Add declaration.
8546         * corefile.c (_initialize_core): Add declaration.
8547         * corelow.c (_initialize_corelow): Add declaration.
8548         * cp-abi.c (_initialize_cp_abi): Add declaration.
8549         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
8550         * cp-support.c (_initialize_cp_support): Add declaration.
8551         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
8552         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
8553         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
8554         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
8555         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
8556         * ctfread.c (_initialize_ctfread): Add declaration.
8557         * d-lang.c (_initialize_d_language): Add declaration.
8558         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
8559         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
8560         * dbxread.c (_initialize_dbxread): Add declaration.
8561         * dcache.c (_initialize_dcache): Add declaration.
8562         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
8563         * disasm.c (_initialize_disasm): Add declaration.
8564         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
8565         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
8566         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
8567         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
8568         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
8569         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
8570         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
8571         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
8572         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
8573         * elfread.c (_initialize_elfread): Add declaration.
8574         * exec.c (_initialize_exec): Add declaration.
8575         * extension.c (_initialize_extension): Add declaration.
8576         * f-lang.c (_initialize_f_language): Add declaration.
8577         * f-valprint.c (_initialize_f_valprint): Add declaration.
8578         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
8579         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
8580         * filesystem.c (_initialize_filesystem): Add declaration.
8581         * findcmd.c (_initialize_mem_search): Add declaration.
8582         * findvar.c (_initialize_findvar): Add declaration.
8583         * fork-child.c (_initialize_fork_child): Add declaration.
8584         * frame-base.c (_initialize_frame_base): Add declaration.
8585         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
8586         * frame.c (_initialize_frame): Add declaration.
8587         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
8588         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
8589         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
8590         * gcore.c (_initialize_gcore): Add declaration.
8591         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
8592         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
8593         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
8594         * gdbarch.c (_initialize_gdbarch): Add declaration.
8595         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
8596         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
8597         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
8598         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
8599         * go-lang.c (_initialize_go_language): Add declaration.
8600         * go32-nat.c (_initialize_go32_nat): Add declaration.
8601         * guile/guile.c (_initialize_guile): Add declaration.
8602         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
8603         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
8604         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
8605         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
8606         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
8607         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
8608         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
8609         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
8610         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
8611         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
8612         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
8613         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
8614         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
8615         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
8616         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
8617         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
8618         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
8619         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
8620         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
8621         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
8622         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
8623         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
8624         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
8625         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
8626         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
8627         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
8628         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
8629         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
8630         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
8631         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
8632         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
8633         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
8634         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
8635         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
8636         * infcall.c (_initialize_infcall): Add declaration.
8637         * infcmd.c (_initialize_infcmd): Add declaration.
8638         * inflow.c (_initialize_inflow): Add declaration.
8639         * infrun.c (_initialize_infrun): Add declaration.
8640         * interps.c (_initialize_interpreter): Add declaration.
8641         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
8642         * jit.c (_initialize_jit): Add declaration.
8643         * language.c (_initialize_language): Add declaration.
8644         * linux-fork.c (_initialize_linux_fork): Add declaration.
8645         * linux-nat.c (_initialize_linux_nat): Add declaration.
8646         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
8647         * linux-thread-db.c (_initialize_thread_db): Add declaration.
8648         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
8649         * m2-lang.c (_initialize_m2_language): Add declaration.
8650         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
8651         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
8652         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
8653         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
8654         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
8655         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
8656         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
8657         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
8658         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
8659         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
8660         * machoread.c (_initialize_machoread): Add declaration.
8661         * macrocmd.c (_initialize_macrocmd): Add declaration.
8662         * macroscope.c (_initialize_macroscope): Add declaration.
8663         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
8664         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
8665         * maint.c (_initialize_maint_cmds): Add declaration.
8666         * mdebugread.c (_initialize_mdebugread): Add declaration.
8667         * memattr.c (_initialize_mem): Add declaration.
8668         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
8669         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
8670         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
8671         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
8672         * mi/mi-main.c (_initialize_mi_main): Add declaration.
8673         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
8674         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
8675         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
8676         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
8677         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
8678         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
8679         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
8680         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
8681         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
8682         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
8683         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
8684         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
8685         * mipsread.c (_initialize_mipsread): Add declaration.
8686         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
8687         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
8688         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
8689         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
8690         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
8691         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
8692         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
8693         * nto-procfs.c (_initialize_procfs): Add declaration.
8694         * objc-lang.c (_initialize_objc_language): Add declaration.
8695         * observable.c (_initialize_observer): Add declaration.
8696         * opencl-lang.c (_initialize_opencl_language): Add declaration.
8697         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
8698         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
8699         * osabi.c (_initialize_gdb_osabi): Add declaration.
8700         * osdata.c (_initialize_osdata): Add declaration.
8701         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
8702         * parse.c (_initialize_parse): Add declaration.
8703         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
8704         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
8705         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
8706         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
8707         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
8708         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
8709         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
8710         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
8711         * printcmd.c (_initialize_printcmd): Add declaration.
8712         * probe.c (_initialize_probe): Add declaration.
8713         * proc-api.c (_initialize_proc_api): Add declaration.
8714         * proc-events.c (_initialize_proc_events): Add declaration.
8715         * proc-service.c (_initialize_proc_service): Add declaration.
8716         * procfs.c (_initialize_procfs): Add declaration.
8717         * producer.c (_initialize_producer): Add declaration.
8718         * psymtab.c (_initialize_psymtab): Add declaration.
8719         * python/python.c (_initialize_python): Add declaration.
8720         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
8721         * record-btrace.c (_initialize_record_btrace): Add declaration.
8722         * record-full.c (_initialize_record_full): Add declaration.
8723         * record.c (_initialize_record): Add declaration.
8724         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
8725         * regcache.c (_initialize_regcache): Add declaration.
8726         * reggroups.c (_initialize_reggroup): Add declaration.
8727         * remote-notif.c (_initialize_notif): Add declaration.
8728         * remote-sim.c (_initialize_remote_sim): Add declaration.
8729         * remote.c (_initialize_remote): Add declaration.
8730         * reverse.c (_initialize_reverse): Add declaration.
8731         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
8732         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
8733         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
8734         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
8735         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
8736         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
8737         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
8738         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
8739         Add declaration.
8740         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
8741         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
8742         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
8743         * rust-exp.y (_initialize_rust_exp): Add declaration.
8744         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
8745         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
8746         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
8747         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
8748         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
8749         * score-tdep.c (_initialize_score_tdep): Add declaration.
8750         * ser-go32.c (_initialize_ser_dos): Add declaration.
8751         * ser-mingw.c (_initialize_ser_windows): Add declaration.
8752         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
8753         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
8754         * ser-uds.c (_initialize_ser_socket): Add declaration.
8755         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
8756         * serial.c (_initialize_serial): Add declaration.
8757         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
8758         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
8759         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
8760         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
8761         * skip.c (_initialize_step_skip): Add declaration.
8762         * sol-thread.c (_initialize_sol_thread): Add declaration.
8763         * solib-aix.c (_initialize_solib_aix): Add declaration.
8764         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
8765         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
8766         * solib-frv.c (_initialize_frv_solib): Add declaration.
8767         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
8768         * solib-target.c (_initialize_solib_target): Add declaration.
8769         * solib.c (_initialize_solib): Add declaration.
8770         * source-cache.c (_initialize_source_cache): Add declaration.
8771         * source.c (_initialize_source): Add declaration.
8772         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
8773         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
8774         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
8775         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
8776         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
8777         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
8778         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
8779         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
8780         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
8781         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
8782         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
8783         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
8784         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
8785         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
8786         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
8787         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
8788         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
8789         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
8790         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
8791         * stabsread.c (_initialize_stabsread): Add declaration.
8792         * stack.c (_initialize_stack): Add declaration.
8793         * stap-probe.c (_initialize_stap_probe): Add declaration.
8794         * std-regs.c (_initialize_frame_reg): Add declaration.
8795         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
8796         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
8797         * symfile.c (_initialize_symfile): Add declaration.
8798         * symmisc.c (_initialize_symmisc): Add declaration.
8799         * symtab.c (_initialize_symtab): Add declaration.
8800         * target.c (_initialize_target): Add declaration.
8801         * target-connection.c (_initialize_target_connection): Add
8802         declaration.
8803         * target-dcache.c (_initialize_target_dcache): Add declaration.
8804         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
8805         * thread.c (_initialize_thread): Add declaration.
8806         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
8807         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
8808         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
8809         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
8810         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
8811         * tracectf.c (_initialize_ctf): Add declaration.
8812         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
8813         * tracefile.c (_initialize_tracefile): Add declaration.
8814         * tracepoint.c (_initialize_tracepoint): Add declaration.
8815         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
8816         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
8817         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
8818         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
8819         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
8820         * tui/tui-win.c (_initialize_tui_win): Add declaration.
8821         * tui/tui.c (_initialize_tui): Add declaration.
8822         * typeprint.c (_initialize_typeprint): Add declaration.
8823         * ui-style.c (_initialize_ui_style): Add declaration.
8824         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
8825         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
8826         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
8827         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
8828         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
8829         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
8830         * unittests/filtered_iterator-selftests.c
8831         (_initialize_filtered_iterator_selftests): Add declaration.
8832         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
8833         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
8834         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
8835         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
8836         * unittests/main-thread-selftests.c
8837         (_initialize_main_thread_selftests): Add declaration.
8838         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
8839         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
8840         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
8841         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
8842         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
8843         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
8844         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
8845         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
8846         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
8847         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
8848         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
8849         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
8850         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
8851         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
8852         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
8853         declaration.
8854         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
8855         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
8856         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
8857         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
8858         * user-regs.c (_initialize_user_regs): Add declaration.
8859         * utils.c (_initialize_utils): Add declaration.
8860         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
8861         * valops.c (_initialize_valops): Add declaration.
8862         * valprint.c (_initialize_valprint): Add declaration.
8863         * value.c (_initialize_values): Add declaration.
8864         * varobj.c (_initialize_varobj): Add declaration.
8865         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
8866         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
8867         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
8868         * windows-nat.c (_initialize_windows_nat): Add declaration.
8869         (_initialize_check_for_gdb_ini): Add declaration.
8870         (_initialize_loadable): Add declaration.
8871         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
8872         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
8873         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
8874         * xcoffread.c (_initialize_xcoffread): Add declaration.
8875         * xml-support.c (_initialize_xml_support): Add declaration.
8876         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
8877         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
8878         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
8879         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
8880
8881 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8882
8883         * regformats/regdat.sh: Generate declaration for init function.
8884
8885 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8886
8887         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
8888         up.
8889         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
8890         close_one_inferior>: New methods.
8891         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
8892         pass down target to find_inferior_pid.
8893         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
8894         Pass down target to find_inferior_ptid.
8895         (gdbsim_target::create_inferior): Pass down target to
8896         add_thread_silent.
8897         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
8898         target down to find_inferior_ptid and switch_to_thread.
8899         (gdbsim_target::close): Update to call close_one_inferior.
8900         (struct resume_data): Remove.
8901         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
8902         directly, rather than through a void pointer.
8903         (gdbsim_target::resume): Update to call resume_one_inferior.
8904
8905 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
8906
8907         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
8908
8909 2020-01-12  Pedro Alves  <palves@redhat.com>
8910
8911         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
8912         directly for the current inferior instead of
8913         discard_all_inferiors.
8914         (discard_all_inferiors): Delete.
8915
8916 2020-01-11  Tom Tromey  <tom@tromey.com>
8917
8918         * tui/tui-wingeneral.c (box_win): Check cli_styling.
8919         * tui/tui-winsource.c (tui_source_window_base::refill): Use
8920         deprecated_safe_get_selected_frame.
8921
8922 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
8923
8924         * inferior.c (print_inferior): Switch inferior before printing it.
8925
8926 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
8927             Pedro Alves  <palves@redhat.com>
8928
8929         * progspace-and-thread.c (switch_to_program_space_and_thread):
8930         Assert there's an inferior for PSPACE.  Use
8931         switch_to_inferior_no_thread to switch the inferior too.
8932         * progspace.c (program_space::~program_space): Call
8933         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
8934         (program_space::free_all_objfiles): Don't call clear_symtab_users
8935         here.
8936         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
8937
8938 2020-01-10  Pedro Alves  <palves@redhat.com>
8939
8940         * NEWS: Mention multi-target debugging, "info connections", and
8941         "add-inferior -no-connection".
8942
8943 2020-01-10  Pedro Alves  <palves@redhat.com>
8944
8945         * infrun.c: Include "target-connection.h".
8946         (check_multi_target_resumption): New.
8947         (proceed): Call it.
8948         * target-connection.c (make_target_connection_string): Make
8949         extern.
8950         * target-connection.h (make_target_connection_string): Declare.
8951
8952 2020-01-10  Pedro Alves  <palves@redhat.com>
8953
8954         * Makefile.in (COMMON_SFILES): Add target-connection.c.
8955         * inferior.c (uiout_field_connection): New function.
8956         (print_inferior): Add new "connection-id" column.
8957         (add_inferior_command): Show connection number/string of added
8958         inferior.
8959         * process-stratum-target.h
8960         (process_stratum_target::connection_string): New virtual method.
8961         (process_stratum_target::connection_number): New field.
8962         * remote.c (remote_target::connection_string): New override.
8963         * target-connection.c: New file.
8964         * target-connection.h: New file.
8965         * target.c (decref_target): Remove process_stratum targets from
8966         the connection list.
8967         (target_stack::push): Add process_stratum targets to the
8968         connection list.
8969
8970 2020-01-10  Pedro Alves  <palves@redhat.com>
8971
8972         Revert:
8973         2016-04-12  Pedro Alves  <palves@redhat.com>
8974         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
8975         Remove references to name.
8976         * serial.h (struct serial) <name>: Delete.
8977
8978 2020-01-10  Pedro Alves  <palves@redhat.com>
8979
8980         * gdbarch-selftests.c (register_to_value_test): Remove "target
8981         already pushed" check.
8982
8983 2020-01-10  Pedro Alves  <palves@redhat.com>
8984             John Baldwin  <jhb@FreeBSD.org>
8985
8986         * aarch64-linux-nat.c
8987         (aarch64_linux_nat_target::thread_architecture): Adjust.
8988         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
8989         (task_command_1): Likewise.
8990         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
8991         (aix_thread_target::wait, aix_thread_target::fetch_registers)
8992         (aix_thread_target::store_registers)
8993         (aix_thread_target::thread_alive): Adjust.
8994         * amd64-fbsd-tdep.c: Include "inferior.h".
8995         (amd64fbsd_get_thread_local_address): Pass down target.
8996         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
8997         thread's gdbarch instead of target_gdbarch.
8998         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
8999         get_last_target_status.
9000         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9001         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9002         inferiors.
9003         (update_inserted_breakpoint_locations): Skip if inferiors with no
9004         execution.
9005         (update_global_location_list): When handling moribund locations,
9006         find representative inferior for location's pspace, and use thread
9007         count of its process_stratum target.
9008         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9009         * bsd-uthread.c (bsd_uthread_target::wait): Use
9010         as_process_stratum_target and adjust thread_change_ptid and
9011         add_thread calls.
9012         (bsd_uthread_target::update_thread_list): Use
9013         as_process_stratum_target and adjust find_thread_ptid,
9014         thread_change_ptid and add_thread calls.
9015         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9016         find_thread_ptid call.
9017         * corelow.c (add_to_thread_list): Adjust add_thread call.
9018         (core_target_open): Adjust add_thread_silent and thread_count
9019         calls.
9020         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9021         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9022         * event-top.c (async_disconnect): Pop targets from all inferiors.
9023         * exec.c (add_target_sections): Push exec target on all inferiors
9024         sharing the program space.
9025         (remove_target_sections): Remove the exec target from all
9026         inferiors sharing the program space.
9027         (exec_on_vfork): New.
9028         * exec.h (exec_on_vfork): Declare.
9029         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9030         Pass it down.
9031         (fbsd_nat_target::update_thread_list): Adjust.
9032         (fbsd_nat_target::resume): Adjust.
9033         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9034         down.
9035         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9036         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9037         get_thread_arch_regcache call.
9038         * fork-child.c (gdb_startup_inferior): Pass target down to
9039         startup_inferior and set_executing.
9040         * gdbthread.h (struct process_stratum_target): Forward declare.
9041         (add_thread, add_thread_silent, add_thread_with_info)
9042         (in_thread_list): Add process_stratum_target parameter.
9043         (find_thread_ptid(inferior*, ptid_t)): New overload.
9044         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9045         parameter.
9046         (all_threads()): Delete overload.
9047         (all_threads, all_non_exited_threads): Add process_stratum_target
9048         parameter.
9049         (all_threads_safe): Use brace initialization.
9050         (thread_count): Add process_stratum_target parameter.
9051         (set_resumed, set_running, set_stop_requested, set_executing)
9052         (threads_are_executing, finish_thread_state): Add
9053         process_stratum_target parameter.
9054         (switch_to_thread): Use is_current_thread.
9055         * i386-fbsd-tdep.c: Include "inferior.h".
9056         (i386fbsd_get_thread_local_address): Pass down target.
9057         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9058         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9059         have_inferiors check.
9060         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9061         (inf_ptrace_target::attach): Adjust.
9062         * infcall.c (run_inferior_call): Adjust.
9063         * infcmd.c (run_command_1): Pass target to
9064         scoped_finish_thread_state.
9065         (proceed_thread_callback): Skip inferiors with no execution.
9066         (continue_command): Rename 'all_threads' local to avoid hiding
9067         'all_threads' function.  Adjust get_last_target_status call.
9068         (prepare_one_step): Adjust set_running call.
9069         (signal_command): Use user_visible_resume_target.  Compare thread
9070         pointers instead of inferior_ptid.
9071         (info_program_command): Adjust to pass down target.
9072         (attach_command): Mark target's 'thread_executing' flag.
9073         (stop_current_target_threads_ns): New, factored out from ...
9074         (interrupt_target_1): ... this.  Switch inferior before making
9075         target calls.
9076         * inferior-iter.h
9077         (struct all_inferiors_iterator, struct all_inferiors_range)
9078         (struct all_inferiors_safe_range)
9079         (struct all_non_exited_inferiors_range): Filter on
9080         process_stratum_target too.  Remove explicit.
9081         * inferior.c (inferior::inferior): Push dummy target on target
9082         stack.
9083         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9084         Add process_stratum_target parameter, and pass it down.
9085         (have_live_inferiors): Adjust.
9086         (switch_to_inferior_and_push_target): New.
9087         (add_inferior_command, clone_inferior_command): Handle
9088         "-no-connection" parameter.  Use
9089         switch_to_inferior_and_push_target.
9090         (_initialize_inferior): Mention "-no-connection" option in
9091         the help of "add-inferior" and "clone-inferior" commands.
9092         * inferior.h: Include "process-stratum-target.h".
9093         (interrupt_target_1): Use bool.
9094         (struct inferior) <push_target, unpush_target, target_is_pushed,
9095         find_target_beneath, top_target, process_target, target_at,
9096         m_stack>: New.
9097         (discard_all_inferiors): Delete.
9098         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9099         (all_inferiors, all_non_exited_inferiors): Add
9100         process_stratum_target parameter.
9101         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9102         (target_last_proc_target): New global.
9103         (follow_fork_inferior): Push target on new inferior.  Pass target
9104         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9105         reference count.
9106         (follow_fork): Adjust get_last_target_status call.  Also consider
9107         target.
9108         (follow_exec): Push target on new inferior.
9109         (struct execution_control_state) <target>: New field.
9110         (user_visible_resume_target): New.
9111         (do_target_resume): Call target_async.
9112         (resume_1): Set target's threads_executing flag.  Consider resume
9113         target.
9114         (commit_resume_all_targets): New.
9115         (proceed): Also consider resume target.  Skip threads of inferiors
9116         with no execution.  Commit resumtion in all targets.
9117         (start_remote): Pass current inferior to wait_for_inferior.
9118         (infrun_thread_stop_requested): Consider target as well.  Pass
9119         thread_info pointer to clear_inline_frame_state instead of ptid.
9120         (infrun_thread_thread_exit): Consider target as well.
9121         (random_pending_event_thread): New inferior parameter.  Use it.
9122         (do_target_wait): Rename to ...
9123         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9124         down.
9125         (threads_are_resumed_pending_p, do_target_wait): New.
9126         (prepare_for_detach): Adjust calls.
9127         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9128         do_target_wait_1 instead of do_target_wait.
9129         (fetch_inferior_event): Adjust.  Switch to representative
9130         inferior.  Pass target down.
9131         (set_last_target_status): Add process_stratum_target parameter.
9132         Save target in global.
9133         (get_last_target_status): Add process_stratum_target parameter and
9134         handle it.
9135         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9136         (context_switch): Check inferior_ptid == null_ptid before calling
9137         inferior_thread().
9138         (get_inferior_stop_soon): Pass down target.
9139         (wait_one): Rename to ...
9140         (poll_one_curr_target): ... this.
9141         (struct wait_one_event): New.
9142         (wait_one): New.
9143         (stop_all_threads): Adjust.
9144         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9145         event's target.
9146         (switch_back_to_stepped_thread): Also consider target.
9147         (print_stop_event): Update.
9148         (normal_stop): Update.  Also consider the resume target.
9149         * infrun.h (wait_for_inferior): Remove declaration.
9150         (user_visible_resume_target): New declaration.
9151         (get_last_target_status, set_last_target_status): New
9152         process_stratum_target parameter.
9153         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9154         process_stratum_target parameter, and use it.
9155         (clear_inline_frame_state (thread_info*)): New.
9156         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9157         process_stratum_target parameter.
9158         (clear_inline_frame_state (thread_info*)): Declare.
9159         * linux-fork.c (delete_checkpoint_command): Pass target down to
9160         find_thread_ptid.
9161         (checkpoint_command): Adjust.
9162         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9163         instead of just tweaking inferior_ptid.
9164         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9165         (exit_lwp): Pass target down to find_thread_ptid.
9166         (attach_proc_task_lwp_callback): Pass target down to
9167         add_thread/set_running/set_executing.
9168         (linux_nat_target::attach): Pass target down to
9169         thread_change_ptid.
9170         (get_detach_signal): Pass target down to find_thread_ptid.
9171         Consider last target status's target.
9172         (linux_resume_one_lwp_throw, resume_lwp)
9173         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
9174         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
9175         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
9176         (linux_nat_target::async_wait_fd): New.
9177         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
9178         target down.
9179         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
9180         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
9181         * linux-thread-db.c (struct thread_db_info::process_target): New
9182         field.
9183         (add_thread_db_info): Save target.
9184         (get_thread_db_info): New process_stratum_target parameter.  Also
9185         match target.
9186         (delete_thread_db_info): New process_stratum_target parameter.
9187         Also match target.
9188         (thread_from_lwp): Adjust to pass down target.
9189         (thread_db_notice_clone): Pass down target.
9190         (check_thread_db_callback): Pass down target.
9191         (try_thread_db_load_1): Always push the thread_db target.
9192         (try_thread_db_load, record_thread): Pass target down.
9193         (thread_db_target::detach): Pass target down.  Always unpush the
9194         thread_db target.
9195         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
9196         target down.  Always unpush the thread_db target.
9197         (find_new_threads_callback, thread_db_find_new_threads_2)
9198         (thread_db_target::update_thread_list): Pass target down.
9199         (thread_db_target::pid_to_str): Pass current inferior down.
9200         (thread_db_target::get_thread_local_address): Pass target down.
9201         (thread_db_target::resume, maintenance_check_libthread_db): Pass
9202         target down.
9203         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
9204         * procfs.c (procfs_target::procfs_init_inferior): Declare.
9205         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
9206         (procfs_init_inferior): Rename to ...
9207         (procfs_target::procfs_init_inferior): ... this and adjust.
9208         (procfs_target::create_inferior, procfs_notice_thread)
9209         (procfs_do_thread_registers): Adjust.
9210         * ppc-fbsd-tdep.c: Include "inferior.h".
9211         (ppcfbsd_get_thread_local_address): Pass down target.
9212         * proc-service.c (ps_xfer_memory): Switch current inferior and
9213         program space as well.
9214         (get_ps_regcache): Pass target down.
9215         * process-stratum-target.c
9216         (process_stratum_target::thread_address_space)
9217         (process_stratum_target::thread_architecture): Pass target down.
9218         * process-stratum-target.h
9219         (process_stratum_target::threads_executing): New field.
9220         (as_process_stratum_target): New.
9221         * ravenscar-thread.c
9222         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
9223         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
9224         down.
9225         * record-btrace.c (record_btrace_target::info_record): Adjust.
9226         (record_btrace_target::record_method)
9227         (record_btrace_target::record_is_replaying)
9228         (record_btrace_target::fetch_registers)
9229         (get_thread_current_frame_id, record_btrace_target::resume)
9230         (record_btrace_target::wait, record_btrace_target::stop): Pass
9231         target down.
9232         * record-full.c (record_full_wait_1): Switch to event thread.
9233         Pass target down.
9234         * regcache.c (regcache::regcache)
9235         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
9236         process_stratum_target parameter and handle it.
9237         (current_thread_target): New global.
9238         (get_thread_regcache): Add process_stratum_target parameter and
9239         handle it.  Switch inferior before calling target method.
9240         (get_thread_regcache): Pass target down.
9241         (get_thread_regcache_for_ptid): Pass target down.
9242         (registers_changed_ptid): Add process_stratum_target parameter and
9243         handle it.
9244         (registers_changed_thread, registers_changed): Pass target down.
9245         (test_get_thread_arch_aspace_regcache): New.
9246         (current_regcache_test): Define a couple local test_target_ops
9247         instances and use them for testing.
9248         (readwrite_regcache): Pass process_stratum_target parameter.
9249         (cooked_read_test, cooked_write_test): Pass mock_target down.
9250         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
9251         (get_thread_arch_aspace_regcache): Add process_stratum_target
9252         parameter.
9253         (regcache::target): New method.
9254         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
9255         (regcache::registers_changed_ptid): Add process_stratum_target
9256         parameter.
9257         (regcache::m_target): New field.
9258         (registers_changed_ptid): Add process_stratum_target parameter.
9259         * remote.c (remote_state::supports_vCont_probed): New field.
9260         (remote_target::async_wait_fd): New method.
9261         (remote_unpush_and_throw): Add remote_target parameter.
9262         (get_current_remote_target): Adjust.
9263         (remote_target::remote_add_inferior): Push target.
9264         (remote_target::remote_add_thread)
9265         (remote_target::remote_notice_new_inferior)
9266         (get_remote_thread_info): Pass target down.
9267         (remote_target::update_thread_list): Skip threads of inferiors
9268         bound to other targets.  (remote_target::close): Don't discard
9269         inferiors.  (remote_target::add_current_inferior_and_thread)
9270         (remote_target::process_initial_stop_replies)
9271         (remote_target::start_remote)
9272         (remote_target::remote_serial_quit_handler): Pass down target.
9273         (remote_target::remote_unpush_target): New remote_target
9274         parameter.  Unpush the target from all inferiors.
9275         (remote_target::remote_unpush_and_throw): New remote_target
9276         parameter.  Pass it down.
9277         (remote_target::open_1): Check whether the current inferior has
9278         execution instead of checking whether any inferior is live.  Pass
9279         target down.
9280         (remote_target::remote_detach_1): Pass down target.  Use
9281         remote_unpush_target.
9282         (extended_remote_target::attach): Pass down target.
9283         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
9284         (remote_target::append_resumption): Pass down target.
9285         (remote_target::append_pending_thread_resumptions)
9286         (remote_target::remote_resume_with_hc, remote_target::resume)
9287         (remote_target::commit_resume): Pass down target.
9288         (remote_target::remote_stop_ns): Check supports_vCont_probed.
9289         (remote_target::interrupt_query)
9290         (remote_target::remove_new_fork_children)
9291         (remote_target::check_pending_events_prevent_wildcard_vcont)
9292         (remote_target::remote_parse_stop_reply)
9293         (remote_target::process_stop_reply): Pass down target.
9294         (first_remote_resumed_thread): New remote_target parameter.  Pass
9295         it down.
9296         (remote_target::wait_as): Pass down target.
9297         (unpush_and_perror): New remote_target parameter.  Pass it down.
9298         (remote_target::readchar, remote_target::remote_serial_write)
9299         (remote_target::getpkt_or_notif_sane_1)
9300         (remote_target::kill_new_fork_children, remote_target::kill): Pass
9301         down target.
9302         (remote_target::mourn_inferior): Pass down target.  Use
9303         remote_unpush_target.
9304         (remote_target::core_of_thread)
9305         (remote_target::remote_btrace_maybe_reopen): Pass down target.
9306         (remote_target::pid_to_exec_file)
9307         (remote_target::thread_handle_to_thread_info): Pass down target.
9308         (remote_target::async_wait_fd): New.
9309         * riscv-fbsd-tdep.c: Include "inferior.h".
9310         (riscv_fbsd_get_thread_local_address): Pass down target.
9311         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
9312         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
9313         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
9314         Adjust.
9315         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
9316         * solib-svr4.c (enable_break): Pass down target.
9317         * spu-multiarch.c (parse_spufs_run): Pass down target.
9318         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
9319         * target-delegates.c: Regenerate.
9320         * target.c (g_target_stack): Delete.
9321         (current_top_target): Return the current inferior's top target.
9322         (target_has_execution_1): Refer to the passed-in inferior's top
9323         target.
9324         (target_supports_terminal_ours): Check whether the initial
9325         inferior was already created.
9326         (decref_target): New.
9327         (target_stack::push): Incref/decref the target.
9328         (push_target, push_target, unpush_target): Adjust.
9329         (target_stack::unpush): Defref target.
9330         (target_is_pushed): Return bool.  Adjust to refer to the current
9331         inferior's target stack.
9332         (dispose_inferior): Delete, and inline parts ...
9333         (target_preopen): ... here.  Only dispose of the current inferior.
9334         (target_detach): Hold strong target reference while detaching.
9335         Pass target down.
9336         (target_thread_name): Add assertion.
9337         (target_resume): Pass down target.
9338         (target_ops::beneath, find_target_at): Adjust to refer to the
9339         current inferior's target stack.
9340         (get_dummy_target): New.
9341         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
9342         has a thread running.
9343         (initialize_targets): Rename to ...
9344         (_initialize_target): ... this.
9345         * target.h: Include "gdbsupport/refcounted-object.h".
9346         (struct target_ops): Inherit refcounted_object.
9347         (target_ops::shortname, target_ops::longname): Make const.
9348         (target_ops::async_wait_fd): New method.
9349         (decref_target): Declare.
9350         (struct target_ops_ref_policy): New.
9351         (target_ops_ref): New typedef.
9352         (get_dummy_target): Declare function.
9353         (target_is_pushed): Return bool.
9354         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
9355         (all_matching_threads_iterator::all_matching_threads_iterator):
9356         Handle filter target.
9357         * thread-iter.h (struct all_matching_threads_iterator, struct
9358         all_matching_threads_range, class all_non_exited_threads_range):
9359         Filter by target too.  Remove explicit.
9360         * thread.c (threads_executing): Delete.
9361         (inferior_thread): Pass down current inferior.
9362         (clear_thread_inferior_resources): Pass down thread pointer
9363         instead of ptid_t.
9364         (add_thread_silent, add_thread_with_info, add_thread): Add
9365         process_stratum_target parameter.  Use it for thread and inferior
9366         searches.
9367         (is_current_thread): New.
9368         (thread_info::deletable): Use it.
9369         (find_thread_ptid, thread_count, in_thread_list)
9370         (thread_change_ptid, set_resumed, set_running): New
9371         process_stratum_target parameter.  Pass it down.
9372         (set_executing): New process_stratum_target parameter.  Pass it
9373         down.  Adjust reference to 'threads_executing'.
9374         (threads_are_executing): New process_stratum_target parameter.
9375         Adjust reference to 'threads_executing'.
9376         (set_stop_requested, finish_thread_state): New
9377         process_stratum_target parameter.  Pass it down.
9378         (switch_to_thread): Also match inferior.
9379         (switch_to_thread): New process_stratum_target parameter.  Pass it
9380         down.
9381         (update_threads_executing): Reimplement.
9382         * top.c (quit_force): Pop targets from all inferior.
9383         (gdb_init): Don't call initialize_targets.
9384         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
9385         Declare.
9386         (windows_add_thread, windows_delete_thread): Adjust.
9387         (get_windows_debug_event): Rename to ...
9388         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
9389         * tracefile-tfile.c (tfile_target_open): Pass down target.
9390         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
9391         Forward declare.
9392         (switch_to_thread): Add process_stratum_target parameter.
9393         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
9394         parameter.  Use it.
9395         (mi_on_resume): Pass target down.
9396         * nat/fork-inferior.c (startup_inferior): Add
9397         process_stratum_target parameter.  Pass it down.
9398         * nat/fork-inferior.h (startup_inferior): Add
9399         process_stratum_target parameter.
9400         * python/py-threadevent.c (py_get_event_thread): Pass target down.
9401
9402 2020-01-10  Pedro Alves  <palves@redhat.com>
9403
9404         * remote.c (remote_target::start_remote): Don't set inferior_ptid
9405         directly.  Instead find the first thread in the thread list and
9406         use switch_to_thread.
9407
9408 2020-01-10  Pedro Alves  <palves@redhat.com>
9409
9410         * remote.c (remote_target::remote_add_inferior): Don't bind a
9411         process to the current inferior if the current inferior is already
9412         bound to a process.
9413
9414 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9415             Pedro Alves  <palves@redhat.com>
9416
9417         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
9418         If no process is specified, return null_ptid instead of
9419         inferior_ptid.
9420         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
9421         TARGET_WAITKIND_SIGNALLED with no pid.
9422
9423 2020-01-10  Pedro Alves  <palves@redhat.com>
9424
9425         * remote.c (first_remote_resumed_thread): New.
9426         (remote_target::wait_as): Use it as default event_ptid instead of
9427         inferior_ptid.
9428
9429 2020-01-10  Pedro Alves  <palves@redhat.com>
9430
9431         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
9432
9433 2020-01-10  Pedro Alves  <palves@redhat.com>
9434
9435         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
9436         not -1.
9437
9438 2020-01-10  Pedro Alves  <palves@redhat.com>
9439
9440         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
9441         ptid to get_last_target_status.
9442         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
9443         ptid to get_last_target_status.
9444         * infcmd.c (continue_command): Don't pass a target_waitstatus to
9445         get_last_target_status.
9446         (info_program_command): Don't pass a target_waitstatus to
9447         get_last_target_status.
9448         * infrun.c (init_wait_for_inferior): Use
9449         nullify_last_target_wait_ptid.
9450         (get_last_target_status): Handle nullptr arguments.
9451         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
9452         (print_stop_event): Don't pass a ptid to get_last_target_status.
9453         (normal_stop): Don't pass a ptid to get_last_target_status.
9454         * infrun.h (get_last_target_status, set_last_target_status): Move
9455         comments here and update.
9456         (nullify_last_target_wait_ptid): Declare.
9457         * linux-fork.c (fork_load_infrun_state): Remove local extern
9458         declaration of nullify_last_target_wait_ptid.
9459         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
9460         to get_last_target_status.
9461
9462 2020-01-10  Pedro Alves  <palves@redhat.com>
9463
9464         * gdbthread.h (scoped_restore_current_thread)
9465         <dont_restore, restore, m_dont_restore>: Declare.
9466         * thread.c (thread_alive): Add assertion.  Return bool.
9467         (switch_to_thread_if_alive): New.
9468         (prune_threads): Switch inferior/thread.
9469         (print_thread_info_1): Switch thread before calling target methods.
9470         (scoped_restore_current_thread::restore): New, factored out from
9471         ...
9472         (scoped_restore_current_thread::~scoped_restore_current_thread):
9473         ... this.
9474         (scoped_restore_current_thread::scoped_restore_current_thread):
9475         Add assertion.
9476         (thread_apply_all_command, thread_select): Use
9477         switch_to_thread_if_alive.
9478         * infrun.c (proceed, restart_threads, handle_signal_stop)
9479         (switch_back_to_stepped_thread): Switch current thread before
9480         calling target methods.
9481
9482 2020-01-10  Pedro Alves <palves@redhat.com>
9483
9484         * inferior.c (switch_to_inferior_no_thread): New function,
9485         factored out from ...
9486         (inferior_command): ... here.
9487         * inferior.h (switch_to_inferior_no_thread): Declare.
9488         * mi/mi-main.c (run_one_inferior): Use
9489         switch_to_inferior_no_thread.
9490
9491 2020-01-10  Pedro Alves  <palves@redhat.com>
9492
9493         * infcmd.c (kill_command): Remove dead code.
9494
9495 2020-01-10  Pedro Alves  <palves@redhat.com>
9496
9497         * remote.c (remote_target::mourn_inferior): No longer check
9498         whether the target is running.
9499
9500 2020-01-10  Pedro Alves  <palves@redhat.com>
9501
9502         * corelow.c (core_target::has_execution): Change parameter type to
9503         inferior pointer.
9504         * inferior.c (number_of_live_inferiors): Use
9505         inferior::has_execution instead of target_has_execution_1.
9506         * inferior.h (inferior::has_execution): New.
9507         * linux-thread-db.c (thread_db_target::update_thread_list): Use
9508         inferior::has_execution instead of target_has_execution_1.
9509         * process-stratum-target.c
9510         (process_stratum_target::has_execution): Change parameter type to
9511         inferior pointer.  Check the inferior's PID instead of
9512         inferior_ptid.
9513         * process-stratum-target.h
9514         (process_stratum_target::has_execution): Change parameter type to
9515         inferior pointer.
9516         * record-full.c (record_full_core_target::has_execution): Change
9517         parameter type to inferior pointer.
9518         * target.c (target_has_execution_1): Change parameter type to
9519         inferior pointer.
9520         (target_has_execution_current): Adjust.
9521         * target.h (target_ops::has_execution): Change parameter type to
9522         inferior pointer.
9523         (target_has_execution_1): Change parameter type to inferior
9524         pointer.  Change return type to bool.
9525         * tracefile.h (tracefile_target::has_execution): Change parameter
9526         type to inferior pointer.
9527
9528 2020-01-10  Pedro Alves  <palves@redhat.com>
9529
9530         * exceptions.c (print_flush): Remove current_top_target() check.
9531
9532 2020-01-10  Pedro Alves  <palves@redhat.com>
9533
9534         * remote.c (show_remote_exec_file): Show the current inferior's
9535         exec-file instead of the command variable's value.
9536
9537 2020-01-10  Pedro Alves  <palves@redhat.com>
9538
9539         * record-full.c (record_full_resume_ptid): New global.
9540         (record_full_target::resume): Set it.
9541         (record_full_wait_1): Use record_full_resume_ptid instead of
9542         inferior_ptid.
9543
9544 2020-01-10  Pedro Alves  <palves@redhat.com>
9545
9546         * gdbthread.h (scoped_restore_current_thread)
9547         <dont_restore, restore, m_dont_restore>: Declare.
9548         * thread.c (thread_alive): Add assertion.  Return bool.
9549         (switch_to_thread_if_alive): New.
9550         (prune_threads): Switch inferior/thread.
9551         (print_thread_info_1): Switch thread before calling target methods.
9552         (scoped_restore_current_thread::restore): New, factored out from
9553         ...
9554         (scoped_restore_current_thread::~scoped_restore_current_thread):
9555         ... this.
9556         (scoped_restore_current_thread::scoped_restore_current_thread):
9557         Add assertion.
9558         (thread_apply_all_command, thread_select): Use
9559         switch_to_thread_if_alive.
9560
9561 2020-01-10  George Barrett  <bob@bob131.so>
9562
9563         * stap-probe.c (stap_modify_semaphore): Don't check for null
9564         semaphores.
9565         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
9566         for null semaphores.
9567
9568 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9569
9570         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
9571         all source windows, and maintain horizontal scroll status while
9572         doing so.
9573
9574 2020-01-09  Tom Tromey  <tom@tromey.com>
9575
9576         PR tui/18932:
9577         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
9578         update_source_window, not print_source_lines.
9579
9580 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9581
9582         * tui/tui.c (tui_enable): Register tui hooks after calling
9583         tui_display_main.
9584
9585 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9586
9587         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
9588
9589 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
9590
9591         * thread.c (print_thread_info_1): Fix indentation.
9592
9593 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9594
9595         * symtab.c (general_symbol_info::compute_and_set_names): Move the
9596         unique_xmalloc_ptr outside the if to always free the demangled name.
9597
9598 2020-01-08  Tom Tromey  <tromey@adacore.com>
9599
9600         * xcoffread.c (enter_line_range, read_xcoff_symtab)
9601         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
9602         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
9603         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
9604         Remove.
9605         (section_offsets): New typedef.
9606         * symtab.c (fixup_section, get_msymbol_address): Update.
9607         * symmisc.c (dump_msymbols): Update.
9608         * symfile.h (relative_addr_info_to_section_offsets)
9609         (symfile_map_offsets_to_segments): Update.
9610         * symfile.c (build_section_addr_info_from_objfile)
9611         (init_objfile_sect_indices): Update.
9612         (struct place_section_arg): Change type of "offsets".
9613         (place_section): Update.
9614         (relative_addr_info_to_section_offsets): Change type of
9615         "section_offsets".  Remove "num_sections" parameter.
9616         (default_symfile_offsets, syms_from_objfile_1)
9617         (set_objfile_default_section_offset): Update.
9618         (reread_symbols): No need to preserve section offsets by hand.
9619         (symfile_map_offsets_to_segments): Change type of "offsets".
9620         * stap-probe.c (relocate_address): Update.
9621         * stabsread.h (process_one_symbol): Update.
9622         * solib-target.c (struct lm_info_target) <offsets>: Change type.
9623         (solib_target_relocate_section_addresses): Update.
9624         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
9625         Update.
9626         * solib-frv.c (frv_relocate_main_executable): Update.
9627         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
9628         * solib-aix.c (solib_aix_get_section_offsets): Change return
9629         type.
9630         (solib_aix_solib_create_inferior_hook): Update.
9631         * remote.c (remote_target::get_offsets): Update.
9632         * psymtab.c (find_pc_sect_psymtab): Update.
9633         * psympriv.h (struct partial_symbol) <address, text_low,
9634         text_high>: Update.
9635         * objfiles.h (obj_section_offset): Update.
9636         (struct objfile) <section_offsets>: Change type.
9637         <num_sections>: Remove.
9638         (objfile_relocate): Update.
9639         * objfiles.c (entry_point_address_query): Update
9640         (relocate_one_symbol): Change type of "section_offsets".
9641         (objfile_relocate1, objfile_relocate1): Change type of
9642         "new_offsets".
9643         (objfile_rebase1): Update.
9644         * mipsread.c (mipscoff_symfile_read): Update.
9645         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
9646         parameter.
9647         * mdebugread.c (parse_symbol): Change type of "section_offsets".
9648         (parse_external, psymtab_to_symtab_1): Update.
9649         * machoread.c (macho_symfile_offsets): Update.
9650         * ia64-tdep.c (ia64_find_unwind_table): Update.
9651         * hppa-tdep.c (read_unwind_info): Update.
9652         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
9653         * dwarf2read.c (create_addrmap_from_index)
9654         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9655         (process_psymtab_comp_unit_reader, add_partial_symbol)
9656         (add_partial_subprogram, process_full_comp_unit)
9657         (read_file_scope, read_func_scope, read_lexical_block_scope)
9658         (read_call_site_scope, dwarf2_rnglists_process)
9659         (dwarf2_ranges_process, dwarf2_ranges_read)
9660         (dwarf_decode_lines_1, var_decode_location, new_symbol)
9661         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
9662         Update.
9663         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
9664         Update.
9665         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
9666         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
9667         (process_one_symbol): Change type of "section_offsets".
9668         * ctfread.c (get_objfile_text_range): Update.
9669         * coffread.c (coff_symtab_read, enter_linenos)
9670         (process_coff_symbol): Update.
9671         * coff-pe-read.c (add_pe_forwarded_sym): Update.
9672         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
9673
9674 2020-01-08  Tom Tromey  <tromey@adacore.com>
9675
9676         * dwarf2read.c (parse_macro_definition): Use std::string.
9677         (parse_macro_definition): Likewise.
9678
9679 2020-01-08  Tom Tromey  <tromey@adacore.com>
9680
9681         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
9682         (ATTR_ALLOC_CHUNK): Remove.
9683
9684 2020-01-08  Tom Tromey  <tromey@adacore.com>
9685
9686         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
9687
9688 2020-01-08  Tom Tromey  <tromey@adacore.com>
9689
9690         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
9691         (dwarf2_compute_name, open_dwo_file): Likewise.
9692         (process_enumeration_scope): Use std::vector.
9693         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
9694         (partial_die_info::fixup, dwarf2_start_subfile)
9695         (guess_full_die_structure_name, dwarf2_name): Likewise.
9696         (determine_prefix): Update.
9697         (guess_full_die_structure_name): Make return type const.
9698         (partial_die_full_name): Return unique_xmalloc_ptr.
9699         (DW_FIELD_ALLOC_CHUNK): Remove.
9700
9701 2020-01-07  Tom Tromey  <tromey@adacore.com>
9702
9703         PR build/24937:
9704         * stap-probe.c (class stap_static_probe_ops): Add constructor.
9705
9706 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9707
9708         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
9709
9710 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9711
9712         * stack.c (print_frame_info): Move disassemble_next_line code
9713         inside source_print block.
9714
9715 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9716
9717         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
9718         gdb/signals.h, as we are now using native signal symbols.
9719
9720 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9721
9722         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
9723         overflow by an early check of content vs threshold.
9724         * tui/tui-source.c (tui_source_window::line_is_displayed):
9725         Likewise.
9726
9727 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9728
9729         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
9730
9731 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9732
9733         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
9734         export table if no section contains it's RVA.
9735
9736 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9737
9738         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
9739
9740 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
9741
9742         * source.c (print_source_lines_base): Set last_line_listed.
9743
9744 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9745
9746         * tui/tui-disasm.c: Remove trailing spaces.
9747
9748 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9749             Pedro Alves  <palves@redhat.com>
9750
9751         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
9752         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
9753         (windows_gdb_signal_to_target): New function, uses the above
9754         enumeration to convert GDB internal signal codes to equivalent
9755         Windows codes.
9756         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
9757         * windows-nat.c: Include "gdb_wait.h".
9758         (get_windows_debug_event): Extract the fatal exception from the
9759         exit status and convert to the equivalent Posix signal number.
9760         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
9761         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
9762         * gdbsupport/gdb_wait.c: New file, implements
9763         windows_status_to_termsig.
9764         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
9765         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
9766
9767 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9768
9769         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
9770         show_layout.
9771
9772 2020-01-05  Luis Machado  <luis.machado@linaro.org>
9773
9774         * aarch64-linux-nat.c
9775         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
9776         and bfd_mach_aarch64.
9777
9778 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9779
9780         * ui-file.c (stdio_file::can_emit_style_escape)
9781         (tee_file::can_emit_style_escape): Ensure style is used also on
9782         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
9783         to gdb_stdout.
9784         * main.c (set_gdb_data_directory): Use file style to output the
9785         warning that the given pathname is not a directory.
9786         * top.c (show_history_filename, gdb_safe_append_history)
9787         (show_gdb_datadir): Use file style.
9788
9789 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9790
9791         * solib-target.c (struct lm_info_target):
9792         Change offsets to be a unique_xmalloc_ptr.
9793         (solib_target_relocate_section_addresses): Update.
9794
9795 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9796
9797         * windows-nat.c (windows_clear_solib): Free so_list linked list.
9798
9799 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9800
9801         * MAINTAINERS (Write After Approval): Add myself.
9802
9803 2020-01-02  Luis Machado  <luis.machado@linaro.org>
9804
9805         * proc-service.c (get_ps_regcache): Remove reference to obsolete
9806         Cell BE architecture.
9807         * target.h (struct target_ops) <thread_architecture>: Likewise.
9808
9809 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9810
9811         * Makefile.in: Use INSTALL_PROGRAM_ENV.
9812
9813 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9814
9815         * MAINTAINERS (Write After Approval): Add myself.
9816
9817 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9818
9819         * gdbarch.sh: Update copyright year range of generated files.
9820
9821 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9822
9823         Update copyright year range in all GDB files.
9824
9825 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9826
9827         * copyright.py: Convert to Python 3.
9828
9829 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9830
9831         * copyright.py: Adapt after move of gnulib directory from gdb
9832         directory to toplevel directory.
9833
9834 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9835
9836         * copyright.py (main): Exit if run from the wrong directory.
9837
9838 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9839
9840         * top.c (print_gdb_version): Change copyright year to 2020.
9841
9842 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9843
9844         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
9845
9846 For older changes see ChangeLog-2019.
9847 \f
9848 Local Variables:
9849 mode: change-log
9850 left-margin: 8
9851 fill-column: 74
9852 version-control: never
9853 coding: utf-8
9854 End: