gdb/ChangeLog

   1 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
   2
   3         PR gdb/25054
   4         * infcall.c (call_function_by_hand_dummy): Update the argument-
   5         passing section for call-by-value parameters.
   6         (struct destructor_info): New struct.
   7         (call_destructors): New auxiliary function.
   8
   9 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  10
  11         * gnu-v3-abi.c (enum definition_style): New enum type.
  12         (get_def_style): New function.
  13         (is_user_provided_def): New function.
  14         (is_implicit_def): New function.
  15         (is_copy_or_move_constructor_type): New function.
  16         (is_copy_constructor_type): New function.
  17         (is_move_constructor_type): New function.
  18         (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
  19         for a given type.
  20
  21 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  22
  23         * language.h (struct language_pass_by_ref_info): New struct.
  24         (struct language_defn)<la_pass_by_reference>: Change the signature
  25         to return a language_pass_by_ref_info instead of an int.
  26         (language_pass_by_reference): Ditto.
  27         (default_pass_by_reference): Ditto.
  28         Adjust the users listed below.
  29         * arch-utils.c (default_return_in_first_hidden_param_p):
  30         Update.
  31         * cp-abi.c (cp_pass_by_reference): Update.
  32         * cp-abi.h (cp_pass_by_reference): Update declaration.
  33         (struct cp_abi_ops)<pass_by_reference>: Update.
  34         * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
  35         * infcall.c (call_function_by_hand_dummy): Update.
  36         * language.c (language_pass_by_reference): Update.
  37         (default_pass_by_reference): Update.
  38         * tic6x-tdep.c (tic6x_return_value): Update.
  39
  40 2019-12-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  41
  42         * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
  43         and DW_AT_deleted attributes of a function.
  44         (read_structure_type): Read the DW_AT_calling_convention attribute
  45         of a type.
  46         (is_valid_DW_AT_defaulted): New function.
  47         (is_valid_DW_AT_calling_convention_for_type): New function.
  48         * gdbtypes.h: Include dwarf2.h.
  49         (struct fn_field)<defaulted>: New field to store the
  50         DW_AT_defaulted attribute.
  51         (struct fn_field)<is_deleted>: New field to store the
  52         DW_AT_deleted attribute.
  53         (struct cplus_struct_type)<calling_convention>: New field to store
  54         the DW_AT_calling_convention attribute.
  55         (TYPE_FN_FIELD_DEFAULTED): New macro.
  56         (TYPE_FN_FIELD_DELETED): New macro.
  57         (TYPE_CPLUS_CALLING_CONVENTION): New macro.
  58         * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
  59         to the .h file.
  60         (print_cplus_stuff): Likewise.
  61
  62 2019-12-20  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui.c (tui_show_source): Remove.
  65         * tui/tui.h (tui_show_source): Don't declare.
  66         * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
  67         tui_show_source.
  68
  69 2019-12-20  Tom Tromey  <tom@tromey.com>
  70
  71         * tui/tui-stack.h (tui_show_frame_info): Return bool.
  72         * tui/tui-stack.c (tui_show_frame_info): Return bool.
  73         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
  74         Update.
  75
  76 2019-12-20  Tom Tromey  <tom@tromey.com>
  77
  78         PR tui/18932:
  79         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
  80         Rename parameters.  Handle the not-from-stack-frame case.
  81         (from_stack, from_source_symtab): New globals.
  82         (tui_before_prompt, tui_normal_stop): Update.
  83         (tui_context_changed, tui_symtab_changed): New functions.
  84         (tui_attach_detach_observers): Attach new observers.
  85
  86 2019-12-20  Tom Tromey  <tom@tromey.com>
  87
  88         * source.c (struct current_source_location) <set, symtab, line>:
  89         New methods.
  90         <m_symtab, m_line>: Rename.  Now private.
  91         (get_current_source_symtab_and_line)
  92         (set_default_source_symtab_and_line)
  93         (set_current_source_symtab_and_line)
  94         (clear_current_source_symtab_and_line, select_source_symtab)
  95         (info_source_command, print_source_lines_base)
  96         (info_line_command, search_command_helper): Update.
  97         * observable.h (current_source_symtab_and_line_changed): Declare
  98         observable.
  99         * observable.c (current_source_symtab_and_line_changed): Define
 100         observable.
 101
 102 2019-12-20  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
 105         (tui_before_prompt, tui_normal_stop): Update.
 106
 107 2019-12-20  Tom Tromey  <tom@tromey.com>
 108
 109         * tui/tui-winsource.c
 110         (tui_source_window_base::update_source_window_as_is): Don't call
 111         set_current_source_symtab_and_line.
 112
 113 2019-12-20  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
 116         Take a symtab_and_line.
 117         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
 118         symtab_and_line.
 119         (tui_show_frame_info): Update.
 120
 121 2019-12-20  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-stack.c (tui_show_frame_info): Don't call
 124         update_exec_info.
 125
 126 2019-12-20  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui.c (tui_enable): Call tui_display_main.
 129
 130 2019-12-20  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
 133         get_current_source_symtab_and_line, and main_name.
 134
 135 2019-12-20  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui.c (tui_show_source): Update.
 138         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
 139         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
 140         a symtab_symbol_info, not a separate symtab and line.  Simplify.
 141
 142 2019-12-20  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
 145         Simplify.
 146
 147 2019-12-20  Tom Tromey  <tom@tromey.com>
 148
 149         * tui/tui-winsource.h (struct tui_source_window_base)
 150         <set_contents, update_source_window_as_is, update_source_window>:
 151         Take a sal, not a separate symtab and tui_line_or_address.
 152         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
 153         (tui_source_window_base::update_source_window_as_is): Take a sal,
 154         not a separate symtab and tui_line_or_address.
 155         (tui_update_source_windows_with_addr)
 156         (tui_update_source_windows_with_line)
 157         (tui_source_window_base::rerender)
 158         (tui_source_window_base::refill): Update.
 159         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
 160         a sal, not a separate symtab and tui_line_or_address.
 161         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
 162         not a separate symtab and tui_line_or_address.
 163         (tui_source_window::maybe_update): Update.
 164         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
 165         a sal, not a separate symtab and tui_line_or_address.
 166         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
 167         not a separate symtab and tui_line_or_address.
 168         (tui_disasm_window::do_scroll_vertical)
 169         (tui_disasm_window::maybe_update): Update.
 170
 171 2019-12-20  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-winsource.c (tui_source_window_base::refill): Use
 174         start_line_or_addr.
 175         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
 176         start_line_or_addr.
 177         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 178         start_line_or_addr.
 179
 180 2019-12-20  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-winsource.h (struct tui_source_window_base)
 183         <set_contents>: Return bool.
 184         * tui/tui-winsource.c
 185         (tui_source_window_base::update_source_window_as_is): Update.
 186         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 187         Return bool.
 188         * tui/tui-source.c (tui_source_window::set_contents): Return
 189         bool.  Simplify.
 190         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 191         Return bool.
 192         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
 193         bool.
 194
 195 2019-12-20  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 198         (tui_update_source_windows_with_line): Call update_source_window.
 199         * tui/tui-source.h (struct tui_source_window)
 200         <show_symtab_source>: Don't declare.
 201         * tui/tui-source.c (tui_source_window::show_symtab_source):
 202         Remove.
 203
 204 2019-12-20  Tom Tromey  <tom@tromey.com>
 205
 206         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 207         update_source_window directly.
 208         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
 209         * tui/tui-disasm.c (tui_show_disassem): Remove.
 210
 211 2019-12-20  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-winsource.c
 214         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
 215         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
 216
 217 2019-12-20  Tom Tromey  <tom@tromey.com>
 218
 219         * tui/tui-winsource.h (struct tui_source_window_base)
 220         <maybe_update>: Remove line_no and addr parameters.
 221         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 222         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 223         Update.
 224         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 225         line_no and addr parameters.
 226         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 227         Update.
 228         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 229         line_no and addr parameters.
 230
 231 2019-12-20  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 234         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 235
 236 2019-12-20  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 239         tui_show_disassem.
 240         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 241         declare.
 242         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 243
 244 2019-12-20  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui.h (tui_show_source): Remove parameters.
 247         * tui/tui.c (tui_show_source): Remove parameters.
 248         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 249
 250 2019-12-20  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui.c (tui_show_source): Update.
 253         * tui/tui-winsource.c (tui_display_main): Update.
 254         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 255         to symtab.
 256         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 257         to symtab.
 258         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 259
 260 2019-12-20  Tom Tromey  <tom@tromey.com>
 261
 262         PR tui/23619:
 263         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 264         (tui_redisplay_readline): Use rl_display_prompt.
 265         (tui_prep_terminal): Update.
 266
 267 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 268
 269         * configure: Regenerate.
 270         * configure.ac: Quote variable arguments of test.
 271         * gdbsupport/common.m4: Likewise.
 272
 273 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 274
 275         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 276         2 to pow ().
 277
 278 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 279
 280         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 281         log10 to double to fix Solaris 11 with gcc 5.5.
 282
 283 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 284
 285         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 286         "sun" to "saddr_un".
 287
 288 2019-12-19  Tom Tromey  <tromey@adacore.com>
 289
 290         * ui-out.h (enum class field_kind): Fix comment.
 291
 292 2019-12-11  Tom Tromey  <tromey@adacore.com>
 293
 294         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 295
 296 2019-12-18  Tom Tromey  <tromey@adacore.com>
 297
 298         PR build/25268:
 299         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 300         type on macOS.  Add comment.
 301
 302 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 303
 304         * c-lang.c (c_get_string, asm_language_defn): Remove space
 305         before tab.
 306
 307 2019-12-18  Tom Tromey  <tromey@adacore.com>
 308
 309         PR build/25250:
 310         * ui-out.c (ui_out::vmessage): Update.
 311         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 312         Rename.
 313         (string_field): Update.
 314         (signed_field): Update.
 315
 316 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 317
 318         * top.c (print_gdb_configuration): Adjust indentation.
 319
 320 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 321
 322         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 323
 324 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 325
 326         * tui/tui-layout.h (class tui_layout_base): Add virtual
 327         destructor.
 328
 329 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 330
 331         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 332         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 333         (process_event_stop_test): Keep stepping over skipped inline functions.
 334
 335 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 336
 337         * jit.c (struct gdb_block) <next>: Remove field.
 338         (struct gdb_symtab) <~gdb_symtab>: Remove.
 339         <blocks>: Change type to std::forward_list<gdb_block>.
 340         (compare_block): Remove.
 341         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 342         block at the beginning, don't mind about sorting.
 343         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 344         before using it.
 345
 346 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 347
 348         * jit.c (struct gdb_block): Add constructor, initialize
 349         real_block and next fields.
 350         <name>: Change type to gdb::unique_xmalloc_ptr.
 351         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 352         (jit_block_open_impl): Allocate gdb_block with new.
 353         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 354
 355 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 356
 357         * jit.c: Include forward_list.
 358         (struct gdb_symtab) <next>: Remove field.
 359         (struct gdb_object) <symtabs>: Change type to
 360         std::forward_list<gdb_symtab>.
 361         (jit_object_open_impl): Allocate gdb_object with new.
 362         (jit_symtab_open_impl): Adjust to std::forward_list.
 363         (finalize_symtab): Don't delete symtab.
 364         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 365         gdb_object with delete.
 366
 367 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 368
 369         * jit.c (struct gdb_symtab): Add constructor, destructor,
 370         initialize fields.
 371         <linetable>: Change type to unique_xmalloc_ptr.
 372         <file_name>: Change type to std::string.
 373         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 374         (jit_symtab_line_mapping_add_impl): Adjust.
 375         (finalize_symtab): Adjust, call delete on stab.
 376
 377 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 378
 379         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 380
 381 2019-12-16  Tom Tromey  <tromey@adacore.com>
 382
 383         * windows-nat.c (windows_nat_target::attach): Update.
 384         * remote.c (extended_remote_target::attach): Update.
 385         * procfs.c (procfs_target::attach): Update.
 386         * nto-procfs.c (nto_procfs_target::attach): Update.
 387         (nto_procfs_target::create_inferior): Update.
 388         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 389         * gnu-nat.c (gnu_nat_target::attach): Update.
 390         (gnu_nat_target::detach): Update.
 391         * darwin-nat.c (darwin_nat_target::attach): Update.
 392         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 393         return.
 394         * bsd-kvm.c (bsd_kvm_target_open): Update.
 395         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 396
 397 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 398
 399         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 400         (we no longer need to include time.h before pathmax.h)
 401
 402 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 403
 404         * ada-exp.y (write_ambiguous_var): Update.
 405         * coffread.c (process_coff_symbol): Update.
 406         * ctfread.c (ctf_add_enum_member_cb): Update.
 407         (new_symbol): Update.
 408         * dwarf2read.c (fixup_go_packaging): Update.
 409         (new_symbol): Update.
 410         * language.c (language_alloc_type_symbol): Update.
 411         * mdebugread.c (new_symbol): Update.
 412         * minsyms.c (minimal_symbol_reader::record_full): Update.
 413         * psymtab.c (add_psymbol_to_bcache): Update.
 414         * stabsread.c (define_symbol): Update.
 415         (read_enum_type): Update.
 416         * symtab.c (symbol_set_language): Make this a member function...
 417         (general_symbol_info::set_language): ... here.
 418         * symtab.h (struct general_symbol_info) <set_language>: New function.
 419         (SYMBOL_SET_LANGUAGE): Remove.
 420         (symbol_set_language): Remove.
 421
 422 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 423
 424         * ada-lang.c (ada_add_block_symbols): Update.
 425         (ada_collect_symbol_completion_matches): Update.
 426         * ax-gdb.c (gen_expr): Update.
 427         * block.c (block_lookup_symbol): Update.
 428         (block_lookup_symbol_primary): Update.
 429         (block_find_symbol): Update.
 430         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 431         * dbxread.c (process_one_symbol): Update.
 432         * dictionary.c (insert_symbol_hashed): Update.
 433         (collate_pending_symbols_by_language): Update.
 434         (mdict_add_symbol): Update.
 435         * dwarf-index-write.c (write_psymbols): Update.
 436         * dwarf2read.c (fixup_go_packaging): Update.
 437         * findvar.c (read_var_value): Update.
 438         * ft32-tdep.c (ft32_skip_prologue): Update.
 439         * go-lang.c (go_symbol_package_name): Update.
 440         * language.h (scoped_switch_to_sym_language_if_auto::
 441         scoped_switch_to_sym_language_if_auto): Update.
 442         * linespec.c (find_method): Update.
 443         (find_label_symbols_in_block): Update.
 444         * mdebugread.c (parse_symbol): Update.
 445         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 446         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 447         (minimal_symbol_reader::install): Update.
 448         * moxie-tdep.c (moxie_skip_prologue): Update.
 449         * parse.c (parse_exp_in_context): Update.
 450         * psymtab.c (psymbol_name_matches): Update.
 451         (match_partial_symbol): Update.
 452         (lookup_partial_symbol): Update.
 453         (psymbol_hash): Update.
 454         (psymbol_compare): Update.
 455         * python/py-framefilter.c (extract_sym): Update.
 456         (py_print_single_arg): Update.
 457         * stabsread.c (define_symbol): Update.
 458         * stack.c (print_frame_arg): Update.
 459         (find_frame_funname): Update.
 460         (info_frame_command_core): Update.
 461         * symfile.c (set_initial_language): Update.
 462         * symtab.c (symbol_set_demangled_name): Update.
 463         (symbol_get_demangled_name): Update.
 464         (symbol_set_language): Update.
 465         (symbol_find_demangled_name): Update.
 466         (symbol_set_names): Update.
 467         (general_symbol_info::natural_name): Update.
 468         (general_symbol_info::demangled_name): Update.
 469         (general_symbol_info::search_name): Update.
 470         (symbol_matches_search_name): Update.
 471         (eq_symbol_entry): Update.
 472         (iterate_over_symbols): Update.
 473         (completion_list_add_symbol): Update.
 474         (completion_list_add_msymbol): Update.
 475         (completion_list_add_fields): Update.
 476         * symtab.h (struct general_symbol_info) <language>: New function.
 477         <language>: Rename to...
 478         <m_language>: ...this.
 479         (SYMBOL_LANGUAGE): Remove.
 480         (MSYMBOL_LANGUAGE): Remove.
 481         (struct symbol) <ctor>: Update.
 482         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 483
 484 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 485
 486         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 487         set the language of sym.
 488         * language.c (language_alloc_type_symbol): Likewise.
 489
 490 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 491
 492         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 493         PR gdb/23613
 494         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 495         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 496         (core_target_open): Use 'gdb_abspath'.
 497         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 498         'current_directory == NULL' case.
 499         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 500         explain what happens when 'current_directory' is NULL.
 501         * go32-nat.c (go32_nat_target::wait): Check if
 502         'current_directory' is NULL before call to 'chdir'.
 503         * source.c (add_path): Use 'gdb_abspath'.
 504         * top.c: Include 'gdbsupport/pathstuff.h'.
 505         (init_history): Use 'gdb_abspath'.
 506         (set_history_filename): Likewise.
 507         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 508         (tfile_target_open): Use 'gdb_abspath'.
 509
 510 2019-12-13  Tom Tromey  <tromey@adacore.com>
 511
 512         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 513         warning or error.
 514
 515 2019-12-13  Tom Tromey  <tromey@adacore.com>
 516
 517         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 518
 519 2019-12-13  Tom Tromey  <tromey@adacore.com>
 520
 521         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 522
 523 2019-12-13  Tom Tromey  <tromey@adacore.com>
 524
 525         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 526
 527 2019-12-13  Tom Tromey  <tromey@adacore.com>
 528
 529         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 530         (string_vappendf): Add ARI comment.
 531
 532 2019-12-13  Tom Tromey  <tromey@adacore.com>
 533
 534         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 535         floatformat_to_double.
 536         * target-float.c (host_float_ops<T>::from_target): Add ARI
 537         comment.
 538
 539 2019-12-13  Tom Tromey  <tromey@adacore.com>
 540
 541         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 542         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 543         ARI marker to abort.
 544         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 545
 546 2019-12-13  Tom Tromey  <tromey@adacore.com>
 547
 548         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 549
 550 2019-12-13  Tom Tromey  <tromey@adacore.com>
 551
 552         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 553
 554 2019-12-13  Tom Tromey  <tromey@adacore.com>
 555
 556         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 557         checks.
 558
 559 2019-12-13  Tom Tromey  <tromey@adacore.com>
 560
 561         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 562         end>: No longer "const".
 563
 564 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 565
 566         * jit.c: Fix indentation, replace spaces with tabs where
 567         applicable.
 568
 569 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 570
 571         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 572
 573 2019-12-12  Tom Tromey  <tom@tromey.com>
 574
 575         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 576         unique_ptr.
 577
 578 2019-12-12  Tom Tromey  <tom@tromey.com>
 579
 580         * progspace.h (objfile_list): New typedef.
 581         (class unwrapping_objfile_iterator)
 582         (struct unwrapping_objfile_range): Newl
 583         (struct program_space) <objfiles_range>: Change type.
 584         <objfiles>: Change return type.
 585         <add_objfile>: Change type of "objfile" parameter.
 586         <objfiles_list>: Now a list of shared_ptr.
 587         * progspace.c (program_space::add_objfile): Change type of
 588         "objfile".  Update.
 589         (program_space::remove_objfile): Update.
 590         * objfiles.h (struct objfile) <~objfile>: Make public.
 591         * objfiles.c (objfile::make): Update.
 592         (objfile::unlink): Don't call delete.
 593
 594 2019-12-12  Tom Tromey  <tom@tromey.com>
 595
 596         * symfile.c (symbol_file_clear): Update.
 597         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 598         method.
 599         * progspace.c (program_space::free_all_objfiles): New method.
 600         * objfiles.h (free_all_objfiles): Don't declare.
 601         * objfiles.c (free_all_objfiles): Move to program_space.
 602
 603 2019-12-12  Tom Tromey  <tom@tromey.com>
 604
 605         * progspace.c (program_space::add_objfile)
 606         (program_space::remove_objfile): Update.
 607         (program_space::multi_objfile_p): Remove.
 608         * objfiles.h (struct objfile) <next>: Remove.
 609         * objfiles.c (objfile::objfile): Update.
 610         (put_objfile_before): Update.
 611         (unlink_objfile): Update.
 612         * progspace.h (object_files): Remove.
 613         (struct program_space) <objfiles_head>: Remove.
 614         <objfiles_list>: New member.
 615         <objfiles_range, objfiles_safe_range>: Change type.
 616         (objfiles): Change return type.
 617         (objfiles_safe): Update.
 618         (multi_objfile_p): Rewrite and inline.
 619         (object_files): Remove macro.
 620
 621 2019-12-12  Tom Tromey  <tom@tromey.com>
 622
 623         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 624         second constructor.
 625         (basic_safe_range): New class.
 626
 627 2019-12-12  Tom Tromey  <tom@tromey.com>
 628
 629         * progspace.c (program_space::multi_objfile_p): New method.
 630         * printcmd.c (info_symbol_command): Update.
 631         * maint.c (maintenance_translate_address): Update.
 632         * objfiles.h (MULTI_OBJFILE_P): Remove.
 633         * progspace.h (struct program_space) <multi_objfile_p>: New
 634         method.
 635
 636 2019-12-12  Tom Tromey  <tom@tromey.com>
 637
 638         * progspace.h (struct program_space) <remove_objfile>: Declare.
 639         * progspace.c (program_space::remove_objfile): New method.
 640         * objfiles.c (unlink_objfile): Remove.
 641         (objfile::unlink): Call remove_objfile.
 642         (objfile): Don't call unlink_objfile.
 643
 644 2019-12-12  Tom Tromey  <tom@tromey.com>
 645
 646         * progspace.h (struct program_space) <add_objfile>: Declare
 647         method.
 648         * progspace.c (program_space::add_objfile): New method.
 649         * objfiles.c (~objfile): Don't unlink objfile.
 650         (put_objfile_before): Remove.
 651         (add_separate_debug_objfile): Don't call put_objfile_before.
 652         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 653         the per-program-space data.
 654
 655 2019-12-12  Tom Tromey  <tom@tromey.com>
 656
 657         * symfile.c (syms_from_objfile_1): Use objfile_up.
 658         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 659         method.
 660         (reread_symbols): Use objfile_up.
 661         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 662         unlink method.
 663         * objfiles.h (struct objfile) <~objfile>: Now private.
 664         <unlink>: New method.
 665         (struct objfile_deleter): New.
 666         (objfile_up): New typedef.
 667         * objfiles.c (objfile::unlink): New method.
 668         (free_objfile_separate_debug, free_all_objfiles)
 669         (objfile_purge_solibs): Use it.
 670         * jit.c (jit_unregister_code): Remove.
 671         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 672         objfile.
 673         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 674         objfile.
 675         * compile/compile-object-load.c (compile_object_load): Use
 676         objfile_up.
 677
 678 2019-12-12  Tom Tromey  <tom@tromey.com>
 679
 680         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 681         objfile::make.
 682         * objfiles.h (struct objjfile) <make>: No longer inline.
 683         (add_separate_debug_objfile): Don't declare.
 684         * objfiles.c (add_separate_debug_objfile): Now static.
 685         (objfile::make): Move from objfiles.h.  Call
 686         add_separate_debug_objfile.  Add "parent" parameter.
 687
 688 2019-12-12  Tom Tromey  <tom@tromey.com>
 689
 690         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 691         * objfiles.h (struct objfile): Make constructor private.
 692         <make>: New static method.
 693         * jit.c (jit_object_close_impl): Update.
 694
 695 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 696
 697         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 698         gdb::byte_vector.
 699
 700 2019-12-12  Tom Tromey  <tromey@adacore.com>
 701
 702         * xml-support.c (xml_fetch_content_from_file): Don't call
 703         malloc_failure.
 704         * utils.h (class gdb_argv): Remove malloc_failure comment.
 705         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 706
 707 2019-12-12  Tom Tromey  <tromey@adacore.com>
 708
 709         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 710         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 711         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 712         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 713         * riscv-ravenscar-thread.c: New file.
 714         * riscv-ravenscar-thread.h: New file.
 715         * riscv-tdep.c (riscv_gdbarch_init): Call
 716         register_riscv_ravenscar_ops.
 717
 718 2019-12-12  Tom Tromey  <tromey@adacore.com>
 719
 720         * gdbsupport/thread-pool.c (set_thread_name): Use
 721         ATTRIBUTE_UNUSED.
 722
 723 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 724
 725         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 726         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 727         macros.
 728
 729 2019-12-11  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-win.c (tui_set_win_height_command): Call
 732         tui_adjust_window_height.
 733         (tui_adjust_win_heights, new_height_ok): Remove.
 734         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 735         * tui/tui-layout.c (tui_adjust_window_height): New function.
 736
 737 2019-12-11  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-win.c (tui_resize_all): Remove code, call
 740         tui_apply_current_layout.
 741
 742 2019-12-11  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 745         * tui/tui-layout.c (standard_layouts, applied_layout): New
 746         globals.
 747         (tui_apply_current_layout): New function.
 748         (show_layout): Set applied_layout.  Call
 749         tui_apply_current_layout.
 750         (show_source_command, show_disasm_command)
 751         (show_source_disasm_command, show_data)
 752         (show_source_or_disasm_and_command): Remove.
 753         (initialize_layouts): New function.
 754         (_initialize_tui_layout): Call initialize_layouts.
 755
 756 2019-12-11  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-layout.h (class tui_layout_base)
 759         (class tui_layout_window, class tui_layout_split): New.
 760         * tui/tui-layout.c (tui_get_window_by_name)
 761         (tui_layout_window::clone, tui_layout_window::apply)
 762         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 763         (tui_layout_split::add_window, tui_layout_split::clone)
 764         (tui_layout_split::get_sizes)
 765         (tui_layout_split::set_weights_from_heights)
 766         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 767         functions.
 768         (tui_layout_split::add_split, tui_layout_split::add_split)
 769         (tui_layout_split::set_weights_from_heights)
 770         (tui_layout_split::set_weights_from_heights): New functions.
 771
 772 2019-12-11  Tom Tromey  <tom@tromey.com>
 773
 774         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 775         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 776         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 777         * tui/tui-data.h (struct tui_point): Remove.
 778         (struct tui_gen_win_info) <origin>: Remove.
 779         <x, y>: New fields.
 780         * tui/tui-command.c (tui_cmd_window::resize): Update.
 781
 782 2019-12-11  Tom Tromey  <tom@tromey.com>
 783
 784         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 785         Implement.
 786         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 787         Implement.
 788         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 789         method.
 790         (struct tui_win_info) <min_height>: Implement.
 791
 792 2019-12-11  Tom Tromey  <tom@tromey.com>
 793
 794         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 795         (struct tui_win_info) <can_box>: Update.
 796
 797 2019-12-11  Tom Tromey  <tom@tromey.com>
 798
 799         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 800         method.
 801         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 802         method.
 803         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 804         method.
 805         (struct tui_win_info) <max_height>: Now override.
 806
 807 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 808
 809         * NEWS: Create a new section for the next release branch.
 810         Rename the section of the current branch, now that it has
 811         been cut.
 812
 813 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 814
 815         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 816         * version.in: Bump version to 10.0.50.DATE-git.
 817
 818 2019-12-11  Tom Tromey  <tromey@adacore.com>
 819
 820         PR build/25268:
 821         * gdbsupport/thread-pool.c (set_thread_name): New function.
 822         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 823         (thread_pool::thread_function): Call set_thread_name.
 824
 825 2019-12-11  Tom Tromey  <tromey@adacore.com>
 826
 827         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 828         bfd_get_signed_8.
 829
 830 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 831
 832         * NEWS: Document -raw-values option and the related setting commands.
 833         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 834         only set it on when /r is given.
 835         * valprint.c (value_print_option_defs): New element raw-values.
 836         * Makefile.in: Add the new file.
 837
 838 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 839
 840         * gdbsupport/safe-strerror.c: Supress the unused function warning
 841         for select_strerror_r.
 842
 843 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 844
 845         * config.in: Regenerate.
 846         * configure: Regenerate.
 847         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 848         safe_strerror instead of strerror.
 849         * gdbsupport/common.m4: Don't check for strerror.
 850         * gdbsupport/safe-strerror.c: Support both the glibc version
 851         of strerror_r and the XSI version.
 852
 853 2019-12-10  Tom Tromey  <tromey@adacore.com>
 854
 855         * ada-typeprint.c (print_choices): Use a single "?".
 856         (print_variant_part): Print "?" if the discriminant name
 857         is not known.
 858
 859 2019-12-10  George Barrett  <bob@bob131.so>
 860
 861         Fix scripted probe breakpoints.
 862         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 863         declaration forward.
 864         (breakpoint_ops_for_event_location_type)
 865         (breakpoint_ops_for_event_location): Add function definitions.
 866         (break_command_1, trace_command): Use
 867         breakpoint_ops_for_event_location.
 868         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 869         declarations.
 870         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 871         breakpoint_ops_for_event_location.
 872         * python/py-breakpoint.c (bppy_init): Use
 873         breakpoint_ops_for_event_location.
 874
 875 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 876
 877         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 878         when ranking an lvalue argument for an rvalue parameter.
 879
 880 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 881
 882         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 883         template argument for scoped_restore_tmpl from bool to int.
 884
 885 2019-12-07  Keith Seitz  <keiths@redhat.com>
 886
 887         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 888         (build_id_to_debug_bfd): Make static, rewriting to use
 889         build_id_to_bfd_suffix.
 890         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 891         adding `suffix' parameter. Append SUFFIX to file names
 892         when searching for matching files.
 893         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 894         (build_id_to_exec_bfd): Likewise.
 895         * build-id.h (build_id_to_debug_bfd): Clarify that function
 896         searches for BFD of debug info file.
 897         (build_id_to_exec_bfd): Declare.
 898         * corelow.c: Include build-id.h.
 899         (locate_exec_from_corefile_build_id): New function.
 900         (core_target_open): If no executable BFD is found,
 901         search for a core file BFD using build-id.
 902
 903 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 904
 905         * bcache.c: Put in namespace gdb.
 906         * bcache.h: Likewise.
 907         * gdbtypes.c (check_types_worklist): Update.
 908         (types_deeply_equal): Update.
 909         * macrotab.c (struct macro_table) <bcache>: Update.
 910         (new_macro_table): Update.
 911         * macrotab.h (struct bcache): Put this forward declaration
 912         inside namespace gdb.
 913         (new_macro_table): Update.
 914         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 915         Update.
 916         <macro_cache>: Update.
 917         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 918
 919 2019-12-06  Tom de Vries  <tdevries@suse.de>
 920
 921         PR symtab/24971
 922         * block.c (best_symbol, better_symbol): New function.
 923         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 924         decl.
 925
 926 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 927
 928         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 929         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 930         for ranking see-through reference cases.
 931
 932 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 933         * stack.c (faas_command): Check a command is provided.
 934         * thread.c (taas_command, tfaas_command): Likewise.
 935
 936 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 937         * inferior.c (prune_inferiors):  Only call delete_inferior,
 938         Do not modify the inferior list.
 939
 940 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 941
 942         * c-exp.y: Update calls to lookup_typename,
 943         lookup_signed_typename and lookup_unsigned_typename.
 944         * c-lang.c (evaluate_subexp_c): Likewise.
 945         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 946         Likewise.
 947         * eval.c (binop_promote): Likewise.
 948         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 949         (lookup_unsigned_typename): Likewise.
 950         (lookup_signed_typename): Likewise.
 951         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 952         (lookup_signed_typename): Likewise.
 953         (lookup_typename): Likewise.
 954         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 955         lookup_typename, lookup_signed_typename,
 956         lookup_unsigned_typename.
 957         * m2-exp.y: Likewise.
 958         * printcmd.c (printf_wide_c_string): Likewise.
 959         (ui_printf): Likewise.
 960         * python/py-type.c (typy_lookup_typename): Likewise.
 961         * python/py-xmethods.c (python_xmethod_worker::invoke):
 962         Likewise.
 963         * rust-exp.y: Likewise.
 964
 965 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 966
 967         * configure.nat (obsd64): Add missing files x86-nat.o and
 968         nat/x86-dregs.o.
 969
 970 2019-12-04  Tom Tromey  <tom@tromey.com>
 971
 972         * valprint.c (val_print_string): Use metadata_style.
 973         * go-valprint.c (print_go_string): Use metadata style.
 974         * p-valprint.c (pascal_object_print_static_field): Use metadata
 975         style.
 976         * cp-valprint.c (cp_print_static_field): Use metadata style.
 977
 978 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 979             Chris January  <chris.january@arm.com>
 980
 981         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 982         tokens.
 983         (typebase): New patterns for complex, single/double precision, and
 984         single/double complex.
 985         (f77_keywords): Change token for complex keyword, and add single,
 986         double, and precision keywords.
 987
 988 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 989
 990         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 991         "info io_registers".
 992
 993 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 994
 995         * regcache.c (cooked_read_test): Initialize thread list of
 996         mock_inferior.
 997
 998 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 999
1000         * aarch64-linux-tdep.c: Remove includes.
1001
1002 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
1003
1004         * aarch64-tdep.c: Remove includes.
1005
1006 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
1007
1008         * filtered-iterator.h (filtered_iterator) <operator==,
1009         operator!=>: Compare wrapped iterators, not wrapped pointers.
1010         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1011         unittests/filtered_iterator-selftests.c.
1012         * unittests/filtered_iterator-selftests.c: New file.
1013
1014 2019-12-04  Tom Tromey  <tromey@adacore.com>
1015
1016         * gdbtypes.c (create_range_type): Inherit endianity
1017         from base type.
1018
1019 2019-12-04  Tom Tromey  <tromey@adacore.com>
1020
1021         * ada-lang.c (decode_constrained_packed_array)
1022         (ada_value_assign, value_assign_to_component): Update.
1023         * dwarf2loc.c (rw_pieced_value, access_memory)
1024         (dwarf2_compile_expr_to_ax): Update.
1025         * dwarf2read.c (dwarf2_add_field): Update.
1026         * eval.c (evaluate_subexp_standard): Update.
1027         * gdbarch.c, gdbarch.h: Rebuild.
1028         * gdbarch.sh (bits_big_endian): Remove.
1029         * gdbtypes.h (union field_location): Update comment.
1030         * target-descriptions.c (make_gdb_type): Update.
1031         * valarith.c (value_bit_index): Update.
1032         * value.c (struct value) <bitpos>: Update comment.
1033         (unpack_bits_as_long, modify_field): Update.
1034         * value.h (value_bitpos): Update comment.
1035
1036 2019-12-04  Tom Tromey  <tromey@adacore.com>
1037
1038         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
1039         endian-ness.
1040
1041 2019-12-04  Tom Tromey  <tromey@adacore.com>
1042
1043         * dwarf2read.c (dwarf2_init_float_type)
1044         (dwarf2_init_complex_target_type): Add byte_order parameter.
1045         (read_base_type): Compute byte order earlier.
1046         * gdbtypes.c (init_float_type): Add byte_order parameter.
1047         * gdbtypes.h (init_float_type): Add byte_order parameter.
1048
1049 2019-12-04  Tom Tromey  <tromey@adacore.com>
1050
1051         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1052
1053 2019-12-04  Tom Tromey  <tromey@adacore.com>
1054
1055         * dwarf2read.c (process_structure_scope): Initialize
1056         "discr_offset".
1057
1058 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1059
1060         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1061         add it into the search spec.
1062         (parse_max_results_option): New function.
1063         (mi_info_functions_or_variables): Parse -max-results flag and pass
1064         it to mi_symbol_info.
1065         (mi_cmd_symbol_info_modules): Likewise.
1066         (mi_cmd_symbol_info_types): Likewise.
1067         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1068         return type to bool, change result container into a set, and don't
1069         add new results if we have enough already.
1070         (global_symbol_searcher::add_matching_msymbols): Change return
1071         type to bool, and don't add new results if we have enough already.
1072         (sort_search_symbols_remove_dups): Delete.
1073         (global_symbol_searcher::search): Early exit from search loop when
1074         we have enough results.  Use a std::set to collect the results
1075         from calling add_matching_symbols.
1076         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1077         member function.
1078         (global_symbol_searcher) <m_max_search_results>: New member
1079         variable.
1080         (global_symbol_searcher) <add_matching_symbols>: Update header
1081         comment and change return type to bool.
1082         (global_symbol_searcher) <add_matching_msymbols>: Update header
1083         comment and change return type to bool.
1084
1085 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * symtab.c (symbol_search::compare_search_syms): Update header
1088         comment.
1089         (global_symbol_searcher::is_suitable_msymbol): New function.
1090         (global_symbol_searcher::expand_symtabs): New function.
1091         (global_symbol_searcher::add_matching_symbols): New function.
1092         (global_symbol_searcher::add_matching_msymbols): New function.
1093         (global_symbol_searcher::search): Move most of the content
1094         into the new functions above, and call them as needed.
1095         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1096         function.
1097         (global_symbol_searcher) <add_matching_symbols>: New member
1098         function.
1099         (global_symbol_searcher) <add_matching_msymbols>: New member
1100         function.
1101         (global_symbol_searcher) <is_suitable_msymbol>: New member
1102         function.
1103
1104 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1107         -symbol-info-module-variables entries.
1108         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1109         (mi_cmd_symbol_info_module_variables): Declare.
1110         * mi/mi-symbol-cmds.c
1111         (module_symbol_search_iterator): New typedef.
1112         (output_module_symbols_in_single_module_and_file): New function.
1113         (output_module_symbols_in_single_module): New function.
1114         (mi_info_module_functions_or_variables): New function.
1115         (mi_cmd_symbol_info_module_functions): New function.
1116         (mi_cmd_symbol_info_module_variables): New function.
1117         * NEWS: Mention new MI command.
1118
1119 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1120
1121         * bcache.c (hash): Remove.
1122         (hash_continue): Remove.
1123         * bcache.h (hash): Remove.
1124         (hash_continue): Remove.
1125         (struct bcache) <ctor>: Update.
1126         * psymtab.c (psymbol_hash): Update.
1127         * stabsread.c (hashname): Update.
1128         * utils.h (fast_hash): Add an argument for a start value,
1129         defaulting to zero.
1130
1131 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1132         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1133         (destroy_block_symbol_cache): New function.
1134         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1135         (resize_symbol_cache): Likewise.
1136
1137 2019-12-02  Tom Tromey  <tom@tromey.com>
1138
1139         * unittests/tui-selftests.c (run_tests): Make conditional.
1140         (_initialize_tui_selftest): Make conditional.
1141
1142 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1143
1144         * aix-thread.c (debug_aix_thread): Change type to bool.
1145
1146 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1147
1148         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1149
1150 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1151
1152         * dwarf2read.c (read_tag_string_type): Read the fields required to
1153         make a dynamic string, and possibly create a dynamic range for the
1154         string.
1155         (attr_to_dynamic_prop): Setup is_reference based on the type of
1156         attribute being processed.
1157         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1158         (resolve_dynamic_array): Rename to...
1159         (resolve_dynamic_array_or_string): ...this, update header comment,
1160         and accept TYPE_CODE_STRING.
1161         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1162
1163 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1166         of its implementation from...
1167         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1168         the new function.
1169
1170 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1171
1172         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1173         create a range with stride where appropriate.
1174         * f-valprint.c: Include 'gdbarch.h'.
1175         (f77_print_array_1): Take the stride into account when walking the
1176         array.  Also convert the stride into addressable units.
1177         * gdbtypes.c (create_range_type): Initialise the stride to
1178         constant zero.
1179         (create_range_type_with_stride): New function, initialise the
1180         range as normal, and then setup the stride.
1181         (has_static_range): Include the stride here.  Also change the
1182         return type to bool.
1183         (create_array_type_with_stride): Consider the range stride if the
1184         array isn't given its own stride.
1185         (resolve_dynamic_range): Resolve the stride if needed.
1186         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1187         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1188         (TYPE_BIT_STRIDE): Define.
1189         (TYPE_ARRAY_BIT_STRIDE): Define.
1190         (create_range_type_with_stride): Declare.
1191         * valarith.c (value_subscripted_rvalue): Take range stride into
1192         account when walking the array.
1193
1194 2019-12-01  Tom Tromey  <tom@tromey.com>
1195
1196         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1197         specially.
1198
1199 2019-12-01  Tom Tromey  <tom@tromey.com>
1200
1201         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1202         \0.
1203         * unittests/tui-selftests.c: New file.
1204         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1205
1206 2019-12-01  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1209
1210 2019-12-01  Tom Tromey  <tom@tromey.com>
1211
1212         * NEWS: Document new settings.
1213         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1214         * tui/tui-win.c (_initialize_tui_win): Add border style
1215         observers.
1216         * tui/tui-io.h (tui_apply_style): Declare.
1217         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1218         longer static.
1219         (apply_ansi_escape, tui_set_reverse_mode): Update.
1220         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1221         Add "skip_intensity" parameter.
1222         <changed>: New member.
1223         <do_set_value>: Declare.
1224         (tui_border_style, tui_active_border_style): Declare.
1225         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1226         globals.
1227         (cli_style_option): Initialize "changed".
1228         (cli_style_option::do_set_value): New function.
1229         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1230         parameter.  Update.
1231         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1232         (_initialize_cli_style): Update.  Create TUI border style
1233         commands.
1234
1235 2019-12-01  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1238         parameter.
1239         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1240         parameter.
1241         * tui/tui-win.h (compact_source): Declare.
1242         * tui/tui-win.c (compact_source): New global.
1243         (tui_set_compact_source, tui_show_compact_source): New functions.
1244         (_initialize_tui_win): Add "compact-source" setting.
1245         * tui/tui-source.c (tui_source_window::set_contents): Handle
1246         compact_source setting.
1247         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1248         * NEWS: Document new setting.
1249
1250 2019-11-30  Tom Tromey  <tom@tromey.com>
1251
1252         * dwarf2read.c (dwarf2_add_field): Include field offset when
1253         computing variant part length.
1254
1255 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1256         * NEWS:  Mention define-prefix.  Tell that command names can now
1257         contain a . character.
1258
1259 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1260
1261         * command.h (valid_cmd_char_p): Declare.
1262         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1263         the check of valid command char.
1264         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1265         valid_cmd_char_p.
1266         * cli/cli-script.c (validate_comname): Likewise.
1267         * completer.c (gdb_completer_command_word_break_characters):
1268         Do not remove . from the word break char, update comments.
1269         (complete_line_internal_1): Use valid_cmd_char_p.
1270         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1271         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1272
1273 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1274
1275         * cli/cli-script.c (do_define_command): Ensure a redefined
1276         prefix command is kept as a prefix command.
1277         (define_prefix_command): New function.
1278         (show_user_1): Report user defined prefixes.
1279         (_initialize_cli_script):  Create the new 'define-prefix' command.
1280         Add completers for 'define' and 'document'.
1281         * top.c (execute_command):  If command is a user-defined prefix only
1282         command, report the list of commands for this prefix command.
1283
1284 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1285
1286         * valops.c (find_oload_champ): Improve debug output.
1287
1288 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1289
1290         * valops.c (find_oload_champ): Print part of debug messages
1291         before the badness vector is std::move'd.
1292
1293 2019-11-28  Tom Tromey  <tom@tromey.com>
1294
1295         * value.c (creal_internal_fn): Fix comment.
1296
1297 2019-11-28  Tom Tromey  <tom@tromey.com>
1298
1299         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1300         flag_bound_evaluated>: Now unsigned.
1301
1302 2019-11-28  Tom Tromey  <tom@tromey.com>
1303
1304         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1305         declare.
1306
1307 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1308
1309         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1310         debug output.
1311         * jit.c (jit_unregister_code): Add debug print to match
1312         `jit_register_code`.
1313
1314 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1315
1316         * NEWS: Mention the new multithreaded symbol loading.
1317
1318 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1319
1320         * maint.c (n_worker_threads): Default to 0.
1321         (worker_threads_disabled): New function.
1322         * maint.h (worker_threads_disabled): New function.
1323         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1324         here if worker_threads_disabled () is true.
1325         (minimal_symbol_reader::install): Skip all threading if
1326         worker_threads_disabled () is true.
1327
1328 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1329
1330         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1331         hash code if possible.
1332         (add_minsym_to_demangled_hash_table): Likewise.
1333         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1334         on the background thread.
1335         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1336         Add these fields.
1337
1338 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1339
1340         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1341         of the mangled name on the background thread.
1342         * symtab.c (symbol_set_names): Allow passing in the hash of the
1343         linkage_name.
1344         * symtab.h (symbol_set_names): Likewise.
1345
1346 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1347
1348         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1349         physnames are computed for inherited DIEs.
1350
1351 2019-11-27  Tom Tromey  <tromey@adacore.com>
1352
1353         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1354         backslashes.
1355         * cp-support.c: Remove unnecessary backslashes.
1356
1357 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1358
1359         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1360         with sym->set_linkage_name.
1361         * coffread.c (coff_read_enum_type): Likewise.
1362         * mdebugread.c (parse_symbol): Likewise.
1363         * stabsread.c (patch_block_stabs): Likewise.
1364         (define_symbol): Likewise.
1365         (read_enum_type): Likewise.
1366         (common_block_end): Likewise.
1367         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1368         function.
1369         (SYMBOL_SET_LINKAGE_NAME): Remove.
1370         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1371         with sym->set_linkage_name.
1372
1373 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1374
1375         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1376         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1377         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1378         * NEWS: Mention new MI command.
1379
1380 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1381
1382         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1383         '-symbol-info-types', and '-symbol-info-variables'.
1384         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1385         (mi_cmd_symbol_info_types): Declare.
1386         (mi_cmd_symbol_info_variables): Declare.
1387         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1388         (output_debug_symbol): New function.
1389         (output_nondebug_symbol): New function.
1390         (mi_symbol_info): New function.
1391         (mi_info_functions_or_variables): New function.
1392         (mi_cmd_symbol_info_functions): New function.
1393         (mi_cmd_symbol_info_types): New function.
1394         (mi_cmd_symbol_info_variables): New function.
1395         * NEWS: Mention new commands.
1396
1397 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1398
1399         * symtab.c (symbol_to_info_string): New function, most content
1400         moved from print_symbol_info, but updated to return a std::string.
1401         (print_symbol_info): Update to use symbol_to_info_string and print
1402         returned string.
1403         * symtab.h (symbol_to_info_string): Declare new function.
1404
1405 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * python/python.c (gdbpy_rbreak): Convert to using
1408         global_symbol_searcher.
1409         * symtab.c (file_matches): Convert return type to bool, change
1410         file list to std::vector, update header comment.
1411         (search_symbols): Rename to...
1412         (global_symbol_searcher::search): ...this and update now its
1413         a member function of global_symbol_searcher.  Take account of the
1414         changes to file_matches.
1415         (symtab_symbol_info): Convert to using global_symbol_searcher.
1416         (rbreak_command): Likewise.
1417         (search_module_symbols): Likewise.
1418         * symtab.h (enum symbol_search): Update comment.
1419         (search_symbols): Remove declaration.
1420         (class global_symbol_searcher): New class.
1421
1422 2019-11-26  Tom Tromey  <tromey@adacore.com>
1423
1424         * cp-support.c (_initialize_cp_support): Conditionally initialize
1425         gdb_demangle_attempt_core_dump.
1426
1427 2019-11-26  Tom Tromey  <tom@tromey.com>
1428
1429         * python/py-function.c (fnpy_init): Update.
1430         * value.h (add_internal_function): Adjust declaration.
1431         * value.c (function_destroyer): Remove.
1432         (do_add_internal_function): Don't set destroyer or copy name.
1433         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1434         Set name_allocated.
1435         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1436         (cmdpy_init): Set name_allocated.
1437         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1438         member.
1439         (~cmd_list_element): Free "name" if needed.
1440
1441 2019-11-26  Tom Tromey  <tom@tromey.com>
1442
1443         * value.h (add_internal_function): Add new overload.  Move
1444         documentation from value.h.
1445         * value.c (do_add_internal_function): New function.
1446         (add_internal_function): Use it.  Add new overload.
1447         (function_destroyer): Don't free doc.
1448         * python/py-function.c (fnpy_init): Update.
1449
1450 2019-11-26  Tom Tromey  <tom@tromey.com>
1451
1452         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1453         (cmdpy_init): Set "doc_allocated".
1454
1455 2019-11-26  Tom Tromey  <tom@tromey.com>
1456
1457         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1458         name of worker thread.
1459         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1460         pthread_setname_np.
1461         * configure, config.in: Rebuild.
1462
1463 2019-11-26  Tom Tromey  <tom@tromey.com>
1464
1465         * python/python.c (class gdbpy_gil): New.
1466         (struct gdbpy_event): Add constructor, destructor, operator().
1467         (gdbpy_post_event): Use run_on_main_thread.
1468         (gdbpy_initialize_events): Remove.
1469         (do_start_initialization): Update.
1470
1471 2019-11-26  Tom Tromey  <tom@tromey.com>
1472
1473         * NEWS: Add entry.
1474         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1475         commands.  Call update_thread_pool_size.
1476         (update_thread_pool_size, maintenance_set_worker_threads): New
1477         functions.
1478         (n_worker_threads): New global.
1479
1480 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1481             Tom Tromey  <tom@tromey.com>
1482
1483         * minsyms.c (minimal_symbol_reader::install): Use
1484         parallel_for_each.
1485         * gdbsupport/parallel-for.h: New file.
1486         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1487
1488 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1489             Tom Tromey  <tom@tromey.com>
1490
1491         * gdbsupport/thread-pool.h: New file.
1492         * gdbsupport/thread-pool.c: New file.
1493         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1494         (HFILES_NO_SRCDIR): Add thread-pool.h.
1495
1496 2019-11-26  Tom Tromey  <tom@tromey.com>
1497
1498         * event-top.h (thread_local_segv_handler): Declare.
1499         * event-top.c (thread_local_segv_handler): New global.
1500         (install_handle_sigsegv, handle_sigsegv): New functions.
1501         (async_init_signals): Install SIGSEGV handler.
1502         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1503         thread-local.
1504         (report_failed_demangle): New function.
1505         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1506         handler-setting code, instead use segv_handler.  Run warning code
1507         on main thread.
1508
1509 2019-11-26  Tom Tromey  <tom@tromey.com>
1510
1511         * run-on-main-thread.c: New file.
1512         * run-on-main-thread.h: New file.
1513         * unittests/main-thread-selftests.c: New file.
1514         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1515         main-thread-selftests.c.
1516         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1517         (COMMON_SFILES): Add run-on-main-thread.c.
1518
1519 2019-11-26  Tom Tromey  <tom@tromey.com>
1520
1521         * main.c (setup_alternate_signal_stack): Remove.
1522         (captured_main_1): Use gdb::alternate_signal_stack.
1523         * gdbsupport/alt-stack.h: New file.
1524
1525 2019-11-26  Tom Tromey  <tom@tromey.com>
1526
1527         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1528         Remove comment.
1529         (save_original_signals_state, restore_original_signals_state): Use
1530         gdb_sigmask.
1531         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1532         (_initialize_linux_nat): Use gdb_sigmask.
1533         * guile/guile.c (_initialize_guile): Use block_signals.
1534         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1535         * gdbsupport/gdb-sigmask.h: New file.
1536         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1537         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1538         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1539         pthread_sigmask.
1540         * configure, config.in: Rebuild.
1541         * gdbsupport/block-signals.h: New file.
1542
1543 2019-11-26  Tom Tromey  <tom@tromey.com>
1544
1545         * acinclude.m4: Include ax_pthread.m4.
1546         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1547         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1548         (CLIBS): Use PTHREAD_LIBS.
1549         (aclocal_m4_deps): Add ax_pthread.m4.
1550         * config.in, configure: Rebuild.
1551         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1552
1553 2019-11-26  Tom Tromey  <tom@tromey.com>
1554
1555         * symtab.h (struct minimal_symbol) <name_set>: New member.
1556         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1557         Don't call symbol_set_names.
1558         (minimal_symbol_reader::install): Call symbol_set_names.
1559
1560 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1561
1562         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1563         restore_active_ext_lang, as GIL is needed for (indirectly)
1564         called PyOS_InterruptOccurred.
1565
1566 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1567
1568         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1569         definition.
1570
1571 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1572
1573         * remote-sim.c (simulator_command): Make static, remove
1574         declaration.
1575
1576 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1577
1578         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1579         static.
1580         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1581         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1582         (main): Likewise.
1583         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1584         (main): Likewise.
1585         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1586         (main): Likewise.
1587         * unittests/basic_string_view/element_access/char/1.cc (test01):
1588         Likewise.
1589         (main): Likewise.
1590         * unittests/basic_string_view/element_access/char/empty.cc (main):
1591         Likewise.
1592         * unittests/basic_string_view/element_access/char/front_back.cc
1593         (test01): Likewise.
1594         (main): Likewise.
1595         * unittests/basic_string_view/inserters/char/2.cc (test05):
1596         Likewise.
1597         (main): Likewise.
1598         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1599         (test01): Likewise.
1600         (main): Likewise.
1601         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1602         (test01): Likewise.
1603         (main): Likewise.
1604         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1605         Likewise.
1606         * unittests/basic_string_view/operations/compare/char/1.cc
1607         (test01): Likewise.
1608         (main): Likewise.
1609         * unittests/basic_string_view/operations/compare/char/13650.cc
1610         (test01): Likewise.
1611         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1612         Likewise.
1613         (main): Likewise.
1614         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1615         Likewise.
1616         (main): Likewise.
1617         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1618         Likewise.
1619         (main): Likewise.
1620         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1621         Likewise.
1622         (main): Likewise.
1623         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1624         Likewise.
1625         (main): Likewise.
1626         * unittests/basic_string_view/operations/find/char/4.cc (main):
1627         Likewise.
1628         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1629         Likewise.
1630         (main): Likewise.
1631         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1632         Likewise.
1633         (main): Likewise.
1634         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1635         Likewise.
1636         (main): Likewise.
1637         * unittests/basic_string_view/operations/substr/char/1.cc
1638         (test01): Likewise.
1639         (main): Likewise.
1640         * unittests/basic_string_view/operators/char/2.cc (main):
1641         Likewise.
1642         * unittests/optional/assignment/1.cc (test): Likewise.
1643         * unittests/optional/assignment/2.cc (test): Likewise.
1644         * unittests/optional/assignment/3.cc (test): Likewise.
1645         * unittests/optional/assignment/4.cc (test): Likewise.
1646         * unittests/optional/assignment/5.cc (test): Likewise.
1647         * unittests/optional/assignment/6.cc (test): Likewise.
1648         * unittests/optional/assignment/7.cc (test): Likewise.
1649         * unittests/optional/cons/copy.cc (test): Likewise.
1650         * unittests/optional/cons/default.cc (test): Likewise.
1651         * unittests/optional/cons/move.cc (test): Likewise.
1652         * unittests/optional/cons/value.cc (test): Likewise.
1653         * unittests/optional/in_place.cc (test): Likewise.
1654         * unittests/optional/observers/1.cc (test): Likewise.
1655         * unittests/optional/observers/2.cc (test): Likewise.
1656
1657 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1658
1659         * tui-win.h (tui_set_var_cmd): Remove.
1660         * tui-win.c (tui_set_var_cmd): Make static.
1661
1662 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1663
1664         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1665         rbreak_command_wrapper): Remove.
1666         * symtab.c (rbreak_command_wrapper): Remove.
1667
1668 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1669
1670         * inferior.h (info_terminal_command): Remove declaration.
1671         * inflow.c (info_terminal_command): Make static.
1672
1673 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1674
1675         * inferior.c (exit_inferior_silent): Remove.
1676
1677 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1678
1679         * dictionary.c (dict_empty, mdict_empty): Remove.
1680         * dictionary.c (mdict_empty): Remove.
1681
1682 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1683
1684          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1685          (arc_insn_get_memory_offset): Likewise.
1686          (arc_insn_dump): Likewise.
1687          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1688          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1689          * dictionary.c (dict_iterator_next): Likewise.
1690          (dict_iter_match_first): Likewise.
1691          (dict_iter_match_next): Likewise.
1692          * f-lang.c (evaluate_subexp_f): Likewise.
1693          * hppa-tdep.c (hppa_read_pc): Likewise.
1694          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1695          * parse.c (write_exp_elt_msym): Likewise.
1696          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1697          * remote.c (remote_packet_size): Likewise.
1698          (remote_notif_stop_parse): Likewise.
1699          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1700          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1701          * source.c (prepare_path_for_appending): Likewise.
1702          * sparc64-linux-tdep.c
1703          (sparc64_linux_handle_segmentation_fault); Likewise.
1704          * stack.c (frame_selection_by_function_completer): Likewise.
1705
1706 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1707
1708         * completer.c (set_gdb_completion_word_break_characters):
1709         Remove.
1710
1711 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1712
1713         * dwarf-index-write.c: Include dwarf-index-write.h.
1714         * mi/mi-interp.c: Include mi/mi-interp.h.
1715
1716 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1717
1718         * aarch32-tdep.c: Include aarch32-tdep.h.
1719         * aarch32-tdep.h: Forward-declare struct target_desc.
1720
1721 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1722
1723         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1724         strerror.
1725         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1726         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1727
1728 2019-11-25  Tom de Vries  <tdevries@suse.de>
1729
1730         * contrib/words.sh: Add -c option.
1731
1732 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1733
1734         * solib.c (solib_find_1): Change int to bool.
1735         (exec_file_find): Change int to bool.
1736         (solib_find): Change int to bool.
1737         (solib_read_symbols): Change int to bool.
1738         (solib_used): Change int to bool.
1739         (solib_add): Change int to bool.
1740         (info_sharedlibrary_command): Change int to bool.
1741         (solib_contains_address_p): Change int to bool.
1742         (solib_keep_data_in_core): Change int to bool.
1743         (in_solib_dynsym_resolve_code): Change int to bool.
1744         (reload_shared_libraries_1): Change int to bool.
1745         (gdb_sysroot_changed): Change int to bool.
1746         * solib.h (solib_read_symbols): Change int to bool.
1747         (solib_contains_address_p): Change int to bool.
1748         (solib_keep_data_in_core): Change int to bool.
1749         (in_solib_dynsym_resolve_code): Change int to bool.
1750         (libpthread_name_p): Change int to bool.
1751
1752 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1753
1754         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1755         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1756         (remote_packet_max_chars): New static global.
1757         (show_remote_packet_max_chars): New function.
1758         (remote_target::putpkt_binary): Adjust to use new
1759         remote_packet_max_chars option.
1760         (remote_target::getpkt_or_notif_sane_1): Likewise.
1761         (_initialize_remote): Register new remote-packet-max-chars option.
1762
1763 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1764
1765         * m68k-linux-nat.c: Include gdbarch.h.
1766
1767 2019-11-24  Tom Tromey  <tom@tromey.com>
1768
1769         * symfile.c (read_symbols): Update.
1770         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1771         bool.
1772         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1773         (psym_lookup_symbol, psym_find_last_source_symtab)
1774         (psym_forget_cached_source_info, psym_print_stats)
1775         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1776         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1777         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1778         (psym_find_compunit_symtab_by_address)
1779         (maintenance_print_psymbols, maintenance_info_psymtabs)
1780         (maintenance_check_psymtabs): Update.
1781         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1782         bool.
1783
1784 2019-11-22  Tom Tromey  <tom@tromey.com>
1785
1786         * observable.h: Update comments.
1787
1788 2019-11-22  Tom Tromey  <tromey@adacore.com>
1789
1790         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1791         (print_ada_task_info): Don't try to fetch thread id if task is not
1792         alive.
1793
1794 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1795
1796         * ada-exp.y: Update.
1797         * ada-lang.c (sort_choices): Update.
1798         (ada_print_symbol_signature): Update.
1799         (resolve_subexp): Update.
1800         (ada_parse_renaming): Update.
1801         (ada_read_renaming_var_value): Update.
1802         (lesseq_defined_than): Update.
1803         (remove_extra_symbols): Update.
1804         (remove_irrelevant_renamings): Update.
1805         (ada_add_block_symbols): Update.
1806         (ada_collect_symbol_completion_matches): Update.
1807         (ada_is_renaming_symbol): Update.
1808         (aggregate_assign_from_choices): Update.
1809         (ada_evaluate_subexp): Update.
1810         (ada_has_this_exception_support): Update.
1811         (ada_is_non_standard_exception_sym): Update.
1812         (ada_add_exceptions_from_frame): Update.
1813         (ada_add_global_exceptions): Update.
1814         (ada_print_subexp): Update.
1815         * ax-gdb.c (gen_var_ref): Update.
1816         (gen_maybe_namespace_elt): Update.
1817         (gen_expr_for_cast): Update.
1818         (gen_expr): Update.
1819         * block.h: Update.
1820         * blockframe.c (find_pc_partial_function): Update.
1821         * breakpoint.c (print_breakpoint_location): Update.
1822         (update_static_tracepoint): Update.
1823         * btrace.c (ftrace_print_function_name): Update.
1824         (ftrace_function_switched): Update.
1825         * buildsym.c (find_symbol_in_list): Update.
1826         * c-exp.y: Update.
1827         * c-typeprint.c (c_print_typedef): Update.
1828         (c_type_print_template_args): Update.
1829         * cli/cli-cmds.c (edit_command): Update.
1830         (list_command): Update.
1831         (print_sal_location): Update.
1832         * coffread.c (patch_opaque_types): Update.
1833         (process_coff_symbol): Update.
1834         (coff_read_enum_type): Update.
1835         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1836         (convert_one_symbol): Update.
1837         (hash_symname): Update.
1838         (eq_symname): Update.
1839         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1840         * compile/compile-cplus-types.c (debug_print_scope): Update.
1841         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1842         * compile/compile-object-load.c (get_out_value_type): Update.
1843         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1844         (search_symbol_list): Update.
1845         (cp_lookup_symbol_imports_or_template): Update.
1846         * cp-support.c (overload_list_add_symbol): Update.
1847         * ctfread.c (psymtab_to_symtab): Update.
1848         * dbxread.c (cp_set_block_scope): Update.
1849         * dictionary.c (iter_match_first_hashed): Update.
1850         (iter_match_next_hashed): Update.
1851         (insert_symbol_hashed): Update.
1852         (iter_match_next_linear): Update.
1853         * dictionary.h: Update.
1854         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1855         (locexpr_describe_location_piece): Update.
1856         (locexpr_describe_location_1): Update.
1857         (locexpr_generate_c_location): Update.
1858         (loclist_describe_location): Update.
1859         (loclist_generate_c_location): Update.
1860         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1861         (read_func_scope): Update.
1862         (process_enumeration_scope): Update.
1863         (new_symbol): Update.
1864         (dwarf2_const_value): Update.
1865         (dwarf2_symbol_mark_computed): Update.
1866         * eval.c (evaluate_funcall): Update.
1867         (evaluate_subexp_standard): Update.
1868         * expprint.c (print_subexp_standard): Update.
1869         (dump_subexp_body_standard): Update.
1870         * f-valprint.c (info_common_command_for_block): Update.
1871         * findvar.c (get_hosting_frame): Update.
1872         (default_read_var_value): Update.
1873         * go-lang.c (go_symbol_package_name): Update.
1874         * guile/scm-block.c (bkscm_print_block_smob): Update.
1875         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1876         (gdbscm_symbol_name): Update.
1877         (gdbscm_symbol_linkage_name): Update.
1878         (gdbscm_symbol_print_name): Update.
1879         * infcall.c (get_function_name): Update.
1880         * infcmd.c (jump_command): Update.
1881         (finish_command): Update.
1882         * infrun.c (insert_exception_resume_breakpoint): Update.
1883         * linespec.c (canonicalize_linespec): Update.
1884         (create_sals_line_offset): Update.
1885         (convert_linespec_to_sals): Update.
1886         (complete_label): Update.
1887         (find_label_symbols_in_block): Update.
1888         * m2-typeprint.c (m2_print_typedef): Update.
1889         * mdebugread.c (mdebug_reg_to_regnum): Update.
1890         (parse_symbol): Update.
1891         (mylookup_symbol): Update.
1892         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1893         (list_args_or_locals): Update.
1894         * objc-lang.c (compare_selectors): Update.
1895         (info_selectors_command): Update.
1896         (compare_classes): Update.
1897         (info_classes_command): Update.
1898         (find_imps): Update.
1899         * p-typeprint.c (pascal_print_typedef): Update.
1900         * printcmd.c (build_address_symbolic): Update.
1901         (info_address_command): Update.
1902         (print_variable_and_value): Update.
1903         * python/py-framefilter.c (extract_sym): Update.
1904         (py_print_single_arg): Update.
1905         * python/py-symbol.c (sympy_str): Update.
1906         (sympy_get_name): Update.
1907         (sympy_get_linkage_name): Update.
1908         * python/python.c (gdbpy_rbreak): Update.
1909         * record-btrace.c (btrace_get_bfun_name): Update.
1910         (btrace_call_history): Update.
1911         * rust-lang.c (rust_print_typedef): Update.
1912         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1913         * stabsread.c (stab_reg_to_regnum): Update.
1914         (define_symbol): Update.
1915         (read_enum_type): Update.
1916         (common_block_end): Update.
1917         (cleanup_undefined_types_1): Update.
1918         (scan_file_globals): Update.
1919         * stack.c (print_frame_arg): Update.
1920         (print_frame_args): Update.
1921         (find_frame_funname): Update.
1922         (info_frame_command_core): Update.
1923         (iterate_over_block_locals): Update.
1924         (print_block_frame_labels): Update.
1925         (do_print_variable_and_value): Update.
1926         (iterate_over_block_arg_vars): Update.
1927         (return_command): Update.
1928         * symmisc.c (dump_symtab_1): Update.
1929         (print_symbol): Update.
1930         * symtab.c (eq_symbol_entry): Update.
1931         (symbol_cache_dump): Update.
1932         (lookup_language_this): Update.
1933         (find_pc_sect_line): Update.
1934         (skip_prologue_sal): Update.
1935         (symbol_search::compare_search_syms): Update.
1936         (treg_matches_sym_type_name): Update.
1937         (search_symbols): Update.
1938         (print_symbol_info): Update.
1939         (rbreak_command): Update.
1940         (completion_list_add_symbol): Update.
1941         (find_gnu_ifunc): Update.
1942         (get_symbol_address): Update.
1943         (search_module_symbols): Update.
1944         (info_module_subcommand): Update.
1945         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1946         (SYMBOL_LINKAGE_NAME): Remove.
1947         (SYMBOL_DEMANGLED_NAME): Remove.
1948         (SYMBOL_PRINT_NAME): Remove.
1949         (SYMBOL_SEARCH_NAME): Remove.
1950         * tracepoint.c (set_traceframe_context): Update.
1951         (validate_actionline): Update.
1952         (collection_list::collect_symbol): Update.
1953         (encode_actions_1): Update.
1954         (info_scope_command): Update.
1955         (print_one_static_tracepoint_marker): Update.
1956         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1957         * valops.c (address_of_variable): Update.
1958         (find_overload_match): Update.
1959         (find_oload_champ): Update.
1960
1961 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1962
1963         * ada-lang.c (ada_lookup_simple_minsym): Update.
1964         (ada_collect_symbol_completion_matches): Update.
1965         * ada-tasks.c (read_atcb): Update.
1966         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1967         (amd64_windows_skip_trampoline_code): Update.
1968         * arm-tdep.c (skip_prologue_function): Update.
1969         (arm_skip_stack_protector): Update.
1970         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1971         (arm_wince_skip_main_prologue): Update.
1972         * ax-gdb.c (gen_expr): Update.
1973         * block.c (call_site_for_pc): Update.
1974         * blockframe.c (find_pc_partial_function): Update.
1975         * breakpoint.c (set_breakpoint_location_function): Update.
1976         * btrace.c (ftrace_print_function_name): Update.
1977         (ftrace_function_switched): Update.
1978         * c-valprint.c (print_unpacked_pointer): Update.
1979         * coffread.c (coff_symfile_read): Update.
1980         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1981         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1982         * dwarf-index-write.c (write_psymbols): Update.
1983         * dwarf2loc.c (call_site_to_target_addr): Update.
1984         (func_verify_no_selftailcall): Update.
1985         (tailcall_dump): Update.
1986         (call_site_find_chain_1): Update.
1987         (dwarf_expr_reg_to_entry_parameter): Update.
1988         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1989         * eval.c (evaluate_funcall): Update.
1990         (evaluate_subexp_standard): Update.
1991         (evaluate_subexp_for_sizeof): Update.
1992         * expprint.c (print_subexp_standard): Update.
1993         (dump_subexp_body_standard): Update.
1994         * frame.c (get_prev_frame_always_1): Update.
1995         * frv-tdep.c (frv_skip_main_prologue): Update.
1996         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1997         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1998         (gnuv3_get_typename_from_type_info): Update.
1999         (gnuv3_skip_trampoline): Update.
2000         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2001         * i386-tdep.c (i386_skip_main_prologue): Update.
2002         (i386_pe_skip_trampoline_code): Update.
2003         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2004         * infcall.c (get_function_name): Update.
2005         * linespec.c (minsym_found): Update.
2006         * linux-fork.c (info_checkpoints_command): Update.
2007         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2008         (m32c_m16c_pointer_to_address): Update.
2009         * maint.c (maintenance_translate_address): Update.
2010         * minsyms.c (add_minsym_to_hash_table): Update.
2011         (add_minsym_to_demangled_hash_table): Update.
2012         (lookup_minimal_symbol_mangled): Update.
2013         (lookup_minimal_symbol_demangled): Update.
2014         (lookup_minimal_symbol_linkage): Update.
2015         (lookup_minimal_symbol_text): Update.
2016         (lookup_minimal_symbol_by_pc_name): Update.
2017         (minimal_symbol_is_less_than): Update.
2018         (compact_minimal_symbols): Update.
2019         (build_minimal_symbol_hash_tables): Update.
2020         (find_solib_trampoline_target): Update.
2021         * mips-tdep.c (mips_stub_frame_sniffer): Update.
2022         (mips_skip_pic_trampoline_code): Update.
2023         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2024         * objc-lang.c (info_selectors_command): Update.
2025         (info_classes_command): Update.
2026         (find_methods): Update.
2027         (find_imps): Update.
2028         * p-valprint.c (pascal_val_print): Update.
2029         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2030         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2031         * printcmd.c (build_address_symbolic): Update.
2032         (info_symbol_command): Update.
2033         * psymtab.c (psymbol_name_matches): Update.
2034         (match_partial_symbol): Update.
2035         (lookup_partial_symbol): Update.
2036         (print_partial_symbols): Update.
2037         (sort_pst_symbols): Update.
2038         (maintenance_check_psymtabs): Update.
2039         * python/py-framefilter.c (py_print_frame): Update.
2040         * python/python.c (gdbpy_rbreak): Update.
2041         * record-btrace.c (btrace_get_bfun_name): Update.
2042         (btrace_call_history): Update.
2043         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2044         (rs6000_skip_trampoline_code): Update.
2045         * sol-thread.c (info_cb): Update.
2046         * stabsread.c (scan_file_globals): Update.
2047         * stack.c (find_frame_funname): Update.
2048         (info_frame_command_core): Update.
2049         * symmisc.c (dump_msymbols): Update.
2050         * symtab.c (symbol_natural_name): Rename to..,
2051         (general_symbol_info::natural_name): ...this.
2052         (symbol_demangled_name): Rename to...
2053         (general_symbol_info::demangled_name): ...this.
2054         (symbol_search_name): Rename to...
2055         (general_symbol_info::search_name): ...this.
2056         (symbol_matches_search_name): Update.
2057         (find_pc_sect_line): Update.
2058         (skip_prologue_sal): Update.
2059         (search_symbols): Update.
2060         (print_msymbol_info): Update.
2061         (rbreak_command): Update.
2062         (completion_list_add_msymbol): Update.
2063         (completion_list_objc_symbol): Update.
2064         (get_msymbol_address): Update.
2065         * symtab.h (struct general_symbol_info): Add member functions
2066         natural_name (), linkage_name (), print_name (), demangled_name (),
2067         and search_name ().
2068         (SYMBOL_NATURAL_NAME): Update.
2069         (symbol_natural_name): Move to a member function on general_symbol_info.
2070         (SYMBOL_DEMANGLED_NAME): Update.
2071         (symbol_demangled_name): Move to a member function on
2072         general_symbol_info.
2073         (SYMBOL_SEARCH_NAME): Update.
2074         (symbol_search_name): Move to a member function on general_symbol_info.
2075         (MSYMBOL_NATURAL_NAME): Remove.
2076         (MSYMBOL_LINKAGE_NAME): Remove.
2077         (MSYMBOL_PRINT_NAME): Remove.
2078         (MSYMBOL_DEMANGLED_NAME): Remove.
2079         (MSYMBOL_SEARCH_NAME): Remove.
2080         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2081
2082 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2083
2084         * symtab.c (create_demangled_names_hash): Use per_bfd->
2085         minimal_symbol_count for computing the initial size, if greater
2086         than our default size.
2087
2088 2019-11-22  Tom de Vries  <tdevries@suse.de>
2089
2090         * contrib/words.sh: Improve words extraction.
2091
2092 2019-11-22  Tom de Vries  <tdevries@suse.de>
2093
2094         * contrib/words.sh: Combine sed invocations.
2095
2096 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2097
2098         * Makefile.in: Update.
2099         * demangle.c: Rename to...
2100         * gdb-demangle.c: ..this.
2101         (is_cplus_marker): Change return type to bool.
2102         (_initialize_demangler): Rename to...
2103         (_initialize_gdb_demangle): ...this.
2104         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2105         * symtab.h (demangle): Remove declaration; instead include
2106         gdb-demangle.h.
2107
2108 2019-11-21  Tom Tromey  <tromey@adacore.com>
2109
2110         * gdbsupport/format.c (format_pieces): Parse %I64d.
2111         * unittests/format_pieces-selftests.c (test_windows_formats): New
2112         function.
2113         (run_tests): Call it.
2114
2115 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2116
2117         Byte reverse display of variables with DW_END_big, DW_END_little
2118         (DW_AT_endianity) dwarf attributes if different than the native
2119         byte order.
2120         * ada-lang.c (ada_value_binop):
2121         Use type_byte_order instead of gdbarch_byte_order.
2122         * ada-valprint.c (printstr):
2123         (ada_val_print_string):
2124         * ada-lang.c (value_pointer):
2125         (ada_value_binop):
2126         Use type_byte_order instead of gdbarch_byte_order.
2127         * c-lang.c (c_get_string):
2128         Use type_byte_order instead of gdbarch_byte_order.
2129         * c-valprint.c (c_val_print_array):
2130         Use type_byte_order instead of gdbarch_byte_order.
2131         * cp-valprint.c (cp_print_class_member):
2132         Use type_byte_order instead of gdbarch_byte_order.
2133         * dwarf2loc.c (rw_pieced_value):
2134         Use type_byte_order instead of gdbarch_byte_order.
2135         * dwarf2read.c (read_base_type): Handle DW_END_big,
2136         DW_END_little
2137         * f-lang.c (f_get_encoding):
2138         Use type_byte_order instead of gdbarch_byte_order.
2139         * findvar.c (default_read_var_value):
2140         Use type_byte_order instead of gdbarch_byte_order.
2141         * gdbtypes.c (check_types_equal):
2142         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2143         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2144         and TYPE_ENDIANITY_LITTLE if set.
2145         (type_byte_order): new function.
2146         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2147         (struct main_type) <flag_endianity_not_default>:
2148         New field.
2149         (type_byte_order): New function.
2150         * infcmd.c (default_print_one_register_info):
2151         Use type_byte_order instead of gdbarch_byte_order.
2152         * p-lang.c (pascal_printstr):
2153         Use type_byte_order instead of gdbarch_byte_order.
2154         * p-valprint.c (pascal_val_print):
2155         Use type_byte_order instead of gdbarch_byte_order.
2156         * printcmd.c (print_scalar_formatted):
2157         Use type_byte_order instead of gdbarch_byte_order.
2158         * solib-darwin.c (darwin_current_sos):
2159         Use type_byte_order instead of gdbarch_byte_order.
2160         * solib-svr4.c (solib_svr4_r_ldsomap):
2161         Use type_byte_order instead of gdbarch_byte_order.
2162         * stap-probe.c (stap_modify_semaphore):
2163         Use type_byte_order instead of gdbarch_byte_order.
2164         * target-float.c (target_float_same_format_p):
2165         Use type_byte_order instead of gdbarch_byte_order.
2166         * valarith.c (scalar_binop):
2167         (value_bit_index):
2168         Use type_byte_order instead of gdbarch_byte_order.
2169         * valops.c (value_cast):
2170         Use type_byte_order instead of gdbarch_byte_order.
2171         * valprint.c (generic_emit_char):
2172         (generic_printstr):
2173         (val_print_string):
2174         Use type_byte_order instead of gdbarch_byte_order.
2175         * value.c (unpack_long):
2176         (unpack_bits_as_long):
2177         (unpack_value_bitfield):
2178         (modify_field):
2179         (pack_long):
2180         (pack_unsigned_long):
2181         Use type_byte_order instead of gdbarch_byte_order.
2182         * findvar.c (unsigned_pointer_to_address):
2183         (signed_pointer_to_address):
2184         (unsigned_address_to_pointer):
2185         (address_to_signed_pointer):
2186         (default_read_var_value):
2187         (default_value_from_register):
2188         Use type_byte_order instead of gdbarch_byte_order.
2189         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2190         Use type_byte_order instead of gdbarch_byte_order.
2191         * riscv-tdep.c (riscv_print_one_register_info):
2192         Use type_byte_order instead of gdbarch_byte_order.
2193
2194 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2195
2196         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2197         (current_ui_gdb_stdin_ptr): Likewise.
2198         (current_ui_gdb_stderr_ptr): Likewise.
2199         (current_ui_gdb_stdlog_ptr): Likewise.
2200         (current_ui_current_uiout_ptr): Likewise.
2201         (gen_ret_current_ui_field_ptr): Remove.
2202
2203 2019-11-21  Tom de Vries  <tdevries@suse.de>
2204
2205         PR gdb/24956
2206         * cli/cli-script.c (execute_control_command): Only switch to
2207         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2208
2209 2019-11-19  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2212         Now static.  Change type of "name".
2213         (tui_set_win_height_command): Don't copy "arg".
2214         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2215         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2216
2217 2019-11-19  Ali Tamur <tamur@google.com>
2218
2219         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2220         "if (attr != nullptr)".
2221         (dwarf2_find_base_address): Likewise.
2222         (dwarf2_build_include_psymtabs): Likewise.
2223         (read_cutu_die_from_dwo): Likewise.
2224         (read_func_scope): Likewise.
2225         (read_call_site_scope): Likewise.
2226         (dwarf2_get_pc_bounds): Likewise.
2227         (dwarf2_record_block_ranges): Likewise.
2228         (dwarf2_add_field): Likewise.
2229         (dwarf2_add_member_fn): Likewise.
2230         (read_structure_type): Likewise.
2231         (read_enumeration_type): Likewise.
2232         (read_array_type): Likewise.
2233         (read_array_order): Likewise.
2234         (read_set_type): Likewise.
2235         (read_common_block): Likewise.
2236         (read_tag_reference_type): Likewise.
2237         (read_tag_string_type): Likewise.
2238         (read_subroutine_type): Likewise.
2239         (read_base_type): Likewise.
2240         (read_subrange_type): Likewise.
2241         (new_symbol): Likewise.
2242         (prepare_one_comp_unit): Likewise.
2243
2244 2019-11-19  Tom Tromey  <tromey@adacore.com>
2245
2246         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2247         result in error when DebugActiveProcess fails.
2248
2249 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2250             Pedro Alves  <palves@redhat.com>
2251
2252         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2253         * target.c (target_stack::push): Call 'unpush' if there's a
2254         target on top of the stack.
2255
2256 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2257
2258         * python/py-block.c (blpy_dealloc): Call tp_free.
2259         (blpy_block_syms_dealloc): Likewise.
2260         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2261         * python/py-inferior.c (infpy_dealloc): Likewise.
2262         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2263         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2264         * python/py-symbol.c (sympy_dealloc): Likewise.
2265         * python/py-symtab.c (stpy_dealloc): Likewise.
2266         * python/py-type.c (typy_iterator_dealloc): Likewise.
2267
2268 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2269
2270         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2271         constructor instead of using a class initializer.
2272
2273 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2274
2275         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2276         * configure: Regenerate.
2277         * configure.ac: Don't source common.host.
2278         * gdbsupport/common.host: Remove.
2279         * gdbsupport/mingw-strerror.c: Remove.
2280         * gdbsupport/posix-strerror.c: Rename to...
2281         * gdbsupport/safe-strerror.c: ...this.
2282
2283 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2284
2285         * maint.c (scoped_command_stats::print_time): Use localtime_r
2286         instead of localtime (provided through gnulib if necessary).
2287         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2288         of ctime.
2289
2290 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2291
2292         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2293         avoid compile errors.
2294
2295 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2296
2297         * config.in: Regenerate.
2298         * configure: Regenerate.
2299         * gdbsupport/common.m4: No longer check for strerror_r.
2300         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2301         POSIX version of strerror_r, now that gnulib provides it if
2302         necessary.
2303
2304 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2305
2306         * README (`configure' options): Update.
2307
2308 2019-11-14  Tom Tromey  <tromey@adacore.com>
2309
2310         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2311         expected type for the RHS if the LHS is a convenience variable.
2312
2313 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2314
2315         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2316         Provide explicit default and copy constructor.
2317
2318 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2319
2320         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2321         only call Py_INCREF (newbp) in the bppy_pending_object case.
2322
2323 2019-11-13  Tom Tromey  <tromey@adacore.com>
2324
2325         PR build/25182:
2326         * psympriv.h (partial_symbol): Remove static assert.
2327         * symtab.h (general_symbol_info, symbol): Remove static assert.
2328
2329 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2330
2331         * gdbsupport/format.c (format_pieces::format_pieces): Support
2332         printf 'z' size modifier.
2333         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2334         * printcmd.c (ui_printf):  Handle size_t_arg.
2335         * ui-out.c (ui_out::vmessage): Likewise.
2336         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2337         function.
2338         (run_tests): Call test_format_int_sizes.
2339
2340 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2341
2342         * ada-exp.y (write_ambiguous_var): Update.
2343         * buildsym.c (add_symbol_to_list): Update.
2344         * dwarf2read.c (read_variable): Update.
2345         (new_symbol): Update.
2346         * jit.c (finalize_symtab): Update.
2347         * language.c (language_alloc_type_symbol): Update.
2348         * symtab.c (fixup_symbol_section): Update.
2349         (initialize_objfile_symbol_1): Move code to...
2350         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2351         (allocate_symbol): Update.
2352         (allocate_template_symbol): Update.
2353         (get_symbol_address): Update.
2354         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2355         of having as a field, and add a constructor.
2356         (SYMBOL_VALUE): Update.
2357         (SYMBOL_VALUE_ADDRESS): Update.
2358         (SET_SYMBOL_VALUE_ADDRESS): Update.
2359         (SYMBOL_VALUE_BYTES): Update.
2360         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2361         (SYMBOL_BLOCK_VALUE): Update.
2362         (SYMBOL_VALUE_CHAIN): Update.
2363         (SYMBOL_LANGUAGE): Update.
2364         (SYMBOL_SECTION): Update.
2365         (SYMBOL_OBJ_SECTION): Update.
2366         (SYMBOL_SET_LANGUAGE): Update.
2367         (SYMBOL_SET_LINKAGE_NAME): Update.
2368         (SYMBOL_SET_NAMES): Update.
2369         (SYMBOL_NATURAL_NAME): Update.
2370         (SYMBOL_LINKAGE_NAME): Update.
2371         (SYMBOL_DEMANGLED_NAME): Update.
2372         (SYMBOL_SEARCH_NAME): Update.
2373         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2374         (struct symbol): Update.
2375         (struct template_symbol): Update.
2376         (struct rust_vtable_symbol): Update.
2377         * xcoffread.c (SYMBOL_DUP): Update.
2378
2379 2019-11-12  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-layout.c (show_layout): Set current_layout.
2382         (show_source_disasm_command, show_data)
2383         (show_source_or_disasm_and_command): Don't set current_layout.
2384
2385 2019-11-12  Tom Tromey  <tom@tromey.com>
2386
2387         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2388
2389 2019-11-12  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-win.c (resize_message): New global.
2392         (show_tui_resize_message): New function.
2393         (tui_async_resize_screen): Print message if requested.
2394         (_initialize_tui_win): Add tui-resize-message setting.
2395         * NEWS: Add entry for new commands.
2396
2397 2019-11-11  Tom Tromey  <tom@tromey.com>
2398
2399         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2400         functions.
2401
2402 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2403
2404         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2405
2406 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2407
2408         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2409         function.
2410         * python/python-internal.h (gdbpy_lookup_static_symbols):
2411         Declare new function.
2412         * python/python.c (python_GdbMethods): Add
2413         gdb.lookup_static_symbols method.
2414         * NEWS: Mention gdb.lookup_static_symbols.
2415
2416 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2417
2418         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2419         static block of current object file first.  Also fix typo in
2420         header comment.
2421
2422 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2423
2424         * stack.c (set_last_displayed_sal): Delete.
2425         (last_displayed_sal_valid): Delete.
2426         (last_displayed_pspace): Delete.
2427         (last_displayed_addr): Delete.
2428         (last_displayed_symtab): Delete.
2429         (last_displayed_line): Delete.
2430         (class last_displayed_symtab_info_type): New.
2431         (last_displayed_symtab_info): New static global variable.
2432         (print_frame_info): Call methods on last_displayed_symtab_info.
2433         (clear_last_displayed_sal): Update header comment, and make use of
2434         last_displayed_symtab_info.
2435         (last_displayed_sal_is_valid): Likewise.
2436         (get_last_displayed_pspace): Likewise.
2437         (get_last_displayed_addr): Likewise.
2438         (get_last_displayed_symtab): Likewise.
2439         (get_last_displayed_line): Likewise.
2440         (get_last_displayed_sal): Likewise.
2441         * stack.h (clear_last_displayed_sal): Update header comment.
2442         (last_displayed_sal_is_valid): Likewise.
2443         (get_last_displayed_pspace): Likewise.
2444         (get_last_displayed_addr): Likewise.
2445         (get_last_displayed_symtab): Likewise.
2446         (get_last_displayed_line): Likewise.
2447         (get_last_displayed_sal): Likewise.
2448
2449 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2450
2451         * stack.c (frame_show_address): Convert return type to bool.
2452         * stack.h (frame_show_address): Likewise, and update header
2453         comment.
2454
2455 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2456
2457         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2458         * unittests/vec-utils-selftests.c: New file.
2459         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2460
2461 2019-11-10  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2464         (tui_highlight_win): Likewise.
2465         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2466         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2467         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2468         Don't set can_highlight.
2469
2470 2019-11-10  Tom Tromey  <tom@tromey.com>
2471
2472         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2473         Remove unused declaration.
2474
2475 2019-11-08  Tom Tromey  <tromey@adacore.com>
2476
2477         * top.c (read_command_file): Update.
2478         (command_line_input): Make return type const.
2479         * python/py-gdb-readline.c: Update.
2480         * linespec.c (decode_line_2): Update.
2481         * defs.h (command_line_input): Make return type const.
2482         * cli/cli-script.c (read_next_line): Make return type const.
2483         * ada-lang.c (get_selections): Update.
2484
2485 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2486
2487         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2488         * mi/mi-main.c (output_cores): Likewise.
2489         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2490         (linux_xfer_osdata_modules): Likewise.
2491         * remote.c (register_remote_support_xml): Likewise.
2492         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2493         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2494
2495 2019-11-06  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-interp.c: Don't include readline.h.
2498         * tui/tui-hooks.c: Don't include readline.h.
2499         * symmisc.c: Include tilde.h, not readline.h.
2500         * symfile.c: Include tilde.h, not readline.h.
2501         * source.c: Include tilde.h, not readline.h.
2502         * solib.c: Include tilde.h, not readline.h.
2503         * psymtab.c: Include tilde.h, not readline.h.
2504         * exec.c: Include tilde.h, not readline.h.
2505         * corelow.c: Include tilde.h, not readline.h.
2506         * cli/cli-dump.c: Include tilde.h, not readline.h.
2507         * cli/cli-cmds.c: Don't include readline.h.
2508
2509 2019-11-05  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2512         (tui_disassemble): Set addr_size.
2513         (tui_disasm_window::set_contents): Use addr_size.
2514
2515 2019-11-05  Tom Tromey  <tom@tromey.com>
2516
2517         * rust-lang.c (rust_language_defn): Update.
2518         * python/py-value.c (valpy_string): Call c_get_string.
2519         * p-lang.c (pascal_language_defn): Update.
2520         * opencl-lang.c (opencl_language_defn): Update.
2521         * objc-lang.c (objc_language_defn): Update.
2522         * m2-lang.c (m2_language_defn): Update.
2523         * language.c (unknown_language_defn, auto_language_defn): Update.
2524         (default_get_string): Remove.
2525         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2526         * go-lang.c (go_language_defn): Update.
2527         * f-lang.c (f_language_defn): Update.
2528         * d-lang.c (d_language_defn): Update.
2529         * c-lang.c (c_language_defn, cplus_language_defn)
2530         (asm_language_defn, minimal_language_defn): Update.
2531         * ada-lang.c (ada_language_defn): Update.
2532         * language.h (struct language_defn) <la_get_string>: Remove.
2533         (LA_GET_STRING): Remove.
2534         (default_get_string): Don't declare.
2535
2536 2019-11-05  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-source.h (struct tui_source_window): Inline
2539         constructor.  Remove destructor.
2540         <style_changed, m_observable>: Move to superclass.
2541         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2542         (struct tui_source_window_base): Move private members to end.
2543         <style_changed, m_observable>: Move from tui_source_window.
2544         * tui/tui-winsource.c (tui_copy_source_line): Move from
2545         tui-source.c.  Rename from copy_source_line.  Add special handling
2546         for negative line number.
2547         (tui_source_window_base::style_changed): Move from
2548         tui_source_window.
2549         (tui_source_window_base): Register observer.
2550         (~tui_source_window_base): New.
2551         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2552         rename.
2553         (tui_source_window::set_contents): Use tui_copy_source_line.
2554         (tui_source_window::tui_source_window): Move to tui-source.h.
2555         (tui_source_window::~tui_source_window): Remove.
2556         (tui_source_window::style_changed): Move to superclass.
2557         * tui/tui-disasm.c (tui_disassemble): Create string file with
2558         styling, when possible.  Add "addr_size" parameter.
2559         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2560         Don't compute maximum size.
2561         (len_without_escapes): New function
2562
2563 2019-11-05  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2566         std::string.
2567         * tui/tui-winsource.c (tui_show_source_line): Update.
2568         * tui/tui-source.c (tui_source_window::set_contents): Update.
2569         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2570
2571 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2572
2573         * symtab.h (gdb_static_assert): Put && operator at the beginning
2574         of the line instead of the end.
2575
2576 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2577
2578         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2579         and sizeof (symbol).
2580         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2581
2582 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2583
2584         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2585         * configure.host: Mark *-*-solaris2.10* obsolete.
2586         * configure.tgt: Mark Solaris < 11 obsolete.
2587         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2588         Update target triplet.
2589
2590 2019-11-01  Tom Tromey  <tromey@adacore.com>
2591
2592         * utils.c (print_sys_errmsg): Simplify.
2593
2594 2019-11-01  Tom Tromey  <tromey@adacore.com>
2595
2596         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2597
2598 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2599
2600         * configure: Regenerate.
2601         * configure.ac: Remove check for strerror_r.
2602         * gdbsupport/common.m4: Check for strerror_r.
2603
2604 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2605
2606         PR gdb/25124
2607
2608         * arm-tdep.c (arm_per_objfile): Rename to ...
2609         (arm_per_bfd): ... this.
2610         (arm_objfile_data_key): Rename to ...
2611         (arm_bfd_data_key): ... this.
2612         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2613         data.
2614         (arm_record_special_symbol): Likewise.
2615
2616 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2617
2618         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2619         end.
2620         * c-typeprint.c (c_print_typedef): Likewise.
2621         * f-typeprint.c (f_print_typedef): Likewise.
2622         * m2-typeprint.c (m2_print_typedef): Likewise.
2623         * p-typeprint.c (pascal_print_typedef): Likewise.
2624         * rust-lang.c (rust_print_typedef): Likewise.
2625         * symtab.c (print_symbol_info): Print a newline after calling
2626         typedef_print.
2627
2628 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2629
2630         * symtab.c (info_module_cmdlist): New variable.
2631         (info_module_command): New function.
2632         (search_module_symbols): New function.
2633         (info_module_subcommand): New function.
2634         (struct info_modules_var_func_options): New struct.
2635         (info_modules_var_func_options_defs): New variable.
2636         (make_info_modules_var_func_options_def_group): New function.
2637         (info_module_functions_command): New function.
2638         (info_module_variables_command): New function.
2639         (info_module_var_func_command_completer): New function.
2640         (_initialize_symtab): Register new 'info module functions' and
2641         'info module variables' commands.
2642         * symtab.h (typedef symbol_search_in_module): New typedef.
2643         (search_module_symbols): Declare new function.
2644         * NEWS: Mention new commands.
2645
2646 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2647
2648         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2649         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2650         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2651         MODULES_DOMAIN.
2652         (scan_partial_symbols): Only create partial module symbols for non
2653         declarations.
2654         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2655         and MODULES_DOMAIN.
2656         * symtab.c (search_domain_name): Likewise.
2657         (search_symbols): Likewise.
2658         (print_symbol_info): Likewise.
2659         (symtab_symbol_info): Likewise.
2660         (info_modules_command): New function.
2661         (_initialize_symtab): Register 'info modules' command.
2662         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2663         * NEWS: Mention new 'info modules' command.
2664
2665 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2666
2667         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2668         and $_gdb_maint_setting_str.
2669
2670 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2671
2672         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2673         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2674         (str_value_from_setting, gdb_setting_str_internal_fn)
2675         (gdb_maint_setting_str_internal_fn): New functions.
2676         (_initialize_cli_cmds): Define the new convenience functions.
2677         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2678         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2679
2680 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2681
2682         * agent.c (set_can_use_agent): When the setting is turned on,
2683         look up agent symbols if we don't have them yet.
2684         (agent_new_objfile): Don't look up agent symbols when the agent
2685         setting is off.
2686
2687 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2688
2689         * config.in: Regenerate.
2690
2691 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2692
2693         * configure: Regenerate.
2694         * configure.ac: Check for strerror_r.
2695         * gdbsupport/common-utils.h (safe_strerror): Change return value
2696         to const char * and document that this function is now threadsafe.
2697         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2698         thread_local and call strerror_r, if available.
2699         * utils.c (perror_string): Update.
2700         (print_sys_errmsg): Update.
2701
2702 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2703
2704         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2705         objfile_key.
2706         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2707         objfile to fetch per-bfd data.
2708         (arm_find_exidx_entry): Likewise.
2709
2710 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2711
2712         * gdbsupport/agent.c (debug_agent): Change type to bool.
2713         (use_agent): Likewise.
2714         (all_agent_symbols_look_up): Likewise.
2715         (agent_loaded_p): Change return value to bool.
2716         (agent_look_up_symbols): Update.
2717         (agent_capability_check): Change return value to bool.
2718         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2719         (debug_agent): Change type to bool.
2720         (use_agent): Likewise.
2721         (agent_capability_check): Change return value to bool.
2722
2723 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2724
2725         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2726         (build_minimal_symbol_hash_tables): Code to clear the table moved
2727         to clear_minimal_symbol_hash_tables.
2728         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2729         when needed.
2730
2731 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2732
2733         * infcmd.c: Remove includes.
2734         * infrun.c: Remove includes.
2735
2736 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2737
2738         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2739         (grow_vect): Remove declaration.
2740         (ada_type_of_array): Remove declaration.
2741         (ada_update_initial_language): Remove declaration.
2742         (ada_fold_name): Remove declaration.
2743         (ada_fill_in_ada_prototype): Remove declaration.
2744         (user_select_syms): Remove declaration.
2745         (get_selections): Remove declaration.
2746         (ada_tag_type): Remove declaration.
2747         (ada_value_tag): Remove declaration.
2748         (ada_is_others_clause): Remove declaration.
2749         (ada_in_variant): Remove declaration.
2750         (ada_value_struct_elt): Remove declaration.
2751         (ada_attribute_name): Remove declaration.
2752         (ada_system_address_type): Remove declaration.
2753         * ada-lang.c (ada_watch_location_expression): Make static.
2754         (GROW_VECT): Move here from ada-lang.h.
2755         (grow_vect): Make static.
2756         (ada_update_initial_language): Make static.
2757         (ada_fold_name): Make static.
2758         (ada_type_of_array): Make static.
2759         (encoded_ordered_before): Move up.
2760         (sort_choices): Move up.
2761         (print_signatures): Move up.
2762         (ada_print_symbol_signature): Move up.
2763         (get_selections): Move up and make static.
2764         (user_select_syms): Move up and make static.
2765         (ada_value_struct_elt): Move up and make static.
2766         (ada_tag_type): Make static.
2767         (ada_value_tag): Make static.
2768         (ada_is_others_clause): Make static.
2769         (ada_in_variant): Make static.
2770         (ada_attribute_name): Make static.
2771
2772 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2773
2774         * ada-lang.c: Remove includes.
2775         * ada-typeprint.c: Remove includes.
2776         * ada-valprint.c: Remove includes.
2777
2778 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2779
2780         * addrmap.c: Add static assertions of type size, moved from
2781         _initialize_addrmap.
2782         (_initialize_addrmap): Remove.
2783
2784 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2785
2786         * coffread.c (record_minimal_symbol): Update.
2787         (process_coff_symbol): Update.
2788         * dbxread.c (read_dbx_symtab): Update.
2789         * dwarf2read.c (add_partial_symbol): Update.
2790         (fixup_go_packaging): Update.
2791         (load_partial_dies): Update.
2792         (new_symbol): Update.
2793         * elfread.c (record_minimal_symbol): Change signature to use
2794         gdb::string_view instead of name+len.
2795         (elf_symtab_read): Update.
2796         (elf_rel_plt_read): Update.
2797         * mdebugread.c (parse_partial_symbols): Update.
2798         (handle_psymbol_enumerators): Update.
2799         (new_symbol): Update.
2800         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2801         to use gdb::string_view instead of name+len.
2802         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2803         * psympriv.h (add_psymbol_to_list): Likewise.
2804         * psymtab.c (add_psymbol_to_bcache): Likewise.
2805         (add_psymbol_to_list): Likewise.
2806         * stabsread.c (define_symbol): Update.
2807         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2808         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2809         (symbol_set_names): Likewise.
2810         * xcoffread.c (scan_xcoff_symtab): Update.
2811
2812 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2813
2814         * symtab.h (symbol_set_names): Document that copy_name must be
2815         set to true for non-nullterminated strings.
2816         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2817         linkage_name if the entry was not found and we need to demangle.
2818
2819 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2820
2821         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2822         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2823         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2824         * gdbsupport/gdb_binary_search.h: New file.
2825
2826 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2827
2828         * NEWS: Mention new --with-system-gdbinit-dir option.
2829         * config.in: Regenerate.
2830         * configure: Regenerate.
2831         * configure.ac: Add new option --with-system-gdbinit-dir.
2832         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2833         for a ".gdb" suffix.
2834         * main.c (get_init_files): Change system_gdbinit argument to
2835         a vector and return the files in SYSTEM_GDBINIT_DIR in
2836         addition to SYSTEM_GDBINIT.
2837         (captured_main_1): Update.
2838         (print_gdb_help): Update.
2839         * top.c (print_gdb_configuration): Also print the value of
2840         SYSTEM_GDBINIT_DIR.
2841
2842 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2843
2844         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2845         that takes gdb::string_view arguments.
2846
2847 2019-10-26  Tom de Vries  <tdevries@suse.de>
2848
2849         * aarch64-linux-tdep.c: Fix typos in comments.
2850         * aarch64-tdep.c: Same.
2851         * ada-lang.c: Same.
2852         * amd64-nat.c: Same.
2853         * arc-tdep.c: Same.
2854         * arch/aarch64-insn.c: Same.
2855         * block.c: Same.
2856         * breakpoint.h: Same.
2857         * btrace.h: Same.
2858         * c-varobj.c: Same.
2859         * cli/cli-decode.c: Same.
2860         * cli/cli-script.c: Same.
2861         * cli/cli-utils.h: Same.
2862         * coff-pe-read.c: Same.
2863         * coffread.c: Same.
2864         * compile/compile-cplus-symbols.c: Same.
2865         * compile/compile-object-run.c: Same.
2866         * completer.c: Same.
2867         * corelow.c: Same.
2868         * cp-support.c: Same.
2869         * demangle.c: Same.
2870         * dwarf-index-write.c: Same.
2871         * dwarf2-frame.c: Same.
2872         * dwarf2-frame.h: Same.
2873         * eval.c: Same.
2874         * frame-base.h: Same.
2875         * frame.h: Same.
2876         * gdbcmd.h: Same.
2877         * gdbtypes.h: Same.
2878         * gnu-nat.c: Same.
2879         * guile/scm-objfile.c: Same.
2880         * i386-tdep.c: Same.
2881         * i386-tdep.h: Same.
2882         * infcall.c: Same.
2883         * infcall.h: Same.
2884         * linux-nat.c: Same.
2885         * m68k-tdep.c: Same.
2886         * macroexp.c: Same.
2887         * memattr.c: Same.
2888         * mi/mi-cmd-disas.c: Same.
2889         * mi/mi-getopt.h: Same.
2890         * mi/mi-main.c: Same.
2891         * minsyms.c: Same.
2892         * nat/aarch64-sve-linux-sigcontext.h: Same.
2893         * objfiles.h: Same.
2894         * ppc-linux-nat.c: Same.
2895         * ppc-linux-tdep.c: Same.
2896         * ppc-tdep.h: Same.
2897         * progspace.h: Same.
2898         * prologue-value.h: Same.
2899         * python/py-evtregistry.c: Same.
2900         * python/py-instruction.h: Same.
2901         * record-btrace.c: Same.
2902         * record-full.c: Same.
2903         * remote.c: Same.
2904         * rs6000-tdep.c: Same.
2905         * ser-tcp.c: Same.
2906         * sol-thread.c: Same.
2907         * sparc-sol2-tdep.c: Same.
2908         * sparc64-tdep.c: Same.
2909         * stabsread.c: Same.
2910         * symfile.c: Same.
2911         * symtab.h: Same.
2912         * target.c: Same.
2913         * tracepoint.c: Same.
2914         * tui/tui-data.h: Same.
2915         * tui/tui-io.c: Same.
2916         * tui/tui-win.c: Same.
2917         * tui/tui.c: Same.
2918         * unittests/rsp-low-selftests.c: Same.
2919         * user-regs.h: Same.
2920         * utils.c: Same.
2921         * utils.h: Same.
2922         * valarith.c: Same.
2923         * valops.c: Same.
2924         * valprint.c: Same.
2925         * valprint.h: Same.
2926         * value.c: Same.
2927         * value.h: Same.
2928         * varobj.c: Same.
2929         * x86-nat.h: Same.
2930         * xtensa-tdep.c: Same.
2931
2932 2019-10-25  Ali Tamur <tamur@google.com>
2933
2934         * charset.c (find_charset_names): Reflect API change.
2935
2936 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2937
2938         * symtab.c (struct demangled_name_entry): Change demangled name
2939         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2940         part of the struct anymore.
2941         (symbol_set_names): No longer obstack allocate + copy the demangled
2942         name, just store the allocated name from bfd.
2943
2944 2019-10-25  Tom Tromey  <tromey@adacore.com>
2945
2946         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2947         (bsearch_cie_cmp, add_cie): Remove.
2948         (find_cie): Reimplement.
2949         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2950         (dwarf2_build_frame_info): Update.
2951
2952 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2953
2954         PR gdb/25126
2955         * symfile.c (reread_symbols): Call forget_cached_source_info to
2956         clear the stale source cache.
2957
2958 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2959
2960         * configure: Regenerate.
2961         * configure.ac: Remove code that sets python_has_threads.
2962
2963 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2964
2965         * config.in: Regenerate.
2966         * configure: Regenerate.
2967         * configure.ac: Remove the code that uses sed to get the python
2968         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2969
2970 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2971
2972         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2973         error paths.
2974
2975 2019-10-23  Tom Tromey  <tom@tromey.com>
2976
2977         * arc-tdep.c: Remove ".." from include.
2978         * frv-tdep.c: Remove ".." from include.
2979         * lm32-tdep.c: Remove ".." from include.
2980         * microblaze-tdep.c: Remove ".." from include.
2981         * or1k-tdep.h: Remove ".." from include.
2982         * s12z-tdep.c: Remove ".." from include.
2983         * Makefile.in (OPCODES_CFLAGS): Add comment.
2984         (TOP_CFLAGS): New variable.
2985         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2986
2987 2019-10-23  Tom Tromey  <tom@tromey.com>
2988
2989         * Makefile.in (READLINE_DIR): Update.
2990
2991 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2992
2993         * infcall.c (call_function_by_hand_dummy): Fix the function
2994         comment.  And extract out a code section into...
2995         (reserve_stack_space): ...this new function.
2996
2997 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2998
2999         * infcall.c (value_arg_coerce): Remove an unused parameter.
3000         (call_function_by_hand_dummy): Update the call to
3001         'value_arg_coerce'.
3002
3003 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3004
3005         * infcall.c (call_function_by_hand_dummy): Refactor.
3006
3007 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3008
3009         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3010
3011 2019-10-23  Tom Tromey  <tom@tromey.com>
3012
3013         * configure: Rebuild.
3014         * configure.ac: Don't check for sigprocmask.
3015         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3016
3017 2019-10-23  Tom Tromey  <tom@tromey.com>
3018
3019         * configure: Rebuild.
3020         * acinclude.m4: Use m4_include, not sinclude.
3021
3022 2019-10-23  Tom de Vries  <tdevries@suse.de>
3023
3024         PR breakpoints/24687
3025         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3026
3027 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3028
3029         * symtab.c (struct demangled_name_entry) <language>: Change from
3030         bitfield to regular variable.
3031
3032 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3033
3034         * symtab.c (struct demangled_name_entry): Add a constructor.
3035         (free_demangled_name_entry): New function to call the destructor
3036         for demangled_name_entry.
3037         (create_demangled_names_hash): Pass free_demangled_name_entry to
3038         htab_create_alloc.
3039         (symbol_set_names): Call placement new for demangled_name_entry.
3040         * utils.c: No longer include xxhash.h here, now that fast_hash
3041         is inlined in the header.
3042         * utils.h: Instead, include it here.
3043
3044 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3045
3046         * Makefile.in: Link with libxxhash.
3047         * config.in: Regenerate.
3048         * configure: Regenerate.
3049         * configure.ac: Search for libxxhash.
3050         * utils.c (fast_hash): Use xxhash if present.
3051
3052 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3053
3054         * utils.h (fast_hash): New function.
3055         * symtab.c (hash_demangled_name_entry): Call new function
3056         fast_hash.
3057
3058 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
3059
3060         * symtab.c (struct demangled_name_entry): Change type of mangled
3061         to gdb::string_view. Also adds a constructor that takes the
3062         mangled name.
3063         (hash_demangled_name_entry): Update.
3064         (eq_demangled_name_entry): Update.
3065         (free_demangled_name_entry): New function to call the destructor
3066         now that this is not a POD anymore.
3067         (create_demangled_names_hash): Pass free_demangled_name_entry to
3068         htab_create_alloc.
3069         (symbol_set_names): Update.
3070
3071 2019-10-21  Ali Tamur  <tamu@google.com>
3072
3073         * dwarf2read.c (dir_index): Change type.
3074         (file_name_index): Likewise.
3075         (line_header::include_dir_at): Change comment and implementation on
3076         whether it is DWARF 5.
3077         (line_header::is_valid_file_index): New function.
3078         (line_header::file_name_at): Change comment and implementation on
3079         whether it is DWARF 5.
3080         (line_header::file_names): Change to private field renamed as
3081         m_file_names and introduce a new accessor method.
3082         (line_header::file_names_size): New method.
3083         (line_header::include_dirs): Change to private field and rename as
3084         m_include_dirs.
3085         (dw2_get_file_names_reader): Define local var at a smaller scope and
3086         reflect API change.
3087         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3088         (process_structure_scope): Likewise.
3089         (line_header::add_include_dir): Change message and reflect renaming.
3090         (line_header::add_file_name): Likewise.
3091         (read_formatted_entries): Handle DW_FORM_data16.
3092         (dwarf_decode_line_header): Fix line header length calculation.
3093         (psymtab_include_file_name): Change comment and API.
3094         (lnp_state_machine::m_file): Update comment and reflect type change.
3095         (lnp_state_machine::record_line): Reflect type change.
3096         (dwarf_decode_lines): Reflect API change.
3097         (file_file_name): Likewise.
3098         (file_full_name): Likewise.
3099
3100 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3103
3104 2019-10-21  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3107
3108 2019-10-21  Tom Tromey  <tom@tromey.com>
3109
3110         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3111         NM_H.   Use AC_CONFIG_LINKS.
3112         * configure: Rebuild.
3113         * Makefile.in (NM_H): New variable.
3114         (generated_files): Add NM_H.  Remove gcore.
3115         (nm.h, stamp-nmh): New targets.
3116
3117 2019-10-20  Tom Tromey  <tom@tromey.com>
3118
3119         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3120         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3121         obsolete comment.
3122         (put_objfile_before): Now static.
3123
3124 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3125
3126         * gdbsupport/common-utils.h (startswith): Change return type to
3127         bool.
3128
3129 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3130
3131         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3132         * breakpoint.c (bp_locations_compare): Rename to...
3133         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3134         (update_global_location_list): Use std::sort instead of qsort.
3135         * buildsym.c (compare_line_numbers): Rename to...
3136         (lte_is_less_than): ...this, and change to std::sort semantics.
3137         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3138         instead of qsort.
3139         * disasm.c (compare_lines): Rename to...
3140         (line_is_less_than): ...this, and change to std::sort semantics.
3141         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3142         of qsort.
3143         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3144         (fde_is_less_than): ...this, and change to std::sort semantics.
3145         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3146         * mdebugread.c (compare_blocks):
3147         (block_is_less_than): ...this, and change to std::sort semantics.
3148         (sort_blocks): Call std::sort instead of qsort.
3149         * objfiles.c (qsort_cmp): Rename to...
3150         (sort_cmp): ...this, and change to std::sort semantics.
3151         (update_section_map): Call std::sort instead of qsort.
3152         * remote.c (compare_pnums): Remove.
3153         (map_regcache_remote_table): Call std::sort instead of qsort.
3154         * utils.c (compare_positive_ints): Remove.
3155         * utils.h (compare_positive_ints): Remove.
3156         * xcoffread.c (compare_lte): Remove.
3157         (arrange_linetable): Call std::sort instead of qsort.
3158
3159 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3160
3161         * symfile.c (init_entry_point_info): Fix typo.
3162         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3163
3164 2019-10-18  Tom de Vries  <tdevries@suse.de>
3165
3166         * aarch64-tdep.c: Fix typos in comments.
3167         * ada-lang.c: Same.
3168         * ada-tasks.c: Same.
3169         * alpha-tdep.c: Same.
3170         * alpha-tdep.h: Same.
3171         * amd64-nat.c: Same.
3172         * amd64-windows-tdep.c: Same.
3173         * arc-tdep.c: Same.
3174         * arc-tdep.h: Same.
3175         * arch-utils.c: Same.
3176         * arm-nbsd-tdep.c: Same.
3177         * arm-tdep.c: Same.
3178         * ax-gdb.c: Same.
3179         * blockframe.c: Same.
3180         * btrace.c: Same.
3181         * c-varobj.c: Same.
3182         * coff-pe-read.c: Same.
3183         * coffread.c: Same.
3184         * cris-tdep.c: Same.
3185         * darwin-nat.c: Same.
3186         * dbxread.c: Same.
3187         * dcache.c: Same.
3188         * disasm.c: Same.
3189         * dtrace-probe.c: Same.
3190         * dwarf-index-write.c: Same.
3191         * dwarf2-frame-tailcall.c: Same.
3192         * dwarf2-frame.c: Same.
3193         * dwarf2read.c: Same.
3194         * eval.c: Same.
3195         * exceptions.c: Same.
3196         * fbsd-tdep.c: Same.
3197         * findvar.c: Same.
3198         * frame.c: Same.
3199         * frv-tdep.c: Same.
3200         * gnu-v3-abi.c: Same.
3201         * go32-nat.c: Same.
3202         * h8300-tdep.c: Same.
3203         * hppa-tdep.c: Same.
3204         * i386-linux-tdep.c: Same.
3205         * i386-tdep.c: Same.
3206         * ia64-libunwind-tdep.c: Same.
3207         * ia64-tdep.c: Same.
3208         * infcmd.c: Same.
3209         * infrun.c: Same.
3210         * linespec.c: Same.
3211         * linux-nat.c: Same.
3212         * linux-thread-db.c: Same.
3213         * machoread.c: Same.
3214         * mdebugread.c: Same.
3215         * mep-tdep.c: Same.
3216         * mn10300-tdep.c: Same.
3217         * namespace.c: Same.
3218         * objfiles.c: Same.
3219         * opencl-lang.c: Same.
3220         * or1k-tdep.c: Same.
3221         * osabi.c: Same.
3222         * ppc-linux-nat.c: Same.
3223         * ppc-linux-tdep.c: Same.
3224         * ppc-sysv-tdep.c: Same.
3225         * printcmd.c: Same.
3226         * procfs.c: Same.
3227         * record-btrace.c: Same.
3228         * record-full.c: Same.
3229         * remote-fileio.c: Same.
3230         * remote.c: Same.
3231         * rs6000-tdep.c: Same.
3232         * s12z-tdep.c: Same.
3233         * score-tdep.c: Same.
3234         * ser-base.c: Same.
3235         * ser-go32.c: Same.
3236         * skip.c: Same.
3237         * sol-thread.c: Same.
3238         * solib-svr4.c: Same.
3239         * solib.c: Same.
3240         * source.c: Same.
3241         * sparc-nat.c: Same.
3242         * sparc-sol2-tdep.c: Same.
3243         * sparc-tdep.c: Same.
3244         * sparc64-tdep.c: Same.
3245         * stabsread.c: Same.
3246         * stack.c: Same.
3247         * symfile.c: Same.
3248         * symtab.c: Same.
3249         * target-descriptions.c: Same.
3250         * target-float.c: Same.
3251         * thread.c: Same.
3252         * utils.c: Same.
3253         * valops.c: Same.
3254         * valprint.c: Same.
3255         * value.c: Same.
3256         * varobj.c: Same.
3257         * windows-nat.c: Same.
3258         * xcoffread.c: Same.
3259         * xstormy16-tdep.c: Same.
3260         * xtensa-tdep.c: Same.
3261
3262 2019-10-17  Tom Tromey  <tromey@adacore.com>
3263
3264         * configure: Rebuild.
3265         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3266         in AC_CONFIG_FILES invocation.
3267         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3268         new-style config.status invocation.
3269
3270 2019-10-17  Tom de Vries  <tdevries@suse.de>
3271
3272         * arm-nbsd-nat.c: Fix typos in comments.
3273         * arm-tdep.c: Same.
3274         * darwin-nat-info.c: Same.
3275         * dwarf2read.c: Same.
3276         * elfread.c: Same.
3277         * event-top.c: Same.
3278         * findvar.c: Same.
3279         * gdbtypes.c: Same.
3280         * hppa-tdep.c: Same.
3281         * i386-tdep.c: Same.
3282         * jit.c: Same.
3283         * main.c: Same.
3284         * mdebugread.c: Same.
3285         * moxie-tdep.c: Same.
3286         * nto-procfs.c: Same.
3287         * osabi.c: Same.
3288         * ppc-linux-tdep.c: Same.
3289         * remote.c: Same.
3290         * riscv-tdep.c: Same.
3291         * s390-tdep.c: Same.
3292         * sh-tdep.c: Same.
3293         * sparc-linux-tdep.c: Same.
3294         * sparc-nat.c: Same.
3295         * stack.c: Same.
3296         * target-descriptions.c: Same.
3297         * top.c: Same.
3298         * varobj.c: Same.
3299
3300 2019-10-16  Tom Tromey  <tom@tromey.com>
3301
3302         * objfiles.h (struct objfile) <original_name>: Now const.
3303
3304 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3305
3306         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3307         pass on to sigsetjmp's second argument.
3308         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3309
3310 2019-10-16  Keith Seitz  <keiths@redhat.com>
3311
3312         PR gdb/23567
3313         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3314         sections whose size is greater than the file size.
3315
3316 2019-10-16  Jim Wilson  <jimw@sifive.com>
3317
3318         * riscv-tdep.c (riscv_gcc_target_options): New.
3319         (riscv_gnu_triplet_regexp): New.
3320         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3321         set_gdbarch_gnu_triplet_regexp.
3322
3323 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3324
3325         * Makefile.in: Add xml-builtin.h.
3326         * features/feature_to_c.sh: Add an include for xml-builtin.h
3327         to ensure that the compiler checks that the types match.
3328         * xml-builtin.h: New file.
3329         * xml-support.c (fetch_xml_builtin): Add missing const.
3330         * xml-support.h: Remove declaration of xml_builtins.
3331
3332 2019-10-16  Tom de Vries  <tdevries@suse.de>
3333
3334         PR tdep/25096
3335         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3336         (amd64_classify_aggregate): ... here.
3337         (amd64_classify_aggregate_field): Handled fiels of nested structs
3338         recursively.
3339
3340 2019-10-16  Tom de Vries  <tdevries@suse.de>
3341
3342         PR tdep/24104
3343         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3344         that handles 'theclass'.
3345
3346 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3347
3348         * linespec.c (decode_digits_ordinary): Update comment.
3349         * make-target-delegates: No longer need to handle VEC case.
3350         * memrange.c (normalize_mem_ranges): Update comment.
3351         * namespace.c (add_using_directive): Update comment.
3352         * objc-lang.c (uniquify_strings): Update comment.
3353         * ppc-linux-nat.c (struct thread_points): Update comment.
3354         * probe.h (find_probes_in_objfile): Update comment.
3355         * target.h (enum flash_preserve_mode): Update comment.
3356         * varobj.c (varobj_restrict_range): Update comment.
3357         * varobj.h (varobj_list_children): Update comment.
3358
3359 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3360
3361         * Makefile.in: Remove references to vec.h and vec.c.
3362         * aarch64-tdep.c: No longer include vec.h.
3363         * ada-lang.c: Likewise.
3364         * ada-lang.h: Likewise.
3365         * arm-tdep.c: Likewise.
3366         * ax.h: Likewise.
3367         * breakpoint.h: Likewise.
3368         * charset.c: Likewise.
3369         * cp-support.h: Likewise.
3370         * dtrace-probe.c: Likewise.
3371         * dwarf2read.c: Likewise.
3372         * extension.h: Likewise.
3373         * gdb_bfd.c: Likewise.
3374         * gdbsupport/gdb_vecs.h: Likewise.
3375         * gdbsupport/vec.c: Remove.
3376         * gdbsupport/vec.h: Remove.
3377         * gdbthread.h: Likewise.
3378         * guile/scm-type.c: Likewise.
3379         * inline-frame.c: Likewise.
3380         * machoread.c: Likewise.
3381         * memattr.c: Likewise.
3382         * memrange.h: Likewise.
3383         * namespace.h: Likewise.
3384         * nat/linux-btrace.h: Likewise.
3385         * osdata.c: Likewise.
3386         * parser-defs.h: Likewise.
3387         * progspace.h: Likewise.
3388         * python/py-type.c: Likewise.
3389         * record-btrace.c: Likewise.
3390         * rust-exp.y: Likewise.
3391         * solib-target.c: Likewise.
3392         * stap-probe.c: Likewise.
3393         * target-descriptions.c: Likewise.
3394         * target-memory.c: Likewise.
3395         * target.h: Likewise.
3396         * varobj.c: Likewise.
3397         * varobj.h: Likewise.
3398         * xml-support.h: Likewise.
3399
3400 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3401
3402         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3403         Update for new std::vector based implementation.
3404         (process_psymtab_comp_unit_reader): Likewise.
3405         (scan_partial_symbols): Likewise.
3406         (recursively_compute_inclusions): Likewise.
3407         (compute_compunit_symtab_includes): Likewise.
3408         (process_imported_unit_die): Likewise.
3409         (queue_and_load_dwo_tu): Likewise.
3410         (follow_die_sig_1): Likewise.
3411         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3412         (typedef dwarf2_per_cu_ptr): Remove.
3413         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3414         function.
3415         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3416         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3417         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3418         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3419         std::vector.
3420
3421 2019-10-15  Tom Tromey  <tromey@adacore.com>
3422
3423         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3424         TID.
3425
3426 2019-10-15  Tom Tromey  <tromey@adacore.com>
3427
3428         * windows-nat.c (windows_nat_target::fetch_registers)
3429         (windows_nat_target::store_registers): Rename "pid" to "tid".
3430
3431 2019-10-15  Tom Tromey  <tromey@adacore.com>
3432
3433         * gdbarch.h, gdbarch.c: Rebuild.
3434         * gdbarch.sh (gcc_target_options): Change return type to
3435         std::string.
3436         * compile/compile.c (get_args): Update.
3437         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3438         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3439         std::string.
3440         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3441         std::string.
3442         * arch-utils.c (default_gcc_target_options): Return std::string.
3443         * arch-utils.h (default_gcc_target_options): Return std::string.
3444         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3445
3446 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3447
3448         * breakpoint.c (breakpoint_chain): Make static.
3449         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3450         of accessing breakpoint_chain.
3451
3452 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3453
3454         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3455         to a gdb::function_view and return value to bool.
3456         * breakpoint.h (iterate_over_breakpoints): Likewise.
3457         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3458         (pop_dummy_frame): Update.
3459         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3460         (gdbscm_breakpoints): Update.
3461         * python/py-breakpoint.c (build_bp_list): Update.
3462         (gdbpy_breakpoints): Update.
3463         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3464         Update.
3465         (bpfinishpy_handle_stop): Update.
3466         (bpfinishpy_handle_exit): Update.
3467         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3468         (svr4_update_solib_event_breakpoints): Update.
3469
3470 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3471
3472         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3473         when unwrapping single-field structs.
3474
3475 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3476
3477         * dwarf2read.c: Remove includes.
3478
3479 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3480
3481         * ui-out.c (ui_out::call_do_message): Silence
3482         -Wformat-nonliteral warning.
3483
3484 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3485
3486         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3487         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3488         include: readline/tilde.h.
3489
3490 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3491
3492         * remote.c (remote_target::get_trace_status): Remove declaration of
3493         trace_regblock_size.
3494
3495 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3496
3497         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3498         (show_user): Remove declaration of cmdlist.
3499         * cli/cli-cmds.h (max_user_call_depth): Declare.
3500         * cli/cli-script.c (execute_user_command): Remove declaration
3501         of max_user_call_depth.
3502
3503 2019-10-11  Jim Wilson  <jimw@sifive.com>
3504
3505         * gdbsupport/print-utils.h (pulongest): Fix comment.
3506         (plongest): Likewise.
3507         (phex): Add missing comment, mention leading zeros.
3508         (phex_nz): Add mention of no leading zeros to comment.
3509
3510         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3511         plongest instead of unsigned long long cast.
3512
3513 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3514
3515         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3516         for external_editor_command and gdbtk_test.
3517
3518 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3519
3520         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3521         * varobj.c (varobjdebug): Move comment to...
3522         * varobj.h (varobjdebug): ...here, and declare.
3523
3524 2019-10-09  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3527         erase_data_content.
3528
3529 2019-10-09  Tom Tromey  <tom@tromey.com>
3530
3531         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3532         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3533         * tui/tui-command.c (tui_cmd_window::resize)
3534         (tui_refresh_cmd_win): Update.
3535         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3536         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3537         * tui/tui-data.c (~tui_gen_win_info): Remove.
3538         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3539         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3540         (tui_redisplay_readline, tui_mld_flush)
3541         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3542         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3543         (tui_data_window::erase_data_content)
3544         (tui_data_item_window::rerender)
3545         (tui_data_item_window::refresh_window): Update.
3546         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3547         (box_win, tui_gen_win_info::make_window)
3548         (tui_gen_win_info::make_visible): Update.
3549         (tui_delete_win): Remove.
3550         * tui/tui-winsource.c
3551         (tui_source_window_base::do_erase_source_content): Update.
3552         (tui_show_source_line, tui_source_window_base::update_tab_width)
3553         (tui_source_window_base::update_exec_info): Update.
3554         * tui/tui-data.h (struct curses_deleter): New.
3555         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3556         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3557
3558 2019-10-09  Tom Tromey  <tom@tromey.com>
3559
3560         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3561
3562 2019-10-09  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3565         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3566
3567 2019-10-09  Tom Tromey  <tom@tromey.com>
3568
3569         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3570         window height directly.
3571         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3572         declare.
3573         * tui/tui-layout.c (tui_default_win_height): Remove.
3574         (tui_default_win_viewport_height): Remove.
3575
3576 2019-10-09  Tom Tromey  <tom@tromey.com>
3577
3578         * tui/tui.h: Remove comments.
3579
3580 2019-10-09  Tom de Vries  <tdevries@suse.de>
3581
3582         * python/lib/gdb/printer/bound_registers.py: Use
3583         '^builtin_type_bound128' as regexp argument for
3584         add_builtin_pretty_printer.
3585
3586 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3587
3588         * guile/guile.c (guile_extension_script_ops): Remove forward
3589         declaration and mark as static.
3590         (guile_script_ops): Likewise.
3591         (extension_language_guile): Move further down in the file so
3592         it can reference the definitions for guile_{extension_,}script_ops.
3593
3594 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3595
3596         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3597         except SORTL, DFLTCC, and KDSA.
3598
3599 2019-10-08  Tom Tromey  <tromey@adacore.com>
3600
3601         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3602         (struct safe_symbol_file_add_args): Remove.
3603
3604 2019-10-08  Tom Tromey  <tromey@adacore.com>
3605
3606         * windows-nat.c: Don't include buildsym-legacy.h.
3607
3608 2019-10-08  Tom Tromey  <tromey@adacore.com>
3609
3610         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3611
3612 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3613
3614         * gdbtypes.c (overload_debug): Move comment to header.
3615         * gdbtypes.h (overload_debug): Declare.
3616         * valops.c: Remove declaration of overload_debug, instead
3617         include gdbtypes.h.
3618
3619 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3620
3621         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3622         through _().
3623         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3624         move comment...
3625         * language.h (lang_frame_mismatch_warn): ... here. Also add
3626         declaration.
3627         * top.c (lang_frame_mismatch_warn): Remove declaration.
3628         (check_frame_language_change): Pass lang_frame_mismatch_warn
3629         through _().
3630
3631 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3632
3633         * c-lang.h (vtbl_ptr_name): Declare.
3634         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3635         it from the header.
3636         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3637
3638 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3639
3640         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3641         gdb_static_assert.
3642
3643 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3644
3645         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3646         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3647         * ctfread.c: New file.
3648         * ctfread.h: New file.
3649         * elfread.c: Include ctfread.h.
3650         (struct elfinfo text_p): New member ctfsect.
3651         (elf_locate_sections): Mark CTF section.
3652         (elf_symfile_read): Call elfctf_build_psymtabs.
3653         * Makefile.in (LIBCTF): Add.
3654         (CLIBS): Use it.
3655         (CDEPS): Likewise.
3656         (DIST): Add ctfread.c.
3657
3658 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3659
3660         * ctfread.c (struct nextfield): Renamed to ...
3661         (struct ctf_nextfield): ... this.
3662         (struct field_info): Renamed to ...
3663         (strut ctf_field_info): ... this.
3664         (attach_fields_to_type): Update for renamed structures.
3665         (ctf_add_member_cb): Likewise.
3666         (ctf_add_enum_member_cb): Likewise.
3667         (process_struct_members): Likewise.
3668         (process_enum_type): Likewise.
3669
3670 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3671
3672         * tracectf.h: Rename, was ctf.h.
3673         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3674         * tracefile.c: Likewise.
3675         * tracepoint.c: Remove unused include ctf.h.
3676         * mi/mi-main.c: Likewise.
3677         * Makefile.in Replace ctf.c with tracectf.c.
3678
3679 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3680
3681         * version.in: Change version number to "9.0.50.DATE-git".
3682
3683 2019-10-03  Tom Tromey  <tom@tromey.com>
3684
3685         PR rust/24976:
3686         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3687
3688 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3689
3690         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3691         cp_search_name_hash.
3692         * NEWS: Add entry about nested function support.
3693
3694 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3695             Andrew Burgess  <andrew.burgess@embecosm.com>
3696
3697         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3698         for nested static variables when searchin VAR_DOMAIN.
3699         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3700         global scope, update comment.
3701         (add_partial_subprogram): Call add_partial_subprogram recursively
3702         for nested subroutines when processinng Fortran.
3703         (load_partial_dies): Process the child entities of a subprogram
3704         when processing Fortran.
3705         (partial_die_parent_scope): Handle building scope
3706         for Fortran nested functions.
3707         (process_die): Record that nested functions have a scope.
3708         (new_symbol): Always record Fortran subprograms on the global
3709         symbol list.
3710         (determine_prefix): How to build the prefix for Fortran
3711         subprograms.
3712
3713 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3714
3715         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3716         have just sent the thread a SIGSTOP and are waiting for it to
3717         arrive.
3718
3719 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * btrace.c (btrace_add_pc): Remove whitespace before the template
3722         parameter in 'std::vector <...>'.
3723         (parse_xml_btrace_block): Likewise.
3724         (btrace_maint_decode_pt): Likewise.
3725         (btrace_maint_update_packets): Likewise.
3726         (btrace_maint_print_packets): Likewise.
3727         * btrace.h (struct btrace_maint_info): Likewise.
3728         * dwarf2read.c (struct type_unit_group): Likewise.
3729         (build_type_psymtabs_reader): Likewise.
3730         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3731         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3732         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3733
3734 2019-10-03  Tom de Vries  <tdevries@suse.de>
3735
3736         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3737         the first line of the help text for set/show style metadata.
3738
3739 2019-10-02  Tom Tromey  <tromey@adacore.com>
3740
3741         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3742         * gdbsupport/common-inferior.c: New file.
3743         * infcmd.c (startup_with_shell): Don't define.
3744         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3745         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3746         * inferior.h (startup_with_shell): Don't declare.
3747
3748 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3749
3750         * gdbsupport/gdb_assert.h: Include errors.h.
3751         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3752
3753 2019-10-02  Tom Tromey  <tromey@adacore.com>
3754
3755         * NEWS: Add $_ada_exception entry.
3756         * ada-lang.c (struct ada_catchpoint): Add constructor.
3757         <m_kind>: New member.
3758         (allocate_location_exception, re_set_exception): Remove
3759         "ex" parameter.
3760         (should_stop_exception): Compute $_ada_exception.
3761         (check_status_exception, print_it_exception)
3762         (print_one_exception, print_mention_exception): Remove
3763         "ex" parameter.
3764         (allocate_location_catch_exception, re_set_catch_exception)
3765         (check_status_exception, print_it_catch_exception)
3766         (print_one_catch_exception, print_mention_catch_exception)
3767         (print_recreate_catch_exception)
3768         (allocate_location_catch_exception_unhandled)
3769         (re_set_catch_exception_unhandled)
3770         (check_status_exception, print_it_catch_exception_unhandled)
3771         (print_one_catch_exception_unhandled)
3772         (print_mention_catch_exception_unhandled)
3773         (print_recreate_catch_exception_unhandled)
3774         (allocate_location_catch_assert, re_set_catch_assert)
3775         (check_status_assert, print_it_catch_assert)
3776         (print_one_catch_assert, print_mention_catch_assert)
3777         (print_recreate_catch_assert)
3778         (allocate_location_catch_handlers, re_set_catch_handlers)
3779         (check_status_handlers, print_it_catch_handlers)
3780         (print_one_catch_handlers, print_mention_catch_handlers)
3781         (print_recreate_catch_handlers): Remove.
3782         (create_ada_exception_catchpoint): Update.
3783         (initialize_ada_catchpoint_ops): Update.
3784
3785 2019-10-02  Tom Tromey  <tromey@adacore.com>
3786
3787         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3788         (create_excep_cond_exprs): Simplify exception string computation.
3789         (ada_exception_catchpoint_cond_string): Likewise.
3790
3791 2019-10-02  Tom Tromey  <tromey@adacore.com>
3792
3793         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3794         * ada-lang.c (lesseq_defined_than): Handle
3795         LOC_STATIC.
3796         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3797         parameter.
3798         (dwarf2_has_info): Likewise.
3799         (new_symbol): Set maybe_copied on symbol when
3800         appropriate.
3801         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3802         parameter.
3803         <can_copy>: New member.
3804         * elfread.c (record_minimal_symbol): Set maybe_copied
3805         on symbol when appropriate.
3806         (elf_symfile_read): Update call to dwarf2_has_info.
3807         * minsyms.c (lookup_minimal_symbol_linkage): New
3808         function.
3809         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3810         * symtab.c (get_symbol_address, get_msymbol_address):
3811         New functions.
3812         * symtab.h (get_symbol_address, get_msymbol_address):
3813         Declare.
3814         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3815         maybe_copied.
3816         (struct symbol, struct minimal_symbol) <maybe_copied>:
3817         New member.
3818
3819 2019-10-02  Tom Tromey  <tromey@adacore.com>
3820
3821         * source.c (struct current_source_location): New.
3822         (current_source_key): New global.
3823         (current_source_symtab, current_source_line)
3824         (current_source_pspace): Remove.
3825         (get_source_location): New function.
3826         (get_current_source_symtab_and_line)
3827         (set_default_source_symtab_and_line)
3828         (set_current_source_symtab_and_line)
3829         (clear_current_source_symtab_and_line, select_source_symtab)
3830         (info_source_command, print_source_lines_base)
3831         (info_line_command, search_command_helper, _initialize_source):
3832         Update.
3833
3834 2019-10-02  Tom Tromey  <tromey@adacore.com>
3835
3836         * source.c (select_source_symtab): Don't call
3837         decode_line_with_current_source.
3838
3839 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * symtab.c (lookup_global_symbol): Search global block.
3842
3843 2019-10-02  Tom Tromey  <tromey@adacore.com>
3844
3845         * coffread.c (process_coff_symbol): Update.
3846         * dwarf2read.c (var_decode_location, new_symbol): Update.
3847         * mdebugread.c (parse_symbol): Update.
3848         * objfiles.c (relocate_one_symbol): Update.
3849         * stabsread.c (define_symbol, fix_common_block)
3850         (scan_file_globals): Update.
3851         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3852         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3853         * xcoffread.c (process_xcoff_symbol): Update.
3854
3855 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3856
3857         * MAINTAINERS: Update my email address.
3858
3859 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3862         std::vector.
3863         (build_type_psymtabs_reader): Update for std::vector.
3864         (build_type_psymtab_dependencies): Likewise.
3865         * dwarf2read.h: Remove use of DEF_VEC_P.
3866         (typedef sig_type_ptr): Delete.
3867
3868 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3869
3870         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3871         to std::vector.
3872         (btrace_maint_decode_pt): Likewise, and move allocation of the
3873         vector outside of the loop.
3874         (btrace_maint_update_packets): Update to handle change from VEC to
3875         std::vector.
3876         (btrace_maint_print_packets): Likewise.
3877         (maint_info_btrace_cmd): Likewise.
3878         * btrace.h: Remove use of DEF_VEC_O.
3879         (typedef btrace_pt_packet_s): Delete.
3880         (struct btrace_maint_info) <packets>: Change fromm VEC to
3881         std::vector.
3882         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3883
3884 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3887         make accesses into the vector constant references.
3888         (btrace_add_pc): Update for std::vector.
3889         (btrace_stitch_bts): Likewise.
3890         (parse_xml_btrace_block): Likewise.
3891         (btrace_maint_update_packets): Likewise.
3892         (btrace_maint_print_packets): Likewise.
3893         (maint_info_btrace_cmd): Likewise.
3894         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3895         std::vector.
3896         (btrace_data::empty): Likewise.
3897         (btrace_data_append): Likewise.
3898         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3899         (typedef btrace_block_s): Delete.
3900         (struct btrace_block): Add constructor.
3901         (struct btrace_data_bts) <blocks>: Change to std::vector.
3902         * nat/linux-btrace.c (perf_event_read_bts): Update for
3903         std::vector.
3904         (linux_read_bts): Likewise.
3905
3906 2019-10-01  Tom Tromey  <tom@tromey.com>
3907
3908         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3909
3910 2019-10-01  Tom Tromey  <tom@tromey.com>
3911
3912         * stack.c (print_frame, info_frame_command_core): Use
3913         styled_string.
3914         * linux-thread-db.c (try_thread_db_load_1)
3915         (try_thread_db_load_from_pdir_1): Use styled_string.
3916         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3917         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3918         (maybe_print_unsupported_script_warning)
3919         (maybe_print_script_not_found_warning): Use styled_string.
3920         * ada-lang.c (user_select_syms): Use styled_string.
3921
3922 2019-10-01  Tom Tromey  <tom@tromey.com>
3923
3924         * p-lang.c (pascal_printstr): Use metadata style.
3925         * value.c (show_convenience): Use metadata style.
3926         * valprint.c (valprint_check_validity, val_print_optimized_out)
3927         (val_print_not_saved, val_print_unavailable)
3928         (val_print_invalid_address, generic_val_print, val_print)
3929         (value_check_printable, val_print_array_elements): Use metadata
3930         style.
3931         * ui-out.h (class ui_out) <field_fmt>: New overload.
3932         <do_field_fmt>: Add style parameter.
3933         * ui-out.c (ui_out::field_fmt): New overload.
3934         * typeprint.c (type_print_unknown_return_type)
3935         (val_print_not_allocated, val_print_not_associated): Use metadata
3936         style.
3937         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3938         parameter.
3939         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3940         * tracepoint.c (tvariables_info_1): Use metadata style.
3941         * stack.c (print_frame_arg, print_frame_info, print_frame)
3942         (info_frame_command_core): Use metadata style.
3943         * skip.c (info_skip_command): Use metadata style.
3944         * rust-lang.c (rust_print_enum): Use metadata style.
3945         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3946         metadata style.
3947         * python/py-framefilter.c (py_print_single_arg): Use metadata
3948         style.
3949         * printcmd.c (do_one_display, print_variable_and_value): Use
3950         metadata style.
3951         * p-valprint.c (pascal_val_print)
3952         (pascal_object_print_value_fields): Use metadata style.
3953         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3954         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3955         parameter.
3956         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3957         * m2-valprint.c (m2_print_long_set): Use metadata style.
3958         * m2-typeprint.c (m2_print_type): Use metadata style.
3959         * infcmd.c (print_return_value_1): Use metadata style.
3960         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3961         * f-valprint.c (info_common_command_for_block): Use metadata
3962         style.
3963         * f-typeprint.c (f_type_print_base): Use metadata style.
3964         * expprint.c (print_subexp_standard): Use metadata style.
3965         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3966         * cli/cli-style.h (class cli_style_option): Add constructor.
3967         (metadata_style): Declare.
3968         * cli/cli-style.c (metadata_style): New global.
3969         (_initialize_cli_style): Register metadata style.
3970         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3971         parameter.
3972         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3973         * c-typeprint.c (c_type_print_base_struct_union)
3974         (c_type_print_base_1): Use metadata style.
3975         * breakpoint.c (watchpoint_value_print)
3976         (print_one_breakpoint_location): Use metadata style.
3977         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3978         style.
3979         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3980         style.
3981         * ada-valprint.c (val_print_packed_array_elements, printstr)
3982         (print_field_values, ada_val_print_ref, ada_val_print): Use
3983         metadata style.
3984         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3985         style.
3986         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3987         style.
3988         * ada-lang.c (user_select_syms): Use metadata style.
3989
3990 2019-10-01  Tom Tromey  <tom@tromey.com>
3991
3992         * cli/cli-cmds.c (pwd_command): Style output.
3993
3994 2019-10-01  Pedro Alves  <palves@redhat.com>
3995             Tom Tromey  <tom@tromey.com>
3996
3997         * symtab.c (print_symbol_info): Use %ps.
3998         (print_msymbol_info): Use %ps.
3999         * symfile.c (symbol_file_add_with_addrs): Use %ps.
4000         * printcmd.c (print_variable_and_value): Use %ps.
4001         * macrocmd.c (show_pp_source_pos): Use %ps.
4002         * infrun.c (print_exited_reason): Use ui_out::message.
4003         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4004         (describe_other_breakpoints): Use ui_out::message and new
4005         formats.
4006         (say_where): Use new formats.
4007         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4008         and new formats.
4009
4010 2019-10-01  Pedro Alves  <palves@redhat.com>
4011             Tom Tromey  <tom@tromey.com>
4012
4013         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4014         (test_gdb_formats): New function.
4015         (run_tests): Call it.
4016         (test_format_specifier): Update.
4017         * utils.h (fputs_filtered): Update comment.
4018         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4019         (fputs_styled_unfiltered): Declare.
4020         * utils.c (fputs_styled_unfiltered): New function.
4021         (vfprintf_maybe_filtered): Add gdbfmt parameter.
4022         (vfprintf_filtered): Update.
4023         (vfprintf_unfiltered, vprintf_filtered): Update.
4024         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4025         * ui-out.h (enum ui_out_flag) <unfiltered_output,
4026         disallow_ui_out_field>: New constants.
4027         (enum class field_kind): New.
4028         (struct base_field_s, struct signed_field_s): New.
4029         (signed_field): New function.
4030         (struct string_field_s): New.
4031         (string_field): New function.
4032         (struct styled_string_s): New.
4033         (styled_string): New function.
4034         (class ui_out) <message>: Add comment.
4035         <vmessage, call_do_message>: New methods.
4036         <do_message>: Add style parameter.
4037         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4038         methods.
4039         (ui_out::message): Rewrite.
4040         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4041         parameter.
4042         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4043         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4044         gdb_extensions parameter.
4045         (class format_piece): Add parameter to constructor.
4046         (n_int_args): New field.
4047         * gdbsupport/format.c (format_pieces::format_pieces): Add
4048         gdb_extensions parameter.  Handle '*'.
4049         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4050         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
4051         vfprintf_styled_no_gdbfmt.
4052         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4053         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4054         unfiltered output.
4055         * ui-style.h (struct ui_file_style) <ptr>: New method.
4056
4057 2019-10-01  Tom Tromey  <tom@tromey.com>
4058
4059         * unittests/format_pieces-selftests.c: Update.  Add final format.
4060         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4061         empty literal pieces.
4062
4063 2019-10-01  Tom Tromey  <tom@tromey.com>
4064
4065         * ui-out.h (enum class ui_out_style_kind): Remove.
4066         (class ui_out) <field_string, field_stsream, do_field_string>:
4067         Change type of "style".
4068         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4069         (ui_out::field_string): Update.
4070         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4071         of "style".
4072         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4073         * tracepoint.c (print_one_static_tracepoint_marker): Update.
4074         * stack.c (print_frame_arg, print_frame_info, print_frame):
4075         Update.
4076         * source.c (print_source_lines_base): Update.
4077         * solib.c (info_sharedlibrary_command): Update.
4078         * skip.c (info_skip_command): Update.
4079         * record-btrace.c (btrace_call_history_src_line)
4080         (btrace_call_history): Update.
4081         * python/py-framefilter.c (py_print_frame): Update.
4082         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4083         "style".
4084         * mi/mi-out.c (mi_ui_out::do_table_header)
4085         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4086         (mi_ui_out::do_field_string): Update.
4087         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4088         Update.
4089         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4090         "style".
4091         * cli-out.c (cli_ui_out::do_table_header)
4092         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4093         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4094         (cli_ui_out::do_field_fmt): Update.
4095         * breakpoint.c (print_breakpoint_location): Update.
4096         (update_static_tracepoint): Update.
4097
4098 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4099
4100         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4101         conversion of gdb_datadir.
4102         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4103         remove not needed c_str ().
4104
4105 2019-09-30  Ali Tamur <tamur@google.com>
4106
4107         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4108         (dwarf2_string_attr): Likewise.
4109
4110 2019-09-30  Ali Tamur <tamur@google.com>
4111
4112         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4113         (process_full_type_unit): Likewise.
4114         (dump_die_shallow): Likewise.
4115         (cu_debug_loc_section): Likewise.
4116
4117 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4118
4119         * minsyms.c (compare_minimal_symbols): Rename to...
4120         (minimal_symbol_is_less_than): ...this, and adjust to STL
4121         conventions (return bool, take arguments as references)
4122         (minimal_symbol_reader::install): Call std::sort instead
4123         of qsort.
4124
4125 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4126
4127         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4128         hash and why.
4129         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4130         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4131
4132 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4133
4134         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4135         * psympriv.h (add_psymbol_to_list): Move comment here and update
4136         it.
4137
4138 2019-09-29  Tom de Vries  <tdevries@suse.de>
4139
4140         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4141         Use $tmpdir/$(basename "$output_file").dwz instead of
4142         "${output_file}.dwz".
4143
4144 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4145
4146         PR gdb/25045
4147         * hppa-linux-nat.c: Include gdbarch.h.
4148
4149 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4150
4151         * blockframe.c (find_pc_partial_function): Change return type to bool.
4152         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4153         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4154         (stub_gnu_ifunc_resolve_name): Likewise.
4155         * symtab.c (compare_filenames_for_search): Likewise.
4156         (compare_glob_filenames_for_search): Likewise.
4157         (matching_obj_sections): Likewise.
4158         (symbol_matches_domain): Likewise.
4159         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4160         (find_line_pc): Change return type to bool.
4161         (find_line_pc_range): Likewise.
4162         (producer_is_realview): Likewise.
4163         * symtab.h (symbol_matches_domain): Likewise.
4164         (find_pc_partial_function): Likewise.
4165         (find_pc_line_pc_range): Likewise.
4166         (in_gnu_ifunc_stub): Likewise.
4167         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4168         (find_line_pc): Likewise.
4169         (find_line_pc_range): Likewise.
4170         (matching_obj_sections): Likewise.
4171         (find_line_symtab): Change out parameter to bool.
4172         (producer_is_realview): Change return type to bool.
4173         (compare_filenames_for_search): Likewise.
4174         (compare_glob_filenames_for_search): Likewise.
4175
4176 2019-09-26  Tom Tromey  <tom@tromey.com>
4177
4178         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4179         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4180         * gdb_usleep.h: Remove.
4181         * gdb_usleep.c: Remove.
4182         * utils.c: Don't include gdb_usleep.h.
4183
4184 2019-09-26  Tom Tromey  <tromey@adacore.com>
4185
4186         * python/py-type.c (type_to_type_object): Call check_typedef
4187         for stub types.
4188
4189 2019-09-26  Tom Tromey  <tom@tromey.com>
4190
4191         * utils.h (initialize_utils): Don't declare.
4192         * top.c (gdb_init): Don't call initialize_utils.
4193         * utils.c (initialize_utils): Remove.  Move contents...
4194         (_initialize_utils): ... here.
4195
4196 2019-09-25  Tom Tromey  <tom@tromey.com>
4197
4198         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4199         * utils.h (make_hex_string): Don't declare.
4200         * utils.c (make_hex_string): Remove.
4201
4202 2019-09-24  Tom de Vries  <tdevries@suse.de>
4203
4204         PR gdb/23815
4205         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4206         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4207
4208 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4209
4210         * NEWS: Mention new simulator port for PRU.
4211
4212 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4213
4214         * ada-exp.y (write_object_remaining): Update.
4215         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4216         and eliminate the static buffer.
4217         (ada_decode_symbol): Update.
4218         (ada_la_decode): Update.
4219         (ada_sniff_from_mangled_name): Update.
4220         (is_valid_name_for_wild_match): Update.
4221         (ada_lookup_name_info::matches): Update and simplify.
4222         (name_matches_regex): Update.
4223         (ada_add_global_exceptions): Update.
4224         * ada-lang.h (ada_decode): Update signature.
4225         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4226         * dwarf-index-write.c (debug_names::insert): Update.
4227
4228 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4229
4230         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4231         formatting.
4232
4233 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4234
4235         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4236         Change "nonzero" to "true" in documentation.
4237
4238 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4239
4240         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4241         (_initialize_darwin_solib): Don't set
4242         darwin_so_ops.lookup_lib_global_symbol.
4243         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4244         set_gdbarch_iterate_over_objfiles_in_search_order.
4245         (elf_lookup_lib_symbol): Rename to...
4246         (svr4_iterate_over_objfiles_in_search_order): this, and update
4247         to iterate semantics.
4248         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4249         * solib.c (solib_global_lookup): Remove.
4250         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4251         (solib_global_lookup): Remove.
4252         * symtab.c (lookup_global_or_static_symbol): Remove call to
4253         solib_global_lookup.
4254
4255 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4256
4257         * NEWS: Move entries about default MI version now being
4258         version 3, and about the GDB/MI fix for multi-location
4259         breakpoints to the "since GDB 8.3" section.
4260
4261 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4262
4263         GDB 8.3.1 released.
4264
4265 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4266
4267         * NEWS: Mention that Cell/B.E. debugging support was removed.
4268         * MAINTAINERS: Remove spu target.
4269
4270         * config/djgpp/fnchange.lst: Remove entries for removed files.
4271
4272         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4273         spu-multiarch.o, and spu-tdep.o.
4274         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4275         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4276         spu-multiarch.c, and spu-tdep.c.
4277         * spu-linux-nat.c: Remove file.
4278         * spu-multiarch.c: Remove file.
4279         * spu-tdep.c: Remove file.
4280         * spu-tdep.h: Remove file.
4281         * solib-spu.c: Remove file.
4282         * solib-spu.h: Remove file.
4283
4284         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4285         * configure.nat (spu-linux): Remove.
4286         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4287         solib-multiarch.o from gdb_target_obs.
4288         (spu*-*-*): Remove.
4289
4290         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4291         feature flag.
4292         (ppc_linux_no_features): Update.
4293         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4294         Cell/B.E. support.
4295         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4296         (tdesc_powerpc_cell64l): Likewise.
4297         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4298         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4299         Cell/B.E. support.
4300         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4301         Do not include "features/rs6000/powerpc-cell32l.c" or
4302         "features/rs6000/powerpc-cell64l.c".
4303         (ppc_linux_spu_section): Remove.
4304         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4305         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4306         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4307         (ppc_linux_spe_context_lookup): Remove.
4308         (ppc_linux_spe_context_inferior_created): Remove.
4309         (ppc_linux_spe_context_solib_loaded): Remove.
4310         (ppc_linux_spe_context_solib_unloaded): Remove.
4311         (ppc_linux_spe_context): Remove.
4312         (struct ppu2spu_cache): Remove.
4313         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4314         (struct ppu2spu_data): Remove.
4315         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4316         ppu2spu_unwind): Remove.
4317         (ppc_linux_init_abi): Remove Cell/B.E. support.
4318         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4319
4320         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4321         (rs6000/powerpc-cell64l-expedite): Likewise
4322         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4323         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4324         rs6000/powerpc-cell64l.xml.
4325         * features/rs6000/powerpc-cell32l.xml: Remove.
4326         * features/rs6000/powerpc-cell64l.xml: Likewise.
4327         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4328         * features/rs6000/powerpc-cell64l.c: Likewise.
4329         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4330         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4331         * regformats/reg-spu.dat: Remove.
4332
4333         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4334         * corelow.c (struct spuid_list): Remove.
4335         (add_to_spuid_list): Remove.
4336         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4337         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4338         (remote_protocol_features): Remove associated entries.
4339         (_initialize_remote): No longer initialize them.
4340         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4341         * linux-nat.c (SPUFS_MAGIC): Remove.
4342         (linux_proc_xfer_spu): Remove.
4343         (spu_enumerate_spu_ids): Remove.
4344         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4345         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4346         (linux_make_corefile_notes): No longer call it.
4347
4348         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4349         (cooked_write_test): Likewise.
4350
4351 2019-09-20  Tom Tromey  <tom@tromey.com>
4352
4353         * NEWS: Mention case-sensitivity of TUI commands.
4354         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4355         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4356         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4357
4358 2019-09-20  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui-source.c (tui_source_window::set_contents): Use
4361         make_unique_xstrdup.
4362         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4363         make_unique_xstrdup.
4364
4365 2019-09-20  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui-data.c: Remove separator comments.
4368         * tui/tui-layout.c: Remove separator comments.
4369         * tui/tui-win.c: Remove separator comments.
4370         * tui/tui-wingeneral.c: Remove separator comments.
4371
4372 2019-09-20  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui.h (strcat_to_buf): Don't declare.
4375         * tui/tui.c (strcat_to_buf): Remove.
4376
4377 2019-09-20  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4380         from "fullname".
4381         * tui/tui-source.c (tui_source_window::set_contents)
4382         (tui_source_window::location_matches_p)
4383         (tui_source_window::maybe_update): Update.
4384
4385 2019-09-20  Tom Tromey  <tom@tromey.com>
4386
4387         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4388         Update.
4389         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4390         prefix.
4391         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4392         (tui_data_window::line_from_reg_element_no)
4393         (tui_data_window::first_reg_element_no_inline)
4394         (tui_data_window::show_registers)
4395         (tui_data_window::show_register_group)
4396         (tui_data_window::display_registers_from)
4397         (tui_data_window::display_registers_from_line)
4398         (tui_data_window::first_data_item_displayed)
4399         (tui_data_window::delete_data_content_windows)
4400         (tui_data_window::erase_data_content)
4401         (tui_data_window::do_scroll_vertical)
4402         (tui_data_window::refresh_window)
4403         (tui_data_window::check_register_values): Update.
4404
4405 2019-09-20  Tom Tromey  <tom@tromey.com>
4406
4407         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4408         (struct tui_locator_window) <full_name, proc_name>: Now
4409         std::string.
4410         * tui/tui-stack.c (tui_locator_window::make_status_line)
4411         (tui_locator_window::set_locator_fullname)
4412         (tui_locator_window::set_locator_info): Update.
4413         * tui/tui-source.c (tui_source_window::set_contents)
4414         (tui_source_window::showing_source_p): Update.
4415
4416 2019-09-20  Tom Tromey  <tom@tromey.com>
4417
4418         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4419         Don't call tui_locator_win_info_ptr.
4420
4421 2019-09-20  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4424
4425 2019-09-20  Tom Tromey  <tom@tromey.com>
4426
4427         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4428         height for locator.
4429         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4430         * tui/tui-layout.c (show_source_disasm_command, show_data)
4431         (show_source_or_disasm_and_command): Use 1 as height for locator.
4432
4433 2019-09-20  Tom Tromey  <tom@tromey.com>
4434
4435         * tui/tui.c (tui_enable): Update.
4436         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4437         Update.
4438         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4439         Update.
4440         * tui/tui-data.c (win_resized): Now bool.
4441         (tui_win_resized): Return bool.
4442         (tui_set_win_resized_to): Accept a bool.
4443
4444 2019-09-20  Tom Tromey  <tom@tromey.com>
4445
4446         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4447         Change type of "refresh_values_only".
4448         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4449         type of "refresh_values_only".
4450
4451 2019-09-20  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4454         std::string.
4455         (tui_disassemble): Add "pos" parameter.
4456         (tui_disasm_window::set_contents): Simplify.
4457
4458 2019-09-20  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-winsource.h (struct tui_source_window_base)
4461         <show_source_content>: Now private.
4462         * tui/tui-winsource.c
4463         (tui_source_window_base::show_source_content): Don't handle empty
4464         content case.
4465
4466 2019-09-20  Tom Tromey  <tom@tromey.com>
4467
4468         * tui/tui-layout.c (show_source_disasm_command)
4469         (show_source_or_disasm_and_command): Don't call
4470         show_source_content.
4471
4472 2019-09-20  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4475         Declare.
4476         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4477         from tui_make_status_line.
4478         (tui_locator_window::rerender): Update.
4479
4480 2019-09-20  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4483         (tui_locator_window::rerender): Update.
4484
4485 2019-09-20  Tom Tromey  <tom@tromey.com>
4486
4487         * tui/tui-winsource.h (struct tui_source_window_base)
4488         <~tui_source_window_base>: Don't declare.
4489         <fullname>: Remove.
4490         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4491         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4492         member.
4493         * tui/tui-source.c (tui_source_window::set_contents): Update.
4494         (tui_source_window::location_matches_p)
4495         (tui_source_window::maybe_update): Update.
4496
4497 2019-09-20  Tom Tromey  <tom@tromey.com>
4498
4499         * tui/tui-winsource.h (~tui_source_element): Remove.
4500         (tui_source_element): Update.
4501         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4502         * tui/tui-winsource.c (tui_show_source_line): Update.
4503         * tui/tui-source.c (tui_source_window::set_contents): Update.
4504         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4505
4506 2019-09-20  Tom Tromey  <tom@tromey.com>
4507
4508         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4509         declare.
4510         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4511         tui_clear_source_windows_detail.
4512         * tui/tui-winsource.h (struct tui_source_window_base)
4513         <clear_detail>: Don't declare.
4514         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4515         Remove.
4516         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4517
4518 2019-09-20  Tom Tromey  <tromey@adacore.com>
4519
4520         PR ada/24919:
4521         * block.c (contained_in): Fix final return value.
4522
4523 2019-09-20  Alan Modra  <amodra@gmail.com>
4524
4525         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4526         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4527         (read_indirect_string_from_dwz): Use bfd accessor.
4528         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4529         * machoread.c (macho_symfile_read_all_oso): Likewise.
4530         * solib.c (solib_bfd_open): Likewise.
4531
4532 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4533
4534         * eval.c: Move declaration of overload_resolution to...
4535         * value.h: ...here.
4536
4537 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4538
4539         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4540         * arm-linux-tdep.c: Likewise.
4541         * arm-nbsd-nat.c: Likewise.
4542         * arm-tdep.h: Declare arm_apcs_32.
4543         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4544
4545 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4546
4547         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4548         * dwarf2read.h: Declare dwarf_always_disassemble.
4549
4550 2019-09-19  Tom de Vries  <tdevries@suse.de>
4551
4552         PR gdb/25009
4553         * source-cache.c (source_cache::ensure): Catch exception thrown during
4554         construction of the highlighter.
4555
4556 2019-09-18  Alan Modra  <amodra@gmail.com>
4557
4558         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4559         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4560         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4561         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4562         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4563         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4564         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4565         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4566         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4567         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4568         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4569         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4570         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4571         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4572         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4573         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4574         * mi/mi-interp.c: Update throughout for bfd section macro and
4575         function changes.
4576         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4577         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4578
4579 2019-09-18  Tom Tromey  <tom@tromey.com>
4580
4581         * NEWS: Add entry.
4582         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4583         call rl_initialize.
4584         (tui_enable): Do not call rl_initialize.
4585
4586 2019-09-18  Christian Groessler  <chris@groessler.org>
4587
4588         * alpha-linux-nat.c: Include gdbarch.h.
4589
4590 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4591
4592         * ui-file.c: Include cli/cli-style.h.
4593         (term_cli_styling): Remove cli_styling declaration.
4594
4595 2019-09-18  Alan Modra  <amodra@gmail.com>
4596
4597         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4598         to bfd_asymbol_section.
4599
4600 2019-09-18  Alan Modra  <amodra@gmail.com>
4601
4602         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4603         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4604         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4605
4606 2019-09-18  Alan Modra  <amodra@gmail.com>
4607
4608         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4609         * spu-linux-nat.c (spu_bfd_open): Likewise.
4610
4611 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4612
4613         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4614         to bool to match definition in dwarf2read.c.
4615
4616 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4617
4618         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4619         (print_signatures): Likewise.
4620         (trust_pad_over_xvs): Likewise.
4621         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4622         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4623         * arm-linux-nat.c (arm_apcs_32): Likewise.
4624         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4625         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4626         * arm-tdep.c (arm_debug): Likewise.
4627         (arm_apcs_32): Likewise.
4628         * auto-load.c (debug_auto_load): Likewise.
4629         (auto_load_gdb_scripts): Likewise.
4630         (global_auto_load): Likewise.
4631         (auto_load_local_gdbinit): Likewise.
4632         (auto_load_local_gdbinit_loaded): Likewise.
4633         * auto-load.h (global_auto_load): Likewise.
4634         (auto_load_local_gdbinit): Likewise.
4635         (auto_load_local_gdbinit_loaded): Likewise.
4636         * breakpoint.c (disconnected_dprintf): Likewise.
4637         (breakpoint_proceeded): Likewise.
4638         (automatic_hardware_breakpoints): Likewise.
4639         (always_inserted_mode): Likewise.
4640         (target_exact_watchpoints): Likewise.
4641         (_initialize_breakpoint): Update.
4642         * breakpoint.h (target_exact_watchpoints): Change to bool.
4643         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4644         * cli/cli-cmds.c (trace_commands): Likewise.
4645         * cli/cli-cmds.h (trace_commands): Likewise.
4646         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4647         to bool*.
4648         * cli/cli-logging.c (logging_overwrite): Change to bool.
4649         (logging_redirect): Likewise.
4650         (debug_redirect): Likewise.
4651         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4652         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4653         to bool.
4654         <boolean_option_def>: Update.
4655         (struct flag_option_def): Change default type of Context to bool
4656         from int.
4657         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4658         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4659         (get_setshow_command_value_string): Likewise.
4660         * cli/cli-style.c (cli_styling): Change to bool.
4661         (source_styling): Likewise.
4662         * cli/cli-style.h (source_styling): Likewise.
4663         (cli_styling): Likewise.
4664         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4665         to bool.
4666         * command.h (var_types): Update comment.
4667         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4668         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4669         bool.
4670         (debug_compile_cplus_scopes): Likewise.
4671         * compile/compile-internal.h (compile_debug): Likewise.
4672         * compile/compile.c (compile_debug): Likewise.
4673         (struct compile_options) <raw>: Likewise.
4674         * cp-support.c (catch_demangler_crashes): Likewise.
4675         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4676         (usr_cmd_cris_dwarf2_cfi): Likewise.
4677         * csky-tdep.c (csky_debug): Likewise.
4678         * darwin-nat.c (enable_mach_exceptions): Likewise.
4679         * dcache.c (dcache_enabled_p): Likewise.
4680         * defs.h (info_verbose): Likewise.
4681         * demangle.c (demangle): Likewise.
4682         (asm_demangle): Likewise.
4683         * dwarf-index-cache.c (debug_index_cache): Likewise.
4684         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4685         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4686         * dwarf2read.c (check_physname): Likewise.
4687         (use_deprecated_index_sections): Likewise.
4688         (dwarf_always_disassemble): Likewise.
4689         * eval.c (overload_resolution): Likewise.
4690         * event-top.c (set_editing_cmd_var): Likewise.
4691         (exec_done_display_p): Likewise.
4692         * event-top.h (set_editing_cmd_var): Likewise.
4693         (exec_done_display_p): Likewise.
4694         * exec.c (write_files): Likewise.
4695         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4696         (debug_fbsd_nat): Likewise.
4697         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4698         Likewise.
4699         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4700         <backtrace_past_entry> Likewise.
4701         * gdb-demangle.h (demangle): Likewise.
4702         (asm_demangle): Likewise.
4703         * gdb_bfd.c (bfd_sharing): Likewise.
4704         * gdbcore.h (write_files): Likewise.
4705         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4706         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4707         * gdbthread.h (print_thread_events): Likewise.
4708         * gdbtypes.c (opaque_type_resolution): Likewise.
4709         (strict_type_checking): Likewise.
4710         * gnu-nat.c (gnu_debug_flag): Likewise.
4711         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4712         * guile/scm-param.c (pascm_variable): Add boolval.
4713         (add_setshow_generic): Update.
4714         (pascm_param_value): Update.
4715         (pascm_set_param_value_x): Update.
4716         * hppa-tdep.c (hppa_debug): Change to bool..
4717         * infcall.c (may_call_functions_p): Likewise.
4718         (coerce_float_to_double_p): Likewise.
4719         (unwind_on_signal_p): Likewise.
4720         (unwind_on_terminating_exception_p): Likewise.
4721         * infcmd.c (startup_with_shell): Likewise.
4722         * inferior.c (print_inferior_events): Likewise.
4723         * inferior.h (startup_with_shell): Likewise.
4724         (print_inferior_events): Likewise.
4725         * infrun.c (step_stop_if_no_debug): Likewise.
4726         (detach_fork): Likewise.
4727         (debug_displaced): Likewise.
4728         (disable_randomization): Likewise.
4729         (non_stop): Likewise.
4730         (non_stop_1): Likewise.
4731         (observer_mode): Likewise.
4732         (observer_mode_1): Likewise.
4733         (set_observer_mode): Update.
4734         (sched_multi): Change to bool.
4735         * infrun.h (debug_displaced): Likewise.
4736         (sched_multi): Likewise.
4737         (step_stop_if_no_debug): Likewise.
4738         (non_stop): Likewise.
4739         (disable_randomization): Likewise.
4740         * linux-tdep.c (use_coredump_filter): Likewise.
4741         (dump_excluded_mappings): Likewise.
4742         * linux-thread-db.c (auto_load_thread_db): Likewise.
4743         (check_thread_db_on_load): Likewise.
4744         * main.c (captured_main_1): Update.
4745         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4746         xx2_opt, boolean_opt>: Change to bool.
4747         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4748         * maint.c (maintenance_profile_p): Likewise.
4749         (per_command_time): Likewise.
4750         (per_command_space): Likewise.
4751         (per_command_symtab): Likewise.
4752         * memattr.c (inaccessible_by_default): Likewise.
4753         * mi/mi-main.c (mi_async): Likewise.
4754         (mi_async_1): Likewise.
4755         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4756         * nat/fork-inferior.h (startup_with_shell): Likewise.
4757         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4758         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4759         * nios2-tdep.c (nios2_debug): Likewise.
4760         * or1k-tdep.c (or1k_debug): Likewise.
4761         * parse.c (parser_debug): Likewise.
4762         * parser-defs.h (parser_debug): Likewise.
4763         * printcmd.c (print_symbol_filename): Likewise.
4764         * proc-api.c (procfs_trace): Likewise.
4765         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4766         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4767         (set_parameter_value): Update.
4768         (add_setshow_generic): Update.
4769         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4770         to bool*.
4771         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4772         int*.
4773         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4774         * record-btrace.c (record_btrace_target::store_registers): Update.
4775         * record-full.c (record_full_memory_query): Change to bool.
4776         (record_full_stop_at_limit): Likewise.
4777         * record-full.h (record_full_memory_query): Likewise.
4778         * remote-notif.c (notif_debug): Likewise.
4779         * remote-notif.h (notif_debug): Likewise.
4780         * remote.c (use_range_stepping): Likewise.
4781         (interrupt_on_connect): Likewise.
4782         (remote_break): Likewise.
4783         * ser-tcp.c (tcp_auto_retry): Likewise.
4784         * ser-unix.c (serial_hwflow): Likewise.
4785         * skip.c (debug_skip): Likewise.
4786         * solib-aix.c (solib_aix_debug): Likewise.
4787         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4788         (spu_auto_flush_cache_p): Likewise.
4789         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4790         Likewise.
4791         (struct info_print_options) <quiet>: Likewise.
4792         * symfile-debug.c (debug_symfile): Likewise.
4793         * symfile.c (auto_solib_add): Likewise.
4794         (separate_debug_file_debug): Likewise.
4795         * symfile.h (auto_solib_add): Likewise.
4796         (separate_debug_file_debug): Likewise.
4797         * symtab.c (basenames_may_differ): Likewise.
4798         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4799         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4800         (struct info_types_options) <quiet>: Likewise.
4801         * symtab.h (demangle): Likewise.
4802         (basenames_may_differ): Likewise.
4803         * target-dcache.c (stack_cache_enabled_1): Likewise.
4804         (code_cache_enabled_1): Likewise.
4805         * target.c (trust_readonly): Likewise.
4806         (may_write_registers): Likewise.
4807         (may_write_memory): Likewise.
4808         (may_insert_breakpoints): Likewise.
4809         (may_insert_tracepoints): Likewise.
4810         (may_insert_fast_tracepoints): Likewise.
4811         (may_stop): Likewise.
4812         (auto_connect_native_target): Likewise.
4813         (target_stop_and_wait): Update.
4814         (target_async_permitted): Change to bool.
4815         (target_async_permitted_1): Likewise.
4816         (may_write_registers_1): Likewise.
4817         (may_write_memory_1): Likewise.
4818         (may_insert_breakpoints_1): Likewise.
4819         (may_insert_tracepoints_1): Likewise.
4820         (may_insert_fast_tracepoints_1): Likewise.
4821         (may_stop_1): Likewise.
4822         * target.h (target_async_permitted): Likewise.
4823         (may_write_registers): Likewise.
4824         (may_write_memory): Likewise.
4825         (may_insert_breakpoints): Likewise.
4826         (may_insert_tracepoints): Likewise.
4827         (may_insert_fast_tracepoints): Likewise.
4828         (may_stop): Likewise.
4829         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4830         (make_thread_apply_all_options_def_group): Change argument from int*
4831         to bool*.
4832         (thread_apply_all_command): Update.
4833         (print_thread_events): Change to bool.
4834         * top.c (confirm): Likewise.
4835         (command_editing_p): Likewise.
4836         (history_expansion_p): Likewise.
4837         (write_history_p): Likewise.
4838         (info_verbose): Likewise.
4839         * top.h (confirm): Likewise.
4840         (history_expansion_p): Likewise.
4841         * tracepoint.c (disconnected_tracing): Likewise.
4842         (circular_trace_buffer): Likewise.
4843         * typeprint.c (print_methods): Likewise.
4844         (print_typedefs): Likewise.
4845         * utils.c (debug_timestamp): Likewise.
4846         (sevenbit_strings): Likewise.
4847         (pagination_enabled): Likewise.
4848         * utils.h (sevenbit_strings): Likewise.
4849         (pagination_enabled): Likewise.
4850         * valops.c (overload_resolution): Likewise.
4851         * valprint.h (struct value_print_options) <prettyformat_arrays,
4852         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4853         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4854         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4855         Likewise.
4856         * windows-nat.c (new_console): Likewise.
4857         (cygwin_exceptions): Likewise.
4858         (new_group): Likewise.
4859         (debug_exec): Likewise.
4860         (debug_events): Likewise.
4861         (debug_memory): Likewise.
4862         (debug_exceptions): Likewise.
4863         (useshell): Likewise.
4864         * windows-tdep.c (maint_display_all_tib): Likewise.
4865         * xml-support.c (debug_xml): Likewise.
4866
4867 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4868
4869         * source.c (prepare_path_for_appending): New function.
4870         (openp): Make use of new function.
4871         (find_and_open_source): Search for the compilation directory and
4872         source file as a relative path beneath the directory search path.
4873
4874 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4875
4876         * source-cache.c (source_cache::get_line_charpos): Catch
4877         exceptions and return false, this matches the behaviour documented
4878         in the header file.
4879
4880 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4881
4882         * ada-tasks.c (info_task): Remove quoting of the task's name.
4883
4884 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4885
4886         * symfile.c (auto_solib_add): Replace comment with a reference
4887         to the header file.
4888
4889 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4890
4891         * NEWS: Mention that gdb can now be compiled with Python 3
4892         on Windows.
4893
4894 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * maint.c (maint_print_section_data::maint_print_section_data):
4897         Force use of 'float log10 (float)' by casting the argument to
4898         float.
4899
4900 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         * maint.c: Add 'cmath' include.
4903         (struct maint_print_section_data): New structure.
4904         (print_section_index): New function.
4905         (print_bfd_section_info): Add header comment, small whitespace
4906         cleanup, and update to call new print_section_index function.
4907         (print_objfile_section_info): Likewise.
4908         (maint_obj_section_from_bfd_section): New function.
4909         (print_bfd_section_info_maybe_relocated): New function.
4910         (maintenance_info_sections): Add header comment, always use
4911         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4912
4913 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4916         inner scope, add check that the objfile has psymtabs before
4917         checking psymtabs_addrmap.
4918         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4919
4920 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4921
4922         * NEWS: Announce that Ada task names are now shown at more places,
4923         and between quotes (except in info task output).
4924         * gdb/ada-tasks.c (task_to_str): New function.
4925         (display_current_task_id): Call task_to_str.
4926         (task_command_1): Likewise.
4927         (print_ada_task_info): In non-mi mode, Properly align headers and data
4928         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4929
4930 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4931
4932         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4933         prstatus.pr_lwp.pr_info instead of making it up.
4934
4935 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4936
4937         * auto-load.c (auto_load_expand_dir_vars): Update.
4938         * defs.h (gdb_datadir): Change to std::string.
4939         (python_libdir): Likewise.
4940         (relocate_gdb_directory): Change return type to std::string.
4941         * guile/guile.c (gdbscm_data_directory): Update.
4942         (initialize_scheme_side): Update.
4943         * jit.c (jit_reader_dir): Change to std::string.
4944         (jit_reader_load_command): Update.
4945         * main.c (gdb_datadir): Change to std::string.
4946         (python_libdir): Likewise.
4947         (set_gdb_data_directory): Update.
4948         (relocate_path): Change to return std::string.
4949         (relocate_gdb_directory): Change to return std::string.
4950         (relocate_gdbinit_path_maybe_in_datadir): Update.
4951         (captured_main_1): Update.
4952         * python/python.c (do_start_initialization): Update.
4953         * top.c (show_gdb_datadir): Update.
4954         * xml-syscall.c (xml_init_syscalls_info): Update.
4955         (init_syscalls_info): Update.
4956
4957 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4958
4959         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4960         out of get_init_files.
4961         (get_init_files): Update.
4962
4963 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4964
4965         * main.c (get_init_files): Change to use std::string.
4966         (captured_main_1): Update.
4967         (print_gdb_help): Update.
4968
4969 2019-09-11  Ali Tamur  <tamur@google.com>
4970
4971         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4972         implementation.
4973
4974 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4975
4976         * dbxread.c (read_dbx_symtab): Update.
4977         * dwarf2read.c (load_partial_dies): Update.
4978         * mdebugread.c (parse_partial_symbols): Update.
4979         (handle_psymbol_enumerators): Update.
4980         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4981         * psymtab.c (add_psymbol_to_bcache): Likewise.
4982         (add_psymbol_to_list): Likewise.
4983         * symtab.c (symbol_set_names): Likewise.
4984         * symtab.h (symbol_set_names): Likewise.
4985         * xcoffread.c (scan_xcoff_symtab): Update.
4986
4987 2019-09-11  Tom Tromey  <tom@tromey.com>
4988
4989         * symfile-mem.c (symbol_file_add_from_memory): Use
4990         bfd_set_filename.
4991         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4992         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4993
4994 2019-09-10  Tom Tromey  <tromey@adacore.com>
4995
4996         * dwarf-index-write.c (write_psymbols): Extend error message.
4997         (debug_names::insert): Add Ada code.
4998         (debug_names::write_psymbols): Remove Ada check.
4999         (debug_names) <m_string_obstack>: New member.
5000         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5001         (gdb_index_symbol_name_matcher::matches): Remove.
5002         (mapped_index_base::find_name_components_bounds): Add "lang"
5003         parameter.
5004         (mapped_index_base::build_name_components): Also split names
5005         according to Ada syntax.
5006         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
5007         type of "match_callback".
5008         (check_match, check_find_bounds_finds)
5009         (dw2_expand_symtabs_matching): Update.
5010         (dw2_debug_names_iterator): Add new constructor.
5011         (dw2_debug_names_map_matching_symbols): New function.
5012         (dw2_debug_names_expand_symtabs_matching): Update.
5013         (dwarf2_debug_names_functions): Use
5014         dw2_debug_names_map_matching_symbols.
5015
5016 2019-09-10  Tom Tromey  <tromey@adacore.com>
5017
5018         * dwarf2read.c (dw2_get_file_names_reader): Add the
5019         CU's file name to the results.
5020
5021 2019-09-10  Tom Tromey  <tromey@adacore.com>
5022
5023         * ada-lang.c (add_nonlocal_symbols): Combine calls to
5024         map_matching_symbols.  Update.
5025         * dwarf2read.c (dw2_map_matching_symbols): Update.
5026         * psymtab.c (match_partial_symbol): Change type; update.
5027         (psym_map_matching_symbols): Likewise.
5028         * symfile-debug.c (debug_qf_map_matching_symbols): Change
5029         type; update.
5030         * symfile.h (struct quick_symbol_functions)
5031         <map_matching_symbols>: Change "name" to be a lookup_name_info.
5032         Remove "match".
5033
5034 2019-09-10  Tom Tromey  <tromey@adacore.com>
5035
5036         * psymtab.c (map_block): Remove.
5037         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5038         * symtab.c (iterate_over_symbols_terminated): New function.
5039         * symtab.c (iterate_over_symbols_terminated): Declare.
5040
5041 2019-09-10  Tom Tromey  <tromey@adacore.com>
5042
5043         * ada-lang.c (ada_iterate_over_symbols): Return bool.
5044         * language.h (struct language_defn) <la_iterate_over_symbols>:
5045         Return bool.
5046         * symtab.c (iterate_over_symbols): Return bool.
5047         * symtab.h (iterate_over_symbols): Return bool.
5048
5049 2019-09-10  Tom Tromey  <tromey@adacore.com>
5050
5051         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5052         (add_nonlocal_symbols): Update.
5053         * dwarf2read.c (dw2_map_matching_symbols): Change type.
5054         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5055         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5056         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5057         Change type of "callback".  Remove "data".
5058
5059
5060 2019-09-09  Ali Tamur  <tamur@google.com>
5061
5062         * dwarf2read.c (comp_unit_head): Update comment.
5063         (dwarf2_dwo_name): New function declaration.
5064         (dwarf_unit_type_name): New function declaration.
5065         (read_comp_unit_head): Add support for new compilation units,
5066         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5067         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5068         (currently named as "signature") in their header. Also clarify error
5069         messages.
5070         (lookup_dwo_id): New function. Returns the dwo id of the given
5071         compile unit.
5072         (lookup_dwo_unit): Use the new lookup_dwo_id function.
5073         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5074         functions.
5075         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5076         (dwarf2_dwo_name): Get the dwo name if present.
5077         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5078         purposes.
5079
5080 2019-09-09  Tom Tromey  <tom@tromey.com>
5081
5082         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5083
5084 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5085
5086         * python/python.c (do_start_initialization): Make progname_copy static,
5087         to avoid a leak report.
5088
5089 2019-09-08  Tom Tromey  <tom@tromey.com>
5090
5091         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5092
5093 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5094
5095         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5096         Change type to gdb::optional<block_enum>.
5097         (dw2_symtab_iter_init): Change block_index parameter type
5098         to gdb::optional<block_enum>.
5099         (dw2_lookup_symbol): Change block_index parameter
5100         type to block_enum.c
5101         (dw2_debug_names_lookup_symbol): Likewise.
5102         * psymtab.c (psym_lookup_symbol): Likewise.
5103         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5104         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5105         Likewise.
5106
5107 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5108
5109         * defs.h (relocate_gdb_directory): Change int to bool in
5110         signature and rename flag to relocatable.
5111         * main.c (relocate_path): Likewise.
5112         (relocate_gdb_directory): Likewise.
5113
5114 2019-09-06  Alan Modra  <amodra@gmail.com>
5115
5116         * coffread.c (coff_symfile_read): Constify filename variable.
5117         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5118         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5119         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5120         * solib.c (reload_shared_libraries_1): Likewise.
5121         * symfile.c (reread_symbols): Likewise.
5122         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5123         * solib-darwin.c (darwin_bfd_open): Likewise.
5124         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5125
5126 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5127
5128         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5129         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5130
5131 2019-09-03  Tom Tromey  <tromey@adacore.com>
5132
5133         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5134         types.
5135         (has_negatives): Unbias a range type bound.
5136         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5137         * gdbtypes.c (operator==): Handle new field.
5138         (create_range_type): Add "bias" parameter.
5139         (create_static_range_type, resolve_dynamic_range): Update.
5140         * gdbtypes.h (struct range_bounds) <bias>: New member.
5141         (create_range_type): Add bias parameter.
5142         * printcmd.c (print_scalar_formatted): Unbias range types.
5143         * value.c (unpack_long): Unbias range types.
5144         (pack_long): Bias range types.
5145
5146 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5147
5148         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5149         probe arguments.
5150
5151 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5152
5153         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5154         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5155         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5156         (compile_probe_arg): Likewise.
5157         * probe.h (get_argument_count): Likewise.
5158         * solib-svr4.c (solib_event_probe_action): Likewise.
5159         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5160
5161 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5162
5163         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5164         code to here...
5165         (svr4_create_solib_event_breakpoints): ...from here.
5166
5167 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5168
5169         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5170         suffix from warning message.
5171
5172 2019-08-30  Tom Tromey  <tom@tromey.com>
5173
5174         * tui/tui-winsource.h (struct tui_source_window_base)
5175         <refresh_all>: Don't declare.
5176         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5177         Remove.
5178         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5179         tui_show_locator_content.
5180         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5181         declare.
5182         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5183         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5184         declare.
5185
5186 2019-08-30  Tom Tromey  <tom@tromey.com>
5187
5188         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5189
5190 2019-08-30  Tom Tromey  <tom@tromey.com>
5191
5192         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5193         Remove unnecessary forward declarations.
5194
5195 2019-08-30  Tom Tromey  <tom@tromey.com>
5196
5197         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5198         rerender.
5199         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5200         tui_show_locator_content.
5201
5202 2019-08-30  Tom Tromey  <tom@tromey.com>
5203
5204         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5205         (tui_locator_window::rerender): Rewrite using body of previous
5206         tui_show_locator_content.
5207
5208 2019-08-30  Tom Tromey  <tom@tromey.com>
5209
5210         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5211         set_locator_fullname>: New methods.
5212         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5213         Rename from tui_set_locator_fullname.
5214         (tui_locator_window::set_locator_info): Rename from
5215         tui_set_locator_info.  Return bool.
5216         (tui_update_locator_fullname, tui_show_frame_info): Update.
5217
5218 2019-08-30  Tom Tromey  <tom@tromey.com>
5219
5220         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5221
5222 2019-08-30  Tom Tromey  <tom@tromey.com>
5223
5224         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5225         call touchwin.
5226
5227 2019-08-30  Tom Tromey  <tom@tromey.com>
5228
5229         * tui/tui-wingeneral.c (box_win): Assume win_info and
5230         win_info->handle cannot be NULL.
5231
5232 2019-08-30  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5235         refresh_window>: Declare.
5236         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5237         resize.
5238         (tui_data_item_window::rerender): Rename from
5239         tui_display_register.
5240         (tui_data_item_window::refresh_window): New method.
5241         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5242         no-op.
5243
5244 2019-08-30  Tom Tromey  <tom@tromey.com>
5245
5246         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5247         regs_column_count, current_group>: Move later.  Now private.
5248         <get_current_group>: New method.
5249         * tui/tui-regs.c (tui_reg_command): Update.
5250         * tui/tui-layout.c (tui_set_layout): Update.
5251
5252 2019-08-30  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5255         (tui_data_window::rerender): Don't call
5256         check_and_display_highlight_if_needed.
5257         (tui_data_window::refresh_all): Remove call to
5258         erase_data_content.
5259
5260 2019-08-30  Tom Tromey  <tom@tromey.com>
5261
5262         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5263         (tui_data_window::display_registers_from)
5264         (tui_data_window::display_reg_element_at_line)
5265         (tui_data_window::display_registers_from_line): Remove checks of
5266         "empty".
5267
5268 2019-08-30  Tom Tromey  <tom@tromey.com>
5269
5270         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5271         Don't declare.
5272         * tui/tui-regs.c (tui_data_window::show_registers): Call
5273         rerender.
5274         (tui_data_window::rerender): Rename from display_all_data.
5275         (tui_data_window::rerender): Remove old implementation.
5276
5277 2019-08-30  Tom Tromey  <tom@tromey.com>
5278
5279         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5280         text.
5281         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5282
5283 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5284             Sergio Durigan Junior  <sergiodj@redhat.com>
5285
5286         PR win32/24284
5287         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5288
5289 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5290
5291         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5292         when searching for types.
5293
5294 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5295
5296         * f-lang.c (f_language_defn): Use f_print_typedef.
5297         * f-lang.h (f_print_typedef): Declare.
5298         * f-typeprint.c (f_print_typedef): Define.
5299
5300 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5301
5302         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5303
5304 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5305
5306         * cli/cli-utils.c (info_print_options_defs): Delete.
5307         (make_info_print_options_def_group): Delete.
5308         (extract_info_print_options): Delete.
5309         (info_print_command_completer): Delete.
5310         (info_print_args_help): Add extra parameter, and optionally
5311         include text about -n flag.
5312         * cli/cli-utils.h (struct info_print_options): Delete.
5313         (extract_info_print_options): Delete declaration.
5314         (info_print_command_completer): Delete declaration.
5315         (info_print_args_help): Add extra parameter, extend header
5316         comment.
5317         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5318         search_symbols.
5319         * stack.c (struct info_print_options): New type.
5320         (info_print_options_defs): New file scoped variable.
5321         (make_info_print_options_def_group): New static function.
5322         (info_print_command_completer): New static function.
5323         (info_locals_command): Update to use new local functions.
5324         (info_args_command): Likewise.
5325         (_initialize_stack): Add extra parameter to calls to
5326         info_print_args_help.
5327         * symtab.c (search_symbols): Add extra parameter, use this to
5328         possibly excluse non-debug symbols.
5329         (symtab_symbol_info): Add extra parameter, which is passed on to
5330         search_symbols.
5331         (struct info_print_options): New type.
5332         (info_print_options_defs): New file scoped variable.
5333         (make_info_print_options_def_group): New static function.
5334         (info_print_command_completer): New static function.
5335         (info_variables_command): Update to use local functions, and pass
5336         extra parameter through to symtab_symbol_info.
5337         (info_functions_command): Likewise.
5338         (info_types_command): Pass additional argument through to
5339         symtab_symbol_info.
5340         (rbreak_command): Pass extra argument to search_symbols.
5341         (_initialize_symtab): Add extra arguments for calls to
5342         info_print_args_help, and update help text for 'info variables',
5343         'whereis', and 'info functions' commands.
5344         * symtab.h (search_symbols): Add extra argument to declaration.
5345         * NEWS: Mention new flags.
5346
5347 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5348
5349         * symtab.c (lookup_static_symbol): Call the new function (and move
5350         it down to be next to lookup_global_symbol).
5351         (struct global_sym_lookup_data): Add block_enum member and rename to...
5352         (struct global_or_static_sym_lookup_data): ...this.
5353         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5354         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5355         (lookup_symbol_global_or_static_iterator_cb): ...this.
5356         (lookup_global_or_static_symbol): New function.
5357         (lookup_global_symbol): Call new function.
5358
5359 2019-08-26  Tom de Vries  <tdevries@suse.de>
5360
5361         PR c++/24852
5362         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5363         when pc_probe.prob == NULL.
5364
5365 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5366
5367         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5368         variable symbol_linkage to symbol_linkage_.
5369
5370 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5371
5372         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5373         represent whether the symbol is static, dynamic, or we don't
5374         know.
5375
5376 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5377
5378         * gdb/rx-tdep.c (rx_register_names): New.
5379         (rx_register_name): Delete.
5380         (rx_psw_type): Delete.
5381         (rx_fpsw_type): Delete.
5382         (rx_register_type): Delete.
5383         (rx_gdbarch_init): Convert target-descriptions.
5384         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5385         * gdb/features/Makefile: Add rx.xml.
5386         * gdb/features/rx.xml: New.
5387         * gdb/features/rx.c: Generated.
5388         * gdb/NEWS: Mention target description support.
5389
5390 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5391
5392         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5393         *slot_ptr.
5394
5395 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5396
5397         * configure.ac: Don't check for 'dlfcn.h' (moved to
5398         gdbsupport/common.m4).
5399         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5400         'gdbsupport/'.
5401         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5402         * compile/compile-c-support.c: Include
5403         'gdbsupport/gdb-dlfcn.h'.
5404         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5405         * gdb-dlfcn.c: Move to...
5406         * gdbsupport/gdb-dlfcn.c: ... here.
5407         * gdb-dlfcn.h: Move to...
5408         * gdbsupport/gdb-dlfcn.h: ... here.
5409
5410 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5411
5412         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5413         the offset field signed.
5414
5415 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5416
5417         * python/lib/gdb/__init__.py (_execute_file): New function.
5418         * python/python.c (python_run_simple_file): Call gdb._execute_file
5419         on Windows.
5420
5421 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5422
5423         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5424         all uses as this was never set to anything but a zero value.
5425
5426 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5427
5428         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5429
5430 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5431
5432         * tui/tui-data.h (tui_gen_win_info): Add an =default
5433         move constructor, required by some GCC versions.
5434
5435 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5436
5437         * go32-nat.c (go32_sysinfo): Add hygon_p.
5438
5439 2019-08-20  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5442         line_from_reg_element_no, first_reg_element_no_inline,
5443         display_all_data, delete_data_content_windows,
5444         erase_data_content>: Now private.
5445
5446 2019-08-20  Tom Tromey  <tom@tromey.com>
5447
5448         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5449         (tui_unhighlight_win, tui_highlight_win)
5450         (tui_win_info::make_window): Update.
5451         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5452
5453 2019-08-20  Tom Tromey  <tom@tromey.com>
5454
5455         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5456         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5457         (MAX_PID_WIDTH): Move to tui-stack.c.
5458         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5459         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5460         (MAX_PID_WIDTH): Move from tui-data.h.
5461
5462 2019-08-20  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5465         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5466         (box_win): Update.
5467         (tui_gen_win_info::make_window): Rename from tui_make_window.
5468         (tui_win_info::make_window): New method.
5469         (tui_gen_win_info::make_visible): Update.
5470         * tui/tui-source.c (tui_source_window::set_contents): Update.
5471         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5472         (tui_data_window::display_registers_from): Update.
5473         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5474         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5475         Declare.
5476         <can_box>: Remove.
5477         <title>: Remove.
5478         (struct tui_win_info) <make_window>: Declare.
5479         <can_box>: Now virtual.
5480         <title>: New member.
5481         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5482         * tui/tui-command.c (tui_cmd_window::resize): Update.
5483
5484 2019-08-20  Tom Tromey  <tom@tromey.com>
5485
5486         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5487         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5488         (tui_data_window::check_register_values): Update.
5489
5490 2019-08-20  Tom Tromey  <tom@tromey.com>
5491
5492         * tui/tui-regs.h (struct tui_data_window): Use
5493         DISABLE_COPY_AND_ASSIGN.
5494         <regs_content>: Change type, removing unique_ptr.
5495         <tui_data_window>: Add move constructor.
5496         * tui/tui-regs.c (tui_data_window::show_registers)
5497         (tui_data_window::show_register_group)
5498         (tui_data_window::display_registers_from)
5499         (tui_data_window::display_registers_from)
5500         (tui_data_window::first_data_item_displayed)
5501         (tui_data_window::delete_data_content_windows)
5502         (tui_data_window::rerender, tui_data_window::refresh_window)
5503         (tui_data_window::check_register_values): Update.
5504
5505 2019-08-20  Tom Tromey  <tom@tromey.com>
5506
5507         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5508         show_register_group>: Declare.
5509         (tui_show_register_group): Don't declare.
5510         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5511         tui_show_registers.
5512         (tui_data_window::show_register_group): Rename from
5513         tui_show_register_group.
5514         (tui_data_window::check_register_values, tui_reg_command):
5515         Update.
5516         * tui/tui-layout.c (tui_set_layout): Update.
5517
5518 2019-08-20  Tom Tromey  <tom@tromey.com>
5519
5520         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5521         Declare.
5522         (tui_check_register_values): Don't declare.
5523         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5524         from tui_check_register_values.
5525         * tui/tui-hooks.c (tui_register_changed): Update.
5526
5527 2019-08-20  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-regs.c (tui_reg_layout): Move later.
5530         (tui_show_registers): Don't enable TUI mode or change layout.
5531
5532 2019-08-20  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-regs.h (struct tui_data_item_window)
5535         <~tui_data_item_window>: Remove.
5536         <content>: Now a unique_xmalloc_ptr.
5537         * tui/tui-regs.c (tui_register_format): Return a
5538         unique_xmalloc_ptr.
5539         (tui_get_register): Update.
5540         (~tui_data_item_window): Remove.
5541         (tui_data_window::display_registers_from, tui_display_register):
5542         Update.
5543         * tui/tui-io.h (tui_expand_tabs): Update.
5544         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5545         Remove "col" parameter.
5546
5547 2019-08-20  Tom Tromey  <tom@tromey.com>
5548
5549         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5550         field.
5551         * tui/tui-regs.c (~tui_data_item_window): Update.
5552
5553 2019-08-20  Tom Tromey  <tom@tromey.com>
5554
5555         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5556         earlier.
5557
5558 2019-08-20  Tom Tromey  <tom@tromey.com>
5559
5560         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5561
5562 2019-08-20  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui-source.h (struct tui_source_window): Update.
5565         * tui/tui-regs.c (tui_show_registers): Update.
5566         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5567         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5568         (NO_REGS_STRING): Remove defines.
5569
5570 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5571
5572         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5573         unnecessary thread walk if remote doesn't support the packet.
5574
5575 2019-08-19  Tom Tromey  <tromey@adacore.com>
5576
5577         * python/py-value.c (value_has_field): Fix indentation.
5578
5579 2019-08-19  Tom Tromey  <tromey@adacore.com>
5580
5581         * printcmd.c (do_one_display, info_display_command): Update.
5582         * block.h (contained_in): Return bool.  Add allow_nested
5583         parameter.
5584         * block.c (contained_in): Return bool.  Add allow_nested
5585         parameter.
5586
5587 2019-08-19  Tom Tromey  <tom@tromey.com>
5588
5589         * configure: Rebuild.
5590         * configure.ac: Disallow the combination of -static-libstdc++ and
5591         source highlight.
5592         * source-cache.c (get_language_name): Handle rust.
5593         (source_cache::get_source_lines): Ignore highlighting exceptions.
5594
5595 2019-08-16  Tom Tromey  <tom@tromey.com>
5596
5597         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5598         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5599         (struct tui_source_window_base) <make_visible, refresh_window,
5600         resize>: Remove methods.
5601         <execution_info>: Remove field.
5602         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5603         (tui_show_source_line, tui_source_window_base)
5604         (~tui_source_window_base): Update.
5605         (tui_source_window_base::resize)
5606         (tui_source_window_base::make_visible)
5607         (tui_source_window_base::refresh_window): Remove.
5608         (tui_source_window_base::update_exec_info): Update.
5609         * tui/tui-source.c (tui_source_window::set_contents): Update.
5610         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5611
5612 2019-08-16  Tom Tromey  <tom@tromey.com>
5613
5614         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5615         deprecated_query_hook.
5616
5617 2019-08-16  Tom Tromey  <tom@tromey.com>
5618
5619         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5620         (tui_update_source_windows_with_line): Update.
5621         * tui/tui-source.h (struct tui_source_window)
5622         <show_symtab_source>: Declare.
5623         (tui_show_symtab_source): Don't declare.
5624         * tui/tui-source.c (tui_show_symtab_source): Rename from
5625         tui_show_symtab_source.
5626
5627 2019-08-16  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-winsource.h (struct tui_source_window_base)
5630         <set_contents>: Declare.
5631         * tui/tui-winsource.c
5632         (tui_source_window_base::update_source_window_as_is): Update.
5633         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5634         Declare.
5635         (tui_set_source_content): Don't declare.
5636         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5637         tui_set_source_content.
5638         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5639         Declare.
5640         (tui_set_disassem_content): Don't declare.
5641         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5642         tui_set_disassem_content.
5643
5644 2019-08-16  Tom Tromey  <tom@tromey.com>
5645
5646         * tui/tui-winsource.h (struct tui_source_window_base)
5647         <update_breakpoint_info>: Declare.
5648         (tui_update_breakpoint_info): Don't declare.
5649         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5650         (tui_update_all_breakpoint_info): Update.
5651         (tui_source_window_base::update_breakpoint_info): Rename from
5652         tui_update_breakpoint_info.
5653         (tui_source_window_base::update_exec_info): Update.
5654
5655 2019-08-16  Tom Tromey  <tom@tromey.com>
5656
5657         * tui/tui-winsource.h (struct tui_source_window_base)
5658         <update_source_window>: Declare.
5659         (tui_update_source_window): Don't declare.
5660         * tui/tui-winsource.c
5661         (tui_source_window_base::update_source_window): Rename from
5662         tui_update_source_window.
5663         (tui_source_window_base::rerender): Update.
5664         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5665         * tui/tui-disasm.c (tui_show_disassem)
5666         (tui_show_disassem_and_update_source)
5667         (tui_disasm_window::maybe_update): Update.
5668
5669 2019-08-16  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-winsource.h (struct tui_source_window_base)
5672         <update_source_window_as_is>: Declare.
5673         (tui_update_source_window_as_is): Don't declare.
5674         * tui/tui-winsource.c (tui_update_source_window): Update
5675         (tui_source_window_base::update_source_window_as_is): Rename from
5676         tui_update_source_window_as_is.
5677         (tui_source_window_base::refill): Update.
5678         * tui/tui-source.c (tui_show_symtab_source): Update.
5679         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5680         Update.
5681
5682 2019-08-16  Tom Tromey  <tom@tromey.com>
5683
5684         * tui/tui-winsource.h (tui_update_source_window)
5685         (tui_update_source_window_as_is): Remove "noerror" parameter.
5686         * tui/tui-winsource.c (tui_update_source_window)
5687         (tui_update_source_window_as_is): Remove "noerror" parameter.
5688         (tui_update_source_windows_with_addr)
5689         (tui_update_source_windows_with_line)
5690         (tui_source_window_base::rerender)
5691         (tui_source_window_base::refill): Update.
5692         * tui/tui-source.h (tui_set_source_content)
5693         (tui_show_symtab_source): Remove "noerror" parameter.
5694         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5695         parameter.
5696         (tui_show_symtab_source): Likewise.
5697         (tui_source_window::maybe_update): Update.
5698         * tui/tui-disasm.c (tui_show_disassem)
5699         (tui_show_disassem_and_update_source)
5700         (tui_disasm_window::do_scroll_vertical)
5701         (tui_disasm_window::maybe_update): Update.
5702
5703 2019-08-16  Tom Tromey  <tom@tromey.com>
5704
5705         * tui/tui.c (tui_is_window_visible): Update.
5706         * tui/tui-wingeneral.c (tui_make_window)
5707         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5708         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5709         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5710         (tui_set_win_height_command, parse_scrolling_args): Update.
5711         * tui/tui-source.c (tui_source_window::style_changed): Update.
5712         * tui/tui-regs.c (tui_show_registers)
5713         (tui_data_window::first_data_item_displayed)
5714         (tui_data_window::delete_data_content_windows)
5715         (tui_check_register_values, tui_reg_command): Update.
5716         * tui/tui-disasm.c (tui_show_disassem): Update.
5717         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5718         method.
5719         <is_visible>: Remove field.
5720         * tui/tui-data.c (tui_next_win, tui_prev_win)
5721         (tui_delete_invisible_windows): Update.
5722
5723 2019-08-16  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-winsource.h (struct tui_source_window_base)
5726         <m_has_locator>: Remove.
5727         * tui/tui-layout.c (show_source_disasm_command, show_data)
5728         (show_source_or_disasm_and_command): Update.
5729
5730 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5731
5732         * NEWS (Other MI changes): New subsection.
5733         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5734         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5735         * arch-utils.c (default_get_pc_address_flags): New function.
5736         * arch-utils.h (default_get_pc_address_flags): New declaration.
5737         * gdbarch.sh: Add get_pc_address_flags.
5738         * gdbarch.c: Regenerate.
5739         * gdbarch.h: Likewise.
5740         * stack.c (print_pc): New function.
5741         (print_frame_info) (print_frame): Call print_pc.
5742
5743 2019-08-16  Tom de Vries  <tdevries@suse.de>
5744
5745         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5746         print_objfile_section_info.
5747
5748 2019-08-15  Tom Tromey  <tom@tromey.com>
5749
5750         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5751         calling update_cmdwin_start_line.
5752         * tui/tui-winsource.h (struct tui_source_window_base)
5753         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5754         <rerender>: Declare.
5755         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5756         Call rerender.
5757         (tui_source_window_base::set_new_height): Remove.
5758         (tui_source_window_base::rerender): Rename from
5759         do_make_visible_with_new_height.
5760         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5761         resize method.
5762         (tui_win_info::make_invisible_and_set_new_height)
5763         (tui_win_info::make_visible_with_new_height): Remove.
5764         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5765         Declare.
5766         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5767         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5768         do_make_visible_with_new_height>: Don't declare.
5769         <rerender>: Declare.
5770         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5771         set_new_height.
5772         (tui_data_window::do_make_visible_with_new_height): Remove.
5773         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5774         call tui_show_locator_content.
5775         (tui_gen_win_info::resize): Call rerender.
5776         (show_source_or_disasm_and_command): Don't call
5777         tui_show_locator_content.
5778         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5779         method.
5780         (struct tui_win_info) <rerender>: Declare.
5781         <set_new_height, make_invisible_and_set_new_height,
5782         make_visible_with_new_height>: Don't declare.
5783         * tui/tui-data.c (tui_win_list::rerender): New method.
5784         * tui/tui-command.h (struct tui_cmd_window)
5785         <do_make_visible_with_new_height>: Don't declare.
5786         * tui/tui-command.c
5787         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5788
5789 2019-08-15  Tom Tromey  <tromey@adacore.com>
5790
5791         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5792         * ada-lang.c (ada_enum_name): Likewise.
5793
5794 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5795
5796         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5797         leading underscore.
5798         (GdbOutputErrorFile): Likewise.
5799         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5800         accordingly.
5801         (execute_unwinders): Rename to have a leading underscore.
5802         (auto_load_packages): Likewise.
5803         (global scope): Adjust call to auto_load_packages accordingly.
5804         (GdbSetPythonDirectory): Likewise.
5805         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5806         instead of execute_unwinders.
5807
5808 2019-08-15  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5811         (show_data): Don't change window visibility.
5812         (tui_gen_win_info::resize): Remove special case for command
5813         window.  Use wresize, when available.
5814         (show_source_or_disasm_and_command): Don't change window
5815         visibility.
5816         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5817         <make_visible>: New method.
5818         * tui/tui-command.c (tui_cmd_window::resize): New method.
5819
5820 2019-08-15  Tom Tromey  <tom@tromey.com>
5821
5822         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5823         (struct tui_source_windows): New.
5824         * tui/tui-winsource.c (tui_display_main): Update.
5825         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5826         (new_height_ok, parse_scrolling_args): Update.
5827         * tui/tui-layout.c (show_layout, show_data): Update.
5828         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5829         (tui_add_to_source_windows): Don't declare.
5830         * tui/tui-data.c (source_windows, tui_source_windows)
5831         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5832
5833 2019-08-15  Tom Tromey  <tom@tromey.com>
5834
5835         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5836         Rename from reset.
5837         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5838         * tui/tui-layout.c (show_source_disasm_command, show_data):
5839         Update.
5840         (tui_gen_win_info::resize): Rename.
5841         (show_source_or_disasm_and_command): Update.
5842         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5843         reset.
5844
5845 2019-08-15  Tom Tromey  <tom@tromey.com>
5846
5847         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5848         * tui/tui-interp.c (tui_interp::init): Don't call
5849         tui_initialize_static_data.
5850         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5851
5852 2019-08-15  Tom Tromey  <tom@tromey.com>
5853
5854         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5855         examine tui_win_list.
5856
5857 2019-08-15  Tom Tromey  <tom@tromey.com>
5858
5859         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5860         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5861         tui_clear_source_content.
5862         (tui_clear_source_content): Remove.
5863         (tui_source_window_base::do_erase_source_content): Hoist call to
5864         content.clear().
5865         * tui/tui-stack.c (tui_show_frame_info): Don't call
5866         tui_clear_source_content.
5867
5868 2019-08-15  Tom Tromey  <tom@tromey.com>
5869
5870         * tui/tui-winsource.h (struct tui_source_window_base)
5871         <do_erase_source_content>: New method.
5872         <erase_source_content>: New method.
5873         (tui_erase_source_content): Don't declare.
5874         * tui/tui-winsource.c (tui_clear_source_content): Update.
5875         (tui_source_window_base::do_erase_source_content): Rename from
5876         tui_erase_source_content.
5877         (tui_source_window_base::show_source_content): Update.
5878         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5879         * tui/tui-source.h (struct tui_source_window)
5880         <erase_source_content>: New method.
5881         * tui/tui-disasm.h (struct tui_disasm_window)
5882         <erase_source_content>: New method.
5883
5884 2019-08-15  Tom Tromey  <tom@tromey.com>
5885
5886         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5887         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5888         constructor.
5889         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5890         * tui/tui-source.c (tui_set_source_content): Update.
5891         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5892
5893 2019-08-15  Tom Tromey  <tom@tromey.com>
5894
5895         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5896         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5897         tui-source.c.
5898         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5899         Declare.
5900         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5901         method.
5902         (tui_source_window::maybe_update): Update.
5903
5904 2019-08-15  Tom Tromey  <tom@tromey.com>
5905
5906         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5907         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5908         tui-disasm.c.
5909         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5910         Declare.
5911         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5912         method.
5913         (tui_disasm_window::maybe_update): Update.
5914
5915 2019-08-15  Tom Tromey  <tom@tromey.com>
5916
5917         * tui/tui-winsource.h (struct tui_source_window_base)
5918         <maybe_update>: Declare.
5919         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5920         method.
5921         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5922         Declare.
5923         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5924         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5925         Declare.
5926         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5927
5928 2019-08-15  Tom Tromey  <tom@tromey.com>
5929
5930         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5931
5932 2019-08-15  Tom Tromey  <tom@tromey.com>
5933
5934         * tui/tui-wingeneral.c: Include tui-stack.h.
5935         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5936         (struct tui_locator_window): Move from tui-data.h.
5937         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5938         (tui_initialize_static_data): Move from tui-data.c.
5939         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5940         (struct tui_locator_window): Move to tui-stack.c.
5941         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5942         (tui_initialize_static_data): Move to tui-stack.c.
5943
5944 2019-08-15  Tom Tromey  <tom@tromey.com>
5945
5946         * tui/tui-layout.c (show_source_disasm_command)
5947         (show_source_or_disasm_and_command): Use make_visible method, not
5948         tui_make_window.
5949         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5950         Remove.
5951
5952 2019-08-15  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-wingeneral.h (tui_make_window): Update.
5955         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5956         parameter.
5957         (tui_gen_win_info::make_visible): Update.
5958         * tui/tui-regs.c (tui_data_window::display_registers_from):
5959         Update.
5960         * tui/tui-layout.c (show_source_disasm_command)
5961         (show_source_or_disasm_and_command): Update.
5962         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5963         (enum tui_box): Remove.
5964         (struct tui_win_info) <can_box>: New method.
5965         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5966         method.
5967
5968 2019-08-15  Tom de Vries  <tdevries@suse.de>
5969
5970         * linux-nat-trad.c: Include gdbarch.h.
5971
5972 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5973
5974         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5975         register sizes.
5976
5977 2019-08-14  Tom Tromey  <tromey@adacore.com>
5978
5979         * darwin-nat.c: Include gdbarch.h.
5980         * darwin-nat-info.c: Include gdbarch.h.
5981
5982 2019-08-13  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5985         Remove.
5986         * tui/tui-data.c (tui_initialize_static_data): Update.
5987
5988 2019-08-13  Tom Tromey  <tom@tromey.com>
5989
5990         * tui/tui-winsource.h (struct tui_exec_info_window)
5991         <~tui_exec_info_window, maybe_allocate_content, get_content,
5992         m_content>: Remove.
5993         (struct tui_source_window_base) <set_exec_info_content,
5994         show_exec_info_content>: Don't declare.
5995         * tui/tui-winsource.c
5996         (tui_exec_info_window::maybe_allocate_content): Remove.
5997         (tui_source_window_base::update_exec_info): Rename from
5998         set_exec_info_content.
5999         (tui_source_window_base::show_exec_info_content)
6000         (tui_source_window_base::update_exec_info): Remove.
6001
6002 2019-08-13  Tom Tromey  <tom@tromey.com>
6003
6004         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6005         declare.
6006         * tui/tui-winsource.c (tui_update_source_window_as_is)
6007         (tui_update_source_windows_with_addr, tui_erase_source_content):
6008         Update.
6009         (tui_clear_exec_info_content): Remove.
6010
6011 2019-08-13  Tom Tromey  <tom@tromey.com>
6012
6013         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6014         declare.
6015         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6016         call tui_erase_exec_info_content.
6017         (tui_clear_exec_info_content): Rename from
6018         tui_erase_exec_info_content.
6019         (tui_clear_exec_info_content): Delete.
6020
6021 2019-08-13  Tom Tromey  <tom@tromey.com>
6022
6023         * tui/tui-winsource.h (struct tui_source_window_base)
6024         <show_exec_info_content>: Declare.
6025         (tui_show_exec_info_content): Don't declare.
6026         * tui/tui-winsource.c
6027         (tui_source_window_base::show_exec_info_content): Rename from
6028         tui_show_exec_info_content.
6029         (tui_source_window_base::update_exec_info): Update.
6030
6031 2019-08-13  Tom Tromey  <tom@tromey.com>
6032
6033         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6034         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6035         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6036         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6037         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6038         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6039         ... here.
6040
6041 2019-08-13  Tom Tromey  <tom@tromey.com>
6042
6043         * tui/tui-winsource.h (struct tui_source_window_base)
6044         <update_exec_info>: Declare.
6045         (tui_update_exec_info): Don't declare.
6046         * tui/tui-winsource.c (tui_update_source_window_as_is)
6047         (tui_source_window_base::refresh_all)
6048         (tui_update_all_breakpoint_info): Update.
6049         (tui_source_window_base::update_exec_info): Rename from
6050         tui_update_exec_info.
6051         * tui/tui-stack.c (tui_show_frame_info): Update.
6052
6053 2019-08-13  Tom Tromey  <tom@tromey.com>
6054
6055         * tui/tui-winsource.h (struct tui_source_window_base)
6056         <set_exec_info_content>: Declare.
6057         (tui_set_exec_info_content): Don't declare.
6058         * tui/tui-winsource.c
6059         (tui_source_window_base::set_exec_info_content): Rename from
6060         tui_set_exec_info_content.
6061         (tui_update_exec_info): Update.
6062
6063 2019-08-13  Tom Tromey  <tom@tromey.com>
6064
6065         * tui/tui-winsource.h (struct tui_source_window_base)
6066         <show_source_content>: Declare.
6067         (tui_show_source_content): Don't declare.
6068         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6069         (tui_source_window_base::show_source_content): Rename from
6070         tui_show_source_content.
6071         (tui_source_window_base::refresh_all): Update.
6072         * tui/tui-layout.c (show_source_disasm_command)
6073         (show_source_or_disasm_and_command): Update.
6074
6075 2019-08-13  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-winsource.c (tui_erase_source_content)
6078         (tui_show_source_content, tui_source_window_base::refresh_all):
6079         Update.
6080         * tui/tui-wingeneral.h
6081         (tui_check_and_display_highlight_if_needed): Don't declare.
6082         * tui/tui-wingeneral.c
6083         (tui_win_info::check_and_display_highlight_if_needed): Rename from
6084         check_and_display_highlight_if_needed.
6085         * tui/tui-win.c (tui_rehighlight_all)
6086         (tui_win_info::make_visible_with_new_height): Update.
6087         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6088         (tui_data_window::erase_data_content)
6089         (tui_data_window::display_all_data): Update.
6090         * tui/tui-data.h (struct tui_win_info)
6091         <check_and_display_highlight_if_needed>: Declare.
6092
6093 2019-08-13  Tom Tromey  <tom@tromey.com>
6094
6095         * tui/tui-win.c (tui_resize_all): Call
6096         tui_delete_invisible_windows.
6097         * tui/tui-layout.c (show_layout): Call
6098         tui_delete_invisible_windows.
6099         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6100         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6101
6102 2019-08-13  Tom Tromey  <tom@tromey.com>
6103
6104         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6105         tui_add_win_to_layout.
6106
6107 2019-08-13  Tom Tromey  <tom@tromey.com>
6108
6109         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6110         * tui/tui-layout.c (tui_default_win_height): Now static.
6111
6112 2019-08-13  Tom Tromey  <tom@tromey.com>
6113
6114         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6115         single switch.
6116         (show_source_disasm_command, show_source_or_disasm_and_command):
6117         Don't check current layout.
6118
6119 2019-08-13  Tom Tromey  <tom@tromey.com>
6120
6121         * tui/tui-wingeneral.c (make_all_visible): Remove.
6122         (tui_make_all_invisible): Simplify.
6123         * tui/tui-layout.c (tui_make_all_invisible): Move from
6124         tui-wingeneral.c; simplify.
6125         (show_layout): Hoist call to tui_make_all_invisible.
6126         (show_data): Don't call tui_make_all_invisible.
6127
6128 2019-08-13  Tom Tromey  <tom@tromey.com>
6129
6130         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6131         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6132
6133 2019-08-13  Tom Tromey  <tom@tromey.com>
6134
6135         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6136         tui-data.c.
6137         (show_source_disasm_command, show_data)
6138         (show_source_or_disasm_and_command): Don't use
6139         tui_set_current_layout_to.
6140         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6141         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6142         tui-layout.c.
6143         (tui_set_current_layout_to): Remove.
6144
6145 2019-08-13  Tom Tromey  <tom@tromey.com>
6146
6147         * tui/tui-layout.c (tui_set_layout): Update.
6148         * tui/tui-data.h (struct tui_layout_def): Remove.
6149         (tui_layout_def): Don't declare.
6150         * tui/tui-data.c (layout_def): Remove.
6151         (tui_layout_def): Remove.
6152
6153 2019-08-13  Tom Tromey  <tom@tromey.com>
6154
6155         * tui/tui-winsource.h (struct tui_source_window_base)
6156         <clear_detail>: No longer "override".
6157         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6158         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6159         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6160         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6161         Remove.
6162         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6163
6164 2019-08-13  Tom Tromey  <tromey@adacore.com>
6165
6166         * tracepoint.c: Don't include readline.h or history.h.
6167
6168 2019-08-12  Tom Tromey  <tom@tromey.com>
6169
6170         * configure: Rebuild.
6171         * configure.ac: Check for readline 7.
6172         * NEWS: Mention readline 7 requirement.
6173         * README: Update.
6174
6175 2019-08-12  Tom Tromey  <tom@tromey.com>
6176
6177         * mingw-hdep.c (gdb_select): Remove readline hack.
6178
6179 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6180
6181         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6182         when the function fails.
6183
6184 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6185
6186         * s390-tdep.c (s390_type_align): New function.
6187         (s390_gdbarch_init): Set it as type_align gdbarch method.
6188
6189 2019-08-09  Tom de Vries  <tdevries@suse.de>
6190
6191         PR gdb/24591
6192         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6193         pc_low with relocation offset.
6194
6195 2019-08-07  Tom Tromey  <tromey@adacore.com>
6196
6197         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6198         (print_frame_args): Update.
6199         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6200         Update.
6201         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6202         * frame.h (struct frame_arg): Add initializers.
6203         <error>: Now a unique_xmalloc_ptr.
6204
6205 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6206
6207         * NEWS: Expand the Pointer Authentication entry.
6208         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6209         (aarch64_frame_unmask_lr): ... to this.
6210         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6211         Call aarch64_frame_unmask_lr.
6212         * frame.c (struct frame_info): Add "masked" variable.
6213         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6214         (fprint_frame): Check for masked pc.
6215         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6216         declarations.
6217         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6218         * stack.c (print_frame): Check for masked pc.
6219
6220 2019-08-06  Tom Tromey  <tom@tromey.com>
6221
6222         * stabsread.c (patch_block_stabs, read_one_struct_field)
6223         (read_enum_type): Use obstack_strndup.
6224         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6225         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6226         * dwarf2read.c (guess_full_die_structure_name)
6227         (anonymous_struct_prefix): Use obstack_strndup.
6228         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6229         * c-exp.y (yylex): Use obstack_strndup.
6230         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6231         (write_var_or_type): Use obstack_strndup.
6232
6233 2019-08-06  Tom Tromey  <tom@tromey.com>
6234
6235         * symfile.c (reread_symbols): Use obstack_strdup.
6236         * stabsread.c (read_type): Use obstack_strdup.
6237         * gdb_obstack.h (obstack_strdup): New overload.
6238         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6239         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6240         (dwarf2_canonicalize_name): Use obstack_strdup.
6241         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6242         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6243         Use obstack_strdup.
6244
6245 2019-08-06  Tom Tromey  <tom@tromey.com>
6246
6247         * gdb_obstack.h (obstack_strdup): Define.
6248         * gdb_obstack.c (obstack_strdup): Don't define.
6249
6250 2019-08-06  Tom Tromey  <tom@tromey.com>
6251
6252         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6253         obstack_strdup.
6254         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6255         obstack_strdup.
6256         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6257         * stabsread.c (common_block_start): Use obstack_strdup.
6258         * objfiles.c (set_objfile_main_name, objfile): Use
6259         obstack_strdup.
6260         * namespace.c (add_using_directive): Use obstack_strdup.
6261         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6262         * jit.c (finalize_symtab): Use obstack_strdup.
6263         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6264         (guess_partial_die_structure_name, partial_die_info::fixup)
6265         (dwarf2_name): Use obstack_strdup.
6266         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6267         obstack_strdup.
6268         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6269         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6270         obstack_strdup.
6271         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6272
6273 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6274
6275         * unittests/help-doc-selftests.c: New file.
6276         * Makefile.in: Add the new file.
6277
6278 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6279
6280         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6281         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6282         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6283         the trailing '.' is not output, and the first character is uppercased.
6284         (print_help_for_command): Update call to print_doc_line.
6285         (print_doc_of_command): Likewise.
6286         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6287         * cli/cli-option.c (append_indented_doc): Do not append newline.
6288         (build_help_option): Append newline after first appended_indented_doc
6289         only if a second call is done.
6290         (build_help): Append 2 new lines before each option, except the first
6291         one.
6292         * compile/compile.c (_initialize_compile): Add new lines after
6293         %OPTIONS%, when not at the end of the help.
6294         Change help doc or code
6295         producing the help doc to respect the invariants.
6296         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6297         Also removed the new line after 'Options:', as all other commands
6298         do not put an empty line between 'Options:' and the first option.
6299         * printcmd.c (_initialize_printcmd): Likewise.
6300         * stack.c (_initialize_stack): Likewise.
6301         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6302         incorrectly telling COMMAND is optional.
6303         * ada-lang.c (_initialize_ada_language): Change help doc or code
6304         producing the help doc to respect the invariants.
6305         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6306         * breakpoint.c (_initialize_breakpoint): Likewise.
6307         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6308         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6309         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6310         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6311         _initialize_cli_style): Likewise.
6312         * corelow.c (core_target_info): Likewise.
6313         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6314         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6315         * filesystem.c (_initialize_filesystem): Likewise.
6316         * frame.c (_initialize_frame): Likewise.
6317         * gnu-nat.c (add_task_commands): Likewise.
6318         * infcall.c (_initialize_infcall): Likewise.
6319         * infcmd.c (_initialize_infcmd): Likewise.
6320         * interps.c (_initialize_interpreter): Likewise.
6321         * language.c (_initialize_language): Likewise.
6322         * linux-fork.c (_initialize_linux_fork): Likewise.
6323         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6324         * maint.c (_initialize_maint_cmds): Likewise.
6325         * memattr.c (_initialize_mem): Likewise.
6326         * printcmd.c (_initialize_printcmd): Likewise.
6327         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6328         _RegEx): Likewise.
6329         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6330         * record-btrace.c (_initialize_record_btrace): Likewise.
6331         * record-full.c (_initialize_record_full): Likewise.
6332         * record.c (_initialize_record): Likewise.
6333         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6334         * regcache.c (_initialize_regcache): Likewise.
6335         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6336         _initialize_remote): Likewise.
6337         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6338         * serial.c (_initialize_serial): Likewise.
6339         * skip.c (_initialize_step_skip): Likewise.
6340         * source.c (_initialize_source): Likewise.
6341         * stack.c (_initialize_stack): Likewise.
6342         * symfile.c (_initialize_symfile): Likewise.
6343         * symtab.c (_initialize_symtab): Likewise.
6344         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6345         * top.c (init_main): Likewise.
6346         * tracefile-tfile.c (tfile_target_info): Likewise.
6347         * tracepoint.c (_initialize_tracepoint): Likewise.
6348         * tui/tui-win.c (_initialize_tui_win): Likewise.
6349         * utils.c (add_internal_problem_command): Likewise.
6350         * valprint.c (value_print_option_defs): Likewise.
6351
6352 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6353
6354         PR build/24886
6355         * configure.ac: Drop enable-libmcheck support.
6356         * configure, config.in: Rebuild.
6357         * libmcheck.m4: Remove.
6358         * acinclude.m4: Don't include it.
6359         * Makefile.in: Don't distribute it.
6360         * top.c (print_gdb_configuration): Don't mention it.
6361
6362 2019-08-06  Tom Tromey  <tom@tromey.com>
6363
6364         * utils.c (set_output_style): Sometimes pass stream to
6365         emit_style_escape.
6366         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6367         * record-btrace.c (btrace_insn_history): Update.
6368         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6369         method.
6370         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6371         Update initializers.
6372         <m_uiout>: New field.
6373         <m_di>: Move lower.
6374         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6375         Remove "uiout" parameter.
6376         (dump_insns): Update.
6377         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6378         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6379
6380 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6381
6382         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6383         (error_in_psymtab_expansion): Likewise.
6384         (lookup_symbol_via_quick_fns): Likewise.
6385         (basic_lookup_transparent_type_quick): Likewise.
6386         (basic_lookup_transparent_type_1): Likewise.
6387
6388 2019-08-06  Tom Tromey  <tromey@adacore.com>
6389
6390         * source.c (last_source_error): Now bool.
6391         (print_source_lines_base): Make "noprint" bool.  Only open
6392         source file when last_source_visited changes.
6393
6394 2019-08-06  Tom Tromey  <tromey@adacore.com>
6395
6396         * annotate.c (annotate_source_line): Use g_source_cache.
6397         * source-cache.c (source_cache::get_plain_source_lines): Change
6398         parameters.  Populate m_offset_cache.
6399         (source_cache::ensure): New method.
6400         (source_cache::get_line_charpos): New method.
6401         (extract_lines): Move lower.  Change parameters.
6402         (source_cache::get_source_lines): Move lower.
6403         * source-cache.h (class source_cache): Update comment.
6404         <get_line_charpos>: New method.
6405         <get_source_lines>: Update comment.
6406         <clear>: Clear m_offset_cache.
6407         <get_plain_source_lines>: Change parameters.
6408         <ensure>: New method
6409         <m_offset_cache>: New member.
6410         * source.c (forget_cached_source_info_for_objfile): Update.
6411         (info_source_command): Use g_source_cache.
6412         (find_source_lines, open_source_file_with_line_charpos): Remove.
6413         (print_source_lines_base, search_command_helper): Use g_source_cache.
6414         * source.h (open_source_file_with_line_charpos): Don't declare.
6415         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6416         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6417         Use g_source_cache.
6418
6419 2019-08-06  Tom Tromey  <tromey@adacore.com>
6420
6421         * source-cache.c (source_cache::get_plain_source_lines):
6422         Remove "first_line" and "last_line" parameters.
6423         (source_cache::get_source_lines): Cache plain text.
6424         * source-cache.h (class source_cache)
6425         <get_plain_source_lines>: Update.
6426
6427 2019-08-06  Tom Tromey  <tromey@adacore.com>
6428
6429         * source-cache.c (extract_lines): No longer a method.
6430         Changed type of parameter.  Include final newline.
6431         (selftests::extract_lines_test): New function.
6432         (_initialize_source_cache): Likewise.
6433         * source-cache.h (class source_cache)
6434         <extract_lines>: Don't declare.
6435
6436 2019-08-06  Tom Tromey  <tromey@adacore.com>
6437
6438         * breakpoint.c (init_breakpoint_sal): Update.
6439         (breakpoint): Update.
6440         * breakpoint.h (struct breakpoint) <filter>: Now a
6441         unique_xmalloc_ptr.
6442
6443 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6444
6445         * NEWS: Mention dictionary access on blocks.
6446         * python/py-block.c (blpy_getitem): New function.
6447         (block_object_as_mapping): New struct.
6448         (block_object_type): Use new struct for tp_as_mapping field.
6449
6450 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6451
6452         * objfiles.h (objfile): Add a comment describing partial symbols.
6453
6454 2019-08-05  Tom Tromey  <tromey@adacore.com>
6455
6456         * compile/compile.c (_initialize_compile): Use _(), not N_().
6457         * thread.c (_initialize_thread): Use _(), not N_().
6458         * stack.c (_initialize_stack): Use _(), not N_().
6459         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6460
6461 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6462
6463         * dwarf2read.c (struct dw2_symtab_iterator):
6464         <want_specific_block>: Remove.
6465         <block_index>: Change type to gdb::optional.
6466         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6467         change type of BLOCK_INDEX parameter to gdb::optional.
6468         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6469         (dw2_lookup_symbol): Don't pass argument for
6470         WANT_SPECIFIC_BLOCK.
6471         (dw2_expand_symtabs_for_function): Don't pass argument for
6472         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6473         (class dw2_debug_names_iterator)
6474         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6475         parameter, change BLOCK_INDEX type to gdb::optional.
6476         <m_want_specific_block>: Remove.
6477         <m_block_index>: Change type to gdb::optional.
6478         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6479         gdb::optional.  Re-write in function of gdb::optional.
6480         (dw2_debug_names_lookup_symbol): Don't pass argument for
6481         WANT_SPECIFIC_BLOCK.
6482         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6483         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6484         BLOCK_INDEX.
6485
6486 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6487
6488         * NEWS: Mention changes to "info sources" command.
6489
6490 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6491
6492         * symtab.c (filename_partial_match_opts): New struct type.
6493         (struct output_source_filename_data): New members
6494         regexp, c_regexp, partial_match.
6495         (output_source_filename): Use new members to decide to print file.
6496         (info_sources_option_defs): New variable.
6497         (make_info_sources_options_def_group, print_info_sources_header,
6498         info_sources_command_completer):
6499         New functions.
6500         (info_sources_command): Read new optional arguments.
6501         (_initialize_symtab): Update info sources help.
6502
6503 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6504
6505         * ada-lang.c (exception_support_info_v0): Renamed from...
6506         (default_exception_support_info): ... this.  Create new
6507         definition for v1.
6508         (ada_has_this_exception_support): Look up catch_handlers_sym.
6509         (ada_exception_support_info_sniffer): Try v0 after default.
6510
6511 2019-08-01  Tom Tromey  <tromey@adacore.com>
6512
6513         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6514         gdbarch.h.
6515
6516 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6517
6518         * s12z-tdep.c: Fix include path for s12z-opc.h.
6519
6520 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6521
6522         * NEWS: Require GNU make 3.82.
6523
6524 2019-07-16  Tom Tromey  <tom@tromey.com>
6525
6526         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6527         declare.
6528
6529 2019-07-30  Tom Tromey  <tromey@adacore.com>
6530
6531         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6532
6533 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6534
6535         * printcmd.c (print_address_symbolic): Print negative offsets.
6536         (build_address_symbolic): Force signed arithmetic when computing
6537         offset.
6538
6539 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6540
6541         PR/24474: Add a function to lookup static variables.
6542         * NEWS: Mention this new function.
6543         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6544         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6545         * python/python.c (python_GdbMethods): Add new function.
6546
6547 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6548
6549         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6550         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6551         (objfpy_lookup_static_symbol): New function.
6552         (objfile_object_methods): Add new functions.
6553
6554 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6555
6556         * NEWS: Mention 'set|show print frame-info'.  Mention new
6557         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6558         backtrace argument.  Mention that python frame filtering code
6559         is now consistent with what 'backtrace' command prints.
6560
6561 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6562
6563         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6564         comments.
6565         (print_frame_info_auto, print_frame_info_source_line,
6566         print_frame_info_location, print_frame_info_source_and_location,
6567         print_frame_info_location_and_address, print_frame_info_short_location):
6568         New declarations.
6569         (struct frame_print_options): New member print_frame_info.
6570         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6571         * stack.h (get_user_print_what_frame_info): New declaration.
6572         (frame_show_address): New declaration.
6573         * stack.c (print_frame_arguments_choices): New value 'presence'.
6574         (print_frame_info_auto, print_frame_info_source_line,
6575         print_frame_info_location, print_frame_info_source_and_location,
6576         print_frame_info_location_and_address, print_frame_info_short_location,
6577         print_frame_info_choices, print_frame_info_print_what): New definitions.
6578         (print_frame_args): Only print dots for args if print frame-arguments
6579         is 'presence'.
6580         (frame_print_option_defs): New element for "frame-info".
6581         (get_user_print_what_frame_info): New function.
6582         (frame_show_address): Make non static.  Move comment to stack.h.
6583         (print_frame_info_to_print_what): New function.
6584         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6585         to decide what to print.
6586         (backtrace_command_1): Handle the new print_frame_arguments_presence
6587         value.
6588         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6589         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6590         (py_print_frame): In non-mi mode, use LOCATION as default for
6591         print_what, similarly to frame information printed directly by
6592         backtrace command. Handle frame-info user option in non MI mode.
6593
6594 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6595
6596         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6597         Add case for debugging 32-bit target on 64-bit host.  Revise
6598         comment.
6599
6600 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6601
6602         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6603         instead of find_function_entry_range_from_pc.
6604
6605 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6606
6607         * stack.c (find_frame_funname): Remove code which preferred
6608         minsym over symtab sym in "certain pathological cases".
6609
6610         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6611         parameter.  Change type of "do_demangle" to bool.
6612         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6613         Pass suitable "prefer_sym_over_minsym" flag to
6614         build_address_symbolic().  Don't output "+" for negative offsets.
6615         * printcmd.c (print_address_symbolic): Update invocation of
6616         build_address_symbolic to include a "prefer_sym_over_minsym"
6617         flag.
6618         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6619         Restrict cases in which use of minimal symbol is preferred to that
6620         of a found symbol.  Update comments.
6621
6622         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6623         for entry pc when entry pc is out of range for that FDE.
6624
6625 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6626
6627         PR gdb/24839:
6628         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6629         type.
6630
6631 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6632
6633         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6634         this function's Python signature.
6635
6636
6637 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6638
6639         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6640         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6641         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6642         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6643         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6644
6645
6646 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6647
6648         * h8300-tdep.c (h8300_register_name_common): New.
6649         h8300_register_name): Use h8300_register_name_common.
6650         (h8300s_register_name): Likewise.
6651         (h8300sx_register_name): Likewise.
6652         (h8300h_register_nam): New.
6653         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6654
6655
6656 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6657
6658         * arm-tdep.c (arm_skip_cmse_entry): New function.
6659         (arm_is_sgstubs_section): New function.
6660         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6661
6662 2019-07-22  Tom Tromey  <tom@tromey.com>
6663
6664         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6665         Don't self-assign.
6666
6667 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6668
6669         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6670         type_print.
6671
6672 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6673
6674         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6675         so that GDB doesn't match any msymbols when searching in the
6676         TYPES_DOMAIN.
6677         (print_symbol_info): Print using typedef_print or type_print based
6678         on the type of the symbol.  Add updated FIXME comment moved from...
6679         (_initialize_symtab): ... move and update FIXME comment to above.
6680
6681 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6682
6683         * NEWS: Mention adding -q option to "info types".
6684         * symtab.c (struct info_types_options): New struct.
6685         (info_types_options_defs): New variable.
6686         (make_info_types_options_def_group): New function.
6687         (info_types_command): Use gdb::option framework to parse options.
6688         (info_types_command_completer): New function.
6689         (_initialize_symtab): Extend the help text on "info types" and
6690         register command completer.
6691
6692 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6693
6694         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6695         (lookup_symbol_in_objfile): Change int to block_enum and add a
6696         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6697
6698 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6699
6700         * MAINTAINERS (Write After Approval): Add self.
6701
6702 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6703
6704         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6705         instruction to the dummy code region.
6706
6707 2019-07-19  Tom Tromey  <tromey@adacore.com>
6708
6709         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6710         (ARGSUSED, PARAMS, __func__): Remove rules.
6711
6712 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6713
6714         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6715         * features/arm/arm-with-iwmmxt.c: Remove.
6716         * features/arm/arm-with-iwmmxt.xml: Remove.
6717         * features/arm/arm-with-m-fpa-layout.c: Remove.
6718         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6719         * features/arm/arm-with-m-vfp-d16.c: Remove.
6720         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6721         * features/arm/arm-with-m.c: Remove.
6722         * features/arm/arm-with-m.xml: Remove.
6723         * features/arm/arm-with-neon.c: Remove.
6724         * features/arm/arm-with-neon.xml: Remove.
6725         * features/arm/arm-with-vfpv2.c: Remove.
6726         * features/arm/arm-with-vfpv2.xml: Remove.
6727         * features/arm/arm-with-vfpv3.c: Remove.
6728         * features/arm/arm-with-vfpv3.xml: Remove.
6729
6730 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6731
6732         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6733
6734 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6735
6736         * arch/aarch32.c (aarch32_create_target_description): Create
6737         target descriptions using features.
6738         * arch/arm.c (arm_create_target_description)
6739         (arm_create_mprofile_target_description): Likewise.
6740         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6741
6742 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6743
6744         * Makefile.in: Add new files.
6745         * aarch32-tdep.c: New file.
6746         * aarch32-tdep.h: New file.
6747         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6748         Call aarch32_read_description.
6749         * arch/aarch32.c: New file.
6750         * arch/aarch32.h: New file.
6751         * arch/arm.c (arm_create_target_description)
6752         (arm_create_mprofile_target_description): New function.
6753         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6754         (arm_create_target_description)
6755         (arm_create_mprofile_target_description): New declaration.
6756         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6757         read_description functions.
6758         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6759         Likewise.
6760         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6761         * arm-tdep.c (tdesc_arm_list): New variable.
6762         (arm_register_g_packet_guesses): Call create description functions.
6763         (arm_read_description) (arm_read_mprofile_description): New
6764         function.
6765         * arm-tdep.h (arm_read_description)
6766         (arm_read_mprofile_description): Add declaration.
6767         * configure.tgt: Add new files.
6768
6769 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6770
6771         * top.c (new_ui_command): Open specified terminal just once.
6772
6773 2019-07-18  Tom Tromey  <tromey@adacore.com>
6774
6775         * symtab.c (main_name): Constify return type.
6776         * symfile.c (set_initial_language): Update.
6777         * symtab.h (main_name): Constify return type.
6778
6779 2019-07-17  Tom Tromey  <tom@tromey.com>
6780
6781         * tui/tui-winsource.c (tui_update_source_window)
6782         (tui_update_source_window_as_is)
6783         (tui_update_source_windows_with_line): Remove return.
6784         * tui/tui-disasm.c (tui_show_disassem)
6785         (tui_show_disassem_and_update_source): Remove return.
6786         * tui/tui.c (tui_reset): Remove return.
6787         * tui/tui-wingeneral.c
6788         (tui_check_and_display_highlight_if_needed): Remove return.
6789
6790 2019-07-17  Tom Tromey  <tom@tromey.com>
6791
6792         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6793
6794 2019-07-17  Tom Tromey  <tom@tromey.com>
6795
6796         * tui/tui-winsource.h (struct tui_exec_info_window)
6797         (struct tui_source_window_base): Move from tui-data.h.
6798         * tui/tui-winsource.c: Move many method definitions from
6799         elsewhere.  Remove "structuring" comments.
6800         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6801         (tui_source_window_base::refresh_window): Move to
6802         tui-winsource.c.
6803         * tui/tui-win.c (tui_source_window_base::refresh_all)
6804         (tui_source_window_base::update_tab_width)
6805         (tui_source_window_base::set_new_height)
6806         (tui_source_window_base::do_make_visible_with_new_height): Move to
6807         tui-winsource.c.
6808         * tui/tui-source.h: Update.
6809         * tui/tui-source.c (tui_source_window_base::reset): Move to
6810         tui-winsource.c.
6811         * tui/tui-disasm.h: Update.
6812         * tui/tui-data.h (struct tui_exec_info_window): Move to
6813         tui-winsource.h.
6814         (struct tui_source_window_base): Likewise.
6815         * tui/tui-data.c (tui_source_window_base::clear_detail)
6816         (tui_source_window_base, ~tui_source_window_base): Move to
6817         tui-winsource.c.
6818
6819 2019-07-17  Tom Tromey  <tom@tromey.com>
6820
6821         * tui/tui-win.c (tui_resize_all)
6822         (tui_source_window_base::update_tab_width)
6823         (tui_adjust_win_heights): Update.
6824         (tui_win_info::make_invisible_and_set_new_height): Rename from
6825         make_invisible_and_set_new_height.
6826         * tui/tui-data.h (struct tui_win_info)
6827         <make_invisible_and_set_new_height>: New method.
6828
6829 2019-07-17  Tom Tromey  <tom@tromey.com>
6830
6831         * tui/tui.c: Update.
6832         * tui/tui-source.h (struct tui_source_window): Move from
6833         tui-data.h.
6834         * tui/tui-layout.c: Update.
6835         * tui/tui-disasm.c: Update.
6836         * tui/tui-data.h (struct tui_source_window): Move to
6837         tui-source.h.
6838
6839 2019-07-17  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6842         tui-data.h.
6843         * tui/tui-data.h (struct tui_disasm_window): Move to
6844         tui-disasm.h.
6845
6846 2019-07-17  Tom Tromey  <tom@tromey.com>
6847
6848         * tui/tui-regs.h (struct tui_data_item_window): Move from
6849         tui-data.h.
6850         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6851         * tui/tui-data.h (struct tui_data_item_window): Move to
6852         tui-regs.h.
6853         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6854
6855 2019-07-17  Tom Tromey  <tom@tromey.com>
6856
6857         * tui/tui.c: Update.
6858         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6859         (tui_cmd_window::max_height): Move to tui-command.c.
6860         * tui/tui-layout.c: Update.
6861         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6862         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6863         tui-command.c.
6864         * tui/tui-command.h (struct tui_cmd_window): Move from
6865         tui-data.h.
6866         * tui/tui-command.c: Remove "structuring" comments.
6867         (tui_cmd_window::clear_detail)
6868         (tui_cmd_window::do_make_visible_with_new_height)
6869         (tui_cmd_window::max_height): Move from elsewhere.
6870
6871 2019-07-17  Tom Tromey  <tom@tromey.com>
6872
6873         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6874         Now static.
6875         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6876         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6877
6878 2019-07-17  Tom Tromey  <tom@tromey.com>
6879
6880         * tui/tui.c: Update.
6881         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6882         tui-regs.c.
6883         * tui/tui-windata.h: Remove file.
6884         * tui/tui-windata.c: Remove file.
6885         * tui/tui-win.c (tui_data_window::set_new_height)
6886         (tui_data_window::do_make_visible_with_new_height): Move to
6887         tui-regs.c.
6888         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6889         * tui/tui-regs.c: Remove "structuring" comments.
6890         (tui_data_window::first_data_item_displayed)
6891         (tui_data_window::delete_data_content_windows)
6892         (tui_data_window::erase_data_content)
6893         (tui_data_window::display_all_data)
6894         (tui_data_window::refresh_all)
6895         (tui_data_window::do_scroll_vertical)
6896         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6897         (tui_data_window::do_make_visible_with_new_height)
6898         (tui_data_window::refresh_window): Move from elsewhere.
6899         (_initialize_tui_regs): Move to end of file.
6900         * tui/tui-layout.c: Update.
6901         * tui/tui-hooks.c: Update.
6902         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6903         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6904         tui-regs.c.
6905         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6906
6907 2019-07-17  Tom Tromey  <tom@tromey.com>
6908
6909         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6910         seen.
6911
6912 2019-07-17  Tom Tromey  <tom@tromey.com>
6913
6914         * tui/tui-win.c (tui_source_window_base::set_new_height)
6915         (tui_source_window_base::do_make_visible_with_new_height): Use
6916         m_has_locator field directly.
6917         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6918         method.
6919         (struct tui_source_window_base) <has_locator>: Likewise.
6920
6921 2019-07-17  Tom Tromey  <tom@tromey.com>
6922
6923         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6924         Don't declare.
6925         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6926         Remove.
6927         * tui/tui-win.c (tui_source_window_base::set_new_height)
6928         (tui_source_window_base::set_new_height)
6929         (make_invisible_and_set_new_height)
6930         (tui_source_window_base::do_make_visible_with_new_height)
6931         (tui_source_window_base::do_make_visible_with_new_height):
6932         Update.
6933         * tui/tui-layout.c (show_source_disasm_command, show_data)
6934         (show_source_or_disasm_and_command): Update.
6935         * tui/tui-layout.c (show_layout): Update.
6936
6937 2019-07-17  Tom Tromey  <tom@tromey.com>
6938
6939         * tui/tui-layout.c (make_data_window): Remove.
6940         (show_data): Unify creation and re-initialization cases.
6941
6942 2019-07-17  Tom Tromey  <tom@tromey.com>
6943
6944         * tui/tui-layout.c (make_source_window, make_disasm_window):
6945         Remove.
6946         (show_data): Unify creation and re-initialization cases.
6947
6948 2019-07-17  Tom Tromey  <tom@tromey.com>
6949
6950         * tui/tui-layout.c (make_command_window): Remove.
6951         (show_source_disasm_command, show_source_or_disasm_and_command):
6952         Unify creation and re-initialization cases.
6953
6954 2019-07-17  Tom Tromey  <tom@tromey.com>
6955
6956         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6957         creation and re-initialization cases.
6958
6959 2019-07-17  Tom Tromey  <tom@tromey.com>
6960
6961         * tui/tui-regs.c (tui_get_register): Return void.
6962
6963 2019-07-17  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6966         Simplify.
6967
6968 2019-07-17  Tom Tromey  <tom@tromey.com>
6969
6970         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6971         resetting.
6972
6973 2019-07-17  Tom Tromey  <tom@tromey.com>
6974
6975         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6976         * tui/tui-regs.c (tui_reg_layout): New function.
6977         (tui_show_registers, tui_reg_command): Use it.
6978         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6979         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6980         parameters.
6981         (tui_layout_command): Remove.
6982
6983 2019-07-17  Tom Tromey  <tom@tromey.com>
6984
6985         * tui/tui-layout.h (tui/tui-layout): Return void.
6986         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6987
6988 2019-07-17  Tom Tromey  <tom@tromey.com>
6989
6990         * tui/tui-layout.c (show_source_disasm_command, show_data):
6991         Update.
6992         (reset_locator): Remove.
6993         (show_source_or_disasm_and_command): Update.
6994
6995 2019-07-17  Tom Tromey  <tom@tromey.com>
6996
6997         * tui/tui-source.c (tui_source_window_base::reset): Remove
6998         win_type parameter.
6999         * tui/tui-layout.c (make_command_window, make_source_window)
7000         (make_disasm_window, make_data_window)
7001         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7002         (reset_locator, show_source_or_disasm_and_command): Update.
7003         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7004         win_type parameter.
7005         (struct tui_source_window_base) <reset>: Likewise.
7006
7007 2019-07-17  Tom Tromey  <tom@tromey.com>
7008
7009         * tui/tui-layout.c (show_source_disasm_command): Use
7010         reset_locator.
7011         (reset_locator): New function.
7012         (init_and_make_win): Remove.
7013         (show_source_or_disasm_and_command): Use reset_locator.
7014
7015 2019-07-17  Tom Tromey  <tom@tromey.com>
7016
7017         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7018         condition.
7019         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7020         Remove condition.
7021         * tui/tui-source.c (tui_source_window_base::reset): New method.
7022         * tui/tui-layout.c (make_command_window): Don't call
7023         init_and_make_win.
7024         (make_source_window, make_disasm_window): Don't call
7025         make_source_or_disasm_window.
7026         (make_data_window): Don't call init_and_make_win.  Change calling
7027         convention.
7028         (show_source_disasm_command, show_data): Simplify.
7029         (make_source_or_disasm_window): Remove.
7030         (show_source_or_disasm_and_command): Simplify.
7031         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7032         (struct tui_source_window_base) <reset>: Likewise.
7033         <execution_info>: Remove initializer.
7034         * tui/tui-data.c (tui_source_window_base): Initialize
7035         execution_info.
7036
7037 2019-07-17  Tom Tromey  <tom@tromey.com>
7038
7039         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7040         variable.
7041
7042 2019-07-17  Tom Tromey  <tom@tromey.com>
7043
7044         * tui/tui.c (tui_rl_other_window): Update.
7045         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7046         superclass method first.  Always iterate over regs_content.
7047         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7048         method.
7049         * tui/tui-win.c (tui_set_focus_command): Update.
7050
7051 2019-07-17  Tom Tromey  <tom@tromey.com>
7052
7053         * tui/tui-win.c (tui_set_focus_command): Rename from
7054         tui_set_focus.  Call tui_enable.
7055         (tui_set_focus_command): Remove.
7056
7057 2019-07-17  Tom Tromey  <tom@tromey.com>
7058
7059         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7060         refresh_window.
7061         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7062         touchwin.
7063         (tui_data_window::refresh_window): Call refresh_window on data
7064         items.  Always call superclass refresh_window.
7065         (tui_win_info::refresh): Remove.
7066         (tui_source_window_base::refresh_window): Update.
7067         (tui_refresh_all): Update.
7068         * tui/tui-layout.c (show_source_disasm_command): Remove call to
7069         refresh_window.
7070         (show_source_or_disasm_and_command): Likewise.
7071         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7072         (struct tui_source_window_base) <refresh>: Likewise.
7073
7074 2019-07-17  Tom Tromey  <tom@tromey.com>
7075
7076         * tui/tui-winsource.c (tui_clear_source_content)
7077         (tui_show_source_content): Update.
7078         * tui/tui-source.c (tui_source_window::showing_source_p): Check
7079         whether content is empty.
7080         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7081         Remove.
7082
7083 2019-07-17  Tom Tromey  <tom@tromey.com>
7084
7085         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7086         window's contents.
7087         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7088         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7089
7090 2019-07-17  Tom Tromey  <tom@tromey.com>
7091
7092         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7093         (struct tui_data_item_window): Update.
7094
7095 2019-07-17  Tom Tromey  <tom@tromey.com>
7096
7097         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7098         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7099         defines.
7100
7101 2019-07-17  Tom Tromey  <tom@tromey.com>
7102
7103         * tui/tui-winsource.h (tui_erase_source_content)
7104         (tui_clear_source_content): Remove "display_prompt" parameter.
7105         * tui/tui-winsource.c (tui_update_source_window_as_is)
7106         (tui_update_source_windows_with_addr): Update.
7107         (tui_clear_source_content): Remove "display_prompt" parameter.
7108         (tui_erase_source_content): Likewise.  Simplify.
7109         (tui_show_source_content): Update.
7110         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7111         * tui/tui-stack.c (tui_show_frame_info): Update.
7112         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7113         Remove defines.
7114
7115 2019-07-17  Tom Tromey  <tom@tromey.com>
7116
7117         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7118         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7119         parameter.
7120         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7121         parameter.
7122
7123 2019-07-17  Tom Tromey  <tom@tromey.com>
7124
7125         * tui/tui-winsource.c (tui_clear_source_content)
7126         (tui_show_source_content, tui_show_exec_info_content)
7127         (tui_clear_exec_info_content): Update.
7128         * tui/tui-stack.c (tui_show_locator_content): Update.
7129         (tui_show_frame_info): Update.
7130         * tui/tui-source.h (tui_source_window): Don't declare.
7131         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7132         from tui_source_is_displayed.
7133         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7134         Remove field.
7135         (struct tui_source_window_base) <content_in_use>: New field.  Now
7136         bool.
7137         (struct tui_source_window) <showing_source_p>: New method.
7138         (TUI_SRC_WIN): Change cast.
7139         * tui/tui-data.c (tui_initialize_static_data): Update.
7140
7141 2019-07-17  Tom Tromey  <tom@tromey.com>
7142
7143         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7144         location_matches_p.
7145         * tui/tui-source.c (tui_source_window::location_matches_p): New
7146         method.
7147         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7148         method.
7149         * tui/tui-data.h (struct tui_source_window_base)
7150         <location_matches_p>: New method.
7151         (struct tui_source_window, struct tui_disasm_window)
7152         <location_matches_p>: Likewise.
7153
7154 2019-07-17  Tom Tromey  <tom@tromey.com>
7155
7156         * tui/tui-win.c (tui_set_win_height_command): Rename from
7157         tui_set_win_height.
7158         (tui_set_win_height_command): Remove.
7159
7160 2019-07-17  Tom Tromey  <tom@tromey.com>
7161
7162         * tui/tui-source.c (tui_source_window): New constructor.  Add
7163         observer.
7164         (~tui_source_window): New destructor.
7165         (tui_source_window::style_changed): New method.
7166         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7167         (tui_attach_detach_observers): Update.
7168         * tui/tui-data.h (struct tui_source_window): Make constructor not
7169         inline.  Add destructor.
7170         (struct tui_source_window) <style_changed>: New method.
7171         <m_observable>: New member.
7172
7173 2019-07-17  Tom Tromey  <tom@tromey.com>
7174
7175         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7176         * tui/tui-win.c (tui_resize_all): Fix typo.
7177
7178 2019-07-17  Tom Tromey  <tom@tromey.com>
7179
7180         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7181         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7182         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7183         * tui/tui-win.c (window_name_completer): Use foreach.
7184         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7185         (update_tab_width): Likewise.
7186         * tui/tui-layout.c (show_layout): Update.
7187         * tui/tui-data.h (class tui_window_iterator): New.
7188         (struct all_tui_windows): New.
7189         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7190
7191 2019-07-17  Tom Tromey  <tom@tromey.com>
7192
7193         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7194         parameter.  Don't reference globals.
7195         (tui_reg_command): Update.
7196
7197 2019-07-17  Tom Tromey  <tom@tromey.com>
7198
7199         * tui/tui-regs.c (tui_show_registers): Simplify.
7200
7201 2019-07-17  Tom Tromey  <tom@tromey.com>
7202
7203         * tui/tui-regs.c (tui_show_registers): Update.
7204         (tui_show_register_group): Add win_info parameter.
7205
7206 2019-07-17  Tom Tromey  <tom@tromey.com>
7207
7208         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7209         Rename from tui_display_reg_element_at_line.
7210         (tui_data_window::display_registers_from_line): Update.
7211         * tui/tui-data.h (struct tui_data_window)
7212         <display_reg_element_at_line>: New method.
7213
7214 2019-07-17  Tom Tromey  <tom@tromey.com>
7215
7216         * tui/tui-regs.h (tui_display_registers_from)
7217         (tui_display_registers_from_line): Don't declare.
7218         * tui/tui-windata.c (tui_data_window::display_all_data)
7219         (tui_data_window::refresh_all)
7220         (tui_data_window::do_scroll_vertical): Update.
7221         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7222         from tui_display_registers_from.
7223         (tui_display_reg_element_at_line): Update.
7224         (tui_data_window::display_registers_from_line): Rename from
7225         tui_display_registers_from_line.
7226         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7227         display_registers_from_line>: New methods.
7228
7229 2019-07-17  Tom Tromey  <tom@tromey.com>
7230
7231         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7232         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7233         from tui_erase_data_content.
7234         (tui_data_window::display_all_data)
7235         (tui_data_window::refresh_all)
7236         (tui_data_window::do_scroll_vertical): Update.
7237         * tui/tui-regs.c (tui_show_registers): Update.
7238         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7239         New method.
7240
7241 2019-07-17  Tom Tromey  <tom@tromey.com>
7242
7243         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7244         declare.
7245         * tui/tui-windata.c
7246         (tui_data_window::delete_data_content_windows): Rename from
7247         tui_delete_data_content_windows.
7248         (tui_data_window::display_all_data)
7249         (tui_data_window::do_scroll_vertical): Update.
7250         * tui/tui-data.h (struct tui_data_window)
7251         <delete_data_content_windows>: New method.
7252
7253 2019-07-17  Tom Tromey  <tom@tromey.com>
7254
7255         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7256         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7257
7258 2019-07-17  Tom Tromey  <tom@tromey.com>
7259
7260         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7261         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7262         from tui_display_all_data.
7263         * tui/tui-win.c
7264         (tui_data_window::do_make_visible_with_new_height): Update.
7265         * tui/tui-regs.c (tui_show_registers): Update.
7266         * tui/tui-layout.c (tui_set_layout): Update.
7267         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7268         method.
7269
7270 2019-07-17  Tom Tromey  <tom@tromey.com>
7271
7272         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7273         * tui/tui-windata.c (tui_display_data_from): Remove.
7274         (tui_data_window::refresh_all): Update.
7275
7276 2019-07-17  Tom Tromey  <tom@tromey.com>
7277
7278         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7279         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7280         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7281         tui_display_registers_from_line.
7282         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7283         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7284         "force_display" parameter.
7285
7286 2019-07-17  Tom Tromey  <tom@tromey.com>
7287
7288         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7289         declare.
7290         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7291         Rename from tui_first_reg_element_no_inline.
7292         (tui_display_reg_element_at_line)
7293         (tui_display_registers_from_line): Update.
7294         * tui/tui-data.h (struct tui_data_window)
7295         <first_reg_element_no_inline>: New method.
7296
7297 2019-07-17  Tom Tromey  <tom@tromey.com>
7298
7299         * tui/tui-windata.c (tui_display_data_from)
7300         (tui_data_window::do_scroll_vertical): Update.
7301         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7302         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7303         Rename from tui_line_from_reg_element_no.
7304         (tui_display_registers_from_line): Update.
7305         * tui/tui-data.h (struct tui_data_window)
7306         <line_from_reg_element_no>: New method.
7307
7308 2019-07-17  Tom Tromey  <tom@tromey.com>
7309
7310         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7311         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7312         tui_last_regs_line_no.
7313         (tui_display_reg_element_at_line)
7314         (tui_display_registers_from_line): Update.
7315         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7316         method.
7317
7318 2019-07-17  Tom Tromey  <tom@tromey.com>
7319
7320         PR tui/24722:
7321         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7322         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7323         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7324         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7325         (tui_update_breakpoint_info): Likewise.
7326         * tui/tui-hooks.c (tui_event_create_breakpoint)
7327         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7328         Update.
7329
7330 2019-07-17  Tom Tromey  <tom@tromey.com>
7331
7332         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7333
7334 2019-07-17  Tom Tromey  <tom@tromey.com>
7335
7336         * tui/tui-winsource.c (tui_update_source_window_as_is)
7337         (tui_update_source_windows_with_addr): Update.
7338         * tui/tui-source.h (tui_set_source_content)
7339         (tui_show_symtab_source): Add "win_info" parameter.
7340         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7341         parameter.
7342         (tui_show_symtab_source): Likewise.
7343
7344 2019-07-17  Tom Tromey  <tom@tromey.com>
7345
7346         * tui/tui-wingeneral.c
7347         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7348
7349 2019-07-17  Tom Tromey  <tom@tromey.com>
7350
7351         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7352         (struct tui_cmd_window) <can_scroll>: New method.
7353         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7354         method.
7355
7356 2019-07-17  Tom Tromey  <tromey@adacore.com>
7357
7358         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7359         do_field_signed>: Rename.  Change type of "value".
7360         * ui-out.c (ui_out::field_signed): Rename from field_int.
7361         Change type of "value".
7362         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7363         type of "value".
7364         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7365         do_field_int.  Change type of "value".
7366         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7367         do_field_int.  Change type of "value".
7368         * tracepoint.c (trace_status_mi, tfind_1)
7369         (print_one_static_tracepoint_marker): Update.
7370         * thread.c (print_thread_info_1, print_selected_thread_frame):
7371         Update.
7372         * stack.c (print_frame, print_frame_info): Update.
7373         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7374         Update.
7375         * source.c (print_source_lines_base): Update.
7376         * skip.c (info_skip_command): Update.
7377         * record-btrace.c (btrace_ui_out_decode_error)
7378         (btrace_call_history_src_line): Update.
7379         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7380         Update.
7381         * progspace.c (print_program_space): Update.
7382         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7383         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7384         do_field_int.  Change type of "value".
7385         * mi/mi-out.c (mi_ui_out::do_table_begin)
7386         (mi_ui_out::do_table_header): Update.
7387         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7388         type of "value".
7389         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7390         (mi_cmd_data_list_changed_registers, output_register)
7391         (mi_cmd_data_read_memory, mi_load_progress)
7392         (mi_cmd_trace_frame_collected): Update.
7393         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7394         Update.
7395         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7396         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7397         (mi_cmd_var_list_children, varobj_update_one): Update.
7398         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7399         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7400         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7401         * inferior.c (print_inferior): Update.
7402         * gdb_bfd.c (print_one_bfd): Update.
7403         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7404         Update.
7405         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7406         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7407         do_field_int.  Change type of "value".
7408         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7409         do_field_int.  Change type of "value".
7410         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7411         (print_one_breakpoint_location, print_it_catch_fork)
7412         (print_one_catch_fork, print_it_catch_vfork)
7413         (print_one_catch_vfork, print_it_catch_solib)
7414         (print_it_catch_exec, print_it_ranged_breakpoint)
7415         (print_mention_watchpoint, print_mention_masked_watchpoint)
7416         (bkpt_print_it, update_static_tracepoint): Update.
7417         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7418         * break-catch-syscall.c (print_it_catch_syscall): Update.
7419         * ada-tasks.c (print_ada_task_info): Update.
7420         * ada-lang.c (print_it_exception, print_mention_exception):
7421         Update.
7422
7423 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7424
7425         PR breakpoints/24541
7426         * gdbarch.c: Regenerate.
7427         * gdbarch.h: Regenerate.
7428         * gdbarch.sh: Adjust return type and parameter types for
7429         'stap_adjust_register'.
7430         (i386_stap_adjust_register): Adjust signature and return new
7431         register name.
7432         * stap-probe.c (stap_parse_register_operand): Adjust use of
7433         'gdbarch_stap_adjust_register'.
7434
7435 2019-07-17  Tom Tromey  <tromey@adacore.com>
7436
7437         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7438         declare VEC.
7439         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7440         std::vector.
7441         (struct s390_process_info): Add initializers.
7442         (s390_add_process): Use new.
7443         (s390_linux_nat_target::low_forget_process): Use delete.
7444         (s390_linux_nat_target::low_new_fork)
7445         (s390_linux_nat_target::stopped_by_watchpoint)
7446         (s390_linux_nat_target::low_prepare_to_resume)
7447         (s390_linux_nat_target::insert_watchpoint)
7448         (s390_linux_nat_target::insert_hw_breakpoint)
7449         (s390_linux_nat_target::remove_watchpoint)
7450         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7451
7452 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7453
7454         * aarch64-fbsd-nat.c: Include regcache.h.
7455         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7456         argument.
7457         (aarch64_fbsd_nat_target::fetch_registers)
7458         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7459         variable.
7460         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7461
7462 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7463
7464         * fbsd-nat.c: Include gdbarch.h.
7465
7466 2019-07-15  Tom Tromey  <tromey@adacore.com>
7467
7468         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7469
7470 2019-07-15  Tom Tromey  <tromey@adacore.com>
7471
7472         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7473         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7474         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7475         * cli-out.c (cli_ui_out::do_field_int): New method.
7476         * ui-out.c (ui_out::field_unsigned): New method.
7477         * symfile.c (generic_load): Use field_unsigned.
7478         (print_transfer_performance): Likewise.
7479         * record-btrace.c (ui_out_field_uint): Remove.
7480         (btrace_call_history_insn_range, btrace_call_history): Use
7481         field_unsigned.
7482         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7483         field_unsigned.
7484         * ui-out.h (class ui_out) <field_unsigned>: New method.
7485         <do_field_unsigned>: Likewise.
7486
7487 2019-07-15  Tom Tromey  <tromey@adacore.com>
7488
7489         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7490         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7491         * target.c (flash_erase_command): Use field_string.
7492         * infrun.c (print_signal_received_reason): Use field_string.
7493         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7494         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7495         field_string.
7496         * ada-tasks.c (print_ada_task_info): Use field_string.
7497
7498 2019-07-15  Tom Tromey  <tromey@adacore.com>
7499
7500         * target.c (flash_erase_command): Use field_core_addr.
7501         * symfile.c (generic_load): Use field_core_addr.
7502         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7503         Use field_core_addr.
7504         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7505         field_core_addr.
7506
7507 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7508
7509         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7510         value if its desired type is smaller than a CORE_ADDR and signed.
7511
7512 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7513
7514         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7515         of changes to field names, and use new is_reference field to
7516         decide if a property is a reference or not.
7517         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7518         field.
7519         (struct dwarf2_property_baton): Update header comment, rename
7520         'referenced_type' to 'property_type' and update comments.
7521         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7522         default property type, store in property baton, update to take
7523         accound of renamed field.
7524         (read_func_scope): Update call to attr_to_dynamic_prop.
7525         (read_array_type): Likewise.
7526         (dwarf2_per_cu_addr_sized_int_type): New function.
7527         (read_subrange_index_type): Move type finding code to
7528         dwarf2_per_cu_addr_sized_int_type.
7529         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7530         (dwarf2_per_cu_addr_type): New function.
7531         (set_die_type): Update calls to attr_to_dynamic_prop.
7532
7533 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7534
7535         * dwarf2read.c (read_subrange_index_type): New function.
7536         (read_subrange_type): Move code into new function and call it.
7537         * gdbtypes.c (create_range_type): Add some asserts.
7538
7539 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7540
7541         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7542         update return statements.
7543         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7544         declaration, and update comment to match.
7545         * gdbtypes.c (resolve_dynamic_array): Update call to
7546         dwarf2_evaluate_property to match new return type.
7547
7548 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7549
7550         * valarith.c (value_subscripted_rvalue): Change lowerbound
7551         parameter type from int to LONGEST.
7552         * value.h (value_subscripted_rvalue): Likewise in declaration.
7553
7554 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * cli/cli-utils.c (info_print_command_completer): New function.
7557         * cli/cli-utils.h: Add 'completer.h' include, and forward
7558         declaration for 'struct cmd_list_element'.
7559         (info_print_command_completer): Declare.
7560         * stack.c (_initialize_stack): Add completer for 'info locals' and
7561         'info args'.
7562         * symtab.c (_initialize_symtab): Add completer for 'info
7563         variables' and 'info functions'.
7564         * NEWS: Mention completion for additional info commands.
7565
7566 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7567
7568         * cli/cli-utils.c (extract_info_print_args): Delete.
7569         (extract_arg_maybe_quoted): Delete.
7570         (info_print_options_defs): New variable.
7571         (make_info_print_options_def_group): New function.
7572         (extract_info_print_options): Define new function.
7573         * cli/cli-utils.h (extract_info_print_args): Delete.
7574         (struct info_print_options): New structure.
7575         (extract_info_print_options): Declare new function.
7576         * stack.c (info_locals_command): Update to use new
7577         extract_info_print_options, also add a header comment.
7578         (info_args_command): Likewise.
7579         * symtab.c (info_variables_command): Likewise.
7580         (info_functions_command): Likewise.
7581
7582 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7585         to extract string arguments.
7586         * common/common-utils.c (extract_string_maybe_quoted): New function.
7587         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7588
7589 2019-07-11  Tom Tromey  <tromey@adacore.com>
7590
7591         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7592         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7593         * top.h (gdbinit): Don't declare.
7594         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7595         into...
7596         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7597         * top.c (gdb_init): Don't call init_cli_cmds.
7598         (gdbinit): Remove.
7599         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7600
7601 2019-07-11  Tom Tromey  <tromey@adacore.com>
7602
7603         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7604         after it has been moved.
7605
7606 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7607
7608         * valops.c (value_must_coerce_to_target): Change return type to
7609         bool.
7610         * value.h (value_must_coerce_to_target): Likewise.
7611
7612 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7613
7614         * breakpoint.c (is_hardware_watchpoint): Remove
7615         forward-declaration.
7616         (is_masked_watchpoint): Change return type to bool.
7617         (is_tracepoint): Likewise.
7618         (is_breakpoint): Likewise.
7619         (is_hardware_watchpoint): Likewise.
7620         (is_watchpoint): Likewise.
7621         (is_no_memory_software_watchpoint): Likewise.
7622         (is_catchpoint): Likewise.
7623         (breakpoint_1): Make FILTER parameter's return type bool.
7624         is_masked_watchpoint): Change return type to bool.
7625         (save_breakpoints): Make FILTER parameter's return type bool.
7626         * breakpoint.h (is_breakpoint): Change return type to bool.
7627         (is_watchpoint): Likewise.
7628         (is_catchpoint): Likewise.
7629         (is_tracepoint): Likewise.
7630
7631 2019-07-10  Tom Tromey  <tom@tromey.com>
7632
7633         * defs.h: Don't include gdbarch.h.
7634         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7635         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7636         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7637         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7638         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7639         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7640         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7641         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7642         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7643         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7644         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7645         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7646         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7647         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7648         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7649         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7650         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7651         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7652         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7653         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7654         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7655         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7656         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7657         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7658         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7659         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7660         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7661
7662 2019-07-10  Tom Tromey  <tromey@adacore.com>
7663
7664         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7665         * breakpoint.c (init_ada_exception_breakpoint): Register as
7666         bp_catchpoint.
7667         (print_one_breakpoint_location, print_one_breakpoint): Use
7668         is_ada_exception_catchpoint.
7669         * ada-lang.c (class ada_catchpoint_location): Pass
7670         bp_loc_software_breakpoint to bp_location constructor.
7671         (is_ada_exception_catchpoint): New function.
7672
7673 2019-07-10  Tom Tromey  <tromey@adacore.com>
7674
7675         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7676         VEC.
7677         (struct arm_exidx_entry): New method operator<.
7678         (struct arm_exidx_data) <section_maps>: Change type.
7679         (arm_exidx_data_free): Remove.
7680         (arm_exidx_data_key): Change type.  Move lower.
7681         (arm_exidx_new_objfile): Update.
7682         (arm_compare_exidx_entries): Remove.
7683         (arm_find_exidx_entry, _initialize_arm_tdep)
7684
7685 2019-07-10  Tom Tromey  <tromey@adacore.com>
7686
7687         * solib-spu.c (ocl_program_data_key): Change type.
7688         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7689         Update.
7690
7691 2019-07-10  Tom Tromey  <tromey@adacore.com>
7692
7693         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7694         (struct solib_aix_inferior_data) <library_list>: Change type.
7695         (solib_aix_inferior_data_handle): Change type.
7696         (get_solib_aix_inferior_data): Update.
7697         (solib_aix_free_library_list): Remove.
7698         (library_list_start_library): Update.
7699         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7700         return type.
7701         (solib_aix_get_library_list)
7702         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7703         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7704
7705 2019-07-10  Tom Tromey  <tromey@adacore.com>
7706
7707         * solib-dsbt.c (struct dsbt_info): Add initializers.
7708         (solib_dsbt_pspace_data): Change type.
7709         (dsbt_pspace_data_cleanup): Remove.
7710         (get_dsbt_info, _initialize_dsbt_solib): Update.
7711
7712 2019-07-10  Tom Tromey  <tromey@adacore.com>
7713
7714         * spu-tdep.c (spu_overlay_data): Change type.
7715         (spu_get_overlay_table, spu_overlay_new_objfile)
7716         (_initialize_spu_tdep): Update.
7717
7718 2019-07-10  Tom Tromey  <tromey@adacore.com>
7719
7720         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7721         destructor.
7722         (dbx_objfile_data_key): Change type and declare later.
7723         (DBX_SYMFILE_INFO): Rewrite.
7724         * dbxread.c (dbx_objfile_data_key): Change type.
7725         (dbx_symfile_init): Update.
7726         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7727         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7728         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7729
7730 2019-07-10  Tom Tromey  <tromey@adacore.com>
7731
7732         * jit.c (jit_program_space_key): Change type.  Move lower.
7733         (get_jit_program_space_data): Update.
7734         (jit_program_space_data_cleanup): Remove.
7735         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7736         Update.
7737         (struct jit_program_space_data): Add initializers.
7738
7739 2019-07-10  Tom Tromey  <tromey@adacore.com>
7740
7741         * solib-darwin.c (struct darwin_info): Add initializers.
7742         (solib_darwin_pspace_data): Change type.
7743         (darwin_pspace_data_cleanup): Remove.
7744         (get_darwin_info, _initialize_darwin_solib): Update.
7745
7746 2019-07-10  Tom Tromey  <tromey@adacore.com>
7747
7748         * remote-sim.c (struct sim_inferior_data): Add initializers,
7749         constructor, and destructor.
7750         (sim_inferior_data_key): Change type.  Move lower.
7751         (check_for_duplicate_sim_descriptor): Update.
7752         (get_sim_inferior_data): Use new.  Update.
7753         (~sim_inferior_data_cleanup): Rename from
7754         sim_inferior_data_cleanup.  Simplify.
7755         (gdbsim_close_inferior, simulator_command)
7756         (sim_command_completer, _initialize_remote_sim): Update.
7757         (next_pid, INITIAL_PID): Move earlier.
7758
7759 2019-07-10  Tom Tromey  <tromey@adacore.com>
7760
7761         * python/python-internal.h (create_thread_object): Return
7762         gdbpy_ref.
7763         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7764         * python/py-inferior.c (struct threadlist_entry): Add
7765         constructor.
7766         <thread_obj>: Now a gdbpy_ref.
7767         (thread_to_thread_object): Update.
7768         (add_thread_object): Use new.
7769         (delete_thread_object): Use delete.
7770         (infpy_threads): Update.
7771         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7772         GIL.
7773
7774 2019-07-10  Tom Tromey  <tromey@adacore.com>
7775
7776         * valops.c (value_cast): Specialize error message for Ada.
7777
7778 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7779
7780         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7781
7782 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7783
7784         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7785         bpstat_should_step): Return bool, adjust comments.
7786         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7787         bpstat_should_step): Likewise.
7788
7789 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7790
7791         * features/Makefile: Use feature target descriptions for Arm.
7792         * features/arm/arm-core.c: Generate new file.
7793         * features/arm/arm-fpa.c: Likewise.
7794         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7795         * features/arm/arm-m-profile.c: Likewise.
7796         * features/arm/arm-vfpv2.c: Likewise.
7797         * features/arm/arm-vfpv3.c: Likewise.
7798         * features/arm/xscale-iwmmxt.c: Likewise.
7799         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7800
7801 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7802
7803         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7804         ptrace earlier.
7805
7806 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7807
7808         * features/aarch64-pauth.c: Regenerate.
7809
7810 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7811
7812         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7813         bool.
7814         (bpstat_what): Use false instead of 0.
7815
7816 2019-07-09  Pedro Alves  <palves@redhat.com>
7817
7818         * break-catch-throw.c (is_exception_catchpoint): New.
7819         * breakpoint.c (print_one_breakpoint_location): New parameter
7820         'raw_loc'.  Handle it.  Use
7821         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7822         looking at the breakpoint's type.
7823         (print_one_breakpoint): If handling "maint info breakpoints", also
7824         print locations of exception catchpoints.
7825         * breakpoint.h (is_exception_catchpoint): Declare.
7826
7827 2019-07-09  Pedro Alves  <palves@redhat.com>
7828
7829         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7830         "addr" field.
7831         (allocate_location_exception_catchpoint): New.
7832         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7833         (initialize_throw_catchpoint_ops): Install
7834         allocate_location_exception_catchpoint as allocate_location
7835         method.
7836         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7837         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7838         bp_loc_other.
7839         (breakpoint_address_is_meaningful): Delete.
7840         (bl_address_is_meaningful): New.
7841         (breakpoint_locations_match): Adjust comment.
7842         (bp_location_from_bp_type): New, factored out of...
7843         (bp_location::bp_location(breakpoint *)): ... this.
7844         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7845         factored out of...
7846         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7847         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7848         breakpoint_address_is_meaningful.
7849         (bp_locations_compare): Adjust comment.
7850         (update_global_location_list): Use bl_address_is_meaningful
7851         instead of breakpoint_address_is_meaningful.
7852         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7853         explicit.
7854         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7855         * python/py-breakpoint.c (bppy_get_location): No longer check
7856         whether location is null.
7857
7858 2019-07-09  Pedro Alves  <palves@redhat.com>
7859
7860         PR c++/15468
7861         * breakpoint.c (print_one_breakpoint_location): Remove
7862         single-location assert.
7863
7864 2019-07-09  Tom Tromey  <tom@tromey.com>
7865
7866         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7867         * configure: Rebuild.
7868         * configure.ac: Change common to gdbsupport.
7869         * gdbsupport: Rename from common.
7870         * acinclude.m4: Change common to gdbsupport.
7871         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7872         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7873         gdbsupport.
7874         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7875         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7876         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7877         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7878         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7879         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7880         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7881         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7882         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7883         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7884         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7885         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7886         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7887         coff-pe-read.c, command.h, compile/compile-c-support.c,
7888         compile/compile-c.h, compile/compile-cplus-symbols.c,
7889         compile/compile-cplus-types.c, compile/compile-cplus.h,
7890         compile/compile-loc2c.c, compile/compile.c, completer.c,
7891         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7892         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7893         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7894         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7895         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7896         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7897         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7898         features/aarch64-core.c, features/aarch64-fpu.c,
7899         features/aarch64-pauth.c, features/aarch64-sve.c,
7900         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7901         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7902         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7903         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7904         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7905         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7906         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7907         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7908         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7909         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7910         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7911         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7912         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7913         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7914         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7915         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7916         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7917         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7918         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7919         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7920         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7921         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7922         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7923         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7924         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7925         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7926         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7927         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7928         minsyms.c, mips-linux-tdep.c, namespace.h,
7929         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7930         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7931         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7932         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7933         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7934         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7935         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7936         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7937         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7938         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7939         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7940         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7941         procfs.c, producer.c, progspace.h, psymtab.h,
7942         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7943         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7944         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7945         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7946         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7947         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7948         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7949         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7950         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7951         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7952         target-memory.c, target.c, target.h, target/waitstatus.c,
7953         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7954         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7955         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7956         unittests/array-view-selftests.c,
7957         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7958         unittests/common-utils-selftests.c,
7959         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7960         unittests/format_pieces-selftests.c,
7961         unittests/function-view-selftests.c,
7962         unittests/lookup_name_info-selftests.c,
7963         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7964         unittests/mkdir-recursive-selftests.c,
7965         unittests/observable-selftests.c,
7966         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7967         unittests/parse-connection-spec-selftests.c,
7968         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7969         unittests/scoped_fd-selftests.c,
7970         unittests/scoped_mmap-selftests.c,
7971         unittests/scoped_restore-selftests.c,
7972         unittests/string_view-selftests.c, unittests/style-selftests.c,
7973         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7974         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7975         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7976         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7977         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7978         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7979
7980 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7981
7982         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7983         bool value.
7984         (decode_digits_ordinary): Set explicit_line field in sal.
7985         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7986         symtab_and_line that was set on an explicit line number in
7987         assembler code.  Do always update the recorded symtab and line if
7988         we do skip the prologue.
7989
7990 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7991
7992         * breakpoint.c (set_breakpoint_location_function): Remove
7993         explicit_loc parameter.
7994         (momentary_breakpoint_from_master): Update call to
7995         set_breakpoint_location_function.
7996         (add_location_to_breakpoint): Likewise.
7997
7998 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7999
8000         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8001         required features based on default bfd type when no specific bfd
8002         is present.
8003
8004 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8005
8006         * NEWS: Mention that GDB printf and eval commands can now print
8007         C-style and Ada-style convenience var strings without
8008         calling the inferior.
8009         * printcmd.c (printf_c_string): Locally print GDB internal var
8010         instead of transiting via the inferior.
8011         (printf_wide_c_string): Likewise.
8012
8013 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8014
8015         PR breakpoints/25011
8016         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8017
8018 2019-07-04  Tom Tromey  <tom@tromey.com>
8019
8020         PR tui/24724:
8021         * tui/tui-winsource.c (tui_clear_source_content): Update.
8022         (tui_source_window_base::set_is_exec_point_at): Fix comment.
8023         (tui_update_breakpoint_info): Update.
8024         (tui_set_exec_info_content): Update.
8025         * tui/tui-source.c (tui_set_source_content_nil): Update.
8026         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8027         has_break.
8028         * tui/tui-data.h (enum tui_bp_flag): New.
8029         (tui_bp_flags): New enum flags type.
8030         (struct tui_source_element) <break_mode>: Change type.  Rename
8031         from has_break.
8032         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8033         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
8034         constants.
8035         * tui/tui-winsource.h: Fix comment.
8036
8037 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8038
8039         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8040         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8041         (store_fpregs_to_thread)
8042         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8043         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8044         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8045         (IWMMXT_REGS_SIZE): Add define.
8046         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8047         (fetch_vfp_regs, store_vfp_regs)
8048         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8049         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8050
8051 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8052
8053         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8054         defines.
8055         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8056         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8057         (ARM_INT_REGISTER_SIZE): ...to this.
8058         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8059         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8060         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8061         (arm_linux_collect_gregset, supply_nwfpe_register)
8062         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8063         defines.
8064         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8065         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8066         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8067         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8068         (arm_return_in_memory, arm_store_return_value)
8069         (arm_get_longjmp_target, arm_register_g_packet_guesses)
8070         (arm_record_ld_st_multiple): Likewise.
8071         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8072         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8073
8074 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8075
8076         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8077         AARCH64_DISPLACED_MODIFIED_INSNS.
8078         * aarch64-tdep.c (struct aarch64_displaced_step_data)
8079         (aarch64_displaced_step_copy_insn): Likewise.
8080         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8081         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8082         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8083         ARM_DISPLACED_MODIFIED_INSNS.
8084         * arm-tdep.c (arm_gdbarch_init): Likewise.
8085         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8086         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8087         (struct arm_displaced_step_closure): Use
8088         ARM_DISPLACED_MODIFIED_INSNS.
8089
8090 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8091
8092         * features/Makefile: Remove unused xml files.
8093         * features/aarch64.xml: Remove.
8094         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8095         * features/i386/amd64-avx-avx512.xml: Remove.
8096         * features/i386/amd64-avx-linux.xml: Remove.
8097         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8098         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8099         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8100         * features/i386/amd64-avx-mpx.xml: Remove.
8101         * features/i386/amd64-avx.xml: Remove.
8102         * features/i386/amd64-linux.xml: Remove.
8103         * features/i386/amd64-mpx-linux.xml: Remove.
8104         * features/i386/amd64-mpx.xml: Remove.
8105         * features/i386/amd64.xml: Remove.
8106         * features/i386/i386-avx-avx512-linux.xml: Remove.
8107         * features/i386/i386-avx-avx512.xml: Remove.
8108         * features/i386/i386-avx-linux.xml: Remove.
8109         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8110         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8111         * features/i386/i386-avx-mpx-linux.xml: Remove.
8112         * features/i386/i386-avx-mpx.xml: Remove.
8113         * features/i386/i386-avx.xml: Remove.
8114         * features/i386/i386-linux.xml: Remove.
8115         * features/i386/i386-mmx-linux.xml: Remove.
8116         * features/i386/i386-mmx.xml: Remove.
8117         * features/i386/i386-mpx-linux.xml: Remove.
8118         * features/i386/i386-mpx.xml: Remove.
8119         * features/i386/i386.xml: Remove.
8120         * features/i386/x32-avx-avx512-linux.xml: Remove.
8121         * features/i386/x32-avx-linux.xml: Remove.
8122         * features/i386/x32-linux.xml: Remove.
8123
8124 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8125
8126         * regformats/aarch64.dat: Remove.
8127         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8128         * regformats/i386/amd64-avx-linux.dat: Remove.
8129         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8130         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8131         * regformats/i386/amd64-linux.dat: Remove.
8132         * regformats/i386/amd64-mpx-linux.dat: Remove.
8133         * regformats/i386/amd64.dat: Remove.
8134         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8135         * regformats/i386/i386-avx-linux.dat: Remove.
8136         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8137         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8138         * regformats/i386/i386-linux.dat: Remove.
8139         * regformats/i386/i386-mmx-linux.dat: Remove.
8140         * regformats/i386/i386-mpx-linux.dat: Remove.
8141         * regformats/i386/i386.dat: Remove.
8142         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8143         * regformats/i386/x32-avx-linux.dat: Remove.
8144         * regformats/i386/x32-linux.dat: Remove.
8145
8146 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8147
8148         * aarch64-tdep.c: Remove xml self tests.
8149         * amd64-linux-tdep.c: Likewise.
8150         * amd64-tdep.c: Likewise.
8151         * i386-linux-tdep.c: Likewise.
8152         * i386-tdep.c: Likewise.
8153
8154 2019-07-03  Pedro Alves  <palves@redhat.com>
8155
8156         PR cli/24732
8157         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8158         (pipe_cmd_option_defs): New.
8159         (make_pipe_cmd_options_def_group): New.
8160         (pipe_command): Use gdb::option::process_options.
8161         (pipe_command_completer): New function.
8162         (_initialize_cli_cmds): Install completer for "pipe" command.
8163
8164 2019-07-03  Pedro Alves  <palves@redhat.com>
8165
8166         * cli/cli-option.c (union option_value) <string>: New field.
8167         (struct option_def_and_value): Add ctor, move ctor, dtor and
8168         use DISABLE_COPY_AND_ASSIGN.
8169         (option_def_and_value::clear_value): New.
8170         (parse_option, save_option_value_in_ctx, get_val_type_str)
8171         (add_setshow_cmds_for_options): Handle var_string.
8172         * cli-option.h (union option_def::var_address) <string>: New
8173         field.
8174         (struct string_option_def): New.
8175         * maint-test-options.c (struct test_options_opts): Add default
8176         ctor and use DISABLE_COPY_AND_ASSIGN.
8177         <string_opt>: New field.
8178         (test_options_opts::~test_options_opts): New.
8179         (test_options_opts::dump): Also dump "-string".
8180         (test_options_option_defs): Install "string.
8181
8182 2019-07-03  Pedro Alves  <palves@redhat.com>
8183
8184         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8185         option_value with a null enumeration.
8186         (complete_options): Save the option values in the context.
8187         (save_option_value_in_ctx): New, factored out from ...
8188         (process_options): ... here.
8189         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8190         of the function.
8191         * maint-test-options.c (test_options_opts::dump): New, factored
8192         out from ...
8193         (maintenance_test_options_command_mode): ... here.
8194         (maintenance_test_options_command_completion_result): Delete.
8195         (maintenance_test_options_command_completion_text): Update
8196         comment.
8197         (maintenance_show_test_options_completion_result): Change
8198         prototype.  Just print
8199         maintenance_test_options_command_completion_text.
8200         (save_completion_result): New.
8201         (maintenance_test_options_completer_mode): Pass options context to
8202         complete_options, and then save a dump.
8203         (_initialize_maint_test_options): Use add_cmd to install "maint
8204         show test-options-completion-result".
8205
8206 2019-07-03  Pedro Alves  <palves@redhat.com>
8207
8208         * NEWS (New commands): Mention "with" and "maint with".
8209         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8210         (with_command, with_command_completer): New.
8211         (pipe_command): Adjust to new repeat_previous
8212         interface.
8213         (_initialize_cli_cmds): Install the "with" command and its "w"
8214         alias.
8215         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8216         declarations.
8217         * cli/cli-setshow.c (parse_cli_var_uinteger)
8218         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8219         argument strings for all var_types.
8220         (get_setshow_command_value_string): New, factored out from ...
8221         (do_show_command): ... this.
8222         * cli/cli-setshow.h: Include <string>.
8223         (get_setshow_command_value_string): Declare.
8224         * command.h (repeat_previous): Now returns const char *.  Adjust
8225         comment.
8226         * maint.c: Include "cli/cli-cmds.h".
8227         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8228         (_initialize_maint_cmds): Register the "maintenance with" command.
8229         * top.c (repeat_previous): Move bits from pipe_command here:
8230         Return the saved command line, if any; error out if there's no
8231         command to relaunch.
8232
8233 2019-07-03  Pedro Alves  <palves@redhat.com>
8234
8235         * NEWS (New commands): Mention "maint set/show test-settings"
8236         instead of "maint test-settings".
8237         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8238         (maintenance_test_settings_set_list): Rename to ...
8239         (maintenance_set_test_settings_list): ... this.
8240         (maintenance_test_settings_show_list): Rename to  ...
8241         (maintenance_show_test_settings_list): ... this.
8242         (maintenance_test_settings_cmd): Delete.
8243         (maintenance_test_settings_set_cmd): ...
8244         (maintenance_set_test_settings_cmd): ... this.
8245         (maintenance_test_settings_show_cmd): ...
8246         (maintenance_show_test_settings_cmd): ... this.
8247         (maintenance_test_settings_show_value_cmd):
8248         (maintenance_show_test_settings_value_cmd): ... this.
8249         (_initialize_maint_test_settings): No longer install the "maint
8250         test-settings" prefix command.  Rename "maint test-settings set"
8251         to "maint set test-settings", and "maint test-settings show" to
8252         "maint show test-settings".  Adjust all subcommands.
8253
8254 2019-07-03  Pedro Alves  <palves@redhat.com>
8255
8256         * maint-test-settings.c: Fix file's intro comment.  Replace all
8257         references to "test-options" with references to "test-settings",
8258         in comments.
8259
8260 2019-07-03  Pedro Alves  <palves@redhat.com>
8261
8262         * maint-test-settings.c (maintenance_test_settings_xxx)
8263         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8264         New.
8265         (maintenance_test_settings_enums): Use them.
8266         (maintenance_test_settings_enum): Default to
8267         maintenance_test_settings_xxx.
8268         (_initialize_maint_test_settings): Initialize
8269         MAINTENANCE_TEST_SETTINGS_FILENAME.
8270
8271 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8272
8273         * breakpoint.h (remove_breakpoints_inf): Change return type to
8274         void, move function documentation here.
8275         * breakpoint.c (remove_breakpoints_inf): Change return type to
8276         void, move function documentation to header.
8277
8278 2019-07-02  Pedro Alves  <palves@redhat.com>
8279
8280         * NEWS (Completion improvements): Mention "info threads".
8281         * thread.c (struct info_threads_opts, info_threads_option_defs)
8282         (make_info_threads_options_def_group): New.
8283         (info_threads_command): Use gdb::option::process_options.
8284         (info_threads_command_completer): New.
8285         (_initialize_thread): Use gdb::option::build_help to build the
8286         help text for "info threads".
8287
8288 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8289
8290         * defs.h (generic_load): Move from here...
8291         * symfile.h (generic_load): ... to here.  Rename name parameter
8292         to args.
8293         * symfile.c (generic_load): Add comment.
8294
8295 2019-07-01  Tom Tromey  <tromey@adacore.com>
8296
8297         * dwarf2read.c
8298         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8299         declaration of without_params.  Fix formatting.
8300
8301 2019-07-01  Tom Tromey  <tromey@adacore.com>
8302
8303         * ada-exp.y (find_primitive_type): Update.
8304         * ada-lang.h (ada_lookup_symbol): Update.
8305         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8306         parameter.
8307         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8308
8309 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8310
8311         PR breakpoints/24541
8312         * gdbarch.c: Regenerate.
8313         * gdbarch.h: Regenerate.
8314         * gdbarch.sh: Add 'stap_adjust_register'.
8315         * i386-tdep.c: Include '<unordered_set>'.
8316         (i386_stap_adjust_register): New function.
8317         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8318         * stap-probe.c (stap_parse_register_operand): Call
8319         'gdbarch_stap_adjust_register'.
8320
8321 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8322
8323         PR python/24742
8324         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8325         * python/python.c (do_start_initialization): Use 'xmalloc'
8326         instead of 'PyMem_Malloc'.
8327
8328 2019-06-28  Tom Tromey  <tromey@adacore.com>
8329
8330         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8331         for Ada.
8332
8333 2019-06-27  Tom Tromey  <tromey@adacore.com>
8334
8335         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8336         objfile_key.
8337         (arm_find_mapping_symbol, arm_record_special_symbol)
8338         (_initialize_arm_tdep): Update.
8339         (arm_objfile_data_free): Remove.
8340
8341 2019-06-27  Tom Tromey  <tromey@adacore.com>
8342
8343         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8344         to cp_print_static_field.
8345
8346 2019-06-26  Tom Tromey  <tromey@adacore.com>
8347
8348         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8349         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8350         declare.
8351
8352 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8353
8354         * features/aarch64-core.c (create_feature_aarch64_core):
8355         Regenerate.
8356         * features/aarch64-core.xml: Add cpsr flags.
8357
8358 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8359
8360         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8361         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8362
8363 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8364
8365         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8366         field.
8367         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8368         use.
8369         (arm_record_special_symbol): Don't insert new symbol in sorted
8370         position, push it at the end.
8371
8372 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8373
8374         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8375         (arm_mapping_symbol_s): Remove.
8376         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8377         (arm_mapping_symbol_vec): New typedef.
8378         (struct arm_per_objfile): Add constructor.
8379         <section_maps>: Change type to
8380         std::unique_ptr<arm_mapping_symbol_vec[]>.
8381         (arm_compare_mapping_symbols): Remove.
8382         (arm_find_mapping_symbol): Adjust to section_maps type change.
8383         (arm_objfile_data_free): Call delete on arm_per_objfile.
8384         (arm_record_special_symbol): Adjust to section_maps type change.
8385         Allocate arm_per_objfile with new.
8386
8387 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8388
8389         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8390         with the command prefix.
8391
8392 2019-06-25  Tom Tromey  <tom@tromey.com>
8393
8394         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8395         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8396
8397 2019-06-25  Tom Tromey  <tom@tromey.com>
8398
8399         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8400         type.
8401         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8402         protected.
8403
8404 2019-06-25  Tom Tromey  <tom@tromey.com>
8405
8406         * tui/tui-winsource.c
8407         (tui_source_window_base::set_is_exec_point_at): Add check against
8408         LOA_ADDRESS.
8409
8410 2019-06-25  Tom Tromey  <tom@tromey.com>
8411
8412         * tui/tui-source.c (tui_set_source_content): Don't check before
8413         xfree.
8414         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8415
8416 2019-06-25  Tom Tromey  <tom@tromey.com>
8417
8418         * tui/tui-winsource.h (tui_update_source_window_as_is)
8419         (tui_alloc_source_buffer, tui_line_is_displayed)
8420         (tui_addr_is_displayed): Change type of win_info.
8421         * tui/tui-winsource.c (tui_update_source_window_as_is)
8422         (tui_clear_source_content, tui_show_source_line)
8423         (tui_show_source_content, tui_source_window_base::refill)
8424         (tui_source_window_base::set_is_exec_point_at)
8425         (tui_source_window_base::set_is_exec_point_at)
8426         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8427         (tui_alloc_source_buffer, tui_line_is_displayed)
8428         (tui_addr_is_displayed): Change type of win_info.  Update.
8429         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8430         (tui_source_window_base::do_make_visible_with_new_height):
8431         Update.
8432         * tui/tui-source.c (tui_set_source_content)
8433         (tui_set_source_content_nil)
8434         (tui_source_window::do_scroll_vertical): Update.
8435         * tui/tui-layout.c (show_layout): Update.
8436         * tui/tui-disasm.c (tui_set_disassem_content)
8437         (tui_disasm_window::do_scroll_vertical): Update.
8438         * tui/tui-data.h (tui_win_content): Remove.
8439         (struct tui_gen_win_info) <content, content_size>: Remove.
8440         (struct tui_source_element): Add initializers and destructor.
8441         (union tui_which_element, struct tui_win_element): Remove.
8442         (struct tui_source_window_base) <content>: New field.
8443         (struct tui_data_window): Remove destructor.
8444         (tui_alloc_content, tui_free_win_content)
8445         (tui_free_all_source_wins_content): Don't declare.
8446         * tui/tui-data.c (tui_initialize_static_data): Update.
8447         (init_content_element, tui_alloc_content): Remove.
8448         (~tui_gen_win_info): Update.
8449         (~tui_data_window, tui_free_all_source_wins_content)
8450         (tui_free_win_content, free_content, free_content_elements):
8451         Remove.
8452
8453 2019-06-25  Tom Tromey  <tom@tromey.com>
8454
8455         * tui/tui-winsource.h (tui_clear_source_content)
8456         (tui_erase_source_content, tui_show_source_content): Change type
8457         of win_info.
8458         * tui/tui-winsource.c (tui_clear_source_content)
8459         (tui_erase_source_content, tui_show_source_content): Change type
8460         of win_info.
8461         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8462         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8463         win_info.
8464         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8465         win_info.
8466         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8467
8468 2019-06-25  Tom Tromey  <tom@tromey.com>
8469
8470         * tui/tui-winsource.c (tui_clear_source_content)
8471         (tui_source_window_base::set_is_exec_point_at): Update.
8472         * tui/tui-source.c (tui_set_source_content_nil): Update.
8473         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8474         a bool.
8475         * tui/tui-data.c (init_content_element): Update.
8476
8477 2019-06-25  Tom Tromey  <tom@tromey.com>
8478
8479         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8480         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8481         * tui/tui-layout.c (init_and_make_win): Update.
8482         * tui/tui.h (enum tui_win_type): Update.
8483         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8484         tui_win_is_auxillary.
8485         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8486         tui_win_is_auxillary.
8487
8488 2019-06-25  Tom Tromey  <tom@tromey.com>
8489
8490         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8491         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8492         (tui_delete_data_content_windows, tui_display_all_data)
8493         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8494         Update.
8495         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8496         * tui/tui-regs.c (tui_last_regs_line_no)
8497         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8498         (tui_show_registers): Update.
8499         (tui_show_register_group): Return void.  Update.
8500         (tui_display_registers_from, tui_display_reg_element_at_line)
8501         (tui_display_registers_from_line, tui_check_register_values):
8502         Update.
8503         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8504         member.
8505         (struct tui_data_window) <regs_content>: Now a std::vector.
8506         <regs_content_count>: Remove.
8507         (tui_add_content_elements, tui_free_data_content): Don't declare.
8508         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8509         (init_content_element): Remove DATA_WIN case.  Add assert.
8510         (tui_add_content_elements): Remove.
8511         (tui_data_window): Update.
8512         (tui_free_data_content): Remove.
8513         (free_content_elements): Remove DATA_WIN case.
8514
8515 2019-06-25  Tom Tromey  <tom@tromey.com>
8516
8517         * tui/tui-data.c (tui_data_item_window): Update.
8518         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8519         * tui/tui-windata.c (tui_display_all_data)
8520         (tui_display_data_from_line): Update.
8521         (tui_check_data_values): Remove.
8522         * tui/tui-regs.c (tui_show_register_group)
8523         (tui_display_reg_element_at_line): Update.
8524         * tui/tui-hooks.c (tui_register_changed)
8525         (tui_refresh_frame_and_register_information): Call
8526         tui_check_register_values.
8527         * tui/tui-data.h (struct tui_data_window) <data_content,
8528         data_content_count, data_type>: Remove.
8529         (enum tui_data_type): Remove.
8530
8531         * tui/tui-data.c (tui_data_window::clear_detail)
8532         (~tui_data_window): Update.
8533
8534 2019-06-25  Tom Tromey  <tom@tromey.com>
8535
8536         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8537         declare.
8538         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8539         Rename from tui_first_data_item_displayed.  Update.
8540         (tui_data_window::refresh_all)
8541         (tui_data_window::do_scroll_vertical): Update.
8542         * tui/tui-data.h (struct tui_data_window)
8543         <first_data_item_displayed>: Declare new method.
8544
8545 2019-06-25  Tom Tromey  <tom@tromey.com>
8546
8547         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8548         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8549         contents...
8550         (tui_initialize_static_data): ...here.
8551
8552 2019-06-25  Tom Tromey  <tom@tromey.com>
8553
8554         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8555         (tui_display_registers_from, tui_check_register_values): Update.
8556         (tui_display_register): Remove win_info parameter; update.
8557         (tui_get_register): Change type of parameters.
8558         * tui/tui-data.h (struct tui_data_element): Remove.
8559         (union tui_which_element) <data>: Remove.
8560         <data_window>: Change type.
8561         (struct tui_data_item_window): New.
8562         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8563         case.  Add assert.
8564         (~tui_data_item_window): New destructor.
8565         (free_content_elements): Remove DATA_ITEM_WIN case.
8566
8567 2019-06-25  Tom Tromey  <tom@tromey.com>
8568
8569         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8570         Remove.
8571
8572 2019-06-25  Tom Tromey  <tom@tromey.com>
8573
8574         * tui/tui-data.h (struct tui_command_element): Remove.
8575         (union tui_which_element) <command>: Remove.
8576         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8577         assert.
8578         (free_content_elements): Remove CMD_WIN case.
8579
8580 2019-06-25  Tom Tromey  <tom@tromey.com>
8581
8582         * tui/tui-layout.c (tui_set_layout): Update.
8583         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8584         * tui/tui-data.c (layout_def): Update.
8585
8586 2019-06-25  Tom Tromey  <tom@tromey.com>
8587
8588         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8589         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8590         (tui_source_window_base::set_new_height): Update.
8591         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8592         Update.
8593         (tui_set_locator_fullname, tui_set_locator_info)
8594         (tui_show_frame_info): Update.
8595         * tui/tui-source.c (tui_set_source_content)
8596         (tui_source_is_displayed): Update.
8597         * tui/tui-layout.c (show_source_disasm_command, show_data)
8598         (show_source_or_disasm_and_command): Update.
8599         * tui/tui-disasm.c (tui_set_disassem_content)
8600         (tui_get_begin_asm_address): Update.
8601         * tui/tui-data.h (struct tui_locator_element): Remove.
8602         (union tui_which_element) <locator>: Remove.
8603         (struct tui_locator_window): New.
8604         (tui_locator_win_info_ptr): Change return type.
8605         * tui/tui-data.c (_locator): Change type.
8606         (tui_locator_win_info_ptr): Change return type.
8607         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8608         (tui_alloc_content): Add assert.
8609
8610 2019-06-25  Tom Tromey  <tom@tromey.com>
8611
8612         * tui/tui-winsource.c
8613         (tui_exec_info_window::maybe_allocate_content): New method.
8614         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8615         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8616         (make_source_or_disasm_window): Add cast.
8617         * tui/tui-data.h (union tui_which_element) <simple_string>:
8618         Remove.
8619         (struct tui_source_info): New.
8620         (struct tui_source_window_base) <execution_info>: Change type.
8621         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8622         case, and add assert.
8623         (tui_alloc_content): Add assert.
8624
8625 2019-06-25  Tom Tromey  <tom@tromey.com>
8626
8627         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8628         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8629         * tui/tui-data.c (tui_alloc_win_info): Remove.
8630
8631 2019-06-25  Tom Tromey  <tom@tromey.com>
8632
8633         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8634         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8635         can_highlight.
8636
8637 2019-06-25  Tom Tromey  <tom@tromey.com>
8638
8639         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8640         make_visible_with_new_height method.
8641         (tui_win_info::make_visible_with_new_height): New method.
8642         (tui_source_window_base::do_make_visible_with_new_height)
8643         (tui_data_window::do_make_visible_with_new_height)
8644         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8645         (make_visible_with_new_height): Remove.
8646         (tui_resize_all, tui_adjust_win_heights): Use
8647         make_visible_with_new_height method.
8648         * tui/tui-data.h (struct tui_win_info)
8649         <do_make_visible_with_new_height, make_visible_with_new_height>:
8650         New methods.
8651         (struct tui_source_window_base, struct tui_data_window)
8652         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8653         methods.
8654
8655 2019-06-25  Tom Tromey  <tom@tromey.com>
8656
8657         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8658         method.
8659         (update_tab_width): Call update_tab_width method.
8660         * tui/tui-data.h (struct tui_win_info)
8661         (struct tui_source_window_base) <update_tab_width>: New methods.
8662
8663 2019-06-25  Tom Tromey  <tom@tromey.com>
8664
8665         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8666         parameter.
8667         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8668         parameter.
8669         (tui_gen_win_info::make_visible): Update.
8670         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8671         parameter.
8672         * tui/tui-data.h (enum tui_box): New enum.
8673         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8674
8675 2019-06-25  Tom Tromey  <tom@tromey.com>
8676
8677         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8678         init_and_make_win for EXEC_INFO_WIN.
8679         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8680         longer inline.
8681         (struct tui_win_info) <~tui_win_info>: Inline.
8682         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8683         Don't declare.
8684         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8685         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8686         Remove.
8687         (tui_initialize_static_data): Update.
8688         (~tui_gen_win_info): Handle more cleanup here.
8689         (~tui_source_window_base): Delete "execution_info".
8690         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8691
8692 2019-06-25  Tom Tromey  <tom@tromey.com>
8693
8694         * tui/tui-layout.c (make_command_window): Don't set
8695         can_highlight.
8696         (show_source_disasm_command): Call the reset method.
8697         (show_data): Don't set can_highlight.  Call the reset method.
8698         (tui_gen_win_info::reset): Rename from init_gen_win_info
8699         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8700         (show_source_or_disasm_and_command): Call the reset method.
8701         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8702         (struct tui_cmd_window): Set can_highlight.
8703
8704 2019-06-25  Tom Tromey  <tom@tromey.com>
8705
8706         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8707         from make_visible.
8708         (tui_make_visible, tui_make_invisible): Rewrite.
8709         (tui_win_info::make_visible): Remove.
8710         (tui_source_window_base::make_visible): Update.
8711         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8712         method.  Moved from...
8713         (struct tui_win_info) <make_visible>: ...here.
8714
8715 2019-06-25  Tom Tromey  <tom@tromey.com>
8716
8717         * tui/tui-winsource.c
8718         (tui_source_window_base::do_scroll_horizontal): Remove direction
8719         parameter.
8720         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8721         direction parameter.
8722         * tui/tui-win.c (tui_win_info::forward_scroll)
8723         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8724         (tui_win_info::right_scroll): Update.
8725         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8726         direction parameter.
8727         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8728         direction parameter.
8729         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8730         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8731         Remove direction parameter.
8732         (struct tui_source_window_base, struct tui_source_window)
8733         (struct tui_disasm_window, struct tui_data_window)
8734         (struct tui_cmd_window): Update.
8735
8736 2019-06-25  Tom Tromey  <tom@tromey.com>
8737
8738         * tui/tui-winsource.h (tui_set_exec_info_content)
8739         (tui_show_exec_info_content, tui_erase_exec_info_content)
8740         (tui_clear_exec_info_content, tui_update_exec_info): Change
8741         argument to tui_source_window_base.
8742         * tui/tui-winsource.c (tui_set_exec_info_content)
8743         (tui_show_exec_info_content, tui_erase_exec_info_content)
8744         (tui_clear_exec_info_content, tui_update_exec_info): Change
8745         argument to tui_source_window_base.
8746
8747 2019-06-25  Tom Tromey  <tom@tromey.com>
8748
8749         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8750         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8751
8752 2019-06-25  Tom Tromey  <tom@tromey.com>
8753
8754         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8755         check.
8756
8757 2019-06-25  Tom Tromey  <tom@tromey.com>
8758
8759         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8760         type to void.
8761         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8762         type to void.
8763         * tui/tui-source.c (tui_set_source_content): Update.
8764         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8765
8766 2019-06-25  Tom Tromey  <tom@tromey.com>
8767
8768         * tui/tui-win.c (window_name_completer, tui_set_focus)
8769         (tui_all_windows_info): Use name method.
8770         * tui/tui-data.h (struct tui_gen_win_info)
8771         (struct tui_source_window, struct tui_disasm_window)
8772         (struct tui_data_window, struct tui_cmd_window) <name>: New
8773         method.
8774         (tui_win_name): Don't declare.
8775         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8776         (tui_win_name): Remove.
8777
8778 2019-06-25  Tom Tromey  <tom@tromey.com>
8779
8780         * tui/tui-winsource.h (tui_update_source_window)
8781         (tui_update_source_window_as_is): Change parameter type.
8782         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8783         to be a tui_source_window_base.
8784         (tui_update_source_window_as_is): Likewise.
8785         * tui/tui-win.c (make_visible_with_new_height): Update.
8786
8787 2019-06-25  Tom Tromey  <tom@tromey.com>
8788
8789         * tui/tui-winsource.c (tui_erase_source_content)
8790         (tui_show_source_content, tui_show_exec_info_content)
8791         (tui_erase_exec_info_content): Use refresh_window method.
8792         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8793         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8794         from tui_refresh_win.
8795         (tui_data_window::refresh_window): New method.
8796         (tui_win_info::refresh, tui_source_window_base::refresh)
8797         (tui_refresh_all): Use refresh_window method.
8798         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8799         method.
8800         * tui/tui-regs.c (tui_display_register): Call refresh_window
8801         method.
8802         * tui/tui-layout.c (show_source_disasm_command)
8803         (show_source_or_disasm_and_command): Call refresh_window method.
8804         * tui/tui-data.h (struct tui_gen_win_info)
8805         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8806         New method.
8807
8808 2019-06-25  Tom Tromey  <tom@tromey.com>
8809
8810         * tui/tui.c (tui_rl_other_window, tui_enable)
8811         (tui_is_window_visible, tui_get_command_dimension): Update.
8812         * tui/tui-winsource.c (tui_update_source_window_as_is)
8813         (tui_clear_source_content, tui_erase_source_content)
8814         (tui_show_source_line, tui_source_window_base::refill)
8815         (tui_source_window_base::do_scroll_horizontal)
8816         (tui_source_window_base::set_is_exec_point_at)
8817         (tui_update_breakpoint_info, tui_set_exec_info_content)
8818         (tui_alloc_source_buffer, tui_line_is_displayed)
8819         (tui_addr_is_displayed): Update.
8820         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8821         (tui_check_and_display_highlight_if_needed)
8822         (tui_win_info::make_visible, tui_win_info::refresh)
8823         (tui_refresh_all): Update.
8824         * tui/tui-windata.c (tui_first_data_item_displayed)
8825         (tui_delete_data_content_windows, tui_erase_data_content)
8826         (tui_display_all_data, tui_data_window::refresh_all)
8827         (tui_check_data_values): Update.
8828         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8829         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8830         (tui_win_info::backward_scroll, tui_refresh_all_win)
8831         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8832         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8833         (tui_source_window_base::set_new_height)
8834         (tui_data_window::set_new_height)
8835         (make_invisible_and_set_new_height)
8836         (make_visible_with_new_height, new_height_ok)
8837         (parse_scrolling_args): Update.
8838         * tui/tui-stack.c (tui_show_frame_info): Update.
8839         * tui/tui-source.c (tui_set_source_content)
8840         (tui_set_source_content_nil, tui_source_is_displayed)
8841         (tui_source_window::do_scroll_vertical): Update.
8842         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8843         (tui_display_registers_from, tui_display_reg_element_at_line)
8844         (tui_check_register_values, tui_reg_command): Update.
8845         * tui/tui-layout.c (tui_default_win_height)
8846         (show_source_disasm_command, show_data, init_and_make_win)
8847         (show_source_or_disasm_and_command): Update.
8848         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8849         (tui_redisplay_readline, tui_mld_flush)
8850         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8851         (tui_getc): Update.
8852         * tui/tui-disasm.c (tui_set_disassem_content)
8853         (tui_disasm_window::do_scroll_vertical): Update.
8854         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8855         Now virtual.
8856         (struct tui_win_info): Derive from tui_gen_win_info.
8857         <~tui_win_info>: Mark as override.
8858         <generic>: Remove member.
8859         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8860         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8861         (~tui_data_window, ~tui_win_info)
8862         (tui_free_all_source_wins_content): Update.
8863         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8864
8865 2019-06-25  Tom Tromey  <tom@tromey.com>
8866
8867         * tui/tui-layout.c (init_and_make_win): Use new.
8868         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8869         destructor, initializers.
8870         (tui_alloc_generic_win_info): Don't declare.
8871         * tui/tui-data.c (_locator): Add argument to constructor.
8872         (source_win, disasm_win): New globals.
8873         (exec_info): Remove.
8874         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8875         Update.
8876         (tui_alloc_generic_win_info): Remove.
8877         (init_content_element): Use new.
8878         (tui_win_info::tui_win_info): Update.
8879         (free_content_elements) <case DATA_WIN>: Use delete.
8880
8881 2019-06-25  Tom Tromey  <tom@tromey.com>
8882
8883         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8884         * tui/tui-windata.c (tui_first_data_item_displayed)
8885         (tui_delete_data_content_windows): Update.
8886         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8887         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8888         (tui_display_registers_from, tui_check_register_values): Update.
8889         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8890         pointer.
8891         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8892         window.
8893         (tui_free_data_content): Update.
8894         (free_content_elements) <case DATA_WIN>: Free the window.
8895
8896 2019-06-25  Tom Tromey  <tom@tromey.com>
8897
8898         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8899         Update.
8900         * tui/tui-layout.c (make_command_window)
8901         (show_source_disasm_command, show_data, init_and_make_win)
8902         (show_source_or_disasm_and_command): Update.
8903         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8904         method.
8905         <can_highight, is_highlighted>: Now bool.
8906         (tui_set_win_highlight): Don't declare.
8907         * tui/tui-data.c (tui_set_win_highlight): Remove.
8908
8909 2019-06-25  Tom Tromey  <tom@tromey.com>
8910
8911         * tui/tui-wingeneral.c (make_visible): Remove check of window
8912         type.
8913
8914 2019-06-25  Tom Tromey  <tom@tromey.com>
8915
8916         * tui/tui-win.c (tui_win_info::max_height)
8917         (tui_cmd_window::max_height): New methods.
8918         (new_height_ok): Call max_height.
8919         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8920         <max_height>: New method.
8921
8922 2019-06-25  Tom Tromey  <tom@tromey.com>
8923
8924         * tui/tui-win.c (tui_source_window_base::set_new_height)
8925         (tui_data_window::set_new_height): New methods.
8926         (make_invisible_and_set_new_height): Call set_new_height method.
8927         * tui/tui-data.h (struct tui_win_info)
8928         (struct tui_source_window_base, struct tui_data_window)
8929         <set_new_height>: New method.
8930
8931 2019-06-25  Tom Tromey  <tom@tromey.com>
8932
8933         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8934         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8935         tui_refresh_data_win.
8936         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8937         method.
8938         (tui_refresh_all_win): Call the refresh_all method.
8939         (tui_set_focus): Likewise.
8940         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8941         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8942         Likewise.
8943
8944 2019-06-25  Tom Tromey  <tom@tromey.com>
8945
8946         * tui/tui-winsource.h (tui_refill_source_window)
8947         (tui_set_is_exec_point_at): Don't declare.
8948         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8949         (tui_source_window_base::refill): Rename from
8950         tui_refill_source_window.
8951         (tui_source_window_base::do_scroll_horizontal): Update.
8952         (tui_source_window_base::set_is_exec_point_at): Rename from
8953         tui_set_is_exec_point_at.
8954         (tui_update_all_breakpoint_info): Update.
8955         * tui/tui-stack.c (tui_show_frame_info): Update.
8956         * tui/tui-layout.c (show_data): Add cast.
8957         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8958         * tui/tui-data.h (struct tui_source_window_base) <refill,
8959         set_is_exec_point_at>: New methods.
8960         (tui_source_windows, tui_add_to_source_windows): Update types.
8961         (tui_add_to_source_windows): Remove redundant declaration.
8962         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8963         (tui_source_windows): Change return type.
8964         (tui_clear_source_windows_detail): Update.
8965         (tui_add_to_source_windows): Change type of parameter.
8966         (tui_free_all_source_wins_content): Update.
8967
8968 2019-06-25  Tom Tromey  <tom@tromey.com>
8969
8970         * tui/tui-wingeneral.c (tui_win_info::refresh)
8971         (tui_source_window_base::refresh): New methods.
8972         (tui_refresh_all): Call the refresh method.
8973         * tui/tui-data.h (struct tui_win_info)
8974         (struct tui_source_window_base) <refresh>: New method.
8975
8976 2019-06-25  Tom Tromey  <tom@tromey.com>
8977
8978         * tui/tui.h (tui_is_window_visible): Return bool.
8979         * tui/tui.c (tui_is_window_visible): Return bool.
8980         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8981         (tui_make_visible, tui_make_invisible)
8982         (tui_win_info::make_visible)
8983         (tui_source_window_base::make_visible, make_all_visible)
8984         (tui_make_all_visible, tui_make_all_invisible): Update.
8985         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8986         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8987         bool.
8988         (struct tui_win_info, struct tui_source_window_base)
8989         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8990         * tui/tui-data.c (tui_init_generic_part): Update.
8991
8992 2019-06-25  Tom Tromey  <tom@tromey.com>
8993
8994         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8995         (tui_source_window_base::make_visible): New methods.
8996         (make_all_visible): Make method call.
8997         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8998         (struct tui_source_window_base, struct tui_cmd_window): Override
8999         make_visible.
9000         (tui_win_is_source_type): Don't declare.
9001         * tui/tui-data.c (tui_win_is_source_type): Remove.
9002
9003 2019-06-25  Tom Tromey  <tom@tromey.com>
9004
9005         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9006         NULL check.
9007
9008 2019-06-25  Tom Tromey  <tom@tromey.com>
9009
9010         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9011         Inline constructor.  Add initializers for members.
9012         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9013         constructors; now inline in class.
9014
9015 2019-06-25  Tom Tromey  <tom@tromey.com>
9016
9017         * tui/tui-regs.c (tui_show_registers): Update.
9018         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9019         bool.
9020         * tui/tui-data.c (tui_data_window::clear_detail)
9021         (tui_data_window): Update.
9022
9023 2019-06-25  Tom Tromey  <tom@tromey.com>
9024
9025         * tui/tui-windata.c (tui_display_all_data)
9026         (tui_display_data_from_line, tui_display_data_from)
9027         (tui_check_data_values, tui_data_window::do_scroll_vertical):
9028         Update.
9029         * tui/tui-regs.c (tui_last_regs_line_no)
9030         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9031         (tui_show_registers, tui_show_register_group)
9032         (tui_display_registers_from, tui_display_reg_element_at_line)
9033         (tui_display_registers_from_line, tui_check_register_values)
9034         (tui_reg_next, tui_reg_prev): Update.
9035         * tui/tui-layout.c (tui_set_layout, show_data): Update.
9036         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
9037         tui_data_window.
9038         (struct tui_win_info) <detail>: Remove.  Add new fields from
9039         tui_data_info.
9040         (TUI_DATA_WIN): Add cast.
9041         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9042         (~tui_data_window): Simplify.
9043
9044 2019-06-25  Tom Tromey  <tom@tromey.com>
9045
9046         * tui/tui-layout.c (show_source_disasm_command)
9047         (show_source_or_disasm_and_command): Update.
9048         * tui/tui-io.c (update_cmdwin_start_line)
9049         (tui_redisplay_readline): Update.
9050         * tui/tui-data.h (struct tui_command_info): Remove.
9051         (struct tui_win_info) <detail>: Remove command_info member.
9052         (struct tui_data_window) <start_line>: New member, from
9053         tui_command_info.
9054         (TUI_CMD_WIN): Add casts.
9055
9056 2019-06-25  Tom Tromey  <tom@tromey.com>
9057
9058         * tui/tui-winsource.c (tui_update_source_window)
9059         (tui_refill_source_window)
9060         (tui_source_window_base::do_scroll_horizontal)
9061         (tui_update_breakpoint_info, tui_set_exec_info_content)
9062         (tui_show_exec_info_content, tui_erase_exec_info_content)
9063         (tui_clear_exec_info_content): Update.
9064         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9065         Update.
9066         * tui/tui-win.c (make_invisible_and_set_new_height)
9067         (make_visible_with_new_height): Update.
9068         * tui/tui-source.c (tui_set_source_content)
9069         (tui_show_symtab_source): Update.
9070         * tui/tui-layout.c (extract_display_start_addr)
9071         (show_source_disasm_command, show_data)
9072         (make_source_or_disasm_window)
9073         (show_source_or_disasm_and_command): Update.
9074         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9075         (tui_disasm_window::do_scroll_vertical): Remove shadowing
9076         "gdbarch".
9077         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
9078         to tui_source_window_base.
9079         (struct tui_win_info) <detail>: Remove source_info member.
9080         (struct tui_source_window_base) <has_locator>: Inline.
9081         Move contents from tui_source_info; rename has_locator member to
9082         m_has_locator.
9083         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9084         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9085         header file.
9086         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9087         Simplify.
9088         (tui_free_all_source_wins_content): Cast to
9089         tui_source_window_base.
9090
9091 2019-06-25  Tom Tromey  <tom@tromey.com>
9092
9093         * tui/tui-win.c (make_invisible_and_set_new_height)
9094         (make_visible_with_new_height): Call has_locator method.
9095         * tui/tui-layout.c (show_source_disasm_command, show_data)
9096         (show_source_or_disasm_and_command): Update for bool change.
9097         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9098         (tui_win_info) <has_locator>: New method.
9099         (struct tui_source_window_base) <has_locator>: New method.
9100         (tui_win_has_locator): Don't declare.
9101         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9102         from tui_win_has_locator.
9103         (tui_source_window_base): Use false, not FALSE.
9104
9105 2019-06-25  Tom Tromey  <tom@tromey.com>
9106
9107         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9108         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9109         clear_detail method directly.
9110         (tui_clear_win_detail): Remove.
9111
9112 2019-06-25  Tom Tromey  <tom@tromey.com>
9113
9114         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9115         "this", not TUI_DISASM_WIN.
9116
9117 2019-06-25  Tom Tromey  <tom@tromey.com>
9118
9119         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9120         declare.
9121         * tui/tui-winsource.c
9122         (tui_source_window_base::do_scroll_horizontal): Rename from
9123         tui_horizontal_source_scroll.
9124         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9125         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9126         from tui_vertical_data_scroll.
9127         * tui/tui-win.h (tui_scroll): Don't declare.
9128         * tui/tui-win.c (tui_win_info::forward_scroll)
9129         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9130         (tui_win_info::right_scroll): Rename and update.
9131         (tui_scroll_forward_command, tui_scroll_backward_command)
9132         (tui_scroll_left_command, tui_scroll_right_command): Update.
9133         (tui_scroll): Remove.
9134         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9135         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9136         from tui_vertical_source_scroll.
9137         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9138         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9139         from tui_vertical_disassem_scroll.
9140         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9141         do_scroll_horizontal>: New methods.
9142         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9143         Likewise.
9144         (struct tui_source_window_base): Add do_scroll_horizontal.
9145         (struct tui_source_window, struct tui_disasm_window): Add
9146         do_scroll_vertical.
9147         (struct tui_data_window, struct tui_cmd_window): Add
9148         do_scroll_horizontal and do_scroll_vertical.
9149         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9150
9151 2019-06-25  Tom Tromey  <tom@tromey.com>
9152
9153         * tui/tui-data.h (struct tui_source_window_base): New struct.
9154         (struct tui_source_window): Derive from tui_source_window_base.
9155         (struct tui_disasm_window): New struct.
9156         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9157         from tui_source_window::clear_detail.
9158         (tui_source_window_base): Rename from tui_source_window.
9159         (~tui_source_window_base): Rename from ~tui_source_window.
9160         (tui_alloc_win_info): Create a tui_disasm_window.
9161
9162 2019-06-25  Tom Tromey  <tom@tromey.com>
9163
9164         * tui/tui-data.h (struct tui_source_window)
9165         (struct tui_data_window): Declare destructors.
9166         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9167         destructors.
9168         (tui_win_info): Simplify.
9169
9170 2019-06-25  Tom Tromey  <tom@tromey.com>
9171
9172         * tui/tui-winsource.c (tui_display_main)
9173         (tui_update_source_windows_with_addr)
9174         (tui_update_all_breakpoint_info): Update.
9175         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9176         (new_height_ok, parse_scrolling_args): Update.
9177         * tui/tui-stack.c (tui_show_frame_info): Update.
9178         * tui/tui-data.h (struct tui_list): Remove.
9179         (tui_source_windows): Return a reference to a std::vector.
9180         * tui/tui-data.c (source_windows): Now a std::vector.
9181         (tui_source_windows): Change return type.
9182         (tui_clear_source_windows): Rewrite.
9183         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9184         (tui_free_all_source_wins_content): Rewrite.
9185
9186 2019-06-25  Tom Tromey  <tom@tromey.com>
9187
9188         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9189         (struct tui_data_window, struct tui_cmd_window): Declare
9190         clear_detail method.
9191         * tui/tui-data.c (tui_source_window::clear_detail)
9192         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9193         methods.
9194         (tui_clear_win_detail): Simplify.
9195
9196 2019-06-25  Tom Tromey  <tom@tromey.com>
9197
9198         * tui/tui-layout.c (make_source_window, make_disasm_window)
9199         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9200         Return the new window.
9201         (show_source_disasm_command, show_data)
9202         (show_source_or_disasm_and_command): Update.
9203
9204 2019-06-25  Tom Tromey  <tom@tromey.com>
9205
9206         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9207         parameter.  Return the new window.
9208         (show_source_disasm_command): Update and remove NULL check.
9209         (show_source_or_disasm_and_command): Update.
9210
9211 2019-06-25  Tom Tromey  <tom@tromey.com>
9212
9213         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9214
9215 2019-06-25  Tom Tromey  <tom@tromey.com>
9216
9217         * tui/tui-data.h (struct tui_win_info): Make constructor
9218         protected.  Make destructor virtual.  Add initializers.
9219         (tui_source_window, tui_data_window, tui_cmd_window): New
9220         classes.
9221         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9222         constructor.  Add "type" parameter.
9223         (tui_source_window, tui_data_window, tui_cmd_window): New
9224         constructors.
9225         (tui_alloc_win_info): Instantiate the appropriate subclass.
9226
9227 2019-06-25  Tom Tromey  <tom@tromey.com>
9228
9229         * tui/tui-win.c (tui_resize_all): Use delete.
9230         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9231         destructor.
9232         (tui_free_window): Don't declare.
9233         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9234         Update.
9235
9236 2019-06-25  Tom Tromey  <tom@tromey.com>
9237
9238         * tui/tui-data.h (struct tui_win_info): Add constructor.
9239         * tui/tui-data.c (tui_alloc_win_info): Use new.
9240         (tui_free_window): Use delete.
9241
9242 2019-06-22  Tom Tromey  <tom@tromey.com>
9243
9244         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9245         declare.
9246         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9247
9248 2019-06-22  Tom Tromey  <tom@tromey.com>
9249
9250         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9251         declare.
9252         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9253
9254 2019-06-22  Tom de Vries  <tdevries@suse.de>
9255
9256         * dwarf2read.c (create_addrmap_from_aranges)
9257         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9258         instead of '%zu'.
9259
9260 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9261
9262         * dwarf2read.h (dwarf2_section_info_def): Remove.
9263         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9264         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9265         std::vector<dwarf2_section_info>.
9266         (struct dwo_file) <~dwo_file>: Remove.
9267         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9268         types field.
9269         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9270         (dwarf2_read_debug_names): Likewise.
9271         (create_debug_types_hash_table): Change parameter type to
9272         array_view, adjust code accordingly.
9273         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9274         (partial_die_info::fixup): Likewise.
9275         (determine_prefix): Likewise.
9276         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9277
9278 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9279
9280         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9281         gdb_bfd_ref_ptr.
9282         <~dwo_file>: Remove call to gdb_bfd_unref.
9283         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9284         gdb_bfd_ref_ptr::get.
9285
9286 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9287
9288         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9289         type to htab_up.
9290         * dwarf2read.c (struct dwo_file): Initialize fields.
9291         <~dwo_file>: New.
9292         (free_dwo_file): Remove, move content to ~dwo_file.
9293         (struct dwo_file_deleter): Remove.
9294         (dwo_file_up>: Remove custom deleter.
9295         (free_dwo_files): Remove.
9296         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9297         dwo_files.
9298         (process_skeletonless_type_units): Call unique_ptr::get.
9299         (allocate_dwo_file_hash_table): Add deleter to created hash
9300         table.  Change return type to htab_up.
9301         (lookup_dwo_file_slot): Don't memset dwo_file, call
9302         unique_ptr::get.
9303         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9304         (create_dwo_unit_in_dwp_v2): Likewise.
9305         (open_and_init_dwo_file): Likewise.
9306         (free_dwo_file_from_slot): Remove.
9307
9308 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9309
9310         * dwarf2read.h (struct dwarf2_section_info) <readin,
9311         is_virtual>: Change type to bool.
9312         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9313         true instead of 1.
9314
9315 2019-06-19  Tom Tromey  <tom@tromey.com>
9316
9317         * tui/tui-data.h (tui_init_content_element): Don't declare.
9318
9319 2019-06-19  Tom Tromey  <tom@tromey.com>
9320
9321         * tui/tui-data.h (tui_init_win_info): Don't declare.
9322
9323 2019-06-19  Tom de Vries  <tdevries@suse.de>
9324
9325         * dwarf2read.h (abstract_to_concrete): Change type to
9326         std::unordered_map<sect_offset, std::vector<sect_offset>,
9327         gdb::hash_enum<sect_offset>>.
9328
9329 2019-06-19  Tom Tromey  <tromey@adacore.com>
9330
9331         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9332         EVAL_AVOID_SIDE_EFFECTS specially.
9333
9334 2019-06-19  Tom Tromey  <tromey@adacore.com>
9335
9336         * source-cache.c (highlighter): New global.
9337         (source_cache::get_source_lines): Create a highlighter on demand.
9338
9339 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9340
9341         * defs.h (deprecated_interactive_hook): Delete declaration.
9342         * interps.c (clear_interpreter_hooks): Remove use of
9343         deprecated_interactive_hook.
9344         * top.c (deprecated_interactive_hook): Delete definition.
9345         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9346
9347 2019-06-18  Tom de Vries  <tdevries@suse.de>
9348
9349         PR gdb/24515
9350         * dwarf2read.h (abstract_to_concrete): Change type from
9351         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9352         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9353         * dwarf2read.c (read_variable): Update.
9354         (dwarf2_fetch_die_loc_sect_off): Update.
9355
9356 2019-06-17  Tom de Vries  <tdevries@suse.de>
9357
9358         PR gdb/24617
9359         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9360         accessing parent[parent_len - 1].
9361
9362 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9363
9364         PR gdb/24364
9365         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9366         call dtrace_process_dof with NULL dof.
9367
9368 2019-06-16  Tom de Vries  <tdevries@suse.de>
9369
9370         PR gdb/24445
9371         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9372
9373 2019-06-16  Tom Tromey  <tom@tromey.com>
9374
9375         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9376         (make_all_visible): Use address of member.
9377
9378 2019-06-16  Tom Tromey  <tom@tromey.com>
9379
9380         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9381         (tui_free_window, free_content, free_content_elements): Remove
9382         unnecessary cast.
9383         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9384         cast.
9385         * tui/tui-regs.c (tui_show_register_group)
9386         (tui_display_registers_from, tui_display_reg_element_at_line):
9387         Remove unnecessary cast.
9388
9389 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9390
9391         * linux-nat.c (normal_mask): Delete.
9392         (_initialize_linux_nat): Don't initialise normal_mask.
9393
9394 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9395
9396         PR gdb/24445
9397         * dwarf-index-write.h (write_psymtabs_to_index): Add
9398         dwz_basename parameter.
9399         * dwarf-index-write.c (write_gdbindex): Move file writing to
9400         write_gdbindex_1.  Change return type void.
9401         (assert_file_size): Move up, remove filename parameter.
9402         (write_gdbindex_1): New function.
9403         (write_debug_names): Change return type to void, call
9404         assert_file_size.
9405         (struct index_wip_file): New struct.
9406         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9407         file logic to index_wip_file.  Write index for dwz file if
9408         needed.
9409         (save_gdb_index_command): Pass basename of dwz file, if present.
9410         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9411         build-id of dwz file, if present.
9412         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9413         (dwarf2_get_dwz_file): Likewise.
9414         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9415         (dwarf2_get_dwz_file): Likewise.
9416
9417 2019-06-16  Tom Tromey  <tom@tromey.com>
9418
9419         * coffread.c (process_coff_symbol): Use xstrdup.
9420         * value.c (create_internalvar): Use xstrdup.
9421
9422 2019-06-16  Tom Tromey  <tom@tromey.com>
9423
9424         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9425         * breakpoint.c (stopin_command, stopat_command)
9426         (until_break_command, decode_location_default): Remove unnecessary
9427         cast.
9428         * utils.c (subset_compare): Remove unnecessary cast.
9429         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9430         cast.
9431         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9432         cast.
9433         * infcmd.c (path_command): Remove unnecessary cast.
9434         * coffread.c (decode_type): Remove unnecessary cast.
9435         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9436         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9437         * tui/tui-stack.c (tui_show_locator_content)
9438         (tui_show_frame_info): Remove unnecessary cast.
9439         * tui/tui-win.c (tui_scroll_forward_command)
9440         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9441         (parse_scrolling_args): Remove unnecessary cast.
9442         * tui/tui-data.c (init_win_info, tui_del_window)
9443         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9444         (free_content_elements): Remove unnecessary cast.
9445         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9446         unnecessary cast.
9447         * tui/tui-source.c (tui_set_source_content)
9448         (tui_vertical_source_scroll): Remove unnecessary cast.
9449         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9450         cast.
9451         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9452         * tui/tui-regs.c (tui_display_registers_from)
9453         (tui_display_register): Remove unnecessary cast.
9454         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9455         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9456         (make_visible): Remove unnecessary cast.
9457         * tui/tui-winsource.c (tui_erase_source_content)
9458         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9459         unnecessary cast.
9460         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9461         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9462         * stabsread.c (read_type, read_array_type, read_range_type):
9463         Remove unnecessary cast.
9464         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9465         (parse_symbol, parse_type, upgrade_type, parse_external)
9466         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9467         unnecessary cast.
9468         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9469
9470 2019-06-16  Tom Tromey  <tom@tromey.com>
9471
9472         * tui/tui-data.c (tui_alloc_generic_win_info)
9473         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9474         checks.
9475
9476 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9477             Andrew Burgess  <andrew.burgess@embecosm.com>
9478
9479         * f-typeprint.c (f_print_type): Don't return early for not
9480         associated or not allocated types.
9481         (f_type_print_varspec_suffix): Add print_rank parameter and print
9482         ranks of array types in case they dangling.
9483         (f_type_print_base): Add print_rank parameter.
9484
9485 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9486
9487         * NEWS: Mention new MI commands.
9488         * break-catch-throw.c (enum exception_event_kind): Move to
9489         breakpoint.h.
9490         (print_mention_exception_catchpoint): Output text as a single
9491         message.
9492         (catch_exception_command_1): Rename to...
9493         (catch_exception_event): ...this, make non-static, update header
9494         command, and change some parameter types.
9495         (catch_catch_command): Update for changes to
9496         catch_exception_command_1.
9497         (catch_throw_command): Likewise.
9498         (catch_rethrow_command): Likewise.
9499         * breakpoint.c (enum exception_event_kind): Delete.
9500         * breakpoint.h (enum exception_event_kind): Moved here from
9501         break-catch-throw.c.
9502         (catch_exception_event): Declare.
9503         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9504         (mi_cmd_catch_throw): New function.
9505         (mi_cmd_catch_rethrow): New function.
9506         (mi_cmd_catch_catch): New function.
9507         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9508         'catch-catch' entries.
9509         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9510         (mi_cmd_catch_rethrow): Declare.
9511         (mi_cmd_catch_catch): Declare.
9512
9513 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * annotate.c (annotate_source_line): Change return type to void,
9516         update implementation to match.
9517         * annotate.h (annotate_source_line): Change return type to void,
9518         update header comment.
9519         * stack.c (print_frame_info): Don't change what frame information
9520         is printed based on whether annotations are on or not.
9521
9522 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9523
9524         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9525         (annotate_source): Make static.
9526         (annotate_source_line): Moved from source.c and renamed from
9527         identify_source_line.  Update the return type.
9528         * annotate.h (annotate_source): Delete declaration.
9529         (annotate_source_line): Declaration moved from source.h, and
9530         renamed from identify_source_line.  Return type updated.
9531         * source.c (identify_source_line): Moved to annotate.c and renamed
9532         to annotate_source_line.
9533         (info_line_command): Remove check of annotation_level.
9534         * source.h (identify_source_line): Move declaration to annotate.h
9535         and rename to annotate_source_line.
9536         * stack.c: Add 'annotate.h' include.
9537         (print_frame_info): Remove check of annotation_level before
9538         calling annotate_source_line.
9539
9540 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9541
9542         * source-cache.c (source_cache::get_plain_source_lines): Use
9543         open_source_file_with_line_charpos instead of just
9544         open_source_file, remove call to find_source_lines.
9545         (source_cache::get_source_lines): Likewise.
9546         * source.c (find_source_lines): Make static.
9547         (get_filename_and_charpos): Renamed into...
9548         (open_source_file_with_line_charpos): ..this along with changes to
9549         return a scoped_fd, and some other minor clean ups.
9550         (identify_source_line): Use open_source_file_with_line_charpos.
9551         (search_command_helper): Use open_source_file_with_line_charpos
9552         instead of just open_source_file, remove call to
9553         find_source_lines.
9554         * source.h (open_source_file_with_line_charpos): Declare new
9555         function.
9556         (find_source_lines): Delete declaration.
9557
9558 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9559
9560         * source.c (get_filename_and_charpos): Remove fullname
9561         parameter.
9562         (identify_source_line): Update call to get_filename_and_charpos.
9563
9564 2019-06-14  Tom Tromey  <tromey@adacore.com>
9565
9566         PR gdb/24502:
9567         * ui-style.h (skip_ansi_escape): Update comment.
9568         * ui-file.h (class no_terminal_escape_file): New class.
9569         * ui-file.c (no_terminal_escape_file::write)
9570         (no_terminal_escape_file::puts): New methods.
9571         * cli/cli-logging.c (handle_redirections): Use
9572         no_terminal_escape_file.
9573
9574 2019-06-14  Tom Tromey  <tromey@adacore.com>
9575
9576         * NEWS: Move convenience variable news above Python news.
9577
9578 2019-06-14  Tom Tromey  <tom@tromey.com>
9579
9580         * gnulib: Move directory to top-level.
9581         * configure.ac: Don't configure gnulib.
9582         * configure: Rebuild.
9583         * common/common-defs.h: Use new path to gnulib.
9584         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9585         (GNULIB_H): Remove.
9586         (INCGNU): Look in new gnulib location.
9587         (HFILES_NO_SRCDIR): Remove gnulib files.
9588         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9589         (generated_files): Remove GNULIB_H.
9590         ($(LIBGNU), all-lib): Remove targets.
9591         (distclean): Don't mention GNULIB_BUILDDIR.
9592         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9593
9594 2019-06-14  Tom Tromey  <tromey@adacore.com>
9595
9596         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9597         Warn if symbol file does not provide any symbols.
9598
9599 2019-06-14  Tom Tromey  <tromey@adacore.com>
9600
9601         * source.c (find_and_open_source): Respect basenames_may_differ.
9602
9603 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9604
9605         * annotate.c (annotate_breakpoints_invalid): Make use of
9606         scoped_restore_terminal_state.
9607         (annotate_frames_invalid): Likewise.
9608
9609 2019-06-14  Tom Tromey  <tromey@adacore.com>
9610
9611         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9612         allow assignment to an internalvar.
9613
9614 2019-06-14  Tom Tromey  <tromey@adacore.com>
9615
9616         * ada-lex.l: Allow "_" in attribute names.
9617
9618 2019-06-14  Tom Tromey  <tromey@adacore.com>
9619
9620         PR gdb/24653:
9621         * regcache.c (registers_changed): Don't call alloca.
9622         * top.c (execute_command): Don't call alloca.
9623
9624 2019-06-13  Pedro Alves  <palves@redhat.com>
9625
9626         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9627         'expression'.  When parsing an expression, error out if there's
9628         junk after "unlimited".
9629         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9630         (do_set_command): Adjust calls to is_unlimited_literal.
9631
9632 2019-06-13  Pedro Alves  <palves@redhat.com>
9633
9634         * compile/compile.c (make_compile_options_def_group): Add braces
9635         around array_view initializer.
9636         * thread.c (make_thread_apply_all_options_def_group)
9637         (make_thread_apply_all_options_def_group): Likewise.
9638
9639 2019-06-13  Pedro Alves  <palves@redhat.com>
9640
9641         * NEWS (New commands): Mention "maint test-options
9642         require-delimiter", "maint test-options unknown-is-error", "maint
9643         test-options unknown-is-operand" and "maint show
9644         test-options-completion-result".
9645         (New command options, command completion): New section.
9646         (Completion improvements): New section.
9647         Mention that you can abbreviate "unlimited".
9648
9649 2019-06-13  Pedro Alves  <palves@redhat.com>
9650
9651         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9652         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9653         * unittests/cli-utils-selftests.c (test_parse_flags)
9654         (test_parse_flags_qcs): Delete.
9655         (test_cli_utils): Don't call deleted functions.
9656
9657 2019-06-13  Pedro Alves  <palves@redhat.com>
9658
9659         * thread.c: Include "cli/cli-option.h".
9660         (tp_array_compar_ascending): Global.
9661         (tp_array_compar): Delete function.
9662         (tp_array_compar_ascending, tp_array_compar_descending): New
9663         functions.
9664         (ascending_option_def, qcs_flag_option_def)
9665         (thr_qcs_flags_option_defs)
9666         (make_thread_apply_all_options_def_group)
9667         (make_thread_apply_options_def_group): New.
9668         (thread_apply_all_command): Use gdb::option::process_options.
9669         (thread_apply_command_completer)
9670         (thread_apply_all_command_completer): New.
9671         (thread_apply_command): Use gdb::option::process_options.
9672         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9673         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9674         to generate help text of "thread apply".  Adjust "taas"'s help.
9675         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9676         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9677
9678 2019-06-13  Pedro Alves  <palves@redhat.com>
9679
9680         * thread.c (thread_apply_command): Check for invalid TID with
9681         isdigit instead of !isalpha.
9682
9683 2019-06-13  Pedro Alves  <palves@redhat.com>
9684
9685         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9686         (validate_flags_qcs): New.
9687         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9688         (validate_flags_qcs): Declare.
9689         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9690         (make_frame_apply_options_def_group): New.
9691         (frame_apply_command_count): Process options with
9692         gdb::option::process_options.
9693         (frame_apply_completer): New.
9694         (frame_apply_level_completer, frame_apply_all_completer)
9695         (frame_apply_completer): New.
9696         (_initialize_stack): Update help of "frame apply", "frame apply
9697         level", "frame apply all" and "faas" to mention supported options
9698         and install command completers.
9699         * stack.h (frame_apply_all_completer): Declare.
9700         * thread.c: Include "stack.h".
9701         (tfaas_command): Add "--".
9702         (_initialize_thread): Update help "tfaas" to mention supported
9703         options and install command completer.
9704
9705 2019-06-13  Pedro Alves  <palves@redhat.com>
9706
9707         * completer.c (complete_nested_command_line): New.
9708         (gdb_completion_word_break_characters_throw): Add assertion.
9709         * completer.h (complete_nested_command_line): Declare.
9710
9711 2019-06-13  Pedro Alves  <palves@redhat.com>
9712
9713         * stack.c (parse_backtrace_qualifiers): New.
9714         (backtrace_command): Use it.
9715         (backtrace_command_completer): Complete on qualifiers.
9716
9717 2019-06-13  Pedro Alves  <palves@redhat.com>
9718
9719         * frame.c: Include "cli/cli-option.h.
9720         (user_set_backtrace_options): New.
9721         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9722         Delete.
9723         (get_prev_frame): Adjust.
9724         (boolean_option_def, uinteger_option_def)
9725         (set_backtrace_option_defs): New.
9726         (_initialize_frame): Adjust and use
9727         gdb::option::add_setshow_cmds_for_options to install "set
9728         backtrace past-main" and "set backtrace past-entry".
9729         * frame.h: Include "cli/cli-option.h".
9730         (struct frame_print_options): Forward declare.
9731         (print_frame_arguments_all, print_frame_arguments_scalars)
9732         (print_frame_arguments_none): Declare.
9733         (print_entry_values): Delete declaration.
9734         (struct frame_print_options, user_frame_print_options): New.
9735         (struct set_backtrace_options): New.
9736         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9737         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9738         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9739         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9740         (list_args_or_locals): Add frame_print_options parameter.
9741         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9742         * python/py-framefilter.c (enumerate_args): Pass down
9743         USER_FRAME_PRINT_OPTIONS.
9744         * stack.c: Include "cli/cli-option.h".
9745         (print_frame_arguments_all, print_frame_arguments_scalars)
9746         (print_frame_arguments_none): Declare.
9747         (print_raw_frame_arguments, print_entry_values): Delete.
9748         (user_frame_print_options): New.
9749         (boolean_option_def, enum_option_def, frame_print_option_defs):
9750         New.
9751         (struct backtrace_cmd_options): New.
9752         (bt_flag_option_def): New.
9753         (backtrace_command_option_defs): New.
9754         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9755         (print_frame_arg, read_frame_arg, print_frame_args)
9756         (print_frame_info, print_frame): Add frame_print_options parameter
9757         and use it.
9758         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9759         (backtrace_command_1): Add frame_print_options and
9760         backtrace_cmd_options parameters and use them.
9761         (make_backtrace_options_def_group): New.
9762         (backtrace_command): Process command options with
9763         gdb::option::process_options.
9764         (backtrace_command_completer): New.
9765         (_initialize_stack): Extend "backtrace"'s help to mention
9766         supported options.  Install completer for "backtrace".
9767         Install some settings commands with add_setshow_cmds_for_options.
9768
9769 2019-06-13  Pedro Alves  <palves@redhat.com>
9770
9771         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9772         and that "set/show print raw frame-arguments" are now deprecated.
9773
9774         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9775         command.
9776         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9777         * stack.c (_initialize_stack): Install "set/show print
9778         raw-frame-arguments", and deprecate "set/show print raw
9779         frame-arguments".
9780         * valprint.c (_initialize_valprint): Deprecate "set/show print
9781         raw".
9782
9783 2019-06-13  Pedro Alves  <palves@redhat.com>
9784
9785         * compile/compile.c (struct compile_options): New.
9786         (compile_flag_option_def, compile_command_option_defs)
9787         (make_compile_options_def_group): New.
9788         (compile_file_command): Handle options with
9789         gdb::option::process_options.
9790         (compile_file_command_completer): New function.
9791         (compile_code_command): Handle options with
9792         gdb::option::process_options.
9793         (compile_code_command_completer): New function.
9794         (_initialize_compiler): Install completers for "compile code" and
9795         "compile file".  Mention available options in "compile code" and
9796         "compile code"'s help.
9797         * completer.c (advance_to_completion_word): New, factored out from
9798         ...
9799         (advance_to_expression_complete_word_point): ... this.
9800         (advance_to_filename_complete_word_point): New.
9801         * completer.h (advance_to_filename_complete_word_point): New
9802         declaration.
9803
9804 2019-06-13  Pedro Alves  <palves@redhat.com>
9805
9806         * compile/compile.c: Include "cli/cli-option.h".
9807         (compile_print_value): Scope data pointer is now a
9808         value_print_options pointer; adjust.
9809         (compile_print_command): Process options.  Scope data pointer is
9810         now a value_print_options pointer; adjust.
9811         (_initialize_compile): Update "compile print"'s help to include
9812         supported options.  Install a completer for "compile print".
9813         * cp-valprint.c (show_vtblprint, show_objectprint)
9814         (show_static_field_print): Delete.
9815         (_initialize_cp_valprint): Don't install "set print
9816         static-members", "set print vtbl", "set print object" here.
9817         * printcmd.c: Include "cli/cli-option.h" and
9818         "common/gdb_optional.h".
9819         (print_command_parse_format): Rework to fill in a
9820         value_print_options instead of a format_data.
9821         (print_value): Change parameter type from format_data pointer to
9822         value_print_options reference.  Adjust.
9823         (print_command_1): Process options.  Adjust to pass down a
9824         value_print_options.
9825         (print_command_completer): New.
9826         (_initialize_printcmd): Install print_command_completer as
9827         handle_brkchars completer for the "print" command.  Update
9828         "print"'s help to include supported options.
9829         * valprint.c: Include "cli/cli-option.h".
9830         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9831         here from cp-valprint.c.
9832         (boolean_option_def, uinteger_option_def)
9833         (value_print_option_defs, make_value_print_options_def_group):
9834         New.  Use gdb::option::add_setshow_cmds_for_options to install
9835         "set print elements", "set print null-stop", "set print repeats",
9836         "set print pretty", "set print union", "set print array", "set
9837         print address", "set print symbol", "set print array-indexes".
9838         * valprint.h: Include <string> and "cli/cli-option.h".
9839         (make_value_print_options_def_group): Declare.
9840         (print_value): Change parameter type from format_data pointer to
9841         value_print_options reference.
9842         (print_command_completer): Declare.
9843
9844 2019-06-13  Pedro Alves  <palves@redhat.com>
9845
9846         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9847         (COMMON_SFILES): Add maint-test-settings.c.
9848         * cli/cli-decode.c (boolean_enums): New global, factored out from
9849         ...
9850         (add_setshow_boolean_cmd): ... here.
9851         * cli/cli-decode.h (boolean_enums): Declare.
9852         * cli/cli-option.c: New file.
9853         * cli/cli-option.h: New file.
9854         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9855         factored out from ...
9856         (parse_cli_boolean_value(const char *)): ... this.
9857         (is_unlimited_literal): Change parameter type to pointer to
9858         pointer.  Adjust and advance ARG pointer.
9859         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9860         (parse_cli_var_enum): New, factored out from ...
9861         (do_set_command): ... this.  Adjust.
9862         * cli/cli-setshow.h (parse_cli_boolean_value)
9863         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9864         (parse_cli_var_enum): Declare.
9865         * cli/cli-utils.c: Include "cli/cli-option.h".
9866         (get_ulongest): New.
9867         * cli/cli-utils.h (get_ulongest): Declare.
9868         (check_for_argument): New overloads.
9869         * maint-test-options.c: New file.
9870
9871 2019-06-13  Pedro Alves  <palves@redhat.com>
9872
9873         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9874         parse a range if "-" is at the end of the string.
9875
9876 2019-06-13  Pedro Alves  <palves@redhat.com>
9877
9878         * cli/cli-setshow.c (parse_auto_binary_operation)
9879         (parse_cli_boolean_value): Don't allow "o".
9880
9881 2019-06-13  Pedro Alves  <palves@redhat.com>
9882
9883         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9884         * NEWS: Mention maint test-settings KIND.
9885         * maint-test-settings.c: New file.
9886
9887 2019-06-13  Pedro Alves  <palves@redhat.com>
9888
9889         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9890         completer.
9891         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9892         "set" completers.
9893
9894 2019-06-13  Pedro Alves  <palves@redhat.com>
9895
9896         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9897         after item.
9898
9899 2019-06-13  Pedro Alves  <palves@redhat.com>
9900
9901         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9902
9903 2019-06-13  Pedro Alves <palves@redhat.com>
9904
9905         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9906         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9907         call.
9908         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9909         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9910         calls.
9911         (check_for_argument): Skip spaces after argument.
9912
9913 2019-06-13  Pedro Alves  <palves@redhat.com>
9914
9915         * thread.c (thread_apply_command): Adjust TID parsing.
9916         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9917         detected before end of string.
9918         (tid_is_in_list): Error out if LIST is invalid.
9919
9920 2019-06-13  Pedro Alves  <palves@redhat.com>
9921
9922         * completer.c (complete_line_internal_1): Rewind completion word
9923         point.
9924         (completion_tracker::advance_custom_word_point_by): Change
9925         parameter type to int.
9926         * completer.h (completion_tracker::advance_custom_word_point_by):
9927         Likewise.
9928
9929 2019-06-13  Pedro Alves  <palves@redhat.com>
9930
9931         * completer.c (advance_to_completion_word): Handle delimiters.
9932
9933 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9934
9935         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9936
9937 2019-06-11  Tom Tromey  <tom@tromey.com>
9938
9939         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9940         (xmalloc_failed): Move to alloc.c.
9941         * alloc.c: New file.
9942         * Makefile.in (COMMON_SFILES): Add alloc.c.
9943
9944 2019-06-11  Tom Tromey  <tom@tromey.com>
9945
9946         * nat/linux-waitpid.c: Don't include server.h.
9947         (linux_debug): Remove.
9948         (my_waitpid): Update.
9949
9950 2019-06-11  Tom Tromey  <tromey@adacore.com>
9951
9952         * infcall.c (_initialize_infcall): Remove trailing newline from
9953         help.
9954         * user-regs.c (_initialize_user_regs): Remove trailing newline
9955         from help.
9956         * typeprint.c (_initialize_typeprint): Remove trailing newline
9957         from help.
9958         * reverse.c (_initialize_reverse): Remove trailing newlines from
9959         help.
9960         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9961         from help.
9962         * language.c (add_set_language_command): Remove trailing newline
9963         from help.
9964         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9965         help.
9966         * disasm.c (_initialize_disasm): Remove trailing newline from
9967         help.
9968         * top.c (init_main): Remove trailing newline from help.
9969         * interps.c (_initialize_interpreter): Remove trailing newline
9970         from help.
9971         * btrace.c (_initialize_btrace): Remove trailing newlines from
9972         help.
9973         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9974         from help.
9975         * python/python.c (_initialize_python): Remove trailing newline
9976         from help.
9977         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9978         help.
9979         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9980         from help.  Reformat some text.
9981         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9982         from help.
9983         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9984         newline from help.
9985
9986 2019-06-11  Tom Tromey  <tromey@adacore.com>
9987
9988         * darwin-nat.c (darwin_decode_exception_message)
9989         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9990
9991 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9992
9993         * valops.c (value_slice): Check for not allocated or not
9994         associated values.
9995
9996 2019-06-10  Tom de Vries  <tdevries@suse.de>
9997
9998         PR gdb/24618
9999         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10000         sure an empty slot (defined by a 32-bit zero pair) is recognized as
10001         invalid.
10002
10003 2019-06-10  Tom de Vries  <tdevries@suse.de>
10004
10005         PR gdb/24611
10006         * linespec.c (linespec_lexer_lex_string): Remove incorrect
10007         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
10008
10009 2019-06-10  Tom de Vries  <tdevries@suse.de>
10010
10011         PR symtab/24545
10012         * symtab.c (struct demangled_name_entry): Add language field.
10013         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
10014         static minimal symbol".  Set and use language field.
10015
10016 2019-06-10  Tom Tromey  <tromey@adacore.com>
10017
10018         * ada-lang.c (_initialize_ada_language): Update help text.
10019
10020 2019-06-10  Tom Tromey  <tromey@adacore.com>
10021
10022         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10023         with a newline.
10024         * guile/guile.c (handle_boot_error): Don't end warning with a
10025         newline.
10026         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10027         warning with a newline.
10028         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10029         newline.
10030         (s12z_frame_cache): Likewise.
10031         * dwarf-index-cache.c (index_cache::store): Don't end warning with
10032         a newline.
10033         * solib-svr4.c (disable_probes_interface): Don't end warning with
10034         a newline.
10035         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10036         newline.
10037         * python/python.c (do_finish_initialization): Don't end warning
10038         with a newline.
10039
10040 2019-06-10  Tom Tromey  <tom@tromey.com>
10041
10042         * python/py-breakpoint.c (gdbpy_breakpoint_created)
10043         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10044         gdbpy_enter.
10045
10046 2019-06-10  Tom Tromey  <tromey@adacore.com>
10047
10048         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10049         data.
10050         (elf_new_init): Don't call stabsread_new_init.
10051         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10052         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
10053         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10054
10055 2019-06-10  Tom de Vries  <tdevries@suse.de>
10056
10057         PR symtab/16264
10058         PR symtab/24517
10059         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10060
10061 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
10062
10063         * source.c (find_and_open_source): Also rewrite relative file
10064         names.
10065
10066 2019-04-26  Amos Bird  <amosbird@gmail.com>
10067
10068         * annotate.c (annotate_thread_exited): Add "thread-exited"
10069         annotation.
10070
10071 2019-06-06  Tom Tromey  <tromey@adacore.com>
10072
10073         * maint.h (class scoped_command_stats): Use
10074         DISABLE_COPY_AND_ASSIGN.
10075         <print_time>: New method.
10076         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10077         print_time.
10078         (scoped_command_stats::print_time): New method.
10079
10080 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10081
10082         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10083         instructions of lengths 6 or 8 bytes.
10084
10085 2019-06-04  Pedro Alves  <palves@redhat.com>
10086
10087         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10088
10089         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10090         * breakpoint.c (condition_completer): Likewise.
10091         * cli/cli-dump.c (scan_expression): Likewise.
10092         * common/filestuff.c (mkdir_recursive): Likewise.
10093         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10094         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10095         (gdb_abspath): Likewise.
10096         * compile/compile-cplus-types.c
10097         (compile_cplus_instance::decl_name): Likewise.
10098         * completer.c (complete_explicit_location):
10099         (signal_completer, reg_or_group_completer_1): Likewise.
10100         * cp-support.c (cp_remove_params_if_any): Likewise.
10101         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10102         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10103         * infcmd.c (strip_bg_char): Likewise.
10104         * linespec.c (copy_token_string): Likewise.
10105         * mi/mi-main.c (output_cores): Likewise.
10106         * psymtab.c (psymtab_search_name):
10107         * symfile.c (test_set_ext_lang_command): Likewise.
10108         * target.c (target_fileio_read_stralloc): Likewise.
10109         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10110         * value.c (complete_internalvar): Likewise.
10111
10112 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10113
10114         Add objfile property to gdb.Type.
10115         * NEWS: Mention Python API addition.
10116         * python/py-type.c (typy_get_objfile): New method.
10117
10118 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10119
10120         * NEWS: Mention the new set|show style [title|highlight].
10121         Mention changes to "show style", "help" and "apropos".
10122
10123 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10124
10125         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10126         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10127         instead of print_help_for_command.
10128         (print_doc_of_command): New function.
10129         (help_list): Add 'apropos -v word' suggestion.
10130         (print_help_for_command): Style the command name using title style.
10131         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10132         (_initialize_cli_cmds): Describe -v in apropos_command help.
10133
10134 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10135
10136         * cli/cli-style.h (cli_style_option): Add name in constructor,
10137         add m_name class member, add constructor with intensity,
10138         add name class function.
10139         (cli_style_option::add_setshow_commands): Remove name argument.
10140         (highlight_style, title_style): New styles.
10141         * cli/cli-style.c (do_show): New function that shows a style
10142         characteristic styling the style name with itself.
10143         (set_style_name): New function.
10144         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10145         Update all callers according to the changes in cli/cli-style.h.
10146         * utils.h (fputs_highlighted): New function.
10147         * utils.c (fputs_highlighted): Likewise.
10148
10149 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10150
10151         * NEWS: Mention new pipe command and new convenience variables.
10152
10153 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10154
10155         * cli/cli-cmds.c (pipe_command): New function.
10156         (_initialize_cli_cmds): Call add_com for pipe_command.
10157         Define | as an alias for pipe.
10158         (exit_status_set_internal_vars): New function.
10159         (shell_escape): Call exit_status_set_internal_vars.
10160         cli/cli-decode.c (find_command_name_length): Recognize | as
10161         a single character command.
10162
10163 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10164
10165         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10166         top.c (execute_command_to_ui_file): New function, mostly a copy
10167         of execute_command_to_string.
10168         (execute_command_to_string): Implement by calling
10169         execute_command_to_ui_file.
10170
10171 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10172
10173         * top.h (saved_command_line): Remove declaration.
10174         * top.c (previous_saved_command_line, previous_repeat_arguments):
10175         New variables.
10176         (saved_command_line): Make static, define together with other
10177         'repeat variables'.
10178         (dont_repeat): Clear repeat_arguments.
10179         (repeat_previous, get_saved_command_line, save_command_line):
10180         New functions.
10181         (gdb_init): Initialize saved_command_line
10182         and previous_saved_command_line.
10183         * main.c (captured_main_1): Remove saved_command_line initialization.
10184         * event-top.c (handle_line_of_input): Update to use
10185         the new 'repeat' related functions instead of direct access to
10186         saved_command_line.
10187         * command.h (repeat_previous, get_saved_command_line,
10188         save_command_line): New declarations.
10189         (dont_repeat): Add comment.
10190
10191 2019-05-30  Tom Tromey  <tromey@adacore.com>
10192
10193         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10194         Fix comment.
10195         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10196
10197 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10198
10199         PR cli/24587
10200         * completer.c (complete): Initialize variable word.
10201
10202 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10203
10204         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10205         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10206         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10207         'body' is NULL to the outter 'if', protecting the '!is_define'
10208         situation as well.
10209
10210 2019-05-29  Tom Tromey  <tromey@adacore.com>
10211
10212         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10213         (dwarf_unknown): New function.
10214         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10215         (dwarf_type_encoding_name): Use dwarf_unknown.
10216
10217 2019-05-29  Tom Tromey  <tromey@adacore.com>
10218
10219         PR c++/20020:
10220         * cp-valprint.c (cp_print_value_fields): Call
10221         cp_print_static_field inside "try".
10222
10223 2019-05-29  Tom Tromey  <tromey@adacore.com>
10224
10225         * inflow.c (struct terminal_info): Add default operator=.
10226         * configure: Rebuild.
10227         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10228         -Wdeprecated-copy-dtor, -Wredundant-move.
10229
10230 2019-05-29  Tom Tromey  <tromey@adacore.com>
10231
10232         * NEWS: Add entry.
10233         * infcmd.c (print_return_value_1): Handle finish_print
10234         option.
10235         (show_print_finish): New function.
10236         (_initialize_infcmd): Add "set/show print finish" commands.
10237         * valprint.c (user_print_options): Initialize new member.
10238         * valprint.h (struct value_print_options) <finish_print>: New
10239         member.
10240
10241 2019-05-28  Tom Tromey  <tromey@adacore.com>
10242
10243         * ada-lang.c (ada_remove_Xbn_suffix)
10244         (find_old_style_renaming_symbol)
10245         (parse_old_style_renaming): Remove.
10246         (ada_find_renaming_symbol): Don't call
10247         find_old_style_renaming_symbol.
10248         (ada_is_renaming_symbol): Rename from
10249         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10250         bool.  Now static.
10251         (ada_read_var_value): Update and simplify.
10252         * ada-exp.y (write_var_or_type): Remove old code.
10253
10254 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10255
10256         PR gdb/25010
10257         * event-top.c: Remove include comment.
10258         * inflow.c (class scoped_ignore_sigttou): Move from here...
10259         * inflow.h (class scoped_ignore_sigttou): ...to here.
10260         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10261         * top.c:  Remove include comment.
10262
10263 2019-05-27  Tom Tromey  <tom@tromey.com>
10264
10265         * NEWS: Fix typo.
10266
10267 2019-05-22  Tom Tromey  <tromey@adacore.com>
10268
10269         * target.c (target_follow_exec): Constify parameter.
10270         * target-delegates.c: Rebuild.
10271         * remote.c (remote_target::follow_exec): Constify parameter.
10272         * infrun.c (follow_exec): Constify parameter.
10273         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10274         (target_follow_exec): Likewise.
10275
10276 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10277
10278         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10279         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10280
10281 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10282
10283         * NEWS: Add debugredirect and testsuite sections.
10284
10285 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10286
10287         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10288         target descriptions using exclusively floating point register name
10289         aliases.
10290
10291 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10292
10293         PR gdb/18644:
10294         * f-lang.c (build_fortran_types): Handle the case where
10295         gdbarch_floatformat_for_type returns a nullptr.
10296
10297 2019-05-21  Tom de Vries  <tdevries@suse.de>
10298
10299         PR cli/24587
10300         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10301
10302 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10303
10304         PR gdb/18644:
10305         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10306         16-byte floats.
10307         * i386-tdep.c (i386_floatformat_for_type): Use
10308         floatformats_ia64_quad for the 16-byte floating point component
10309         within a fortran 32-byte complex number.
10310
10311 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10312
10313         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10314         delete default constructor.
10315         (find_partial_die): Update to return const struct.
10316         (partial_die_parent_scope): Move variable declaration into scope
10317         of its use and change its type to auto.
10318         (guess_partial_die_structure_name): Likewise.
10319         (partial_die_info::fixup): Likewise.
10320
10321 2019-05-17  Tom Tromey  <tromey@adacore.com>
10322
10323         * source.c (find_and_open_source): Remove cast.
10324
10325 2019-05-17  Tom Tromey  <tromey@adacore.com>
10326
10327         * annotate.c (annotate_source): Make "filename" const.
10328         * annotate.h (annotate_source): Use const.
10329
10330 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10331
10332         * disasm.c (set_disassembler_options): Send errors to stderr.
10333
10334 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10335
10336         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10337         (cli_interp_base::set_logging): Check debug_redirect.
10338         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10339         * cli/cli-logging.c (debug_redirect): Add static variable.
10340         (pop_output_files): Add default param.
10341         (handle_redirections): Print debug setting.
10342         (show_logging_command): Likewise.
10343         (_initialize_cli_logging): Add debugredirect command.
10344         * interps.c (current_interp_set_logging): Add debug_redirect
10345         parameter.
10346         * interps.h (set_logging): Add debug_redirect parameter.
10347         (current_interp_set_logging): Likewise.
10348         * mi/mi-common.h: Likewise.
10349         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10350
10351 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10352             Tom Tromey  <tromey@adacore.com>
10353
10354         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10355         directly.
10356         * cli/cli-interp.h (make_logging_output): Remove declaration.
10357         * cli/cli-logging.c (make_logging_output): Remove function.
10358         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10359         directly.
10360         * ui-file.c (tee_file::tee_file): Remove bools.
10361         (tee_file::~tee_file): Remove deletes.
10362         * ui-file.h (tee_file): Remove bools.
10363
10364 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10365
10366         * mi/mi-cmds.h (mi_cmd_complete): New function.
10367         * mi/mi-main.c (mi_cmd_complete): Likewise.
10368         * mi/mi-cmds.c: Define new MI command -complete.
10369         * NEWS: Mention new -complete command.
10370
10371 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10372
10373         * completer.h (complete): New function.
10374         * completer.c (complete): Likewise.
10375         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10376         function defined in completer.h.
10377
10378 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10379
10380         * MAINTAINERS (Write After Approval): Add myself.
10381
10382 2019-05-17  Tom de Vries  <tdevries@suse.de>
10383
10384         PR gdb/24094
10385         * dwarf2read.c (struct cu_partial_die_info): New struct.
10386         (find_partial_die): Return cu_partial_die_info.
10387         (partial_die_parent_scope, guess_partial_die_structure_name)
10388         (partial_die_info::fixup): Handle new return type of find_partial_die.
10389
10390 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10391
10392         PR breakpoints/24541
10393         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10394         "std::string", simplifying the algorithm.
10395
10396 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10397
10398         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10399         (stap_static_probe_ops::get_probes): Likewise.
10400
10401 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10402
10403         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10404         '-')" and "else if".
10405         (stap_parse_single_operand): Join checks for
10406         "gdbarch_stap_parse_special_token_p" and
10407         "gdbarch_stap_parse_special_token" in the same "if" statement.
10408         Invert check when verifying for operation on register
10409         displacement.
10410
10411 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10412
10413         * stap-probe.c (stap_get_opcode): Update comment.
10414         (stap_get_expected_argument_type): Likewise.
10415         (handle_stap_probe): Likewise.
10416
10417 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10418
10419         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10420         return type to 'bool'.  Adjust comment.  Use 'bool' when
10421         appropriate.
10422         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10423         * stap-probe.c (stap_parse_argument_1): Likewise.
10424         (stap_is_operator): Likewise.
10425         (stap_is_generic_prefix): Likewise.
10426         (stap_is_register_prefix): Likewise.
10427         (stap_is_register_indirection_prefix): Likewise.
10428         (stap_is_integer_prefix): Likewise.
10429         (stap_generic_check_suffix): Likewise.
10430         (stap_check_integer_suffix): Likewise.
10431         (stap_check_register_suffix): Likewise.
10432         (stap_check_register_indirection_suffix): Likewise.
10433         (stap_parse_register_operand): Likewise.
10434         (stap_parse_single_operand): Likewise.
10435         (stap_parse_argument_1): Likewise.
10436         (stap_probe::get_argument_count): Likewise.
10437         (stap_is_operator): Likewise.
10438
10439 2019-05-16  Tom Tromey  <tromey@adacore.com>
10440
10441         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10442         keyword to foreach.
10443
10444 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10445
10446         * linux-thread-db.c (try_thread_db_load_1): Change return type
10447         to bool.
10448         (try_thread_db_load): Likewise.
10449         (try_thread_db_load_from_pdir_1): Likewise.
10450         (try_thread_db_load_from_pdir): Likewise.
10451         (try_thread_db_load_from_sdir): Likewise.
10452         (try_thread_db_load_from_dir): Likewise.
10453         (thread_db_load_search): Likewise.
10454         (has_libpthread): Likewise.
10455         (thread_db_load): Likewise.
10456
10457 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10458
10459         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10460         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10461         NULL, and complain/return if that's the case.
10462
10463 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10464
10465         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10466         (advance, posn, abstract_read_memory): New functions.
10467         [struct mem_read_abstraction]: New struct.
10468         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10469
10470 2019-05-14  Tom Tromey  <tromey@adacore.com>
10471
10472         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10473         value is not lval_memory.
10474
10475 2019-05-14  Tom Tromey  <tromey@adacore.com>
10476
10477         * solib.c (info_sharedlibrary_command): Style the file name.
10478
10479 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10480
10481         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10482         (aarch64_vnv_type): Likewise.
10483         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10484         * common/tdesc.c: Likewise.
10485         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10486         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10487         * features/aarch64-fpu.xml: Add ieee half view.
10488         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10489         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10490         * gdbtypes.h (struct builtin_type): Likewise.
10491         (struct objfile_type): Likewise.
10492
10493 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10494
10495         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10496         typo.
10497         * location.h (string_to_event_location): Likewise.
10498
10499 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10500
10501         GDB 8.3 released.
10502
10503 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10504
10505         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10506         New variable declaration.
10507         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10508         New variable.
10509         (print_one_breakpoint): Use ui_out::test_flags and new global
10510         variable to compute use_fixed_output.
10511         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10512         Remove.
10513         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10514         (mi_multi_location_breakpoint_output_fixed): Remove.
10515         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10516         new variable.
10517         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10518         fix_multi_location_breakpoint_output flag if version >= 3.
10519         * ui-out.h (enum ui_out_flag)
10520         <fix_multi_location_breakpoint_output>: New enumerator.
10521
10522 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10523
10524         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10525
10526 2019-05-10  Tom Tromey  <tromey@adacore.com>
10527
10528         * ada-lang.c (catch_ada_completer): New function.
10529         (_initialize_ada_language): Use it.
10530
10531 2019-05-10  Tom Tromey  <tromey@adacore.com>
10532
10533         * thread.c (print_thread_info): Make "requested_threads" const.
10534         * gdbthread.h (print_thread_info): Make "requested_threads"
10535         const.
10536         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10537         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10538
10539 2019-05-08  Tom Tromey  <tom@tromey.com>
10540
10541         * gdbtypes.c (objfile_type_data): Change type.
10542         (objfile_type, _initialize_gdbtypes): Update.
10543
10544 2019-05-08  Tom Tromey  <tom@tromey.com>
10545
10546         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10547         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10548         (_initialize_dwarf2_frame): Update.
10549
10550 2019-05-08  Tom Tromey  <tom@tromey.com>
10551
10552         * objc-lang.c (objc_objfile_data): Change type.
10553         (find_methods): Update.
10554         (_initialize_objc_lang): Remove.
10555
10556 2019-05-08  Tom Tromey  <tom@tromey.com>
10557
10558         * stabsread.c (rs6000_builtin_type_data): Change type.
10559         (rs6000_builtin_type, _initialize_stabsread): Update.
10560
10561 2019-05-08  Tom Tromey  <tom@tromey.com>
10562
10563         * mips-tdep.c (mips_pdr_data): Remove.
10564         (_initialize_mips_tdep): Update.
10565
10566 2019-05-08  Tom Tromey  <tom@tromey.com>
10567
10568         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10569         (hppa_init_objfile_priv_data, read_unwind_info)
10570         (find_unwind_entry, _initialize_hppa_tdep): Update.
10571
10572 2019-05-08  Tom Tromey  <tom@tromey.com>
10573
10574         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10575         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10576         on obstack.
10577         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10578
10579 2019-05-08  Tom Tromey  <tom@tromey.com>
10580
10581         * mdebugread.c (basic_type_data): Change type.
10582         (basic_type, _initialize_mdebugread): Update.
10583
10584 2019-05-08  Tom Tromey  <tom@tromey.com>
10585
10586         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10587
10588 2019-05-08  Tom Tromey  <tom@tromey.com>
10589
10590         * nto-tdep.c (nto_inferior_data_reg): Change type.
10591         (nto_inferior_data): Update.
10592         (nto_inferior_data_cleanup, nto_new_inferior_data)
10593         (_initialize_nto_tdep): Remove.
10594         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10595
10596 2019-05-08  Tom Tromey  <tom@tromey.com>
10597
10598         * ada-lang.c (struct ada_inferior_data): Add initializers.
10599         (ada_inferior_data): Change type.
10600         (ada_inferior_data_cleanup): Remove.
10601         (get_ada_inferior_data, ada_inferior_exit)
10602         (struct ada_pspace_data): Add initializers, destructor.
10603         (ada_pspace_data_handle): Change type.
10604         (get_ada_pspace_data): Update.
10605         (ada_pspace_data_cleanup): Remove.
10606
10607 2019-05-08  Tom Tromey  <tom@tromey.com>
10608
10609         * coffread.c (struct coff_symfile_info): Add initializers.
10610         (coff_objfile_data_key): Move lower.  Change type.
10611         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10612         Update.
10613         (coff_free_info): Remove.
10614
10615 2019-05-08  Tom Tromey  <tom@tromey.com>
10616
10617         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10618         (fbsd_pspace_data_handle): Move lower.  Change type.
10619         (get_fbsd_pspace_data): Update.
10620         (fbsd_pspace_data_cleanup): Remove.
10621         (_initialize_fbsd_tdep): Update.
10622
10623 2019-05-08  Tom Tromey  <tom@tromey.com>
10624
10625         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10626         (get_ada_tasks_pspace_data): Update.
10627         (ada_tasks_pspace_data_cleanup): Remove.
10628         (_initialize_tasks): Update.
10629         (ada_tasks_inferior_data_handle): Change type.
10630         (get_ada_tasks_inferior_data): Update.
10631         (ada_tasks_inferior_data_cleanup): Remove.
10632         (struct ada_tasks_pspace_data): Add initializers.
10633
10634 2019-05-08  Tom Tromey  <tom@tromey.com>
10635
10636         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10637         * symfile-debug.c (debug_sym_get_probes): Change type.
10638         * stap-probe.c (handle_stap_probe):
10639         (stap_static_probe_ops::get_probes): Change type.
10640         * probe.h (class static_probe_ops) <get_probes>: Change type.
10641         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10642         (parse_probes_in_pspace): Update.
10643         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10644         Update.
10645         (any_static_probe_ops::get_probes): Change type.
10646         * elfread.c (elfread_data): New typedef.
10647         (probe_key): Change type.
10648         (elf_get_probes): Likewise.  Update.
10649         (probe_key_free): Remove.
10650         (_initialize_elfread): Update.
10651         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10652         Change type.
10653         (dtrace_process_dof_probe, dtrace_process_dof)
10654         (dtrace_static_probe_ops::get_probe): Change type.
10655
10656 2019-05-08  Tom Tromey  <tom@tromey.com>
10657
10658         * xcoffread.c (struct xcoff_symfile_info): Rename from
10659         coff_symfile_info.  Add initializers.
10660         (xcoff_objfile_data_key): Move lower.  Change type.
10661         (XCOFF_DATA): Rewrite.
10662         (xcoff_free_info): Remove.
10663         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10664         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10665         (xcoff_initial_scan): Update.
10666
10667 2019-05-08  Tom Tromey  <tom@tromey.com>
10668
10669         * solib-svr4.c (struct svr4_info): Add initializers and
10670         destructor.
10671         <probes_table>: Now an htab_up.
10672         (solib_svr4_pspace_data): Change type.
10673         (free_probes_table): Simplify.
10674         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10675         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10676         (probes_table_remove_objfile_probes, register_solib_event_probe)
10677         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10678         (_initialize_svr4_solib): Update.
10679
10680 2019-05-08  Tom Tromey  <tom@tromey.com>
10681
10682         * remote.c (remote_pspace_data): Change type.
10683         (remote_pspace_data_cleanup): Remove.
10684         (get_remote_exec_file, set_pspace_remote_exec_file)
10685         (_initialize_remote): Update.
10686
10687 2019-05-08  Tom Tromey  <tom@tromey.com>
10688
10689         * breakpoint.c (breakpoint_objfile_key): Change type.
10690         (get_breakpoint_objfile_data): Update.
10691         (free_breakpoint_objfile_data): Remove.
10692         (_initialize_breakpoint): Update.
10693
10694 2019-05-08  Tom Tromey  <tom@tromey.com>
10695
10696         * linux-tdep.c (struct linux_info): Add initializers.
10697         (linux_inferior_data): Move.  Change type.
10698         (invalidate_linux_cache_inf): Update.
10699         (linux_inferior_data_cleanup): Remove.
10700         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10701
10702 2019-05-08  Tom Tromey  <tom@tromey.com>
10703
10704         * auxv.c (auxv_inferior_data): Move.  Change type.
10705         (auxv_inferior_data_cleanup): Remove.
10706         (invalidate_auxv_cache_inf): Rewrite.
10707         (get_auxv_inferior_data, _initialize_auxv): Update.
10708
10709 2019-05-08  Tom Tromey  <tom@tromey.com>
10710
10711         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10712         (symfile_debug_objfile_data_key): Change type.
10713         (symfile_debug_installed, debug_qf_has_symbols)
10714         (debug_qf_find_last_source_symtab)
10715         (debug_qf_forget_cached_source_info)
10716         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10717         (debug_qf_print_stats, debug_qf_dump)
10718         (debug_qf_expand_symtabs_for_function)
10719         (debug_qf_expand_all_symtabs)
10720         (debug_qf_expand_symtabs_with_fullname)
10721         (debug_qf_map_matching_symbols)
10722         (debug_qf_expand_symtabs_matching)
10723         (debug_qf_find_pc_sect_compunit_symtab)
10724         (debug_qf_map_symbol_filenames)
10725         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10726         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10727         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10728         (debug_sym_read_linetable, debug_sym_relocate): Update.
10729         (symfile_debug_free_objfile): Remove.
10730         (install_symfile_debug_logging, _initialize_symfile_debug):
10731         Update.
10732
10733 2019-05-08  Tom Tromey  <tom@tromey.com>
10734
10735         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10736         allocate_on_obstack.
10737         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10738         (get_dwarf2_per_objfile): Update.
10739         (set_dwarf2_per_objfile): Remove.
10740         (dwarf2_has_info, dwarf2_get_section_info): Update.
10741         (dwarf2_free_objfile): Remove.
10742         (_initialize_dwarf2_read): Update.
10743
10744 2019-05-08  Tom Tromey  <tom@tromey.com>
10745
10746         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10747         initializers.
10748         <unsupported_script_warning_printed,
10749         script_not_found_warning_printed>: Now bool.
10750         (auto_load_pspace_data): Change type.
10751         (~auto_load_pspace_info): Rename from
10752         auto_load_pspace_data_cleanup.
10753         (get_auto_load_pspace_data, init_loaded_scripts_info)
10754         (clear_section_scripts, maybe_print_unsupported_script_warning)
10755         (maybe_print_script_not_found_warning, _initialize_auto_load):
10756         Update.
10757
10758 2019-05-08  Tom Tromey  <tom@tromey.com>
10759
10760         * objfiles.c (objfile_pspace_info): Add destructor and
10761         initializers.
10762         (objfiles_pspace_data): Change type.
10763         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10764         (get_objfile_pspace_data): Update.
10765         (objfiles_bfd_data): Change type.
10766         (get_objfile_bfd_data): Update.
10767         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10768
10769 2019-05-08  Tom Tromey  <tom@tromey.com>
10770
10771         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10772         Change type.
10773         (get_catch_syscall_inferior_data): Update.
10774         (catch_syscall_inferior_data_cleanup): Remove.
10775         (_initialize_break_catch_syscall): Update.
10776
10777 2019-05-08  Tom Tromey  <tom@tromey.com>
10778
10779         * inflow.c (struct terminal_info): Add destructor and
10780         initializers.
10781         (inflow_inferior_data): Change type.
10782         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10783         (get_inflow_inferior_data, inflow_inferior_exit)
10784         (swap_terminal_info, _initialize_inflow): Update.
10785
10786 2019-05-08  Tom Tromey  <tom@tromey.com>
10787
10788         * target-dcache.c (target_dcache_cleanup): Remove.
10789         (target_dcache_aspace_key): Change type.
10790         (target_dcache_init_p, target_dcache_invalidate)
10791         (target_dcache_get, target_dcache_get_or_init)
10792         (_initialize_target_dcache): Update.
10793         * dcache.h (struct dcache_deleter): New.
10794
10795 2019-05-08  Tom Tromey  <tom@tromey.com>
10796
10797         * symtab.c (struct symbol_cache): Add destructor and
10798         initializers.
10799         (symbol_cache_key): Move.  Change type.
10800         (make_symbol_cache, free_symbol_cache): Remove.
10801         (get_symbol_cache): Update.
10802         (symbol_cache_cleanup): Remove.
10803         (ALL_PSPACES, symbol_cache_flush)
10804         (maintenance_print_symbol_cache)
10805         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10806         Update.
10807
10808 2019-05-08  Tom Tromey  <tom@tromey.com>
10809
10810         * symtab.c (struct main_info): Add destructor and initializers.
10811         (main_progspace_key): Move.  Change type.
10812         (get_main_info): Update.
10813         (main_info_cleanup): Remove.
10814         (_initialize_symtab): Update.
10815
10816 2019-05-08  Tom Tromey  <tom@tromey.com>
10817
10818         * registry.h (DECLARE_REGISTRY): Define the _key class.
10819
10820 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10821
10822         * NEWS: Merge two 'New commands' sections.
10823
10824 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10825
10826         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10827         parameter and use Ada language definition instead.
10828         (ada_val_print_ptr): Remove unused language parameter.
10829         (ada_val_print_num): Remove language parameter and use Ada language
10830         definition instead.
10831         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10832         parameter.
10833         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10834         parameter and use Ada language definition instead.
10835         (ada_val_print_1): Update all ada_val_print_xxx calls.
10836         Remove language parameter.
10837         (ada_val_print): Update ada_val_print_1 call.
10838
10839 2019-05-08  Tom Tromey  <tromey@adacore.com>
10840
10841         * remote.c (remote_hw_watchpoint_limit)
10842         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10843         Now static.
10844
10845 2019-05-08  Tom Tromey  <tromey@adacore.com>
10846
10847         * maint.c (_initialize_maint_cmds): Move initialization code to
10848         remote.c.
10849         (watchdog, show_watchdog): Move to remote.c.
10850         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10851         "watchdog" static.
10852         (_initialize_remote): Move initialization code from maint.c.
10853         * defs.h (watchdog): Don't declare.
10854
10855 2019-05-08  Tom Tromey  <tromey@adacore.com>
10856
10857         * tui/tui-interp.c: Include main.h.
10858         * interps.c: Include main.h.
10859         * main.h (interpreter_p): Declare.
10860         * defs.h (interpreter_p): Don't declare.
10861
10862 2019-05-08  Tom Tromey  <tromey@adacore.com>
10863
10864         * dwarf2loc.c: Include dwarf2read.h.
10865         * defs.h (read_unsigned_leb128): Don't declare.
10866         * dwarf2read.h (read_unsigned_leb128): Declare.
10867
10868 2019-05-08  Tom Tromey  <tromey@adacore.com>
10869
10870         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10871         method.
10872
10873 2019-05-08  Tom Tromey  <tromey@adacore.com>
10874
10875         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10876         when no wrap column is set.
10877
10878 2019-05-08  Tom Tromey  <tromey@adacore.com>
10879
10880         * c-lang.c (c_get_string): Handle non-C-style arrays.
10881
10882 2019-05-08  Tom Tromey  <tromey@adacore.com>
10883
10884         * typeprint.c (print_offset_data::update): Print the bit offset,
10885         not the number of bits remaining.
10886
10887 2019-05-08  Tom Tromey  <tromey@adacore.com>
10888
10889         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10890         padding at end of comment.
10891
10892 2019-05-08  Tom Tromey  <tromey@adacore.com>
10893
10894         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10895         Compare main types.
10896
10897 2019-05-06  Tom Tromey  <tom@tromey.com>
10898
10899         * common/scoped_mmap.c: Include common-defs.h.
10900         * common/scoped_mmap.h: Don't include config.h.
10901
10902 2019-05-04  Tom Tromey  <tom@tromey.com>
10903
10904         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10905         (struct aarch64_call_info): Add initializers.
10906         <si>: Now a std::vector.
10907         (pass_on_stack, aarch64_push_dummy_call): Update.
10908
10909 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10910             Tom Tromey  <tom@tromey.com>
10911
10912         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10913         (ppc_threads): Now a std::vector.  Now static.
10914         (hwdebug_find_thread_points_by_tid)
10915         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10916         Update.
10917
10918 2019-05-04  Tom Tromey  <tom@tromey.com>
10919
10920         * arc-tdep.c (arc_tdesc_init): Return bool.
10921
10922 2019-05-04  Tom Tromey  <tom@tromey.com>
10923
10924         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10925         Use gdb_assert_not_reached.
10926
10927 2019-05-04  Tom Tromey  <tom@tromey.com>
10928
10929         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10930         "false".
10931
10932 2019-05-04  Tom Tromey  <tom@tromey.com>
10933
10934         * arc-tdep.c (arc_tdesc_init): Use bool.
10935
10936 2019-05-04  Tom Tromey  <tom@tromey.com>
10937
10938         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10939
10940 2019-05-04  Tom Tromey  <tom@tromey.com>
10941
10942         * cli/cli-cmds.c (valid_command_p): Return bool.
10943
10944 2019-05-04  Tom Tromey  <tom@tromey.com>
10945
10946         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10947         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10948
10949 2019-05-04  Raul Tambre  <raul@tambre.ee>
10950
10951         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10952         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10953         operator for comparison.
10954
10955 2019-05-04  Tom Tromey  <tom@tromey.com>
10956
10957         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10958         (lookup_partial_symbol, print_partial_symbols)
10959         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10960         (psymbol_compare): Update.
10961         (add_psymbol_to_bcache): Clear the entire psymbol.
10962         (maintenance_check_psymtabs): Update.
10963         * psympriv.h (struct partial_symbol): Don't derive from
10964         general_symbol_info.
10965         <obj_section, unrelocated_address, address,
10966         set_unrelocated_address>: Update.
10967         <ginfo>: New member.
10968         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10969         (debug_names::write_psymbols): Update.
10970
10971 2019-05-04  Tom de Vries  <tdevries@suse.de>
10972
10973         * contrib/cc-with-tweaks.sh: Support -n arg.
10974
10975 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10976
10977         * corelow.c (core_target::detach): Ensure frame cache and
10978         register caches are cleared.
10979         inferior.c (exit_inferior_1): Likewise.
10980
10981 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10982             Tom Tromey  <tom@tromey.com>
10983
10984         * dictionary.c (collate_pending_symbols_by_language): Remove
10985         "struct" from foreach.
10986         * symtab.c (lookup_global_symbol_from_objfile)
10987         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10988         foreach.
10989         * ser-tcp.c (net_open): Remove "struct" from foreach.
10990         * objfiles.c (objfile_relocate, objfile_rebase)
10991         (objfile_has_symbols): Remove "struct" from foreach.
10992         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10993         from foreach.
10994         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10995         foreach.
10996         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10997         "struct" from foreach.
10998         * ada-lang.c (create_excep_cond_exprs)
10999         (ada_exception_catchpoint_cond_string): Remove "struct" from
11000         foreach.
11001
11002 2019-05-03  Tom Tromey  <tromey@adacore.com>
11003
11004         * ada-exp.y (convert_char_literal): Check suffix of each
11005         enumerator.
11006
11007 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
11008
11009         PR ada/21406:
11010         * ada-exp.y (yywrap): Don't define.
11011         * ada-lex.l (%option): Add noyywrap
11012         (yywrap): Remove.
11013
11014 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
11015
11016         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11017         _WIN32_WINNT to the XP level, unless already defined to a higher
11018         level.
11019
11020         * unittests/parse-connection-spec-selftests.c:
11021         * ser-tcp.c:
11022         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
11023         override.
11024
11025         * symfile.c (find_separate_debug_file): Remove colon from the
11026         drive spec of DOS/Windows file names of the target, so that the
11027         file name produced from DEBUGDIR and the target's directory will
11028         be valid on DOS/Windows systems.
11029
11030 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
11031
11032         * rust-lang.c (val_print_struct): Handle printing structures
11033         containing strings.
11034
11035 2019-05-02  Tom Tromey  <tromey@adacore.com>
11036
11037         * valarith.c (_initialize_valarith): Remove.
11038
11039 2019-05-01  Tom Tromey  <tromey@adacore.com>
11040
11041         * ada-lang.c (ada_value_primitive_field): Treat more fields as
11042         bitfields.
11043
11044 2019-05-01  Tom Tromey  <tromey@adacore.com>
11045
11046         * ada-lang.c (ada_value_assign): Correctly compute starting offset
11047         for big-endian copies.
11048
11049 2019-04-30  Ali Tamur  <tamur@google.com>
11050         * gdb/dwarf2read.c (read_3_bytes): New declaration.
11051         (read_attribute_value): Added DW_FORM_strx1-4 cases.
11052         (read_3_bytes): New function.
11053
11054 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11055
11056         * windows-nat.c (main_thread_id): Delete.
11057         (handle_output_debug_string): Replace main_thread_id by
11058         current_event.dwThreadId.
11059         (fake_create_process): Likewise.
11060         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11061         Do not set main_thread_id.
11062         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11063         current_event.dwThreadId.
11064         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11065
11066 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
11067
11068         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11069         Use current_event.dwThreadId instead of main_thread_id.
11070
11071 2019-04-30  Tom Tromey  <tromey@adacore.com>
11072
11073         * ada-lang.c (ada_lookup_simple_minsyms): New function.
11074         (create_excep_cond_exprs): Iterate over program spaces.
11075         (ada_exception_catchpoint_cond_string): Examine all minimal
11076         symbols for exception types.
11077
11078 2019-04-30  Tom Tromey  <tromey@adacore.com>
11079
11080         PR c++/24470:
11081         * dwarf2read.c (process_structure_scope): Handle case where type
11082         has template parameters but no symbol was created.
11083
11084 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11085             Chris January  <chris.january@arm.com>
11086
11087         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11088         qualifier.
11089         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11090
11091 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11092
11093         * f-typeprint.c (f_print_type): Update rules for printing
11094         whitespace.
11095         (f_type_print_varspec_suffix): Likewise.
11096
11097 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11098             Chris January  <chris.january@arm.com>
11099
11100         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11101         function arguments.
11102
11103 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11104
11105         * f-lang.c (build_fortran_types): Change name of void type to
11106         lower case.
11107         * f-typeprint.c (f_type_print_base): Print the name of the void
11108         type, rather than a fixed string.
11109         * f-valprint.c (f_decorations): Use lower case void string.
11110
11111 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11112             Chris January  <chris.january@arm.com>
11113
11114         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11115         types for Fortran.
11116
11117 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11118             Chris January  <chris.january@arm.com>
11119             David Lecomber  <david.lecomber@arm.com>
11120
11121         * f-exp.y (BINOP_INTRINSIC): New token.
11122         (exp): New parser rule handling BINOP_INTRINSIC.
11123         (f77_keywords): Add new builtin procedures.
11124         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11125         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11126         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11127         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11128         (print_unop_subexp_f): New function.
11129         (print_binop_subexp_f): New function.
11130         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11131         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11132         (dump_subexp_body_f): Likewise.
11133         (operator_check_f): Likewise.
11134         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11135         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11136
11137 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11138
11139         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11140         UNOP_KIND.
11141         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11142         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11143         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11144         (operator_length_f): New fuction.
11145         (print_subexp_f): New function.
11146         (op_name_f): New function.
11147         (dump_subexp_body_f): New function.
11148         (operator_check_f): New function.
11149         (exp_descriptor_f): Replace standard expression handling functions
11150         with new functions.
11151         * gdb/fortran-operator.def: New file.
11152         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11153         * gdb/std-operator.def: Remove UNOP_KIND.
11154
11155 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11156
11157         * std-operator.def: Remove unbalanced, stray double quote
11158         character.
11159
11160 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11161             Chris January  <chris.january@arm.com>
11162             Daniel Everett  <daniel.everett@arm.com>
11163             Nick Forrington  <nick.forrington@arm.com>
11164             Richard Bunt  <richard.bunt@arm.com>
11165
11166         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11167         of depth when printing anonymous structs or unions.
11168         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11169         Don't print either the top-level value, or the children if the
11170         max-depth is exceeded.
11171         (ppscm_print_children): When printing the key of a map, allow one
11172         extra level of depth.
11173         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11174         print either the top-level value, or the children if the max-depth
11175         is exceeded.
11176         (print_children): When printing the key of a map, allow one extra
11177         level of depth.
11178         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11179         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11180         (user_print_options): Initialise max_depth field.
11181         (val_print_scalar_or_string_type_p): New function.
11182         (val_print): Check to see if the max depth has been reached.
11183         (val_print_check_max_depth): Define new function.
11184         (show_print_max_depth): New function.
11185         (_initialize_valprint): Add 'print max-depth' option.
11186         * valprint.h (struct value_print_options) <max_depth>: New field.
11187         (val_print_check_max_depth): Declare new function.
11188         * NEWS: Document new feature.
11189
11190 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11191
11192         * ada-lang.c (ada_language_defn): Initialise new field.
11193         * c-lang.c (c_is_string_type_p): New function.
11194         (c_language_defn): Initialise new field.
11195         (cplus_language_defn): Initialise new field.
11196         (asm_language_defn): Initialise new field.
11197         (minimal_language_defn): Initialise new field.
11198         * c-lang.h (c_is_string_type_p): Declare new function.
11199         * d-lang.c (d_language_defn): Initialise new field.
11200         * f-lang.c (f_is_string_type_p): New function.
11201         (f_language_defn): Initialise new field.
11202         * go-lang.c (go_is_string_type_p): New function.
11203         (go_language_defn): Initialise new field.
11204         * language.c (default_is_string_type_p): New function.
11205         (unknown_language_defn): Initialise new field.
11206         (auto_language_defn): Initialise new field.
11207         * language.h (struct language_defn) <la_is_string_type_p>: New
11208         member variable.
11209         (default_is_string_type_p): Declare new function.
11210         * m2-lang.c (m2_language_defn): Initialise new field.
11211         * objc-lang.c (objc_language_defn): Initialise new field.
11212         * opencl-lang.c (opencl_language_defn): Initialise new field.
11213         * p-lang.c (pascal_is_string_type_p): New function.
11214         (pascal_language_defn): Initialise new field.
11215         * rust-lang.c (rust_is_string_type_p): New function.
11216         (rust_language_defn): Initialise new field.
11217
11218 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11219
11220         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11221         New field.
11222         * ada-lang.c (ada_language_defn): Initialise new field.
11223         * c-lang.c (c_language_defn): Likewise.
11224         (cplus_language_defn): Likewise.
11225         (asm_language_defn): Likewise.
11226         (minimal_language_defn): Likewise.
11227         * d-lang.c (d_language_defn): Likewise.
11228         * f-lang.c (f_language_defn): Likewise.
11229         * go-lang.c (go_language_defn): Likewise.
11230         * language.c (unknown_language_defn): Likewise.
11231         (auto_language_defn): Likewise.
11232         * m2-lang.c (m2_language_defn): Likewise.
11233         * objc-lang.c (objc_language_defn): Likewise.
11234         * opencl-lang.c (opencl_language_defn): Likewise.
11235         * p-lang.c (pascal_language_defn): Likewise.
11236         * rust-lang.c (rust_language_defn): Likewise.
11237
11238 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11239
11240         * ada-lang.c (ada_is_character_type): Change return type to bool.
11241         (ada_is_string_type): Likewise.
11242         * ada-lang.h (ada_is_character_type): Update declaration
11243         (ada_is_string_type): Likewise.
11244
11245 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11246
11247         Support style in 'frame|thread apply'
11248
11249         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11250         * record.c (record_start, record_stop): Update callers of
11251         execute_command_to_string with false.
11252         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11253         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11254         methods.
11255         (class string_file): New constructor with term_out parameter.
11256         Override methods term_out and can_emit_style_escape.  New member
11257         term_out.
11258         (class stdio_file): Override can_emit_style_escape.
11259         (class tee_file): Override term_out and can_emit_style_escape.
11260         * utils.h (can_emit_style_escape): Remove.
11261         * utils.c (can_emit_style_escape): Likewise.
11262         Update all callers of can_emit_style_escape (SOMESTREAM) to
11263         SOMESTREAM->can_emit_style_escape.
11264         * source-cache.c (source_cache::get_source_lines): Likewise.
11265         * stack.c (frame_apply_command_count): Call execute_command_to_string
11266         passing the term_out characteristic of the current gdb_stdout.
11267         * thread.c (thr_try_catch_cmd): Likewise.
11268         * top.c (execute_command_to_string): pass term_out parameter
11269         to construct the string_file for the command output.
11270         * ui-file.c (term_cli_styling): New function (most code moved
11271         from utils.c can_emit_style_escape).
11272         (string_file::string_file, string_file::can_emit_style_escape,
11273         stdio_file::can_emit_style_escape, tee_file::term_out,
11274         tee_file::can_emit_style_escape): New functions.
11275
11276 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11277
11278         * NEWS: Mention the new set|show may-call-functions.
11279         * infcall.c (may_call_functions_p): New variable.
11280         (show_may_call_functions_p): New function.
11281         (call_function_by_hand_dummy): Throws an error if not
11282         may-call-functions.
11283         (_initialize_infcall): Call add_setshow_boolean_cmd for
11284         may-call-functions.
11285
11286 2019-04-25  Keith Seitz  <keiths@redhat.com>
11287
11288         PR c++/24367
11289         * cp-support.c (inspect_type): Don't attempt substitutions
11290         of symbol with the same name.
11291
11292 2019-04-25  Tom Tromey  <tromey@adacore.com>
11293
11294         PR gdb/24475:
11295         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11296         static.
11297
11298 2019-04-25  Tom Tromey  <tromey@adacore.com>
11299
11300         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11301         rvalue reference.
11302         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11303         (gdb_xml_parser::parse): Use std::move.
11304         * python/python-internal.h (gdbpy_convert_exception): Take a const
11305         reference.
11306         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11307         std::move.
11308         * python/py-utils.c (gdbpy_convert_exception): Take a const
11309         reference.
11310         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11311         Use std::move.
11312         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11313         Use std::move.
11314         * mi/mi-main.c (mi_print_exception): Take a const reference.
11315         * main.c (handle_command_errors): Take a const reference.
11316         * linespec.c (parse_linespec): Use std::move.
11317         * infcall.c (run_inferior_call): Use std::move.
11318         (call_function_by_hand_dummy): Use std::move.
11319         * exec.c (try_open_exec_file): Use std::move.
11320         * exceptions.h (exception_print, exception_fprintf)
11321         (exception_print_same): Update.
11322         * exceptions.c (print_exception, exception_print)
11323         (exception_fprintf, exception_print_same): Change parameters to
11324         const reference.
11325         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11326         * common/new-op.c: Use std::move.
11327         * common/common-exceptions.h (struct gdb_exception): Add move
11328         constructor.
11329         (struct gdb_exception_error, struct gdb_exception_quit, struct
11330         gdb_quit_bad_alloc): Change constructor to move constructor.
11331         (throw_exception): Change parameter to rvalue reference.
11332         * common/common-exceptions.c (throw_exception): Take rvalue
11333         reference.
11334         * cli/cli-interp.c (safe_execute_command): Use std::move.
11335         * breakpoint.c (insert_bp_location, location_to_sals): Use
11336         std::move.
11337
11338 2019-04-25  Tom Tromey  <tromey@adacore.com>
11339
11340         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11341         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11342         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11343         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11344         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11345         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11346         guile/scm-value.c: Use unpack.
11347         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11348         gdbscm_gdb_exception.
11349         (gdbscm_throw_gdb_exception): Likewise.
11350         (struct gdbscm_gdb_exception): New.
11351         (unpack): New function.
11352         (gdbscm_wrap): Use unpack.
11353
11354 2019-04-25  Tom Tromey  <tromey@adacore.com>
11355
11356         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11357         (gdb_rl_callback_handler): Use std::move.
11358         * common/common-exceptions.h (struct gdb_exception): Add move
11359         assignment operator.
11360         (throw_exception_sjlj): Change "exception" to const reference.
11361         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11362         (throw_exception_sjlj): Change "exception" to const reference.
11363
11364 2019-04-25  Tom Tromey  <tromey@adacore.com>
11365
11366         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11367         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11368         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11369         Update.
11370         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11371         Update.
11372         * mi/mi-interp.c (mi_interp::exec): Update.
11373         * linespec.c (parse_linespec): Update.
11374         * infcall.c (run_inferior_call): Update.
11375         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11376         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11377         (gdbscm_lookup_global_symbol): Update.
11378         * guile/scm-param.c (gdbscm_parameter_value): Update.
11379         * guile/scm-frame.c (gdbscm_frame_read_register)
11380         (gdbscm_frame_read_var): Update.
11381         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11382         * exec.c (try_open_exec_file): Update.
11383         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11384         (gdb_rl_callback_handler): Update.
11385         * common/common-exceptions.h (exception_none): Don't declare.
11386         * common/common-exceptions.c (exception_none): Don't define.
11387         (struct catcher) <exception>: Update.
11388         * cli/cli-interp.c (safe_execute_command): Update.
11389         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11390
11391 2019-04-25  Ali Tamur  <tamur@google.com>
11392
11393         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11394         (read_attribute_value): Likewise.
11395         (dwarf2_read_addr_index): Update comment.
11396         (read_str_index): Add DW_FORM_strx.
11397         (dwarf2_string_attr): Likewise.
11398         (dwarf2_const_value_attr): Likewise.
11399         (dump_die_shallow): Likewise.
11400         (dwarf2_fetch_constant_bytes): Likewise.
11401         (skip_form_bytes): Likewise.
11402         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11403
11404 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11405
11406         PR corefiles/11608
11407         PR corefiles/18187
11408         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11409         OFFSET.  Verify if current mapping contains an ELF header.
11410         (linux_find_memory_regions_full): Adjust call to
11411         dump_mapping_p.
11412
11413 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11414             Kang Li <kanglictf@gmail.com>
11415
11416         PR gdb/21600
11417
11418         * dwarf2-frame.c (read_initial_length): Be consistent about using
11419         unsigned representation of length.
11420         (decode_frame_entry_1): Likewise.  Check for wraparound of
11421         end pointer as well as buffer overflow.
11422
11423 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11424
11425         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11426         "vq".
11427
11428 2019-04-24  Tom Tromey  <tromey@adacore.com>
11429
11430         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11431
11432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11433
11434         * s12z-tdep.c (s12z_unwind_pc): Delete.
11435         (s12z_unwind_sp): Delete.
11436         (s12z_gdbarch_init): Don't register deleted functions with
11437         gdbarch.
11438
11439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11440
11441         * rl78-tdep.c (rl78_unwind_sp): Delete.
11442         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11443
11444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11445
11446         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11447         (xstormy16_unwind_pc): Delete.
11448         (xstormy16_dummy_id): Delete.
11449         (xstormy16_gdbarch_init): Don't register deleted functions with
11450         gdbarch.
11451
11452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11453
11454         * vax-tdep.c (vax_unwind_pc): Delete.
11455         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11456
11457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11458
11459         * v850-tdep.c (v850_unwind_sp): Delete.
11460         (v850_unwind_pc): Delete.
11461         (v850_dummy_id): Delete.
11462         (v850_gdbarch_init): Don't register deleted functions with
11463         gdbarch.
11464
11465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11466
11467         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11468         (tilegx_unwind_pc): Delete.
11469         (tilegx_unwind_dummy_id): Delete.
11470         (tilegx_gdbarch_init): Don't register deleted functions with
11471         gdbarch.
11472
11473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11474
11475         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11476         (tic6x_dummy_id): Delete.
11477         (tic6x_gdbarch_init): Don't register deleted functions with
11478         gdbarch.
11479
11480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11481
11482         * sparc-tdep.c (sparc_unwind_pc): Delete.
11483         (sparc32_gdbarch_init): Don't register deleted function with
11484         gdbarch.
11485
11486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11487
11488         * sh-tdep.c (sh_unwind_sp): Delete.
11489         (sh_unwind_pc): Delete.
11490         (sh_dummy_id): Delete.
11491         (sh_gdbarch_init): Don't register deleted functions with
11492         gdbarch.
11493
11494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11495
11496         * score-tdep.c (score_unwind_sp): Delete.
11497         (score_unwind_pc): Delete.
11498         (score_dummy_id): Delete.
11499         (score_gdbarch_init): Don't register deleted functions with
11500         gdbarch.
11501
11502 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11503
11504         * rx-tdep.c (rx_unwind_pc): Delete.
11505         (rx_unwind_sp): Delete.
11506         (rx_dummy_id): Delete.
11507         (rx_gdbarch_init): Don't register deleted functions with
11508         gdbarch.  Update comment.
11509
11510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11511
11512         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11513         (rs6000_dummy_id): Delete.
11514         (rs6000_gdbarch_init): Don't register deleted functions with
11515         gdbarch.
11516
11517 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11518
11519         * or1k-tdep.c (or1k_dummy_id): Delete.
11520         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11521
11522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11523
11524         * nios2-tdep.c (nios2_dummy_id): Delete.
11525         (nios2_unwind_sp): Delete.
11526         (nios2_gdbarch_init): Don't register deleted functions with
11527         gdbarch.
11528
11529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11530
11531         * nds32-tdep.c (nds32_dummy_id): Delete.
11532         (nds32_unwind_pc): Delete.
11533         (nds32_unwind_sp): Delete.
11534         (nds32_gdbarch_init): Don't register deleted functions with
11535         gdbarch.
11536
11537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11538
11539         * msp430-tdep.c (msp430_unwind_pc): Delete.
11540         (msp430_unwind_sp): Delete.
11541         (msp430_dummy_id): Delete.
11542         (msp430_gdbarch_init): Don't register deleted functions with
11543         gdbarch.
11544
11545 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11546
11547         * moxie-tdep.c (moxie_unwind_sp): Delete.
11548         (moxie_unwind_pc): Delete.
11549         (moxie_dummy_id): Delete.
11550         (moxie_gdbarch_init): Don't register deleted functions with
11551         gdbarch.
11552
11553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11554
11555         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11556         (mn10300_unwind_pc): Delete.
11557         (mn10300_unwind_sp): Delete.
11558         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11559         mn10300_unwind_sp.
11560         (mn10300_frame_unwind_init): Don't register deleted functions with
11561         gdbarch.
11562
11563 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11564
11565         * mep-tdep.c (mep_unwind_pc): Delete.
11566         (mep_unwind_sp): Delete.
11567         (mep_dummy_id): Delete.
11568         (mep_gdbarch_init): Don't register deleted functions with
11569         gdbarch.
11570
11571 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11572
11573         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11574         (m68hc11_unwind_sp): Delete.
11575         (m68hc11_gdbarch_init): Don't register deleted functions with
11576         gdbarch.
11577
11578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11579
11580         * m32r-tdep.c (m32r_unwind_sp): Delete.
11581         (m32r_unwind_pc): Delete.
11582         (m32r_dummy_id): Delete.
11583         (m32r_gdbarch_init): Don't register deleted functions with
11584         gdbarch.
11585
11586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11587
11588         * m32c-tdep.c (m32c_unwind_pc): Delete.
11589         (m32c_unwind_sp): Delete.
11590         (m32c_dummy_id): Delete.
11591         (m32c_gdbarch_init): Don't register deleted functions with
11592         gdbarch.
11593
11594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11595
11596         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11597         (lm32_unwind_pc): Delete.
11598         (lm32_dummy_id): Delete.
11599         (lm32_gdbarch_init): Don't register deleted functions with
11600         gdbarch.
11601
11602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11603
11604         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11605         (iq2000_unwind_pc): Delete.
11606         (iq2000_dummy_id): Delete.
11607         (iq2000_gdbarch_init): Don't register deleted functions with
11608         gdbarch.
11609
11610 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11611
11612         * nds32-tdep.c (nds32_type_align): Delete.
11613         (nds32_push_dummy_call): Use type_align instead.
11614
11615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11616
11617         * arm-tdep.c (arm_type_align): Only handle vector override case.
11618         (arm_push_dummy_call): Use type_align.
11619         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11620
11621 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11622
11623         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11624         case.
11625         (pass_on_stack): Use type_align.
11626         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11627         function.
11628
11629 2019-04-23  Tom Tromey  <tromey@adacore.com>
11630
11631         * dwarf2read.c (line_header::file_name_at): Remove unused
11632         overload.
11633
11634 2019-04-23  Tom de Vries  <tdevries@suse.de>
11635
11636         PR gdb/24438
11637         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11638         invocation.
11639
11640
11641 2019-03-27  Ali Tamur  <tamur@google.com>
11642
11643         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11644         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11645         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11646         (dwarf_expr_context::get_addr_index): Likewise
11647         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11648         (symbol_needs_eval_context::get_addr_index): Likewise
11649         (disassemble_dwarf_expression): Add DW_OP_addrx
11650         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11651         (read_cutu_die_from_dwo): Update comment
11652         (skip_one_die): Add DW_FORM_addrx
11653         (read_attribute_value): Likewise
11654         (var_decode_location): Add DW_OP_addrx
11655         (dwarf2_const_value_attr): Add DW_FORM_addrx
11656         (dump_die_shallow): Likewise
11657         (dwarf2_fetch_constant_bytes): Likewise
11658         (decode_locdesc): Add DW_OP_addrx
11659         (skip_form_bytes): Add DW_FORM_addrx
11660
11661 2019-04-22  Ali Tamur  <tamur@google.com>
11662
11663         * MAINTAINERS (Write After Approval): Add self.
11664
11665 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11666
11667         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11668         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11669         (open_symbol_file_object): Likewise.
11670         (svr4_default_sos): Add info parameter.
11671         (svr4_read_so_list): Likewise.
11672         (svr4_current_sos_direct): Adjust functions calls to pass down
11673         info.
11674         (svr4_current_sos_1): Add info parameter.
11675         (svr4_current_sos): Call get_svr4_info, pass info down to
11676         svr4_current_sos_1.
11677         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11678         get_svr4_info.
11679         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11680         get_svr4_info.
11681         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11682         to get_svr4_info.
11683         (probes_table_remove_objfile_probes): Likewise.
11684         (register_solib_event_probe): Add info parameter.
11685         (solist_update_incremental): Pass info parameter down to
11686         svr4_read_so_list.
11687         (disable_probes_interface): Add info parameter.
11688         (svr4_handle_solib_event): Pass current_program_space to
11689         get_svr4_info.  Adjust disable_probes_interface cleanup.
11690         (svr4_create_probe_breakpoints): Add info parameter, pass it
11691         down to register_solib_event_probe.
11692         (svr4_create_solib_event_breakpoints): Add info parameter,
11693         pass it down to svr4_create_probe_breakpoints.
11694         (enable_break): Pass info down to
11695         svr4_create_solib_event_breakpoints.
11696         (svr4_solib_create_inferior_hook): Pass current_program_space to
11697         get_svr4_info.
11698         (svr4_clear_solib): Likewise.
11699
11700 2019-04-22  Pedro Alves  <palves@redhat.com>
11701
11702         * solib-svr4.c (svr4_free_objfile_observer): New.
11703         (probe_and_action::objfile): New field.
11704         (probes_table_htab_remove_objfile_probes)
11705         (probes_table_remove_objfile_probes): New functions.
11706         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11707         in the new probe_and_action.  Don't store the probe in 'lookup'.
11708         (svr4_create_probe_breakpoints): Pass objfile to
11709         register_solib_event_probe.
11710         (_initialize_svr4_solib): Register a free_objfile observer.
11711
11712 2019-04-19  Tom Tromey  <tom@tromey.com>
11713
11714         * common/queue.h: Remove.
11715
11716 2019-04-19  Tom Tromey  <tom@tromey.com>
11717
11718         * event-loop.c: Don't include "common/queue.h".
11719
11720 2019-04-19  Tom Tromey  <tom@tromey.com>
11721
11722         * remote.c (remote_target): Use delete.
11723         * remote-notif.h: Include <list>, not "common/queue.h".
11724         (notif_client_p): Remove typedef.
11725         (remote_notif_state): Add constructor, destructor, initializer.
11726         <notif_queue>: Now a std::list.
11727         (remote_notif_state_xfree): Don't declare.
11728         * remote-notif.c (remote_notif_process, handle_notification)
11729         (remote_notif_state_allocate): Update.
11730         (~remote_notif_state): Rename from remote_notif_state_xfree.
11731
11732 2019-04-19  Tom Tromey  <tom@tromey.com>
11733
11734         * symfile.c (reread_symbols): Update.
11735         * objfiles.c (objfile_register_static_link)
11736         (objfile_lookup_static_link): Update
11737         (~objfile) Don't delete static_links.
11738         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11739
11740 2019-04-19  Tom Tromey  <tom@tromey.com>
11741
11742         * type-stack.h (struct type_stack) <insert>: Constify string.
11743         * type-stack.c (type_stack::insert): Constify string.
11744         * gdbtypes.h (lookup_template_type): Update.
11745         (address_space_name_to_int): Update.
11746         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11747         const.
11748         (lookup_template_type): Make name const.
11749         * c-exp.y: Update rules.
11750         (lex_one_token, classify_name, classify_inner_name)
11751         (c_print_token): Update.
11752         * p-exp.y: Update rules.
11753         (yylex): Update.
11754         * f-exp.y: Update rules.
11755         (yylex): Update.
11756         * d-exp.y: Update rules.
11757         (lex_one_token, classify_name, classify_inner_name): Update.
11758         * parse.c (write_dollar_variable, copy_name): Return std::string.
11759         * parser-defs.h (copy_name): Change return type.
11760         * m2-exp.y: Update rules.
11761         (yylex): Update.
11762         * go-exp.y (lex_one_token): Update.
11763         Update rules.
11764         (classify_unsafe_function, classify_packaged_name)
11765         (classify_name, yylex): Update.
11766
11767 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11768
11769         * configure.ac: add --enable-source-highlight switch.
11770         * configure: Regenerate.
11771         * top.c (print_gdb_version): plumb --enable-source-highlight
11772         status to "show configuration".
11773
11774 2019-04-19  Tom Tromey  <tromey@adacore.com>
11775
11776         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11777         Check ADA_TYPE_P.
11778         (empty_record, ada_template_to_fixed_record_type_1)
11779         (template_to_static_fixed_type)
11780         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11781         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11782         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11783         macros.
11784
11785 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11786
11787         PR symtab/24423:
11788         * source.c (print_source_lines_base): Advance "iter" when a
11789         control character is seen.
11790
11791 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11792
11793         * inferior.h (struct infcall_suspend_state_deleter):
11794         Catch exception in destructor to avoid crash.
11795
11796 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11797
11798         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11799         close to the add_com "shell".
11800
11801 2019-04-18  Tom Tromey  <tromey@adacore.com>
11802
11803         * process-stratum-target.h (class process_stratum_target)
11804         <stratum>: Add "final".
11805
11806 2019-04-17  Tom Tromey  <tromey@adacore.com>
11807
11808         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11809         against nullptr before use.
11810
11811 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11812
11813         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11814
11815 2019-04-17  Jim Wilson  <jimw@sifive.com>
11816             Andrew Burgess  <andrew.burgess@embecosm.com>
11817
11818         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11819         code read might fail, assume 4-byte breakpoint in that case.
11820
11821 2019-04-15  Leszek Swirski  <leszeks@google.com>
11822
11823         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11824         rather than a hand-rolled POD check when checking for forced MEMORY
11825         classification.
11826
11827 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11828
11829         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11830         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11831         function.
11832         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11833         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11834         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11835         declaration.
11836
11837 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11838
11839         * aarch64-linux-nat.c
11840         (aarch64_linux_nat_target::thread_architecture): Add override.
11841         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11842         each VQ.
11843
11844 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11845
11846         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11847
11848 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11849
11850         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11851         target types of size 96-bits, add some additional comments, and
11852         check that the builtin type we found was the correct size.
11853
11854 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11855
11856         * utils.c (prompt_for_continue): Don't restore the styling at the
11857         end, as applied_style has the wrong value.  This fixes styling in
11858         long lists of file names that are interrupted by the "Continue?"
11859         prompt.
11860
11861 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11862
11863         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11864         * c-lang.c (c_language_defn): Likewise.
11865         (cplus_language_defn): Likewise.
11866         (asm_language_defn): Likewise.
11867         (minimal_language_defn): Likewise.
11868         * d-lang.c (d_language_defn): Likewise.
11869         * f-lang.c (f_language_defn): Likewise.
11870         * go-lang.c (go_language_defn): Likewise.
11871         * language.c (unknown_language_defn): Likewise.
11872         (auto_language_defn): Likewise.
11873         * language.h (struct language_defn): Remove la_magic field.
11874         (LANG_MAGIC): Delete.
11875         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11876         * objc-lang.c (objc_language_defn): Likewise.
11877         * opencl-lang.c (opencl_language_defn): Likewise.
11878         * p-lang.c (pascal_language_defn): Likewise.
11879         * rust-lang.c (rust_language_defn): Likewise.
11880
11881 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11882
11883         * riscv-tdep.c (riscv_type_align): New function.
11884         (riscv_type_alignment): Delete.
11885         (riscv_arg_location): Use 'type_align'.
11886         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11887
11888 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11889
11890         * gdbtypes.c (type_align): A struct with no non-static fields also
11891         has alignment of 1.
11892
11893 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11894
11895         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11896         component to 0.
11897         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11898         member.
11899         (riscv_struct_info::analyse): New implementation using new
11900         analyse_inner member function.
11901         (riscv_struct_info::field_offset): New member function.
11902         (riscv_struct_info::m_offsets): New member variable.
11903         (riscv_struct_info::analyse_inner): New private member function,
11904         takes the old implementation of riscv_struct_info::analyse but
11905         extended to track field offsets.
11906         (riscv_call_arg_struct): Update the struct folding special cases
11907         to handle cases where empty C++ structs, which are non-zero
11908         length, are found.
11909         (riscv_arg_location): Initialise the length of each location, a
11910         non-zero length now indicates the location is in use.
11911         (riscv_push_dummy_call): Allow for the first location having a
11912         non-zero offset when setting up arguments.
11913         (riscv_return_value): Likewise, but for return values.
11914
11915 2019-04-11  Tom Tromey  <tromey@adacore.com>
11916
11917         * utils.c (internal_vproblem): Make "msg" const.
11918
11919 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11920
11921         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11922         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11923         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11924         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11925
11926 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11927
11928         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11929         function.
11930         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11931         of amd64_collect_native_gregset.
11932         (amd64_linux_nat_target::store_registers): Likewise.
11933
11934 2019-04-10  Tom Tromey  <tom@tromey.com>
11935
11936         * symtab.c (lookup_global_symbol_from_objfile)
11937         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11938         * objfiles.h (class separate_debug_iterator): New.
11939         (class separate_debug_range): New.
11940         (struct objfile) <separate_debug_objfiles>: New method.
11941         (objfile_separate_debug_iterate): Don't declare.
11942         * objfiles.c (separate_debug_iterator::operator++): Rename from
11943         objfile_separate_debug_iterate.
11944         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11945         iterator.
11946         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11947         iterator.
11948
11949 2019-04-10  Tom Tromey  <tom@tromey.com>
11950
11951         * symfile.c (reread_symbols): Remove old comment.
11952         * objfiles.c (free_all_objfiles): Fix a typo.
11953
11954 2019-04-10  Tom Tromey  <tom@tromey.com>
11955
11956         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11957         * minsyms.c (lookup_minimal_symbol): Use foreach.
11958         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11959         (lookup_minimal_symbol_solib_trampoline): Likewise.
11960         * symfile.c (reread_symbols): Use foreach.
11961
11962 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11963             Tom Tromey  <tromey@adacore.com>
11964
11965         PR rust/24414:
11966         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11967         (rust_lex_int_test): Change "value" to be LONGEST.
11968         (rust_lex_tests): Add test for long integer literal.
11969
11970 2019-04-09  Tom Tromey  <tromey@adacore.com>
11971
11972         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11973         to bool.
11974         (extended_remote_target::attach): Update.
11975         (remote_target::remote_notice_new_inferior): Update.
11976         (remote_target::add_current_inferior_and_thread): Update.
11977         * inferior.c (exit_inferior_1): Use "false".
11978         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11979
11980 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11981
11982         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11983         the "start" command.
11984
11985 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11986
11987         * python/py-inferior.c (infpy_thread_from_thread_handle):
11988         Adjust comments to reflect renaming of thread_from_thread_handle
11989         to thread_from_handle.  Adjust keywords.  Fix type error message.
11990         (inferior_object_methods): Add thread_from_handle.  Retain
11991         thread_from_thread_handle, but mark it as deprecated.
11992
11993 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11994
11995         * gdbthread.h (find_thread_by_handle): Revise declaration.
11996         * thread.c (find_thread_by_handle): Likewise.  Adjust
11997         implementation too.
11998         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11999         support for buffer objects as handles.
12000
12001 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12002
12003         * python/py-infthread.c (thpy_thread_handle): New function.
12004         (thread_object_methods): Register thpy_thread_handle.
12005
12006 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
12007
12008         * gdbthread.h (thread_to_thread_handle): Declare.
12009         * thread.c (gdbtypes.h): Include.
12010         (thread_to_thread_handle): New function.
12011
12012         * target.h (struct target_ops): Add thread_info_to_thread_handle.
12013         (target_thread_info_to_thread_handle): Declare.
12014         * target.c (target_thread_info_to_thread_handle): New function.
12015         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12016         * target-delegates.c: Regenerate.
12017
12018         * linux-thread-db.c (class thread_db_target): Add method
12019         thread_info_to_thread_handle.
12020         (thread_db_target::thread_info_to_thread_handle): Define.
12021         * remote.c (class remote_target): Add new method
12022         thread_info_to_thread_handle.
12023         (remote_target::thread_info_to_thread_handle): Define.
12024
12025 2019-04-08  Pedro Alves  <palves@redhat.com>
12026
12027         * common/common-exceptions.c (throw_exception): Don't create
12028         named object to throw; throw directly.
12029         (throw_it): Likewise.  Don't initialize gdb_exception::message
12030         here, with new; pass FMT and AP to the ctor instead.
12031         * common/common-exceptions.h: Include <string>.
12032         (gdb_exception::gdb_exception(enum return_reason, enum errors,
12033         const char *, va_list)): New ctor.  Use std::make_shared.
12034         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12035         errors)): Delete.
12036         (gdb_exception_error::gdb_exception_error(enum errors, const char
12037         *, va_list)): New.
12038         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12039         Add assertion.
12040         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12041         errors)): Delete.
12042         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12043         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12044         Add assertion.
12045
12046 2019-04-08  Tom Tromey  <tom@tromey.com>
12047
12048         * valops.c (value_rtti_indirect_type): Replace throw_exception
12049         with throw.
12050         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12051         with throw.
12052         * thread.c (thr_try_catch_cmd): Replace throw_exception with
12053         throw.
12054         * target.c (target_translate_tls_address): Replace throw_exception
12055         with throw.
12056         * stack.c (frame_apply_command_count): Replace throw_exception
12057         with throw.
12058         * solib-spu.c (append_ocl_sos): Replace throw_exception with
12059         throw.
12060         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12061         with throw.
12062         * rs6000-tdep.c (rs6000_frame_cache)
12063         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12064         * remote.c: Replace throw_exception with throw.
12065         * record-full.c (record_full_message, record_full_wait_1)
12066         (record_full_restore): Replace throw_exception with throw.
12067         * record-btrace.c:
12068         (get_thread_current_frame_id, record_btrace_start_replaying)
12069         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12070         (cmd_record_btrace_start): Replace throw_exception with throw.
12071         * parse.c (parse_exp_in_context_1): Replace throw_exception with
12072         throw.
12073         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12074         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12075         * linespec.c:
12076         (find_linespec_symbols): Replace throw_exception with throw.
12077         * infrun.c (displaced_step_prepare, resume): Replace
12078         throw_exception with throw.
12079         * infcmd.c (post_create_inferior): Replace throw_exception with
12080         throw.
12081         * inf-loop.c (inferior_event_handler): Replace throw_exception
12082         with throw.
12083         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12084         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12085         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12086         (get_prev_frame_always, get_frame_pc_if_available)
12087         (get_frame_address_in_block_if_available, get_frame_language):
12088         Replace throw_exception with throw.
12089         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12090         throw_exception with throw.
12091         * eval.c (fetch_subexp_value, evaluate_var_value)
12092         (evaluate_funcall, evaluate_subexp_standard): Replace
12093         throw_exception with throw.
12094         * dwarf2loc.c (call_site_find_chain)
12095         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12096         Replace throw_exception with throw.
12097         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12098         with throw.
12099         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12100         throw.
12101         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12102         * completer.c (complete_line_internal): Replace throw_exception
12103         with throw.
12104         * compile/compile-object-run.c (compile_object_run): Replace
12105         throw_exception with throw.
12106         * cli/cli-script.c (process_next_line): Replace throw_exception
12107         with throw.
12108         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12109         (btrace_enable, btrace_maint_update_pt_packets): Replace
12110         throw_exception with throw.
12111         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12112         throw_exception with throw.
12113         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12114         throw_exception with throw.
12115         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12116         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12117         * aarch64-tdep.c (aarch64_make_prologue_cache)
12118         (aarch64_make_stub_cache): Replace throw_exception with throw.
12119
12120 2019-04-08  Tom Tromey  <tom@tromey.com>
12121
12122         * common/common-exceptions.c (throw_exception): Rename from
12123         throw_exception_cxx.  Remove old copy.  Make argument const.
12124         (throw_it): Create and throw exception objects directly.
12125         * common/common-exceptions.h (throw_exception): Make argument
12126         const.
12127         (struct gdb_exception_error): Add constructor.
12128         (struct gdb_exception_quit): Add constructor.
12129
12130 2019-04-08  Tom Tromey  <tom@tromey.com>
12131
12132         * common/common-exceptions.h (exception_rethrow): Don't declare.
12133         (TRY_SJLJ): Update comment.
12134         (TRY, CATCH, END_CATCH): Remove.
12135         * common/common-exceptions.c (exception_rethrow): Remove.
12136
12137 2019-04-08  Tom Tromey  <tom@tromey.com>
12138
12139         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12140         Remove.
12141         (gdb_exception_error): Rename from
12142         gdb_exception_RETURN_MASK_ERROR.
12143         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12144         (gdb_quit_bad_alloc): Update.
12145         * aarch64-tdep.c: Update.
12146         * ada-lang.c: Update.
12147         * ada-typeprint.c: Update.
12148         * ada-valprint.c: Update.
12149         * amd64-tdep.c: Update.
12150         * arch-utils.c: Update.
12151         * break-catch-throw.c: Update.
12152         * breakpoint.c: Update.
12153         * btrace.c: Update.
12154         * c-varobj.c: Update.
12155         * cli/cli-cmds.c: Update.
12156         * cli/cli-interp.c: Update.
12157         * cli/cli-script.c: Update.
12158         * common/common-exceptions.c: Update.
12159         * common/new-op.c: Update.
12160         * common/selftest.c: Update.
12161         * compile/compile-c-symbols.c: Update.
12162         * compile/compile-cplus-symbols.c: Update.
12163         * compile/compile-object-load.c: Update.
12164         * compile/compile-object-run.c: Update.
12165         * completer.c: Update.
12166         * corelow.c: Update.
12167         * cp-abi.c: Update.
12168         * cp-support.c: Update.
12169         * cp-valprint.c: Update.
12170         * darwin-nat.c: Update.
12171         * disasm-selftests.c: Update.
12172         * dtrace-probe.c: Update.
12173         * dwarf-index-cache.c: Update.
12174         * dwarf-index-write.c: Update.
12175         * dwarf2-frame-tailcall.c: Update.
12176         * dwarf2-frame.c: Update.
12177         * dwarf2loc.c: Update.
12178         * dwarf2read.c: Update.
12179         * eval.c: Update.
12180         * event-loop.c: Update.
12181         * event-top.c: Update.
12182         * exec.c: Update.
12183         * f-valprint.c: Update.
12184         * fbsd-tdep.c: Update.
12185         * frame-unwind.c: Update.
12186         * frame.c: Update.
12187         * gdbtypes.c: Update.
12188         * gnu-v3-abi.c: Update.
12189         * guile/guile-internal.h: Update.
12190         * guile/scm-block.c: Update.
12191         * guile/scm-breakpoint.c: Update.
12192         * guile/scm-cmd.c: Update.
12193         * guile/scm-disasm.c: Update.
12194         * guile/scm-frame.c: Update.
12195         * guile/scm-lazy-string.c: Update.
12196         * guile/scm-math.c: Update.
12197         * guile/scm-param.c: Update.
12198         * guile/scm-ports.c: Update.
12199         * guile/scm-pretty-print.c: Update.
12200         * guile/scm-symbol.c: Update.
12201         * guile/scm-symtab.c: Update.
12202         * guile/scm-type.c: Update.
12203         * guile/scm-value.c: Update.
12204         * i386-linux-tdep.c: Update.
12205         * i386-tdep.c: Update.
12206         * inf-loop.c: Update.
12207         * infcall.c: Update.
12208         * infcmd.c: Update.
12209         * infrun.c: Update.
12210         * jit.c: Update.
12211         * language.c: Update.
12212         * linespec.c: Update.
12213         * linux-fork.c: Update.
12214         * linux-nat.c: Update.
12215         * linux-tdep.c: Update.
12216         * linux-thread-db.c: Update.
12217         * main.c: Update.
12218         * mi/mi-cmd-break.c: Update.
12219         * mi/mi-cmd-stack.c: Update.
12220         * mi/mi-interp.c: Update.
12221         * mi/mi-main.c: Update.
12222         * objc-lang.c: Update.
12223         * p-valprint.c: Update.
12224         * parse.c: Update.
12225         * ppc-linux-tdep.c: Update.
12226         * printcmd.c: Update.
12227         * python/py-arch.c: Update.
12228         * python/py-breakpoint.c: Update.
12229         * python/py-cmd.c: Update.
12230         * python/py-finishbreakpoint.c: Update.
12231         * python/py-frame.c: Update.
12232         * python/py-framefilter.c: Update.
12233         * python/py-gdb-readline.c: Update.
12234         * python/py-inferior.c: Update.
12235         * python/py-infthread.c: Update.
12236         * python/py-lazy-string.c: Update.
12237         * python/py-linetable.c: Update.
12238         * python/py-objfile.c: Update.
12239         * python/py-param.c: Update.
12240         * python/py-prettyprint.c: Update.
12241         * python/py-progspace.c: Update.
12242         * python/py-record-btrace.c: Update.
12243         * python/py-record.c: Update.
12244         * python/py-symbol.c: Update.
12245         * python/py-type.c: Update.
12246         * python/py-unwind.c: Update.
12247         * python/py-utils.c: Update.
12248         * python/py-value.c: Update.
12249         * python/python.c: Update.
12250         * record-btrace.c: Update.
12251         * record-full.c: Update.
12252         * remote-fileio.c: Update.
12253         * remote.c: Update.
12254         * riscv-tdep.c: Update.
12255         * rs6000-aix-tdep.c: Update.
12256         * rs6000-tdep.c: Update.
12257         * rust-exp.y: Update.
12258         * rust-lang.c: Update.
12259         * s390-tdep.c: Update.
12260         * selftest-arch.c: Update.
12261         * solib-dsbt.c: Update.
12262         * solib-frv.c: Update.
12263         * solib-spu.c: Update.
12264         * solib-svr4.c: Update.
12265         * solib.c: Update.
12266         * sparc64-linux-tdep.c: Update.
12267         * stack.c: Update.
12268         * symfile-mem.c: Update.
12269         * symmisc.c: Update.
12270         * target.c: Update.
12271         * thread.c: Update.
12272         * top.c: Update.
12273         * tracefile-tfile.c: Update.
12274         * tui/tui.c: Update.
12275         * typeprint.c: Update.
12276         * unittests/cli-utils-selftests.c: Update.
12277         * unittests/parse-connection-spec-selftests.c: Update.
12278         * valops.c: Update.
12279         * valprint.c: Update.
12280         * value.c: Update.
12281         * varobj.c: Update.
12282         * windows-nat.c: Update.
12283         * x86-linux-nat.c: Update.
12284         * xml-support.c: Update.
12285
12286 2019-04-08  Tom Tromey  <tom@tromey.com>
12287
12288         * xml-support.c: Use C++ exception handling.
12289         * x86-linux-nat.c: Use C++ exception handling.
12290         * windows-nat.c: Use C++ exception handling.
12291         * varobj.c: Use C++ exception handling.
12292         * value.c: Use C++ exception handling.
12293         * valprint.c: Use C++ exception handling.
12294         * valops.c: Use C++ exception handling.
12295         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12296         handling.
12297         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12298         * typeprint.c: Use C++ exception handling.
12299         * tui/tui.c: Use C++ exception handling.
12300         * tracefile-tfile.c: Use C++ exception handling.
12301         * top.c: Use C++ exception handling.
12302         * thread.c: Use C++ exception handling.
12303         * target.c: Use C++ exception handling.
12304         * symmisc.c: Use C++ exception handling.
12305         * symfile-mem.c: Use C++ exception handling.
12306         * stack.c: Use C++ exception handling.
12307         * sparc64-linux-tdep.c: Use C++ exception handling.
12308         * solib.c: Use C++ exception handling.
12309         * solib-svr4.c: Use C++ exception handling.
12310         * solib-spu.c: Use C++ exception handling.
12311         * solib-frv.c: Use C++ exception handling.
12312         * solib-dsbt.c: Use C++ exception handling.
12313         * selftest-arch.c: Use C++ exception handling.
12314         * s390-tdep.c: Use C++ exception handling.
12315         * rust-lang.c: Use C++ exception handling.
12316         * rust-exp.y: Use C++ exception handling.
12317         * rs6000-tdep.c: Use C++ exception handling.
12318         * rs6000-aix-tdep.c: Use C++ exception handling.
12319         * riscv-tdep.c: Use C++ exception handling.
12320         * remote.c: Use C++ exception handling.
12321         * remote-fileio.c: Use C++ exception handling.
12322         * record-full.c: Use C++ exception handling.
12323         * record-btrace.c: Use C++ exception handling.
12324         * python/python.c: Use C++ exception handling.
12325         * python/py-value.c: Use C++ exception handling.
12326         * python/py-utils.c: Use C++ exception handling.
12327         * python/py-unwind.c: Use C++ exception handling.
12328         * python/py-type.c: Use C++ exception handling.
12329         * python/py-symbol.c: Use C++ exception handling.
12330         * python/py-record.c: Use C++ exception handling.
12331         * python/py-record-btrace.c: Use C++ exception handling.
12332         * python/py-progspace.c: Use C++ exception handling.
12333         * python/py-prettyprint.c: Use C++ exception handling.
12334         * python/py-param.c: Use C++ exception handling.
12335         * python/py-objfile.c: Use C++ exception handling.
12336         * python/py-linetable.c: Use C++ exception handling.
12337         * python/py-lazy-string.c: Use C++ exception handling.
12338         * python/py-infthread.c: Use C++ exception handling.
12339         * python/py-inferior.c: Use C++ exception handling.
12340         * python/py-gdb-readline.c: Use C++ exception handling.
12341         * python/py-framefilter.c: Use C++ exception handling.
12342         * python/py-frame.c: Use C++ exception handling.
12343         * python/py-finishbreakpoint.c: Use C++ exception handling.
12344         * python/py-cmd.c: Use C++ exception handling.
12345         * python/py-breakpoint.c: Use C++ exception handling.
12346         * python/py-arch.c: Use C++ exception handling.
12347         * printcmd.c: Use C++ exception handling.
12348         * ppc-linux-tdep.c: Use C++ exception handling.
12349         * parse.c: Use C++ exception handling.
12350         * p-valprint.c: Use C++ exception handling.
12351         * objc-lang.c: Use C++ exception handling.
12352         * mi/mi-main.c: Use C++ exception handling.
12353         * mi/mi-interp.c: Use C++ exception handling.
12354         * mi/mi-cmd-stack.c: Use C++ exception handling.
12355         * mi/mi-cmd-break.c: Use C++ exception handling.
12356         * main.c: Use C++ exception handling.
12357         * linux-thread-db.c: Use C++ exception handling.
12358         * linux-tdep.c: Use C++ exception handling.
12359         * linux-nat.c: Use C++ exception handling.
12360         * linux-fork.c: Use C++ exception handling.
12361         * linespec.c: Use C++ exception handling.
12362         * language.c: Use C++ exception handling.
12363         * jit.c: Use C++ exception handling.
12364         * infrun.c: Use C++ exception handling.
12365         * infcmd.c: Use C++ exception handling.
12366         * infcall.c: Use C++ exception handling.
12367         * inf-loop.c: Use C++ exception handling.
12368         * i386-tdep.c: Use C++ exception handling.
12369         * i386-linux-tdep.c: Use C++ exception handling.
12370         * guile/scm-value.c: Use C++ exception handling.
12371         * guile/scm-type.c: Use C++ exception handling.
12372         * guile/scm-symtab.c: Use C++ exception handling.
12373         * guile/scm-symbol.c: Use C++ exception handling.
12374         * guile/scm-pretty-print.c: Use C++ exception handling.
12375         * guile/scm-ports.c: Use C++ exception handling.
12376         * guile/scm-param.c: Use C++ exception handling.
12377         * guile/scm-math.c: Use C++ exception handling.
12378         * guile/scm-lazy-string.c: Use C++ exception handling.
12379         * guile/scm-frame.c: Use C++ exception handling.
12380         * guile/scm-disasm.c: Use C++ exception handling.
12381         * guile/scm-cmd.c: Use C++ exception handling.
12382         * guile/scm-breakpoint.c: Use C++ exception handling.
12383         * guile/scm-block.c: Use C++ exception handling.
12384         * guile/guile-internal.h: Use C++ exception handling.
12385         * gnu-v3-abi.c: Use C++ exception handling.
12386         * gdbtypes.c: Use C++ exception handling.
12387         * frame.c: Use C++ exception handling.
12388         * frame-unwind.c: Use C++ exception handling.
12389         * fbsd-tdep.c: Use C++ exception handling.
12390         * f-valprint.c: Use C++ exception handling.
12391         * exec.c: Use C++ exception handling.
12392         * event-top.c: Use C++ exception handling.
12393         * event-loop.c: Use C++ exception handling.
12394         * eval.c: Use C++ exception handling.
12395         * dwarf2read.c: Use C++ exception handling.
12396         * dwarf2loc.c: Use C++ exception handling.
12397         * dwarf2-frame.c: Use C++ exception handling.
12398         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12399         * dwarf-index-write.c: Use C++ exception handling.
12400         * dwarf-index-cache.c: Use C++ exception handling.
12401         * dtrace-probe.c: Use C++ exception handling.
12402         * disasm-selftests.c: Use C++ exception handling.
12403         * darwin-nat.c: Use C++ exception handling.
12404         * cp-valprint.c: Use C++ exception handling.
12405         * cp-support.c: Use C++ exception handling.
12406         * cp-abi.c: Use C++ exception handling.
12407         * corelow.c: Use C++ exception handling.
12408         * completer.c: Use C++ exception handling.
12409         * compile/compile-object-run.c: Use C++ exception handling.
12410         * compile/compile-object-load.c: Use C++ exception handling.
12411         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12412         * compile/compile-c-symbols.c: Use C++ exception handling.
12413         * common/selftest.c: Use C++ exception handling.
12414         * common/new-op.c: Use C++ exception handling.
12415         * cli/cli-script.c: Use C++ exception handling.
12416         * cli/cli-interp.c: Use C++ exception handling.
12417         * cli/cli-cmds.c: Use C++ exception handling.
12418         * c-varobj.c: Use C++ exception handling.
12419         * btrace.c: Use C++ exception handling.
12420         * breakpoint.c: Use C++ exception handling.
12421         * break-catch-throw.c: Use C++ exception handling.
12422         * arch-utils.c: Use C++ exception handling.
12423         * amd64-tdep.c: Use C++ exception handling.
12424         * ada-valprint.c: Use C++ exception handling.
12425         * ada-typeprint.c: Use C++ exception handling.
12426         * ada-lang.c: Use C++ exception handling.
12427         * aarch64-tdep.c: Use C++ exception handling.
12428
12429 2019-04-08  Tom Tromey  <tom@tromey.com>
12430
12431         * xml-support.c (gdb_xml_parser::parse): Update.
12432         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12433         * value.c (show_convenience): Update.
12434         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12435         (test_parse_flags_qcs): Update.
12436         * thread.c (thr_try_catch_cmd): Update.
12437         * target.c (target_translate_tls_address): Update.
12438         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12439         (info_frame_command_core, frame_apply_command_count): Update.
12440         * rust-exp.y (rust_lex_exception_test): Update.
12441         * riscv-tdep.c (riscv_print_one_register_info): Update.
12442         * remote.c (remote_target::enable_btrace): Update.
12443         * record-btrace.c (record_btrace_enable_warn): Update.
12444         * python/py-utils.c (gdbpy_convert_exception): Update.
12445         * printcmd.c (do_one_display, print_variable_and_value): Update.
12446         * mi/mi-main.c (mi_print_exception): Update.
12447         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12448         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12449         * linux-nat.c (linux_nat_target::attach): Update.
12450         * linux-fork.c (class scoped_switch_fork_info): Update.
12451         * infrun.c (displaced_step_prepare): Update.
12452         * infcall.c (call_function_by_hand_dummy): Update.
12453         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12454         * gnu-v3-abi.c (print_one_vtable): Update.
12455         * frame.c (get_prev_frame_always): Update.
12456         * f-valprint.c (info_common_command_for_block): Update.
12457         * exec.c (try_open_exec_file): Update.
12458         * exceptions.c (print_exception, exception_print)
12459         (exception_fprintf, exception_print_same): Update.
12460         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12461         * dwarf-index-cache.c (index_cache::store)
12462         (index_cache::lookup_gdb_index): Update.
12463         * darwin-nat.c (maybe_cache_shell): Update.
12464         * cp-valprint.c (cp_print_value_fields): Update.
12465         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12466         (gcc_cplus_symbol_address): Update.
12467         * compile/compile-c-symbols.c (gcc_convert_symbol)
12468         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12469         * common/selftest.c: Update.
12470         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12471         a std::string.
12472         (exception_try_scope_entry, exception_try_scope_exit): Don't
12473         declare.
12474         (struct exception_try_scope): Remove.
12475         (TRY): Don't use exception_try_scope.
12476         (struct gdb_exception): Add constructor, operator=.
12477         <what>: New method.
12478         (struct gdb_exception_RETURN_MASK_ALL)
12479         (struct gdb_exception_RETURN_MASK_ERROR)
12480         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12481         (struct gdb_quit_bad_alloc): Update.
12482         * common/common-exceptions.c (exception_none): Change
12483         initializer.
12484         (struct catcher) <state, exception>: Initialize inline.
12485         <prev>: Remove member.
12486         (current_catcher): Remove.
12487         (catchers): New global.
12488         (exceptions_state_mc_init): Simplify.
12489         (catcher_pop): Remove.
12490         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12491         (try_scope_depth, exception_try_scope_entry)
12492         (exception_try_scope_exit): Remove.
12493         (throw_exception_sjlj): Update.
12494         (exception_messages, exception_messages_size): Remove.
12495         (throw_it): Simplify.
12496         (gdb_exception_sliced_copy): Remove.
12497         (throw_exception_cxx): Update.
12498         * cli/cli-script.c (script_from_file): Update.
12499         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12500         Update.
12501         * ada-valprint.c (ada_val_print): Update.
12502         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12503         (create_excep_cond_exprs): Update.
12504
12505 2019-04-08  Tom Tromey  <tom@tromey.com>
12506
12507         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12508         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12509         (TRY, CATCH, END_CATCH): Remove some definitions.
12510         * common/common-exceptions.c: Don't use GDB_XCPT.
12511         (catcher_list_size): Remove.
12512         (throw_exception, throw_it): Simplify.
12513
12514 2019-04-05  Tom Tromey  <tom@tromey.com>
12515
12516         Revert the header-sorting patch.
12517         * ft32-tdep.c: Revert.
12518         * frv-tdep.c: Revert.
12519         * frv-linux-tdep.c: Revert.
12520         * frame.c: Revert.
12521         * frame-unwind.c: Revert.
12522         * frame-base.c: Revert.
12523         * fork-child.c: Revert.
12524         * findvar.c: Revert.
12525         * findcmd.c: Revert.
12526         * filesystem.c: Revert.
12527         * filename-seen-cache.h: Revert.
12528         * filename-seen-cache.c: Revert.
12529         * fbsd-tdep.c: Revert.
12530         * fbsd-nat.h: Revert.
12531         * fbsd-nat.c: Revert.
12532         * f-valprint.c: Revert.
12533         * f-typeprint.c: Revert.
12534         * f-lang.c: Revert.
12535         * extension.h: Revert.
12536         * extension.c: Revert.
12537         * extension-priv.h: Revert.
12538         * expprint.c: Revert.
12539         * exec.h: Revert.
12540         * exec.c: Revert.
12541         * exceptions.c: Revert.
12542         * event-top.c: Revert.
12543         * event-loop.c: Revert.
12544         * eval.c: Revert.
12545         * elfread.c: Revert.
12546         * dwarf2read.h: Revert.
12547         * dwarf2read.c: Revert.
12548         * dwarf2loc.c: Revert.
12549         * dwarf2expr.h: Revert.
12550         * dwarf2expr.c: Revert.
12551         * dwarf2-frame.c: Revert.
12552         * dwarf2-frame-tailcall.c: Revert.
12553         * dwarf-index-write.h: Revert.
12554         * dwarf-index-write.c: Revert.
12555         * dwarf-index-common.c: Revert.
12556         * dwarf-index-cache.h: Revert.
12557         * dwarf-index-cache.c: Revert.
12558         * dummy-frame.c: Revert.
12559         * dtrace-probe.c: Revert.
12560         * disasm.h: Revert.
12561         * disasm.c: Revert.
12562         * disasm-selftests.c: Revert.
12563         * dictionary.c: Revert.
12564         * dicos-tdep.c: Revert.
12565         * demangle.c: Revert.
12566         * dcache.h: Revert.
12567         * dcache.c: Revert.
12568         * darwin-nat.h: Revert.
12569         * darwin-nat.c: Revert.
12570         * darwin-nat-info.c: Revert.
12571         * d-valprint.c: Revert.
12572         * d-namespace.c: Revert.
12573         * d-lang.c: Revert.
12574         * ctf.c: Revert.
12575         * csky-tdep.c: Revert.
12576         * csky-linux-tdep.c: Revert.
12577         * cris-tdep.c: Revert.
12578         * cris-linux-tdep.c: Revert.
12579         * cp-valprint.c: Revert.
12580         * cp-support.c: Revert.
12581         * cp-namespace.c: Revert.
12582         * cp-abi.c: Revert.
12583         * corelow.c: Revert.
12584         * corefile.c: Revert.
12585         * continuations.c: Revert.
12586         * completer.h: Revert.
12587         * completer.c: Revert.
12588         * complaints.c: Revert.
12589         * coffread.c: Revert.
12590         * coff-pe-read.c: Revert.
12591         * cli-out.h: Revert.
12592         * cli-out.c: Revert.
12593         * charset.c: Revert.
12594         * c-varobj.c: Revert.
12595         * c-valprint.c: Revert.
12596         * c-typeprint.c: Revert.
12597         * c-lang.c: Revert.
12598         * buildsym.c: Revert.
12599         * buildsym-legacy.c: Revert.
12600         * build-id.h: Revert.
12601         * build-id.c: Revert.
12602         * btrace.c: Revert.
12603         * bsd-uthread.c: Revert.
12604         * breakpoint.h: Revert.
12605         * breakpoint.c: Revert.
12606         * break-catch-throw.c: Revert.
12607         * break-catch-syscall.c: Revert.
12608         * break-catch-sig.c: Revert.
12609         * blockframe.c: Revert.
12610         * block.c: Revert.
12611         * bfin-tdep.c: Revert.
12612         * bfin-linux-tdep.c: Revert.
12613         * bfd-target.c: Revert.
12614         * bcache.c: Revert.
12615         * ax-general.c: Revert.
12616         * ax-gdb.h: Revert.
12617         * ax-gdb.c: Revert.
12618         * avr-tdep.c: Revert.
12619         * auxv.c: Revert.
12620         * auto-load.c: Revert.
12621         * arm-wince-tdep.c: Revert.
12622         * arm-tdep.c: Revert.
12623         * arm-symbian-tdep.c: Revert.
12624         * arm-pikeos-tdep.c: Revert.
12625         * arm-obsd-tdep.c: Revert.
12626         * arm-nbsd-tdep.c: Revert.
12627         * arm-nbsd-nat.c: Revert.
12628         * arm-linux-tdep.c: Revert.
12629         * arm-linux-nat.c: Revert.
12630         * arm-fbsd-tdep.c: Revert.
12631         * arm-fbsd-nat.c: Revert.
12632         * arm-bsd-tdep.c: Revert.
12633         * arch-utils.c: Revert.
12634         * arc-tdep.c: Revert.
12635         * arc-newlib-tdep.c: Revert.
12636         * annotate.h: Revert.
12637         * annotate.c: Revert.
12638         * amd64-windows-tdep.c: Revert.
12639         * amd64-windows-nat.c: Revert.
12640         * amd64-tdep.c: Revert.
12641         * amd64-sol2-tdep.c: Revert.
12642         * amd64-obsd-tdep.c: Revert.
12643         * amd64-obsd-nat.c: Revert.
12644         * amd64-nbsd-tdep.c: Revert.
12645         * amd64-nbsd-nat.c: Revert.
12646         * amd64-nat.c: Revert.
12647         * amd64-linux-tdep.c: Revert.
12648         * amd64-linux-nat.c: Revert.
12649         * amd64-fbsd-tdep.c: Revert.
12650         * amd64-fbsd-nat.c: Revert.
12651         * amd64-dicos-tdep.c: Revert.
12652         * amd64-darwin-tdep.c: Revert.
12653         * amd64-bsd-nat.c: Revert.
12654         * alpha-tdep.c: Revert.
12655         * alpha-obsd-tdep.c: Revert.
12656         * alpha-nbsd-tdep.c: Revert.
12657         * alpha-mdebug-tdep.c: Revert.
12658         * alpha-linux-tdep.c: Revert.
12659         * alpha-linux-nat.c: Revert.
12660         * alpha-bsd-tdep.c: Revert.
12661         * alpha-bsd-nat.c: Revert.
12662         * aix-thread.c: Revert.
12663         * agent.c: Revert.
12664         * addrmap.c: Revert.
12665         * ada-varobj.c: Revert.
12666         * ada-valprint.c: Revert.
12667         * ada-typeprint.c: Revert.
12668         * ada-tasks.c: Revert.
12669         * ada-lang.c: Revert.
12670         * aarch64-tdep.c: Revert.
12671         * aarch64-ravenscar-thread.c: Revert.
12672         * aarch64-newlib-tdep.c: Revert.
12673         * aarch64-linux-tdep.c: Revert.
12674         * aarch64-linux-nat.c: Revert.
12675         * aarch64-fbsd-tdep.c: Revert.
12676         * aarch64-fbsd-nat.c: Revert.
12677         * aarch32-linux-nat.c: Revert.
12678
12679 2019-04-05  Tom Tromey  <tom@tromey.com>
12680
12681         * ft32-tdep.c: Sort headers.
12682         * frv-tdep.c: Sort headers.
12683         * frv-linux-tdep.c: Sort headers.
12684         * frame.c: Sort headers.
12685         * frame-unwind.c: Sort headers.
12686         * frame-base.c: Sort headers.
12687         * fork-child.c: Sort headers.
12688         * findvar.c: Sort headers.
12689         * findcmd.c: Sort headers.
12690         * filesystem.c: Sort headers.
12691         * filename-seen-cache.h: Sort headers.
12692         * filename-seen-cache.c: Sort headers.
12693         * fbsd-tdep.c: Sort headers.
12694         * fbsd-nat.h: Sort headers.
12695         * fbsd-nat.c: Sort headers.
12696         * f-valprint.c: Sort headers.
12697         * f-typeprint.c: Sort headers.
12698         * f-lang.c: Sort headers.
12699         * extension.h: Sort headers.
12700         * extension.c: Sort headers.
12701         * extension-priv.h: Sort headers.
12702         * expprint.c: Sort headers.
12703         * exec.h: Sort headers.
12704         * exec.c: Sort headers.
12705         * exceptions.c: Sort headers.
12706         * event-top.c: Sort headers.
12707         * event-loop.c: Sort headers.
12708         * eval.c: Sort headers.
12709         * elfread.c: Sort headers.
12710         * dwarf2read.h: Sort headers.
12711         * dwarf2read.c: Sort headers.
12712         * dwarf2loc.c: Sort headers.
12713         * dwarf2expr.h: Sort headers.
12714         * dwarf2expr.c: Sort headers.
12715         * dwarf2-frame.c: Sort headers.
12716         * dwarf2-frame-tailcall.c: Sort headers.
12717         * dwarf-index-write.h: Sort headers.
12718         * dwarf-index-write.c: Sort headers.
12719         * dwarf-index-common.c: Sort headers.
12720         * dwarf-index-cache.h: Sort headers.
12721         * dwarf-index-cache.c: Sort headers.
12722         * dummy-frame.c: Sort headers.
12723         * dtrace-probe.c: Sort headers.
12724         * disasm.h: Sort headers.
12725         * disasm.c: Sort headers.
12726         * disasm-selftests.c: Sort headers.
12727         * dictionary.c: Sort headers.
12728         * dicos-tdep.c: Sort headers.
12729         * demangle.c: Sort headers.
12730         * dcache.h: Sort headers.
12731         * dcache.c: Sort headers.
12732         * darwin-nat.h: Sort headers.
12733         * darwin-nat.c: Sort headers.
12734         * darwin-nat-info.c: Sort headers.
12735         * d-valprint.c: Sort headers.
12736         * d-namespace.c: Sort headers.
12737         * d-lang.c: Sort headers.
12738         * ctf.c: Sort headers.
12739         * csky-tdep.c: Sort headers.
12740         * csky-linux-tdep.c: Sort headers.
12741         * cris-tdep.c: Sort headers.
12742         * cris-linux-tdep.c: Sort headers.
12743         * cp-valprint.c: Sort headers.
12744         * cp-support.c: Sort headers.
12745         * cp-namespace.c: Sort headers.
12746         * cp-abi.c: Sort headers.
12747         * corelow.c: Sort headers.
12748         * corefile.c: Sort headers.
12749         * continuations.c: Sort headers.
12750         * completer.h: Sort headers.
12751         * completer.c: Sort headers.
12752         * complaints.c: Sort headers.
12753         * coffread.c: Sort headers.
12754         * coff-pe-read.c: Sort headers.
12755         * cli-out.h: Sort headers.
12756         * cli-out.c: Sort headers.
12757         * charset.c: Sort headers.
12758         * c-varobj.c: Sort headers.
12759         * c-valprint.c: Sort headers.
12760         * c-typeprint.c: Sort headers.
12761         * c-lang.c: Sort headers.
12762         * buildsym.c: Sort headers.
12763         * buildsym-legacy.c: Sort headers.
12764         * build-id.h: Sort headers.
12765         * build-id.c: Sort headers.
12766         * btrace.c: Sort headers.
12767         * bsd-uthread.c: Sort headers.
12768         * breakpoint.h: Sort headers.
12769         * breakpoint.c: Sort headers.
12770         * break-catch-throw.c: Sort headers.
12771         * break-catch-syscall.c: Sort headers.
12772         * break-catch-sig.c: Sort headers.
12773         * blockframe.c: Sort headers.
12774         * block.c: Sort headers.
12775         * bfin-tdep.c: Sort headers.
12776         * bfin-linux-tdep.c: Sort headers.
12777         * bfd-target.c: Sort headers.
12778         * bcache.c: Sort headers.
12779         * ax-general.c: Sort headers.
12780         * ax-gdb.h: Sort headers.
12781         * ax-gdb.c: Sort headers.
12782         * avr-tdep.c: Sort headers.
12783         * auxv.c: Sort headers.
12784         * auto-load.c: Sort headers.
12785         * arm-wince-tdep.c: Sort headers.
12786         * arm-tdep.c: Sort headers.
12787         * arm-symbian-tdep.c: Sort headers.
12788         * arm-pikeos-tdep.c: Sort headers.
12789         * arm-obsd-tdep.c: Sort headers.
12790         * arm-nbsd-tdep.c: Sort headers.
12791         * arm-nbsd-nat.c: Sort headers.
12792         * arm-linux-tdep.c: Sort headers.
12793         * arm-linux-nat.c: Sort headers.
12794         * arm-fbsd-tdep.c: Sort headers.
12795         * arm-fbsd-nat.c: Sort headers.
12796         * arm-bsd-tdep.c: Sort headers.
12797         * arch-utils.c: Sort headers.
12798         * arc-tdep.c: Sort headers.
12799         * arc-newlib-tdep.c: Sort headers.
12800         * annotate.h: Sort headers.
12801         * annotate.c: Sort headers.
12802         * amd64-windows-tdep.c: Sort headers.
12803         * amd64-windows-nat.c: Sort headers.
12804         * amd64-tdep.c: Sort headers.
12805         * amd64-sol2-tdep.c: Sort headers.
12806         * amd64-obsd-tdep.c: Sort headers.
12807         * amd64-obsd-nat.c: Sort headers.
12808         * amd64-nbsd-tdep.c: Sort headers.
12809         * amd64-nbsd-nat.c: Sort headers.
12810         * amd64-nat.c: Sort headers.
12811         * amd64-linux-tdep.c: Sort headers.
12812         * amd64-linux-nat.c: Sort headers.
12813         * amd64-fbsd-tdep.c: Sort headers.
12814         * amd64-fbsd-nat.c: Sort headers.
12815         * amd64-dicos-tdep.c: Sort headers.
12816         * amd64-darwin-tdep.c: Sort headers.
12817         * amd64-bsd-nat.c: Sort headers.
12818         * alpha-tdep.c: Sort headers.
12819         * alpha-obsd-tdep.c: Sort headers.
12820         * alpha-nbsd-tdep.c: Sort headers.
12821         * alpha-mdebug-tdep.c: Sort headers.
12822         * alpha-linux-tdep.c: Sort headers.
12823         * alpha-linux-nat.c: Sort headers.
12824         * alpha-bsd-tdep.c: Sort headers.
12825         * alpha-bsd-nat.c: Sort headers.
12826         * aix-thread.c: Sort headers.
12827         * agent.c: Sort headers.
12828         * addrmap.c: Sort headers.
12829         * ada-varobj.c: Sort headers.
12830         * ada-valprint.c: Sort headers.
12831         * ada-typeprint.c: Sort headers.
12832         * ada-tasks.c: Sort headers.
12833         * ada-lang.c: Sort headers.
12834         * aarch64-tdep.c: Sort headers.
12835         * aarch64-ravenscar-thread.c: Sort headers.
12836         * aarch64-newlib-tdep.c: Sort headers.
12837         * aarch64-linux-tdep.c: Sort headers.
12838         * aarch64-linux-nat.c: Sort headers.
12839         * aarch64-fbsd-tdep.c: Sort headers.
12840         * aarch64-fbsd-nat.c: Sort headers.
12841         * aarch32-linux-nat.c: Sort headers.
12842
12843 2019-04-04  Tom Tromey  <tom@tromey.com>
12844
12845         * varobj.c (varobj_create): Update.
12846         * rust-exp.y (struct rust_parser) <update_innermost_block,
12847         lookup_symbol>: New methods.
12848         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12849         Rename.
12850         (rust_parser::rust_lookup_type)
12851         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12852         * printcmd.c (display_command, do_one_display): Update.
12853         * parser-defs.h (struct parser_state) <parser_state>: Add
12854         "tracker" parameter.
12855         (block_tracker): New member.
12856         (class innermost_block_tracker) <innermost_block_tracker>: Add
12857         "types" parameter.
12858         <reset>: Remove method.
12859         (innermost_block): Don't declare.
12860         (null_post_parser): Update.
12861         * parse.c (innermost_block): Remove global.
12862         (write_dollar_variable): Update.
12863         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12864         Remove "tracker_types" parameter.
12865         (parse_expression): Add "tracker" parameter.
12866         (parse_expression_for_completion): Update.
12867         (null_post_parser): Add "tracker" parameter.
12868         * p-exp.y: Update rules.
12869         * m2-exp.y: Update rules.
12870         * language.h (struct language_defn) <la_post_parser>: Add
12871         "tracker" parameter.
12872         * go-exp.y: Update rules.
12873         * f-exp.y: Update rules.
12874         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12875         parameter.
12876         * d-exp.y: Update rules.
12877         * c-exp.y: Update rules.
12878         * breakpoint.c (set_breakpoint_condition): Create an
12879         innermost_block_tracker.
12880         (watch_command_1): Likewise.
12881         * ada-lang.c (resolve): Add "tracker" parameter.
12882         (resolve_subexp): Likewise.
12883         * ada-exp.y (write_var_from_sym): Update.
12884
12885 2019-04-04  Tom Tromey  <tom@tromey.com>
12886
12887         * type-stack.h: New file.
12888         * type-stack.c: New file.
12889         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12890         type-stack.h.
12891         (insert_into_type_stack, insert_type, push_type, push_type_int)
12892         (insert_type_address_space, pop_type, pop_type_int)
12893         (pop_typelist, pop_type_stack, append_type_stack)
12894         (push_type_stack, get_type_stack, push_typelist)
12895         (follow_type_instance_flags, follow_types): Don't declare.
12896         * parse.c (type_stack): Remove global.
12897         (parse_exp_in_context): Update.
12898         (insert_into_type_stack, insert_type, push_type, push_type_int)
12899         (insert_type_address_space, pop_type, pop_type_int)
12900         (pop_typelist, pop_type_stack, append_type_stack)
12901         (push_type_stack, get_type_stack, push_typelist)
12902         (follow_type_instance_flags, follow_types): Remove (moved to
12903         type-stack.c).
12904         * f-exp.y (type_stack): New global.
12905         Update rules.
12906         (push_kind_type, f_parse): Update.
12907         * d-exp.y (type_stack): New global.
12908         Update rules.
12909         (d_parse): Update.
12910         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12911         Update rules.
12912         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12913         (HFILES_NO_SRCDIR): Add type-stack.h.
12914
12915 2019-04-04  Tom Tromey  <tom@tromey.com>
12916
12917         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12918         (rust_parser::convert_ast_to_expression, rust_parse)
12919         (rust_lex_test_completion, rust_lex_tests): Update.
12920         * parser-defs.h (struct expr_completion_state): New.
12921         (struct parser_state) <parser_state>: Add completion parameter.
12922         <mark_struct_expression, mark_completion_tag>: New methods.
12923         <parse_completion, m_completion_state>: New members.
12924         (prefixify_expression, null_post_parser): Update.
12925         (mark_struct_expression, mark_completion_tag): Don't declare.
12926         * parse.c (parse_completion, expout_last_struct)
12927         (expout_tag_completion_type, expout_completion_name): Remove
12928         globals.
12929         (parser_state::mark_struct_expression)
12930         (parser_state::mark_completion_tag): Now methods.
12931         (prefixify_expression): Add last_struct parameter.
12932         (prefixify_subexp): Likewise.
12933         (parse_exp_1): Update.
12934         (parse_exp_in_context): Add cstate parameter.  Update.
12935         (parse_expression_for_completion): Create an
12936         expr_completion_state.
12937         (null_post_parser): Add "completion" parameter.
12938         * p-exp.y: Update rules.
12939         (yylex): Update.
12940         * language.h (struct language_defn) <la_post_parser>: Add
12941         "completing" parameter.
12942         * go-exp.y: Update rules.
12943         (lex_one_token): Update.
12944         * expression.h (parse_completion): Don't declare.
12945         * d-exp.y: Update rules.
12946         (lex_one_token): Update rules.
12947         * c-exp.y: Update rules.
12948         (lex_one_token): Update.
12949         * ada-lang.c (resolve): Add "parse_completion" parameter.
12950         (resolve_subexp): Likewise.
12951         (ada_resolve_function): Likewise.
12952
12953 2019-04-04  Tom Tromey  <tom@tromey.com>
12954
12955         * parser-defs.h (struct parser_state) <start_arglist,
12956         end_arglist>: New methods.
12957         <arglist_len, m_funcall_chain>: New members.
12958         (arglist_len, start_arglist, end_arglist): Don't declare.
12959         * parse.c (arglist_len, funcall_chain): Remove global.
12960         (start_arglist, end_arglist): Remove functions.
12961         (parse_exp_in_context): Update.
12962         * p-exp.y: Update rules.
12963         * m2-exp.y: Update rules.
12964         * go-exp.y: Update rules.
12965         * f-exp.y: Update rules.
12966         * d-exp.y: Update rules.
12967         * c-exp.y: Update rules.
12968
12969 2019-04-04  Tom Tromey  <tom@tromey.com>
12970
12971         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12972         lex_operator, push_back>: New methods.
12973         Update all rules.
12974         (rust_parser::lex_hex, lex_escape): Rename and update.
12975         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12976         (rust_parser::lex_operator): Rename and update.
12977         (rust_parser::lex_number, rustyylex, rustyyerror)
12978         (rust_lex_test_init, rust_lex_test_sequence)
12979         (rust_lex_test_push_back, rust_lex_tests): Update.
12980         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12981         parameter.
12982         <lexptr, prev_lexptr>: New members.
12983         (lexptr, prev_lexptr): Don't declare.
12984         * parse.c (lexptr, prev_lexptr): Remove globals.
12985         (parse_exp_in_context): Update.
12986         * p-exp.y (yylex, yyerror): Update.
12987         * m2-exp.y (parse_number, yylex, yyerror): Update.
12988         * go-exp.y (lex_one_token, yyerror): Update.
12989         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12990         * d-exp.y (lex_one_token, yyerror): Update.
12991         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12992         (lex_one_token, yyerror): Update.
12993         * ada-lex.l (YY_INPUT): Update.
12994         (rewind_to_char): Update.
12995         * ada-exp.y (yyerror): Update.
12996
12997 2019-04-04  Tom Tromey  <tom@tromey.com>
12998
12999         * rust-exp.y (rustyylex, rust_lex_tests): Update.
13000         * parser-defs.h (struct parser_state) <parser_state>: Add new
13001         parameter.
13002         <comma_terminates>: New member.
13003         (comma_terminates): Don't declare global.
13004         * parse.c (comma_terminates): Remove global.
13005         (parse_exp_in_context): Update.
13006         * p-exp.y (yylex): Update.
13007         * m2-exp.y (yylex): Update.
13008         * go-exp.y (lex_one_token): Update.
13009         * f-exp.y (yylex): Update.
13010         * d-exp.y (lex_one_token): Update.
13011         * c-exp.y (lex_one_token): Update.
13012         * ada-lex.l: Update.
13013
13014 2019-04-04  Tom Tromey  <tom@tromey.com>
13015
13016         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13017         (rustyylex, rust_lex_test_init, rust_lex_test_one)
13018         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13019         * parser-defs.h (paren_depth): Don't declare.
13020         * parse.c (paren_depth): Remove global.
13021         (parse_exp_in_context): Update.
13022         * p-exp.y (paren_depth): New global.
13023         (pascal_parse): Initialize it.
13024         * m2-exp.y (paren_depth): New global.
13025         (m2_parse): Initialize it.
13026         * go-exp.y (paren_depth): New global.
13027         (go_parse): Initialize it.
13028         * f-exp.y (paren_depth): New global.
13029         (f_parse): Initialize it.
13030         * d-exp.y (paren_depth): New global.
13031         (d_parse): Initialize it.
13032         * c-exp.y (paren_depth): New global.
13033         (c_parse): Initialize it.
13034         * ada-lex.l (paren_depth): New global.
13035         (lexer_init): Initialize it.
13036
13037 2019-04-04  Tom Tromey  <tom@tromey.com>
13038
13039         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13040         (rust_parser::convert_ast_to_type)
13041         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13042         * parser-defs.h (struct parser_state) <parser_state>: Add
13043         parameters.  Initialize new members.
13044         <expression_context_block, expression_context_pc>: New members.
13045         * parse.c (expression_context_block, expression_context_pc):
13046         Remove globals.
13047         (parse_exp_in_context): Update.
13048         * p-exp.y: Update all rules.
13049         (yylex): Update.
13050         * m2-exp.y: Update all rules.
13051         (yylex): Update.
13052         * go-exp.y (yylex): Update.
13053         * f-exp.y (yylex): Update.
13054         * d-exp.y: Update all rules.
13055         (yylex): Update.
13056         * c-exp.y: Update all rules.
13057         (lex_one_token, classify_name, yylex, c_parse): Update.
13058         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13059
13060 2019-04-04  Tom Tromey  <tom@tromey.com>
13061
13062         * gdbarch.h, gdbarch.c: Rebuild.
13063         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13064         * stap-probe.h:
13065         (struct stap_parse_info): Replace "parser_state" with
13066         "expr_builder".
13067         * parser-defs.h (struct expr_builder): Rename from "parser_state".
13068         (parser_state): New class.
13069         * parse.c (expr_builder): Rename.
13070         (expr_builder::release): Rename.
13071         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13072         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13073         (write_exp_elt_longcst, write_exp_elt_floatcst)
13074         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13075         (write_exp_string_vector, write_exp_bitstring)
13076         (write_exp_msymbol, mark_struct_expression)
13077         (write_dollar_variable)
13078         (insert_type_address_space, increase_expout_size): Replace
13079         "parser_state" with "expr_builder".
13080         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13081         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13082         "parser_state" with "expr_builder".
13083
13084 2019-04-04  Tom Tromey  <tom@tromey.com>
13085
13086         * rust-exp.y: Replace "parse_language" with method call.
13087         * p-exp.y:
13088         (yylex): Replace "parse_language" with method call.
13089         * m2-exp.y:
13090         (yylex): Replace "parse_language" with method call.
13091         * go-exp.y (classify_name): Replace "parse_language" with method
13092         call.
13093         * f-exp.y (yylex): Replace "parse_language" with method call.
13094         * d-exp.y (lex_one_token): Replace "parse_language" with method
13095         call.
13096         * c-exp.y:
13097         (lex_one_token, classify_name, yylex): Replace "parse_language"
13098         with method call.
13099         * ada-exp.y (find_primitive_type, type_char)
13100         (type_system_address): Replace "parse_language" with method call.
13101
13102 2019-04-04  Tom Tromey  <tom@tromey.com>
13103
13104         * rust-exp.y: Replace "parse_gdbarch" with method call.
13105         * parse.c (write_dollar_variable, insert_type_address_space):
13106         Replace "parse_gdbarch" with method call.
13107         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13108         call.
13109         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13110         call.
13111         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13112         "parse_gdbarch" with method call.
13113         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13114         with method call.
13115         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13116         "parse_gdbarch" with method call.
13117         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13118         "parse_gdbarch" with method call.
13119         * c-exp.y (parse_type, parse_number, classify_name): Replace
13120         "parse_gdbarch" with method call.
13121         * ada-lex.l: Replace "parse_gdbarch" with method call.
13122         * ada-exp.y (parse_type, find_primitive_type, type_char)
13123         (type_system_address): Replace "parse_gdbarch" with method call.
13124
13125 2019-04-04  Tom Tromey  <tom@tromey.com>
13126
13127         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13128         * stap-probe.c (stap_parse_argument): Update.
13129         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13130         initial_size parameter.
13131         * rust-exp.y (rust_lex_tests): Update.
13132         * parse.c (parser_state): Update.
13133         (parse_exp_in_context): Update.
13134         * parser-defs.h (struct parser_state) <parser_state>: Remove
13135         "initial_size" parameter.
13136
13137 2019-04-04  Tom Tromey  <tom@tromey.com>
13138
13139         * parser-defs.h (increase_expout_size): Don't declare.
13140         * parse.c (increase_expout_size): Now static.
13141
13142 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13143
13144         * gnu-nat.c (gnu_nat_target::wait): Fix
13145         target_waitstatus_to_string call.
13146
13147 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13148
13149         * eval.c (evaluate_subexp_standard): Handle internal functions
13150         during Fortran function call handling.
13151
13152 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13153
13154         * NEWS: Mention new internal functions.
13155         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13156         (read_base_type): Use dwarf2_init_complex_target_type.
13157         * value.c (creal_internal_fn): New function.
13158         (cimag_internal_fn): New function.
13159         (_initialize_values): Register new internal functions.
13160
13161 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13162
13163         * infrun.c (stop_all_threads): If debug_infrun, always
13164         trace the wait status after wait_one, using
13165         target_waitstatus_to_string and target_pid_to_str.
13166         (handle_inferior_event): Replace various trace of
13167         wait status kind by a single trace.
13168         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13169         wait status kind image by target_waitstatus_to_string.
13170         * target/waitstatus.c (target_waitstatus_to_string): Fix
13171         obsolete comment.
13172
13173 2019-04-01  Tom Tromey  <tromey@adacore.com>
13174
13175         PR symtab/23331:
13176         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13177
13178 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13179             Pedro Alves  <palves@redhat.com>
13180
13181         * top.c (quit_force): Call 'finalize_values'.
13182         * value.c (finalize_values): New function.
13183         * value.h (finalize_values): Declare.
13184
13185 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13186
13187         * NEWS: Announce $_gdb_major and $_gdb_minor.
13188
13189         * top.c (init_gdb_version_vars): New function.
13190         (gdb_init): Call init_gdb_version_vars.
13191
13192 2019-03-29  Tom Tromey  <tromey@adacore.com>
13193
13194         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13195         help text.  Remove dead code.
13196
13197 2019-03-29  Keith Seitz  <keiths@redhat.com>
13198
13199         From Siddhesh Poyarekar:
13200         * f-lang.h (f77_get_upperbound): Return LONGEST.
13201         (f77_get_lowerbound): Likewise.
13202         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13203         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13204         print them.
13205         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13206         plongest to format print it.
13207         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13208         (f77_get_upperbound): Likewise.
13209         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13210         LOWER_BOUND to LONGEST.
13211         (f77_create_arrayprint_offset_tbl): Likewise.
13212
13213 2019-03-29  Keith Seitz  <keiths@redhat.com>
13214
13215         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13216         %s/pulongest for TYPE_LENGTH instead of %d in format
13217         strings.
13218         * ada-typerint.c (ada_print_type): Likewise.
13219         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13220         * compile/compile-c-support.c (generate_register_struct): Likewise.
13221         * gdbtypes.c (recursive_dump_type): Likewise.
13222         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13223         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13224         instead of %d in format strings.
13225         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13226         to std::min to ULONGEST.
13227         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13228         instead of %d in format strings.
13229         * tracepoint.c (info_scope_command): Likewise.
13230         * typeprint.c (print_offset_data::update)
13231         (print_offset_data::finish): Likewise.
13232         * xtensa-tdep.c (xtensa_store_return_value)
13233         (xtensa_push_dummy_call): Likewise.
13234
13235 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13236
13237         * windows-nat.c (display_selector): Fixed format specifications
13238         for 64-bit Cygwin.
13239
13240 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13241
13242         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13243
13244 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13245
13246         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13247         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13248         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13249         (nios2_linux_init_abi): Install it.
13250
13251 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13252
13253         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13254
13255 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13256
13257         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13258
13259 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13260             Tom Tromey  <tromey@adacore.com>
13261
13262         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13263
13264 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13265
13266         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13267         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13268         method to compute the bounds of range types. Also print "[evaluated]"
13269         if the bounds' values come from a dynamic evaluation.
13270
13271 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13272
13273         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13274         whitespace when pretty printing is on.
13275
13276 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13277
13278         * ppc-linux-nat.c: Add include.
13279
13280 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13281
13282         * NEWS: Mention AArch64 Pointer Authentication.
13283
13284 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13285
13286         * arm-linux-nat.c: Add include.
13287
13288 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13289
13290         * source-cache.c (source_cache::get_source_lines): Re-read
13291         fullname after calling open_source_file.
13292
13293 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13294
13295         * NEWS: Mention TLS support for FreeBSD.
13296
13297 2019-03-25  Tom Tromey  <tromey@adacore.com>
13298
13299         * minsyms.c (BUNCH_SIZE): Update comment.
13300         (~minimal_symbol_reader): Remove old comment.
13301         (compact_minimal_symbols): Update comment.
13302         (minimal_symbol_reader::install): Remove old comment.  Update
13303         other comments.
13304
13305 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13306
13307         * s390-linux-nat.c: Add include.
13308
13309 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13310
13311         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13312         Call linux_get_hwcap.
13313         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13314         Likewise.
13315         (aarch64_linux_get_hwcap): Remove function.
13316         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13317         declaration.
13318         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13319         linux_get_hwcap.
13320         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13321         * linux-tdep.c (linux_get_hwcap): Add function.
13322         (linux_get_hwcap2): Likewise.
13323         * linux-tdep.h (linux_get_hwcap): Add declaration.
13324         (linux_get_hwcap2): Likewise.
13325         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13326         (ppc_linux_get_hwcap2): Likewise.
13327         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13328         linux_get_hwcap.
13329         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13330         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13331         (ppc_linux_nat_target::read_description): Likewise.
13332         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13333         * s390-linux-nat.c: Likewise.
13334         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13335
13336 2019-03-24  Tom Tromey  <tom@tromey.com>
13337
13338         * ada-lang.c (standard_lookup): Simplify initialization.
13339         (ada_lookup_symbol_nonlocal): Simplify return.
13340         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13341         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13342         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13343         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13344         initialization.
13345         * solib.c (solib_global_lookup): Simplify.
13346         * symtab.c (null_block_symbol): Remove.
13347         (symbol_cache_lookup): Simplify returns.
13348         (lookup_language_this): Simplify returns.
13349         (lookup_symbol_aux): Simplify return.
13350         (lookup_local_symbol): Simplify returns.
13351         (lookup_global_symbol_from_objfile): Simplify return.
13352         (lookup_symbol_in_objfile_symtabs)
13353         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13354         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13355         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13356         * cp-namespace.c (cp_lookup_bare_symbol)
13357         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13358         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13359         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13360         (cp_lookup_symbol_via_imports): Simplify initialization.
13361         (find_symbol_in_baseclass): Likewise.
13362         * symtab.h (null_block_symbol): Remove.
13363         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13364         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13365         (d_lookup_symbol_module): Likewise.
13366         (find_symbol_in_baseclass): Simplify initialization.
13367
13368 2019-03-24  Tom Tromey  <tom@tromey.com>
13369
13370         * expression.h: Don't include symtab.h.
13371         (struct block): Forward declare.
13372
13373 2019-03-24  Tom Tromey  <tom@tromey.com>
13374
13375         * c-exp.y (typebase): Remove casts.
13376         * gdbtypes.c (lookup_unsigned_typename, )
13377         (lookup_signed_typename): Remove cast.
13378         * eval.c (parse_to_comma_and_eval): Remove cast.
13379         * parse.c (write_dollar_variable): Remove cast.
13380         * block.h (struct block) <superblock>: Now const.
13381         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13382         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13383         (map_block): Make "block" const.
13384         * symfile.h (struct quick_symbol_functions)
13385         <map_matching_symbols>: Constify block argument to "callback".
13386         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13387         const.
13388         (find_pc_sect_compunit_symtab): Make "b" const.
13389         (find_symbol_at_address): Likewise.
13390         (search_symbols): Likewise.
13391         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13392         (dw2_debug_names_lookup_symbol): Likewise.
13393         (dw2_map_matching_symbols): Update.
13394         * p-valprint.c (pascal_val_print): Remove "block".
13395         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13396         (aux_add_nonlocal_symbols): Make "block" const.
13397         (resolve_subexp): Remove cast.
13398         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13399         const.
13400         (iterate_over_file_blocks): Likewise.
13401         * f-exp.y (%union) <bval>: Remove.
13402         * coffread.c (patch_opaque_types): Make "b" const.
13403         * spu-tdep.c (spu_catch_start): Make "block" const.
13404         * c-valprint.c (print_unpacked_pointer): Remove "block".
13405         * symmisc.c (dump_symtab_1): Make "b" const.
13406         (block_depth): Make "block" const.
13407         * d-exp.y (%union) <bval>: Remove.
13408         * cp-support.h (cp_lookup_rtti_type): Update.
13409         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13410         * psymtab.c (psym_lookup_symbol): Make "block" const.
13411         (maintenance_check_psymtabs): Make "b" const.
13412         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13413         (enumerate_locals, enumerate_args): Update.
13414         * python/py-symtab.c (stpy_global_block): Make "block" const.
13415         (stpy_static_block): Likewise.
13416         * inline-frame.c (block_starting_point_at): Make "new_block"
13417         const.
13418         * block.c (find_block_in_blockvector): Make return type const.
13419         (blockvector_for_pc_sect): Make "b" const.
13420         (find_block_in_blockvector): Make "b" const.
13421
13422 2019-03-23  Tom Tromey  <tom@tromey.com>
13423
13424         * varobj.c (varobj_create): Update.
13425         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13426         * printcmd.c (display_command, do_one_display): Don't reset
13427         innermost_block.
13428         * parser-defs.h (enum innermost_block_tracker_type): Move to
13429         expression.h.
13430         (innermost_block): Update comment.
13431         * parse.c (parse_exp_1): Add tracker_types parameter.
13432         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13433         tracker_types parameter.  Reset innermost_block.
13434         (parse_exp_in_context): Remove.
13435         (parse_expression_for_completion): Update.
13436         * objfiles.c (~objfile): Don't reset expression_context_block or
13437         innermost_block.
13438         * expression.h (enum innermost_block_tracker_type): Move from
13439         parser-defs.h.
13440         (parse_exp_1): Add tracker_types parameter.
13441         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13442         reset innermost_block.
13443
13444 2019-03-23  Tom Tromey  <tom@tromey.com>
13445
13446         * objfiles.h: Include bcache.h.
13447
13448 2019-03-23  Tom Tromey  <tom@tromey.com>
13449
13450         * linespec.c (get_current_search_block): Use
13451         scoped_restore_current_language.
13452         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13453
13454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13455             Jiong Wang  <jiong.wang@arm.com>
13456
13457         * aarch64-linux-tdep.c
13458         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13459         section.
13460         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13461
13462 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13463             Jiong Wang  <jiong.wang@arm.com>
13464
13465         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13466         instructions.
13467         (aarch64_analyze_prologue_test): Add PACIASP test.
13468         (aarch64_prologue_prev_register): Unmask PC value.
13469
13470 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13471             Jiong Wang  <jiong.wang@arm.com>
13472
13473         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13474         (aarch64_dwarf2_prev_register): Unmask PC value.
13475         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13476         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13477         DW_CFA_AARCH64_negate_ra_state.
13478         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13479
13480 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13481             Jiong Wang  <jiong.wang@arm.com>
13482
13483         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13484         registers.
13485         (aarch64_pseudo_register_name): Likewise.
13486         (aarch64_pseudo_register_type): Likewise.
13487         (aarch64_pseudo_register_reggroup_p): Likewise.
13488         (aarch64_gdbarch_init): Add pauth registers.
13489         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13490         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13491         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13492         (struct gdbarch_tdep): Add regnum for ra_state.
13493
13494 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13495             Jiong Wang  <jiong.wang@arm.com>
13496
13497         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13498
13499 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13500             Jiong Wang  <jiong.wang@arm.com>
13501
13502         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13503         function.
13504         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13505         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13506         (aarch64_gdbarch_init): Add puth registers.
13507         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13508         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13509         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13510
13511 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13512             Jiong Wang  <jiong.wang@arm.com>
13513
13514         * aarch64-linux-nat.c
13515         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13516         * aarch64-linux-tdep.c
13517         (aarch64_linux_core_read_description): Likewise.
13518         (aarch64_linux_get_hwcap): New function.
13519         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13520         (aarch64_linux_get_hwcap): New declaration.
13521
13522 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13523             Jiong Wang  <jiong.wang@arm.com>
13524
13525         * aarch64-linux-nat.c
13526         (aarch64_linux_nat_target::read_description): Add pauth param.
13527         * aarch64-linux-tdep.c
13528         (aarch64_linux_core_read_description): Likewise.
13529         * aarch64-tdep.c (struct target_desc): Add in pauth.
13530         (aarch64_read_description): Add pauth param.
13531         (aarch64_gdbarch_init): Likewise.
13532         * aarch64-tdep.h (aarch64_read_description): Likewise.
13533         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13534         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13535         * features/Makefile: Add new files.
13536         * features/aarch64-pauth.c: New file.
13537         * features/aarch64-pauth.xml: New file.
13538
13539 2019-03-20  Tom Tromey  <tromey@adacore.com>
13540
13541         * infrun.c (handle_inferior_event): Rename from
13542         handle_inferior_event_1.  Create a scoped_value_mark.
13543         (handle_inferior_event): Remove.
13544
13545 2019-03-19  Tom Tromey  <tromey@adacore.com>
13546
13547         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13548         * infrun.h (print_stop_event): Add "displays" parameter.
13549         * infrun.c (print_stop_event): Add "displays" parameter.
13550
13551 2019-03-19  Pedro Alves  <palves@redhat.com>
13552
13553         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13554         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13555         to -1.  Fix TABs vs spaces.
13556         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13557         * tui/tui-out.h (tui_ui_out) Add intro comments.
13558         <m_line, m_start_of_line>: In-class initialize, and add describing
13559         comment.
13560
13561 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13562
13563         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13564         variable names.
13565         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13566
13567 2019-03-18  Pedro Alves  <palves@redhat.com>
13568             Eli Zaretskii <eliz@gnu.org>
13569
13570         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13571         m_line and m_start_of_line.
13572
13573 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13574
13575         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13576         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13577         it returns a newline.  This fixes a regression in TU mode, whereby
13578         the next line is output on the same screen line as the user input.
13579
13580 2019-03-18  Tom Tromey  <tromey@adacore.com>
13581
13582         * minsyms.c (minimal_symbol_reader::install): Remove call to
13583         obstack_blank.
13584
13585 2019-03-18  Pedro Alves  <palves@redhat.com>
13586
13587         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13588         New globals.
13589         (apply_style): New, factored out from ...
13590         (apply_ansi_escape): ... this.  Handle reverse video mode.
13591         (tui_set_reverse_mode): New function.
13592         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13593         * tui/tui-winsource.c (tui_show_source_line): Use
13594         tui_set_reverse_mode instead of setting A_STANDOUT.
13595         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13596         New setter methods.
13597
13598 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13599
13600         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13601         Handle tabs.
13602
13603 2019-03-18  Tom Tromey  <tromey@adacore.com>
13604
13605         * ada-lang.c (empty_array): Add "high" parameter.
13606         (ada_evaluate_subexp): Update.
13607
13608 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13609
13610         * unittests/string_view-selftests.c: Define
13611         _initialize_string_view_selftests unconditionally.
13612
13613 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13614
13615         PR gdb/24350
13616         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13617
13618 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13619
13620         PR gdb/24351
13621         * windows-nat.c (display_selector): Fix format specifiers.
13622
13623 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13624
13625         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13626         tui_refill_source_window instead of tui_refresh_win, to update the
13627         current execution line.  This fixes redisplay of the current line
13628         when stepping through the code with "next" or "step".
13629
13630 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13631
13632         * source-cache.c (source_cache::get_source_lines): Call
13633         find_source_lines to initialize s->nlines.  This fixes vertical
13634         scrolling of TUI source window when the DOWN arrow is pressed.
13635
13636 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13637
13638         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13639         linux-thread-db.c (_initialize_thread_db): Likewise.
13640
13641 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13642
13643         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13644         wclrtoeol in tui_show_source_line".  This reverts changes made in
13645         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13646
13647 2019-03-15  Tom Tromey  <tom@tromey.com>
13648
13649         * symtab.h (struct minimal_symbol): Derive from
13650         general_symbol_info.
13651         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13652         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13653         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13654         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13655         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13656         (MSYMBOL_SEARCH_NAME): Update.
13657         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13658         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13659         * minsyms.c (minimal_symbol_reader::record_full): Update.
13660
13661 2019-03-15  Tom Tromey  <tom@tromey.com>
13662
13663         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13664
13665 2019-03-15  Tom Tromey  <tom@tromey.com>
13666
13667         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13668         unique_xmalloc_ptr.
13669         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13670         Update.
13671         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13672         (build_minimal_symbol_hash_tables)
13673         (minimal_symbol_reader::install): Update.
13674
13675 2019-03-15  Tom Tromey  <tom@tromey.com>
13676
13677         * symtab.c (create_demangled_names_hash): Update.
13678         (symbol_set_names): Update.
13679         * objfiles.h (struct objfile_per_bfd_storage)
13680         <demangled_names_hash>: Now an htab_up.
13681         * objfiles.c (objfile_per_bfd_storage): Simplify.
13682
13683 2019-03-15  Tom Tromey  <tom@tromey.com>
13684
13685         * objfiles.h (struct objfile_per_bfd_storage): Declare
13686         destructor.
13687         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13688         New.
13689         (get_objfile_bfd_data): Use new.  Don't initialize
13690         language_of_main.
13691         (free_objfile_per_bfd_storage): Remove.
13692         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13693
13694 2019-03-15  Tom Tromey  <tom@tromey.com>
13695
13696         * symfile.c (reread_symbols): Update.
13697         * objfiles.c (objfile::objfile): Update.
13698         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13699         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13700         comment.
13701         (minimal_symbol_reader::install): Update.
13702         (terminate_minimal_symbol_table): Remove.
13703         * jit.c (jit_object_close_impl): Update.
13704
13705 2019-03-15  Tom Tromey  <tom@tromey.com>
13706
13707         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13708         initializations.
13709
13710 2019-03-15  Tom Tromey  <tom@tromey.com>
13711
13712         * objfiles.h (struct objfile_per_bfd_storage)
13713         <demangled_hash_languages>: Now a bitset.
13714         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13715         (lookup_minimal_symbol): Update.
13716
13717 2019-03-15  Tom Tromey  <tom@tromey.com>
13718
13719         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13720         Don't return the symbol.
13721         * coffread.c (record_minimal_symbol): Use record_full.
13722
13723 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13724
13725         The MS-Windows port of ncurses fails to switch to a color pair if
13726         one or both of the colors are the implicit default colors.  This
13727         change records the default colors when TUI is initialized, and
13728         then specifies them explicitly when a color pair uses the default
13729         colors.  This allows color styling in TUI mode on MS-Windows.
13730
13731         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13732         ncurses_norm_attr.
13733         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13734         colors in ncurses_norm_attr.
13735         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13736         "none", replace it with the default color recorded in
13737         ncurses_norm_attr.
13738
13739 2019-03-14  Tom Tromey  <tromey@adacore.com>
13740
13741         * source-cache.h (class source_cache) <get_source_lines>: Return
13742         std::string.
13743         * source-cache.c (source_cache::extract_lines): Handle case where
13744         first_pos==npos.  Return std::string.
13745         (source_cache::get_source_lines): Update.
13746
13747 2019-03-14  Tom Tromey  <tromey@adacore.com>
13748
13749         * NEWS: Add item for "style sources" commands.
13750         * source-cache.c (source_cache::get_source_lines): Check
13751         source_styling.
13752         * cli/cli-style.c (source_styling): New global.
13753         (_initialize_cli_style): Add "style sources" commands.
13754         (show_style_sources): New function.
13755         * cli/cli-style.h (source_styling): Declare.
13756
13757 2019-03-14  Pedro Alves  <palves@redhat.com>
13758             Tom Tromey  <tromey@adacore.com>
13759
13760         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13761         * tui/tui-winsource.c (tui_refill_source_window): New function,
13762         from...
13763         (tui_horizontal_source_scroll): ... here.  Move some logic.
13764         * cli/cli-style.c (set_style_enabled): Notify new observable.
13765         * tui/tui-hooks.c (tui_redisplay_source): New function.
13766         (tui_attach_detach_observers): Attach or detach
13767         tui_redisplay_source.
13768         * observable.h (source_styling_changed): New observable.
13769         * observable.c: Define source_styling_changed observable.
13770
13771 2019-03-13  Tom Tromey  <tromey@adacore.com>
13772
13773         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13774         (i386_gnu_nat_target::store_registers): Update.
13775         * target-debug.h (target_debug_print_std_string): New macro.
13776         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13777         * windows-tdep.c (display_one_tib): Update.
13778         * tui/tui-stack.c (tui_make_status_line): Update.
13779         * top.c (print_inferior_quit_action): Update.
13780         * thread.c (thr_try_catch_cmd): Update.
13781         (add_thread_with_info): Update.
13782         (thread_target_id_str): Update.
13783         (thr_try_catch_cmd): Update.
13784         (thread_command): Update.
13785         (thread_find_command): Update.
13786         * record-btrace.c (record_btrace_target::info_record)
13787         (record_btrace_resume_thread, record_btrace_target::resume)
13788         (record_btrace_cancel_resume, record_btrace_step_thread)
13789         (record_btrace_target::wait, record_btrace_target::wait)
13790         (record_btrace_target::wait, record_btrace_target::stop): Update.
13791         * progspace.c (print_program_space): Update.
13792         * process-stratum-target.c
13793         (process_stratum_target::thread_address_space): Update.
13794         * linux-fork.c (linux_fork_mourn_inferior)
13795         (detach_checkpoint_command, info_checkpoints_command)
13796         (linux_fork_context): Update.
13797         (linux_fork_detach): Update.
13798         (class scoped_switch_fork_info): Update.
13799         (delete_checkpoint_command): Update.
13800         * infrun.c (follow_fork_inferior): Update.
13801         (follow_fork_inferior): Update.
13802         (proceed_after_vfork_done): Update.
13803         (handle_vfork_child_exec_or_exit): Update.
13804         (follow_exec): Update.
13805         (displaced_step_prepare_throw): Update.
13806         (displaced_step_restore): Update.
13807         (start_step_over): Update.
13808         (resume_1): Update.
13809         (clear_proceed_status_thread): Update.
13810         (proceed): Update.
13811         (print_target_wait_results): Update.
13812         (do_target_wait): Update.
13813         (context_switch): Update.
13814         (stop_all_threads): Update.
13815         (restart_threads): Update.
13816         (finish_step_over): Update.
13817         (handle_signal_stop): Update.
13818         (switch_back_to_stepped_thread): Update.
13819         (keep_going_pass_signal): Update.
13820         (print_exited_reason): Update.
13821         (normal_stop): Update.
13822         * inferior.c (inferior_pid_to_str): Change return type.
13823         (print_selected_inferior): Update.
13824         (add_inferior): Update.
13825         (detach_inferior): Update.
13826         * dummy-frame.c (fprint_dummy_frames): Update.
13827         * dcache.c (dcache_info_1): Update.
13828         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13829         (btrace_fetch, btrace_clear): Update.
13830         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13831         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13832         type.
13833         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13834         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13835         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13836         * gdbarch.c, gdbarch.h: Rebuild.
13837         * gdbarch.sh (core_pid_to_str): Change return type.
13838         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13839         return type.
13840         (windows_nat_target::pid_to_str): Change return type.
13841         (windows_delete_thread): Update.
13842         (windows_nat_target::attach): Update.
13843         (windows_nat_target::files_info): Update.
13844         * target-delegates.c: Rebuild.
13845         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13846         return type.
13847         (sol_thread_target::pid_to_str): Change return type.
13848         * remote.c (class remote_target) <pid_to_str>: Change return
13849         type.
13850         (remote_target::pid_to_str): Change return type.
13851         (extended_remote_target::attach, remote_target::remote_stop_ns)
13852         (remote_target::remote_notif_remove_queued_reply)
13853         (remote_target::push_stop_reply, remote_target::disable_btrace):
13854         Update.
13855         (extended_remote_target::attach): Update.
13856         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13857         type.
13858         (gdbsim_target::pid_to_str): Change return type.
13859         * ravenscar-thread.c (struct ravenscar_thread_target)
13860         <pid_to_str>: Change return type.
13861         (ravenscar_thread_target::pid_to_str): Change return type.
13862         * procfs.c (class procfs_target) <pid_to_str>: Change return
13863         type.
13864         (procfs_target::pid_to_str): Change return type.
13865         (procfs_target::attach): Update.
13866         (procfs_target::detach): Update.
13867         (procfs_target::fetch_registers): Update.
13868         (procfs_target::store_registers): Update.
13869         (procfs_target::wait): Update.
13870         (procfs_target::files_info): Update.
13871         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13872         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13873         return type.
13874         (nto_procfs_target::pid_to_str): Change return type.
13875         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13876         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13877         return type.
13878         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13879         (exit_lwp): Update.
13880         (attach_proc_task_lwp_callback, get_detach_signal)
13881         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13882         (linux_nat_target::resume, wait_lwp, stop_callback)
13883         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13884         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13885         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13886         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13887         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13888         type.
13889         (inf_ptrace_target::attach): Update.
13890         (inf_ptrace_target::files_info): Update.
13891         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13892         type.
13893         (go32_nat_target::pid_to_str): Change return type.
13894         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13895         (gnu_nat_target::wait): Update.
13896         (gnu_nat_target::wait): Update.
13897         (gnu_nat_target::resume): Update.
13898         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13899         (fbsd_nat_target::wait): Update.
13900         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13901         type.
13902         (darwin_nat_target::attach): Update.
13903         * corelow.c (class core_target) <pid_to_str>: Change return type.
13904         (core_target::pid_to_str): Change return type.
13905         * target.c (normal_pid_to_str): Change return type.
13906         (default_pid_to_str): Likewise.
13907         (target_pid_to_str): Change return type.
13908         (target_translate_tls_address): Update.
13909         (target_announce_detach): Update.
13910         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13911         return type.
13912         (bsd_uthread_target::pid_to_str): Change return type.
13913         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13914         type.
13915         (bsd_kvm_target::pid_to_str): Change return type.
13916         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13917         return type.
13918         (aix_thread_target::pid_to_str): Change return type.
13919         * target.h (struct target_ops) <pid_to_str>: Change return type.
13920         (target_pid_to_str, normal_pid_to_str): Likewise.
13921         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13922         type.
13923         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13924         type.
13925         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13926         return type.
13927         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13928         type.
13929         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13930         type.
13931         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13932         return type.
13933
13934 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13935
13936         * NEWS: Mention that the new default MI version is 3.  Mention
13937         changes to the output of commands and events that deal with
13938         multi-location breakpoints.
13939         * breakpoint.c: Include "mi/mi-out.h".
13940         (print_one_breakpoint): Change output syntax if using MI version
13941         >= 3.
13942         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13943         New.
13944         (mi_multi_location_breakpoint_output_fixed): New.
13945         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13946         (mi_cmd_fix_multi_location_breakpoint_output): New.
13947         (mi_multi_location_breakpoint_output_fixed): New.
13948         * mi/mi-cmds.c (mi_cmds): Register command
13949         -fix-multi-location-breakpoint-output.
13950         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13951         interpreter "mi".
13952
13953 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13954
13955         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13956         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13957         instantiate mi_ui_out based on interpreter name.
13958         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13959         * mi/mi-main.c (mi_load_progress): Likewise.
13960
13961 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13962
13963         * NEWS: Combine separate "New targets" sections for 8.3.
13964
13965 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13966
13967         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13968         (ppcfbsd_init_abi): Install gdbarch
13969         "fetch_tls_load_module_address" and "get_thread_local_address"
13970         methods.
13971
13972 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13973
13974         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13975         (riscv_fbsd_init_abi): Install gdbarch
13976         "fetch_tls_load_module_address" and "get_thread_local_address"
13977         methods.
13978
13979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13980
13981         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13982         (i386fbsd_init_abi): Install gdbarch
13983         "fetch_tls_load_module_address" and "get_thread_local_address"
13984         methods.
13985
13986 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13987
13988         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13989         (amd64fbsd_init_abi): Install gdbarch
13990         "fetch_tls_load_module_address" and "get_thread_local_address"
13991         methods.
13992
13993 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13994
13995         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13996         (struct fbsd_pspace_data): New type.
13997         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13998         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13999         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14000         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14001         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14002
14003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14004
14005         * gdbtypes.c (lookup_struct_elt): New function.
14006         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14007         * gdbtypes.h (struct struct_elt): New type.
14008         (lookup_struct_elt): New prototype.
14009
14010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14011
14012         * gdbtypes.c (lookup_struct_elt_type): Update comment and
14013         remove disabled code block.
14014
14015 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14016
14017         * gdbarch.sh (get_thread_local_address): New method.
14018         * gdbarch.h, gdbarch.c: Regenerate.
14019         * target.c (target_translate_tls_address): Use
14020         gdbarch_get_thread_local_address if present instead of
14021         target::get_thread_local_address.
14022
14023 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14024
14025         * target.h (target::get_thread_local_address): Update comment.
14026
14027 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14028
14029         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14030         objfile->separate_debug_objfile_backlink if not NULL.
14031
14032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14033
14034         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14035         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14036         (amd64bsd_store_inferior_registers): Likewise.
14037         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14038         Enable segment base registers.
14039         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14040         PT_GETFSBASE and PT_GETGSBASE.
14041         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14042         PT_SETGSBASE.
14043         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14044         segment base registers.
14045         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14046
14047 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
14048
14049         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14050         Update calls to i386_target_description to add 'segments'
14051         parameter.
14052         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
14053         add segment base registers.
14054         * arch/i386.c (i386_create_target_description): Add 'segments'
14055         parameter to enable segment base registers.
14056         * arch/i386.h (i386_create_target_description): Likewise.
14057         * features/i386/32bit-segments.xml: New file.
14058         * features/i386/32bit-segments.c: Generate.
14059         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14060         call to i386_target_description to add 'segments' parameter.
14061         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14062         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14063         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14064         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14065         if feature is present.
14066         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14067         Add 'segments' parameter to call to i386_target_description.
14068         (i386_target_description): Add 'segments' parameter to enable
14069         segment base registers.
14070         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14071         to call to i386_target_description.
14072         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14073         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14074         Define I386_NUM_REGS.
14075         (i386_target_description): Add 'segments' parameter to enable
14076         segment base registers.
14077
14078 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
14079
14080         PR/24325
14081         * source-cache.c: #undef open and close, to avoid unresolved
14082         externals during linking.
14083
14084 2019-03-12  Tom Tromey  <tromey@adacore.com>
14085
14086         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14087         const.  Add initializers.
14088         (_initialize_remote): Don't initialize ptid globals.
14089
14090 2019-03-12  Pedro Alves  <palves@redhat.com>
14091
14092         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14093
14094 2019-03-12  Pedro Alves  <palves@redhat.com>
14095
14096         * cp-name-parser.y (main): Remove unused 'len' variable.
14097
14098 2019-03-12  Tom Tromey  <tromey@adacore.com>
14099
14100         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14101         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14102
14103 2019-03-12  Tom Tromey  <tromey@adacore.com>
14104
14105         * linux-nat.c (iterate_over_lwps): Update.
14106         (stop_callback): Remove parameter.
14107         (stop_wait_callback, detach_callback, resume_set_callback)
14108         (select_singlestep_lwp_callback, set_ignore_sigint)
14109         (status_callback, resumed_callback, resume_clear_callback)
14110         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14111         data parameter.
14112         (linux_nat_target::detach, linux_nat_target::resume)
14113         (linux_stop_and_wait_all_lwps, select_event_lwp)
14114         (linux_nat_filter_event, linux_nat_wait_1)
14115         (linux_nat_target::kill, linux_nat_target::stop)
14116         (linux_nat_target::stop): Update.
14117         (linux_nat_resume_callback): Change type.
14118         (resume_stopped_resumed_lwps, count_events_callback)
14119         (select_event_lwp_callback): Likewise.
14120         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14121         * arm-linux-nat.c (struct update_registers_data): Remove.
14122         (update_registers_callback): Change type.
14123         (arm_linux_insert_hw_breakpoint1): Update.
14124         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14125         parameter.
14126         (x86_linux_dr_set_addr): Update.
14127         (x86_linux_dr_set_control): Update.
14128         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14129         (iterate_over_lwps): Use gdb::function_view.
14130         * nat/aarch64-linux-hw-point.c (struct
14131         aarch64_dr_update_callback_param): Remove.
14132         (debug_reg_change_callback): Change type.
14133         (aarch64_notify_debug_reg_change): Update.
14134         * s390-linux-nat.c (s390_refresh_per_info): Update.
14135
14136 2019-03-11  Tom Tromey  <tromey@adacore.com>
14137
14138         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14139         redundant assignment to "this_cu".
14140
14141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14142
14143         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14144
14145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14146
14147         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14148         from...
14149         (rank_one_type): ... this.
14150
14151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14152
14153         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14154         from...
14155         (rank_one_type): ... this.
14156
14157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14158
14159         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14160         from...
14161         (rank_one_type): ... this.
14162
14163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14164
14165         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14166         from...
14167         (rank_one_type): ... this.
14168
14169 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14170
14171         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14172         from...
14173         (rank_one_type): ... this.
14174
14175 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14176
14177         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14178         from...
14179         (rank_one_type): ... this.
14180
14181 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14182
14183         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14184         from...
14185         (rank_one_type): ... this.
14186
14187 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14188
14189         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14190         from...
14191         (rank_one_type): ... this.
14192
14193 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14194
14195         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14196         from...
14197         (rank_one_type): ... this.
14198
14199 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14200
14201         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14202         from...
14203         (rank_one_type): ... this.
14204
14205 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14206
14207         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14208         from...
14209         (rank_one_type): ... this.
14210
14211 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14212
14213         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14214         from...
14215         (rank_one_type): ... this.
14216
14217 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14218
14219         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14220         inferior-events' shows the example events.
14221
14222 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14223
14224         Support styling on native MS-Windows console
14225
14226         PR/24315
14227         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14228         on MS-Windows if $TERM is not defined.
14229
14230         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14231
14232         * posix-hdep.c (gdb_console_fputs):
14233         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14234         functions.
14235         * ui-file.h (gdb_console_fputs): Add prototype.
14236
14237         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14238         back to fputs only if the former returns zero.
14239
14240 2019-03-07  Tom Tromey  <tom@tromey.com>
14241
14242         * symmisc.c (print_symbol_bcache_statistics): Update.
14243         (print_objfile_statistics): Update.
14244         * symfile.c (allocate_symtab): Update.
14245         * stabsread.c: Don't include bcache.h.
14246         * psymtab.h (struct psymbol_bcache): Don't declare.
14247         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14248         (psymbol_bcache_init, psymbol_bcache_free)
14249         (psymbol_bcache_get_bcache): Don't declare.
14250         * psymtab.c (struct psymbol_bcache): Remove.
14251         (psymtab_storage::psymtab_storage): Update.
14252         (psymtab_storage::~psymtab_storage): Update.
14253         (psymbol_bcache_init, psymbol_bcache_free)
14254         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14255         (add_psymbol_to_bcache): Update.
14256         (allocate_psymtab): Update.
14257         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14258         macro_cache>: No longer pointers.
14259         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14260         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14261         * macrotab.c (macro_bcache): Update.
14262         * macroexp.c: Don't include bcache.h.
14263         * gdbtypes.c (check_types_worklist): Update.
14264         (types_deeply_equal): Remove TRY/CATCH.  Update.
14265         * elfread.c (elf_symtab_read): Update.
14266         * dwarf2read.c: Don't include bcache.h.
14267         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14268         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14269         (print_bcache_statistics, bcache_memory_used): Don't declare.
14270         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14271         methods.  Rename all data members.
14272         * bcache.c (struct bcache): Move to bcache.h.
14273         (bcache::expand_hash_table): Rename from expand_hash_table.
14274         (bcache): Remove.
14275         (bcache::insert): Rename from bcache_full.
14276         (bcache::compare): Rename from bcache_compare.
14277         (bcache_xmalloc): Remove.
14278         (bcache::~bcache): Rename from bcache_xfree.
14279         (bcache::print_statistics): Rename from print_bcache_statistics.
14280         (bcache::memory_used): Rename from bcache_memory_used.
14281
14282 2019-03-07  Pedro Alves  <palves@redhat.com>
14283
14284         * infrun.c (normal_stop): Also check for
14285         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14286
14287 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14288
14289         * f-lang.c (value_from_host_double): Moved to...
14290         * value.c (value_from_host_double): ...here.
14291         * value.h (value_from_host_double): Declare.
14292         * guile/scm-math.c (vlscm_convert_typed_number): Use
14293         value_from_host_double.
14294         (vlscm_convert_number): Likewise.
14295         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14296         * python/py-value.c (convert_value_from_python): Likewise.
14297
14298 2019-03-06  Tom Tromey  <tom@tromey.com>
14299
14300         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14301
14302 2019-03-06  Tom Tromey  <tom@tromey.com>
14303
14304         * utils.h (free_current_contents): Don't declare.
14305         * utils.c (free_current_contents): Remove.
14306
14307 2019-03-06  Tom Tromey  <tom@tromey.com>
14308
14309         * top.c (quit_force): Update.
14310         * main.c (captured_command_loop): Update.
14311         * common/new-op.c (operator new): Update.
14312         * common/common-exceptions.c (struct catcher)
14313         <save_cleanup_chain>: Remove member.
14314         (exceptions_state_mc_init): Update.
14315         (exception_try_scope_entry): Return nullptr.
14316         (exception_try_scope_exit, exception_rethrow)
14317         (throw_exception_sjlj, throw_exception_cxx): Update.
14318         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14319         (all_cleanups, do_cleanups, discard_cleanups)
14320         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14321         (restore_cleanups, restore_final_cleanups): Don't declare.
14322         (do_final_cleanups): Remove parameter.
14323         * common/cleanups.c (cleanup_chain, make_cleanup)
14324         (make_cleanup_dtor, all_cleanups, do_cleanups)
14325         (discard_my_cleanups, discard_cleanups)
14326         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14327         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14328         (null_cleanup): Remove.
14329         (do_final_cleanups): Remove parameter.
14330
14331 2019-03-06  Tom Tromey  <tom@tromey.com>
14332
14333         * remote.c (remote_target::remote_parse_stop_reply): Use
14334         unique_xmalloc_ptr.
14335
14336 2019-03-06  Tom Tromey  <tom@tromey.com>
14337
14338         * stabsread.c (struct stabs_field_info): Rename from field_info.
14339         <list, fnlist>: Add initializers.
14340         <obstack>: New member.
14341         (read_member_functions, read_struct_fields, read_baseclasses):
14342         Allocate on obstack.  Don't use cleanups.
14343         (read_one_struct_field, read_member_functions, read_struct_fields)
14344         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14345         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14346         (read_struct_type): Update.
14347
14348 2019-03-06  Tom Tromey  <tom@tromey.com>
14349
14350         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14351         * common/filestuff.h (make_cleanup_close): Don't declare.
14352         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14353         Remove.
14354
14355 2019-03-06  Tom Tromey  <tom@tromey.com>
14356
14357         * solib-aix.c: Use make_scope_exit.
14358
14359 2019-03-06  Tom Tromey  <tom@tromey.com>
14360
14361         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14362         Use make_scope_exit.
14363
14364 2019-03-06  Tom Tromey  <tom@tromey.com>
14365
14366         * solib-svr4.c (disable_probes_interface): Remove parameter.
14367         (svr4_handle_solib_event): Use make_scope_exit.
14368
14369 2019-03-06  Tom Tromey  <tom@tromey.com>
14370
14371         * remote.c (struct stop_reply_deleter): Remove.
14372         (stop_reply_up): Update.
14373         (struct stop_reply): Derive from notif_event.  Don't typedef.
14374         <regcache>: Now a std::vector.
14375         (stop_reply_xfree): Remove.
14376         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14377         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14378         (remote_target::discard_pending_stop_replies): Use delete.
14379         (remote_target::remote_parse_stop_reply): Update.
14380         (remote_target::process_stop_reply): Update.
14381         * remote-notif.h (struct notif_event): Add virtual destructor.
14382         Remove "dtr" member.
14383         (struct notif_client) <alloc_event>: Return a unique_ptr.
14384         (notif_event_xfree): Don't declare.
14385         (notif_event_up): New typedef.
14386         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14387         (notif_event_xfree, do_notif_event_xfree): Remove.
14388         (remote_notif_state_xfree): Update.
14389
14390 2019-03-06  Tom Tromey  <tom@tromey.com>
14391
14392         * infrun.c (displaced_step_clear_cleanup): Now a
14393         forward_scope_exit type.
14394         (displaced_step_prepare_throw): Update.
14395         (displaced_step_fixup): Update.
14396
14397 2019-03-06  Tom Tromey  <tom@tromey.com>
14398
14399         * inferior.h (class inferior): Update comment.
14400         * gdbthread.h (class thread_info): Update comment.
14401
14402 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14403             Tom Tromey  <tom@tromey.com>
14404
14405         * stabsread.h (struct stab_section_list): Remove.
14406         (coffstab_build_psymtabs): Update.
14407         * dbxread.c (symbuf_sections): Now a std::vector.
14408         (sect_idx): New global.
14409         (fill_symbuf): Update.
14410         (coffstab_build_psymtabs): Change type of stabsects parameter.
14411         Update.
14412         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14413         std::vector.
14414         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14415         (coff_locate_sections): Update.
14416         (coff_symfile_read): Remove cleanups.  Update.
14417         (init_stringtab): Add storage parameter.
14418         (free_stringtab, free_stringtab_cleanup): Remove.
14419         (init_lineno): Add storage parameter.
14420         (free_linetab, free_linetab_cleanup): Remove.
14421
14422 2019-03-06  Pedro Alves  <palves@redhat.com>
14423
14424         * linux-fork.c (fork_info::clobber_regs): Delete.
14425         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14426         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14427         comment.  Adjust.
14428         (scoped_switch_fork_info::scoped_switch_fork_info)
14429         (checkpoint_command, linux_fork_context): Adjust
14430         fork_save_infrun_state calls.
14431
14432 2019-03-06  Pedro Alves  <palves@redhat.com>
14433
14434         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14435         (inf_has_multiple_threads): Return 'bool' and rewrite using
14436         inferior_info::threads().
14437
14438 2019-03-06  Pedro Alves  <palves@redhat.com>
14439
14440         * linux-fork.c: Include <list>.
14441         (fork_list): Now a std::list instance.
14442         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14443         (forks_exist_p, find_last_fork): Adjust.
14444         (new_fork): Delete.
14445         (one_fork_p): New.
14446         (add_fork): Adjust.
14447         (free_fork): Delete, folded into fork_info::~fork_info().
14448         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14449         Adjust.
14450         (init_fork_list): Delete.
14451         (linux_fork_killall, linux_fork_mourn_inferior)
14452         (linux_fork_detach, info_checkpoints_command): Adjust.
14453         (_initialize_linux_fork): No longer call init_fork_list.
14454
14455 2019-03-06  Pedro Alves  <palves@redhat.com>
14456
14457         * linux-fork.c (new_fork): New, split out of ...
14458         (add_fork): ... this.  Return void.  Move "first fork" special
14459         case from here, to ...
14460         (checkpoint_command): ... here.
14461         * linux-linux.h (add_fork): Return void.
14462
14463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14464
14465         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14466
14467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14468             Chris January  <chris.january@arm.com>
14469             David Lecomber  <david.lecomber@arm.com>
14470
14471         * f-exp.y: New token, UNOP_INTRINSIC.
14472         (exp): New pattern using UNOP_INTRINSIC token.
14473         (f77_keywords): Add 'abs' keyword.
14474         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14475         (value_from_host_double): New function.
14476         (evaluate_subexp_f): Support UNOP_ABS.
14477
14478 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14479
14480         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14481         types.
14482
14483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14484
14485         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14486         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14487         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14488
14489 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14490
14491         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14492
14493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14494             Chris January  <chris.january@arm.com>
14495
14496         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14497         * f-exp.y: Define 'KIND' token.
14498         (exp): New pattern for KIND expressions.
14499         (ptype): Handle types with a kind extension.
14500         (direct_abs_decl): Extend to spot kind extensions.
14501         (f77_keywords): Add 'kind' to the list.
14502         (push_kind_type): New function.
14503         (convert_to_kind_type): New function.
14504         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14505         * parse.c (operator_length_standard): Likewise.
14506         * parser-defs.h (enum type_pieces): Add tp_kind.
14507         * std-operator.def: Add UNOP_KIND.
14508
14509 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14510
14511         * f-exp.y (f_parse): Set yydebug.
14512
14513 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14514
14515         * f-lang.c (evaluate_subexp_f): New function.
14516         (exp_descriptor_f): New global.
14517         (f_language_defn): Use exp_descriptor_f instead of
14518         exp_descriptor_standard.
14519
14520 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14521
14522         * f-exp.y (struct token): Add comments.
14523         (dot_ops): Remove uppercase versions and the end marker.
14524         (f77_keywords): Likewise.
14525         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14526         entries in the dot_ops array are case insensitive, and use
14527         strncasecmp to compare strings.  Also some whitespace cleanup in
14528         this area.  Similar for the f77_keywords array, except entries in
14529         this list might be case sensitive.
14530
14531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14532
14533         * f-exp.y (struct f77_boolean_val): Add comments.
14534         (boolean_values): Remove uppercase versions, and end marker.
14535         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14536         and use strncasecmp to achieve case insensitivity.  Additionally,
14537         perform whitespace cleanup around this code.
14538
14539 2019-03-06  Tom Tromey  <tromey@adacore.com>
14540
14541         * remote-sim.c (gdbsim_target_open): Use result of
14542         gdb_argv::release.
14543
14544 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14545         Dirk Schubert  <dirk.schubert@arm.com>
14546         Chris January  <chris.january@arm.com>
14547
14548         * eval.c (evaluate_subexp_standard): Call Fortran argument
14549         wrapping logic.
14550         * f-lang.c (struct value): A value which can be passed into a
14551         Fortran function call.
14552         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14553         where appropriate.
14554         (struct type): Value ready for a Fortran function call.
14555         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14556         is needed.
14557         * f-lang.h (fortran_argument_convert): Declaration.
14558         (fortran_preserve_arg_pointer): Declaration.
14559         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14560
14561 2019-03-05  Tom Tromey  <tromey@adacore.com>
14562
14563         * python/py-prettyprint.c (print_string_repr): Remove #if.
14564         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14565
14566 2019-03-05  Tom Tromey  <tromey@adacore.com>
14567
14568         * target.c (the_dummy_target): Move later.  Change type to
14569         "dummy_target".
14570         (initialize_targets): Don't initialize the_dummy_target.
14571
14572 2019-03-05  Tom Tromey  <tromey@adacore.com>
14573
14574         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14575         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14576
14577 2019-03-05  Tom Tromey  <tromey@adacore.com>
14578
14579         * windows-nat.c (windows_nat_target::attach)
14580         (windows_nat_target::detach): Don't call gdb_flush.
14581         * valprint.c (generic_val_print, val_print, val_print_string):
14582         Don't call gdb_flush.
14583         * utils.c (defaulted_query): Don't call gdb_flush.
14584         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14585         * target.c (target_announce_detach): Don't call gdb_flush.
14586         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14587         * remote.c (extended_remote_target::attach): Don't call
14588         gdb_flush.
14589         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14590         * printcmd.c (do_examine): Don't call gdb_flush.
14591         (info_display_command): Don't call gdb_flush.
14592         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14593         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14594         * memattr.c (info_mem_command): Don't call gdb_flush.
14595         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14596         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14597         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14598         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14599         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14600         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14601         (gnu_nat_target::detach): Don't call gdb_flush.
14602         * f-valprint.c (f_val_print): Don't call gdb_flush.
14603         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14604         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14605         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14606         gdb_flush.
14607         * c-valprint.c (c_val_print): Don't call gdb_flush.
14608         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14609
14610 2019-03-05  Tom Tromey  <tromey@adacore.com>
14611
14612         * varobj.c (update_dynamic_varobj_children): Update.
14613         (install_default_visualizer): Use reset, not release.
14614         * value.c (set_internalvar): Update.
14615         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14616         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14617         ATTRIBUTE_UNUSED_RESULT.
14618
14619 2019-03-05  Tom Tromey  <tromey@adacore.com>
14620
14621         * remote.c (class scoped_remote_fd) <release>: Add
14622         ATTRIBUTE_UNUSED_RESULT.
14623
14624 2019-03-05  Tom Tromey  <tromey@adacore.com>
14625
14626         * macroexp.c (struct macro_buffer) <release>: Add
14627         ATTRIBUTE_UNUSED_RESULT.
14628
14629 2019-03-05  Tom Tromey  <tromey@adacore.com>
14630
14631         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14632         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14633         ATTRIBUTE_UNUSED_RESULT.
14634
14635 2019-03-05  Tom Tromey  <tromey@adacore.com>
14636
14637         * common/scoped_fd.h (class scoped_fd) <release>: Add
14638         ATTRIBUTE_UNUSED_RESULT.
14639
14640 2019-03-05  Tom Tromey  <tromey@adacore.com>
14641
14642         * parser-defs.h (struct parser_state) <release>: Add
14643         ATTRIBUTE_UNUSED_RESULT.
14644
14645 2019-03-05  Tom Tromey  <tromey@adacore.com>
14646
14647         * utils.h (class gdb_argv) <release>: Add
14648         ATTRIBUTE_UNUSED_RESULT.
14649         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14650
14651 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14652
14653         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14654         for-loop range, to avoid compiler warnings.
14655
14656         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14657         avoid compiler warnings about unused variables.
14658
14659         * NEWS: Mention end of support for native debugging on MS-Windows
14660         before XP.
14661
14662         PR gdb/24292
14663         * common/netstuff.c:
14664         * gdbserver/gdbreplay.c
14665         * gdbserver/remote-utils.c:
14666         * ser-tcp.c:
14667         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14668         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14669         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14670         'getaddrinfo' and 'freeaddrinfo' were not available before
14671         Windows XP, and mingw.org's MinGW headers by default define
14672         _WIN32_WINNT to 0x500.
14673
14674 2019-03-01  Gary Benson <gbenson@redhat.com>
14675
14676         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14677
14678 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14679             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14680
14681         PR gdb/8527
14682         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14683         set_sigint_trap, clear_sigint_trap.
14684
14685 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14686
14687         * target.c (target_detach): Clear the regcache and the
14688         frame cache.
14689
14690 2019-02-27  Pedro Alves  <palves@redhat.com>
14691
14692         * utils.c (set_screen_size): When we cap the height/width sizes,
14693         tweak the corresponding command variable to show "unlimited":
14694
14695 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14696             Pedro Alves  <palves@redhat.com>
14697
14698         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14699         before calling rl_set_screen_size.
14700
14701 2019-02-27  Tom Tromey  <tromey@adacore.com>
14702
14703         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14704         define.
14705         * python/py-value.c: Remove Python 2.4 workaround.
14706         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14707         workaround.
14708         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14709         Python 2.4 workaround.
14710         * python/python-internal.h: Remove Python 2.4 comment.
14711         (Py_ssize_t): Don't define.
14712         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14713         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14714         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14715         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14716         * python/python.c (do_start_initialization): Remove Python 2.4
14717         workaround.
14718         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14719         (print_children): Remove Python 2.4 workaround.
14720         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14721         workaround.
14722         (CHARBUFFERPROC_NAME): Remove.
14723         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14724         Python 2.4 workaround.
14725
14726 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14727
14728         * NEWS: Note minimum Python version.
14729
14730 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14731
14732         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14733         code from these functions.  Remove corresponding ifdefs.  Use
14734         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14735         Remove gotos and target of gotos.
14736         (infpy_search_memory): Likewise.
14737
14738 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14739
14740         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14741         (hppa_gdbarch_init): Don't register deleted functions with
14742         gdbarch.
14743
14744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14745
14746         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14747         (h8300_unwind_sp): Delete.
14748         (h8300_dummy_id): Delete.
14749         (h8300_gdbarch_init): Don't register deleted functions with
14750         gdbarch.
14751
14752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14753
14754         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14755         (ft32_unwind_pc): Delete.
14756         (ft32_unwind_sp): Delete.
14757         (ft32_gdbarch_init): Don't register deleted functions with
14758         gdbarch.
14759
14760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14761
14762         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14763         (frv_unwind_pc): Delete.
14764         (frv_unwind_sp): Delete.
14765         (frv_gdbarch_init): Don't register deleted functions with
14766         gdbarch.
14767
14768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14769
14770         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14771         (riscv_unwind_pc): Delete.
14772         (riscv_unwind_sp): Delete.
14773         (riscv_gdbarch_init): Don't register deleted functions with
14774         gdbarch.
14775
14776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14777
14778         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14779         (csky_unwind_pc): Delete.
14780         (csky_unwind_sp): Delete.
14781         (csky_gdbarch_init): Don't register deleted functions with
14782         gdbarch.
14783
14784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14785
14786         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14787         (cris_unwind_pc): Delete.
14788         (cris_unwind_sp): Delete.
14789         (cris_gdbarch_init): Don't register deleted functions with
14790         gdbarch.
14791
14792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14793
14794         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14795         (bfin_unwind_pc): Delete.
14796         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14797
14798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14799
14800         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14801         (arm_unwind_pc): Delete.
14802         (arm_unwind_sp): Delete.
14803         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14804
14805 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14806
14807         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14808         (arc_unwind_pc): Delete.
14809         (arc_unwind_sp): Delete.
14810         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14811
14812 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14813
14814         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14815         (alpha_unwind_pc): Delete.
14816         (alpha_gdbarch_init): Don't register deleted functions with
14817         gdbarch.
14818
14819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14820
14821         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14822         (aarch64_unwind_pc): Delete.
14823         (aarch64_unwind_sp): Delete.
14824         (aarch64_gdbarch_init): Don't register deleted functions with
14825         gdbarch.
14826
14827 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14828
14829         * gdbtypes.c (type_align): Don't consider static members when
14830         computing structure alignment.
14831
14832 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14833
14834         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14835         return 0 for other types.
14836         * arch-utils.c (default_type_align): Always return 0.
14837         * gdbarch.h: Regenerate.
14838         * gdbarch.sh (type_align): Extend comment.
14839         * gdbtypes.c (type_align): Add additional comments, always call
14840         gdbarch_type_align before applying the default rules.
14841         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14842         generic code will then apply a suitable default.
14843         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14844         types, return 0 for other types.
14845
14846 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14847
14848         * NEWS: Create a new section for the next release branch.
14849         Rename the section of the current branch, now that it has
14850         been cut.
14851
14852 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14853
14854         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14855         * version.in: Bump version to 8.3.50.DATE-git.
14856
14857 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14858
14859         * aix-thread.c (ptid_cmp): Remove unused variable.
14860         (get_signaled_thread): Likewise.
14861         (store_regs_user_thread): Likewise.
14862         (store_regs_kernel_thread): Likewise.
14863         (fetch_regs_kernel_thread): Remove shadowed variable.
14864
14865 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14866
14867         * features/riscv/32bit-cpu.xml: Add register numbers.
14868         * features/riscv/32bit-fpu.c: Regenerate.
14869         * features/riscv/32bit-fpu.xml: Add register numbers.
14870         * features/riscv/64bit-cpu.xml: Add register numbers.
14871         * features/riscv/64bit-fpu.c: Regenerate.
14872         * features/riscv/64bit-fpu.xml: Add register numbers.
14873
14874 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14875
14876         * NEWS: Mention two argument form of gdb.Value constructor.
14877         * python/py-value.c (convert_buffer_and_type_to_value): New
14878         function.
14879         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14880         Add support for handling an optional second argument.  Call
14881         convert_buffer_and_type_to_value as appropriate.
14882         * python/python-internal.h (Py_buffer_deleter): New struct.
14883         (Py_buffer_up): New typedef.
14884
14885 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14886
14887         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14888         instead of releasing ownership.
14889
14890 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14891
14892         * dwarf2read.c (open_and_init_dwp_file): Call
14893         elf_numsections instead of bfd_count_sections to initialize
14894         dwp_file->num_sections.
14895
14896 2019-02-25  Tom Tromey  <tromey@adacore.com>
14897
14898         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14899
14900 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14901
14902         * gcore.in: Add '--readnever' option when invoking GDB.
14903
14904 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14905
14906         * MAINTAINERS: Update my email address.
14907
14908 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14909
14910         * build-id.c (build_id_to_debug_bfd_1): New function.
14911         (build_id_to_debug_bfd): Look for separate debug file in
14912         sysroot.
14913
14914 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14915
14916         * gdbarch.sh: Update the copyright year range that is placed into
14917         generated files.
14918
14919 2019-02-22  Keith Seitz  <keiths@redhat.com>
14920
14921         PR symtab/23853
14922         * linespec.c (create_sals_line_offset): Search for the default
14923         symtab's filename instead of its fullname.
14924
14925 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14926
14927         * NEWS: Update style defaults.
14928
14929 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14930
14931         * main.c (captured_main_1): Disable styling in batch mode.
14932
14933 2019-02-20  Tom Tromey  <tom@tromey.com>
14934
14935         * symtab.c (symtab_symbol_info): Fix typos.
14936
14937 2019-02-20  Tom Tromey  <tromey@adacore.com>
14938
14939         * findcmd.c (_initialize_mem_search): Use upper case for
14940         metasyntactic variables.
14941
14942 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14943
14944         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14945         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14946
14947 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14948
14949         * top.h (source_file_name): Change to std::string.
14950         * top.c (source_file_name): Likewise.
14951         (command_line_input): Adjust.
14952         * cli/cli-script.c (script_from_file): Adjust.
14953
14954 2019-02-19  Tom Tromey  <tromey@adacore.com>
14955
14956         * ravenscar-thread.c
14957         (ravenscar_thread_target::update_thread_list): Don't call
14958         ada_build_task_list.
14959         * ada-lang.h (ada_build_task_list): Don't declare.
14960         * ada-tasks.c (struct ada_tasks_inferior_data)
14961         <task_list_valid_p>: Now bool.
14962         (read_known_tasks, ada_task_list_changed)
14963         (ada_tasks_invalidate_inferior_data): Update.
14964         (read_known_tasks_array): Return bool.
14965         (read_known_tasks_list): Likewise.
14966         (read_known_tasks): Return void.
14967         (ada_build_task_list): Now static.
14968
14969 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14970
14971         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14972         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14973
14974 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14975
14976         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14977         variant for ada_tasks_pspace_data_handle and
14978         ada_tasks_inferior_data_handle.
14979         (ada_tasks_pspace_data_cleanup): New function.
14980         (ada_tasks_inferior_data_cleanup): New function.
14981
14982 2019-02-17  Tom Tromey  <tom@tromey.com>
14983
14984         * macrotab.h (macro_source_fullname): Return a std::string.
14985         * macrotab.c (macro_include, check_for_redefinition)
14986         (macro_undef, macro_lookup_definition, foreach_macro)
14987         (foreach_macro_in_scope): Update.
14988         (macro_source_fullname): Return a std::string.
14989         * macrocmd.c (show_pp_source_pos): Update.
14990
14991 2019-02-17  Tom Tromey  <tom@tromey.com>
14992
14993         * macrocmd.c (show_pp_source_pos): Style the file names.
14994
14995 2019-02-17  Tom Tromey  <tom@tromey.com>
14996
14997         PR tui/24197:
14998         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14999
15000 2019-02-17  Tom Tromey  <tom@tromey.com>
15001
15002         * ada-lang.c (user_select_syms): Use filtered printing.
15003         * utils.c (wrap_style): New global.
15004         (desired_style): Remove.
15005         (emit_style_escape): Add stream parameter.
15006         (set_output_style, reset_terminal_style, prompt_for_continue):
15007         Update.
15008         (flush_wrap_buffer): Only flush gdb_stdout.
15009         (wrap_here): Set wrap_style.
15010         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
15011         treat escape sequences as a character.  Change when wrap buffer is
15012         flushed.
15013         (fputs_styled): Do not set the output style when the default is
15014         requested.
15015         * ui-style.h (struct ui_file_style) <is_default>: New method.
15016         * source.c (print_source_lines_base): Emit escape sequences in one
15017         piece.
15018
15019 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15020
15021         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15022         integers and enumeration types.
15023
15024 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
15025
15026         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15027         instead of lookup_symbol_in_language
15028         (do_exact_match): New function.
15029         (ada_get_symbol_name_matcher): Return do_exact_match when
15030         doing a verbatim match.
15031
15032 2019-02-15  Tom Tromey  <tromey@adacore.com>
15033
15034         * ravenscar-thread.c (ravenscar_thread_target::resume)
15035         (ravenscar_thread_target::wait): Special case wildcard requests.
15036
15037 2019-02-15  Tom Tromey  <tromey@adacore.com>
15038
15039         * ravenscar-thread.c (base_ptid): Remove.
15040         (struct ravenscar_thread_target) <close>: New method.
15041         <m_base_ptid>: New member.
15042         <update_inferior_ptid, active_task, task_is_currently_active,
15043         runtime_initialized>: Declare methods.
15044         <ravenscar_thread_target>: Add constructor.
15045         (ravenscar_thread_target::task_is_currently_active)
15046         (ravenscar_thread_target::update_inferior_ptid)
15047         (ravenscar_runtime_initialized): Rename.  Now methods.
15048         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15049         (ravenscar_thread_target::update_thread_list): Update.
15050         (ravenscar_thread_target::active_task): Now method.
15051         (ravenscar_thread_target::store_registers)
15052         (ravenscar_thread_target::prepare_to_store)
15053         (ravenscar_thread_target::prepare_to_store)
15054         (ravenscar_thread_target::mourn_inferior): Update.
15055         (ravenscar_inferior_created): Use "new" to create target.
15056         (ravenscar_thread_target::get_ada_task_ptid): Update.
15057         (_initialize_ravenscar): Don't initialize base_ptid.
15058         (ravenscar_ops): Remove global.
15059
15060 2019-02-15  Tom Tromey  <tromey@adacore.com>
15061
15062         * target.h (push_target): Declare new overload.
15063         * target.c (push_target): New overload, taking an rvalue reference.
15064         * remote.c (remote_target::open_1): Use push_target overload.
15065         * corelow.c (core_target_open): Use push_target overload.
15066
15067 2019-02-15  Tom Tromey  <tromey@adacore.com>
15068
15069         * ravenscar-thread.c (is_ravenscar_task)
15070         (ravenscar_task_is_currently_active): Return bool.
15071         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15072         (_initialize_ravenscar): Remove "(void)".
15073         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15074         Return bool.
15075
15076 2019-02-15  Tom Tromey  <tromey@adacore.com>
15077
15078         * ravenscar-thread.c (ravenscar_runtime_initializer)
15079         (has_ravenscar_runtime, get_running_thread_id)
15080         (ravenscar_thread_target::resume): Fix indentation.
15081
15082 2019-02-15  Tom Tromey  <tromey@adacore.com>
15083
15084         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15085         from ravenscar_arch_ops.
15086         (sparc_ravenscar_ops::fetch_registers)
15087         (sparc_ravenscar_ops::store_registers): Now methods.
15088         (sparc_ravenscar_prepare_to_store): Remove.
15089         (sparc_ravenscar_ops): Redefine.
15090         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15091         methods and destructor.  Remove members.
15092         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15093         (ravenscar_thread_target::store_registers)
15094         (ravenscar_thread_target::prepare_to_store): Update.
15095         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15096         Remove.
15097         (struct ppc_ravenscar_powerpc_ops): Derive from
15098         ravenscar_arch_ops.
15099         (ppc_ravenscar_powerpc_ops::fetch_registers)
15100         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15101         (ppc_ravenscar_powerpc_ops): Redefine.
15102         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15103         (ppc_ravenscar_e500_ops::fetch_registers)
15104         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15105         (ppc_ravenscar_e500_ops): Redefine.
15106         * aarch64-ravenscar-thread.c
15107         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15108         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15109         (aarch64_ravenscar_fetch_registers)
15110         (aarch64_ravenscar_store_registers): Now methods.
15111         (aarch64_ravenscar_ops): Redefine.
15112
15113 2019-02-15  Tom Tromey  <tromey@adacore.com>
15114
15115         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15116         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15117         (ravenscar_thread_target::stopped_by_watchpoint)
15118         (ravenscar_thread_target::stopped_data_address)
15119         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15120
15121 2019-02-15  Tom Tromey  <tromey@adacore.com>
15122
15123         * ravenscar-thread.c: Fix some typos.
15124
15125 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15126             Tom Tromey  <tromey@adacore.com>
15127
15128         * ada-lang.c (ada_exception_sal): Change addr_string to a
15129         std::string.
15130         (create_ada_exception_catchpoint): Update.
15131
15132 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15133             Tom Tromey  <tromey@adacore.com>
15134
15135         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15136         (bp_location_ops): Remove.
15137         (base_breakpoint_allocate_location): Update.
15138         (free_bp_location): Update.
15139         * ada-lang.c (class ada_catchpoint_location)
15140         <ada_catchpoint_location>: Remove ops parameter.
15141         (ada_catchpoint_location_dtor): Remove.
15142         (ada_catchpoint_location_ops): Remove.
15143         (allocate_location_exception): Update.
15144         * breakpoint.h (struct bp_location_ops): Remove.
15145         (class bp_location) <bp_location>: Remove bp_location_ops
15146         parameter.
15147         <~bp_location>: Add destructor.
15148         <ops>: Remove.
15149
15150 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15151             Pedro Alves  <palves@redhat.com>
15152
15153         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15154         'PATH_MAX'.
15155
15156 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15157             Samuel Thibault  <samuel.thibault@gnu.org>
15158             Thomas Schwinge  <thomas@codesourcery.com>
15159
15160         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15161         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15162
15163 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15164
15165         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15166         (check_empty): Use "const char *".
15167
15168         * gnu-nat.c (gnu_nat_target::detach): Instead of
15169         'detach_inferior (pid)' call
15170         'detach_inferior (find_inferior_pid (pid))'.
15171
15172         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15173         'nat/fork-inferior.o'.
15174         * gnu-nat.c: #include "nat/fork-inferior.h".
15175
15176         * gnu-nat.c (gnu_nat_target::detach): Instead of
15177         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15178         * gnu-nat.h: #include "inf-child.h".
15179         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15180         'i386_gnu_nat_target::fetch_registers'.
15181         (gnu_store_registers): Rename/move to
15182         'i386_gnu_nat_target::store_registers'.
15183
15184         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15185         * gnu-nat.h (mach_thread_info): New function.
15186         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15187
15188         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15189
15190 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15191
15192         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15193
15194 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15195
15196         * windows-nat.c (windows_add_thread): Add new parameter
15197         "main_thread_p" with default value set to false.  Update
15198         function documentation as well as all callers.
15199         (windows_delete_thread): Likewise.
15200         (fake_create_process): Update call to windows_add_thread.
15201         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15202         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15203         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15204         call to windows_delete_thread.
15205
15206 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15207
15208         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15209
15210 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15211
15212         * symfile.c (find_separate_debug_file): Use canonical path of
15213         sysroot with child_path instead of gdb_sysroot if it is valid.
15214
15215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15216
15217         * symfile.c (find_separate_debug_file): Use child_path to
15218         determine if an object file is under a sysroot.
15219
15220 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15221
15222         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15223         unittests/child-path-selftests.c.
15224         * common/pathstuff.c (child_path): New function.
15225         * common/pathstuff.h (child_path): New prototype.
15226         * unittests/child-path-selftests.c: New file.
15227
15228 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15229
15230         * symfile.c (find_separate_debug_file): Look for separate debug
15231         files in debug directories under the sysroot.
15232
15233 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15234
15235         * symtab.h (struct minimal_symbol data_p): New const method.
15236         (struct minimal_symbol text_p): Likewise.
15237         * symtab.c (output_source_filename): Use file name style
15238         to print file name.
15239         (print_symbol_info): Likewise.
15240         (print_msymbol_info): Use address style to print addresses.
15241         Use function name style to print executable text symbols.
15242         (expand_symtab_containing_pc): Use data_p.
15243         (find_pc_sect_compunit_symtab): Likewise.
15244
15245 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15246
15247         * breakpoint.c (describe_other_breakpoints): Use address style
15248         to print addresses.
15249         (say_where): Likewise.
15250
15251 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15252
15253         * ada-typeprint.c (print_func_type): Print function name
15254         style to print function name.
15255         * c-typeprint.c (c_print_type_1): Likewise.
15256
15257 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15258
15259         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15260         for execve.
15261
15262 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15263
15264         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15265         type_stack.
15266
15267 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15268
15269         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15270         TYPE_CODE_REF types.
15271
15272 2019-02-08  Jim Wilson  <jimw@sifive.com>
15273
15274         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15275         (riscv_linux_fregset): New.
15276         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15277
15278 2019-02-07  Tom Tromey  <tom@tromey.com>
15279
15280         * thread.c (thread_cancel_execution_command): Update.
15281         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15282         methods.
15283         (struct thread_fsm_ops): Remove.
15284         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15285         (thread_fsm_should_stop, thread_fsm_return_value)
15286         (thread_fsm_set_finished, thread_fsm_finished_p)
15287         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15288         Don't declare.
15289         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15290         * infrun.c (clear_proceed_status_thread)
15291         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15292         (print_stop_event): Update.
15293         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15294         Add constructor.
15295         (step_command_fsm_ops): Remove.
15296         (new_step_command_fsm): Remove.
15297         (step_1): Update.
15298         (step_command_fsm::should_stop): Rename from
15299         step_command_fsm_should_stop.
15300         (step_command_fsm::clean_up): Rename from
15301         step_command_fsm_clean_up.
15302         (step_command_fsm::do_async_reply_reason): Rename from
15303         step_command_fsm_async_reply_reason.
15304         (struct until_next_fsm): Inherit from thread_fsm.  Add
15305         constructor.
15306         (until_next_fsm_ops): Remove.
15307         (new_until_next_fsm): Remove.
15308         (until_next_fsm::should_stop): Rename from
15309         until_next_fsm_should_stop.
15310         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15311         (until_next_fsm::do_async_reply_reason): Rename from
15312         until_next_fsm_async_reply_reason.
15313         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15314         constructor.  Change type of breakpoint.
15315         (finish_command_fsm_ops): Remove.
15316         (new_finish_command_fsm): Remove.
15317         (finish_command_fsm::should_stop): Rename from
15318         finish_command_fsm_should_stop.
15319         (finish_command_fsm::clean_up): Rename from
15320         finish_command_fsm_clean_up.
15321         (finish_command_fsm::return_value): Rename from
15322         finish_command_fsm_return_value.
15323         (finish_command_fsm::do_async_reply_reason): Rename from
15324         finish_command_fsm_async_reply_reason.
15325         (finish_command): Update.
15326         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15327         Add constructor.
15328         (call_thread_fsm_ops): Remove.
15329         (call_thread_fsm::call_thread_fsm): Rename from
15330         new_call_thread_fsm.
15331         (call_thread_fsm::should_stop): Rename from
15332         call_thread_fsm_should_stop.
15333         (call_thread_fsm::should_notify_stop): Rename from
15334         call_thread_fsm_should_notify_stop.
15335         (run_inferior_call, call_function_by_hand_dummy): Update.
15336         * cli/cli-interp.c (should_print_stop_to_console): Update.
15337         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15338         Add constructor.  Change type of location_breakpoint,
15339         caller_breakpoint.
15340         (until_break_fsm_ops): Remove.
15341         (new_until_break_fsm): Remove.
15342         (until_break_fsm::should_stop): Rename from
15343         until_break_fsm_should_stop.
15344         (until_break_fsm::clean_up): Rename from
15345         until_break_fsm_clean_up.
15346         (until_break_fsm::do_async_reply_reason): Rename from
15347         until_break_fsm_async_reply_reason.
15348         (until_break_command): Update.
15349         * thread-fsm.c: Remove.
15350         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15351
15352 2019-02-07  Tom Tromey  <tom@tromey.com>
15353
15354         * yy-remap.h: Add include guard.
15355         * xtensa-tdep.h: Add include guard.
15356         * xcoffread.h: Rename include guard.
15357         * varobj-iter.h: Add include guard.
15358         * tui/tui.h: Rename include guard.
15359         * tui/tui-winsource.h: Rename include guard.
15360         * tui/tui-wingeneral.h: Rename include guard.
15361         * tui/tui-windata.h: Rename include guard.
15362         * tui/tui-win.h: Rename include guard.
15363         * tui/tui-stack.h: Rename include guard.
15364         * tui/tui-source.h: Rename include guard.
15365         * tui/tui-regs.h: Rename include guard.
15366         * tui/tui-out.h: Rename include guard.
15367         * tui/tui-layout.h: Rename include guard.
15368         * tui/tui-io.h: Rename include guard.
15369         * tui/tui-hooks.h: Rename include guard.
15370         * tui/tui-file.h: Rename include guard.
15371         * tui/tui-disasm.h: Rename include guard.
15372         * tui/tui-data.h: Rename include guard.
15373         * tui/tui-command.h: Rename include guard.
15374         * tic6x-tdep.h: Add include guard.
15375         * target/waitstatus.h: Rename include guard.
15376         * target/wait.h: Rename include guard.
15377         * target/target.h: Rename include guard.
15378         * target/resume.h: Rename include guard.
15379         * target-float.h: Rename include guard.
15380         * stabsread.h: Add include guard.
15381         * rs6000-tdep.h: Add include guard.
15382         * riscv-fbsd-tdep.h: Add include guard.
15383         * regformats/regdef.h: Rename include guard.
15384         * record.h: Rename include guard.
15385         * python/python.h: Rename include guard.
15386         * python/python-internal.h: Rename include guard.
15387         * python/py-stopevent.h: Rename include guard.
15388         * python/py-ref.h: Rename include guard.
15389         * python/py-record.h: Rename include guard.
15390         * python/py-record-full.h: Rename include guard.
15391         * python/py-record-btrace.h: Rename include guard.
15392         * python/py-instruction.h: Rename include guard.
15393         * python/py-events.h: Rename include guard.
15394         * python/py-event.h: Rename include guard.
15395         * procfs.h: Add include guard.
15396         * proc-utils.h: Add include guard.
15397         * p-lang.h: Add include guard.
15398         * or1k-tdep.h: Rename include guard.
15399         * observable.h: Rename include guard.
15400         * nto-tdep.h: Rename include guard.
15401         * nat/x86-linux.h: Rename include guard.
15402         * nat/x86-linux-dregs.h: Rename include guard.
15403         * nat/x86-gcc-cpuid.h: Add include guard.
15404         * nat/x86-dregs.h: Rename include guard.
15405         * nat/x86-cpuid.h: Rename include guard.
15406         * nat/ppc-linux.h: Rename include guard.
15407         * nat/mips-linux-watch.h: Rename include guard.
15408         * nat/linux-waitpid.h: Rename include guard.
15409         * nat/linux-ptrace.h: Rename include guard.
15410         * nat/linux-procfs.h: Rename include guard.
15411         * nat/linux-osdata.h: Rename include guard.
15412         * nat/linux-nat.h: Rename include guard.
15413         * nat/linux-namespaces.h: Rename include guard.
15414         * nat/linux-btrace.h: Rename include guard.
15415         * nat/glibc_thread_db.h: Rename include guard.
15416         * nat/gdb_thread_db.h: Rename include guard.
15417         * nat/gdb_ptrace.h: Rename include guard.
15418         * nat/fork-inferior.h: Rename include guard.
15419         * nat/amd64-linux-siginfo.h: Rename include guard.
15420         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15421         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15422         * nat/aarch64-linux.h: Rename include guard.
15423         * nat/aarch64-linux-hw-point.h: Rename include guard.
15424         * mn10300-tdep.h: Add include guard.
15425         * mips-linux-tdep.h: Add include guard.
15426         * mi/mi-parse.h: Rename include guard.
15427         * mi/mi-out.h: Rename include guard.
15428         * mi/mi-main.h: Rename include guard.
15429         * mi/mi-interp.h: Rename include guard.
15430         * mi/mi-getopt.h: Rename include guard.
15431         * mi/mi-console.h: Rename include guard.
15432         * mi/mi-common.h: Rename include guard.
15433         * mi/mi-cmds.h: Rename include guard.
15434         * mi/mi-cmd-break.h: Rename include guard.
15435         * m2-lang.h: Add include guard.
15436         * location.h: Rename include guard.
15437         * linux-record.h: Rename include guard.
15438         * linux-nat.h: Add include guard.
15439         * linux-fork.h: Add include guard.
15440         * i386-darwin-tdep.h: Rename include guard.
15441         * hppa-linux-offsets.h: Add include guard.
15442         * guile/guile.h: Rename include guard.
15443         * guile/guile-internal.h: Rename include guard.
15444         * gnu-nat.h: Rename include guard.
15445         * gdb-stabs.h: Rename include guard.
15446         * frv-tdep.h: Add include guard.
15447         * f-lang.h: Add include guard.
15448         * event-loop.h: Add include guard.
15449         * darwin-nat.h: Rename include guard.
15450         * cp-abi.h: Rename include guard.
15451         * config/sparc/nm-sol2.h: Rename include guard.
15452         * config/nm-nto.h: Rename include guard.
15453         * config/nm-linux.h: Add include guard.
15454         * config/i386/nm-i386gnu.h: Rename include guard.
15455         * config/djgpp/nl_types.h: Rename include guard.
15456         * config/djgpp/langinfo.h: Rename include guard.
15457         * compile/gcc-cp-plugin.h: Add include guard.
15458         * compile/gcc-c-plugin.h: Add include guard.
15459         * compile/compile.h: Rename include guard.
15460         * compile/compile-object-run.h: Rename include guard.
15461         * compile/compile-object-load.h: Rename include guard.
15462         * compile/compile-internal.h: Rename include guard.
15463         * compile/compile-cplus.h: Rename include guard.
15464         * compile/compile-c.h: Rename include guard.
15465         * common/xml-utils.h: Rename include guard.
15466         * common/x86-xstate.h: Rename include guard.
15467         * common/version.h: Rename include guard.
15468         * common/vec.h: Rename include guard.
15469         * common/tdesc.h: Rename include guard.
15470         * common/selftest.h: Rename include guard.
15471         * common/scoped_restore.h: Rename include guard.
15472         * common/scoped_mmap.h: Rename include guard.
15473         * common/scoped_fd.h: Rename include guard.
15474         * common/safe-iterator.h: Rename include guard.
15475         * common/run-time-clock.h: Rename include guard.
15476         * common/refcounted-object.h: Rename include guard.
15477         * common/queue.h: Rename include guard.
15478         * common/ptid.h: Rename include guard.
15479         * common/print-utils.h: Rename include guard.
15480         * common/preprocessor.h: Rename include guard.
15481         * common/pathstuff.h: Rename include guard.
15482         * common/observable.h: Rename include guard.
15483         * common/netstuff.h: Rename include guard.
15484         * common/job-control.h: Rename include guard.
15485         * common/host-defs.h: Rename include guard.
15486         * common/gdb_wait.h: Rename include guard.
15487         * common/gdb_vecs.h: Rename include guard.
15488         * common/gdb_unlinker.h: Rename include guard.
15489         * common/gdb_unique_ptr.h: Rename include guard.
15490         * common/gdb_tilde_expand.h: Rename include guard.
15491         * common/gdb_sys_time.h: Rename include guard.
15492         * common/gdb_string_view.h: Rename include guard.
15493         * common/gdb_splay_tree.h: Rename include guard.
15494         * common/gdb_setjmp.h: Rename include guard.
15495         * common/gdb_ref_ptr.h: Rename include guard.
15496         * common/gdb_optional.h: Rename include guard.
15497         * common/gdb_locale.h: Rename include guard.
15498         * common/gdb_assert.h: Rename include guard.
15499         * common/filtered-iterator.h: Rename include guard.
15500         * common/filestuff.h: Rename include guard.
15501         * common/fileio.h: Rename include guard.
15502         * common/environ.h: Rename include guard.
15503         * common/common-utils.h: Rename include guard.
15504         * common/common-types.h: Rename include guard.
15505         * common/common-regcache.h: Rename include guard.
15506         * common/common-inferior.h: Rename include guard.
15507         * common/common-gdbthread.h: Rename include guard.
15508         * common/common-exceptions.h: Rename include guard.
15509         * common/common-defs.h: Rename include guard.
15510         * common/common-debug.h: Rename include guard.
15511         * common/cleanups.h: Rename include guard.
15512         * common/buffer.h: Rename include guard.
15513         * common/btrace-common.h: Rename include guard.
15514         * common/break-common.h: Rename include guard.
15515         * cli/cli-utils.h: Rename include guard.
15516         * cli/cli-style.h: Rename include guard.
15517         * cli/cli-setshow.h: Rename include guard.
15518         * cli/cli-script.h: Rename include guard.
15519         * cli/cli-interp.h: Rename include guard.
15520         * cli/cli-decode.h: Rename include guard.
15521         * cli/cli-cmds.h: Rename include guard.
15522         * charset-list.h: Add include guard.
15523         * buildsym-legacy.h: Rename include guard.
15524         * bfin-tdep.h: Add include guard.
15525         * ax.h: Rename include guard.
15526         * arm-linux-tdep.h: Add include guard.
15527         * arm-fbsd-tdep.h: Add include guard.
15528         * arch/xtensa.h: Rename include guard.
15529         * arch/tic6x.h: Add include guard.
15530         * arch/i386.h: Add include guard.
15531         * arch/arm.h: Rename include guard.
15532         * arch/arm-linux.h: Rename include guard.
15533         * arch/arm-get-next-pcs.h: Rename include guard.
15534         * arch/amd64.h: Add include guard.
15535         * arch/aarch64-insn.h: Rename include guard.
15536         * arch-utils.h: Rename include guard.
15537         * annotate.h: Add include guard.
15538         * amd64-darwin-tdep.h: Rename include guard.
15539         * aarch64-linux-tdep.h: Add include guard.
15540         * aarch64-fbsd-tdep.h: Add include guard.
15541         * aarch32-linux-nat.h: Add include guard.
15542
15543 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15544
15545         * macrotab.c (macro_define_internal): New function that
15546         factorizes macro_define_object_internal and macro_define_function
15547         code.
15548         (macro_define_object_internal): Use macro_define_internal.
15549         (macro_define_function): Likewise.
15550
15551 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15552
15553         * macrocmd.c (extract_identifier): Return
15554         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15555         callers.
15556
15557 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15558
15559         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15560
15561 2019-02-05  Tom Tromey  <tom@tromey.com>
15562
15563         * target.c (target_stack::unpush): Move assertion earlier.
15564
15565 2019-01-30  Tom Tromey  <tom@tromey.com>
15566
15567         PR python/23615:
15568         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15569         (gdbpy_parse_and_eval): Likewise.
15570         * python/python-internal.h (gdbpy_allow_threads): New class.
15571
15572 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15573
15574         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15575         (aarch64_fbsd_fpregmap): Move earlier.
15576         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15577         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15578         instead of individual calls to trad_frame_set_reg_addr.
15579         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15580         earlier.
15581         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15582         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15583         instead of individual calls to trad_frame_set_reg_addr.
15584
15585 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15586
15587         * CONTRIBUTE: Replace contribution list with wiki link.
15588
15589 2019-01-25  Tom Tromey  <tom@tromey.com>
15590
15591         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15592
15593 2019-01-25  Tom Tromey  <tom@tromey.com>
15594
15595         * xtensa-linux-nat.c: Fix common/ includes.
15596         * xml-support.h: Fix common/ includes.
15597         * xml-support.c: Fix common/ includes.
15598         * x86-linux-nat.c: Fix common/ includes.
15599         * windows-nat.c: Fix common/ includes.
15600         * varobj.h: Fix common/ includes.
15601         * varobj.c: Fix common/ includes.
15602         * value.c: Fix common/ includes.
15603         * valops.c: Fix common/ includes.
15604         * utils.c: Fix common/ includes.
15605         * unittests/xml-utils-selftests.c: Fix common/ includes.
15606         * unittests/utils-selftests.c: Fix common/ includes.
15607         * unittests/unpack-selftests.c: Fix common/ includes.
15608         * unittests/tracepoint-selftests.c: Fix common/ includes.
15609         * unittests/style-selftests.c: Fix common/ includes.
15610         * unittests/string_view-selftests.c: Fix common/ includes.
15611         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15612         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15613         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15614         * unittests/rsp-low-selftests.c: Fix common/ includes.
15615         * unittests/parse-connection-spec-selftests.c: Fix common/
15616         includes.
15617         * unittests/optional-selftests.c: Fix common/ includes.
15618         * unittests/offset-type-selftests.c: Fix common/ includes.
15619         * unittests/observable-selftests.c: Fix common/ includes.
15620         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15621         * unittests/memrange-selftests.c: Fix common/ includes.
15622         * unittests/memory-map-selftests.c: Fix common/ includes.
15623         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15624         * unittests/function-view-selftests.c: Fix common/ includes.
15625         * unittests/environ-selftests.c: Fix common/ includes.
15626         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15627         * unittests/common-utils-selftests.c: Fix common/ includes.
15628         * unittests/cli-utils-selftests.c: Fix common/ includes.
15629         * unittests/array-view-selftests.c: Fix common/ includes.
15630         * ui-file.c: Fix common/ includes.
15631         * tui/tui-io.c: Fix common/ includes.
15632         * tracepoint.h: Fix common/ includes.
15633         * tracepoint.c: Fix common/ includes.
15634         * tracefile-tfile.c: Fix common/ includes.
15635         * top.h: Fix common/ includes.
15636         * top.c: Fix common/ includes.
15637         * thread.c: Fix common/ includes.
15638         * target/waitstatus.h: Fix common/ includes.
15639         * target/waitstatus.c: Fix common/ includes.
15640         * target.h: Fix common/ includes.
15641         * target.c: Fix common/ includes.
15642         * target-memory.c: Fix common/ includes.
15643         * target-descriptions.c: Fix common/ includes.
15644         * symtab.h: Fix common/ includes.
15645         * symfile.c: Fix common/ includes.
15646         * stap-probe.c: Fix common/ includes.
15647         * spu-linux-nat.c: Fix common/ includes.
15648         * sparc-nat.c: Fix common/ includes.
15649         * source.c: Fix common/ includes.
15650         * solib.c: Fix common/ includes.
15651         * solib-target.c: Fix common/ includes.
15652         * ser-unix.c: Fix common/ includes.
15653         * ser-tcp.c: Fix common/ includes.
15654         * ser-pipe.c: Fix common/ includes.
15655         * ser-base.c: Fix common/ includes.
15656         * selftest-arch.c: Fix common/ includes.
15657         * s12z-tdep.c: Fix common/ includes.
15658         * rust-exp.y: Fix common/ includes.
15659         * rs6000-aix-tdep.c: Fix common/ includes.
15660         * riscv-tdep.c: Fix common/ includes.
15661         * remote.c: Fix common/ includes.
15662         * remote-notif.h: Fix common/ includes.
15663         * remote-fileio.h: Fix common/ includes.
15664         * remote-fileio.c: Fix common/ includes.
15665         * regcache.h: Fix common/ includes.
15666         * regcache.c: Fix common/ includes.
15667         * record-btrace.c: Fix common/ includes.
15668         * python/python.c: Fix common/ includes.
15669         * python/py-type.c: Fix common/ includes.
15670         * python/py-inferior.c: Fix common/ includes.
15671         * progspace.h: Fix common/ includes.
15672         * producer.c: Fix common/ includes.
15673         * procfs.c: Fix common/ includes.
15674         * proc-api.c: Fix common/ includes.
15675         * printcmd.c: Fix common/ includes.
15676         * ppc-linux-nat.c: Fix common/ includes.
15677         * parser-defs.h: Fix common/ includes.
15678         * osdata.c: Fix common/ includes.
15679         * obsd-nat.c: Fix common/ includes.
15680         * nat/x86-linux.c: Fix common/ includes.
15681         * nat/x86-linux-dregs.c: Fix common/ includes.
15682         * nat/x86-dregs.h: Fix common/ includes.
15683         * nat/x86-dregs.c: Fix common/ includes.
15684         * nat/ppc-linux.c: Fix common/ includes.
15685         * nat/mips-linux-watch.h: Fix common/ includes.
15686         * nat/mips-linux-watch.c: Fix common/ includes.
15687         * nat/linux-waitpid.c: Fix common/ includes.
15688         * nat/linux-ptrace.h: Fix common/ includes.
15689         * nat/linux-ptrace.c: Fix common/ includes.
15690         * nat/linux-procfs.c: Fix common/ includes.
15691         * nat/linux-personality.c: Fix common/ includes.
15692         * nat/linux-osdata.c: Fix common/ includes.
15693         * nat/linux-namespaces.c: Fix common/ includes.
15694         * nat/linux-btrace.h: Fix common/ includes.
15695         * nat/linux-btrace.c: Fix common/ includes.
15696         * nat/fork-inferior.c: Fix common/ includes.
15697         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15698         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15699         * nat/aarch64-linux.c: Fix common/ includes.
15700         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15701         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15702         * namespace.h: Fix common/ includes.
15703         * mips-linux-tdep.c: Fix common/ includes.
15704         * minsyms.c: Fix common/ includes.
15705         * mi/mi-parse.h: Fix common/ includes.
15706         * mi/mi-main.c: Fix common/ includes.
15707         * mi/mi-cmd-env.c: Fix common/ includes.
15708         * memrange.h: Fix common/ includes.
15709         * memattr.c: Fix common/ includes.
15710         * maint.h: Fix common/ includes.
15711         * maint.c: Fix common/ includes.
15712         * main.c: Fix common/ includes.
15713         * machoread.c: Fix common/ includes.
15714         * location.c: Fix common/ includes.
15715         * linux-thread-db.c: Fix common/ includes.
15716         * linux-nat.c: Fix common/ includes.
15717         * linux-fork.c: Fix common/ includes.
15718         * inline-frame.c: Fix common/ includes.
15719         * infrun.c: Fix common/ includes.
15720         * inflow.c: Fix common/ includes.
15721         * inferior.h: Fix common/ includes.
15722         * inferior.c: Fix common/ includes.
15723         * infcmd.c: Fix common/ includes.
15724         * inf-ptrace.c: Fix common/ includes.
15725         * inf-child.c: Fix common/ includes.
15726         * ia64-linux-nat.c: Fix common/ includes.
15727         * i387-tdep.c: Fix common/ includes.
15728         * i386-tdep.c: Fix common/ includes.
15729         * i386-linux-tdep.c: Fix common/ includes.
15730         * i386-linux-nat.c: Fix common/ includes.
15731         * i386-go32-tdep.c: Fix common/ includes.
15732         * i386-fbsd-tdep.c: Fix common/ includes.
15733         * i386-fbsd-nat.c: Fix common/ includes.
15734         * guile/scm-type.c: Fix common/ includes.
15735         * guile/guile.c: Fix common/ includes.
15736         * go32-nat.c: Fix common/ includes.
15737         * gnu-nat.c: Fix common/ includes.
15738         * gdbthread.h: Fix common/ includes.
15739         * gdbarch-selftests.c: Fix common/ includes.
15740         * gdb_usleep.c: Fix common/ includes.
15741         * gdb_select.h: Fix common/ includes.
15742         * gdb_bfd.c: Fix common/ includes.
15743         * gcore.c: Fix common/ includes.
15744         * fork-child.c: Fix common/ includes.
15745         * findvar.c: Fix common/ includes.
15746         * fbsd-nat.c: Fix common/ includes.
15747         * event-top.c: Fix common/ includes.
15748         * event-loop.c: Fix common/ includes.
15749         * dwarf2read.c: Fix common/ includes.
15750         * dwarf2loc.c: Fix common/ includes.
15751         * dwarf2-frame.c: Fix common/ includes.
15752         * dwarf-index-cache.c: Fix common/ includes.
15753         * dtrace-probe.c: Fix common/ includes.
15754         * disasm-selftests.c: Fix common/ includes.
15755         * defs.h: Fix common/ includes.
15756         * csky-tdep.c: Fix common/ includes.
15757         * cp-valprint.c: Fix common/ includes.
15758         * cp-support.h: Fix common/ includes.
15759         * cp-support.c: Fix common/ includes.
15760         * corelow.c: Fix common/ includes.
15761         * completer.h: Fix common/ includes.
15762         * completer.c: Fix common/ includes.
15763         * compile/compile.c: Fix common/ includes.
15764         * compile/compile-loc2c.c: Fix common/ includes.
15765         * compile/compile-cplus-types.c: Fix common/ includes.
15766         * compile/compile-cplus-symbols.c: Fix common/ includes.
15767         * command.h: Fix common/ includes.
15768         * cli/cli-dump.c: Fix common/ includes.
15769         * cli/cli-cmds.c: Fix common/ includes.
15770         * charset.c: Fix common/ includes.
15771         * build-id.c: Fix common/ includes.
15772         * btrace.h: Fix common/ includes.
15773         * btrace.c: Fix common/ includes.
15774         * breakpoint.h: Fix common/ includes.
15775         * breakpoint.c: Fix common/ includes.
15776         * ax.h:
15777         (enum agent_op): Fix common/ includes.
15778         * ax-general.c (struct aop_map): Fix common/ includes.
15779         * ax-gdb.c: Fix common/ includes.
15780         * auxv.c: Fix common/ includes.
15781         * auto-load.c: Fix common/ includes.
15782         * arm-tdep.c: Fix common/ includes.
15783         * arch/riscv.c: Fix common/ includes.
15784         * arch/ppc-linux-common.c: Fix common/ includes.
15785         * arch/i386.c: Fix common/ includes.
15786         * arch/arm.c: Fix common/ includes.
15787         * arch/arm-linux.c: Fix common/ includes.
15788         * arch/arm-get-next-pcs.c: Fix common/ includes.
15789         * arch/amd64.c: Fix common/ includes.
15790         * arch/aarch64.c: Fix common/ includes.
15791         * arch/aarch64-insn.c: Fix common/ includes.
15792         * arch-utils.c: Fix common/ includes.
15793         * amd64-windows-tdep.c: Fix common/ includes.
15794         * amd64-tdep.c: Fix common/ includes.
15795         * amd64-sol2-tdep.c: Fix common/ includes.
15796         * amd64-obsd-tdep.c: Fix common/ includes.
15797         * amd64-nbsd-tdep.c: Fix common/ includes.
15798         * amd64-linux-tdep.c: Fix common/ includes.
15799         * amd64-linux-nat.c: Fix common/ includes.
15800         * amd64-fbsd-tdep.c: Fix common/ includes.
15801         * amd64-fbsd-nat.c: Fix common/ includes.
15802         * amd64-dicos-tdep.c: Fix common/ includes.
15803         * amd64-darwin-tdep.c: Fix common/ includes.
15804         * agent.c: Fix common/ includes.
15805         * ada-lang.h: Fix common/ includes.
15806         * ada-lang.c: Fix common/ includes.
15807         * aarch64-tdep.c: Fix common/ includes.
15808
15809 2019-01-25  Tom Tromey  <tom@tromey.com>
15810
15811         * common/create-version.sh: Use common/version.h.
15812
15813 2019-01-24  Pedro Alves  <palves@redhat.com>
15814
15815         * infrun.c (signal_stop, signal_print, signal_program)
15816         (signal_catch, signal_pass): Now arrays instead of pointers.
15817         (update_signals_program_target, do_target_resume)
15818         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15819         * linux-nat.c (linux_nat_target::pass_signals)
15820         (linux_nat_target::create_inferior, linux_nat_target::attach):
15821         Adjust.
15822         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15823         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15824         * procfs.c (procfs_target::pass_signals): Adjust.
15825         * record-full.c (record_full_target::resume): Adjust.
15826         * remote.c (remote_target::pass_signals)
15827         (remote_target::program_signals): Adjust.
15828         * target-debug.h (target_debug_print_signals): Now takes a
15829         gdb::array_view as parameter.  Adjust.
15830         * target.h (target_ops) <pass_signals, program_signals>: Replace
15831         pointer and length parameters with gdb::array_view.
15832         (target_pass_signals, target_program_signals): Likewise.
15833         * target-delegates.c: Regenerate.
15834
15835 2019-01-24  Pedro Alves  <palves@redhat.com>
15836
15837         * common/forward-scope-exit.h
15838         (forward_scope_exit::forward_scope_exit): Pass arguments to
15839         m_bind_function directly, instead of creating a std::bind and
15840         copying that.
15841
15842 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15843
15844         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15845         for static members.
15846         (pass_in_v_vfp_candidate): Likewise.
15847
15848 2019-01-23  Tom Tromey  <tom@tromey.com>
15849             Pedro Alves  <palves@redhat.com>
15850
15851         * regcache.c (class regcache_invalidator): Remove.
15852         (regcache::raw_write): Use make_scope_exit.
15853
15854 2019-01-23  Tom Tromey  <tom@tromey.com>
15855
15856         * ui-out.h (class ui_out_emit_type): Update comment.
15857
15858 2019-01-23  Tom Tromey  <tom@tromey.com>
15859
15860         * infrun.c (fetch_inferior_event): Update comment.
15861
15862 2019-01-23  Tom Tromey  <tom@tromey.com>
15863             Pedro Alves  <palves@redhat.com>
15864
15865         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15866         parameter.
15867         (fetch_inferior_event): Use SCOPE_EXIT.
15868
15869
15870 2019-01-23  Tom Tromey  <tom@tromey.com>
15871             Pedro Alves  <palves@redhat.com>
15872
15873         * infrun.c (disable_thread_events): Delete.
15874         (stop_all_threads): Use SCOPE_EXIT.
15875
15876 2019-01-23  Tom Tromey  <tom@tromey.com>
15877             Pedro Alves  <palves@redhat.com>
15878
15879         * symfile.c: Include forward-scope-exit.h.
15880         (clear_symtab_users_cleanup): Replace forward declaration with
15881         a FORWARD_SCOPE_EXIT.
15882         (syms_from_objfile_1): Use the forward_scope_exit and
15883         gdb::optional instead of cleanup_function.
15884         (reread_symbols): Use the forward_scope_exit instead of
15885         cleanup_function.
15886         (clear_symtab_users_cleanup): Remove function.
15887
15888 2019-01-23  Tom Tromey  <tom@tromey.com>
15889             Pedro Alves  <palves@redhat.com>
15890
15891         * linux-nat.c: Include scope-exit.h.
15892         (cleanup_target_stop): Remove.
15893         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15894         SCOPE_EXIT.
15895
15896 2019-01-23  Tom Tromey  <tom@tromey.com>
15897             Pedro Alves  <palves@redhat.com>
15898
15899         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15900         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15901
15902 2019-01-23  Tom Tromey  <tom@tromey.com>
15903             Andrew Burgess  <andrew.burgess@embecosm.com>
15904             Pedro Alves  <palves@redhat.com>
15905
15906         * infrun.c (fetch_inferior_event): Use scope_exit.
15907         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15908         * top.c (execute_command): Use scope_exit.
15909         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15910         * utils.c (do_bpstat_clear_actions_cleanup)
15911         (make_bpstat_clear_actions_cleanup): Remove.
15912
15913 2019-01-23  Tom Tromey  <tom@tromey.com>
15914             Pedro Alves  <palves@redhat.com>
15915
15916         * infrun.c: Include "common/scope-exit.h"
15917         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15918         (wait_for_inferior): Use SCOPE_EXIT.
15919         (fetch_inferior_event): Use scope_exit.
15920
15921 2019-01-23  Tom Tromey  <tom@tromey.com>
15922             Pedro Alves  <palves@redhat.com>
15923
15924         * breakpoint.c (create_breakpoint): Remove cleanup.
15925
15926 2019-01-23  Tom Tromey  <tom@tromey.com>
15927             Andrew Burgess  <andrew.burgess@embecosm.com>
15928             Pedro Alves  <palves@redhat.com>
15929
15930 2019-01-23  Pedro Alves  <palves@redhat.com>
15931
15932         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15933
15934 2019-01-23  Pedro Alves  <palves@redhat.com>
15935             Andrew Burgess  <andrew.burgess@embecosm.com>
15936
15937         * gdbthread.h: Include "common/forward-scope-exit.h".
15938         (scoped_finish_thread_state): Redefine custom class in terms of
15939         forward_scope_exit.
15940
15941 2019-01-23  Pedro Alves  <palves@redhat.com>
15942             Andrew Burgess  <andrew.burgess@embecosm.com>
15943
15944         * common/forward-scope-exit.h: New file.
15945
15946 2019-01-23  Pedro Alves  <palves@redhat.com>
15947             Andrew Burgess  <andrew.burgess@embecosm.com>
15948             Tom Tromey  <tom@tromey.com>
15949
15950         * common/scope-exit.h: New file.
15951
15952 2019-01-23  Pedro Alves  <palves@redhat.com>
15953
15954         * common/preprocessor.h (ESC): Rename to ...
15955         (ESC_PARENS): ... this.
15956         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15957         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15958
15959 2019-01-23  Tom Tromey  <tom@tromey.com>
15960
15961         * language.h (class scoped_switch_to_sym_language_if_auto):
15962         Initialize m_lang in both cases.
15963
15964 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15965
15966         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15967         with XCNEW.
15968
15969 2019-01-22  Tom Tromey  <tom@tromey.com>
15970
15971         * corelow.c: Do not include sys/file.h.
15972
15973 2019-01-22  Tom Tromey  <tom@tromey.com>
15974
15975         * tui/tui-wingeneral.h: Include gdb_curses.h.
15976
15977 2019-01-22  Tom Tromey  <tom@tromey.com>
15978
15979         * source-cache.h (class source_cache) <get_source_lines,
15980         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15981
15982 2019-01-22  Tom Tromey  <tom@tromey.com>
15983
15984         * remote-fileio.h (struct remote_target): Declare.
15985
15986 2019-01-22  Tom Tromey  <tom@tromey.com>
15987
15988         * python/py-arch.c: Do not include py-ref.h.
15989         * python/py-bpevent.c: Do not include py-ref.h.
15990         * python/py-cmd.c: Do not include py-ref.h.
15991         * python/py-continueevent.c: Do not include py-ref.h.
15992         * python/py-event.h: Do not include py-ref.h.
15993         * python/py-evtregistry.c: Do not include py-ref.h.
15994         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15995         * python/py-frame.c: Do not include py-ref.h.
15996         * python/py-framefilter.c: Do not include py-ref.h.
15997         * python/py-function.c: Do not include py-ref.h.
15998         * python/py-infevents.c: Do not include py-ref.h.
15999         * python/py-linetable.c: Do not include py-ref.h.
16000         * python/py-objfile.c: Do not include py-ref.h.
16001         * python/py-param.c: Do not include py-ref.h.
16002         * python/py-prettyprint.c: Do not include py-ref.h.
16003         * python/py-progspace.c: Do not include py-ref.h.
16004         * python/py-symbol.c: Do not include py-ref.h.
16005         * python/py-symtab.c: Do not include py-ref.h.
16006         * python/py-type.c: Do not include py-ref.h.
16007         * python/py-unwind.c: Do not include py-ref.h.
16008         * python/py-utils.c: Do not include py-ref.h.
16009         * python/py-value.c: Do not include py-ref.h.
16010         * python/py-varobj.c: Do not include py-ref.h.
16011         * python/py-xmethods.c: Do not include py-ref.h.
16012         * python/python.c: Do not include py-ref.h.
16013         * varobj.c: Do not include py-ref.h.
16014
16015 2019-01-22  Tom Tromey  <tom@tromey.com>
16016
16017         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16018         keyword for bcache.
16019
16020 2019-01-22  Tom Tromey  <tom@tromey.com>
16021
16022         * compile/compile-cplus-types.c: Remove a comment by #include.
16023
16024 2019-01-22  Tom Tromey  <tom@tromey.com>
16025
16026         * compile/gcc-c-plugin.h: Include compile-internal.h.
16027
16028 2019-01-22  Tom Tromey  <tom@tromey.com>
16029
16030         * stabsread.c (EXTERN): Do not define.
16031         (symnum, next_symbol_text_func, processing_gcc_compilation)
16032         (within_function, global_sym_chain, global_stabs)
16033         (previous_stab_code, this_object_header_files)
16034         (n_this_object_header_files)
16035         (n_allocated_this_object_header_files): Define.
16036         * stabsread.h (EXTERN): Never define.  Use "extern".
16037
16038 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16039
16040         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16041         history_value.
16042
16043 2019-01-21  Tom Tromey  <tom@tromey.com>
16044
16045         * ui-out.c: Fix includes.
16046         * tui/tui-source.c: Fix includes.
16047         * target.c: Fix includes.
16048         * remote.c: Fix includes.
16049         * regcache.c: Fix includes.
16050         * python/py-block.c: Fix includes.
16051         * printcmd.c: Fix includes.
16052         * or1k-tdep.c: Fix includes.
16053         * mi/mi-main.c: Fix includes.
16054         * m32r-tdep.c: Fix includes.
16055         * csky-tdep.c: Fix includes.
16056         * compile/compile-cplus-types.c: Fix includes.
16057         * cli/cli-interp.c: Fix includes.
16058
16059 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
16060
16061         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16062         for padding.
16063
16064 2019-01-16  Tom Tromey  <tom@tromey.com>
16065
16066         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
16067         earlier.
16068         (struct objfile) <msymbols_range>: Move from top level.
16069         <msymbols>: New method.
16070         (class objfile_msymbols): Remove.
16071         * symtab.c (default_collect_symbol_completion_matches_break_on):
16072         Update.
16073         * symmisc.c (dump_msymbols): Update.
16074         * stabsread.c (scan_file_globals): Update.
16075         * objc-lang.c (info_selectors_command, info_classes_command)
16076         (find_methods): Update.
16077         * minsyms.c (find_solib_trampoline_target): Update.
16078         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16079         * coffread.c (coff_symfile_read): Update.
16080         * ada-lang.c (ada_lookup_simple_minsym)
16081         (ada_collect_symbol_completion_matches): Update.
16082
16083 2019-01-16  Tom Tromey  <tom@tromey.com>
16084
16085         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16086         type.  Remove no-argument constructor.
16087         <iterator::operator++>: Simplify.
16088         <begin>: Update.
16089         <end>: Use minimal_symbol_count.
16090
16091 2019-01-16  Tom Tromey  <tom@tromey.com>
16092
16093         * objfiles.h (struct objfile) <psymtabs>: New method.
16094         (class objfile_psymtabs): Remove.
16095         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16096         typedef.
16097         <range>: New method.
16098         (require_partial_symbols): Change return type.
16099         * psymtab.c (require_partial_symbols)
16100         (psym_expand_symtabs_matching): Update.
16101         * mdebugread.c (parse_partial_symbols): Update.
16102         * dbxread.c (dbx_end_psymtab): Update.
16103
16104 2019-01-15  Tom Tromey  <tom@tromey.com>
16105
16106         * symtab.c (lookup_objfile_from_block)
16107         (lookup_symbol_in_objfile_symtabs)
16108         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16109         (find_line_symtab, info_sources_command)
16110         (default_collect_symbol_completion_matches_break_on)
16111         (make_source_files_completion_list): Update.
16112         * symmisc.c (print_objfile_statistics, dump_objfile)
16113         (maintenance_print_symbols, maintenance_info_symtabs)
16114         (maintenance_check_symtabs, maintenance_info_line_tables):
16115         Update.
16116         * source.c (select_source_symtab)
16117         (forget_cached_source_info_for_objfile): Update.
16118         * objfiles.h (class objfile_compunits): Remove.
16119         (struct objfile) <compunits_range>: New typedef.
16120         (compunits): New method.
16121         * objfiles.c (objfile_relocate1): Update.
16122         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16123         * maint.c (count_symtabs_and_blocks): Update.
16124         * linespec.c (iterate_over_all_matching_symtabs): Update.
16125         * cp-support.c (add_symbol_overload_list_qualified): Update.
16126         * coffread.c (coff_symtab_read): Update.
16127         * ada-lang.c (add_nonlocal_symbols)
16128         (ada_collect_symbol_completion_matches)
16129         (ada_add_global_exceptions): Update.
16130
16131 2019-01-15  Tom Tromey  <tom@tromey.com>
16132
16133         * progspace.h (program_space) <objfiles_safe_range>: New
16134         typedef.
16135         <objfiles_safe>: New method.
16136         * objfiles.h (class all_objfiles_safe): Remove.
16137         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16138         * jit.c (jit_inferior_exit_hook): Update.
16139
16140 2019-01-17  Tom Tromey  <tom@tromey.com>
16141
16142         * progspace.h (program_space) <objfiles_range>: New typedef.
16143         <objfiles>: New method.
16144         <objfiles_head>: Rename from objfiles.
16145         (object_files): Update.
16146         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16147         * guile/scm-pretty-print.c
16148         (ppscm_find_pretty_printer_from_objfiles): Update.
16149         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16150         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16151         Update.
16152         * python/py-progspace.c (pspy_get_objfiles): Update.
16153         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16154         Update.
16155         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16156         (objfpy_lookup_objfile_by_build_id): Update.
16157         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16158         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16159         Update.
16160         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16161         (expand_symtab_containing_pc, lookup_objfile_from_block)
16162         (lookup_static_symbol, basic_lookup_transparent_type)
16163         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16164         (find_line_symtab, info_sources_command)
16165         (default_collect_symbol_completion_matches_break_on)
16166         (make_source_files_completion_list, find_main_name): Update.
16167         * symmisc.c (print_symbol_bcache_statistics)
16168         (print_objfile_statistics, maintenance_print_symbols)
16169         (maintenance_print_msymbols, maintenance_print_objfiles)
16170         (maintenance_info_symtabs, maintenance_check_symtabs)
16171         (maintenance_expand_symtabs, maintenance_info_line_tables):
16172         Update.
16173         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16174         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16175         (map_overlay_command, unmap_overlay_command)
16176         (simple_overlay_update, expand_symtabs_matching)
16177         (map_symbol_filenames): Update.
16178         * symfile-debug.c (set_debug_symfile): Update.
16179         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16180         Update.
16181         * source.c (select_source_symtab, forget_cached_source_info):
16182         Update.
16183         * solib.c (solib_read_symbols): Update.
16184         * solib-spu.c (append_ocl_sos): Update.
16185         * psymtab.c (maintenance_print_psymbols)
16186         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16187         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16188         * printcmd.c (info_symbol_command): Update.
16189         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16190         Update.
16191         * objfiles.h (class all_objfiles): Remove.
16192         * objfiles.c (have_partial_symbols, have_full_symbols)
16193         (have_minimal_symbols, qsort_cmp, update_section_map)
16194         (shared_objfile_contains_address_p)
16195         (default_iterate_over_objfiles_in_search_order): Update.
16196         * objc-lang.c (info_selectors_command, info_classes_command)
16197         (find_methods): Update.
16198         * minsyms.c (find_solib_trampoline_target): Update.
16199         * maint.c (maintenance_info_sections)
16200         (maintenance_translate_address, count_symtabs_and_blocks):
16201         Update.
16202         * main.c (captured_main_1): Update.
16203         * linux-thread-db.c (try_thread_db_load_from_pdir)
16204         (has_libpthread): Update.
16205         * linespec.c (iterate_over_all_matching_symtabs)
16206         (search_minsyms_for_name): Update.
16207         * jit.c (jit_find_objf_with_entry_addr): Update.
16208         * hppa-tdep.c (find_unwind_entry)
16209         (hppa_lookup_stub_minimal_symbol): Update.
16210         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16211         Update.
16212         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16213         (elf_gnu_ifunc_resolve_by_got): Update.
16214         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16215         * dwarf-index-write.c (save_gdb_index_command): Update.
16216         * cp-support.c (add_symbol_overload_list_qualified): Update.
16217         * breakpoint.c (create_overlay_event_breakpoint)
16218         (create_longjmp_master_breakpoint)
16219         (create_std_terminate_master_breakpoint)
16220         (create_exception_master_breakpoint): Update.
16221         * blockframe.c (find_pc_partial_function): Update.
16222         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16223         (ada_collect_symbol_completion_matches)
16224         (ada_add_global_exceptions): Update.
16225
16226 2019-01-17  Tom Tromey  <tom@tromey.com>
16227
16228         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16229         declare VEC.
16230         (solib_target_parse_libraries): Change return type.
16231         (library_list_start_segment, library_list_start_section)
16232         (library_list_end_library, library_list_start_library); Update.
16233         (solib_target_free_library_list): Remove.
16234         (solib_target_parse_libraries): Remove cleanup.  Change return
16235         type.
16236         (solib_target_current_sos): Update.
16237
16238 2019-01-17  Tom Tromey  <tromey@bapiya>
16239
16240         * valprint.c: Replace "the the" with "the".
16241         * symtab.c: Replace "the the" with "the".
16242         * solib.c: Replace "the the" with "the".
16243         * solib-dsbt.c: Replace "the the" with "the".
16244         * linespec.c: Replace "the the" with "the".
16245         * dwarf2loc.h: Replace "the the" with "the".
16246         * amd64-windows-tdep.c: Replace "the the" with "the".
16247         * aarch64-tdep.c: Replace "the the" with "the".
16248
16249 2019-01-16  Keith Seitz  <keiths@redhat.com>
16250
16251         PR gdb/23773
16252         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16253         <builder>: Rename to ..
16254         <m_builder>: ... this and make private.
16255         (dwarf2_cu::get_builder): New method.  Change all users of
16256         `builder' to use this method.
16257         (dwarf2_start_symtab): Move to ...
16258         (dwarf2_cu::start_symtab): ... here.  Update all callers
16259         (setup_type_unit_groups): Move to ...
16260         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16261         callers.
16262         (dwarf2_cu::reset_builder): New method.
16263         (process_full_compunit, process_full_type_unit): Use
16264         dwarf2_cu::reset_builder.
16265         (follow_die_offset): Record the ancestor CU if it is different
16266         from the followed DIE's CU.
16267         (follow_die_sig_1): Likewise.
16268
16269 2019-01-15  Tom Tromey  <tom@tromey.com>
16270
16271         * remote.c (class remote_state) <buf>: Now a char_vector.
16272         <buf_size>: Remove.
16273         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16274         parameter.
16275         (remote_target::getpkt_or_notif_sane_1)
16276         (remote_target::getpkt_sane)
16277         (remote_target::getpkt_or_notif_sane): Likewise.
16278         (class remote_target) <putpkt>: New overload.
16279         (remote_target::read_frame): Change type of "buf_p".  Remove
16280         sizeof_p parameter.
16281         (packet_ok): New overload.
16282         (packet_check_result): New overload.
16283         Update all uses.
16284
16285 2019-01-14  Tom Tromey  <tom@tromey.com>
16286
16287         * remote-notif.c (handle_notification, remote_notif_ack)
16288         (remote_notif_parse): Make "buf" const.
16289         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16290         const.
16291         (remote_notif_parse, remote_notif_ack, handle_notification):
16292         Likewise.
16293         * remote.c (remote_notif_stop_parse): Make "buf" const.
16294         (remote_target::remote_parse_stop_reply): Make "buf" const.
16295         (remote_notif_stop_ack): Make "buf" const.
16296
16297 2019-01-14  Tom Tromey  <tom@tromey.com>
16298
16299         * remote.c (remote_console_output): Make parameter const.
16300
16301 2019-01-14  Tom Tromey  <tom@tromey.com>
16302
16303         * target-debug.h (target_debug_print_signals): Constify.
16304         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16305         * procfs.c (procfs_target::pass_signals): Update.
16306         * linux-nat.c (linux_nat_target::pass_signals): Update.
16307         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16308         * target-delegates.c: Rebuild.
16309         * remote.c (remote_target::program_signals): Update.
16310         (remote_target::pass_signals): Update.
16311         * target.c (target_pass_signals): Constify argument.
16312         (target_program_signals): Likewise.
16313         * target.h (struct target_ops) <pass_signals, program_signals>:
16314         Constify argument.
16315         (target_pass_signals, target_program_signals): Constify argument.
16316
16317 2019-01-14  Tom Tromey  <tom@tromey.com>
16318
16319         PR tui/28819:
16320         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16321
16322 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16323
16324         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16325         field.
16326         * rs6000-tdep.c: Include reggroups.h.
16327         (IS_V_ALIAS_PSEUDOREG): Define.
16328         (rs6000_register_name): Return names for the "vX" aliases.
16329         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16330         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16331         aliases.  Call default_register_reggroup_p for all other
16332         pseudo-registers.
16333         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16334         New functions.
16335         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16336         Handle "vX" aliases.
16337         (v_alias_pseudo_register_collect): New function.
16338         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16339         (rs6000_gdbarch_init): Initialize "vX" aliases as
16340         pseudo-registers.  Restore registration of
16341         rs6000_pseudo_register_reggroup_p with
16342         set_tdesc_pseudo_register_reggroup_p.
16343
16344 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16345
16346         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16347         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16348         set_gdbarch_num_pseudo_regs.
16349
16350 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16351
16352         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16353         Remove arg prefixname, add do_set and do_show.
16354         Add member functions set_list and show_list.
16355         * cli/cli-style.c (class cli_style_option): Update accordingly.
16356         (style_set_list): Move to file scope.
16357         (style_show_list): Likewise.
16358         (set_style): Call help_list.
16359         (show_style): Call cmd_show_list.
16360         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16361         Update to use the new macro.
16362
16363 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16364
16365         * ada-lang.c (_initialize_ada_language): Expand the help text
16366         for the "catch exception" command.
16367
16368 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16369
16370         * symtab.c (matching_obj_sections): Initialize obj,
16371         declare it closer to its usage.
16372
16373 2019-01-10  Tom Tromey  <tom@tromey.com>
16374
16375         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16376         (basic_inf_threads_range): Remove.
16377         (inf_threads_range, inf_non_exited_threads_range)
16378         (safe_inf_threads_range): Use next_adapter.
16379
16380 2019-01-10  Keith Seitz  <keiths@redhat.com>
16381
16382         PR gdb/23712
16383         PR symtab/23010
16384         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16385         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16386
16387 2019-01-10  Keith Seitz  <keiths@redhat.com>
16388
16389         PR gdb/23712
16390         PR symtab/23010
16391         * dictionary.c (pending_to_vector): Remove.
16392         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16393         Remove _1 suffix, replacing functions of the same name.  Update
16394         all callers.
16395         (dict_create_hashed, dict_create_hashed_expandable)
16396         (dict_create_linear, dict_create_linear_expandable, dict_free)
16397         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16398         Make functions static.
16399
16400 2019-01-10  Keith Seitz  <keiths@redhat.com>
16401
16402         PR gdb/23712
16403         PR symtab/23010
16404         * dictionary.h (struct dictionary): Replace declaration with
16405         multidictionary.
16406         (dict_create_hashed, dict_create_hashed_expandable)
16407         (dict_create_linear, dict_create_linear_expandable)
16408         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16409         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16410         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16411         taking multidictionary argument.
16412         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16413         * block.h (struct block) <dict>: Change to multidictionary
16414         and rename `multidict'.
16415         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16416         symmisc.c: Update all dictionary references to multidictionary.
16417
16418 2019-01-10  Keith Seitz  <keiths@redhat.com>
16419
16420         PR gdb/23712
16421         PR symtab/23010
16422         * dictionary.c: Include unordered_map.
16423         (pending_to_vector): New function.
16424         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16425         Rewrite the non-"_1" functions to take vector instead
16426         of linked list.
16427         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16428         "new" _1 versions of the same name.
16429         (multidictionary): Define.
16430         (std::hash<enum language): New definition.
16431         (collate_pending_symbols_by_language, mdict_create_hashed)
16432         (mdict_create_hashed_expandable, mdict_create_linear)
16433         (mdict_create_linear_expandable, mdict_free)
16434         (find_language_dictionary, create_new_language_dictionary)
16435         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16436         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16437         (mdict_size, mdict_empty): New functions.
16438         * dictionary.h (mdict_iterator): Define.
16439
16440 2019-01-10  Pedro Alves  <palves@redhat.com>
16441
16442         * breakpoint.c (read_uploaded_action)
16443         (create_tracepoint_from_upload): Adjust to use
16444         gdb::unique_xmalloc_ptr.
16445         * ctf.c (ctf_write_uploaded_tp):
16446         (SET_ARRAY_FIELD): Use emplace_back.
16447         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16448         * tracefile-tfile.c (tfile_write_uploaded_tp):
16449         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16450         gdb::unique_xmalloc_ptr.
16451         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16452         at_string, cond_string, cmd_strings>: Replace char pointers
16453         with gdb::unique_xmalloc_ptr.
16454
16455 2019-01-10  Pedro Alves  <palves@redhat.com>
16456
16457         * solib-target.c (library_list_start_library): Don't xstrdup name.
16458
16459 2019-01-10  Pedro Alves  <palves@redhat.com>
16460
16461         * mdebugread.c (parse_partial_symbols): Use
16462         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16463
16464 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16465
16466         * linux-fork.c (scoped_switch_fork_info)
16467         <~scoped_switch_fork_info>: Fix incorrect variable name.
16468
16469 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16470
16471         * linux-fork.c (scoped_switch_fork_info)
16472         <scoped_switch_fork_info>: Make explicit.
16473         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16474
16475 2019-01-10  Tom Tromey  <tom@tromey.com>
16476
16477         * objfiles.h (objfile::reset_psymtabs): Update.
16478         * objfiles.c (objfile::objfile): Update.
16479         * psymtab.h (psymtab_storage::obstack): Update.
16480         (psymtab_storage::m_obstack): Use gdb::optional.
16481         (class psymtab_storage): Update comment.  Remove objfile
16482         parameter.
16483         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16484
16485 2019-01-10  Tom Tromey  <tom@tromey.com>
16486
16487         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16488         <free_psymtabs>: Now private.
16489         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16490         (allocate_psymtab): Use new method.
16491
16492 2019-01-10  Tom Tromey  <tom@tromey.com>
16493
16494         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16495         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16496         * mdebugread.c (parse_partial_symbols): Use
16497         allocate_dependencies.
16498         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16499         allocate_dependencies.
16500         (process_psymtab_comp_unit_reader)
16501         (build_type_psymtab_dependencies): Likewise.
16502         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16503
16504 2019-01-10  Tom Tromey  <tom@tromey.com>
16505
16506         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16507         PSYMBOL_SET_LANGUAGE.
16508         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16509
16510 2019-01-10  Tom Tromey  <tom@tromey.com>
16511
16512         * psymtab.h (psymtab_storage::obstack): New method.
16513         <m_obstack>: Rename from obstack; now private.
16514         * psymtab.c (psymtab_storage): Update.
16515         * dwarf2read.c (create_addrmap_from_index)
16516         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16517         Update.
16518
16519 2019-01-10  Tom Tromey  <tom@tromey.com>
16520
16521         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16522         * objfiles.h (objfile::reset_psymtabs): New method.
16523
16524 2019-01-10  Tom Tromey  <tom@tromey.com>
16525
16526         * symmisc.c (print_symbol_bcache_statistics): Update.
16527         (print_objfile_statistics): Update.
16528         * symfile.c (reread_symbols): Update.
16529         * psymtab.h (class psymtab_storage): New.
16530         * psymtab.c (psymtab_storage): New constructor.
16531         (~psymtab_storage): New destructor.
16532         (require_partial_symbols): Update.
16533         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16534         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16535         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16536         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16537         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16538         (start_psymtab_common, end_psymtab_common)
16539         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16540         (allocate_psymtab): Update.
16541         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16542         Update.
16543         (dump_psymtab_addrmap, maintenance_print_psymbols)
16544         (maintenance_check_psymtabs): Update.
16545         (class objfile_psymtabs): Move to objfiles.h.
16546         * psympriv.h (discard_psymtab): Now inline.
16547         (psymtab_discarder::psymtab_discarder): Update.
16548         (psymtab_discarder::~psymtab_discarder): Update.
16549         (ALL_OBJFILE_PSYMTABS): Rewrite.
16550         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16551         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16552         Remove fields.
16553         <partial_symtabs>: New field.
16554         (class objfile_psymtabs): Move from psymtab.h.  Update.
16555         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16556         psymbol_cache.
16557         (objfile::~objfile): Don't destroy psymbol_cache.
16558         * mdebugread.c (parse_partial_symbols): Update.
16559         * dwarf2read.c (create_addrmap_from_index)
16560         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16561         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16562         (add_partial_subprogram, dwarf2_ranges_read): Update.
16563         * dwarf-index-write.c (write_address_map)
16564         (write_one_signatured_type, recursively_write_psymbols)
16565         (class debug_names, class debug_names, write_psymtabs_to_index):
16566         Update.
16567
16568 2019-01-10  Tom Tromey  <tom@tromey.com>
16569
16570         * symtab.h (SYMBOL_SET_NAMES): Update.
16571         (symbol_set_names): Update.
16572         (MSYMBOL_SET_NAMES): Update.
16573         * symtab.c (symbol_set_names): Change argument to be an
16574         objfile_per_bfd_storage.
16575         * psymtab.c (add_psymbol_to_bcache): Update.
16576         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16577
16578 2019-01-10  Tom Tromey  <tom@tromey.com>
16579
16580         * symtab.c (create_demangled_names_hash): Change argument to be an
16581         objfile_per_bfd_storage.
16582         (symbol_set_names): Update.
16583
16584 2019-01-10  Tom Tromey  <tom@tromey.com>
16585
16586         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16587         init_psymbol_list.
16588         * psymtab.c (init_psymbol_list): Do nothing if already called.
16589         * psympriv.h (init_psymbol_list): Add comment.
16590         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16591         init_psymbol_list.
16592         * dbxread.c (dbx_symfile_read): Unconditionally call
16593         init_psymbol_list.
16594
16595 2019-01-10  Tom Tromey  <tom@tromey.com>
16596
16597         * xcoffread.c (scan_xcoff_symtab): Update.
16598         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16599         "where".
16600         * mdebugread.c (parse_partial_symbols)
16601         (handle_psymbol_enumerators): Update.
16602         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16603         * dbxread.c (read_dbx_symtab): Update.
16604         * psympriv.h (psymbol_placement): New enum.
16605         (add_psymbol_to_list): Update.
16606
16607 2019-01-10  Tom Tromey  <tom@tromey.com>
16608
16609         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16610         static_psymbols parameters.
16611         (scan_xcoff_symtab): Update.
16612         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16613         static_psymbols parameters.
16614         * psympriv.h (start_psymtab_common): Update.
16615         * mdebugread.c (parse_partial_symbols): Update.
16616         * dwarf2read.c (create_partial_symtab): Update.
16617         * dbxread.c (read_dbx_symtab): Update.
16618         (start_psymtab): Remove global_psymbols and static_psymbols
16619         parameters.
16620
16621 2019-01-10  Tom Tromey  <tom@tromey.com>
16622
16623         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16624         * psymtab.c (allocate_psymtab): Add comment.
16625         * psympriv.h (allocate_psymtab): Add comment.
16626         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16627         initializations.
16628         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16629
16630 2019-01-10  Tom Tromey  <tom@tromey.com>
16631
16632         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16633         Don't declare.
16634         * mipsread.c: Include mdebugread.h.
16635         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16636         Declare.
16637         * elfread.c: Include mdebugread.h.
16638
16639 2019-01-09  Tom Tromey  <tom@tromey.com>
16640
16641         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16642         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16643         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16644         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16645         (psym_lookup_symbol, psym_find_last_source_symtab)
16646         (psym_forget_cached_source_info, psym_print_stats)
16647         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16648         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16649         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16650         (psym_find_compunit_symtab_by_address)
16651         (maintenance_print_psymbols, maintenance_info_psymtabs)
16652         (maintenance_check_psymtabs): Use ranged for.
16653         * psymtab.h (class objfile_psymtabs): New.
16654         (require_partial_symbols): Return objfile_psymtabs.
16655         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16656
16657 2019-01-09  Tom Tromey  <tom@tromey.com>
16658
16659         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16660         (find_pc_mapped_section, list_overlays_command)
16661         (map_overlay_command, unmap_overlay_command)
16662         (simple_overlay_update): Use all_objfiles.
16663         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16664         * printcmd.c (info_symbol_command): Use all_objfiles.
16665         * objfiles.h (ALL_OBJSECTIONS): Remove.
16666         * maint.c (maintenance_translate_address): Use all_objfiles.
16667         * gcore.c (gcore_create_callback): Use all_objfiles.
16668         (objfile_find_memory_regions): Likewise.
16669
16670 2019-01-09  Tom Tromey  <tom@tromey.com>
16671
16672         * symtab.c (find_line_symtab, info_sources_command)
16673         (make_source_files_completion_list): Use objfile_compunits.
16674         * source.c (select_source_symtab): Use objfile_compunits.
16675         * objfiles.h (struct objfile): Update comment.
16676         (ALL_OBJFILES): Remove.
16677         (ALL_FILETABS): Remove.
16678         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16679         objfile_compunits.
16680
16681 2019-01-09  Tom Tromey  <tom@tromey.com>
16682
16683         * symmisc.c (print_objfile_statistics, dump_objfile)
16684         (maintenance_print_symbols): Use compunit_filetabs.
16685         * source.c (forget_cached_source_info_for_objfile): Use
16686         compunit_filetabs.
16687         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16688         (ALL_FILETABS): Use compunit_filetabs.
16689         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16690         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16691
16692 2019-01-09  Tom Tromey  <tom@tromey.com>
16693
16694         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16695         (compunit_filetabs): New.
16696         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16697         compunit_filetabs.
16698         (info_sources_command, make_source_files_completion_list): Remove
16699         declaration.
16700         * symmisc.c (print_objfile_statistics, dump_objfile)
16701         (maintenance_print_symbols): Remove declaration.
16702         (maintenance_info_symtabs): Use compunit_filetabs.
16703         (maintenance_info_line_tables): Likewise.
16704         * source.c (select_source_symtab): Change local variable name.
16705         (forget_cached_source_info_for_objfile): Remove declaration.
16706         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16707         * objfiles.c (objfile_relocate1): Remove declaration.
16708         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16709         declaration.
16710         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16711         * coffread.c (coff_symtab_read): Remove declaration.
16712         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16713         compunit_filetabs.
16714
16715 2019-01-09  Tom Tromey  <tom@tromey.com>
16716
16717         * symtab.c (lookup_objfile_from_block)
16718         (find_pc_sect_compunit_symtab, search_symbols)
16719         (default_collect_symbol_completion_matches_break_on): Use
16720         objfile_compunits.
16721         * objfiles.h (ALL_COMPUNITS): Remove.
16722         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16723         * cp-support.c (add_symbol_overload_list_qualified): Use
16724         objfile_compunits.
16725         * ada-lang.c (ada_collect_symbol_completion_matches)
16726         (ada_add_global_exceptions): Use objfile_compunits.
16727
16728 2019-01-09  Tom Tromey  <tom@tromey.com>
16729
16730         * source.c (select_source_symtab)
16731         (forget_cached_source_info_for_objfile): Remove declaration.
16732         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16733         declaration.
16734         * maint.c (count_symtabs_and_blocks): Remove declaration.
16735         * cp-support.c (add_symbol_overload_list_qualified): Remove
16736         declaration.
16737         * coffread.c (coff_symtab_read): Remove declaration.
16738         * symtab.c (lookup_symbol_in_objfile_symtabs)
16739         (basic_lookup_transparent_type_1): Use objfile_compunits.
16740         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16741         (info_sources_command, search_symbols)
16742         (default_collect_symbol_completion_matches_break_on)
16743         (make_source_files_completion_list): Remove declaration.
16744         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16745         (ada_collect_symbol_completion_matches)
16746         (ada_add_global_exceptions): Remove declaration.
16747         * linespec.c (iterate_over_all_matching_symtabs): Use
16748         objfile_compunits.
16749         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16750         (class objfile_compunits): New.
16751         (ALL_COMPUNITS): Use objfile_compunits.
16752         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16753         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16754         objfile_compunits.
16755         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16756
16757 2019-01-09  Tom Tromey  <tom@tromey.com>
16758
16759         * symtab.c (search_symbols)
16760         (default_collect_symbol_completion_matches_break_on): Use
16761         objfile_msymbols.
16762         * ada-lang.c (ada_lookup_simple_minsym)
16763         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16764         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16765         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16766         objfile_msymbols.
16767         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16768         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16769         * objc-lang.c (find_methods): Use objfile_msymbols.
16770         (info_selectors_command, info_classes_command): Likewise.
16771         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16772         * objfiles.h (class objfile_msymbols): New.
16773         (ALL_OBJFILE_MSYMBOLS): Remove.
16774         (ALL_MSYMBOLS): Remove.
16775
16776 2019-01-09  Tom Tromey  <tom@tromey.com>
16777
16778         * common/next-iterator.h (next_adapter): Add Iterator template
16779         parameter.
16780         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16781         (class all_objfiles_safe): New.
16782         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16783         * objfiles.c (put_objfile_before): Update comment.
16784         (add_separate_debug_objfile): Likewise.
16785         (free_all_objfiles): Use all_objfiles_safe.
16786         (objfile_purge_solibs): Likewise.
16787
16788 2019-01-09  Tom Tromey  <tom@tromey.com>
16789
16790         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16791         (expand_symtab_containing_pc, lookup_static_symbol)
16792         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16793         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16794         all_objfiles.
16795         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16796         * breakpoint.c (create_overlay_event_breakpoint)
16797         (create_longjmp_master_breakpoint)
16798         (create_std_terminate_master_breakpoint)
16799         (create_exception_master_breakpoint): Use all_objfiles.
16800         * linux-thread-db.c (try_thread_db_load_from_pdir)
16801         (has_libpthread): Use all_objfiles.
16802         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16803         * linespec.c (iterate_over_all_matching_symtabs)
16804         (search_minsyms_for_name): Use all_objfiles.
16805         * maint.c (maintenance_info_sections): Use all_objfiles.
16806         * main.c (captured_main_1): Use all_objfiles.
16807         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16808         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16809         * guile/scm-pretty-print.c
16810         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16811         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16812         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16813         (maintenance_print_msymbols): Use all_objfiles.
16814         * source.c (select_source_symtab): Use all_objfiles.
16815         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16816         * symfile.c (remove_symbol_file_command)
16817         (expand_symtabs_matching, map_symbol_filenames): Use
16818         all_objfiles.
16819         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16820         all_objfiles.
16821         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16822         * objc-lang.c (find_methods): Use all_objfiles.
16823         * objfiles.c (have_partial_symbols, have_full_symbols)
16824         (have_minimal_symbols, qsort_cmp)
16825         (default_iterate_over_objfiles_in_search_order): Use
16826         all_objfiles.
16827         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16828         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16829         (maintenance_check_psymtabs): Use all_objfiles.
16830         (ALL_PSYMTABS): Remove.
16831         * compile/compile-object-run.c (do_module_cleanup): Use
16832         all_objfiles.
16833         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16834         * cp-support.c (add_symbol_overload_list_qualified): Use
16835         all_objfiles.
16836         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16837         Use all_objfiles.
16838         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16839         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16840         all_objfiles.
16841         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16842         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16843         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16844         Uses all_objfiles.
16845         * solib.c (solib_read_symbols): Use all_objfiles
16846
16847 2019-01-09  Tom Tromey  <tom@tromey.com>
16848
16849         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16850         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16851         all_objfiles.
16852         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16853         * symmisc.c (print_symbol_bcache_statistics)
16854         (print_objfile_statistics, maintenance_print_objfiles)
16855         (maintenance_info_symtabs, maintenance_check_symtabs)
16856         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16857         all_objfiles.
16858         * source.c (forget_cached_source_info): Use all_objfiles.
16859         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16860         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16861         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16862         * objfiles.c (update_section_map): Use all_objfiles.
16863         (shared_objfile_contains_address_p): Likewise.
16864         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16865         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16866
16867 2019-01-09  Tom Tromey  <tom@tromey.com>
16868
16869         * common/next-iterator.h: New file.
16870         * objfiles.h (class all_objfiles): New.
16871         (struct objfile_iterator): New.
16872
16873 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16874
16875         * NEWS: Move the description of the changed "frame", "select-frame",
16876          and "info frame" commands to the Changed commands section.
16877
16878 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16879
16880         * gdbtypes.c (check_stub_method_group): Remove handling of old
16881         mangling schemes.
16882         * linespec.c (find_methods): Likewise.
16883         * stabsread.c (read_member_functions): Likewise.
16884         * valops.c (search_struct_method): Likewise.
16885         (value_struct_elt_for_reference): Likewise.
16886         * NEWS: Mention this change.
16887
16888 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16889
16890         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16891         print_source_lines.
16892         * source.c (print_source_lines_base): Update line number check.
16893         (print_source_lines): New function.
16894         (source_lines_range::source_lines_range): New function.
16895         * source.h (class source_lines_range): New class.
16896         (print_source_lines): New declaration.
16897
16898 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16899
16900         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16901
16902 2019-01-08  Tom Tromey  <tom@tromey.com>
16903             Simon Marchi  <simon.marchi@ericsson.com>
16904
16905         PR gdb/24060
16906         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16907         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16908         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16909         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16910         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16911         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16912
16913 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16914
16915         * source.c (select_source_symtab): Move header comment to
16916         declaration in source.h.
16917         (forget_cached_source_info_for_objfile): Likewise.
16918         (forget_cached_source_info): Likewise.
16919         (identify_source_line): Likewise.
16920         * source.h (identify_source_line): Move declaration from symtab.h
16921         and add comment from source.c
16922         (print_source_lines): Likewise.
16923         (forget_cached_source_info_for_objfile): Likewise.
16924         (forget_cached_source_info): Likewise.
16925         (select_source_symtab): Likewise.
16926         (enum print_source_lines_flag): Move definition from symtab.h.
16927         * symtab.h (identify_source_line): Move declaration to source.h.
16928         (print_source_lines): Likewise.
16929         (forget_cached_source_info_for_objfile): Likewise.
16930         (forget_cached_source_info): Likewise.
16931         (select_source_symtab): Likewise.
16932         (enum print_source_lines_flag): Move definition to source.h.
16933         * tui/tui-hooks.c: Add 'source.h' include.
16934
16935 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16936
16937         * source.c (print_source_lines_base): Handle requests to print
16938         reverse line number sequences, and guard against empty lines
16939         string.
16940
16941 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16942
16943         * source.c (print_source_lines_base): Fix skip of '\r' if next
16944         character is '\n'.
16945
16946 2019-01-06  Tom Tromey  <tom@tromey.com>
16947
16948         * c-exp.y (struct c_parse_state) <macro_original_text,
16949         expansion_obstack>: New member.
16950         (macro_original_text, expansion_obstack): Remove globals.
16951         (scan_macro_expansion, scanning_macro_expansion)
16952         (finished_macro_expansion): Update.
16953         (scan_macro_cleanup): Remove.
16954         (yylex, c_parse): Update.
16955
16956 2019-01-06  Tom Tromey  <tom@tromey.com>
16957
16958         * c-exp.y (struct c_parse_state) <strings>: New member.
16959         (operator_stoken): Update.
16960
16961 2019-01-06  Tom Tromey  <tom@tromey.com>
16962
16963         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16964         (union type_stack_elt) <typelist_val>: Now a pointer to
16965         std::vector.
16966         (type_stack_cleanup): Don't declare.
16967         (push_typelist): Update.
16968         * parse.c (pop_typelist): Return a std::vector.
16969         (push_typelist): Take a std::vector.
16970         (follow_types): Update.  Do not free args.
16971         (type_stack_cleanup): Remove.
16972         * c-exp.y (struct c_parse_state): New.
16973         (cpstate): New global.
16974         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16975         (nonempty_typelist): Update.
16976         (func_mod): Create a new vector.
16977         (c_parse): Create a c_parse_state.
16978         (check_parameter_typelist): Do not delete params.
16979         (function_method): Update.  Do not delete type_list.
16980
16981 2019-01-06  Tom Tromey  <tom@tromey.com>
16982
16983         PR gdb/28155:
16984         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16985         check_typedef.
16986         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16987         (print_return_value): Likewise.
16988
16989 2019-01-05  Tom Tromey  <tom@tromey.com>
16990
16991         * contrib/cleanup_check.py: Remove.
16992         * contrib/gcc-with-excheck: Remove.
16993         * contrib/exsummary.py: Remove.
16994         * contrib/excheck.py: Remove.
16995
16996 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16997
16998         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16999         NULL. Initialize tpprev to NULL instead of assigning it
17000         to NULL on the next statement.
17001         * windows-nat.c (windows_delete_thread): Remove check for
17002         main_thread_id before printing thread exit notifications.
17003         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17004         Remove thread ID check against main_thread_id.
17005         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17006         windows_delete_thread.
17007         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17008
17009 2019-01-04  Tom Tromey  <tom@tromey.com>
17010
17011         * compile/compile.c (_initialize_compile): Use upper case for
17012         metasyntactic variables.
17013         * symmisc.c (_initialize_symmisc): Use upper case for
17014         metasyntactic variables.
17015         * psymtab.c (_initialize_psymtab): Use upper case for
17016         metasyntactic variables.
17017         * demangle.c (demangle_command): Use upper case for metasyntactic
17018         variables.
17019         (_initialize_demangler): Likewise.
17020         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17021         variables.
17022
17023 2019-01-03  Tom Tromey  <tom@tromey.com>
17024
17025         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17026
17027 2019-01-03  Tom Tromey  <tom@tromey.com>
17028
17029         * python/py-symtab.c (salpy_str): Update.
17030         (struct salpy_sal_object) <symtab>: Now a PyObject.
17031         (salpy_dealloc): Update.
17032         (del_objfile_sal): Use gdbpy_ref.
17033
17034 2019-01-03  Tom Tromey  <tom@tromey.com>
17035
17036         * python/py-type.c (convert_field): Use new_reference.  Return
17037         gdbpy_ref.
17038         (make_fielditem): Return gdbpy_ref.
17039         (typy_fields): Update.
17040         (typy_getitem): Update.
17041         (field_name): Return gdbpy_ref.  Use new_reference.
17042         (typy_iterator_iternext): Update.
17043
17044 2019-01-03  Tom Tromey  <tom@tromey.com>
17045
17046         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17047
17048 2019-01-03  Tom Tromey  <tom@tromey.com>
17049
17050         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17051         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17052         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17053         (pspy_set_frame_filters, pspy_set_frame_unwinders)
17054         (pspy_set_type_printers): Likewise.
17055         * python/py-function.c (fnpy_init): Use gdbpy_ref.
17056         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17057         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17058         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17059         (objfpy_set_type_printers): Likewise.
17060
17061 2019-01-03  Tom Tromey  <tom@tromey.com>
17062
17063         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17064         (gdbpy_print_stack): Use gdbpy_err_fetch.
17065         * python/python-internal.h (class gdbpy_err_fetch): New class.
17066         (class gdbpy_enter) <m_error_type, m_error_value,
17067         m_error_traceback>: Remove.
17068         <m_error>: New member.
17069         (gdbpy_exception_to_string): Don't declare.
17070         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17071         * python/py-value.c (convert_value_from_python): Use
17072         gdbpy_err_fetch.
17073         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17074         gdbpy_exception_to_string.
17075         (gdbpy_handle_exception): Use gdbpy_err_fetch.
17076         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17077         gdbpy_err_fetch.
17078
17079 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17080
17081         * linux-nat.c (delete_lwp_cleanup): Delete.
17082         (struct lwp_deleter): New struct.
17083         (lwp_info_up): New typedef.
17084         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17085         lwp_info_up.
17086
17087 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17088
17089         * linux-fork.c (class scoped_switch_fork_info): New class.
17090         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17091
17092 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17093
17094         * valops.c (find_overload_match): Remove use of null_cleanup, and
17095         calls to do_cleanups.
17096
17097 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17098
17099         * compile/compile-cplus-types.c
17100         (compile_cplus_instance::decl_name): Handle changes to
17101         cp_func_name.
17102         * cp-support.c (cp_func_name): Update header comment, update
17103         return type.
17104         * cp-support.h (cp_func_name): Update return type in declaration.
17105         * valops.c (find_overload_match): Move temp_func local to top
17106         level of function and change its type.  Use temp_func to hold and
17107         delete temporary string obtained from cp_func_name.
17108
17109 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17110
17111         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17112         gdb::char_vector, remove cleanup, and update uses of `msg`.
17113
17114 2019-01-03  Jim Wilson  <jimw@sifive.com>
17115
17116         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17117
17118 2019-01-02  Tom Tromey  <tom@tromey.com>
17119
17120         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17121         (tdesc_parse_xml): Remove cleanups.
17122         * target-descriptions.h (make_cleanup_free_target_description):
17123         Don't declare.
17124         (target_desc_deleter): New struct.
17125         (target_desc_up): New typedef.
17126         * target-descriptions.c (target_desc_deleter::operator()): Rename
17127         from free_target_description.
17128         (make_cleanup_free_target_description): Remove.
17129
17130 2019-01-02  Tom Tromey  <tom@tromey.com>
17131
17132         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17133         constructor, destructor.
17134         (linespec_parser): Remove typedef.
17135         (~linespec_parser): Rename from linespec_parser_delete.
17136         (linespec_lex_to_end, linespec_complete_label)
17137         (linespec_complete): Update.
17138         (decode_line_full): Remove cleanups.
17139         (decode_line_1): Update.
17140
17141 2019-01-02  Tom Tromey  <tom@tromey.com>
17142
17143         * python/python-internal.h (inferior_to_inferior_object): Change
17144         return type.
17145         * python/py-exitedevent.c (create_exited_event_object): Update.
17146         * python/py-inferior.c (inferior_to_inferior_object): Return
17147         gdbpy_ref.
17148         (python_new_inferior, python_inferior_deleted)
17149         (thread_to_thread_object, delete_thread_object)
17150         (build_inferior_list, gdbpy_selected_inferior): Update.
17151         * python/py-infthread.c (create_thread_object): Update.  Also fail
17152         if inferior_to_inferior_object fails.
17153
17154 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17155
17156         * inferior.h (class inferior) <displaced_step_state>: New field.
17157         * infrun.h (struct displaced_step_state): Move here from
17158         infrun.c.  Initialize fields, add constructor.
17159         <inf>: Remove field.
17160         <reset>: New method.
17161         * infrun.c (struct displaced_step_inferior_state): Move to
17162         infrun.h.
17163         (displaced_step_inferior_states): Remove.
17164         (get_displaced_stepping_state): Adust.
17165         (displaced_step_in_progress_any_inferior): Adjust.
17166         (displaced_step_in_progress_thread): Adjust.
17167         (displaced_step_in_progress): Adjust.
17168         (add_displaced_stepping_state): Remove.
17169         (get_displaced_step_closure_by_addr): Adjust.
17170         (remove_displaced_stepping_state): Remove.
17171         (infrun_inferior_exit): Call displaced_step_state.reset.
17172         (use_displaced_stepping): Don't check for NULL.
17173         (displaced_step_prepare_throw): Call
17174         get_displaced_stepping_state.
17175         (displaced_step_fixup): Don't check for NULL.
17176         (prepare_for_detach): Don't check for NULL.
17177
17178 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17179
17180         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17181          in case of call that did not complete.
17182
17183 2019-01-02  Andrey Utkin  <autkin@undo.io>
17184
17185         * symfile.c (find_separate_debug_file): Fix search of debug files for
17186         remote debuggee.
17187
17188 2019-01-02  Tom Tromey  <tom@tromey.com>
17189
17190         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17191         indentation.
17192         * python/py-frame.c (frapy_older): Remove cast.
17193         (frapy_newer): Likewise.
17194         * python/py-breakpoint.c (local_setattro): Remove cast.
17195         * python/py-arch.c (archpy_name): Remove local variable.
17196         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17197
17198 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17199
17200         * unittests/basic_string_view/element_access/char/empty.cc:
17201         Fix year range in copyright header.
17202
17203 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17204
17205         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17206         Delete.
17207         <operator==>: Update with for removed field.
17208         <hash>: Likewise.
17209         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17210         <isa_features>: ...this.
17211         <abi_features>: New field.
17212         (riscv_isa_flen): Update comment.
17213         (riscv_abi_xlen): New declaration.
17214         (riscv_abi_flen): New declaration.
17215         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17216         isa_features.
17217         (riscv_abi_xlen): New function.
17218         (riscv_isa_flen): Update to get answer from isa_features.
17219         (riscv_abi_flen): New function.
17220         (riscv_has_fp_abi): Update to get answer from abi_features.
17221         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17222         xlen and flen.
17223         (riscv_call_info) <xlen, flen>: Update comment.
17224         (riscv_call_arg_struct): Remove invalid assertions
17225         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17226         is removed.
17227         (riscv_gdbarch_init): Gather isa features and abi features
17228         separately, ensure both match on the gdbarch when reusing an old
17229         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17230         a target with 64-bit float hardware.
17231
17232 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17233
17234         * source.c (search_command_helper): Stop reverse search
17235         when line 1 has been searched.
17236
17237 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17238
17239         * record-full.c (record_full_base_target::close): Rewrite
17240         record_full_core_buf_list free logic.
17241
17242 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17243
17244         * break-catch-syscall.c (print_one_catch_syscall): xfree
17245         the last text.
17246
17247 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17248
17249         * top.c (print_gdb_version): Update Copyright year in version
17250         message.
17251
17252 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17253
17254         Update copyright year range in all GDB files.
17255
17256 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17257
17258         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17259
17260 For older changes see ChangeLog-2018.
17261 \f
17262 Local Variables:
17263 mode: change-log
17264 left-margin: 8
17265 fill-column: 74
17266 version-control: never
17267 coding: utf-8
17268 End:
17269