gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-layout.c (make_source_window, make_disasm_window)
   4         (make_source_or_disasm_window): Remove win_info_ptr parameter.
   5         Return the new window.
   6         (show_source_disasm_command, show_data)
   7         (show_source_or_disasm_and_command): Update.
   8
   9 2019-06-25  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
  12         parameter.  Return the new window.
  13         (show_source_disasm_command): Update and remove NULL check.
  14         (show_source_or_disasm_and_command): Update.
  15
  16 2019-06-25  Tom Tromey  <tom@tromey.com>
  17
  18         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
  19
  20 2019-06-25  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-data.h (struct tui_win_info): Make constructor
  23         protected.  Make destructor virtual.  Add initializers.
  24         (tui_source_window, tui_data_window, tui_cmd_window): New
  25         classes.
  26         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
  27         constructor.  Add "type" parameter.
  28         (tui_source_window, tui_data_window, tui_cmd_window): New
  29         constructors.
  30         (tui_alloc_win_info): Instantiate the appropriate subclass.
  31
  32 2019-06-25  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-win.c (tui_resize_all): Use delete.
  35         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
  36         destructor.
  37         (tui_free_window): Don't declare.
  38         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
  39         Update.
  40
  41 2019-06-25  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-data.h (struct tui_win_info): Add constructor.
  44         * tui/tui-data.c (tui_alloc_win_info): Use new.
  45         (tui_free_window): Use delete.
  46
  47 2019-06-22  Tom Tromey  <tom@tromey.com>
  48
  49         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
  50         declare.
  51         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
  52
  53 2019-06-22  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
  56         declare.
  57         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
  58
  59 2019-06-22  Tom de Vries  <tdevries@suse.de>
  60
  61         * dwarf2read.c (create_addrmap_from_aranges)
  62         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
  63         instead of '%zu'.
  64
  65 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
  66
  67         * dwarf2read.h (dwarf2_section_info_def): Remove.
  68         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
  69         * dwarf2read.c (struct dwo_sections) <types>: Change type to
  70         std::vector<dwarf2_section_info>.
  71         (struct dwo_file) <~dwo_file>: Remove.
  72         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
  73         types field.
  74         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
  75         (dwarf2_read_debug_names): Likewise.
  76         (create_debug_types_hash_table): Change parameter type to
  77         array_view, adjust code accordingly.
  78         (dwarf2_locate_dwo_sections): Adjust to std::vector.
  79         (partial_die_info::fixup): Likewise.
  80         (determine_prefix): Likewise.
  81         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
  82
  83 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  84
  85         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
  86         gdb_bfd_ref_ptr.
  87         <~dwo_file>: Remove call to gdb_bfd_unref.
  88         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
  89         gdb_bfd_ref_ptr::get.
  90
  91 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  92
  93         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
  94         type to htab_up.
  95         * dwarf2read.c (struct dwo_file): Initialize fields.
  96         <~dwo_file>: New.
  97         (free_dwo_file): Remove, move content to ~dwo_file.
  98         (struct dwo_file_deleter): Remove.
  99         (dwo_file_up>: Remove custom deleter.
 100         (free_dwo_files): Remove.
 101         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 102         dwo_files.
 103         (process_skeletonless_type_units): Call unique_ptr::get.
 104         (allocate_dwo_file_hash_table): Add deleter to created hash
 105         table.  Change return type to htab_up.
 106         (lookup_dwo_file_slot): Don't memset dwo_file, call
 107         unique_ptr::get.
 108         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 109         (create_dwo_unit_in_dwp_v2): Likewise.
 110         (open_and_init_dwo_file): Likewise.
 111         (free_dwo_file_from_slot): Remove.
 112
 113 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 114
 115         * dwarf2read.h (struct dwarf2_section_info) <readin,
 116         is_virtual>: Change type to bool.
 117         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 118         true instead of 1.
 119
 120 2019-06-19  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-data.h (tui_init_content_element): Don't declare.
 123
 124 2019-06-19  Tom Tromey  <tom@tromey.com>
 125
 126         * tui/tui-data.h (tui_init_win_info): Don't declare.
 127
 128 2019-06-19  Tom de Vries  <tdevries@suse.de>
 129
 130         * dwarf2read.h (abstract_to_concrete): Change type to
 131         std::unordered_map<sect_offset, std::vector<sect_offset>,
 132         gdb::hash_enum<sect_offset>>.
 133
 134 2019-06-19  Tom Tromey  <tromey@adacore.com>
 135
 136         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 137         EVAL_AVOID_SIDE_EFFECTS specially.
 138
 139 2019-06-19  Tom Tromey  <tromey@adacore.com>
 140
 141         * source-cache.c (highlighter): New global.
 142         (source_cache::get_source_lines): Create a highlighter on demand.
 143
 144 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 145
 146         * defs.h (deprecated_interactive_hook): Delete declaration.
 147         * interps.c (clear_interpreter_hooks): Remove use of
 148         deprecated_interactive_hook.
 149         * top.c (deprecated_interactive_hook): Delete definition.
 150         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 151
 152 2019-06-18  Tom de Vries  <tdevries@suse.de>
 153
 154         PR gdb/24515
 155         * dwarf2read.h (abstract_to_concrete): Change type from
 156         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 157         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 158         * dwarf2read.c (read_variable): Update.
 159         (dwarf2_fetch_die_loc_sect_off): Update.
 160
 161 2019-06-17  Tom de Vries  <tdevries@suse.de>
 162
 163         PR gdb/24617
 164         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 165         accessing parent[parent_len - 1].
 166
 167 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 168
 169         PR gdb/24364
 170         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 171         call dtrace_process_dof with NULL dof.
 172
 173 2019-06-16  Tom de Vries  <tdevries@suse.de>
 174
 175         PR gdb/24445
 176         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 177
 178 2019-06-16  Tom Tromey  <tom@tromey.com>
 179
 180         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 181         (make_all_visible): Use address of member.
 182
 183 2019-06-16  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 186         (tui_free_window, free_content, free_content_elements): Remove
 187         unnecessary cast.
 188         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 189         cast.
 190         * tui/tui-regs.c (tui_show_register_group)
 191         (tui_display_registers_from, tui_display_reg_element_at_line):
 192         Remove unnecessary cast.
 193
 194 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 195
 196         * linux-nat.c (normal_mask): Delete.
 197         (_initialize_linux_nat): Don't initialise normal_mask.
 198
 199 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 200
 201         PR gdb/24445
 202         * dwarf-index-write.h (write_psymtabs_to_index): Add
 203         dwz_basename parameter.
 204         * dwarf-index-write.c (write_gdbindex): Move file writing to
 205         write_gdbindex_1.  Change return type void.
 206         (assert_file_size): Move up, remove filename parameter.
 207         (write_gdbindex_1): New function.
 208         (write_debug_names): Change return type to void, call
 209         assert_file_size.
 210         (struct index_wip_file): New struct.
 211         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 212         file logic to index_wip_file.  Write index for dwz file if
 213         needed.
 214         (save_gdb_index_command): Pass basename of dwz file, if present.
 215         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 216         build-id of dwz file, if present.
 217         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 218         (dwarf2_get_dwz_file): Likewise.
 219         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 220         (dwarf2_get_dwz_file): Likewise.
 221
 222 2019-06-16  Tom Tromey  <tom@tromey.com>
 223
 224         * coffread.c (process_coff_symbol): Use xstrdup.
 225         * value.c (create_internalvar): Use xstrdup.
 226
 227 2019-06-16  Tom Tromey  <tom@tromey.com>
 228
 229         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 230         * breakpoint.c (stopin_command, stopat_command)
 231         (until_break_command, decode_location_default): Remove unnecessary
 232         cast.
 233         * utils.c (subset_compare): Remove unnecessary cast.
 234         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 235         cast.
 236         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 237         cast.
 238         * infcmd.c (path_command): Remove unnecessary cast.
 239         * coffread.c (decode_type): Remove unnecessary cast.
 240         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 241         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 242         * tui/tui-stack.c (tui_show_locator_content)
 243         (tui_show_frame_info): Remove unnecessary cast.
 244         * tui/tui-win.c (tui_scroll_forward_command)
 245         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 246         (parse_scrolling_args): Remove unnecessary cast.
 247         * tui/tui-data.c (init_win_info, tui_del_window)
 248         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 249         (free_content_elements): Remove unnecessary cast.
 250         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 251         unnecessary cast.
 252         * tui/tui-source.c (tui_set_source_content)
 253         (tui_vertical_source_scroll): Remove unnecessary cast.
 254         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 255         cast.
 256         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 257         * tui/tui-regs.c (tui_display_registers_from)
 258         (tui_display_register): Remove unnecessary cast.
 259         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 260         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 261         (make_visible): Remove unnecessary cast.
 262         * tui/tui-winsource.c (tui_erase_source_content)
 263         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 264         unnecessary cast.
 265         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 266         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 267         * stabsread.c (read_type, read_array_type, read_range_type):
 268         Remove unnecessary cast.
 269         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 270         (parse_symbol, parse_type, upgrade_type, parse_external)
 271         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 272         unnecessary cast.
 273         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 274
 275 2019-06-16  Tom Tromey  <tom@tromey.com>
 276
 277         * tui/tui-data.c (tui_alloc_generic_win_info)
 278         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 279         checks.
 280
 281 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 282             Andrew Burgess  <andrew.burgess@embecosm.com>
 283
 284         * f-typeprint.c (f_print_type): Don't return early for not
 285         associated or not allocated types.
 286         (f_type_print_varspec_suffix): Add print_rank parameter and print
 287         ranks of array types in case they dangling.
 288         (f_type_print_base): Add print_rank parameter.
 289
 290 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 291
 292         * NEWS: Mention new MI commands.
 293         * break-catch-throw.c (enum exception_event_kind): Move to
 294         breakpoint.h.
 295         (print_mention_exception_catchpoint): Output text as a single
 296         message.
 297         (catch_exception_command_1): Rename to...
 298         (catch_exception_event): ...this, make non-static, update header
 299         command, and change some parameter types.
 300         (catch_catch_command): Update for changes to
 301         catch_exception_command_1.
 302         (catch_throw_command): Likewise.
 303         (catch_rethrow_command): Likewise.
 304         * breakpoint.c (enum exception_event_kind): Delete.
 305         * breakpoint.h (enum exception_event_kind): Moved here from
 306         break-catch-throw.c.
 307         (catch_exception_event): Declare.
 308         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 309         (mi_cmd_catch_throw): New function.
 310         (mi_cmd_catch_rethrow): New function.
 311         (mi_cmd_catch_catch): New function.
 312         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 313         'catch-catch' entries.
 314         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 315         (mi_cmd_catch_rethrow): Declare.
 316         (mi_cmd_catch_catch): Declare.
 317
 318 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 319
 320         * annotate.c (annotate_source_line): Change return type to void,
 321         update implementation to match.
 322         * annotate.h (annotate_source_line): Change return type to void,
 323         update header comment.
 324         * stack.c (print_frame_info): Don't change what frame information
 325         is printed based on whether annotations are on or not.
 326
 327 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 330         (annotate_source): Make static.
 331         (annotate_source_line): Moved from source.c and renamed from
 332         identify_source_line.  Update the return type.
 333         * annotate.h (annotate_source): Delete declaration.
 334         (annotate_source_line): Declaration moved from source.h, and
 335         renamed from identify_source_line.  Return type updated.
 336         * source.c (identify_source_line): Moved to annotate.c and renamed
 337         to annotate_source_line.
 338         (info_line_command): Remove check of annotation_level.
 339         * source.h (identify_source_line): Move declaration to annotate.h
 340         and rename to annotate_source_line.
 341         * stack.c: Add 'annotate.h' include.
 342         (print_frame_info): Remove check of annotation_level before
 343         calling annotate_source_line.
 344
 345 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 346
 347         * source-cache.c (source_cache::get_plain_source_lines): Use
 348         open_source_file_with_line_charpos instead of just
 349         open_source_file, remove call to find_source_lines.
 350         (source_cache::get_source_lines): Likewise.
 351         * source.c (find_source_lines): Make static.
 352         (get_filename_and_charpos): Renamed into...
 353         (open_source_file_with_line_charpos): ..this along with changes to
 354         return a scoped_fd, and some other minor clean ups.
 355         (identify_source_line): Use open_source_file_with_line_charpos.
 356         (search_command_helper): Use open_source_file_with_line_charpos
 357         instead of just open_source_file, remove call to
 358         find_source_lines.
 359         * source.h (open_source_file_with_line_charpos): Declare new
 360         function.
 361         (find_source_lines): Delete declaration.
 362
 363 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 364
 365         * source.c (get_filename_and_charpos): Remove fullname
 366         parameter.
 367         (identify_source_line): Update call to get_filename_and_charpos.
 368
 369 2019-06-14  Tom Tromey  <tromey@adacore.com>
 370
 371         PR gdb/24502:
 372         * ui-style.h (skip_ansi_escape): Update comment.
 373         * ui-file.h (class no_terminal_escape_file): New class.
 374         * ui-file.c (no_terminal_escape_file::write)
 375         (no_terminal_escape_file::puts): New methods.
 376         * cli/cli-logging.c (handle_redirections): Use
 377         no_terminal_escape_file.
 378
 379 2019-06-14  Tom Tromey  <tromey@adacore.com>
 380
 381         * NEWS: Move convenience variable news above Python news.
 382
 383 2019-06-14  Tom Tromey  <tom@tromey.com>
 384
 385         * gnulib: Move directory to top-level.
 386         * configure.ac: Don't configure gnulib.
 387         * configure: Rebuild.
 388         * common/common-defs.h: Use new path to gnulib.
 389         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 390         (GNULIB_H): Remove.
 391         (INCGNU): Look in new gnulib location.
 392         (HFILES_NO_SRCDIR): Remove gnulib files.
 393         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 394         (generated_files): Remove GNULIB_H.
 395         ($(LIBGNU), all-lib): Remove targets.
 396         (distclean): Don't mention GNULIB_BUILDDIR.
 397         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 398
 399 2019-06-14  Tom Tromey  <tromey@adacore.com>
 400
 401         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 402         Warn if symbol file does not provide any symbols.
 403
 404 2019-06-14  Tom Tromey  <tromey@adacore.com>
 405
 406         * source.c (find_and_open_source): Respect basenames_may_differ.
 407
 408 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * annotate.c (annotate_breakpoints_invalid): Make use of
 411         scoped_restore_terminal_state.
 412         (annotate_frames_invalid): Likewise.
 413
 414 2019-06-14  Tom Tromey  <tromey@adacore.com>
 415
 416         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 417         allow assignment to an internalvar.
 418
 419 2019-06-14  Tom Tromey  <tromey@adacore.com>
 420
 421         * ada-lex.l: Allow "_" in attribute names.
 422
 423 2019-06-14  Tom Tromey  <tromey@adacore.com>
 424
 425         PR gdb/24653:
 426         * regcache.c (registers_changed): Don't call alloca.
 427         * top.c (execute_command): Don't call alloca.
 428
 429 2019-06-13  Pedro Alves  <palves@redhat.com>
 430
 431         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 432         'expression'.  When parsing an expression, error out if there's
 433         junk after "unlimited".
 434         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 435         (do_set_command): Adjust calls to is_unlimited_literal.
 436
 437 2019-06-13  Pedro Alves  <palves@redhat.com>
 438
 439         * compile/compile.c (make_compile_options_def_group): Add braces
 440         around array_view initializer.
 441         * thread.c (make_thread_apply_all_options_def_group)
 442         (make_thread_apply_all_options_def_group): Likewise.
 443
 444 2019-06-13  Pedro Alves  <palves@redhat.com>
 445
 446         * NEWS (New commands): Mention "maint test-options
 447         require-delimiter", "maint test-options unknown-is-error", "maint
 448         test-options unknown-is-operand" and "maint show
 449         test-options-completion-result".
 450         (New command options, command completion): New section.
 451         (Completion improvements): New section.
 452         Mention that you can abbreviate "unlimited".
 453
 454 2019-06-13  Pedro Alves  <palves@redhat.com>
 455
 456         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 457         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 458         * unittests/cli-utils-selftests.c (test_parse_flags)
 459         (test_parse_flags_qcs): Delete.
 460         (test_cli_utils): Don't call deleted functions.
 461
 462 2019-06-13  Pedro Alves  <palves@redhat.com>
 463
 464         * thread.c: Include "cli/cli-option.h".
 465         (tp_array_compar_ascending): Global.
 466         (tp_array_compar): Delete function.
 467         (tp_array_compar_ascending, tp_array_compar_descending): New
 468         functions.
 469         (ascending_option_def, qcs_flag_option_def)
 470         (thr_qcs_flags_option_defs)
 471         (make_thread_apply_all_options_def_group)
 472         (make_thread_apply_options_def_group): New.
 473         (thread_apply_all_command): Use gdb::option::process_options.
 474         (thread_apply_command_completer)
 475         (thread_apply_all_command_completer): New.
 476         (thread_apply_command): Use gdb::option::process_options.
 477         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 478         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 479         to generate help text of "thread apply".  Adjust "taas"'s help.
 480         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 481         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 482
 483 2019-06-13  Pedro Alves  <palves@redhat.com>
 484
 485         * thread.c (thread_apply_command): Check for invalid TID with
 486         isdigit instead of !isalpha.
 487
 488 2019-06-13  Pedro Alves  <palves@redhat.com>
 489
 490         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 491         (validate_flags_qcs): New.
 492         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 493         (validate_flags_qcs): Declare.
 494         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 495         (make_frame_apply_options_def_group): New.
 496         (frame_apply_command_count): Process options with
 497         gdb::option::process_options.
 498         (frame_apply_completer): New.
 499         (frame_apply_level_completer, frame_apply_all_completer)
 500         (frame_apply_completer): New.
 501         (_initialize_stack): Update help of "frame apply", "frame apply
 502         level", "frame apply all" and "faas" to mention supported options
 503         and install command completers.
 504         * stack.h (frame_apply_all_completer): Declare.
 505         * thread.c: Include "stack.h".
 506         (tfaas_command): Add "--".
 507         (_initialize_thread): Update help "tfaas" to mention supported
 508         options and install command completer.
 509
 510 2019-06-13  Pedro Alves  <palves@redhat.com>
 511
 512         * completer.c (complete_nested_command_line): New.
 513         (gdb_completion_word_break_characters_throw): Add assertion.
 514         * completer.h (complete_nested_command_line): Declare.
 515
 516 2019-06-13  Pedro Alves  <palves@redhat.com>
 517
 518         * stack.c (parse_backtrace_qualifiers): New.
 519         (backtrace_command): Use it.
 520         (backtrace_command_completer): Complete on qualifiers.
 521
 522 2019-06-13  Pedro Alves  <palves@redhat.com>
 523
 524         * frame.c: Include "cli/cli-option.h.
 525         (user_set_backtrace_options): New.
 526         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 527         Delete.
 528         (get_prev_frame): Adjust.
 529         (boolean_option_def, uinteger_option_def)
 530         (set_backtrace_option_defs): New.
 531         (_initialize_frame): Adjust and use
 532         gdb::option::add_setshow_cmds_for_options to install "set
 533         backtrace past-main" and "set backtrace past-entry".
 534         * frame.h: Include "cli/cli-option.h".
 535         (struct frame_print_options): Forward declare.
 536         (print_frame_arguments_all, print_frame_arguments_scalars)
 537         (print_frame_arguments_none): Declare.
 538         (print_entry_values): Delete declaration.
 539         (struct frame_print_options, user_frame_print_options): New.
 540         (struct set_backtrace_options): New.
 541         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 542         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 543         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 544         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 545         (list_args_or_locals): Add frame_print_options parameter.
 546         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 547         * python/py-framefilter.c (enumerate_args): Pass down
 548         USER_FRAME_PRINT_OPTIONS.
 549         * stack.c: Include "cli/cli-option.h".
 550         (print_frame_arguments_all, print_frame_arguments_scalars)
 551         (print_frame_arguments_none): Declare.
 552         (print_raw_frame_arguments, print_entry_values): Delete.
 553         (user_frame_print_options): New.
 554         (boolean_option_def, enum_option_def, frame_print_option_defs):
 555         New.
 556         (struct backtrace_cmd_options): New.
 557         (bt_flag_option_def): New.
 558         (backtrace_command_option_defs): New.
 559         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 560         (print_frame_arg, read_frame_arg, print_frame_args)
 561         (print_frame_info, print_frame): Add frame_print_options parameter
 562         and use it.
 563         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 564         (backtrace_command_1): Add frame_print_options and
 565         backtrace_cmd_options parameters and use them.
 566         (make_backtrace_options_def_group): New.
 567         (backtrace_command): Process command options with
 568         gdb::option::process_options.
 569         (backtrace_command_completer): New.
 570         (_initialize_stack): Extend "backtrace"'s help to mention
 571         supported options.  Install completer for "backtrace".
 572         Install some settings commands with add_setshow_cmds_for_options.
 573
 574 2019-06-13  Pedro Alves  <palves@redhat.com>
 575
 576         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 577         and that "set/show print raw frame-arguments" are now deprecated.
 578
 579         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 580         command.
 581         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 582         * stack.c (_initialize_stack): Install "set/show print
 583         raw-frame-arguments", and deprecate "set/show print raw
 584         frame-arguments".
 585         * valprint.c (_initialize_valprint): Deprecate "set/show print
 586         raw".
 587
 588 2019-06-13  Pedro Alves  <palves@redhat.com>
 589
 590         * compile/compile.c (struct compile_options): New.
 591         (compile_flag_option_def, compile_command_option_defs)
 592         (make_compile_options_def_group): New.
 593         (compile_file_command): Handle options with
 594         gdb::option::process_options.
 595         (compile_file_command_completer): New function.
 596         (compile_code_command): Handle options with
 597         gdb::option::process_options.
 598         (compile_code_command_completer): New function.
 599         (_initialize_compiler): Install completers for "compile code" and
 600         "compile file".  Mention available options in "compile code" and
 601         "compile code"'s help.
 602         * completer.c (advance_to_completion_word): New, factored out from
 603         ...
 604         (advance_to_expression_complete_word_point): ... this.
 605         (advance_to_filename_complete_word_point): New.
 606         * completer.h (advance_to_filename_complete_word_point): New
 607         declaration.
 608
 609 2019-06-13  Pedro Alves  <palves@redhat.com>
 610
 611         * compile/compile.c: Include "cli/cli-option.h".
 612         (compile_print_value): Scope data pointer is now a
 613         value_print_options pointer; adjust.
 614         (compile_print_command): Process options.  Scope data pointer is
 615         now a value_print_options pointer; adjust.
 616         (_initialize_compile): Update "compile print"'s help to include
 617         supported options.  Install a completer for "compile print".
 618         * cp-valprint.c (show_vtblprint, show_objectprint)
 619         (show_static_field_print): Delete.
 620         (_initialize_cp_valprint): Don't install "set print
 621         static-members", "set print vtbl", "set print object" here.
 622         * printcmd.c: Include "cli/cli-option.h" and
 623         "common/gdb_optional.h".
 624         (print_command_parse_format): Rework to fill in a
 625         value_print_options instead of a format_data.
 626         (print_value): Change parameter type from format_data pointer to
 627         value_print_options reference.  Adjust.
 628         (print_command_1): Process options.  Adjust to pass down a
 629         value_print_options.
 630         (print_command_completer): New.
 631         (_initialize_printcmd): Install print_command_completer as
 632         handle_brkchars completer for the "print" command.  Update
 633         "print"'s help to include supported options.
 634         * valprint.c: Include "cli/cli-option.h".
 635         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 636         here from cp-valprint.c.
 637         (boolean_option_def, uinteger_option_def)
 638         (value_print_option_defs, make_value_print_options_def_group):
 639         New.  Use gdb::option::add_setshow_cmds_for_options to install
 640         "set print elements", "set print null-stop", "set print repeats",
 641         "set print pretty", "set print union", "set print array", "set
 642         print address", "set print symbol", "set print array-indexes".
 643         * valprint.h: Include <string> and "cli/cli-option.h".
 644         (make_value_print_options_def_group): Declare.
 645         (print_value): Change parameter type from format_data pointer to
 646         value_print_options reference.
 647         (print_command_completer): Declare.
 648
 649 2019-06-13  Pedro Alves  <palves@redhat.com>
 650
 651         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 652         (COMMON_SFILES): Add maint-test-settings.c.
 653         * cli/cli-decode.c (boolean_enums): New global, factored out from
 654         ...
 655         (add_setshow_boolean_cmd): ... here.
 656         * cli/cli-decode.h (boolean_enums): Declare.
 657         * cli/cli-option.c: New file.
 658         * cli/cli-option.h: New file.
 659         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 660         factored out from ...
 661         (parse_cli_boolean_value(const char *)): ... this.
 662         (is_unlimited_literal): Change parameter type to pointer to
 663         pointer.  Adjust and advance ARG pointer.
 664         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 665         (parse_cli_var_enum): New, factored out from ...
 666         (do_set_command): ... this.  Adjust.
 667         * cli/cli-setshow.h (parse_cli_boolean_value)
 668         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 669         (parse_cli_var_enum): Declare.
 670         * cli/cli-utils.c: Include "cli/cli-option.h".
 671         (get_ulongest): New.
 672         * cli/cli-utils.h (get_ulongest): Declare.
 673         (check_for_argument): New overloads.
 674         * maint-test-options.c: New file.
 675
 676 2019-06-13  Pedro Alves  <palves@redhat.com>
 677
 678         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 679         parse a range if "-" is at the end of the string.
 680
 681 2019-06-13  Pedro Alves  <palves@redhat.com>
 682
 683         * cli/cli-setshow.c (parse_auto_binary_operation)
 684         (parse_cli_boolean_value): Don't allow "o".
 685
 686 2019-06-13  Pedro Alves  <palves@redhat.com>
 687
 688         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 689         * NEWS: Mention maint test-settings KIND.
 690         * maint-test-settings.c: New file.
 691
 692 2019-06-13  Pedro Alves  <palves@redhat.com>
 693
 694         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 695         completer.
 696         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 697         "set" completers.
 698
 699 2019-06-13  Pedro Alves  <palves@redhat.com>
 700
 701         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 702         after item.
 703
 704 2019-06-13  Pedro Alves  <palves@redhat.com>
 705
 706         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 707
 708 2019-06-13  Pedro Alves <palves@redhat.com>
 709
 710         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 711         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 712         call.
 713         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 714         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 715         calls.
 716         (check_for_argument): Skip spaces after argument.
 717
 718 2019-06-13  Pedro Alves  <palves@redhat.com>
 719
 720         * thread.c (thread_apply_command): Adjust TID parsing.
 721         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 722         detected before end of string.
 723         (tid_is_in_list): Error out if LIST is invalid.
 724
 725 2019-06-13  Pedro Alves  <palves@redhat.com>
 726
 727         * completer.c (complete_line_internal_1): Rewind completion word
 728         point.
 729         (completion_tracker::advance_custom_word_point_by): Change
 730         parameter type to int.
 731         * completer.h (completion_tracker::advance_custom_word_point_by):
 732         Likewise.
 733
 734 2019-06-13  Pedro Alves  <palves@redhat.com>
 735
 736         * completer.c (advance_to_completion_word): Handle delimiters.
 737
 738 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 739
 740         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 741
 742 2019-06-11  Tom Tromey  <tom@tromey.com>
 743
 744         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 745         (xmalloc_failed): Move to alloc.c.
 746         * alloc.c: New file.
 747         * Makefile.in (COMMON_SFILES): Add alloc.c.
 748
 749 2019-06-11  Tom Tromey  <tom@tromey.com>
 750
 751         * nat/linux-waitpid.c: Don't include server.h.
 752         (linux_debug): Remove.
 753         (my_waitpid): Update.
 754
 755 2019-06-11  Tom Tromey  <tromey@adacore.com>
 756
 757         * infcall.c (_initialize_infcall): Remove trailing newline from
 758         help.
 759         * user-regs.c (_initialize_user_regs): Remove trailing newline
 760         from help.
 761         * typeprint.c (_initialize_typeprint): Remove trailing newline
 762         from help.
 763         * reverse.c (_initialize_reverse): Remove trailing newlines from
 764         help.
 765         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 766         from help.
 767         * language.c (add_set_language_command): Remove trailing newline
 768         from help.
 769         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 770         help.
 771         * disasm.c (_initialize_disasm): Remove trailing newline from
 772         help.
 773         * top.c (init_main): Remove trailing newline from help.
 774         * interps.c (_initialize_interpreter): Remove trailing newline
 775         from help.
 776         * btrace.c (_initialize_btrace): Remove trailing newlines from
 777         help.
 778         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 779         from help.
 780         * python/python.c (_initialize_python): Remove trailing newline
 781         from help.
 782         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 783         help.
 784         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 785         from help.  Reformat some text.
 786         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 787         from help.
 788         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 789         newline from help.
 790
 791 2019-06-11  Tom Tromey  <tromey@adacore.com>
 792
 793         * darwin-nat.c (darwin_decode_exception_message)
 794         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 795
 796 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * valops.c (value_slice): Check for not allocated or not
 799         associated values.
 800
 801 2019-06-10  Tom de Vries  <tdevries@suse.de>
 802
 803         PR gdb/24618
 804         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 805         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 806         invalid.
 807
 808 2019-06-10  Tom de Vries  <tdevries@suse.de>
 809
 810         PR gdb/24611
 811         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 812         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 813
 814 2019-06-10  Tom de Vries  <tdevries@suse.de>
 815
 816         PR symtab/24545
 817         * symtab.c (struct demangled_name_entry): Add language field.
 818         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 819         static minimal symbol".  Set and use language field.
 820
 821 2019-06-10  Tom Tromey  <tromey@adacore.com>
 822
 823         * ada-lang.c (_initialize_ada_language): Update help text.
 824
 825 2019-06-10  Tom Tromey  <tromey@adacore.com>
 826
 827         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 828         with a newline.
 829         * guile/guile.c (handle_boot_error): Don't end warning with a
 830         newline.
 831         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 832         warning with a newline.
 833         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 834         newline.
 835         (s12z_frame_cache): Likewise.
 836         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 837         a newline.
 838         * solib-svr4.c (disable_probes_interface): Don't end warning with
 839         a newline.
 840         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 841         newline.
 842         * python/python.c (do_finish_initialization): Don't end warning
 843         with a newline.
 844
 845 2019-06-10  Tom Tromey  <tom@tromey.com>
 846
 847         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 848         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 849         gdbpy_enter.
 850
 851 2019-06-10  Tom Tromey  <tromey@adacore.com>
 852
 853         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 854         data.
 855         (elf_new_init): Don't call stabsread_new_init.
 856         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 857         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 858         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 859
 860 2019-06-10  Tom de Vries  <tdevries@suse.de>
 861
 862         PR symtab/16264
 863         PR symtab/24517
 864         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 865
 866 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 867
 868         * source.c (find_and_open_source): Also rewrite relative file
 869         names.
 870
 871 2019-04-26  Amos Bird  <amosbird@gmail.com>
 872
 873         * annotate.c (annotate_thread_exited): Add "thread-exited"
 874         annotation.
 875
 876 2019-06-06  Tom Tromey  <tromey@adacore.com>
 877
 878         * maint.h (class scoped_command_stats): Use
 879         DISABLE_COPY_AND_ASSIGN.
 880         <print_time>: New method.
 881         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 882         print_time.
 883         (scoped_command_stats::print_time): New method.
 884
 885 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 888         instructions of lengths 6 or 8 bytes.
 889
 890 2019-06-04  Pedro Alves  <palves@redhat.com>
 891
 892         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 893
 894         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 895         * breakpoint.c (condition_completer): Likewise.
 896         * cli/cli-dump.c (scan_expression): Likewise.
 897         * common/filestuff.c (mkdir_recursive): Likewise.
 898         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 899         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 900         (gdb_abspath): Likewise.
 901         * compile/compile-cplus-types.c
 902         (compile_cplus_instance::decl_name): Likewise.
 903         * completer.c (complete_explicit_location):
 904         (signal_completer, reg_or_group_completer_1): Likewise.
 905         * cp-support.c (cp_remove_params_if_any): Likewise.
 906         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 907         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 908         * infcmd.c (strip_bg_char): Likewise.
 909         * linespec.c (copy_token_string): Likewise.
 910         * mi/mi-main.c (output_cores): Likewise.
 911         * psymtab.c (psymtab_search_name):
 912         * symfile.c (test_set_ext_lang_command): Likewise.
 913         * target.c (target_fileio_read_stralloc): Likewise.
 914         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 915         * value.c (complete_internalvar): Likewise.
 916
 917 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 918
 919         Add objfile property to gdb.Type.
 920         * NEWS: Mention Python API addition.
 921         * python/py-type.c (typy_get_objfile): New method.
 922
 923 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 924
 925         * NEWS: Mention the new set|show style [title|highlight].
 926         Mention changes to "show style", "help" and "apropos".
 927
 928 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 929
 930         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 931         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 932         instead of print_help_for_command.
 933         (print_doc_of_command): New function.
 934         (help_list): Add 'apropos -v word' suggestion.
 935         (print_help_for_command): Style the command name using title style.
 936         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 937         (_initialize_cli_cmds): Describe -v in apropos_command help.
 938
 939 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 940
 941         * cli/cli-style.h (cli_style_option): Add name in constructor,
 942         add m_name class member, add constructor with intensity,
 943         add name class function.
 944         (cli_style_option::add_setshow_commands): Remove name argument.
 945         (highlight_style, title_style): New styles.
 946         * cli/cli-style.c (do_show): New function that shows a style
 947         characteristic styling the style name with itself.
 948         (set_style_name): New function.
 949         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 950         Update all callers according to the changes in cli/cli-style.h.
 951         * utils.h (fputs_highlighted): New function.
 952         * utils.c (fputs_highlighted): Likewise.
 953
 954 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 955
 956         * NEWS: Mention new pipe command and new convenience variables.
 957
 958 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 959
 960         * cli/cli-cmds.c (pipe_command): New function.
 961         (_initialize_cli_cmds): Call add_com for pipe_command.
 962         Define | as an alias for pipe.
 963         (exit_status_set_internal_vars): New function.
 964         (shell_escape): Call exit_status_set_internal_vars.
 965         cli/cli-decode.c (find_command_name_length): Recognize | as
 966         a single character command.
 967
 968 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 969
 970         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 971         top.c (execute_command_to_ui_file): New function, mostly a copy
 972         of execute_command_to_string.
 973         (execute_command_to_string): Implement by calling
 974         execute_command_to_ui_file.
 975
 976 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 977
 978         * top.h (saved_command_line): Remove declaration.
 979         * top.c (previous_saved_command_line, previous_repeat_arguments):
 980         New variables.
 981         (saved_command_line): Make static, define together with other
 982         'repeat variables'.
 983         (dont_repeat): Clear repeat_arguments.
 984         (repeat_previous, get_saved_command_line, save_command_line):
 985         New functions.
 986         (gdb_init): Initialize saved_command_line
 987         and previous_saved_command_line.
 988         * main.c (captured_main_1): Remove saved_command_line initialization.
 989         * event-top.c (handle_line_of_input): Update to use
 990         the new 'repeat' related functions instead of direct access to
 991         saved_command_line.
 992         * command.h (repeat_previous, get_saved_command_line,
 993         save_command_line): New declarations.
 994         (dont_repeat): Add comment.
 995
 996 2019-05-30  Tom Tromey  <tromey@adacore.com>
 997
 998         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 999         Fix comment.
1000         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1001
1002 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1003
1004         PR cli/24587
1005         * completer.c (complete): Initialize variable word.
1006
1007 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1008
1009         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1010         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1011         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1012         'body' is NULL to the outter 'if', protecting the '!is_define'
1013         situation as well.
1014
1015 2019-05-29  Tom Tromey  <tromey@adacore.com>
1016
1017         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1018         (dwarf_unknown): New function.
1019         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1020         (dwarf_type_encoding_name): Use dwarf_unknown.
1021
1022 2019-05-29  Tom Tromey  <tromey@adacore.com>
1023
1024         PR c++/20020:
1025         * cp-valprint.c (cp_print_value_fields): Call
1026         cp_print_static_field inside "try".
1027
1028 2019-05-29  Tom Tromey  <tromey@adacore.com>
1029
1030         * inflow.c (struct terminal_info): Add default operator=.
1031         * configure: Rebuild.
1032         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1033         -Wdeprecated-copy-dtor, -Wredundant-move.
1034
1035 2019-05-29  Tom Tromey  <tromey@adacore.com>
1036
1037         * NEWS: Add entry.
1038         * infcmd.c (print_return_value_1): Handle finish_print
1039         option.
1040         (show_print_finish): New function.
1041         (_initialize_infcmd): Add "set/show print finish" commands.
1042         * valprint.c (user_print_options): Initialize new member.
1043         * valprint.h (struct value_print_options) <finish_print>: New
1044         member.
1045
1046 2019-05-28  Tom Tromey  <tromey@adacore.com>
1047
1048         * ada-lang.c (ada_remove_Xbn_suffix)
1049         (find_old_style_renaming_symbol)
1050         (parse_old_style_renaming): Remove.
1051         (ada_find_renaming_symbol): Don't call
1052         find_old_style_renaming_symbol.
1053         (ada_is_renaming_symbol): Rename from
1054         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1055         bool.  Now static.
1056         (ada_read_var_value): Update and simplify.
1057         * ada-exp.y (write_var_or_type): Remove old code.
1058
1059 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1060
1061         * event-top.c: Remove include comment.
1062         * inflow.c (class scoped_ignore_sigttou): Move from here...
1063         * inflow.h (class scoped_ignore_sigttou): ...to here.
1064         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1065         * top.c:  Remove include comment.
1066
1067 2019-05-27  Tom Tromey  <tom@tromey.com>
1068
1069         * NEWS: Fix typo.
1070
1071 2019-05-22  Tom Tromey  <tromey@adacore.com>
1072
1073         * target.c (target_follow_exec): Constify parameter.
1074         * target-delegates.c: Rebuild.
1075         * remote.c (remote_target::follow_exec): Constify parameter.
1076         * infrun.c (follow_exec): Constify parameter.
1077         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1078         (target_follow_exec): Likewise.
1079
1080 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1081
1082         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1083         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1084
1085 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1086
1087         * NEWS: Add debugredirect and testsuite sections.
1088
1089 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1090
1091         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1092         target descriptions using exclusively floating point register name
1093         aliases.
1094
1095 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         PR gdb/18644:
1098         * f-lang.c (build_fortran_types): Handle the case where
1099         gdbarch_floatformat_for_type returns a nullptr.
1100
1101 2019-05-21  Tom de Vries  <tdevries@suse.de>
1102
1103         PR cli/24587
1104         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1105
1106 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1107
1108         PR gdb/18644:
1109         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1110         16-byte floats.
1111         * i386-tdep.c (i386_floatformat_for_type): Use
1112         floatformats_ia64_quad for the 16-byte floating point component
1113         within a fortran 32-byte complex number.
1114
1115 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1116
1117         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1118         delete default constructor.
1119         (find_partial_die): Update to return const struct.
1120         (partial_die_parent_scope): Move variable declaration into scope
1121         of its use and change its type to auto.
1122         (guess_partial_die_structure_name): Likewise.
1123         (partial_die_info::fixup): Likewise.
1124
1125 2019-05-17  Tom Tromey  <tromey@adacore.com>
1126
1127         * source.c (find_and_open_source): Remove cast.
1128
1129 2019-05-17  Tom Tromey  <tromey@adacore.com>
1130
1131         * annotate.c (annotate_source): Make "filename" const.
1132         * annotate.h (annotate_source): Use const.
1133
1134 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1135
1136         * disasm.c (set_disassembler_options): Send errors to stderr.
1137
1138 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1139
1140         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1141         (cli_interp_base::set_logging): Check debug_redirect.
1142         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1143         * cli/cli-logging.c (debug_redirect): Add static variable.
1144         (pop_output_files): Add default param.
1145         (handle_redirections): Print debug setting.
1146         (show_logging_command): Likewise.
1147         (_initialize_cli_logging): Add debugredirect command.
1148         * interps.c (current_interp_set_logging): Add debug_redirect
1149         parameter.
1150         * interps.h (set_logging): Add debug_redirect parameter.
1151         (current_interp_set_logging): Likewise.
1152         * mi/mi-common.h: Likewise.
1153         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1154
1155 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1156             Tom Tromey  <tromey@adacore.com>
1157
1158         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1159         directly.
1160         * cli/cli-interp.h (make_logging_output): Remove declaration.
1161         * cli/cli-logging.c (make_logging_output): Remove function.
1162         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1163         directly.
1164         * ui-file.c (tee_file::tee_file): Remove bools.
1165         (tee_file::~tee_file): Remove deletes.
1166         * ui-file.h (tee_file): Remove bools.
1167
1168 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1169
1170         * mi/mi-cmds.h (mi_cmd_complete): New function.
1171         * mi/mi-main.c (mi_cmd_complete): Likewise.
1172         * mi/mi-cmds.c: Define new MI command -complete.
1173         * NEWS: Mention new -complete command.
1174
1175 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1176
1177         * completer.h (complete): New function.
1178         * completer.c (complete): Likewise.
1179         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1180         function defined in completer.h.
1181
1182 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1183
1184         * MAINTAINERS (Write After Approval): Add myself.
1185
1186 2019-05-17  Tom de Vries  <tdevries@suse.de>
1187
1188         PR gdb/24094
1189         * dwarf2read.c (struct cu_partial_die_info): New struct.
1190         (find_partial_die): Return cu_partial_die_info.
1191         (partial_die_parent_scope, guess_partial_die_structure_name)
1192         (partial_die_info::fixup): Handle new return type of find_partial_die.
1193
1194 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1195
1196         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1197         "std::string", simplifying the algorithm.
1198
1199 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1200
1201         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1202         (stap_static_probe_ops::get_probes): Likewise.
1203
1204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1205
1206         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1207         '-')" and "else if".
1208         (stap_parse_single_operand): Join checks for
1209         "gdbarch_stap_parse_special_token_p" and
1210         "gdbarch_stap_parse_special_token" in the same "if" statement.
1211         Invert check when verifying for operation on register
1212         displacement.
1213
1214 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1215
1216         * stap-probe.c (stap_get_opcode): Update comment.
1217         (stap_get_expected_argument_type): Likewise.
1218         (handle_stap_probe): Likewise.
1219
1220 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1221
1222         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1223         return type to 'bool'.  Adjust comment.  Use 'bool' when
1224         appropriate.
1225         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1226         * stap-probe.c (stap_parse_argument_1): Likewise.
1227         (stap_is_operator): Likewise.
1228         (stap_is_generic_prefix): Likewise.
1229         (stap_is_register_prefix): Likewise.
1230         (stap_is_register_indirection_prefix): Likewise.
1231         (stap_is_integer_prefix): Likewise.
1232         (stap_generic_check_suffix): Likewise.
1233         (stap_check_integer_suffix): Likewise.
1234         (stap_check_register_suffix): Likewise.
1235         (stap_check_register_indirection_suffix): Likewise.
1236         (stap_parse_register_operand): Likewise.
1237         (stap_parse_single_operand): Likewise.
1238         (stap_parse_argument_1): Likewise.
1239         (stap_probe::get_argument_count): Likewise.
1240         (stap_is_operator): Likewise.
1241
1242 2019-05-16  Tom Tromey  <tromey@adacore.com>
1243
1244         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1245         keyword to foreach.
1246
1247 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1248
1249         * linux-thread-db.c (try_thread_db_load_1): Change return type
1250         to bool.
1251         (try_thread_db_load): Likewise.
1252         (try_thread_db_load_from_pdir_1): Likewise.
1253         (try_thread_db_load_from_pdir): Likewise.
1254         (try_thread_db_load_from_sdir): Likewise.
1255         (try_thread_db_load_from_dir): Likewise.
1256         (thread_db_load_search): Likewise.
1257         (has_libpthread): Likewise.
1258         (thread_db_load): Likewise.
1259
1260 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1261
1262         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1263         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1264         NULL, and complain/return if that's the case.
1265
1266 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1267
1268         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1269         (advance, posn, abstract_read_memory): New functions.
1270         [struct mem_read_abstraction]: New struct.
1271         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1272
1273 2019-05-14  Tom Tromey  <tromey@adacore.com>
1274
1275         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1276         value is not lval_memory.
1277
1278 2019-05-14  Tom Tromey  <tromey@adacore.com>
1279
1280         * solib.c (info_sharedlibrary_command): Style the file name.
1281
1282 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1283
1284         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1285         (aarch64_vnv_type): Likewise.
1286         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1287         * common/tdesc.c: Likewise.
1288         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1289         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1290         * features/aarch64-fpu.xml: Add ieee half view.
1291         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1292         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1293         * gdbtypes.h (struct builtin_type): Likewise.
1294         (struct objfile_type): Likewise.
1295
1296 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1297
1298         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1299         typo.
1300         * location.h (string_to_event_location): Likewise.
1301
1302 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1303
1304         GDB 8.3 released.
1305
1306 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1307
1308         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1309         New variable declaration.
1310         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1311         New variable.
1312         (print_one_breakpoint): Use ui_out::test_flags and new global
1313         variable to compute use_fixed_output.
1314         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1315         Remove.
1316         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1317         (mi_multi_location_breakpoint_output_fixed): Remove.
1318         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1319         new variable.
1320         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1321         fix_multi_location_breakpoint_output flag if version >= 3.
1322         * ui-out.h (enum ui_out_flag)
1323         <fix_multi_location_breakpoint_output>: New enumerator.
1324
1325 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1326
1327         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1328
1329 2019-05-10  Tom Tromey  <tromey@adacore.com>
1330
1331         * ada-lang.c (catch_ada_completer): New function.
1332         (_initialize_ada_language): Use it.
1333
1334 2019-05-10  Tom Tromey  <tromey@adacore.com>
1335
1336         * thread.c (print_thread_info): Make "requested_threads" const.
1337         * gdbthread.h (print_thread_info): Make "requested_threads"
1338         const.
1339         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1340         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1341
1342 2019-05-08  Tom Tromey  <tom@tromey.com>
1343
1344         * gdbtypes.c (objfile_type_data): Change type.
1345         (objfile_type, _initialize_gdbtypes): Update.
1346
1347 2019-05-08  Tom Tromey  <tom@tromey.com>
1348
1349         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1350         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1351         (_initialize_dwarf2_frame): Update.
1352
1353 2019-05-08  Tom Tromey  <tom@tromey.com>
1354
1355         * objc-lang.c (objc_objfile_data): Change type.
1356         (find_methods): Update.
1357         (_initialize_objc_lang): Remove.
1358
1359 2019-05-08  Tom Tromey  <tom@tromey.com>
1360
1361         * stabsread.c (rs6000_builtin_type_data): Change type.
1362         (rs6000_builtin_type, _initialize_stabsread): Update.
1363
1364 2019-05-08  Tom Tromey  <tom@tromey.com>
1365
1366         * mips-tdep.c (mips_pdr_data): Remove.
1367         (_initialize_mips_tdep): Update.
1368
1369 2019-05-08  Tom Tromey  <tom@tromey.com>
1370
1371         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1372         (hppa_init_objfile_priv_data, read_unwind_info)
1373         (find_unwind_entry, _initialize_hppa_tdep): Update.
1374
1375 2019-05-08  Tom Tromey  <tom@tromey.com>
1376
1377         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1378         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1379         on obstack.
1380         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1381
1382 2019-05-08  Tom Tromey  <tom@tromey.com>
1383
1384         * mdebugread.c (basic_type_data): Change type.
1385         (basic_type, _initialize_mdebugread): Update.
1386
1387 2019-05-08  Tom Tromey  <tom@tromey.com>
1388
1389         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1390
1391 2019-05-08  Tom Tromey  <tom@tromey.com>
1392
1393         * nto-tdep.c (nto_inferior_data_reg): Change type.
1394         (nto_inferior_data): Update.
1395         (nto_inferior_data_cleanup, nto_new_inferior_data)
1396         (_initialize_nto_tdep): Remove.
1397         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1398
1399 2019-05-08  Tom Tromey  <tom@tromey.com>
1400
1401         * ada-lang.c (struct ada_inferior_data): Add initializers.
1402         (ada_inferior_data): Change type.
1403         (ada_inferior_data_cleanup): Remove.
1404         (get_ada_inferior_data, ada_inferior_exit)
1405         (struct ada_pspace_data): Add initializers, destructor.
1406         (ada_pspace_data_handle): Change type.
1407         (get_ada_pspace_data): Update.
1408         (ada_pspace_data_cleanup): Remove.
1409
1410 2019-05-08  Tom Tromey  <tom@tromey.com>
1411
1412         * coffread.c (struct coff_symfile_info): Add initializers.
1413         (coff_objfile_data_key): Move lower.  Change type.
1414         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1415         Update.
1416         (coff_free_info): Remove.
1417
1418 2019-05-08  Tom Tromey  <tom@tromey.com>
1419
1420         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1421         (fbsd_pspace_data_handle): Move lower.  Change type.
1422         (get_fbsd_pspace_data): Update.
1423         (fbsd_pspace_data_cleanup): Remove.
1424         (_initialize_fbsd_tdep): Update.
1425
1426 2019-05-08  Tom Tromey  <tom@tromey.com>
1427
1428         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1429         (get_ada_tasks_pspace_data): Update.
1430         (ada_tasks_pspace_data_cleanup): Remove.
1431         (_initialize_tasks): Update.
1432         (ada_tasks_inferior_data_handle): Change type.
1433         (get_ada_tasks_inferior_data): Update.
1434         (ada_tasks_inferior_data_cleanup): Remove.
1435         (struct ada_tasks_pspace_data): Add initializers.
1436
1437 2019-05-08  Tom Tromey  <tom@tromey.com>
1438
1439         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1440         * symfile-debug.c (debug_sym_get_probes): Change type.
1441         * stap-probe.c (handle_stap_probe):
1442         (stap_static_probe_ops::get_probes): Change type.
1443         * probe.h (class static_probe_ops) <get_probes>: Change type.
1444         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1445         (parse_probes_in_pspace): Update.
1446         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1447         Update.
1448         (any_static_probe_ops::get_probes): Change type.
1449         * elfread.c (elfread_data): New typedef.
1450         (probe_key): Change type.
1451         (elf_get_probes): Likewise.  Update.
1452         (probe_key_free): Remove.
1453         (_initialize_elfread): Update.
1454         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1455         Change type.
1456         (dtrace_process_dof_probe, dtrace_process_dof)
1457         (dtrace_static_probe_ops::get_probe): Change type.
1458
1459 2019-05-08  Tom Tromey  <tom@tromey.com>
1460
1461         * xcoffread.c (struct xcoff_symfile_info): Rename from
1462         coff_symfile_info.  Add initializers.
1463         (xcoff_objfile_data_key): Move lower.  Change type.
1464         (XCOFF_DATA): Rewrite.
1465         (xcoff_free_info): Remove.
1466         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1467         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1468         (xcoff_initial_scan): Update.
1469
1470 2019-05-08  Tom Tromey  <tom@tromey.com>
1471
1472         * solib-svr4.c (struct svr4_info): Add initializers and
1473         destructor.
1474         <probes_table>: Now an htab_up.
1475         (solib_svr4_pspace_data): Change type.
1476         (free_probes_table): Simplify.
1477         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1478         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1479         (probes_table_remove_objfile_probes, register_solib_event_probe)
1480         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1481         (_initialize_svr4_solib): Update.
1482
1483 2019-05-08  Tom Tromey  <tom@tromey.com>
1484
1485         * remote.c (remote_pspace_data): Change type.
1486         (remote_pspace_data_cleanup): Remove.
1487         (get_remote_exec_file, set_pspace_remote_exec_file)
1488         (_initialize_remote): Update.
1489
1490 2019-05-08  Tom Tromey  <tom@tromey.com>
1491
1492         * breakpoint.c (breakpoint_objfile_key): Change type.
1493         (get_breakpoint_objfile_data): Update.
1494         (free_breakpoint_objfile_data): Remove.
1495         (_initialize_breakpoint): Update.
1496
1497 2019-05-08  Tom Tromey  <tom@tromey.com>
1498
1499         * linux-tdep.c (struct linux_info): Add initializers.
1500         (linux_inferior_data): Move.  Change type.
1501         (invalidate_linux_cache_inf): Update.
1502         (linux_inferior_data_cleanup): Remove.
1503         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1504
1505 2019-05-08  Tom Tromey  <tom@tromey.com>
1506
1507         * auxv.c (auxv_inferior_data): Move.  Change type.
1508         (auxv_inferior_data_cleanup): Remove.
1509         (invalidate_auxv_cache_inf): Rewrite.
1510         (get_auxv_inferior_data, _initialize_auxv): Update.
1511
1512 2019-05-08  Tom Tromey  <tom@tromey.com>
1513
1514         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1515         (symfile_debug_objfile_data_key): Change type.
1516         (symfile_debug_installed, debug_qf_has_symbols)
1517         (debug_qf_find_last_source_symtab)
1518         (debug_qf_forget_cached_source_info)
1519         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1520         (debug_qf_print_stats, debug_qf_dump)
1521         (debug_qf_expand_symtabs_for_function)
1522         (debug_qf_expand_all_symtabs)
1523         (debug_qf_expand_symtabs_with_fullname)
1524         (debug_qf_map_matching_symbols)
1525         (debug_qf_expand_symtabs_matching)
1526         (debug_qf_find_pc_sect_compunit_symtab)
1527         (debug_qf_map_symbol_filenames)
1528         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1529         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1530         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1531         (debug_sym_read_linetable, debug_sym_relocate): Update.
1532         (symfile_debug_free_objfile): Remove.
1533         (install_symfile_debug_logging, _initialize_symfile_debug):
1534         Update.
1535
1536 2019-05-08  Tom Tromey  <tom@tromey.com>
1537
1538         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1539         allocate_on_obstack.
1540         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1541         (get_dwarf2_per_objfile): Update.
1542         (set_dwarf2_per_objfile): Remove.
1543         (dwarf2_has_info, dwarf2_get_section_info): Update.
1544         (dwarf2_free_objfile): Remove.
1545         (_initialize_dwarf2_read): Update.
1546
1547 2019-05-08  Tom Tromey  <tom@tromey.com>
1548
1549         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1550         initializers.
1551         <unsupported_script_warning_printed,
1552         script_not_found_warning_printed>: Now bool.
1553         (auto_load_pspace_data): Change type.
1554         (~auto_load_pspace_info): Rename from
1555         auto_load_pspace_data_cleanup.
1556         (get_auto_load_pspace_data, init_loaded_scripts_info)
1557         (clear_section_scripts, maybe_print_unsupported_script_warning)
1558         (maybe_print_script_not_found_warning, _initialize_auto_load):
1559         Update.
1560
1561 2019-05-08  Tom Tromey  <tom@tromey.com>
1562
1563         * objfiles.c (objfile_pspace_info): Add destructor and
1564         initializers.
1565         (objfiles_pspace_data): Change type.
1566         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1567         (get_objfile_pspace_data): Update.
1568         (objfiles_bfd_data): Change type.
1569         (get_objfile_bfd_data): Update.
1570         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1571
1572 2019-05-08  Tom Tromey  <tom@tromey.com>
1573
1574         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1575         Change type.
1576         (get_catch_syscall_inferior_data): Update.
1577         (catch_syscall_inferior_data_cleanup): Remove.
1578         (_initialize_break_catch_syscall): Update.
1579
1580 2019-05-08  Tom Tromey  <tom@tromey.com>
1581
1582         * inflow.c (struct terminal_info): Add destructor and
1583         initializers.
1584         (inflow_inferior_data): Change type.
1585         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1586         (get_inflow_inferior_data, inflow_inferior_exit)
1587         (swap_terminal_info, _initialize_inflow): Update.
1588
1589 2019-05-08  Tom Tromey  <tom@tromey.com>
1590
1591         * target-dcache.c (target_dcache_cleanup): Remove.
1592         (target_dcache_aspace_key): Change type.
1593         (target_dcache_init_p, target_dcache_invalidate)
1594         (target_dcache_get, target_dcache_get_or_init)
1595         (_initialize_target_dcache): Update.
1596         * dcache.h (struct dcache_deleter): New.
1597
1598 2019-05-08  Tom Tromey  <tom@tromey.com>
1599
1600         * symtab.c (struct symbol_cache): Add destructor and
1601         initializers.
1602         (symbol_cache_key): Move.  Change type.
1603         (make_symbol_cache, free_symbol_cache): Remove.
1604         (get_symbol_cache): Update.
1605         (symbol_cache_cleanup): Remove.
1606         (ALL_PSPACES, symbol_cache_flush)
1607         (maintenance_print_symbol_cache)
1608         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1609         Update.
1610
1611 2019-05-08  Tom Tromey  <tom@tromey.com>
1612
1613         * symtab.c (struct main_info): Add destructor and initializers.
1614         (main_progspace_key): Move.  Change type.
1615         (get_main_info): Update.
1616         (main_info_cleanup): Remove.
1617         (_initialize_symtab): Update.
1618
1619 2019-05-08  Tom Tromey  <tom@tromey.com>
1620
1621         * registry.h (DECLARE_REGISTRY): Define the _key class.
1622
1623 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1624
1625         * NEWS: Merge two 'New commands' sections.
1626
1627 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1628
1629         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1630         parameter and use Ada language definition instead.
1631         (ada_val_print_ptr): Remove unused language parameter.
1632         (ada_val_print_num): Remove language parameter and use Ada language
1633         definition instead.
1634         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1635         parameter.
1636         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1637         parameter and use Ada language definition instead.
1638         (ada_val_print_1): Update all ada_val_print_xxx calls.
1639         Remove language parameter.
1640         (ada_val_print): Update ada_val_print_1 call.
1641
1642 2019-05-08  Tom Tromey  <tromey@adacore.com>
1643
1644         * remote.c (remote_hw_watchpoint_limit)
1645         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1646         Now static.
1647
1648 2019-05-08  Tom Tromey  <tromey@adacore.com>
1649
1650         * maint.c (_initialize_maint_cmds): Move initialization code to
1651         remote.c.
1652         (watchdog, show_watchdog): Move to remote.c.
1653         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1654         "watchdog" static.
1655         (_initialize_remote): Move initialization code from maint.c.
1656         * defs.h (watchdog): Don't declare.
1657
1658 2019-05-08  Tom Tromey  <tromey@adacore.com>
1659
1660         * tui/tui-interp.c: Include main.h.
1661         * interps.c: Include main.h.
1662         * main.h (interpreter_p): Declare.
1663         * defs.h (interpreter_p): Don't declare.
1664
1665 2019-05-08  Tom Tromey  <tromey@adacore.com>
1666
1667         * dwarf2loc.c: Include dwarf2read.h.
1668         * defs.h (read_unsigned_leb128): Don't declare.
1669         * dwarf2read.h (read_unsigned_leb128): Declare.
1670
1671 2019-05-08  Tom Tromey  <tromey@adacore.com>
1672
1673         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1674         method.
1675
1676 2019-05-08  Tom Tromey  <tromey@adacore.com>
1677
1678         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1679         when no wrap column is set.
1680
1681 2019-05-08  Tom Tromey  <tromey@adacore.com>
1682
1683         * c-lang.c (c_get_string): Handle non-C-style arrays.
1684
1685 2019-05-08  Tom Tromey  <tromey@adacore.com>
1686
1687         * typeprint.c (print_offset_data::update): Print the bit offset,
1688         not the number of bits remaining.
1689
1690 2019-05-08  Tom Tromey  <tromey@adacore.com>
1691
1692         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1693         padding at end of comment.
1694
1695 2019-05-08  Tom Tromey  <tromey@adacore.com>
1696
1697         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1698         Compare main types.
1699
1700 2019-05-06  Tom Tromey  <tom@tromey.com>
1701
1702         * common/scoped_mmap.c: Include common-defs.h.
1703         * common/scoped_mmap.h: Don't include config.h.
1704
1705 2019-05-04  Tom Tromey  <tom@tromey.com>
1706
1707         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1708         (struct aarch64_call_info): Add initializers.
1709         <si>: Now a std::vector.
1710         (pass_on_stack, aarch64_push_dummy_call): Update.
1711
1712 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1713             Tom Tromey  <tom@tromey.com>
1714
1715         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1716         (ppc_threads): Now a std::vector.  Now static.
1717         (hwdebug_find_thread_points_by_tid)
1718         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1719         Update.
1720
1721 2019-05-04  Tom Tromey  <tom@tromey.com>
1722
1723         * arc-tdep.c (arc_tdesc_init): Return bool.
1724
1725 2019-05-04  Tom Tromey  <tom@tromey.com>
1726
1727         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1728         Use gdb_assert_not_reached.
1729
1730 2019-05-04  Tom Tromey  <tom@tromey.com>
1731
1732         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1733         "false".
1734
1735 2019-05-04  Tom Tromey  <tom@tromey.com>
1736
1737         * arc-tdep.c (arc_tdesc_init): Use bool.
1738
1739 2019-05-04  Tom Tromey  <tom@tromey.com>
1740
1741         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1742
1743 2019-05-04  Tom Tromey  <tom@tromey.com>
1744
1745         * cli/cli-cmds.c (valid_command_p): Return bool.
1746
1747 2019-05-04  Tom Tromey  <tom@tromey.com>
1748
1749         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1750         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1751
1752 2019-05-04  Raul Tambre  <raul@tambre.ee>
1753
1754         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1755         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1756         operator for comparison.
1757
1758 2019-05-04  Tom Tromey  <tom@tromey.com>
1759
1760         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1761         (lookup_partial_symbol, print_partial_symbols)
1762         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1763         (psymbol_compare): Update.
1764         (add_psymbol_to_bcache): Clear the entire psymbol.
1765         (maintenance_check_psymtabs): Update.
1766         * psympriv.h (struct partial_symbol): Don't derive from
1767         general_symbol_info.
1768         <obj_section, unrelocated_address, address,
1769         set_unrelocated_address>: Update.
1770         <ginfo>: New member.
1771         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1772         (debug_names::write_psymbols): Update.
1773
1774 2019-05-04  Tom de Vries  <tdevries@suse.de>
1775
1776         * contrib/cc-with-tweaks.sh: Support -n arg.
1777
1778 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1779
1780         * corelow.c (core_target::detach): Ensure frame cache and
1781         register caches are cleared.
1782         inferior.c (exit_inferior_1): Likewise.
1783
1784 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1785             Tom Tromey  <tom@tromey.com>
1786
1787         * dictionary.c (collate_pending_symbols_by_language): Remove
1788         "struct" from foreach.
1789         * symtab.c (lookup_global_symbol_from_objfile)
1790         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1791         foreach.
1792         * ser-tcp.c (net_open): Remove "struct" from foreach.
1793         * objfiles.c (objfile_relocate, objfile_rebase)
1794         (objfile_has_symbols): Remove "struct" from foreach.
1795         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1796         from foreach.
1797         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1798         foreach.
1799         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1800         "struct" from foreach.
1801         * ada-lang.c (create_excep_cond_exprs)
1802         (ada_exception_catchpoint_cond_string): Remove "struct" from
1803         foreach.
1804
1805 2019-05-03  Tom Tromey  <tromey@adacore.com>
1806
1807         * ada-exp.y (convert_char_literal): Check suffix of each
1808         enumerator.
1809
1810 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1811
1812         PR ada/21406:
1813         * ada-exp.y (yywrap): Don't define.
1814         * ada-lex.l (%option): Add noyywrap
1815         (yywrap): Remove.
1816
1817 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1818
1819         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1820         _WIN32_WINNT to the XP level, unless already defined to a higher
1821         level.
1822
1823         * unittests/parse-connection-spec-selftests.c:
1824         * ser-tcp.c:
1825         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1826         override.
1827
1828         * symfile.c (find_separate_debug_file): Remove colon from the
1829         drive spec of DOS/Windows file names of the target, so that the
1830         file name produced from DEBUGDIR and the target's directory will
1831         be valid on DOS/Windows systems.
1832
1833 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1834
1835         * rust-lang.c (val_print_struct): Handle printing structures
1836         containing strings.
1837
1838 2019-05-02  Tom Tromey  <tromey@adacore.com>
1839
1840         * valarith.c (_initialize_valarith): Remove.
1841
1842 2019-05-01  Tom Tromey  <tromey@adacore.com>
1843
1844         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1845         bitfields.
1846
1847 2019-05-01  Tom Tromey  <tromey@adacore.com>
1848
1849         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1850         for big-endian copies.
1851
1852 2019-04-30  Ali Tamur  <tamur@google.com>
1853         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1854         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1855         (read_3_bytes): New function.
1856
1857 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1858
1859         * windows-nat.c (main_thread_id): Delete.
1860         (handle_output_debug_string): Replace main_thread_id by
1861         current_event.dwThreadId.
1862         (fake_create_process): Likewise.
1863         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1864         Do not set main_thread_id.
1865         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1866         current_event.dwThreadId.
1867         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1868
1869 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1870
1871         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1872         Use current_event.dwThreadId instead of main_thread_id.
1873
1874 2019-04-30  Tom Tromey  <tromey@adacore.com>
1875
1876         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1877         (create_excep_cond_exprs): Iterate over program spaces.
1878         (ada_exception_catchpoint_cond_string): Examine all minimal
1879         symbols for exception types.
1880
1881 2019-04-30  Tom Tromey  <tromey@adacore.com>
1882
1883         PR c++/24470:
1884         * dwarf2read.c (process_structure_scope): Handle case where type
1885         has template parameters but no symbol was created.
1886
1887 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1888             Chris January  <chris.january@arm.com>
1889
1890         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1891         qualifier.
1892         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1893
1894 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * f-typeprint.c (f_print_type): Update rules for printing
1897         whitespace.
1898         (f_type_print_varspec_suffix): Likewise.
1899
1900 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1901             Chris January  <chris.january@arm.com>
1902
1903         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1904         function arguments.
1905
1906 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1907
1908         * f-lang.c (build_fortran_types): Change name of void type to
1909         lower case.
1910         * f-typeprint.c (f_type_print_base): Print the name of the void
1911         type, rather than a fixed string.
1912         * f-valprint.c (f_decorations): Use lower case void string.
1913
1914 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1915             Chris January  <chris.january@arm.com>
1916
1917         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1918         types for Fortran.
1919
1920 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1921             Chris January  <chris.january@arm.com>
1922             David Lecomber  <david.lecomber@arm.com>
1923
1924         * f-exp.y (BINOP_INTRINSIC): New token.
1925         (exp): New parser rule handling BINOP_INTRINSIC.
1926         (f77_keywords): Add new builtin procedures.
1927         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1928         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1929         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1930         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1931         (print_unop_subexp_f): New function.
1932         (print_binop_subexp_f): New function.
1933         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1934         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1935         (dump_subexp_body_f): Likewise.
1936         (operator_check_f): Likewise.
1937         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1938         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1939
1940 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1943         UNOP_KIND.
1944         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1945         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1946         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1947         (operator_length_f): New fuction.
1948         (print_subexp_f): New function.
1949         (op_name_f): New function.
1950         (dump_subexp_body_f): New function.
1951         (operator_check_f): New function.
1952         (exp_descriptor_f): Replace standard expression handling functions
1953         with new functions.
1954         * gdb/fortran-operator.def: New file.
1955         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1956         * gdb/std-operator.def: Remove UNOP_KIND.
1957
1958 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         * std-operator.def: Remove unbalanced, stray double quote
1961         character.
1962
1963 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1964             Chris January  <chris.january@arm.com>
1965             Daniel Everett  <daniel.everett@arm.com>
1966             Nick Forrington  <nick.forrington@arm.com>
1967             Richard Bunt  <richard.bunt@arm.com>
1968
1969         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1970         of depth when printing anonymous structs or unions.
1971         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1972         Don't print either the top-level value, or the children if the
1973         max-depth is exceeded.
1974         (ppscm_print_children): When printing the key of a map, allow one
1975         extra level of depth.
1976         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1977         print either the top-level value, or the children if the max-depth
1978         is exceeded.
1979         (print_children): When printing the key of a map, allow one extra
1980         level of depth.
1981         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1982         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1983         (user_print_options): Initialise max_depth field.
1984         (val_print_scalar_or_string_type_p): New function.
1985         (val_print): Check to see if the max depth has been reached.
1986         (val_print_check_max_depth): Define new function.
1987         (show_print_max_depth): New function.
1988         (_initialize_valprint): Add 'print max-depth' option.
1989         * valprint.h (struct value_print_options) <max_depth>: New field.
1990         (val_print_check_max_depth): Declare new function.
1991         * NEWS: Document new feature.
1992
1993 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1994
1995         * ada-lang.c (ada_language_defn): Initialise new field.
1996         * c-lang.c (c_is_string_type_p): New function.
1997         (c_language_defn): Initialise new field.
1998         (cplus_language_defn): Initialise new field.
1999         (asm_language_defn): Initialise new field.
2000         (minimal_language_defn): Initialise new field.
2001         * c-lang.h (c_is_string_type_p): Declare new function.
2002         * d-lang.c (d_language_defn): Initialise new field.
2003         * f-lang.c (f_is_string_type_p): New function.
2004         (f_language_defn): Initialise new field.
2005         * go-lang.c (go_is_string_type_p): New function.
2006         (go_language_defn): Initialise new field.
2007         * language.c (default_is_string_type_p): New function.
2008         (unknown_language_defn): Initialise new field.
2009         (auto_language_defn): Initialise new field.
2010         * language.h (struct language_defn) <la_is_string_type_p>: New
2011         member variable.
2012         (default_is_string_type_p): Declare new function.
2013         * m2-lang.c (m2_language_defn): Initialise new field.
2014         * objc-lang.c (objc_language_defn): Initialise new field.
2015         * opencl-lang.c (opencl_language_defn): Initialise new field.
2016         * p-lang.c (pascal_is_string_type_p): New function.
2017         (pascal_language_defn): Initialise new field.
2018         * rust-lang.c (rust_is_string_type_p): New function.
2019         (rust_language_defn): Initialise new field.
2020
2021 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2022
2023         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2024         New field.
2025         * ada-lang.c (ada_language_defn): Initialise new field.
2026         * c-lang.c (c_language_defn): Likewise.
2027         (cplus_language_defn): Likewise.
2028         (asm_language_defn): Likewise.
2029         (minimal_language_defn): Likewise.
2030         * d-lang.c (d_language_defn): Likewise.
2031         * f-lang.c (f_language_defn): Likewise.
2032         * go-lang.c (go_language_defn): Likewise.
2033         * language.c (unknown_language_defn): Likewise.
2034         (auto_language_defn): Likewise.
2035         * m2-lang.c (m2_language_defn): Likewise.
2036         * objc-lang.c (objc_language_defn): Likewise.
2037         * opencl-lang.c (opencl_language_defn): Likewise.
2038         * p-lang.c (pascal_language_defn): Likewise.
2039         * rust-lang.c (rust_language_defn): Likewise.
2040
2041 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2042
2043         * ada-lang.c (ada_is_character_type): Change return type to bool.
2044         (ada_is_string_type): Likewise.
2045         * ada-lang.h (ada_is_character_type): Update declaration
2046         (ada_is_string_type): Likewise.
2047
2048 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2049
2050         Support style in 'frame|thread apply'
2051
2052         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2053         * record.c (record_start, record_stop): Update callers of
2054         execute_command_to_string with false.
2055         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2056         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2057         methods.
2058         (class string_file): New constructor with term_out parameter.
2059         Override methods term_out and can_emit_style_escape.  New member
2060         term_out.
2061         (class stdio_file): Override can_emit_style_escape.
2062         (class tee_file): Override term_out and can_emit_style_escape.
2063         * utils.h (can_emit_style_escape): Remove.
2064         * utils.c (can_emit_style_escape): Likewise.
2065         Update all callers of can_emit_style_escape (SOMESTREAM) to
2066         SOMESTREAM->can_emit_style_escape.
2067         * source-cache.c (source_cache::get_source_lines): Likewise.
2068         * stack.c (frame_apply_command_count): Call execute_command_to_string
2069         passing the term_out characteristic of the current gdb_stdout.
2070         * thread.c (thr_try_catch_cmd): Likewise.
2071         * top.c (execute_command_to_string): pass term_out parameter
2072         to construct the string_file for the command output.
2073         * ui-file.c (term_cli_styling): New function (most code moved
2074         from utils.c can_emit_style_escape).
2075         (string_file::string_file, string_file::can_emit_style_escape,
2076         stdio_file::can_emit_style_escape, tee_file::term_out,
2077         tee_file::can_emit_style_escape): New functions.
2078
2079 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2080
2081         * NEWS: Mention the new set|show may-call-functions.
2082         * infcall.c (may_call_functions_p): New variable.
2083         (show_may_call_functions_p): New function.
2084         (call_function_by_hand_dummy): Throws an error if not
2085         may-call-functions.
2086         (_initialize_infcall): Call add_setshow_boolean_cmd for
2087         may-call-functions.
2088
2089 2019-04-25  Keith Seitz  <keiths@redhat.com>
2090
2091         PR c++/24367
2092         * cp-support.c (inspect_type): Don't attempt substitutions
2093         of symbol with the same name.
2094
2095 2019-04-25  Tom Tromey  <tromey@adacore.com>
2096
2097         PR gdb/24475:
2098         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2099         static.
2100
2101 2019-04-25  Tom Tromey  <tromey@adacore.com>
2102
2103         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2104         rvalue reference.
2105         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2106         (gdb_xml_parser::parse): Use std::move.
2107         * python/python-internal.h (gdbpy_convert_exception): Take a const
2108         reference.
2109         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2110         std::move.
2111         * python/py-utils.c (gdbpy_convert_exception): Take a const
2112         reference.
2113         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2114         Use std::move.
2115         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2116         Use std::move.
2117         * mi/mi-main.c (mi_print_exception): Take a const reference.
2118         * main.c (handle_command_errors): Take a const reference.
2119         * linespec.c (parse_linespec): Use std::move.
2120         * infcall.c (run_inferior_call): Use std::move.
2121         (call_function_by_hand_dummy): Use std::move.
2122         * exec.c (try_open_exec_file): Use std::move.
2123         * exceptions.h (exception_print, exception_fprintf)
2124         (exception_print_same): Update.
2125         * exceptions.c (print_exception, exception_print)
2126         (exception_fprintf, exception_print_same): Change parameters to
2127         const reference.
2128         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2129         * common/new-op.c: Use std::move.
2130         * common/common-exceptions.h (struct gdb_exception): Add move
2131         constructor.
2132         (struct gdb_exception_error, struct gdb_exception_quit, struct
2133         gdb_quit_bad_alloc): Change constructor to move constructor.
2134         (throw_exception): Change parameter to rvalue reference.
2135         * common/common-exceptions.c (throw_exception): Take rvalue
2136         reference.
2137         * cli/cli-interp.c (safe_execute_command): Use std::move.
2138         * breakpoint.c (insert_bp_location, location_to_sals): Use
2139         std::move.
2140
2141 2019-04-25  Tom Tromey  <tromey@adacore.com>
2142
2143         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2144         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2145         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2146         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2147         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2148         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2149         guile/scm-value.c: Use unpack.
2150         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2151         gdbscm_gdb_exception.
2152         (gdbscm_throw_gdb_exception): Likewise.
2153         (struct gdbscm_gdb_exception): New.
2154         (unpack): New function.
2155         (gdbscm_wrap): Use unpack.
2156
2157 2019-04-25  Tom Tromey  <tromey@adacore.com>
2158
2159         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2160         (gdb_rl_callback_handler): Use std::move.
2161         * common/common-exceptions.h (struct gdb_exception): Add move
2162         assignment operator.
2163         (throw_exception_sjlj): Change "exception" to const reference.
2164         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2165         (throw_exception_sjlj): Change "exception" to const reference.
2166
2167 2019-04-25  Tom Tromey  <tromey@adacore.com>
2168
2169         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2170         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2171         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2172         Update.
2173         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2174         Update.
2175         * mi/mi-interp.c (mi_interp::exec): Update.
2176         * linespec.c (parse_linespec): Update.
2177         * infcall.c (run_inferior_call): Update.
2178         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2179         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2180         (gdbscm_lookup_global_symbol): Update.
2181         * guile/scm-param.c (gdbscm_parameter_value): Update.
2182         * guile/scm-frame.c (gdbscm_frame_read_register)
2183         (gdbscm_frame_read_var): Update.
2184         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2185         * exec.c (try_open_exec_file): Update.
2186         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2187         (gdb_rl_callback_handler): Update.
2188         * common/common-exceptions.h (exception_none): Don't declare.
2189         * common/common-exceptions.c (exception_none): Don't define.
2190         (struct catcher) <exception>: Update.
2191         * cli/cli-interp.c (safe_execute_command): Update.
2192         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2193
2194 2019-04-25  Ali Tamur  <tamur@google.com>
2195
2196         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2197         (read_attribute_value): Likewise.
2198         (dwarf2_read_addr_index): Update comment.
2199         (read_str_index): Add DW_FORM_strx.
2200         (dwarf2_string_attr): Likewise.
2201         (dwarf2_const_value_attr): Likewise.
2202         (dump_die_shallow): Likewise.
2203         (dwarf2_fetch_constant_bytes): Likewise.
2204         (skip_form_bytes): Likewise.
2205         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2206
2207 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2208
2209         PR corefiles/11608
2210         PR corefiles/18187
2211         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2212         OFFSET.  Verify if current mapping contains an ELF header.
2213         (linux_find_memory_regions_full): Adjust call to
2214         dump_mapping_p.
2215
2216 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2217             Kang Li <kanglictf@gmail.com>
2218
2219         PR gdb/21600
2220
2221         * dwarf2-frame.c (read_initial_length): Be consistent about using
2222         unsigned representation of length.
2223         (decode_frame_entry_1): Likewise.  Check for wraparound of
2224         end pointer as well as buffer overflow.
2225
2226 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2227
2228         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2229         "vq".
2230
2231 2019-04-24  Tom Tromey  <tromey@adacore.com>
2232
2233         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2234
2235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2236
2237         * s12z-tdep.c (s12z_unwind_pc): Delete.
2238         (s12z_unwind_sp): Delete.
2239         (s12z_gdbarch_init): Don't register deleted functions with
2240         gdbarch.
2241
2242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * rl78-tdep.c (rl78_unwind_sp): Delete.
2245         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2246
2247 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2250         (xstormy16_unwind_pc): Delete.
2251         (xstormy16_dummy_id): Delete.
2252         (xstormy16_gdbarch_init): Don't register deleted functions with
2253         gdbarch.
2254
2255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * vax-tdep.c (vax_unwind_pc): Delete.
2258         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2259
2260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2261
2262         * v850-tdep.c (v850_unwind_sp): Delete.
2263         (v850_unwind_pc): Delete.
2264         (v850_dummy_id): Delete.
2265         (v850_gdbarch_init): Don't register deleted functions with
2266         gdbarch.
2267
2268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2269
2270         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2271         (tilegx_unwind_pc): Delete.
2272         (tilegx_unwind_dummy_id): Delete.
2273         (tilegx_gdbarch_init): Don't register deleted functions with
2274         gdbarch.
2275
2276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2279         (tic6x_dummy_id): Delete.
2280         (tic6x_gdbarch_init): Don't register deleted functions with
2281         gdbarch.
2282
2283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2284
2285         * sparc-tdep.c (sparc_unwind_pc): Delete.
2286         (sparc32_gdbarch_init): Don't register deleted function with
2287         gdbarch.
2288
2289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2290
2291         * sh-tdep.c (sh_unwind_sp): Delete.
2292         (sh_unwind_pc): Delete.
2293         (sh_dummy_id): Delete.
2294         (sh_gdbarch_init): Don't register deleted functions with
2295         gdbarch.
2296
2297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * score-tdep.c (score_unwind_sp): Delete.
2300         (score_unwind_pc): Delete.
2301         (score_dummy_id): Delete.
2302         (score_gdbarch_init): Don't register deleted functions with
2303         gdbarch.
2304
2305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * rx-tdep.c (rx_unwind_pc): Delete.
2308         (rx_unwind_sp): Delete.
2309         (rx_dummy_id): Delete.
2310         (rx_gdbarch_init): Don't register deleted functions with
2311         gdbarch.  Update comment.
2312
2313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2314
2315         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2316         (rs6000_dummy_id): Delete.
2317         (rs6000_gdbarch_init): Don't register deleted functions with
2318         gdbarch.
2319
2320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2321
2322         * or1k-tdep.c (or1k_dummy_id): Delete.
2323         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2324
2325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2326
2327         * nios2-tdep.c (nios2_dummy_id): Delete.
2328         (nios2_unwind_sp): Delete.
2329         (nios2_gdbarch_init): Don't register deleted functions with
2330         gdbarch.
2331
2332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * nds32-tdep.c (nds32_dummy_id): Delete.
2335         (nds32_unwind_pc): Delete.
2336         (nds32_unwind_sp): Delete.
2337         (nds32_gdbarch_init): Don't register deleted functions with
2338         gdbarch.
2339
2340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2341
2342         * msp430-tdep.c (msp430_unwind_pc): Delete.
2343         (msp430_unwind_sp): Delete.
2344         (msp430_dummy_id): Delete.
2345         (msp430_gdbarch_init): Don't register deleted functions with
2346         gdbarch.
2347
2348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2349
2350         * moxie-tdep.c (moxie_unwind_sp): Delete.
2351         (moxie_unwind_pc): Delete.
2352         (moxie_dummy_id): Delete.
2353         (moxie_gdbarch_init): Don't register deleted functions with
2354         gdbarch.
2355
2356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2357
2358         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2359         (mn10300_unwind_pc): Delete.
2360         (mn10300_unwind_sp): Delete.
2361         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2362         mn10300_unwind_sp.
2363         (mn10300_frame_unwind_init): Don't register deleted functions with
2364         gdbarch.
2365
2366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2367
2368         * mep-tdep.c (mep_unwind_pc): Delete.
2369         (mep_unwind_sp): Delete.
2370         (mep_dummy_id): Delete.
2371         (mep_gdbarch_init): Don't register deleted functions with
2372         gdbarch.
2373
2374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2375
2376         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2377         (m68hc11_unwind_sp): Delete.
2378         (m68hc11_gdbarch_init): Don't register deleted functions with
2379         gdbarch.
2380
2381 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * m32r-tdep.c (m32r_unwind_sp): Delete.
2384         (m32r_unwind_pc): Delete.
2385         (m32r_dummy_id): Delete.
2386         (m32r_gdbarch_init): Don't register deleted functions with
2387         gdbarch.
2388
2389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2390
2391         * m32c-tdep.c (m32c_unwind_pc): Delete.
2392         (m32c_unwind_sp): Delete.
2393         (m32c_dummy_id): Delete.
2394         (m32c_gdbarch_init): Don't register deleted functions with
2395         gdbarch.
2396
2397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2398
2399         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2400         (lm32_unwind_pc): Delete.
2401         (lm32_dummy_id): Delete.
2402         (lm32_gdbarch_init): Don't register deleted functions with
2403         gdbarch.
2404
2405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2406
2407         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2408         (iq2000_unwind_pc): Delete.
2409         (iq2000_dummy_id): Delete.
2410         (iq2000_gdbarch_init): Don't register deleted functions with
2411         gdbarch.
2412
2413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2414
2415         * nds32-tdep.c (nds32_type_align): Delete.
2416         (nds32_push_dummy_call): Use type_align instead.
2417
2418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2419
2420         * arm-tdep.c (arm_type_align): Only handle vector override case.
2421         (arm_push_dummy_call): Use type_align.
2422         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2423
2424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2425
2426         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2427         case.
2428         (pass_on_stack): Use type_align.
2429         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2430         function.
2431
2432 2019-04-23  Tom Tromey  <tromey@adacore.com>
2433
2434         * dwarf2read.c (line_header::file_name_at): Remove unused
2435         overload.
2436
2437 2019-04-23  Tom de Vries  <tdevries@suse.de>
2438
2439         PR gdb/24438
2440         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2441         invocation.
2442
2443
2444 2019-03-27  Ali Tamur  <tamur@google.com>
2445
2446         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2447         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2448         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2449         (dwarf_expr_context::get_addr_index): Likewise
2450         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2451         (symbol_needs_eval_context::get_addr_index): Likewise
2452         (disassemble_dwarf_expression): Add DW_OP_addrx
2453         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2454         (read_cutu_die_from_dwo): Update comment
2455         (skip_one_die): Add DW_FORM_addrx
2456         (read_attribute_value): Likewise
2457         (var_decode_location): Add DW_OP_addrx
2458         (dwarf2_const_value_attr): Add DW_FORM_addrx
2459         (dump_die_shallow): Likewise
2460         (dwarf2_fetch_constant_bytes): Likewise
2461         (decode_locdesc): Add DW_OP_addrx
2462         (skip_form_bytes): Add DW_FORM_addrx
2463
2464 2019-04-22  Ali Tamur  <tamur@google.com>
2465
2466         * MAINTAINERS (Write After Approval): Add self.
2467
2468 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2469
2470         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2471         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2472         (open_symbol_file_object): Likewise.
2473         (svr4_default_sos): Add info parameter.
2474         (svr4_read_so_list): Likewise.
2475         (svr4_current_sos_direct): Adjust functions calls to pass down
2476         info.
2477         (svr4_current_sos_1): Add info parameter.
2478         (svr4_current_sos): Call get_svr4_info, pass info down to
2479         svr4_current_sos_1.
2480         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2481         get_svr4_info.
2482         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2483         get_svr4_info.
2484         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2485         to get_svr4_info.
2486         (probes_table_remove_objfile_probes): Likewise.
2487         (register_solib_event_probe): Add info parameter.
2488         (solist_update_incremental): Pass info parameter down to
2489         svr4_read_so_list.
2490         (disable_probes_interface): Add info parameter.
2491         (svr4_handle_solib_event): Pass current_program_space to
2492         get_svr4_info.  Adjust disable_probes_interface cleanup.
2493         (svr4_create_probe_breakpoints): Add info parameter, pass it
2494         down to register_solib_event_probe.
2495         (svr4_create_solib_event_breakpoints): Add info parameter,
2496         pass it down to svr4_create_probe_breakpoints.
2497         (enable_break): Pass info down to
2498         svr4_create_solib_event_breakpoints.
2499         (svr4_solib_create_inferior_hook): Pass current_program_space to
2500         get_svr4_info.
2501         (svr4_clear_solib): Likewise.
2502
2503 2019-04-22  Pedro Alves  <palves@redhat.com>
2504
2505         * solib-svr4.c (svr4_free_objfile_observer): New.
2506         (probe_and_action::objfile): New field.
2507         (probes_table_htab_remove_objfile_probes)
2508         (probes_table_remove_objfile_probes): New functions.
2509         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2510         in the new probe_and_action.  Don't store the probe in 'lookup'.
2511         (svr4_create_probe_breakpoints): Pass objfile to
2512         register_solib_event_probe.
2513         (_initialize_svr4_solib): Register a free_objfile observer.
2514
2515 2019-04-19  Tom Tromey  <tom@tromey.com>
2516
2517         * common/queue.h: Remove.
2518
2519 2019-04-19  Tom Tromey  <tom@tromey.com>
2520
2521         * event-loop.c: Don't include "common/queue.h".
2522
2523 2019-04-19  Tom Tromey  <tom@tromey.com>
2524
2525         * remote.c (remote_target): Use delete.
2526         * remote-notif.h: Include <list>, not "common/queue.h".
2527         (notif_client_p): Remove typedef.
2528         (remote_notif_state): Add constructor, destructor, initializer.
2529         <notif_queue>: Now a std::list.
2530         (remote_notif_state_xfree): Don't declare.
2531         * remote-notif.c (remote_notif_process, handle_notification)
2532         (remote_notif_state_allocate): Update.
2533         (~remote_notif_state): Rename from remote_notif_state_xfree.
2534
2535 2019-04-19  Tom Tromey  <tom@tromey.com>
2536
2537         * symfile.c (reread_symbols): Update.
2538         * objfiles.c (objfile_register_static_link)
2539         (objfile_lookup_static_link): Update
2540         (~objfile) Don't delete static_links.
2541         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2542
2543 2019-04-19  Tom Tromey  <tom@tromey.com>
2544
2545         * type-stack.h (struct type_stack) <insert>: Constify string.
2546         * type-stack.c (type_stack::insert): Constify string.
2547         * gdbtypes.h (lookup_template_type): Update.
2548         (address_space_name_to_int): Update.
2549         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2550         const.
2551         (lookup_template_type): Make name const.
2552         * c-exp.y: Update rules.
2553         (lex_one_token, classify_name, classify_inner_name)
2554         (c_print_token): Update.
2555         * p-exp.y: Update rules.
2556         (yylex): Update.
2557         * f-exp.y: Update rules.
2558         (yylex): Update.
2559         * d-exp.y: Update rules.
2560         (lex_one_token, classify_name, classify_inner_name): Update.
2561         * parse.c (write_dollar_variable, copy_name): Return std::string.
2562         * parser-defs.h (copy_name): Change return type.
2563         * m2-exp.y: Update rules.
2564         (yylex): Update.
2565         * go-exp.y (lex_one_token): Update.
2566         Update rules.
2567         (classify_unsafe_function, classify_packaged_name)
2568         (classify_name, yylex): Update.
2569
2570 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2571
2572         * configure.ac: add --enable-source-highlight switch.
2573         * configure: Regenerate.
2574         * top.c (print_gdb_version): plumb --enable-source-highlight
2575         status to "show configuration".
2576
2577 2019-04-19  Tom Tromey  <tromey@adacore.com>
2578
2579         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2580         Check ADA_TYPE_P.
2581         (empty_record, ada_template_to_fixed_record_type_1)
2582         (template_to_static_fixed_type)
2583         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2584         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2585         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2586         macros.
2587
2588 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2589
2590         PR symtab/24423:
2591         * source.c (print_source_lines_base): Advance "iter" when a
2592         control character is seen.
2593
2594 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2595
2596         * inferior.h (struct infcall_suspend_state_deleter):
2597         Catch exception in destructor to avoid crash.
2598
2599 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2600
2601         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2602         close to the add_com "shell".
2603
2604 2019-04-18  Tom Tromey  <tromey@adacore.com>
2605
2606         * process-stratum-target.h (class process_stratum_target)
2607         <stratum>: Add "final".
2608
2609 2019-04-17  Tom Tromey  <tromey@adacore.com>
2610
2611         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2612         against nullptr before use.
2613
2614 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2615
2616         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2617
2618 2019-04-17  Jim Wilson  <jimw@sifive.com>
2619             Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2622         code read might fail, assume 4-byte breakpoint in that case.
2623
2624 2019-04-15  Leszek Swirski  <leszeks@google.com>
2625
2626         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2627         rather than a hand-rolled POD check when checking for forced MEMORY
2628         classification.
2629
2630 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2631
2632         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2633         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2634         function.
2635         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2636         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2637         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2638         declaration.
2639
2640 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * aarch64-linux-nat.c
2643         (aarch64_linux_nat_target::thread_architecture): Add override.
2644         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2645         each VQ.
2646
2647 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2648
2649         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2650
2651 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2654         target types of size 96-bits, add some additional comments, and
2655         check that the builtin type we found was the correct size.
2656
2657 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2658
2659         * utils.c (prompt_for_continue): Don't restore the styling at the
2660         end, as applied_style has the wrong value.  This fixes styling in
2661         long lists of file names that are interrupted by the "Continue?"
2662         prompt.
2663
2664 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2665
2666         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2667         * c-lang.c (c_language_defn): Likewise.
2668         (cplus_language_defn): Likewise.
2669         (asm_language_defn): Likewise.
2670         (minimal_language_defn): Likewise.
2671         * d-lang.c (d_language_defn): Likewise.
2672         * f-lang.c (f_language_defn): Likewise.
2673         * go-lang.c (go_language_defn): Likewise.
2674         * language.c (unknown_language_defn): Likewise.
2675         (auto_language_defn): Likewise.
2676         * language.h (struct language_defn): Remove la_magic field.
2677         (LANG_MAGIC): Delete.
2678         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2679         * objc-lang.c (objc_language_defn): Likewise.
2680         * opencl-lang.c (opencl_language_defn): Likewise.
2681         * p-lang.c (pascal_language_defn): Likewise.
2682         * rust-lang.c (rust_language_defn): Likewise.
2683
2684 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * riscv-tdep.c (riscv_type_align): New function.
2687         (riscv_type_alignment): Delete.
2688         (riscv_arg_location): Use 'type_align'.
2689         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2690
2691 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * gdbtypes.c (type_align): A struct with no non-static fields also
2694         has alignment of 1.
2695
2696 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2699         component to 0.
2700         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2701         member.
2702         (riscv_struct_info::analyse): New implementation using new
2703         analyse_inner member function.
2704         (riscv_struct_info::field_offset): New member function.
2705         (riscv_struct_info::m_offsets): New member variable.
2706         (riscv_struct_info::analyse_inner): New private member function,
2707         takes the old implementation of riscv_struct_info::analyse but
2708         extended to track field offsets.
2709         (riscv_call_arg_struct): Update the struct folding special cases
2710         to handle cases where empty C++ structs, which are non-zero
2711         length, are found.
2712         (riscv_arg_location): Initialise the length of each location, a
2713         non-zero length now indicates the location is in use.
2714         (riscv_push_dummy_call): Allow for the first location having a
2715         non-zero offset when setting up arguments.
2716         (riscv_return_value): Likewise, but for return values.
2717
2718 2019-04-11  Tom Tromey  <tromey@adacore.com>
2719
2720         * utils.c (internal_vproblem): Make "msg" const.
2721
2722 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2723
2724         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2725         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2726         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2727         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2728
2729 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2730
2731         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2732         function.
2733         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2734         of amd64_collect_native_gregset.
2735         (amd64_linux_nat_target::store_registers): Likewise.
2736
2737 2019-04-10  Tom Tromey  <tom@tromey.com>
2738
2739         * symtab.c (lookup_global_symbol_from_objfile)
2740         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2741         * objfiles.h (class separate_debug_iterator): New.
2742         (class separate_debug_range): New.
2743         (struct objfile) <separate_debug_objfiles>: New method.
2744         (objfile_separate_debug_iterate): Don't declare.
2745         * objfiles.c (separate_debug_iterator::operator++): Rename from
2746         objfile_separate_debug_iterate.
2747         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2748         iterator.
2749         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2750         iterator.
2751
2752 2019-04-10  Tom Tromey  <tom@tromey.com>
2753
2754         * symfile.c (reread_symbols): Remove old comment.
2755         * objfiles.c (free_all_objfiles): Fix a typo.
2756
2757 2019-04-10  Tom Tromey  <tom@tromey.com>
2758
2759         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2760         * minsyms.c (lookup_minimal_symbol): Use foreach.
2761         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2762         (lookup_minimal_symbol_solib_trampoline): Likewise.
2763         * symfile.c (reread_symbols): Use foreach.
2764
2765 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2766             Tom Tromey  <tromey@adacore.com>
2767
2768         PR rust/24414:
2769         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2770         (rust_lex_int_test): Change "value" to be LONGEST.
2771         (rust_lex_tests): Add test for long integer literal.
2772
2773 2019-04-09  Tom Tromey  <tromey@adacore.com>
2774
2775         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2776         to bool.
2777         (extended_remote_target::attach): Update.
2778         (remote_target::remote_notice_new_inferior): Update.
2779         (remote_target::add_current_inferior_and_thread): Update.
2780         * inferior.c (exit_inferior_1): Use "false".
2781         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2782
2783 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2784
2785         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2786         the "start" command.
2787
2788 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2789
2790         * python/py-inferior.c (infpy_thread_from_thread_handle):
2791         Adjust comments to reflect renaming of thread_from_thread_handle
2792         to thread_from_handle.  Adjust keywords.  Fix type error message.
2793         (inferior_object_methods): Add thread_from_handle.  Retain
2794         thread_from_thread_handle, but mark it as deprecated.
2795
2796 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2797
2798         * gdbthread.h (find_thread_by_handle): Revise declaration.
2799         * thread.c (find_thread_by_handle): Likewise.  Adjust
2800         implementation too.
2801         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2802         support for buffer objects as handles.
2803
2804 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2805
2806         * python/py-infthread.c (thpy_thread_handle): New function.
2807         (thread_object_methods): Register thpy_thread_handle.
2808
2809 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2810
2811         * gdbthread.h (thread_to_thread_handle): Declare.
2812         * thread.c (gdbtypes.h): Include.
2813         (thread_to_thread_handle): New function.
2814
2815         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2816         (target_thread_info_to_thread_handle): Declare.
2817         * target.c (target_thread_info_to_thread_handle): New function.
2818         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2819         * target-delegates.c: Regenerate.
2820
2821         * linux-thread-db.c (class thread_db_target): Add method
2822         thread_info_to_thread_handle.
2823         (thread_db_target::thread_info_to_thread_handle): Define.
2824         * remote.c (class remote_target): Add new method
2825         thread_info_to_thread_handle.
2826         (remote_target::thread_info_to_thread_handle): Define.
2827
2828 2019-04-08  Pedro Alves  <palves@redhat.com>
2829
2830         * common/common-exceptions.c (throw_exception): Don't create
2831         named object to throw; throw directly.
2832         (throw_it): Likewise.  Don't initialize gdb_exception::message
2833         here, with new; pass FMT and AP to the ctor instead.
2834         * common/common-exceptions.h: Include <string>.
2835         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2836         const char *, va_list)): New ctor.  Use std::make_shared.
2837         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2838         errors)): Delete.
2839         (gdb_exception_error::gdb_exception_error(enum errors, const char
2840         *, va_list)): New.
2841         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2842         Add assertion.
2843         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2844         errors)): Delete.
2845         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2846         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2847         Add assertion.
2848
2849 2019-04-08  Tom Tromey  <tom@tromey.com>
2850
2851         * valops.c (value_rtti_indirect_type): Replace throw_exception
2852         with throw.
2853         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2854         with throw.
2855         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2856         throw.
2857         * target.c (target_translate_tls_address): Replace throw_exception
2858         with throw.
2859         * stack.c (frame_apply_command_count): Replace throw_exception
2860         with throw.
2861         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2862         throw.
2863         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2864         with throw.
2865         * rs6000-tdep.c (rs6000_frame_cache)
2866         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2867         * remote.c: Replace throw_exception with throw.
2868         * record-full.c (record_full_message, record_full_wait_1)
2869         (record_full_restore): Replace throw_exception with throw.
2870         * record-btrace.c:
2871         (get_thread_current_frame_id, record_btrace_start_replaying)
2872         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2873         (cmd_record_btrace_start): Replace throw_exception with throw.
2874         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2875         throw.
2876         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2877         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2878         * linespec.c:
2879         (find_linespec_symbols): Replace throw_exception with throw.
2880         * infrun.c (displaced_step_prepare, resume): Replace
2881         throw_exception with throw.
2882         * infcmd.c (post_create_inferior): Replace throw_exception with
2883         throw.
2884         * inf-loop.c (inferior_event_handler): Replace throw_exception
2885         with throw.
2886         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2887         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2888         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2889         (get_prev_frame_always, get_frame_pc_if_available)
2890         (get_frame_address_in_block_if_available, get_frame_language):
2891         Replace throw_exception with throw.
2892         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2893         throw_exception with throw.
2894         * eval.c (fetch_subexp_value, evaluate_var_value)
2895         (evaluate_funcall, evaluate_subexp_standard): Replace
2896         throw_exception with throw.
2897         * dwarf2loc.c (call_site_find_chain)
2898         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2899         Replace throw_exception with throw.
2900         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2901         with throw.
2902         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2903         throw.
2904         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2905         * completer.c (complete_line_internal): Replace throw_exception
2906         with throw.
2907         * compile/compile-object-run.c (compile_object_run): Replace
2908         throw_exception with throw.
2909         * cli/cli-script.c (process_next_line): Replace throw_exception
2910         with throw.
2911         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2912         (btrace_enable, btrace_maint_update_pt_packets): Replace
2913         throw_exception with throw.
2914         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2915         throw_exception with throw.
2916         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2917         throw_exception with throw.
2918         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2919         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2920         * aarch64-tdep.c (aarch64_make_prologue_cache)
2921         (aarch64_make_stub_cache): Replace throw_exception with throw.
2922
2923 2019-04-08  Tom Tromey  <tom@tromey.com>
2924
2925         * common/common-exceptions.c (throw_exception): Rename from
2926         throw_exception_cxx.  Remove old copy.  Make argument const.
2927         (throw_it): Create and throw exception objects directly.
2928         * common/common-exceptions.h (throw_exception): Make argument
2929         const.
2930         (struct gdb_exception_error): Add constructor.
2931         (struct gdb_exception_quit): Add constructor.
2932
2933 2019-04-08  Tom Tromey  <tom@tromey.com>
2934
2935         * common/common-exceptions.h (exception_rethrow): Don't declare.
2936         (TRY_SJLJ): Update comment.
2937         (TRY, CATCH, END_CATCH): Remove.
2938         * common/common-exceptions.c (exception_rethrow): Remove.
2939
2940 2019-04-08  Tom Tromey  <tom@tromey.com>
2941
2942         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2943         Remove.
2944         (gdb_exception_error): Rename from
2945         gdb_exception_RETURN_MASK_ERROR.
2946         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2947         (gdb_quit_bad_alloc): Update.
2948         * aarch64-tdep.c: Update.
2949         * ada-lang.c: Update.
2950         * ada-typeprint.c: Update.
2951         * ada-valprint.c: Update.
2952         * amd64-tdep.c: Update.
2953         * arch-utils.c: Update.
2954         * break-catch-throw.c: Update.
2955         * breakpoint.c: Update.
2956         * btrace.c: Update.
2957         * c-varobj.c: Update.
2958         * cli/cli-cmds.c: Update.
2959         * cli/cli-interp.c: Update.
2960         * cli/cli-script.c: Update.
2961         * common/common-exceptions.c: Update.
2962         * common/new-op.c: Update.
2963         * common/selftest.c: Update.
2964         * compile/compile-c-symbols.c: Update.
2965         * compile/compile-cplus-symbols.c: Update.
2966         * compile/compile-object-load.c: Update.
2967         * compile/compile-object-run.c: Update.
2968         * completer.c: Update.
2969         * corelow.c: Update.
2970         * cp-abi.c: Update.
2971         * cp-support.c: Update.
2972         * cp-valprint.c: Update.
2973         * darwin-nat.c: Update.
2974         * disasm-selftests.c: Update.
2975         * dtrace-probe.c: Update.
2976         * dwarf-index-cache.c: Update.
2977         * dwarf-index-write.c: Update.
2978         * dwarf2-frame-tailcall.c: Update.
2979         * dwarf2-frame.c: Update.
2980         * dwarf2loc.c: Update.
2981         * dwarf2read.c: Update.
2982         * eval.c: Update.
2983         * event-loop.c: Update.
2984         * event-top.c: Update.
2985         * exec.c: Update.
2986         * f-valprint.c: Update.
2987         * fbsd-tdep.c: Update.
2988         * frame-unwind.c: Update.
2989         * frame.c: Update.
2990         * gdbtypes.c: Update.
2991         * gnu-v3-abi.c: Update.
2992         * guile/guile-internal.h: Update.
2993         * guile/scm-block.c: Update.
2994         * guile/scm-breakpoint.c: Update.
2995         * guile/scm-cmd.c: Update.
2996         * guile/scm-disasm.c: Update.
2997         * guile/scm-frame.c: Update.
2998         * guile/scm-lazy-string.c: Update.
2999         * guile/scm-math.c: Update.
3000         * guile/scm-param.c: Update.
3001         * guile/scm-ports.c: Update.
3002         * guile/scm-pretty-print.c: Update.
3003         * guile/scm-symbol.c: Update.
3004         * guile/scm-symtab.c: Update.
3005         * guile/scm-type.c: Update.
3006         * guile/scm-value.c: Update.
3007         * i386-linux-tdep.c: Update.
3008         * i386-tdep.c: Update.
3009         * inf-loop.c: Update.
3010         * infcall.c: Update.
3011         * infcmd.c: Update.
3012         * infrun.c: Update.
3013         * jit.c: Update.
3014         * language.c: Update.
3015         * linespec.c: Update.
3016         * linux-fork.c: Update.
3017         * linux-nat.c: Update.
3018         * linux-tdep.c: Update.
3019         * linux-thread-db.c: Update.
3020         * main.c: Update.
3021         * mi/mi-cmd-break.c: Update.
3022         * mi/mi-cmd-stack.c: Update.
3023         * mi/mi-interp.c: Update.
3024         * mi/mi-main.c: Update.
3025         * objc-lang.c: Update.
3026         * p-valprint.c: Update.
3027         * parse.c: Update.
3028         * ppc-linux-tdep.c: Update.
3029         * printcmd.c: Update.
3030         * python/py-arch.c: Update.
3031         * python/py-breakpoint.c: Update.
3032         * python/py-cmd.c: Update.
3033         * python/py-finishbreakpoint.c: Update.
3034         * python/py-frame.c: Update.
3035         * python/py-framefilter.c: Update.
3036         * python/py-gdb-readline.c: Update.
3037         * python/py-inferior.c: Update.
3038         * python/py-infthread.c: Update.
3039         * python/py-lazy-string.c: Update.
3040         * python/py-linetable.c: Update.
3041         * python/py-objfile.c: Update.
3042         * python/py-param.c: Update.
3043         * python/py-prettyprint.c: Update.
3044         * python/py-progspace.c: Update.
3045         * python/py-record-btrace.c: Update.
3046         * python/py-record.c: Update.
3047         * python/py-symbol.c: Update.
3048         * python/py-type.c: Update.
3049         * python/py-unwind.c: Update.
3050         * python/py-utils.c: Update.
3051         * python/py-value.c: Update.
3052         * python/python.c: Update.
3053         * record-btrace.c: Update.
3054         * record-full.c: Update.
3055         * remote-fileio.c: Update.
3056         * remote.c: Update.
3057         * riscv-tdep.c: Update.
3058         * rs6000-aix-tdep.c: Update.
3059         * rs6000-tdep.c: Update.
3060         * rust-exp.y: Update.
3061         * rust-lang.c: Update.
3062         * s390-tdep.c: Update.
3063         * selftest-arch.c: Update.
3064         * solib-dsbt.c: Update.
3065         * solib-frv.c: Update.
3066         * solib-spu.c: Update.
3067         * solib-svr4.c: Update.
3068         * solib.c: Update.
3069         * sparc64-linux-tdep.c: Update.
3070         * stack.c: Update.
3071         * symfile-mem.c: Update.
3072         * symmisc.c: Update.
3073         * target.c: Update.
3074         * thread.c: Update.
3075         * top.c: Update.
3076         * tracefile-tfile.c: Update.
3077         * tui/tui.c: Update.
3078         * typeprint.c: Update.
3079         * unittests/cli-utils-selftests.c: Update.
3080         * unittests/parse-connection-spec-selftests.c: Update.
3081         * valops.c: Update.
3082         * valprint.c: Update.
3083         * value.c: Update.
3084         * varobj.c: Update.
3085         * windows-nat.c: Update.
3086         * x86-linux-nat.c: Update.
3087         * xml-support.c: Update.
3088
3089 2019-04-08  Tom Tromey  <tom@tromey.com>
3090
3091         * xml-support.c: Use C++ exception handling.
3092         * x86-linux-nat.c: Use C++ exception handling.
3093         * windows-nat.c: Use C++ exception handling.
3094         * varobj.c: Use C++ exception handling.
3095         * value.c: Use C++ exception handling.
3096         * valprint.c: Use C++ exception handling.
3097         * valops.c: Use C++ exception handling.
3098         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3099         handling.
3100         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3101         * typeprint.c: Use C++ exception handling.
3102         * tui/tui.c: Use C++ exception handling.
3103         * tracefile-tfile.c: Use C++ exception handling.
3104         * top.c: Use C++ exception handling.
3105         * thread.c: Use C++ exception handling.
3106         * target.c: Use C++ exception handling.
3107         * symmisc.c: Use C++ exception handling.
3108         * symfile-mem.c: Use C++ exception handling.
3109         * stack.c: Use C++ exception handling.
3110         * sparc64-linux-tdep.c: Use C++ exception handling.
3111         * solib.c: Use C++ exception handling.
3112         * solib-svr4.c: Use C++ exception handling.
3113         * solib-spu.c: Use C++ exception handling.
3114         * solib-frv.c: Use C++ exception handling.
3115         * solib-dsbt.c: Use C++ exception handling.
3116         * selftest-arch.c: Use C++ exception handling.
3117         * s390-tdep.c: Use C++ exception handling.
3118         * rust-lang.c: Use C++ exception handling.
3119         * rust-exp.y: Use C++ exception handling.
3120         * rs6000-tdep.c: Use C++ exception handling.
3121         * rs6000-aix-tdep.c: Use C++ exception handling.
3122         * riscv-tdep.c: Use C++ exception handling.
3123         * remote.c: Use C++ exception handling.
3124         * remote-fileio.c: Use C++ exception handling.
3125         * record-full.c: Use C++ exception handling.
3126         * record-btrace.c: Use C++ exception handling.
3127         * python/python.c: Use C++ exception handling.
3128         * python/py-value.c: Use C++ exception handling.
3129         * python/py-utils.c: Use C++ exception handling.
3130         * python/py-unwind.c: Use C++ exception handling.
3131         * python/py-type.c: Use C++ exception handling.
3132         * python/py-symbol.c: Use C++ exception handling.
3133         * python/py-record.c: Use C++ exception handling.
3134         * python/py-record-btrace.c: Use C++ exception handling.
3135         * python/py-progspace.c: Use C++ exception handling.
3136         * python/py-prettyprint.c: Use C++ exception handling.
3137         * python/py-param.c: Use C++ exception handling.
3138         * python/py-objfile.c: Use C++ exception handling.
3139         * python/py-linetable.c: Use C++ exception handling.
3140         * python/py-lazy-string.c: Use C++ exception handling.
3141         * python/py-infthread.c: Use C++ exception handling.
3142         * python/py-inferior.c: Use C++ exception handling.
3143         * python/py-gdb-readline.c: Use C++ exception handling.
3144         * python/py-framefilter.c: Use C++ exception handling.
3145         * python/py-frame.c: Use C++ exception handling.
3146         * python/py-finishbreakpoint.c: Use C++ exception handling.
3147         * python/py-cmd.c: Use C++ exception handling.
3148         * python/py-breakpoint.c: Use C++ exception handling.
3149         * python/py-arch.c: Use C++ exception handling.
3150         * printcmd.c: Use C++ exception handling.
3151         * ppc-linux-tdep.c: Use C++ exception handling.
3152         * parse.c: Use C++ exception handling.
3153         * p-valprint.c: Use C++ exception handling.
3154         * objc-lang.c: Use C++ exception handling.
3155         * mi/mi-main.c: Use C++ exception handling.
3156         * mi/mi-interp.c: Use C++ exception handling.
3157         * mi/mi-cmd-stack.c: Use C++ exception handling.
3158         * mi/mi-cmd-break.c: Use C++ exception handling.
3159         * main.c: Use C++ exception handling.
3160         * linux-thread-db.c: Use C++ exception handling.
3161         * linux-tdep.c: Use C++ exception handling.
3162         * linux-nat.c: Use C++ exception handling.
3163         * linux-fork.c: Use C++ exception handling.
3164         * linespec.c: Use C++ exception handling.
3165         * language.c: Use C++ exception handling.
3166         * jit.c: Use C++ exception handling.
3167         * infrun.c: Use C++ exception handling.
3168         * infcmd.c: Use C++ exception handling.
3169         * infcall.c: Use C++ exception handling.
3170         * inf-loop.c: Use C++ exception handling.
3171         * i386-tdep.c: Use C++ exception handling.
3172         * i386-linux-tdep.c: Use C++ exception handling.
3173         * guile/scm-value.c: Use C++ exception handling.
3174         * guile/scm-type.c: Use C++ exception handling.
3175         * guile/scm-symtab.c: Use C++ exception handling.
3176         * guile/scm-symbol.c: Use C++ exception handling.
3177         * guile/scm-pretty-print.c: Use C++ exception handling.
3178         * guile/scm-ports.c: Use C++ exception handling.
3179         * guile/scm-param.c: Use C++ exception handling.
3180         * guile/scm-math.c: Use C++ exception handling.
3181         * guile/scm-lazy-string.c: Use C++ exception handling.
3182         * guile/scm-frame.c: Use C++ exception handling.
3183         * guile/scm-disasm.c: Use C++ exception handling.
3184         * guile/scm-cmd.c: Use C++ exception handling.
3185         * guile/scm-breakpoint.c: Use C++ exception handling.
3186         * guile/scm-block.c: Use C++ exception handling.
3187         * guile/guile-internal.h: Use C++ exception handling.
3188         * gnu-v3-abi.c: Use C++ exception handling.
3189         * gdbtypes.c: Use C++ exception handling.
3190         * frame.c: Use C++ exception handling.
3191         * frame-unwind.c: Use C++ exception handling.
3192         * fbsd-tdep.c: Use C++ exception handling.
3193         * f-valprint.c: Use C++ exception handling.
3194         * exec.c: Use C++ exception handling.
3195         * event-top.c: Use C++ exception handling.
3196         * event-loop.c: Use C++ exception handling.
3197         * eval.c: Use C++ exception handling.
3198         * dwarf2read.c: Use C++ exception handling.
3199         * dwarf2loc.c: Use C++ exception handling.
3200         * dwarf2-frame.c: Use C++ exception handling.
3201         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3202         * dwarf-index-write.c: Use C++ exception handling.
3203         * dwarf-index-cache.c: Use C++ exception handling.
3204         * dtrace-probe.c: Use C++ exception handling.
3205         * disasm-selftests.c: Use C++ exception handling.
3206         * darwin-nat.c: Use C++ exception handling.
3207         * cp-valprint.c: Use C++ exception handling.
3208         * cp-support.c: Use C++ exception handling.
3209         * cp-abi.c: Use C++ exception handling.
3210         * corelow.c: Use C++ exception handling.
3211         * completer.c: Use C++ exception handling.
3212         * compile/compile-object-run.c: Use C++ exception handling.
3213         * compile/compile-object-load.c: Use C++ exception handling.
3214         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3215         * compile/compile-c-symbols.c: Use C++ exception handling.
3216         * common/selftest.c: Use C++ exception handling.
3217         * common/new-op.c: Use C++ exception handling.
3218         * cli/cli-script.c: Use C++ exception handling.
3219         * cli/cli-interp.c: Use C++ exception handling.
3220         * cli/cli-cmds.c: Use C++ exception handling.
3221         * c-varobj.c: Use C++ exception handling.
3222         * btrace.c: Use C++ exception handling.
3223         * breakpoint.c: Use C++ exception handling.
3224         * break-catch-throw.c: Use C++ exception handling.
3225         * arch-utils.c: Use C++ exception handling.
3226         * amd64-tdep.c: Use C++ exception handling.
3227         * ada-valprint.c: Use C++ exception handling.
3228         * ada-typeprint.c: Use C++ exception handling.
3229         * ada-lang.c: Use C++ exception handling.
3230         * aarch64-tdep.c: Use C++ exception handling.
3231
3232 2019-04-08  Tom Tromey  <tom@tromey.com>
3233
3234         * xml-support.c (gdb_xml_parser::parse): Update.
3235         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3236         * value.c (show_convenience): Update.
3237         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3238         (test_parse_flags_qcs): Update.
3239         * thread.c (thr_try_catch_cmd): Update.
3240         * target.c (target_translate_tls_address): Update.
3241         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3242         (info_frame_command_core, frame_apply_command_count): Update.
3243         * rust-exp.y (rust_lex_exception_test): Update.
3244         * riscv-tdep.c (riscv_print_one_register_info): Update.
3245         * remote.c (remote_target::enable_btrace): Update.
3246         * record-btrace.c (record_btrace_enable_warn): Update.
3247         * python/py-utils.c (gdbpy_convert_exception): Update.
3248         * printcmd.c (do_one_display, print_variable_and_value): Update.
3249         * mi/mi-main.c (mi_print_exception): Update.
3250         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3251         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3252         * linux-nat.c (linux_nat_target::attach): Update.
3253         * linux-fork.c (class scoped_switch_fork_info): Update.
3254         * infrun.c (displaced_step_prepare): Update.
3255         * infcall.c (call_function_by_hand_dummy): Update.
3256         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3257         * gnu-v3-abi.c (print_one_vtable): Update.
3258         * frame.c (get_prev_frame_always): Update.
3259         * f-valprint.c (info_common_command_for_block): Update.
3260         * exec.c (try_open_exec_file): Update.
3261         * exceptions.c (print_exception, exception_print)
3262         (exception_fprintf, exception_print_same): Update.
3263         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3264         * dwarf-index-cache.c (index_cache::store)
3265         (index_cache::lookup_gdb_index): Update.
3266         * darwin-nat.c (maybe_cache_shell): Update.
3267         * cp-valprint.c (cp_print_value_fields): Update.
3268         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3269         (gcc_cplus_symbol_address): Update.
3270         * compile/compile-c-symbols.c (gcc_convert_symbol)
3271         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3272         * common/selftest.c: Update.
3273         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3274         a std::string.
3275         (exception_try_scope_entry, exception_try_scope_exit): Don't
3276         declare.
3277         (struct exception_try_scope): Remove.
3278         (TRY): Don't use exception_try_scope.
3279         (struct gdb_exception): Add constructor, operator=.
3280         <what>: New method.
3281         (struct gdb_exception_RETURN_MASK_ALL)
3282         (struct gdb_exception_RETURN_MASK_ERROR)
3283         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3284         (struct gdb_quit_bad_alloc): Update.
3285         * common/common-exceptions.c (exception_none): Change
3286         initializer.
3287         (struct catcher) <state, exception>: Initialize inline.
3288         <prev>: Remove member.
3289         (current_catcher): Remove.
3290         (catchers): New global.
3291         (exceptions_state_mc_init): Simplify.
3292         (catcher_pop): Remove.
3293         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3294         (try_scope_depth, exception_try_scope_entry)
3295         (exception_try_scope_exit): Remove.
3296         (throw_exception_sjlj): Update.
3297         (exception_messages, exception_messages_size): Remove.
3298         (throw_it): Simplify.
3299         (gdb_exception_sliced_copy): Remove.
3300         (throw_exception_cxx): Update.
3301         * cli/cli-script.c (script_from_file): Update.
3302         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3303         Update.
3304         * ada-valprint.c (ada_val_print): Update.
3305         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3306         (create_excep_cond_exprs): Update.
3307
3308 2019-04-08  Tom Tromey  <tom@tromey.com>
3309
3310         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3311         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3312         (TRY, CATCH, END_CATCH): Remove some definitions.
3313         * common/common-exceptions.c: Don't use GDB_XCPT.
3314         (catcher_list_size): Remove.
3315         (throw_exception, throw_it): Simplify.
3316
3317 2019-04-05  Tom Tromey  <tom@tromey.com>
3318
3319         Revert the header-sorting patch.
3320         * ft32-tdep.c: Revert.
3321         * frv-tdep.c: Revert.
3322         * frv-linux-tdep.c: Revert.
3323         * frame.c: Revert.
3324         * frame-unwind.c: Revert.
3325         * frame-base.c: Revert.
3326         * fork-child.c: Revert.
3327         * findvar.c: Revert.
3328         * findcmd.c: Revert.
3329         * filesystem.c: Revert.
3330         * filename-seen-cache.h: Revert.
3331         * filename-seen-cache.c: Revert.
3332         * fbsd-tdep.c: Revert.
3333         * fbsd-nat.h: Revert.
3334         * fbsd-nat.c: Revert.
3335         * f-valprint.c: Revert.
3336         * f-typeprint.c: Revert.
3337         * f-lang.c: Revert.
3338         * extension.h: Revert.
3339         * extension.c: Revert.
3340         * extension-priv.h: Revert.
3341         * expprint.c: Revert.
3342         * exec.h: Revert.
3343         * exec.c: Revert.
3344         * exceptions.c: Revert.
3345         * event-top.c: Revert.
3346         * event-loop.c: Revert.
3347         * eval.c: Revert.
3348         * elfread.c: Revert.
3349         * dwarf2read.h: Revert.
3350         * dwarf2read.c: Revert.
3351         * dwarf2loc.c: Revert.
3352         * dwarf2expr.h: Revert.
3353         * dwarf2expr.c: Revert.
3354         * dwarf2-frame.c: Revert.
3355         * dwarf2-frame-tailcall.c: Revert.
3356         * dwarf-index-write.h: Revert.
3357         * dwarf-index-write.c: Revert.
3358         * dwarf-index-common.c: Revert.
3359         * dwarf-index-cache.h: Revert.
3360         * dwarf-index-cache.c: Revert.
3361         * dummy-frame.c: Revert.
3362         * dtrace-probe.c: Revert.
3363         * disasm.h: Revert.
3364         * disasm.c: Revert.
3365         * disasm-selftests.c: Revert.
3366         * dictionary.c: Revert.
3367         * dicos-tdep.c: Revert.
3368         * demangle.c: Revert.
3369         * dcache.h: Revert.
3370         * dcache.c: Revert.
3371         * darwin-nat.h: Revert.
3372         * darwin-nat.c: Revert.
3373         * darwin-nat-info.c: Revert.
3374         * d-valprint.c: Revert.
3375         * d-namespace.c: Revert.
3376         * d-lang.c: Revert.
3377         * ctf.c: Revert.
3378         * csky-tdep.c: Revert.
3379         * csky-linux-tdep.c: Revert.
3380         * cris-tdep.c: Revert.
3381         * cris-linux-tdep.c: Revert.
3382         * cp-valprint.c: Revert.
3383         * cp-support.c: Revert.
3384         * cp-namespace.c: Revert.
3385         * cp-abi.c: Revert.
3386         * corelow.c: Revert.
3387         * corefile.c: Revert.
3388         * continuations.c: Revert.
3389         * completer.h: Revert.
3390         * completer.c: Revert.
3391         * complaints.c: Revert.
3392         * coffread.c: Revert.
3393         * coff-pe-read.c: Revert.
3394         * cli-out.h: Revert.
3395         * cli-out.c: Revert.
3396         * charset.c: Revert.
3397         * c-varobj.c: Revert.
3398         * c-valprint.c: Revert.
3399         * c-typeprint.c: Revert.
3400         * c-lang.c: Revert.
3401         * buildsym.c: Revert.
3402         * buildsym-legacy.c: Revert.
3403         * build-id.h: Revert.
3404         * build-id.c: Revert.
3405         * btrace.c: Revert.
3406         * bsd-uthread.c: Revert.
3407         * breakpoint.h: Revert.
3408         * breakpoint.c: Revert.
3409         * break-catch-throw.c: Revert.
3410         * break-catch-syscall.c: Revert.
3411         * break-catch-sig.c: Revert.
3412         * blockframe.c: Revert.
3413         * block.c: Revert.
3414         * bfin-tdep.c: Revert.
3415         * bfin-linux-tdep.c: Revert.
3416         * bfd-target.c: Revert.
3417         * bcache.c: Revert.
3418         * ax-general.c: Revert.
3419         * ax-gdb.h: Revert.
3420         * ax-gdb.c: Revert.
3421         * avr-tdep.c: Revert.
3422         * auxv.c: Revert.
3423         * auto-load.c: Revert.
3424         * arm-wince-tdep.c: Revert.
3425         * arm-tdep.c: Revert.
3426         * arm-symbian-tdep.c: Revert.
3427         * arm-pikeos-tdep.c: Revert.
3428         * arm-obsd-tdep.c: Revert.
3429         * arm-nbsd-tdep.c: Revert.
3430         * arm-nbsd-nat.c: Revert.
3431         * arm-linux-tdep.c: Revert.
3432         * arm-linux-nat.c: Revert.
3433         * arm-fbsd-tdep.c: Revert.
3434         * arm-fbsd-nat.c: Revert.
3435         * arm-bsd-tdep.c: Revert.
3436         * arch-utils.c: Revert.
3437         * arc-tdep.c: Revert.
3438         * arc-newlib-tdep.c: Revert.
3439         * annotate.h: Revert.
3440         * annotate.c: Revert.
3441         * amd64-windows-tdep.c: Revert.
3442         * amd64-windows-nat.c: Revert.
3443         * amd64-tdep.c: Revert.
3444         * amd64-sol2-tdep.c: Revert.
3445         * amd64-obsd-tdep.c: Revert.
3446         * amd64-obsd-nat.c: Revert.
3447         * amd64-nbsd-tdep.c: Revert.
3448         * amd64-nbsd-nat.c: Revert.
3449         * amd64-nat.c: Revert.
3450         * amd64-linux-tdep.c: Revert.
3451         * amd64-linux-nat.c: Revert.
3452         * amd64-fbsd-tdep.c: Revert.
3453         * amd64-fbsd-nat.c: Revert.
3454         * amd64-dicos-tdep.c: Revert.
3455         * amd64-darwin-tdep.c: Revert.
3456         * amd64-bsd-nat.c: Revert.
3457         * alpha-tdep.c: Revert.
3458         * alpha-obsd-tdep.c: Revert.
3459         * alpha-nbsd-tdep.c: Revert.
3460         * alpha-mdebug-tdep.c: Revert.
3461         * alpha-linux-tdep.c: Revert.
3462         * alpha-linux-nat.c: Revert.
3463         * alpha-bsd-tdep.c: Revert.
3464         * alpha-bsd-nat.c: Revert.
3465         * aix-thread.c: Revert.
3466         * agent.c: Revert.
3467         * addrmap.c: Revert.
3468         * ada-varobj.c: Revert.
3469         * ada-valprint.c: Revert.
3470         * ada-typeprint.c: Revert.
3471         * ada-tasks.c: Revert.
3472         * ada-lang.c: Revert.
3473         * aarch64-tdep.c: Revert.
3474         * aarch64-ravenscar-thread.c: Revert.
3475         * aarch64-newlib-tdep.c: Revert.
3476         * aarch64-linux-tdep.c: Revert.
3477         * aarch64-linux-nat.c: Revert.
3478         * aarch64-fbsd-tdep.c: Revert.
3479         * aarch64-fbsd-nat.c: Revert.
3480         * aarch32-linux-nat.c: Revert.
3481
3482 2019-04-05  Tom Tromey  <tom@tromey.com>
3483
3484         * ft32-tdep.c: Sort headers.
3485         * frv-tdep.c: Sort headers.
3486         * frv-linux-tdep.c: Sort headers.
3487         * frame.c: Sort headers.
3488         * frame-unwind.c: Sort headers.
3489         * frame-base.c: Sort headers.
3490         * fork-child.c: Sort headers.
3491         * findvar.c: Sort headers.
3492         * findcmd.c: Sort headers.
3493         * filesystem.c: Sort headers.
3494         * filename-seen-cache.h: Sort headers.
3495         * filename-seen-cache.c: Sort headers.
3496         * fbsd-tdep.c: Sort headers.
3497         * fbsd-nat.h: Sort headers.
3498         * fbsd-nat.c: Sort headers.
3499         * f-valprint.c: Sort headers.
3500         * f-typeprint.c: Sort headers.
3501         * f-lang.c: Sort headers.
3502         * extension.h: Sort headers.
3503         * extension.c: Sort headers.
3504         * extension-priv.h: Sort headers.
3505         * expprint.c: Sort headers.
3506         * exec.h: Sort headers.
3507         * exec.c: Sort headers.
3508         * exceptions.c: Sort headers.
3509         * event-top.c: Sort headers.
3510         * event-loop.c: Sort headers.
3511         * eval.c: Sort headers.
3512         * elfread.c: Sort headers.
3513         * dwarf2read.h: Sort headers.
3514         * dwarf2read.c: Sort headers.
3515         * dwarf2loc.c: Sort headers.
3516         * dwarf2expr.h: Sort headers.
3517         * dwarf2expr.c: Sort headers.
3518         * dwarf2-frame.c: Sort headers.
3519         * dwarf2-frame-tailcall.c: Sort headers.
3520         * dwarf-index-write.h: Sort headers.
3521         * dwarf-index-write.c: Sort headers.
3522         * dwarf-index-common.c: Sort headers.
3523         * dwarf-index-cache.h: Sort headers.
3524         * dwarf-index-cache.c: Sort headers.
3525         * dummy-frame.c: Sort headers.
3526         * dtrace-probe.c: Sort headers.
3527         * disasm.h: Sort headers.
3528         * disasm.c: Sort headers.
3529         * disasm-selftests.c: Sort headers.
3530         * dictionary.c: Sort headers.
3531         * dicos-tdep.c: Sort headers.
3532         * demangle.c: Sort headers.
3533         * dcache.h: Sort headers.
3534         * dcache.c: Sort headers.
3535         * darwin-nat.h: Sort headers.
3536         * darwin-nat.c: Sort headers.
3537         * darwin-nat-info.c: Sort headers.
3538         * d-valprint.c: Sort headers.
3539         * d-namespace.c: Sort headers.
3540         * d-lang.c: Sort headers.
3541         * ctf.c: Sort headers.
3542         * csky-tdep.c: Sort headers.
3543         * csky-linux-tdep.c: Sort headers.
3544         * cris-tdep.c: Sort headers.
3545         * cris-linux-tdep.c: Sort headers.
3546         * cp-valprint.c: Sort headers.
3547         * cp-support.c: Sort headers.
3548         * cp-namespace.c: Sort headers.
3549         * cp-abi.c: Sort headers.
3550         * corelow.c: Sort headers.
3551         * corefile.c: Sort headers.
3552         * continuations.c: Sort headers.
3553         * completer.h: Sort headers.
3554         * completer.c: Sort headers.
3555         * complaints.c: Sort headers.
3556         * coffread.c: Sort headers.
3557         * coff-pe-read.c: Sort headers.
3558         * cli-out.h: Sort headers.
3559         * cli-out.c: Sort headers.
3560         * charset.c: Sort headers.
3561         * c-varobj.c: Sort headers.
3562         * c-valprint.c: Sort headers.
3563         * c-typeprint.c: Sort headers.
3564         * c-lang.c: Sort headers.
3565         * buildsym.c: Sort headers.
3566         * buildsym-legacy.c: Sort headers.
3567         * build-id.h: Sort headers.
3568         * build-id.c: Sort headers.
3569         * btrace.c: Sort headers.
3570         * bsd-uthread.c: Sort headers.
3571         * breakpoint.h: Sort headers.
3572         * breakpoint.c: Sort headers.
3573         * break-catch-throw.c: Sort headers.
3574         * break-catch-syscall.c: Sort headers.
3575         * break-catch-sig.c: Sort headers.
3576         * blockframe.c: Sort headers.
3577         * block.c: Sort headers.
3578         * bfin-tdep.c: Sort headers.
3579         * bfin-linux-tdep.c: Sort headers.
3580         * bfd-target.c: Sort headers.
3581         * bcache.c: Sort headers.
3582         * ax-general.c: Sort headers.
3583         * ax-gdb.h: Sort headers.
3584         * ax-gdb.c: Sort headers.
3585         * avr-tdep.c: Sort headers.
3586         * auxv.c: Sort headers.
3587         * auto-load.c: Sort headers.
3588         * arm-wince-tdep.c: Sort headers.
3589         * arm-tdep.c: Sort headers.
3590         * arm-symbian-tdep.c: Sort headers.
3591         * arm-pikeos-tdep.c: Sort headers.
3592         * arm-obsd-tdep.c: Sort headers.
3593         * arm-nbsd-tdep.c: Sort headers.
3594         * arm-nbsd-nat.c: Sort headers.
3595         * arm-linux-tdep.c: Sort headers.
3596         * arm-linux-nat.c: Sort headers.
3597         * arm-fbsd-tdep.c: Sort headers.
3598         * arm-fbsd-nat.c: Sort headers.
3599         * arm-bsd-tdep.c: Sort headers.
3600         * arch-utils.c: Sort headers.
3601         * arc-tdep.c: Sort headers.
3602         * arc-newlib-tdep.c: Sort headers.
3603         * annotate.h: Sort headers.
3604         * annotate.c: Sort headers.
3605         * amd64-windows-tdep.c: Sort headers.
3606         * amd64-windows-nat.c: Sort headers.
3607         * amd64-tdep.c: Sort headers.
3608         * amd64-sol2-tdep.c: Sort headers.
3609         * amd64-obsd-tdep.c: Sort headers.
3610         * amd64-obsd-nat.c: Sort headers.
3611         * amd64-nbsd-tdep.c: Sort headers.
3612         * amd64-nbsd-nat.c: Sort headers.
3613         * amd64-nat.c: Sort headers.
3614         * amd64-linux-tdep.c: Sort headers.
3615         * amd64-linux-nat.c: Sort headers.
3616         * amd64-fbsd-tdep.c: Sort headers.
3617         * amd64-fbsd-nat.c: Sort headers.
3618         * amd64-dicos-tdep.c: Sort headers.
3619         * amd64-darwin-tdep.c: Sort headers.
3620         * amd64-bsd-nat.c: Sort headers.
3621         * alpha-tdep.c: Sort headers.
3622         * alpha-obsd-tdep.c: Sort headers.
3623         * alpha-nbsd-tdep.c: Sort headers.
3624         * alpha-mdebug-tdep.c: Sort headers.
3625         * alpha-linux-tdep.c: Sort headers.
3626         * alpha-linux-nat.c: Sort headers.
3627         * alpha-bsd-tdep.c: Sort headers.
3628         * alpha-bsd-nat.c: Sort headers.
3629         * aix-thread.c: Sort headers.
3630         * agent.c: Sort headers.
3631         * addrmap.c: Sort headers.
3632         * ada-varobj.c: Sort headers.
3633         * ada-valprint.c: Sort headers.
3634         * ada-typeprint.c: Sort headers.
3635         * ada-tasks.c: Sort headers.
3636         * ada-lang.c: Sort headers.
3637         * aarch64-tdep.c: Sort headers.
3638         * aarch64-ravenscar-thread.c: Sort headers.
3639         * aarch64-newlib-tdep.c: Sort headers.
3640         * aarch64-linux-tdep.c: Sort headers.
3641         * aarch64-linux-nat.c: Sort headers.
3642         * aarch64-fbsd-tdep.c: Sort headers.
3643         * aarch64-fbsd-nat.c: Sort headers.
3644         * aarch32-linux-nat.c: Sort headers.
3645
3646 2019-04-04  Tom Tromey  <tom@tromey.com>
3647
3648         * varobj.c (varobj_create): Update.
3649         * rust-exp.y (struct rust_parser) <update_innermost_block,
3650         lookup_symbol>: New methods.
3651         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3652         Rename.
3653         (rust_parser::rust_lookup_type)
3654         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3655         * printcmd.c (display_command, do_one_display): Update.
3656         * parser-defs.h (struct parser_state) <parser_state>: Add
3657         "tracker" parameter.
3658         (block_tracker): New member.
3659         (class innermost_block_tracker) <innermost_block_tracker>: Add
3660         "types" parameter.
3661         <reset>: Remove method.
3662         (innermost_block): Don't declare.
3663         (null_post_parser): Update.
3664         * parse.c (innermost_block): Remove global.
3665         (write_dollar_variable): Update.
3666         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3667         Remove "tracker_types" parameter.
3668         (parse_expression): Add "tracker" parameter.
3669         (parse_expression_for_completion): Update.
3670         (null_post_parser): Add "tracker" parameter.
3671         * p-exp.y: Update rules.
3672         * m2-exp.y: Update rules.
3673         * language.h (struct language_defn) <la_post_parser>: Add
3674         "tracker" parameter.
3675         * go-exp.y: Update rules.
3676         * f-exp.y: Update rules.
3677         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3678         parameter.
3679         * d-exp.y: Update rules.
3680         * c-exp.y: Update rules.
3681         * breakpoint.c (set_breakpoint_condition): Create an
3682         innermost_block_tracker.
3683         (watch_command_1): Likewise.
3684         * ada-lang.c (resolve): Add "tracker" parameter.
3685         (resolve_subexp): Likewise.
3686         * ada-exp.y (write_var_from_sym): Update.
3687
3688 2019-04-04  Tom Tromey  <tom@tromey.com>
3689
3690         * type-stack.h: New file.
3691         * type-stack.c: New file.
3692         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3693         type-stack.h.
3694         (insert_into_type_stack, insert_type, push_type, push_type_int)
3695         (insert_type_address_space, pop_type, pop_type_int)
3696         (pop_typelist, pop_type_stack, append_type_stack)
3697         (push_type_stack, get_type_stack, push_typelist)
3698         (follow_type_instance_flags, follow_types): Don't declare.
3699         * parse.c (type_stack): Remove global.
3700         (parse_exp_in_context): Update.
3701         (insert_into_type_stack, insert_type, push_type, push_type_int)
3702         (insert_type_address_space, pop_type, pop_type_int)
3703         (pop_typelist, pop_type_stack, append_type_stack)
3704         (push_type_stack, get_type_stack, push_typelist)
3705         (follow_type_instance_flags, follow_types): Remove (moved to
3706         type-stack.c).
3707         * f-exp.y (type_stack): New global.
3708         Update rules.
3709         (push_kind_type, f_parse): Update.
3710         * d-exp.y (type_stack): New global.
3711         Update rules.
3712         (d_parse): Update.
3713         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3714         Update rules.
3715         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3716         (HFILES_NO_SRCDIR): Add type-stack.h.
3717
3718 2019-04-04  Tom Tromey  <tom@tromey.com>
3719
3720         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3721         (rust_parser::convert_ast_to_expression, rust_parse)
3722         (rust_lex_test_completion, rust_lex_tests): Update.
3723         * parser-defs.h (struct expr_completion_state): New.
3724         (struct parser_state) <parser_state>: Add completion parameter.
3725         <mark_struct_expression, mark_completion_tag>: New methods.
3726         <parse_completion, m_completion_state>: New members.
3727         (prefixify_expression, null_post_parser): Update.
3728         (mark_struct_expression, mark_completion_tag): Don't declare.
3729         * parse.c (parse_completion, expout_last_struct)
3730         (expout_tag_completion_type, expout_completion_name): Remove
3731         globals.
3732         (parser_state::mark_struct_expression)
3733         (parser_state::mark_completion_tag): Now methods.
3734         (prefixify_expression): Add last_struct parameter.
3735         (prefixify_subexp): Likewise.
3736         (parse_exp_1): Update.
3737         (parse_exp_in_context): Add cstate parameter.  Update.
3738         (parse_expression_for_completion): Create an
3739         expr_completion_state.
3740         (null_post_parser): Add "completion" parameter.
3741         * p-exp.y: Update rules.
3742         (yylex): Update.
3743         * language.h (struct language_defn) <la_post_parser>: Add
3744         "completing" parameter.
3745         * go-exp.y: Update rules.
3746         (lex_one_token): Update.
3747         * expression.h (parse_completion): Don't declare.
3748         * d-exp.y: Update rules.
3749         (lex_one_token): Update rules.
3750         * c-exp.y: Update rules.
3751         (lex_one_token): Update.
3752         * ada-lang.c (resolve): Add "parse_completion" parameter.
3753         (resolve_subexp): Likewise.
3754         (ada_resolve_function): Likewise.
3755
3756 2019-04-04  Tom Tromey  <tom@tromey.com>
3757
3758         * parser-defs.h (struct parser_state) <start_arglist,
3759         end_arglist>: New methods.
3760         <arglist_len, m_funcall_chain>: New members.
3761         (arglist_len, start_arglist, end_arglist): Don't declare.
3762         * parse.c (arglist_len, funcall_chain): Remove global.
3763         (start_arglist, end_arglist): Remove functions.
3764         (parse_exp_in_context): Update.
3765         * p-exp.y: Update rules.
3766         * m2-exp.y: Update rules.
3767         * go-exp.y: Update rules.
3768         * f-exp.y: Update rules.
3769         * d-exp.y: Update rules.
3770         * c-exp.y: Update rules.
3771
3772 2019-04-04  Tom Tromey  <tom@tromey.com>
3773
3774         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3775         lex_operator, push_back>: New methods.
3776         Update all rules.
3777         (rust_parser::lex_hex, lex_escape): Rename and update.
3778         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3779         (rust_parser::lex_operator): Rename and update.
3780         (rust_parser::lex_number, rustyylex, rustyyerror)
3781         (rust_lex_test_init, rust_lex_test_sequence)
3782         (rust_lex_test_push_back, rust_lex_tests): Update.
3783         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3784         parameter.
3785         <lexptr, prev_lexptr>: New members.
3786         (lexptr, prev_lexptr): Don't declare.
3787         * parse.c (lexptr, prev_lexptr): Remove globals.
3788         (parse_exp_in_context): Update.
3789         * p-exp.y (yylex, yyerror): Update.
3790         * m2-exp.y (parse_number, yylex, yyerror): Update.
3791         * go-exp.y (lex_one_token, yyerror): Update.
3792         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3793         * d-exp.y (lex_one_token, yyerror): Update.
3794         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3795         (lex_one_token, yyerror): Update.
3796         * ada-lex.l (YY_INPUT): Update.
3797         (rewind_to_char): Update.
3798         * ada-exp.y (yyerror): Update.
3799
3800 2019-04-04  Tom Tromey  <tom@tromey.com>
3801
3802         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3803         * parser-defs.h (struct parser_state) <parser_state>: Add new
3804         parameter.
3805         <comma_terminates>: New member.
3806         (comma_terminates): Don't declare global.
3807         * parse.c (comma_terminates): Remove global.
3808         (parse_exp_in_context): Update.
3809         * p-exp.y (yylex): Update.
3810         * m2-exp.y (yylex): Update.
3811         * go-exp.y (lex_one_token): Update.
3812         * f-exp.y (yylex): Update.
3813         * d-exp.y (lex_one_token): Update.
3814         * c-exp.y (lex_one_token): Update.
3815         * ada-lex.l: Update.
3816
3817 2019-04-04  Tom Tromey  <tom@tromey.com>
3818
3819         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3820         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3821         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3822         * parser-defs.h (paren_depth): Don't declare.
3823         * parse.c (paren_depth): Remove global.
3824         (parse_exp_in_context): Update.
3825         * p-exp.y (paren_depth): New global.
3826         (pascal_parse): Initialize it.
3827         * m2-exp.y (paren_depth): New global.
3828         (m2_parse): Initialize it.
3829         * go-exp.y (paren_depth): New global.
3830         (go_parse): Initialize it.
3831         * f-exp.y (paren_depth): New global.
3832         (f_parse): Initialize it.
3833         * d-exp.y (paren_depth): New global.
3834         (d_parse): Initialize it.
3835         * c-exp.y (paren_depth): New global.
3836         (c_parse): Initialize it.
3837         * ada-lex.l (paren_depth): New global.
3838         (lexer_init): Initialize it.
3839
3840 2019-04-04  Tom Tromey  <tom@tromey.com>
3841
3842         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3843         (rust_parser::convert_ast_to_type)
3844         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3845         * parser-defs.h (struct parser_state) <parser_state>: Add
3846         parameters.  Initialize new members.
3847         <expression_context_block, expression_context_pc>: New members.
3848         * parse.c (expression_context_block, expression_context_pc):
3849         Remove globals.
3850         (parse_exp_in_context): Update.
3851         * p-exp.y: Update all rules.
3852         (yylex): Update.
3853         * m2-exp.y: Update all rules.
3854         (yylex): Update.
3855         * go-exp.y (yylex): Update.
3856         * f-exp.y (yylex): Update.
3857         * d-exp.y: Update all rules.
3858         (yylex): Update.
3859         * c-exp.y: Update all rules.
3860         (lex_one_token, classify_name, yylex, c_parse): Update.
3861         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3862
3863 2019-04-04  Tom Tromey  <tom@tromey.com>
3864
3865         * gdbarch.h, gdbarch.c: Rebuild.
3866         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3867         * stap-probe.h:
3868         (struct stap_parse_info): Replace "parser_state" with
3869         "expr_builder".
3870         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3871         (parser_state): New class.
3872         * parse.c (expr_builder): Rename.
3873         (expr_builder::release): Rename.
3874         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3875         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3876         (write_exp_elt_longcst, write_exp_elt_floatcst)
3877         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3878         (write_exp_string_vector, write_exp_bitstring)
3879         (write_exp_msymbol, mark_struct_expression)
3880         (write_dollar_variable)
3881         (insert_type_address_space, increase_expout_size): Replace
3882         "parser_state" with "expr_builder".
3883         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3884         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3885         "parser_state" with "expr_builder".
3886
3887 2019-04-04  Tom Tromey  <tom@tromey.com>
3888
3889         * rust-exp.y: Replace "parse_language" with method call.
3890         * p-exp.y:
3891         (yylex): Replace "parse_language" with method call.
3892         * m2-exp.y:
3893         (yylex): Replace "parse_language" with method call.
3894         * go-exp.y (classify_name): Replace "parse_language" with method
3895         call.
3896         * f-exp.y (yylex): Replace "parse_language" with method call.
3897         * d-exp.y (lex_one_token): Replace "parse_language" with method
3898         call.
3899         * c-exp.y:
3900         (lex_one_token, classify_name, yylex): Replace "parse_language"
3901         with method call.
3902         * ada-exp.y (find_primitive_type, type_char)
3903         (type_system_address): Replace "parse_language" with method call.
3904
3905 2019-04-04  Tom Tromey  <tom@tromey.com>
3906
3907         * rust-exp.y: Replace "parse_gdbarch" with method call.
3908         * parse.c (write_dollar_variable, insert_type_address_space):
3909         Replace "parse_gdbarch" with method call.
3910         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3911         call.
3912         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3913         call.
3914         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3915         "parse_gdbarch" with method call.
3916         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3917         with method call.
3918         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3919         "parse_gdbarch" with method call.
3920         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3921         "parse_gdbarch" with method call.
3922         * c-exp.y (parse_type, parse_number, classify_name): Replace
3923         "parse_gdbarch" with method call.
3924         * ada-lex.l: Replace "parse_gdbarch" with method call.
3925         * ada-exp.y (parse_type, find_primitive_type, type_char)
3926         (type_system_address): Replace "parse_gdbarch" with method call.
3927
3928 2019-04-04  Tom Tromey  <tom@tromey.com>
3929
3930         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3931         * stap-probe.c (stap_parse_argument): Update.
3932         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3933         initial_size parameter.
3934         * rust-exp.y (rust_lex_tests): Update.
3935         * parse.c (parser_state): Update.
3936         (parse_exp_in_context): Update.
3937         * parser-defs.h (struct parser_state) <parser_state>: Remove
3938         "initial_size" parameter.
3939
3940 2019-04-04  Tom Tromey  <tom@tromey.com>
3941
3942         * parser-defs.h (increase_expout_size): Don't declare.
3943         * parse.c (increase_expout_size): Now static.
3944
3945 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3946
3947         * gnu-nat.c (gnu_nat_target::wait): Fix
3948         target_waitstatus_to_string call.
3949
3950 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3951
3952         * eval.c (evaluate_subexp_standard): Handle internal functions
3953         during Fortran function call handling.
3954
3955 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3956
3957         * NEWS: Mention new internal functions.
3958         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3959         (read_base_type): Use dwarf2_init_complex_target_type.
3960         * value.c (creal_internal_fn): New function.
3961         (cimag_internal_fn): New function.
3962         (_initialize_values): Register new internal functions.
3963
3964 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3965
3966         * infrun.c (stop_all_threads): If debug_infrun, always
3967         trace the wait status after wait_one, using
3968         target_waitstatus_to_string and target_pid_to_str.
3969         (handle_inferior_event): Replace various trace of
3970         wait status kind by a single trace.
3971         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3972         wait status kind image by target_waitstatus_to_string.
3973         * target/waitstatus.c (target_waitstatus_to_string): Fix
3974         obsolete comment.
3975
3976 2019-04-01  Tom Tromey  <tromey@adacore.com>
3977
3978         PR symtab/23331:
3979         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3980
3981 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3982             Pedro Alves  <palves@redhat.com>
3983
3984         * top.c (quit_force): Call 'finalize_values'.
3985         * value.c (finalize_values): New function.
3986         * value.h (finalize_values): Declare.
3987
3988 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3989
3990         * NEWS: Announce $_gdb_major and $_gdb_minor.
3991
3992         * top.c (init_gdb_version_vars): New function.
3993         (gdb_init): Call init_gdb_version_vars.
3994
3995 2019-03-29  Tom Tromey  <tromey@adacore.com>
3996
3997         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3998         help text.  Remove dead code.
3999
4000 2019-03-29  Keith Seitz  <keiths@redhat.com>
4001
4002         From Siddhesh Poyarekar:
4003         * f-lang.h (f77_get_upperbound): Return LONGEST.
4004         (f77_get_lowerbound): Likewise.
4005         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4006         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4007         print them.
4008         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4009         plongest to format print it.
4010         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4011         (f77_get_upperbound): Likewise.
4012         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4013         LOWER_BOUND to LONGEST.
4014         (f77_create_arrayprint_offset_tbl): Likewise.
4015
4016 2019-03-29  Keith Seitz  <keiths@redhat.com>
4017
4018         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4019         %s/pulongest for TYPE_LENGTH instead of %d in format
4020         strings.
4021         * ada-typerint.c (ada_print_type): Likewise.
4022         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4023         * compile/compile-c-support.c (generate_register_struct): Likewise.
4024         * gdbtypes.c (recursive_dump_type): Likewise.
4025         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4026         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4027         instead of %d in format strings.
4028         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4029         to std::min to ULONGEST.
4030         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4031         instead of %d in format strings.
4032         * tracepoint.c (info_scope_command): Likewise.
4033         * typeprint.c (print_offset_data::update)
4034         (print_offset_data::finish): Likewise.
4035         * xtensa-tdep.c (xtensa_store_return_value)
4036         (xtensa_push_dummy_call): Likewise.
4037
4038 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4039
4040         * windows-nat.c (display_selector): Fixed format specifications
4041         for 64-bit Cygwin.
4042
4043 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4044
4045         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4046
4047 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4048
4049         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4050         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4051         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4052         (nios2_linux_init_abi): Install it.
4053
4054 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4055
4056         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4057
4058 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4059
4060         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4061
4062 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4063             Tom Tromey  <tromey@adacore.com>
4064
4065         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4066
4067 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4068
4069         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4070         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4071         method to compute the bounds of range types. Also print "[evaluated]"
4072         if the bounds' values come from a dynamic evaluation.
4073
4074 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4077         whitespace when pretty printing is on.
4078
4079 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4080
4081         * ppc-linux-nat.c: Add include.
4082
4083 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4084
4085         * NEWS: Mention AArch64 Pointer Authentication.
4086
4087 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4088
4089         * arm-linux-nat.c: Add include.
4090
4091 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4092
4093         * source-cache.c (source_cache::get_source_lines): Re-read
4094         fullname after calling open_source_file.
4095
4096 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4097
4098         * NEWS: Mention TLS support for FreeBSD.
4099
4100 2019-03-25  Tom Tromey  <tromey@adacore.com>
4101
4102         * minsyms.c (BUNCH_SIZE): Update comment.
4103         (~minimal_symbol_reader): Remove old comment.
4104         (compact_minimal_symbols): Update comment.
4105         (minimal_symbol_reader::install): Remove old comment.  Update
4106         other comments.
4107
4108 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4109
4110         * s390-linux-nat.c: Add include.
4111
4112 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4113
4114         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4115         Call linux_get_hwcap.
4116         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4117         Likewise.
4118         (aarch64_linux_get_hwcap): Remove function.
4119         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4120         declaration.
4121         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4122         linux_get_hwcap.
4123         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4124         * linux-tdep.c (linux_get_hwcap): Add function.
4125         (linux_get_hwcap2): Likewise.
4126         * linux-tdep.h (linux_get_hwcap): Add declaration.
4127         (linux_get_hwcap2): Likewise.
4128         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4129         (ppc_linux_get_hwcap2): Likewise.
4130         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4131         linux_get_hwcap.
4132         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4133         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4134         (ppc_linux_nat_target::read_description): Likewise.
4135         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4136         * s390-linux-nat.c: Likewise.
4137         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4138
4139 2019-03-24  Tom Tromey  <tom@tromey.com>
4140
4141         * ada-lang.c (standard_lookup): Simplify initialization.
4142         (ada_lookup_symbol_nonlocal): Simplify return.
4143         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4144         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4145         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4146         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4147         initialization.
4148         * solib.c (solib_global_lookup): Simplify.
4149         * symtab.c (null_block_symbol): Remove.
4150         (symbol_cache_lookup): Simplify returns.
4151         (lookup_language_this): Simplify returns.
4152         (lookup_symbol_aux): Simplify return.
4153         (lookup_local_symbol): Simplify returns.
4154         (lookup_global_symbol_from_objfile): Simplify return.
4155         (lookup_symbol_in_objfile_symtabs)
4156         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4157         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4158         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4159         * cp-namespace.c (cp_lookup_bare_symbol)
4160         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4161         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4162         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4163         (cp_lookup_symbol_via_imports): Simplify initialization.
4164         (find_symbol_in_baseclass): Likewise.
4165         * symtab.h (null_block_symbol): Remove.
4166         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4167         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4168         (d_lookup_symbol_module): Likewise.
4169         (find_symbol_in_baseclass): Simplify initialization.
4170
4171 2019-03-24  Tom Tromey  <tom@tromey.com>
4172
4173         * expression.h: Don't include symtab.h.
4174         (struct block): Forward declare.
4175
4176 2019-03-24  Tom Tromey  <tom@tromey.com>
4177
4178         * c-exp.y (typebase): Remove casts.
4179         * gdbtypes.c (lookup_unsigned_typename, )
4180         (lookup_signed_typename): Remove cast.
4181         * eval.c (parse_to_comma_and_eval): Remove cast.
4182         * parse.c (write_dollar_variable): Remove cast.
4183         * block.h (struct block) <superblock>: Now const.
4184         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4185         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4186         (map_block): Make "block" const.
4187         * symfile.h (struct quick_symbol_functions)
4188         <map_matching_symbols>: Constify block argument to "callback".
4189         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4190         const.
4191         (find_pc_sect_compunit_symtab): Make "b" const.
4192         (find_symbol_at_address): Likewise.
4193         (search_symbols): Likewise.
4194         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4195         (dw2_debug_names_lookup_symbol): Likewise.
4196         (dw2_map_matching_symbols): Update.
4197         * p-valprint.c (pascal_val_print): Remove "block".
4198         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4199         (aux_add_nonlocal_symbols): Make "block" const.
4200         (resolve_subexp): Remove cast.
4201         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4202         const.
4203         (iterate_over_file_blocks): Likewise.
4204         * f-exp.y (%union) <bval>: Remove.
4205         * coffread.c (patch_opaque_types): Make "b" const.
4206         * spu-tdep.c (spu_catch_start): Make "block" const.
4207         * c-valprint.c (print_unpacked_pointer): Remove "block".
4208         * symmisc.c (dump_symtab_1): Make "b" const.
4209         (block_depth): Make "block" const.
4210         * d-exp.y (%union) <bval>: Remove.
4211         * cp-support.h (cp_lookup_rtti_type): Update.
4212         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4213         * psymtab.c (psym_lookup_symbol): Make "block" const.
4214         (maintenance_check_psymtabs): Make "b" const.
4215         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4216         (enumerate_locals, enumerate_args): Update.
4217         * python/py-symtab.c (stpy_global_block): Make "block" const.
4218         (stpy_static_block): Likewise.
4219         * inline-frame.c (block_starting_point_at): Make "new_block"
4220         const.
4221         * block.c (find_block_in_blockvector): Make return type const.
4222         (blockvector_for_pc_sect): Make "b" const.
4223         (find_block_in_blockvector): Make "b" const.
4224
4225 2019-03-23  Tom Tromey  <tom@tromey.com>
4226
4227         * varobj.c (varobj_create): Update.
4228         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4229         * printcmd.c (display_command, do_one_display): Don't reset
4230         innermost_block.
4231         * parser-defs.h (enum innermost_block_tracker_type): Move to
4232         expression.h.
4233         (innermost_block): Update comment.
4234         * parse.c (parse_exp_1): Add tracker_types parameter.
4235         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4236         tracker_types parameter.  Reset innermost_block.
4237         (parse_exp_in_context): Remove.
4238         (parse_expression_for_completion): Update.
4239         * objfiles.c (~objfile): Don't reset expression_context_block or
4240         innermost_block.
4241         * expression.h (enum innermost_block_tracker_type): Move from
4242         parser-defs.h.
4243         (parse_exp_1): Add tracker_types parameter.
4244         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4245         reset innermost_block.
4246
4247 2019-03-23  Tom Tromey  <tom@tromey.com>
4248
4249         * objfiles.h: Include bcache.h.
4250
4251 2019-03-23  Tom Tromey  <tom@tromey.com>
4252
4253         * linespec.c (get_current_search_block): Use
4254         scoped_restore_current_language.
4255         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4256
4257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4258             Jiong Wang  <jiong.wang@arm.com>
4259
4260         * aarch64-linux-tdep.c
4261         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4262         section.
4263         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4264
4265 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4266             Jiong Wang  <jiong.wang@arm.com>
4267
4268         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4269         instructions.
4270         (aarch64_analyze_prologue_test): Add PACIASP test.
4271         (aarch64_prologue_prev_register): Unmask PC value.
4272
4273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4274             Jiong Wang  <jiong.wang@arm.com>
4275
4276         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4277         (aarch64_dwarf2_prev_register): Unmask PC value.
4278         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4279         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4280         DW_CFA_AARCH64_negate_ra_state.
4281         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4282
4283 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4284             Jiong Wang  <jiong.wang@arm.com>
4285
4286         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4287         registers.
4288         (aarch64_pseudo_register_name): Likewise.
4289         (aarch64_pseudo_register_type): Likewise.
4290         (aarch64_pseudo_register_reggroup_p): Likewise.
4291         (aarch64_gdbarch_init): Add pauth registers.
4292         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4293         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4294         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4295         (struct gdbarch_tdep): Add regnum for ra_state.
4296
4297 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4298             Jiong Wang  <jiong.wang@arm.com>
4299
4300         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4301
4302 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4303             Jiong Wang  <jiong.wang@arm.com>
4304
4305         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4306         function.
4307         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4308         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4309         (aarch64_gdbarch_init): Add puth registers.
4310         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4311         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4312         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4313
4314 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4315             Jiong Wang  <jiong.wang@arm.com>
4316
4317         * aarch64-linux-nat.c
4318         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4319         * aarch64-linux-tdep.c
4320         (aarch64_linux_core_read_description): Likewise.
4321         (aarch64_linux_get_hwcap): New function.
4322         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4323         (aarch64_linux_get_hwcap): New declaration.
4324
4325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4326             Jiong Wang  <jiong.wang@arm.com>
4327
4328         * aarch64-linux-nat.c
4329         (aarch64_linux_nat_target::read_description): Add pauth param.
4330         * aarch64-linux-tdep.c
4331         (aarch64_linux_core_read_description): Likewise.
4332         * aarch64-tdep.c (struct target_desc): Add in pauth.
4333         (aarch64_read_description): Add pauth param.
4334         (aarch64_gdbarch_init): Likewise.
4335         * aarch64-tdep.h (aarch64_read_description): Likewise.
4336         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4337         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4338         * features/Makefile: Add new files.
4339         * features/aarch64-pauth.c: New file.
4340         * features/aarch64-pauth.xml: New file.
4341
4342 2019-03-20  Tom Tromey  <tromey@adacore.com>
4343
4344         * infrun.c (handle_inferior_event): Rename from
4345         handle_inferior_event_1.  Create a scoped_value_mark.
4346         (handle_inferior_event): Remove.
4347
4348 2019-03-19  Tom Tromey  <tromey@adacore.com>
4349
4350         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4351         * infrun.h (print_stop_event): Add "displays" parameter.
4352         * infrun.c (print_stop_event): Add "displays" parameter.
4353
4354 2019-03-19  Pedro Alves  <palves@redhat.com>
4355
4356         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4357         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4358         to -1.  Fix TABs vs spaces.
4359         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4360         * tui/tui-out.h (tui_ui_out) Add intro comments.
4361         <m_line, m_start_of_line>: In-class initialize, and add describing
4362         comment.
4363
4364 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4365
4366         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4367         variable names.
4368         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4369
4370 2019-03-18  Pedro Alves  <palves@redhat.com>
4371             Eli Zaretskii <eliz@gnu.org>
4372
4373         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4374         m_line and m_start_of_line.
4375
4376 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4377
4378         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4379         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4380         it returns a newline.  This fixes a regression in TU mode, whereby
4381         the next line is output on the same screen line as the user input.
4382
4383 2019-03-18  Tom Tromey  <tromey@adacore.com>
4384
4385         * minsyms.c (minimal_symbol_reader::install): Remove call to
4386         obstack_blank.
4387
4388 2019-03-18  Pedro Alves  <palves@redhat.com>
4389
4390         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4391         New globals.
4392         (apply_style): New, factored out from ...
4393         (apply_ansi_escape): ... this.  Handle reverse video mode.
4394         (tui_set_reverse_mode): New function.
4395         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4396         * tui/tui-winsource.c (tui_show_source_line): Use
4397         tui_set_reverse_mode instead of setting A_STANDOUT.
4398         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4399         New setter methods.
4400
4401 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4402
4403         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4404         Handle tabs.
4405
4406 2019-03-18  Tom Tromey  <tromey@adacore.com>
4407
4408         * ada-lang.c (empty_array): Add "high" parameter.
4409         (ada_evaluate_subexp): Update.
4410
4411 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4412
4413         * unittests/string_view-selftests.c: Define
4414         _initialize_string_view_selftests unconditionally.
4415
4416 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4417
4418         PR gdb/24350
4419         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4420
4421 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4422
4423         PR gdb/24351
4424         * windows-nat.c (display_selector): Fix format specifiers.
4425
4426 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4427
4428         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4429         tui_refill_source_window instead of tui_refresh_win, to update the
4430         current execution line.  This fixes redisplay of the current line
4431         when stepping through the code with "next" or "step".
4432
4433 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4434
4435         * source-cache.c (source_cache::get_source_lines): Call
4436         find_source_lines to initialize s->nlines.  This fixes vertical
4437         scrolling of TUI source window when the DOWN arrow is pressed.
4438
4439 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4440
4441         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4442         linux-thread-db.c (_initialize_thread_db): Likewise.
4443
4444 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4445
4446         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4447         wclrtoeol in tui_show_source_line".  This reverts changes made in
4448         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4449
4450 2019-03-15  Tom Tromey  <tom@tromey.com>
4451
4452         * symtab.h (struct minimal_symbol): Derive from
4453         general_symbol_info.
4454         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4455         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4456         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4457         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4458         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4459         (MSYMBOL_SEARCH_NAME): Update.
4460         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4461         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4462         * minsyms.c (minimal_symbol_reader::record_full): Update.
4463
4464 2019-03-15  Tom Tromey  <tom@tromey.com>
4465
4466         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4467
4468 2019-03-15  Tom Tromey  <tom@tromey.com>
4469
4470         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4471         unique_xmalloc_ptr.
4472         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4473         Update.
4474         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4475         (build_minimal_symbol_hash_tables)
4476         (minimal_symbol_reader::install): Update.
4477
4478 2019-03-15  Tom Tromey  <tom@tromey.com>
4479
4480         * symtab.c (create_demangled_names_hash): Update.
4481         (symbol_set_names): Update.
4482         * objfiles.h (struct objfile_per_bfd_storage)
4483         <demangled_names_hash>: Now an htab_up.
4484         * objfiles.c (objfile_per_bfd_storage): Simplify.
4485
4486 2019-03-15  Tom Tromey  <tom@tromey.com>
4487
4488         * objfiles.h (struct objfile_per_bfd_storage): Declare
4489         destructor.
4490         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4491         New.
4492         (get_objfile_bfd_data): Use new.  Don't initialize
4493         language_of_main.
4494         (free_objfile_per_bfd_storage): Remove.
4495         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4496
4497 2019-03-15  Tom Tromey  <tom@tromey.com>
4498
4499         * symfile.c (reread_symbols): Update.
4500         * objfiles.c (objfile::objfile): Update.
4501         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4502         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4503         comment.
4504         (minimal_symbol_reader::install): Update.
4505         (terminate_minimal_symbol_table): Remove.
4506         * jit.c (jit_object_close_impl): Update.
4507
4508 2019-03-15  Tom Tromey  <tom@tromey.com>
4509
4510         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4511         initializations.
4512
4513 2019-03-15  Tom Tromey  <tom@tromey.com>
4514
4515         * objfiles.h (struct objfile_per_bfd_storage)
4516         <demangled_hash_languages>: Now a bitset.
4517         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4518         (lookup_minimal_symbol): Update.
4519
4520 2019-03-15  Tom Tromey  <tom@tromey.com>
4521
4522         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4523         Don't return the symbol.
4524         * coffread.c (record_minimal_symbol): Use record_full.
4525
4526 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4527
4528         The MS-Windows port of ncurses fails to switch to a color pair if
4529         one or both of the colors are the implicit default colors.  This
4530         change records the default colors when TUI is initialized, and
4531         then specifies them explicitly when a color pair uses the default
4532         colors.  This allows color styling in TUI mode on MS-Windows.
4533
4534         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4535         ncurses_norm_attr.
4536         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4537         colors in ncurses_norm_attr.
4538         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4539         "none", replace it with the default color recorded in
4540         ncurses_norm_attr.
4541
4542 2019-03-14  Tom Tromey  <tromey@adacore.com>
4543
4544         * source-cache.h (class source_cache) <get_source_lines>: Return
4545         std::string.
4546         * source-cache.c (source_cache::extract_lines): Handle case where
4547         first_pos==npos.  Return std::string.
4548         (source_cache::get_source_lines): Update.
4549
4550 2019-03-14  Tom Tromey  <tromey@adacore.com>
4551
4552         * NEWS: Add item for "style sources" commands.
4553         * source-cache.c (source_cache::get_source_lines): Check
4554         source_styling.
4555         * cli/cli-style.c (source_styling): New global.
4556         (_initialize_cli_style): Add "style sources" commands.
4557         (show_style_sources): New function.
4558         * cli/cli-style.h (source_styling): Declare.
4559
4560 2019-03-14  Pedro Alves  <palves@redhat.com>
4561             Tom Tromey  <tromey@adacore.com>
4562
4563         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4564         * tui/tui-winsource.c (tui_refill_source_window): New function,
4565         from...
4566         (tui_horizontal_source_scroll): ... here.  Move some logic.
4567         * cli/cli-style.c (set_style_enabled): Notify new observable.
4568         * tui/tui-hooks.c (tui_redisplay_source): New function.
4569         (tui_attach_detach_observers): Attach or detach
4570         tui_redisplay_source.
4571         * observable.h (source_styling_changed): New observable.
4572         * observable.c: Define source_styling_changed observable.
4573
4574 2019-03-13  Tom Tromey  <tromey@adacore.com>
4575
4576         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4577         (i386_gnu_nat_target::store_registers): Update.
4578         * target-debug.h (target_debug_print_std_string): New macro.
4579         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4580         * windows-tdep.c (display_one_tib): Update.
4581         * tui/tui-stack.c (tui_make_status_line): Update.
4582         * top.c (print_inferior_quit_action): Update.
4583         * thread.c (thr_try_catch_cmd): Update.
4584         (add_thread_with_info): Update.
4585         (thread_target_id_str): Update.
4586         (thr_try_catch_cmd): Update.
4587         (thread_command): Update.
4588         (thread_find_command): Update.
4589         * record-btrace.c (record_btrace_target::info_record)
4590         (record_btrace_resume_thread, record_btrace_target::resume)
4591         (record_btrace_cancel_resume, record_btrace_step_thread)
4592         (record_btrace_target::wait, record_btrace_target::wait)
4593         (record_btrace_target::wait, record_btrace_target::stop): Update.
4594         * progspace.c (print_program_space): Update.
4595         * process-stratum-target.c
4596         (process_stratum_target::thread_address_space): Update.
4597         * linux-fork.c (linux_fork_mourn_inferior)
4598         (detach_checkpoint_command, info_checkpoints_command)
4599         (linux_fork_context): Update.
4600         (linux_fork_detach): Update.
4601         (class scoped_switch_fork_info): Update.
4602         (delete_checkpoint_command): Update.
4603         * infrun.c (follow_fork_inferior): Update.
4604         (follow_fork_inferior): Update.
4605         (proceed_after_vfork_done): Update.
4606         (handle_vfork_child_exec_or_exit): Update.
4607         (follow_exec): Update.
4608         (displaced_step_prepare_throw): Update.
4609         (displaced_step_restore): Update.
4610         (start_step_over): Update.
4611         (resume_1): Update.
4612         (clear_proceed_status_thread): Update.
4613         (proceed): Update.
4614         (print_target_wait_results): Update.
4615         (do_target_wait): Update.
4616         (context_switch): Update.
4617         (stop_all_threads): Update.
4618         (restart_threads): Update.
4619         (finish_step_over): Update.
4620         (handle_signal_stop): Update.
4621         (switch_back_to_stepped_thread): Update.
4622         (keep_going_pass_signal): Update.
4623         (print_exited_reason): Update.
4624         (normal_stop): Update.
4625         * inferior.c (inferior_pid_to_str): Change return type.
4626         (print_selected_inferior): Update.
4627         (add_inferior): Update.
4628         (detach_inferior): Update.
4629         * dummy-frame.c (fprint_dummy_frames): Update.
4630         * dcache.c (dcache_info_1): Update.
4631         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4632         (btrace_fetch, btrace_clear): Update.
4633         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4634         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4635         type.
4636         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4637         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4638         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4639         * gdbarch.c, gdbarch.h: Rebuild.
4640         * gdbarch.sh (core_pid_to_str): Change return type.
4641         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4642         return type.
4643         (windows_nat_target::pid_to_str): Change return type.
4644         (windows_delete_thread): Update.
4645         (windows_nat_target::attach): Update.
4646         (windows_nat_target::files_info): Update.
4647         * target-delegates.c: Rebuild.
4648         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4649         return type.
4650         (sol_thread_target::pid_to_str): Change return type.
4651         * remote.c (class remote_target) <pid_to_str>: Change return
4652         type.
4653         (remote_target::pid_to_str): Change return type.
4654         (extended_remote_target::attach, remote_target::remote_stop_ns)
4655         (remote_target::remote_notif_remove_queued_reply)
4656         (remote_target::push_stop_reply, remote_target::disable_btrace):
4657         Update.
4658         (extended_remote_target::attach): Update.
4659         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4660         type.
4661         (gdbsim_target::pid_to_str): Change return type.
4662         * ravenscar-thread.c (struct ravenscar_thread_target)
4663         <pid_to_str>: Change return type.
4664         (ravenscar_thread_target::pid_to_str): Change return type.
4665         * procfs.c (class procfs_target) <pid_to_str>: Change return
4666         type.
4667         (procfs_target::pid_to_str): Change return type.
4668         (procfs_target::attach): Update.
4669         (procfs_target::detach): Update.
4670         (procfs_target::fetch_registers): Update.
4671         (procfs_target::store_registers): Update.
4672         (procfs_target::wait): Update.
4673         (procfs_target::files_info): Update.
4674         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4675         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4676         return type.
4677         (nto_procfs_target::pid_to_str): Change return type.
4678         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4679         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4680         return type.
4681         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4682         (exit_lwp): Update.
4683         (attach_proc_task_lwp_callback, get_detach_signal)
4684         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4685         (linux_nat_target::resume, wait_lwp, stop_callback)
4686         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4687         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4688         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4689         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4690         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4691         type.
4692         (inf_ptrace_target::attach): Update.
4693         (inf_ptrace_target::files_info): Update.
4694         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4695         type.
4696         (go32_nat_target::pid_to_str): Change return type.
4697         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4698         (gnu_nat_target::wait): Update.
4699         (gnu_nat_target::wait): Update.
4700         (gnu_nat_target::resume): Update.
4701         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4702         (fbsd_nat_target::wait): Update.
4703         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4704         type.
4705         (darwin_nat_target::attach): Update.
4706         * corelow.c (class core_target) <pid_to_str>: Change return type.
4707         (core_target::pid_to_str): Change return type.
4708         * target.c (normal_pid_to_str): Change return type.
4709         (default_pid_to_str): Likewise.
4710         (target_pid_to_str): Change return type.
4711         (target_translate_tls_address): Update.
4712         (target_announce_detach): Update.
4713         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4714         return type.
4715         (bsd_uthread_target::pid_to_str): Change return type.
4716         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4717         type.
4718         (bsd_kvm_target::pid_to_str): Change return type.
4719         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4720         return type.
4721         (aix_thread_target::pid_to_str): Change return type.
4722         * target.h (struct target_ops) <pid_to_str>: Change return type.
4723         (target_pid_to_str, normal_pid_to_str): Likewise.
4724         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4725         type.
4726         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4727         type.
4728         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4729         return type.
4730         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4731         type.
4732         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4733         type.
4734         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4735         return type.
4736
4737 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4738
4739         * NEWS: Mention that the new default MI version is 3.  Mention
4740         changes to the output of commands and events that deal with
4741         multi-location breakpoints.
4742         * breakpoint.c: Include "mi/mi-out.h".
4743         (print_one_breakpoint): Change output syntax if using MI version
4744         >= 3.
4745         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4746         New.
4747         (mi_multi_location_breakpoint_output_fixed): New.
4748         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4749         (mi_cmd_fix_multi_location_breakpoint_output): New.
4750         (mi_multi_location_breakpoint_output_fixed): New.
4751         * mi/mi-cmds.c (mi_cmds): Register command
4752         -fix-multi-location-breakpoint-output.
4753         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4754         interpreter "mi".
4755
4756 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4757
4758         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4759         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4760         instantiate mi_ui_out based on interpreter name.
4761         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4762         * mi/mi-main.c (mi_load_progress): Likewise.
4763
4764 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4765
4766         * NEWS: Combine separate "New targets" sections for 8.3.
4767
4768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4769
4770         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4771         (ppcfbsd_init_abi): Install gdbarch
4772         "fetch_tls_load_module_address" and "get_thread_local_address"
4773         methods.
4774
4775 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4776
4777         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4778         (riscv_fbsd_init_abi): Install gdbarch
4779         "fetch_tls_load_module_address" and "get_thread_local_address"
4780         methods.
4781
4782 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4783
4784         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4785         (i386fbsd_init_abi): Install gdbarch
4786         "fetch_tls_load_module_address" and "get_thread_local_address"
4787         methods.
4788
4789 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4790
4791         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4792         (amd64fbsd_init_abi): Install gdbarch
4793         "fetch_tls_load_module_address" and "get_thread_local_address"
4794         methods.
4795
4796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4797
4798         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4799         (struct fbsd_pspace_data): New type.
4800         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4801         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4802         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4803         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4804         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4805
4806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4807
4808         * gdbtypes.c (lookup_struct_elt): New function.
4809         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4810         * gdbtypes.h (struct struct_elt): New type.
4811         (lookup_struct_elt): New prototype.
4812
4813 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4814
4815         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4816         remove disabled code block.
4817
4818 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4819
4820         * gdbarch.sh (get_thread_local_address): New method.
4821         * gdbarch.h, gdbarch.c: Regenerate.
4822         * target.c (target_translate_tls_address): Use
4823         gdbarch_get_thread_local_address if present instead of
4824         target::get_thread_local_address.
4825
4826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4827
4828         * target.h (target::get_thread_local_address): Update comment.
4829
4830 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4831
4832         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4833         objfile->separate_debug_objfile_backlink if not NULL.
4834
4835 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4836
4837         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4838         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4839         (amd64bsd_store_inferior_registers): Likewise.
4840         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4841         Enable segment base registers.
4842         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4843         PT_GETFSBASE and PT_GETGSBASE.
4844         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4845         PT_SETGSBASE.
4846         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4847         segment base registers.
4848         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4849
4850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4851
4852         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4853         Update calls to i386_target_description to add 'segments'
4854         parameter.
4855         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4856         add segment base registers.
4857         * arch/i386.c (i386_create_target_description): Add 'segments'
4858         parameter to enable segment base registers.
4859         * arch/i386.h (i386_create_target_description): Likewise.
4860         * features/i386/32bit-segments.xml: New file.
4861         * features/i386/32bit-segments.c: Generate.
4862         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4863         call to i386_target_description to add 'segments' parameter.
4864         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4865         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4866         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4867         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4868         if feature is present.
4869         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4870         Add 'segments' parameter to call to i386_target_description.
4871         (i386_target_description): Add 'segments' parameter to enable
4872         segment base registers.
4873         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4874         to call to i386_target_description.
4875         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4876         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4877         Define I386_NUM_REGS.
4878         (i386_target_description): Add 'segments' parameter to enable
4879         segment base registers.
4880
4881 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4882
4883         PR/24325
4884         * source-cache.c: #undef open and close, to avoid unresolved
4885         externals during linking.
4886
4887 2019-03-12  Tom Tromey  <tromey@adacore.com>
4888
4889         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4890         const.  Add initializers.
4891         (_initialize_remote): Don't initialize ptid globals.
4892
4893 2019-03-12  Pedro Alves  <palves@redhat.com>
4894
4895         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4896
4897 2019-03-12  Pedro Alves  <palves@redhat.com>
4898
4899         * cp-name-parser.y (main): Remove unused 'len' variable.
4900
4901 2019-03-12  Tom Tromey  <tromey@adacore.com>
4902
4903         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4904         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4905
4906 2019-03-12  Tom Tromey  <tromey@adacore.com>
4907
4908         * linux-nat.c (iterate_over_lwps): Update.
4909         (stop_callback): Remove parameter.
4910         (stop_wait_callback, detach_callback, resume_set_callback)
4911         (select_singlestep_lwp_callback, set_ignore_sigint)
4912         (status_callback, resumed_callback, resume_clear_callback)
4913         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4914         data parameter.
4915         (linux_nat_target::detach, linux_nat_target::resume)
4916         (linux_stop_and_wait_all_lwps, select_event_lwp)
4917         (linux_nat_filter_event, linux_nat_wait_1)
4918         (linux_nat_target::kill, linux_nat_target::stop)
4919         (linux_nat_target::stop): Update.
4920         (linux_nat_resume_callback): Change type.
4921         (resume_stopped_resumed_lwps, count_events_callback)
4922         (select_event_lwp_callback): Likewise.
4923         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4924         * arm-linux-nat.c (struct update_registers_data): Remove.
4925         (update_registers_callback): Change type.
4926         (arm_linux_insert_hw_breakpoint1): Update.
4927         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4928         parameter.
4929         (x86_linux_dr_set_addr): Update.
4930         (x86_linux_dr_set_control): Update.
4931         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4932         (iterate_over_lwps): Use gdb::function_view.
4933         * nat/aarch64-linux-hw-point.c (struct
4934         aarch64_dr_update_callback_param): Remove.
4935         (debug_reg_change_callback): Change type.
4936         (aarch64_notify_debug_reg_change): Update.
4937         * s390-linux-nat.c (s390_refresh_per_info): Update.
4938
4939 2019-03-11  Tom Tromey  <tromey@adacore.com>
4940
4941         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4942         redundant assignment to "this_cu".
4943
4944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4945
4946         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4947
4948 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4949
4950         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4951         from...
4952         (rank_one_type): ... this.
4953
4954 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4955
4956         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4957         from...
4958         (rank_one_type): ... this.
4959
4960 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4961
4962         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4963         from...
4964         (rank_one_type): ... this.
4965
4966 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4967
4968         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4969         from...
4970         (rank_one_type): ... this.
4971
4972 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4973
4974         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4975         from...
4976         (rank_one_type): ... this.
4977
4978 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4979
4980         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4981         from...
4982         (rank_one_type): ... this.
4983
4984 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4985
4986         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4987         from...
4988         (rank_one_type): ... this.
4989
4990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4991
4992         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4993         from...
4994         (rank_one_type): ... this.
4995
4996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4997
4998         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4999         from...
5000         (rank_one_type): ... this.
5001
5002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5003
5004         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5005         from...
5006         (rank_one_type): ... this.
5007
5008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5009
5010         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5011         from...
5012         (rank_one_type): ... this.
5013
5014 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5015
5016         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5017         from...
5018         (rank_one_type): ... this.
5019
5020 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5021
5022         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5023         inferior-events' shows the example events.
5024
5025 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5026
5027         Support styling on native MS-Windows console
5028
5029         PR/24315
5030         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5031         on MS-Windows if $TERM is not defined.
5032
5033         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5034
5035         * posix-hdep.c (gdb_console_fputs):
5036         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5037         functions.
5038         * ui-file.h (gdb_console_fputs): Add prototype.
5039
5040         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5041         back to fputs only if the former returns zero.
5042
5043 2019-03-07  Tom Tromey  <tom@tromey.com>
5044
5045         * symmisc.c (print_symbol_bcache_statistics): Update.
5046         (print_objfile_statistics): Update.
5047         * symfile.c (allocate_symtab): Update.
5048         * stabsread.c: Don't include bcache.h.
5049         * psymtab.h (struct psymbol_bcache): Don't declare.
5050         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5051         (psymbol_bcache_init, psymbol_bcache_free)
5052         (psymbol_bcache_get_bcache): Don't declare.
5053         * psymtab.c (struct psymbol_bcache): Remove.
5054         (psymtab_storage::psymtab_storage): Update.
5055         (psymtab_storage::~psymtab_storage): Update.
5056         (psymbol_bcache_init, psymbol_bcache_free)
5057         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5058         (add_psymbol_to_bcache): Update.
5059         (allocate_psymtab): Update.
5060         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5061         macro_cache>: No longer pointers.
5062         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5063         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5064         * macrotab.c (macro_bcache): Update.
5065         * macroexp.c: Don't include bcache.h.
5066         * gdbtypes.c (check_types_worklist): Update.
5067         (types_deeply_equal): Remove TRY/CATCH.  Update.
5068         * elfread.c (elf_symtab_read): Update.
5069         * dwarf2read.c: Don't include bcache.h.
5070         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5071         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5072         (print_bcache_statistics, bcache_memory_used): Don't declare.
5073         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5074         methods.  Rename all data members.
5075         * bcache.c (struct bcache): Move to bcache.h.
5076         (bcache::expand_hash_table): Rename from expand_hash_table.
5077         (bcache): Remove.
5078         (bcache::insert): Rename from bcache_full.
5079         (bcache::compare): Rename from bcache_compare.
5080         (bcache_xmalloc): Remove.
5081         (bcache::~bcache): Rename from bcache_xfree.
5082         (bcache::print_statistics): Rename from print_bcache_statistics.
5083         (bcache::memory_used): Rename from bcache_memory_used.
5084
5085 2019-03-07  Pedro Alves  <palves@redhat.com>
5086
5087         * infrun.c (normal_stop): Also check for
5088         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5089
5090 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5091
5092         * f-lang.c (value_from_host_double): Moved to...
5093         * value.c (value_from_host_double): ...here.
5094         * value.h (value_from_host_double): Declare.
5095         * guile/scm-math.c (vlscm_convert_typed_number): Use
5096         value_from_host_double.
5097         (vlscm_convert_number): Likewise.
5098         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5099         * python/py-value.c (convert_value_from_python): Likewise.
5100
5101 2019-03-06  Tom Tromey  <tom@tromey.com>
5102
5103         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5104
5105 2019-03-06  Tom Tromey  <tom@tromey.com>
5106
5107         * utils.h (free_current_contents): Don't declare.
5108         * utils.c (free_current_contents): Remove.
5109
5110 2019-03-06  Tom Tromey  <tom@tromey.com>
5111
5112         * top.c (quit_force): Update.
5113         * main.c (captured_command_loop): Update.
5114         * common/new-op.c (operator new): Update.
5115         * common/common-exceptions.c (struct catcher)
5116         <save_cleanup_chain>: Remove member.
5117         (exceptions_state_mc_init): Update.
5118         (exception_try_scope_entry): Return nullptr.
5119         (exception_try_scope_exit, exception_rethrow)
5120         (throw_exception_sjlj, throw_exception_cxx): Update.
5121         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5122         (all_cleanups, do_cleanups, discard_cleanups)
5123         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5124         (restore_cleanups, restore_final_cleanups): Don't declare.
5125         (do_final_cleanups): Remove parameter.
5126         * common/cleanups.c (cleanup_chain, make_cleanup)
5127         (make_cleanup_dtor, all_cleanups, do_cleanups)
5128         (discard_my_cleanups, discard_cleanups)
5129         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5130         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5131         (null_cleanup): Remove.
5132         (do_final_cleanups): Remove parameter.
5133
5134 2019-03-06  Tom Tromey  <tom@tromey.com>
5135
5136         * remote.c (remote_target::remote_parse_stop_reply): Use
5137         unique_xmalloc_ptr.
5138
5139 2019-03-06  Tom Tromey  <tom@tromey.com>
5140
5141         * stabsread.c (struct stabs_field_info): Rename from field_info.
5142         <list, fnlist>: Add initializers.
5143         <obstack>: New member.
5144         (read_member_functions, read_struct_fields, read_baseclasses):
5145         Allocate on obstack.  Don't use cleanups.
5146         (read_one_struct_field, read_member_functions, read_struct_fields)
5147         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5148         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5149         (read_struct_type): Update.
5150
5151 2019-03-06  Tom Tromey  <tom@tromey.com>
5152
5153         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5154         * common/filestuff.h (make_cleanup_close): Don't declare.
5155         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5156         Remove.
5157
5158 2019-03-06  Tom Tromey  <tom@tromey.com>
5159
5160         * solib-aix.c: Use make_scope_exit.
5161
5162 2019-03-06  Tom Tromey  <tom@tromey.com>
5163
5164         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5165         Use make_scope_exit.
5166
5167 2019-03-06  Tom Tromey  <tom@tromey.com>
5168
5169         * solib-svr4.c (disable_probes_interface): Remove parameter.
5170         (svr4_handle_solib_event): Use make_scope_exit.
5171
5172 2019-03-06  Tom Tromey  <tom@tromey.com>
5173
5174         * remote.c (struct stop_reply_deleter): Remove.
5175         (stop_reply_up): Update.
5176         (struct stop_reply): Derive from notif_event.  Don't typedef.
5177         <regcache>: Now a std::vector.
5178         (stop_reply_xfree): Remove.
5179         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5180         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5181         (remote_target::discard_pending_stop_replies): Use delete.
5182         (remote_target::remote_parse_stop_reply): Update.
5183         (remote_target::process_stop_reply): Update.
5184         * remote-notif.h (struct notif_event): Add virtual destructor.
5185         Remove "dtr" member.
5186         (struct notif_client) <alloc_event>: Return a unique_ptr.
5187         (notif_event_xfree): Don't declare.
5188         (notif_event_up): New typedef.
5189         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5190         (notif_event_xfree, do_notif_event_xfree): Remove.
5191         (remote_notif_state_xfree): Update.
5192
5193 2019-03-06  Tom Tromey  <tom@tromey.com>
5194
5195         * infrun.c (displaced_step_clear_cleanup): Now a
5196         forward_scope_exit type.
5197         (displaced_step_prepare_throw): Update.
5198         (displaced_step_fixup): Update.
5199
5200 2019-03-06  Tom Tromey  <tom@tromey.com>
5201
5202         * inferior.h (class inferior): Update comment.
5203         * gdbthread.h (class thread_info): Update comment.
5204
5205 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5206             Tom Tromey  <tom@tromey.com>
5207
5208         * stabsread.h (struct stab_section_list): Remove.
5209         (coffstab_build_psymtabs): Update.
5210         * dbxread.c (symbuf_sections): Now a std::vector.
5211         (sect_idx): New global.
5212         (fill_symbuf): Update.
5213         (coffstab_build_psymtabs): Change type of stabsects parameter.
5214         Update.
5215         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5216         std::vector.
5217         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5218         (coff_locate_sections): Update.
5219         (coff_symfile_read): Remove cleanups.  Update.
5220         (init_stringtab): Add storage parameter.
5221         (free_stringtab, free_stringtab_cleanup): Remove.
5222         (init_lineno): Add storage parameter.
5223         (free_linetab, free_linetab_cleanup): Remove.
5224
5225 2019-03-06  Pedro Alves  <palves@redhat.com>
5226
5227         * linux-fork.c (fork_info::clobber_regs): Delete.
5228         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5229         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5230         comment.  Adjust.
5231         (scoped_switch_fork_info::scoped_switch_fork_info)
5232         (checkpoint_command, linux_fork_context): Adjust
5233         fork_save_infrun_state calls.
5234
5235 2019-03-06  Pedro Alves  <palves@redhat.com>
5236
5237         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5238         (inf_has_multiple_threads): Return 'bool' and rewrite using
5239         inferior_info::threads().
5240
5241 2019-03-06  Pedro Alves  <palves@redhat.com>
5242
5243         * linux-fork.c: Include <list>.
5244         (fork_list): Now a std::list instance.
5245         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5246         (forks_exist_p, find_last_fork): Adjust.
5247         (new_fork): Delete.
5248         (one_fork_p): New.
5249         (add_fork): Adjust.
5250         (free_fork): Delete, folded into fork_info::~fork_info().
5251         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5252         Adjust.
5253         (init_fork_list): Delete.
5254         (linux_fork_killall, linux_fork_mourn_inferior)
5255         (linux_fork_detach, info_checkpoints_command): Adjust.
5256         (_initialize_linux_fork): No longer call init_fork_list.
5257
5258 2019-03-06  Pedro Alves  <palves@redhat.com>
5259
5260         * linux-fork.c (new_fork): New, split out of ...
5261         (add_fork): ... this.  Return void.  Move "first fork" special
5262         case from here, to ...
5263         (checkpoint_command): ... here.
5264         * linux-linux.h (add_fork): Return void.
5265
5266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5267
5268         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5269
5270 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5271             Chris January  <chris.january@arm.com>
5272             David Lecomber  <david.lecomber@arm.com>
5273
5274         * f-exp.y: New token, UNOP_INTRINSIC.
5275         (exp): New pattern using UNOP_INTRINSIC token.
5276         (f77_keywords): Add 'abs' keyword.
5277         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5278         (value_from_host_double): New function.
5279         (evaluate_subexp_f): Support UNOP_ABS.
5280
5281 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5282
5283         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5284         types.
5285
5286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5287
5288         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5289         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5290         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5291
5292 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5293
5294         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5295
5296 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5297             Chris January  <chris.january@arm.com>
5298
5299         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5300         * f-exp.y: Define 'KIND' token.
5301         (exp): New pattern for KIND expressions.
5302         (ptype): Handle types with a kind extension.
5303         (direct_abs_decl): Extend to spot kind extensions.
5304         (f77_keywords): Add 'kind' to the list.
5305         (push_kind_type): New function.
5306         (convert_to_kind_type): New function.
5307         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5308         * parse.c (operator_length_standard): Likewise.
5309         * parser-defs.h (enum type_pieces): Add tp_kind.
5310         * std-operator.def: Add UNOP_KIND.
5311
5312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5313
5314         * f-exp.y (f_parse): Set yydebug.
5315
5316 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5317
5318         * f-lang.c (evaluate_subexp_f): New function.
5319         (exp_descriptor_f): New global.
5320         (f_language_defn): Use exp_descriptor_f instead of
5321         exp_descriptor_standard.
5322
5323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5324
5325         * f-exp.y (struct token): Add comments.
5326         (dot_ops): Remove uppercase versions and the end marker.
5327         (f77_keywords): Likewise.
5328         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5329         entries in the dot_ops array are case insensitive, and use
5330         strncasecmp to compare strings.  Also some whitespace cleanup in
5331         this area.  Similar for the f77_keywords array, except entries in
5332         this list might be case sensitive.
5333
5334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5335
5336         * f-exp.y (struct f77_boolean_val): Add comments.
5337         (boolean_values): Remove uppercase versions, and end marker.
5338         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5339         and use strncasecmp to achieve case insensitivity.  Additionally,
5340         perform whitespace cleanup around this code.
5341
5342 2019-03-06  Tom Tromey  <tromey@adacore.com>
5343
5344         * remote-sim.c (gdbsim_target_open): Use result of
5345         gdb_argv::release.
5346
5347 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5348         Dirk Schubert  <dirk.schubert@arm.com>
5349         Chris January  <chris.january@arm.com>
5350
5351         * eval.c (evaluate_subexp_standard): Call Fortran argument
5352         wrapping logic.
5353         * f-lang.c (struct value): A value which can be passed into a
5354         Fortran function call.
5355         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5356         where appropriate.
5357         (struct type): Value ready for a Fortran function call.
5358         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5359         is needed.
5360         * f-lang.h (fortran_argument_convert): Declaration.
5361         (fortran_preserve_arg_pointer): Declaration.
5362         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5363
5364 2019-03-05  Tom Tromey  <tromey@adacore.com>
5365
5366         * python/py-prettyprint.c (print_string_repr): Remove #if.
5367         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5368
5369 2019-03-05  Tom Tromey  <tromey@adacore.com>
5370
5371         * target.c (the_dummy_target): Move later.  Change type to
5372         "dummy_target".
5373         (initialize_targets): Don't initialize the_dummy_target.
5374
5375 2019-03-05  Tom Tromey  <tromey@adacore.com>
5376
5377         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5378         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5379
5380 2019-03-05  Tom Tromey  <tromey@adacore.com>
5381
5382         * windows-nat.c (windows_nat_target::attach)
5383         (windows_nat_target::detach): Don't call gdb_flush.
5384         * valprint.c (generic_val_print, val_print, val_print_string):
5385         Don't call gdb_flush.
5386         * utils.c (defaulted_query): Don't call gdb_flush.
5387         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5388         * target.c (target_announce_detach): Don't call gdb_flush.
5389         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5390         * remote.c (extended_remote_target::attach): Don't call
5391         gdb_flush.
5392         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5393         * printcmd.c (do_examine): Don't call gdb_flush.
5394         (info_display_command): Don't call gdb_flush.
5395         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5396         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5397         * memattr.c (info_mem_command): Don't call gdb_flush.
5398         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5399         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5400         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5401         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5402         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5403         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5404         (gnu_nat_target::detach): Don't call gdb_flush.
5405         * f-valprint.c (f_val_print): Don't call gdb_flush.
5406         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5407         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5408         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5409         gdb_flush.
5410         * c-valprint.c (c_val_print): Don't call gdb_flush.
5411         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5412
5413 2019-03-05  Tom Tromey  <tromey@adacore.com>
5414
5415         * varobj.c (update_dynamic_varobj_children): Update.
5416         (install_default_visualizer): Use reset, not release.
5417         * value.c (set_internalvar): Update.
5418         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5419         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5420         ATTRIBUTE_UNUSED_RESULT.
5421
5422 2019-03-05  Tom Tromey  <tromey@adacore.com>
5423
5424         * remote.c (class scoped_remote_fd) <release>: Add
5425         ATTRIBUTE_UNUSED_RESULT.
5426
5427 2019-03-05  Tom Tromey  <tromey@adacore.com>
5428
5429         * macroexp.c (struct macro_buffer) <release>: Add
5430         ATTRIBUTE_UNUSED_RESULT.
5431
5432 2019-03-05  Tom Tromey  <tromey@adacore.com>
5433
5434         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5435         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5436         ATTRIBUTE_UNUSED_RESULT.
5437
5438 2019-03-05  Tom Tromey  <tromey@adacore.com>
5439
5440         * common/scoped_fd.h (class scoped_fd) <release>: Add
5441         ATTRIBUTE_UNUSED_RESULT.
5442
5443 2019-03-05  Tom Tromey  <tromey@adacore.com>
5444
5445         * parser-defs.h (struct parser_state) <release>: Add
5446         ATTRIBUTE_UNUSED_RESULT.
5447
5448 2019-03-05  Tom Tromey  <tromey@adacore.com>
5449
5450         * utils.h (class gdb_argv) <release>: Add
5451         ATTRIBUTE_UNUSED_RESULT.
5452         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5453
5454 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5455
5456         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5457         for-loop range, to avoid compiler warnings.
5458
5459         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5460         avoid compiler warnings about unused variables.
5461
5462         * NEWS: Mention end of support for native debugging on MS-Windows
5463         before XP.
5464
5465         PR gdb/24292
5466         * common/netstuff.c:
5467         * gdbserver/gdbreplay.c
5468         * gdbserver/remote-utils.c:
5469         * ser-tcp.c:
5470         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5471         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5472         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5473         'getaddrinfo' and 'freeaddrinfo' were not available before
5474         Windows XP, and mingw.org's MinGW headers by default define
5475         _WIN32_WINNT to 0x500.
5476
5477 2019-03-01  Gary Benson <gbenson@redhat.com>
5478
5479         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5480
5481 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5482             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5483
5484         PR gdb/8527
5485         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5486         set_sigint_trap, clear_sigint_trap.
5487
5488 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5489
5490         * target.c (target_detach): Clear the regcache and the
5491         frame cache.
5492
5493 2019-02-27  Pedro Alves  <palves@redhat.com>
5494
5495         * utils.c (set_screen_size): When we cap the height/width sizes,
5496         tweak the corresponding command variable to show "unlimited":
5497
5498 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5499             Pedro Alves  <palves@redhat.com>
5500
5501         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5502         before calling rl_set_screen_size.
5503
5504 2019-02-27  Tom Tromey  <tromey@adacore.com>
5505
5506         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5507         define.
5508         * python/py-value.c: Remove Python 2.4 workaround.
5509         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5510         workaround.
5511         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5512         Python 2.4 workaround.
5513         * python/python-internal.h: Remove Python 2.4 comment.
5514         (Py_ssize_t): Don't define.
5515         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5516         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5517         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5518         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5519         * python/python.c (do_start_initialization): Remove Python 2.4
5520         workaround.
5521         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5522         (print_children): Remove Python 2.4 workaround.
5523         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5524         workaround.
5525         (CHARBUFFERPROC_NAME): Remove.
5526         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5527         Python 2.4 workaround.
5528
5529 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5530
5531         * NEWS: Note minimum Python version.
5532
5533 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5534
5535         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5536         code from these functions.  Remove corresponding ifdefs.  Use
5537         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5538         Remove gotos and target of gotos.
5539         (infpy_search_memory): Likewise.
5540
5541 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5542
5543         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5544         (hppa_gdbarch_init): Don't register deleted functions with
5545         gdbarch.
5546
5547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5548
5549         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5550         (h8300_unwind_sp): Delete.
5551         (h8300_dummy_id): Delete.
5552         (h8300_gdbarch_init): Don't register deleted functions with
5553         gdbarch.
5554
5555 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5558         (ft32_unwind_pc): Delete.
5559         (ft32_unwind_sp): Delete.
5560         (ft32_gdbarch_init): Don't register deleted functions with
5561         gdbarch.
5562
5563 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5564
5565         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5566         (frv_unwind_pc): Delete.
5567         (frv_unwind_sp): Delete.
5568         (frv_gdbarch_init): Don't register deleted functions with
5569         gdbarch.
5570
5571 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5572
5573         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5574         (riscv_unwind_pc): Delete.
5575         (riscv_unwind_sp): Delete.
5576         (riscv_gdbarch_init): Don't register deleted functions with
5577         gdbarch.
5578
5579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5580
5581         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5582         (csky_unwind_pc): Delete.
5583         (csky_unwind_sp): Delete.
5584         (csky_gdbarch_init): Don't register deleted functions with
5585         gdbarch.
5586
5587 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5588
5589         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5590         (cris_unwind_pc): Delete.
5591         (cris_unwind_sp): Delete.
5592         (cris_gdbarch_init): Don't register deleted functions with
5593         gdbarch.
5594
5595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5596
5597         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5598         (bfin_unwind_pc): Delete.
5599         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5600
5601 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5602
5603         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5604         (arm_unwind_pc): Delete.
5605         (arm_unwind_sp): Delete.
5606         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5607
5608 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5609
5610         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5611         (arc_unwind_pc): Delete.
5612         (arc_unwind_sp): Delete.
5613         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5614
5615 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5616
5617         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5618         (alpha_unwind_pc): Delete.
5619         (alpha_gdbarch_init): Don't register deleted functions with
5620         gdbarch.
5621
5622 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5623
5624         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5625         (aarch64_unwind_pc): Delete.
5626         (aarch64_unwind_sp): Delete.
5627         (aarch64_gdbarch_init): Don't register deleted functions with
5628         gdbarch.
5629
5630 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5631
5632         * gdbtypes.c (type_align): Don't consider static members when
5633         computing structure alignment.
5634
5635 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5636
5637         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5638         return 0 for other types.
5639         * arch-utils.c (default_type_align): Always return 0.
5640         * gdbarch.h: Regenerate.
5641         * gdbarch.sh (type_align): Extend comment.
5642         * gdbtypes.c (type_align): Add additional comments, always call
5643         gdbarch_type_align before applying the default rules.
5644         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5645         generic code will then apply a suitable default.
5646         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5647         types, return 0 for other types.
5648
5649 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5650
5651         * NEWS: Create a new section for the next release branch.
5652         Rename the section of the current branch, now that it has
5653         been cut.
5654
5655 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5656
5657         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5658         * version.in: Bump version to 8.3.50.DATE-git.
5659
5660 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5661
5662         * aix-thread.c (ptid_cmp): Remove unused variable.
5663         (get_signaled_thread): Likewise.
5664         (store_regs_user_thread): Likewise.
5665         (store_regs_kernel_thread): Likewise.
5666         (fetch_regs_kernel_thread): Remove shadowed variable.
5667
5668 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5669
5670         * features/riscv/32bit-cpu.xml: Add register numbers.
5671         * features/riscv/32bit-fpu.c: Regenerate.
5672         * features/riscv/32bit-fpu.xml: Add register numbers.
5673         * features/riscv/64bit-cpu.xml: Add register numbers.
5674         * features/riscv/64bit-fpu.c: Regenerate.
5675         * features/riscv/64bit-fpu.xml: Add register numbers.
5676
5677 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5678
5679         * NEWS: Mention two argument form of gdb.Value constructor.
5680         * python/py-value.c (convert_buffer_and_type_to_value): New
5681         function.
5682         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5683         Add support for handling an optional second argument.  Call
5684         convert_buffer_and_type_to_value as appropriate.
5685         * python/python-internal.h (Py_buffer_deleter): New struct.
5686         (Py_buffer_up): New typedef.
5687
5688 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5689
5690         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5691         instead of releasing ownership.
5692
5693 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5694
5695         * dwarf2read.c (open_and_init_dwp_file): Call
5696         elf_numsections instead of bfd_count_sections to initialize
5697         dwp_file->num_sections.
5698
5699 2019-02-25  Tom Tromey  <tromey@adacore.com>
5700
5701         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5702
5703 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5704
5705         * gcore.in: Add '--readnever' option when invoking GDB.
5706
5707 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5708
5709         * MAINTAINERS: Update my email address.
5710
5711 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5712
5713         * build-id.c (build_id_to_debug_bfd_1): New function.
5714         (build_id_to_debug_bfd): Look for separate debug file in
5715         sysroot.
5716
5717 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5718
5719         * gdbarch.sh: Update the copyright year range that is placed into
5720         generated files.
5721
5722 2019-02-22  Keith Seitz  <keiths@redhat.com>
5723
5724         PR symtab/23853
5725         * linespec.c (create_sals_line_offset): Search for the default
5726         symtab's filename instead of its fullname.
5727
5728 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5729
5730         * NEWS: Update style defaults.
5731
5732 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5733
5734         * main.c (captured_main_1): Disable styling in batch mode.
5735
5736 2019-02-20  Tom Tromey  <tom@tromey.com>
5737
5738         * symtab.c (symtab_symbol_info): Fix typos.
5739
5740 2019-02-20  Tom Tromey  <tromey@adacore.com>
5741
5742         * findcmd.c (_initialize_mem_search): Use upper case for
5743         metasyntactic variables.
5744
5745 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5746
5747         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5748         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5749
5750 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5751
5752         * top.h (source_file_name): Change to std::string.
5753         * top.c (source_file_name): Likewise.
5754         (command_line_input): Adjust.
5755         * cli/cli-script.c (script_from_file): Adjust.
5756
5757 2019-02-19  Tom Tromey  <tromey@adacore.com>
5758
5759         * ravenscar-thread.c
5760         (ravenscar_thread_target::update_thread_list): Don't call
5761         ada_build_task_list.
5762         * ada-lang.h (ada_build_task_list): Don't declare.
5763         * ada-tasks.c (struct ada_tasks_inferior_data)
5764         <task_list_valid_p>: Now bool.
5765         (read_known_tasks, ada_task_list_changed)
5766         (ada_tasks_invalidate_inferior_data): Update.
5767         (read_known_tasks_array): Return bool.
5768         (read_known_tasks_list): Likewise.
5769         (read_known_tasks): Return void.
5770         (ada_build_task_list): Now static.
5771
5772 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5775         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5776
5777 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5778
5779         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5780         variant for ada_tasks_pspace_data_handle and
5781         ada_tasks_inferior_data_handle.
5782         (ada_tasks_pspace_data_cleanup): New function.
5783         (ada_tasks_inferior_data_cleanup): New function.
5784
5785 2019-02-17  Tom Tromey  <tom@tromey.com>
5786
5787         * macrotab.h (macro_source_fullname): Return a std::string.
5788         * macrotab.c (macro_include, check_for_redefinition)
5789         (macro_undef, macro_lookup_definition, foreach_macro)
5790         (foreach_macro_in_scope): Update.
5791         (macro_source_fullname): Return a std::string.
5792         * macrocmd.c (show_pp_source_pos): Update.
5793
5794 2019-02-17  Tom Tromey  <tom@tromey.com>
5795
5796         * macrocmd.c (show_pp_source_pos): Style the file names.
5797
5798 2019-02-17  Tom Tromey  <tom@tromey.com>
5799
5800         PR tui/24197:
5801         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5802
5803 2019-02-17  Tom Tromey  <tom@tromey.com>
5804
5805         * ada-lang.c (user_select_syms): Use filtered printing.
5806         * utils.c (wrap_style): New global.
5807         (desired_style): Remove.
5808         (emit_style_escape): Add stream parameter.
5809         (set_output_style, reset_terminal_style, prompt_for_continue):
5810         Update.
5811         (flush_wrap_buffer): Only flush gdb_stdout.
5812         (wrap_here): Set wrap_style.
5813         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5814         treat escape sequences as a character.  Change when wrap buffer is
5815         flushed.
5816         (fputs_styled): Do not set the output style when the default is
5817         requested.
5818         * ui-style.h (struct ui_file_style) <is_default>: New method.
5819         * source.c (print_source_lines_base): Emit escape sequences in one
5820         piece.
5821
5822 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5823
5824         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5825         integers and enumeration types.
5826
5827 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5828
5829         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5830         instead of lookup_symbol_in_language
5831         (do_exact_match): New function.
5832         (ada_get_symbol_name_matcher): Return do_exact_match when
5833         doing a verbatim match.
5834
5835 2019-02-15  Tom Tromey  <tromey@adacore.com>
5836
5837         * ravenscar-thread.c (ravenscar_thread_target::resume)
5838         (ravenscar_thread_target::wait): Special case wildcard requests.
5839
5840 2019-02-15  Tom Tromey  <tromey@adacore.com>
5841
5842         * ravenscar-thread.c (base_ptid): Remove.
5843         (struct ravenscar_thread_target) <close>: New method.
5844         <m_base_ptid>: New member.
5845         <update_inferior_ptid, active_task, task_is_currently_active,
5846         runtime_initialized>: Declare methods.
5847         <ravenscar_thread_target>: Add constructor.
5848         (ravenscar_thread_target::task_is_currently_active)
5849         (ravenscar_thread_target::update_inferior_ptid)
5850         (ravenscar_runtime_initialized): Rename.  Now methods.
5851         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5852         (ravenscar_thread_target::update_thread_list): Update.
5853         (ravenscar_thread_target::active_task): Now method.
5854         (ravenscar_thread_target::store_registers)
5855         (ravenscar_thread_target::prepare_to_store)
5856         (ravenscar_thread_target::prepare_to_store)
5857         (ravenscar_thread_target::mourn_inferior): Update.
5858         (ravenscar_inferior_created): Use "new" to create target.
5859         (ravenscar_thread_target::get_ada_task_ptid): Update.
5860         (_initialize_ravenscar): Don't initialize base_ptid.
5861         (ravenscar_ops): Remove global.
5862
5863 2019-02-15  Tom Tromey  <tromey@adacore.com>
5864
5865         * target.h (push_target): Declare new overload.
5866         * target.c (push_target): New overload, taking an rvalue reference.
5867         * remote.c (remote_target::open_1): Use push_target overload.
5868         * corelow.c (core_target_open): Use push_target overload.
5869
5870 2019-02-15  Tom Tromey  <tromey@adacore.com>
5871
5872         * ravenscar-thread.c (is_ravenscar_task)
5873         (ravenscar_task_is_currently_active): Return bool.
5874         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5875         (_initialize_ravenscar): Remove "(void)".
5876         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5877         Return bool.
5878
5879 2019-02-15  Tom Tromey  <tromey@adacore.com>
5880
5881         * ravenscar-thread.c (ravenscar_runtime_initializer)
5882         (has_ravenscar_runtime, get_running_thread_id)
5883         (ravenscar_thread_target::resume): Fix indentation.
5884
5885 2019-02-15  Tom Tromey  <tromey@adacore.com>
5886
5887         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5888         from ravenscar_arch_ops.
5889         (sparc_ravenscar_ops::fetch_registers)
5890         (sparc_ravenscar_ops::store_registers): Now methods.
5891         (sparc_ravenscar_prepare_to_store): Remove.
5892         (sparc_ravenscar_ops): Redefine.
5893         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5894         methods and destructor.  Remove members.
5895         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5896         (ravenscar_thread_target::store_registers)
5897         (ravenscar_thread_target::prepare_to_store): Update.
5898         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5899         Remove.
5900         (struct ppc_ravenscar_powerpc_ops): Derive from
5901         ravenscar_arch_ops.
5902         (ppc_ravenscar_powerpc_ops::fetch_registers)
5903         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5904         (ppc_ravenscar_powerpc_ops): Redefine.
5905         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5906         (ppc_ravenscar_e500_ops::fetch_registers)
5907         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5908         (ppc_ravenscar_e500_ops): Redefine.
5909         * aarch64-ravenscar-thread.c
5910         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5911         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5912         (aarch64_ravenscar_fetch_registers)
5913         (aarch64_ravenscar_store_registers): Now methods.
5914         (aarch64_ravenscar_ops): Redefine.
5915
5916 2019-02-15  Tom Tromey  <tromey@adacore.com>
5917
5918         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5919         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5920         (ravenscar_thread_target::stopped_by_watchpoint)
5921         (ravenscar_thread_target::stopped_data_address)
5922         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5923
5924 2019-02-15  Tom Tromey  <tromey@adacore.com>
5925
5926         * ravenscar-thread.c: Fix some typos.
5927
5928 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5929             Tom Tromey  <tromey@adacore.com>
5930
5931         * ada-lang.c (ada_exception_sal): Change addr_string to a
5932         std::string.
5933         (create_ada_exception_catchpoint): Update.
5934
5935 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5936             Tom Tromey  <tromey@adacore.com>
5937
5938         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5939         (bp_location_ops): Remove.
5940         (base_breakpoint_allocate_location): Update.
5941         (free_bp_location): Update.
5942         * ada-lang.c (class ada_catchpoint_location)
5943         <ada_catchpoint_location>: Remove ops parameter.
5944         (ada_catchpoint_location_dtor): Remove.
5945         (ada_catchpoint_location_ops): Remove.
5946         (allocate_location_exception): Update.
5947         * breakpoint.h (struct bp_location_ops): Remove.
5948         (class bp_location) <bp_location>: Remove bp_location_ops
5949         parameter.
5950         <~bp_location>: Add destructor.
5951         <ops>: Remove.
5952
5953 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5954             Pedro Alves  <palves@redhat.com>
5955
5956         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5957         'PATH_MAX'.
5958
5959 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5960             Samuel Thibault  <samuel.thibault@gnu.org>
5961             Thomas Schwinge  <thomas@codesourcery.com>
5962
5963         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5964         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5965
5966 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5967
5968         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5969         (check_empty): Use "const char *".
5970
5971         * gnu-nat.c (gnu_nat_target::detach): Instead of
5972         'detach_inferior (pid)' call
5973         'detach_inferior (find_inferior_pid (pid))'.
5974
5975         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5976         'nat/fork-inferior.o'.
5977         * gnu-nat.c: #include "nat/fork-inferior.h".
5978
5979         * gnu-nat.c (gnu_nat_target::detach): Instead of
5980         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5981         * gnu-nat.h: #include "inf-child.h".
5982         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5983         'i386_gnu_nat_target::fetch_registers'.
5984         (gnu_store_registers): Rename/move to
5985         'i386_gnu_nat_target::store_registers'.
5986
5987         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5988         * gnu-nat.h (mach_thread_info): New function.
5989         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5990
5991         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5992
5993 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5994
5995         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5996
5997 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5998
5999         * windows-nat.c (windows_add_thread): Add new parameter
6000         "main_thread_p" with default value set to false.  Update
6001         function documentation as well as all callers.
6002         (windows_delete_thread): Likewise.
6003         (fake_create_process): Update call to windows_add_thread.
6004         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6005         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6006         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6007         call to windows_delete_thread.
6008
6009 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6010
6011         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6012
6013 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6014
6015         * symfile.c (find_separate_debug_file): Use canonical path of
6016         sysroot with child_path instead of gdb_sysroot if it is valid.
6017
6018 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6019
6020         * symfile.c (find_separate_debug_file): Use child_path to
6021         determine if an object file is under a sysroot.
6022
6023 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6024
6025         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6026         unittests/child-path-selftests.c.
6027         * common/pathstuff.c (child_path): New function.
6028         * common/pathstuff.h (child_path): New prototype.
6029         * unittests/child-path-selftests.c: New file.
6030
6031 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6032
6033         * symfile.c (find_separate_debug_file): Look for separate debug
6034         files in debug directories under the sysroot.
6035
6036 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6037
6038         * symtab.h (struct minimal_symbol data_p): New const method.
6039         (struct minimal_symbol text_p): Likewise.
6040         * symtab.c (output_source_filename): Use file name style
6041         to print file name.
6042         (print_symbol_info): Likewise.
6043         (print_msymbol_info): Use address style to print addresses.
6044         Use function name style to print executable text symbols.
6045         (expand_symtab_containing_pc): Use data_p.
6046         (find_pc_sect_compunit_symtab): Likewise.
6047
6048 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6049
6050         * breakpoint.c (describe_other_breakpoints): Use address style
6051         to print addresses.
6052         (say_where): Likewise.
6053
6054 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6055
6056         * ada-typeprint.c (print_func_type): Print function name
6057         style to print function name.
6058         * c-typeprint.c (c_print_type_1): Likewise.
6059
6060 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6061
6062         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6063         for execve.
6064
6065 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6066
6067         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6068         type_stack.
6069
6070 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6071
6072         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6073         TYPE_CODE_REF types.
6074
6075 2019-02-08  Jim Wilson  <jimw@sifive.com>
6076
6077         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6078         (riscv_linux_fregset): New.
6079         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6080
6081 2019-02-07  Tom Tromey  <tom@tromey.com>
6082
6083         * thread.c (thread_cancel_execution_command): Update.
6084         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6085         methods.
6086         (struct thread_fsm_ops): Remove.
6087         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6088         (thread_fsm_should_stop, thread_fsm_return_value)
6089         (thread_fsm_set_finished, thread_fsm_finished_p)
6090         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6091         Don't declare.
6092         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6093         * infrun.c (clear_proceed_status_thread)
6094         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6095         (print_stop_event): Update.
6096         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6097         Add constructor.
6098         (step_command_fsm_ops): Remove.
6099         (new_step_command_fsm): Remove.
6100         (step_1): Update.
6101         (step_command_fsm::should_stop): Rename from
6102         step_command_fsm_should_stop.
6103         (step_command_fsm::clean_up): Rename from
6104         step_command_fsm_clean_up.
6105         (step_command_fsm::do_async_reply_reason): Rename from
6106         step_command_fsm_async_reply_reason.
6107         (struct until_next_fsm): Inherit from thread_fsm.  Add
6108         constructor.
6109         (until_next_fsm_ops): Remove.
6110         (new_until_next_fsm): Remove.
6111         (until_next_fsm::should_stop): Rename from
6112         until_next_fsm_should_stop.
6113         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6114         (until_next_fsm::do_async_reply_reason): Rename from
6115         until_next_fsm_async_reply_reason.
6116         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6117         constructor.  Change type of breakpoint.
6118         (finish_command_fsm_ops): Remove.
6119         (new_finish_command_fsm): Remove.
6120         (finish_command_fsm::should_stop): Rename from
6121         finish_command_fsm_should_stop.
6122         (finish_command_fsm::clean_up): Rename from
6123         finish_command_fsm_clean_up.
6124         (finish_command_fsm::return_value): Rename from
6125         finish_command_fsm_return_value.
6126         (finish_command_fsm::do_async_reply_reason): Rename from
6127         finish_command_fsm_async_reply_reason.
6128         (finish_command): Update.
6129         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6130         Add constructor.
6131         (call_thread_fsm_ops): Remove.
6132         (call_thread_fsm::call_thread_fsm): Rename from
6133         new_call_thread_fsm.
6134         (call_thread_fsm::should_stop): Rename from
6135         call_thread_fsm_should_stop.
6136         (call_thread_fsm::should_notify_stop): Rename from
6137         call_thread_fsm_should_notify_stop.
6138         (run_inferior_call, call_function_by_hand_dummy): Update.
6139         * cli/cli-interp.c (should_print_stop_to_console): Update.
6140         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6141         Add constructor.  Change type of location_breakpoint,
6142         caller_breakpoint.
6143         (until_break_fsm_ops): Remove.
6144         (new_until_break_fsm): Remove.
6145         (until_break_fsm::should_stop): Rename from
6146         until_break_fsm_should_stop.
6147         (until_break_fsm::clean_up): Rename from
6148         until_break_fsm_clean_up.
6149         (until_break_fsm::do_async_reply_reason): Rename from
6150         until_break_fsm_async_reply_reason.
6151         (until_break_command): Update.
6152         * thread-fsm.c: Remove.
6153         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6154
6155 2019-02-07  Tom Tromey  <tom@tromey.com>
6156
6157         * yy-remap.h: Add include guard.
6158         * xtensa-tdep.h: Add include guard.
6159         * xcoffread.h: Rename include guard.
6160         * varobj-iter.h: Add include guard.
6161         * tui/tui.h: Rename include guard.
6162         * tui/tui-winsource.h: Rename include guard.
6163         * tui/tui-wingeneral.h: Rename include guard.
6164         * tui/tui-windata.h: Rename include guard.
6165         * tui/tui-win.h: Rename include guard.
6166         * tui/tui-stack.h: Rename include guard.
6167         * tui/tui-source.h: Rename include guard.
6168         * tui/tui-regs.h: Rename include guard.
6169         * tui/tui-out.h: Rename include guard.
6170         * tui/tui-layout.h: Rename include guard.
6171         * tui/tui-io.h: Rename include guard.
6172         * tui/tui-hooks.h: Rename include guard.
6173         * tui/tui-file.h: Rename include guard.
6174         * tui/tui-disasm.h: Rename include guard.
6175         * tui/tui-data.h: Rename include guard.
6176         * tui/tui-command.h: Rename include guard.
6177         * tic6x-tdep.h: Add include guard.
6178         * target/waitstatus.h: Rename include guard.
6179         * target/wait.h: Rename include guard.
6180         * target/target.h: Rename include guard.
6181         * target/resume.h: Rename include guard.
6182         * target-float.h: Rename include guard.
6183         * stabsread.h: Add include guard.
6184         * rs6000-tdep.h: Add include guard.
6185         * riscv-fbsd-tdep.h: Add include guard.
6186         * regformats/regdef.h: Rename include guard.
6187         * record.h: Rename include guard.
6188         * python/python.h: Rename include guard.
6189         * python/python-internal.h: Rename include guard.
6190         * python/py-stopevent.h: Rename include guard.
6191         * python/py-ref.h: Rename include guard.
6192         * python/py-record.h: Rename include guard.
6193         * python/py-record-full.h: Rename include guard.
6194         * python/py-record-btrace.h: Rename include guard.
6195         * python/py-instruction.h: Rename include guard.
6196         * python/py-events.h: Rename include guard.
6197         * python/py-event.h: Rename include guard.
6198         * procfs.h: Add include guard.
6199         * proc-utils.h: Add include guard.
6200         * p-lang.h: Add include guard.
6201         * or1k-tdep.h: Rename include guard.
6202         * observable.h: Rename include guard.
6203         * nto-tdep.h: Rename include guard.
6204         * nat/x86-linux.h: Rename include guard.
6205         * nat/x86-linux-dregs.h: Rename include guard.
6206         * nat/x86-gcc-cpuid.h: Add include guard.
6207         * nat/x86-dregs.h: Rename include guard.
6208         * nat/x86-cpuid.h: Rename include guard.
6209         * nat/ppc-linux.h: Rename include guard.
6210         * nat/mips-linux-watch.h: Rename include guard.
6211         * nat/linux-waitpid.h: Rename include guard.
6212         * nat/linux-ptrace.h: Rename include guard.
6213         * nat/linux-procfs.h: Rename include guard.
6214         * nat/linux-osdata.h: Rename include guard.
6215         * nat/linux-nat.h: Rename include guard.
6216         * nat/linux-namespaces.h: Rename include guard.
6217         * nat/linux-btrace.h: Rename include guard.
6218         * nat/glibc_thread_db.h: Rename include guard.
6219         * nat/gdb_thread_db.h: Rename include guard.
6220         * nat/gdb_ptrace.h: Rename include guard.
6221         * nat/fork-inferior.h: Rename include guard.
6222         * nat/amd64-linux-siginfo.h: Rename include guard.
6223         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6224         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6225         * nat/aarch64-linux.h: Rename include guard.
6226         * nat/aarch64-linux-hw-point.h: Rename include guard.
6227         * mn10300-tdep.h: Add include guard.
6228         * mips-linux-tdep.h: Add include guard.
6229         * mi/mi-parse.h: Rename include guard.
6230         * mi/mi-out.h: Rename include guard.
6231         * mi/mi-main.h: Rename include guard.
6232         * mi/mi-interp.h: Rename include guard.
6233         * mi/mi-getopt.h: Rename include guard.
6234         * mi/mi-console.h: Rename include guard.
6235         * mi/mi-common.h: Rename include guard.
6236         * mi/mi-cmds.h: Rename include guard.
6237         * mi/mi-cmd-break.h: Rename include guard.
6238         * m2-lang.h: Add include guard.
6239         * location.h: Rename include guard.
6240         * linux-record.h: Rename include guard.
6241         * linux-nat.h: Add include guard.
6242         * linux-fork.h: Add include guard.
6243         * i386-darwin-tdep.h: Rename include guard.
6244         * hppa-linux-offsets.h: Add include guard.
6245         * guile/guile.h: Rename include guard.
6246         * guile/guile-internal.h: Rename include guard.
6247         * gnu-nat.h: Rename include guard.
6248         * gdb-stabs.h: Rename include guard.
6249         * frv-tdep.h: Add include guard.
6250         * f-lang.h: Add include guard.
6251         * event-loop.h: Add include guard.
6252         * darwin-nat.h: Rename include guard.
6253         * cp-abi.h: Rename include guard.
6254         * config/sparc/nm-sol2.h: Rename include guard.
6255         * config/nm-nto.h: Rename include guard.
6256         * config/nm-linux.h: Add include guard.
6257         * config/i386/nm-i386gnu.h: Rename include guard.
6258         * config/djgpp/nl_types.h: Rename include guard.
6259         * config/djgpp/langinfo.h: Rename include guard.
6260         * compile/gcc-cp-plugin.h: Add include guard.
6261         * compile/gcc-c-plugin.h: Add include guard.
6262         * compile/compile.h: Rename include guard.
6263         * compile/compile-object-run.h: Rename include guard.
6264         * compile/compile-object-load.h: Rename include guard.
6265         * compile/compile-internal.h: Rename include guard.
6266         * compile/compile-cplus.h: Rename include guard.
6267         * compile/compile-c.h: Rename include guard.
6268         * common/xml-utils.h: Rename include guard.
6269         * common/x86-xstate.h: Rename include guard.
6270         * common/version.h: Rename include guard.
6271         * common/vec.h: Rename include guard.
6272         * common/tdesc.h: Rename include guard.
6273         * common/selftest.h: Rename include guard.
6274         * common/scoped_restore.h: Rename include guard.
6275         * common/scoped_mmap.h: Rename include guard.
6276         * common/scoped_fd.h: Rename include guard.
6277         * common/safe-iterator.h: Rename include guard.
6278         * common/run-time-clock.h: Rename include guard.
6279         * common/refcounted-object.h: Rename include guard.
6280         * common/queue.h: Rename include guard.
6281         * common/ptid.h: Rename include guard.
6282         * common/print-utils.h: Rename include guard.
6283         * common/preprocessor.h: Rename include guard.
6284         * common/pathstuff.h: Rename include guard.
6285         * common/observable.h: Rename include guard.
6286         * common/netstuff.h: Rename include guard.
6287         * common/job-control.h: Rename include guard.
6288         * common/host-defs.h: Rename include guard.
6289         * common/gdb_wait.h: Rename include guard.
6290         * common/gdb_vecs.h: Rename include guard.
6291         * common/gdb_unlinker.h: Rename include guard.
6292         * common/gdb_unique_ptr.h: Rename include guard.
6293         * common/gdb_tilde_expand.h: Rename include guard.
6294         * common/gdb_sys_time.h: Rename include guard.
6295         * common/gdb_string_view.h: Rename include guard.
6296         * common/gdb_splay_tree.h: Rename include guard.
6297         * common/gdb_setjmp.h: Rename include guard.
6298         * common/gdb_ref_ptr.h: Rename include guard.
6299         * common/gdb_optional.h: Rename include guard.
6300         * common/gdb_locale.h: Rename include guard.
6301         * common/gdb_assert.h: Rename include guard.
6302         * common/filtered-iterator.h: Rename include guard.
6303         * common/filestuff.h: Rename include guard.
6304         * common/fileio.h: Rename include guard.
6305         * common/environ.h: Rename include guard.
6306         * common/common-utils.h: Rename include guard.
6307         * common/common-types.h: Rename include guard.
6308         * common/common-regcache.h: Rename include guard.
6309         * common/common-inferior.h: Rename include guard.
6310         * common/common-gdbthread.h: Rename include guard.
6311         * common/common-exceptions.h: Rename include guard.
6312         * common/common-defs.h: Rename include guard.
6313         * common/common-debug.h: Rename include guard.
6314         * common/cleanups.h: Rename include guard.
6315         * common/buffer.h: Rename include guard.
6316         * common/btrace-common.h: Rename include guard.
6317         * common/break-common.h: Rename include guard.
6318         * cli/cli-utils.h: Rename include guard.
6319         * cli/cli-style.h: Rename include guard.
6320         * cli/cli-setshow.h: Rename include guard.
6321         * cli/cli-script.h: Rename include guard.
6322         * cli/cli-interp.h: Rename include guard.
6323         * cli/cli-decode.h: Rename include guard.
6324         * cli/cli-cmds.h: Rename include guard.
6325         * charset-list.h: Add include guard.
6326         * buildsym-legacy.h: Rename include guard.
6327         * bfin-tdep.h: Add include guard.
6328         * ax.h: Rename include guard.
6329         * arm-linux-tdep.h: Add include guard.
6330         * arm-fbsd-tdep.h: Add include guard.
6331         * arch/xtensa.h: Rename include guard.
6332         * arch/tic6x.h: Add include guard.
6333         * arch/i386.h: Add include guard.
6334         * arch/arm.h: Rename include guard.
6335         * arch/arm-linux.h: Rename include guard.
6336         * arch/arm-get-next-pcs.h: Rename include guard.
6337         * arch/amd64.h: Add include guard.
6338         * arch/aarch64-insn.h: Rename include guard.
6339         * arch-utils.h: Rename include guard.
6340         * annotate.h: Add include guard.
6341         * amd64-darwin-tdep.h: Rename include guard.
6342         * aarch64-linux-tdep.h: Add include guard.
6343         * aarch64-fbsd-tdep.h: Add include guard.
6344         * aarch32-linux-nat.h: Add include guard.
6345
6346 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6347
6348         * macrotab.c (macro_define_internal): New function that
6349         factorizes macro_define_object_internal and macro_define_function
6350         code.
6351         (macro_define_object_internal): Use macro_define_internal.
6352         (macro_define_function): Likewise.
6353
6354 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6355
6356         * macrocmd.c (extract_identifier): Return
6357         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6358         callers.
6359
6360 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6361
6362         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6363
6364 2019-02-05  Tom Tromey  <tom@tromey.com>
6365
6366         * target.c (target_stack::unpush): Move assertion earlier.
6367
6368 2019-01-30  Tom Tromey  <tom@tromey.com>
6369
6370         PR python/23615:
6371         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6372         (gdbpy_parse_and_eval): Likewise.
6373         * python/python-internal.h (gdbpy_allow_threads): New class.
6374
6375 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6376
6377         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6378         (aarch64_fbsd_fpregmap): Move earlier.
6379         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6380         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6381         instead of individual calls to trad_frame_set_reg_addr.
6382         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6383         earlier.
6384         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6385         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6386         instead of individual calls to trad_frame_set_reg_addr.
6387
6388 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6389
6390         * CONTRIBUTE: Replace contribution list with wiki link.
6391
6392 2019-01-25  Tom Tromey  <tom@tromey.com>
6393
6394         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6395
6396 2019-01-25  Tom Tromey  <tom@tromey.com>
6397
6398         * xtensa-linux-nat.c: Fix common/ includes.
6399         * xml-support.h: Fix common/ includes.
6400         * xml-support.c: Fix common/ includes.
6401         * x86-linux-nat.c: Fix common/ includes.
6402         * windows-nat.c: Fix common/ includes.
6403         * varobj.h: Fix common/ includes.
6404         * varobj.c: Fix common/ includes.
6405         * value.c: Fix common/ includes.
6406         * valops.c: Fix common/ includes.
6407         * utils.c: Fix common/ includes.
6408         * unittests/xml-utils-selftests.c: Fix common/ includes.
6409         * unittests/utils-selftests.c: Fix common/ includes.
6410         * unittests/unpack-selftests.c: Fix common/ includes.
6411         * unittests/tracepoint-selftests.c: Fix common/ includes.
6412         * unittests/style-selftests.c: Fix common/ includes.
6413         * unittests/string_view-selftests.c: Fix common/ includes.
6414         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6415         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6416         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6417         * unittests/rsp-low-selftests.c: Fix common/ includes.
6418         * unittests/parse-connection-spec-selftests.c: Fix common/
6419         includes.
6420         * unittests/optional-selftests.c: Fix common/ includes.
6421         * unittests/offset-type-selftests.c: Fix common/ includes.
6422         * unittests/observable-selftests.c: Fix common/ includes.
6423         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6424         * unittests/memrange-selftests.c: Fix common/ includes.
6425         * unittests/memory-map-selftests.c: Fix common/ includes.
6426         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6427         * unittests/function-view-selftests.c: Fix common/ includes.
6428         * unittests/environ-selftests.c: Fix common/ includes.
6429         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6430         * unittests/common-utils-selftests.c: Fix common/ includes.
6431         * unittests/cli-utils-selftests.c: Fix common/ includes.
6432         * unittests/array-view-selftests.c: Fix common/ includes.
6433         * ui-file.c: Fix common/ includes.
6434         * tui/tui-io.c: Fix common/ includes.
6435         * tracepoint.h: Fix common/ includes.
6436         * tracepoint.c: Fix common/ includes.
6437         * tracefile-tfile.c: Fix common/ includes.
6438         * top.h: Fix common/ includes.
6439         * top.c: Fix common/ includes.
6440         * thread.c: Fix common/ includes.
6441         * target/waitstatus.h: Fix common/ includes.
6442         * target/waitstatus.c: Fix common/ includes.
6443         * target.h: Fix common/ includes.
6444         * target.c: Fix common/ includes.
6445         * target-memory.c: Fix common/ includes.
6446         * target-descriptions.c: Fix common/ includes.
6447         * symtab.h: Fix common/ includes.
6448         * symfile.c: Fix common/ includes.
6449         * stap-probe.c: Fix common/ includes.
6450         * spu-linux-nat.c: Fix common/ includes.
6451         * sparc-nat.c: Fix common/ includes.
6452         * source.c: Fix common/ includes.
6453         * solib.c: Fix common/ includes.
6454         * solib-target.c: Fix common/ includes.
6455         * ser-unix.c: Fix common/ includes.
6456         * ser-tcp.c: Fix common/ includes.
6457         * ser-pipe.c: Fix common/ includes.
6458         * ser-base.c: Fix common/ includes.
6459         * selftest-arch.c: Fix common/ includes.
6460         * s12z-tdep.c: Fix common/ includes.
6461         * rust-exp.y: Fix common/ includes.
6462         * rs6000-aix-tdep.c: Fix common/ includes.
6463         * riscv-tdep.c: Fix common/ includes.
6464         * remote.c: Fix common/ includes.
6465         * remote-notif.h: Fix common/ includes.
6466         * remote-fileio.h: Fix common/ includes.
6467         * remote-fileio.c: Fix common/ includes.
6468         * regcache.h: Fix common/ includes.
6469         * regcache.c: Fix common/ includes.
6470         * record-btrace.c: Fix common/ includes.
6471         * python/python.c: Fix common/ includes.
6472         * python/py-type.c: Fix common/ includes.
6473         * python/py-inferior.c: Fix common/ includes.
6474         * progspace.h: Fix common/ includes.
6475         * producer.c: Fix common/ includes.
6476         * procfs.c: Fix common/ includes.
6477         * proc-api.c: Fix common/ includes.
6478         * printcmd.c: Fix common/ includes.
6479         * ppc-linux-nat.c: Fix common/ includes.
6480         * parser-defs.h: Fix common/ includes.
6481         * osdata.c: Fix common/ includes.
6482         * obsd-nat.c: Fix common/ includes.
6483         * nat/x86-linux.c: Fix common/ includes.
6484         * nat/x86-linux-dregs.c: Fix common/ includes.
6485         * nat/x86-dregs.h: Fix common/ includes.
6486         * nat/x86-dregs.c: Fix common/ includes.
6487         * nat/ppc-linux.c: Fix common/ includes.
6488         * nat/mips-linux-watch.h: Fix common/ includes.
6489         * nat/mips-linux-watch.c: Fix common/ includes.
6490         * nat/linux-waitpid.c: Fix common/ includes.
6491         * nat/linux-ptrace.h: Fix common/ includes.
6492         * nat/linux-ptrace.c: Fix common/ includes.
6493         * nat/linux-procfs.c: Fix common/ includes.
6494         * nat/linux-personality.c: Fix common/ includes.
6495         * nat/linux-osdata.c: Fix common/ includes.
6496         * nat/linux-namespaces.c: Fix common/ includes.
6497         * nat/linux-btrace.h: Fix common/ includes.
6498         * nat/linux-btrace.c: Fix common/ includes.
6499         * nat/fork-inferior.c: Fix common/ includes.
6500         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6501         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6502         * nat/aarch64-linux.c: Fix common/ includes.
6503         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6504         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6505         * namespace.h: Fix common/ includes.
6506         * mips-linux-tdep.c: Fix common/ includes.
6507         * minsyms.c: Fix common/ includes.
6508         * mi/mi-parse.h: Fix common/ includes.
6509         * mi/mi-main.c: Fix common/ includes.
6510         * mi/mi-cmd-env.c: Fix common/ includes.
6511         * memrange.h: Fix common/ includes.
6512         * memattr.c: Fix common/ includes.
6513         * maint.h: Fix common/ includes.
6514         * maint.c: Fix common/ includes.
6515         * main.c: Fix common/ includes.
6516         * machoread.c: Fix common/ includes.
6517         * location.c: Fix common/ includes.
6518         * linux-thread-db.c: Fix common/ includes.
6519         * linux-nat.c: Fix common/ includes.
6520         * linux-fork.c: Fix common/ includes.
6521         * inline-frame.c: Fix common/ includes.
6522         * infrun.c: Fix common/ includes.
6523         * inflow.c: Fix common/ includes.
6524         * inferior.h: Fix common/ includes.
6525         * inferior.c: Fix common/ includes.
6526         * infcmd.c: Fix common/ includes.
6527         * inf-ptrace.c: Fix common/ includes.
6528         * inf-child.c: Fix common/ includes.
6529         * ia64-linux-nat.c: Fix common/ includes.
6530         * i387-tdep.c: Fix common/ includes.
6531         * i386-tdep.c: Fix common/ includes.
6532         * i386-linux-tdep.c: Fix common/ includes.
6533         * i386-linux-nat.c: Fix common/ includes.
6534         * i386-go32-tdep.c: Fix common/ includes.
6535         * i386-fbsd-tdep.c: Fix common/ includes.
6536         * i386-fbsd-nat.c: Fix common/ includes.
6537         * guile/scm-type.c: Fix common/ includes.
6538         * guile/guile.c: Fix common/ includes.
6539         * go32-nat.c: Fix common/ includes.
6540         * gnu-nat.c: Fix common/ includes.
6541         * gdbthread.h: Fix common/ includes.
6542         * gdbarch-selftests.c: Fix common/ includes.
6543         * gdb_usleep.c: Fix common/ includes.
6544         * gdb_select.h: Fix common/ includes.
6545         * gdb_bfd.c: Fix common/ includes.
6546         * gcore.c: Fix common/ includes.
6547         * fork-child.c: Fix common/ includes.
6548         * findvar.c: Fix common/ includes.
6549         * fbsd-nat.c: Fix common/ includes.
6550         * event-top.c: Fix common/ includes.
6551         * event-loop.c: Fix common/ includes.
6552         * dwarf2read.c: Fix common/ includes.
6553         * dwarf2loc.c: Fix common/ includes.
6554         * dwarf2-frame.c: Fix common/ includes.
6555         * dwarf-index-cache.c: Fix common/ includes.
6556         * dtrace-probe.c: Fix common/ includes.
6557         * disasm-selftests.c: Fix common/ includes.
6558         * defs.h: Fix common/ includes.
6559         * csky-tdep.c: Fix common/ includes.
6560         * cp-valprint.c: Fix common/ includes.
6561         * cp-support.h: Fix common/ includes.
6562         * cp-support.c: Fix common/ includes.
6563         * corelow.c: Fix common/ includes.
6564         * completer.h: Fix common/ includes.
6565         * completer.c: Fix common/ includes.
6566         * compile/compile.c: Fix common/ includes.
6567         * compile/compile-loc2c.c: Fix common/ includes.
6568         * compile/compile-cplus-types.c: Fix common/ includes.
6569         * compile/compile-cplus-symbols.c: Fix common/ includes.
6570         * command.h: Fix common/ includes.
6571         * cli/cli-dump.c: Fix common/ includes.
6572         * cli/cli-cmds.c: Fix common/ includes.
6573         * charset.c: Fix common/ includes.
6574         * build-id.c: Fix common/ includes.
6575         * btrace.h: Fix common/ includes.
6576         * btrace.c: Fix common/ includes.
6577         * breakpoint.h: Fix common/ includes.
6578         * breakpoint.c: Fix common/ includes.
6579         * ax.h:
6580         (enum agent_op): Fix common/ includes.
6581         * ax-general.c (struct aop_map): Fix common/ includes.
6582         * ax-gdb.c: Fix common/ includes.
6583         * auxv.c: Fix common/ includes.
6584         * auto-load.c: Fix common/ includes.
6585         * arm-tdep.c: Fix common/ includes.
6586         * arch/riscv.c: Fix common/ includes.
6587         * arch/ppc-linux-common.c: Fix common/ includes.
6588         * arch/i386.c: Fix common/ includes.
6589         * arch/arm.c: Fix common/ includes.
6590         * arch/arm-linux.c: Fix common/ includes.
6591         * arch/arm-get-next-pcs.c: Fix common/ includes.
6592         * arch/amd64.c: Fix common/ includes.
6593         * arch/aarch64.c: Fix common/ includes.
6594         * arch/aarch64-insn.c: Fix common/ includes.
6595         * arch-utils.c: Fix common/ includes.
6596         * amd64-windows-tdep.c: Fix common/ includes.
6597         * amd64-tdep.c: Fix common/ includes.
6598         * amd64-sol2-tdep.c: Fix common/ includes.
6599         * amd64-obsd-tdep.c: Fix common/ includes.
6600         * amd64-nbsd-tdep.c: Fix common/ includes.
6601         * amd64-linux-tdep.c: Fix common/ includes.
6602         * amd64-linux-nat.c: Fix common/ includes.
6603         * amd64-fbsd-tdep.c: Fix common/ includes.
6604         * amd64-fbsd-nat.c: Fix common/ includes.
6605         * amd64-dicos-tdep.c: Fix common/ includes.
6606         * amd64-darwin-tdep.c: Fix common/ includes.
6607         * agent.c: Fix common/ includes.
6608         * ada-lang.h: Fix common/ includes.
6609         * ada-lang.c: Fix common/ includes.
6610         * aarch64-tdep.c: Fix common/ includes.
6611
6612 2019-01-25  Tom Tromey  <tom@tromey.com>
6613
6614         * common/create-version.sh: Use common/version.h.
6615
6616 2019-01-24  Pedro Alves  <palves@redhat.com>
6617
6618         * infrun.c (signal_stop, signal_print, signal_program)
6619         (signal_catch, signal_pass): Now arrays instead of pointers.
6620         (update_signals_program_target, do_target_resume)
6621         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6622         * linux-nat.c (linux_nat_target::pass_signals)
6623         (linux_nat_target::create_inferior, linux_nat_target::attach):
6624         Adjust.
6625         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6626         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6627         * procfs.c (procfs_target::pass_signals): Adjust.
6628         * record-full.c (record_full_target::resume): Adjust.
6629         * remote.c (remote_target::pass_signals)
6630         (remote_target::program_signals): Adjust.
6631         * target-debug.h (target_debug_print_signals): Now takes a
6632         gdb::array_view as parameter.  Adjust.
6633         * target.h (target_ops) <pass_signals, program_signals>: Replace
6634         pointer and length parameters with gdb::array_view.
6635         (target_pass_signals, target_program_signals): Likewise.
6636         * target-delegates.c: Regenerate.
6637
6638 2019-01-24  Pedro Alves  <palves@redhat.com>
6639
6640         * common/forward-scope-exit.h
6641         (forward_scope_exit::forward_scope_exit): Pass arguments to
6642         m_bind_function directly, instead of creating a std::bind and
6643         copying that.
6644
6645 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6646
6647         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6648         for static members.
6649         (pass_in_v_vfp_candidate): Likewise.
6650
6651 2019-01-23  Tom Tromey  <tom@tromey.com>
6652             Pedro Alves  <palves@redhat.com>
6653
6654         * regcache.c (class regcache_invalidator): Remove.
6655         (regcache::raw_write): Use make_scope_exit.
6656
6657 2019-01-23  Tom Tromey  <tom@tromey.com>
6658
6659         * ui-out.h (class ui_out_emit_type): Update comment.
6660
6661 2019-01-23  Tom Tromey  <tom@tromey.com>
6662
6663         * infrun.c (fetch_inferior_event): Update comment.
6664
6665 2019-01-23  Tom Tromey  <tom@tromey.com>
6666             Pedro Alves  <palves@redhat.com>
6667
6668         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6669         parameter.
6670         (fetch_inferior_event): Use SCOPE_EXIT.
6671
6672
6673 2019-01-23  Tom Tromey  <tom@tromey.com>
6674             Pedro Alves  <palves@redhat.com>
6675
6676         * infrun.c (disable_thread_events): Delete.
6677         (stop_all_threads): Use SCOPE_EXIT.
6678
6679 2019-01-23  Tom Tromey  <tom@tromey.com>
6680             Pedro Alves  <palves@redhat.com>
6681
6682         * symfile.c: Include forward-scope-exit.h.
6683         (clear_symtab_users_cleanup): Replace forward declaration with
6684         a FORWARD_SCOPE_EXIT.
6685         (syms_from_objfile_1): Use the forward_scope_exit and
6686         gdb::optional instead of cleanup_function.
6687         (reread_symbols): Use the forward_scope_exit instead of
6688         cleanup_function.
6689         (clear_symtab_users_cleanup): Remove function.
6690
6691 2019-01-23  Tom Tromey  <tom@tromey.com>
6692             Pedro Alves  <palves@redhat.com>
6693
6694         * linux-nat.c: Include scope-exit.h.
6695         (cleanup_target_stop): Remove.
6696         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6697         SCOPE_EXIT.
6698
6699 2019-01-23  Tom Tromey  <tom@tromey.com>
6700             Pedro Alves  <palves@redhat.com>
6701
6702         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6703         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6704
6705 2019-01-23  Tom Tromey  <tom@tromey.com>
6706             Andrew Burgess  <andrew.burgess@embecosm.com>
6707             Pedro Alves  <palves@redhat.com>
6708
6709         * infrun.c (fetch_inferior_event): Use scope_exit.
6710         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6711         * top.c (execute_command): Use scope_exit.
6712         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6713         * utils.c (do_bpstat_clear_actions_cleanup)
6714         (make_bpstat_clear_actions_cleanup): Remove.
6715
6716 2019-01-23  Tom Tromey  <tom@tromey.com>
6717             Pedro Alves  <palves@redhat.com>
6718
6719         * infrun.c: Include "common/scope-exit.h"
6720         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6721         (wait_for_inferior): Use SCOPE_EXIT.
6722         (fetch_inferior_event): Use scope_exit.
6723
6724 2019-01-23  Tom Tromey  <tom@tromey.com>
6725             Pedro Alves  <palves@redhat.com>
6726
6727         * breakpoint.c (create_breakpoint): Remove cleanup.
6728
6729 2019-01-23  Tom Tromey  <tom@tromey.com>
6730             Andrew Burgess  <andrew.burgess@embecosm.com>
6731             Pedro Alves  <palves@redhat.com>
6732
6733 2019-01-23  Pedro Alves  <palves@redhat.com>
6734
6735         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6736
6737 2019-01-23  Pedro Alves  <palves@redhat.com>
6738             Andrew Burgess  <andrew.burgess@embecosm.com>
6739
6740         * gdbthread.h: Include "common/forward-scope-exit.h".
6741         (scoped_finish_thread_state): Redefine custom class in terms of
6742         forward_scope_exit.
6743
6744 2019-01-23  Pedro Alves  <palves@redhat.com>
6745             Andrew Burgess  <andrew.burgess@embecosm.com>
6746
6747         * common/forward-scope-exit.h: New file.
6748
6749 2019-01-23  Pedro Alves  <palves@redhat.com>
6750             Andrew Burgess  <andrew.burgess@embecosm.com>
6751             Tom Tromey  <tom@tromey.com>
6752
6753         * common/scope-exit.h: New file.
6754
6755 2019-01-23  Pedro Alves  <palves@redhat.com>
6756
6757         * common/preprocessor.h (ESC): Rename to ...
6758         (ESC_PARENS): ... this.
6759         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6760         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6761
6762 2019-01-23  Tom Tromey  <tom@tromey.com>
6763
6764         * language.h (class scoped_switch_to_sym_language_if_auto):
6765         Initialize m_lang in both cases.
6766
6767 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6768
6769         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6770         with XCNEW.
6771
6772 2019-01-22  Tom Tromey  <tom@tromey.com>
6773
6774         * corelow.c: Do not include sys/file.h.
6775
6776 2019-01-22  Tom Tromey  <tom@tromey.com>
6777
6778         * tui/tui-wingeneral.h: Include gdb_curses.h.
6779
6780 2019-01-22  Tom Tromey  <tom@tromey.com>
6781
6782         * source-cache.h (class source_cache) <get_source_lines,
6783         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6784
6785 2019-01-22  Tom Tromey  <tom@tromey.com>
6786
6787         * remote-fileio.h (struct remote_target): Declare.
6788
6789 2019-01-22  Tom Tromey  <tom@tromey.com>
6790
6791         * python/py-arch.c: Do not include py-ref.h.
6792         * python/py-bpevent.c: Do not include py-ref.h.
6793         * python/py-cmd.c: Do not include py-ref.h.
6794         * python/py-continueevent.c: Do not include py-ref.h.
6795         * python/py-event.h: Do not include py-ref.h.
6796         * python/py-evtregistry.c: Do not include py-ref.h.
6797         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6798         * python/py-frame.c: Do not include py-ref.h.
6799         * python/py-framefilter.c: Do not include py-ref.h.
6800         * python/py-function.c: Do not include py-ref.h.
6801         * python/py-infevents.c: Do not include py-ref.h.
6802         * python/py-linetable.c: Do not include py-ref.h.
6803         * python/py-objfile.c: Do not include py-ref.h.
6804         * python/py-param.c: Do not include py-ref.h.
6805         * python/py-prettyprint.c: Do not include py-ref.h.
6806         * python/py-progspace.c: Do not include py-ref.h.
6807         * python/py-symbol.c: Do not include py-ref.h.
6808         * python/py-symtab.c: Do not include py-ref.h.
6809         * python/py-type.c: Do not include py-ref.h.
6810         * python/py-unwind.c: Do not include py-ref.h.
6811         * python/py-utils.c: Do not include py-ref.h.
6812         * python/py-value.c: Do not include py-ref.h.
6813         * python/py-varobj.c: Do not include py-ref.h.
6814         * python/py-xmethods.c: Do not include py-ref.h.
6815         * python/python.c: Do not include py-ref.h.
6816         * varobj.c: Do not include py-ref.h.
6817
6818 2019-01-22  Tom Tromey  <tom@tromey.com>
6819
6820         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6821         keyword for bcache.
6822
6823 2019-01-22  Tom Tromey  <tom@tromey.com>
6824
6825         * compile/compile-cplus-types.c: Remove a comment by #include.
6826
6827 2019-01-22  Tom Tromey  <tom@tromey.com>
6828
6829         * compile/gcc-c-plugin.h: Include compile-internal.h.
6830
6831 2019-01-22  Tom Tromey  <tom@tromey.com>
6832
6833         * stabsread.c (EXTERN): Do not define.
6834         (symnum, next_symbol_text_func, processing_gcc_compilation)
6835         (within_function, global_sym_chain, global_stabs)
6836         (previous_stab_code, this_object_header_files)
6837         (n_this_object_header_files)
6838         (n_allocated_this_object_header_files): Define.
6839         * stabsread.h (EXTERN): Never define.  Use "extern".
6840
6841 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6842
6843         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6844         history_value.
6845
6846 2019-01-21  Tom Tromey  <tom@tromey.com>
6847
6848         * ui-out.c: Fix includes.
6849         * tui/tui-source.c: Fix includes.
6850         * target.c: Fix includes.
6851         * remote.c: Fix includes.
6852         * regcache.c: Fix includes.
6853         * python/py-block.c: Fix includes.
6854         * printcmd.c: Fix includes.
6855         * or1k-tdep.c: Fix includes.
6856         * mi/mi-main.c: Fix includes.
6857         * m32r-tdep.c: Fix includes.
6858         * csky-tdep.c: Fix includes.
6859         * compile/compile-cplus-types.c: Fix includes.
6860         * cli/cli-interp.c: Fix includes.
6861
6862 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6863
6864         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6865         for padding.
6866
6867 2019-01-16  Tom Tromey  <tom@tromey.com>
6868
6869         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6870         earlier.
6871         (struct objfile) <msymbols_range>: Move from top level.
6872         <msymbols>: New method.
6873         (class objfile_msymbols): Remove.
6874         * symtab.c (default_collect_symbol_completion_matches_break_on):
6875         Update.
6876         * symmisc.c (dump_msymbols): Update.
6877         * stabsread.c (scan_file_globals): Update.
6878         * objc-lang.c (info_selectors_command, info_classes_command)
6879         (find_methods): Update.
6880         * minsyms.c (find_solib_trampoline_target): Update.
6881         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6882         * coffread.c (coff_symfile_read): Update.
6883         * ada-lang.c (ada_lookup_simple_minsym)
6884         (ada_collect_symbol_completion_matches): Update.
6885
6886 2019-01-16  Tom Tromey  <tom@tromey.com>
6887
6888         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6889         type.  Remove no-argument constructor.
6890         <iterator::operator++>: Simplify.
6891         <begin>: Update.
6892         <end>: Use minimal_symbol_count.
6893
6894 2019-01-16  Tom Tromey  <tom@tromey.com>
6895
6896         * objfiles.h (struct objfile) <psymtabs>: New method.
6897         (class objfile_psymtabs): Remove.
6898         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6899         typedef.
6900         <range>: New method.
6901         (require_partial_symbols): Change return type.
6902         * psymtab.c (require_partial_symbols)
6903         (psym_expand_symtabs_matching): Update.
6904         * mdebugread.c (parse_partial_symbols): Update.
6905         * dbxread.c (dbx_end_psymtab): Update.
6906
6907 2019-01-15  Tom Tromey  <tom@tromey.com>
6908
6909         * symtab.c (lookup_objfile_from_block)
6910         (lookup_symbol_in_objfile_symtabs)
6911         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6912         (find_line_symtab, info_sources_command)
6913         (default_collect_symbol_completion_matches_break_on)
6914         (make_source_files_completion_list): Update.
6915         * symmisc.c (print_objfile_statistics, dump_objfile)
6916         (maintenance_print_symbols, maintenance_info_symtabs)
6917         (maintenance_check_symtabs, maintenance_info_line_tables):
6918         Update.
6919         * source.c (select_source_symtab)
6920         (forget_cached_source_info_for_objfile): Update.
6921         * objfiles.h (class objfile_compunits): Remove.
6922         (struct objfile) <compunits_range>: New typedef.
6923         (compunits): New method.
6924         * objfiles.c (objfile_relocate1): Update.
6925         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6926         * maint.c (count_symtabs_and_blocks): Update.
6927         * linespec.c (iterate_over_all_matching_symtabs): Update.
6928         * cp-support.c (add_symbol_overload_list_qualified): Update.
6929         * coffread.c (coff_symtab_read): Update.
6930         * ada-lang.c (add_nonlocal_symbols)
6931         (ada_collect_symbol_completion_matches)
6932         (ada_add_global_exceptions): Update.
6933
6934 2019-01-15  Tom Tromey  <tom@tromey.com>
6935
6936         * progspace.h (program_space) <objfiles_safe_range>: New
6937         typedef.
6938         <objfiles_safe>: New method.
6939         * objfiles.h (class all_objfiles_safe): Remove.
6940         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6941         * jit.c (jit_inferior_exit_hook): Update.
6942
6943 2019-01-17  Tom Tromey  <tom@tromey.com>
6944
6945         * progspace.h (program_space) <objfiles_range>: New typedef.
6946         <objfiles>: New method.
6947         <objfiles_head>: Rename from objfiles.
6948         (object_files): Update.
6949         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6950         * guile/scm-pretty-print.c
6951         (ppscm_find_pretty_printer_from_objfiles): Update.
6952         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6953         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6954         Update.
6955         * python/py-progspace.c (pspy_get_objfiles): Update.
6956         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6957         Update.
6958         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6959         (objfpy_lookup_objfile_by_build_id): Update.
6960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6961         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6962         Update.
6963         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6964         (expand_symtab_containing_pc, lookup_objfile_from_block)
6965         (lookup_static_symbol, basic_lookup_transparent_type)
6966         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6967         (find_line_symtab, info_sources_command)
6968         (default_collect_symbol_completion_matches_break_on)
6969         (make_source_files_completion_list, find_main_name): Update.
6970         * symmisc.c (print_symbol_bcache_statistics)
6971         (print_objfile_statistics, maintenance_print_symbols)
6972         (maintenance_print_msymbols, maintenance_print_objfiles)
6973         (maintenance_info_symtabs, maintenance_check_symtabs)
6974         (maintenance_expand_symtabs, maintenance_info_line_tables):
6975         Update.
6976         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6977         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6978         (map_overlay_command, unmap_overlay_command)
6979         (simple_overlay_update, expand_symtabs_matching)
6980         (map_symbol_filenames): Update.
6981         * symfile-debug.c (set_debug_symfile): Update.
6982         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6983         Update.
6984         * source.c (select_source_symtab, forget_cached_source_info):
6985         Update.
6986         * solib.c (solib_read_symbols): Update.
6987         * solib-spu.c (append_ocl_sos): Update.
6988         * psymtab.c (maintenance_print_psymbols)
6989         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6990         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6991         * printcmd.c (info_symbol_command): Update.
6992         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6993         Update.
6994         * objfiles.h (class all_objfiles): Remove.
6995         * objfiles.c (have_partial_symbols, have_full_symbols)
6996         (have_minimal_symbols, qsort_cmp, update_section_map)
6997         (shared_objfile_contains_address_p)
6998         (default_iterate_over_objfiles_in_search_order): Update.
6999         * objc-lang.c (info_selectors_command, info_classes_command)
7000         (find_methods): Update.
7001         * minsyms.c (find_solib_trampoline_target): Update.
7002         * maint.c (maintenance_info_sections)
7003         (maintenance_translate_address, count_symtabs_and_blocks):
7004         Update.
7005         * main.c (captured_main_1): Update.
7006         * linux-thread-db.c (try_thread_db_load_from_pdir)
7007         (has_libpthread): Update.
7008         * linespec.c (iterate_over_all_matching_symtabs)
7009         (search_minsyms_for_name): Update.
7010         * jit.c (jit_find_objf_with_entry_addr): Update.
7011         * hppa-tdep.c (find_unwind_entry)
7012         (hppa_lookup_stub_minimal_symbol): Update.
7013         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7014         Update.
7015         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7016         (elf_gnu_ifunc_resolve_by_got): Update.
7017         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7018         * dwarf-index-write.c (save_gdb_index_command): Update.
7019         * cp-support.c (add_symbol_overload_list_qualified): Update.
7020         * breakpoint.c (create_overlay_event_breakpoint)
7021         (create_longjmp_master_breakpoint)
7022         (create_std_terminate_master_breakpoint)
7023         (create_exception_master_breakpoint): Update.
7024         * blockframe.c (find_pc_partial_function): Update.
7025         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7026         (ada_collect_symbol_completion_matches)
7027         (ada_add_global_exceptions): Update.
7028
7029 2019-01-17  Tom Tromey  <tom@tromey.com>
7030
7031         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7032         declare VEC.
7033         (solib_target_parse_libraries): Change return type.
7034         (library_list_start_segment, library_list_start_section)
7035         (library_list_end_library, library_list_start_library); Update.
7036         (solib_target_free_library_list): Remove.
7037         (solib_target_parse_libraries): Remove cleanup.  Change return
7038         type.
7039         (solib_target_current_sos): Update.
7040
7041 2019-01-17  Tom Tromey  <tromey@bapiya>
7042
7043         * valprint.c: Replace "the the" with "the".
7044         * symtab.c: Replace "the the" with "the".
7045         * solib.c: Replace "the the" with "the".
7046         * solib-dsbt.c: Replace "the the" with "the".
7047         * linespec.c: Replace "the the" with "the".
7048         * dwarf2loc.h: Replace "the the" with "the".
7049         * amd64-windows-tdep.c: Replace "the the" with "the".
7050         * aarch64-tdep.c: Replace "the the" with "the".
7051
7052 2019-01-16  Keith Seitz  <keiths@redhat.com>
7053
7054         PR gdb/23773
7055         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7056         <builder>: Rename to ..
7057         <m_builder>: ... this and make private.
7058         (dwarf2_cu::get_builder): New method.  Change all users of
7059         `builder' to use this method.
7060         (dwarf2_start_symtab): Move to ...
7061         (dwarf2_cu::start_symtab): ... here.  Update all callers
7062         (setup_type_unit_groups): Move to ...
7063         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7064         callers.
7065         (dwarf2_cu::reset_builder): New method.
7066         (process_full_compunit, process_full_type_unit): Use
7067         dwarf2_cu::reset_builder.
7068         (follow_die_offset): Record the ancestor CU if it is different
7069         from the followed DIE's CU.
7070         (follow_die_sig_1): Likewise.
7071
7072 2019-01-15  Tom Tromey  <tom@tromey.com>
7073
7074         * remote.c (class remote_state) <buf>: Now a char_vector.
7075         <buf_size>: Remove.
7076         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7077         parameter.
7078         (remote_target::getpkt_or_notif_sane_1)
7079         (remote_target::getpkt_sane)
7080         (remote_target::getpkt_or_notif_sane): Likewise.
7081         (class remote_target) <putpkt>: New overload.
7082         (remote_target::read_frame): Change type of "buf_p".  Remove
7083         sizeof_p parameter.
7084         (packet_ok): New overload.
7085         (packet_check_result): New overload.
7086         Update all uses.
7087
7088 2019-01-14  Tom Tromey  <tom@tromey.com>
7089
7090         * remote-notif.c (handle_notification, remote_notif_ack)
7091         (remote_notif_parse): Make "buf" const.
7092         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7093         const.
7094         (remote_notif_parse, remote_notif_ack, handle_notification):
7095         Likewise.
7096         * remote.c (remote_notif_stop_parse): Make "buf" const.
7097         (remote_target::remote_parse_stop_reply): Make "buf" const.
7098         (remote_notif_stop_ack): Make "buf" const.
7099
7100 2019-01-14  Tom Tromey  <tom@tromey.com>
7101
7102         * remote.c (remote_console_output): Make parameter const.
7103
7104 2019-01-14  Tom Tromey  <tom@tromey.com>
7105
7106         * target-debug.h (target_debug_print_signals): Constify.
7107         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7108         * procfs.c (procfs_target::pass_signals): Update.
7109         * linux-nat.c (linux_nat_target::pass_signals): Update.
7110         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7111         * target-delegates.c: Rebuild.
7112         * remote.c (remote_target::program_signals): Update.
7113         (remote_target::pass_signals): Update.
7114         * target.c (target_pass_signals): Constify argument.
7115         (target_program_signals): Likewise.
7116         * target.h (struct target_ops) <pass_signals, program_signals>:
7117         Constify argument.
7118         (target_pass_signals, target_program_signals): Constify argument.
7119
7120 2019-01-14  Tom Tromey  <tom@tromey.com>
7121
7122         PR tui/28819:
7123         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7124
7125 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7126
7127         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7128         field.
7129         * rs6000-tdep.c: Include reggroups.h.
7130         (IS_V_ALIAS_PSEUDOREG): Define.
7131         (rs6000_register_name): Return names for the "vX" aliases.
7132         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7133         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7134         aliases.  Call default_register_reggroup_p for all other
7135         pseudo-registers.
7136         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7137         New functions.
7138         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7139         Handle "vX" aliases.
7140         (v_alias_pseudo_register_collect): New function.
7141         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7142         (rs6000_gdbarch_init): Initialize "vX" aliases as
7143         pseudo-registers.  Restore registration of
7144         rs6000_pseudo_register_reggroup_p with
7145         set_tdesc_pseudo_register_reggroup_p.
7146
7147 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7148
7149         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7150         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7151         set_gdbarch_num_pseudo_regs.
7152
7153 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7154
7155         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7156         Remove arg prefixname, add do_set and do_show.
7157         Add member functions set_list and show_list.
7158         * cli/cli-style.c (class cli_style_option): Update accordingly.
7159         (style_set_list): Move to file scope.
7160         (style_show_list): Likewise.
7161         (set_style): Call help_list.
7162         (show_style): Call cmd_show_list.
7163         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7164         Update to use the new macro.
7165
7166 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7167
7168         * ada-lang.c (_initialize_ada_language): Expand the help text
7169         for the "catch exception" command.
7170
7171 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7172
7173         * symtab.c (matching_obj_sections): Initialize obj,
7174         declare it closer to its usage.
7175
7176 2019-01-10  Tom Tromey  <tom@tromey.com>
7177
7178         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7179         (basic_inf_threads_range): Remove.
7180         (inf_threads_range, inf_non_exited_threads_range)
7181         (safe_inf_threads_range): Use next_adapter.
7182
7183 2019-01-10  Keith Seitz  <keiths@redhat.com>
7184
7185         PR gdb/23712
7186         PR symtab/23010
7187         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7188         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7189
7190 2019-01-10  Keith Seitz  <keiths@redhat.com>
7191
7192         PR gdb/23712
7193         PR symtab/23010
7194         * dictionary.c (pending_to_vector): Remove.
7195         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7196         Remove _1 suffix, replacing functions of the same name.  Update
7197         all callers.
7198         (dict_create_hashed, dict_create_hashed_expandable)
7199         (dict_create_linear, dict_create_linear_expandable, dict_free)
7200         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7201         Make functions static.
7202
7203 2019-01-10  Keith Seitz  <keiths@redhat.com>
7204
7205         PR gdb/23712
7206         PR symtab/23010
7207         * dictionary.h (struct dictionary): Replace declaration with
7208         multidictionary.
7209         (dict_create_hashed, dict_create_hashed_expandable)
7210         (dict_create_linear, dict_create_linear_expandable)
7211         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7212         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7213         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7214         taking multidictionary argument.
7215         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7216         * block.h (struct block) <dict>: Change to multidictionary
7217         and rename `multidict'.
7218         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7219         symmisc.c: Update all dictionary references to multidictionary.
7220
7221 2019-01-10  Keith Seitz  <keiths@redhat.com>
7222
7223         PR gdb/23712
7224         PR symtab/23010
7225         * dictionary.c: Include unordered_map.
7226         (pending_to_vector): New function.
7227         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7228         Rewrite the non-"_1" functions to take vector instead
7229         of linked list.
7230         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7231         "new" _1 versions of the same name.
7232         (multidictionary): Define.
7233         (std::hash<enum language): New definition.
7234         (collate_pending_symbols_by_language, mdict_create_hashed)
7235         (mdict_create_hashed_expandable, mdict_create_linear)
7236         (mdict_create_linear_expandable, mdict_free)
7237         (find_language_dictionary, create_new_language_dictionary)
7238         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7239         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7240         (mdict_size, mdict_empty): New functions.
7241         * dictionary.h (mdict_iterator): Define.
7242
7243 2019-01-10  Pedro Alves  <palves@redhat.com>
7244
7245         * breakpoint.c (read_uploaded_action)
7246         (create_tracepoint_from_upload): Adjust to use
7247         gdb::unique_xmalloc_ptr.
7248         * ctf.c (ctf_write_uploaded_tp):
7249         (SET_ARRAY_FIELD): Use emplace_back.
7250         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7251         * tracefile-tfile.c (tfile_write_uploaded_tp):
7252         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7253         gdb::unique_xmalloc_ptr.
7254         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7255         at_string, cond_string, cmd_strings>: Replace char pointers
7256         with gdb::unique_xmalloc_ptr.
7257
7258 2019-01-10  Pedro Alves  <palves@redhat.com>
7259
7260         * solib-target.c (library_list_start_library): Don't xstrdup name.
7261
7262 2019-01-10  Pedro Alves  <palves@redhat.com>
7263
7264         * mdebugread.c (parse_partial_symbols): Use
7265         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7266
7267 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7268
7269         * linux-fork.c (scoped_switch_fork_info)
7270         <~scoped_switch_fork_info>: Fix incorrect variable name.
7271
7272 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7273
7274         * linux-fork.c (scoped_switch_fork_info)
7275         <scoped_switch_fork_info>: Make explicit.
7276         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7277
7278 2019-01-10  Tom Tromey  <tom@tromey.com>
7279
7280         * objfiles.h (objfile::reset_psymtabs): Update.
7281         * objfiles.c (objfile::objfile): Update.
7282         * psymtab.h (psymtab_storage::obstack): Update.
7283         (psymtab_storage::m_obstack): Use gdb::optional.
7284         (class psymtab_storage): Update comment.  Remove objfile
7285         parameter.
7286         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7287
7288 2019-01-10  Tom Tromey  <tom@tromey.com>
7289
7290         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7291         <free_psymtabs>: Now private.
7292         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7293         (allocate_psymtab): Use new method.
7294
7295 2019-01-10  Tom Tromey  <tom@tromey.com>
7296
7297         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7298         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7299         * mdebugread.c (parse_partial_symbols): Use
7300         allocate_dependencies.
7301         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7302         allocate_dependencies.
7303         (process_psymtab_comp_unit_reader)
7304         (build_type_psymtab_dependencies): Likewise.
7305         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7306
7307 2019-01-10  Tom Tromey  <tom@tromey.com>
7308
7309         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7310         PSYMBOL_SET_LANGUAGE.
7311         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7312
7313 2019-01-10  Tom Tromey  <tom@tromey.com>
7314
7315         * psymtab.h (psymtab_storage::obstack): New method.
7316         <m_obstack>: Rename from obstack; now private.
7317         * psymtab.c (psymtab_storage): Update.
7318         * dwarf2read.c (create_addrmap_from_index)
7319         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7320         Update.
7321
7322 2019-01-10  Tom Tromey  <tom@tromey.com>
7323
7324         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7325         * objfiles.h (objfile::reset_psymtabs): New method.
7326
7327 2019-01-10  Tom Tromey  <tom@tromey.com>
7328
7329         * symmisc.c (print_symbol_bcache_statistics): Update.
7330         (print_objfile_statistics): Update.
7331         * symfile.c (reread_symbols): Update.
7332         * psymtab.h (class psymtab_storage): New.
7333         * psymtab.c (psymtab_storage): New constructor.
7334         (~psymtab_storage): New destructor.
7335         (require_partial_symbols): Update.
7336         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7337         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7338         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7339         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7340         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7341         (start_psymtab_common, end_psymtab_common)
7342         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7343         (allocate_psymtab): Update.
7344         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7345         Update.
7346         (dump_psymtab_addrmap, maintenance_print_psymbols)
7347         (maintenance_check_psymtabs): Update.
7348         (class objfile_psymtabs): Move to objfiles.h.
7349         * psympriv.h (discard_psymtab): Now inline.
7350         (psymtab_discarder::psymtab_discarder): Update.
7351         (psymtab_discarder::~psymtab_discarder): Update.
7352         (ALL_OBJFILE_PSYMTABS): Rewrite.
7353         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7354         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7355         Remove fields.
7356         <partial_symtabs>: New field.
7357         (class objfile_psymtabs): Move from psymtab.h.  Update.
7358         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7359         psymbol_cache.
7360         (objfile::~objfile): Don't destroy psymbol_cache.
7361         * mdebugread.c (parse_partial_symbols): Update.
7362         * dwarf2read.c (create_addrmap_from_index)
7363         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7364         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7365         (add_partial_subprogram, dwarf2_ranges_read): Update.
7366         * dwarf-index-write.c (write_address_map)
7367         (write_one_signatured_type, recursively_write_psymbols)
7368         (class debug_names, class debug_names, write_psymtabs_to_index):
7369         Update.
7370
7371 2019-01-10  Tom Tromey  <tom@tromey.com>
7372
7373         * symtab.h (SYMBOL_SET_NAMES): Update.
7374         (symbol_set_names): Update.
7375         (MSYMBOL_SET_NAMES): Update.
7376         * symtab.c (symbol_set_names): Change argument to be an
7377         objfile_per_bfd_storage.
7378         * psymtab.c (add_psymbol_to_bcache): Update.
7379         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7380
7381 2019-01-10  Tom Tromey  <tom@tromey.com>
7382
7383         * symtab.c (create_demangled_names_hash): Change argument to be an
7384         objfile_per_bfd_storage.
7385         (symbol_set_names): Update.
7386
7387 2019-01-10  Tom Tromey  <tom@tromey.com>
7388
7389         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7390         init_psymbol_list.
7391         * psymtab.c (init_psymbol_list): Do nothing if already called.
7392         * psympriv.h (init_psymbol_list): Add comment.
7393         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7394         init_psymbol_list.
7395         * dbxread.c (dbx_symfile_read): Unconditionally call
7396         init_psymbol_list.
7397
7398 2019-01-10  Tom Tromey  <tom@tromey.com>
7399
7400         * xcoffread.c (scan_xcoff_symtab): Update.
7401         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7402         "where".
7403         * mdebugread.c (parse_partial_symbols)
7404         (handle_psymbol_enumerators): Update.
7405         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7406         * dbxread.c (read_dbx_symtab): Update.
7407         * psympriv.h (psymbol_placement): New enum.
7408         (add_psymbol_to_list): Update.
7409
7410 2019-01-10  Tom Tromey  <tom@tromey.com>
7411
7412         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7413         static_psymbols parameters.
7414         (scan_xcoff_symtab): Update.
7415         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7416         static_psymbols parameters.
7417         * psympriv.h (start_psymtab_common): Update.
7418         * mdebugread.c (parse_partial_symbols): Update.
7419         * dwarf2read.c (create_partial_symtab): Update.
7420         * dbxread.c (read_dbx_symtab): Update.
7421         (start_psymtab): Remove global_psymbols and static_psymbols
7422         parameters.
7423
7424 2019-01-10  Tom Tromey  <tom@tromey.com>
7425
7426         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7427         * psymtab.c (allocate_psymtab): Add comment.
7428         * psympriv.h (allocate_psymtab): Add comment.
7429         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7430         initializations.
7431         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7432
7433 2019-01-10  Tom Tromey  <tom@tromey.com>
7434
7435         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7436         Don't declare.
7437         * mipsread.c: Include mdebugread.h.
7438         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7439         Declare.
7440         * elfread.c: Include mdebugread.h.
7441
7442 2019-01-09  Tom Tromey  <tom@tromey.com>
7443
7444         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7445         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7446         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7447         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7448         (psym_lookup_symbol, psym_find_last_source_symtab)
7449         (psym_forget_cached_source_info, psym_print_stats)
7450         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7451         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7452         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7453         (psym_find_compunit_symtab_by_address)
7454         (maintenance_print_psymbols, maintenance_info_psymtabs)
7455         (maintenance_check_psymtabs): Use ranged for.
7456         * psymtab.h (class objfile_psymtabs): New.
7457         (require_partial_symbols): Return objfile_psymtabs.
7458         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7459
7460 2019-01-09  Tom Tromey  <tom@tromey.com>
7461
7462         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7463         (find_pc_mapped_section, list_overlays_command)
7464         (map_overlay_command, unmap_overlay_command)
7465         (simple_overlay_update): Use all_objfiles.
7466         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7467         * printcmd.c (info_symbol_command): Use all_objfiles.
7468         * objfiles.h (ALL_OBJSECTIONS): Remove.
7469         * maint.c (maintenance_translate_address): Use all_objfiles.
7470         * gcore.c (gcore_create_callback): Use all_objfiles.
7471         (objfile_find_memory_regions): Likewise.
7472
7473 2019-01-09  Tom Tromey  <tom@tromey.com>
7474
7475         * symtab.c (find_line_symtab, info_sources_command)
7476         (make_source_files_completion_list): Use objfile_compunits.
7477         * source.c (select_source_symtab): Use objfile_compunits.
7478         * objfiles.h (struct objfile): Update comment.
7479         (ALL_OBJFILES): Remove.
7480         (ALL_FILETABS): Remove.
7481         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7482         objfile_compunits.
7483
7484 2019-01-09  Tom Tromey  <tom@tromey.com>
7485
7486         * symmisc.c (print_objfile_statistics, dump_objfile)
7487         (maintenance_print_symbols): Use compunit_filetabs.
7488         * source.c (forget_cached_source_info_for_objfile): Use
7489         compunit_filetabs.
7490         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7491         (ALL_FILETABS): Use compunit_filetabs.
7492         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7493         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7494
7495 2019-01-09  Tom Tromey  <tom@tromey.com>
7496
7497         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7498         (compunit_filetabs): New.
7499         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7500         compunit_filetabs.
7501         (info_sources_command, make_source_files_completion_list): Remove
7502         declaration.
7503         * symmisc.c (print_objfile_statistics, dump_objfile)
7504         (maintenance_print_symbols): Remove declaration.
7505         (maintenance_info_symtabs): Use compunit_filetabs.
7506         (maintenance_info_line_tables): Likewise.
7507         * source.c (select_source_symtab): Change local variable name.
7508         (forget_cached_source_info_for_objfile): Remove declaration.
7509         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7510         * objfiles.c (objfile_relocate1): Remove declaration.
7511         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7512         declaration.
7513         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7514         * coffread.c (coff_symtab_read): Remove declaration.
7515         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7516         compunit_filetabs.
7517
7518 2019-01-09  Tom Tromey  <tom@tromey.com>
7519
7520         * symtab.c (lookup_objfile_from_block)
7521         (find_pc_sect_compunit_symtab, search_symbols)
7522         (default_collect_symbol_completion_matches_break_on): Use
7523         objfile_compunits.
7524         * objfiles.h (ALL_COMPUNITS): Remove.
7525         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7526         * cp-support.c (add_symbol_overload_list_qualified): Use
7527         objfile_compunits.
7528         * ada-lang.c (ada_collect_symbol_completion_matches)
7529         (ada_add_global_exceptions): Use objfile_compunits.
7530
7531 2019-01-09  Tom Tromey  <tom@tromey.com>
7532
7533         * source.c (select_source_symtab)
7534         (forget_cached_source_info_for_objfile): Remove declaration.
7535         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7536         declaration.
7537         * maint.c (count_symtabs_and_blocks): Remove declaration.
7538         * cp-support.c (add_symbol_overload_list_qualified): Remove
7539         declaration.
7540         * coffread.c (coff_symtab_read): Remove declaration.
7541         * symtab.c (lookup_symbol_in_objfile_symtabs)
7542         (basic_lookup_transparent_type_1): Use objfile_compunits.
7543         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7544         (info_sources_command, search_symbols)
7545         (default_collect_symbol_completion_matches_break_on)
7546         (make_source_files_completion_list): Remove declaration.
7547         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7548         (ada_collect_symbol_completion_matches)
7549         (ada_add_global_exceptions): Remove declaration.
7550         * linespec.c (iterate_over_all_matching_symtabs): Use
7551         objfile_compunits.
7552         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7553         (class objfile_compunits): New.
7554         (ALL_COMPUNITS): Use objfile_compunits.
7555         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7556         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7557         objfile_compunits.
7558         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7559
7560 2019-01-09  Tom Tromey  <tom@tromey.com>
7561
7562         * symtab.c (search_symbols)
7563         (default_collect_symbol_completion_matches_break_on): Use
7564         objfile_msymbols.
7565         * ada-lang.c (ada_lookup_simple_minsym)
7566         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7567         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7568         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7569         objfile_msymbols.
7570         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7571         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7572         * objc-lang.c (find_methods): Use objfile_msymbols.
7573         (info_selectors_command, info_classes_command): Likewise.
7574         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7575         * objfiles.h (class objfile_msymbols): New.
7576         (ALL_OBJFILE_MSYMBOLS): Remove.
7577         (ALL_MSYMBOLS): Remove.
7578
7579 2019-01-09  Tom Tromey  <tom@tromey.com>
7580
7581         * common/next-iterator.h (next_adapter): Add Iterator template
7582         parameter.
7583         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7584         (class all_objfiles_safe): New.
7585         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7586         * objfiles.c (put_objfile_before): Update comment.
7587         (add_separate_debug_objfile): Likewise.
7588         (free_all_objfiles): Use all_objfiles_safe.
7589         (objfile_purge_solibs): Likewise.
7590
7591 2019-01-09  Tom Tromey  <tom@tromey.com>
7592
7593         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7594         (expand_symtab_containing_pc, lookup_static_symbol)
7595         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7596         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7597         all_objfiles.
7598         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7599         * breakpoint.c (create_overlay_event_breakpoint)
7600         (create_longjmp_master_breakpoint)
7601         (create_std_terminate_master_breakpoint)
7602         (create_exception_master_breakpoint): Use all_objfiles.
7603         * linux-thread-db.c (try_thread_db_load_from_pdir)
7604         (has_libpthread): Use all_objfiles.
7605         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7606         * linespec.c (iterate_over_all_matching_symtabs)
7607         (search_minsyms_for_name): Use all_objfiles.
7608         * maint.c (maintenance_info_sections): Use all_objfiles.
7609         * main.c (captured_main_1): Use all_objfiles.
7610         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7611         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7612         * guile/scm-pretty-print.c
7613         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7614         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7615         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7616         (maintenance_print_msymbols): Use all_objfiles.
7617         * source.c (select_source_symtab): Use all_objfiles.
7618         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7619         * symfile.c (remove_symbol_file_command)
7620         (expand_symtabs_matching, map_symbol_filenames): Use
7621         all_objfiles.
7622         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7623         all_objfiles.
7624         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7625         * objc-lang.c (find_methods): Use all_objfiles.
7626         * objfiles.c (have_partial_symbols, have_full_symbols)
7627         (have_minimal_symbols, qsort_cmp)
7628         (default_iterate_over_objfiles_in_search_order): Use
7629         all_objfiles.
7630         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7631         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7632         (maintenance_check_psymtabs): Use all_objfiles.
7633         (ALL_PSYMTABS): Remove.
7634         * compile/compile-object-run.c (do_module_cleanup): Use
7635         all_objfiles.
7636         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7637         * cp-support.c (add_symbol_overload_list_qualified): Use
7638         all_objfiles.
7639         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7640         Use all_objfiles.
7641         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7642         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7643         all_objfiles.
7644         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7645         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7646         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7647         Uses all_objfiles.
7648         * solib.c (solib_read_symbols): Use all_objfiles
7649
7650 2019-01-09  Tom Tromey  <tom@tromey.com>
7651
7652         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7653         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7654         all_objfiles.
7655         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7656         * symmisc.c (print_symbol_bcache_statistics)
7657         (print_objfile_statistics, maintenance_print_objfiles)
7658         (maintenance_info_symtabs, maintenance_check_symtabs)
7659         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7660         all_objfiles.
7661         * source.c (forget_cached_source_info): Use all_objfiles.
7662         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7663         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7664         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7665         * objfiles.c (update_section_map): Use all_objfiles.
7666         (shared_objfile_contains_address_p): Likewise.
7667         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7668         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7669
7670 2019-01-09  Tom Tromey  <tom@tromey.com>
7671
7672         * common/next-iterator.h: New file.
7673         * objfiles.h (class all_objfiles): New.
7674         (struct objfile_iterator): New.
7675
7676 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7677
7678         * NEWS: Move the description of the changed "frame", "select-frame",
7679          and "info frame" commands to the Changed commands section.
7680
7681 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7682
7683         * gdbtypes.c (check_stub_method_group): Remove handling of old
7684         mangling schemes.
7685         * linespec.c (find_methods): Likewise.
7686         * stabsread.c (read_member_functions): Likewise.
7687         * valops.c (search_struct_method): Likewise.
7688         (value_struct_elt_for_reference): Likewise.
7689         * NEWS: Mention this change.
7690
7691 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7692
7693         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7694         print_source_lines.
7695         * source.c (print_source_lines_base): Update line number check.
7696         (print_source_lines): New function.
7697         (source_lines_range::source_lines_range): New function.
7698         * source.h (class source_lines_range): New class.
7699         (print_source_lines): New declaration.
7700
7701 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7702
7703         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7704
7705 2019-01-08  Tom Tromey  <tom@tromey.com>
7706             Simon Marchi  <simon.marchi@ericsson.com>
7707
7708         PR gdb/24060
7709         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7710         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7711         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7712         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7713         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7714         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7715
7716 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7717
7718         * source.c (select_source_symtab): Move header comment to
7719         declaration in source.h.
7720         (forget_cached_source_info_for_objfile): Likewise.
7721         (forget_cached_source_info): Likewise.
7722         (identify_source_line): Likewise.
7723         * source.h (identify_source_line): Move declaration from symtab.h
7724         and add comment from source.c
7725         (print_source_lines): Likewise.
7726         (forget_cached_source_info_for_objfile): Likewise.
7727         (forget_cached_source_info): Likewise.
7728         (select_source_symtab): Likewise.
7729         (enum print_source_lines_flag): Move definition from symtab.h.
7730         * symtab.h (identify_source_line): Move declaration to source.h.
7731         (print_source_lines): Likewise.
7732         (forget_cached_source_info_for_objfile): Likewise.
7733         (forget_cached_source_info): Likewise.
7734         (select_source_symtab): Likewise.
7735         (enum print_source_lines_flag): Move definition to source.h.
7736         * tui/tui-hooks.c: Add 'source.h' include.
7737
7738 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7739
7740         * source.c (print_source_lines_base): Handle requests to print
7741         reverse line number sequences, and guard against empty lines
7742         string.
7743
7744 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7745
7746         * source.c (print_source_lines_base): Fix skip of '\r' if next
7747         character is '\n'.
7748
7749 2019-01-06  Tom Tromey  <tom@tromey.com>
7750
7751         * c-exp.y (struct c_parse_state) <macro_original_text,
7752         expansion_obstack>: New member.
7753         (macro_original_text, expansion_obstack): Remove globals.
7754         (scan_macro_expansion, scanning_macro_expansion)
7755         (finished_macro_expansion): Update.
7756         (scan_macro_cleanup): Remove.
7757         (yylex, c_parse): Update.
7758
7759 2019-01-06  Tom Tromey  <tom@tromey.com>
7760
7761         * c-exp.y (struct c_parse_state) <strings>: New member.
7762         (operator_stoken): Update.
7763
7764 2019-01-06  Tom Tromey  <tom@tromey.com>
7765
7766         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7767         (union type_stack_elt) <typelist_val>: Now a pointer to
7768         std::vector.
7769         (type_stack_cleanup): Don't declare.
7770         (push_typelist): Update.
7771         * parse.c (pop_typelist): Return a std::vector.
7772         (push_typelist): Take a std::vector.
7773         (follow_types): Update.  Do not free args.
7774         (type_stack_cleanup): Remove.
7775         * c-exp.y (struct c_parse_state): New.
7776         (cpstate): New global.
7777         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7778         (nonempty_typelist): Update.
7779         (func_mod): Create a new vector.
7780         (c_parse): Create a c_parse_state.
7781         (check_parameter_typelist): Do not delete params.
7782         (function_method): Update.  Do not delete type_list.
7783
7784 2019-01-06  Tom Tromey  <tom@tromey.com>
7785
7786         PR gdb/28155:
7787         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7788         check_typedef.
7789         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7790         (print_return_value): Likewise.
7791
7792 2019-01-05  Tom Tromey  <tom@tromey.com>
7793
7794         * contrib/cleanup_check.py: Remove.
7795         * contrib/gcc-with-excheck: Remove.
7796         * contrib/exsummary.py: Remove.
7797         * contrib/excheck.py: Remove.
7798
7799 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7800
7801         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7802         NULL. Initialize tpprev to NULL instead of assigning it
7803         to NULL on the next statement.
7804         * windows-nat.c (windows_delete_thread): Remove check for
7805         main_thread_id before printing thread exit notifications.
7806         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7807         Remove thread ID check against main_thread_id.
7808         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7809         windows_delete_thread.
7810         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7811
7812 2019-01-04  Tom Tromey  <tom@tromey.com>
7813
7814         * compile/compile.c (_initialize_compile): Use upper case for
7815         metasyntactic variables.
7816         * symmisc.c (_initialize_symmisc): Use upper case for
7817         metasyntactic variables.
7818         * psymtab.c (_initialize_psymtab): Use upper case for
7819         metasyntactic variables.
7820         * demangle.c (demangle_command): Use upper case for metasyntactic
7821         variables.
7822         (_initialize_demangler): Likewise.
7823         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7824         variables.
7825
7826 2019-01-03  Tom Tromey  <tom@tromey.com>
7827
7828         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7829
7830 2019-01-03  Tom Tromey  <tom@tromey.com>
7831
7832         * python/py-symtab.c (salpy_str): Update.
7833         (struct salpy_sal_object) <symtab>: Now a PyObject.
7834         (salpy_dealloc): Update.
7835         (del_objfile_sal): Use gdbpy_ref.
7836
7837 2019-01-03  Tom Tromey  <tom@tromey.com>
7838
7839         * python/py-type.c (convert_field): Use new_reference.  Return
7840         gdbpy_ref.
7841         (make_fielditem): Return gdbpy_ref.
7842         (typy_fields): Update.
7843         (typy_getitem): Update.
7844         (field_name): Return gdbpy_ref.  Use new_reference.
7845         (typy_iterator_iternext): Update.
7846
7847 2019-01-03  Tom Tromey  <tom@tromey.com>
7848
7849         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7850
7851 2019-01-03  Tom Tromey  <tom@tromey.com>
7852
7853         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7854         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7855         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7856         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7857         (pspy_set_type_printers): Likewise.
7858         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7859         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7860         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7861         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7862         (objfpy_set_type_printers): Likewise.
7863
7864 2019-01-03  Tom Tromey  <tom@tromey.com>
7865
7866         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7867         (gdbpy_print_stack): Use gdbpy_err_fetch.
7868         * python/python-internal.h (class gdbpy_err_fetch): New class.
7869         (class gdbpy_enter) <m_error_type, m_error_value,
7870         m_error_traceback>: Remove.
7871         <m_error>: New member.
7872         (gdbpy_exception_to_string): Don't declare.
7873         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7874         * python/py-value.c (convert_value_from_python): Use
7875         gdbpy_err_fetch.
7876         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7877         gdbpy_exception_to_string.
7878         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7879         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7880         gdbpy_err_fetch.
7881
7882 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7883
7884         * linux-nat.c (delete_lwp_cleanup): Delete.
7885         (struct lwp_deleter): New struct.
7886         (lwp_info_up): New typedef.
7887         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7888         lwp_info_up.
7889
7890 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7891
7892         * linux-fork.c (class scoped_switch_fork_info): New class.
7893         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7894
7895 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7896
7897         * valops.c (find_overload_match): Remove use of null_cleanup, and
7898         calls to do_cleanups.
7899
7900 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7901
7902         * compile/compile-cplus-types.c
7903         (compile_cplus_instance::decl_name): Handle changes to
7904         cp_func_name.
7905         * cp-support.c (cp_func_name): Update header comment, update
7906         return type.
7907         * cp-support.h (cp_func_name): Update return type in declaration.
7908         * valops.c (find_overload_match): Move temp_func local to top
7909         level of function and change its type.  Use temp_func to hold and
7910         delete temporary string obtained from cp_func_name.
7911
7912 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7913
7914         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7915         gdb::char_vector, remove cleanup, and update uses of `msg`.
7916
7917 2019-01-03  Jim Wilson  <jimw@sifive.com>
7918
7919         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7920
7921 2019-01-02  Tom Tromey  <tom@tromey.com>
7922
7923         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7924         (tdesc_parse_xml): Remove cleanups.
7925         * target-descriptions.h (make_cleanup_free_target_description):
7926         Don't declare.
7927         (target_desc_deleter): New struct.
7928         (target_desc_up): New typedef.
7929         * target-descriptions.c (target_desc_deleter::operator()): Rename
7930         from free_target_description.
7931         (make_cleanup_free_target_description): Remove.
7932
7933 2019-01-02  Tom Tromey  <tom@tromey.com>
7934
7935         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7936         constructor, destructor.
7937         (linespec_parser): Remove typedef.
7938         (~linespec_parser): Rename from linespec_parser_delete.
7939         (linespec_lex_to_end, linespec_complete_label)
7940         (linespec_complete): Update.
7941         (decode_line_full): Remove cleanups.
7942         (decode_line_1): Update.
7943
7944 2019-01-02  Tom Tromey  <tom@tromey.com>
7945
7946         * python/python-internal.h (inferior_to_inferior_object): Change
7947         return type.
7948         * python/py-exitedevent.c (create_exited_event_object): Update.
7949         * python/py-inferior.c (inferior_to_inferior_object): Return
7950         gdbpy_ref.
7951         (python_new_inferior, python_inferior_deleted)
7952         (thread_to_thread_object, delete_thread_object)
7953         (build_inferior_list, gdbpy_selected_inferior): Update.
7954         * python/py-infthread.c (create_thread_object): Update.  Also fail
7955         if inferior_to_inferior_object fails.
7956
7957 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7958
7959         * inferior.h (class inferior) <displaced_step_state>: New field.
7960         * infrun.h (struct displaced_step_state): Move here from
7961         infrun.c.  Initialize fields, add constructor.
7962         <inf>: Remove field.
7963         <reset>: New method.
7964         * infrun.c (struct displaced_step_inferior_state): Move to
7965         infrun.h.
7966         (displaced_step_inferior_states): Remove.
7967         (get_displaced_stepping_state): Adust.
7968         (displaced_step_in_progress_any_inferior): Adjust.
7969         (displaced_step_in_progress_thread): Adjust.
7970         (displaced_step_in_progress): Adjust.
7971         (add_displaced_stepping_state): Remove.
7972         (get_displaced_step_closure_by_addr): Adjust.
7973         (remove_displaced_stepping_state): Remove.
7974         (infrun_inferior_exit): Call displaced_step_state.reset.
7975         (use_displaced_stepping): Don't check for NULL.
7976         (displaced_step_prepare_throw): Call
7977         get_displaced_stepping_state.
7978         (displaced_step_fixup): Don't check for NULL.
7979         (prepare_for_detach): Don't check for NULL.
7980
7981 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7982
7983         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7984          in case of call that did not complete.
7985
7986 2019-01-02  Andrey Utkin  <autkin@undo.io>
7987
7988         * symfile.c (find_separate_debug_file): Fix search of debug files for
7989         remote debuggee.
7990
7991 2019-01-02  Tom Tromey  <tom@tromey.com>
7992
7993         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7994         indentation.
7995         * python/py-frame.c (frapy_older): Remove cast.
7996         (frapy_newer): Likewise.
7997         * python/py-breakpoint.c (local_setattro): Remove cast.
7998         * python/py-arch.c (archpy_name): Remove local variable.
7999         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8000
8001 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8002
8003         * unittests/basic_string_view/element_access/char/empty.cc:
8004         Fix year range in copyright header.
8005
8006 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8007
8008         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8009         Delete.
8010         <operator==>: Update with for removed field.
8011         <hash>: Likewise.
8012         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8013         <isa_features>: ...this.
8014         <abi_features>: New field.
8015         (riscv_isa_flen): Update comment.
8016         (riscv_abi_xlen): New declaration.
8017         (riscv_abi_flen): New declaration.
8018         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8019         isa_features.
8020         (riscv_abi_xlen): New function.
8021         (riscv_isa_flen): Update to get answer from isa_features.
8022         (riscv_abi_flen): New function.
8023         (riscv_has_fp_abi): Update to get answer from abi_features.
8024         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8025         xlen and flen.
8026         (riscv_call_info) <xlen, flen>: Update comment.
8027         (riscv_call_arg_struct): Remove invalid assertions
8028         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8029         is removed.
8030         (riscv_gdbarch_init): Gather isa features and abi features
8031         separately, ensure both match on the gdbarch when reusing an old
8032         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8033         a target with 64-bit float hardware.
8034
8035 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8036
8037         * source.c (search_command_helper): Stop reverse search
8038         when line 1 has been searched.
8039
8040 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8041
8042         * record-full.c (record_full_base_target::close): Rewrite
8043         record_full_core_buf_list free logic.
8044
8045 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8046
8047         * break-catch-syscall.c (print_one_catch_syscall): xfree
8048         the last text.
8049
8050 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8051
8052         * top.c (print_gdb_version): Update Copyright year in version
8053         message.
8054
8055 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8056
8057         Update copyright year range in all GDB files.
8058
8059 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8060
8061         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8062
8063 For older changes see ChangeLog-2018.
8064 \f
8065 Local Variables:
8066 mode: change-log
8067 left-margin: 8
8068 fill-column: 74
8069 version-control: never
8070 coding: utf-8
8071 End:
8072