gdb/ChangeLog

   1 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
   2
   3         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
   4         _WIN32_WINNT to the XP level, unless already defined to a higher
   5         level.
   6
   7         * unittests/parse-connection-spec-selftests.c:
   8         * ser-tcp.c:
   9         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
  10         override.
  11
  12         * symfile.c (find_separate_debug_file): Remove colon from the
  13         drive spec of DOS/Windows file names of the target, so that the
  14         file name produced from DEBUGDIR and the target's directory will
  15         be valid on DOS/Windows systems.
  16
  17 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * rust-lang.c (val_print_struct): Handle printing structures
  20         containing strings.
  21
  22 2019-05-02  Tom Tromey  <tromey@adacore.com>
  23
  24         * valarith.c (_initialize_valarith): Remove.
  25
  26 2019-05-01  Tom Tromey  <tromey@adacore.com>
  27
  28         * ada-lang.c (ada_value_primitive_field): Treat more fields as
  29         bitfields.
  30
  31 2019-05-01  Tom Tromey  <tromey@adacore.com>
  32
  33         * ada-lang.c (ada_value_assign): Correctly compute starting offset
  34         for big-endian copies.
  35
  36 2019-04-30  Ali Tamur  <tamur@google.com>
  37         * gdb/dwarf2read.c (read_3_bytes): New declaration.
  38         (read_attribute_value): Added DW_FORM_strx1-4 cases.
  39         (read_3_bytes): New function.
  40
  41 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  42
  43         * windows-nat.c (main_thread_id): Delete.
  44         (handle_output_debug_string): Replace main_thread_id by
  45         current_event.dwThreadId.
  46         (fake_create_process): Likewise.
  47         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  48         Do not set main_thread_id.
  49         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  50         current_event.dwThreadId.
  51         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  52
  53 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  54
  55         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  56         Use current_event.dwThreadId instead of main_thread_id.
  57
  58 2019-04-30  Tom Tromey  <tromey@adacore.com>
  59
  60         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  61         (create_excep_cond_exprs): Iterate over program spaces.
  62         (ada_exception_catchpoint_cond_string): Examine all minimal
  63         symbols for exception types.
  64
  65 2019-04-30  Tom Tromey  <tromey@adacore.com>
  66
  67         PR c++/24470:
  68         * dwarf2read.c (process_structure_scope): Handle case where type
  69         has template parameters but no symbol was created.
  70
  71 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  72             Chris January  <chris.january@arm.com>
  73
  74         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  75         qualifier.
  76         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  77
  78 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  79
  80         * f-typeprint.c (f_print_type): Update rules for printing
  81         whitespace.
  82         (f_type_print_varspec_suffix): Likewise.
  83
  84 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  85             Chris January  <chris.january@arm.com>
  86
  87         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  88         function arguments.
  89
  90 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  91
  92         * f-lang.c (build_fortran_types): Change name of void type to
  93         lower case.
  94         * f-typeprint.c (f_type_print_base): Print the name of the void
  95         type, rather than a fixed string.
  96         * f-valprint.c (f_decorations): Use lower case void string.
  97
  98 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  99             Chris January  <chris.january@arm.com>
 100
 101         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 102         types for Fortran.
 103
 104 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 105             Chris January  <chris.january@arm.com>
 106             David Lecomber  <david.lecomber@arm.com>
 107
 108         * f-exp.y (BINOP_INTRINSIC): New token.
 109         (exp): New parser rule handling BINOP_INTRINSIC.
 110         (f77_keywords): Add new builtin procedures.
 111         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 112         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 113         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 114         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 115         (print_unop_subexp_f): New function.
 116         (print_binop_subexp_f): New function.
 117         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 118         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 119         (dump_subexp_body_f): Likewise.
 120         (operator_check_f): Likewise.
 121         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 122         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 123
 124 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 125
 126         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 127         UNOP_KIND.
 128         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 129         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 130         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 131         (operator_length_f): New fuction.
 132         (print_subexp_f): New function.
 133         (op_name_f): New function.
 134         (dump_subexp_body_f): New function.
 135         (operator_check_f): New function.
 136         (exp_descriptor_f): Replace standard expression handling functions
 137         with new functions.
 138         * gdb/fortran-operator.def: New file.
 139         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 140         * gdb/std-operator.def: Remove UNOP_KIND.
 141
 142 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 143
 144         * std-operator.def: Remove unbalanced, stray double quote
 145         character.
 146
 147 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 148             Chris January  <chris.january@arm.com>
 149             Daniel Everett  <daniel.everett@arm.com>
 150             Nick Forrington  <nick.forrington@arm.com>
 151             Richard Bunt  <richard.bunt@arm.com>
 152
 153         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 154         of depth when printing anonymous structs or unions.
 155         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 156         Don't print either the top-level value, or the children if the
 157         max-depth is exceeded.
 158         (ppscm_print_children): When printing the key of a map, allow one
 159         extra level of depth.
 160         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 161         print either the top-level value, or the children if the max-depth
 162         is exceeded.
 163         (print_children): When printing the key of a map, allow one extra
 164         level of depth.
 165         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 166         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 167         (user_print_options): Initialise max_depth field.
 168         (val_print_scalar_or_string_type_p): New function.
 169         (val_print): Check to see if the max depth has been reached.
 170         (val_print_check_max_depth): Define new function.
 171         (show_print_max_depth): New function.
 172         (_initialize_valprint): Add 'print max-depth' option.
 173         * valprint.h (struct value_print_options) <max_depth>: New field.
 174         (val_print_check_max_depth): Declare new function.
 175         * NEWS: Document new feature.
 176
 177 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 178
 179         * ada-lang.c (ada_language_defn): Initialise new field.
 180         * c-lang.c (c_is_string_type_p): New function.
 181         (c_language_defn): Initialise new field.
 182         (cplus_language_defn): Initialise new field.
 183         (asm_language_defn): Initialise new field.
 184         (minimal_language_defn): Initialise new field.
 185         * c-lang.h (c_is_string_type_p): Declare new function.
 186         * d-lang.c (d_language_defn): Initialise new field.
 187         * f-lang.c (f_is_string_type_p): New function.
 188         (f_language_defn): Initialise new field.
 189         * go-lang.c (go_is_string_type_p): New function.
 190         (go_language_defn): Initialise new field.
 191         * language.c (default_is_string_type_p): New function.
 192         (unknown_language_defn): Initialise new field.
 193         (auto_language_defn): Initialise new field.
 194         * language.h (struct language_defn) <la_is_string_type_p>: New
 195         member variable.
 196         (default_is_string_type_p): Declare new function.
 197         * m2-lang.c (m2_language_defn): Initialise new field.
 198         * objc-lang.c (objc_language_defn): Initialise new field.
 199         * opencl-lang.c (opencl_language_defn): Initialise new field.
 200         * p-lang.c (pascal_is_string_type_p): New function.
 201         (pascal_language_defn): Initialise new field.
 202         * rust-lang.c (rust_is_string_type_p): New function.
 203         (rust_language_defn): Initialise new field.
 204
 205 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 206
 207         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 208         New field.
 209         * ada-lang.c (ada_language_defn): Initialise new field.
 210         * c-lang.c (c_language_defn): Likewise.
 211         (cplus_language_defn): Likewise.
 212         (asm_language_defn): Likewise.
 213         (minimal_language_defn): Likewise.
 214         * d-lang.c (d_language_defn): Likewise.
 215         * f-lang.c (f_language_defn): Likewise.
 216         * go-lang.c (go_language_defn): Likewise.
 217         * language.c (unknown_language_defn): Likewise.
 218         (auto_language_defn): Likewise.
 219         * m2-lang.c (m2_language_defn): Likewise.
 220         * objc-lang.c (objc_language_defn): Likewise.
 221         * opencl-lang.c (opencl_language_defn): Likewise.
 222         * p-lang.c (pascal_language_defn): Likewise.
 223         * rust-lang.c (rust_language_defn): Likewise.
 224
 225 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * ada-lang.c (ada_is_character_type): Change return type to bool.
 228         (ada_is_string_type): Likewise.
 229         * ada-lang.h (ada_is_character_type): Update declaration
 230         (ada_is_string_type): Likewise.
 231
 232 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 233
 234         Support style in 'frame|thread apply'
 235
 236         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 237         * record.c (record_start, record_stop): Update callers of
 238         execute_command_to_string with false.
 239         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 240         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 241         methods.
 242         (class string_file): New constructor with term_out parameter.
 243         Override methods term_out and can_emit_style_escape.  New member
 244         term_out.
 245         (class stdio_file): Override can_emit_style_escape.
 246         (class tee_file): Override term_out and can_emit_style_escape.
 247         * utils.h (can_emit_style_escape): Remove.
 248         * utils.c (can_emit_style_escape): Likewise.
 249         Update all callers of can_emit_style_escape (SOMESTREAM) to
 250         SOMESTREAM->can_emit_style_escape.
 251         * source-cache.c (source_cache::get_source_lines): Likewise.
 252         * stack.c (frame_apply_command_count): Call execute_command_to_string
 253         passing the term_out characteristic of the current gdb_stdout.
 254         * thread.c (thr_try_catch_cmd): Likewise.
 255         * top.c (execute_command_to_string): pass term_out parameter
 256         to construct the string_file for the command output.
 257         * ui-file.c (term_cli_styling): New function (most code moved
 258         from utils.c can_emit_style_escape).
 259         (string_file::string_file, string_file::can_emit_style_escape,
 260         stdio_file::can_emit_style_escape, tee_file::term_out,
 261         tee_file::can_emit_style_escape): New functions.
 262
 263 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 264
 265         * NEWS: Mention the new set|show may-call-functions.
 266         * infcall.c (may_call_functions_p): New variable.
 267         (show_may_call_functions_p): New function.
 268         (call_function_by_hand_dummy): Throws an error if not
 269         may-call-functions.
 270         (_initialize_infcall): Call add_setshow_boolean_cmd for
 271         may-call-functions.
 272
 273 2019-04-25  Keith Seitz  <keiths@redhat.com>
 274
 275         PR c++/24367
 276         * cp-support.c (inspect_type): Don't attempt substitutions
 277         of symbol with the same name.
 278
 279 2019-04-25  Tom Tromey  <tromey@adacore.com>
 280
 281         PR gdb/24475:
 282         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 283         static.
 284
 285 2019-04-25  Tom Tromey  <tromey@adacore.com>
 286
 287         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 288         rvalue reference.
 289         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 290         (gdb_xml_parser::parse): Use std::move.
 291         * python/python-internal.h (gdbpy_convert_exception): Take a const
 292         reference.
 293         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 294         std::move.
 295         * python/py-utils.c (gdbpy_convert_exception): Take a const
 296         reference.
 297         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 298         Use std::move.
 299         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 300         Use std::move.
 301         * mi/mi-main.c (mi_print_exception): Take a const reference.
 302         * main.c (handle_command_errors): Take a const reference.
 303         * linespec.c (parse_linespec): Use std::move.
 304         * infcall.c (run_inferior_call): Use std::move.
 305         (call_function_by_hand_dummy): Use std::move.
 306         * exec.c (try_open_exec_file): Use std::move.
 307         * exceptions.h (exception_print, exception_fprintf)
 308         (exception_print_same): Update.
 309         * exceptions.c (print_exception, exception_print)
 310         (exception_fprintf, exception_print_same): Change parameters to
 311         const reference.
 312         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 313         * common/new-op.c: Use std::move.
 314         * common/common-exceptions.h (struct gdb_exception): Add move
 315         constructor.
 316         (struct gdb_exception_error, struct gdb_exception_quit, struct
 317         gdb_quit_bad_alloc): Change constructor to move constructor.
 318         (throw_exception): Change parameter to rvalue reference.
 319         * common/common-exceptions.c (throw_exception): Take rvalue
 320         reference.
 321         * cli/cli-interp.c (safe_execute_command): Use std::move.
 322         * breakpoint.c (insert_bp_location, location_to_sals): Use
 323         std::move.
 324
 325 2019-04-25  Tom Tromey  <tromey@adacore.com>
 326
 327         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 328         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 329         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 330         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 331         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 332         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 333         guile/scm-value.c: Use unpack.
 334         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 335         gdbscm_gdb_exception.
 336         (gdbscm_throw_gdb_exception): Likewise.
 337         (struct gdbscm_gdb_exception): New.
 338         (unpack): New function.
 339         (gdbscm_wrap): Use unpack.
 340
 341 2019-04-25  Tom Tromey  <tromey@adacore.com>
 342
 343         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 344         (gdb_rl_callback_handler): Use std::move.
 345         * common/common-exceptions.h (struct gdb_exception): Add move
 346         assignment operator.
 347         (throw_exception_sjlj): Change "exception" to const reference.
 348         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 349         (throw_exception_sjlj): Change "exception" to const reference.
 350
 351 2019-04-25  Tom Tromey  <tromey@adacore.com>
 352
 353         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 354         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 355         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 356         Update.
 357         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 358         Update.
 359         * mi/mi-interp.c (mi_interp::exec): Update.
 360         * linespec.c (parse_linespec): Update.
 361         * infcall.c (run_inferior_call): Update.
 362         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 363         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 364         (gdbscm_lookup_global_symbol): Update.
 365         * guile/scm-param.c (gdbscm_parameter_value): Update.
 366         * guile/scm-frame.c (gdbscm_frame_read_register)
 367         (gdbscm_frame_read_var): Update.
 368         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 369         * exec.c (try_open_exec_file): Update.
 370         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 371         (gdb_rl_callback_handler): Update.
 372         * common/common-exceptions.h (exception_none): Don't declare.
 373         * common/common-exceptions.c (exception_none): Don't define.
 374         (struct catcher) <exception>: Update.
 375         * cli/cli-interp.c (safe_execute_command): Update.
 376         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 377
 378 2019-04-25  Ali Tamur  <tamur@google.com>
 379
 380         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 381         (read_attribute_value): Likewise.
 382         (dwarf2_read_addr_index): Update comment.
 383         (read_str_index): Add DW_FORM_strx.
 384         (dwarf2_string_attr): Likewise.
 385         (dwarf2_const_value_attr): Likewise.
 386         (dump_die_shallow): Likewise.
 387         (dwarf2_fetch_constant_bytes): Likewise.
 388         (skip_form_bytes): Likewise.
 389         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 390
 391 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 392
 393         PR corefiles/11608
 394         PR corefiles/18187
 395         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 396         OFFSET.  Verify if current mapping contains an ELF header.
 397         (linux_find_memory_regions_full): Adjust call to
 398         dump_mapping_p.
 399
 400 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 401             Kang Li <kanglictf@gmail.com>
 402
 403         PR gdb/21600
 404
 405         * dwarf2-frame.c (read_initial_length): Be consistent about using
 406         unsigned representation of length.
 407         (decode_frame_entry_1): Likewise.  Check for wraparound of
 408         end pointer as well as buffer overflow.
 409
 410 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 411
 412         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 413         "vq".
 414
 415 2019-04-24  Tom Tromey  <tromey@adacore.com>
 416
 417         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 418
 419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * s12z-tdep.c (s12z_unwind_pc): Delete.
 422         (s12z_unwind_sp): Delete.
 423         (s12z_gdbarch_init): Don't register deleted functions with
 424         gdbarch.
 425
 426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 427
 428         * rl78-tdep.c (rl78_unwind_sp): Delete.
 429         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 430
 431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 434         (xstormy16_unwind_pc): Delete.
 435         (xstormy16_dummy_id): Delete.
 436         (xstormy16_gdbarch_init): Don't register deleted functions with
 437         gdbarch.
 438
 439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * vax-tdep.c (vax_unwind_pc): Delete.
 442         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 443
 444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 445
 446         * v850-tdep.c (v850_unwind_sp): Delete.
 447         (v850_unwind_pc): Delete.
 448         (v850_dummy_id): Delete.
 449         (v850_gdbarch_init): Don't register deleted functions with
 450         gdbarch.
 451
 452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 453
 454         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 455         (tilegx_unwind_pc): Delete.
 456         (tilegx_unwind_dummy_id): Delete.
 457         (tilegx_gdbarch_init): Don't register deleted functions with
 458         gdbarch.
 459
 460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 461
 462         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 463         (tic6x_dummy_id): Delete.
 464         (tic6x_gdbarch_init): Don't register deleted functions with
 465         gdbarch.
 466
 467 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 468
 469         * sparc-tdep.c (sparc_unwind_pc): Delete.
 470         (sparc32_gdbarch_init): Don't register deleted function with
 471         gdbarch.
 472
 473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 474
 475         * sh-tdep.c (sh_unwind_sp): Delete.
 476         (sh_unwind_pc): Delete.
 477         (sh_dummy_id): Delete.
 478         (sh_gdbarch_init): Don't register deleted functions with
 479         gdbarch.
 480
 481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * score-tdep.c (score_unwind_sp): Delete.
 484         (score_unwind_pc): Delete.
 485         (score_dummy_id): Delete.
 486         (score_gdbarch_init): Don't register deleted functions with
 487         gdbarch.
 488
 489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 490
 491         * rx-tdep.c (rx_unwind_pc): Delete.
 492         (rx_unwind_sp): Delete.
 493         (rx_dummy_id): Delete.
 494         (rx_gdbarch_init): Don't register deleted functions with
 495         gdbarch.  Update comment.
 496
 497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 500         (rs6000_dummy_id): Delete.
 501         (rs6000_gdbarch_init): Don't register deleted functions with
 502         gdbarch.
 503
 504 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 505
 506         * or1k-tdep.c (or1k_dummy_id): Delete.
 507         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 508
 509 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * nios2-tdep.c (nios2_dummy_id): Delete.
 512         (nios2_unwind_sp): Delete.
 513         (nios2_gdbarch_init): Don't register deleted functions with
 514         gdbarch.
 515
 516 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * nds32-tdep.c (nds32_dummy_id): Delete.
 519         (nds32_unwind_pc): Delete.
 520         (nds32_unwind_sp): Delete.
 521         (nds32_gdbarch_init): Don't register deleted functions with
 522         gdbarch.
 523
 524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 525
 526         * msp430-tdep.c (msp430_unwind_pc): Delete.
 527         (msp430_unwind_sp): Delete.
 528         (msp430_dummy_id): Delete.
 529         (msp430_gdbarch_init): Don't register deleted functions with
 530         gdbarch.
 531
 532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * moxie-tdep.c (moxie_unwind_sp): Delete.
 535         (moxie_unwind_pc): Delete.
 536         (moxie_dummy_id): Delete.
 537         (moxie_gdbarch_init): Don't register deleted functions with
 538         gdbarch.
 539
 540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 541
 542         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 543         (mn10300_unwind_pc): Delete.
 544         (mn10300_unwind_sp): Delete.
 545         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 546         mn10300_unwind_sp.
 547         (mn10300_frame_unwind_init): Don't register deleted functions with
 548         gdbarch.
 549
 550 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 551
 552         * mep-tdep.c (mep_unwind_pc): Delete.
 553         (mep_unwind_sp): Delete.
 554         (mep_dummy_id): Delete.
 555         (mep_gdbarch_init): Don't register deleted functions with
 556         gdbarch.
 557
 558 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 559
 560         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 561         (m68hc11_unwind_sp): Delete.
 562         (m68hc11_gdbarch_init): Don't register deleted functions with
 563         gdbarch.
 564
 565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * m32r-tdep.c (m32r_unwind_sp): Delete.
 568         (m32r_unwind_pc): Delete.
 569         (m32r_dummy_id): Delete.
 570         (m32r_gdbarch_init): Don't register deleted functions with
 571         gdbarch.
 572
 573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 574
 575         * m32c-tdep.c (m32c_unwind_pc): Delete.
 576         (m32c_unwind_sp): Delete.
 577         (m32c_dummy_id): Delete.
 578         (m32c_gdbarch_init): Don't register deleted functions with
 579         gdbarch.
 580
 581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 584         (lm32_unwind_pc): Delete.
 585         (lm32_dummy_id): Delete.
 586         (lm32_gdbarch_init): Don't register deleted functions with
 587         gdbarch.
 588
 589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 592         (iq2000_unwind_pc): Delete.
 593         (iq2000_dummy_id): Delete.
 594         (iq2000_gdbarch_init): Don't register deleted functions with
 595         gdbarch.
 596
 597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 598
 599         * nds32-tdep.c (nds32_type_align): Delete.
 600         (nds32_push_dummy_call): Use type_align instead.
 601
 602 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 603
 604         * arm-tdep.c (arm_type_align): Only handle vector override case.
 605         (arm_push_dummy_call): Use type_align.
 606         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 607
 608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 609
 610         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 611         case.
 612         (pass_on_stack): Use type_align.
 613         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 614         function.
 615
 616 2019-04-23  Tom Tromey  <tromey@adacore.com>
 617
 618         * dwarf2read.c (line_header::file_name_at): Remove unused
 619         overload.
 620
 621 2019-04-23  Tom de Vries  <tdevries@suse.de>
 622
 623         PR gdb/24438
 624         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 625         invocation.
 626
 627
 628 2019-03-27  Ali Tamur  <tamur@google.com>
 629
 630         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 631         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 632         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 633         (dwarf_expr_context::get_addr_index): Likewise
 634         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 635         (symbol_needs_eval_context::get_addr_index): Likewise
 636         (disassemble_dwarf_expression): Add DW_OP_addrx
 637         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 638         (read_cutu_die_from_dwo): Update comment
 639         (skip_one_die): Add DW_FORM_addrx
 640         (read_attribute_value): Likewise
 641         (var_decode_location): Add DW_OP_addrx
 642         (dwarf2_const_value_attr): Add DW_FORM_addrx
 643         (dump_die_shallow): Likewise
 644         (dwarf2_fetch_constant_bytes): Likewise
 645         (decode_locdesc): Add DW_OP_addrx
 646         (skip_form_bytes): Add DW_FORM_addrx
 647
 648 2019-04-22  Ali Tamur  <tamur@google.com>
 649
 650         * MAINTAINERS (Write After Approval): Add self.
 651
 652 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 653
 654         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 655         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 656         (open_symbol_file_object): Likewise.
 657         (svr4_default_sos): Add info parameter.
 658         (svr4_read_so_list): Likewise.
 659         (svr4_current_sos_direct): Adjust functions calls to pass down
 660         info.
 661         (svr4_current_sos_1): Add info parameter.
 662         (svr4_current_sos): Call get_svr4_info, pass info down to
 663         svr4_current_sos_1.
 664         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 665         get_svr4_info.
 666         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 667         get_svr4_info.
 668         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 669         to get_svr4_info.
 670         (probes_table_remove_objfile_probes): Likewise.
 671         (register_solib_event_probe): Add info parameter.
 672         (solist_update_incremental): Pass info parameter down to
 673         svr4_read_so_list.
 674         (disable_probes_interface): Add info parameter.
 675         (svr4_handle_solib_event): Pass current_program_space to
 676         get_svr4_info.  Adjust disable_probes_interface cleanup.
 677         (svr4_create_probe_breakpoints): Add info parameter, pass it
 678         down to register_solib_event_probe.
 679         (svr4_create_solib_event_breakpoints): Add info parameter,
 680         pass it down to svr4_create_probe_breakpoints.
 681         (enable_break): Pass info down to
 682         svr4_create_solib_event_breakpoints.
 683         (svr4_solib_create_inferior_hook): Pass current_program_space to
 684         get_svr4_info.
 685         (svr4_clear_solib): Likewise.
 686
 687 2019-04-22  Pedro Alves  <palves@redhat.com>
 688
 689         * solib-svr4.c (svr4_free_objfile_observer): New.
 690         (probe_and_action::objfile): New field.
 691         (probes_table_htab_remove_objfile_probes)
 692         (probes_table_remove_objfile_probes): New functions.
 693         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 694         in the new probe_and_action.  Don't store the probe in 'lookup'.
 695         (svr4_create_probe_breakpoints): Pass objfile to
 696         register_solib_event_probe.
 697         (_initialize_svr4_solib): Register a free_objfile observer.
 698
 699 2019-04-19  Tom Tromey  <tom@tromey.com>
 700
 701         * common/queue.h: Remove.
 702
 703 2019-04-19  Tom Tromey  <tom@tromey.com>
 704
 705         * event-loop.c: Don't include "common/queue.h".
 706
 707 2019-04-19  Tom Tromey  <tom@tromey.com>
 708
 709         * remote.c (remote_target): Use delete.
 710         * remote-notif.h: Include <list>, not "common/queue.h".
 711         (notif_client_p): Remove typedef.
 712         (remote_notif_state): Add constructor, destructor, initializer.
 713         <notif_queue>: Now a std::list.
 714         (remote_notif_state_xfree): Don't declare.
 715         * remote-notif.c (remote_notif_process, handle_notification)
 716         (remote_notif_state_allocate): Update.
 717         (~remote_notif_state): Rename from remote_notif_state_xfree.
 718
 719 2019-04-19  Tom Tromey  <tom@tromey.com>
 720
 721         * symfile.c (reread_symbols): Update.
 722         * objfiles.c (objfile_register_static_link)
 723         (objfile_lookup_static_link): Update
 724         (~objfile) Don't delete static_links.
 725         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 726
 727 2019-04-19  Tom Tromey  <tom@tromey.com>
 728
 729         * type-stack.h (struct type_stack) <insert>: Constify string.
 730         * type-stack.c (type_stack::insert): Constify string.
 731         * gdbtypes.h (lookup_template_type): Update.
 732         (address_space_name_to_int): Update.
 733         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 734         const.
 735         (lookup_template_type): Make name const.
 736         * c-exp.y: Update rules.
 737         (lex_one_token, classify_name, classify_inner_name)
 738         (c_print_token): Update.
 739         * p-exp.y: Update rules.
 740         (yylex): Update.
 741         * f-exp.y: Update rules.
 742         (yylex): Update.
 743         * d-exp.y: Update rules.
 744         (lex_one_token, classify_name, classify_inner_name): Update.
 745         * parse.c (write_dollar_variable, copy_name): Return std::string.
 746         * parser-defs.h (copy_name): Change return type.
 747         * m2-exp.y: Update rules.
 748         (yylex): Update.
 749         * go-exp.y (lex_one_token): Update.
 750         Update rules.
 751         (classify_unsafe_function, classify_packaged_name)
 752         (classify_name, yylex): Update.
 753
 754 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 755
 756         * configure.ac: add --enable-source-highlight switch.
 757         * configure: Regenerate.
 758         * top.c (print_gdb_version): plumb --enable-source-highlight
 759         status to "show configuration".
 760
 761 2019-04-19  Tom Tromey  <tromey@adacore.com>
 762
 763         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 764         Check ADA_TYPE_P.
 765         (empty_record, ada_template_to_fixed_record_type_1)
 766         (template_to_static_fixed_type)
 767         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 768         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 769         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 770         macros.
 771
 772 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 773
 774         PR symtab/24423:
 775         * source.c (print_source_lines_base): Advance "iter" when a
 776         control character is seen.
 777
 778 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 779
 780         * inferior.h (struct infcall_suspend_state_deleter):
 781         Catch exception in destructor to avoid crash.
 782
 783 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 784
 785         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 786         close to the add_com "shell".
 787
 788 2019-04-18  Tom Tromey  <tromey@adacore.com>
 789
 790         * process-stratum-target.h (class process_stratum_target)
 791         <stratum>: Add "final".
 792
 793 2019-04-17  Tom Tromey  <tromey@adacore.com>
 794
 795         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 796         against nullptr before use.
 797
 798 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 799
 800         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 801
 802 2019-04-17  Jim Wilson  <jimw@sifive.com>
 803             Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 806         code read might fail, assume 4-byte breakpoint in that case.
 807
 808 2019-04-15  Leszek Swirski  <leszeks@google.com>
 809
 810         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 811         rather than a hand-rolled POD check when checking for forced MEMORY
 812         classification.
 813
 814 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 815
 816         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 817         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 818         function.
 819         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 820         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 821         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 822         declaration.
 823
 824 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 825
 826         * aarch64-linux-nat.c
 827         (aarch64_linux_nat_target::thread_architecture): Add override.
 828         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 829         each VQ.
 830
 831 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 832
 833         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 834
 835 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 836
 837         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 838         target types of size 96-bits, add some additional comments, and
 839         check that the builtin type we found was the correct size.
 840
 841 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 842
 843         * utils.c (prompt_for_continue): Don't restore the styling at the
 844         end, as applied_style has the wrong value.  This fixes styling in
 845         long lists of file names that are interrupted by the "Continue?"
 846         prompt.
 847
 848 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 849
 850         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 851         * c-lang.c (c_language_defn): Likewise.
 852         (cplus_language_defn): Likewise.
 853         (asm_language_defn): Likewise.
 854         (minimal_language_defn): Likewise.
 855         * d-lang.c (d_language_defn): Likewise.
 856         * f-lang.c (f_language_defn): Likewise.
 857         * go-lang.c (go_language_defn): Likewise.
 858         * language.c (unknown_language_defn): Likewise.
 859         (auto_language_defn): Likewise.
 860         * language.h (struct language_defn): Remove la_magic field.
 861         (LANG_MAGIC): Delete.
 862         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 863         * objc-lang.c (objc_language_defn): Likewise.
 864         * opencl-lang.c (opencl_language_defn): Likewise.
 865         * p-lang.c (pascal_language_defn): Likewise.
 866         * rust-lang.c (rust_language_defn): Likewise.
 867
 868 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * riscv-tdep.c (riscv_type_align): New function.
 871         (riscv_type_alignment): Delete.
 872         (riscv_arg_location): Use 'type_align'.
 873         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 874
 875 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 876
 877         * gdbtypes.c (type_align): A struct with no non-static fields also
 878         has alignment of 1.
 879
 880 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 881
 882         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 883         component to 0.
 884         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 885         member.
 886         (riscv_struct_info::analyse): New implementation using new
 887         analyse_inner member function.
 888         (riscv_struct_info::field_offset): New member function.
 889         (riscv_struct_info::m_offsets): New member variable.
 890         (riscv_struct_info::analyse_inner): New private member function,
 891         takes the old implementation of riscv_struct_info::analyse but
 892         extended to track field offsets.
 893         (riscv_call_arg_struct): Update the struct folding special cases
 894         to handle cases where empty C++ structs, which are non-zero
 895         length, are found.
 896         (riscv_arg_location): Initialise the length of each location, a
 897         non-zero length now indicates the location is in use.
 898         (riscv_push_dummy_call): Allow for the first location having a
 899         non-zero offset when setting up arguments.
 900         (riscv_return_value): Likewise, but for return values.
 901
 902 2019-04-11  Tom Tromey  <tromey@adacore.com>
 903
 904         * utils.c (internal_vproblem): Make "msg" const.
 905
 906 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 907
 908         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 909         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 910         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 911         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 912
 913 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 914
 915         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 916         function.
 917         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 918         of amd64_collect_native_gregset.
 919         (amd64_linux_nat_target::store_registers): Likewise.
 920
 921 2019-04-10  Tom Tromey  <tom@tromey.com>
 922
 923         * symtab.c (lookup_global_symbol_from_objfile)
 924         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 925         * objfiles.h (class separate_debug_iterator): New.
 926         (class separate_debug_range): New.
 927         (struct objfile) <separate_debug_objfiles>: New method.
 928         (objfile_separate_debug_iterate): Don't declare.
 929         * objfiles.c (separate_debug_iterator::operator++): Rename from
 930         objfile_separate_debug_iterate.
 931         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 932         iterator.
 933         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 934         iterator.
 935
 936 2019-04-10  Tom Tromey  <tom@tromey.com>
 937
 938         * symfile.c (reread_symbols): Remove old comment.
 939         * objfiles.c (free_all_objfiles): Fix a typo.
 940
 941 2019-04-10  Tom Tromey  <tom@tromey.com>
 942
 943         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 944         * minsyms.c (lookup_minimal_symbol): Use foreach.
 945         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 946         (lookup_minimal_symbol_solib_trampoline): Likewise.
 947         * symfile.c (reread_symbols): Use foreach.
 948
 949 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 950             Tom Tromey  <tromey@adacore.com>
 951
 952         PR rust/24414:
 953         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 954         (rust_lex_int_test): Change "value" to be LONGEST.
 955         (rust_lex_tests): Add test for long integer literal.
 956
 957 2019-04-09  Tom Tromey  <tromey@adacore.com>
 958
 959         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 960         to bool.
 961         (extended_remote_target::attach): Update.
 962         (remote_target::remote_notice_new_inferior): Update.
 963         (remote_target::add_current_inferior_and_thread): Update.
 964         * inferior.c (exit_inferior_1): Use "false".
 965         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 966
 967 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 968
 969         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 970         the "start" command.
 971
 972 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 973
 974         * python/py-inferior.c (infpy_thread_from_thread_handle):
 975         Adjust comments to reflect renaming of thread_from_thread_handle
 976         to thread_from_handle.  Adjust keywords.  Fix type error message.
 977         (inferior_object_methods): Add thread_from_handle.  Retain
 978         thread_from_thread_handle, but mark it as deprecated.
 979
 980 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 981
 982         * gdbthread.h (find_thread_by_handle): Revise declaration.
 983         * thread.c (find_thread_by_handle): Likewise.  Adjust
 984         implementation too.
 985         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 986         support for buffer objects as handles.
 987
 988 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 989
 990         * python/py-infthread.c (thpy_thread_handle): New function.
 991         (thread_object_methods): Register thpy_thread_handle.
 992
 993 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 994
 995         * gdbthread.h (thread_to_thread_handle): Declare.
 996         * thread.c (gdbtypes.h): Include.
 997         (thread_to_thread_handle): New function.
 998
 999         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1000         (target_thread_info_to_thread_handle): Declare.
1001         * target.c (target_thread_info_to_thread_handle): New function.
1002         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1003         * target-delegates.c: Regenerate.
1004
1005         * linux-thread-db.c (class thread_db_target): Add method
1006         thread_info_to_thread_handle.
1007         (thread_db_target::thread_info_to_thread_handle): Define.
1008         * remote.c (class remote_target): Add new method
1009         thread_info_to_thread_handle.
1010         (remote_target::thread_info_to_thread_handle): Define.
1011
1012 2019-04-08  Pedro Alves  <palves@redhat.com>
1013
1014         * common/common-exceptions.c (throw_exception): Don't create
1015         named object to throw; throw directly.
1016         (throw_it): Likewise.  Don't initialize gdb_exception::message
1017         here, with new; pass FMT and AP to the ctor instead.
1018         * common/common-exceptions.h: Include <string>.
1019         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1020         const char *, va_list)): New ctor.  Use std::make_shared.
1021         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1022         errors)): Delete.
1023         (gdb_exception_error::gdb_exception_error(enum errors, const char
1024         *, va_list)): New.
1025         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1026         Add assertion.
1027         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1028         errors)): Delete.
1029         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1030         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1031         Add assertion.
1032
1033 2019-04-08  Tom Tromey  <tom@tromey.com>
1034
1035         * valops.c (value_rtti_indirect_type): Replace throw_exception
1036         with throw.
1037         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1038         with throw.
1039         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1040         throw.
1041         * target.c (target_translate_tls_address): Replace throw_exception
1042         with throw.
1043         * stack.c (frame_apply_command_count): Replace throw_exception
1044         with throw.
1045         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1046         throw.
1047         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1048         with throw.
1049         * rs6000-tdep.c (rs6000_frame_cache)
1050         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1051         * remote.c: Replace throw_exception with throw.
1052         * record-full.c (record_full_message, record_full_wait_1)
1053         (record_full_restore): Replace throw_exception with throw.
1054         * record-btrace.c:
1055         (get_thread_current_frame_id, record_btrace_start_replaying)
1056         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1057         (cmd_record_btrace_start): Replace throw_exception with throw.
1058         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1059         throw.
1060         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1061         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1062         * linespec.c:
1063         (find_linespec_symbols): Replace throw_exception with throw.
1064         * infrun.c (displaced_step_prepare, resume): Replace
1065         throw_exception with throw.
1066         * infcmd.c (post_create_inferior): Replace throw_exception with
1067         throw.
1068         * inf-loop.c (inferior_event_handler): Replace throw_exception
1069         with throw.
1070         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1071         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1072         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1073         (get_prev_frame_always, get_frame_pc_if_available)
1074         (get_frame_address_in_block_if_available, get_frame_language):
1075         Replace throw_exception with throw.
1076         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1077         throw_exception with throw.
1078         * eval.c (fetch_subexp_value, evaluate_var_value)
1079         (evaluate_funcall, evaluate_subexp_standard): Replace
1080         throw_exception with throw.
1081         * dwarf2loc.c (call_site_find_chain)
1082         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1083         Replace throw_exception with throw.
1084         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1085         with throw.
1086         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1087         throw.
1088         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1089         * completer.c (complete_line_internal): Replace throw_exception
1090         with throw.
1091         * compile/compile-object-run.c (compile_object_run): Replace
1092         throw_exception with throw.
1093         * cli/cli-script.c (process_next_line): Replace throw_exception
1094         with throw.
1095         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1096         (btrace_enable, btrace_maint_update_pt_packets): Replace
1097         throw_exception with throw.
1098         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1099         throw_exception with throw.
1100         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1101         throw_exception with throw.
1102         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1103         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1104         * aarch64-tdep.c (aarch64_make_prologue_cache)
1105         (aarch64_make_stub_cache): Replace throw_exception with throw.
1106
1107 2019-04-08  Tom Tromey  <tom@tromey.com>
1108
1109         * common/common-exceptions.c (throw_exception): Rename from
1110         throw_exception_cxx.  Remove old copy.  Make argument const.
1111         (throw_it): Create and throw exception objects directly.
1112         * common/common-exceptions.h (throw_exception): Make argument
1113         const.
1114         (struct gdb_exception_error): Add constructor.
1115         (struct gdb_exception_quit): Add constructor.
1116
1117 2019-04-08  Tom Tromey  <tom@tromey.com>
1118
1119         * common/common-exceptions.h (exception_rethrow): Don't declare.
1120         (TRY_SJLJ): Update comment.
1121         (TRY, CATCH, END_CATCH): Remove.
1122         * common/common-exceptions.c (exception_rethrow): Remove.
1123
1124 2019-04-08  Tom Tromey  <tom@tromey.com>
1125
1126         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1127         Remove.
1128         (gdb_exception_error): Rename from
1129         gdb_exception_RETURN_MASK_ERROR.
1130         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1131         (gdb_quit_bad_alloc): Update.
1132         * aarch64-tdep.c: Update.
1133         * ada-lang.c: Update.
1134         * ada-typeprint.c: Update.
1135         * ada-valprint.c: Update.
1136         * amd64-tdep.c: Update.
1137         * arch-utils.c: Update.
1138         * break-catch-throw.c: Update.
1139         * breakpoint.c: Update.
1140         * btrace.c: Update.
1141         * c-varobj.c: Update.
1142         * cli/cli-cmds.c: Update.
1143         * cli/cli-interp.c: Update.
1144         * cli/cli-script.c: Update.
1145         * common/common-exceptions.c: Update.
1146         * common/new-op.c: Update.
1147         * common/selftest.c: Update.
1148         * compile/compile-c-symbols.c: Update.
1149         * compile/compile-cplus-symbols.c: Update.
1150         * compile/compile-object-load.c: Update.
1151         * compile/compile-object-run.c: Update.
1152         * completer.c: Update.
1153         * corelow.c: Update.
1154         * cp-abi.c: Update.
1155         * cp-support.c: Update.
1156         * cp-valprint.c: Update.
1157         * darwin-nat.c: Update.
1158         * disasm-selftests.c: Update.
1159         * dtrace-probe.c: Update.
1160         * dwarf-index-cache.c: Update.
1161         * dwarf-index-write.c: Update.
1162         * dwarf2-frame-tailcall.c: Update.
1163         * dwarf2-frame.c: Update.
1164         * dwarf2loc.c: Update.
1165         * dwarf2read.c: Update.
1166         * eval.c: Update.
1167         * event-loop.c: Update.
1168         * event-top.c: Update.
1169         * exec.c: Update.
1170         * f-valprint.c: Update.
1171         * fbsd-tdep.c: Update.
1172         * frame-unwind.c: Update.
1173         * frame.c: Update.
1174         * gdbtypes.c: Update.
1175         * gnu-v3-abi.c: Update.
1176         * guile/guile-internal.h: Update.
1177         * guile/scm-block.c: Update.
1178         * guile/scm-breakpoint.c: Update.
1179         * guile/scm-cmd.c: Update.
1180         * guile/scm-disasm.c: Update.
1181         * guile/scm-frame.c: Update.
1182         * guile/scm-lazy-string.c: Update.
1183         * guile/scm-math.c: Update.
1184         * guile/scm-param.c: Update.
1185         * guile/scm-ports.c: Update.
1186         * guile/scm-pretty-print.c: Update.
1187         * guile/scm-symbol.c: Update.
1188         * guile/scm-symtab.c: Update.
1189         * guile/scm-type.c: Update.
1190         * guile/scm-value.c: Update.
1191         * i386-linux-tdep.c: Update.
1192         * i386-tdep.c: Update.
1193         * inf-loop.c: Update.
1194         * infcall.c: Update.
1195         * infcmd.c: Update.
1196         * infrun.c: Update.
1197         * jit.c: Update.
1198         * language.c: Update.
1199         * linespec.c: Update.
1200         * linux-fork.c: Update.
1201         * linux-nat.c: Update.
1202         * linux-tdep.c: Update.
1203         * linux-thread-db.c: Update.
1204         * main.c: Update.
1205         * mi/mi-cmd-break.c: Update.
1206         * mi/mi-cmd-stack.c: Update.
1207         * mi/mi-interp.c: Update.
1208         * mi/mi-main.c: Update.
1209         * objc-lang.c: Update.
1210         * p-valprint.c: Update.
1211         * parse.c: Update.
1212         * ppc-linux-tdep.c: Update.
1213         * printcmd.c: Update.
1214         * python/py-arch.c: Update.
1215         * python/py-breakpoint.c: Update.
1216         * python/py-cmd.c: Update.
1217         * python/py-finishbreakpoint.c: Update.
1218         * python/py-frame.c: Update.
1219         * python/py-framefilter.c: Update.
1220         * python/py-gdb-readline.c: Update.
1221         * python/py-inferior.c: Update.
1222         * python/py-infthread.c: Update.
1223         * python/py-lazy-string.c: Update.
1224         * python/py-linetable.c: Update.
1225         * python/py-objfile.c: Update.
1226         * python/py-param.c: Update.
1227         * python/py-prettyprint.c: Update.
1228         * python/py-progspace.c: Update.
1229         * python/py-record-btrace.c: Update.
1230         * python/py-record.c: Update.
1231         * python/py-symbol.c: Update.
1232         * python/py-type.c: Update.
1233         * python/py-unwind.c: Update.
1234         * python/py-utils.c: Update.
1235         * python/py-value.c: Update.
1236         * python/python.c: Update.
1237         * record-btrace.c: Update.
1238         * record-full.c: Update.
1239         * remote-fileio.c: Update.
1240         * remote.c: Update.
1241         * riscv-tdep.c: Update.
1242         * rs6000-aix-tdep.c: Update.
1243         * rs6000-tdep.c: Update.
1244         * rust-exp.y: Update.
1245         * rust-lang.c: Update.
1246         * s390-tdep.c: Update.
1247         * selftest-arch.c: Update.
1248         * solib-dsbt.c: Update.
1249         * solib-frv.c: Update.
1250         * solib-spu.c: Update.
1251         * solib-svr4.c: Update.
1252         * solib.c: Update.
1253         * sparc64-linux-tdep.c: Update.
1254         * stack.c: Update.
1255         * symfile-mem.c: Update.
1256         * symmisc.c: Update.
1257         * target.c: Update.
1258         * thread.c: Update.
1259         * top.c: Update.
1260         * tracefile-tfile.c: Update.
1261         * tui/tui.c: Update.
1262         * typeprint.c: Update.
1263         * unittests/cli-utils-selftests.c: Update.
1264         * unittests/parse-connection-spec-selftests.c: Update.
1265         * valops.c: Update.
1266         * valprint.c: Update.
1267         * value.c: Update.
1268         * varobj.c: Update.
1269         * windows-nat.c: Update.
1270         * x86-linux-nat.c: Update.
1271         * xml-support.c: Update.
1272
1273 2019-04-08  Tom Tromey  <tom@tromey.com>
1274
1275         * xml-support.c: Use C++ exception handling.
1276         * x86-linux-nat.c: Use C++ exception handling.
1277         * windows-nat.c: Use C++ exception handling.
1278         * varobj.c: Use C++ exception handling.
1279         * value.c: Use C++ exception handling.
1280         * valprint.c: Use C++ exception handling.
1281         * valops.c: Use C++ exception handling.
1282         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1283         handling.
1284         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1285         * typeprint.c: Use C++ exception handling.
1286         * tui/tui.c: Use C++ exception handling.
1287         * tracefile-tfile.c: Use C++ exception handling.
1288         * top.c: Use C++ exception handling.
1289         * thread.c: Use C++ exception handling.
1290         * target.c: Use C++ exception handling.
1291         * symmisc.c: Use C++ exception handling.
1292         * symfile-mem.c: Use C++ exception handling.
1293         * stack.c: Use C++ exception handling.
1294         * sparc64-linux-tdep.c: Use C++ exception handling.
1295         * solib.c: Use C++ exception handling.
1296         * solib-svr4.c: Use C++ exception handling.
1297         * solib-spu.c: Use C++ exception handling.
1298         * solib-frv.c: Use C++ exception handling.
1299         * solib-dsbt.c: Use C++ exception handling.
1300         * selftest-arch.c: Use C++ exception handling.
1301         * s390-tdep.c: Use C++ exception handling.
1302         * rust-lang.c: Use C++ exception handling.
1303         * rust-exp.y: Use C++ exception handling.
1304         * rs6000-tdep.c: Use C++ exception handling.
1305         * rs6000-aix-tdep.c: Use C++ exception handling.
1306         * riscv-tdep.c: Use C++ exception handling.
1307         * remote.c: Use C++ exception handling.
1308         * remote-fileio.c: Use C++ exception handling.
1309         * record-full.c: Use C++ exception handling.
1310         * record-btrace.c: Use C++ exception handling.
1311         * python/python.c: Use C++ exception handling.
1312         * python/py-value.c: Use C++ exception handling.
1313         * python/py-utils.c: Use C++ exception handling.
1314         * python/py-unwind.c: Use C++ exception handling.
1315         * python/py-type.c: Use C++ exception handling.
1316         * python/py-symbol.c: Use C++ exception handling.
1317         * python/py-record.c: Use C++ exception handling.
1318         * python/py-record-btrace.c: Use C++ exception handling.
1319         * python/py-progspace.c: Use C++ exception handling.
1320         * python/py-prettyprint.c: Use C++ exception handling.
1321         * python/py-param.c: Use C++ exception handling.
1322         * python/py-objfile.c: Use C++ exception handling.
1323         * python/py-linetable.c: Use C++ exception handling.
1324         * python/py-lazy-string.c: Use C++ exception handling.
1325         * python/py-infthread.c: Use C++ exception handling.
1326         * python/py-inferior.c: Use C++ exception handling.
1327         * python/py-gdb-readline.c: Use C++ exception handling.
1328         * python/py-framefilter.c: Use C++ exception handling.
1329         * python/py-frame.c: Use C++ exception handling.
1330         * python/py-finishbreakpoint.c: Use C++ exception handling.
1331         * python/py-cmd.c: Use C++ exception handling.
1332         * python/py-breakpoint.c: Use C++ exception handling.
1333         * python/py-arch.c: Use C++ exception handling.
1334         * printcmd.c: Use C++ exception handling.
1335         * ppc-linux-tdep.c: Use C++ exception handling.
1336         * parse.c: Use C++ exception handling.
1337         * p-valprint.c: Use C++ exception handling.
1338         * objc-lang.c: Use C++ exception handling.
1339         * mi/mi-main.c: Use C++ exception handling.
1340         * mi/mi-interp.c: Use C++ exception handling.
1341         * mi/mi-cmd-stack.c: Use C++ exception handling.
1342         * mi/mi-cmd-break.c: Use C++ exception handling.
1343         * main.c: Use C++ exception handling.
1344         * linux-thread-db.c: Use C++ exception handling.
1345         * linux-tdep.c: Use C++ exception handling.
1346         * linux-nat.c: Use C++ exception handling.
1347         * linux-fork.c: Use C++ exception handling.
1348         * linespec.c: Use C++ exception handling.
1349         * language.c: Use C++ exception handling.
1350         * jit.c: Use C++ exception handling.
1351         * infrun.c: Use C++ exception handling.
1352         * infcmd.c: Use C++ exception handling.
1353         * infcall.c: Use C++ exception handling.
1354         * inf-loop.c: Use C++ exception handling.
1355         * i386-tdep.c: Use C++ exception handling.
1356         * i386-linux-tdep.c: Use C++ exception handling.
1357         * guile/scm-value.c: Use C++ exception handling.
1358         * guile/scm-type.c: Use C++ exception handling.
1359         * guile/scm-symtab.c: Use C++ exception handling.
1360         * guile/scm-symbol.c: Use C++ exception handling.
1361         * guile/scm-pretty-print.c: Use C++ exception handling.
1362         * guile/scm-ports.c: Use C++ exception handling.
1363         * guile/scm-param.c: Use C++ exception handling.
1364         * guile/scm-math.c: Use C++ exception handling.
1365         * guile/scm-lazy-string.c: Use C++ exception handling.
1366         * guile/scm-frame.c: Use C++ exception handling.
1367         * guile/scm-disasm.c: Use C++ exception handling.
1368         * guile/scm-cmd.c: Use C++ exception handling.
1369         * guile/scm-breakpoint.c: Use C++ exception handling.
1370         * guile/scm-block.c: Use C++ exception handling.
1371         * guile/guile-internal.h: Use C++ exception handling.
1372         * gnu-v3-abi.c: Use C++ exception handling.
1373         * gdbtypes.c: Use C++ exception handling.
1374         * frame.c: Use C++ exception handling.
1375         * frame-unwind.c: Use C++ exception handling.
1376         * fbsd-tdep.c: Use C++ exception handling.
1377         * f-valprint.c: Use C++ exception handling.
1378         * exec.c: Use C++ exception handling.
1379         * event-top.c: Use C++ exception handling.
1380         * event-loop.c: Use C++ exception handling.
1381         * eval.c: Use C++ exception handling.
1382         * dwarf2read.c: Use C++ exception handling.
1383         * dwarf2loc.c: Use C++ exception handling.
1384         * dwarf2-frame.c: Use C++ exception handling.
1385         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1386         * dwarf-index-write.c: Use C++ exception handling.
1387         * dwarf-index-cache.c: Use C++ exception handling.
1388         * dtrace-probe.c: Use C++ exception handling.
1389         * disasm-selftests.c: Use C++ exception handling.
1390         * darwin-nat.c: Use C++ exception handling.
1391         * cp-valprint.c: Use C++ exception handling.
1392         * cp-support.c: Use C++ exception handling.
1393         * cp-abi.c: Use C++ exception handling.
1394         * corelow.c: Use C++ exception handling.
1395         * completer.c: Use C++ exception handling.
1396         * compile/compile-object-run.c: Use C++ exception handling.
1397         * compile/compile-object-load.c: Use C++ exception handling.
1398         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1399         * compile/compile-c-symbols.c: Use C++ exception handling.
1400         * common/selftest.c: Use C++ exception handling.
1401         * common/new-op.c: Use C++ exception handling.
1402         * cli/cli-script.c: Use C++ exception handling.
1403         * cli/cli-interp.c: Use C++ exception handling.
1404         * cli/cli-cmds.c: Use C++ exception handling.
1405         * c-varobj.c: Use C++ exception handling.
1406         * btrace.c: Use C++ exception handling.
1407         * breakpoint.c: Use C++ exception handling.
1408         * break-catch-throw.c: Use C++ exception handling.
1409         * arch-utils.c: Use C++ exception handling.
1410         * amd64-tdep.c: Use C++ exception handling.
1411         * ada-valprint.c: Use C++ exception handling.
1412         * ada-typeprint.c: Use C++ exception handling.
1413         * ada-lang.c: Use C++ exception handling.
1414         * aarch64-tdep.c: Use C++ exception handling.
1415
1416 2019-04-08  Tom Tromey  <tom@tromey.com>
1417
1418         * xml-support.c (gdb_xml_parser::parse): Update.
1419         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1420         * value.c (show_convenience): Update.
1421         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1422         (test_parse_flags_qcs): Update.
1423         * thread.c (thr_try_catch_cmd): Update.
1424         * target.c (target_translate_tls_address): Update.
1425         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1426         (info_frame_command_core, frame_apply_command_count): Update.
1427         * rust-exp.y (rust_lex_exception_test): Update.
1428         * riscv-tdep.c (riscv_print_one_register_info): Update.
1429         * remote.c (remote_target::enable_btrace): Update.
1430         * record-btrace.c (record_btrace_enable_warn): Update.
1431         * python/py-utils.c (gdbpy_convert_exception): Update.
1432         * printcmd.c (do_one_display, print_variable_and_value): Update.
1433         * mi/mi-main.c (mi_print_exception): Update.
1434         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1435         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1436         * linux-nat.c (linux_nat_target::attach): Update.
1437         * linux-fork.c (class scoped_switch_fork_info): Update.
1438         * infrun.c (displaced_step_prepare): Update.
1439         * infcall.c (call_function_by_hand_dummy): Update.
1440         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1441         * gnu-v3-abi.c (print_one_vtable): Update.
1442         * frame.c (get_prev_frame_always): Update.
1443         * f-valprint.c (info_common_command_for_block): Update.
1444         * exec.c (try_open_exec_file): Update.
1445         * exceptions.c (print_exception, exception_print)
1446         (exception_fprintf, exception_print_same): Update.
1447         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1448         * dwarf-index-cache.c (index_cache::store)
1449         (index_cache::lookup_gdb_index): Update.
1450         * darwin-nat.c (maybe_cache_shell): Update.
1451         * cp-valprint.c (cp_print_value_fields): Update.
1452         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1453         (gcc_cplus_symbol_address): Update.
1454         * compile/compile-c-symbols.c (gcc_convert_symbol)
1455         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1456         * common/selftest.c: Update.
1457         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1458         a std::string.
1459         (exception_try_scope_entry, exception_try_scope_exit): Don't
1460         declare.
1461         (struct exception_try_scope): Remove.
1462         (TRY): Don't use exception_try_scope.
1463         (struct gdb_exception): Add constructor, operator=.
1464         <what>: New method.
1465         (struct gdb_exception_RETURN_MASK_ALL)
1466         (struct gdb_exception_RETURN_MASK_ERROR)
1467         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1468         (struct gdb_quit_bad_alloc): Update.
1469         * common/common-exceptions.c (exception_none): Change
1470         initializer.
1471         (struct catcher) <state, exception>: Initialize inline.
1472         <prev>: Remove member.
1473         (current_catcher): Remove.
1474         (catchers): New global.
1475         (exceptions_state_mc_init): Simplify.
1476         (catcher_pop): Remove.
1477         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1478         (try_scope_depth, exception_try_scope_entry)
1479         (exception_try_scope_exit): Remove.
1480         (throw_exception_sjlj): Update.
1481         (exception_messages, exception_messages_size): Remove.
1482         (throw_it): Simplify.
1483         (gdb_exception_sliced_copy): Remove.
1484         (throw_exception_cxx): Update.
1485         * cli/cli-script.c (script_from_file): Update.
1486         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1487         Update.
1488         * ada-valprint.c (ada_val_print): Update.
1489         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1490         (create_excep_cond_exprs): Update.
1491
1492 2019-04-08  Tom Tromey  <tom@tromey.com>
1493
1494         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1495         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1496         (TRY, CATCH, END_CATCH): Remove some definitions.
1497         * common/common-exceptions.c: Don't use GDB_XCPT.
1498         (catcher_list_size): Remove.
1499         (throw_exception, throw_it): Simplify.
1500
1501 2019-04-05  Tom Tromey  <tom@tromey.com>
1502
1503         Revert the header-sorting patch.
1504         * ft32-tdep.c: Revert.
1505         * frv-tdep.c: Revert.
1506         * frv-linux-tdep.c: Revert.
1507         * frame.c: Revert.
1508         * frame-unwind.c: Revert.
1509         * frame-base.c: Revert.
1510         * fork-child.c: Revert.
1511         * findvar.c: Revert.
1512         * findcmd.c: Revert.
1513         * filesystem.c: Revert.
1514         * filename-seen-cache.h: Revert.
1515         * filename-seen-cache.c: Revert.
1516         * fbsd-tdep.c: Revert.
1517         * fbsd-nat.h: Revert.
1518         * fbsd-nat.c: Revert.
1519         * f-valprint.c: Revert.
1520         * f-typeprint.c: Revert.
1521         * f-lang.c: Revert.
1522         * extension.h: Revert.
1523         * extension.c: Revert.
1524         * extension-priv.h: Revert.
1525         * expprint.c: Revert.
1526         * exec.h: Revert.
1527         * exec.c: Revert.
1528         * exceptions.c: Revert.
1529         * event-top.c: Revert.
1530         * event-loop.c: Revert.
1531         * eval.c: Revert.
1532         * elfread.c: Revert.
1533         * dwarf2read.h: Revert.
1534         * dwarf2read.c: Revert.
1535         * dwarf2loc.c: Revert.
1536         * dwarf2expr.h: Revert.
1537         * dwarf2expr.c: Revert.
1538         * dwarf2-frame.c: Revert.
1539         * dwarf2-frame-tailcall.c: Revert.
1540         * dwarf-index-write.h: Revert.
1541         * dwarf-index-write.c: Revert.
1542         * dwarf-index-common.c: Revert.
1543         * dwarf-index-cache.h: Revert.
1544         * dwarf-index-cache.c: Revert.
1545         * dummy-frame.c: Revert.
1546         * dtrace-probe.c: Revert.
1547         * disasm.h: Revert.
1548         * disasm.c: Revert.
1549         * disasm-selftests.c: Revert.
1550         * dictionary.c: Revert.
1551         * dicos-tdep.c: Revert.
1552         * demangle.c: Revert.
1553         * dcache.h: Revert.
1554         * dcache.c: Revert.
1555         * darwin-nat.h: Revert.
1556         * darwin-nat.c: Revert.
1557         * darwin-nat-info.c: Revert.
1558         * d-valprint.c: Revert.
1559         * d-namespace.c: Revert.
1560         * d-lang.c: Revert.
1561         * ctf.c: Revert.
1562         * csky-tdep.c: Revert.
1563         * csky-linux-tdep.c: Revert.
1564         * cris-tdep.c: Revert.
1565         * cris-linux-tdep.c: Revert.
1566         * cp-valprint.c: Revert.
1567         * cp-support.c: Revert.
1568         * cp-namespace.c: Revert.
1569         * cp-abi.c: Revert.
1570         * corelow.c: Revert.
1571         * corefile.c: Revert.
1572         * continuations.c: Revert.
1573         * completer.h: Revert.
1574         * completer.c: Revert.
1575         * complaints.c: Revert.
1576         * coffread.c: Revert.
1577         * coff-pe-read.c: Revert.
1578         * cli-out.h: Revert.
1579         * cli-out.c: Revert.
1580         * charset.c: Revert.
1581         * c-varobj.c: Revert.
1582         * c-valprint.c: Revert.
1583         * c-typeprint.c: Revert.
1584         * c-lang.c: Revert.
1585         * buildsym.c: Revert.
1586         * buildsym-legacy.c: Revert.
1587         * build-id.h: Revert.
1588         * build-id.c: Revert.
1589         * btrace.c: Revert.
1590         * bsd-uthread.c: Revert.
1591         * breakpoint.h: Revert.
1592         * breakpoint.c: Revert.
1593         * break-catch-throw.c: Revert.
1594         * break-catch-syscall.c: Revert.
1595         * break-catch-sig.c: Revert.
1596         * blockframe.c: Revert.
1597         * block.c: Revert.
1598         * bfin-tdep.c: Revert.
1599         * bfin-linux-tdep.c: Revert.
1600         * bfd-target.c: Revert.
1601         * bcache.c: Revert.
1602         * ax-general.c: Revert.
1603         * ax-gdb.h: Revert.
1604         * ax-gdb.c: Revert.
1605         * avr-tdep.c: Revert.
1606         * auxv.c: Revert.
1607         * auto-load.c: Revert.
1608         * arm-wince-tdep.c: Revert.
1609         * arm-tdep.c: Revert.
1610         * arm-symbian-tdep.c: Revert.
1611         * arm-pikeos-tdep.c: Revert.
1612         * arm-obsd-tdep.c: Revert.
1613         * arm-nbsd-tdep.c: Revert.
1614         * arm-nbsd-nat.c: Revert.
1615         * arm-linux-tdep.c: Revert.
1616         * arm-linux-nat.c: Revert.
1617         * arm-fbsd-tdep.c: Revert.
1618         * arm-fbsd-nat.c: Revert.
1619         * arm-bsd-tdep.c: Revert.
1620         * arch-utils.c: Revert.
1621         * arc-tdep.c: Revert.
1622         * arc-newlib-tdep.c: Revert.
1623         * annotate.h: Revert.
1624         * annotate.c: Revert.
1625         * amd64-windows-tdep.c: Revert.
1626         * amd64-windows-nat.c: Revert.
1627         * amd64-tdep.c: Revert.
1628         * amd64-sol2-tdep.c: Revert.
1629         * amd64-obsd-tdep.c: Revert.
1630         * amd64-obsd-nat.c: Revert.
1631         * amd64-nbsd-tdep.c: Revert.
1632         * amd64-nbsd-nat.c: Revert.
1633         * amd64-nat.c: Revert.
1634         * amd64-linux-tdep.c: Revert.
1635         * amd64-linux-nat.c: Revert.
1636         * amd64-fbsd-tdep.c: Revert.
1637         * amd64-fbsd-nat.c: Revert.
1638         * amd64-dicos-tdep.c: Revert.
1639         * amd64-darwin-tdep.c: Revert.
1640         * amd64-bsd-nat.c: Revert.
1641         * alpha-tdep.c: Revert.
1642         * alpha-obsd-tdep.c: Revert.
1643         * alpha-nbsd-tdep.c: Revert.
1644         * alpha-mdebug-tdep.c: Revert.
1645         * alpha-linux-tdep.c: Revert.
1646         * alpha-linux-nat.c: Revert.
1647         * alpha-bsd-tdep.c: Revert.
1648         * alpha-bsd-nat.c: Revert.
1649         * aix-thread.c: Revert.
1650         * agent.c: Revert.
1651         * addrmap.c: Revert.
1652         * ada-varobj.c: Revert.
1653         * ada-valprint.c: Revert.
1654         * ada-typeprint.c: Revert.
1655         * ada-tasks.c: Revert.
1656         * ada-lang.c: Revert.
1657         * aarch64-tdep.c: Revert.
1658         * aarch64-ravenscar-thread.c: Revert.
1659         * aarch64-newlib-tdep.c: Revert.
1660         * aarch64-linux-tdep.c: Revert.
1661         * aarch64-linux-nat.c: Revert.
1662         * aarch64-fbsd-tdep.c: Revert.
1663         * aarch64-fbsd-nat.c: Revert.
1664         * aarch32-linux-nat.c: Revert.
1665
1666 2019-04-05  Tom Tromey  <tom@tromey.com>
1667
1668         * ft32-tdep.c: Sort headers.
1669         * frv-tdep.c: Sort headers.
1670         * frv-linux-tdep.c: Sort headers.
1671         * frame.c: Sort headers.
1672         * frame-unwind.c: Sort headers.
1673         * frame-base.c: Sort headers.
1674         * fork-child.c: Sort headers.
1675         * findvar.c: Sort headers.
1676         * findcmd.c: Sort headers.
1677         * filesystem.c: Sort headers.
1678         * filename-seen-cache.h: Sort headers.
1679         * filename-seen-cache.c: Sort headers.
1680         * fbsd-tdep.c: Sort headers.
1681         * fbsd-nat.h: Sort headers.
1682         * fbsd-nat.c: Sort headers.
1683         * f-valprint.c: Sort headers.
1684         * f-typeprint.c: Sort headers.
1685         * f-lang.c: Sort headers.
1686         * extension.h: Sort headers.
1687         * extension.c: Sort headers.
1688         * extension-priv.h: Sort headers.
1689         * expprint.c: Sort headers.
1690         * exec.h: Sort headers.
1691         * exec.c: Sort headers.
1692         * exceptions.c: Sort headers.
1693         * event-top.c: Sort headers.
1694         * event-loop.c: Sort headers.
1695         * eval.c: Sort headers.
1696         * elfread.c: Sort headers.
1697         * dwarf2read.h: Sort headers.
1698         * dwarf2read.c: Sort headers.
1699         * dwarf2loc.c: Sort headers.
1700         * dwarf2expr.h: Sort headers.
1701         * dwarf2expr.c: Sort headers.
1702         * dwarf2-frame.c: Sort headers.
1703         * dwarf2-frame-tailcall.c: Sort headers.
1704         * dwarf-index-write.h: Sort headers.
1705         * dwarf-index-write.c: Sort headers.
1706         * dwarf-index-common.c: Sort headers.
1707         * dwarf-index-cache.h: Sort headers.
1708         * dwarf-index-cache.c: Sort headers.
1709         * dummy-frame.c: Sort headers.
1710         * dtrace-probe.c: Sort headers.
1711         * disasm.h: Sort headers.
1712         * disasm.c: Sort headers.
1713         * disasm-selftests.c: Sort headers.
1714         * dictionary.c: Sort headers.
1715         * dicos-tdep.c: Sort headers.
1716         * demangle.c: Sort headers.
1717         * dcache.h: Sort headers.
1718         * dcache.c: Sort headers.
1719         * darwin-nat.h: Sort headers.
1720         * darwin-nat.c: Sort headers.
1721         * darwin-nat-info.c: Sort headers.
1722         * d-valprint.c: Sort headers.
1723         * d-namespace.c: Sort headers.
1724         * d-lang.c: Sort headers.
1725         * ctf.c: Sort headers.
1726         * csky-tdep.c: Sort headers.
1727         * csky-linux-tdep.c: Sort headers.
1728         * cris-tdep.c: Sort headers.
1729         * cris-linux-tdep.c: Sort headers.
1730         * cp-valprint.c: Sort headers.
1731         * cp-support.c: Sort headers.
1732         * cp-namespace.c: Sort headers.
1733         * cp-abi.c: Sort headers.
1734         * corelow.c: Sort headers.
1735         * corefile.c: Sort headers.
1736         * continuations.c: Sort headers.
1737         * completer.h: Sort headers.
1738         * completer.c: Sort headers.
1739         * complaints.c: Sort headers.
1740         * coffread.c: Sort headers.
1741         * coff-pe-read.c: Sort headers.
1742         * cli-out.h: Sort headers.
1743         * cli-out.c: Sort headers.
1744         * charset.c: Sort headers.
1745         * c-varobj.c: Sort headers.
1746         * c-valprint.c: Sort headers.
1747         * c-typeprint.c: Sort headers.
1748         * c-lang.c: Sort headers.
1749         * buildsym.c: Sort headers.
1750         * buildsym-legacy.c: Sort headers.
1751         * build-id.h: Sort headers.
1752         * build-id.c: Sort headers.
1753         * btrace.c: Sort headers.
1754         * bsd-uthread.c: Sort headers.
1755         * breakpoint.h: Sort headers.
1756         * breakpoint.c: Sort headers.
1757         * break-catch-throw.c: Sort headers.
1758         * break-catch-syscall.c: Sort headers.
1759         * break-catch-sig.c: Sort headers.
1760         * blockframe.c: Sort headers.
1761         * block.c: Sort headers.
1762         * bfin-tdep.c: Sort headers.
1763         * bfin-linux-tdep.c: Sort headers.
1764         * bfd-target.c: Sort headers.
1765         * bcache.c: Sort headers.
1766         * ax-general.c: Sort headers.
1767         * ax-gdb.h: Sort headers.
1768         * ax-gdb.c: Sort headers.
1769         * avr-tdep.c: Sort headers.
1770         * auxv.c: Sort headers.
1771         * auto-load.c: Sort headers.
1772         * arm-wince-tdep.c: Sort headers.
1773         * arm-tdep.c: Sort headers.
1774         * arm-symbian-tdep.c: Sort headers.
1775         * arm-pikeos-tdep.c: Sort headers.
1776         * arm-obsd-tdep.c: Sort headers.
1777         * arm-nbsd-tdep.c: Sort headers.
1778         * arm-nbsd-nat.c: Sort headers.
1779         * arm-linux-tdep.c: Sort headers.
1780         * arm-linux-nat.c: Sort headers.
1781         * arm-fbsd-tdep.c: Sort headers.
1782         * arm-fbsd-nat.c: Sort headers.
1783         * arm-bsd-tdep.c: Sort headers.
1784         * arch-utils.c: Sort headers.
1785         * arc-tdep.c: Sort headers.
1786         * arc-newlib-tdep.c: Sort headers.
1787         * annotate.h: Sort headers.
1788         * annotate.c: Sort headers.
1789         * amd64-windows-tdep.c: Sort headers.
1790         * amd64-windows-nat.c: Sort headers.
1791         * amd64-tdep.c: Sort headers.
1792         * amd64-sol2-tdep.c: Sort headers.
1793         * amd64-obsd-tdep.c: Sort headers.
1794         * amd64-obsd-nat.c: Sort headers.
1795         * amd64-nbsd-tdep.c: Sort headers.
1796         * amd64-nbsd-nat.c: Sort headers.
1797         * amd64-nat.c: Sort headers.
1798         * amd64-linux-tdep.c: Sort headers.
1799         * amd64-linux-nat.c: Sort headers.
1800         * amd64-fbsd-tdep.c: Sort headers.
1801         * amd64-fbsd-nat.c: Sort headers.
1802         * amd64-dicos-tdep.c: Sort headers.
1803         * amd64-darwin-tdep.c: Sort headers.
1804         * amd64-bsd-nat.c: Sort headers.
1805         * alpha-tdep.c: Sort headers.
1806         * alpha-obsd-tdep.c: Sort headers.
1807         * alpha-nbsd-tdep.c: Sort headers.
1808         * alpha-mdebug-tdep.c: Sort headers.
1809         * alpha-linux-tdep.c: Sort headers.
1810         * alpha-linux-nat.c: Sort headers.
1811         * alpha-bsd-tdep.c: Sort headers.
1812         * alpha-bsd-nat.c: Sort headers.
1813         * aix-thread.c: Sort headers.
1814         * agent.c: Sort headers.
1815         * addrmap.c: Sort headers.
1816         * ada-varobj.c: Sort headers.
1817         * ada-valprint.c: Sort headers.
1818         * ada-typeprint.c: Sort headers.
1819         * ada-tasks.c: Sort headers.
1820         * ada-lang.c: Sort headers.
1821         * aarch64-tdep.c: Sort headers.
1822         * aarch64-ravenscar-thread.c: Sort headers.
1823         * aarch64-newlib-tdep.c: Sort headers.
1824         * aarch64-linux-tdep.c: Sort headers.
1825         * aarch64-linux-nat.c: Sort headers.
1826         * aarch64-fbsd-tdep.c: Sort headers.
1827         * aarch64-fbsd-nat.c: Sort headers.
1828         * aarch32-linux-nat.c: Sort headers.
1829
1830 2019-04-04  Tom Tromey  <tom@tromey.com>
1831
1832         * varobj.c (varobj_create): Update.
1833         * rust-exp.y (struct rust_parser) <update_innermost_block,
1834         lookup_symbol>: New methods.
1835         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1836         Rename.
1837         (rust_parser::rust_lookup_type)
1838         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1839         * printcmd.c (display_command, do_one_display): Update.
1840         * parser-defs.h (struct parser_state) <parser_state>: Add
1841         "tracker" parameter.
1842         (block_tracker): New member.
1843         (class innermost_block_tracker) <innermost_block_tracker>: Add
1844         "types" parameter.
1845         <reset>: Remove method.
1846         (innermost_block): Don't declare.
1847         (null_post_parser): Update.
1848         * parse.c (innermost_block): Remove global.
1849         (write_dollar_variable): Update.
1850         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1851         Remove "tracker_types" parameter.
1852         (parse_expression): Add "tracker" parameter.
1853         (parse_expression_for_completion): Update.
1854         (null_post_parser): Add "tracker" parameter.
1855         * p-exp.y: Update rules.
1856         * m2-exp.y: Update rules.
1857         * language.h (struct language_defn) <la_post_parser>: Add
1858         "tracker" parameter.
1859         * go-exp.y: Update rules.
1860         * f-exp.y: Update rules.
1861         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1862         parameter.
1863         * d-exp.y: Update rules.
1864         * c-exp.y: Update rules.
1865         * breakpoint.c (set_breakpoint_condition): Create an
1866         innermost_block_tracker.
1867         (watch_command_1): Likewise.
1868         * ada-lang.c (resolve): Add "tracker" parameter.
1869         (resolve_subexp): Likewise.
1870         * ada-exp.y (write_var_from_sym): Update.
1871
1872 2019-04-04  Tom Tromey  <tom@tromey.com>
1873
1874         * type-stack.h: New file.
1875         * type-stack.c: New file.
1876         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1877         type-stack.h.
1878         (insert_into_type_stack, insert_type, push_type, push_type_int)
1879         (insert_type_address_space, pop_type, pop_type_int)
1880         (pop_typelist, pop_type_stack, append_type_stack)
1881         (push_type_stack, get_type_stack, push_typelist)
1882         (follow_type_instance_flags, follow_types): Don't declare.
1883         * parse.c (type_stack): Remove global.
1884         (parse_exp_in_context): Update.
1885         (insert_into_type_stack, insert_type, push_type, push_type_int)
1886         (insert_type_address_space, pop_type, pop_type_int)
1887         (pop_typelist, pop_type_stack, append_type_stack)
1888         (push_type_stack, get_type_stack, push_typelist)
1889         (follow_type_instance_flags, follow_types): Remove (moved to
1890         type-stack.c).
1891         * f-exp.y (type_stack): New global.
1892         Update rules.
1893         (push_kind_type, f_parse): Update.
1894         * d-exp.y (type_stack): New global.
1895         Update rules.
1896         (d_parse): Update.
1897         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1898         Update rules.
1899         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1900         (HFILES_NO_SRCDIR): Add type-stack.h.
1901
1902 2019-04-04  Tom Tromey  <tom@tromey.com>
1903
1904         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1905         (rust_parser::convert_ast_to_expression, rust_parse)
1906         (rust_lex_test_completion, rust_lex_tests): Update.
1907         * parser-defs.h (struct expr_completion_state): New.
1908         (struct parser_state) <parser_state>: Add completion parameter.
1909         <mark_struct_expression, mark_completion_tag>: New methods.
1910         <parse_completion, m_completion_state>: New members.
1911         (prefixify_expression, null_post_parser): Update.
1912         (mark_struct_expression, mark_completion_tag): Don't declare.
1913         * parse.c (parse_completion, expout_last_struct)
1914         (expout_tag_completion_type, expout_completion_name): Remove
1915         globals.
1916         (parser_state::mark_struct_expression)
1917         (parser_state::mark_completion_tag): Now methods.
1918         (prefixify_expression): Add last_struct parameter.
1919         (prefixify_subexp): Likewise.
1920         (parse_exp_1): Update.
1921         (parse_exp_in_context): Add cstate parameter.  Update.
1922         (parse_expression_for_completion): Create an
1923         expr_completion_state.
1924         (null_post_parser): Add "completion" parameter.
1925         * p-exp.y: Update rules.
1926         (yylex): Update.
1927         * language.h (struct language_defn) <la_post_parser>: Add
1928         "completing" parameter.
1929         * go-exp.y: Update rules.
1930         (lex_one_token): Update.
1931         * expression.h (parse_completion): Don't declare.
1932         * d-exp.y: Update rules.
1933         (lex_one_token): Update rules.
1934         * c-exp.y: Update rules.
1935         (lex_one_token): Update.
1936         * ada-lang.c (resolve): Add "parse_completion" parameter.
1937         (resolve_subexp): Likewise.
1938         (ada_resolve_function): Likewise.
1939
1940 2019-04-04  Tom Tromey  <tom@tromey.com>
1941
1942         * parser-defs.h (struct parser_state) <start_arglist,
1943         end_arglist>: New methods.
1944         <arglist_len, m_funcall_chain>: New members.
1945         (arglist_len, start_arglist, end_arglist): Don't declare.
1946         * parse.c (arglist_len, funcall_chain): Remove global.
1947         (start_arglist, end_arglist): Remove functions.
1948         (parse_exp_in_context): Update.
1949         * p-exp.y: Update rules.
1950         * m2-exp.y: Update rules.
1951         * go-exp.y: Update rules.
1952         * f-exp.y: Update rules.
1953         * d-exp.y: Update rules.
1954         * c-exp.y: Update rules.
1955
1956 2019-04-04  Tom Tromey  <tom@tromey.com>
1957
1958         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1959         lex_operator, push_back>: New methods.
1960         Update all rules.
1961         (rust_parser::lex_hex, lex_escape): Rename and update.
1962         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1963         (rust_parser::lex_operator): Rename and update.
1964         (rust_parser::lex_number, rustyylex, rustyyerror)
1965         (rust_lex_test_init, rust_lex_test_sequence)
1966         (rust_lex_test_push_back, rust_lex_tests): Update.
1967         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1968         parameter.
1969         <lexptr, prev_lexptr>: New members.
1970         (lexptr, prev_lexptr): Don't declare.
1971         * parse.c (lexptr, prev_lexptr): Remove globals.
1972         (parse_exp_in_context): Update.
1973         * p-exp.y (yylex, yyerror): Update.
1974         * m2-exp.y (parse_number, yylex, yyerror): Update.
1975         * go-exp.y (lex_one_token, yyerror): Update.
1976         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1977         * d-exp.y (lex_one_token, yyerror): Update.
1978         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1979         (lex_one_token, yyerror): Update.
1980         * ada-lex.l (YY_INPUT): Update.
1981         (rewind_to_char): Update.
1982         * ada-exp.y (yyerror): Update.
1983
1984 2019-04-04  Tom Tromey  <tom@tromey.com>
1985
1986         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1987         * parser-defs.h (struct parser_state) <parser_state>: Add new
1988         parameter.
1989         <comma_terminates>: New member.
1990         (comma_terminates): Don't declare global.
1991         * parse.c (comma_terminates): Remove global.
1992         (parse_exp_in_context): Update.
1993         * p-exp.y (yylex): Update.
1994         * m2-exp.y (yylex): Update.
1995         * go-exp.y (lex_one_token): Update.
1996         * f-exp.y (yylex): Update.
1997         * d-exp.y (lex_one_token): Update.
1998         * c-exp.y (lex_one_token): Update.
1999         * ada-lex.l: Update.
2000
2001 2019-04-04  Tom Tromey  <tom@tromey.com>
2002
2003         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2004         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2005         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2006         * parser-defs.h (paren_depth): Don't declare.
2007         * parse.c (paren_depth): Remove global.
2008         (parse_exp_in_context): Update.
2009         * p-exp.y (paren_depth): New global.
2010         (pascal_parse): Initialize it.
2011         * m2-exp.y (paren_depth): New global.
2012         (m2_parse): Initialize it.
2013         * go-exp.y (paren_depth): New global.
2014         (go_parse): Initialize it.
2015         * f-exp.y (paren_depth): New global.
2016         (f_parse): Initialize it.
2017         * d-exp.y (paren_depth): New global.
2018         (d_parse): Initialize it.
2019         * c-exp.y (paren_depth): New global.
2020         (c_parse): Initialize it.
2021         * ada-lex.l (paren_depth): New global.
2022         (lexer_init): Initialize it.
2023
2024 2019-04-04  Tom Tromey  <tom@tromey.com>
2025
2026         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2027         (rust_parser::convert_ast_to_type)
2028         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2029         * parser-defs.h (struct parser_state) <parser_state>: Add
2030         parameters.  Initialize new members.
2031         <expression_context_block, expression_context_pc>: New members.
2032         * parse.c (expression_context_block, expression_context_pc):
2033         Remove globals.
2034         (parse_exp_in_context): Update.
2035         * p-exp.y: Update all rules.
2036         (yylex): Update.
2037         * m2-exp.y: Update all rules.
2038         (yylex): Update.
2039         * go-exp.y (yylex): Update.
2040         * f-exp.y (yylex): Update.
2041         * d-exp.y: Update all rules.
2042         (yylex): Update.
2043         * c-exp.y: Update all rules.
2044         (lex_one_token, classify_name, yylex, c_parse): Update.
2045         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2046
2047 2019-04-04  Tom Tromey  <tom@tromey.com>
2048
2049         * gdbarch.h, gdbarch.c: Rebuild.
2050         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2051         * stap-probe.h:
2052         (struct stap_parse_info): Replace "parser_state" with
2053         "expr_builder".
2054         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2055         (parser_state): New class.
2056         * parse.c (expr_builder): Rename.
2057         (expr_builder::release): Rename.
2058         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2059         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2060         (write_exp_elt_longcst, write_exp_elt_floatcst)
2061         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2062         (write_exp_string_vector, write_exp_bitstring)
2063         (write_exp_msymbol, mark_struct_expression)
2064         (write_dollar_variable)
2065         (insert_type_address_space, increase_expout_size): Replace
2066         "parser_state" with "expr_builder".
2067         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2068         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2069         "parser_state" with "expr_builder".
2070
2071 2019-04-04  Tom Tromey  <tom@tromey.com>
2072
2073         * rust-exp.y: Replace "parse_language" with method call.
2074         * p-exp.y:
2075         (yylex): Replace "parse_language" with method call.
2076         * m2-exp.y:
2077         (yylex): Replace "parse_language" with method call.
2078         * go-exp.y (classify_name): Replace "parse_language" with method
2079         call.
2080         * f-exp.y (yylex): Replace "parse_language" with method call.
2081         * d-exp.y (lex_one_token): Replace "parse_language" with method
2082         call.
2083         * c-exp.y:
2084         (lex_one_token, classify_name, yylex): Replace "parse_language"
2085         with method call.
2086         * ada-exp.y (find_primitive_type, type_char)
2087         (type_system_address): Replace "parse_language" with method call.
2088
2089 2019-04-04  Tom Tromey  <tom@tromey.com>
2090
2091         * rust-exp.y: Replace "parse_gdbarch" with method call.
2092         * parse.c (write_dollar_variable, insert_type_address_space):
2093         Replace "parse_gdbarch" with method call.
2094         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2095         call.
2096         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2097         call.
2098         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2099         "parse_gdbarch" with method call.
2100         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2101         with method call.
2102         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2103         "parse_gdbarch" with method call.
2104         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2105         "parse_gdbarch" with method call.
2106         * c-exp.y (parse_type, parse_number, classify_name): Replace
2107         "parse_gdbarch" with method call.
2108         * ada-lex.l: Replace "parse_gdbarch" with method call.
2109         * ada-exp.y (parse_type, find_primitive_type, type_char)
2110         (type_system_address): Replace "parse_gdbarch" with method call.
2111
2112 2019-04-04  Tom Tromey  <tom@tromey.com>
2113
2114         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2115         * stap-probe.c (stap_parse_argument): Update.
2116         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2117         initial_size parameter.
2118         * rust-exp.y (rust_lex_tests): Update.
2119         * parse.c (parser_state): Update.
2120         (parse_exp_in_context): Update.
2121         * parser-defs.h (struct parser_state) <parser_state>: Remove
2122         "initial_size" parameter.
2123
2124 2019-04-04  Tom Tromey  <tom@tromey.com>
2125
2126         * parser-defs.h (increase_expout_size): Don't declare.
2127         * parse.c (increase_expout_size): Now static.
2128
2129 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2130
2131         * gnu-nat.c (gnu_nat_target::wait): Fix
2132         target_waitstatus_to_string call.
2133
2134 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2135
2136         * eval.c (evaluate_subexp_standard): Handle internal functions
2137         during Fortran function call handling.
2138
2139 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2140
2141         * NEWS: Mention new internal functions.
2142         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2143         (read_base_type): Use dwarf2_init_complex_target_type.
2144         * value.c (creal_internal_fn): New function.
2145         (cimag_internal_fn): New function.
2146         (_initialize_values): Register new internal functions.
2147
2148 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2149
2150         * infrun.c (stop_all_threads): If debug_infrun, always
2151         trace the wait status after wait_one, using
2152         target_waitstatus_to_string and target_pid_to_str.
2153         (handle_inferior_event): Replace various trace of
2154         wait status kind by a single trace.
2155         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2156         wait status kind image by target_waitstatus_to_string.
2157         * target/waitstatus.c (target_waitstatus_to_string): Fix
2158         obsolete comment.
2159
2160 2019-04-01  Tom Tromey  <tromey@adacore.com>
2161
2162         PR symtab/23331:
2163         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2164
2165 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2166             Pedro Alves  <palves@redhat.com>
2167
2168         * top.c (quit_force): Call 'finalize_values'.
2169         * value.c (finalize_values): New function.
2170         * value.h (finalize_values): Declare.
2171
2172 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2173
2174         * NEWS: Announce $_gdb_major and $_gdb_minor.
2175
2176         * top.c (init_gdb_version_vars): New function.
2177         (gdb_init): Call init_gdb_version_vars.
2178
2179 2019-03-29  Tom Tromey  <tromey@adacore.com>
2180
2181         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2182         help text.  Remove dead code.
2183
2184 2019-03-29  Keith Seitz  <keiths@redhat.com>
2185
2186         From Siddhesh Poyarekar:
2187         * f-lang.h (f77_get_upperbound): Return LONGEST.
2188         (f77_get_lowerbound): Likewise.
2189         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2190         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2191         print them.
2192         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2193         plongest to format print it.
2194         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2195         (f77_get_upperbound): Likewise.
2196         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2197         LOWER_BOUND to LONGEST.
2198         (f77_create_arrayprint_offset_tbl): Likewise.
2199
2200 2019-03-29  Keith Seitz  <keiths@redhat.com>
2201
2202         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2203         %s/pulongest for TYPE_LENGTH instead of %d in format
2204         strings.
2205         * ada-typerint.c (ada_print_type): Likewise.
2206         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2207         * compile/compile-c-support.c (generate_register_struct): Likewise.
2208         * gdbtypes.c (recursive_dump_type): Likewise.
2209         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2210         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2211         instead of %d in format strings.
2212         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2213         to std::min to ULONGEST.
2214         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2215         instead of %d in format strings.
2216         * tracepoint.c (info_scope_command): Likewise.
2217         * typeprint.c (print_offset_data::update)
2218         (print_offset_data::finish): Likewise.
2219         * xtensa-tdep.c (xtensa_store_return_value)
2220         (xtensa_push_dummy_call): Likewise.
2221
2222 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2223
2224         * windows-nat.c (display_selector): Fixed format specifications
2225         for 64-bit Cygwin.
2226
2227 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2228
2229         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2230
2231 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2232
2233         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2234         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2235         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2236         (nios2_linux_init_abi): Install it.
2237
2238 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2239
2240         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2241
2242 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2243
2244         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2245
2246 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2247             Tom Tromey  <tromey@adacore.com>
2248
2249         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2250
2251 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2252
2253         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2254         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2255         method to compute the bounds of range types. Also print "[evaluated]"
2256         if the bounds' values come from a dynamic evaluation.
2257
2258 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2261         whitespace when pretty printing is on.
2262
2263 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2264
2265         * ppc-linux-nat.c: Add include.
2266
2267 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2268
2269         * NEWS: Mention AArch64 Pointer Authentication.
2270
2271 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2272
2273         * arm-linux-nat.c: Add include.
2274
2275 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2276
2277         * source-cache.c (source_cache::get_source_lines): Re-read
2278         fullname after calling open_source_file.
2279
2280 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2281
2282         * NEWS: Mention TLS support for FreeBSD.
2283
2284 2019-03-25  Tom Tromey  <tromey@adacore.com>
2285
2286         * minsyms.c (BUNCH_SIZE): Update comment.
2287         (~minimal_symbol_reader): Remove old comment.
2288         (compact_minimal_symbols): Update comment.
2289         (minimal_symbol_reader::install): Remove old comment.  Update
2290         other comments.
2291
2292 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2293
2294         * s390-linux-nat.c: Add include.
2295
2296 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2297
2298         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2299         Call linux_get_hwcap.
2300         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2301         Likewise.
2302         (aarch64_linux_get_hwcap): Remove function.
2303         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2304         declaration.
2305         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2306         linux_get_hwcap.
2307         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2308         * linux-tdep.c (linux_get_hwcap): Add function.
2309         (linux_get_hwcap2): Likewise.
2310         * linux-tdep.h (linux_get_hwcap): Add declaration.
2311         (linux_get_hwcap2): Likewise.
2312         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2313         (ppc_linux_get_hwcap2): Likewise.
2314         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2315         linux_get_hwcap.
2316         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2317         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2318         (ppc_linux_nat_target::read_description): Likewise.
2319         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2320         * s390-linux-nat.c: Likewise.
2321         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2322
2323 2019-03-24  Tom Tromey  <tom@tromey.com>
2324
2325         * ada-lang.c (standard_lookup): Simplify initialization.
2326         (ada_lookup_symbol_nonlocal): Simplify return.
2327         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2328         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2329         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2330         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2331         initialization.
2332         * solib.c (solib_global_lookup): Simplify.
2333         * symtab.c (null_block_symbol): Remove.
2334         (symbol_cache_lookup): Simplify returns.
2335         (lookup_language_this): Simplify returns.
2336         (lookup_symbol_aux): Simplify return.
2337         (lookup_local_symbol): Simplify returns.
2338         (lookup_global_symbol_from_objfile): Simplify return.
2339         (lookup_symbol_in_objfile_symtabs)
2340         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2341         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2342         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2343         * cp-namespace.c (cp_lookup_bare_symbol)
2344         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2345         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2346         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2347         (cp_lookup_symbol_via_imports): Simplify initialization.
2348         (find_symbol_in_baseclass): Likewise.
2349         * symtab.h (null_block_symbol): Remove.
2350         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2351         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2352         (d_lookup_symbol_module): Likewise.
2353         (find_symbol_in_baseclass): Simplify initialization.
2354
2355 2019-03-24  Tom Tromey  <tom@tromey.com>
2356
2357         * expression.h: Don't include symtab.h.
2358         (struct block): Forward declare.
2359
2360 2019-03-24  Tom Tromey  <tom@tromey.com>
2361
2362         * c-exp.y (typebase): Remove casts.
2363         * gdbtypes.c (lookup_unsigned_typename, )
2364         (lookup_signed_typename): Remove cast.
2365         * eval.c (parse_to_comma_and_eval): Remove cast.
2366         * parse.c (write_dollar_variable): Remove cast.
2367         * block.h (struct block) <superblock>: Now const.
2368         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2369         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2370         (map_block): Make "block" const.
2371         * symfile.h (struct quick_symbol_functions)
2372         <map_matching_symbols>: Constify block argument to "callback".
2373         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2374         const.
2375         (find_pc_sect_compunit_symtab): Make "b" const.
2376         (find_symbol_at_address): Likewise.
2377         (search_symbols): Likewise.
2378         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2379         (dw2_debug_names_lookup_symbol): Likewise.
2380         (dw2_map_matching_symbols): Update.
2381         * p-valprint.c (pascal_val_print): Remove "block".
2382         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2383         (aux_add_nonlocal_symbols): Make "block" const.
2384         (resolve_subexp): Remove cast.
2385         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2386         const.
2387         (iterate_over_file_blocks): Likewise.
2388         * f-exp.y (%union) <bval>: Remove.
2389         * coffread.c (patch_opaque_types): Make "b" const.
2390         * spu-tdep.c (spu_catch_start): Make "block" const.
2391         * c-valprint.c (print_unpacked_pointer): Remove "block".
2392         * symmisc.c (dump_symtab_1): Make "b" const.
2393         (block_depth): Make "block" const.
2394         * d-exp.y (%union) <bval>: Remove.
2395         * cp-support.h (cp_lookup_rtti_type): Update.
2396         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2397         * psymtab.c (psym_lookup_symbol): Make "block" const.
2398         (maintenance_check_psymtabs): Make "b" const.
2399         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2400         (enumerate_locals, enumerate_args): Update.
2401         * python/py-symtab.c (stpy_global_block): Make "block" const.
2402         (stpy_static_block): Likewise.
2403         * inline-frame.c (block_starting_point_at): Make "new_block"
2404         const.
2405         * block.c (find_block_in_blockvector): Make return type const.
2406         (blockvector_for_pc_sect): Make "b" const.
2407         (find_block_in_blockvector): Make "b" const.
2408
2409 2019-03-23  Tom Tromey  <tom@tromey.com>
2410
2411         * varobj.c (varobj_create): Update.
2412         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2413         * printcmd.c (display_command, do_one_display): Don't reset
2414         innermost_block.
2415         * parser-defs.h (enum innermost_block_tracker_type): Move to
2416         expression.h.
2417         (innermost_block): Update comment.
2418         * parse.c (parse_exp_1): Add tracker_types parameter.
2419         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2420         tracker_types parameter.  Reset innermost_block.
2421         (parse_exp_in_context): Remove.
2422         (parse_expression_for_completion): Update.
2423         * objfiles.c (~objfile): Don't reset expression_context_block or
2424         innermost_block.
2425         * expression.h (enum innermost_block_tracker_type): Move from
2426         parser-defs.h.
2427         (parse_exp_1): Add tracker_types parameter.
2428         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2429         reset innermost_block.
2430
2431 2019-03-23  Tom Tromey  <tom@tromey.com>
2432
2433         * objfiles.h: Include bcache.h.
2434
2435 2019-03-23  Tom Tromey  <tom@tromey.com>
2436
2437         * linespec.c (get_current_search_block): Use
2438         scoped_restore_current_language.
2439         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2440
2441 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2442             Jiong Wang  <jiong.wang@arm.com>
2443
2444         * aarch64-linux-tdep.c
2445         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2446         section.
2447         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2448
2449 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2450             Jiong Wang  <jiong.wang@arm.com>
2451
2452         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2453         instructions.
2454         (aarch64_analyze_prologue_test): Add PACIASP test.
2455         (aarch64_prologue_prev_register): Unmask PC value.
2456
2457 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2458             Jiong Wang  <jiong.wang@arm.com>
2459
2460         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2461         (aarch64_dwarf2_prev_register): Unmask PC value.
2462         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2463         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2464         DW_CFA_AARCH64_negate_ra_state.
2465         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2466
2467 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2468             Jiong Wang  <jiong.wang@arm.com>
2469
2470         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2471         registers.
2472         (aarch64_pseudo_register_name): Likewise.
2473         (aarch64_pseudo_register_type): Likewise.
2474         (aarch64_pseudo_register_reggroup_p): Likewise.
2475         (aarch64_gdbarch_init): Add pauth registers.
2476         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2477         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2478         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2479         (struct gdbarch_tdep): Add regnum for ra_state.
2480
2481 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2482             Jiong Wang  <jiong.wang@arm.com>
2483
2484         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2485
2486 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2487             Jiong Wang  <jiong.wang@arm.com>
2488
2489         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2490         function.
2491         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2492         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2493         (aarch64_gdbarch_init): Add puth registers.
2494         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2495         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2496         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2497
2498 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2499             Jiong Wang  <jiong.wang@arm.com>
2500
2501         * aarch64-linux-nat.c
2502         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2503         * aarch64-linux-tdep.c
2504         (aarch64_linux_core_read_description): Likewise.
2505         (aarch64_linux_get_hwcap): New function.
2506         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2507         (aarch64_linux_get_hwcap): New declaration.
2508
2509 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2510             Jiong Wang  <jiong.wang@arm.com>
2511
2512         * aarch64-linux-nat.c
2513         (aarch64_linux_nat_target::read_description): Add pauth param.
2514         * aarch64-linux-tdep.c
2515         (aarch64_linux_core_read_description): Likewise.
2516         * aarch64-tdep.c (struct target_desc): Add in pauth.
2517         (aarch64_read_description): Add pauth param.
2518         (aarch64_gdbarch_init): Likewise.
2519         * aarch64-tdep.h (aarch64_read_description): Likewise.
2520         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2521         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2522         * features/Makefile: Add new files.
2523         * features/aarch64-pauth.c: New file.
2524         * features/aarch64-pauth.xml: New file.
2525
2526 2019-03-20  Tom Tromey  <tromey@adacore.com>
2527
2528         * infrun.c (handle_inferior_event): Rename from
2529         handle_inferior_event_1.  Create a scoped_value_mark.
2530         (handle_inferior_event): Remove.
2531
2532 2019-03-19  Tom Tromey  <tromey@adacore.com>
2533
2534         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2535         * infrun.h (print_stop_event): Add "displays" parameter.
2536         * infrun.c (print_stop_event): Add "displays" parameter.
2537
2538 2019-03-19  Pedro Alves  <palves@redhat.com>
2539
2540         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2541         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2542         to -1.  Fix TABs vs spaces.
2543         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2544         * tui/tui-out.h (tui_ui_out) Add intro comments.
2545         <m_line, m_start_of_line>: In-class initialize, and add describing
2546         comment.
2547
2548 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2549
2550         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2551         variable names.
2552         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2553
2554 2019-03-18  Pedro Alves  <palves@redhat.com>
2555             Eli Zaretskii <eliz@gnu.org>
2556
2557         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2558         m_line and m_start_of_line.
2559
2560 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2561
2562         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2563         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2564         it returns a newline.  This fixes a regression in TU mode, whereby
2565         the next line is output on the same screen line as the user input.
2566
2567 2019-03-18  Tom Tromey  <tromey@adacore.com>
2568
2569         * minsyms.c (minimal_symbol_reader::install): Remove call to
2570         obstack_blank.
2571
2572 2019-03-18  Pedro Alves  <palves@redhat.com>
2573
2574         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2575         New globals.
2576         (apply_style): New, factored out from ...
2577         (apply_ansi_escape): ... this.  Handle reverse video mode.
2578         (tui_set_reverse_mode): New function.
2579         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2580         * tui/tui-winsource.c (tui_show_source_line): Use
2581         tui_set_reverse_mode instead of setting A_STANDOUT.
2582         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2583         New setter methods.
2584
2585 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2586
2587         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2588         Handle tabs.
2589
2590 2019-03-18  Tom Tromey  <tromey@adacore.com>
2591
2592         * ada-lang.c (empty_array): Add "high" parameter.
2593         (ada_evaluate_subexp): Update.
2594
2595 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2596
2597         * unittests/string_view-selftests.c: Define
2598         _initialize_string_view_selftests unconditionally.
2599
2600 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2601
2602         PR gdb/24350
2603         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2604
2605 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2606
2607         PR gdb/24351
2608         * windows-nat.c (display_selector): Fix format specifiers.
2609
2610 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2611
2612         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2613         tui_refill_source_window instead of tui_refresh_win, to update the
2614         current execution line.  This fixes redisplay of the current line
2615         when stepping through the code with "next" or "step".
2616
2617 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2618
2619         * source-cache.c (source_cache::get_source_lines): Call
2620         find_source_lines to initialize s->nlines.  This fixes vertical
2621         scrolling of TUI source window when the DOWN arrow is pressed.
2622
2623 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2624
2625         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2626         linux-thread-db.c (_initialize_thread_db): Likewise.
2627
2628 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2629
2630         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2631         wclrtoeol in tui_show_source_line".  This reverts changes made in
2632         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2633
2634 2019-03-15  Tom Tromey  <tom@tromey.com>
2635
2636         * symtab.h (struct minimal_symbol): Derive from
2637         general_symbol_info.
2638         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2639         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2640         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2641         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2642         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2643         (MSYMBOL_SEARCH_NAME): Update.
2644         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2645         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2646         * minsyms.c (minimal_symbol_reader::record_full): Update.
2647
2648 2019-03-15  Tom Tromey  <tom@tromey.com>
2649
2650         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2651
2652 2019-03-15  Tom Tromey  <tom@tromey.com>
2653
2654         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2655         unique_xmalloc_ptr.
2656         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2657         Update.
2658         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2659         (build_minimal_symbol_hash_tables)
2660         (minimal_symbol_reader::install): Update.
2661
2662 2019-03-15  Tom Tromey  <tom@tromey.com>
2663
2664         * symtab.c (create_demangled_names_hash): Update.
2665         (symbol_set_names): Update.
2666         * objfiles.h (struct objfile_per_bfd_storage)
2667         <demangled_names_hash>: Now an htab_up.
2668         * objfiles.c (objfile_per_bfd_storage): Simplify.
2669
2670 2019-03-15  Tom Tromey  <tom@tromey.com>
2671
2672         * objfiles.h (struct objfile_per_bfd_storage): Declare
2673         destructor.
2674         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2675         New.
2676         (get_objfile_bfd_data): Use new.  Don't initialize
2677         language_of_main.
2678         (free_objfile_per_bfd_storage): Remove.
2679         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2680
2681 2019-03-15  Tom Tromey  <tom@tromey.com>
2682
2683         * symfile.c (reread_symbols): Update.
2684         * objfiles.c (objfile::objfile): Update.
2685         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2686         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2687         comment.
2688         (minimal_symbol_reader::install): Update.
2689         (terminate_minimal_symbol_table): Remove.
2690         * jit.c (jit_object_close_impl): Update.
2691
2692 2019-03-15  Tom Tromey  <tom@tromey.com>
2693
2694         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2695         initializations.
2696
2697 2019-03-15  Tom Tromey  <tom@tromey.com>
2698
2699         * objfiles.h (struct objfile_per_bfd_storage)
2700         <demangled_hash_languages>: Now a bitset.
2701         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2702         (lookup_minimal_symbol): Update.
2703
2704 2019-03-15  Tom Tromey  <tom@tromey.com>
2705
2706         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2707         Don't return the symbol.
2708         * coffread.c (record_minimal_symbol): Use record_full.
2709
2710 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2711
2712         The MS-Windows port of ncurses fails to switch to a color pair if
2713         one or both of the colors are the implicit default colors.  This
2714         change records the default colors when TUI is initialized, and
2715         then specifies them explicitly when a color pair uses the default
2716         colors.  This allows color styling in TUI mode on MS-Windows.
2717
2718         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2719         ncurses_norm_attr.
2720         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2721         colors in ncurses_norm_attr.
2722         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2723         "none", replace it with the default color recorded in
2724         ncurses_norm_attr.
2725
2726 2019-03-14  Tom Tromey  <tromey@adacore.com>
2727
2728         * source-cache.h (class source_cache) <get_source_lines>: Return
2729         std::string.
2730         * source-cache.c (source_cache::extract_lines): Handle case where
2731         first_pos==npos.  Return std::string.
2732         (source_cache::get_source_lines): Update.
2733
2734 2019-03-14  Tom Tromey  <tromey@adacore.com>
2735
2736         * NEWS: Add item for "style sources" commands.
2737         * source-cache.c (source_cache::get_source_lines): Check
2738         source_styling.
2739         * cli/cli-style.c (source_styling): New global.
2740         (_initialize_cli_style): Add "style sources" commands.
2741         (show_style_sources): New function.
2742         * cli/cli-style.h (source_styling): Declare.
2743
2744 2019-03-14  Pedro Alves  <palves@redhat.com>
2745             Tom Tromey  <tromey@adacore.com>
2746
2747         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2748         * tui/tui-winsource.c (tui_refill_source_window): New function,
2749         from...
2750         (tui_horizontal_source_scroll): ... here.  Move some logic.
2751         * cli/cli-style.c (set_style_enabled): Notify new observable.
2752         * tui/tui-hooks.c (tui_redisplay_source): New function.
2753         (tui_attach_detach_observers): Attach or detach
2754         tui_redisplay_source.
2755         * observable.h (source_styling_changed): New observable.
2756         * observable.c: Define source_styling_changed observable.
2757
2758 2019-03-13  Tom Tromey  <tromey@adacore.com>
2759
2760         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2761         (i386_gnu_nat_target::store_registers): Update.
2762         * target-debug.h (target_debug_print_std_string): New macro.
2763         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2764         * windows-tdep.c (display_one_tib): Update.
2765         * tui/tui-stack.c (tui_make_status_line): Update.
2766         * top.c (print_inferior_quit_action): Update.
2767         * thread.c (thr_try_catch_cmd): Update.
2768         (add_thread_with_info): Update.
2769         (thread_target_id_str): Update.
2770         (thr_try_catch_cmd): Update.
2771         (thread_command): Update.
2772         (thread_find_command): Update.
2773         * record-btrace.c (record_btrace_target::info_record)
2774         (record_btrace_resume_thread, record_btrace_target::resume)
2775         (record_btrace_cancel_resume, record_btrace_step_thread)
2776         (record_btrace_target::wait, record_btrace_target::wait)
2777         (record_btrace_target::wait, record_btrace_target::stop): Update.
2778         * progspace.c (print_program_space): Update.
2779         * process-stratum-target.c
2780         (process_stratum_target::thread_address_space): Update.
2781         * linux-fork.c (linux_fork_mourn_inferior)
2782         (detach_checkpoint_command, info_checkpoints_command)
2783         (linux_fork_context): Update.
2784         (linux_fork_detach): Update.
2785         (class scoped_switch_fork_info): Update.
2786         (delete_checkpoint_command): Update.
2787         * infrun.c (follow_fork_inferior): Update.
2788         (follow_fork_inferior): Update.
2789         (proceed_after_vfork_done): Update.
2790         (handle_vfork_child_exec_or_exit): Update.
2791         (follow_exec): Update.
2792         (displaced_step_prepare_throw): Update.
2793         (displaced_step_restore): Update.
2794         (start_step_over): Update.
2795         (resume_1): Update.
2796         (clear_proceed_status_thread): Update.
2797         (proceed): Update.
2798         (print_target_wait_results): Update.
2799         (do_target_wait): Update.
2800         (context_switch): Update.
2801         (stop_all_threads): Update.
2802         (restart_threads): Update.
2803         (finish_step_over): Update.
2804         (handle_signal_stop): Update.
2805         (switch_back_to_stepped_thread): Update.
2806         (keep_going_pass_signal): Update.
2807         (print_exited_reason): Update.
2808         (normal_stop): Update.
2809         * inferior.c (inferior_pid_to_str): Change return type.
2810         (print_selected_inferior): Update.
2811         (add_inferior): Update.
2812         (detach_inferior): Update.
2813         * dummy-frame.c (fprint_dummy_frames): Update.
2814         * dcache.c (dcache_info_1): Update.
2815         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2816         (btrace_fetch, btrace_clear): Update.
2817         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2818         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2819         type.
2820         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2821         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2822         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2823         * gdbarch.c, gdbarch.h: Rebuild.
2824         * gdbarch.sh (core_pid_to_str): Change return type.
2825         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2826         return type.
2827         (windows_nat_target::pid_to_str): Change return type.
2828         (windows_delete_thread): Update.
2829         (windows_nat_target::attach): Update.
2830         (windows_nat_target::files_info): Update.
2831         * target-delegates.c: Rebuild.
2832         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2833         return type.
2834         (sol_thread_target::pid_to_str): Change return type.
2835         * remote.c (class remote_target) <pid_to_str>: Change return
2836         type.
2837         (remote_target::pid_to_str): Change return type.
2838         (extended_remote_target::attach, remote_target::remote_stop_ns)
2839         (remote_target::remote_notif_remove_queued_reply)
2840         (remote_target::push_stop_reply, remote_target::disable_btrace):
2841         Update.
2842         (extended_remote_target::attach): Update.
2843         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2844         type.
2845         (gdbsim_target::pid_to_str): Change return type.
2846         * ravenscar-thread.c (struct ravenscar_thread_target)
2847         <pid_to_str>: Change return type.
2848         (ravenscar_thread_target::pid_to_str): Change return type.
2849         * procfs.c (class procfs_target) <pid_to_str>: Change return
2850         type.
2851         (procfs_target::pid_to_str): Change return type.
2852         (procfs_target::attach): Update.
2853         (procfs_target::detach): Update.
2854         (procfs_target::fetch_registers): Update.
2855         (procfs_target::store_registers): Update.
2856         (procfs_target::wait): Update.
2857         (procfs_target::files_info): Update.
2858         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2859         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2860         return type.
2861         (nto_procfs_target::pid_to_str): Change return type.
2862         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2863         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2864         return type.
2865         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2866         (exit_lwp): Update.
2867         (attach_proc_task_lwp_callback, get_detach_signal)
2868         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2869         (linux_nat_target::resume, wait_lwp, stop_callback)
2870         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2871         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2872         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2873         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2874         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2875         type.
2876         (inf_ptrace_target::attach): Update.
2877         (inf_ptrace_target::files_info): Update.
2878         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2879         type.
2880         (go32_nat_target::pid_to_str): Change return type.
2881         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2882         (gnu_nat_target::wait): Update.
2883         (gnu_nat_target::wait): Update.
2884         (gnu_nat_target::resume): Update.
2885         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2886         (fbsd_nat_target::wait): Update.
2887         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2888         type.
2889         (darwin_nat_target::attach): Update.
2890         * corelow.c (class core_target) <pid_to_str>: Change return type.
2891         (core_target::pid_to_str): Change return type.
2892         * target.c (normal_pid_to_str): Change return type.
2893         (default_pid_to_str): Likewise.
2894         (target_pid_to_str): Change return type.
2895         (target_translate_tls_address): Update.
2896         (target_announce_detach): Update.
2897         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2898         return type.
2899         (bsd_uthread_target::pid_to_str): Change return type.
2900         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2901         type.
2902         (bsd_kvm_target::pid_to_str): Change return type.
2903         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2904         return type.
2905         (aix_thread_target::pid_to_str): Change return type.
2906         * target.h (struct target_ops) <pid_to_str>: Change return type.
2907         (target_pid_to_str, normal_pid_to_str): Likewise.
2908         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2909         type.
2910         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2911         type.
2912         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2913         return type.
2914         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2915         type.
2916         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2917         type.
2918         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2919         return type.
2920
2921 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2922
2923         * NEWS: Mention that the new default MI version is 3.  Mention
2924         changes to the output of commands and events that deal with
2925         multi-location breakpoints.
2926         * breakpoint.c: Include "mi/mi-out.h".
2927         (print_one_breakpoint): Change output syntax if using MI version
2928         >= 3.
2929         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2930         New.
2931         (mi_multi_location_breakpoint_output_fixed): New.
2932         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2933         (mi_cmd_fix_multi_location_breakpoint_output): New.
2934         (mi_multi_location_breakpoint_output_fixed): New.
2935         * mi/mi-cmds.c (mi_cmds): Register command
2936         -fix-multi-location-breakpoint-output.
2937         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2938         interpreter "mi".
2939
2940 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2941
2942         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2943         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2944         instantiate mi_ui_out based on interpreter name.
2945         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2946         * mi/mi-main.c (mi_load_progress): Likewise.
2947
2948 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2949
2950         * NEWS: Combine separate "New targets" sections for 8.3.
2951
2952 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2953
2954         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2955         (ppcfbsd_init_abi): Install gdbarch
2956         "fetch_tls_load_module_address" and "get_thread_local_address"
2957         methods.
2958
2959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2960
2961         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2962         (riscv_fbsd_init_abi): Install gdbarch
2963         "fetch_tls_load_module_address" and "get_thread_local_address"
2964         methods.
2965
2966 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2967
2968         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2969         (i386fbsd_init_abi): Install gdbarch
2970         "fetch_tls_load_module_address" and "get_thread_local_address"
2971         methods.
2972
2973 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2974
2975         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2976         (amd64fbsd_init_abi): Install gdbarch
2977         "fetch_tls_load_module_address" and "get_thread_local_address"
2978         methods.
2979
2980 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2981
2982         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2983         (struct fbsd_pspace_data): New type.
2984         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2985         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2986         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2987         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2988         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2989
2990 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2991
2992         * gdbtypes.c (lookup_struct_elt): New function.
2993         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2994         * gdbtypes.h (struct struct_elt): New type.
2995         (lookup_struct_elt): New prototype.
2996
2997 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2998
2999         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3000         remove disabled code block.
3001
3002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3003
3004         * gdbarch.sh (get_thread_local_address): New method.
3005         * gdbarch.h, gdbarch.c: Regenerate.
3006         * target.c (target_translate_tls_address): Use
3007         gdbarch_get_thread_local_address if present instead of
3008         target::get_thread_local_address.
3009
3010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3011
3012         * target.h (target::get_thread_local_address): Update comment.
3013
3014 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3015
3016         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3017         objfile->separate_debug_objfile_backlink if not NULL.
3018
3019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3020
3021         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3022         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3023         (amd64bsd_store_inferior_registers): Likewise.
3024         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3025         Enable segment base registers.
3026         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3027         PT_GETFSBASE and PT_GETGSBASE.
3028         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3029         PT_SETGSBASE.
3030         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3031         segment base registers.
3032         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3033
3034 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3035
3036         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3037         Update calls to i386_target_description to add 'segments'
3038         parameter.
3039         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3040         add segment base registers.
3041         * arch/i386.c (i386_create_target_description): Add 'segments'
3042         parameter to enable segment base registers.
3043         * arch/i386.h (i386_create_target_description): Likewise.
3044         * features/i386/32bit-segments.xml: New file.
3045         * features/i386/32bit-segments.c: Generate.
3046         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3047         call to i386_target_description to add 'segments' parameter.
3048         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3049         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3050         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3051         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3052         if feature is present.
3053         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3054         Add 'segments' parameter to call to i386_target_description.
3055         (i386_target_description): Add 'segments' parameter to enable
3056         segment base registers.
3057         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3058         to call to i386_target_description.
3059         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3060         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3061         Define I386_NUM_REGS.
3062         (i386_target_description): Add 'segments' parameter to enable
3063         segment base registers.
3064
3065 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3066
3067         PR/24325
3068         * source-cache.c: #undef open and close, to avoid unresolved
3069         externals during linking.
3070
3071 2019-03-12  Tom Tromey  <tromey@adacore.com>
3072
3073         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3074         const.  Add initializers.
3075         (_initialize_remote): Don't initialize ptid globals.
3076
3077 2019-03-12  Pedro Alves  <palves@redhat.com>
3078
3079         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3080
3081 2019-03-12  Pedro Alves  <palves@redhat.com>
3082
3083         * cp-name-parser.y (main): Remove unused 'len' variable.
3084
3085 2019-03-12  Tom Tromey  <tromey@adacore.com>
3086
3087         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3088         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3089
3090 2019-03-12  Tom Tromey  <tromey@adacore.com>
3091
3092         * linux-nat.c (iterate_over_lwps): Update.
3093         (stop_callback): Remove parameter.
3094         (stop_wait_callback, detach_callback, resume_set_callback)
3095         (select_singlestep_lwp_callback, set_ignore_sigint)
3096         (status_callback, resumed_callback, resume_clear_callback)
3097         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3098         data parameter.
3099         (linux_nat_target::detach, linux_nat_target::resume)
3100         (linux_stop_and_wait_all_lwps, select_event_lwp)
3101         (linux_nat_filter_event, linux_nat_wait_1)
3102         (linux_nat_target::kill, linux_nat_target::stop)
3103         (linux_nat_target::stop): Update.
3104         (linux_nat_resume_callback): Change type.
3105         (resume_stopped_resumed_lwps, count_events_callback)
3106         (select_event_lwp_callback): Likewise.
3107         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3108         * arm-linux-nat.c (struct update_registers_data): Remove.
3109         (update_registers_callback): Change type.
3110         (arm_linux_insert_hw_breakpoint1): Update.
3111         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3112         parameter.
3113         (x86_linux_dr_set_addr): Update.
3114         (x86_linux_dr_set_control): Update.
3115         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3116         (iterate_over_lwps): Use gdb::function_view.
3117         * nat/aarch64-linux-hw-point.c (struct
3118         aarch64_dr_update_callback_param): Remove.
3119         (debug_reg_change_callback): Change type.
3120         (aarch64_notify_debug_reg_change): Update.
3121         * s390-linux-nat.c (s390_refresh_per_info): Update.
3122
3123 2019-03-11  Tom Tromey  <tromey@adacore.com>
3124
3125         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3126         redundant assignment to "this_cu".
3127
3128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3129
3130         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3131
3132 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3133
3134         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3135         from...
3136         (rank_one_type): ... this.
3137
3138 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3139
3140         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3141         from...
3142         (rank_one_type): ... this.
3143
3144 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3145
3146         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3147         from...
3148         (rank_one_type): ... this.
3149
3150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3151
3152         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3153         from...
3154         (rank_one_type): ... this.
3155
3156 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3157
3158         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3159         from...
3160         (rank_one_type): ... this.
3161
3162 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3163
3164         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3165         from...
3166         (rank_one_type): ... this.
3167
3168 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3169
3170         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3171         from...
3172         (rank_one_type): ... this.
3173
3174 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3175
3176         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3177         from...
3178         (rank_one_type): ... this.
3179
3180 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3181
3182         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3183         from...
3184         (rank_one_type): ... this.
3185
3186 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3187
3188         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3189         from...
3190         (rank_one_type): ... this.
3191
3192 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3193
3194         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3195         from...
3196         (rank_one_type): ... this.
3197
3198 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3199
3200         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3201         from...
3202         (rank_one_type): ... this.
3203
3204 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3205
3206         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3207         inferior-events' shows the example events.
3208
3209 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3210
3211         Support styling on native MS-Windows console
3212
3213         PR/24315
3214         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3215         on MS-Windows if $TERM is not defined.
3216
3217         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3218
3219         * posix-hdep.c (gdb_console_fputs):
3220         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3221         functions.
3222         * ui-file.h (gdb_console_fputs): Add prototype.
3223
3224         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3225         back to fputs only if the former returns zero.
3226
3227 2019-03-07  Tom Tromey  <tom@tromey.com>
3228
3229         * symmisc.c (print_symbol_bcache_statistics): Update.
3230         (print_objfile_statistics): Update.
3231         * symfile.c (allocate_symtab): Update.
3232         * stabsread.c: Don't include bcache.h.
3233         * psymtab.h (struct psymbol_bcache): Don't declare.
3234         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3235         (psymbol_bcache_init, psymbol_bcache_free)
3236         (psymbol_bcache_get_bcache): Don't declare.
3237         * psymtab.c (struct psymbol_bcache): Remove.
3238         (psymtab_storage::psymtab_storage): Update.
3239         (psymtab_storage::~psymtab_storage): Update.
3240         (psymbol_bcache_init, psymbol_bcache_free)
3241         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3242         (add_psymbol_to_bcache): Update.
3243         (allocate_psymtab): Update.
3244         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3245         macro_cache>: No longer pointers.
3246         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3247         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3248         * macrotab.c (macro_bcache): Update.
3249         * macroexp.c: Don't include bcache.h.
3250         * gdbtypes.c (check_types_worklist): Update.
3251         (types_deeply_equal): Remove TRY/CATCH.  Update.
3252         * elfread.c (elf_symtab_read): Update.
3253         * dwarf2read.c: Don't include bcache.h.
3254         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3255         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3256         (print_bcache_statistics, bcache_memory_used): Don't declare.
3257         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3258         methods.  Rename all data members.
3259         * bcache.c (struct bcache): Move to bcache.h.
3260         (bcache::expand_hash_table): Rename from expand_hash_table.
3261         (bcache): Remove.
3262         (bcache::insert): Rename from bcache_full.
3263         (bcache::compare): Rename from bcache_compare.
3264         (bcache_xmalloc): Remove.
3265         (bcache::~bcache): Rename from bcache_xfree.
3266         (bcache::print_statistics): Rename from print_bcache_statistics.
3267         (bcache::memory_used): Rename from bcache_memory_used.
3268
3269 2019-03-07  Pedro Alves  <palves@redhat.com>
3270
3271         * infrun.c (normal_stop): Also check for
3272         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3273
3274 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * f-lang.c (value_from_host_double): Moved to...
3277         * value.c (value_from_host_double): ...here.
3278         * value.h (value_from_host_double): Declare.
3279         * guile/scm-math.c (vlscm_convert_typed_number): Use
3280         value_from_host_double.
3281         (vlscm_convert_number): Likewise.
3282         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3283         * python/py-value.c (convert_value_from_python): Likewise.
3284
3285 2019-03-06  Tom Tromey  <tom@tromey.com>
3286
3287         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3288
3289 2019-03-06  Tom Tromey  <tom@tromey.com>
3290
3291         * utils.h (free_current_contents): Don't declare.
3292         * utils.c (free_current_contents): Remove.
3293
3294 2019-03-06  Tom Tromey  <tom@tromey.com>
3295
3296         * top.c (quit_force): Update.
3297         * main.c (captured_command_loop): Update.
3298         * common/new-op.c (operator new): Update.
3299         * common/common-exceptions.c (struct catcher)
3300         <save_cleanup_chain>: Remove member.
3301         (exceptions_state_mc_init): Update.
3302         (exception_try_scope_entry): Return nullptr.
3303         (exception_try_scope_exit, exception_rethrow)
3304         (throw_exception_sjlj, throw_exception_cxx): Update.
3305         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3306         (all_cleanups, do_cleanups, discard_cleanups)
3307         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3308         (restore_cleanups, restore_final_cleanups): Don't declare.
3309         (do_final_cleanups): Remove parameter.
3310         * common/cleanups.c (cleanup_chain, make_cleanup)
3311         (make_cleanup_dtor, all_cleanups, do_cleanups)
3312         (discard_my_cleanups, discard_cleanups)
3313         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3314         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3315         (null_cleanup): Remove.
3316         (do_final_cleanups): Remove parameter.
3317
3318 2019-03-06  Tom Tromey  <tom@tromey.com>
3319
3320         * remote.c (remote_target::remote_parse_stop_reply): Use
3321         unique_xmalloc_ptr.
3322
3323 2019-03-06  Tom Tromey  <tom@tromey.com>
3324
3325         * stabsread.c (struct stabs_field_info): Rename from field_info.
3326         <list, fnlist>: Add initializers.
3327         <obstack>: New member.
3328         (read_member_functions, read_struct_fields, read_baseclasses):
3329         Allocate on obstack.  Don't use cleanups.
3330         (read_one_struct_field, read_member_functions, read_struct_fields)
3331         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3332         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3333         (read_struct_type): Update.
3334
3335 2019-03-06  Tom Tromey  <tom@tromey.com>
3336
3337         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3338         * common/filestuff.h (make_cleanup_close): Don't declare.
3339         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3340         Remove.
3341
3342 2019-03-06  Tom Tromey  <tom@tromey.com>
3343
3344         * solib-aix.c: Use make_scope_exit.
3345
3346 2019-03-06  Tom Tromey  <tom@tromey.com>
3347
3348         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3349         Use make_scope_exit.
3350
3351 2019-03-06  Tom Tromey  <tom@tromey.com>
3352
3353         * solib-svr4.c (disable_probes_interface): Remove parameter.
3354         (svr4_handle_solib_event): Use make_scope_exit.
3355
3356 2019-03-06  Tom Tromey  <tom@tromey.com>
3357
3358         * remote.c (struct stop_reply_deleter): Remove.
3359         (stop_reply_up): Update.
3360         (struct stop_reply): Derive from notif_event.  Don't typedef.
3361         <regcache>: Now a std::vector.
3362         (stop_reply_xfree): Remove.
3363         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3364         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3365         (remote_target::discard_pending_stop_replies): Use delete.
3366         (remote_target::remote_parse_stop_reply): Update.
3367         (remote_target::process_stop_reply): Update.
3368         * remote-notif.h (struct notif_event): Add virtual destructor.
3369         Remove "dtr" member.
3370         (struct notif_client) <alloc_event>: Return a unique_ptr.
3371         (notif_event_xfree): Don't declare.
3372         (notif_event_up): New typedef.
3373         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3374         (notif_event_xfree, do_notif_event_xfree): Remove.
3375         (remote_notif_state_xfree): Update.
3376
3377 2019-03-06  Tom Tromey  <tom@tromey.com>
3378
3379         * infrun.c (displaced_step_clear_cleanup): Now a
3380         forward_scope_exit type.
3381         (displaced_step_prepare_throw): Update.
3382         (displaced_step_fixup): Update.
3383
3384 2019-03-06  Tom Tromey  <tom@tromey.com>
3385
3386         * inferior.h (class inferior): Update comment.
3387         * gdbthread.h (class thread_info): Update comment.
3388
3389 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3390             Tom Tromey  <tom@tromey.com>
3391
3392         * stabsread.h (struct stab_section_list): Remove.
3393         (coffstab_build_psymtabs): Update.
3394         * dbxread.c (symbuf_sections): Now a std::vector.
3395         (sect_idx): New global.
3396         (fill_symbuf): Update.
3397         (coffstab_build_psymtabs): Change type of stabsects parameter.
3398         Update.
3399         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3400         std::vector.
3401         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3402         (coff_locate_sections): Update.
3403         (coff_symfile_read): Remove cleanups.  Update.
3404         (init_stringtab): Add storage parameter.
3405         (free_stringtab, free_stringtab_cleanup): Remove.
3406         (init_lineno): Add storage parameter.
3407         (free_linetab, free_linetab_cleanup): Remove.
3408
3409 2019-03-06  Pedro Alves  <palves@redhat.com>
3410
3411         * linux-fork.c (fork_info::clobber_regs): Delete.
3412         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3413         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3414         comment.  Adjust.
3415         (scoped_switch_fork_info::scoped_switch_fork_info)
3416         (checkpoint_command, linux_fork_context): Adjust
3417         fork_save_infrun_state calls.
3418
3419 2019-03-06  Pedro Alves  <palves@redhat.com>
3420
3421         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3422         (inf_has_multiple_threads): Return 'bool' and rewrite using
3423         inferior_info::threads().
3424
3425 2019-03-06  Pedro Alves  <palves@redhat.com>
3426
3427         * linux-fork.c: Include <list>.
3428         (fork_list): Now a std::list instance.
3429         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3430         (forks_exist_p, find_last_fork): Adjust.
3431         (new_fork): Delete.
3432         (one_fork_p): New.
3433         (add_fork): Adjust.
3434         (free_fork): Delete, folded into fork_info::~fork_info().
3435         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3436         Adjust.
3437         (init_fork_list): Delete.
3438         (linux_fork_killall, linux_fork_mourn_inferior)
3439         (linux_fork_detach, info_checkpoints_command): Adjust.
3440         (_initialize_linux_fork): No longer call init_fork_list.
3441
3442 2019-03-06  Pedro Alves  <palves@redhat.com>
3443
3444         * linux-fork.c (new_fork): New, split out of ...
3445         (add_fork): ... this.  Return void.  Move "first fork" special
3446         case from here, to ...
3447         (checkpoint_command): ... here.
3448         * linux-linux.h (add_fork): Return void.
3449
3450 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3453
3454 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3455             Chris January  <chris.january@arm.com>
3456             David Lecomber  <david.lecomber@arm.com>
3457
3458         * f-exp.y: New token, UNOP_INTRINSIC.
3459         (exp): New pattern using UNOP_INTRINSIC token.
3460         (f77_keywords): Add 'abs' keyword.
3461         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3462         (value_from_host_double): New function.
3463         (evaluate_subexp_f): Support UNOP_ABS.
3464
3465 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3466
3467         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3468         types.
3469
3470 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3471
3472         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3473         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3474         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3475
3476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3477
3478         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3479
3480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3481             Chris January  <chris.january@arm.com>
3482
3483         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3484         * f-exp.y: Define 'KIND' token.
3485         (exp): New pattern for KIND expressions.
3486         (ptype): Handle types with a kind extension.
3487         (direct_abs_decl): Extend to spot kind extensions.
3488         (f77_keywords): Add 'kind' to the list.
3489         (push_kind_type): New function.
3490         (convert_to_kind_type): New function.
3491         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3492         * parse.c (operator_length_standard): Likewise.
3493         * parser-defs.h (enum type_pieces): Add tp_kind.
3494         * std-operator.def: Add UNOP_KIND.
3495
3496 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3497
3498         * f-exp.y (f_parse): Set yydebug.
3499
3500 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3501
3502         * f-lang.c (evaluate_subexp_f): New function.
3503         (exp_descriptor_f): New global.
3504         (f_language_defn): Use exp_descriptor_f instead of
3505         exp_descriptor_standard.
3506
3507 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3508
3509         * f-exp.y (struct token): Add comments.
3510         (dot_ops): Remove uppercase versions and the end marker.
3511         (f77_keywords): Likewise.
3512         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3513         entries in the dot_ops array are case insensitive, and use
3514         strncasecmp to compare strings.  Also some whitespace cleanup in
3515         this area.  Similar for the f77_keywords array, except entries in
3516         this list might be case sensitive.
3517
3518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * f-exp.y (struct f77_boolean_val): Add comments.
3521         (boolean_values): Remove uppercase versions, and end marker.
3522         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3523         and use strncasecmp to achieve case insensitivity.  Additionally,
3524         perform whitespace cleanup around this code.
3525
3526 2019-03-06  Tom Tromey  <tromey@adacore.com>
3527
3528         * remote-sim.c (gdbsim_target_open): Use result of
3529         gdb_argv::release.
3530
3531 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3532         Dirk Schubert  <dirk.schubert@arm.com>
3533         Chris January  <chris.january@arm.com>
3534
3535         * eval.c (evaluate_subexp_standard): Call Fortran argument
3536         wrapping logic.
3537         * f-lang.c (struct value): A value which can be passed into a
3538         Fortran function call.
3539         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3540         where appropriate.
3541         (struct type): Value ready for a Fortran function call.
3542         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3543         is needed.
3544         * f-lang.h (fortran_argument_convert): Declaration.
3545         (fortran_preserve_arg_pointer): Declaration.
3546         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3547
3548 2019-03-05  Tom Tromey  <tromey@adacore.com>
3549
3550         * python/py-prettyprint.c (print_string_repr): Remove #if.
3551         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3552
3553 2019-03-05  Tom Tromey  <tromey@adacore.com>
3554
3555         * target.c (the_dummy_target): Move later.  Change type to
3556         "dummy_target".
3557         (initialize_targets): Don't initialize the_dummy_target.
3558
3559 2019-03-05  Tom Tromey  <tromey@adacore.com>
3560
3561         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3562         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3563
3564 2019-03-05  Tom Tromey  <tromey@adacore.com>
3565
3566         * windows-nat.c (windows_nat_target::attach)
3567         (windows_nat_target::detach): Don't call gdb_flush.
3568         * valprint.c (generic_val_print, val_print, val_print_string):
3569         Don't call gdb_flush.
3570         * utils.c (defaulted_query): Don't call gdb_flush.
3571         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3572         * target.c (target_announce_detach): Don't call gdb_flush.
3573         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3574         * remote.c (extended_remote_target::attach): Don't call
3575         gdb_flush.
3576         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3577         * printcmd.c (do_examine): Don't call gdb_flush.
3578         (info_display_command): Don't call gdb_flush.
3579         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3580         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3581         * memattr.c (info_mem_command): Don't call gdb_flush.
3582         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3583         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3584         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3585         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3586         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3587         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3588         (gnu_nat_target::detach): Don't call gdb_flush.
3589         * f-valprint.c (f_val_print): Don't call gdb_flush.
3590         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3591         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3592         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3593         gdb_flush.
3594         * c-valprint.c (c_val_print): Don't call gdb_flush.
3595         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3596
3597 2019-03-05  Tom Tromey  <tromey@adacore.com>
3598
3599         * varobj.c (update_dynamic_varobj_children): Update.
3600         (install_default_visualizer): Use reset, not release.
3601         * value.c (set_internalvar): Update.
3602         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3603         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3604         ATTRIBUTE_UNUSED_RESULT.
3605
3606 2019-03-05  Tom Tromey  <tromey@adacore.com>
3607
3608         * remote.c (class scoped_remote_fd) <release>: Add
3609         ATTRIBUTE_UNUSED_RESULT.
3610
3611 2019-03-05  Tom Tromey  <tromey@adacore.com>
3612
3613         * macroexp.c (struct macro_buffer) <release>: Add
3614         ATTRIBUTE_UNUSED_RESULT.
3615
3616 2019-03-05  Tom Tromey  <tromey@adacore.com>
3617
3618         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3619         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3620         ATTRIBUTE_UNUSED_RESULT.
3621
3622 2019-03-05  Tom Tromey  <tromey@adacore.com>
3623
3624         * common/scoped_fd.h (class scoped_fd) <release>: Add
3625         ATTRIBUTE_UNUSED_RESULT.
3626
3627 2019-03-05  Tom Tromey  <tromey@adacore.com>
3628
3629         * parser-defs.h (struct parser_state) <release>: Add
3630         ATTRIBUTE_UNUSED_RESULT.
3631
3632 2019-03-05  Tom Tromey  <tromey@adacore.com>
3633
3634         * utils.h (class gdb_argv) <release>: Add
3635         ATTRIBUTE_UNUSED_RESULT.
3636         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3637
3638 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3639
3640         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3641         for-loop range, to avoid compiler warnings.
3642
3643         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3644         avoid compiler warnings about unused variables.
3645
3646         * NEWS: Mention end of support for native debugging on MS-Windows
3647         before XP.
3648
3649         PR gdb/24292
3650         * common/netstuff.c:
3651         * gdbserver/gdbreplay.c
3652         * gdbserver/remote-utils.c:
3653         * ser-tcp.c:
3654         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3655         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3656         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3657         'getaddrinfo' and 'freeaddrinfo' were not available before
3658         Windows XP, and mingw.org's MinGW headers by default define
3659         _WIN32_WINNT to 0x500.
3660
3661 2019-03-01  Gary Benson <gbenson@redhat.com>
3662
3663         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3664
3665 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3666             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3667
3668         PR gdb/8527
3669         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3670         set_sigint_trap, clear_sigint_trap.
3671
3672 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3673
3674         * target.c (target_detach): Clear the regcache and the
3675         frame cache.
3676
3677 2019-02-27  Pedro Alves  <palves@redhat.com>
3678
3679         * utils.c (set_screen_size): When we cap the height/width sizes,
3680         tweak the corresponding command variable to show "unlimited":
3681
3682 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3683             Pedro Alves  <palves@redhat.com>
3684
3685         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3686         before calling rl_set_screen_size.
3687
3688 2019-02-27  Tom Tromey  <tromey@adacore.com>
3689
3690         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3691         define.
3692         * python/py-value.c: Remove Python 2.4 workaround.
3693         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3694         workaround.
3695         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3696         Python 2.4 workaround.
3697         * python/python-internal.h: Remove Python 2.4 comment.
3698         (Py_ssize_t): Don't define.
3699         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3700         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3701         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3702         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3703         * python/python.c (do_start_initialization): Remove Python 2.4
3704         workaround.
3705         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3706         (print_children): Remove Python 2.4 workaround.
3707         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3708         workaround.
3709         (CHARBUFFERPROC_NAME): Remove.
3710         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3711         Python 2.4 workaround.
3712
3713 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3714
3715         * NEWS: Note minimum Python version.
3716
3717 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3718
3719         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3720         code from these functions.  Remove corresponding ifdefs.  Use
3721         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3722         Remove gotos and target of gotos.
3723         (infpy_search_memory): Likewise.
3724
3725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3728         (hppa_gdbarch_init): Don't register deleted functions with
3729         gdbarch.
3730
3731 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3732
3733         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3734         (h8300_unwind_sp): Delete.
3735         (h8300_dummy_id): Delete.
3736         (h8300_gdbarch_init): Don't register deleted functions with
3737         gdbarch.
3738
3739 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3740
3741         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3742         (ft32_unwind_pc): Delete.
3743         (ft32_unwind_sp): Delete.
3744         (ft32_gdbarch_init): Don't register deleted functions with
3745         gdbarch.
3746
3747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3748
3749         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3750         (frv_unwind_pc): Delete.
3751         (frv_unwind_sp): Delete.
3752         (frv_gdbarch_init): Don't register deleted functions with
3753         gdbarch.
3754
3755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3758         (riscv_unwind_pc): Delete.
3759         (riscv_unwind_sp): Delete.
3760         (riscv_gdbarch_init): Don't register deleted functions with
3761         gdbarch.
3762
3763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3766         (csky_unwind_pc): Delete.
3767         (csky_unwind_sp): Delete.
3768         (csky_gdbarch_init): Don't register deleted functions with
3769         gdbarch.
3770
3771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3772
3773         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3774         (cris_unwind_pc): Delete.
3775         (cris_unwind_sp): Delete.
3776         (cris_gdbarch_init): Don't register deleted functions with
3777         gdbarch.
3778
3779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3782         (bfin_unwind_pc): Delete.
3783         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3784
3785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3786
3787         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3788         (arm_unwind_pc): Delete.
3789         (arm_unwind_sp): Delete.
3790         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3791
3792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3793
3794         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3795         (arc_unwind_pc): Delete.
3796         (arc_unwind_sp): Delete.
3797         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3798
3799 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3800
3801         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3802         (alpha_unwind_pc): Delete.
3803         (alpha_gdbarch_init): Don't register deleted functions with
3804         gdbarch.
3805
3806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3807
3808         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3809         (aarch64_unwind_pc): Delete.
3810         (aarch64_unwind_sp): Delete.
3811         (aarch64_gdbarch_init): Don't register deleted functions with
3812         gdbarch.
3813
3814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * gdbtypes.c (type_align): Don't consider static members when
3817         computing structure alignment.
3818
3819 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3820
3821         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3822         return 0 for other types.
3823         * arch-utils.c (default_type_align): Always return 0.
3824         * gdbarch.h: Regenerate.
3825         * gdbarch.sh (type_align): Extend comment.
3826         * gdbtypes.c (type_align): Add additional comments, always call
3827         gdbarch_type_align before applying the default rules.
3828         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3829         generic code will then apply a suitable default.
3830         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3831         types, return 0 for other types.
3832
3833 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3834
3835         * NEWS: Create a new section for the next release branch.
3836         Rename the section of the current branch, now that it has
3837         been cut.
3838
3839 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3840
3841         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3842         * version.in: Bump version to 8.3.50.DATE-git.
3843
3844 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3845
3846         * aix-thread.c (ptid_cmp): Remove unused variable.
3847         (get_signaled_thread): Likewise.
3848         (store_regs_user_thread): Likewise.
3849         (store_regs_kernel_thread): Likewise.
3850         (fetch_regs_kernel_thread): Remove shadowed variable.
3851
3852 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3853
3854         * features/riscv/32bit-cpu.xml: Add register numbers.
3855         * features/riscv/32bit-fpu.c: Regenerate.
3856         * features/riscv/32bit-fpu.xml: Add register numbers.
3857         * features/riscv/64bit-cpu.xml: Add register numbers.
3858         * features/riscv/64bit-fpu.c: Regenerate.
3859         * features/riscv/64bit-fpu.xml: Add register numbers.
3860
3861 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3862
3863         * NEWS: Mention two argument form of gdb.Value constructor.
3864         * python/py-value.c (convert_buffer_and_type_to_value): New
3865         function.
3866         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3867         Add support for handling an optional second argument.  Call
3868         convert_buffer_and_type_to_value as appropriate.
3869         * python/python-internal.h (Py_buffer_deleter): New struct.
3870         (Py_buffer_up): New typedef.
3871
3872 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3873
3874         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3875         instead of releasing ownership.
3876
3877 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3878
3879         * dwarf2read.c (open_and_init_dwp_file): Call
3880         elf_numsections instead of bfd_count_sections to initialize
3881         dwp_file->num_sections.
3882
3883 2019-02-25  Tom Tromey  <tromey@adacore.com>
3884
3885         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3886
3887 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3888
3889         * gcore.in: Add '--readnever' option when invoking GDB.
3890
3891 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3892
3893         * MAINTAINERS: Update my email address.
3894
3895 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3896
3897         * build-id.c (build_id_to_debug_bfd_1): New function.
3898         (build_id_to_debug_bfd): Look for separate debug file in
3899         sysroot.
3900
3901 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3902
3903         * gdbarch.sh: Update the copyright year range that is placed into
3904         generated files.
3905
3906 2019-02-22  Keith Seitz  <keiths@redhat.com>
3907
3908         PR symtab/23853
3909         * linespec.c (create_sals_line_offset): Search for the default
3910         symtab's filename instead of its fullname.
3911
3912 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3913
3914         * NEWS: Update style defaults.
3915
3916 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3917
3918         * main.c (captured_main_1): Disable styling in batch mode.
3919
3920 2019-02-20  Tom Tromey  <tom@tromey.com>
3921
3922         * symtab.c (symtab_symbol_info): Fix typos.
3923
3924 2019-02-20  Tom Tromey  <tromey@adacore.com>
3925
3926         * findcmd.c (_initialize_mem_search): Use upper case for
3927         metasyntactic variables.
3928
3929 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3930
3931         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3932         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3933
3934 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3935
3936         * top.h (source_file_name): Change to std::string.
3937         * top.c (source_file_name): Likewise.
3938         (command_line_input): Adjust.
3939         * cli/cli-script.c (script_from_file): Adjust.
3940
3941 2019-02-19  Tom Tromey  <tromey@adacore.com>
3942
3943         * ravenscar-thread.c
3944         (ravenscar_thread_target::update_thread_list): Don't call
3945         ada_build_task_list.
3946         * ada-lang.h (ada_build_task_list): Don't declare.
3947         * ada-tasks.c (struct ada_tasks_inferior_data)
3948         <task_list_valid_p>: Now bool.
3949         (read_known_tasks, ada_task_list_changed)
3950         (ada_tasks_invalidate_inferior_data): Update.
3951         (read_known_tasks_array): Return bool.
3952         (read_known_tasks_list): Likewise.
3953         (read_known_tasks): Return void.
3954         (ada_build_task_list): Now static.
3955
3956 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3957
3958         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3959         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3960
3961 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3962
3963         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3964         variant for ada_tasks_pspace_data_handle and
3965         ada_tasks_inferior_data_handle.
3966         (ada_tasks_pspace_data_cleanup): New function.
3967         (ada_tasks_inferior_data_cleanup): New function.
3968
3969 2019-02-17  Tom Tromey  <tom@tromey.com>
3970
3971         * macrotab.h (macro_source_fullname): Return a std::string.
3972         * macrotab.c (macro_include, check_for_redefinition)
3973         (macro_undef, macro_lookup_definition, foreach_macro)
3974         (foreach_macro_in_scope): Update.
3975         (macro_source_fullname): Return a std::string.
3976         * macrocmd.c (show_pp_source_pos): Update.
3977
3978 2019-02-17  Tom Tromey  <tom@tromey.com>
3979
3980         * macrocmd.c (show_pp_source_pos): Style the file names.
3981
3982 2019-02-17  Tom Tromey  <tom@tromey.com>
3983
3984         PR tui/24197:
3985         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3986
3987 2019-02-17  Tom Tromey  <tom@tromey.com>
3988
3989         * ada-lang.c (user_select_syms): Use filtered printing.
3990         * utils.c (wrap_style): New global.
3991         (desired_style): Remove.
3992         (emit_style_escape): Add stream parameter.
3993         (set_output_style, reset_terminal_style, prompt_for_continue):
3994         Update.
3995         (flush_wrap_buffer): Only flush gdb_stdout.
3996         (wrap_here): Set wrap_style.
3997         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3998         treat escape sequences as a character.  Change when wrap buffer is
3999         flushed.
4000         (fputs_styled): Do not set the output style when the default is
4001         requested.
4002         * ui-style.h (struct ui_file_style) <is_default>: New method.
4003         * source.c (print_source_lines_base): Emit escape sequences in one
4004         piece.
4005
4006 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4007
4008         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4009         integers and enumeration types.
4010
4011 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4012
4013         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4014         instead of lookup_symbol_in_language
4015         (do_exact_match): New function.
4016         (ada_get_symbol_name_matcher): Return do_exact_match when
4017         doing a verbatim match.
4018
4019 2019-02-15  Tom Tromey  <tromey@adacore.com>
4020
4021         * ravenscar-thread.c (ravenscar_thread_target::resume)
4022         (ravenscar_thread_target::wait): Special case wildcard requests.
4023
4024 2019-02-15  Tom Tromey  <tromey@adacore.com>
4025
4026         * ravenscar-thread.c (base_ptid): Remove.
4027         (struct ravenscar_thread_target) <close>: New method.
4028         <m_base_ptid>: New member.
4029         <update_inferior_ptid, active_task, task_is_currently_active,
4030         runtime_initialized>: Declare methods.
4031         <ravenscar_thread_target>: Add constructor.
4032         (ravenscar_thread_target::task_is_currently_active)
4033         (ravenscar_thread_target::update_inferior_ptid)
4034         (ravenscar_runtime_initialized): Rename.  Now methods.
4035         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4036         (ravenscar_thread_target::update_thread_list): Update.
4037         (ravenscar_thread_target::active_task): Now method.
4038         (ravenscar_thread_target::store_registers)
4039         (ravenscar_thread_target::prepare_to_store)
4040         (ravenscar_thread_target::prepare_to_store)
4041         (ravenscar_thread_target::mourn_inferior): Update.
4042         (ravenscar_inferior_created): Use "new" to create target.
4043         (ravenscar_thread_target::get_ada_task_ptid): Update.
4044         (_initialize_ravenscar): Don't initialize base_ptid.
4045         (ravenscar_ops): Remove global.
4046
4047 2019-02-15  Tom Tromey  <tromey@adacore.com>
4048
4049         * target.h (push_target): Declare new overload.
4050         * target.c (push_target): New overload, taking an rvalue reference.
4051         * remote.c (remote_target::open_1): Use push_target overload.
4052         * corelow.c (core_target_open): Use push_target overload.
4053
4054 2019-02-15  Tom Tromey  <tromey@adacore.com>
4055
4056         * ravenscar-thread.c (is_ravenscar_task)
4057         (ravenscar_task_is_currently_active): Return bool.
4058         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4059         (_initialize_ravenscar): Remove "(void)".
4060         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4061         Return bool.
4062
4063 2019-02-15  Tom Tromey  <tromey@adacore.com>
4064
4065         * ravenscar-thread.c (ravenscar_runtime_initializer)
4066         (has_ravenscar_runtime, get_running_thread_id)
4067         (ravenscar_thread_target::resume): Fix indentation.
4068
4069 2019-02-15  Tom Tromey  <tromey@adacore.com>
4070
4071         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4072         from ravenscar_arch_ops.
4073         (sparc_ravenscar_ops::fetch_registers)
4074         (sparc_ravenscar_ops::store_registers): Now methods.
4075         (sparc_ravenscar_prepare_to_store): Remove.
4076         (sparc_ravenscar_ops): Redefine.
4077         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4078         methods and destructor.  Remove members.
4079         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4080         (ravenscar_thread_target::store_registers)
4081         (ravenscar_thread_target::prepare_to_store): Update.
4082         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4083         Remove.
4084         (struct ppc_ravenscar_powerpc_ops): Derive from
4085         ravenscar_arch_ops.
4086         (ppc_ravenscar_powerpc_ops::fetch_registers)
4087         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4088         (ppc_ravenscar_powerpc_ops): Redefine.
4089         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4090         (ppc_ravenscar_e500_ops::fetch_registers)
4091         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4092         (ppc_ravenscar_e500_ops): Redefine.
4093         * aarch64-ravenscar-thread.c
4094         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4095         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4096         (aarch64_ravenscar_fetch_registers)
4097         (aarch64_ravenscar_store_registers): Now methods.
4098         (aarch64_ravenscar_ops): Redefine.
4099
4100 2019-02-15  Tom Tromey  <tromey@adacore.com>
4101
4102         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4103         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4104         (ravenscar_thread_target::stopped_by_watchpoint)
4105         (ravenscar_thread_target::stopped_data_address)
4106         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4107
4108 2019-02-15  Tom Tromey  <tromey@adacore.com>
4109
4110         * ravenscar-thread.c: Fix some typos.
4111
4112 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4113             Tom Tromey  <tromey@adacore.com>
4114
4115         * ada-lang.c (ada_exception_sal): Change addr_string to a
4116         std::string.
4117         (create_ada_exception_catchpoint): Update.
4118
4119 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4120             Tom Tromey  <tromey@adacore.com>
4121
4122         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4123         (bp_location_ops): Remove.
4124         (base_breakpoint_allocate_location): Update.
4125         (free_bp_location): Update.
4126         * ada-lang.c (class ada_catchpoint_location)
4127         <ada_catchpoint_location>: Remove ops parameter.
4128         (ada_catchpoint_location_dtor): Remove.
4129         (ada_catchpoint_location_ops): Remove.
4130         (allocate_location_exception): Update.
4131         * breakpoint.h (struct bp_location_ops): Remove.
4132         (class bp_location) <bp_location>: Remove bp_location_ops
4133         parameter.
4134         <~bp_location>: Add destructor.
4135         <ops>: Remove.
4136
4137 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4138             Pedro Alves  <palves@redhat.com>
4139
4140         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4141         'PATH_MAX'.
4142
4143 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4144             Samuel Thibault  <samuel.thibault@gnu.org>
4145             Thomas Schwinge  <thomas@codesourcery.com>
4146
4147         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4148         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4149
4150 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4151
4152         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4153         (check_empty): Use "const char *".
4154
4155         * gnu-nat.c (gnu_nat_target::detach): Instead of
4156         'detach_inferior (pid)' call
4157         'detach_inferior (find_inferior_pid (pid))'.
4158
4159         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4160         'nat/fork-inferior.o'.
4161         * gnu-nat.c: #include "nat/fork-inferior.h".
4162
4163         * gnu-nat.c (gnu_nat_target::detach): Instead of
4164         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4165         * gnu-nat.h: #include "inf-child.h".
4166         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4167         'i386_gnu_nat_target::fetch_registers'.
4168         (gnu_store_registers): Rename/move to
4169         'i386_gnu_nat_target::store_registers'.
4170
4171         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4172         * gnu-nat.h (mach_thread_info): New function.
4173         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4174
4175         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4176
4177 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4178
4179         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4180
4181 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4182
4183         * windows-nat.c (windows_add_thread): Add new parameter
4184         "main_thread_p" with default value set to false.  Update
4185         function documentation as well as all callers.
4186         (windows_delete_thread): Likewise.
4187         (fake_create_process): Update call to windows_add_thread.
4188         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4189         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4190         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4191         call to windows_delete_thread.
4192
4193 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4194
4195         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4196
4197 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4198
4199         * symfile.c (find_separate_debug_file): Use canonical path of
4200         sysroot with child_path instead of gdb_sysroot if it is valid.
4201
4202 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4203
4204         * symfile.c (find_separate_debug_file): Use child_path to
4205         determine if an object file is under a sysroot.
4206
4207 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4208
4209         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4210         unittests/child-path-selftests.c.
4211         * common/pathstuff.c (child_path): New function.
4212         * common/pathstuff.h (child_path): New prototype.
4213         * unittests/child-path-selftests.c: New file.
4214
4215 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4216
4217         * symfile.c (find_separate_debug_file): Look for separate debug
4218         files in debug directories under the sysroot.
4219
4220 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4221
4222         * symtab.h (struct minimal_symbol data_p): New const method.
4223         (struct minimal_symbol text_p): Likewise.
4224         * symtab.c (output_source_filename): Use file name style
4225         to print file name.
4226         (print_symbol_info): Likewise.
4227         (print_msymbol_info): Use address style to print addresses.
4228         Use function name style to print executable text symbols.
4229         (expand_symtab_containing_pc): Use data_p.
4230         (find_pc_sect_compunit_symtab): Likewise.
4231
4232 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4233
4234         * breakpoint.c (describe_other_breakpoints): Use address style
4235         to print addresses.
4236         (say_where): Likewise.
4237
4238 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4239
4240         * ada-typeprint.c (print_func_type): Print function name
4241         style to print function name.
4242         * c-typeprint.c (c_print_type_1): Likewise.
4243
4244 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4245
4246         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4247         for execve.
4248
4249 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4250
4251         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4252         type_stack.
4253
4254 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4255
4256         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4257         TYPE_CODE_REF types.
4258
4259 2019-02-08  Jim Wilson  <jimw@sifive.com>
4260
4261         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4262         (riscv_linux_fregset): New.
4263         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4264
4265 2019-02-07  Tom Tromey  <tom@tromey.com>
4266
4267         * thread.c (thread_cancel_execution_command): Update.
4268         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4269         methods.
4270         (struct thread_fsm_ops): Remove.
4271         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4272         (thread_fsm_should_stop, thread_fsm_return_value)
4273         (thread_fsm_set_finished, thread_fsm_finished_p)
4274         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4275         Don't declare.
4276         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4277         * infrun.c (clear_proceed_status_thread)
4278         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4279         (print_stop_event): Update.
4280         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4281         Add constructor.
4282         (step_command_fsm_ops): Remove.
4283         (new_step_command_fsm): Remove.
4284         (step_1): Update.
4285         (step_command_fsm::should_stop): Rename from
4286         step_command_fsm_should_stop.
4287         (step_command_fsm::clean_up): Rename from
4288         step_command_fsm_clean_up.
4289         (step_command_fsm::do_async_reply_reason): Rename from
4290         step_command_fsm_async_reply_reason.
4291         (struct until_next_fsm): Inherit from thread_fsm.  Add
4292         constructor.
4293         (until_next_fsm_ops): Remove.
4294         (new_until_next_fsm): Remove.
4295         (until_next_fsm::should_stop): Rename from
4296         until_next_fsm_should_stop.
4297         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4298         (until_next_fsm::do_async_reply_reason): Rename from
4299         until_next_fsm_async_reply_reason.
4300         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4301         constructor.  Change type of breakpoint.
4302         (finish_command_fsm_ops): Remove.
4303         (new_finish_command_fsm): Remove.
4304         (finish_command_fsm::should_stop): Rename from
4305         finish_command_fsm_should_stop.
4306         (finish_command_fsm::clean_up): Rename from
4307         finish_command_fsm_clean_up.
4308         (finish_command_fsm::return_value): Rename from
4309         finish_command_fsm_return_value.
4310         (finish_command_fsm::do_async_reply_reason): Rename from
4311         finish_command_fsm_async_reply_reason.
4312         (finish_command): Update.
4313         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4314         Add constructor.
4315         (call_thread_fsm_ops): Remove.
4316         (call_thread_fsm::call_thread_fsm): Rename from
4317         new_call_thread_fsm.
4318         (call_thread_fsm::should_stop): Rename from
4319         call_thread_fsm_should_stop.
4320         (call_thread_fsm::should_notify_stop): Rename from
4321         call_thread_fsm_should_notify_stop.
4322         (run_inferior_call, call_function_by_hand_dummy): Update.
4323         * cli/cli-interp.c (should_print_stop_to_console): Update.
4324         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4325         Add constructor.  Change type of location_breakpoint,
4326         caller_breakpoint.
4327         (until_break_fsm_ops): Remove.
4328         (new_until_break_fsm): Remove.
4329         (until_break_fsm::should_stop): Rename from
4330         until_break_fsm_should_stop.
4331         (until_break_fsm::clean_up): Rename from
4332         until_break_fsm_clean_up.
4333         (until_break_fsm::do_async_reply_reason): Rename from
4334         until_break_fsm_async_reply_reason.
4335         (until_break_command): Update.
4336         * thread-fsm.c: Remove.
4337         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4338
4339 2019-02-07  Tom Tromey  <tom@tromey.com>
4340
4341         * yy-remap.h: Add include guard.
4342         * xtensa-tdep.h: Add include guard.
4343         * xcoffread.h: Rename include guard.
4344         * varobj-iter.h: Add include guard.
4345         * tui/tui.h: Rename include guard.
4346         * tui/tui-winsource.h: Rename include guard.
4347         * tui/tui-wingeneral.h: Rename include guard.
4348         * tui/tui-windata.h: Rename include guard.
4349         * tui/tui-win.h: Rename include guard.
4350         * tui/tui-stack.h: Rename include guard.
4351         * tui/tui-source.h: Rename include guard.
4352         * tui/tui-regs.h: Rename include guard.
4353         * tui/tui-out.h: Rename include guard.
4354         * tui/tui-layout.h: Rename include guard.
4355         * tui/tui-io.h: Rename include guard.
4356         * tui/tui-hooks.h: Rename include guard.
4357         * tui/tui-file.h: Rename include guard.
4358         * tui/tui-disasm.h: Rename include guard.
4359         * tui/tui-data.h: Rename include guard.
4360         * tui/tui-command.h: Rename include guard.
4361         * tic6x-tdep.h: Add include guard.
4362         * target/waitstatus.h: Rename include guard.
4363         * target/wait.h: Rename include guard.
4364         * target/target.h: Rename include guard.
4365         * target/resume.h: Rename include guard.
4366         * target-float.h: Rename include guard.
4367         * stabsread.h: Add include guard.
4368         * rs6000-tdep.h: Add include guard.
4369         * riscv-fbsd-tdep.h: Add include guard.
4370         * regformats/regdef.h: Rename include guard.
4371         * record.h: Rename include guard.
4372         * python/python.h: Rename include guard.
4373         * python/python-internal.h: Rename include guard.
4374         * python/py-stopevent.h: Rename include guard.
4375         * python/py-ref.h: Rename include guard.
4376         * python/py-record.h: Rename include guard.
4377         * python/py-record-full.h: Rename include guard.
4378         * python/py-record-btrace.h: Rename include guard.
4379         * python/py-instruction.h: Rename include guard.
4380         * python/py-events.h: Rename include guard.
4381         * python/py-event.h: Rename include guard.
4382         * procfs.h: Add include guard.
4383         * proc-utils.h: Add include guard.
4384         * p-lang.h: Add include guard.
4385         * or1k-tdep.h: Rename include guard.
4386         * observable.h: Rename include guard.
4387         * nto-tdep.h: Rename include guard.
4388         * nat/x86-linux.h: Rename include guard.
4389         * nat/x86-linux-dregs.h: Rename include guard.
4390         * nat/x86-gcc-cpuid.h: Add include guard.
4391         * nat/x86-dregs.h: Rename include guard.
4392         * nat/x86-cpuid.h: Rename include guard.
4393         * nat/ppc-linux.h: Rename include guard.
4394         * nat/mips-linux-watch.h: Rename include guard.
4395         * nat/linux-waitpid.h: Rename include guard.
4396         * nat/linux-ptrace.h: Rename include guard.
4397         * nat/linux-procfs.h: Rename include guard.
4398         * nat/linux-osdata.h: Rename include guard.
4399         * nat/linux-nat.h: Rename include guard.
4400         * nat/linux-namespaces.h: Rename include guard.
4401         * nat/linux-btrace.h: Rename include guard.
4402         * nat/glibc_thread_db.h: Rename include guard.
4403         * nat/gdb_thread_db.h: Rename include guard.
4404         * nat/gdb_ptrace.h: Rename include guard.
4405         * nat/fork-inferior.h: Rename include guard.
4406         * nat/amd64-linux-siginfo.h: Rename include guard.
4407         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4408         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4409         * nat/aarch64-linux.h: Rename include guard.
4410         * nat/aarch64-linux-hw-point.h: Rename include guard.
4411         * mn10300-tdep.h: Add include guard.
4412         * mips-linux-tdep.h: Add include guard.
4413         * mi/mi-parse.h: Rename include guard.
4414         * mi/mi-out.h: Rename include guard.
4415         * mi/mi-main.h: Rename include guard.
4416         * mi/mi-interp.h: Rename include guard.
4417         * mi/mi-getopt.h: Rename include guard.
4418         * mi/mi-console.h: Rename include guard.
4419         * mi/mi-common.h: Rename include guard.
4420         * mi/mi-cmds.h: Rename include guard.
4421         * mi/mi-cmd-break.h: Rename include guard.
4422         * m2-lang.h: Add include guard.
4423         * location.h: Rename include guard.
4424         * linux-record.h: Rename include guard.
4425         * linux-nat.h: Add include guard.
4426         * linux-fork.h: Add include guard.
4427         * i386-darwin-tdep.h: Rename include guard.
4428         * hppa-linux-offsets.h: Add include guard.
4429         * guile/guile.h: Rename include guard.
4430         * guile/guile-internal.h: Rename include guard.
4431         * gnu-nat.h: Rename include guard.
4432         * gdb-stabs.h: Rename include guard.
4433         * frv-tdep.h: Add include guard.
4434         * f-lang.h: Add include guard.
4435         * event-loop.h: Add include guard.
4436         * darwin-nat.h: Rename include guard.
4437         * cp-abi.h: Rename include guard.
4438         * config/sparc/nm-sol2.h: Rename include guard.
4439         * config/nm-nto.h: Rename include guard.
4440         * config/nm-linux.h: Add include guard.
4441         * config/i386/nm-i386gnu.h: Rename include guard.
4442         * config/djgpp/nl_types.h: Rename include guard.
4443         * config/djgpp/langinfo.h: Rename include guard.
4444         * compile/gcc-cp-plugin.h: Add include guard.
4445         * compile/gcc-c-plugin.h: Add include guard.
4446         * compile/compile.h: Rename include guard.
4447         * compile/compile-object-run.h: Rename include guard.
4448         * compile/compile-object-load.h: Rename include guard.
4449         * compile/compile-internal.h: Rename include guard.
4450         * compile/compile-cplus.h: Rename include guard.
4451         * compile/compile-c.h: Rename include guard.
4452         * common/xml-utils.h: Rename include guard.
4453         * common/x86-xstate.h: Rename include guard.
4454         * common/version.h: Rename include guard.
4455         * common/vec.h: Rename include guard.
4456         * common/tdesc.h: Rename include guard.
4457         * common/selftest.h: Rename include guard.
4458         * common/scoped_restore.h: Rename include guard.
4459         * common/scoped_mmap.h: Rename include guard.
4460         * common/scoped_fd.h: Rename include guard.
4461         * common/safe-iterator.h: Rename include guard.
4462         * common/run-time-clock.h: Rename include guard.
4463         * common/refcounted-object.h: Rename include guard.
4464         * common/queue.h: Rename include guard.
4465         * common/ptid.h: Rename include guard.
4466         * common/print-utils.h: Rename include guard.
4467         * common/preprocessor.h: Rename include guard.
4468         * common/pathstuff.h: Rename include guard.
4469         * common/observable.h: Rename include guard.
4470         * common/netstuff.h: Rename include guard.
4471         * common/job-control.h: Rename include guard.
4472         * common/host-defs.h: Rename include guard.
4473         * common/gdb_wait.h: Rename include guard.
4474         * common/gdb_vecs.h: Rename include guard.
4475         * common/gdb_unlinker.h: Rename include guard.
4476         * common/gdb_unique_ptr.h: Rename include guard.
4477         * common/gdb_tilde_expand.h: Rename include guard.
4478         * common/gdb_sys_time.h: Rename include guard.
4479         * common/gdb_string_view.h: Rename include guard.
4480         * common/gdb_splay_tree.h: Rename include guard.
4481         * common/gdb_setjmp.h: Rename include guard.
4482         * common/gdb_ref_ptr.h: Rename include guard.
4483         * common/gdb_optional.h: Rename include guard.
4484         * common/gdb_locale.h: Rename include guard.
4485         * common/gdb_assert.h: Rename include guard.
4486         * common/filtered-iterator.h: Rename include guard.
4487         * common/filestuff.h: Rename include guard.
4488         * common/fileio.h: Rename include guard.
4489         * common/environ.h: Rename include guard.
4490         * common/common-utils.h: Rename include guard.
4491         * common/common-types.h: Rename include guard.
4492         * common/common-regcache.h: Rename include guard.
4493         * common/common-inferior.h: Rename include guard.
4494         * common/common-gdbthread.h: Rename include guard.
4495         * common/common-exceptions.h: Rename include guard.
4496         * common/common-defs.h: Rename include guard.
4497         * common/common-debug.h: Rename include guard.
4498         * common/cleanups.h: Rename include guard.
4499         * common/buffer.h: Rename include guard.
4500         * common/btrace-common.h: Rename include guard.
4501         * common/break-common.h: Rename include guard.
4502         * cli/cli-utils.h: Rename include guard.
4503         * cli/cli-style.h: Rename include guard.
4504         * cli/cli-setshow.h: Rename include guard.
4505         * cli/cli-script.h: Rename include guard.
4506         * cli/cli-interp.h: Rename include guard.
4507         * cli/cli-decode.h: Rename include guard.
4508         * cli/cli-cmds.h: Rename include guard.
4509         * charset-list.h: Add include guard.
4510         * buildsym-legacy.h: Rename include guard.
4511         * bfin-tdep.h: Add include guard.
4512         * ax.h: Rename include guard.
4513         * arm-linux-tdep.h: Add include guard.
4514         * arm-fbsd-tdep.h: Add include guard.
4515         * arch/xtensa.h: Rename include guard.
4516         * arch/tic6x.h: Add include guard.
4517         * arch/i386.h: Add include guard.
4518         * arch/arm.h: Rename include guard.
4519         * arch/arm-linux.h: Rename include guard.
4520         * arch/arm-get-next-pcs.h: Rename include guard.
4521         * arch/amd64.h: Add include guard.
4522         * arch/aarch64-insn.h: Rename include guard.
4523         * arch-utils.h: Rename include guard.
4524         * annotate.h: Add include guard.
4525         * amd64-darwin-tdep.h: Rename include guard.
4526         * aarch64-linux-tdep.h: Add include guard.
4527         * aarch64-fbsd-tdep.h: Add include guard.
4528         * aarch32-linux-nat.h: Add include guard.
4529
4530 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4531
4532         * macrotab.c (macro_define_internal): New function that
4533         factorizes macro_define_object_internal and macro_define_function
4534         code.
4535         (macro_define_object_internal): Use macro_define_internal.
4536         (macro_define_function): Likewise.
4537
4538 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4539
4540         * macrocmd.c (extract_identifier): Return
4541         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4542         callers.
4543
4544 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4545
4546         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4547
4548 2019-02-05  Tom Tromey  <tom@tromey.com>
4549
4550         * target.c (target_stack::unpush): Move assertion earlier.
4551
4552 2019-01-30  Tom Tromey  <tom@tromey.com>
4553
4554         PR python/23615:
4555         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4556         (gdbpy_parse_and_eval): Likewise.
4557         * python/python-internal.h (gdbpy_allow_threads): New class.
4558
4559 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4560
4561         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4562         (aarch64_fbsd_fpregmap): Move earlier.
4563         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4564         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4565         instead of individual calls to trad_frame_set_reg_addr.
4566         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4567         earlier.
4568         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4569         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4570         instead of individual calls to trad_frame_set_reg_addr.
4571
4572 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4573
4574         * CONTRIBUTE: Replace contribution list with wiki link.
4575
4576 2019-01-25  Tom Tromey  <tom@tromey.com>
4577
4578         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4579
4580 2019-01-25  Tom Tromey  <tom@tromey.com>
4581
4582         * xtensa-linux-nat.c: Fix common/ includes.
4583         * xml-support.h: Fix common/ includes.
4584         * xml-support.c: Fix common/ includes.
4585         * x86-linux-nat.c: Fix common/ includes.
4586         * windows-nat.c: Fix common/ includes.
4587         * varobj.h: Fix common/ includes.
4588         * varobj.c: Fix common/ includes.
4589         * value.c: Fix common/ includes.
4590         * valops.c: Fix common/ includes.
4591         * utils.c: Fix common/ includes.
4592         * unittests/xml-utils-selftests.c: Fix common/ includes.
4593         * unittests/utils-selftests.c: Fix common/ includes.
4594         * unittests/unpack-selftests.c: Fix common/ includes.
4595         * unittests/tracepoint-selftests.c: Fix common/ includes.
4596         * unittests/style-selftests.c: Fix common/ includes.
4597         * unittests/string_view-selftests.c: Fix common/ includes.
4598         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4599         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4600         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4601         * unittests/rsp-low-selftests.c: Fix common/ includes.
4602         * unittests/parse-connection-spec-selftests.c: Fix common/
4603         includes.
4604         * unittests/optional-selftests.c: Fix common/ includes.
4605         * unittests/offset-type-selftests.c: Fix common/ includes.
4606         * unittests/observable-selftests.c: Fix common/ includes.
4607         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4608         * unittests/memrange-selftests.c: Fix common/ includes.
4609         * unittests/memory-map-selftests.c: Fix common/ includes.
4610         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4611         * unittests/function-view-selftests.c: Fix common/ includes.
4612         * unittests/environ-selftests.c: Fix common/ includes.
4613         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4614         * unittests/common-utils-selftests.c: Fix common/ includes.
4615         * unittests/cli-utils-selftests.c: Fix common/ includes.
4616         * unittests/array-view-selftests.c: Fix common/ includes.
4617         * ui-file.c: Fix common/ includes.
4618         * tui/tui-io.c: Fix common/ includes.
4619         * tracepoint.h: Fix common/ includes.
4620         * tracepoint.c: Fix common/ includes.
4621         * tracefile-tfile.c: Fix common/ includes.
4622         * top.h: Fix common/ includes.
4623         * top.c: Fix common/ includes.
4624         * thread.c: Fix common/ includes.
4625         * target/waitstatus.h: Fix common/ includes.
4626         * target/waitstatus.c: Fix common/ includes.
4627         * target.h: Fix common/ includes.
4628         * target.c: Fix common/ includes.
4629         * target-memory.c: Fix common/ includes.
4630         * target-descriptions.c: Fix common/ includes.
4631         * symtab.h: Fix common/ includes.
4632         * symfile.c: Fix common/ includes.
4633         * stap-probe.c: Fix common/ includes.
4634         * spu-linux-nat.c: Fix common/ includes.
4635         * sparc-nat.c: Fix common/ includes.
4636         * source.c: Fix common/ includes.
4637         * solib.c: Fix common/ includes.
4638         * solib-target.c: Fix common/ includes.
4639         * ser-unix.c: Fix common/ includes.
4640         * ser-tcp.c: Fix common/ includes.
4641         * ser-pipe.c: Fix common/ includes.
4642         * ser-base.c: Fix common/ includes.
4643         * selftest-arch.c: Fix common/ includes.
4644         * s12z-tdep.c: Fix common/ includes.
4645         * rust-exp.y: Fix common/ includes.
4646         * rs6000-aix-tdep.c: Fix common/ includes.
4647         * riscv-tdep.c: Fix common/ includes.
4648         * remote.c: Fix common/ includes.
4649         * remote-notif.h: Fix common/ includes.
4650         * remote-fileio.h: Fix common/ includes.
4651         * remote-fileio.c: Fix common/ includes.
4652         * regcache.h: Fix common/ includes.
4653         * regcache.c: Fix common/ includes.
4654         * record-btrace.c: Fix common/ includes.
4655         * python/python.c: Fix common/ includes.
4656         * python/py-type.c: Fix common/ includes.
4657         * python/py-inferior.c: Fix common/ includes.
4658         * progspace.h: Fix common/ includes.
4659         * producer.c: Fix common/ includes.
4660         * procfs.c: Fix common/ includes.
4661         * proc-api.c: Fix common/ includes.
4662         * printcmd.c: Fix common/ includes.
4663         * ppc-linux-nat.c: Fix common/ includes.
4664         * parser-defs.h: Fix common/ includes.
4665         * osdata.c: Fix common/ includes.
4666         * obsd-nat.c: Fix common/ includes.
4667         * nat/x86-linux.c: Fix common/ includes.
4668         * nat/x86-linux-dregs.c: Fix common/ includes.
4669         * nat/x86-dregs.h: Fix common/ includes.
4670         * nat/x86-dregs.c: Fix common/ includes.
4671         * nat/ppc-linux.c: Fix common/ includes.
4672         * nat/mips-linux-watch.h: Fix common/ includes.
4673         * nat/mips-linux-watch.c: Fix common/ includes.
4674         * nat/linux-waitpid.c: Fix common/ includes.
4675         * nat/linux-ptrace.h: Fix common/ includes.
4676         * nat/linux-ptrace.c: Fix common/ includes.
4677         * nat/linux-procfs.c: Fix common/ includes.
4678         * nat/linux-personality.c: Fix common/ includes.
4679         * nat/linux-osdata.c: Fix common/ includes.
4680         * nat/linux-namespaces.c: Fix common/ includes.
4681         * nat/linux-btrace.h: Fix common/ includes.
4682         * nat/linux-btrace.c: Fix common/ includes.
4683         * nat/fork-inferior.c: Fix common/ includes.
4684         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4685         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4686         * nat/aarch64-linux.c: Fix common/ includes.
4687         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4688         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4689         * namespace.h: Fix common/ includes.
4690         * mips-linux-tdep.c: Fix common/ includes.
4691         * minsyms.c: Fix common/ includes.
4692         * mi/mi-parse.h: Fix common/ includes.
4693         * mi/mi-main.c: Fix common/ includes.
4694         * mi/mi-cmd-env.c: Fix common/ includes.
4695         * memrange.h: Fix common/ includes.
4696         * memattr.c: Fix common/ includes.
4697         * maint.h: Fix common/ includes.
4698         * maint.c: Fix common/ includes.
4699         * main.c: Fix common/ includes.
4700         * machoread.c: Fix common/ includes.
4701         * location.c: Fix common/ includes.
4702         * linux-thread-db.c: Fix common/ includes.
4703         * linux-nat.c: Fix common/ includes.
4704         * linux-fork.c: Fix common/ includes.
4705         * inline-frame.c: Fix common/ includes.
4706         * infrun.c: Fix common/ includes.
4707         * inflow.c: Fix common/ includes.
4708         * inferior.h: Fix common/ includes.
4709         * inferior.c: Fix common/ includes.
4710         * infcmd.c: Fix common/ includes.
4711         * inf-ptrace.c: Fix common/ includes.
4712         * inf-child.c: Fix common/ includes.
4713         * ia64-linux-nat.c: Fix common/ includes.
4714         * i387-tdep.c: Fix common/ includes.
4715         * i386-tdep.c: Fix common/ includes.
4716         * i386-linux-tdep.c: Fix common/ includes.
4717         * i386-linux-nat.c: Fix common/ includes.
4718         * i386-go32-tdep.c: Fix common/ includes.
4719         * i386-fbsd-tdep.c: Fix common/ includes.
4720         * i386-fbsd-nat.c: Fix common/ includes.
4721         * guile/scm-type.c: Fix common/ includes.
4722         * guile/guile.c: Fix common/ includes.
4723         * go32-nat.c: Fix common/ includes.
4724         * gnu-nat.c: Fix common/ includes.
4725         * gdbthread.h: Fix common/ includes.
4726         * gdbarch-selftests.c: Fix common/ includes.
4727         * gdb_usleep.c: Fix common/ includes.
4728         * gdb_select.h: Fix common/ includes.
4729         * gdb_bfd.c: Fix common/ includes.
4730         * gcore.c: Fix common/ includes.
4731         * fork-child.c: Fix common/ includes.
4732         * findvar.c: Fix common/ includes.
4733         * fbsd-nat.c: Fix common/ includes.
4734         * event-top.c: Fix common/ includes.
4735         * event-loop.c: Fix common/ includes.
4736         * dwarf2read.c: Fix common/ includes.
4737         * dwarf2loc.c: Fix common/ includes.
4738         * dwarf2-frame.c: Fix common/ includes.
4739         * dwarf-index-cache.c: Fix common/ includes.
4740         * dtrace-probe.c: Fix common/ includes.
4741         * disasm-selftests.c: Fix common/ includes.
4742         * defs.h: Fix common/ includes.
4743         * csky-tdep.c: Fix common/ includes.
4744         * cp-valprint.c: Fix common/ includes.
4745         * cp-support.h: Fix common/ includes.
4746         * cp-support.c: Fix common/ includes.
4747         * corelow.c: Fix common/ includes.
4748         * completer.h: Fix common/ includes.
4749         * completer.c: Fix common/ includes.
4750         * compile/compile.c: Fix common/ includes.
4751         * compile/compile-loc2c.c: Fix common/ includes.
4752         * compile/compile-cplus-types.c: Fix common/ includes.
4753         * compile/compile-cplus-symbols.c: Fix common/ includes.
4754         * command.h: Fix common/ includes.
4755         * cli/cli-dump.c: Fix common/ includes.
4756         * cli/cli-cmds.c: Fix common/ includes.
4757         * charset.c: Fix common/ includes.
4758         * build-id.c: Fix common/ includes.
4759         * btrace.h: Fix common/ includes.
4760         * btrace.c: Fix common/ includes.
4761         * breakpoint.h: Fix common/ includes.
4762         * breakpoint.c: Fix common/ includes.
4763         * ax.h:
4764         (enum agent_op): Fix common/ includes.
4765         * ax-general.c (struct aop_map): Fix common/ includes.
4766         * ax-gdb.c: Fix common/ includes.
4767         * auxv.c: Fix common/ includes.
4768         * auto-load.c: Fix common/ includes.
4769         * arm-tdep.c: Fix common/ includes.
4770         * arch/riscv.c: Fix common/ includes.
4771         * arch/ppc-linux-common.c: Fix common/ includes.
4772         * arch/i386.c: Fix common/ includes.
4773         * arch/arm.c: Fix common/ includes.
4774         * arch/arm-linux.c: Fix common/ includes.
4775         * arch/arm-get-next-pcs.c: Fix common/ includes.
4776         * arch/amd64.c: Fix common/ includes.
4777         * arch/aarch64.c: Fix common/ includes.
4778         * arch/aarch64-insn.c: Fix common/ includes.
4779         * arch-utils.c: Fix common/ includes.
4780         * amd64-windows-tdep.c: Fix common/ includes.
4781         * amd64-tdep.c: Fix common/ includes.
4782         * amd64-sol2-tdep.c: Fix common/ includes.
4783         * amd64-obsd-tdep.c: Fix common/ includes.
4784         * amd64-nbsd-tdep.c: Fix common/ includes.
4785         * amd64-linux-tdep.c: Fix common/ includes.
4786         * amd64-linux-nat.c: Fix common/ includes.
4787         * amd64-fbsd-tdep.c: Fix common/ includes.
4788         * amd64-fbsd-nat.c: Fix common/ includes.
4789         * amd64-dicos-tdep.c: Fix common/ includes.
4790         * amd64-darwin-tdep.c: Fix common/ includes.
4791         * agent.c: Fix common/ includes.
4792         * ada-lang.h: Fix common/ includes.
4793         * ada-lang.c: Fix common/ includes.
4794         * aarch64-tdep.c: Fix common/ includes.
4795
4796 2019-01-25  Tom Tromey  <tom@tromey.com>
4797
4798         * common/create-version.sh: Use common/version.h.
4799
4800 2019-01-24  Pedro Alves  <palves@redhat.com>
4801
4802         * infrun.c (signal_stop, signal_print, signal_program)
4803         (signal_catch, signal_pass): Now arrays instead of pointers.
4804         (update_signals_program_target, do_target_resume)
4805         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4806         * linux-nat.c (linux_nat_target::pass_signals)
4807         (linux_nat_target::create_inferior, linux_nat_target::attach):
4808         Adjust.
4809         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4810         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4811         * procfs.c (procfs_target::pass_signals): Adjust.
4812         * record-full.c (record_full_target::resume): Adjust.
4813         * remote.c (remote_target::pass_signals)
4814         (remote_target::program_signals): Adjust.
4815         * target-debug.h (target_debug_print_signals): Now takes a
4816         gdb::array_view as parameter.  Adjust.
4817         * target.h (target_ops) <pass_signals, program_signals>: Replace
4818         pointer and length parameters with gdb::array_view.
4819         (target_pass_signals, target_program_signals): Likewise.
4820         * target-delegates.c: Regenerate.
4821
4822 2019-01-24  Pedro Alves  <palves@redhat.com>
4823
4824         * common/forward-scope-exit.h
4825         (forward_scope_exit::forward_scope_exit): Pass arguments to
4826         m_bind_function directly, instead of creating a std::bind and
4827         copying that.
4828
4829 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4830
4831         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4832         for static members.
4833         (pass_in_v_vfp_candidate): Likewise.
4834
4835 2019-01-23  Tom Tromey  <tom@tromey.com>
4836             Pedro Alves  <palves@redhat.com>
4837
4838         * regcache.c (class regcache_invalidator): Remove.
4839         (regcache::raw_write): Use make_scope_exit.
4840
4841 2019-01-23  Tom Tromey  <tom@tromey.com>
4842
4843         * ui-out.h (class ui_out_emit_type): Update comment.
4844
4845 2019-01-23  Tom Tromey  <tom@tromey.com>
4846
4847         * infrun.c (fetch_inferior_event): Update comment.
4848
4849 2019-01-23  Tom Tromey  <tom@tromey.com>
4850             Pedro Alves  <palves@redhat.com>
4851
4852         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4853         parameter.
4854         (fetch_inferior_event): Use SCOPE_EXIT.
4855
4856
4857 2019-01-23  Tom Tromey  <tom@tromey.com>
4858             Pedro Alves  <palves@redhat.com>
4859
4860         * infrun.c (disable_thread_events): Delete.
4861         (stop_all_threads): Use SCOPE_EXIT.
4862
4863 2019-01-23  Tom Tromey  <tom@tromey.com>
4864             Pedro Alves  <palves@redhat.com>
4865
4866         * symfile.c: Include forward-scope-exit.h.
4867         (clear_symtab_users_cleanup): Replace forward declaration with
4868         a FORWARD_SCOPE_EXIT.
4869         (syms_from_objfile_1): Use the forward_scope_exit and
4870         gdb::optional instead of cleanup_function.
4871         (reread_symbols): Use the forward_scope_exit instead of
4872         cleanup_function.
4873         (clear_symtab_users_cleanup): Remove function.
4874
4875 2019-01-23  Tom Tromey  <tom@tromey.com>
4876             Pedro Alves  <palves@redhat.com>
4877
4878         * linux-nat.c: Include scope-exit.h.
4879         (cleanup_target_stop): Remove.
4880         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4881         SCOPE_EXIT.
4882
4883 2019-01-23  Tom Tromey  <tom@tromey.com>
4884             Pedro Alves  <palves@redhat.com>
4885
4886         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4887         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4888
4889 2019-01-23  Tom Tromey  <tom@tromey.com>
4890             Andrew Burgess  <andrew.burgess@embecosm.com>
4891             Pedro Alves  <palves@redhat.com>
4892
4893         * infrun.c (fetch_inferior_event): Use scope_exit.
4894         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4895         * top.c (execute_command): Use scope_exit.
4896         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4897         * utils.c (do_bpstat_clear_actions_cleanup)
4898         (make_bpstat_clear_actions_cleanup): Remove.
4899
4900 2019-01-23  Tom Tromey  <tom@tromey.com>
4901             Pedro Alves  <palves@redhat.com>
4902
4903         * infrun.c: Include "common/scope-exit.h"
4904         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4905         (wait_for_inferior): Use SCOPE_EXIT.
4906         (fetch_inferior_event): Use scope_exit.
4907
4908 2019-01-23  Tom Tromey  <tom@tromey.com>
4909             Pedro Alves  <palves@redhat.com>
4910
4911         * breakpoint.c (create_breakpoint): Remove cleanup.
4912
4913 2019-01-23  Tom Tromey  <tom@tromey.com>
4914             Andrew Burgess  <andrew.burgess@embecosm.com>
4915             Pedro Alves  <palves@redhat.com>
4916
4917 2019-01-23  Pedro Alves  <palves@redhat.com>
4918
4919         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4920
4921 2019-01-23  Pedro Alves  <palves@redhat.com>
4922             Andrew Burgess  <andrew.burgess@embecosm.com>
4923
4924         * gdbthread.h: Include "common/forward-scope-exit.h".
4925         (scoped_finish_thread_state): Redefine custom class in terms of
4926         forward_scope_exit.
4927
4928 2019-01-23  Pedro Alves  <palves@redhat.com>
4929             Andrew Burgess  <andrew.burgess@embecosm.com>
4930
4931         * common/forward-scope-exit.h: New file.
4932
4933 2019-01-23  Pedro Alves  <palves@redhat.com>
4934             Andrew Burgess  <andrew.burgess@embecosm.com>
4935             Tom Tromey  <tom@tromey.com>
4936
4937         * common/scope-exit.h: New file.
4938
4939 2019-01-23  Pedro Alves  <palves@redhat.com>
4940
4941         * common/preprocessor.h (ESC): Rename to ...
4942         (ESC_PARENS): ... this.
4943         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4944         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4945
4946 2019-01-23  Tom Tromey  <tom@tromey.com>
4947
4948         * language.h (class scoped_switch_to_sym_language_if_auto):
4949         Initialize m_lang in both cases.
4950
4951 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4952
4953         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4954         with XCNEW.
4955
4956 2019-01-22  Tom Tromey  <tom@tromey.com>
4957
4958         * corelow.c: Do not include sys/file.h.
4959
4960 2019-01-22  Tom Tromey  <tom@tromey.com>
4961
4962         * tui/tui-wingeneral.h: Include gdb_curses.h.
4963
4964 2019-01-22  Tom Tromey  <tom@tromey.com>
4965
4966         * source-cache.h (class source_cache) <get_source_lines,
4967         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4968
4969 2019-01-22  Tom Tromey  <tom@tromey.com>
4970
4971         * remote-fileio.h (struct remote_target): Declare.
4972
4973 2019-01-22  Tom Tromey  <tom@tromey.com>
4974
4975         * python/py-arch.c: Do not include py-ref.h.
4976         * python/py-bpevent.c: Do not include py-ref.h.
4977         * python/py-cmd.c: Do not include py-ref.h.
4978         * python/py-continueevent.c: Do not include py-ref.h.
4979         * python/py-event.h: Do not include py-ref.h.
4980         * python/py-evtregistry.c: Do not include py-ref.h.
4981         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4982         * python/py-frame.c: Do not include py-ref.h.
4983         * python/py-framefilter.c: Do not include py-ref.h.
4984         * python/py-function.c: Do not include py-ref.h.
4985         * python/py-infevents.c: Do not include py-ref.h.
4986         * python/py-linetable.c: Do not include py-ref.h.
4987         * python/py-objfile.c: Do not include py-ref.h.
4988         * python/py-param.c: Do not include py-ref.h.
4989         * python/py-prettyprint.c: Do not include py-ref.h.
4990         * python/py-progspace.c: Do not include py-ref.h.
4991         * python/py-symbol.c: Do not include py-ref.h.
4992         * python/py-symtab.c: Do not include py-ref.h.
4993         * python/py-type.c: Do not include py-ref.h.
4994         * python/py-unwind.c: Do not include py-ref.h.
4995         * python/py-utils.c: Do not include py-ref.h.
4996         * python/py-value.c: Do not include py-ref.h.
4997         * python/py-varobj.c: Do not include py-ref.h.
4998         * python/py-xmethods.c: Do not include py-ref.h.
4999         * python/python.c: Do not include py-ref.h.
5000         * varobj.c: Do not include py-ref.h.
5001
5002 2019-01-22  Tom Tromey  <tom@tromey.com>
5003
5004         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5005         keyword for bcache.
5006
5007 2019-01-22  Tom Tromey  <tom@tromey.com>
5008
5009         * compile/compile-cplus-types.c: Remove a comment by #include.
5010
5011 2019-01-22  Tom Tromey  <tom@tromey.com>
5012
5013         * compile/gcc-c-plugin.h: Include compile-internal.h.
5014
5015 2019-01-22  Tom Tromey  <tom@tromey.com>
5016
5017         * stabsread.c (EXTERN): Do not define.
5018         (symnum, next_symbol_text_func, processing_gcc_compilation)
5019         (within_function, global_sym_chain, global_stabs)
5020         (previous_stab_code, this_object_header_files)
5021         (n_this_object_header_files)
5022         (n_allocated_this_object_header_files): Define.
5023         * stabsread.h (EXTERN): Never define.  Use "extern".
5024
5025 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5026
5027         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5028         history_value.
5029
5030 2019-01-21  Tom Tromey  <tom@tromey.com>
5031
5032         * ui-out.c: Fix includes.
5033         * tui/tui-source.c: Fix includes.
5034         * target.c: Fix includes.
5035         * remote.c: Fix includes.
5036         * regcache.c: Fix includes.
5037         * python/py-block.c: Fix includes.
5038         * printcmd.c: Fix includes.
5039         * or1k-tdep.c: Fix includes.
5040         * mi/mi-main.c: Fix includes.
5041         * m32r-tdep.c: Fix includes.
5042         * csky-tdep.c: Fix includes.
5043         * compile/compile-cplus-types.c: Fix includes.
5044         * cli/cli-interp.c: Fix includes.
5045
5046 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5047
5048         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5049         for padding.
5050
5051 2019-01-16  Tom Tromey  <tom@tromey.com>
5052
5053         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5054         earlier.
5055         (struct objfile) <msymbols_range>: Move from top level.
5056         <msymbols>: New method.
5057         (class objfile_msymbols): Remove.
5058         * symtab.c (default_collect_symbol_completion_matches_break_on):
5059         Update.
5060         * symmisc.c (dump_msymbols): Update.
5061         * stabsread.c (scan_file_globals): Update.
5062         * objc-lang.c (info_selectors_command, info_classes_command)
5063         (find_methods): Update.
5064         * minsyms.c (find_solib_trampoline_target): Update.
5065         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5066         * coffread.c (coff_symfile_read): Update.
5067         * ada-lang.c (ada_lookup_simple_minsym)
5068         (ada_collect_symbol_completion_matches): Update.
5069
5070 2019-01-16  Tom Tromey  <tom@tromey.com>
5071
5072         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5073         type.  Remove no-argument constructor.
5074         <iterator::operator++>: Simplify.
5075         <begin>: Update.
5076         <end>: Use minimal_symbol_count.
5077
5078 2019-01-16  Tom Tromey  <tom@tromey.com>
5079
5080         * objfiles.h (struct objfile) <psymtabs>: New method.
5081         (class objfile_psymtabs): Remove.
5082         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5083         typedef.
5084         <range>: New method.
5085         (require_partial_symbols): Change return type.
5086         * psymtab.c (require_partial_symbols)
5087         (psym_expand_symtabs_matching): Update.
5088         * mdebugread.c (parse_partial_symbols): Update.
5089         * dbxread.c (dbx_end_psymtab): Update.
5090
5091 2019-01-15  Tom Tromey  <tom@tromey.com>
5092
5093         * symtab.c (lookup_objfile_from_block)
5094         (lookup_symbol_in_objfile_symtabs)
5095         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5096         (find_line_symtab, info_sources_command)
5097         (default_collect_symbol_completion_matches_break_on)
5098         (make_source_files_completion_list): Update.
5099         * symmisc.c (print_objfile_statistics, dump_objfile)
5100         (maintenance_print_symbols, maintenance_info_symtabs)
5101         (maintenance_check_symtabs, maintenance_info_line_tables):
5102         Update.
5103         * source.c (select_source_symtab)
5104         (forget_cached_source_info_for_objfile): Update.
5105         * objfiles.h (class objfile_compunits): Remove.
5106         (struct objfile) <compunits_range>: New typedef.
5107         (compunits): New method.
5108         * objfiles.c (objfile_relocate1): Update.
5109         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5110         * maint.c (count_symtabs_and_blocks): Update.
5111         * linespec.c (iterate_over_all_matching_symtabs): Update.
5112         * cp-support.c (add_symbol_overload_list_qualified): Update.
5113         * coffread.c (coff_symtab_read): Update.
5114         * ada-lang.c (add_nonlocal_symbols)
5115         (ada_collect_symbol_completion_matches)
5116         (ada_add_global_exceptions): Update.
5117
5118 2019-01-15  Tom Tromey  <tom@tromey.com>
5119
5120         * progspace.h (program_space) <objfiles_safe_range>: New
5121         typedef.
5122         <objfiles_safe>: New method.
5123         * objfiles.h (class all_objfiles_safe): Remove.
5124         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5125         * jit.c (jit_inferior_exit_hook): Update.
5126
5127 2019-01-17  Tom Tromey  <tom@tromey.com>
5128
5129         * progspace.h (program_space) <objfiles_range>: New typedef.
5130         <objfiles>: New method.
5131         <objfiles_head>: Rename from objfiles.
5132         (object_files): Update.
5133         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5134         * guile/scm-pretty-print.c
5135         (ppscm_find_pretty_printer_from_objfiles): Update.
5136         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5137         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5138         Update.
5139         * python/py-progspace.c (pspy_get_objfiles): Update.
5140         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5141         Update.
5142         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5143         (objfpy_lookup_objfile_by_build_id): Update.
5144         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5145         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5146         Update.
5147         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5148         (expand_symtab_containing_pc, lookup_objfile_from_block)
5149         (lookup_static_symbol, basic_lookup_transparent_type)
5150         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5151         (find_line_symtab, info_sources_command)
5152         (default_collect_symbol_completion_matches_break_on)
5153         (make_source_files_completion_list, find_main_name): Update.
5154         * symmisc.c (print_symbol_bcache_statistics)
5155         (print_objfile_statistics, maintenance_print_symbols)
5156         (maintenance_print_msymbols, maintenance_print_objfiles)
5157         (maintenance_info_symtabs, maintenance_check_symtabs)
5158         (maintenance_expand_symtabs, maintenance_info_line_tables):
5159         Update.
5160         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5161         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5162         (map_overlay_command, unmap_overlay_command)
5163         (simple_overlay_update, expand_symtabs_matching)
5164         (map_symbol_filenames): Update.
5165         * symfile-debug.c (set_debug_symfile): Update.
5166         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5167         Update.
5168         * source.c (select_source_symtab, forget_cached_source_info):
5169         Update.
5170         * solib.c (solib_read_symbols): Update.
5171         * solib-spu.c (append_ocl_sos): Update.
5172         * psymtab.c (maintenance_print_psymbols)
5173         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5174         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5175         * printcmd.c (info_symbol_command): Update.
5176         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5177         Update.
5178         * objfiles.h (class all_objfiles): Remove.
5179         * objfiles.c (have_partial_symbols, have_full_symbols)
5180         (have_minimal_symbols, qsort_cmp, update_section_map)
5181         (shared_objfile_contains_address_p)
5182         (default_iterate_over_objfiles_in_search_order): Update.
5183         * objc-lang.c (info_selectors_command, info_classes_command)
5184         (find_methods): Update.
5185         * minsyms.c (find_solib_trampoline_target): Update.
5186         * maint.c (maintenance_info_sections)
5187         (maintenance_translate_address, count_symtabs_and_blocks):
5188         Update.
5189         * main.c (captured_main_1): Update.
5190         * linux-thread-db.c (try_thread_db_load_from_pdir)
5191         (has_libpthread): Update.
5192         * linespec.c (iterate_over_all_matching_symtabs)
5193         (search_minsyms_for_name): Update.
5194         * jit.c (jit_find_objf_with_entry_addr): Update.
5195         * hppa-tdep.c (find_unwind_entry)
5196         (hppa_lookup_stub_minimal_symbol): Update.
5197         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5198         Update.
5199         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5200         (elf_gnu_ifunc_resolve_by_got): Update.
5201         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5202         * dwarf-index-write.c (save_gdb_index_command): Update.
5203         * cp-support.c (add_symbol_overload_list_qualified): Update.
5204         * breakpoint.c (create_overlay_event_breakpoint)
5205         (create_longjmp_master_breakpoint)
5206         (create_std_terminate_master_breakpoint)
5207         (create_exception_master_breakpoint): Update.
5208         * blockframe.c (find_pc_partial_function): Update.
5209         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5210         (ada_collect_symbol_completion_matches)
5211         (ada_add_global_exceptions): Update.
5212
5213 2019-01-17  Tom Tromey  <tom@tromey.com>
5214
5215         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5216         declare VEC.
5217         (solib_target_parse_libraries): Change return type.
5218         (library_list_start_segment, library_list_start_section)
5219         (library_list_end_library, library_list_start_library); Update.
5220         (solib_target_free_library_list): Remove.
5221         (solib_target_parse_libraries): Remove cleanup.  Change return
5222         type.
5223         (solib_target_current_sos): Update.
5224
5225 2019-01-17  Tom Tromey  <tromey@bapiya>
5226
5227         * valprint.c: Replace "the the" with "the".
5228         * symtab.c: Replace "the the" with "the".
5229         * solib.c: Replace "the the" with "the".
5230         * solib-dsbt.c: Replace "the the" with "the".
5231         * linespec.c: Replace "the the" with "the".
5232         * dwarf2loc.h: Replace "the the" with "the".
5233         * amd64-windows-tdep.c: Replace "the the" with "the".
5234         * aarch64-tdep.c: Replace "the the" with "the".
5235
5236 2019-01-16  Keith Seitz  <keiths@redhat.com>
5237
5238         PR gdb/23773
5239         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5240         <builder>: Rename to ..
5241         <m_builder>: ... this and make private.
5242         (dwarf2_cu::get_builder): New method.  Change all users of
5243         `builder' to use this method.
5244         (dwarf2_start_symtab): Move to ...
5245         (dwarf2_cu::start_symtab): ... here.  Update all callers
5246         (setup_type_unit_groups): Move to ...
5247         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5248         callers.
5249         (dwarf2_cu::reset_builder): New method.
5250         (process_full_compunit, process_full_type_unit): Use
5251         dwarf2_cu::reset_builder.
5252         (follow_die_offset): Record the ancestor CU if it is different
5253         from the followed DIE's CU.
5254         (follow_die_sig_1): Likewise.
5255
5256 2019-01-15  Tom Tromey  <tom@tromey.com>
5257
5258         * remote.c (class remote_state) <buf>: Now a char_vector.
5259         <buf_size>: Remove.
5260         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5261         parameter.
5262         (remote_target::getpkt_or_notif_sane_1)
5263         (remote_target::getpkt_sane)
5264         (remote_target::getpkt_or_notif_sane): Likewise.
5265         (class remote_target) <putpkt>: New overload.
5266         (remote_target::read_frame): Change type of "buf_p".  Remove
5267         sizeof_p parameter.
5268         (packet_ok): New overload.
5269         (packet_check_result): New overload.
5270         Update all uses.
5271
5272 2019-01-14  Tom Tromey  <tom@tromey.com>
5273
5274         * remote-notif.c (handle_notification, remote_notif_ack)
5275         (remote_notif_parse): Make "buf" const.
5276         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5277         const.
5278         (remote_notif_parse, remote_notif_ack, handle_notification):
5279         Likewise.
5280         * remote.c (remote_notif_stop_parse): Make "buf" const.
5281         (remote_target::remote_parse_stop_reply): Make "buf" const.
5282         (remote_notif_stop_ack): Make "buf" const.
5283
5284 2019-01-14  Tom Tromey  <tom@tromey.com>
5285
5286         * remote.c (remote_console_output): Make parameter const.
5287
5288 2019-01-14  Tom Tromey  <tom@tromey.com>
5289
5290         * target-debug.h (target_debug_print_signals): Constify.
5291         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5292         * procfs.c (procfs_target::pass_signals): Update.
5293         * linux-nat.c (linux_nat_target::pass_signals): Update.
5294         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5295         * target-delegates.c: Rebuild.
5296         * remote.c (remote_target::program_signals): Update.
5297         (remote_target::pass_signals): Update.
5298         * target.c (target_pass_signals): Constify argument.
5299         (target_program_signals): Likewise.
5300         * target.h (struct target_ops) <pass_signals, program_signals>:
5301         Constify argument.
5302         (target_pass_signals, target_program_signals): Constify argument.
5303
5304 2019-01-14  Tom Tromey  <tom@tromey.com>
5305
5306         PR tui/28819:
5307         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5308
5309 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5310
5311         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5312         field.
5313         * rs6000-tdep.c: Include reggroups.h.
5314         (IS_V_ALIAS_PSEUDOREG): Define.
5315         (rs6000_register_name): Return names for the "vX" aliases.
5316         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5317         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5318         aliases.  Call default_register_reggroup_p for all other
5319         pseudo-registers.
5320         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5321         New functions.
5322         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5323         Handle "vX" aliases.
5324         (v_alias_pseudo_register_collect): New function.
5325         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5326         (rs6000_gdbarch_init): Initialize "vX" aliases as
5327         pseudo-registers.  Restore registration of
5328         rs6000_pseudo_register_reggroup_p with
5329         set_tdesc_pseudo_register_reggroup_p.
5330
5331 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5332
5333         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5334         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5335         set_gdbarch_num_pseudo_regs.
5336
5337 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5338
5339         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5340         Remove arg prefixname, add do_set and do_show.
5341         Add member functions set_list and show_list.
5342         * cli/cli-style.c (class cli_style_option): Update accordingly.
5343         (style_set_list): Move to file scope.
5344         (style_show_list): Likewise.
5345         (set_style): Call help_list.
5346         (show_style): Call cmd_show_list.
5347         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5348         Update to use the new macro.
5349
5350 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5351
5352         * ada-lang.c (_initialize_ada_language): Expand the help text
5353         for the "catch exception" command.
5354
5355 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5356
5357         * symtab.c (matching_obj_sections): Initialize obj,
5358         declare it closer to its usage.
5359
5360 2019-01-10  Tom Tromey  <tom@tromey.com>
5361
5362         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5363         (basic_inf_threads_range): Remove.
5364         (inf_threads_range, inf_non_exited_threads_range)
5365         (safe_inf_threads_range): Use next_adapter.
5366
5367 2019-01-10  Keith Seitz  <keiths@redhat.com>
5368
5369         PR gdb/23712
5370         PR symtab/23010
5371         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5372         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5373
5374 2019-01-10  Keith Seitz  <keiths@redhat.com>
5375
5376         PR gdb/23712
5377         PR symtab/23010
5378         * dictionary.c (pending_to_vector): Remove.
5379         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5380         Remove _1 suffix, replacing functions of the same name.  Update
5381         all callers.
5382         (dict_create_hashed, dict_create_hashed_expandable)
5383         (dict_create_linear, dict_create_linear_expandable, dict_free)
5384         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5385         Make functions static.
5386
5387 2019-01-10  Keith Seitz  <keiths@redhat.com>
5388
5389         PR gdb/23712
5390         PR symtab/23010
5391         * dictionary.h (struct dictionary): Replace declaration with
5392         multidictionary.
5393         (dict_create_hashed, dict_create_hashed_expandable)
5394         (dict_create_linear, dict_create_linear_expandable)
5395         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5396         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5397         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5398         taking multidictionary argument.
5399         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5400         * block.h (struct block) <dict>: Change to multidictionary
5401         and rename `multidict'.
5402         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5403         symmisc.c: Update all dictionary references to multidictionary.
5404
5405 2019-01-10  Keith Seitz  <keiths@redhat.com>
5406
5407         PR gdb/23712
5408         PR symtab/23010
5409         * dictionary.c: Include unordered_map.
5410         (pending_to_vector): New function.
5411         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5412         Rewrite the non-"_1" functions to take vector instead
5413         of linked list.
5414         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5415         "new" _1 versions of the same name.
5416         (multidictionary): Define.
5417         (std::hash<enum language): New definition.
5418         (collate_pending_symbols_by_language, mdict_create_hashed)
5419         (mdict_create_hashed_expandable, mdict_create_linear)
5420         (mdict_create_linear_expandable, mdict_free)
5421         (find_language_dictionary, create_new_language_dictionary)
5422         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5423         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5424         (mdict_size, mdict_empty): New functions.
5425         * dictionary.h (mdict_iterator): Define.
5426
5427 2019-01-10  Pedro Alves  <palves@redhat.com>
5428
5429         * breakpoint.c (read_uploaded_action)
5430         (create_tracepoint_from_upload): Adjust to use
5431         gdb::unique_xmalloc_ptr.
5432         * ctf.c (ctf_write_uploaded_tp):
5433         (SET_ARRAY_FIELD): Use emplace_back.
5434         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5435         * tracefile-tfile.c (tfile_write_uploaded_tp):
5436         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5437         gdb::unique_xmalloc_ptr.
5438         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5439         at_string, cond_string, cmd_strings>: Replace char pointers
5440         with gdb::unique_xmalloc_ptr.
5441
5442 2019-01-10  Pedro Alves  <palves@redhat.com>
5443
5444         * solib-target.c (library_list_start_library): Don't xstrdup name.
5445
5446 2019-01-10  Pedro Alves  <palves@redhat.com>
5447
5448         * mdebugread.c (parse_partial_symbols): Use
5449         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5450
5451 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5452
5453         * linux-fork.c (scoped_switch_fork_info)
5454         <~scoped_switch_fork_info>: Fix incorrect variable name.
5455
5456 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5457
5458         * linux-fork.c (scoped_switch_fork_info)
5459         <scoped_switch_fork_info>: Make explicit.
5460         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5461
5462 2019-01-10  Tom Tromey  <tom@tromey.com>
5463
5464         * objfiles.h (objfile::reset_psymtabs): Update.
5465         * objfiles.c (objfile::objfile): Update.
5466         * psymtab.h (psymtab_storage::obstack): Update.
5467         (psymtab_storage::m_obstack): Use gdb::optional.
5468         (class psymtab_storage): Update comment.  Remove objfile
5469         parameter.
5470         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5471
5472 2019-01-10  Tom Tromey  <tom@tromey.com>
5473
5474         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5475         <free_psymtabs>: Now private.
5476         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5477         (allocate_psymtab): Use new method.
5478
5479 2019-01-10  Tom Tromey  <tom@tromey.com>
5480
5481         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5482         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5483         * mdebugread.c (parse_partial_symbols): Use
5484         allocate_dependencies.
5485         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5486         allocate_dependencies.
5487         (process_psymtab_comp_unit_reader)
5488         (build_type_psymtab_dependencies): Likewise.
5489         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5490
5491 2019-01-10  Tom Tromey  <tom@tromey.com>
5492
5493         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5494         PSYMBOL_SET_LANGUAGE.
5495         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5496
5497 2019-01-10  Tom Tromey  <tom@tromey.com>
5498
5499         * psymtab.h (psymtab_storage::obstack): New method.
5500         <m_obstack>: Rename from obstack; now private.
5501         * psymtab.c (psymtab_storage): Update.
5502         * dwarf2read.c (create_addrmap_from_index)
5503         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5504         Update.
5505
5506 2019-01-10  Tom Tromey  <tom@tromey.com>
5507
5508         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5509         * objfiles.h (objfile::reset_psymtabs): New method.
5510
5511 2019-01-10  Tom Tromey  <tom@tromey.com>
5512
5513         * symmisc.c (print_symbol_bcache_statistics): Update.
5514         (print_objfile_statistics): Update.
5515         * symfile.c (reread_symbols): Update.
5516         * psymtab.h (class psymtab_storage): New.
5517         * psymtab.c (psymtab_storage): New constructor.
5518         (~psymtab_storage): New destructor.
5519         (require_partial_symbols): Update.
5520         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5521         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5522         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5523         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5524         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5525         (start_psymtab_common, end_psymtab_common)
5526         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5527         (allocate_psymtab): Update.
5528         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5529         Update.
5530         (dump_psymtab_addrmap, maintenance_print_psymbols)
5531         (maintenance_check_psymtabs): Update.
5532         (class objfile_psymtabs): Move to objfiles.h.
5533         * psympriv.h (discard_psymtab): Now inline.
5534         (psymtab_discarder::psymtab_discarder): Update.
5535         (psymtab_discarder::~psymtab_discarder): Update.
5536         (ALL_OBJFILE_PSYMTABS): Rewrite.
5537         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5538         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5539         Remove fields.
5540         <partial_symtabs>: New field.
5541         (class objfile_psymtabs): Move from psymtab.h.  Update.
5542         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5543         psymbol_cache.
5544         (objfile::~objfile): Don't destroy psymbol_cache.
5545         * mdebugread.c (parse_partial_symbols): Update.
5546         * dwarf2read.c (create_addrmap_from_index)
5547         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5548         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5549         (add_partial_subprogram, dwarf2_ranges_read): Update.
5550         * dwarf-index-write.c (write_address_map)
5551         (write_one_signatured_type, recursively_write_psymbols)
5552         (class debug_names, class debug_names, write_psymtabs_to_index):
5553         Update.
5554
5555 2019-01-10  Tom Tromey  <tom@tromey.com>
5556
5557         * symtab.h (SYMBOL_SET_NAMES): Update.
5558         (symbol_set_names): Update.
5559         (MSYMBOL_SET_NAMES): Update.
5560         * symtab.c (symbol_set_names): Change argument to be an
5561         objfile_per_bfd_storage.
5562         * psymtab.c (add_psymbol_to_bcache): Update.
5563         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5564
5565 2019-01-10  Tom Tromey  <tom@tromey.com>
5566
5567         * symtab.c (create_demangled_names_hash): Change argument to be an
5568         objfile_per_bfd_storage.
5569         (symbol_set_names): Update.
5570
5571 2019-01-10  Tom Tromey  <tom@tromey.com>
5572
5573         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5574         init_psymbol_list.
5575         * psymtab.c (init_psymbol_list): Do nothing if already called.
5576         * psympriv.h (init_psymbol_list): Add comment.
5577         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5578         init_psymbol_list.
5579         * dbxread.c (dbx_symfile_read): Unconditionally call
5580         init_psymbol_list.
5581
5582 2019-01-10  Tom Tromey  <tom@tromey.com>
5583
5584         * xcoffread.c (scan_xcoff_symtab): Update.
5585         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5586         "where".
5587         * mdebugread.c (parse_partial_symbols)
5588         (handle_psymbol_enumerators): Update.
5589         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5590         * dbxread.c (read_dbx_symtab): Update.
5591         * psympriv.h (psymbol_placement): New enum.
5592         (add_psymbol_to_list): Update.
5593
5594 2019-01-10  Tom Tromey  <tom@tromey.com>
5595
5596         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5597         static_psymbols parameters.
5598         (scan_xcoff_symtab): Update.
5599         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5600         static_psymbols parameters.
5601         * psympriv.h (start_psymtab_common): Update.
5602         * mdebugread.c (parse_partial_symbols): Update.
5603         * dwarf2read.c (create_partial_symtab): Update.
5604         * dbxread.c (read_dbx_symtab): Update.
5605         (start_psymtab): Remove global_psymbols and static_psymbols
5606         parameters.
5607
5608 2019-01-10  Tom Tromey  <tom@tromey.com>
5609
5610         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5611         * psymtab.c (allocate_psymtab): Add comment.
5612         * psympriv.h (allocate_psymtab): Add comment.
5613         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5614         initializations.
5615         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5616
5617 2019-01-10  Tom Tromey  <tom@tromey.com>
5618
5619         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5620         Don't declare.
5621         * mipsread.c: Include mdebugread.h.
5622         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5623         Declare.
5624         * elfread.c: Include mdebugread.h.
5625
5626 2019-01-09  Tom Tromey  <tom@tromey.com>
5627
5628         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5629         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5630         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5631         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5632         (psym_lookup_symbol, psym_find_last_source_symtab)
5633         (psym_forget_cached_source_info, psym_print_stats)
5634         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5635         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5636         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5637         (psym_find_compunit_symtab_by_address)
5638         (maintenance_print_psymbols, maintenance_info_psymtabs)
5639         (maintenance_check_psymtabs): Use ranged for.
5640         * psymtab.h (class objfile_psymtabs): New.
5641         (require_partial_symbols): Return objfile_psymtabs.
5642         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5643
5644 2019-01-09  Tom Tromey  <tom@tromey.com>
5645
5646         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5647         (find_pc_mapped_section, list_overlays_command)
5648         (map_overlay_command, unmap_overlay_command)
5649         (simple_overlay_update): Use all_objfiles.
5650         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5651         * printcmd.c (info_symbol_command): Use all_objfiles.
5652         * objfiles.h (ALL_OBJSECTIONS): Remove.
5653         * maint.c (maintenance_translate_address): Use all_objfiles.
5654         * gcore.c (gcore_create_callback): Use all_objfiles.
5655         (objfile_find_memory_regions): Likewise.
5656
5657 2019-01-09  Tom Tromey  <tom@tromey.com>
5658
5659         * symtab.c (find_line_symtab, info_sources_command)
5660         (make_source_files_completion_list): Use objfile_compunits.
5661         * source.c (select_source_symtab): Use objfile_compunits.
5662         * objfiles.h (struct objfile): Update comment.
5663         (ALL_OBJFILES): Remove.
5664         (ALL_FILETABS): Remove.
5665         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5666         objfile_compunits.
5667
5668 2019-01-09  Tom Tromey  <tom@tromey.com>
5669
5670         * symmisc.c (print_objfile_statistics, dump_objfile)
5671         (maintenance_print_symbols): Use compunit_filetabs.
5672         * source.c (forget_cached_source_info_for_objfile): Use
5673         compunit_filetabs.
5674         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5675         (ALL_FILETABS): Use compunit_filetabs.
5676         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5677         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5678
5679 2019-01-09  Tom Tromey  <tom@tromey.com>
5680
5681         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5682         (compunit_filetabs): New.
5683         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5684         compunit_filetabs.
5685         (info_sources_command, make_source_files_completion_list): Remove
5686         declaration.
5687         * symmisc.c (print_objfile_statistics, dump_objfile)
5688         (maintenance_print_symbols): Remove declaration.
5689         (maintenance_info_symtabs): Use compunit_filetabs.
5690         (maintenance_info_line_tables): Likewise.
5691         * source.c (select_source_symtab): Change local variable name.
5692         (forget_cached_source_info_for_objfile): Remove declaration.
5693         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5694         * objfiles.c (objfile_relocate1): Remove declaration.
5695         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5696         declaration.
5697         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5698         * coffread.c (coff_symtab_read): Remove declaration.
5699         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5700         compunit_filetabs.
5701
5702 2019-01-09  Tom Tromey  <tom@tromey.com>
5703
5704         * symtab.c (lookup_objfile_from_block)
5705         (find_pc_sect_compunit_symtab, search_symbols)
5706         (default_collect_symbol_completion_matches_break_on): Use
5707         objfile_compunits.
5708         * objfiles.h (ALL_COMPUNITS): Remove.
5709         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5710         * cp-support.c (add_symbol_overload_list_qualified): Use
5711         objfile_compunits.
5712         * ada-lang.c (ada_collect_symbol_completion_matches)
5713         (ada_add_global_exceptions): Use objfile_compunits.
5714
5715 2019-01-09  Tom Tromey  <tom@tromey.com>
5716
5717         * source.c (select_source_symtab)
5718         (forget_cached_source_info_for_objfile): Remove declaration.
5719         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5720         declaration.
5721         * maint.c (count_symtabs_and_blocks): Remove declaration.
5722         * cp-support.c (add_symbol_overload_list_qualified): Remove
5723         declaration.
5724         * coffread.c (coff_symtab_read): Remove declaration.
5725         * symtab.c (lookup_symbol_in_objfile_symtabs)
5726         (basic_lookup_transparent_type_1): Use objfile_compunits.
5727         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5728         (info_sources_command, search_symbols)
5729         (default_collect_symbol_completion_matches_break_on)
5730         (make_source_files_completion_list): Remove declaration.
5731         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5732         (ada_collect_symbol_completion_matches)
5733         (ada_add_global_exceptions): Remove declaration.
5734         * linespec.c (iterate_over_all_matching_symtabs): Use
5735         objfile_compunits.
5736         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5737         (class objfile_compunits): New.
5738         (ALL_COMPUNITS): Use objfile_compunits.
5739         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5740         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5741         objfile_compunits.
5742         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5743
5744 2019-01-09  Tom Tromey  <tom@tromey.com>
5745
5746         * symtab.c (search_symbols)
5747         (default_collect_symbol_completion_matches_break_on): Use
5748         objfile_msymbols.
5749         * ada-lang.c (ada_lookup_simple_minsym)
5750         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5751         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5752         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5753         objfile_msymbols.
5754         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5755         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5756         * objc-lang.c (find_methods): Use objfile_msymbols.
5757         (info_selectors_command, info_classes_command): Likewise.
5758         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5759         * objfiles.h (class objfile_msymbols): New.
5760         (ALL_OBJFILE_MSYMBOLS): Remove.
5761         (ALL_MSYMBOLS): Remove.
5762
5763 2019-01-09  Tom Tromey  <tom@tromey.com>
5764
5765         * common/next-iterator.h (next_adapter): Add Iterator template
5766         parameter.
5767         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5768         (class all_objfiles_safe): New.
5769         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5770         * objfiles.c (put_objfile_before): Update comment.
5771         (add_separate_debug_objfile): Likewise.
5772         (free_all_objfiles): Use all_objfiles_safe.
5773         (objfile_purge_solibs): Likewise.
5774
5775 2019-01-09  Tom Tromey  <tom@tromey.com>
5776
5777         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5778         (expand_symtab_containing_pc, lookup_static_symbol)
5779         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5780         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5781         all_objfiles.
5782         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5783         * breakpoint.c (create_overlay_event_breakpoint)
5784         (create_longjmp_master_breakpoint)
5785         (create_std_terminate_master_breakpoint)
5786         (create_exception_master_breakpoint): Use all_objfiles.
5787         * linux-thread-db.c (try_thread_db_load_from_pdir)
5788         (has_libpthread): Use all_objfiles.
5789         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5790         * linespec.c (iterate_over_all_matching_symtabs)
5791         (search_minsyms_for_name): Use all_objfiles.
5792         * maint.c (maintenance_info_sections): Use all_objfiles.
5793         * main.c (captured_main_1): Use all_objfiles.
5794         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5795         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5796         * guile/scm-pretty-print.c
5797         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5798         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5799         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5800         (maintenance_print_msymbols): Use all_objfiles.
5801         * source.c (select_source_symtab): Use all_objfiles.
5802         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5803         * symfile.c (remove_symbol_file_command)
5804         (expand_symtabs_matching, map_symbol_filenames): Use
5805         all_objfiles.
5806         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5807         all_objfiles.
5808         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5809         * objc-lang.c (find_methods): Use all_objfiles.
5810         * objfiles.c (have_partial_symbols, have_full_symbols)
5811         (have_minimal_symbols, qsort_cmp)
5812         (default_iterate_over_objfiles_in_search_order): Use
5813         all_objfiles.
5814         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5815         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5816         (maintenance_check_psymtabs): Use all_objfiles.
5817         (ALL_PSYMTABS): Remove.
5818         * compile/compile-object-run.c (do_module_cleanup): Use
5819         all_objfiles.
5820         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5821         * cp-support.c (add_symbol_overload_list_qualified): Use
5822         all_objfiles.
5823         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5824         Use all_objfiles.
5825         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5826         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5827         all_objfiles.
5828         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5829         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5830         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5831         Uses all_objfiles.
5832         * solib.c (solib_read_symbols): Use all_objfiles
5833
5834 2019-01-09  Tom Tromey  <tom@tromey.com>
5835
5836         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5837         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5838         all_objfiles.
5839         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5840         * symmisc.c (print_symbol_bcache_statistics)
5841         (print_objfile_statistics, maintenance_print_objfiles)
5842         (maintenance_info_symtabs, maintenance_check_symtabs)
5843         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5844         all_objfiles.
5845         * source.c (forget_cached_source_info): Use all_objfiles.
5846         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5847         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5848         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5849         * objfiles.c (update_section_map): Use all_objfiles.
5850         (shared_objfile_contains_address_p): Likewise.
5851         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5852         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5853
5854 2019-01-09  Tom Tromey  <tom@tromey.com>
5855
5856         * common/next-iterator.h: New file.
5857         * objfiles.h (class all_objfiles): New.
5858         (struct objfile_iterator): New.
5859
5860 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5861
5862         * NEWS: Move the description of the changed "frame", "select-frame",
5863          and "info frame" commands to the Changed commands section.
5864
5865 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5866
5867         * gdbtypes.c (check_stub_method_group): Remove handling of old
5868         mangling schemes.
5869         * linespec.c (find_methods): Likewise.
5870         * stabsread.c (read_member_functions): Likewise.
5871         * valops.c (search_struct_method): Likewise.
5872         (value_struct_elt_for_reference): Likewise.
5873         * NEWS: Mention this change.
5874
5875 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5876
5877         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5878         print_source_lines.
5879         * source.c (print_source_lines_base): Update line number check.
5880         (print_source_lines): New function.
5881         (source_lines_range::source_lines_range): New function.
5882         * source.h (class source_lines_range): New class.
5883         (print_source_lines): New declaration.
5884
5885 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5886
5887         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5888
5889 2019-01-08  Tom Tromey  <tom@tromey.com>
5890             Simon Marchi  <simon.marchi@ericsson.com>
5891
5892         PR gdb/24060
5893         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5894         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5895         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5896         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5897         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5898         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5899
5900 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5901
5902         * source.c (select_source_symtab): Move header comment to
5903         declaration in source.h.
5904         (forget_cached_source_info_for_objfile): Likewise.
5905         (forget_cached_source_info): Likewise.
5906         (identify_source_line): Likewise.
5907         * source.h (identify_source_line): Move declaration from symtab.h
5908         and add comment from source.c
5909         (print_source_lines): Likewise.
5910         (forget_cached_source_info_for_objfile): Likewise.
5911         (forget_cached_source_info): Likewise.
5912         (select_source_symtab): Likewise.
5913         (enum print_source_lines_flag): Move definition from symtab.h.
5914         * symtab.h (identify_source_line): Move declaration to source.h.
5915         (print_source_lines): Likewise.
5916         (forget_cached_source_info_for_objfile): Likewise.
5917         (forget_cached_source_info): Likewise.
5918         (select_source_symtab): Likewise.
5919         (enum print_source_lines_flag): Move definition to source.h.
5920         * tui/tui-hooks.c: Add 'source.h' include.
5921
5922 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5923
5924         * source.c (print_source_lines_base): Handle requests to print
5925         reverse line number sequences, and guard against empty lines
5926         string.
5927
5928 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * source.c (print_source_lines_base): Fix skip of '\r' if next
5931         character is '\n'.
5932
5933 2019-01-06  Tom Tromey  <tom@tromey.com>
5934
5935         * c-exp.y (struct c_parse_state) <macro_original_text,
5936         expansion_obstack>: New member.
5937         (macro_original_text, expansion_obstack): Remove globals.
5938         (scan_macro_expansion, scanning_macro_expansion)
5939         (finished_macro_expansion): Update.
5940         (scan_macro_cleanup): Remove.
5941         (yylex, c_parse): Update.
5942
5943 2019-01-06  Tom Tromey  <tom@tromey.com>
5944
5945         * c-exp.y (struct c_parse_state) <strings>: New member.
5946         (operator_stoken): Update.
5947
5948 2019-01-06  Tom Tromey  <tom@tromey.com>
5949
5950         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5951         (union type_stack_elt) <typelist_val>: Now a pointer to
5952         std::vector.
5953         (type_stack_cleanup): Don't declare.
5954         (push_typelist): Update.
5955         * parse.c (pop_typelist): Return a std::vector.
5956         (push_typelist): Take a std::vector.
5957         (follow_types): Update.  Do not free args.
5958         (type_stack_cleanup): Remove.
5959         * c-exp.y (struct c_parse_state): New.
5960         (cpstate): New global.
5961         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5962         (nonempty_typelist): Update.
5963         (func_mod): Create a new vector.
5964         (c_parse): Create a c_parse_state.
5965         (check_parameter_typelist): Do not delete params.
5966         (function_method): Update.  Do not delete type_list.
5967
5968 2019-01-06  Tom Tromey  <tom@tromey.com>
5969
5970         PR gdb/28155:
5971         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5972         check_typedef.
5973         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5974         (print_return_value): Likewise.
5975
5976 2019-01-05  Tom Tromey  <tom@tromey.com>
5977
5978         * contrib/cleanup_check.py: Remove.
5979         * contrib/gcc-with-excheck: Remove.
5980         * contrib/exsummary.py: Remove.
5981         * contrib/excheck.py: Remove.
5982
5983 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5984
5985         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5986         NULL. Initialize tpprev to NULL instead of assigning it
5987         to NULL on the next statement.
5988         * windows-nat.c (windows_delete_thread): Remove check for
5989         main_thread_id before printing thread exit notifications.
5990         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5991         Remove thread ID check against main_thread_id.
5992         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5993         windows_delete_thread.
5994         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5995
5996 2019-01-04  Tom Tromey  <tom@tromey.com>
5997
5998         * compile/compile.c (_initialize_compile): Use upper case for
5999         metasyntactic variables.
6000         * symmisc.c (_initialize_symmisc): Use upper case for
6001         metasyntactic variables.
6002         * psymtab.c (_initialize_psymtab): Use upper case for
6003         metasyntactic variables.
6004         * demangle.c (demangle_command): Use upper case for metasyntactic
6005         variables.
6006         (_initialize_demangler): Likewise.
6007         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6008         variables.
6009
6010 2019-01-03  Tom Tromey  <tom@tromey.com>
6011
6012         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6013
6014 2019-01-03  Tom Tromey  <tom@tromey.com>
6015
6016         * python/py-symtab.c (salpy_str): Update.
6017         (struct salpy_sal_object) <symtab>: Now a PyObject.
6018         (salpy_dealloc): Update.
6019         (del_objfile_sal): Use gdbpy_ref.
6020
6021 2019-01-03  Tom Tromey  <tom@tromey.com>
6022
6023         * python/py-type.c (convert_field): Use new_reference.  Return
6024         gdbpy_ref.
6025         (make_fielditem): Return gdbpy_ref.
6026         (typy_fields): Update.
6027         (typy_getitem): Update.
6028         (field_name): Return gdbpy_ref.  Use new_reference.
6029         (typy_iterator_iternext): Update.
6030
6031 2019-01-03  Tom Tromey  <tom@tromey.com>
6032
6033         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6034
6035 2019-01-03  Tom Tromey  <tom@tromey.com>
6036
6037         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6038         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6039         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6040         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6041         (pspy_set_type_printers): Likewise.
6042         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6043         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6044         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6045         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6046         (objfpy_set_type_printers): Likewise.
6047
6048 2019-01-03  Tom Tromey  <tom@tromey.com>
6049
6050         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6051         (gdbpy_print_stack): Use gdbpy_err_fetch.
6052         * python/python-internal.h (class gdbpy_err_fetch): New class.
6053         (class gdbpy_enter) <m_error_type, m_error_value,
6054         m_error_traceback>: Remove.
6055         <m_error>: New member.
6056         (gdbpy_exception_to_string): Don't declare.
6057         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6058         * python/py-value.c (convert_value_from_python): Use
6059         gdbpy_err_fetch.
6060         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6061         gdbpy_exception_to_string.
6062         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6063         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6064         gdbpy_err_fetch.
6065
6066 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6067
6068         * linux-nat.c (delete_lwp_cleanup): Delete.
6069         (struct lwp_deleter): New struct.
6070         (lwp_info_up): New typedef.
6071         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6072         lwp_info_up.
6073
6074 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6075
6076         * linux-fork.c (class scoped_switch_fork_info): New class.
6077         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6078
6079 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * valops.c (find_overload_match): Remove use of null_cleanup, and
6082         calls to do_cleanups.
6083
6084 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6085
6086         * compile/compile-cplus-types.c
6087         (compile_cplus_instance::decl_name): Handle changes to
6088         cp_func_name.
6089         * cp-support.c (cp_func_name): Update header comment, update
6090         return type.
6091         * cp-support.h (cp_func_name): Update return type in declaration.
6092         * valops.c (find_overload_match): Move temp_func local to top
6093         level of function and change its type.  Use temp_func to hold and
6094         delete temporary string obtained from cp_func_name.
6095
6096 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6097
6098         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6099         gdb::char_vector, remove cleanup, and update uses of `msg`.
6100
6101 2019-01-03  Jim Wilson  <jimw@sifive.com>
6102
6103         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6104
6105 2019-01-02  Tom Tromey  <tom@tromey.com>
6106
6107         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6108         (tdesc_parse_xml): Remove cleanups.
6109         * target-descriptions.h (make_cleanup_free_target_description):
6110         Don't declare.
6111         (target_desc_deleter): New struct.
6112         (target_desc_up): New typedef.
6113         * target-descriptions.c (target_desc_deleter::operator()): Rename
6114         from free_target_description.
6115         (make_cleanup_free_target_description): Remove.
6116
6117 2019-01-02  Tom Tromey  <tom@tromey.com>
6118
6119         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6120         constructor, destructor.
6121         (linespec_parser): Remove typedef.
6122         (~linespec_parser): Rename from linespec_parser_delete.
6123         (linespec_lex_to_end, linespec_complete_label)
6124         (linespec_complete): Update.
6125         (decode_line_full): Remove cleanups.
6126         (decode_line_1): Update.
6127
6128 2019-01-02  Tom Tromey  <tom@tromey.com>
6129
6130         * python/python-internal.h (inferior_to_inferior_object): Change
6131         return type.
6132         * python/py-exitedevent.c (create_exited_event_object): Update.
6133         * python/py-inferior.c (inferior_to_inferior_object): Return
6134         gdbpy_ref.
6135         (python_new_inferior, python_inferior_deleted)
6136         (thread_to_thread_object, delete_thread_object)
6137         (build_inferior_list, gdbpy_selected_inferior): Update.
6138         * python/py-infthread.c (create_thread_object): Update.  Also fail
6139         if inferior_to_inferior_object fails.
6140
6141 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6142
6143         * inferior.h (class inferior) <displaced_step_state>: New field.
6144         * infrun.h (struct displaced_step_state): Move here from
6145         infrun.c.  Initialize fields, add constructor.
6146         <inf>: Remove field.
6147         <reset>: New method.
6148         * infrun.c (struct displaced_step_inferior_state): Move to
6149         infrun.h.
6150         (displaced_step_inferior_states): Remove.
6151         (get_displaced_stepping_state): Adust.
6152         (displaced_step_in_progress_any_inferior): Adjust.
6153         (displaced_step_in_progress_thread): Adjust.
6154         (displaced_step_in_progress): Adjust.
6155         (add_displaced_stepping_state): Remove.
6156         (get_displaced_step_closure_by_addr): Adjust.
6157         (remove_displaced_stepping_state): Remove.
6158         (infrun_inferior_exit): Call displaced_step_state.reset.
6159         (use_displaced_stepping): Don't check for NULL.
6160         (displaced_step_prepare_throw): Call
6161         get_displaced_stepping_state.
6162         (displaced_step_fixup): Don't check for NULL.
6163         (prepare_for_detach): Don't check for NULL.
6164
6165 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6166
6167         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6168          in case of call that did not complete.
6169
6170 2019-01-02  Andrey Utkin  <autkin@undo.io>
6171
6172         * symfile.c (find_separate_debug_file): Fix search of debug files for
6173         remote debuggee.
6174
6175 2019-01-02  Tom Tromey  <tom@tromey.com>
6176
6177         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6178         indentation.
6179         * python/py-frame.c (frapy_older): Remove cast.
6180         (frapy_newer): Likewise.
6181         * python/py-breakpoint.c (local_setattro): Remove cast.
6182         * python/py-arch.c (archpy_name): Remove local variable.
6183         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6184
6185 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6186
6187         * unittests/basic_string_view/element_access/char/empty.cc:
6188         Fix year range in copyright header.
6189
6190 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6191
6192         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6193         Delete.
6194         <operator==>: Update with for removed field.
6195         <hash>: Likewise.
6196         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6197         <isa_features>: ...this.
6198         <abi_features>: New field.
6199         (riscv_isa_flen): Update comment.
6200         (riscv_abi_xlen): New declaration.
6201         (riscv_abi_flen): New declaration.
6202         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6203         isa_features.
6204         (riscv_abi_xlen): New function.
6205         (riscv_isa_flen): Update to get answer from isa_features.
6206         (riscv_abi_flen): New function.
6207         (riscv_has_fp_abi): Update to get answer from abi_features.
6208         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6209         xlen and flen.
6210         (riscv_call_info) <xlen, flen>: Update comment.
6211         (riscv_call_arg_struct): Remove invalid assertions
6212         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6213         is removed.
6214         (riscv_gdbarch_init): Gather isa features and abi features
6215         separately, ensure both match on the gdbarch when reusing an old
6216         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6217         a target with 64-bit float hardware.
6218
6219 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6220
6221         * source.c (search_command_helper): Stop reverse search
6222         when line 1 has been searched.
6223
6224 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6225
6226         * record-full.c (record_full_base_target::close): Rewrite
6227         record_full_core_buf_list free logic.
6228
6229 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6230
6231         * break-catch-syscall.c (print_one_catch_syscall): xfree
6232         the last text.
6233
6234 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6235
6236         * top.c (print_gdb_version): Update Copyright year in version
6237         message.
6238
6239 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6240
6241         Update copyright year range in all GDB files.
6242
6243 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6244
6245         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6246
6247 For older changes see ChangeLog-2018.
6248 \f
6249 Local Variables:
6250 mode: change-log
6251 left-margin: 8
6252 fill-column: 74
6253 version-control: never
6254 coding: utf-8
6255 End:
6256