gdb/ChangeLog

   1 2019-08-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
   4         * tui/tui-regs.c (tui_data_window::show_registers): Update.
   5         (tui_data_window::check_register_values): Update.
   6
   7 2019-08-20  Tom Tromey  <tom@tromey.com>
   8
   9         * tui/tui-regs.h (struct tui_data_window): Use
  10         DISABLE_COPY_AND_ASSIGN.
  11         <regs_content>: Change type, removing unique_ptr.
  12         <tui_data_window>: Add move constructor.
  13         * tui/tui-regs.c (tui_data_window::show_registers)
  14         (tui_data_window::show_register_group)
  15         (tui_data_window::display_registers_from)
  16         (tui_data_window::display_registers_from)
  17         (tui_data_window::first_data_item_displayed)
  18         (tui_data_window::delete_data_content_windows)
  19         (tui_data_window::rerender, tui_data_window::refresh_window)
  20         (tui_data_window::check_register_values): Update.
  21
  22 2019-08-20  Tom Tromey  <tom@tromey.com>
  23
  24         * tui/tui-regs.h (struct tui_data_window) <show_registers,
  25         show_register_group>: Declare.
  26         (tui_show_register_group): Don't declare.
  27         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
  28         tui_show_registers.
  29         (tui_data_window::show_register_group): Rename from
  30         tui_show_register_group.
  31         (tui_data_window::check_register_values, tui_reg_command):
  32         Update.
  33         * tui/tui-layout.c (tui_set_layout): Update.
  34
  35 2019-08-20  Tom Tromey  <tom@tromey.com>
  36
  37         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
  38         Declare.
  39         (tui_check_register_values): Don't declare.
  40         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
  41         from tui_check_register_values.
  42         * tui/tui-hooks.c (tui_register_changed): Update.
  43
  44 2019-08-20  Tom Tromey  <tom@tromey.com>
  45
  46         * tui/tui-regs.c (tui_reg_layout): Move later.
  47         (tui_show_registers): Don't enable TUI mode or change layout.
  48
  49 2019-08-20  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-regs.h (struct tui_data_item_window)
  52         <~tui_data_item_window>: Remove.
  53         <content>: Now a unique_xmalloc_ptr.
  54         * tui/tui-regs.c (tui_register_format): Return a
  55         unique_xmalloc_ptr.
  56         (tui_get_register): Update.
  57         (~tui_data_item_window): Remove.
  58         (tui_data_window::display_registers_from, tui_display_register):
  59         Update.
  60         * tui/tui-io.h (tui_expand_tabs): Update.
  61         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
  62         Remove "col" parameter.
  63
  64 2019-08-20  Tom Tromey  <tom@tromey.com>
  65
  66         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
  67         field.
  68         * tui/tui-regs.c (~tui_data_item_window): Update.
  69
  70 2019-08-20  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
  73         earlier.
  74
  75 2019-08-20  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
  78
  79 2019-08-20  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-source.h (struct tui_source_window): Update.
  82         * tui/tui-regs.c (tui_show_registers): Update.
  83         * tui/tui-disasm.h (struct tui_disasm_window): Update.
  84         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
  85         (NO_REGS_STRING): Remove defines.
  86
  87 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
  88
  89         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
  90         unnecessary thread walk if remote doesn't support the packet.
  91
  92 2019-08-19  Tom Tromey  <tromey@adacore.com>
  93
  94         * python/py-value.c (value_has_field): Fix indentation.
  95
  96 2019-08-19  Tom Tromey  <tromey@adacore.com>
  97
  98         * printcmd.c (do_one_display, info_display_command): Update.
  99         * block.h (contained_in): Return bool.  Add allow_nested
 100         parameter.
 101         * block.c (contained_in): Return bool.  Add allow_nested
 102         parameter.
 103
 104 2019-08-19  Tom Tromey  <tom@tromey.com>
 105
 106         * configure: Rebuild.
 107         * configure.ac: Disallow the combination of -static-libstdc++ and
 108         source highlight.
 109         * source-cache.c (get_language_name): Handle rust.
 110         (source_cache::get_source_lines): Ignore highlighting exceptions.
 111
 112 2019-08-16  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 115         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 116         (struct tui_source_window_base) <make_visible, refresh_window,
 117         resize>: Remove methods.
 118         <execution_info>: Remove field.
 119         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 120         (tui_show_source_line, tui_source_window_base)
 121         (~tui_source_window_base): Update.
 122         (tui_source_window_base::resize)
 123         (tui_source_window_base::make_visible)
 124         (tui_source_window_base::refresh_window): Remove.
 125         (tui_source_window_base::update_exec_info): Update.
 126         * tui/tui-source.c (tui_source_window::set_contents): Update.
 127         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 128
 129 2019-08-16  Tom Tromey  <tom@tromey.com>
 130
 131         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 132         deprecated_query_hook.
 133
 134 2019-08-16  Tom Tromey  <tom@tromey.com>
 135
 136         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 137         (tui_update_source_windows_with_line): Update.
 138         * tui/tui-source.h (struct tui_source_window)
 139         <show_symtab_source>: Declare.
 140         (tui_show_symtab_source): Don't declare.
 141         * tui/tui-source.c (tui_show_symtab_source): Rename from
 142         tui_show_symtab_source.
 143
 144 2019-08-16  Tom Tromey  <tom@tromey.com>
 145
 146         * tui/tui-winsource.h (struct tui_source_window_base)
 147         <set_contents>: Declare.
 148         * tui/tui-winsource.c
 149         (tui_source_window_base::update_source_window_as_is): Update.
 150         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 151         Declare.
 152         (tui_set_source_content): Don't declare.
 153         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 154         tui_set_source_content.
 155         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 156         Declare.
 157         (tui_set_disassem_content): Don't declare.
 158         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 159         tui_set_disassem_content.
 160
 161 2019-08-16  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-winsource.h (struct tui_source_window_base)
 164         <update_breakpoint_info>: Declare.
 165         (tui_update_breakpoint_info): Don't declare.
 166         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 167         (tui_update_all_breakpoint_info): Update.
 168         (tui_source_window_base::update_breakpoint_info): Rename from
 169         tui_update_breakpoint_info.
 170         (tui_source_window_base::update_exec_info): Update.
 171
 172 2019-08-16  Tom Tromey  <tom@tromey.com>
 173
 174         * tui/tui-winsource.h (struct tui_source_window_base)
 175         <update_source_window>: Declare.
 176         (tui_update_source_window): Don't declare.
 177         * tui/tui-winsource.c
 178         (tui_source_window_base::update_source_window): Rename from
 179         tui_update_source_window.
 180         (tui_source_window_base::rerender): Update.
 181         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 182         * tui/tui-disasm.c (tui_show_disassem)
 183         (tui_show_disassem_and_update_source)
 184         (tui_disasm_window::maybe_update): Update.
 185
 186 2019-08-16  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-winsource.h (struct tui_source_window_base)
 189         <update_source_window_as_is>: Declare.
 190         (tui_update_source_window_as_is): Don't declare.
 191         * tui/tui-winsource.c (tui_update_source_window): Update
 192         (tui_source_window_base::update_source_window_as_is): Rename from
 193         tui_update_source_window_as_is.
 194         (tui_source_window_base::refill): Update.
 195         * tui/tui-source.c (tui_show_symtab_source): Update.
 196         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 197         Update.
 198
 199 2019-08-16  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-winsource.h (tui_update_source_window)
 202         (tui_update_source_window_as_is): Remove "noerror" parameter.
 203         * tui/tui-winsource.c (tui_update_source_window)
 204         (tui_update_source_window_as_is): Remove "noerror" parameter.
 205         (tui_update_source_windows_with_addr)
 206         (tui_update_source_windows_with_line)
 207         (tui_source_window_base::rerender)
 208         (tui_source_window_base::refill): Update.
 209         * tui/tui-source.h (tui_set_source_content)
 210         (tui_show_symtab_source): Remove "noerror" parameter.
 211         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 212         parameter.
 213         (tui_show_symtab_source): Likewise.
 214         (tui_source_window::maybe_update): Update.
 215         * tui/tui-disasm.c (tui_show_disassem)
 216         (tui_show_disassem_and_update_source)
 217         (tui_disasm_window::do_scroll_vertical)
 218         (tui_disasm_window::maybe_update): Update.
 219
 220 2019-08-16  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui.c (tui_is_window_visible): Update.
 223         * tui/tui-wingeneral.c (tui_make_window)
 224         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 225         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 226         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 227         (tui_set_win_height_command, parse_scrolling_args): Update.
 228         * tui/tui-source.c (tui_source_window::style_changed): Update.
 229         * tui/tui-regs.c (tui_show_registers)
 230         (tui_data_window::first_data_item_displayed)
 231         (tui_data_window::delete_data_content_windows)
 232         (tui_check_register_values, tui_reg_command): Update.
 233         * tui/tui-disasm.c (tui_show_disassem): Update.
 234         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 235         method.
 236         <is_visible>: Remove field.
 237         * tui/tui-data.c (tui_next_win, tui_prev_win)
 238         (tui_delete_invisible_windows): Update.
 239
 240 2019-08-16  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-winsource.h (struct tui_source_window_base)
 243         <m_has_locator>: Remove.
 244         * tui/tui-layout.c (show_source_disasm_command, show_data)
 245         (show_source_or_disasm_and_command): Update.
 246
 247 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 248
 249         * NEWS (Other MI changes): New subsection.
 250         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 251         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 252         * arch-utils.c (default_get_pc_address_flags): New function.
 253         * arch-utils.h (default_get_pc_address_flags): New declaration.
 254         * gdbarch.sh: Add get_pc_address_flags.
 255         * gdbarch.c: Regenerate.
 256         * gdbarch.h: Likewise.
 257         * stack.c (print_pc): New function.
 258         (print_frame_info) (print_frame): Call print_pc.
 259
 260 2019-08-16  Tom de Vries  <tdevries@suse.de>
 261
 262         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 263         print_objfile_section_info.
 264
 265 2019-08-15  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 268         calling update_cmdwin_start_line.
 269         * tui/tui-winsource.h (struct tui_source_window_base)
 270         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 271         <rerender>: Declare.
 272         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 273         Call rerender.
 274         (tui_source_window_base::set_new_height): Remove.
 275         (tui_source_window_base::rerender): Rename from
 276         do_make_visible_with_new_height.
 277         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 278         resize method.
 279         (tui_win_info::make_invisible_and_set_new_height)
 280         (tui_win_info::make_visible_with_new_height): Remove.
 281         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 282         Declare.
 283         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 284         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 285         do_make_visible_with_new_height>: Don't declare.
 286         <rerender>: Declare.
 287         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 288         set_new_height.
 289         (tui_data_window::do_make_visible_with_new_height): Remove.
 290         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 291         call tui_show_locator_content.
 292         (tui_gen_win_info::resize): Call rerender.
 293         (show_source_or_disasm_and_command): Don't call
 294         tui_show_locator_content.
 295         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 296         method.
 297         (struct tui_win_info) <rerender>: Declare.
 298         <set_new_height, make_invisible_and_set_new_height,
 299         make_visible_with_new_height>: Don't declare.
 300         * tui/tui-data.c (tui_win_list::rerender): New method.
 301         * tui/tui-command.h (struct tui_cmd_window)
 302         <do_make_visible_with_new_height>: Don't declare.
 303         * tui/tui-command.c
 304         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 305
 306 2019-08-15  Tom Tromey  <tromey@adacore.com>
 307
 308         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 309         * ada-lang.c (ada_enum_name): Likewise.
 310
 311 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 312
 313         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 314         leading underscore.
 315         (GdbOutputErrorFile): Likewise.
 316         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 317         accordingly.
 318         (execute_unwinders): Rename to have a leading underscore.
 319         (auto_load_packages): Likewise.
 320         (global scope): Adjust call to auto_load_packages accordingly.
 321         (GdbSetPythonDirectory): Likewise.
 322         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 323         instead of execute_unwinders.
 324
 325 2019-08-15  Tom Tromey  <tom@tromey.com>
 326
 327         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 328         (show_data): Don't change window visibility.
 329         (tui_gen_win_info::resize): Remove special case for command
 330         window.  Use wresize, when available.
 331         (show_source_or_disasm_and_command): Don't change window
 332         visibility.
 333         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 334         <make_visible>: New method.
 335         * tui/tui-command.c (tui_cmd_window::resize): New method.
 336
 337 2019-08-15  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 340         (struct tui_source_windows): New.
 341         * tui/tui-winsource.c (tui_display_main): Update.
 342         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 343         (new_height_ok, parse_scrolling_args): Update.
 344         * tui/tui-layout.c (show_layout, show_data): Update.
 345         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 346         (tui_add_to_source_windows): Don't declare.
 347         * tui/tui-data.c (source_windows, tui_source_windows)
 348         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 349
 350 2019-08-15  Tom Tromey  <tom@tromey.com>
 351
 352         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 353         Rename from reset.
 354         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 355         * tui/tui-layout.c (show_source_disasm_command, show_data):
 356         Update.
 357         (tui_gen_win_info::resize): Rename.
 358         (show_source_or_disasm_and_command): Update.
 359         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 360         reset.
 361
 362 2019-08-15  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 365         * tui/tui-interp.c (tui_interp::init): Don't call
 366         tui_initialize_static_data.
 367         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 368
 369 2019-08-15  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 372         examine tui_win_list.
 373
 374 2019-08-15  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 377         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 378         tui_clear_source_content.
 379         (tui_clear_source_content): Remove.
 380         (tui_source_window_base::do_erase_source_content): Hoist call to
 381         content.clear().
 382         * tui/tui-stack.c (tui_show_frame_info): Don't call
 383         tui_clear_source_content.
 384
 385 2019-08-15  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-winsource.h (struct tui_source_window_base)
 388         <do_erase_source_content>: New method.
 389         <erase_source_content>: New method.
 390         (tui_erase_source_content): Don't declare.
 391         * tui/tui-winsource.c (tui_clear_source_content): Update.
 392         (tui_source_window_base::do_erase_source_content): Rename from
 393         tui_erase_source_content.
 394         (tui_source_window_base::show_source_content): Update.
 395         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 396         * tui/tui-source.h (struct tui_source_window)
 397         <erase_source_content>: New method.
 398         * tui/tui-disasm.h (struct tui_disasm_window)
 399         <erase_source_content>: New method.
 400
 401 2019-08-15  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 404         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 405         constructor.
 406         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 407         * tui/tui-source.c (tui_set_source_content): Update.
 408         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 409
 410 2019-08-15  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 413         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 414         tui-source.c.
 415         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 416         Declare.
 417         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 418         method.
 419         (tui_source_window::maybe_update): Update.
 420
 421 2019-08-15  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 424         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 425         tui-disasm.c.
 426         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 427         Declare.
 428         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 429         method.
 430         (tui_disasm_window::maybe_update): Update.
 431
 432 2019-08-15  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-winsource.h (struct tui_source_window_base)
 435         <maybe_update>: Declare.
 436         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 437         method.
 438         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 439         Declare.
 440         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 441         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 442         Declare.
 443         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 444
 445 2019-08-15  Tom Tromey  <tom@tromey.com>
 446
 447         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 448
 449 2019-08-15  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-wingeneral.c: Include tui-stack.h.
 452         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 453         (struct tui_locator_window): Move from tui-data.h.
 454         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 455         (tui_initialize_static_data): Move from tui-data.c.
 456         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 457         (struct tui_locator_window): Move to tui-stack.c.
 458         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 459         (tui_initialize_static_data): Move to tui-stack.c.
 460
 461 2019-08-15  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-layout.c (show_source_disasm_command)
 464         (show_source_or_disasm_and_command): Use make_visible method, not
 465         tui_make_window.
 466         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 467         Remove.
 468
 469 2019-08-15  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-wingeneral.h (tui_make_window): Update.
 472         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 473         parameter.
 474         (tui_gen_win_info::make_visible): Update.
 475         * tui/tui-regs.c (tui_data_window::display_registers_from):
 476         Update.
 477         * tui/tui-layout.c (show_source_disasm_command)
 478         (show_source_or_disasm_and_command): Update.
 479         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 480         (enum tui_box): Remove.
 481         (struct tui_win_info) <can_box>: New method.
 482         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 483         method.
 484
 485 2019-08-15  Tom de Vries  <tdevries@suse.de>
 486
 487         * linux-nat-trad.c: Include gdbarch.h.
 488
 489 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 490
 491         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 492         register sizes.
 493
 494 2019-08-14  Tom Tromey  <tromey@adacore.com>
 495
 496         * darwin-nat.c: Include gdbarch.h.
 497         * darwin-nat-info.c: Include gdbarch.h.
 498
 499 2019-08-13  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 502         Remove.
 503         * tui/tui-data.c (tui_initialize_static_data): Update.
 504
 505 2019-08-13  Tom Tromey  <tom@tromey.com>
 506
 507         * tui/tui-winsource.h (struct tui_exec_info_window)
 508         <~tui_exec_info_window, maybe_allocate_content, get_content,
 509         m_content>: Remove.
 510         (struct tui_source_window_base) <set_exec_info_content,
 511         show_exec_info_content>: Don't declare.
 512         * tui/tui-winsource.c
 513         (tui_exec_info_window::maybe_allocate_content): Remove.
 514         (tui_source_window_base::update_exec_info): Rename from
 515         set_exec_info_content.
 516         (tui_source_window_base::show_exec_info_content)
 517         (tui_source_window_base::update_exec_info): Remove.
 518
 519 2019-08-13  Tom Tromey  <tom@tromey.com>
 520
 521         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 522         declare.
 523         * tui/tui-winsource.c (tui_update_source_window_as_is)
 524         (tui_update_source_windows_with_addr, tui_erase_source_content):
 525         Update.
 526         (tui_clear_exec_info_content): Remove.
 527
 528 2019-08-13  Tom Tromey  <tom@tromey.com>
 529
 530         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 531         declare.
 532         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 533         call tui_erase_exec_info_content.
 534         (tui_clear_exec_info_content): Rename from
 535         tui_erase_exec_info_content.
 536         (tui_clear_exec_info_content): Delete.
 537
 538 2019-08-13  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-winsource.h (struct tui_source_window_base)
 541         <show_exec_info_content>: Declare.
 542         (tui_show_exec_info_content): Don't declare.
 543         * tui/tui-winsource.c
 544         (tui_source_window_base::show_exec_info_content): Rename from
 545         tui_show_exec_info_content.
 546         (tui_source_window_base::update_exec_info): Update.
 547
 548 2019-08-13  Tom Tromey  <tom@tromey.com>
 549
 550         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 551         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 552         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 553         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 554         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 555         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 556         ... here.
 557
 558 2019-08-13  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-winsource.h (struct tui_source_window_base)
 561         <update_exec_info>: Declare.
 562         (tui_update_exec_info): Don't declare.
 563         * tui/tui-winsource.c (tui_update_source_window_as_is)
 564         (tui_source_window_base::refresh_all)
 565         (tui_update_all_breakpoint_info): Update.
 566         (tui_source_window_base::update_exec_info): Rename from
 567         tui_update_exec_info.
 568         * tui/tui-stack.c (tui_show_frame_info): Update.
 569
 570 2019-08-13  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-winsource.h (struct tui_source_window_base)
 573         <set_exec_info_content>: Declare.
 574         (tui_set_exec_info_content): Don't declare.
 575         * tui/tui-winsource.c
 576         (tui_source_window_base::set_exec_info_content): Rename from
 577         tui_set_exec_info_content.
 578         (tui_update_exec_info): Update.
 579
 580 2019-08-13  Tom Tromey  <tom@tromey.com>
 581
 582         * tui/tui-winsource.h (struct tui_source_window_base)
 583         <show_source_content>: Declare.
 584         (tui_show_source_content): Don't declare.
 585         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 586         (tui_source_window_base::show_source_content): Rename from
 587         tui_show_source_content.
 588         (tui_source_window_base::refresh_all): Update.
 589         * tui/tui-layout.c (show_source_disasm_command)
 590         (show_source_or_disasm_and_command): Update.
 591
 592 2019-08-13  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.c (tui_erase_source_content)
 595         (tui_show_source_content, tui_source_window_base::refresh_all):
 596         Update.
 597         * tui/tui-wingeneral.h
 598         (tui_check_and_display_highlight_if_needed): Don't declare.
 599         * tui/tui-wingeneral.c
 600         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 601         check_and_display_highlight_if_needed.
 602         * tui/tui-win.c (tui_rehighlight_all)
 603         (tui_win_info::make_visible_with_new_height): Update.
 604         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 605         (tui_data_window::erase_data_content)
 606         (tui_data_window::display_all_data): Update.
 607         * tui/tui-data.h (struct tui_win_info)
 608         <check_and_display_highlight_if_needed>: Declare.
 609
 610 2019-08-13  Tom Tromey  <tom@tromey.com>
 611
 612         * tui/tui-win.c (tui_resize_all): Call
 613         tui_delete_invisible_windows.
 614         * tui/tui-layout.c (show_layout): Call
 615         tui_delete_invisible_windows.
 616         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 617         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 618
 619 2019-08-13  Tom Tromey  <tom@tromey.com>
 620
 621         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 622         tui_add_win_to_layout.
 623
 624 2019-08-13  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 627         * tui/tui-layout.c (tui_default_win_height): Now static.
 628
 629 2019-08-13  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 632         single switch.
 633         (show_source_disasm_command, show_source_or_disasm_and_command):
 634         Don't check current layout.
 635
 636 2019-08-13  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-wingeneral.c (make_all_visible): Remove.
 639         (tui_make_all_invisible): Simplify.
 640         * tui/tui-layout.c (tui_make_all_invisible): Move from
 641         tui-wingeneral.c; simplify.
 642         (show_layout): Hoist call to tui_make_all_invisible.
 643         (show_data): Don't call tui_make_all_invisible.
 644
 645 2019-08-13  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 648         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 649
 650 2019-08-13  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 653         tui-data.c.
 654         (show_source_disasm_command, show_data)
 655         (show_source_or_disasm_and_command): Don't use
 656         tui_set_current_layout_to.
 657         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 658         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 659         tui-layout.c.
 660         (tui_set_current_layout_to): Remove.
 661
 662 2019-08-13  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-layout.c (tui_set_layout): Update.
 665         * tui/tui-data.h (struct tui_layout_def): Remove.
 666         (tui_layout_def): Don't declare.
 667         * tui/tui-data.c (layout_def): Remove.
 668         (tui_layout_def): Remove.
 669
 670 2019-08-13  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-winsource.h (struct tui_source_window_base)
 673         <clear_detail>: No longer "override".
 674         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 675         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 676         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 677         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 678         Remove.
 679         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 680
 681 2019-08-13  Tom Tromey  <tromey@adacore.com>
 682
 683         * tracepoint.c: Don't include readline.h or history.h.
 684
 685 2019-08-12  Tom Tromey  <tom@tromey.com>
 686
 687         * configure: Rebuild.
 688         * configure.ac: Check for readline 7.
 689         * NEWS: Mention readline 7 requirement.
 690         * README: Update.
 691
 692 2019-08-12  Tom Tromey  <tom@tromey.com>
 693
 694         * mingw-hdep.c (gdb_select): Remove readline hack.
 695
 696 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 697
 698         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 699         when the function fails.
 700
 701 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 702
 703         * s390-tdep.c (s390_type_align): New function.
 704         (s390_gdbarch_init): Set it as type_align gdbarch method.
 705
 706 2019-08-09  Tom de Vries  <tdevries@suse.de>
 707
 708         PR gdb/24591
 709         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 710         pc_low with relocation offset.
 711
 712 2019-08-07  Tom Tromey  <tromey@adacore.com>
 713
 714         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 715         (print_frame_args): Update.
 716         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 717         Update.
 718         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 719         * frame.h (struct frame_arg): Add initializers.
 720         <error>: Now a unique_xmalloc_ptr.
 721
 722 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 723
 724         * NEWS: Expand the Pointer Authentication entry.
 725         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 726         (aarch64_frame_unmask_lr): ... to this.
 727         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 728         Call aarch64_frame_unmask_lr.
 729         * frame.c (struct frame_info): Add "masked" variable.
 730         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 731         (fprint_frame): Check for masked pc.
 732         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 733         declarations.
 734         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 735         * stack.c (print_frame): Check for masked pc.
 736
 737 2019-08-06  Tom Tromey  <tom@tromey.com>
 738
 739         * stabsread.c (patch_block_stabs, read_one_struct_field)
 740         (read_enum_type): Use obstack_strndup.
 741         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 742         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 743         * dwarf2read.c (guess_full_die_structure_name)
 744         (anonymous_struct_prefix): Use obstack_strndup.
 745         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 746         * c-exp.y (yylex): Use obstack_strndup.
 747         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 748         (write_var_or_type): Use obstack_strndup.
 749
 750 2019-08-06  Tom Tromey  <tom@tromey.com>
 751
 752         * symfile.c (reread_symbols): Use obstack_strdup.
 753         * stabsread.c (read_type): Use obstack_strdup.
 754         * gdb_obstack.h (obstack_strdup): New overload.
 755         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 756         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 757         (dwarf2_canonicalize_name): Use obstack_strdup.
 758         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 759         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 760         Use obstack_strdup.
 761
 762 2019-08-06  Tom Tromey  <tom@tromey.com>
 763
 764         * gdb_obstack.h (obstack_strdup): Define.
 765         * gdb_obstack.c (obstack_strdup): Don't define.
 766
 767 2019-08-06  Tom Tromey  <tom@tromey.com>
 768
 769         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 770         obstack_strdup.
 771         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 772         obstack_strdup.
 773         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 774         * stabsread.c (common_block_start): Use obstack_strdup.
 775         * objfiles.c (set_objfile_main_name, objfile): Use
 776         obstack_strdup.
 777         * namespace.c (add_using_directive): Use obstack_strdup.
 778         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 779         * jit.c (finalize_symtab): Use obstack_strdup.
 780         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 781         (guess_partial_die_structure_name, partial_die_info::fixup)
 782         (dwarf2_name): Use obstack_strdup.
 783         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 784         obstack_strdup.
 785         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 786         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 787         obstack_strdup.
 788         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 789
 790 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 791
 792         * unittests/help-doc-selftests.c: New file.
 793         * Makefile.in: Add the new file.
 794
 795 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 796
 797         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 798         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
 799         the full first line, except when FOR_VALUE_PREFIX.  In this case,
 800         the trailing '.' is not output, and the first character is uppercased.
 801         (print_help_for_command): Update call to print_doc_line.
 802         (print_doc_of_command): Likewise.
 803         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
 804         * cli/cli-option.c (append_indented_doc): Do not append newline.
 805         (build_help_option): Append newline after first appended_indented_doc
 806         only if a second call is done.
 807         (build_help): Append 2 new lines before each option, except the first
 808         one.
 809         * compile/compile.c (_initialize_compile): Add new lines after
 810         %OPTIONS%, when not at the end of the help.
 811         Change help doc or code
 812         producing the help doc to respect the invariants.
 813         * maint-test-options.c (_initialize_maint_test_options): Likewise.
 814         Also removed the new line after 'Options:', as all other commands
 815         do not put an empty line between 'Options:' and the first option.
 816         * printcmd.c (_initialize_printcmd): Likewise.
 817         * stack.c (_initialize_stack): Likewise.
 818         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
 819         incorrectly telling COMMAND is optional.
 820         * ada-lang.c (_initialize_ada_language): Change help doc or code
 821         producing the help doc to respect the invariants.
 822         * ada-tasks.c (_initialize_ada_tasks): Likewise.
 823         * breakpoint.c (_initialize_breakpoint): Likewise.
 824         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
 825         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
 826         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
 827         * cli/cli-style.c (cli_style_option::add_setshow_commands,
 828         _initialize_cli_style): Likewise.
 829         * corelow.c (core_target_info): Likewise.
 830         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
 831         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
 832         * filesystem.c (_initialize_filesystem): Likewise.
 833         * frame.c (_initialize_frame): Likewise.
 834         * gnu-nat.c (add_task_commands): Likewise.
 835         * infcall.c (_initialize_infcall): Likewise.
 836         * infcmd.c (_initialize_infcmd): Likewise.
 837         * interps.c (_initialize_interpreter): Likewise.
 838         * language.c (_initialize_language): Likewise.
 839         * linux-fork.c (_initialize_linux_fork): Likewise.
 840         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
 841         * maint.c (_initialize_maint_cmds): Likewise.
 842         * memattr.c (_initialize_mem): Likewise.
 843         * printcmd.c (_initialize_printcmd): Likewise.
 844         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
 845         _RegEx): Likewise.
 846         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
 847         * record-btrace.c (_initialize_record_btrace): Likewise.
 848         * record-full.c (_initialize_record_full): Likewise.
 849         * record.c (_initialize_record): Likewise.
 850         * regcache-dump.c (_initialize_regcache_dump): Likewise.
 851         * regcache.c (_initialize_regcache): Likewise.
 852         * remote.c (add_packet_config_cmd, init_remote_threadtests,
 853         _initialize_remote): Likewise.
 854         * ser-tcp.c (_initialize_ser_tcp): Likewise.
 855         * serial.c (_initialize_serial): Likewise.
 856         * skip.c (_initialize_step_skip): Likewise.
 857         * source.c (_initialize_source): Likewise.
 858         * stack.c (_initialize_stack): Likewise.
 859         * symfile.c (_initialize_symfile): Likewise.
 860         * symtab.c (_initialize_symtab): Likewise.
 861         * target-descriptions.c (_initialize_target_descriptions): Likewise.
 862         * top.c (init_main): Likewise.
 863         * tracefile-tfile.c (tfile_target_info): Likewise.
 864         * tracepoint.c (_initialize_tracepoint): Likewise.
 865         * tui/tui-win.c (_initialize_tui_win): Likewise.
 866         * utils.c (add_internal_problem_command): Likewise.
 867         * valprint.c (value_print_option_defs): Likewise.
 868
 869 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
 870
 871         PR build/24886
 872         * configure.ac: Drop enable-libmcheck support.
 873         * configure, config.in: Rebuild.
 874         * libmcheck.m4: Remove.
 875         * acinclude.m4: Don't include it.
 876         * Makefile.in: Don't distribute it.
 877         * top.c (print_gdb_configuration): Don't mention it.
 878
 879 2019-08-06  Tom Tromey  <tom@tromey.com>
 880
 881         * utils.c (set_output_style): Sometimes pass stream to
 882         emit_style_escape.
 883         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
 884         * record-btrace.c (btrace_insn_history): Update.
 885         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
 886         method.
 887         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
 888         Update initializers.
 889         <m_uiout>: New field.
 890         <m_di>: Move lower.
 891         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 892         Remove "uiout" parameter.
 893         (dump_insns): Update.
 894         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
 895         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
 896
 897 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
 898
 899         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
 900         (error_in_psymtab_expansion): Likewise.
 901         (lookup_symbol_via_quick_fns): Likewise.
 902         (basic_lookup_transparent_type_quick): Likewise.
 903         (basic_lookup_transparent_type_1): Likewise.
 904
 905 2019-08-06  Tom Tromey  <tromey@adacore.com>
 906
 907         * source.c (last_source_error): Now bool.
 908         (print_source_lines_base): Make "noprint" bool.  Only open
 909         source file when last_source_visited changes.
 910
 911 2019-08-06  Tom Tromey  <tromey@adacore.com>
 912
 913         * annotate.c (annotate_source_line): Use g_source_cache.
 914         * source-cache.c (source_cache::get_plain_source_lines): Change
 915         parameters.  Populate m_offset_cache.
 916         (source_cache::ensure): New method.
 917         (source_cache::get_line_charpos): New method.
 918         (extract_lines): Move lower.  Change parameters.
 919         (source_cache::get_source_lines): Move lower.
 920         * source-cache.h (class source_cache): Update comment.
 921         <get_line_charpos>: New method.
 922         <get_source_lines>: Update comment.
 923         <clear>: Clear m_offset_cache.
 924         <get_plain_source_lines>: Change parameters.
 925         <ensure>: New method
 926         <m_offset_cache>: New member.
 927         * source.c (forget_cached_source_info_for_objfile): Update.
 928         (info_source_command): Use g_source_cache.
 929         (find_source_lines, open_source_file_with_line_charpos): Remove.
 930         (print_source_lines_base, search_command_helper): Use g_source_cache.
 931         * source.h (open_source_file_with_line_charpos): Don't declare.
 932         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
 933         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
 934         Use g_source_cache.
 935
 936 2019-08-06  Tom Tromey  <tromey@adacore.com>
 937
 938         * source-cache.c (source_cache::get_plain_source_lines):
 939         Remove "first_line" and "last_line" parameters.
 940         (source_cache::get_source_lines): Cache plain text.
 941         * source-cache.h (class source_cache)
 942         <get_plain_source_lines>: Update.
 943
 944 2019-08-06  Tom Tromey  <tromey@adacore.com>
 945
 946         * source-cache.c (extract_lines): No longer a method.
 947         Changed type of parameter.  Include final newline.
 948         (selftests::extract_lines_test): New function.
 949         (_initialize_source_cache): Likewise.
 950         * source-cache.h (class source_cache)
 951         <extract_lines>: Don't declare.
 952
 953 2019-08-06  Tom Tromey  <tromey@adacore.com>
 954
 955         * breakpoint.c (init_breakpoint_sal): Update.
 956         (breakpoint): Update.
 957         * breakpoint.h (struct breakpoint) <filter>: Now a
 958         unique_xmalloc_ptr.
 959
 960 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 961
 962         * NEWS: Mention dictionary access on blocks.
 963         * python/py-block.c (blpy_getitem): New function.
 964         (block_object_as_mapping): New struct.
 965         (block_object_type): Use new struct for tp_as_mapping field.
 966
 967 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
 968
 969         * objfiles.h (objfile): Add a comment describing partial symbols.
 970
 971 2019-08-05  Tom Tromey  <tromey@adacore.com>
 972
 973         * compile/compile.c (_initialize_compile): Use _(), not N_().
 974         * thread.c (_initialize_thread): Use _(), not N_().
 975         * stack.c (_initialize_stack): Use _(), not N_().
 976         * printcmd.c (_initialize_printcmd): Use _(), not N_().
 977
 978 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
 979
 980         * dwarf2read.c (struct dw2_symtab_iterator):
 981         <want_specific_block>: Remove.
 982         <block_index>: Change type to gdb::optional.
 983         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
 984         change type of BLOCK_INDEX parameter to gdb::optional.
 985         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
 986         (dw2_lookup_symbol): Don't pass argument for
 987         WANT_SPECIFIC_BLOCK.
 988         (dw2_expand_symtabs_for_function): Don't pass argument for
 989         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
 990         (class dw2_debug_names_iterator)
 991         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
 992         parameter, change BLOCK_INDEX type to gdb::optional.
 993         <m_want_specific_block>: Remove.
 994         <m_block_index>: Change type to gdb::optional.
 995         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
 996         gdb::optional.  Re-write in function of gdb::optional.
 997         (dw2_debug_names_lookup_symbol): Don't pass argument for
 998         WANT_SPECIFIC_BLOCK.
 999         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1000         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1001         BLOCK_INDEX.
1002
1003 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1004
1005         * NEWS: Mention changes to "info sources" command.
1006
1007 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1008
1009         * symtab.c (filename_partial_match_opts): New struct type.
1010         (struct output_source_filename_data): New members
1011         regexp, c_regexp, partial_match.
1012         (output_source_filename): Use new members to decide to print file.
1013         (info_sources_option_defs): New variable.
1014         (make_info_sources_options_def_group, print_info_sources_header,
1015         info_sources_command_completer):
1016         New functions.
1017         (info_sources_command): Read new optional arguments.
1018         (_initialize_symtab): Update info sources help.
1019
1020 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1021
1022         * ada-lang.c (exception_support_info_v0): Renamed from...
1023         (default_exception_support_info): ... this.  Create new
1024         definition for v1.
1025         (ada_has_this_exception_support): Look up catch_handlers_sym.
1026         (ada_exception_support_info_sniffer): Try v0 after default.
1027
1028 2019-08-01  Tom Tromey  <tromey@adacore.com>
1029
1030         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1031         gdbarch.h.
1032
1033 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1034
1035         * s12z-tdep.c: Fix include path for s12z-opc.h.
1036
1037 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1038
1039         * NEWS: Require GNU make 3.82.
1040
1041 2019-07-16  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1044         declare.
1045
1046 2019-07-30  Tom Tromey  <tromey@adacore.com>
1047
1048         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1049
1050 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1051
1052         * printcmd.c (print_address_symbolic): Print negative offsets.
1053         (build_address_symbolic): Force signed arithmetic when computing
1054         offset.
1055
1056 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1057
1058         PR/24474: Add a function to lookup static variables.
1059         * NEWS: Mention this new function.
1060         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1061         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1062         * python/python.c (python_GdbMethods): Add new function.
1063
1064 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1065
1066         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1067         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1068         (objfpy_lookup_static_symbol): New function.
1069         (objfile_object_methods): Add new functions.
1070
1071 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1072
1073         * NEWS: Mention 'set|show print frame-info'.  Mention new
1074         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1075         backtrace argument.  Mention that python frame filtering code
1076         is now consistent with what 'backtrace' command prints.
1077
1078 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1079
1080         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1081         comments.
1082         (print_frame_info_auto, print_frame_info_source_line,
1083         print_frame_info_location, print_frame_info_source_and_location,
1084         print_frame_info_location_and_address, print_frame_info_short_location):
1085         New declarations.
1086         (struct frame_print_options): New member print_frame_info.
1087         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1088         * stack.h (get_user_print_what_frame_info): New declaration.
1089         (frame_show_address): New declaration.
1090         * stack.c (print_frame_arguments_choices): New value 'presence'.
1091         (print_frame_info_auto, print_frame_info_source_line,
1092         print_frame_info_location, print_frame_info_source_and_location,
1093         print_frame_info_location_and_address, print_frame_info_short_location,
1094         print_frame_info_choices, print_frame_info_print_what): New definitions.
1095         (print_frame_args): Only print dots for args if print frame-arguments
1096         is 'presence'.
1097         (frame_print_option_defs): New element for "frame-info".
1098         (get_user_print_what_frame_info): New function.
1099         (frame_show_address): Make non static.  Move comment to stack.h.
1100         (print_frame_info_to_print_what): New function.
1101         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1102         to decide what to print.
1103         (backtrace_command_1): Handle the new print_frame_arguments_presence
1104         value.
1105         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1106         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1107         (py_print_frame): In non-mi mode, use LOCATION as default for
1108         print_what, similarly to frame information printed directly by
1109         backtrace command. Handle frame-info user option in non MI mode.
1110
1111 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1112
1113         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1114         Add case for debugging 32-bit target on 64-bit host.  Revise
1115         comment.
1116
1117 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1118
1119         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1120         instead of find_function_entry_range_from_pc.
1121
1122 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1123
1124         * stack.c (find_frame_funname): Remove code which preferred
1125         minsym over symtab sym in "certain pathological cases".
1126
1127         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1128         parameter.  Change type of "do_demangle" to bool.
1129         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1130         Pass suitable "prefer_sym_over_minsym" flag to
1131         build_address_symbolic().  Don't output "+" for negative offsets.
1132         * printcmd.c (print_address_symbolic): Update invocation of
1133         build_address_symbolic to include a "prefer_sym_over_minsym"
1134         flag.
1135         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1136         Restrict cases in which use of minimal symbol is preferred to that
1137         of a found symbol.  Update comments.
1138
1139         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1140         for entry pc when entry pc is out of range for that FDE.
1141
1142 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1143
1144         PR gdb/24839:
1145         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1146         type.
1147
1148 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1149
1150         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1151         this function's Python signature.
1152
1153
1154 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1155
1156         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1157         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1158         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1159         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1160         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1161
1162
1163 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1164
1165         * h8300-tdep.c (h8300_register_name_common): New.
1166         h8300_register_name): Use h8300_register_name_common.
1167         (h8300s_register_name): Likewise.
1168         (h8300sx_register_name): Likewise.
1169         (h8300h_register_nam): New.
1170         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1171
1172
1173 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1174
1175         * arm-tdep.c (arm_skip_cmse_entry): New function.
1176         (arm_is_sgstubs_section): New function.
1177         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1178
1179 2019-07-22  Tom Tromey  <tom@tromey.com>
1180
1181         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1182         Don't self-assign.
1183
1184 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1187         type_print.
1188
1189 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1190
1191         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1192         so that GDB doesn't match any msymbols when searching in the
1193         TYPES_DOMAIN.
1194         (print_symbol_info): Print using typedef_print or type_print based
1195         on the type of the symbol.  Add updated FIXME comment moved from...
1196         (_initialize_symtab): ... move and update FIXME comment to above.
1197
1198 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1199
1200         * NEWS: Mention adding -q option to "info types".
1201         * symtab.c (struct info_types_options): New struct.
1202         (info_types_options_defs): New variable.
1203         (make_info_types_options_def_group): New function.
1204         (info_types_command): Use gdb::option framework to parse options.
1205         (info_types_command_completer): New function.
1206         (_initialize_symtab): Extend the help text on "info types" and
1207         register command completer.
1208
1209 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1210
1211         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1212         (lookup_symbol_in_objfile): Change int to block_enum and add a
1213         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1214
1215 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1216
1217         * MAINTAINERS (Write After Approval): Add self.
1218
1219 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1220
1221         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1222         instruction to the dummy code region.
1223
1224 2019-07-19  Tom Tromey  <tromey@adacore.com>
1225
1226         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1227         (ARGSUSED, PARAMS, __func__): Remove rules.
1228
1229 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1230
1231         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1232         * features/arm/arm-with-iwmmxt.c: Remove.
1233         * features/arm/arm-with-iwmmxt.xml: Remove.
1234         * features/arm/arm-with-m-fpa-layout.c: Remove.
1235         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1236         * features/arm/arm-with-m-vfp-d16.c: Remove.
1237         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1238         * features/arm/arm-with-m.c: Remove.
1239         * features/arm/arm-with-m.xml: Remove.
1240         * features/arm/arm-with-neon.c: Remove.
1241         * features/arm/arm-with-neon.xml: Remove.
1242         * features/arm/arm-with-vfpv2.c: Remove.
1243         * features/arm/arm-with-vfpv2.xml: Remove.
1244         * features/arm/arm-with-vfpv3.c: Remove.
1245         * features/arm/arm-with-vfpv3.xml: Remove.
1246
1247 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1248
1249         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1250
1251 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1252
1253         * arch/aarch32.c (aarch32_create_target_description): Create
1254         target descriptions using features.
1255         * arch/arm.c (arm_create_target_description)
1256         (arm_create_mprofile_target_description): Likewise.
1257         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1258
1259 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1260
1261         * Makefile.in: Add new files.
1262         * aarch32-tdep.c: New file.
1263         * aarch32-tdep.h: New file.
1264         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1265         Call aarch32_read_description.
1266         * arch/aarch32.c: New file.
1267         * arch/aarch32.h: New file.
1268         * arch/arm.c (arm_create_target_description)
1269         (arm_create_mprofile_target_description): New function.
1270         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1271         (arm_create_target_description)
1272         (arm_create_mprofile_target_description): New declaration.
1273         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1274         read_description functions.
1275         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1276         Likewise.
1277         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1278         * arm-tdep.c (tdesc_arm_list): New variable.
1279         (arm_register_g_packet_guesses): Call create description functions.
1280         (arm_read_description) (arm_read_mprofile_description): New
1281         function.
1282         * arm-tdep.h (arm_read_description)
1283         (arm_read_mprofile_description): Add declaration.
1284         * configure.tgt: Add new files.
1285
1286 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1287
1288         * top.c (new_ui_command): Open specified terminal just once.
1289
1290 2019-07-18  Tom Tromey  <tromey@adacore.com>
1291
1292         * symtab.c (main_name): Constify return type.
1293         * symfile.c (set_initial_language): Update.
1294         * symtab.h (main_name): Constify return type.
1295
1296 2019-07-17  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-winsource.c (tui_update_source_window)
1299         (tui_update_source_window_as_is)
1300         (tui_update_source_windows_with_line): Remove return.
1301         * tui/tui-disasm.c (tui_show_disassem)
1302         (tui_show_disassem_and_update_source): Remove return.
1303         * tui/tui.c (tui_reset): Remove return.
1304         * tui/tui-wingeneral.c
1305         (tui_check_and_display_highlight_if_needed): Remove return.
1306
1307 2019-07-17  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1310
1311 2019-07-17  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-winsource.h (struct tui_exec_info_window)
1314         (struct tui_source_window_base): Move from tui-data.h.
1315         * tui/tui-winsource.c: Move many method definitions from
1316         elsewhere.  Remove "structuring" comments.
1317         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1318         (tui_source_window_base::refresh_window): Move to
1319         tui-winsource.c.
1320         * tui/tui-win.c (tui_source_window_base::refresh_all)
1321         (tui_source_window_base::update_tab_width)
1322         (tui_source_window_base::set_new_height)
1323         (tui_source_window_base::do_make_visible_with_new_height): Move to
1324         tui-winsource.c.
1325         * tui/tui-source.h: Update.
1326         * tui/tui-source.c (tui_source_window_base::reset): Move to
1327         tui-winsource.c.
1328         * tui/tui-disasm.h: Update.
1329         * tui/tui-data.h (struct tui_exec_info_window): Move to
1330         tui-winsource.h.
1331         (struct tui_source_window_base): Likewise.
1332         * tui/tui-data.c (tui_source_window_base::clear_detail)
1333         (tui_source_window_base, ~tui_source_window_base): Move to
1334         tui-winsource.c.
1335
1336 2019-07-17  Tom Tromey  <tom@tromey.com>
1337
1338         * tui/tui-win.c (tui_resize_all)
1339         (tui_source_window_base::update_tab_width)
1340         (tui_adjust_win_heights): Update.
1341         (tui_win_info::make_invisible_and_set_new_height): Rename from
1342         make_invisible_and_set_new_height.
1343         * tui/tui-data.h (struct tui_win_info)
1344         <make_invisible_and_set_new_height>: New method.
1345
1346 2019-07-17  Tom Tromey  <tom@tromey.com>
1347
1348         * tui/tui.c: Update.
1349         * tui/tui-source.h (struct tui_source_window): Move from
1350         tui-data.h.
1351         * tui/tui-layout.c: Update.
1352         * tui/tui-disasm.c: Update.
1353         * tui/tui-data.h (struct tui_source_window): Move to
1354         tui-source.h.
1355
1356 2019-07-17  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1359         tui-data.h.
1360         * tui/tui-data.h (struct tui_disasm_window): Move to
1361         tui-disasm.h.
1362
1363 2019-07-17  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-regs.h (struct tui_data_item_window): Move from
1366         tui-data.h.
1367         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1368         * tui/tui-data.h (struct tui_data_item_window): Move to
1369         tui-regs.h.
1370         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1371
1372 2019-07-17  Tom Tromey  <tom@tromey.com>
1373
1374         * tui/tui.c: Update.
1375         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1376         (tui_cmd_window::max_height): Move to tui-command.c.
1377         * tui/tui-layout.c: Update.
1378         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1379         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1380         tui-command.c.
1381         * tui/tui-command.h (struct tui_cmd_window): Move from
1382         tui-data.h.
1383         * tui/tui-command.c: Remove "structuring" comments.
1384         (tui_cmd_window::clear_detail)
1385         (tui_cmd_window::do_make_visible_with_new_height)
1386         (tui_cmd_window::max_height): Move from elsewhere.
1387
1388 2019-07-17  Tom Tromey  <tom@tromey.com>
1389
1390         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1391         Now static.
1392         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1393         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1394
1395 2019-07-17  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui.c: Update.
1398         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1399         tui-regs.c.
1400         * tui/tui-windata.h: Remove file.
1401         * tui/tui-windata.c: Remove file.
1402         * tui/tui-win.c (tui_data_window::set_new_height)
1403         (tui_data_window::do_make_visible_with_new_height): Move to
1404         tui-regs.c.
1405         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1406         * tui/tui-regs.c: Remove "structuring" comments.
1407         (tui_data_window::first_data_item_displayed)
1408         (tui_data_window::delete_data_content_windows)
1409         (tui_data_window::erase_data_content)
1410         (tui_data_window::display_all_data)
1411         (tui_data_window::refresh_all)
1412         (tui_data_window::do_scroll_vertical)
1413         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1414         (tui_data_window::do_make_visible_with_new_height)
1415         (tui_data_window::refresh_window): Move from elsewhere.
1416         (_initialize_tui_regs): Move to end of file.
1417         * tui/tui-layout.c: Update.
1418         * tui/tui-hooks.c: Update.
1419         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1420         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1421         tui-regs.c.
1422         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1423
1424 2019-07-17  Tom Tromey  <tom@tromey.com>
1425
1426         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1427         seen.
1428
1429 2019-07-17  Tom Tromey  <tom@tromey.com>
1430
1431         * tui/tui-win.c (tui_source_window_base::set_new_height)
1432         (tui_source_window_base::do_make_visible_with_new_height): Use
1433         m_has_locator field directly.
1434         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1435         method.
1436         (struct tui_source_window_base) <has_locator>: Likewise.
1437
1438 2019-07-17  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1441         Don't declare.
1442         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1443         Remove.
1444         * tui/tui-win.c (tui_source_window_base::set_new_height)
1445         (tui_source_window_base::set_new_height)
1446         (make_invisible_and_set_new_height)
1447         (tui_source_window_base::do_make_visible_with_new_height)
1448         (tui_source_window_base::do_make_visible_with_new_height):
1449         Update.
1450         * tui/tui-layout.c (show_source_disasm_command, show_data)
1451         (show_source_or_disasm_and_command): Update.
1452         * tui/tui-layout.c (show_layout): Update.
1453
1454 2019-07-17  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-layout.c (make_data_window): Remove.
1457         (show_data): Unify creation and re-initialization cases.
1458
1459 2019-07-17  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-layout.c (make_source_window, make_disasm_window):
1462         Remove.
1463         (show_data): Unify creation and re-initialization cases.
1464
1465 2019-07-17  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-layout.c (make_command_window): Remove.
1468         (show_source_disasm_command, show_source_or_disasm_and_command):
1469         Unify creation and re-initialization cases.
1470
1471 2019-07-17  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1474         creation and re-initialization cases.
1475
1476 2019-07-17  Tom Tromey  <tom@tromey.com>
1477
1478         * tui/tui-regs.c (tui_get_register): Return void.
1479
1480 2019-07-17  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1483         Simplify.
1484
1485 2019-07-17  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1488         resetting.
1489
1490 2019-07-17  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1493         * tui/tui-regs.c (tui_reg_layout): New function.
1494         (tui_show_registers, tui_reg_command): Use it.
1495         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1496         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1497         parameters.
1498         (tui_layout_command): Remove.
1499
1500 2019-07-17  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-layout.h (tui/tui-layout): Return void.
1503         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1504
1505 2019-07-17  Tom Tromey  <tom@tromey.com>
1506
1507         * tui/tui-layout.c (show_source_disasm_command, show_data):
1508         Update.
1509         (reset_locator): Remove.
1510         (show_source_or_disasm_and_command): Update.
1511
1512 2019-07-17  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-source.c (tui_source_window_base::reset): Remove
1515         win_type parameter.
1516         * tui/tui-layout.c (make_command_window, make_source_window)
1517         (make_disasm_window, make_data_window)
1518         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1519         (reset_locator, show_source_or_disasm_and_command): Update.
1520         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1521         win_type parameter.
1522         (struct tui_source_window_base) <reset>: Likewise.
1523
1524 2019-07-17  Tom Tromey  <tom@tromey.com>
1525
1526         * tui/tui-layout.c (show_source_disasm_command): Use
1527         reset_locator.
1528         (reset_locator): New function.
1529         (init_and_make_win): Remove.
1530         (show_source_or_disasm_and_command): Use reset_locator.
1531
1532 2019-07-17  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1535         condition.
1536         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1537         Remove condition.
1538         * tui/tui-source.c (tui_source_window_base::reset): New method.
1539         * tui/tui-layout.c (make_command_window): Don't call
1540         init_and_make_win.
1541         (make_source_window, make_disasm_window): Don't call
1542         make_source_or_disasm_window.
1543         (make_data_window): Don't call init_and_make_win.  Change calling
1544         convention.
1545         (show_source_disasm_command, show_data): Simplify.
1546         (make_source_or_disasm_window): Remove.
1547         (show_source_or_disasm_and_command): Simplify.
1548         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1549         (struct tui_source_window_base) <reset>: Likewise.
1550         <execution_info>: Remove initializer.
1551         * tui/tui-data.c (tui_source_window_base): Initialize
1552         execution_info.
1553
1554 2019-07-17  Tom Tromey  <tom@tromey.com>
1555
1556         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1557         variable.
1558
1559 2019-07-17  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui.c (tui_rl_other_window): Update.
1562         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1563         superclass method first.  Always iterate over regs_content.
1564         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1565         method.
1566         * tui/tui-win.c (tui_set_focus_command): Update.
1567
1568 2019-07-17  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-win.c (tui_set_focus_command): Rename from
1571         tui_set_focus.  Call tui_enable.
1572         (tui_set_focus_command): Remove.
1573
1574 2019-07-17  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1577         refresh_window.
1578         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1579         touchwin.
1580         (tui_data_window::refresh_window): Call refresh_window on data
1581         items.  Always call superclass refresh_window.
1582         (tui_win_info::refresh): Remove.
1583         (tui_source_window_base::refresh_window): Update.
1584         (tui_refresh_all): Update.
1585         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1586         refresh_window.
1587         (show_source_or_disasm_and_command): Likewise.
1588         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1589         (struct tui_source_window_base) <refresh>: Likewise.
1590
1591 2019-07-17  Tom Tromey  <tom@tromey.com>
1592
1593         * tui/tui-winsource.c (tui_clear_source_content)
1594         (tui_show_source_content): Update.
1595         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1596         whether content is empty.
1597         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1598         Remove.
1599
1600 2019-07-17  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1603         window's contents.
1604         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1605         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1606
1607 2019-07-17  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1610         (struct tui_data_item_window): Update.
1611
1612 2019-07-17  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1615         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1616         defines.
1617
1618 2019-07-17  Tom Tromey  <tom@tromey.com>
1619
1620         * tui/tui-winsource.h (tui_erase_source_content)
1621         (tui_clear_source_content): Remove "display_prompt" parameter.
1622         * tui/tui-winsource.c (tui_update_source_window_as_is)
1623         (tui_update_source_windows_with_addr): Update.
1624         (tui_clear_source_content): Remove "display_prompt" parameter.
1625         (tui_erase_source_content): Likewise.  Simplify.
1626         (tui_show_source_content): Update.
1627         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1628         * tui/tui-stack.c (tui_show_frame_info): Update.
1629         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1630         Remove defines.
1631
1632 2019-07-17  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1635         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1636         parameter.
1637         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1638         parameter.
1639
1640 2019-07-17  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-winsource.c (tui_clear_source_content)
1643         (tui_show_source_content, tui_show_exec_info_content)
1644         (tui_clear_exec_info_content): Update.
1645         * tui/tui-stack.c (tui_show_locator_content): Update.
1646         (tui_show_frame_info): Update.
1647         * tui/tui-source.h (tui_source_window): Don't declare.
1648         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1649         from tui_source_is_displayed.
1650         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1651         Remove field.
1652         (struct tui_source_window_base) <content_in_use>: New field.  Now
1653         bool.
1654         (struct tui_source_window) <showing_source_p>: New method.
1655         (TUI_SRC_WIN): Change cast.
1656         * tui/tui-data.c (tui_initialize_static_data): Update.
1657
1658 2019-07-17  Tom Tromey  <tom@tromey.com>
1659
1660         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1661         location_matches_p.
1662         * tui/tui-source.c (tui_source_window::location_matches_p): New
1663         method.
1664         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1665         method.
1666         * tui/tui-data.h (struct tui_source_window_base)
1667         <location_matches_p>: New method.
1668         (struct tui_source_window, struct tui_disasm_window)
1669         <location_matches_p>: Likewise.
1670
1671 2019-07-17  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-win.c (tui_set_win_height_command): Rename from
1674         tui_set_win_height.
1675         (tui_set_win_height_command): Remove.
1676
1677 2019-07-17  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-source.c (tui_source_window): New constructor.  Add
1680         observer.
1681         (~tui_source_window): New destructor.
1682         (tui_source_window::style_changed): New method.
1683         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1684         (tui_attach_detach_observers): Update.
1685         * tui/tui-data.h (struct tui_source_window): Make constructor not
1686         inline.  Add destructor.
1687         (struct tui_source_window) <style_changed>: New method.
1688         <m_observable>: New member.
1689
1690 2019-07-17  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1693         * tui/tui-win.c (tui_resize_all): Fix typo.
1694
1695 2019-07-17  Tom Tromey  <tom@tromey.com>
1696
1697         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1698         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1699         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1700         * tui/tui-win.c (window_name_completer): Use foreach.
1701         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1702         (update_tab_width): Likewise.
1703         * tui/tui-layout.c (show_layout): Update.
1704         * tui/tui-data.h (class tui_window_iterator): New.
1705         (struct all_tui_windows): New.
1706         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1707
1708 2019-07-17  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1711         parameter.  Don't reference globals.
1712         (tui_reg_command): Update.
1713
1714 2019-07-17  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-regs.c (tui_show_registers): Simplify.
1717
1718 2019-07-17  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-regs.c (tui_show_registers): Update.
1721         (tui_show_register_group): Add win_info parameter.
1722
1723 2019-07-17  Tom Tromey  <tom@tromey.com>
1724
1725         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1726         Rename from tui_display_reg_element_at_line.
1727         (tui_data_window::display_registers_from_line): Update.
1728         * tui/tui-data.h (struct tui_data_window)
1729         <display_reg_element_at_line>: New method.
1730
1731 2019-07-17  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-regs.h (tui_display_registers_from)
1734         (tui_display_registers_from_line): Don't declare.
1735         * tui/tui-windata.c (tui_data_window::display_all_data)
1736         (tui_data_window::refresh_all)
1737         (tui_data_window::do_scroll_vertical): Update.
1738         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1739         from tui_display_registers_from.
1740         (tui_display_reg_element_at_line): Update.
1741         (tui_data_window::display_registers_from_line): Rename from
1742         tui_display_registers_from_line.
1743         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1744         display_registers_from_line>: New methods.
1745
1746 2019-07-17  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1749         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1750         from tui_erase_data_content.
1751         (tui_data_window::display_all_data)
1752         (tui_data_window::refresh_all)
1753         (tui_data_window::do_scroll_vertical): Update.
1754         * tui/tui-regs.c (tui_show_registers): Update.
1755         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1756         New method.
1757
1758 2019-07-17  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1761         declare.
1762         * tui/tui-windata.c
1763         (tui_data_window::delete_data_content_windows): Rename from
1764         tui_delete_data_content_windows.
1765         (tui_data_window::display_all_data)
1766         (tui_data_window::do_scroll_vertical): Update.
1767         * tui/tui-data.h (struct tui_data_window)
1768         <delete_data_content_windows>: New method.
1769
1770 2019-07-17  Tom Tromey  <tom@tromey.com>
1771
1772         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1773         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1774
1775 2019-07-17  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1778         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1779         from tui_display_all_data.
1780         * tui/tui-win.c
1781         (tui_data_window::do_make_visible_with_new_height): Update.
1782         * tui/tui-regs.c (tui_show_registers): Update.
1783         * tui/tui-layout.c (tui_set_layout): Update.
1784         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1785         method.
1786
1787 2019-07-17  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1790         * tui/tui-windata.c (tui_display_data_from): Remove.
1791         (tui_data_window::refresh_all): Update.
1792
1793 2019-07-17  Tom Tromey  <tom@tromey.com>
1794
1795         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1796         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1797         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1798         tui_display_registers_from_line.
1799         * tui/tui-regs.h (tui_display_registers_from_line): Update.
1800         * tui/tui-regs.c (tui_display_registers_from_line): Remove
1801         "force_display" parameter.
1802
1803 2019-07-17  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1806         declare.
1807         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1808         Rename from tui_first_reg_element_no_inline.
1809         (tui_display_reg_element_at_line)
1810         (tui_display_registers_from_line): Update.
1811         * tui/tui-data.h (struct tui_data_window)
1812         <first_reg_element_no_inline>: New method.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-windata.c (tui_display_data_from)
1817         (tui_data_window::do_scroll_vertical): Update.
1818         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1819         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1820         Rename from tui_line_from_reg_element_no.
1821         (tui_display_registers_from_line): Update.
1822         * tui/tui-data.h (struct tui_data_window)
1823         <line_from_reg_element_no>: New method.
1824
1825 2019-07-17  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1828         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1829         tui_last_regs_line_no.
1830         (tui_display_reg_element_at_line)
1831         (tui_display_registers_from_line): Update.
1832         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1833         method.
1834
1835 2019-07-17  Tom Tromey  <tom@tromey.com>
1836
1837         PR tui/24722:
1838         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1839         (tui_update_breakpoint_info): Add "being_deleted" parameter.
1840         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1841         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1842         (tui_update_breakpoint_info): Likewise.
1843         * tui/tui-hooks.c (tui_event_create_breakpoint)
1844         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1845         Update.
1846
1847 2019-07-17  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1850
1851 2019-07-17  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-winsource.c (tui_update_source_window_as_is)
1854         (tui_update_source_windows_with_addr): Update.
1855         * tui/tui-source.h (tui_set_source_content)
1856         (tui_show_symtab_source): Add "win_info" parameter.
1857         * tui/tui-source.c (tui_set_source_content): Add "win_info"
1858         parameter.
1859         (tui_show_symtab_source): Likewise.
1860
1861 2019-07-17  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-wingeneral.c
1864         (tui_check_and_display_highlight_if_needed): Check can_highlight.
1865
1866 2019-07-17  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1869         (struct tui_cmd_window) <can_scroll>: New method.
1870         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1871         method.
1872
1873 2019-07-17  Tom Tromey  <tromey@adacore.com>
1874
1875         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1876         do_field_signed>: Rename.  Change type of "value".
1877         * ui-out.c (ui_out::field_signed): Rename from field_int.
1878         Change type of "value".
1879         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
1880         type of "value".
1881         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1882         do_field_int.  Change type of "value".
1883         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1884         do_field_int.  Change type of "value".
1885         * tracepoint.c (trace_status_mi, tfind_1)
1886         (print_one_static_tracepoint_marker): Update.
1887         * thread.c (print_thread_info_1, print_selected_thread_frame):
1888         Update.
1889         * stack.c (print_frame, print_frame_info): Update.
1890         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1891         Update.
1892         * source.c (print_source_lines_base): Update.
1893         * skip.c (info_skip_command): Update.
1894         * record-btrace.c (btrace_ui_out_decode_error)
1895         (btrace_call_history_src_line): Update.
1896         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1897         Update.
1898         * progspace.c (print_program_space): Update.
1899         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1900         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1901         do_field_int.  Change type of "value".
1902         * mi/mi-out.c (mi_ui_out::do_table_begin)
1903         (mi_ui_out::do_table_header): Update.
1904         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
1905         type of "value".
1906         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1907         (mi_cmd_data_list_changed_registers, output_register)
1908         (mi_cmd_data_read_memory, mi_load_progress)
1909         (mi_cmd_trace_frame_collected): Update.
1910         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1911         Update.
1912         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1913         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1914         (mi_cmd_var_list_children, varobj_update_one): Update.
1915         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1916         (mi_cmd_stack_list_args, list_arg_or_local): Update.
1917         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1918         * inferior.c (print_inferior): Update.
1919         * gdb_bfd.c (print_one_bfd): Update.
1920         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1921         Update.
1922         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1923         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1924         do_field_int.  Change type of "value".
1925         * cli-out.c (cli_ui_out::do_field_signed): Rename from
1926         do_field_int.  Change type of "value".
1927         * breakpoint.c (watchpoint_check, print_breakpoint_location)
1928         (print_one_breakpoint_location, print_it_catch_fork)
1929         (print_one_catch_fork, print_it_catch_vfork)
1930         (print_one_catch_vfork, print_it_catch_solib)
1931         (print_it_catch_exec, print_it_ranged_breakpoint)
1932         (print_mention_watchpoint, print_mention_masked_watchpoint)
1933         (bkpt_print_it, update_static_tracepoint): Update.
1934         * break-catch-throw.c (print_it_exception_catchpoint): Update.
1935         * break-catch-syscall.c (print_it_catch_syscall): Update.
1936         * ada-tasks.c (print_ada_task_info): Update.
1937         * ada-lang.c (print_it_exception, print_mention_exception):
1938         Update.
1939
1940 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1941
1942         PR breakpoints/24541
1943         * gdbarch.c: Regenerate.
1944         * gdbarch.h: Regenerate.
1945         * gdbarch.sh: Adjust return type and parameter types for
1946         'stap_adjust_register'.
1947         (i386_stap_adjust_register): Adjust signature and return new
1948         register name.
1949         * stap-probe.c (stap_parse_register_operand): Adjust use of
1950         'gdbarch_stap_adjust_register'.
1951
1952 2019-07-17  Tom Tromey  <tromey@adacore.com>
1953
1954         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
1955         declare VEC.
1956         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
1957         std::vector.
1958         (struct s390_process_info): Add initializers.
1959         (s390_add_process): Use new.
1960         (s390_linux_nat_target::low_forget_process): Use delete.
1961         (s390_linux_nat_target::low_new_fork)
1962         (s390_linux_nat_target::stopped_by_watchpoint)
1963         (s390_linux_nat_target::low_prepare_to_resume)
1964         (s390_linux_nat_target::insert_watchpoint)
1965         (s390_linux_nat_target::insert_hw_breakpoint)
1966         (s390_linux_nat_target::remove_watchpoint)
1967         (s390_linux_nat_target::remove_hw_breakpoint): Update.
1968
1969 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1970
1971         * aarch64-fbsd-nat.c: Include regcache.h.
1972         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
1973         argument.
1974         (aarch64_fbsd_nat_target::fetch_registers)
1975         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
1976         variable.
1977         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
1978
1979 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
1980
1981         * fbsd-nat.c: Include gdbarch.h.
1982
1983 2019-07-15  Tom Tromey  <tromey@adacore.com>
1984
1985         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
1986
1987 2019-07-15  Tom Tromey  <tromey@adacore.com>
1988
1989         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
1990         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
1991         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
1992         * cli-out.c (cli_ui_out::do_field_int): New method.
1993         * ui-out.c (ui_out::field_unsigned): New method.
1994         * symfile.c (generic_load): Use field_unsigned.
1995         (print_transfer_performance): Likewise.
1996         * record-btrace.c (ui_out_field_uint): Remove.
1997         (btrace_call_history_insn_range, btrace_call_history): Use
1998         field_unsigned.
1999         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2000         field_unsigned.
2001         * ui-out.h (class ui_out) <field_unsigned>: New method.
2002         <do_field_unsigned>: Likewise.
2003
2004 2019-07-15  Tom Tromey  <tromey@adacore.com>
2005
2006         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2007         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2008         * target.c (flash_erase_command): Use field_string.
2009         * infrun.c (print_signal_received_reason): Use field_string.
2010         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2011         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2012         field_string.
2013         * ada-tasks.c (print_ada_task_info): Use field_string.
2014
2015 2019-07-15  Tom Tromey  <tromey@adacore.com>
2016
2017         * target.c (flash_erase_command): Use field_core_addr.
2018         * symfile.c (generic_load): Use field_core_addr.
2019         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2020         Use field_core_addr.
2021         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2022         field_core_addr.
2023
2024 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2025
2026         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2027         value if its desired type is smaller than a CORE_ADDR and signed.
2028
2029 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2030
2031         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2032         of changes to field names, and use new is_reference field to
2033         decide if a property is a reference or not.
2034         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2035         field.
2036         (struct dwarf2_property_baton): Update header comment, rename
2037         'referenced_type' to 'property_type' and update comments.
2038         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2039         default property type, store in property baton, update to take
2040         accound of renamed field.
2041         (read_func_scope): Update call to attr_to_dynamic_prop.
2042         (read_array_type): Likewise.
2043         (dwarf2_per_cu_addr_sized_int_type): New function.
2044         (read_subrange_index_type): Move type finding code to
2045         dwarf2_per_cu_addr_sized_int_type.
2046         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2047         (dwarf2_per_cu_addr_type): New function.
2048         (set_die_type): Update calls to attr_to_dynamic_prop.
2049
2050 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * dwarf2read.c (read_subrange_index_type): New function.
2053         (read_subrange_type): Move code into new function and call it.
2054         * gdbtypes.c (create_range_type): Add some asserts.
2055
2056 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2057
2058         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2059         update return statements.
2060         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2061         declaration, and update comment to match.
2062         * gdbtypes.c (resolve_dynamic_array): Update call to
2063         dwarf2_evaluate_property to match new return type.
2064
2065 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2066
2067         * valarith.c (value_subscripted_rvalue): Change lowerbound
2068         parameter type from int to LONGEST.
2069         * value.h (value_subscripted_rvalue): Likewise in declaration.
2070
2071 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2072
2073         * cli/cli-utils.c (info_print_command_completer): New function.
2074         * cli/cli-utils.h: Add 'completer.h' include, and forward
2075         declaration for 'struct cmd_list_element'.
2076         (info_print_command_completer): Declare.
2077         * stack.c (_initialize_stack): Add completer for 'info locals' and
2078         'info args'.
2079         * symtab.c (_initialize_symtab): Add completer for 'info
2080         variables' and 'info functions'.
2081         * NEWS: Mention completion for additional info commands.
2082
2083 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * cli/cli-utils.c (extract_info_print_args): Delete.
2086         (extract_arg_maybe_quoted): Delete.
2087         (info_print_options_defs): New variable.
2088         (make_info_print_options_def_group): New function.
2089         (extract_info_print_options): Define new function.
2090         * cli/cli-utils.h (extract_info_print_args): Delete.
2091         (struct info_print_options): New structure.
2092         (extract_info_print_options): Declare new function.
2093         * stack.c (info_locals_command): Update to use new
2094         extract_info_print_options, also add a header comment.
2095         (info_args_command): Likewise.
2096         * symtab.c (info_variables_command): Likewise.
2097         (info_functions_command): Likewise.
2098
2099 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2100
2101         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2102         to extract string arguments.
2103         * common/common-utils.c (extract_string_maybe_quoted): New function.
2104         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2105
2106 2019-07-11  Tom Tromey  <tromey@adacore.com>
2107
2108         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2109         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2110         * top.h (gdbinit): Don't declare.
2111         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2112         into...
2113         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2114         * top.c (gdb_init): Don't call init_cli_cmds.
2115         (gdbinit): Remove.
2116         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2117
2118 2019-07-11  Tom Tromey  <tromey@adacore.com>
2119
2120         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2121         after it has been moved.
2122
2123 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2124
2125         * valops.c (value_must_coerce_to_target): Change return type to
2126         bool.
2127         * value.h (value_must_coerce_to_target): Likewise.
2128
2129 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2130
2131         * breakpoint.c (is_hardware_watchpoint): Remove
2132         forward-declaration.
2133         (is_masked_watchpoint): Change return type to bool.
2134         (is_tracepoint): Likewise.
2135         (is_breakpoint): Likewise.
2136         (is_hardware_watchpoint): Likewise.
2137         (is_watchpoint): Likewise.
2138         (is_no_memory_software_watchpoint): Likewise.
2139         (is_catchpoint): Likewise.
2140         (breakpoint_1): Make FILTER parameter's return type bool.
2141         is_masked_watchpoint): Change return type to bool.
2142         (save_breakpoints): Make FILTER parameter's return type bool.
2143         * breakpoint.h (is_breakpoint): Change return type to bool.
2144         (is_watchpoint): Likewise.
2145         (is_catchpoint): Likewise.
2146         (is_tracepoint): Likewise.
2147
2148 2019-07-10  Tom Tromey  <tom@tromey.com>
2149
2150         * defs.h: Don't include gdbarch.h.
2151         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2152         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2153         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2154         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2155         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2156         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2157         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2158         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2159         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2160         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2161         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2162         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2163         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2164         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2165         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2166         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2167         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2168         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2169         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2170         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2171         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2172         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2173         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2174         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2175         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2176         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2177         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2178
2179 2019-07-10  Tom Tromey  <tromey@adacore.com>
2180
2181         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2182         * breakpoint.c (init_ada_exception_breakpoint): Register as
2183         bp_catchpoint.
2184         (print_one_breakpoint_location, print_one_breakpoint): Use
2185         is_ada_exception_catchpoint.
2186         * ada-lang.c (class ada_catchpoint_location): Pass
2187         bp_loc_software_breakpoint to bp_location constructor.
2188         (is_ada_exception_catchpoint): New function.
2189
2190 2019-07-10  Tom Tromey  <tromey@adacore.com>
2191
2192         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2193         VEC.
2194         (struct arm_exidx_entry): New method operator<.
2195         (struct arm_exidx_data) <section_maps>: Change type.
2196         (arm_exidx_data_free): Remove.
2197         (arm_exidx_data_key): Change type.  Move lower.
2198         (arm_exidx_new_objfile): Update.
2199         (arm_compare_exidx_entries): Remove.
2200         (arm_find_exidx_entry, _initialize_arm_tdep)
2201
2202 2019-07-10  Tom Tromey  <tromey@adacore.com>
2203
2204         * solib-spu.c (ocl_program_data_key): Change type.
2205         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2206         Update.
2207
2208 2019-07-10  Tom Tromey  <tromey@adacore.com>
2209
2210         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2211         (struct solib_aix_inferior_data) <library_list>: Change type.
2212         (solib_aix_inferior_data_handle): Change type.
2213         (get_solib_aix_inferior_data): Update.
2214         (solib_aix_free_library_list): Remove.
2215         (library_list_start_library): Update.
2216         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2217         return type.
2218         (solib_aix_get_library_list)
2219         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2220         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2221
2222 2019-07-10  Tom Tromey  <tromey@adacore.com>
2223
2224         * solib-dsbt.c (struct dsbt_info): Add initializers.
2225         (solib_dsbt_pspace_data): Change type.
2226         (dsbt_pspace_data_cleanup): Remove.
2227         (get_dsbt_info, _initialize_dsbt_solib): Update.
2228
2229 2019-07-10  Tom Tromey  <tromey@adacore.com>
2230
2231         * spu-tdep.c (spu_overlay_data): Change type.
2232         (spu_get_overlay_table, spu_overlay_new_objfile)
2233         (_initialize_spu_tdep): Update.
2234
2235 2019-07-10  Tom Tromey  <tromey@adacore.com>
2236
2237         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2238         destructor.
2239         (dbx_objfile_data_key): Change type and declare later.
2240         (DBX_SYMFILE_INFO): Rewrite.
2241         * dbxread.c (dbx_objfile_data_key): Change type.
2242         (dbx_symfile_init): Update.
2243         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2244         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2245         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2246
2247 2019-07-10  Tom Tromey  <tromey@adacore.com>
2248
2249         * jit.c (jit_program_space_key): Change type.  Move lower.
2250         (get_jit_program_space_data): Update.
2251         (jit_program_space_data_cleanup): Remove.
2252         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2253         Update.
2254         (struct jit_program_space_data): Add initializers.
2255
2256 2019-07-10  Tom Tromey  <tromey@adacore.com>
2257
2258         * solib-darwin.c (struct darwin_info): Add initializers.
2259         (solib_darwin_pspace_data): Change type.
2260         (darwin_pspace_data_cleanup): Remove.
2261         (get_darwin_info, _initialize_darwin_solib): Update.
2262
2263 2019-07-10  Tom Tromey  <tromey@adacore.com>
2264
2265         * remote-sim.c (struct sim_inferior_data): Add initializers,
2266         constructor, and destructor.
2267         (sim_inferior_data_key): Change type.  Move lower.
2268         (check_for_duplicate_sim_descriptor): Update.
2269         (get_sim_inferior_data): Use new.  Update.
2270         (~sim_inferior_data_cleanup): Rename from
2271         sim_inferior_data_cleanup.  Simplify.
2272         (gdbsim_close_inferior, simulator_command)
2273         (sim_command_completer, _initialize_remote_sim): Update.
2274         (next_pid, INITIAL_PID): Move earlier.
2275
2276 2019-07-10  Tom Tromey  <tromey@adacore.com>
2277
2278         * python/python-internal.h (create_thread_object): Return
2279         gdbpy_ref.
2280         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2281         * python/py-inferior.c (struct threadlist_entry): Add
2282         constructor.
2283         <thread_obj>: Now a gdbpy_ref.
2284         (thread_to_thread_object): Update.
2285         (add_thread_object): Use new.
2286         (delete_thread_object): Use delete.
2287         (infpy_threads): Update.
2288         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2289         GIL.
2290
2291 2019-07-10  Tom Tromey  <tromey@adacore.com>
2292
2293         * valops.c (value_cast): Specialize error message for Ada.
2294
2295 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2296
2297         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2298
2299 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2300
2301         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2302         bpstat_should_step): Return bool, adjust comments.
2303         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2304         bpstat_should_step): Likewise.
2305
2306 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2307
2308         * features/Makefile: Use feature target descriptions for Arm.
2309         * features/arm/arm-core.c: Generate new file.
2310         * features/arm/arm-fpa.c: Likewise.
2311         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2312         * features/arm/arm-m-profile.c: Likewise.
2313         * features/arm/arm-vfpv2.c: Likewise.
2314         * features/arm/arm-vfpv3.c: Likewise.
2315         * features/arm/xscale-iwmmxt.c: Likewise.
2316         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2317
2318 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2319
2320         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2321         ptrace earlier.
2322
2323 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2324
2325         * features/aarch64-pauth.c: Regenerate.
2326
2327 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2328
2329         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2330         bool.
2331         (bpstat_what): Use false instead of 0.
2332
2333 2019-07-09  Pedro Alves  <palves@redhat.com>
2334
2335         * break-catch-throw.c (is_exception_catchpoint): New.
2336         * breakpoint.c (print_one_breakpoint_location): New parameter
2337         'raw_loc'.  Handle it.  Use
2338         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2339         looking at the breakpoint's type.
2340         (print_one_breakpoint): If handling "maint info breakpoints", also
2341         print locations of exception catchpoints.
2342         * breakpoint.h (is_exception_catchpoint): Declare.
2343
2344 2019-07-09  Pedro Alves  <palves@redhat.com>
2345
2346         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2347         "addr" field.
2348         (allocate_location_exception_catchpoint): New.
2349         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2350         (initialize_throw_catchpoint_ops): Install
2351         allocate_location_exception_catchpoint as allocate_location
2352         method.
2353         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2354         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2355         bp_loc_other.
2356         (breakpoint_address_is_meaningful): Delete.
2357         (bl_address_is_meaningful): New.
2358         (breakpoint_locations_match): Adjust comment.
2359         (bp_location_from_bp_type): New, factored out of...
2360         (bp_location::bp_location(breakpoint *)): ... this.
2361         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2362         factored out of...
2363         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2364         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2365         breakpoint_address_is_meaningful.
2366         (bp_locations_compare): Adjust comment.
2367         (update_global_location_list): Use bl_address_is_meaningful
2368         instead of breakpoint_address_is_meaningful.
2369         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2370         explicit.
2371         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2372         * python/py-breakpoint.c (bppy_get_location): No longer check
2373         whether location is null.
2374
2375 2019-07-09  Pedro Alves  <palves@redhat.com>
2376
2377         PR c++/15468
2378         * breakpoint.c (print_one_breakpoint_location): Remove
2379         single-location assert.
2380
2381 2019-07-09  Tom Tromey  <tom@tromey.com>
2382
2383         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2384         * configure: Rebuild.
2385         * configure.ac: Change common to gdbsupport.
2386         * gdbsupport: Rename from common.
2387         * acinclude.m4: Change common to gdbsupport.
2388         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2389         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2390         gdbsupport.
2391         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2392         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2393         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2394         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2395         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2396         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2397         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2398         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2399         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2400         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2401         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2402         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2403         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2404         coff-pe-read.c, command.h, compile/compile-c-support.c,
2405         compile/compile-c.h, compile/compile-cplus-symbols.c,
2406         compile/compile-cplus-types.c, compile/compile-cplus.h,
2407         compile/compile-loc2c.c, compile/compile.c, completer.c,
2408         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2409         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2410         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2411         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2412         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2413         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2414         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2415         features/aarch64-core.c, features/aarch64-fpu.c,
2416         features/aarch64-pauth.c, features/aarch64-sve.c,
2417         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2418         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2419         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2420         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2421         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2422         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2423         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2424         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2425         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2426         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2427         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2428         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2429         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2430         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2431         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2432         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2433         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2434         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2435         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2436         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2437         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2438         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2439         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2440         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2441         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2442         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2443         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2444         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2445         minsyms.c, mips-linux-tdep.c, namespace.h,
2446         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2447         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2448         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2449         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2450         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2451         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2452         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2453         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2454         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2455         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2456         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2457         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2458         procfs.c, producer.c, progspace.h, psymtab.h,
2459         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2460         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2461         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2462         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2463         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2464         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2465         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2466         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2467         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2468         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2469         target-memory.c, target.c, target.h, target/waitstatus.c,
2470         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2471         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2472         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2473         unittests/array-view-selftests.c,
2474         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2475         unittests/common-utils-selftests.c,
2476         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2477         unittests/format_pieces-selftests.c,
2478         unittests/function-view-selftests.c,
2479         unittests/lookup_name_info-selftests.c,
2480         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2481         unittests/mkdir-recursive-selftests.c,
2482         unittests/observable-selftests.c,
2483         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2484         unittests/parse-connection-spec-selftests.c,
2485         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2486         unittests/scoped_fd-selftests.c,
2487         unittests/scoped_mmap-selftests.c,
2488         unittests/scoped_restore-selftests.c,
2489         unittests/string_view-selftests.c, unittests/style-selftests.c,
2490         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2491         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2492         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2493         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2494         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2495         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2496
2497 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2498
2499         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2500         bool value.
2501         (decode_digits_ordinary): Set explicit_line field in sal.
2502         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2503         symtab_and_line that was set on an explicit line number in
2504         assembler code.  Do always update the recorded symtab and line if
2505         we do skip the prologue.
2506
2507 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2508
2509         * breakpoint.c (set_breakpoint_location_function): Remove
2510         explicit_loc parameter.
2511         (momentary_breakpoint_from_master): Update call to
2512         set_breakpoint_location_function.
2513         (add_location_to_breakpoint): Likewise.
2514
2515 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2516
2517         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2518         required features based on default bfd type when no specific bfd
2519         is present.
2520
2521 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2522
2523         * NEWS: Mention that GDB printf and eval commands can now print
2524         C-style and Ada-style convenience var strings without
2525         calling the inferior.
2526         * printcmd.c (printf_c_string): Locally print GDB internal var
2527         instead of transiting via the inferior.
2528         (printf_wide_c_string): Likewise.
2529
2530 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2531
2532         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2533
2534 2019-07-04  Tom Tromey  <tom@tromey.com>
2535
2536         PR tui/24724:
2537         * tui/tui-winsource.c (tui_clear_source_content): Update.
2538         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2539         (tui_update_breakpoint_info): Update.
2540         (tui_set_exec_info_content): Update.
2541         * tui/tui-source.c (tui_set_source_content_nil): Update.
2542         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2543         has_break.
2544         * tui/tui-data.h (enum tui_bp_flag): New.
2545         (tui_bp_flags): New enum flags type.
2546         (struct tui_source_element) <break_mode>: Change type.  Rename
2547         from has_break.
2548         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2549         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2550         constants.
2551         * tui/tui-winsource.h: Fix comment.
2552
2553 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2554
2555         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2556         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2557         (store_fpregs_to_thread)
2558         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2559         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2560         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2561         (IWMMXT_REGS_SIZE): Add define.
2562         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2563         (fetch_vfp_regs, store_vfp_regs)
2564         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2565         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2566
2567 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2568
2569         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2570         defines.
2571         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2572         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2573         (ARM_INT_REGISTER_SIZE): ...to this.
2574         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2575         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2576         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2577         (arm_linux_collect_gregset, supply_nwfpe_register)
2578         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2579         defines.
2580         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2581         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2582         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2583         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2584         (arm_return_in_memory, arm_store_return_value)
2585         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2586         (arm_record_ld_st_multiple): Likewise.
2587         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2588         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2589
2590 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2591
2592         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2593         AARCH64_DISPLACED_MODIFIED_INSNS.
2594         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2595         (aarch64_displaced_step_copy_insn): Likewise.
2596         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2597         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2598         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2599         ARM_DISPLACED_MODIFIED_INSNS.
2600         * arm-tdep.c (arm_gdbarch_init): Likewise.
2601         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2602         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2603         (struct arm_displaced_step_closure): Use
2604         ARM_DISPLACED_MODIFIED_INSNS.
2605
2606 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2607
2608         * features/Makefile: Remove unused xml files.
2609         * features/aarch64.xml: Remove.
2610         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2611         * features/i386/amd64-avx-avx512.xml: Remove.
2612         * features/i386/amd64-avx-linux.xml: Remove.
2613         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2614         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2615         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2616         * features/i386/amd64-avx-mpx.xml: Remove.
2617         * features/i386/amd64-avx.xml: Remove.
2618         * features/i386/amd64-linux.xml: Remove.
2619         * features/i386/amd64-mpx-linux.xml: Remove.
2620         * features/i386/amd64-mpx.xml: Remove.
2621         * features/i386/amd64.xml: Remove.
2622         * features/i386/i386-avx-avx512-linux.xml: Remove.
2623         * features/i386/i386-avx-avx512.xml: Remove.
2624         * features/i386/i386-avx-linux.xml: Remove.
2625         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2626         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2627         * features/i386/i386-avx-mpx-linux.xml: Remove.
2628         * features/i386/i386-avx-mpx.xml: Remove.
2629         * features/i386/i386-avx.xml: Remove.
2630         * features/i386/i386-linux.xml: Remove.
2631         * features/i386/i386-mmx-linux.xml: Remove.
2632         * features/i386/i386-mmx.xml: Remove.
2633         * features/i386/i386-mpx-linux.xml: Remove.
2634         * features/i386/i386-mpx.xml: Remove.
2635         * features/i386/i386.xml: Remove.
2636         * features/i386/x32-avx-avx512-linux.xml: Remove.
2637         * features/i386/x32-avx-linux.xml: Remove.
2638         * features/i386/x32-linux.xml: Remove.
2639
2640 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * regformats/aarch64.dat: Remove.
2643         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2644         * regformats/i386/amd64-avx-linux.dat: Remove.
2645         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2646         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2647         * regformats/i386/amd64-linux.dat: Remove.
2648         * regformats/i386/amd64-mpx-linux.dat: Remove.
2649         * regformats/i386/amd64.dat: Remove.
2650         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2651         * regformats/i386/i386-avx-linux.dat: Remove.
2652         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2653         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2654         * regformats/i386/i386-linux.dat: Remove.
2655         * regformats/i386/i386-mmx-linux.dat: Remove.
2656         * regformats/i386/i386-mpx-linux.dat: Remove.
2657         * regformats/i386/i386.dat: Remove.
2658         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2659         * regformats/i386/x32-avx-linux.dat: Remove.
2660         * regformats/i386/x32-linux.dat: Remove.
2661
2662 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2663
2664         * aarch64-tdep.c: Remove xml self tests.
2665         * amd64-linux-tdep.c: Likewise.
2666         * amd64-tdep.c: Likewise.
2667         * i386-linux-tdep.c: Likewise.
2668         * i386-tdep.c: Likewise.
2669
2670 2019-07-03  Pedro Alves  <palves@redhat.com>
2671
2672         PR cli/24732
2673         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2674         (pipe_cmd_option_defs): New.
2675         (make_pipe_cmd_options_def_group): New.
2676         (pipe_command): Use gdb::option::process_options.
2677         (pipe_command_completer): New function.
2678         (_initialize_cli_cmds): Install completer for "pipe" command.
2679
2680 2019-07-03  Pedro Alves  <palves@redhat.com>
2681
2682         * cli/cli-option.c (union option_value) <string>: New field.
2683         (struct option_def_and_value): Add ctor, move ctor, dtor and
2684         use DISABLE_COPY_AND_ASSIGN.
2685         (option_def_and_value::clear_value): New.
2686         (parse_option, save_option_value_in_ctx, get_val_type_str)
2687         (add_setshow_cmds_for_options): Handle var_string.
2688         * cli-option.h (union option_def::var_address) <string>: New
2689         field.
2690         (struct string_option_def): New.
2691         * maint-test-options.c (struct test_options_opts): Add default
2692         ctor and use DISABLE_COPY_AND_ASSIGN.
2693         <string_opt>: New field.
2694         (test_options_opts::~test_options_opts): New.
2695         (test_options_opts::dump): Also dump "-string".
2696         (test_options_option_defs): Install "string.
2697
2698 2019-07-03  Pedro Alves  <palves@redhat.com>
2699
2700         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2701         option_value with a null enumeration.
2702         (complete_options): Save the option values in the context.
2703         (save_option_value_in_ctx): New, factored out from ...
2704         (process_options): ... here.
2705         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2706         of the function.
2707         * maint-test-options.c (test_options_opts::dump): New, factored
2708         out from ...
2709         (maintenance_test_options_command_mode): ... here.
2710         (maintenance_test_options_command_completion_result): Delete.
2711         (maintenance_test_options_command_completion_text): Update
2712         comment.
2713         (maintenance_show_test_options_completion_result): Change
2714         prototype.  Just print
2715         maintenance_test_options_command_completion_text.
2716         (save_completion_result): New.
2717         (maintenance_test_options_completer_mode): Pass options context to
2718         complete_options, and then save a dump.
2719         (_initialize_maint_test_options): Use add_cmd to install "maint
2720         show test-options-completion-result".
2721
2722 2019-07-03  Pedro Alves  <palves@redhat.com>
2723
2724         * NEWS (New commands): Mention "with" and "maint with".
2725         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2726         (with_command, with_command_completer): New.
2727         (pipe_command): Adjust to new repeat_previous
2728         interface.
2729         (_initialize_cli_cmds): Install the "with" command and its "w"
2730         alias.
2731         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2732         declarations.
2733         * cli/cli-setshow.c (parse_cli_var_uinteger)
2734         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2735         argument strings for all var_types.
2736         (get_setshow_command_value_string): New, factored out from ...
2737         (do_show_command): ... this.
2738         * cli/cli-setshow.h: Include <string>.
2739         (get_setshow_command_value_string): Declare.
2740         * command.h (repeat_previous): Now returns const char *.  Adjust
2741         comment.
2742         * maint.c: Include "cli/cli-cmds.h".
2743         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2744         (_initialize_maint_cmds): Register the "maintenance with" command.
2745         * top.c (repeat_previous): Move bits from pipe_command here:
2746         Return the saved command line, if any; error out if there's no
2747         command to relaunch.
2748
2749 2019-07-03  Pedro Alves  <palves@redhat.com>
2750
2751         * NEWS (New commands): Mention "maint set/show test-settings"
2752         instead of "maint test-settings".
2753         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2754         (maintenance_test_settings_set_list): Rename to ...
2755         (maintenance_set_test_settings_list): ... this.
2756         (maintenance_test_settings_show_list): Rename to  ...
2757         (maintenance_show_test_settings_list): ... this.
2758         (maintenance_test_settings_cmd): Delete.
2759         (maintenance_test_settings_set_cmd): ...
2760         (maintenance_set_test_settings_cmd): ... this.
2761         (maintenance_test_settings_show_cmd): ...
2762         (maintenance_show_test_settings_cmd): ... this.
2763         (maintenance_test_settings_show_value_cmd):
2764         (maintenance_show_test_settings_value_cmd): ... this.
2765         (_initialize_maint_test_settings): No longer install the "maint
2766         test-settings" prefix command.  Rename "maint test-settings set"
2767         to "maint set test-settings", and "maint test-settings show" to
2768         "maint show test-settings".  Adjust all subcommands.
2769
2770 2019-07-03  Pedro Alves  <palves@redhat.com>
2771
2772         * maint-test-settings.c: Fix file's intro comment.  Replace all
2773         references to "test-options" with references to "test-settings",
2774         in comments.
2775
2776 2019-07-03  Pedro Alves  <palves@redhat.com>
2777
2778         * maint-test-settings.c (maintenance_test_settings_xxx)
2779         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2780         New.
2781         (maintenance_test_settings_enums): Use them.
2782         (maintenance_test_settings_enum): Default to
2783         maintenance_test_settings_xxx.
2784         (_initialize_maint_test_settings): Initialize
2785         MAINTENANCE_TEST_SETTINGS_FILENAME.
2786
2787 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2788
2789         * breakpoint.h (remove_breakpoints_inf): Change return type to
2790         void, move function documentation here.
2791         * breakpoint.c (remove_breakpoints_inf): Change return type to
2792         void, move function documentation to header.
2793
2794 2019-07-02  Pedro Alves  <palves@redhat.com>
2795
2796         * NEWS (Completion improvements): Mention "info threads".
2797         * thread.c (struct info_threads_opts, info_threads_option_defs)
2798         (make_info_threads_options_def_group): New.
2799         (info_threads_command): Use gdb::option::process_options.
2800         (info_threads_command_completer): New.
2801         (_initialize_thread): Use gdb::option::build_help to build the
2802         help text for "info threads".
2803
2804 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2805
2806         * defs.h (generic_load): Move from here...
2807         * symfile.h (generic_load): ... to here.  Rename name parameter
2808         to args.
2809         * symfile.c (generic_load): Add comment.
2810
2811 2019-07-01  Tom Tromey  <tromey@adacore.com>
2812
2813         * dwarf2read.c
2814         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2815         declaration of without_params.  Fix formatting.
2816
2817 2019-07-01  Tom Tromey  <tromey@adacore.com>
2818
2819         * ada-exp.y (find_primitive_type): Update.
2820         * ada-lang.h (ada_lookup_symbol): Update.
2821         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2822         parameter.
2823         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2824
2825 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2826
2827         PR breakpoints/24541
2828         * gdbarch.c: Regenerate.
2829         * gdbarch.h: Regenerate.
2830         * gdbarch.sh: Add 'stap_adjust_register'.
2831         * i386-tdep.c: Include '<unordered_set>'.
2832         (i386_stap_adjust_register): New function.
2833         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2834         * stap-probe.c (stap_parse_register_operand): Call
2835         'gdbarch_stap_adjust_register'.
2836
2837 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
2838
2839         PR python/24742
2840         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2841         * python/python.c (do_start_initialization): Use 'xmalloc'
2842         instead of 'PyMem_Malloc'.
2843
2844 2019-06-28  Tom Tromey  <tromey@adacore.com>
2845
2846         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2847         for Ada.
2848
2849 2019-06-27  Tom Tromey  <tromey@adacore.com>
2850
2851         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
2852         objfile_key.
2853         (arm_find_mapping_symbol, arm_record_special_symbol)
2854         (_initialize_arm_tdep): Update.
2855         (arm_objfile_data_free): Remove.
2856
2857 2019-06-27  Tom Tromey  <tromey@adacore.com>
2858
2859         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2860         to cp_print_static_field.
2861
2862 2019-06-26  Tom Tromey  <tromey@adacore.com>
2863
2864         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2865         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2866         declare.
2867
2868 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2869
2870         * features/aarch64-core.c (create_feature_aarch64_core):
2871         Regenerate.
2872         * features/aarch64-core.xml: Add cpsr flags.
2873
2874 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
2875
2876         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2877         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2878
2879 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2880
2881         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2882         field.
2883         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2884         use.
2885         (arm_record_special_symbol): Don't insert new symbol in sorted
2886         position, push it at the end.
2887
2888 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
2889
2890         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2891         (arm_mapping_symbol_s): Remove.
2892         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2893         (arm_mapping_symbol_vec): New typedef.
2894         (struct arm_per_objfile): Add constructor.
2895         <section_maps>: Change type to
2896         std::unique_ptr<arm_mapping_symbol_vec[]>.
2897         (arm_compare_mapping_symbols): Remove.
2898         (arm_find_mapping_symbol): Adjust to section_maps type change.
2899         (arm_objfile_data_free): Call delete on arm_per_objfile.
2900         (arm_record_special_symbol): Adjust to section_maps type change.
2901         Allocate arm_per_objfile with new.
2902
2903 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2904
2905         * cli/cli-cmds.c (alias_command): Compare the alias prefix
2906         with the command prefix.
2907
2908 2019-06-25  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2911         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2912
2913 2019-06-25  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2916         type.
2917         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2918         protected.
2919
2920 2019-06-25  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-winsource.c
2923         (tui_source_window_base::set_is_exec_point_at): Add check against
2924         LOA_ADDRESS.
2925
2926 2019-06-25  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-source.c (tui_set_source_content): Don't check before
2929         xfree.
2930         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
2931
2932 2019-06-25  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-winsource.h (tui_update_source_window_as_is)
2935         (tui_alloc_source_buffer, tui_line_is_displayed)
2936         (tui_addr_is_displayed): Change type of win_info.
2937         * tui/tui-winsource.c (tui_update_source_window_as_is)
2938         (tui_clear_source_content, tui_show_source_line)
2939         (tui_show_source_content, tui_source_window_base::refill)
2940         (tui_source_window_base::set_is_exec_point_at)
2941         (tui_source_window_base::set_is_exec_point_at)
2942         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
2943         (tui_alloc_source_buffer, tui_line_is_displayed)
2944         (tui_addr_is_displayed): Change type of win_info.  Update.
2945         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2946         (tui_source_window_base::do_make_visible_with_new_height):
2947         Update.
2948         * tui/tui-source.c (tui_set_source_content)
2949         (tui_set_source_content_nil)
2950         (tui_source_window::do_scroll_vertical): Update.
2951         * tui/tui-layout.c (show_layout): Update.
2952         * tui/tui-disasm.c (tui_set_disassem_content)
2953         (tui_disasm_window::do_scroll_vertical): Update.
2954         * tui/tui-data.h (tui_win_content): Remove.
2955         (struct tui_gen_win_info) <content, content_size>: Remove.
2956         (struct tui_source_element): Add initializers and destructor.
2957         (union tui_which_element, struct tui_win_element): Remove.
2958         (struct tui_source_window_base) <content>: New field.
2959         (struct tui_data_window): Remove destructor.
2960         (tui_alloc_content, tui_free_win_content)
2961         (tui_free_all_source_wins_content): Don't declare.
2962         * tui/tui-data.c (tui_initialize_static_data): Update.
2963         (init_content_element, tui_alloc_content): Remove.
2964         (~tui_gen_win_info): Update.
2965         (~tui_data_window, tui_free_all_source_wins_content)
2966         (tui_free_win_content, free_content, free_content_elements):
2967         Remove.
2968
2969 2019-06-25  Tom Tromey  <tom@tromey.com>
2970
2971         * tui/tui-winsource.h (tui_clear_source_content)
2972         (tui_erase_source_content, tui_show_source_content): Change type
2973         of win_info.
2974         * tui/tui-winsource.c (tui_clear_source_content)
2975         (tui_erase_source_content, tui_show_source_content): Change type
2976         of win_info.
2977         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2978         * tui/tui-source.h (tui_set_source_content_nil): Change type of
2979         win_info.
2980         * tui/tui-source.c (tui_set_source_content_nil): Change type of
2981         win_info.
2982         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
2983
2984 2019-06-25  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-winsource.c (tui_clear_source_content)
2987         (tui_source_window_base::set_is_exec_point_at): Update.
2988         * tui/tui-source.c (tui_set_source_content_nil): Update.
2989         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
2990         a bool.
2991         * tui/tui-data.c (init_content_element): Update.
2992
2993 2019-06-25  Tom Tromey  <tom@tromey.com>
2994
2995         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
2996         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
2997         * tui/tui-layout.c (init_and_make_win): Update.
2998         * tui/tui.h (enum tui_win_type): Update.
2999         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3000         tui_win_is_auxillary.
3001         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3002         tui_win_is_auxillary.
3003
3004 2019-06-25  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3007         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3008         (tui_delete_data_content_windows, tui_display_all_data)
3009         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3010         Update.
3011         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3012         * tui/tui-regs.c (tui_last_regs_line_no)
3013         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3014         (tui_show_registers): Update.
3015         (tui_show_register_group): Return void.  Update.
3016         (tui_display_registers_from, tui_display_reg_element_at_line)
3017         (tui_display_registers_from_line, tui_check_register_values):
3018         Update.
3019         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3020         member.
3021         (struct tui_data_window) <regs_content>: Now a std::vector.
3022         <regs_content_count>: Remove.
3023         (tui_add_content_elements, tui_free_data_content): Don't declare.
3024         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3025         (init_content_element): Remove DATA_WIN case.  Add assert.
3026         (tui_add_content_elements): Remove.
3027         (tui_data_window): Update.
3028         (tui_free_data_content): Remove.
3029         (free_content_elements): Remove DATA_WIN case.
3030
3031 2019-06-25  Tom Tromey  <tom@tromey.com>
3032
3033         * tui/tui-data.c (tui_data_item_window): Update.
3034         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3035         * tui/tui-windata.c (tui_display_all_data)
3036         (tui_display_data_from_line): Update.
3037         (tui_check_data_values): Remove.
3038         * tui/tui-regs.c (tui_show_register_group)
3039         (tui_display_reg_element_at_line): Update.
3040         * tui/tui-hooks.c (tui_register_changed)
3041         (tui_refresh_frame_and_register_information): Call
3042         tui_check_register_values.
3043         * tui/tui-data.h (struct tui_data_window) <data_content,
3044         data_content_count, data_type>: Remove.
3045         (enum tui_data_type): Remove.
3046
3047         * tui/tui-data.c (tui_data_window::clear_detail)
3048         (~tui_data_window): Update.
3049
3050 2019-06-25  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3053         declare.
3054         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3055         Rename from tui_first_data_item_displayed.  Update.
3056         (tui_data_window::refresh_all)
3057         (tui_data_window::do_scroll_vertical): Update.
3058         * tui/tui-data.h (struct tui_data_window)
3059         <first_data_item_displayed>: Declare new method.
3060
3061 2019-06-25  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3064         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3065         contents...
3066         (tui_initialize_static_data): ...here.
3067
3068 2019-06-25  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3071         (tui_display_registers_from, tui_check_register_values): Update.
3072         (tui_display_register): Remove win_info parameter; update.
3073         (tui_get_register): Change type of parameters.
3074         * tui/tui-data.h (struct tui_data_element): Remove.
3075         (union tui_which_element) <data>: Remove.
3076         <data_window>: Change type.
3077         (struct tui_data_item_window): New.
3078         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3079         case.  Add assert.
3080         (~tui_data_item_window): New destructor.
3081         (free_content_elements): Remove DATA_ITEM_WIN case.
3082
3083 2019-06-25  Tom Tromey  <tom@tromey.com>
3084
3085         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3086         Remove.
3087
3088 2019-06-25  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-data.h (struct tui_command_element): Remove.
3091         (union tui_which_element) <command>: Remove.
3092         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3093         assert.
3094         (free_content_elements): Remove CMD_WIN case.
3095
3096 2019-06-25  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-layout.c (tui_set_layout): Update.
3099         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3100         * tui/tui-data.c (layout_def): Update.
3101
3102 2019-06-25  Tom Tromey  <tom@tromey.com>
3103
3104         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3105         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3106         (tui_source_window_base::set_new_height): Update.
3107         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3108         Update.
3109         (tui_set_locator_fullname, tui_set_locator_info)
3110         (tui_show_frame_info): Update.
3111         * tui/tui-source.c (tui_set_source_content)
3112         (tui_source_is_displayed): Update.
3113         * tui/tui-layout.c (show_source_disasm_command, show_data)
3114         (show_source_or_disasm_and_command): Update.
3115         * tui/tui-disasm.c (tui_set_disassem_content)
3116         (tui_get_begin_asm_address): Update.
3117         * tui/tui-data.h (struct tui_locator_element): Remove.
3118         (union tui_which_element) <locator>: Remove.
3119         (struct tui_locator_window): New.
3120         (tui_locator_win_info_ptr): Change return type.
3121         * tui/tui-data.c (_locator): Change type.
3122         (tui_locator_win_info_ptr): Change return type.
3123         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3124         (tui_alloc_content): Add assert.
3125
3126 2019-06-25  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-winsource.c
3129         (tui_exec_info_window::maybe_allocate_content): New method.
3130         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3131         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3132         (make_source_or_disasm_window): Add cast.
3133         * tui/tui-data.h (union tui_which_element) <simple_string>:
3134         Remove.
3135         (struct tui_source_info): New.
3136         (struct tui_source_window_base) <execution_info>: Change type.
3137         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3138         case, and add assert.
3139         (tui_alloc_content): Add assert.
3140
3141 2019-06-25  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3144         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3145         * tui/tui-data.c (tui_alloc_win_info): Remove.
3146
3147 2019-06-25  Tom Tromey  <tom@tromey.com>
3148
3149         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3150         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3151         can_highlight.
3152
3153 2019-06-25  Tom Tromey  <tom@tromey.com>
3154
3155         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3156         make_visible_with_new_height method.
3157         (tui_win_info::make_visible_with_new_height): New method.
3158         (tui_source_window_base::do_make_visible_with_new_height)
3159         (tui_data_window::do_make_visible_with_new_height)
3160         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3161         (make_visible_with_new_height): Remove.
3162         (tui_resize_all, tui_adjust_win_heights): Use
3163         make_visible_with_new_height method.
3164         * tui/tui-data.h (struct tui_win_info)
3165         <do_make_visible_with_new_height, make_visible_with_new_height>:
3166         New methods.
3167         (struct tui_source_window_base, struct tui_data_window)
3168         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3169         methods.
3170
3171 2019-06-25  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3174         method.
3175         (update_tab_width): Call update_tab_width method.
3176         * tui/tui-data.h (struct tui_win_info)
3177         (struct tui_source_window_base) <update_tab_width>: New methods.
3178
3179 2019-06-25  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3182         parameter.
3183         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3184         parameter.
3185         (tui_gen_win_info::make_visible): Update.
3186         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3187         parameter.
3188         * tui/tui-data.h (enum tui_box): New enum.
3189         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3194         init_and_make_win for EXEC_INFO_WIN.
3195         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3196         longer inline.
3197         (struct tui_win_info) <~tui_win_info>: Inline.
3198         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3199         Don't declare.
3200         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3201         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3202         Remove.
3203         (tui_initialize_static_data): Update.
3204         (~tui_gen_win_info): Handle more cleanup here.
3205         (~tui_source_window_base): Delete "execution_info".
3206         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3207
3208 2019-06-25  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-layout.c (make_command_window): Don't set
3211         can_highlight.
3212         (show_source_disasm_command): Call the reset method.
3213         (show_data): Don't set can_highlight.  Call the reset method.
3214         (tui_gen_win_info::reset): Rename from init_gen_win_info
3215         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3216         (show_source_or_disasm_and_command): Call the reset method.
3217         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3218         (struct tui_cmd_window): Set can_highlight.
3219
3220 2019-06-25  Tom Tromey  <tom@tromey.com>
3221
3222         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3223         from make_visible.
3224         (tui_make_visible, tui_make_invisible): Rewrite.
3225         (tui_win_info::make_visible): Remove.
3226         (tui_source_window_base::make_visible): Update.
3227         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3228         method.  Moved from...
3229         (struct tui_win_info) <make_visible>: ...here.
3230
3231 2019-06-25  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-winsource.c
3234         (tui_source_window_base::do_scroll_horizontal): Remove direction
3235         parameter.
3236         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3237         direction parameter.
3238         * tui/tui-win.c (tui_win_info::forward_scroll)
3239         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3240         (tui_win_info::right_scroll): Update.
3241         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3242         direction parameter.
3243         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3244         direction parameter.
3245         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3246         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3247         Remove direction parameter.
3248         (struct tui_source_window_base, struct tui_source_window)
3249         (struct tui_disasm_window, struct tui_data_window)
3250         (struct tui_cmd_window): Update.
3251
3252 2019-06-25  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-winsource.h (tui_set_exec_info_content)
3255         (tui_show_exec_info_content, tui_erase_exec_info_content)
3256         (tui_clear_exec_info_content, tui_update_exec_info): Change
3257         argument to tui_source_window_base.
3258         * tui/tui-winsource.c (tui_set_exec_info_content)
3259         (tui_show_exec_info_content, tui_erase_exec_info_content)
3260         (tui_clear_exec_info_content, tui_update_exec_info): Change
3261         argument to tui_source_window_base.
3262
3263 2019-06-25  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3266         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3267
3268 2019-06-25  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3271         check.
3272
3273 2019-06-25  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3276         type to void.
3277         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3278         type to void.
3279         * tui/tui-source.c (tui_set_source_content): Update.
3280         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3281
3282 2019-06-25  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-win.c (window_name_completer, tui_set_focus)
3285         (tui_all_windows_info): Use name method.
3286         * tui/tui-data.h (struct tui_gen_win_info)
3287         (struct tui_source_window, struct tui_disasm_window)
3288         (struct tui_data_window, struct tui_cmd_window) <name>: New
3289         method.
3290         (tui_win_name): Don't declare.
3291         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3292         (tui_win_name): Remove.
3293
3294 2019-06-25  Tom Tromey  <tom@tromey.com>
3295
3296         * tui/tui-winsource.h (tui_update_source_window)
3297         (tui_update_source_window_as_is): Change parameter type.
3298         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3299         to be a tui_source_window_base.
3300         (tui_update_source_window_as_is): Likewise.
3301         * tui/tui-win.c (make_visible_with_new_height): Update.
3302
3303 2019-06-25  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-winsource.c (tui_erase_source_content)
3306         (tui_show_source_content, tui_show_exec_info_content)
3307         (tui_erase_exec_info_content): Use refresh_window method.
3308         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3309         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3310         from tui_refresh_win.
3311         (tui_data_window::refresh_window): New method.
3312         (tui_win_info::refresh, tui_source_window_base::refresh)
3313         (tui_refresh_all): Use refresh_window method.
3314         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3315         method.
3316         * tui/tui-regs.c (tui_display_register): Call refresh_window
3317         method.
3318         * tui/tui-layout.c (show_source_disasm_command)
3319         (show_source_or_disasm_and_command): Call refresh_window method.
3320         * tui/tui-data.h (struct tui_gen_win_info)
3321         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3322         New method.
3323
3324 2019-06-25  Tom Tromey  <tom@tromey.com>
3325
3326         * tui/tui.c (tui_rl_other_window, tui_enable)
3327         (tui_is_window_visible, tui_get_command_dimension): Update.
3328         * tui/tui-winsource.c (tui_update_source_window_as_is)
3329         (tui_clear_source_content, tui_erase_source_content)
3330         (tui_show_source_line, tui_source_window_base::refill)
3331         (tui_source_window_base::do_scroll_horizontal)
3332         (tui_source_window_base::set_is_exec_point_at)
3333         (tui_update_breakpoint_info, tui_set_exec_info_content)
3334         (tui_alloc_source_buffer, tui_line_is_displayed)
3335         (tui_addr_is_displayed): Update.
3336         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3337         (tui_check_and_display_highlight_if_needed)
3338         (tui_win_info::make_visible, tui_win_info::refresh)
3339         (tui_refresh_all): Update.
3340         * tui/tui-windata.c (tui_first_data_item_displayed)
3341         (tui_delete_data_content_windows, tui_erase_data_content)
3342         (tui_display_all_data, tui_data_window::refresh_all)
3343         (tui_check_data_values): Update.
3344         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3345         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3346         (tui_win_info::backward_scroll, tui_refresh_all_win)
3347         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3348         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3349         (tui_source_window_base::set_new_height)
3350         (tui_data_window::set_new_height)
3351         (make_invisible_and_set_new_height)
3352         (make_visible_with_new_height, new_height_ok)
3353         (parse_scrolling_args): Update.
3354         * tui/tui-stack.c (tui_show_frame_info): Update.
3355         * tui/tui-source.c (tui_set_source_content)
3356         (tui_set_source_content_nil, tui_source_is_displayed)
3357         (tui_source_window::do_scroll_vertical): Update.
3358         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3359         (tui_display_registers_from, tui_display_reg_element_at_line)
3360         (tui_check_register_values, tui_reg_command): Update.
3361         * tui/tui-layout.c (tui_default_win_height)
3362         (show_source_disasm_command, show_data, init_and_make_win)
3363         (show_source_or_disasm_and_command): Update.
3364         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3365         (tui_redisplay_readline, tui_mld_flush)
3366         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3367         (tui_getc): Update.
3368         * tui/tui-disasm.c (tui_set_disassem_content)
3369         (tui_disasm_window::do_scroll_vertical): Update.
3370         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3371         Now virtual.
3372         (struct tui_win_info): Derive from tui_gen_win_info.
3373         <~tui_win_info>: Mark as override.
3374         <generic>: Remove member.
3375         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3376         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3377         (~tui_data_window, ~tui_win_info)
3378         (tui_free_all_source_wins_content): Update.
3379         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3380
3381 2019-06-25  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-layout.c (init_and_make_win): Use new.
3384         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3385         destructor, initializers.
3386         (tui_alloc_generic_win_info): Don't declare.
3387         * tui/tui-data.c (_locator): Add argument to constructor.
3388         (source_win, disasm_win): New globals.
3389         (exec_info): Remove.
3390         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3391         Update.
3392         (tui_alloc_generic_win_info): Remove.
3393         (init_content_element): Use new.
3394         (tui_win_info::tui_win_info): Update.
3395         (free_content_elements) <case DATA_WIN>: Use delete.
3396
3397 2019-06-25  Tom Tromey  <tom@tromey.com>
3398
3399         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3400         * tui/tui-windata.c (tui_first_data_item_displayed)
3401         (tui_delete_data_content_windows): Update.
3402         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3403         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3404         (tui_display_registers_from, tui_check_register_values): Update.
3405         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3406         pointer.
3407         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3408         window.
3409         (tui_free_data_content): Update.
3410         (free_content_elements) <case DATA_WIN>: Free the window.
3411
3412 2019-06-25  Tom Tromey  <tom@tromey.com>
3413
3414         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3415         Update.
3416         * tui/tui-layout.c (make_command_window)
3417         (show_source_disasm_command, show_data, init_and_make_win)
3418         (show_source_or_disasm_and_command): Update.
3419         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3420         method.
3421         <can_highight, is_highlighted>: Now bool.
3422         (tui_set_win_highlight): Don't declare.
3423         * tui/tui-data.c (tui_set_win_highlight): Remove.
3424
3425 2019-06-25  Tom Tromey  <tom@tromey.com>
3426
3427         * tui/tui-wingeneral.c (make_visible): Remove check of window
3428         type.
3429
3430 2019-06-25  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui-win.c (tui_win_info::max_height)
3433         (tui_cmd_window::max_height): New methods.
3434         (new_height_ok): Call max_height.
3435         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3436         <max_height>: New method.
3437
3438 2019-06-25  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-win.c (tui_source_window_base::set_new_height)
3441         (tui_data_window::set_new_height): New methods.
3442         (make_invisible_and_set_new_height): Call set_new_height method.
3443         * tui/tui-data.h (struct tui_win_info)
3444         (struct tui_source_window_base, struct tui_data_window)
3445         <set_new_height>: New method.
3446
3447 2019-06-25  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3450         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3451         tui_refresh_data_win.
3452         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3453         method.
3454         (tui_refresh_all_win): Call the refresh_all method.
3455         (tui_set_focus): Likewise.
3456         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3457         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3458         Likewise.
3459
3460 2019-06-25  Tom Tromey  <tom@tromey.com>
3461
3462         * tui/tui-winsource.h (tui_refill_source_window)
3463         (tui_set_is_exec_point_at): Don't declare.
3464         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3465         (tui_source_window_base::refill): Rename from
3466         tui_refill_source_window.
3467         (tui_source_window_base::do_scroll_horizontal): Update.
3468         (tui_source_window_base::set_is_exec_point_at): Rename from
3469         tui_set_is_exec_point_at.
3470         (tui_update_all_breakpoint_info): Update.
3471         * tui/tui-stack.c (tui_show_frame_info): Update.
3472         * tui/tui-layout.c (show_data): Add cast.
3473         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3474         * tui/tui-data.h (struct tui_source_window_base) <refill,
3475         set_is_exec_point_at>: New methods.
3476         (tui_source_windows, tui_add_to_source_windows): Update types.
3477         (tui_add_to_source_windows): Remove redundant declaration.
3478         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3479         (tui_source_windows): Change return type.
3480         (tui_clear_source_windows_detail): Update.
3481         (tui_add_to_source_windows): Change type of parameter.
3482         (tui_free_all_source_wins_content): Update.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-wingeneral.c (tui_win_info::refresh)
3487         (tui_source_window_base::refresh): New methods.
3488         (tui_refresh_all): Call the refresh method.
3489         * tui/tui-data.h (struct tui_win_info)
3490         (struct tui_source_window_base) <refresh>: New method.
3491
3492 2019-06-25  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui.h (tui_is_window_visible): Return bool.
3495         * tui/tui.c (tui_is_window_visible): Return bool.
3496         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3497         (tui_make_visible, tui_make_invisible)
3498         (tui_win_info::make_visible)
3499         (tui_source_window_base::make_visible, make_all_visible)
3500         (tui_make_all_visible, tui_make_all_invisible): Update.
3501         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3502         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3503         bool.
3504         (struct tui_win_info, struct tui_source_window_base)
3505         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3506         * tui/tui-data.c (tui_init_generic_part): Update.
3507
3508 2019-06-25  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3511         (tui_source_window_base::make_visible): New methods.
3512         (make_all_visible): Make method call.
3513         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3514         (struct tui_source_window_base, struct tui_cmd_window): Override
3515         make_visible.
3516         (tui_win_is_source_type): Don't declare.
3517         * tui/tui-data.c (tui_win_is_source_type): Remove.
3518
3519 2019-06-25  Tom Tromey  <tom@tromey.com>
3520
3521         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3522         NULL check.
3523
3524 2019-06-25  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3527         Inline constructor.  Add initializers for members.
3528         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3529         constructors; now inline in class.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-regs.c (tui_show_registers): Update.
3534         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3535         bool.
3536         * tui/tui-data.c (tui_data_window::clear_detail)
3537         (tui_data_window): Update.
3538
3539 2019-06-25  Tom Tromey  <tom@tromey.com>
3540
3541         * tui/tui-windata.c (tui_display_all_data)
3542         (tui_display_data_from_line, tui_display_data_from)
3543         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3544         Update.
3545         * tui/tui-regs.c (tui_last_regs_line_no)
3546         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3547         (tui_show_registers, tui_show_register_group)
3548         (tui_display_registers_from, tui_display_reg_element_at_line)
3549         (tui_display_registers_from_line, tui_check_register_values)
3550         (tui_reg_next, tui_reg_prev): Update.
3551         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3552         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3553         tui_data_window.
3554         (struct tui_win_info) <detail>: Remove.  Add new fields from
3555         tui_data_info.
3556         (TUI_DATA_WIN): Add cast.
3557         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3558         (~tui_data_window): Simplify.
3559
3560 2019-06-25  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-layout.c (show_source_disasm_command)
3563         (show_source_or_disasm_and_command): Update.
3564         * tui/tui-io.c (update_cmdwin_start_line)
3565         (tui_redisplay_readline): Update.
3566         * tui/tui-data.h (struct tui_command_info): Remove.
3567         (struct tui_win_info) <detail>: Remove command_info member.
3568         (struct tui_data_window) <start_line>: New member, from
3569         tui_command_info.
3570         (TUI_CMD_WIN): Add casts.
3571
3572 2019-06-25  Tom Tromey  <tom@tromey.com>
3573
3574         * tui/tui-winsource.c (tui_update_source_window)
3575         (tui_refill_source_window)
3576         (tui_source_window_base::do_scroll_horizontal)
3577         (tui_update_breakpoint_info, tui_set_exec_info_content)
3578         (tui_show_exec_info_content, tui_erase_exec_info_content)
3579         (tui_clear_exec_info_content): Update.
3580         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3581         Update.
3582         * tui/tui-win.c (make_invisible_and_set_new_height)
3583         (make_visible_with_new_height): Update.
3584         * tui/tui-source.c (tui_set_source_content)
3585         (tui_show_symtab_source): Update.
3586         * tui/tui-layout.c (extract_display_start_addr)
3587         (show_source_disasm_command, show_data)
3588         (make_source_or_disasm_window)
3589         (show_source_or_disasm_and_command): Update.
3590         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3591         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3592         "gdbarch".
3593         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3594         to tui_source_window_base.
3595         (struct tui_win_info) <detail>: Remove source_info member.
3596         (struct tui_source_window_base) <has_locator>: Inline.
3597         Move contents from tui_source_info; rename has_locator member to
3598         m_has_locator.
3599         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3600         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3601         header file.
3602         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3603         Simplify.
3604         (tui_free_all_source_wins_content): Cast to
3605         tui_source_window_base.
3606
3607 2019-06-25  Tom Tromey  <tom@tromey.com>
3608
3609         * tui/tui-win.c (make_invisible_and_set_new_height)
3610         (make_visible_with_new_height): Call has_locator method.
3611         * tui/tui-layout.c (show_source_disasm_command, show_data)
3612         (show_source_or_disasm_and_command): Update for bool change.
3613         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3614         (tui_win_info) <has_locator>: New method.
3615         (struct tui_source_window_base) <has_locator>: New method.
3616         (tui_win_has_locator): Don't declare.
3617         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3618         from tui_win_has_locator.
3619         (tui_source_window_base): Use false, not FALSE.
3620
3621 2019-06-25  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3624         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3625         clear_detail method directly.
3626         (tui_clear_win_detail): Remove.
3627
3628 2019-06-25  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3631         "this", not TUI_DISASM_WIN.
3632
3633 2019-06-25  Tom Tromey  <tom@tromey.com>
3634
3635         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3636         declare.
3637         * tui/tui-winsource.c
3638         (tui_source_window_base::do_scroll_horizontal): Rename from
3639         tui_horizontal_source_scroll.
3640         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3641         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3642         from tui_vertical_data_scroll.
3643         * tui/tui-win.h (tui_scroll): Don't declare.
3644         * tui/tui-win.c (tui_win_info::forward_scroll)
3645         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3646         (tui_win_info::right_scroll): Rename and update.
3647         (tui_scroll_forward_command, tui_scroll_backward_command)
3648         (tui_scroll_left_command, tui_scroll_right_command): Update.
3649         (tui_scroll): Remove.
3650         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3651         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3652         from tui_vertical_source_scroll.
3653         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3654         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3655         from tui_vertical_disassem_scroll.
3656         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3657         do_scroll_horizontal>: New methods.
3658         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3659         Likewise.
3660         (struct tui_source_window_base): Add do_scroll_horizontal.
3661         (struct tui_source_window, struct tui_disasm_window): Add
3662         do_scroll_vertical.
3663         (struct tui_data_window, struct tui_cmd_window): Add
3664         do_scroll_horizontal and do_scroll_vertical.
3665         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3666
3667 2019-06-25  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-data.h (struct tui_source_window_base): New struct.
3670         (struct tui_source_window): Derive from tui_source_window_base.
3671         (struct tui_disasm_window): New struct.
3672         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3673         from tui_source_window::clear_detail.
3674         (tui_source_window_base): Rename from tui_source_window.
3675         (~tui_source_window_base): Rename from ~tui_source_window.
3676         (tui_alloc_win_info): Create a tui_disasm_window.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-data.h (struct tui_source_window)
3681         (struct tui_data_window): Declare destructors.
3682         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3683         destructors.
3684         (tui_win_info): Simplify.
3685
3686 2019-06-25  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-winsource.c (tui_display_main)
3689         (tui_update_source_windows_with_addr)
3690         (tui_update_all_breakpoint_info): Update.
3691         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3692         (new_height_ok, parse_scrolling_args): Update.
3693         * tui/tui-stack.c (tui_show_frame_info): Update.
3694         * tui/tui-data.h (struct tui_list): Remove.
3695         (tui_source_windows): Return a reference to a std::vector.
3696         * tui/tui-data.c (source_windows): Now a std::vector.
3697         (tui_source_windows): Change return type.
3698         (tui_clear_source_windows): Rewrite.
3699         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3700         (tui_free_all_source_wins_content): Rewrite.
3701
3702 2019-06-25  Tom Tromey  <tom@tromey.com>
3703
3704         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3705         (struct tui_data_window, struct tui_cmd_window): Declare
3706         clear_detail method.
3707         * tui/tui-data.c (tui_source_window::clear_detail)
3708         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3709         methods.
3710         (tui_clear_win_detail): Simplify.
3711
3712 2019-06-25  Tom Tromey  <tom@tromey.com>
3713
3714         * tui/tui-layout.c (make_source_window, make_disasm_window)
3715         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3716         Return the new window.
3717         (show_source_disasm_command, show_data)
3718         (show_source_or_disasm_and_command): Update.
3719
3720 2019-06-25  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3723         parameter.  Return the new window.
3724         (show_source_disasm_command): Update and remove NULL check.
3725         (show_source_or_disasm_and_command): Update.
3726
3727 2019-06-25  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3730
3731 2019-06-25  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-data.h (struct tui_win_info): Make constructor
3734         protected.  Make destructor virtual.  Add initializers.
3735         (tui_source_window, tui_data_window, tui_cmd_window): New
3736         classes.
3737         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3738         constructor.  Add "type" parameter.
3739         (tui_source_window, tui_data_window, tui_cmd_window): New
3740         constructors.
3741         (tui_alloc_win_info): Instantiate the appropriate subclass.
3742
3743 2019-06-25  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-win.c (tui_resize_all): Use delete.
3746         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3747         destructor.
3748         (tui_free_window): Don't declare.
3749         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3750         Update.
3751
3752 2019-06-25  Tom Tromey  <tom@tromey.com>
3753
3754         * tui/tui-data.h (struct tui_win_info): Add constructor.
3755         * tui/tui-data.c (tui_alloc_win_info): Use new.
3756         (tui_free_window): Use delete.
3757
3758 2019-06-22  Tom Tromey  <tom@tromey.com>
3759
3760         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3761         declare.
3762         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3763
3764 2019-06-22  Tom Tromey  <tom@tromey.com>
3765
3766         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3767         declare.
3768         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3769
3770 2019-06-22  Tom de Vries  <tdevries@suse.de>
3771
3772         * dwarf2read.c (create_addrmap_from_aranges)
3773         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3774         instead of '%zu'.
3775
3776 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3777
3778         * dwarf2read.h (dwarf2_section_info_def): Remove.
3779         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3780         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3781         std::vector<dwarf2_section_info>.
3782         (struct dwo_file) <~dwo_file>: Remove.
3783         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3784         types field.
3785         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3786         (dwarf2_read_debug_names): Likewise.
3787         (create_debug_types_hash_table): Change parameter type to
3788         array_view, adjust code accordingly.
3789         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3790         (partial_die_info::fixup): Likewise.
3791         (determine_prefix): Likewise.
3792         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3793
3794 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3795
3796         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3797         gdb_bfd_ref_ptr.
3798         <~dwo_file>: Remove call to gdb_bfd_unref.
3799         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3800         gdb_bfd_ref_ptr::get.
3801
3802 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3803
3804         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3805         type to htab_up.
3806         * dwarf2read.c (struct dwo_file): Initialize fields.
3807         <~dwo_file>: New.
3808         (free_dwo_file): Remove, move content to ~dwo_file.
3809         (struct dwo_file_deleter): Remove.
3810         (dwo_file_up>: Remove custom deleter.
3811         (free_dwo_files): Remove.
3812         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3813         dwo_files.
3814         (process_skeletonless_type_units): Call unique_ptr::get.
3815         (allocate_dwo_file_hash_table): Add deleter to created hash
3816         table.  Change return type to htab_up.
3817         (lookup_dwo_file_slot): Don't memset dwo_file, call
3818         unique_ptr::get.
3819         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3820         (create_dwo_unit_in_dwp_v2): Likewise.
3821         (open_and_init_dwo_file): Likewise.
3822         (free_dwo_file_from_slot): Remove.
3823
3824 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3825
3826         * dwarf2read.h (struct dwarf2_section_info) <readin,
3827         is_virtual>: Change type to bool.
3828         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3829         true instead of 1.
3830
3831 2019-06-19  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-data.h (tui_init_content_element): Don't declare.
3834
3835 2019-06-19  Tom Tromey  <tom@tromey.com>
3836
3837         * tui/tui-data.h (tui_init_win_info): Don't declare.
3838
3839 2019-06-19  Tom de Vries  <tdevries@suse.de>
3840
3841         * dwarf2read.h (abstract_to_concrete): Change type to
3842         std::unordered_map<sect_offset, std::vector<sect_offset>,
3843         gdb::hash_enum<sect_offset>>.
3844
3845 2019-06-19  Tom Tromey  <tromey@adacore.com>
3846
3847         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3848         EVAL_AVOID_SIDE_EFFECTS specially.
3849
3850 2019-06-19  Tom Tromey  <tromey@adacore.com>
3851
3852         * source-cache.c (highlighter): New global.
3853         (source_cache::get_source_lines): Create a highlighter on demand.
3854
3855 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * defs.h (deprecated_interactive_hook): Delete declaration.
3858         * interps.c (clear_interpreter_hooks): Remove use of
3859         deprecated_interactive_hook.
3860         * top.c (deprecated_interactive_hook): Delete definition.
3861         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3862
3863 2019-06-18  Tom de Vries  <tdevries@suse.de>
3864
3865         PR gdb/24515
3866         * dwarf2read.h (abstract_to_concrete): Change type from
3867         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3868         std::unordered_map<sect_offset, std::vector<sect_offset>>.
3869         * dwarf2read.c (read_variable): Update.
3870         (dwarf2_fetch_die_loc_sect_off): Update.
3871
3872 2019-06-17  Tom de Vries  <tdevries@suse.de>
3873
3874         PR gdb/24617
3875         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3876         accessing parent[parent_len - 1].
3877
3878 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
3879
3880         PR gdb/24364
3881         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3882         call dtrace_process_dof with NULL dof.
3883
3884 2019-06-16  Tom de Vries  <tdevries@suse.de>
3885
3886         PR gdb/24445
3887         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3888
3889 2019-06-16  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3892         (make_all_visible): Use address of member.
3893
3894 2019-06-16  Tom Tromey  <tom@tromey.com>
3895
3896         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3897         (tui_free_window, free_content, free_content_elements): Remove
3898         unnecessary cast.
3899         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3900         cast.
3901         * tui/tui-regs.c (tui_show_register_group)
3902         (tui_display_registers_from, tui_display_reg_element_at_line):
3903         Remove unnecessary cast.
3904
3905 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * linux-nat.c (normal_mask): Delete.
3908         (_initialize_linux_nat): Don't initialise normal_mask.
3909
3910 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
3911
3912         PR gdb/24445
3913         * dwarf-index-write.h (write_psymtabs_to_index): Add
3914         dwz_basename parameter.
3915         * dwarf-index-write.c (write_gdbindex): Move file writing to
3916         write_gdbindex_1.  Change return type void.
3917         (assert_file_size): Move up, remove filename parameter.
3918         (write_gdbindex_1): New function.
3919         (write_debug_names): Change return type to void, call
3920         assert_file_size.
3921         (struct index_wip_file): New struct.
3922         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
3923         file logic to index_wip_file.  Write index for dwz file if
3924         needed.
3925         (save_gdb_index_command): Pass basename of dwz file, if present.
3926         * dwarf-index-cache.c (index_cache::store): Obtain and pass
3927         build-id of dwz file, if present.
3928         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
3929         (dwarf2_get_dwz_file): Likewise.
3930         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
3931         (dwarf2_get_dwz_file): Likewise.
3932
3933 2019-06-16  Tom Tromey  <tom@tromey.com>
3934
3935         * coffread.c (process_coff_symbol): Use xstrdup.
3936         * value.c (create_internalvar): Use xstrdup.
3937
3938 2019-06-16  Tom Tromey  <tom@tromey.com>
3939
3940         * valops.c (value_cast, value_slice): Remove unnecessary cast.
3941         * breakpoint.c (stopin_command, stopat_command)
3942         (until_break_command, decode_location_default): Remove unnecessary
3943         cast.
3944         * utils.c (subset_compare): Remove unnecessary cast.
3945         * ada-lang.c (ada_update_initial_language): Remove unnecessary
3946         cast.
3947         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
3948         cast.
3949         * infcmd.c (path_command): Remove unnecessary cast.
3950         * coffread.c (decode_type): Remove unnecessary cast.
3951         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
3952         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
3953         * tui/tui-stack.c (tui_show_locator_content)
3954         (tui_show_frame_info): Remove unnecessary cast.
3955         * tui/tui-win.c (tui_scroll_forward_command)
3956         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
3957         (parse_scrolling_args): Remove unnecessary cast.
3958         * tui/tui-data.c (init_win_info, tui_del_window)
3959         (tui_free_window, tui_del_data_windows, tui_free_data_content)
3960         (free_content_elements): Remove unnecessary cast.
3961         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
3962         unnecessary cast.
3963         * tui/tui-source.c (tui_set_source_content)
3964         (tui_vertical_source_scroll): Remove unnecessary cast.
3965         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
3966         cast.
3967         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
3968         * tui/tui-regs.c (tui_display_registers_from)
3969         (tui_display_register): Remove unnecessary cast.
3970         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
3971         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
3972         (make_visible): Remove unnecessary cast.
3973         * tui/tui-winsource.c (tui_erase_source_content)
3974         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
3975         unnecessary cast.
3976         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
3977         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
3978         * stabsread.c (read_type, read_array_type, read_range_type):
3979         Remove unnecessary cast.
3980         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
3981         (parse_symbol, parse_type, upgrade_type, parse_external)
3982         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
3983         unnecessary cast.
3984         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
3985
3986 2019-06-16  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-data.c (tui_alloc_generic_win_info)
3989         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
3990         checks.
3991
3992 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
3993             Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * f-typeprint.c (f_print_type): Don't return early for not
3996         associated or not allocated types.
3997         (f_type_print_varspec_suffix): Add print_rank parameter and print
3998         ranks of array types in case they dangling.
3999         (f_type_print_base): Add print_rank parameter.
4000
4001 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * NEWS: Mention new MI commands.
4004         * break-catch-throw.c (enum exception_event_kind): Move to
4005         breakpoint.h.
4006         (print_mention_exception_catchpoint): Output text as a single
4007         message.
4008         (catch_exception_command_1): Rename to...
4009         (catch_exception_event): ...this, make non-static, update header
4010         command, and change some parameter types.
4011         (catch_catch_command): Update for changes to
4012         catch_exception_command_1.
4013         (catch_throw_command): Likewise.
4014         (catch_rethrow_command): Likewise.
4015         * breakpoint.c (enum exception_event_kind): Delete.
4016         * breakpoint.h (enum exception_event_kind): Moved here from
4017         break-catch-throw.c.
4018         (catch_exception_event): Declare.
4019         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4020         (mi_cmd_catch_throw): New function.
4021         (mi_cmd_catch_rethrow): New function.
4022         (mi_cmd_catch_catch): New function.
4023         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4024         'catch-catch' entries.
4025         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4026         (mi_cmd_catch_rethrow): Declare.
4027         (mi_cmd_catch_catch): Declare.
4028
4029 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4030
4031         * annotate.c (annotate_source_line): Change return type to void,
4032         update implementation to match.
4033         * annotate.h (annotate_source_line): Change return type to void,
4034         update header comment.
4035         * stack.c (print_frame_info): Don't change what frame information
4036         is printed based on whether annotations are on or not.
4037
4038 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4041         (annotate_source): Make static.
4042         (annotate_source_line): Moved from source.c and renamed from
4043         identify_source_line.  Update the return type.
4044         * annotate.h (annotate_source): Delete declaration.
4045         (annotate_source_line): Declaration moved from source.h, and
4046         renamed from identify_source_line.  Return type updated.
4047         * source.c (identify_source_line): Moved to annotate.c and renamed
4048         to annotate_source_line.
4049         (info_line_command): Remove check of annotation_level.
4050         * source.h (identify_source_line): Move declaration to annotate.h
4051         and rename to annotate_source_line.
4052         * stack.c: Add 'annotate.h' include.
4053         (print_frame_info): Remove check of annotation_level before
4054         calling annotate_source_line.
4055
4056 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * source-cache.c (source_cache::get_plain_source_lines): Use
4059         open_source_file_with_line_charpos instead of just
4060         open_source_file, remove call to find_source_lines.
4061         (source_cache::get_source_lines): Likewise.
4062         * source.c (find_source_lines): Make static.
4063         (get_filename_and_charpos): Renamed into...
4064         (open_source_file_with_line_charpos): ..this along with changes to
4065         return a scoped_fd, and some other minor clean ups.
4066         (identify_source_line): Use open_source_file_with_line_charpos.
4067         (search_command_helper): Use open_source_file_with_line_charpos
4068         instead of just open_source_file, remove call to
4069         find_source_lines.
4070         * source.h (open_source_file_with_line_charpos): Declare new
4071         function.
4072         (find_source_lines): Delete declaration.
4073
4074 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4075
4076         * source.c (get_filename_and_charpos): Remove fullname
4077         parameter.
4078         (identify_source_line): Update call to get_filename_and_charpos.
4079
4080 2019-06-14  Tom Tromey  <tromey@adacore.com>
4081
4082         PR gdb/24502:
4083         * ui-style.h (skip_ansi_escape): Update comment.
4084         * ui-file.h (class no_terminal_escape_file): New class.
4085         * ui-file.c (no_terminal_escape_file::write)
4086         (no_terminal_escape_file::puts): New methods.
4087         * cli/cli-logging.c (handle_redirections): Use
4088         no_terminal_escape_file.
4089
4090 2019-06-14  Tom Tromey  <tromey@adacore.com>
4091
4092         * NEWS: Move convenience variable news above Python news.
4093
4094 2019-06-14  Tom Tromey  <tom@tromey.com>
4095
4096         * gnulib: Move directory to top-level.
4097         * configure.ac: Don't configure gnulib.
4098         * configure: Rebuild.
4099         * common/common-defs.h: Use new path to gnulib.
4100         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4101         (GNULIB_H): Remove.
4102         (INCGNU): Look in new gnulib location.
4103         (HFILES_NO_SRCDIR): Remove gnulib files.
4104         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4105         (generated_files): Remove GNULIB_H.
4106         ($(LIBGNU), all-lib): Remove targets.
4107         (distclean): Don't mention GNULIB_BUILDDIR.
4108         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4109
4110 2019-06-14  Tom Tromey  <tromey@adacore.com>
4111
4112         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4113         Warn if symbol file does not provide any symbols.
4114
4115 2019-06-14  Tom Tromey  <tromey@adacore.com>
4116
4117         * source.c (find_and_open_source): Respect basenames_may_differ.
4118
4119 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * annotate.c (annotate_breakpoints_invalid): Make use of
4122         scoped_restore_terminal_state.
4123         (annotate_frames_invalid): Likewise.
4124
4125 2019-06-14  Tom Tromey  <tromey@adacore.com>
4126
4127         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4128         allow assignment to an internalvar.
4129
4130 2019-06-14  Tom Tromey  <tromey@adacore.com>
4131
4132         * ada-lex.l: Allow "_" in attribute names.
4133
4134 2019-06-14  Tom Tromey  <tromey@adacore.com>
4135
4136         PR gdb/24653:
4137         * regcache.c (registers_changed): Don't call alloca.
4138         * top.c (execute_command): Don't call alloca.
4139
4140 2019-06-13  Pedro Alves  <palves@redhat.com>
4141
4142         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4143         'expression'.  When parsing an expression, error out if there's
4144         junk after "unlimited".
4145         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4146         (do_set_command): Adjust calls to is_unlimited_literal.
4147
4148 2019-06-13  Pedro Alves  <palves@redhat.com>
4149
4150         * compile/compile.c (make_compile_options_def_group): Add braces
4151         around array_view initializer.
4152         * thread.c (make_thread_apply_all_options_def_group)
4153         (make_thread_apply_all_options_def_group): Likewise.
4154
4155 2019-06-13  Pedro Alves  <palves@redhat.com>
4156
4157         * NEWS (New commands): Mention "maint test-options
4158         require-delimiter", "maint test-options unknown-is-error", "maint
4159         test-options unknown-is-operand" and "maint show
4160         test-options-completion-result".
4161         (New command options, command completion): New section.
4162         (Completion improvements): New section.
4163         Mention that you can abbreviate "unlimited".
4164
4165 2019-06-13  Pedro Alves  <palves@redhat.com>
4166
4167         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4168         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4169         * unittests/cli-utils-selftests.c (test_parse_flags)
4170         (test_parse_flags_qcs): Delete.
4171         (test_cli_utils): Don't call deleted functions.
4172
4173 2019-06-13  Pedro Alves  <palves@redhat.com>
4174
4175         * thread.c: Include "cli/cli-option.h".
4176         (tp_array_compar_ascending): Global.
4177         (tp_array_compar): Delete function.
4178         (tp_array_compar_ascending, tp_array_compar_descending): New
4179         functions.
4180         (ascending_option_def, qcs_flag_option_def)
4181         (thr_qcs_flags_option_defs)
4182         (make_thread_apply_all_options_def_group)
4183         (make_thread_apply_options_def_group): New.
4184         (thread_apply_all_command): Use gdb::option::process_options.
4185         (thread_apply_command_completer)
4186         (thread_apply_all_command_completer): New.
4187         (thread_apply_command): Use gdb::option::process_options.
4188         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4189         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4190         to generate help text of "thread apply".  Adjust "taas"'s help.
4191         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4192         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4193
4194 2019-06-13  Pedro Alves  <palves@redhat.com>
4195
4196         * thread.c (thread_apply_command): Check for invalid TID with
4197         isdigit instead of !isalpha.
4198
4199 2019-06-13  Pedro Alves  <palves@redhat.com>
4200
4201         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4202         (validate_flags_qcs): New.
4203         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4204         (validate_flags_qcs): Declare.
4205         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4206         (make_frame_apply_options_def_group): New.
4207         (frame_apply_command_count): Process options with
4208         gdb::option::process_options.
4209         (frame_apply_completer): New.
4210         (frame_apply_level_completer, frame_apply_all_completer)
4211         (frame_apply_completer): New.
4212         (_initialize_stack): Update help of "frame apply", "frame apply
4213         level", "frame apply all" and "faas" to mention supported options
4214         and install command completers.
4215         * stack.h (frame_apply_all_completer): Declare.
4216         * thread.c: Include "stack.h".
4217         (tfaas_command): Add "--".
4218         (_initialize_thread): Update help "tfaas" to mention supported
4219         options and install command completer.
4220
4221 2019-06-13  Pedro Alves  <palves@redhat.com>
4222
4223         * completer.c (complete_nested_command_line): New.
4224         (gdb_completion_word_break_characters_throw): Add assertion.
4225         * completer.h (complete_nested_command_line): Declare.
4226
4227 2019-06-13  Pedro Alves  <palves@redhat.com>
4228
4229         * stack.c (parse_backtrace_qualifiers): New.
4230         (backtrace_command): Use it.
4231         (backtrace_command_completer): Complete on qualifiers.
4232
4233 2019-06-13  Pedro Alves  <palves@redhat.com>
4234
4235         * frame.c: Include "cli/cli-option.h.
4236         (user_set_backtrace_options): New.
4237         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4238         Delete.
4239         (get_prev_frame): Adjust.
4240         (boolean_option_def, uinteger_option_def)
4241         (set_backtrace_option_defs): New.
4242         (_initialize_frame): Adjust and use
4243         gdb::option::add_setshow_cmds_for_options to install "set
4244         backtrace past-main" and "set backtrace past-entry".
4245         * frame.h: Include "cli/cli-option.h".
4246         (struct frame_print_options): Forward declare.
4247         (print_frame_arguments_all, print_frame_arguments_scalars)
4248         (print_frame_arguments_none): Declare.
4249         (print_entry_values): Delete declaration.
4250         (struct frame_print_options, user_frame_print_options): New.
4251         (struct set_backtrace_options): New.
4252         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4253         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4254         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4255         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4256         (list_args_or_locals): Add frame_print_options parameter.
4257         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4258         * python/py-framefilter.c (enumerate_args): Pass down
4259         USER_FRAME_PRINT_OPTIONS.
4260         * stack.c: Include "cli/cli-option.h".
4261         (print_frame_arguments_all, print_frame_arguments_scalars)
4262         (print_frame_arguments_none): Declare.
4263         (print_raw_frame_arguments, print_entry_values): Delete.
4264         (user_frame_print_options): New.
4265         (boolean_option_def, enum_option_def, frame_print_option_defs):
4266         New.
4267         (struct backtrace_cmd_options): New.
4268         (bt_flag_option_def): New.
4269         (backtrace_command_option_defs): New.
4270         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4271         (print_frame_arg, read_frame_arg, print_frame_args)
4272         (print_frame_info, print_frame): Add frame_print_options parameter
4273         and use it.
4274         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4275         (backtrace_command_1): Add frame_print_options and
4276         backtrace_cmd_options parameters and use them.
4277         (make_backtrace_options_def_group): New.
4278         (backtrace_command): Process command options with
4279         gdb::option::process_options.
4280         (backtrace_command_completer): New.
4281         (_initialize_stack): Extend "backtrace"'s help to mention
4282         supported options.  Install completer for "backtrace".
4283         Install some settings commands with add_setshow_cmds_for_options.
4284
4285 2019-06-13  Pedro Alves  <palves@redhat.com>
4286
4287         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4288         and that "set/show print raw frame-arguments" are now deprecated.
4289
4290         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4291         command.
4292         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4293         * stack.c (_initialize_stack): Install "set/show print
4294         raw-frame-arguments", and deprecate "set/show print raw
4295         frame-arguments".
4296         * valprint.c (_initialize_valprint): Deprecate "set/show print
4297         raw".
4298
4299 2019-06-13  Pedro Alves  <palves@redhat.com>
4300
4301         * compile/compile.c (struct compile_options): New.
4302         (compile_flag_option_def, compile_command_option_defs)
4303         (make_compile_options_def_group): New.
4304         (compile_file_command): Handle options with
4305         gdb::option::process_options.
4306         (compile_file_command_completer): New function.
4307         (compile_code_command): Handle options with
4308         gdb::option::process_options.
4309         (compile_code_command_completer): New function.
4310         (_initialize_compiler): Install completers for "compile code" and
4311         "compile file".  Mention available options in "compile code" and
4312         "compile code"'s help.
4313         * completer.c (advance_to_completion_word): New, factored out from
4314         ...
4315         (advance_to_expression_complete_word_point): ... this.
4316         (advance_to_filename_complete_word_point): New.
4317         * completer.h (advance_to_filename_complete_word_point): New
4318         declaration.
4319
4320 2019-06-13  Pedro Alves  <palves@redhat.com>
4321
4322         * compile/compile.c: Include "cli/cli-option.h".
4323         (compile_print_value): Scope data pointer is now a
4324         value_print_options pointer; adjust.
4325         (compile_print_command): Process options.  Scope data pointer is
4326         now a value_print_options pointer; adjust.
4327         (_initialize_compile): Update "compile print"'s help to include
4328         supported options.  Install a completer for "compile print".
4329         * cp-valprint.c (show_vtblprint, show_objectprint)
4330         (show_static_field_print): Delete.
4331         (_initialize_cp_valprint): Don't install "set print
4332         static-members", "set print vtbl", "set print object" here.
4333         * printcmd.c: Include "cli/cli-option.h" and
4334         "common/gdb_optional.h".
4335         (print_command_parse_format): Rework to fill in a
4336         value_print_options instead of a format_data.
4337         (print_value): Change parameter type from format_data pointer to
4338         value_print_options reference.  Adjust.
4339         (print_command_1): Process options.  Adjust to pass down a
4340         value_print_options.
4341         (print_command_completer): New.
4342         (_initialize_printcmd): Install print_command_completer as
4343         handle_brkchars completer for the "print" command.  Update
4344         "print"'s help to include supported options.
4345         * valprint.c: Include "cli/cli-option.h".
4346         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4347         here from cp-valprint.c.
4348         (boolean_option_def, uinteger_option_def)
4349         (value_print_option_defs, make_value_print_options_def_group):
4350         New.  Use gdb::option::add_setshow_cmds_for_options to install
4351         "set print elements", "set print null-stop", "set print repeats",
4352         "set print pretty", "set print union", "set print array", "set
4353         print address", "set print symbol", "set print array-indexes".
4354         * valprint.h: Include <string> and "cli/cli-option.h".
4355         (make_value_print_options_def_group): Declare.
4356         (print_value): Change parameter type from format_data pointer to
4357         value_print_options reference.
4358         (print_command_completer): Declare.
4359
4360 2019-06-13  Pedro Alves  <palves@redhat.com>
4361
4362         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4363         (COMMON_SFILES): Add maint-test-settings.c.
4364         * cli/cli-decode.c (boolean_enums): New global, factored out from
4365         ...
4366         (add_setshow_boolean_cmd): ... here.
4367         * cli/cli-decode.h (boolean_enums): Declare.
4368         * cli/cli-option.c: New file.
4369         * cli/cli-option.h: New file.
4370         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4371         factored out from ...
4372         (parse_cli_boolean_value(const char *)): ... this.
4373         (is_unlimited_literal): Change parameter type to pointer to
4374         pointer.  Adjust and advance ARG pointer.
4375         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4376         (parse_cli_var_enum): New, factored out from ...
4377         (do_set_command): ... this.  Adjust.
4378         * cli/cli-setshow.h (parse_cli_boolean_value)
4379         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4380         (parse_cli_var_enum): Declare.
4381         * cli/cli-utils.c: Include "cli/cli-option.h".
4382         (get_ulongest): New.
4383         * cli/cli-utils.h (get_ulongest): Declare.
4384         (check_for_argument): New overloads.
4385         * maint-test-options.c: New file.
4386
4387 2019-06-13  Pedro Alves  <palves@redhat.com>
4388
4389         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4390         parse a range if "-" is at the end of the string.
4391
4392 2019-06-13  Pedro Alves  <palves@redhat.com>
4393
4394         * cli/cli-setshow.c (parse_auto_binary_operation)
4395         (parse_cli_boolean_value): Don't allow "o".
4396
4397 2019-06-13  Pedro Alves  <palves@redhat.com>
4398
4399         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4400         * NEWS: Mention maint test-settings KIND.
4401         * maint-test-settings.c: New file.
4402
4403 2019-06-13  Pedro Alves  <palves@redhat.com>
4404
4405         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4406         completer.
4407         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4408         "set" completers.
4409
4410 2019-06-13  Pedro Alves  <palves@redhat.com>
4411
4412         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4413         after item.
4414
4415 2019-06-13  Pedro Alves  <palves@redhat.com>
4416
4417         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4418
4419 2019-06-13  Pedro Alves <palves@redhat.com>
4420
4421         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4422         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4423         call.
4424         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4425         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4426         calls.
4427         (check_for_argument): Skip spaces after argument.
4428
4429 2019-06-13  Pedro Alves  <palves@redhat.com>
4430
4431         * thread.c (thread_apply_command): Adjust TID parsing.
4432         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4433         detected before end of string.
4434         (tid_is_in_list): Error out if LIST is invalid.
4435
4436 2019-06-13  Pedro Alves  <palves@redhat.com>
4437
4438         * completer.c (complete_line_internal_1): Rewind completion word
4439         point.
4440         (completion_tracker::advance_custom_word_point_by): Change
4441         parameter type to int.
4442         * completer.h (completion_tracker::advance_custom_word_point_by):
4443         Likewise.
4444
4445 2019-06-13  Pedro Alves  <palves@redhat.com>
4446
4447         * completer.c (advance_to_completion_word): Handle delimiters.
4448
4449 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4450
4451         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4452
4453 2019-06-11  Tom Tromey  <tom@tromey.com>
4454
4455         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4456         (xmalloc_failed): Move to alloc.c.
4457         * alloc.c: New file.
4458         * Makefile.in (COMMON_SFILES): Add alloc.c.
4459
4460 2019-06-11  Tom Tromey  <tom@tromey.com>
4461
4462         * nat/linux-waitpid.c: Don't include server.h.
4463         (linux_debug): Remove.
4464         (my_waitpid): Update.
4465
4466 2019-06-11  Tom Tromey  <tromey@adacore.com>
4467
4468         * infcall.c (_initialize_infcall): Remove trailing newline from
4469         help.
4470         * user-regs.c (_initialize_user_regs): Remove trailing newline
4471         from help.
4472         * typeprint.c (_initialize_typeprint): Remove trailing newline
4473         from help.
4474         * reverse.c (_initialize_reverse): Remove trailing newlines from
4475         help.
4476         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4477         from help.
4478         * language.c (add_set_language_command): Remove trailing newline
4479         from help.
4480         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4481         help.
4482         * disasm.c (_initialize_disasm): Remove trailing newline from
4483         help.
4484         * top.c (init_main): Remove trailing newline from help.
4485         * interps.c (_initialize_interpreter): Remove trailing newline
4486         from help.
4487         * btrace.c (_initialize_btrace): Remove trailing newlines from
4488         help.
4489         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4490         from help.
4491         * python/python.c (_initialize_python): Remove trailing newline
4492         from help.
4493         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4494         help.
4495         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4496         from help.  Reformat some text.
4497         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4498         from help.
4499         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4500         newline from help.
4501
4502 2019-06-11  Tom Tromey  <tromey@adacore.com>
4503
4504         * darwin-nat.c (darwin_decode_exception_message)
4505         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4506
4507 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * valops.c (value_slice): Check for not allocated or not
4510         associated values.
4511
4512 2019-06-10  Tom de Vries  <tdevries@suse.de>
4513
4514         PR gdb/24618
4515         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4516         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4517         invalid.
4518
4519 2019-06-10  Tom de Vries  <tdevries@suse.de>
4520
4521         PR gdb/24611
4522         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4523         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4524
4525 2019-06-10  Tom de Vries  <tdevries@suse.de>
4526
4527         PR symtab/24545
4528         * symtab.c (struct demangled_name_entry): Add language field.
4529         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4530         static minimal symbol".  Set and use language field.
4531
4532 2019-06-10  Tom Tromey  <tromey@adacore.com>
4533
4534         * ada-lang.c (_initialize_ada_language): Update help text.
4535
4536 2019-06-10  Tom Tromey  <tromey@adacore.com>
4537
4538         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4539         with a newline.
4540         * guile/guile.c (handle_boot_error): Don't end warning with a
4541         newline.
4542         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4543         warning with a newline.
4544         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4545         newline.
4546         (s12z_frame_cache): Likewise.
4547         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4548         a newline.
4549         * solib-svr4.c (disable_probes_interface): Don't end warning with
4550         a newline.
4551         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4552         newline.
4553         * python/python.c (do_finish_initialization): Don't end warning
4554         with a newline.
4555
4556 2019-06-10  Tom Tromey  <tom@tromey.com>
4557
4558         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4559         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4560         gdbpy_enter.
4561
4562 2019-06-10  Tom Tromey  <tromey@adacore.com>
4563
4564         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4565         data.
4566         (elf_new_init): Don't call stabsread_new_init.
4567         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4568         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4569         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4570
4571 2019-06-10  Tom de Vries  <tdevries@suse.de>
4572
4573         PR symtab/16264
4574         PR symtab/24517
4575         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4576
4577 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4578
4579         * source.c (find_and_open_source): Also rewrite relative file
4580         names.
4581
4582 2019-04-26  Amos Bird  <amosbird@gmail.com>
4583
4584         * annotate.c (annotate_thread_exited): Add "thread-exited"
4585         annotation.
4586
4587 2019-06-06  Tom Tromey  <tromey@adacore.com>
4588
4589         * maint.h (class scoped_command_stats): Use
4590         DISABLE_COPY_AND_ASSIGN.
4591         <print_time>: New method.
4592         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4593         print_time.
4594         (scoped_command_stats::print_time): New method.
4595
4596 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4599         instructions of lengths 6 or 8 bytes.
4600
4601 2019-06-04  Pedro Alves  <palves@redhat.com>
4602
4603         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4604
4605         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4606         * breakpoint.c (condition_completer): Likewise.
4607         * cli/cli-dump.c (scan_expression): Likewise.
4608         * common/filestuff.c (mkdir_recursive): Likewise.
4609         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4610         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4611         (gdb_abspath): Likewise.
4612         * compile/compile-cplus-types.c
4613         (compile_cplus_instance::decl_name): Likewise.
4614         * completer.c (complete_explicit_location):
4615         (signal_completer, reg_or_group_completer_1): Likewise.
4616         * cp-support.c (cp_remove_params_if_any): Likewise.
4617         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4618         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4619         * infcmd.c (strip_bg_char): Likewise.
4620         * linespec.c (copy_token_string): Likewise.
4621         * mi/mi-main.c (output_cores): Likewise.
4622         * psymtab.c (psymtab_search_name):
4623         * symfile.c (test_set_ext_lang_command): Likewise.
4624         * target.c (target_fileio_read_stralloc): Likewise.
4625         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4626         * value.c (complete_internalvar): Likewise.
4627
4628 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4629
4630         Add objfile property to gdb.Type.
4631         * NEWS: Mention Python API addition.
4632         * python/py-type.c (typy_get_objfile): New method.
4633
4634 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4635
4636         * NEWS: Mention the new set|show style [title|highlight].
4637         Mention changes to "show style", "help" and "apropos".
4638
4639 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4640
4641         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4642         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4643         instead of print_help_for_command.
4644         (print_doc_of_command): New function.
4645         (help_list): Add 'apropos -v word' suggestion.
4646         (print_help_for_command): Style the command name using title style.
4647         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4648         (_initialize_cli_cmds): Describe -v in apropos_command help.
4649
4650 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4651
4652         * cli/cli-style.h (cli_style_option): Add name in constructor,
4653         add m_name class member, add constructor with intensity,
4654         add name class function.
4655         (cli_style_option::add_setshow_commands): Remove name argument.
4656         (highlight_style, title_style): New styles.
4657         * cli/cli-style.c (do_show): New function that shows a style
4658         characteristic styling the style name with itself.
4659         (set_style_name): New function.
4660         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4661         Update all callers according to the changes in cli/cli-style.h.
4662         * utils.h (fputs_highlighted): New function.
4663         * utils.c (fputs_highlighted): Likewise.
4664
4665 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4666
4667         * NEWS: Mention new pipe command and new convenience variables.
4668
4669 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4670
4671         * cli/cli-cmds.c (pipe_command): New function.
4672         (_initialize_cli_cmds): Call add_com for pipe_command.
4673         Define | as an alias for pipe.
4674         (exit_status_set_internal_vars): New function.
4675         (shell_escape): Call exit_status_set_internal_vars.
4676         cli/cli-decode.c (find_command_name_length): Recognize | as
4677         a single character command.
4678
4679 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4680
4681         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4682         top.c (execute_command_to_ui_file): New function, mostly a copy
4683         of execute_command_to_string.
4684         (execute_command_to_string): Implement by calling
4685         execute_command_to_ui_file.
4686
4687 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4688
4689         * top.h (saved_command_line): Remove declaration.
4690         * top.c (previous_saved_command_line, previous_repeat_arguments):
4691         New variables.
4692         (saved_command_line): Make static, define together with other
4693         'repeat variables'.
4694         (dont_repeat): Clear repeat_arguments.
4695         (repeat_previous, get_saved_command_line, save_command_line):
4696         New functions.
4697         (gdb_init): Initialize saved_command_line
4698         and previous_saved_command_line.
4699         * main.c (captured_main_1): Remove saved_command_line initialization.
4700         * event-top.c (handle_line_of_input): Update to use
4701         the new 'repeat' related functions instead of direct access to
4702         saved_command_line.
4703         * command.h (repeat_previous, get_saved_command_line,
4704         save_command_line): New declarations.
4705         (dont_repeat): Add comment.
4706
4707 2019-05-30  Tom Tromey  <tromey@adacore.com>
4708
4709         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4710         Fix comment.
4711         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4712
4713 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4714
4715         PR cli/24587
4716         * completer.c (complete): Initialize variable word.
4717
4718 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4719
4720         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4721         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4722         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4723         'body' is NULL to the outter 'if', protecting the '!is_define'
4724         situation as well.
4725
4726 2019-05-29  Tom Tromey  <tromey@adacore.com>
4727
4728         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4729         (dwarf_unknown): New function.
4730         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4731         (dwarf_type_encoding_name): Use dwarf_unknown.
4732
4733 2019-05-29  Tom Tromey  <tromey@adacore.com>
4734
4735         PR c++/20020:
4736         * cp-valprint.c (cp_print_value_fields): Call
4737         cp_print_static_field inside "try".
4738
4739 2019-05-29  Tom Tromey  <tromey@adacore.com>
4740
4741         * inflow.c (struct terminal_info): Add default operator=.
4742         * configure: Rebuild.
4743         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4744         -Wdeprecated-copy-dtor, -Wredundant-move.
4745
4746 2019-05-29  Tom Tromey  <tromey@adacore.com>
4747
4748         * NEWS: Add entry.
4749         * infcmd.c (print_return_value_1): Handle finish_print
4750         option.
4751         (show_print_finish): New function.
4752         (_initialize_infcmd): Add "set/show print finish" commands.
4753         * valprint.c (user_print_options): Initialize new member.
4754         * valprint.h (struct value_print_options) <finish_print>: New
4755         member.
4756
4757 2019-05-28  Tom Tromey  <tromey@adacore.com>
4758
4759         * ada-lang.c (ada_remove_Xbn_suffix)
4760         (find_old_style_renaming_symbol)
4761         (parse_old_style_renaming): Remove.
4762         (ada_find_renaming_symbol): Don't call
4763         find_old_style_renaming_symbol.
4764         (ada_is_renaming_symbol): Rename from
4765         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4766         bool.  Now static.
4767         (ada_read_var_value): Update and simplify.
4768         * ada-exp.y (write_var_or_type): Remove old code.
4769
4770 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4771
4772         * event-top.c: Remove include comment.
4773         * inflow.c (class scoped_ignore_sigttou): Move from here...
4774         * inflow.h (class scoped_ignore_sigttou): ...to here.
4775         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4776         * top.c:  Remove include comment.
4777
4778 2019-05-27  Tom Tromey  <tom@tromey.com>
4779
4780         * NEWS: Fix typo.
4781
4782 2019-05-22  Tom Tromey  <tromey@adacore.com>
4783
4784         * target.c (target_follow_exec): Constify parameter.
4785         * target-delegates.c: Rebuild.
4786         * remote.c (remote_target::follow_exec): Constify parameter.
4787         * infrun.c (follow_exec): Constify parameter.
4788         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4789         (target_follow_exec): Likewise.
4790
4791 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4792
4793         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4794         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4795
4796 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4797
4798         * NEWS: Add debugredirect and testsuite sections.
4799
4800 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
4801
4802         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4803         target descriptions using exclusively floating point register name
4804         aliases.
4805
4806 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
4807
4808         PR gdb/18644:
4809         * f-lang.c (build_fortran_types): Handle the case where
4810         gdbarch_floatformat_for_type returns a nullptr.
4811
4812 2019-05-21  Tom de Vries  <tdevries@suse.de>
4813
4814         PR cli/24587
4815         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4816
4817 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4818
4819         PR gdb/18644:
4820         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4821         16-byte floats.
4822         * i386-tdep.c (i386_floatformat_for_type): Use
4823         floatformats_ia64_quad for the 16-byte floating point component
4824         within a fortran 32-byte complex number.
4825
4826 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4827
4828         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4829         delete default constructor.
4830         (find_partial_die): Update to return const struct.
4831         (partial_die_parent_scope): Move variable declaration into scope
4832         of its use and change its type to auto.
4833         (guess_partial_die_structure_name): Likewise.
4834         (partial_die_info::fixup): Likewise.
4835
4836 2019-05-17  Tom Tromey  <tromey@adacore.com>
4837
4838         * source.c (find_and_open_source): Remove cast.
4839
4840 2019-05-17  Tom Tromey  <tromey@adacore.com>
4841
4842         * annotate.c (annotate_source): Make "filename" const.
4843         * annotate.h (annotate_source): Use const.
4844
4845 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4846
4847         * disasm.c (set_disassembler_options): Send errors to stderr.
4848
4849 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4850
4851         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4852         (cli_interp_base::set_logging): Check debug_redirect.
4853         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4854         * cli/cli-logging.c (debug_redirect): Add static variable.
4855         (pop_output_files): Add default param.
4856         (handle_redirections): Print debug setting.
4857         (show_logging_command): Likewise.
4858         (_initialize_cli_logging): Add debugredirect command.
4859         * interps.c (current_interp_set_logging): Add debug_redirect
4860         parameter.
4861         * interps.h (set_logging): Add debug_redirect parameter.
4862         (current_interp_set_logging): Likewise.
4863         * mi/mi-common.h: Likewise.
4864         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4865
4866 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
4867             Tom Tromey  <tromey@adacore.com>
4868
4869         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4870         directly.
4871         * cli/cli-interp.h (make_logging_output): Remove declaration.
4872         * cli/cli-logging.c (make_logging_output): Remove function.
4873         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4874         directly.
4875         * ui-file.c (tee_file::tee_file): Remove bools.
4876         (tee_file::~tee_file): Remove deletes.
4877         * ui-file.h (tee_file): Remove bools.
4878
4879 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
4880
4881         * mi/mi-cmds.h (mi_cmd_complete): New function.
4882         * mi/mi-main.c (mi_cmd_complete): Likewise.
4883         * mi/mi-cmds.c: Define new MI command -complete.
4884         * NEWS: Mention new -complete command.
4885
4886 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
4887
4888         * completer.h (complete): New function.
4889         * completer.c (complete): Likewise.
4890         * cli/cli-cmds.c: (complete_command): Update to use new complete()
4891         function defined in completer.h.
4892
4893 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
4894
4895         * MAINTAINERS (Write After Approval): Add myself.
4896
4897 2019-05-17  Tom de Vries  <tdevries@suse.de>
4898
4899         PR gdb/24094
4900         * dwarf2read.c (struct cu_partial_die_info): New struct.
4901         (find_partial_die): Return cu_partial_die_info.
4902         (partial_die_parent_scope, guess_partial_die_structure_name)
4903         (partial_die_info::fixup): Handle new return type of find_partial_die.
4904
4905 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4906
4907         * stap-probe.c (stap_parse_register_operand): Make "regname" an
4908         "std::string", simplifying the algorithm.
4909
4910 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4911
4912         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4913         (stap_static_probe_ops::get_probes): Likewise.
4914
4915 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4916
4917         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4918         '-')" and "else if".
4919         (stap_parse_single_operand): Join checks for
4920         "gdbarch_stap_parse_special_token_p" and
4921         "gdbarch_stap_parse_special_token" in the same "if" statement.
4922         Invert check when verifying for operation on register
4923         displacement.
4924
4925 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4926
4927         * stap-probe.c (stap_get_opcode): Update comment.
4928         (stap_get_expected_argument_type): Likewise.
4929         (handle_stap_probe): Likewise.
4930
4931 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
4932
4933         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
4934         return type to 'bool'.  Adjust comment.  Use 'bool' when
4935         appropriate.
4936         (i386_stap_parse_special_token_three_arg_disp): Likewise.
4937         * stap-probe.c (stap_parse_argument_1): Likewise.
4938         (stap_is_operator): Likewise.
4939         (stap_is_generic_prefix): Likewise.
4940         (stap_is_register_prefix): Likewise.
4941         (stap_is_register_indirection_prefix): Likewise.
4942         (stap_is_integer_prefix): Likewise.
4943         (stap_generic_check_suffix): Likewise.
4944         (stap_check_integer_suffix): Likewise.
4945         (stap_check_register_suffix): Likewise.
4946         (stap_check_register_indirection_suffix): Likewise.
4947         (stap_parse_register_operand): Likewise.
4948         (stap_parse_single_operand): Likewise.
4949         (stap_parse_argument_1): Likewise.
4950         (stap_probe::get_argument_count): Likewise.
4951         (stap_is_operator): Likewise.
4952
4953 2019-05-16  Tom Tromey  <tromey@adacore.com>
4954
4955         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
4956         keyword to foreach.
4957
4958 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
4959
4960         * linux-thread-db.c (try_thread_db_load_1): Change return type
4961         to bool.
4962         (try_thread_db_load): Likewise.
4963         (try_thread_db_load_from_pdir_1): Likewise.
4964         (try_thread_db_load_from_pdir): Likewise.
4965         (try_thread_db_load_from_sdir): Likewise.
4966         (try_thread_db_load_from_dir): Likewise.
4967         (thread_db_load_search): Likewise.
4968         (has_libpthread): Likewise.
4969         (thread_db_load): Likewise.
4970
4971 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
4972
4973         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4974         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
4975         NULL, and complain/return if that's the case.
4976
4977 2019-05-15  John Darrington <john@darrington.wattle.id.au>
4978
4979         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
4980         (advance, posn, abstract_read_memory): New functions.
4981         [struct mem_read_abstraction]: New struct.
4982         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
4983
4984 2019-05-14  Tom Tromey  <tromey@adacore.com>
4985
4986         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
4987         value is not lval_memory.
4988
4989 2019-05-14  Tom Tromey  <tromey@adacore.com>
4990
4991         * solib.c (info_sharedlibrary_command): Style the file name.
4992
4993 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
4994
4995         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
4996         (aarch64_vnv_type): Likewise.
4997         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
4998         * common/tdesc.c: Likewise.
4999         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5000         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5001         * features/aarch64-fpu.xml: Add ieee half view.
5002         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5003         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5004         * gdbtypes.h (struct builtin_type): Likewise.
5005         (struct objfile_type): Likewise.
5006
5007 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5008
5009         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5010         typo.
5011         * location.h (string_to_event_location): Likewise.
5012
5013 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5014
5015         GDB 8.3 released.
5016
5017 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5018
5019         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5020         New variable declaration.
5021         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5022         New variable.
5023         (print_one_breakpoint): Use ui_out::test_flags and new global
5024         variable to compute use_fixed_output.
5025         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5026         Remove.
5027         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5028         (mi_multi_location_breakpoint_output_fixed): Remove.
5029         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5030         new variable.
5031         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5032         fix_multi_location_breakpoint_output flag if version >= 3.
5033         * ui-out.h (enum ui_out_flag)
5034         <fix_multi_location_breakpoint_output>: New enumerator.
5035
5036 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5037
5038         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5039
5040 2019-05-10  Tom Tromey  <tromey@adacore.com>
5041
5042         * ada-lang.c (catch_ada_completer): New function.
5043         (_initialize_ada_language): Use it.
5044
5045 2019-05-10  Tom Tromey  <tromey@adacore.com>
5046
5047         * thread.c (print_thread_info): Make "requested_threads" const.
5048         * gdbthread.h (print_thread_info): Make "requested_threads"
5049         const.
5050         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5051         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5052
5053 2019-05-08  Tom Tromey  <tom@tromey.com>
5054
5055         * gdbtypes.c (objfile_type_data): Change type.
5056         (objfile_type, _initialize_gdbtypes): Update.
5057
5058 2019-05-08  Tom Tromey  <tom@tromey.com>
5059
5060         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5061         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5062         (_initialize_dwarf2_frame): Update.
5063
5064 2019-05-08  Tom Tromey  <tom@tromey.com>
5065
5066         * objc-lang.c (objc_objfile_data): Change type.
5067         (find_methods): Update.
5068         (_initialize_objc_lang): Remove.
5069
5070 2019-05-08  Tom Tromey  <tom@tromey.com>
5071
5072         * stabsread.c (rs6000_builtin_type_data): Change type.
5073         (rs6000_builtin_type, _initialize_stabsread): Update.
5074
5075 2019-05-08  Tom Tromey  <tom@tromey.com>
5076
5077         * mips-tdep.c (mips_pdr_data): Remove.
5078         (_initialize_mips_tdep): Update.
5079
5080 2019-05-08  Tom Tromey  <tom@tromey.com>
5081
5082         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5083         (hppa_init_objfile_priv_data, read_unwind_info)
5084         (find_unwind_entry, _initialize_hppa_tdep): Update.
5085
5086 2019-05-08  Tom Tromey  <tom@tromey.com>
5087
5088         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5089         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5090         on obstack.
5091         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5092
5093 2019-05-08  Tom Tromey  <tom@tromey.com>
5094
5095         * mdebugread.c (basic_type_data): Change type.
5096         (basic_type, _initialize_mdebugread): Update.
5097
5098 2019-05-08  Tom Tromey  <tom@tromey.com>
5099
5100         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5101
5102 2019-05-08  Tom Tromey  <tom@tromey.com>
5103
5104         * nto-tdep.c (nto_inferior_data_reg): Change type.
5105         (nto_inferior_data): Update.
5106         (nto_inferior_data_cleanup, nto_new_inferior_data)
5107         (_initialize_nto_tdep): Remove.
5108         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5109
5110 2019-05-08  Tom Tromey  <tom@tromey.com>
5111
5112         * ada-lang.c (struct ada_inferior_data): Add initializers.
5113         (ada_inferior_data): Change type.
5114         (ada_inferior_data_cleanup): Remove.
5115         (get_ada_inferior_data, ada_inferior_exit)
5116         (struct ada_pspace_data): Add initializers, destructor.
5117         (ada_pspace_data_handle): Change type.
5118         (get_ada_pspace_data): Update.
5119         (ada_pspace_data_cleanup): Remove.
5120
5121 2019-05-08  Tom Tromey  <tom@tromey.com>
5122
5123         * coffread.c (struct coff_symfile_info): Add initializers.
5124         (coff_objfile_data_key): Move lower.  Change type.
5125         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5126         Update.
5127         (coff_free_info): Remove.
5128
5129 2019-05-08  Tom Tromey  <tom@tromey.com>
5130
5131         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5132         (fbsd_pspace_data_handle): Move lower.  Change type.
5133         (get_fbsd_pspace_data): Update.
5134         (fbsd_pspace_data_cleanup): Remove.
5135         (_initialize_fbsd_tdep): Update.
5136
5137 2019-05-08  Tom Tromey  <tom@tromey.com>
5138
5139         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5140         (get_ada_tasks_pspace_data): Update.
5141         (ada_tasks_pspace_data_cleanup): Remove.
5142         (_initialize_tasks): Update.
5143         (ada_tasks_inferior_data_handle): Change type.
5144         (get_ada_tasks_inferior_data): Update.
5145         (ada_tasks_inferior_data_cleanup): Remove.
5146         (struct ada_tasks_pspace_data): Add initializers.
5147
5148 2019-05-08  Tom Tromey  <tom@tromey.com>
5149
5150         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5151         * symfile-debug.c (debug_sym_get_probes): Change type.
5152         * stap-probe.c (handle_stap_probe):
5153         (stap_static_probe_ops::get_probes): Change type.
5154         * probe.h (class static_probe_ops) <get_probes>: Change type.
5155         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5156         (parse_probes_in_pspace): Update.
5157         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5158         Update.
5159         (any_static_probe_ops::get_probes): Change type.
5160         * elfread.c (elfread_data): New typedef.
5161         (probe_key): Change type.
5162         (elf_get_probes): Likewise.  Update.
5163         (probe_key_free): Remove.
5164         (_initialize_elfread): Update.
5165         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5166         Change type.
5167         (dtrace_process_dof_probe, dtrace_process_dof)
5168         (dtrace_static_probe_ops::get_probe): Change type.
5169
5170 2019-05-08  Tom Tromey  <tom@tromey.com>
5171
5172         * xcoffread.c (struct xcoff_symfile_info): Rename from
5173         coff_symfile_info.  Add initializers.
5174         (xcoff_objfile_data_key): Move lower.  Change type.
5175         (XCOFF_DATA): Rewrite.
5176         (xcoff_free_info): Remove.
5177         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5178         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5179         (xcoff_initial_scan): Update.
5180
5181 2019-05-08  Tom Tromey  <tom@tromey.com>
5182
5183         * solib-svr4.c (struct svr4_info): Add initializers and
5184         destructor.
5185         <probes_table>: Now an htab_up.
5186         (solib_svr4_pspace_data): Change type.
5187         (free_probes_table): Simplify.
5188         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5189         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5190         (probes_table_remove_objfile_probes, register_solib_event_probe)
5191         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5192         (_initialize_svr4_solib): Update.
5193
5194 2019-05-08  Tom Tromey  <tom@tromey.com>
5195
5196         * remote.c (remote_pspace_data): Change type.
5197         (remote_pspace_data_cleanup): Remove.
5198         (get_remote_exec_file, set_pspace_remote_exec_file)
5199         (_initialize_remote): Update.
5200
5201 2019-05-08  Tom Tromey  <tom@tromey.com>
5202
5203         * breakpoint.c (breakpoint_objfile_key): Change type.
5204         (get_breakpoint_objfile_data): Update.
5205         (free_breakpoint_objfile_data): Remove.
5206         (_initialize_breakpoint): Update.
5207
5208 2019-05-08  Tom Tromey  <tom@tromey.com>
5209
5210         * linux-tdep.c (struct linux_info): Add initializers.
5211         (linux_inferior_data): Move.  Change type.
5212         (invalidate_linux_cache_inf): Update.
5213         (linux_inferior_data_cleanup): Remove.
5214         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5215
5216 2019-05-08  Tom Tromey  <tom@tromey.com>
5217
5218         * auxv.c (auxv_inferior_data): Move.  Change type.
5219         (auxv_inferior_data_cleanup): Remove.
5220         (invalidate_auxv_cache_inf): Rewrite.
5221         (get_auxv_inferior_data, _initialize_auxv): Update.
5222
5223 2019-05-08  Tom Tromey  <tom@tromey.com>
5224
5225         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5226         (symfile_debug_objfile_data_key): Change type.
5227         (symfile_debug_installed, debug_qf_has_symbols)
5228         (debug_qf_find_last_source_symtab)
5229         (debug_qf_forget_cached_source_info)
5230         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5231         (debug_qf_print_stats, debug_qf_dump)
5232         (debug_qf_expand_symtabs_for_function)
5233         (debug_qf_expand_all_symtabs)
5234         (debug_qf_expand_symtabs_with_fullname)
5235         (debug_qf_map_matching_symbols)
5236         (debug_qf_expand_symtabs_matching)
5237         (debug_qf_find_pc_sect_compunit_symtab)
5238         (debug_qf_map_symbol_filenames)
5239         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5240         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5241         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5242         (debug_sym_read_linetable, debug_sym_relocate): Update.
5243         (symfile_debug_free_objfile): Remove.
5244         (install_symfile_debug_logging, _initialize_symfile_debug):
5245         Update.
5246
5247 2019-05-08  Tom Tromey  <tom@tromey.com>
5248
5249         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5250         allocate_on_obstack.
5251         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5252         (get_dwarf2_per_objfile): Update.
5253         (set_dwarf2_per_objfile): Remove.
5254         (dwarf2_has_info, dwarf2_get_section_info): Update.
5255         (dwarf2_free_objfile): Remove.
5256         (_initialize_dwarf2_read): Update.
5257
5258 2019-05-08  Tom Tromey  <tom@tromey.com>
5259
5260         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5261         initializers.
5262         <unsupported_script_warning_printed,
5263         script_not_found_warning_printed>: Now bool.
5264         (auto_load_pspace_data): Change type.
5265         (~auto_load_pspace_info): Rename from
5266         auto_load_pspace_data_cleanup.
5267         (get_auto_load_pspace_data, init_loaded_scripts_info)
5268         (clear_section_scripts, maybe_print_unsupported_script_warning)
5269         (maybe_print_script_not_found_warning, _initialize_auto_load):
5270         Update.
5271
5272 2019-05-08  Tom Tromey  <tom@tromey.com>
5273
5274         * objfiles.c (objfile_pspace_info): Add destructor and
5275         initializers.
5276         (objfiles_pspace_data): Change type.
5277         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5278         (get_objfile_pspace_data): Update.
5279         (objfiles_bfd_data): Change type.
5280         (get_objfile_bfd_data): Update.
5281         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5282
5283 2019-05-08  Tom Tromey  <tom@tromey.com>
5284
5285         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5286         Change type.
5287         (get_catch_syscall_inferior_data): Update.
5288         (catch_syscall_inferior_data_cleanup): Remove.
5289         (_initialize_break_catch_syscall): Update.
5290
5291 2019-05-08  Tom Tromey  <tom@tromey.com>
5292
5293         * inflow.c (struct terminal_info): Add destructor and
5294         initializers.
5295         (inflow_inferior_data): Change type.
5296         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5297         (get_inflow_inferior_data, inflow_inferior_exit)
5298         (swap_terminal_info, _initialize_inflow): Update.
5299
5300 2019-05-08  Tom Tromey  <tom@tromey.com>
5301
5302         * target-dcache.c (target_dcache_cleanup): Remove.
5303         (target_dcache_aspace_key): Change type.
5304         (target_dcache_init_p, target_dcache_invalidate)
5305         (target_dcache_get, target_dcache_get_or_init)
5306         (_initialize_target_dcache): Update.
5307         * dcache.h (struct dcache_deleter): New.
5308
5309 2019-05-08  Tom Tromey  <tom@tromey.com>
5310
5311         * symtab.c (struct symbol_cache): Add destructor and
5312         initializers.
5313         (symbol_cache_key): Move.  Change type.
5314         (make_symbol_cache, free_symbol_cache): Remove.
5315         (get_symbol_cache): Update.
5316         (symbol_cache_cleanup): Remove.
5317         (ALL_PSPACES, symbol_cache_flush)
5318         (maintenance_print_symbol_cache)
5319         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5320         Update.
5321
5322 2019-05-08  Tom Tromey  <tom@tromey.com>
5323
5324         * symtab.c (struct main_info): Add destructor and initializers.
5325         (main_progspace_key): Move.  Change type.
5326         (get_main_info): Update.
5327         (main_info_cleanup): Remove.
5328         (_initialize_symtab): Update.
5329
5330 2019-05-08  Tom Tromey  <tom@tromey.com>
5331
5332         * registry.h (DECLARE_REGISTRY): Define the _key class.
5333
5334 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5335
5336         * NEWS: Merge two 'New commands' sections.
5337
5338 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5339
5340         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5341         parameter and use Ada language definition instead.
5342         (ada_val_print_ptr): Remove unused language parameter.
5343         (ada_val_print_num): Remove language parameter and use Ada language
5344         definition instead.
5345         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5346         parameter.
5347         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5348         parameter and use Ada language definition instead.
5349         (ada_val_print_1): Update all ada_val_print_xxx calls.
5350         Remove language parameter.
5351         (ada_val_print): Update ada_val_print_1 call.
5352
5353 2019-05-08  Tom Tromey  <tromey@adacore.com>
5354
5355         * remote.c (remote_hw_watchpoint_limit)
5356         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5357         Now static.
5358
5359 2019-05-08  Tom Tromey  <tromey@adacore.com>
5360
5361         * maint.c (_initialize_maint_cmds): Move initialization code to
5362         remote.c.
5363         (watchdog, show_watchdog): Move to remote.c.
5364         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5365         "watchdog" static.
5366         (_initialize_remote): Move initialization code from maint.c.
5367         * defs.h (watchdog): Don't declare.
5368
5369 2019-05-08  Tom Tromey  <tromey@adacore.com>
5370
5371         * tui/tui-interp.c: Include main.h.
5372         * interps.c: Include main.h.
5373         * main.h (interpreter_p): Declare.
5374         * defs.h (interpreter_p): Don't declare.
5375
5376 2019-05-08  Tom Tromey  <tromey@adacore.com>
5377
5378         * dwarf2loc.c: Include dwarf2read.h.
5379         * defs.h (read_unsigned_leb128): Don't declare.
5380         * dwarf2read.h (read_unsigned_leb128): Declare.
5381
5382 2019-05-08  Tom Tromey  <tromey@adacore.com>
5383
5384         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5385         method.
5386
5387 2019-05-08  Tom Tromey  <tromey@adacore.com>
5388
5389         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5390         when no wrap column is set.
5391
5392 2019-05-08  Tom Tromey  <tromey@adacore.com>
5393
5394         * c-lang.c (c_get_string): Handle non-C-style arrays.
5395
5396 2019-05-08  Tom Tromey  <tromey@adacore.com>
5397
5398         * typeprint.c (print_offset_data::update): Print the bit offset,
5399         not the number of bits remaining.
5400
5401 2019-05-08  Tom Tromey  <tromey@adacore.com>
5402
5403         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5404         padding at end of comment.
5405
5406 2019-05-08  Tom Tromey  <tromey@adacore.com>
5407
5408         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5409         Compare main types.
5410
5411 2019-05-06  Tom Tromey  <tom@tromey.com>
5412
5413         * common/scoped_mmap.c: Include common-defs.h.
5414         * common/scoped_mmap.h: Don't include config.h.
5415
5416 2019-05-04  Tom Tromey  <tom@tromey.com>
5417
5418         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5419         (struct aarch64_call_info): Add initializers.
5420         <si>: Now a std::vector.
5421         (pass_on_stack, aarch64_push_dummy_call): Update.
5422
5423 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5424             Tom Tromey  <tom@tromey.com>
5425
5426         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5427         (ppc_threads): Now a std::vector.  Now static.
5428         (hwdebug_find_thread_points_by_tid)
5429         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5430         Update.
5431
5432 2019-05-04  Tom Tromey  <tom@tromey.com>
5433
5434         * arc-tdep.c (arc_tdesc_init): Return bool.
5435
5436 2019-05-04  Tom Tromey  <tom@tromey.com>
5437
5438         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5439         Use gdb_assert_not_reached.
5440
5441 2019-05-04  Tom Tromey  <tom@tromey.com>
5442
5443         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5444         "false".
5445
5446 2019-05-04  Tom Tromey  <tom@tromey.com>
5447
5448         * arc-tdep.c (arc_tdesc_init): Use bool.
5449
5450 2019-05-04  Tom Tromey  <tom@tromey.com>
5451
5452         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5453
5454 2019-05-04  Tom Tromey  <tom@tromey.com>
5455
5456         * cli/cli-cmds.c (valid_command_p): Return bool.
5457
5458 2019-05-04  Tom Tromey  <tom@tromey.com>
5459
5460         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5461         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5462
5463 2019-05-04  Raul Tambre  <raul@tambre.ee>
5464
5465         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5466         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5467         operator for comparison.
5468
5469 2019-05-04  Tom Tromey  <tom@tromey.com>
5470
5471         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5472         (lookup_partial_symbol, print_partial_symbols)
5473         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5474         (psymbol_compare): Update.
5475         (add_psymbol_to_bcache): Clear the entire psymbol.
5476         (maintenance_check_psymtabs): Update.
5477         * psympriv.h (struct partial_symbol): Don't derive from
5478         general_symbol_info.
5479         <obj_section, unrelocated_address, address,
5480         set_unrelocated_address>: Update.
5481         <ginfo>: New member.
5482         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5483         (debug_names::write_psymbols): Update.
5484
5485 2019-05-04  Tom de Vries  <tdevries@suse.de>
5486
5487         * contrib/cc-with-tweaks.sh: Support -n arg.
5488
5489 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5490
5491         * corelow.c (core_target::detach): Ensure frame cache and
5492         register caches are cleared.
5493         inferior.c (exit_inferior_1): Likewise.
5494
5495 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5496             Tom Tromey  <tom@tromey.com>
5497
5498         * dictionary.c (collate_pending_symbols_by_language): Remove
5499         "struct" from foreach.
5500         * symtab.c (lookup_global_symbol_from_objfile)
5501         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5502         foreach.
5503         * ser-tcp.c (net_open): Remove "struct" from foreach.
5504         * objfiles.c (objfile_relocate, objfile_rebase)
5505         (objfile_has_symbols): Remove "struct" from foreach.
5506         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5507         from foreach.
5508         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5509         foreach.
5510         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5511         "struct" from foreach.
5512         * ada-lang.c (create_excep_cond_exprs)
5513         (ada_exception_catchpoint_cond_string): Remove "struct" from
5514         foreach.
5515
5516 2019-05-03  Tom Tromey  <tromey@adacore.com>
5517
5518         * ada-exp.y (convert_char_literal): Check suffix of each
5519         enumerator.
5520
5521 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5522
5523         PR ada/21406:
5524         * ada-exp.y (yywrap): Don't define.
5525         * ada-lex.l (%option): Add noyywrap
5526         (yywrap): Remove.
5527
5528 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5529
5530         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5531         _WIN32_WINNT to the XP level, unless already defined to a higher
5532         level.
5533
5534         * unittests/parse-connection-spec-selftests.c:
5535         * ser-tcp.c:
5536         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5537         override.
5538
5539         * symfile.c (find_separate_debug_file): Remove colon from the
5540         drive spec of DOS/Windows file names of the target, so that the
5541         file name produced from DEBUGDIR and the target's directory will
5542         be valid on DOS/Windows systems.
5543
5544 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5545
5546         * rust-lang.c (val_print_struct): Handle printing structures
5547         containing strings.
5548
5549 2019-05-02  Tom Tromey  <tromey@adacore.com>
5550
5551         * valarith.c (_initialize_valarith): Remove.
5552
5553 2019-05-01  Tom Tromey  <tromey@adacore.com>
5554
5555         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5556         bitfields.
5557
5558 2019-05-01  Tom Tromey  <tromey@adacore.com>
5559
5560         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5561         for big-endian copies.
5562
5563 2019-04-30  Ali Tamur  <tamur@google.com>
5564         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5565         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5566         (read_3_bytes): New function.
5567
5568 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5569
5570         * windows-nat.c (main_thread_id): Delete.
5571         (handle_output_debug_string): Replace main_thread_id by
5572         current_event.dwThreadId.
5573         (fake_create_process): Likewise.
5574         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5575         Do not set main_thread_id.
5576         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5577         current_event.dwThreadId.
5578         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5579
5580 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5581
5582         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5583         Use current_event.dwThreadId instead of main_thread_id.
5584
5585 2019-04-30  Tom Tromey  <tromey@adacore.com>
5586
5587         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5588         (create_excep_cond_exprs): Iterate over program spaces.
5589         (ada_exception_catchpoint_cond_string): Examine all minimal
5590         symbols for exception types.
5591
5592 2019-04-30  Tom Tromey  <tromey@adacore.com>
5593
5594         PR c++/24470:
5595         * dwarf2read.c (process_structure_scope): Handle case where type
5596         has template parameters but no symbol was created.
5597
5598 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5599             Chris January  <chris.january@arm.com>
5600
5601         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5602         qualifier.
5603         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5604
5605 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5606
5607         * f-typeprint.c (f_print_type): Update rules for printing
5608         whitespace.
5609         (f_type_print_varspec_suffix): Likewise.
5610
5611 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5612             Chris January  <chris.january@arm.com>
5613
5614         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5615         function arguments.
5616
5617 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5618
5619         * f-lang.c (build_fortran_types): Change name of void type to
5620         lower case.
5621         * f-typeprint.c (f_type_print_base): Print the name of the void
5622         type, rather than a fixed string.
5623         * f-valprint.c (f_decorations): Use lower case void string.
5624
5625 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5626             Chris January  <chris.january@arm.com>
5627
5628         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5629         types for Fortran.
5630
5631 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5632             Chris January  <chris.january@arm.com>
5633             David Lecomber  <david.lecomber@arm.com>
5634
5635         * f-exp.y (BINOP_INTRINSIC): New token.
5636         (exp): New parser rule handling BINOP_INTRINSIC.
5637         (f77_keywords): Add new builtin procedures.
5638         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5639         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5640         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5641         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5642         (print_unop_subexp_f): New function.
5643         (print_binop_subexp_f): New function.
5644         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5645         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5646         (dump_subexp_body_f): Likewise.
5647         (operator_check_f): Likewise.
5648         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5649         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5650
5651 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5654         UNOP_KIND.
5655         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5656         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5657         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5658         (operator_length_f): New fuction.
5659         (print_subexp_f): New function.
5660         (op_name_f): New function.
5661         (dump_subexp_body_f): New function.
5662         (operator_check_f): New function.
5663         (exp_descriptor_f): Replace standard expression handling functions
5664         with new functions.
5665         * gdb/fortran-operator.def: New file.
5666         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5667         * gdb/std-operator.def: Remove UNOP_KIND.
5668
5669 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5670
5671         * std-operator.def: Remove unbalanced, stray double quote
5672         character.
5673
5674 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5675             Chris January  <chris.january@arm.com>
5676             Daniel Everett  <daniel.everett@arm.com>
5677             Nick Forrington  <nick.forrington@arm.com>
5678             Richard Bunt  <richard.bunt@arm.com>
5679
5680         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5681         of depth when printing anonymous structs or unions.
5682         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5683         Don't print either the top-level value, or the children if the
5684         max-depth is exceeded.
5685         (ppscm_print_children): When printing the key of a map, allow one
5686         extra level of depth.
5687         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5688         print either the top-level value, or the children if the max-depth
5689         is exceeded.
5690         (print_children): When printing the key of a map, allow one extra
5691         level of depth.
5692         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5693         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5694         (user_print_options): Initialise max_depth field.
5695         (val_print_scalar_or_string_type_p): New function.
5696         (val_print): Check to see if the max depth has been reached.
5697         (val_print_check_max_depth): Define new function.
5698         (show_print_max_depth): New function.
5699         (_initialize_valprint): Add 'print max-depth' option.
5700         * valprint.h (struct value_print_options) <max_depth>: New field.
5701         (val_print_check_max_depth): Declare new function.
5702         * NEWS: Document new feature.
5703
5704 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * ada-lang.c (ada_language_defn): Initialise new field.
5707         * c-lang.c (c_is_string_type_p): New function.
5708         (c_language_defn): Initialise new field.
5709         (cplus_language_defn): Initialise new field.
5710         (asm_language_defn): Initialise new field.
5711         (minimal_language_defn): Initialise new field.
5712         * c-lang.h (c_is_string_type_p): Declare new function.
5713         * d-lang.c (d_language_defn): Initialise new field.
5714         * f-lang.c (f_is_string_type_p): New function.
5715         (f_language_defn): Initialise new field.
5716         * go-lang.c (go_is_string_type_p): New function.
5717         (go_language_defn): Initialise new field.
5718         * language.c (default_is_string_type_p): New function.
5719         (unknown_language_defn): Initialise new field.
5720         (auto_language_defn): Initialise new field.
5721         * language.h (struct language_defn) <la_is_string_type_p>: New
5722         member variable.
5723         (default_is_string_type_p): Declare new function.
5724         * m2-lang.c (m2_language_defn): Initialise new field.
5725         * objc-lang.c (objc_language_defn): Initialise new field.
5726         * opencl-lang.c (opencl_language_defn): Initialise new field.
5727         * p-lang.c (pascal_is_string_type_p): New function.
5728         (pascal_language_defn): Initialise new field.
5729         * rust-lang.c (rust_is_string_type_p): New function.
5730         (rust_language_defn): Initialise new field.
5731
5732 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5735         New field.
5736         * ada-lang.c (ada_language_defn): Initialise new field.
5737         * c-lang.c (c_language_defn): Likewise.
5738         (cplus_language_defn): Likewise.
5739         (asm_language_defn): Likewise.
5740         (minimal_language_defn): Likewise.
5741         * d-lang.c (d_language_defn): Likewise.
5742         * f-lang.c (f_language_defn): Likewise.
5743         * go-lang.c (go_language_defn): Likewise.
5744         * language.c (unknown_language_defn): Likewise.
5745         (auto_language_defn): Likewise.
5746         * m2-lang.c (m2_language_defn): Likewise.
5747         * objc-lang.c (objc_language_defn): Likewise.
5748         * opencl-lang.c (opencl_language_defn): Likewise.
5749         * p-lang.c (pascal_language_defn): Likewise.
5750         * rust-lang.c (rust_language_defn): Likewise.
5751
5752 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5753
5754         * ada-lang.c (ada_is_character_type): Change return type to bool.
5755         (ada_is_string_type): Likewise.
5756         * ada-lang.h (ada_is_character_type): Update declaration
5757         (ada_is_string_type): Likewise.
5758
5759 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5760
5761         Support style in 'frame|thread apply'
5762
5763         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5764         * record.c (record_start, record_stop): Update callers of
5765         execute_command_to_string with false.
5766         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5767         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5768         methods.
5769         (class string_file): New constructor with term_out parameter.
5770         Override methods term_out and can_emit_style_escape.  New member
5771         term_out.
5772         (class stdio_file): Override can_emit_style_escape.
5773         (class tee_file): Override term_out and can_emit_style_escape.
5774         * utils.h (can_emit_style_escape): Remove.
5775         * utils.c (can_emit_style_escape): Likewise.
5776         Update all callers of can_emit_style_escape (SOMESTREAM) to
5777         SOMESTREAM->can_emit_style_escape.
5778         * source-cache.c (source_cache::get_source_lines): Likewise.
5779         * stack.c (frame_apply_command_count): Call execute_command_to_string
5780         passing the term_out characteristic of the current gdb_stdout.
5781         * thread.c (thr_try_catch_cmd): Likewise.
5782         * top.c (execute_command_to_string): pass term_out parameter
5783         to construct the string_file for the command output.
5784         * ui-file.c (term_cli_styling): New function (most code moved
5785         from utils.c can_emit_style_escape).
5786         (string_file::string_file, string_file::can_emit_style_escape,
5787         stdio_file::can_emit_style_escape, tee_file::term_out,
5788         tee_file::can_emit_style_escape): New functions.
5789
5790 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5791
5792         * NEWS: Mention the new set|show may-call-functions.
5793         * infcall.c (may_call_functions_p): New variable.
5794         (show_may_call_functions_p): New function.
5795         (call_function_by_hand_dummy): Throws an error if not
5796         may-call-functions.
5797         (_initialize_infcall): Call add_setshow_boolean_cmd for
5798         may-call-functions.
5799
5800 2019-04-25  Keith Seitz  <keiths@redhat.com>
5801
5802         PR c++/24367
5803         * cp-support.c (inspect_type): Don't attempt substitutions
5804         of symbol with the same name.
5805
5806 2019-04-25  Tom Tromey  <tromey@adacore.com>
5807
5808         PR gdb/24475:
5809         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5810         static.
5811
5812 2019-04-25  Tom Tromey  <tromey@adacore.com>
5813
5814         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5815         rvalue reference.
5816         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5817         (gdb_xml_parser::parse): Use std::move.
5818         * python/python-internal.h (gdbpy_convert_exception): Take a const
5819         reference.
5820         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5821         std::move.
5822         * python/py-utils.c (gdbpy_convert_exception): Take a const
5823         reference.
5824         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5825         Use std::move.
5826         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5827         Use std::move.
5828         * mi/mi-main.c (mi_print_exception): Take a const reference.
5829         * main.c (handle_command_errors): Take a const reference.
5830         * linespec.c (parse_linespec): Use std::move.
5831         * infcall.c (run_inferior_call): Use std::move.
5832         (call_function_by_hand_dummy): Use std::move.
5833         * exec.c (try_open_exec_file): Use std::move.
5834         * exceptions.h (exception_print, exception_fprintf)
5835         (exception_print_same): Update.
5836         * exceptions.c (print_exception, exception_print)
5837         (exception_fprintf, exception_print_same): Change parameters to
5838         const reference.
5839         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5840         * common/new-op.c: Use std::move.
5841         * common/common-exceptions.h (struct gdb_exception): Add move
5842         constructor.
5843         (struct gdb_exception_error, struct gdb_exception_quit, struct
5844         gdb_quit_bad_alloc): Change constructor to move constructor.
5845         (throw_exception): Change parameter to rvalue reference.
5846         * common/common-exceptions.c (throw_exception): Take rvalue
5847         reference.
5848         * cli/cli-interp.c (safe_execute_command): Use std::move.
5849         * breakpoint.c (insert_bp_location, location_to_sals): Use
5850         std::move.
5851
5852 2019-04-25  Tom Tromey  <tromey@adacore.com>
5853
5854         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5855         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5856         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5857         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5858         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5859         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5860         guile/scm-value.c: Use unpack.
5861         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5862         gdbscm_gdb_exception.
5863         (gdbscm_throw_gdb_exception): Likewise.
5864         (struct gdbscm_gdb_exception): New.
5865         (unpack): New function.
5866         (gdbscm_wrap): Use unpack.
5867
5868 2019-04-25  Tom Tromey  <tromey@adacore.com>
5869
5870         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5871         (gdb_rl_callback_handler): Use std::move.
5872         * common/common-exceptions.h (struct gdb_exception): Add move
5873         assignment operator.
5874         (throw_exception_sjlj): Change "exception" to const reference.
5875         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5876         (throw_exception_sjlj): Change "exception" to const reference.
5877
5878 2019-04-25  Tom Tromey  <tromey@adacore.com>
5879
5880         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5881         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5882         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5883         Update.
5884         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5885         Update.
5886         * mi/mi-interp.c (mi_interp::exec): Update.
5887         * linespec.c (parse_linespec): Update.
5888         * infcall.c (run_inferior_call): Update.
5889         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5890         * guile/scm-symbol.c (gdbscm_lookup_symbol)
5891         (gdbscm_lookup_global_symbol): Update.
5892         * guile/scm-param.c (gdbscm_parameter_value): Update.
5893         * guile/scm-frame.c (gdbscm_frame_read_register)
5894         (gdbscm_frame_read_var): Update.
5895         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5896         * exec.c (try_open_exec_file): Update.
5897         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5898         (gdb_rl_callback_handler): Update.
5899         * common/common-exceptions.h (exception_none): Don't declare.
5900         * common/common-exceptions.c (exception_none): Don't define.
5901         (struct catcher) <exception>: Update.
5902         * cli/cli-interp.c (safe_execute_command): Update.
5903         * breakpoint.c (insert_bp_location, location_to_sals): Update.
5904
5905 2019-04-25  Ali Tamur  <tamur@google.com>
5906
5907         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5908         (read_attribute_value): Likewise.
5909         (dwarf2_read_addr_index): Update comment.
5910         (read_str_index): Add DW_FORM_strx.
5911         (dwarf2_string_attr): Likewise.
5912         (dwarf2_const_value_attr): Likewise.
5913         (dump_die_shallow): Likewise.
5914         (dwarf2_fetch_constant_bytes): Likewise.
5915         (skip_form_bytes): Likewise.
5916         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5917
5918 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
5919
5920         PR corefiles/11608
5921         PR corefiles/18187
5922         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5923         OFFSET.  Verify if current mapping contains an ELF header.
5924         (linux_find_memory_regions_full): Adjust call to
5925         dump_mapping_p.
5926
5927 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
5928             Kang Li <kanglictf@gmail.com>
5929
5930         PR gdb/21600
5931
5932         * dwarf2-frame.c (read_initial_length): Be consistent about using
5933         unsigned representation of length.
5934         (decode_frame_entry_1): Likewise.  Check for wraparound of
5935         end pointer as well as buffer overflow.
5936
5937 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
5938
5939         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
5940         "vq".
5941
5942 2019-04-24  Tom Tromey  <tromey@adacore.com>
5943
5944         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
5945
5946 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5947
5948         * s12z-tdep.c (s12z_unwind_pc): Delete.
5949         (s12z_unwind_sp): Delete.
5950         (s12z_gdbarch_init): Don't register deleted functions with
5951         gdbarch.
5952
5953 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * rl78-tdep.c (rl78_unwind_sp): Delete.
5956         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
5957
5958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5959
5960         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
5961         (xstormy16_unwind_pc): Delete.
5962         (xstormy16_dummy_id): Delete.
5963         (xstormy16_gdbarch_init): Don't register deleted functions with
5964         gdbarch.
5965
5966 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5967
5968         * vax-tdep.c (vax_unwind_pc): Delete.
5969         (vax_gdbarch_init): Don't register deleted function with gdbarch.
5970
5971 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5972
5973         * v850-tdep.c (v850_unwind_sp): Delete.
5974         (v850_unwind_pc): Delete.
5975         (v850_dummy_id): Delete.
5976         (v850_gdbarch_init): Don't register deleted functions with
5977         gdbarch.
5978
5979 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5980
5981         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
5982         (tilegx_unwind_pc): Delete.
5983         (tilegx_unwind_dummy_id): Delete.
5984         (tilegx_gdbarch_init): Don't register deleted functions with
5985         gdbarch.
5986
5987 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5988
5989         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
5990         (tic6x_dummy_id): Delete.
5991         (tic6x_gdbarch_init): Don't register deleted functions with
5992         gdbarch.
5993
5994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5995
5996         * sparc-tdep.c (sparc_unwind_pc): Delete.
5997         (sparc32_gdbarch_init): Don't register deleted function with
5998         gdbarch.
5999
6000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6001
6002         * sh-tdep.c (sh_unwind_sp): Delete.
6003         (sh_unwind_pc): Delete.
6004         (sh_dummy_id): Delete.
6005         (sh_gdbarch_init): Don't register deleted functions with
6006         gdbarch.
6007
6008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6009
6010         * score-tdep.c (score_unwind_sp): Delete.
6011         (score_unwind_pc): Delete.
6012         (score_dummy_id): Delete.
6013         (score_gdbarch_init): Don't register deleted functions with
6014         gdbarch.
6015
6016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6017
6018         * rx-tdep.c (rx_unwind_pc): Delete.
6019         (rx_unwind_sp): Delete.
6020         (rx_dummy_id): Delete.
6021         (rx_gdbarch_init): Don't register deleted functions with
6022         gdbarch.  Update comment.
6023
6024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6025
6026         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6027         (rs6000_dummy_id): Delete.
6028         (rs6000_gdbarch_init): Don't register deleted functions with
6029         gdbarch.
6030
6031 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * or1k-tdep.c (or1k_dummy_id): Delete.
6034         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6035
6036 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6037
6038         * nios2-tdep.c (nios2_dummy_id): Delete.
6039         (nios2_unwind_sp): Delete.
6040         (nios2_gdbarch_init): Don't register deleted functions with
6041         gdbarch.
6042
6043 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6044
6045         * nds32-tdep.c (nds32_dummy_id): Delete.
6046         (nds32_unwind_pc): Delete.
6047         (nds32_unwind_sp): Delete.
6048         (nds32_gdbarch_init): Don't register deleted functions with
6049         gdbarch.
6050
6051 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6052
6053         * msp430-tdep.c (msp430_unwind_pc): Delete.
6054         (msp430_unwind_sp): Delete.
6055         (msp430_dummy_id): Delete.
6056         (msp430_gdbarch_init): Don't register deleted functions with
6057         gdbarch.
6058
6059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6060
6061         * moxie-tdep.c (moxie_unwind_sp): Delete.
6062         (moxie_unwind_pc): Delete.
6063         (moxie_dummy_id): Delete.
6064         (moxie_gdbarch_init): Don't register deleted functions with
6065         gdbarch.
6066
6067 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6068
6069         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6070         (mn10300_unwind_pc): Delete.
6071         (mn10300_unwind_sp): Delete.
6072         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6073         mn10300_unwind_sp.
6074         (mn10300_frame_unwind_init): Don't register deleted functions with
6075         gdbarch.
6076
6077 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6078
6079         * mep-tdep.c (mep_unwind_pc): Delete.
6080         (mep_unwind_sp): Delete.
6081         (mep_dummy_id): Delete.
6082         (mep_gdbarch_init): Don't register deleted functions with
6083         gdbarch.
6084
6085 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6088         (m68hc11_unwind_sp): Delete.
6089         (m68hc11_gdbarch_init): Don't register deleted functions with
6090         gdbarch.
6091
6092 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6093
6094         * m32r-tdep.c (m32r_unwind_sp): Delete.
6095         (m32r_unwind_pc): Delete.
6096         (m32r_dummy_id): Delete.
6097         (m32r_gdbarch_init): Don't register deleted functions with
6098         gdbarch.
6099
6100 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6101
6102         * m32c-tdep.c (m32c_unwind_pc): Delete.
6103         (m32c_unwind_sp): Delete.
6104         (m32c_dummy_id): Delete.
6105         (m32c_gdbarch_init): Don't register deleted functions with
6106         gdbarch.
6107
6108 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6109
6110         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6111         (lm32_unwind_pc): Delete.
6112         (lm32_dummy_id): Delete.
6113         (lm32_gdbarch_init): Don't register deleted functions with
6114         gdbarch.
6115
6116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6117
6118         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6119         (iq2000_unwind_pc): Delete.
6120         (iq2000_dummy_id): Delete.
6121         (iq2000_gdbarch_init): Don't register deleted functions with
6122         gdbarch.
6123
6124 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6125
6126         * nds32-tdep.c (nds32_type_align): Delete.
6127         (nds32_push_dummy_call): Use type_align instead.
6128
6129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6130
6131         * arm-tdep.c (arm_type_align): Only handle vector override case.
6132         (arm_push_dummy_call): Use type_align.
6133         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6134
6135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6136
6137         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6138         case.
6139         (pass_on_stack): Use type_align.
6140         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6141         function.
6142
6143 2019-04-23  Tom Tromey  <tromey@adacore.com>
6144
6145         * dwarf2read.c (line_header::file_name_at): Remove unused
6146         overload.
6147
6148 2019-04-23  Tom de Vries  <tdevries@suse.de>
6149
6150         PR gdb/24438
6151         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6152         invocation.
6153
6154
6155 2019-03-27  Ali Tamur  <tamur@google.com>
6156
6157         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6158         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6159         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6160         (dwarf_expr_context::get_addr_index): Likewise
6161         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6162         (symbol_needs_eval_context::get_addr_index): Likewise
6163         (disassemble_dwarf_expression): Add DW_OP_addrx
6164         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6165         (read_cutu_die_from_dwo): Update comment
6166         (skip_one_die): Add DW_FORM_addrx
6167         (read_attribute_value): Likewise
6168         (var_decode_location): Add DW_OP_addrx
6169         (dwarf2_const_value_attr): Add DW_FORM_addrx
6170         (dump_die_shallow): Likewise
6171         (dwarf2_fetch_constant_bytes): Likewise
6172         (decode_locdesc): Add DW_OP_addrx
6173         (skip_form_bytes): Add DW_FORM_addrx
6174
6175 2019-04-22  Ali Tamur  <tamur@google.com>
6176
6177         * MAINTAINERS (Write After Approval): Add self.
6178
6179 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6180
6181         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6182         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6183         (open_symbol_file_object): Likewise.
6184         (svr4_default_sos): Add info parameter.
6185         (svr4_read_so_list): Likewise.
6186         (svr4_current_sos_direct): Adjust functions calls to pass down
6187         info.
6188         (svr4_current_sos_1): Add info parameter.
6189         (svr4_current_sos): Call get_svr4_info, pass info down to
6190         svr4_current_sos_1.
6191         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6192         get_svr4_info.
6193         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6194         get_svr4_info.
6195         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6196         to get_svr4_info.
6197         (probes_table_remove_objfile_probes): Likewise.
6198         (register_solib_event_probe): Add info parameter.
6199         (solist_update_incremental): Pass info parameter down to
6200         svr4_read_so_list.
6201         (disable_probes_interface): Add info parameter.
6202         (svr4_handle_solib_event): Pass current_program_space to
6203         get_svr4_info.  Adjust disable_probes_interface cleanup.
6204         (svr4_create_probe_breakpoints): Add info parameter, pass it
6205         down to register_solib_event_probe.
6206         (svr4_create_solib_event_breakpoints): Add info parameter,
6207         pass it down to svr4_create_probe_breakpoints.
6208         (enable_break): Pass info down to
6209         svr4_create_solib_event_breakpoints.
6210         (svr4_solib_create_inferior_hook): Pass current_program_space to
6211         get_svr4_info.
6212         (svr4_clear_solib): Likewise.
6213
6214 2019-04-22  Pedro Alves  <palves@redhat.com>
6215
6216         * solib-svr4.c (svr4_free_objfile_observer): New.
6217         (probe_and_action::objfile): New field.
6218         (probes_table_htab_remove_objfile_probes)
6219         (probes_table_remove_objfile_probes): New functions.
6220         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6221         in the new probe_and_action.  Don't store the probe in 'lookup'.
6222         (svr4_create_probe_breakpoints): Pass objfile to
6223         register_solib_event_probe.
6224         (_initialize_svr4_solib): Register a free_objfile observer.
6225
6226 2019-04-19  Tom Tromey  <tom@tromey.com>
6227
6228         * common/queue.h: Remove.
6229
6230 2019-04-19  Tom Tromey  <tom@tromey.com>
6231
6232         * event-loop.c: Don't include "common/queue.h".
6233
6234 2019-04-19  Tom Tromey  <tom@tromey.com>
6235
6236         * remote.c (remote_target): Use delete.
6237         * remote-notif.h: Include <list>, not "common/queue.h".
6238         (notif_client_p): Remove typedef.
6239         (remote_notif_state): Add constructor, destructor, initializer.
6240         <notif_queue>: Now a std::list.
6241         (remote_notif_state_xfree): Don't declare.
6242         * remote-notif.c (remote_notif_process, handle_notification)
6243         (remote_notif_state_allocate): Update.
6244         (~remote_notif_state): Rename from remote_notif_state_xfree.
6245
6246 2019-04-19  Tom Tromey  <tom@tromey.com>
6247
6248         * symfile.c (reread_symbols): Update.
6249         * objfiles.c (objfile_register_static_link)
6250         (objfile_lookup_static_link): Update
6251         (~objfile) Don't delete static_links.
6252         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6253
6254 2019-04-19  Tom Tromey  <tom@tromey.com>
6255
6256         * type-stack.h (struct type_stack) <insert>: Constify string.
6257         * type-stack.c (type_stack::insert): Constify string.
6258         * gdbtypes.h (lookup_template_type): Update.
6259         (address_space_name_to_int): Update.
6260         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6261         const.
6262         (lookup_template_type): Make name const.
6263         * c-exp.y: Update rules.
6264         (lex_one_token, classify_name, classify_inner_name)
6265         (c_print_token): Update.
6266         * p-exp.y: Update rules.
6267         (yylex): Update.
6268         * f-exp.y: Update rules.
6269         (yylex): Update.
6270         * d-exp.y: Update rules.
6271         (lex_one_token, classify_name, classify_inner_name): Update.
6272         * parse.c (write_dollar_variable, copy_name): Return std::string.
6273         * parser-defs.h (copy_name): Change return type.
6274         * m2-exp.y: Update rules.
6275         (yylex): Update.
6276         * go-exp.y (lex_one_token): Update.
6277         Update rules.
6278         (classify_unsafe_function, classify_packaged_name)
6279         (classify_name, yylex): Update.
6280
6281 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6282
6283         * configure.ac: add --enable-source-highlight switch.
6284         * configure: Regenerate.
6285         * top.c (print_gdb_version): plumb --enable-source-highlight
6286         status to "show configuration".
6287
6288 2019-04-19  Tom Tromey  <tromey@adacore.com>
6289
6290         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6291         Check ADA_TYPE_P.
6292         (empty_record, ada_template_to_fixed_record_type_1)
6293         (template_to_static_fixed_type)
6294         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6295         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6296         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6297         macros.
6298
6299 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6300
6301         PR symtab/24423:
6302         * source.c (print_source_lines_base): Advance "iter" when a
6303         control character is seen.
6304
6305 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6306
6307         * inferior.h (struct infcall_suspend_state_deleter):
6308         Catch exception in destructor to avoid crash.
6309
6310 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6311
6312         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6313         close to the add_com "shell".
6314
6315 2019-04-18  Tom Tromey  <tromey@adacore.com>
6316
6317         * process-stratum-target.h (class process_stratum_target)
6318         <stratum>: Add "final".
6319
6320 2019-04-17  Tom Tromey  <tromey@adacore.com>
6321
6322         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6323         against nullptr before use.
6324
6325 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6326
6327         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6328
6329 2019-04-17  Jim Wilson  <jimw@sifive.com>
6330             Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6333         code read might fail, assume 4-byte breakpoint in that case.
6334
6335 2019-04-15  Leszek Swirski  <leszeks@google.com>
6336
6337         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6338         rather than a hand-rolled POD check when checking for forced MEMORY
6339         classification.
6340
6341 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6342
6343         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6344         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6345         function.
6346         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6347         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6348         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6349         declaration.
6350
6351 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6352
6353         * aarch64-linux-nat.c
6354         (aarch64_linux_nat_target::thread_architecture): Add override.
6355         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6356         each VQ.
6357
6358 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6359
6360         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6361
6362 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6363
6364         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6365         target types of size 96-bits, add some additional comments, and
6366         check that the builtin type we found was the correct size.
6367
6368 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6369
6370         * utils.c (prompt_for_continue): Don't restore the styling at the
6371         end, as applied_style has the wrong value.  This fixes styling in
6372         long lists of file names that are interrupted by the "Continue?"
6373         prompt.
6374
6375 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6376
6377         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6378         * c-lang.c (c_language_defn): Likewise.
6379         (cplus_language_defn): Likewise.
6380         (asm_language_defn): Likewise.
6381         (minimal_language_defn): Likewise.
6382         * d-lang.c (d_language_defn): Likewise.
6383         * f-lang.c (f_language_defn): Likewise.
6384         * go-lang.c (go_language_defn): Likewise.
6385         * language.c (unknown_language_defn): Likewise.
6386         (auto_language_defn): Likewise.
6387         * language.h (struct language_defn): Remove la_magic field.
6388         (LANG_MAGIC): Delete.
6389         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6390         * objc-lang.c (objc_language_defn): Likewise.
6391         * opencl-lang.c (opencl_language_defn): Likewise.
6392         * p-lang.c (pascal_language_defn): Likewise.
6393         * rust-lang.c (rust_language_defn): Likewise.
6394
6395 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6396
6397         * riscv-tdep.c (riscv_type_align): New function.
6398         (riscv_type_alignment): Delete.
6399         (riscv_arg_location): Use 'type_align'.
6400         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6401
6402 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6403
6404         * gdbtypes.c (type_align): A struct with no non-static fields also
6405         has alignment of 1.
6406
6407 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6408
6409         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6410         component to 0.
6411         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6412         member.
6413         (riscv_struct_info::analyse): New implementation using new
6414         analyse_inner member function.
6415         (riscv_struct_info::field_offset): New member function.
6416         (riscv_struct_info::m_offsets): New member variable.
6417         (riscv_struct_info::analyse_inner): New private member function,
6418         takes the old implementation of riscv_struct_info::analyse but
6419         extended to track field offsets.
6420         (riscv_call_arg_struct): Update the struct folding special cases
6421         to handle cases where empty C++ structs, which are non-zero
6422         length, are found.
6423         (riscv_arg_location): Initialise the length of each location, a
6424         non-zero length now indicates the location is in use.
6425         (riscv_push_dummy_call): Allow for the first location having a
6426         non-zero offset when setting up arguments.
6427         (riscv_return_value): Likewise, but for return values.
6428
6429 2019-04-11  Tom Tromey  <tromey@adacore.com>
6430
6431         * utils.c (internal_vproblem): Make "msg" const.
6432
6433 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6434
6435         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6436         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6437         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6438         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6439
6440 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6441
6442         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6443         function.
6444         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6445         of amd64_collect_native_gregset.
6446         (amd64_linux_nat_target::store_registers): Likewise.
6447
6448 2019-04-10  Tom Tromey  <tom@tromey.com>
6449
6450         * symtab.c (lookup_global_symbol_from_objfile)
6451         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6452         * objfiles.h (class separate_debug_iterator): New.
6453         (class separate_debug_range): New.
6454         (struct objfile) <separate_debug_objfiles>: New method.
6455         (objfile_separate_debug_iterate): Don't declare.
6456         * objfiles.c (separate_debug_iterator::operator++): Rename from
6457         objfile_separate_debug_iterate.
6458         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6459         iterator.
6460         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6461         iterator.
6462
6463 2019-04-10  Tom Tromey  <tom@tromey.com>
6464
6465         * symfile.c (reread_symbols): Remove old comment.
6466         * objfiles.c (free_all_objfiles): Fix a typo.
6467
6468 2019-04-10  Tom Tromey  <tom@tromey.com>
6469
6470         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6471         * minsyms.c (lookup_minimal_symbol): Use foreach.
6472         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6473         (lookup_minimal_symbol_solib_trampoline): Likewise.
6474         * symfile.c (reread_symbols): Use foreach.
6475
6476 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6477             Tom Tromey  <tromey@adacore.com>
6478
6479         PR rust/24414:
6480         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6481         (rust_lex_int_test): Change "value" to be LONGEST.
6482         (rust_lex_tests): Add test for long integer literal.
6483
6484 2019-04-09  Tom Tromey  <tromey@adacore.com>
6485
6486         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6487         to bool.
6488         (extended_remote_target::attach): Update.
6489         (remote_target::remote_notice_new_inferior): Update.
6490         (remote_target::add_current_inferior_and_thread): Update.
6491         * inferior.c (exit_inferior_1): Use "false".
6492         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6493
6494 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6495
6496         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6497         the "start" command.
6498
6499 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6500
6501         * python/py-inferior.c (infpy_thread_from_thread_handle):
6502         Adjust comments to reflect renaming of thread_from_thread_handle
6503         to thread_from_handle.  Adjust keywords.  Fix type error message.
6504         (inferior_object_methods): Add thread_from_handle.  Retain
6505         thread_from_thread_handle, but mark it as deprecated.
6506
6507 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6508
6509         * gdbthread.h (find_thread_by_handle): Revise declaration.
6510         * thread.c (find_thread_by_handle): Likewise.  Adjust
6511         implementation too.
6512         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6513         support for buffer objects as handles.
6514
6515 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6516
6517         * python/py-infthread.c (thpy_thread_handle): New function.
6518         (thread_object_methods): Register thpy_thread_handle.
6519
6520 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6521
6522         * gdbthread.h (thread_to_thread_handle): Declare.
6523         * thread.c (gdbtypes.h): Include.
6524         (thread_to_thread_handle): New function.
6525
6526         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6527         (target_thread_info_to_thread_handle): Declare.
6528         * target.c (target_thread_info_to_thread_handle): New function.
6529         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6530         * target-delegates.c: Regenerate.
6531
6532         * linux-thread-db.c (class thread_db_target): Add method
6533         thread_info_to_thread_handle.
6534         (thread_db_target::thread_info_to_thread_handle): Define.
6535         * remote.c (class remote_target): Add new method
6536         thread_info_to_thread_handle.
6537         (remote_target::thread_info_to_thread_handle): Define.
6538
6539 2019-04-08  Pedro Alves  <palves@redhat.com>
6540
6541         * common/common-exceptions.c (throw_exception): Don't create
6542         named object to throw; throw directly.
6543         (throw_it): Likewise.  Don't initialize gdb_exception::message
6544         here, with new; pass FMT and AP to the ctor instead.
6545         * common/common-exceptions.h: Include <string>.
6546         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6547         const char *, va_list)): New ctor.  Use std::make_shared.
6548         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6549         errors)): Delete.
6550         (gdb_exception_error::gdb_exception_error(enum errors, const char
6551         *, va_list)): New.
6552         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6553         Add assertion.
6554         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6555         errors)): Delete.
6556         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6557         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6558         Add assertion.
6559
6560 2019-04-08  Tom Tromey  <tom@tromey.com>
6561
6562         * valops.c (value_rtti_indirect_type): Replace throw_exception
6563         with throw.
6564         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6565         with throw.
6566         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6567         throw.
6568         * target.c (target_translate_tls_address): Replace throw_exception
6569         with throw.
6570         * stack.c (frame_apply_command_count): Replace throw_exception
6571         with throw.
6572         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6573         throw.
6574         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6575         with throw.
6576         * rs6000-tdep.c (rs6000_frame_cache)
6577         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6578         * remote.c: Replace throw_exception with throw.
6579         * record-full.c (record_full_message, record_full_wait_1)
6580         (record_full_restore): Replace throw_exception with throw.
6581         * record-btrace.c:
6582         (get_thread_current_frame_id, record_btrace_start_replaying)
6583         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6584         (cmd_record_btrace_start): Replace throw_exception with throw.
6585         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6586         throw.
6587         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6588         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6589         * linespec.c:
6590         (find_linespec_symbols): Replace throw_exception with throw.
6591         * infrun.c (displaced_step_prepare, resume): Replace
6592         throw_exception with throw.
6593         * infcmd.c (post_create_inferior): Replace throw_exception with
6594         throw.
6595         * inf-loop.c (inferior_event_handler): Replace throw_exception
6596         with throw.
6597         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6598         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6599         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6600         (get_prev_frame_always, get_frame_pc_if_available)
6601         (get_frame_address_in_block_if_available, get_frame_language):
6602         Replace throw_exception with throw.
6603         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6604         throw_exception with throw.
6605         * eval.c (fetch_subexp_value, evaluate_var_value)
6606         (evaluate_funcall, evaluate_subexp_standard): Replace
6607         throw_exception with throw.
6608         * dwarf2loc.c (call_site_find_chain)
6609         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6610         Replace throw_exception with throw.
6611         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6612         with throw.
6613         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6614         throw.
6615         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6616         * completer.c (complete_line_internal): Replace throw_exception
6617         with throw.
6618         * compile/compile-object-run.c (compile_object_run): Replace
6619         throw_exception with throw.
6620         * cli/cli-script.c (process_next_line): Replace throw_exception
6621         with throw.
6622         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6623         (btrace_enable, btrace_maint_update_pt_packets): Replace
6624         throw_exception with throw.
6625         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6626         throw_exception with throw.
6627         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6628         throw_exception with throw.
6629         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6630         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6631         * aarch64-tdep.c (aarch64_make_prologue_cache)
6632         (aarch64_make_stub_cache): Replace throw_exception with throw.
6633
6634 2019-04-08  Tom Tromey  <tom@tromey.com>
6635
6636         * common/common-exceptions.c (throw_exception): Rename from
6637         throw_exception_cxx.  Remove old copy.  Make argument const.
6638         (throw_it): Create and throw exception objects directly.
6639         * common/common-exceptions.h (throw_exception): Make argument
6640         const.
6641         (struct gdb_exception_error): Add constructor.
6642         (struct gdb_exception_quit): Add constructor.
6643
6644 2019-04-08  Tom Tromey  <tom@tromey.com>
6645
6646         * common/common-exceptions.h (exception_rethrow): Don't declare.
6647         (TRY_SJLJ): Update comment.
6648         (TRY, CATCH, END_CATCH): Remove.
6649         * common/common-exceptions.c (exception_rethrow): Remove.
6650
6651 2019-04-08  Tom Tromey  <tom@tromey.com>
6652
6653         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6654         Remove.
6655         (gdb_exception_error): Rename from
6656         gdb_exception_RETURN_MASK_ERROR.
6657         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6658         (gdb_quit_bad_alloc): Update.
6659         * aarch64-tdep.c: Update.
6660         * ada-lang.c: Update.
6661         * ada-typeprint.c: Update.
6662         * ada-valprint.c: Update.
6663         * amd64-tdep.c: Update.
6664         * arch-utils.c: Update.
6665         * break-catch-throw.c: Update.
6666         * breakpoint.c: Update.
6667         * btrace.c: Update.
6668         * c-varobj.c: Update.
6669         * cli/cli-cmds.c: Update.
6670         * cli/cli-interp.c: Update.
6671         * cli/cli-script.c: Update.
6672         * common/common-exceptions.c: Update.
6673         * common/new-op.c: Update.
6674         * common/selftest.c: Update.
6675         * compile/compile-c-symbols.c: Update.
6676         * compile/compile-cplus-symbols.c: Update.
6677         * compile/compile-object-load.c: Update.
6678         * compile/compile-object-run.c: Update.
6679         * completer.c: Update.
6680         * corelow.c: Update.
6681         * cp-abi.c: Update.
6682         * cp-support.c: Update.
6683         * cp-valprint.c: Update.
6684         * darwin-nat.c: Update.
6685         * disasm-selftests.c: Update.
6686         * dtrace-probe.c: Update.
6687         * dwarf-index-cache.c: Update.
6688         * dwarf-index-write.c: Update.
6689         * dwarf2-frame-tailcall.c: Update.
6690         * dwarf2-frame.c: Update.
6691         * dwarf2loc.c: Update.
6692         * dwarf2read.c: Update.
6693         * eval.c: Update.
6694         * event-loop.c: Update.
6695         * event-top.c: Update.
6696         * exec.c: Update.
6697         * f-valprint.c: Update.
6698         * fbsd-tdep.c: Update.
6699         * frame-unwind.c: Update.
6700         * frame.c: Update.
6701         * gdbtypes.c: Update.
6702         * gnu-v3-abi.c: Update.
6703         * guile/guile-internal.h: Update.
6704         * guile/scm-block.c: Update.
6705         * guile/scm-breakpoint.c: Update.
6706         * guile/scm-cmd.c: Update.
6707         * guile/scm-disasm.c: Update.
6708         * guile/scm-frame.c: Update.
6709         * guile/scm-lazy-string.c: Update.
6710         * guile/scm-math.c: Update.
6711         * guile/scm-param.c: Update.
6712         * guile/scm-ports.c: Update.
6713         * guile/scm-pretty-print.c: Update.
6714         * guile/scm-symbol.c: Update.
6715         * guile/scm-symtab.c: Update.
6716         * guile/scm-type.c: Update.
6717         * guile/scm-value.c: Update.
6718         * i386-linux-tdep.c: Update.
6719         * i386-tdep.c: Update.
6720         * inf-loop.c: Update.
6721         * infcall.c: Update.
6722         * infcmd.c: Update.
6723         * infrun.c: Update.
6724         * jit.c: Update.
6725         * language.c: Update.
6726         * linespec.c: Update.
6727         * linux-fork.c: Update.
6728         * linux-nat.c: Update.
6729         * linux-tdep.c: Update.
6730         * linux-thread-db.c: Update.
6731         * main.c: Update.
6732         * mi/mi-cmd-break.c: Update.
6733         * mi/mi-cmd-stack.c: Update.
6734         * mi/mi-interp.c: Update.
6735         * mi/mi-main.c: Update.
6736         * objc-lang.c: Update.
6737         * p-valprint.c: Update.
6738         * parse.c: Update.
6739         * ppc-linux-tdep.c: Update.
6740         * printcmd.c: Update.
6741         * python/py-arch.c: Update.
6742         * python/py-breakpoint.c: Update.
6743         * python/py-cmd.c: Update.
6744         * python/py-finishbreakpoint.c: Update.
6745         * python/py-frame.c: Update.
6746         * python/py-framefilter.c: Update.
6747         * python/py-gdb-readline.c: Update.
6748         * python/py-inferior.c: Update.
6749         * python/py-infthread.c: Update.
6750         * python/py-lazy-string.c: Update.
6751         * python/py-linetable.c: Update.
6752         * python/py-objfile.c: Update.
6753         * python/py-param.c: Update.
6754         * python/py-prettyprint.c: Update.
6755         * python/py-progspace.c: Update.
6756         * python/py-record-btrace.c: Update.
6757         * python/py-record.c: Update.
6758         * python/py-symbol.c: Update.
6759         * python/py-type.c: Update.
6760         * python/py-unwind.c: Update.
6761         * python/py-utils.c: Update.
6762         * python/py-value.c: Update.
6763         * python/python.c: Update.
6764         * record-btrace.c: Update.
6765         * record-full.c: Update.
6766         * remote-fileio.c: Update.
6767         * remote.c: Update.
6768         * riscv-tdep.c: Update.
6769         * rs6000-aix-tdep.c: Update.
6770         * rs6000-tdep.c: Update.
6771         * rust-exp.y: Update.
6772         * rust-lang.c: Update.
6773         * s390-tdep.c: Update.
6774         * selftest-arch.c: Update.
6775         * solib-dsbt.c: Update.
6776         * solib-frv.c: Update.
6777         * solib-spu.c: Update.
6778         * solib-svr4.c: Update.
6779         * solib.c: Update.
6780         * sparc64-linux-tdep.c: Update.
6781         * stack.c: Update.
6782         * symfile-mem.c: Update.
6783         * symmisc.c: Update.
6784         * target.c: Update.
6785         * thread.c: Update.
6786         * top.c: Update.
6787         * tracefile-tfile.c: Update.
6788         * tui/tui.c: Update.
6789         * typeprint.c: Update.
6790         * unittests/cli-utils-selftests.c: Update.
6791         * unittests/parse-connection-spec-selftests.c: Update.
6792         * valops.c: Update.
6793         * valprint.c: Update.
6794         * value.c: Update.
6795         * varobj.c: Update.
6796         * windows-nat.c: Update.
6797         * x86-linux-nat.c: Update.
6798         * xml-support.c: Update.
6799
6800 2019-04-08  Tom Tromey  <tom@tromey.com>
6801
6802         * xml-support.c: Use C++ exception handling.
6803         * x86-linux-nat.c: Use C++ exception handling.
6804         * windows-nat.c: Use C++ exception handling.
6805         * varobj.c: Use C++ exception handling.
6806         * value.c: Use C++ exception handling.
6807         * valprint.c: Use C++ exception handling.
6808         * valops.c: Use C++ exception handling.
6809         * unittests/parse-connection-spec-selftests.c: Use C++ exception
6810         handling.
6811         * unittests/cli-utils-selftests.c: Use C++ exception handling.
6812         * typeprint.c: Use C++ exception handling.
6813         * tui/tui.c: Use C++ exception handling.
6814         * tracefile-tfile.c: Use C++ exception handling.
6815         * top.c: Use C++ exception handling.
6816         * thread.c: Use C++ exception handling.
6817         * target.c: Use C++ exception handling.
6818         * symmisc.c: Use C++ exception handling.
6819         * symfile-mem.c: Use C++ exception handling.
6820         * stack.c: Use C++ exception handling.
6821         * sparc64-linux-tdep.c: Use C++ exception handling.
6822         * solib.c: Use C++ exception handling.
6823         * solib-svr4.c: Use C++ exception handling.
6824         * solib-spu.c: Use C++ exception handling.
6825         * solib-frv.c: Use C++ exception handling.
6826         * solib-dsbt.c: Use C++ exception handling.
6827         * selftest-arch.c: Use C++ exception handling.
6828         * s390-tdep.c: Use C++ exception handling.
6829         * rust-lang.c: Use C++ exception handling.
6830         * rust-exp.y: Use C++ exception handling.
6831         * rs6000-tdep.c: Use C++ exception handling.
6832         * rs6000-aix-tdep.c: Use C++ exception handling.
6833         * riscv-tdep.c: Use C++ exception handling.
6834         * remote.c: Use C++ exception handling.
6835         * remote-fileio.c: Use C++ exception handling.
6836         * record-full.c: Use C++ exception handling.
6837         * record-btrace.c: Use C++ exception handling.
6838         * python/python.c: Use C++ exception handling.
6839         * python/py-value.c: Use C++ exception handling.
6840         * python/py-utils.c: Use C++ exception handling.
6841         * python/py-unwind.c: Use C++ exception handling.
6842         * python/py-type.c: Use C++ exception handling.
6843         * python/py-symbol.c: Use C++ exception handling.
6844         * python/py-record.c: Use C++ exception handling.
6845         * python/py-record-btrace.c: Use C++ exception handling.
6846         * python/py-progspace.c: Use C++ exception handling.
6847         * python/py-prettyprint.c: Use C++ exception handling.
6848         * python/py-param.c: Use C++ exception handling.
6849         * python/py-objfile.c: Use C++ exception handling.
6850         * python/py-linetable.c: Use C++ exception handling.
6851         * python/py-lazy-string.c: Use C++ exception handling.
6852         * python/py-infthread.c: Use C++ exception handling.
6853         * python/py-inferior.c: Use C++ exception handling.
6854         * python/py-gdb-readline.c: Use C++ exception handling.
6855         * python/py-framefilter.c: Use C++ exception handling.
6856         * python/py-frame.c: Use C++ exception handling.
6857         * python/py-finishbreakpoint.c: Use C++ exception handling.
6858         * python/py-cmd.c: Use C++ exception handling.
6859         * python/py-breakpoint.c: Use C++ exception handling.
6860         * python/py-arch.c: Use C++ exception handling.
6861         * printcmd.c: Use C++ exception handling.
6862         * ppc-linux-tdep.c: Use C++ exception handling.
6863         * parse.c: Use C++ exception handling.
6864         * p-valprint.c: Use C++ exception handling.
6865         * objc-lang.c: Use C++ exception handling.
6866         * mi/mi-main.c: Use C++ exception handling.
6867         * mi/mi-interp.c: Use C++ exception handling.
6868         * mi/mi-cmd-stack.c: Use C++ exception handling.
6869         * mi/mi-cmd-break.c: Use C++ exception handling.
6870         * main.c: Use C++ exception handling.
6871         * linux-thread-db.c: Use C++ exception handling.
6872         * linux-tdep.c: Use C++ exception handling.
6873         * linux-nat.c: Use C++ exception handling.
6874         * linux-fork.c: Use C++ exception handling.
6875         * linespec.c: Use C++ exception handling.
6876         * language.c: Use C++ exception handling.
6877         * jit.c: Use C++ exception handling.
6878         * infrun.c: Use C++ exception handling.
6879         * infcmd.c: Use C++ exception handling.
6880         * infcall.c: Use C++ exception handling.
6881         * inf-loop.c: Use C++ exception handling.
6882         * i386-tdep.c: Use C++ exception handling.
6883         * i386-linux-tdep.c: Use C++ exception handling.
6884         * guile/scm-value.c: Use C++ exception handling.
6885         * guile/scm-type.c: Use C++ exception handling.
6886         * guile/scm-symtab.c: Use C++ exception handling.
6887         * guile/scm-symbol.c: Use C++ exception handling.
6888         * guile/scm-pretty-print.c: Use C++ exception handling.
6889         * guile/scm-ports.c: Use C++ exception handling.
6890         * guile/scm-param.c: Use C++ exception handling.
6891         * guile/scm-math.c: Use C++ exception handling.
6892         * guile/scm-lazy-string.c: Use C++ exception handling.
6893         * guile/scm-frame.c: Use C++ exception handling.
6894         * guile/scm-disasm.c: Use C++ exception handling.
6895         * guile/scm-cmd.c: Use C++ exception handling.
6896         * guile/scm-breakpoint.c: Use C++ exception handling.
6897         * guile/scm-block.c: Use C++ exception handling.
6898         * guile/guile-internal.h: Use C++ exception handling.
6899         * gnu-v3-abi.c: Use C++ exception handling.
6900         * gdbtypes.c: Use C++ exception handling.
6901         * frame.c: Use C++ exception handling.
6902         * frame-unwind.c: Use C++ exception handling.
6903         * fbsd-tdep.c: Use C++ exception handling.
6904         * f-valprint.c: Use C++ exception handling.
6905         * exec.c: Use C++ exception handling.
6906         * event-top.c: Use C++ exception handling.
6907         * event-loop.c: Use C++ exception handling.
6908         * eval.c: Use C++ exception handling.
6909         * dwarf2read.c: Use C++ exception handling.
6910         * dwarf2loc.c: Use C++ exception handling.
6911         * dwarf2-frame.c: Use C++ exception handling.
6912         * dwarf2-frame-tailcall.c: Use C++ exception handling.
6913         * dwarf-index-write.c: Use C++ exception handling.
6914         * dwarf-index-cache.c: Use C++ exception handling.
6915         * dtrace-probe.c: Use C++ exception handling.
6916         * disasm-selftests.c: Use C++ exception handling.
6917         * darwin-nat.c: Use C++ exception handling.
6918         * cp-valprint.c: Use C++ exception handling.
6919         * cp-support.c: Use C++ exception handling.
6920         * cp-abi.c: Use C++ exception handling.
6921         * corelow.c: Use C++ exception handling.
6922         * completer.c: Use C++ exception handling.
6923         * compile/compile-object-run.c: Use C++ exception handling.
6924         * compile/compile-object-load.c: Use C++ exception handling.
6925         * compile/compile-cplus-symbols.c: Use C++ exception handling.
6926         * compile/compile-c-symbols.c: Use C++ exception handling.
6927         * common/selftest.c: Use C++ exception handling.
6928         * common/new-op.c: Use C++ exception handling.
6929         * cli/cli-script.c: Use C++ exception handling.
6930         * cli/cli-interp.c: Use C++ exception handling.
6931         * cli/cli-cmds.c: Use C++ exception handling.
6932         * c-varobj.c: Use C++ exception handling.
6933         * btrace.c: Use C++ exception handling.
6934         * breakpoint.c: Use C++ exception handling.
6935         * break-catch-throw.c: Use C++ exception handling.
6936         * arch-utils.c: Use C++ exception handling.
6937         * amd64-tdep.c: Use C++ exception handling.
6938         * ada-valprint.c: Use C++ exception handling.
6939         * ada-typeprint.c: Use C++ exception handling.
6940         * ada-lang.c: Use C++ exception handling.
6941         * aarch64-tdep.c: Use C++ exception handling.
6942
6943 2019-04-08  Tom Tromey  <tom@tromey.com>
6944
6945         * xml-support.c (gdb_xml_parser::parse): Update.
6946         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6947         * value.c (show_convenience): Update.
6948         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
6949         (test_parse_flags_qcs): Update.
6950         * thread.c (thr_try_catch_cmd): Update.
6951         * target.c (target_translate_tls_address): Update.
6952         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6953         (info_frame_command_core, frame_apply_command_count): Update.
6954         * rust-exp.y (rust_lex_exception_test): Update.
6955         * riscv-tdep.c (riscv_print_one_register_info): Update.
6956         * remote.c (remote_target::enable_btrace): Update.
6957         * record-btrace.c (record_btrace_enable_warn): Update.
6958         * python/py-utils.c (gdbpy_convert_exception): Update.
6959         * printcmd.c (do_one_display, print_variable_and_value): Update.
6960         * mi/mi-main.c (mi_print_exception): Update.
6961         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
6962         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6963         * linux-nat.c (linux_nat_target::attach): Update.
6964         * linux-fork.c (class scoped_switch_fork_info): Update.
6965         * infrun.c (displaced_step_prepare): Update.
6966         * infcall.c (call_function_by_hand_dummy): Update.
6967         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
6968         * gnu-v3-abi.c (print_one_vtable): Update.
6969         * frame.c (get_prev_frame_always): Update.
6970         * f-valprint.c (info_common_command_for_block): Update.
6971         * exec.c (try_open_exec_file): Update.
6972         * exceptions.c (print_exception, exception_print)
6973         (exception_fprintf, exception_print_same): Update.
6974         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
6975         * dwarf-index-cache.c (index_cache::store)
6976         (index_cache::lookup_gdb_index): Update.
6977         * darwin-nat.c (maybe_cache_shell): Update.
6978         * cp-valprint.c (cp_print_value_fields): Update.
6979         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
6980         (gcc_cplus_symbol_address): Update.
6981         * compile/compile-c-symbols.c (gcc_convert_symbol)
6982         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
6983         * common/selftest.c: Update.
6984         * common/common-exceptions.h (struct gdb_exception) <message>: Now
6985         a std::string.
6986         (exception_try_scope_entry, exception_try_scope_exit): Don't
6987         declare.
6988         (struct exception_try_scope): Remove.
6989         (TRY): Don't use exception_try_scope.
6990         (struct gdb_exception): Add constructor, operator=.
6991         <what>: New method.
6992         (struct gdb_exception_RETURN_MASK_ALL)
6993         (struct gdb_exception_RETURN_MASK_ERROR)
6994         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
6995         (struct gdb_quit_bad_alloc): Update.
6996         * common/common-exceptions.c (exception_none): Change
6997         initializer.
6998         (struct catcher) <state, exception>: Initialize inline.
6999         <prev>: Remove member.
7000         (current_catcher): Remove.
7001         (catchers): New global.
7002         (exceptions_state_mc_init): Simplify.
7003         (catcher_pop): Remove.
7004         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7005         (try_scope_depth, exception_try_scope_entry)
7006         (exception_try_scope_exit): Remove.
7007         (throw_exception_sjlj): Update.
7008         (exception_messages, exception_messages_size): Remove.
7009         (throw_it): Simplify.
7010         (gdb_exception_sliced_copy): Remove.
7011         (throw_exception_cxx): Update.
7012         * cli/cli-script.c (script_from_file): Update.
7013         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7014         Update.
7015         * ada-valprint.c (ada_val_print): Update.
7016         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7017         (create_excep_cond_exprs): Update.
7018
7019 2019-04-08  Tom Tromey  <tom@tromey.com>
7020
7021         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7022         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7023         (TRY, CATCH, END_CATCH): Remove some definitions.
7024         * common/common-exceptions.c: Don't use GDB_XCPT.
7025         (catcher_list_size): Remove.
7026         (throw_exception, throw_it): Simplify.
7027
7028 2019-04-05  Tom Tromey  <tom@tromey.com>
7029
7030         Revert the header-sorting patch.
7031         * ft32-tdep.c: Revert.
7032         * frv-tdep.c: Revert.
7033         * frv-linux-tdep.c: Revert.
7034         * frame.c: Revert.
7035         * frame-unwind.c: Revert.
7036         * frame-base.c: Revert.
7037         * fork-child.c: Revert.
7038         * findvar.c: Revert.
7039         * findcmd.c: Revert.
7040         * filesystem.c: Revert.
7041         * filename-seen-cache.h: Revert.
7042         * filename-seen-cache.c: Revert.
7043         * fbsd-tdep.c: Revert.
7044         * fbsd-nat.h: Revert.
7045         * fbsd-nat.c: Revert.
7046         * f-valprint.c: Revert.
7047         * f-typeprint.c: Revert.
7048         * f-lang.c: Revert.
7049         * extension.h: Revert.
7050         * extension.c: Revert.
7051         * extension-priv.h: Revert.
7052         * expprint.c: Revert.
7053         * exec.h: Revert.
7054         * exec.c: Revert.
7055         * exceptions.c: Revert.
7056         * event-top.c: Revert.
7057         * event-loop.c: Revert.
7058         * eval.c: Revert.
7059         * elfread.c: Revert.
7060         * dwarf2read.h: Revert.
7061         * dwarf2read.c: Revert.
7062         * dwarf2loc.c: Revert.
7063         * dwarf2expr.h: Revert.
7064         * dwarf2expr.c: Revert.
7065         * dwarf2-frame.c: Revert.
7066         * dwarf2-frame-tailcall.c: Revert.
7067         * dwarf-index-write.h: Revert.
7068         * dwarf-index-write.c: Revert.
7069         * dwarf-index-common.c: Revert.
7070         * dwarf-index-cache.h: Revert.
7071         * dwarf-index-cache.c: Revert.
7072         * dummy-frame.c: Revert.
7073         * dtrace-probe.c: Revert.
7074         * disasm.h: Revert.
7075         * disasm.c: Revert.
7076         * disasm-selftests.c: Revert.
7077         * dictionary.c: Revert.
7078         * dicos-tdep.c: Revert.
7079         * demangle.c: Revert.
7080         * dcache.h: Revert.
7081         * dcache.c: Revert.
7082         * darwin-nat.h: Revert.
7083         * darwin-nat.c: Revert.
7084         * darwin-nat-info.c: Revert.
7085         * d-valprint.c: Revert.
7086         * d-namespace.c: Revert.
7087         * d-lang.c: Revert.
7088         * ctf.c: Revert.
7089         * csky-tdep.c: Revert.
7090         * csky-linux-tdep.c: Revert.
7091         * cris-tdep.c: Revert.
7092         * cris-linux-tdep.c: Revert.
7093         * cp-valprint.c: Revert.
7094         * cp-support.c: Revert.
7095         * cp-namespace.c: Revert.
7096         * cp-abi.c: Revert.
7097         * corelow.c: Revert.
7098         * corefile.c: Revert.
7099         * continuations.c: Revert.
7100         * completer.h: Revert.
7101         * completer.c: Revert.
7102         * complaints.c: Revert.
7103         * coffread.c: Revert.
7104         * coff-pe-read.c: Revert.
7105         * cli-out.h: Revert.
7106         * cli-out.c: Revert.
7107         * charset.c: Revert.
7108         * c-varobj.c: Revert.
7109         * c-valprint.c: Revert.
7110         * c-typeprint.c: Revert.
7111         * c-lang.c: Revert.
7112         * buildsym.c: Revert.
7113         * buildsym-legacy.c: Revert.
7114         * build-id.h: Revert.
7115         * build-id.c: Revert.
7116         * btrace.c: Revert.
7117         * bsd-uthread.c: Revert.
7118         * breakpoint.h: Revert.
7119         * breakpoint.c: Revert.
7120         * break-catch-throw.c: Revert.
7121         * break-catch-syscall.c: Revert.
7122         * break-catch-sig.c: Revert.
7123         * blockframe.c: Revert.
7124         * block.c: Revert.
7125         * bfin-tdep.c: Revert.
7126         * bfin-linux-tdep.c: Revert.
7127         * bfd-target.c: Revert.
7128         * bcache.c: Revert.
7129         * ax-general.c: Revert.
7130         * ax-gdb.h: Revert.
7131         * ax-gdb.c: Revert.
7132         * avr-tdep.c: Revert.
7133         * auxv.c: Revert.
7134         * auto-load.c: Revert.
7135         * arm-wince-tdep.c: Revert.
7136         * arm-tdep.c: Revert.
7137         * arm-symbian-tdep.c: Revert.
7138         * arm-pikeos-tdep.c: Revert.
7139         * arm-obsd-tdep.c: Revert.
7140         * arm-nbsd-tdep.c: Revert.
7141         * arm-nbsd-nat.c: Revert.
7142         * arm-linux-tdep.c: Revert.
7143         * arm-linux-nat.c: Revert.
7144         * arm-fbsd-tdep.c: Revert.
7145         * arm-fbsd-nat.c: Revert.
7146         * arm-bsd-tdep.c: Revert.
7147         * arch-utils.c: Revert.
7148         * arc-tdep.c: Revert.
7149         * arc-newlib-tdep.c: Revert.
7150         * annotate.h: Revert.
7151         * annotate.c: Revert.
7152         * amd64-windows-tdep.c: Revert.
7153         * amd64-windows-nat.c: Revert.
7154         * amd64-tdep.c: Revert.
7155         * amd64-sol2-tdep.c: Revert.
7156         * amd64-obsd-tdep.c: Revert.
7157         * amd64-obsd-nat.c: Revert.
7158         * amd64-nbsd-tdep.c: Revert.
7159         * amd64-nbsd-nat.c: Revert.
7160         * amd64-nat.c: Revert.
7161         * amd64-linux-tdep.c: Revert.
7162         * amd64-linux-nat.c: Revert.
7163         * amd64-fbsd-tdep.c: Revert.
7164         * amd64-fbsd-nat.c: Revert.
7165         * amd64-dicos-tdep.c: Revert.
7166         * amd64-darwin-tdep.c: Revert.
7167         * amd64-bsd-nat.c: Revert.
7168         * alpha-tdep.c: Revert.
7169         * alpha-obsd-tdep.c: Revert.
7170         * alpha-nbsd-tdep.c: Revert.
7171         * alpha-mdebug-tdep.c: Revert.
7172         * alpha-linux-tdep.c: Revert.
7173         * alpha-linux-nat.c: Revert.
7174         * alpha-bsd-tdep.c: Revert.
7175         * alpha-bsd-nat.c: Revert.
7176         * aix-thread.c: Revert.
7177         * agent.c: Revert.
7178         * addrmap.c: Revert.
7179         * ada-varobj.c: Revert.
7180         * ada-valprint.c: Revert.
7181         * ada-typeprint.c: Revert.
7182         * ada-tasks.c: Revert.
7183         * ada-lang.c: Revert.
7184         * aarch64-tdep.c: Revert.
7185         * aarch64-ravenscar-thread.c: Revert.
7186         * aarch64-newlib-tdep.c: Revert.
7187         * aarch64-linux-tdep.c: Revert.
7188         * aarch64-linux-nat.c: Revert.
7189         * aarch64-fbsd-tdep.c: Revert.
7190         * aarch64-fbsd-nat.c: Revert.
7191         * aarch32-linux-nat.c: Revert.
7192
7193 2019-04-05  Tom Tromey  <tom@tromey.com>
7194
7195         * ft32-tdep.c: Sort headers.
7196         * frv-tdep.c: Sort headers.
7197         * frv-linux-tdep.c: Sort headers.
7198         * frame.c: Sort headers.
7199         * frame-unwind.c: Sort headers.
7200         * frame-base.c: Sort headers.
7201         * fork-child.c: Sort headers.
7202         * findvar.c: Sort headers.
7203         * findcmd.c: Sort headers.
7204         * filesystem.c: Sort headers.
7205         * filename-seen-cache.h: Sort headers.
7206         * filename-seen-cache.c: Sort headers.
7207         * fbsd-tdep.c: Sort headers.
7208         * fbsd-nat.h: Sort headers.
7209         * fbsd-nat.c: Sort headers.
7210         * f-valprint.c: Sort headers.
7211         * f-typeprint.c: Sort headers.
7212         * f-lang.c: Sort headers.
7213         * extension.h: Sort headers.
7214         * extension.c: Sort headers.
7215         * extension-priv.h: Sort headers.
7216         * expprint.c: Sort headers.
7217         * exec.h: Sort headers.
7218         * exec.c: Sort headers.
7219         * exceptions.c: Sort headers.
7220         * event-top.c: Sort headers.
7221         * event-loop.c: Sort headers.
7222         * eval.c: Sort headers.
7223         * elfread.c: Sort headers.
7224         * dwarf2read.h: Sort headers.
7225         * dwarf2read.c: Sort headers.
7226         * dwarf2loc.c: Sort headers.
7227         * dwarf2expr.h: Sort headers.
7228         * dwarf2expr.c: Sort headers.
7229         * dwarf2-frame.c: Sort headers.
7230         * dwarf2-frame-tailcall.c: Sort headers.
7231         * dwarf-index-write.h: Sort headers.
7232         * dwarf-index-write.c: Sort headers.
7233         * dwarf-index-common.c: Sort headers.
7234         * dwarf-index-cache.h: Sort headers.
7235         * dwarf-index-cache.c: Sort headers.
7236         * dummy-frame.c: Sort headers.
7237         * dtrace-probe.c: Sort headers.
7238         * disasm.h: Sort headers.
7239         * disasm.c: Sort headers.
7240         * disasm-selftests.c: Sort headers.
7241         * dictionary.c: Sort headers.
7242         * dicos-tdep.c: Sort headers.
7243         * demangle.c: Sort headers.
7244         * dcache.h: Sort headers.
7245         * dcache.c: Sort headers.
7246         * darwin-nat.h: Sort headers.
7247         * darwin-nat.c: Sort headers.
7248         * darwin-nat-info.c: Sort headers.
7249         * d-valprint.c: Sort headers.
7250         * d-namespace.c: Sort headers.
7251         * d-lang.c: Sort headers.
7252         * ctf.c: Sort headers.
7253         * csky-tdep.c: Sort headers.
7254         * csky-linux-tdep.c: Sort headers.
7255         * cris-tdep.c: Sort headers.
7256         * cris-linux-tdep.c: Sort headers.
7257         * cp-valprint.c: Sort headers.
7258         * cp-support.c: Sort headers.
7259         * cp-namespace.c: Sort headers.
7260         * cp-abi.c: Sort headers.
7261         * corelow.c: Sort headers.
7262         * corefile.c: Sort headers.
7263         * continuations.c: Sort headers.
7264         * completer.h: Sort headers.
7265         * completer.c: Sort headers.
7266         * complaints.c: Sort headers.
7267         * coffread.c: Sort headers.
7268         * coff-pe-read.c: Sort headers.
7269         * cli-out.h: Sort headers.
7270         * cli-out.c: Sort headers.
7271         * charset.c: Sort headers.
7272         * c-varobj.c: Sort headers.
7273         * c-valprint.c: Sort headers.
7274         * c-typeprint.c: Sort headers.
7275         * c-lang.c: Sort headers.
7276         * buildsym.c: Sort headers.
7277         * buildsym-legacy.c: Sort headers.
7278         * build-id.h: Sort headers.
7279         * build-id.c: Sort headers.
7280         * btrace.c: Sort headers.
7281         * bsd-uthread.c: Sort headers.
7282         * breakpoint.h: Sort headers.
7283         * breakpoint.c: Sort headers.
7284         * break-catch-throw.c: Sort headers.
7285         * break-catch-syscall.c: Sort headers.
7286         * break-catch-sig.c: Sort headers.
7287         * blockframe.c: Sort headers.
7288         * block.c: Sort headers.
7289         * bfin-tdep.c: Sort headers.
7290         * bfin-linux-tdep.c: Sort headers.
7291         * bfd-target.c: Sort headers.
7292         * bcache.c: Sort headers.
7293         * ax-general.c: Sort headers.
7294         * ax-gdb.h: Sort headers.
7295         * ax-gdb.c: Sort headers.
7296         * avr-tdep.c: Sort headers.
7297         * auxv.c: Sort headers.
7298         * auto-load.c: Sort headers.
7299         * arm-wince-tdep.c: Sort headers.
7300         * arm-tdep.c: Sort headers.
7301         * arm-symbian-tdep.c: Sort headers.
7302         * arm-pikeos-tdep.c: Sort headers.
7303         * arm-obsd-tdep.c: Sort headers.
7304         * arm-nbsd-tdep.c: Sort headers.
7305         * arm-nbsd-nat.c: Sort headers.
7306         * arm-linux-tdep.c: Sort headers.
7307         * arm-linux-nat.c: Sort headers.
7308         * arm-fbsd-tdep.c: Sort headers.
7309         * arm-fbsd-nat.c: Sort headers.
7310         * arm-bsd-tdep.c: Sort headers.
7311         * arch-utils.c: Sort headers.
7312         * arc-tdep.c: Sort headers.
7313         * arc-newlib-tdep.c: Sort headers.
7314         * annotate.h: Sort headers.
7315         * annotate.c: Sort headers.
7316         * amd64-windows-tdep.c: Sort headers.
7317         * amd64-windows-nat.c: Sort headers.
7318         * amd64-tdep.c: Sort headers.
7319         * amd64-sol2-tdep.c: Sort headers.
7320         * amd64-obsd-tdep.c: Sort headers.
7321         * amd64-obsd-nat.c: Sort headers.
7322         * amd64-nbsd-tdep.c: Sort headers.
7323         * amd64-nbsd-nat.c: Sort headers.
7324         * amd64-nat.c: Sort headers.
7325         * amd64-linux-tdep.c: Sort headers.
7326         * amd64-linux-nat.c: Sort headers.
7327         * amd64-fbsd-tdep.c: Sort headers.
7328         * amd64-fbsd-nat.c: Sort headers.
7329         * amd64-dicos-tdep.c: Sort headers.
7330         * amd64-darwin-tdep.c: Sort headers.
7331         * amd64-bsd-nat.c: Sort headers.
7332         * alpha-tdep.c: Sort headers.
7333         * alpha-obsd-tdep.c: Sort headers.
7334         * alpha-nbsd-tdep.c: Sort headers.
7335         * alpha-mdebug-tdep.c: Sort headers.
7336         * alpha-linux-tdep.c: Sort headers.
7337         * alpha-linux-nat.c: Sort headers.
7338         * alpha-bsd-tdep.c: Sort headers.
7339         * alpha-bsd-nat.c: Sort headers.
7340         * aix-thread.c: Sort headers.
7341         * agent.c: Sort headers.
7342         * addrmap.c: Sort headers.
7343         * ada-varobj.c: Sort headers.
7344         * ada-valprint.c: Sort headers.
7345         * ada-typeprint.c: Sort headers.
7346         * ada-tasks.c: Sort headers.
7347         * ada-lang.c: Sort headers.
7348         * aarch64-tdep.c: Sort headers.
7349         * aarch64-ravenscar-thread.c: Sort headers.
7350         * aarch64-newlib-tdep.c: Sort headers.
7351         * aarch64-linux-tdep.c: Sort headers.
7352         * aarch64-linux-nat.c: Sort headers.
7353         * aarch64-fbsd-tdep.c: Sort headers.
7354         * aarch64-fbsd-nat.c: Sort headers.
7355         * aarch32-linux-nat.c: Sort headers.
7356
7357 2019-04-04  Tom Tromey  <tom@tromey.com>
7358
7359         * varobj.c (varobj_create): Update.
7360         * rust-exp.y (struct rust_parser) <update_innermost_block,
7361         lookup_symbol>: New methods.
7362         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7363         Rename.
7364         (rust_parser::rust_lookup_type)
7365         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7366         * printcmd.c (display_command, do_one_display): Update.
7367         * parser-defs.h (struct parser_state) <parser_state>: Add
7368         "tracker" parameter.
7369         (block_tracker): New member.
7370         (class innermost_block_tracker) <innermost_block_tracker>: Add
7371         "types" parameter.
7372         <reset>: Remove method.
7373         (innermost_block): Don't declare.
7374         (null_post_parser): Update.
7375         * parse.c (innermost_block): Remove global.
7376         (write_dollar_variable): Update.
7377         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7378         Remove "tracker_types" parameter.
7379         (parse_expression): Add "tracker" parameter.
7380         (parse_expression_for_completion): Update.
7381         (null_post_parser): Add "tracker" parameter.
7382         * p-exp.y: Update rules.
7383         * m2-exp.y: Update rules.
7384         * language.h (struct language_defn) <la_post_parser>: Add
7385         "tracker" parameter.
7386         * go-exp.y: Update rules.
7387         * f-exp.y: Update rules.
7388         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7389         parameter.
7390         * d-exp.y: Update rules.
7391         * c-exp.y: Update rules.
7392         * breakpoint.c (set_breakpoint_condition): Create an
7393         innermost_block_tracker.
7394         (watch_command_1): Likewise.
7395         * ada-lang.c (resolve): Add "tracker" parameter.
7396         (resolve_subexp): Likewise.
7397         * ada-exp.y (write_var_from_sym): Update.
7398
7399 2019-04-04  Tom Tromey  <tom@tromey.com>
7400
7401         * type-stack.h: New file.
7402         * type-stack.c: New file.
7403         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7404         type-stack.h.
7405         (insert_into_type_stack, insert_type, push_type, push_type_int)
7406         (insert_type_address_space, pop_type, pop_type_int)
7407         (pop_typelist, pop_type_stack, append_type_stack)
7408         (push_type_stack, get_type_stack, push_typelist)
7409         (follow_type_instance_flags, follow_types): Don't declare.
7410         * parse.c (type_stack): Remove global.
7411         (parse_exp_in_context): Update.
7412         (insert_into_type_stack, insert_type, push_type, push_type_int)
7413         (insert_type_address_space, pop_type, pop_type_int)
7414         (pop_typelist, pop_type_stack, append_type_stack)
7415         (push_type_stack, get_type_stack, push_typelist)
7416         (follow_type_instance_flags, follow_types): Remove (moved to
7417         type-stack.c).
7418         * f-exp.y (type_stack): New global.
7419         Update rules.
7420         (push_kind_type, f_parse): Update.
7421         * d-exp.y (type_stack): New global.
7422         Update rules.
7423         (d_parse): Update.
7424         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7425         Update rules.
7426         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7427         (HFILES_NO_SRCDIR): Add type-stack.h.
7428
7429 2019-04-04  Tom Tromey  <tom@tromey.com>
7430
7431         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7432         (rust_parser::convert_ast_to_expression, rust_parse)
7433         (rust_lex_test_completion, rust_lex_tests): Update.
7434         * parser-defs.h (struct expr_completion_state): New.
7435         (struct parser_state) <parser_state>: Add completion parameter.
7436         <mark_struct_expression, mark_completion_tag>: New methods.
7437         <parse_completion, m_completion_state>: New members.
7438         (prefixify_expression, null_post_parser): Update.
7439         (mark_struct_expression, mark_completion_tag): Don't declare.
7440         * parse.c (parse_completion, expout_last_struct)
7441         (expout_tag_completion_type, expout_completion_name): Remove
7442         globals.
7443         (parser_state::mark_struct_expression)
7444         (parser_state::mark_completion_tag): Now methods.
7445         (prefixify_expression): Add last_struct parameter.
7446         (prefixify_subexp): Likewise.
7447         (parse_exp_1): Update.
7448         (parse_exp_in_context): Add cstate parameter.  Update.
7449         (parse_expression_for_completion): Create an
7450         expr_completion_state.
7451         (null_post_parser): Add "completion" parameter.
7452         * p-exp.y: Update rules.
7453         (yylex): Update.
7454         * language.h (struct language_defn) <la_post_parser>: Add
7455         "completing" parameter.
7456         * go-exp.y: Update rules.
7457         (lex_one_token): Update.
7458         * expression.h (parse_completion): Don't declare.
7459         * d-exp.y: Update rules.
7460         (lex_one_token): Update rules.
7461         * c-exp.y: Update rules.
7462         (lex_one_token): Update.
7463         * ada-lang.c (resolve): Add "parse_completion" parameter.
7464         (resolve_subexp): Likewise.
7465         (ada_resolve_function): Likewise.
7466
7467 2019-04-04  Tom Tromey  <tom@tromey.com>
7468
7469         * parser-defs.h (struct parser_state) <start_arglist,
7470         end_arglist>: New methods.
7471         <arglist_len, m_funcall_chain>: New members.
7472         (arglist_len, start_arglist, end_arglist): Don't declare.
7473         * parse.c (arglist_len, funcall_chain): Remove global.
7474         (start_arglist, end_arglist): Remove functions.
7475         (parse_exp_in_context): Update.
7476         * p-exp.y: Update rules.
7477         * m2-exp.y: Update rules.
7478         * go-exp.y: Update rules.
7479         * f-exp.y: Update rules.
7480         * d-exp.y: Update rules.
7481         * c-exp.y: Update rules.
7482
7483 2019-04-04  Tom Tromey  <tom@tromey.com>
7484
7485         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7486         lex_operator, push_back>: New methods.
7487         Update all rules.
7488         (rust_parser::lex_hex, lex_escape): Rename and update.
7489         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7490         (rust_parser::lex_operator): Rename and update.
7491         (rust_parser::lex_number, rustyylex, rustyyerror)
7492         (rust_lex_test_init, rust_lex_test_sequence)
7493         (rust_lex_test_push_back, rust_lex_tests): Update.
7494         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7495         parameter.
7496         <lexptr, prev_lexptr>: New members.
7497         (lexptr, prev_lexptr): Don't declare.
7498         * parse.c (lexptr, prev_lexptr): Remove globals.
7499         (parse_exp_in_context): Update.
7500         * p-exp.y (yylex, yyerror): Update.
7501         * m2-exp.y (parse_number, yylex, yyerror): Update.
7502         * go-exp.y (lex_one_token, yyerror): Update.
7503         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7504         * d-exp.y (lex_one_token, yyerror): Update.
7505         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7506         (lex_one_token, yyerror): Update.
7507         * ada-lex.l (YY_INPUT): Update.
7508         (rewind_to_char): Update.
7509         * ada-exp.y (yyerror): Update.
7510
7511 2019-04-04  Tom Tromey  <tom@tromey.com>
7512
7513         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7514         * parser-defs.h (struct parser_state) <parser_state>: Add new
7515         parameter.
7516         <comma_terminates>: New member.
7517         (comma_terminates): Don't declare global.
7518         * parse.c (comma_terminates): Remove global.
7519         (parse_exp_in_context): Update.
7520         * p-exp.y (yylex): Update.
7521         * m2-exp.y (yylex): Update.
7522         * go-exp.y (lex_one_token): Update.
7523         * f-exp.y (yylex): Update.
7524         * d-exp.y (lex_one_token): Update.
7525         * c-exp.y (lex_one_token): Update.
7526         * ada-lex.l: Update.
7527
7528 2019-04-04  Tom Tromey  <tom@tromey.com>
7529
7530         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7531         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7532         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7533         * parser-defs.h (paren_depth): Don't declare.
7534         * parse.c (paren_depth): Remove global.
7535         (parse_exp_in_context): Update.
7536         * p-exp.y (paren_depth): New global.
7537         (pascal_parse): Initialize it.
7538         * m2-exp.y (paren_depth): New global.
7539         (m2_parse): Initialize it.
7540         * go-exp.y (paren_depth): New global.
7541         (go_parse): Initialize it.
7542         * f-exp.y (paren_depth): New global.
7543         (f_parse): Initialize it.
7544         * d-exp.y (paren_depth): New global.
7545         (d_parse): Initialize it.
7546         * c-exp.y (paren_depth): New global.
7547         (c_parse): Initialize it.
7548         * ada-lex.l (paren_depth): New global.
7549         (lexer_init): Initialize it.
7550
7551 2019-04-04  Tom Tromey  <tom@tromey.com>
7552
7553         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7554         (rust_parser::convert_ast_to_type)
7555         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7556         * parser-defs.h (struct parser_state) <parser_state>: Add
7557         parameters.  Initialize new members.
7558         <expression_context_block, expression_context_pc>: New members.
7559         * parse.c (expression_context_block, expression_context_pc):
7560         Remove globals.
7561         (parse_exp_in_context): Update.
7562         * p-exp.y: Update all rules.
7563         (yylex): Update.
7564         * m2-exp.y: Update all rules.
7565         (yylex): Update.
7566         * go-exp.y (yylex): Update.
7567         * f-exp.y (yylex): Update.
7568         * d-exp.y: Update all rules.
7569         (yylex): Update.
7570         * c-exp.y: Update all rules.
7571         (lex_one_token, classify_name, yylex, c_parse): Update.
7572         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7573
7574 2019-04-04  Tom Tromey  <tom@tromey.com>
7575
7576         * gdbarch.h, gdbarch.c: Rebuild.
7577         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7578         * stap-probe.h:
7579         (struct stap_parse_info): Replace "parser_state" with
7580         "expr_builder".
7581         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7582         (parser_state): New class.
7583         * parse.c (expr_builder): Rename.
7584         (expr_builder::release): Rename.
7585         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7586         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7587         (write_exp_elt_longcst, write_exp_elt_floatcst)
7588         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7589         (write_exp_string_vector, write_exp_bitstring)
7590         (write_exp_msymbol, mark_struct_expression)
7591         (write_dollar_variable)
7592         (insert_type_address_space, increase_expout_size): Replace
7593         "parser_state" with "expr_builder".
7594         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7595         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7596         "parser_state" with "expr_builder".
7597
7598 2019-04-04  Tom Tromey  <tom@tromey.com>
7599
7600         * rust-exp.y: Replace "parse_language" with method call.
7601         * p-exp.y:
7602         (yylex): Replace "parse_language" with method call.
7603         * m2-exp.y:
7604         (yylex): Replace "parse_language" with method call.
7605         * go-exp.y (classify_name): Replace "parse_language" with method
7606         call.
7607         * f-exp.y (yylex): Replace "parse_language" with method call.
7608         * d-exp.y (lex_one_token): Replace "parse_language" with method
7609         call.
7610         * c-exp.y:
7611         (lex_one_token, classify_name, yylex): Replace "parse_language"
7612         with method call.
7613         * ada-exp.y (find_primitive_type, type_char)
7614         (type_system_address): Replace "parse_language" with method call.
7615
7616 2019-04-04  Tom Tromey  <tom@tromey.com>
7617
7618         * rust-exp.y: Replace "parse_gdbarch" with method call.
7619         * parse.c (write_dollar_variable, insert_type_address_space):
7620         Replace "parse_gdbarch" with method call.
7621         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7622         call.
7623         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7624         call.
7625         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7626         "parse_gdbarch" with method call.
7627         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7628         with method call.
7629         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7630         "parse_gdbarch" with method call.
7631         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7632         "parse_gdbarch" with method call.
7633         * c-exp.y (parse_type, parse_number, classify_name): Replace
7634         "parse_gdbarch" with method call.
7635         * ada-lex.l: Replace "parse_gdbarch" with method call.
7636         * ada-exp.y (parse_type, find_primitive_type, type_char)
7637         (type_system_address): Replace "parse_gdbarch" with method call.
7638
7639 2019-04-04  Tom Tromey  <tom@tromey.com>
7640
7641         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7642         * stap-probe.c (stap_parse_argument): Update.
7643         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7644         initial_size parameter.
7645         * rust-exp.y (rust_lex_tests): Update.
7646         * parse.c (parser_state): Update.
7647         (parse_exp_in_context): Update.
7648         * parser-defs.h (struct parser_state) <parser_state>: Remove
7649         "initial_size" parameter.
7650
7651 2019-04-04  Tom Tromey  <tom@tromey.com>
7652
7653         * parser-defs.h (increase_expout_size): Don't declare.
7654         * parse.c (increase_expout_size): Now static.
7655
7656 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7657
7658         * gnu-nat.c (gnu_nat_target::wait): Fix
7659         target_waitstatus_to_string call.
7660
7661 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7662
7663         * eval.c (evaluate_subexp_standard): Handle internal functions
7664         during Fortran function call handling.
7665
7666 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7667
7668         * NEWS: Mention new internal functions.
7669         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7670         (read_base_type): Use dwarf2_init_complex_target_type.
7671         * value.c (creal_internal_fn): New function.
7672         (cimag_internal_fn): New function.
7673         (_initialize_values): Register new internal functions.
7674
7675 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7676
7677         * infrun.c (stop_all_threads): If debug_infrun, always
7678         trace the wait status after wait_one, using
7679         target_waitstatus_to_string and target_pid_to_str.
7680         (handle_inferior_event): Replace various trace of
7681         wait status kind by a single trace.
7682         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7683         wait status kind image by target_waitstatus_to_string.
7684         * target/waitstatus.c (target_waitstatus_to_string): Fix
7685         obsolete comment.
7686
7687 2019-04-01  Tom Tromey  <tromey@adacore.com>
7688
7689         PR symtab/23331:
7690         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7691
7692 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7693             Pedro Alves  <palves@redhat.com>
7694
7695         * top.c (quit_force): Call 'finalize_values'.
7696         * value.c (finalize_values): New function.
7697         * value.h (finalize_values): Declare.
7698
7699 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7700
7701         * NEWS: Announce $_gdb_major and $_gdb_minor.
7702
7703         * top.c (init_gdb_version_vars): New function.
7704         (gdb_init): Call init_gdb_version_vars.
7705
7706 2019-03-29  Tom Tromey  <tromey@adacore.com>
7707
7708         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7709         help text.  Remove dead code.
7710
7711 2019-03-29  Keith Seitz  <keiths@redhat.com>
7712
7713         From Siddhesh Poyarekar:
7714         * f-lang.h (f77_get_upperbound): Return LONGEST.
7715         (f77_get_lowerbound): Likewise.
7716         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7717         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7718         print them.
7719         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7720         plongest to format print it.
7721         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7722         (f77_get_upperbound): Likewise.
7723         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7724         LOWER_BOUND to LONGEST.
7725         (f77_create_arrayprint_offset_tbl): Likewise.
7726
7727 2019-03-29  Keith Seitz  <keiths@redhat.com>
7728
7729         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7730         %s/pulongest for TYPE_LENGTH instead of %d in format
7731         strings.
7732         * ada-typerint.c (ada_print_type): Likewise.
7733         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7734         * compile/compile-c-support.c (generate_register_struct): Likewise.
7735         * gdbtypes.c (recursive_dump_type): Likewise.
7736         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7737         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7738         instead of %d in format strings.
7739         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7740         to std::min to ULONGEST.
7741         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7742         instead of %d in format strings.
7743         * tracepoint.c (info_scope_command): Likewise.
7744         * typeprint.c (print_offset_data::update)
7745         (print_offset_data::finish): Likewise.
7746         * xtensa-tdep.c (xtensa_store_return_value)
7747         (xtensa_push_dummy_call): Likewise.
7748
7749 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7750
7751         * windows-nat.c (display_selector): Fixed format specifications
7752         for 64-bit Cygwin.
7753
7754 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7755
7756         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7757
7758 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7759
7760         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7761         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7762         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7763         (nios2_linux_init_abi): Install it.
7764
7765 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7766
7767         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7768
7769 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7770
7771         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7772
7773 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7774             Tom Tromey  <tromey@adacore.com>
7775
7776         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7777
7778 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7779
7780         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7781         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7782         method to compute the bounds of range types. Also print "[evaluated]"
7783         if the bounds' values come from a dynamic evaluation.
7784
7785 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7786
7787         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7788         whitespace when pretty printing is on.
7789
7790 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7791
7792         * ppc-linux-nat.c: Add include.
7793
7794 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7795
7796         * NEWS: Mention AArch64 Pointer Authentication.
7797
7798 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7799
7800         * arm-linux-nat.c: Add include.
7801
7802 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
7803
7804         * source-cache.c (source_cache::get_source_lines): Re-read
7805         fullname after calling open_source_file.
7806
7807 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
7808
7809         * NEWS: Mention TLS support for FreeBSD.
7810
7811 2019-03-25  Tom Tromey  <tromey@adacore.com>
7812
7813         * minsyms.c (BUNCH_SIZE): Update comment.
7814         (~minimal_symbol_reader): Remove old comment.
7815         (compact_minimal_symbols): Update comment.
7816         (minimal_symbol_reader::install): Remove old comment.  Update
7817         other comments.
7818
7819 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7820
7821         * s390-linux-nat.c: Add include.
7822
7823 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
7824
7825         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7826         Call linux_get_hwcap.
7827         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7828         Likewise.
7829         (aarch64_linux_get_hwcap): Remove function.
7830         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7831         declaration.
7832         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7833         linux_get_hwcap.
7834         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7835         * linux-tdep.c (linux_get_hwcap): Add function.
7836         (linux_get_hwcap2): Likewise.
7837         * linux-tdep.h (linux_get_hwcap): Add declaration.
7838         (linux_get_hwcap2): Likewise.
7839         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7840         (ppc_linux_get_hwcap2): Likewise.
7841         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7842         linux_get_hwcap.
7843         (ppc_linux_nat_target::insert_watchpoint): Likewise.
7844         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7845         (ppc_linux_nat_target::read_description): Likewise.
7846         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7847         * s390-linux-nat.c: Likewise.
7848         * s390-linux-tdep.c (s390_core_read_description): Likewise.
7849
7850 2019-03-24  Tom Tromey  <tom@tromey.com>
7851
7852         * ada-lang.c (standard_lookup): Simplify initialization.
7853         (ada_lookup_symbol_nonlocal): Simplify return.
7854         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7855         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7856         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7857         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7858         initialization.
7859         * solib.c (solib_global_lookup): Simplify.
7860         * symtab.c (null_block_symbol): Remove.
7861         (symbol_cache_lookup): Simplify returns.
7862         (lookup_language_this): Simplify returns.
7863         (lookup_symbol_aux): Simplify return.
7864         (lookup_local_symbol): Simplify returns.
7865         (lookup_global_symbol_from_objfile): Simplify return.
7866         (lookup_symbol_in_objfile_symtabs)
7867         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7868         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7869         (lookup_static_symbol, lookup_global_symbol): Simplify return.
7870         * cp-namespace.c (cp_lookup_bare_symbol)
7871         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7872         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7873         (cp_lookup_nested_symbol): Don't use null_block_symbol.
7874         (cp_lookup_symbol_via_imports): Simplify initialization.
7875         (find_symbol_in_baseclass): Likewise.
7876         * symtab.h (null_block_symbol): Remove.
7877         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7878         (d_lookup_nested_symbol, d_lookup_symbol_imports)
7879         (d_lookup_symbol_module): Likewise.
7880         (find_symbol_in_baseclass): Simplify initialization.
7881
7882 2019-03-24  Tom Tromey  <tom@tromey.com>
7883
7884         * expression.h: Don't include symtab.h.
7885         (struct block): Forward declare.
7886
7887 2019-03-24  Tom Tromey  <tom@tromey.com>
7888
7889         * c-exp.y (typebase): Remove casts.
7890         * gdbtypes.c (lookup_unsigned_typename, )
7891         (lookup_signed_typename): Remove cast.
7892         * eval.c (parse_to_comma_and_eval): Remove cast.
7893         * parse.c (write_dollar_variable): Remove cast.
7894         * block.h (struct block) <superblock>: Now const.
7895         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7896         * psymtab.c (psym_map_matching_symbols): Make "block" const.
7897         (map_block): Make "block" const.
7898         * symfile.h (struct quick_symbol_functions)
7899         <map_matching_symbols>: Constify block argument to "callback".
7900         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7901         const.
7902         (find_pc_sect_compunit_symtab): Make "b" const.
7903         (find_symbol_at_address): Likewise.
7904         (search_symbols): Likewise.
7905         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7906         (dw2_debug_names_lookup_symbol): Likewise.
7907         (dw2_map_matching_symbols): Update.
7908         * p-valprint.c (pascal_val_print): Remove "block".
7909         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7910         (aux_add_nonlocal_symbols): Make "block" const.
7911         (resolve_subexp): Remove cast.
7912         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7913         const.
7914         (iterate_over_file_blocks): Likewise.
7915         * f-exp.y (%union) <bval>: Remove.
7916         * coffread.c (patch_opaque_types): Make "b" const.
7917         * spu-tdep.c (spu_catch_start): Make "block" const.
7918         * c-valprint.c (print_unpacked_pointer): Remove "block".
7919         * symmisc.c (dump_symtab_1): Make "b" const.
7920         (block_depth): Make "block" const.
7921         * d-exp.y (%union) <bval>: Remove.
7922         * cp-support.h (cp_lookup_rtti_type): Update.
7923         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7924         * psymtab.c (psym_lookup_symbol): Make "block" const.
7925         (maintenance_check_psymtabs): Make "b" const.
7926         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
7927         (enumerate_locals, enumerate_args): Update.
7928         * python/py-symtab.c (stpy_global_block): Make "block" const.
7929         (stpy_static_block): Likewise.
7930         * inline-frame.c (block_starting_point_at): Make "new_block"
7931         const.
7932         * block.c (find_block_in_blockvector): Make return type const.
7933         (blockvector_for_pc_sect): Make "b" const.
7934         (find_block_in_blockvector): Make "b" const.
7935
7936 2019-03-23  Tom Tromey  <tom@tromey.com>
7937
7938         * varobj.c (varobj_create): Update.
7939         * symfile.c (clear_symtab_users): Don't reset innermost_block.
7940         * printcmd.c (display_command, do_one_display): Don't reset
7941         innermost_block.
7942         * parser-defs.h (enum innermost_block_tracker_type): Move to
7943         expression.h.
7944         (innermost_block): Update comment.
7945         * parse.c (parse_exp_1): Add tracker_types parameter.
7946         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
7947         tracker_types parameter.  Reset innermost_block.
7948         (parse_exp_in_context): Remove.
7949         (parse_expression_for_completion): Update.
7950         * objfiles.c (~objfile): Don't reset expression_context_block or
7951         innermost_block.
7952         * expression.h (enum innermost_block_tracker_type): Move from
7953         parser-defs.h.
7954         (parse_exp_1): Add tracker_types parameter.
7955         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
7956         reset innermost_block.
7957
7958 2019-03-23  Tom Tromey  <tom@tromey.com>
7959
7960         * objfiles.h: Include bcache.h.
7961
7962 2019-03-23  Tom Tromey  <tom@tromey.com>
7963
7964         * linespec.c (get_current_search_block): Use
7965         scoped_restore_current_language.
7966         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
7967
7968 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7969             Jiong Wang  <jiong.wang@arm.com>
7970
7971         * aarch64-linux-tdep.c
7972         (aarch64_linux_iterate_over_regset_sections): Check for pauth
7973         section.
7974         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
7975
7976 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7977             Jiong Wang  <jiong.wang@arm.com>
7978
7979         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
7980         instructions.
7981         (aarch64_analyze_prologue_test): Add PACIASP test.
7982         (aarch64_prologue_prev_register): Unmask PC value.
7983
7984 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7985             Jiong Wang  <jiong.wang@arm.com>
7986
7987         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
7988         (aarch64_dwarf2_prev_register): Unmask PC value.
7989         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
7990         (aarch64_execute_dwarf_cfa_vendor_op): Check for
7991         DW_CFA_AARCH64_negate_ra_state.
7992         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
7993
7994 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
7995             Jiong Wang  <jiong.wang@arm.com>
7996
7997         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
7998         registers.
7999         (aarch64_pseudo_register_name): Likewise.
8000         (aarch64_pseudo_register_type): Likewise.
8001         (aarch64_pseudo_register_reggroup_p): Likewise.
8002         (aarch64_gdbarch_init): Add pauth registers.
8003         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8004         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8005         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8006         (struct gdbarch_tdep): Add regnum for ra_state.
8007
8008 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8009             Jiong Wang  <jiong.wang@arm.com>
8010
8011         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8012
8013 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8014             Jiong Wang  <jiong.wang@arm.com>
8015
8016         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8017         function.
8018         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8019         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8020         (aarch64_gdbarch_init): Add puth registers.
8021         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8022         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8023         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8024
8025 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8026             Jiong Wang  <jiong.wang@arm.com>
8027
8028         * aarch64-linux-nat.c
8029         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8030         * aarch64-linux-tdep.c
8031         (aarch64_linux_core_read_description): Likewise.
8032         (aarch64_linux_get_hwcap): New function.
8033         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8034         (aarch64_linux_get_hwcap): New declaration.
8035
8036 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8037             Jiong Wang  <jiong.wang@arm.com>
8038
8039         * aarch64-linux-nat.c
8040         (aarch64_linux_nat_target::read_description): Add pauth param.
8041         * aarch64-linux-tdep.c
8042         (aarch64_linux_core_read_description): Likewise.
8043         * aarch64-tdep.c (struct target_desc): Add in pauth.
8044         (aarch64_read_description): Add pauth param.
8045         (aarch64_gdbarch_init): Likewise.
8046         * aarch64-tdep.h (aarch64_read_description): Likewise.
8047         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8048         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8049         * features/Makefile: Add new files.
8050         * features/aarch64-pauth.c: New file.
8051         * features/aarch64-pauth.xml: New file.
8052
8053 2019-03-20  Tom Tromey  <tromey@adacore.com>
8054
8055         * infrun.c (handle_inferior_event): Rename from
8056         handle_inferior_event_1.  Create a scoped_value_mark.
8057         (handle_inferior_event): Remove.
8058
8059 2019-03-19  Tom Tromey  <tromey@adacore.com>
8060
8061         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8062         * infrun.h (print_stop_event): Add "displays" parameter.
8063         * infrun.c (print_stop_event): Add "displays" parameter.
8064
8065 2019-03-19  Pedro Alves  <palves@redhat.com>
8066
8067         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8068         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8069         to -1.  Fix TABs vs spaces.
8070         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8071         * tui/tui-out.h (tui_ui_out) Add intro comments.
8072         <m_line, m_start_of_line>: In-class initialize, and add describing
8073         comment.
8074
8075 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8076
8077         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8078         variable names.
8079         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8080
8081 2019-03-18  Pedro Alves  <palves@redhat.com>
8082             Eli Zaretskii <eliz@gnu.org>
8083
8084         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8085         m_line and m_start_of_line.
8086
8087 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8088
8089         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8090         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8091         it returns a newline.  This fixes a regression in TU mode, whereby
8092         the next line is output on the same screen line as the user input.
8093
8094 2019-03-18  Tom Tromey  <tromey@adacore.com>
8095
8096         * minsyms.c (minimal_symbol_reader::install): Remove call to
8097         obstack_blank.
8098
8099 2019-03-18  Pedro Alves  <palves@redhat.com>
8100
8101         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8102         New globals.
8103         (apply_style): New, factored out from ...
8104         (apply_ansi_escape): ... this.  Handle reverse video mode.
8105         (tui_set_reverse_mode): New function.
8106         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8107         * tui/tui-winsource.c (tui_show_source_line): Use
8108         tui_set_reverse_mode instead of setting A_STANDOUT.
8109         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8110         New setter methods.
8111
8112 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8113
8114         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8115         Handle tabs.
8116
8117 2019-03-18  Tom Tromey  <tromey@adacore.com>
8118
8119         * ada-lang.c (empty_array): Add "high" parameter.
8120         (ada_evaluate_subexp): Update.
8121
8122 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8123
8124         * unittests/string_view-selftests.c: Define
8125         _initialize_string_view_selftests unconditionally.
8126
8127 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8128
8129         PR gdb/24350
8130         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8131
8132 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8133
8134         PR gdb/24351
8135         * windows-nat.c (display_selector): Fix format specifiers.
8136
8137 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8138
8139         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8140         tui_refill_source_window instead of tui_refresh_win, to update the
8141         current execution line.  This fixes redisplay of the current line
8142         when stepping through the code with "next" or "step".
8143
8144 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8145
8146         * source-cache.c (source_cache::get_source_lines): Call
8147         find_source_lines to initialize s->nlines.  This fixes vertical
8148         scrolling of TUI source window when the DOWN arrow is pressed.
8149
8150 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8151
8152         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8153         linux-thread-db.c (_initialize_thread_db): Likewise.
8154
8155 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8156
8157         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8158         wclrtoeol in tui_show_source_line".  This reverts changes made in
8159         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8160
8161 2019-03-15  Tom Tromey  <tom@tromey.com>
8162
8163         * symtab.h (struct minimal_symbol): Derive from
8164         general_symbol_info.
8165         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8166         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8167         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8168         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8169         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8170         (MSYMBOL_SEARCH_NAME): Update.
8171         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8172         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8173         * minsyms.c (minimal_symbol_reader::record_full): Update.
8174
8175 2019-03-15  Tom Tromey  <tom@tromey.com>
8176
8177         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8178
8179 2019-03-15  Tom Tromey  <tom@tromey.com>
8180
8181         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8182         unique_xmalloc_ptr.
8183         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8184         Update.
8185         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8186         (build_minimal_symbol_hash_tables)
8187         (minimal_symbol_reader::install): Update.
8188
8189 2019-03-15  Tom Tromey  <tom@tromey.com>
8190
8191         * symtab.c (create_demangled_names_hash): Update.
8192         (symbol_set_names): Update.
8193         * objfiles.h (struct objfile_per_bfd_storage)
8194         <demangled_names_hash>: Now an htab_up.
8195         * objfiles.c (objfile_per_bfd_storage): Simplify.
8196
8197 2019-03-15  Tom Tromey  <tom@tromey.com>
8198
8199         * objfiles.h (struct objfile_per_bfd_storage): Declare
8200         destructor.
8201         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8202         New.
8203         (get_objfile_bfd_data): Use new.  Don't initialize
8204         language_of_main.
8205         (free_objfile_per_bfd_storage): Remove.
8206         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8207
8208 2019-03-15  Tom Tromey  <tom@tromey.com>
8209
8210         * symfile.c (reread_symbols): Update.
8211         * objfiles.c (objfile::objfile): Update.
8212         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8213         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8214         comment.
8215         (minimal_symbol_reader::install): Update.
8216         (terminate_minimal_symbol_table): Remove.
8217         * jit.c (jit_object_close_impl): Update.
8218
8219 2019-03-15  Tom Tromey  <tom@tromey.com>
8220
8221         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8222         initializations.
8223
8224 2019-03-15  Tom Tromey  <tom@tromey.com>
8225
8226         * objfiles.h (struct objfile_per_bfd_storage)
8227         <demangled_hash_languages>: Now a bitset.
8228         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8229         (lookup_minimal_symbol): Update.
8230
8231 2019-03-15  Tom Tromey  <tom@tromey.com>
8232
8233         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8234         Don't return the symbol.
8235         * coffread.c (record_minimal_symbol): Use record_full.
8236
8237 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8238
8239         The MS-Windows port of ncurses fails to switch to a color pair if
8240         one or both of the colors are the implicit default colors.  This
8241         change records the default colors when TUI is initialized, and
8242         then specifies them explicitly when a color pair uses the default
8243         colors.  This allows color styling in TUI mode on MS-Windows.
8244
8245         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8246         ncurses_norm_attr.
8247         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8248         colors in ncurses_norm_attr.
8249         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8250         "none", replace it with the default color recorded in
8251         ncurses_norm_attr.
8252
8253 2019-03-14  Tom Tromey  <tromey@adacore.com>
8254
8255         * source-cache.h (class source_cache) <get_source_lines>: Return
8256         std::string.
8257         * source-cache.c (source_cache::extract_lines): Handle case where
8258         first_pos==npos.  Return std::string.
8259         (source_cache::get_source_lines): Update.
8260
8261 2019-03-14  Tom Tromey  <tromey@adacore.com>
8262
8263         * NEWS: Add item for "style sources" commands.
8264         * source-cache.c (source_cache::get_source_lines): Check
8265         source_styling.
8266         * cli/cli-style.c (source_styling): New global.
8267         (_initialize_cli_style): Add "style sources" commands.
8268         (show_style_sources): New function.
8269         * cli/cli-style.h (source_styling): Declare.
8270
8271 2019-03-14  Pedro Alves  <palves@redhat.com>
8272             Tom Tromey  <tromey@adacore.com>
8273
8274         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8275         * tui/tui-winsource.c (tui_refill_source_window): New function,
8276         from...
8277         (tui_horizontal_source_scroll): ... here.  Move some logic.
8278         * cli/cli-style.c (set_style_enabled): Notify new observable.
8279         * tui/tui-hooks.c (tui_redisplay_source): New function.
8280         (tui_attach_detach_observers): Attach or detach
8281         tui_redisplay_source.
8282         * observable.h (source_styling_changed): New observable.
8283         * observable.c: Define source_styling_changed observable.
8284
8285 2019-03-13  Tom Tromey  <tromey@adacore.com>
8286
8287         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8288         (i386_gnu_nat_target::store_registers): Update.
8289         * target-debug.h (target_debug_print_std_string): New macro.
8290         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8291         * windows-tdep.c (display_one_tib): Update.
8292         * tui/tui-stack.c (tui_make_status_line): Update.
8293         * top.c (print_inferior_quit_action): Update.
8294         * thread.c (thr_try_catch_cmd): Update.
8295         (add_thread_with_info): Update.
8296         (thread_target_id_str): Update.
8297         (thr_try_catch_cmd): Update.
8298         (thread_command): Update.
8299         (thread_find_command): Update.
8300         * record-btrace.c (record_btrace_target::info_record)
8301         (record_btrace_resume_thread, record_btrace_target::resume)
8302         (record_btrace_cancel_resume, record_btrace_step_thread)
8303         (record_btrace_target::wait, record_btrace_target::wait)
8304         (record_btrace_target::wait, record_btrace_target::stop): Update.
8305         * progspace.c (print_program_space): Update.
8306         * process-stratum-target.c
8307         (process_stratum_target::thread_address_space): Update.
8308         * linux-fork.c (linux_fork_mourn_inferior)
8309         (detach_checkpoint_command, info_checkpoints_command)
8310         (linux_fork_context): Update.
8311         (linux_fork_detach): Update.
8312         (class scoped_switch_fork_info): Update.
8313         (delete_checkpoint_command): Update.
8314         * infrun.c (follow_fork_inferior): Update.
8315         (follow_fork_inferior): Update.
8316         (proceed_after_vfork_done): Update.
8317         (handle_vfork_child_exec_or_exit): Update.
8318         (follow_exec): Update.
8319         (displaced_step_prepare_throw): Update.
8320         (displaced_step_restore): Update.
8321         (start_step_over): Update.
8322         (resume_1): Update.
8323         (clear_proceed_status_thread): Update.
8324         (proceed): Update.
8325         (print_target_wait_results): Update.
8326         (do_target_wait): Update.
8327         (context_switch): Update.
8328         (stop_all_threads): Update.
8329         (restart_threads): Update.
8330         (finish_step_over): Update.
8331         (handle_signal_stop): Update.
8332         (switch_back_to_stepped_thread): Update.
8333         (keep_going_pass_signal): Update.
8334         (print_exited_reason): Update.
8335         (normal_stop): Update.
8336         * inferior.c (inferior_pid_to_str): Change return type.
8337         (print_selected_inferior): Update.
8338         (add_inferior): Update.
8339         (detach_inferior): Update.
8340         * dummy-frame.c (fprint_dummy_frames): Update.
8341         * dcache.c (dcache_info_1): Update.
8342         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8343         (btrace_fetch, btrace_clear): Update.
8344         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8345         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8346         type.
8347         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8348         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8349         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8350         * gdbarch.c, gdbarch.h: Rebuild.
8351         * gdbarch.sh (core_pid_to_str): Change return type.
8352         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8353         return type.
8354         (windows_nat_target::pid_to_str): Change return type.
8355         (windows_delete_thread): Update.
8356         (windows_nat_target::attach): Update.
8357         (windows_nat_target::files_info): Update.
8358         * target-delegates.c: Rebuild.
8359         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8360         return type.
8361         (sol_thread_target::pid_to_str): Change return type.
8362         * remote.c (class remote_target) <pid_to_str>: Change return
8363         type.
8364         (remote_target::pid_to_str): Change return type.
8365         (extended_remote_target::attach, remote_target::remote_stop_ns)
8366         (remote_target::remote_notif_remove_queued_reply)
8367         (remote_target::push_stop_reply, remote_target::disable_btrace):
8368         Update.
8369         (extended_remote_target::attach): Update.
8370         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8371         type.
8372         (gdbsim_target::pid_to_str): Change return type.
8373         * ravenscar-thread.c (struct ravenscar_thread_target)
8374         <pid_to_str>: Change return type.
8375         (ravenscar_thread_target::pid_to_str): Change return type.
8376         * procfs.c (class procfs_target) <pid_to_str>: Change return
8377         type.
8378         (procfs_target::pid_to_str): Change return type.
8379         (procfs_target::attach): Update.
8380         (procfs_target::detach): Update.
8381         (procfs_target::fetch_registers): Update.
8382         (procfs_target::store_registers): Update.
8383         (procfs_target::wait): Update.
8384         (procfs_target::files_info): Update.
8385         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8386         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8387         return type.
8388         (nto_procfs_target::pid_to_str): Change return type.
8389         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8390         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8391         return type.
8392         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8393         (exit_lwp): Update.
8394         (attach_proc_task_lwp_callback, get_detach_signal)
8395         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8396         (linux_nat_target::resume, wait_lwp, stop_callback)
8397         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8398         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8399         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8400         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8401         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8402         type.
8403         (inf_ptrace_target::attach): Update.
8404         (inf_ptrace_target::files_info): Update.
8405         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8406         type.
8407         (go32_nat_target::pid_to_str): Change return type.
8408         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8409         (gnu_nat_target::wait): Update.
8410         (gnu_nat_target::wait): Update.
8411         (gnu_nat_target::resume): Update.
8412         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8413         (fbsd_nat_target::wait): Update.
8414         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8415         type.
8416         (darwin_nat_target::attach): Update.
8417         * corelow.c (class core_target) <pid_to_str>: Change return type.
8418         (core_target::pid_to_str): Change return type.
8419         * target.c (normal_pid_to_str): Change return type.
8420         (default_pid_to_str): Likewise.
8421         (target_pid_to_str): Change return type.
8422         (target_translate_tls_address): Update.
8423         (target_announce_detach): Update.
8424         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8425         return type.
8426         (bsd_uthread_target::pid_to_str): Change return type.
8427         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8428         type.
8429         (bsd_kvm_target::pid_to_str): Change return type.
8430         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8431         return type.
8432         (aix_thread_target::pid_to_str): Change return type.
8433         * target.h (struct target_ops) <pid_to_str>: Change return type.
8434         (target_pid_to_str, normal_pid_to_str): Likewise.
8435         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8436         type.
8437         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8438         type.
8439         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8440         return type.
8441         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8442         type.
8443         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8444         type.
8445         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8446         return type.
8447
8448 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8449
8450         * NEWS: Mention that the new default MI version is 3.  Mention
8451         changes to the output of commands and events that deal with
8452         multi-location breakpoints.
8453         * breakpoint.c: Include "mi/mi-out.h".
8454         (print_one_breakpoint): Change output syntax if using MI version
8455         >= 3.
8456         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8457         New.
8458         (mi_multi_location_breakpoint_output_fixed): New.
8459         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8460         (mi_cmd_fix_multi_location_breakpoint_output): New.
8461         (mi_multi_location_breakpoint_output_fixed): New.
8462         * mi/mi-cmds.c (mi_cmds): Register command
8463         -fix-multi-location-breakpoint-output.
8464         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8465         interpreter "mi".
8466
8467 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8468
8469         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8470         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8471         instantiate mi_ui_out based on interpreter name.
8472         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8473         * mi/mi-main.c (mi_load_progress): Likewise.
8474
8475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8476
8477         * NEWS: Combine separate "New targets" sections for 8.3.
8478
8479 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8480
8481         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8482         (ppcfbsd_init_abi): Install gdbarch
8483         "fetch_tls_load_module_address" and "get_thread_local_address"
8484         methods.
8485
8486 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8487
8488         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8489         (riscv_fbsd_init_abi): Install gdbarch
8490         "fetch_tls_load_module_address" and "get_thread_local_address"
8491         methods.
8492
8493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8494
8495         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8496         (i386fbsd_init_abi): Install gdbarch
8497         "fetch_tls_load_module_address" and "get_thread_local_address"
8498         methods.
8499
8500 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8501
8502         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8503         (amd64fbsd_init_abi): Install gdbarch
8504         "fetch_tls_load_module_address" and "get_thread_local_address"
8505         methods.
8506
8507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8508
8509         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8510         (struct fbsd_pspace_data): New type.
8511         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8512         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8513         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8514         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8515         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8516
8517 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8518
8519         * gdbtypes.c (lookup_struct_elt): New function.
8520         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8521         * gdbtypes.h (struct struct_elt): New type.
8522         (lookup_struct_elt): New prototype.
8523
8524 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8525
8526         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8527         remove disabled code block.
8528
8529 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8530
8531         * gdbarch.sh (get_thread_local_address): New method.
8532         * gdbarch.h, gdbarch.c: Regenerate.
8533         * target.c (target_translate_tls_address): Use
8534         gdbarch_get_thread_local_address if present instead of
8535         target::get_thread_local_address.
8536
8537 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8538
8539         * target.h (target::get_thread_local_address): Update comment.
8540
8541 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8542
8543         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8544         objfile->separate_debug_objfile_backlink if not NULL.
8545
8546 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8547
8548         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8549         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8550         (amd64bsd_store_inferior_registers): Likewise.
8551         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8552         Enable segment base registers.
8553         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8554         PT_GETFSBASE and PT_GETGSBASE.
8555         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8556         PT_SETGSBASE.
8557         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8558         segment base registers.
8559         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8560
8561 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8562
8563         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8564         Update calls to i386_target_description to add 'segments'
8565         parameter.
8566         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8567         add segment base registers.
8568         * arch/i386.c (i386_create_target_description): Add 'segments'
8569         parameter to enable segment base registers.
8570         * arch/i386.h (i386_create_target_description): Likewise.
8571         * features/i386/32bit-segments.xml: New file.
8572         * features/i386/32bit-segments.c: Generate.
8573         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8574         call to i386_target_description to add 'segments' parameter.
8575         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8576         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8577         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8578         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8579         if feature is present.
8580         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8581         Add 'segments' parameter to call to i386_target_description.
8582         (i386_target_description): Add 'segments' parameter to enable
8583         segment base registers.
8584         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8585         to call to i386_target_description.
8586         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8587         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8588         Define I386_NUM_REGS.
8589         (i386_target_description): Add 'segments' parameter to enable
8590         segment base registers.
8591
8592 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8593
8594         PR/24325
8595         * source-cache.c: #undef open and close, to avoid unresolved
8596         externals during linking.
8597
8598 2019-03-12  Tom Tromey  <tromey@adacore.com>
8599
8600         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8601         const.  Add initializers.
8602         (_initialize_remote): Don't initialize ptid globals.
8603
8604 2019-03-12  Pedro Alves  <palves@redhat.com>
8605
8606         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8607
8608 2019-03-12  Pedro Alves  <palves@redhat.com>
8609
8610         * cp-name-parser.y (main): Remove unused 'len' variable.
8611
8612 2019-03-12  Tom Tromey  <tromey@adacore.com>
8613
8614         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8615         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8616
8617 2019-03-12  Tom Tromey  <tromey@adacore.com>
8618
8619         * linux-nat.c (iterate_over_lwps): Update.
8620         (stop_callback): Remove parameter.
8621         (stop_wait_callback, detach_callback, resume_set_callback)
8622         (select_singlestep_lwp_callback, set_ignore_sigint)
8623         (status_callback, resumed_callback, resume_clear_callback)
8624         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8625         data parameter.
8626         (linux_nat_target::detach, linux_nat_target::resume)
8627         (linux_stop_and_wait_all_lwps, select_event_lwp)
8628         (linux_nat_filter_event, linux_nat_wait_1)
8629         (linux_nat_target::kill, linux_nat_target::stop)
8630         (linux_nat_target::stop): Update.
8631         (linux_nat_resume_callback): Change type.
8632         (resume_stopped_resumed_lwps, count_events_callback)
8633         (select_event_lwp_callback): Likewise.
8634         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8635         * arm-linux-nat.c (struct update_registers_data): Remove.
8636         (update_registers_callback): Change type.
8637         (arm_linux_insert_hw_breakpoint1): Update.
8638         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8639         parameter.
8640         (x86_linux_dr_set_addr): Update.
8641         (x86_linux_dr_set_control): Update.
8642         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8643         (iterate_over_lwps): Use gdb::function_view.
8644         * nat/aarch64-linux-hw-point.c (struct
8645         aarch64_dr_update_callback_param): Remove.
8646         (debug_reg_change_callback): Change type.
8647         (aarch64_notify_debug_reg_change): Update.
8648         * s390-linux-nat.c (s390_refresh_per_info): Update.
8649
8650 2019-03-11  Tom Tromey  <tromey@adacore.com>
8651
8652         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8653         redundant assignment to "this_cu".
8654
8655 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8656
8657         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8658
8659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8660
8661         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8662         from...
8663         (rank_one_type): ... this.
8664
8665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8666
8667         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8668         from...
8669         (rank_one_type): ... this.
8670
8671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8672
8673         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8674         from...
8675         (rank_one_type): ... this.
8676
8677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8678
8679         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8680         from...
8681         (rank_one_type): ... this.
8682
8683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8684
8685         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8686         from...
8687         (rank_one_type): ... this.
8688
8689 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8690
8691         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8692         from...
8693         (rank_one_type): ... this.
8694
8695 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8696
8697         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8698         from...
8699         (rank_one_type): ... this.
8700
8701 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8702
8703         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8704         from...
8705         (rank_one_type): ... this.
8706
8707 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8708
8709         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8710         from...
8711         (rank_one_type): ... this.
8712
8713 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8714
8715         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8716         from...
8717         (rank_one_type): ... this.
8718
8719 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8720
8721         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8722         from...
8723         (rank_one_type): ... this.
8724
8725 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8726
8727         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8728         from...
8729         (rank_one_type): ... this.
8730
8731 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8732
8733         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8734         inferior-events' shows the example events.
8735
8736 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8737
8738         Support styling on native MS-Windows console
8739
8740         PR/24315
8741         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8742         on MS-Windows if $TERM is not defined.
8743
8744         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8745
8746         * posix-hdep.c (gdb_console_fputs):
8747         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8748         functions.
8749         * ui-file.h (gdb_console_fputs): Add prototype.
8750
8751         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8752         back to fputs only if the former returns zero.
8753
8754 2019-03-07  Tom Tromey  <tom@tromey.com>
8755
8756         * symmisc.c (print_symbol_bcache_statistics): Update.
8757         (print_objfile_statistics): Update.
8758         * symfile.c (allocate_symtab): Update.
8759         * stabsread.c: Don't include bcache.h.
8760         * psymtab.h (struct psymbol_bcache): Don't declare.
8761         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8762         (psymbol_bcache_init, psymbol_bcache_free)
8763         (psymbol_bcache_get_bcache): Don't declare.
8764         * psymtab.c (struct psymbol_bcache): Remove.
8765         (psymtab_storage::psymtab_storage): Update.
8766         (psymtab_storage::~psymtab_storage): Update.
8767         (psymbol_bcache_init, psymbol_bcache_free)
8768         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8769         (add_psymbol_to_bcache): Update.
8770         (allocate_psymtab): Update.
8771         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8772         macro_cache>: No longer pointers.
8773         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8774         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8775         * macrotab.c (macro_bcache): Update.
8776         * macroexp.c: Don't include bcache.h.
8777         * gdbtypes.c (check_types_worklist): Update.
8778         (types_deeply_equal): Remove TRY/CATCH.  Update.
8779         * elfread.c (elf_symtab_read): Update.
8780         * dwarf2read.c: Don't include bcache.h.
8781         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8782         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8783         (print_bcache_statistics, bcache_memory_used): Don't declare.
8784         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8785         methods.  Rename all data members.
8786         * bcache.c (struct bcache): Move to bcache.h.
8787         (bcache::expand_hash_table): Rename from expand_hash_table.
8788         (bcache): Remove.
8789         (bcache::insert): Rename from bcache_full.
8790         (bcache::compare): Rename from bcache_compare.
8791         (bcache_xmalloc): Remove.
8792         (bcache::~bcache): Rename from bcache_xfree.
8793         (bcache::print_statistics): Rename from print_bcache_statistics.
8794         (bcache::memory_used): Rename from bcache_memory_used.
8795
8796 2019-03-07  Pedro Alves  <palves@redhat.com>
8797
8798         * infrun.c (normal_stop): Also check for
8799         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8800
8801 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
8802
8803         * f-lang.c (value_from_host_double): Moved to...
8804         * value.c (value_from_host_double): ...here.
8805         * value.h (value_from_host_double): Declare.
8806         * guile/scm-math.c (vlscm_convert_typed_number): Use
8807         value_from_host_double.
8808         (vlscm_convert_number): Likewise.
8809         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8810         * python/py-value.c (convert_value_from_python): Likewise.
8811
8812 2019-03-06  Tom Tromey  <tom@tromey.com>
8813
8814         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8815
8816 2019-03-06  Tom Tromey  <tom@tromey.com>
8817
8818         * utils.h (free_current_contents): Don't declare.
8819         * utils.c (free_current_contents): Remove.
8820
8821 2019-03-06  Tom Tromey  <tom@tromey.com>
8822
8823         * top.c (quit_force): Update.
8824         * main.c (captured_command_loop): Update.
8825         * common/new-op.c (operator new): Update.
8826         * common/common-exceptions.c (struct catcher)
8827         <save_cleanup_chain>: Remove member.
8828         (exceptions_state_mc_init): Update.
8829         (exception_try_scope_entry): Return nullptr.
8830         (exception_try_scope_exit, exception_rethrow)
8831         (throw_exception_sjlj, throw_exception_cxx): Update.
8832         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8833         (all_cleanups, do_cleanups, discard_cleanups)
8834         (discard_final_cleanups, save_cleanups, save_final_cleanups)
8835         (restore_cleanups, restore_final_cleanups): Don't declare.
8836         (do_final_cleanups): Remove parameter.
8837         * common/cleanups.c (cleanup_chain, make_cleanup)
8838         (make_cleanup_dtor, all_cleanups, do_cleanups)
8839         (discard_my_cleanups, discard_cleanups)
8840         (discard_final_cleanups, save_my_cleanups, save_cleanups)
8841         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8842         (null_cleanup): Remove.
8843         (do_final_cleanups): Remove parameter.
8844
8845 2019-03-06  Tom Tromey  <tom@tromey.com>
8846
8847         * remote.c (remote_target::remote_parse_stop_reply): Use
8848         unique_xmalloc_ptr.
8849
8850 2019-03-06  Tom Tromey  <tom@tromey.com>
8851
8852         * stabsread.c (struct stabs_field_info): Rename from field_info.
8853         <list, fnlist>: Add initializers.
8854         <obstack>: New member.
8855         (read_member_functions, read_struct_fields, read_baseclasses):
8856         Allocate on obstack.  Don't use cleanups.
8857         (read_one_struct_field, read_member_functions, read_struct_fields)
8858         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8859         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8860         (read_struct_type): Update.
8861
8862 2019-03-06  Tom Tromey  <tom@tromey.com>
8863
8864         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8865         * common/filestuff.h (make_cleanup_close): Don't declare.
8866         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8867         Remove.
8868
8869 2019-03-06  Tom Tromey  <tom@tromey.com>
8870
8871         * solib-aix.c: Use make_scope_exit.
8872
8873 2019-03-06  Tom Tromey  <tom@tromey.com>
8874
8875         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8876         Use make_scope_exit.
8877
8878 2019-03-06  Tom Tromey  <tom@tromey.com>
8879
8880         * solib-svr4.c (disable_probes_interface): Remove parameter.
8881         (svr4_handle_solib_event): Use make_scope_exit.
8882
8883 2019-03-06  Tom Tromey  <tom@tromey.com>
8884
8885         * remote.c (struct stop_reply_deleter): Remove.
8886         (stop_reply_up): Update.
8887         (struct stop_reply): Derive from notif_event.  Don't typedef.
8888         <regcache>: Now a std::vector.
8889         (stop_reply_xfree): Remove.
8890         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8891         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
8892         (remote_target::discard_pending_stop_replies): Use delete.
8893         (remote_target::remote_parse_stop_reply): Update.
8894         (remote_target::process_stop_reply): Update.
8895         * remote-notif.h (struct notif_event): Add virtual destructor.
8896         Remove "dtr" member.
8897         (struct notif_client) <alloc_event>: Return a unique_ptr.
8898         (notif_event_xfree): Don't declare.
8899         (notif_event_up): New typedef.
8900         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8901         (notif_event_xfree, do_notif_event_xfree): Remove.
8902         (remote_notif_state_xfree): Update.
8903
8904 2019-03-06  Tom Tromey  <tom@tromey.com>
8905
8906         * infrun.c (displaced_step_clear_cleanup): Now a
8907         forward_scope_exit type.
8908         (displaced_step_prepare_throw): Update.
8909         (displaced_step_fixup): Update.
8910
8911 2019-03-06  Tom Tromey  <tom@tromey.com>
8912
8913         * inferior.h (class inferior): Update comment.
8914         * gdbthread.h (class thread_info): Update comment.
8915
8916 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
8917             Tom Tromey  <tom@tromey.com>
8918
8919         * stabsread.h (struct stab_section_list): Remove.
8920         (coffstab_build_psymtabs): Update.
8921         * dbxread.c (symbuf_sections): Now a std::vector.
8922         (sect_idx): New global.
8923         (fill_symbuf): Update.
8924         (coffstab_build_psymtabs): Change type of stabsects parameter.
8925         Update.
8926         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
8927         std::vector.
8928         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
8929         (coff_locate_sections): Update.
8930         (coff_symfile_read): Remove cleanups.  Update.
8931         (init_stringtab): Add storage parameter.
8932         (free_stringtab, free_stringtab_cleanup): Remove.
8933         (init_lineno): Add storage parameter.
8934         (free_linetab, free_linetab_cleanup): Remove.
8935
8936 2019-03-06  Pedro Alves  <palves@redhat.com>
8937
8938         * linux-fork.c (fork_info::clobber_regs): Delete.
8939         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
8940         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
8941         comment.  Adjust.
8942         (scoped_switch_fork_info::scoped_switch_fork_info)
8943         (checkpoint_command, linux_fork_context): Adjust
8944         fork_save_infrun_state calls.
8945
8946 2019-03-06  Pedro Alves  <palves@redhat.com>
8947
8948         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
8949         (inf_has_multiple_threads): Return 'bool' and rewrite using
8950         inferior_info::threads().
8951
8952 2019-03-06  Pedro Alves  <palves@redhat.com>
8953
8954         * linux-fork.c: Include <list>.
8955         (fork_list): Now a std::list instance.
8956         (fork_info): Add ctor, dtor, and in-class initialize all fields.
8957         (forks_exist_p, find_last_fork): Adjust.
8958         (new_fork): Delete.
8959         (one_fork_p): New.
8960         (add_fork): Adjust.
8961         (free_fork): Delete, folded into fork_info::~fork_info().
8962         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
8963         Adjust.
8964         (init_fork_list): Delete.
8965         (linux_fork_killall, linux_fork_mourn_inferior)
8966         (linux_fork_detach, info_checkpoints_command): Adjust.
8967         (_initialize_linux_fork): No longer call init_fork_list.
8968
8969 2019-03-06  Pedro Alves  <palves@redhat.com>
8970
8971         * linux-fork.c (new_fork): New, split out of ...
8972         (add_fork): ... this.  Return void.  Move "first fork" special
8973         case from here, to ...
8974         (checkpoint_command): ... here.
8975         * linux-linux.h (add_fork): Return void.
8976
8977 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8978
8979         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
8980
8981 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8982             Chris January  <chris.january@arm.com>
8983             David Lecomber  <david.lecomber@arm.com>
8984
8985         * f-exp.y: New token, UNOP_INTRINSIC.
8986         (exp): New pattern using UNOP_INTRINSIC token.
8987         (f77_keywords): Add 'abs' keyword.
8988         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
8989         (value_from_host_double): New function.
8990         (evaluate_subexp_f): Support UNOP_ABS.
8991
8992 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8993
8994         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
8995         types.
8996
8997 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9000         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9001         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9002
9003 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9004
9005         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9006
9007 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9008             Chris January  <chris.january@arm.com>
9009
9010         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9011         * f-exp.y: Define 'KIND' token.
9012         (exp): New pattern for KIND expressions.
9013         (ptype): Handle types with a kind extension.
9014         (direct_abs_decl): Extend to spot kind extensions.
9015         (f77_keywords): Add 'kind' to the list.
9016         (push_kind_type): New function.
9017         (convert_to_kind_type): New function.
9018         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9019         * parse.c (operator_length_standard): Likewise.
9020         * parser-defs.h (enum type_pieces): Add tp_kind.
9021         * std-operator.def: Add UNOP_KIND.
9022
9023 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9024
9025         * f-exp.y (f_parse): Set yydebug.
9026
9027 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9028
9029         * f-lang.c (evaluate_subexp_f): New function.
9030         (exp_descriptor_f): New global.
9031         (f_language_defn): Use exp_descriptor_f instead of
9032         exp_descriptor_standard.
9033
9034 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9035
9036         * f-exp.y (struct token): Add comments.
9037         (dot_ops): Remove uppercase versions and the end marker.
9038         (f77_keywords): Likewise.
9039         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9040         entries in the dot_ops array are case insensitive, and use
9041         strncasecmp to compare strings.  Also some whitespace cleanup in
9042         this area.  Similar for the f77_keywords array, except entries in
9043         this list might be case sensitive.
9044
9045 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9046
9047         * f-exp.y (struct f77_boolean_val): Add comments.
9048         (boolean_values): Remove uppercase versions, and end marker.
9049         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9050         and use strncasecmp to achieve case insensitivity.  Additionally,
9051         perform whitespace cleanup around this code.
9052
9053 2019-03-06  Tom Tromey  <tromey@adacore.com>
9054
9055         * remote-sim.c (gdbsim_target_open): Use result of
9056         gdb_argv::release.
9057
9058 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9059         Dirk Schubert  <dirk.schubert@arm.com>
9060         Chris January  <chris.january@arm.com>
9061
9062         * eval.c (evaluate_subexp_standard): Call Fortran argument
9063         wrapping logic.
9064         * f-lang.c (struct value): A value which can be passed into a
9065         Fortran function call.
9066         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9067         where appropriate.
9068         (struct type): Value ready for a Fortran function call.
9069         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9070         is needed.
9071         * f-lang.h (fortran_argument_convert): Declaration.
9072         (fortran_preserve_arg_pointer): Declaration.
9073         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9074
9075 2019-03-05  Tom Tromey  <tromey@adacore.com>
9076
9077         * python/py-prettyprint.c (print_string_repr): Remove #if.
9078         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9079
9080 2019-03-05  Tom Tromey  <tromey@adacore.com>
9081
9082         * target.c (the_dummy_target): Move later.  Change type to
9083         "dummy_target".
9084         (initialize_targets): Don't initialize the_dummy_target.
9085
9086 2019-03-05  Tom Tromey  <tromey@adacore.com>
9087
9088         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9089         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9090
9091 2019-03-05  Tom Tromey  <tromey@adacore.com>
9092
9093         * windows-nat.c (windows_nat_target::attach)
9094         (windows_nat_target::detach): Don't call gdb_flush.
9095         * valprint.c (generic_val_print, val_print, val_print_string):
9096         Don't call gdb_flush.
9097         * utils.c (defaulted_query): Don't call gdb_flush.
9098         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9099         * target.c (target_announce_detach): Don't call gdb_flush.
9100         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9101         * remote.c (extended_remote_target::attach): Don't call
9102         gdb_flush.
9103         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9104         * printcmd.c (do_examine): Don't call gdb_flush.
9105         (info_display_command): Don't call gdb_flush.
9106         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9107         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9108         * memattr.c (info_mem_command): Don't call gdb_flush.
9109         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9110         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9111         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9112         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9113         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9114         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9115         (gnu_nat_target::detach): Don't call gdb_flush.
9116         * f-valprint.c (f_val_print): Don't call gdb_flush.
9117         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9118         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9119         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9120         gdb_flush.
9121         * c-valprint.c (c_val_print): Don't call gdb_flush.
9122         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9123
9124 2019-03-05  Tom Tromey  <tromey@adacore.com>
9125
9126         * varobj.c (update_dynamic_varobj_children): Update.
9127         (install_default_visualizer): Use reset, not release.
9128         * value.c (set_internalvar): Update.
9129         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9130         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9131         ATTRIBUTE_UNUSED_RESULT.
9132
9133 2019-03-05  Tom Tromey  <tromey@adacore.com>
9134
9135         * remote.c (class scoped_remote_fd) <release>: Add
9136         ATTRIBUTE_UNUSED_RESULT.
9137
9138 2019-03-05  Tom Tromey  <tromey@adacore.com>
9139
9140         * macroexp.c (struct macro_buffer) <release>: Add
9141         ATTRIBUTE_UNUSED_RESULT.
9142
9143 2019-03-05  Tom Tromey  <tromey@adacore.com>
9144
9145         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9146         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9147         ATTRIBUTE_UNUSED_RESULT.
9148
9149 2019-03-05  Tom Tromey  <tromey@adacore.com>
9150
9151         * common/scoped_fd.h (class scoped_fd) <release>: Add
9152         ATTRIBUTE_UNUSED_RESULT.
9153
9154 2019-03-05  Tom Tromey  <tromey@adacore.com>
9155
9156         * parser-defs.h (struct parser_state) <release>: Add
9157         ATTRIBUTE_UNUSED_RESULT.
9158
9159 2019-03-05  Tom Tromey  <tromey@adacore.com>
9160
9161         * utils.h (class gdb_argv) <release>: Add
9162         ATTRIBUTE_UNUSED_RESULT.
9163         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9164
9165 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9166
9167         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9168         for-loop range, to avoid compiler warnings.
9169
9170         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9171         avoid compiler warnings about unused variables.
9172
9173         * NEWS: Mention end of support for native debugging on MS-Windows
9174         before XP.
9175
9176         PR gdb/24292
9177         * common/netstuff.c:
9178         * gdbserver/gdbreplay.c
9179         * gdbserver/remote-utils.c:
9180         * ser-tcp.c:
9181         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9182         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9183         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9184         'getaddrinfo' and 'freeaddrinfo' were not available before
9185         Windows XP, and mingw.org's MinGW headers by default define
9186         _WIN32_WINNT to 0x500.
9187
9188 2019-03-01  Gary Benson <gbenson@redhat.com>
9189
9190         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9191
9192 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9193             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9194
9195         PR gdb/8527
9196         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9197         set_sigint_trap, clear_sigint_trap.
9198
9199 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9200
9201         * target.c (target_detach): Clear the regcache and the
9202         frame cache.
9203
9204 2019-02-27  Pedro Alves  <palves@redhat.com>
9205
9206         * utils.c (set_screen_size): When we cap the height/width sizes,
9207         tweak the corresponding command variable to show "unlimited":
9208
9209 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9210             Pedro Alves  <palves@redhat.com>
9211
9212         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9213         before calling rl_set_screen_size.
9214
9215 2019-02-27  Tom Tromey  <tromey@adacore.com>
9216
9217         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9218         define.
9219         * python/py-value.c: Remove Python 2.4 workaround.
9220         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9221         workaround.
9222         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9223         Python 2.4 workaround.
9224         * python/python-internal.h: Remove Python 2.4 comment.
9225         (Py_ssize_t): Don't define.
9226         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9227         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9228         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9229         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9230         * python/python.c (do_start_initialization): Remove Python 2.4
9231         workaround.
9232         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9233         (print_children): Remove Python 2.4 workaround.
9234         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9235         workaround.
9236         (CHARBUFFERPROC_NAME): Remove.
9237         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9238         Python 2.4 workaround.
9239
9240 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9241
9242         * NEWS: Note minimum Python version.
9243
9244 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9245
9246         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9247         code from these functions.  Remove corresponding ifdefs.  Use
9248         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9249         Remove gotos and target of gotos.
9250         (infpy_search_memory): Likewise.
9251
9252 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9253
9254         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9255         (hppa_gdbarch_init): Don't register deleted functions with
9256         gdbarch.
9257
9258 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9259
9260         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9261         (h8300_unwind_sp): Delete.
9262         (h8300_dummy_id): Delete.
9263         (h8300_gdbarch_init): Don't register deleted functions with
9264         gdbarch.
9265
9266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9269         (ft32_unwind_pc): Delete.
9270         (ft32_unwind_sp): Delete.
9271         (ft32_gdbarch_init): Don't register deleted functions with
9272         gdbarch.
9273
9274 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9275
9276         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9277         (frv_unwind_pc): Delete.
9278         (frv_unwind_sp): Delete.
9279         (frv_gdbarch_init): Don't register deleted functions with
9280         gdbarch.
9281
9282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9283
9284         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9285         (riscv_unwind_pc): Delete.
9286         (riscv_unwind_sp): Delete.
9287         (riscv_gdbarch_init): Don't register deleted functions with
9288         gdbarch.
9289
9290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9291
9292         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9293         (csky_unwind_pc): Delete.
9294         (csky_unwind_sp): Delete.
9295         (csky_gdbarch_init): Don't register deleted functions with
9296         gdbarch.
9297
9298 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9299
9300         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9301         (cris_unwind_pc): Delete.
9302         (cris_unwind_sp): Delete.
9303         (cris_gdbarch_init): Don't register deleted functions with
9304         gdbarch.
9305
9306 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9307
9308         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9309         (bfin_unwind_pc): Delete.
9310         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9311
9312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9315         (arm_unwind_pc): Delete.
9316         (arm_unwind_sp): Delete.
9317         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9318
9319 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9320
9321         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9322         (arc_unwind_pc): Delete.
9323         (arc_unwind_sp): Delete.
9324         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9325
9326 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9329         (alpha_unwind_pc): Delete.
9330         (alpha_gdbarch_init): Don't register deleted functions with
9331         gdbarch.
9332
9333 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9334
9335         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9336         (aarch64_unwind_pc): Delete.
9337         (aarch64_unwind_sp): Delete.
9338         (aarch64_gdbarch_init): Don't register deleted functions with
9339         gdbarch.
9340
9341 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9342
9343         * gdbtypes.c (type_align): Don't consider static members when
9344         computing structure alignment.
9345
9346 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9347
9348         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9349         return 0 for other types.
9350         * arch-utils.c (default_type_align): Always return 0.
9351         * gdbarch.h: Regenerate.
9352         * gdbarch.sh (type_align): Extend comment.
9353         * gdbtypes.c (type_align): Add additional comments, always call
9354         gdbarch_type_align before applying the default rules.
9355         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9356         generic code will then apply a suitable default.
9357         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9358         types, return 0 for other types.
9359
9360 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9361
9362         * NEWS: Create a new section for the next release branch.
9363         Rename the section of the current branch, now that it has
9364         been cut.
9365
9366 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9367
9368         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9369         * version.in: Bump version to 8.3.50.DATE-git.
9370
9371 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9372
9373         * aix-thread.c (ptid_cmp): Remove unused variable.
9374         (get_signaled_thread): Likewise.
9375         (store_regs_user_thread): Likewise.
9376         (store_regs_kernel_thread): Likewise.
9377         (fetch_regs_kernel_thread): Remove shadowed variable.
9378
9379 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9380
9381         * features/riscv/32bit-cpu.xml: Add register numbers.
9382         * features/riscv/32bit-fpu.c: Regenerate.
9383         * features/riscv/32bit-fpu.xml: Add register numbers.
9384         * features/riscv/64bit-cpu.xml: Add register numbers.
9385         * features/riscv/64bit-fpu.c: Regenerate.
9386         * features/riscv/64bit-fpu.xml: Add register numbers.
9387
9388 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9389
9390         * NEWS: Mention two argument form of gdb.Value constructor.
9391         * python/py-value.c (convert_buffer_and_type_to_value): New
9392         function.
9393         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9394         Add support for handling an optional second argument.  Call
9395         convert_buffer_and_type_to_value as appropriate.
9396         * python/python-internal.h (Py_buffer_deleter): New struct.
9397         (Py_buffer_up): New typedef.
9398
9399 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9400
9401         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9402         instead of releasing ownership.
9403
9404 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9405
9406         * dwarf2read.c (open_and_init_dwp_file): Call
9407         elf_numsections instead of bfd_count_sections to initialize
9408         dwp_file->num_sections.
9409
9410 2019-02-25  Tom Tromey  <tromey@adacore.com>
9411
9412         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9413
9414 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9415
9416         * gcore.in: Add '--readnever' option when invoking GDB.
9417
9418 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9419
9420         * MAINTAINERS: Update my email address.
9421
9422 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9423
9424         * build-id.c (build_id_to_debug_bfd_1): New function.
9425         (build_id_to_debug_bfd): Look for separate debug file in
9426         sysroot.
9427
9428 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9429
9430         * gdbarch.sh: Update the copyright year range that is placed into
9431         generated files.
9432
9433 2019-02-22  Keith Seitz  <keiths@redhat.com>
9434
9435         PR symtab/23853
9436         * linespec.c (create_sals_line_offset): Search for the default
9437         symtab's filename instead of its fullname.
9438
9439 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9440
9441         * NEWS: Update style defaults.
9442
9443 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9444
9445         * main.c (captured_main_1): Disable styling in batch mode.
9446
9447 2019-02-20  Tom Tromey  <tom@tromey.com>
9448
9449         * symtab.c (symtab_symbol_info): Fix typos.
9450
9451 2019-02-20  Tom Tromey  <tromey@adacore.com>
9452
9453         * findcmd.c (_initialize_mem_search): Use upper case for
9454         metasyntactic variables.
9455
9456 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9457
9458         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9459         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9460
9461 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9462
9463         * top.h (source_file_name): Change to std::string.
9464         * top.c (source_file_name): Likewise.
9465         (command_line_input): Adjust.
9466         * cli/cli-script.c (script_from_file): Adjust.
9467
9468 2019-02-19  Tom Tromey  <tromey@adacore.com>
9469
9470         * ravenscar-thread.c
9471         (ravenscar_thread_target::update_thread_list): Don't call
9472         ada_build_task_list.
9473         * ada-lang.h (ada_build_task_list): Don't declare.
9474         * ada-tasks.c (struct ada_tasks_inferior_data)
9475         <task_list_valid_p>: Now bool.
9476         (read_known_tasks, ada_task_list_changed)
9477         (ada_tasks_invalidate_inferior_data): Update.
9478         (read_known_tasks_array): Return bool.
9479         (read_known_tasks_list): Likewise.
9480         (read_known_tasks): Return void.
9481         (ada_build_task_list): Now static.
9482
9483 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9486         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9487
9488 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9489
9490         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9491         variant for ada_tasks_pspace_data_handle and
9492         ada_tasks_inferior_data_handle.
9493         (ada_tasks_pspace_data_cleanup): New function.
9494         (ada_tasks_inferior_data_cleanup): New function.
9495
9496 2019-02-17  Tom Tromey  <tom@tromey.com>
9497
9498         * macrotab.h (macro_source_fullname): Return a std::string.
9499         * macrotab.c (macro_include, check_for_redefinition)
9500         (macro_undef, macro_lookup_definition, foreach_macro)
9501         (foreach_macro_in_scope): Update.
9502         (macro_source_fullname): Return a std::string.
9503         * macrocmd.c (show_pp_source_pos): Update.
9504
9505 2019-02-17  Tom Tromey  <tom@tromey.com>
9506
9507         * macrocmd.c (show_pp_source_pos): Style the file names.
9508
9509 2019-02-17  Tom Tromey  <tom@tromey.com>
9510
9511         PR tui/24197:
9512         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9513
9514 2019-02-17  Tom Tromey  <tom@tromey.com>
9515
9516         * ada-lang.c (user_select_syms): Use filtered printing.
9517         * utils.c (wrap_style): New global.
9518         (desired_style): Remove.
9519         (emit_style_escape): Add stream parameter.
9520         (set_output_style, reset_terminal_style, prompt_for_continue):
9521         Update.
9522         (flush_wrap_buffer): Only flush gdb_stdout.
9523         (wrap_here): Set wrap_style.
9524         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9525         treat escape sequences as a character.  Change when wrap buffer is
9526         flushed.
9527         (fputs_styled): Do not set the output style when the default is
9528         requested.
9529         * ui-style.h (struct ui_file_style) <is_default>: New method.
9530         * source.c (print_source_lines_base): Emit escape sequences in one
9531         piece.
9532
9533 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9534
9535         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9536         integers and enumeration types.
9537
9538 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9539
9540         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9541         instead of lookup_symbol_in_language
9542         (do_exact_match): New function.
9543         (ada_get_symbol_name_matcher): Return do_exact_match when
9544         doing a verbatim match.
9545
9546 2019-02-15  Tom Tromey  <tromey@adacore.com>
9547
9548         * ravenscar-thread.c (ravenscar_thread_target::resume)
9549         (ravenscar_thread_target::wait): Special case wildcard requests.
9550
9551 2019-02-15  Tom Tromey  <tromey@adacore.com>
9552
9553         * ravenscar-thread.c (base_ptid): Remove.
9554         (struct ravenscar_thread_target) <close>: New method.
9555         <m_base_ptid>: New member.
9556         <update_inferior_ptid, active_task, task_is_currently_active,
9557         runtime_initialized>: Declare methods.
9558         <ravenscar_thread_target>: Add constructor.
9559         (ravenscar_thread_target::task_is_currently_active)
9560         (ravenscar_thread_target::update_inferior_ptid)
9561         (ravenscar_runtime_initialized): Rename.  Now methods.
9562         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9563         (ravenscar_thread_target::update_thread_list): Update.
9564         (ravenscar_thread_target::active_task): Now method.
9565         (ravenscar_thread_target::store_registers)
9566         (ravenscar_thread_target::prepare_to_store)
9567         (ravenscar_thread_target::prepare_to_store)
9568         (ravenscar_thread_target::mourn_inferior): Update.
9569         (ravenscar_inferior_created): Use "new" to create target.
9570         (ravenscar_thread_target::get_ada_task_ptid): Update.
9571         (_initialize_ravenscar): Don't initialize base_ptid.
9572         (ravenscar_ops): Remove global.
9573
9574 2019-02-15  Tom Tromey  <tromey@adacore.com>
9575
9576         * target.h (push_target): Declare new overload.
9577         * target.c (push_target): New overload, taking an rvalue reference.
9578         * remote.c (remote_target::open_1): Use push_target overload.
9579         * corelow.c (core_target_open): Use push_target overload.
9580
9581 2019-02-15  Tom Tromey  <tromey@adacore.com>
9582
9583         * ravenscar-thread.c (is_ravenscar_task)
9584         (ravenscar_task_is_currently_active): Return bool.
9585         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9586         (_initialize_ravenscar): Remove "(void)".
9587         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9588         Return bool.
9589
9590 2019-02-15  Tom Tromey  <tromey@adacore.com>
9591
9592         * ravenscar-thread.c (ravenscar_runtime_initializer)
9593         (has_ravenscar_runtime, get_running_thread_id)
9594         (ravenscar_thread_target::resume): Fix indentation.
9595
9596 2019-02-15  Tom Tromey  <tromey@adacore.com>
9597
9598         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9599         from ravenscar_arch_ops.
9600         (sparc_ravenscar_ops::fetch_registers)
9601         (sparc_ravenscar_ops::store_registers): Now methods.
9602         (sparc_ravenscar_prepare_to_store): Remove.
9603         (sparc_ravenscar_ops): Redefine.
9604         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9605         methods and destructor.  Remove members.
9606         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9607         (ravenscar_thread_target::store_registers)
9608         (ravenscar_thread_target::prepare_to_store): Update.
9609         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9610         Remove.
9611         (struct ppc_ravenscar_powerpc_ops): Derive from
9612         ravenscar_arch_ops.
9613         (ppc_ravenscar_powerpc_ops::fetch_registers)
9614         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9615         (ppc_ravenscar_powerpc_ops): Redefine.
9616         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9617         (ppc_ravenscar_e500_ops::fetch_registers)
9618         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9619         (ppc_ravenscar_e500_ops): Redefine.
9620         * aarch64-ravenscar-thread.c
9621         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9622         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9623         (aarch64_ravenscar_fetch_registers)
9624         (aarch64_ravenscar_store_registers): Now methods.
9625         (aarch64_ravenscar_ops): Redefine.
9626
9627 2019-02-15  Tom Tromey  <tromey@adacore.com>
9628
9629         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9630         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9631         (ravenscar_thread_target::stopped_by_watchpoint)
9632         (ravenscar_thread_target::stopped_data_address)
9633         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9634
9635 2019-02-15  Tom Tromey  <tromey@adacore.com>
9636
9637         * ravenscar-thread.c: Fix some typos.
9638
9639 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9640             Tom Tromey  <tromey@adacore.com>
9641
9642         * ada-lang.c (ada_exception_sal): Change addr_string to a
9643         std::string.
9644         (create_ada_exception_catchpoint): Update.
9645
9646 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9647             Tom Tromey  <tromey@adacore.com>
9648
9649         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9650         (bp_location_ops): Remove.
9651         (base_breakpoint_allocate_location): Update.
9652         (free_bp_location): Update.
9653         * ada-lang.c (class ada_catchpoint_location)
9654         <ada_catchpoint_location>: Remove ops parameter.
9655         (ada_catchpoint_location_dtor): Remove.
9656         (ada_catchpoint_location_ops): Remove.
9657         (allocate_location_exception): Update.
9658         * breakpoint.h (struct bp_location_ops): Remove.
9659         (class bp_location) <bp_location>: Remove bp_location_ops
9660         parameter.
9661         <~bp_location>: Add destructor.
9662         <ops>: Remove.
9663
9664 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9665             Pedro Alves  <palves@redhat.com>
9666
9667         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9668         'PATH_MAX'.
9669
9670 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9671             Samuel Thibault  <samuel.thibault@gnu.org>
9672             Thomas Schwinge  <thomas@codesourcery.com>
9673
9674         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9675         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9676
9677 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9678
9679         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9680         (check_empty): Use "const char *".
9681
9682         * gnu-nat.c (gnu_nat_target::detach): Instead of
9683         'detach_inferior (pid)' call
9684         'detach_inferior (find_inferior_pid (pid))'.
9685
9686         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9687         'nat/fork-inferior.o'.
9688         * gnu-nat.c: #include "nat/fork-inferior.h".
9689
9690         * gnu-nat.c (gnu_nat_target::detach): Instead of
9691         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9692         * gnu-nat.h: #include "inf-child.h".
9693         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9694         'i386_gnu_nat_target::fetch_registers'.
9695         (gnu_store_registers): Rename/move to
9696         'i386_gnu_nat_target::store_registers'.
9697
9698         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9699         * gnu-nat.h (mach_thread_info): New function.
9700         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9701
9702         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9703
9704 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9705
9706         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9707
9708 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9709
9710         * windows-nat.c (windows_add_thread): Add new parameter
9711         "main_thread_p" with default value set to false.  Update
9712         function documentation as well as all callers.
9713         (windows_delete_thread): Likewise.
9714         (fake_create_process): Update call to windows_add_thread.
9715         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9716         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9717         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9718         call to windows_delete_thread.
9719
9720 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9721
9722         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9723
9724 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9725
9726         * symfile.c (find_separate_debug_file): Use canonical path of
9727         sysroot with child_path instead of gdb_sysroot if it is valid.
9728
9729 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9730
9731         * symfile.c (find_separate_debug_file): Use child_path to
9732         determine if an object file is under a sysroot.
9733
9734 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9735
9736         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9737         unittests/child-path-selftests.c.
9738         * common/pathstuff.c (child_path): New function.
9739         * common/pathstuff.h (child_path): New prototype.
9740         * unittests/child-path-selftests.c: New file.
9741
9742 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9743
9744         * symfile.c (find_separate_debug_file): Look for separate debug
9745         files in debug directories under the sysroot.
9746
9747 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9748
9749         * symtab.h (struct minimal_symbol data_p): New const method.
9750         (struct minimal_symbol text_p): Likewise.
9751         * symtab.c (output_source_filename): Use file name style
9752         to print file name.
9753         (print_symbol_info): Likewise.
9754         (print_msymbol_info): Use address style to print addresses.
9755         Use function name style to print executable text symbols.
9756         (expand_symtab_containing_pc): Use data_p.
9757         (find_pc_sect_compunit_symtab): Likewise.
9758
9759 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9760
9761         * breakpoint.c (describe_other_breakpoints): Use address style
9762         to print addresses.
9763         (say_where): Likewise.
9764
9765 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9766
9767         * ada-typeprint.c (print_func_type): Print function name
9768         style to print function name.
9769         * c-typeprint.c (c_print_type_1): Likewise.
9770
9771 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9772
9773         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9774         for execve.
9775
9776 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9777
9778         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9779         type_stack.
9780
9781 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9782
9783         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9784         TYPE_CODE_REF types.
9785
9786 2019-02-08  Jim Wilson  <jimw@sifive.com>
9787
9788         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9789         (riscv_linux_fregset): New.
9790         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9791
9792 2019-02-07  Tom Tromey  <tom@tromey.com>
9793
9794         * thread.c (thread_cancel_execution_command): Update.
9795         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9796         methods.
9797         (struct thread_fsm_ops): Remove.
9798         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9799         (thread_fsm_should_stop, thread_fsm_return_value)
9800         (thread_fsm_set_finished, thread_fsm_finished_p)
9801         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9802         Don't declare.
9803         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9804         * infrun.c (clear_proceed_status_thread)
9805         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9806         (print_stop_event): Update.
9807         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9808         Add constructor.
9809         (step_command_fsm_ops): Remove.
9810         (new_step_command_fsm): Remove.
9811         (step_1): Update.
9812         (step_command_fsm::should_stop): Rename from
9813         step_command_fsm_should_stop.
9814         (step_command_fsm::clean_up): Rename from
9815         step_command_fsm_clean_up.
9816         (step_command_fsm::do_async_reply_reason): Rename from
9817         step_command_fsm_async_reply_reason.
9818         (struct until_next_fsm): Inherit from thread_fsm.  Add
9819         constructor.
9820         (until_next_fsm_ops): Remove.
9821         (new_until_next_fsm): Remove.
9822         (until_next_fsm::should_stop): Rename from
9823         until_next_fsm_should_stop.
9824         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9825         (until_next_fsm::do_async_reply_reason): Rename from
9826         until_next_fsm_async_reply_reason.
9827         (struct finish_command_fsm): Inherit from thread_fsm.  Add
9828         constructor.  Change type of breakpoint.
9829         (finish_command_fsm_ops): Remove.
9830         (new_finish_command_fsm): Remove.
9831         (finish_command_fsm::should_stop): Rename from
9832         finish_command_fsm_should_stop.
9833         (finish_command_fsm::clean_up): Rename from
9834         finish_command_fsm_clean_up.
9835         (finish_command_fsm::return_value): Rename from
9836         finish_command_fsm_return_value.
9837         (finish_command_fsm::do_async_reply_reason): Rename from
9838         finish_command_fsm_async_reply_reason.
9839         (finish_command): Update.
9840         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9841         Add constructor.
9842         (call_thread_fsm_ops): Remove.
9843         (call_thread_fsm::call_thread_fsm): Rename from
9844         new_call_thread_fsm.
9845         (call_thread_fsm::should_stop): Rename from
9846         call_thread_fsm_should_stop.
9847         (call_thread_fsm::should_notify_stop): Rename from
9848         call_thread_fsm_should_notify_stop.
9849         (run_inferior_call, call_function_by_hand_dummy): Update.
9850         * cli/cli-interp.c (should_print_stop_to_console): Update.
9851         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9852         Add constructor.  Change type of location_breakpoint,
9853         caller_breakpoint.
9854         (until_break_fsm_ops): Remove.
9855         (new_until_break_fsm): Remove.
9856         (until_break_fsm::should_stop): Rename from
9857         until_break_fsm_should_stop.
9858         (until_break_fsm::clean_up): Rename from
9859         until_break_fsm_clean_up.
9860         (until_break_fsm::do_async_reply_reason): Rename from
9861         until_break_fsm_async_reply_reason.
9862         (until_break_command): Update.
9863         * thread-fsm.c: Remove.
9864         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9865
9866 2019-02-07  Tom Tromey  <tom@tromey.com>
9867
9868         * yy-remap.h: Add include guard.
9869         * xtensa-tdep.h: Add include guard.
9870         * xcoffread.h: Rename include guard.
9871         * varobj-iter.h: Add include guard.
9872         * tui/tui.h: Rename include guard.
9873         * tui/tui-winsource.h: Rename include guard.
9874         * tui/tui-wingeneral.h: Rename include guard.
9875         * tui/tui-windata.h: Rename include guard.
9876         * tui/tui-win.h: Rename include guard.
9877         * tui/tui-stack.h: Rename include guard.
9878         * tui/tui-source.h: Rename include guard.
9879         * tui/tui-regs.h: Rename include guard.
9880         * tui/tui-out.h: Rename include guard.
9881         * tui/tui-layout.h: Rename include guard.
9882         * tui/tui-io.h: Rename include guard.
9883         * tui/tui-hooks.h: Rename include guard.
9884         * tui/tui-file.h: Rename include guard.
9885         * tui/tui-disasm.h: Rename include guard.
9886         * tui/tui-data.h: Rename include guard.
9887         * tui/tui-command.h: Rename include guard.
9888         * tic6x-tdep.h: Add include guard.
9889         * target/waitstatus.h: Rename include guard.
9890         * target/wait.h: Rename include guard.
9891         * target/target.h: Rename include guard.
9892         * target/resume.h: Rename include guard.
9893         * target-float.h: Rename include guard.
9894         * stabsread.h: Add include guard.
9895         * rs6000-tdep.h: Add include guard.
9896         * riscv-fbsd-tdep.h: Add include guard.
9897         * regformats/regdef.h: Rename include guard.
9898         * record.h: Rename include guard.
9899         * python/python.h: Rename include guard.
9900         * python/python-internal.h: Rename include guard.
9901         * python/py-stopevent.h: Rename include guard.
9902         * python/py-ref.h: Rename include guard.
9903         * python/py-record.h: Rename include guard.
9904         * python/py-record-full.h: Rename include guard.
9905         * python/py-record-btrace.h: Rename include guard.
9906         * python/py-instruction.h: Rename include guard.
9907         * python/py-events.h: Rename include guard.
9908         * python/py-event.h: Rename include guard.
9909         * procfs.h: Add include guard.
9910         * proc-utils.h: Add include guard.
9911         * p-lang.h: Add include guard.
9912         * or1k-tdep.h: Rename include guard.
9913         * observable.h: Rename include guard.
9914         * nto-tdep.h: Rename include guard.
9915         * nat/x86-linux.h: Rename include guard.
9916         * nat/x86-linux-dregs.h: Rename include guard.
9917         * nat/x86-gcc-cpuid.h: Add include guard.
9918         * nat/x86-dregs.h: Rename include guard.
9919         * nat/x86-cpuid.h: Rename include guard.
9920         * nat/ppc-linux.h: Rename include guard.
9921         * nat/mips-linux-watch.h: Rename include guard.
9922         * nat/linux-waitpid.h: Rename include guard.
9923         * nat/linux-ptrace.h: Rename include guard.
9924         * nat/linux-procfs.h: Rename include guard.
9925         * nat/linux-osdata.h: Rename include guard.
9926         * nat/linux-nat.h: Rename include guard.
9927         * nat/linux-namespaces.h: Rename include guard.
9928         * nat/linux-btrace.h: Rename include guard.
9929         * nat/glibc_thread_db.h: Rename include guard.
9930         * nat/gdb_thread_db.h: Rename include guard.
9931         * nat/gdb_ptrace.h: Rename include guard.
9932         * nat/fork-inferior.h: Rename include guard.
9933         * nat/amd64-linux-siginfo.h: Rename include guard.
9934         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
9935         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
9936         * nat/aarch64-linux.h: Rename include guard.
9937         * nat/aarch64-linux-hw-point.h: Rename include guard.
9938         * mn10300-tdep.h: Add include guard.
9939         * mips-linux-tdep.h: Add include guard.
9940         * mi/mi-parse.h: Rename include guard.
9941         * mi/mi-out.h: Rename include guard.
9942         * mi/mi-main.h: Rename include guard.
9943         * mi/mi-interp.h: Rename include guard.
9944         * mi/mi-getopt.h: Rename include guard.
9945         * mi/mi-console.h: Rename include guard.
9946         * mi/mi-common.h: Rename include guard.
9947         * mi/mi-cmds.h: Rename include guard.
9948         * mi/mi-cmd-break.h: Rename include guard.
9949         * m2-lang.h: Add include guard.
9950         * location.h: Rename include guard.
9951         * linux-record.h: Rename include guard.
9952         * linux-nat.h: Add include guard.
9953         * linux-fork.h: Add include guard.
9954         * i386-darwin-tdep.h: Rename include guard.
9955         * hppa-linux-offsets.h: Add include guard.
9956         * guile/guile.h: Rename include guard.
9957         * guile/guile-internal.h: Rename include guard.
9958         * gnu-nat.h: Rename include guard.
9959         * gdb-stabs.h: Rename include guard.
9960         * frv-tdep.h: Add include guard.
9961         * f-lang.h: Add include guard.
9962         * event-loop.h: Add include guard.
9963         * darwin-nat.h: Rename include guard.
9964         * cp-abi.h: Rename include guard.
9965         * config/sparc/nm-sol2.h: Rename include guard.
9966         * config/nm-nto.h: Rename include guard.
9967         * config/nm-linux.h: Add include guard.
9968         * config/i386/nm-i386gnu.h: Rename include guard.
9969         * config/djgpp/nl_types.h: Rename include guard.
9970         * config/djgpp/langinfo.h: Rename include guard.
9971         * compile/gcc-cp-plugin.h: Add include guard.
9972         * compile/gcc-c-plugin.h: Add include guard.
9973         * compile/compile.h: Rename include guard.
9974         * compile/compile-object-run.h: Rename include guard.
9975         * compile/compile-object-load.h: Rename include guard.
9976         * compile/compile-internal.h: Rename include guard.
9977         * compile/compile-cplus.h: Rename include guard.
9978         * compile/compile-c.h: Rename include guard.
9979         * common/xml-utils.h: Rename include guard.
9980         * common/x86-xstate.h: Rename include guard.
9981         * common/version.h: Rename include guard.
9982         * common/vec.h: Rename include guard.
9983         * common/tdesc.h: Rename include guard.
9984         * common/selftest.h: Rename include guard.
9985         * common/scoped_restore.h: Rename include guard.
9986         * common/scoped_mmap.h: Rename include guard.
9987         * common/scoped_fd.h: Rename include guard.
9988         * common/safe-iterator.h: Rename include guard.
9989         * common/run-time-clock.h: Rename include guard.
9990         * common/refcounted-object.h: Rename include guard.
9991         * common/queue.h: Rename include guard.
9992         * common/ptid.h: Rename include guard.
9993         * common/print-utils.h: Rename include guard.
9994         * common/preprocessor.h: Rename include guard.
9995         * common/pathstuff.h: Rename include guard.
9996         * common/observable.h: Rename include guard.
9997         * common/netstuff.h: Rename include guard.
9998         * common/job-control.h: Rename include guard.
9999         * common/host-defs.h: Rename include guard.
10000         * common/gdb_wait.h: Rename include guard.
10001         * common/gdb_vecs.h: Rename include guard.
10002         * common/gdb_unlinker.h: Rename include guard.
10003         * common/gdb_unique_ptr.h: Rename include guard.
10004         * common/gdb_tilde_expand.h: Rename include guard.
10005         * common/gdb_sys_time.h: Rename include guard.
10006         * common/gdb_string_view.h: Rename include guard.
10007         * common/gdb_splay_tree.h: Rename include guard.
10008         * common/gdb_setjmp.h: Rename include guard.
10009         * common/gdb_ref_ptr.h: Rename include guard.
10010         * common/gdb_optional.h: Rename include guard.
10011         * common/gdb_locale.h: Rename include guard.
10012         * common/gdb_assert.h: Rename include guard.
10013         * common/filtered-iterator.h: Rename include guard.
10014         * common/filestuff.h: Rename include guard.
10015         * common/fileio.h: Rename include guard.
10016         * common/environ.h: Rename include guard.
10017         * common/common-utils.h: Rename include guard.
10018         * common/common-types.h: Rename include guard.
10019         * common/common-regcache.h: Rename include guard.
10020         * common/common-inferior.h: Rename include guard.
10021         * common/common-gdbthread.h: Rename include guard.
10022         * common/common-exceptions.h: Rename include guard.
10023         * common/common-defs.h: Rename include guard.
10024         * common/common-debug.h: Rename include guard.
10025         * common/cleanups.h: Rename include guard.
10026         * common/buffer.h: Rename include guard.
10027         * common/btrace-common.h: Rename include guard.
10028         * common/break-common.h: Rename include guard.
10029         * cli/cli-utils.h: Rename include guard.
10030         * cli/cli-style.h: Rename include guard.
10031         * cli/cli-setshow.h: Rename include guard.
10032         * cli/cli-script.h: Rename include guard.
10033         * cli/cli-interp.h: Rename include guard.
10034         * cli/cli-decode.h: Rename include guard.
10035         * cli/cli-cmds.h: Rename include guard.
10036         * charset-list.h: Add include guard.
10037         * buildsym-legacy.h: Rename include guard.
10038         * bfin-tdep.h: Add include guard.
10039         * ax.h: Rename include guard.
10040         * arm-linux-tdep.h: Add include guard.
10041         * arm-fbsd-tdep.h: Add include guard.
10042         * arch/xtensa.h: Rename include guard.
10043         * arch/tic6x.h: Add include guard.
10044         * arch/i386.h: Add include guard.
10045         * arch/arm.h: Rename include guard.
10046         * arch/arm-linux.h: Rename include guard.
10047         * arch/arm-get-next-pcs.h: Rename include guard.
10048         * arch/amd64.h: Add include guard.
10049         * arch/aarch64-insn.h: Rename include guard.
10050         * arch-utils.h: Rename include guard.
10051         * annotate.h: Add include guard.
10052         * amd64-darwin-tdep.h: Rename include guard.
10053         * aarch64-linux-tdep.h: Add include guard.
10054         * aarch64-fbsd-tdep.h: Add include guard.
10055         * aarch32-linux-nat.h: Add include guard.
10056
10057 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10058
10059         * macrotab.c (macro_define_internal): New function that
10060         factorizes macro_define_object_internal and macro_define_function
10061         code.
10062         (macro_define_object_internal): Use macro_define_internal.
10063         (macro_define_function): Likewise.
10064
10065 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10066
10067         * macrocmd.c (extract_identifier): Return
10068         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10069         callers.
10070
10071 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10072
10073         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10074
10075 2019-02-05  Tom Tromey  <tom@tromey.com>
10076
10077         * target.c (target_stack::unpush): Move assertion earlier.
10078
10079 2019-01-30  Tom Tromey  <tom@tromey.com>
10080
10081         PR python/23615:
10082         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10083         (gdbpy_parse_and_eval): Likewise.
10084         * python/python-internal.h (gdbpy_allow_threads): New class.
10085
10086 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10087
10088         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10089         (aarch64_fbsd_fpregmap): Move earlier.
10090         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10091         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10092         instead of individual calls to trad_frame_set_reg_addr.
10093         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10094         earlier.
10095         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10096         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10097         instead of individual calls to trad_frame_set_reg_addr.
10098
10099 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10100
10101         * CONTRIBUTE: Replace contribution list with wiki link.
10102
10103 2019-01-25  Tom Tromey  <tom@tromey.com>
10104
10105         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10106
10107 2019-01-25  Tom Tromey  <tom@tromey.com>
10108
10109         * xtensa-linux-nat.c: Fix common/ includes.
10110         * xml-support.h: Fix common/ includes.
10111         * xml-support.c: Fix common/ includes.
10112         * x86-linux-nat.c: Fix common/ includes.
10113         * windows-nat.c: Fix common/ includes.
10114         * varobj.h: Fix common/ includes.
10115         * varobj.c: Fix common/ includes.
10116         * value.c: Fix common/ includes.
10117         * valops.c: Fix common/ includes.
10118         * utils.c: Fix common/ includes.
10119         * unittests/xml-utils-selftests.c: Fix common/ includes.
10120         * unittests/utils-selftests.c: Fix common/ includes.
10121         * unittests/unpack-selftests.c: Fix common/ includes.
10122         * unittests/tracepoint-selftests.c: Fix common/ includes.
10123         * unittests/style-selftests.c: Fix common/ includes.
10124         * unittests/string_view-selftests.c: Fix common/ includes.
10125         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10126         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10127         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10128         * unittests/rsp-low-selftests.c: Fix common/ includes.
10129         * unittests/parse-connection-spec-selftests.c: Fix common/
10130         includes.
10131         * unittests/optional-selftests.c: Fix common/ includes.
10132         * unittests/offset-type-selftests.c: Fix common/ includes.
10133         * unittests/observable-selftests.c: Fix common/ includes.
10134         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10135         * unittests/memrange-selftests.c: Fix common/ includes.
10136         * unittests/memory-map-selftests.c: Fix common/ includes.
10137         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10138         * unittests/function-view-selftests.c: Fix common/ includes.
10139         * unittests/environ-selftests.c: Fix common/ includes.
10140         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10141         * unittests/common-utils-selftests.c: Fix common/ includes.
10142         * unittests/cli-utils-selftests.c: Fix common/ includes.
10143         * unittests/array-view-selftests.c: Fix common/ includes.
10144         * ui-file.c: Fix common/ includes.
10145         * tui/tui-io.c: Fix common/ includes.
10146         * tracepoint.h: Fix common/ includes.
10147         * tracepoint.c: Fix common/ includes.
10148         * tracefile-tfile.c: Fix common/ includes.
10149         * top.h: Fix common/ includes.
10150         * top.c: Fix common/ includes.
10151         * thread.c: Fix common/ includes.
10152         * target/waitstatus.h: Fix common/ includes.
10153         * target/waitstatus.c: Fix common/ includes.
10154         * target.h: Fix common/ includes.
10155         * target.c: Fix common/ includes.
10156         * target-memory.c: Fix common/ includes.
10157         * target-descriptions.c: Fix common/ includes.
10158         * symtab.h: Fix common/ includes.
10159         * symfile.c: Fix common/ includes.
10160         * stap-probe.c: Fix common/ includes.
10161         * spu-linux-nat.c: Fix common/ includes.
10162         * sparc-nat.c: Fix common/ includes.
10163         * source.c: Fix common/ includes.
10164         * solib.c: Fix common/ includes.
10165         * solib-target.c: Fix common/ includes.
10166         * ser-unix.c: Fix common/ includes.
10167         * ser-tcp.c: Fix common/ includes.
10168         * ser-pipe.c: Fix common/ includes.
10169         * ser-base.c: Fix common/ includes.
10170         * selftest-arch.c: Fix common/ includes.
10171         * s12z-tdep.c: Fix common/ includes.
10172         * rust-exp.y: Fix common/ includes.
10173         * rs6000-aix-tdep.c: Fix common/ includes.
10174         * riscv-tdep.c: Fix common/ includes.
10175         * remote.c: Fix common/ includes.
10176         * remote-notif.h: Fix common/ includes.
10177         * remote-fileio.h: Fix common/ includes.
10178         * remote-fileio.c: Fix common/ includes.
10179         * regcache.h: Fix common/ includes.
10180         * regcache.c: Fix common/ includes.
10181         * record-btrace.c: Fix common/ includes.
10182         * python/python.c: Fix common/ includes.
10183         * python/py-type.c: Fix common/ includes.
10184         * python/py-inferior.c: Fix common/ includes.
10185         * progspace.h: Fix common/ includes.
10186         * producer.c: Fix common/ includes.
10187         * procfs.c: Fix common/ includes.
10188         * proc-api.c: Fix common/ includes.
10189         * printcmd.c: Fix common/ includes.
10190         * ppc-linux-nat.c: Fix common/ includes.
10191         * parser-defs.h: Fix common/ includes.
10192         * osdata.c: Fix common/ includes.
10193         * obsd-nat.c: Fix common/ includes.
10194         * nat/x86-linux.c: Fix common/ includes.
10195         * nat/x86-linux-dregs.c: Fix common/ includes.
10196         * nat/x86-dregs.h: Fix common/ includes.
10197         * nat/x86-dregs.c: Fix common/ includes.
10198         * nat/ppc-linux.c: Fix common/ includes.
10199         * nat/mips-linux-watch.h: Fix common/ includes.
10200         * nat/mips-linux-watch.c: Fix common/ includes.
10201         * nat/linux-waitpid.c: Fix common/ includes.
10202         * nat/linux-ptrace.h: Fix common/ includes.
10203         * nat/linux-ptrace.c: Fix common/ includes.
10204         * nat/linux-procfs.c: Fix common/ includes.
10205         * nat/linux-personality.c: Fix common/ includes.
10206         * nat/linux-osdata.c: Fix common/ includes.
10207         * nat/linux-namespaces.c: Fix common/ includes.
10208         * nat/linux-btrace.h: Fix common/ includes.
10209         * nat/linux-btrace.c: Fix common/ includes.
10210         * nat/fork-inferior.c: Fix common/ includes.
10211         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10212         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10213         * nat/aarch64-linux.c: Fix common/ includes.
10214         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10215         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10216         * namespace.h: Fix common/ includes.
10217         * mips-linux-tdep.c: Fix common/ includes.
10218         * minsyms.c: Fix common/ includes.
10219         * mi/mi-parse.h: Fix common/ includes.
10220         * mi/mi-main.c: Fix common/ includes.
10221         * mi/mi-cmd-env.c: Fix common/ includes.
10222         * memrange.h: Fix common/ includes.
10223         * memattr.c: Fix common/ includes.
10224         * maint.h: Fix common/ includes.
10225         * maint.c: Fix common/ includes.
10226         * main.c: Fix common/ includes.
10227         * machoread.c: Fix common/ includes.
10228         * location.c: Fix common/ includes.
10229         * linux-thread-db.c: Fix common/ includes.
10230         * linux-nat.c: Fix common/ includes.
10231         * linux-fork.c: Fix common/ includes.
10232         * inline-frame.c: Fix common/ includes.
10233         * infrun.c: Fix common/ includes.
10234         * inflow.c: Fix common/ includes.
10235         * inferior.h: Fix common/ includes.
10236         * inferior.c: Fix common/ includes.
10237         * infcmd.c: Fix common/ includes.
10238         * inf-ptrace.c: Fix common/ includes.
10239         * inf-child.c: Fix common/ includes.
10240         * ia64-linux-nat.c: Fix common/ includes.
10241         * i387-tdep.c: Fix common/ includes.
10242         * i386-tdep.c: Fix common/ includes.
10243         * i386-linux-tdep.c: Fix common/ includes.
10244         * i386-linux-nat.c: Fix common/ includes.
10245         * i386-go32-tdep.c: Fix common/ includes.
10246         * i386-fbsd-tdep.c: Fix common/ includes.
10247         * i386-fbsd-nat.c: Fix common/ includes.
10248         * guile/scm-type.c: Fix common/ includes.
10249         * guile/guile.c: Fix common/ includes.
10250         * go32-nat.c: Fix common/ includes.
10251         * gnu-nat.c: Fix common/ includes.
10252         * gdbthread.h: Fix common/ includes.
10253         * gdbarch-selftests.c: Fix common/ includes.
10254         * gdb_usleep.c: Fix common/ includes.
10255         * gdb_select.h: Fix common/ includes.
10256         * gdb_bfd.c: Fix common/ includes.
10257         * gcore.c: Fix common/ includes.
10258         * fork-child.c: Fix common/ includes.
10259         * findvar.c: Fix common/ includes.
10260         * fbsd-nat.c: Fix common/ includes.
10261         * event-top.c: Fix common/ includes.
10262         * event-loop.c: Fix common/ includes.
10263         * dwarf2read.c: Fix common/ includes.
10264         * dwarf2loc.c: Fix common/ includes.
10265         * dwarf2-frame.c: Fix common/ includes.
10266         * dwarf-index-cache.c: Fix common/ includes.
10267         * dtrace-probe.c: Fix common/ includes.
10268         * disasm-selftests.c: Fix common/ includes.
10269         * defs.h: Fix common/ includes.
10270         * csky-tdep.c: Fix common/ includes.
10271         * cp-valprint.c: Fix common/ includes.
10272         * cp-support.h: Fix common/ includes.
10273         * cp-support.c: Fix common/ includes.
10274         * corelow.c: Fix common/ includes.
10275         * completer.h: Fix common/ includes.
10276         * completer.c: Fix common/ includes.
10277         * compile/compile.c: Fix common/ includes.
10278         * compile/compile-loc2c.c: Fix common/ includes.
10279         * compile/compile-cplus-types.c: Fix common/ includes.
10280         * compile/compile-cplus-symbols.c: Fix common/ includes.
10281         * command.h: Fix common/ includes.
10282         * cli/cli-dump.c: Fix common/ includes.
10283         * cli/cli-cmds.c: Fix common/ includes.
10284         * charset.c: Fix common/ includes.
10285         * build-id.c: Fix common/ includes.
10286         * btrace.h: Fix common/ includes.
10287         * btrace.c: Fix common/ includes.
10288         * breakpoint.h: Fix common/ includes.
10289         * breakpoint.c: Fix common/ includes.
10290         * ax.h:
10291         (enum agent_op): Fix common/ includes.
10292         * ax-general.c (struct aop_map): Fix common/ includes.
10293         * ax-gdb.c: Fix common/ includes.
10294         * auxv.c: Fix common/ includes.
10295         * auto-load.c: Fix common/ includes.
10296         * arm-tdep.c: Fix common/ includes.
10297         * arch/riscv.c: Fix common/ includes.
10298         * arch/ppc-linux-common.c: Fix common/ includes.
10299         * arch/i386.c: Fix common/ includes.
10300         * arch/arm.c: Fix common/ includes.
10301         * arch/arm-linux.c: Fix common/ includes.
10302         * arch/arm-get-next-pcs.c: Fix common/ includes.
10303         * arch/amd64.c: Fix common/ includes.
10304         * arch/aarch64.c: Fix common/ includes.
10305         * arch/aarch64-insn.c: Fix common/ includes.
10306         * arch-utils.c: Fix common/ includes.
10307         * amd64-windows-tdep.c: Fix common/ includes.
10308         * amd64-tdep.c: Fix common/ includes.
10309         * amd64-sol2-tdep.c: Fix common/ includes.
10310         * amd64-obsd-tdep.c: Fix common/ includes.
10311         * amd64-nbsd-tdep.c: Fix common/ includes.
10312         * amd64-linux-tdep.c: Fix common/ includes.
10313         * amd64-linux-nat.c: Fix common/ includes.
10314         * amd64-fbsd-tdep.c: Fix common/ includes.
10315         * amd64-fbsd-nat.c: Fix common/ includes.
10316         * amd64-dicos-tdep.c: Fix common/ includes.
10317         * amd64-darwin-tdep.c: Fix common/ includes.
10318         * agent.c: Fix common/ includes.
10319         * ada-lang.h: Fix common/ includes.
10320         * ada-lang.c: Fix common/ includes.
10321         * aarch64-tdep.c: Fix common/ includes.
10322
10323 2019-01-25  Tom Tromey  <tom@tromey.com>
10324
10325         * common/create-version.sh: Use common/version.h.
10326
10327 2019-01-24  Pedro Alves  <palves@redhat.com>
10328
10329         * infrun.c (signal_stop, signal_print, signal_program)
10330         (signal_catch, signal_pass): Now arrays instead of pointers.
10331         (update_signals_program_target, do_target_resume)
10332         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10333         * linux-nat.c (linux_nat_target::pass_signals)
10334         (linux_nat_target::create_inferior, linux_nat_target::attach):
10335         Adjust.
10336         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10337         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10338         * procfs.c (procfs_target::pass_signals): Adjust.
10339         * record-full.c (record_full_target::resume): Adjust.
10340         * remote.c (remote_target::pass_signals)
10341         (remote_target::program_signals): Adjust.
10342         * target-debug.h (target_debug_print_signals): Now takes a
10343         gdb::array_view as parameter.  Adjust.
10344         * target.h (target_ops) <pass_signals, program_signals>: Replace
10345         pointer and length parameters with gdb::array_view.
10346         (target_pass_signals, target_program_signals): Likewise.
10347         * target-delegates.c: Regenerate.
10348
10349 2019-01-24  Pedro Alves  <palves@redhat.com>
10350
10351         * common/forward-scope-exit.h
10352         (forward_scope_exit::forward_scope_exit): Pass arguments to
10353         m_bind_function directly, instead of creating a std::bind and
10354         copying that.
10355
10356 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10357
10358         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10359         for static members.
10360         (pass_in_v_vfp_candidate): Likewise.
10361
10362 2019-01-23  Tom Tromey  <tom@tromey.com>
10363             Pedro Alves  <palves@redhat.com>
10364
10365         * regcache.c (class regcache_invalidator): Remove.
10366         (regcache::raw_write): Use make_scope_exit.
10367
10368 2019-01-23  Tom Tromey  <tom@tromey.com>
10369
10370         * ui-out.h (class ui_out_emit_type): Update comment.
10371
10372 2019-01-23  Tom Tromey  <tom@tromey.com>
10373
10374         * infrun.c (fetch_inferior_event): Update comment.
10375
10376 2019-01-23  Tom Tromey  <tom@tromey.com>
10377             Pedro Alves  <palves@redhat.com>
10378
10379         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10380         parameter.
10381         (fetch_inferior_event): Use SCOPE_EXIT.
10382
10383
10384 2019-01-23  Tom Tromey  <tom@tromey.com>
10385             Pedro Alves  <palves@redhat.com>
10386
10387         * infrun.c (disable_thread_events): Delete.
10388         (stop_all_threads): Use SCOPE_EXIT.
10389
10390 2019-01-23  Tom Tromey  <tom@tromey.com>
10391             Pedro Alves  <palves@redhat.com>
10392
10393         * symfile.c: Include forward-scope-exit.h.
10394         (clear_symtab_users_cleanup): Replace forward declaration with
10395         a FORWARD_SCOPE_EXIT.
10396         (syms_from_objfile_1): Use the forward_scope_exit and
10397         gdb::optional instead of cleanup_function.
10398         (reread_symbols): Use the forward_scope_exit instead of
10399         cleanup_function.
10400         (clear_symtab_users_cleanup): Remove function.
10401
10402 2019-01-23  Tom Tromey  <tom@tromey.com>
10403             Pedro Alves  <palves@redhat.com>
10404
10405         * linux-nat.c: Include scope-exit.h.
10406         (cleanup_target_stop): Remove.
10407         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10408         SCOPE_EXIT.
10409
10410 2019-01-23  Tom Tromey  <tom@tromey.com>
10411             Pedro Alves  <palves@redhat.com>
10412
10413         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10414         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10415
10416 2019-01-23  Tom Tromey  <tom@tromey.com>
10417             Andrew Burgess  <andrew.burgess@embecosm.com>
10418             Pedro Alves  <palves@redhat.com>
10419
10420         * infrun.c (fetch_inferior_event): Use scope_exit.
10421         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10422         * top.c (execute_command): Use scope_exit.
10423         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10424         * utils.c (do_bpstat_clear_actions_cleanup)
10425         (make_bpstat_clear_actions_cleanup): Remove.
10426
10427 2019-01-23  Tom Tromey  <tom@tromey.com>
10428             Pedro Alves  <palves@redhat.com>
10429
10430         * infrun.c: Include "common/scope-exit.h"
10431         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10432         (wait_for_inferior): Use SCOPE_EXIT.
10433         (fetch_inferior_event): Use scope_exit.
10434
10435 2019-01-23  Tom Tromey  <tom@tromey.com>
10436             Pedro Alves  <palves@redhat.com>
10437
10438         * breakpoint.c (create_breakpoint): Remove cleanup.
10439
10440 2019-01-23  Tom Tromey  <tom@tromey.com>
10441             Andrew Burgess  <andrew.burgess@embecosm.com>
10442             Pedro Alves  <palves@redhat.com>
10443
10444 2019-01-23  Pedro Alves  <palves@redhat.com>
10445
10446         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10447
10448 2019-01-23  Pedro Alves  <palves@redhat.com>
10449             Andrew Burgess  <andrew.burgess@embecosm.com>
10450
10451         * gdbthread.h: Include "common/forward-scope-exit.h".
10452         (scoped_finish_thread_state): Redefine custom class in terms of
10453         forward_scope_exit.
10454
10455 2019-01-23  Pedro Alves  <palves@redhat.com>
10456             Andrew Burgess  <andrew.burgess@embecosm.com>
10457
10458         * common/forward-scope-exit.h: New file.
10459
10460 2019-01-23  Pedro Alves  <palves@redhat.com>
10461             Andrew Burgess  <andrew.burgess@embecosm.com>
10462             Tom Tromey  <tom@tromey.com>
10463
10464         * common/scope-exit.h: New file.
10465
10466 2019-01-23  Pedro Alves  <palves@redhat.com>
10467
10468         * common/preprocessor.h (ESC): Rename to ...
10469         (ESC_PARENS): ... this.
10470         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10471         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10472
10473 2019-01-23  Tom Tromey  <tom@tromey.com>
10474
10475         * language.h (class scoped_switch_to_sym_language_if_auto):
10476         Initialize m_lang in both cases.
10477
10478 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10479
10480         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10481         with XCNEW.
10482
10483 2019-01-22  Tom Tromey  <tom@tromey.com>
10484
10485         * corelow.c: Do not include sys/file.h.
10486
10487 2019-01-22  Tom Tromey  <tom@tromey.com>
10488
10489         * tui/tui-wingeneral.h: Include gdb_curses.h.
10490
10491 2019-01-22  Tom Tromey  <tom@tromey.com>
10492
10493         * source-cache.h (class source_cache) <get_source_lines,
10494         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10495
10496 2019-01-22  Tom Tromey  <tom@tromey.com>
10497
10498         * remote-fileio.h (struct remote_target): Declare.
10499
10500 2019-01-22  Tom Tromey  <tom@tromey.com>
10501
10502         * python/py-arch.c: Do not include py-ref.h.
10503         * python/py-bpevent.c: Do not include py-ref.h.
10504         * python/py-cmd.c: Do not include py-ref.h.
10505         * python/py-continueevent.c: Do not include py-ref.h.
10506         * python/py-event.h: Do not include py-ref.h.
10507         * python/py-evtregistry.c: Do not include py-ref.h.
10508         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10509         * python/py-frame.c: Do not include py-ref.h.
10510         * python/py-framefilter.c: Do not include py-ref.h.
10511         * python/py-function.c: Do not include py-ref.h.
10512         * python/py-infevents.c: Do not include py-ref.h.
10513         * python/py-linetable.c: Do not include py-ref.h.
10514         * python/py-objfile.c: Do not include py-ref.h.
10515         * python/py-param.c: Do not include py-ref.h.
10516         * python/py-prettyprint.c: Do not include py-ref.h.
10517         * python/py-progspace.c: Do not include py-ref.h.
10518         * python/py-symbol.c: Do not include py-ref.h.
10519         * python/py-symtab.c: Do not include py-ref.h.
10520         * python/py-type.c: Do not include py-ref.h.
10521         * python/py-unwind.c: Do not include py-ref.h.
10522         * python/py-utils.c: Do not include py-ref.h.
10523         * python/py-value.c: Do not include py-ref.h.
10524         * python/py-varobj.c: Do not include py-ref.h.
10525         * python/py-xmethods.c: Do not include py-ref.h.
10526         * python/python.c: Do not include py-ref.h.
10527         * varobj.c: Do not include py-ref.h.
10528
10529 2019-01-22  Tom Tromey  <tom@tromey.com>
10530
10531         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10532         keyword for bcache.
10533
10534 2019-01-22  Tom Tromey  <tom@tromey.com>
10535
10536         * compile/compile-cplus-types.c: Remove a comment by #include.
10537
10538 2019-01-22  Tom Tromey  <tom@tromey.com>
10539
10540         * compile/gcc-c-plugin.h: Include compile-internal.h.
10541
10542 2019-01-22  Tom Tromey  <tom@tromey.com>
10543
10544         * stabsread.c (EXTERN): Do not define.
10545         (symnum, next_symbol_text_func, processing_gcc_compilation)
10546         (within_function, global_sym_chain, global_stabs)
10547         (previous_stab_code, this_object_header_files)
10548         (n_this_object_header_files)
10549         (n_allocated_this_object_header_files): Define.
10550         * stabsread.h (EXTERN): Never define.  Use "extern".
10551
10552 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10553
10554         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10555         history_value.
10556
10557 2019-01-21  Tom Tromey  <tom@tromey.com>
10558
10559         * ui-out.c: Fix includes.
10560         * tui/tui-source.c: Fix includes.
10561         * target.c: Fix includes.
10562         * remote.c: Fix includes.
10563         * regcache.c: Fix includes.
10564         * python/py-block.c: Fix includes.
10565         * printcmd.c: Fix includes.
10566         * or1k-tdep.c: Fix includes.
10567         * mi/mi-main.c: Fix includes.
10568         * m32r-tdep.c: Fix includes.
10569         * csky-tdep.c: Fix includes.
10570         * compile/compile-cplus-types.c: Fix includes.
10571         * cli/cli-interp.c: Fix includes.
10572
10573 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10574
10575         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10576         for padding.
10577
10578 2019-01-16  Tom Tromey  <tom@tromey.com>
10579
10580         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10581         earlier.
10582         (struct objfile) <msymbols_range>: Move from top level.
10583         <msymbols>: New method.
10584         (class objfile_msymbols): Remove.
10585         * symtab.c (default_collect_symbol_completion_matches_break_on):
10586         Update.
10587         * symmisc.c (dump_msymbols): Update.
10588         * stabsread.c (scan_file_globals): Update.
10589         * objc-lang.c (info_selectors_command, info_classes_command)
10590         (find_methods): Update.
10591         * minsyms.c (find_solib_trampoline_target): Update.
10592         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10593         * coffread.c (coff_symfile_read): Update.
10594         * ada-lang.c (ada_lookup_simple_minsym)
10595         (ada_collect_symbol_completion_matches): Update.
10596
10597 2019-01-16  Tom Tromey  <tom@tromey.com>
10598
10599         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10600         type.  Remove no-argument constructor.
10601         <iterator::operator++>: Simplify.
10602         <begin>: Update.
10603         <end>: Use minimal_symbol_count.
10604
10605 2019-01-16  Tom Tromey  <tom@tromey.com>
10606
10607         * objfiles.h (struct objfile) <psymtabs>: New method.
10608         (class objfile_psymtabs): Remove.
10609         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10610         typedef.
10611         <range>: New method.
10612         (require_partial_symbols): Change return type.
10613         * psymtab.c (require_partial_symbols)
10614         (psym_expand_symtabs_matching): Update.
10615         * mdebugread.c (parse_partial_symbols): Update.
10616         * dbxread.c (dbx_end_psymtab): Update.
10617
10618 2019-01-15  Tom Tromey  <tom@tromey.com>
10619
10620         * symtab.c (lookup_objfile_from_block)
10621         (lookup_symbol_in_objfile_symtabs)
10622         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10623         (find_line_symtab, info_sources_command)
10624         (default_collect_symbol_completion_matches_break_on)
10625         (make_source_files_completion_list): Update.
10626         * symmisc.c (print_objfile_statistics, dump_objfile)
10627         (maintenance_print_symbols, maintenance_info_symtabs)
10628         (maintenance_check_symtabs, maintenance_info_line_tables):
10629         Update.
10630         * source.c (select_source_symtab)
10631         (forget_cached_source_info_for_objfile): Update.
10632         * objfiles.h (class objfile_compunits): Remove.
10633         (struct objfile) <compunits_range>: New typedef.
10634         (compunits): New method.
10635         * objfiles.c (objfile_relocate1): Update.
10636         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10637         * maint.c (count_symtabs_and_blocks): Update.
10638         * linespec.c (iterate_over_all_matching_symtabs): Update.
10639         * cp-support.c (add_symbol_overload_list_qualified): Update.
10640         * coffread.c (coff_symtab_read): Update.
10641         * ada-lang.c (add_nonlocal_symbols)
10642         (ada_collect_symbol_completion_matches)
10643         (ada_add_global_exceptions): Update.
10644
10645 2019-01-15  Tom Tromey  <tom@tromey.com>
10646
10647         * progspace.h (program_space) <objfiles_safe_range>: New
10648         typedef.
10649         <objfiles_safe>: New method.
10650         * objfiles.h (class all_objfiles_safe): Remove.
10651         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10652         * jit.c (jit_inferior_exit_hook): Update.
10653
10654 2019-01-17  Tom Tromey  <tom@tromey.com>
10655
10656         * progspace.h (program_space) <objfiles_range>: New typedef.
10657         <objfiles>: New method.
10658         <objfiles_head>: Rename from objfiles.
10659         (object_files): Update.
10660         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10661         * guile/scm-pretty-print.c
10662         (ppscm_find_pretty_printer_from_objfiles): Update.
10663         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10664         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10665         Update.
10666         * python/py-progspace.c (pspy_get_objfiles): Update.
10667         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10668         Update.
10669         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10670         (objfpy_lookup_objfile_by_build_id): Update.
10671         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10672         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10673         Update.
10674         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10675         (expand_symtab_containing_pc, lookup_objfile_from_block)
10676         (lookup_static_symbol, basic_lookup_transparent_type)
10677         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10678         (find_line_symtab, info_sources_command)
10679         (default_collect_symbol_completion_matches_break_on)
10680         (make_source_files_completion_list, find_main_name): Update.
10681         * symmisc.c (print_symbol_bcache_statistics)
10682         (print_objfile_statistics, maintenance_print_symbols)
10683         (maintenance_print_msymbols, maintenance_print_objfiles)
10684         (maintenance_info_symtabs, maintenance_check_symtabs)
10685         (maintenance_expand_symtabs, maintenance_info_line_tables):
10686         Update.
10687         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10688         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10689         (map_overlay_command, unmap_overlay_command)
10690         (simple_overlay_update, expand_symtabs_matching)
10691         (map_symbol_filenames): Update.
10692         * symfile-debug.c (set_debug_symfile): Update.
10693         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10694         Update.
10695         * source.c (select_source_symtab, forget_cached_source_info):
10696         Update.
10697         * solib.c (solib_read_symbols): Update.
10698         * solib-spu.c (append_ocl_sos): Update.
10699         * psymtab.c (maintenance_print_psymbols)
10700         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10701         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10702         * printcmd.c (info_symbol_command): Update.
10703         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10704         Update.
10705         * objfiles.h (class all_objfiles): Remove.
10706         * objfiles.c (have_partial_symbols, have_full_symbols)
10707         (have_minimal_symbols, qsort_cmp, update_section_map)
10708         (shared_objfile_contains_address_p)
10709         (default_iterate_over_objfiles_in_search_order): Update.
10710         * objc-lang.c (info_selectors_command, info_classes_command)
10711         (find_methods): Update.
10712         * minsyms.c (find_solib_trampoline_target): Update.
10713         * maint.c (maintenance_info_sections)
10714         (maintenance_translate_address, count_symtabs_and_blocks):
10715         Update.
10716         * main.c (captured_main_1): Update.
10717         * linux-thread-db.c (try_thread_db_load_from_pdir)
10718         (has_libpthread): Update.
10719         * linespec.c (iterate_over_all_matching_symtabs)
10720         (search_minsyms_for_name): Update.
10721         * jit.c (jit_find_objf_with_entry_addr): Update.
10722         * hppa-tdep.c (find_unwind_entry)
10723         (hppa_lookup_stub_minimal_symbol): Update.
10724         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10725         Update.
10726         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10727         (elf_gnu_ifunc_resolve_by_got): Update.
10728         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10729         * dwarf-index-write.c (save_gdb_index_command): Update.
10730         * cp-support.c (add_symbol_overload_list_qualified): Update.
10731         * breakpoint.c (create_overlay_event_breakpoint)
10732         (create_longjmp_master_breakpoint)
10733         (create_std_terminate_master_breakpoint)
10734         (create_exception_master_breakpoint): Update.
10735         * blockframe.c (find_pc_partial_function): Update.
10736         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10737         (ada_collect_symbol_completion_matches)
10738         (ada_add_global_exceptions): Update.
10739
10740 2019-01-17  Tom Tromey  <tom@tromey.com>
10741
10742         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10743         declare VEC.
10744         (solib_target_parse_libraries): Change return type.
10745         (library_list_start_segment, library_list_start_section)
10746         (library_list_end_library, library_list_start_library); Update.
10747         (solib_target_free_library_list): Remove.
10748         (solib_target_parse_libraries): Remove cleanup.  Change return
10749         type.
10750         (solib_target_current_sos): Update.
10751
10752 2019-01-17  Tom Tromey  <tromey@bapiya>
10753
10754         * valprint.c: Replace "the the" with "the".
10755         * symtab.c: Replace "the the" with "the".
10756         * solib.c: Replace "the the" with "the".
10757         * solib-dsbt.c: Replace "the the" with "the".
10758         * linespec.c: Replace "the the" with "the".
10759         * dwarf2loc.h: Replace "the the" with "the".
10760         * amd64-windows-tdep.c: Replace "the the" with "the".
10761         * aarch64-tdep.c: Replace "the the" with "the".
10762
10763 2019-01-16  Keith Seitz  <keiths@redhat.com>
10764
10765         PR gdb/23773
10766         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10767         <builder>: Rename to ..
10768         <m_builder>: ... this and make private.
10769         (dwarf2_cu::get_builder): New method.  Change all users of
10770         `builder' to use this method.
10771         (dwarf2_start_symtab): Move to ...
10772         (dwarf2_cu::start_symtab): ... here.  Update all callers
10773         (setup_type_unit_groups): Move to ...
10774         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10775         callers.
10776         (dwarf2_cu::reset_builder): New method.
10777         (process_full_compunit, process_full_type_unit): Use
10778         dwarf2_cu::reset_builder.
10779         (follow_die_offset): Record the ancestor CU if it is different
10780         from the followed DIE's CU.
10781         (follow_die_sig_1): Likewise.
10782
10783 2019-01-15  Tom Tromey  <tom@tromey.com>
10784
10785         * remote.c (class remote_state) <buf>: Now a char_vector.
10786         <buf_size>: Remove.
10787         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10788         parameter.
10789         (remote_target::getpkt_or_notif_sane_1)
10790         (remote_target::getpkt_sane)
10791         (remote_target::getpkt_or_notif_sane): Likewise.
10792         (class remote_target) <putpkt>: New overload.
10793         (remote_target::read_frame): Change type of "buf_p".  Remove
10794         sizeof_p parameter.
10795         (packet_ok): New overload.
10796         (packet_check_result): New overload.
10797         Update all uses.
10798
10799 2019-01-14  Tom Tromey  <tom@tromey.com>
10800
10801         * remote-notif.c (handle_notification, remote_notif_ack)
10802         (remote_notif_parse): Make "buf" const.
10803         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10804         const.
10805         (remote_notif_parse, remote_notif_ack, handle_notification):
10806         Likewise.
10807         * remote.c (remote_notif_stop_parse): Make "buf" const.
10808         (remote_target::remote_parse_stop_reply): Make "buf" const.
10809         (remote_notif_stop_ack): Make "buf" const.
10810
10811 2019-01-14  Tom Tromey  <tom@tromey.com>
10812
10813         * remote.c (remote_console_output): Make parameter const.
10814
10815 2019-01-14  Tom Tromey  <tom@tromey.com>
10816
10817         * target-debug.h (target_debug_print_signals): Constify.
10818         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10819         * procfs.c (procfs_target::pass_signals): Update.
10820         * linux-nat.c (linux_nat_target::pass_signals): Update.
10821         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10822         * target-delegates.c: Rebuild.
10823         * remote.c (remote_target::program_signals): Update.
10824         (remote_target::pass_signals): Update.
10825         * target.c (target_pass_signals): Constify argument.
10826         (target_program_signals): Likewise.
10827         * target.h (struct target_ops) <pass_signals, program_signals>:
10828         Constify argument.
10829         (target_pass_signals, target_program_signals): Constify argument.
10830
10831 2019-01-14  Tom Tromey  <tom@tromey.com>
10832
10833         PR tui/28819:
10834         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10835
10836 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
10837
10838         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10839         field.
10840         * rs6000-tdep.c: Include reggroups.h.
10841         (IS_V_ALIAS_PSEUDOREG): Define.
10842         (rs6000_register_name): Return names for the "vX" aliases.
10843         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10844         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
10845         aliases.  Call default_register_reggroup_p for all other
10846         pseudo-registers.
10847         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10848         New functions.
10849         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10850         Handle "vX" aliases.
10851         (v_alias_pseudo_register_collect): New function.
10852         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10853         (rs6000_gdbarch_init): Initialize "vX" aliases as
10854         pseudo-registers.  Restore registration of
10855         rs6000_pseudo_register_reggroup_p with
10856         set_tdesc_pseudo_register_reggroup_p.
10857
10858 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
10859
10860         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10861         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10862         set_gdbarch_num_pseudo_regs.
10863
10864 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10865
10866         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10867         Remove arg prefixname, add do_set and do_show.
10868         Add member functions set_list and show_list.
10869         * cli/cli-style.c (class cli_style_option): Update accordingly.
10870         (style_set_list): Move to file scope.
10871         (style_show_list): Likewise.
10872         (set_style): Call help_list.
10873         (show_style): Call cmd_show_list.
10874         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10875         Update to use the new macro.
10876
10877 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
10878
10879         * ada-lang.c (_initialize_ada_language): Expand the help text
10880         for the "catch exception" command.
10881
10882 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10883
10884         * symtab.c (matching_obj_sections): Initialize obj,
10885         declare it closer to its usage.
10886
10887 2019-01-10  Tom Tromey  <tom@tromey.com>
10888
10889         * thread-iter.h (inf_threads_iterator): Use next_iterator.
10890         (basic_inf_threads_range): Remove.
10891         (inf_threads_range, inf_non_exited_threads_range)
10892         (safe_inf_threads_range): Use next_adapter.
10893
10894 2019-01-10  Keith Seitz  <keiths@redhat.com>
10895
10896         PR gdb/23712
10897         PR symtab/23010
10898         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10899         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10900
10901 2019-01-10  Keith Seitz  <keiths@redhat.com>
10902
10903         PR gdb/23712
10904         PR symtab/23010
10905         * dictionary.c (pending_to_vector): Remove.
10906         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10907         Remove _1 suffix, replacing functions of the same name.  Update
10908         all callers.
10909         (dict_create_hashed, dict_create_hashed_expandable)
10910         (dict_create_linear, dict_create_linear_expandable, dict_free)
10911         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10912         Make functions static.
10913
10914 2019-01-10  Keith Seitz  <keiths@redhat.com>
10915
10916         PR gdb/23712
10917         PR symtab/23010
10918         * dictionary.h (struct dictionary): Replace declaration with
10919         multidictionary.
10920         (dict_create_hashed, dict_create_hashed_expandable)
10921         (dict_create_linear, dict_create_linear_expandable)
10922         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10923         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10924         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10925         taking multidictionary argument.
10926         [ALL_DICT_SYMBOLS]: Update for multidictionary.
10927         * block.h (struct block) <dict>: Change to multidictionary
10928         and rename `multidict'.
10929         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
10930         symmisc.c: Update all dictionary references to multidictionary.
10931
10932 2019-01-10  Keith Seitz  <keiths@redhat.com>
10933
10934         PR gdb/23712
10935         PR symtab/23010
10936         * dictionary.c: Include unordered_map.
10937         (pending_to_vector): New function.
10938         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10939         Rewrite the non-"_1" functions to take vector instead
10940         of linked list.
10941         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
10942         "new" _1 versions of the same name.
10943         (multidictionary): Define.
10944         (std::hash<enum language): New definition.
10945         (collate_pending_symbols_by_language, mdict_create_hashed)
10946         (mdict_create_hashed_expandable, mdict_create_linear)
10947         (mdict_create_linear_expandable, mdict_free)
10948         (find_language_dictionary, create_new_language_dictionary)
10949         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
10950         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
10951         (mdict_size, mdict_empty): New functions.
10952         * dictionary.h (mdict_iterator): Define.
10953
10954 2019-01-10  Pedro Alves  <palves@redhat.com>
10955
10956         * breakpoint.c (read_uploaded_action)
10957         (create_tracepoint_from_upload): Adjust to use
10958         gdb::unique_xmalloc_ptr.
10959         * ctf.c (ctf_write_uploaded_tp):
10960         (SET_ARRAY_FIELD): Use emplace_back.
10961         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
10962         * tracefile-tfile.c (tfile_write_uploaded_tp):
10963         * tracepoint.c (parse_tracepoint_definition): Adjust to use
10964         gdb::unique_xmalloc_ptr.
10965         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
10966         at_string, cond_string, cmd_strings>: Replace char pointers
10967         with gdb::unique_xmalloc_ptr.
10968
10969 2019-01-10  Pedro Alves  <palves@redhat.com>
10970
10971         * solib-target.c (library_list_start_library): Don't xstrdup name.
10972
10973 2019-01-10  Pedro Alves  <palves@redhat.com>
10974
10975         * mdebugread.c (parse_partial_symbols): Use
10976         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
10977
10978 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10979
10980         * linux-fork.c (scoped_switch_fork_info)
10981         <~scoped_switch_fork_info>: Fix incorrect variable name.
10982
10983 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
10984
10985         * linux-fork.c (scoped_switch_fork_info)
10986         <scoped_switch_fork_info>: Make explicit.
10987         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
10988
10989 2019-01-10  Tom Tromey  <tom@tromey.com>
10990
10991         * objfiles.h (objfile::reset_psymtabs): Update.
10992         * objfiles.c (objfile::objfile): Update.
10993         * psymtab.h (psymtab_storage::obstack): Update.
10994         (psymtab_storage::m_obstack): Use gdb::optional.
10995         (class psymtab_storage): Update comment.  Remove objfile
10996         parameter.
10997         * psymtab.c (psymtab_storage::psymtab_storage): Update.
10998
10999 2019-01-10  Tom Tromey  <tom@tromey.com>
11000
11001         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11002         <free_psymtabs>: Now private.
11003         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11004         (allocate_psymtab): Use new method.
11005
11006 2019-01-10  Tom Tromey  <tom@tromey.com>
11007
11008         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11009         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11010         * mdebugread.c (parse_partial_symbols): Use
11011         allocate_dependencies.
11012         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11013         allocate_dependencies.
11014         (process_psymtab_comp_unit_reader)
11015         (build_type_psymtab_dependencies): Likewise.
11016         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11017
11018 2019-01-10  Tom Tromey  <tom@tromey.com>
11019
11020         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11021         PSYMBOL_SET_LANGUAGE.
11022         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11023
11024 2019-01-10  Tom Tromey  <tom@tromey.com>
11025
11026         * psymtab.h (psymtab_storage::obstack): New method.
11027         <m_obstack>: Rename from obstack; now private.
11028         * psymtab.c (psymtab_storage): Update.
11029         * dwarf2read.c (create_addrmap_from_index)
11030         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11031         Update.
11032
11033 2019-01-10  Tom Tromey  <tom@tromey.com>
11034
11035         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11036         * objfiles.h (objfile::reset_psymtabs): New method.
11037
11038 2019-01-10  Tom Tromey  <tom@tromey.com>
11039
11040         * symmisc.c (print_symbol_bcache_statistics): Update.
11041         (print_objfile_statistics): Update.
11042         * symfile.c (reread_symbols): Update.
11043         * psymtab.h (class psymtab_storage): New.
11044         * psymtab.c (psymtab_storage): New constructor.
11045         (~psymtab_storage): New destructor.
11046         (require_partial_symbols): Update.
11047         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11048         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11049         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11050         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11051         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11052         (start_psymtab_common, end_psymtab_common)
11053         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11054         (allocate_psymtab): Update.
11055         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11056         Update.
11057         (dump_psymtab_addrmap, maintenance_print_psymbols)
11058         (maintenance_check_psymtabs): Update.
11059         (class objfile_psymtabs): Move to objfiles.h.
11060         * psympriv.h (discard_psymtab): Now inline.
11061         (psymtab_discarder::psymtab_discarder): Update.
11062         (psymtab_discarder::~psymtab_discarder): Update.
11063         (ALL_OBJFILE_PSYMTABS): Rewrite.
11064         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11065         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11066         Remove fields.
11067         <partial_symtabs>: New field.
11068         (class objfile_psymtabs): Move from psymtab.h.  Update.
11069         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11070         psymbol_cache.
11071         (objfile::~objfile): Don't destroy psymbol_cache.
11072         * mdebugread.c (parse_partial_symbols): Update.
11073         * dwarf2read.c (create_addrmap_from_index)
11074         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11075         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11076         (add_partial_subprogram, dwarf2_ranges_read): Update.
11077         * dwarf-index-write.c (write_address_map)
11078         (write_one_signatured_type, recursively_write_psymbols)
11079         (class debug_names, class debug_names, write_psymtabs_to_index):
11080         Update.
11081
11082 2019-01-10  Tom Tromey  <tom@tromey.com>
11083
11084         * symtab.h (SYMBOL_SET_NAMES): Update.
11085         (symbol_set_names): Update.
11086         (MSYMBOL_SET_NAMES): Update.
11087         * symtab.c (symbol_set_names): Change argument to be an
11088         objfile_per_bfd_storage.
11089         * psymtab.c (add_psymbol_to_bcache): Update.
11090         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11091
11092 2019-01-10  Tom Tromey  <tom@tromey.com>
11093
11094         * symtab.c (create_demangled_names_hash): Change argument to be an
11095         objfile_per_bfd_storage.
11096         (symbol_set_names): Update.
11097
11098 2019-01-10  Tom Tromey  <tom@tromey.com>
11099
11100         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11101         init_psymbol_list.
11102         * psymtab.c (init_psymbol_list): Do nothing if already called.
11103         * psympriv.h (init_psymbol_list): Add comment.
11104         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11105         init_psymbol_list.
11106         * dbxread.c (dbx_symfile_read): Unconditionally call
11107         init_psymbol_list.
11108
11109 2019-01-10  Tom Tromey  <tom@tromey.com>
11110
11111         * xcoffread.c (scan_xcoff_symtab): Update.
11112         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11113         "where".
11114         * mdebugread.c (parse_partial_symbols)
11115         (handle_psymbol_enumerators): Update.
11116         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11117         * dbxread.c (read_dbx_symtab): Update.
11118         * psympriv.h (psymbol_placement): New enum.
11119         (add_psymbol_to_list): Update.
11120
11121 2019-01-10  Tom Tromey  <tom@tromey.com>
11122
11123         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11124         static_psymbols parameters.
11125         (scan_xcoff_symtab): Update.
11126         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11127         static_psymbols parameters.
11128         * psympriv.h (start_psymtab_common): Update.
11129         * mdebugread.c (parse_partial_symbols): Update.
11130         * dwarf2read.c (create_partial_symtab): Update.
11131         * dbxread.c (read_dbx_symtab): Update.
11132         (start_psymtab): Remove global_psymbols and static_psymbols
11133         parameters.
11134
11135 2019-01-10  Tom Tromey  <tom@tromey.com>
11136
11137         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11138         * psymtab.c (allocate_psymtab): Add comment.
11139         * psympriv.h (allocate_psymtab): Add comment.
11140         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11141         initializations.
11142         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11143
11144 2019-01-10  Tom Tromey  <tom@tromey.com>
11145
11146         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11147         Don't declare.
11148         * mipsread.c: Include mdebugread.h.
11149         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11150         Declare.
11151         * elfread.c: Include mdebugread.h.
11152
11153 2019-01-09  Tom Tromey  <tom@tromey.com>
11154
11155         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11156         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11157         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11158         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11159         (psym_lookup_symbol, psym_find_last_source_symtab)
11160         (psym_forget_cached_source_info, psym_print_stats)
11161         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11162         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11163         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11164         (psym_find_compunit_symtab_by_address)
11165         (maintenance_print_psymbols, maintenance_info_psymtabs)
11166         (maintenance_check_psymtabs): Use ranged for.
11167         * psymtab.h (class objfile_psymtabs): New.
11168         (require_partial_symbols): Return objfile_psymtabs.
11169         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11170
11171 2019-01-09  Tom Tromey  <tom@tromey.com>
11172
11173         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11174         (find_pc_mapped_section, list_overlays_command)
11175         (map_overlay_command, unmap_overlay_command)
11176         (simple_overlay_update): Use all_objfiles.
11177         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11178         * printcmd.c (info_symbol_command): Use all_objfiles.
11179         * objfiles.h (ALL_OBJSECTIONS): Remove.
11180         * maint.c (maintenance_translate_address): Use all_objfiles.
11181         * gcore.c (gcore_create_callback): Use all_objfiles.
11182         (objfile_find_memory_regions): Likewise.
11183
11184 2019-01-09  Tom Tromey  <tom@tromey.com>
11185
11186         * symtab.c (find_line_symtab, info_sources_command)
11187         (make_source_files_completion_list): Use objfile_compunits.
11188         * source.c (select_source_symtab): Use objfile_compunits.
11189         * objfiles.h (struct objfile): Update comment.
11190         (ALL_OBJFILES): Remove.
11191         (ALL_FILETABS): Remove.
11192         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11193         objfile_compunits.
11194
11195 2019-01-09  Tom Tromey  <tom@tromey.com>
11196
11197         * symmisc.c (print_objfile_statistics, dump_objfile)
11198         (maintenance_print_symbols): Use compunit_filetabs.
11199         * source.c (forget_cached_source_info_for_objfile): Use
11200         compunit_filetabs.
11201         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11202         (ALL_FILETABS): Use compunit_filetabs.
11203         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11204         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11205
11206 2019-01-09  Tom Tromey  <tom@tromey.com>
11207
11208         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11209         (compunit_filetabs): New.
11210         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11211         compunit_filetabs.
11212         (info_sources_command, make_source_files_completion_list): Remove
11213         declaration.
11214         * symmisc.c (print_objfile_statistics, dump_objfile)
11215         (maintenance_print_symbols): Remove declaration.
11216         (maintenance_info_symtabs): Use compunit_filetabs.
11217         (maintenance_info_line_tables): Likewise.
11218         * source.c (select_source_symtab): Change local variable name.
11219         (forget_cached_source_info_for_objfile): Remove declaration.
11220         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11221         * objfiles.c (objfile_relocate1): Remove declaration.
11222         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11223         declaration.
11224         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11225         * coffread.c (coff_symtab_read): Remove declaration.
11226         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11227         compunit_filetabs.
11228
11229 2019-01-09  Tom Tromey  <tom@tromey.com>
11230
11231         * symtab.c (lookup_objfile_from_block)
11232         (find_pc_sect_compunit_symtab, search_symbols)
11233         (default_collect_symbol_completion_matches_break_on): Use
11234         objfile_compunits.
11235         * objfiles.h (ALL_COMPUNITS): Remove.
11236         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11237         * cp-support.c (add_symbol_overload_list_qualified): Use
11238         objfile_compunits.
11239         * ada-lang.c (ada_collect_symbol_completion_matches)
11240         (ada_add_global_exceptions): Use objfile_compunits.
11241
11242 2019-01-09  Tom Tromey  <tom@tromey.com>
11243
11244         * source.c (select_source_symtab)
11245         (forget_cached_source_info_for_objfile): Remove declaration.
11246         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11247         declaration.
11248         * maint.c (count_symtabs_and_blocks): Remove declaration.
11249         * cp-support.c (add_symbol_overload_list_qualified): Remove
11250         declaration.
11251         * coffread.c (coff_symtab_read): Remove declaration.
11252         * symtab.c (lookup_symbol_in_objfile_symtabs)
11253         (basic_lookup_transparent_type_1): Use objfile_compunits.
11254         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11255         (info_sources_command, search_symbols)
11256         (default_collect_symbol_completion_matches_break_on)
11257         (make_source_files_completion_list): Remove declaration.
11258         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11259         (ada_collect_symbol_completion_matches)
11260         (ada_add_global_exceptions): Remove declaration.
11261         * linespec.c (iterate_over_all_matching_symtabs): Use
11262         objfile_compunits.
11263         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11264         (class objfile_compunits): New.
11265         (ALL_COMPUNITS): Use objfile_compunits.
11266         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11267         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11268         objfile_compunits.
11269         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11270
11271 2019-01-09  Tom Tromey  <tom@tromey.com>
11272
11273         * symtab.c (search_symbols)
11274         (default_collect_symbol_completion_matches_break_on): Use
11275         objfile_msymbols.
11276         * ada-lang.c (ada_lookup_simple_minsym)
11277         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11278         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11279         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11280         objfile_msymbols.
11281         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11282         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11283         * objc-lang.c (find_methods): Use objfile_msymbols.
11284         (info_selectors_command, info_classes_command): Likewise.
11285         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11286         * objfiles.h (class objfile_msymbols): New.
11287         (ALL_OBJFILE_MSYMBOLS): Remove.
11288         (ALL_MSYMBOLS): Remove.
11289
11290 2019-01-09  Tom Tromey  <tom@tromey.com>
11291
11292         * common/next-iterator.h (next_adapter): Add Iterator template
11293         parameter.
11294         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11295         (class all_objfiles_safe): New.
11296         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11297         * objfiles.c (put_objfile_before): Update comment.
11298         (add_separate_debug_objfile): Likewise.
11299         (free_all_objfiles): Use all_objfiles_safe.
11300         (objfile_purge_solibs): Likewise.
11301
11302 2019-01-09  Tom Tromey  <tom@tromey.com>
11303
11304         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11305         (expand_symtab_containing_pc, lookup_static_symbol)
11306         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11307         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11308         all_objfiles.
11309         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11310         * breakpoint.c (create_overlay_event_breakpoint)
11311         (create_longjmp_master_breakpoint)
11312         (create_std_terminate_master_breakpoint)
11313         (create_exception_master_breakpoint): Use all_objfiles.
11314         * linux-thread-db.c (try_thread_db_load_from_pdir)
11315         (has_libpthread): Use all_objfiles.
11316         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11317         * linespec.c (iterate_over_all_matching_symtabs)
11318         (search_minsyms_for_name): Use all_objfiles.
11319         * maint.c (maintenance_info_sections): Use all_objfiles.
11320         * main.c (captured_main_1): Use all_objfiles.
11321         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11322         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11323         * guile/scm-pretty-print.c
11324         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11325         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11326         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11327         (maintenance_print_msymbols): Use all_objfiles.
11328         * source.c (select_source_symtab): Use all_objfiles.
11329         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11330         * symfile.c (remove_symbol_file_command)
11331         (expand_symtabs_matching, map_symbol_filenames): Use
11332         all_objfiles.
11333         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11334         all_objfiles.
11335         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11336         * objc-lang.c (find_methods): Use all_objfiles.
11337         * objfiles.c (have_partial_symbols, have_full_symbols)
11338         (have_minimal_symbols, qsort_cmp)
11339         (default_iterate_over_objfiles_in_search_order): Use
11340         all_objfiles.
11341         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11342         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11343         (maintenance_check_psymtabs): Use all_objfiles.
11344         (ALL_PSYMTABS): Remove.
11345         * compile/compile-object-run.c (do_module_cleanup): Use
11346         all_objfiles.
11347         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11348         * cp-support.c (add_symbol_overload_list_qualified): Use
11349         all_objfiles.
11350         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11351         Use all_objfiles.
11352         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11353         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11354         all_objfiles.
11355         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11356         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11357         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11358         Uses all_objfiles.
11359         * solib.c (solib_read_symbols): Use all_objfiles
11360
11361 2019-01-09  Tom Tromey  <tom@tromey.com>
11362
11363         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11364         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11365         all_objfiles.
11366         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11367         * symmisc.c (print_symbol_bcache_statistics)
11368         (print_objfile_statistics, maintenance_print_objfiles)
11369         (maintenance_info_symtabs, maintenance_check_symtabs)
11370         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11371         all_objfiles.
11372         * source.c (forget_cached_source_info): Use all_objfiles.
11373         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11374         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11375         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11376         * objfiles.c (update_section_map): Use all_objfiles.
11377         (shared_objfile_contains_address_p): Likewise.
11378         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11379         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11380
11381 2019-01-09  Tom Tromey  <tom@tromey.com>
11382
11383         * common/next-iterator.h: New file.
11384         * objfiles.h (class all_objfiles): New.
11385         (struct objfile_iterator): New.
11386
11387 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11388
11389         * NEWS: Move the description of the changed "frame", "select-frame",
11390          and "info frame" commands to the Changed commands section.
11391
11392 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11393
11394         * gdbtypes.c (check_stub_method_group): Remove handling of old
11395         mangling schemes.
11396         * linespec.c (find_methods): Likewise.
11397         * stabsread.c (read_member_functions): Likewise.
11398         * valops.c (search_struct_method): Likewise.
11399         (value_struct_elt_for_reference): Likewise.
11400         * NEWS: Mention this change.
11401
11402 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11403
11404         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11405         print_source_lines.
11406         * source.c (print_source_lines_base): Update line number check.
11407         (print_source_lines): New function.
11408         (source_lines_range::source_lines_range): New function.
11409         * source.h (class source_lines_range): New class.
11410         (print_source_lines): New declaration.
11411
11412 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11413
11414         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11415
11416 2019-01-08  Tom Tromey  <tom@tromey.com>
11417             Simon Marchi  <simon.marchi@ericsson.com>
11418
11419         PR gdb/24060
11420         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11421         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11422         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11423         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11424         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11425         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11426
11427 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11428
11429         * source.c (select_source_symtab): Move header comment to
11430         declaration in source.h.
11431         (forget_cached_source_info_for_objfile): Likewise.
11432         (forget_cached_source_info): Likewise.
11433         (identify_source_line): Likewise.
11434         * source.h (identify_source_line): Move declaration from symtab.h
11435         and add comment from source.c
11436         (print_source_lines): Likewise.
11437         (forget_cached_source_info_for_objfile): Likewise.
11438         (forget_cached_source_info): Likewise.
11439         (select_source_symtab): Likewise.
11440         (enum print_source_lines_flag): Move definition from symtab.h.
11441         * symtab.h (identify_source_line): Move declaration to source.h.
11442         (print_source_lines): Likewise.
11443         (forget_cached_source_info_for_objfile): Likewise.
11444         (forget_cached_source_info): Likewise.
11445         (select_source_symtab): Likewise.
11446         (enum print_source_lines_flag): Move definition to source.h.
11447         * tui/tui-hooks.c: Add 'source.h' include.
11448
11449 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11450
11451         * source.c (print_source_lines_base): Handle requests to print
11452         reverse line number sequences, and guard against empty lines
11453         string.
11454
11455 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11456
11457         * source.c (print_source_lines_base): Fix skip of '\r' if next
11458         character is '\n'.
11459
11460 2019-01-06  Tom Tromey  <tom@tromey.com>
11461
11462         * c-exp.y (struct c_parse_state) <macro_original_text,
11463         expansion_obstack>: New member.
11464         (macro_original_text, expansion_obstack): Remove globals.
11465         (scan_macro_expansion, scanning_macro_expansion)
11466         (finished_macro_expansion): Update.
11467         (scan_macro_cleanup): Remove.
11468         (yylex, c_parse): Update.
11469
11470 2019-01-06  Tom Tromey  <tom@tromey.com>
11471
11472         * c-exp.y (struct c_parse_state) <strings>: New member.
11473         (operator_stoken): Update.
11474
11475 2019-01-06  Tom Tromey  <tom@tromey.com>
11476
11477         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11478         (union type_stack_elt) <typelist_val>: Now a pointer to
11479         std::vector.
11480         (type_stack_cleanup): Don't declare.
11481         (push_typelist): Update.
11482         * parse.c (pop_typelist): Return a std::vector.
11483         (push_typelist): Take a std::vector.
11484         (follow_types): Update.  Do not free args.
11485         (type_stack_cleanup): Remove.
11486         * c-exp.y (struct c_parse_state): New.
11487         (cpstate): New global.
11488         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11489         (nonempty_typelist): Update.
11490         (func_mod): Create a new vector.
11491         (c_parse): Create a c_parse_state.
11492         (check_parameter_typelist): Do not delete params.
11493         (function_method): Update.  Do not delete type_list.
11494
11495 2019-01-06  Tom Tromey  <tom@tromey.com>
11496
11497         PR gdb/28155:
11498         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11499         check_typedef.
11500         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11501         (print_return_value): Likewise.
11502
11503 2019-01-05  Tom Tromey  <tom@tromey.com>
11504
11505         * contrib/cleanup_check.py: Remove.
11506         * contrib/gcc-with-excheck: Remove.
11507         * contrib/exsummary.py: Remove.
11508         * contrib/excheck.py: Remove.
11509
11510 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11511
11512         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11513         NULL. Initialize tpprev to NULL instead of assigning it
11514         to NULL on the next statement.
11515         * windows-nat.c (windows_delete_thread): Remove check for
11516         main_thread_id before printing thread exit notifications.
11517         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11518         Remove thread ID check against main_thread_id.
11519         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11520         windows_delete_thread.
11521         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11522
11523 2019-01-04  Tom Tromey  <tom@tromey.com>
11524
11525         * compile/compile.c (_initialize_compile): Use upper case for
11526         metasyntactic variables.
11527         * symmisc.c (_initialize_symmisc): Use upper case for
11528         metasyntactic variables.
11529         * psymtab.c (_initialize_psymtab): Use upper case for
11530         metasyntactic variables.
11531         * demangle.c (demangle_command): Use upper case for metasyntactic
11532         variables.
11533         (_initialize_demangler): Likewise.
11534         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11535         variables.
11536
11537 2019-01-03  Tom Tromey  <tom@tromey.com>
11538
11539         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11540
11541 2019-01-03  Tom Tromey  <tom@tromey.com>
11542
11543         * python/py-symtab.c (salpy_str): Update.
11544         (struct salpy_sal_object) <symtab>: Now a PyObject.
11545         (salpy_dealloc): Update.
11546         (del_objfile_sal): Use gdbpy_ref.
11547
11548 2019-01-03  Tom Tromey  <tom@tromey.com>
11549
11550         * python/py-type.c (convert_field): Use new_reference.  Return
11551         gdbpy_ref.
11552         (make_fielditem): Return gdbpy_ref.
11553         (typy_fields): Update.
11554         (typy_getitem): Update.
11555         (field_name): Return gdbpy_ref.  Use new_reference.
11556         (typy_iterator_iternext): Update.
11557
11558 2019-01-03  Tom Tromey  <tom@tromey.com>
11559
11560         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11561
11562 2019-01-03  Tom Tromey  <tom@tromey.com>
11563
11564         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11565         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11566         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11567         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11568         (pspy_set_type_printers): Likewise.
11569         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11570         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11571         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11572         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11573         (objfpy_set_type_printers): Likewise.
11574
11575 2019-01-03  Tom Tromey  <tom@tromey.com>
11576
11577         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11578         (gdbpy_print_stack): Use gdbpy_err_fetch.
11579         * python/python-internal.h (class gdbpy_err_fetch): New class.
11580         (class gdbpy_enter) <m_error_type, m_error_value,
11581         m_error_traceback>: Remove.
11582         <m_error>: New member.
11583         (gdbpy_exception_to_string): Don't declare.
11584         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11585         * python/py-value.c (convert_value_from_python): Use
11586         gdbpy_err_fetch.
11587         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11588         gdbpy_exception_to_string.
11589         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11590         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11591         gdbpy_err_fetch.
11592
11593 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11594
11595         * linux-nat.c (delete_lwp_cleanup): Delete.
11596         (struct lwp_deleter): New struct.
11597         (lwp_info_up): New typedef.
11598         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11599         lwp_info_up.
11600
11601 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11602
11603         * linux-fork.c (class scoped_switch_fork_info): New class.
11604         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11605
11606 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11607
11608         * valops.c (find_overload_match): Remove use of null_cleanup, and
11609         calls to do_cleanups.
11610
11611 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11612
11613         * compile/compile-cplus-types.c
11614         (compile_cplus_instance::decl_name): Handle changes to
11615         cp_func_name.
11616         * cp-support.c (cp_func_name): Update header comment, update
11617         return type.
11618         * cp-support.h (cp_func_name): Update return type in declaration.
11619         * valops.c (find_overload_match): Move temp_func local to top
11620         level of function and change its type.  Use temp_func to hold and
11621         delete temporary string obtained from cp_func_name.
11622
11623 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11624
11625         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11626         gdb::char_vector, remove cleanup, and update uses of `msg`.
11627
11628 2019-01-03  Jim Wilson  <jimw@sifive.com>
11629
11630         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11631
11632 2019-01-02  Tom Tromey  <tom@tromey.com>
11633
11634         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11635         (tdesc_parse_xml): Remove cleanups.
11636         * target-descriptions.h (make_cleanup_free_target_description):
11637         Don't declare.
11638         (target_desc_deleter): New struct.
11639         (target_desc_up): New typedef.
11640         * target-descriptions.c (target_desc_deleter::operator()): Rename
11641         from free_target_description.
11642         (make_cleanup_free_target_description): Remove.
11643
11644 2019-01-02  Tom Tromey  <tom@tromey.com>
11645
11646         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11647         constructor, destructor.
11648         (linespec_parser): Remove typedef.
11649         (~linespec_parser): Rename from linespec_parser_delete.
11650         (linespec_lex_to_end, linespec_complete_label)
11651         (linespec_complete): Update.
11652         (decode_line_full): Remove cleanups.
11653         (decode_line_1): Update.
11654
11655 2019-01-02  Tom Tromey  <tom@tromey.com>
11656
11657         * python/python-internal.h (inferior_to_inferior_object): Change
11658         return type.
11659         * python/py-exitedevent.c (create_exited_event_object): Update.
11660         * python/py-inferior.c (inferior_to_inferior_object): Return
11661         gdbpy_ref.
11662         (python_new_inferior, python_inferior_deleted)
11663         (thread_to_thread_object, delete_thread_object)
11664         (build_inferior_list, gdbpy_selected_inferior): Update.
11665         * python/py-infthread.c (create_thread_object): Update.  Also fail
11666         if inferior_to_inferior_object fails.
11667
11668 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11669
11670         * inferior.h (class inferior) <displaced_step_state>: New field.
11671         * infrun.h (struct displaced_step_state): Move here from
11672         infrun.c.  Initialize fields, add constructor.
11673         <inf>: Remove field.
11674         <reset>: New method.
11675         * infrun.c (struct displaced_step_inferior_state): Move to
11676         infrun.h.
11677         (displaced_step_inferior_states): Remove.
11678         (get_displaced_stepping_state): Adust.
11679         (displaced_step_in_progress_any_inferior): Adjust.
11680         (displaced_step_in_progress_thread): Adjust.
11681         (displaced_step_in_progress): Adjust.
11682         (add_displaced_stepping_state): Remove.
11683         (get_displaced_step_closure_by_addr): Adjust.
11684         (remove_displaced_stepping_state): Remove.
11685         (infrun_inferior_exit): Call displaced_step_state.reset.
11686         (use_displaced_stepping): Don't check for NULL.
11687         (displaced_step_prepare_throw): Call
11688         get_displaced_stepping_state.
11689         (displaced_step_fixup): Don't check for NULL.
11690         (prepare_for_detach): Don't check for NULL.
11691
11692 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11693
11694         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11695          in case of call that did not complete.
11696
11697 2019-01-02  Andrey Utkin  <autkin@undo.io>
11698
11699         * symfile.c (find_separate_debug_file): Fix search of debug files for
11700         remote debuggee.
11701
11702 2019-01-02  Tom Tromey  <tom@tromey.com>
11703
11704         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11705         indentation.
11706         * python/py-frame.c (frapy_older): Remove cast.
11707         (frapy_newer): Likewise.
11708         * python/py-breakpoint.c (local_setattro): Remove cast.
11709         * python/py-arch.c (archpy_name): Remove local variable.
11710         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11711
11712 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11713
11714         * unittests/basic_string_view/element_access/char/empty.cc:
11715         Fix year range in copyright header.
11716
11717 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11718
11719         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11720         Delete.
11721         <operator==>: Update with for removed field.
11722         <hash>: Likewise.
11723         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11724         <isa_features>: ...this.
11725         <abi_features>: New field.
11726         (riscv_isa_flen): Update comment.
11727         (riscv_abi_xlen): New declaration.
11728         (riscv_abi_flen): New declaration.
11729         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11730         isa_features.
11731         (riscv_abi_xlen): New function.
11732         (riscv_isa_flen): Update to get answer from isa_features.
11733         (riscv_abi_flen): New function.
11734         (riscv_has_fp_abi): Update to get answer from abi_features.
11735         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11736         xlen and flen.
11737         (riscv_call_info) <xlen, flen>: Update comment.
11738         (riscv_call_arg_struct): Remove invalid assertions
11739         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11740         is removed.
11741         (riscv_gdbarch_init): Gather isa features and abi features
11742         separately, ensure both match on the gdbarch when reusing an old
11743         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11744         a target with 64-bit float hardware.
11745
11746 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11747
11748         * source.c (search_command_helper): Stop reverse search
11749         when line 1 has been searched.
11750
11751 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11752
11753         * record-full.c (record_full_base_target::close): Rewrite
11754         record_full_core_buf_list free logic.
11755
11756 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11757
11758         * break-catch-syscall.c (print_one_catch_syscall): xfree
11759         the last text.
11760
11761 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11762
11763         * top.c (print_gdb_version): Update Copyright year in version
11764         message.
11765
11766 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11767
11768         Update copyright year range in all GDB files.
11769
11770 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11771
11772         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11773
11774 For older changes see ChangeLog-2018.
11775 \f
11776 Local Variables:
11777 mode: change-log
11778 left-margin: 8
11779 fill-column: 74
11780 version-control: never
11781 coding: utf-8
11782 End:
11783