gdb/ChangeLog

   1 2019-12-04  Tom Tromey  <tromey@adacore.com>
   2
   3         * dwarf2read.c (dwarf2_init_float_type)
   4         (dwarf2_init_complex_target_type): Add byte_order parameter.
   5         (read_base_type): Compute byte order earlier.
   6         * gdbtypes.c (init_float_type): Add byte_order parameter.
   7         * gdbtypes.h (init_float_type): Add byte_order parameter.
   8
   9 2019-12-04  Tom Tromey  <tromey@adacore.com>
  10
  11         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
  12
  13 2019-12-04  Tom Tromey  <tromey@adacore.com>
  14
  15         * dwarf2read.c (process_structure_scope): Initialize
  16         "discr_offset".
  17
  18 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
  19
  20         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
  21         add it into the search spec.
  22         (parse_max_results_option): New function.
  23         (mi_info_functions_or_variables): Parse -max-results flag and pass
  24         it to mi_symbol_info.
  25         (mi_cmd_symbol_info_modules): Likewise.
  26         (mi_cmd_symbol_info_types): Likewise.
  27         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
  28         return type to bool, change result container into a set, and don't
  29         add new results if we have enough already.
  30         (global_symbol_searcher::add_matching_msymbols): Change return
  31         type to bool, and don't add new results if we have enough already.
  32         (sort_search_symbols_remove_dups): Delete.
  33         (global_symbol_searcher::search): Early exit from search loop when
  34         we have enough results.  Use a std::set to collect the results
  35         from calling add_matching_symbols.
  36         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
  37         member function.
  38         (global_symbol_searcher) <m_max_search_results>: New member
  39         variable.
  40         (global_symbol_searcher) <add_matching_symbols>: Update header
  41         comment and change return type to bool.
  42         (global_symbol_searcher) <add_matching_msymbols>: Update header
  43         comment and change return type to bool.
  44
  45 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
  46
  47         * symtab.c (symbol_search::compare_search_syms): Update header
  48         comment.
  49         (global_symbol_searcher::is_suitable_msymbol): New function.
  50         (global_symbol_searcher::expand_symtabs): New function.
  51         (global_symbol_searcher::add_matching_symbols): New function.
  52         (global_symbol_searcher::add_matching_msymbols): New function.
  53         (global_symbol_searcher::search): Move most of the content
  54         into the new functions above, and call them as needed.
  55         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
  56         function.
  57         (global_symbol_searcher) <add_matching_symbols>: New member
  58         function.
  59         (global_symbol_searcher) <add_matching_msymbols>: New member
  60         function.
  61         (global_symbol_searcher) <is_suitable_msymbol>: New member
  62         function.
  63
  64 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
  65
  66         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
  67         -symbol-info-module-variables entries.
  68         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
  69         (mi_cmd_symbol_info_module_variables): Declare.
  70         * mi/mi-symbol-cmds.c
  71         (module_symbol_search_iterator): New typedef.
  72         (output_module_symbols_in_single_module_and_file): New function.
  73         (output_module_symbols_in_single_module): New function.
  74         (mi_info_module_functions_or_variables): New function.
  75         (mi_cmd_symbol_info_module_functions): New function.
  76         (mi_cmd_symbol_info_module_variables): New function.
  77         * NEWS: Mention new MI command.
  78
  79 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
  80
  81         * bcache.c (hash): Remove.
  82         (hash_continue): Remove.
  83         * bcache.h (hash): Remove.
  84         (hash_continue): Remove.
  85         (struct bcache) <ctor>: Update.
  86         * psymtab.c (psymbol_hash): Update.
  87         * stabsread.c (hashname): Update.
  88         * utils.h (fast_hash): Add an argument for a start value,
  89         defaulting to zero.
  90
  91 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  92         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
  93         (destroy_block_symbol_cache): New function.
  94         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
  95         (resize_symbol_cache): Likewise.
  96
  97 2019-12-02  Tom Tromey  <tom@tromey.com>
  98
  99         * unittests/tui-selftests.c (run_tests): Make conditional.
 100         (_initialize_tui_selftest): Make conditional.
 101
 102 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 103
 104         * aix-thread.c (debug_aix_thread): Change type to bool.
 105
 106 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 107
 108         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 109
 110 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 111
 112         * dwarf2read.c (read_tag_string_type): Read the fields required to
 113         make a dynamic string, and possibly create a dynamic range for the
 114         string.
 115         (attr_to_dynamic_prop): Setup is_reference based on the type of
 116         attribute being processed.
 117         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 118         (resolve_dynamic_array): Rename to...
 119         (resolve_dynamic_array_or_string): ...this, update header comment,
 120         and accept TYPE_CODE_STRING.
 121         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 122
 123 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 124
 125         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 126         of its implementation from...
 127         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 128         the new function.
 129
 130 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 133         create a range with stride where appropriate.
 134         * f-valprint.c: Include 'gdbarch.h'.
 135         (f77_print_array_1): Take the stride into account when walking the
 136         array.  Also convert the stride into addressable units.
 137         * gdbtypes.c (create_range_type): Initialise the stride to
 138         constant zero.
 139         (create_range_type_with_stride): New function, initialise the
 140         range as normal, and then setup the stride.
 141         (has_static_range): Include the stride here.  Also change the
 142         return type to bool.
 143         (create_array_type_with_stride): Consider the range stride if the
 144         array isn't given its own stride.
 145         (resolve_dynamic_range): Resolve the stride if needed.
 146         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 147         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 148         (TYPE_BIT_STRIDE): Define.
 149         (TYPE_ARRAY_BIT_STRIDE): Define.
 150         (create_range_type_with_stride): Declare.
 151         * valarith.c (value_subscripted_rvalue): Take range stride into
 152         account when walking the array.
 153
 154 2019-12-01  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 157         specially.
 158
 159 2019-12-01  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 162         \0.
 163         * unittests/tui-selftests.c: New file.
 164         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 165
 166 2019-12-01  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 169
 170 2019-12-01  Tom Tromey  <tom@tromey.com>
 171
 172         * NEWS: Document new settings.
 173         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 174         * tui/tui-win.c (_initialize_tui_win): Add border style
 175         observers.
 176         * tui/tui-io.h (tui_apply_style): Declare.
 177         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 178         longer static.
 179         (apply_ansi_escape, tui_set_reverse_mode): Update.
 180         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 181         Add "skip_intensity" parameter.
 182         <changed>: New member.
 183         <do_set_value>: Declare.
 184         (tui_border_style, tui_active_border_style): Declare.
 185         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 186         globals.
 187         (cli_style_option): Initialize "changed".
 188         (cli_style_option::do_set_value): New function.
 189         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 190         parameter.  Update.
 191         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 192         (_initialize_cli_style): Update.  Create TUI border style
 193         commands.
 194
 195 2019-12-01  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 198         parameter.
 199         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 200         parameter.
 201         * tui/tui-win.h (compact_source): Declare.
 202         * tui/tui-win.c (compact_source): New global.
 203         (tui_set_compact_source, tui_show_compact_source): New functions.
 204         (_initialize_tui_win): Add "compact-source" setting.
 205         * tui/tui-source.c (tui_source_window::set_contents): Handle
 206         compact_source setting.
 207         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 208         * NEWS: Document new setting.
 209
 210 2019-11-30  Tom Tromey  <tom@tromey.com>
 211
 212         * dwarf2read.c (dwarf2_add_field): Include field offset when
 213         computing variant part length.
 214
 215 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 216         * NEWS:  Mention define-prefix.  Tell that command names can now
 217         contain a . character.
 218
 219 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 220
 221         * command.h (valid_cmd_char_p): Declare.
 222         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 223         the check of valid command char.
 224         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 225         valid_cmd_char_p.
 226         * cli/cli-script.c (validate_comname): Likewise.
 227         * completer.c (gdb_completer_command_word_break_characters):
 228         Do not remove . from the word break char, update comments.
 229         (complete_line_internal_1): Use valid_cmd_char_p.
 230         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 231         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 232
 233 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 234
 235         * cli/cli-script.c (do_define_command): Ensure a redefined
 236         prefix command is kept as a prefix command.
 237         (define_prefix_command): New function.
 238         (show_user_1): Report user defined prefixes.
 239         (_initialize_cli_script):  Create the new 'define-prefix' command.
 240         Add completers for 'define' and 'document'.
 241         * top.c (execute_command):  If command is a user-defined prefix only
 242         command, report the list of commands for this prefix command.
 243
 244 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 245
 246         * valops.c (find_oload_champ): Improve debug output.
 247
 248 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 249
 250         * valops.c (find_oload_champ): Print part of debug messages
 251         before the badness vector is std::move'd.
 252
 253 2019-11-28  Tom Tromey  <tom@tromey.com>
 254
 255         * value.c (creal_internal_fn): Fix comment.
 256
 257 2019-11-28  Tom Tromey  <tom@tromey.com>
 258
 259         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 260         flag_bound_evaluated>: Now unsigned.
 261
 262 2019-11-28  Tom Tromey  <tom@tromey.com>
 263
 264         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 265         declare.
 266
 267 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 268
 269         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 270         debug output.
 271         * jit.c (jit_unregister_code): Add debug print to match
 272         `jit_register_code`.
 273
 274 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 275
 276         * NEWS: Mention the new multithreaded symbol loading.
 277
 278 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 279
 280         * maint.c (n_worker_threads): Default to 0.
 281         (worker_threads_disabled): New function.
 282         * maint.h (worker_threads_disabled): New function.
 283         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 284         here if worker_threads_disabled () is true.
 285         (minimal_symbol_reader::install): Skip all threading if
 286         worker_threads_disabled () is true.
 287
 288 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 289
 290         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 291         hash code if possible.
 292         (add_minsym_to_demangled_hash_table): Likewise.
 293         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 294         on the background thread.
 295         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 296         Add these fields.
 297
 298 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 299
 300         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 301         of the mangled name on the background thread.
 302         * symtab.c (symbol_set_names): Allow passing in the hash of the
 303         linkage_name.
 304         * symtab.h (symbol_set_names): Likewise.
 305
 306 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 307
 308         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 309         physnames are computed for inherited DIEs.
 310
 311 2019-11-27  Tom Tromey  <tromey@adacore.com>
 312
 313         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 314         backslashes.
 315         * cp-support.c: Remove unnecessary backslashes.
 316
 317 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 318
 319         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 320         with sym->set_linkage_name.
 321         * coffread.c (coff_read_enum_type): Likewise.
 322         * mdebugread.c (parse_symbol): Likewise.
 323         * stabsread.c (patch_block_stabs): Likewise.
 324         (define_symbol): Likewise.
 325         (read_enum_type): Likewise.
 326         (common_block_end): Likewise.
 327         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 328         function.
 329         (SYMBOL_SET_LINKAGE_NAME): Remove.
 330         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 331         with sym->set_linkage_name.
 332
 333 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 334
 335         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 336         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 337         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 338         * NEWS: Mention new MI command.
 339
 340 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 341
 342         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 343         '-symbol-info-types', and '-symbol-info-variables'.
 344         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 345         (mi_cmd_symbol_info_types): Declare.
 346         (mi_cmd_symbol_info_variables): Declare.
 347         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 348         (output_debug_symbol): New function.
 349         (output_nondebug_symbol): New function.
 350         (mi_symbol_info): New function.
 351         (mi_info_functions_or_variables): New function.
 352         (mi_cmd_symbol_info_functions): New function.
 353         (mi_cmd_symbol_info_types): New function.
 354         (mi_cmd_symbol_info_variables): New function.
 355         * NEWS: Mention new commands.
 356
 357 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 358
 359         * symtab.c (symbol_to_info_string): New function, most content
 360         moved from print_symbol_info, but updated to return a std::string.
 361         (print_symbol_info): Update to use symbol_to_info_string and print
 362         returned string.
 363         * symtab.h (symbol_to_info_string): Declare new function.
 364
 365 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 366
 367         * python/python.c (gdbpy_rbreak): Convert to using
 368         global_symbol_searcher.
 369         * symtab.c (file_matches): Convert return type to bool, change
 370         file list to std::vector, update header comment.
 371         (search_symbols): Rename to...
 372         (global_symbol_searcher::search): ...this and update now its
 373         a member function of global_symbol_searcher.  Take account of the
 374         changes to file_matches.
 375         (symtab_symbol_info): Convert to using global_symbol_searcher.
 376         (rbreak_command): Likewise.
 377         (search_module_symbols): Likewise.
 378         * symtab.h (enum symbol_search): Update comment.
 379         (search_symbols): Remove declaration.
 380         (class global_symbol_searcher): New class.
 381
 382 2019-11-26  Tom Tromey  <tromey@adacore.com>
 383
 384         * cp-support.c (_initialize_cp_support): Conditionally initialize
 385         gdb_demangle_attempt_core_dump.
 386
 387 2019-11-26  Tom Tromey  <tom@tromey.com>
 388
 389         * python/py-function.c (fnpy_init): Update.
 390         * value.h (add_internal_function): Adjust declaration.
 391         * value.c (function_destroyer): Remove.
 392         (do_add_internal_function): Don't set destroyer or copy name.
 393         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 394         Set name_allocated.
 395         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 396         (cmdpy_init): Set name_allocated.
 397         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 398         member.
 399         (~cmd_list_element): Free "name" if needed.
 400
 401 2019-11-26  Tom Tromey  <tom@tromey.com>
 402
 403         * value.h (add_internal_function): Add new overload.  Move
 404         documentation from value.h.
 405         * value.c (do_add_internal_function): New function.
 406         (add_internal_function): Use it.  Add new overload.
 407         (function_destroyer): Don't free doc.
 408         * python/py-function.c (fnpy_init): Update.
 409
 410 2019-11-26  Tom Tromey  <tom@tromey.com>
 411
 412         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 413         (cmdpy_init): Set "doc_allocated".
 414
 415 2019-11-26  Tom Tromey  <tom@tromey.com>
 416
 417         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 418         name of worker thread.
 419         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 420         pthread_setname_np.
 421         * configure, config.in: Rebuild.
 422
 423 2019-11-26  Tom Tromey  <tom@tromey.com>
 424
 425         * python/python.c (class gdbpy_gil): New.
 426         (struct gdbpy_event): Add constructor, destructor, operator().
 427         (gdbpy_post_event): Use run_on_main_thread.
 428         (gdbpy_initialize_events): Remove.
 429         (do_start_initialization): Update.
 430
 431 2019-11-26  Tom Tromey  <tom@tromey.com>
 432
 433         * NEWS: Add entry.
 434         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 435         commands.  Call update_thread_pool_size.
 436         (update_thread_pool_size, maintenance_set_worker_threads): New
 437         functions.
 438         (n_worker_threads): New global.
 439
 440 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 441             Tom Tromey  <tom@tromey.com>
 442
 443         * minsyms.c (minimal_symbol_reader::install): Use
 444         parallel_for_each.
 445         * gdbsupport/parallel-for.h: New file.
 446         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 447
 448 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 449             Tom Tromey  <tom@tromey.com>
 450
 451         * gdbsupport/thread-pool.h: New file.
 452         * gdbsupport/thread-pool.c: New file.
 453         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 454         (HFILES_NO_SRCDIR): Add thread-pool.h.
 455
 456 2019-11-26  Tom Tromey  <tom@tromey.com>
 457
 458         * event-top.h (thread_local_segv_handler): Declare.
 459         * event-top.c (thread_local_segv_handler): New global.
 460         (install_handle_sigsegv, handle_sigsegv): New functions.
 461         (async_init_signals): Install SIGSEGV handler.
 462         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 463         thread-local.
 464         (report_failed_demangle): New function.
 465         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 466         handler-setting code, instead use segv_handler.  Run warning code
 467         on main thread.
 468
 469 2019-11-26  Tom Tromey  <tom@tromey.com>
 470
 471         * run-on-main-thread.c: New file.
 472         * run-on-main-thread.h: New file.
 473         * unittests/main-thread-selftests.c: New file.
 474         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 475         main-thread-selftests.c.
 476         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 477         (COMMON_SFILES): Add run-on-main-thread.c.
 478
 479 2019-11-26  Tom Tromey  <tom@tromey.com>
 480
 481         * main.c (setup_alternate_signal_stack): Remove.
 482         (captured_main_1): Use gdb::alternate_signal_stack.
 483         * gdbsupport/alt-stack.h: New file.
 484
 485 2019-11-26  Tom Tromey  <tom@tromey.com>
 486
 487         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 488         Remove comment.
 489         (save_original_signals_state, restore_original_signals_state): Use
 490         gdb_sigmask.
 491         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 492         (_initialize_linux_nat): Use gdb_sigmask.
 493         * guile/guile.c (_initialize_guile): Use block_signals.
 494         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 495         * gdbsupport/gdb-sigmask.h: New file.
 496         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 497         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 498         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 499         pthread_sigmask.
 500         * configure, config.in: Rebuild.
 501         * gdbsupport/block-signals.h: New file.
 502
 503 2019-11-26  Tom Tromey  <tom@tromey.com>
 504
 505         * acinclude.m4: Include ax_pthread.m4.
 506         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 507         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 508         (CLIBS): Use PTHREAD_LIBS.
 509         (aclocal_m4_deps): Add ax_pthread.m4.
 510         * config.in, configure: Rebuild.
 511         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 512
 513 2019-11-26  Tom Tromey  <tom@tromey.com>
 514
 515         * symtab.h (struct minimal_symbol) <name_set>: New member.
 516         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 517         Don't call symbol_set_names.
 518         (minimal_symbol_reader::install): Call symbol_set_names.
 519
 520 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 521
 522         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 523         restore_active_ext_lang, as GIL is needed for (indirectly)
 524         called PyOS_InterruptOccurred.
 525
 526 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 527
 528         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 529         definition.
 530
 531 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 532
 533         * remote-sim.c (simulator_command): Make static, remove
 534         declaration.
 535
 536 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 537
 538         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 539         static.
 540         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 541         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 542         (main): Likewise.
 543         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 544         (main): Likewise.
 545         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 546         (main): Likewise.
 547         * unittests/basic_string_view/element_access/char/1.cc (test01):
 548         Likewise.
 549         (main): Likewise.
 550         * unittests/basic_string_view/element_access/char/empty.cc (main):
 551         Likewise.
 552         * unittests/basic_string_view/element_access/char/front_back.cc
 553         (test01): Likewise.
 554         (main): Likewise.
 555         * unittests/basic_string_view/inserters/char/2.cc (test05):
 556         Likewise.
 557         (main): Likewise.
 558         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 559         (test01): Likewise.
 560         (main): Likewise.
 561         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 562         (test01): Likewise.
 563         (main): Likewise.
 564         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 565         Likewise.
 566         * unittests/basic_string_view/operations/compare/char/1.cc
 567         (test01): Likewise.
 568         (main): Likewise.
 569         * unittests/basic_string_view/operations/compare/char/13650.cc
 570         (test01): Likewise.
 571         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 572         Likewise.
 573         (main): Likewise.
 574         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 575         Likewise.
 576         (main): Likewise.
 577         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 578         Likewise.
 579         (main): Likewise.
 580         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 581         Likewise.
 582         (main): Likewise.
 583         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 584         Likewise.
 585         (main): Likewise.
 586         * unittests/basic_string_view/operations/find/char/4.cc (main):
 587         Likewise.
 588         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 589         Likewise.
 590         (main): Likewise.
 591         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 592         Likewise.
 593         (main): Likewise.
 594         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 595         Likewise.
 596         (main): Likewise.
 597         * unittests/basic_string_view/operations/substr/char/1.cc
 598         (test01): Likewise.
 599         (main): Likewise.
 600         * unittests/basic_string_view/operators/char/2.cc (main):
 601         Likewise.
 602         * unittests/optional/assignment/1.cc (test): Likewise.
 603         * unittests/optional/assignment/2.cc (test): Likewise.
 604         * unittests/optional/assignment/3.cc (test): Likewise.
 605         * unittests/optional/assignment/4.cc (test): Likewise.
 606         * unittests/optional/assignment/5.cc (test): Likewise.
 607         * unittests/optional/assignment/6.cc (test): Likewise.
 608         * unittests/optional/assignment/7.cc (test): Likewise.
 609         * unittests/optional/cons/copy.cc (test): Likewise.
 610         * unittests/optional/cons/default.cc (test): Likewise.
 611         * unittests/optional/cons/move.cc (test): Likewise.
 612         * unittests/optional/cons/value.cc (test): Likewise.
 613         * unittests/optional/in_place.cc (test): Likewise.
 614         * unittests/optional/observers/1.cc (test): Likewise.
 615         * unittests/optional/observers/2.cc (test): Likewise.
 616
 617 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 618
 619         * tui-win.h (tui_set_var_cmd): Remove.
 620         * tui-win.c (tui_set_var_cmd): Make static.
 621
 622 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 623
 624         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 625         rbreak_command_wrapper): Remove.
 626         * symtab.c (rbreak_command_wrapper): Remove.
 627
 628 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 629
 630         * inferior.h (info_terminal_command): Remove declaration.
 631         * inflow.c (info_terminal_command): Make static.
 632
 633 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 634
 635         * inferior.c (exit_inferior_silent): Remove.
 636
 637 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 638
 639         * dictionary.c (dict_empty, mdict_empty): Remove.
 640         * dictionary.c (mdict_empty): Remove.
 641
 642 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 643
 644          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 645          (arc_insn_get_memory_offset): Likewise.
 646          (arc_insn_dump): Likewise.
 647          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 648          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 649          * dictionary.c (dict_iterator_next): Likewise.
 650          (dict_iter_match_first): Likewise.
 651          (dict_iter_match_next): Likewise.
 652          * f-lang.c (evaluate_subexp_f): Likewise.
 653          * hppa-tdep.c (hppa_read_pc): Likewise.
 654          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 655          * parse.c (write_exp_elt_msym): Likewise.
 656          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 657          * remote.c (remote_packet_size): Likewise.
 658          (remote_notif_stop_parse): Likewise.
 659          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 660          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 661          * source.c (prepare_path_for_appending): Likewise.
 662          * sparc64-linux-tdep.c
 663          (sparc64_linux_handle_segmentation_fault); Likewise.
 664          * stack.c (frame_selection_by_function_completer): Likewise.
 665
 666 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 667
 668         * completer.c (set_gdb_completion_word_break_characters):
 669         Remove.
 670
 671 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 672
 673         * dwarf-index-write.c: Include dwarf-index-write.h.
 674         * mi/mi-interp.c: Include mi/mi-interp.h.
 675
 676 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 677
 678         * aarch32-tdep.c: Include aarch32-tdep.h.
 679         * aarch32-tdep.h: Forward-declare struct target_desc.
 680
 681 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 682
 683         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 684         strerror.
 685         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 686         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 687
 688 2019-11-25  Tom de Vries  <tdevries@suse.de>
 689
 690         * contrib/words.sh: Add -c option.
 691
 692 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 693
 694         * solib.c (solib_find_1): Change int to bool.
 695         (exec_file_find): Change int to bool.
 696         (solib_find): Change int to bool.
 697         (solib_read_symbols): Change int to bool.
 698         (solib_used): Change int to bool.
 699         (solib_add): Change int to bool.
 700         (info_sharedlibrary_command): Change int to bool.
 701         (solib_contains_address_p): Change int to bool.
 702         (solib_keep_data_in_core): Change int to bool.
 703         (in_solib_dynsym_resolve_code): Change int to bool.
 704         (reload_shared_libraries_1): Change int to bool.
 705         (gdb_sysroot_changed): Change int to bool.
 706         * solib.h (solib_read_symbols): Change int to bool.
 707         (solib_contains_address_p): Change int to bool.
 708         (solib_keep_data_in_core): Change int to bool.
 709         (in_solib_dynsym_resolve_code): Change int to bool.
 710         (libpthread_name_p): Change int to bool.
 711
 712 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 713
 714         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 715         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 716         (remote_packet_max_chars): New static global.
 717         (show_remote_packet_max_chars): New function.
 718         (remote_target::putpkt_binary): Adjust to use new
 719         remote_packet_max_chars option.
 720         (remote_target::getpkt_or_notif_sane_1): Likewise.
 721         (_initialize_remote): Register new remote-packet-max-chars option.
 722
 723 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 724
 725         * m68k-linux-nat.c: Include gdbarch.h.
 726
 727 2019-11-24  Tom Tromey  <tom@tromey.com>
 728
 729         * symfile.c (read_symbols): Update.
 730         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 731         bool.
 732         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 733         (psym_lookup_symbol, psym_find_last_source_symtab)
 734         (psym_forget_cached_source_info, psym_print_stats)
 735         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 736         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 737         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 738         (psym_find_compunit_symtab_by_address)
 739         (maintenance_print_psymbols, maintenance_info_psymtabs)
 740         (maintenance_check_psymtabs): Update.
 741         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 742         bool.
 743
 744 2019-11-22  Tom Tromey  <tom@tromey.com>
 745
 746         * observable.h: Update comments.
 747
 748 2019-11-22  Tom Tromey  <tromey@adacore.com>
 749
 750         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 751         (print_ada_task_info): Don't try to fetch thread id if task is not
 752         alive.
 753
 754 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 755
 756         * ada-exp.y: Update.
 757         * ada-lang.c (sort_choices): Update.
 758         (ada_print_symbol_signature): Update.
 759         (resolve_subexp): Update.
 760         (ada_parse_renaming): Update.
 761         (ada_read_renaming_var_value): Update.
 762         (lesseq_defined_than): Update.
 763         (remove_extra_symbols): Update.
 764         (remove_irrelevant_renamings): Update.
 765         (ada_add_block_symbols): Update.
 766         (ada_collect_symbol_completion_matches): Update.
 767         (ada_is_renaming_symbol): Update.
 768         (aggregate_assign_from_choices): Update.
 769         (ada_evaluate_subexp): Update.
 770         (ada_has_this_exception_support): Update.
 771         (ada_is_non_standard_exception_sym): Update.
 772         (ada_add_exceptions_from_frame): Update.
 773         (ada_add_global_exceptions): Update.
 774         (ada_print_subexp): Update.
 775         * ax-gdb.c (gen_var_ref): Update.
 776         (gen_maybe_namespace_elt): Update.
 777         (gen_expr_for_cast): Update.
 778         (gen_expr): Update.
 779         * block.h: Update.
 780         * blockframe.c (find_pc_partial_function): Update.
 781         * breakpoint.c (print_breakpoint_location): Update.
 782         (update_static_tracepoint): Update.
 783         * btrace.c (ftrace_print_function_name): Update.
 784         (ftrace_function_switched): Update.
 785         * buildsym.c (find_symbol_in_list): Update.
 786         * c-exp.y: Update.
 787         * c-typeprint.c (c_print_typedef): Update.
 788         (c_type_print_template_args): Update.
 789         * cli/cli-cmds.c (edit_command): Update.
 790         (list_command): Update.
 791         (print_sal_location): Update.
 792         * coffread.c (patch_opaque_types): Update.
 793         (process_coff_symbol): Update.
 794         (coff_read_enum_type): Update.
 795         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 796         (convert_one_symbol): Update.
 797         (hash_symname): Update.
 798         (eq_symname): Update.
 799         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 800         * compile/compile-cplus-types.c (debug_print_scope): Update.
 801         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 802         * compile/compile-object-load.c (get_out_value_type): Update.
 803         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 804         (search_symbol_list): Update.
 805         (cp_lookup_symbol_imports_or_template): Update.
 806         * cp-support.c (overload_list_add_symbol): Update.
 807         * ctfread.c (psymtab_to_symtab): Update.
 808         * dbxread.c (cp_set_block_scope): Update.
 809         * dictionary.c (iter_match_first_hashed): Update.
 810         (iter_match_next_hashed): Update.
 811         (insert_symbol_hashed): Update.
 812         (iter_match_next_linear): Update.
 813         * dictionary.h: Update.
 814         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 815         (locexpr_describe_location_piece): Update.
 816         (locexpr_describe_location_1): Update.
 817         (locexpr_generate_c_location): Update.
 818         (loclist_describe_location): Update.
 819         (loclist_generate_c_location): Update.
 820         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 821         (read_func_scope): Update.
 822         (process_enumeration_scope): Update.
 823         (new_symbol): Update.
 824         (dwarf2_const_value): Update.
 825         (dwarf2_symbol_mark_computed): Update.
 826         * eval.c (evaluate_funcall): Update.
 827         (evaluate_subexp_standard): Update.
 828         * expprint.c (print_subexp_standard): Update.
 829         (dump_subexp_body_standard): Update.
 830         * f-valprint.c (info_common_command_for_block): Update.
 831         * findvar.c (get_hosting_frame): Update.
 832         (default_read_var_value): Update.
 833         * go-lang.c (go_symbol_package_name): Update.
 834         * guile/scm-block.c (bkscm_print_block_smob): Update.
 835         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 836         (gdbscm_symbol_name): Update.
 837         (gdbscm_symbol_linkage_name): Update.
 838         (gdbscm_symbol_print_name): Update.
 839         * infcall.c (get_function_name): Update.
 840         * infcmd.c (jump_command): Update.
 841         (finish_command): Update.
 842         * infrun.c (insert_exception_resume_breakpoint): Update.
 843         * linespec.c (canonicalize_linespec): Update.
 844         (create_sals_line_offset): Update.
 845         (convert_linespec_to_sals): Update.
 846         (complete_label): Update.
 847         (find_label_symbols_in_block): Update.
 848         * m2-typeprint.c (m2_print_typedef): Update.
 849         * mdebugread.c (mdebug_reg_to_regnum): Update.
 850         (parse_symbol): Update.
 851         (mylookup_symbol): Update.
 852         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 853         (list_args_or_locals): Update.
 854         * objc-lang.c (compare_selectors): Update.
 855         (info_selectors_command): Update.
 856         (compare_classes): Update.
 857         (info_classes_command): Update.
 858         (find_imps): Update.
 859         * p-typeprint.c (pascal_print_typedef): Update.
 860         * printcmd.c (build_address_symbolic): Update.
 861         (info_address_command): Update.
 862         (print_variable_and_value): Update.
 863         * python/py-framefilter.c (extract_sym): Update.
 864         (py_print_single_arg): Update.
 865         * python/py-symbol.c (sympy_str): Update.
 866         (sympy_get_name): Update.
 867         (sympy_get_linkage_name): Update.
 868         * python/python.c (gdbpy_rbreak): Update.
 869         * record-btrace.c (btrace_get_bfun_name): Update.
 870         (btrace_call_history): Update.
 871         * rust-lang.c (rust_print_typedef): Update.
 872         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 873         * stabsread.c (stab_reg_to_regnum): Update.
 874         (define_symbol): Update.
 875         (read_enum_type): Update.
 876         (common_block_end): Update.
 877         (cleanup_undefined_types_1): Update.
 878         (scan_file_globals): Update.
 879         * stack.c (print_frame_arg): Update.
 880         (print_frame_args): Update.
 881         (find_frame_funname): Update.
 882         (info_frame_command_core): Update.
 883         (iterate_over_block_locals): Update.
 884         (print_block_frame_labels): Update.
 885         (do_print_variable_and_value): Update.
 886         (iterate_over_block_arg_vars): Update.
 887         (return_command): Update.
 888         * symmisc.c (dump_symtab_1): Update.
 889         (print_symbol): Update.
 890         * symtab.c (eq_symbol_entry): Update.
 891         (symbol_cache_dump): Update.
 892         (lookup_language_this): Update.
 893         (find_pc_sect_line): Update.
 894         (skip_prologue_sal): Update.
 895         (symbol_search::compare_search_syms): Update.
 896         (treg_matches_sym_type_name): Update.
 897         (search_symbols): Update.
 898         (print_symbol_info): Update.
 899         (rbreak_command): Update.
 900         (completion_list_add_symbol): Update.
 901         (find_gnu_ifunc): Update.
 902         (get_symbol_address): Update.
 903         (search_module_symbols): Update.
 904         (info_module_subcommand): Update.
 905         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 906         (SYMBOL_LINKAGE_NAME): Remove.
 907         (SYMBOL_DEMANGLED_NAME): Remove.
 908         (SYMBOL_PRINT_NAME): Remove.
 909         (SYMBOL_SEARCH_NAME): Remove.
 910         * tracepoint.c (set_traceframe_context): Update.
 911         (validate_actionline): Update.
 912         (collection_list::collect_symbol): Update.
 913         (encode_actions_1): Update.
 914         (info_scope_command): Update.
 915         (print_one_static_tracepoint_marker): Update.
 916         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 917         * valops.c (address_of_variable): Update.
 918         (find_overload_match): Update.
 919         (find_oload_champ): Update.
 920
 921 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 922
 923         * ada-lang.c (ada_lookup_simple_minsym): Update.
 924         (ada_collect_symbol_completion_matches): Update.
 925         * ada-tasks.c (read_atcb): Update.
 926         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 927         (amd64_windows_skip_trampoline_code): Update.
 928         * arm-tdep.c (skip_prologue_function): Update.
 929         (arm_skip_stack_protector): Update.
 930         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 931         (arm_wince_skip_main_prologue): Update.
 932         * ax-gdb.c (gen_expr): Update.
 933         * block.c (call_site_for_pc): Update.
 934         * blockframe.c (find_pc_partial_function): Update.
 935         * breakpoint.c (set_breakpoint_location_function): Update.
 936         * btrace.c (ftrace_print_function_name): Update.
 937         (ftrace_function_switched): Update.
 938         * c-valprint.c (print_unpacked_pointer): Update.
 939         * coffread.c (coff_symfile_read): Update.
 940         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 941         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 942         * dwarf-index-write.c (write_psymbols): Update.
 943         * dwarf2loc.c (call_site_to_target_addr): Update.
 944         (func_verify_no_selftailcall): Update.
 945         (tailcall_dump): Update.
 946         (call_site_find_chain_1): Update.
 947         (dwarf_expr_reg_to_entry_parameter): Update.
 948         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 949         * eval.c (evaluate_funcall): Update.
 950         (evaluate_subexp_standard): Update.
 951         (evaluate_subexp_for_sizeof): Update.
 952         * expprint.c (print_subexp_standard): Update.
 953         (dump_subexp_body_standard): Update.
 954         * frame.c (get_prev_frame_always_1): Update.
 955         * frv-tdep.c (frv_skip_main_prologue): Update.
 956         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 957         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 958         (gnuv3_get_typename_from_type_info): Update.
 959         (gnuv3_skip_trampoline): Update.
 960         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 961         * i386-tdep.c (i386_skip_main_prologue): Update.
 962         (i386_pe_skip_trampoline_code): Update.
 963         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 964         * infcall.c (get_function_name): Update.
 965         * linespec.c (minsym_found): Update.
 966         * linux-fork.c (info_checkpoints_command): Update.
 967         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 968         (m32c_m16c_pointer_to_address): Update.
 969         * maint.c (maintenance_translate_address): Update.
 970         * minsyms.c (add_minsym_to_hash_table): Update.
 971         (add_minsym_to_demangled_hash_table): Update.
 972         (lookup_minimal_symbol_mangled): Update.
 973         (lookup_minimal_symbol_demangled): Update.
 974         (lookup_minimal_symbol_linkage): Update.
 975         (lookup_minimal_symbol_text): Update.
 976         (lookup_minimal_symbol_by_pc_name): Update.
 977         (minimal_symbol_is_less_than): Update.
 978         (compact_minimal_symbols): Update.
 979         (build_minimal_symbol_hash_tables): Update.
 980         (find_solib_trampoline_target): Update.
 981         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 982         (mips_skip_pic_trampoline_code): Update.
 983         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 984         * objc-lang.c (info_selectors_command): Update.
 985         (info_classes_command): Update.
 986         (find_methods): Update.
 987         (find_imps): Update.
 988         * p-valprint.c (pascal_val_print): Update.
 989         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 990         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 991         * printcmd.c (build_address_symbolic): Update.
 992         (info_symbol_command): Update.
 993         * psymtab.c (psymbol_name_matches): Update.
 994         (match_partial_symbol): Update.
 995         (lookup_partial_symbol): Update.
 996         (print_partial_symbols): Update.
 997         (sort_pst_symbols): Update.
 998         (maintenance_check_psymtabs): Update.
 999         * python/py-framefilter.c (py_print_frame): Update.
1000         * python/python.c (gdbpy_rbreak): Update.
1001         * record-btrace.c (btrace_get_bfun_name): Update.
1002         (btrace_call_history): Update.
1003         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1004         (rs6000_skip_trampoline_code): Update.
1005         * sol-thread.c (info_cb): Update.
1006         * stabsread.c (scan_file_globals): Update.
1007         * stack.c (find_frame_funname): Update.
1008         (info_frame_command_core): Update.
1009         * symmisc.c (dump_msymbols): Update.
1010         * symtab.c (symbol_natural_name): Rename to..,
1011         (general_symbol_info::natural_name): ...this.
1012         (symbol_demangled_name): Rename to...
1013         (general_symbol_info::demangled_name): ...this.
1014         (symbol_search_name): Rename to...
1015         (general_symbol_info::search_name): ...this.
1016         (symbol_matches_search_name): Update.
1017         (find_pc_sect_line): Update.
1018         (skip_prologue_sal): Update.
1019         (search_symbols): Update.
1020         (print_msymbol_info): Update.
1021         (rbreak_command): Update.
1022         (completion_list_add_msymbol): Update.
1023         (completion_list_objc_symbol): Update.
1024         (get_msymbol_address): Update.
1025         * symtab.h (struct general_symbol_info): Add member functions
1026         natural_name (), linkage_name (), print_name (), demangled_name (),
1027         and search_name ().
1028         (SYMBOL_NATURAL_NAME): Update.
1029         (symbol_natural_name): Move to a member function on general_symbol_info.
1030         (SYMBOL_DEMANGLED_NAME): Update.
1031         (symbol_demangled_name): Move to a member function on
1032         general_symbol_info.
1033         (SYMBOL_SEARCH_NAME): Update.
1034         (symbol_search_name): Move to a member function on general_symbol_info.
1035         (MSYMBOL_NATURAL_NAME): Remove.
1036         (MSYMBOL_LINKAGE_NAME): Remove.
1037         (MSYMBOL_PRINT_NAME): Remove.
1038         (MSYMBOL_DEMANGLED_NAME): Remove.
1039         (MSYMBOL_SEARCH_NAME): Remove.
1040         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1041
1042 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1043
1044         * symtab.c (create_demangled_names_hash): Use per_bfd->
1045         minimal_symbol_count for computing the initial size, if greater
1046         than our default size.
1047
1048 2019-11-22  Tom de Vries  <tdevries@suse.de>
1049
1050         * contrib/words.sh: Improve words extraction.
1051
1052 2019-11-22  Tom de Vries  <tdevries@suse.de>
1053
1054         * contrib/words.sh: Combine sed invocations.
1055
1056 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1057
1058         * Makefile.in: Update.
1059         * demangle.c: Rename to...
1060         * gdb-demangle.c: ..this.
1061         (is_cplus_marker): Change return type to bool.
1062         (_initialize_demangler): Rename to...
1063         (_initialize_gdb_demangle): ...this.
1064         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1065         * symtab.h (demangle): Remove declaration; instead include
1066         gdb-demangle.h.
1067
1068 2019-11-21  Tom Tromey  <tromey@adacore.com>
1069
1070         * gdbsupport/format.c (format_pieces): Parse %I64d.
1071         * unittests/format_pieces-selftests.c (test_windows_formats): New
1072         function.
1073         (run_tests): Call it.
1074
1075 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1076
1077         Byte reverse display of variables with DW_END_big, DW_END_little
1078         (DW_AT_endianity) dwarf attributes if different than the native
1079         byte order.
1080         * ada-lang.c (ada_value_binop):
1081         Use type_byte_order instead of gdbarch_byte_order.
1082         * ada-valprint.c (printstr):
1083         (ada_val_print_string):
1084         * ada-lang.c (value_pointer):
1085         (ada_value_binop):
1086         Use type_byte_order instead of gdbarch_byte_order.
1087         * c-lang.c (c_get_string):
1088         Use type_byte_order instead of gdbarch_byte_order.
1089         * c-valprint.c (c_val_print_array):
1090         Use type_byte_order instead of gdbarch_byte_order.
1091         * cp-valprint.c (cp_print_class_member):
1092         Use type_byte_order instead of gdbarch_byte_order.
1093         * dwarf2loc.c (rw_pieced_value):
1094         Use type_byte_order instead of gdbarch_byte_order.
1095         * dwarf2read.c (read_base_type): Handle DW_END_big,
1096         DW_END_little
1097         * f-lang.c (f_get_encoding):
1098         Use type_byte_order instead of gdbarch_byte_order.
1099         * findvar.c (default_read_var_value):
1100         Use type_byte_order instead of gdbarch_byte_order.
1101         * gdbtypes.c (check_types_equal):
1102         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1103         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1104         and TYPE_ENDIANITY_LITTLE if set.
1105         (type_byte_order): new function.
1106         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1107         (struct main_type) <flag_endianity_not_default>:
1108         New field.
1109         (type_byte_order): New function.
1110         * infcmd.c (default_print_one_register_info):
1111         Use type_byte_order instead of gdbarch_byte_order.
1112         * p-lang.c (pascal_printstr):
1113         Use type_byte_order instead of gdbarch_byte_order.
1114         * p-valprint.c (pascal_val_print):
1115         Use type_byte_order instead of gdbarch_byte_order.
1116         * printcmd.c (print_scalar_formatted):
1117         Use type_byte_order instead of gdbarch_byte_order.
1118         * solib-darwin.c (darwin_current_sos):
1119         Use type_byte_order instead of gdbarch_byte_order.
1120         * solib-svr4.c (solib_svr4_r_ldsomap):
1121         Use type_byte_order instead of gdbarch_byte_order.
1122         * stap-probe.c (stap_modify_semaphore):
1123         Use type_byte_order instead of gdbarch_byte_order.
1124         * target-float.c (target_float_same_format_p):
1125         Use type_byte_order instead of gdbarch_byte_order.
1126         * valarith.c (scalar_binop):
1127         (value_bit_index):
1128         Use type_byte_order instead of gdbarch_byte_order.
1129         * valops.c (value_cast):
1130         Use type_byte_order instead of gdbarch_byte_order.
1131         * valprint.c (generic_emit_char):
1132         (generic_printstr):
1133         (val_print_string):
1134         Use type_byte_order instead of gdbarch_byte_order.
1135         * value.c (unpack_long):
1136         (unpack_bits_as_long):
1137         (unpack_value_bitfield):
1138         (modify_field):
1139         (pack_long):
1140         (pack_unsigned_long):
1141         Use type_byte_order instead of gdbarch_byte_order.
1142         * findvar.c (unsigned_pointer_to_address):
1143         (signed_pointer_to_address):
1144         (unsigned_address_to_pointer):
1145         (address_to_signed_pointer):
1146         (default_read_var_value):
1147         (default_value_from_register):
1148         Use type_byte_order instead of gdbarch_byte_order.
1149         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1150         Use type_byte_order instead of gdbarch_byte_order.
1151         * riscv-tdep.c (riscv_print_one_register_info):
1152         Use type_byte_order instead of gdbarch_byte_order.
1153
1154 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1155
1156         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1157         (current_ui_gdb_stdin_ptr): Likewise.
1158         (current_ui_gdb_stderr_ptr): Likewise.
1159         (current_ui_gdb_stdlog_ptr): Likewise.
1160         (current_ui_current_uiout_ptr): Likewise.
1161         (gen_ret_current_ui_field_ptr): Remove.
1162
1163 2019-11-21  Tom de Vries  <tdevries@suse.de>
1164
1165         PR gdb/24956
1166         * cli/cli-script.c (execute_control_command): Only switch to
1167         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1168
1169 2019-11-19  Tom Tromey  <tom@tromey.com>
1170
1171         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1172         Now static.  Change type of "name".
1173         (tui_set_win_height_command): Don't copy "arg".
1174         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1175         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1176
1177 2019-11-19  Ali Tamur <tamur@google.com>
1178
1179         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1180         "if (attr != nullptr)".
1181         (dwarf2_find_base_address): Likewise.
1182         (dwarf2_build_include_psymtabs): Likewise.
1183         (read_cutu_die_from_dwo): Likewise.
1184         (read_func_scope): Likewise.
1185         (read_call_site_scope): Likewise.
1186         (dwarf2_get_pc_bounds): Likewise.
1187         (dwarf2_record_block_ranges): Likewise.
1188         (dwarf2_add_field): Likewise.
1189         (dwarf2_add_member_fn): Likewise.
1190         (read_structure_type): Likewise.
1191         (read_enumeration_type): Likewise.
1192         (read_array_type): Likewise.
1193         (read_array_order): Likewise.
1194         (read_set_type): Likewise.
1195         (read_common_block): Likewise.
1196         (read_tag_reference_type): Likewise.
1197         (read_tag_string_type): Likewise.
1198         (read_subroutine_type): Likewise.
1199         (read_base_type): Likewise.
1200         (read_subrange_type): Likewise.
1201         (new_symbol): Likewise.
1202         (prepare_one_comp_unit): Likewise.
1203
1204 2019-11-19  Tom Tromey  <tromey@adacore.com>
1205
1206         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1207         result in error when DebugActiveProcess fails.
1208
1209 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1210             Pedro Alves  <palves@redhat.com>
1211
1212         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1213         * target.c (target_stack::push): Call 'unpush' if there's a
1214         target on top of the stack.
1215
1216 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1217
1218         * python/py-block.c (blpy_dealloc): Call tp_free.
1219         (blpy_block_syms_dealloc): Likewise.
1220         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1221         * python/py-inferior.c (infpy_dealloc): Likewise.
1222         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1223         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1224         * python/py-symbol.c (sympy_dealloc): Likewise.
1225         * python/py-symtab.c (stpy_dealloc): Likewise.
1226         * python/py-type.c (typy_iterator_dealloc): Likewise.
1227
1228 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1229
1230         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1231         constructor instead of using a class initializer.
1232
1233 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1234
1235         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1236         * configure: Regenerate.
1237         * configure.ac: Don't source common.host.
1238         * gdbsupport/common.host: Remove.
1239         * gdbsupport/mingw-strerror.c: Remove.
1240         * gdbsupport/posix-strerror.c: Rename to...
1241         * gdbsupport/safe-strerror.c: ...this.
1242
1243 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1244
1245         * maint.c (scoped_command_stats::print_time): Use localtime_r
1246         instead of localtime (provided through gnulib if necessary).
1247         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1248         of ctime.
1249
1250 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1251
1252         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1253         avoid compile errors.
1254
1255 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1256
1257         * config.in: Regenerate.
1258         * configure: Regenerate.
1259         * gdbsupport/common.m4: No longer check for strerror_r.
1260         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1261         POSIX version of strerror_r, now that gnulib provides it if
1262         necessary.
1263
1264 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1265
1266         * README (`configure' options): Update.
1267
1268 2019-11-14  Tom Tromey  <tromey@adacore.com>
1269
1270         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1271         expected type for the RHS if the LHS is a convenience variable.
1272
1273 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1274
1275         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1276         Provide explicit default and copy constructor.
1277
1278 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1279
1280         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1281         only call Py_INCREF (newbp) in the bppy_pending_object case.
1282
1283 2019-11-13  Tom Tromey  <tromey@adacore.com>
1284
1285         PR build/25182:
1286         * psympriv.h (partial_symbol): Remove static assert.
1287         * symtab.h (general_symbol_info, symbol): Remove static assert.
1288
1289 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1290
1291         * gdbsupport/format.c (format_pieces::format_pieces): Support
1292         printf 'z' size modifier.
1293         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1294         * printcmd.c (ui_printf):  Handle size_t_arg.
1295         * ui-out.c (ui_out::vmessage): Likewise.
1296         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1297         function.
1298         (run_tests): Call test_format_int_sizes.
1299
1300 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1301
1302         * ada-exp.y (write_ambiguous_var): Update.
1303         * buildsym.c (add_symbol_to_list): Update.
1304         * dwarf2read.c (read_variable): Update.
1305         (new_symbol): Update.
1306         * jit.c (finalize_symtab): Update.
1307         * language.c (language_alloc_type_symbol): Update.
1308         * symtab.c (fixup_symbol_section): Update.
1309         (initialize_objfile_symbol_1): Move code to...
1310         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1311         (allocate_symbol): Update.
1312         (allocate_template_symbol): Update.
1313         (get_symbol_address): Update.
1314         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1315         of having as a field, and add a constructor.
1316         (SYMBOL_VALUE): Update.
1317         (SYMBOL_VALUE_ADDRESS): Update.
1318         (SET_SYMBOL_VALUE_ADDRESS): Update.
1319         (SYMBOL_VALUE_BYTES): Update.
1320         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1321         (SYMBOL_BLOCK_VALUE): Update.
1322         (SYMBOL_VALUE_CHAIN): Update.
1323         (SYMBOL_LANGUAGE): Update.
1324         (SYMBOL_SECTION): Update.
1325         (SYMBOL_OBJ_SECTION): Update.
1326         (SYMBOL_SET_LANGUAGE): Update.
1327         (SYMBOL_SET_LINKAGE_NAME): Update.
1328         (SYMBOL_SET_NAMES): Update.
1329         (SYMBOL_NATURAL_NAME): Update.
1330         (SYMBOL_LINKAGE_NAME): Update.
1331         (SYMBOL_DEMANGLED_NAME): Update.
1332         (SYMBOL_SEARCH_NAME): Update.
1333         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1334         (struct symbol): Update.
1335         (struct template_symbol): Update.
1336         (struct rust_vtable_symbol): Update.
1337         * xcoffread.c (SYMBOL_DUP): Update.
1338
1339 2019-11-12  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-layout.c (show_layout): Set current_layout.
1342         (show_source_disasm_command, show_data)
1343         (show_source_or_disasm_and_command): Don't set current_layout.
1344
1345 2019-11-12  Tom Tromey  <tom@tromey.com>
1346
1347         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1348
1349 2019-11-12  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-win.c (resize_message): New global.
1352         (show_tui_resize_message): New function.
1353         (tui_async_resize_screen): Print message if requested.
1354         (_initialize_tui_win): Add tui-resize-message setting.
1355         * NEWS: Add entry for new commands.
1356
1357 2019-11-11  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1360         functions.
1361
1362 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1363
1364         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1365
1366 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1367
1368         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1369         function.
1370         * python/python-internal.h (gdbpy_lookup_static_symbols):
1371         Declare new function.
1372         * python/python.c (python_GdbMethods): Add
1373         gdb.lookup_static_symbols method.
1374         * NEWS: Mention gdb.lookup_static_symbols.
1375
1376 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1377
1378         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1379         static block of current object file first.  Also fix typo in
1380         header comment.
1381
1382 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1383
1384         * stack.c (set_last_displayed_sal): Delete.
1385         (last_displayed_sal_valid): Delete.
1386         (last_displayed_pspace): Delete.
1387         (last_displayed_addr): Delete.
1388         (last_displayed_symtab): Delete.
1389         (last_displayed_line): Delete.
1390         (class last_displayed_symtab_info_type): New.
1391         (last_displayed_symtab_info): New static global variable.
1392         (print_frame_info): Call methods on last_displayed_symtab_info.
1393         (clear_last_displayed_sal): Update header comment, and make use of
1394         last_displayed_symtab_info.
1395         (last_displayed_sal_is_valid): Likewise.
1396         (get_last_displayed_pspace): Likewise.
1397         (get_last_displayed_addr): Likewise.
1398         (get_last_displayed_symtab): Likewise.
1399         (get_last_displayed_line): Likewise.
1400         (get_last_displayed_sal): Likewise.
1401         * stack.h (clear_last_displayed_sal): Update header comment.
1402         (last_displayed_sal_is_valid): Likewise.
1403         (get_last_displayed_pspace): Likewise.
1404         (get_last_displayed_addr): Likewise.
1405         (get_last_displayed_symtab): Likewise.
1406         (get_last_displayed_line): Likewise.
1407         (get_last_displayed_sal): Likewise.
1408
1409 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1410
1411         * stack.c (frame_show_address): Convert return type to bool.
1412         * stack.h (frame_show_address): Likewise, and update header
1413         comment.
1414
1415 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1416
1417         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1418         * unittests/vec-utils-selftests.c: New file.
1419         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1420
1421 2019-11-10  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1424         (tui_highlight_win): Likewise.
1425         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1426         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1427         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1428         Don't set can_highlight.
1429
1430 2019-11-10  Tom Tromey  <tom@tromey.com>
1431
1432         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1433         Remove unused declaration.
1434
1435 2019-11-08  Tom Tromey  <tromey@adacore.com>
1436
1437         * top.c (read_command_file): Update.
1438         (command_line_input): Make return type const.
1439         * python/py-gdb-readline.c: Update.
1440         * linespec.c (decode_line_2): Update.
1441         * defs.h (command_line_input): Make return type const.
1442         * cli/cli-script.c (read_next_line): Make return type const.
1443         * ada-lang.c (get_selections): Update.
1444
1445 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1446
1447         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1448         * mi/mi-main.c (output_cores): Likewise.
1449         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1450         (linux_xfer_osdata_modules): Likewise.
1451         * remote.c (register_remote_support_xml): Likewise.
1452         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1453         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1454
1455 2019-11-06  Tom Tromey  <tom@tromey.com>
1456
1457         * tui/tui-interp.c: Don't include readline.h.
1458         * tui/tui-hooks.c: Don't include readline.h.
1459         * symmisc.c: Include tilde.h, not readline.h.
1460         * symfile.c: Include tilde.h, not readline.h.
1461         * source.c: Include tilde.h, not readline.h.
1462         * solib.c: Include tilde.h, not readline.h.
1463         * psymtab.c: Include tilde.h, not readline.h.
1464         * exec.c: Include tilde.h, not readline.h.
1465         * corelow.c: Include tilde.h, not readline.h.
1466         * cli/cli-dump.c: Include tilde.h, not readline.h.
1467         * cli/cli-cmds.c: Don't include readline.h.
1468
1469 2019-11-05  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1472         (tui_disassemble): Set addr_size.
1473         (tui_disasm_window::set_contents): Use addr_size.
1474
1475 2019-11-05  Tom Tromey  <tom@tromey.com>
1476
1477         * rust-lang.c (rust_language_defn): Update.
1478         * python/py-value.c (valpy_string): Call c_get_string.
1479         * p-lang.c (pascal_language_defn): Update.
1480         * opencl-lang.c (opencl_language_defn): Update.
1481         * objc-lang.c (objc_language_defn): Update.
1482         * m2-lang.c (m2_language_defn): Update.
1483         * language.c (unknown_language_defn, auto_language_defn): Update.
1484         (default_get_string): Remove.
1485         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1486         * go-lang.c (go_language_defn): Update.
1487         * f-lang.c (f_language_defn): Update.
1488         * d-lang.c (d_language_defn): Update.
1489         * c-lang.c (c_language_defn, cplus_language_defn)
1490         (asm_language_defn, minimal_language_defn): Update.
1491         * ada-lang.c (ada_language_defn): Update.
1492         * language.h (struct language_defn) <la_get_string>: Remove.
1493         (LA_GET_STRING): Remove.
1494         (default_get_string): Don't declare.
1495
1496 2019-11-05  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-source.h (struct tui_source_window): Inline
1499         constructor.  Remove destructor.
1500         <style_changed, m_observable>: Move to superclass.
1501         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1502         (struct tui_source_window_base): Move private members to end.
1503         <style_changed, m_observable>: Move from tui_source_window.
1504         * tui/tui-winsource.c (tui_copy_source_line): Move from
1505         tui-source.c.  Rename from copy_source_line.  Add special handling
1506         for negative line number.
1507         (tui_source_window_base::style_changed): Move from
1508         tui_source_window.
1509         (tui_source_window_base): Register observer.
1510         (~tui_source_window_base): New.
1511         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1512         rename.
1513         (tui_source_window::set_contents): Use tui_copy_source_line.
1514         (tui_source_window::tui_source_window): Move to tui-source.h.
1515         (tui_source_window::~tui_source_window): Remove.
1516         (tui_source_window::style_changed): Move to superclass.
1517         * tui/tui-disasm.c (tui_disassemble): Create string file with
1518         styling, when possible.  Add "addr_size" parameter.
1519         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1520         Don't compute maximum size.
1521         (len_without_escapes): New function
1522
1523 2019-11-05  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1526         std::string.
1527         * tui/tui-winsource.c (tui_show_source_line): Update.
1528         * tui/tui-source.c (tui_source_window::set_contents): Update.
1529         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1530
1531 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1532
1533         * symtab.h (gdb_static_assert): Put && operator at the beginning
1534         of the line instead of the end.
1535
1536 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1537
1538         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1539         and sizeof (symbol).
1540         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1541
1542 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1543
1544         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1545         * configure.host: Mark *-*-solaris2.10* obsolete.
1546         * configure.tgt: Mark Solaris < 11 obsolete.
1547         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1548         Update target triplet.
1549
1550 2019-11-01  Tom Tromey  <tromey@adacore.com>
1551
1552         * utils.c (print_sys_errmsg): Simplify.
1553
1554 2019-11-01  Tom Tromey  <tromey@adacore.com>
1555
1556         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1557
1558 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1559
1560         * configure: Regenerate.
1561         * configure.ac: Remove check for strerror_r.
1562         * gdbsupport/common.m4: Check for strerror_r.
1563
1564 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1565
1566         PR gdb/25124
1567
1568         * arm-tdep.c (arm_per_objfile): Rename to ...
1569         (arm_per_bfd): ... this.
1570         (arm_objfile_data_key): Rename to ...
1571         (arm_bfd_data_key): ... this.
1572         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1573         data.
1574         (arm_record_special_symbol): Likewise.
1575
1576 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1579         end.
1580         * c-typeprint.c (c_print_typedef): Likewise.
1581         * f-typeprint.c (f_print_typedef): Likewise.
1582         * m2-typeprint.c (m2_print_typedef): Likewise.
1583         * p-typeprint.c (pascal_print_typedef): Likewise.
1584         * rust-lang.c (rust_print_typedef): Likewise.
1585         * symtab.c (print_symbol_info): Print a newline after calling
1586         typedef_print.
1587
1588 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * symtab.c (info_module_cmdlist): New variable.
1591         (info_module_command): New function.
1592         (search_module_symbols): New function.
1593         (info_module_subcommand): New function.
1594         (struct info_modules_var_func_options): New struct.
1595         (info_modules_var_func_options_defs): New variable.
1596         (make_info_modules_var_func_options_def_group): New function.
1597         (info_module_functions_command): New function.
1598         (info_module_variables_command): New function.
1599         (info_module_var_func_command_completer): New function.
1600         (_initialize_symtab): Register new 'info module functions' and
1601         'info module variables' commands.
1602         * symtab.h (typedef symbol_search_in_module): New typedef.
1603         (search_module_symbols): Declare new function.
1604         * NEWS: Mention new commands.
1605
1606 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1607
1608         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1609         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1610         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1611         MODULES_DOMAIN.
1612         (scan_partial_symbols): Only create partial module symbols for non
1613         declarations.
1614         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1615         and MODULES_DOMAIN.
1616         * symtab.c (search_domain_name): Likewise.
1617         (search_symbols): Likewise.
1618         (print_symbol_info): Likewise.
1619         (symtab_symbol_info): Likewise.
1620         (info_modules_command): New function.
1621         (_initialize_symtab): Register 'info modules' command.
1622         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1623         * NEWS: Mention new 'info modules' command.
1624
1625 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1626
1627         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1628         and $_gdb_maint_setting_str.
1629
1630 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1631
1632         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1633         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1634         (str_value_from_setting, gdb_setting_str_internal_fn)
1635         (gdb_maint_setting_str_internal_fn): New functions.
1636         (_initialize_cli_cmds): Define the new convenience functions.
1637         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1638         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1639
1640 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1641
1642         * agent.c (set_can_use_agent): When the setting is turned on,
1643         look up agent symbols if we don't have them yet.
1644         (agent_new_objfile): Don't look up agent symbols when the agent
1645         setting is off.
1646
1647 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1648
1649         * config.in: Regenerate.
1650
1651 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1652
1653         * configure: Regenerate.
1654         * configure.ac: Check for strerror_r.
1655         * gdbsupport/common-utils.h (safe_strerror): Change return value
1656         to const char * and document that this function is now threadsafe.
1657         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1658         thread_local and call strerror_r, if available.
1659         * utils.c (perror_string): Update.
1660         (print_sys_errmsg): Update.
1661
1662 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1663
1664         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1665         objfile_key.
1666         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1667         objfile to fetch per-bfd data.
1668         (arm_find_exidx_entry): Likewise.
1669
1670 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1671
1672         * gdbsupport/agent.c (debug_agent): Change type to bool.
1673         (use_agent): Likewise.
1674         (all_agent_symbols_look_up): Likewise.
1675         (agent_loaded_p): Change return value to bool.
1676         (agent_look_up_symbols): Update.
1677         (agent_capability_check): Change return value to bool.
1678         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1679         (debug_agent): Change type to bool.
1680         (use_agent): Likewise.
1681         (agent_capability_check): Change return value to bool.
1682
1683 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1684
1685         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1686         (build_minimal_symbol_hash_tables): Code to clear the table moved
1687         to clear_minimal_symbol_hash_tables.
1688         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1689         when needed.
1690
1691 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1692
1693         * infcmd.c: Remove includes.
1694         * infrun.c: Remove includes.
1695
1696 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1697
1698         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1699         (grow_vect): Remove declaration.
1700         (ada_type_of_array): Remove declaration.
1701         (ada_update_initial_language): Remove declaration.
1702         (ada_fold_name): Remove declaration.
1703         (ada_fill_in_ada_prototype): Remove declaration.
1704         (user_select_syms): Remove declaration.
1705         (get_selections): Remove declaration.
1706         (ada_tag_type): Remove declaration.
1707         (ada_value_tag): Remove declaration.
1708         (ada_is_others_clause): Remove declaration.
1709         (ada_in_variant): Remove declaration.
1710         (ada_value_struct_elt): Remove declaration.
1711         (ada_attribute_name): Remove declaration.
1712         (ada_system_address_type): Remove declaration.
1713         * ada-lang.c (ada_watch_location_expression): Make static.
1714         (GROW_VECT): Move here from ada-lang.h.
1715         (grow_vect): Make static.
1716         (ada_update_initial_language): Make static.
1717         (ada_fold_name): Make static.
1718         (ada_type_of_array): Make static.
1719         (encoded_ordered_before): Move up.
1720         (sort_choices): Move up.
1721         (print_signatures): Move up.
1722         (ada_print_symbol_signature): Move up.
1723         (get_selections): Move up and make static.
1724         (user_select_syms): Move up and make static.
1725         (ada_value_struct_elt): Move up and make static.
1726         (ada_tag_type): Make static.
1727         (ada_value_tag): Make static.
1728         (ada_is_others_clause): Make static.
1729         (ada_in_variant): Make static.
1730         (ada_attribute_name): Make static.
1731
1732 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1733
1734         * ada-lang.c: Remove includes.
1735         * ada-typeprint.c: Remove includes.
1736         * ada-valprint.c: Remove includes.
1737
1738 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1739
1740         * addrmap.c: Add static assertions of type size, moved from
1741         _initialize_addrmap.
1742         (_initialize_addrmap): Remove.
1743
1744 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1745
1746         * coffread.c (record_minimal_symbol): Update.
1747         (process_coff_symbol): Update.
1748         * dbxread.c (read_dbx_symtab): Update.
1749         * dwarf2read.c (add_partial_symbol): Update.
1750         (fixup_go_packaging): Update.
1751         (load_partial_dies): Update.
1752         (new_symbol): Update.
1753         * elfread.c (record_minimal_symbol): Change signature to use
1754         gdb::string_view instead of name+len.
1755         (elf_symtab_read): Update.
1756         (elf_rel_plt_read): Update.
1757         * mdebugread.c (parse_partial_symbols): Update.
1758         (handle_psymbol_enumerators): Update.
1759         (new_symbol): Update.
1760         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1761         to use gdb::string_view instead of name+len.
1762         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1763         * psympriv.h (add_psymbol_to_list): Likewise.
1764         * psymtab.c (add_psymbol_to_bcache): Likewise.
1765         (add_psymbol_to_list): Likewise.
1766         * stabsread.c (define_symbol): Update.
1767         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1768         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1769         (symbol_set_names): Likewise.
1770         * xcoffread.c (scan_xcoff_symtab): Update.
1771
1772 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1773
1774         * symtab.h (symbol_set_names): Document that copy_name must be
1775         set to true for non-nullterminated strings.
1776         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1777         linkage_name if the entry was not found and we need to demangle.
1778
1779 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1780
1781         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1782         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1783         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1784         * gdbsupport/gdb_binary_search.h: New file.
1785
1786 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1787
1788         * NEWS: Mention new --with-system-gdbinit-dir option.
1789         * config.in: Regenerate.
1790         * configure: Regenerate.
1791         * configure.ac: Add new option --with-system-gdbinit-dir.
1792         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1793         for a ".gdb" suffix.
1794         * main.c (get_init_files): Change system_gdbinit argument to
1795         a vector and return the files in SYSTEM_GDBINIT_DIR in
1796         addition to SYSTEM_GDBINIT.
1797         (captured_main_1): Update.
1798         (print_gdb_help): Update.
1799         * top.c (print_gdb_configuration): Also print the value of
1800         SYSTEM_GDBINIT_DIR.
1801
1802 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1803
1804         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1805         that takes gdb::string_view arguments.
1806
1807 2019-10-26  Tom de Vries  <tdevries@suse.de>
1808
1809         * aarch64-linux-tdep.c: Fix typos in comments.
1810         * aarch64-tdep.c: Same.
1811         * ada-lang.c: Same.
1812         * amd64-nat.c: Same.
1813         * arc-tdep.c: Same.
1814         * arch/aarch64-insn.c: Same.
1815         * block.c: Same.
1816         * breakpoint.h: Same.
1817         * btrace.h: Same.
1818         * c-varobj.c: Same.
1819         * cli/cli-decode.c: Same.
1820         * cli/cli-script.c: Same.
1821         * cli/cli-utils.h: Same.
1822         * coff-pe-read.c: Same.
1823         * coffread.c: Same.
1824         * compile/compile-cplus-symbols.c: Same.
1825         * compile/compile-object-run.c: Same.
1826         * completer.c: Same.
1827         * corelow.c: Same.
1828         * cp-support.c: Same.
1829         * demangle.c: Same.
1830         * dwarf-index-write.c: Same.
1831         * dwarf2-frame.c: Same.
1832         * dwarf2-frame.h: Same.
1833         * eval.c: Same.
1834         * frame-base.h: Same.
1835         * frame.h: Same.
1836         * gdbcmd.h: Same.
1837         * gdbtypes.h: Same.
1838         * gnu-nat.c: Same.
1839         * guile/scm-objfile.c: Same.
1840         * i386-tdep.c: Same.
1841         * i386-tdep.h: Same.
1842         * infcall.c: Same.
1843         * infcall.h: Same.
1844         * linux-nat.c: Same.
1845         * m68k-tdep.c: Same.
1846         * macroexp.c: Same.
1847         * memattr.c: Same.
1848         * mi/mi-cmd-disas.c: Same.
1849         * mi/mi-getopt.h: Same.
1850         * mi/mi-main.c: Same.
1851         * minsyms.c: Same.
1852         * nat/aarch64-sve-linux-sigcontext.h: Same.
1853         * objfiles.h: Same.
1854         * ppc-linux-nat.c: Same.
1855         * ppc-linux-tdep.c: Same.
1856         * ppc-tdep.h: Same.
1857         * progspace.h: Same.
1858         * prologue-value.h: Same.
1859         * python/py-evtregistry.c: Same.
1860         * python/py-instruction.h: Same.
1861         * record-btrace.c: Same.
1862         * record-full.c: Same.
1863         * remote.c: Same.
1864         * rs6000-tdep.c: Same.
1865         * ser-tcp.c: Same.
1866         * sol-thread.c: Same.
1867         * sparc-sol2-tdep.c: Same.
1868         * sparc64-tdep.c: Same.
1869         * stabsread.c: Same.
1870         * symfile.c: Same.
1871         * symtab.h: Same.
1872         * target.c: Same.
1873         * tracepoint.c: Same.
1874         * tui/tui-data.h: Same.
1875         * tui/tui-io.c: Same.
1876         * tui/tui-win.c: Same.
1877         * tui/tui.c: Same.
1878         * unittests/rsp-low-selftests.c: Same.
1879         * user-regs.h: Same.
1880         * utils.c: Same.
1881         * utils.h: Same.
1882         * valarith.c: Same.
1883         * valops.c: Same.
1884         * valprint.c: Same.
1885         * valprint.h: Same.
1886         * value.c: Same.
1887         * value.h: Same.
1888         * varobj.c: Same.
1889         * x86-nat.h: Same.
1890         * xtensa-tdep.c: Same.
1891
1892 2019-10-25  Ali Tamur <tamur@google.com>
1893
1894         * charset.c (find_charset_names): Reflect API change.
1895
1896 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1897
1898         * symtab.c (struct demangled_name_entry): Change demangled name
1899         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1900         part of the struct anymore.
1901         (symbol_set_names): No longer obstack allocate + copy the demangled
1902         name, just store the allocated name from bfd.
1903
1904 2019-10-25  Tom Tromey  <tromey@adacore.com>
1905
1906         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1907         (bsearch_cie_cmp, add_cie): Remove.
1908         (find_cie): Reimplement.
1909         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1910         (dwarf2_build_frame_info): Update.
1911
1912 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1913
1914         PR gdb/25126
1915         * symfile.c (reread_symbols): Call forget_cached_source_info to
1916         clear the stale source cache.
1917
1918 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1919
1920         * configure: Regenerate.
1921         * configure.ac: Remove code that sets python_has_threads.
1922
1923 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1924
1925         * config.in: Regenerate.
1926         * configure: Regenerate.
1927         * configure.ac: Remove the code that uses sed to get the python
1928         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1929
1930 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1931
1932         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1933         error paths.
1934
1935 2019-10-23  Tom Tromey  <tom@tromey.com>
1936
1937         * arc-tdep.c: Remove ".." from include.
1938         * frv-tdep.c: Remove ".." from include.
1939         * lm32-tdep.c: Remove ".." from include.
1940         * microblaze-tdep.c: Remove ".." from include.
1941         * or1k-tdep.h: Remove ".." from include.
1942         * s12z-tdep.c: Remove ".." from include.
1943         * Makefile.in (OPCODES_CFLAGS): Add comment.
1944         (TOP_CFLAGS): New variable.
1945         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1946
1947 2019-10-23  Tom Tromey  <tom@tromey.com>
1948
1949         * Makefile.in (READLINE_DIR): Update.
1950
1951 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1952
1953         * infcall.c (call_function_by_hand_dummy): Fix the function
1954         comment.  And extract out a code section into...
1955         (reserve_stack_space): ...this new function.
1956
1957 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1958
1959         * infcall.c (value_arg_coerce): Remove an unused parameter.
1960         (call_function_by_hand_dummy): Update the call to
1961         'value_arg_coerce'.
1962
1963 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1964
1965         * infcall.c (call_function_by_hand_dummy): Refactor.
1966
1967 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1968
1969         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1970
1971 2019-10-23  Tom Tromey  <tom@tromey.com>
1972
1973         * configure: Rebuild.
1974         * configure.ac: Don't check for sigprocmask.
1975         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1976
1977 2019-10-23  Tom Tromey  <tom@tromey.com>
1978
1979         * configure: Rebuild.
1980         * acinclude.m4: Use m4_include, not sinclude.
1981
1982 2019-10-23  Tom de Vries  <tdevries@suse.de>
1983
1984         PR breakpoints/24687
1985         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1986
1987 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1988
1989         * symtab.c (struct demangled_name_entry) <language>: Change from
1990         bitfield to regular variable.
1991
1992 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1993
1994         * symtab.c (struct demangled_name_entry): Add a constructor.
1995         (free_demangled_name_entry): New function to call the destructor
1996         for demangled_name_entry.
1997         (create_demangled_names_hash): Pass free_demangled_name_entry to
1998         htab_create_alloc.
1999         (symbol_set_names): Call placement new for demangled_name_entry.
2000         * utils.c: No longer include xxhash.h here, now that fast_hash
2001         is inlined in the header.
2002         * utils.h: Instead, include it here.
2003
2004 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2005
2006         * Makefile.in: Link with libxxhash.
2007         * config.in: Regenerate.
2008         * configure: Regenerate.
2009         * configure.ac: Search for libxxhash.
2010         * utils.c (fast_hash): Use xxhash if present.
2011
2012 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2013
2014         * utils.h (fast_hash): New function.
2015         * symtab.c (hash_demangled_name_entry): Call new function
2016         fast_hash.
2017
2018 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2019
2020         * symtab.c (struct demangled_name_entry): Change type of mangled
2021         to gdb::string_view. Also adds a constructor that takes the
2022         mangled name.
2023         (hash_demangled_name_entry): Update.
2024         (eq_demangled_name_entry): Update.
2025         (free_demangled_name_entry): New function to call the destructor
2026         now that this is not a POD anymore.
2027         (create_demangled_names_hash): Pass free_demangled_name_entry to
2028         htab_create_alloc.
2029         (symbol_set_names): Update.
2030
2031 2019-10-21  Ali Tamur  <tamu@google.com>
2032
2033         * dwarf2read.c (dir_index): Change type.
2034         (file_name_index): Likewise.
2035         (line_header::include_dir_at): Change comment and implementation on
2036         whether it is DWARF 5.
2037         (line_header::is_valid_file_index): New function.
2038         (line_header::file_name_at): Change comment and implementation on
2039         whether it is DWARF 5.
2040         (line_header::file_names): Change to private field renamed as
2041         m_file_names and introduce a new accessor method.
2042         (line_header::file_names_size): New method.
2043         (line_header::include_dirs): Change to private field and rename as
2044         m_include_dirs.
2045         (dw2_get_file_names_reader): Define local var at a smaller scope and
2046         reflect API change.
2047         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2048         (process_structure_scope): Likewise.
2049         (line_header::add_include_dir): Change message and reflect renaming.
2050         (line_header::add_file_name): Likewise.
2051         (read_formatted_entries): Handle DW_FORM_data16.
2052         (dwarf_decode_line_header): Fix line header length calculation.
2053         (psymtab_include_file_name): Change comment and API.
2054         (lnp_state_machine::m_file): Update comment and reflect type change.
2055         (lnp_state_machine::record_line): Reflect type change.
2056         (dwarf_decode_lines): Reflect API change.
2057         (file_file_name): Likewise.
2058         (file_full_name): Likewise.
2059
2060 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2061
2062         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2063
2064 2019-10-21  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2067
2068 2019-10-21  Tom Tromey  <tom@tromey.com>
2069
2070         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2071         NM_H.   Use AC_CONFIG_LINKS.
2072         * configure: Rebuild.
2073         * Makefile.in (NM_H): New variable.
2074         (generated_files): Add NM_H.  Remove gcore.
2075         (nm.h, stamp-nmh): New targets.
2076
2077 2019-10-20  Tom Tromey  <tom@tromey.com>
2078
2079         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2080         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2081         obsolete comment.
2082         (put_objfile_before): Now static.
2083
2084 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2085
2086         * gdbsupport/common-utils.h (startswith): Change return type to
2087         bool.
2088
2089 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2090
2091         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2092         * breakpoint.c (bp_locations_compare): Rename to...
2093         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2094         (update_global_location_list): Use std::sort instead of qsort.
2095         * buildsym.c (compare_line_numbers): Rename to...
2096         (lte_is_less_than): ...this, and change to std::sort semantics.
2097         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2098         instead of qsort.
2099         * disasm.c (compare_lines): Rename to...
2100         (line_is_less_than): ...this, and change to std::sort semantics.
2101         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2102         of qsort.
2103         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2104         (fde_is_less_than): ...this, and change to std::sort semantics.
2105         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2106         * mdebugread.c (compare_blocks):
2107         (block_is_less_than): ...this, and change to std::sort semantics.
2108         (sort_blocks): Call std::sort instead of qsort.
2109         * objfiles.c (qsort_cmp): Rename to...
2110         (sort_cmp): ...this, and change to std::sort semantics.
2111         (update_section_map): Call std::sort instead of qsort.
2112         * remote.c (compare_pnums): Remove.
2113         (map_regcache_remote_table): Call std::sort instead of qsort.
2114         * utils.c (compare_positive_ints): Remove.
2115         * utils.h (compare_positive_ints): Remove.
2116         * xcoffread.c (compare_lte): Remove.
2117         (arrange_linetable): Call std::sort instead of qsort.
2118
2119 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2120
2121         * symfile.c (init_entry_point_info): Fix typo.
2122         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2123
2124 2019-10-18  Tom de Vries  <tdevries@suse.de>
2125
2126         * aarch64-tdep.c: Fix typos in comments.
2127         * ada-lang.c: Same.
2128         * ada-tasks.c: Same.
2129         * alpha-tdep.c: Same.
2130         * alpha-tdep.h: Same.
2131         * amd64-nat.c: Same.
2132         * amd64-windows-tdep.c: Same.
2133         * arc-tdep.c: Same.
2134         * arc-tdep.h: Same.
2135         * arch-utils.c: Same.
2136         * arm-nbsd-tdep.c: Same.
2137         * arm-tdep.c: Same.
2138         * ax-gdb.c: Same.
2139         * blockframe.c: Same.
2140         * btrace.c: Same.
2141         * c-varobj.c: Same.
2142         * coff-pe-read.c: Same.
2143         * coffread.c: Same.
2144         * cris-tdep.c: Same.
2145         * darwin-nat.c: Same.
2146         * dbxread.c: Same.
2147         * dcache.c: Same.
2148         * disasm.c: Same.
2149         * dtrace-probe.c: Same.
2150         * dwarf-index-write.c: Same.
2151         * dwarf2-frame-tailcall.c: Same.
2152         * dwarf2-frame.c: Same.
2153         * dwarf2read.c: Same.
2154         * eval.c: Same.
2155         * exceptions.c: Same.
2156         * fbsd-tdep.c: Same.
2157         * findvar.c: Same.
2158         * frame.c: Same.
2159         * frv-tdep.c: Same.
2160         * gnu-v3-abi.c: Same.
2161         * go32-nat.c: Same.
2162         * h8300-tdep.c: Same.
2163         * hppa-tdep.c: Same.
2164         * i386-linux-tdep.c: Same.
2165         * i386-tdep.c: Same.
2166         * ia64-libunwind-tdep.c: Same.
2167         * ia64-tdep.c: Same.
2168         * infcmd.c: Same.
2169         * infrun.c: Same.
2170         * linespec.c: Same.
2171         * linux-nat.c: Same.
2172         * linux-thread-db.c: Same.
2173         * machoread.c: Same.
2174         * mdebugread.c: Same.
2175         * mep-tdep.c: Same.
2176         * mn10300-tdep.c: Same.
2177         * namespace.c: Same.
2178         * objfiles.c: Same.
2179         * opencl-lang.c: Same.
2180         * or1k-tdep.c: Same.
2181         * osabi.c: Same.
2182         * ppc-linux-nat.c: Same.
2183         * ppc-linux-tdep.c: Same.
2184         * ppc-sysv-tdep.c: Same.
2185         * printcmd.c: Same.
2186         * procfs.c: Same.
2187         * record-btrace.c: Same.
2188         * record-full.c: Same.
2189         * remote-fileio.c: Same.
2190         * remote.c: Same.
2191         * rs6000-tdep.c: Same.
2192         * s12z-tdep.c: Same.
2193         * score-tdep.c: Same.
2194         * ser-base.c: Same.
2195         * ser-go32.c: Same.
2196         * skip.c: Same.
2197         * sol-thread.c: Same.
2198         * solib-svr4.c: Same.
2199         * solib.c: Same.
2200         * source.c: Same.
2201         * sparc-nat.c: Same.
2202         * sparc-sol2-tdep.c: Same.
2203         * sparc-tdep.c: Same.
2204         * sparc64-tdep.c: Same.
2205         * stabsread.c: Same.
2206         * stack.c: Same.
2207         * symfile.c: Same.
2208         * symtab.c: Same.
2209         * target-descriptions.c: Same.
2210         * target-float.c: Same.
2211         * thread.c: Same.
2212         * utils.c: Same.
2213         * valops.c: Same.
2214         * valprint.c: Same.
2215         * value.c: Same.
2216         * varobj.c: Same.
2217         * windows-nat.c: Same.
2218         * xcoffread.c: Same.
2219         * xstormy16-tdep.c: Same.
2220         * xtensa-tdep.c: Same.
2221
2222 2019-10-17  Tom Tromey  <tromey@adacore.com>
2223
2224         * configure: Rebuild.
2225         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2226         in AC_CONFIG_FILES invocation.
2227         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2228         new-style config.status invocation.
2229
2230 2019-10-17  Tom de Vries  <tdevries@suse.de>
2231
2232         * arm-nbsd-nat.c: Fix typos in comments.
2233         * arm-tdep.c: Same.
2234         * darwin-nat-info.c: Same.
2235         * dwarf2read.c: Same.
2236         * elfread.c: Same.
2237         * event-top.c: Same.
2238         * findvar.c: Same.
2239         * gdbtypes.c: Same.
2240         * hppa-tdep.c: Same.
2241         * i386-tdep.c: Same.
2242         * jit.c: Same.
2243         * main.c: Same.
2244         * mdebugread.c: Same.
2245         * moxie-tdep.c: Same.
2246         * nto-procfs.c: Same.
2247         * osabi.c: Same.
2248         * ppc-linux-tdep.c: Same.
2249         * remote.c: Same.
2250         * riscv-tdep.c: Same.
2251         * s390-tdep.c: Same.
2252         * sh-tdep.c: Same.
2253         * sparc-linux-tdep.c: Same.
2254         * sparc-nat.c: Same.
2255         * stack.c: Same.
2256         * target-descriptions.c: Same.
2257         * top.c: Same.
2258         * varobj.c: Same.
2259
2260 2019-10-16  Tom Tromey  <tom@tromey.com>
2261
2262         * objfiles.h (struct objfile) <original_name>: Now const.
2263
2264 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2265
2266         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2267         pass on to sigsetjmp's second argument.
2268         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2269
2270 2019-10-16  Keith Seitz  <keiths@redhat.com>
2271
2272         PR gdb/23567
2273         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2274         sections whose size is greater than the file size.
2275
2276 2019-10-16  Jim Wilson  <jimw@sifive.com>
2277
2278         * riscv-tdep.c (riscv_gcc_target_options): New.
2279         (riscv_gnu_triplet_regexp): New.
2280         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2281         set_gdbarch_gnu_triplet_regexp.
2282
2283 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2284
2285         * Makefile.in: Add xml-builtin.h.
2286         * features/feature_to_c.sh: Add an include for xml-builtin.h
2287         to ensure that the compiler checks that the types match.
2288         * xml-builtin.h: New file.
2289         * xml-support.c (fetch_xml_builtin): Add missing const.
2290         * xml-support.h: Remove declaration of xml_builtins.
2291
2292 2019-10-16  Tom de Vries  <tdevries@suse.de>
2293
2294         PR tdep/25096
2295         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2296         (amd64_classify_aggregate): ... here.
2297         (amd64_classify_aggregate_field): Handled fiels of nested structs
2298         recursively.
2299
2300 2019-10-16  Tom de Vries  <tdevries@suse.de>
2301
2302         PR tdep/24104
2303         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2304         that handles 'theclass'.
2305
2306 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * linespec.c (decode_digits_ordinary): Update comment.
2309         * make-target-delegates: No longer need to handle VEC case.
2310         * memrange.c (normalize_mem_ranges): Update comment.
2311         * namespace.c (add_using_directive): Update comment.
2312         * objc-lang.c (uniquify_strings): Update comment.
2313         * ppc-linux-nat.c (struct thread_points): Update comment.
2314         * probe.h (find_probes_in_objfile): Update comment.
2315         * target.h (enum flash_preserve_mode): Update comment.
2316         * varobj.c (varobj_restrict_range): Update comment.
2317         * varobj.h (varobj_list_children): Update comment.
2318
2319 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2320
2321         * Makefile.in: Remove references to vec.h and vec.c.
2322         * aarch64-tdep.c: No longer include vec.h.
2323         * ada-lang.c: Likewise.
2324         * ada-lang.h: Likewise.
2325         * arm-tdep.c: Likewise.
2326         * ax.h: Likewise.
2327         * breakpoint.h: Likewise.
2328         * charset.c: Likewise.
2329         * cp-support.h: Likewise.
2330         * dtrace-probe.c: Likewise.
2331         * dwarf2read.c: Likewise.
2332         * extension.h: Likewise.
2333         * gdb_bfd.c: Likewise.
2334         * gdbsupport/gdb_vecs.h: Likewise.
2335         * gdbsupport/vec.c: Remove.
2336         * gdbsupport/vec.h: Remove.
2337         * gdbthread.h: Likewise.
2338         * guile/scm-type.c: Likewise.
2339         * inline-frame.c: Likewise.
2340         * machoread.c: Likewise.
2341         * memattr.c: Likewise.
2342         * memrange.h: Likewise.
2343         * namespace.h: Likewise.
2344         * nat/linux-btrace.h: Likewise.
2345         * osdata.c: Likewise.
2346         * parser-defs.h: Likewise.
2347         * progspace.h: Likewise.
2348         * python/py-type.c: Likewise.
2349         * record-btrace.c: Likewise.
2350         * rust-exp.y: Likewise.
2351         * solib-target.c: Likewise.
2352         * stap-probe.c: Likewise.
2353         * target-descriptions.c: Likewise.
2354         * target-memory.c: Likewise.
2355         * target.h: Likewise.
2356         * varobj.c: Likewise.
2357         * varobj.h: Likewise.
2358         * xml-support.h: Likewise.
2359
2360 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2361
2362         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2363         Update for new std::vector based implementation.
2364         (process_psymtab_comp_unit_reader): Likewise.
2365         (scan_partial_symbols): Likewise.
2366         (recursively_compute_inclusions): Likewise.
2367         (compute_compunit_symtab_includes): Likewise.
2368         (process_imported_unit_die): Likewise.
2369         (queue_and_load_dwo_tu): Likewise.
2370         (follow_die_sig_1): Likewise.
2371         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2372         (typedef dwarf2_per_cu_ptr): Remove.
2373         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2374         function.
2375         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2376         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2377         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2378         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2379         std::vector.
2380
2381 2019-10-15  Tom Tromey  <tromey@adacore.com>
2382
2383         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2384         TID.
2385
2386 2019-10-15  Tom Tromey  <tromey@adacore.com>
2387
2388         * windows-nat.c (windows_nat_target::fetch_registers)
2389         (windows_nat_target::store_registers): Rename "pid" to "tid".
2390
2391 2019-10-15  Tom Tromey  <tromey@adacore.com>
2392
2393         * gdbarch.h, gdbarch.c: Rebuild.
2394         * gdbarch.sh (gcc_target_options): Change return type to
2395         std::string.
2396         * compile/compile.c (get_args): Update.
2397         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2398         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2399         std::string.
2400         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2401         std::string.
2402         * arch-utils.c (default_gcc_target_options): Return std::string.
2403         * arch-utils.h (default_gcc_target_options): Return std::string.
2404         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2405
2406 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2407
2408         * breakpoint.c (breakpoint_chain): Make static.
2409         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2410         of accessing breakpoint_chain.
2411
2412 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2413
2414         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2415         to a gdb::function_view and return value to bool.
2416         * breakpoint.h (iterate_over_breakpoints): Likewise.
2417         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2418         (pop_dummy_frame): Update.
2419         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2420         (gdbscm_breakpoints): Update.
2421         * python/py-breakpoint.c (build_bp_list): Update.
2422         (gdbpy_breakpoints): Update.
2423         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2424         Update.
2425         (bpfinishpy_handle_stop): Update.
2426         (bpfinishpy_handle_exit): Update.
2427         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2428         (svr4_update_solib_event_breakpoints): Update.
2429
2430 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2431
2432         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2433         when unwrapping single-field structs.
2434
2435 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2436
2437         * dwarf2read.c: Remove includes.
2438
2439 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2440
2441         * ui-out.c (ui_out::call_do_message): Silence
2442         -Wformat-nonliteral warning.
2443
2444 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2445
2446         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2447         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2448         include: readline/tilde.h.
2449
2450 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2451
2452         * remote.c (remote_target::get_trace_status): Remove declaration of
2453         trace_regblock_size.
2454
2455 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2456
2457         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2458         (show_user): Remove declaration of cmdlist.
2459         * cli/cli-cmds.h (max_user_call_depth): Declare.
2460         * cli/cli-script.c (execute_user_command): Remove declaration
2461         of max_user_call_depth.
2462
2463 2019-10-11  Jim Wilson  <jimw@sifive.com>
2464
2465         * gdbsupport/print-utils.h (pulongest): Fix comment.
2466         (plongest): Likewise.
2467         (phex): Add missing comment, mention leading zeros.
2468         (phex_nz): Add mention of no leading zeros to comment.
2469
2470         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2471         plongest instead of unsigned long long cast.
2472
2473 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2474
2475         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2476         for external_editor_command and gdbtk_test.
2477
2478 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2479
2480         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2481         * varobj.c (varobjdebug): Move comment to...
2482         * varobj.h (varobjdebug): ...here, and declare.
2483
2484 2019-10-09  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2487         erase_data_content.
2488
2489 2019-10-09  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2492         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2493         * tui/tui-command.c (tui_cmd_window::resize)
2494         (tui_refresh_cmd_win): Update.
2495         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2496         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2497         * tui/tui-data.c (~tui_gen_win_info): Remove.
2498         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2499         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2500         (tui_redisplay_readline, tui_mld_flush)
2501         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2502         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2503         (tui_data_window::erase_data_content)
2504         (tui_data_item_window::rerender)
2505         (tui_data_item_window::refresh_window): Update.
2506         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2507         (box_win, tui_gen_win_info::make_window)
2508         (tui_gen_win_info::make_visible): Update.
2509         (tui_delete_win): Remove.
2510         * tui/tui-winsource.c
2511         (tui_source_window_base::do_erase_source_content): Update.
2512         (tui_show_source_line, tui_source_window_base::update_tab_width)
2513         (tui_source_window_base::update_exec_info): Update.
2514         * tui/tui-data.h (struct curses_deleter): New.
2515         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2516         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2517
2518 2019-10-09  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2521
2522 2019-10-09  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2525         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2526
2527 2019-10-09  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2530         window height directly.
2531         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2532         declare.
2533         * tui/tui-layout.c (tui_default_win_height): Remove.
2534         (tui_default_win_viewport_height): Remove.
2535
2536 2019-10-09  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui.h: Remove comments.
2539
2540 2019-10-09  Tom de Vries  <tdevries@suse.de>
2541
2542         * python/lib/gdb/printer/bound_registers.py: Use
2543         '^builtin_type_bound128' as regexp argument for
2544         add_builtin_pretty_printer.
2545
2546 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2547
2548         * guile/guile.c (guile_extension_script_ops): Remove forward
2549         declaration and mark as static.
2550         (guile_script_ops): Likewise.
2551         (extension_language_guile): Move further down in the file so
2552         it can reference the definitions for guile_{extension_,}script_ops.
2553
2554 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2555
2556         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2557         except SORTL, DFLTCC, and KDSA.
2558
2559 2019-10-08  Tom Tromey  <tromey@adacore.com>
2560
2561         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2562         (struct safe_symbol_file_add_args): Remove.
2563
2564 2019-10-08  Tom Tromey  <tromey@adacore.com>
2565
2566         * windows-nat.c: Don't include buildsym-legacy.h.
2567
2568 2019-10-08  Tom Tromey  <tromey@adacore.com>
2569
2570         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2571
2572 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2573
2574         * gdbtypes.c (overload_debug): Move comment to header.
2575         * gdbtypes.h (overload_debug): Declare.
2576         * valops.c: Remove declaration of overload_debug, instead
2577         include gdbtypes.h.
2578
2579 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2580
2581         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2582         through _().
2583         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2584         move comment...
2585         * language.h (lang_frame_mismatch_warn): ... here. Also add
2586         declaration.
2587         * top.c (lang_frame_mismatch_warn): Remove declaration.
2588         (check_frame_language_change): Pass lang_frame_mismatch_warn
2589         through _().
2590
2591 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2592
2593         * c-lang.h (vtbl_ptr_name): Declare.
2594         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2595         it from the header.
2596         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2597
2598 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2599
2600         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2601         gdb_static_assert.
2602
2603 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2604
2605         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2606         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2607         * ctfread.c: New file.
2608         * ctfread.h: New file.
2609         * elfread.c: Include ctfread.h.
2610         (struct elfinfo text_p): New member ctfsect.
2611         (elf_locate_sections): Mark CTF section.
2612         (elf_symfile_read): Call elfctf_build_psymtabs.
2613         * Makefile.in (LIBCTF): Add.
2614         (CLIBS): Use it.
2615         (CDEPS): Likewise.
2616         (DIST): Add ctfread.c.
2617
2618 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2619
2620         * ctfread.c (struct nextfield): Renamed to ...
2621         (struct ctf_nextfield): ... this.
2622         (struct field_info): Renamed to ...
2623         (strut ctf_field_info): ... this.
2624         (attach_fields_to_type): Update for renamed structures.
2625         (ctf_add_member_cb): Likewise.
2626         (ctf_add_enum_member_cb): Likewise.
2627         (process_struct_members): Likewise.
2628         (process_enum_type): Likewise.
2629
2630 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2631
2632         * tracectf.h: Rename, was ctf.h.
2633         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2634         * tracefile.c: Likewise.
2635         * tracepoint.c: Remove unused include ctf.h.
2636         * mi/mi-main.c: Likewise.
2637         * Makefile.in Replace ctf.c with tracectf.c.
2638
2639 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2640
2641         * version.in: Change version number to "9.0.50.DATE-git".
2642
2643 2019-10-03  Tom Tromey  <tom@tromey.com>
2644
2645         PR rust/24976:
2646         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2647
2648 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2649
2650         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2651         cp_search_name_hash.
2652         * NEWS: Add entry about nested function support.
2653
2654 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2655             Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2658         for nested static variables when searchin VAR_DOMAIN.
2659         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2660         global scope, update comment.
2661         (add_partial_subprogram): Call add_partial_subprogram recursively
2662         for nested subroutines when processinng Fortran.
2663         (load_partial_dies): Process the child entities of a subprogram
2664         when processing Fortran.
2665         (partial_die_parent_scope): Handle building scope
2666         for Fortran nested functions.
2667         (process_die): Record that nested functions have a scope.
2668         (new_symbol): Always record Fortran subprograms on the global
2669         symbol list.
2670         (determine_prefix): How to build the prefix for Fortran
2671         subprograms.
2672
2673 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2676         have just sent the thread a SIGSTOP and are waiting for it to
2677         arrive.
2678
2679 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2680
2681         * btrace.c (btrace_add_pc): Remove whitespace before the template
2682         parameter in 'std::vector <...>'.
2683         (parse_xml_btrace_block): Likewise.
2684         (btrace_maint_decode_pt): Likewise.
2685         (btrace_maint_update_packets): Likewise.
2686         (btrace_maint_print_packets): Likewise.
2687         * btrace.h (struct btrace_maint_info): Likewise.
2688         * dwarf2read.c (struct type_unit_group): Likewise.
2689         (build_type_psymtabs_reader): Likewise.
2690         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2691         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2692         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2693
2694 2019-10-03  Tom de Vries  <tdevries@suse.de>
2695
2696         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2697         the first line of the help text for set/show style metadata.
2698
2699 2019-10-02  Tom Tromey  <tromey@adacore.com>
2700
2701         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2702         * gdbsupport/common-inferior.c: New file.
2703         * infcmd.c (startup_with_shell): Don't define.
2704         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2705         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2706         * inferior.h (startup_with_shell): Don't declare.
2707
2708 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2709
2710         * gdbsupport/gdb_assert.h: Include errors.h.
2711         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2712
2713 2019-10-02  Tom Tromey  <tromey@adacore.com>
2714
2715         * NEWS: Add $_ada_exception entry.
2716         * ada-lang.c (struct ada_catchpoint): Add constructor.
2717         <m_kind>: New member.
2718         (allocate_location_exception, re_set_exception): Remove
2719         "ex" parameter.
2720         (should_stop_exception): Compute $_ada_exception.
2721         (check_status_exception, print_it_exception)
2722         (print_one_exception, print_mention_exception): Remove
2723         "ex" parameter.
2724         (allocate_location_catch_exception, re_set_catch_exception)
2725         (check_status_exception, print_it_catch_exception)
2726         (print_one_catch_exception, print_mention_catch_exception)
2727         (print_recreate_catch_exception)
2728         (allocate_location_catch_exception_unhandled)
2729         (re_set_catch_exception_unhandled)
2730         (check_status_exception, print_it_catch_exception_unhandled)
2731         (print_one_catch_exception_unhandled)
2732         (print_mention_catch_exception_unhandled)
2733         (print_recreate_catch_exception_unhandled)
2734         (allocate_location_catch_assert, re_set_catch_assert)
2735         (check_status_assert, print_it_catch_assert)
2736         (print_one_catch_assert, print_mention_catch_assert)
2737         (print_recreate_catch_assert)
2738         (allocate_location_catch_handlers, re_set_catch_handlers)
2739         (check_status_handlers, print_it_catch_handlers)
2740         (print_one_catch_handlers, print_mention_catch_handlers)
2741         (print_recreate_catch_handlers): Remove.
2742         (create_ada_exception_catchpoint): Update.
2743         (initialize_ada_catchpoint_ops): Update.
2744
2745 2019-10-02  Tom Tromey  <tromey@adacore.com>
2746
2747         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2748         (create_excep_cond_exprs): Simplify exception string computation.
2749         (ada_exception_catchpoint_cond_string): Likewise.
2750
2751 2019-10-02  Tom Tromey  <tromey@adacore.com>
2752
2753         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2754         * ada-lang.c (lesseq_defined_than): Handle
2755         LOC_STATIC.
2756         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2757         parameter.
2758         (dwarf2_has_info): Likewise.
2759         (new_symbol): Set maybe_copied on symbol when
2760         appropriate.
2761         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2762         parameter.
2763         <can_copy>: New member.
2764         * elfread.c (record_minimal_symbol): Set maybe_copied
2765         on symbol when appropriate.
2766         (elf_symfile_read): Update call to dwarf2_has_info.
2767         * minsyms.c (lookup_minimal_symbol_linkage): New
2768         function.
2769         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2770         * symtab.c (get_symbol_address, get_msymbol_address):
2771         New functions.
2772         * symtab.h (get_symbol_address, get_msymbol_address):
2773         Declare.
2774         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2775         maybe_copied.
2776         (struct symbol, struct minimal_symbol) <maybe_copied>:
2777         New member.
2778
2779 2019-10-02  Tom Tromey  <tromey@adacore.com>
2780
2781         * source.c (struct current_source_location): New.
2782         (current_source_key): New global.
2783         (current_source_symtab, current_source_line)
2784         (current_source_pspace): Remove.
2785         (get_source_location): New function.
2786         (get_current_source_symtab_and_line)
2787         (set_default_source_symtab_and_line)
2788         (set_current_source_symtab_and_line)
2789         (clear_current_source_symtab_and_line, select_source_symtab)
2790         (info_source_command, print_source_lines_base)
2791         (info_line_command, search_command_helper, _initialize_source):
2792         Update.
2793
2794 2019-10-02  Tom Tromey  <tromey@adacore.com>
2795
2796         * source.c (select_source_symtab): Don't call
2797         decode_line_with_current_source.
2798
2799 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * symtab.c (lookup_global_symbol): Search global block.
2802
2803 2019-10-02  Tom Tromey  <tromey@adacore.com>
2804
2805         * coffread.c (process_coff_symbol): Update.
2806         * dwarf2read.c (var_decode_location, new_symbol): Update.
2807         * mdebugread.c (parse_symbol): Update.
2808         * objfiles.c (relocate_one_symbol): Update.
2809         * stabsread.c (define_symbol, fix_common_block)
2810         (scan_file_globals): Update.
2811         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2812         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2813         * xcoffread.c (process_xcoff_symbol): Update.
2814
2815 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2816
2817         * MAINTAINERS: Update my email address.
2818
2819 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2820
2821         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2822         std::vector.
2823         (build_type_psymtabs_reader): Update for std::vector.
2824         (build_type_psymtab_dependencies): Likewise.
2825         * dwarf2read.h: Remove use of DEF_VEC_P.
2826         (typedef sig_type_ptr): Delete.
2827
2828 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2829
2830         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2831         to std::vector.
2832         (btrace_maint_decode_pt): Likewise, and move allocation of the
2833         vector outside of the loop.
2834         (btrace_maint_update_packets): Update to handle change from VEC to
2835         std::vector.
2836         (btrace_maint_print_packets): Likewise.
2837         (maint_info_btrace_cmd): Likewise.
2838         * btrace.h: Remove use of DEF_VEC_O.
2839         (typedef btrace_pt_packet_s): Delete.
2840         (struct btrace_maint_info) <packets>: Change fromm VEC to
2841         std::vector.
2842         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2843
2844 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2845
2846         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2847         make accesses into the vector constant references.
2848         (btrace_add_pc): Update for std::vector.
2849         (btrace_stitch_bts): Likewise.
2850         (parse_xml_btrace_block): Likewise.
2851         (btrace_maint_update_packets): Likewise.
2852         (btrace_maint_print_packets): Likewise.
2853         (maint_info_btrace_cmd): Likewise.
2854         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2855         std::vector.
2856         (btrace_data::empty): Likewise.
2857         (btrace_data_append): Likewise.
2858         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2859         (typedef btrace_block_s): Delete.
2860         (struct btrace_block): Add constructor.
2861         (struct btrace_data_bts) <blocks>: Change to std::vector.
2862         * nat/linux-btrace.c (perf_event_read_bts): Update for
2863         std::vector.
2864         (linux_read_bts): Likewise.
2865
2866 2019-10-01  Tom Tromey  <tom@tromey.com>
2867
2868         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2869
2870 2019-10-01  Tom Tromey  <tom@tromey.com>
2871
2872         * stack.c (print_frame, info_frame_command_core): Use
2873         styled_string.
2874         * linux-thread-db.c (try_thread_db_load_1)
2875         (try_thread_db_load_from_pdir_1): Use styled_string.
2876         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2877         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2878         (maybe_print_unsupported_script_warning)
2879         (maybe_print_script_not_found_warning): Use styled_string.
2880         * ada-lang.c (user_select_syms): Use styled_string.
2881
2882 2019-10-01  Tom Tromey  <tom@tromey.com>
2883
2884         * p-lang.c (pascal_printstr): Use metadata style.
2885         * value.c (show_convenience): Use metadata style.
2886         * valprint.c (valprint_check_validity, val_print_optimized_out)
2887         (val_print_not_saved, val_print_unavailable)
2888         (val_print_invalid_address, generic_val_print, val_print)
2889         (value_check_printable, val_print_array_elements): Use metadata
2890         style.
2891         * ui-out.h (class ui_out) <field_fmt>: New overload.
2892         <do_field_fmt>: Add style parameter.
2893         * ui-out.c (ui_out::field_fmt): New overload.
2894         * typeprint.c (type_print_unknown_return_type)
2895         (val_print_not_allocated, val_print_not_associated): Use metadata
2896         style.
2897         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2898         parameter.
2899         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2900         * tracepoint.c (tvariables_info_1): Use metadata style.
2901         * stack.c (print_frame_arg, print_frame_info, print_frame)
2902         (info_frame_command_core): Use metadata style.
2903         * skip.c (info_skip_command): Use metadata style.
2904         * rust-lang.c (rust_print_enum): Use metadata style.
2905         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2906         metadata style.
2907         * python/py-framefilter.c (py_print_single_arg): Use metadata
2908         style.
2909         * printcmd.c (do_one_display, print_variable_and_value): Use
2910         metadata style.
2911         * p-valprint.c (pascal_val_print)
2912         (pascal_object_print_value_fields): Use metadata style.
2913         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2914         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2915         parameter.
2916         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2917         * m2-valprint.c (m2_print_long_set): Use metadata style.
2918         * m2-typeprint.c (m2_print_type): Use metadata style.
2919         * infcmd.c (print_return_value_1): Use metadata style.
2920         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2921         * f-valprint.c (info_common_command_for_block): Use metadata
2922         style.
2923         * f-typeprint.c (f_type_print_base): Use metadata style.
2924         * expprint.c (print_subexp_standard): Use metadata style.
2925         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2926         * cli/cli-style.h (class cli_style_option): Add constructor.
2927         (metadata_style): Declare.
2928         * cli/cli-style.c (metadata_style): New global.
2929         (_initialize_cli_style): Register metadata style.
2930         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2931         parameter.
2932         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2933         * c-typeprint.c (c_type_print_base_struct_union)
2934         (c_type_print_base_1): Use metadata style.
2935         * breakpoint.c (watchpoint_value_print)
2936         (print_one_breakpoint_location): Use metadata style.
2937         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2938         style.
2939         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2940         style.
2941         * ada-valprint.c (val_print_packed_array_elements, printstr)
2942         (print_field_values, ada_val_print_ref, ada_val_print): Use
2943         metadata style.
2944         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2945         style.
2946         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2947         style.
2948         * ada-lang.c (user_select_syms): Use metadata style.
2949
2950 2019-10-01  Tom Tromey  <tom@tromey.com>
2951
2952         * cli/cli-cmds.c (pwd_command): Style output.
2953
2954 2019-10-01  Pedro Alves  <palves@redhat.com>
2955             Tom Tromey  <tom@tromey.com>
2956
2957         * symtab.c (print_symbol_info): Use %ps.
2958         (print_msymbol_info): Use %ps.
2959         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2960         * printcmd.c (print_variable_and_value): Use %ps.
2961         * macrocmd.c (show_pp_source_pos): Use %ps.
2962         * infrun.c (print_exited_reason): Use ui_out::message.
2963         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2964         (describe_other_breakpoints): Use ui_out::message and new
2965         formats.
2966         (say_where): Use new formats.
2967         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2968         and new formats.
2969
2970 2019-10-01  Pedro Alves  <palves@redhat.com>
2971             Tom Tromey  <tom@tromey.com>
2972
2973         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2974         (test_gdb_formats): New function.
2975         (run_tests): Call it.
2976         (test_format_specifier): Update.
2977         * utils.h (fputs_filtered): Update comment.
2978         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2979         (fputs_styled_unfiltered): Declare.
2980         * utils.c (fputs_styled_unfiltered): New function.
2981         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2982         (vfprintf_filtered): Update.
2983         (vfprintf_unfiltered, vprintf_filtered): Update.
2984         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2985         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2986         disallow_ui_out_field>: New constants.
2987         (enum class field_kind): New.
2988         (struct base_field_s, struct signed_field_s): New.
2989         (signed_field): New function.
2990         (struct string_field_s): New.
2991         (string_field): New function.
2992         (struct styled_string_s): New.
2993         (styled_string): New function.
2994         (class ui_out) <message>: Add comment.
2995         <vmessage, call_do_message>: New methods.
2996         <do_message>: Add style parameter.
2997         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2998         methods.
2999         (ui_out::message): Rewrite.
3000         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3001         parameter.
3002         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3003         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3004         gdb_extensions parameter.
3005         (class format_piece): Add parameter to constructor.
3006         (n_int_args): New field.
3007         * gdbsupport/format.c (format_pieces::format_pieces): Add
3008         gdb_extensions parameter.  Handle '*'.
3009         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3010         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3011         vfprintf_styled_no_gdbfmt.
3012         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3013         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3014         unfiltered output.
3015         * ui-style.h (struct ui_file_style) <ptr>: New method.
3016
3017 2019-10-01  Tom Tromey  <tom@tromey.com>
3018
3019         * unittests/format_pieces-selftests.c: Update.  Add final format.
3020         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3021         empty literal pieces.
3022
3023 2019-10-01  Tom Tromey  <tom@tromey.com>
3024
3025         * ui-out.h (enum class ui_out_style_kind): Remove.
3026         (class ui_out) <field_string, field_stsream, do_field_string>:
3027         Change type of "style".
3028         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3029         (ui_out::field_string): Update.
3030         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3031         of "style".
3032         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3033         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3034         * stack.c (print_frame_arg, print_frame_info, print_frame):
3035         Update.
3036         * source.c (print_source_lines_base): Update.
3037         * solib.c (info_sharedlibrary_command): Update.
3038         * skip.c (info_skip_command): Update.
3039         * record-btrace.c (btrace_call_history_src_line)
3040         (btrace_call_history): Update.
3041         * python/py-framefilter.c (py_print_frame): Update.
3042         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3043         "style".
3044         * mi/mi-out.c (mi_ui_out::do_table_header)
3045         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3046         (mi_ui_out::do_field_string): Update.
3047         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3048         Update.
3049         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3050         "style".
3051         * cli-out.c (cli_ui_out::do_table_header)
3052         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3053         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3054         (cli_ui_out::do_field_fmt): Update.
3055         * breakpoint.c (print_breakpoint_location): Update.
3056         (update_static_tracepoint): Update.
3057
3058 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3059
3060         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3061         conversion of gdb_datadir.
3062         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3063         remove not needed c_str ().
3064
3065 2019-09-30  Ali Tamur <tamur@google.com>
3066
3067         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3068         (dwarf2_string_attr): Likewise.
3069
3070 2019-09-30  Ali Tamur <tamur@google.com>
3071
3072         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3073         (process_full_type_unit): Likewise.
3074         (dump_die_shallow): Likewise.
3075         (cu_debug_loc_section): Likewise.
3076
3077 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3078
3079         * minsyms.c (compare_minimal_symbols): Rename to...
3080         (minimal_symbol_is_less_than): ...this, and adjust to STL
3081         conventions (return bool, take arguments as references)
3082         (minimal_symbol_reader::install): Call std::sort instead
3083         of qsort.
3084
3085 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3086
3087         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3088         hash and why.
3089         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3090         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3091
3092 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3093
3094         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3095         * psympriv.h (add_psymbol_to_list): Move comment here and update
3096         it.
3097
3098 2019-09-29  Tom de Vries  <tdevries@suse.de>
3099
3100         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3101         Use $tmpdir/$(basename "$output_file").dwz instead of
3102         "${output_file}.dwz".
3103
3104 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3105
3106         PR gdb/25045
3107         * hppa-linux-nat.c: Include gdbarch.h.
3108
3109 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3110
3111         * blockframe.c (find_pc_partial_function): Change return type to bool.
3112         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3113         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3114         (stub_gnu_ifunc_resolve_name): Likewise.
3115         * symtab.c (compare_filenames_for_search): Likewise.
3116         (compare_glob_filenames_for_search): Likewise.
3117         (matching_obj_sections): Likewise.
3118         (symbol_matches_domain): Likewise.
3119         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3120         (find_line_pc): Change return type to bool.
3121         (find_line_pc_range): Likewise.
3122         (producer_is_realview): Likewise.
3123         * symtab.h (symbol_matches_domain): Likewise.
3124         (find_pc_partial_function): Likewise.
3125         (find_pc_line_pc_range): Likewise.
3126         (in_gnu_ifunc_stub): Likewise.
3127         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3128         (find_line_pc): Likewise.
3129         (find_line_pc_range): Likewise.
3130         (matching_obj_sections): Likewise.
3131         (find_line_symtab): Change out parameter to bool.
3132         (producer_is_realview): Change return type to bool.
3133         (compare_filenames_for_search): Likewise.
3134         (compare_glob_filenames_for_search): Likewise.
3135
3136 2019-09-26  Tom Tromey  <tom@tromey.com>
3137
3138         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3139         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3140         * gdb_usleep.h: Remove.
3141         * gdb_usleep.c: Remove.
3142         * utils.c: Don't include gdb_usleep.h.
3143
3144 2019-09-26  Tom Tromey  <tromey@adacore.com>
3145
3146         * python/py-type.c (type_to_type_object): Call check_typedef
3147         for stub types.
3148
3149 2019-09-26  Tom Tromey  <tom@tromey.com>
3150
3151         * utils.h (initialize_utils): Don't declare.
3152         * top.c (gdb_init): Don't call initialize_utils.
3153         * utils.c (initialize_utils): Remove.  Move contents...
3154         (_initialize_utils): ... here.
3155
3156 2019-09-25  Tom Tromey  <tom@tromey.com>
3157
3158         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3159         * utils.h (make_hex_string): Don't declare.
3160         * utils.c (make_hex_string): Remove.
3161
3162 2019-09-24  Tom de Vries  <tdevries@suse.de>
3163
3164         PR gdb/23815
3165         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3166         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3167
3168 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3169
3170         * NEWS: Mention new simulator port for PRU.
3171
3172 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3173
3174         * ada-exp.y (write_object_remaining): Update.
3175         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3176         and eliminate the static buffer.
3177         (ada_decode_symbol): Update.
3178         (ada_la_decode): Update.
3179         (ada_sniff_from_mangled_name): Update.
3180         (is_valid_name_for_wild_match): Update.
3181         (ada_lookup_name_info::matches): Update and simplify.
3182         (name_matches_regex): Update.
3183         (ada_add_global_exceptions): Update.
3184         * ada-lang.h (ada_decode): Update signature.
3185         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3186         * dwarf-index-write.c (debug_names::insert): Update.
3187
3188 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3189
3190         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3191         formatting.
3192
3193 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3194
3195         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3196         Change "nonzero" to "true" in documentation.
3197
3198 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3199
3200         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3201         (_initialize_darwin_solib): Don't set
3202         darwin_so_ops.lookup_lib_global_symbol.
3203         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3204         set_gdbarch_iterate_over_objfiles_in_search_order.
3205         (elf_lookup_lib_symbol): Rename to...
3206         (svr4_iterate_over_objfiles_in_search_order): this, and update
3207         to iterate semantics.
3208         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3209         * solib.c (solib_global_lookup): Remove.
3210         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3211         (solib_global_lookup): Remove.
3212         * symtab.c (lookup_global_or_static_symbol): Remove call to
3213         solib_global_lookup.
3214
3215 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3216
3217         * NEWS: Move entries about default MI version now being
3218         version 3, and about the GDB/MI fix for multi-location
3219         breakpoints to the "since GDB 8.3" section.
3220
3221 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3222
3223         GDB 8.3.1 released.
3224
3225 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3226
3227         * NEWS: Mention that Cell/B.E. debugging support was removed.
3228         * MAINTAINERS: Remove spu target.
3229
3230         * config/djgpp/fnchange.lst: Remove entries for removed files.
3231
3232         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3233         spu-multiarch.o, and spu-tdep.o.
3234         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3235         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3236         spu-multiarch.c, and spu-tdep.c.
3237         * spu-linux-nat.c: Remove file.
3238         * spu-multiarch.c: Remove file.
3239         * spu-tdep.c: Remove file.
3240         * spu-tdep.h: Remove file.
3241         * solib-spu.c: Remove file.
3242         * solib-spu.h: Remove file.
3243
3244         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3245         * configure.nat (spu-linux): Remove.
3246         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3247         solib-multiarch.o from gdb_target_obs.
3248         (spu*-*-*): Remove.
3249
3250         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3251         feature flag.
3252         (ppc_linux_no_features): Update.
3253         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3254         Cell/B.E. support.
3255         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3256         (tdesc_powerpc_cell64l): Likewise.
3257         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3258         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3259         Cell/B.E. support.
3260         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3261         Do not include "features/rs6000/powerpc-cell32l.c" or
3262         "features/rs6000/powerpc-cell64l.c".
3263         (ppc_linux_spu_section): Remove.
3264         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3265         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3266         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3267         (ppc_linux_spe_context_lookup): Remove.
3268         (ppc_linux_spe_context_inferior_created): Remove.
3269         (ppc_linux_spe_context_solib_loaded): Remove.
3270         (ppc_linux_spe_context_solib_unloaded): Remove.
3271         (ppc_linux_spe_context): Remove.
3272         (struct ppu2spu_cache): Remove.
3273         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3274         (struct ppu2spu_data): Remove.
3275         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3276         ppu2spu_unwind): Remove.
3277         (ppc_linux_init_abi): Remove Cell/B.E. support.
3278         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3279
3280         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3281         (rs6000/powerpc-cell64l-expedite): Likewise
3282         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3283         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3284         rs6000/powerpc-cell64l.xml.
3285         * features/rs6000/powerpc-cell32l.xml: Remove.
3286         * features/rs6000/powerpc-cell64l.xml: Likewise.
3287         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3288         * features/rs6000/powerpc-cell64l.c: Likewise.
3289         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3290         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3291         * regformats/reg-spu.dat: Remove.
3292
3293         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3294         * corelow.c (struct spuid_list): Remove.
3295         (add_to_spuid_list): Remove.
3296         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3297         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3298         (remote_protocol_features): Remove associated entries.
3299         (_initialize_remote): No longer initialize them.
3300         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3301         * linux-nat.c (SPUFS_MAGIC): Remove.
3302         (linux_proc_xfer_spu): Remove.
3303         (spu_enumerate_spu_ids): Remove.
3304         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3305         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3306         (linux_make_corefile_notes): No longer call it.
3307
3308         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3309         (cooked_write_test): Likewise.
3310
3311 2019-09-20  Tom Tromey  <tom@tromey.com>
3312
3313         * NEWS: Mention case-sensitivity of TUI commands.
3314         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3315         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3316         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3317
3318 2019-09-20  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-source.c (tui_source_window::set_contents): Use
3321         make_unique_xstrdup.
3322         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3323         make_unique_xstrdup.
3324
3325 2019-09-20  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-data.c: Remove separator comments.
3328         * tui/tui-layout.c: Remove separator comments.
3329         * tui/tui-win.c: Remove separator comments.
3330         * tui/tui-wingeneral.c: Remove separator comments.
3331
3332 2019-09-20  Tom Tromey  <tom@tromey.com>
3333
3334         * tui/tui.h (strcat_to_buf): Don't declare.
3335         * tui/tui.c (strcat_to_buf): Remove.
3336
3337 2019-09-20  Tom Tromey  <tom@tromey.com>
3338
3339         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3340         from "fullname".
3341         * tui/tui-source.c (tui_source_window::set_contents)
3342         (tui_source_window::location_matches_p)
3343         (tui_source_window::maybe_update): Update.
3344
3345 2019-09-20  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3348         Update.
3349         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3350         prefix.
3351         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3352         (tui_data_window::line_from_reg_element_no)
3353         (tui_data_window::first_reg_element_no_inline)
3354         (tui_data_window::show_registers)
3355         (tui_data_window::show_register_group)
3356         (tui_data_window::display_registers_from)
3357         (tui_data_window::display_registers_from_line)
3358         (tui_data_window::first_data_item_displayed)
3359         (tui_data_window::delete_data_content_windows)
3360         (tui_data_window::erase_data_content)
3361         (tui_data_window::do_scroll_vertical)
3362         (tui_data_window::refresh_window)
3363         (tui_data_window::check_register_values): Update.
3364
3365 2019-09-20  Tom Tromey  <tom@tromey.com>
3366
3367         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3368         (struct tui_locator_window) <full_name, proc_name>: Now
3369         std::string.
3370         * tui/tui-stack.c (tui_locator_window::make_status_line)
3371         (tui_locator_window::set_locator_fullname)
3372         (tui_locator_window::set_locator_info): Update.
3373         * tui/tui-source.c (tui_source_window::set_contents)
3374         (tui_source_window::showing_source_p): Update.
3375
3376 2019-09-20  Tom Tromey  <tom@tromey.com>
3377
3378         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3379         Don't call tui_locator_win_info_ptr.
3380
3381 2019-09-20  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3384
3385 2019-09-20  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3388         height for locator.
3389         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3390         * tui/tui-layout.c (show_source_disasm_command, show_data)
3391         (show_source_or_disasm_and_command): Use 1 as height for locator.
3392
3393 2019-09-20  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui.c (tui_enable): Update.
3396         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3397         Update.
3398         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3399         Update.
3400         * tui/tui-data.c (win_resized): Now bool.
3401         (tui_win_resized): Return bool.
3402         (tui_set_win_resized_to): Accept a bool.
3403
3404 2019-09-20  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3407         Change type of "refresh_values_only".
3408         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3409         type of "refresh_values_only".
3410
3411 2019-09-20  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3414         std::string.
3415         (tui_disassemble): Add "pos" parameter.
3416         (tui_disasm_window::set_contents): Simplify.
3417
3418 2019-09-20  Tom Tromey  <tom@tromey.com>
3419
3420         * tui/tui-winsource.h (struct tui_source_window_base)
3421         <show_source_content>: Now private.
3422         * tui/tui-winsource.c
3423         (tui_source_window_base::show_source_content): Don't handle empty
3424         content case.
3425
3426 2019-09-20  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-layout.c (show_source_disasm_command)
3429         (show_source_or_disasm_and_command): Don't call
3430         show_source_content.
3431
3432 2019-09-20  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3435         Declare.
3436         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3437         from tui_make_status_line.
3438         (tui_locator_window::rerender): Update.
3439
3440 2019-09-20  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3443         (tui_locator_window::rerender): Update.
3444
3445 2019-09-20  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-winsource.h (struct tui_source_window_base)
3448         <~tui_source_window_base>: Don't declare.
3449         <fullname>: Remove.
3450         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3451         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3452         member.
3453         * tui/tui-source.c (tui_source_window::set_contents): Update.
3454         (tui_source_window::location_matches_p)
3455         (tui_source_window::maybe_update): Update.
3456
3457 2019-09-20  Tom Tromey  <tom@tromey.com>
3458
3459         * tui/tui-winsource.h (~tui_source_element): Remove.
3460         (tui_source_element): Update.
3461         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3462         * tui/tui-winsource.c (tui_show_source_line): Update.
3463         * tui/tui-source.c (tui_source_window::set_contents): Update.
3464         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3465
3466 2019-09-20  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3469         declare.
3470         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3471         tui_clear_source_windows_detail.
3472         * tui/tui-winsource.h (struct tui_source_window_base)
3473         <clear_detail>: Don't declare.
3474         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3475         Remove.
3476         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3477
3478 2019-09-20  Tom Tromey  <tromey@adacore.com>
3479
3480         PR ada/24919:
3481         * block.c (contained_in): Fix final return value.
3482
3483 2019-09-20  Alan Modra  <amodra@gmail.com>
3484
3485         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3486         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3487         (read_indirect_string_from_dwz): Use bfd accessor.
3488         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3489         * machoread.c (macho_symfile_read_all_oso): Likewise.
3490         * solib.c (solib_bfd_open): Likewise.
3491
3492 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3493
3494         * eval.c: Move declaration of overload_resolution to...
3495         * value.h: ...here.
3496
3497 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3498
3499         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3500         * arm-linux-tdep.c: Likewise.
3501         * arm-nbsd-nat.c: Likewise.
3502         * arm-tdep.h: Declare arm_apcs_32.
3503         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3504
3505 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3506
3507         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3508         * dwarf2read.h: Declare dwarf_always_disassemble.
3509
3510 2019-09-19  Tom de Vries  <tdevries@suse.de>
3511
3512         PR gdb/25009
3513         * source-cache.c (source_cache::ensure): Catch exception thrown during
3514         construction of the highlighter.
3515
3516 2019-09-18  Alan Modra  <amodra@gmail.com>
3517
3518         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3519         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3520         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3521         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3522         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3523         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3524         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3525         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3526         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3527         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3528         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3529         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3530         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3531         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3532         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3533         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3534         * mi/mi-interp.c: Update throughout for bfd section macro and
3535         function changes.
3536         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3537         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3538
3539 2019-09-18  Tom Tromey  <tom@tromey.com>
3540
3541         * NEWS: Add entry.
3542         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3543         call rl_initialize.
3544         (tui_enable): Do not call rl_initialize.
3545
3546 2019-09-18  Christian Groessler  <chris@groessler.org>
3547
3548         * alpha-linux-nat.c: Include gdbarch.h.
3549
3550 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3551
3552         * ui-file.c: Include cli/cli-style.h.
3553         (term_cli_styling): Remove cli_styling declaration.
3554
3555 2019-09-18  Alan Modra  <amodra@gmail.com>
3556
3557         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3558         to bfd_asymbol_section.
3559
3560 2019-09-18  Alan Modra  <amodra@gmail.com>
3561
3562         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3563         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3564         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3565
3566 2019-09-18  Alan Modra  <amodra@gmail.com>
3567
3568         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3569         * spu-linux-nat.c (spu_bfd_open): Likewise.
3570
3571 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3572
3573         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3574         to bool to match definition in dwarf2read.c.
3575
3576 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3577
3578         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3579         (print_signatures): Likewise.
3580         (trust_pad_over_xvs): Likewise.
3581         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3582         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3583         * arm-linux-nat.c (arm_apcs_32): Likewise.
3584         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3585         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3586         * arm-tdep.c (arm_debug): Likewise.
3587         (arm_apcs_32): Likewise.
3588         * auto-load.c (debug_auto_load): Likewise.
3589         (auto_load_gdb_scripts): Likewise.
3590         (global_auto_load): Likewise.
3591         (auto_load_local_gdbinit): Likewise.
3592         (auto_load_local_gdbinit_loaded): Likewise.
3593         * auto-load.h (global_auto_load): Likewise.
3594         (auto_load_local_gdbinit): Likewise.
3595         (auto_load_local_gdbinit_loaded): Likewise.
3596         * breakpoint.c (disconnected_dprintf): Likewise.
3597         (breakpoint_proceeded): Likewise.
3598         (automatic_hardware_breakpoints): Likewise.
3599         (always_inserted_mode): Likewise.
3600         (target_exact_watchpoints): Likewise.
3601         (_initialize_breakpoint): Update.
3602         * breakpoint.h (target_exact_watchpoints): Change to bool.
3603         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3604         * cli/cli-cmds.c (trace_commands): Likewise.
3605         * cli/cli-cmds.h (trace_commands): Likewise.
3606         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3607         to bool*.
3608         * cli/cli-logging.c (logging_overwrite): Change to bool.
3609         (logging_redirect): Likewise.
3610         (debug_redirect): Likewise.
3611         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3612         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3613         to bool.
3614         <boolean_option_def>: Update.
3615         (struct flag_option_def): Change default type of Context to bool
3616         from int.
3617         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3618         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3619         (get_setshow_command_value_string): Likewise.
3620         * cli/cli-style.c (cli_styling): Change to bool.
3621         (source_styling): Likewise.
3622         * cli/cli-style.h (source_styling): Likewise.
3623         (cli_styling): Likewise.
3624         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3625         to bool.
3626         * command.h (var_types): Update comment.
3627         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3628         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3629         bool.
3630         (debug_compile_cplus_scopes): Likewise.
3631         * compile/compile-internal.h (compile_debug): Likewise.
3632         * compile/compile.c (compile_debug): Likewise.
3633         (struct compile_options) <raw>: Likewise.
3634         * cp-support.c (catch_demangler_crashes): Likewise.
3635         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3636         (usr_cmd_cris_dwarf2_cfi): Likewise.
3637         * csky-tdep.c (csky_debug): Likewise.
3638         * darwin-nat.c (enable_mach_exceptions): Likewise.
3639         * dcache.c (dcache_enabled_p): Likewise.
3640         * defs.h (info_verbose): Likewise.
3641         * demangle.c (demangle): Likewise.
3642         (asm_demangle): Likewise.
3643         * dwarf-index-cache.c (debug_index_cache): Likewise.
3644         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3645         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3646         * dwarf2read.c (check_physname): Likewise.
3647         (use_deprecated_index_sections): Likewise.
3648         (dwarf_always_disassemble): Likewise.
3649         * eval.c (overload_resolution): Likewise.
3650         * event-top.c (set_editing_cmd_var): Likewise.
3651         (exec_done_display_p): Likewise.
3652         * event-top.h (set_editing_cmd_var): Likewise.
3653         (exec_done_display_p): Likewise.
3654         * exec.c (write_files): Likewise.
3655         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3656         (debug_fbsd_nat): Likewise.
3657         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3658         Likewise.
3659         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3660         <backtrace_past_entry> Likewise.
3661         * gdb-demangle.h (demangle): Likewise.
3662         (asm_demangle): Likewise.
3663         * gdb_bfd.c (bfd_sharing): Likewise.
3664         * gdbcore.h (write_files): Likewise.
3665         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3666         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3667         * gdbthread.h (print_thread_events): Likewise.
3668         * gdbtypes.c (opaque_type_resolution): Likewise.
3669         (strict_type_checking): Likewise.
3670         * gnu-nat.c (gnu_debug_flag): Likewise.
3671         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3672         * guile/scm-param.c (pascm_variable): Add boolval.
3673         (add_setshow_generic): Update.
3674         (pascm_param_value): Update.
3675         (pascm_set_param_value_x): Update.
3676         * hppa-tdep.c (hppa_debug): Change to bool..
3677         * infcall.c (may_call_functions_p): Likewise.
3678         (coerce_float_to_double_p): Likewise.
3679         (unwind_on_signal_p): Likewise.
3680         (unwind_on_terminating_exception_p): Likewise.
3681         * infcmd.c (startup_with_shell): Likewise.
3682         * inferior.c (print_inferior_events): Likewise.
3683         * inferior.h (startup_with_shell): Likewise.
3684         (print_inferior_events): Likewise.
3685         * infrun.c (step_stop_if_no_debug): Likewise.
3686         (detach_fork): Likewise.
3687         (debug_displaced): Likewise.
3688         (disable_randomization): Likewise.
3689         (non_stop): Likewise.
3690         (non_stop_1): Likewise.
3691         (observer_mode): Likewise.
3692         (observer_mode_1): Likewise.
3693         (set_observer_mode): Update.
3694         (sched_multi): Change to bool.
3695         * infrun.h (debug_displaced): Likewise.
3696         (sched_multi): Likewise.
3697         (step_stop_if_no_debug): Likewise.
3698         (non_stop): Likewise.
3699         (disable_randomization): Likewise.
3700         * linux-tdep.c (use_coredump_filter): Likewise.
3701         (dump_excluded_mappings): Likewise.
3702         * linux-thread-db.c (auto_load_thread_db): Likewise.
3703         (check_thread_db_on_load): Likewise.
3704         * main.c (captured_main_1): Update.
3705         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3706         xx2_opt, boolean_opt>: Change to bool.
3707         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3708         * maint.c (maintenance_profile_p): Likewise.
3709         (per_command_time): Likewise.
3710         (per_command_space): Likewise.
3711         (per_command_symtab): Likewise.
3712         * memattr.c (inaccessible_by_default): Likewise.
3713         * mi/mi-main.c (mi_async): Likewise.
3714         (mi_async_1): Likewise.
3715         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3716         * nat/fork-inferior.h (startup_with_shell): Likewise.
3717         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3718         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3719         * nios2-tdep.c (nios2_debug): Likewise.
3720         * or1k-tdep.c (or1k_debug): Likewise.
3721         * parse.c (parser_debug): Likewise.
3722         * parser-defs.h (parser_debug): Likewise.
3723         * printcmd.c (print_symbol_filename): Likewise.
3724         * proc-api.c (procfs_trace): Likewise.
3725         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3726         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3727         (set_parameter_value): Update.
3728         (add_setshow_generic): Update.
3729         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3730         to bool*.
3731         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3732         int*.
3733         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3734         * record-btrace.c (record_btrace_target::store_registers): Update.
3735         * record-full.c (record_full_memory_query): Change to bool.
3736         (record_full_stop_at_limit): Likewise.
3737         * record-full.h (record_full_memory_query): Likewise.
3738         * remote-notif.c (notif_debug): Likewise.
3739         * remote-notif.h (notif_debug): Likewise.
3740         * remote.c (use_range_stepping): Likewise.
3741         (interrupt_on_connect): Likewise.
3742         (remote_break): Likewise.
3743         * ser-tcp.c (tcp_auto_retry): Likewise.
3744         * ser-unix.c (serial_hwflow): Likewise.
3745         * skip.c (debug_skip): Likewise.
3746         * solib-aix.c (solib_aix_debug): Likewise.
3747         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3748         (spu_auto_flush_cache_p): Likewise.
3749         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3750         Likewise.
3751         (struct info_print_options) <quiet>: Likewise.
3752         * symfile-debug.c (debug_symfile): Likewise.
3753         * symfile.c (auto_solib_add): Likewise.
3754         (separate_debug_file_debug): Likewise.
3755         * symfile.h (auto_solib_add): Likewise.
3756         (separate_debug_file_debug): Likewise.
3757         * symtab.c (basenames_may_differ): Likewise.
3758         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3759         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3760         (struct info_types_options) <quiet>: Likewise.
3761         * symtab.h (demangle): Likewise.
3762         (basenames_may_differ): Likewise.
3763         * target-dcache.c (stack_cache_enabled_1): Likewise.
3764         (code_cache_enabled_1): Likewise.
3765         * target.c (trust_readonly): Likewise.
3766         (may_write_registers): Likewise.
3767         (may_write_memory): Likewise.
3768         (may_insert_breakpoints): Likewise.
3769         (may_insert_tracepoints): Likewise.
3770         (may_insert_fast_tracepoints): Likewise.
3771         (may_stop): Likewise.
3772         (auto_connect_native_target): Likewise.
3773         (target_stop_and_wait): Update.
3774         (target_async_permitted): Change to bool.
3775         (target_async_permitted_1): Likewise.
3776         (may_write_registers_1): Likewise.
3777         (may_write_memory_1): Likewise.
3778         (may_insert_breakpoints_1): Likewise.
3779         (may_insert_tracepoints_1): Likewise.
3780         (may_insert_fast_tracepoints_1): Likewise.
3781         (may_stop_1): Likewise.
3782         * target.h (target_async_permitted): Likewise.
3783         (may_write_registers): Likewise.
3784         (may_write_memory): Likewise.
3785         (may_insert_breakpoints): Likewise.
3786         (may_insert_tracepoints): Likewise.
3787         (may_insert_fast_tracepoints): Likewise.
3788         (may_stop): Likewise.
3789         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3790         (make_thread_apply_all_options_def_group): Change argument from int*
3791         to bool*.
3792         (thread_apply_all_command): Update.
3793         (print_thread_events): Change to bool.
3794         * top.c (confirm): Likewise.
3795         (command_editing_p): Likewise.
3796         (history_expansion_p): Likewise.
3797         (write_history_p): Likewise.
3798         (info_verbose): Likewise.
3799         * top.h (confirm): Likewise.
3800         (history_expansion_p): Likewise.
3801         * tracepoint.c (disconnected_tracing): Likewise.
3802         (circular_trace_buffer): Likewise.
3803         * typeprint.c (print_methods): Likewise.
3804         (print_typedefs): Likewise.
3805         * utils.c (debug_timestamp): Likewise.
3806         (sevenbit_strings): Likewise.
3807         (pagination_enabled): Likewise.
3808         * utils.h (sevenbit_strings): Likewise.
3809         (pagination_enabled): Likewise.
3810         * valops.c (overload_resolution): Likewise.
3811         * valprint.h (struct value_print_options) <prettyformat_arrays,
3812         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3813         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3814         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3815         Likewise.
3816         * windows-nat.c (new_console): Likewise.
3817         (cygwin_exceptions): Likewise.
3818         (new_group): Likewise.
3819         (debug_exec): Likewise.
3820         (debug_events): Likewise.
3821         (debug_memory): Likewise.
3822         (debug_exceptions): Likewise.
3823         (useshell): Likewise.
3824         * windows-tdep.c (maint_display_all_tib): Likewise.
3825         * xml-support.c (debug_xml): Likewise.
3826
3827 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3828
3829         * source.c (prepare_path_for_appending): New function.
3830         (openp): Make use of new function.
3831         (find_and_open_source): Search for the compilation directory and
3832         source file as a relative path beneath the directory search path.
3833
3834 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3835
3836         * source-cache.c (source_cache::get_line_charpos): Catch
3837         exceptions and return false, this matches the behaviour documented
3838         in the header file.
3839
3840 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3841
3842         * ada-tasks.c (info_task): Remove quoting of the task's name.
3843
3844 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3845
3846         * symfile.c (auto_solib_add): Replace comment with a reference
3847         to the header file.
3848
3849 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3850
3851         * NEWS: Mention that gdb can now be compiled with Python 3
3852         on Windows.
3853
3854 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3855
3856         * maint.c (maint_print_section_data::maint_print_section_data):
3857         Force use of 'float log10 (float)' by casting the argument to
3858         float.
3859
3860 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * maint.c: Add 'cmath' include.
3863         (struct maint_print_section_data): New structure.
3864         (print_section_index): New function.
3865         (print_bfd_section_info): Add header comment, small whitespace
3866         cleanup, and update to call new print_section_index function.
3867         (print_objfile_section_info): Likewise.
3868         (maint_obj_section_from_bfd_section): New function.
3869         (print_bfd_section_info_maybe_relocated): New function.
3870         (maintenance_info_sections): Add header comment, always use
3871         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3872
3873 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3874
3875         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3876         inner scope, add check that the objfile has psymtabs before
3877         checking psymtabs_addrmap.
3878         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3879
3880 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3881
3882         * NEWS: Announce that Ada task names are now shown at more places,
3883         and between quotes (except in info task output).
3884         * gdb/ada-tasks.c (task_to_str): New function.
3885         (display_current_task_id): Call task_to_str.
3886         (task_command_1): Likewise.
3887         (print_ada_task_info): In non-mi mode, Properly align headers and data
3888         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3889
3890 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3891
3892         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3893         prstatus.pr_lwp.pr_info instead of making it up.
3894
3895 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3896
3897         * auto-load.c (auto_load_expand_dir_vars): Update.
3898         * defs.h (gdb_datadir): Change to std::string.
3899         (python_libdir): Likewise.
3900         (relocate_gdb_directory): Change return type to std::string.
3901         * guile/guile.c (gdbscm_data_directory): Update.
3902         (initialize_scheme_side): Update.
3903         * jit.c (jit_reader_dir): Change to std::string.
3904         (jit_reader_load_command): Update.
3905         * main.c (gdb_datadir): Change to std::string.
3906         (python_libdir): Likewise.
3907         (set_gdb_data_directory): Update.
3908         (relocate_path): Change to return std::string.
3909         (relocate_gdb_directory): Change to return std::string.
3910         (relocate_gdbinit_path_maybe_in_datadir): Update.
3911         (captured_main_1): Update.
3912         * python/python.c (do_start_initialization): Update.
3913         * top.c (show_gdb_datadir): Update.
3914         * xml-syscall.c (xml_init_syscalls_info): Update.
3915         (init_syscalls_info): Update.
3916
3917 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3918
3919         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3920         out of get_init_files.
3921         (get_init_files): Update.
3922
3923 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3924
3925         * main.c (get_init_files): Change to use std::string.
3926         (captured_main_1): Update.
3927         (print_gdb_help): Update.
3928
3929 2019-09-11  Ali Tamur  <tamur@google.com>
3930
3931         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3932         implementation.
3933
3934 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3935
3936         * dbxread.c (read_dbx_symtab): Update.
3937         * dwarf2read.c (load_partial_dies): Update.
3938         * mdebugread.c (parse_partial_symbols): Update.
3939         (handle_psymbol_enumerators): Update.
3940         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3941         * psymtab.c (add_psymbol_to_bcache): Likewise.
3942         (add_psymbol_to_list): Likewise.
3943         * symtab.c (symbol_set_names): Likewise.
3944         * symtab.h (symbol_set_names): Likewise.
3945         * xcoffread.c (scan_xcoff_symtab): Update.
3946
3947 2019-09-11  Tom Tromey  <tom@tromey.com>
3948
3949         * symfile-mem.c (symbol_file_add_from_memory): Use
3950         bfd_set_filename.
3951         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3952         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3953
3954 2019-09-10  Tom Tromey  <tromey@adacore.com>
3955
3956         * dwarf-index-write.c (write_psymbols): Extend error message.
3957         (debug_names::insert): Add Ada code.
3958         (debug_names::write_psymbols): Remove Ada check.
3959         (debug_names) <m_string_obstack>: New member.
3960         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3961         (gdb_index_symbol_name_matcher::matches): Remove.
3962         (mapped_index_base::find_name_components_bounds): Add "lang"
3963         parameter.
3964         (mapped_index_base::build_name_components): Also split names
3965         according to Ada syntax.
3966         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3967         type of "match_callback".
3968         (check_match, check_find_bounds_finds)
3969         (dw2_expand_symtabs_matching): Update.
3970         (dw2_debug_names_iterator): Add new constructor.
3971         (dw2_debug_names_map_matching_symbols): New function.
3972         (dw2_debug_names_expand_symtabs_matching): Update.
3973         (dwarf2_debug_names_functions): Use
3974         dw2_debug_names_map_matching_symbols.
3975
3976 2019-09-10  Tom Tromey  <tromey@adacore.com>
3977
3978         * dwarf2read.c (dw2_get_file_names_reader): Add the
3979         CU's file name to the results.
3980
3981 2019-09-10  Tom Tromey  <tromey@adacore.com>
3982
3983         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3984         map_matching_symbols.  Update.
3985         * dwarf2read.c (dw2_map_matching_symbols): Update.
3986         * psymtab.c (match_partial_symbol): Change type; update.
3987         (psym_map_matching_symbols): Likewise.
3988         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3989         type; update.
3990         * symfile.h (struct quick_symbol_functions)
3991         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3992         Remove "match".
3993
3994 2019-09-10  Tom Tromey  <tromey@adacore.com>
3995
3996         * psymtab.c (map_block): Remove.
3997         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3998         * symtab.c (iterate_over_symbols_terminated): New function.
3999         * symtab.c (iterate_over_symbols_terminated): Declare.
4000
4001 2019-09-10  Tom Tromey  <tromey@adacore.com>
4002
4003         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4004         * language.h (struct language_defn) <la_iterate_over_symbols>:
4005         Return bool.
4006         * symtab.c (iterate_over_symbols): Return bool.
4007         * symtab.h (iterate_over_symbols): Return bool.
4008
4009 2019-09-10  Tom Tromey  <tromey@adacore.com>
4010
4011         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4012         (add_nonlocal_symbols): Update.
4013         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4014         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4015         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4016         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4017         Change type of "callback".  Remove "data".
4018
4019
4020 2019-09-09  Ali Tamur  <tamur@google.com>
4021
4022         * dwarf2read.c (comp_unit_head): Update comment.
4023         (dwarf2_dwo_name): New function declaration.
4024         (dwarf_unit_type_name): New function declaration.
4025         (read_comp_unit_head): Add support for new compilation units,
4026         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4027         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4028         (currently named as "signature") in their header. Also clarify error
4029         messages.
4030         (lookup_dwo_id): New function. Returns the dwo id of the given
4031         compile unit.
4032         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4033         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4034         functions.
4035         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4036         (dwarf2_dwo_name): Get the dwo name if present.
4037         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4038         purposes.
4039
4040 2019-09-09  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4043
4044 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4045
4046         * python/python.c (do_start_initialization): Make progname_copy static,
4047         to avoid a leak report.
4048
4049 2019-09-08  Tom Tromey  <tom@tromey.com>
4050
4051         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4052
4053 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4054
4055         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4056         Change type to gdb::optional<block_enum>.
4057         (dw2_symtab_iter_init): Change block_index parameter type
4058         to gdb::optional<block_enum>.
4059         (dw2_lookup_symbol): Change block_index parameter
4060         type to block_enum.c
4061         (dw2_debug_names_lookup_symbol): Likewise.
4062         * psymtab.c (psym_lookup_symbol): Likewise.
4063         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4064         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4065         Likewise.
4066
4067 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4068
4069         * defs.h (relocate_gdb_directory): Change int to bool in
4070         signature and rename flag to relocatable.
4071         * main.c (relocate_path): Likewise.
4072         (relocate_gdb_directory): Likewise.
4073
4074 2019-09-06  Alan Modra  <amodra@gmail.com>
4075
4076         * coffread.c (coff_symfile_read): Constify filename variable.
4077         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4078         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4079         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4080         * solib.c (reload_shared_libraries_1): Likewise.
4081         * symfile.c (reread_symbols): Likewise.
4082         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4083         * solib-darwin.c (darwin_bfd_open): Likewise.
4084         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4085
4086 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4087
4088         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4089         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4090
4091 2019-09-03  Tom Tromey  <tromey@adacore.com>
4092
4093         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4094         types.
4095         (has_negatives): Unbias a range type bound.
4096         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4097         * gdbtypes.c (operator==): Handle new field.
4098         (create_range_type): Add "bias" parameter.
4099         (create_static_range_type, resolve_dynamic_range): Update.
4100         * gdbtypes.h (struct range_bounds) <bias>: New member.
4101         (create_range_type): Add bias parameter.
4102         * printcmd.c (print_scalar_formatted): Unbias range types.
4103         * value.c (unpack_long): Unbias range types.
4104         (pack_long): Bias range types.
4105
4106 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4107
4108         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4109         probe arguments.
4110
4111 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4112
4113         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4114         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4115         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4116         (compile_probe_arg): Likewise.
4117         * probe.h (get_argument_count): Likewise.
4118         * solib-svr4.c (solib_event_probe_action): Likewise.
4119         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4120
4121 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4122
4123         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4124         code to here...
4125         (svr4_create_solib_event_breakpoints): ...from here.
4126
4127 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4128
4129         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4130         suffix from warning message.
4131
4132 2019-08-30  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-winsource.h (struct tui_source_window_base)
4135         <refresh_all>: Don't declare.
4136         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4137         Remove.
4138         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4139         tui_show_locator_content.
4140         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4141         declare.
4142         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4143         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4144         declare.
4145
4146 2019-08-30  Tom Tromey  <tom@tromey.com>
4147
4148         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4149
4150 2019-08-30  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4153         Remove unnecessary forward declarations.
4154
4155 2019-08-30  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4158         rerender.
4159         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4160         tui_show_locator_content.
4161
4162 2019-08-30  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4165         (tui_locator_window::rerender): Rewrite using body of previous
4166         tui_show_locator_content.
4167
4168 2019-08-30  Tom Tromey  <tom@tromey.com>
4169
4170         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4171         set_locator_fullname>: New methods.
4172         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4173         Rename from tui_set_locator_fullname.
4174         (tui_locator_window::set_locator_info): Rename from
4175         tui_set_locator_info.  Return bool.
4176         (tui_update_locator_fullname, tui_show_frame_info): Update.
4177
4178 2019-08-30  Tom Tromey  <tom@tromey.com>
4179
4180         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4181
4182 2019-08-30  Tom Tromey  <tom@tromey.com>
4183
4184         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4185         call touchwin.
4186
4187 2019-08-30  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-wingeneral.c (box_win): Assume win_info and
4190         win_info->handle cannot be NULL.
4191
4192 2019-08-30  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4195         refresh_window>: Declare.
4196         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4197         resize.
4198         (tui_data_item_window::rerender): Rename from
4199         tui_display_register.
4200         (tui_data_item_window::refresh_window): New method.
4201         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4202         no-op.
4203
4204 2019-08-30  Tom Tromey  <tom@tromey.com>
4205
4206         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4207         regs_column_count, current_group>: Move later.  Now private.
4208         <get_current_group>: New method.
4209         * tui/tui-regs.c (tui_reg_command): Update.
4210         * tui/tui-layout.c (tui_set_layout): Update.
4211
4212 2019-08-30  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4215         (tui_data_window::rerender): Don't call
4216         check_and_display_highlight_if_needed.
4217         (tui_data_window::refresh_all): Remove call to
4218         erase_data_content.
4219
4220 2019-08-30  Tom Tromey  <tom@tromey.com>
4221
4222         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4223         (tui_data_window::display_registers_from)
4224         (tui_data_window::display_reg_element_at_line)
4225         (tui_data_window::display_registers_from_line): Remove checks of
4226         "empty".
4227
4228 2019-08-30  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4231         Don't declare.
4232         * tui/tui-regs.c (tui_data_window::show_registers): Call
4233         rerender.
4234         (tui_data_window::rerender): Rename from display_all_data.
4235         (tui_data_window::rerender): Remove old implementation.
4236
4237 2019-08-30  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4240         text.
4241         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4242
4243 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4244             Sergio Durigan Junior  <sergiodj@redhat.com>
4245
4246         PR win32/24284
4247         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4248
4249 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4250
4251         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4252         when searching for types.
4253
4254 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4255
4256         * f-lang.c (f_language_defn): Use f_print_typedef.
4257         * f-lang.h (f_print_typedef): Declare.
4258         * f-typeprint.c (f_print_typedef): Define.
4259
4260 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4261
4262         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4263
4264 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * cli/cli-utils.c (info_print_options_defs): Delete.
4267         (make_info_print_options_def_group): Delete.
4268         (extract_info_print_options): Delete.
4269         (info_print_command_completer): Delete.
4270         (info_print_args_help): Add extra parameter, and optionally
4271         include text about -n flag.
4272         * cli/cli-utils.h (struct info_print_options): Delete.
4273         (extract_info_print_options): Delete declaration.
4274         (info_print_command_completer): Delete declaration.
4275         (info_print_args_help): Add extra parameter, extend header
4276         comment.
4277         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4278         search_symbols.
4279         * stack.c (struct info_print_options): New type.
4280         (info_print_options_defs): New file scoped variable.
4281         (make_info_print_options_def_group): New static function.
4282         (info_print_command_completer): New static function.
4283         (info_locals_command): Update to use new local functions.
4284         (info_args_command): Likewise.
4285         (_initialize_stack): Add extra parameter to calls to
4286         info_print_args_help.
4287         * symtab.c (search_symbols): Add extra parameter, use this to
4288         possibly excluse non-debug symbols.
4289         (symtab_symbol_info): Add extra parameter, which is passed on to
4290         search_symbols.
4291         (struct info_print_options): New type.
4292         (info_print_options_defs): New file scoped variable.
4293         (make_info_print_options_def_group): New static function.
4294         (info_print_command_completer): New static function.
4295         (info_variables_command): Update to use local functions, and pass
4296         extra parameter through to symtab_symbol_info.
4297         (info_functions_command): Likewise.
4298         (info_types_command): Pass additional argument through to
4299         symtab_symbol_info.
4300         (rbreak_command): Pass extra argument to search_symbols.
4301         (_initialize_symtab): Add extra arguments for calls to
4302         info_print_args_help, and update help text for 'info variables',
4303         'whereis', and 'info functions' commands.
4304         * symtab.h (search_symbols): Add extra argument to declaration.
4305         * NEWS: Mention new flags.
4306
4307 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4308
4309         * symtab.c (lookup_static_symbol): Call the new function (and move
4310         it down to be next to lookup_global_symbol).
4311         (struct global_sym_lookup_data): Add block_enum member and rename to...
4312         (struct global_or_static_sym_lookup_data): ...this.
4313         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4314         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4315         (lookup_symbol_global_or_static_iterator_cb): ...this.
4316         (lookup_global_or_static_symbol): New function.
4317         (lookup_global_symbol): Call new function.
4318
4319 2019-08-26  Tom de Vries  <tdevries@suse.de>
4320
4321         PR c++/24852
4322         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4323         when pc_probe.prob == NULL.
4324
4325 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4326
4327         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4328         variable symbol_linkage to symbol_linkage_.
4329
4330 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4331
4332         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4333         represent whether the symbol is static, dynamic, or we don't
4334         know.
4335
4336 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4337
4338         * gdb/rx-tdep.c (rx_register_names): New.
4339         (rx_register_name): Delete.
4340         (rx_psw_type): Delete.
4341         (rx_fpsw_type): Delete.
4342         (rx_register_type): Delete.
4343         (rx_gdbarch_init): Convert target-descriptions.
4344         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4345         * gdb/features/Makefile: Add rx.xml.
4346         * gdb/features/rx.xml: New.
4347         * gdb/features/rx.c: Generated.
4348         * gdb/NEWS: Mention target description support.
4349
4350 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4351
4352         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4353         *slot_ptr.
4354
4355 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4356
4357         * configure.ac: Don't check for 'dlfcn.h' (moved to
4358         gdbsupport/common.m4).
4359         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4360         'gdbsupport/'.
4361         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4362         * compile/compile-c-support.c: Include
4363         'gdbsupport/gdb-dlfcn.h'.
4364         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4365         * gdb-dlfcn.c: Move to...
4366         * gdbsupport/gdb-dlfcn.c: ... here.
4367         * gdb-dlfcn.h: Move to...
4368         * gdbsupport/gdb-dlfcn.h: ... here.
4369
4370 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4371
4372         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4373         the offset field signed.
4374
4375 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4376
4377         * python/lib/gdb/__init__.py (_execute_file): New function.
4378         * python/python.c (python_run_simple_file): Call gdb._execute_file
4379         on Windows.
4380
4381 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4382
4383         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4384         all uses as this was never set to anything but a zero value.
4385
4386 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4387
4388         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4389
4390 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4391
4392         * tui/tui-data.h (tui_gen_win_info): Add an =default
4393         move constructor, required by some GCC versions.
4394
4395 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4396
4397         * go32-nat.c (go32_sysinfo): Add hygon_p.
4398
4399 2019-08-20  Tom Tromey  <tom@tromey.com>
4400
4401         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4402         line_from_reg_element_no, first_reg_element_no_inline,
4403         display_all_data, delete_data_content_windows,
4404         erase_data_content>: Now private.
4405
4406 2019-08-20  Tom Tromey  <tom@tromey.com>
4407
4408         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4409         (tui_unhighlight_win, tui_highlight_win)
4410         (tui_win_info::make_window): Update.
4411         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4412
4413 2019-08-20  Tom Tromey  <tom@tromey.com>
4414
4415         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4416         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4417         (MAX_PID_WIDTH): Move to tui-stack.c.
4418         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4419         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4420         (MAX_PID_WIDTH): Move from tui-data.h.
4421
4422 2019-08-20  Tom Tromey  <tom@tromey.com>
4423
4424         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4425         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4426         (box_win): Update.
4427         (tui_gen_win_info::make_window): Rename from tui_make_window.
4428         (tui_win_info::make_window): New method.
4429         (tui_gen_win_info::make_visible): Update.
4430         * tui/tui-source.c (tui_source_window::set_contents): Update.
4431         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4432         (tui_data_window::display_registers_from): Update.
4433         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4434         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4435         Declare.
4436         <can_box>: Remove.
4437         <title>: Remove.
4438         (struct tui_win_info) <make_window>: Declare.
4439         <can_box>: Now virtual.
4440         <title>: New member.
4441         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4442         * tui/tui-command.c (tui_cmd_window::resize): Update.
4443
4444 2019-08-20  Tom Tromey  <tom@tromey.com>
4445
4446         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4447         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4448         (tui_data_window::check_register_values): Update.
4449
4450 2019-08-20  Tom Tromey  <tom@tromey.com>
4451
4452         * tui/tui-regs.h (struct tui_data_window): Use
4453         DISABLE_COPY_AND_ASSIGN.
4454         <regs_content>: Change type, removing unique_ptr.
4455         <tui_data_window>: Add move constructor.
4456         * tui/tui-regs.c (tui_data_window::show_registers)
4457         (tui_data_window::show_register_group)
4458         (tui_data_window::display_registers_from)
4459         (tui_data_window::display_registers_from)
4460         (tui_data_window::first_data_item_displayed)
4461         (tui_data_window::delete_data_content_windows)
4462         (tui_data_window::rerender, tui_data_window::refresh_window)
4463         (tui_data_window::check_register_values): Update.
4464
4465 2019-08-20  Tom Tromey  <tom@tromey.com>
4466
4467         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4468         show_register_group>: Declare.
4469         (tui_show_register_group): Don't declare.
4470         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4471         tui_show_registers.
4472         (tui_data_window::show_register_group): Rename from
4473         tui_show_register_group.
4474         (tui_data_window::check_register_values, tui_reg_command):
4475         Update.
4476         * tui/tui-layout.c (tui_set_layout): Update.
4477
4478 2019-08-20  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4481         Declare.
4482         (tui_check_register_values): Don't declare.
4483         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4484         from tui_check_register_values.
4485         * tui/tui-hooks.c (tui_register_changed): Update.
4486
4487 2019-08-20  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-regs.c (tui_reg_layout): Move later.
4490         (tui_show_registers): Don't enable TUI mode or change layout.
4491
4492 2019-08-20  Tom Tromey  <tom@tromey.com>
4493
4494         * tui/tui-regs.h (struct tui_data_item_window)
4495         <~tui_data_item_window>: Remove.
4496         <content>: Now a unique_xmalloc_ptr.
4497         * tui/tui-regs.c (tui_register_format): Return a
4498         unique_xmalloc_ptr.
4499         (tui_get_register): Update.
4500         (~tui_data_item_window): Remove.
4501         (tui_data_window::display_registers_from, tui_display_register):
4502         Update.
4503         * tui/tui-io.h (tui_expand_tabs): Update.
4504         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4505         Remove "col" parameter.
4506
4507 2019-08-20  Tom Tromey  <tom@tromey.com>
4508
4509         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4510         field.
4511         * tui/tui-regs.c (~tui_data_item_window): Update.
4512
4513 2019-08-20  Tom Tromey  <tom@tromey.com>
4514
4515         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4516         earlier.
4517
4518 2019-08-20  Tom Tromey  <tom@tromey.com>
4519
4520         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4521
4522 2019-08-20  Tom Tromey  <tom@tromey.com>
4523
4524         * tui/tui-source.h (struct tui_source_window): Update.
4525         * tui/tui-regs.c (tui_show_registers): Update.
4526         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4527         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4528         (NO_REGS_STRING): Remove defines.
4529
4530 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4531
4532         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4533         unnecessary thread walk if remote doesn't support the packet.
4534
4535 2019-08-19  Tom Tromey  <tromey@adacore.com>
4536
4537         * python/py-value.c (value_has_field): Fix indentation.
4538
4539 2019-08-19  Tom Tromey  <tromey@adacore.com>
4540
4541         * printcmd.c (do_one_display, info_display_command): Update.
4542         * block.h (contained_in): Return bool.  Add allow_nested
4543         parameter.
4544         * block.c (contained_in): Return bool.  Add allow_nested
4545         parameter.
4546
4547 2019-08-19  Tom Tromey  <tom@tromey.com>
4548
4549         * configure: Rebuild.
4550         * configure.ac: Disallow the combination of -static-libstdc++ and
4551         source highlight.
4552         * source-cache.c (get_language_name): Handle rust.
4553         (source_cache::get_source_lines): Ignore highlighting exceptions.
4554
4555 2019-08-16  Tom Tromey  <tom@tromey.com>
4556
4557         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4558         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4559         (struct tui_source_window_base) <make_visible, refresh_window,
4560         resize>: Remove methods.
4561         <execution_info>: Remove field.
4562         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4563         (tui_show_source_line, tui_source_window_base)
4564         (~tui_source_window_base): Update.
4565         (tui_source_window_base::resize)
4566         (tui_source_window_base::make_visible)
4567         (tui_source_window_base::refresh_window): Remove.
4568         (tui_source_window_base::update_exec_info): Update.
4569         * tui/tui-source.c (tui_source_window::set_contents): Update.
4570         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4571
4572 2019-08-16  Tom Tromey  <tom@tromey.com>
4573
4574         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4575         deprecated_query_hook.
4576
4577 2019-08-16  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4580         (tui_update_source_windows_with_line): Update.
4581         * tui/tui-source.h (struct tui_source_window)
4582         <show_symtab_source>: Declare.
4583         (tui_show_symtab_source): Don't declare.
4584         * tui/tui-source.c (tui_show_symtab_source): Rename from
4585         tui_show_symtab_source.
4586
4587 2019-08-16  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-winsource.h (struct tui_source_window_base)
4590         <set_contents>: Declare.
4591         * tui/tui-winsource.c
4592         (tui_source_window_base::update_source_window_as_is): Update.
4593         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4594         Declare.
4595         (tui_set_source_content): Don't declare.
4596         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4597         tui_set_source_content.
4598         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4599         Declare.
4600         (tui_set_disassem_content): Don't declare.
4601         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4602         tui_set_disassem_content.
4603
4604 2019-08-16  Tom Tromey  <tom@tromey.com>
4605
4606         * tui/tui-winsource.h (struct tui_source_window_base)
4607         <update_breakpoint_info>: Declare.
4608         (tui_update_breakpoint_info): Don't declare.
4609         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4610         (tui_update_all_breakpoint_info): Update.
4611         (tui_source_window_base::update_breakpoint_info): Rename from
4612         tui_update_breakpoint_info.
4613         (tui_source_window_base::update_exec_info): Update.
4614
4615 2019-08-16  Tom Tromey  <tom@tromey.com>
4616
4617         * tui/tui-winsource.h (struct tui_source_window_base)
4618         <update_source_window>: Declare.
4619         (tui_update_source_window): Don't declare.
4620         * tui/tui-winsource.c
4621         (tui_source_window_base::update_source_window): Rename from
4622         tui_update_source_window.
4623         (tui_source_window_base::rerender): Update.
4624         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4625         * tui/tui-disasm.c (tui_show_disassem)
4626         (tui_show_disassem_and_update_source)
4627         (tui_disasm_window::maybe_update): Update.
4628
4629 2019-08-16  Tom Tromey  <tom@tromey.com>
4630
4631         * tui/tui-winsource.h (struct tui_source_window_base)
4632         <update_source_window_as_is>: Declare.
4633         (tui_update_source_window_as_is): Don't declare.
4634         * tui/tui-winsource.c (tui_update_source_window): Update
4635         (tui_source_window_base::update_source_window_as_is): Rename from
4636         tui_update_source_window_as_is.
4637         (tui_source_window_base::refill): Update.
4638         * tui/tui-source.c (tui_show_symtab_source): Update.
4639         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4640         Update.
4641
4642 2019-08-16  Tom Tromey  <tom@tromey.com>
4643
4644         * tui/tui-winsource.h (tui_update_source_window)
4645         (tui_update_source_window_as_is): Remove "noerror" parameter.
4646         * tui/tui-winsource.c (tui_update_source_window)
4647         (tui_update_source_window_as_is): Remove "noerror" parameter.
4648         (tui_update_source_windows_with_addr)
4649         (tui_update_source_windows_with_line)
4650         (tui_source_window_base::rerender)
4651         (tui_source_window_base::refill): Update.
4652         * tui/tui-source.h (tui_set_source_content)
4653         (tui_show_symtab_source): Remove "noerror" parameter.
4654         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4655         parameter.
4656         (tui_show_symtab_source): Likewise.
4657         (tui_source_window::maybe_update): Update.
4658         * tui/tui-disasm.c (tui_show_disassem)
4659         (tui_show_disassem_and_update_source)
4660         (tui_disasm_window::do_scroll_vertical)
4661         (tui_disasm_window::maybe_update): Update.
4662
4663 2019-08-16  Tom Tromey  <tom@tromey.com>
4664
4665         * tui/tui.c (tui_is_window_visible): Update.
4666         * tui/tui-wingeneral.c (tui_make_window)
4667         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4668         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4669         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4670         (tui_set_win_height_command, parse_scrolling_args): Update.
4671         * tui/tui-source.c (tui_source_window::style_changed): Update.
4672         * tui/tui-regs.c (tui_show_registers)
4673         (tui_data_window::first_data_item_displayed)
4674         (tui_data_window::delete_data_content_windows)
4675         (tui_check_register_values, tui_reg_command): Update.
4676         * tui/tui-disasm.c (tui_show_disassem): Update.
4677         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4678         method.
4679         <is_visible>: Remove field.
4680         * tui/tui-data.c (tui_next_win, tui_prev_win)
4681         (tui_delete_invisible_windows): Update.
4682
4683 2019-08-16  Tom Tromey  <tom@tromey.com>
4684
4685         * tui/tui-winsource.h (struct tui_source_window_base)
4686         <m_has_locator>: Remove.
4687         * tui/tui-layout.c (show_source_disasm_command, show_data)
4688         (show_source_or_disasm_and_command): Update.
4689
4690 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4691
4692         * NEWS (Other MI changes): New subsection.
4693         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4694         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4695         * arch-utils.c (default_get_pc_address_flags): New function.
4696         * arch-utils.h (default_get_pc_address_flags): New declaration.
4697         * gdbarch.sh: Add get_pc_address_flags.
4698         * gdbarch.c: Regenerate.
4699         * gdbarch.h: Likewise.
4700         * stack.c (print_pc): New function.
4701         (print_frame_info) (print_frame): Call print_pc.
4702
4703 2019-08-16  Tom de Vries  <tdevries@suse.de>
4704
4705         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4706         print_objfile_section_info.
4707
4708 2019-08-15  Tom Tromey  <tom@tromey.com>
4709
4710         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4711         calling update_cmdwin_start_line.
4712         * tui/tui-winsource.h (struct tui_source_window_base)
4713         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4714         <rerender>: Declare.
4715         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4716         Call rerender.
4717         (tui_source_window_base::set_new_height): Remove.
4718         (tui_source_window_base::rerender): Rename from
4719         do_make_visible_with_new_height.
4720         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4721         resize method.
4722         (tui_win_info::make_invisible_and_set_new_height)
4723         (tui_win_info::make_visible_with_new_height): Remove.
4724         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4725         Declare.
4726         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4727         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4728         do_make_visible_with_new_height>: Don't declare.
4729         <rerender>: Declare.
4730         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4731         set_new_height.
4732         (tui_data_window::do_make_visible_with_new_height): Remove.
4733         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4734         call tui_show_locator_content.
4735         (tui_gen_win_info::resize): Call rerender.
4736         (show_source_or_disasm_and_command): Don't call
4737         tui_show_locator_content.
4738         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4739         method.
4740         (struct tui_win_info) <rerender>: Declare.
4741         <set_new_height, make_invisible_and_set_new_height,
4742         make_visible_with_new_height>: Don't declare.
4743         * tui/tui-data.c (tui_win_list::rerender): New method.
4744         * tui/tui-command.h (struct tui_cmd_window)
4745         <do_make_visible_with_new_height>: Don't declare.
4746         * tui/tui-command.c
4747         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4748
4749 2019-08-15  Tom Tromey  <tromey@adacore.com>
4750
4751         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4752         * ada-lang.c (ada_enum_name): Likewise.
4753
4754 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4755
4756         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4757         leading underscore.
4758         (GdbOutputErrorFile): Likewise.
4759         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4760         accordingly.
4761         (execute_unwinders): Rename to have a leading underscore.
4762         (auto_load_packages): Likewise.
4763         (global scope): Adjust call to auto_load_packages accordingly.
4764         (GdbSetPythonDirectory): Likewise.
4765         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4766         instead of execute_unwinders.
4767
4768 2019-08-15  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4771         (show_data): Don't change window visibility.
4772         (tui_gen_win_info::resize): Remove special case for command
4773         window.  Use wresize, when available.
4774         (show_source_or_disasm_and_command): Don't change window
4775         visibility.
4776         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4777         <make_visible>: New method.
4778         * tui/tui-command.c (tui_cmd_window::resize): New method.
4779
4780 2019-08-15  Tom Tromey  <tom@tromey.com>
4781
4782         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4783         (struct tui_source_windows): New.
4784         * tui/tui-winsource.c (tui_display_main): Update.
4785         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4786         (new_height_ok, parse_scrolling_args): Update.
4787         * tui/tui-layout.c (show_layout, show_data): Update.
4788         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4789         (tui_add_to_source_windows): Don't declare.
4790         * tui/tui-data.c (source_windows, tui_source_windows)
4791         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4792
4793 2019-08-15  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4796         Rename from reset.
4797         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4798         * tui/tui-layout.c (show_source_disasm_command, show_data):
4799         Update.
4800         (tui_gen_win_info::resize): Rename.
4801         (show_source_or_disasm_and_command): Update.
4802         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4803         reset.
4804
4805 2019-08-15  Tom Tromey  <tom@tromey.com>
4806
4807         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4808         * tui/tui-interp.c (tui_interp::init): Don't call
4809         tui_initialize_static_data.
4810         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4811
4812 2019-08-15  Tom Tromey  <tom@tromey.com>
4813
4814         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4815         examine tui_win_list.
4816
4817 2019-08-15  Tom Tromey  <tom@tromey.com>
4818
4819         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4820         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4821         tui_clear_source_content.
4822         (tui_clear_source_content): Remove.
4823         (tui_source_window_base::do_erase_source_content): Hoist call to
4824         content.clear().
4825         * tui/tui-stack.c (tui_show_frame_info): Don't call
4826         tui_clear_source_content.
4827
4828 2019-08-15  Tom Tromey  <tom@tromey.com>
4829
4830         * tui/tui-winsource.h (struct tui_source_window_base)
4831         <do_erase_source_content>: New method.
4832         <erase_source_content>: New method.
4833         (tui_erase_source_content): Don't declare.
4834         * tui/tui-winsource.c (tui_clear_source_content): Update.
4835         (tui_source_window_base::do_erase_source_content): Rename from
4836         tui_erase_source_content.
4837         (tui_source_window_base::show_source_content): Update.
4838         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4839         * tui/tui-source.h (struct tui_source_window)
4840         <erase_source_content>: New method.
4841         * tui/tui-disasm.h (struct tui_disasm_window)
4842         <erase_source_content>: New method.
4843
4844 2019-08-15  Tom Tromey  <tom@tromey.com>
4845
4846         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4847         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4848         constructor.
4849         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4850         * tui/tui-source.c (tui_set_source_content): Update.
4851         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4852
4853 2019-08-15  Tom Tromey  <tom@tromey.com>
4854
4855         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4856         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4857         tui-source.c.
4858         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4859         Declare.
4860         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4861         method.
4862         (tui_source_window::maybe_update): Update.
4863
4864 2019-08-15  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4867         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4868         tui-disasm.c.
4869         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4870         Declare.
4871         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4872         method.
4873         (tui_disasm_window::maybe_update): Update.
4874
4875 2019-08-15  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-winsource.h (struct tui_source_window_base)
4878         <maybe_update>: Declare.
4879         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4880         method.
4881         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4882         Declare.
4883         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4884         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4885         Declare.
4886         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4887
4888 2019-08-15  Tom Tromey  <tom@tromey.com>
4889
4890         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4891
4892 2019-08-15  Tom Tromey  <tom@tromey.com>
4893
4894         * tui/tui-wingeneral.c: Include tui-stack.h.
4895         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4896         (struct tui_locator_window): Move from tui-data.h.
4897         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4898         (tui_initialize_static_data): Move from tui-data.c.
4899         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4900         (struct tui_locator_window): Move to tui-stack.c.
4901         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4902         (tui_initialize_static_data): Move to tui-stack.c.
4903
4904 2019-08-15  Tom Tromey  <tom@tromey.com>
4905
4906         * tui/tui-layout.c (show_source_disasm_command)
4907         (show_source_or_disasm_and_command): Use make_visible method, not
4908         tui_make_window.
4909         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4910         Remove.
4911
4912 2019-08-15  Tom Tromey  <tom@tromey.com>
4913
4914         * tui/tui-wingeneral.h (tui_make_window): Update.
4915         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4916         parameter.
4917         (tui_gen_win_info::make_visible): Update.
4918         * tui/tui-regs.c (tui_data_window::display_registers_from):
4919         Update.
4920         * tui/tui-layout.c (show_source_disasm_command)
4921         (show_source_or_disasm_and_command): Update.
4922         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4923         (enum tui_box): Remove.
4924         (struct tui_win_info) <can_box>: New method.
4925         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4926         method.
4927
4928 2019-08-15  Tom de Vries  <tdevries@suse.de>
4929
4930         * linux-nat-trad.c: Include gdbarch.h.
4931
4932 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4933
4934         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4935         register sizes.
4936
4937 2019-08-14  Tom Tromey  <tromey@adacore.com>
4938
4939         * darwin-nat.c: Include gdbarch.h.
4940         * darwin-nat-info.c: Include gdbarch.h.
4941
4942 2019-08-13  Tom Tromey  <tom@tromey.com>
4943
4944         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4945         Remove.
4946         * tui/tui-data.c (tui_initialize_static_data): Update.
4947
4948 2019-08-13  Tom Tromey  <tom@tromey.com>
4949
4950         * tui/tui-winsource.h (struct tui_exec_info_window)
4951         <~tui_exec_info_window, maybe_allocate_content, get_content,
4952         m_content>: Remove.
4953         (struct tui_source_window_base) <set_exec_info_content,
4954         show_exec_info_content>: Don't declare.
4955         * tui/tui-winsource.c
4956         (tui_exec_info_window::maybe_allocate_content): Remove.
4957         (tui_source_window_base::update_exec_info): Rename from
4958         set_exec_info_content.
4959         (tui_source_window_base::show_exec_info_content)
4960         (tui_source_window_base::update_exec_info): Remove.
4961
4962 2019-08-13  Tom Tromey  <tom@tromey.com>
4963
4964         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4965         declare.
4966         * tui/tui-winsource.c (tui_update_source_window_as_is)
4967         (tui_update_source_windows_with_addr, tui_erase_source_content):
4968         Update.
4969         (tui_clear_exec_info_content): Remove.
4970
4971 2019-08-13  Tom Tromey  <tom@tromey.com>
4972
4973         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4974         declare.
4975         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4976         call tui_erase_exec_info_content.
4977         (tui_clear_exec_info_content): Rename from
4978         tui_erase_exec_info_content.
4979         (tui_clear_exec_info_content): Delete.
4980
4981 2019-08-13  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-winsource.h (struct tui_source_window_base)
4984         <show_exec_info_content>: Declare.
4985         (tui_show_exec_info_content): Don't declare.
4986         * tui/tui-winsource.c
4987         (tui_source_window_base::show_exec_info_content): Rename from
4988         tui_show_exec_info_content.
4989         (tui_source_window_base::update_exec_info): Update.
4990
4991 2019-08-13  Tom Tromey  <tom@tromey.com>
4992
4993         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4994         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4995         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4996         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4997         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4998         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4999         ... here.
5000
5001 2019-08-13  Tom Tromey  <tom@tromey.com>
5002
5003         * tui/tui-winsource.h (struct tui_source_window_base)
5004         <update_exec_info>: Declare.
5005         (tui_update_exec_info): Don't declare.
5006         * tui/tui-winsource.c (tui_update_source_window_as_is)
5007         (tui_source_window_base::refresh_all)
5008         (tui_update_all_breakpoint_info): Update.
5009         (tui_source_window_base::update_exec_info): Rename from
5010         tui_update_exec_info.
5011         * tui/tui-stack.c (tui_show_frame_info): Update.
5012
5013 2019-08-13  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-winsource.h (struct tui_source_window_base)
5016         <set_exec_info_content>: Declare.
5017         (tui_set_exec_info_content): Don't declare.
5018         * tui/tui-winsource.c
5019         (tui_source_window_base::set_exec_info_content): Rename from
5020         tui_set_exec_info_content.
5021         (tui_update_exec_info): Update.
5022
5023 2019-08-13  Tom Tromey  <tom@tromey.com>
5024
5025         * tui/tui-winsource.h (struct tui_source_window_base)
5026         <show_source_content>: Declare.
5027         (tui_show_source_content): Don't declare.
5028         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5029         (tui_source_window_base::show_source_content): Rename from
5030         tui_show_source_content.
5031         (tui_source_window_base::refresh_all): Update.
5032         * tui/tui-layout.c (show_source_disasm_command)
5033         (show_source_or_disasm_and_command): Update.
5034
5035 2019-08-13  Tom Tromey  <tom@tromey.com>
5036
5037         * tui/tui-winsource.c (tui_erase_source_content)
5038         (tui_show_source_content, tui_source_window_base::refresh_all):
5039         Update.
5040         * tui/tui-wingeneral.h
5041         (tui_check_and_display_highlight_if_needed): Don't declare.
5042         * tui/tui-wingeneral.c
5043         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5044         check_and_display_highlight_if_needed.
5045         * tui/tui-win.c (tui_rehighlight_all)
5046         (tui_win_info::make_visible_with_new_height): Update.
5047         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5048         (tui_data_window::erase_data_content)
5049         (tui_data_window::display_all_data): Update.
5050         * tui/tui-data.h (struct tui_win_info)
5051         <check_and_display_highlight_if_needed>: Declare.
5052
5053 2019-08-13  Tom Tromey  <tom@tromey.com>
5054
5055         * tui/tui-win.c (tui_resize_all): Call
5056         tui_delete_invisible_windows.
5057         * tui/tui-layout.c (show_layout): Call
5058         tui_delete_invisible_windows.
5059         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5060         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5061
5062 2019-08-13  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5065         tui_add_win_to_layout.
5066
5067 2019-08-13  Tom Tromey  <tom@tromey.com>
5068
5069         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5070         * tui/tui-layout.c (tui_default_win_height): Now static.
5071
5072 2019-08-13  Tom Tromey  <tom@tromey.com>
5073
5074         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5075         single switch.
5076         (show_source_disasm_command, show_source_or_disasm_and_command):
5077         Don't check current layout.
5078
5079 2019-08-13  Tom Tromey  <tom@tromey.com>
5080
5081         * tui/tui-wingeneral.c (make_all_visible): Remove.
5082         (tui_make_all_invisible): Simplify.
5083         * tui/tui-layout.c (tui_make_all_invisible): Move from
5084         tui-wingeneral.c; simplify.
5085         (show_layout): Hoist call to tui_make_all_invisible.
5086         (show_data): Don't call tui_make_all_invisible.
5087
5088 2019-08-13  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5091         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5092
5093 2019-08-13  Tom Tromey  <tom@tromey.com>
5094
5095         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5096         tui-data.c.
5097         (show_source_disasm_command, show_data)
5098         (show_source_or_disasm_and_command): Don't use
5099         tui_set_current_layout_to.
5100         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5101         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5102         tui-layout.c.
5103         (tui_set_current_layout_to): Remove.
5104
5105 2019-08-13  Tom Tromey  <tom@tromey.com>
5106
5107         * tui/tui-layout.c (tui_set_layout): Update.
5108         * tui/tui-data.h (struct tui_layout_def): Remove.
5109         (tui_layout_def): Don't declare.
5110         * tui/tui-data.c (layout_def): Remove.
5111         (tui_layout_def): Remove.
5112
5113 2019-08-13  Tom Tromey  <tom@tromey.com>
5114
5115         * tui/tui-winsource.h (struct tui_source_window_base)
5116         <clear_detail>: No longer "override".
5117         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5118         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5119         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5120         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5121         Remove.
5122         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5123
5124 2019-08-13  Tom Tromey  <tromey@adacore.com>
5125
5126         * tracepoint.c: Don't include readline.h or history.h.
5127
5128 2019-08-12  Tom Tromey  <tom@tromey.com>
5129
5130         * configure: Rebuild.
5131         * configure.ac: Check for readline 7.
5132         * NEWS: Mention readline 7 requirement.
5133         * README: Update.
5134
5135 2019-08-12  Tom Tromey  <tom@tromey.com>
5136
5137         * mingw-hdep.c (gdb_select): Remove readline hack.
5138
5139 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5140
5141         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5142         when the function fails.
5143
5144 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5145
5146         * s390-tdep.c (s390_type_align): New function.
5147         (s390_gdbarch_init): Set it as type_align gdbarch method.
5148
5149 2019-08-09  Tom de Vries  <tdevries@suse.de>
5150
5151         PR gdb/24591
5152         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5153         pc_low with relocation offset.
5154
5155 2019-08-07  Tom Tromey  <tromey@adacore.com>
5156
5157         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5158         (print_frame_args): Update.
5159         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5160         Update.
5161         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5162         * frame.h (struct frame_arg): Add initializers.
5163         <error>: Now a unique_xmalloc_ptr.
5164
5165 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5166
5167         * NEWS: Expand the Pointer Authentication entry.
5168         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5169         (aarch64_frame_unmask_lr): ... to this.
5170         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5171         Call aarch64_frame_unmask_lr.
5172         * frame.c (struct frame_info): Add "masked" variable.
5173         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5174         (fprint_frame): Check for masked pc.
5175         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5176         declarations.
5177         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5178         * stack.c (print_frame): Check for masked pc.
5179
5180 2019-08-06  Tom Tromey  <tom@tromey.com>
5181
5182         * stabsread.c (patch_block_stabs, read_one_struct_field)
5183         (read_enum_type): Use obstack_strndup.
5184         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5185         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5186         * dwarf2read.c (guess_full_die_structure_name)
5187         (anonymous_struct_prefix): Use obstack_strndup.
5188         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5189         * c-exp.y (yylex): Use obstack_strndup.
5190         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5191         (write_var_or_type): Use obstack_strndup.
5192
5193 2019-08-06  Tom Tromey  <tom@tromey.com>
5194
5195         * symfile.c (reread_symbols): Use obstack_strdup.
5196         * stabsread.c (read_type): Use obstack_strdup.
5197         * gdb_obstack.h (obstack_strdup): New overload.
5198         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5199         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5200         (dwarf2_canonicalize_name): Use obstack_strdup.
5201         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5202         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5203         Use obstack_strdup.
5204
5205 2019-08-06  Tom Tromey  <tom@tromey.com>
5206
5207         * gdb_obstack.h (obstack_strdup): Define.
5208         * gdb_obstack.c (obstack_strdup): Don't define.
5209
5210 2019-08-06  Tom Tromey  <tom@tromey.com>
5211
5212         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5213         obstack_strdup.
5214         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5215         obstack_strdup.
5216         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5217         * stabsread.c (common_block_start): Use obstack_strdup.
5218         * objfiles.c (set_objfile_main_name, objfile): Use
5219         obstack_strdup.
5220         * namespace.c (add_using_directive): Use obstack_strdup.
5221         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5222         * jit.c (finalize_symtab): Use obstack_strdup.
5223         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5224         (guess_partial_die_structure_name, partial_die_info::fixup)
5225         (dwarf2_name): Use obstack_strdup.
5226         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5227         obstack_strdup.
5228         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5229         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5230         obstack_strdup.
5231         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5232
5233 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5234
5235         * unittests/help-doc-selftests.c: New file.
5236         * Makefile.in: Add the new file.
5237
5238 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5239
5240         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5241         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5242         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5243         the trailing '.' is not output, and the first character is uppercased.
5244         (print_help_for_command): Update call to print_doc_line.
5245         (print_doc_of_command): Likewise.
5246         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5247         * cli/cli-option.c (append_indented_doc): Do not append newline.
5248         (build_help_option): Append newline after first appended_indented_doc
5249         only if a second call is done.
5250         (build_help): Append 2 new lines before each option, except the first
5251         one.
5252         * compile/compile.c (_initialize_compile): Add new lines after
5253         %OPTIONS%, when not at the end of the help.
5254         Change help doc or code
5255         producing the help doc to respect the invariants.
5256         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5257         Also removed the new line after 'Options:', as all other commands
5258         do not put an empty line between 'Options:' and the first option.
5259         * printcmd.c (_initialize_printcmd): Likewise.
5260         * stack.c (_initialize_stack): Likewise.
5261         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5262         incorrectly telling COMMAND is optional.
5263         * ada-lang.c (_initialize_ada_language): Change help doc or code
5264         producing the help doc to respect the invariants.
5265         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5266         * breakpoint.c (_initialize_breakpoint): Likewise.
5267         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5268         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5269         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5270         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5271         _initialize_cli_style): Likewise.
5272         * corelow.c (core_target_info): Likewise.
5273         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5274         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5275         * filesystem.c (_initialize_filesystem): Likewise.
5276         * frame.c (_initialize_frame): Likewise.
5277         * gnu-nat.c (add_task_commands): Likewise.
5278         * infcall.c (_initialize_infcall): Likewise.
5279         * infcmd.c (_initialize_infcmd): Likewise.
5280         * interps.c (_initialize_interpreter): Likewise.
5281         * language.c (_initialize_language): Likewise.
5282         * linux-fork.c (_initialize_linux_fork): Likewise.
5283         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5284         * maint.c (_initialize_maint_cmds): Likewise.
5285         * memattr.c (_initialize_mem): Likewise.
5286         * printcmd.c (_initialize_printcmd): Likewise.
5287         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5288         _RegEx): Likewise.
5289         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5290         * record-btrace.c (_initialize_record_btrace): Likewise.
5291         * record-full.c (_initialize_record_full): Likewise.
5292         * record.c (_initialize_record): Likewise.
5293         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5294         * regcache.c (_initialize_regcache): Likewise.
5295         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5296         _initialize_remote): Likewise.
5297         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5298         * serial.c (_initialize_serial): Likewise.
5299         * skip.c (_initialize_step_skip): Likewise.
5300         * source.c (_initialize_source): Likewise.
5301         * stack.c (_initialize_stack): Likewise.
5302         * symfile.c (_initialize_symfile): Likewise.
5303         * symtab.c (_initialize_symtab): Likewise.
5304         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5305         * top.c (init_main): Likewise.
5306         * tracefile-tfile.c (tfile_target_info): Likewise.
5307         * tracepoint.c (_initialize_tracepoint): Likewise.
5308         * tui/tui-win.c (_initialize_tui_win): Likewise.
5309         * utils.c (add_internal_problem_command): Likewise.
5310         * valprint.c (value_print_option_defs): Likewise.
5311
5312 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5313
5314         PR build/24886
5315         * configure.ac: Drop enable-libmcheck support.
5316         * configure, config.in: Rebuild.
5317         * libmcheck.m4: Remove.
5318         * acinclude.m4: Don't include it.
5319         * Makefile.in: Don't distribute it.
5320         * top.c (print_gdb_configuration): Don't mention it.
5321
5322 2019-08-06  Tom Tromey  <tom@tromey.com>
5323
5324         * utils.c (set_output_style): Sometimes pass stream to
5325         emit_style_escape.
5326         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5327         * record-btrace.c (btrace_insn_history): Update.
5328         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5329         method.
5330         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5331         Update initializers.
5332         <m_uiout>: New field.
5333         <m_di>: Move lower.
5334         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5335         Remove "uiout" parameter.
5336         (dump_insns): Update.
5337         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5338         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5339
5340 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5341
5342         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5343         (error_in_psymtab_expansion): Likewise.
5344         (lookup_symbol_via_quick_fns): Likewise.
5345         (basic_lookup_transparent_type_quick): Likewise.
5346         (basic_lookup_transparent_type_1): Likewise.
5347
5348 2019-08-06  Tom Tromey  <tromey@adacore.com>
5349
5350         * source.c (last_source_error): Now bool.
5351         (print_source_lines_base): Make "noprint" bool.  Only open
5352         source file when last_source_visited changes.
5353
5354 2019-08-06  Tom Tromey  <tromey@adacore.com>
5355
5356         * annotate.c (annotate_source_line): Use g_source_cache.
5357         * source-cache.c (source_cache::get_plain_source_lines): Change
5358         parameters.  Populate m_offset_cache.
5359         (source_cache::ensure): New method.
5360         (source_cache::get_line_charpos): New method.
5361         (extract_lines): Move lower.  Change parameters.
5362         (source_cache::get_source_lines): Move lower.
5363         * source-cache.h (class source_cache): Update comment.
5364         <get_line_charpos>: New method.
5365         <get_source_lines>: Update comment.
5366         <clear>: Clear m_offset_cache.
5367         <get_plain_source_lines>: Change parameters.
5368         <ensure>: New method
5369         <m_offset_cache>: New member.
5370         * source.c (forget_cached_source_info_for_objfile): Update.
5371         (info_source_command): Use g_source_cache.
5372         (find_source_lines, open_source_file_with_line_charpos): Remove.
5373         (print_source_lines_base, search_command_helper): Use g_source_cache.
5374         * source.h (open_source_file_with_line_charpos): Don't declare.
5375         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5376         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5377         Use g_source_cache.
5378
5379 2019-08-06  Tom Tromey  <tromey@adacore.com>
5380
5381         * source-cache.c (source_cache::get_plain_source_lines):
5382         Remove "first_line" and "last_line" parameters.
5383         (source_cache::get_source_lines): Cache plain text.
5384         * source-cache.h (class source_cache)
5385         <get_plain_source_lines>: Update.
5386
5387 2019-08-06  Tom Tromey  <tromey@adacore.com>
5388
5389         * source-cache.c (extract_lines): No longer a method.
5390         Changed type of parameter.  Include final newline.
5391         (selftests::extract_lines_test): New function.
5392         (_initialize_source_cache): Likewise.
5393         * source-cache.h (class source_cache)
5394         <extract_lines>: Don't declare.
5395
5396 2019-08-06  Tom Tromey  <tromey@adacore.com>
5397
5398         * breakpoint.c (init_breakpoint_sal): Update.
5399         (breakpoint): Update.
5400         * breakpoint.h (struct breakpoint) <filter>: Now a
5401         unique_xmalloc_ptr.
5402
5403 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5404
5405         * NEWS: Mention dictionary access on blocks.
5406         * python/py-block.c (blpy_getitem): New function.
5407         (block_object_as_mapping): New struct.
5408         (block_object_type): Use new struct for tp_as_mapping field.
5409
5410 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5411
5412         * objfiles.h (objfile): Add a comment describing partial symbols.
5413
5414 2019-08-05  Tom Tromey  <tromey@adacore.com>
5415
5416         * compile/compile.c (_initialize_compile): Use _(), not N_().
5417         * thread.c (_initialize_thread): Use _(), not N_().
5418         * stack.c (_initialize_stack): Use _(), not N_().
5419         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5420
5421 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5422
5423         * dwarf2read.c (struct dw2_symtab_iterator):
5424         <want_specific_block>: Remove.
5425         <block_index>: Change type to gdb::optional.
5426         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5427         change type of BLOCK_INDEX parameter to gdb::optional.
5428         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5429         (dw2_lookup_symbol): Don't pass argument for
5430         WANT_SPECIFIC_BLOCK.
5431         (dw2_expand_symtabs_for_function): Don't pass argument for
5432         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5433         (class dw2_debug_names_iterator)
5434         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5435         parameter, change BLOCK_INDEX type to gdb::optional.
5436         <m_want_specific_block>: Remove.
5437         <m_block_index>: Change type to gdb::optional.
5438         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5439         gdb::optional.  Re-write in function of gdb::optional.
5440         (dw2_debug_names_lookup_symbol): Don't pass argument for
5441         WANT_SPECIFIC_BLOCK.
5442         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5443         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5444         BLOCK_INDEX.
5445
5446 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5447
5448         * NEWS: Mention changes to "info sources" command.
5449
5450 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5451
5452         * symtab.c (filename_partial_match_opts): New struct type.
5453         (struct output_source_filename_data): New members
5454         regexp, c_regexp, partial_match.
5455         (output_source_filename): Use new members to decide to print file.
5456         (info_sources_option_defs): New variable.
5457         (make_info_sources_options_def_group, print_info_sources_header,
5458         info_sources_command_completer):
5459         New functions.
5460         (info_sources_command): Read new optional arguments.
5461         (_initialize_symtab): Update info sources help.
5462
5463 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5464
5465         * ada-lang.c (exception_support_info_v0): Renamed from...
5466         (default_exception_support_info): ... this.  Create new
5467         definition for v1.
5468         (ada_has_this_exception_support): Look up catch_handlers_sym.
5469         (ada_exception_support_info_sniffer): Try v0 after default.
5470
5471 2019-08-01  Tom Tromey  <tromey@adacore.com>
5472
5473         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5474         gdbarch.h.
5475
5476 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5477
5478         * s12z-tdep.c: Fix include path for s12z-opc.h.
5479
5480 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5481
5482         * NEWS: Require GNU make 3.82.
5483
5484 2019-07-16  Tom Tromey  <tom@tromey.com>
5485
5486         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5487         declare.
5488
5489 2019-07-30  Tom Tromey  <tromey@adacore.com>
5490
5491         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5492
5493 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5494
5495         * printcmd.c (print_address_symbolic): Print negative offsets.
5496         (build_address_symbolic): Force signed arithmetic when computing
5497         offset.
5498
5499 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5500
5501         PR/24474: Add a function to lookup static variables.
5502         * NEWS: Mention this new function.
5503         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5504         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5505         * python/python.c (python_GdbMethods): Add new function.
5506
5507 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5508
5509         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5510         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5511         (objfpy_lookup_static_symbol): New function.
5512         (objfile_object_methods): Add new functions.
5513
5514 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5515
5516         * NEWS: Mention 'set|show print frame-info'.  Mention new
5517         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5518         backtrace argument.  Mention that python frame filtering code
5519         is now consistent with what 'backtrace' command prints.
5520
5521 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5522
5523         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5524         comments.
5525         (print_frame_info_auto, print_frame_info_source_line,
5526         print_frame_info_location, print_frame_info_source_and_location,
5527         print_frame_info_location_and_address, print_frame_info_short_location):
5528         New declarations.
5529         (struct frame_print_options): New member print_frame_info.
5530         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5531         * stack.h (get_user_print_what_frame_info): New declaration.
5532         (frame_show_address): New declaration.
5533         * stack.c (print_frame_arguments_choices): New value 'presence'.
5534         (print_frame_info_auto, print_frame_info_source_line,
5535         print_frame_info_location, print_frame_info_source_and_location,
5536         print_frame_info_location_and_address, print_frame_info_short_location,
5537         print_frame_info_choices, print_frame_info_print_what): New definitions.
5538         (print_frame_args): Only print dots for args if print frame-arguments
5539         is 'presence'.
5540         (frame_print_option_defs): New element for "frame-info".
5541         (get_user_print_what_frame_info): New function.
5542         (frame_show_address): Make non static.  Move comment to stack.h.
5543         (print_frame_info_to_print_what): New function.
5544         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5545         to decide what to print.
5546         (backtrace_command_1): Handle the new print_frame_arguments_presence
5547         value.
5548         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5549         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5550         (py_print_frame): In non-mi mode, use LOCATION as default for
5551         print_what, similarly to frame information printed directly by
5552         backtrace command. Handle frame-info user option in non MI mode.
5553
5554 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5555
5556         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5557         Add case for debugging 32-bit target on 64-bit host.  Revise
5558         comment.
5559
5560 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5561
5562         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5563         instead of find_function_entry_range_from_pc.
5564
5565 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5566
5567         * stack.c (find_frame_funname): Remove code which preferred
5568         minsym over symtab sym in "certain pathological cases".
5569
5570         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5571         parameter.  Change type of "do_demangle" to bool.
5572         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5573         Pass suitable "prefer_sym_over_minsym" flag to
5574         build_address_symbolic().  Don't output "+" for negative offsets.
5575         * printcmd.c (print_address_symbolic): Update invocation of
5576         build_address_symbolic to include a "prefer_sym_over_minsym"
5577         flag.
5578         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5579         Restrict cases in which use of minimal symbol is preferred to that
5580         of a found symbol.  Update comments.
5581
5582         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5583         for entry pc when entry pc is out of range for that FDE.
5584
5585 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5586
5587         PR gdb/24839:
5588         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5589         type.
5590
5591 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5592
5593         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5594         this function's Python signature.
5595
5596
5597 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5598
5599         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5600         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5601         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5602         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5603         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5604
5605
5606 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5607
5608         * h8300-tdep.c (h8300_register_name_common): New.
5609         h8300_register_name): Use h8300_register_name_common.
5610         (h8300s_register_name): Likewise.
5611         (h8300sx_register_name): Likewise.
5612         (h8300h_register_nam): New.
5613         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5614
5615
5616 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5617
5618         * arm-tdep.c (arm_skip_cmse_entry): New function.
5619         (arm_is_sgstubs_section): New function.
5620         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5621
5622 2019-07-22  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5625         Don't self-assign.
5626
5627 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5628
5629         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5630         type_print.
5631
5632 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5635         so that GDB doesn't match any msymbols when searching in the
5636         TYPES_DOMAIN.
5637         (print_symbol_info): Print using typedef_print or type_print based
5638         on the type of the symbol.  Add updated FIXME comment moved from...
5639         (_initialize_symtab): ... move and update FIXME comment to above.
5640
5641 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5642
5643         * NEWS: Mention adding -q option to "info types".
5644         * symtab.c (struct info_types_options): New struct.
5645         (info_types_options_defs): New variable.
5646         (make_info_types_options_def_group): New function.
5647         (info_types_command): Use gdb::option framework to parse options.
5648         (info_types_command_completer): New function.
5649         (_initialize_symtab): Extend the help text on "info types" and
5650         register command completer.
5651
5652 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5653
5654         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5655         (lookup_symbol_in_objfile): Change int to block_enum and add a
5656         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5657
5658 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5659
5660         * MAINTAINERS (Write After Approval): Add self.
5661
5662 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5663
5664         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5665         instruction to the dummy code region.
5666
5667 2019-07-19  Tom Tromey  <tromey@adacore.com>
5668
5669         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5670         (ARGSUSED, PARAMS, __func__): Remove rules.
5671
5672 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5673
5674         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5675         * features/arm/arm-with-iwmmxt.c: Remove.
5676         * features/arm/arm-with-iwmmxt.xml: Remove.
5677         * features/arm/arm-with-m-fpa-layout.c: Remove.
5678         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5679         * features/arm/arm-with-m-vfp-d16.c: Remove.
5680         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5681         * features/arm/arm-with-m.c: Remove.
5682         * features/arm/arm-with-m.xml: Remove.
5683         * features/arm/arm-with-neon.c: Remove.
5684         * features/arm/arm-with-neon.xml: Remove.
5685         * features/arm/arm-with-vfpv2.c: Remove.
5686         * features/arm/arm-with-vfpv2.xml: Remove.
5687         * features/arm/arm-with-vfpv3.c: Remove.
5688         * features/arm/arm-with-vfpv3.xml: Remove.
5689
5690 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5691
5692         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5693
5694 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5695
5696         * arch/aarch32.c (aarch32_create_target_description): Create
5697         target descriptions using features.
5698         * arch/arm.c (arm_create_target_description)
5699         (arm_create_mprofile_target_description): Likewise.
5700         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5701
5702 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5703
5704         * Makefile.in: Add new files.
5705         * aarch32-tdep.c: New file.
5706         * aarch32-tdep.h: New file.
5707         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5708         Call aarch32_read_description.
5709         * arch/aarch32.c: New file.
5710         * arch/aarch32.h: New file.
5711         * arch/arm.c (arm_create_target_description)
5712         (arm_create_mprofile_target_description): New function.
5713         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5714         (arm_create_target_description)
5715         (arm_create_mprofile_target_description): New declaration.
5716         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5717         read_description functions.
5718         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5719         Likewise.
5720         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5721         * arm-tdep.c (tdesc_arm_list): New variable.
5722         (arm_register_g_packet_guesses): Call create description functions.
5723         (arm_read_description) (arm_read_mprofile_description): New
5724         function.
5725         * arm-tdep.h (arm_read_description)
5726         (arm_read_mprofile_description): Add declaration.
5727         * configure.tgt: Add new files.
5728
5729 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5730
5731         * top.c (new_ui_command): Open specified terminal just once.
5732
5733 2019-07-18  Tom Tromey  <tromey@adacore.com>
5734
5735         * symtab.c (main_name): Constify return type.
5736         * symfile.c (set_initial_language): Update.
5737         * symtab.h (main_name): Constify return type.
5738
5739 2019-07-17  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-winsource.c (tui_update_source_window)
5742         (tui_update_source_window_as_is)
5743         (tui_update_source_windows_with_line): Remove return.
5744         * tui/tui-disasm.c (tui_show_disassem)
5745         (tui_show_disassem_and_update_source): Remove return.
5746         * tui/tui.c (tui_reset): Remove return.
5747         * tui/tui-wingeneral.c
5748         (tui_check_and_display_highlight_if_needed): Remove return.
5749
5750 2019-07-17  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5753
5754 2019-07-17  Tom Tromey  <tom@tromey.com>
5755
5756         * tui/tui-winsource.h (struct tui_exec_info_window)
5757         (struct tui_source_window_base): Move from tui-data.h.
5758         * tui/tui-winsource.c: Move many method definitions from
5759         elsewhere.  Remove "structuring" comments.
5760         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5761         (tui_source_window_base::refresh_window): Move to
5762         tui-winsource.c.
5763         * tui/tui-win.c (tui_source_window_base::refresh_all)
5764         (tui_source_window_base::update_tab_width)
5765         (tui_source_window_base::set_new_height)
5766         (tui_source_window_base::do_make_visible_with_new_height): Move to
5767         tui-winsource.c.
5768         * tui/tui-source.h: Update.
5769         * tui/tui-source.c (tui_source_window_base::reset): Move to
5770         tui-winsource.c.
5771         * tui/tui-disasm.h: Update.
5772         * tui/tui-data.h (struct tui_exec_info_window): Move to
5773         tui-winsource.h.
5774         (struct tui_source_window_base): Likewise.
5775         * tui/tui-data.c (tui_source_window_base::clear_detail)
5776         (tui_source_window_base, ~tui_source_window_base): Move to
5777         tui-winsource.c.
5778
5779 2019-07-17  Tom Tromey  <tom@tromey.com>
5780
5781         * tui/tui-win.c (tui_resize_all)
5782         (tui_source_window_base::update_tab_width)
5783         (tui_adjust_win_heights): Update.
5784         (tui_win_info::make_invisible_and_set_new_height): Rename from
5785         make_invisible_and_set_new_height.
5786         * tui/tui-data.h (struct tui_win_info)
5787         <make_invisible_and_set_new_height>: New method.
5788
5789 2019-07-17  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui.c: Update.
5792         * tui/tui-source.h (struct tui_source_window): Move from
5793         tui-data.h.
5794         * tui/tui-layout.c: Update.
5795         * tui/tui-disasm.c: Update.
5796         * tui/tui-data.h (struct tui_source_window): Move to
5797         tui-source.h.
5798
5799 2019-07-17  Tom Tromey  <tom@tromey.com>
5800
5801         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5802         tui-data.h.
5803         * tui/tui-data.h (struct tui_disasm_window): Move to
5804         tui-disasm.h.
5805
5806 2019-07-17  Tom Tromey  <tom@tromey.com>
5807
5808         * tui/tui-regs.h (struct tui_data_item_window): Move from
5809         tui-data.h.
5810         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5811         * tui/tui-data.h (struct tui_data_item_window): Move to
5812         tui-regs.h.
5813         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5814
5815 2019-07-17  Tom Tromey  <tom@tromey.com>
5816
5817         * tui/tui.c: Update.
5818         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5819         (tui_cmd_window::max_height): Move to tui-command.c.
5820         * tui/tui-layout.c: Update.
5821         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5822         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5823         tui-command.c.
5824         * tui/tui-command.h (struct tui_cmd_window): Move from
5825         tui-data.h.
5826         * tui/tui-command.c: Remove "structuring" comments.
5827         (tui_cmd_window::clear_detail)
5828         (tui_cmd_window::do_make_visible_with_new_height)
5829         (tui_cmd_window::max_height): Move from elsewhere.
5830
5831 2019-07-17  Tom Tromey  <tom@tromey.com>
5832
5833         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5834         Now static.
5835         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5836         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5837
5838 2019-07-17  Tom Tromey  <tom@tromey.com>
5839
5840         * tui/tui.c: Update.
5841         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5842         tui-regs.c.
5843         * tui/tui-windata.h: Remove file.
5844         * tui/tui-windata.c: Remove file.
5845         * tui/tui-win.c (tui_data_window::set_new_height)
5846         (tui_data_window::do_make_visible_with_new_height): Move to
5847         tui-regs.c.
5848         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5849         * tui/tui-regs.c: Remove "structuring" comments.
5850         (tui_data_window::first_data_item_displayed)
5851         (tui_data_window::delete_data_content_windows)
5852         (tui_data_window::erase_data_content)
5853         (tui_data_window::display_all_data)
5854         (tui_data_window::refresh_all)
5855         (tui_data_window::do_scroll_vertical)
5856         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5857         (tui_data_window::do_make_visible_with_new_height)
5858         (tui_data_window::refresh_window): Move from elsewhere.
5859         (_initialize_tui_regs): Move to end of file.
5860         * tui/tui-layout.c: Update.
5861         * tui/tui-hooks.c: Update.
5862         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5863         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5864         tui-regs.c.
5865         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5866
5867 2019-07-17  Tom Tromey  <tom@tromey.com>
5868
5869         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5870         seen.
5871
5872 2019-07-17  Tom Tromey  <tom@tromey.com>
5873
5874         * tui/tui-win.c (tui_source_window_base::set_new_height)
5875         (tui_source_window_base::do_make_visible_with_new_height): Use
5876         m_has_locator field directly.
5877         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5878         method.
5879         (struct tui_source_window_base) <has_locator>: Likewise.
5880
5881 2019-07-17  Tom Tromey  <tom@tromey.com>
5882
5883         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5884         Don't declare.
5885         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5886         Remove.
5887         * tui/tui-win.c (tui_source_window_base::set_new_height)
5888         (tui_source_window_base::set_new_height)
5889         (make_invisible_and_set_new_height)
5890         (tui_source_window_base::do_make_visible_with_new_height)
5891         (tui_source_window_base::do_make_visible_with_new_height):
5892         Update.
5893         * tui/tui-layout.c (show_source_disasm_command, show_data)
5894         (show_source_or_disasm_and_command): Update.
5895         * tui/tui-layout.c (show_layout): Update.
5896
5897 2019-07-17  Tom Tromey  <tom@tromey.com>
5898
5899         * tui/tui-layout.c (make_data_window): Remove.
5900         (show_data): Unify creation and re-initialization cases.
5901
5902 2019-07-17  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-layout.c (make_source_window, make_disasm_window):
5905         Remove.
5906         (show_data): Unify creation and re-initialization cases.
5907
5908 2019-07-17  Tom Tromey  <tom@tromey.com>
5909
5910         * tui/tui-layout.c (make_command_window): Remove.
5911         (show_source_disasm_command, show_source_or_disasm_and_command):
5912         Unify creation and re-initialization cases.
5913
5914 2019-07-17  Tom Tromey  <tom@tromey.com>
5915
5916         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5917         creation and re-initialization cases.
5918
5919 2019-07-17  Tom Tromey  <tom@tromey.com>
5920
5921         * tui/tui-regs.c (tui_get_register): Return void.
5922
5923 2019-07-17  Tom Tromey  <tom@tromey.com>
5924
5925         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5926         Simplify.
5927
5928 2019-07-17  Tom Tromey  <tom@tromey.com>
5929
5930         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5931         resetting.
5932
5933 2019-07-17  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5936         * tui/tui-regs.c (tui_reg_layout): New function.
5937         (tui_show_registers, tui_reg_command): Use it.
5938         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5939         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5940         parameters.
5941         (tui_layout_command): Remove.
5942
5943 2019-07-17  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-layout.h (tui/tui-layout): Return void.
5946         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5947
5948 2019-07-17  Tom Tromey  <tom@tromey.com>
5949
5950         * tui/tui-layout.c (show_source_disasm_command, show_data):
5951         Update.
5952         (reset_locator): Remove.
5953         (show_source_or_disasm_and_command): Update.
5954
5955 2019-07-17  Tom Tromey  <tom@tromey.com>
5956
5957         * tui/tui-source.c (tui_source_window_base::reset): Remove
5958         win_type parameter.
5959         * tui/tui-layout.c (make_command_window, make_source_window)
5960         (make_disasm_window, make_data_window)
5961         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5962         (reset_locator, show_source_or_disasm_and_command): Update.
5963         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5964         win_type parameter.
5965         (struct tui_source_window_base) <reset>: Likewise.
5966
5967 2019-07-17  Tom Tromey  <tom@tromey.com>
5968
5969         * tui/tui-layout.c (show_source_disasm_command): Use
5970         reset_locator.
5971         (reset_locator): New function.
5972         (init_and_make_win): Remove.
5973         (show_source_or_disasm_and_command): Use reset_locator.
5974
5975 2019-07-17  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5978         condition.
5979         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5980         Remove condition.
5981         * tui/tui-source.c (tui_source_window_base::reset): New method.
5982         * tui/tui-layout.c (make_command_window): Don't call
5983         init_and_make_win.
5984         (make_source_window, make_disasm_window): Don't call
5985         make_source_or_disasm_window.
5986         (make_data_window): Don't call init_and_make_win.  Change calling
5987         convention.
5988         (show_source_disasm_command, show_data): Simplify.
5989         (make_source_or_disasm_window): Remove.
5990         (show_source_or_disasm_and_command): Simplify.
5991         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5992         (struct tui_source_window_base) <reset>: Likewise.
5993         <execution_info>: Remove initializer.
5994         * tui/tui-data.c (tui_source_window_base): Initialize
5995         execution_info.
5996
5997 2019-07-17  Tom Tromey  <tom@tromey.com>
5998
5999         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6000         variable.
6001
6002 2019-07-17  Tom Tromey  <tom@tromey.com>
6003
6004         * tui/tui.c (tui_rl_other_window): Update.
6005         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6006         superclass method first.  Always iterate over regs_content.
6007         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6008         method.
6009         * tui/tui-win.c (tui_set_focus_command): Update.
6010
6011 2019-07-17  Tom Tromey  <tom@tromey.com>
6012
6013         * tui/tui-win.c (tui_set_focus_command): Rename from
6014         tui_set_focus.  Call tui_enable.
6015         (tui_set_focus_command): Remove.
6016
6017 2019-07-17  Tom Tromey  <tom@tromey.com>
6018
6019         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6020         refresh_window.
6021         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6022         touchwin.
6023         (tui_data_window::refresh_window): Call refresh_window on data
6024         items.  Always call superclass refresh_window.
6025         (tui_win_info::refresh): Remove.
6026         (tui_source_window_base::refresh_window): Update.
6027         (tui_refresh_all): Update.
6028         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6029         refresh_window.
6030         (show_source_or_disasm_and_command): Likewise.
6031         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6032         (struct tui_source_window_base) <refresh>: Likewise.
6033
6034 2019-07-17  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-winsource.c (tui_clear_source_content)
6037         (tui_show_source_content): Update.
6038         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6039         whether content is empty.
6040         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6041         Remove.
6042
6043 2019-07-17  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6046         window's contents.
6047         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6048         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6049
6050 2019-07-17  Tom Tromey  <tom@tromey.com>
6051
6052         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6053         (struct tui_data_item_window): Update.
6054
6055 2019-07-17  Tom Tromey  <tom@tromey.com>
6056
6057         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6058         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6059         defines.
6060
6061 2019-07-17  Tom Tromey  <tom@tromey.com>
6062
6063         * tui/tui-winsource.h (tui_erase_source_content)
6064         (tui_clear_source_content): Remove "display_prompt" parameter.
6065         * tui/tui-winsource.c (tui_update_source_window_as_is)
6066         (tui_update_source_windows_with_addr): Update.
6067         (tui_clear_source_content): Remove "display_prompt" parameter.
6068         (tui_erase_source_content): Likewise.  Simplify.
6069         (tui_show_source_content): Update.
6070         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6071         * tui/tui-stack.c (tui_show_frame_info): Update.
6072         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6073         Remove defines.
6074
6075 2019-07-17  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6078         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6079         parameter.
6080         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6081         parameter.
6082
6083 2019-07-17  Tom Tromey  <tom@tromey.com>
6084
6085         * tui/tui-winsource.c (tui_clear_source_content)
6086         (tui_show_source_content, tui_show_exec_info_content)
6087         (tui_clear_exec_info_content): Update.
6088         * tui/tui-stack.c (tui_show_locator_content): Update.
6089         (tui_show_frame_info): Update.
6090         * tui/tui-source.h (tui_source_window): Don't declare.
6091         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6092         from tui_source_is_displayed.
6093         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6094         Remove field.
6095         (struct tui_source_window_base) <content_in_use>: New field.  Now
6096         bool.
6097         (struct tui_source_window) <showing_source_p>: New method.
6098         (TUI_SRC_WIN): Change cast.
6099         * tui/tui-data.c (tui_initialize_static_data): Update.
6100
6101 2019-07-17  Tom Tromey  <tom@tromey.com>
6102
6103         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6104         location_matches_p.
6105         * tui/tui-source.c (tui_source_window::location_matches_p): New
6106         method.
6107         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6108         method.
6109         * tui/tui-data.h (struct tui_source_window_base)
6110         <location_matches_p>: New method.
6111         (struct tui_source_window, struct tui_disasm_window)
6112         <location_matches_p>: Likewise.
6113
6114 2019-07-17  Tom Tromey  <tom@tromey.com>
6115
6116         * tui/tui-win.c (tui_set_win_height_command): Rename from
6117         tui_set_win_height.
6118         (tui_set_win_height_command): Remove.
6119
6120 2019-07-17  Tom Tromey  <tom@tromey.com>
6121
6122         * tui/tui-source.c (tui_source_window): New constructor.  Add
6123         observer.
6124         (~tui_source_window): New destructor.
6125         (tui_source_window::style_changed): New method.
6126         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6127         (tui_attach_detach_observers): Update.
6128         * tui/tui-data.h (struct tui_source_window): Make constructor not
6129         inline.  Add destructor.
6130         (struct tui_source_window) <style_changed>: New method.
6131         <m_observable>: New member.
6132
6133 2019-07-17  Tom Tromey  <tom@tromey.com>
6134
6135         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6136         * tui/tui-win.c (tui_resize_all): Fix typo.
6137
6138 2019-07-17  Tom Tromey  <tom@tromey.com>
6139
6140         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6141         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6142         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6143         * tui/tui-win.c (window_name_completer): Use foreach.
6144         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6145         (update_tab_width): Likewise.
6146         * tui/tui-layout.c (show_layout): Update.
6147         * tui/tui-data.h (class tui_window_iterator): New.
6148         (struct all_tui_windows): New.
6149         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6150
6151 2019-07-17  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6154         parameter.  Don't reference globals.
6155         (tui_reg_command): Update.
6156
6157 2019-07-17  Tom Tromey  <tom@tromey.com>
6158
6159         * tui/tui-regs.c (tui_show_registers): Simplify.
6160
6161 2019-07-17  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui-regs.c (tui_show_registers): Update.
6164         (tui_show_register_group): Add win_info parameter.
6165
6166 2019-07-17  Tom Tromey  <tom@tromey.com>
6167
6168         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6169         Rename from tui_display_reg_element_at_line.
6170         (tui_data_window::display_registers_from_line): Update.
6171         * tui/tui-data.h (struct tui_data_window)
6172         <display_reg_element_at_line>: New method.
6173
6174 2019-07-17  Tom Tromey  <tom@tromey.com>
6175
6176         * tui/tui-regs.h (tui_display_registers_from)
6177         (tui_display_registers_from_line): Don't declare.
6178         * tui/tui-windata.c (tui_data_window::display_all_data)
6179         (tui_data_window::refresh_all)
6180         (tui_data_window::do_scroll_vertical): Update.
6181         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6182         from tui_display_registers_from.
6183         (tui_display_reg_element_at_line): Update.
6184         (tui_data_window::display_registers_from_line): Rename from
6185         tui_display_registers_from_line.
6186         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6187         display_registers_from_line>: New methods.
6188
6189 2019-07-17  Tom Tromey  <tom@tromey.com>
6190
6191         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6192         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6193         from tui_erase_data_content.
6194         (tui_data_window::display_all_data)
6195         (tui_data_window::refresh_all)
6196         (tui_data_window::do_scroll_vertical): Update.
6197         * tui/tui-regs.c (tui_show_registers): Update.
6198         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6199         New method.
6200
6201 2019-07-17  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6204         declare.
6205         * tui/tui-windata.c
6206         (tui_data_window::delete_data_content_windows): Rename from
6207         tui_delete_data_content_windows.
6208         (tui_data_window::display_all_data)
6209         (tui_data_window::do_scroll_vertical): Update.
6210         * tui/tui-data.h (struct tui_data_window)
6211         <delete_data_content_windows>: New method.
6212
6213 2019-07-17  Tom Tromey  <tom@tromey.com>
6214
6215         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6216         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6217
6218 2019-07-17  Tom Tromey  <tom@tromey.com>
6219
6220         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6221         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6222         from tui_display_all_data.
6223         * tui/tui-win.c
6224         (tui_data_window::do_make_visible_with_new_height): Update.
6225         * tui/tui-regs.c (tui_show_registers): Update.
6226         * tui/tui-layout.c (tui_set_layout): Update.
6227         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6228         method.
6229
6230 2019-07-17  Tom Tromey  <tom@tromey.com>
6231
6232         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6233         * tui/tui-windata.c (tui_display_data_from): Remove.
6234         (tui_data_window::refresh_all): Update.
6235
6236 2019-07-17  Tom Tromey  <tom@tromey.com>
6237
6238         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6239         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6240         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6241         tui_display_registers_from_line.
6242         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6243         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6244         "force_display" parameter.
6245
6246 2019-07-17  Tom Tromey  <tom@tromey.com>
6247
6248         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6249         declare.
6250         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6251         Rename from tui_first_reg_element_no_inline.
6252         (tui_display_reg_element_at_line)
6253         (tui_display_registers_from_line): Update.
6254         * tui/tui-data.h (struct tui_data_window)
6255         <first_reg_element_no_inline>: New method.
6256
6257 2019-07-17  Tom Tromey  <tom@tromey.com>
6258
6259         * tui/tui-windata.c (tui_display_data_from)
6260         (tui_data_window::do_scroll_vertical): Update.
6261         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6262         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6263         Rename from tui_line_from_reg_element_no.
6264         (tui_display_registers_from_line): Update.
6265         * tui/tui-data.h (struct tui_data_window)
6266         <line_from_reg_element_no>: New method.
6267
6268 2019-07-17  Tom Tromey  <tom@tromey.com>
6269
6270         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6271         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6272         tui_last_regs_line_no.
6273         (tui_display_reg_element_at_line)
6274         (tui_display_registers_from_line): Update.
6275         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6276         method.
6277
6278 2019-07-17  Tom Tromey  <tom@tromey.com>
6279
6280         PR tui/24722:
6281         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6282         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6283         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6284         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6285         (tui_update_breakpoint_info): Likewise.
6286         * tui/tui-hooks.c (tui_event_create_breakpoint)
6287         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6288         Update.
6289
6290 2019-07-17  Tom Tromey  <tom@tromey.com>
6291
6292         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6293
6294 2019-07-17  Tom Tromey  <tom@tromey.com>
6295
6296         * tui/tui-winsource.c (tui_update_source_window_as_is)
6297         (tui_update_source_windows_with_addr): Update.
6298         * tui/tui-source.h (tui_set_source_content)
6299         (tui_show_symtab_source): Add "win_info" parameter.
6300         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6301         parameter.
6302         (tui_show_symtab_source): Likewise.
6303
6304 2019-07-17  Tom Tromey  <tom@tromey.com>
6305
6306         * tui/tui-wingeneral.c
6307         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6308
6309 2019-07-17  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6312         (struct tui_cmd_window) <can_scroll>: New method.
6313         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6314         method.
6315
6316 2019-07-17  Tom Tromey  <tromey@adacore.com>
6317
6318         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6319         do_field_signed>: Rename.  Change type of "value".
6320         * ui-out.c (ui_out::field_signed): Rename from field_int.
6321         Change type of "value".
6322         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6323         type of "value".
6324         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6325         do_field_int.  Change type of "value".
6326         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6327         do_field_int.  Change type of "value".
6328         * tracepoint.c (trace_status_mi, tfind_1)
6329         (print_one_static_tracepoint_marker): Update.
6330         * thread.c (print_thread_info_1, print_selected_thread_frame):
6331         Update.
6332         * stack.c (print_frame, print_frame_info): Update.
6333         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6334         Update.
6335         * source.c (print_source_lines_base): Update.
6336         * skip.c (info_skip_command): Update.
6337         * record-btrace.c (btrace_ui_out_decode_error)
6338         (btrace_call_history_src_line): Update.
6339         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6340         Update.
6341         * progspace.c (print_program_space): Update.
6342         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6343         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6344         do_field_int.  Change type of "value".
6345         * mi/mi-out.c (mi_ui_out::do_table_begin)
6346         (mi_ui_out::do_table_header): Update.
6347         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6348         type of "value".
6349         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6350         (mi_cmd_data_list_changed_registers, output_register)
6351         (mi_cmd_data_read_memory, mi_load_progress)
6352         (mi_cmd_trace_frame_collected): Update.
6353         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6354         Update.
6355         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6356         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6357         (mi_cmd_var_list_children, varobj_update_one): Update.
6358         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6359         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6360         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6361         * inferior.c (print_inferior): Update.
6362         * gdb_bfd.c (print_one_bfd): Update.
6363         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6364         Update.
6365         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6366         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6367         do_field_int.  Change type of "value".
6368         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6369         do_field_int.  Change type of "value".
6370         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6371         (print_one_breakpoint_location, print_it_catch_fork)
6372         (print_one_catch_fork, print_it_catch_vfork)
6373         (print_one_catch_vfork, print_it_catch_solib)
6374         (print_it_catch_exec, print_it_ranged_breakpoint)
6375         (print_mention_watchpoint, print_mention_masked_watchpoint)
6376         (bkpt_print_it, update_static_tracepoint): Update.
6377         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6378         * break-catch-syscall.c (print_it_catch_syscall): Update.
6379         * ada-tasks.c (print_ada_task_info): Update.
6380         * ada-lang.c (print_it_exception, print_mention_exception):
6381         Update.
6382
6383 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6384
6385         PR breakpoints/24541
6386         * gdbarch.c: Regenerate.
6387         * gdbarch.h: Regenerate.
6388         * gdbarch.sh: Adjust return type and parameter types for
6389         'stap_adjust_register'.
6390         (i386_stap_adjust_register): Adjust signature and return new
6391         register name.
6392         * stap-probe.c (stap_parse_register_operand): Adjust use of
6393         'gdbarch_stap_adjust_register'.
6394
6395 2019-07-17  Tom Tromey  <tromey@adacore.com>
6396
6397         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6398         declare VEC.
6399         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6400         std::vector.
6401         (struct s390_process_info): Add initializers.
6402         (s390_add_process): Use new.
6403         (s390_linux_nat_target::low_forget_process): Use delete.
6404         (s390_linux_nat_target::low_new_fork)
6405         (s390_linux_nat_target::stopped_by_watchpoint)
6406         (s390_linux_nat_target::low_prepare_to_resume)
6407         (s390_linux_nat_target::insert_watchpoint)
6408         (s390_linux_nat_target::insert_hw_breakpoint)
6409         (s390_linux_nat_target::remove_watchpoint)
6410         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6411
6412 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6413
6414         * aarch64-fbsd-nat.c: Include regcache.h.
6415         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6416         argument.
6417         (aarch64_fbsd_nat_target::fetch_registers)
6418         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6419         variable.
6420         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6421
6422 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6423
6424         * fbsd-nat.c: Include gdbarch.h.
6425
6426 2019-07-15  Tom Tromey  <tromey@adacore.com>
6427
6428         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6429
6430 2019-07-15  Tom Tromey  <tromey@adacore.com>
6431
6432         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6433         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6434         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6435         * cli-out.c (cli_ui_out::do_field_int): New method.
6436         * ui-out.c (ui_out::field_unsigned): New method.
6437         * symfile.c (generic_load): Use field_unsigned.
6438         (print_transfer_performance): Likewise.
6439         * record-btrace.c (ui_out_field_uint): Remove.
6440         (btrace_call_history_insn_range, btrace_call_history): Use
6441         field_unsigned.
6442         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6443         field_unsigned.
6444         * ui-out.h (class ui_out) <field_unsigned>: New method.
6445         <do_field_unsigned>: Likewise.
6446
6447 2019-07-15  Tom Tromey  <tromey@adacore.com>
6448
6449         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6450         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6451         * target.c (flash_erase_command): Use field_string.
6452         * infrun.c (print_signal_received_reason): Use field_string.
6453         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6454         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6455         field_string.
6456         * ada-tasks.c (print_ada_task_info): Use field_string.
6457
6458 2019-07-15  Tom Tromey  <tromey@adacore.com>
6459
6460         * target.c (flash_erase_command): Use field_core_addr.
6461         * symfile.c (generic_load): Use field_core_addr.
6462         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6463         Use field_core_addr.
6464         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6465         field_core_addr.
6466
6467 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6470         value if its desired type is smaller than a CORE_ADDR and signed.
6471
6472 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6473
6474         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6475         of changes to field names, and use new is_reference field to
6476         decide if a property is a reference or not.
6477         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6478         field.
6479         (struct dwarf2_property_baton): Update header comment, rename
6480         'referenced_type' to 'property_type' and update comments.
6481         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6482         default property type, store in property baton, update to take
6483         accound of renamed field.
6484         (read_func_scope): Update call to attr_to_dynamic_prop.
6485         (read_array_type): Likewise.
6486         (dwarf2_per_cu_addr_sized_int_type): New function.
6487         (read_subrange_index_type): Move type finding code to
6488         dwarf2_per_cu_addr_sized_int_type.
6489         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6490         (dwarf2_per_cu_addr_type): New function.
6491         (set_die_type): Update calls to attr_to_dynamic_prop.
6492
6493 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6494
6495         * dwarf2read.c (read_subrange_index_type): New function.
6496         (read_subrange_type): Move code into new function and call it.
6497         * gdbtypes.c (create_range_type): Add some asserts.
6498
6499 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6500
6501         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6502         update return statements.
6503         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6504         declaration, and update comment to match.
6505         * gdbtypes.c (resolve_dynamic_array): Update call to
6506         dwarf2_evaluate_property to match new return type.
6507
6508 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6509
6510         * valarith.c (value_subscripted_rvalue): Change lowerbound
6511         parameter type from int to LONGEST.
6512         * value.h (value_subscripted_rvalue): Likewise in declaration.
6513
6514 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6515
6516         * cli/cli-utils.c (info_print_command_completer): New function.
6517         * cli/cli-utils.h: Add 'completer.h' include, and forward
6518         declaration for 'struct cmd_list_element'.
6519         (info_print_command_completer): Declare.
6520         * stack.c (_initialize_stack): Add completer for 'info locals' and
6521         'info args'.
6522         * symtab.c (_initialize_symtab): Add completer for 'info
6523         variables' and 'info functions'.
6524         * NEWS: Mention completion for additional info commands.
6525
6526 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6527
6528         * cli/cli-utils.c (extract_info_print_args): Delete.
6529         (extract_arg_maybe_quoted): Delete.
6530         (info_print_options_defs): New variable.
6531         (make_info_print_options_def_group): New function.
6532         (extract_info_print_options): Define new function.
6533         * cli/cli-utils.h (extract_info_print_args): Delete.
6534         (struct info_print_options): New structure.
6535         (extract_info_print_options): Declare new function.
6536         * stack.c (info_locals_command): Update to use new
6537         extract_info_print_options, also add a header comment.
6538         (info_args_command): Likewise.
6539         * symtab.c (info_variables_command): Likewise.
6540         (info_functions_command): Likewise.
6541
6542 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6545         to extract string arguments.
6546         * common/common-utils.c (extract_string_maybe_quoted): New function.
6547         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6548
6549 2019-07-11  Tom Tromey  <tromey@adacore.com>
6550
6551         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6552         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6553         * top.h (gdbinit): Don't declare.
6554         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6555         into...
6556         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6557         * top.c (gdb_init): Don't call init_cli_cmds.
6558         (gdbinit): Remove.
6559         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6560
6561 2019-07-11  Tom Tromey  <tromey@adacore.com>
6562
6563         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6564         after it has been moved.
6565
6566 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6567
6568         * valops.c (value_must_coerce_to_target): Change return type to
6569         bool.
6570         * value.h (value_must_coerce_to_target): Likewise.
6571
6572 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6573
6574         * breakpoint.c (is_hardware_watchpoint): Remove
6575         forward-declaration.
6576         (is_masked_watchpoint): Change return type to bool.
6577         (is_tracepoint): Likewise.
6578         (is_breakpoint): Likewise.
6579         (is_hardware_watchpoint): Likewise.
6580         (is_watchpoint): Likewise.
6581         (is_no_memory_software_watchpoint): Likewise.
6582         (is_catchpoint): Likewise.
6583         (breakpoint_1): Make FILTER parameter's return type bool.
6584         is_masked_watchpoint): Change return type to bool.
6585         (save_breakpoints): Make FILTER parameter's return type bool.
6586         * breakpoint.h (is_breakpoint): Change return type to bool.
6587         (is_watchpoint): Likewise.
6588         (is_catchpoint): Likewise.
6589         (is_tracepoint): Likewise.
6590
6591 2019-07-10  Tom Tromey  <tom@tromey.com>
6592
6593         * defs.h: Don't include gdbarch.h.
6594         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6595         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6596         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6597         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6598         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6599         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6600         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6601         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6602         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6603         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6604         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6605         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6606         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6607         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6608         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6609         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6610         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6611         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6612         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6613         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6614         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6615         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6616         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6617         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6618         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6619         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6620         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6621
6622 2019-07-10  Tom Tromey  <tromey@adacore.com>
6623
6624         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6625         * breakpoint.c (init_ada_exception_breakpoint): Register as
6626         bp_catchpoint.
6627         (print_one_breakpoint_location, print_one_breakpoint): Use
6628         is_ada_exception_catchpoint.
6629         * ada-lang.c (class ada_catchpoint_location): Pass
6630         bp_loc_software_breakpoint to bp_location constructor.
6631         (is_ada_exception_catchpoint): New function.
6632
6633 2019-07-10  Tom Tromey  <tromey@adacore.com>
6634
6635         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6636         VEC.
6637         (struct arm_exidx_entry): New method operator<.
6638         (struct arm_exidx_data) <section_maps>: Change type.
6639         (arm_exidx_data_free): Remove.
6640         (arm_exidx_data_key): Change type.  Move lower.
6641         (arm_exidx_new_objfile): Update.
6642         (arm_compare_exidx_entries): Remove.
6643         (arm_find_exidx_entry, _initialize_arm_tdep)
6644
6645 2019-07-10  Tom Tromey  <tromey@adacore.com>
6646
6647         * solib-spu.c (ocl_program_data_key): Change type.
6648         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6649         Update.
6650
6651 2019-07-10  Tom Tromey  <tromey@adacore.com>
6652
6653         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6654         (struct solib_aix_inferior_data) <library_list>: Change type.
6655         (solib_aix_inferior_data_handle): Change type.
6656         (get_solib_aix_inferior_data): Update.
6657         (solib_aix_free_library_list): Remove.
6658         (library_list_start_library): Update.
6659         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6660         return type.
6661         (solib_aix_get_library_list)
6662         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6663         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6664
6665 2019-07-10  Tom Tromey  <tromey@adacore.com>
6666
6667         * solib-dsbt.c (struct dsbt_info): Add initializers.
6668         (solib_dsbt_pspace_data): Change type.
6669         (dsbt_pspace_data_cleanup): Remove.
6670         (get_dsbt_info, _initialize_dsbt_solib): Update.
6671
6672 2019-07-10  Tom Tromey  <tromey@adacore.com>
6673
6674         * spu-tdep.c (spu_overlay_data): Change type.
6675         (spu_get_overlay_table, spu_overlay_new_objfile)
6676         (_initialize_spu_tdep): Update.
6677
6678 2019-07-10  Tom Tromey  <tromey@adacore.com>
6679
6680         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6681         destructor.
6682         (dbx_objfile_data_key): Change type and declare later.
6683         (DBX_SYMFILE_INFO): Rewrite.
6684         * dbxread.c (dbx_objfile_data_key): Change type.
6685         (dbx_symfile_init): Update.
6686         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6687         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6688         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6689
6690 2019-07-10  Tom Tromey  <tromey@adacore.com>
6691
6692         * jit.c (jit_program_space_key): Change type.  Move lower.
6693         (get_jit_program_space_data): Update.
6694         (jit_program_space_data_cleanup): Remove.
6695         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6696         Update.
6697         (struct jit_program_space_data): Add initializers.
6698
6699 2019-07-10  Tom Tromey  <tromey@adacore.com>
6700
6701         * solib-darwin.c (struct darwin_info): Add initializers.
6702         (solib_darwin_pspace_data): Change type.
6703         (darwin_pspace_data_cleanup): Remove.
6704         (get_darwin_info, _initialize_darwin_solib): Update.
6705
6706 2019-07-10  Tom Tromey  <tromey@adacore.com>
6707
6708         * remote-sim.c (struct sim_inferior_data): Add initializers,
6709         constructor, and destructor.
6710         (sim_inferior_data_key): Change type.  Move lower.
6711         (check_for_duplicate_sim_descriptor): Update.
6712         (get_sim_inferior_data): Use new.  Update.
6713         (~sim_inferior_data_cleanup): Rename from
6714         sim_inferior_data_cleanup.  Simplify.
6715         (gdbsim_close_inferior, simulator_command)
6716         (sim_command_completer, _initialize_remote_sim): Update.
6717         (next_pid, INITIAL_PID): Move earlier.
6718
6719 2019-07-10  Tom Tromey  <tromey@adacore.com>
6720
6721         * python/python-internal.h (create_thread_object): Return
6722         gdbpy_ref.
6723         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6724         * python/py-inferior.c (struct threadlist_entry): Add
6725         constructor.
6726         <thread_obj>: Now a gdbpy_ref.
6727         (thread_to_thread_object): Update.
6728         (add_thread_object): Use new.
6729         (delete_thread_object): Use delete.
6730         (infpy_threads): Update.
6731         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6732         GIL.
6733
6734 2019-07-10  Tom Tromey  <tromey@adacore.com>
6735
6736         * valops.c (value_cast): Specialize error message for Ada.
6737
6738 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6739
6740         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6741
6742 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6743
6744         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6745         bpstat_should_step): Return bool, adjust comments.
6746         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6747         bpstat_should_step): Likewise.
6748
6749 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6750
6751         * features/Makefile: Use feature target descriptions for Arm.
6752         * features/arm/arm-core.c: Generate new file.
6753         * features/arm/arm-fpa.c: Likewise.
6754         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6755         * features/arm/arm-m-profile.c: Likewise.
6756         * features/arm/arm-vfpv2.c: Likewise.
6757         * features/arm/arm-vfpv3.c: Likewise.
6758         * features/arm/xscale-iwmmxt.c: Likewise.
6759         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6760
6761 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6762
6763         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6764         ptrace earlier.
6765
6766 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6767
6768         * features/aarch64-pauth.c: Regenerate.
6769
6770 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6771
6772         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6773         bool.
6774         (bpstat_what): Use false instead of 0.
6775
6776 2019-07-09  Pedro Alves  <palves@redhat.com>
6777
6778         * break-catch-throw.c (is_exception_catchpoint): New.
6779         * breakpoint.c (print_one_breakpoint_location): New parameter
6780         'raw_loc'.  Handle it.  Use
6781         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6782         looking at the breakpoint's type.
6783         (print_one_breakpoint): If handling "maint info breakpoints", also
6784         print locations of exception catchpoints.
6785         * breakpoint.h (is_exception_catchpoint): Declare.
6786
6787 2019-07-09  Pedro Alves  <palves@redhat.com>
6788
6789         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6790         "addr" field.
6791         (allocate_location_exception_catchpoint): New.
6792         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6793         (initialize_throw_catchpoint_ops): Install
6794         allocate_location_exception_catchpoint as allocate_location
6795         method.
6796         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6797         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6798         bp_loc_other.
6799         (breakpoint_address_is_meaningful): Delete.
6800         (bl_address_is_meaningful): New.
6801         (breakpoint_locations_match): Adjust comment.
6802         (bp_location_from_bp_type): New, factored out of...
6803         (bp_location::bp_location(breakpoint *)): ... this.
6804         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6805         factored out of...
6806         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6807         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6808         breakpoint_address_is_meaningful.
6809         (bp_locations_compare): Adjust comment.
6810         (update_global_location_list): Use bl_address_is_meaningful
6811         instead of breakpoint_address_is_meaningful.
6812         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6813         explicit.
6814         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6815         * python/py-breakpoint.c (bppy_get_location): No longer check
6816         whether location is null.
6817
6818 2019-07-09  Pedro Alves  <palves@redhat.com>
6819
6820         PR c++/15468
6821         * breakpoint.c (print_one_breakpoint_location): Remove
6822         single-location assert.
6823
6824 2019-07-09  Tom Tromey  <tom@tromey.com>
6825
6826         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6827         * configure: Rebuild.
6828         * configure.ac: Change common to gdbsupport.
6829         * gdbsupport: Rename from common.
6830         * acinclude.m4: Change common to gdbsupport.
6831         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6832         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6833         gdbsupport.
6834         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6835         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6836         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6837         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6838         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6839         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6840         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6841         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6842         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6843         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6844         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6845         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6846         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6847         coff-pe-read.c, command.h, compile/compile-c-support.c,
6848         compile/compile-c.h, compile/compile-cplus-symbols.c,
6849         compile/compile-cplus-types.c, compile/compile-cplus.h,
6850         compile/compile-loc2c.c, compile/compile.c, completer.c,
6851         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6852         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6853         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6854         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6855         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6856         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6857         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6858         features/aarch64-core.c, features/aarch64-fpu.c,
6859         features/aarch64-pauth.c, features/aarch64-sve.c,
6860         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6861         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6862         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6863         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6864         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6865         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6866         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6867         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6868         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6869         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6870         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6871         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6872         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6873         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6874         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6875         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6876         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6877         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6878         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6879         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6880         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6881         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6882         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6883         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6884         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6885         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6886         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6887         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6888         minsyms.c, mips-linux-tdep.c, namespace.h,
6889         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6890         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6891         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6892         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6893         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6894         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6895         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6896         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6897         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6898         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6899         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6900         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6901         procfs.c, producer.c, progspace.h, psymtab.h,
6902         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6903         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6904         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6905         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6906         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6907         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6908         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6909         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6910         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6911         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6912         target-memory.c, target.c, target.h, target/waitstatus.c,
6913         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6914         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6915         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6916         unittests/array-view-selftests.c,
6917         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6918         unittests/common-utils-selftests.c,
6919         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6920         unittests/format_pieces-selftests.c,
6921         unittests/function-view-selftests.c,
6922         unittests/lookup_name_info-selftests.c,
6923         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6924         unittests/mkdir-recursive-selftests.c,
6925         unittests/observable-selftests.c,
6926         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6927         unittests/parse-connection-spec-selftests.c,
6928         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6929         unittests/scoped_fd-selftests.c,
6930         unittests/scoped_mmap-selftests.c,
6931         unittests/scoped_restore-selftests.c,
6932         unittests/string_view-selftests.c, unittests/style-selftests.c,
6933         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6934         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6935         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6936         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6937         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6938         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6939
6940 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6941
6942         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6943         bool value.
6944         (decode_digits_ordinary): Set explicit_line field in sal.
6945         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6946         symtab_and_line that was set on an explicit line number in
6947         assembler code.  Do always update the recorded symtab and line if
6948         we do skip the prologue.
6949
6950 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6951
6952         * breakpoint.c (set_breakpoint_location_function): Remove
6953         explicit_loc parameter.
6954         (momentary_breakpoint_from_master): Update call to
6955         set_breakpoint_location_function.
6956         (add_location_to_breakpoint): Likewise.
6957
6958 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6959
6960         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6961         required features based on default bfd type when no specific bfd
6962         is present.
6963
6964 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6965
6966         * NEWS: Mention that GDB printf and eval commands can now print
6967         C-style and Ada-style convenience var strings without
6968         calling the inferior.
6969         * printcmd.c (printf_c_string): Locally print GDB internal var
6970         instead of transiting via the inferior.
6971         (printf_wide_c_string): Likewise.
6972
6973 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6974
6975         PR breakpoints/25011
6976         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6977
6978 2019-07-04  Tom Tromey  <tom@tromey.com>
6979
6980         PR tui/24724:
6981         * tui/tui-winsource.c (tui_clear_source_content): Update.
6982         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6983         (tui_update_breakpoint_info): Update.
6984         (tui_set_exec_info_content): Update.
6985         * tui/tui-source.c (tui_set_source_content_nil): Update.
6986         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6987         has_break.
6988         * tui/tui-data.h (enum tui_bp_flag): New.
6989         (tui_bp_flags): New enum flags type.
6990         (struct tui_source_element) <break_mode>: Change type.  Rename
6991         from has_break.
6992         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6993         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6994         constants.
6995         * tui/tui-winsource.h: Fix comment.
6996
6997 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6998
6999         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7000         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7001         (store_fpregs_to_thread)
7002         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7003         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7004         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7005         (IWMMXT_REGS_SIZE): Add define.
7006         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7007         (fetch_vfp_regs, store_vfp_regs)
7008         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7009         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7010
7011 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7012
7013         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7014         defines.
7015         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7016         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7017         (ARM_INT_REGISTER_SIZE): ...to this.
7018         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7019         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7020         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7021         (arm_linux_collect_gregset, supply_nwfpe_register)
7022         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7023         defines.
7024         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7025         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7026         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7027         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7028         (arm_return_in_memory, arm_store_return_value)
7029         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7030         (arm_record_ld_st_multiple): Likewise.
7031         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7032         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7033
7034 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7035
7036         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7037         AARCH64_DISPLACED_MODIFIED_INSNS.
7038         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7039         (aarch64_displaced_step_copy_insn): Likewise.
7040         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7041         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7042         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7043         ARM_DISPLACED_MODIFIED_INSNS.
7044         * arm-tdep.c (arm_gdbarch_init): Likewise.
7045         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7046         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7047         (struct arm_displaced_step_closure): Use
7048         ARM_DISPLACED_MODIFIED_INSNS.
7049
7050 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7051
7052         * features/Makefile: Remove unused xml files.
7053         * features/aarch64.xml: Remove.
7054         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7055         * features/i386/amd64-avx-avx512.xml: Remove.
7056         * features/i386/amd64-avx-linux.xml: Remove.
7057         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7058         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7059         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7060         * features/i386/amd64-avx-mpx.xml: Remove.
7061         * features/i386/amd64-avx.xml: Remove.
7062         * features/i386/amd64-linux.xml: Remove.
7063         * features/i386/amd64-mpx-linux.xml: Remove.
7064         * features/i386/amd64-mpx.xml: Remove.
7065         * features/i386/amd64.xml: Remove.
7066         * features/i386/i386-avx-avx512-linux.xml: Remove.
7067         * features/i386/i386-avx-avx512.xml: Remove.
7068         * features/i386/i386-avx-linux.xml: Remove.
7069         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7070         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7071         * features/i386/i386-avx-mpx-linux.xml: Remove.
7072         * features/i386/i386-avx-mpx.xml: Remove.
7073         * features/i386/i386-avx.xml: Remove.
7074         * features/i386/i386-linux.xml: Remove.
7075         * features/i386/i386-mmx-linux.xml: Remove.
7076         * features/i386/i386-mmx.xml: Remove.
7077         * features/i386/i386-mpx-linux.xml: Remove.
7078         * features/i386/i386-mpx.xml: Remove.
7079         * features/i386/i386.xml: Remove.
7080         * features/i386/x32-avx-avx512-linux.xml: Remove.
7081         * features/i386/x32-avx-linux.xml: Remove.
7082         * features/i386/x32-linux.xml: Remove.
7083
7084 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7085
7086         * regformats/aarch64.dat: Remove.
7087         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7088         * regformats/i386/amd64-avx-linux.dat: Remove.
7089         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7090         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7091         * regformats/i386/amd64-linux.dat: Remove.
7092         * regformats/i386/amd64-mpx-linux.dat: Remove.
7093         * regformats/i386/amd64.dat: Remove.
7094         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7095         * regformats/i386/i386-avx-linux.dat: Remove.
7096         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7097         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7098         * regformats/i386/i386-linux.dat: Remove.
7099         * regformats/i386/i386-mmx-linux.dat: Remove.
7100         * regformats/i386/i386-mpx-linux.dat: Remove.
7101         * regformats/i386/i386.dat: Remove.
7102         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7103         * regformats/i386/x32-avx-linux.dat: Remove.
7104         * regformats/i386/x32-linux.dat: Remove.
7105
7106 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7107
7108         * aarch64-tdep.c: Remove xml self tests.
7109         * amd64-linux-tdep.c: Likewise.
7110         * amd64-tdep.c: Likewise.
7111         * i386-linux-tdep.c: Likewise.
7112         * i386-tdep.c: Likewise.
7113
7114 2019-07-03  Pedro Alves  <palves@redhat.com>
7115
7116         PR cli/24732
7117         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7118         (pipe_cmd_option_defs): New.
7119         (make_pipe_cmd_options_def_group): New.
7120         (pipe_command): Use gdb::option::process_options.
7121         (pipe_command_completer): New function.
7122         (_initialize_cli_cmds): Install completer for "pipe" command.
7123
7124 2019-07-03  Pedro Alves  <palves@redhat.com>
7125
7126         * cli/cli-option.c (union option_value) <string>: New field.
7127         (struct option_def_and_value): Add ctor, move ctor, dtor and
7128         use DISABLE_COPY_AND_ASSIGN.
7129         (option_def_and_value::clear_value): New.
7130         (parse_option, save_option_value_in_ctx, get_val_type_str)
7131         (add_setshow_cmds_for_options): Handle var_string.
7132         * cli-option.h (union option_def::var_address) <string>: New
7133         field.
7134         (struct string_option_def): New.
7135         * maint-test-options.c (struct test_options_opts): Add default
7136         ctor and use DISABLE_COPY_AND_ASSIGN.
7137         <string_opt>: New field.
7138         (test_options_opts::~test_options_opts): New.
7139         (test_options_opts::dump): Also dump "-string".
7140         (test_options_option_defs): Install "string.
7141
7142 2019-07-03  Pedro Alves  <palves@redhat.com>
7143
7144         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7145         option_value with a null enumeration.
7146         (complete_options): Save the option values in the context.
7147         (save_option_value_in_ctx): New, factored out from ...
7148         (process_options): ... here.
7149         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7150         of the function.
7151         * maint-test-options.c (test_options_opts::dump): New, factored
7152         out from ...
7153         (maintenance_test_options_command_mode): ... here.
7154         (maintenance_test_options_command_completion_result): Delete.
7155         (maintenance_test_options_command_completion_text): Update
7156         comment.
7157         (maintenance_show_test_options_completion_result): Change
7158         prototype.  Just print
7159         maintenance_test_options_command_completion_text.
7160         (save_completion_result): New.
7161         (maintenance_test_options_completer_mode): Pass options context to
7162         complete_options, and then save a dump.
7163         (_initialize_maint_test_options): Use add_cmd to install "maint
7164         show test-options-completion-result".
7165
7166 2019-07-03  Pedro Alves  <palves@redhat.com>
7167
7168         * NEWS (New commands): Mention "with" and "maint with".
7169         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7170         (with_command, with_command_completer): New.
7171         (pipe_command): Adjust to new repeat_previous
7172         interface.
7173         (_initialize_cli_cmds): Install the "with" command and its "w"
7174         alias.
7175         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7176         declarations.
7177         * cli/cli-setshow.c (parse_cli_var_uinteger)
7178         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7179         argument strings for all var_types.
7180         (get_setshow_command_value_string): New, factored out from ...
7181         (do_show_command): ... this.
7182         * cli/cli-setshow.h: Include <string>.
7183         (get_setshow_command_value_string): Declare.
7184         * command.h (repeat_previous): Now returns const char *.  Adjust
7185         comment.
7186         * maint.c: Include "cli/cli-cmds.h".
7187         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7188         (_initialize_maint_cmds): Register the "maintenance with" command.
7189         * top.c (repeat_previous): Move bits from pipe_command here:
7190         Return the saved command line, if any; error out if there's no
7191         command to relaunch.
7192
7193 2019-07-03  Pedro Alves  <palves@redhat.com>
7194
7195         * NEWS (New commands): Mention "maint set/show test-settings"
7196         instead of "maint test-settings".
7197         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7198         (maintenance_test_settings_set_list): Rename to ...
7199         (maintenance_set_test_settings_list): ... this.
7200         (maintenance_test_settings_show_list): Rename to  ...
7201         (maintenance_show_test_settings_list): ... this.
7202         (maintenance_test_settings_cmd): Delete.
7203         (maintenance_test_settings_set_cmd): ...
7204         (maintenance_set_test_settings_cmd): ... this.
7205         (maintenance_test_settings_show_cmd): ...
7206         (maintenance_show_test_settings_cmd): ... this.
7207         (maintenance_test_settings_show_value_cmd):
7208         (maintenance_show_test_settings_value_cmd): ... this.
7209         (_initialize_maint_test_settings): No longer install the "maint
7210         test-settings" prefix command.  Rename "maint test-settings set"
7211         to "maint set test-settings", and "maint test-settings show" to
7212         "maint show test-settings".  Adjust all subcommands.
7213
7214 2019-07-03  Pedro Alves  <palves@redhat.com>
7215
7216         * maint-test-settings.c: Fix file's intro comment.  Replace all
7217         references to "test-options" with references to "test-settings",
7218         in comments.
7219
7220 2019-07-03  Pedro Alves  <palves@redhat.com>
7221
7222         * maint-test-settings.c (maintenance_test_settings_xxx)
7223         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7224         New.
7225         (maintenance_test_settings_enums): Use them.
7226         (maintenance_test_settings_enum): Default to
7227         maintenance_test_settings_xxx.
7228         (_initialize_maint_test_settings): Initialize
7229         MAINTENANCE_TEST_SETTINGS_FILENAME.
7230
7231 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7232
7233         * breakpoint.h (remove_breakpoints_inf): Change return type to
7234         void, move function documentation here.
7235         * breakpoint.c (remove_breakpoints_inf): Change return type to
7236         void, move function documentation to header.
7237
7238 2019-07-02  Pedro Alves  <palves@redhat.com>
7239
7240         * NEWS (Completion improvements): Mention "info threads".
7241         * thread.c (struct info_threads_opts, info_threads_option_defs)
7242         (make_info_threads_options_def_group): New.
7243         (info_threads_command): Use gdb::option::process_options.
7244         (info_threads_command_completer): New.
7245         (_initialize_thread): Use gdb::option::build_help to build the
7246         help text for "info threads".
7247
7248 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7249
7250         * defs.h (generic_load): Move from here...
7251         * symfile.h (generic_load): ... to here.  Rename name parameter
7252         to args.
7253         * symfile.c (generic_load): Add comment.
7254
7255 2019-07-01  Tom Tromey  <tromey@adacore.com>
7256
7257         * dwarf2read.c
7258         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7259         declaration of without_params.  Fix formatting.
7260
7261 2019-07-01  Tom Tromey  <tromey@adacore.com>
7262
7263         * ada-exp.y (find_primitive_type): Update.
7264         * ada-lang.h (ada_lookup_symbol): Update.
7265         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7266         parameter.
7267         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7268
7269 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7270
7271         PR breakpoints/24541
7272         * gdbarch.c: Regenerate.
7273         * gdbarch.h: Regenerate.
7274         * gdbarch.sh: Add 'stap_adjust_register'.
7275         * i386-tdep.c: Include '<unordered_set>'.
7276         (i386_stap_adjust_register): New function.
7277         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7278         * stap-probe.c (stap_parse_register_operand): Call
7279         'gdbarch_stap_adjust_register'.
7280
7281 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7282
7283         PR python/24742
7284         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7285         * python/python.c (do_start_initialization): Use 'xmalloc'
7286         instead of 'PyMem_Malloc'.
7287
7288 2019-06-28  Tom Tromey  <tromey@adacore.com>
7289
7290         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7291         for Ada.
7292
7293 2019-06-27  Tom Tromey  <tromey@adacore.com>
7294
7295         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7296         objfile_key.
7297         (arm_find_mapping_symbol, arm_record_special_symbol)
7298         (_initialize_arm_tdep): Update.
7299         (arm_objfile_data_free): Remove.
7300
7301 2019-06-27  Tom Tromey  <tromey@adacore.com>
7302
7303         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7304         to cp_print_static_field.
7305
7306 2019-06-26  Tom Tromey  <tromey@adacore.com>
7307
7308         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7309         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7310         declare.
7311
7312 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7313
7314         * features/aarch64-core.c (create_feature_aarch64_core):
7315         Regenerate.
7316         * features/aarch64-core.xml: Add cpsr flags.
7317
7318 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7319
7320         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7321         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7322
7323 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7324
7325         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7326         field.
7327         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7328         use.
7329         (arm_record_special_symbol): Don't insert new symbol in sorted
7330         position, push it at the end.
7331
7332 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7333
7334         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7335         (arm_mapping_symbol_s): Remove.
7336         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7337         (arm_mapping_symbol_vec): New typedef.
7338         (struct arm_per_objfile): Add constructor.
7339         <section_maps>: Change type to
7340         std::unique_ptr<arm_mapping_symbol_vec[]>.
7341         (arm_compare_mapping_symbols): Remove.
7342         (arm_find_mapping_symbol): Adjust to section_maps type change.
7343         (arm_objfile_data_free): Call delete on arm_per_objfile.
7344         (arm_record_special_symbol): Adjust to section_maps type change.
7345         Allocate arm_per_objfile with new.
7346
7347 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7348
7349         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7350         with the command prefix.
7351
7352 2019-06-25  Tom Tromey  <tom@tromey.com>
7353
7354         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7355         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7356
7357 2019-06-25  Tom Tromey  <tom@tromey.com>
7358
7359         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7360         type.
7361         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7362         protected.
7363
7364 2019-06-25  Tom Tromey  <tom@tromey.com>
7365
7366         * tui/tui-winsource.c
7367         (tui_source_window_base::set_is_exec_point_at): Add check against
7368         LOA_ADDRESS.
7369
7370 2019-06-25  Tom Tromey  <tom@tromey.com>
7371
7372         * tui/tui-source.c (tui_set_source_content): Don't check before
7373         xfree.
7374         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7375
7376 2019-06-25  Tom Tromey  <tom@tromey.com>
7377
7378         * tui/tui-winsource.h (tui_update_source_window_as_is)
7379         (tui_alloc_source_buffer, tui_line_is_displayed)
7380         (tui_addr_is_displayed): Change type of win_info.
7381         * tui/tui-winsource.c (tui_update_source_window_as_is)
7382         (tui_clear_source_content, tui_show_source_line)
7383         (tui_show_source_content, tui_source_window_base::refill)
7384         (tui_source_window_base::set_is_exec_point_at)
7385         (tui_source_window_base::set_is_exec_point_at)
7386         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7387         (tui_alloc_source_buffer, tui_line_is_displayed)
7388         (tui_addr_is_displayed): Change type of win_info.  Update.
7389         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7390         (tui_source_window_base::do_make_visible_with_new_height):
7391         Update.
7392         * tui/tui-source.c (tui_set_source_content)
7393         (tui_set_source_content_nil)
7394         (tui_source_window::do_scroll_vertical): Update.
7395         * tui/tui-layout.c (show_layout): Update.
7396         * tui/tui-disasm.c (tui_set_disassem_content)
7397         (tui_disasm_window::do_scroll_vertical): Update.
7398         * tui/tui-data.h (tui_win_content): Remove.
7399         (struct tui_gen_win_info) <content, content_size>: Remove.
7400         (struct tui_source_element): Add initializers and destructor.
7401         (union tui_which_element, struct tui_win_element): Remove.
7402         (struct tui_source_window_base) <content>: New field.
7403         (struct tui_data_window): Remove destructor.
7404         (tui_alloc_content, tui_free_win_content)
7405         (tui_free_all_source_wins_content): Don't declare.
7406         * tui/tui-data.c (tui_initialize_static_data): Update.
7407         (init_content_element, tui_alloc_content): Remove.
7408         (~tui_gen_win_info): Update.
7409         (~tui_data_window, tui_free_all_source_wins_content)
7410         (tui_free_win_content, free_content, free_content_elements):
7411         Remove.
7412
7413 2019-06-25  Tom Tromey  <tom@tromey.com>
7414
7415         * tui/tui-winsource.h (tui_clear_source_content)
7416         (tui_erase_source_content, tui_show_source_content): Change type
7417         of win_info.
7418         * tui/tui-winsource.c (tui_clear_source_content)
7419         (tui_erase_source_content, tui_show_source_content): Change type
7420         of win_info.
7421         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7422         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7423         win_info.
7424         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7425         win_info.
7426         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7427
7428 2019-06-25  Tom Tromey  <tom@tromey.com>
7429
7430         * tui/tui-winsource.c (tui_clear_source_content)
7431         (tui_source_window_base::set_is_exec_point_at): Update.
7432         * tui/tui-source.c (tui_set_source_content_nil): Update.
7433         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7434         a bool.
7435         * tui/tui-data.c (init_content_element): Update.
7436
7437 2019-06-25  Tom Tromey  <tom@tromey.com>
7438
7439         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7440         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7441         * tui/tui-layout.c (init_and_make_win): Update.
7442         * tui/tui.h (enum tui_win_type): Update.
7443         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7444         tui_win_is_auxillary.
7445         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7446         tui_win_is_auxillary.
7447
7448 2019-06-25  Tom Tromey  <tom@tromey.com>
7449
7450         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7451         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7452         (tui_delete_data_content_windows, tui_display_all_data)
7453         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7454         Update.
7455         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7456         * tui/tui-regs.c (tui_last_regs_line_no)
7457         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7458         (tui_show_registers): Update.
7459         (tui_show_register_group): Return void.  Update.
7460         (tui_display_registers_from, tui_display_reg_element_at_line)
7461         (tui_display_registers_from_line, tui_check_register_values):
7462         Update.
7463         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7464         member.
7465         (struct tui_data_window) <regs_content>: Now a std::vector.
7466         <regs_content_count>: Remove.
7467         (tui_add_content_elements, tui_free_data_content): Don't declare.
7468         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7469         (init_content_element): Remove DATA_WIN case.  Add assert.
7470         (tui_add_content_elements): Remove.
7471         (tui_data_window): Update.
7472         (tui_free_data_content): Remove.
7473         (free_content_elements): Remove DATA_WIN case.
7474
7475 2019-06-25  Tom Tromey  <tom@tromey.com>
7476
7477         * tui/tui-data.c (tui_data_item_window): Update.
7478         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7479         * tui/tui-windata.c (tui_display_all_data)
7480         (tui_display_data_from_line): Update.
7481         (tui_check_data_values): Remove.
7482         * tui/tui-regs.c (tui_show_register_group)
7483         (tui_display_reg_element_at_line): Update.
7484         * tui/tui-hooks.c (tui_register_changed)
7485         (tui_refresh_frame_and_register_information): Call
7486         tui_check_register_values.
7487         * tui/tui-data.h (struct tui_data_window) <data_content,
7488         data_content_count, data_type>: Remove.
7489         (enum tui_data_type): Remove.
7490
7491         * tui/tui-data.c (tui_data_window::clear_detail)
7492         (~tui_data_window): Update.
7493
7494 2019-06-25  Tom Tromey  <tom@tromey.com>
7495
7496         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7497         declare.
7498         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7499         Rename from tui_first_data_item_displayed.  Update.
7500         (tui_data_window::refresh_all)
7501         (tui_data_window::do_scroll_vertical): Update.
7502         * tui/tui-data.h (struct tui_data_window)
7503         <first_data_item_displayed>: Declare new method.
7504
7505 2019-06-25  Tom Tromey  <tom@tromey.com>
7506
7507         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7508         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7509         contents...
7510         (tui_initialize_static_data): ...here.
7511
7512 2019-06-25  Tom Tromey  <tom@tromey.com>
7513
7514         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7515         (tui_display_registers_from, tui_check_register_values): Update.
7516         (tui_display_register): Remove win_info parameter; update.
7517         (tui_get_register): Change type of parameters.
7518         * tui/tui-data.h (struct tui_data_element): Remove.
7519         (union tui_which_element) <data>: Remove.
7520         <data_window>: Change type.
7521         (struct tui_data_item_window): New.
7522         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7523         case.  Add assert.
7524         (~tui_data_item_window): New destructor.
7525         (free_content_elements): Remove DATA_ITEM_WIN case.
7526
7527 2019-06-25  Tom Tromey  <tom@tromey.com>
7528
7529         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7530         Remove.
7531
7532 2019-06-25  Tom Tromey  <tom@tromey.com>
7533
7534         * tui/tui-data.h (struct tui_command_element): Remove.
7535         (union tui_which_element) <command>: Remove.
7536         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7537         assert.
7538         (free_content_elements): Remove CMD_WIN case.
7539
7540 2019-06-25  Tom Tromey  <tom@tromey.com>
7541
7542         * tui/tui-layout.c (tui_set_layout): Update.
7543         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7544         * tui/tui-data.c (layout_def): Update.
7545
7546 2019-06-25  Tom Tromey  <tom@tromey.com>
7547
7548         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7549         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7550         (tui_source_window_base::set_new_height): Update.
7551         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7552         Update.
7553         (tui_set_locator_fullname, tui_set_locator_info)
7554         (tui_show_frame_info): Update.
7555         * tui/tui-source.c (tui_set_source_content)
7556         (tui_source_is_displayed): Update.
7557         * tui/tui-layout.c (show_source_disasm_command, show_data)
7558         (show_source_or_disasm_and_command): Update.
7559         * tui/tui-disasm.c (tui_set_disassem_content)
7560         (tui_get_begin_asm_address): Update.
7561         * tui/tui-data.h (struct tui_locator_element): Remove.
7562         (union tui_which_element) <locator>: Remove.
7563         (struct tui_locator_window): New.
7564         (tui_locator_win_info_ptr): Change return type.
7565         * tui/tui-data.c (_locator): Change type.
7566         (tui_locator_win_info_ptr): Change return type.
7567         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7568         (tui_alloc_content): Add assert.
7569
7570 2019-06-25  Tom Tromey  <tom@tromey.com>
7571
7572         * tui/tui-winsource.c
7573         (tui_exec_info_window::maybe_allocate_content): New method.
7574         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7575         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7576         (make_source_or_disasm_window): Add cast.
7577         * tui/tui-data.h (union tui_which_element) <simple_string>:
7578         Remove.
7579         (struct tui_source_info): New.
7580         (struct tui_source_window_base) <execution_info>: Change type.
7581         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7582         case, and add assert.
7583         (tui_alloc_content): Add assert.
7584
7585 2019-06-25  Tom Tromey  <tom@tromey.com>
7586
7587         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7588         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7589         * tui/tui-data.c (tui_alloc_win_info): Remove.
7590
7591 2019-06-25  Tom Tromey  <tom@tromey.com>
7592
7593         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7594         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7595         can_highlight.
7596
7597 2019-06-25  Tom Tromey  <tom@tromey.com>
7598
7599         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7600         make_visible_with_new_height method.
7601         (tui_win_info::make_visible_with_new_height): New method.
7602         (tui_source_window_base::do_make_visible_with_new_height)
7603         (tui_data_window::do_make_visible_with_new_height)
7604         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7605         (make_visible_with_new_height): Remove.
7606         (tui_resize_all, tui_adjust_win_heights): Use
7607         make_visible_with_new_height method.
7608         * tui/tui-data.h (struct tui_win_info)
7609         <do_make_visible_with_new_height, make_visible_with_new_height>:
7610         New methods.
7611         (struct tui_source_window_base, struct tui_data_window)
7612         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7613         methods.
7614
7615 2019-06-25  Tom Tromey  <tom@tromey.com>
7616
7617         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7618         method.
7619         (update_tab_width): Call update_tab_width method.
7620         * tui/tui-data.h (struct tui_win_info)
7621         (struct tui_source_window_base) <update_tab_width>: New methods.
7622
7623 2019-06-25  Tom Tromey  <tom@tromey.com>
7624
7625         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7626         parameter.
7627         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7628         parameter.
7629         (tui_gen_win_info::make_visible): Update.
7630         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7631         parameter.
7632         * tui/tui-data.h (enum tui_box): New enum.
7633         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7634
7635 2019-06-25  Tom Tromey  <tom@tromey.com>
7636
7637         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7638         init_and_make_win for EXEC_INFO_WIN.
7639         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7640         longer inline.
7641         (struct tui_win_info) <~tui_win_info>: Inline.
7642         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7643         Don't declare.
7644         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7645         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7646         Remove.
7647         (tui_initialize_static_data): Update.
7648         (~tui_gen_win_info): Handle more cleanup here.
7649         (~tui_source_window_base): Delete "execution_info".
7650         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7651
7652 2019-06-25  Tom Tromey  <tom@tromey.com>
7653
7654         * tui/tui-layout.c (make_command_window): Don't set
7655         can_highlight.
7656         (show_source_disasm_command): Call the reset method.
7657         (show_data): Don't set can_highlight.  Call the reset method.
7658         (tui_gen_win_info::reset): Rename from init_gen_win_info
7659         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7660         (show_source_or_disasm_and_command): Call the reset method.
7661         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7662         (struct tui_cmd_window): Set can_highlight.
7663
7664 2019-06-25  Tom Tromey  <tom@tromey.com>
7665
7666         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7667         from make_visible.
7668         (tui_make_visible, tui_make_invisible): Rewrite.
7669         (tui_win_info::make_visible): Remove.
7670         (tui_source_window_base::make_visible): Update.
7671         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7672         method.  Moved from...
7673         (struct tui_win_info) <make_visible>: ...here.
7674
7675 2019-06-25  Tom Tromey  <tom@tromey.com>
7676
7677         * tui/tui-winsource.c
7678         (tui_source_window_base::do_scroll_horizontal): Remove direction
7679         parameter.
7680         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7681         direction parameter.
7682         * tui/tui-win.c (tui_win_info::forward_scroll)
7683         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7684         (tui_win_info::right_scroll): Update.
7685         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7686         direction parameter.
7687         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7688         direction parameter.
7689         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7690         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7691         Remove direction parameter.
7692         (struct tui_source_window_base, struct tui_source_window)
7693         (struct tui_disasm_window, struct tui_data_window)
7694         (struct tui_cmd_window): Update.
7695
7696 2019-06-25  Tom Tromey  <tom@tromey.com>
7697
7698         * tui/tui-winsource.h (tui_set_exec_info_content)
7699         (tui_show_exec_info_content, tui_erase_exec_info_content)
7700         (tui_clear_exec_info_content, tui_update_exec_info): Change
7701         argument to tui_source_window_base.
7702         * tui/tui-winsource.c (tui_set_exec_info_content)
7703         (tui_show_exec_info_content, tui_erase_exec_info_content)
7704         (tui_clear_exec_info_content, tui_update_exec_info): Change
7705         argument to tui_source_window_base.
7706
7707 2019-06-25  Tom Tromey  <tom@tromey.com>
7708
7709         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7710         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7711
7712 2019-06-25  Tom Tromey  <tom@tromey.com>
7713
7714         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7715         check.
7716
7717 2019-06-25  Tom Tromey  <tom@tromey.com>
7718
7719         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7720         type to void.
7721         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7722         type to void.
7723         * tui/tui-source.c (tui_set_source_content): Update.
7724         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7725
7726 2019-06-25  Tom Tromey  <tom@tromey.com>
7727
7728         * tui/tui-win.c (window_name_completer, tui_set_focus)
7729         (tui_all_windows_info): Use name method.
7730         * tui/tui-data.h (struct tui_gen_win_info)
7731         (struct tui_source_window, struct tui_disasm_window)
7732         (struct tui_data_window, struct tui_cmd_window) <name>: New
7733         method.
7734         (tui_win_name): Don't declare.
7735         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7736         (tui_win_name): Remove.
7737
7738 2019-06-25  Tom Tromey  <tom@tromey.com>
7739
7740         * tui/tui-winsource.h (tui_update_source_window)
7741         (tui_update_source_window_as_is): Change parameter type.
7742         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7743         to be a tui_source_window_base.
7744         (tui_update_source_window_as_is): Likewise.
7745         * tui/tui-win.c (make_visible_with_new_height): Update.
7746
7747 2019-06-25  Tom Tromey  <tom@tromey.com>
7748
7749         * tui/tui-winsource.c (tui_erase_source_content)
7750         (tui_show_source_content, tui_show_exec_info_content)
7751         (tui_erase_exec_info_content): Use refresh_window method.
7752         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7753         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7754         from tui_refresh_win.
7755         (tui_data_window::refresh_window): New method.
7756         (tui_win_info::refresh, tui_source_window_base::refresh)
7757         (tui_refresh_all): Use refresh_window method.
7758         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7759         method.
7760         * tui/tui-regs.c (tui_display_register): Call refresh_window
7761         method.
7762         * tui/tui-layout.c (show_source_disasm_command)
7763         (show_source_or_disasm_and_command): Call refresh_window method.
7764         * tui/tui-data.h (struct tui_gen_win_info)
7765         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7766         New method.
7767
7768 2019-06-25  Tom Tromey  <tom@tromey.com>
7769
7770         * tui/tui.c (tui_rl_other_window, tui_enable)
7771         (tui_is_window_visible, tui_get_command_dimension): Update.
7772         * tui/tui-winsource.c (tui_update_source_window_as_is)
7773         (tui_clear_source_content, tui_erase_source_content)
7774         (tui_show_source_line, tui_source_window_base::refill)
7775         (tui_source_window_base::do_scroll_horizontal)
7776         (tui_source_window_base::set_is_exec_point_at)
7777         (tui_update_breakpoint_info, tui_set_exec_info_content)
7778         (tui_alloc_source_buffer, tui_line_is_displayed)
7779         (tui_addr_is_displayed): Update.
7780         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7781         (tui_check_and_display_highlight_if_needed)
7782         (tui_win_info::make_visible, tui_win_info::refresh)
7783         (tui_refresh_all): Update.
7784         * tui/tui-windata.c (tui_first_data_item_displayed)
7785         (tui_delete_data_content_windows, tui_erase_data_content)
7786         (tui_display_all_data, tui_data_window::refresh_all)
7787         (tui_check_data_values): Update.
7788         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7789         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7790         (tui_win_info::backward_scroll, tui_refresh_all_win)
7791         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7792         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7793         (tui_source_window_base::set_new_height)
7794         (tui_data_window::set_new_height)
7795         (make_invisible_and_set_new_height)
7796         (make_visible_with_new_height, new_height_ok)
7797         (parse_scrolling_args): Update.
7798         * tui/tui-stack.c (tui_show_frame_info): Update.
7799         * tui/tui-source.c (tui_set_source_content)
7800         (tui_set_source_content_nil, tui_source_is_displayed)
7801         (tui_source_window::do_scroll_vertical): Update.
7802         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7803         (tui_display_registers_from, tui_display_reg_element_at_line)
7804         (tui_check_register_values, tui_reg_command): Update.
7805         * tui/tui-layout.c (tui_default_win_height)
7806         (show_source_disasm_command, show_data, init_and_make_win)
7807         (show_source_or_disasm_and_command): Update.
7808         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7809         (tui_redisplay_readline, tui_mld_flush)
7810         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7811         (tui_getc): Update.
7812         * tui/tui-disasm.c (tui_set_disassem_content)
7813         (tui_disasm_window::do_scroll_vertical): Update.
7814         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7815         Now virtual.
7816         (struct tui_win_info): Derive from tui_gen_win_info.
7817         <~tui_win_info>: Mark as override.
7818         <generic>: Remove member.
7819         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7820         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7821         (~tui_data_window, ~tui_win_info)
7822         (tui_free_all_source_wins_content): Update.
7823         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7824
7825 2019-06-25  Tom Tromey  <tom@tromey.com>
7826
7827         * tui/tui-layout.c (init_and_make_win): Use new.
7828         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7829         destructor, initializers.
7830         (tui_alloc_generic_win_info): Don't declare.
7831         * tui/tui-data.c (_locator): Add argument to constructor.
7832         (source_win, disasm_win): New globals.
7833         (exec_info): Remove.
7834         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7835         Update.
7836         (tui_alloc_generic_win_info): Remove.
7837         (init_content_element): Use new.
7838         (tui_win_info::tui_win_info): Update.
7839         (free_content_elements) <case DATA_WIN>: Use delete.
7840
7841 2019-06-25  Tom Tromey  <tom@tromey.com>
7842
7843         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7844         * tui/tui-windata.c (tui_first_data_item_displayed)
7845         (tui_delete_data_content_windows): Update.
7846         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7847         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7848         (tui_display_registers_from, tui_check_register_values): Update.
7849         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7850         pointer.
7851         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7852         window.
7853         (tui_free_data_content): Update.
7854         (free_content_elements) <case DATA_WIN>: Free the window.
7855
7856 2019-06-25  Tom Tromey  <tom@tromey.com>
7857
7858         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7859         Update.
7860         * tui/tui-layout.c (make_command_window)
7861         (show_source_disasm_command, show_data, init_and_make_win)
7862         (show_source_or_disasm_and_command): Update.
7863         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7864         method.
7865         <can_highight, is_highlighted>: Now bool.
7866         (tui_set_win_highlight): Don't declare.
7867         * tui/tui-data.c (tui_set_win_highlight): Remove.
7868
7869 2019-06-25  Tom Tromey  <tom@tromey.com>
7870
7871         * tui/tui-wingeneral.c (make_visible): Remove check of window
7872         type.
7873
7874 2019-06-25  Tom Tromey  <tom@tromey.com>
7875
7876         * tui/tui-win.c (tui_win_info::max_height)
7877         (tui_cmd_window::max_height): New methods.
7878         (new_height_ok): Call max_height.
7879         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7880         <max_height>: New method.
7881
7882 2019-06-25  Tom Tromey  <tom@tromey.com>
7883
7884         * tui/tui-win.c (tui_source_window_base::set_new_height)
7885         (tui_data_window::set_new_height): New methods.
7886         (make_invisible_and_set_new_height): Call set_new_height method.
7887         * tui/tui-data.h (struct tui_win_info)
7888         (struct tui_source_window_base, struct tui_data_window)
7889         <set_new_height>: New method.
7890
7891 2019-06-25  Tom Tromey  <tom@tromey.com>
7892
7893         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7894         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7895         tui_refresh_data_win.
7896         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7897         method.
7898         (tui_refresh_all_win): Call the refresh_all method.
7899         (tui_set_focus): Likewise.
7900         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7901         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7902         Likewise.
7903
7904 2019-06-25  Tom Tromey  <tom@tromey.com>
7905
7906         * tui/tui-winsource.h (tui_refill_source_window)
7907         (tui_set_is_exec_point_at): Don't declare.
7908         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7909         (tui_source_window_base::refill): Rename from
7910         tui_refill_source_window.
7911         (tui_source_window_base::do_scroll_horizontal): Update.
7912         (tui_source_window_base::set_is_exec_point_at): Rename from
7913         tui_set_is_exec_point_at.
7914         (tui_update_all_breakpoint_info): Update.
7915         * tui/tui-stack.c (tui_show_frame_info): Update.
7916         * tui/tui-layout.c (show_data): Add cast.
7917         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7918         * tui/tui-data.h (struct tui_source_window_base) <refill,
7919         set_is_exec_point_at>: New methods.
7920         (tui_source_windows, tui_add_to_source_windows): Update types.
7921         (tui_add_to_source_windows): Remove redundant declaration.
7922         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7923         (tui_source_windows): Change return type.
7924         (tui_clear_source_windows_detail): Update.
7925         (tui_add_to_source_windows): Change type of parameter.
7926         (tui_free_all_source_wins_content): Update.
7927
7928 2019-06-25  Tom Tromey  <tom@tromey.com>
7929
7930         * tui/tui-wingeneral.c (tui_win_info::refresh)
7931         (tui_source_window_base::refresh): New methods.
7932         (tui_refresh_all): Call the refresh method.
7933         * tui/tui-data.h (struct tui_win_info)
7934         (struct tui_source_window_base) <refresh>: New method.
7935
7936 2019-06-25  Tom Tromey  <tom@tromey.com>
7937
7938         * tui/tui.h (tui_is_window_visible): Return bool.
7939         * tui/tui.c (tui_is_window_visible): Return bool.
7940         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7941         (tui_make_visible, tui_make_invisible)
7942         (tui_win_info::make_visible)
7943         (tui_source_window_base::make_visible, make_all_visible)
7944         (tui_make_all_visible, tui_make_all_invisible): Update.
7945         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7946         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7947         bool.
7948         (struct tui_win_info, struct tui_source_window_base)
7949         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7950         * tui/tui-data.c (tui_init_generic_part): Update.
7951
7952 2019-06-25  Tom Tromey  <tom@tromey.com>
7953
7954         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7955         (tui_source_window_base::make_visible): New methods.
7956         (make_all_visible): Make method call.
7957         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7958         (struct tui_source_window_base, struct tui_cmd_window): Override
7959         make_visible.
7960         (tui_win_is_source_type): Don't declare.
7961         * tui/tui-data.c (tui_win_is_source_type): Remove.
7962
7963 2019-06-25  Tom Tromey  <tom@tromey.com>
7964
7965         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7966         NULL check.
7967
7968 2019-06-25  Tom Tromey  <tom@tromey.com>
7969
7970         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7971         Inline constructor.  Add initializers for members.
7972         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7973         constructors; now inline in class.
7974
7975 2019-06-25  Tom Tromey  <tom@tromey.com>
7976
7977         * tui/tui-regs.c (tui_show_registers): Update.
7978         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7979         bool.
7980         * tui/tui-data.c (tui_data_window::clear_detail)
7981         (tui_data_window): Update.
7982
7983 2019-06-25  Tom Tromey  <tom@tromey.com>
7984
7985         * tui/tui-windata.c (tui_display_all_data)
7986         (tui_display_data_from_line, tui_display_data_from)
7987         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7988         Update.
7989         * tui/tui-regs.c (tui_last_regs_line_no)
7990         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7991         (tui_show_registers, tui_show_register_group)
7992         (tui_display_registers_from, tui_display_reg_element_at_line)
7993         (tui_display_registers_from_line, tui_check_register_values)
7994         (tui_reg_next, tui_reg_prev): Update.
7995         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7996         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7997         tui_data_window.
7998         (struct tui_win_info) <detail>: Remove.  Add new fields from
7999         tui_data_info.
8000         (TUI_DATA_WIN): Add cast.
8001         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8002         (~tui_data_window): Simplify.
8003
8004 2019-06-25  Tom Tromey  <tom@tromey.com>
8005
8006         * tui/tui-layout.c (show_source_disasm_command)
8007         (show_source_or_disasm_and_command): Update.
8008         * tui/tui-io.c (update_cmdwin_start_line)
8009         (tui_redisplay_readline): Update.
8010         * tui/tui-data.h (struct tui_command_info): Remove.
8011         (struct tui_win_info) <detail>: Remove command_info member.
8012         (struct tui_data_window) <start_line>: New member, from
8013         tui_command_info.
8014         (TUI_CMD_WIN): Add casts.
8015
8016 2019-06-25  Tom Tromey  <tom@tromey.com>
8017
8018         * tui/tui-winsource.c (tui_update_source_window)
8019         (tui_refill_source_window)
8020         (tui_source_window_base::do_scroll_horizontal)
8021         (tui_update_breakpoint_info, tui_set_exec_info_content)
8022         (tui_show_exec_info_content, tui_erase_exec_info_content)
8023         (tui_clear_exec_info_content): Update.
8024         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8025         Update.
8026         * tui/tui-win.c (make_invisible_and_set_new_height)
8027         (make_visible_with_new_height): Update.
8028         * tui/tui-source.c (tui_set_source_content)
8029         (tui_show_symtab_source): Update.
8030         * tui/tui-layout.c (extract_display_start_addr)
8031         (show_source_disasm_command, show_data)
8032         (make_source_or_disasm_window)
8033         (show_source_or_disasm_and_command): Update.
8034         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8035         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8036         "gdbarch".
8037         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8038         to tui_source_window_base.
8039         (struct tui_win_info) <detail>: Remove source_info member.
8040         (struct tui_source_window_base) <has_locator>: Inline.
8041         Move contents from tui_source_info; rename has_locator member to
8042         m_has_locator.
8043         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8044         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8045         header file.
8046         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8047         Simplify.
8048         (tui_free_all_source_wins_content): Cast to
8049         tui_source_window_base.
8050
8051 2019-06-25  Tom Tromey  <tom@tromey.com>
8052
8053         * tui/tui-win.c (make_invisible_and_set_new_height)
8054         (make_visible_with_new_height): Call has_locator method.
8055         * tui/tui-layout.c (show_source_disasm_command, show_data)
8056         (show_source_or_disasm_and_command): Update for bool change.
8057         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8058         (tui_win_info) <has_locator>: New method.
8059         (struct tui_source_window_base) <has_locator>: New method.
8060         (tui_win_has_locator): Don't declare.
8061         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8062         from tui_win_has_locator.
8063         (tui_source_window_base): Use false, not FALSE.
8064
8065 2019-06-25  Tom Tromey  <tom@tromey.com>
8066
8067         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8068         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8069         clear_detail method directly.
8070         (tui_clear_win_detail): Remove.
8071
8072 2019-06-25  Tom Tromey  <tom@tromey.com>
8073
8074         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8075         "this", not TUI_DISASM_WIN.
8076
8077 2019-06-25  Tom Tromey  <tom@tromey.com>
8078
8079         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8080         declare.
8081         * tui/tui-winsource.c
8082         (tui_source_window_base::do_scroll_horizontal): Rename from
8083         tui_horizontal_source_scroll.
8084         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8085         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8086         from tui_vertical_data_scroll.
8087         * tui/tui-win.h (tui_scroll): Don't declare.
8088         * tui/tui-win.c (tui_win_info::forward_scroll)
8089         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8090         (tui_win_info::right_scroll): Rename and update.
8091         (tui_scroll_forward_command, tui_scroll_backward_command)
8092         (tui_scroll_left_command, tui_scroll_right_command): Update.
8093         (tui_scroll): Remove.
8094         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8095         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8096         from tui_vertical_source_scroll.
8097         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8098         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8099         from tui_vertical_disassem_scroll.
8100         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8101         do_scroll_horizontal>: New methods.
8102         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8103         Likewise.
8104         (struct tui_source_window_base): Add do_scroll_horizontal.
8105         (struct tui_source_window, struct tui_disasm_window): Add
8106         do_scroll_vertical.
8107         (struct tui_data_window, struct tui_cmd_window): Add
8108         do_scroll_horizontal and do_scroll_vertical.
8109         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8110
8111 2019-06-25  Tom Tromey  <tom@tromey.com>
8112
8113         * tui/tui-data.h (struct tui_source_window_base): New struct.
8114         (struct tui_source_window): Derive from tui_source_window_base.
8115         (struct tui_disasm_window): New struct.
8116         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8117         from tui_source_window::clear_detail.
8118         (tui_source_window_base): Rename from tui_source_window.
8119         (~tui_source_window_base): Rename from ~tui_source_window.
8120         (tui_alloc_win_info): Create a tui_disasm_window.
8121
8122 2019-06-25  Tom Tromey  <tom@tromey.com>
8123
8124         * tui/tui-data.h (struct tui_source_window)
8125         (struct tui_data_window): Declare destructors.
8126         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8127         destructors.
8128         (tui_win_info): Simplify.
8129
8130 2019-06-25  Tom Tromey  <tom@tromey.com>
8131
8132         * tui/tui-winsource.c (tui_display_main)
8133         (tui_update_source_windows_with_addr)
8134         (tui_update_all_breakpoint_info): Update.
8135         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8136         (new_height_ok, parse_scrolling_args): Update.
8137         * tui/tui-stack.c (tui_show_frame_info): Update.
8138         * tui/tui-data.h (struct tui_list): Remove.
8139         (tui_source_windows): Return a reference to a std::vector.
8140         * tui/tui-data.c (source_windows): Now a std::vector.
8141         (tui_source_windows): Change return type.
8142         (tui_clear_source_windows): Rewrite.
8143         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8144         (tui_free_all_source_wins_content): Rewrite.
8145
8146 2019-06-25  Tom Tromey  <tom@tromey.com>
8147
8148         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8149         (struct tui_data_window, struct tui_cmd_window): Declare
8150         clear_detail method.
8151         * tui/tui-data.c (tui_source_window::clear_detail)
8152         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8153         methods.
8154         (tui_clear_win_detail): Simplify.
8155
8156 2019-06-25  Tom Tromey  <tom@tromey.com>
8157
8158         * tui/tui-layout.c (make_source_window, make_disasm_window)
8159         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8160         Return the new window.
8161         (show_source_disasm_command, show_data)
8162         (show_source_or_disasm_and_command): Update.
8163
8164 2019-06-25  Tom Tromey  <tom@tromey.com>
8165
8166         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8167         parameter.  Return the new window.
8168         (show_source_disasm_command): Update and remove NULL check.
8169         (show_source_or_disasm_and_command): Update.
8170
8171 2019-06-25  Tom Tromey  <tom@tromey.com>
8172
8173         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8174
8175 2019-06-25  Tom Tromey  <tom@tromey.com>
8176
8177         * tui/tui-data.h (struct tui_win_info): Make constructor
8178         protected.  Make destructor virtual.  Add initializers.
8179         (tui_source_window, tui_data_window, tui_cmd_window): New
8180         classes.
8181         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8182         constructor.  Add "type" parameter.
8183         (tui_source_window, tui_data_window, tui_cmd_window): New
8184         constructors.
8185         (tui_alloc_win_info): Instantiate the appropriate subclass.
8186
8187 2019-06-25  Tom Tromey  <tom@tromey.com>
8188
8189         * tui/tui-win.c (tui_resize_all): Use delete.
8190         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8191         destructor.
8192         (tui_free_window): Don't declare.
8193         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8194         Update.
8195
8196 2019-06-25  Tom Tromey  <tom@tromey.com>
8197
8198         * tui/tui-data.h (struct tui_win_info): Add constructor.
8199         * tui/tui-data.c (tui_alloc_win_info): Use new.
8200         (tui_free_window): Use delete.
8201
8202 2019-06-22  Tom Tromey  <tom@tromey.com>
8203
8204         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8205         declare.
8206         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8207
8208 2019-06-22  Tom Tromey  <tom@tromey.com>
8209
8210         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8211         declare.
8212         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8213
8214 2019-06-22  Tom de Vries  <tdevries@suse.de>
8215
8216         * dwarf2read.c (create_addrmap_from_aranges)
8217         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8218         instead of '%zu'.
8219
8220 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8221
8222         * dwarf2read.h (dwarf2_section_info_def): Remove.
8223         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8224         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8225         std::vector<dwarf2_section_info>.
8226         (struct dwo_file) <~dwo_file>: Remove.
8227         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8228         types field.
8229         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8230         (dwarf2_read_debug_names): Likewise.
8231         (create_debug_types_hash_table): Change parameter type to
8232         array_view, adjust code accordingly.
8233         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8234         (partial_die_info::fixup): Likewise.
8235         (determine_prefix): Likewise.
8236         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8237
8238 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8239
8240         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8241         gdb_bfd_ref_ptr.
8242         <~dwo_file>: Remove call to gdb_bfd_unref.
8243         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8244         gdb_bfd_ref_ptr::get.
8245
8246 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8247
8248         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8249         type to htab_up.
8250         * dwarf2read.c (struct dwo_file): Initialize fields.
8251         <~dwo_file>: New.
8252         (free_dwo_file): Remove, move content to ~dwo_file.
8253         (struct dwo_file_deleter): Remove.
8254         (dwo_file_up>: Remove custom deleter.
8255         (free_dwo_files): Remove.
8256         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8257         dwo_files.
8258         (process_skeletonless_type_units): Call unique_ptr::get.
8259         (allocate_dwo_file_hash_table): Add deleter to created hash
8260         table.  Change return type to htab_up.
8261         (lookup_dwo_file_slot): Don't memset dwo_file, call
8262         unique_ptr::get.
8263         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8264         (create_dwo_unit_in_dwp_v2): Likewise.
8265         (open_and_init_dwo_file): Likewise.
8266         (free_dwo_file_from_slot): Remove.
8267
8268 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8269
8270         * dwarf2read.h (struct dwarf2_section_info) <readin,
8271         is_virtual>: Change type to bool.
8272         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8273         true instead of 1.
8274
8275 2019-06-19  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-data.h (tui_init_content_element): Don't declare.
8278
8279 2019-06-19  Tom Tromey  <tom@tromey.com>
8280
8281         * tui/tui-data.h (tui_init_win_info): Don't declare.
8282
8283 2019-06-19  Tom de Vries  <tdevries@suse.de>
8284
8285         * dwarf2read.h (abstract_to_concrete): Change type to
8286         std::unordered_map<sect_offset, std::vector<sect_offset>,
8287         gdb::hash_enum<sect_offset>>.
8288
8289 2019-06-19  Tom Tromey  <tromey@adacore.com>
8290
8291         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8292         EVAL_AVOID_SIDE_EFFECTS specially.
8293
8294 2019-06-19  Tom Tromey  <tromey@adacore.com>
8295
8296         * source-cache.c (highlighter): New global.
8297         (source_cache::get_source_lines): Create a highlighter on demand.
8298
8299 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8300
8301         * defs.h (deprecated_interactive_hook): Delete declaration.
8302         * interps.c (clear_interpreter_hooks): Remove use of
8303         deprecated_interactive_hook.
8304         * top.c (deprecated_interactive_hook): Delete definition.
8305         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8306
8307 2019-06-18  Tom de Vries  <tdevries@suse.de>
8308
8309         PR gdb/24515
8310         * dwarf2read.h (abstract_to_concrete): Change type from
8311         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8312         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8313         * dwarf2read.c (read_variable): Update.
8314         (dwarf2_fetch_die_loc_sect_off): Update.
8315
8316 2019-06-17  Tom de Vries  <tdevries@suse.de>
8317
8318         PR gdb/24617
8319         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8320         accessing parent[parent_len - 1].
8321
8322 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8323
8324         PR gdb/24364
8325         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8326         call dtrace_process_dof with NULL dof.
8327
8328 2019-06-16  Tom de Vries  <tdevries@suse.de>
8329
8330         PR gdb/24445
8331         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8332
8333 2019-06-16  Tom Tromey  <tom@tromey.com>
8334
8335         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8336         (make_all_visible): Use address of member.
8337
8338 2019-06-16  Tom Tromey  <tom@tromey.com>
8339
8340         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8341         (tui_free_window, free_content, free_content_elements): Remove
8342         unnecessary cast.
8343         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8344         cast.
8345         * tui/tui-regs.c (tui_show_register_group)
8346         (tui_display_registers_from, tui_display_reg_element_at_line):
8347         Remove unnecessary cast.
8348
8349 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * linux-nat.c (normal_mask): Delete.
8352         (_initialize_linux_nat): Don't initialise normal_mask.
8353
8354 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8355
8356         PR gdb/24445
8357         * dwarf-index-write.h (write_psymtabs_to_index): Add
8358         dwz_basename parameter.
8359         * dwarf-index-write.c (write_gdbindex): Move file writing to
8360         write_gdbindex_1.  Change return type void.
8361         (assert_file_size): Move up, remove filename parameter.
8362         (write_gdbindex_1): New function.
8363         (write_debug_names): Change return type to void, call
8364         assert_file_size.
8365         (struct index_wip_file): New struct.
8366         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8367         file logic to index_wip_file.  Write index for dwz file if
8368         needed.
8369         (save_gdb_index_command): Pass basename of dwz file, if present.
8370         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8371         build-id of dwz file, if present.
8372         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8373         (dwarf2_get_dwz_file): Likewise.
8374         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8375         (dwarf2_get_dwz_file): Likewise.
8376
8377 2019-06-16  Tom Tromey  <tom@tromey.com>
8378
8379         * coffread.c (process_coff_symbol): Use xstrdup.
8380         * value.c (create_internalvar): Use xstrdup.
8381
8382 2019-06-16  Tom Tromey  <tom@tromey.com>
8383
8384         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8385         * breakpoint.c (stopin_command, stopat_command)
8386         (until_break_command, decode_location_default): Remove unnecessary
8387         cast.
8388         * utils.c (subset_compare): Remove unnecessary cast.
8389         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8390         cast.
8391         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8392         cast.
8393         * infcmd.c (path_command): Remove unnecessary cast.
8394         * coffread.c (decode_type): Remove unnecessary cast.
8395         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8396         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8397         * tui/tui-stack.c (tui_show_locator_content)
8398         (tui_show_frame_info): Remove unnecessary cast.
8399         * tui/tui-win.c (tui_scroll_forward_command)
8400         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8401         (parse_scrolling_args): Remove unnecessary cast.
8402         * tui/tui-data.c (init_win_info, tui_del_window)
8403         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8404         (free_content_elements): Remove unnecessary cast.
8405         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8406         unnecessary cast.
8407         * tui/tui-source.c (tui_set_source_content)
8408         (tui_vertical_source_scroll): Remove unnecessary cast.
8409         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8410         cast.
8411         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8412         * tui/tui-regs.c (tui_display_registers_from)
8413         (tui_display_register): Remove unnecessary cast.
8414         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8415         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8416         (make_visible): Remove unnecessary cast.
8417         * tui/tui-winsource.c (tui_erase_source_content)
8418         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8419         unnecessary cast.
8420         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8421         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8422         * stabsread.c (read_type, read_array_type, read_range_type):
8423         Remove unnecessary cast.
8424         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8425         (parse_symbol, parse_type, upgrade_type, parse_external)
8426         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8427         unnecessary cast.
8428         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8429
8430 2019-06-16  Tom Tromey  <tom@tromey.com>
8431
8432         * tui/tui-data.c (tui_alloc_generic_win_info)
8433         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8434         checks.
8435
8436 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8437             Andrew Burgess  <andrew.burgess@embecosm.com>
8438
8439         * f-typeprint.c (f_print_type): Don't return early for not
8440         associated or not allocated types.
8441         (f_type_print_varspec_suffix): Add print_rank parameter and print
8442         ranks of array types in case they dangling.
8443         (f_type_print_base): Add print_rank parameter.
8444
8445 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8446
8447         * NEWS: Mention new MI commands.
8448         * break-catch-throw.c (enum exception_event_kind): Move to
8449         breakpoint.h.
8450         (print_mention_exception_catchpoint): Output text as a single
8451         message.
8452         (catch_exception_command_1): Rename to...
8453         (catch_exception_event): ...this, make non-static, update header
8454         command, and change some parameter types.
8455         (catch_catch_command): Update for changes to
8456         catch_exception_command_1.
8457         (catch_throw_command): Likewise.
8458         (catch_rethrow_command): Likewise.
8459         * breakpoint.c (enum exception_event_kind): Delete.
8460         * breakpoint.h (enum exception_event_kind): Moved here from
8461         break-catch-throw.c.
8462         (catch_exception_event): Declare.
8463         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8464         (mi_cmd_catch_throw): New function.
8465         (mi_cmd_catch_rethrow): New function.
8466         (mi_cmd_catch_catch): New function.
8467         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8468         'catch-catch' entries.
8469         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8470         (mi_cmd_catch_rethrow): Declare.
8471         (mi_cmd_catch_catch): Declare.
8472
8473 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8474
8475         * annotate.c (annotate_source_line): Change return type to void,
8476         update implementation to match.
8477         * annotate.h (annotate_source_line): Change return type to void,
8478         update header comment.
8479         * stack.c (print_frame_info): Don't change what frame information
8480         is printed based on whether annotations are on or not.
8481
8482 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8483
8484         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8485         (annotate_source): Make static.
8486         (annotate_source_line): Moved from source.c and renamed from
8487         identify_source_line.  Update the return type.
8488         * annotate.h (annotate_source): Delete declaration.
8489         (annotate_source_line): Declaration moved from source.h, and
8490         renamed from identify_source_line.  Return type updated.
8491         * source.c (identify_source_line): Moved to annotate.c and renamed
8492         to annotate_source_line.
8493         (info_line_command): Remove check of annotation_level.
8494         * source.h (identify_source_line): Move declaration to annotate.h
8495         and rename to annotate_source_line.
8496         * stack.c: Add 'annotate.h' include.
8497         (print_frame_info): Remove check of annotation_level before
8498         calling annotate_source_line.
8499
8500 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8501
8502         * source-cache.c (source_cache::get_plain_source_lines): Use
8503         open_source_file_with_line_charpos instead of just
8504         open_source_file, remove call to find_source_lines.
8505         (source_cache::get_source_lines): Likewise.
8506         * source.c (find_source_lines): Make static.
8507         (get_filename_and_charpos): Renamed into...
8508         (open_source_file_with_line_charpos): ..this along with changes to
8509         return a scoped_fd, and some other minor clean ups.
8510         (identify_source_line): Use open_source_file_with_line_charpos.
8511         (search_command_helper): Use open_source_file_with_line_charpos
8512         instead of just open_source_file, remove call to
8513         find_source_lines.
8514         * source.h (open_source_file_with_line_charpos): Declare new
8515         function.
8516         (find_source_lines): Delete declaration.
8517
8518 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8519
8520         * source.c (get_filename_and_charpos): Remove fullname
8521         parameter.
8522         (identify_source_line): Update call to get_filename_and_charpos.
8523
8524 2019-06-14  Tom Tromey  <tromey@adacore.com>
8525
8526         PR gdb/24502:
8527         * ui-style.h (skip_ansi_escape): Update comment.
8528         * ui-file.h (class no_terminal_escape_file): New class.
8529         * ui-file.c (no_terminal_escape_file::write)
8530         (no_terminal_escape_file::puts): New methods.
8531         * cli/cli-logging.c (handle_redirections): Use
8532         no_terminal_escape_file.
8533
8534 2019-06-14  Tom Tromey  <tromey@adacore.com>
8535
8536         * NEWS: Move convenience variable news above Python news.
8537
8538 2019-06-14  Tom Tromey  <tom@tromey.com>
8539
8540         * gnulib: Move directory to top-level.
8541         * configure.ac: Don't configure gnulib.
8542         * configure: Rebuild.
8543         * common/common-defs.h: Use new path to gnulib.
8544         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8545         (GNULIB_H): Remove.
8546         (INCGNU): Look in new gnulib location.
8547         (HFILES_NO_SRCDIR): Remove gnulib files.
8548         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8549         (generated_files): Remove GNULIB_H.
8550         ($(LIBGNU), all-lib): Remove targets.
8551         (distclean): Don't mention GNULIB_BUILDDIR.
8552         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8553
8554 2019-06-14  Tom Tromey  <tromey@adacore.com>
8555
8556         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8557         Warn if symbol file does not provide any symbols.
8558
8559 2019-06-14  Tom Tromey  <tromey@adacore.com>
8560
8561         * source.c (find_and_open_source): Respect basenames_may_differ.
8562
8563 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8564
8565         * annotate.c (annotate_breakpoints_invalid): Make use of
8566         scoped_restore_terminal_state.
8567         (annotate_frames_invalid): Likewise.
8568
8569 2019-06-14  Tom Tromey  <tromey@adacore.com>
8570
8571         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8572         allow assignment to an internalvar.
8573
8574 2019-06-14  Tom Tromey  <tromey@adacore.com>
8575
8576         * ada-lex.l: Allow "_" in attribute names.
8577
8578 2019-06-14  Tom Tromey  <tromey@adacore.com>
8579
8580         PR gdb/24653:
8581         * regcache.c (registers_changed): Don't call alloca.
8582         * top.c (execute_command): Don't call alloca.
8583
8584 2019-06-13  Pedro Alves  <palves@redhat.com>
8585
8586         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8587         'expression'.  When parsing an expression, error out if there's
8588         junk after "unlimited".
8589         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8590         (do_set_command): Adjust calls to is_unlimited_literal.
8591
8592 2019-06-13  Pedro Alves  <palves@redhat.com>
8593
8594         * compile/compile.c (make_compile_options_def_group): Add braces
8595         around array_view initializer.
8596         * thread.c (make_thread_apply_all_options_def_group)
8597         (make_thread_apply_all_options_def_group): Likewise.
8598
8599 2019-06-13  Pedro Alves  <palves@redhat.com>
8600
8601         * NEWS (New commands): Mention "maint test-options
8602         require-delimiter", "maint test-options unknown-is-error", "maint
8603         test-options unknown-is-operand" and "maint show
8604         test-options-completion-result".
8605         (New command options, command completion): New section.
8606         (Completion improvements): New section.
8607         Mention that you can abbreviate "unlimited".
8608
8609 2019-06-13  Pedro Alves  <palves@redhat.com>
8610
8611         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8612         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8613         * unittests/cli-utils-selftests.c (test_parse_flags)
8614         (test_parse_flags_qcs): Delete.
8615         (test_cli_utils): Don't call deleted functions.
8616
8617 2019-06-13  Pedro Alves  <palves@redhat.com>
8618
8619         * thread.c: Include "cli/cli-option.h".
8620         (tp_array_compar_ascending): Global.
8621         (tp_array_compar): Delete function.
8622         (tp_array_compar_ascending, tp_array_compar_descending): New
8623         functions.
8624         (ascending_option_def, qcs_flag_option_def)
8625         (thr_qcs_flags_option_defs)
8626         (make_thread_apply_all_options_def_group)
8627         (make_thread_apply_options_def_group): New.
8628         (thread_apply_all_command): Use gdb::option::process_options.
8629         (thread_apply_command_completer)
8630         (thread_apply_all_command_completer): New.
8631         (thread_apply_command): Use gdb::option::process_options.
8632         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8633         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8634         to generate help text of "thread apply".  Adjust "taas"'s help.
8635         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8636         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8637
8638 2019-06-13  Pedro Alves  <palves@redhat.com>
8639
8640         * thread.c (thread_apply_command): Check for invalid TID with
8641         isdigit instead of !isalpha.
8642
8643 2019-06-13  Pedro Alves  <palves@redhat.com>
8644
8645         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8646         (validate_flags_qcs): New.
8647         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8648         (validate_flags_qcs): Declare.
8649         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8650         (make_frame_apply_options_def_group): New.
8651         (frame_apply_command_count): Process options with
8652         gdb::option::process_options.
8653         (frame_apply_completer): New.
8654         (frame_apply_level_completer, frame_apply_all_completer)
8655         (frame_apply_completer): New.
8656         (_initialize_stack): Update help of "frame apply", "frame apply
8657         level", "frame apply all" and "faas" to mention supported options
8658         and install command completers.
8659         * stack.h (frame_apply_all_completer): Declare.
8660         * thread.c: Include "stack.h".
8661         (tfaas_command): Add "--".
8662         (_initialize_thread): Update help "tfaas" to mention supported
8663         options and install command completer.
8664
8665 2019-06-13  Pedro Alves  <palves@redhat.com>
8666
8667         * completer.c (complete_nested_command_line): New.
8668         (gdb_completion_word_break_characters_throw): Add assertion.
8669         * completer.h (complete_nested_command_line): Declare.
8670
8671 2019-06-13  Pedro Alves  <palves@redhat.com>
8672
8673         * stack.c (parse_backtrace_qualifiers): New.
8674         (backtrace_command): Use it.
8675         (backtrace_command_completer): Complete on qualifiers.
8676
8677 2019-06-13  Pedro Alves  <palves@redhat.com>
8678
8679         * frame.c: Include "cli/cli-option.h.
8680         (user_set_backtrace_options): New.
8681         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8682         Delete.
8683         (get_prev_frame): Adjust.
8684         (boolean_option_def, uinteger_option_def)
8685         (set_backtrace_option_defs): New.
8686         (_initialize_frame): Adjust and use
8687         gdb::option::add_setshow_cmds_for_options to install "set
8688         backtrace past-main" and "set backtrace past-entry".
8689         * frame.h: Include "cli/cli-option.h".
8690         (struct frame_print_options): Forward declare.
8691         (print_frame_arguments_all, print_frame_arguments_scalars)
8692         (print_frame_arguments_none): Declare.
8693         (print_entry_values): Delete declaration.
8694         (struct frame_print_options, user_frame_print_options): New.
8695         (struct set_backtrace_options): New.
8696         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8697         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8698         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8699         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8700         (list_args_or_locals): Add frame_print_options parameter.
8701         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8702         * python/py-framefilter.c (enumerate_args): Pass down
8703         USER_FRAME_PRINT_OPTIONS.
8704         * stack.c: Include "cli/cli-option.h".
8705         (print_frame_arguments_all, print_frame_arguments_scalars)
8706         (print_frame_arguments_none): Declare.
8707         (print_raw_frame_arguments, print_entry_values): Delete.
8708         (user_frame_print_options): New.
8709         (boolean_option_def, enum_option_def, frame_print_option_defs):
8710         New.
8711         (struct backtrace_cmd_options): New.
8712         (bt_flag_option_def): New.
8713         (backtrace_command_option_defs): New.
8714         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8715         (print_frame_arg, read_frame_arg, print_frame_args)
8716         (print_frame_info, print_frame): Add frame_print_options parameter
8717         and use it.
8718         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8719         (backtrace_command_1): Add frame_print_options and
8720         backtrace_cmd_options parameters and use them.
8721         (make_backtrace_options_def_group): New.
8722         (backtrace_command): Process command options with
8723         gdb::option::process_options.
8724         (backtrace_command_completer): New.
8725         (_initialize_stack): Extend "backtrace"'s help to mention
8726         supported options.  Install completer for "backtrace".
8727         Install some settings commands with add_setshow_cmds_for_options.
8728
8729 2019-06-13  Pedro Alves  <palves@redhat.com>
8730
8731         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8732         and that "set/show print raw frame-arguments" are now deprecated.
8733
8734         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8735         command.
8736         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8737         * stack.c (_initialize_stack): Install "set/show print
8738         raw-frame-arguments", and deprecate "set/show print raw
8739         frame-arguments".
8740         * valprint.c (_initialize_valprint): Deprecate "set/show print
8741         raw".
8742
8743 2019-06-13  Pedro Alves  <palves@redhat.com>
8744
8745         * compile/compile.c (struct compile_options): New.
8746         (compile_flag_option_def, compile_command_option_defs)
8747         (make_compile_options_def_group): New.
8748         (compile_file_command): Handle options with
8749         gdb::option::process_options.
8750         (compile_file_command_completer): New function.
8751         (compile_code_command): Handle options with
8752         gdb::option::process_options.
8753         (compile_code_command_completer): New function.
8754         (_initialize_compiler): Install completers for "compile code" and
8755         "compile file".  Mention available options in "compile code" and
8756         "compile code"'s help.
8757         * completer.c (advance_to_completion_word): New, factored out from
8758         ...
8759         (advance_to_expression_complete_word_point): ... this.
8760         (advance_to_filename_complete_word_point): New.
8761         * completer.h (advance_to_filename_complete_word_point): New
8762         declaration.
8763
8764 2019-06-13  Pedro Alves  <palves@redhat.com>
8765
8766         * compile/compile.c: Include "cli/cli-option.h".
8767         (compile_print_value): Scope data pointer is now a
8768         value_print_options pointer; adjust.
8769         (compile_print_command): Process options.  Scope data pointer is
8770         now a value_print_options pointer; adjust.
8771         (_initialize_compile): Update "compile print"'s help to include
8772         supported options.  Install a completer for "compile print".
8773         * cp-valprint.c (show_vtblprint, show_objectprint)
8774         (show_static_field_print): Delete.
8775         (_initialize_cp_valprint): Don't install "set print
8776         static-members", "set print vtbl", "set print object" here.
8777         * printcmd.c: Include "cli/cli-option.h" and
8778         "common/gdb_optional.h".
8779         (print_command_parse_format): Rework to fill in a
8780         value_print_options instead of a format_data.
8781         (print_value): Change parameter type from format_data pointer to
8782         value_print_options reference.  Adjust.
8783         (print_command_1): Process options.  Adjust to pass down a
8784         value_print_options.
8785         (print_command_completer): New.
8786         (_initialize_printcmd): Install print_command_completer as
8787         handle_brkchars completer for the "print" command.  Update
8788         "print"'s help to include supported options.
8789         * valprint.c: Include "cli/cli-option.h".
8790         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8791         here from cp-valprint.c.
8792         (boolean_option_def, uinteger_option_def)
8793         (value_print_option_defs, make_value_print_options_def_group):
8794         New.  Use gdb::option::add_setshow_cmds_for_options to install
8795         "set print elements", "set print null-stop", "set print repeats",
8796         "set print pretty", "set print union", "set print array", "set
8797         print address", "set print symbol", "set print array-indexes".
8798         * valprint.h: Include <string> and "cli/cli-option.h".
8799         (make_value_print_options_def_group): Declare.
8800         (print_value): Change parameter type from format_data pointer to
8801         value_print_options reference.
8802         (print_command_completer): Declare.
8803
8804 2019-06-13  Pedro Alves  <palves@redhat.com>
8805
8806         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8807         (COMMON_SFILES): Add maint-test-settings.c.
8808         * cli/cli-decode.c (boolean_enums): New global, factored out from
8809         ...
8810         (add_setshow_boolean_cmd): ... here.
8811         * cli/cli-decode.h (boolean_enums): Declare.
8812         * cli/cli-option.c: New file.
8813         * cli/cli-option.h: New file.
8814         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8815         factored out from ...
8816         (parse_cli_boolean_value(const char *)): ... this.
8817         (is_unlimited_literal): Change parameter type to pointer to
8818         pointer.  Adjust and advance ARG pointer.
8819         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8820         (parse_cli_var_enum): New, factored out from ...
8821         (do_set_command): ... this.  Adjust.
8822         * cli/cli-setshow.h (parse_cli_boolean_value)
8823         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8824         (parse_cli_var_enum): Declare.
8825         * cli/cli-utils.c: Include "cli/cli-option.h".
8826         (get_ulongest): New.
8827         * cli/cli-utils.h (get_ulongest): Declare.
8828         (check_for_argument): New overloads.
8829         * maint-test-options.c: New file.
8830
8831 2019-06-13  Pedro Alves  <palves@redhat.com>
8832
8833         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8834         parse a range if "-" is at the end of the string.
8835
8836 2019-06-13  Pedro Alves  <palves@redhat.com>
8837
8838         * cli/cli-setshow.c (parse_auto_binary_operation)
8839         (parse_cli_boolean_value): Don't allow "o".
8840
8841 2019-06-13  Pedro Alves  <palves@redhat.com>
8842
8843         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8844         * NEWS: Mention maint test-settings KIND.
8845         * maint-test-settings.c: New file.
8846
8847 2019-06-13  Pedro Alves  <palves@redhat.com>
8848
8849         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8850         completer.
8851         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8852         "set" completers.
8853
8854 2019-06-13  Pedro Alves  <palves@redhat.com>
8855
8856         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8857         after item.
8858
8859 2019-06-13  Pedro Alves  <palves@redhat.com>
8860
8861         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8862
8863 2019-06-13  Pedro Alves <palves@redhat.com>
8864
8865         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8866         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8867         call.
8868         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8869         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8870         calls.
8871         (check_for_argument): Skip spaces after argument.
8872
8873 2019-06-13  Pedro Alves  <palves@redhat.com>
8874
8875         * thread.c (thread_apply_command): Adjust TID parsing.
8876         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8877         detected before end of string.
8878         (tid_is_in_list): Error out if LIST is invalid.
8879
8880 2019-06-13  Pedro Alves  <palves@redhat.com>
8881
8882         * completer.c (complete_line_internal_1): Rewind completion word
8883         point.
8884         (completion_tracker::advance_custom_word_point_by): Change
8885         parameter type to int.
8886         * completer.h (completion_tracker::advance_custom_word_point_by):
8887         Likewise.
8888
8889 2019-06-13  Pedro Alves  <palves@redhat.com>
8890
8891         * completer.c (advance_to_completion_word): Handle delimiters.
8892
8893 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8894
8895         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8896
8897 2019-06-11  Tom Tromey  <tom@tromey.com>
8898
8899         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8900         (xmalloc_failed): Move to alloc.c.
8901         * alloc.c: New file.
8902         * Makefile.in (COMMON_SFILES): Add alloc.c.
8903
8904 2019-06-11  Tom Tromey  <tom@tromey.com>
8905
8906         * nat/linux-waitpid.c: Don't include server.h.
8907         (linux_debug): Remove.
8908         (my_waitpid): Update.
8909
8910 2019-06-11  Tom Tromey  <tromey@adacore.com>
8911
8912         * infcall.c (_initialize_infcall): Remove trailing newline from
8913         help.
8914         * user-regs.c (_initialize_user_regs): Remove trailing newline
8915         from help.
8916         * typeprint.c (_initialize_typeprint): Remove trailing newline
8917         from help.
8918         * reverse.c (_initialize_reverse): Remove trailing newlines from
8919         help.
8920         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8921         from help.
8922         * language.c (add_set_language_command): Remove trailing newline
8923         from help.
8924         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8925         help.
8926         * disasm.c (_initialize_disasm): Remove trailing newline from
8927         help.
8928         * top.c (init_main): Remove trailing newline from help.
8929         * interps.c (_initialize_interpreter): Remove trailing newline
8930         from help.
8931         * btrace.c (_initialize_btrace): Remove trailing newlines from
8932         help.
8933         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8934         from help.
8935         * python/python.c (_initialize_python): Remove trailing newline
8936         from help.
8937         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8938         help.
8939         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8940         from help.  Reformat some text.
8941         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8942         from help.
8943         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8944         newline from help.
8945
8946 2019-06-11  Tom Tromey  <tromey@adacore.com>
8947
8948         * darwin-nat.c (darwin_decode_exception_message)
8949         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8950
8951 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8952
8953         * valops.c (value_slice): Check for not allocated or not
8954         associated values.
8955
8956 2019-06-10  Tom de Vries  <tdevries@suse.de>
8957
8958         PR gdb/24618
8959         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8960         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8961         invalid.
8962
8963 2019-06-10  Tom de Vries  <tdevries@suse.de>
8964
8965         PR gdb/24611
8966         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8967         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8968
8969 2019-06-10  Tom de Vries  <tdevries@suse.de>
8970
8971         PR symtab/24545
8972         * symtab.c (struct demangled_name_entry): Add language field.
8973         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8974         static minimal symbol".  Set and use language field.
8975
8976 2019-06-10  Tom Tromey  <tromey@adacore.com>
8977
8978         * ada-lang.c (_initialize_ada_language): Update help text.
8979
8980 2019-06-10  Tom Tromey  <tromey@adacore.com>
8981
8982         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8983         with a newline.
8984         * guile/guile.c (handle_boot_error): Don't end warning with a
8985         newline.
8986         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8987         warning with a newline.
8988         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8989         newline.
8990         (s12z_frame_cache): Likewise.
8991         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8992         a newline.
8993         * solib-svr4.c (disable_probes_interface): Don't end warning with
8994         a newline.
8995         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8996         newline.
8997         * python/python.c (do_finish_initialization): Don't end warning
8998         with a newline.
8999
9000 2019-06-10  Tom Tromey  <tom@tromey.com>
9001
9002         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9003         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9004         gdbpy_enter.
9005
9006 2019-06-10  Tom Tromey  <tromey@adacore.com>
9007
9008         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9009         data.
9010         (elf_new_init): Don't call stabsread_new_init.
9011         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9012         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9013         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9014
9015 2019-06-10  Tom de Vries  <tdevries@suse.de>
9016
9017         PR symtab/16264
9018         PR symtab/24517
9019         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9020
9021 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9022
9023         * source.c (find_and_open_source): Also rewrite relative file
9024         names.
9025
9026 2019-04-26  Amos Bird  <amosbird@gmail.com>
9027
9028         * annotate.c (annotate_thread_exited): Add "thread-exited"
9029         annotation.
9030
9031 2019-06-06  Tom Tromey  <tromey@adacore.com>
9032
9033         * maint.h (class scoped_command_stats): Use
9034         DISABLE_COPY_AND_ASSIGN.
9035         <print_time>: New method.
9036         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9037         print_time.
9038         (scoped_command_stats::print_time): New method.
9039
9040 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9041
9042         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9043         instructions of lengths 6 or 8 bytes.
9044
9045 2019-06-04  Pedro Alves  <palves@redhat.com>
9046
9047         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9048
9049         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9050         * breakpoint.c (condition_completer): Likewise.
9051         * cli/cli-dump.c (scan_expression): Likewise.
9052         * common/filestuff.c (mkdir_recursive): Likewise.
9053         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9054         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9055         (gdb_abspath): Likewise.
9056         * compile/compile-cplus-types.c
9057         (compile_cplus_instance::decl_name): Likewise.
9058         * completer.c (complete_explicit_location):
9059         (signal_completer, reg_or_group_completer_1): Likewise.
9060         * cp-support.c (cp_remove_params_if_any): Likewise.
9061         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9062         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9063         * infcmd.c (strip_bg_char): Likewise.
9064         * linespec.c (copy_token_string): Likewise.
9065         * mi/mi-main.c (output_cores): Likewise.
9066         * psymtab.c (psymtab_search_name):
9067         * symfile.c (test_set_ext_lang_command): Likewise.
9068         * target.c (target_fileio_read_stralloc): Likewise.
9069         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9070         * value.c (complete_internalvar): Likewise.
9071
9072 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9073
9074         Add objfile property to gdb.Type.
9075         * NEWS: Mention Python API addition.
9076         * python/py-type.c (typy_get_objfile): New method.
9077
9078 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9079
9080         * NEWS: Mention the new set|show style [title|highlight].
9081         Mention changes to "show style", "help" and "apropos".
9082
9083 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9084
9085         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9086         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9087         instead of print_help_for_command.
9088         (print_doc_of_command): New function.
9089         (help_list): Add 'apropos -v word' suggestion.
9090         (print_help_for_command): Style the command name using title style.
9091         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9092         (_initialize_cli_cmds): Describe -v in apropos_command help.
9093
9094 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9095
9096         * cli/cli-style.h (cli_style_option): Add name in constructor,
9097         add m_name class member, add constructor with intensity,
9098         add name class function.
9099         (cli_style_option::add_setshow_commands): Remove name argument.
9100         (highlight_style, title_style): New styles.
9101         * cli/cli-style.c (do_show): New function that shows a style
9102         characteristic styling the style name with itself.
9103         (set_style_name): New function.
9104         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9105         Update all callers according to the changes in cli/cli-style.h.
9106         * utils.h (fputs_highlighted): New function.
9107         * utils.c (fputs_highlighted): Likewise.
9108
9109 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9110
9111         * NEWS: Mention new pipe command and new convenience variables.
9112
9113 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9114
9115         * cli/cli-cmds.c (pipe_command): New function.
9116         (_initialize_cli_cmds): Call add_com for pipe_command.
9117         Define | as an alias for pipe.
9118         (exit_status_set_internal_vars): New function.
9119         (shell_escape): Call exit_status_set_internal_vars.
9120         cli/cli-decode.c (find_command_name_length): Recognize | as
9121         a single character command.
9122
9123 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9124
9125         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9126         top.c (execute_command_to_ui_file): New function, mostly a copy
9127         of execute_command_to_string.
9128         (execute_command_to_string): Implement by calling
9129         execute_command_to_ui_file.
9130
9131 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9132
9133         * top.h (saved_command_line): Remove declaration.
9134         * top.c (previous_saved_command_line, previous_repeat_arguments):
9135         New variables.
9136         (saved_command_line): Make static, define together with other
9137         'repeat variables'.
9138         (dont_repeat): Clear repeat_arguments.
9139         (repeat_previous, get_saved_command_line, save_command_line):
9140         New functions.
9141         (gdb_init): Initialize saved_command_line
9142         and previous_saved_command_line.
9143         * main.c (captured_main_1): Remove saved_command_line initialization.
9144         * event-top.c (handle_line_of_input): Update to use
9145         the new 'repeat' related functions instead of direct access to
9146         saved_command_line.
9147         * command.h (repeat_previous, get_saved_command_line,
9148         save_command_line): New declarations.
9149         (dont_repeat): Add comment.
9150
9151 2019-05-30  Tom Tromey  <tromey@adacore.com>
9152
9153         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9154         Fix comment.
9155         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9156
9157 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9158
9159         PR cli/24587
9160         * completer.c (complete): Initialize variable word.
9161
9162 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9163
9164         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9165         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9166         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9167         'body' is NULL to the outter 'if', protecting the '!is_define'
9168         situation as well.
9169
9170 2019-05-29  Tom Tromey  <tromey@adacore.com>
9171
9172         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9173         (dwarf_unknown): New function.
9174         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9175         (dwarf_type_encoding_name): Use dwarf_unknown.
9176
9177 2019-05-29  Tom Tromey  <tromey@adacore.com>
9178
9179         PR c++/20020:
9180         * cp-valprint.c (cp_print_value_fields): Call
9181         cp_print_static_field inside "try".
9182
9183 2019-05-29  Tom Tromey  <tromey@adacore.com>
9184
9185         * inflow.c (struct terminal_info): Add default operator=.
9186         * configure: Rebuild.
9187         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9188         -Wdeprecated-copy-dtor, -Wredundant-move.
9189
9190 2019-05-29  Tom Tromey  <tromey@adacore.com>
9191
9192         * NEWS: Add entry.
9193         * infcmd.c (print_return_value_1): Handle finish_print
9194         option.
9195         (show_print_finish): New function.
9196         (_initialize_infcmd): Add "set/show print finish" commands.
9197         * valprint.c (user_print_options): Initialize new member.
9198         * valprint.h (struct value_print_options) <finish_print>: New
9199         member.
9200
9201 2019-05-28  Tom Tromey  <tromey@adacore.com>
9202
9203         * ada-lang.c (ada_remove_Xbn_suffix)
9204         (find_old_style_renaming_symbol)
9205         (parse_old_style_renaming): Remove.
9206         (ada_find_renaming_symbol): Don't call
9207         find_old_style_renaming_symbol.
9208         (ada_is_renaming_symbol): Rename from
9209         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9210         bool.  Now static.
9211         (ada_read_var_value): Update and simplify.
9212         * ada-exp.y (write_var_or_type): Remove old code.
9213
9214 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9215
9216         PR gdb/25010
9217         * event-top.c: Remove include comment.
9218         * inflow.c (class scoped_ignore_sigttou): Move from here...
9219         * inflow.h (class scoped_ignore_sigttou): ...to here.
9220         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9221         * top.c:  Remove include comment.
9222
9223 2019-05-27  Tom Tromey  <tom@tromey.com>
9224
9225         * NEWS: Fix typo.
9226
9227 2019-05-22  Tom Tromey  <tromey@adacore.com>
9228
9229         * target.c (target_follow_exec): Constify parameter.
9230         * target-delegates.c: Rebuild.
9231         * remote.c (remote_target::follow_exec): Constify parameter.
9232         * infrun.c (follow_exec): Constify parameter.
9233         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9234         (target_follow_exec): Likewise.
9235
9236 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9237
9238         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9239         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9240
9241 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9242
9243         * NEWS: Add debugredirect and testsuite sections.
9244
9245 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9246
9247         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9248         target descriptions using exclusively floating point register name
9249         aliases.
9250
9251 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9252
9253         PR gdb/18644:
9254         * f-lang.c (build_fortran_types): Handle the case where
9255         gdbarch_floatformat_for_type returns a nullptr.
9256
9257 2019-05-21  Tom de Vries  <tdevries@suse.de>
9258
9259         PR cli/24587
9260         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9261
9262 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9263
9264         PR gdb/18644:
9265         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9266         16-byte floats.
9267         * i386-tdep.c (i386_floatformat_for_type): Use
9268         floatformats_ia64_quad for the 16-byte floating point component
9269         within a fortran 32-byte complex number.
9270
9271 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9274         delete default constructor.
9275         (find_partial_die): Update to return const struct.
9276         (partial_die_parent_scope): Move variable declaration into scope
9277         of its use and change its type to auto.
9278         (guess_partial_die_structure_name): Likewise.
9279         (partial_die_info::fixup): Likewise.
9280
9281 2019-05-17  Tom Tromey  <tromey@adacore.com>
9282
9283         * source.c (find_and_open_source): Remove cast.
9284
9285 2019-05-17  Tom Tromey  <tromey@adacore.com>
9286
9287         * annotate.c (annotate_source): Make "filename" const.
9288         * annotate.h (annotate_source): Use const.
9289
9290 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9291
9292         * disasm.c (set_disassembler_options): Send errors to stderr.
9293
9294 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9295
9296         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9297         (cli_interp_base::set_logging): Check debug_redirect.
9298         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9299         * cli/cli-logging.c (debug_redirect): Add static variable.
9300         (pop_output_files): Add default param.
9301         (handle_redirections): Print debug setting.
9302         (show_logging_command): Likewise.
9303         (_initialize_cli_logging): Add debugredirect command.
9304         * interps.c (current_interp_set_logging): Add debug_redirect
9305         parameter.
9306         * interps.h (set_logging): Add debug_redirect parameter.
9307         (current_interp_set_logging): Likewise.
9308         * mi/mi-common.h: Likewise.
9309         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9310
9311 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9312             Tom Tromey  <tromey@adacore.com>
9313
9314         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9315         directly.
9316         * cli/cli-interp.h (make_logging_output): Remove declaration.
9317         * cli/cli-logging.c (make_logging_output): Remove function.
9318         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9319         directly.
9320         * ui-file.c (tee_file::tee_file): Remove bools.
9321         (tee_file::~tee_file): Remove deletes.
9322         * ui-file.h (tee_file): Remove bools.
9323
9324 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9325
9326         * mi/mi-cmds.h (mi_cmd_complete): New function.
9327         * mi/mi-main.c (mi_cmd_complete): Likewise.
9328         * mi/mi-cmds.c: Define new MI command -complete.
9329         * NEWS: Mention new -complete command.
9330
9331 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9332
9333         * completer.h (complete): New function.
9334         * completer.c (complete): Likewise.
9335         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9336         function defined in completer.h.
9337
9338 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9339
9340         * MAINTAINERS (Write After Approval): Add myself.
9341
9342 2019-05-17  Tom de Vries  <tdevries@suse.de>
9343
9344         PR gdb/24094
9345         * dwarf2read.c (struct cu_partial_die_info): New struct.
9346         (find_partial_die): Return cu_partial_die_info.
9347         (partial_die_parent_scope, guess_partial_die_structure_name)
9348         (partial_die_info::fixup): Handle new return type of find_partial_die.
9349
9350 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9351
9352         PR breakpoints/24541
9353         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9354         "std::string", simplifying the algorithm.
9355
9356 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9357
9358         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9359         (stap_static_probe_ops::get_probes): Likewise.
9360
9361 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9362
9363         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9364         '-')" and "else if".
9365         (stap_parse_single_operand): Join checks for
9366         "gdbarch_stap_parse_special_token_p" and
9367         "gdbarch_stap_parse_special_token" in the same "if" statement.
9368         Invert check when verifying for operation on register
9369         displacement.
9370
9371 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9372
9373         * stap-probe.c (stap_get_opcode): Update comment.
9374         (stap_get_expected_argument_type): Likewise.
9375         (handle_stap_probe): Likewise.
9376
9377 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9378
9379         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9380         return type to 'bool'.  Adjust comment.  Use 'bool' when
9381         appropriate.
9382         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9383         * stap-probe.c (stap_parse_argument_1): Likewise.
9384         (stap_is_operator): Likewise.
9385         (stap_is_generic_prefix): Likewise.
9386         (stap_is_register_prefix): Likewise.
9387         (stap_is_register_indirection_prefix): Likewise.
9388         (stap_is_integer_prefix): Likewise.
9389         (stap_generic_check_suffix): Likewise.
9390         (stap_check_integer_suffix): Likewise.
9391         (stap_check_register_suffix): Likewise.
9392         (stap_check_register_indirection_suffix): Likewise.
9393         (stap_parse_register_operand): Likewise.
9394         (stap_parse_single_operand): Likewise.
9395         (stap_parse_argument_1): Likewise.
9396         (stap_probe::get_argument_count): Likewise.
9397         (stap_is_operator): Likewise.
9398
9399 2019-05-16  Tom Tromey  <tromey@adacore.com>
9400
9401         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9402         keyword to foreach.
9403
9404 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9405
9406         * linux-thread-db.c (try_thread_db_load_1): Change return type
9407         to bool.
9408         (try_thread_db_load): Likewise.
9409         (try_thread_db_load_from_pdir_1): Likewise.
9410         (try_thread_db_load_from_pdir): Likewise.
9411         (try_thread_db_load_from_sdir): Likewise.
9412         (try_thread_db_load_from_dir): Likewise.
9413         (thread_db_load_search): Likewise.
9414         (has_libpthread): Likewise.
9415         (thread_db_load): Likewise.
9416
9417 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9418
9419         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9420         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9421         NULL, and complain/return if that's the case.
9422
9423 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9424
9425         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9426         (advance, posn, abstract_read_memory): New functions.
9427         [struct mem_read_abstraction]: New struct.
9428         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9429
9430 2019-05-14  Tom Tromey  <tromey@adacore.com>
9431
9432         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9433         value is not lval_memory.
9434
9435 2019-05-14  Tom Tromey  <tromey@adacore.com>
9436
9437         * solib.c (info_sharedlibrary_command): Style the file name.
9438
9439 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9440
9441         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9442         (aarch64_vnv_type): Likewise.
9443         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9444         * common/tdesc.c: Likewise.
9445         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9446         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9447         * features/aarch64-fpu.xml: Add ieee half view.
9448         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9449         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9450         * gdbtypes.h (struct builtin_type): Likewise.
9451         (struct objfile_type): Likewise.
9452
9453 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9454
9455         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9456         typo.
9457         * location.h (string_to_event_location): Likewise.
9458
9459 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9460
9461         GDB 8.3 released.
9462
9463 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9464
9465         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9466         New variable declaration.
9467         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9468         New variable.
9469         (print_one_breakpoint): Use ui_out::test_flags and new global
9470         variable to compute use_fixed_output.
9471         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9472         Remove.
9473         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9474         (mi_multi_location_breakpoint_output_fixed): Remove.
9475         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9476         new variable.
9477         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9478         fix_multi_location_breakpoint_output flag if version >= 3.
9479         * ui-out.h (enum ui_out_flag)
9480         <fix_multi_location_breakpoint_output>: New enumerator.
9481
9482 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9483
9484         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9485
9486 2019-05-10  Tom Tromey  <tromey@adacore.com>
9487
9488         * ada-lang.c (catch_ada_completer): New function.
9489         (_initialize_ada_language): Use it.
9490
9491 2019-05-10  Tom Tromey  <tromey@adacore.com>
9492
9493         * thread.c (print_thread_info): Make "requested_threads" const.
9494         * gdbthread.h (print_thread_info): Make "requested_threads"
9495         const.
9496         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9497         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9498
9499 2019-05-08  Tom Tromey  <tom@tromey.com>
9500
9501         * gdbtypes.c (objfile_type_data): Change type.
9502         (objfile_type, _initialize_gdbtypes): Update.
9503
9504 2019-05-08  Tom Tromey  <tom@tromey.com>
9505
9506         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9507         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9508         (_initialize_dwarf2_frame): Update.
9509
9510 2019-05-08  Tom Tromey  <tom@tromey.com>
9511
9512         * objc-lang.c (objc_objfile_data): Change type.
9513         (find_methods): Update.
9514         (_initialize_objc_lang): Remove.
9515
9516 2019-05-08  Tom Tromey  <tom@tromey.com>
9517
9518         * stabsread.c (rs6000_builtin_type_data): Change type.
9519         (rs6000_builtin_type, _initialize_stabsread): Update.
9520
9521 2019-05-08  Tom Tromey  <tom@tromey.com>
9522
9523         * mips-tdep.c (mips_pdr_data): Remove.
9524         (_initialize_mips_tdep): Update.
9525
9526 2019-05-08  Tom Tromey  <tom@tromey.com>
9527
9528         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9529         (hppa_init_objfile_priv_data, read_unwind_info)
9530         (find_unwind_entry, _initialize_hppa_tdep): Update.
9531
9532 2019-05-08  Tom Tromey  <tom@tromey.com>
9533
9534         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9535         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9536         on obstack.
9537         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9538
9539 2019-05-08  Tom Tromey  <tom@tromey.com>
9540
9541         * mdebugread.c (basic_type_data): Change type.
9542         (basic_type, _initialize_mdebugread): Update.
9543
9544 2019-05-08  Tom Tromey  <tom@tromey.com>
9545
9546         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9547
9548 2019-05-08  Tom Tromey  <tom@tromey.com>
9549
9550         * nto-tdep.c (nto_inferior_data_reg): Change type.
9551         (nto_inferior_data): Update.
9552         (nto_inferior_data_cleanup, nto_new_inferior_data)
9553         (_initialize_nto_tdep): Remove.
9554         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9555
9556 2019-05-08  Tom Tromey  <tom@tromey.com>
9557
9558         * ada-lang.c (struct ada_inferior_data): Add initializers.
9559         (ada_inferior_data): Change type.
9560         (ada_inferior_data_cleanup): Remove.
9561         (get_ada_inferior_data, ada_inferior_exit)
9562         (struct ada_pspace_data): Add initializers, destructor.
9563         (ada_pspace_data_handle): Change type.
9564         (get_ada_pspace_data): Update.
9565         (ada_pspace_data_cleanup): Remove.
9566
9567 2019-05-08  Tom Tromey  <tom@tromey.com>
9568
9569         * coffread.c (struct coff_symfile_info): Add initializers.
9570         (coff_objfile_data_key): Move lower.  Change type.
9571         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9572         Update.
9573         (coff_free_info): Remove.
9574
9575 2019-05-08  Tom Tromey  <tom@tromey.com>
9576
9577         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9578         (fbsd_pspace_data_handle): Move lower.  Change type.
9579         (get_fbsd_pspace_data): Update.
9580         (fbsd_pspace_data_cleanup): Remove.
9581         (_initialize_fbsd_tdep): Update.
9582
9583 2019-05-08  Tom Tromey  <tom@tromey.com>
9584
9585         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9586         (get_ada_tasks_pspace_data): Update.
9587         (ada_tasks_pspace_data_cleanup): Remove.
9588         (_initialize_tasks): Update.
9589         (ada_tasks_inferior_data_handle): Change type.
9590         (get_ada_tasks_inferior_data): Update.
9591         (ada_tasks_inferior_data_cleanup): Remove.
9592         (struct ada_tasks_pspace_data): Add initializers.
9593
9594 2019-05-08  Tom Tromey  <tom@tromey.com>
9595
9596         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9597         * symfile-debug.c (debug_sym_get_probes): Change type.
9598         * stap-probe.c (handle_stap_probe):
9599         (stap_static_probe_ops::get_probes): Change type.
9600         * probe.h (class static_probe_ops) <get_probes>: Change type.
9601         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9602         (parse_probes_in_pspace): Update.
9603         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9604         Update.
9605         (any_static_probe_ops::get_probes): Change type.
9606         * elfread.c (elfread_data): New typedef.
9607         (probe_key): Change type.
9608         (elf_get_probes): Likewise.  Update.
9609         (probe_key_free): Remove.
9610         (_initialize_elfread): Update.
9611         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9612         Change type.
9613         (dtrace_process_dof_probe, dtrace_process_dof)
9614         (dtrace_static_probe_ops::get_probe): Change type.
9615
9616 2019-05-08  Tom Tromey  <tom@tromey.com>
9617
9618         * xcoffread.c (struct xcoff_symfile_info): Rename from
9619         coff_symfile_info.  Add initializers.
9620         (xcoff_objfile_data_key): Move lower.  Change type.
9621         (XCOFF_DATA): Rewrite.
9622         (xcoff_free_info): Remove.
9623         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9624         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9625         (xcoff_initial_scan): Update.
9626
9627 2019-05-08  Tom Tromey  <tom@tromey.com>
9628
9629         * solib-svr4.c (struct svr4_info): Add initializers and
9630         destructor.
9631         <probes_table>: Now an htab_up.
9632         (solib_svr4_pspace_data): Change type.
9633         (free_probes_table): Simplify.
9634         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9635         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9636         (probes_table_remove_objfile_probes, register_solib_event_probe)
9637         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9638         (_initialize_svr4_solib): Update.
9639
9640 2019-05-08  Tom Tromey  <tom@tromey.com>
9641
9642         * remote.c (remote_pspace_data): Change type.
9643         (remote_pspace_data_cleanup): Remove.
9644         (get_remote_exec_file, set_pspace_remote_exec_file)
9645         (_initialize_remote): Update.
9646
9647 2019-05-08  Tom Tromey  <tom@tromey.com>
9648
9649         * breakpoint.c (breakpoint_objfile_key): Change type.
9650         (get_breakpoint_objfile_data): Update.
9651         (free_breakpoint_objfile_data): Remove.
9652         (_initialize_breakpoint): Update.
9653
9654 2019-05-08  Tom Tromey  <tom@tromey.com>
9655
9656         * linux-tdep.c (struct linux_info): Add initializers.
9657         (linux_inferior_data): Move.  Change type.
9658         (invalidate_linux_cache_inf): Update.
9659         (linux_inferior_data_cleanup): Remove.
9660         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9661
9662 2019-05-08  Tom Tromey  <tom@tromey.com>
9663
9664         * auxv.c (auxv_inferior_data): Move.  Change type.
9665         (auxv_inferior_data_cleanup): Remove.
9666         (invalidate_auxv_cache_inf): Rewrite.
9667         (get_auxv_inferior_data, _initialize_auxv): Update.
9668
9669 2019-05-08  Tom Tromey  <tom@tromey.com>
9670
9671         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9672         (symfile_debug_objfile_data_key): Change type.
9673         (symfile_debug_installed, debug_qf_has_symbols)
9674         (debug_qf_find_last_source_symtab)
9675         (debug_qf_forget_cached_source_info)
9676         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9677         (debug_qf_print_stats, debug_qf_dump)
9678         (debug_qf_expand_symtabs_for_function)
9679         (debug_qf_expand_all_symtabs)
9680         (debug_qf_expand_symtabs_with_fullname)
9681         (debug_qf_map_matching_symbols)
9682         (debug_qf_expand_symtabs_matching)
9683         (debug_qf_find_pc_sect_compunit_symtab)
9684         (debug_qf_map_symbol_filenames)
9685         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9686         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9687         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9688         (debug_sym_read_linetable, debug_sym_relocate): Update.
9689         (symfile_debug_free_objfile): Remove.
9690         (install_symfile_debug_logging, _initialize_symfile_debug):
9691         Update.
9692
9693 2019-05-08  Tom Tromey  <tom@tromey.com>
9694
9695         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9696         allocate_on_obstack.
9697         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9698         (get_dwarf2_per_objfile): Update.
9699         (set_dwarf2_per_objfile): Remove.
9700         (dwarf2_has_info, dwarf2_get_section_info): Update.
9701         (dwarf2_free_objfile): Remove.
9702         (_initialize_dwarf2_read): Update.
9703
9704 2019-05-08  Tom Tromey  <tom@tromey.com>
9705
9706         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9707         initializers.
9708         <unsupported_script_warning_printed,
9709         script_not_found_warning_printed>: Now bool.
9710         (auto_load_pspace_data): Change type.
9711         (~auto_load_pspace_info): Rename from
9712         auto_load_pspace_data_cleanup.
9713         (get_auto_load_pspace_data, init_loaded_scripts_info)
9714         (clear_section_scripts, maybe_print_unsupported_script_warning)
9715         (maybe_print_script_not_found_warning, _initialize_auto_load):
9716         Update.
9717
9718 2019-05-08  Tom Tromey  <tom@tromey.com>
9719
9720         * objfiles.c (objfile_pspace_info): Add destructor and
9721         initializers.
9722         (objfiles_pspace_data): Change type.
9723         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9724         (get_objfile_pspace_data): Update.
9725         (objfiles_bfd_data): Change type.
9726         (get_objfile_bfd_data): Update.
9727         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9728
9729 2019-05-08  Tom Tromey  <tom@tromey.com>
9730
9731         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9732         Change type.
9733         (get_catch_syscall_inferior_data): Update.
9734         (catch_syscall_inferior_data_cleanup): Remove.
9735         (_initialize_break_catch_syscall): Update.
9736
9737 2019-05-08  Tom Tromey  <tom@tromey.com>
9738
9739         * inflow.c (struct terminal_info): Add destructor and
9740         initializers.
9741         (inflow_inferior_data): Change type.
9742         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9743         (get_inflow_inferior_data, inflow_inferior_exit)
9744         (swap_terminal_info, _initialize_inflow): Update.
9745
9746 2019-05-08  Tom Tromey  <tom@tromey.com>
9747
9748         * target-dcache.c (target_dcache_cleanup): Remove.
9749         (target_dcache_aspace_key): Change type.
9750         (target_dcache_init_p, target_dcache_invalidate)
9751         (target_dcache_get, target_dcache_get_or_init)
9752         (_initialize_target_dcache): Update.
9753         * dcache.h (struct dcache_deleter): New.
9754
9755 2019-05-08  Tom Tromey  <tom@tromey.com>
9756
9757         * symtab.c (struct symbol_cache): Add destructor and
9758         initializers.
9759         (symbol_cache_key): Move.  Change type.
9760         (make_symbol_cache, free_symbol_cache): Remove.
9761         (get_symbol_cache): Update.
9762         (symbol_cache_cleanup): Remove.
9763         (ALL_PSPACES, symbol_cache_flush)
9764         (maintenance_print_symbol_cache)
9765         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9766         Update.
9767
9768 2019-05-08  Tom Tromey  <tom@tromey.com>
9769
9770         * symtab.c (struct main_info): Add destructor and initializers.
9771         (main_progspace_key): Move.  Change type.
9772         (get_main_info): Update.
9773         (main_info_cleanup): Remove.
9774         (_initialize_symtab): Update.
9775
9776 2019-05-08  Tom Tromey  <tom@tromey.com>
9777
9778         * registry.h (DECLARE_REGISTRY): Define the _key class.
9779
9780 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9781
9782         * NEWS: Merge two 'New commands' sections.
9783
9784 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9785
9786         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9787         parameter and use Ada language definition instead.
9788         (ada_val_print_ptr): Remove unused language parameter.
9789         (ada_val_print_num): Remove language parameter and use Ada language
9790         definition instead.
9791         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9792         parameter.
9793         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9794         parameter and use Ada language definition instead.
9795         (ada_val_print_1): Update all ada_val_print_xxx calls.
9796         Remove language parameter.
9797         (ada_val_print): Update ada_val_print_1 call.
9798
9799 2019-05-08  Tom Tromey  <tromey@adacore.com>
9800
9801         * remote.c (remote_hw_watchpoint_limit)
9802         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9803         Now static.
9804
9805 2019-05-08  Tom Tromey  <tromey@adacore.com>
9806
9807         * maint.c (_initialize_maint_cmds): Move initialization code to
9808         remote.c.
9809         (watchdog, show_watchdog): Move to remote.c.
9810         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9811         "watchdog" static.
9812         (_initialize_remote): Move initialization code from maint.c.
9813         * defs.h (watchdog): Don't declare.
9814
9815 2019-05-08  Tom Tromey  <tromey@adacore.com>
9816
9817         * tui/tui-interp.c: Include main.h.
9818         * interps.c: Include main.h.
9819         * main.h (interpreter_p): Declare.
9820         * defs.h (interpreter_p): Don't declare.
9821
9822 2019-05-08  Tom Tromey  <tromey@adacore.com>
9823
9824         * dwarf2loc.c: Include dwarf2read.h.
9825         * defs.h (read_unsigned_leb128): Don't declare.
9826         * dwarf2read.h (read_unsigned_leb128): Declare.
9827
9828 2019-05-08  Tom Tromey  <tromey@adacore.com>
9829
9830         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9831         method.
9832
9833 2019-05-08  Tom Tromey  <tromey@adacore.com>
9834
9835         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9836         when no wrap column is set.
9837
9838 2019-05-08  Tom Tromey  <tromey@adacore.com>
9839
9840         * c-lang.c (c_get_string): Handle non-C-style arrays.
9841
9842 2019-05-08  Tom Tromey  <tromey@adacore.com>
9843
9844         * typeprint.c (print_offset_data::update): Print the bit offset,
9845         not the number of bits remaining.
9846
9847 2019-05-08  Tom Tromey  <tromey@adacore.com>
9848
9849         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9850         padding at end of comment.
9851
9852 2019-05-08  Tom Tromey  <tromey@adacore.com>
9853
9854         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9855         Compare main types.
9856
9857 2019-05-06  Tom Tromey  <tom@tromey.com>
9858
9859         * common/scoped_mmap.c: Include common-defs.h.
9860         * common/scoped_mmap.h: Don't include config.h.
9861
9862 2019-05-04  Tom Tromey  <tom@tromey.com>
9863
9864         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9865         (struct aarch64_call_info): Add initializers.
9866         <si>: Now a std::vector.
9867         (pass_on_stack, aarch64_push_dummy_call): Update.
9868
9869 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9870             Tom Tromey  <tom@tromey.com>
9871
9872         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9873         (ppc_threads): Now a std::vector.  Now static.
9874         (hwdebug_find_thread_points_by_tid)
9875         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9876         Update.
9877
9878 2019-05-04  Tom Tromey  <tom@tromey.com>
9879
9880         * arc-tdep.c (arc_tdesc_init): Return bool.
9881
9882 2019-05-04  Tom Tromey  <tom@tromey.com>
9883
9884         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9885         Use gdb_assert_not_reached.
9886
9887 2019-05-04  Tom Tromey  <tom@tromey.com>
9888
9889         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9890         "false".
9891
9892 2019-05-04  Tom Tromey  <tom@tromey.com>
9893
9894         * arc-tdep.c (arc_tdesc_init): Use bool.
9895
9896 2019-05-04  Tom Tromey  <tom@tromey.com>
9897
9898         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9899
9900 2019-05-04  Tom Tromey  <tom@tromey.com>
9901
9902         * cli/cli-cmds.c (valid_command_p): Return bool.
9903
9904 2019-05-04  Tom Tromey  <tom@tromey.com>
9905
9906         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9907         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9908
9909 2019-05-04  Raul Tambre  <raul@tambre.ee>
9910
9911         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9912         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9913         operator for comparison.
9914
9915 2019-05-04  Tom Tromey  <tom@tromey.com>
9916
9917         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9918         (lookup_partial_symbol, print_partial_symbols)
9919         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9920         (psymbol_compare): Update.
9921         (add_psymbol_to_bcache): Clear the entire psymbol.
9922         (maintenance_check_psymtabs): Update.
9923         * psympriv.h (struct partial_symbol): Don't derive from
9924         general_symbol_info.
9925         <obj_section, unrelocated_address, address,
9926         set_unrelocated_address>: Update.
9927         <ginfo>: New member.
9928         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9929         (debug_names::write_psymbols): Update.
9930
9931 2019-05-04  Tom de Vries  <tdevries@suse.de>
9932
9933         * contrib/cc-with-tweaks.sh: Support -n arg.
9934
9935 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9936
9937         * corelow.c (core_target::detach): Ensure frame cache and
9938         register caches are cleared.
9939         inferior.c (exit_inferior_1): Likewise.
9940
9941 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9942             Tom Tromey  <tom@tromey.com>
9943
9944         * dictionary.c (collate_pending_symbols_by_language): Remove
9945         "struct" from foreach.
9946         * symtab.c (lookup_global_symbol_from_objfile)
9947         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9948         foreach.
9949         * ser-tcp.c (net_open): Remove "struct" from foreach.
9950         * objfiles.c (objfile_relocate, objfile_rebase)
9951         (objfile_has_symbols): Remove "struct" from foreach.
9952         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9953         from foreach.
9954         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9955         foreach.
9956         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9957         "struct" from foreach.
9958         * ada-lang.c (create_excep_cond_exprs)
9959         (ada_exception_catchpoint_cond_string): Remove "struct" from
9960         foreach.
9961
9962 2019-05-03  Tom Tromey  <tromey@adacore.com>
9963
9964         * ada-exp.y (convert_char_literal): Check suffix of each
9965         enumerator.
9966
9967 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9968
9969         PR ada/21406:
9970         * ada-exp.y (yywrap): Don't define.
9971         * ada-lex.l (%option): Add noyywrap
9972         (yywrap): Remove.
9973
9974 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9975
9976         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9977         _WIN32_WINNT to the XP level, unless already defined to a higher
9978         level.
9979
9980         * unittests/parse-connection-spec-selftests.c:
9981         * ser-tcp.c:
9982         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9983         override.
9984
9985         * symfile.c (find_separate_debug_file): Remove colon from the
9986         drive spec of DOS/Windows file names of the target, so that the
9987         file name produced from DEBUGDIR and the target's directory will
9988         be valid on DOS/Windows systems.
9989
9990 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9991
9992         * rust-lang.c (val_print_struct): Handle printing structures
9993         containing strings.
9994
9995 2019-05-02  Tom Tromey  <tromey@adacore.com>
9996
9997         * valarith.c (_initialize_valarith): Remove.
9998
9999 2019-05-01  Tom Tromey  <tromey@adacore.com>
10000
10001         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10002         bitfields.
10003
10004 2019-05-01  Tom Tromey  <tromey@adacore.com>
10005
10006         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10007         for big-endian copies.
10008
10009 2019-04-30  Ali Tamur  <tamur@google.com>
10010         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10011         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10012         (read_3_bytes): New function.
10013
10014 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10015
10016         * windows-nat.c (main_thread_id): Delete.
10017         (handle_output_debug_string): Replace main_thread_id by
10018         current_event.dwThreadId.
10019         (fake_create_process): Likewise.
10020         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10021         Do not set main_thread_id.
10022         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10023         current_event.dwThreadId.
10024         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10025
10026 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10027
10028         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10029         Use current_event.dwThreadId instead of main_thread_id.
10030
10031 2019-04-30  Tom Tromey  <tromey@adacore.com>
10032
10033         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10034         (create_excep_cond_exprs): Iterate over program spaces.
10035         (ada_exception_catchpoint_cond_string): Examine all minimal
10036         symbols for exception types.
10037
10038 2019-04-30  Tom Tromey  <tromey@adacore.com>
10039
10040         PR c++/24470:
10041         * dwarf2read.c (process_structure_scope): Handle case where type
10042         has template parameters but no symbol was created.
10043
10044 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10045             Chris January  <chris.january@arm.com>
10046
10047         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10048         qualifier.
10049         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10050
10051 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10052
10053         * f-typeprint.c (f_print_type): Update rules for printing
10054         whitespace.
10055         (f_type_print_varspec_suffix): Likewise.
10056
10057 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10058             Chris January  <chris.january@arm.com>
10059
10060         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10061         function arguments.
10062
10063 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10064
10065         * f-lang.c (build_fortran_types): Change name of void type to
10066         lower case.
10067         * f-typeprint.c (f_type_print_base): Print the name of the void
10068         type, rather than a fixed string.
10069         * f-valprint.c (f_decorations): Use lower case void string.
10070
10071 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10072             Chris January  <chris.january@arm.com>
10073
10074         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10075         types for Fortran.
10076
10077 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10078             Chris January  <chris.january@arm.com>
10079             David Lecomber  <david.lecomber@arm.com>
10080
10081         * f-exp.y (BINOP_INTRINSIC): New token.
10082         (exp): New parser rule handling BINOP_INTRINSIC.
10083         (f77_keywords): Add new builtin procedures.
10084         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10085         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10086         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10087         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10088         (print_unop_subexp_f): New function.
10089         (print_binop_subexp_f): New function.
10090         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10091         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10092         (dump_subexp_body_f): Likewise.
10093         (operator_check_f): Likewise.
10094         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10095         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10096
10097 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10098
10099         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10100         UNOP_KIND.
10101         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10102         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10103         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10104         (operator_length_f): New fuction.
10105         (print_subexp_f): New function.
10106         (op_name_f): New function.
10107         (dump_subexp_body_f): New function.
10108         (operator_check_f): New function.
10109         (exp_descriptor_f): Replace standard expression handling functions
10110         with new functions.
10111         * gdb/fortran-operator.def: New file.
10112         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10113         * gdb/std-operator.def: Remove UNOP_KIND.
10114
10115 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10116
10117         * std-operator.def: Remove unbalanced, stray double quote
10118         character.
10119
10120 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10121             Chris January  <chris.january@arm.com>
10122             Daniel Everett  <daniel.everett@arm.com>
10123             Nick Forrington  <nick.forrington@arm.com>
10124             Richard Bunt  <richard.bunt@arm.com>
10125
10126         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10127         of depth when printing anonymous structs or unions.
10128         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10129         Don't print either the top-level value, or the children if the
10130         max-depth is exceeded.
10131         (ppscm_print_children): When printing the key of a map, allow one
10132         extra level of depth.
10133         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10134         print either the top-level value, or the children if the max-depth
10135         is exceeded.
10136         (print_children): When printing the key of a map, allow one extra
10137         level of depth.
10138         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10139         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10140         (user_print_options): Initialise max_depth field.
10141         (val_print_scalar_or_string_type_p): New function.
10142         (val_print): Check to see if the max depth has been reached.
10143         (val_print_check_max_depth): Define new function.
10144         (show_print_max_depth): New function.
10145         (_initialize_valprint): Add 'print max-depth' option.
10146         * valprint.h (struct value_print_options) <max_depth>: New field.
10147         (val_print_check_max_depth): Declare new function.
10148         * NEWS: Document new feature.
10149
10150 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * ada-lang.c (ada_language_defn): Initialise new field.
10153         * c-lang.c (c_is_string_type_p): New function.
10154         (c_language_defn): Initialise new field.
10155         (cplus_language_defn): Initialise new field.
10156         (asm_language_defn): Initialise new field.
10157         (minimal_language_defn): Initialise new field.
10158         * c-lang.h (c_is_string_type_p): Declare new function.
10159         * d-lang.c (d_language_defn): Initialise new field.
10160         * f-lang.c (f_is_string_type_p): New function.
10161         (f_language_defn): Initialise new field.
10162         * go-lang.c (go_is_string_type_p): New function.
10163         (go_language_defn): Initialise new field.
10164         * language.c (default_is_string_type_p): New function.
10165         (unknown_language_defn): Initialise new field.
10166         (auto_language_defn): Initialise new field.
10167         * language.h (struct language_defn) <la_is_string_type_p>: New
10168         member variable.
10169         (default_is_string_type_p): Declare new function.
10170         * m2-lang.c (m2_language_defn): Initialise new field.
10171         * objc-lang.c (objc_language_defn): Initialise new field.
10172         * opencl-lang.c (opencl_language_defn): Initialise new field.
10173         * p-lang.c (pascal_is_string_type_p): New function.
10174         (pascal_language_defn): Initialise new field.
10175         * rust-lang.c (rust_is_string_type_p): New function.
10176         (rust_language_defn): Initialise new field.
10177
10178 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10179
10180         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10181         New field.
10182         * ada-lang.c (ada_language_defn): Initialise new field.
10183         * c-lang.c (c_language_defn): Likewise.
10184         (cplus_language_defn): Likewise.
10185         (asm_language_defn): Likewise.
10186         (minimal_language_defn): Likewise.
10187         * d-lang.c (d_language_defn): Likewise.
10188         * f-lang.c (f_language_defn): Likewise.
10189         * go-lang.c (go_language_defn): Likewise.
10190         * language.c (unknown_language_defn): Likewise.
10191         (auto_language_defn): Likewise.
10192         * m2-lang.c (m2_language_defn): Likewise.
10193         * objc-lang.c (objc_language_defn): Likewise.
10194         * opencl-lang.c (opencl_language_defn): Likewise.
10195         * p-lang.c (pascal_language_defn): Likewise.
10196         * rust-lang.c (rust_language_defn): Likewise.
10197
10198 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10199
10200         * ada-lang.c (ada_is_character_type): Change return type to bool.
10201         (ada_is_string_type): Likewise.
10202         * ada-lang.h (ada_is_character_type): Update declaration
10203         (ada_is_string_type): Likewise.
10204
10205 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10206
10207         Support style in 'frame|thread apply'
10208
10209         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10210         * record.c (record_start, record_stop): Update callers of
10211         execute_command_to_string with false.
10212         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10213         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10214         methods.
10215         (class string_file): New constructor with term_out parameter.
10216         Override methods term_out and can_emit_style_escape.  New member
10217         term_out.
10218         (class stdio_file): Override can_emit_style_escape.
10219         (class tee_file): Override term_out and can_emit_style_escape.
10220         * utils.h (can_emit_style_escape): Remove.
10221         * utils.c (can_emit_style_escape): Likewise.
10222         Update all callers of can_emit_style_escape (SOMESTREAM) to
10223         SOMESTREAM->can_emit_style_escape.
10224         * source-cache.c (source_cache::get_source_lines): Likewise.
10225         * stack.c (frame_apply_command_count): Call execute_command_to_string
10226         passing the term_out characteristic of the current gdb_stdout.
10227         * thread.c (thr_try_catch_cmd): Likewise.
10228         * top.c (execute_command_to_string): pass term_out parameter
10229         to construct the string_file for the command output.
10230         * ui-file.c (term_cli_styling): New function (most code moved
10231         from utils.c can_emit_style_escape).
10232         (string_file::string_file, string_file::can_emit_style_escape,
10233         stdio_file::can_emit_style_escape, tee_file::term_out,
10234         tee_file::can_emit_style_escape): New functions.
10235
10236 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10237
10238         * NEWS: Mention the new set|show may-call-functions.
10239         * infcall.c (may_call_functions_p): New variable.
10240         (show_may_call_functions_p): New function.
10241         (call_function_by_hand_dummy): Throws an error if not
10242         may-call-functions.
10243         (_initialize_infcall): Call add_setshow_boolean_cmd for
10244         may-call-functions.
10245
10246 2019-04-25  Keith Seitz  <keiths@redhat.com>
10247
10248         PR c++/24367
10249         * cp-support.c (inspect_type): Don't attempt substitutions
10250         of symbol with the same name.
10251
10252 2019-04-25  Tom Tromey  <tromey@adacore.com>
10253
10254         PR gdb/24475:
10255         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10256         static.
10257
10258 2019-04-25  Tom Tromey  <tromey@adacore.com>
10259
10260         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10261         rvalue reference.
10262         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10263         (gdb_xml_parser::parse): Use std::move.
10264         * python/python-internal.h (gdbpy_convert_exception): Take a const
10265         reference.
10266         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10267         std::move.
10268         * python/py-utils.c (gdbpy_convert_exception): Take a const
10269         reference.
10270         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10271         Use std::move.
10272         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10273         Use std::move.
10274         * mi/mi-main.c (mi_print_exception): Take a const reference.
10275         * main.c (handle_command_errors): Take a const reference.
10276         * linespec.c (parse_linespec): Use std::move.
10277         * infcall.c (run_inferior_call): Use std::move.
10278         (call_function_by_hand_dummy): Use std::move.
10279         * exec.c (try_open_exec_file): Use std::move.
10280         * exceptions.h (exception_print, exception_fprintf)
10281         (exception_print_same): Update.
10282         * exceptions.c (print_exception, exception_print)
10283         (exception_fprintf, exception_print_same): Change parameters to
10284         const reference.
10285         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10286         * common/new-op.c: Use std::move.
10287         * common/common-exceptions.h (struct gdb_exception): Add move
10288         constructor.
10289         (struct gdb_exception_error, struct gdb_exception_quit, struct
10290         gdb_quit_bad_alloc): Change constructor to move constructor.
10291         (throw_exception): Change parameter to rvalue reference.
10292         * common/common-exceptions.c (throw_exception): Take rvalue
10293         reference.
10294         * cli/cli-interp.c (safe_execute_command): Use std::move.
10295         * breakpoint.c (insert_bp_location, location_to_sals): Use
10296         std::move.
10297
10298 2019-04-25  Tom Tromey  <tromey@adacore.com>
10299
10300         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10301         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10302         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10303         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10304         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10305         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10306         guile/scm-value.c: Use unpack.
10307         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10308         gdbscm_gdb_exception.
10309         (gdbscm_throw_gdb_exception): Likewise.
10310         (struct gdbscm_gdb_exception): New.
10311         (unpack): New function.
10312         (gdbscm_wrap): Use unpack.
10313
10314 2019-04-25  Tom Tromey  <tromey@adacore.com>
10315
10316         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10317         (gdb_rl_callback_handler): Use std::move.
10318         * common/common-exceptions.h (struct gdb_exception): Add move
10319         assignment operator.
10320         (throw_exception_sjlj): Change "exception" to const reference.
10321         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10322         (throw_exception_sjlj): Change "exception" to const reference.
10323
10324 2019-04-25  Tom Tromey  <tromey@adacore.com>
10325
10326         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10327         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10328         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10329         Update.
10330         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10331         Update.
10332         * mi/mi-interp.c (mi_interp::exec): Update.
10333         * linespec.c (parse_linespec): Update.
10334         * infcall.c (run_inferior_call): Update.
10335         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10336         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10337         (gdbscm_lookup_global_symbol): Update.
10338         * guile/scm-param.c (gdbscm_parameter_value): Update.
10339         * guile/scm-frame.c (gdbscm_frame_read_register)
10340         (gdbscm_frame_read_var): Update.
10341         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10342         * exec.c (try_open_exec_file): Update.
10343         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10344         (gdb_rl_callback_handler): Update.
10345         * common/common-exceptions.h (exception_none): Don't declare.
10346         * common/common-exceptions.c (exception_none): Don't define.
10347         (struct catcher) <exception>: Update.
10348         * cli/cli-interp.c (safe_execute_command): Update.
10349         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10350
10351 2019-04-25  Ali Tamur  <tamur@google.com>
10352
10353         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10354         (read_attribute_value): Likewise.
10355         (dwarf2_read_addr_index): Update comment.
10356         (read_str_index): Add DW_FORM_strx.
10357         (dwarf2_string_attr): Likewise.
10358         (dwarf2_const_value_attr): Likewise.
10359         (dump_die_shallow): Likewise.
10360         (dwarf2_fetch_constant_bytes): Likewise.
10361         (skip_form_bytes): Likewise.
10362         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10363
10364 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10365
10366         PR corefiles/11608
10367         PR corefiles/18187
10368         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10369         OFFSET.  Verify if current mapping contains an ELF header.
10370         (linux_find_memory_regions_full): Adjust call to
10371         dump_mapping_p.
10372
10373 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10374             Kang Li <kanglictf@gmail.com>
10375
10376         PR gdb/21600
10377
10378         * dwarf2-frame.c (read_initial_length): Be consistent about using
10379         unsigned representation of length.
10380         (decode_frame_entry_1): Likewise.  Check for wraparound of
10381         end pointer as well as buffer overflow.
10382
10383 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10384
10385         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10386         "vq".
10387
10388 2019-04-24  Tom Tromey  <tromey@adacore.com>
10389
10390         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10391
10392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10393
10394         * s12z-tdep.c (s12z_unwind_pc): Delete.
10395         (s12z_unwind_sp): Delete.
10396         (s12z_gdbarch_init): Don't register deleted functions with
10397         gdbarch.
10398
10399 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10400
10401         * rl78-tdep.c (rl78_unwind_sp): Delete.
10402         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10403
10404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10405
10406         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10407         (xstormy16_unwind_pc): Delete.
10408         (xstormy16_dummy_id): Delete.
10409         (xstormy16_gdbarch_init): Don't register deleted functions with
10410         gdbarch.
10411
10412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10413
10414         * vax-tdep.c (vax_unwind_pc): Delete.
10415         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10416
10417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10418
10419         * v850-tdep.c (v850_unwind_sp): Delete.
10420         (v850_unwind_pc): Delete.
10421         (v850_dummy_id): Delete.
10422         (v850_gdbarch_init): Don't register deleted functions with
10423         gdbarch.
10424
10425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10426
10427         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10428         (tilegx_unwind_pc): Delete.
10429         (tilegx_unwind_dummy_id): Delete.
10430         (tilegx_gdbarch_init): Don't register deleted functions with
10431         gdbarch.
10432
10433 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10434
10435         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10436         (tic6x_dummy_id): Delete.
10437         (tic6x_gdbarch_init): Don't register deleted functions with
10438         gdbarch.
10439
10440 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10441
10442         * sparc-tdep.c (sparc_unwind_pc): Delete.
10443         (sparc32_gdbarch_init): Don't register deleted function with
10444         gdbarch.
10445
10446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10447
10448         * sh-tdep.c (sh_unwind_sp): Delete.
10449         (sh_unwind_pc): Delete.
10450         (sh_dummy_id): Delete.
10451         (sh_gdbarch_init): Don't register deleted functions with
10452         gdbarch.
10453
10454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10455
10456         * score-tdep.c (score_unwind_sp): Delete.
10457         (score_unwind_pc): Delete.
10458         (score_dummy_id): Delete.
10459         (score_gdbarch_init): Don't register deleted functions with
10460         gdbarch.
10461
10462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10463
10464         * rx-tdep.c (rx_unwind_pc): Delete.
10465         (rx_unwind_sp): Delete.
10466         (rx_dummy_id): Delete.
10467         (rx_gdbarch_init): Don't register deleted functions with
10468         gdbarch.  Update comment.
10469
10470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10471
10472         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10473         (rs6000_dummy_id): Delete.
10474         (rs6000_gdbarch_init): Don't register deleted functions with
10475         gdbarch.
10476
10477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10478
10479         * or1k-tdep.c (or1k_dummy_id): Delete.
10480         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10481
10482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10483
10484         * nios2-tdep.c (nios2_dummy_id): Delete.
10485         (nios2_unwind_sp): Delete.
10486         (nios2_gdbarch_init): Don't register deleted functions with
10487         gdbarch.
10488
10489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10490
10491         * nds32-tdep.c (nds32_dummy_id): Delete.
10492         (nds32_unwind_pc): Delete.
10493         (nds32_unwind_sp): Delete.
10494         (nds32_gdbarch_init): Don't register deleted functions with
10495         gdbarch.
10496
10497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10498
10499         * msp430-tdep.c (msp430_unwind_pc): Delete.
10500         (msp430_unwind_sp): Delete.
10501         (msp430_dummy_id): Delete.
10502         (msp430_gdbarch_init): Don't register deleted functions with
10503         gdbarch.
10504
10505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10506
10507         * moxie-tdep.c (moxie_unwind_sp): Delete.
10508         (moxie_unwind_pc): Delete.
10509         (moxie_dummy_id): Delete.
10510         (moxie_gdbarch_init): Don't register deleted functions with
10511         gdbarch.
10512
10513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10514
10515         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10516         (mn10300_unwind_pc): Delete.
10517         (mn10300_unwind_sp): Delete.
10518         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10519         mn10300_unwind_sp.
10520         (mn10300_frame_unwind_init): Don't register deleted functions with
10521         gdbarch.
10522
10523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10524
10525         * mep-tdep.c (mep_unwind_pc): Delete.
10526         (mep_unwind_sp): Delete.
10527         (mep_dummy_id): Delete.
10528         (mep_gdbarch_init): Don't register deleted functions with
10529         gdbarch.
10530
10531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10532
10533         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10534         (m68hc11_unwind_sp): Delete.
10535         (m68hc11_gdbarch_init): Don't register deleted functions with
10536         gdbarch.
10537
10538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10539
10540         * m32r-tdep.c (m32r_unwind_sp): Delete.
10541         (m32r_unwind_pc): Delete.
10542         (m32r_dummy_id): Delete.
10543         (m32r_gdbarch_init): Don't register deleted functions with
10544         gdbarch.
10545
10546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10547
10548         * m32c-tdep.c (m32c_unwind_pc): Delete.
10549         (m32c_unwind_sp): Delete.
10550         (m32c_dummy_id): Delete.
10551         (m32c_gdbarch_init): Don't register deleted functions with
10552         gdbarch.
10553
10554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10555
10556         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10557         (lm32_unwind_pc): Delete.
10558         (lm32_dummy_id): Delete.
10559         (lm32_gdbarch_init): Don't register deleted functions with
10560         gdbarch.
10561
10562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10563
10564         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10565         (iq2000_unwind_pc): Delete.
10566         (iq2000_dummy_id): Delete.
10567         (iq2000_gdbarch_init): Don't register deleted functions with
10568         gdbarch.
10569
10570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10571
10572         * nds32-tdep.c (nds32_type_align): Delete.
10573         (nds32_push_dummy_call): Use type_align instead.
10574
10575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10576
10577         * arm-tdep.c (arm_type_align): Only handle vector override case.
10578         (arm_push_dummy_call): Use type_align.
10579         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10580
10581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10582
10583         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10584         case.
10585         (pass_on_stack): Use type_align.
10586         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10587         function.
10588
10589 2019-04-23  Tom Tromey  <tromey@adacore.com>
10590
10591         * dwarf2read.c (line_header::file_name_at): Remove unused
10592         overload.
10593
10594 2019-04-23  Tom de Vries  <tdevries@suse.de>
10595
10596         PR gdb/24438
10597         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10598         invocation.
10599
10600
10601 2019-03-27  Ali Tamur  <tamur@google.com>
10602
10603         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10604         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10605         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10606         (dwarf_expr_context::get_addr_index): Likewise
10607         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10608         (symbol_needs_eval_context::get_addr_index): Likewise
10609         (disassemble_dwarf_expression): Add DW_OP_addrx
10610         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10611         (read_cutu_die_from_dwo): Update comment
10612         (skip_one_die): Add DW_FORM_addrx
10613         (read_attribute_value): Likewise
10614         (var_decode_location): Add DW_OP_addrx
10615         (dwarf2_const_value_attr): Add DW_FORM_addrx
10616         (dump_die_shallow): Likewise
10617         (dwarf2_fetch_constant_bytes): Likewise
10618         (decode_locdesc): Add DW_OP_addrx
10619         (skip_form_bytes): Add DW_FORM_addrx
10620
10621 2019-04-22  Ali Tamur  <tamur@google.com>
10622
10623         * MAINTAINERS (Write After Approval): Add self.
10624
10625 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10626
10627         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10628         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10629         (open_symbol_file_object): Likewise.
10630         (svr4_default_sos): Add info parameter.
10631         (svr4_read_so_list): Likewise.
10632         (svr4_current_sos_direct): Adjust functions calls to pass down
10633         info.
10634         (svr4_current_sos_1): Add info parameter.
10635         (svr4_current_sos): Call get_svr4_info, pass info down to
10636         svr4_current_sos_1.
10637         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10638         get_svr4_info.
10639         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10640         get_svr4_info.
10641         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10642         to get_svr4_info.
10643         (probes_table_remove_objfile_probes): Likewise.
10644         (register_solib_event_probe): Add info parameter.
10645         (solist_update_incremental): Pass info parameter down to
10646         svr4_read_so_list.
10647         (disable_probes_interface): Add info parameter.
10648         (svr4_handle_solib_event): Pass current_program_space to
10649         get_svr4_info.  Adjust disable_probes_interface cleanup.
10650         (svr4_create_probe_breakpoints): Add info parameter, pass it
10651         down to register_solib_event_probe.
10652         (svr4_create_solib_event_breakpoints): Add info parameter,
10653         pass it down to svr4_create_probe_breakpoints.
10654         (enable_break): Pass info down to
10655         svr4_create_solib_event_breakpoints.
10656         (svr4_solib_create_inferior_hook): Pass current_program_space to
10657         get_svr4_info.
10658         (svr4_clear_solib): Likewise.
10659
10660 2019-04-22  Pedro Alves  <palves@redhat.com>
10661
10662         * solib-svr4.c (svr4_free_objfile_observer): New.
10663         (probe_and_action::objfile): New field.
10664         (probes_table_htab_remove_objfile_probes)
10665         (probes_table_remove_objfile_probes): New functions.
10666         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10667         in the new probe_and_action.  Don't store the probe in 'lookup'.
10668         (svr4_create_probe_breakpoints): Pass objfile to
10669         register_solib_event_probe.
10670         (_initialize_svr4_solib): Register a free_objfile observer.
10671
10672 2019-04-19  Tom Tromey  <tom@tromey.com>
10673
10674         * common/queue.h: Remove.
10675
10676 2019-04-19  Tom Tromey  <tom@tromey.com>
10677
10678         * event-loop.c: Don't include "common/queue.h".
10679
10680 2019-04-19  Tom Tromey  <tom@tromey.com>
10681
10682         * remote.c (remote_target): Use delete.
10683         * remote-notif.h: Include <list>, not "common/queue.h".
10684         (notif_client_p): Remove typedef.
10685         (remote_notif_state): Add constructor, destructor, initializer.
10686         <notif_queue>: Now a std::list.
10687         (remote_notif_state_xfree): Don't declare.
10688         * remote-notif.c (remote_notif_process, handle_notification)
10689         (remote_notif_state_allocate): Update.
10690         (~remote_notif_state): Rename from remote_notif_state_xfree.
10691
10692 2019-04-19  Tom Tromey  <tom@tromey.com>
10693
10694         * symfile.c (reread_symbols): Update.
10695         * objfiles.c (objfile_register_static_link)
10696         (objfile_lookup_static_link): Update
10697         (~objfile) Don't delete static_links.
10698         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10699
10700 2019-04-19  Tom Tromey  <tom@tromey.com>
10701
10702         * type-stack.h (struct type_stack) <insert>: Constify string.
10703         * type-stack.c (type_stack::insert): Constify string.
10704         * gdbtypes.h (lookup_template_type): Update.
10705         (address_space_name_to_int): Update.
10706         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10707         const.
10708         (lookup_template_type): Make name const.
10709         * c-exp.y: Update rules.
10710         (lex_one_token, classify_name, classify_inner_name)
10711         (c_print_token): Update.
10712         * p-exp.y: Update rules.
10713         (yylex): Update.
10714         * f-exp.y: Update rules.
10715         (yylex): Update.
10716         * d-exp.y: Update rules.
10717         (lex_one_token, classify_name, classify_inner_name): Update.
10718         * parse.c (write_dollar_variable, copy_name): Return std::string.
10719         * parser-defs.h (copy_name): Change return type.
10720         * m2-exp.y: Update rules.
10721         (yylex): Update.
10722         * go-exp.y (lex_one_token): Update.
10723         Update rules.
10724         (classify_unsafe_function, classify_packaged_name)
10725         (classify_name, yylex): Update.
10726
10727 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10728
10729         * configure.ac: add --enable-source-highlight switch.
10730         * configure: Regenerate.
10731         * top.c (print_gdb_version): plumb --enable-source-highlight
10732         status to "show configuration".
10733
10734 2019-04-19  Tom Tromey  <tromey@adacore.com>
10735
10736         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10737         Check ADA_TYPE_P.
10738         (empty_record, ada_template_to_fixed_record_type_1)
10739         (template_to_static_fixed_type)
10740         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10741         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10742         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10743         macros.
10744
10745 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10746
10747         PR symtab/24423:
10748         * source.c (print_source_lines_base): Advance "iter" when a
10749         control character is seen.
10750
10751 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10752
10753         * inferior.h (struct infcall_suspend_state_deleter):
10754         Catch exception in destructor to avoid crash.
10755
10756 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10757
10758         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10759         close to the add_com "shell".
10760
10761 2019-04-18  Tom Tromey  <tromey@adacore.com>
10762
10763         * process-stratum-target.h (class process_stratum_target)
10764         <stratum>: Add "final".
10765
10766 2019-04-17  Tom Tromey  <tromey@adacore.com>
10767
10768         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10769         against nullptr before use.
10770
10771 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10772
10773         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10774
10775 2019-04-17  Jim Wilson  <jimw@sifive.com>
10776             Andrew Burgess  <andrew.burgess@embecosm.com>
10777
10778         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10779         code read might fail, assume 4-byte breakpoint in that case.
10780
10781 2019-04-15  Leszek Swirski  <leszeks@google.com>
10782
10783         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10784         rather than a hand-rolled POD check when checking for forced MEMORY
10785         classification.
10786
10787 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10788
10789         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10790         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10791         function.
10792         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10793         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10794         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10795         declaration.
10796
10797 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10798
10799         * aarch64-linux-nat.c
10800         (aarch64_linux_nat_target::thread_architecture): Add override.
10801         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10802         each VQ.
10803
10804 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10805
10806         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10807
10808 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10809
10810         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10811         target types of size 96-bits, add some additional comments, and
10812         check that the builtin type we found was the correct size.
10813
10814 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10815
10816         * utils.c (prompt_for_continue): Don't restore the styling at the
10817         end, as applied_style has the wrong value.  This fixes styling in
10818         long lists of file names that are interrupted by the "Continue?"
10819         prompt.
10820
10821 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10822
10823         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10824         * c-lang.c (c_language_defn): Likewise.
10825         (cplus_language_defn): Likewise.
10826         (asm_language_defn): Likewise.
10827         (minimal_language_defn): Likewise.
10828         * d-lang.c (d_language_defn): Likewise.
10829         * f-lang.c (f_language_defn): Likewise.
10830         * go-lang.c (go_language_defn): Likewise.
10831         * language.c (unknown_language_defn): Likewise.
10832         (auto_language_defn): Likewise.
10833         * language.h (struct language_defn): Remove la_magic field.
10834         (LANG_MAGIC): Delete.
10835         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10836         * objc-lang.c (objc_language_defn): Likewise.
10837         * opencl-lang.c (opencl_language_defn): Likewise.
10838         * p-lang.c (pascal_language_defn): Likewise.
10839         * rust-lang.c (rust_language_defn): Likewise.
10840
10841 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10842
10843         * riscv-tdep.c (riscv_type_align): New function.
10844         (riscv_type_alignment): Delete.
10845         (riscv_arg_location): Use 'type_align'.
10846         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10847
10848 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10849
10850         * gdbtypes.c (type_align): A struct with no non-static fields also
10851         has alignment of 1.
10852
10853 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10854
10855         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10856         component to 0.
10857         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10858         member.
10859         (riscv_struct_info::analyse): New implementation using new
10860         analyse_inner member function.
10861         (riscv_struct_info::field_offset): New member function.
10862         (riscv_struct_info::m_offsets): New member variable.
10863         (riscv_struct_info::analyse_inner): New private member function,
10864         takes the old implementation of riscv_struct_info::analyse but
10865         extended to track field offsets.
10866         (riscv_call_arg_struct): Update the struct folding special cases
10867         to handle cases where empty C++ structs, which are non-zero
10868         length, are found.
10869         (riscv_arg_location): Initialise the length of each location, a
10870         non-zero length now indicates the location is in use.
10871         (riscv_push_dummy_call): Allow for the first location having a
10872         non-zero offset when setting up arguments.
10873         (riscv_return_value): Likewise, but for return values.
10874
10875 2019-04-11  Tom Tromey  <tromey@adacore.com>
10876
10877         * utils.c (internal_vproblem): Make "msg" const.
10878
10879 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10880
10881         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10882         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10883         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10884         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10885
10886 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10887
10888         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10889         function.
10890         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10891         of amd64_collect_native_gregset.
10892         (amd64_linux_nat_target::store_registers): Likewise.
10893
10894 2019-04-10  Tom Tromey  <tom@tromey.com>
10895
10896         * symtab.c (lookup_global_symbol_from_objfile)
10897         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10898         * objfiles.h (class separate_debug_iterator): New.
10899         (class separate_debug_range): New.
10900         (struct objfile) <separate_debug_objfiles>: New method.
10901         (objfile_separate_debug_iterate): Don't declare.
10902         * objfiles.c (separate_debug_iterator::operator++): Rename from
10903         objfile_separate_debug_iterate.
10904         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10905         iterator.
10906         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10907         iterator.
10908
10909 2019-04-10  Tom Tromey  <tom@tromey.com>
10910
10911         * symfile.c (reread_symbols): Remove old comment.
10912         * objfiles.c (free_all_objfiles): Fix a typo.
10913
10914 2019-04-10  Tom Tromey  <tom@tromey.com>
10915
10916         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10917         * minsyms.c (lookup_minimal_symbol): Use foreach.
10918         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10919         (lookup_minimal_symbol_solib_trampoline): Likewise.
10920         * symfile.c (reread_symbols): Use foreach.
10921
10922 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10923             Tom Tromey  <tromey@adacore.com>
10924
10925         PR rust/24414:
10926         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10927         (rust_lex_int_test): Change "value" to be LONGEST.
10928         (rust_lex_tests): Add test for long integer literal.
10929
10930 2019-04-09  Tom Tromey  <tromey@adacore.com>
10931
10932         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10933         to bool.
10934         (extended_remote_target::attach): Update.
10935         (remote_target::remote_notice_new_inferior): Update.
10936         (remote_target::add_current_inferior_and_thread): Update.
10937         * inferior.c (exit_inferior_1): Use "false".
10938         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10939
10940 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10941
10942         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10943         the "start" command.
10944
10945 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10946
10947         * python/py-inferior.c (infpy_thread_from_thread_handle):
10948         Adjust comments to reflect renaming of thread_from_thread_handle
10949         to thread_from_handle.  Adjust keywords.  Fix type error message.
10950         (inferior_object_methods): Add thread_from_handle.  Retain
10951         thread_from_thread_handle, but mark it as deprecated.
10952
10953 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10954
10955         * gdbthread.h (find_thread_by_handle): Revise declaration.
10956         * thread.c (find_thread_by_handle): Likewise.  Adjust
10957         implementation too.
10958         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10959         support for buffer objects as handles.
10960
10961 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10962
10963         * python/py-infthread.c (thpy_thread_handle): New function.
10964         (thread_object_methods): Register thpy_thread_handle.
10965
10966 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10967
10968         * gdbthread.h (thread_to_thread_handle): Declare.
10969         * thread.c (gdbtypes.h): Include.
10970         (thread_to_thread_handle): New function.
10971
10972         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10973         (target_thread_info_to_thread_handle): Declare.
10974         * target.c (target_thread_info_to_thread_handle): New function.
10975         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10976         * target-delegates.c: Regenerate.
10977
10978         * linux-thread-db.c (class thread_db_target): Add method
10979         thread_info_to_thread_handle.
10980         (thread_db_target::thread_info_to_thread_handle): Define.
10981         * remote.c (class remote_target): Add new method
10982         thread_info_to_thread_handle.
10983         (remote_target::thread_info_to_thread_handle): Define.
10984
10985 2019-04-08  Pedro Alves  <palves@redhat.com>
10986
10987         * common/common-exceptions.c (throw_exception): Don't create
10988         named object to throw; throw directly.
10989         (throw_it): Likewise.  Don't initialize gdb_exception::message
10990         here, with new; pass FMT and AP to the ctor instead.
10991         * common/common-exceptions.h: Include <string>.
10992         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10993         const char *, va_list)): New ctor.  Use std::make_shared.
10994         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10995         errors)): Delete.
10996         (gdb_exception_error::gdb_exception_error(enum errors, const char
10997         *, va_list)): New.
10998         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10999         Add assertion.
11000         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11001         errors)): Delete.
11002         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11003         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11004         Add assertion.
11005
11006 2019-04-08  Tom Tromey  <tom@tromey.com>
11007
11008         * valops.c (value_rtti_indirect_type): Replace throw_exception
11009         with throw.
11010         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11011         with throw.
11012         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11013         throw.
11014         * target.c (target_translate_tls_address): Replace throw_exception
11015         with throw.
11016         * stack.c (frame_apply_command_count): Replace throw_exception
11017         with throw.
11018         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11019         throw.
11020         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11021         with throw.
11022         * rs6000-tdep.c (rs6000_frame_cache)
11023         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11024         * remote.c: Replace throw_exception with throw.
11025         * record-full.c (record_full_message, record_full_wait_1)
11026         (record_full_restore): Replace throw_exception with throw.
11027         * record-btrace.c:
11028         (get_thread_current_frame_id, record_btrace_start_replaying)
11029         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11030         (cmd_record_btrace_start): Replace throw_exception with throw.
11031         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11032         throw.
11033         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11034         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11035         * linespec.c:
11036         (find_linespec_symbols): Replace throw_exception with throw.
11037         * infrun.c (displaced_step_prepare, resume): Replace
11038         throw_exception with throw.
11039         * infcmd.c (post_create_inferior): Replace throw_exception with
11040         throw.
11041         * inf-loop.c (inferior_event_handler): Replace throw_exception
11042         with throw.
11043         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11044         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11045         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11046         (get_prev_frame_always, get_frame_pc_if_available)
11047         (get_frame_address_in_block_if_available, get_frame_language):
11048         Replace throw_exception with throw.
11049         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11050         throw_exception with throw.
11051         * eval.c (fetch_subexp_value, evaluate_var_value)
11052         (evaluate_funcall, evaluate_subexp_standard): Replace
11053         throw_exception with throw.
11054         * dwarf2loc.c (call_site_find_chain)
11055         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11056         Replace throw_exception with throw.
11057         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11058         with throw.
11059         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11060         throw.
11061         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11062         * completer.c (complete_line_internal): Replace throw_exception
11063         with throw.
11064         * compile/compile-object-run.c (compile_object_run): Replace
11065         throw_exception with throw.
11066         * cli/cli-script.c (process_next_line): Replace throw_exception
11067         with throw.
11068         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11069         (btrace_enable, btrace_maint_update_pt_packets): Replace
11070         throw_exception with throw.
11071         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11072         throw_exception with throw.
11073         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11074         throw_exception with throw.
11075         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11076         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11077         * aarch64-tdep.c (aarch64_make_prologue_cache)
11078         (aarch64_make_stub_cache): Replace throw_exception with throw.
11079
11080 2019-04-08  Tom Tromey  <tom@tromey.com>
11081
11082         * common/common-exceptions.c (throw_exception): Rename from
11083         throw_exception_cxx.  Remove old copy.  Make argument const.
11084         (throw_it): Create and throw exception objects directly.
11085         * common/common-exceptions.h (throw_exception): Make argument
11086         const.
11087         (struct gdb_exception_error): Add constructor.
11088         (struct gdb_exception_quit): Add constructor.
11089
11090 2019-04-08  Tom Tromey  <tom@tromey.com>
11091
11092         * common/common-exceptions.h (exception_rethrow): Don't declare.
11093         (TRY_SJLJ): Update comment.
11094         (TRY, CATCH, END_CATCH): Remove.
11095         * common/common-exceptions.c (exception_rethrow): Remove.
11096
11097 2019-04-08  Tom Tromey  <tom@tromey.com>
11098
11099         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11100         Remove.
11101         (gdb_exception_error): Rename from
11102         gdb_exception_RETURN_MASK_ERROR.
11103         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11104         (gdb_quit_bad_alloc): Update.
11105         * aarch64-tdep.c: Update.
11106         * ada-lang.c: Update.
11107         * ada-typeprint.c: Update.
11108         * ada-valprint.c: Update.
11109         * amd64-tdep.c: Update.
11110         * arch-utils.c: Update.
11111         * break-catch-throw.c: Update.
11112         * breakpoint.c: Update.
11113         * btrace.c: Update.
11114         * c-varobj.c: Update.
11115         * cli/cli-cmds.c: Update.
11116         * cli/cli-interp.c: Update.
11117         * cli/cli-script.c: Update.
11118         * common/common-exceptions.c: Update.
11119         * common/new-op.c: Update.
11120         * common/selftest.c: Update.
11121         * compile/compile-c-symbols.c: Update.
11122         * compile/compile-cplus-symbols.c: Update.
11123         * compile/compile-object-load.c: Update.
11124         * compile/compile-object-run.c: Update.
11125         * completer.c: Update.
11126         * corelow.c: Update.
11127         * cp-abi.c: Update.
11128         * cp-support.c: Update.
11129         * cp-valprint.c: Update.
11130         * darwin-nat.c: Update.
11131         * disasm-selftests.c: Update.
11132         * dtrace-probe.c: Update.
11133         * dwarf-index-cache.c: Update.
11134         * dwarf-index-write.c: Update.
11135         * dwarf2-frame-tailcall.c: Update.
11136         * dwarf2-frame.c: Update.
11137         * dwarf2loc.c: Update.
11138         * dwarf2read.c: Update.
11139         * eval.c: Update.
11140         * event-loop.c: Update.
11141         * event-top.c: Update.
11142         * exec.c: Update.
11143         * f-valprint.c: Update.
11144         * fbsd-tdep.c: Update.
11145         * frame-unwind.c: Update.
11146         * frame.c: Update.
11147         * gdbtypes.c: Update.
11148         * gnu-v3-abi.c: Update.
11149         * guile/guile-internal.h: Update.
11150         * guile/scm-block.c: Update.
11151         * guile/scm-breakpoint.c: Update.
11152         * guile/scm-cmd.c: Update.
11153         * guile/scm-disasm.c: Update.
11154         * guile/scm-frame.c: Update.
11155         * guile/scm-lazy-string.c: Update.
11156         * guile/scm-math.c: Update.
11157         * guile/scm-param.c: Update.
11158         * guile/scm-ports.c: Update.
11159         * guile/scm-pretty-print.c: Update.
11160         * guile/scm-symbol.c: Update.
11161         * guile/scm-symtab.c: Update.
11162         * guile/scm-type.c: Update.
11163         * guile/scm-value.c: Update.
11164         * i386-linux-tdep.c: Update.
11165         * i386-tdep.c: Update.
11166         * inf-loop.c: Update.
11167         * infcall.c: Update.
11168         * infcmd.c: Update.
11169         * infrun.c: Update.
11170         * jit.c: Update.
11171         * language.c: Update.
11172         * linespec.c: Update.
11173         * linux-fork.c: Update.
11174         * linux-nat.c: Update.
11175         * linux-tdep.c: Update.
11176         * linux-thread-db.c: Update.
11177         * main.c: Update.
11178         * mi/mi-cmd-break.c: Update.
11179         * mi/mi-cmd-stack.c: Update.
11180         * mi/mi-interp.c: Update.
11181         * mi/mi-main.c: Update.
11182         * objc-lang.c: Update.
11183         * p-valprint.c: Update.
11184         * parse.c: Update.
11185         * ppc-linux-tdep.c: Update.
11186         * printcmd.c: Update.
11187         * python/py-arch.c: Update.
11188         * python/py-breakpoint.c: Update.
11189         * python/py-cmd.c: Update.
11190         * python/py-finishbreakpoint.c: Update.
11191         * python/py-frame.c: Update.
11192         * python/py-framefilter.c: Update.
11193         * python/py-gdb-readline.c: Update.
11194         * python/py-inferior.c: Update.
11195         * python/py-infthread.c: Update.
11196         * python/py-lazy-string.c: Update.
11197         * python/py-linetable.c: Update.
11198         * python/py-objfile.c: Update.
11199         * python/py-param.c: Update.
11200         * python/py-prettyprint.c: Update.
11201         * python/py-progspace.c: Update.
11202         * python/py-record-btrace.c: Update.
11203         * python/py-record.c: Update.
11204         * python/py-symbol.c: Update.
11205         * python/py-type.c: Update.
11206         * python/py-unwind.c: Update.
11207         * python/py-utils.c: Update.
11208         * python/py-value.c: Update.
11209         * python/python.c: Update.
11210         * record-btrace.c: Update.
11211         * record-full.c: Update.
11212         * remote-fileio.c: Update.
11213         * remote.c: Update.
11214         * riscv-tdep.c: Update.
11215         * rs6000-aix-tdep.c: Update.
11216         * rs6000-tdep.c: Update.
11217         * rust-exp.y: Update.
11218         * rust-lang.c: Update.
11219         * s390-tdep.c: Update.
11220         * selftest-arch.c: Update.
11221         * solib-dsbt.c: Update.
11222         * solib-frv.c: Update.
11223         * solib-spu.c: Update.
11224         * solib-svr4.c: Update.
11225         * solib.c: Update.
11226         * sparc64-linux-tdep.c: Update.
11227         * stack.c: Update.
11228         * symfile-mem.c: Update.
11229         * symmisc.c: Update.
11230         * target.c: Update.
11231         * thread.c: Update.
11232         * top.c: Update.
11233         * tracefile-tfile.c: Update.
11234         * tui/tui.c: Update.
11235         * typeprint.c: Update.
11236         * unittests/cli-utils-selftests.c: Update.
11237         * unittests/parse-connection-spec-selftests.c: Update.
11238         * valops.c: Update.
11239         * valprint.c: Update.
11240         * value.c: Update.
11241         * varobj.c: Update.
11242         * windows-nat.c: Update.
11243         * x86-linux-nat.c: Update.
11244         * xml-support.c: Update.
11245
11246 2019-04-08  Tom Tromey  <tom@tromey.com>
11247
11248         * xml-support.c: Use C++ exception handling.
11249         * x86-linux-nat.c: Use C++ exception handling.
11250         * windows-nat.c: Use C++ exception handling.
11251         * varobj.c: Use C++ exception handling.
11252         * value.c: Use C++ exception handling.
11253         * valprint.c: Use C++ exception handling.
11254         * valops.c: Use C++ exception handling.
11255         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11256         handling.
11257         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11258         * typeprint.c: Use C++ exception handling.
11259         * tui/tui.c: Use C++ exception handling.
11260         * tracefile-tfile.c: Use C++ exception handling.
11261         * top.c: Use C++ exception handling.
11262         * thread.c: Use C++ exception handling.
11263         * target.c: Use C++ exception handling.
11264         * symmisc.c: Use C++ exception handling.
11265         * symfile-mem.c: Use C++ exception handling.
11266         * stack.c: Use C++ exception handling.
11267         * sparc64-linux-tdep.c: Use C++ exception handling.
11268         * solib.c: Use C++ exception handling.
11269         * solib-svr4.c: Use C++ exception handling.
11270         * solib-spu.c: Use C++ exception handling.
11271         * solib-frv.c: Use C++ exception handling.
11272         * solib-dsbt.c: Use C++ exception handling.
11273         * selftest-arch.c: Use C++ exception handling.
11274         * s390-tdep.c: Use C++ exception handling.
11275         * rust-lang.c: Use C++ exception handling.
11276         * rust-exp.y: Use C++ exception handling.
11277         * rs6000-tdep.c: Use C++ exception handling.
11278         * rs6000-aix-tdep.c: Use C++ exception handling.
11279         * riscv-tdep.c: Use C++ exception handling.
11280         * remote.c: Use C++ exception handling.
11281         * remote-fileio.c: Use C++ exception handling.
11282         * record-full.c: Use C++ exception handling.
11283         * record-btrace.c: Use C++ exception handling.
11284         * python/python.c: Use C++ exception handling.
11285         * python/py-value.c: Use C++ exception handling.
11286         * python/py-utils.c: Use C++ exception handling.
11287         * python/py-unwind.c: Use C++ exception handling.
11288         * python/py-type.c: Use C++ exception handling.
11289         * python/py-symbol.c: Use C++ exception handling.
11290         * python/py-record.c: Use C++ exception handling.
11291         * python/py-record-btrace.c: Use C++ exception handling.
11292         * python/py-progspace.c: Use C++ exception handling.
11293         * python/py-prettyprint.c: Use C++ exception handling.
11294         * python/py-param.c: Use C++ exception handling.
11295         * python/py-objfile.c: Use C++ exception handling.
11296         * python/py-linetable.c: Use C++ exception handling.
11297         * python/py-lazy-string.c: Use C++ exception handling.
11298         * python/py-infthread.c: Use C++ exception handling.
11299         * python/py-inferior.c: Use C++ exception handling.
11300         * python/py-gdb-readline.c: Use C++ exception handling.
11301         * python/py-framefilter.c: Use C++ exception handling.
11302         * python/py-frame.c: Use C++ exception handling.
11303         * python/py-finishbreakpoint.c: Use C++ exception handling.
11304         * python/py-cmd.c: Use C++ exception handling.
11305         * python/py-breakpoint.c: Use C++ exception handling.
11306         * python/py-arch.c: Use C++ exception handling.
11307         * printcmd.c: Use C++ exception handling.
11308         * ppc-linux-tdep.c: Use C++ exception handling.
11309         * parse.c: Use C++ exception handling.
11310         * p-valprint.c: Use C++ exception handling.
11311         * objc-lang.c: Use C++ exception handling.
11312         * mi/mi-main.c: Use C++ exception handling.
11313         * mi/mi-interp.c: Use C++ exception handling.
11314         * mi/mi-cmd-stack.c: Use C++ exception handling.
11315         * mi/mi-cmd-break.c: Use C++ exception handling.
11316         * main.c: Use C++ exception handling.
11317         * linux-thread-db.c: Use C++ exception handling.
11318         * linux-tdep.c: Use C++ exception handling.
11319         * linux-nat.c: Use C++ exception handling.
11320         * linux-fork.c: Use C++ exception handling.
11321         * linespec.c: Use C++ exception handling.
11322         * language.c: Use C++ exception handling.
11323         * jit.c: Use C++ exception handling.
11324         * infrun.c: Use C++ exception handling.
11325         * infcmd.c: Use C++ exception handling.
11326         * infcall.c: Use C++ exception handling.
11327         * inf-loop.c: Use C++ exception handling.
11328         * i386-tdep.c: Use C++ exception handling.
11329         * i386-linux-tdep.c: Use C++ exception handling.
11330         * guile/scm-value.c: Use C++ exception handling.
11331         * guile/scm-type.c: Use C++ exception handling.
11332         * guile/scm-symtab.c: Use C++ exception handling.
11333         * guile/scm-symbol.c: Use C++ exception handling.
11334         * guile/scm-pretty-print.c: Use C++ exception handling.
11335         * guile/scm-ports.c: Use C++ exception handling.
11336         * guile/scm-param.c: Use C++ exception handling.
11337         * guile/scm-math.c: Use C++ exception handling.
11338         * guile/scm-lazy-string.c: Use C++ exception handling.
11339         * guile/scm-frame.c: Use C++ exception handling.
11340         * guile/scm-disasm.c: Use C++ exception handling.
11341         * guile/scm-cmd.c: Use C++ exception handling.
11342         * guile/scm-breakpoint.c: Use C++ exception handling.
11343         * guile/scm-block.c: Use C++ exception handling.
11344         * guile/guile-internal.h: Use C++ exception handling.
11345         * gnu-v3-abi.c: Use C++ exception handling.
11346         * gdbtypes.c: Use C++ exception handling.
11347         * frame.c: Use C++ exception handling.
11348         * frame-unwind.c: Use C++ exception handling.
11349         * fbsd-tdep.c: Use C++ exception handling.
11350         * f-valprint.c: Use C++ exception handling.
11351         * exec.c: Use C++ exception handling.
11352         * event-top.c: Use C++ exception handling.
11353         * event-loop.c: Use C++ exception handling.
11354         * eval.c: Use C++ exception handling.
11355         * dwarf2read.c: Use C++ exception handling.
11356         * dwarf2loc.c: Use C++ exception handling.
11357         * dwarf2-frame.c: Use C++ exception handling.
11358         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11359         * dwarf-index-write.c: Use C++ exception handling.
11360         * dwarf-index-cache.c: Use C++ exception handling.
11361         * dtrace-probe.c: Use C++ exception handling.
11362         * disasm-selftests.c: Use C++ exception handling.
11363         * darwin-nat.c: Use C++ exception handling.
11364         * cp-valprint.c: Use C++ exception handling.
11365         * cp-support.c: Use C++ exception handling.
11366         * cp-abi.c: Use C++ exception handling.
11367         * corelow.c: Use C++ exception handling.
11368         * completer.c: Use C++ exception handling.
11369         * compile/compile-object-run.c: Use C++ exception handling.
11370         * compile/compile-object-load.c: Use C++ exception handling.
11371         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11372         * compile/compile-c-symbols.c: Use C++ exception handling.
11373         * common/selftest.c: Use C++ exception handling.
11374         * common/new-op.c: Use C++ exception handling.
11375         * cli/cli-script.c: Use C++ exception handling.
11376         * cli/cli-interp.c: Use C++ exception handling.
11377         * cli/cli-cmds.c: Use C++ exception handling.
11378         * c-varobj.c: Use C++ exception handling.
11379         * btrace.c: Use C++ exception handling.
11380         * breakpoint.c: Use C++ exception handling.
11381         * break-catch-throw.c: Use C++ exception handling.
11382         * arch-utils.c: Use C++ exception handling.
11383         * amd64-tdep.c: Use C++ exception handling.
11384         * ada-valprint.c: Use C++ exception handling.
11385         * ada-typeprint.c: Use C++ exception handling.
11386         * ada-lang.c: Use C++ exception handling.
11387         * aarch64-tdep.c: Use C++ exception handling.
11388
11389 2019-04-08  Tom Tromey  <tom@tromey.com>
11390
11391         * xml-support.c (gdb_xml_parser::parse): Update.
11392         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11393         * value.c (show_convenience): Update.
11394         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11395         (test_parse_flags_qcs): Update.
11396         * thread.c (thr_try_catch_cmd): Update.
11397         * target.c (target_translate_tls_address): Update.
11398         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11399         (info_frame_command_core, frame_apply_command_count): Update.
11400         * rust-exp.y (rust_lex_exception_test): Update.
11401         * riscv-tdep.c (riscv_print_one_register_info): Update.
11402         * remote.c (remote_target::enable_btrace): Update.
11403         * record-btrace.c (record_btrace_enable_warn): Update.
11404         * python/py-utils.c (gdbpy_convert_exception): Update.
11405         * printcmd.c (do_one_display, print_variable_and_value): Update.
11406         * mi/mi-main.c (mi_print_exception): Update.
11407         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11408         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11409         * linux-nat.c (linux_nat_target::attach): Update.
11410         * linux-fork.c (class scoped_switch_fork_info): Update.
11411         * infrun.c (displaced_step_prepare): Update.
11412         * infcall.c (call_function_by_hand_dummy): Update.
11413         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11414         * gnu-v3-abi.c (print_one_vtable): Update.
11415         * frame.c (get_prev_frame_always): Update.
11416         * f-valprint.c (info_common_command_for_block): Update.
11417         * exec.c (try_open_exec_file): Update.
11418         * exceptions.c (print_exception, exception_print)
11419         (exception_fprintf, exception_print_same): Update.
11420         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11421         * dwarf-index-cache.c (index_cache::store)
11422         (index_cache::lookup_gdb_index): Update.
11423         * darwin-nat.c (maybe_cache_shell): Update.
11424         * cp-valprint.c (cp_print_value_fields): Update.
11425         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11426         (gcc_cplus_symbol_address): Update.
11427         * compile/compile-c-symbols.c (gcc_convert_symbol)
11428         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11429         * common/selftest.c: Update.
11430         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11431         a std::string.
11432         (exception_try_scope_entry, exception_try_scope_exit): Don't
11433         declare.
11434         (struct exception_try_scope): Remove.
11435         (TRY): Don't use exception_try_scope.
11436         (struct gdb_exception): Add constructor, operator=.
11437         <what>: New method.
11438         (struct gdb_exception_RETURN_MASK_ALL)
11439         (struct gdb_exception_RETURN_MASK_ERROR)
11440         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11441         (struct gdb_quit_bad_alloc): Update.
11442         * common/common-exceptions.c (exception_none): Change
11443         initializer.
11444         (struct catcher) <state, exception>: Initialize inline.
11445         <prev>: Remove member.
11446         (current_catcher): Remove.
11447         (catchers): New global.
11448         (exceptions_state_mc_init): Simplify.
11449         (catcher_pop): Remove.
11450         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11451         (try_scope_depth, exception_try_scope_entry)
11452         (exception_try_scope_exit): Remove.
11453         (throw_exception_sjlj): Update.
11454         (exception_messages, exception_messages_size): Remove.
11455         (throw_it): Simplify.
11456         (gdb_exception_sliced_copy): Remove.
11457         (throw_exception_cxx): Update.
11458         * cli/cli-script.c (script_from_file): Update.
11459         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11460         Update.
11461         * ada-valprint.c (ada_val_print): Update.
11462         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11463         (create_excep_cond_exprs): Update.
11464
11465 2019-04-08  Tom Tromey  <tom@tromey.com>
11466
11467         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11468         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11469         (TRY, CATCH, END_CATCH): Remove some definitions.
11470         * common/common-exceptions.c: Don't use GDB_XCPT.
11471         (catcher_list_size): Remove.
11472         (throw_exception, throw_it): Simplify.
11473
11474 2019-04-05  Tom Tromey  <tom@tromey.com>
11475
11476         Revert the header-sorting patch.
11477         * ft32-tdep.c: Revert.
11478         * frv-tdep.c: Revert.
11479         * frv-linux-tdep.c: Revert.
11480         * frame.c: Revert.
11481         * frame-unwind.c: Revert.
11482         * frame-base.c: Revert.
11483         * fork-child.c: Revert.
11484         * findvar.c: Revert.
11485         * findcmd.c: Revert.
11486         * filesystem.c: Revert.
11487         * filename-seen-cache.h: Revert.
11488         * filename-seen-cache.c: Revert.
11489         * fbsd-tdep.c: Revert.
11490         * fbsd-nat.h: Revert.
11491         * fbsd-nat.c: Revert.
11492         * f-valprint.c: Revert.
11493         * f-typeprint.c: Revert.
11494         * f-lang.c: Revert.
11495         * extension.h: Revert.
11496         * extension.c: Revert.
11497         * extension-priv.h: Revert.
11498         * expprint.c: Revert.
11499         * exec.h: Revert.
11500         * exec.c: Revert.
11501         * exceptions.c: Revert.
11502         * event-top.c: Revert.
11503         * event-loop.c: Revert.
11504         * eval.c: Revert.
11505         * elfread.c: Revert.
11506         * dwarf2read.h: Revert.
11507         * dwarf2read.c: Revert.
11508         * dwarf2loc.c: Revert.
11509         * dwarf2expr.h: Revert.
11510         * dwarf2expr.c: Revert.
11511         * dwarf2-frame.c: Revert.
11512         * dwarf2-frame-tailcall.c: Revert.
11513         * dwarf-index-write.h: Revert.
11514         * dwarf-index-write.c: Revert.
11515         * dwarf-index-common.c: Revert.
11516         * dwarf-index-cache.h: Revert.
11517         * dwarf-index-cache.c: Revert.
11518         * dummy-frame.c: Revert.
11519         * dtrace-probe.c: Revert.
11520         * disasm.h: Revert.
11521         * disasm.c: Revert.
11522         * disasm-selftests.c: Revert.
11523         * dictionary.c: Revert.
11524         * dicos-tdep.c: Revert.
11525         * demangle.c: Revert.
11526         * dcache.h: Revert.
11527         * dcache.c: Revert.
11528         * darwin-nat.h: Revert.
11529         * darwin-nat.c: Revert.
11530         * darwin-nat-info.c: Revert.
11531         * d-valprint.c: Revert.
11532         * d-namespace.c: Revert.
11533         * d-lang.c: Revert.
11534         * ctf.c: Revert.
11535         * csky-tdep.c: Revert.
11536         * csky-linux-tdep.c: Revert.
11537         * cris-tdep.c: Revert.
11538         * cris-linux-tdep.c: Revert.
11539         * cp-valprint.c: Revert.
11540         * cp-support.c: Revert.
11541         * cp-namespace.c: Revert.
11542         * cp-abi.c: Revert.
11543         * corelow.c: Revert.
11544         * corefile.c: Revert.
11545         * continuations.c: Revert.
11546         * completer.h: Revert.
11547         * completer.c: Revert.
11548         * complaints.c: Revert.
11549         * coffread.c: Revert.
11550         * coff-pe-read.c: Revert.
11551         * cli-out.h: Revert.
11552         * cli-out.c: Revert.
11553         * charset.c: Revert.
11554         * c-varobj.c: Revert.
11555         * c-valprint.c: Revert.
11556         * c-typeprint.c: Revert.
11557         * c-lang.c: Revert.
11558         * buildsym.c: Revert.
11559         * buildsym-legacy.c: Revert.
11560         * build-id.h: Revert.
11561         * build-id.c: Revert.
11562         * btrace.c: Revert.
11563         * bsd-uthread.c: Revert.
11564         * breakpoint.h: Revert.
11565         * breakpoint.c: Revert.
11566         * break-catch-throw.c: Revert.
11567         * break-catch-syscall.c: Revert.
11568         * break-catch-sig.c: Revert.
11569         * blockframe.c: Revert.
11570         * block.c: Revert.
11571         * bfin-tdep.c: Revert.
11572         * bfin-linux-tdep.c: Revert.
11573         * bfd-target.c: Revert.
11574         * bcache.c: Revert.
11575         * ax-general.c: Revert.
11576         * ax-gdb.h: Revert.
11577         * ax-gdb.c: Revert.
11578         * avr-tdep.c: Revert.
11579         * auxv.c: Revert.
11580         * auto-load.c: Revert.
11581         * arm-wince-tdep.c: Revert.
11582         * arm-tdep.c: Revert.
11583         * arm-symbian-tdep.c: Revert.
11584         * arm-pikeos-tdep.c: Revert.
11585         * arm-obsd-tdep.c: Revert.
11586         * arm-nbsd-tdep.c: Revert.
11587         * arm-nbsd-nat.c: Revert.
11588         * arm-linux-tdep.c: Revert.
11589         * arm-linux-nat.c: Revert.
11590         * arm-fbsd-tdep.c: Revert.
11591         * arm-fbsd-nat.c: Revert.
11592         * arm-bsd-tdep.c: Revert.
11593         * arch-utils.c: Revert.
11594         * arc-tdep.c: Revert.
11595         * arc-newlib-tdep.c: Revert.
11596         * annotate.h: Revert.
11597         * annotate.c: Revert.
11598         * amd64-windows-tdep.c: Revert.
11599         * amd64-windows-nat.c: Revert.
11600         * amd64-tdep.c: Revert.
11601         * amd64-sol2-tdep.c: Revert.
11602         * amd64-obsd-tdep.c: Revert.
11603         * amd64-obsd-nat.c: Revert.
11604         * amd64-nbsd-tdep.c: Revert.
11605         * amd64-nbsd-nat.c: Revert.
11606         * amd64-nat.c: Revert.
11607         * amd64-linux-tdep.c: Revert.
11608         * amd64-linux-nat.c: Revert.
11609         * amd64-fbsd-tdep.c: Revert.
11610         * amd64-fbsd-nat.c: Revert.
11611         * amd64-dicos-tdep.c: Revert.
11612         * amd64-darwin-tdep.c: Revert.
11613         * amd64-bsd-nat.c: Revert.
11614         * alpha-tdep.c: Revert.
11615         * alpha-obsd-tdep.c: Revert.
11616         * alpha-nbsd-tdep.c: Revert.
11617         * alpha-mdebug-tdep.c: Revert.
11618         * alpha-linux-tdep.c: Revert.
11619         * alpha-linux-nat.c: Revert.
11620         * alpha-bsd-tdep.c: Revert.
11621         * alpha-bsd-nat.c: Revert.
11622         * aix-thread.c: Revert.
11623         * agent.c: Revert.
11624         * addrmap.c: Revert.
11625         * ada-varobj.c: Revert.
11626         * ada-valprint.c: Revert.
11627         * ada-typeprint.c: Revert.
11628         * ada-tasks.c: Revert.
11629         * ada-lang.c: Revert.
11630         * aarch64-tdep.c: Revert.
11631         * aarch64-ravenscar-thread.c: Revert.
11632         * aarch64-newlib-tdep.c: Revert.
11633         * aarch64-linux-tdep.c: Revert.
11634         * aarch64-linux-nat.c: Revert.
11635         * aarch64-fbsd-tdep.c: Revert.
11636         * aarch64-fbsd-nat.c: Revert.
11637         * aarch32-linux-nat.c: Revert.
11638
11639 2019-04-05  Tom Tromey  <tom@tromey.com>
11640
11641         * ft32-tdep.c: Sort headers.
11642         * frv-tdep.c: Sort headers.
11643         * frv-linux-tdep.c: Sort headers.
11644         * frame.c: Sort headers.
11645         * frame-unwind.c: Sort headers.
11646         * frame-base.c: Sort headers.
11647         * fork-child.c: Sort headers.
11648         * findvar.c: Sort headers.
11649         * findcmd.c: Sort headers.
11650         * filesystem.c: Sort headers.
11651         * filename-seen-cache.h: Sort headers.
11652         * filename-seen-cache.c: Sort headers.
11653         * fbsd-tdep.c: Sort headers.
11654         * fbsd-nat.h: Sort headers.
11655         * fbsd-nat.c: Sort headers.
11656         * f-valprint.c: Sort headers.
11657         * f-typeprint.c: Sort headers.
11658         * f-lang.c: Sort headers.
11659         * extension.h: Sort headers.
11660         * extension.c: Sort headers.
11661         * extension-priv.h: Sort headers.
11662         * expprint.c: Sort headers.
11663         * exec.h: Sort headers.
11664         * exec.c: Sort headers.
11665         * exceptions.c: Sort headers.
11666         * event-top.c: Sort headers.
11667         * event-loop.c: Sort headers.
11668         * eval.c: Sort headers.
11669         * elfread.c: Sort headers.
11670         * dwarf2read.h: Sort headers.
11671         * dwarf2read.c: Sort headers.
11672         * dwarf2loc.c: Sort headers.
11673         * dwarf2expr.h: Sort headers.
11674         * dwarf2expr.c: Sort headers.
11675         * dwarf2-frame.c: Sort headers.
11676         * dwarf2-frame-tailcall.c: Sort headers.
11677         * dwarf-index-write.h: Sort headers.
11678         * dwarf-index-write.c: Sort headers.
11679         * dwarf-index-common.c: Sort headers.
11680         * dwarf-index-cache.h: Sort headers.
11681         * dwarf-index-cache.c: Sort headers.
11682         * dummy-frame.c: Sort headers.
11683         * dtrace-probe.c: Sort headers.
11684         * disasm.h: Sort headers.
11685         * disasm.c: Sort headers.
11686         * disasm-selftests.c: Sort headers.
11687         * dictionary.c: Sort headers.
11688         * dicos-tdep.c: Sort headers.
11689         * demangle.c: Sort headers.
11690         * dcache.h: Sort headers.
11691         * dcache.c: Sort headers.
11692         * darwin-nat.h: Sort headers.
11693         * darwin-nat.c: Sort headers.
11694         * darwin-nat-info.c: Sort headers.
11695         * d-valprint.c: Sort headers.
11696         * d-namespace.c: Sort headers.
11697         * d-lang.c: Sort headers.
11698         * ctf.c: Sort headers.
11699         * csky-tdep.c: Sort headers.
11700         * csky-linux-tdep.c: Sort headers.
11701         * cris-tdep.c: Sort headers.
11702         * cris-linux-tdep.c: Sort headers.
11703         * cp-valprint.c: Sort headers.
11704         * cp-support.c: Sort headers.
11705         * cp-namespace.c: Sort headers.
11706         * cp-abi.c: Sort headers.
11707         * corelow.c: Sort headers.
11708         * corefile.c: Sort headers.
11709         * continuations.c: Sort headers.
11710         * completer.h: Sort headers.
11711         * completer.c: Sort headers.
11712         * complaints.c: Sort headers.
11713         * coffread.c: Sort headers.
11714         * coff-pe-read.c: Sort headers.
11715         * cli-out.h: Sort headers.
11716         * cli-out.c: Sort headers.
11717         * charset.c: Sort headers.
11718         * c-varobj.c: Sort headers.
11719         * c-valprint.c: Sort headers.
11720         * c-typeprint.c: Sort headers.
11721         * c-lang.c: Sort headers.
11722         * buildsym.c: Sort headers.
11723         * buildsym-legacy.c: Sort headers.
11724         * build-id.h: Sort headers.
11725         * build-id.c: Sort headers.
11726         * btrace.c: Sort headers.
11727         * bsd-uthread.c: Sort headers.
11728         * breakpoint.h: Sort headers.
11729         * breakpoint.c: Sort headers.
11730         * break-catch-throw.c: Sort headers.
11731         * break-catch-syscall.c: Sort headers.
11732         * break-catch-sig.c: Sort headers.
11733         * blockframe.c: Sort headers.
11734         * block.c: Sort headers.
11735         * bfin-tdep.c: Sort headers.
11736         * bfin-linux-tdep.c: Sort headers.
11737         * bfd-target.c: Sort headers.
11738         * bcache.c: Sort headers.
11739         * ax-general.c: Sort headers.
11740         * ax-gdb.h: Sort headers.
11741         * ax-gdb.c: Sort headers.
11742         * avr-tdep.c: Sort headers.
11743         * auxv.c: Sort headers.
11744         * auto-load.c: Sort headers.
11745         * arm-wince-tdep.c: Sort headers.
11746         * arm-tdep.c: Sort headers.
11747         * arm-symbian-tdep.c: Sort headers.
11748         * arm-pikeos-tdep.c: Sort headers.
11749         * arm-obsd-tdep.c: Sort headers.
11750         * arm-nbsd-tdep.c: Sort headers.
11751         * arm-nbsd-nat.c: Sort headers.
11752         * arm-linux-tdep.c: Sort headers.
11753         * arm-linux-nat.c: Sort headers.
11754         * arm-fbsd-tdep.c: Sort headers.
11755         * arm-fbsd-nat.c: Sort headers.
11756         * arm-bsd-tdep.c: Sort headers.
11757         * arch-utils.c: Sort headers.
11758         * arc-tdep.c: Sort headers.
11759         * arc-newlib-tdep.c: Sort headers.
11760         * annotate.h: Sort headers.
11761         * annotate.c: Sort headers.
11762         * amd64-windows-tdep.c: Sort headers.
11763         * amd64-windows-nat.c: Sort headers.
11764         * amd64-tdep.c: Sort headers.
11765         * amd64-sol2-tdep.c: Sort headers.
11766         * amd64-obsd-tdep.c: Sort headers.
11767         * amd64-obsd-nat.c: Sort headers.
11768         * amd64-nbsd-tdep.c: Sort headers.
11769         * amd64-nbsd-nat.c: Sort headers.
11770         * amd64-nat.c: Sort headers.
11771         * amd64-linux-tdep.c: Sort headers.
11772         * amd64-linux-nat.c: Sort headers.
11773         * amd64-fbsd-tdep.c: Sort headers.
11774         * amd64-fbsd-nat.c: Sort headers.
11775         * amd64-dicos-tdep.c: Sort headers.
11776         * amd64-darwin-tdep.c: Sort headers.
11777         * amd64-bsd-nat.c: Sort headers.
11778         * alpha-tdep.c: Sort headers.
11779         * alpha-obsd-tdep.c: Sort headers.
11780         * alpha-nbsd-tdep.c: Sort headers.
11781         * alpha-mdebug-tdep.c: Sort headers.
11782         * alpha-linux-tdep.c: Sort headers.
11783         * alpha-linux-nat.c: Sort headers.
11784         * alpha-bsd-tdep.c: Sort headers.
11785         * alpha-bsd-nat.c: Sort headers.
11786         * aix-thread.c: Sort headers.
11787         * agent.c: Sort headers.
11788         * addrmap.c: Sort headers.
11789         * ada-varobj.c: Sort headers.
11790         * ada-valprint.c: Sort headers.
11791         * ada-typeprint.c: Sort headers.
11792         * ada-tasks.c: Sort headers.
11793         * ada-lang.c: Sort headers.
11794         * aarch64-tdep.c: Sort headers.
11795         * aarch64-ravenscar-thread.c: Sort headers.
11796         * aarch64-newlib-tdep.c: Sort headers.
11797         * aarch64-linux-tdep.c: Sort headers.
11798         * aarch64-linux-nat.c: Sort headers.
11799         * aarch64-fbsd-tdep.c: Sort headers.
11800         * aarch64-fbsd-nat.c: Sort headers.
11801         * aarch32-linux-nat.c: Sort headers.
11802
11803 2019-04-04  Tom Tromey  <tom@tromey.com>
11804
11805         * varobj.c (varobj_create): Update.
11806         * rust-exp.y (struct rust_parser) <update_innermost_block,
11807         lookup_symbol>: New methods.
11808         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11809         Rename.
11810         (rust_parser::rust_lookup_type)
11811         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11812         * printcmd.c (display_command, do_one_display): Update.
11813         * parser-defs.h (struct parser_state) <parser_state>: Add
11814         "tracker" parameter.
11815         (block_tracker): New member.
11816         (class innermost_block_tracker) <innermost_block_tracker>: Add
11817         "types" parameter.
11818         <reset>: Remove method.
11819         (innermost_block): Don't declare.
11820         (null_post_parser): Update.
11821         * parse.c (innermost_block): Remove global.
11822         (write_dollar_variable): Update.
11823         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11824         Remove "tracker_types" parameter.
11825         (parse_expression): Add "tracker" parameter.
11826         (parse_expression_for_completion): Update.
11827         (null_post_parser): Add "tracker" parameter.
11828         * p-exp.y: Update rules.
11829         * m2-exp.y: Update rules.
11830         * language.h (struct language_defn) <la_post_parser>: Add
11831         "tracker" parameter.
11832         * go-exp.y: Update rules.
11833         * f-exp.y: Update rules.
11834         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11835         parameter.
11836         * d-exp.y: Update rules.
11837         * c-exp.y: Update rules.
11838         * breakpoint.c (set_breakpoint_condition): Create an
11839         innermost_block_tracker.
11840         (watch_command_1): Likewise.
11841         * ada-lang.c (resolve): Add "tracker" parameter.
11842         (resolve_subexp): Likewise.
11843         * ada-exp.y (write_var_from_sym): Update.
11844
11845 2019-04-04  Tom Tromey  <tom@tromey.com>
11846
11847         * type-stack.h: New file.
11848         * type-stack.c: New file.
11849         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11850         type-stack.h.
11851         (insert_into_type_stack, insert_type, push_type, push_type_int)
11852         (insert_type_address_space, pop_type, pop_type_int)
11853         (pop_typelist, pop_type_stack, append_type_stack)
11854         (push_type_stack, get_type_stack, push_typelist)
11855         (follow_type_instance_flags, follow_types): Don't declare.
11856         * parse.c (type_stack): Remove global.
11857         (parse_exp_in_context): Update.
11858         (insert_into_type_stack, insert_type, push_type, push_type_int)
11859         (insert_type_address_space, pop_type, pop_type_int)
11860         (pop_typelist, pop_type_stack, append_type_stack)
11861         (push_type_stack, get_type_stack, push_typelist)
11862         (follow_type_instance_flags, follow_types): Remove (moved to
11863         type-stack.c).
11864         * f-exp.y (type_stack): New global.
11865         Update rules.
11866         (push_kind_type, f_parse): Update.
11867         * d-exp.y (type_stack): New global.
11868         Update rules.
11869         (d_parse): Update.
11870         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11871         Update rules.
11872         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11873         (HFILES_NO_SRCDIR): Add type-stack.h.
11874
11875 2019-04-04  Tom Tromey  <tom@tromey.com>
11876
11877         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11878         (rust_parser::convert_ast_to_expression, rust_parse)
11879         (rust_lex_test_completion, rust_lex_tests): Update.
11880         * parser-defs.h (struct expr_completion_state): New.
11881         (struct parser_state) <parser_state>: Add completion parameter.
11882         <mark_struct_expression, mark_completion_tag>: New methods.
11883         <parse_completion, m_completion_state>: New members.
11884         (prefixify_expression, null_post_parser): Update.
11885         (mark_struct_expression, mark_completion_tag): Don't declare.
11886         * parse.c (parse_completion, expout_last_struct)
11887         (expout_tag_completion_type, expout_completion_name): Remove
11888         globals.
11889         (parser_state::mark_struct_expression)
11890         (parser_state::mark_completion_tag): Now methods.
11891         (prefixify_expression): Add last_struct parameter.
11892         (prefixify_subexp): Likewise.
11893         (parse_exp_1): Update.
11894         (parse_exp_in_context): Add cstate parameter.  Update.
11895         (parse_expression_for_completion): Create an
11896         expr_completion_state.
11897         (null_post_parser): Add "completion" parameter.
11898         * p-exp.y: Update rules.
11899         (yylex): Update.
11900         * language.h (struct language_defn) <la_post_parser>: Add
11901         "completing" parameter.
11902         * go-exp.y: Update rules.
11903         (lex_one_token): Update.
11904         * expression.h (parse_completion): Don't declare.
11905         * d-exp.y: Update rules.
11906         (lex_one_token): Update rules.
11907         * c-exp.y: Update rules.
11908         (lex_one_token): Update.
11909         * ada-lang.c (resolve): Add "parse_completion" parameter.
11910         (resolve_subexp): Likewise.
11911         (ada_resolve_function): Likewise.
11912
11913 2019-04-04  Tom Tromey  <tom@tromey.com>
11914
11915         * parser-defs.h (struct parser_state) <start_arglist,
11916         end_arglist>: New methods.
11917         <arglist_len, m_funcall_chain>: New members.
11918         (arglist_len, start_arglist, end_arglist): Don't declare.
11919         * parse.c (arglist_len, funcall_chain): Remove global.
11920         (start_arglist, end_arglist): Remove functions.
11921         (parse_exp_in_context): Update.
11922         * p-exp.y: Update rules.
11923         * m2-exp.y: Update rules.
11924         * go-exp.y: Update rules.
11925         * f-exp.y: Update rules.
11926         * d-exp.y: Update rules.
11927         * c-exp.y: Update rules.
11928
11929 2019-04-04  Tom Tromey  <tom@tromey.com>
11930
11931         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11932         lex_operator, push_back>: New methods.
11933         Update all rules.
11934         (rust_parser::lex_hex, lex_escape): Rename and update.
11935         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11936         (rust_parser::lex_operator): Rename and update.
11937         (rust_parser::lex_number, rustyylex, rustyyerror)
11938         (rust_lex_test_init, rust_lex_test_sequence)
11939         (rust_lex_test_push_back, rust_lex_tests): Update.
11940         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11941         parameter.
11942         <lexptr, prev_lexptr>: New members.
11943         (lexptr, prev_lexptr): Don't declare.
11944         * parse.c (lexptr, prev_lexptr): Remove globals.
11945         (parse_exp_in_context): Update.
11946         * p-exp.y (yylex, yyerror): Update.
11947         * m2-exp.y (parse_number, yylex, yyerror): Update.
11948         * go-exp.y (lex_one_token, yyerror): Update.
11949         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11950         * d-exp.y (lex_one_token, yyerror): Update.
11951         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11952         (lex_one_token, yyerror): Update.
11953         * ada-lex.l (YY_INPUT): Update.
11954         (rewind_to_char): Update.
11955         * ada-exp.y (yyerror): Update.
11956
11957 2019-04-04  Tom Tromey  <tom@tromey.com>
11958
11959         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11960         * parser-defs.h (struct parser_state) <parser_state>: Add new
11961         parameter.
11962         <comma_terminates>: New member.
11963         (comma_terminates): Don't declare global.
11964         * parse.c (comma_terminates): Remove global.
11965         (parse_exp_in_context): Update.
11966         * p-exp.y (yylex): Update.
11967         * m2-exp.y (yylex): Update.
11968         * go-exp.y (lex_one_token): Update.
11969         * f-exp.y (yylex): Update.
11970         * d-exp.y (lex_one_token): Update.
11971         * c-exp.y (lex_one_token): Update.
11972         * ada-lex.l: Update.
11973
11974 2019-04-04  Tom Tromey  <tom@tromey.com>
11975
11976         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11977         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11978         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11979         * parser-defs.h (paren_depth): Don't declare.
11980         * parse.c (paren_depth): Remove global.
11981         (parse_exp_in_context): Update.
11982         * p-exp.y (paren_depth): New global.
11983         (pascal_parse): Initialize it.
11984         * m2-exp.y (paren_depth): New global.
11985         (m2_parse): Initialize it.
11986         * go-exp.y (paren_depth): New global.
11987         (go_parse): Initialize it.
11988         * f-exp.y (paren_depth): New global.
11989         (f_parse): Initialize it.
11990         * d-exp.y (paren_depth): New global.
11991         (d_parse): Initialize it.
11992         * c-exp.y (paren_depth): New global.
11993         (c_parse): Initialize it.
11994         * ada-lex.l (paren_depth): New global.
11995         (lexer_init): Initialize it.
11996
11997 2019-04-04  Tom Tromey  <tom@tromey.com>
11998
11999         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12000         (rust_parser::convert_ast_to_type)
12001         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12002         * parser-defs.h (struct parser_state) <parser_state>: Add
12003         parameters.  Initialize new members.
12004         <expression_context_block, expression_context_pc>: New members.
12005         * parse.c (expression_context_block, expression_context_pc):
12006         Remove globals.
12007         (parse_exp_in_context): Update.
12008         * p-exp.y: Update all rules.
12009         (yylex): Update.
12010         * m2-exp.y: Update all rules.
12011         (yylex): Update.
12012         * go-exp.y (yylex): Update.
12013         * f-exp.y (yylex): Update.
12014         * d-exp.y: Update all rules.
12015         (yylex): Update.
12016         * c-exp.y: Update all rules.
12017         (lex_one_token, classify_name, yylex, c_parse): Update.
12018         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12019
12020 2019-04-04  Tom Tromey  <tom@tromey.com>
12021
12022         * gdbarch.h, gdbarch.c: Rebuild.
12023         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12024         * stap-probe.h:
12025         (struct stap_parse_info): Replace "parser_state" with
12026         "expr_builder".
12027         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12028         (parser_state): New class.
12029         * parse.c (expr_builder): Rename.
12030         (expr_builder::release): Rename.
12031         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12032         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12033         (write_exp_elt_longcst, write_exp_elt_floatcst)
12034         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12035         (write_exp_string_vector, write_exp_bitstring)
12036         (write_exp_msymbol, mark_struct_expression)
12037         (write_dollar_variable)
12038         (insert_type_address_space, increase_expout_size): Replace
12039         "parser_state" with "expr_builder".
12040         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12041         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12042         "parser_state" with "expr_builder".
12043
12044 2019-04-04  Tom Tromey  <tom@tromey.com>
12045
12046         * rust-exp.y: Replace "parse_language" with method call.
12047         * p-exp.y:
12048         (yylex): Replace "parse_language" with method call.
12049         * m2-exp.y:
12050         (yylex): Replace "parse_language" with method call.
12051         * go-exp.y (classify_name): Replace "parse_language" with method
12052         call.
12053         * f-exp.y (yylex): Replace "parse_language" with method call.
12054         * d-exp.y (lex_one_token): Replace "parse_language" with method
12055         call.
12056         * c-exp.y:
12057         (lex_one_token, classify_name, yylex): Replace "parse_language"
12058         with method call.
12059         * ada-exp.y (find_primitive_type, type_char)
12060         (type_system_address): Replace "parse_language" with method call.
12061
12062 2019-04-04  Tom Tromey  <tom@tromey.com>
12063
12064         * rust-exp.y: Replace "parse_gdbarch" with method call.
12065         * parse.c (write_dollar_variable, insert_type_address_space):
12066         Replace "parse_gdbarch" with method call.
12067         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12068         call.
12069         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12070         call.
12071         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12072         "parse_gdbarch" with method call.
12073         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12074         with method call.
12075         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12076         "parse_gdbarch" with method call.
12077         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12078         "parse_gdbarch" with method call.
12079         * c-exp.y (parse_type, parse_number, classify_name): Replace
12080         "parse_gdbarch" with method call.
12081         * ada-lex.l: Replace "parse_gdbarch" with method call.
12082         * ada-exp.y (parse_type, find_primitive_type, type_char)
12083         (type_system_address): Replace "parse_gdbarch" with method call.
12084
12085 2019-04-04  Tom Tromey  <tom@tromey.com>
12086
12087         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12088         * stap-probe.c (stap_parse_argument): Update.
12089         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12090         initial_size parameter.
12091         * rust-exp.y (rust_lex_tests): Update.
12092         * parse.c (parser_state): Update.
12093         (parse_exp_in_context): Update.
12094         * parser-defs.h (struct parser_state) <parser_state>: Remove
12095         "initial_size" parameter.
12096
12097 2019-04-04  Tom Tromey  <tom@tromey.com>
12098
12099         * parser-defs.h (increase_expout_size): Don't declare.
12100         * parse.c (increase_expout_size): Now static.
12101
12102 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12103
12104         * gnu-nat.c (gnu_nat_target::wait): Fix
12105         target_waitstatus_to_string call.
12106
12107 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12108
12109         * eval.c (evaluate_subexp_standard): Handle internal functions
12110         during Fortran function call handling.
12111
12112 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12113
12114         * NEWS: Mention new internal functions.
12115         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12116         (read_base_type): Use dwarf2_init_complex_target_type.
12117         * value.c (creal_internal_fn): New function.
12118         (cimag_internal_fn): New function.
12119         (_initialize_values): Register new internal functions.
12120
12121 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12122
12123         * infrun.c (stop_all_threads): If debug_infrun, always
12124         trace the wait status after wait_one, using
12125         target_waitstatus_to_string and target_pid_to_str.
12126         (handle_inferior_event): Replace various trace of
12127         wait status kind by a single trace.
12128         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12129         wait status kind image by target_waitstatus_to_string.
12130         * target/waitstatus.c (target_waitstatus_to_string): Fix
12131         obsolete comment.
12132
12133 2019-04-01  Tom Tromey  <tromey@adacore.com>
12134
12135         PR symtab/23331:
12136         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12137
12138 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12139             Pedro Alves  <palves@redhat.com>
12140
12141         * top.c (quit_force): Call 'finalize_values'.
12142         * value.c (finalize_values): New function.
12143         * value.h (finalize_values): Declare.
12144
12145 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12146
12147         * NEWS: Announce $_gdb_major and $_gdb_minor.
12148
12149         * top.c (init_gdb_version_vars): New function.
12150         (gdb_init): Call init_gdb_version_vars.
12151
12152 2019-03-29  Tom Tromey  <tromey@adacore.com>
12153
12154         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12155         help text.  Remove dead code.
12156
12157 2019-03-29  Keith Seitz  <keiths@redhat.com>
12158
12159         From Siddhesh Poyarekar:
12160         * f-lang.h (f77_get_upperbound): Return LONGEST.
12161         (f77_get_lowerbound): Likewise.
12162         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12163         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12164         print them.
12165         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12166         plongest to format print it.
12167         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12168         (f77_get_upperbound): Likewise.
12169         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12170         LOWER_BOUND to LONGEST.
12171         (f77_create_arrayprint_offset_tbl): Likewise.
12172
12173 2019-03-29  Keith Seitz  <keiths@redhat.com>
12174
12175         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12176         %s/pulongest for TYPE_LENGTH instead of %d in format
12177         strings.
12178         * ada-typerint.c (ada_print_type): Likewise.
12179         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12180         * compile/compile-c-support.c (generate_register_struct): Likewise.
12181         * gdbtypes.c (recursive_dump_type): Likewise.
12182         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12183         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12184         instead of %d in format strings.
12185         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12186         to std::min to ULONGEST.
12187         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12188         instead of %d in format strings.
12189         * tracepoint.c (info_scope_command): Likewise.
12190         * typeprint.c (print_offset_data::update)
12191         (print_offset_data::finish): Likewise.
12192         * xtensa-tdep.c (xtensa_store_return_value)
12193         (xtensa_push_dummy_call): Likewise.
12194
12195 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12196
12197         * windows-nat.c (display_selector): Fixed format specifications
12198         for 64-bit Cygwin.
12199
12200 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12201
12202         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12203
12204 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12205
12206         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12207         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12208         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12209         (nios2_linux_init_abi): Install it.
12210
12211 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12212
12213         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12214
12215 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12216
12217         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12218
12219 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12220             Tom Tromey  <tromey@adacore.com>
12221
12222         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12223
12224 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12225
12226         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12227         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12228         method to compute the bounds of range types. Also print "[evaluated]"
12229         if the bounds' values come from a dynamic evaluation.
12230
12231 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12232
12233         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12234         whitespace when pretty printing is on.
12235
12236 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12237
12238         * ppc-linux-nat.c: Add include.
12239
12240 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12241
12242         * NEWS: Mention AArch64 Pointer Authentication.
12243
12244 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12245
12246         * arm-linux-nat.c: Add include.
12247
12248 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12249
12250         * source-cache.c (source_cache::get_source_lines): Re-read
12251         fullname after calling open_source_file.
12252
12253 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12254
12255         * NEWS: Mention TLS support for FreeBSD.
12256
12257 2019-03-25  Tom Tromey  <tromey@adacore.com>
12258
12259         * minsyms.c (BUNCH_SIZE): Update comment.
12260         (~minimal_symbol_reader): Remove old comment.
12261         (compact_minimal_symbols): Update comment.
12262         (minimal_symbol_reader::install): Remove old comment.  Update
12263         other comments.
12264
12265 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12266
12267         * s390-linux-nat.c: Add include.
12268
12269 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12270
12271         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12272         Call linux_get_hwcap.
12273         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12274         Likewise.
12275         (aarch64_linux_get_hwcap): Remove function.
12276         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12277         declaration.
12278         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12279         linux_get_hwcap.
12280         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12281         * linux-tdep.c (linux_get_hwcap): Add function.
12282         (linux_get_hwcap2): Likewise.
12283         * linux-tdep.h (linux_get_hwcap): Add declaration.
12284         (linux_get_hwcap2): Likewise.
12285         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12286         (ppc_linux_get_hwcap2): Likewise.
12287         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12288         linux_get_hwcap.
12289         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12290         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12291         (ppc_linux_nat_target::read_description): Likewise.
12292         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12293         * s390-linux-nat.c: Likewise.
12294         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12295
12296 2019-03-24  Tom Tromey  <tom@tromey.com>
12297
12298         * ada-lang.c (standard_lookup): Simplify initialization.
12299         (ada_lookup_symbol_nonlocal): Simplify return.
12300         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12301         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12302         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12303         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12304         initialization.
12305         * solib.c (solib_global_lookup): Simplify.
12306         * symtab.c (null_block_symbol): Remove.
12307         (symbol_cache_lookup): Simplify returns.
12308         (lookup_language_this): Simplify returns.
12309         (lookup_symbol_aux): Simplify return.
12310         (lookup_local_symbol): Simplify returns.
12311         (lookup_global_symbol_from_objfile): Simplify return.
12312         (lookup_symbol_in_objfile_symtabs)
12313         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12314         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12315         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12316         * cp-namespace.c (cp_lookup_bare_symbol)
12317         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12318         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12319         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12320         (cp_lookup_symbol_via_imports): Simplify initialization.
12321         (find_symbol_in_baseclass): Likewise.
12322         * symtab.h (null_block_symbol): Remove.
12323         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12324         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12325         (d_lookup_symbol_module): Likewise.
12326         (find_symbol_in_baseclass): Simplify initialization.
12327
12328 2019-03-24  Tom Tromey  <tom@tromey.com>
12329
12330         * expression.h: Don't include symtab.h.
12331         (struct block): Forward declare.
12332
12333 2019-03-24  Tom Tromey  <tom@tromey.com>
12334
12335         * c-exp.y (typebase): Remove casts.
12336         * gdbtypes.c (lookup_unsigned_typename, )
12337         (lookup_signed_typename): Remove cast.
12338         * eval.c (parse_to_comma_and_eval): Remove cast.
12339         * parse.c (write_dollar_variable): Remove cast.
12340         * block.h (struct block) <superblock>: Now const.
12341         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12342         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12343         (map_block): Make "block" const.
12344         * symfile.h (struct quick_symbol_functions)
12345         <map_matching_symbols>: Constify block argument to "callback".
12346         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12347         const.
12348         (find_pc_sect_compunit_symtab): Make "b" const.
12349         (find_symbol_at_address): Likewise.
12350         (search_symbols): Likewise.
12351         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12352         (dw2_debug_names_lookup_symbol): Likewise.
12353         (dw2_map_matching_symbols): Update.
12354         * p-valprint.c (pascal_val_print): Remove "block".
12355         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12356         (aux_add_nonlocal_symbols): Make "block" const.
12357         (resolve_subexp): Remove cast.
12358         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12359         const.
12360         (iterate_over_file_blocks): Likewise.
12361         * f-exp.y (%union) <bval>: Remove.
12362         * coffread.c (patch_opaque_types): Make "b" const.
12363         * spu-tdep.c (spu_catch_start): Make "block" const.
12364         * c-valprint.c (print_unpacked_pointer): Remove "block".
12365         * symmisc.c (dump_symtab_1): Make "b" const.
12366         (block_depth): Make "block" const.
12367         * d-exp.y (%union) <bval>: Remove.
12368         * cp-support.h (cp_lookup_rtti_type): Update.
12369         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12370         * psymtab.c (psym_lookup_symbol): Make "block" const.
12371         (maintenance_check_psymtabs): Make "b" const.
12372         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12373         (enumerate_locals, enumerate_args): Update.
12374         * python/py-symtab.c (stpy_global_block): Make "block" const.
12375         (stpy_static_block): Likewise.
12376         * inline-frame.c (block_starting_point_at): Make "new_block"
12377         const.
12378         * block.c (find_block_in_blockvector): Make return type const.
12379         (blockvector_for_pc_sect): Make "b" const.
12380         (find_block_in_blockvector): Make "b" const.
12381
12382 2019-03-23  Tom Tromey  <tom@tromey.com>
12383
12384         * varobj.c (varobj_create): Update.
12385         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12386         * printcmd.c (display_command, do_one_display): Don't reset
12387         innermost_block.
12388         * parser-defs.h (enum innermost_block_tracker_type): Move to
12389         expression.h.
12390         (innermost_block): Update comment.
12391         * parse.c (parse_exp_1): Add tracker_types parameter.
12392         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12393         tracker_types parameter.  Reset innermost_block.
12394         (parse_exp_in_context): Remove.
12395         (parse_expression_for_completion): Update.
12396         * objfiles.c (~objfile): Don't reset expression_context_block or
12397         innermost_block.
12398         * expression.h (enum innermost_block_tracker_type): Move from
12399         parser-defs.h.
12400         (parse_exp_1): Add tracker_types parameter.
12401         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12402         reset innermost_block.
12403
12404 2019-03-23  Tom Tromey  <tom@tromey.com>
12405
12406         * objfiles.h: Include bcache.h.
12407
12408 2019-03-23  Tom Tromey  <tom@tromey.com>
12409
12410         * linespec.c (get_current_search_block): Use
12411         scoped_restore_current_language.
12412         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12413
12414 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12415             Jiong Wang  <jiong.wang@arm.com>
12416
12417         * aarch64-linux-tdep.c
12418         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12419         section.
12420         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12421
12422 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12423             Jiong Wang  <jiong.wang@arm.com>
12424
12425         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12426         instructions.
12427         (aarch64_analyze_prologue_test): Add PACIASP test.
12428         (aarch64_prologue_prev_register): Unmask PC value.
12429
12430 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12431             Jiong Wang  <jiong.wang@arm.com>
12432
12433         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12434         (aarch64_dwarf2_prev_register): Unmask PC value.
12435         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12436         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12437         DW_CFA_AARCH64_negate_ra_state.
12438         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12439
12440 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12441             Jiong Wang  <jiong.wang@arm.com>
12442
12443         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12444         registers.
12445         (aarch64_pseudo_register_name): Likewise.
12446         (aarch64_pseudo_register_type): Likewise.
12447         (aarch64_pseudo_register_reggroup_p): Likewise.
12448         (aarch64_gdbarch_init): Add pauth registers.
12449         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12450         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12451         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12452         (struct gdbarch_tdep): Add regnum for ra_state.
12453
12454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12455             Jiong Wang  <jiong.wang@arm.com>
12456
12457         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12458
12459 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12460             Jiong Wang  <jiong.wang@arm.com>
12461
12462         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12463         function.
12464         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12465         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12466         (aarch64_gdbarch_init): Add puth registers.
12467         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12468         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12469         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12470
12471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12472             Jiong Wang  <jiong.wang@arm.com>
12473
12474         * aarch64-linux-nat.c
12475         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12476         * aarch64-linux-tdep.c
12477         (aarch64_linux_core_read_description): Likewise.
12478         (aarch64_linux_get_hwcap): New function.
12479         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12480         (aarch64_linux_get_hwcap): New declaration.
12481
12482 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12483             Jiong Wang  <jiong.wang@arm.com>
12484
12485         * aarch64-linux-nat.c
12486         (aarch64_linux_nat_target::read_description): Add pauth param.
12487         * aarch64-linux-tdep.c
12488         (aarch64_linux_core_read_description): Likewise.
12489         * aarch64-tdep.c (struct target_desc): Add in pauth.
12490         (aarch64_read_description): Add pauth param.
12491         (aarch64_gdbarch_init): Likewise.
12492         * aarch64-tdep.h (aarch64_read_description): Likewise.
12493         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12494         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12495         * features/Makefile: Add new files.
12496         * features/aarch64-pauth.c: New file.
12497         * features/aarch64-pauth.xml: New file.
12498
12499 2019-03-20  Tom Tromey  <tromey@adacore.com>
12500
12501         * infrun.c (handle_inferior_event): Rename from
12502         handle_inferior_event_1.  Create a scoped_value_mark.
12503         (handle_inferior_event): Remove.
12504
12505 2019-03-19  Tom Tromey  <tromey@adacore.com>
12506
12507         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12508         * infrun.h (print_stop_event): Add "displays" parameter.
12509         * infrun.c (print_stop_event): Add "displays" parameter.
12510
12511 2019-03-19  Pedro Alves  <palves@redhat.com>
12512
12513         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12514         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12515         to -1.  Fix TABs vs spaces.
12516         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12517         * tui/tui-out.h (tui_ui_out) Add intro comments.
12518         <m_line, m_start_of_line>: In-class initialize, and add describing
12519         comment.
12520
12521 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12522
12523         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12524         variable names.
12525         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12526
12527 2019-03-18  Pedro Alves  <palves@redhat.com>
12528             Eli Zaretskii <eliz@gnu.org>
12529
12530         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12531         m_line and m_start_of_line.
12532
12533 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12534
12535         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12536         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12537         it returns a newline.  This fixes a regression in TU mode, whereby
12538         the next line is output on the same screen line as the user input.
12539
12540 2019-03-18  Tom Tromey  <tromey@adacore.com>
12541
12542         * minsyms.c (minimal_symbol_reader::install): Remove call to
12543         obstack_blank.
12544
12545 2019-03-18  Pedro Alves  <palves@redhat.com>
12546
12547         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12548         New globals.
12549         (apply_style): New, factored out from ...
12550         (apply_ansi_escape): ... this.  Handle reverse video mode.
12551         (tui_set_reverse_mode): New function.
12552         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12553         * tui/tui-winsource.c (tui_show_source_line): Use
12554         tui_set_reverse_mode instead of setting A_STANDOUT.
12555         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12556         New setter methods.
12557
12558 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12559
12560         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12561         Handle tabs.
12562
12563 2019-03-18  Tom Tromey  <tromey@adacore.com>
12564
12565         * ada-lang.c (empty_array): Add "high" parameter.
12566         (ada_evaluate_subexp): Update.
12567
12568 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12569
12570         * unittests/string_view-selftests.c: Define
12571         _initialize_string_view_selftests unconditionally.
12572
12573 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12574
12575         PR gdb/24350
12576         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12577
12578 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12579
12580         PR gdb/24351
12581         * windows-nat.c (display_selector): Fix format specifiers.
12582
12583 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12584
12585         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12586         tui_refill_source_window instead of tui_refresh_win, to update the
12587         current execution line.  This fixes redisplay of the current line
12588         when stepping through the code with "next" or "step".
12589
12590 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12591
12592         * source-cache.c (source_cache::get_source_lines): Call
12593         find_source_lines to initialize s->nlines.  This fixes vertical
12594         scrolling of TUI source window when the DOWN arrow is pressed.
12595
12596 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12597
12598         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12599         linux-thread-db.c (_initialize_thread_db): Likewise.
12600
12601 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12602
12603         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12604         wclrtoeol in tui_show_source_line".  This reverts changes made in
12605         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12606
12607 2019-03-15  Tom Tromey  <tom@tromey.com>
12608
12609         * symtab.h (struct minimal_symbol): Derive from
12610         general_symbol_info.
12611         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12612         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12613         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12614         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12615         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12616         (MSYMBOL_SEARCH_NAME): Update.
12617         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12618         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12619         * minsyms.c (minimal_symbol_reader::record_full): Update.
12620
12621 2019-03-15  Tom Tromey  <tom@tromey.com>
12622
12623         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12624
12625 2019-03-15  Tom Tromey  <tom@tromey.com>
12626
12627         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12628         unique_xmalloc_ptr.
12629         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12630         Update.
12631         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12632         (build_minimal_symbol_hash_tables)
12633         (minimal_symbol_reader::install): Update.
12634
12635 2019-03-15  Tom Tromey  <tom@tromey.com>
12636
12637         * symtab.c (create_demangled_names_hash): Update.
12638         (symbol_set_names): Update.
12639         * objfiles.h (struct objfile_per_bfd_storage)
12640         <demangled_names_hash>: Now an htab_up.
12641         * objfiles.c (objfile_per_bfd_storage): Simplify.
12642
12643 2019-03-15  Tom Tromey  <tom@tromey.com>
12644
12645         * objfiles.h (struct objfile_per_bfd_storage): Declare
12646         destructor.
12647         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12648         New.
12649         (get_objfile_bfd_data): Use new.  Don't initialize
12650         language_of_main.
12651         (free_objfile_per_bfd_storage): Remove.
12652         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12653
12654 2019-03-15  Tom Tromey  <tom@tromey.com>
12655
12656         * symfile.c (reread_symbols): Update.
12657         * objfiles.c (objfile::objfile): Update.
12658         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12659         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12660         comment.
12661         (minimal_symbol_reader::install): Update.
12662         (terminate_minimal_symbol_table): Remove.
12663         * jit.c (jit_object_close_impl): Update.
12664
12665 2019-03-15  Tom Tromey  <tom@tromey.com>
12666
12667         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12668         initializations.
12669
12670 2019-03-15  Tom Tromey  <tom@tromey.com>
12671
12672         * objfiles.h (struct objfile_per_bfd_storage)
12673         <demangled_hash_languages>: Now a bitset.
12674         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12675         (lookup_minimal_symbol): Update.
12676
12677 2019-03-15  Tom Tromey  <tom@tromey.com>
12678
12679         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12680         Don't return the symbol.
12681         * coffread.c (record_minimal_symbol): Use record_full.
12682
12683 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12684
12685         The MS-Windows port of ncurses fails to switch to a color pair if
12686         one or both of the colors are the implicit default colors.  This
12687         change records the default colors when TUI is initialized, and
12688         then specifies them explicitly when a color pair uses the default
12689         colors.  This allows color styling in TUI mode on MS-Windows.
12690
12691         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12692         ncurses_norm_attr.
12693         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12694         colors in ncurses_norm_attr.
12695         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12696         "none", replace it with the default color recorded in
12697         ncurses_norm_attr.
12698
12699 2019-03-14  Tom Tromey  <tromey@adacore.com>
12700
12701         * source-cache.h (class source_cache) <get_source_lines>: Return
12702         std::string.
12703         * source-cache.c (source_cache::extract_lines): Handle case where
12704         first_pos==npos.  Return std::string.
12705         (source_cache::get_source_lines): Update.
12706
12707 2019-03-14  Tom Tromey  <tromey@adacore.com>
12708
12709         * NEWS: Add item for "style sources" commands.
12710         * source-cache.c (source_cache::get_source_lines): Check
12711         source_styling.
12712         * cli/cli-style.c (source_styling): New global.
12713         (_initialize_cli_style): Add "style sources" commands.
12714         (show_style_sources): New function.
12715         * cli/cli-style.h (source_styling): Declare.
12716
12717 2019-03-14  Pedro Alves  <palves@redhat.com>
12718             Tom Tromey  <tromey@adacore.com>
12719
12720         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12721         * tui/tui-winsource.c (tui_refill_source_window): New function,
12722         from...
12723         (tui_horizontal_source_scroll): ... here.  Move some logic.
12724         * cli/cli-style.c (set_style_enabled): Notify new observable.
12725         * tui/tui-hooks.c (tui_redisplay_source): New function.
12726         (tui_attach_detach_observers): Attach or detach
12727         tui_redisplay_source.
12728         * observable.h (source_styling_changed): New observable.
12729         * observable.c: Define source_styling_changed observable.
12730
12731 2019-03-13  Tom Tromey  <tromey@adacore.com>
12732
12733         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12734         (i386_gnu_nat_target::store_registers): Update.
12735         * target-debug.h (target_debug_print_std_string): New macro.
12736         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12737         * windows-tdep.c (display_one_tib): Update.
12738         * tui/tui-stack.c (tui_make_status_line): Update.
12739         * top.c (print_inferior_quit_action): Update.
12740         * thread.c (thr_try_catch_cmd): Update.
12741         (add_thread_with_info): Update.
12742         (thread_target_id_str): Update.
12743         (thr_try_catch_cmd): Update.
12744         (thread_command): Update.
12745         (thread_find_command): Update.
12746         * record-btrace.c (record_btrace_target::info_record)
12747         (record_btrace_resume_thread, record_btrace_target::resume)
12748         (record_btrace_cancel_resume, record_btrace_step_thread)
12749         (record_btrace_target::wait, record_btrace_target::wait)
12750         (record_btrace_target::wait, record_btrace_target::stop): Update.
12751         * progspace.c (print_program_space): Update.
12752         * process-stratum-target.c
12753         (process_stratum_target::thread_address_space): Update.
12754         * linux-fork.c (linux_fork_mourn_inferior)
12755         (detach_checkpoint_command, info_checkpoints_command)
12756         (linux_fork_context): Update.
12757         (linux_fork_detach): Update.
12758         (class scoped_switch_fork_info): Update.
12759         (delete_checkpoint_command): Update.
12760         * infrun.c (follow_fork_inferior): Update.
12761         (follow_fork_inferior): Update.
12762         (proceed_after_vfork_done): Update.
12763         (handle_vfork_child_exec_or_exit): Update.
12764         (follow_exec): Update.
12765         (displaced_step_prepare_throw): Update.
12766         (displaced_step_restore): Update.
12767         (start_step_over): Update.
12768         (resume_1): Update.
12769         (clear_proceed_status_thread): Update.
12770         (proceed): Update.
12771         (print_target_wait_results): Update.
12772         (do_target_wait): Update.
12773         (context_switch): Update.
12774         (stop_all_threads): Update.
12775         (restart_threads): Update.
12776         (finish_step_over): Update.
12777         (handle_signal_stop): Update.
12778         (switch_back_to_stepped_thread): Update.
12779         (keep_going_pass_signal): Update.
12780         (print_exited_reason): Update.
12781         (normal_stop): Update.
12782         * inferior.c (inferior_pid_to_str): Change return type.
12783         (print_selected_inferior): Update.
12784         (add_inferior): Update.
12785         (detach_inferior): Update.
12786         * dummy-frame.c (fprint_dummy_frames): Update.
12787         * dcache.c (dcache_info_1): Update.
12788         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12789         (btrace_fetch, btrace_clear): Update.
12790         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12791         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12792         type.
12793         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12794         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12795         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12796         * gdbarch.c, gdbarch.h: Rebuild.
12797         * gdbarch.sh (core_pid_to_str): Change return type.
12798         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12799         return type.
12800         (windows_nat_target::pid_to_str): Change return type.
12801         (windows_delete_thread): Update.
12802         (windows_nat_target::attach): Update.
12803         (windows_nat_target::files_info): Update.
12804         * target-delegates.c: Rebuild.
12805         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12806         return type.
12807         (sol_thread_target::pid_to_str): Change return type.
12808         * remote.c (class remote_target) <pid_to_str>: Change return
12809         type.
12810         (remote_target::pid_to_str): Change return type.
12811         (extended_remote_target::attach, remote_target::remote_stop_ns)
12812         (remote_target::remote_notif_remove_queued_reply)
12813         (remote_target::push_stop_reply, remote_target::disable_btrace):
12814         Update.
12815         (extended_remote_target::attach): Update.
12816         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12817         type.
12818         (gdbsim_target::pid_to_str): Change return type.
12819         * ravenscar-thread.c (struct ravenscar_thread_target)
12820         <pid_to_str>: Change return type.
12821         (ravenscar_thread_target::pid_to_str): Change return type.
12822         * procfs.c (class procfs_target) <pid_to_str>: Change return
12823         type.
12824         (procfs_target::pid_to_str): Change return type.
12825         (procfs_target::attach): Update.
12826         (procfs_target::detach): Update.
12827         (procfs_target::fetch_registers): Update.
12828         (procfs_target::store_registers): Update.
12829         (procfs_target::wait): Update.
12830         (procfs_target::files_info): Update.
12831         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12832         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12833         return type.
12834         (nto_procfs_target::pid_to_str): Change return type.
12835         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12836         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12837         return type.
12838         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12839         (exit_lwp): Update.
12840         (attach_proc_task_lwp_callback, get_detach_signal)
12841         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12842         (linux_nat_target::resume, wait_lwp, stop_callback)
12843         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12844         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12845         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12846         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12847         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12848         type.
12849         (inf_ptrace_target::attach): Update.
12850         (inf_ptrace_target::files_info): Update.
12851         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12852         type.
12853         (go32_nat_target::pid_to_str): Change return type.
12854         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12855         (gnu_nat_target::wait): Update.
12856         (gnu_nat_target::wait): Update.
12857         (gnu_nat_target::resume): Update.
12858         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12859         (fbsd_nat_target::wait): Update.
12860         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12861         type.
12862         (darwin_nat_target::attach): Update.
12863         * corelow.c (class core_target) <pid_to_str>: Change return type.
12864         (core_target::pid_to_str): Change return type.
12865         * target.c (normal_pid_to_str): Change return type.
12866         (default_pid_to_str): Likewise.
12867         (target_pid_to_str): Change return type.
12868         (target_translate_tls_address): Update.
12869         (target_announce_detach): Update.
12870         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12871         return type.
12872         (bsd_uthread_target::pid_to_str): Change return type.
12873         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12874         type.
12875         (bsd_kvm_target::pid_to_str): Change return type.
12876         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12877         return type.
12878         (aix_thread_target::pid_to_str): Change return type.
12879         * target.h (struct target_ops) <pid_to_str>: Change return type.
12880         (target_pid_to_str, normal_pid_to_str): Likewise.
12881         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12882         type.
12883         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12884         type.
12885         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12886         return type.
12887         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12888         type.
12889         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12890         type.
12891         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12892         return type.
12893
12894 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12895
12896         * NEWS: Mention that the new default MI version is 3.  Mention
12897         changes to the output of commands and events that deal with
12898         multi-location breakpoints.
12899         * breakpoint.c: Include "mi/mi-out.h".
12900         (print_one_breakpoint): Change output syntax if using MI version
12901         >= 3.
12902         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12903         New.
12904         (mi_multi_location_breakpoint_output_fixed): New.
12905         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12906         (mi_cmd_fix_multi_location_breakpoint_output): New.
12907         (mi_multi_location_breakpoint_output_fixed): New.
12908         * mi/mi-cmds.c (mi_cmds): Register command
12909         -fix-multi-location-breakpoint-output.
12910         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12911         interpreter "mi".
12912
12913 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12914
12915         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12916         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12917         instantiate mi_ui_out based on interpreter name.
12918         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12919         * mi/mi-main.c (mi_load_progress): Likewise.
12920
12921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12922
12923         * NEWS: Combine separate "New targets" sections for 8.3.
12924
12925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12926
12927         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12928         (ppcfbsd_init_abi): Install gdbarch
12929         "fetch_tls_load_module_address" and "get_thread_local_address"
12930         methods.
12931
12932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12933
12934         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12935         (riscv_fbsd_init_abi): Install gdbarch
12936         "fetch_tls_load_module_address" and "get_thread_local_address"
12937         methods.
12938
12939 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12940
12941         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12942         (i386fbsd_init_abi): Install gdbarch
12943         "fetch_tls_load_module_address" and "get_thread_local_address"
12944         methods.
12945
12946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12947
12948         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12949         (amd64fbsd_init_abi): Install gdbarch
12950         "fetch_tls_load_module_address" and "get_thread_local_address"
12951         methods.
12952
12953 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12954
12955         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12956         (struct fbsd_pspace_data): New type.
12957         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12958         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12959         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12960         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12961         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12962
12963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12964
12965         * gdbtypes.c (lookup_struct_elt): New function.
12966         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12967         * gdbtypes.h (struct struct_elt): New type.
12968         (lookup_struct_elt): New prototype.
12969
12970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12971
12972         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12973         remove disabled code block.
12974
12975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12976
12977         * gdbarch.sh (get_thread_local_address): New method.
12978         * gdbarch.h, gdbarch.c: Regenerate.
12979         * target.c (target_translate_tls_address): Use
12980         gdbarch_get_thread_local_address if present instead of
12981         target::get_thread_local_address.
12982
12983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12984
12985         * target.h (target::get_thread_local_address): Update comment.
12986
12987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12988
12989         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12990         objfile->separate_debug_objfile_backlink if not NULL.
12991
12992 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12993
12994         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12995         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12996         (amd64bsd_store_inferior_registers): Likewise.
12997         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12998         Enable segment base registers.
12999         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13000         PT_GETFSBASE and PT_GETGSBASE.
13001         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13002         PT_SETGSBASE.
13003         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13004         segment base registers.
13005         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13006
13007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13008
13009         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13010         Update calls to i386_target_description to add 'segments'
13011         parameter.
13012         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13013         add segment base registers.
13014         * arch/i386.c (i386_create_target_description): Add 'segments'
13015         parameter to enable segment base registers.
13016         * arch/i386.h (i386_create_target_description): Likewise.
13017         * features/i386/32bit-segments.xml: New file.
13018         * features/i386/32bit-segments.c: Generate.
13019         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13020         call to i386_target_description to add 'segments' parameter.
13021         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13022         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13023         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13024         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13025         if feature is present.
13026         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13027         Add 'segments' parameter to call to i386_target_description.
13028         (i386_target_description): Add 'segments' parameter to enable
13029         segment base registers.
13030         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13031         to call to i386_target_description.
13032         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13033         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13034         Define I386_NUM_REGS.
13035         (i386_target_description): Add 'segments' parameter to enable
13036         segment base registers.
13037
13038 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13039
13040         PR/24325
13041         * source-cache.c: #undef open and close, to avoid unresolved
13042         externals during linking.
13043
13044 2019-03-12  Tom Tromey  <tromey@adacore.com>
13045
13046         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13047         const.  Add initializers.
13048         (_initialize_remote): Don't initialize ptid globals.
13049
13050 2019-03-12  Pedro Alves  <palves@redhat.com>
13051
13052         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13053
13054 2019-03-12  Pedro Alves  <palves@redhat.com>
13055
13056         * cp-name-parser.y (main): Remove unused 'len' variable.
13057
13058 2019-03-12  Tom Tromey  <tromey@adacore.com>
13059
13060         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13061         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13062
13063 2019-03-12  Tom Tromey  <tromey@adacore.com>
13064
13065         * linux-nat.c (iterate_over_lwps): Update.
13066         (stop_callback): Remove parameter.
13067         (stop_wait_callback, detach_callback, resume_set_callback)
13068         (select_singlestep_lwp_callback, set_ignore_sigint)
13069         (status_callback, resumed_callback, resume_clear_callback)
13070         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13071         data parameter.
13072         (linux_nat_target::detach, linux_nat_target::resume)
13073         (linux_stop_and_wait_all_lwps, select_event_lwp)
13074         (linux_nat_filter_event, linux_nat_wait_1)
13075         (linux_nat_target::kill, linux_nat_target::stop)
13076         (linux_nat_target::stop): Update.
13077         (linux_nat_resume_callback): Change type.
13078         (resume_stopped_resumed_lwps, count_events_callback)
13079         (select_event_lwp_callback): Likewise.
13080         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13081         * arm-linux-nat.c (struct update_registers_data): Remove.
13082         (update_registers_callback): Change type.
13083         (arm_linux_insert_hw_breakpoint1): Update.
13084         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13085         parameter.
13086         (x86_linux_dr_set_addr): Update.
13087         (x86_linux_dr_set_control): Update.
13088         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13089         (iterate_over_lwps): Use gdb::function_view.
13090         * nat/aarch64-linux-hw-point.c (struct
13091         aarch64_dr_update_callback_param): Remove.
13092         (debug_reg_change_callback): Change type.
13093         (aarch64_notify_debug_reg_change): Update.
13094         * s390-linux-nat.c (s390_refresh_per_info): Update.
13095
13096 2019-03-11  Tom Tromey  <tromey@adacore.com>
13097
13098         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13099         redundant assignment to "this_cu".
13100
13101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13102
13103         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13104
13105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13106
13107         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13108         from...
13109         (rank_one_type): ... this.
13110
13111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13112
13113         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13114         from...
13115         (rank_one_type): ... this.
13116
13117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13118
13119         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13120         from...
13121         (rank_one_type): ... this.
13122
13123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13124
13125         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13126         from...
13127         (rank_one_type): ... this.
13128
13129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13130
13131         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13132         from...
13133         (rank_one_type): ... this.
13134
13135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13136
13137         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13138         from...
13139         (rank_one_type): ... this.
13140
13141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13142
13143         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13144         from...
13145         (rank_one_type): ... this.
13146
13147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13148
13149         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13150         from...
13151         (rank_one_type): ... this.
13152
13153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13154
13155         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13156         from...
13157         (rank_one_type): ... this.
13158
13159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13160
13161         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13162         from...
13163         (rank_one_type): ... this.
13164
13165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13166
13167         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13168         from...
13169         (rank_one_type): ... this.
13170
13171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13172
13173         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13174         from...
13175         (rank_one_type): ... this.
13176
13177 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13178
13179         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13180         inferior-events' shows the example events.
13181
13182 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13183
13184         Support styling on native MS-Windows console
13185
13186         PR/24315
13187         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13188         on MS-Windows if $TERM is not defined.
13189
13190         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13191
13192         * posix-hdep.c (gdb_console_fputs):
13193         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13194         functions.
13195         * ui-file.h (gdb_console_fputs): Add prototype.
13196
13197         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13198         back to fputs only if the former returns zero.
13199
13200 2019-03-07  Tom Tromey  <tom@tromey.com>
13201
13202         * symmisc.c (print_symbol_bcache_statistics): Update.
13203         (print_objfile_statistics): Update.
13204         * symfile.c (allocate_symtab): Update.
13205         * stabsread.c: Don't include bcache.h.
13206         * psymtab.h (struct psymbol_bcache): Don't declare.
13207         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13208         (psymbol_bcache_init, psymbol_bcache_free)
13209         (psymbol_bcache_get_bcache): Don't declare.
13210         * psymtab.c (struct psymbol_bcache): Remove.
13211         (psymtab_storage::psymtab_storage): Update.
13212         (psymtab_storage::~psymtab_storage): Update.
13213         (psymbol_bcache_init, psymbol_bcache_free)
13214         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13215         (add_psymbol_to_bcache): Update.
13216         (allocate_psymtab): Update.
13217         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13218         macro_cache>: No longer pointers.
13219         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13220         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13221         * macrotab.c (macro_bcache): Update.
13222         * macroexp.c: Don't include bcache.h.
13223         * gdbtypes.c (check_types_worklist): Update.
13224         (types_deeply_equal): Remove TRY/CATCH.  Update.
13225         * elfread.c (elf_symtab_read): Update.
13226         * dwarf2read.c: Don't include bcache.h.
13227         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13228         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13229         (print_bcache_statistics, bcache_memory_used): Don't declare.
13230         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13231         methods.  Rename all data members.
13232         * bcache.c (struct bcache): Move to bcache.h.
13233         (bcache::expand_hash_table): Rename from expand_hash_table.
13234         (bcache): Remove.
13235         (bcache::insert): Rename from bcache_full.
13236         (bcache::compare): Rename from bcache_compare.
13237         (bcache_xmalloc): Remove.
13238         (bcache::~bcache): Rename from bcache_xfree.
13239         (bcache::print_statistics): Rename from print_bcache_statistics.
13240         (bcache::memory_used): Rename from bcache_memory_used.
13241
13242 2019-03-07  Pedro Alves  <palves@redhat.com>
13243
13244         * infrun.c (normal_stop): Also check for
13245         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13246
13247 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13248
13249         * f-lang.c (value_from_host_double): Moved to...
13250         * value.c (value_from_host_double): ...here.
13251         * value.h (value_from_host_double): Declare.
13252         * guile/scm-math.c (vlscm_convert_typed_number): Use
13253         value_from_host_double.
13254         (vlscm_convert_number): Likewise.
13255         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13256         * python/py-value.c (convert_value_from_python): Likewise.
13257
13258 2019-03-06  Tom Tromey  <tom@tromey.com>
13259
13260         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13261
13262 2019-03-06  Tom Tromey  <tom@tromey.com>
13263
13264         * utils.h (free_current_contents): Don't declare.
13265         * utils.c (free_current_contents): Remove.
13266
13267 2019-03-06  Tom Tromey  <tom@tromey.com>
13268
13269         * top.c (quit_force): Update.
13270         * main.c (captured_command_loop): Update.
13271         * common/new-op.c (operator new): Update.
13272         * common/common-exceptions.c (struct catcher)
13273         <save_cleanup_chain>: Remove member.
13274         (exceptions_state_mc_init): Update.
13275         (exception_try_scope_entry): Return nullptr.
13276         (exception_try_scope_exit, exception_rethrow)
13277         (throw_exception_sjlj, throw_exception_cxx): Update.
13278         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13279         (all_cleanups, do_cleanups, discard_cleanups)
13280         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13281         (restore_cleanups, restore_final_cleanups): Don't declare.
13282         (do_final_cleanups): Remove parameter.
13283         * common/cleanups.c (cleanup_chain, make_cleanup)
13284         (make_cleanup_dtor, all_cleanups, do_cleanups)
13285         (discard_my_cleanups, discard_cleanups)
13286         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13287         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13288         (null_cleanup): Remove.
13289         (do_final_cleanups): Remove parameter.
13290
13291 2019-03-06  Tom Tromey  <tom@tromey.com>
13292
13293         * remote.c (remote_target::remote_parse_stop_reply): Use
13294         unique_xmalloc_ptr.
13295
13296 2019-03-06  Tom Tromey  <tom@tromey.com>
13297
13298         * stabsread.c (struct stabs_field_info): Rename from field_info.
13299         <list, fnlist>: Add initializers.
13300         <obstack>: New member.
13301         (read_member_functions, read_struct_fields, read_baseclasses):
13302         Allocate on obstack.  Don't use cleanups.
13303         (read_one_struct_field, read_member_functions, read_struct_fields)
13304         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13305         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13306         (read_struct_type): Update.
13307
13308 2019-03-06  Tom Tromey  <tom@tromey.com>
13309
13310         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13311         * common/filestuff.h (make_cleanup_close): Don't declare.
13312         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13313         Remove.
13314
13315 2019-03-06  Tom Tromey  <tom@tromey.com>
13316
13317         * solib-aix.c: Use make_scope_exit.
13318
13319 2019-03-06  Tom Tromey  <tom@tromey.com>
13320
13321         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13322         Use make_scope_exit.
13323
13324 2019-03-06  Tom Tromey  <tom@tromey.com>
13325
13326         * solib-svr4.c (disable_probes_interface): Remove parameter.
13327         (svr4_handle_solib_event): Use make_scope_exit.
13328
13329 2019-03-06  Tom Tromey  <tom@tromey.com>
13330
13331         * remote.c (struct stop_reply_deleter): Remove.
13332         (stop_reply_up): Update.
13333         (struct stop_reply): Derive from notif_event.  Don't typedef.
13334         <regcache>: Now a std::vector.
13335         (stop_reply_xfree): Remove.
13336         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13337         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13338         (remote_target::discard_pending_stop_replies): Use delete.
13339         (remote_target::remote_parse_stop_reply): Update.
13340         (remote_target::process_stop_reply): Update.
13341         * remote-notif.h (struct notif_event): Add virtual destructor.
13342         Remove "dtr" member.
13343         (struct notif_client) <alloc_event>: Return a unique_ptr.
13344         (notif_event_xfree): Don't declare.
13345         (notif_event_up): New typedef.
13346         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13347         (notif_event_xfree, do_notif_event_xfree): Remove.
13348         (remote_notif_state_xfree): Update.
13349
13350 2019-03-06  Tom Tromey  <tom@tromey.com>
13351
13352         * infrun.c (displaced_step_clear_cleanup): Now a
13353         forward_scope_exit type.
13354         (displaced_step_prepare_throw): Update.
13355         (displaced_step_fixup): Update.
13356
13357 2019-03-06  Tom Tromey  <tom@tromey.com>
13358
13359         * inferior.h (class inferior): Update comment.
13360         * gdbthread.h (class thread_info): Update comment.
13361
13362 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13363             Tom Tromey  <tom@tromey.com>
13364
13365         * stabsread.h (struct stab_section_list): Remove.
13366         (coffstab_build_psymtabs): Update.
13367         * dbxread.c (symbuf_sections): Now a std::vector.
13368         (sect_idx): New global.
13369         (fill_symbuf): Update.
13370         (coffstab_build_psymtabs): Change type of stabsects parameter.
13371         Update.
13372         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13373         std::vector.
13374         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13375         (coff_locate_sections): Update.
13376         (coff_symfile_read): Remove cleanups.  Update.
13377         (init_stringtab): Add storage parameter.
13378         (free_stringtab, free_stringtab_cleanup): Remove.
13379         (init_lineno): Add storage parameter.
13380         (free_linetab, free_linetab_cleanup): Remove.
13381
13382 2019-03-06  Pedro Alves  <palves@redhat.com>
13383
13384         * linux-fork.c (fork_info::clobber_regs): Delete.
13385         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13386         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13387         comment.  Adjust.
13388         (scoped_switch_fork_info::scoped_switch_fork_info)
13389         (checkpoint_command, linux_fork_context): Adjust
13390         fork_save_infrun_state calls.
13391
13392 2019-03-06  Pedro Alves  <palves@redhat.com>
13393
13394         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13395         (inf_has_multiple_threads): Return 'bool' and rewrite using
13396         inferior_info::threads().
13397
13398 2019-03-06  Pedro Alves  <palves@redhat.com>
13399
13400         * linux-fork.c: Include <list>.
13401         (fork_list): Now a std::list instance.
13402         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13403         (forks_exist_p, find_last_fork): Adjust.
13404         (new_fork): Delete.
13405         (one_fork_p): New.
13406         (add_fork): Adjust.
13407         (free_fork): Delete, folded into fork_info::~fork_info().
13408         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13409         Adjust.
13410         (init_fork_list): Delete.
13411         (linux_fork_killall, linux_fork_mourn_inferior)
13412         (linux_fork_detach, info_checkpoints_command): Adjust.
13413         (_initialize_linux_fork): No longer call init_fork_list.
13414
13415 2019-03-06  Pedro Alves  <palves@redhat.com>
13416
13417         * linux-fork.c (new_fork): New, split out of ...
13418         (add_fork): ... this.  Return void.  Move "first fork" special
13419         case from here, to ...
13420         (checkpoint_command): ... here.
13421         * linux-linux.h (add_fork): Return void.
13422
13423 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13424
13425         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13426
13427 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13428             Chris January  <chris.january@arm.com>
13429             David Lecomber  <david.lecomber@arm.com>
13430
13431         * f-exp.y: New token, UNOP_INTRINSIC.
13432         (exp): New pattern using UNOP_INTRINSIC token.
13433         (f77_keywords): Add 'abs' keyword.
13434         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13435         (value_from_host_double): New function.
13436         (evaluate_subexp_f): Support UNOP_ABS.
13437
13438 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13439
13440         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13441         types.
13442
13443 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13444
13445         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13446         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13447         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13448
13449 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13450
13451         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13452
13453 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13454             Chris January  <chris.january@arm.com>
13455
13456         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13457         * f-exp.y: Define 'KIND' token.
13458         (exp): New pattern for KIND expressions.
13459         (ptype): Handle types with a kind extension.
13460         (direct_abs_decl): Extend to spot kind extensions.
13461         (f77_keywords): Add 'kind' to the list.
13462         (push_kind_type): New function.
13463         (convert_to_kind_type): New function.
13464         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13465         * parse.c (operator_length_standard): Likewise.
13466         * parser-defs.h (enum type_pieces): Add tp_kind.
13467         * std-operator.def: Add UNOP_KIND.
13468
13469 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13470
13471         * f-exp.y (f_parse): Set yydebug.
13472
13473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13474
13475         * f-lang.c (evaluate_subexp_f): New function.
13476         (exp_descriptor_f): New global.
13477         (f_language_defn): Use exp_descriptor_f instead of
13478         exp_descriptor_standard.
13479
13480 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13481
13482         * f-exp.y (struct token): Add comments.
13483         (dot_ops): Remove uppercase versions and the end marker.
13484         (f77_keywords): Likewise.
13485         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13486         entries in the dot_ops array are case insensitive, and use
13487         strncasecmp to compare strings.  Also some whitespace cleanup in
13488         this area.  Similar for the f77_keywords array, except entries in
13489         this list might be case sensitive.
13490
13491 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13492
13493         * f-exp.y (struct f77_boolean_val): Add comments.
13494         (boolean_values): Remove uppercase versions, and end marker.
13495         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13496         and use strncasecmp to achieve case insensitivity.  Additionally,
13497         perform whitespace cleanup around this code.
13498
13499 2019-03-06  Tom Tromey  <tromey@adacore.com>
13500
13501         * remote-sim.c (gdbsim_target_open): Use result of
13502         gdb_argv::release.
13503
13504 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13505         Dirk Schubert  <dirk.schubert@arm.com>
13506         Chris January  <chris.january@arm.com>
13507
13508         * eval.c (evaluate_subexp_standard): Call Fortran argument
13509         wrapping logic.
13510         * f-lang.c (struct value): A value which can be passed into a
13511         Fortran function call.
13512         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13513         where appropriate.
13514         (struct type): Value ready for a Fortran function call.
13515         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13516         is needed.
13517         * f-lang.h (fortran_argument_convert): Declaration.
13518         (fortran_preserve_arg_pointer): Declaration.
13519         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13520
13521 2019-03-05  Tom Tromey  <tromey@adacore.com>
13522
13523         * python/py-prettyprint.c (print_string_repr): Remove #if.
13524         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13525
13526 2019-03-05  Tom Tromey  <tromey@adacore.com>
13527
13528         * target.c (the_dummy_target): Move later.  Change type to
13529         "dummy_target".
13530         (initialize_targets): Don't initialize the_dummy_target.
13531
13532 2019-03-05  Tom Tromey  <tromey@adacore.com>
13533
13534         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13535         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13536
13537 2019-03-05  Tom Tromey  <tromey@adacore.com>
13538
13539         * windows-nat.c (windows_nat_target::attach)
13540         (windows_nat_target::detach): Don't call gdb_flush.
13541         * valprint.c (generic_val_print, val_print, val_print_string):
13542         Don't call gdb_flush.
13543         * utils.c (defaulted_query): Don't call gdb_flush.
13544         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13545         * target.c (target_announce_detach): Don't call gdb_flush.
13546         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13547         * remote.c (extended_remote_target::attach): Don't call
13548         gdb_flush.
13549         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13550         * printcmd.c (do_examine): Don't call gdb_flush.
13551         (info_display_command): Don't call gdb_flush.
13552         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13553         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13554         * memattr.c (info_mem_command): Don't call gdb_flush.
13555         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13556         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13557         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13558         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13559         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13560         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13561         (gnu_nat_target::detach): Don't call gdb_flush.
13562         * f-valprint.c (f_val_print): Don't call gdb_flush.
13563         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13564         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13565         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13566         gdb_flush.
13567         * c-valprint.c (c_val_print): Don't call gdb_flush.
13568         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13569
13570 2019-03-05  Tom Tromey  <tromey@adacore.com>
13571
13572         * varobj.c (update_dynamic_varobj_children): Update.
13573         (install_default_visualizer): Use reset, not release.
13574         * value.c (set_internalvar): Update.
13575         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13576         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13577         ATTRIBUTE_UNUSED_RESULT.
13578
13579 2019-03-05  Tom Tromey  <tromey@adacore.com>
13580
13581         * remote.c (class scoped_remote_fd) <release>: Add
13582         ATTRIBUTE_UNUSED_RESULT.
13583
13584 2019-03-05  Tom Tromey  <tromey@adacore.com>
13585
13586         * macroexp.c (struct macro_buffer) <release>: Add
13587         ATTRIBUTE_UNUSED_RESULT.
13588
13589 2019-03-05  Tom Tromey  <tromey@adacore.com>
13590
13591         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13592         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13593         ATTRIBUTE_UNUSED_RESULT.
13594
13595 2019-03-05  Tom Tromey  <tromey@adacore.com>
13596
13597         * common/scoped_fd.h (class scoped_fd) <release>: Add
13598         ATTRIBUTE_UNUSED_RESULT.
13599
13600 2019-03-05  Tom Tromey  <tromey@adacore.com>
13601
13602         * parser-defs.h (struct parser_state) <release>: Add
13603         ATTRIBUTE_UNUSED_RESULT.
13604
13605 2019-03-05  Tom Tromey  <tromey@adacore.com>
13606
13607         * utils.h (class gdb_argv) <release>: Add
13608         ATTRIBUTE_UNUSED_RESULT.
13609         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13610
13611 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13612
13613         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13614         for-loop range, to avoid compiler warnings.
13615
13616         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13617         avoid compiler warnings about unused variables.
13618
13619         * NEWS: Mention end of support for native debugging on MS-Windows
13620         before XP.
13621
13622         PR gdb/24292
13623         * common/netstuff.c:
13624         * gdbserver/gdbreplay.c
13625         * gdbserver/remote-utils.c:
13626         * ser-tcp.c:
13627         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13628         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13629         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13630         'getaddrinfo' and 'freeaddrinfo' were not available before
13631         Windows XP, and mingw.org's MinGW headers by default define
13632         _WIN32_WINNT to 0x500.
13633
13634 2019-03-01  Gary Benson <gbenson@redhat.com>
13635
13636         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13637
13638 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13639             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13640
13641         PR gdb/8527
13642         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13643         set_sigint_trap, clear_sigint_trap.
13644
13645 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13646
13647         * target.c (target_detach): Clear the regcache and the
13648         frame cache.
13649
13650 2019-02-27  Pedro Alves  <palves@redhat.com>
13651
13652         * utils.c (set_screen_size): When we cap the height/width sizes,
13653         tweak the corresponding command variable to show "unlimited":
13654
13655 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13656             Pedro Alves  <palves@redhat.com>
13657
13658         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13659         before calling rl_set_screen_size.
13660
13661 2019-02-27  Tom Tromey  <tromey@adacore.com>
13662
13663         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13664         define.
13665         * python/py-value.c: Remove Python 2.4 workaround.
13666         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13667         workaround.
13668         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13669         Python 2.4 workaround.
13670         * python/python-internal.h: Remove Python 2.4 comment.
13671         (Py_ssize_t): Don't define.
13672         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13673         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13674         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13675         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13676         * python/python.c (do_start_initialization): Remove Python 2.4
13677         workaround.
13678         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13679         (print_children): Remove Python 2.4 workaround.
13680         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13681         workaround.
13682         (CHARBUFFERPROC_NAME): Remove.
13683         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13684         Python 2.4 workaround.
13685
13686 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13687
13688         * NEWS: Note minimum Python version.
13689
13690 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13691
13692         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13693         code from these functions.  Remove corresponding ifdefs.  Use
13694         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13695         Remove gotos and target of gotos.
13696         (infpy_search_memory): Likewise.
13697
13698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13699
13700         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13701         (hppa_gdbarch_init): Don't register deleted functions with
13702         gdbarch.
13703
13704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13705
13706         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13707         (h8300_unwind_sp): Delete.
13708         (h8300_dummy_id): Delete.
13709         (h8300_gdbarch_init): Don't register deleted functions with
13710         gdbarch.
13711
13712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13713
13714         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13715         (ft32_unwind_pc): Delete.
13716         (ft32_unwind_sp): Delete.
13717         (ft32_gdbarch_init): Don't register deleted functions with
13718         gdbarch.
13719
13720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13721
13722         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13723         (frv_unwind_pc): Delete.
13724         (frv_unwind_sp): Delete.
13725         (frv_gdbarch_init): Don't register deleted functions with
13726         gdbarch.
13727
13728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13729
13730         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13731         (riscv_unwind_pc): Delete.
13732         (riscv_unwind_sp): Delete.
13733         (riscv_gdbarch_init): Don't register deleted functions with
13734         gdbarch.
13735
13736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13737
13738         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13739         (csky_unwind_pc): Delete.
13740         (csky_unwind_sp): Delete.
13741         (csky_gdbarch_init): Don't register deleted functions with
13742         gdbarch.
13743
13744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13745
13746         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13747         (cris_unwind_pc): Delete.
13748         (cris_unwind_sp): Delete.
13749         (cris_gdbarch_init): Don't register deleted functions with
13750         gdbarch.
13751
13752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13753
13754         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13755         (bfin_unwind_pc): Delete.
13756         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13757
13758 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13759
13760         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13761         (arm_unwind_pc): Delete.
13762         (arm_unwind_sp): Delete.
13763         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13764
13765 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13766
13767         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13768         (arc_unwind_pc): Delete.
13769         (arc_unwind_sp): Delete.
13770         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13771
13772 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13773
13774         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13775         (alpha_unwind_pc): Delete.
13776         (alpha_gdbarch_init): Don't register deleted functions with
13777         gdbarch.
13778
13779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13780
13781         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13782         (aarch64_unwind_pc): Delete.
13783         (aarch64_unwind_sp): Delete.
13784         (aarch64_gdbarch_init): Don't register deleted functions with
13785         gdbarch.
13786
13787 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13788
13789         * gdbtypes.c (type_align): Don't consider static members when
13790         computing structure alignment.
13791
13792 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13793
13794         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13795         return 0 for other types.
13796         * arch-utils.c (default_type_align): Always return 0.
13797         * gdbarch.h: Regenerate.
13798         * gdbarch.sh (type_align): Extend comment.
13799         * gdbtypes.c (type_align): Add additional comments, always call
13800         gdbarch_type_align before applying the default rules.
13801         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13802         generic code will then apply a suitable default.
13803         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13804         types, return 0 for other types.
13805
13806 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13807
13808         * NEWS: Create a new section for the next release branch.
13809         Rename the section of the current branch, now that it has
13810         been cut.
13811
13812 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13813
13814         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13815         * version.in: Bump version to 8.3.50.DATE-git.
13816
13817 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13818
13819         * aix-thread.c (ptid_cmp): Remove unused variable.
13820         (get_signaled_thread): Likewise.
13821         (store_regs_user_thread): Likewise.
13822         (store_regs_kernel_thread): Likewise.
13823         (fetch_regs_kernel_thread): Remove shadowed variable.
13824
13825 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13826
13827         * features/riscv/32bit-cpu.xml: Add register numbers.
13828         * features/riscv/32bit-fpu.c: Regenerate.
13829         * features/riscv/32bit-fpu.xml: Add register numbers.
13830         * features/riscv/64bit-cpu.xml: Add register numbers.
13831         * features/riscv/64bit-fpu.c: Regenerate.
13832         * features/riscv/64bit-fpu.xml: Add register numbers.
13833
13834 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13835
13836         * NEWS: Mention two argument form of gdb.Value constructor.
13837         * python/py-value.c (convert_buffer_and_type_to_value): New
13838         function.
13839         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13840         Add support for handling an optional second argument.  Call
13841         convert_buffer_and_type_to_value as appropriate.
13842         * python/python-internal.h (Py_buffer_deleter): New struct.
13843         (Py_buffer_up): New typedef.
13844
13845 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13846
13847         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13848         instead of releasing ownership.
13849
13850 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13851
13852         * dwarf2read.c (open_and_init_dwp_file): Call
13853         elf_numsections instead of bfd_count_sections to initialize
13854         dwp_file->num_sections.
13855
13856 2019-02-25  Tom Tromey  <tromey@adacore.com>
13857
13858         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13859
13860 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13861
13862         * gcore.in: Add '--readnever' option when invoking GDB.
13863
13864 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13865
13866         * MAINTAINERS: Update my email address.
13867
13868 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13869
13870         * build-id.c (build_id_to_debug_bfd_1): New function.
13871         (build_id_to_debug_bfd): Look for separate debug file in
13872         sysroot.
13873
13874 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13875
13876         * gdbarch.sh: Update the copyright year range that is placed into
13877         generated files.
13878
13879 2019-02-22  Keith Seitz  <keiths@redhat.com>
13880
13881         PR symtab/23853
13882         * linespec.c (create_sals_line_offset): Search for the default
13883         symtab's filename instead of its fullname.
13884
13885 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13886
13887         * NEWS: Update style defaults.
13888
13889 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13890
13891         * main.c (captured_main_1): Disable styling in batch mode.
13892
13893 2019-02-20  Tom Tromey  <tom@tromey.com>
13894
13895         * symtab.c (symtab_symbol_info): Fix typos.
13896
13897 2019-02-20  Tom Tromey  <tromey@adacore.com>
13898
13899         * findcmd.c (_initialize_mem_search): Use upper case for
13900         metasyntactic variables.
13901
13902 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13903
13904         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13905         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13906
13907 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13908
13909         * top.h (source_file_name): Change to std::string.
13910         * top.c (source_file_name): Likewise.
13911         (command_line_input): Adjust.
13912         * cli/cli-script.c (script_from_file): Adjust.
13913
13914 2019-02-19  Tom Tromey  <tromey@adacore.com>
13915
13916         * ravenscar-thread.c
13917         (ravenscar_thread_target::update_thread_list): Don't call
13918         ada_build_task_list.
13919         * ada-lang.h (ada_build_task_list): Don't declare.
13920         * ada-tasks.c (struct ada_tasks_inferior_data)
13921         <task_list_valid_p>: Now bool.
13922         (read_known_tasks, ada_task_list_changed)
13923         (ada_tasks_invalidate_inferior_data): Update.
13924         (read_known_tasks_array): Return bool.
13925         (read_known_tasks_list): Likewise.
13926         (read_known_tasks): Return void.
13927         (ada_build_task_list): Now static.
13928
13929 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13930
13931         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13932         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13933
13934 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13935
13936         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13937         variant for ada_tasks_pspace_data_handle and
13938         ada_tasks_inferior_data_handle.
13939         (ada_tasks_pspace_data_cleanup): New function.
13940         (ada_tasks_inferior_data_cleanup): New function.
13941
13942 2019-02-17  Tom Tromey  <tom@tromey.com>
13943
13944         * macrotab.h (macro_source_fullname): Return a std::string.
13945         * macrotab.c (macro_include, check_for_redefinition)
13946         (macro_undef, macro_lookup_definition, foreach_macro)
13947         (foreach_macro_in_scope): Update.
13948         (macro_source_fullname): Return a std::string.
13949         * macrocmd.c (show_pp_source_pos): Update.
13950
13951 2019-02-17  Tom Tromey  <tom@tromey.com>
13952
13953         * macrocmd.c (show_pp_source_pos): Style the file names.
13954
13955 2019-02-17  Tom Tromey  <tom@tromey.com>
13956
13957         PR tui/24197:
13958         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13959
13960 2019-02-17  Tom Tromey  <tom@tromey.com>
13961
13962         * ada-lang.c (user_select_syms): Use filtered printing.
13963         * utils.c (wrap_style): New global.
13964         (desired_style): Remove.
13965         (emit_style_escape): Add stream parameter.
13966         (set_output_style, reset_terminal_style, prompt_for_continue):
13967         Update.
13968         (flush_wrap_buffer): Only flush gdb_stdout.
13969         (wrap_here): Set wrap_style.
13970         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13971         treat escape sequences as a character.  Change when wrap buffer is
13972         flushed.
13973         (fputs_styled): Do not set the output style when the default is
13974         requested.
13975         * ui-style.h (struct ui_file_style) <is_default>: New method.
13976         * source.c (print_source_lines_base): Emit escape sequences in one
13977         piece.
13978
13979 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13980
13981         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13982         integers and enumeration types.
13983
13984 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13985
13986         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13987         instead of lookup_symbol_in_language
13988         (do_exact_match): New function.
13989         (ada_get_symbol_name_matcher): Return do_exact_match when
13990         doing a verbatim match.
13991
13992 2019-02-15  Tom Tromey  <tromey@adacore.com>
13993
13994         * ravenscar-thread.c (ravenscar_thread_target::resume)
13995         (ravenscar_thread_target::wait): Special case wildcard requests.
13996
13997 2019-02-15  Tom Tromey  <tromey@adacore.com>
13998
13999         * ravenscar-thread.c (base_ptid): Remove.
14000         (struct ravenscar_thread_target) <close>: New method.
14001         <m_base_ptid>: New member.
14002         <update_inferior_ptid, active_task, task_is_currently_active,
14003         runtime_initialized>: Declare methods.
14004         <ravenscar_thread_target>: Add constructor.
14005         (ravenscar_thread_target::task_is_currently_active)
14006         (ravenscar_thread_target::update_inferior_ptid)
14007         (ravenscar_runtime_initialized): Rename.  Now methods.
14008         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14009         (ravenscar_thread_target::update_thread_list): Update.
14010         (ravenscar_thread_target::active_task): Now method.
14011         (ravenscar_thread_target::store_registers)
14012         (ravenscar_thread_target::prepare_to_store)
14013         (ravenscar_thread_target::prepare_to_store)
14014         (ravenscar_thread_target::mourn_inferior): Update.
14015         (ravenscar_inferior_created): Use "new" to create target.
14016         (ravenscar_thread_target::get_ada_task_ptid): Update.
14017         (_initialize_ravenscar): Don't initialize base_ptid.
14018         (ravenscar_ops): Remove global.
14019
14020 2019-02-15  Tom Tromey  <tromey@adacore.com>
14021
14022         * target.h (push_target): Declare new overload.
14023         * target.c (push_target): New overload, taking an rvalue reference.
14024         * remote.c (remote_target::open_1): Use push_target overload.
14025         * corelow.c (core_target_open): Use push_target overload.
14026
14027 2019-02-15  Tom Tromey  <tromey@adacore.com>
14028
14029         * ravenscar-thread.c (is_ravenscar_task)
14030         (ravenscar_task_is_currently_active): Return bool.
14031         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14032         (_initialize_ravenscar): Remove "(void)".
14033         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14034         Return bool.
14035
14036 2019-02-15  Tom Tromey  <tromey@adacore.com>
14037
14038         * ravenscar-thread.c (ravenscar_runtime_initializer)
14039         (has_ravenscar_runtime, get_running_thread_id)
14040         (ravenscar_thread_target::resume): Fix indentation.
14041
14042 2019-02-15  Tom Tromey  <tromey@adacore.com>
14043
14044         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14045         from ravenscar_arch_ops.
14046         (sparc_ravenscar_ops::fetch_registers)
14047         (sparc_ravenscar_ops::store_registers): Now methods.
14048         (sparc_ravenscar_prepare_to_store): Remove.
14049         (sparc_ravenscar_ops): Redefine.
14050         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14051         methods and destructor.  Remove members.
14052         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14053         (ravenscar_thread_target::store_registers)
14054         (ravenscar_thread_target::prepare_to_store): Update.
14055         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14056         Remove.
14057         (struct ppc_ravenscar_powerpc_ops): Derive from
14058         ravenscar_arch_ops.
14059         (ppc_ravenscar_powerpc_ops::fetch_registers)
14060         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14061         (ppc_ravenscar_powerpc_ops): Redefine.
14062         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14063         (ppc_ravenscar_e500_ops::fetch_registers)
14064         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14065         (ppc_ravenscar_e500_ops): Redefine.
14066         * aarch64-ravenscar-thread.c
14067         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14068         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14069         (aarch64_ravenscar_fetch_registers)
14070         (aarch64_ravenscar_store_registers): Now methods.
14071         (aarch64_ravenscar_ops): Redefine.
14072
14073 2019-02-15  Tom Tromey  <tromey@adacore.com>
14074
14075         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14076         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14077         (ravenscar_thread_target::stopped_by_watchpoint)
14078         (ravenscar_thread_target::stopped_data_address)
14079         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14080
14081 2019-02-15  Tom Tromey  <tromey@adacore.com>
14082
14083         * ravenscar-thread.c: Fix some typos.
14084
14085 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14086             Tom Tromey  <tromey@adacore.com>
14087
14088         * ada-lang.c (ada_exception_sal): Change addr_string to a
14089         std::string.
14090         (create_ada_exception_catchpoint): Update.
14091
14092 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14093             Tom Tromey  <tromey@adacore.com>
14094
14095         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14096         (bp_location_ops): Remove.
14097         (base_breakpoint_allocate_location): Update.
14098         (free_bp_location): Update.
14099         * ada-lang.c (class ada_catchpoint_location)
14100         <ada_catchpoint_location>: Remove ops parameter.
14101         (ada_catchpoint_location_dtor): Remove.
14102         (ada_catchpoint_location_ops): Remove.
14103         (allocate_location_exception): Update.
14104         * breakpoint.h (struct bp_location_ops): Remove.
14105         (class bp_location) <bp_location>: Remove bp_location_ops
14106         parameter.
14107         <~bp_location>: Add destructor.
14108         <ops>: Remove.
14109
14110 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14111             Pedro Alves  <palves@redhat.com>
14112
14113         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14114         'PATH_MAX'.
14115
14116 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14117             Samuel Thibault  <samuel.thibault@gnu.org>
14118             Thomas Schwinge  <thomas@codesourcery.com>
14119
14120         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14121         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14122
14123 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14124
14125         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14126         (check_empty): Use "const char *".
14127
14128         * gnu-nat.c (gnu_nat_target::detach): Instead of
14129         'detach_inferior (pid)' call
14130         'detach_inferior (find_inferior_pid (pid))'.
14131
14132         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14133         'nat/fork-inferior.o'.
14134         * gnu-nat.c: #include "nat/fork-inferior.h".
14135
14136         * gnu-nat.c (gnu_nat_target::detach): Instead of
14137         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14138         * gnu-nat.h: #include "inf-child.h".
14139         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14140         'i386_gnu_nat_target::fetch_registers'.
14141         (gnu_store_registers): Rename/move to
14142         'i386_gnu_nat_target::store_registers'.
14143
14144         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14145         * gnu-nat.h (mach_thread_info): New function.
14146         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14147
14148         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14149
14150 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14151
14152         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14153
14154 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14155
14156         * windows-nat.c (windows_add_thread): Add new parameter
14157         "main_thread_p" with default value set to false.  Update
14158         function documentation as well as all callers.
14159         (windows_delete_thread): Likewise.
14160         (fake_create_process): Update call to windows_add_thread.
14161         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14162         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14163         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14164         call to windows_delete_thread.
14165
14166 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14167
14168         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14169
14170 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14171
14172         * symfile.c (find_separate_debug_file): Use canonical path of
14173         sysroot with child_path instead of gdb_sysroot if it is valid.
14174
14175 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14176
14177         * symfile.c (find_separate_debug_file): Use child_path to
14178         determine if an object file is under a sysroot.
14179
14180 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14181
14182         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14183         unittests/child-path-selftests.c.
14184         * common/pathstuff.c (child_path): New function.
14185         * common/pathstuff.h (child_path): New prototype.
14186         * unittests/child-path-selftests.c: New file.
14187
14188 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14189
14190         * symfile.c (find_separate_debug_file): Look for separate debug
14191         files in debug directories under the sysroot.
14192
14193 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14194
14195         * symtab.h (struct minimal_symbol data_p): New const method.
14196         (struct minimal_symbol text_p): Likewise.
14197         * symtab.c (output_source_filename): Use file name style
14198         to print file name.
14199         (print_symbol_info): Likewise.
14200         (print_msymbol_info): Use address style to print addresses.
14201         Use function name style to print executable text symbols.
14202         (expand_symtab_containing_pc): Use data_p.
14203         (find_pc_sect_compunit_symtab): Likewise.
14204
14205 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14206
14207         * breakpoint.c (describe_other_breakpoints): Use address style
14208         to print addresses.
14209         (say_where): Likewise.
14210
14211 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14212
14213         * ada-typeprint.c (print_func_type): Print function name
14214         style to print function name.
14215         * c-typeprint.c (c_print_type_1): Likewise.
14216
14217 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14218
14219         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14220         for execve.
14221
14222 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14223
14224         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14225         type_stack.
14226
14227 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14228
14229         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14230         TYPE_CODE_REF types.
14231
14232 2019-02-08  Jim Wilson  <jimw@sifive.com>
14233
14234         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14235         (riscv_linux_fregset): New.
14236         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14237
14238 2019-02-07  Tom Tromey  <tom@tromey.com>
14239
14240         * thread.c (thread_cancel_execution_command): Update.
14241         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14242         methods.
14243         (struct thread_fsm_ops): Remove.
14244         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14245         (thread_fsm_should_stop, thread_fsm_return_value)
14246         (thread_fsm_set_finished, thread_fsm_finished_p)
14247         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14248         Don't declare.
14249         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14250         * infrun.c (clear_proceed_status_thread)
14251         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14252         (print_stop_event): Update.
14253         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14254         Add constructor.
14255         (step_command_fsm_ops): Remove.
14256         (new_step_command_fsm): Remove.
14257         (step_1): Update.
14258         (step_command_fsm::should_stop): Rename from
14259         step_command_fsm_should_stop.
14260         (step_command_fsm::clean_up): Rename from
14261         step_command_fsm_clean_up.
14262         (step_command_fsm::do_async_reply_reason): Rename from
14263         step_command_fsm_async_reply_reason.
14264         (struct until_next_fsm): Inherit from thread_fsm.  Add
14265         constructor.
14266         (until_next_fsm_ops): Remove.
14267         (new_until_next_fsm): Remove.
14268         (until_next_fsm::should_stop): Rename from
14269         until_next_fsm_should_stop.
14270         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14271         (until_next_fsm::do_async_reply_reason): Rename from
14272         until_next_fsm_async_reply_reason.
14273         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14274         constructor.  Change type of breakpoint.
14275         (finish_command_fsm_ops): Remove.
14276         (new_finish_command_fsm): Remove.
14277         (finish_command_fsm::should_stop): Rename from
14278         finish_command_fsm_should_stop.
14279         (finish_command_fsm::clean_up): Rename from
14280         finish_command_fsm_clean_up.
14281         (finish_command_fsm::return_value): Rename from
14282         finish_command_fsm_return_value.
14283         (finish_command_fsm::do_async_reply_reason): Rename from
14284         finish_command_fsm_async_reply_reason.
14285         (finish_command): Update.
14286         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14287         Add constructor.
14288         (call_thread_fsm_ops): Remove.
14289         (call_thread_fsm::call_thread_fsm): Rename from
14290         new_call_thread_fsm.
14291         (call_thread_fsm::should_stop): Rename from
14292         call_thread_fsm_should_stop.
14293         (call_thread_fsm::should_notify_stop): Rename from
14294         call_thread_fsm_should_notify_stop.
14295         (run_inferior_call, call_function_by_hand_dummy): Update.
14296         * cli/cli-interp.c (should_print_stop_to_console): Update.
14297         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14298         Add constructor.  Change type of location_breakpoint,
14299         caller_breakpoint.
14300         (until_break_fsm_ops): Remove.
14301         (new_until_break_fsm): Remove.
14302         (until_break_fsm::should_stop): Rename from
14303         until_break_fsm_should_stop.
14304         (until_break_fsm::clean_up): Rename from
14305         until_break_fsm_clean_up.
14306         (until_break_fsm::do_async_reply_reason): Rename from
14307         until_break_fsm_async_reply_reason.
14308         (until_break_command): Update.
14309         * thread-fsm.c: Remove.
14310         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14311
14312 2019-02-07  Tom Tromey  <tom@tromey.com>
14313
14314         * yy-remap.h: Add include guard.
14315         * xtensa-tdep.h: Add include guard.
14316         * xcoffread.h: Rename include guard.
14317         * varobj-iter.h: Add include guard.
14318         * tui/tui.h: Rename include guard.
14319         * tui/tui-winsource.h: Rename include guard.
14320         * tui/tui-wingeneral.h: Rename include guard.
14321         * tui/tui-windata.h: Rename include guard.
14322         * tui/tui-win.h: Rename include guard.
14323         * tui/tui-stack.h: Rename include guard.
14324         * tui/tui-source.h: Rename include guard.
14325         * tui/tui-regs.h: Rename include guard.
14326         * tui/tui-out.h: Rename include guard.
14327         * tui/tui-layout.h: Rename include guard.
14328         * tui/tui-io.h: Rename include guard.
14329         * tui/tui-hooks.h: Rename include guard.
14330         * tui/tui-file.h: Rename include guard.
14331         * tui/tui-disasm.h: Rename include guard.
14332         * tui/tui-data.h: Rename include guard.
14333         * tui/tui-command.h: Rename include guard.
14334         * tic6x-tdep.h: Add include guard.
14335         * target/waitstatus.h: Rename include guard.
14336         * target/wait.h: Rename include guard.
14337         * target/target.h: Rename include guard.
14338         * target/resume.h: Rename include guard.
14339         * target-float.h: Rename include guard.
14340         * stabsread.h: Add include guard.
14341         * rs6000-tdep.h: Add include guard.
14342         * riscv-fbsd-tdep.h: Add include guard.
14343         * regformats/regdef.h: Rename include guard.
14344         * record.h: Rename include guard.
14345         * python/python.h: Rename include guard.
14346         * python/python-internal.h: Rename include guard.
14347         * python/py-stopevent.h: Rename include guard.
14348         * python/py-ref.h: Rename include guard.
14349         * python/py-record.h: Rename include guard.
14350         * python/py-record-full.h: Rename include guard.
14351         * python/py-record-btrace.h: Rename include guard.
14352         * python/py-instruction.h: Rename include guard.
14353         * python/py-events.h: Rename include guard.
14354         * python/py-event.h: Rename include guard.
14355         * procfs.h: Add include guard.
14356         * proc-utils.h: Add include guard.
14357         * p-lang.h: Add include guard.
14358         * or1k-tdep.h: Rename include guard.
14359         * observable.h: Rename include guard.
14360         * nto-tdep.h: Rename include guard.
14361         * nat/x86-linux.h: Rename include guard.
14362         * nat/x86-linux-dregs.h: Rename include guard.
14363         * nat/x86-gcc-cpuid.h: Add include guard.
14364         * nat/x86-dregs.h: Rename include guard.
14365         * nat/x86-cpuid.h: Rename include guard.
14366         * nat/ppc-linux.h: Rename include guard.
14367         * nat/mips-linux-watch.h: Rename include guard.
14368         * nat/linux-waitpid.h: Rename include guard.
14369         * nat/linux-ptrace.h: Rename include guard.
14370         * nat/linux-procfs.h: Rename include guard.
14371         * nat/linux-osdata.h: Rename include guard.
14372         * nat/linux-nat.h: Rename include guard.
14373         * nat/linux-namespaces.h: Rename include guard.
14374         * nat/linux-btrace.h: Rename include guard.
14375         * nat/glibc_thread_db.h: Rename include guard.
14376         * nat/gdb_thread_db.h: Rename include guard.
14377         * nat/gdb_ptrace.h: Rename include guard.
14378         * nat/fork-inferior.h: Rename include guard.
14379         * nat/amd64-linux-siginfo.h: Rename include guard.
14380         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14381         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14382         * nat/aarch64-linux.h: Rename include guard.
14383         * nat/aarch64-linux-hw-point.h: Rename include guard.
14384         * mn10300-tdep.h: Add include guard.
14385         * mips-linux-tdep.h: Add include guard.
14386         * mi/mi-parse.h: Rename include guard.
14387         * mi/mi-out.h: Rename include guard.
14388         * mi/mi-main.h: Rename include guard.
14389         * mi/mi-interp.h: Rename include guard.
14390         * mi/mi-getopt.h: Rename include guard.
14391         * mi/mi-console.h: Rename include guard.
14392         * mi/mi-common.h: Rename include guard.
14393         * mi/mi-cmds.h: Rename include guard.
14394         * mi/mi-cmd-break.h: Rename include guard.
14395         * m2-lang.h: Add include guard.
14396         * location.h: Rename include guard.
14397         * linux-record.h: Rename include guard.
14398         * linux-nat.h: Add include guard.
14399         * linux-fork.h: Add include guard.
14400         * i386-darwin-tdep.h: Rename include guard.
14401         * hppa-linux-offsets.h: Add include guard.
14402         * guile/guile.h: Rename include guard.
14403         * guile/guile-internal.h: Rename include guard.
14404         * gnu-nat.h: Rename include guard.
14405         * gdb-stabs.h: Rename include guard.
14406         * frv-tdep.h: Add include guard.
14407         * f-lang.h: Add include guard.
14408         * event-loop.h: Add include guard.
14409         * darwin-nat.h: Rename include guard.
14410         * cp-abi.h: Rename include guard.
14411         * config/sparc/nm-sol2.h: Rename include guard.
14412         * config/nm-nto.h: Rename include guard.
14413         * config/nm-linux.h: Add include guard.
14414         * config/i386/nm-i386gnu.h: Rename include guard.
14415         * config/djgpp/nl_types.h: Rename include guard.
14416         * config/djgpp/langinfo.h: Rename include guard.
14417         * compile/gcc-cp-plugin.h: Add include guard.
14418         * compile/gcc-c-plugin.h: Add include guard.
14419         * compile/compile.h: Rename include guard.
14420         * compile/compile-object-run.h: Rename include guard.
14421         * compile/compile-object-load.h: Rename include guard.
14422         * compile/compile-internal.h: Rename include guard.
14423         * compile/compile-cplus.h: Rename include guard.
14424         * compile/compile-c.h: Rename include guard.
14425         * common/xml-utils.h: Rename include guard.
14426         * common/x86-xstate.h: Rename include guard.
14427         * common/version.h: Rename include guard.
14428         * common/vec.h: Rename include guard.
14429         * common/tdesc.h: Rename include guard.
14430         * common/selftest.h: Rename include guard.
14431         * common/scoped_restore.h: Rename include guard.
14432         * common/scoped_mmap.h: Rename include guard.
14433         * common/scoped_fd.h: Rename include guard.
14434         * common/safe-iterator.h: Rename include guard.
14435         * common/run-time-clock.h: Rename include guard.
14436         * common/refcounted-object.h: Rename include guard.
14437         * common/queue.h: Rename include guard.
14438         * common/ptid.h: Rename include guard.
14439         * common/print-utils.h: Rename include guard.
14440         * common/preprocessor.h: Rename include guard.
14441         * common/pathstuff.h: Rename include guard.
14442         * common/observable.h: Rename include guard.
14443         * common/netstuff.h: Rename include guard.
14444         * common/job-control.h: Rename include guard.
14445         * common/host-defs.h: Rename include guard.
14446         * common/gdb_wait.h: Rename include guard.
14447         * common/gdb_vecs.h: Rename include guard.
14448         * common/gdb_unlinker.h: Rename include guard.
14449         * common/gdb_unique_ptr.h: Rename include guard.
14450         * common/gdb_tilde_expand.h: Rename include guard.
14451         * common/gdb_sys_time.h: Rename include guard.
14452         * common/gdb_string_view.h: Rename include guard.
14453         * common/gdb_splay_tree.h: Rename include guard.
14454         * common/gdb_setjmp.h: Rename include guard.
14455         * common/gdb_ref_ptr.h: Rename include guard.
14456         * common/gdb_optional.h: Rename include guard.
14457         * common/gdb_locale.h: Rename include guard.
14458         * common/gdb_assert.h: Rename include guard.
14459         * common/filtered-iterator.h: Rename include guard.
14460         * common/filestuff.h: Rename include guard.
14461         * common/fileio.h: Rename include guard.
14462         * common/environ.h: Rename include guard.
14463         * common/common-utils.h: Rename include guard.
14464         * common/common-types.h: Rename include guard.
14465         * common/common-regcache.h: Rename include guard.
14466         * common/common-inferior.h: Rename include guard.
14467         * common/common-gdbthread.h: Rename include guard.
14468         * common/common-exceptions.h: Rename include guard.
14469         * common/common-defs.h: Rename include guard.
14470         * common/common-debug.h: Rename include guard.
14471         * common/cleanups.h: Rename include guard.
14472         * common/buffer.h: Rename include guard.
14473         * common/btrace-common.h: Rename include guard.
14474         * common/break-common.h: Rename include guard.
14475         * cli/cli-utils.h: Rename include guard.
14476         * cli/cli-style.h: Rename include guard.
14477         * cli/cli-setshow.h: Rename include guard.
14478         * cli/cli-script.h: Rename include guard.
14479         * cli/cli-interp.h: Rename include guard.
14480         * cli/cli-decode.h: Rename include guard.
14481         * cli/cli-cmds.h: Rename include guard.
14482         * charset-list.h: Add include guard.
14483         * buildsym-legacy.h: Rename include guard.
14484         * bfin-tdep.h: Add include guard.
14485         * ax.h: Rename include guard.
14486         * arm-linux-tdep.h: Add include guard.
14487         * arm-fbsd-tdep.h: Add include guard.
14488         * arch/xtensa.h: Rename include guard.
14489         * arch/tic6x.h: Add include guard.
14490         * arch/i386.h: Add include guard.
14491         * arch/arm.h: Rename include guard.
14492         * arch/arm-linux.h: Rename include guard.
14493         * arch/arm-get-next-pcs.h: Rename include guard.
14494         * arch/amd64.h: Add include guard.
14495         * arch/aarch64-insn.h: Rename include guard.
14496         * arch-utils.h: Rename include guard.
14497         * annotate.h: Add include guard.
14498         * amd64-darwin-tdep.h: Rename include guard.
14499         * aarch64-linux-tdep.h: Add include guard.
14500         * aarch64-fbsd-tdep.h: Add include guard.
14501         * aarch32-linux-nat.h: Add include guard.
14502
14503 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14504
14505         * macrotab.c (macro_define_internal): New function that
14506         factorizes macro_define_object_internal and macro_define_function
14507         code.
14508         (macro_define_object_internal): Use macro_define_internal.
14509         (macro_define_function): Likewise.
14510
14511 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14512
14513         * macrocmd.c (extract_identifier): Return
14514         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14515         callers.
14516
14517 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14518
14519         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14520
14521 2019-02-05  Tom Tromey  <tom@tromey.com>
14522
14523         * target.c (target_stack::unpush): Move assertion earlier.
14524
14525 2019-01-30  Tom Tromey  <tom@tromey.com>
14526
14527         PR python/23615:
14528         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14529         (gdbpy_parse_and_eval): Likewise.
14530         * python/python-internal.h (gdbpy_allow_threads): New class.
14531
14532 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14533
14534         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14535         (aarch64_fbsd_fpregmap): Move earlier.
14536         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14537         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14538         instead of individual calls to trad_frame_set_reg_addr.
14539         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14540         earlier.
14541         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14542         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14543         instead of individual calls to trad_frame_set_reg_addr.
14544
14545 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14546
14547         * CONTRIBUTE: Replace contribution list with wiki link.
14548
14549 2019-01-25  Tom Tromey  <tom@tromey.com>
14550
14551         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14552
14553 2019-01-25  Tom Tromey  <tom@tromey.com>
14554
14555         * xtensa-linux-nat.c: Fix common/ includes.
14556         * xml-support.h: Fix common/ includes.
14557         * xml-support.c: Fix common/ includes.
14558         * x86-linux-nat.c: Fix common/ includes.
14559         * windows-nat.c: Fix common/ includes.
14560         * varobj.h: Fix common/ includes.
14561         * varobj.c: Fix common/ includes.
14562         * value.c: Fix common/ includes.
14563         * valops.c: Fix common/ includes.
14564         * utils.c: Fix common/ includes.
14565         * unittests/xml-utils-selftests.c: Fix common/ includes.
14566         * unittests/utils-selftests.c: Fix common/ includes.
14567         * unittests/unpack-selftests.c: Fix common/ includes.
14568         * unittests/tracepoint-selftests.c: Fix common/ includes.
14569         * unittests/style-selftests.c: Fix common/ includes.
14570         * unittests/string_view-selftests.c: Fix common/ includes.
14571         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14572         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14573         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14574         * unittests/rsp-low-selftests.c: Fix common/ includes.
14575         * unittests/parse-connection-spec-selftests.c: Fix common/
14576         includes.
14577         * unittests/optional-selftests.c: Fix common/ includes.
14578         * unittests/offset-type-selftests.c: Fix common/ includes.
14579         * unittests/observable-selftests.c: Fix common/ includes.
14580         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14581         * unittests/memrange-selftests.c: Fix common/ includes.
14582         * unittests/memory-map-selftests.c: Fix common/ includes.
14583         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14584         * unittests/function-view-selftests.c: Fix common/ includes.
14585         * unittests/environ-selftests.c: Fix common/ includes.
14586         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14587         * unittests/common-utils-selftests.c: Fix common/ includes.
14588         * unittests/cli-utils-selftests.c: Fix common/ includes.
14589         * unittests/array-view-selftests.c: Fix common/ includes.
14590         * ui-file.c: Fix common/ includes.
14591         * tui/tui-io.c: Fix common/ includes.
14592         * tracepoint.h: Fix common/ includes.
14593         * tracepoint.c: Fix common/ includes.
14594         * tracefile-tfile.c: Fix common/ includes.
14595         * top.h: Fix common/ includes.
14596         * top.c: Fix common/ includes.
14597         * thread.c: Fix common/ includes.
14598         * target/waitstatus.h: Fix common/ includes.
14599         * target/waitstatus.c: Fix common/ includes.
14600         * target.h: Fix common/ includes.
14601         * target.c: Fix common/ includes.
14602         * target-memory.c: Fix common/ includes.
14603         * target-descriptions.c: Fix common/ includes.
14604         * symtab.h: Fix common/ includes.
14605         * symfile.c: Fix common/ includes.
14606         * stap-probe.c: Fix common/ includes.
14607         * spu-linux-nat.c: Fix common/ includes.
14608         * sparc-nat.c: Fix common/ includes.
14609         * source.c: Fix common/ includes.
14610         * solib.c: Fix common/ includes.
14611         * solib-target.c: Fix common/ includes.
14612         * ser-unix.c: Fix common/ includes.
14613         * ser-tcp.c: Fix common/ includes.
14614         * ser-pipe.c: Fix common/ includes.
14615         * ser-base.c: Fix common/ includes.
14616         * selftest-arch.c: Fix common/ includes.
14617         * s12z-tdep.c: Fix common/ includes.
14618         * rust-exp.y: Fix common/ includes.
14619         * rs6000-aix-tdep.c: Fix common/ includes.
14620         * riscv-tdep.c: Fix common/ includes.
14621         * remote.c: Fix common/ includes.
14622         * remote-notif.h: Fix common/ includes.
14623         * remote-fileio.h: Fix common/ includes.
14624         * remote-fileio.c: Fix common/ includes.
14625         * regcache.h: Fix common/ includes.
14626         * regcache.c: Fix common/ includes.
14627         * record-btrace.c: Fix common/ includes.
14628         * python/python.c: Fix common/ includes.
14629         * python/py-type.c: Fix common/ includes.
14630         * python/py-inferior.c: Fix common/ includes.
14631         * progspace.h: Fix common/ includes.
14632         * producer.c: Fix common/ includes.
14633         * procfs.c: Fix common/ includes.
14634         * proc-api.c: Fix common/ includes.
14635         * printcmd.c: Fix common/ includes.
14636         * ppc-linux-nat.c: Fix common/ includes.
14637         * parser-defs.h: Fix common/ includes.
14638         * osdata.c: Fix common/ includes.
14639         * obsd-nat.c: Fix common/ includes.
14640         * nat/x86-linux.c: Fix common/ includes.
14641         * nat/x86-linux-dregs.c: Fix common/ includes.
14642         * nat/x86-dregs.h: Fix common/ includes.
14643         * nat/x86-dregs.c: Fix common/ includes.
14644         * nat/ppc-linux.c: Fix common/ includes.
14645         * nat/mips-linux-watch.h: Fix common/ includes.
14646         * nat/mips-linux-watch.c: Fix common/ includes.
14647         * nat/linux-waitpid.c: Fix common/ includes.
14648         * nat/linux-ptrace.h: Fix common/ includes.
14649         * nat/linux-ptrace.c: Fix common/ includes.
14650         * nat/linux-procfs.c: Fix common/ includes.
14651         * nat/linux-personality.c: Fix common/ includes.
14652         * nat/linux-osdata.c: Fix common/ includes.
14653         * nat/linux-namespaces.c: Fix common/ includes.
14654         * nat/linux-btrace.h: Fix common/ includes.
14655         * nat/linux-btrace.c: Fix common/ includes.
14656         * nat/fork-inferior.c: Fix common/ includes.
14657         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14658         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14659         * nat/aarch64-linux.c: Fix common/ includes.
14660         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14661         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14662         * namespace.h: Fix common/ includes.
14663         * mips-linux-tdep.c: Fix common/ includes.
14664         * minsyms.c: Fix common/ includes.
14665         * mi/mi-parse.h: Fix common/ includes.
14666         * mi/mi-main.c: Fix common/ includes.
14667         * mi/mi-cmd-env.c: Fix common/ includes.
14668         * memrange.h: Fix common/ includes.
14669         * memattr.c: Fix common/ includes.
14670         * maint.h: Fix common/ includes.
14671         * maint.c: Fix common/ includes.
14672         * main.c: Fix common/ includes.
14673         * machoread.c: Fix common/ includes.
14674         * location.c: Fix common/ includes.
14675         * linux-thread-db.c: Fix common/ includes.
14676         * linux-nat.c: Fix common/ includes.
14677         * linux-fork.c: Fix common/ includes.
14678         * inline-frame.c: Fix common/ includes.
14679         * infrun.c: Fix common/ includes.
14680         * inflow.c: Fix common/ includes.
14681         * inferior.h: Fix common/ includes.
14682         * inferior.c: Fix common/ includes.
14683         * infcmd.c: Fix common/ includes.
14684         * inf-ptrace.c: Fix common/ includes.
14685         * inf-child.c: Fix common/ includes.
14686         * ia64-linux-nat.c: Fix common/ includes.
14687         * i387-tdep.c: Fix common/ includes.
14688         * i386-tdep.c: Fix common/ includes.
14689         * i386-linux-tdep.c: Fix common/ includes.
14690         * i386-linux-nat.c: Fix common/ includes.
14691         * i386-go32-tdep.c: Fix common/ includes.
14692         * i386-fbsd-tdep.c: Fix common/ includes.
14693         * i386-fbsd-nat.c: Fix common/ includes.
14694         * guile/scm-type.c: Fix common/ includes.
14695         * guile/guile.c: Fix common/ includes.
14696         * go32-nat.c: Fix common/ includes.
14697         * gnu-nat.c: Fix common/ includes.
14698         * gdbthread.h: Fix common/ includes.
14699         * gdbarch-selftests.c: Fix common/ includes.
14700         * gdb_usleep.c: Fix common/ includes.
14701         * gdb_select.h: Fix common/ includes.
14702         * gdb_bfd.c: Fix common/ includes.
14703         * gcore.c: Fix common/ includes.
14704         * fork-child.c: Fix common/ includes.
14705         * findvar.c: Fix common/ includes.
14706         * fbsd-nat.c: Fix common/ includes.
14707         * event-top.c: Fix common/ includes.
14708         * event-loop.c: Fix common/ includes.
14709         * dwarf2read.c: Fix common/ includes.
14710         * dwarf2loc.c: Fix common/ includes.
14711         * dwarf2-frame.c: Fix common/ includes.
14712         * dwarf-index-cache.c: Fix common/ includes.
14713         * dtrace-probe.c: Fix common/ includes.
14714         * disasm-selftests.c: Fix common/ includes.
14715         * defs.h: Fix common/ includes.
14716         * csky-tdep.c: Fix common/ includes.
14717         * cp-valprint.c: Fix common/ includes.
14718         * cp-support.h: Fix common/ includes.
14719         * cp-support.c: Fix common/ includes.
14720         * corelow.c: Fix common/ includes.
14721         * completer.h: Fix common/ includes.
14722         * completer.c: Fix common/ includes.
14723         * compile/compile.c: Fix common/ includes.
14724         * compile/compile-loc2c.c: Fix common/ includes.
14725         * compile/compile-cplus-types.c: Fix common/ includes.
14726         * compile/compile-cplus-symbols.c: Fix common/ includes.
14727         * command.h: Fix common/ includes.
14728         * cli/cli-dump.c: Fix common/ includes.
14729         * cli/cli-cmds.c: Fix common/ includes.
14730         * charset.c: Fix common/ includes.
14731         * build-id.c: Fix common/ includes.
14732         * btrace.h: Fix common/ includes.
14733         * btrace.c: Fix common/ includes.
14734         * breakpoint.h: Fix common/ includes.
14735         * breakpoint.c: Fix common/ includes.
14736         * ax.h:
14737         (enum agent_op): Fix common/ includes.
14738         * ax-general.c (struct aop_map): Fix common/ includes.
14739         * ax-gdb.c: Fix common/ includes.
14740         * auxv.c: Fix common/ includes.
14741         * auto-load.c: Fix common/ includes.
14742         * arm-tdep.c: Fix common/ includes.
14743         * arch/riscv.c: Fix common/ includes.
14744         * arch/ppc-linux-common.c: Fix common/ includes.
14745         * arch/i386.c: Fix common/ includes.
14746         * arch/arm.c: Fix common/ includes.
14747         * arch/arm-linux.c: Fix common/ includes.
14748         * arch/arm-get-next-pcs.c: Fix common/ includes.
14749         * arch/amd64.c: Fix common/ includes.
14750         * arch/aarch64.c: Fix common/ includes.
14751         * arch/aarch64-insn.c: Fix common/ includes.
14752         * arch-utils.c: Fix common/ includes.
14753         * amd64-windows-tdep.c: Fix common/ includes.
14754         * amd64-tdep.c: Fix common/ includes.
14755         * amd64-sol2-tdep.c: Fix common/ includes.
14756         * amd64-obsd-tdep.c: Fix common/ includes.
14757         * amd64-nbsd-tdep.c: Fix common/ includes.
14758         * amd64-linux-tdep.c: Fix common/ includes.
14759         * amd64-linux-nat.c: Fix common/ includes.
14760         * amd64-fbsd-tdep.c: Fix common/ includes.
14761         * amd64-fbsd-nat.c: Fix common/ includes.
14762         * amd64-dicos-tdep.c: Fix common/ includes.
14763         * amd64-darwin-tdep.c: Fix common/ includes.
14764         * agent.c: Fix common/ includes.
14765         * ada-lang.h: Fix common/ includes.
14766         * ada-lang.c: Fix common/ includes.
14767         * aarch64-tdep.c: Fix common/ includes.
14768
14769 2019-01-25  Tom Tromey  <tom@tromey.com>
14770
14771         * common/create-version.sh: Use common/version.h.
14772
14773 2019-01-24  Pedro Alves  <palves@redhat.com>
14774
14775         * infrun.c (signal_stop, signal_print, signal_program)
14776         (signal_catch, signal_pass): Now arrays instead of pointers.
14777         (update_signals_program_target, do_target_resume)
14778         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14779         * linux-nat.c (linux_nat_target::pass_signals)
14780         (linux_nat_target::create_inferior, linux_nat_target::attach):
14781         Adjust.
14782         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14783         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14784         * procfs.c (procfs_target::pass_signals): Adjust.
14785         * record-full.c (record_full_target::resume): Adjust.
14786         * remote.c (remote_target::pass_signals)
14787         (remote_target::program_signals): Adjust.
14788         * target-debug.h (target_debug_print_signals): Now takes a
14789         gdb::array_view as parameter.  Adjust.
14790         * target.h (target_ops) <pass_signals, program_signals>: Replace
14791         pointer and length parameters with gdb::array_view.
14792         (target_pass_signals, target_program_signals): Likewise.
14793         * target-delegates.c: Regenerate.
14794
14795 2019-01-24  Pedro Alves  <palves@redhat.com>
14796
14797         * common/forward-scope-exit.h
14798         (forward_scope_exit::forward_scope_exit): Pass arguments to
14799         m_bind_function directly, instead of creating a std::bind and
14800         copying that.
14801
14802 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14803
14804         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14805         for static members.
14806         (pass_in_v_vfp_candidate): Likewise.
14807
14808 2019-01-23  Tom Tromey  <tom@tromey.com>
14809             Pedro Alves  <palves@redhat.com>
14810
14811         * regcache.c (class regcache_invalidator): Remove.
14812         (regcache::raw_write): Use make_scope_exit.
14813
14814 2019-01-23  Tom Tromey  <tom@tromey.com>
14815
14816         * ui-out.h (class ui_out_emit_type): Update comment.
14817
14818 2019-01-23  Tom Tromey  <tom@tromey.com>
14819
14820         * infrun.c (fetch_inferior_event): Update comment.
14821
14822 2019-01-23  Tom Tromey  <tom@tromey.com>
14823             Pedro Alves  <palves@redhat.com>
14824
14825         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14826         parameter.
14827         (fetch_inferior_event): Use SCOPE_EXIT.
14828
14829
14830 2019-01-23  Tom Tromey  <tom@tromey.com>
14831             Pedro Alves  <palves@redhat.com>
14832
14833         * infrun.c (disable_thread_events): Delete.
14834         (stop_all_threads): Use SCOPE_EXIT.
14835
14836 2019-01-23  Tom Tromey  <tom@tromey.com>
14837             Pedro Alves  <palves@redhat.com>
14838
14839         * symfile.c: Include forward-scope-exit.h.
14840         (clear_symtab_users_cleanup): Replace forward declaration with
14841         a FORWARD_SCOPE_EXIT.
14842         (syms_from_objfile_1): Use the forward_scope_exit and
14843         gdb::optional instead of cleanup_function.
14844         (reread_symbols): Use the forward_scope_exit instead of
14845         cleanup_function.
14846         (clear_symtab_users_cleanup): Remove function.
14847
14848 2019-01-23  Tom Tromey  <tom@tromey.com>
14849             Pedro Alves  <palves@redhat.com>
14850
14851         * linux-nat.c: Include scope-exit.h.
14852         (cleanup_target_stop): Remove.
14853         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14854         SCOPE_EXIT.
14855
14856 2019-01-23  Tom Tromey  <tom@tromey.com>
14857             Pedro Alves  <palves@redhat.com>
14858
14859         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14860         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14861
14862 2019-01-23  Tom Tromey  <tom@tromey.com>
14863             Andrew Burgess  <andrew.burgess@embecosm.com>
14864             Pedro Alves  <palves@redhat.com>
14865
14866         * infrun.c (fetch_inferior_event): Use scope_exit.
14867         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14868         * top.c (execute_command): Use scope_exit.
14869         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14870         * utils.c (do_bpstat_clear_actions_cleanup)
14871         (make_bpstat_clear_actions_cleanup): Remove.
14872
14873 2019-01-23  Tom Tromey  <tom@tromey.com>
14874             Pedro Alves  <palves@redhat.com>
14875
14876         * infrun.c: Include "common/scope-exit.h"
14877         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14878         (wait_for_inferior): Use SCOPE_EXIT.
14879         (fetch_inferior_event): Use scope_exit.
14880
14881 2019-01-23  Tom Tromey  <tom@tromey.com>
14882             Pedro Alves  <palves@redhat.com>
14883
14884         * breakpoint.c (create_breakpoint): Remove cleanup.
14885
14886 2019-01-23  Tom Tromey  <tom@tromey.com>
14887             Andrew Burgess  <andrew.burgess@embecosm.com>
14888             Pedro Alves  <palves@redhat.com>
14889
14890 2019-01-23  Pedro Alves  <palves@redhat.com>
14891
14892         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14893
14894 2019-01-23  Pedro Alves  <palves@redhat.com>
14895             Andrew Burgess  <andrew.burgess@embecosm.com>
14896
14897         * gdbthread.h: Include "common/forward-scope-exit.h".
14898         (scoped_finish_thread_state): Redefine custom class in terms of
14899         forward_scope_exit.
14900
14901 2019-01-23  Pedro Alves  <palves@redhat.com>
14902             Andrew Burgess  <andrew.burgess@embecosm.com>
14903
14904         * common/forward-scope-exit.h: New file.
14905
14906 2019-01-23  Pedro Alves  <palves@redhat.com>
14907             Andrew Burgess  <andrew.burgess@embecosm.com>
14908             Tom Tromey  <tom@tromey.com>
14909
14910         * common/scope-exit.h: New file.
14911
14912 2019-01-23  Pedro Alves  <palves@redhat.com>
14913
14914         * common/preprocessor.h (ESC): Rename to ...
14915         (ESC_PARENS): ... this.
14916         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14917         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14918
14919 2019-01-23  Tom Tromey  <tom@tromey.com>
14920
14921         * language.h (class scoped_switch_to_sym_language_if_auto):
14922         Initialize m_lang in both cases.
14923
14924 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14925
14926         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14927         with XCNEW.
14928
14929 2019-01-22  Tom Tromey  <tom@tromey.com>
14930
14931         * corelow.c: Do not include sys/file.h.
14932
14933 2019-01-22  Tom Tromey  <tom@tromey.com>
14934
14935         * tui/tui-wingeneral.h: Include gdb_curses.h.
14936
14937 2019-01-22  Tom Tromey  <tom@tromey.com>
14938
14939         * source-cache.h (class source_cache) <get_source_lines,
14940         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14941
14942 2019-01-22  Tom Tromey  <tom@tromey.com>
14943
14944         * remote-fileio.h (struct remote_target): Declare.
14945
14946 2019-01-22  Tom Tromey  <tom@tromey.com>
14947
14948         * python/py-arch.c: Do not include py-ref.h.
14949         * python/py-bpevent.c: Do not include py-ref.h.
14950         * python/py-cmd.c: Do not include py-ref.h.
14951         * python/py-continueevent.c: Do not include py-ref.h.
14952         * python/py-event.h: Do not include py-ref.h.
14953         * python/py-evtregistry.c: Do not include py-ref.h.
14954         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14955         * python/py-frame.c: Do not include py-ref.h.
14956         * python/py-framefilter.c: Do not include py-ref.h.
14957         * python/py-function.c: Do not include py-ref.h.
14958         * python/py-infevents.c: Do not include py-ref.h.
14959         * python/py-linetable.c: Do not include py-ref.h.
14960         * python/py-objfile.c: Do not include py-ref.h.
14961         * python/py-param.c: Do not include py-ref.h.
14962         * python/py-prettyprint.c: Do not include py-ref.h.
14963         * python/py-progspace.c: Do not include py-ref.h.
14964         * python/py-symbol.c: Do not include py-ref.h.
14965         * python/py-symtab.c: Do not include py-ref.h.
14966         * python/py-type.c: Do not include py-ref.h.
14967         * python/py-unwind.c: Do not include py-ref.h.
14968         * python/py-utils.c: Do not include py-ref.h.
14969         * python/py-value.c: Do not include py-ref.h.
14970         * python/py-varobj.c: Do not include py-ref.h.
14971         * python/py-xmethods.c: Do not include py-ref.h.
14972         * python/python.c: Do not include py-ref.h.
14973         * varobj.c: Do not include py-ref.h.
14974
14975 2019-01-22  Tom Tromey  <tom@tromey.com>
14976
14977         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14978         keyword for bcache.
14979
14980 2019-01-22  Tom Tromey  <tom@tromey.com>
14981
14982         * compile/compile-cplus-types.c: Remove a comment by #include.
14983
14984 2019-01-22  Tom Tromey  <tom@tromey.com>
14985
14986         * compile/gcc-c-plugin.h: Include compile-internal.h.
14987
14988 2019-01-22  Tom Tromey  <tom@tromey.com>
14989
14990         * stabsread.c (EXTERN): Do not define.
14991         (symnum, next_symbol_text_func, processing_gcc_compilation)
14992         (within_function, global_sym_chain, global_stabs)
14993         (previous_stab_code, this_object_header_files)
14994         (n_this_object_header_files)
14995         (n_allocated_this_object_header_files): Define.
14996         * stabsread.h (EXTERN): Never define.  Use "extern".
14997
14998 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14999
15000         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15001         history_value.
15002
15003 2019-01-21  Tom Tromey  <tom@tromey.com>
15004
15005         * ui-out.c: Fix includes.
15006         * tui/tui-source.c: Fix includes.
15007         * target.c: Fix includes.
15008         * remote.c: Fix includes.
15009         * regcache.c: Fix includes.
15010         * python/py-block.c: Fix includes.
15011         * printcmd.c: Fix includes.
15012         * or1k-tdep.c: Fix includes.
15013         * mi/mi-main.c: Fix includes.
15014         * m32r-tdep.c: Fix includes.
15015         * csky-tdep.c: Fix includes.
15016         * compile/compile-cplus-types.c: Fix includes.
15017         * cli/cli-interp.c: Fix includes.
15018
15019 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15020
15021         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15022         for padding.
15023
15024 2019-01-16  Tom Tromey  <tom@tromey.com>
15025
15026         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15027         earlier.
15028         (struct objfile) <msymbols_range>: Move from top level.
15029         <msymbols>: New method.
15030         (class objfile_msymbols): Remove.
15031         * symtab.c (default_collect_symbol_completion_matches_break_on):
15032         Update.
15033         * symmisc.c (dump_msymbols): Update.
15034         * stabsread.c (scan_file_globals): Update.
15035         * objc-lang.c (info_selectors_command, info_classes_command)
15036         (find_methods): Update.
15037         * minsyms.c (find_solib_trampoline_target): Update.
15038         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15039         * coffread.c (coff_symfile_read): Update.
15040         * ada-lang.c (ada_lookup_simple_minsym)
15041         (ada_collect_symbol_completion_matches): Update.
15042
15043 2019-01-16  Tom Tromey  <tom@tromey.com>
15044
15045         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15046         type.  Remove no-argument constructor.
15047         <iterator::operator++>: Simplify.
15048         <begin>: Update.
15049         <end>: Use minimal_symbol_count.
15050
15051 2019-01-16  Tom Tromey  <tom@tromey.com>
15052
15053         * objfiles.h (struct objfile) <psymtabs>: New method.
15054         (class objfile_psymtabs): Remove.
15055         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15056         typedef.
15057         <range>: New method.
15058         (require_partial_symbols): Change return type.
15059         * psymtab.c (require_partial_symbols)
15060         (psym_expand_symtabs_matching): Update.
15061         * mdebugread.c (parse_partial_symbols): Update.
15062         * dbxread.c (dbx_end_psymtab): Update.
15063
15064 2019-01-15  Tom Tromey  <tom@tromey.com>
15065
15066         * symtab.c (lookup_objfile_from_block)
15067         (lookup_symbol_in_objfile_symtabs)
15068         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15069         (find_line_symtab, info_sources_command)
15070         (default_collect_symbol_completion_matches_break_on)
15071         (make_source_files_completion_list): Update.
15072         * symmisc.c (print_objfile_statistics, dump_objfile)
15073         (maintenance_print_symbols, maintenance_info_symtabs)
15074         (maintenance_check_symtabs, maintenance_info_line_tables):
15075         Update.
15076         * source.c (select_source_symtab)
15077         (forget_cached_source_info_for_objfile): Update.
15078         * objfiles.h (class objfile_compunits): Remove.
15079         (struct objfile) <compunits_range>: New typedef.
15080         (compunits): New method.
15081         * objfiles.c (objfile_relocate1): Update.
15082         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15083         * maint.c (count_symtabs_and_blocks): Update.
15084         * linespec.c (iterate_over_all_matching_symtabs): Update.
15085         * cp-support.c (add_symbol_overload_list_qualified): Update.
15086         * coffread.c (coff_symtab_read): Update.
15087         * ada-lang.c (add_nonlocal_symbols)
15088         (ada_collect_symbol_completion_matches)
15089         (ada_add_global_exceptions): Update.
15090
15091 2019-01-15  Tom Tromey  <tom@tromey.com>
15092
15093         * progspace.h (program_space) <objfiles_safe_range>: New
15094         typedef.
15095         <objfiles_safe>: New method.
15096         * objfiles.h (class all_objfiles_safe): Remove.
15097         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15098         * jit.c (jit_inferior_exit_hook): Update.
15099
15100 2019-01-17  Tom Tromey  <tom@tromey.com>
15101
15102         * progspace.h (program_space) <objfiles_range>: New typedef.
15103         <objfiles>: New method.
15104         <objfiles_head>: Rename from objfiles.
15105         (object_files): Update.
15106         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15107         * guile/scm-pretty-print.c
15108         (ppscm_find_pretty_printer_from_objfiles): Update.
15109         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15110         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15111         Update.
15112         * python/py-progspace.c (pspy_get_objfiles): Update.
15113         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15114         Update.
15115         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15116         (objfpy_lookup_objfile_by_build_id): Update.
15117         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15118         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15119         Update.
15120         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15121         (expand_symtab_containing_pc, lookup_objfile_from_block)
15122         (lookup_static_symbol, basic_lookup_transparent_type)
15123         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15124         (find_line_symtab, info_sources_command)
15125         (default_collect_symbol_completion_matches_break_on)
15126         (make_source_files_completion_list, find_main_name): Update.
15127         * symmisc.c (print_symbol_bcache_statistics)
15128         (print_objfile_statistics, maintenance_print_symbols)
15129         (maintenance_print_msymbols, maintenance_print_objfiles)
15130         (maintenance_info_symtabs, maintenance_check_symtabs)
15131         (maintenance_expand_symtabs, maintenance_info_line_tables):
15132         Update.
15133         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15134         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15135         (map_overlay_command, unmap_overlay_command)
15136         (simple_overlay_update, expand_symtabs_matching)
15137         (map_symbol_filenames): Update.
15138         * symfile-debug.c (set_debug_symfile): Update.
15139         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15140         Update.
15141         * source.c (select_source_symtab, forget_cached_source_info):
15142         Update.
15143         * solib.c (solib_read_symbols): Update.
15144         * solib-spu.c (append_ocl_sos): Update.
15145         * psymtab.c (maintenance_print_psymbols)
15146         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15147         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15148         * printcmd.c (info_symbol_command): Update.
15149         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15150         Update.
15151         * objfiles.h (class all_objfiles): Remove.
15152         * objfiles.c (have_partial_symbols, have_full_symbols)
15153         (have_minimal_symbols, qsort_cmp, update_section_map)
15154         (shared_objfile_contains_address_p)
15155         (default_iterate_over_objfiles_in_search_order): Update.
15156         * objc-lang.c (info_selectors_command, info_classes_command)
15157         (find_methods): Update.
15158         * minsyms.c (find_solib_trampoline_target): Update.
15159         * maint.c (maintenance_info_sections)
15160         (maintenance_translate_address, count_symtabs_and_blocks):
15161         Update.
15162         * main.c (captured_main_1): Update.
15163         * linux-thread-db.c (try_thread_db_load_from_pdir)
15164         (has_libpthread): Update.
15165         * linespec.c (iterate_over_all_matching_symtabs)
15166         (search_minsyms_for_name): Update.
15167         * jit.c (jit_find_objf_with_entry_addr): Update.
15168         * hppa-tdep.c (find_unwind_entry)
15169         (hppa_lookup_stub_minimal_symbol): Update.
15170         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15171         Update.
15172         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15173         (elf_gnu_ifunc_resolve_by_got): Update.
15174         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15175         * dwarf-index-write.c (save_gdb_index_command): Update.
15176         * cp-support.c (add_symbol_overload_list_qualified): Update.
15177         * breakpoint.c (create_overlay_event_breakpoint)
15178         (create_longjmp_master_breakpoint)
15179         (create_std_terminate_master_breakpoint)
15180         (create_exception_master_breakpoint): Update.
15181         * blockframe.c (find_pc_partial_function): Update.
15182         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15183         (ada_collect_symbol_completion_matches)
15184         (ada_add_global_exceptions): Update.
15185
15186 2019-01-17  Tom Tromey  <tom@tromey.com>
15187
15188         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15189         declare VEC.
15190         (solib_target_parse_libraries): Change return type.
15191         (library_list_start_segment, library_list_start_section)
15192         (library_list_end_library, library_list_start_library); Update.
15193         (solib_target_free_library_list): Remove.
15194         (solib_target_parse_libraries): Remove cleanup.  Change return
15195         type.
15196         (solib_target_current_sos): Update.
15197
15198 2019-01-17  Tom Tromey  <tromey@bapiya>
15199
15200         * valprint.c: Replace "the the" with "the".
15201         * symtab.c: Replace "the the" with "the".
15202         * solib.c: Replace "the the" with "the".
15203         * solib-dsbt.c: Replace "the the" with "the".
15204         * linespec.c: Replace "the the" with "the".
15205         * dwarf2loc.h: Replace "the the" with "the".
15206         * amd64-windows-tdep.c: Replace "the the" with "the".
15207         * aarch64-tdep.c: Replace "the the" with "the".
15208
15209 2019-01-16  Keith Seitz  <keiths@redhat.com>
15210
15211         PR gdb/23773
15212         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15213         <builder>: Rename to ..
15214         <m_builder>: ... this and make private.
15215         (dwarf2_cu::get_builder): New method.  Change all users of
15216         `builder' to use this method.
15217         (dwarf2_start_symtab): Move to ...
15218         (dwarf2_cu::start_symtab): ... here.  Update all callers
15219         (setup_type_unit_groups): Move to ...
15220         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15221         callers.
15222         (dwarf2_cu::reset_builder): New method.
15223         (process_full_compunit, process_full_type_unit): Use
15224         dwarf2_cu::reset_builder.
15225         (follow_die_offset): Record the ancestor CU if it is different
15226         from the followed DIE's CU.
15227         (follow_die_sig_1): Likewise.
15228
15229 2019-01-15  Tom Tromey  <tom@tromey.com>
15230
15231         * remote.c (class remote_state) <buf>: Now a char_vector.
15232         <buf_size>: Remove.
15233         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15234         parameter.
15235         (remote_target::getpkt_or_notif_sane_1)
15236         (remote_target::getpkt_sane)
15237         (remote_target::getpkt_or_notif_sane): Likewise.
15238         (class remote_target) <putpkt>: New overload.
15239         (remote_target::read_frame): Change type of "buf_p".  Remove
15240         sizeof_p parameter.
15241         (packet_ok): New overload.
15242         (packet_check_result): New overload.
15243         Update all uses.
15244
15245 2019-01-14  Tom Tromey  <tom@tromey.com>
15246
15247         * remote-notif.c (handle_notification, remote_notif_ack)
15248         (remote_notif_parse): Make "buf" const.
15249         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15250         const.
15251         (remote_notif_parse, remote_notif_ack, handle_notification):
15252         Likewise.
15253         * remote.c (remote_notif_stop_parse): Make "buf" const.
15254         (remote_target::remote_parse_stop_reply): Make "buf" const.
15255         (remote_notif_stop_ack): Make "buf" const.
15256
15257 2019-01-14  Tom Tromey  <tom@tromey.com>
15258
15259         * remote.c (remote_console_output): Make parameter const.
15260
15261 2019-01-14  Tom Tromey  <tom@tromey.com>
15262
15263         * target-debug.h (target_debug_print_signals): Constify.
15264         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15265         * procfs.c (procfs_target::pass_signals): Update.
15266         * linux-nat.c (linux_nat_target::pass_signals): Update.
15267         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15268         * target-delegates.c: Rebuild.
15269         * remote.c (remote_target::program_signals): Update.
15270         (remote_target::pass_signals): Update.
15271         * target.c (target_pass_signals): Constify argument.
15272         (target_program_signals): Likewise.
15273         * target.h (struct target_ops) <pass_signals, program_signals>:
15274         Constify argument.
15275         (target_pass_signals, target_program_signals): Constify argument.
15276
15277 2019-01-14  Tom Tromey  <tom@tromey.com>
15278
15279         PR tui/28819:
15280         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15281
15282 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15283
15284         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15285         field.
15286         * rs6000-tdep.c: Include reggroups.h.
15287         (IS_V_ALIAS_PSEUDOREG): Define.
15288         (rs6000_register_name): Return names for the "vX" aliases.
15289         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15290         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15291         aliases.  Call default_register_reggroup_p for all other
15292         pseudo-registers.
15293         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15294         New functions.
15295         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15296         Handle "vX" aliases.
15297         (v_alias_pseudo_register_collect): New function.
15298         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15299         (rs6000_gdbarch_init): Initialize "vX" aliases as
15300         pseudo-registers.  Restore registration of
15301         rs6000_pseudo_register_reggroup_p with
15302         set_tdesc_pseudo_register_reggroup_p.
15303
15304 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15305
15306         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15307         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15308         set_gdbarch_num_pseudo_regs.
15309
15310 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15311
15312         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15313         Remove arg prefixname, add do_set and do_show.
15314         Add member functions set_list and show_list.
15315         * cli/cli-style.c (class cli_style_option): Update accordingly.
15316         (style_set_list): Move to file scope.
15317         (style_show_list): Likewise.
15318         (set_style): Call help_list.
15319         (show_style): Call cmd_show_list.
15320         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15321         Update to use the new macro.
15322
15323 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15324
15325         * ada-lang.c (_initialize_ada_language): Expand the help text
15326         for the "catch exception" command.
15327
15328 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15329
15330         * symtab.c (matching_obj_sections): Initialize obj,
15331         declare it closer to its usage.
15332
15333 2019-01-10  Tom Tromey  <tom@tromey.com>
15334
15335         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15336         (basic_inf_threads_range): Remove.
15337         (inf_threads_range, inf_non_exited_threads_range)
15338         (safe_inf_threads_range): Use next_adapter.
15339
15340 2019-01-10  Keith Seitz  <keiths@redhat.com>
15341
15342         PR gdb/23712
15343         PR symtab/23010
15344         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15345         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15346
15347 2019-01-10  Keith Seitz  <keiths@redhat.com>
15348
15349         PR gdb/23712
15350         PR symtab/23010
15351         * dictionary.c (pending_to_vector): Remove.
15352         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15353         Remove _1 suffix, replacing functions of the same name.  Update
15354         all callers.
15355         (dict_create_hashed, dict_create_hashed_expandable)
15356         (dict_create_linear, dict_create_linear_expandable, dict_free)
15357         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15358         Make functions static.
15359
15360 2019-01-10  Keith Seitz  <keiths@redhat.com>
15361
15362         PR gdb/23712
15363         PR symtab/23010
15364         * dictionary.h (struct dictionary): Replace declaration with
15365         multidictionary.
15366         (dict_create_hashed, dict_create_hashed_expandable)
15367         (dict_create_linear, dict_create_linear_expandable)
15368         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15369         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15370         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15371         taking multidictionary argument.
15372         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15373         * block.h (struct block) <dict>: Change to multidictionary
15374         and rename `multidict'.
15375         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15376         symmisc.c: Update all dictionary references to multidictionary.
15377
15378 2019-01-10  Keith Seitz  <keiths@redhat.com>
15379
15380         PR gdb/23712
15381         PR symtab/23010
15382         * dictionary.c: Include unordered_map.
15383         (pending_to_vector): New function.
15384         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15385         Rewrite the non-"_1" functions to take vector instead
15386         of linked list.
15387         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15388         "new" _1 versions of the same name.
15389         (multidictionary): Define.
15390         (std::hash<enum language): New definition.
15391         (collate_pending_symbols_by_language, mdict_create_hashed)
15392         (mdict_create_hashed_expandable, mdict_create_linear)
15393         (mdict_create_linear_expandable, mdict_free)
15394         (find_language_dictionary, create_new_language_dictionary)
15395         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15396         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15397         (mdict_size, mdict_empty): New functions.
15398         * dictionary.h (mdict_iterator): Define.
15399
15400 2019-01-10  Pedro Alves  <palves@redhat.com>
15401
15402         * breakpoint.c (read_uploaded_action)
15403         (create_tracepoint_from_upload): Adjust to use
15404         gdb::unique_xmalloc_ptr.
15405         * ctf.c (ctf_write_uploaded_tp):
15406         (SET_ARRAY_FIELD): Use emplace_back.
15407         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15408         * tracefile-tfile.c (tfile_write_uploaded_tp):
15409         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15410         gdb::unique_xmalloc_ptr.
15411         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15412         at_string, cond_string, cmd_strings>: Replace char pointers
15413         with gdb::unique_xmalloc_ptr.
15414
15415 2019-01-10  Pedro Alves  <palves@redhat.com>
15416
15417         * solib-target.c (library_list_start_library): Don't xstrdup name.
15418
15419 2019-01-10  Pedro Alves  <palves@redhat.com>
15420
15421         * mdebugread.c (parse_partial_symbols): Use
15422         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15423
15424 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15425
15426         * linux-fork.c (scoped_switch_fork_info)
15427         <~scoped_switch_fork_info>: Fix incorrect variable name.
15428
15429 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15430
15431         * linux-fork.c (scoped_switch_fork_info)
15432         <scoped_switch_fork_info>: Make explicit.
15433         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15434
15435 2019-01-10  Tom Tromey  <tom@tromey.com>
15436
15437         * objfiles.h (objfile::reset_psymtabs): Update.
15438         * objfiles.c (objfile::objfile): Update.
15439         * psymtab.h (psymtab_storage::obstack): Update.
15440         (psymtab_storage::m_obstack): Use gdb::optional.
15441         (class psymtab_storage): Update comment.  Remove objfile
15442         parameter.
15443         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15444
15445 2019-01-10  Tom Tromey  <tom@tromey.com>
15446
15447         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15448         <free_psymtabs>: Now private.
15449         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15450         (allocate_psymtab): Use new method.
15451
15452 2019-01-10  Tom Tromey  <tom@tromey.com>
15453
15454         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15455         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15456         * mdebugread.c (parse_partial_symbols): Use
15457         allocate_dependencies.
15458         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15459         allocate_dependencies.
15460         (process_psymtab_comp_unit_reader)
15461         (build_type_psymtab_dependencies): Likewise.
15462         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15463
15464 2019-01-10  Tom Tromey  <tom@tromey.com>
15465
15466         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15467         PSYMBOL_SET_LANGUAGE.
15468         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15469
15470 2019-01-10  Tom Tromey  <tom@tromey.com>
15471
15472         * psymtab.h (psymtab_storage::obstack): New method.
15473         <m_obstack>: Rename from obstack; now private.
15474         * psymtab.c (psymtab_storage): Update.
15475         * dwarf2read.c (create_addrmap_from_index)
15476         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15477         Update.
15478
15479 2019-01-10  Tom Tromey  <tom@tromey.com>
15480
15481         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15482         * objfiles.h (objfile::reset_psymtabs): New method.
15483
15484 2019-01-10  Tom Tromey  <tom@tromey.com>
15485
15486         * symmisc.c (print_symbol_bcache_statistics): Update.
15487         (print_objfile_statistics): Update.
15488         * symfile.c (reread_symbols): Update.
15489         * psymtab.h (class psymtab_storage): New.
15490         * psymtab.c (psymtab_storage): New constructor.
15491         (~psymtab_storage): New destructor.
15492         (require_partial_symbols): Update.
15493         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15494         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15495         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15496         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15497         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15498         (start_psymtab_common, end_psymtab_common)
15499         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15500         (allocate_psymtab): Update.
15501         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15502         Update.
15503         (dump_psymtab_addrmap, maintenance_print_psymbols)
15504         (maintenance_check_psymtabs): Update.
15505         (class objfile_psymtabs): Move to objfiles.h.
15506         * psympriv.h (discard_psymtab): Now inline.
15507         (psymtab_discarder::psymtab_discarder): Update.
15508         (psymtab_discarder::~psymtab_discarder): Update.
15509         (ALL_OBJFILE_PSYMTABS): Rewrite.
15510         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15511         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15512         Remove fields.
15513         <partial_symtabs>: New field.
15514         (class objfile_psymtabs): Move from psymtab.h.  Update.
15515         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15516         psymbol_cache.
15517         (objfile::~objfile): Don't destroy psymbol_cache.
15518         * mdebugread.c (parse_partial_symbols): Update.
15519         * dwarf2read.c (create_addrmap_from_index)
15520         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15521         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15522         (add_partial_subprogram, dwarf2_ranges_read): Update.
15523         * dwarf-index-write.c (write_address_map)
15524         (write_one_signatured_type, recursively_write_psymbols)
15525         (class debug_names, class debug_names, write_psymtabs_to_index):
15526         Update.
15527
15528 2019-01-10  Tom Tromey  <tom@tromey.com>
15529
15530         * symtab.h (SYMBOL_SET_NAMES): Update.
15531         (symbol_set_names): Update.
15532         (MSYMBOL_SET_NAMES): Update.
15533         * symtab.c (symbol_set_names): Change argument to be an
15534         objfile_per_bfd_storage.
15535         * psymtab.c (add_psymbol_to_bcache): Update.
15536         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15537
15538 2019-01-10  Tom Tromey  <tom@tromey.com>
15539
15540         * symtab.c (create_demangled_names_hash): Change argument to be an
15541         objfile_per_bfd_storage.
15542         (symbol_set_names): Update.
15543
15544 2019-01-10  Tom Tromey  <tom@tromey.com>
15545
15546         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15547         init_psymbol_list.
15548         * psymtab.c (init_psymbol_list): Do nothing if already called.
15549         * psympriv.h (init_psymbol_list): Add comment.
15550         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15551         init_psymbol_list.
15552         * dbxread.c (dbx_symfile_read): Unconditionally call
15553         init_psymbol_list.
15554
15555 2019-01-10  Tom Tromey  <tom@tromey.com>
15556
15557         * xcoffread.c (scan_xcoff_symtab): Update.
15558         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15559         "where".
15560         * mdebugread.c (parse_partial_symbols)
15561         (handle_psymbol_enumerators): Update.
15562         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15563         * dbxread.c (read_dbx_symtab): Update.
15564         * psympriv.h (psymbol_placement): New enum.
15565         (add_psymbol_to_list): Update.
15566
15567 2019-01-10  Tom Tromey  <tom@tromey.com>
15568
15569         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15570         static_psymbols parameters.
15571         (scan_xcoff_symtab): Update.
15572         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15573         static_psymbols parameters.
15574         * psympriv.h (start_psymtab_common): Update.
15575         * mdebugread.c (parse_partial_symbols): Update.
15576         * dwarf2read.c (create_partial_symtab): Update.
15577         * dbxread.c (read_dbx_symtab): Update.
15578         (start_psymtab): Remove global_psymbols and static_psymbols
15579         parameters.
15580
15581 2019-01-10  Tom Tromey  <tom@tromey.com>
15582
15583         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15584         * psymtab.c (allocate_psymtab): Add comment.
15585         * psympriv.h (allocate_psymtab): Add comment.
15586         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15587         initializations.
15588         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15589
15590 2019-01-10  Tom Tromey  <tom@tromey.com>
15591
15592         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15593         Don't declare.
15594         * mipsread.c: Include mdebugread.h.
15595         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15596         Declare.
15597         * elfread.c: Include mdebugread.h.
15598
15599 2019-01-09  Tom Tromey  <tom@tromey.com>
15600
15601         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15602         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15603         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15604         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15605         (psym_lookup_symbol, psym_find_last_source_symtab)
15606         (psym_forget_cached_source_info, psym_print_stats)
15607         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15608         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15609         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15610         (psym_find_compunit_symtab_by_address)
15611         (maintenance_print_psymbols, maintenance_info_psymtabs)
15612         (maintenance_check_psymtabs): Use ranged for.
15613         * psymtab.h (class objfile_psymtabs): New.
15614         (require_partial_symbols): Return objfile_psymtabs.
15615         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15616
15617 2019-01-09  Tom Tromey  <tom@tromey.com>
15618
15619         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15620         (find_pc_mapped_section, list_overlays_command)
15621         (map_overlay_command, unmap_overlay_command)
15622         (simple_overlay_update): Use all_objfiles.
15623         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15624         * printcmd.c (info_symbol_command): Use all_objfiles.
15625         * objfiles.h (ALL_OBJSECTIONS): Remove.
15626         * maint.c (maintenance_translate_address): Use all_objfiles.
15627         * gcore.c (gcore_create_callback): Use all_objfiles.
15628         (objfile_find_memory_regions): Likewise.
15629
15630 2019-01-09  Tom Tromey  <tom@tromey.com>
15631
15632         * symtab.c (find_line_symtab, info_sources_command)
15633         (make_source_files_completion_list): Use objfile_compunits.
15634         * source.c (select_source_symtab): Use objfile_compunits.
15635         * objfiles.h (struct objfile): Update comment.
15636         (ALL_OBJFILES): Remove.
15637         (ALL_FILETABS): Remove.
15638         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15639         objfile_compunits.
15640
15641 2019-01-09  Tom Tromey  <tom@tromey.com>
15642
15643         * symmisc.c (print_objfile_statistics, dump_objfile)
15644         (maintenance_print_symbols): Use compunit_filetabs.
15645         * source.c (forget_cached_source_info_for_objfile): Use
15646         compunit_filetabs.
15647         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15648         (ALL_FILETABS): Use compunit_filetabs.
15649         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15650         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15651
15652 2019-01-09  Tom Tromey  <tom@tromey.com>
15653
15654         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15655         (compunit_filetabs): New.
15656         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15657         compunit_filetabs.
15658         (info_sources_command, make_source_files_completion_list): Remove
15659         declaration.
15660         * symmisc.c (print_objfile_statistics, dump_objfile)
15661         (maintenance_print_symbols): Remove declaration.
15662         (maintenance_info_symtabs): Use compunit_filetabs.
15663         (maintenance_info_line_tables): Likewise.
15664         * source.c (select_source_symtab): Change local variable name.
15665         (forget_cached_source_info_for_objfile): Remove declaration.
15666         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15667         * objfiles.c (objfile_relocate1): Remove declaration.
15668         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15669         declaration.
15670         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15671         * coffread.c (coff_symtab_read): Remove declaration.
15672         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15673         compunit_filetabs.
15674
15675 2019-01-09  Tom Tromey  <tom@tromey.com>
15676
15677         * symtab.c (lookup_objfile_from_block)
15678         (find_pc_sect_compunit_symtab, search_symbols)
15679         (default_collect_symbol_completion_matches_break_on): Use
15680         objfile_compunits.
15681         * objfiles.h (ALL_COMPUNITS): Remove.
15682         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15683         * cp-support.c (add_symbol_overload_list_qualified): Use
15684         objfile_compunits.
15685         * ada-lang.c (ada_collect_symbol_completion_matches)
15686         (ada_add_global_exceptions): Use objfile_compunits.
15687
15688 2019-01-09  Tom Tromey  <tom@tromey.com>
15689
15690         * source.c (select_source_symtab)
15691         (forget_cached_source_info_for_objfile): Remove declaration.
15692         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15693         declaration.
15694         * maint.c (count_symtabs_and_blocks): Remove declaration.
15695         * cp-support.c (add_symbol_overload_list_qualified): Remove
15696         declaration.
15697         * coffread.c (coff_symtab_read): Remove declaration.
15698         * symtab.c (lookup_symbol_in_objfile_symtabs)
15699         (basic_lookup_transparent_type_1): Use objfile_compunits.
15700         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15701         (info_sources_command, search_symbols)
15702         (default_collect_symbol_completion_matches_break_on)
15703         (make_source_files_completion_list): Remove declaration.
15704         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15705         (ada_collect_symbol_completion_matches)
15706         (ada_add_global_exceptions): Remove declaration.
15707         * linespec.c (iterate_over_all_matching_symtabs): Use
15708         objfile_compunits.
15709         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15710         (class objfile_compunits): New.
15711         (ALL_COMPUNITS): Use objfile_compunits.
15712         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15713         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15714         objfile_compunits.
15715         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15716
15717 2019-01-09  Tom Tromey  <tom@tromey.com>
15718
15719         * symtab.c (search_symbols)
15720         (default_collect_symbol_completion_matches_break_on): Use
15721         objfile_msymbols.
15722         * ada-lang.c (ada_lookup_simple_minsym)
15723         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15724         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15725         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15726         objfile_msymbols.
15727         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15728         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15729         * objc-lang.c (find_methods): Use objfile_msymbols.
15730         (info_selectors_command, info_classes_command): Likewise.
15731         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15732         * objfiles.h (class objfile_msymbols): New.
15733         (ALL_OBJFILE_MSYMBOLS): Remove.
15734         (ALL_MSYMBOLS): Remove.
15735
15736 2019-01-09  Tom Tromey  <tom@tromey.com>
15737
15738         * common/next-iterator.h (next_adapter): Add Iterator template
15739         parameter.
15740         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15741         (class all_objfiles_safe): New.
15742         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15743         * objfiles.c (put_objfile_before): Update comment.
15744         (add_separate_debug_objfile): Likewise.
15745         (free_all_objfiles): Use all_objfiles_safe.
15746         (objfile_purge_solibs): Likewise.
15747
15748 2019-01-09  Tom Tromey  <tom@tromey.com>
15749
15750         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15751         (expand_symtab_containing_pc, lookup_static_symbol)
15752         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15753         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15754         all_objfiles.
15755         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15756         * breakpoint.c (create_overlay_event_breakpoint)
15757         (create_longjmp_master_breakpoint)
15758         (create_std_terminate_master_breakpoint)
15759         (create_exception_master_breakpoint): Use all_objfiles.
15760         * linux-thread-db.c (try_thread_db_load_from_pdir)
15761         (has_libpthread): Use all_objfiles.
15762         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15763         * linespec.c (iterate_over_all_matching_symtabs)
15764         (search_minsyms_for_name): Use all_objfiles.
15765         * maint.c (maintenance_info_sections): Use all_objfiles.
15766         * main.c (captured_main_1): Use all_objfiles.
15767         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15768         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15769         * guile/scm-pretty-print.c
15770         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15771         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15772         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15773         (maintenance_print_msymbols): Use all_objfiles.
15774         * source.c (select_source_symtab): Use all_objfiles.
15775         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15776         * symfile.c (remove_symbol_file_command)
15777         (expand_symtabs_matching, map_symbol_filenames): Use
15778         all_objfiles.
15779         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15780         all_objfiles.
15781         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15782         * objc-lang.c (find_methods): Use all_objfiles.
15783         * objfiles.c (have_partial_symbols, have_full_symbols)
15784         (have_minimal_symbols, qsort_cmp)
15785         (default_iterate_over_objfiles_in_search_order): Use
15786         all_objfiles.
15787         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15788         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15789         (maintenance_check_psymtabs): Use all_objfiles.
15790         (ALL_PSYMTABS): Remove.
15791         * compile/compile-object-run.c (do_module_cleanup): Use
15792         all_objfiles.
15793         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15794         * cp-support.c (add_symbol_overload_list_qualified): Use
15795         all_objfiles.
15796         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15797         Use all_objfiles.
15798         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15799         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15800         all_objfiles.
15801         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15802         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15803         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15804         Uses all_objfiles.
15805         * solib.c (solib_read_symbols): Use all_objfiles
15806
15807 2019-01-09  Tom Tromey  <tom@tromey.com>
15808
15809         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15810         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15811         all_objfiles.
15812         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15813         * symmisc.c (print_symbol_bcache_statistics)
15814         (print_objfile_statistics, maintenance_print_objfiles)
15815         (maintenance_info_symtabs, maintenance_check_symtabs)
15816         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15817         all_objfiles.
15818         * source.c (forget_cached_source_info): Use all_objfiles.
15819         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15820         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15821         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15822         * objfiles.c (update_section_map): Use all_objfiles.
15823         (shared_objfile_contains_address_p): Likewise.
15824         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15825         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15826
15827 2019-01-09  Tom Tromey  <tom@tromey.com>
15828
15829         * common/next-iterator.h: New file.
15830         * objfiles.h (class all_objfiles): New.
15831         (struct objfile_iterator): New.
15832
15833 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15834
15835         * NEWS: Move the description of the changed "frame", "select-frame",
15836          and "info frame" commands to the Changed commands section.
15837
15838 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15839
15840         * gdbtypes.c (check_stub_method_group): Remove handling of old
15841         mangling schemes.
15842         * linespec.c (find_methods): Likewise.
15843         * stabsread.c (read_member_functions): Likewise.
15844         * valops.c (search_struct_method): Likewise.
15845         (value_struct_elt_for_reference): Likewise.
15846         * NEWS: Mention this change.
15847
15848 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15849
15850         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15851         print_source_lines.
15852         * source.c (print_source_lines_base): Update line number check.
15853         (print_source_lines): New function.
15854         (source_lines_range::source_lines_range): New function.
15855         * source.h (class source_lines_range): New class.
15856         (print_source_lines): New declaration.
15857
15858 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15859
15860         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15861
15862 2019-01-08  Tom Tromey  <tom@tromey.com>
15863             Simon Marchi  <simon.marchi@ericsson.com>
15864
15865         PR gdb/24060
15866         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15867         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15868         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15869         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15870         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15871         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15872
15873 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15874
15875         * source.c (select_source_symtab): Move header comment to
15876         declaration in source.h.
15877         (forget_cached_source_info_for_objfile): Likewise.
15878         (forget_cached_source_info): Likewise.
15879         (identify_source_line): Likewise.
15880         * source.h (identify_source_line): Move declaration from symtab.h
15881         and add comment from source.c
15882         (print_source_lines): Likewise.
15883         (forget_cached_source_info_for_objfile): Likewise.
15884         (forget_cached_source_info): Likewise.
15885         (select_source_symtab): Likewise.
15886         (enum print_source_lines_flag): Move definition from symtab.h.
15887         * symtab.h (identify_source_line): Move declaration to source.h.
15888         (print_source_lines): Likewise.
15889         (forget_cached_source_info_for_objfile): Likewise.
15890         (forget_cached_source_info): Likewise.
15891         (select_source_symtab): Likewise.
15892         (enum print_source_lines_flag): Move definition to source.h.
15893         * tui/tui-hooks.c: Add 'source.h' include.
15894
15895 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15896
15897         * source.c (print_source_lines_base): Handle requests to print
15898         reverse line number sequences, and guard against empty lines
15899         string.
15900
15901 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15902
15903         * source.c (print_source_lines_base): Fix skip of '\r' if next
15904         character is '\n'.
15905
15906 2019-01-06  Tom Tromey  <tom@tromey.com>
15907
15908         * c-exp.y (struct c_parse_state) <macro_original_text,
15909         expansion_obstack>: New member.
15910         (macro_original_text, expansion_obstack): Remove globals.
15911         (scan_macro_expansion, scanning_macro_expansion)
15912         (finished_macro_expansion): Update.
15913         (scan_macro_cleanup): Remove.
15914         (yylex, c_parse): Update.
15915
15916 2019-01-06  Tom Tromey  <tom@tromey.com>
15917
15918         * c-exp.y (struct c_parse_state) <strings>: New member.
15919         (operator_stoken): Update.
15920
15921 2019-01-06  Tom Tromey  <tom@tromey.com>
15922
15923         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15924         (union type_stack_elt) <typelist_val>: Now a pointer to
15925         std::vector.
15926         (type_stack_cleanup): Don't declare.
15927         (push_typelist): Update.
15928         * parse.c (pop_typelist): Return a std::vector.
15929         (push_typelist): Take a std::vector.
15930         (follow_types): Update.  Do not free args.
15931         (type_stack_cleanup): Remove.
15932         * c-exp.y (struct c_parse_state): New.
15933         (cpstate): New global.
15934         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15935         (nonempty_typelist): Update.
15936         (func_mod): Create a new vector.
15937         (c_parse): Create a c_parse_state.
15938         (check_parameter_typelist): Do not delete params.
15939         (function_method): Update.  Do not delete type_list.
15940
15941 2019-01-06  Tom Tromey  <tom@tromey.com>
15942
15943         PR gdb/28155:
15944         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15945         check_typedef.
15946         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15947         (print_return_value): Likewise.
15948
15949 2019-01-05  Tom Tromey  <tom@tromey.com>
15950
15951         * contrib/cleanup_check.py: Remove.
15952         * contrib/gcc-with-excheck: Remove.
15953         * contrib/exsummary.py: Remove.
15954         * contrib/excheck.py: Remove.
15955
15956 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15957
15958         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15959         NULL. Initialize tpprev to NULL instead of assigning it
15960         to NULL on the next statement.
15961         * windows-nat.c (windows_delete_thread): Remove check for
15962         main_thread_id before printing thread exit notifications.
15963         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15964         Remove thread ID check against main_thread_id.
15965         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15966         windows_delete_thread.
15967         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15968
15969 2019-01-04  Tom Tromey  <tom@tromey.com>
15970
15971         * compile/compile.c (_initialize_compile): Use upper case for
15972         metasyntactic variables.
15973         * symmisc.c (_initialize_symmisc): Use upper case for
15974         metasyntactic variables.
15975         * psymtab.c (_initialize_psymtab): Use upper case for
15976         metasyntactic variables.
15977         * demangle.c (demangle_command): Use upper case for metasyntactic
15978         variables.
15979         (_initialize_demangler): Likewise.
15980         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15981         variables.
15982
15983 2019-01-03  Tom Tromey  <tom@tromey.com>
15984
15985         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15986
15987 2019-01-03  Tom Tromey  <tom@tromey.com>
15988
15989         * python/py-symtab.c (salpy_str): Update.
15990         (struct salpy_sal_object) <symtab>: Now a PyObject.
15991         (salpy_dealloc): Update.
15992         (del_objfile_sal): Use gdbpy_ref.
15993
15994 2019-01-03  Tom Tromey  <tom@tromey.com>
15995
15996         * python/py-type.c (convert_field): Use new_reference.  Return
15997         gdbpy_ref.
15998         (make_fielditem): Return gdbpy_ref.
15999         (typy_fields): Update.
16000         (typy_getitem): Update.
16001         (field_name): Return gdbpy_ref.  Use new_reference.
16002         (typy_iterator_iternext): Update.
16003
16004 2019-01-03  Tom Tromey  <tom@tromey.com>
16005
16006         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16007
16008 2019-01-03  Tom Tromey  <tom@tromey.com>
16009
16010         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16011         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16012         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16013         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16014         (pspy_set_type_printers): Likewise.
16015         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16016         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16017         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16018         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16019         (objfpy_set_type_printers): Likewise.
16020
16021 2019-01-03  Tom Tromey  <tom@tromey.com>
16022
16023         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16024         (gdbpy_print_stack): Use gdbpy_err_fetch.
16025         * python/python-internal.h (class gdbpy_err_fetch): New class.
16026         (class gdbpy_enter) <m_error_type, m_error_value,
16027         m_error_traceback>: Remove.
16028         <m_error>: New member.
16029         (gdbpy_exception_to_string): Don't declare.
16030         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16031         * python/py-value.c (convert_value_from_python): Use
16032         gdbpy_err_fetch.
16033         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16034         gdbpy_exception_to_string.
16035         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16036         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16037         gdbpy_err_fetch.
16038
16039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16040
16041         * linux-nat.c (delete_lwp_cleanup): Delete.
16042         (struct lwp_deleter): New struct.
16043         (lwp_info_up): New typedef.
16044         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16045         lwp_info_up.
16046
16047 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16048
16049         * linux-fork.c (class scoped_switch_fork_info): New class.
16050         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16051
16052 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16053
16054         * valops.c (find_overload_match): Remove use of null_cleanup, and
16055         calls to do_cleanups.
16056
16057 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16058
16059         * compile/compile-cplus-types.c
16060         (compile_cplus_instance::decl_name): Handle changes to
16061         cp_func_name.
16062         * cp-support.c (cp_func_name): Update header comment, update
16063         return type.
16064         * cp-support.h (cp_func_name): Update return type in declaration.
16065         * valops.c (find_overload_match): Move temp_func local to top
16066         level of function and change its type.  Use temp_func to hold and
16067         delete temporary string obtained from cp_func_name.
16068
16069 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16070
16071         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16072         gdb::char_vector, remove cleanup, and update uses of `msg`.
16073
16074 2019-01-03  Jim Wilson  <jimw@sifive.com>
16075
16076         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16077
16078 2019-01-02  Tom Tromey  <tom@tromey.com>
16079
16080         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16081         (tdesc_parse_xml): Remove cleanups.
16082         * target-descriptions.h (make_cleanup_free_target_description):
16083         Don't declare.
16084         (target_desc_deleter): New struct.
16085         (target_desc_up): New typedef.
16086         * target-descriptions.c (target_desc_deleter::operator()): Rename
16087         from free_target_description.
16088         (make_cleanup_free_target_description): Remove.
16089
16090 2019-01-02  Tom Tromey  <tom@tromey.com>
16091
16092         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16093         constructor, destructor.
16094         (linespec_parser): Remove typedef.
16095         (~linespec_parser): Rename from linespec_parser_delete.
16096         (linespec_lex_to_end, linespec_complete_label)
16097         (linespec_complete): Update.
16098         (decode_line_full): Remove cleanups.
16099         (decode_line_1): Update.
16100
16101 2019-01-02  Tom Tromey  <tom@tromey.com>
16102
16103         * python/python-internal.h (inferior_to_inferior_object): Change
16104         return type.
16105         * python/py-exitedevent.c (create_exited_event_object): Update.
16106         * python/py-inferior.c (inferior_to_inferior_object): Return
16107         gdbpy_ref.
16108         (python_new_inferior, python_inferior_deleted)
16109         (thread_to_thread_object, delete_thread_object)
16110         (build_inferior_list, gdbpy_selected_inferior): Update.
16111         * python/py-infthread.c (create_thread_object): Update.  Also fail
16112         if inferior_to_inferior_object fails.
16113
16114 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16115
16116         * inferior.h (class inferior) <displaced_step_state>: New field.
16117         * infrun.h (struct displaced_step_state): Move here from
16118         infrun.c.  Initialize fields, add constructor.
16119         <inf>: Remove field.
16120         <reset>: New method.
16121         * infrun.c (struct displaced_step_inferior_state): Move to
16122         infrun.h.
16123         (displaced_step_inferior_states): Remove.
16124         (get_displaced_stepping_state): Adust.
16125         (displaced_step_in_progress_any_inferior): Adjust.
16126         (displaced_step_in_progress_thread): Adjust.
16127         (displaced_step_in_progress): Adjust.
16128         (add_displaced_stepping_state): Remove.
16129         (get_displaced_step_closure_by_addr): Adjust.
16130         (remove_displaced_stepping_state): Remove.
16131         (infrun_inferior_exit): Call displaced_step_state.reset.
16132         (use_displaced_stepping): Don't check for NULL.
16133         (displaced_step_prepare_throw): Call
16134         get_displaced_stepping_state.
16135         (displaced_step_fixup): Don't check for NULL.
16136         (prepare_for_detach): Don't check for NULL.
16137
16138 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16139
16140         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16141          in case of call that did not complete.
16142
16143 2019-01-02  Andrey Utkin  <autkin@undo.io>
16144
16145         * symfile.c (find_separate_debug_file): Fix search of debug files for
16146         remote debuggee.
16147
16148 2019-01-02  Tom Tromey  <tom@tromey.com>
16149
16150         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16151         indentation.
16152         * python/py-frame.c (frapy_older): Remove cast.
16153         (frapy_newer): Likewise.
16154         * python/py-breakpoint.c (local_setattro): Remove cast.
16155         * python/py-arch.c (archpy_name): Remove local variable.
16156         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16157
16158 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16159
16160         * unittests/basic_string_view/element_access/char/empty.cc:
16161         Fix year range in copyright header.
16162
16163 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16164
16165         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16166         Delete.
16167         <operator==>: Update with for removed field.
16168         <hash>: Likewise.
16169         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16170         <isa_features>: ...this.
16171         <abi_features>: New field.
16172         (riscv_isa_flen): Update comment.
16173         (riscv_abi_xlen): New declaration.
16174         (riscv_abi_flen): New declaration.
16175         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16176         isa_features.
16177         (riscv_abi_xlen): New function.
16178         (riscv_isa_flen): Update to get answer from isa_features.
16179         (riscv_abi_flen): New function.
16180         (riscv_has_fp_abi): Update to get answer from abi_features.
16181         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16182         xlen and flen.
16183         (riscv_call_info) <xlen, flen>: Update comment.
16184         (riscv_call_arg_struct): Remove invalid assertions
16185         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16186         is removed.
16187         (riscv_gdbarch_init): Gather isa features and abi features
16188         separately, ensure both match on the gdbarch when reusing an old
16189         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16190         a target with 64-bit float hardware.
16191
16192 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16193
16194         * source.c (search_command_helper): Stop reverse search
16195         when line 1 has been searched.
16196
16197 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16198
16199         * record-full.c (record_full_base_target::close): Rewrite
16200         record_full_core_buf_list free logic.
16201
16202 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16203
16204         * break-catch-syscall.c (print_one_catch_syscall): xfree
16205         the last text.
16206
16207 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16208
16209         * top.c (print_gdb_version): Update Copyright year in version
16210         message.
16211
16212 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16213
16214         Update copyright year range in all GDB files.
16215
16216 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16217
16218         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16219
16220 For older changes see ChangeLog-2018.
16221 \f
16222 Local Variables:
16223 mode: change-log
16224 left-margin: 8
16225 fill-column: 74
16226 version-control: never
16227 coding: utf-8
16228 End:
16229