infcall: refactor 'call_function_by_hand_dummy'
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2
3 * infcall.c (call_function_by_hand_dummy): Fix the function
4 comment. And extract out a code section into...
5 (reserve_stack_space): ...this new function.
6
7 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
8
9 * infcall.c (value_arg_coerce): Remove an unused parameter.
10 (call_function_by_hand_dummy): Update the call to
11 'value_arg_coerce'.
12
13 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
14
15 * infcall.c (call_function_by_hand_dummy): Refactor.
16
17 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
18
19 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
20
21 2019-10-23 Tom Tromey <tom@tromey.com>
22
23 * configure: Rebuild.
24 * configure.ac: Don't check for sigprocmask.
25 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
26
27 2019-10-23 Tom Tromey <tom@tromey.com>
28
29 * configure: Rebuild.
30 * acinclude.m4: Use m4_include, not sinclude.
31
32 2019-10-23 Tom de Vries <tdevries@suse.de>
33
34 PR breakpoints/24687
35 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
36
37 2019-10-22 Christian Biesinger <cbiesinger@google.com>
38
39 * symtab.c (struct demangled_name_entry) <language>: Change from
40 bitfield to regular variable.
41
42 2019-10-22 Christian Biesinger <cbiesinger@google.com>
43
44 * symtab.c (struct demangled_name_entry): Add a constructor.
45 (free_demangled_name_entry): New function to call the destructor
46 for demangled_name_entry.
47 (create_demangled_names_hash): Pass free_demangled_name_entry to
48 htab_create_alloc.
49 (symbol_set_names): Call placement new for demangled_name_entry.
50 * utils.c: No longer include xxhash.h here, now that fast_hash
51 is inlined in the header.
52 * utils.h: Instead, include it here.
53
54 2019-10-22 Christian Biesinger <cbiesinger@google.com>
55
56 * Makefile.in: Link with libxxhash.
57 * config.in: Regenerate.
58 * configure: Regenerate.
59 * configure.ac: Search for libxxhash.
60 * utils.c (fast_hash): Use xxhash if present.
61
62 2019-10-22 Christian Biesinger <cbiesinger@google.com>
63
64 * utils.h (fast_hash): New function.
65 * symtab.c (hash_demangled_name_entry): Call new function
66 fast_hash.
67
68 2019-10-22 Christian Biesinger <cbiesinger@google.com>
69
70 * symtab.c (struct demangled_name_entry): Change type of mangled
71 to gdb::string_view. Also adds a constructor that takes the
72 mangled name.
73 (hash_demangled_name_entry): Update.
74 (eq_demangled_name_entry): Update.
75 (free_demangled_name_entry): New function to call the destructor
76 now that this is not a POD anymore.
77 (create_demangled_names_hash): Pass free_demangled_name_entry to
78 htab_create_alloc.
79 (symbol_set_names): Update.
80
81 2019-10-21 Ali Tamur <tamu@google.com>
82
83 * dwarf2read.c (dir_index): Change type.
84 (file_name_index): Likewise.
85 (line_header::include_dir_at): Change comment and implementation on
86 whether it is DWARF 5.
87 (line_header::is_valid_file_index): New function.
88 (line_header::file_name_at): Change comment and implementation on
89 whether it is DWARF 5.
90 (line_header::file_names): Change to private field renamed as
91 m_file_names and introduce a new accessor method.
92 (line_header::file_names_size): New method.
93 (line_header::include_dirs): Change to private field and rename as
94 m_include_dirs.
95 (dw2_get_file_names_reader): Define local var at a smaller scope and
96 reflect API change.
97 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
98 (process_structure_scope): Likewise.
99 (line_header::add_include_dir): Change message and reflect renaming.
100 (line_header::add_file_name): Likewise.
101 (read_formatted_entries): Handle DW_FORM_data16.
102 (dwarf_decode_line_header): Fix line header length calculation.
103 (psymtab_include_file_name): Change comment and API.
104 (lnp_state_machine::m_file): Update comment and reflect type change.
105 (lnp_state_machine::record_line): Reflect type change.
106 (dwarf_decode_lines): Reflect API change.
107 (file_file_name): Likewise.
108 (file_full_name): Likewise.
109
110 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
111
112 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
113
114 2019-10-21 Tom Tromey <tom@tromey.com>
115
116 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
117
118 2019-10-21 Tom Tromey <tom@tromey.com>
119
120 * configure.ac (nm.h): Conditionally create nm.h link. Subst
121 NM_H. Use AC_CONFIG_LINKS.
122 * configure: Rebuild.
123 * Makefile.in (NM_H): New variable.
124 (generated_files): Add NM_H. Remove gcore.
125 (nm.h, stamp-nmh): New targets.
126
127 2019-10-20 Tom Tromey <tom@tromey.com>
128
129 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
130 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
131 obsolete comment.
132 (put_objfile_before): Now static.
133
134 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
135
136 * gdbsupport/common-utils.h (startswith): Change return type to
137 bool.
138
139 2019-10-19 Christian Biesinger <cbiesinger@google.com>
140
141 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
142 * breakpoint.c (bp_locations_compare): Rename to...
143 (bp_location_is_less_than): ...this, and change to std::sort semantics.
144 (update_global_location_list): Use std::sort instead of qsort.
145 * buildsym.c (compare_line_numbers): Rename to...
146 (lte_is_less_than): ...this, and change to std::sort semantics.
147 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
148 instead of qsort.
149 * disasm.c (compare_lines): Rename to...
150 (line_is_less_than): ...this, and change to std::sort semantics.
151 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
152 of qsort.
153 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
154 (fde_is_less_than): ...this, and change to std::sort semantics.
155 (dwarf2_build_frame_info): Call std::sort instead of qsort.
156 * mdebugread.c (compare_blocks):
157 (block_is_less_than): ...this, and change to std::sort semantics.
158 (sort_blocks): Call std::sort instead of qsort.
159 * objfiles.c (qsort_cmp): Rename to...
160 (sort_cmp): ...this, and change to std::sort semantics.
161 (update_section_map): Call std::sort instead of qsort.
162 * remote.c (compare_pnums): Remove.
163 (map_regcache_remote_table): Call std::sort instead of qsort.
164 * utils.c (compare_positive_ints): Remove.
165 * utils.h (compare_positive_ints): Remove.
166 * xcoffread.c (compare_lte): Remove.
167 (arrange_linetable): Call std::sort instead of qsort.
168
169 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
170
171 * symfile.c (init_entry_point_info): Fix typo.
172 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
173
174 2019-10-18 Tom de Vries <tdevries@suse.de>
175
176 * aarch64-tdep.c: Fix typos in comments.
177 * ada-lang.c: Same.
178 * ada-tasks.c: Same.
179 * alpha-tdep.c: Same.
180 * alpha-tdep.h: Same.
181 * amd64-nat.c: Same.
182 * amd64-windows-tdep.c: Same.
183 * arc-tdep.c: Same.
184 * arc-tdep.h: Same.
185 * arch-utils.c: Same.
186 * arm-nbsd-tdep.c: Same.
187 * arm-tdep.c: Same.
188 * ax-gdb.c: Same.
189 * blockframe.c: Same.
190 * btrace.c: Same.
191 * c-varobj.c: Same.
192 * coff-pe-read.c: Same.
193 * coffread.c: Same.
194 * cris-tdep.c: Same.
195 * darwin-nat.c: Same.
196 * dbxread.c: Same.
197 * dcache.c: Same.
198 * disasm.c: Same.
199 * dtrace-probe.c: Same.
200 * dwarf-index-write.c: Same.
201 * dwarf2-frame-tailcall.c: Same.
202 * dwarf2-frame.c: Same.
203 * dwarf2read.c: Same.
204 * eval.c: Same.
205 * exceptions.c: Same.
206 * fbsd-tdep.c: Same.
207 * findvar.c: Same.
208 * frame.c: Same.
209 * frv-tdep.c: Same.
210 * gnu-v3-abi.c: Same.
211 * go32-nat.c: Same.
212 * h8300-tdep.c: Same.
213 * hppa-tdep.c: Same.
214 * i386-linux-tdep.c: Same.
215 * i386-tdep.c: Same.
216 * ia64-libunwind-tdep.c: Same.
217 * ia64-tdep.c: Same.
218 * infcmd.c: Same.
219 * infrun.c: Same.
220 * linespec.c: Same.
221 * linux-nat.c: Same.
222 * linux-thread-db.c: Same.
223 * machoread.c: Same.
224 * mdebugread.c: Same.
225 * mep-tdep.c: Same.
226 * mn10300-tdep.c: Same.
227 * namespace.c: Same.
228 * objfiles.c: Same.
229 * opencl-lang.c: Same.
230 * or1k-tdep.c: Same.
231 * osabi.c: Same.
232 * ppc-linux-nat.c: Same.
233 * ppc-linux-tdep.c: Same.
234 * ppc-sysv-tdep.c: Same.
235 * printcmd.c: Same.
236 * procfs.c: Same.
237 * record-btrace.c: Same.
238 * record-full.c: Same.
239 * remote-fileio.c: Same.
240 * remote.c: Same.
241 * rs6000-tdep.c: Same.
242 * s12z-tdep.c: Same.
243 * score-tdep.c: Same.
244 * ser-base.c: Same.
245 * ser-go32.c: Same.
246 * skip.c: Same.
247 * sol-thread.c: Same.
248 * solib-svr4.c: Same.
249 * solib.c: Same.
250 * source.c: Same.
251 * sparc-nat.c: Same.
252 * sparc-sol2-tdep.c: Same.
253 * sparc-tdep.c: Same.
254 * sparc64-tdep.c: Same.
255 * stabsread.c: Same.
256 * stack.c: Same.
257 * symfile.c: Same.
258 * symtab.c: Same.
259 * target-descriptions.c: Same.
260 * target-float.c: Same.
261 * thread.c: Same.
262 * utils.c: Same.
263 * valops.c: Same.
264 * valprint.c: Same.
265 * value.c: Same.
266 * varobj.c: Same.
267 * windows-nat.c: Same.
268 * xcoffread.c: Same.
269 * xstormy16-tdep.c: Same.
270 * xtensa-tdep.c: Same.
271
272 2019-10-17 Tom Tromey <tromey@adacore.com>
273
274 * configure: Rebuild.
275 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
276 in AC_CONFIG_FILES invocation.
277 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
278 new-style config.status invocation.
279
280 2019-10-17 Tom de Vries <tdevries@suse.de>
281
282 * arm-nbsd-nat.c: Fix typos in comments.
283 * arm-tdep.c: Same.
284 * darwin-nat-info.c: Same.
285 * dwarf2read.c: Same.
286 * elfread.c: Same.
287 * event-top.c: Same.
288 * findvar.c: Same.
289 * gdbtypes.c: Same.
290 * hppa-tdep.c: Same.
291 * i386-tdep.c: Same.
292 * jit.c: Same.
293 * main.c: Same.
294 * mdebugread.c: Same.
295 * moxie-tdep.c: Same.
296 * nto-procfs.c: Same.
297 * osabi.c: Same.
298 * ppc-linux-tdep.c: Same.
299 * remote.c: Same.
300 * riscv-tdep.c: Same.
301 * s390-tdep.c: Same.
302 * sh-tdep.c: Same.
303 * sparc-linux-tdep.c: Same.
304 * sparc-nat.c: Same.
305 * stack.c: Same.
306 * target-descriptions.c: Same.
307 * top.c: Same.
308 * varobj.c: Same.
309
310 2019-10-16 Tom Tromey <tom@tromey.com>
311
312 * objfiles.h (struct objfile) <original_name>: Now const.
313
314 2019-10-16 Christian Biesinger <cbiesinger@google.com>
315
316 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
317 pass on to sigsetjmp's second argument.
318 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
319
320 2019-10-16 Keith Seitz <keiths@redhat.com>
321
322 PR gdb/23567
323 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
324 sections whose size is greater than the file size.
325
326 2019-10-16 Jim Wilson <jimw@sifive.com>
327
328 * riscv-tdep.c (riscv_gcc_target_options): New.
329 (riscv_gnu_triplet_regexp): New.
330 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
331 set_gdbarch_gnu_triplet_regexp.
332
333 2019-10-16 Christian Biesinger <cbiesinger@google.com>
334
335 * Makefile.in: Add xml-builtin.h.
336 * features/feature_to_c.sh: Add an include for xml-builtin.h
337 to ensure that the compiler checks that the types match.
338 * xml-builtin.h: New file.
339 * xml-support.c (fetch_xml_builtin): Add missing const.
340 * xml-support.h: Remove declaration of xml_builtins.
341
342 2019-10-16 Tom de Vries <tdevries@suse.de>
343
344 PR tdep/25096
345 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
346 (amd64_classify_aggregate): ... here.
347 (amd64_classify_aggregate_field): Handled fiels of nested structs
348 recursively.
349
350 2019-10-16 Tom de Vries <tdevries@suse.de>
351
352 PR tdep/24104
353 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
354 that handles 'theclass'.
355
356 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
357
358 * linespec.c (decode_digits_ordinary): Update comment.
359 * make-target-delegates: No longer need to handle VEC case.
360 * memrange.c (normalize_mem_ranges): Update comment.
361 * namespace.c (add_using_directive): Update comment.
362 * objc-lang.c (uniquify_strings): Update comment.
363 * ppc-linux-nat.c (struct thread_points): Update comment.
364 * probe.h (find_probes_in_objfile): Update comment.
365 * target.h (enum flash_preserve_mode): Update comment.
366 * varobj.c (varobj_restrict_range): Update comment.
367 * varobj.h (varobj_list_children): Update comment.
368
369 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
370
371 * Makefile.in: Remove references to vec.h and vec.c.
372 * aarch64-tdep.c: No longer include vec.h.
373 * ada-lang.c: Likewise.
374 * ada-lang.h: Likewise.
375 * arm-tdep.c: Likewise.
376 * ax.h: Likewise.
377 * breakpoint.h: Likewise.
378 * charset.c: Likewise.
379 * cp-support.h: Likewise.
380 * dtrace-probe.c: Likewise.
381 * dwarf2read.c: Likewise.
382 * extension.h: Likewise.
383 * gdb_bfd.c: Likewise.
384 * gdbsupport/gdb_vecs.h: Likewise.
385 * gdbsupport/vec.c: Remove.
386 * gdbsupport/vec.h: Remove.
387 * gdbthread.h: Likewise.
388 * guile/scm-type.c: Likewise.
389 * inline-frame.c: Likewise.
390 * machoread.c: Likewise.
391 * memattr.c: Likewise.
392 * memrange.h: Likewise.
393 * namespace.h: Likewise.
394 * nat/linux-btrace.h: Likewise.
395 * osdata.c: Likewise.
396 * parser-defs.h: Likewise.
397 * progspace.h: Likewise.
398 * python/py-type.c: Likewise.
399 * record-btrace.c: Likewise.
400 * rust-exp.y: Likewise.
401 * solib-target.c: Likewise.
402 * stap-probe.c: Likewise.
403 * target-descriptions.c: Likewise.
404 * target-memory.c: Likewise.
405 * target.h: Likewise.
406 * varobj.c: Likewise.
407 * varobj.h: Likewise.
408 * xml-support.h: Likewise.
409
410 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
411
412 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
413 Update for new std::vector based implementation.
414 (process_psymtab_comp_unit_reader): Likewise.
415 (scan_partial_symbols): Likewise.
416 (recursively_compute_inclusions): Likewise.
417 (compute_compunit_symtab_includes): Likewise.
418 (process_imported_unit_die): Likewise.
419 (queue_and_load_dwo_tu): Likewise.
420 (follow_die_sig_1): Likewise.
421 * gdb/dwarf2read.h: Remove DEF_VEC_P.
422 (typedef dwarf2_per_cu_ptr): Remove.
423 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
424 function.
425 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
426 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
427 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
428 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
429 std::vector.
430
431 2019-10-15 Tom Tromey <tromey@adacore.com>
432
433 * windows-nat.c (windows_nat_target::resume): Use %x when logging
434 TID.
435
436 2019-10-15 Tom Tromey <tromey@adacore.com>
437
438 * windows-nat.c (windows_nat_target::fetch_registers)
439 (windows_nat_target::store_registers): Rename "pid" to "tid".
440
441 2019-10-15 Tom Tromey <tromey@adacore.com>
442
443 * gdbarch.h, gdbarch.c: Rebuild.
444 * gdbarch.sh (gcc_target_options): Change return type to
445 std::string.
446 * compile/compile.c (get_args): Update.
447 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
448 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
449 std::string.
450 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
451 std::string.
452 * arch-utils.c (default_gcc_target_options): Return std::string.
453 * arch-utils.h (default_gcc_target_options): Return std::string.
454 * s390-tdep.c (s390_gcc_target_options): Return std::string.
455
456 2019-10-15 Christian Biesinger <cbiesinger@google.com>
457
458 * breakpoint.c (breakpoint_chain): Make static.
459 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
460 of accessing breakpoint_chain.
461
462 2019-10-15 Christian Biesinger <cbiesinger@google.com>
463
464 * breakpoint.c (iterate_over_breakpoints): Change function pointer
465 to a gdb::function_view and return value to bool.
466 * breakpoint.h (iterate_over_breakpoints): Likewise.
467 * dummy-frame.c (pop_dummy_frame_bpt): Update.
468 (pop_dummy_frame): Update.
469 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
470 (gdbscm_breakpoints): Update.
471 * python/py-breakpoint.c (build_bp_list): Update.
472 (gdbpy_breakpoints): Update.
473 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
474 Update.
475 (bpfinishpy_handle_stop): Update.
476 (bpfinishpy_handle_exit): Update.
477 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
478 (svr4_update_solib_event_breakpoints): Update.
479
480 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
481
482 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
483 when unwrapping single-field structs.
484
485 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
486
487 * dwarf2read.c: Remove includes.
488
489 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
490
491 * ui-out.c (ui_out::call_do_message): Silence
492 -Wformat-nonliteral warning.
493
494 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
495
496 * breakpoint.c: Remove some includes: continuations.h, skip.h,
497 mi/mi-main.h, readline/readline.h, readline/history.h. Add
498 include: readline/tilde.h.
499
500 2019-10-12 Christian Biesinger <cbiesinger@google.com>
501
502 * remote.c (remote_target::get_trace_status): Remove declaration of
503 trace_regblock_size.
504
505 2019-10-12 Christian Biesinger <cbiesinger@google.com>
506
507 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
508 (show_user): Remove declaration of cmdlist.
509 * cli/cli-cmds.h (max_user_call_depth): Declare.
510 * cli/cli-script.c (execute_user_command): Remove declaration
511 of max_user_call_depth.
512
513 2019-10-11 Jim Wilson <jimw@sifive.com>
514
515 * gdbsupport/print-utils.h (pulongest): Fix comment.
516 (plongest): Likewise.
517 (phex): Add missing comment, mention leading zeros.
518 (phex_nz): Add mention of no leading zeros to comment.
519
520 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
521 plongest instead of unsigned long long cast.
522
523 2019-10-10 Christian Biesinger <cbiesinger@google.com>
524
525 * main.c (captured_main_1): Include gdbtk.h and remove declarations
526 for external_editor_command and gdbtk_test.
527
528 2019-10-10 Christian Biesinger <cbiesinger@google.com>
529
530 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
531 * varobj.c (varobjdebug): Move comment to...
532 * varobj.h (varobjdebug): ...here, and declare.
533
534 2019-10-09 Tom Tromey <tom@tromey.com>
535
536 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
537 erase_data_content.
538
539 2019-10-09 Tom Tromey <tom@tromey.com>
540
541 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
542 * tui/tui-stack.c (tui_locator_window::rerender): Update.
543 * tui/tui-command.c (tui_cmd_window::resize)
544 (tui_refresh_cmd_win): Update.
545 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
546 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
547 * tui/tui-data.c (~tui_gen_win_info): Remove.
548 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
549 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
550 (tui_redisplay_readline, tui_mld_flush)
551 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
552 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
553 (tui_data_window::erase_data_content)
554 (tui_data_item_window::rerender)
555 (tui_data_item_window::refresh_window): Update.
556 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
557 (box_win, tui_gen_win_info::make_window)
558 (tui_gen_win_info::make_visible): Update.
559 (tui_delete_win): Remove.
560 * tui/tui-winsource.c
561 (tui_source_window_base::do_erase_source_content): Update.
562 (tui_show_source_line, tui_source_window_base::update_tab_width)
563 (tui_source_window_base::update_exec_info): Update.
564 * tui/tui-data.h (struct curses_deleter): New.
565 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
566 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
567
568 2019-10-09 Tom Tromey <tom@tromey.com>
569
570 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
571
572 2019-10-09 Tom Tromey <tom@tromey.com>
573
574 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
575 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
576
577 2019-10-09 Tom Tromey <tom@tromey.com>
578
579 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
580 window height directly.
581 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
582 declare.
583 * tui/tui-layout.c (tui_default_win_height): Remove.
584 (tui_default_win_viewport_height): Remove.
585
586 2019-10-09 Tom Tromey <tom@tromey.com>
587
588 * tui/tui.h: Remove comments.
589
590 2019-10-09 Tom de Vries <tdevries@suse.de>
591
592 * python/lib/gdb/printer/bound_registers.py: Use
593 '^builtin_type_bound128' as regexp argument for
594 add_builtin_pretty_printer.
595
596 2019-10-09 Christian Biesinger <cbiesinger@google.com>
597
598 * guile/guile.c (guile_extension_script_ops): Remove forward
599 declaration and mark as static.
600 (guile_script_ops): Likewise.
601 (extension_language_guile): Move further down in the file so
602 it can reference the definitions for guile_{extension_,}script_ops.
603
604 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
605
606 * s390-tdep.c (390_process_record): Handle new arch13 instructions
607 except SORTL, DFLTCC, and KDSA.
608
609 2019-10-08 Tom Tromey <tromey@adacore.com>
610
611 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
612 (struct safe_symbol_file_add_args): Remove.
613
614 2019-10-08 Tom Tromey <tromey@adacore.com>
615
616 * windows-nat.c: Don't include buildsym-legacy.h.
617
618 2019-10-08 Tom Tromey <tromey@adacore.com>
619
620 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
621
622 2019-10-08 Christian Biesinger <cbiesinger@google.com>
623
624 * gdbtypes.c (overload_debug): Move comment to header.
625 * gdbtypes.h (overload_debug): Declare.
626 * valops.c: Remove declaration of overload_debug, instead
627 include gdbtypes.h.
628
629 2019-10-08 Christian Biesinger <cbiesinger@google.com>
630
631 * language.c (show_language_command): Pass lang_frame_mismatch_warn
632 through _().
633 (lang_frame_mismatch_warn): Make const, mark with N_(), and
634 move comment...
635 * language.h (lang_frame_mismatch_warn): ... here. Also add
636 declaration.
637 * top.c (lang_frame_mismatch_warn): Remove declaration.
638 (check_frame_language_change): Pass lang_frame_mismatch_warn
639 through _().
640
641 2019-10-07 Christian Biesinger <cbiesinger@google.com>
642
643 * c-lang.h (vtbl_ptr_name): Declare.
644 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
645 it from the header.
646 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
647
648 2019-10-07 Christian Biesinger <cbiesinger@google.com>
649
650 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
651 gdb_static_assert.
652
653 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
654
655 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
656 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
657 * ctfread.c: New file.
658 * ctfread.h: New file.
659 * elfread.c: Include ctfread.h.
660 (struct elfinfo text_p): New member ctfsect.
661 (elf_locate_sections): Mark CTF section.
662 (elf_symfile_read): Call elfctf_build_psymtabs.
663 * Makefile.in (LIBCTF): Add.
664 (CLIBS): Use it.
665 (CDEPS): Likewise.
666 (DIST): Add ctfread.c.
667
668 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
669
670 * ctfread.c (struct nextfield): Renamed to ...
671 (struct ctf_nextfield): ... this.
672 (struct field_info): Renamed to ...
673 (strut ctf_field_info): ... this.
674 (attach_fields_to_type): Update for renamed structures.
675 (ctf_add_member_cb): Likewise.
676 (ctf_add_enum_member_cb): Likewise.
677 (process_struct_members): Likewise.
678 (process_enum_type): Likewise.
679
680 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
681
682 * tracectf.h: Rename, was ctf.h.
683 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
684 * tracefile.c: Likewise.
685 * tracepoint.c: Remove unused include ctf.h.
686 * mi/mi-main.c: Likewise.
687 * Makefile.in Replace ctf.c with tracectf.c.
688
689 2019-10-06 Joel Brobecker <brobecker@adacore.com>
690
691 * version.in: Change version number to "9.0.50.DATE-git".
692
693 2019-10-03 Tom Tromey <tom@tromey.com>
694
695 PR rust/24976:
696 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
697
698 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
699
700 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
701 cp_search_name_hash.
702 * NEWS: Add entry about nested function support.
703
704 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
705 Andrew Burgess <andrew.burgess@embecosm.com>
706
707 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
708 for nested static variables when searchin VAR_DOMAIN.
709 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
710 global scope, update comment.
711 (add_partial_subprogram): Call add_partial_subprogram recursively
712 for nested subroutines when processinng Fortran.
713 (load_partial_dies): Process the child entities of a subprogram
714 when processing Fortran.
715 (partial_die_parent_scope): Handle building scope
716 for Fortran nested functions.
717 (process_die): Record that nested functions have a scope.
718 (new_symbol): Always record Fortran subprograms on the global
719 symbol list.
720 (determine_prefix): How to build the prefix for Fortran
721 subprograms.
722
723 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
724
725 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
726 have just sent the thread a SIGSTOP and are waiting for it to
727 arrive.
728
729 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
730
731 * btrace.c (btrace_add_pc): Remove whitespace before the template
732 parameter in 'std::vector <...>'.
733 (parse_xml_btrace_block): Likewise.
734 (btrace_maint_decode_pt): Likewise.
735 (btrace_maint_update_packets): Likewise.
736 (btrace_maint_print_packets): Likewise.
737 * btrace.h (struct btrace_maint_info): Likewise.
738 * dwarf2read.c (struct type_unit_group): Likewise.
739 (build_type_psymtabs_reader): Likewise.
740 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
741 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
742 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
743
744 2019-10-03 Tom de Vries <tdevries@suse.de>
745
746 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
747 the first line of the help text for set/show style metadata.
748
749 2019-10-02 Tom Tromey <tromey@adacore.com>
750
751 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
752 * gdbsupport/common-inferior.c: New file.
753 * infcmd.c (startup_with_shell): Don't define.
754 * nat/fork-inferior.h (startup_with_shell): Don't declare.
755 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
756 * inferior.h (startup_with_shell): Don't declare.
757
758 2019-10-02 Christian Biesinger <cbiesinger@google.com>
759
760 * gdbsupport/gdb_assert.h: Include errors.h.
761 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
762
763 2019-10-02 Tom Tromey <tromey@adacore.com>
764
765 * NEWS: Add $_ada_exception entry.
766 * ada-lang.c (struct ada_catchpoint): Add constructor.
767 <m_kind>: New member.
768 (allocate_location_exception, re_set_exception): Remove
769 "ex" parameter.
770 (should_stop_exception): Compute $_ada_exception.
771 (check_status_exception, print_it_exception)
772 (print_one_exception, print_mention_exception): Remove
773 "ex" parameter.
774 (allocate_location_catch_exception, re_set_catch_exception)
775 (check_status_exception, print_it_catch_exception)
776 (print_one_catch_exception, print_mention_catch_exception)
777 (print_recreate_catch_exception)
778 (allocate_location_catch_exception_unhandled)
779 (re_set_catch_exception_unhandled)
780 (check_status_exception, print_it_catch_exception_unhandled)
781 (print_one_catch_exception_unhandled)
782 (print_mention_catch_exception_unhandled)
783 (print_recreate_catch_exception_unhandled)
784 (allocate_location_catch_assert, re_set_catch_assert)
785 (check_status_assert, print_it_catch_assert)
786 (print_one_catch_assert, print_mention_catch_assert)
787 (print_recreate_catch_assert)
788 (allocate_location_catch_handlers, re_set_catch_handlers)
789 (check_status_handlers, print_it_catch_handlers)
790 (print_one_catch_handlers, print_mention_catch_handlers)
791 (print_recreate_catch_handlers): Remove.
792 (create_ada_exception_catchpoint): Update.
793 (initialize_ada_catchpoint_ops): Update.
794
795 2019-10-02 Tom Tromey <tromey@adacore.com>
796
797 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
798 (create_excep_cond_exprs): Simplify exception string computation.
799 (ada_exception_catchpoint_cond_string): Likewise.
800
801 2019-10-02 Tom Tromey <tromey@adacore.com>
802
803 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
804 * ada-lang.c (lesseq_defined_than): Handle
805 LOC_STATIC.
806 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
807 parameter.
808 (dwarf2_has_info): Likewise.
809 (new_symbol): Set maybe_copied on symbol when
810 appropriate.
811 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
812 parameter.
813 <can_copy>: New member.
814 * elfread.c (record_minimal_symbol): Set maybe_copied
815 on symbol when appropriate.
816 (elf_symfile_read): Update call to dwarf2_has_info.
817 * minsyms.c (lookup_minimal_symbol_linkage): New
818 function.
819 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
820 * symtab.c (get_symbol_address, get_msymbol_address):
821 New functions.
822 * symtab.h (get_symbol_address, get_msymbol_address):
823 Declare.
824 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
825 maybe_copied.
826 (struct symbol, struct minimal_symbol) <maybe_copied>:
827 New member.
828
829 2019-10-02 Tom Tromey <tromey@adacore.com>
830
831 * source.c (struct current_source_location): New.
832 (current_source_key): New global.
833 (current_source_symtab, current_source_line)
834 (current_source_pspace): Remove.
835 (get_source_location): New function.
836 (get_current_source_symtab_and_line)
837 (set_default_source_symtab_and_line)
838 (set_current_source_symtab_and_line)
839 (clear_current_source_symtab_and_line, select_source_symtab)
840 (info_source_command, print_source_lines_base)
841 (info_line_command, search_command_helper, _initialize_source):
842 Update.
843
844 2019-10-02 Tom Tromey <tromey@adacore.com>
845
846 * source.c (select_source_symtab): Don't call
847 decode_line_with_current_source.
848
849 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
850
851 * symtab.c (lookup_global_symbol): Search global block.
852
853 2019-10-02 Tom Tromey <tromey@adacore.com>
854
855 * coffread.c (process_coff_symbol): Update.
856 * dwarf2read.c (var_decode_location, new_symbol): Update.
857 * mdebugread.c (parse_symbol): Update.
858 * objfiles.c (relocate_one_symbol): Update.
859 * stabsread.c (define_symbol, fix_common_block)
860 (scan_file_globals): Update.
861 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
862 (SET_SYMBOL_VALUE_ADDRESS): New macro.
863 * xcoffread.c (process_xcoff_symbol): Update.
864
865 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
866
867 * MAINTAINERS: Update my email address.
868
869 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
870
871 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
872 std::vector.
873 (build_type_psymtabs_reader): Update for std::vector.
874 (build_type_psymtab_dependencies): Likewise.
875 * dwarf2read.h: Remove use of DEF_VEC_P.
876 (typedef sig_type_ptr): Delete.
877
878 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
879
880 * btrace.c (btrace_maint_clear): Update to handle change from VEC
881 to std::vector.
882 (btrace_maint_decode_pt): Likewise, and move allocation of the
883 vector outside of the loop.
884 (btrace_maint_update_packets): Update to handle change from VEC to
885 std::vector.
886 (btrace_maint_print_packets): Likewise.
887 (maint_info_btrace_cmd): Likewise.
888 * btrace.h: Remove use of DEF_VEC_O.
889 (typedef btrace_pt_packet_s): Delete.
890 (struct btrace_maint_info) <packets>: Change fromm VEC to
891 std::vector.
892 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
893
894 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
895
896 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
897 make accesses into the vector constant references.
898 (btrace_add_pc): Update for std::vector.
899 (btrace_stitch_bts): Likewise.
900 (parse_xml_btrace_block): Likewise.
901 (btrace_maint_update_packets): Likewise.
902 (btrace_maint_print_packets): Likewise.
903 (maint_info_btrace_cmd): Likewise.
904 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
905 std::vector.
906 (btrace_data::empty): Likewise.
907 (btrace_data_append): Likewise.
908 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
909 (typedef btrace_block_s): Delete.
910 (struct btrace_block): Add constructor.
911 (struct btrace_data_bts) <blocks>: Change to std::vector.
912 * nat/linux-btrace.c (perf_event_read_bts): Update for
913 std::vector.
914 (linux_read_bts): Likewise.
915
916 2019-10-01 Tom Tromey <tom@tromey.com>
917
918 * cli/cli-logging.c (show_logging_filename): Use styled_string.
919
920 2019-10-01 Tom Tromey <tom@tromey.com>
921
922 * stack.c (print_frame, info_frame_command_core): Use
923 styled_string.
924 * linux-thread-db.c (try_thread_db_load_1)
925 (try_thread_db_load_from_pdir_1): Use styled_string.
926 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
927 (auto_load_section_scripts, info_auto_load_local_gdbinit)
928 (maybe_print_unsupported_script_warning)
929 (maybe_print_script_not_found_warning): Use styled_string.
930 * ada-lang.c (user_select_syms): Use styled_string.
931
932 2019-10-01 Tom Tromey <tom@tromey.com>
933
934 * p-lang.c (pascal_printstr): Use metadata style.
935 * value.c (show_convenience): Use metadata style.
936 * valprint.c (valprint_check_validity, val_print_optimized_out)
937 (val_print_not_saved, val_print_unavailable)
938 (val_print_invalid_address, generic_val_print, val_print)
939 (value_check_printable, val_print_array_elements): Use metadata
940 style.
941 * ui-out.h (class ui_out) <field_fmt>: New overload.
942 <do_field_fmt>: Add style parameter.
943 * ui-out.c (ui_out::field_fmt): New overload.
944 * typeprint.c (type_print_unknown_return_type)
945 (val_print_not_allocated, val_print_not_associated): Use metadata
946 style.
947 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
948 parameter.
949 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
950 * tracepoint.c (tvariables_info_1): Use metadata style.
951 * stack.c (print_frame_arg, print_frame_info, print_frame)
952 (info_frame_command_core): Use metadata style.
953 * skip.c (info_skip_command): Use metadata style.
954 * rust-lang.c (rust_print_enum): Use metadata style.
955 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
956 metadata style.
957 * python/py-framefilter.c (py_print_single_arg): Use metadata
958 style.
959 * printcmd.c (do_one_display, print_variable_and_value): Use
960 metadata style.
961 * p-valprint.c (pascal_val_print)
962 (pascal_object_print_value_fields): Use metadata style.
963 * p-typeprint.c (pascal_type_print_base): Use metadata style.
964 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
965 parameter.
966 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
967 * m2-valprint.c (m2_print_long_set): Use metadata style.
968 * m2-typeprint.c (m2_print_type): Use metadata style.
969 * infcmd.c (print_return_value_1): Use metadata style.
970 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
971 * f-valprint.c (info_common_command_for_block): Use metadata
972 style.
973 * f-typeprint.c (f_type_print_base): Use metadata style.
974 * expprint.c (print_subexp_standard): Use metadata style.
975 * cp-valprint.c (cp_print_value_fields): Use metadata style.
976 * cli/cli-style.h (class cli_style_option): Add constructor.
977 (metadata_style): Declare.
978 * cli/cli-style.c (metadata_style): New global.
979 (_initialize_cli_style): Register metadata style.
980 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
981 parameter.
982 * cli-out.c (cli_ui_out::do_field_fmt): Update.
983 * c-typeprint.c (c_type_print_base_struct_union)
984 (c_type_print_base_1): Use metadata style.
985 * breakpoint.c (watchpoint_value_print)
986 (print_one_breakpoint_location): Use metadata style.
987 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
988 style.
989 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
990 style.
991 * ada-valprint.c (val_print_packed_array_elements, printstr)
992 (print_field_values, ada_val_print_ref, ada_val_print): Use
993 metadata style.
994 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
995 style.
996 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
997 style.
998 * ada-lang.c (user_select_syms): Use metadata style.
999
1000 2019-10-01 Tom Tromey <tom@tromey.com>
1001
1002 * cli/cli-cmds.c (pwd_command): Style output.
1003
1004 2019-10-01 Pedro Alves <palves@redhat.com>
1005 Tom Tromey <tom@tromey.com>
1006
1007 * symtab.c (print_symbol_info): Use %ps.
1008 (print_msymbol_info): Use %ps.
1009 * symfile.c (symbol_file_add_with_addrs): Use %ps.
1010 * printcmd.c (print_variable_and_value): Use %ps.
1011 * macrocmd.c (show_pp_source_pos): Use %ps.
1012 * infrun.c (print_exited_reason): Use ui_out::message.
1013 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1014 (describe_other_breakpoints): Use ui_out::message and new
1015 formats.
1016 (say_where): Use new formats.
1017 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1018 and new formats.
1019
1020 2019-10-01 Pedro Alves <palves@redhat.com>
1021 Tom Tromey <tom@tromey.com>
1022
1023 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1024 (test_gdb_formats): New function.
1025 (run_tests): Call it.
1026 (test_format_specifier): Update.
1027 * utils.h (fputs_filtered): Update comment.
1028 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1029 (fputs_styled_unfiltered): Declare.
1030 * utils.c (fputs_styled_unfiltered): New function.
1031 (vfprintf_maybe_filtered): Add gdbfmt parameter.
1032 (vfprintf_filtered): Update.
1033 (vfprintf_unfiltered, vprintf_filtered): Update.
1034 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1035 * ui-out.h (enum ui_out_flag) <unfiltered_output,
1036 disallow_ui_out_field>: New constants.
1037 (enum class field_kind): New.
1038 (struct base_field_s, struct signed_field_s): New.
1039 (signed_field): New function.
1040 (struct string_field_s): New.
1041 (string_field): New function.
1042 (struct styled_string_s): New.
1043 (styled_string): New function.
1044 (class ui_out) <message>: Add comment.
1045 <vmessage, call_do_message>: New methods.
1046 <do_message>: Add style parameter.
1047 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1048 methods.
1049 (ui_out::message): Rewrite.
1050 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1051 parameter.
1052 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1053 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1054 gdb_extensions parameter.
1055 (class format_piece): Add parameter to constructor.
1056 (n_int_args): New field.
1057 * gdbsupport/format.c (format_pieces::format_pieces): Add
1058 gdb_extensions parameter. Handle '*'.
1059 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1060 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
1061 vfprintf_styled_no_gdbfmt.
1062 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1063 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1064 unfiltered output.
1065 * ui-style.h (struct ui_file_style) <ptr>: New method.
1066
1067 2019-10-01 Tom Tromey <tom@tromey.com>
1068
1069 * unittests/format_pieces-selftests.c: Update. Add final format.
1070 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1071 empty literal pieces.
1072
1073 2019-10-01 Tom Tromey <tom@tromey.com>
1074
1075 * ui-out.h (enum class ui_out_style_kind): Remove.
1076 (class ui_out) <field_string, field_stsream, do_field_string>:
1077 Change type of "style".
1078 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1079 (ui_out::field_string): Update.
1080 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1081 of "style".
1082 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1083 * tracepoint.c (print_one_static_tracepoint_marker): Update.
1084 * stack.c (print_frame_arg, print_frame_info, print_frame):
1085 Update.
1086 * source.c (print_source_lines_base): Update.
1087 * solib.c (info_sharedlibrary_command): Update.
1088 * skip.c (info_skip_command): Update.
1089 * record-btrace.c (btrace_call_history_src_line)
1090 (btrace_call_history): Update.
1091 * python/py-framefilter.c (py_print_frame): Update.
1092 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1093 "style".
1094 * mi/mi-out.c (mi_ui_out::do_table_header)
1095 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1096 (mi_ui_out::do_field_string): Update.
1097 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1098 Update.
1099 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1100 "style".
1101 * cli-out.c (cli_ui_out::do_table_header)
1102 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1103 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1104 (cli_ui_out::do_field_fmt): Update.
1105 * breakpoint.c (print_breakpoint_location): Update.
1106 (update_static_tracepoint): Update.
1107
1108 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1109
1110 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1111 conversion of gdb_datadir.
1112 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1113 remove not needed c_str ().
1114
1115 2019-09-30 Ali Tamur <tamur@google.com>
1116
1117 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1118 (dwarf2_string_attr): Likewise.
1119
1120 2019-09-30 Ali Tamur <tamur@google.com>
1121
1122 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1123 (process_full_type_unit): Likewise.
1124 (dump_die_shallow): Likewise.
1125 (cu_debug_loc_section): Likewise.
1126
1127 2019-09-28 Christian Biesinger <cbiesinger@google.com>
1128
1129 * minsyms.c (compare_minimal_symbols): Rename to...
1130 (minimal_symbol_is_less_than): ...this, and adjust to STL
1131 conventions (return bool, take arguments as references)
1132 (minimal_symbol_reader::install): Call std::sort instead
1133 of qsort.
1134
1135 2019-09-29 Christian Biesinger <cbiesinger@google.com>
1136
1137 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1138 hash and why.
1139 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1140 msymbol_hash, msymbol_demangled_hash>: Improve comments.
1141
1142 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
1143
1144 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1145 * psympriv.h (add_psymbol_to_list): Move comment here and update
1146 it.
1147
1148 2019-09-29 Tom de Vries <tdevries@suse.de>
1149
1150 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1151 Use $tmpdir/$(basename "$output_file").dwz instead of
1152 "${output_file}.dwz".
1153
1154 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
1155
1156 PR gdb/25045
1157 * hppa-linux-nat.c: Include gdbarch.h.
1158
1159 2019-09-26 Christian Biesinger <cbiesinger@google.com>
1160
1161 * blockframe.c (find_pc_partial_function): Change return type to bool.
1162 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1163 * minsyms.c (in_gnu_ifunc_stub): Likewise.
1164 (stub_gnu_ifunc_resolve_name): Likewise.
1165 * symtab.c (compare_filenames_for_search): Likewise.
1166 (compare_glob_filenames_for_search): Likewise.
1167 (matching_obj_sections): Likewise.
1168 (symbol_matches_domain): Likewise.
1169 (find_line_symtab): Change out param EXACT_MATCH to bool *.
1170 (find_line_pc): Change return type to bool.
1171 (find_line_pc_range): Likewise.
1172 (producer_is_realview): Likewise.
1173 * symtab.h (symbol_matches_domain): Likewise.
1174 (find_pc_partial_function): Likewise.
1175 (find_pc_line_pc_range): Likewise.
1176 (in_gnu_ifunc_stub): Likewise.
1177 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1178 (find_line_pc): Likewise.
1179 (find_line_pc_range): Likewise.
1180 (matching_obj_sections): Likewise.
1181 (find_line_symtab): Change out parameter to bool.
1182 (producer_is_realview): Change return type to bool.
1183 (compare_filenames_for_search): Likewise.
1184 (compare_glob_filenames_for_search): Likewise.
1185
1186 2019-09-26 Tom Tromey <tom@tromey.com>
1187
1188 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1189 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1190 * gdb_usleep.h: Remove.
1191 * gdb_usleep.c: Remove.
1192 * utils.c: Don't include gdb_usleep.h.
1193
1194 2019-09-26 Tom Tromey <tromey@adacore.com>
1195
1196 * python/py-type.c (type_to_type_object): Call check_typedef
1197 for stub types.
1198
1199 2019-09-26 Tom Tromey <tom@tromey.com>
1200
1201 * utils.h (initialize_utils): Don't declare.
1202 * top.c (gdb_init): Don't call initialize_utils.
1203 * utils.c (initialize_utils): Remove. Move contents...
1204 (_initialize_utils): ... here.
1205
1206 2019-09-25 Tom Tromey <tom@tromey.com>
1207
1208 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1209 * utils.h (make_hex_string): Don't declare.
1210 * utils.c (make_hex_string): Remove.
1211
1212 2019-09-24 Tom de Vries <tdevries@suse.de>
1213
1214 PR gdb/23815
1215 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1216 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1217
1218 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
1219
1220 * NEWS: Mention new simulator port for PRU.
1221
1222 2019-09-23 Christian Biesinger <cbiesinger@google.com>
1223
1224 * ada-exp.y (write_object_remaining): Update.
1225 * ada-lang.c (ada_decode): Return a std::string instead of a char*
1226 and eliminate the static buffer.
1227 (ada_decode_symbol): Update.
1228 (ada_la_decode): Update.
1229 (ada_sniff_from_mangled_name): Update.
1230 (is_valid_name_for_wild_match): Update.
1231 (ada_lookup_name_info::matches): Update and simplify.
1232 (name_matches_regex): Update.
1233 (ada_add_global_exceptions): Update.
1234 * ada-lang.h (ada_decode): Update signature.
1235 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1236 * dwarf-index-write.c (debug_names::insert): Update.
1237
1238 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1239
1240 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1241 formatting.
1242
1243 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
1244
1245 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1246 Change "nonzero" to "true" in documentation.
1247
1248 2019-09-20 Christian Biesinger <cbiesinger@google.com>
1249
1250 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1251 (_initialize_darwin_solib): Don't set
1252 darwin_so_ops.lookup_lib_global_symbol.
1253 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1254 set_gdbarch_iterate_over_objfiles_in_search_order.
1255 (elf_lookup_lib_symbol): Rename to...
1256 (svr4_iterate_over_objfiles_in_search_order): this, and update
1257 to iterate semantics.
1258 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1259 * solib.c (solib_global_lookup): Remove.
1260 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1261 (solib_global_lookup): Remove.
1262 * symtab.c (lookup_global_or_static_symbol): Remove call to
1263 solib_global_lookup.
1264
1265 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1266
1267 * NEWS: Move entries about default MI version now being
1268 version 3, and about the GDB/MI fix for multi-location
1269 breakpoints to the "since GDB 8.3" section.
1270
1271 2019-09-20 Joel Brobecker <brobecker@adacore.com>
1272
1273 GDB 8.3.1 released.
1274
1275 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
1276
1277 * NEWS: Mention that Cell/B.E. debugging support was removed.
1278 * MAINTAINERS: Remove spu target.
1279
1280 * config/djgpp/fnchange.lst: Remove entries for removed files.
1281
1282 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1283 spu-multiarch.o, and spu-tdep.o.
1284 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1285 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1286 spu-multiarch.c, and spu-tdep.c.
1287 * spu-linux-nat.c: Remove file.
1288 * spu-multiarch.c: Remove file.
1289 * spu-tdep.c: Remove file.
1290 * spu-tdep.h: Remove file.
1291 * solib-spu.c: Remove file.
1292 * solib-spu.h: Remove file.
1293
1294 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1295 * configure.nat (spu-linux): Remove.
1296 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1297 solib-multiarch.o from gdb_target_obs.
1298 (spu*-*-*): Remove.
1299
1300 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1301 feature flag.
1302 (ppc_linux_no_features): Update.
1303 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1304 Cell/B.E. support.
1305 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1306 (tdesc_powerpc_cell64l): Likewise.
1307 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1308 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1309 Cell/B.E. support.
1310 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1311 Do not include "features/rs6000/powerpc-cell32l.c" or
1312 "features/rs6000/powerpc-cell64l.c".
1313 (ppc_linux_spu_section): Remove.
1314 (ppc_linux_core_read_description): Remove Cell/B.E. support.
1315 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1316 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1317 (ppc_linux_spe_context_lookup): Remove.
1318 (ppc_linux_spe_context_inferior_created): Remove.
1319 (ppc_linux_spe_context_solib_loaded): Remove.
1320 (ppc_linux_spe_context_solib_unloaded): Remove.
1321 (ppc_linux_spe_context): Remove.
1322 (struct ppu2spu_cache): Remove.
1323 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1324 (struct ppu2spu_data): Remove.
1325 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1326 ppu2spu_unwind): Remove.
1327 (ppc_linux_init_abi): Remove Cell/B.E. support.
1328 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1329
1330 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1331 (rs6000/powerpc-cell64l-expedite): Likewise
1332 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1333 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1334 rs6000/powerpc-cell64l.xml.
1335 * features/rs6000/powerpc-cell32l.xml: Remove.
1336 * features/rs6000/powerpc-cell64l.xml: Likewise.
1337 * features/rs6000/powerpc-cell32l.c: Remove generated file.
1338 * features/rs6000/powerpc-cell64l.c: Likewise.
1339 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1340 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1341 * regformats/reg-spu.dat: Remove.
1342
1343 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1344 * corelow.c (struct spuid_list): Remove.
1345 (add_to_spuid_list): Remove.
1346 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1347 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1348 (remote_protocol_features): Remove associated entries.
1349 (_initialize_remote): No longer initialize them.
1350 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1351 * linux-nat.c (SPUFS_MAGIC): Remove.
1352 (linux_proc_xfer_spu): Remove.
1353 (spu_enumerate_spu_ids): Remove.
1354 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1355 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1356 (linux_make_corefile_notes): No longer call it.
1357
1358 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1359 (cooked_write_test): Likewise.
1360
1361 2019-09-20 Tom Tromey <tom@tromey.com>
1362
1363 * NEWS: Mention case-sensitivity of TUI commands.
1364 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1365 (tui_set_win_height_command, parse_scrolling_args): Likewise.
1366 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1367
1368 2019-09-20 Tom Tromey <tom@tromey.com>
1369
1370 * tui/tui-source.c (tui_source_window::set_contents): Use
1371 make_unique_xstrdup.
1372 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1373 make_unique_xstrdup.
1374
1375 2019-09-20 Tom Tromey <tom@tromey.com>
1376
1377 * tui/tui-data.c: Remove separator comments.
1378 * tui/tui-layout.c: Remove separator comments.
1379 * tui/tui-win.c: Remove separator comments.
1380 * tui/tui-wingeneral.c: Remove separator comments.
1381
1382 2019-09-20 Tom Tromey <tom@tromey.com>
1383
1384 * tui/tui.h (strcat_to_buf): Don't declare.
1385 * tui/tui.c (strcat_to_buf): Remove.
1386
1387 2019-09-20 Tom Tromey <tom@tromey.com>
1388
1389 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1390 from "fullname".
1391 * tui/tui-source.c (tui_source_window::set_contents)
1392 (tui_source_window::location_matches_p)
1393 (tui_source_window::maybe_update): Update.
1394
1395 2019-09-20 Tom Tromey <tom@tromey.com>
1396
1397 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1398 Update.
1399 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1400 prefix.
1401 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1402 (tui_data_window::line_from_reg_element_no)
1403 (tui_data_window::first_reg_element_no_inline)
1404 (tui_data_window::show_registers)
1405 (tui_data_window::show_register_group)
1406 (tui_data_window::display_registers_from)
1407 (tui_data_window::display_registers_from_line)
1408 (tui_data_window::first_data_item_displayed)
1409 (tui_data_window::delete_data_content_windows)
1410 (tui_data_window::erase_data_content)
1411 (tui_data_window::do_scroll_vertical)
1412 (tui_data_window::refresh_window)
1413 (tui_data_window::check_register_values): Update.
1414
1415 2019-09-20 Tom Tromey <tom@tromey.com>
1416
1417 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1418 (struct tui_locator_window) <full_name, proc_name>: Now
1419 std::string.
1420 * tui/tui-stack.c (tui_locator_window::make_status_line)
1421 (tui_locator_window::set_locator_fullname)
1422 (tui_locator_window::set_locator_info): Update.
1423 * tui/tui-source.c (tui_source_window::set_contents)
1424 (tui_source_window::showing_source_p): Update.
1425
1426 2019-09-20 Tom Tromey <tom@tromey.com>
1427
1428 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1429 Don't call tui_locator_win_info_ptr.
1430
1431 2019-09-20 Tom Tromey <tom@tromey.com>
1432
1433 * tui/tui-win.c (tui_resize_all): Don't call refresh.
1434
1435 2019-09-20 Tom Tromey <tom@tromey.com>
1436
1437 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1438 height for locator.
1439 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1440 * tui/tui-layout.c (show_source_disasm_command, show_data)
1441 (show_source_or_disasm_and_command): Use 1 as height for locator.
1442
1443 2019-09-20 Tom Tromey <tom@tromey.com>
1444
1445 * tui/tui.c (tui_enable): Update.
1446 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1447 Update.
1448 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1449 Update.
1450 * tui/tui-data.c (win_resized): Now bool.
1451 (tui_win_resized): Return bool.
1452 (tui_set_win_resized_to): Accept a bool.
1453
1454 2019-09-20 Tom Tromey <tom@tromey.com>
1455
1456 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1457 Change type of "refresh_values_only".
1458 * tui/tui-regs.c (tui_data_window::show_register_group): Change
1459 type of "refresh_values_only".
1460
1461 2019-09-20 Tom Tromey <tom@tromey.com>
1462
1463 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1464 std::string.
1465 (tui_disassemble): Add "pos" parameter.
1466 (tui_disasm_window::set_contents): Simplify.
1467
1468 2019-09-20 Tom Tromey <tom@tromey.com>
1469
1470 * tui/tui-winsource.h (struct tui_source_window_base)
1471 <show_source_content>: Now private.
1472 * tui/tui-winsource.c
1473 (tui_source_window_base::show_source_content): Don't handle empty
1474 content case.
1475
1476 2019-09-20 Tom Tromey <tom@tromey.com>
1477
1478 * tui/tui-layout.c (show_source_disasm_command)
1479 (show_source_or_disasm_and_command): Don't call
1480 show_source_content.
1481
1482 2019-09-20 Tom Tromey <tom@tromey.com>
1483
1484 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1485 Declare.
1486 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1487 from tui_make_status_line.
1488 (tui_locator_window::rerender): Update.
1489
1490 2019-09-20 Tom Tromey <tom@tromey.com>
1491
1492 * tui/tui-stack.c (tui_make_status_line): Return std::string.
1493 (tui_locator_window::rerender): Update.
1494
1495 2019-09-20 Tom Tromey <tom@tromey.com>
1496
1497 * tui/tui-winsource.h (struct tui_source_window_base)
1498 <~tui_source_window_base>: Don't declare.
1499 <fullname>: Remove.
1500 * tui/tui-winsource.c (~tui_source_window_base): Remove.
1501 * tui/tui-source.h (struct tui_source_window) <fullname>: New
1502 member.
1503 * tui/tui-source.c (tui_source_window::set_contents): Update.
1504 (tui_source_window::location_matches_p)
1505 (tui_source_window::maybe_update): Update.
1506
1507 2019-09-20 Tom Tromey <tom@tromey.com>
1508
1509 * tui/tui-winsource.h (~tui_source_element): Remove.
1510 (tui_source_element): Update.
1511 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1512 * tui/tui-winsource.c (tui_show_source_line): Update.
1513 * tui/tui-source.c (tui_source_window::set_contents): Update.
1514 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1515
1516 2019-09-20 Tom Tromey <tom@tromey.com>
1517
1518 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1519 declare.
1520 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1521 tui_clear_source_windows_detail.
1522 * tui/tui-winsource.h (struct tui_source_window_base)
1523 <clear_detail>: Don't declare.
1524 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1525 Remove.
1526 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1527
1528 2019-09-20 Tom Tromey <tromey@adacore.com>
1529
1530 PR ada/24919:
1531 * block.c (contained_in): Fix final return value.
1532
1533 2019-09-20 Alan Modra <amodra@gmail.com>
1534
1535 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1536 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1537 (read_indirect_string_from_dwz): Use bfd accessor.
1538 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1539 * machoread.c (macho_symfile_read_all_oso): Likewise.
1540 * solib.c (solib_bfd_open): Likewise.
1541
1542 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1543
1544 * eval.c: Move declaration of overload_resolution to...
1545 * value.h: ...here.
1546
1547 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1548
1549 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1550 * arm-linux-tdep.c: Likewise.
1551 * arm-nbsd-nat.c: Likewise.
1552 * arm-tdep.h: Declare arm_apcs_32.
1553 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1554
1555 2019-09-19 Christian Biesinger <cbiesinger@google.com>
1556
1557 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1558 * dwarf2read.h: Declare dwarf_always_disassemble.
1559
1560 2019-09-19 Tom de Vries <tdevries@suse.de>
1561
1562 PR gdb/25009
1563 * source-cache.c (source_cache::ensure): Catch exception thrown during
1564 construction of the highlighter.
1565
1566 2019-09-18 Alan Modra <amodra@gmail.com>
1567
1568 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1569 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1570 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1571 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1572 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1573 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1574 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1575 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1576 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1577 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1578 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1579 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1580 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1581 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1582 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1583 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1584 * mi/mi-interp.c: Update throughout for bfd section macro and
1585 function changes.
1586 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1587 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1588
1589 2019-09-18 Tom Tromey <tom@tromey.com>
1590
1591 * NEWS: Add entry.
1592 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1593 call rl_initialize.
1594 (tui_enable): Do not call rl_initialize.
1595
1596 2019-09-18 Christian Groessler <chris@groessler.org>
1597
1598 * alpha-linux-nat.c: Include gdbarch.h.
1599
1600 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1601
1602 * ui-file.c: Include cli/cli-style.h.
1603 (term_cli_styling): Remove cli_styling declaration.
1604
1605 2019-09-18 Alan Modra <amodra@gmail.com>
1606
1607 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1608 to bfd_asymbol_section.
1609
1610 2019-09-18 Alan Modra <amodra@gmail.com>
1611
1612 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1613 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1614 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1615
1616 2019-09-18 Alan Modra <amodra@gmail.com>
1617
1618 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1619 * spu-linux-nat.c (spu_bfd_open): Likewise.
1620
1621 2019-09-18 Christian Biesinger <cbiesinger@google.com>
1622
1623 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1624 to bool to match definition in dwarf2read.c.
1625
1626 2019-09-17 Christian Biesinger <cbiesinger@google.com>
1627
1628 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1629 (print_signatures): Likewise.
1630 (trust_pad_over_xvs): Likewise.
1631 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1632 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1633 * arm-linux-nat.c (arm_apcs_32): Likewise.
1634 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1635 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1636 * arm-tdep.c (arm_debug): Likewise.
1637 (arm_apcs_32): Likewise.
1638 * auto-load.c (debug_auto_load): Likewise.
1639 (auto_load_gdb_scripts): Likewise.
1640 (global_auto_load): Likewise.
1641 (auto_load_local_gdbinit): Likewise.
1642 (auto_load_local_gdbinit_loaded): Likewise.
1643 * auto-load.h (global_auto_load): Likewise.
1644 (auto_load_local_gdbinit): Likewise.
1645 (auto_load_local_gdbinit_loaded): Likewise.
1646 * breakpoint.c (disconnected_dprintf): Likewise.
1647 (breakpoint_proceeded): Likewise.
1648 (automatic_hardware_breakpoints): Likewise.
1649 (always_inserted_mode): Likewise.
1650 (target_exact_watchpoints): Likewise.
1651 (_initialize_breakpoint): Update.
1652 * breakpoint.h (target_exact_watchpoints): Change to bool.
1653 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1654 * cli/cli-cmds.c (trace_commands): Likewise.
1655 * cli/cli-cmds.h (trace_commands): Likewise.
1656 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1657 to bool*.
1658 * cli/cli-logging.c (logging_overwrite): Change to bool.
1659 (logging_redirect): Likewise.
1660 (debug_redirect): Likewise.
1661 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1662 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1663 to bool.
1664 <boolean_option_def>: Update.
1665 (struct flag_option_def): Change default type of Context to bool
1666 from int.
1667 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1668 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1669 (get_setshow_command_value_string): Likewise.
1670 * cli/cli-style.c (cli_styling): Change to bool.
1671 (source_styling): Likewise.
1672 * cli/cli-style.h (source_styling): Likewise.
1673 (cli_styling): Likewise.
1674 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1675 to bool.
1676 * command.h (var_types): Update comment.
1677 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1678 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1679 bool.
1680 (debug_compile_cplus_scopes): Likewise.
1681 * compile/compile-internal.h (compile_debug): Likewise.
1682 * compile/compile.c (compile_debug): Likewise.
1683 (struct compile_options) <raw>: Likewise.
1684 * cp-support.c (catch_demangler_crashes): Likewise.
1685 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1686 (usr_cmd_cris_dwarf2_cfi): Likewise.
1687 * csky-tdep.c (csky_debug): Likewise.
1688 * darwin-nat.c (enable_mach_exceptions): Likewise.
1689 * dcache.c (dcache_enabled_p): Likewise.
1690 * defs.h (info_verbose): Likewise.
1691 * demangle.c (demangle): Likewise.
1692 (asm_demangle): Likewise.
1693 * dwarf-index-cache.c (debug_index_cache): Likewise.
1694 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1695 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1696 * dwarf2read.c (check_physname): Likewise.
1697 (use_deprecated_index_sections): Likewise.
1698 (dwarf_always_disassemble): Likewise.
1699 * eval.c (overload_resolution): Likewise.
1700 * event-top.c (set_editing_cmd_var): Likewise.
1701 (exec_done_display_p): Likewise.
1702 * event-top.h (set_editing_cmd_var): Likewise.
1703 (exec_done_display_p): Likewise.
1704 * exec.c (write_files): Likewise.
1705 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1706 (debug_fbsd_nat): Likewise.
1707 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1708 Likewise.
1709 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1710 <backtrace_past_entry> Likewise.
1711 * gdb-demangle.h (demangle): Likewise.
1712 (asm_demangle): Likewise.
1713 * gdb_bfd.c (bfd_sharing): Likewise.
1714 * gdbcore.h (write_files): Likewise.
1715 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1716 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1717 * gdbthread.h (print_thread_events): Likewise.
1718 * gdbtypes.c (opaque_type_resolution): Likewise.
1719 (strict_type_checking): Likewise.
1720 * gnu-nat.c (gnu_debug_flag): Likewise.
1721 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1722 * guile/scm-param.c (pascm_variable): Add boolval.
1723 (add_setshow_generic): Update.
1724 (pascm_param_value): Update.
1725 (pascm_set_param_value_x): Update.
1726 * hppa-tdep.c (hppa_debug): Change to bool..
1727 * infcall.c (may_call_functions_p): Likewise.
1728 (coerce_float_to_double_p): Likewise.
1729 (unwind_on_signal_p): Likewise.
1730 (unwind_on_terminating_exception_p): Likewise.
1731 * infcmd.c (startup_with_shell): Likewise.
1732 * inferior.c (print_inferior_events): Likewise.
1733 * inferior.h (startup_with_shell): Likewise.
1734 (print_inferior_events): Likewise.
1735 * infrun.c (step_stop_if_no_debug): Likewise.
1736 (detach_fork): Likewise.
1737 (debug_displaced): Likewise.
1738 (disable_randomization): Likewise.
1739 (non_stop): Likewise.
1740 (non_stop_1): Likewise.
1741 (observer_mode): Likewise.
1742 (observer_mode_1): Likewise.
1743 (set_observer_mode): Update.
1744 (sched_multi): Change to bool.
1745 * infrun.h (debug_displaced): Likewise.
1746 (sched_multi): Likewise.
1747 (step_stop_if_no_debug): Likewise.
1748 (non_stop): Likewise.
1749 (disable_randomization): Likewise.
1750 * linux-tdep.c (use_coredump_filter): Likewise.
1751 (dump_excluded_mappings): Likewise.
1752 * linux-thread-db.c (auto_load_thread_db): Likewise.
1753 (check_thread_db_on_load): Likewise.
1754 * main.c (captured_main_1): Update.
1755 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1756 xx2_opt, boolean_opt>: Change to bool.
1757 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1758 * maint.c (maintenance_profile_p): Likewise.
1759 (per_command_time): Likewise.
1760 (per_command_space): Likewise.
1761 (per_command_symtab): Likewise.
1762 * memattr.c (inaccessible_by_default): Likewise.
1763 * mi/mi-main.c (mi_async): Likewise.
1764 (mi_async_1): Likewise.
1765 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1766 * nat/fork-inferior.h (startup_with_shell): Likewise.
1767 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1768 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1769 * nios2-tdep.c (nios2_debug): Likewise.
1770 * or1k-tdep.c (or1k_debug): Likewise.
1771 * parse.c (parser_debug): Likewise.
1772 * parser-defs.h (parser_debug): Likewise.
1773 * printcmd.c (print_symbol_filename): Likewise.
1774 * proc-api.c (procfs_trace): Likewise.
1775 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1776 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1777 (set_parameter_value): Update.
1778 (add_setshow_generic): Update.
1779 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1780 to bool*.
1781 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1782 int*.
1783 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1784 * record-btrace.c (record_btrace_target::store_registers): Update.
1785 * record-full.c (record_full_memory_query): Change to bool.
1786 (record_full_stop_at_limit): Likewise.
1787 * record-full.h (record_full_memory_query): Likewise.
1788 * remote-notif.c (notif_debug): Likewise.
1789 * remote-notif.h (notif_debug): Likewise.
1790 * remote.c (use_range_stepping): Likewise.
1791 (interrupt_on_connect): Likewise.
1792 (remote_break): Likewise.
1793 * ser-tcp.c (tcp_auto_retry): Likewise.
1794 * ser-unix.c (serial_hwflow): Likewise.
1795 * skip.c (debug_skip): Likewise.
1796 * solib-aix.c (solib_aix_debug): Likewise.
1797 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1798 (spu_auto_flush_cache_p): Likewise.
1799 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1800 Likewise.
1801 (struct info_print_options) <quiet>: Likewise.
1802 * symfile-debug.c (debug_symfile): Likewise.
1803 * symfile.c (auto_solib_add): Likewise.
1804 (separate_debug_file_debug): Likewise.
1805 * symfile.h (auto_solib_add): Likewise.
1806 (separate_debug_file_debug): Likewise.
1807 * symtab.c (basenames_may_differ): Likewise.
1808 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1809 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1810 (struct info_types_options) <quiet>: Likewise.
1811 * symtab.h (demangle): Likewise.
1812 (basenames_may_differ): Likewise.
1813 * target-dcache.c (stack_cache_enabled_1): Likewise.
1814 (code_cache_enabled_1): Likewise.
1815 * target.c (trust_readonly): Likewise.
1816 (may_write_registers): Likewise.
1817 (may_write_memory): Likewise.
1818 (may_insert_breakpoints): Likewise.
1819 (may_insert_tracepoints): Likewise.
1820 (may_insert_fast_tracepoints): Likewise.
1821 (may_stop): Likewise.
1822 (auto_connect_native_target): Likewise.
1823 (target_stop_and_wait): Update.
1824 (target_async_permitted): Change to bool.
1825 (target_async_permitted_1): Likewise.
1826 (may_write_registers_1): Likewise.
1827 (may_write_memory_1): Likewise.
1828 (may_insert_breakpoints_1): Likewise.
1829 (may_insert_tracepoints_1): Likewise.
1830 (may_insert_fast_tracepoints_1): Likewise.
1831 (may_stop_1): Likewise.
1832 * target.h (target_async_permitted): Likewise.
1833 (may_write_registers): Likewise.
1834 (may_write_memory): Likewise.
1835 (may_insert_breakpoints): Likewise.
1836 (may_insert_tracepoints): Likewise.
1837 (may_insert_fast_tracepoints): Likewise.
1838 (may_stop): Likewise.
1839 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1840 (make_thread_apply_all_options_def_group): Change argument from int*
1841 to bool*.
1842 (thread_apply_all_command): Update.
1843 (print_thread_events): Change to bool.
1844 * top.c (confirm): Likewise.
1845 (command_editing_p): Likewise.
1846 (history_expansion_p): Likewise.
1847 (write_history_p): Likewise.
1848 (info_verbose): Likewise.
1849 * top.h (confirm): Likewise.
1850 (history_expansion_p): Likewise.
1851 * tracepoint.c (disconnected_tracing): Likewise.
1852 (circular_trace_buffer): Likewise.
1853 * typeprint.c (print_methods): Likewise.
1854 (print_typedefs): Likewise.
1855 * utils.c (debug_timestamp): Likewise.
1856 (sevenbit_strings): Likewise.
1857 (pagination_enabled): Likewise.
1858 * utils.h (sevenbit_strings): Likewise.
1859 (pagination_enabled): Likewise.
1860 * valops.c (overload_resolution): Likewise.
1861 * valprint.h (struct value_print_options) <prettyformat_arrays,
1862 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1863 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1864 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1865 Likewise.
1866 * windows-nat.c (new_console): Likewise.
1867 (cygwin_exceptions): Likewise.
1868 (new_group): Likewise.
1869 (debug_exec): Likewise.
1870 (debug_events): Likewise.
1871 (debug_memory): Likewise.
1872 (debug_exceptions): Likewise.
1873 (useshell): Likewise.
1874 * windows-tdep.c (maint_display_all_tib): Likewise.
1875 * xml-support.c (debug_xml): Likewise.
1876
1877 2019-09-17 Mike Gulick <mgulick@mathworks.com>
1878
1879 * source.c (prepare_path_for_appending): New function.
1880 (openp): Make use of new function.
1881 (find_and_open_source): Search for the compilation directory and
1882 source file as a relative path beneath the directory search path.
1883
1884 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1885
1886 * source-cache.c (source_cache::get_line_charpos): Catch
1887 exceptions and return false, this matches the behaviour documented
1888 in the header file.
1889
1890 2019-09-17 Joel Brobecker <brobecker@adacore.com>
1891
1892 * ada-tasks.c (info_task): Remove quoting of the task's name.
1893
1894 2019-09-16 Christian Biesinger <cbiesinger@google.com>
1895
1896 * symfile.c (auto_solib_add): Replace comment with a reference
1897 to the header file.
1898
1899 2019-09-14 Christian Biesinger <cbiesinger@google.com>
1900
1901 * NEWS: Mention that gdb can now be compiled with Python 3
1902 on Windows.
1903
1904 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1905
1906 * maint.c (maint_print_section_data::maint_print_section_data):
1907 Force use of 'float log10 (float)' by casting the argument to
1908 float.
1909
1910 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1911
1912 * maint.c: Add 'cmath' include.
1913 (struct maint_print_section_data): New structure.
1914 (print_section_index): New function.
1915 (print_bfd_section_info): Add header comment, small whitespace
1916 cleanup, and update to call new print_section_index function.
1917 (print_objfile_section_info): Likewise.
1918 (maint_obj_section_from_bfd_section): New function.
1919 (print_bfd_section_info_maybe_relocated): New function.
1920 (maintenance_info_sections): Add header comment, always use
1921 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1922
1923 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1924
1925 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1926 inner scope, add check that the objfile has psymtabs before
1927 checking psymtabs_addrmap.
1928 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1929
1930 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1931
1932 * NEWS: Announce that Ada task names are now shown at more places,
1933 and between quotes (except in info task output).
1934 * gdb/ada-tasks.c (task_to_str): New function.
1935 (display_current_task_id): Call task_to_str.
1936 (task_command_1): Likewise.
1937 (print_ada_task_info): In non-mi mode, Properly align headers and data
1938 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1939
1940 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1941
1942 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1943 prstatus.pr_lwp.pr_info instead of making it up.
1944
1945 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1946
1947 * auto-load.c (auto_load_expand_dir_vars): Update.
1948 * defs.h (gdb_datadir): Change to std::string.
1949 (python_libdir): Likewise.
1950 (relocate_gdb_directory): Change return type to std::string.
1951 * guile/guile.c (gdbscm_data_directory): Update.
1952 (initialize_scheme_side): Update.
1953 * jit.c (jit_reader_dir): Change to std::string.
1954 (jit_reader_load_command): Update.
1955 * main.c (gdb_datadir): Change to std::string.
1956 (python_libdir): Likewise.
1957 (set_gdb_data_directory): Update.
1958 (relocate_path): Change to return std::string.
1959 (relocate_gdb_directory): Change to return std::string.
1960 (relocate_gdbinit_path_maybe_in_datadir): Update.
1961 (captured_main_1): Update.
1962 * python/python.c (do_start_initialization): Update.
1963 * top.c (show_gdb_datadir): Update.
1964 * xml-syscall.c (xml_init_syscalls_info): Update.
1965 (init_syscalls_info): Update.
1966
1967 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1968
1969 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1970 out of get_init_files.
1971 (get_init_files): Update.
1972
1973 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1974
1975 * main.c (get_init_files): Change to use std::string.
1976 (captured_main_1): Update.
1977 (print_gdb_help): Update.
1978
1979 2019-09-11 Ali Tamur <tamur@google.com>
1980
1981 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1982 implementation.
1983
1984 2019-09-11 Christian Biesinger <cbiesinger@google.com>
1985
1986 * dbxread.c (read_dbx_symtab): Update.
1987 * dwarf2read.c (load_partial_dies): Update.
1988 * mdebugread.c (parse_partial_symbols): Update.
1989 (handle_psymbol_enumerators): Update.
1990 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1991 * psymtab.c (add_psymbol_to_bcache): Likewise.
1992 (add_psymbol_to_list): Likewise.
1993 * symtab.c (symbol_set_names): Likewise.
1994 * symtab.h (symbol_set_names): Likewise.
1995 * xcoffread.c (scan_xcoff_symtab): Update.
1996
1997 2019-09-11 Tom Tromey <tom@tromey.com>
1998
1999 * symfile-mem.c (symbol_file_add_from_memory): Use
2000 bfd_set_filename.
2001 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2002 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2003
2004 2019-09-10 Tom Tromey <tromey@adacore.com>
2005
2006 * dwarf-index-write.c (write_psymbols): Extend error message.
2007 (debug_names::insert): Add Ada code.
2008 (debug_names::write_psymbols): Remove Ada check.
2009 (debug_names) <m_string_obstack>: New member.
2010 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2011 (gdb_index_symbol_name_matcher::matches): Remove.
2012 (mapped_index_base::find_name_components_bounds): Add "lang"
2013 parameter.
2014 (mapped_index_base::build_name_components): Also split names
2015 according to Ada syntax.
2016 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
2017 type of "match_callback".
2018 (check_match, check_find_bounds_finds)
2019 (dw2_expand_symtabs_matching): Update.
2020 (dw2_debug_names_iterator): Add new constructor.
2021 (dw2_debug_names_map_matching_symbols): New function.
2022 (dw2_debug_names_expand_symtabs_matching): Update.
2023 (dwarf2_debug_names_functions): Use
2024 dw2_debug_names_map_matching_symbols.
2025
2026 2019-09-10 Tom Tromey <tromey@adacore.com>
2027
2028 * dwarf2read.c (dw2_get_file_names_reader): Add the
2029 CU's file name to the results.
2030
2031 2019-09-10 Tom Tromey <tromey@adacore.com>
2032
2033 * ada-lang.c (add_nonlocal_symbols): Combine calls to
2034 map_matching_symbols. Update.
2035 * dwarf2read.c (dw2_map_matching_symbols): Update.
2036 * psymtab.c (match_partial_symbol): Change type; update.
2037 (psym_map_matching_symbols): Likewise.
2038 * symfile-debug.c (debug_qf_map_matching_symbols): Change
2039 type; update.
2040 * symfile.h (struct quick_symbol_functions)
2041 <map_matching_symbols>: Change "name" to be a lookup_name_info.
2042 Remove "match".
2043
2044 2019-09-10 Tom Tromey <tromey@adacore.com>
2045
2046 * psymtab.c (map_block): Remove.
2047 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2048 * symtab.c (iterate_over_symbols_terminated): New function.
2049 * symtab.c (iterate_over_symbols_terminated): Declare.
2050
2051 2019-09-10 Tom Tromey <tromey@adacore.com>
2052
2053 * ada-lang.c (ada_iterate_over_symbols): Return bool.
2054 * language.h (struct language_defn) <la_iterate_over_symbols>:
2055 Return bool.
2056 * symtab.c (iterate_over_symbols): Return bool.
2057 * symtab.h (iterate_over_symbols): Return bool.
2058
2059 2019-09-10 Tom Tromey <tromey@adacore.com>
2060
2061 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2062 (add_nonlocal_symbols): Update.
2063 * dwarf2read.c (dw2_map_matching_symbols): Change type.
2064 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2065 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2066 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2067 Change type of "callback". Remove "data".
2068
2069
2070 2019-09-09 Ali Tamur <tamur@google.com>
2071
2072 * dwarf2read.c (comp_unit_head): Update comment.
2073 (dwarf2_dwo_name): New function declaration.
2074 (dwarf_unit_type_name): New function declaration.
2075 (read_comp_unit_head): Add support for new compilation units,
2076 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2077 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2078 (currently named as "signature") in their header. Also clarify error
2079 messages.
2080 (lookup_dwo_id): New function. Returns the dwo id of the given
2081 compile unit.
2082 (lookup_dwo_unit): Use the new lookup_dwo_id function.
2083 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2084 functions.
2085 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2086 (dwarf2_dwo_name): Get the dwo name if present.
2087 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2088 purposes.
2089
2090 2019-09-09 Tom Tromey <tom@tromey.com>
2091
2092 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2093
2094 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2095
2096 * python/python.c (do_start_initialization): Make progname_copy static,
2097 to avoid a leak report.
2098
2099 2019-09-08 Tom Tromey <tom@tromey.com>
2100
2101 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2102
2103 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
2104
2105 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2106 Change type to gdb::optional<block_enum>.
2107 (dw2_symtab_iter_init): Change block_index parameter type
2108 to gdb::optional<block_enum>.
2109 (dw2_lookup_symbol): Change block_index parameter
2110 type to block_enum.c
2111 (dw2_debug_names_lookup_symbol): Likewise.
2112 * psymtab.c (psym_lookup_symbol): Likewise.
2113 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2114 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2115 Likewise.
2116
2117 2019-09-06 Christian Biesinger <cbiesinger@google.com>
2118
2119 * defs.h (relocate_gdb_directory): Change int to bool in
2120 signature and rename flag to relocatable.
2121 * main.c (relocate_path): Likewise.
2122 (relocate_gdb_directory): Likewise.
2123
2124 2019-09-06 Alan Modra <amodra@gmail.com>
2125
2126 * coffread.c (coff_symfile_read): Constify filename variable.
2127 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2128 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2129 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2130 * solib.c (reload_shared_libraries_1): Likewise.
2131 * symfile.c (reread_symbols): Likewise.
2132 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2133 * solib-darwin.c (darwin_bfd_open): Likewise.
2134 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2135
2136 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
2137
2138 * psymtab.c (print_partial_symbols): Handle missing domain_enum
2139 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2140
2141 2019-09-03 Tom Tromey <tromey@adacore.com>
2142
2143 * ada-valprint.c (ada_val_print_num): Don't recurse for range
2144 types.
2145 (has_negatives): Unbias a range type bound.
2146 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2147 * gdbtypes.c (operator==): Handle new field.
2148 (create_range_type): Add "bias" parameter.
2149 (create_static_range_type, resolve_dynamic_range): Update.
2150 * gdbtypes.h (struct range_bounds) <bias>: New member.
2151 (create_range_type): Add bias parameter.
2152 * printcmd.c (print_scalar_formatted): Unbias range types.
2153 * value.c (unpack_long): Unbias range types.
2154 (pack_long): Bias range types.
2155
2156 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2157
2158 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2159 probe arguments.
2160
2161 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2162
2163 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2164 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2165 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2166 (compile_probe_arg): Likewise.
2167 * probe.h (get_argument_count): Likewise.
2168 * solib-svr4.c (solib_event_probe_action): Likewise.
2169 * stap-probe.c (stap_probe::get_argument_count): Likewise.
2170
2171 2019-09-02 Alan Hayward <alan.hayward@arm.com>
2172
2173 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2174 code to here...
2175 (svr4_create_solib_event_breakpoints): ...from here.
2176
2177 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
2178
2179 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2180 suffix from warning message.
2181
2182 2019-08-30 Tom Tromey <tom@tromey.com>
2183
2184 * tui/tui-winsource.h (struct tui_source_window_base)
2185 <refresh_all>: Don't declare.
2186 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2187 Remove.
2188 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2189 tui_show_locator_content.
2190 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2191 declare.
2192 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2193 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2194 declare.
2195
2196 2019-08-30 Tom Tromey <tom@tromey.com>
2197
2198 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2199
2200 2019-08-30 Tom Tromey <tom@tromey.com>
2201
2202 * tui/tui-stack.c (_initialize_tui_stack): Move later.
2203 Remove unnecessary forward declarations.
2204
2205 2019-08-30 Tom Tromey <tom@tromey.com>
2206
2207 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2208 rerender.
2209 (tui_update_locator_fullname, tui_show_frame_info): Don't call
2210 tui_show_locator_content.
2211
2212 2019-08-30 Tom Tromey <tom@tromey.com>
2213
2214 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
2215 (tui_locator_window::rerender): Rewrite using body of previous
2216 tui_show_locator_content.
2217
2218 2019-08-30 Tom Tromey <tom@tromey.com>
2219
2220 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2221 set_locator_fullname>: New methods.
2222 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2223 Rename from tui_set_locator_fullname.
2224 (tui_locator_window::set_locator_info): Rename from
2225 tui_set_locator_info. Return bool.
2226 (tui_update_locator_fullname, tui_show_frame_info): Update.
2227
2228 2019-08-30 Tom Tromey <tom@tromey.com>
2229
2230 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2231
2232 2019-08-30 Tom Tromey <tom@tromey.com>
2233
2234 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2235 call touchwin.
2236
2237 2019-08-30 Tom Tromey <tom@tromey.com>
2238
2239 * tui/tui-wingeneral.c (box_win): Assume win_info and
2240 win_info->handle cannot be NULL.
2241
2242 2019-08-30 Tom Tromey <tom@tromey.com>
2243
2244 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2245 refresh_window>: Declare.
2246 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2247 resize.
2248 (tui_data_item_window::rerender): Rename from
2249 tui_display_register.
2250 (tui_data_item_window::refresh_window): New method.
2251 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2252 no-op.
2253
2254 2019-08-30 Tom Tromey <tom@tromey.com>
2255
2256 * tui/tui-regs.h (struct tui_data_window) <regs_content,
2257 regs_column_count, current_group>: Move later. Now private.
2258 <get_current_group>: New method.
2259 * tui/tui-regs.c (tui_reg_command): Update.
2260 * tui/tui-layout.c (tui_set_layout): Update.
2261
2262 2019-08-30 Tom Tromey <tom@tromey.com>
2263
2264 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2265 (tui_data_window::rerender): Don't call
2266 check_and_display_highlight_if_needed.
2267 (tui_data_window::refresh_all): Remove call to
2268 erase_data_content.
2269
2270 2019-08-30 Tom Tromey <tom@tromey.com>
2271
2272 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2273 (tui_data_window::display_registers_from)
2274 (tui_data_window::display_reg_element_at_line)
2275 (tui_data_window::display_registers_from_line): Remove checks of
2276 "empty".
2277
2278 2019-08-30 Tom Tromey <tom@tromey.com>
2279
2280 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2281 Don't declare.
2282 * tui/tui-regs.c (tui_data_window::show_registers): Call
2283 rerender.
2284 (tui_data_window::rerender): Rename from display_all_data.
2285 (tui_data_window::rerender): Remove old implementation.
2286
2287 2019-08-30 Tom Tromey <tom@tromey.com>
2288
2289 * tui/tui-regs.c (tui_data_window::display_all_data): Change
2290 text.
2291 * tui/tui-data.h (NO_DATA_STRING): Remove define.
2292
2293 2019-08-29 Bernhard Wodok <barto@gmx.net>
2294 Sergio Durigan Junior <sergiodj@redhat.com>
2295
2296 PR win32/24284
2297 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2298
2299 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2300
2301 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2302 when searching for types.
2303
2304 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
2305
2306 * f-lang.c (f_language_defn): Use f_print_typedef.
2307 * f-lang.h (f_print_typedef): Declare.
2308 * f-typeprint.c (f_print_typedef): Define.
2309
2310 2019-08-27 Christian Biesinger <cbiesinger@google.com>
2311
2312 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2313
2314 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
2315
2316 * cli/cli-utils.c (info_print_options_defs): Delete.
2317 (make_info_print_options_def_group): Delete.
2318 (extract_info_print_options): Delete.
2319 (info_print_command_completer): Delete.
2320 (info_print_args_help): Add extra parameter, and optionally
2321 include text about -n flag.
2322 * cli/cli-utils.h (struct info_print_options): Delete.
2323 (extract_info_print_options): Delete declaration.
2324 (info_print_command_completer): Delete declaration.
2325 (info_print_args_help): Add extra parameter, extend header
2326 comment.
2327 * python/python.c (gdbpy_rbreak): Pass additional parameter to
2328 search_symbols.
2329 * stack.c (struct info_print_options): New type.
2330 (info_print_options_defs): New file scoped variable.
2331 (make_info_print_options_def_group): New static function.
2332 (info_print_command_completer): New static function.
2333 (info_locals_command): Update to use new local functions.
2334 (info_args_command): Likewise.
2335 (_initialize_stack): Add extra parameter to calls to
2336 info_print_args_help.
2337 * symtab.c (search_symbols): Add extra parameter, use this to
2338 possibly excluse non-debug symbols.
2339 (symtab_symbol_info): Add extra parameter, which is passed on to
2340 search_symbols.
2341 (struct info_print_options): New type.
2342 (info_print_options_defs): New file scoped variable.
2343 (make_info_print_options_def_group): New static function.
2344 (info_print_command_completer): New static function.
2345 (info_variables_command): Update to use local functions, and pass
2346 extra parameter through to symtab_symbol_info.
2347 (info_functions_command): Likewise.
2348 (info_types_command): Pass additional argument through to
2349 symtab_symbol_info.
2350 (rbreak_command): Pass extra argument to search_symbols.
2351 (_initialize_symtab): Add extra arguments for calls to
2352 info_print_args_help, and update help text for 'info variables',
2353 'whereis', and 'info functions' commands.
2354 * symtab.h (search_symbols): Add extra argument to declaration.
2355 * NEWS: Mention new flags.
2356
2357 2019-08-26 Christian Biesinger <cbiesinger@google.com>
2358
2359 * symtab.c (lookup_static_symbol): Call the new function (and move
2360 it down to be next to lookup_global_symbol).
2361 (struct global_sym_lookup_data): Add block_enum member and rename to...
2362 (struct global_or_static_sym_lookup_data): ...this.
2363 (lookup_symbol_global_iterator_cb): Pass block_index instead of
2364 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2365 (lookup_symbol_global_or_static_iterator_cb): ...this.
2366 (lookup_global_or_static_symbol): New function.
2367 (lookup_global_symbol): Call new function.
2368
2369 2019-08-26 Tom de Vries <tdevries@suse.de>
2370
2371 PR c++/24852
2372 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2373 when pc_probe.prob == NULL.
2374
2375 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2376
2377 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2378 variable symbol_linkage to symbol_linkage_.
2379
2380 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
2381
2382 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2383 represent whether the symbol is static, dynamic, or we don't
2384 know.
2385
2386 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
2387
2388 * gdb/rx-tdep.c (rx_register_names): New.
2389 (rx_register_name): Delete.
2390 (rx_psw_type): Delete.
2391 (rx_fpsw_type): Delete.
2392 (rx_register_type): Delete.
2393 (rx_gdbarch_init): Convert target-descriptions.
2394 (_initialize_rx_tdep): Add initialize_tdesc_rx.
2395 * gdb/features/Makefile: Add rx.xml.
2396 * gdb/features/rx.xml: New.
2397 * gdb/features/rx.c: Generated.
2398 * gdb/NEWS: Mention target description support.
2399
2400 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2401
2402 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2403 *slot_ptr.
2404
2405 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
2406
2407 * configure.ac: Don't check for 'dlfcn.h' (moved to
2408 gdbsupport/common.m4).
2409 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2410 'gdbsupport/'.
2411 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2412 * compile/compile-c-support.c: Include
2413 'gdbsupport/gdb-dlfcn.h'.
2414 * gdbsupport/common.m4: Check for 'dlfcn.h'.
2415 * gdb-dlfcn.c: Move to...
2416 * gdbsupport/gdb-dlfcn.c: ... here.
2417 * gdb-dlfcn.h: Move to...
2418 * gdbsupport/gdb-dlfcn.h: ... here.
2419
2420 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
2421
2422 * nios2-tdep.c (struct reg_value): Improve comments. Make
2423 the offset field signed.
2424
2425 2019-08-22 Christian Biesinger <cbiesinger@google.com>
2426
2427 * python/lib/gdb/__init__.py (_execute_file): New function.
2428 * python/python.c (python_run_simple_file): Call gdb._execute_file
2429 on Windows.
2430
2431 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
2432
2433 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2434 all uses as this was never set to anything but a zero value.
2435
2436 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
2437
2438 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2439
2440 2019-08-21 Christian Biesinger <cbiesinger@google.com>
2441
2442 * tui/tui-data.h (tui_gen_win_info): Add an =default
2443 move constructor, required by some GCC versions.
2444
2445 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
2446
2447 * go32-nat.c (go32_sysinfo): Add hygon_p.
2448
2449 2019-08-20 Tom Tromey <tom@tromey.com>
2450
2451 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2452 line_from_reg_element_no, first_reg_element_no_inline,
2453 display_all_data, delete_data_content_windows,
2454 erase_data_content>: Now private.
2455
2456 2019-08-20 Tom Tromey <tom@tromey.com>
2457
2458 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2459 (tui_unhighlight_win, tui_highlight_win)
2460 (tui_win_info::make_window): Update.
2461 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2462
2463 2019-08-20 Tom Tromey <tom@tromey.com>
2464
2465 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2466 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2467 (MAX_PID_WIDTH): Move to tui-stack.c.
2468 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2469 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2470 (MAX_PID_WIDTH): Move from tui-data.h.
2471
2472 2019-08-20 Tom Tromey <tom@tromey.com>
2473
2474 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2475 * tui/tui-wingeneral.c (box_win): Change type of win_info.
2476 (box_win): Update.
2477 (tui_gen_win_info::make_window): Rename from tui_make_window.
2478 (tui_win_info::make_window): New method.
2479 (tui_gen_win_info::make_visible): Update.
2480 * tui/tui-source.c (tui_source_window::set_contents): Update.
2481 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2482 (tui_data_window::display_registers_from): Update.
2483 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2484 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2485 Declare.
2486 <can_box>: Remove.
2487 <title>: Remove.
2488 (struct tui_win_info) <make_window>: Declare.
2489 <can_box>: Now virtual.
2490 <title>: New member.
2491 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2492 * tui/tui-command.c (tui_cmd_window::resize): Update.
2493
2494 2019-08-20 Tom Tromey <tom@tromey.com>
2495
2496 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2497 * tui/tui-regs.c (tui_data_window::show_registers): Update.
2498 (tui_data_window::check_register_values): Update.
2499
2500 2019-08-20 Tom Tromey <tom@tromey.com>
2501
2502 * tui/tui-regs.h (struct tui_data_window): Use
2503 DISABLE_COPY_AND_ASSIGN.
2504 <regs_content>: Change type, removing unique_ptr.
2505 <tui_data_window>: Add move constructor.
2506 * tui/tui-regs.c (tui_data_window::show_registers)
2507 (tui_data_window::show_register_group)
2508 (tui_data_window::display_registers_from)
2509 (tui_data_window::display_registers_from)
2510 (tui_data_window::first_data_item_displayed)
2511 (tui_data_window::delete_data_content_windows)
2512 (tui_data_window::rerender, tui_data_window::refresh_window)
2513 (tui_data_window::check_register_values): Update.
2514
2515 2019-08-20 Tom Tromey <tom@tromey.com>
2516
2517 * tui/tui-regs.h (struct tui_data_window) <show_registers,
2518 show_register_group>: Declare.
2519 (tui_show_register_group): Don't declare.
2520 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2521 tui_show_registers.
2522 (tui_data_window::show_register_group): Rename from
2523 tui_show_register_group.
2524 (tui_data_window::check_register_values, tui_reg_command):
2525 Update.
2526 * tui/tui-layout.c (tui_set_layout): Update.
2527
2528 2019-08-20 Tom Tromey <tom@tromey.com>
2529
2530 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2531 Declare.
2532 (tui_check_register_values): Don't declare.
2533 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2534 from tui_check_register_values.
2535 * tui/tui-hooks.c (tui_register_changed): Update.
2536
2537 2019-08-20 Tom Tromey <tom@tromey.com>
2538
2539 * tui/tui-regs.c (tui_reg_layout): Move later.
2540 (tui_show_registers): Don't enable TUI mode or change layout.
2541
2542 2019-08-20 Tom Tromey <tom@tromey.com>
2543
2544 * tui/tui-regs.h (struct tui_data_item_window)
2545 <~tui_data_item_window>: Remove.
2546 <content>: Now a unique_xmalloc_ptr.
2547 * tui/tui-regs.c (tui_register_format): Return a
2548 unique_xmalloc_ptr.
2549 (tui_get_register): Update.
2550 (~tui_data_item_window): Remove.
2551 (tui_data_window::display_registers_from, tui_display_register):
2552 Update.
2553 * tui/tui-io.h (tui_expand_tabs): Update.
2554 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2555 Remove "col" parameter.
2556
2557 2019-08-20 Tom Tromey <tom@tromey.com>
2558
2559 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2560 field.
2561 * tui/tui-regs.c (~tui_data_item_window): Update.
2562
2563 2019-08-20 Tom Tromey <tom@tromey.com>
2564
2565 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2566 earlier.
2567
2568 2019-08-20 Tom Tromey <tom@tromey.com>
2569
2570 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2571
2572 2019-08-20 Tom Tromey <tom@tromey.com>
2573
2574 * tui/tui-source.h (struct tui_source_window): Update.
2575 * tui/tui-regs.c (tui_show_registers): Update.
2576 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2577 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2578 (NO_REGS_STRING): Remove defines.
2579
2580 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
2581
2582 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2583 unnecessary thread walk if remote doesn't support the packet.
2584
2585 2019-08-19 Tom Tromey <tromey@adacore.com>
2586
2587 * python/py-value.c (value_has_field): Fix indentation.
2588
2589 2019-08-19 Tom Tromey <tromey@adacore.com>
2590
2591 * printcmd.c (do_one_display, info_display_command): Update.
2592 * block.h (contained_in): Return bool. Add allow_nested
2593 parameter.
2594 * block.c (contained_in): Return bool. Add allow_nested
2595 parameter.
2596
2597 2019-08-19 Tom Tromey <tom@tromey.com>
2598
2599 * configure: Rebuild.
2600 * configure.ac: Disallow the combination of -static-libstdc++ and
2601 source highlight.
2602 * source-cache.c (get_language_name): Handle rust.
2603 (source_cache::get_source_lines): Ignore highlighting exceptions.
2604
2605 2019-08-16 Tom Tromey <tom@tromey.com>
2606
2607 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2608 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2609 (struct tui_source_window_base) <make_visible, refresh_window,
2610 resize>: Remove methods.
2611 <execution_info>: Remove field.
2612 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2613 (tui_show_source_line, tui_source_window_base)
2614 (~tui_source_window_base): Update.
2615 (tui_source_window_base::resize)
2616 (tui_source_window_base::make_visible)
2617 (tui_source_window_base::refresh_window): Remove.
2618 (tui_source_window_base::update_exec_info): Update.
2619 * tui/tui-source.c (tui_source_window::set_contents): Update.
2620 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2621
2622 2019-08-16 Tom Tromey <tom@tromey.com>
2623
2624 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2625 deprecated_query_hook.
2626
2627 2019-08-16 Tom Tromey <tom@tromey.com>
2628
2629 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2630 (tui_update_source_windows_with_line): Update.
2631 * tui/tui-source.h (struct tui_source_window)
2632 <show_symtab_source>: Declare.
2633 (tui_show_symtab_source): Don't declare.
2634 * tui/tui-source.c (tui_show_symtab_source): Rename from
2635 tui_show_symtab_source.
2636
2637 2019-08-16 Tom Tromey <tom@tromey.com>
2638
2639 * tui/tui-winsource.h (struct tui_source_window_base)
2640 <set_contents>: Declare.
2641 * tui/tui-winsource.c
2642 (tui_source_window_base::update_source_window_as_is): Update.
2643 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2644 Declare.
2645 (tui_set_source_content): Don't declare.
2646 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2647 tui_set_source_content.
2648 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2649 Declare.
2650 (tui_set_disassem_content): Don't declare.
2651 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2652 tui_set_disassem_content.
2653
2654 2019-08-16 Tom Tromey <tom@tromey.com>
2655
2656 * tui/tui-winsource.h (struct tui_source_window_base)
2657 <update_breakpoint_info>: Declare.
2658 (tui_update_breakpoint_info): Don't declare.
2659 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2660 (tui_update_all_breakpoint_info): Update.
2661 (tui_source_window_base::update_breakpoint_info): Rename from
2662 tui_update_breakpoint_info.
2663 (tui_source_window_base::update_exec_info): Update.
2664
2665 2019-08-16 Tom Tromey <tom@tromey.com>
2666
2667 * tui/tui-winsource.h (struct tui_source_window_base)
2668 <update_source_window>: Declare.
2669 (tui_update_source_window): Don't declare.
2670 * tui/tui-winsource.c
2671 (tui_source_window_base::update_source_window): Rename from
2672 tui_update_source_window.
2673 (tui_source_window_base::rerender): Update.
2674 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2675 * tui/tui-disasm.c (tui_show_disassem)
2676 (tui_show_disassem_and_update_source)
2677 (tui_disasm_window::maybe_update): Update.
2678
2679 2019-08-16 Tom Tromey <tom@tromey.com>
2680
2681 * tui/tui-winsource.h (struct tui_source_window_base)
2682 <update_source_window_as_is>: Declare.
2683 (tui_update_source_window_as_is): Don't declare.
2684 * tui/tui-winsource.c (tui_update_source_window): Update
2685 (tui_source_window_base::update_source_window_as_is): Rename from
2686 tui_update_source_window_as_is.
2687 (tui_source_window_base::refill): Update.
2688 * tui/tui-source.c (tui_show_symtab_source): Update.
2689 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2690 Update.
2691
2692 2019-08-16 Tom Tromey <tom@tromey.com>
2693
2694 * tui/tui-winsource.h (tui_update_source_window)
2695 (tui_update_source_window_as_is): Remove "noerror" parameter.
2696 * tui/tui-winsource.c (tui_update_source_window)
2697 (tui_update_source_window_as_is): Remove "noerror" parameter.
2698 (tui_update_source_windows_with_addr)
2699 (tui_update_source_windows_with_line)
2700 (tui_source_window_base::rerender)
2701 (tui_source_window_base::refill): Update.
2702 * tui/tui-source.h (tui_set_source_content)
2703 (tui_show_symtab_source): Remove "noerror" parameter.
2704 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2705 parameter.
2706 (tui_show_symtab_source): Likewise.
2707 (tui_source_window::maybe_update): Update.
2708 * tui/tui-disasm.c (tui_show_disassem)
2709 (tui_show_disassem_and_update_source)
2710 (tui_disasm_window::do_scroll_vertical)
2711 (tui_disasm_window::maybe_update): Update.
2712
2713 2019-08-16 Tom Tromey <tom@tromey.com>
2714
2715 * tui/tui.c (tui_is_window_visible): Update.
2716 * tui/tui-wingeneral.c (tui_make_window)
2717 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2718 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2719 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2720 (tui_set_win_height_command, parse_scrolling_args): Update.
2721 * tui/tui-source.c (tui_source_window::style_changed): Update.
2722 * tui/tui-regs.c (tui_show_registers)
2723 (tui_data_window::first_data_item_displayed)
2724 (tui_data_window::delete_data_content_windows)
2725 (tui_check_register_values, tui_reg_command): Update.
2726 * tui/tui-disasm.c (tui_show_disassem): Update.
2727 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2728 method.
2729 <is_visible>: Remove field.
2730 * tui/tui-data.c (tui_next_win, tui_prev_win)
2731 (tui_delete_invisible_windows): Update.
2732
2733 2019-08-16 Tom Tromey <tom@tromey.com>
2734
2735 * tui/tui-winsource.h (struct tui_source_window_base)
2736 <m_has_locator>: Remove.
2737 * tui/tui-layout.c (show_source_disasm_command, show_data)
2738 (show_source_or_disasm_and_command): Update.
2739
2740 2019-08-16 Alan Hayward <alan.hayward@arm.com>
2741
2742 * NEWS (Other MI changes): New subsection.
2743 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2744 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2745 * arch-utils.c (default_get_pc_address_flags): New function.
2746 * arch-utils.h (default_get_pc_address_flags): New declaration.
2747 * gdbarch.sh: Add get_pc_address_flags.
2748 * gdbarch.c: Regenerate.
2749 * gdbarch.h: Likewise.
2750 * stack.c (print_pc): New function.
2751 (print_frame_info) (print_frame): Call print_pc.
2752
2753 2019-08-16 Tom de Vries <tdevries@suse.de>
2754
2755 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2756 print_objfile_section_info.
2757
2758 2019-08-15 Tom Tromey <tom@tromey.com>
2759
2760 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2761 calling update_cmdwin_start_line.
2762 * tui/tui-winsource.h (struct tui_source_window_base)
2763 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2764 <rerender>: Declare.
2765 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2766 Call rerender.
2767 (tui_source_window_base::set_new_height): Remove.
2768 (tui_source_window_base::rerender): Rename from
2769 do_make_visible_with_new_height.
2770 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2771 resize method.
2772 (tui_win_info::make_invisible_and_set_new_height)
2773 (tui_win_info::make_visible_with_new_height): Remove.
2774 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2775 Declare.
2776 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2777 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2778 do_make_visible_with_new_height>: Don't declare.
2779 <rerender>: Declare.
2780 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2781 set_new_height.
2782 (tui_data_window::do_make_visible_with_new_height): Remove.
2783 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2784 call tui_show_locator_content.
2785 (tui_gen_win_info::resize): Call rerender.
2786 (show_source_or_disasm_and_command): Don't call
2787 tui_show_locator_content.
2788 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2789 method.
2790 (struct tui_win_info) <rerender>: Declare.
2791 <set_new_height, make_invisible_and_set_new_height,
2792 make_visible_with_new_height>: Don't declare.
2793 * tui/tui-data.c (tui_win_list::rerender): New method.
2794 * tui/tui-command.h (struct tui_cmd_window)
2795 <do_make_visible_with_new_height>: Don't declare.
2796 * tui/tui-command.c
2797 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2798
2799 2019-08-15 Tom Tromey <tromey@adacore.com>
2800
2801 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2802 * ada-lang.c (ada_enum_name): Likewise.
2803
2804 2019-08-15 Christian Biesinger <cbiesinger@google.com>
2805
2806 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2807 leading underscore.
2808 (GdbOutputErrorFile): Likewise.
2809 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2810 accordingly.
2811 (execute_unwinders): Rename to have a leading underscore.
2812 (auto_load_packages): Likewise.
2813 (global scope): Adjust call to auto_load_packages accordingly.
2814 (GdbSetPythonDirectory): Likewise.
2815 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2816 instead of execute_unwinders.
2817
2818 2019-08-15 Tom Tromey <tom@tromey.com>
2819
2820 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2821 (show_data): Don't change window visibility.
2822 (tui_gen_win_info::resize): Remove special case for command
2823 window. Use wresize, when available.
2824 (show_source_or_disasm_and_command): Don't change window
2825 visibility.
2826 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2827 <make_visible>: New method.
2828 * tui/tui-command.c (tui_cmd_window::resize): New method.
2829
2830 2019-08-15 Tom Tromey <tom@tromey.com>
2831
2832 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2833 (struct tui_source_windows): New.
2834 * tui/tui-winsource.c (tui_display_main): Update.
2835 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2836 (new_height_ok, parse_scrolling_args): Update.
2837 * tui/tui-layout.c (show_layout, show_data): Update.
2838 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2839 (tui_add_to_source_windows): Don't declare.
2840 * tui/tui-data.c (source_windows, tui_source_windows)
2841 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2842
2843 2019-08-15 Tom Tromey <tom@tromey.com>
2844
2845 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2846 Rename from reset.
2847 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2848 * tui/tui-layout.c (show_source_disasm_command, show_data):
2849 Update.
2850 (tui_gen_win_info::resize): Rename.
2851 (show_source_or_disasm_and_command): Update.
2852 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2853 reset.
2854
2855 2019-08-15 Tom Tromey <tom@tromey.com>
2856
2857 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2858 * tui/tui-interp.c (tui_interp::init): Don't call
2859 tui_initialize_static_data.
2860 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2861
2862 2019-08-15 Tom Tromey <tom@tromey.com>
2863
2864 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2865 examine tui_win_list.
2866
2867 2019-08-15 Tom Tromey <tom@tromey.com>
2868
2869 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2870 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2871 tui_clear_source_content.
2872 (tui_clear_source_content): Remove.
2873 (tui_source_window_base::do_erase_source_content): Hoist call to
2874 content.clear().
2875 * tui/tui-stack.c (tui_show_frame_info): Don't call
2876 tui_clear_source_content.
2877
2878 2019-08-15 Tom Tromey <tom@tromey.com>
2879
2880 * tui/tui-winsource.h (struct tui_source_window_base)
2881 <do_erase_source_content>: New method.
2882 <erase_source_content>: New method.
2883 (tui_erase_source_content): Don't declare.
2884 * tui/tui-winsource.c (tui_clear_source_content): Update.
2885 (tui_source_window_base::do_erase_source_content): Rename from
2886 tui_erase_source_content.
2887 (tui_source_window_base::show_source_content): Update.
2888 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2889 * tui/tui-source.h (struct tui_source_window)
2890 <erase_source_content>: New method.
2891 * tui/tui-disasm.h (struct tui_disasm_window)
2892 <erase_source_content>: New method.
2893
2894 2019-08-15 Tom Tromey <tom@tromey.com>
2895
2896 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2897 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2898 constructor.
2899 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2900 * tui/tui-source.c (tui_set_source_content): Update.
2901 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2902
2903 2019-08-15 Tom Tromey <tom@tromey.com>
2904
2905 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2906 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2907 tui-source.c.
2908 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2909 Declare.
2910 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2911 method.
2912 (tui_source_window::maybe_update): Update.
2913
2914 2019-08-15 Tom Tromey <tom@tromey.com>
2915
2916 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2917 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2918 tui-disasm.c.
2919 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2920 Declare.
2921 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2922 method.
2923 (tui_disasm_window::maybe_update): Update.
2924
2925 2019-08-15 Tom Tromey <tom@tromey.com>
2926
2927 * tui/tui-winsource.h (struct tui_source_window_base)
2928 <maybe_update>: Declare.
2929 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2930 method.
2931 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2932 Declare.
2933 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2934 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2935 Declare.
2936 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2937
2938 2019-08-15 Tom Tromey <tom@tromey.com>
2939
2940 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2941
2942 2019-08-15 Tom Tromey <tom@tromey.com>
2943
2944 * tui/tui-wingeneral.c: Include tui-stack.h.
2945 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2946 (struct tui_locator_window): Move from tui-data.h.
2947 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2948 (tui_initialize_static_data): Move from tui-data.c.
2949 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2950 (struct tui_locator_window): Move to tui-stack.c.
2951 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2952 (tui_initialize_static_data): Move to tui-stack.c.
2953
2954 2019-08-15 Tom Tromey <tom@tromey.com>
2955
2956 * tui/tui-layout.c (show_source_disasm_command)
2957 (show_source_or_disasm_and_command): Use make_visible method, not
2958 tui_make_window.
2959 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2960 Remove.
2961
2962 2019-08-15 Tom Tromey <tom@tromey.com>
2963
2964 * tui/tui-wingeneral.h (tui_make_window): Update.
2965 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2966 parameter.
2967 (tui_gen_win_info::make_visible): Update.
2968 * tui/tui-regs.c (tui_data_window::display_registers_from):
2969 Update.
2970 * tui/tui-layout.c (show_source_disasm_command)
2971 (show_source_or_disasm_and_command): Update.
2972 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2973 (enum tui_box): Remove.
2974 (struct tui_win_info) <can_box>: New method.
2975 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2976 method.
2977
2978 2019-08-15 Tom de Vries <tdevries@suse.de>
2979
2980 * linux-nat-trad.c: Include gdbarch.h.
2981
2982 2019-08-14 Alan Hayward <alan.hayward@arm.com>
2983
2984 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2985 register sizes.
2986
2987 2019-08-14 Tom Tromey <tromey@adacore.com>
2988
2989 * darwin-nat.c: Include gdbarch.h.
2990 * darwin-nat-info.c: Include gdbarch.h.
2991
2992 2019-08-13 Tom Tromey <tom@tromey.com>
2993
2994 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2995 Remove.
2996 * tui/tui-data.c (tui_initialize_static_data): Update.
2997
2998 2019-08-13 Tom Tromey <tom@tromey.com>
2999
3000 * tui/tui-winsource.h (struct tui_exec_info_window)
3001 <~tui_exec_info_window, maybe_allocate_content, get_content,
3002 m_content>: Remove.
3003 (struct tui_source_window_base) <set_exec_info_content,
3004 show_exec_info_content>: Don't declare.
3005 * tui/tui-winsource.c
3006 (tui_exec_info_window::maybe_allocate_content): Remove.
3007 (tui_source_window_base::update_exec_info): Rename from
3008 set_exec_info_content.
3009 (tui_source_window_base::show_exec_info_content)
3010 (tui_source_window_base::update_exec_info): Remove.
3011
3012 2019-08-13 Tom Tromey <tom@tromey.com>
3013
3014 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3015 declare.
3016 * tui/tui-winsource.c (tui_update_source_window_as_is)
3017 (tui_update_source_windows_with_addr, tui_erase_source_content):
3018 Update.
3019 (tui_clear_exec_info_content): Remove.
3020
3021 2019-08-13 Tom Tromey <tom@tromey.com>
3022
3023 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3024 declare.
3025 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3026 call tui_erase_exec_info_content.
3027 (tui_clear_exec_info_content): Rename from
3028 tui_erase_exec_info_content.
3029 (tui_clear_exec_info_content): Delete.
3030
3031 2019-08-13 Tom Tromey <tom@tromey.com>
3032
3033 * tui/tui-winsource.h (struct tui_source_window_base)
3034 <show_exec_info_content>: Declare.
3035 (tui_show_exec_info_content): Don't declare.
3036 * tui/tui-winsource.c
3037 (tui_source_window_base::show_exec_info_content): Rename from
3038 tui_show_exec_info_content.
3039 (tui_source_window_base::update_exec_info): Update.
3040
3041 2019-08-13 Tom Tromey <tom@tromey.com>
3042
3043 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3044 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3045 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3046 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3047 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3048 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3049 ... here.
3050
3051 2019-08-13 Tom Tromey <tom@tromey.com>
3052
3053 * tui/tui-winsource.h (struct tui_source_window_base)
3054 <update_exec_info>: Declare.
3055 (tui_update_exec_info): Don't declare.
3056 * tui/tui-winsource.c (tui_update_source_window_as_is)
3057 (tui_source_window_base::refresh_all)
3058 (tui_update_all_breakpoint_info): Update.
3059 (tui_source_window_base::update_exec_info): Rename from
3060 tui_update_exec_info.
3061 * tui/tui-stack.c (tui_show_frame_info): Update.
3062
3063 2019-08-13 Tom Tromey <tom@tromey.com>
3064
3065 * tui/tui-winsource.h (struct tui_source_window_base)
3066 <set_exec_info_content>: Declare.
3067 (tui_set_exec_info_content): Don't declare.
3068 * tui/tui-winsource.c
3069 (tui_source_window_base::set_exec_info_content): Rename from
3070 tui_set_exec_info_content.
3071 (tui_update_exec_info): Update.
3072
3073 2019-08-13 Tom Tromey <tom@tromey.com>
3074
3075 * tui/tui-winsource.h (struct tui_source_window_base)
3076 <show_source_content>: Declare.
3077 (tui_show_source_content): Don't declare.
3078 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3079 (tui_source_window_base::show_source_content): Rename from
3080 tui_show_source_content.
3081 (tui_source_window_base::refresh_all): Update.
3082 * tui/tui-layout.c (show_source_disasm_command)
3083 (show_source_or_disasm_and_command): Update.
3084
3085 2019-08-13 Tom Tromey <tom@tromey.com>
3086
3087 * tui/tui-winsource.c (tui_erase_source_content)
3088 (tui_show_source_content, tui_source_window_base::refresh_all):
3089 Update.
3090 * tui/tui-wingeneral.h
3091 (tui_check_and_display_highlight_if_needed): Don't declare.
3092 * tui/tui-wingeneral.c
3093 (tui_win_info::check_and_display_highlight_if_needed): Rename from
3094 check_and_display_highlight_if_needed.
3095 * tui/tui-win.c (tui_rehighlight_all)
3096 (tui_win_info::make_visible_with_new_height): Update.
3097 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3098 (tui_data_window::erase_data_content)
3099 (tui_data_window::display_all_data): Update.
3100 * tui/tui-data.h (struct tui_win_info)
3101 <check_and_display_highlight_if_needed>: Declare.
3102
3103 2019-08-13 Tom Tromey <tom@tromey.com>
3104
3105 * tui/tui-win.c (tui_resize_all): Call
3106 tui_delete_invisible_windows.
3107 * tui/tui-layout.c (show_layout): Call
3108 tui_delete_invisible_windows.
3109 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3110 * tui/tui-data.c (tui_delete_invisible_windows): New function.
3111
3112 2019-08-13 Tom Tromey <tom@tromey.com>
3113
3114 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
3115 tui_add_win_to_layout.
3116
3117 2019-08-13 Tom Tromey <tom@tromey.com>
3118
3119 * tui/tui-layout.h (tui_default_win_height): Don't declare.
3120 * tui/tui-layout.c (tui_default_win_height): Now static.
3121
3122 2019-08-13 Tom Tromey <tom@tromey.com>
3123
3124 * tui/tui-layout.c (show_layout): Unify all layout cases into a
3125 single switch.
3126 (show_source_disasm_command, show_source_or_disasm_and_command):
3127 Don't check current layout.
3128
3129 2019-08-13 Tom Tromey <tom@tromey.com>
3130
3131 * tui/tui-wingeneral.c (make_all_visible): Remove.
3132 (tui_make_all_invisible): Simplify.
3133 * tui/tui-layout.c (tui_make_all_invisible): Move from
3134 tui-wingeneral.c; simplify.
3135 (show_layout): Hoist call to tui_make_all_invisible.
3136 (show_data): Don't call tui_make_all_invisible.
3137
3138 2019-08-13 Tom Tromey <tom@tromey.com>
3139
3140 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3141 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3142
3143 2019-08-13 Tom Tromey <tom@tromey.com>
3144
3145 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3146 tui-data.c.
3147 (show_source_disasm_command, show_data)
3148 (show_source_or_disasm_and_command): Don't use
3149 tui_set_current_layout_to.
3150 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3151 * tui/tui-data.c (current_layout, tui_current_layout): Move to
3152 tui-layout.c.
3153 (tui_set_current_layout_to): Remove.
3154
3155 2019-08-13 Tom Tromey <tom@tromey.com>
3156
3157 * tui/tui-layout.c (tui_set_layout): Update.
3158 * tui/tui-data.h (struct tui_layout_def): Remove.
3159 (tui_layout_def): Don't declare.
3160 * tui/tui-data.c (layout_def): Remove.
3161 (tui_layout_def): Remove.
3162
3163 2019-08-13 Tom Tromey <tom@tromey.com>
3164
3165 * tui/tui-winsource.h (struct tui_source_window_base)
3166 <clear_detail>: No longer "override".
3167 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3168 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3169 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3170 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3171 Remove.
3172 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3173
3174 2019-08-13 Tom Tromey <tromey@adacore.com>
3175
3176 * tracepoint.c: Don't include readline.h or history.h.
3177
3178 2019-08-12 Tom Tromey <tom@tromey.com>
3179
3180 * configure: Rebuild.
3181 * configure.ac: Check for readline 7.
3182 * NEWS: Mention readline 7 requirement.
3183 * README: Update.
3184
3185 2019-08-12 Tom Tromey <tom@tromey.com>
3186
3187 * mingw-hdep.c (gdb_select): Remove readline hack.
3188
3189 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
3190
3191 * blockframe.c (find_pc_partial_function): Set *block to nullptr
3192 when the function fails.
3193
3194 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
3195
3196 * s390-tdep.c (s390_type_align): New function.
3197 (s390_gdbarch_init): Set it as type_align gdbarch method.
3198
3199 2019-08-09 Tom de Vries <tdevries@suse.de>
3200
3201 PR gdb/24591
3202 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3203 pc_low with relocation offset.
3204
3205 2019-08-07 Tom Tromey <tromey@adacore.com>
3206
3207 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3208 (print_frame_args): Update.
3209 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3210 Update.
3211 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3212 * frame.h (struct frame_arg): Add initializers.
3213 <error>: Now a unique_xmalloc_ptr.
3214
3215 2019-08-07 Alan Hayward <alan.hayward@arm.com>
3216
3217 * NEWS: Expand the Pointer Authentication entry.
3218 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3219 (aarch64_frame_unmask_lr): ... to this.
3220 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3221 Call aarch64_frame_unmask_lr.
3222 * frame.c (struct frame_info): Add "masked" variable.
3223 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3224 (fprint_frame): Check for masked pc.
3225 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3226 declarations.
3227 * python/py-framefilter.c (py_print_frame): Check for masked pc.
3228 * stack.c (print_frame): Check for masked pc.
3229
3230 2019-08-06 Tom Tromey <tom@tromey.com>
3231
3232 * stabsread.c (patch_block_stabs, read_one_struct_field)
3233 (read_enum_type): Use obstack_strndup.
3234 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3235 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3236 * dwarf2read.c (guess_full_die_structure_name)
3237 (anonymous_struct_prefix): Use obstack_strndup.
3238 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3239 * c-exp.y (yylex): Use obstack_strndup.
3240 * ada-exp.y (write_object_renaming, write_ambiguous_var)
3241 (write_var_or_type): Use obstack_strndup.
3242
3243 2019-08-06 Tom Tromey <tom@tromey.com>
3244
3245 * symfile.c (reread_symbols): Use obstack_strdup.
3246 * stabsread.c (read_type): Use obstack_strdup.
3247 * gdb_obstack.h (obstack_strdup): New overload.
3248 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3249 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3250 (dwarf2_canonicalize_name): Use obstack_strdup.
3251 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3252 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3253 Use obstack_strdup.
3254
3255 2019-08-06 Tom Tromey <tom@tromey.com>
3256
3257 * gdb_obstack.h (obstack_strdup): Define.
3258 * gdb_obstack.c (obstack_strdup): Don't define.
3259
3260 2019-08-06 Tom Tromey <tom@tromey.com>
3261
3262 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3263 obstack_strdup.
3264 * typeprint.c (typedef_hash_table::find_global_typedef): Use
3265 obstack_strdup.
3266 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3267 * stabsread.c (common_block_start): Use obstack_strdup.
3268 * objfiles.c (set_objfile_main_name, objfile): Use
3269 obstack_strdup.
3270 * namespace.c (add_using_directive): Use obstack_strdup.
3271 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3272 * jit.c (finalize_symtab): Use obstack_strdup.
3273 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3274 (guess_partial_die_structure_name, partial_die_info::fixup)
3275 (dwarf2_name): Use obstack_strdup.
3276 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3277 obstack_strdup.
3278 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3279 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3280 obstack_strdup.
3281 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3282
3283 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3284
3285 * unittests/help-doc-selftests.c: New file.
3286 * Makefile.in: Add the new file.
3287
3288 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3289
3290 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3291 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
3292 the full first line, except when FOR_VALUE_PREFIX. In this case,
3293 the trailing '.' is not output, and the first character is uppercased.
3294 (print_help_for_command): Update call to print_doc_line.
3295 (print_doc_of_command): Likewise.
3296 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3297 * cli/cli-option.c (append_indented_doc): Do not append newline.
3298 (build_help_option): Append newline after first appended_indented_doc
3299 only if a second call is done.
3300 (build_help): Append 2 new lines before each option, except the first
3301 one.
3302 * compile/compile.c (_initialize_compile): Add new lines after
3303 %OPTIONS%, when not at the end of the help.
3304 Change help doc or code
3305 producing the help doc to respect the invariants.
3306 * maint-test-options.c (_initialize_maint_test_options): Likewise.
3307 Also removed the new line after 'Options:', as all other commands
3308 do not put an empty line between 'Options:' and the first option.
3309 * printcmd.c (_initialize_printcmd): Likewise.
3310 * stack.c (_initialize_stack): Likewise.
3311 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3312 incorrectly telling COMMAND is optional.
3313 * ada-lang.c (_initialize_ada_language): Change help doc or code
3314 producing the help doc to respect the invariants.
3315 * ada-tasks.c (_initialize_ada_tasks): Likewise.
3316 * breakpoint.c (_initialize_breakpoint): Likewise.
3317 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3318 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3319 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3320 * cli/cli-style.c (cli_style_option::add_setshow_commands,
3321 _initialize_cli_style): Likewise.
3322 * corelow.c (core_target_info): Likewise.
3323 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3324 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3325 * filesystem.c (_initialize_filesystem): Likewise.
3326 * frame.c (_initialize_frame): Likewise.
3327 * gnu-nat.c (add_task_commands): Likewise.
3328 * infcall.c (_initialize_infcall): Likewise.
3329 * infcmd.c (_initialize_infcmd): Likewise.
3330 * interps.c (_initialize_interpreter): Likewise.
3331 * language.c (_initialize_language): Likewise.
3332 * linux-fork.c (_initialize_linux_fork): Likewise.
3333 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3334 * maint.c (_initialize_maint_cmds): Likewise.
3335 * memattr.c (_initialize_mem): Likewise.
3336 * printcmd.c (_initialize_printcmd): Likewise.
3337 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3338 _RegEx): Likewise.
3339 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3340 * record-btrace.c (_initialize_record_btrace): Likewise.
3341 * record-full.c (_initialize_record_full): Likewise.
3342 * record.c (_initialize_record): Likewise.
3343 * regcache-dump.c (_initialize_regcache_dump): Likewise.
3344 * regcache.c (_initialize_regcache): Likewise.
3345 * remote.c (add_packet_config_cmd, init_remote_threadtests,
3346 _initialize_remote): Likewise.
3347 * ser-tcp.c (_initialize_ser_tcp): Likewise.
3348 * serial.c (_initialize_serial): Likewise.
3349 * skip.c (_initialize_step_skip): Likewise.
3350 * source.c (_initialize_source): Likewise.
3351 * stack.c (_initialize_stack): Likewise.
3352 * symfile.c (_initialize_symfile): Likewise.
3353 * symtab.c (_initialize_symtab): Likewise.
3354 * target-descriptions.c (_initialize_target_descriptions): Likewise.
3355 * top.c (init_main): Likewise.
3356 * tracefile-tfile.c (tfile_target_info): Likewise.
3357 * tracepoint.c (_initialize_tracepoint): Likewise.
3358 * tui/tui-win.c (_initialize_tui_win): Likewise.
3359 * utils.c (add_internal_problem_command): Likewise.
3360 * valprint.c (value_print_option_defs): Likewise.
3361
3362 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
3363
3364 PR build/24886
3365 * configure.ac: Drop enable-libmcheck support.
3366 * configure, config.in: Rebuild.
3367 * libmcheck.m4: Remove.
3368 * acinclude.m4: Don't include it.
3369 * Makefile.in: Don't distribute it.
3370 * top.c (print_gdb_configuration): Don't mention it.
3371
3372 2019-08-06 Tom Tromey <tom@tromey.com>
3373
3374 * utils.c (set_output_style): Sometimes pass stream to
3375 emit_style_escape.
3376 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3377 * record-btrace.c (btrace_insn_history): Update.
3378 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3379 method.
3380 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3381 Update initializers.
3382 <m_uiout>: New field.
3383 <m_di>: Move lower.
3384 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3385 Remove "uiout" parameter.
3386 (dump_insns): Update.
3387 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3388 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3389
3390 2019-08-06 Christian Biesinger <cbiesinger@google.com>
3391
3392 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3393 (error_in_psymtab_expansion): Likewise.
3394 (lookup_symbol_via_quick_fns): Likewise.
3395 (basic_lookup_transparent_type_quick): Likewise.
3396 (basic_lookup_transparent_type_1): Likewise.
3397
3398 2019-08-06 Tom Tromey <tromey@adacore.com>
3399
3400 * source.c (last_source_error): Now bool.
3401 (print_source_lines_base): Make "noprint" bool. Only open
3402 source file when last_source_visited changes.
3403
3404 2019-08-06 Tom Tromey <tromey@adacore.com>
3405
3406 * annotate.c (annotate_source_line): Use g_source_cache.
3407 * source-cache.c (source_cache::get_plain_source_lines): Change
3408 parameters. Populate m_offset_cache.
3409 (source_cache::ensure): New method.
3410 (source_cache::get_line_charpos): New method.
3411 (extract_lines): Move lower. Change parameters.
3412 (source_cache::get_source_lines): Move lower.
3413 * source-cache.h (class source_cache): Update comment.
3414 <get_line_charpos>: New method.
3415 <get_source_lines>: Update comment.
3416 <clear>: Clear m_offset_cache.
3417 <get_plain_source_lines>: Change parameters.
3418 <ensure>: New method
3419 <m_offset_cache>: New member.
3420 * source.c (forget_cached_source_info_for_objfile): Update.
3421 (info_source_command): Use g_source_cache.
3422 (find_source_lines, open_source_file_with_line_charpos): Remove.
3423 (print_source_lines_base, search_command_helper): Use g_source_cache.
3424 * source.h (open_source_file_with_line_charpos): Don't declare.
3425 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3426 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3427 Use g_source_cache.
3428
3429 2019-08-06 Tom Tromey <tromey@adacore.com>
3430
3431 * source-cache.c (source_cache::get_plain_source_lines):
3432 Remove "first_line" and "last_line" parameters.
3433 (source_cache::get_source_lines): Cache plain text.
3434 * source-cache.h (class source_cache)
3435 <get_plain_source_lines>: Update.
3436
3437 2019-08-06 Tom Tromey <tromey@adacore.com>
3438
3439 * source-cache.c (extract_lines): No longer a method.
3440 Changed type of parameter. Include final newline.
3441 (selftests::extract_lines_test): New function.
3442 (_initialize_source_cache): Likewise.
3443 * source-cache.h (class source_cache)
3444 <extract_lines>: Don't declare.
3445
3446 2019-08-06 Tom Tromey <tromey@adacore.com>
3447
3448 * breakpoint.c (init_breakpoint_sal): Update.
3449 (breakpoint): Update.
3450 * breakpoint.h (struct breakpoint) <filter>: Now a
3451 unique_xmalloc_ptr.
3452
3453 2019-08-05 Christian Biesinger <cbiesinger@google.com>
3454
3455 * NEWS: Mention dictionary access on blocks.
3456 * python/py-block.c (blpy_getitem): New function.
3457 (block_object_as_mapping): New struct.
3458 (block_object_type): Use new struct for tp_as_mapping field.
3459
3460 2019-08-05 Christian Biesinger <cbiesinger@google.com>
3461
3462 * objfiles.h (objfile): Add a comment describing partial symbols.
3463
3464 2019-08-05 Tom Tromey <tromey@adacore.com>
3465
3466 * compile/compile.c (_initialize_compile): Use _(), not N_().
3467 * thread.c (_initialize_thread): Use _(), not N_().
3468 * stack.c (_initialize_stack): Use _(), not N_().
3469 * printcmd.c (_initialize_printcmd): Use _(), not N_().
3470
3471 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
3472
3473 * dwarf2read.c (struct dw2_symtab_iterator):
3474 <want_specific_block>: Remove.
3475 <block_index>: Change type to gdb::optional.
3476 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3477 change type of BLOCK_INDEX parameter to gdb::optional.
3478 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3479 (dw2_lookup_symbol): Don't pass argument for
3480 WANT_SPECIFIC_BLOCK.
3481 (dw2_expand_symtabs_for_function): Don't pass argument for
3482 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3483 (class dw2_debug_names_iterator)
3484 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3485 parameter, change BLOCK_INDEX type to gdb::optional.
3486 <m_want_specific_block>: Remove.
3487 <m_block_index>: Change type to gdb::optional.
3488 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3489 gdb::optional. Re-write in function of gdb::optional.
3490 (dw2_debug_names_lookup_symbol): Don't pass argument for
3491 WANT_SPECIFIC_BLOCK.
3492 (dw2_debug_names_expand_symtabs_for_function): Don't pass
3493 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3494 BLOCK_INDEX.
3495
3496 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3497
3498 * NEWS: Mention changes to "info sources" command.
3499
3500 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3501
3502 * symtab.c (filename_partial_match_opts): New struct type.
3503 (struct output_source_filename_data): New members
3504 regexp, c_regexp, partial_match.
3505 (output_source_filename): Use new members to decide to print file.
3506 (info_sources_option_defs): New variable.
3507 (make_info_sources_options_def_group, print_info_sources_header,
3508 info_sources_command_completer):
3509 New functions.
3510 (info_sources_command): Read new optional arguments.
3511 (_initialize_symtab): Update info sources help.
3512
3513 2019-08-02 Alexandre Oliva <oliva@adacore.com>
3514
3515 * ada-lang.c (exception_support_info_v0): Renamed from...
3516 (default_exception_support_info): ... this. Create new
3517 definition for v1.
3518 (ada_has_this_exception_support): Look up catch_handlers_sym.
3519 (ada_exception_support_info_sniffer): Try v0 after default.
3520
3521 2019-08-01 Tom Tromey <tromey@adacore.com>
3522
3523 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3524 gdbarch.h.
3525
3526 2019-08-01 Christian Biesinger <cbiesinger@google.com>
3527
3528 * s12z-tdep.c: Fix include path for s12z-opc.h.
3529
3530 2019-08-01 Alan Hayward <alan.hayward@arm.com>
3531
3532 * NEWS: Require GNU make 3.82.
3533
3534 2019-07-16 Tom Tromey <tom@tromey.com>
3535
3536 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3537 declare.
3538
3539 2019-07-30 Tom Tromey <tromey@adacore.com>
3540
3541 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3542
3543 2019-07-30 Kevin Buettner <kevinb@redhat.com>
3544
3545 * printcmd.c (print_address_symbolic): Print negative offsets.
3546 (build_address_symbolic): Force signed arithmetic when computing
3547 offset.
3548
3549 2019-07-30 Christian Biesinger <cbiesinger@google.com>
3550
3551 PR/24474: Add a function to lookup static variables.
3552 * NEWS: Mention this new function.
3553 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3554 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3555 * python/python.c (python_GdbMethods): Add new function.
3556
3557 2019-07-29 Christian Biesinger <cbiesinger@google.com>
3558
3559 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3560 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3561 (objfpy_lookup_static_symbol): New function.
3562 (objfile_object_methods): Add new functions.
3563
3564 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3565
3566 * NEWS: Mention 'set|show print frame-info'. Mention new
3567 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3568 backtrace argument. Mention that python frame filtering code
3569 is now consistent with what 'backtrace' command prints.
3570
3571 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3572
3573 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3574 comments.
3575 (print_frame_info_auto, print_frame_info_source_line,
3576 print_frame_info_location, print_frame_info_source_and_location,
3577 print_frame_info_location_and_address, print_frame_info_short_location):
3578 New declarations.
3579 (struct frame_print_options): New member print_frame_info.
3580 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3581 * stack.h (get_user_print_what_frame_info): New declaration.
3582 (frame_show_address): New declaration.
3583 * stack.c (print_frame_arguments_choices): New value 'presence'.
3584 (print_frame_info_auto, print_frame_info_source_line,
3585 print_frame_info_location, print_frame_info_source_and_location,
3586 print_frame_info_location_and_address, print_frame_info_short_location,
3587 print_frame_info_choices, print_frame_info_print_what): New definitions.
3588 (print_frame_args): Only print dots for args if print frame-arguments
3589 is 'presence'.
3590 (frame_print_option_defs): New element for "frame-info".
3591 (get_user_print_what_frame_info): New function.
3592 (frame_show_address): Make non static. Move comment to stack.h.
3593 (print_frame_info_to_print_what): New function.
3594 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3595 to decide what to print.
3596 (backtrace_command_1): Handle the new print_frame_arguments_presence
3597 value.
3598 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3599 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3600 (py_print_frame): In non-mi mode, use LOCATION as default for
3601 print_what, similarly to frame information printed directly by
3602 backtrace command. Handle frame-info user option in non MI mode.
3603
3604 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3605
3606 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3607 Add case for debugging 32-bit target on 64-bit host. Revise
3608 comment.
3609
3610 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3611
3612 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3613 instead of find_function_entry_range_from_pc.
3614
3615 2019-07-27 Kevin Buettner <kevinb@redhat.com>
3616
3617 * stack.c (find_frame_funname): Remove code which preferred
3618 minsym over symtab sym in "certain pathological cases".
3619
3620 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3621 parameter. Change type of "do_demangle" to bool.
3622 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3623 Pass suitable "prefer_sym_over_minsym" flag to
3624 build_address_symbolic(). Don't output "+" for negative offsets.
3625 * printcmd.c (print_address_symbolic): Update invocation of
3626 build_address_symbolic to include a "prefer_sym_over_minsym"
3627 flag.
3628 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3629 Restrict cases in which use of minimal symbol is preferred to that
3630 of a found symbol. Update comments.
3631
3632 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3633 for entry pc when entry pc is out of range for that FDE.
3634
3635 2019-07-26 Brian Callahan <bcallah@openbsd.org>
3636
3637 PR gdb/24839:
3638 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3639 type.
3640
3641 2019-07-25 Christian Biesinger <cbiesinger@google.com>
3642
3643 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3644 this function's Python signature.
3645
3646
3647 2019-07-24 Christian Biesinger <cbiesinger@google.com>
3648
3649 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3650 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3651 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3652 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3653 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3654
3655
3656 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3657
3658 * h8300-tdep.c (h8300_register_name_common): New.
3659 h8300_register_name): Use h8300_register_name_common.
3660 (h8300s_register_name): Likewise.
3661 (h8300sx_register_name): Likewise.
3662 (h8300h_register_nam): New.
3663 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3664
3665
3666 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3667
3668 * arm-tdep.c (arm_skip_cmse_entry): New function.
3669 (arm_is_sgstubs_section): New function.
3670 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3671
3672 2019-07-22 Tom Tromey <tom@tromey.com>
3673
3674 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3675 Don't self-assign.
3676
3677 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3678
3679 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3680 type_print.
3681
3682 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3683
3684 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3685 so that GDB doesn't match any msymbols when searching in the
3686 TYPES_DOMAIN.
3687 (print_symbol_info): Print using typedef_print or type_print based
3688 on the type of the symbol. Add updated FIXME comment moved from...
3689 (_initialize_symtab): ... move and update FIXME comment to above.
3690
3691 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3692
3693 * NEWS: Mention adding -q option to "info types".
3694 * symtab.c (struct info_types_options): New struct.
3695 (info_types_options_defs): New variable.
3696 (make_info_types_options_def_group): New function.
3697 (info_types_command): Use gdb::option framework to parse options.
3698 (info_types_command_completer): New function.
3699 (_initialize_symtab): Extend the help text on "info types" and
3700 register command completer.
3701
3702 2019-07-21 Christian Biesinger <cbiesinger@google.com>
3703
3704 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3705 (lookup_symbol_in_objfile): Change int to block_enum and add a
3706 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3707
3708 2019-07-20 Christian Biesinger <cbiesinger@google.com>
3709
3710 * MAINTAINERS (Write After Approval): Add self.
3711
3712 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3713
3714 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3715 instruction to the dummy code region.
3716
3717 2019-07-19 Tom Tromey <tromey@adacore.com>
3718
3719 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3720 (ARGSUSED, PARAMS, __func__): Remove rules.
3721
3722 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3723
3724 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3725 * features/arm/arm-with-iwmmxt.c: Remove.
3726 * features/arm/arm-with-iwmmxt.xml: Remove.
3727 * features/arm/arm-with-m-fpa-layout.c: Remove.
3728 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3729 * features/arm/arm-with-m-vfp-d16.c: Remove.
3730 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3731 * features/arm/arm-with-m.c: Remove.
3732 * features/arm/arm-with-m.xml: Remove.
3733 * features/arm/arm-with-neon.c: Remove.
3734 * features/arm/arm-with-neon.xml: Remove.
3735 * features/arm/arm-with-vfpv2.c: Remove.
3736 * features/arm/arm-with-vfpv2.xml: Remove.
3737 * features/arm/arm-with-vfpv3.c: Remove.
3738 * features/arm/arm-with-vfpv3.xml: Remove.
3739
3740 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3741
3742 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3743
3744 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3745
3746 * arch/aarch32.c (aarch32_create_target_description): Create
3747 target descriptions using features.
3748 * arch/arm.c (arm_create_target_description)
3749 (arm_create_mprofile_target_description): Likewise.
3750 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3751
3752 2019-07-19 Alan Hayward <alan.hayward@arm.com>
3753
3754 * Makefile.in: Add new files.
3755 * aarch32-tdep.c: New file.
3756 * aarch32-tdep.h: New file.
3757 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3758 Call aarch32_read_description.
3759 * arch/aarch32.c: New file.
3760 * arch/aarch32.h: New file.
3761 * arch/arm.c (arm_create_target_description)
3762 (arm_create_mprofile_target_description): New function.
3763 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3764 (arm_create_target_description)
3765 (arm_create_mprofile_target_description): New declaration.
3766 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3767 read_description functions.
3768 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3769 Likewise.
3770 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3771 * arm-tdep.c (tdesc_arm_list): New variable.
3772 (arm_register_g_packet_guesses): Call create description functions.
3773 (arm_read_description) (arm_read_mprofile_description): New
3774 function.
3775 * arm-tdep.h (arm_read_description)
3776 (arm_read_mprofile_description): Add declaration.
3777 * configure.tgt: Add new files.
3778
3779 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3780
3781 * top.c (new_ui_command): Open specified terminal just once.
3782
3783 2019-07-18 Tom Tromey <tromey@adacore.com>
3784
3785 * symtab.c (main_name): Constify return type.
3786 * symfile.c (set_initial_language): Update.
3787 * symtab.h (main_name): Constify return type.
3788
3789 2019-07-17 Tom Tromey <tom@tromey.com>
3790
3791 * tui/tui-winsource.c (tui_update_source_window)
3792 (tui_update_source_window_as_is)
3793 (tui_update_source_windows_with_line): Remove return.
3794 * tui/tui-disasm.c (tui_show_disassem)
3795 (tui_show_disassem_and_update_source): Remove return.
3796 * tui/tui.c (tui_reset): Remove return.
3797 * tui/tui-wingeneral.c
3798 (tui_check_and_display_highlight_if_needed): Remove return.
3799
3800 2019-07-17 Tom Tromey <tom@tromey.com>
3801
3802 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3803
3804 2019-07-17 Tom Tromey <tom@tromey.com>
3805
3806 * tui/tui-winsource.h (struct tui_exec_info_window)
3807 (struct tui_source_window_base): Move from tui-data.h.
3808 * tui/tui-winsource.c: Move many method definitions from
3809 elsewhere. Remove "structuring" comments.
3810 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3811 (tui_source_window_base::refresh_window): Move to
3812 tui-winsource.c.
3813 * tui/tui-win.c (tui_source_window_base::refresh_all)
3814 (tui_source_window_base::update_tab_width)
3815 (tui_source_window_base::set_new_height)
3816 (tui_source_window_base::do_make_visible_with_new_height): Move to
3817 tui-winsource.c.
3818 * tui/tui-source.h: Update.
3819 * tui/tui-source.c (tui_source_window_base::reset): Move to
3820 tui-winsource.c.
3821 * tui/tui-disasm.h: Update.
3822 * tui/tui-data.h (struct tui_exec_info_window): Move to
3823 tui-winsource.h.
3824 (struct tui_source_window_base): Likewise.
3825 * tui/tui-data.c (tui_source_window_base::clear_detail)
3826 (tui_source_window_base, ~tui_source_window_base): Move to
3827 tui-winsource.c.
3828
3829 2019-07-17 Tom Tromey <tom@tromey.com>
3830
3831 * tui/tui-win.c (tui_resize_all)
3832 (tui_source_window_base::update_tab_width)
3833 (tui_adjust_win_heights): Update.
3834 (tui_win_info::make_invisible_and_set_new_height): Rename from
3835 make_invisible_and_set_new_height.
3836 * tui/tui-data.h (struct tui_win_info)
3837 <make_invisible_and_set_new_height>: New method.
3838
3839 2019-07-17 Tom Tromey <tom@tromey.com>
3840
3841 * tui/tui.c: Update.
3842 * tui/tui-source.h (struct tui_source_window): Move from
3843 tui-data.h.
3844 * tui/tui-layout.c: Update.
3845 * tui/tui-disasm.c: Update.
3846 * tui/tui-data.h (struct tui_source_window): Move to
3847 tui-source.h.
3848
3849 2019-07-17 Tom Tromey <tom@tromey.com>
3850
3851 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3852 tui-data.h.
3853 * tui/tui-data.h (struct tui_disasm_window): Move to
3854 tui-disasm.h.
3855
3856 2019-07-17 Tom Tromey <tom@tromey.com>
3857
3858 * tui/tui-regs.h (struct tui_data_item_window): Move from
3859 tui-data.h.
3860 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3861 * tui/tui-data.h (struct tui_data_item_window): Move to
3862 tui-regs.h.
3863 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3864
3865 2019-07-17 Tom Tromey <tom@tromey.com>
3866
3867 * tui/tui.c: Update.
3868 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3869 (tui_cmd_window::max_height): Move to tui-command.c.
3870 * tui/tui-layout.c: Update.
3871 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3872 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3873 tui-command.c.
3874 * tui/tui-command.h (struct tui_cmd_window): Move from
3875 tui-data.h.
3876 * tui/tui-command.c: Remove "structuring" comments.
3877 (tui_cmd_window::clear_detail)
3878 (tui_cmd_window::do_make_visible_with_new_height)
3879 (tui_cmd_window::max_height): Move from elsewhere.
3880
3881 2019-07-17 Tom Tromey <tom@tromey.com>
3882
3883 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3884 Now static.
3885 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3886 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3887
3888 2019-07-17 Tom Tromey <tom@tromey.com>
3889
3890 * tui/tui.c: Update.
3891 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3892 tui-regs.c.
3893 * tui/tui-windata.h: Remove file.
3894 * tui/tui-windata.c: Remove file.
3895 * tui/tui-win.c (tui_data_window::set_new_height)
3896 (tui_data_window::do_make_visible_with_new_height): Move to
3897 tui-regs.c.
3898 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3899 * tui/tui-regs.c: Remove "structuring" comments.
3900 (tui_data_window::first_data_item_displayed)
3901 (tui_data_window::delete_data_content_windows)
3902 (tui_data_window::erase_data_content)
3903 (tui_data_window::display_all_data)
3904 (tui_data_window::refresh_all)
3905 (tui_data_window::do_scroll_vertical)
3906 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3907 (tui_data_window::do_make_visible_with_new_height)
3908 (tui_data_window::refresh_window): Move from elsewhere.
3909 (_initialize_tui_regs): Move to end of file.
3910 * tui/tui-layout.c: Update.
3911 * tui/tui-hooks.c: Update.
3912 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3913 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3914 tui-regs.c.
3915 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3916
3917 2019-07-17 Tom Tromey <tom@tromey.com>
3918
3919 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3920 seen.
3921
3922 2019-07-17 Tom Tromey <tom@tromey.com>
3923
3924 * tui/tui-win.c (tui_source_window_base::set_new_height)
3925 (tui_source_window_base::do_make_visible_with_new_height): Use
3926 m_has_locator field directly.
3927 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3928 method.
3929 (struct tui_source_window_base) <has_locator>: Likewise.
3930
3931 2019-07-17 Tom Tromey <tom@tromey.com>
3932
3933 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3934 Don't declare.
3935 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3936 Remove.
3937 * tui/tui-win.c (tui_source_window_base::set_new_height)
3938 (tui_source_window_base::set_new_height)
3939 (make_invisible_and_set_new_height)
3940 (tui_source_window_base::do_make_visible_with_new_height)
3941 (tui_source_window_base::do_make_visible_with_new_height):
3942 Update.
3943 * tui/tui-layout.c (show_source_disasm_command, show_data)
3944 (show_source_or_disasm_and_command): Update.
3945 * tui/tui-layout.c (show_layout): Update.
3946
3947 2019-07-17 Tom Tromey <tom@tromey.com>
3948
3949 * tui/tui-layout.c (make_data_window): Remove.
3950 (show_data): Unify creation and re-initialization cases.
3951
3952 2019-07-17 Tom Tromey <tom@tromey.com>
3953
3954 * tui/tui-layout.c (make_source_window, make_disasm_window):
3955 Remove.
3956 (show_data): Unify creation and re-initialization cases.
3957
3958 2019-07-17 Tom Tromey <tom@tromey.com>
3959
3960 * tui/tui-layout.c (make_command_window): Remove.
3961 (show_source_disasm_command, show_source_or_disasm_and_command):
3962 Unify creation and re-initialization cases.
3963
3964 2019-07-17 Tom Tromey <tom@tromey.com>
3965
3966 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3967 creation and re-initialization cases.
3968
3969 2019-07-17 Tom Tromey <tom@tromey.com>
3970
3971 * tui/tui-regs.c (tui_get_register): Return void.
3972
3973 2019-07-17 Tom Tromey <tom@tromey.com>
3974
3975 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3976 Simplify.
3977
3978 2019-07-17 Tom Tromey <tom@tromey.com>
3979
3980 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3981 resetting.
3982
3983 2019-07-17 Tom Tromey <tom@tromey.com>
3984
3985 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3986 * tui/tui-regs.c (tui_reg_layout): New function.
3987 (tui_show_registers, tui_reg_command): Use it.
3988 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3989 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3990 parameters.
3991 (tui_layout_command): Remove.
3992
3993 2019-07-17 Tom Tromey <tom@tromey.com>
3994
3995 * tui/tui-layout.h (tui/tui-layout): Return void.
3996 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3997
3998 2019-07-17 Tom Tromey <tom@tromey.com>
3999
4000 * tui/tui-layout.c (show_source_disasm_command, show_data):
4001 Update.
4002 (reset_locator): Remove.
4003 (show_source_or_disasm_and_command): Update.
4004
4005 2019-07-17 Tom Tromey <tom@tromey.com>
4006
4007 * tui/tui-source.c (tui_source_window_base::reset): Remove
4008 win_type parameter.
4009 * tui/tui-layout.c (make_command_window, make_source_window)
4010 (make_disasm_window, make_data_window)
4011 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4012 (reset_locator, show_source_or_disasm_and_command): Update.
4013 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4014 win_type parameter.
4015 (struct tui_source_window_base) <reset>: Likewise.
4016
4017 2019-07-17 Tom Tromey <tom@tromey.com>
4018
4019 * tui/tui-layout.c (show_source_disasm_command): Use
4020 reset_locator.
4021 (reset_locator): New function.
4022 (init_and_make_win): Remove.
4023 (show_source_or_disasm_and_command): Use reset_locator.
4024
4025 2019-07-17 Tom Tromey <tom@tromey.com>
4026
4027 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4028 condition.
4029 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4030 Remove condition.
4031 * tui/tui-source.c (tui_source_window_base::reset): New method.
4032 * tui/tui-layout.c (make_command_window): Don't call
4033 init_and_make_win.
4034 (make_source_window, make_disasm_window): Don't call
4035 make_source_or_disasm_window.
4036 (make_data_window): Don't call init_and_make_win. Change calling
4037 convention.
4038 (show_source_disasm_command, show_data): Simplify.
4039 (make_source_or_disasm_window): Remove.
4040 (show_source_or_disasm_and_command): Simplify.
4041 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4042 (struct tui_source_window_base) <reset>: Likewise.
4043 <execution_info>: Remove initializer.
4044 * tui/tui-data.c (tui_source_window_base): Initialize
4045 execution_info.
4046
4047 2019-07-17 Tom Tromey <tom@tromey.com>
4048
4049 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4050 variable.
4051
4052 2019-07-17 Tom Tromey <tom@tromey.com>
4053
4054 * tui/tui.c (tui_rl_other_window): Update.
4055 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4056 superclass method first. Always iterate over regs_content.
4057 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4058 method.
4059 * tui/tui-win.c (tui_set_focus_command): Update.
4060
4061 2019-07-17 Tom Tromey <tom@tromey.com>
4062
4063 * tui/tui-win.c (tui_set_focus_command): Rename from
4064 tui_set_focus. Call tui_enable.
4065 (tui_set_focus_command): Remove.
4066
4067 2019-07-17 Tom Tromey <tom@tromey.com>
4068
4069 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4070 refresh_window.
4071 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4072 touchwin.
4073 (tui_data_window::refresh_window): Call refresh_window on data
4074 items. Always call superclass refresh_window.
4075 (tui_win_info::refresh): Remove.
4076 (tui_source_window_base::refresh_window): Update.
4077 (tui_refresh_all): Update.
4078 * tui/tui-layout.c (show_source_disasm_command): Remove call to
4079 refresh_window.
4080 (show_source_or_disasm_and_command): Likewise.
4081 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4082 (struct tui_source_window_base) <refresh>: Likewise.
4083
4084 2019-07-17 Tom Tromey <tom@tromey.com>
4085
4086 * tui/tui-winsource.c (tui_clear_source_content)
4087 (tui_show_source_content): Update.
4088 * tui/tui-source.c (tui_source_window::showing_source_p): Check
4089 whether content is empty.
4090 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4091 Remove.
4092
4093 2019-07-17 Tom Tromey <tom@tromey.com>
4094
4095 * tui/tui-winsource.c (tui_erase_source_content): Clear the
4096 window's contents.
4097 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4098 * tui/tui-source.c (tui_set_source_content_nil): Remove.
4099
4100 2019-07-17 Tom Tromey <tom@tromey.com>
4101
4102 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4103 (struct tui_data_item_window): Update.
4104
4105 2019-07-17 Tom Tromey <tom@tromey.com>
4106
4107 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4108 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4109 defines.
4110
4111 2019-07-17 Tom Tromey <tom@tromey.com>
4112
4113 * tui/tui-winsource.h (tui_erase_source_content)
4114 (tui_clear_source_content): Remove "display_prompt" parameter.
4115 * tui/tui-winsource.c (tui_update_source_window_as_is)
4116 (tui_update_source_windows_with_addr): Update.
4117 (tui_clear_source_content): Remove "display_prompt" parameter.
4118 (tui_erase_source_content): Likewise. Simplify.
4119 (tui_show_source_content): Update.
4120 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4121 * tui/tui-stack.c (tui_show_frame_info): Update.
4122 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4123 Remove defines.
4124
4125 2019-07-17 Tom Tromey <tom@tromey.com>
4126
4127 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4128 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4129 parameter.
4130 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4131 parameter.
4132
4133 2019-07-17 Tom Tromey <tom@tromey.com>
4134
4135 * tui/tui-winsource.c (tui_clear_source_content)
4136 (tui_show_source_content, tui_show_exec_info_content)
4137 (tui_clear_exec_info_content): Update.
4138 * tui/tui-stack.c (tui_show_locator_content): Update.
4139 (tui_show_frame_info): Update.
4140 * tui/tui-source.h (tui_source_window): Don't declare.
4141 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4142 from tui_source_is_displayed.
4143 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4144 Remove field.
4145 (struct tui_source_window_base) <content_in_use>: New field. Now
4146 bool.
4147 (struct tui_source_window) <showing_source_p>: New method.
4148 (TUI_SRC_WIN): Change cast.
4149 * tui/tui-data.c (tui_initialize_static_data): Update.
4150
4151 2019-07-17 Tom Tromey <tom@tromey.com>
4152
4153 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4154 location_matches_p.
4155 * tui/tui-source.c (tui_source_window::location_matches_p): New
4156 method.
4157 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4158 method.
4159 * tui/tui-data.h (struct tui_source_window_base)
4160 <location_matches_p>: New method.
4161 (struct tui_source_window, struct tui_disasm_window)
4162 <location_matches_p>: Likewise.
4163
4164 2019-07-17 Tom Tromey <tom@tromey.com>
4165
4166 * tui/tui-win.c (tui_set_win_height_command): Rename from
4167 tui_set_win_height.
4168 (tui_set_win_height_command): Remove.
4169
4170 2019-07-17 Tom Tromey <tom@tromey.com>
4171
4172 * tui/tui-source.c (tui_source_window): New constructor. Add
4173 observer.
4174 (~tui_source_window): New destructor.
4175 (tui_source_window::style_changed): New method.
4176 * tui/tui-hooks.c (tui_redisplay_source): Remove.
4177 (tui_attach_detach_observers): Update.
4178 * tui/tui-data.h (struct tui_source_window): Make constructor not
4179 inline. Add destructor.
4180 (struct tui_source_window) <style_changed>: New method.
4181 <m_observable>: New member.
4182
4183 2019-07-17 Tom Tromey <tom@tromey.com>
4184
4185 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4186 * tui/tui-win.c (tui_resize_all): Fix typo.
4187
4188 2019-07-17 Tom Tromey <tom@tromey.com>
4189
4190 * tui/tui-wingeneral.h (tui_refresh_all): Update.
4191 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4192 (tui_refresh_all): Remove "list" parameter. Use foreach.
4193 * tui/tui-win.c (window_name_completer): Use foreach.
4194 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4195 (update_tab_width): Likewise.
4196 * tui/tui-layout.c (show_layout): Update.
4197 * tui/tui-data.h (class tui_window_iterator): New.
4198 (struct all_tui_windows): New.
4199 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4200
4201 2019-07-17 Tom Tromey <tom@tromey.com>
4202
4203 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4204 parameter. Don't reference globals.
4205 (tui_reg_command): Update.
4206
4207 2019-07-17 Tom Tromey <tom@tromey.com>
4208
4209 * tui/tui-regs.c (tui_show_registers): Simplify.
4210
4211 2019-07-17 Tom Tromey <tom@tromey.com>
4212
4213 * tui/tui-regs.c (tui_show_registers): Update.
4214 (tui_show_register_group): Add win_info parameter.
4215
4216 2019-07-17 Tom Tromey <tom@tromey.com>
4217
4218 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4219 Rename from tui_display_reg_element_at_line.
4220 (tui_data_window::display_registers_from_line): Update.
4221 * tui/tui-data.h (struct tui_data_window)
4222 <display_reg_element_at_line>: New method.
4223
4224 2019-07-17 Tom Tromey <tom@tromey.com>
4225
4226 * tui/tui-regs.h (tui_display_registers_from)
4227 (tui_display_registers_from_line): Don't declare.
4228 * tui/tui-windata.c (tui_data_window::display_all_data)
4229 (tui_data_window::refresh_all)
4230 (tui_data_window::do_scroll_vertical): Update.
4231 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4232 from tui_display_registers_from.
4233 (tui_display_reg_element_at_line): Update.
4234 (tui_data_window::display_registers_from_line): Rename from
4235 tui_display_registers_from_line.
4236 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4237 display_registers_from_line>: New methods.
4238
4239 2019-07-17 Tom Tromey <tom@tromey.com>
4240
4241 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4242 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4243 from tui_erase_data_content.
4244 (tui_data_window::display_all_data)
4245 (tui_data_window::refresh_all)
4246 (tui_data_window::do_scroll_vertical): Update.
4247 * tui/tui-regs.c (tui_show_registers): Update.
4248 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4249 New method.
4250
4251 2019-07-17 Tom Tromey <tom@tromey.com>
4252
4253 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4254 declare.
4255 * tui/tui-windata.c
4256 (tui_data_window::delete_data_content_windows): Rename from
4257 tui_delete_data_content_windows.
4258 (tui_data_window::display_all_data)
4259 (tui_data_window::do_scroll_vertical): Update.
4260 * tui/tui-data.h (struct tui_data_window)
4261 <delete_data_content_windows>: New method.
4262
4263 2019-07-17 Tom Tromey <tom@tromey.com>
4264
4265 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4266 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4267
4268 2019-07-17 Tom Tromey <tom@tromey.com>
4269
4270 * tui/tui-windata.h (tui_display_all_data): Don't declare.
4271 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4272 from tui_display_all_data.
4273 * tui/tui-win.c
4274 (tui_data_window::do_make_visible_with_new_height): Update.
4275 * tui/tui-regs.c (tui_show_registers): Update.
4276 * tui/tui-layout.c (tui_set_layout): Update.
4277 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4278 method.
4279
4280 2019-07-17 Tom Tromey <tom@tromey.com>
4281
4282 * tui/tui-windata.h (tui_display_data_from): Don't declare.
4283 * tui/tui-windata.c (tui_display_data_from): Remove.
4284 (tui_data_window::refresh_all): Update.
4285
4286 2019-07-17 Tom Tromey <tom@tromey.com>
4287
4288 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4289 * tui/tui-windata.c (tui_display_data_from_line): Remove.
4290 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4291 tui_display_registers_from_line.
4292 * tui/tui-regs.h (tui_display_registers_from_line): Update.
4293 * tui/tui-regs.c (tui_display_registers_from_line): Remove
4294 "force_display" parameter.
4295
4296 2019-07-17 Tom Tromey <tom@tromey.com>
4297
4298 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4299 declare.
4300 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4301 Rename from tui_first_reg_element_no_inline.
4302 (tui_display_reg_element_at_line)
4303 (tui_display_registers_from_line): Update.
4304 * tui/tui-data.h (struct tui_data_window)
4305 <first_reg_element_no_inline>: New method.
4306
4307 2019-07-17 Tom Tromey <tom@tromey.com>
4308
4309 * tui/tui-windata.c (tui_display_data_from)
4310 (tui_data_window::do_scroll_vertical): Update.
4311 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4312 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4313 Rename from tui_line_from_reg_element_no.
4314 (tui_display_registers_from_line): Update.
4315 * tui/tui-data.h (struct tui_data_window)
4316 <line_from_reg_element_no>: New method.
4317
4318 2019-07-17 Tom Tromey <tom@tromey.com>
4319
4320 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4321 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4322 tui_last_regs_line_no.
4323 (tui_display_reg_element_at_line)
4324 (tui_display_registers_from_line): Update.
4325 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4326 method.
4327
4328 2019-07-17 Tom Tromey <tom@tromey.com>
4329
4330 PR tui/24722:
4331 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4332 (tui_update_breakpoint_info): Add "being_deleted" parameter.
4333 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4334 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4335 (tui_update_breakpoint_info): Likewise.
4336 * tui/tui-hooks.c (tui_event_create_breakpoint)
4337 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4338 Update.
4339
4340 2019-07-17 Tom Tromey <tom@tromey.com>
4341
4342 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4343
4344 2019-07-17 Tom Tromey <tom@tromey.com>
4345
4346 * tui/tui-winsource.c (tui_update_source_window_as_is)
4347 (tui_update_source_windows_with_addr): Update.
4348 * tui/tui-source.h (tui_set_source_content)
4349 (tui_show_symtab_source): Add "win_info" parameter.
4350 * tui/tui-source.c (tui_set_source_content): Add "win_info"
4351 parameter.
4352 (tui_show_symtab_source): Likewise.
4353
4354 2019-07-17 Tom Tromey <tom@tromey.com>
4355
4356 * tui/tui-wingeneral.c
4357 (tui_check_and_display_highlight_if_needed): Check can_highlight.
4358
4359 2019-07-17 Tom Tromey <tom@tromey.com>
4360
4361 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4362 (struct tui_cmd_window) <can_scroll>: New method.
4363 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4364 method.
4365
4366 2019-07-17 Tom Tromey <tromey@adacore.com>
4367
4368 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4369 do_field_signed>: Rename. Change type of "value".
4370 * ui-out.c (ui_out::field_signed): Rename from field_int.
4371 Change type of "value".
4372 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
4373 type of "value".
4374 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4375 do_field_int. Change type of "value".
4376 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4377 do_field_int. Change type of "value".
4378 * tracepoint.c (trace_status_mi, tfind_1)
4379 (print_one_static_tracepoint_marker): Update.
4380 * thread.c (print_thread_info_1, print_selected_thread_frame):
4381 Update.
4382 * stack.c (print_frame, print_frame_info): Update.
4383 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4384 Update.
4385 * source.c (print_source_lines_base): Update.
4386 * skip.c (info_skip_command): Update.
4387 * record-btrace.c (btrace_ui_out_decode_error)
4388 (btrace_call_history_src_line): Update.
4389 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4390 Update.
4391 * progspace.c (print_program_space): Update.
4392 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4393 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4394 do_field_int. Change type of "value".
4395 * mi/mi-out.c (mi_ui_out::do_table_begin)
4396 (mi_ui_out::do_table_header): Update.
4397 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
4398 type of "value".
4399 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4400 (mi_cmd_data_list_changed_registers, output_register)
4401 (mi_cmd_data_read_memory, mi_load_progress)
4402 (mi_cmd_trace_frame_collected): Update.
4403 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4404 Update.
4405 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4406 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4407 (mi_cmd_var_list_children, varobj_update_one): Update.
4408 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4409 (mi_cmd_stack_list_args, list_arg_or_local): Update.
4410 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4411 * inferior.c (print_inferior): Update.
4412 * gdb_bfd.c (print_one_bfd): Update.
4413 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4414 Update.
4415 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4416 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4417 do_field_int. Change type of "value".
4418 * cli-out.c (cli_ui_out::do_field_signed): Rename from
4419 do_field_int. Change type of "value".
4420 * breakpoint.c (watchpoint_check, print_breakpoint_location)
4421 (print_one_breakpoint_location, print_it_catch_fork)
4422 (print_one_catch_fork, print_it_catch_vfork)
4423 (print_one_catch_vfork, print_it_catch_solib)
4424 (print_it_catch_exec, print_it_ranged_breakpoint)
4425 (print_mention_watchpoint, print_mention_masked_watchpoint)
4426 (bkpt_print_it, update_static_tracepoint): Update.
4427 * break-catch-throw.c (print_it_exception_catchpoint): Update.
4428 * break-catch-syscall.c (print_it_catch_syscall): Update.
4429 * ada-tasks.c (print_ada_task_info): Update.
4430 * ada-lang.c (print_it_exception, print_mention_exception):
4431 Update.
4432
4433 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
4434
4435 PR breakpoints/24541
4436 * gdbarch.c: Regenerate.
4437 * gdbarch.h: Regenerate.
4438 * gdbarch.sh: Adjust return type and parameter types for
4439 'stap_adjust_register'.
4440 (i386_stap_adjust_register): Adjust signature and return new
4441 register name.
4442 * stap-probe.c (stap_parse_register_operand): Adjust use of
4443 'gdbarch_stap_adjust_register'.
4444
4445 2019-07-17 Tom Tromey <tromey@adacore.com>
4446
4447 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
4448 declare VEC.
4449 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4450 std::vector.
4451 (struct s390_process_info): Add initializers.
4452 (s390_add_process): Use new.
4453 (s390_linux_nat_target::low_forget_process): Use delete.
4454 (s390_linux_nat_target::low_new_fork)
4455 (s390_linux_nat_target::stopped_by_watchpoint)
4456 (s390_linux_nat_target::low_prepare_to_resume)
4457 (s390_linux_nat_target::insert_watchpoint)
4458 (s390_linux_nat_target::insert_hw_breakpoint)
4459 (s390_linux_nat_target::remove_watchpoint)
4460 (s390_linux_nat_target::remove_hw_breakpoint): Update.
4461
4462 2019-07-16 John Baldwin <jhb@FreeBSD.org>
4463
4464 * aarch64-fbsd-nat.c: Include regcache.h.
4465 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4466 argument.
4467 (aarch64_fbsd_nat_target::fetch_registers)
4468 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4469 variable.
4470 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4471
4472 2019-07-16 John Baldwin <jhb@FreeBSD.org>
4473
4474 * fbsd-nat.c: Include gdbarch.h.
4475
4476 2019-07-15 Tom Tromey <tromey@adacore.com>
4477
4478 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4479
4480 2019-07-15 Tom Tromey <tromey@adacore.com>
4481
4482 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4483 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4484 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4485 * cli-out.c (cli_ui_out::do_field_int): New method.
4486 * ui-out.c (ui_out::field_unsigned): New method.
4487 * symfile.c (generic_load): Use field_unsigned.
4488 (print_transfer_performance): Likewise.
4489 * record-btrace.c (ui_out_field_uint): Remove.
4490 (btrace_call_history_insn_range, btrace_call_history): Use
4491 field_unsigned.
4492 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4493 field_unsigned.
4494 * ui-out.h (class ui_out) <field_unsigned>: New method.
4495 <do_field_unsigned>: Likewise.
4496
4497 2019-07-15 Tom Tromey <tromey@adacore.com>
4498
4499 * mi/mi-main.c (list_available_thread_groups): Use field_string.
4500 * mi/mi-interp.c (mi_memory_changed): Use field_string.
4501 * target.c (flash_erase_command): Use field_string.
4502 * infrun.c (print_signal_received_reason): Use field_string.
4503 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4504 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4505 field_string.
4506 * ada-tasks.c (print_ada_task_info): Use field_string.
4507
4508 2019-07-15 Tom Tromey <tromey@adacore.com>
4509
4510 * target.c (flash_erase_command): Use field_core_addr.
4511 * symfile.c (generic_load): Use field_core_addr.
4512 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4513 Use field_core_addr.
4514 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4515 field_core_addr.
4516
4517 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4518
4519 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4520 value if its desired type is smaller than a CORE_ADDR and signed.
4521
4522 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4523
4524 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4525 of changes to field names, and use new is_reference field to
4526 decide if a property is a reference or not.
4527 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4528 field.
4529 (struct dwarf2_property_baton): Update header comment, rename
4530 'referenced_type' to 'property_type' and update comments.
4531 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4532 default property type, store in property baton, update to take
4533 accound of renamed field.
4534 (read_func_scope): Update call to attr_to_dynamic_prop.
4535 (read_array_type): Likewise.
4536 (dwarf2_per_cu_addr_sized_int_type): New function.
4537 (read_subrange_index_type): Move type finding code to
4538 dwarf2_per_cu_addr_sized_int_type.
4539 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4540 (dwarf2_per_cu_addr_type): New function.
4541 (set_die_type): Update calls to attr_to_dynamic_prop.
4542
4543 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4544
4545 * dwarf2read.c (read_subrange_index_type): New function.
4546 (read_subrange_type): Move code into new function and call it.
4547 * gdbtypes.c (create_range_type): Add some asserts.
4548
4549 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4550
4551 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4552 update return statements.
4553 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4554 declaration, and update comment to match.
4555 * gdbtypes.c (resolve_dynamic_array): Update call to
4556 dwarf2_evaluate_property to match new return type.
4557
4558 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4559
4560 * valarith.c (value_subscripted_rvalue): Change lowerbound
4561 parameter type from int to LONGEST.
4562 * value.h (value_subscripted_rvalue): Likewise in declaration.
4563
4564 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4565
4566 * cli/cli-utils.c (info_print_command_completer): New function.
4567 * cli/cli-utils.h: Add 'completer.h' include, and forward
4568 declaration for 'struct cmd_list_element'.
4569 (info_print_command_completer): Declare.
4570 * stack.c (_initialize_stack): Add completer for 'info locals' and
4571 'info args'.
4572 * symtab.c (_initialize_symtab): Add completer for 'info
4573 variables' and 'info functions'.
4574 * NEWS: Mention completion for additional info commands.
4575
4576 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4577
4578 * cli/cli-utils.c (extract_info_print_args): Delete.
4579 (extract_arg_maybe_quoted): Delete.
4580 (info_print_options_defs): New variable.
4581 (make_info_print_options_def_group): New function.
4582 (extract_info_print_options): Define new function.
4583 * cli/cli-utils.h (extract_info_print_args): Delete.
4584 (struct info_print_options): New structure.
4585 (extract_info_print_options): Declare new function.
4586 * stack.c (info_locals_command): Update to use new
4587 extract_info_print_options, also add a header comment.
4588 (info_args_command): Likewise.
4589 * symtab.c (info_variables_command): Likewise.
4590 (info_functions_command): Likewise.
4591
4592 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4593
4594 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4595 to extract string arguments.
4596 * common/common-utils.c (extract_string_maybe_quoted): New function.
4597 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4598
4599 2019-07-11 Tom Tromey <tromey@adacore.com>
4600
4601 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4602 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4603 * top.h (gdbinit): Don't declare.
4604 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4605 into...
4606 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4607 * top.c (gdb_init): Don't call init_cli_cmds.
4608 (gdbinit): Remove.
4609 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4610
4611 2019-07-11 Tom Tromey <tromey@adacore.com>
4612
4613 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4614 after it has been moved.
4615
4616 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4617
4618 * valops.c (value_must_coerce_to_target): Change return type to
4619 bool.
4620 * value.h (value_must_coerce_to_target): Likewise.
4621
4622 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
4623
4624 * breakpoint.c (is_hardware_watchpoint): Remove
4625 forward-declaration.
4626 (is_masked_watchpoint): Change return type to bool.
4627 (is_tracepoint): Likewise.
4628 (is_breakpoint): Likewise.
4629 (is_hardware_watchpoint): Likewise.
4630 (is_watchpoint): Likewise.
4631 (is_no_memory_software_watchpoint): Likewise.
4632 (is_catchpoint): Likewise.
4633 (breakpoint_1): Make FILTER parameter's return type bool.
4634 is_masked_watchpoint): Change return type to bool.
4635 (save_breakpoints): Make FILTER parameter's return type bool.
4636 * breakpoint.h (is_breakpoint): Change return type to bool.
4637 (is_watchpoint): Likewise.
4638 (is_catchpoint): Likewise.
4639 (is_tracepoint): Likewise.
4640
4641 2019-07-10 Tom Tromey <tom@tromey.com>
4642
4643 * defs.h: Don't include gdbarch.h.
4644 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4645 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4646 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4647 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4648 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4649 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4650 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4651 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4652 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4653 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4654 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4655 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4656 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4657 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4658 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4659 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4660 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4661 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4662 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4663 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4664 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4665 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4666 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4667 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4668 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4669 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4670 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4671
4672 2019-07-10 Tom Tromey <tromey@adacore.com>
4673
4674 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4675 * breakpoint.c (init_ada_exception_breakpoint): Register as
4676 bp_catchpoint.
4677 (print_one_breakpoint_location, print_one_breakpoint): Use
4678 is_ada_exception_catchpoint.
4679 * ada-lang.c (class ada_catchpoint_location): Pass
4680 bp_loc_software_breakpoint to bp_location constructor.
4681 (is_ada_exception_catchpoint): New function.
4682
4683 2019-07-10 Tom Tromey <tromey@adacore.com>
4684
4685 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4686 VEC.
4687 (struct arm_exidx_entry): New method operator<.
4688 (struct arm_exidx_data) <section_maps>: Change type.
4689 (arm_exidx_data_free): Remove.
4690 (arm_exidx_data_key): Change type. Move lower.
4691 (arm_exidx_new_objfile): Update.
4692 (arm_compare_exidx_entries): Remove.
4693 (arm_find_exidx_entry, _initialize_arm_tdep)
4694
4695 2019-07-10 Tom Tromey <tromey@adacore.com>
4696
4697 * solib-spu.c (ocl_program_data_key): Change type.
4698 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4699 Update.
4700
4701 2019-07-10 Tom Tromey <tromey@adacore.com>
4702
4703 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4704 (struct solib_aix_inferior_data) <library_list>: Change type.
4705 (solib_aix_inferior_data_handle): Change type.
4706 (get_solib_aix_inferior_data): Update.
4707 (solib_aix_free_library_list): Remove.
4708 (library_list_start_library): Update.
4709 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4710 return type.
4711 (solib_aix_get_library_list)
4712 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4713 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4714
4715 2019-07-10 Tom Tromey <tromey@adacore.com>
4716
4717 * solib-dsbt.c (struct dsbt_info): Add initializers.
4718 (solib_dsbt_pspace_data): Change type.
4719 (dsbt_pspace_data_cleanup): Remove.
4720 (get_dsbt_info, _initialize_dsbt_solib): Update.
4721
4722 2019-07-10 Tom Tromey <tromey@adacore.com>
4723
4724 * spu-tdep.c (spu_overlay_data): Change type.
4725 (spu_get_overlay_table, spu_overlay_new_objfile)
4726 (_initialize_spu_tdep): Update.
4727
4728 2019-07-10 Tom Tromey <tromey@adacore.com>
4729
4730 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4731 destructor.
4732 (dbx_objfile_data_key): Change type and declare later.
4733 (DBX_SYMFILE_INFO): Rewrite.
4734 * dbxread.c (dbx_objfile_data_key): Change type.
4735 (dbx_symfile_init): Update.
4736 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4737 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4738 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4739
4740 2019-07-10 Tom Tromey <tromey@adacore.com>
4741
4742 * jit.c (jit_program_space_key): Change type. Move lower.
4743 (get_jit_program_space_data): Update.
4744 (jit_program_space_data_cleanup): Remove.
4745 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4746 Update.
4747 (struct jit_program_space_data): Add initializers.
4748
4749 2019-07-10 Tom Tromey <tromey@adacore.com>
4750
4751 * solib-darwin.c (struct darwin_info): Add initializers.
4752 (solib_darwin_pspace_data): Change type.
4753 (darwin_pspace_data_cleanup): Remove.
4754 (get_darwin_info, _initialize_darwin_solib): Update.
4755
4756 2019-07-10 Tom Tromey <tromey@adacore.com>
4757
4758 * remote-sim.c (struct sim_inferior_data): Add initializers,
4759 constructor, and destructor.
4760 (sim_inferior_data_key): Change type. Move lower.
4761 (check_for_duplicate_sim_descriptor): Update.
4762 (get_sim_inferior_data): Use new. Update.
4763 (~sim_inferior_data_cleanup): Rename from
4764 sim_inferior_data_cleanup. Simplify.
4765 (gdbsim_close_inferior, simulator_command)
4766 (sim_command_completer, _initialize_remote_sim): Update.
4767 (next_pid, INITIAL_PID): Move earlier.
4768
4769 2019-07-10 Tom Tromey <tromey@adacore.com>
4770
4771 * python/python-internal.h (create_thread_object): Return
4772 gdbpy_ref.
4773 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4774 * python/py-inferior.c (struct threadlist_entry): Add
4775 constructor.
4776 <thread_obj>: Now a gdbpy_ref.
4777 (thread_to_thread_object): Update.
4778 (add_thread_object): Use new.
4779 (delete_thread_object): Use delete.
4780 (infpy_threads): Update.
4781 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4782 GIL.
4783
4784 2019-07-10 Tom Tromey <tromey@adacore.com>
4785
4786 * valops.c (value_cast): Specialize error message for Ada.
4787
4788 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4789
4790 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4791
4792 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4793
4794 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4795 bpstat_should_step): Return bool, adjust comments.
4796 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4797 bpstat_should_step): Likewise.
4798
4799 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4800
4801 * features/Makefile: Use feature target descriptions for Arm.
4802 * features/arm/arm-core.c: Generate new file.
4803 * features/arm/arm-fpa.c: Likewise.
4804 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4805 * features/arm/arm-m-profile.c: Likewise.
4806 * features/arm/arm-vfpv2.c: Likewise.
4807 * features/arm/arm-vfpv3.c: Likewise.
4808 * features/arm/xscale-iwmmxt.c: Likewise.
4809 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4810
4811 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4812
4813 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4814 ptrace earlier.
4815
4816 2019-07-10 Alan Hayward <alan.hayward@arm.com>
4817
4818 * features/aarch64-pauth.c: Regenerate.
4819
4820 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4821
4822 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4823 bool.
4824 (bpstat_what): Use false instead of 0.
4825
4826 2019-07-09 Pedro Alves <palves@redhat.com>
4827
4828 * break-catch-throw.c (is_exception_catchpoint): New.
4829 * breakpoint.c (print_one_breakpoint_location): New parameter
4830 'raw_loc'. Handle it. Use
4831 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4832 looking at the breakpoint's type.
4833 (print_one_breakpoint): If handling "maint info breakpoints", also
4834 print locations of exception catchpoints.
4835 * breakpoint.h (is_exception_catchpoint): Declare.
4836
4837 2019-07-09 Pedro Alves <palves@redhat.com>
4838
4839 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4840 "addr" field.
4841 (allocate_location_exception_catchpoint): New.
4842 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4843 (initialize_throw_catchpoint_ops): Install
4844 allocate_location_exception_catchpoint as allocate_location
4845 method.
4846 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4847 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4848 bp_loc_other.
4849 (breakpoint_address_is_meaningful): Delete.
4850 (bl_address_is_meaningful): New.
4851 (breakpoint_locations_match): Adjust comment.
4852 (bp_location_from_bp_type): New, factored out of...
4853 (bp_location::bp_location(breakpoint *)): ... this.
4854 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4855 factored out of...
4856 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4857 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4858 breakpoint_address_is_meaningful.
4859 (bp_locations_compare): Adjust comment.
4860 (update_global_location_list): Use bl_address_is_meaningful
4861 instead of breakpoint_address_is_meaningful.
4862 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4863 explicit.
4864 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4865 * python/py-breakpoint.c (bppy_get_location): No longer check
4866 whether location is null.
4867
4868 2019-07-09 Pedro Alves <palves@redhat.com>
4869
4870 PR c++/15468
4871 * breakpoint.c (print_one_breakpoint_location): Remove
4872 single-location assert.
4873
4874 2019-07-09 Tom Tromey <tom@tromey.com>
4875
4876 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4877 * configure: Rebuild.
4878 * configure.ac: Change common to gdbsupport.
4879 * gdbsupport: Rename from common.
4880 * acinclude.m4: Change common to gdbsupport.
4881 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4882 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4883 gdbsupport.
4884 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4885 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4886 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4887 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4888 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4889 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4890 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4891 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4892 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4893 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4894 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4895 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4896 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4897 coff-pe-read.c, command.h, compile/compile-c-support.c,
4898 compile/compile-c.h, compile/compile-cplus-symbols.c,
4899 compile/compile-cplus-types.c, compile/compile-cplus.h,
4900 compile/compile-loc2c.c, compile/compile.c, completer.c,
4901 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4902 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4903 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4904 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4905 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4906 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4907 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4908 features/aarch64-core.c, features/aarch64-fpu.c,
4909 features/aarch64-pauth.c, features/aarch64-sve.c,
4910 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4911 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4912 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4913 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4914 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4915 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4916 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4917 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4918 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4919 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4920 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4921 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4922 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4923 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4924 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4925 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4926 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4927 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4928 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4929 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4930 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4931 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4932 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4933 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4934 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4935 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4936 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4937 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4938 minsyms.c, mips-linux-tdep.c, namespace.h,
4939 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4940 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4941 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4942 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4943 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4944 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4945 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4946 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4947 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4948 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4949 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4950 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4951 procfs.c, producer.c, progspace.h, psymtab.h,
4952 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4953 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4954 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4955 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4956 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4957 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4958 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4959 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4960 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4961 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4962 target-memory.c, target.c, target.h, target/waitstatus.c,
4963 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4964 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4965 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4966 unittests/array-view-selftests.c,
4967 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4968 unittests/common-utils-selftests.c,
4969 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4970 unittests/format_pieces-selftests.c,
4971 unittests/function-view-selftests.c,
4972 unittests/lookup_name_info-selftests.c,
4973 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4974 unittests/mkdir-recursive-selftests.c,
4975 unittests/observable-selftests.c,
4976 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4977 unittests/parse-connection-spec-selftests.c,
4978 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4979 unittests/scoped_fd-selftests.c,
4980 unittests/scoped_mmap-selftests.c,
4981 unittests/scoped_restore-selftests.c,
4982 unittests/string_view-selftests.c, unittests/style-selftests.c,
4983 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4984 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4985 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4986 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4987 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4988 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4989
4990 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4991
4992 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4993 bool value.
4994 (decode_digits_ordinary): Set explicit_line field in sal.
4995 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4996 symtab_and_line that was set on an explicit line number in
4997 assembler code. Do always update the recorded symtab and line if
4998 we do skip the prologue.
4999
5000 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
5001
5002 * breakpoint.c (set_breakpoint_location_function): Remove
5003 explicit_loc parameter.
5004 (momentary_breakpoint_from_master): Update call to
5005 set_breakpoint_location_function.
5006 (add_location_to_breakpoint): Likewise.
5007
5008 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
5009
5010 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5011 required features based on default bfd type when no specific bfd
5012 is present.
5013
5014 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5015
5016 * NEWS: Mention that GDB printf and eval commands can now print
5017 C-style and Ada-style convenience var strings without
5018 calling the inferior.
5019 * printcmd.c (printf_c_string): Locally print GDB internal var
5020 instead of transiting via the inferior.
5021 (printf_wide_c_string): Likewise.
5022
5023 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5024
5025 PR breakpoints/25011
5026 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5027
5028 2019-07-04 Tom Tromey <tom@tromey.com>
5029
5030 PR tui/24724:
5031 * tui/tui-winsource.c (tui_clear_source_content): Update.
5032 (tui_source_window_base::set_is_exec_point_at): Fix comment.
5033 (tui_update_breakpoint_info): Update.
5034 (tui_set_exec_info_content): Update.
5035 * tui/tui-source.c (tui_set_source_content_nil): Update.
5036 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5037 has_break.
5038 * tui/tui-data.h (enum tui_bp_flag): New.
5039 (tui_bp_flags): New enum flags type.
5040 (struct tui_source_element) <break_mode>: Change type. Rename
5041 from has_break.
5042 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5043 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
5044 constants.
5045 * tui/tui-winsource.h: Fix comment.
5046
5047 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5048
5049 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5050 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5051 (store_fpregs_to_thread)
5052 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5053 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5054 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5055 (IWMMXT_REGS_SIZE): Add define.
5056 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5057 (fetch_vfp_regs, store_vfp_regs)
5058 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5059 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5060
5061 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5062
5063 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5064 defines.
5065 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5066 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5067 (ARM_INT_REGISTER_SIZE): ...to this.
5068 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5069 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5070 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5071 (arm_linux_collect_gregset, supply_nwfpe_register)
5072 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5073 defines.
5074 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5075 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5076 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5077 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5078 (arm_return_in_memory, arm_store_return_value)
5079 (arm_get_longjmp_target, arm_register_g_packet_guesses)
5080 (arm_record_ld_st_multiple): Likewise.
5081 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5082 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5083
5084 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5085
5086 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5087 AARCH64_DISPLACED_MODIFIED_INSNS.
5088 * aarch64-tdep.c (struct aarch64_displaced_step_data)
5089 (aarch64_displaced_step_copy_insn): Likewise.
5090 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5091 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5092 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5093 ARM_DISPLACED_MODIFIED_INSNS.
5094 * arm-tdep.c (arm_gdbarch_init): Likewise.
5095 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5096 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5097 (struct arm_displaced_step_closure): Use
5098 ARM_DISPLACED_MODIFIED_INSNS.
5099
5100 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5101
5102 * features/Makefile: Remove unused xml files.
5103 * features/aarch64.xml: Remove.
5104 * features/i386/amd64-avx-avx512-linux.xml: Remove.
5105 * features/i386/amd64-avx-avx512.xml: Remove.
5106 * features/i386/amd64-avx-linux.xml: Remove.
5107 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5108 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5109 * features/i386/amd64-avx-mpx-linux.xml: Remove.
5110 * features/i386/amd64-avx-mpx.xml: Remove.
5111 * features/i386/amd64-avx.xml: Remove.
5112 * features/i386/amd64-linux.xml: Remove.
5113 * features/i386/amd64-mpx-linux.xml: Remove.
5114 * features/i386/amd64-mpx.xml: Remove.
5115 * features/i386/amd64.xml: Remove.
5116 * features/i386/i386-avx-avx512-linux.xml: Remove.
5117 * features/i386/i386-avx-avx512.xml: Remove.
5118 * features/i386/i386-avx-linux.xml: Remove.
5119 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5120 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5121 * features/i386/i386-avx-mpx-linux.xml: Remove.
5122 * features/i386/i386-avx-mpx.xml: Remove.
5123 * features/i386/i386-avx.xml: Remove.
5124 * features/i386/i386-linux.xml: Remove.
5125 * features/i386/i386-mmx-linux.xml: Remove.
5126 * features/i386/i386-mmx.xml: Remove.
5127 * features/i386/i386-mpx-linux.xml: Remove.
5128 * features/i386/i386-mpx.xml: Remove.
5129 * features/i386/i386.xml: Remove.
5130 * features/i386/x32-avx-avx512-linux.xml: Remove.
5131 * features/i386/x32-avx-linux.xml: Remove.
5132 * features/i386/x32-linux.xml: Remove.
5133
5134 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5135
5136 * regformats/aarch64.dat: Remove.
5137 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5138 * regformats/i386/amd64-avx-linux.dat: Remove.
5139 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5140 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5141 * regformats/i386/amd64-linux.dat: Remove.
5142 * regformats/i386/amd64-mpx-linux.dat: Remove.
5143 * regformats/i386/amd64.dat: Remove.
5144 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5145 * regformats/i386/i386-avx-linux.dat: Remove.
5146 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5147 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5148 * regformats/i386/i386-linux.dat: Remove.
5149 * regformats/i386/i386-mmx-linux.dat: Remove.
5150 * regformats/i386/i386-mpx-linux.dat: Remove.
5151 * regformats/i386/i386.dat: Remove.
5152 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5153 * regformats/i386/x32-avx-linux.dat: Remove.
5154 * regformats/i386/x32-linux.dat: Remove.
5155
5156 2019-07-04 Alan Hayward <alan.hayward@arm.com>
5157
5158 * aarch64-tdep.c: Remove xml self tests.
5159 * amd64-linux-tdep.c: Likewise.
5160 * amd64-tdep.c: Likewise.
5161 * i386-linux-tdep.c: Likewise.
5162 * i386-tdep.c: Likewise.
5163
5164 2019-07-03 Pedro Alves <palves@redhat.com>
5165
5166 PR cli/24732
5167 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5168 (pipe_cmd_option_defs): New.
5169 (make_pipe_cmd_options_def_group): New.
5170 (pipe_command): Use gdb::option::process_options.
5171 (pipe_command_completer): New function.
5172 (_initialize_cli_cmds): Install completer for "pipe" command.
5173
5174 2019-07-03 Pedro Alves <palves@redhat.com>
5175
5176 * cli/cli-option.c (union option_value) <string>: New field.
5177 (struct option_def_and_value): Add ctor, move ctor, dtor and
5178 use DISABLE_COPY_AND_ASSIGN.
5179 (option_def_and_value::clear_value): New.
5180 (parse_option, save_option_value_in_ctx, get_val_type_str)
5181 (add_setshow_cmds_for_options): Handle var_string.
5182 * cli-option.h (union option_def::var_address) <string>: New
5183 field.
5184 (struct string_option_def): New.
5185 * maint-test-options.c (struct test_options_opts): Add default
5186 ctor and use DISABLE_COPY_AND_ASSIGN.
5187 <string_opt>: New field.
5188 (test_options_opts::~test_options_opts): New.
5189 (test_options_opts::dump): Also dump "-string".
5190 (test_options_option_defs): Install "string.
5191
5192 2019-07-03 Pedro Alves <palves@redhat.com>
5193
5194 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5195 option_value with a null enumeration.
5196 (complete_options): Save the option values in the context.
5197 (save_option_value_in_ctx): New, factored out from ...
5198 (process_options): ... here.
5199 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5200 of the function.
5201 * maint-test-options.c (test_options_opts::dump): New, factored
5202 out from ...
5203 (maintenance_test_options_command_mode): ... here.
5204 (maintenance_test_options_command_completion_result): Delete.
5205 (maintenance_test_options_command_completion_text): Update
5206 comment.
5207 (maintenance_show_test_options_completion_result): Change
5208 prototype. Just print
5209 maintenance_test_options_command_completion_text.
5210 (save_completion_result): New.
5211 (maintenance_test_options_completer_mode): Pass options context to
5212 complete_options, and then save a dump.
5213 (_initialize_maint_test_options): Use add_cmd to install "maint
5214 show test-options-completion-result".
5215
5216 2019-07-03 Pedro Alves <palves@redhat.com>
5217
5218 * NEWS (New commands): Mention "with" and "maint with".
5219 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5220 (with_command, with_command_completer): New.
5221 (pipe_command): Adjust to new repeat_previous
5222 interface.
5223 (_initialize_cli_cmds): Install the "with" command and its "w"
5224 alias.
5225 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5226 declarations.
5227 * cli/cli-setshow.c (parse_cli_var_uinteger)
5228 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5229 argument strings for all var_types.
5230 (get_setshow_command_value_string): New, factored out from ...
5231 (do_show_command): ... this.
5232 * cli/cli-setshow.h: Include <string>.
5233 (get_setshow_command_value_string): Declare.
5234 * command.h (repeat_previous): Now returns const char *. Adjust
5235 comment.
5236 * maint.c: Include "cli/cli-cmds.h".
5237 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5238 (_initialize_maint_cmds): Register the "maintenance with" command.
5239 * top.c (repeat_previous): Move bits from pipe_command here:
5240 Return the saved command line, if any; error out if there's no
5241 command to relaunch.
5242
5243 2019-07-03 Pedro Alves <palves@redhat.com>
5244
5245 * NEWS (New commands): Mention "maint set/show test-settings"
5246 instead of "maint test-settings".
5247 * maint-test-settings.c (maintenance_test_settings_list): Delete.
5248 (maintenance_test_settings_set_list): Rename to ...
5249 (maintenance_set_test_settings_list): ... this.
5250 (maintenance_test_settings_show_list): Rename to ...
5251 (maintenance_show_test_settings_list): ... this.
5252 (maintenance_test_settings_cmd): Delete.
5253 (maintenance_test_settings_set_cmd): ...
5254 (maintenance_set_test_settings_cmd): ... this.
5255 (maintenance_test_settings_show_cmd): ...
5256 (maintenance_show_test_settings_cmd): ... this.
5257 (maintenance_test_settings_show_value_cmd):
5258 (maintenance_show_test_settings_value_cmd): ... this.
5259 (_initialize_maint_test_settings): No longer install the "maint
5260 test-settings" prefix command. Rename "maint test-settings set"
5261 to "maint set test-settings", and "maint test-settings show" to
5262 "maint show test-settings". Adjust all subcommands.
5263
5264 2019-07-03 Pedro Alves <palves@redhat.com>
5265
5266 * maint-test-settings.c: Fix file's intro comment. Replace all
5267 references to "test-options" with references to "test-settings",
5268 in comments.
5269
5270 2019-07-03 Pedro Alves <palves@redhat.com>
5271
5272 * maint-test-settings.c (maintenance_test_settings_xxx)
5273 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5274 New.
5275 (maintenance_test_settings_enums): Use them.
5276 (maintenance_test_settings_enum): Default to
5277 maintenance_test_settings_xxx.
5278 (_initialize_maint_test_settings): Initialize
5279 MAINTENANCE_TEST_SETTINGS_FILENAME.
5280
5281 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5282
5283 * breakpoint.h (remove_breakpoints_inf): Change return type to
5284 void, move function documentation here.
5285 * breakpoint.c (remove_breakpoints_inf): Change return type to
5286 void, move function documentation to header.
5287
5288 2019-07-02 Pedro Alves <palves@redhat.com>
5289
5290 * NEWS (Completion improvements): Mention "info threads".
5291 * thread.c (struct info_threads_opts, info_threads_option_defs)
5292 (make_info_threads_options_def_group): New.
5293 (info_threads_command): Use gdb::option::process_options.
5294 (info_threads_command_completer): New.
5295 (_initialize_thread): Use gdb::option::build_help to build the
5296 help text for "info threads".
5297
5298 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
5299
5300 * defs.h (generic_load): Move from here...
5301 * symfile.h (generic_load): ... to here. Rename name parameter
5302 to args.
5303 * symfile.c (generic_load): Add comment.
5304
5305 2019-07-01 Tom Tromey <tromey@adacore.com>
5306
5307 * dwarf2read.c
5308 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5309 declaration of without_params. Fix formatting.
5310
5311 2019-07-01 Tom Tromey <tromey@adacore.com>
5312
5313 * ada-exp.y (find_primitive_type): Update.
5314 * ada-lang.h (ada_lookup_symbol): Update.
5315 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5316 parameter.
5317 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5318
5319 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5320
5321 PR breakpoints/24541
5322 * gdbarch.c: Regenerate.
5323 * gdbarch.h: Regenerate.
5324 * gdbarch.sh: Add 'stap_adjust_register'.
5325 * i386-tdep.c: Include '<unordered_set>'.
5326 (i386_stap_adjust_register): New function.
5327 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5328 * stap-probe.c (stap_parse_register_operand): Call
5329 'gdbarch_stap_adjust_register'.
5330
5331 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
5332
5333 PR python/24742
5334 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5335 * python/python.c (do_start_initialization): Use 'xmalloc'
5336 instead of 'PyMem_Malloc'.
5337
5338 2019-06-28 Tom Tromey <tromey@adacore.com>
5339
5340 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5341 for Ada.
5342
5343 2019-06-27 Tom Tromey <tromey@adacore.com>
5344
5345 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
5346 objfile_key.
5347 (arm_find_mapping_symbol, arm_record_special_symbol)
5348 (_initialize_arm_tdep): Update.
5349 (arm_objfile_data_free): Remove.
5350
5351 2019-06-27 Tom Tromey <tromey@adacore.com>
5352
5353 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5354 to cp_print_static_field.
5355
5356 2019-06-26 Tom Tromey <tromey@adacore.com>
5357
5358 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5359 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5360 declare.
5361
5362 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5363
5364 * features/aarch64-core.c (create_feature_aarch64_core):
5365 Regenerate.
5366 * features/aarch64-core.xml: Add cpsr flags.
5367
5368 2019-06-26 Alan Hayward <alan.hayward@arm.com>
5369
5370 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5371 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5372
5373 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5374
5375 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5376 field.
5377 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5378 use.
5379 (arm_record_special_symbol): Don't insert new symbol in sorted
5380 position, push it at the end.
5381
5382 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
5383
5384 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5385 (arm_mapping_symbol_s): Remove.
5386 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5387 (arm_mapping_symbol_vec): New typedef.
5388 (struct arm_per_objfile): Add constructor.
5389 <section_maps>: Change type to
5390 std::unique_ptr<arm_mapping_symbol_vec[]>.
5391 (arm_compare_mapping_symbols): Remove.
5392 (arm_find_mapping_symbol): Adjust to section_maps type change.
5393 (arm_objfile_data_free): Call delete on arm_per_objfile.
5394 (arm_record_special_symbol): Adjust to section_maps type change.
5395 Allocate arm_per_objfile with new.
5396
5397 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5398
5399 * cli/cli-cmds.c (alias_command): Compare the alias prefix
5400 with the command prefix.
5401
5402 2019-06-25 Tom Tromey <tom@tromey.com>
5403
5404 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5405 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5406
5407 2019-06-25 Tom Tromey <tom@tromey.com>
5408
5409 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5410 type.
5411 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5412 protected.
5413
5414 2019-06-25 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-winsource.c
5417 (tui_source_window_base::set_is_exec_point_at): Add check against
5418 LOA_ADDRESS.
5419
5420 2019-06-25 Tom Tromey <tom@tromey.com>
5421
5422 * tui/tui-source.c (tui_set_source_content): Don't check before
5423 xfree.
5424 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5425
5426 2019-06-25 Tom Tromey <tom@tromey.com>
5427
5428 * tui/tui-winsource.h (tui_update_source_window_as_is)
5429 (tui_alloc_source_buffer, tui_line_is_displayed)
5430 (tui_addr_is_displayed): Change type of win_info.
5431 * tui/tui-winsource.c (tui_update_source_window_as_is)
5432 (tui_clear_source_content, tui_show_source_line)
5433 (tui_show_source_content, tui_source_window_base::refill)
5434 (tui_source_window_base::set_is_exec_point_at)
5435 (tui_source_window_base::set_is_exec_point_at)
5436 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5437 (tui_alloc_source_buffer, tui_line_is_displayed)
5438 (tui_addr_is_displayed): Change type of win_info. Update.
5439 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5440 (tui_source_window_base::do_make_visible_with_new_height):
5441 Update.
5442 * tui/tui-source.c (tui_set_source_content)
5443 (tui_set_source_content_nil)
5444 (tui_source_window::do_scroll_vertical): Update.
5445 * tui/tui-layout.c (show_layout): Update.
5446 * tui/tui-disasm.c (tui_set_disassem_content)
5447 (tui_disasm_window::do_scroll_vertical): Update.
5448 * tui/tui-data.h (tui_win_content): Remove.
5449 (struct tui_gen_win_info) <content, content_size>: Remove.
5450 (struct tui_source_element): Add initializers and destructor.
5451 (union tui_which_element, struct tui_win_element): Remove.
5452 (struct tui_source_window_base) <content>: New field.
5453 (struct tui_data_window): Remove destructor.
5454 (tui_alloc_content, tui_free_win_content)
5455 (tui_free_all_source_wins_content): Don't declare.
5456 * tui/tui-data.c (tui_initialize_static_data): Update.
5457 (init_content_element, tui_alloc_content): Remove.
5458 (~tui_gen_win_info): Update.
5459 (~tui_data_window, tui_free_all_source_wins_content)
5460 (tui_free_win_content, free_content, free_content_elements):
5461 Remove.
5462
5463 2019-06-25 Tom Tromey <tom@tromey.com>
5464
5465 * tui/tui-winsource.h (tui_clear_source_content)
5466 (tui_erase_source_content, tui_show_source_content): Change type
5467 of win_info.
5468 * tui/tui-winsource.c (tui_clear_source_content)
5469 (tui_erase_source_content, tui_show_source_content): Change type
5470 of win_info.
5471 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5472 * tui/tui-source.h (tui_set_source_content_nil): Change type of
5473 win_info.
5474 * tui/tui-source.c (tui_set_source_content_nil): Change type of
5475 win_info.
5476 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5477
5478 2019-06-25 Tom Tromey <tom@tromey.com>
5479
5480 * tui/tui-winsource.c (tui_clear_source_content)
5481 (tui_source_window_base::set_is_exec_point_at): Update.
5482 * tui/tui-source.c (tui_set_source_content_nil): Update.
5483 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5484 a bool.
5485 * tui/tui-data.c (init_content_element): Update.
5486
5487 2019-06-25 Tom Tromey <tom@tromey.com>
5488
5489 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5490 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5491 * tui/tui-layout.c (init_and_make_win): Update.
5492 * tui/tui.h (enum tui_win_type): Update.
5493 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5494 tui_win_is_auxillary.
5495 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5496 tui_win_is_auxillary.
5497
5498 2019-06-25 Tom Tromey <tom@tromey.com>
5499
5500 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5501 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5502 (tui_delete_data_content_windows, tui_display_all_data)
5503 (tui_data_window::do_scroll_vertical, tui_display_data_from):
5504 Update.
5505 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5506 * tui/tui-regs.c (tui_last_regs_line_no)
5507 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5508 (tui_show_registers): Update.
5509 (tui_show_register_group): Return void. Update.
5510 (tui_display_registers_from, tui_display_reg_element_at_line)
5511 (tui_display_registers_from_line, tui_check_register_values):
5512 Update.
5513 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5514 member.
5515 (struct tui_data_window) <regs_content>: Now a std::vector.
5516 <regs_content_count>: Remove.
5517 (tui_add_content_elements, tui_free_data_content): Don't declare.
5518 * tui/tui-data.c (tui_data_window::clear_detail): Update.
5519 (init_content_element): Remove DATA_WIN case. Add assert.
5520 (tui_add_content_elements): Remove.
5521 (tui_data_window): Update.
5522 (tui_free_data_content): Remove.
5523 (free_content_elements): Remove DATA_WIN case.
5524
5525 2019-06-25 Tom Tromey <tom@tromey.com>
5526
5527 * tui/tui-data.c (tui_data_item_window): Update.
5528 * tui/tui-windata.h (tui_check_data_values): Don't declare.
5529 * tui/tui-windata.c (tui_display_all_data)
5530 (tui_display_data_from_line): Update.
5531 (tui_check_data_values): Remove.
5532 * tui/tui-regs.c (tui_show_register_group)
5533 (tui_display_reg_element_at_line): Update.
5534 * tui/tui-hooks.c (tui_register_changed)
5535 (tui_refresh_frame_and_register_information): Call
5536 tui_check_register_values.
5537 * tui/tui-data.h (struct tui_data_window) <data_content,
5538 data_content_count, data_type>: Remove.
5539 (enum tui_data_type): Remove.
5540
5541 * tui/tui-data.c (tui_data_window::clear_detail)
5542 (~tui_data_window): Update.
5543
5544 2019-06-25 Tom Tromey <tom@tromey.com>
5545
5546 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5547 declare.
5548 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5549 Rename from tui_first_data_item_displayed. Update.
5550 (tui_data_window::refresh_all)
5551 (tui_data_window::do_scroll_vertical): Update.
5552 * tui/tui-data.h (struct tui_data_window)
5553 <first_data_item_displayed>: Declare new method.
5554
5555 2019-06-25 Tom Tromey <tom@tromey.com>
5556
5557 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5558 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5559 contents...
5560 (tui_initialize_static_data): ...here.
5561
5562 2019-06-25 Tom Tromey <tom@tromey.com>
5563
5564 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5565 (tui_display_registers_from, tui_check_register_values): Update.
5566 (tui_display_register): Remove win_info parameter; update.
5567 (tui_get_register): Change type of parameters.
5568 * tui/tui-data.h (struct tui_data_element): Remove.
5569 (union tui_which_element) <data>: Remove.
5570 <data_window>: Change type.
5571 (struct tui_data_item_window): New.
5572 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5573 case. Add assert.
5574 (~tui_data_item_window): New destructor.
5575 (free_content_elements): Remove DATA_ITEM_WIN case.
5576
5577 2019-06-25 Tom Tromey <tom@tromey.com>
5578
5579 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5580 Remove.
5581
5582 2019-06-25 Tom Tromey <tom@tromey.com>
5583
5584 * tui/tui-data.h (struct tui_command_element): Remove.
5585 (union tui_which_element) <command>: Remove.
5586 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5587 assert.
5588 (free_content_elements): Remove CMD_WIN case.
5589
5590 2019-06-25 Tom Tromey <tom@tromey.com>
5591
5592 * tui/tui-layout.c (tui_set_layout): Update.
5593 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5594 * tui/tui-data.c (layout_def): Update.
5595
5596 2019-06-25 Tom Tromey <tom@tromey.com>
5597
5598 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5599 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5600 (tui_source_window_base::set_new_height): Update.
5601 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5602 Update.
5603 (tui_set_locator_fullname, tui_set_locator_info)
5604 (tui_show_frame_info): Update.
5605 * tui/tui-source.c (tui_set_source_content)
5606 (tui_source_is_displayed): Update.
5607 * tui/tui-layout.c (show_source_disasm_command, show_data)
5608 (show_source_or_disasm_and_command): Update.
5609 * tui/tui-disasm.c (tui_set_disassem_content)
5610 (tui_get_begin_asm_address): Update.
5611 * tui/tui-data.h (struct tui_locator_element): Remove.
5612 (union tui_which_element) <locator>: Remove.
5613 (struct tui_locator_window): New.
5614 (tui_locator_win_info_ptr): Change return type.
5615 * tui/tui-data.c (_locator): Change type.
5616 (tui_locator_win_info_ptr): Change return type.
5617 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5618 (tui_alloc_content): Add assert.
5619
5620 2019-06-25 Tom Tromey <tom@tromey.com>
5621
5622 * tui/tui-winsource.c
5623 (tui_exec_info_window::maybe_allocate_content): New method.
5624 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5625 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5626 (make_source_or_disasm_window): Add cast.
5627 * tui/tui-data.h (union tui_which_element) <simple_string>:
5628 Remove.
5629 (struct tui_source_info): New.
5630 (struct tui_source_window_base) <execution_info>: Change type.
5631 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5632 case, and add assert.
5633 (tui_alloc_content): Add assert.
5634
5635 2019-06-25 Tom Tromey <tom@tromey.com>
5636
5637 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5638 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5639 * tui/tui-data.c (tui_alloc_win_info): Remove.
5640
5641 2019-06-25 Tom Tromey <tom@tromey.com>
5642
5643 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5644 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5645 can_highlight.
5646
5647 2019-06-25 Tom Tromey <tom@tromey.com>
5648
5649 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5650 make_visible_with_new_height method.
5651 (tui_win_info::make_visible_with_new_height): New method.
5652 (tui_source_window_base::do_make_visible_with_new_height)
5653 (tui_data_window::do_make_visible_with_new_height)
5654 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5655 (make_visible_with_new_height): Remove.
5656 (tui_resize_all, tui_adjust_win_heights): Use
5657 make_visible_with_new_height method.
5658 * tui/tui-data.h (struct tui_win_info)
5659 <do_make_visible_with_new_height, make_visible_with_new_height>:
5660 New methods.
5661 (struct tui_source_window_base, struct tui_data_window)
5662 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5663 methods.
5664
5665 2019-06-25 Tom Tromey <tom@tromey.com>
5666
5667 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5668 method.
5669 (update_tab_width): Call update_tab_width method.
5670 * tui/tui-data.h (struct tui_win_info)
5671 (struct tui_source_window_base) <update_tab_width>: New methods.
5672
5673 2019-06-25 Tom Tromey <tom@tromey.com>
5674
5675 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5676 parameter.
5677 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5678 parameter.
5679 (tui_gen_win_info::make_visible): Update.
5680 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5681 parameter.
5682 * tui/tui-data.h (enum tui_box): New enum.
5683 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5684
5685 2019-06-25 Tom Tromey <tom@tromey.com>
5686
5687 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5688 init_and_make_win for EXEC_INFO_WIN.
5689 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5690 longer inline.
5691 (struct tui_win_info) <~tui_win_info>: Inline.
5692 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5693 Don't declare.
5694 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5695 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5696 Remove.
5697 (tui_initialize_static_data): Update.
5698 (~tui_gen_win_info): Handle more cleanup here.
5699 (~tui_source_window_base): Delete "execution_info".
5700 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5701
5702 2019-06-25 Tom Tromey <tom@tromey.com>
5703
5704 * tui/tui-layout.c (make_command_window): Don't set
5705 can_highlight.
5706 (show_source_disasm_command): Call the reset method.
5707 (show_data): Don't set can_highlight. Call the reset method.
5708 (tui_gen_win_info::reset): Rename from init_gen_win_info
5709 (init_and_make_win): Simplify. Return tui_gen_win_info.
5710 (show_source_or_disasm_and_command): Call the reset method.
5711 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5712 (struct tui_cmd_window): Set can_highlight.
5713
5714 2019-06-25 Tom Tromey <tom@tromey.com>
5715
5716 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5717 from make_visible.
5718 (tui_make_visible, tui_make_invisible): Rewrite.
5719 (tui_win_info::make_visible): Remove.
5720 (tui_source_window_base::make_visible): Update.
5721 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5722 method. Moved from...
5723 (struct tui_win_info) <make_visible>: ...here.
5724
5725 2019-06-25 Tom Tromey <tom@tromey.com>
5726
5727 * tui/tui-winsource.c
5728 (tui_source_window_base::do_scroll_horizontal): Remove direction
5729 parameter.
5730 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5731 direction parameter.
5732 * tui/tui-win.c (tui_win_info::forward_scroll)
5733 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5734 (tui_win_info::right_scroll): Update.
5735 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5736 direction parameter.
5737 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5738 direction parameter.
5739 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5740 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5741 Remove direction parameter.
5742 (struct tui_source_window_base, struct tui_source_window)
5743 (struct tui_disasm_window, struct tui_data_window)
5744 (struct tui_cmd_window): Update.
5745
5746 2019-06-25 Tom Tromey <tom@tromey.com>
5747
5748 * tui/tui-winsource.h (tui_set_exec_info_content)
5749 (tui_show_exec_info_content, tui_erase_exec_info_content)
5750 (tui_clear_exec_info_content, tui_update_exec_info): Change
5751 argument to tui_source_window_base.
5752 * tui/tui-winsource.c (tui_set_exec_info_content)
5753 (tui_show_exec_info_content, tui_erase_exec_info_content)
5754 (tui_clear_exec_info_content, tui_update_exec_info): Change
5755 argument to tui_source_window_base.
5756
5757 2019-06-25 Tom Tromey <tom@tromey.com>
5758
5759 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5760 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5761
5762 2019-06-25 Tom Tromey <tom@tromey.com>
5763
5764 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5765 check.
5766
5767 2019-06-25 Tom Tromey <tom@tromey.com>
5768
5769 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5770 type to void.
5771 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5772 type to void.
5773 * tui/tui-source.c (tui_set_source_content): Update.
5774 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5775
5776 2019-06-25 Tom Tromey <tom@tromey.com>
5777
5778 * tui/tui-win.c (window_name_completer, tui_set_focus)
5779 (tui_all_windows_info): Use name method.
5780 * tui/tui-data.h (struct tui_gen_win_info)
5781 (struct tui_source_window, struct tui_disasm_window)
5782 (struct tui_data_window, struct tui_cmd_window) <name>: New
5783 method.
5784 (tui_win_name): Don't declare.
5785 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5786 (tui_win_name): Remove.
5787
5788 2019-06-25 Tom Tromey <tom@tromey.com>
5789
5790 * tui/tui-winsource.h (tui_update_source_window)
5791 (tui_update_source_window_as_is): Change parameter type.
5792 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5793 to be a tui_source_window_base.
5794 (tui_update_source_window_as_is): Likewise.
5795 * tui/tui-win.c (make_visible_with_new_height): Update.
5796
5797 2019-06-25 Tom Tromey <tom@tromey.com>
5798
5799 * tui/tui-winsource.c (tui_erase_source_content)
5800 (tui_show_source_content, tui_show_exec_info_content)
5801 (tui_erase_exec_info_content): Use refresh_window method.
5802 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5803 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5804 from tui_refresh_win.
5805 (tui_data_window::refresh_window): New method.
5806 (tui_win_info::refresh, tui_source_window_base::refresh)
5807 (tui_refresh_all): Use refresh_window method.
5808 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5809 method.
5810 * tui/tui-regs.c (tui_display_register): Call refresh_window
5811 method.
5812 * tui/tui-layout.c (show_source_disasm_command)
5813 (show_source_or_disasm_and_command): Call refresh_window method.
5814 * tui/tui-data.h (struct tui_gen_win_info)
5815 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5816 New method.
5817
5818 2019-06-25 Tom Tromey <tom@tromey.com>
5819
5820 * tui/tui.c (tui_rl_other_window, tui_enable)
5821 (tui_is_window_visible, tui_get_command_dimension): Update.
5822 * tui/tui-winsource.c (tui_update_source_window_as_is)
5823 (tui_clear_source_content, tui_erase_source_content)
5824 (tui_show_source_line, tui_source_window_base::refill)
5825 (tui_source_window_base::do_scroll_horizontal)
5826 (tui_source_window_base::set_is_exec_point_at)
5827 (tui_update_breakpoint_info, tui_set_exec_info_content)
5828 (tui_alloc_source_buffer, tui_line_is_displayed)
5829 (tui_addr_is_displayed): Update.
5830 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5831 (tui_check_and_display_highlight_if_needed)
5832 (tui_win_info::make_visible, tui_win_info::refresh)
5833 (tui_refresh_all): Update.
5834 * tui/tui-windata.c (tui_first_data_item_displayed)
5835 (tui_delete_data_content_windows, tui_erase_data_content)
5836 (tui_display_all_data, tui_data_window::refresh_all)
5837 (tui_check_data_values): Update.
5838 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5839 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5840 (tui_win_info::backward_scroll, tui_refresh_all_win)
5841 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5842 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5843 (tui_source_window_base::set_new_height)
5844 (tui_data_window::set_new_height)
5845 (make_invisible_and_set_new_height)
5846 (make_visible_with_new_height, new_height_ok)
5847 (parse_scrolling_args): Update.
5848 * tui/tui-stack.c (tui_show_frame_info): Update.
5849 * tui/tui-source.c (tui_set_source_content)
5850 (tui_set_source_content_nil, tui_source_is_displayed)
5851 (tui_source_window::do_scroll_vertical): Update.
5852 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5853 (tui_display_registers_from, tui_display_reg_element_at_line)
5854 (tui_check_register_values, tui_reg_command): Update.
5855 * tui/tui-layout.c (tui_default_win_height)
5856 (show_source_disasm_command, show_data, init_and_make_win)
5857 (show_source_or_disasm_and_command): Update.
5858 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5859 (tui_redisplay_readline, tui_mld_flush)
5860 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5861 (tui_getc): Update.
5862 * tui/tui-disasm.c (tui_set_disassem_content)
5863 (tui_disasm_window::do_scroll_vertical): Update.
5864 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5865 Now virtual.
5866 (struct tui_win_info): Derive from tui_gen_win_info.
5867 <~tui_win_info>: Mark as override.
5868 <generic>: Remove member.
5869 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5870 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5871 (~tui_data_window, ~tui_win_info)
5872 (tui_free_all_source_wins_content): Update.
5873 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5874
5875 2019-06-25 Tom Tromey <tom@tromey.com>
5876
5877 * tui/tui-layout.c (init_and_make_win): Use new.
5878 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5879 destructor, initializers.
5880 (tui_alloc_generic_win_info): Don't declare.
5881 * tui/tui-data.c (_locator): Add argument to constructor.
5882 (source_win, disasm_win): New globals.
5883 (exec_info): Remove.
5884 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5885 Update.
5886 (tui_alloc_generic_win_info): Remove.
5887 (init_content_element): Use new.
5888 (tui_win_info::tui_win_info): Update.
5889 (free_content_elements) <case DATA_WIN>: Use delete.
5890
5891 2019-06-25 Tom Tromey <tom@tromey.com>
5892
5893 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5894 * tui/tui-windata.c (tui_first_data_item_displayed)
5895 (tui_delete_data_content_windows): Update.
5896 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5897 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5898 (tui_display_registers_from, tui_check_register_values): Update.
5899 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5900 pointer.
5901 * tui/tui-data.c (init_content_element): Update. Allocate the new
5902 window.
5903 (tui_free_data_content): Update.
5904 (free_content_elements) <case DATA_WIN>: Free the window.
5905
5906 2019-06-25 Tom Tromey <tom@tromey.com>
5907
5908 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5909 Update.
5910 * tui/tui-layout.c (make_command_window)
5911 (show_source_disasm_command, show_data, init_and_make_win)
5912 (show_source_or_disasm_and_command): Update.
5913 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5914 method.
5915 <can_highight, is_highlighted>: Now bool.
5916 (tui_set_win_highlight): Don't declare.
5917 * tui/tui-data.c (tui_set_win_highlight): Remove.
5918
5919 2019-06-25 Tom Tromey <tom@tromey.com>
5920
5921 * tui/tui-wingeneral.c (make_visible): Remove check of window
5922 type.
5923
5924 2019-06-25 Tom Tromey <tom@tromey.com>
5925
5926 * tui/tui-win.c (tui_win_info::max_height)
5927 (tui_cmd_window::max_height): New methods.
5928 (new_height_ok): Call max_height.
5929 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5930 <max_height>: New method.
5931
5932 2019-06-25 Tom Tromey <tom@tromey.com>
5933
5934 * tui/tui-win.c (tui_source_window_base::set_new_height)
5935 (tui_data_window::set_new_height): New methods.
5936 (make_invisible_and_set_new_height): Call set_new_height method.
5937 * tui/tui-data.h (struct tui_win_info)
5938 (struct tui_source_window_base, struct tui_data_window)
5939 <set_new_height>: New method.
5940
5941 2019-06-25 Tom Tromey <tom@tromey.com>
5942
5943 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5944 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5945 tui_refresh_data_win.
5946 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5947 method.
5948 (tui_refresh_all_win): Call the refresh_all method.
5949 (tui_set_focus): Likewise.
5950 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5951 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5952 Likewise.
5953
5954 2019-06-25 Tom Tromey <tom@tromey.com>
5955
5956 * tui/tui-winsource.h (tui_refill_source_window)
5957 (tui_set_is_exec_point_at): Don't declare.
5958 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5959 (tui_source_window_base::refill): Rename from
5960 tui_refill_source_window.
5961 (tui_source_window_base::do_scroll_horizontal): Update.
5962 (tui_source_window_base::set_is_exec_point_at): Rename from
5963 tui_set_is_exec_point_at.
5964 (tui_update_all_breakpoint_info): Update.
5965 * tui/tui-stack.c (tui_show_frame_info): Update.
5966 * tui/tui-layout.c (show_data): Add cast.
5967 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5968 * tui/tui-data.h (struct tui_source_window_base) <refill,
5969 set_is_exec_point_at>: New methods.
5970 (tui_source_windows, tui_add_to_source_windows): Update types.
5971 (tui_add_to_source_windows): Remove redundant declaration.
5972 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5973 (tui_source_windows): Change return type.
5974 (tui_clear_source_windows_detail): Update.
5975 (tui_add_to_source_windows): Change type of parameter.
5976 (tui_free_all_source_wins_content): Update.
5977
5978 2019-06-25 Tom Tromey <tom@tromey.com>
5979
5980 * tui/tui-wingeneral.c (tui_win_info::refresh)
5981 (tui_source_window_base::refresh): New methods.
5982 (tui_refresh_all): Call the refresh method.
5983 * tui/tui-data.h (struct tui_win_info)
5984 (struct tui_source_window_base) <refresh>: New method.
5985
5986 2019-06-25 Tom Tromey <tom@tromey.com>
5987
5988 * tui/tui.h (tui_is_window_visible): Return bool.
5989 * tui/tui.c (tui_is_window_visible): Return bool.
5990 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5991 (tui_make_visible, tui_make_invisible)
5992 (tui_win_info::make_visible)
5993 (tui_source_window_base::make_visible, make_all_visible)
5994 (tui_make_all_visible, tui_make_all_invisible): Update.
5995 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5996 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5997 bool.
5998 (struct tui_win_info, struct tui_source_window_base)
5999 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6000 * tui/tui-data.c (tui_init_generic_part): Update.
6001
6002 2019-06-25 Tom Tromey <tom@tromey.com>
6003
6004 * tui/tui-wingeneral.c (tui_win_info::make_visible)
6005 (tui_source_window_base::make_visible): New methods.
6006 (make_all_visible): Make method call.
6007 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6008 (struct tui_source_window_base, struct tui_cmd_window): Override
6009 make_visible.
6010 (tui_win_is_source_type): Don't declare.
6011 * tui/tui-data.c (tui_win_is_source_type): Remove.
6012
6013 2019-06-25 Tom Tromey <tom@tromey.com>
6014
6015 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6016 NULL check.
6017
6018 2019-06-25 Tom Tromey <tom@tromey.com>
6019
6020 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6021 Inline constructor. Add initializers for members.
6022 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6023 constructors; now inline in class.
6024
6025 2019-06-25 Tom Tromey <tom@tromey.com>
6026
6027 * tui/tui-regs.c (tui_show_registers): Update.
6028 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6029 bool.
6030 * tui/tui-data.c (tui_data_window::clear_detail)
6031 (tui_data_window): Update.
6032
6033 2019-06-25 Tom Tromey <tom@tromey.com>
6034
6035 * tui/tui-windata.c (tui_display_all_data)
6036 (tui_display_data_from_line, tui_display_data_from)
6037 (tui_check_data_values, tui_data_window::do_scroll_vertical):
6038 Update.
6039 * tui/tui-regs.c (tui_last_regs_line_no)
6040 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6041 (tui_show_registers, tui_show_register_group)
6042 (tui_display_registers_from, tui_display_reg_element_at_line)
6043 (tui_display_registers_from_line, tui_check_register_values)
6044 (tui_reg_next, tui_reg_prev): Update.
6045 * tui/tui-layout.c (tui_set_layout, show_data): Update.
6046 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
6047 tui_data_window.
6048 (struct tui_win_info) <detail>: Remove. Add new fields from
6049 tui_data_info.
6050 (TUI_DATA_WIN): Add cast.
6051 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6052 (~tui_data_window): Simplify.
6053
6054 2019-06-25 Tom Tromey <tom@tromey.com>
6055
6056 * tui/tui-layout.c (show_source_disasm_command)
6057 (show_source_or_disasm_and_command): Update.
6058 * tui/tui-io.c (update_cmdwin_start_line)
6059 (tui_redisplay_readline): Update.
6060 * tui/tui-data.h (struct tui_command_info): Remove.
6061 (struct tui_win_info) <detail>: Remove command_info member.
6062 (struct tui_data_window) <start_line>: New member, from
6063 tui_command_info.
6064 (TUI_CMD_WIN): Add casts.
6065
6066 2019-06-25 Tom Tromey <tom@tromey.com>
6067
6068 * tui/tui-winsource.c (tui_update_source_window)
6069 (tui_refill_source_window)
6070 (tui_source_window_base::do_scroll_horizontal)
6071 (tui_update_breakpoint_info, tui_set_exec_info_content)
6072 (tui_show_exec_info_content, tui_erase_exec_info_content)
6073 (tui_clear_exec_info_content): Update.
6074 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6075 Update.
6076 * tui/tui-win.c (make_invisible_and_set_new_height)
6077 (make_visible_with_new_height): Update.
6078 * tui/tui-source.c (tui_set_source_content)
6079 (tui_show_symtab_source): Update.
6080 * tui/tui-layout.c (extract_display_start_addr)
6081 (show_source_disasm_command, show_data)
6082 (make_source_or_disasm_window)
6083 (show_source_or_disasm_and_command): Update.
6084 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6085 (tui_disasm_window::do_scroll_vertical): Remove shadowing
6086 "gdbarch".
6087 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
6088 to tui_source_window_base.
6089 (struct tui_win_info) <detail>: Remove source_info member.
6090 (struct tui_source_window_base) <has_locator>: Inline.
6091 Move contents from tui_source_info; rename has_locator member to
6092 m_has_locator.
6093 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6094 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6095 header file.
6096 (tui_source_window_base::clear_detail, ~tui_source_window_base):
6097 Simplify.
6098 (tui_free_all_source_wins_content): Cast to
6099 tui_source_window_base.
6100
6101 2019-06-25 Tom Tromey <tom@tromey.com>
6102
6103 * tui/tui-win.c (make_invisible_and_set_new_height)
6104 (make_visible_with_new_height): Call has_locator method.
6105 * tui/tui-layout.c (show_source_disasm_command, show_data)
6106 (show_source_or_disasm_and_command): Update for bool change.
6107 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6108 (tui_win_info) <has_locator>: New method.
6109 (struct tui_source_window_base) <has_locator>: New method.
6110 (tui_win_has_locator): Don't declare.
6111 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6112 from tui_win_has_locator.
6113 (tui_source_window_base): Use false, not FALSE.
6114
6115 2019-06-25 Tom Tromey <tom@tromey.com>
6116
6117 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6118 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6119 clear_detail method directly.
6120 (tui_clear_win_detail): Remove.
6121
6122 2019-06-25 Tom Tromey <tom@tromey.com>
6123
6124 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6125 "this", not TUI_DISASM_WIN.
6126
6127 2019-06-25 Tom Tromey <tom@tromey.com>
6128
6129 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
6130 declare.
6131 * tui/tui-winsource.c
6132 (tui_source_window_base::do_scroll_horizontal): Rename from
6133 tui_horizontal_source_scroll.
6134 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6135 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6136 from tui_vertical_data_scroll.
6137 * tui/tui-win.h (tui_scroll): Don't declare.
6138 * tui/tui-win.c (tui_win_info::forward_scroll)
6139 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6140 (tui_win_info::right_scroll): Rename and update.
6141 (tui_scroll_forward_command, tui_scroll_backward_command)
6142 (tui_scroll_left_command, tui_scroll_right_command): Update.
6143 (tui_scroll): Remove.
6144 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6145 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6146 from tui_vertical_source_scroll.
6147 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6148 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6149 from tui_vertical_disassem_scroll.
6150 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6151 do_scroll_horizontal>: New methods.
6152 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6153 Likewise.
6154 (struct tui_source_window_base): Add do_scroll_horizontal.
6155 (struct tui_source_window, struct tui_disasm_window): Add
6156 do_scroll_vertical.
6157 (struct tui_data_window, struct tui_cmd_window): Add
6158 do_scroll_horizontal and do_scroll_vertical.
6159 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6160
6161 2019-06-25 Tom Tromey <tom@tromey.com>
6162
6163 * tui/tui-data.h (struct tui_source_window_base): New struct.
6164 (struct tui_source_window): Derive from tui_source_window_base.
6165 (struct tui_disasm_window): New struct.
6166 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6167 from tui_source_window::clear_detail.
6168 (tui_source_window_base): Rename from tui_source_window.
6169 (~tui_source_window_base): Rename from ~tui_source_window.
6170 (tui_alloc_win_info): Create a tui_disasm_window.
6171
6172 2019-06-25 Tom Tromey <tom@tromey.com>
6173
6174 * tui/tui-data.h (struct tui_source_window)
6175 (struct tui_data_window): Declare destructors.
6176 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6177 destructors.
6178 (tui_win_info): Simplify.
6179
6180 2019-06-25 Tom Tromey <tom@tromey.com>
6181
6182 * tui/tui-winsource.c (tui_display_main)
6183 (tui_update_source_windows_with_addr)
6184 (tui_update_all_breakpoint_info): Update.
6185 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6186 (new_height_ok, parse_scrolling_args): Update.
6187 * tui/tui-stack.c (tui_show_frame_info): Update.
6188 * tui/tui-data.h (struct tui_list): Remove.
6189 (tui_source_windows): Return a reference to a std::vector.
6190 * tui/tui-data.c (source_windows): Now a std::vector.
6191 (tui_source_windows): Change return type.
6192 (tui_clear_source_windows): Rewrite.
6193 (tui_clear_source_windows_detail, tui_add_to_source_windows)
6194 (tui_free_all_source_wins_content): Rewrite.
6195
6196 2019-06-25 Tom Tromey <tom@tromey.com>
6197
6198 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6199 (struct tui_data_window, struct tui_cmd_window): Declare
6200 clear_detail method.
6201 * tui/tui-data.c (tui_source_window::clear_detail)
6202 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6203 methods.
6204 (tui_clear_win_detail): Simplify.
6205
6206 2019-06-25 Tom Tromey <tom@tromey.com>
6207
6208 * tui/tui-layout.c (make_source_window, make_disasm_window)
6209 (make_source_or_disasm_window): Remove win_info_ptr parameter.
6210 Return the new window.
6211 (show_source_disasm_command, show_data)
6212 (show_source_or_disasm_and_command): Update.
6213
6214 2019-06-25 Tom Tromey <tom@tromey.com>
6215
6216 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6217 parameter. Return the new window.
6218 (show_source_disasm_command): Update and remove NULL check.
6219 (show_source_or_disasm_and_command): Update.
6220
6221 2019-06-25 Tom Tromey <tom@tromey.com>
6222
6223 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6224
6225 2019-06-25 Tom Tromey <tom@tromey.com>
6226
6227 * tui/tui-data.h (struct tui_win_info): Make constructor
6228 protected. Make destructor virtual. Add initializers.
6229 (tui_source_window, tui_data_window, tui_cmd_window): New
6230 classes.
6231 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
6232 constructor. Add "type" parameter.
6233 (tui_source_window, tui_data_window, tui_cmd_window): New
6234 constructors.
6235 (tui_alloc_win_info): Instantiate the appropriate subclass.
6236
6237 2019-06-25 Tom Tromey <tom@tromey.com>
6238
6239 * tui/tui-win.c (tui_resize_all): Use delete.
6240 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6241 destructor.
6242 (tui_free_window): Don't declare.
6243 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6244 Update.
6245
6246 2019-06-25 Tom Tromey <tom@tromey.com>
6247
6248 * tui/tui-data.h (struct tui_win_info): Add constructor.
6249 * tui/tui-data.c (tui_alloc_win_info): Use new.
6250 (tui_free_window): Use delete.
6251
6252 2019-06-22 Tom Tromey <tom@tromey.com>
6253
6254 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6255 declare.
6256 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6257
6258 2019-06-22 Tom Tromey <tom@tromey.com>
6259
6260 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6261 declare.
6262 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6263
6264 2019-06-22 Tom de Vries <tdevries@suse.de>
6265
6266 * dwarf2read.c (create_addrmap_from_aranges)
6267 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6268 instead of '%zu'.
6269
6270 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
6271
6272 * dwarf2read.h (dwarf2_section_info_def): Remove.
6273 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6274 * dwarf2read.c (struct dwo_sections) <types>: Change type to
6275 std::vector<dwarf2_section_info>.
6276 (struct dwo_file) <~dwo_file>: Remove.
6277 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6278 types field.
6279 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6280 (dwarf2_read_debug_names): Likewise.
6281 (create_debug_types_hash_table): Change parameter type to
6282 array_view, adjust code accordingly.
6283 (dwarf2_locate_dwo_sections): Adjust to std::vector.
6284 (partial_die_info::fixup): Likewise.
6285 (determine_prefix): Likewise.
6286 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6287
6288 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6289
6290 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6291 gdb_bfd_ref_ptr.
6292 <~dwo_file>: Remove call to gdb_bfd_unref.
6293 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6294 gdb_bfd_ref_ptr::get.
6295
6296 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6297
6298 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6299 type to htab_up.
6300 * dwarf2read.c (struct dwo_file): Initialize fields.
6301 <~dwo_file>: New.
6302 (free_dwo_file): Remove, move content to ~dwo_file.
6303 (struct dwo_file_deleter): Remove.
6304 (dwo_file_up>: Remove custom deleter.
6305 (free_dwo_files): Remove.
6306 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6307 dwo_files.
6308 (process_skeletonless_type_units): Call unique_ptr::get.
6309 (allocate_dwo_file_hash_table): Add deleter to created hash
6310 table. Change return type to htab_up.
6311 (lookup_dwo_file_slot): Don't memset dwo_file, call
6312 unique_ptr::get.
6313 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6314 (create_dwo_unit_in_dwp_v2): Likewise.
6315 (open_and_init_dwo_file): Likewise.
6316 (free_dwo_file_from_slot): Remove.
6317
6318 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
6319
6320 * dwarf2read.h (struct dwarf2_section_info) <readin,
6321 is_virtual>: Change type to bool.
6322 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6323 true instead of 1.
6324
6325 2019-06-19 Tom Tromey <tom@tromey.com>
6326
6327 * tui/tui-data.h (tui_init_content_element): Don't declare.
6328
6329 2019-06-19 Tom Tromey <tom@tromey.com>
6330
6331 * tui/tui-data.h (tui_init_win_info): Don't declare.
6332
6333 2019-06-19 Tom de Vries <tdevries@suse.de>
6334
6335 * dwarf2read.h (abstract_to_concrete): Change type to
6336 std::unordered_map<sect_offset, std::vector<sect_offset>,
6337 gdb::hash_enum<sect_offset>>.
6338
6339 2019-06-19 Tom Tromey <tromey@adacore.com>
6340
6341 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6342 EVAL_AVOID_SIDE_EFFECTS specially.
6343
6344 2019-06-19 Tom Tromey <tromey@adacore.com>
6345
6346 * source-cache.c (highlighter): New global.
6347 (source_cache::get_source_lines): Create a highlighter on demand.
6348
6349 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
6350
6351 * defs.h (deprecated_interactive_hook): Delete declaration.
6352 * interps.c (clear_interpreter_hooks): Remove use of
6353 deprecated_interactive_hook.
6354 * top.c (deprecated_interactive_hook): Delete definition.
6355 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6356
6357 2019-06-18 Tom de Vries <tdevries@suse.de>
6358
6359 PR gdb/24515
6360 * dwarf2read.h (abstract_to_concrete): Change type from
6361 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6362 std::unordered_map<sect_offset, std::vector<sect_offset>>.
6363 * dwarf2read.c (read_variable): Update.
6364 (dwarf2_fetch_die_loc_sect_off): Update.
6365
6366 2019-06-17 Tom de Vries <tdevries@suse.de>
6367
6368 PR gdb/24617
6369 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6370 accessing parent[parent_len - 1].
6371
6372 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
6373
6374 PR gdb/24364
6375 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6376 call dtrace_process_dof with NULL dof.
6377
6378 2019-06-16 Tom de Vries <tdevries@suse.de>
6379
6380 PR gdb/24445
6381 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6382
6383 2019-06-16 Tom Tromey <tom@tromey.com>
6384
6385 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6386 (make_all_visible): Use address of member.
6387
6388 2019-06-16 Tom Tromey <tom@tromey.com>
6389
6390 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6391 (tui_free_window, free_content, free_content_elements): Remove
6392 unnecessary cast.
6393 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6394 cast.
6395 * tui/tui-regs.c (tui_show_register_group)
6396 (tui_display_registers_from, tui_display_reg_element_at_line):
6397 Remove unnecessary cast.
6398
6399 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
6400
6401 * linux-nat.c (normal_mask): Delete.
6402 (_initialize_linux_nat): Don't initialise normal_mask.
6403
6404 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
6405
6406 PR gdb/24445
6407 * dwarf-index-write.h (write_psymtabs_to_index): Add
6408 dwz_basename parameter.
6409 * dwarf-index-write.c (write_gdbindex): Move file writing to
6410 write_gdbindex_1. Change return type void.
6411 (assert_file_size): Move up, remove filename parameter.
6412 (write_gdbindex_1): New function.
6413 (write_debug_names): Change return type to void, call
6414 assert_file_size.
6415 (struct index_wip_file): New struct.
6416 (write_psymtabs_to_index): Add dwz_basename parameter. Move
6417 file logic to index_wip_file. Write index for dwz file if
6418 needed.
6419 (save_gdb_index_command): Pass basename of dwz file, if present.
6420 * dwarf-index-cache.c (index_cache::store): Obtain and pass
6421 build-id of dwz file, if present.
6422 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6423 (dwarf2_get_dwz_file): Likewise.
6424 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6425 (dwarf2_get_dwz_file): Likewise.
6426
6427 2019-06-16 Tom Tromey <tom@tromey.com>
6428
6429 * coffread.c (process_coff_symbol): Use xstrdup.
6430 * value.c (create_internalvar): Use xstrdup.
6431
6432 2019-06-16 Tom Tromey <tom@tromey.com>
6433
6434 * valops.c (value_cast, value_slice): Remove unnecessary cast.
6435 * breakpoint.c (stopin_command, stopat_command)
6436 (until_break_command, decode_location_default): Remove unnecessary
6437 cast.
6438 * utils.c (subset_compare): Remove unnecessary cast.
6439 * ada-lang.c (ada_update_initial_language): Remove unnecessary
6440 cast.
6441 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6442 cast.
6443 * infcmd.c (path_command): Remove unnecessary cast.
6444 * coffread.c (decode_type): Remove unnecessary cast.
6445 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6446 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6447 * tui/tui-stack.c (tui_show_locator_content)
6448 (tui_show_frame_info): Remove unnecessary cast.
6449 * tui/tui-win.c (tui_scroll_forward_command)
6450 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6451 (parse_scrolling_args): Remove unnecessary cast.
6452 * tui/tui-data.c (init_win_info, tui_del_window)
6453 (tui_free_window, tui_del_data_windows, tui_free_data_content)
6454 (free_content_elements): Remove unnecessary cast.
6455 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6456 unnecessary cast.
6457 * tui/tui-source.c (tui_set_source_content)
6458 (tui_vertical_source_scroll): Remove unnecessary cast.
6459 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6460 cast.
6461 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6462 * tui/tui-regs.c (tui_display_registers_from)
6463 (tui_display_register): Remove unnecessary cast.
6464 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6465 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6466 (make_visible): Remove unnecessary cast.
6467 * tui/tui-winsource.c (tui_erase_source_content)
6468 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6469 unnecessary cast.
6470 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6471 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6472 * stabsread.c (read_type, read_array_type, read_range_type):
6473 Remove unnecessary cast.
6474 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6475 (parse_symbol, parse_type, upgrade_type, parse_external)
6476 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6477 unnecessary cast.
6478 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6479
6480 2019-06-16 Tom Tromey <tom@tromey.com>
6481
6482 * tui/tui-data.c (tui_alloc_generic_win_info)
6483 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6484 checks.
6485
6486 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
6487 Andrew Burgess <andrew.burgess@embecosm.com>
6488
6489 * f-typeprint.c (f_print_type): Don't return early for not
6490 associated or not allocated types.
6491 (f_type_print_varspec_suffix): Add print_rank parameter and print
6492 ranks of array types in case they dangling.
6493 (f_type_print_base): Add print_rank parameter.
6494
6495 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6496
6497 * NEWS: Mention new MI commands.
6498 * break-catch-throw.c (enum exception_event_kind): Move to
6499 breakpoint.h.
6500 (print_mention_exception_catchpoint): Output text as a single
6501 message.
6502 (catch_exception_command_1): Rename to...
6503 (catch_exception_event): ...this, make non-static, update header
6504 command, and change some parameter types.
6505 (catch_catch_command): Update for changes to
6506 catch_exception_command_1.
6507 (catch_throw_command): Likewise.
6508 (catch_rethrow_command): Likewise.
6509 * breakpoint.c (enum exception_event_kind): Delete.
6510 * breakpoint.h (enum exception_event_kind): Moved here from
6511 break-catch-throw.c.
6512 (catch_exception_event): Declare.
6513 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6514 (mi_cmd_catch_throw): New function.
6515 (mi_cmd_catch_rethrow): New function.
6516 (mi_cmd_catch_catch): New function.
6517 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6518 'catch-catch' entries.
6519 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6520 (mi_cmd_catch_rethrow): Declare.
6521 (mi_cmd_catch_catch): Declare.
6522
6523 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6524
6525 * annotate.c (annotate_source_line): Change return type to void,
6526 update implementation to match.
6527 * annotate.h (annotate_source_line): Change return type to void,
6528 update header comment.
6529 * stack.c (print_frame_info): Don't change what frame information
6530 is printed based on whether annotations are on or not.
6531
6532 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6533
6534 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6535 (annotate_source): Make static.
6536 (annotate_source_line): Moved from source.c and renamed from
6537 identify_source_line. Update the return type.
6538 * annotate.h (annotate_source): Delete declaration.
6539 (annotate_source_line): Declaration moved from source.h, and
6540 renamed from identify_source_line. Return type updated.
6541 * source.c (identify_source_line): Moved to annotate.c and renamed
6542 to annotate_source_line.
6543 (info_line_command): Remove check of annotation_level.
6544 * source.h (identify_source_line): Move declaration to annotate.h
6545 and rename to annotate_source_line.
6546 * stack.c: Add 'annotate.h' include.
6547 (print_frame_info): Remove check of annotation_level before
6548 calling annotate_source_line.
6549
6550 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6551
6552 * source-cache.c (source_cache::get_plain_source_lines): Use
6553 open_source_file_with_line_charpos instead of just
6554 open_source_file, remove call to find_source_lines.
6555 (source_cache::get_source_lines): Likewise.
6556 * source.c (find_source_lines): Make static.
6557 (get_filename_and_charpos): Renamed into...
6558 (open_source_file_with_line_charpos): ..this along with changes to
6559 return a scoped_fd, and some other minor clean ups.
6560 (identify_source_line): Use open_source_file_with_line_charpos.
6561 (search_command_helper): Use open_source_file_with_line_charpos
6562 instead of just open_source_file, remove call to
6563 find_source_lines.
6564 * source.h (open_source_file_with_line_charpos): Declare new
6565 function.
6566 (find_source_lines): Delete declaration.
6567
6568 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6569
6570 * source.c (get_filename_and_charpos): Remove fullname
6571 parameter.
6572 (identify_source_line): Update call to get_filename_and_charpos.
6573
6574 2019-06-14 Tom Tromey <tromey@adacore.com>
6575
6576 PR gdb/24502:
6577 * ui-style.h (skip_ansi_escape): Update comment.
6578 * ui-file.h (class no_terminal_escape_file): New class.
6579 * ui-file.c (no_terminal_escape_file::write)
6580 (no_terminal_escape_file::puts): New methods.
6581 * cli/cli-logging.c (handle_redirections): Use
6582 no_terminal_escape_file.
6583
6584 2019-06-14 Tom Tromey <tromey@adacore.com>
6585
6586 * NEWS: Move convenience variable news above Python news.
6587
6588 2019-06-14 Tom Tromey <tom@tromey.com>
6589
6590 * gnulib: Move directory to top-level.
6591 * configure.ac: Don't configure gnulib.
6592 * configure: Rebuild.
6593 * common/common-defs.h: Use new path to gnulib.
6594 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6595 (GNULIB_H): Remove.
6596 (INCGNU): Look in new gnulib location.
6597 (HFILES_NO_SRCDIR): Remove gnulib files.
6598 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6599 (generated_files): Remove GNULIB_H.
6600 ($(LIBGNU), all-lib): Remove targets.
6601 (distclean): Don't mention GNULIB_BUILDDIR.
6602 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6603
6604 2019-06-14 Tom Tromey <tromey@adacore.com>
6605
6606 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6607 Warn if symbol file does not provide any symbols.
6608
6609 2019-06-14 Tom Tromey <tromey@adacore.com>
6610
6611 * source.c (find_and_open_source): Respect basenames_may_differ.
6612
6613 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6614
6615 * annotate.c (annotate_breakpoints_invalid): Make use of
6616 scoped_restore_terminal_state.
6617 (annotate_frames_invalid): Likewise.
6618
6619 2019-06-14 Tom Tromey <tromey@adacore.com>
6620
6621 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6622 allow assignment to an internalvar.
6623
6624 2019-06-14 Tom Tromey <tromey@adacore.com>
6625
6626 * ada-lex.l: Allow "_" in attribute names.
6627
6628 2019-06-14 Tom Tromey <tromey@adacore.com>
6629
6630 PR gdb/24653:
6631 * regcache.c (registers_changed): Don't call alloca.
6632 * top.c (execute_command): Don't call alloca.
6633
6634 2019-06-13 Pedro Alves <palves@redhat.com>
6635
6636 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6637 'expression'. When parsing an expression, error out if there's
6638 junk after "unlimited".
6639 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6640 (do_set_command): Adjust calls to is_unlimited_literal.
6641
6642 2019-06-13 Pedro Alves <palves@redhat.com>
6643
6644 * compile/compile.c (make_compile_options_def_group): Add braces
6645 around array_view initializer.
6646 * thread.c (make_thread_apply_all_options_def_group)
6647 (make_thread_apply_all_options_def_group): Likewise.
6648
6649 2019-06-13 Pedro Alves <palves@redhat.com>
6650
6651 * NEWS (New commands): Mention "maint test-options
6652 require-delimiter", "maint test-options unknown-is-error", "maint
6653 test-options unknown-is-operand" and "maint show
6654 test-options-completion-result".
6655 (New command options, command completion): New section.
6656 (Completion improvements): New section.
6657 Mention that you can abbreviate "unlimited".
6658
6659 2019-06-13 Pedro Alves <palves@redhat.com>
6660
6661 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6662 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6663 * unittests/cli-utils-selftests.c (test_parse_flags)
6664 (test_parse_flags_qcs): Delete.
6665 (test_cli_utils): Don't call deleted functions.
6666
6667 2019-06-13 Pedro Alves <palves@redhat.com>
6668
6669 * thread.c: Include "cli/cli-option.h".
6670 (tp_array_compar_ascending): Global.
6671 (tp_array_compar): Delete function.
6672 (tp_array_compar_ascending, tp_array_compar_descending): New
6673 functions.
6674 (ascending_option_def, qcs_flag_option_def)
6675 (thr_qcs_flags_option_defs)
6676 (make_thread_apply_all_options_def_group)
6677 (make_thread_apply_options_def_group): New.
6678 (thread_apply_all_command): Use gdb::option::process_options.
6679 (thread_apply_command_completer)
6680 (thread_apply_all_command_completer): New.
6681 (thread_apply_command): Use gdb::option::process_options.
6682 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6683 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6684 to generate help text of "thread apply". Adjust "taas"'s help.
6685 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6686 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6687
6688 2019-06-13 Pedro Alves <palves@redhat.com>
6689
6690 * thread.c (thread_apply_command): Check for invalid TID with
6691 isdigit instead of !isalpha.
6692
6693 2019-06-13 Pedro Alves <palves@redhat.com>
6694
6695 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6696 (validate_flags_qcs): New.
6697 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6698 (validate_flags_qcs): Declare.
6699 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6700 (make_frame_apply_options_def_group): New.
6701 (frame_apply_command_count): Process options with
6702 gdb::option::process_options.
6703 (frame_apply_completer): New.
6704 (frame_apply_level_completer, frame_apply_all_completer)
6705 (frame_apply_completer): New.
6706 (_initialize_stack): Update help of "frame apply", "frame apply
6707 level", "frame apply all" and "faas" to mention supported options
6708 and install command completers.
6709 * stack.h (frame_apply_all_completer): Declare.
6710 * thread.c: Include "stack.h".
6711 (tfaas_command): Add "--".
6712 (_initialize_thread): Update help "tfaas" to mention supported
6713 options and install command completer.
6714
6715 2019-06-13 Pedro Alves <palves@redhat.com>
6716
6717 * completer.c (complete_nested_command_line): New.
6718 (gdb_completion_word_break_characters_throw): Add assertion.
6719 * completer.h (complete_nested_command_line): Declare.
6720
6721 2019-06-13 Pedro Alves <palves@redhat.com>
6722
6723 * stack.c (parse_backtrace_qualifiers): New.
6724 (backtrace_command): Use it.
6725 (backtrace_command_completer): Complete on qualifiers.
6726
6727 2019-06-13 Pedro Alves <palves@redhat.com>
6728
6729 * frame.c: Include "cli/cli-option.h.
6730 (user_set_backtrace_options): New.
6731 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6732 Delete.
6733 (get_prev_frame): Adjust.
6734 (boolean_option_def, uinteger_option_def)
6735 (set_backtrace_option_defs): New.
6736 (_initialize_frame): Adjust and use
6737 gdb::option::add_setshow_cmds_for_options to install "set
6738 backtrace past-main" and "set backtrace past-entry".
6739 * frame.h: Include "cli/cli-option.h".
6740 (struct frame_print_options): Forward declare.
6741 (print_frame_arguments_all, print_frame_arguments_scalars)
6742 (print_frame_arguments_none): Declare.
6743 (print_entry_values): Delete declaration.
6744 (struct frame_print_options, user_frame_print_options): New.
6745 (struct set_backtrace_options): New.
6746 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6747 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6748 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6749 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6750 (list_args_or_locals): Add frame_print_options parameter.
6751 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6752 * python/py-framefilter.c (enumerate_args): Pass down
6753 USER_FRAME_PRINT_OPTIONS.
6754 * stack.c: Include "cli/cli-option.h".
6755 (print_frame_arguments_all, print_frame_arguments_scalars)
6756 (print_frame_arguments_none): Declare.
6757 (print_raw_frame_arguments, print_entry_values): Delete.
6758 (user_frame_print_options): New.
6759 (boolean_option_def, enum_option_def, frame_print_option_defs):
6760 New.
6761 (struct backtrace_cmd_options): New.
6762 (bt_flag_option_def): New.
6763 (backtrace_command_option_defs): New.
6764 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6765 (print_frame_arg, read_frame_arg, print_frame_args)
6766 (print_frame_info, print_frame): Add frame_print_options parameter
6767 and use it.
6768 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6769 (backtrace_command_1): Add frame_print_options and
6770 backtrace_cmd_options parameters and use them.
6771 (make_backtrace_options_def_group): New.
6772 (backtrace_command): Process command options with
6773 gdb::option::process_options.
6774 (backtrace_command_completer): New.
6775 (_initialize_stack): Extend "backtrace"'s help to mention
6776 supported options. Install completer for "backtrace".
6777 Install some settings commands with add_setshow_cmds_for_options.
6778
6779 2019-06-13 Pedro Alves <palves@redhat.com>
6780
6781 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6782 and that "set/show print raw frame-arguments" are now deprecated.
6783
6784 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6785 command.
6786 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6787 * stack.c (_initialize_stack): Install "set/show print
6788 raw-frame-arguments", and deprecate "set/show print raw
6789 frame-arguments".
6790 * valprint.c (_initialize_valprint): Deprecate "set/show print
6791 raw".
6792
6793 2019-06-13 Pedro Alves <palves@redhat.com>
6794
6795 * compile/compile.c (struct compile_options): New.
6796 (compile_flag_option_def, compile_command_option_defs)
6797 (make_compile_options_def_group): New.
6798 (compile_file_command): Handle options with
6799 gdb::option::process_options.
6800 (compile_file_command_completer): New function.
6801 (compile_code_command): Handle options with
6802 gdb::option::process_options.
6803 (compile_code_command_completer): New function.
6804 (_initialize_compiler): Install completers for "compile code" and
6805 "compile file". Mention available options in "compile code" and
6806 "compile code"'s help.
6807 * completer.c (advance_to_completion_word): New, factored out from
6808 ...
6809 (advance_to_expression_complete_word_point): ... this.
6810 (advance_to_filename_complete_word_point): New.
6811 * completer.h (advance_to_filename_complete_word_point): New
6812 declaration.
6813
6814 2019-06-13 Pedro Alves <palves@redhat.com>
6815
6816 * compile/compile.c: Include "cli/cli-option.h".
6817 (compile_print_value): Scope data pointer is now a
6818 value_print_options pointer; adjust.
6819 (compile_print_command): Process options. Scope data pointer is
6820 now a value_print_options pointer; adjust.
6821 (_initialize_compile): Update "compile print"'s help to include
6822 supported options. Install a completer for "compile print".
6823 * cp-valprint.c (show_vtblprint, show_objectprint)
6824 (show_static_field_print): Delete.
6825 (_initialize_cp_valprint): Don't install "set print
6826 static-members", "set print vtbl", "set print object" here.
6827 * printcmd.c: Include "cli/cli-option.h" and
6828 "common/gdb_optional.h".
6829 (print_command_parse_format): Rework to fill in a
6830 value_print_options instead of a format_data.
6831 (print_value): Change parameter type from format_data pointer to
6832 value_print_options reference. Adjust.
6833 (print_command_1): Process options. Adjust to pass down a
6834 value_print_options.
6835 (print_command_completer): New.
6836 (_initialize_printcmd): Install print_command_completer as
6837 handle_brkchars completer for the "print" command. Update
6838 "print"'s help to include supported options.
6839 * valprint.c: Include "cli/cli-option.h".
6840 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6841 here from cp-valprint.c.
6842 (boolean_option_def, uinteger_option_def)
6843 (value_print_option_defs, make_value_print_options_def_group):
6844 New. Use gdb::option::add_setshow_cmds_for_options to install
6845 "set print elements", "set print null-stop", "set print repeats",
6846 "set print pretty", "set print union", "set print array", "set
6847 print address", "set print symbol", "set print array-indexes".
6848 * valprint.h: Include <string> and "cli/cli-option.h".
6849 (make_value_print_options_def_group): Declare.
6850 (print_value): Change parameter type from format_data pointer to
6851 value_print_options reference.
6852 (print_command_completer): Declare.
6853
6854 2019-06-13 Pedro Alves <palves@redhat.com>
6855
6856 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6857 (COMMON_SFILES): Add maint-test-settings.c.
6858 * cli/cli-decode.c (boolean_enums): New global, factored out from
6859 ...
6860 (add_setshow_boolean_cmd): ... here.
6861 * cli/cli-decode.h (boolean_enums): Declare.
6862 * cli/cli-option.c: New file.
6863 * cli/cli-option.h: New file.
6864 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6865 factored out from ...
6866 (parse_cli_boolean_value(const char *)): ... this.
6867 (is_unlimited_literal): Change parameter type to pointer to
6868 pointer. Adjust and advance ARG pointer.
6869 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6870 (parse_cli_var_enum): New, factored out from ...
6871 (do_set_command): ... this. Adjust.
6872 * cli/cli-setshow.h (parse_cli_boolean_value)
6873 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6874 (parse_cli_var_enum): Declare.
6875 * cli/cli-utils.c: Include "cli/cli-option.h".
6876 (get_ulongest): New.
6877 * cli/cli-utils.h (get_ulongest): Declare.
6878 (check_for_argument): New overloads.
6879 * maint-test-options.c: New file.
6880
6881 2019-06-13 Pedro Alves <palves@redhat.com>
6882
6883 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6884 parse a range if "-" is at the end of the string.
6885
6886 2019-06-13 Pedro Alves <palves@redhat.com>
6887
6888 * cli/cli-setshow.c (parse_auto_binary_operation)
6889 (parse_cli_boolean_value): Don't allow "o".
6890
6891 2019-06-13 Pedro Alves <palves@redhat.com>
6892
6893 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6894 * NEWS: Mention maint test-settings KIND.
6895 * maint-test-settings.c: New file.
6896
6897 2019-06-13 Pedro Alves <palves@redhat.com>
6898
6899 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6900 completer.
6901 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6902 "set" completers.
6903
6904 2019-06-13 Pedro Alves <palves@redhat.com>
6905
6906 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6907 after item.
6908
6909 2019-06-13 Pedro Alves <palves@redhat.com>
6910
6911 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6912
6913 2019-06-13 Pedro Alves <palves@redhat.com>
6914
6915 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6916 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6917 call.
6918 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6919 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6920 calls.
6921 (check_for_argument): Skip spaces after argument.
6922
6923 2019-06-13 Pedro Alves <palves@redhat.com>
6924
6925 * thread.c (thread_apply_command): Adjust TID parsing.
6926 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6927 detected before end of string.
6928 (tid_is_in_list): Error out if LIST is invalid.
6929
6930 2019-06-13 Pedro Alves <palves@redhat.com>
6931
6932 * completer.c (complete_line_internal_1): Rewind completion word
6933 point.
6934 (completion_tracker::advance_custom_word_point_by): Change
6935 parameter type to int.
6936 * completer.h (completion_tracker::advance_custom_word_point_by):
6937 Likewise.
6938
6939 2019-06-13 Pedro Alves <palves@redhat.com>
6940
6941 * completer.c (advance_to_completion_word): Handle delimiters.
6942
6943 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6944
6945 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6946
6947 2019-06-11 Tom Tromey <tom@tromey.com>
6948
6949 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6950 (xmalloc_failed): Move to alloc.c.
6951 * alloc.c: New file.
6952 * Makefile.in (COMMON_SFILES): Add alloc.c.
6953
6954 2019-06-11 Tom Tromey <tom@tromey.com>
6955
6956 * nat/linux-waitpid.c: Don't include server.h.
6957 (linux_debug): Remove.
6958 (my_waitpid): Update.
6959
6960 2019-06-11 Tom Tromey <tromey@adacore.com>
6961
6962 * infcall.c (_initialize_infcall): Remove trailing newline from
6963 help.
6964 * user-regs.c (_initialize_user_regs): Remove trailing newline
6965 from help.
6966 * typeprint.c (_initialize_typeprint): Remove trailing newline
6967 from help.
6968 * reverse.c (_initialize_reverse): Remove trailing newlines from
6969 help.
6970 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6971 from help.
6972 * language.c (add_set_language_command): Remove trailing newline
6973 from help.
6974 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6975 help.
6976 * disasm.c (_initialize_disasm): Remove trailing newline from
6977 help.
6978 * top.c (init_main): Remove trailing newline from help.
6979 * interps.c (_initialize_interpreter): Remove trailing newline
6980 from help.
6981 * btrace.c (_initialize_btrace): Remove trailing newlines from
6982 help.
6983 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6984 from help.
6985 * python/python.c (_initialize_python): Remove trailing newline
6986 from help.
6987 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6988 help.
6989 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6990 from help. Reformat some text.
6991 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6992 from help.
6993 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6994 newline from help.
6995
6996 2019-06-11 Tom Tromey <tromey@adacore.com>
6997
6998 * darwin-nat.c (darwin_decode_exception_message)
6999 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7000
7001 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
7002
7003 * valops.c (value_slice): Check for not allocated or not
7004 associated values.
7005
7006 2019-06-10 Tom de Vries <tdevries@suse.de>
7007
7008 PR gdb/24618
7009 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7010 sure an empty slot (defined by a 32-bit zero pair) is recognized as
7011 invalid.
7012
7013 2019-06-10 Tom de Vries <tdevries@suse.de>
7014
7015 PR gdb/24611
7016 * linespec.c (linespec_lexer_lex_string): Remove incorrect
7017 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
7018
7019 2019-06-10 Tom de Vries <tdevries@suse.de>
7020
7021 PR symtab/24545
7022 * symtab.c (struct demangled_name_entry): Add language field.
7023 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
7024 static minimal symbol". Set and use language field.
7025
7026 2019-06-10 Tom Tromey <tromey@adacore.com>
7027
7028 * ada-lang.c (_initialize_ada_language): Update help text.
7029
7030 2019-06-10 Tom Tromey <tromey@adacore.com>
7031
7032 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7033 with a newline.
7034 * guile/guile.c (handle_boot_error): Don't end warning with a
7035 newline.
7036 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7037 warning with a newline.
7038 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7039 newline.
7040 (s12z_frame_cache): Likewise.
7041 * dwarf-index-cache.c (index_cache::store): Don't end warning with
7042 a newline.
7043 * solib-svr4.c (disable_probes_interface): Don't end warning with
7044 a newline.
7045 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7046 newline.
7047 * python/python.c (do_finish_initialization): Don't end warning
7048 with a newline.
7049
7050 2019-06-10 Tom Tromey <tom@tromey.com>
7051
7052 * python/py-breakpoint.c (gdbpy_breakpoint_created)
7053 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7054 gdbpy_enter.
7055
7056 2019-06-10 Tom Tromey <tromey@adacore.com>
7057
7058 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7059 data.
7060 (elf_new_init): Don't call stabsread_new_init.
7061 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7062 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
7063 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7064
7065 2019-06-10 Tom de Vries <tdevries@suse.de>
7066
7067 PR symtab/16264
7068 PR symtab/24517
7069 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7070
7071 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
7072
7073 * source.c (find_and_open_source): Also rewrite relative file
7074 names.
7075
7076 2019-04-26 Amos Bird <amosbird@gmail.com>
7077
7078 * annotate.c (annotate_thread_exited): Add "thread-exited"
7079 annotation.
7080
7081 2019-06-06 Tom Tromey <tromey@adacore.com>
7082
7083 * maint.h (class scoped_command_stats): Use
7084 DISABLE_COPY_AND_ASSIGN.
7085 <print_time>: New method.
7086 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7087 print_time.
7088 (scoped_command_stats::print_time): New method.
7089
7090 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
7091
7092 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7093 instructions of lengths 6 or 8 bytes.
7094
7095 2019-06-04 Pedro Alves <palves@redhat.com>
7096
7097 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7098
7099 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7100 * breakpoint.c (condition_completer): Likewise.
7101 * cli/cli-dump.c (scan_expression): Likewise.
7102 * common/filestuff.c (mkdir_recursive): Likewise.
7103 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7104 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7105 (gdb_abspath): Likewise.
7106 * compile/compile-cplus-types.c
7107 (compile_cplus_instance::decl_name): Likewise.
7108 * completer.c (complete_explicit_location):
7109 (signal_completer, reg_or_group_completer_1): Likewise.
7110 * cp-support.c (cp_remove_params_if_any): Likewise.
7111 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7112 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7113 * infcmd.c (strip_bg_char): Likewise.
7114 * linespec.c (copy_token_string): Likewise.
7115 * mi/mi-main.c (output_cores): Likewise.
7116 * psymtab.c (psymtab_search_name):
7117 * symfile.c (test_set_ext_lang_command): Likewise.
7118 * target.c (target_fileio_read_stralloc): Likewise.
7119 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7120 * value.c (complete_internalvar): Likewise.
7121
7122 2019-06-04 Christian Biesinger <cbiesinger@google.com>
7123
7124 Add objfile property to gdb.Type.
7125 * NEWS: Mention Python API addition.
7126 * python/py-type.c (typy_get_objfile): New method.
7127
7128 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7129
7130 * NEWS: Mention the new set|show style [title|highlight].
7131 Mention changes to "show style", "help" and "apropos".
7132
7133 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7134
7135 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7136 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
7137 instead of print_help_for_command.
7138 (print_doc_of_command): New function.
7139 (help_list): Add 'apropos -v word' suggestion.
7140 (print_help_for_command): Style the command name using title style.
7141 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7142 (_initialize_cli_cmds): Describe -v in apropos_command help.
7143
7144 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7145
7146 * cli/cli-style.h (cli_style_option): Add name in constructor,
7147 add m_name class member, add constructor with intensity,
7148 add name class function.
7149 (cli_style_option::add_setshow_commands): Remove name argument.
7150 (highlight_style, title_style): New styles.
7151 * cli/cli-style.c (do_show): New function that shows a style
7152 characteristic styling the style name with itself.
7153 (set_style_name): New function.
7154 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7155 Update all callers according to the changes in cli/cli-style.h.
7156 * utils.h (fputs_highlighted): New function.
7157 * utils.c (fputs_highlighted): Likewise.
7158
7159 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7160
7161 * NEWS: Mention new pipe command and new convenience variables.
7162
7163 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7164
7165 * cli/cli-cmds.c (pipe_command): New function.
7166 (_initialize_cli_cmds): Call add_com for pipe_command.
7167 Define | as an alias for pipe.
7168 (exit_status_set_internal_vars): New function.
7169 (shell_escape): Call exit_status_set_internal_vars.
7170 cli/cli-decode.c (find_command_name_length): Recognize | as
7171 a single character command.
7172
7173 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7174
7175 * gdbcmd.h (execute_command_to_ui_file): New declaration.
7176 top.c (execute_command_to_ui_file): New function, mostly a copy
7177 of execute_command_to_string.
7178 (execute_command_to_string): Implement by calling
7179 execute_command_to_ui_file.
7180
7181 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7182
7183 * top.h (saved_command_line): Remove declaration.
7184 * top.c (previous_saved_command_line, previous_repeat_arguments):
7185 New variables.
7186 (saved_command_line): Make static, define together with other
7187 'repeat variables'.
7188 (dont_repeat): Clear repeat_arguments.
7189 (repeat_previous, get_saved_command_line, save_command_line):
7190 New functions.
7191 (gdb_init): Initialize saved_command_line
7192 and previous_saved_command_line.
7193 * main.c (captured_main_1): Remove saved_command_line initialization.
7194 * event-top.c (handle_line_of_input): Update to use
7195 the new 'repeat' related functions instead of direct access to
7196 saved_command_line.
7197 * command.h (repeat_previous, get_saved_command_line,
7198 save_command_line): New declarations.
7199 (dont_repeat): Add comment.
7200
7201 2019-05-30 Tom Tromey <tromey@adacore.com>
7202
7203 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7204 Fix comment.
7205 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7206
7207 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
7208
7209 PR cli/24587
7210 * completer.c (complete): Initialize variable word.
7211
7212 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
7213
7214 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7215 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7216 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7217 'body' is NULL to the outter 'if', protecting the '!is_define'
7218 situation as well.
7219
7220 2019-05-29 Tom Tromey <tromey@adacore.com>
7221
7222 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7223 (dwarf_unknown): New function.
7224 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7225 (dwarf_type_encoding_name): Use dwarf_unknown.
7226
7227 2019-05-29 Tom Tromey <tromey@adacore.com>
7228
7229 PR c++/20020:
7230 * cp-valprint.c (cp_print_value_fields): Call
7231 cp_print_static_field inside "try".
7232
7233 2019-05-29 Tom Tromey <tromey@adacore.com>
7234
7235 * inflow.c (struct terminal_info): Add default operator=.
7236 * configure: Rebuild.
7237 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7238 -Wdeprecated-copy-dtor, -Wredundant-move.
7239
7240 2019-05-29 Tom Tromey <tromey@adacore.com>
7241
7242 * NEWS: Add entry.
7243 * infcmd.c (print_return_value_1): Handle finish_print
7244 option.
7245 (show_print_finish): New function.
7246 (_initialize_infcmd): Add "set/show print finish" commands.
7247 * valprint.c (user_print_options): Initialize new member.
7248 * valprint.h (struct value_print_options) <finish_print>: New
7249 member.
7250
7251 2019-05-28 Tom Tromey <tromey@adacore.com>
7252
7253 * ada-lang.c (ada_remove_Xbn_suffix)
7254 (find_old_style_renaming_symbol)
7255 (parse_old_style_renaming): Remove.
7256 (ada_find_renaming_symbol): Don't call
7257 find_old_style_renaming_symbol.
7258 (ada_is_renaming_symbol): Rename from
7259 ada_find_renaming_symbol. Remove "block" parameter. Return
7260 bool. Now static.
7261 (ada_read_var_value): Update and simplify.
7262 * ada-exp.y (write_var_or_type): Remove old code.
7263
7264 2019-05-28 Alan Hayward <alan.hayward@arm.com>
7265
7266 PR gdb/25010
7267 * event-top.c: Remove include comment.
7268 * inflow.c (class scoped_ignore_sigttou): Move from here...
7269 * inflow.h (class scoped_ignore_sigttou): ...to here.
7270 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7271 * top.c: Remove include comment.
7272
7273 2019-05-27 Tom Tromey <tom@tromey.com>
7274
7275 * NEWS: Fix typo.
7276
7277 2019-05-22 Tom Tromey <tromey@adacore.com>
7278
7279 * target.c (target_follow_exec): Constify parameter.
7280 * target-delegates.c: Rebuild.
7281 * remote.c (remote_target::follow_exec): Constify parameter.
7282 * infrun.c (follow_exec): Constify parameter.
7283 * target.h (struct target_ops) <follow_exec>: Constify parameter.
7284 (target_follow_exec): Likewise.
7285
7286 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7287
7288 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7289 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7290
7291 2019-05-22 Alan Hayward <alan.hayward@arm.com>
7292
7293 * NEWS: Add debugredirect and testsuite sections.
7294
7295 2019-05-22 Simon Cook <simon.cook@embecosm.com>
7296
7297 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7298 target descriptions using exclusively floating point register name
7299 aliases.
7300
7301 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
7302
7303 PR gdb/18644:
7304 * f-lang.c (build_fortran_types): Handle the case where
7305 gdbarch_floatformat_for_type returns a nullptr.
7306
7307 2019-05-21 Tom de Vries <tdevries@suse.de>
7308
7309 PR cli/24587
7310 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7311
7312 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7313
7314 PR gdb/18644:
7315 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7316 16-byte floats.
7317 * i386-tdep.c (i386_floatformat_for_type): Use
7318 floatformats_ia64_quad for the 16-byte floating point component
7319 within a fortran 32-byte complex number.
7320
7321 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
7322
7323 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7324 delete default constructor.
7325 (find_partial_die): Update to return const struct.
7326 (partial_die_parent_scope): Move variable declaration into scope
7327 of its use and change its type to auto.
7328 (guess_partial_die_structure_name): Likewise.
7329 (partial_die_info::fixup): Likewise.
7330
7331 2019-05-17 Tom Tromey <tromey@adacore.com>
7332
7333 * source.c (find_and_open_source): Remove cast.
7334
7335 2019-05-17 Tom Tromey <tromey@adacore.com>
7336
7337 * annotate.c (annotate_source): Make "filename" const.
7338 * annotate.h (annotate_source): Use const.
7339
7340 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7341
7342 * disasm.c (set_disassembler_options): Send errors to stderr.
7343
7344 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7345
7346 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7347 (cli_interp_base::set_logging): Check debug_redirect.
7348 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7349 * cli/cli-logging.c (debug_redirect): Add static variable.
7350 (pop_output_files): Add default param.
7351 (handle_redirections): Print debug setting.
7352 (show_logging_command): Likewise.
7353 (_initialize_cli_logging): Add debugredirect command.
7354 * interps.c (current_interp_set_logging): Add debug_redirect
7355 parameter.
7356 * interps.h (set_logging): Add debug_redirect parameter.
7357 (current_interp_set_logging): Likewise.
7358 * mi/mi-common.h: Likewise.
7359 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7360
7361 2019-05-17 Alan Hayward <alan.hayward@arm.com>
7362 Tom Tromey <tromey@adacore.com>
7363
7364 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7365 directly.
7366 * cli/cli-interp.h (make_logging_output): Remove declaration.
7367 * cli/cli-logging.c (make_logging_output): Remove function.
7368 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7369 directly.
7370 * ui-file.c (tee_file::tee_file): Remove bools.
7371 (tee_file::~tee_file): Remove deletes.
7372 * ui-file.h (tee_file): Remove bools.
7373
7374 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
7375
7376 * mi/mi-cmds.h (mi_cmd_complete): New function.
7377 * mi/mi-main.c (mi_cmd_complete): Likewise.
7378 * mi/mi-cmds.c: Define new MI command -complete.
7379 * NEWS: Mention new -complete command.
7380
7381 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
7382
7383 * completer.h (complete): New function.
7384 * completer.c (complete): Likewise.
7385 * cli/cli-cmds.c: (complete_command): Update to use new complete()
7386 function defined in completer.h.
7387
7388 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
7389
7390 * MAINTAINERS (Write After Approval): Add myself.
7391
7392 2019-05-17 Tom de Vries <tdevries@suse.de>
7393
7394 PR gdb/24094
7395 * dwarf2read.c (struct cu_partial_die_info): New struct.
7396 (find_partial_die): Return cu_partial_die_info.
7397 (partial_die_parent_scope, guess_partial_die_structure_name)
7398 (partial_die_info::fixup): Handle new return type of find_partial_die.
7399
7400 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7401
7402 PR breakpoints/24541
7403 * stap-probe.c (stap_parse_register_operand): Make "regname" an
7404 "std::string", simplifying the algorithm.
7405
7406 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7407
7408 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7409 (stap_static_probe_ops::get_probes): Likewise.
7410
7411 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7412
7413 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7414 '-')" and "else if".
7415 (stap_parse_single_operand): Join checks for
7416 "gdbarch_stap_parse_special_token_p" and
7417 "gdbarch_stap_parse_special_token" in the same "if" statement.
7418 Invert check when verifying for operation on register
7419 displacement.
7420
7421 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7422
7423 * stap-probe.c (stap_get_opcode): Update comment.
7424 (stap_get_expected_argument_type): Likewise.
7425 (handle_stap_probe): Likewise.
7426
7427 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
7428
7429 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7430 return type to 'bool'. Adjust comment. Use 'bool' when
7431 appropriate.
7432 (i386_stap_parse_special_token_three_arg_disp): Likewise.
7433 * stap-probe.c (stap_parse_argument_1): Likewise.
7434 (stap_is_operator): Likewise.
7435 (stap_is_generic_prefix): Likewise.
7436 (stap_is_register_prefix): Likewise.
7437 (stap_is_register_indirection_prefix): Likewise.
7438 (stap_is_integer_prefix): Likewise.
7439 (stap_generic_check_suffix): Likewise.
7440 (stap_check_integer_suffix): Likewise.
7441 (stap_check_register_suffix): Likewise.
7442 (stap_check_register_indirection_suffix): Likewise.
7443 (stap_parse_register_operand): Likewise.
7444 (stap_parse_single_operand): Likewise.
7445 (stap_parse_argument_1): Likewise.
7446 (stap_probe::get_argument_count): Likewise.
7447 (stap_is_operator): Likewise.
7448
7449 2019-05-16 Tom Tromey <tromey@adacore.com>
7450
7451 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7452 keyword to foreach.
7453
7454 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
7455
7456 * linux-thread-db.c (try_thread_db_load_1): Change return type
7457 to bool.
7458 (try_thread_db_load): Likewise.
7459 (try_thread_db_load_from_pdir_1): Likewise.
7460 (try_thread_db_load_from_pdir): Likewise.
7461 (try_thread_db_load_from_sdir): Likewise.
7462 (try_thread_db_load_from_dir): Likewise.
7463 (thread_db_load_search): Likewise.
7464 (has_libpthread): Likewise.
7465 (thread_db_load): Likewise.
7466
7467 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
7468
7469 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7470 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7471 NULL, and complain/return if that's the case.
7472
7473 2019-05-15 John Darrington <john@darrington.wattle.id.au>
7474
7475 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7476 (advance, posn, abstract_read_memory): New functions.
7477 [struct mem_read_abstraction]: New struct.
7478 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7479
7480 2019-05-14 Tom Tromey <tromey@adacore.com>
7481
7482 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7483 value is not lval_memory.
7484
7485 2019-05-14 Tom Tromey <tromey@adacore.com>
7486
7487 * solib.c (info_sharedlibrary_command): Style the file name.
7488
7489 2019-05-14 Alan Hayward <alan.hayward@arm.com>
7490
7491 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7492 (aarch64_vnv_type): Likewise.
7493 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7494 * common/tdesc.c: Likewise.
7495 * common/tdesc.h (enum tdesc_type_kind): Likewise.
7496 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7497 * features/aarch64-fpu.xml: Add ieee half view.
7498 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7499 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7500 * gdbtypes.h (struct builtin_type): Likewise.
7501 (struct objfile_type): Likewise.
7502
7503 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
7504
7505 * language.c (language_sniff_from_mangled_name): Fix "langauge"
7506 typo.
7507 * location.h (string_to_event_location): Likewise.
7508
7509 2019-05-11 Joel Brobecker <brobecker@adacore.com>
7510
7511 GDB 8.3 released.
7512
7513 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
7514
7515 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7516 New variable declaration.
7517 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7518 New variable.
7519 (print_one_breakpoint): Use ui_out::test_flags and new global
7520 variable to compute use_fixed_output.
7521 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7522 Remove.
7523 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7524 (mi_multi_location_breakpoint_output_fixed): Remove.
7525 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7526 new variable.
7527 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7528 fix_multi_location_breakpoint_output flag if version >= 3.
7529 * ui-out.h (enum ui_out_flag)
7530 <fix_multi_location_breakpoint_output>: New enumerator.
7531
7532 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
7533
7534 * contrib/cc-with-tweaks.sh: Validate dwz's work.
7535
7536 2019-05-10 Tom Tromey <tromey@adacore.com>
7537
7538 * ada-lang.c (catch_ada_completer): New function.
7539 (_initialize_ada_language): Use it.
7540
7541 2019-05-10 Tom Tromey <tromey@adacore.com>
7542
7543 * thread.c (print_thread_info): Make "requested_threads" const.
7544 * gdbthread.h (print_thread_info): Make "requested_threads"
7545 const.
7546 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7547 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7548
7549 2019-05-08 Tom Tromey <tom@tromey.com>
7550
7551 * gdbtypes.c (objfile_type_data): Change type.
7552 (objfile_type, _initialize_gdbtypes): Update.
7553
7554 2019-05-08 Tom Tromey <tom@tromey.com>
7555
7556 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7557 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7558 (_initialize_dwarf2_frame): Update.
7559
7560 2019-05-08 Tom Tromey <tom@tromey.com>
7561
7562 * objc-lang.c (objc_objfile_data): Change type.
7563 (find_methods): Update.
7564 (_initialize_objc_lang): Remove.
7565
7566 2019-05-08 Tom Tromey <tom@tromey.com>
7567
7568 * stabsread.c (rs6000_builtin_type_data): Change type.
7569 (rs6000_builtin_type, _initialize_stabsread): Update.
7570
7571 2019-05-08 Tom Tromey <tom@tromey.com>
7572
7573 * mips-tdep.c (mips_pdr_data): Remove.
7574 (_initialize_mips_tdep): Update.
7575
7576 2019-05-08 Tom Tromey <tom@tromey.com>
7577
7578 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7579 (hppa_init_objfile_priv_data, read_unwind_info)
7580 (find_unwind_entry, _initialize_hppa_tdep): Update.
7581
7582 2019-05-08 Tom Tromey <tom@tromey.com>
7583
7584 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7585 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7586 on obstack.
7587 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7588
7589 2019-05-08 Tom Tromey <tom@tromey.com>
7590
7591 * mdebugread.c (basic_type_data): Change type.
7592 (basic_type, _initialize_mdebugread): Update.
7593
7594 2019-05-08 Tom Tromey <tom@tromey.com>
7595
7596 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7597
7598 2019-05-08 Tom Tromey <tom@tromey.com>
7599
7600 * nto-tdep.c (nto_inferior_data_reg): Change type.
7601 (nto_inferior_data): Update.
7602 (nto_inferior_data_cleanup, nto_new_inferior_data)
7603 (_initialize_nto_tdep): Remove.
7604 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7605
7606 2019-05-08 Tom Tromey <tom@tromey.com>
7607
7608 * ada-lang.c (struct ada_inferior_data): Add initializers.
7609 (ada_inferior_data): Change type.
7610 (ada_inferior_data_cleanup): Remove.
7611 (get_ada_inferior_data, ada_inferior_exit)
7612 (struct ada_pspace_data): Add initializers, destructor.
7613 (ada_pspace_data_handle): Change type.
7614 (get_ada_pspace_data): Update.
7615 (ada_pspace_data_cleanup): Remove.
7616
7617 2019-05-08 Tom Tromey <tom@tromey.com>
7618
7619 * coffread.c (struct coff_symfile_info): Add initializers.
7620 (coff_objfile_data_key): Move lower. Change type.
7621 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7622 Update.
7623 (coff_free_info): Remove.
7624
7625 2019-05-08 Tom Tromey <tom@tromey.com>
7626
7627 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7628 (fbsd_pspace_data_handle): Move lower. Change type.
7629 (get_fbsd_pspace_data): Update.
7630 (fbsd_pspace_data_cleanup): Remove.
7631 (_initialize_fbsd_tdep): Update.
7632
7633 2019-05-08 Tom Tromey <tom@tromey.com>
7634
7635 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7636 (get_ada_tasks_pspace_data): Update.
7637 (ada_tasks_pspace_data_cleanup): Remove.
7638 (_initialize_tasks): Update.
7639 (ada_tasks_inferior_data_handle): Change type.
7640 (get_ada_tasks_inferior_data): Update.
7641 (ada_tasks_inferior_data_cleanup): Remove.
7642 (struct ada_tasks_pspace_data): Add initializers.
7643
7644 2019-05-08 Tom Tromey <tom@tromey.com>
7645
7646 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7647 * symfile-debug.c (debug_sym_get_probes): Change type.
7648 * stap-probe.c (handle_stap_probe):
7649 (stap_static_probe_ops::get_probes): Change type.
7650 * probe.h (class static_probe_ops) <get_probes>: Change type.
7651 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7652 (parse_probes_in_pspace): Update.
7653 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7654 Update.
7655 (any_static_probe_ops::get_probes): Change type.
7656 * elfread.c (elfread_data): New typedef.
7657 (probe_key): Change type.
7658 (elf_get_probes): Likewise. Update.
7659 (probe_key_free): Remove.
7660 (_initialize_elfread): Update.
7661 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7662 Change type.
7663 (dtrace_process_dof_probe, dtrace_process_dof)
7664 (dtrace_static_probe_ops::get_probe): Change type.
7665
7666 2019-05-08 Tom Tromey <tom@tromey.com>
7667
7668 * xcoffread.c (struct xcoff_symfile_info): Rename from
7669 coff_symfile_info. Add initializers.
7670 (xcoff_objfile_data_key): Move lower. Change type.
7671 (XCOFF_DATA): Rewrite.
7672 (xcoff_free_info): Remove.
7673 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7674 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7675 (xcoff_initial_scan): Update.
7676
7677 2019-05-08 Tom Tromey <tom@tromey.com>
7678
7679 * solib-svr4.c (struct svr4_info): Add initializers and
7680 destructor.
7681 <probes_table>: Now an htab_up.
7682 (solib_svr4_pspace_data): Change type.
7683 (free_probes_table): Simplify.
7684 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7685 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7686 (probes_table_remove_objfile_probes, register_solib_event_probe)
7687 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7688 (_initialize_svr4_solib): Update.
7689
7690 2019-05-08 Tom Tromey <tom@tromey.com>
7691
7692 * remote.c (remote_pspace_data): Change type.
7693 (remote_pspace_data_cleanup): Remove.
7694 (get_remote_exec_file, set_pspace_remote_exec_file)
7695 (_initialize_remote): Update.
7696
7697 2019-05-08 Tom Tromey <tom@tromey.com>
7698
7699 * breakpoint.c (breakpoint_objfile_key): Change type.
7700 (get_breakpoint_objfile_data): Update.
7701 (free_breakpoint_objfile_data): Remove.
7702 (_initialize_breakpoint): Update.
7703
7704 2019-05-08 Tom Tromey <tom@tromey.com>
7705
7706 * linux-tdep.c (struct linux_info): Add initializers.
7707 (linux_inferior_data): Move. Change type.
7708 (invalidate_linux_cache_inf): Update.
7709 (linux_inferior_data_cleanup): Remove.
7710 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7711
7712 2019-05-08 Tom Tromey <tom@tromey.com>
7713
7714 * auxv.c (auxv_inferior_data): Move. Change type.
7715 (auxv_inferior_data_cleanup): Remove.
7716 (invalidate_auxv_cache_inf): Rewrite.
7717 (get_auxv_inferior_data, _initialize_auxv): Update.
7718
7719 2019-05-08 Tom Tromey <tom@tromey.com>
7720
7721 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7722 (symfile_debug_objfile_data_key): Change type.
7723 (symfile_debug_installed, debug_qf_has_symbols)
7724 (debug_qf_find_last_source_symtab)
7725 (debug_qf_forget_cached_source_info)
7726 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7727 (debug_qf_print_stats, debug_qf_dump)
7728 (debug_qf_expand_symtabs_for_function)
7729 (debug_qf_expand_all_symtabs)
7730 (debug_qf_expand_symtabs_with_fullname)
7731 (debug_qf_map_matching_symbols)
7732 (debug_qf_expand_symtabs_matching)
7733 (debug_qf_find_pc_sect_compunit_symtab)
7734 (debug_qf_map_symbol_filenames)
7735 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7736 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7737 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7738 (debug_sym_read_linetable, debug_sym_relocate): Update.
7739 (symfile_debug_free_objfile): Remove.
7740 (install_symfile_debug_logging, _initialize_symfile_debug):
7741 Update.
7742
7743 2019-05-08 Tom Tromey <tom@tromey.com>
7744
7745 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7746 allocate_on_obstack.
7747 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7748 (get_dwarf2_per_objfile): Update.
7749 (set_dwarf2_per_objfile): Remove.
7750 (dwarf2_has_info, dwarf2_get_section_info): Update.
7751 (dwarf2_free_objfile): Remove.
7752 (_initialize_dwarf2_read): Update.
7753
7754 2019-05-08 Tom Tromey <tom@tromey.com>
7755
7756 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7757 initializers.
7758 <unsupported_script_warning_printed,
7759 script_not_found_warning_printed>: Now bool.
7760 (auto_load_pspace_data): Change type.
7761 (~auto_load_pspace_info): Rename from
7762 auto_load_pspace_data_cleanup.
7763 (get_auto_load_pspace_data, init_loaded_scripts_info)
7764 (clear_section_scripts, maybe_print_unsupported_script_warning)
7765 (maybe_print_script_not_found_warning, _initialize_auto_load):
7766 Update.
7767
7768 2019-05-08 Tom Tromey <tom@tromey.com>
7769
7770 * objfiles.c (objfile_pspace_info): Add destructor and
7771 initializers.
7772 (objfiles_pspace_data): Change type.
7773 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7774 (get_objfile_pspace_data): Update.
7775 (objfiles_bfd_data): Change type.
7776 (get_objfile_bfd_data): Update.
7777 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7778
7779 2019-05-08 Tom Tromey <tom@tromey.com>
7780
7781 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7782 Change type.
7783 (get_catch_syscall_inferior_data): Update.
7784 (catch_syscall_inferior_data_cleanup): Remove.
7785 (_initialize_break_catch_syscall): Update.
7786
7787 2019-05-08 Tom Tromey <tom@tromey.com>
7788
7789 * inflow.c (struct terminal_info): Add destructor and
7790 initializers.
7791 (inflow_inferior_data): Change type.
7792 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7793 (get_inflow_inferior_data, inflow_inferior_exit)
7794 (swap_terminal_info, _initialize_inflow): Update.
7795
7796 2019-05-08 Tom Tromey <tom@tromey.com>
7797
7798 * target-dcache.c (target_dcache_cleanup): Remove.
7799 (target_dcache_aspace_key): Change type.
7800 (target_dcache_init_p, target_dcache_invalidate)
7801 (target_dcache_get, target_dcache_get_or_init)
7802 (_initialize_target_dcache): Update.
7803 * dcache.h (struct dcache_deleter): New.
7804
7805 2019-05-08 Tom Tromey <tom@tromey.com>
7806
7807 * symtab.c (struct symbol_cache): Add destructor and
7808 initializers.
7809 (symbol_cache_key): Move. Change type.
7810 (make_symbol_cache, free_symbol_cache): Remove.
7811 (get_symbol_cache): Update.
7812 (symbol_cache_cleanup): Remove.
7813 (ALL_PSPACES, symbol_cache_flush)
7814 (maintenance_print_symbol_cache)
7815 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7816 Update.
7817
7818 2019-05-08 Tom Tromey <tom@tromey.com>
7819
7820 * symtab.c (struct main_info): Add destructor and initializers.
7821 (main_progspace_key): Move. Change type.
7822 (get_main_info): Update.
7823 (main_info_cleanup): Remove.
7824 (_initialize_symtab): Update.
7825
7826 2019-05-08 Tom Tromey <tom@tromey.com>
7827
7828 * registry.h (DECLARE_REGISTRY): Define the _key class.
7829
7830 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7831
7832 * NEWS: Merge two 'New commands' sections.
7833
7834 2019-05-08 Joel Brobecker <brobecker@adacore.com>
7835
7836 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7837 parameter and use Ada language definition instead.
7838 (ada_val_print_ptr): Remove unused language parameter.
7839 (ada_val_print_num): Remove language parameter and use Ada language
7840 definition instead.
7841 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7842 parameter.
7843 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7844 parameter and use Ada language definition instead.
7845 (ada_val_print_1): Update all ada_val_print_xxx calls.
7846 Remove language parameter.
7847 (ada_val_print): Update ada_val_print_1 call.
7848
7849 2019-05-08 Tom Tromey <tromey@adacore.com>
7850
7851 * remote.c (remote_hw_watchpoint_limit)
7852 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7853 Now static.
7854
7855 2019-05-08 Tom Tromey <tromey@adacore.com>
7856
7857 * maint.c (_initialize_maint_cmds): Move initialization code to
7858 remote.c.
7859 (watchdog, show_watchdog): Move to remote.c.
7860 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7861 "watchdog" static.
7862 (_initialize_remote): Move initialization code from maint.c.
7863 * defs.h (watchdog): Don't declare.
7864
7865 2019-05-08 Tom Tromey <tromey@adacore.com>
7866
7867 * tui/tui-interp.c: Include main.h.
7868 * interps.c: Include main.h.
7869 * main.h (interpreter_p): Declare.
7870 * defs.h (interpreter_p): Don't declare.
7871
7872 2019-05-08 Tom Tromey <tromey@adacore.com>
7873
7874 * dwarf2loc.c: Include dwarf2read.h.
7875 * defs.h (read_unsigned_leb128): Don't declare.
7876 * dwarf2read.h (read_unsigned_leb128): Declare.
7877
7878 2019-05-08 Tom Tromey <tromey@adacore.com>
7879
7880 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7881 method.
7882
7883 2019-05-08 Tom Tromey <tromey@adacore.com>
7884
7885 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7886 when no wrap column is set.
7887
7888 2019-05-08 Tom Tromey <tromey@adacore.com>
7889
7890 * c-lang.c (c_get_string): Handle non-C-style arrays.
7891
7892 2019-05-08 Tom Tromey <tromey@adacore.com>
7893
7894 * typeprint.c (print_offset_data::update): Print the bit offset,
7895 not the number of bits remaining.
7896
7897 2019-05-08 Tom Tromey <tromey@adacore.com>
7898
7899 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7900 padding at end of comment.
7901
7902 2019-05-08 Tom Tromey <tromey@adacore.com>
7903
7904 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7905 Compare main types.
7906
7907 2019-05-06 Tom Tromey <tom@tromey.com>
7908
7909 * common/scoped_mmap.c: Include common-defs.h.
7910 * common/scoped_mmap.h: Don't include config.h.
7911
7912 2019-05-04 Tom Tromey <tom@tromey.com>
7913
7914 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7915 (struct aarch64_call_info): Add initializers.
7916 <si>: Now a std::vector.
7917 (pass_on_stack, aarch64_push_dummy_call): Update.
7918
7919 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
7920 Tom Tromey <tom@tromey.com>
7921
7922 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7923 (ppc_threads): Now a std::vector. Now static.
7924 (hwdebug_find_thread_points_by_tid)
7925 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7926 Update.
7927
7928 2019-05-04 Tom Tromey <tom@tromey.com>
7929
7930 * arc-tdep.c (arc_tdesc_init): Return bool.
7931
7932 2019-05-04 Tom Tromey <tom@tromey.com>
7933
7934 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7935 Use gdb_assert_not_reached.
7936
7937 2019-05-04 Tom Tromey <tom@tromey.com>
7938
7939 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7940 "false".
7941
7942 2019-05-04 Tom Tromey <tom@tromey.com>
7943
7944 * arc-tdep.c (arc_tdesc_init): Use bool.
7945
7946 2019-05-04 Tom Tromey <tom@tromey.com>
7947
7948 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7949
7950 2019-05-04 Tom Tromey <tom@tromey.com>
7951
7952 * cli/cli-cmds.c (valid_command_p): Return bool.
7953
7954 2019-05-04 Tom Tromey <tom@tromey.com>
7955
7956 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7957 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7958
7959 2019-05-04 Raul Tambre <raul@tambre.ee>
7960
7961 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7962 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7963 operator for comparison.
7964
7965 2019-05-04 Tom Tromey <tom@tromey.com>
7966
7967 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7968 (lookup_partial_symbol, print_partial_symbols)
7969 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7970 (psymbol_compare): Update.
7971 (add_psymbol_to_bcache): Clear the entire psymbol.
7972 (maintenance_check_psymtabs): Update.
7973 * psympriv.h (struct partial_symbol): Don't derive from
7974 general_symbol_info.
7975 <obj_section, unrelocated_address, address,
7976 set_unrelocated_address>: Update.
7977 <ginfo>: New member.
7978 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7979 (debug_names::write_psymbols): Update.
7980
7981 2019-05-04 Tom de Vries <tdevries@suse.de>
7982
7983 * contrib/cc-with-tweaks.sh: Support -n arg.
7984
7985 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7986
7987 * corelow.c (core_target::detach): Ensure frame cache and
7988 register caches are cleared.
7989 inferior.c (exit_inferior_1): Likewise.
7990
7991 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7992 Tom Tromey <tom@tromey.com>
7993
7994 * dictionary.c (collate_pending_symbols_by_language): Remove
7995 "struct" from foreach.
7996 * symtab.c (lookup_global_symbol_from_objfile)
7997 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7998 foreach.
7999 * ser-tcp.c (net_open): Remove "struct" from foreach.
8000 * objfiles.c (objfile_relocate, objfile_rebase)
8001 (objfile_has_symbols): Remove "struct" from foreach.
8002 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8003 from foreach.
8004 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8005 foreach.
8006 * darwin-nat.c (thread_info_from_private_thread_info): Remove
8007 "struct" from foreach.
8008 * ada-lang.c (create_excep_cond_exprs)
8009 (ada_exception_catchpoint_cond_string): Remove "struct" from
8010 foreach.
8011
8012 2019-05-03 Tom Tromey <tromey@adacore.com>
8013
8014 * ada-exp.y (convert_char_literal): Check suffix of each
8015 enumerator.
8016
8017 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
8018
8019 PR ada/21406:
8020 * ada-exp.y (yywrap): Don't define.
8021 * ada-lex.l (%option): Add noyywrap
8022 (yywrap): Remove.
8023
8024 2019-05-03 Eli Zaretskii <eliz@gnu.org>
8025
8026 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8027 _WIN32_WINNT to the XP level, unless already defined to a higher
8028 level.
8029
8030 * unittests/parse-connection-spec-selftests.c:
8031 * ser-tcp.c:
8032 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
8033 override.
8034
8035 * symfile.c (find_separate_debug_file): Remove colon from the
8036 drive spec of DOS/Windows file names of the target, so that the
8037 file name produced from DEBUGDIR and the target's directory will
8038 be valid on DOS/Windows systems.
8039
8040 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
8041
8042 * rust-lang.c (val_print_struct): Handle printing structures
8043 containing strings.
8044
8045 2019-05-02 Tom Tromey <tromey@adacore.com>
8046
8047 * valarith.c (_initialize_valarith): Remove.
8048
8049 2019-05-01 Tom Tromey <tromey@adacore.com>
8050
8051 * ada-lang.c (ada_value_primitive_field): Treat more fields as
8052 bitfields.
8053
8054 2019-05-01 Tom Tromey <tromey@adacore.com>
8055
8056 * ada-lang.c (ada_value_assign): Correctly compute starting offset
8057 for big-endian copies.
8058
8059 2019-04-30 Ali Tamur <tamur@google.com>
8060 * gdb/dwarf2read.c (read_3_bytes): New declaration.
8061 (read_attribute_value): Added DW_FORM_strx1-4 cases.
8062 (read_3_bytes): New function.
8063
8064 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8065
8066 * windows-nat.c (main_thread_id): Delete.
8067 (handle_output_debug_string): Replace main_thread_id by
8068 current_event.dwThreadId.
8069 (fake_create_process): Likewise.
8070 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8071 Do not set main_thread_id.
8072 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8073 current_event.dwThreadId.
8074 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8075
8076 2019-04-30 Joel Brobecker <brobecker@adacore.com>
8077
8078 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8079 Use current_event.dwThreadId instead of main_thread_id.
8080
8081 2019-04-30 Tom Tromey <tromey@adacore.com>
8082
8083 * ada-lang.c (ada_lookup_simple_minsyms): New function.
8084 (create_excep_cond_exprs): Iterate over program spaces.
8085 (ada_exception_catchpoint_cond_string): Examine all minimal
8086 symbols for exception types.
8087
8088 2019-04-30 Tom Tromey <tromey@adacore.com>
8089
8090 PR c++/24470:
8091 * dwarf2read.c (process_structure_scope): Handle case where type
8092 has template parameters but no symbol was created.
8093
8094 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8095 Chris January <chris.january@arm.com>
8096
8097 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8098 qualifier.
8099 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8100
8101 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8102
8103 * f-typeprint.c (f_print_type): Update rules for printing
8104 whitespace.
8105 (f_type_print_varspec_suffix): Likewise.
8106
8107 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8108 Chris January <chris.january@arm.com>
8109
8110 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8111 function arguments.
8112
8113 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8114
8115 * f-lang.c (build_fortran_types): Change name of void type to
8116 lower case.
8117 * f-typeprint.c (f_type_print_base): Print the name of the void
8118 type, rather than a fixed string.
8119 * f-valprint.c (f_decorations): Use lower case void string.
8120
8121 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8122 Chris January <chris.january@arm.com>
8123
8124 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8125 types for Fortran.
8126
8127 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8128 Chris January <chris.january@arm.com>
8129 David Lecomber <david.lecomber@arm.com>
8130
8131 * f-exp.y (BINOP_INTRINSIC): New token.
8132 (exp): New parser rule handling BINOP_INTRINSIC.
8133 (f77_keywords): Add new builtin procedures.
8134 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8135 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8136 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8137 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8138 (print_unop_subexp_f): New function.
8139 (print_binop_subexp_f): New function.
8140 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8141 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8142 (dump_subexp_body_f): Likewise.
8143 (operator_check_f): Likewise.
8144 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8145 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8146
8147 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8148
8149 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8150 UNOP_KIND.
8151 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8152 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8153 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8154 (operator_length_f): New fuction.
8155 (print_subexp_f): New function.
8156 (op_name_f): New function.
8157 (dump_subexp_body_f): New function.
8158 (operator_check_f): New function.
8159 (exp_descriptor_f): Replace standard expression handling functions
8160 with new functions.
8161 * gdb/fortran-operator.def: New file.
8162 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8163 * gdb/std-operator.def: Remove UNOP_KIND.
8164
8165 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
8166
8167 * std-operator.def: Remove unbalanced, stray double quote
8168 character.
8169
8170 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8171 Chris January <chris.january@arm.com>
8172 Daniel Everett <daniel.everett@arm.com>
8173 Nick Forrington <nick.forrington@arm.com>
8174 Richard Bunt <richard.bunt@arm.com>
8175
8176 * cp-valprint.c (cp_print_value_fields): Allow an additional level
8177 of depth when printing anonymous structs or unions.
8178 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8179 Don't print either the top-level value, or the children if the
8180 max-depth is exceeded.
8181 (ppscm_print_children): When printing the key of a map, allow one
8182 extra level of depth.
8183 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8184 print either the top-level value, or the children if the max-depth
8185 is exceeded.
8186 (print_children): When printing the key of a map, allow one extra
8187 level of depth.
8188 * python/py-value.c (valpy_format_string): Add max_depth keyword.
8189 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8190 (user_print_options): Initialise max_depth field.
8191 (val_print_scalar_or_string_type_p): New function.
8192 (val_print): Check to see if the max depth has been reached.
8193 (val_print_check_max_depth): Define new function.
8194 (show_print_max_depth): New function.
8195 (_initialize_valprint): Add 'print max-depth' option.
8196 * valprint.h (struct value_print_options) <max_depth>: New field.
8197 (val_print_check_max_depth): Declare new function.
8198 * NEWS: Document new feature.
8199
8200 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8201
8202 * ada-lang.c (ada_language_defn): Initialise new field.
8203 * c-lang.c (c_is_string_type_p): New function.
8204 (c_language_defn): Initialise new field.
8205 (cplus_language_defn): Initialise new field.
8206 (asm_language_defn): Initialise new field.
8207 (minimal_language_defn): Initialise new field.
8208 * c-lang.h (c_is_string_type_p): Declare new function.
8209 * d-lang.c (d_language_defn): Initialise new field.
8210 * f-lang.c (f_is_string_type_p): New function.
8211 (f_language_defn): Initialise new field.
8212 * go-lang.c (go_is_string_type_p): New function.
8213 (go_language_defn): Initialise new field.
8214 * language.c (default_is_string_type_p): New function.
8215 (unknown_language_defn): Initialise new field.
8216 (auto_language_defn): Initialise new field.
8217 * language.h (struct language_defn) <la_is_string_type_p>: New
8218 member variable.
8219 (default_is_string_type_p): Declare new function.
8220 * m2-lang.c (m2_language_defn): Initialise new field.
8221 * objc-lang.c (objc_language_defn): Initialise new field.
8222 * opencl-lang.c (opencl_language_defn): Initialise new field.
8223 * p-lang.c (pascal_is_string_type_p): New function.
8224 (pascal_language_defn): Initialise new field.
8225 * rust-lang.c (rust_is_string_type_p): New function.
8226 (rust_language_defn): Initialise new field.
8227
8228 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8229
8230 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8231 New field.
8232 * ada-lang.c (ada_language_defn): Initialise new field.
8233 * c-lang.c (c_language_defn): Likewise.
8234 (cplus_language_defn): Likewise.
8235 (asm_language_defn): Likewise.
8236 (minimal_language_defn): Likewise.
8237 * d-lang.c (d_language_defn): Likewise.
8238 * f-lang.c (f_language_defn): Likewise.
8239 * go-lang.c (go_language_defn): Likewise.
8240 * language.c (unknown_language_defn): Likewise.
8241 (auto_language_defn): Likewise.
8242 * m2-lang.c (m2_language_defn): Likewise.
8243 * objc-lang.c (objc_language_defn): Likewise.
8244 * opencl-lang.c (opencl_language_defn): Likewise.
8245 * p-lang.c (pascal_language_defn): Likewise.
8246 * rust-lang.c (rust_language_defn): Likewise.
8247
8248 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
8249
8250 * ada-lang.c (ada_is_character_type): Change return type to bool.
8251 (ada_is_string_type): Likewise.
8252 * ada-lang.h (ada_is_character_type): Update declaration
8253 (ada_is_string_type): Likewise.
8254
8255 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8256
8257 Support style in 'frame|thread apply'
8258
8259 * gdbcmd.h (execute_command_to_string): New term_out parameter.
8260 * record.c (record_start, record_stop): Update callers of
8261 execute_command_to_string with false.
8262 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8263 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8264 methods.
8265 (class string_file): New constructor with term_out parameter.
8266 Override methods term_out and can_emit_style_escape. New member
8267 term_out.
8268 (class stdio_file): Override can_emit_style_escape.
8269 (class tee_file): Override term_out and can_emit_style_escape.
8270 * utils.h (can_emit_style_escape): Remove.
8271 * utils.c (can_emit_style_escape): Likewise.
8272 Update all callers of can_emit_style_escape (SOMESTREAM) to
8273 SOMESTREAM->can_emit_style_escape.
8274 * source-cache.c (source_cache::get_source_lines): Likewise.
8275 * stack.c (frame_apply_command_count): Call execute_command_to_string
8276 passing the term_out characteristic of the current gdb_stdout.
8277 * thread.c (thr_try_catch_cmd): Likewise.
8278 * top.c (execute_command_to_string): pass term_out parameter
8279 to construct the string_file for the command output.
8280 * ui-file.c (term_cli_styling): New function (most code moved
8281 from utils.c can_emit_style_escape).
8282 (string_file::string_file, string_file::can_emit_style_escape,
8283 stdio_file::can_emit_style_escape, tee_file::term_out,
8284 tee_file::can_emit_style_escape): New functions.
8285
8286 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8287
8288 * NEWS: Mention the new set|show may-call-functions.
8289 * infcall.c (may_call_functions_p): New variable.
8290 (show_may_call_functions_p): New function.
8291 (call_function_by_hand_dummy): Throws an error if not
8292 may-call-functions.
8293 (_initialize_infcall): Call add_setshow_boolean_cmd for
8294 may-call-functions.
8295
8296 2019-04-25 Keith Seitz <keiths@redhat.com>
8297
8298 PR c++/24367
8299 * cp-support.c (inspect_type): Don't attempt substitutions
8300 of symbol with the same name.
8301
8302 2019-04-25 Tom Tromey <tromey@adacore.com>
8303
8304 PR gdb/24475:
8305 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8306 static.
8307
8308 2019-04-25 Tom Tromey <tromey@adacore.com>
8309
8310 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8311 rvalue reference.
8312 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8313 (gdb_xml_parser::parse): Use std::move.
8314 * python/python-internal.h (gdbpy_convert_exception): Take a const
8315 reference.
8316 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8317 std::move.
8318 * python/py-utils.c (gdbpy_convert_exception): Take a const
8319 reference.
8320 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8321 Use std::move.
8322 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8323 Use std::move.
8324 * mi/mi-main.c (mi_print_exception): Take a const reference.
8325 * main.c (handle_command_errors): Take a const reference.
8326 * linespec.c (parse_linespec): Use std::move.
8327 * infcall.c (run_inferior_call): Use std::move.
8328 (call_function_by_hand_dummy): Use std::move.
8329 * exec.c (try_open_exec_file): Use std::move.
8330 * exceptions.h (exception_print, exception_fprintf)
8331 (exception_print_same): Update.
8332 * exceptions.c (print_exception, exception_print)
8333 (exception_fprintf, exception_print_same): Change parameters to
8334 const reference.
8335 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8336 * common/new-op.c: Use std::move.
8337 * common/common-exceptions.h (struct gdb_exception): Add move
8338 constructor.
8339 (struct gdb_exception_error, struct gdb_exception_quit, struct
8340 gdb_quit_bad_alloc): Change constructor to move constructor.
8341 (throw_exception): Change parameter to rvalue reference.
8342 * common/common-exceptions.c (throw_exception): Take rvalue
8343 reference.
8344 * cli/cli-interp.c (safe_execute_command): Use std::move.
8345 * breakpoint.c (insert_bp_location, location_to_sals): Use
8346 std::move.
8347
8348 2019-04-25 Tom Tromey <tromey@adacore.com>
8349
8350 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8351 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8352 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8353 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8354 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8355 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8356 guile/scm-value.c: Use unpack.
8357 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8358 gdbscm_gdb_exception.
8359 (gdbscm_throw_gdb_exception): Likewise.
8360 (struct gdbscm_gdb_exception): New.
8361 (unpack): New function.
8362 (gdbscm_wrap): Use unpack.
8363
8364 2019-04-25 Tom Tromey <tromey@adacore.com>
8365
8366 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8367 (gdb_rl_callback_handler): Use std::move.
8368 * common/common-exceptions.h (struct gdb_exception): Add move
8369 assignment operator.
8370 (throw_exception_sjlj): Change "exception" to const reference.
8371 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8372 (throw_exception_sjlj): Change "exception" to const reference.
8373
8374 2019-04-25 Tom Tromey <tromey@adacore.com>
8375
8376 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8377 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8378 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8379 Update.
8380 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8381 Update.
8382 * mi/mi-interp.c (mi_interp::exec): Update.
8383 * linespec.c (parse_linespec): Update.
8384 * infcall.c (run_inferior_call): Update.
8385 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8386 * guile/scm-symbol.c (gdbscm_lookup_symbol)
8387 (gdbscm_lookup_global_symbol): Update.
8388 * guile/scm-param.c (gdbscm_parameter_value): Update.
8389 * guile/scm-frame.c (gdbscm_frame_read_register)
8390 (gdbscm_frame_read_var): Update.
8391 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8392 * exec.c (try_open_exec_file): Update.
8393 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8394 (gdb_rl_callback_handler): Update.
8395 * common/common-exceptions.h (exception_none): Don't declare.
8396 * common/common-exceptions.c (exception_none): Don't define.
8397 (struct catcher) <exception>: Update.
8398 * cli/cli-interp.c (safe_execute_command): Update.
8399 * breakpoint.c (insert_bp_location, location_to_sals): Update.
8400
8401 2019-04-25 Ali Tamur <tamur@google.com>
8402
8403 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8404 (read_attribute_value): Likewise.
8405 (dwarf2_read_addr_index): Update comment.
8406 (read_str_index): Add DW_FORM_strx.
8407 (dwarf2_string_attr): Likewise.
8408 (dwarf2_const_value_attr): Likewise.
8409 (dump_die_shallow): Likewise.
8410 (dwarf2_fetch_constant_bytes): Likewise.
8411 (skip_form_bytes): Likewise.
8412 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8413
8414 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
8415
8416 PR corefiles/11608
8417 PR corefiles/18187
8418 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8419 OFFSET. Verify if current mapping contains an ELF header.
8420 (linux_find_memory_regions_full): Adjust call to
8421 dump_mapping_p.
8422
8423 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
8424 Kang Li <kanglictf@gmail.com>
8425
8426 PR gdb/21600
8427
8428 * dwarf2-frame.c (read_initial_length): Be consistent about using
8429 unsigned representation of length.
8430 (decode_frame_entry_1): Likewise. Check for wraparound of
8431 end pointer as well as buffer overflow.
8432
8433 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
8434
8435 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8436 "vq".
8437
8438 2019-04-24 Tom Tromey <tromey@adacore.com>
8439
8440 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8441
8442 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8443
8444 * s12z-tdep.c (s12z_unwind_pc): Delete.
8445 (s12z_unwind_sp): Delete.
8446 (s12z_gdbarch_init): Don't register deleted functions with
8447 gdbarch.
8448
8449 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8450
8451 * rl78-tdep.c (rl78_unwind_sp): Delete.
8452 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8453
8454 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8455
8456 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8457 (xstormy16_unwind_pc): Delete.
8458 (xstormy16_dummy_id): Delete.
8459 (xstormy16_gdbarch_init): Don't register deleted functions with
8460 gdbarch.
8461
8462 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8463
8464 * vax-tdep.c (vax_unwind_pc): Delete.
8465 (vax_gdbarch_init): Don't register deleted function with gdbarch.
8466
8467 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8468
8469 * v850-tdep.c (v850_unwind_sp): Delete.
8470 (v850_unwind_pc): Delete.
8471 (v850_dummy_id): Delete.
8472 (v850_gdbarch_init): Don't register deleted functions with
8473 gdbarch.
8474
8475 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8476
8477 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8478 (tilegx_unwind_pc): Delete.
8479 (tilegx_unwind_dummy_id): Delete.
8480 (tilegx_gdbarch_init): Don't register deleted functions with
8481 gdbarch.
8482
8483 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8484
8485 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8486 (tic6x_dummy_id): Delete.
8487 (tic6x_gdbarch_init): Don't register deleted functions with
8488 gdbarch.
8489
8490 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8491
8492 * sparc-tdep.c (sparc_unwind_pc): Delete.
8493 (sparc32_gdbarch_init): Don't register deleted function with
8494 gdbarch.
8495
8496 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8497
8498 * sh-tdep.c (sh_unwind_sp): Delete.
8499 (sh_unwind_pc): Delete.
8500 (sh_dummy_id): Delete.
8501 (sh_gdbarch_init): Don't register deleted functions with
8502 gdbarch.
8503
8504 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8505
8506 * score-tdep.c (score_unwind_sp): Delete.
8507 (score_unwind_pc): Delete.
8508 (score_dummy_id): Delete.
8509 (score_gdbarch_init): Don't register deleted functions with
8510 gdbarch.
8511
8512 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8513
8514 * rx-tdep.c (rx_unwind_pc): Delete.
8515 (rx_unwind_sp): Delete.
8516 (rx_dummy_id): Delete.
8517 (rx_gdbarch_init): Don't register deleted functions with
8518 gdbarch. Update comment.
8519
8520 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8521
8522 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8523 (rs6000_dummy_id): Delete.
8524 (rs6000_gdbarch_init): Don't register deleted functions with
8525 gdbarch.
8526
8527 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8528
8529 * or1k-tdep.c (or1k_dummy_id): Delete.
8530 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8531
8532 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8533
8534 * nios2-tdep.c (nios2_dummy_id): Delete.
8535 (nios2_unwind_sp): Delete.
8536 (nios2_gdbarch_init): Don't register deleted functions with
8537 gdbarch.
8538
8539 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8540
8541 * nds32-tdep.c (nds32_dummy_id): Delete.
8542 (nds32_unwind_pc): Delete.
8543 (nds32_unwind_sp): Delete.
8544 (nds32_gdbarch_init): Don't register deleted functions with
8545 gdbarch.
8546
8547 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8548
8549 * msp430-tdep.c (msp430_unwind_pc): Delete.
8550 (msp430_unwind_sp): Delete.
8551 (msp430_dummy_id): Delete.
8552 (msp430_gdbarch_init): Don't register deleted functions with
8553 gdbarch.
8554
8555 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8556
8557 * moxie-tdep.c (moxie_unwind_sp): Delete.
8558 (moxie_unwind_pc): Delete.
8559 (moxie_dummy_id): Delete.
8560 (moxie_gdbarch_init): Don't register deleted functions with
8561 gdbarch.
8562
8563 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8564
8565 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8566 (mn10300_unwind_pc): Delete.
8567 (mn10300_unwind_sp): Delete.
8568 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8569 mn10300_unwind_sp.
8570 (mn10300_frame_unwind_init): Don't register deleted functions with
8571 gdbarch.
8572
8573 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8574
8575 * mep-tdep.c (mep_unwind_pc): Delete.
8576 (mep_unwind_sp): Delete.
8577 (mep_dummy_id): Delete.
8578 (mep_gdbarch_init): Don't register deleted functions with
8579 gdbarch.
8580
8581 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8582
8583 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8584 (m68hc11_unwind_sp): Delete.
8585 (m68hc11_gdbarch_init): Don't register deleted functions with
8586 gdbarch.
8587
8588 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8589
8590 * m32r-tdep.c (m32r_unwind_sp): Delete.
8591 (m32r_unwind_pc): Delete.
8592 (m32r_dummy_id): Delete.
8593 (m32r_gdbarch_init): Don't register deleted functions with
8594 gdbarch.
8595
8596 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8597
8598 * m32c-tdep.c (m32c_unwind_pc): Delete.
8599 (m32c_unwind_sp): Delete.
8600 (m32c_dummy_id): Delete.
8601 (m32c_gdbarch_init): Don't register deleted functions with
8602 gdbarch.
8603
8604 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8605
8606 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8607 (lm32_unwind_pc): Delete.
8608 (lm32_dummy_id): Delete.
8609 (lm32_gdbarch_init): Don't register deleted functions with
8610 gdbarch.
8611
8612 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8613
8614 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8615 (iq2000_unwind_pc): Delete.
8616 (iq2000_dummy_id): Delete.
8617 (iq2000_gdbarch_init): Don't register deleted functions with
8618 gdbarch.
8619
8620 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8621
8622 * nds32-tdep.c (nds32_type_align): Delete.
8623 (nds32_push_dummy_call): Use type_align instead.
8624
8625 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8626
8627 * arm-tdep.c (arm_type_align): Only handle vector override case.
8628 (arm_push_dummy_call): Use type_align.
8629 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8630
8631 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8632
8633 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8634 case.
8635 (pass_on_stack): Use type_align.
8636 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8637 function.
8638
8639 2019-04-23 Tom Tromey <tromey@adacore.com>
8640
8641 * dwarf2read.c (line_header::file_name_at): Remove unused
8642 overload.
8643
8644 2019-04-23 Tom de Vries <tdevries@suse.de>
8645
8646 PR gdb/24438
8647 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8648 invocation.
8649
8650
8651 2019-03-27 Ali Tamur <tamur@google.com>
8652
8653 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8654 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8655 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8656 (dwarf_expr_context::get_addr_index): Likewise
8657 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8658 (symbol_needs_eval_context::get_addr_index): Likewise
8659 (disassemble_dwarf_expression): Add DW_OP_addrx
8660 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8661 (read_cutu_die_from_dwo): Update comment
8662 (skip_one_die): Add DW_FORM_addrx
8663 (read_attribute_value): Likewise
8664 (var_decode_location): Add DW_OP_addrx
8665 (dwarf2_const_value_attr): Add DW_FORM_addrx
8666 (dump_die_shallow): Likewise
8667 (dwarf2_fetch_constant_bytes): Likewise
8668 (decode_locdesc): Add DW_OP_addrx
8669 (skip_form_bytes): Add DW_FORM_addrx
8670
8671 2019-04-22 Ali Tamur <tamur@google.com>
8672
8673 * MAINTAINERS (Write After Approval): Add self.
8674
8675 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
8676
8677 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8678 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8679 (open_symbol_file_object): Likewise.
8680 (svr4_default_sos): Add info parameter.
8681 (svr4_read_so_list): Likewise.
8682 (svr4_current_sos_direct): Adjust functions calls to pass down
8683 info.
8684 (svr4_current_sos_1): Add info parameter.
8685 (svr4_current_sos): Call get_svr4_info, pass info down to
8686 svr4_current_sos_1.
8687 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8688 get_svr4_info.
8689 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8690 get_svr4_info.
8691 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8692 to get_svr4_info.
8693 (probes_table_remove_objfile_probes): Likewise.
8694 (register_solib_event_probe): Add info parameter.
8695 (solist_update_incremental): Pass info parameter down to
8696 svr4_read_so_list.
8697 (disable_probes_interface): Add info parameter.
8698 (svr4_handle_solib_event): Pass current_program_space to
8699 get_svr4_info. Adjust disable_probes_interface cleanup.
8700 (svr4_create_probe_breakpoints): Add info parameter, pass it
8701 down to register_solib_event_probe.
8702 (svr4_create_solib_event_breakpoints): Add info parameter,
8703 pass it down to svr4_create_probe_breakpoints.
8704 (enable_break): Pass info down to
8705 svr4_create_solib_event_breakpoints.
8706 (svr4_solib_create_inferior_hook): Pass current_program_space to
8707 get_svr4_info.
8708 (svr4_clear_solib): Likewise.
8709
8710 2019-04-22 Pedro Alves <palves@redhat.com>
8711
8712 * solib-svr4.c (svr4_free_objfile_observer): New.
8713 (probe_and_action::objfile): New field.
8714 (probes_table_htab_remove_objfile_probes)
8715 (probes_table_remove_objfile_probes): New functions.
8716 (register_solib_event_probe): Add 'objfile' parameter. Store it
8717 in the new probe_and_action. Don't store the probe in 'lookup'.
8718 (svr4_create_probe_breakpoints): Pass objfile to
8719 register_solib_event_probe.
8720 (_initialize_svr4_solib): Register a free_objfile observer.
8721
8722 2019-04-19 Tom Tromey <tom@tromey.com>
8723
8724 * common/queue.h: Remove.
8725
8726 2019-04-19 Tom Tromey <tom@tromey.com>
8727
8728 * event-loop.c: Don't include "common/queue.h".
8729
8730 2019-04-19 Tom Tromey <tom@tromey.com>
8731
8732 * remote.c (remote_target): Use delete.
8733 * remote-notif.h: Include <list>, not "common/queue.h".
8734 (notif_client_p): Remove typedef.
8735 (remote_notif_state): Add constructor, destructor, initializer.
8736 <notif_queue>: Now a std::list.
8737 (remote_notif_state_xfree): Don't declare.
8738 * remote-notif.c (remote_notif_process, handle_notification)
8739 (remote_notif_state_allocate): Update.
8740 (~remote_notif_state): Rename from remote_notif_state_xfree.
8741
8742 2019-04-19 Tom Tromey <tom@tromey.com>
8743
8744 * symfile.c (reread_symbols): Update.
8745 * objfiles.c (objfile_register_static_link)
8746 (objfile_lookup_static_link): Update
8747 (~objfile) Don't delete static_links.
8748 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8749
8750 2019-04-19 Tom Tromey <tom@tromey.com>
8751
8752 * type-stack.h (struct type_stack) <insert>: Constify string.
8753 * type-stack.c (type_stack::insert): Constify string.
8754 * gdbtypes.h (lookup_template_type): Update.
8755 (address_space_name_to_int): Update.
8756 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8757 const.
8758 (lookup_template_type): Make name const.
8759 * c-exp.y: Update rules.
8760 (lex_one_token, classify_name, classify_inner_name)
8761 (c_print_token): Update.
8762 * p-exp.y: Update rules.
8763 (yylex): Update.
8764 * f-exp.y: Update rules.
8765 (yylex): Update.
8766 * d-exp.y: Update rules.
8767 (lex_one_token, classify_name, classify_inner_name): Update.
8768 * parse.c (write_dollar_variable, copy_name): Return std::string.
8769 * parser-defs.h (copy_name): Change return type.
8770 * m2-exp.y: Update rules.
8771 (yylex): Update.
8772 * go-exp.y (lex_one_token): Update.
8773 Update rules.
8774 (classify_unsafe_function, classify_packaged_name)
8775 (classify_name, yylex): Update.
8776
8777 2019-04-19 Sergei Trofimovich <siarheit@google.com>
8778
8779 * configure.ac: add --enable-source-highlight switch.
8780 * configure: Regenerate.
8781 * top.c (print_gdb_version): plumb --enable-source-highlight
8782 status to "show configuration".
8783
8784 2019-04-19 Tom Tromey <tromey@adacore.com>
8785
8786 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8787 Check ADA_TYPE_P.
8788 (empty_record, ada_template_to_fixed_record_type_1)
8789 (template_to_static_fixed_type)
8790 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8791 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8792 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8793 macros.
8794
8795 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8796
8797 PR symtab/24423:
8798 * source.c (print_source_lines_base): Advance "iter" when a
8799 control character is seen.
8800
8801 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8802
8803 * inferior.h (struct infcall_suspend_state_deleter):
8804 Catch exception in destructor to avoid crash.
8805
8806 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8807
8808 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8809 close to the add_com "shell".
8810
8811 2019-04-18 Tom Tromey <tromey@adacore.com>
8812
8813 * process-stratum-target.h (class process_stratum_target)
8814 <stratum>: Add "final".
8815
8816 2019-04-17 Tom Tromey <tromey@adacore.com>
8817
8818 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8819 against nullptr before use.
8820
8821 2019-04-17 Alan Hayward <alan.hayward@arm.com>
8822
8823 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8824
8825 2019-04-17 Jim Wilson <jimw@sifive.com>
8826 Andrew Burgess <andrew.burgess@embecosm.com>
8827
8828 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8829 code read might fail, assume 4-byte breakpoint in that case.
8830
8831 2019-04-15 Leszek Swirski <leszeks@google.com>
8832
8833 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8834 rather than a hand-rolled POD check when checking for forced MEMORY
8835 classification.
8836
8837 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8838
8839 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8840 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8841 function.
8842 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8843 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8844 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8845 declaration.
8846
8847 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8848
8849 * aarch64-linux-nat.c
8850 (aarch64_linux_nat_target::thread_architecture): Add override.
8851 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8852 each VQ.
8853
8854 2019-04-15 Alan Hayward <alan.hayward@arm.com>
8855
8856 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8857
8858 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8859
8860 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8861 target types of size 96-bits, add some additional comments, and
8862 check that the builtin type we found was the correct size.
8863
8864 2019-04-12 Eli Zaretskii <eliz@gnu.org>
8865
8866 * utils.c (prompt_for_continue): Don't restore the styling at the
8867 end, as applied_style has the wrong value. This fixes styling in
8868 long lists of file names that are interrupted by the "Continue?"
8869 prompt.
8870
8871 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8872
8873 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8874 * c-lang.c (c_language_defn): Likewise.
8875 (cplus_language_defn): Likewise.
8876 (asm_language_defn): Likewise.
8877 (minimal_language_defn): Likewise.
8878 * d-lang.c (d_language_defn): Likewise.
8879 * f-lang.c (f_language_defn): Likewise.
8880 * go-lang.c (go_language_defn): Likewise.
8881 * language.c (unknown_language_defn): Likewise.
8882 (auto_language_defn): Likewise.
8883 * language.h (struct language_defn): Remove la_magic field.
8884 (LANG_MAGIC): Delete.
8885 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8886 * objc-lang.c (objc_language_defn): Likewise.
8887 * opencl-lang.c (opencl_language_defn): Likewise.
8888 * p-lang.c (pascal_language_defn): Likewise.
8889 * rust-lang.c (rust_language_defn): Likewise.
8890
8891 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8892
8893 * riscv-tdep.c (riscv_type_align): New function.
8894 (riscv_type_alignment): Delete.
8895 (riscv_arg_location): Use 'type_align'.
8896 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8897
8898 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8899
8900 * gdbtypes.c (type_align): A struct with no non-static fields also
8901 has alignment of 1.
8902
8903 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8904
8905 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8906 component to 0.
8907 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8908 member.
8909 (riscv_struct_info::analyse): New implementation using new
8910 analyse_inner member function.
8911 (riscv_struct_info::field_offset): New member function.
8912 (riscv_struct_info::m_offsets): New member variable.
8913 (riscv_struct_info::analyse_inner): New private member function,
8914 takes the old implementation of riscv_struct_info::analyse but
8915 extended to track field offsets.
8916 (riscv_call_arg_struct): Update the struct folding special cases
8917 to handle cases where empty C++ structs, which are non-zero
8918 length, are found.
8919 (riscv_arg_location): Initialise the length of each location, a
8920 non-zero length now indicates the location is in use.
8921 (riscv_push_dummy_call): Allow for the first location having a
8922 non-zero offset when setting up arguments.
8923 (riscv_return_value): Likewise, but for return values.
8924
8925 2019-04-11 Tom Tromey <tromey@adacore.com>
8926
8927 * utils.c (internal_vproblem): Make "msg" const.
8928
8929 2019-04-11 Alan Hayward <alan.hayward@arm.com>
8930
8931 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8932 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8933 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8934 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8935
8936 2019-04-10 Kevin Buettner <kevinb@redhat.com>
8937
8938 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8939 function.
8940 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8941 of amd64_collect_native_gregset.
8942 (amd64_linux_nat_target::store_registers): Likewise.
8943
8944 2019-04-10 Tom Tromey <tom@tromey.com>
8945
8946 * symtab.c (lookup_global_symbol_from_objfile)
8947 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8948 * objfiles.h (class separate_debug_iterator): New.
8949 (class separate_debug_range): New.
8950 (struct objfile) <separate_debug_objfiles>: New method.
8951 (objfile_separate_debug_iterate): Don't declare.
8952 * objfiles.c (separate_debug_iterator::operator++): Rename from
8953 objfile_separate_debug_iterate.
8954 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8955 iterator.
8956 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8957 iterator.
8958
8959 2019-04-10 Tom Tromey <tom@tromey.com>
8960
8961 * symfile.c (reread_symbols): Remove old comment.
8962 * objfiles.c (free_all_objfiles): Fix a typo.
8963
8964 2019-04-10 Tom Tromey <tom@tromey.com>
8965
8966 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8967 * minsyms.c (lookup_minimal_symbol): Use foreach.
8968 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8969 (lookup_minimal_symbol_solib_trampoline): Likewise.
8970 * symfile.c (reread_symbols): Use foreach.
8971
8972 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
8973 Tom Tromey <tromey@adacore.com>
8974
8975 PR rust/24414:
8976 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8977 (rust_lex_int_test): Change "value" to be LONGEST.
8978 (rust_lex_tests): Add test for long integer literal.
8979
8980 2019-04-09 Tom Tromey <tromey@adacore.com>
8981
8982 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8983 to bool.
8984 (extended_remote_target::attach): Update.
8985 (remote_target::remote_notice_new_inferior): Update.
8986 (remote_target::add_current_inferior_and_thread): Update.
8987 * inferior.c (exit_inferior_1): Use "false".
8988 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8989
8990 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
8991
8992 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8993 the "start" command.
8994
8995 2019-04-08 Kevin Buettner <kevinb@redhat.com>
8996
8997 * python/py-inferior.c (infpy_thread_from_thread_handle):
8998 Adjust comments to reflect renaming of thread_from_thread_handle
8999 to thread_from_handle. Adjust keywords. Fix type error message.
9000 (inferior_object_methods): Add thread_from_handle. Retain
9001 thread_from_thread_handle, but mark it as deprecated.
9002
9003 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9004
9005 * gdbthread.h (find_thread_by_handle): Revise declaration.
9006 * thread.c (find_thread_by_handle): Likewise. Adjust
9007 implementation too.
9008 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9009 support for buffer objects as handles.
9010
9011 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9012
9013 * python/py-infthread.c (thpy_thread_handle): New function.
9014 (thread_object_methods): Register thpy_thread_handle.
9015
9016 2019-04-08 Kevin Buettner <kevinb@redhat.com>
9017
9018 * gdbthread.h (thread_to_thread_handle): Declare.
9019 * thread.c (gdbtypes.h): Include.
9020 (thread_to_thread_handle): New function.
9021
9022 * target.h (struct target_ops): Add thread_info_to_thread_handle.
9023 (target_thread_info_to_thread_handle): Declare.
9024 * target.c (target_thread_info_to_thread_handle): New function.
9025 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9026 * target-delegates.c: Regenerate.
9027
9028 * linux-thread-db.c (class thread_db_target): Add method
9029 thread_info_to_thread_handle.
9030 (thread_db_target::thread_info_to_thread_handle): Define.
9031 * remote.c (class remote_target): Add new method
9032 thread_info_to_thread_handle.
9033 (remote_target::thread_info_to_thread_handle): Define.
9034
9035 2019-04-08 Pedro Alves <palves@redhat.com>
9036
9037 * common/common-exceptions.c (throw_exception): Don't create
9038 named object to throw; throw directly.
9039 (throw_it): Likewise. Don't initialize gdb_exception::message
9040 here, with new; pass FMT and AP to the ctor instead.
9041 * common/common-exceptions.h: Include <string>.
9042 (gdb_exception::gdb_exception(enum return_reason, enum errors,
9043 const char *, va_list)): New ctor. Use std::make_shared.
9044 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9045 errors)): Delete.
9046 (gdb_exception_error::gdb_exception_error(enum errors, const char
9047 *, va_list)): New.
9048 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9049 Add assertion.
9050 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9051 errors)): Delete.
9052 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9053 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9054 Add assertion.
9055
9056 2019-04-08 Tom Tromey <tom@tromey.com>
9057
9058 * valops.c (value_rtti_indirect_type): Replace throw_exception
9059 with throw.
9060 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9061 with throw.
9062 * thread.c (thr_try_catch_cmd): Replace throw_exception with
9063 throw.
9064 * target.c (target_translate_tls_address): Replace throw_exception
9065 with throw.
9066 * stack.c (frame_apply_command_count): Replace throw_exception
9067 with throw.
9068 * solib-spu.c (append_ocl_sos): Replace throw_exception with
9069 throw.
9070 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9071 with throw.
9072 * rs6000-tdep.c (rs6000_frame_cache)
9073 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9074 * remote.c: Replace throw_exception with throw.
9075 * record-full.c (record_full_message, record_full_wait_1)
9076 (record_full_restore): Replace throw_exception with throw.
9077 * record-btrace.c:
9078 (get_thread_current_frame_id, record_btrace_start_replaying)
9079 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9080 (cmd_record_btrace_start): Replace throw_exception with throw.
9081 * parse.c (parse_exp_in_context_1): Replace throw_exception with
9082 throw.
9083 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9084 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9085 * linespec.c:
9086 (find_linespec_symbols): Replace throw_exception with throw.
9087 * infrun.c (displaced_step_prepare, resume): Replace
9088 throw_exception with throw.
9089 * infcmd.c (post_create_inferior): Replace throw_exception with
9090 throw.
9091 * inf-loop.c (inferior_event_handler): Replace throw_exception
9092 with throw.
9093 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9094 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9095 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9096 (get_prev_frame_always, get_frame_pc_if_available)
9097 (get_frame_address_in_block_if_available, get_frame_language):
9098 Replace throw_exception with throw.
9099 * frame-unwind.c (frame_unwind_try_unwinder): Replace
9100 throw_exception with throw.
9101 * eval.c (fetch_subexp_value, evaluate_var_value)
9102 (evaluate_funcall, evaluate_subexp_standard): Replace
9103 throw_exception with throw.
9104 * dwarf2loc.c (call_site_find_chain)
9105 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9106 Replace throw_exception with throw.
9107 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9108 with throw.
9109 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9110 throw.
9111 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9112 * completer.c (complete_line_internal): Replace throw_exception
9113 with throw.
9114 * compile/compile-object-run.c (compile_object_run): Replace
9115 throw_exception with throw.
9116 * cli/cli-script.c (process_next_line): Replace throw_exception
9117 with throw.
9118 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9119 (btrace_enable, btrace_maint_update_pt_packets): Replace
9120 throw_exception with throw.
9121 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9122 throw_exception with throw.
9123 * break-catch-throw.c (re_set_exception_catchpoint): Replace
9124 throw_exception with throw.
9125 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9126 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9127 * aarch64-tdep.c (aarch64_make_prologue_cache)
9128 (aarch64_make_stub_cache): Replace throw_exception with throw.
9129
9130 2019-04-08 Tom Tromey <tom@tromey.com>
9131
9132 * common/common-exceptions.c (throw_exception): Rename from
9133 throw_exception_cxx. Remove old copy. Make argument const.
9134 (throw_it): Create and throw exception objects directly.
9135 * common/common-exceptions.h (throw_exception): Make argument
9136 const.
9137 (struct gdb_exception_error): Add constructor.
9138 (struct gdb_exception_quit): Add constructor.
9139
9140 2019-04-08 Tom Tromey <tom@tromey.com>
9141
9142 * common/common-exceptions.h (exception_rethrow): Don't declare.
9143 (TRY_SJLJ): Update comment.
9144 (TRY, CATCH, END_CATCH): Remove.
9145 * common/common-exceptions.c (exception_rethrow): Remove.
9146
9147 2019-04-08 Tom Tromey <tom@tromey.com>
9148
9149 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9150 Remove.
9151 (gdb_exception_error): Rename from
9152 gdb_exception_RETURN_MASK_ERROR.
9153 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9154 (gdb_quit_bad_alloc): Update.
9155 * aarch64-tdep.c: Update.
9156 * ada-lang.c: Update.
9157 * ada-typeprint.c: Update.
9158 * ada-valprint.c: Update.
9159 * amd64-tdep.c: Update.
9160 * arch-utils.c: Update.
9161 * break-catch-throw.c: Update.
9162 * breakpoint.c: Update.
9163 * btrace.c: Update.
9164 * c-varobj.c: Update.
9165 * cli/cli-cmds.c: Update.
9166 * cli/cli-interp.c: Update.
9167 * cli/cli-script.c: Update.
9168 * common/common-exceptions.c: Update.
9169 * common/new-op.c: Update.
9170 * common/selftest.c: Update.
9171 * compile/compile-c-symbols.c: Update.
9172 * compile/compile-cplus-symbols.c: Update.
9173 * compile/compile-object-load.c: Update.
9174 * compile/compile-object-run.c: Update.
9175 * completer.c: Update.
9176 * corelow.c: Update.
9177 * cp-abi.c: Update.
9178 * cp-support.c: Update.
9179 * cp-valprint.c: Update.
9180 * darwin-nat.c: Update.
9181 * disasm-selftests.c: Update.
9182 * dtrace-probe.c: Update.
9183 * dwarf-index-cache.c: Update.
9184 * dwarf-index-write.c: Update.
9185 * dwarf2-frame-tailcall.c: Update.
9186 * dwarf2-frame.c: Update.
9187 * dwarf2loc.c: Update.
9188 * dwarf2read.c: Update.
9189 * eval.c: Update.
9190 * event-loop.c: Update.
9191 * event-top.c: Update.
9192 * exec.c: Update.
9193 * f-valprint.c: Update.
9194 * fbsd-tdep.c: Update.
9195 * frame-unwind.c: Update.
9196 * frame.c: Update.
9197 * gdbtypes.c: Update.
9198 * gnu-v3-abi.c: Update.
9199 * guile/guile-internal.h: Update.
9200 * guile/scm-block.c: Update.
9201 * guile/scm-breakpoint.c: Update.
9202 * guile/scm-cmd.c: Update.
9203 * guile/scm-disasm.c: Update.
9204 * guile/scm-frame.c: Update.
9205 * guile/scm-lazy-string.c: Update.
9206 * guile/scm-math.c: Update.
9207 * guile/scm-param.c: Update.
9208 * guile/scm-ports.c: Update.
9209 * guile/scm-pretty-print.c: Update.
9210 * guile/scm-symbol.c: Update.
9211 * guile/scm-symtab.c: Update.
9212 * guile/scm-type.c: Update.
9213 * guile/scm-value.c: Update.
9214 * i386-linux-tdep.c: Update.
9215 * i386-tdep.c: Update.
9216 * inf-loop.c: Update.
9217 * infcall.c: Update.
9218 * infcmd.c: Update.
9219 * infrun.c: Update.
9220 * jit.c: Update.
9221 * language.c: Update.
9222 * linespec.c: Update.
9223 * linux-fork.c: Update.
9224 * linux-nat.c: Update.
9225 * linux-tdep.c: Update.
9226 * linux-thread-db.c: Update.
9227 * main.c: Update.
9228 * mi/mi-cmd-break.c: Update.
9229 * mi/mi-cmd-stack.c: Update.
9230 * mi/mi-interp.c: Update.
9231 * mi/mi-main.c: Update.
9232 * objc-lang.c: Update.
9233 * p-valprint.c: Update.
9234 * parse.c: Update.
9235 * ppc-linux-tdep.c: Update.
9236 * printcmd.c: Update.
9237 * python/py-arch.c: Update.
9238 * python/py-breakpoint.c: Update.
9239 * python/py-cmd.c: Update.
9240 * python/py-finishbreakpoint.c: Update.
9241 * python/py-frame.c: Update.
9242 * python/py-framefilter.c: Update.
9243 * python/py-gdb-readline.c: Update.
9244 * python/py-inferior.c: Update.
9245 * python/py-infthread.c: Update.
9246 * python/py-lazy-string.c: Update.
9247 * python/py-linetable.c: Update.
9248 * python/py-objfile.c: Update.
9249 * python/py-param.c: Update.
9250 * python/py-prettyprint.c: Update.
9251 * python/py-progspace.c: Update.
9252 * python/py-record-btrace.c: Update.
9253 * python/py-record.c: Update.
9254 * python/py-symbol.c: Update.
9255 * python/py-type.c: Update.
9256 * python/py-unwind.c: Update.
9257 * python/py-utils.c: Update.
9258 * python/py-value.c: Update.
9259 * python/python.c: Update.
9260 * record-btrace.c: Update.
9261 * record-full.c: Update.
9262 * remote-fileio.c: Update.
9263 * remote.c: Update.
9264 * riscv-tdep.c: Update.
9265 * rs6000-aix-tdep.c: Update.
9266 * rs6000-tdep.c: Update.
9267 * rust-exp.y: Update.
9268 * rust-lang.c: Update.
9269 * s390-tdep.c: Update.
9270 * selftest-arch.c: Update.
9271 * solib-dsbt.c: Update.
9272 * solib-frv.c: Update.
9273 * solib-spu.c: Update.
9274 * solib-svr4.c: Update.
9275 * solib.c: Update.
9276 * sparc64-linux-tdep.c: Update.
9277 * stack.c: Update.
9278 * symfile-mem.c: Update.
9279 * symmisc.c: Update.
9280 * target.c: Update.
9281 * thread.c: Update.
9282 * top.c: Update.
9283 * tracefile-tfile.c: Update.
9284 * tui/tui.c: Update.
9285 * typeprint.c: Update.
9286 * unittests/cli-utils-selftests.c: Update.
9287 * unittests/parse-connection-spec-selftests.c: Update.
9288 * valops.c: Update.
9289 * valprint.c: Update.
9290 * value.c: Update.
9291 * varobj.c: Update.
9292 * windows-nat.c: Update.
9293 * x86-linux-nat.c: Update.
9294 * xml-support.c: Update.
9295
9296 2019-04-08 Tom Tromey <tom@tromey.com>
9297
9298 * xml-support.c: Use C++ exception handling.
9299 * x86-linux-nat.c: Use C++ exception handling.
9300 * windows-nat.c: Use C++ exception handling.
9301 * varobj.c: Use C++ exception handling.
9302 * value.c: Use C++ exception handling.
9303 * valprint.c: Use C++ exception handling.
9304 * valops.c: Use C++ exception handling.
9305 * unittests/parse-connection-spec-selftests.c: Use C++ exception
9306 handling.
9307 * unittests/cli-utils-selftests.c: Use C++ exception handling.
9308 * typeprint.c: Use C++ exception handling.
9309 * tui/tui.c: Use C++ exception handling.
9310 * tracefile-tfile.c: Use C++ exception handling.
9311 * top.c: Use C++ exception handling.
9312 * thread.c: Use C++ exception handling.
9313 * target.c: Use C++ exception handling.
9314 * symmisc.c: Use C++ exception handling.
9315 * symfile-mem.c: Use C++ exception handling.
9316 * stack.c: Use C++ exception handling.
9317 * sparc64-linux-tdep.c: Use C++ exception handling.
9318 * solib.c: Use C++ exception handling.
9319 * solib-svr4.c: Use C++ exception handling.
9320 * solib-spu.c: Use C++ exception handling.
9321 * solib-frv.c: Use C++ exception handling.
9322 * solib-dsbt.c: Use C++ exception handling.
9323 * selftest-arch.c: Use C++ exception handling.
9324 * s390-tdep.c: Use C++ exception handling.
9325 * rust-lang.c: Use C++ exception handling.
9326 * rust-exp.y: Use C++ exception handling.
9327 * rs6000-tdep.c: Use C++ exception handling.
9328 * rs6000-aix-tdep.c: Use C++ exception handling.
9329 * riscv-tdep.c: Use C++ exception handling.
9330 * remote.c: Use C++ exception handling.
9331 * remote-fileio.c: Use C++ exception handling.
9332 * record-full.c: Use C++ exception handling.
9333 * record-btrace.c: Use C++ exception handling.
9334 * python/python.c: Use C++ exception handling.
9335 * python/py-value.c: Use C++ exception handling.
9336 * python/py-utils.c: Use C++ exception handling.
9337 * python/py-unwind.c: Use C++ exception handling.
9338 * python/py-type.c: Use C++ exception handling.
9339 * python/py-symbol.c: Use C++ exception handling.
9340 * python/py-record.c: Use C++ exception handling.
9341 * python/py-record-btrace.c: Use C++ exception handling.
9342 * python/py-progspace.c: Use C++ exception handling.
9343 * python/py-prettyprint.c: Use C++ exception handling.
9344 * python/py-param.c: Use C++ exception handling.
9345 * python/py-objfile.c: Use C++ exception handling.
9346 * python/py-linetable.c: Use C++ exception handling.
9347 * python/py-lazy-string.c: Use C++ exception handling.
9348 * python/py-infthread.c: Use C++ exception handling.
9349 * python/py-inferior.c: Use C++ exception handling.
9350 * python/py-gdb-readline.c: Use C++ exception handling.
9351 * python/py-framefilter.c: Use C++ exception handling.
9352 * python/py-frame.c: Use C++ exception handling.
9353 * python/py-finishbreakpoint.c: Use C++ exception handling.
9354 * python/py-cmd.c: Use C++ exception handling.
9355 * python/py-breakpoint.c: Use C++ exception handling.
9356 * python/py-arch.c: Use C++ exception handling.
9357 * printcmd.c: Use C++ exception handling.
9358 * ppc-linux-tdep.c: Use C++ exception handling.
9359 * parse.c: Use C++ exception handling.
9360 * p-valprint.c: Use C++ exception handling.
9361 * objc-lang.c: Use C++ exception handling.
9362 * mi/mi-main.c: Use C++ exception handling.
9363 * mi/mi-interp.c: Use C++ exception handling.
9364 * mi/mi-cmd-stack.c: Use C++ exception handling.
9365 * mi/mi-cmd-break.c: Use C++ exception handling.
9366 * main.c: Use C++ exception handling.
9367 * linux-thread-db.c: Use C++ exception handling.
9368 * linux-tdep.c: Use C++ exception handling.
9369 * linux-nat.c: Use C++ exception handling.
9370 * linux-fork.c: Use C++ exception handling.
9371 * linespec.c: Use C++ exception handling.
9372 * language.c: Use C++ exception handling.
9373 * jit.c: Use C++ exception handling.
9374 * infrun.c: Use C++ exception handling.
9375 * infcmd.c: Use C++ exception handling.
9376 * infcall.c: Use C++ exception handling.
9377 * inf-loop.c: Use C++ exception handling.
9378 * i386-tdep.c: Use C++ exception handling.
9379 * i386-linux-tdep.c: Use C++ exception handling.
9380 * guile/scm-value.c: Use C++ exception handling.
9381 * guile/scm-type.c: Use C++ exception handling.
9382 * guile/scm-symtab.c: Use C++ exception handling.
9383 * guile/scm-symbol.c: Use C++ exception handling.
9384 * guile/scm-pretty-print.c: Use C++ exception handling.
9385 * guile/scm-ports.c: Use C++ exception handling.
9386 * guile/scm-param.c: Use C++ exception handling.
9387 * guile/scm-math.c: Use C++ exception handling.
9388 * guile/scm-lazy-string.c: Use C++ exception handling.
9389 * guile/scm-frame.c: Use C++ exception handling.
9390 * guile/scm-disasm.c: Use C++ exception handling.
9391 * guile/scm-cmd.c: Use C++ exception handling.
9392 * guile/scm-breakpoint.c: Use C++ exception handling.
9393 * guile/scm-block.c: Use C++ exception handling.
9394 * guile/guile-internal.h: Use C++ exception handling.
9395 * gnu-v3-abi.c: Use C++ exception handling.
9396 * gdbtypes.c: Use C++ exception handling.
9397 * frame.c: Use C++ exception handling.
9398 * frame-unwind.c: Use C++ exception handling.
9399 * fbsd-tdep.c: Use C++ exception handling.
9400 * f-valprint.c: Use C++ exception handling.
9401 * exec.c: Use C++ exception handling.
9402 * event-top.c: Use C++ exception handling.
9403 * event-loop.c: Use C++ exception handling.
9404 * eval.c: Use C++ exception handling.
9405 * dwarf2read.c: Use C++ exception handling.
9406 * dwarf2loc.c: Use C++ exception handling.
9407 * dwarf2-frame.c: Use C++ exception handling.
9408 * dwarf2-frame-tailcall.c: Use C++ exception handling.
9409 * dwarf-index-write.c: Use C++ exception handling.
9410 * dwarf-index-cache.c: Use C++ exception handling.
9411 * dtrace-probe.c: Use C++ exception handling.
9412 * disasm-selftests.c: Use C++ exception handling.
9413 * darwin-nat.c: Use C++ exception handling.
9414 * cp-valprint.c: Use C++ exception handling.
9415 * cp-support.c: Use C++ exception handling.
9416 * cp-abi.c: Use C++ exception handling.
9417 * corelow.c: Use C++ exception handling.
9418 * completer.c: Use C++ exception handling.
9419 * compile/compile-object-run.c: Use C++ exception handling.
9420 * compile/compile-object-load.c: Use C++ exception handling.
9421 * compile/compile-cplus-symbols.c: Use C++ exception handling.
9422 * compile/compile-c-symbols.c: Use C++ exception handling.
9423 * common/selftest.c: Use C++ exception handling.
9424 * common/new-op.c: Use C++ exception handling.
9425 * cli/cli-script.c: Use C++ exception handling.
9426 * cli/cli-interp.c: Use C++ exception handling.
9427 * cli/cli-cmds.c: Use C++ exception handling.
9428 * c-varobj.c: Use C++ exception handling.
9429 * btrace.c: Use C++ exception handling.
9430 * breakpoint.c: Use C++ exception handling.
9431 * break-catch-throw.c: Use C++ exception handling.
9432 * arch-utils.c: Use C++ exception handling.
9433 * amd64-tdep.c: Use C++ exception handling.
9434 * ada-valprint.c: Use C++ exception handling.
9435 * ada-typeprint.c: Use C++ exception handling.
9436 * ada-lang.c: Use C++ exception handling.
9437 * aarch64-tdep.c: Use C++ exception handling.
9438
9439 2019-04-08 Tom Tromey <tom@tromey.com>
9440
9441 * xml-support.c (gdb_xml_parser::parse): Update.
9442 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9443 * value.c (show_convenience): Update.
9444 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9445 (test_parse_flags_qcs): Update.
9446 * thread.c (thr_try_catch_cmd): Update.
9447 * target.c (target_translate_tls_address): Update.
9448 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9449 (info_frame_command_core, frame_apply_command_count): Update.
9450 * rust-exp.y (rust_lex_exception_test): Update.
9451 * riscv-tdep.c (riscv_print_one_register_info): Update.
9452 * remote.c (remote_target::enable_btrace): Update.
9453 * record-btrace.c (record_btrace_enable_warn): Update.
9454 * python/py-utils.c (gdbpy_convert_exception): Update.
9455 * printcmd.c (do_one_display, print_variable_and_value): Update.
9456 * mi/mi-main.c (mi_print_exception): Update.
9457 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9458 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9459 * linux-nat.c (linux_nat_target::attach): Update.
9460 * linux-fork.c (class scoped_switch_fork_info): Update.
9461 * infrun.c (displaced_step_prepare): Update.
9462 * infcall.c (call_function_by_hand_dummy): Update.
9463 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9464 * gnu-v3-abi.c (print_one_vtable): Update.
9465 * frame.c (get_prev_frame_always): Update.
9466 * f-valprint.c (info_common_command_for_block): Update.
9467 * exec.c (try_open_exec_file): Update.
9468 * exceptions.c (print_exception, exception_print)
9469 (exception_fprintf, exception_print_same): Update.
9470 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9471 * dwarf-index-cache.c (index_cache::store)
9472 (index_cache::lookup_gdb_index): Update.
9473 * darwin-nat.c (maybe_cache_shell): Update.
9474 * cp-valprint.c (cp_print_value_fields): Update.
9475 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9476 (gcc_cplus_symbol_address): Update.
9477 * compile/compile-c-symbols.c (gcc_convert_symbol)
9478 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9479 * common/selftest.c: Update.
9480 * common/common-exceptions.h (struct gdb_exception) <message>: Now
9481 a std::string.
9482 (exception_try_scope_entry, exception_try_scope_exit): Don't
9483 declare.
9484 (struct exception_try_scope): Remove.
9485 (TRY): Don't use exception_try_scope.
9486 (struct gdb_exception): Add constructor, operator=.
9487 <what>: New method.
9488 (struct gdb_exception_RETURN_MASK_ALL)
9489 (struct gdb_exception_RETURN_MASK_ERROR)
9490 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9491 (struct gdb_quit_bad_alloc): Update.
9492 * common/common-exceptions.c (exception_none): Change
9493 initializer.
9494 (struct catcher) <state, exception>: Initialize inline.
9495 <prev>: Remove member.
9496 (current_catcher): Remove.
9497 (catchers): New global.
9498 (exceptions_state_mc_init): Simplify.
9499 (catcher_pop): Remove.
9500 (exceptions_state_mc, exceptions_state_mc_catch): Update.
9501 (try_scope_depth, exception_try_scope_entry)
9502 (exception_try_scope_exit): Remove.
9503 (throw_exception_sjlj): Update.
9504 (exception_messages, exception_messages_size): Remove.
9505 (throw_it): Simplify.
9506 (gdb_exception_sliced_copy): Remove.
9507 (throw_exception_cxx): Update.
9508 * cli/cli-script.c (script_from_file): Update.
9509 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9510 Update.
9511 * ada-valprint.c (ada_val_print): Update.
9512 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9513 (create_excep_cond_exprs): Update.
9514
9515 2019-04-08 Tom Tromey <tom@tromey.com>
9516
9517 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9518 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9519 (TRY, CATCH, END_CATCH): Remove some definitions.
9520 * common/common-exceptions.c: Don't use GDB_XCPT.
9521 (catcher_list_size): Remove.
9522 (throw_exception, throw_it): Simplify.
9523
9524 2019-04-05 Tom Tromey <tom@tromey.com>
9525
9526 Revert the header-sorting patch.
9527 * ft32-tdep.c: Revert.
9528 * frv-tdep.c: Revert.
9529 * frv-linux-tdep.c: Revert.
9530 * frame.c: Revert.
9531 * frame-unwind.c: Revert.
9532 * frame-base.c: Revert.
9533 * fork-child.c: Revert.
9534 * findvar.c: Revert.
9535 * findcmd.c: Revert.
9536 * filesystem.c: Revert.
9537 * filename-seen-cache.h: Revert.
9538 * filename-seen-cache.c: Revert.
9539 * fbsd-tdep.c: Revert.
9540 * fbsd-nat.h: Revert.
9541 * fbsd-nat.c: Revert.
9542 * f-valprint.c: Revert.
9543 * f-typeprint.c: Revert.
9544 * f-lang.c: Revert.
9545 * extension.h: Revert.
9546 * extension.c: Revert.
9547 * extension-priv.h: Revert.
9548 * expprint.c: Revert.
9549 * exec.h: Revert.
9550 * exec.c: Revert.
9551 * exceptions.c: Revert.
9552 * event-top.c: Revert.
9553 * event-loop.c: Revert.
9554 * eval.c: Revert.
9555 * elfread.c: Revert.
9556 * dwarf2read.h: Revert.
9557 * dwarf2read.c: Revert.
9558 * dwarf2loc.c: Revert.
9559 * dwarf2expr.h: Revert.
9560 * dwarf2expr.c: Revert.
9561 * dwarf2-frame.c: Revert.
9562 * dwarf2-frame-tailcall.c: Revert.
9563 * dwarf-index-write.h: Revert.
9564 * dwarf-index-write.c: Revert.
9565 * dwarf-index-common.c: Revert.
9566 * dwarf-index-cache.h: Revert.
9567 * dwarf-index-cache.c: Revert.
9568 * dummy-frame.c: Revert.
9569 * dtrace-probe.c: Revert.
9570 * disasm.h: Revert.
9571 * disasm.c: Revert.
9572 * disasm-selftests.c: Revert.
9573 * dictionary.c: Revert.
9574 * dicos-tdep.c: Revert.
9575 * demangle.c: Revert.
9576 * dcache.h: Revert.
9577 * dcache.c: Revert.
9578 * darwin-nat.h: Revert.
9579 * darwin-nat.c: Revert.
9580 * darwin-nat-info.c: Revert.
9581 * d-valprint.c: Revert.
9582 * d-namespace.c: Revert.
9583 * d-lang.c: Revert.
9584 * ctf.c: Revert.
9585 * csky-tdep.c: Revert.
9586 * csky-linux-tdep.c: Revert.
9587 * cris-tdep.c: Revert.
9588 * cris-linux-tdep.c: Revert.
9589 * cp-valprint.c: Revert.
9590 * cp-support.c: Revert.
9591 * cp-namespace.c: Revert.
9592 * cp-abi.c: Revert.
9593 * corelow.c: Revert.
9594 * corefile.c: Revert.
9595 * continuations.c: Revert.
9596 * completer.h: Revert.
9597 * completer.c: Revert.
9598 * complaints.c: Revert.
9599 * coffread.c: Revert.
9600 * coff-pe-read.c: Revert.
9601 * cli-out.h: Revert.
9602 * cli-out.c: Revert.
9603 * charset.c: Revert.
9604 * c-varobj.c: Revert.
9605 * c-valprint.c: Revert.
9606 * c-typeprint.c: Revert.
9607 * c-lang.c: Revert.
9608 * buildsym.c: Revert.
9609 * buildsym-legacy.c: Revert.
9610 * build-id.h: Revert.
9611 * build-id.c: Revert.
9612 * btrace.c: Revert.
9613 * bsd-uthread.c: Revert.
9614 * breakpoint.h: Revert.
9615 * breakpoint.c: Revert.
9616 * break-catch-throw.c: Revert.
9617 * break-catch-syscall.c: Revert.
9618 * break-catch-sig.c: Revert.
9619 * blockframe.c: Revert.
9620 * block.c: Revert.
9621 * bfin-tdep.c: Revert.
9622 * bfin-linux-tdep.c: Revert.
9623 * bfd-target.c: Revert.
9624 * bcache.c: Revert.
9625 * ax-general.c: Revert.
9626 * ax-gdb.h: Revert.
9627 * ax-gdb.c: Revert.
9628 * avr-tdep.c: Revert.
9629 * auxv.c: Revert.
9630 * auto-load.c: Revert.
9631 * arm-wince-tdep.c: Revert.
9632 * arm-tdep.c: Revert.
9633 * arm-symbian-tdep.c: Revert.
9634 * arm-pikeos-tdep.c: Revert.
9635 * arm-obsd-tdep.c: Revert.
9636 * arm-nbsd-tdep.c: Revert.
9637 * arm-nbsd-nat.c: Revert.
9638 * arm-linux-tdep.c: Revert.
9639 * arm-linux-nat.c: Revert.
9640 * arm-fbsd-tdep.c: Revert.
9641 * arm-fbsd-nat.c: Revert.
9642 * arm-bsd-tdep.c: Revert.
9643 * arch-utils.c: Revert.
9644 * arc-tdep.c: Revert.
9645 * arc-newlib-tdep.c: Revert.
9646 * annotate.h: Revert.
9647 * annotate.c: Revert.
9648 * amd64-windows-tdep.c: Revert.
9649 * amd64-windows-nat.c: Revert.
9650 * amd64-tdep.c: Revert.
9651 * amd64-sol2-tdep.c: Revert.
9652 * amd64-obsd-tdep.c: Revert.
9653 * amd64-obsd-nat.c: Revert.
9654 * amd64-nbsd-tdep.c: Revert.
9655 * amd64-nbsd-nat.c: Revert.
9656 * amd64-nat.c: Revert.
9657 * amd64-linux-tdep.c: Revert.
9658 * amd64-linux-nat.c: Revert.
9659 * amd64-fbsd-tdep.c: Revert.
9660 * amd64-fbsd-nat.c: Revert.
9661 * amd64-dicos-tdep.c: Revert.
9662 * amd64-darwin-tdep.c: Revert.
9663 * amd64-bsd-nat.c: Revert.
9664 * alpha-tdep.c: Revert.
9665 * alpha-obsd-tdep.c: Revert.
9666 * alpha-nbsd-tdep.c: Revert.
9667 * alpha-mdebug-tdep.c: Revert.
9668 * alpha-linux-tdep.c: Revert.
9669 * alpha-linux-nat.c: Revert.
9670 * alpha-bsd-tdep.c: Revert.
9671 * alpha-bsd-nat.c: Revert.
9672 * aix-thread.c: Revert.
9673 * agent.c: Revert.
9674 * addrmap.c: Revert.
9675 * ada-varobj.c: Revert.
9676 * ada-valprint.c: Revert.
9677 * ada-typeprint.c: Revert.
9678 * ada-tasks.c: Revert.
9679 * ada-lang.c: Revert.
9680 * aarch64-tdep.c: Revert.
9681 * aarch64-ravenscar-thread.c: Revert.
9682 * aarch64-newlib-tdep.c: Revert.
9683 * aarch64-linux-tdep.c: Revert.
9684 * aarch64-linux-nat.c: Revert.
9685 * aarch64-fbsd-tdep.c: Revert.
9686 * aarch64-fbsd-nat.c: Revert.
9687 * aarch32-linux-nat.c: Revert.
9688
9689 2019-04-05 Tom Tromey <tom@tromey.com>
9690
9691 * ft32-tdep.c: Sort headers.
9692 * frv-tdep.c: Sort headers.
9693 * frv-linux-tdep.c: Sort headers.
9694 * frame.c: Sort headers.
9695 * frame-unwind.c: Sort headers.
9696 * frame-base.c: Sort headers.
9697 * fork-child.c: Sort headers.
9698 * findvar.c: Sort headers.
9699 * findcmd.c: Sort headers.
9700 * filesystem.c: Sort headers.
9701 * filename-seen-cache.h: Sort headers.
9702 * filename-seen-cache.c: Sort headers.
9703 * fbsd-tdep.c: Sort headers.
9704 * fbsd-nat.h: Sort headers.
9705 * fbsd-nat.c: Sort headers.
9706 * f-valprint.c: Sort headers.
9707 * f-typeprint.c: Sort headers.
9708 * f-lang.c: Sort headers.
9709 * extension.h: Sort headers.
9710 * extension.c: Sort headers.
9711 * extension-priv.h: Sort headers.
9712 * expprint.c: Sort headers.
9713 * exec.h: Sort headers.
9714 * exec.c: Sort headers.
9715 * exceptions.c: Sort headers.
9716 * event-top.c: Sort headers.
9717 * event-loop.c: Sort headers.
9718 * eval.c: Sort headers.
9719 * elfread.c: Sort headers.
9720 * dwarf2read.h: Sort headers.
9721 * dwarf2read.c: Sort headers.
9722 * dwarf2loc.c: Sort headers.
9723 * dwarf2expr.h: Sort headers.
9724 * dwarf2expr.c: Sort headers.
9725 * dwarf2-frame.c: Sort headers.
9726 * dwarf2-frame-tailcall.c: Sort headers.
9727 * dwarf-index-write.h: Sort headers.
9728 * dwarf-index-write.c: Sort headers.
9729 * dwarf-index-common.c: Sort headers.
9730 * dwarf-index-cache.h: Sort headers.
9731 * dwarf-index-cache.c: Sort headers.
9732 * dummy-frame.c: Sort headers.
9733 * dtrace-probe.c: Sort headers.
9734 * disasm.h: Sort headers.
9735 * disasm.c: Sort headers.
9736 * disasm-selftests.c: Sort headers.
9737 * dictionary.c: Sort headers.
9738 * dicos-tdep.c: Sort headers.
9739 * demangle.c: Sort headers.
9740 * dcache.h: Sort headers.
9741 * dcache.c: Sort headers.
9742 * darwin-nat.h: Sort headers.
9743 * darwin-nat.c: Sort headers.
9744 * darwin-nat-info.c: Sort headers.
9745 * d-valprint.c: Sort headers.
9746 * d-namespace.c: Sort headers.
9747 * d-lang.c: Sort headers.
9748 * ctf.c: Sort headers.
9749 * csky-tdep.c: Sort headers.
9750 * csky-linux-tdep.c: Sort headers.
9751 * cris-tdep.c: Sort headers.
9752 * cris-linux-tdep.c: Sort headers.
9753 * cp-valprint.c: Sort headers.
9754 * cp-support.c: Sort headers.
9755 * cp-namespace.c: Sort headers.
9756 * cp-abi.c: Sort headers.
9757 * corelow.c: Sort headers.
9758 * corefile.c: Sort headers.
9759 * continuations.c: Sort headers.
9760 * completer.h: Sort headers.
9761 * completer.c: Sort headers.
9762 * complaints.c: Sort headers.
9763 * coffread.c: Sort headers.
9764 * coff-pe-read.c: Sort headers.
9765 * cli-out.h: Sort headers.
9766 * cli-out.c: Sort headers.
9767 * charset.c: Sort headers.
9768 * c-varobj.c: Sort headers.
9769 * c-valprint.c: Sort headers.
9770 * c-typeprint.c: Sort headers.
9771 * c-lang.c: Sort headers.
9772 * buildsym.c: Sort headers.
9773 * buildsym-legacy.c: Sort headers.
9774 * build-id.h: Sort headers.
9775 * build-id.c: Sort headers.
9776 * btrace.c: Sort headers.
9777 * bsd-uthread.c: Sort headers.
9778 * breakpoint.h: Sort headers.
9779 * breakpoint.c: Sort headers.
9780 * break-catch-throw.c: Sort headers.
9781 * break-catch-syscall.c: Sort headers.
9782 * break-catch-sig.c: Sort headers.
9783 * blockframe.c: Sort headers.
9784 * block.c: Sort headers.
9785 * bfin-tdep.c: Sort headers.
9786 * bfin-linux-tdep.c: Sort headers.
9787 * bfd-target.c: Sort headers.
9788 * bcache.c: Sort headers.
9789 * ax-general.c: Sort headers.
9790 * ax-gdb.h: Sort headers.
9791 * ax-gdb.c: Sort headers.
9792 * avr-tdep.c: Sort headers.
9793 * auxv.c: Sort headers.
9794 * auto-load.c: Sort headers.
9795 * arm-wince-tdep.c: Sort headers.
9796 * arm-tdep.c: Sort headers.
9797 * arm-symbian-tdep.c: Sort headers.
9798 * arm-pikeos-tdep.c: Sort headers.
9799 * arm-obsd-tdep.c: Sort headers.
9800 * arm-nbsd-tdep.c: Sort headers.
9801 * arm-nbsd-nat.c: Sort headers.
9802 * arm-linux-tdep.c: Sort headers.
9803 * arm-linux-nat.c: Sort headers.
9804 * arm-fbsd-tdep.c: Sort headers.
9805 * arm-fbsd-nat.c: Sort headers.
9806 * arm-bsd-tdep.c: Sort headers.
9807 * arch-utils.c: Sort headers.
9808 * arc-tdep.c: Sort headers.
9809 * arc-newlib-tdep.c: Sort headers.
9810 * annotate.h: Sort headers.
9811 * annotate.c: Sort headers.
9812 * amd64-windows-tdep.c: Sort headers.
9813 * amd64-windows-nat.c: Sort headers.
9814 * amd64-tdep.c: Sort headers.
9815 * amd64-sol2-tdep.c: Sort headers.
9816 * amd64-obsd-tdep.c: Sort headers.
9817 * amd64-obsd-nat.c: Sort headers.
9818 * amd64-nbsd-tdep.c: Sort headers.
9819 * amd64-nbsd-nat.c: Sort headers.
9820 * amd64-nat.c: Sort headers.
9821 * amd64-linux-tdep.c: Sort headers.
9822 * amd64-linux-nat.c: Sort headers.
9823 * amd64-fbsd-tdep.c: Sort headers.
9824 * amd64-fbsd-nat.c: Sort headers.
9825 * amd64-dicos-tdep.c: Sort headers.
9826 * amd64-darwin-tdep.c: Sort headers.
9827 * amd64-bsd-nat.c: Sort headers.
9828 * alpha-tdep.c: Sort headers.
9829 * alpha-obsd-tdep.c: Sort headers.
9830 * alpha-nbsd-tdep.c: Sort headers.
9831 * alpha-mdebug-tdep.c: Sort headers.
9832 * alpha-linux-tdep.c: Sort headers.
9833 * alpha-linux-nat.c: Sort headers.
9834 * alpha-bsd-tdep.c: Sort headers.
9835 * alpha-bsd-nat.c: Sort headers.
9836 * aix-thread.c: Sort headers.
9837 * agent.c: Sort headers.
9838 * addrmap.c: Sort headers.
9839 * ada-varobj.c: Sort headers.
9840 * ada-valprint.c: Sort headers.
9841 * ada-typeprint.c: Sort headers.
9842 * ada-tasks.c: Sort headers.
9843 * ada-lang.c: Sort headers.
9844 * aarch64-tdep.c: Sort headers.
9845 * aarch64-ravenscar-thread.c: Sort headers.
9846 * aarch64-newlib-tdep.c: Sort headers.
9847 * aarch64-linux-tdep.c: Sort headers.
9848 * aarch64-linux-nat.c: Sort headers.
9849 * aarch64-fbsd-tdep.c: Sort headers.
9850 * aarch64-fbsd-nat.c: Sort headers.
9851 * aarch32-linux-nat.c: Sort headers.
9852
9853 2019-04-04 Tom Tromey <tom@tromey.com>
9854
9855 * varobj.c (varobj_create): Update.
9856 * rust-exp.y (struct rust_parser) <update_innermost_block,
9857 lookup_symbol>: New methods.
9858 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9859 Rename.
9860 (rust_parser::rust_lookup_type)
9861 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9862 * printcmd.c (display_command, do_one_display): Update.
9863 * parser-defs.h (struct parser_state) <parser_state>: Add
9864 "tracker" parameter.
9865 (block_tracker): New member.
9866 (class innermost_block_tracker) <innermost_block_tracker>: Add
9867 "types" parameter.
9868 <reset>: Remove method.
9869 (innermost_block): Don't declare.
9870 (null_post_parser): Update.
9871 * parse.c (innermost_block): Remove global.
9872 (write_dollar_variable): Update.
9873 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9874 Remove "tracker_types" parameter.
9875 (parse_expression): Add "tracker" parameter.
9876 (parse_expression_for_completion): Update.
9877 (null_post_parser): Add "tracker" parameter.
9878 * p-exp.y: Update rules.
9879 * m2-exp.y: Update rules.
9880 * language.h (struct language_defn) <la_post_parser>: Add
9881 "tracker" parameter.
9882 * go-exp.y: Update rules.
9883 * f-exp.y: Update rules.
9884 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9885 parameter.
9886 * d-exp.y: Update rules.
9887 * c-exp.y: Update rules.
9888 * breakpoint.c (set_breakpoint_condition): Create an
9889 innermost_block_tracker.
9890 (watch_command_1): Likewise.
9891 * ada-lang.c (resolve): Add "tracker" parameter.
9892 (resolve_subexp): Likewise.
9893 * ada-exp.y (write_var_from_sym): Update.
9894
9895 2019-04-04 Tom Tromey <tom@tromey.com>
9896
9897 * type-stack.h: New file.
9898 * type-stack.c: New file.
9899 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9900 type-stack.h.
9901 (insert_into_type_stack, insert_type, push_type, push_type_int)
9902 (insert_type_address_space, pop_type, pop_type_int)
9903 (pop_typelist, pop_type_stack, append_type_stack)
9904 (push_type_stack, get_type_stack, push_typelist)
9905 (follow_type_instance_flags, follow_types): Don't declare.
9906 * parse.c (type_stack): Remove global.
9907 (parse_exp_in_context): Update.
9908 (insert_into_type_stack, insert_type, push_type, push_type_int)
9909 (insert_type_address_space, pop_type, pop_type_int)
9910 (pop_typelist, pop_type_stack, append_type_stack)
9911 (push_type_stack, get_type_stack, push_typelist)
9912 (follow_type_instance_flags, follow_types): Remove (moved to
9913 type-stack.c).
9914 * f-exp.y (type_stack): New global.
9915 Update rules.
9916 (push_kind_type, f_parse): Update.
9917 * d-exp.y (type_stack): New global.
9918 Update rules.
9919 (d_parse): Update.
9920 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9921 Update rules.
9922 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9923 (HFILES_NO_SRCDIR): Add type-stack.h.
9924
9925 2019-04-04 Tom Tromey <tom@tromey.com>
9926
9927 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9928 (rust_parser::convert_ast_to_expression, rust_parse)
9929 (rust_lex_test_completion, rust_lex_tests): Update.
9930 * parser-defs.h (struct expr_completion_state): New.
9931 (struct parser_state) <parser_state>: Add completion parameter.
9932 <mark_struct_expression, mark_completion_tag>: New methods.
9933 <parse_completion, m_completion_state>: New members.
9934 (prefixify_expression, null_post_parser): Update.
9935 (mark_struct_expression, mark_completion_tag): Don't declare.
9936 * parse.c (parse_completion, expout_last_struct)
9937 (expout_tag_completion_type, expout_completion_name): Remove
9938 globals.
9939 (parser_state::mark_struct_expression)
9940 (parser_state::mark_completion_tag): Now methods.
9941 (prefixify_expression): Add last_struct parameter.
9942 (prefixify_subexp): Likewise.
9943 (parse_exp_1): Update.
9944 (parse_exp_in_context): Add cstate parameter. Update.
9945 (parse_expression_for_completion): Create an
9946 expr_completion_state.
9947 (null_post_parser): Add "completion" parameter.
9948 * p-exp.y: Update rules.
9949 (yylex): Update.
9950 * language.h (struct language_defn) <la_post_parser>: Add
9951 "completing" parameter.
9952 * go-exp.y: Update rules.
9953 (lex_one_token): Update.
9954 * expression.h (parse_completion): Don't declare.
9955 * d-exp.y: Update rules.
9956 (lex_one_token): Update rules.
9957 * c-exp.y: Update rules.
9958 (lex_one_token): Update.
9959 * ada-lang.c (resolve): Add "parse_completion" parameter.
9960 (resolve_subexp): Likewise.
9961 (ada_resolve_function): Likewise.
9962
9963 2019-04-04 Tom Tromey <tom@tromey.com>
9964
9965 * parser-defs.h (struct parser_state) <start_arglist,
9966 end_arglist>: New methods.
9967 <arglist_len, m_funcall_chain>: New members.
9968 (arglist_len, start_arglist, end_arglist): Don't declare.
9969 * parse.c (arglist_len, funcall_chain): Remove global.
9970 (start_arglist, end_arglist): Remove functions.
9971 (parse_exp_in_context): Update.
9972 * p-exp.y: Update rules.
9973 * m2-exp.y: Update rules.
9974 * go-exp.y: Update rules.
9975 * f-exp.y: Update rules.
9976 * d-exp.y: Update rules.
9977 * c-exp.y: Update rules.
9978
9979 2019-04-04 Tom Tromey <tom@tromey.com>
9980
9981 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9982 lex_operator, push_back>: New methods.
9983 Update all rules.
9984 (rust_parser::lex_hex, lex_escape): Rename and update.
9985 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9986 (rust_parser::lex_operator): Rename and update.
9987 (rust_parser::lex_number, rustyylex, rustyyerror)
9988 (rust_lex_test_init, rust_lex_test_sequence)
9989 (rust_lex_test_push_back, rust_lex_tests): Update.
9990 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9991 parameter.
9992 <lexptr, prev_lexptr>: New members.
9993 (lexptr, prev_lexptr): Don't declare.
9994 * parse.c (lexptr, prev_lexptr): Remove globals.
9995 (parse_exp_in_context): Update.
9996 * p-exp.y (yylex, yyerror): Update.
9997 * m2-exp.y (parse_number, yylex, yyerror): Update.
9998 * go-exp.y (lex_one_token, yyerror): Update.
9999 * f-exp.y (match_string_literal, yylex, yyerror): Update.
10000 * d-exp.y (lex_one_token, yyerror): Update.
10001 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10002 (lex_one_token, yyerror): Update.
10003 * ada-lex.l (YY_INPUT): Update.
10004 (rewind_to_char): Update.
10005 * ada-exp.y (yyerror): Update.
10006
10007 2019-04-04 Tom Tromey <tom@tromey.com>
10008
10009 * rust-exp.y (rustyylex, rust_lex_tests): Update.
10010 * parser-defs.h (struct parser_state) <parser_state>: Add new
10011 parameter.
10012 <comma_terminates>: New member.
10013 (comma_terminates): Don't declare global.
10014 * parse.c (comma_terminates): Remove global.
10015 (parse_exp_in_context): Update.
10016 * p-exp.y (yylex): Update.
10017 * m2-exp.y (yylex): Update.
10018 * go-exp.y (lex_one_token): Update.
10019 * f-exp.y (yylex): Update.
10020 * d-exp.y (lex_one_token): Update.
10021 * c-exp.y (lex_one_token): Update.
10022 * ada-lex.l: Update.
10023
10024 2019-04-04 Tom Tromey <tom@tromey.com>
10025
10026 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10027 (rustyylex, rust_lex_test_init, rust_lex_test_one)
10028 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10029 * parser-defs.h (paren_depth): Don't declare.
10030 * parse.c (paren_depth): Remove global.
10031 (parse_exp_in_context): Update.
10032 * p-exp.y (paren_depth): New global.
10033 (pascal_parse): Initialize it.
10034 * m2-exp.y (paren_depth): New global.
10035 (m2_parse): Initialize it.
10036 * go-exp.y (paren_depth): New global.
10037 (go_parse): Initialize it.
10038 * f-exp.y (paren_depth): New global.
10039 (f_parse): Initialize it.
10040 * d-exp.y (paren_depth): New global.
10041 (d_parse): Initialize it.
10042 * c-exp.y (paren_depth): New global.
10043 (c_parse): Initialize it.
10044 * ada-lex.l (paren_depth): New global.
10045 (lexer_init): Initialize it.
10046
10047 2019-04-04 Tom Tromey <tom@tromey.com>
10048
10049 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10050 (rust_parser::convert_ast_to_type)
10051 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10052 * parser-defs.h (struct parser_state) <parser_state>: Add
10053 parameters. Initialize new members.
10054 <expression_context_block, expression_context_pc>: New members.
10055 * parse.c (expression_context_block, expression_context_pc):
10056 Remove globals.
10057 (parse_exp_in_context): Update.
10058 * p-exp.y: Update all rules.
10059 (yylex): Update.
10060 * m2-exp.y: Update all rules.
10061 (yylex): Update.
10062 * go-exp.y (yylex): Update.
10063 * f-exp.y (yylex): Update.
10064 * d-exp.y: Update all rules.
10065 (yylex): Update.
10066 * c-exp.y: Update all rules.
10067 (lex_one_token, classify_name, yylex, c_parse): Update.
10068 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10069
10070 2019-04-04 Tom Tromey <tom@tromey.com>
10071
10072 * gdbarch.h, gdbarch.c: Rebuild.
10073 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10074 * stap-probe.h:
10075 (struct stap_parse_info): Replace "parser_state" with
10076 "expr_builder".
10077 * parser-defs.h (struct expr_builder): Rename from "parser_state".
10078 (parser_state): New class.
10079 * parse.c (expr_builder): Rename.
10080 (expr_builder::release): Rename.
10081 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10082 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10083 (write_exp_elt_longcst, write_exp_elt_floatcst)
10084 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10085 (write_exp_string_vector, write_exp_bitstring)
10086 (write_exp_msymbol, mark_struct_expression)
10087 (write_dollar_variable)
10088 (insert_type_address_space, increase_expout_size): Replace
10089 "parser_state" with "expr_builder".
10090 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10091 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10092 "parser_state" with "expr_builder".
10093
10094 2019-04-04 Tom Tromey <tom@tromey.com>
10095
10096 * rust-exp.y: Replace "parse_language" with method call.
10097 * p-exp.y:
10098 (yylex): Replace "parse_language" with method call.
10099 * m2-exp.y:
10100 (yylex): Replace "parse_language" with method call.
10101 * go-exp.y (classify_name): Replace "parse_language" with method
10102 call.
10103 * f-exp.y (yylex): Replace "parse_language" with method call.
10104 * d-exp.y (lex_one_token): Replace "parse_language" with method
10105 call.
10106 * c-exp.y:
10107 (lex_one_token, classify_name, yylex): Replace "parse_language"
10108 with method call.
10109 * ada-exp.y (find_primitive_type, type_char)
10110 (type_system_address): Replace "parse_language" with method call.
10111
10112 2019-04-04 Tom Tromey <tom@tromey.com>
10113
10114 * rust-exp.y: Replace "parse_gdbarch" with method call.
10115 * parse.c (write_dollar_variable, insert_type_address_space):
10116 Replace "parse_gdbarch" with method call.
10117 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10118 call.
10119 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10120 call.
10121 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10122 "parse_gdbarch" with method call.
10123 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10124 with method call.
10125 * f-exp.y (parse_type, parse_f_type, yylex): Replace
10126 "parse_gdbarch" with method call.
10127 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10128 "parse_gdbarch" with method call.
10129 * c-exp.y (parse_type, parse_number, classify_name): Replace
10130 "parse_gdbarch" with method call.
10131 * ada-lex.l: Replace "parse_gdbarch" with method call.
10132 * ada-exp.y (parse_type, find_primitive_type, type_char)
10133 (type_system_address): Replace "parse_gdbarch" with method call.
10134
10135 2019-04-04 Tom Tromey <tom@tromey.com>
10136
10137 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10138 * stap-probe.c (stap_parse_argument): Update.
10139 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10140 initial_size parameter.
10141 * rust-exp.y (rust_lex_tests): Update.
10142 * parse.c (parser_state): Update.
10143 (parse_exp_in_context): Update.
10144 * parser-defs.h (struct parser_state) <parser_state>: Remove
10145 "initial_size" parameter.
10146
10147 2019-04-04 Tom Tromey <tom@tromey.com>
10148
10149 * parser-defs.h (increase_expout_size): Don't declare.
10150 * parse.c (increase_expout_size): Now static.
10151
10152 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
10153
10154 * gnu-nat.c (gnu_nat_target::wait): Fix
10155 target_waitstatus_to_string call.
10156
10157 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10158
10159 * eval.c (evaluate_subexp_standard): Handle internal functions
10160 during Fortran function call handling.
10161
10162 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
10163
10164 * NEWS: Mention new internal functions.
10165 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10166 (read_base_type): Use dwarf2_init_complex_target_type.
10167 * value.c (creal_internal_fn): New function.
10168 (cimag_internal_fn): New function.
10169 (_initialize_values): Register new internal functions.
10170
10171 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10172
10173 * infrun.c (stop_all_threads): If debug_infrun, always
10174 trace the wait status after wait_one, using
10175 target_waitstatus_to_string and target_pid_to_str.
10176 (handle_inferior_event): Replace various trace of
10177 wait status kind by a single trace.
10178 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10179 wait status kind image by target_waitstatus_to_string.
10180 * target/waitstatus.c (target_waitstatus_to_string): Fix
10181 obsolete comment.
10182
10183 2019-04-01 Tom Tromey <tromey@adacore.com>
10184
10185 PR symtab/23331:
10186 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10187
10188 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
10189 Pedro Alves <palves@redhat.com>
10190
10191 * top.c (quit_force): Call 'finalize_values'.
10192 * value.c (finalize_values): New function.
10193 * value.h (finalize_values): Declare.
10194
10195 2019-03-30 Eli Zaretskii <eliz@gnu.org>
10196
10197 * NEWS: Announce $_gdb_major and $_gdb_minor.
10198
10199 * top.c (init_gdb_version_vars): New function.
10200 (gdb_init): Call init_gdb_version_vars.
10201
10202 2019-03-29 Tom Tromey <tromey@adacore.com>
10203
10204 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
10205 help text. Remove dead code.
10206
10207 2019-03-29 Keith Seitz <keiths@redhat.com>
10208
10209 From Siddhesh Poyarekar:
10210 * f-lang.h (f77_get_upperbound): Return LONGEST.
10211 (f77_get_lowerbound): Likewise.
10212 * f-typeprint.c (f_type_print_varspec_suffix): Expand
10213 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
10214 print them.
10215 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
10216 plongest to format print it.
10217 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10218 (f77_get_upperbound): Likewise.
10219 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10220 LOWER_BOUND to LONGEST.
10221 (f77_create_arrayprint_offset_tbl): Likewise.
10222
10223 2019-03-29 Keith Seitz <keiths@redhat.com>
10224
10225 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10226 %s/pulongest for TYPE_LENGTH instead of %d in format
10227 strings.
10228 * ada-typerint.c (ada_print_type): Likewise.
10229 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10230 * compile/compile-c-support.c (generate_register_struct): Likewise.
10231 * gdbtypes.c (recursive_dump_type): Likewise.
10232 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10233 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
10234 instead of %d in format strings.
10235 * riscv-tdep.c (riscv_type_alignment): Cast second argument
10236 to std::min to ULONGEST.
10237 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10238 instead of %d in format strings.
10239 * tracepoint.c (info_scope_command): Likewise.
10240 * typeprint.c (print_offset_data::update)
10241 (print_offset_data::finish): Likewise.
10242 * xtensa-tdep.c (xtensa_store_return_value)
10243 (xtensa_push_dummy_call): Likewise.
10244
10245 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
10246
10247 * windows-nat.c (display_selector): Fixed format specifications
10248 for 64-bit Cygwin.
10249
10250 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10251
10252 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10253
10254 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
10255
10256 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10257 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10258 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10259 (nios2_linux_init_abi): Install it.
10260
10261 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10262
10263 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10264
10265 2019-03-28 Alan Hayward <alan.hayward@arm.com>
10266
10267 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10268
10269 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10270 Tom Tromey <tromey@adacore.com>
10271
10272 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10273
10274 2019-03-26 Joel Brobecker <brobecker@adacore.com>
10275
10276 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10277 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10278 method to compute the bounds of range types. Also print "[evaluated]"
10279 if the bounds' values come from a dynamic evaluation.
10280
10281 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
10282
10283 * cp-valprint.c (cp_print_value_fields): Don't print trailing
10284 whitespace when pretty printing is on.
10285
10286 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10287
10288 * ppc-linux-nat.c: Add include.
10289
10290 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10291
10292 * NEWS: Mention AArch64 Pointer Authentication.
10293
10294 2019-03-26 Alan Hayward <alan.hayward@arm.com>
10295
10296 * arm-linux-nat.c: Add include.
10297
10298 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
10299
10300 * source-cache.c (source_cache::get_source_lines): Re-read
10301 fullname after calling open_source_file.
10302
10303 2019-03-25 John Baldwin <jhb@FreeBSD.org>
10304
10305 * NEWS: Mention TLS support for FreeBSD.
10306
10307 2019-03-25 Tom Tromey <tromey@adacore.com>
10308
10309 * minsyms.c (BUNCH_SIZE): Update comment.
10310 (~minimal_symbol_reader): Remove old comment.
10311 (compact_minimal_symbols): Update comment.
10312 (minimal_symbol_reader::install): Remove old comment. Update
10313 other comments.
10314
10315 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10316
10317 * s390-linux-nat.c: Add include.
10318
10319 2019-03-25 Alan Hayward <alan.hayward@arm.com>
10320
10321 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10322 Call linux_get_hwcap.
10323 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10324 Likewise.
10325 (aarch64_linux_get_hwcap): Remove function.
10326 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10327 declaration.
10328 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10329 linux_get_hwcap.
10330 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10331 * linux-tdep.c (linux_get_hwcap): Add function.
10332 (linux_get_hwcap2): Likewise.
10333 * linux-tdep.h (linux_get_hwcap): Add declaration.
10334 (linux_get_hwcap2): Likewise.
10335 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10336 (ppc_linux_get_hwcap2): Likewise.
10337 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10338 linux_get_hwcap.
10339 (ppc_linux_nat_target::insert_watchpoint): Likewise.
10340 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10341 (ppc_linux_nat_target::read_description): Likewise.
10342 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10343 * s390-linux-nat.c: Likewise.
10344 * s390-linux-tdep.c (s390_core_read_description): Likewise.
10345
10346 2019-03-24 Tom Tromey <tom@tromey.com>
10347
10348 * ada-lang.c (standard_lookup): Simplify initialization.
10349 (ada_lookup_symbol_nonlocal): Simplify return.
10350 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10351 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10352 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10353 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10354 initialization.
10355 * solib.c (solib_global_lookup): Simplify.
10356 * symtab.c (null_block_symbol): Remove.
10357 (symbol_cache_lookup): Simplify returns.
10358 (lookup_language_this): Simplify returns.
10359 (lookup_symbol_aux): Simplify return.
10360 (lookup_local_symbol): Simplify returns.
10361 (lookup_global_symbol_from_objfile): Simplify return.
10362 (lookup_symbol_in_objfile_symtabs)
10363 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10364 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10365 (lookup_static_symbol, lookup_global_symbol): Simplify return.
10366 * cp-namespace.c (cp_lookup_bare_symbol)
10367 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10368 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10369 (cp_lookup_nested_symbol): Don't use null_block_symbol.
10370 (cp_lookup_symbol_via_imports): Simplify initialization.
10371 (find_symbol_in_baseclass): Likewise.
10372 * symtab.h (null_block_symbol): Remove.
10373 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10374 (d_lookup_nested_symbol, d_lookup_symbol_imports)
10375 (d_lookup_symbol_module): Likewise.
10376 (find_symbol_in_baseclass): Simplify initialization.
10377
10378 2019-03-24 Tom Tromey <tom@tromey.com>
10379
10380 * expression.h: Don't include symtab.h.
10381 (struct block): Forward declare.
10382
10383 2019-03-24 Tom Tromey <tom@tromey.com>
10384
10385 * c-exp.y (typebase): Remove casts.
10386 * gdbtypes.c (lookup_unsigned_typename, )
10387 (lookup_signed_typename): Remove cast.
10388 * eval.c (parse_to_comma_and_eval): Remove cast.
10389 * parse.c (write_dollar_variable): Remove cast.
10390 * block.h (struct block) <superblock>: Now const.
10391 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10392 * psymtab.c (psym_map_matching_symbols): Make "block" const.
10393 (map_block): Make "block" const.
10394 * symfile.h (struct quick_symbol_functions)
10395 <map_matching_symbols>: Constify block argument to "callback".
10396 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10397 const.
10398 (find_pc_sect_compunit_symtab): Make "b" const.
10399 (find_symbol_at_address): Likewise.
10400 (search_symbols): Likewise.
10401 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10402 (dw2_debug_names_lookup_symbol): Likewise.
10403 (dw2_map_matching_symbols): Update.
10404 * p-valprint.c (pascal_val_print): Remove "block".
10405 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10406 (aux_add_nonlocal_symbols): Make "block" const.
10407 (resolve_subexp): Remove cast.
10408 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10409 const.
10410 (iterate_over_file_blocks): Likewise.
10411 * f-exp.y (%union) <bval>: Remove.
10412 * coffread.c (patch_opaque_types): Make "b" const.
10413 * spu-tdep.c (spu_catch_start): Make "block" const.
10414 * c-valprint.c (print_unpacked_pointer): Remove "block".
10415 * symmisc.c (dump_symtab_1): Make "b" const.
10416 (block_depth): Make "block" const.
10417 * d-exp.y (%union) <bval>: Remove.
10418 * cp-support.h (cp_lookup_rtti_type): Update.
10419 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10420 * psymtab.c (psym_lookup_symbol): Make "block" const.
10421 (maintenance_check_psymtabs): Make "b" const.
10422 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10423 (enumerate_locals, enumerate_args): Update.
10424 * python/py-symtab.c (stpy_global_block): Make "block" const.
10425 (stpy_static_block): Likewise.
10426 * inline-frame.c (block_starting_point_at): Make "new_block"
10427 const.
10428 * block.c (find_block_in_blockvector): Make return type const.
10429 (blockvector_for_pc_sect): Make "b" const.
10430 (find_block_in_blockvector): Make "b" const.
10431
10432 2019-03-23 Tom Tromey <tom@tromey.com>
10433
10434 * varobj.c (varobj_create): Update.
10435 * symfile.c (clear_symtab_users): Don't reset innermost_block.
10436 * printcmd.c (display_command, do_one_display): Don't reset
10437 innermost_block.
10438 * parser-defs.h (enum innermost_block_tracker_type): Move to
10439 expression.h.
10440 (innermost_block): Update comment.
10441 * parse.c (parse_exp_1): Add tracker_types parameter.
10442 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
10443 tracker_types parameter. Reset innermost_block.
10444 (parse_exp_in_context): Remove.
10445 (parse_expression_for_completion): Update.
10446 * objfiles.c (~objfile): Don't reset expression_context_block or
10447 innermost_block.
10448 * expression.h (enum innermost_block_tracker_type): Move from
10449 parser-defs.h.
10450 (parse_exp_1): Add tracker_types parameter.
10451 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10452 reset innermost_block.
10453
10454 2019-03-23 Tom Tromey <tom@tromey.com>
10455
10456 * objfiles.h: Include bcache.h.
10457
10458 2019-03-23 Tom Tromey <tom@tromey.com>
10459
10460 * linespec.c (get_current_search_block): Use
10461 scoped_restore_current_language.
10462 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10463
10464 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10465 Jiong Wang <jiong.wang@arm.com>
10466
10467 * aarch64-linux-tdep.c
10468 (aarch64_linux_iterate_over_regset_sections): Check for pauth
10469 section.
10470 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10471
10472 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10473 Jiong Wang <jiong.wang@arm.com>
10474
10475 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10476 instructions.
10477 (aarch64_analyze_prologue_test): Add PACIASP test.
10478 (aarch64_prologue_prev_register): Unmask PC value.
10479
10480 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10481 Jiong Wang <jiong.wang@arm.com>
10482
10483 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10484 (aarch64_dwarf2_prev_register): Unmask PC value.
10485 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10486 (aarch64_execute_dwarf_cfa_vendor_op): Check for
10487 DW_CFA_AARCH64_negate_ra_state.
10488 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10489
10490 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10491 Jiong Wang <jiong.wang@arm.com>
10492
10493 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10494 registers.
10495 (aarch64_pseudo_register_name): Likewise.
10496 (aarch64_pseudo_register_type): Likewise.
10497 (aarch64_pseudo_register_reggroup_p): Likewise.
10498 (aarch64_gdbarch_init): Add pauth registers.
10499 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10500 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10501 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10502 (struct gdbarch_tdep): Add regnum for ra_state.
10503
10504 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10505 Jiong Wang <jiong.wang@arm.com>
10506
10507 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10508
10509 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10510 Jiong Wang <jiong.wang@arm.com>
10511
10512 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10513 function.
10514 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10515 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10516 (aarch64_gdbarch_init): Add puth registers.
10517 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10518 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10519 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10520
10521 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10522 Jiong Wang <jiong.wang@arm.com>
10523
10524 * aarch64-linux-nat.c
10525 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10526 * aarch64-linux-tdep.c
10527 (aarch64_linux_core_read_description): Likewise.
10528 (aarch64_linux_get_hwcap): New function.
10529 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10530 (aarch64_linux_get_hwcap): New declaration.
10531
10532 2019-03-22 Alan Hayward <alan.hayward@arm.com>
10533 Jiong Wang <jiong.wang@arm.com>
10534
10535 * aarch64-linux-nat.c
10536 (aarch64_linux_nat_target::read_description): Add pauth param.
10537 * aarch64-linux-tdep.c
10538 (aarch64_linux_core_read_description): Likewise.
10539 * aarch64-tdep.c (struct target_desc): Add in pauth.
10540 (aarch64_read_description): Add pauth param.
10541 (aarch64_gdbarch_init): Likewise.
10542 * aarch64-tdep.h (aarch64_read_description): Likewise.
10543 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10544 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10545 * features/Makefile: Add new files.
10546 * features/aarch64-pauth.c: New file.
10547 * features/aarch64-pauth.xml: New file.
10548
10549 2019-03-20 Tom Tromey <tromey@adacore.com>
10550
10551 * infrun.c (handle_inferior_event): Rename from
10552 handle_inferior_event_1. Create a scoped_value_mark.
10553 (handle_inferior_event): Remove.
10554
10555 2019-03-19 Tom Tromey <tromey@adacore.com>
10556
10557 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10558 * infrun.h (print_stop_event): Add "displays" parameter.
10559 * infrun.c (print_stop_event): Add "displays" parameter.
10560
10561 2019-03-19 Pedro Alves <palves@redhat.com>
10562
10563 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10564 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10565 to -1. Fix TABs vs spaces.
10566 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10567 * tui/tui-out.h (tui_ui_out) Add intro comments.
10568 <m_line, m_start_of_line>: In-class initialize, and add describing
10569 comment.
10570
10571 2019-03-18 Alan Hayward <alan.hayward@arm.com>
10572
10573 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10574 variable names.
10575 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10576
10577 2019-03-18 Pedro Alves <palves@redhat.com>
10578 Eli Zaretskii <eliz@gnu.org>
10579
10580 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10581 m_line and m_start_of_line.
10582
10583 2019-03-18 Eli Zaretskii <eliz@gnu.org>
10584
10585 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10586 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10587 it returns a newline. This fixes a regression in TU mode, whereby
10588 the next line is output on the same screen line as the user input.
10589
10590 2019-03-18 Tom Tromey <tromey@adacore.com>
10591
10592 * minsyms.c (minimal_symbol_reader::install): Remove call to
10593 obstack_blank.
10594
10595 2019-03-18 Pedro Alves <palves@redhat.com>
10596
10597 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10598 New globals.
10599 (apply_style): New, factored out from ...
10600 (apply_ansi_escape): ... this. Handle reverse video mode.
10601 (tui_set_reverse_mode): New function.
10602 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10603 * tui/tui-winsource.c (tui_show_source_line): Use
10604 tui_set_reverse_mode instead of setting A_STANDOUT.
10605 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10606 New setter methods.
10607
10608 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
10609
10610 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10611 Handle tabs.
10612
10613 2019-03-18 Tom Tromey <tromey@adacore.com>
10614
10615 * ada-lang.c (empty_array): Add "high" parameter.
10616 (ada_evaluate_subexp): Update.
10617
10618 2019-03-17 Sergei Trofimovich <siarheit@google.com>
10619
10620 * unittests/string_view-selftests.c: Define
10621 _initialize_string_view_selftests unconditionally.
10622
10623 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10624
10625 PR gdb/24350
10626 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10627
10628 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10629
10630 PR gdb/24351
10631 * windows-nat.c (display_selector): Fix format specifiers.
10632
10633 2019-03-17 Eli Zaretskii <eliz@gnu.org>
10634
10635 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10636 tui_refill_source_window instead of tui_refresh_win, to update the
10637 current execution line. This fixes redisplay of the current line
10638 when stepping through the code with "next" or "step".
10639
10640 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10641
10642 * source-cache.c (source_cache::get_source_lines): Call
10643 find_source_lines to initialize s->nlines. This fixes vertical
10644 scrolling of TUI source window when the DOWN arrow is pressed.
10645
10646 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10647
10648 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10649 linux-thread-db.c (_initialize_thread_db): Likewise.
10650
10651 2019-03-16 Eli Zaretskii <eliz@gnu.org>
10652
10653 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10654 wclrtoeol in tui_show_source_line". This reverts changes made in
10655 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10656
10657 2019-03-15 Tom Tromey <tom@tromey.com>
10658
10659 * symtab.h (struct minimal_symbol): Derive from
10660 general_symbol_info.
10661 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10662 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10663 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10664 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10665 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10666 (MSYMBOL_SEARCH_NAME): Update.
10667 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10668 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10669 * minsyms.c (minimal_symbol_reader::record_full): Update.
10670
10671 2019-03-15 Tom Tromey <tom@tromey.com>
10672
10673 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10674
10675 2019-03-15 Tom Tromey <tom@tromey.com>
10676
10677 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10678 unique_xmalloc_ptr.
10679 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10680 Update.
10681 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10682 (build_minimal_symbol_hash_tables)
10683 (minimal_symbol_reader::install): Update.
10684
10685 2019-03-15 Tom Tromey <tom@tromey.com>
10686
10687 * symtab.c (create_demangled_names_hash): Update.
10688 (symbol_set_names): Update.
10689 * objfiles.h (struct objfile_per_bfd_storage)
10690 <demangled_names_hash>: Now an htab_up.
10691 * objfiles.c (objfile_per_bfd_storage): Simplify.
10692
10693 2019-03-15 Tom Tromey <tom@tromey.com>
10694
10695 * objfiles.h (struct objfile_per_bfd_storage): Declare
10696 destructor.
10697 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10698 New.
10699 (get_objfile_bfd_data): Use new. Don't initialize
10700 language_of_main.
10701 (free_objfile_per_bfd_storage): Remove.
10702 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10703
10704 2019-03-15 Tom Tromey <tom@tromey.com>
10705
10706 * symfile.c (reread_symbols): Update.
10707 * objfiles.c (objfile::objfile): Update.
10708 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10709 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10710 comment.
10711 (minimal_symbol_reader::install): Update.
10712 (terminate_minimal_symbol_table): Remove.
10713 * jit.c (jit_object_close_impl): Update.
10714
10715 2019-03-15 Tom Tromey <tom@tromey.com>
10716
10717 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10718 initializations.
10719
10720 2019-03-15 Tom Tromey <tom@tromey.com>
10721
10722 * objfiles.h (struct objfile_per_bfd_storage)
10723 <demangled_hash_languages>: Now a bitset.
10724 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10725 (lookup_minimal_symbol): Update.
10726
10727 2019-03-15 Tom Tromey <tom@tromey.com>
10728
10729 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10730 Don't return the symbol.
10731 * coffread.c (record_minimal_symbol): Use record_full.
10732
10733 2019-03-14 Eli Zaretskii <eliz@gnu.org>
10734
10735 The MS-Windows port of ncurses fails to switch to a color pair if
10736 one or both of the colors are the implicit default colors. This
10737 change records the default colors when TUI is initialized, and
10738 then specifies them explicitly when a color pair uses the default
10739 colors. This allows color styling in TUI mode on MS-Windows.
10740
10741 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10742 ncurses_norm_attr.
10743 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10744 colors in ncurses_norm_attr.
10745 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10746 "none", replace it with the default color recorded in
10747 ncurses_norm_attr.
10748
10749 2019-03-14 Tom Tromey <tromey@adacore.com>
10750
10751 * source-cache.h (class source_cache) <get_source_lines>: Return
10752 std::string.
10753 * source-cache.c (source_cache::extract_lines): Handle case where
10754 first_pos==npos. Return std::string.
10755 (source_cache::get_source_lines): Update.
10756
10757 2019-03-14 Tom Tromey <tromey@adacore.com>
10758
10759 * NEWS: Add item for "style sources" commands.
10760 * source-cache.c (source_cache::get_source_lines): Check
10761 source_styling.
10762 * cli/cli-style.c (source_styling): New global.
10763 (_initialize_cli_style): Add "style sources" commands.
10764 (show_style_sources): New function.
10765 * cli/cli-style.h (source_styling): Declare.
10766
10767 2019-03-14 Pedro Alves <palves@redhat.com>
10768 Tom Tromey <tromey@adacore.com>
10769
10770 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10771 * tui/tui-winsource.c (tui_refill_source_window): New function,
10772 from...
10773 (tui_horizontal_source_scroll): ... here. Move some logic.
10774 * cli/cli-style.c (set_style_enabled): Notify new observable.
10775 * tui/tui-hooks.c (tui_redisplay_source): New function.
10776 (tui_attach_detach_observers): Attach or detach
10777 tui_redisplay_source.
10778 * observable.h (source_styling_changed): New observable.
10779 * observable.c: Define source_styling_changed observable.
10780
10781 2019-03-13 Tom Tromey <tromey@adacore.com>
10782
10783 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10784 (i386_gnu_nat_target::store_registers): Update.
10785 * target-debug.h (target_debug_print_std_string): New macro.
10786 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10787 * windows-tdep.c (display_one_tib): Update.
10788 * tui/tui-stack.c (tui_make_status_line): Update.
10789 * top.c (print_inferior_quit_action): Update.
10790 * thread.c (thr_try_catch_cmd): Update.
10791 (add_thread_with_info): Update.
10792 (thread_target_id_str): Update.
10793 (thr_try_catch_cmd): Update.
10794 (thread_command): Update.
10795 (thread_find_command): Update.
10796 * record-btrace.c (record_btrace_target::info_record)
10797 (record_btrace_resume_thread, record_btrace_target::resume)
10798 (record_btrace_cancel_resume, record_btrace_step_thread)
10799 (record_btrace_target::wait, record_btrace_target::wait)
10800 (record_btrace_target::wait, record_btrace_target::stop): Update.
10801 * progspace.c (print_program_space): Update.
10802 * process-stratum-target.c
10803 (process_stratum_target::thread_address_space): Update.
10804 * linux-fork.c (linux_fork_mourn_inferior)
10805 (detach_checkpoint_command, info_checkpoints_command)
10806 (linux_fork_context): Update.
10807 (linux_fork_detach): Update.
10808 (class scoped_switch_fork_info): Update.
10809 (delete_checkpoint_command): Update.
10810 * infrun.c (follow_fork_inferior): Update.
10811 (follow_fork_inferior): Update.
10812 (proceed_after_vfork_done): Update.
10813 (handle_vfork_child_exec_or_exit): Update.
10814 (follow_exec): Update.
10815 (displaced_step_prepare_throw): Update.
10816 (displaced_step_restore): Update.
10817 (start_step_over): Update.
10818 (resume_1): Update.
10819 (clear_proceed_status_thread): Update.
10820 (proceed): Update.
10821 (print_target_wait_results): Update.
10822 (do_target_wait): Update.
10823 (context_switch): Update.
10824 (stop_all_threads): Update.
10825 (restart_threads): Update.
10826 (finish_step_over): Update.
10827 (handle_signal_stop): Update.
10828 (switch_back_to_stepped_thread): Update.
10829 (keep_going_pass_signal): Update.
10830 (print_exited_reason): Update.
10831 (normal_stop): Update.
10832 * inferior.c (inferior_pid_to_str): Change return type.
10833 (print_selected_inferior): Update.
10834 (add_inferior): Update.
10835 (detach_inferior): Update.
10836 * dummy-frame.c (fprint_dummy_frames): Update.
10837 * dcache.c (dcache_info_1): Update.
10838 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10839 (btrace_fetch, btrace_clear): Update.
10840 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10841 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10842 type.
10843 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10844 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10845 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10846 * gdbarch.c, gdbarch.h: Rebuild.
10847 * gdbarch.sh (core_pid_to_str): Change return type.
10848 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10849 return type.
10850 (windows_nat_target::pid_to_str): Change return type.
10851 (windows_delete_thread): Update.
10852 (windows_nat_target::attach): Update.
10853 (windows_nat_target::files_info): Update.
10854 * target-delegates.c: Rebuild.
10855 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10856 return type.
10857 (sol_thread_target::pid_to_str): Change return type.
10858 * remote.c (class remote_target) <pid_to_str>: Change return
10859 type.
10860 (remote_target::pid_to_str): Change return type.
10861 (extended_remote_target::attach, remote_target::remote_stop_ns)
10862 (remote_target::remote_notif_remove_queued_reply)
10863 (remote_target::push_stop_reply, remote_target::disable_btrace):
10864 Update.
10865 (extended_remote_target::attach): Update.
10866 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10867 type.
10868 (gdbsim_target::pid_to_str): Change return type.
10869 * ravenscar-thread.c (struct ravenscar_thread_target)
10870 <pid_to_str>: Change return type.
10871 (ravenscar_thread_target::pid_to_str): Change return type.
10872 * procfs.c (class procfs_target) <pid_to_str>: Change return
10873 type.
10874 (procfs_target::pid_to_str): Change return type.
10875 (procfs_target::attach): Update.
10876 (procfs_target::detach): Update.
10877 (procfs_target::fetch_registers): Update.
10878 (procfs_target::store_registers): Update.
10879 (procfs_target::wait): Update.
10880 (procfs_target::files_info): Update.
10881 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10882 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10883 return type.
10884 (nto_procfs_target::pid_to_str): Change return type.
10885 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10886 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10887 return type.
10888 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10889 (exit_lwp): Update.
10890 (attach_proc_task_lwp_callback, get_detach_signal)
10891 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10892 (linux_nat_target::resume, wait_lwp, stop_callback)
10893 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10894 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10895 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10896 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10897 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10898 type.
10899 (inf_ptrace_target::attach): Update.
10900 (inf_ptrace_target::files_info): Update.
10901 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10902 type.
10903 (go32_nat_target::pid_to_str): Change return type.
10904 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10905 (gnu_nat_target::wait): Update.
10906 (gnu_nat_target::wait): Update.
10907 (gnu_nat_target::resume): Update.
10908 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10909 (fbsd_nat_target::wait): Update.
10910 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10911 type.
10912 (darwin_nat_target::attach): Update.
10913 * corelow.c (class core_target) <pid_to_str>: Change return type.
10914 (core_target::pid_to_str): Change return type.
10915 * target.c (normal_pid_to_str): Change return type.
10916 (default_pid_to_str): Likewise.
10917 (target_pid_to_str): Change return type.
10918 (target_translate_tls_address): Update.
10919 (target_announce_detach): Update.
10920 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10921 return type.
10922 (bsd_uthread_target::pid_to_str): Change return type.
10923 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10924 type.
10925 (bsd_kvm_target::pid_to_str): Change return type.
10926 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10927 return type.
10928 (aix_thread_target::pid_to_str): Change return type.
10929 * target.h (struct target_ops) <pid_to_str>: Change return type.
10930 (target_pid_to_str, normal_pid_to_str): Likewise.
10931 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10932 type.
10933 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10934 type.
10935 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10936 return type.
10937 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10938 type.
10939 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10940 type.
10941 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10942 return type.
10943
10944 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10945
10946 * NEWS: Mention that the new default MI version is 3. Mention
10947 changes to the output of commands and events that deal with
10948 multi-location breakpoints.
10949 * breakpoint.c: Include "mi/mi-out.h".
10950 (print_one_breakpoint): Change output syntax if using MI version
10951 >= 3.
10952 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10953 New.
10954 (mi_multi_location_breakpoint_output_fixed): New.
10955 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10956 (mi_cmd_fix_multi_location_breakpoint_output): New.
10957 (mi_multi_location_breakpoint_output_fixed): New.
10958 * mi/mi-cmds.c (mi_cmds): Register command
10959 -fix-multi-location-breakpoint-output.
10960 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10961 interpreter "mi".
10962
10963 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10964
10965 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10966 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10967 instantiate mi_ui_out based on interpreter name.
10968 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10969 * mi/mi-main.c (mi_load_progress): Likewise.
10970
10971 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10972
10973 * NEWS: Combine separate "New targets" sections for 8.3.
10974
10975 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10976
10977 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10978 (ppcfbsd_init_abi): Install gdbarch
10979 "fetch_tls_load_module_address" and "get_thread_local_address"
10980 methods.
10981
10982 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10983
10984 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10985 (riscv_fbsd_init_abi): Install gdbarch
10986 "fetch_tls_load_module_address" and "get_thread_local_address"
10987 methods.
10988
10989 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10990
10991 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10992 (i386fbsd_init_abi): Install gdbarch
10993 "fetch_tls_load_module_address" and "get_thread_local_address"
10994 methods.
10995
10996 2019-03-12 John Baldwin <jhb@FreeBSD.org>
10997
10998 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10999 (amd64fbsd_init_abi): Install gdbarch
11000 "fetch_tls_load_module_address" and "get_thread_local_address"
11001 methods.
11002
11003 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11004
11005 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11006 (struct fbsd_pspace_data): New type.
11007 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11008 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11009 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11010 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11011 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11012
11013 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11014
11015 * gdbtypes.c (lookup_struct_elt): New function.
11016 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11017 * gdbtypes.h (struct struct_elt): New type.
11018 (lookup_struct_elt): New prototype.
11019
11020 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11021
11022 * gdbtypes.c (lookup_struct_elt_type): Update comment and
11023 remove disabled code block.
11024
11025 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11026
11027 * gdbarch.sh (get_thread_local_address): New method.
11028 * gdbarch.h, gdbarch.c: Regenerate.
11029 * target.c (target_translate_tls_address): Use
11030 gdbarch_get_thread_local_address if present instead of
11031 target::get_thread_local_address.
11032
11033 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11034
11035 * target.h (target::get_thread_local_address): Update comment.
11036
11037 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11038
11039 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11040 objfile->separate_debug_objfile_backlink if not NULL.
11041
11042 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11043
11044 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11045 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11046 (amd64bsd_store_inferior_registers): Likewise.
11047 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11048 Enable segment base registers.
11049 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11050 PT_GETFSBASE and PT_GETGSBASE.
11051 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11052 PT_SETGSBASE.
11053 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11054 segment base registers.
11055 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11056
11057 2019-03-12 John Baldwin <jhb@FreeBSD.org>
11058
11059 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11060 Update calls to i386_target_description to add 'segments'
11061 parameter.
11062 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
11063 add segment base registers.
11064 * arch/i386.c (i386_create_target_description): Add 'segments'
11065 parameter to enable segment base registers.
11066 * arch/i386.h (i386_create_target_description): Likewise.
11067 * features/i386/32bit-segments.xml: New file.
11068 * features/i386/32bit-segments.c: Generate.
11069 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11070 call to i386_target_description to add 'segments' parameter.
11071 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11072 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11073 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11074 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11075 if feature is present.
11076 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11077 Add 'segments' parameter to call to i386_target_description.
11078 (i386_target_description): Add 'segments' parameter to enable
11079 segment base registers.
11080 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11081 to call to i386_target_description.
11082 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11083 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11084 Define I386_NUM_REGS.
11085 (i386_target_description): Add 'segments' parameter to enable
11086 segment base registers.
11087
11088 2019-03-12 Eli Zaretskii <eliz@gnu.org>
11089
11090 PR/24325
11091 * source-cache.c: #undef open and close, to avoid unresolved
11092 externals during linking.
11093
11094 2019-03-12 Tom Tromey <tromey@adacore.com>
11095
11096 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11097 const. Add initializers.
11098 (_initialize_remote): Don't initialize ptid globals.
11099
11100 2019-03-12 Pedro Alves <palves@redhat.com>
11101
11102 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11103
11104 2019-03-12 Pedro Alves <palves@redhat.com>
11105
11106 * cp-name-parser.y (main): Remove unused 'len' variable.
11107
11108 2019-03-12 Tom Tromey <tromey@adacore.com>
11109
11110 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11111 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11112
11113 2019-03-12 Tom Tromey <tromey@adacore.com>
11114
11115 * linux-nat.c (iterate_over_lwps): Update.
11116 (stop_callback): Remove parameter.
11117 (stop_wait_callback, detach_callback, resume_set_callback)
11118 (select_singlestep_lwp_callback, set_ignore_sigint)
11119 (status_callback, resumed_callback, resume_clear_callback)
11120 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11121 data parameter.
11122 (linux_nat_target::detach, linux_nat_target::resume)
11123 (linux_stop_and_wait_all_lwps, select_event_lwp)
11124 (linux_nat_filter_event, linux_nat_wait_1)
11125 (linux_nat_target::kill, linux_nat_target::stop)
11126 (linux_nat_target::stop): Update.
11127 (linux_nat_resume_callback): Change type.
11128 (resume_stopped_resumed_lwps, count_events_callback)
11129 (select_event_lwp_callback): Likewise.
11130 (linux_stop_lwp, linux_nat_stop_lwp): Update.
11131 * arm-linux-nat.c (struct update_registers_data): Remove.
11132 (update_registers_callback): Change type.
11133 (arm_linux_insert_hw_breakpoint1): Update.
11134 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11135 parameter.
11136 (x86_linux_dr_set_addr): Update.
11137 (x86_linux_dr_set_control): Update.
11138 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11139 (iterate_over_lwps): Use gdb::function_view.
11140 * nat/aarch64-linux-hw-point.c (struct
11141 aarch64_dr_update_callback_param): Remove.
11142 (debug_reg_change_callback): Change type.
11143 (aarch64_notify_debug_reg_change): Update.
11144 * s390-linux-nat.c (s390_refresh_per_info): Update.
11145
11146 2019-03-11 Tom Tromey <tromey@adacore.com>
11147
11148 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11149 redundant assignment to "this_cu".
11150
11151 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11152
11153 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11154
11155 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11156
11157 * gdbtypes.c (rank_one_type_parm_set): New function extracted
11158 from...
11159 (rank_one_type): ... this.
11160
11161 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11162
11163 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11164 from...
11165 (rank_one_type): ... this.
11166
11167 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11168
11169 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11170 from...
11171 (rank_one_type): ... this.
11172
11173 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11174
11175 * gdbtypes.c (rank_one_type_parm_float): New function extracted
11176 from...
11177 (rank_one_type): ... this.
11178
11179 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11180
11181 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11182 from...
11183 (rank_one_type): ... this.
11184
11185 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11186
11187 * gdbtypes.c (rank_one_type_parm_range): New function extracted
11188 from...
11189 (rank_one_type): ... this.
11190
11191 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11192
11193 * gdbtypes.c (rank_one_type_parm_char): New function extracted
11194 from...
11195 (rank_one_type): ... this.
11196
11197 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11198
11199 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11200 from...
11201 (rank_one_type): ... this.
11202
11203 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11204
11205 * gdbtypes.c (rank_one_type_parm_int): New function extracted
11206 from...
11207 (rank_one_type): ... this.
11208
11209 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11210
11211 * gdbtypes.c (rank_one_type_parm_func): New function extracted
11212 from...
11213 (rank_one_type): ... this.
11214
11215 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11216
11217 * gdbtypes.c (rank_one_type_parm_array): New function extracted
11218 from...
11219 (rank_one_type): ... this.
11220
11221 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
11222
11223 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11224 from...
11225 (rank_one_type): ... this.
11226
11227 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11228
11229 * inferior.c (initialize_inferiors): Ensure 'help set/show print
11230 inferior-events' shows the example events.
11231
11232 2019-03-08 Eli Zaretskii <eliz@gnu.org>
11233
11234 Support styling on native MS-Windows console
11235
11236 PR/24315
11237 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11238 on MS-Windows if $TERM is not defined.
11239
11240 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11241
11242 * posix-hdep.c (gdb_console_fputs):
11243 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11244 functions.
11245 * ui-file.h (gdb_console_fputs): Add prototype.
11246
11247 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11248 back to fputs only if the former returns zero.
11249
11250 2019-03-07 Tom Tromey <tom@tromey.com>
11251
11252 * symmisc.c (print_symbol_bcache_statistics): Update.
11253 (print_objfile_statistics): Update.
11254 * symfile.c (allocate_symtab): Update.
11255 * stabsread.c: Don't include bcache.h.
11256 * psymtab.h (struct psymbol_bcache): Don't declare.
11257 (class psymtab_storage) <psymbol_cache>: Now a bcache.
11258 (psymbol_bcache_init, psymbol_bcache_free)
11259 (psymbol_bcache_get_bcache): Don't declare.
11260 * psymtab.c (struct psymbol_bcache): Remove.
11261 (psymtab_storage::psymtab_storage): Update.
11262 (psymtab_storage::~psymtab_storage): Update.
11263 (psymbol_bcache_init, psymbol_bcache_free)
11264 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11265 (add_psymbol_to_bcache): Update.
11266 (allocate_psymtab): Update.
11267 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11268 macro_cache>: No longer pointers.
11269 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11270 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11271 * macrotab.c (macro_bcache): Update.
11272 * macroexp.c: Don't include bcache.h.
11273 * gdbtypes.c (check_types_worklist): Update.
11274 (types_deeply_equal): Remove TRY/CATCH. Update.
11275 * elfread.c (elf_symtab_read): Update.
11276 * dwarf2read.c: Don't include bcache.h.
11277 * buildsym.c (buildsym_compunit::get_macro_table): Update.
11278 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11279 (print_bcache_statistics, bcache_memory_used): Don't declare.
11280 (struct bcache): Move from bcache.c. Add constructor, destructor,
11281 methods. Rename all data members.
11282 * bcache.c (struct bcache): Move to bcache.h.
11283 (bcache::expand_hash_table): Rename from expand_hash_table.
11284 (bcache): Remove.
11285 (bcache::insert): Rename from bcache_full.
11286 (bcache::compare): Rename from bcache_compare.
11287 (bcache_xmalloc): Remove.
11288 (bcache::~bcache): Rename from bcache_xfree.
11289 (bcache::print_statistics): Rename from print_bcache_statistics.
11290 (bcache::memory_used): Rename from bcache_memory_used.
11291
11292 2019-03-07 Pedro Alves <palves@redhat.com>
11293
11294 * infrun.c (normal_stop): Also check for
11295 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11296
11297 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
11298
11299 * f-lang.c (value_from_host_double): Moved to...
11300 * value.c (value_from_host_double): ...here.
11301 * value.h (value_from_host_double): Declare.
11302 * guile/scm-math.c (vlscm_convert_typed_number): Use
11303 value_from_host_double.
11304 (vlscm_convert_number): Likewise.
11305 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11306 * python/py-value.c (convert_value_from_python): Likewise.
11307
11308 2019-03-06 Tom Tromey <tom@tromey.com>
11309
11310 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11311
11312 2019-03-06 Tom Tromey <tom@tromey.com>
11313
11314 * utils.h (free_current_contents): Don't declare.
11315 * utils.c (free_current_contents): Remove.
11316
11317 2019-03-06 Tom Tromey <tom@tromey.com>
11318
11319 * top.c (quit_force): Update.
11320 * main.c (captured_command_loop): Update.
11321 * common/new-op.c (operator new): Update.
11322 * common/common-exceptions.c (struct catcher)
11323 <save_cleanup_chain>: Remove member.
11324 (exceptions_state_mc_init): Update.
11325 (exception_try_scope_entry): Return nullptr.
11326 (exception_try_scope_exit, exception_rethrow)
11327 (throw_exception_sjlj, throw_exception_cxx): Update.
11328 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11329 (all_cleanups, do_cleanups, discard_cleanups)
11330 (discard_final_cleanups, save_cleanups, save_final_cleanups)
11331 (restore_cleanups, restore_final_cleanups): Don't declare.
11332 (do_final_cleanups): Remove parameter.
11333 * common/cleanups.c (cleanup_chain, make_cleanup)
11334 (make_cleanup_dtor, all_cleanups, do_cleanups)
11335 (discard_my_cleanups, discard_cleanups)
11336 (discard_final_cleanups, save_my_cleanups, save_cleanups)
11337 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11338 (null_cleanup): Remove.
11339 (do_final_cleanups): Remove parameter.
11340
11341 2019-03-06 Tom Tromey <tom@tromey.com>
11342
11343 * remote.c (remote_target::remote_parse_stop_reply): Use
11344 unique_xmalloc_ptr.
11345
11346 2019-03-06 Tom Tromey <tom@tromey.com>
11347
11348 * stabsread.c (struct stabs_field_info): Rename from field_info.
11349 <list, fnlist>: Add initializers.
11350 <obstack>: New member.
11351 (read_member_functions, read_struct_fields, read_baseclasses):
11352 Allocate on obstack. Don't use cleanups.
11353 (read_one_struct_field, read_member_functions, read_struct_fields)
11354 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11355 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11356 (read_struct_type): Update.
11357
11358 2019-03-06 Tom Tromey <tom@tromey.com>
11359
11360 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11361 * common/filestuff.h (make_cleanup_close): Don't declare.
11362 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11363 Remove.
11364
11365 2019-03-06 Tom Tromey <tom@tromey.com>
11366
11367 * solib-aix.c: Use make_scope_exit.
11368
11369 2019-03-06 Tom Tromey <tom@tromey.com>
11370
11371 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11372 Use make_scope_exit.
11373
11374 2019-03-06 Tom Tromey <tom@tromey.com>
11375
11376 * solib-svr4.c (disable_probes_interface): Remove parameter.
11377 (svr4_handle_solib_event): Use make_scope_exit.
11378
11379 2019-03-06 Tom Tromey <tom@tromey.com>
11380
11381 * remote.c (struct stop_reply_deleter): Remove.
11382 (stop_reply_up): Update.
11383 (struct stop_reply): Derive from notif_event. Don't typedef.
11384 <regcache>: Now a std::vector.
11385 (stop_reply_xfree): Remove.
11386 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11387 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
11388 (remote_target::discard_pending_stop_replies): Use delete.
11389 (remote_target::remote_parse_stop_reply): Update.
11390 (remote_target::process_stop_reply): Update.
11391 * remote-notif.h (struct notif_event): Add virtual destructor.
11392 Remove "dtr" member.
11393 (struct notif_client) <alloc_event>: Return a unique_ptr.
11394 (notif_event_xfree): Don't declare.
11395 (notif_event_up): New typedef.
11396 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11397 (notif_event_xfree, do_notif_event_xfree): Remove.
11398 (remote_notif_state_xfree): Update.
11399
11400 2019-03-06 Tom Tromey <tom@tromey.com>
11401
11402 * infrun.c (displaced_step_clear_cleanup): Now a
11403 forward_scope_exit type.
11404 (displaced_step_prepare_throw): Update.
11405 (displaced_step_fixup): Update.
11406
11407 2019-03-06 Tom Tromey <tom@tromey.com>
11408
11409 * inferior.h (class inferior): Update comment.
11410 * gdbthread.h (class thread_info): Update comment.
11411
11412 2019-03-06 Joel Brobecker <brobecker@adacore.com>
11413 Tom Tromey <tom@tromey.com>
11414
11415 * stabsread.h (struct stab_section_list): Remove.
11416 (coffstab_build_psymtabs): Update.
11417 * dbxread.c (symbuf_sections): Now a std::vector.
11418 (sect_idx): New global.
11419 (fill_symbuf): Update.
11420 (coffstab_build_psymtabs): Change type of stabsects parameter.
11421 Update.
11422 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11423 std::vector.
11424 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11425 (coff_locate_sections): Update.
11426 (coff_symfile_read): Remove cleanups. Update.
11427 (init_stringtab): Add storage parameter.
11428 (free_stringtab, free_stringtab_cleanup): Remove.
11429 (init_lineno): Add storage parameter.
11430 (free_linetab, free_linetab_cleanup): Remove.
11431
11432 2019-03-06 Pedro Alves <palves@redhat.com>
11433
11434 * linux-fork.c (fork_info::clobber_regs): Delete.
11435 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11436 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
11437 comment. Adjust.
11438 (scoped_switch_fork_info::scoped_switch_fork_info)
11439 (checkpoint_command, linux_fork_context): Adjust
11440 fork_save_infrun_state calls.
11441
11442 2019-03-06 Pedro Alves <palves@redhat.com>
11443
11444 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11445 (inf_has_multiple_threads): Return 'bool' and rewrite using
11446 inferior_info::threads().
11447
11448 2019-03-06 Pedro Alves <palves@redhat.com>
11449
11450 * linux-fork.c: Include <list>.
11451 (fork_list): Now a std::list instance.
11452 (fork_info): Add ctor, dtor, and in-class initialize all fields.
11453 (forks_exist_p, find_last_fork): Adjust.
11454 (new_fork): Delete.
11455 (one_fork_p): New.
11456 (add_fork): Adjust.
11457 (free_fork): Delete, folded into fork_info::~fork_info().
11458 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11459 Adjust.
11460 (init_fork_list): Delete.
11461 (linux_fork_killall, linux_fork_mourn_inferior)
11462 (linux_fork_detach, info_checkpoints_command): Adjust.
11463 (_initialize_linux_fork): No longer call init_fork_list.
11464
11465 2019-03-06 Pedro Alves <palves@redhat.com>
11466
11467 * linux-fork.c (new_fork): New, split out of ...
11468 (add_fork): ... this. Return void. Move "first fork" special
11469 case from here, to ...
11470 (checkpoint_command): ... here.
11471 * linux-linux.h (add_fork): Return void.
11472
11473 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11474
11475 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11476
11477 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11478 Chris January <chris.january@arm.com>
11479 David Lecomber <david.lecomber@arm.com>
11480
11481 * f-exp.y: New token, UNOP_INTRINSIC.
11482 (exp): New pattern using UNOP_INTRINSIC token.
11483 (f77_keywords): Add 'abs' keyword.
11484 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11485 (value_from_host_double): New function.
11486 (evaluate_subexp_f): Support UNOP_ABS.
11487
11488 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11489
11490 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11491 types.
11492
11493 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11494
11495 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11496 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11497 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11498
11499 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11500
11501 * f-exp.y (convert_to_kind_type): Handle more type kinds.
11502
11503 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11504 Chris January <chris.january@arm.com>
11505
11506 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11507 * f-exp.y: Define 'KIND' token.
11508 (exp): New pattern for KIND expressions.
11509 (ptype): Handle types with a kind extension.
11510 (direct_abs_decl): Extend to spot kind extensions.
11511 (f77_keywords): Add 'kind' to the list.
11512 (push_kind_type): New function.
11513 (convert_to_kind_type): New function.
11514 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11515 * parse.c (operator_length_standard): Likewise.
11516 * parser-defs.h (enum type_pieces): Add tp_kind.
11517 * std-operator.def: Add UNOP_KIND.
11518
11519 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11520
11521 * f-exp.y (f_parse): Set yydebug.
11522
11523 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11524
11525 * f-lang.c (evaluate_subexp_f): New function.
11526 (exp_descriptor_f): New global.
11527 (f_language_defn): Use exp_descriptor_f instead of
11528 exp_descriptor_standard.
11529
11530 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11531
11532 * f-exp.y (struct token): Add comments.
11533 (dot_ops): Remove uppercase versions and the end marker.
11534 (f77_keywords): Likewise.
11535 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11536 entries in the dot_ops array are case insensitive, and use
11537 strncasecmp to compare strings. Also some whitespace cleanup in
11538 this area. Similar for the f77_keywords array, except entries in
11539 this list might be case sensitive.
11540
11541 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11542
11543 * f-exp.y (struct f77_boolean_val): Add comments.
11544 (boolean_values): Remove uppercase versions, and end marker.
11545 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11546 and use strncasecmp to achieve case insensitivity. Additionally,
11547 perform whitespace cleanup around this code.
11548
11549 2019-03-06 Tom Tromey <tromey@adacore.com>
11550
11551 * remote-sim.c (gdbsim_target_open): Use result of
11552 gdb_argv::release.
11553
11554 2019-03-06 Richard Bunt <richard.bunt@arm.com>
11555 Dirk Schubert <dirk.schubert@arm.com>
11556 Chris January <chris.january@arm.com>
11557
11558 * eval.c (evaluate_subexp_standard): Call Fortran argument
11559 wrapping logic.
11560 * f-lang.c (struct value): A value which can be passed into a
11561 Fortran function call.
11562 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11563 where appropriate.
11564 (struct type): Value ready for a Fortran function call.
11565 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11566 is needed.
11567 * f-lang.h (fortran_argument_convert): Declaration.
11568 (fortran_preserve_arg_pointer): Declaration.
11569 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11570
11571 2019-03-05 Tom Tromey <tromey@adacore.com>
11572
11573 * python/py-prettyprint.c (print_string_repr): Remove #if.
11574 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11575
11576 2019-03-05 Tom Tromey <tromey@adacore.com>
11577
11578 * target.c (the_dummy_target): Move later. Change type to
11579 "dummy_target".
11580 (initialize_targets): Don't initialize the_dummy_target.
11581
11582 2019-03-05 Tom Tromey <tromey@adacore.com>
11583
11584 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11585 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11586
11587 2019-03-05 Tom Tromey <tromey@adacore.com>
11588
11589 * windows-nat.c (windows_nat_target::attach)
11590 (windows_nat_target::detach): Don't call gdb_flush.
11591 * valprint.c (generic_val_print, val_print, val_print_string):
11592 Don't call gdb_flush.
11593 * utils.c (defaulted_query): Don't call gdb_flush.
11594 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11595 * target.c (target_announce_detach): Don't call gdb_flush.
11596 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11597 * remote.c (extended_remote_target::attach): Don't call
11598 gdb_flush.
11599 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11600 * printcmd.c (do_examine): Don't call gdb_flush.
11601 (info_display_command): Don't call gdb_flush.
11602 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11603 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11604 * memattr.c (info_mem_command): Don't call gdb_flush.
11605 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11606 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11607 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11608 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11609 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11610 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11611 (gnu_nat_target::detach): Don't call gdb_flush.
11612 * f-valprint.c (f_val_print): Don't call gdb_flush.
11613 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11614 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11615 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11616 gdb_flush.
11617 * c-valprint.c (c_val_print): Don't call gdb_flush.
11618 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11619
11620 2019-03-05 Tom Tromey <tromey@adacore.com>
11621
11622 * varobj.c (update_dynamic_varobj_children): Update.
11623 (install_default_visualizer): Use reset, not release.
11624 * value.c (set_internalvar): Update.
11625 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11626 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11627 ATTRIBUTE_UNUSED_RESULT.
11628
11629 2019-03-05 Tom Tromey <tromey@adacore.com>
11630
11631 * remote.c (class scoped_remote_fd) <release>: Add
11632 ATTRIBUTE_UNUSED_RESULT.
11633
11634 2019-03-05 Tom Tromey <tromey@adacore.com>
11635
11636 * macroexp.c (struct macro_buffer) <release>: Add
11637 ATTRIBUTE_UNUSED_RESULT.
11638
11639 2019-03-05 Tom Tromey <tromey@adacore.com>
11640
11641 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11642 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11643 ATTRIBUTE_UNUSED_RESULT.
11644
11645 2019-03-05 Tom Tromey <tromey@adacore.com>
11646
11647 * common/scoped_fd.h (class scoped_fd) <release>: Add
11648 ATTRIBUTE_UNUSED_RESULT.
11649
11650 2019-03-05 Tom Tromey <tromey@adacore.com>
11651
11652 * parser-defs.h (struct parser_state) <release>: Add
11653 ATTRIBUTE_UNUSED_RESULT.
11654
11655 2019-03-05 Tom Tromey <tromey@adacore.com>
11656
11657 * utils.h (class gdb_argv) <release>: Add
11658 ATTRIBUTE_UNUSED_RESULT.
11659 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11660
11661 2019-03-02 Eli Zaretskii <eliz@gnu.org>
11662
11663 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11664 for-loop range, to avoid compiler warnings.
11665
11666 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11667 avoid compiler warnings about unused variables.
11668
11669 * NEWS: Mention end of support for native debugging on MS-Windows
11670 before XP.
11671
11672 PR gdb/24292
11673 * common/netstuff.c:
11674 * gdbserver/gdbreplay.c
11675 * gdbserver/remote-utils.c:
11676 * ser-tcp.c:
11677 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11678 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11679 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11680 'getaddrinfo' and 'freeaddrinfo' were not available before
11681 Windows XP, and mingw.org's MinGW headers by default define
11682 _WIN32_WINNT to 0x500.
11683
11684 2019-03-01 Gary Benson <gbenson@redhat.com>
11685
11686 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11687
11688 2019-02-28 Brian Vandenberg <phantall@gmail.com>
11689 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11690
11691 PR gdb/8527
11692 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11693 set_sigint_trap, clear_sigint_trap.
11694
11695 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11696
11697 * target.c (target_detach): Clear the regcache and the
11698 frame cache.
11699
11700 2019-02-27 Pedro Alves <palves@redhat.com>
11701
11702 * utils.c (set_screen_size): When we cap the height/width sizes,
11703 tweak the corresponding command variable to show "unlimited":
11704
11705 2019-02-27 Saagar Jha <saagar@saagarjha.com>
11706 Pedro Alves <palves@redhat.com>
11707
11708 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11709 before calling rl_set_screen_size.
11710
11711 2019-02-27 Tom Tromey <tromey@adacore.com>
11712
11713 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11714 define.
11715 * python/py-value.c: Remove Python 2.4 workaround.
11716 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11717 workaround.
11718 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11719 Python 2.4 workaround.
11720 * python/python-internal.h: Remove Python 2.4 comment.
11721 (Py_ssize_t): Don't define.
11722 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11723 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11724 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11725 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11726 * python/python.c (do_start_initialization): Remove Python 2.4
11727 workaround.
11728 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11729 (print_children): Remove Python 2.4 workaround.
11730 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11731 workaround.
11732 (CHARBUFFERPROC_NAME): Remove.
11733 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11734 Python 2.4 workaround.
11735
11736 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11737
11738 * NEWS: Note minimum Python version.
11739
11740 2019-02-27 Kevin Buettner <kevinb@redhat.com>
11741
11742 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11743 code from these functions. Remove corresponding ifdefs. Use
11744 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11745 Remove gotos and target of gotos.
11746 (infpy_search_memory): Likewise.
11747
11748 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11749
11750 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11751 (hppa_gdbarch_init): Don't register deleted functions with
11752 gdbarch.
11753
11754 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11755
11756 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11757 (h8300_unwind_sp): Delete.
11758 (h8300_dummy_id): Delete.
11759 (h8300_gdbarch_init): Don't register deleted functions with
11760 gdbarch.
11761
11762 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11763
11764 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11765 (ft32_unwind_pc): Delete.
11766 (ft32_unwind_sp): Delete.
11767 (ft32_gdbarch_init): Don't register deleted functions with
11768 gdbarch.
11769
11770 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11771
11772 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11773 (frv_unwind_pc): Delete.
11774 (frv_unwind_sp): Delete.
11775 (frv_gdbarch_init): Don't register deleted functions with
11776 gdbarch.
11777
11778 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11779
11780 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11781 (riscv_unwind_pc): Delete.
11782 (riscv_unwind_sp): Delete.
11783 (riscv_gdbarch_init): Don't register deleted functions with
11784 gdbarch.
11785
11786 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11787
11788 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11789 (csky_unwind_pc): Delete.
11790 (csky_unwind_sp): Delete.
11791 (csky_gdbarch_init): Don't register deleted functions with
11792 gdbarch.
11793
11794 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11795
11796 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11797 (cris_unwind_pc): Delete.
11798 (cris_unwind_sp): Delete.
11799 (cris_gdbarch_init): Don't register deleted functions with
11800 gdbarch.
11801
11802 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11803
11804 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11805 (bfin_unwind_pc): Delete.
11806 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11807
11808 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11809
11810 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11811 (arm_unwind_pc): Delete.
11812 (arm_unwind_sp): Delete.
11813 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11814
11815 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11816
11817 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11818 (arc_unwind_pc): Delete.
11819 (arc_unwind_sp): Delete.
11820 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11821
11822 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11823
11824 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11825 (alpha_unwind_pc): Delete.
11826 (alpha_gdbarch_init): Don't register deleted functions with
11827 gdbarch.
11828
11829 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11830
11831 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11832 (aarch64_unwind_pc): Delete.
11833 (aarch64_unwind_sp): Delete.
11834 (aarch64_gdbarch_init): Don't register deleted functions with
11835 gdbarch.
11836
11837 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11838
11839 * gdbtypes.c (type_align): Don't consider static members when
11840 computing structure alignment.
11841
11842 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11843
11844 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11845 return 0 for other types.
11846 * arch-utils.c (default_type_align): Always return 0.
11847 * gdbarch.h: Regenerate.
11848 * gdbarch.sh (type_align): Extend comment.
11849 * gdbtypes.c (type_align): Add additional comments, always call
11850 gdbarch_type_align before applying the default rules.
11851 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11852 generic code will then apply a suitable default.
11853 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11854 types, return 0 for other types.
11855
11856 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11857
11858 * NEWS: Create a new section for the next release branch.
11859 Rename the section of the current branch, now that it has
11860 been cut.
11861
11862 2019-02-27 Joel Brobecker <brobecker@adacore.com>
11863
11864 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11865 * version.in: Bump version to 8.3.50.DATE-git.
11866
11867 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
11868
11869 * aix-thread.c (ptid_cmp): Remove unused variable.
11870 (get_signaled_thread): Likewise.
11871 (store_regs_user_thread): Likewise.
11872 (store_regs_kernel_thread): Likewise.
11873 (fetch_regs_kernel_thread): Remove shadowed variable.
11874
11875 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11876
11877 * features/riscv/32bit-cpu.xml: Add register numbers.
11878 * features/riscv/32bit-fpu.c: Regenerate.
11879 * features/riscv/32bit-fpu.xml: Add register numbers.
11880 * features/riscv/64bit-cpu.xml: Add register numbers.
11881 * features/riscv/64bit-fpu.c: Regenerate.
11882 * features/riscv/64bit-fpu.xml: Add register numbers.
11883
11884 2019-02-26 Kevin Buettner <kevinb@redhat.com>
11885
11886 * NEWS: Mention two argument form of gdb.Value constructor.
11887 * python/py-value.c (convert_buffer_and_type_to_value): New
11888 function.
11889 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11890 Add support for handling an optional second argument. Call
11891 convert_buffer_and_type_to_value as appropriate.
11892 * python/python-internal.h (Py_buffer_deleter): New struct.
11893 (Py_buffer_up): New typedef.
11894
11895 2019-02-25 John Baldwin <jhb@FreeBSD.org>
11896
11897 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11898 instead of releasing ownership.
11899
11900 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
11901
11902 * dwarf2read.c (open_and_init_dwp_file): Call
11903 elf_numsections instead of bfd_count_sections to initialize
11904 dwp_file->num_sections.
11905
11906 2019-02-25 Tom Tromey <tromey@adacore.com>
11907
11908 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11909
11910 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11911
11912 * gcore.in: Add '--readnever' option when invoking GDB.
11913
11914 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11915
11916 * MAINTAINERS: Update my email address.
11917
11918 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11919
11920 * build-id.c (build_id_to_debug_bfd_1): New function.
11921 (build_id_to_debug_bfd): Look for separate debug file in
11922 sysroot.
11923
11924 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11925
11926 * gdbarch.sh: Update the copyright year range that is placed into
11927 generated files.
11928
11929 2019-02-22 Keith Seitz <keiths@redhat.com>
11930
11931 PR symtab/23853
11932 * linespec.c (create_sals_line_offset): Search for the default
11933 symtab's filename instead of its fullname.
11934
11935 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11936
11937 * NEWS: Update style defaults.
11938
11939 2019-02-21 Alan Hayward <alan.hayward@arm.com>
11940
11941 * main.c (captured_main_1): Disable styling in batch mode.
11942
11943 2019-02-20 Tom Tromey <tom@tromey.com>
11944
11945 * symtab.c (symtab_symbol_info): Fix typos.
11946
11947 2019-02-20 Tom Tromey <tromey@adacore.com>
11948
11949 * findcmd.c (_initialize_mem_search): Use upper case for
11950 metasyntactic variables.
11951
11952 2019-02-20 Alan Hayward <alan.hayward@arm.com>
11953
11954 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11955 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11956
11957 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11958
11959 * top.h (source_file_name): Change to std::string.
11960 * top.c (source_file_name): Likewise.
11961 (command_line_input): Adjust.
11962 * cli/cli-script.c (script_from_file): Adjust.
11963
11964 2019-02-19 Tom Tromey <tromey@adacore.com>
11965
11966 * ravenscar-thread.c
11967 (ravenscar_thread_target::update_thread_list): Don't call
11968 ada_build_task_list.
11969 * ada-lang.h (ada_build_task_list): Don't declare.
11970 * ada-tasks.c (struct ada_tasks_inferior_data)
11971 <task_list_valid_p>: Now bool.
11972 (read_known_tasks, ada_task_list_changed)
11973 (ada_tasks_invalidate_inferior_data): Update.
11974 (read_known_tasks_array): Return bool.
11975 (read_known_tasks_list): Likewise.
11976 (read_known_tasks): Return void.
11977 (ada_build_task_list): Now static.
11978
11979 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11980
11981 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11982 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11983
11984 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11985
11986 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11987 variant for ada_tasks_pspace_data_handle and
11988 ada_tasks_inferior_data_handle.
11989 (ada_tasks_pspace_data_cleanup): New function.
11990 (ada_tasks_inferior_data_cleanup): New function.
11991
11992 2019-02-17 Tom Tromey <tom@tromey.com>
11993
11994 * macrotab.h (macro_source_fullname): Return a std::string.
11995 * macrotab.c (macro_include, check_for_redefinition)
11996 (macro_undef, macro_lookup_definition, foreach_macro)
11997 (foreach_macro_in_scope): Update.
11998 (macro_source_fullname): Return a std::string.
11999 * macrocmd.c (show_pp_source_pos): Update.
12000
12001 2019-02-17 Tom Tromey <tom@tromey.com>
12002
12003 * macrocmd.c (show_pp_source_pos): Style the file names.
12004
12005 2019-02-17 Tom Tromey <tom@tromey.com>
12006
12007 PR tui/24197:
12008 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12009
12010 2019-02-17 Tom Tromey <tom@tromey.com>
12011
12012 * ada-lang.c (user_select_syms): Use filtered printing.
12013 * utils.c (wrap_style): New global.
12014 (desired_style): Remove.
12015 (emit_style_escape): Add stream parameter.
12016 (set_output_style, reset_terminal_style, prompt_for_continue):
12017 Update.
12018 (flush_wrap_buffer): Only flush gdb_stdout.
12019 (wrap_here): Set wrap_style.
12020 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
12021 treat escape sequences as a character. Change when wrap buffer is
12022 flushed.
12023 (fputs_styled): Do not set the output style when the default is
12024 requested.
12025 * ui-style.h (struct ui_file_style) <is_default>: New method.
12026 * source.c (print_source_lines_base): Emit escape sequences in one
12027 piece.
12028
12029 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12030
12031 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12032 integers and enumeration types.
12033
12034 2019-02-17 Joel Brobecker <brobecker@adacore.com>
12035
12036 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12037 instead of lookup_symbol_in_language
12038 (do_exact_match): New function.
12039 (ada_get_symbol_name_matcher): Return do_exact_match when
12040 doing a verbatim match.
12041
12042 2019-02-15 Tom Tromey <tromey@adacore.com>
12043
12044 * ravenscar-thread.c (ravenscar_thread_target::resume)
12045 (ravenscar_thread_target::wait): Special case wildcard requests.
12046
12047 2019-02-15 Tom Tromey <tromey@adacore.com>
12048
12049 * ravenscar-thread.c (base_ptid): Remove.
12050 (struct ravenscar_thread_target) <close>: New method.
12051 <m_base_ptid>: New member.
12052 <update_inferior_ptid, active_task, task_is_currently_active,
12053 runtime_initialized>: Declare methods.
12054 <ravenscar_thread_target>: Add constructor.
12055 (ravenscar_thread_target::task_is_currently_active)
12056 (ravenscar_thread_target::update_inferior_ptid)
12057 (ravenscar_runtime_initialized): Rename. Now methods.
12058 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12059 (ravenscar_thread_target::update_thread_list): Update.
12060 (ravenscar_thread_target::active_task): Now method.
12061 (ravenscar_thread_target::store_registers)
12062 (ravenscar_thread_target::prepare_to_store)
12063 (ravenscar_thread_target::prepare_to_store)
12064 (ravenscar_thread_target::mourn_inferior): Update.
12065 (ravenscar_inferior_created): Use "new" to create target.
12066 (ravenscar_thread_target::get_ada_task_ptid): Update.
12067 (_initialize_ravenscar): Don't initialize base_ptid.
12068 (ravenscar_ops): Remove global.
12069
12070 2019-02-15 Tom Tromey <tromey@adacore.com>
12071
12072 * target.h (push_target): Declare new overload.
12073 * target.c (push_target): New overload, taking an rvalue reference.
12074 * remote.c (remote_target::open_1): Use push_target overload.
12075 * corelow.c (core_target_open): Use push_target overload.
12076
12077 2019-02-15 Tom Tromey <tromey@adacore.com>
12078
12079 * ravenscar-thread.c (is_ravenscar_task)
12080 (ravenscar_task_is_currently_active): Return bool.
12081 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12082 (_initialize_ravenscar): Remove "(void)".
12083 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12084 Return bool.
12085
12086 2019-02-15 Tom Tromey <tromey@adacore.com>
12087
12088 * ravenscar-thread.c (ravenscar_runtime_initializer)
12089 (has_ravenscar_runtime, get_running_thread_id)
12090 (ravenscar_thread_target::resume): Fix indentation.
12091
12092 2019-02-15 Tom Tromey <tromey@adacore.com>
12093
12094 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12095 from ravenscar_arch_ops.
12096 (sparc_ravenscar_ops::fetch_registers)
12097 (sparc_ravenscar_ops::store_registers): Now methods.
12098 (sparc_ravenscar_prepare_to_store): Remove.
12099 (sparc_ravenscar_ops): Redefine.
12100 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12101 methods and destructor. Remove members.
12102 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12103 (ravenscar_thread_target::store_registers)
12104 (ravenscar_thread_target::prepare_to_store): Update.
12105 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12106 Remove.
12107 (struct ppc_ravenscar_powerpc_ops): Derive from
12108 ravenscar_arch_ops.
12109 (ppc_ravenscar_powerpc_ops::fetch_registers)
12110 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12111 (ppc_ravenscar_powerpc_ops): Redefine.
12112 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12113 (ppc_ravenscar_e500_ops::fetch_registers)
12114 (ppc_ravenscar_e500_ops::store_registers): Now methods.
12115 (ppc_ravenscar_e500_ops): Redefine.
12116 * aarch64-ravenscar-thread.c
12117 (aarch64_ravenscar_generic_prepare_to_store): Remove.
12118 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12119 (aarch64_ravenscar_fetch_registers)
12120 (aarch64_ravenscar_store_registers): Now methods.
12121 (aarch64_ravenscar_ops): Redefine.
12122
12123 2019-02-15 Tom Tromey <tromey@adacore.com>
12124
12125 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12126 (ravenscar_thread_target::stopped_by_hw_breakpoint)
12127 (ravenscar_thread_target::stopped_by_watchpoint)
12128 (ravenscar_thread_target::stopped_data_address)
12129 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12130
12131 2019-02-15 Tom Tromey <tromey@adacore.com>
12132
12133 * ravenscar-thread.c: Fix some typos.
12134
12135 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12136 Tom Tromey <tromey@adacore.com>
12137
12138 * ada-lang.c (ada_exception_sal): Change addr_string to a
12139 std::string.
12140 (create_ada_exception_catchpoint): Update.
12141
12142 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12143 Tom Tromey <tromey@adacore.com>
12144
12145 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12146 (bp_location_ops): Remove.
12147 (base_breakpoint_allocate_location): Update.
12148 (free_bp_location): Update.
12149 * ada-lang.c (class ada_catchpoint_location)
12150 <ada_catchpoint_location>: Remove ops parameter.
12151 (ada_catchpoint_location_dtor): Remove.
12152 (ada_catchpoint_location_ops): Remove.
12153 (allocate_location_exception): Update.
12154 * breakpoint.h (struct bp_location_ops): Remove.
12155 (class bp_location) <bp_location>: Remove bp_location_ops
12156 parameter.
12157 <~bp_location>: Add destructor.
12158 <ops>: Remove.
12159
12160 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12161 Pedro Alves <palves@redhat.com>
12162
12163 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12164 'PATH_MAX'.
12165
12166 2019-02-14 David Michael <fedora.dm0@gmail.com>
12167 Samuel Thibault <samuel.thibault@gnu.org>
12168 Thomas Schwinge <thomas@codesourcery.com>
12169
12170 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12171 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12172
12173 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
12174
12175 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12176 (check_empty): Use "const char *".
12177
12178 * gnu-nat.c (gnu_nat_target::detach): Instead of
12179 'detach_inferior (pid)' call
12180 'detach_inferior (find_inferior_pid (pid))'.
12181
12182 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12183 'nat/fork-inferior.o'.
12184 * gnu-nat.c: #include "nat/fork-inferior.h".
12185
12186 * gnu-nat.c (gnu_nat_target::detach): Instead of
12187 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12188 * gnu-nat.h: #include "inf-child.h".
12189 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12190 'i386_gnu_nat_target::fetch_registers'.
12191 (gnu_store_registers): Rename/move to
12192 'i386_gnu_nat_target::store_registers'.
12193
12194 * config/i386/nm-i386gnu.h: Don't "#include" any files.
12195 * gnu-nat.h (mach_thread_info): New function.
12196 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12197
12198 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12199
12200 2019-02-14 Frederic Konrad <konrad@adacore.com>
12201
12202 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12203
12204 2019-02-14 Joel Brobecker <brobecker@adacore.com>
12205
12206 * windows-nat.c (windows_add_thread): Add new parameter
12207 "main_thread_p" with default value set to false. Update
12208 function documentation as well as all callers.
12209 (windows_delete_thread): Likewise.
12210 (fake_create_process): Update call to windows_add_thread.
12211 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12212 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12213 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12214 call to windows_delete_thread.
12215
12216 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
12217
12218 * MAINTAINERS: Add Andrew Burgess as global maintainer.
12219
12220 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12221
12222 * symfile.c (find_separate_debug_file): Use canonical path of
12223 sysroot with child_path instead of gdb_sysroot if it is valid.
12224
12225 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12226
12227 * symfile.c (find_separate_debug_file): Use child_path to
12228 determine if an object file is under a sysroot.
12229
12230 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12231
12232 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12233 unittests/child-path-selftests.c.
12234 * common/pathstuff.c (child_path): New function.
12235 * common/pathstuff.h (child_path): New prototype.
12236 * unittests/child-path-selftests.c: New file.
12237
12238 2019-02-12 John Baldwin <jhb@FreeBSD.org>
12239
12240 * symfile.c (find_separate_debug_file): Look for separate debug
12241 files in debug directories under the sysroot.
12242
12243 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12244
12245 * symtab.h (struct minimal_symbol data_p): New const method.
12246 (struct minimal_symbol text_p): Likewise.
12247 * symtab.c (output_source_filename): Use file name style
12248 to print file name.
12249 (print_symbol_info): Likewise.
12250 (print_msymbol_info): Use address style to print addresses.
12251 Use function name style to print executable text symbols.
12252 (expand_symtab_containing_pc): Use data_p.
12253 (find_pc_sect_compunit_symtab): Likewise.
12254
12255 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12256
12257 * breakpoint.c (describe_other_breakpoints): Use address style
12258 to print addresses.
12259 (say_where): Likewise.
12260
12261 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12262
12263 * ada-typeprint.c (print_func_type): Print function name
12264 style to print function name.
12265 * c-typeprint.c (c_print_type_1): Likewise.
12266
12267 2019-02-11 Alan Hayward <alan.hayward@arm.com>
12268
12269 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12270 for execve.
12271
12272 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12273
12274 * c-exp.y (direct_abs_decl): Use emplace_back to record the
12275 type_stack.
12276
12277 2019-02-10 Joel Brobecker <brobecker@adacore.com>
12278
12279 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12280 TYPE_CODE_REF types.
12281
12282 2019-02-08 Jim Wilson <jimw@sifive.com>
12283
12284 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12285 (riscv_linux_fregset): New.
12286 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12287
12288 2019-02-07 Tom Tromey <tom@tromey.com>
12289
12290 * thread.c (thread_cancel_execution_command): Update.
12291 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12292 methods.
12293 (struct thread_fsm_ops): Remove.
12294 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12295 (thread_fsm_should_stop, thread_fsm_return_value)
12296 (thread_fsm_set_finished, thread_fsm_finished_p)
12297 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12298 Don't declare.
12299 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12300 * infrun.c (clear_proceed_status_thread)
12301 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12302 (print_stop_event): Update.
12303 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12304 Add constructor.
12305 (step_command_fsm_ops): Remove.
12306 (new_step_command_fsm): Remove.
12307 (step_1): Update.
12308 (step_command_fsm::should_stop): Rename from
12309 step_command_fsm_should_stop.
12310 (step_command_fsm::clean_up): Rename from
12311 step_command_fsm_clean_up.
12312 (step_command_fsm::do_async_reply_reason): Rename from
12313 step_command_fsm_async_reply_reason.
12314 (struct until_next_fsm): Inherit from thread_fsm. Add
12315 constructor.
12316 (until_next_fsm_ops): Remove.
12317 (new_until_next_fsm): Remove.
12318 (until_next_fsm::should_stop): Rename from
12319 until_next_fsm_should_stop.
12320 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12321 (until_next_fsm::do_async_reply_reason): Rename from
12322 until_next_fsm_async_reply_reason.
12323 (struct finish_command_fsm): Inherit from thread_fsm. Add
12324 constructor. Change type of breakpoint.
12325 (finish_command_fsm_ops): Remove.
12326 (new_finish_command_fsm): Remove.
12327 (finish_command_fsm::should_stop): Rename from
12328 finish_command_fsm_should_stop.
12329 (finish_command_fsm::clean_up): Rename from
12330 finish_command_fsm_clean_up.
12331 (finish_command_fsm::return_value): Rename from
12332 finish_command_fsm_return_value.
12333 (finish_command_fsm::do_async_reply_reason): Rename from
12334 finish_command_fsm_async_reply_reason.
12335 (finish_command): Update.
12336 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12337 Add constructor.
12338 (call_thread_fsm_ops): Remove.
12339 (call_thread_fsm::call_thread_fsm): Rename from
12340 new_call_thread_fsm.
12341 (call_thread_fsm::should_stop): Rename from
12342 call_thread_fsm_should_stop.
12343 (call_thread_fsm::should_notify_stop): Rename from
12344 call_thread_fsm_should_notify_stop.
12345 (run_inferior_call, call_function_by_hand_dummy): Update.
12346 * cli/cli-interp.c (should_print_stop_to_console): Update.
12347 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12348 Add constructor. Change type of location_breakpoint,
12349 caller_breakpoint.
12350 (until_break_fsm_ops): Remove.
12351 (new_until_break_fsm): Remove.
12352 (until_break_fsm::should_stop): Rename from
12353 until_break_fsm_should_stop.
12354 (until_break_fsm::clean_up): Rename from
12355 until_break_fsm_clean_up.
12356 (until_break_fsm::do_async_reply_reason): Rename from
12357 until_break_fsm_async_reply_reason.
12358 (until_break_command): Update.
12359 * thread-fsm.c: Remove.
12360 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12361
12362 2019-02-07 Tom Tromey <tom@tromey.com>
12363
12364 * yy-remap.h: Add include guard.
12365 * xtensa-tdep.h: Add include guard.
12366 * xcoffread.h: Rename include guard.
12367 * varobj-iter.h: Add include guard.
12368 * tui/tui.h: Rename include guard.
12369 * tui/tui-winsource.h: Rename include guard.
12370 * tui/tui-wingeneral.h: Rename include guard.
12371 * tui/tui-windata.h: Rename include guard.
12372 * tui/tui-win.h: Rename include guard.
12373 * tui/tui-stack.h: Rename include guard.
12374 * tui/tui-source.h: Rename include guard.
12375 * tui/tui-regs.h: Rename include guard.
12376 * tui/tui-out.h: Rename include guard.
12377 * tui/tui-layout.h: Rename include guard.
12378 * tui/tui-io.h: Rename include guard.
12379 * tui/tui-hooks.h: Rename include guard.
12380 * tui/tui-file.h: Rename include guard.
12381 * tui/tui-disasm.h: Rename include guard.
12382 * tui/tui-data.h: Rename include guard.
12383 * tui/tui-command.h: Rename include guard.
12384 * tic6x-tdep.h: Add include guard.
12385 * target/waitstatus.h: Rename include guard.
12386 * target/wait.h: Rename include guard.
12387 * target/target.h: Rename include guard.
12388 * target/resume.h: Rename include guard.
12389 * target-float.h: Rename include guard.
12390 * stabsread.h: Add include guard.
12391 * rs6000-tdep.h: Add include guard.
12392 * riscv-fbsd-tdep.h: Add include guard.
12393 * regformats/regdef.h: Rename include guard.
12394 * record.h: Rename include guard.
12395 * python/python.h: Rename include guard.
12396 * python/python-internal.h: Rename include guard.
12397 * python/py-stopevent.h: Rename include guard.
12398 * python/py-ref.h: Rename include guard.
12399 * python/py-record.h: Rename include guard.
12400 * python/py-record-full.h: Rename include guard.
12401 * python/py-record-btrace.h: Rename include guard.
12402 * python/py-instruction.h: Rename include guard.
12403 * python/py-events.h: Rename include guard.
12404 * python/py-event.h: Rename include guard.
12405 * procfs.h: Add include guard.
12406 * proc-utils.h: Add include guard.
12407 * p-lang.h: Add include guard.
12408 * or1k-tdep.h: Rename include guard.
12409 * observable.h: Rename include guard.
12410 * nto-tdep.h: Rename include guard.
12411 * nat/x86-linux.h: Rename include guard.
12412 * nat/x86-linux-dregs.h: Rename include guard.
12413 * nat/x86-gcc-cpuid.h: Add include guard.
12414 * nat/x86-dregs.h: Rename include guard.
12415 * nat/x86-cpuid.h: Rename include guard.
12416 * nat/ppc-linux.h: Rename include guard.
12417 * nat/mips-linux-watch.h: Rename include guard.
12418 * nat/linux-waitpid.h: Rename include guard.
12419 * nat/linux-ptrace.h: Rename include guard.
12420 * nat/linux-procfs.h: Rename include guard.
12421 * nat/linux-osdata.h: Rename include guard.
12422 * nat/linux-nat.h: Rename include guard.
12423 * nat/linux-namespaces.h: Rename include guard.
12424 * nat/linux-btrace.h: Rename include guard.
12425 * nat/glibc_thread_db.h: Rename include guard.
12426 * nat/gdb_thread_db.h: Rename include guard.
12427 * nat/gdb_ptrace.h: Rename include guard.
12428 * nat/fork-inferior.h: Rename include guard.
12429 * nat/amd64-linux-siginfo.h: Rename include guard.
12430 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12431 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12432 * nat/aarch64-linux.h: Rename include guard.
12433 * nat/aarch64-linux-hw-point.h: Rename include guard.
12434 * mn10300-tdep.h: Add include guard.
12435 * mips-linux-tdep.h: Add include guard.
12436 * mi/mi-parse.h: Rename include guard.
12437 * mi/mi-out.h: Rename include guard.
12438 * mi/mi-main.h: Rename include guard.
12439 * mi/mi-interp.h: Rename include guard.
12440 * mi/mi-getopt.h: Rename include guard.
12441 * mi/mi-console.h: Rename include guard.
12442 * mi/mi-common.h: Rename include guard.
12443 * mi/mi-cmds.h: Rename include guard.
12444 * mi/mi-cmd-break.h: Rename include guard.
12445 * m2-lang.h: Add include guard.
12446 * location.h: Rename include guard.
12447 * linux-record.h: Rename include guard.
12448 * linux-nat.h: Add include guard.
12449 * linux-fork.h: Add include guard.
12450 * i386-darwin-tdep.h: Rename include guard.
12451 * hppa-linux-offsets.h: Add include guard.
12452 * guile/guile.h: Rename include guard.
12453 * guile/guile-internal.h: Rename include guard.
12454 * gnu-nat.h: Rename include guard.
12455 * gdb-stabs.h: Rename include guard.
12456 * frv-tdep.h: Add include guard.
12457 * f-lang.h: Add include guard.
12458 * event-loop.h: Add include guard.
12459 * darwin-nat.h: Rename include guard.
12460 * cp-abi.h: Rename include guard.
12461 * config/sparc/nm-sol2.h: Rename include guard.
12462 * config/nm-nto.h: Rename include guard.
12463 * config/nm-linux.h: Add include guard.
12464 * config/i386/nm-i386gnu.h: Rename include guard.
12465 * config/djgpp/nl_types.h: Rename include guard.
12466 * config/djgpp/langinfo.h: Rename include guard.
12467 * compile/gcc-cp-plugin.h: Add include guard.
12468 * compile/gcc-c-plugin.h: Add include guard.
12469 * compile/compile.h: Rename include guard.
12470 * compile/compile-object-run.h: Rename include guard.
12471 * compile/compile-object-load.h: Rename include guard.
12472 * compile/compile-internal.h: Rename include guard.
12473 * compile/compile-cplus.h: Rename include guard.
12474 * compile/compile-c.h: Rename include guard.
12475 * common/xml-utils.h: Rename include guard.
12476 * common/x86-xstate.h: Rename include guard.
12477 * common/version.h: Rename include guard.
12478 * common/vec.h: Rename include guard.
12479 * common/tdesc.h: Rename include guard.
12480 * common/selftest.h: Rename include guard.
12481 * common/scoped_restore.h: Rename include guard.
12482 * common/scoped_mmap.h: Rename include guard.
12483 * common/scoped_fd.h: Rename include guard.
12484 * common/safe-iterator.h: Rename include guard.
12485 * common/run-time-clock.h: Rename include guard.
12486 * common/refcounted-object.h: Rename include guard.
12487 * common/queue.h: Rename include guard.
12488 * common/ptid.h: Rename include guard.
12489 * common/print-utils.h: Rename include guard.
12490 * common/preprocessor.h: Rename include guard.
12491 * common/pathstuff.h: Rename include guard.
12492 * common/observable.h: Rename include guard.
12493 * common/netstuff.h: Rename include guard.
12494 * common/job-control.h: Rename include guard.
12495 * common/host-defs.h: Rename include guard.
12496 * common/gdb_wait.h: Rename include guard.
12497 * common/gdb_vecs.h: Rename include guard.
12498 * common/gdb_unlinker.h: Rename include guard.
12499 * common/gdb_unique_ptr.h: Rename include guard.
12500 * common/gdb_tilde_expand.h: Rename include guard.
12501 * common/gdb_sys_time.h: Rename include guard.
12502 * common/gdb_string_view.h: Rename include guard.
12503 * common/gdb_splay_tree.h: Rename include guard.
12504 * common/gdb_setjmp.h: Rename include guard.
12505 * common/gdb_ref_ptr.h: Rename include guard.
12506 * common/gdb_optional.h: Rename include guard.
12507 * common/gdb_locale.h: Rename include guard.
12508 * common/gdb_assert.h: Rename include guard.
12509 * common/filtered-iterator.h: Rename include guard.
12510 * common/filestuff.h: Rename include guard.
12511 * common/fileio.h: Rename include guard.
12512 * common/environ.h: Rename include guard.
12513 * common/common-utils.h: Rename include guard.
12514 * common/common-types.h: Rename include guard.
12515 * common/common-regcache.h: Rename include guard.
12516 * common/common-inferior.h: Rename include guard.
12517 * common/common-gdbthread.h: Rename include guard.
12518 * common/common-exceptions.h: Rename include guard.
12519 * common/common-defs.h: Rename include guard.
12520 * common/common-debug.h: Rename include guard.
12521 * common/cleanups.h: Rename include guard.
12522 * common/buffer.h: Rename include guard.
12523 * common/btrace-common.h: Rename include guard.
12524 * common/break-common.h: Rename include guard.
12525 * cli/cli-utils.h: Rename include guard.
12526 * cli/cli-style.h: Rename include guard.
12527 * cli/cli-setshow.h: Rename include guard.
12528 * cli/cli-script.h: Rename include guard.
12529 * cli/cli-interp.h: Rename include guard.
12530 * cli/cli-decode.h: Rename include guard.
12531 * cli/cli-cmds.h: Rename include guard.
12532 * charset-list.h: Add include guard.
12533 * buildsym-legacy.h: Rename include guard.
12534 * bfin-tdep.h: Add include guard.
12535 * ax.h: Rename include guard.
12536 * arm-linux-tdep.h: Add include guard.
12537 * arm-fbsd-tdep.h: Add include guard.
12538 * arch/xtensa.h: Rename include guard.
12539 * arch/tic6x.h: Add include guard.
12540 * arch/i386.h: Add include guard.
12541 * arch/arm.h: Rename include guard.
12542 * arch/arm-linux.h: Rename include guard.
12543 * arch/arm-get-next-pcs.h: Rename include guard.
12544 * arch/amd64.h: Add include guard.
12545 * arch/aarch64-insn.h: Rename include guard.
12546 * arch-utils.h: Rename include guard.
12547 * annotate.h: Add include guard.
12548 * amd64-darwin-tdep.h: Rename include guard.
12549 * aarch64-linux-tdep.h: Add include guard.
12550 * aarch64-fbsd-tdep.h: Add include guard.
12551 * aarch32-linux-nat.h: Add include guard.
12552
12553 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12554
12555 * macrotab.c (macro_define_internal): New function that
12556 factorizes macro_define_object_internal and macro_define_function
12557 code.
12558 (macro_define_object_internal): Use macro_define_internal.
12559 (macro_define_function): Likewise.
12560
12561 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12562
12563 * macrocmd.c (extract_identifier): Return
12564 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12565 callers.
12566
12567 2019-02-06 John Baldwin <jhb@FreeBSD.org>
12568
12569 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12570
12571 2019-02-05 Tom Tromey <tom@tromey.com>
12572
12573 * target.c (target_stack::unpush): Move assertion earlier.
12574
12575 2019-01-30 Tom Tromey <tom@tromey.com>
12576
12577 PR python/23615:
12578 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12579 (gdbpy_parse_and_eval): Likewise.
12580 * python/python-internal.h (gdbpy_allow_threads): New class.
12581
12582 2019-01-28 John Baldwin <jhb@FreeBSD.org>
12583
12584 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12585 (aarch64_fbsd_fpregmap): Move earlier.
12586 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12587 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12588 instead of individual calls to trad_frame_set_reg_addr.
12589 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12590 earlier.
12591 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12592 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12593 instead of individual calls to trad_frame_set_reg_addr.
12594
12595 2019-01-28 Alan Hayward <alan.hayward@arm.com>
12596
12597 * CONTRIBUTE: Replace contribution list with wiki link.
12598
12599 2019-01-25 Tom Tromey <tom@tromey.com>
12600
12601 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12602
12603 2019-01-25 Tom Tromey <tom@tromey.com>
12604
12605 * xtensa-linux-nat.c: Fix common/ includes.
12606 * xml-support.h: Fix common/ includes.
12607 * xml-support.c: Fix common/ includes.
12608 * x86-linux-nat.c: Fix common/ includes.
12609 * windows-nat.c: Fix common/ includes.
12610 * varobj.h: Fix common/ includes.
12611 * varobj.c: Fix common/ includes.
12612 * value.c: Fix common/ includes.
12613 * valops.c: Fix common/ includes.
12614 * utils.c: Fix common/ includes.
12615 * unittests/xml-utils-selftests.c: Fix common/ includes.
12616 * unittests/utils-selftests.c: Fix common/ includes.
12617 * unittests/unpack-selftests.c: Fix common/ includes.
12618 * unittests/tracepoint-selftests.c: Fix common/ includes.
12619 * unittests/style-selftests.c: Fix common/ includes.
12620 * unittests/string_view-selftests.c: Fix common/ includes.
12621 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12622 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12623 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12624 * unittests/rsp-low-selftests.c: Fix common/ includes.
12625 * unittests/parse-connection-spec-selftests.c: Fix common/
12626 includes.
12627 * unittests/optional-selftests.c: Fix common/ includes.
12628 * unittests/offset-type-selftests.c: Fix common/ includes.
12629 * unittests/observable-selftests.c: Fix common/ includes.
12630 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12631 * unittests/memrange-selftests.c: Fix common/ includes.
12632 * unittests/memory-map-selftests.c: Fix common/ includes.
12633 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12634 * unittests/function-view-selftests.c: Fix common/ includes.
12635 * unittests/environ-selftests.c: Fix common/ includes.
12636 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12637 * unittests/common-utils-selftests.c: Fix common/ includes.
12638 * unittests/cli-utils-selftests.c: Fix common/ includes.
12639 * unittests/array-view-selftests.c: Fix common/ includes.
12640 * ui-file.c: Fix common/ includes.
12641 * tui/tui-io.c: Fix common/ includes.
12642 * tracepoint.h: Fix common/ includes.
12643 * tracepoint.c: Fix common/ includes.
12644 * tracefile-tfile.c: Fix common/ includes.
12645 * top.h: Fix common/ includes.
12646 * top.c: Fix common/ includes.
12647 * thread.c: Fix common/ includes.
12648 * target/waitstatus.h: Fix common/ includes.
12649 * target/waitstatus.c: Fix common/ includes.
12650 * target.h: Fix common/ includes.
12651 * target.c: Fix common/ includes.
12652 * target-memory.c: Fix common/ includes.
12653 * target-descriptions.c: Fix common/ includes.
12654 * symtab.h: Fix common/ includes.
12655 * symfile.c: Fix common/ includes.
12656 * stap-probe.c: Fix common/ includes.
12657 * spu-linux-nat.c: Fix common/ includes.
12658 * sparc-nat.c: Fix common/ includes.
12659 * source.c: Fix common/ includes.
12660 * solib.c: Fix common/ includes.
12661 * solib-target.c: Fix common/ includes.
12662 * ser-unix.c: Fix common/ includes.
12663 * ser-tcp.c: Fix common/ includes.
12664 * ser-pipe.c: Fix common/ includes.
12665 * ser-base.c: Fix common/ includes.
12666 * selftest-arch.c: Fix common/ includes.
12667 * s12z-tdep.c: Fix common/ includes.
12668 * rust-exp.y: Fix common/ includes.
12669 * rs6000-aix-tdep.c: Fix common/ includes.
12670 * riscv-tdep.c: Fix common/ includes.
12671 * remote.c: Fix common/ includes.
12672 * remote-notif.h: Fix common/ includes.
12673 * remote-fileio.h: Fix common/ includes.
12674 * remote-fileio.c: Fix common/ includes.
12675 * regcache.h: Fix common/ includes.
12676 * regcache.c: Fix common/ includes.
12677 * record-btrace.c: Fix common/ includes.
12678 * python/python.c: Fix common/ includes.
12679 * python/py-type.c: Fix common/ includes.
12680 * python/py-inferior.c: Fix common/ includes.
12681 * progspace.h: Fix common/ includes.
12682 * producer.c: Fix common/ includes.
12683 * procfs.c: Fix common/ includes.
12684 * proc-api.c: Fix common/ includes.
12685 * printcmd.c: Fix common/ includes.
12686 * ppc-linux-nat.c: Fix common/ includes.
12687 * parser-defs.h: Fix common/ includes.
12688 * osdata.c: Fix common/ includes.
12689 * obsd-nat.c: Fix common/ includes.
12690 * nat/x86-linux.c: Fix common/ includes.
12691 * nat/x86-linux-dregs.c: Fix common/ includes.
12692 * nat/x86-dregs.h: Fix common/ includes.
12693 * nat/x86-dregs.c: Fix common/ includes.
12694 * nat/ppc-linux.c: Fix common/ includes.
12695 * nat/mips-linux-watch.h: Fix common/ includes.
12696 * nat/mips-linux-watch.c: Fix common/ includes.
12697 * nat/linux-waitpid.c: Fix common/ includes.
12698 * nat/linux-ptrace.h: Fix common/ includes.
12699 * nat/linux-ptrace.c: Fix common/ includes.
12700 * nat/linux-procfs.c: Fix common/ includes.
12701 * nat/linux-personality.c: Fix common/ includes.
12702 * nat/linux-osdata.c: Fix common/ includes.
12703 * nat/linux-namespaces.c: Fix common/ includes.
12704 * nat/linux-btrace.h: Fix common/ includes.
12705 * nat/linux-btrace.c: Fix common/ includes.
12706 * nat/fork-inferior.c: Fix common/ includes.
12707 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12708 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12709 * nat/aarch64-linux.c: Fix common/ includes.
12710 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12711 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12712 * namespace.h: Fix common/ includes.
12713 * mips-linux-tdep.c: Fix common/ includes.
12714 * minsyms.c: Fix common/ includes.
12715 * mi/mi-parse.h: Fix common/ includes.
12716 * mi/mi-main.c: Fix common/ includes.
12717 * mi/mi-cmd-env.c: Fix common/ includes.
12718 * memrange.h: Fix common/ includes.
12719 * memattr.c: Fix common/ includes.
12720 * maint.h: Fix common/ includes.
12721 * maint.c: Fix common/ includes.
12722 * main.c: Fix common/ includes.
12723 * machoread.c: Fix common/ includes.
12724 * location.c: Fix common/ includes.
12725 * linux-thread-db.c: Fix common/ includes.
12726 * linux-nat.c: Fix common/ includes.
12727 * linux-fork.c: Fix common/ includes.
12728 * inline-frame.c: Fix common/ includes.
12729 * infrun.c: Fix common/ includes.
12730 * inflow.c: Fix common/ includes.
12731 * inferior.h: Fix common/ includes.
12732 * inferior.c: Fix common/ includes.
12733 * infcmd.c: Fix common/ includes.
12734 * inf-ptrace.c: Fix common/ includes.
12735 * inf-child.c: Fix common/ includes.
12736 * ia64-linux-nat.c: Fix common/ includes.
12737 * i387-tdep.c: Fix common/ includes.
12738 * i386-tdep.c: Fix common/ includes.
12739 * i386-linux-tdep.c: Fix common/ includes.
12740 * i386-linux-nat.c: Fix common/ includes.
12741 * i386-go32-tdep.c: Fix common/ includes.
12742 * i386-fbsd-tdep.c: Fix common/ includes.
12743 * i386-fbsd-nat.c: Fix common/ includes.
12744 * guile/scm-type.c: Fix common/ includes.
12745 * guile/guile.c: Fix common/ includes.
12746 * go32-nat.c: Fix common/ includes.
12747 * gnu-nat.c: Fix common/ includes.
12748 * gdbthread.h: Fix common/ includes.
12749 * gdbarch-selftests.c: Fix common/ includes.
12750 * gdb_usleep.c: Fix common/ includes.
12751 * gdb_select.h: Fix common/ includes.
12752 * gdb_bfd.c: Fix common/ includes.
12753 * gcore.c: Fix common/ includes.
12754 * fork-child.c: Fix common/ includes.
12755 * findvar.c: Fix common/ includes.
12756 * fbsd-nat.c: Fix common/ includes.
12757 * event-top.c: Fix common/ includes.
12758 * event-loop.c: Fix common/ includes.
12759 * dwarf2read.c: Fix common/ includes.
12760 * dwarf2loc.c: Fix common/ includes.
12761 * dwarf2-frame.c: Fix common/ includes.
12762 * dwarf-index-cache.c: Fix common/ includes.
12763 * dtrace-probe.c: Fix common/ includes.
12764 * disasm-selftests.c: Fix common/ includes.
12765 * defs.h: Fix common/ includes.
12766 * csky-tdep.c: Fix common/ includes.
12767 * cp-valprint.c: Fix common/ includes.
12768 * cp-support.h: Fix common/ includes.
12769 * cp-support.c: Fix common/ includes.
12770 * corelow.c: Fix common/ includes.
12771 * completer.h: Fix common/ includes.
12772 * completer.c: Fix common/ includes.
12773 * compile/compile.c: Fix common/ includes.
12774 * compile/compile-loc2c.c: Fix common/ includes.
12775 * compile/compile-cplus-types.c: Fix common/ includes.
12776 * compile/compile-cplus-symbols.c: Fix common/ includes.
12777 * command.h: Fix common/ includes.
12778 * cli/cli-dump.c: Fix common/ includes.
12779 * cli/cli-cmds.c: Fix common/ includes.
12780 * charset.c: Fix common/ includes.
12781 * build-id.c: Fix common/ includes.
12782 * btrace.h: Fix common/ includes.
12783 * btrace.c: Fix common/ includes.
12784 * breakpoint.h: Fix common/ includes.
12785 * breakpoint.c: Fix common/ includes.
12786 * ax.h:
12787 (enum agent_op): Fix common/ includes.
12788 * ax-general.c (struct aop_map): Fix common/ includes.
12789 * ax-gdb.c: Fix common/ includes.
12790 * auxv.c: Fix common/ includes.
12791 * auto-load.c: Fix common/ includes.
12792 * arm-tdep.c: Fix common/ includes.
12793 * arch/riscv.c: Fix common/ includes.
12794 * arch/ppc-linux-common.c: Fix common/ includes.
12795 * arch/i386.c: Fix common/ includes.
12796 * arch/arm.c: Fix common/ includes.
12797 * arch/arm-linux.c: Fix common/ includes.
12798 * arch/arm-get-next-pcs.c: Fix common/ includes.
12799 * arch/amd64.c: Fix common/ includes.
12800 * arch/aarch64.c: Fix common/ includes.
12801 * arch/aarch64-insn.c: Fix common/ includes.
12802 * arch-utils.c: Fix common/ includes.
12803 * amd64-windows-tdep.c: Fix common/ includes.
12804 * amd64-tdep.c: Fix common/ includes.
12805 * amd64-sol2-tdep.c: Fix common/ includes.
12806 * amd64-obsd-tdep.c: Fix common/ includes.
12807 * amd64-nbsd-tdep.c: Fix common/ includes.
12808 * amd64-linux-tdep.c: Fix common/ includes.
12809 * amd64-linux-nat.c: Fix common/ includes.
12810 * amd64-fbsd-tdep.c: Fix common/ includes.
12811 * amd64-fbsd-nat.c: Fix common/ includes.
12812 * amd64-dicos-tdep.c: Fix common/ includes.
12813 * amd64-darwin-tdep.c: Fix common/ includes.
12814 * agent.c: Fix common/ includes.
12815 * ada-lang.h: Fix common/ includes.
12816 * ada-lang.c: Fix common/ includes.
12817 * aarch64-tdep.c: Fix common/ includes.
12818
12819 2019-01-25 Tom Tromey <tom@tromey.com>
12820
12821 * common/create-version.sh: Use common/version.h.
12822
12823 2019-01-24 Pedro Alves <palves@redhat.com>
12824
12825 * infrun.c (signal_stop, signal_print, signal_program)
12826 (signal_catch, signal_pass): Now arrays instead of pointers.
12827 (update_signals_program_target, do_target_resume)
12828 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12829 * linux-nat.c (linux_nat_target::pass_signals)
12830 (linux_nat_target::create_inferior, linux_nat_target::attach):
12831 Adjust.
12832 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12833 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12834 * procfs.c (procfs_target::pass_signals): Adjust.
12835 * record-full.c (record_full_target::resume): Adjust.
12836 * remote.c (remote_target::pass_signals)
12837 (remote_target::program_signals): Adjust.
12838 * target-debug.h (target_debug_print_signals): Now takes a
12839 gdb::array_view as parameter. Adjust.
12840 * target.h (target_ops) <pass_signals, program_signals>: Replace
12841 pointer and length parameters with gdb::array_view.
12842 (target_pass_signals, target_program_signals): Likewise.
12843 * target-delegates.c: Regenerate.
12844
12845 2019-01-24 Pedro Alves <palves@redhat.com>
12846
12847 * common/forward-scope-exit.h
12848 (forward_scope_exit::forward_scope_exit): Pass arguments to
12849 m_bind_function directly, instead of creating a std::bind and
12850 copying that.
12851
12852 2019-01-24 Alan Hayward <alan.hayward@arm.com>
12853
12854 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12855 for static members.
12856 (pass_in_v_vfp_candidate): Likewise.
12857
12858 2019-01-23 Tom Tromey <tom@tromey.com>
12859 Pedro Alves <palves@redhat.com>
12860
12861 * regcache.c (class regcache_invalidator): Remove.
12862 (regcache::raw_write): Use make_scope_exit.
12863
12864 2019-01-23 Tom Tromey <tom@tromey.com>
12865
12866 * ui-out.h (class ui_out_emit_type): Update comment.
12867
12868 2019-01-23 Tom Tromey <tom@tromey.com>
12869
12870 * infrun.c (fetch_inferior_event): Update comment.
12871
12872 2019-01-23 Tom Tromey <tom@tromey.com>
12873 Pedro Alves <palves@redhat.com>
12874
12875 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12876 parameter.
12877 (fetch_inferior_event): Use SCOPE_EXIT.
12878
12879
12880 2019-01-23 Tom Tromey <tom@tromey.com>
12881 Pedro Alves <palves@redhat.com>
12882
12883 * infrun.c (disable_thread_events): Delete.
12884 (stop_all_threads): Use SCOPE_EXIT.
12885
12886 2019-01-23 Tom Tromey <tom@tromey.com>
12887 Pedro Alves <palves@redhat.com>
12888
12889 * symfile.c: Include forward-scope-exit.h.
12890 (clear_symtab_users_cleanup): Replace forward declaration with
12891 a FORWARD_SCOPE_EXIT.
12892 (syms_from_objfile_1): Use the forward_scope_exit and
12893 gdb::optional instead of cleanup_function.
12894 (reread_symbols): Use the forward_scope_exit instead of
12895 cleanup_function.
12896 (clear_symtab_users_cleanup): Remove function.
12897
12898 2019-01-23 Tom Tromey <tom@tromey.com>
12899 Pedro Alves <palves@redhat.com>
12900
12901 * linux-nat.c: Include scope-exit.h.
12902 (cleanup_target_stop): Remove.
12903 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12904 SCOPE_EXIT.
12905
12906 2019-01-23 Tom Tromey <tom@tromey.com>
12907 Pedro Alves <palves@redhat.com>
12908
12909 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12910 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12911
12912 2019-01-23 Tom Tromey <tom@tromey.com>
12913 Andrew Burgess <andrew.burgess@embecosm.com>
12914 Pedro Alves <palves@redhat.com>
12915
12916 * infrun.c (fetch_inferior_event): Use scope_exit.
12917 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12918 * top.c (execute_command): Use scope_exit.
12919 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12920 * utils.c (do_bpstat_clear_actions_cleanup)
12921 (make_bpstat_clear_actions_cleanup): Remove.
12922
12923 2019-01-23 Tom Tromey <tom@tromey.com>
12924 Pedro Alves <palves@redhat.com>
12925
12926 * infrun.c: Include "common/scope-exit.h"
12927 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12928 (wait_for_inferior): Use SCOPE_EXIT.
12929 (fetch_inferior_event): Use scope_exit.
12930
12931 2019-01-23 Tom Tromey <tom@tromey.com>
12932 Pedro Alves <palves@redhat.com>
12933
12934 * breakpoint.c (create_breakpoint): Remove cleanup.
12935
12936 2019-01-23 Tom Tromey <tom@tromey.com>
12937 Andrew Burgess <andrew.burgess@embecosm.com>
12938 Pedro Alves <palves@redhat.com>
12939
12940 2019-01-23 Pedro Alves <palves@redhat.com>
12941
12942 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12943
12944 2019-01-23 Pedro Alves <palves@redhat.com>
12945 Andrew Burgess <andrew.burgess@embecosm.com>
12946
12947 * gdbthread.h: Include "common/forward-scope-exit.h".
12948 (scoped_finish_thread_state): Redefine custom class in terms of
12949 forward_scope_exit.
12950
12951 2019-01-23 Pedro Alves <palves@redhat.com>
12952 Andrew Burgess <andrew.burgess@embecosm.com>
12953
12954 * common/forward-scope-exit.h: New file.
12955
12956 2019-01-23 Pedro Alves <palves@redhat.com>
12957 Andrew Burgess <andrew.burgess@embecosm.com>
12958 Tom Tromey <tom@tromey.com>
12959
12960 * common/scope-exit.h: New file.
12961
12962 2019-01-23 Pedro Alves <palves@redhat.com>
12963
12964 * common/preprocessor.h (ESC): Rename to ...
12965 (ESC_PARENS): ... this.
12966 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12967 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12968
12969 2019-01-23 Tom Tromey <tom@tromey.com>
12970
12971 * language.h (class scoped_switch_to_sym_language_if_auto):
12972 Initialize m_lang in both cases.
12973
12974 2019-01-23 Alan Hayward <alan.hayward@arm.com>
12975
12976 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12977 with XCNEW.
12978
12979 2019-01-22 Tom Tromey <tom@tromey.com>
12980
12981 * corelow.c: Do not include sys/file.h.
12982
12983 2019-01-22 Tom Tromey <tom@tromey.com>
12984
12985 * tui/tui-wingeneral.h: Include gdb_curses.h.
12986
12987 2019-01-22 Tom Tromey <tom@tromey.com>
12988
12989 * source-cache.h (class source_cache) <get_source_lines,
12990 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12991
12992 2019-01-22 Tom Tromey <tom@tromey.com>
12993
12994 * remote-fileio.h (struct remote_target): Declare.
12995
12996 2019-01-22 Tom Tromey <tom@tromey.com>
12997
12998 * python/py-arch.c: Do not include py-ref.h.
12999 * python/py-bpevent.c: Do not include py-ref.h.
13000 * python/py-cmd.c: Do not include py-ref.h.
13001 * python/py-continueevent.c: Do not include py-ref.h.
13002 * python/py-event.h: Do not include py-ref.h.
13003 * python/py-evtregistry.c: Do not include py-ref.h.
13004 * python/py-finishbreakpoint.c: Do not include py-ref.h.
13005 * python/py-frame.c: Do not include py-ref.h.
13006 * python/py-framefilter.c: Do not include py-ref.h.
13007 * python/py-function.c: Do not include py-ref.h.
13008 * python/py-infevents.c: Do not include py-ref.h.
13009 * python/py-linetable.c: Do not include py-ref.h.
13010 * python/py-objfile.c: Do not include py-ref.h.
13011 * python/py-param.c: Do not include py-ref.h.
13012 * python/py-prettyprint.c: Do not include py-ref.h.
13013 * python/py-progspace.c: Do not include py-ref.h.
13014 * python/py-symbol.c: Do not include py-ref.h.
13015 * python/py-symtab.c: Do not include py-ref.h.
13016 * python/py-type.c: Do not include py-ref.h.
13017 * python/py-unwind.c: Do not include py-ref.h.
13018 * python/py-utils.c: Do not include py-ref.h.
13019 * python/py-value.c: Do not include py-ref.h.
13020 * python/py-varobj.c: Do not include py-ref.h.
13021 * python/py-xmethods.c: Do not include py-ref.h.
13022 * python/python.c: Do not include py-ref.h.
13023 * varobj.c: Do not include py-ref.h.
13024
13025 2019-01-22 Tom Tromey <tom@tromey.com>
13026
13027 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13028 keyword for bcache.
13029
13030 2019-01-22 Tom Tromey <tom@tromey.com>
13031
13032 * compile/compile-cplus-types.c: Remove a comment by #include.
13033
13034 2019-01-22 Tom Tromey <tom@tromey.com>
13035
13036 * compile/gcc-c-plugin.h: Include compile-internal.h.
13037
13038 2019-01-22 Tom Tromey <tom@tromey.com>
13039
13040 * stabsread.c (EXTERN): Do not define.
13041 (symnum, next_symbol_text_func, processing_gcc_compilation)
13042 (within_function, global_sym_chain, global_stabs)
13043 (previous_stab_code, this_object_header_files)
13044 (n_this_object_header_files)
13045 (n_allocated_this_object_header_files): Define.
13046 * stabsread.h (EXTERN): Never define. Use "extern".
13047
13048 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13049
13050 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13051 history_value.
13052
13053 2019-01-21 Tom Tromey <tom@tromey.com>
13054
13055 * ui-out.c: Fix includes.
13056 * tui/tui-source.c: Fix includes.
13057 * target.c: Fix includes.
13058 * remote.c: Fix includes.
13059 * regcache.c: Fix includes.
13060 * python/py-block.c: Fix includes.
13061 * printcmd.c: Fix includes.
13062 * or1k-tdep.c: Fix includes.
13063 * mi/mi-main.c: Fix includes.
13064 * m32r-tdep.c: Fix includes.
13065 * csky-tdep.c: Fix includes.
13066 * compile/compile-cplus-types.c: Fix includes.
13067 * cli/cli-interp.c: Fix includes.
13068
13069 2019-01-21 Alan Hayward <alan.hayward@arm.com>
13070
13071 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13072 for padding.
13073
13074 2019-01-16 Tom Tromey <tom@tromey.com>
13075
13076 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
13077 earlier.
13078 (struct objfile) <msymbols_range>: Move from top level.
13079 <msymbols>: New method.
13080 (class objfile_msymbols): Remove.
13081 * symtab.c (default_collect_symbol_completion_matches_break_on):
13082 Update.
13083 * symmisc.c (dump_msymbols): Update.
13084 * stabsread.c (scan_file_globals): Update.
13085 * objc-lang.c (info_selectors_command, info_classes_command)
13086 (find_methods): Update.
13087 * minsyms.c (find_solib_trampoline_target): Update.
13088 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13089 * coffread.c (coff_symfile_read): Update.
13090 * ada-lang.c (ada_lookup_simple_minsym)
13091 (ada_collect_symbol_completion_matches): Update.
13092
13093 2019-01-16 Tom Tromey <tom@tromey.com>
13094
13095 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13096 type. Remove no-argument constructor.
13097 <iterator::operator++>: Simplify.
13098 <begin>: Update.
13099 <end>: Use minimal_symbol_count.
13100
13101 2019-01-16 Tom Tromey <tom@tromey.com>
13102
13103 * objfiles.h (struct objfile) <psymtabs>: New method.
13104 (class objfile_psymtabs): Remove.
13105 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13106 typedef.
13107 <range>: New method.
13108 (require_partial_symbols): Change return type.
13109 * psymtab.c (require_partial_symbols)
13110 (psym_expand_symtabs_matching): Update.
13111 * mdebugread.c (parse_partial_symbols): Update.
13112 * dbxread.c (dbx_end_psymtab): Update.
13113
13114 2019-01-15 Tom Tromey <tom@tromey.com>
13115
13116 * symtab.c (lookup_objfile_from_block)
13117 (lookup_symbol_in_objfile_symtabs)
13118 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13119 (find_line_symtab, info_sources_command)
13120 (default_collect_symbol_completion_matches_break_on)
13121 (make_source_files_completion_list): Update.
13122 * symmisc.c (print_objfile_statistics, dump_objfile)
13123 (maintenance_print_symbols, maintenance_info_symtabs)
13124 (maintenance_check_symtabs, maintenance_info_line_tables):
13125 Update.
13126 * source.c (select_source_symtab)
13127 (forget_cached_source_info_for_objfile): Update.
13128 * objfiles.h (class objfile_compunits): Remove.
13129 (struct objfile) <compunits_range>: New typedef.
13130 (compunits): New method.
13131 * objfiles.c (objfile_relocate1): Update.
13132 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13133 * maint.c (count_symtabs_and_blocks): Update.
13134 * linespec.c (iterate_over_all_matching_symtabs): Update.
13135 * cp-support.c (add_symbol_overload_list_qualified): Update.
13136 * coffread.c (coff_symtab_read): Update.
13137 * ada-lang.c (add_nonlocal_symbols)
13138 (ada_collect_symbol_completion_matches)
13139 (ada_add_global_exceptions): Update.
13140
13141 2019-01-15 Tom Tromey <tom@tromey.com>
13142
13143 * progspace.h (program_space) <objfiles_safe_range>: New
13144 typedef.
13145 <objfiles_safe>: New method.
13146 * objfiles.h (class all_objfiles_safe): Remove.
13147 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13148 * jit.c (jit_inferior_exit_hook): Update.
13149
13150 2019-01-17 Tom Tromey <tom@tromey.com>
13151
13152 * progspace.h (program_space) <objfiles_range>: New typedef.
13153 <objfiles>: New method.
13154 <objfiles_head>: Rename from objfiles.
13155 (object_files): Update.
13156 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13157 * guile/scm-pretty-print.c
13158 (ppscm_find_pretty_printer_from_objfiles): Update.
13159 * guile/scm-objfile.c (gdbscm_objfiles): Update.
13160 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13161 Update.
13162 * python/py-progspace.c (pspy_get_objfiles): Update.
13163 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13164 Update.
13165 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13166 (objfpy_lookup_objfile_by_build_id): Update.
13167 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13168 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13169 Update.
13170 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13171 (expand_symtab_containing_pc, lookup_objfile_from_block)
13172 (lookup_static_symbol, basic_lookup_transparent_type)
13173 (find_pc_sect_compunit_symtab, find_symbol_at_address)
13174 (find_line_symtab, info_sources_command)
13175 (default_collect_symbol_completion_matches_break_on)
13176 (make_source_files_completion_list, find_main_name): Update.
13177 * symmisc.c (print_symbol_bcache_statistics)
13178 (print_objfile_statistics, maintenance_print_symbols)
13179 (maintenance_print_msymbols, maintenance_print_objfiles)
13180 (maintenance_info_symtabs, maintenance_check_symtabs)
13181 (maintenance_expand_symtabs, maintenance_info_line_tables):
13182 Update.
13183 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13184 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13185 (map_overlay_command, unmap_overlay_command)
13186 (simple_overlay_update, expand_symtabs_matching)
13187 (map_symbol_filenames): Update.
13188 * symfile-debug.c (set_debug_symfile): Update.
13189 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13190 Update.
13191 * source.c (select_source_symtab, forget_cached_source_info):
13192 Update.
13193 * solib.c (solib_read_symbols): Update.
13194 * solib-spu.c (append_ocl_sos): Update.
13195 * psymtab.c (maintenance_print_psymbols)
13196 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13197 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13198 * printcmd.c (info_symbol_command): Update.
13199 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13200 Update.
13201 * objfiles.h (class all_objfiles): Remove.
13202 * objfiles.c (have_partial_symbols, have_full_symbols)
13203 (have_minimal_symbols, qsort_cmp, update_section_map)
13204 (shared_objfile_contains_address_p)
13205 (default_iterate_over_objfiles_in_search_order): Update.
13206 * objc-lang.c (info_selectors_command, info_classes_command)
13207 (find_methods): Update.
13208 * minsyms.c (find_solib_trampoline_target): Update.
13209 * maint.c (maintenance_info_sections)
13210 (maintenance_translate_address, count_symtabs_and_blocks):
13211 Update.
13212 * main.c (captured_main_1): Update.
13213 * linux-thread-db.c (try_thread_db_load_from_pdir)
13214 (has_libpthread): Update.
13215 * linespec.c (iterate_over_all_matching_symtabs)
13216 (search_minsyms_for_name): Update.
13217 * jit.c (jit_find_objf_with_entry_addr): Update.
13218 * hppa-tdep.c (find_unwind_entry)
13219 (hppa_lookup_stub_minimal_symbol): Update.
13220 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13221 Update.
13222 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13223 (elf_gnu_ifunc_resolve_by_got): Update.
13224 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13225 * dwarf-index-write.c (save_gdb_index_command): Update.
13226 * cp-support.c (add_symbol_overload_list_qualified): Update.
13227 * breakpoint.c (create_overlay_event_breakpoint)
13228 (create_longjmp_master_breakpoint)
13229 (create_std_terminate_master_breakpoint)
13230 (create_exception_master_breakpoint): Update.
13231 * blockframe.c (find_pc_partial_function): Update.
13232 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13233 (ada_collect_symbol_completion_matches)
13234 (ada_add_global_exceptions): Update.
13235
13236 2019-01-17 Tom Tromey <tom@tromey.com>
13237
13238 * solib-target.c (lm_info_target_p): Remove typedef. Don't
13239 declare VEC.
13240 (solib_target_parse_libraries): Change return type.
13241 (library_list_start_segment, library_list_start_section)
13242 (library_list_end_library, library_list_start_library); Update.
13243 (solib_target_free_library_list): Remove.
13244 (solib_target_parse_libraries): Remove cleanup. Change return
13245 type.
13246 (solib_target_current_sos): Update.
13247
13248 2019-01-17 Tom Tromey <tromey@bapiya>
13249
13250 * valprint.c: Replace "the the" with "the".
13251 * symtab.c: Replace "the the" with "the".
13252 * solib.c: Replace "the the" with "the".
13253 * solib-dsbt.c: Replace "the the" with "the".
13254 * linespec.c: Replace "the the" with "the".
13255 * dwarf2loc.h: Replace "the the" with "the".
13256 * amd64-windows-tdep.c: Replace "the the" with "the".
13257 * aarch64-tdep.c: Replace "the the" with "the".
13258
13259 2019-01-16 Keith Seitz <keiths@redhat.com>
13260
13261 PR gdb/23773
13262 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13263 <builder>: Rename to ..
13264 <m_builder>: ... this and make private.
13265 (dwarf2_cu::get_builder): New method. Change all users of
13266 `builder' to use this method.
13267 (dwarf2_start_symtab): Move to ...
13268 (dwarf2_cu::start_symtab): ... here. Update all callers
13269 (setup_type_unit_groups): Move to ...
13270 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
13271 callers.
13272 (dwarf2_cu::reset_builder): New method.
13273 (process_full_compunit, process_full_type_unit): Use
13274 dwarf2_cu::reset_builder.
13275 (follow_die_offset): Record the ancestor CU if it is different
13276 from the followed DIE's CU.
13277 (follow_die_sig_1): Likewise.
13278
13279 2019-01-15 Tom Tromey <tom@tromey.com>
13280
13281 * remote.c (class remote_state) <buf>: Now a char_vector.
13282 <buf_size>: Remove.
13283 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
13284 parameter.
13285 (remote_target::getpkt_or_notif_sane_1)
13286 (remote_target::getpkt_sane)
13287 (remote_target::getpkt_or_notif_sane): Likewise.
13288 (class remote_target) <putpkt>: New overload.
13289 (remote_target::read_frame): Change type of "buf_p". Remove
13290 sizeof_p parameter.
13291 (packet_ok): New overload.
13292 (packet_check_result): New overload.
13293 Update all uses.
13294
13295 2019-01-14 Tom Tromey <tom@tromey.com>
13296
13297 * remote-notif.c (handle_notification, remote_notif_ack)
13298 (remote_notif_parse): Make "buf" const.
13299 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13300 const.
13301 (remote_notif_parse, remote_notif_ack, handle_notification):
13302 Likewise.
13303 * remote.c (remote_notif_stop_parse): Make "buf" const.
13304 (remote_target::remote_parse_stop_reply): Make "buf" const.
13305 (remote_notif_stop_ack): Make "buf" const.
13306
13307 2019-01-14 Tom Tromey <tom@tromey.com>
13308
13309 * remote.c (remote_console_output): Make parameter const.
13310
13311 2019-01-14 Tom Tromey <tom@tromey.com>
13312
13313 * target-debug.h (target_debug_print_signals): Constify.
13314 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13315 * procfs.c (procfs_target::pass_signals): Update.
13316 * linux-nat.c (linux_nat_target::pass_signals): Update.
13317 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13318 * target-delegates.c: Rebuild.
13319 * remote.c (remote_target::program_signals): Update.
13320 (remote_target::pass_signals): Update.
13321 * target.c (target_pass_signals): Constify argument.
13322 (target_program_signals): Likewise.
13323 * target.h (struct target_ops) <pass_signals, program_signals>:
13324 Constify argument.
13325 (target_pass_signals, target_program_signals): Constify argument.
13326
13327 2019-01-14 Tom Tromey <tom@tromey.com>
13328
13329 PR tui/28819:
13330 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13331
13332 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
13333
13334 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13335 field.
13336 * rs6000-tdep.c: Include reggroups.h.
13337 (IS_V_ALIAS_PSEUDOREG): Define.
13338 (rs6000_register_name): Return names for the "vX" aliases.
13339 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13340 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
13341 aliases. Call default_register_reggroup_p for all other
13342 pseudo-registers.
13343 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13344 New functions.
13345 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13346 Handle "vX" aliases.
13347 (v_alias_pseudo_register_collect): New function.
13348 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13349 (rs6000_gdbarch_init): Initialize "vX" aliases as
13350 pseudo-registers. Restore registration of
13351 rs6000_pseudo_register_reggroup_p with
13352 set_tdesc_pseudo_register_reggroup_p.
13353
13354 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
13355
13356 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13357 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13358 set_gdbarch_num_pseudo_regs.
13359
13360 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13361
13362 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13363 Remove arg prefixname, add do_set and do_show.
13364 Add member functions set_list and show_list.
13365 * cli/cli-style.c (class cli_style_option): Update accordingly.
13366 (style_set_list): Move to file scope.
13367 (style_show_list): Likewise.
13368 (set_style): Call help_list.
13369 (show_style): Call cmd_show_list.
13370 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13371 Update to use the new macro.
13372
13373 2019-10-12 Joel Brobecker <brobecker@adacore.com>
13374
13375 * ada-lang.c (_initialize_ada_language): Expand the help text
13376 for the "catch exception" command.
13377
13378 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13379
13380 * symtab.c (matching_obj_sections): Initialize obj,
13381 declare it closer to its usage.
13382
13383 2019-01-10 Tom Tromey <tom@tromey.com>
13384
13385 * thread-iter.h (inf_threads_iterator): Use next_iterator.
13386 (basic_inf_threads_range): Remove.
13387 (inf_threads_range, inf_non_exited_threads_range)
13388 (safe_inf_threads_range): Use next_adapter.
13389
13390 2019-01-10 Keith Seitz <keiths@redhat.com>
13391
13392 PR gdb/23712
13393 PR symtab/23010
13394 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13395 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13396
13397 2019-01-10 Keith Seitz <keiths@redhat.com>
13398
13399 PR gdb/23712
13400 PR symtab/23010
13401 * dictionary.c (pending_to_vector): Remove.
13402 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13403 Remove _1 suffix, replacing functions of the same name. Update
13404 all callers.
13405 (dict_create_hashed, dict_create_hashed_expandable)
13406 (dict_create_linear, dict_create_linear_expandable, dict_free)
13407 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13408 Make functions static.
13409
13410 2019-01-10 Keith Seitz <keiths@redhat.com>
13411
13412 PR gdb/23712
13413 PR symtab/23010
13414 * dictionary.h (struct dictionary): Replace declaration with
13415 multidictionary.
13416 (dict_create_hashed, dict_create_hashed_expandable)
13417 (dict_create_linear, dict_create_linear_expandable)
13418 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13419 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13420 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13421 taking multidictionary argument.
13422 [ALL_DICT_SYMBOLS]: Update for multidictionary.
13423 * block.h (struct block) <dict>: Change to multidictionary
13424 and rename `multidict'.
13425 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13426 symmisc.c: Update all dictionary references to multidictionary.
13427
13428 2019-01-10 Keith Seitz <keiths@redhat.com>
13429
13430 PR gdb/23712
13431 PR symtab/23010
13432 * dictionary.c: Include unordered_map.
13433 (pending_to_vector): New function.
13434 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13435 Rewrite the non-"_1" functions to take vector instead
13436 of linked list.
13437 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13438 "new" _1 versions of the same name.
13439 (multidictionary): Define.
13440 (std::hash<enum language): New definition.
13441 (collate_pending_symbols_by_language, mdict_create_hashed)
13442 (mdict_create_hashed_expandable, mdict_create_linear)
13443 (mdict_create_linear_expandable, mdict_free)
13444 (find_language_dictionary, create_new_language_dictionary)
13445 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13446 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13447 (mdict_size, mdict_empty): New functions.
13448 * dictionary.h (mdict_iterator): Define.
13449
13450 2019-01-10 Pedro Alves <palves@redhat.com>
13451
13452 * breakpoint.c (read_uploaded_action)
13453 (create_tracepoint_from_upload): Adjust to use
13454 gdb::unique_xmalloc_ptr.
13455 * ctf.c (ctf_write_uploaded_tp):
13456 (SET_ARRAY_FIELD): Use emplace_back.
13457 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13458 * tracefile-tfile.c (tfile_write_uploaded_tp):
13459 * tracepoint.c (parse_tracepoint_definition): Adjust to use
13460 gdb::unique_xmalloc_ptr.
13461 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13462 at_string, cond_string, cmd_strings>: Replace char pointers
13463 with gdb::unique_xmalloc_ptr.
13464
13465 2019-01-10 Pedro Alves <palves@redhat.com>
13466
13467 * solib-target.c (library_list_start_library): Don't xstrdup name.
13468
13469 2019-01-10 Pedro Alves <palves@redhat.com>
13470
13471 * mdebugread.c (parse_partial_symbols): Use
13472 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13473
13474 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
13475
13476 * linux-fork.c (scoped_switch_fork_info)
13477 <~scoped_switch_fork_info>: Fix incorrect variable name.
13478
13479 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
13480
13481 * linux-fork.c (scoped_switch_fork_info)
13482 <scoped_switch_fork_info>: Make explicit.
13483 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13484
13485 2019-01-10 Tom Tromey <tom@tromey.com>
13486
13487 * objfiles.h (objfile::reset_psymtabs): Update.
13488 * objfiles.c (objfile::objfile): Update.
13489 * psymtab.h (psymtab_storage::obstack): Update.
13490 (psymtab_storage::m_obstack): Use gdb::optional.
13491 (class psymtab_storage): Update comment. Remove objfile
13492 parameter.
13493 * psymtab.c (psymtab_storage::psymtab_storage): Update.
13494
13495 2019-01-10 Tom Tromey <tom@tromey.com>
13496
13497 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13498 <free_psymtabs>: Now private.
13499 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13500 (allocate_psymtab): Use new method.
13501
13502 2019-01-10 Tom Tromey <tom@tromey.com>
13503
13504 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13505 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13506 * mdebugread.c (parse_partial_symbols): Use
13507 allocate_dependencies.
13508 * dwarf2read.c (dwarf2_create_include_psymtab): Use
13509 allocate_dependencies.
13510 (process_psymtab_comp_unit_reader)
13511 (build_type_psymtab_dependencies): Likewise.
13512 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13513
13514 2019-01-10 Tom Tromey <tom@tromey.com>
13515
13516 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13517 PSYMBOL_SET_LANGUAGE.
13518 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13519
13520 2019-01-10 Tom Tromey <tom@tromey.com>
13521
13522 * psymtab.h (psymtab_storage::obstack): New method.
13523 <m_obstack>: Rename from obstack; now private.
13524 * psymtab.c (psymtab_storage): Update.
13525 * dwarf2read.c (create_addrmap_from_index)
13526 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13527 Update.
13528
13529 2019-01-10 Tom Tromey <tom@tromey.com>
13530
13531 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13532 * objfiles.h (objfile::reset_psymtabs): New method.
13533
13534 2019-01-10 Tom Tromey <tom@tromey.com>
13535
13536 * symmisc.c (print_symbol_bcache_statistics): Update.
13537 (print_objfile_statistics): Update.
13538 * symfile.c (reread_symbols): Update.
13539 * psymtab.h (class psymtab_storage): New.
13540 * psymtab.c (psymtab_storage): New constructor.
13541 (~psymtab_storage): New destructor.
13542 (require_partial_symbols): Update.
13543 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13544 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13545 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13546 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13547 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13548 (start_psymtab_common, end_psymtab_common)
13549 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13550 (allocate_psymtab): Update.
13551 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13552 Update.
13553 (dump_psymtab_addrmap, maintenance_print_psymbols)
13554 (maintenance_check_psymtabs): Update.
13555 (class objfile_psymtabs): Move to objfiles.h.
13556 * psympriv.h (discard_psymtab): Now inline.
13557 (psymtab_discarder::psymtab_discarder): Update.
13558 (psymtab_discarder::~psymtab_discarder): Update.
13559 (ALL_OBJFILE_PSYMTABS): Rewrite.
13560 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13561 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13562 Remove fields.
13563 <partial_symtabs>: New field.
13564 (class objfile_psymtabs): Move from psymtab.h. Update.
13565 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13566 psymbol_cache.
13567 (objfile::~objfile): Don't destroy psymbol_cache.
13568 * mdebugread.c (parse_partial_symbols): Update.
13569 * dwarf2read.c (create_addrmap_from_index)
13570 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13571 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13572 (add_partial_subprogram, dwarf2_ranges_read): Update.
13573 * dwarf-index-write.c (write_address_map)
13574 (write_one_signatured_type, recursively_write_psymbols)
13575 (class debug_names, class debug_names, write_psymtabs_to_index):
13576 Update.
13577
13578 2019-01-10 Tom Tromey <tom@tromey.com>
13579
13580 * symtab.h (SYMBOL_SET_NAMES): Update.
13581 (symbol_set_names): Update.
13582 (MSYMBOL_SET_NAMES): Update.
13583 * symtab.c (symbol_set_names): Change argument to be an
13584 objfile_per_bfd_storage.
13585 * psymtab.c (add_psymbol_to_bcache): Update.
13586 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13587
13588 2019-01-10 Tom Tromey <tom@tromey.com>
13589
13590 * symtab.c (create_demangled_names_hash): Change argument to be an
13591 objfile_per_bfd_storage.
13592 (symbol_set_names): Update.
13593
13594 2019-01-10 Tom Tromey <tom@tromey.com>
13595
13596 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13597 init_psymbol_list.
13598 * psymtab.c (init_psymbol_list): Do nothing if already called.
13599 * psympriv.h (init_psymbol_list): Add comment.
13600 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13601 init_psymbol_list.
13602 * dbxread.c (dbx_symfile_read): Unconditionally call
13603 init_psymbol_list.
13604
13605 2019-01-10 Tom Tromey <tom@tromey.com>
13606
13607 * xcoffread.c (scan_xcoff_symtab): Update.
13608 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13609 "where".
13610 * mdebugread.c (parse_partial_symbols)
13611 (handle_psymbol_enumerators): Update.
13612 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13613 * dbxread.c (read_dbx_symtab): Update.
13614 * psympriv.h (psymbol_placement): New enum.
13615 (add_psymbol_to_list): Update.
13616
13617 2019-01-10 Tom Tromey <tom@tromey.com>
13618
13619 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13620 static_psymbols parameters.
13621 (scan_xcoff_symtab): Update.
13622 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13623 static_psymbols parameters.
13624 * psympriv.h (start_psymtab_common): Update.
13625 * mdebugread.c (parse_partial_symbols): Update.
13626 * dwarf2read.c (create_partial_symtab): Update.
13627 * dbxread.c (read_dbx_symtab): Update.
13628 (start_psymtab): Remove global_psymbols and static_psymbols
13629 parameters.
13630
13631 2019-01-10 Tom Tromey <tom@tromey.com>
13632
13633 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13634 * psymtab.c (allocate_psymtab): Add comment.
13635 * psympriv.h (allocate_psymtab): Add comment.
13636 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13637 initializations.
13638 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13639
13640 2019-01-10 Tom Tromey <tom@tromey.com>
13641
13642 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13643 Don't declare.
13644 * mipsread.c: Include mdebugread.h.
13645 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13646 Declare.
13647 * elfread.c: Include mdebugread.h.
13648
13649 2019-01-09 Tom Tromey <tom@tromey.com>
13650
13651 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13652 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13653 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13654 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13655 (psym_lookup_symbol, psym_find_last_source_symtab)
13656 (psym_forget_cached_source_info, psym_print_stats)
13657 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13658 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13659 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13660 (psym_find_compunit_symtab_by_address)
13661 (maintenance_print_psymbols, maintenance_info_psymtabs)
13662 (maintenance_check_psymtabs): Use ranged for.
13663 * psymtab.h (class objfile_psymtabs): New.
13664 (require_partial_symbols): Return objfile_psymtabs.
13665 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13666
13667 2019-01-09 Tom Tromey <tom@tromey.com>
13668
13669 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13670 (find_pc_mapped_section, list_overlays_command)
13671 (map_overlay_command, unmap_overlay_command)
13672 (simple_overlay_update): Use all_objfiles.
13673 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13674 * printcmd.c (info_symbol_command): Use all_objfiles.
13675 * objfiles.h (ALL_OBJSECTIONS): Remove.
13676 * maint.c (maintenance_translate_address): Use all_objfiles.
13677 * gcore.c (gcore_create_callback): Use all_objfiles.
13678 (objfile_find_memory_regions): Likewise.
13679
13680 2019-01-09 Tom Tromey <tom@tromey.com>
13681
13682 * symtab.c (find_line_symtab, info_sources_command)
13683 (make_source_files_completion_list): Use objfile_compunits.
13684 * source.c (select_source_symtab): Use objfile_compunits.
13685 * objfiles.h (struct objfile): Update comment.
13686 (ALL_OBJFILES): Remove.
13687 (ALL_FILETABS): Remove.
13688 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13689 objfile_compunits.
13690
13691 2019-01-09 Tom Tromey <tom@tromey.com>
13692
13693 * symmisc.c (print_objfile_statistics, dump_objfile)
13694 (maintenance_print_symbols): Use compunit_filetabs.
13695 * source.c (forget_cached_source_info_for_objfile): Use
13696 compunit_filetabs.
13697 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13698 (ALL_FILETABS): Use compunit_filetabs.
13699 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13700 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13701
13702 2019-01-09 Tom Tromey <tom@tromey.com>
13703
13704 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13705 (compunit_filetabs): New.
13706 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13707 compunit_filetabs.
13708 (info_sources_command, make_source_files_completion_list): Remove
13709 declaration.
13710 * symmisc.c (print_objfile_statistics, dump_objfile)
13711 (maintenance_print_symbols): Remove declaration.
13712 (maintenance_info_symtabs): Use compunit_filetabs.
13713 (maintenance_info_line_tables): Likewise.
13714 * source.c (select_source_symtab): Change local variable name.
13715 (forget_cached_source_info_for_objfile): Remove declaration.
13716 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13717 * objfiles.c (objfile_relocate1): Remove declaration.
13718 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13719 declaration.
13720 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13721 * coffread.c (coff_symtab_read): Remove declaration.
13722 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13723 compunit_filetabs.
13724
13725 2019-01-09 Tom Tromey <tom@tromey.com>
13726
13727 * symtab.c (lookup_objfile_from_block)
13728 (find_pc_sect_compunit_symtab, search_symbols)
13729 (default_collect_symbol_completion_matches_break_on): Use
13730 objfile_compunits.
13731 * objfiles.h (ALL_COMPUNITS): Remove.
13732 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13733 * cp-support.c (add_symbol_overload_list_qualified): Use
13734 objfile_compunits.
13735 * ada-lang.c (ada_collect_symbol_completion_matches)
13736 (ada_add_global_exceptions): Use objfile_compunits.
13737
13738 2019-01-09 Tom Tromey <tom@tromey.com>
13739
13740 * source.c (select_source_symtab)
13741 (forget_cached_source_info_for_objfile): Remove declaration.
13742 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13743 declaration.
13744 * maint.c (count_symtabs_and_blocks): Remove declaration.
13745 * cp-support.c (add_symbol_overload_list_qualified): Remove
13746 declaration.
13747 * coffread.c (coff_symtab_read): Remove declaration.
13748 * symtab.c (lookup_symbol_in_objfile_symtabs)
13749 (basic_lookup_transparent_type_1): Use objfile_compunits.
13750 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13751 (info_sources_command, search_symbols)
13752 (default_collect_symbol_completion_matches_break_on)
13753 (make_source_files_completion_list): Remove declaration.
13754 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13755 (ada_collect_symbol_completion_matches)
13756 (ada_add_global_exceptions): Remove declaration.
13757 * linespec.c (iterate_over_all_matching_symtabs): Use
13758 objfile_compunits.
13759 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13760 (class objfile_compunits): New.
13761 (ALL_COMPUNITS): Use objfile_compunits.
13762 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13763 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13764 objfile_compunits.
13765 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13766
13767 2019-01-09 Tom Tromey <tom@tromey.com>
13768
13769 * symtab.c (search_symbols)
13770 (default_collect_symbol_completion_matches_break_on): Use
13771 objfile_msymbols.
13772 * ada-lang.c (ada_lookup_simple_minsym)
13773 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13774 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13775 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13776 objfile_msymbols.
13777 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13778 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13779 * objc-lang.c (find_methods): Use objfile_msymbols.
13780 (info_selectors_command, info_classes_command): Likewise.
13781 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13782 * objfiles.h (class objfile_msymbols): New.
13783 (ALL_OBJFILE_MSYMBOLS): Remove.
13784 (ALL_MSYMBOLS): Remove.
13785
13786 2019-01-09 Tom Tromey <tom@tromey.com>
13787
13788 * common/next-iterator.h (next_adapter): Add Iterator template
13789 parameter.
13790 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13791 (class all_objfiles_safe): New.
13792 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13793 * objfiles.c (put_objfile_before): Update comment.
13794 (add_separate_debug_objfile): Likewise.
13795 (free_all_objfiles): Use all_objfiles_safe.
13796 (objfile_purge_solibs): Likewise.
13797
13798 2019-01-09 Tom Tromey <tom@tromey.com>
13799
13800 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13801 (expand_symtab_containing_pc, lookup_static_symbol)
13802 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13803 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13804 all_objfiles.
13805 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13806 * breakpoint.c (create_overlay_event_breakpoint)
13807 (create_longjmp_master_breakpoint)
13808 (create_std_terminate_master_breakpoint)
13809 (create_exception_master_breakpoint): Use all_objfiles.
13810 * linux-thread-db.c (try_thread_db_load_from_pdir)
13811 (has_libpthread): Use all_objfiles.
13812 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13813 * linespec.c (iterate_over_all_matching_symtabs)
13814 (search_minsyms_for_name): Use all_objfiles.
13815 * maint.c (maintenance_info_sections): Use all_objfiles.
13816 * main.c (captured_main_1): Use all_objfiles.
13817 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13818 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13819 * guile/scm-pretty-print.c
13820 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13821 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13822 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13823 (maintenance_print_msymbols): Use all_objfiles.
13824 * source.c (select_source_symtab): Use all_objfiles.
13825 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13826 * symfile.c (remove_symbol_file_command)
13827 (expand_symtabs_matching, map_symbol_filenames): Use
13828 all_objfiles.
13829 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13830 all_objfiles.
13831 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13832 * objc-lang.c (find_methods): Use all_objfiles.
13833 * objfiles.c (have_partial_symbols, have_full_symbols)
13834 (have_minimal_symbols, qsort_cmp)
13835 (default_iterate_over_objfiles_in_search_order): Use
13836 all_objfiles.
13837 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13838 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13839 (maintenance_check_psymtabs): Use all_objfiles.
13840 (ALL_PSYMTABS): Remove.
13841 * compile/compile-object-run.c (do_module_cleanup): Use
13842 all_objfiles.
13843 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13844 * cp-support.c (add_symbol_overload_list_qualified): Use
13845 all_objfiles.
13846 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13847 Use all_objfiles.
13848 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13849 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13850 all_objfiles.
13851 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13852 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13853 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13854 Uses all_objfiles.
13855 * solib.c (solib_read_symbols): Use all_objfiles
13856
13857 2019-01-09 Tom Tromey <tom@tromey.com>
13858
13859 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13860 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13861 all_objfiles.
13862 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13863 * symmisc.c (print_symbol_bcache_statistics)
13864 (print_objfile_statistics, maintenance_print_objfiles)
13865 (maintenance_info_symtabs, maintenance_check_symtabs)
13866 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13867 all_objfiles.
13868 * source.c (forget_cached_source_info): Use all_objfiles.
13869 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13870 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13871 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13872 * objfiles.c (update_section_map): Use all_objfiles.
13873 (shared_objfile_contains_address_p): Likewise.
13874 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13875 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13876
13877 2019-01-09 Tom Tromey <tom@tromey.com>
13878
13879 * common/next-iterator.h: New file.
13880 * objfiles.h (class all_objfiles): New.
13881 (struct objfile_iterator): New.
13882
13883 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13884
13885 * NEWS: Move the description of the changed "frame", "select-frame",
13886 and "info frame" commands to the Changed commands section.
13887
13888 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13889
13890 * gdbtypes.c (check_stub_method_group): Remove handling of old
13891 mangling schemes.
13892 * linespec.c (find_methods): Likewise.
13893 * stabsread.c (read_member_functions): Likewise.
13894 * valops.c (search_struct_method): Likewise.
13895 (value_struct_elt_for_reference): Likewise.
13896 * NEWS: Mention this change.
13897
13898 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13899
13900 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13901 print_source_lines.
13902 * source.c (print_source_lines_base): Update line number check.
13903 (print_source_lines): New function.
13904 (source_lines_range::source_lines_range): New function.
13905 * source.h (class source_lines_range): New class.
13906 (print_source_lines): New declaration.
13907
13908 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13909
13910 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13911
13912 2019-01-08 Tom Tromey <tom@tromey.com>
13913 Simon Marchi <simon.marchi@ericsson.com>
13914
13915 PR gdb/24060
13916 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13917 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13918 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13919 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13920 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13921 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13922
13923 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13924
13925 * source.c (select_source_symtab): Move header comment to
13926 declaration in source.h.
13927 (forget_cached_source_info_for_objfile): Likewise.
13928 (forget_cached_source_info): Likewise.
13929 (identify_source_line): Likewise.
13930 * source.h (identify_source_line): Move declaration from symtab.h
13931 and add comment from source.c
13932 (print_source_lines): Likewise.
13933 (forget_cached_source_info_for_objfile): Likewise.
13934 (forget_cached_source_info): Likewise.
13935 (select_source_symtab): Likewise.
13936 (enum print_source_lines_flag): Move definition from symtab.h.
13937 * symtab.h (identify_source_line): Move declaration to source.h.
13938 (print_source_lines): Likewise.
13939 (forget_cached_source_info_for_objfile): Likewise.
13940 (forget_cached_source_info): Likewise.
13941 (select_source_symtab): Likewise.
13942 (enum print_source_lines_flag): Move definition to source.h.
13943 * tui/tui-hooks.c: Add 'source.h' include.
13944
13945 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13946
13947 * source.c (print_source_lines_base): Handle requests to print
13948 reverse line number sequences, and guard against empty lines
13949 string.
13950
13951 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13952
13953 * source.c (print_source_lines_base): Fix skip of '\r' if next
13954 character is '\n'.
13955
13956 2019-01-06 Tom Tromey <tom@tromey.com>
13957
13958 * c-exp.y (struct c_parse_state) <macro_original_text,
13959 expansion_obstack>: New member.
13960 (macro_original_text, expansion_obstack): Remove globals.
13961 (scan_macro_expansion, scanning_macro_expansion)
13962 (finished_macro_expansion): Update.
13963 (scan_macro_cleanup): Remove.
13964 (yylex, c_parse): Update.
13965
13966 2019-01-06 Tom Tromey <tom@tromey.com>
13967
13968 * c-exp.y (struct c_parse_state) <strings>: New member.
13969 (operator_stoken): Update.
13970
13971 2019-01-06 Tom Tromey <tom@tromey.com>
13972
13973 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13974 (union type_stack_elt) <typelist_val>: Now a pointer to
13975 std::vector.
13976 (type_stack_cleanup): Don't declare.
13977 (push_typelist): Update.
13978 * parse.c (pop_typelist): Return a std::vector.
13979 (push_typelist): Take a std::vector.
13980 (follow_types): Update. Do not free args.
13981 (type_stack_cleanup): Remove.
13982 * c-exp.y (struct c_parse_state): New.
13983 (cpstate): New global.
13984 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13985 (nonempty_typelist): Update.
13986 (func_mod): Create a new vector.
13987 (c_parse): Create a c_parse_state.
13988 (check_parameter_typelist): Do not delete params.
13989 (function_method): Update. Do not delete type_list.
13990
13991 2019-01-06 Tom Tromey <tom@tromey.com>
13992
13993 PR gdb/28155:
13994 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13995 check_typedef.
13996 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13997 (print_return_value): Likewise.
13998
13999 2019-01-05 Tom Tromey <tom@tromey.com>
14000
14001 * contrib/cleanup_check.py: Remove.
14002 * contrib/gcc-with-excheck: Remove.
14003 * contrib/exsummary.py: Remove.
14004 * contrib/excheck.py: Remove.
14005
14006 2019-01-05 Joel Brobecker <brobecker@adacore.com>
14007
14008 * thread.c (delete_thread_1): Add gdb_assert that THR is not
14009 NULL. Initialize tpprev to NULL instead of assigning it
14010 to NULL on the next statement.
14011 * windows-nat.c (windows_delete_thread): Remove check for
14012 main_thread_id before printing thread exit notifications.
14013 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14014 Remove thread ID check against main_thread_id.
14015 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14016 windows_delete_thread.
14017 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14018
14019 2019-01-04 Tom Tromey <tom@tromey.com>
14020
14021 * compile/compile.c (_initialize_compile): Use upper case for
14022 metasyntactic variables.
14023 * symmisc.c (_initialize_symmisc): Use upper case for
14024 metasyntactic variables.
14025 * psymtab.c (_initialize_psymtab): Use upper case for
14026 metasyntactic variables.
14027 * demangle.c (demangle_command): Use upper case for metasyntactic
14028 variables.
14029 (_initialize_demangler): Likewise.
14030 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14031 variables.
14032
14033 2019-01-03 Tom Tromey <tom@tromey.com>
14034
14035 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14036
14037 2019-01-03 Tom Tromey <tom@tromey.com>
14038
14039 * python/py-symtab.c (salpy_str): Update.
14040 (struct salpy_sal_object) <symtab>: Now a PyObject.
14041 (salpy_dealloc): Update.
14042 (del_objfile_sal): Use gdbpy_ref.
14043
14044 2019-01-03 Tom Tromey <tom@tromey.com>
14045
14046 * python/py-type.c (convert_field): Use new_reference. Return
14047 gdbpy_ref.
14048 (make_fielditem): Return gdbpy_ref.
14049 (typy_fields): Update.
14050 (typy_getitem): Update.
14051 (field_name): Return gdbpy_ref. Use new_reference.
14052 (typy_iterator_iternext): Update.
14053
14054 2019-01-03 Tom Tromey <tom@tromey.com>
14055
14056 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14057
14058 2019-01-03 Tom Tromey <tom@tromey.com>
14059
14060 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14061 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14062 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14063 (pspy_set_frame_filters, pspy_set_frame_unwinders)
14064 (pspy_set_type_printers): Likewise.
14065 * python/py-function.c (fnpy_init): Use gdbpy_ref.
14066 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14067 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14068 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14069 (objfpy_set_type_printers): Likewise.
14070
14071 2019-01-03 Tom Tromey <tom@tromey.com>
14072
14073 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14074 (gdbpy_print_stack): Use gdbpy_err_fetch.
14075 * python/python-internal.h (class gdbpy_err_fetch): New class.
14076 (class gdbpy_enter) <m_error_type, m_error_value,
14077 m_error_traceback>: Remove.
14078 <m_error>: New member.
14079 (gdbpy_exception_to_string): Don't declare.
14080 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14081 * python/py-value.c (convert_value_from_python): Use
14082 gdbpy_err_fetch.
14083 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14084 gdbpy_exception_to_string.
14085 (gdbpy_handle_exception): Use gdbpy_err_fetch.
14086 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14087 gdbpy_err_fetch.
14088
14089 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14090
14091 * linux-nat.c (delete_lwp_cleanup): Delete.
14092 (struct lwp_deleter): New struct.
14093 (lwp_info_up): New typedef.
14094 (linux_nat_target::follow_fork): Delete cleanup, and make use of
14095 lwp_info_up.
14096
14097 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14098
14099 * linux-fork.c (class scoped_switch_fork_info): New class.
14100 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14101
14102 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14103
14104 * valops.c (find_overload_match): Remove use of null_cleanup, and
14105 calls to do_cleanups.
14106
14107 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14108
14109 * compile/compile-cplus-types.c
14110 (compile_cplus_instance::decl_name): Handle changes to
14111 cp_func_name.
14112 * cp-support.c (cp_func_name): Update header comment, update
14113 return type.
14114 * cp-support.h (cp_func_name): Update return type in declaration.
14115 * valops.c (find_overload_match): Move temp_func local to top
14116 level of function and change its type. Use temp_func to hold and
14117 delete temporary string obtained from cp_func_name.
14118
14119 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
14120
14121 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14122 gdb::char_vector, remove cleanup, and update uses of `msg`.
14123
14124 2019-01-03 Jim Wilson <jimw@sifive.com>
14125
14126 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14127
14128 2019-01-02 Tom Tromey <tom@tromey.com>
14129
14130 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14131 (tdesc_parse_xml): Remove cleanups.
14132 * target-descriptions.h (make_cleanup_free_target_description):
14133 Don't declare.
14134 (target_desc_deleter): New struct.
14135 (target_desc_up): New typedef.
14136 * target-descriptions.c (target_desc_deleter::operator()): Rename
14137 from free_target_description.
14138 (make_cleanup_free_target_description): Remove.
14139
14140 2019-01-02 Tom Tromey <tom@tromey.com>
14141
14142 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
14143 constructor, destructor.
14144 (linespec_parser): Remove typedef.
14145 (~linespec_parser): Rename from linespec_parser_delete.
14146 (linespec_lex_to_end, linespec_complete_label)
14147 (linespec_complete): Update.
14148 (decode_line_full): Remove cleanups.
14149 (decode_line_1): Update.
14150
14151 2019-01-02 Tom Tromey <tom@tromey.com>
14152
14153 * python/python-internal.h (inferior_to_inferior_object): Change
14154 return type.
14155 * python/py-exitedevent.c (create_exited_event_object): Update.
14156 * python/py-inferior.c (inferior_to_inferior_object): Return
14157 gdbpy_ref.
14158 (python_new_inferior, python_inferior_deleted)
14159 (thread_to_thread_object, delete_thread_object)
14160 (build_inferior_list, gdbpy_selected_inferior): Update.
14161 * python/py-infthread.c (create_thread_object): Update. Also fail
14162 if inferior_to_inferior_object fails.
14163
14164 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
14165
14166 * inferior.h (class inferior) <displaced_step_state>: New field.
14167 * infrun.h (struct displaced_step_state): Move here from
14168 infrun.c. Initialize fields, add constructor.
14169 <inf>: Remove field.
14170 <reset>: New method.
14171 * infrun.c (struct displaced_step_inferior_state): Move to
14172 infrun.h.
14173 (displaced_step_inferior_states): Remove.
14174 (get_displaced_stepping_state): Adust.
14175 (displaced_step_in_progress_any_inferior): Adjust.
14176 (displaced_step_in_progress_thread): Adjust.
14177 (displaced_step_in_progress): Adjust.
14178 (add_displaced_stepping_state): Remove.
14179 (get_displaced_step_closure_by_addr): Adjust.
14180 (remove_displaced_stepping_state): Remove.
14181 (infrun_inferior_exit): Call displaced_step_state.reset.
14182 (use_displaced_stepping): Don't check for NULL.
14183 (displaced_step_prepare_throw): Call
14184 get_displaced_stepping_state.
14185 (displaced_step_fixup): Don't check for NULL.
14186 (prepare_for_detach): Don't check for NULL.
14187
14188 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14189
14190 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14191 in case of call that did not complete.
14192
14193 2019-01-02 Andrey Utkin <autkin@undo.io>
14194
14195 * symfile.c (find_separate_debug_file): Fix search of debug files for
14196 remote debuggee.
14197
14198 2019-01-02 Tom Tromey <tom@tromey.com>
14199
14200 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14201 indentation.
14202 * python/py-frame.c (frapy_older): Remove cast.
14203 (frapy_newer): Likewise.
14204 * python/py-breakpoint.c (local_setattro): Remove cast.
14205 * python/py-arch.c (archpy_name): Remove local variable.
14206 * python/py-type.c (gdbpy_lookup_type): Remove cast.
14207
14208 2019-01-02 Joel Brobecker <brobecker@adacore.com>
14209
14210 * unittests/basic_string_view/element_access/char/empty.cc:
14211 Fix year range in copyright header.
14212
14213 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
14214
14215 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14216 Delete.
14217 <operator==>: Update with for removed field.
14218 <hash>: Likewise.
14219 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14220 <isa_features>: ...this.
14221 <abi_features>: New field.
14222 (riscv_isa_flen): Update comment.
14223 (riscv_abi_xlen): New declaration.
14224 (riscv_abi_flen): New declaration.
14225 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14226 isa_features.
14227 (riscv_abi_xlen): New function.
14228 (riscv_isa_flen): Update to get answer from isa_features.
14229 (riscv_abi_flen): New function.
14230 (riscv_has_fp_abi): Update to get answer from abi_features.
14231 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14232 xlen and flen.
14233 (riscv_call_info) <xlen, flen>: Update comment.
14234 (riscv_call_arg_struct): Remove invalid assertions
14235 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14236 is removed.
14237 (riscv_gdbarch_init): Gather isa features and abi features
14238 separately, ensure both match on the gdbarch when reusing an old
14239 gdbarch. Relax an error check to allow 32-bit abi float to run on
14240 a target with 64-bit float hardware.
14241
14242 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14243
14244 * source.c (search_command_helper): Stop reverse search
14245 when line 1 has been searched.
14246
14247 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14248
14249 * record-full.c (record_full_base_target::close): Rewrite
14250 record_full_core_buf_list free logic.
14251
14252 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14253
14254 * break-catch-syscall.c (print_one_catch_syscall): xfree
14255 the last text.
14256
14257 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14258
14259 * top.c (print_gdb_version): Update Copyright year in version
14260 message.
14261
14262 2019-01-01 Joel Brobecker <brobecker@adacore.com>
14263
14264 Update copyright year range in all GDB files.
14265
14266 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
14267
14268 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14269
14270 For older changes see ChangeLog-2018.
14271 \f
14272 Local Variables:
14273 mode: change-log
14274 left-margin: 8
14275 fill-column: 74
14276 version-control: never
14277 coding: utf-8
14278 End:
14279
This page took 0.299516 seconds and 5 git commands to generate.