gdb/ChangeLog

   1 2019-10-01  Tom Tromey  <tom@tromey.com>
   2
   3         * cli/cli-cmds.c (pwd_command): Style output.
   4
   5 2019-10-01  Pedro Alves  <palves@redhat.com>
   6             Tom Tromey  <tom@tromey.com>
   7
   8         * symtab.c (print_symbol_info): Use %ps.
   9         (print_msymbol_info): Use %ps.
  10         * symfile.c (symbol_file_add_with_addrs): Use %ps.
  11         * printcmd.c (print_variable_and_value): Use %ps.
  12         * macrocmd.c (show_pp_source_pos): Use %ps.
  13         * infrun.c (print_exited_reason): Use ui_out::message.
  14         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
  15         (describe_other_breakpoints): Use ui_out::message and new
  16         formats.
  17         (say_where): Use new formats.
  18         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
  19         and new formats.
  20
  21 2019-10-01  Pedro Alves  <palves@redhat.com>
  22             Tom Tromey  <tom@tromey.com>
  23
  24         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
  25         (test_gdb_formats): New function.
  26         (run_tests): Call it.
  27         (test_format_specifier): Update.
  28         * utils.h (fputs_filtered): Update comment.
  29         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
  30         (fputs_styled_unfiltered): Declare.
  31         * utils.c (fputs_styled_unfiltered): New function.
  32         (vfprintf_maybe_filtered): Add gdbfmt parameter.
  33         (vfprintf_filtered): Update.
  34         (vfprintf_unfiltered, vprintf_filtered): Update.
  35         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
  36         * ui-out.h (enum ui_out_flag) <unfiltered_output,
  37         disallow_ui_out_field>: New constants.
  38         (enum class field_kind): New.
  39         (struct base_field_s, struct signed_field_s): New.
  40         (signed_field): New function.
  41         (struct string_field_s): New.
  42         (string_field): New function.
  43         (struct styled_string_s): New.
  44         (styled_string): New function.
  45         (class ui_out) <message>: Add comment.
  46         <vmessage, call_do_message>: New methods.
  47         <do_message>: Add style parameter.
  48         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
  49         methods.
  50         (ui_out::message): Rewrite.
  51         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
  52         parameter.
  53         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
  54         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
  55         gdb_extensions parameter.
  56         (class format_piece): Add parameter to constructor.
  57         (n_int_args): New field.
  58         * gdbsupport/format.c (format_pieces::format_pieces): Add
  59         gdb_extensions parameter.  Handle '*'.
  60         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
  61         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
  62         vfprintf_styled_no_gdbfmt.
  63         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
  64         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
  65         unfiltered output.
  66         * ui-style.h (struct ui_file_style) <ptr>: New method.
  67
  68 2019-10-01  Tom Tromey  <tom@tromey.com>
  69
  70         * unittests/format_pieces-selftests.c: Update.  Add final format.
  71         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
  72         empty literal pieces.
  73
  74 2019-10-01  Tom Tromey  <tom@tromey.com>
  75
  76         * ui-out.h (enum class ui_out_style_kind): Remove.
  77         (class ui_out) <field_string, field_stsream, do_field_string>:
  78         Change type of "style".
  79         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
  80         (ui_out::field_string): Update.
  81         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
  82         of "style".
  83         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
  84         * tracepoint.c (print_one_static_tracepoint_marker): Update.
  85         * stack.c (print_frame_arg, print_frame_info, print_frame):
  86         Update.
  87         * source.c (print_source_lines_base): Update.
  88         * solib.c (info_sharedlibrary_command): Update.
  89         * skip.c (info_skip_command): Update.
  90         * record-btrace.c (btrace_call_history_src_line)
  91         (btrace_call_history): Update.
  92         * python/py-framefilter.c (py_print_frame): Update.
  93         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
  94         "style".
  95         * mi/mi-out.c (mi_ui_out::do_table_header)
  96         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
  97         (mi_ui_out::do_field_string): Update.
  98         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  99         Update.
 100         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 101         "style".
 102         * cli-out.c (cli_ui_out::do_table_header)
 103         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 104         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 105         (cli_ui_out::do_field_fmt): Update.
 106         * breakpoint.c (print_breakpoint_location): Update.
 107         (update_static_tracepoint): Update.
 108
 109 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 110
 111         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 112         conversion of gdb_datadir.
 113         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 114         remove not needed c_str ().
 115
 116 2019-09-30  Ali Tamur <tamur@google.com>
 117
 118         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 119         (dwarf2_string_attr): Likewise.
 120
 121 2019-09-30  Ali Tamur <tamur@google.com>
 122
 123         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 124         (process_full_type_unit): Likewise.
 125         (dump_die_shallow): Likewise.
 126         (cu_debug_loc_section): Likewise.
 127
 128 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 129
 130         * minsyms.c (compare_minimal_symbols): Rename to...
 131         (minimal_symbol_is_less_than): ...this, and adjust to STL
 132         conventions (return bool, take arguments as references)
 133         (minimal_symbol_reader::install): Call std::sort instead
 134         of qsort.
 135
 136 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 137
 138         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 139         hash and why.
 140         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 141         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 142
 143 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 144
 145         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 146         * psympriv.h (add_psymbol_to_list): Move comment here and update
 147         it.
 148
 149 2019-09-29  Tom de Vries  <tdevries@suse.de>
 150
 151         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 152         Use $tmpdir/$(basename "$output_file").dwz instead of
 153         "${output_file}.dwz".
 154
 155 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 156
 157         PR gdb/25045
 158         * hppa-linux-nat.c: Include gdbarch.h.
 159
 160 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 161
 162         * blockframe.c (find_pc_partial_function): Change return type to bool.
 163         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 164         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 165         (stub_gnu_ifunc_resolve_name): Likewise.
 166         * symtab.c (compare_filenames_for_search): Likewise.
 167         (compare_glob_filenames_for_search): Likewise.
 168         (matching_obj_sections): Likewise.
 169         (symbol_matches_domain): Likewise.
 170         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 171         (find_line_pc): Change return type to bool.
 172         (find_line_pc_range): Likewise.
 173         (producer_is_realview): Likewise.
 174         * symtab.h (symbol_matches_domain): Likewise.
 175         (find_pc_partial_function): Likewise.
 176         (find_pc_line_pc_range): Likewise.
 177         (in_gnu_ifunc_stub): Likewise.
 178         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 179         (find_line_pc): Likewise.
 180         (find_line_pc_range): Likewise.
 181         (matching_obj_sections): Likewise.
 182         (find_line_symtab): Change out parameter to bool.
 183         (producer_is_realview): Change return type to bool.
 184         (compare_filenames_for_search): Likewise.
 185         (compare_glob_filenames_for_search): Likewise.
 186
 187 2019-09-26  Tom Tromey  <tom@tromey.com>
 188
 189         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 190         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 191         * gdb_usleep.h: Remove.
 192         * gdb_usleep.c: Remove.
 193         * utils.c: Don't include gdb_usleep.h.
 194
 195 2019-09-26  Tom Tromey  <tromey@adacore.com>
 196
 197         * python/py-type.c (type_to_type_object): Call check_typedef
 198         for stub types.
 199
 200 2019-09-26  Tom Tromey  <tom@tromey.com>
 201
 202         * utils.h (initialize_utils): Don't declare.
 203         * top.c (gdb_init): Don't call initialize_utils.
 204         * utils.c (initialize_utils): Remove.  Move contents...
 205         (_initialize_utils): ... here.
 206
 207 2019-09-25  Tom Tromey  <tom@tromey.com>
 208
 209         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 210         * utils.h (make_hex_string): Don't declare.
 211         * utils.c (make_hex_string): Remove.
 212
 213 2019-09-24  Tom de Vries  <tdevries@suse.de>
 214
 215         PR gdb/23815
 216         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 217         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 218
 219 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 220
 221         * NEWS: Mention new simulator port for PRU.
 222
 223 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 224
 225         * ada-exp.y (write_object_remaining): Update.
 226         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 227         and eliminate the static buffer.
 228         (ada_decode_symbol): Update.
 229         (ada_la_decode): Update.
 230         (ada_sniff_from_mangled_name): Update.
 231         (is_valid_name_for_wild_match): Update.
 232         (ada_lookup_name_info::matches): Update and simplify.
 233         (name_matches_regex): Update.
 234         (ada_add_global_exceptions): Update.
 235         * ada-lang.h (ada_decode): Update signature.
 236         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 237         * dwarf-index-write.c (debug_names::insert): Update.
 238
 239 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 240
 241         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 242         formatting.
 243
 244 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 245
 246         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 247         Change "nonzero" to "true" in documentation.
 248
 249 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 252         (_initialize_darwin_solib): Don't set
 253         darwin_so_ops.lookup_lib_global_symbol.
 254         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 255         set_gdbarch_iterate_over_objfiles_in_search_order.
 256         (elf_lookup_lib_symbol): Rename to...
 257         (svr4_iterate_over_objfiles_in_search_order): this, and update
 258         to iterate semantics.
 259         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 260         * solib.c (solib_global_lookup): Remove.
 261         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 262         (solib_global_lookup): Remove.
 263         * symtab.c (lookup_global_or_static_symbol): Remove call to
 264         solib_global_lookup.
 265
 266 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 267
 268         * NEWS: Move entries about default MI version now being
 269         version 3, and about the GDB/MI fix for multi-location
 270         breakpoints to the "since GDB 8.3" section.
 271
 272 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 273
 274         GDB 8.3.1 released.
 275
 276 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 277
 278         * NEWS: Mention that Cell/B.E. debugging support was removed.
 279         * MAINTAINERS: Remove spu target.
 280
 281         * config/djgpp/fnchange.lst: Remove entries for removed files.
 282
 283         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 284         spu-multiarch.o, and spu-tdep.o.
 285         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 286         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 287         spu-multiarch.c, and spu-tdep.c.
 288         * spu-linux-nat.c: Remove file.
 289         * spu-multiarch.c: Remove file.
 290         * spu-tdep.c: Remove file.
 291         * spu-tdep.h: Remove file.
 292         * solib-spu.c: Remove file.
 293         * solib-spu.h: Remove file.
 294
 295         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 296         * configure.nat (spu-linux): Remove.
 297         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 298         solib-multiarch.o from gdb_target_obs.
 299         (spu*-*-*): Remove.
 300
 301         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 302         feature flag.
 303         (ppc_linux_no_features): Update.
 304         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 305         Cell/B.E. support.
 306         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 307         (tdesc_powerpc_cell64l): Likewise.
 308         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 309         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 310         Cell/B.E. support.
 311         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 312         Do not include "features/rs6000/powerpc-cell32l.c" or
 313         "features/rs6000/powerpc-cell64l.c".
 314         (ppc_linux_spu_section): Remove.
 315         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 316         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 317         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 318         (ppc_linux_spe_context_lookup): Remove.
 319         (ppc_linux_spe_context_inferior_created): Remove.
 320         (ppc_linux_spe_context_solib_loaded): Remove.
 321         (ppc_linux_spe_context_solib_unloaded): Remove.
 322         (ppc_linux_spe_context): Remove.
 323         (struct ppu2spu_cache): Remove.
 324         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 325         (struct ppu2spu_data): Remove.
 326         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 327         ppu2spu_unwind): Remove.
 328         (ppc_linux_init_abi): Remove Cell/B.E. support.
 329         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 330
 331         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 332         (rs6000/powerpc-cell64l-expedite): Likewise
 333         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 334         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 335         rs6000/powerpc-cell64l.xml.
 336         * features/rs6000/powerpc-cell32l.xml: Remove.
 337         * features/rs6000/powerpc-cell64l.xml: Likewise.
 338         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 339         * features/rs6000/powerpc-cell64l.c: Likewise.
 340         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 341         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 342         * regformats/reg-spu.dat: Remove.
 343
 344         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 345         * corelow.c (struct spuid_list): Remove.
 346         (add_to_spuid_list): Remove.
 347         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 348         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 349         (remote_protocol_features): Remove associated entries.
 350         (_initialize_remote): No longer initialize them.
 351         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 352         * linux-nat.c (SPUFS_MAGIC): Remove.
 353         (linux_proc_xfer_spu): Remove.
 354         (spu_enumerate_spu_ids): Remove.
 355         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 356         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 357         (linux_make_corefile_notes): No longer call it.
 358
 359         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 360         (cooked_write_test): Likewise.
 361
 362 2019-09-20  Tom Tromey  <tom@tromey.com>
 363
 364         * NEWS: Mention case-sensitivity of TUI commands.
 365         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 366         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 367         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 368
 369 2019-09-20  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-source.c (tui_source_window::set_contents): Use
 372         make_unique_xstrdup.
 373         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 374         make_unique_xstrdup.
 375
 376 2019-09-20  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-data.c: Remove separator comments.
 379         * tui/tui-layout.c: Remove separator comments.
 380         * tui/tui-win.c: Remove separator comments.
 381         * tui/tui-wingeneral.c: Remove separator comments.
 382
 383 2019-09-20  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui.h (strcat_to_buf): Don't declare.
 386         * tui/tui.c (strcat_to_buf): Remove.
 387
 388 2019-09-20  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 391         from "fullname".
 392         * tui/tui-source.c (tui_source_window::set_contents)
 393         (tui_source_window::location_matches_p)
 394         (tui_source_window::maybe_update): Update.
 395
 396 2019-09-20  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 399         Update.
 400         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 401         prefix.
 402         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 403         (tui_data_window::line_from_reg_element_no)
 404         (tui_data_window::first_reg_element_no_inline)
 405         (tui_data_window::show_registers)
 406         (tui_data_window::show_register_group)
 407         (tui_data_window::display_registers_from)
 408         (tui_data_window::display_registers_from_line)
 409         (tui_data_window::first_data_item_displayed)
 410         (tui_data_window::delete_data_content_windows)
 411         (tui_data_window::erase_data_content)
 412         (tui_data_window::do_scroll_vertical)
 413         (tui_data_window::refresh_window)
 414         (tui_data_window::check_register_values): Update.
 415
 416 2019-09-20  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 419         (struct tui_locator_window) <full_name, proc_name>: Now
 420         std::string.
 421         * tui/tui-stack.c (tui_locator_window::make_status_line)
 422         (tui_locator_window::set_locator_fullname)
 423         (tui_locator_window::set_locator_info): Update.
 424         * tui/tui-source.c (tui_source_window::set_contents)
 425         (tui_source_window::showing_source_p): Update.
 426
 427 2019-09-20  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 430         Don't call tui_locator_win_info_ptr.
 431
 432 2019-09-20  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 435
 436 2019-09-20  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 439         height for locator.
 440         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 441         * tui/tui-layout.c (show_source_disasm_command, show_data)
 442         (show_source_or_disasm_and_command): Use 1 as height for locator.
 443
 444 2019-09-20  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui.c (tui_enable): Update.
 447         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 448         Update.
 449         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 450         Update.
 451         * tui/tui-data.c (win_resized): Now bool.
 452         (tui_win_resized): Return bool.
 453         (tui_set_win_resized_to): Accept a bool.
 454
 455 2019-09-20  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 458         Change type of "refresh_values_only".
 459         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 460         type of "refresh_values_only".
 461
 462 2019-09-20  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 465         std::string.
 466         (tui_disassemble): Add "pos" parameter.
 467         (tui_disasm_window::set_contents): Simplify.
 468
 469 2019-09-20  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-winsource.h (struct tui_source_window_base)
 472         <show_source_content>: Now private.
 473         * tui/tui-winsource.c
 474         (tui_source_window_base::show_source_content): Don't handle empty
 475         content case.
 476
 477 2019-09-20  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-layout.c (show_source_disasm_command)
 480         (show_source_or_disasm_and_command): Don't call
 481         show_source_content.
 482
 483 2019-09-20  Tom Tromey  <tom@tromey.com>
 484
 485         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 486         Declare.
 487         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 488         from tui_make_status_line.
 489         (tui_locator_window::rerender): Update.
 490
 491 2019-09-20  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 494         (tui_locator_window::rerender): Update.
 495
 496 2019-09-20  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-winsource.h (struct tui_source_window_base)
 499         <~tui_source_window_base>: Don't declare.
 500         <fullname>: Remove.
 501         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 502         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 503         member.
 504         * tui/tui-source.c (tui_source_window::set_contents): Update.
 505         (tui_source_window::location_matches_p)
 506         (tui_source_window::maybe_update): Update.
 507
 508 2019-09-20  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-winsource.h (~tui_source_element): Remove.
 511         (tui_source_element): Update.
 512         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 513         * tui/tui-winsource.c (tui_show_source_line): Update.
 514         * tui/tui-source.c (tui_source_window::set_contents): Update.
 515         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 516
 517 2019-09-20  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 520         declare.
 521         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 522         tui_clear_source_windows_detail.
 523         * tui/tui-winsource.h (struct tui_source_window_base)
 524         <clear_detail>: Don't declare.
 525         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 526         Remove.
 527         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 528
 529 2019-09-20  Tom Tromey  <tromey@adacore.com>
 530
 531         PR ada/24919:
 532         * block.c (contained_in): Fix final return value.
 533
 534 2019-09-20  Alan Modra  <amodra@gmail.com>
 535
 536         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 537         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 538         (read_indirect_string_from_dwz): Use bfd accessor.
 539         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 540         * machoread.c (macho_symfile_read_all_oso): Likewise.
 541         * solib.c (solib_bfd_open): Likewise.
 542
 543 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 544
 545         * eval.c: Move declaration of overload_resolution to...
 546         * value.h: ...here.
 547
 548 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 549
 550         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 551         * arm-linux-tdep.c: Likewise.
 552         * arm-nbsd-nat.c: Likewise.
 553         * arm-tdep.h: Declare arm_apcs_32.
 554         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 555
 556 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 557
 558         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 559         * dwarf2read.h: Declare dwarf_always_disassemble.
 560
 561 2019-09-19  Tom de Vries  <tdevries@suse.de>
 562
 563         PR gdb/25009
 564         * source-cache.c (source_cache::ensure): Catch exception thrown during
 565         construction of the highlighter.
 566
 567 2019-09-18  Alan Modra  <amodra@gmail.com>
 568
 569         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 570         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 571         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 572         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 573         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 574         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 575         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 576         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 577         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 578         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 579         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 580         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 581         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 582         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 583         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 584         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 585         * mi/mi-interp.c: Update throughout for bfd section macro and
 586         function changes.
 587         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 588         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 589
 590 2019-09-18  Tom Tromey  <tom@tromey.com>
 591
 592         * NEWS: Add entry.
 593         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 594         call rl_initialize.
 595         (tui_enable): Do not call rl_initialize.
 596
 597 2019-09-18  Christian Groessler  <chris@groessler.org>
 598
 599         * alpha-linux-nat.c: Include gdbarch.h.
 600
 601 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 602
 603         * ui-file.c: Include cli/cli-style.h.
 604         (term_cli_styling): Remove cli_styling declaration.
 605
 606 2019-09-18  Alan Modra  <amodra@gmail.com>
 607
 608         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 609         to bfd_asymbol_section.
 610
 611 2019-09-18  Alan Modra  <amodra@gmail.com>
 612
 613         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 614         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 615         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 616
 617 2019-09-18  Alan Modra  <amodra@gmail.com>
 618
 619         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 620         * spu-linux-nat.c (spu_bfd_open): Likewise.
 621
 622 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 623
 624         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 625         to bool to match definition in dwarf2read.c.
 626
 627 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 628
 629         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 630         (print_signatures): Likewise.
 631         (trust_pad_over_xvs): Likewise.
 632         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 633         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 634         * arm-linux-nat.c (arm_apcs_32): Likewise.
 635         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 636         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 637         * arm-tdep.c (arm_debug): Likewise.
 638         (arm_apcs_32): Likewise.
 639         * auto-load.c (debug_auto_load): Likewise.
 640         (auto_load_gdb_scripts): Likewise.
 641         (global_auto_load): Likewise.
 642         (auto_load_local_gdbinit): Likewise.
 643         (auto_load_local_gdbinit_loaded): Likewise.
 644         * auto-load.h (global_auto_load): Likewise.
 645         (auto_load_local_gdbinit): Likewise.
 646         (auto_load_local_gdbinit_loaded): Likewise.
 647         * breakpoint.c (disconnected_dprintf): Likewise.
 648         (breakpoint_proceeded): Likewise.
 649         (automatic_hardware_breakpoints): Likewise.
 650         (always_inserted_mode): Likewise.
 651         (target_exact_watchpoints): Likewise.
 652         (_initialize_breakpoint): Update.
 653         * breakpoint.h (target_exact_watchpoints): Change to bool.
 654         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 655         * cli/cli-cmds.c (trace_commands): Likewise.
 656         * cli/cli-cmds.h (trace_commands): Likewise.
 657         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 658         to bool*.
 659         * cli/cli-logging.c (logging_overwrite): Change to bool.
 660         (logging_redirect): Likewise.
 661         (debug_redirect): Likewise.
 662         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 663         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 664         to bool.
 665         <boolean_option_def>: Update.
 666         (struct flag_option_def): Change default type of Context to bool
 667         from int.
 668         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 669         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 670         (get_setshow_command_value_string): Likewise.
 671         * cli/cli-style.c (cli_styling): Change to bool.
 672         (source_styling): Likewise.
 673         * cli/cli-style.h (source_styling): Likewise.
 674         (cli_styling): Likewise.
 675         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 676         to bool.
 677         * command.h (var_types): Update comment.
 678         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 679         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 680         bool.
 681         (debug_compile_cplus_scopes): Likewise.
 682         * compile/compile-internal.h (compile_debug): Likewise.
 683         * compile/compile.c (compile_debug): Likewise.
 684         (struct compile_options) <raw>: Likewise.
 685         * cp-support.c (catch_demangler_crashes): Likewise.
 686         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 687         (usr_cmd_cris_dwarf2_cfi): Likewise.
 688         * csky-tdep.c (csky_debug): Likewise.
 689         * darwin-nat.c (enable_mach_exceptions): Likewise.
 690         * dcache.c (dcache_enabled_p): Likewise.
 691         * defs.h (info_verbose): Likewise.
 692         * demangle.c (demangle): Likewise.
 693         (asm_demangle): Likewise.
 694         * dwarf-index-cache.c (debug_index_cache): Likewise.
 695         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 696         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 697         * dwarf2read.c (check_physname): Likewise.
 698         (use_deprecated_index_sections): Likewise.
 699         (dwarf_always_disassemble): Likewise.
 700         * eval.c (overload_resolution): Likewise.
 701         * event-top.c (set_editing_cmd_var): Likewise.
 702         (exec_done_display_p): Likewise.
 703         * event-top.h (set_editing_cmd_var): Likewise.
 704         (exec_done_display_p): Likewise.
 705         * exec.c (write_files): Likewise.
 706         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 707         (debug_fbsd_nat): Likewise.
 708         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 709         Likewise.
 710         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 711         <backtrace_past_entry> Likewise.
 712         * gdb-demangle.h (demangle): Likewise.
 713         (asm_demangle): Likewise.
 714         * gdb_bfd.c (bfd_sharing): Likewise.
 715         * gdbcore.h (write_files): Likewise.
 716         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 717         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 718         * gdbthread.h (print_thread_events): Likewise.
 719         * gdbtypes.c (opaque_type_resolution): Likewise.
 720         (strict_type_checking): Likewise.
 721         * gnu-nat.c (gnu_debug_flag): Likewise.
 722         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 723         * guile/scm-param.c (pascm_variable): Add boolval.
 724         (add_setshow_generic): Update.
 725         (pascm_param_value): Update.
 726         (pascm_set_param_value_x): Update.
 727         * hppa-tdep.c (hppa_debug): Change to bool..
 728         * infcall.c (may_call_functions_p): Likewise.
 729         (coerce_float_to_double_p): Likewise.
 730         (unwind_on_signal_p): Likewise.
 731         (unwind_on_terminating_exception_p): Likewise.
 732         * infcmd.c (startup_with_shell): Likewise.
 733         * inferior.c (print_inferior_events): Likewise.
 734         * inferior.h (startup_with_shell): Likewise.
 735         (print_inferior_events): Likewise.
 736         * infrun.c (step_stop_if_no_debug): Likewise.
 737         (detach_fork): Likewise.
 738         (debug_displaced): Likewise.
 739         (disable_randomization): Likewise.
 740         (non_stop): Likewise.
 741         (non_stop_1): Likewise.
 742         (observer_mode): Likewise.
 743         (observer_mode_1): Likewise.
 744         (set_observer_mode): Update.
 745         (sched_multi): Change to bool.
 746         * infrun.h (debug_displaced): Likewise.
 747         (sched_multi): Likewise.
 748         (step_stop_if_no_debug): Likewise.
 749         (non_stop): Likewise.
 750         (disable_randomization): Likewise.
 751         * linux-tdep.c (use_coredump_filter): Likewise.
 752         (dump_excluded_mappings): Likewise.
 753         * linux-thread-db.c (auto_load_thread_db): Likewise.
 754         (check_thread_db_on_load): Likewise.
 755         * main.c (captured_main_1): Update.
 756         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 757         xx2_opt, boolean_opt>: Change to bool.
 758         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 759         * maint.c (maintenance_profile_p): Likewise.
 760         (per_command_time): Likewise.
 761         (per_command_space): Likewise.
 762         (per_command_symtab): Likewise.
 763         * memattr.c (inaccessible_by_default): Likewise.
 764         * mi/mi-main.c (mi_async): Likewise.
 765         (mi_async_1): Likewise.
 766         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 767         * nat/fork-inferior.h (startup_with_shell): Likewise.
 768         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 769         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 770         * nios2-tdep.c (nios2_debug): Likewise.
 771         * or1k-tdep.c (or1k_debug): Likewise.
 772         * parse.c (parser_debug): Likewise.
 773         * parser-defs.h (parser_debug): Likewise.
 774         * printcmd.c (print_symbol_filename): Likewise.
 775         * proc-api.c (procfs_trace): Likewise.
 776         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 777         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 778         (set_parameter_value): Update.
 779         (add_setshow_generic): Update.
 780         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 781         to bool*.
 782         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 783         int*.
 784         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 785         * record-btrace.c (record_btrace_target::store_registers): Update.
 786         * record-full.c (record_full_memory_query): Change to bool.
 787         (record_full_stop_at_limit): Likewise.
 788         * record-full.h (record_full_memory_query): Likewise.
 789         * remote-notif.c (notif_debug): Likewise.
 790         * remote-notif.h (notif_debug): Likewise.
 791         * remote.c (use_range_stepping): Likewise.
 792         (interrupt_on_connect): Likewise.
 793         (remote_break): Likewise.
 794         * ser-tcp.c (tcp_auto_retry): Likewise.
 795         * ser-unix.c (serial_hwflow): Likewise.
 796         * skip.c (debug_skip): Likewise.
 797         * solib-aix.c (solib_aix_debug): Likewise.
 798         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 799         (spu_auto_flush_cache_p): Likewise.
 800         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 801         Likewise.
 802         (struct info_print_options) <quiet>: Likewise.
 803         * symfile-debug.c (debug_symfile): Likewise.
 804         * symfile.c (auto_solib_add): Likewise.
 805         (separate_debug_file_debug): Likewise.
 806         * symfile.h (auto_solib_add): Likewise.
 807         (separate_debug_file_debug): Likewise.
 808         * symtab.c (basenames_may_differ): Likewise.
 809         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 810         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 811         (struct info_types_options) <quiet>: Likewise.
 812         * symtab.h (demangle): Likewise.
 813         (basenames_may_differ): Likewise.
 814         * target-dcache.c (stack_cache_enabled_1): Likewise.
 815         (code_cache_enabled_1): Likewise.
 816         * target.c (trust_readonly): Likewise.
 817         (may_write_registers): Likewise.
 818         (may_write_memory): Likewise.
 819         (may_insert_breakpoints): Likewise.
 820         (may_insert_tracepoints): Likewise.
 821         (may_insert_fast_tracepoints): Likewise.
 822         (may_stop): Likewise.
 823         (auto_connect_native_target): Likewise.
 824         (target_stop_and_wait): Update.
 825         (target_async_permitted): Change to bool.
 826         (target_async_permitted_1): Likewise.
 827         (may_write_registers_1): Likewise.
 828         (may_write_memory_1): Likewise.
 829         (may_insert_breakpoints_1): Likewise.
 830         (may_insert_tracepoints_1): Likewise.
 831         (may_insert_fast_tracepoints_1): Likewise.
 832         (may_stop_1): Likewise.
 833         * target.h (target_async_permitted): Likewise.
 834         (may_write_registers): Likewise.
 835         (may_write_memory): Likewise.
 836         (may_insert_breakpoints): Likewise.
 837         (may_insert_tracepoints): Likewise.
 838         (may_insert_fast_tracepoints): Likewise.
 839         (may_stop): Likewise.
 840         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 841         (make_thread_apply_all_options_def_group): Change argument from int*
 842         to bool*.
 843         (thread_apply_all_command): Update.
 844         (print_thread_events): Change to bool.
 845         * top.c (confirm): Likewise.
 846         (command_editing_p): Likewise.
 847         (history_expansion_p): Likewise.
 848         (write_history_p): Likewise.
 849         (info_verbose): Likewise.
 850         * top.h (confirm): Likewise.
 851         (history_expansion_p): Likewise.
 852         * tracepoint.c (disconnected_tracing): Likewise.
 853         (circular_trace_buffer): Likewise.
 854         * typeprint.c (print_methods): Likewise.
 855         (print_typedefs): Likewise.
 856         * utils.c (debug_timestamp): Likewise.
 857         (sevenbit_strings): Likewise.
 858         (pagination_enabled): Likewise.
 859         * utils.h (sevenbit_strings): Likewise.
 860         (pagination_enabled): Likewise.
 861         * valops.c (overload_resolution): Likewise.
 862         * valprint.h (struct value_print_options) <prettyformat_arrays,
 863         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 864         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 865         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 866         Likewise.
 867         * windows-nat.c (new_console): Likewise.
 868         (cygwin_exceptions): Likewise.
 869         (new_group): Likewise.
 870         (debug_exec): Likewise.
 871         (debug_events): Likewise.
 872         (debug_memory): Likewise.
 873         (debug_exceptions): Likewise.
 874         (useshell): Likewise.
 875         * windows-tdep.c (maint_display_all_tib): Likewise.
 876         * xml-support.c (debug_xml): Likewise.
 877
 878 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 879
 880         * source.c (prepare_path_for_appending): New function.
 881         (openp): Make use of new function.
 882         (find_and_open_source): Search for the compilation directory and
 883         source file as a relative path beneath the directory search path.
 884
 885 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * source-cache.c (source_cache::get_line_charpos): Catch
 888         exceptions and return false, this matches the behaviour documented
 889         in the header file.
 890
 891 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 892
 893         * ada-tasks.c (info_task): Remove quoting of the task's name.
 894
 895 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 896
 897         * symfile.c (auto_solib_add): Replace comment with a reference
 898         to the header file.
 899
 900 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 901
 902         * NEWS: Mention that gdb can now be compiled with Python 3
 903         on Windows.
 904
 905 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * maint.c (maint_print_section_data::maint_print_section_data):
 908         Force use of 'float log10 (float)' by casting the argument to
 909         float.
 910
 911 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 912
 913         * maint.c: Add 'cmath' include.
 914         (struct maint_print_section_data): New structure.
 915         (print_section_index): New function.
 916         (print_bfd_section_info): Add header comment, small whitespace
 917         cleanup, and update to call new print_section_index function.
 918         (print_objfile_section_info): Likewise.
 919         (maint_obj_section_from_bfd_section): New function.
 920         (print_bfd_section_info_maybe_relocated): New function.
 921         (maintenance_info_sections): Add header comment, always use
 922         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 923
 924 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 927         inner scope, add check that the objfile has psymtabs before
 928         checking psymtabs_addrmap.
 929         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 930
 931 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 932
 933         * NEWS: Announce that Ada task names are now shown at more places,
 934         and between quotes (except in info task output).
 935         * gdb/ada-tasks.c (task_to_str): New function.
 936         (display_current_task_id): Call task_to_str.
 937         (task_command_1): Likewise.
 938         (print_ada_task_info): In non-mi mode, Properly align headers and data
 939         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 940
 941 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 942
 943         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 944         prstatus.pr_lwp.pr_info instead of making it up.
 945
 946 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 947
 948         * auto-load.c (auto_load_expand_dir_vars): Update.
 949         * defs.h (gdb_datadir): Change to std::string.
 950         (python_libdir): Likewise.
 951         (relocate_gdb_directory): Change return type to std::string.
 952         * guile/guile.c (gdbscm_data_directory): Update.
 953         (initialize_scheme_side): Update.
 954         * jit.c (jit_reader_dir): Change to std::string.
 955         (jit_reader_load_command): Update.
 956         * main.c (gdb_datadir): Change to std::string.
 957         (python_libdir): Likewise.
 958         (set_gdb_data_directory): Update.
 959         (relocate_path): Change to return std::string.
 960         (relocate_gdb_directory): Change to return std::string.
 961         (relocate_gdbinit_path_maybe_in_datadir): Update.
 962         (captured_main_1): Update.
 963         * python/python.c (do_start_initialization): Update.
 964         * top.c (show_gdb_datadir): Update.
 965         * xml-syscall.c (xml_init_syscalls_info): Update.
 966         (init_syscalls_info): Update.
 967
 968 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 969
 970         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 971         out of get_init_files.
 972         (get_init_files): Update.
 973
 974 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 975
 976         * main.c (get_init_files): Change to use std::string.
 977         (captured_main_1): Update.
 978         (print_gdb_help): Update.
 979
 980 2019-09-11  Ali Tamur  <tamur@google.com>
 981
 982         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 983         implementation.
 984
 985 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 986
 987         * dbxread.c (read_dbx_symtab): Update.
 988         * dwarf2read.c (load_partial_dies): Update.
 989         * mdebugread.c (parse_partial_symbols): Update.
 990         (handle_psymbol_enumerators): Update.
 991         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 992         * psymtab.c (add_psymbol_to_bcache): Likewise.
 993         (add_psymbol_to_list): Likewise.
 994         * symtab.c (symbol_set_names): Likewise.
 995         * symtab.h (symbol_set_names): Likewise.
 996         * xcoffread.c (scan_xcoff_symtab): Update.
 997
 998 2019-09-11  Tom Tromey  <tom@tromey.com>
 999
1000         * symfile-mem.c (symbol_file_add_from_memory): Use
1001         bfd_set_filename.
1002         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1003         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1004
1005 2019-09-10  Tom Tromey  <tromey@adacore.com>
1006
1007         * dwarf-index-write.c (write_psymbols): Extend error message.
1008         (debug_names::insert): Add Ada code.
1009         (debug_names::write_psymbols): Remove Ada check.
1010         (debug_names) <m_string_obstack>: New member.
1011         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1012         (gdb_index_symbol_name_matcher::matches): Remove.
1013         (mapped_index_base::find_name_components_bounds): Add "lang"
1014         parameter.
1015         (mapped_index_base::build_name_components): Also split names
1016         according to Ada syntax.
1017         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1018         type of "match_callback".
1019         (check_match, check_find_bounds_finds)
1020         (dw2_expand_symtabs_matching): Update.
1021         (dw2_debug_names_iterator): Add new constructor.
1022         (dw2_debug_names_map_matching_symbols): New function.
1023         (dw2_debug_names_expand_symtabs_matching): Update.
1024         (dwarf2_debug_names_functions): Use
1025         dw2_debug_names_map_matching_symbols.
1026
1027 2019-09-10  Tom Tromey  <tromey@adacore.com>
1028
1029         * dwarf2read.c (dw2_get_file_names_reader): Add the
1030         CU's file name to the results.
1031
1032 2019-09-10  Tom Tromey  <tromey@adacore.com>
1033
1034         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1035         map_matching_symbols.  Update.
1036         * dwarf2read.c (dw2_map_matching_symbols): Update.
1037         * psymtab.c (match_partial_symbol): Change type; update.
1038         (psym_map_matching_symbols): Likewise.
1039         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1040         type; update.
1041         * symfile.h (struct quick_symbol_functions)
1042         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1043         Remove "match".
1044
1045 2019-09-10  Tom Tromey  <tromey@adacore.com>
1046
1047         * psymtab.c (map_block): Remove.
1048         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1049         * symtab.c (iterate_over_symbols_terminated): New function.
1050         * symtab.c (iterate_over_symbols_terminated): Declare.
1051
1052 2019-09-10  Tom Tromey  <tromey@adacore.com>
1053
1054         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1055         * language.h (struct language_defn) <la_iterate_over_symbols>:
1056         Return bool.
1057         * symtab.c (iterate_over_symbols): Return bool.
1058         * symtab.h (iterate_over_symbols): Return bool.
1059
1060 2019-09-10  Tom Tromey  <tromey@adacore.com>
1061
1062         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1063         (add_nonlocal_symbols): Update.
1064         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1065         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1066         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1067         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1068         Change type of "callback".  Remove "data".
1069
1070
1071 2019-09-09  Ali Tamur  <tamur@google.com>
1072
1073         * dwarf2read.c (comp_unit_head): Update comment.
1074         (dwarf2_dwo_name): New function declaration.
1075         (dwarf_unit_type_name): New function declaration.
1076         (read_comp_unit_head): Add support for new compilation units,
1077         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1078         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1079         (currently named as "signature") in their header. Also clarify error
1080         messages.
1081         (lookup_dwo_id): New function. Returns the dwo id of the given
1082         compile unit.
1083         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1084         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1085         functions.
1086         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1087         (dwarf2_dwo_name): Get the dwo name if present.
1088         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1089         purposes.
1090
1091 2019-09-09  Tom Tromey  <tom@tromey.com>
1092
1093         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1094
1095 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1096
1097         * python/python.c (do_start_initialization): Make progname_copy static,
1098         to avoid a leak report.
1099
1100 2019-09-08  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1103
1104 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1105
1106         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1107         Change type to gdb::optional<block_enum>.
1108         (dw2_symtab_iter_init): Change block_index parameter type
1109         to gdb::optional<block_enum>.
1110         (dw2_lookup_symbol): Change block_index parameter
1111         type to block_enum.c
1112         (dw2_debug_names_lookup_symbol): Likewise.
1113         * psymtab.c (psym_lookup_symbol): Likewise.
1114         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1115         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1116         Likewise.
1117
1118 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1119
1120         * defs.h (relocate_gdb_directory): Change int to bool in
1121         signature and rename flag to relocatable.
1122         * main.c (relocate_path): Likewise.
1123         (relocate_gdb_directory): Likewise.
1124
1125 2019-09-06  Alan Modra  <amodra@gmail.com>
1126
1127         * coffread.c (coff_symfile_read): Constify filename variable.
1128         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1129         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1130         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1131         * solib.c (reload_shared_libraries_1): Likewise.
1132         * symfile.c (reread_symbols): Likewise.
1133         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1134         * solib-darwin.c (darwin_bfd_open): Likewise.
1135         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1136
1137 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1138
1139         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1140         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1141
1142 2019-09-03  Tom Tromey  <tromey@adacore.com>
1143
1144         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1145         types.
1146         (has_negatives): Unbias a range type bound.
1147         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1148         * gdbtypes.c (operator==): Handle new field.
1149         (create_range_type): Add "bias" parameter.
1150         (create_static_range_type, resolve_dynamic_range): Update.
1151         * gdbtypes.h (struct range_bounds) <bias>: New member.
1152         (create_range_type): Add bias parameter.
1153         * printcmd.c (print_scalar_formatted): Unbias range types.
1154         * value.c (unpack_long): Unbias range types.
1155         (pack_long): Bias range types.
1156
1157 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1158
1159         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1160         probe arguments.
1161
1162 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1163
1164         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1165         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1166         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1167         (compile_probe_arg): Likewise.
1168         * probe.h (get_argument_count): Likewise.
1169         * solib-svr4.c (solib_event_probe_action): Likewise.
1170         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1171
1172 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1173
1174         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1175         code to here...
1176         (svr4_create_solib_event_breakpoints): ...from here.
1177
1178 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1179
1180         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1181         suffix from warning message.
1182
1183 2019-08-30  Tom Tromey  <tom@tromey.com>
1184
1185         * tui/tui-winsource.h (struct tui_source_window_base)
1186         <refresh_all>: Don't declare.
1187         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1188         Remove.
1189         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1190         tui_show_locator_content.
1191         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1192         declare.
1193         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1194         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1195         declare.
1196
1197 2019-08-30  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1200
1201 2019-08-30  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1204         Remove unnecessary forward declarations.
1205
1206 2019-08-30  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1209         rerender.
1210         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1211         tui_show_locator_content.
1212
1213 2019-08-30  Tom Tromey  <tom@tromey.com>
1214
1215         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1216         (tui_locator_window::rerender): Rewrite using body of previous
1217         tui_show_locator_content.
1218
1219 2019-08-30  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1222         set_locator_fullname>: New methods.
1223         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1224         Rename from tui_set_locator_fullname.
1225         (tui_locator_window::set_locator_info): Rename from
1226         tui_set_locator_info.  Return bool.
1227         (tui_update_locator_fullname, tui_show_frame_info): Update.
1228
1229 2019-08-30  Tom Tromey  <tom@tromey.com>
1230
1231         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1232
1233 2019-08-30  Tom Tromey  <tom@tromey.com>
1234
1235         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1236         call touchwin.
1237
1238 2019-08-30  Tom Tromey  <tom@tromey.com>
1239
1240         * tui/tui-wingeneral.c (box_win): Assume win_info and
1241         win_info->handle cannot be NULL.
1242
1243 2019-08-30  Tom Tromey  <tom@tromey.com>
1244
1245         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1246         refresh_window>: Declare.
1247         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1248         resize.
1249         (tui_data_item_window::rerender): Rename from
1250         tui_display_register.
1251         (tui_data_item_window::refresh_window): New method.
1252         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1253         no-op.
1254
1255 2019-08-30  Tom Tromey  <tom@tromey.com>
1256
1257         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1258         regs_column_count, current_group>: Move later.  Now private.
1259         <get_current_group>: New method.
1260         * tui/tui-regs.c (tui_reg_command): Update.
1261         * tui/tui-layout.c (tui_set_layout): Update.
1262
1263 2019-08-30  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1266         (tui_data_window::rerender): Don't call
1267         check_and_display_highlight_if_needed.
1268         (tui_data_window::refresh_all): Remove call to
1269         erase_data_content.
1270
1271 2019-08-30  Tom Tromey  <tom@tromey.com>
1272
1273         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1274         (tui_data_window::display_registers_from)
1275         (tui_data_window::display_reg_element_at_line)
1276         (tui_data_window::display_registers_from_line): Remove checks of
1277         "empty".
1278
1279 2019-08-30  Tom Tromey  <tom@tromey.com>
1280
1281         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1282         Don't declare.
1283         * tui/tui-regs.c (tui_data_window::show_registers): Call
1284         rerender.
1285         (tui_data_window::rerender): Rename from display_all_data.
1286         (tui_data_window::rerender): Remove old implementation.
1287
1288 2019-08-30  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1291         text.
1292         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1293
1294 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1295             Sergio Durigan Junior  <sergiodj@redhat.com>
1296
1297         PR win32/24284
1298         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1299
1300 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1301
1302         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1303         when searching for types.
1304
1305 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * f-lang.c (f_language_defn): Use f_print_typedef.
1308         * f-lang.h (f_print_typedef): Declare.
1309         * f-typeprint.c (f_print_typedef): Define.
1310
1311 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1312
1313         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1314
1315 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1316
1317         * cli/cli-utils.c (info_print_options_defs): Delete.
1318         (make_info_print_options_def_group): Delete.
1319         (extract_info_print_options): Delete.
1320         (info_print_command_completer): Delete.
1321         (info_print_args_help): Add extra parameter, and optionally
1322         include text about -n flag.
1323         * cli/cli-utils.h (struct info_print_options): Delete.
1324         (extract_info_print_options): Delete declaration.
1325         (info_print_command_completer): Delete declaration.
1326         (info_print_args_help): Add extra parameter, extend header
1327         comment.
1328         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1329         search_symbols.
1330         * stack.c (struct info_print_options): New type.
1331         (info_print_options_defs): New file scoped variable.
1332         (make_info_print_options_def_group): New static function.
1333         (info_print_command_completer): New static function.
1334         (info_locals_command): Update to use new local functions.
1335         (info_args_command): Likewise.
1336         (_initialize_stack): Add extra parameter to calls to
1337         info_print_args_help.
1338         * symtab.c (search_symbols): Add extra parameter, use this to
1339         possibly excluse non-debug symbols.
1340         (symtab_symbol_info): Add extra parameter, which is passed on to
1341         search_symbols.
1342         (struct info_print_options): New type.
1343         (info_print_options_defs): New file scoped variable.
1344         (make_info_print_options_def_group): New static function.
1345         (info_print_command_completer): New static function.
1346         (info_variables_command): Update to use local functions, and pass
1347         extra parameter through to symtab_symbol_info.
1348         (info_functions_command): Likewise.
1349         (info_types_command): Pass additional argument through to
1350         symtab_symbol_info.
1351         (rbreak_command): Pass extra argument to search_symbols.
1352         (_initialize_symtab): Add extra arguments for calls to
1353         info_print_args_help, and update help text for 'info variables',
1354         'whereis', and 'info functions' commands.
1355         * symtab.h (search_symbols): Add extra argument to declaration.
1356         * NEWS: Mention new flags.
1357
1358 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1359
1360         * symtab.c (lookup_static_symbol): Call the new function (and move
1361         it down to be next to lookup_global_symbol).
1362         (struct global_sym_lookup_data): Add block_enum member and rename to...
1363         (struct global_or_static_sym_lookup_data): ...this.
1364         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1365         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1366         (lookup_symbol_global_or_static_iterator_cb): ...this.
1367         (lookup_global_or_static_symbol): New function.
1368         (lookup_global_symbol): Call new function.
1369
1370 2019-08-26  Tom de Vries  <tdevries@suse.de>
1371
1372         PR c++/24852
1373         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1374         when pc_probe.prob == NULL.
1375
1376 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1377
1378         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1379         variable symbol_linkage to symbol_linkage_.
1380
1381 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1382
1383         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1384         represent whether the symbol is static, dynamic, or we don't
1385         know.
1386
1387 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1388
1389         * gdb/rx-tdep.c (rx_register_names): New.
1390         (rx_register_name): Delete.
1391         (rx_psw_type): Delete.
1392         (rx_fpsw_type): Delete.
1393         (rx_register_type): Delete.
1394         (rx_gdbarch_init): Convert target-descriptions.
1395         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1396         * gdb/features/Makefile: Add rx.xml.
1397         * gdb/features/rx.xml: New.
1398         * gdb/features/rx.c: Generated.
1399         * gdb/NEWS: Mention target description support.
1400
1401 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1402
1403         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1404         *slot_ptr.
1405
1406 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1407
1408         * configure.ac: Don't check for 'dlfcn.h' (moved to
1409         gdbsupport/common.m4).
1410         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1411         'gdbsupport/'.
1412         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1413         * compile/compile-c-support.c: Include
1414         'gdbsupport/gdb-dlfcn.h'.
1415         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1416         * gdb-dlfcn.c: Move to...
1417         * gdbsupport/gdb-dlfcn.c: ... here.
1418         * gdb-dlfcn.h: Move to...
1419         * gdbsupport/gdb-dlfcn.h: ... here.
1420
1421 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1422
1423         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1424         the offset field signed.
1425
1426 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1427
1428         * python/lib/gdb/__init__.py (_execute_file): New function.
1429         * python/python.c (python_run_simple_file): Call gdb._execute_file
1430         on Windows.
1431
1432 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1433
1434         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1435         all uses as this was never set to anything but a zero value.
1436
1437 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1438
1439         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1440
1441 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1442
1443         * tui/tui-data.h (tui_gen_win_info): Add an =default
1444         move constructor, required by some GCC versions.
1445
1446 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1447
1448         * go32-nat.c (go32_sysinfo): Add hygon_p.
1449
1450 2019-08-20  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1453         line_from_reg_element_no, first_reg_element_no_inline,
1454         display_all_data, delete_data_content_windows,
1455         erase_data_content>: Now private.
1456
1457 2019-08-20  Tom Tromey  <tom@tromey.com>
1458
1459         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1460         (tui_unhighlight_win, tui_highlight_win)
1461         (tui_win_info::make_window): Update.
1462         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1463
1464 2019-08-20  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1467         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1468         (MAX_PID_WIDTH): Move to tui-stack.c.
1469         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1470         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1471         (MAX_PID_WIDTH): Move from tui-data.h.
1472
1473 2019-08-20  Tom Tromey  <tom@tromey.com>
1474
1475         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1476         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1477         (box_win): Update.
1478         (tui_gen_win_info::make_window): Rename from tui_make_window.
1479         (tui_win_info::make_window): New method.
1480         (tui_gen_win_info::make_visible): Update.
1481         * tui/tui-source.c (tui_source_window::set_contents): Update.
1482         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1483         (tui_data_window::display_registers_from): Update.
1484         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1485         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1486         Declare.
1487         <can_box>: Remove.
1488         <title>: Remove.
1489         (struct tui_win_info) <make_window>: Declare.
1490         <can_box>: Now virtual.
1491         <title>: New member.
1492         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1493         * tui/tui-command.c (tui_cmd_window::resize): Update.
1494
1495 2019-08-20  Tom Tromey  <tom@tromey.com>
1496
1497         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1498         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1499         (tui_data_window::check_register_values): Update.
1500
1501 2019-08-20  Tom Tromey  <tom@tromey.com>
1502
1503         * tui/tui-regs.h (struct tui_data_window): Use
1504         DISABLE_COPY_AND_ASSIGN.
1505         <regs_content>: Change type, removing unique_ptr.
1506         <tui_data_window>: Add move constructor.
1507         * tui/tui-regs.c (tui_data_window::show_registers)
1508         (tui_data_window::show_register_group)
1509         (tui_data_window::display_registers_from)
1510         (tui_data_window::display_registers_from)
1511         (tui_data_window::first_data_item_displayed)
1512         (tui_data_window::delete_data_content_windows)
1513         (tui_data_window::rerender, tui_data_window::refresh_window)
1514         (tui_data_window::check_register_values): Update.
1515
1516 2019-08-20  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1519         show_register_group>: Declare.
1520         (tui_show_register_group): Don't declare.
1521         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1522         tui_show_registers.
1523         (tui_data_window::show_register_group): Rename from
1524         tui_show_register_group.
1525         (tui_data_window::check_register_values, tui_reg_command):
1526         Update.
1527         * tui/tui-layout.c (tui_set_layout): Update.
1528
1529 2019-08-20  Tom Tromey  <tom@tromey.com>
1530
1531         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1532         Declare.
1533         (tui_check_register_values): Don't declare.
1534         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1535         from tui_check_register_values.
1536         * tui/tui-hooks.c (tui_register_changed): Update.
1537
1538 2019-08-20  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-regs.c (tui_reg_layout): Move later.
1541         (tui_show_registers): Don't enable TUI mode or change layout.
1542
1543 2019-08-20  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-regs.h (struct tui_data_item_window)
1546         <~tui_data_item_window>: Remove.
1547         <content>: Now a unique_xmalloc_ptr.
1548         * tui/tui-regs.c (tui_register_format): Return a
1549         unique_xmalloc_ptr.
1550         (tui_get_register): Update.
1551         (~tui_data_item_window): Remove.
1552         (tui_data_window::display_registers_from, tui_display_register):
1553         Update.
1554         * tui/tui-io.h (tui_expand_tabs): Update.
1555         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1556         Remove "col" parameter.
1557
1558 2019-08-20  Tom Tromey  <tom@tromey.com>
1559
1560         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1561         field.
1562         * tui/tui-regs.c (~tui_data_item_window): Update.
1563
1564 2019-08-20  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1567         earlier.
1568
1569 2019-08-20  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1572
1573 2019-08-20  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui-source.h (struct tui_source_window): Update.
1576         * tui/tui-regs.c (tui_show_registers): Update.
1577         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1578         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1579         (NO_REGS_STRING): Remove defines.
1580
1581 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1582
1583         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1584         unnecessary thread walk if remote doesn't support the packet.
1585
1586 2019-08-19  Tom Tromey  <tromey@adacore.com>
1587
1588         * python/py-value.c (value_has_field): Fix indentation.
1589
1590 2019-08-19  Tom Tromey  <tromey@adacore.com>
1591
1592         * printcmd.c (do_one_display, info_display_command): Update.
1593         * block.h (contained_in): Return bool.  Add allow_nested
1594         parameter.
1595         * block.c (contained_in): Return bool.  Add allow_nested
1596         parameter.
1597
1598 2019-08-19  Tom Tromey  <tom@tromey.com>
1599
1600         * configure: Rebuild.
1601         * configure.ac: Disallow the combination of -static-libstdc++ and
1602         source highlight.
1603         * source-cache.c (get_language_name): Handle rust.
1604         (source_cache::get_source_lines): Ignore highlighting exceptions.
1605
1606 2019-08-16  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1609         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1610         (struct tui_source_window_base) <make_visible, refresh_window,
1611         resize>: Remove methods.
1612         <execution_info>: Remove field.
1613         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1614         (tui_show_source_line, tui_source_window_base)
1615         (~tui_source_window_base): Update.
1616         (tui_source_window_base::resize)
1617         (tui_source_window_base::make_visible)
1618         (tui_source_window_base::refresh_window): Remove.
1619         (tui_source_window_base::update_exec_info): Update.
1620         * tui/tui-source.c (tui_source_window::set_contents): Update.
1621         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1622
1623 2019-08-16  Tom Tromey  <tom@tromey.com>
1624
1625         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1626         deprecated_query_hook.
1627
1628 2019-08-16  Tom Tromey  <tom@tromey.com>
1629
1630         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1631         (tui_update_source_windows_with_line): Update.
1632         * tui/tui-source.h (struct tui_source_window)
1633         <show_symtab_source>: Declare.
1634         (tui_show_symtab_source): Don't declare.
1635         * tui/tui-source.c (tui_show_symtab_source): Rename from
1636         tui_show_symtab_source.
1637
1638 2019-08-16  Tom Tromey  <tom@tromey.com>
1639
1640         * tui/tui-winsource.h (struct tui_source_window_base)
1641         <set_contents>: Declare.
1642         * tui/tui-winsource.c
1643         (tui_source_window_base::update_source_window_as_is): Update.
1644         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1645         Declare.
1646         (tui_set_source_content): Don't declare.
1647         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1648         tui_set_source_content.
1649         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1650         Declare.
1651         (tui_set_disassem_content): Don't declare.
1652         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1653         tui_set_disassem_content.
1654
1655 2019-08-16  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-winsource.h (struct tui_source_window_base)
1658         <update_breakpoint_info>: Declare.
1659         (tui_update_breakpoint_info): Don't declare.
1660         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1661         (tui_update_all_breakpoint_info): Update.
1662         (tui_source_window_base::update_breakpoint_info): Rename from
1663         tui_update_breakpoint_info.
1664         (tui_source_window_base::update_exec_info): Update.
1665
1666 2019-08-16  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-winsource.h (struct tui_source_window_base)
1669         <update_source_window>: Declare.
1670         (tui_update_source_window): Don't declare.
1671         * tui/tui-winsource.c
1672         (tui_source_window_base::update_source_window): Rename from
1673         tui_update_source_window.
1674         (tui_source_window_base::rerender): Update.
1675         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1676         * tui/tui-disasm.c (tui_show_disassem)
1677         (tui_show_disassem_and_update_source)
1678         (tui_disasm_window::maybe_update): Update.
1679
1680 2019-08-16  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-winsource.h (struct tui_source_window_base)
1683         <update_source_window_as_is>: Declare.
1684         (tui_update_source_window_as_is): Don't declare.
1685         * tui/tui-winsource.c (tui_update_source_window): Update
1686         (tui_source_window_base::update_source_window_as_is): Rename from
1687         tui_update_source_window_as_is.
1688         (tui_source_window_base::refill): Update.
1689         * tui/tui-source.c (tui_show_symtab_source): Update.
1690         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1691         Update.
1692
1693 2019-08-16  Tom Tromey  <tom@tromey.com>
1694
1695         * tui/tui-winsource.h (tui_update_source_window)
1696         (tui_update_source_window_as_is): Remove "noerror" parameter.
1697         * tui/tui-winsource.c (tui_update_source_window)
1698         (tui_update_source_window_as_is): Remove "noerror" parameter.
1699         (tui_update_source_windows_with_addr)
1700         (tui_update_source_windows_with_line)
1701         (tui_source_window_base::rerender)
1702         (tui_source_window_base::refill): Update.
1703         * tui/tui-source.h (tui_set_source_content)
1704         (tui_show_symtab_source): Remove "noerror" parameter.
1705         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1706         parameter.
1707         (tui_show_symtab_source): Likewise.
1708         (tui_source_window::maybe_update): Update.
1709         * tui/tui-disasm.c (tui_show_disassem)
1710         (tui_show_disassem_and_update_source)
1711         (tui_disasm_window::do_scroll_vertical)
1712         (tui_disasm_window::maybe_update): Update.
1713
1714 2019-08-16  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui.c (tui_is_window_visible): Update.
1717         * tui/tui-wingeneral.c (tui_make_window)
1718         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1719         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1720         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1721         (tui_set_win_height_command, parse_scrolling_args): Update.
1722         * tui/tui-source.c (tui_source_window::style_changed): Update.
1723         * tui/tui-regs.c (tui_show_registers)
1724         (tui_data_window::first_data_item_displayed)
1725         (tui_data_window::delete_data_content_windows)
1726         (tui_check_register_values, tui_reg_command): Update.
1727         * tui/tui-disasm.c (tui_show_disassem): Update.
1728         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1729         method.
1730         <is_visible>: Remove field.
1731         * tui/tui-data.c (tui_next_win, tui_prev_win)
1732         (tui_delete_invisible_windows): Update.
1733
1734 2019-08-16  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-winsource.h (struct tui_source_window_base)
1737         <m_has_locator>: Remove.
1738         * tui/tui-layout.c (show_source_disasm_command, show_data)
1739         (show_source_or_disasm_and_command): Update.
1740
1741 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1742
1743         * NEWS (Other MI changes): New subsection.
1744         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1745         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1746         * arch-utils.c (default_get_pc_address_flags): New function.
1747         * arch-utils.h (default_get_pc_address_flags): New declaration.
1748         * gdbarch.sh: Add get_pc_address_flags.
1749         * gdbarch.c: Regenerate.
1750         * gdbarch.h: Likewise.
1751         * stack.c (print_pc): New function.
1752         (print_frame_info) (print_frame): Call print_pc.
1753
1754 2019-08-16  Tom de Vries  <tdevries@suse.de>
1755
1756         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1757         print_objfile_section_info.
1758
1759 2019-08-15  Tom Tromey  <tom@tromey.com>
1760
1761         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1762         calling update_cmdwin_start_line.
1763         * tui/tui-winsource.h (struct tui_source_window_base)
1764         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1765         <rerender>: Declare.
1766         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1767         Call rerender.
1768         (tui_source_window_base::set_new_height): Remove.
1769         (tui_source_window_base::rerender): Rename from
1770         do_make_visible_with_new_height.
1771         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1772         resize method.
1773         (tui_win_info::make_invisible_and_set_new_height)
1774         (tui_win_info::make_visible_with_new_height): Remove.
1775         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1776         Declare.
1777         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1778         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1779         do_make_visible_with_new_height>: Don't declare.
1780         <rerender>: Declare.
1781         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1782         set_new_height.
1783         (tui_data_window::do_make_visible_with_new_height): Remove.
1784         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1785         call tui_show_locator_content.
1786         (tui_gen_win_info::resize): Call rerender.
1787         (show_source_or_disasm_and_command): Don't call
1788         tui_show_locator_content.
1789         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1790         method.
1791         (struct tui_win_info) <rerender>: Declare.
1792         <set_new_height, make_invisible_and_set_new_height,
1793         make_visible_with_new_height>: Don't declare.
1794         * tui/tui-data.c (tui_win_list::rerender): New method.
1795         * tui/tui-command.h (struct tui_cmd_window)
1796         <do_make_visible_with_new_height>: Don't declare.
1797         * tui/tui-command.c
1798         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1799
1800 2019-08-15  Tom Tromey  <tromey@adacore.com>
1801
1802         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1803         * ada-lang.c (ada_enum_name): Likewise.
1804
1805 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1806
1807         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1808         leading underscore.
1809         (GdbOutputErrorFile): Likewise.
1810         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1811         accordingly.
1812         (execute_unwinders): Rename to have a leading underscore.
1813         (auto_load_packages): Likewise.
1814         (global scope): Adjust call to auto_load_packages accordingly.
1815         (GdbSetPythonDirectory): Likewise.
1816         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1817         instead of execute_unwinders.
1818
1819 2019-08-15  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1822         (show_data): Don't change window visibility.
1823         (tui_gen_win_info::resize): Remove special case for command
1824         window.  Use wresize, when available.
1825         (show_source_or_disasm_and_command): Don't change window
1826         visibility.
1827         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1828         <make_visible>: New method.
1829         * tui/tui-command.c (tui_cmd_window::resize): New method.
1830
1831 2019-08-15  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1834         (struct tui_source_windows): New.
1835         * tui/tui-winsource.c (tui_display_main): Update.
1836         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1837         (new_height_ok, parse_scrolling_args): Update.
1838         * tui/tui-layout.c (show_layout, show_data): Update.
1839         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1840         (tui_add_to_source_windows): Don't declare.
1841         * tui/tui-data.c (source_windows, tui_source_windows)
1842         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1843
1844 2019-08-15  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1847         Rename from reset.
1848         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1849         * tui/tui-layout.c (show_source_disasm_command, show_data):
1850         Update.
1851         (tui_gen_win_info::resize): Rename.
1852         (show_source_or_disasm_and_command): Update.
1853         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1854         reset.
1855
1856 2019-08-15  Tom Tromey  <tom@tromey.com>
1857
1858         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1859         * tui/tui-interp.c (tui_interp::init): Don't call
1860         tui_initialize_static_data.
1861         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1862
1863 2019-08-15  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1866         examine tui_win_list.
1867
1868 2019-08-15  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1871         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1872         tui_clear_source_content.
1873         (tui_clear_source_content): Remove.
1874         (tui_source_window_base::do_erase_source_content): Hoist call to
1875         content.clear().
1876         * tui/tui-stack.c (tui_show_frame_info): Don't call
1877         tui_clear_source_content.
1878
1879 2019-08-15  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-winsource.h (struct tui_source_window_base)
1882         <do_erase_source_content>: New method.
1883         <erase_source_content>: New method.
1884         (tui_erase_source_content): Don't declare.
1885         * tui/tui-winsource.c (tui_clear_source_content): Update.
1886         (tui_source_window_base::do_erase_source_content): Rename from
1887         tui_erase_source_content.
1888         (tui_source_window_base::show_source_content): Update.
1889         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1890         * tui/tui-source.h (struct tui_source_window)
1891         <erase_source_content>: New method.
1892         * tui/tui-disasm.h (struct tui_disasm_window)
1893         <erase_source_content>: New method.
1894
1895 2019-08-15  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1898         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1899         constructor.
1900         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1901         * tui/tui-source.c (tui_set_source_content): Update.
1902         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1903
1904 2019-08-15  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1907         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1908         tui-source.c.
1909         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1910         Declare.
1911         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1912         method.
1913         (tui_source_window::maybe_update): Update.
1914
1915 2019-08-15  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1918         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1919         tui-disasm.c.
1920         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1921         Declare.
1922         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1923         method.
1924         (tui_disasm_window::maybe_update): Update.
1925
1926 2019-08-15  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-winsource.h (struct tui_source_window_base)
1929         <maybe_update>: Declare.
1930         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1931         method.
1932         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1933         Declare.
1934         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1935         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1936         Declare.
1937         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1938
1939 2019-08-15  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1942
1943 2019-08-15  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-wingeneral.c: Include tui-stack.h.
1946         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1947         (struct tui_locator_window): Move from tui-data.h.
1948         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1949         (tui_initialize_static_data): Move from tui-data.c.
1950         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1951         (struct tui_locator_window): Move to tui-stack.c.
1952         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1953         (tui_initialize_static_data): Move to tui-stack.c.
1954
1955 2019-08-15  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-layout.c (show_source_disasm_command)
1958         (show_source_or_disasm_and_command): Use make_visible method, not
1959         tui_make_window.
1960         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1961         Remove.
1962
1963 2019-08-15  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-wingeneral.h (tui_make_window): Update.
1966         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1967         parameter.
1968         (tui_gen_win_info::make_visible): Update.
1969         * tui/tui-regs.c (tui_data_window::display_registers_from):
1970         Update.
1971         * tui/tui-layout.c (show_source_disasm_command)
1972         (show_source_or_disasm_and_command): Update.
1973         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1974         (enum tui_box): Remove.
1975         (struct tui_win_info) <can_box>: New method.
1976         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1977         method.
1978
1979 2019-08-15  Tom de Vries  <tdevries@suse.de>
1980
1981         * linux-nat-trad.c: Include gdbarch.h.
1982
1983 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1984
1985         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1986         register sizes.
1987
1988 2019-08-14  Tom Tromey  <tromey@adacore.com>
1989
1990         * darwin-nat.c: Include gdbarch.h.
1991         * darwin-nat-info.c: Include gdbarch.h.
1992
1993 2019-08-13  Tom Tromey  <tom@tromey.com>
1994
1995         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1996         Remove.
1997         * tui/tui-data.c (tui_initialize_static_data): Update.
1998
1999 2019-08-13  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-winsource.h (struct tui_exec_info_window)
2002         <~tui_exec_info_window, maybe_allocate_content, get_content,
2003         m_content>: Remove.
2004         (struct tui_source_window_base) <set_exec_info_content,
2005         show_exec_info_content>: Don't declare.
2006         * tui/tui-winsource.c
2007         (tui_exec_info_window::maybe_allocate_content): Remove.
2008         (tui_source_window_base::update_exec_info): Rename from
2009         set_exec_info_content.
2010         (tui_source_window_base::show_exec_info_content)
2011         (tui_source_window_base::update_exec_info): Remove.
2012
2013 2019-08-13  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2016         declare.
2017         * tui/tui-winsource.c (tui_update_source_window_as_is)
2018         (tui_update_source_windows_with_addr, tui_erase_source_content):
2019         Update.
2020         (tui_clear_exec_info_content): Remove.
2021
2022 2019-08-13  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2025         declare.
2026         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2027         call tui_erase_exec_info_content.
2028         (tui_clear_exec_info_content): Rename from
2029         tui_erase_exec_info_content.
2030         (tui_clear_exec_info_content): Delete.
2031
2032 2019-08-13  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-winsource.h (struct tui_source_window_base)
2035         <show_exec_info_content>: Declare.
2036         (tui_show_exec_info_content): Don't declare.
2037         * tui/tui-winsource.c
2038         (tui_source_window_base::show_exec_info_content): Rename from
2039         tui_show_exec_info_content.
2040         (tui_source_window_base::update_exec_info): Update.
2041
2042 2019-08-13  Tom Tromey  <tom@tromey.com>
2043
2044         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2045         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2046         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2047         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2048         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2049         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2050         ... here.
2051
2052 2019-08-13  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-winsource.h (struct tui_source_window_base)
2055         <update_exec_info>: Declare.
2056         (tui_update_exec_info): Don't declare.
2057         * tui/tui-winsource.c (tui_update_source_window_as_is)
2058         (tui_source_window_base::refresh_all)
2059         (tui_update_all_breakpoint_info): Update.
2060         (tui_source_window_base::update_exec_info): Rename from
2061         tui_update_exec_info.
2062         * tui/tui-stack.c (tui_show_frame_info): Update.
2063
2064 2019-08-13  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-winsource.h (struct tui_source_window_base)
2067         <set_exec_info_content>: Declare.
2068         (tui_set_exec_info_content): Don't declare.
2069         * tui/tui-winsource.c
2070         (tui_source_window_base::set_exec_info_content): Rename from
2071         tui_set_exec_info_content.
2072         (tui_update_exec_info): Update.
2073
2074 2019-08-13  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-winsource.h (struct tui_source_window_base)
2077         <show_source_content>: Declare.
2078         (tui_show_source_content): Don't declare.
2079         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2080         (tui_source_window_base::show_source_content): Rename from
2081         tui_show_source_content.
2082         (tui_source_window_base::refresh_all): Update.
2083         * tui/tui-layout.c (show_source_disasm_command)
2084         (show_source_or_disasm_and_command): Update.
2085
2086 2019-08-13  Tom Tromey  <tom@tromey.com>
2087
2088         * tui/tui-winsource.c (tui_erase_source_content)
2089         (tui_show_source_content, tui_source_window_base::refresh_all):
2090         Update.
2091         * tui/tui-wingeneral.h
2092         (tui_check_and_display_highlight_if_needed): Don't declare.
2093         * tui/tui-wingeneral.c
2094         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2095         check_and_display_highlight_if_needed.
2096         * tui/tui-win.c (tui_rehighlight_all)
2097         (tui_win_info::make_visible_with_new_height): Update.
2098         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2099         (tui_data_window::erase_data_content)
2100         (tui_data_window::display_all_data): Update.
2101         * tui/tui-data.h (struct tui_win_info)
2102         <check_and_display_highlight_if_needed>: Declare.
2103
2104 2019-08-13  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-win.c (tui_resize_all): Call
2107         tui_delete_invisible_windows.
2108         * tui/tui-layout.c (show_layout): Call
2109         tui_delete_invisible_windows.
2110         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2111         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2112
2113 2019-08-13  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2116         tui_add_win_to_layout.
2117
2118 2019-08-13  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2121         * tui/tui-layout.c (tui_default_win_height): Now static.
2122
2123 2019-08-13  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2126         single switch.
2127         (show_source_disasm_command, show_source_or_disasm_and_command):
2128         Don't check current layout.
2129
2130 2019-08-13  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-wingeneral.c (make_all_visible): Remove.
2133         (tui_make_all_invisible): Simplify.
2134         * tui/tui-layout.c (tui_make_all_invisible): Move from
2135         tui-wingeneral.c; simplify.
2136         (show_layout): Hoist call to tui_make_all_invisible.
2137         (show_data): Don't call tui_make_all_invisible.
2138
2139 2019-08-13  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2142         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2143
2144 2019-08-13  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2147         tui-data.c.
2148         (show_source_disasm_command, show_data)
2149         (show_source_or_disasm_and_command): Don't use
2150         tui_set_current_layout_to.
2151         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2152         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2153         tui-layout.c.
2154         (tui_set_current_layout_to): Remove.
2155
2156 2019-08-13  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-layout.c (tui_set_layout): Update.
2159         * tui/tui-data.h (struct tui_layout_def): Remove.
2160         (tui_layout_def): Don't declare.
2161         * tui/tui-data.c (layout_def): Remove.
2162         (tui_layout_def): Remove.
2163
2164 2019-08-13  Tom Tromey  <tom@tromey.com>
2165
2166         * tui/tui-winsource.h (struct tui_source_window_base)
2167         <clear_detail>: No longer "override".
2168         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2169         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2170         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2171         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2172         Remove.
2173         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2174
2175 2019-08-13  Tom Tromey  <tromey@adacore.com>
2176
2177         * tracepoint.c: Don't include readline.h or history.h.
2178
2179 2019-08-12  Tom Tromey  <tom@tromey.com>
2180
2181         * configure: Rebuild.
2182         * configure.ac: Check for readline 7.
2183         * NEWS: Mention readline 7 requirement.
2184         * README: Update.
2185
2186 2019-08-12  Tom Tromey  <tom@tromey.com>
2187
2188         * mingw-hdep.c (gdb_select): Remove readline hack.
2189
2190 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2191
2192         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2193         when the function fails.
2194
2195 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2196
2197         * s390-tdep.c (s390_type_align): New function.
2198         (s390_gdbarch_init): Set it as type_align gdbarch method.
2199
2200 2019-08-09  Tom de Vries  <tdevries@suse.de>
2201
2202         PR gdb/24591
2203         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2204         pc_low with relocation offset.
2205
2206 2019-08-07  Tom Tromey  <tromey@adacore.com>
2207
2208         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2209         (print_frame_args): Update.
2210         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2211         Update.
2212         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2213         * frame.h (struct frame_arg): Add initializers.
2214         <error>: Now a unique_xmalloc_ptr.
2215
2216 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2217
2218         * NEWS: Expand the Pointer Authentication entry.
2219         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2220         (aarch64_frame_unmask_lr): ... to this.
2221         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2222         Call aarch64_frame_unmask_lr.
2223         * frame.c (struct frame_info): Add "masked" variable.
2224         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2225         (fprint_frame): Check for masked pc.
2226         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2227         declarations.
2228         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2229         * stack.c (print_frame): Check for masked pc.
2230
2231 2019-08-06  Tom Tromey  <tom@tromey.com>
2232
2233         * stabsread.c (patch_block_stabs, read_one_struct_field)
2234         (read_enum_type): Use obstack_strndup.
2235         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2236         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2237         * dwarf2read.c (guess_full_die_structure_name)
2238         (anonymous_struct_prefix): Use obstack_strndup.
2239         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2240         * c-exp.y (yylex): Use obstack_strndup.
2241         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2242         (write_var_or_type): Use obstack_strndup.
2243
2244 2019-08-06  Tom Tromey  <tom@tromey.com>
2245
2246         * symfile.c (reread_symbols): Use obstack_strdup.
2247         * stabsread.c (read_type): Use obstack_strdup.
2248         * gdb_obstack.h (obstack_strdup): New overload.
2249         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2250         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2251         (dwarf2_canonicalize_name): Use obstack_strdup.
2252         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2253         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2254         Use obstack_strdup.
2255
2256 2019-08-06  Tom Tromey  <tom@tromey.com>
2257
2258         * gdb_obstack.h (obstack_strdup): Define.
2259         * gdb_obstack.c (obstack_strdup): Don't define.
2260
2261 2019-08-06  Tom Tromey  <tom@tromey.com>
2262
2263         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2264         obstack_strdup.
2265         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2266         obstack_strdup.
2267         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2268         * stabsread.c (common_block_start): Use obstack_strdup.
2269         * objfiles.c (set_objfile_main_name, objfile): Use
2270         obstack_strdup.
2271         * namespace.c (add_using_directive): Use obstack_strdup.
2272         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2273         * jit.c (finalize_symtab): Use obstack_strdup.
2274         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2275         (guess_partial_die_structure_name, partial_die_info::fixup)
2276         (dwarf2_name): Use obstack_strdup.
2277         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2278         obstack_strdup.
2279         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2280         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2281         obstack_strdup.
2282         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2283
2284 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2285
2286         * unittests/help-doc-selftests.c: New file.
2287         * Makefile.in: Add the new file.
2288
2289 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2290
2291         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2292         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2293         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2294         the trailing '.' is not output, and the first character is uppercased.
2295         (print_help_for_command): Update call to print_doc_line.
2296         (print_doc_of_command): Likewise.
2297         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2298         * cli/cli-option.c (append_indented_doc): Do not append newline.
2299         (build_help_option): Append newline after first appended_indented_doc
2300         only if a second call is done.
2301         (build_help): Append 2 new lines before each option, except the first
2302         one.
2303         * compile/compile.c (_initialize_compile): Add new lines after
2304         %OPTIONS%, when not at the end of the help.
2305         Change help doc or code
2306         producing the help doc to respect the invariants.
2307         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2308         Also removed the new line after 'Options:', as all other commands
2309         do not put an empty line between 'Options:' and the first option.
2310         * printcmd.c (_initialize_printcmd): Likewise.
2311         * stack.c (_initialize_stack): Likewise.
2312         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2313         incorrectly telling COMMAND is optional.
2314         * ada-lang.c (_initialize_ada_language): Change help doc or code
2315         producing the help doc to respect the invariants.
2316         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2317         * breakpoint.c (_initialize_breakpoint): Likewise.
2318         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2319         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2320         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2321         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2322         _initialize_cli_style): Likewise.
2323         * corelow.c (core_target_info): Likewise.
2324         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2325         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2326         * filesystem.c (_initialize_filesystem): Likewise.
2327         * frame.c (_initialize_frame): Likewise.
2328         * gnu-nat.c (add_task_commands): Likewise.
2329         * infcall.c (_initialize_infcall): Likewise.
2330         * infcmd.c (_initialize_infcmd): Likewise.
2331         * interps.c (_initialize_interpreter): Likewise.
2332         * language.c (_initialize_language): Likewise.
2333         * linux-fork.c (_initialize_linux_fork): Likewise.
2334         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2335         * maint.c (_initialize_maint_cmds): Likewise.
2336         * memattr.c (_initialize_mem): Likewise.
2337         * printcmd.c (_initialize_printcmd): Likewise.
2338         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2339         _RegEx): Likewise.
2340         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2341         * record-btrace.c (_initialize_record_btrace): Likewise.
2342         * record-full.c (_initialize_record_full): Likewise.
2343         * record.c (_initialize_record): Likewise.
2344         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2345         * regcache.c (_initialize_regcache): Likewise.
2346         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2347         _initialize_remote): Likewise.
2348         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2349         * serial.c (_initialize_serial): Likewise.
2350         * skip.c (_initialize_step_skip): Likewise.
2351         * source.c (_initialize_source): Likewise.
2352         * stack.c (_initialize_stack): Likewise.
2353         * symfile.c (_initialize_symfile): Likewise.
2354         * symtab.c (_initialize_symtab): Likewise.
2355         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2356         * top.c (init_main): Likewise.
2357         * tracefile-tfile.c (tfile_target_info): Likewise.
2358         * tracepoint.c (_initialize_tracepoint): Likewise.
2359         * tui/tui-win.c (_initialize_tui_win): Likewise.
2360         * utils.c (add_internal_problem_command): Likewise.
2361         * valprint.c (value_print_option_defs): Likewise.
2362
2363 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2364
2365         PR build/24886
2366         * configure.ac: Drop enable-libmcheck support.
2367         * configure, config.in: Rebuild.
2368         * libmcheck.m4: Remove.
2369         * acinclude.m4: Don't include it.
2370         * Makefile.in: Don't distribute it.
2371         * top.c (print_gdb_configuration): Don't mention it.
2372
2373 2019-08-06  Tom Tromey  <tom@tromey.com>
2374
2375         * utils.c (set_output_style): Sometimes pass stream to
2376         emit_style_escape.
2377         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2378         * record-btrace.c (btrace_insn_history): Update.
2379         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2380         method.
2381         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2382         Update initializers.
2383         <m_uiout>: New field.
2384         <m_di>: Move lower.
2385         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2386         Remove "uiout" parameter.
2387         (dump_insns): Update.
2388         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2389         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2390
2391 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2392
2393         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2394         (error_in_psymtab_expansion): Likewise.
2395         (lookup_symbol_via_quick_fns): Likewise.
2396         (basic_lookup_transparent_type_quick): Likewise.
2397         (basic_lookup_transparent_type_1): Likewise.
2398
2399 2019-08-06  Tom Tromey  <tromey@adacore.com>
2400
2401         * source.c (last_source_error): Now bool.
2402         (print_source_lines_base): Make "noprint" bool.  Only open
2403         source file when last_source_visited changes.
2404
2405 2019-08-06  Tom Tromey  <tromey@adacore.com>
2406
2407         * annotate.c (annotate_source_line): Use g_source_cache.
2408         * source-cache.c (source_cache::get_plain_source_lines): Change
2409         parameters.  Populate m_offset_cache.
2410         (source_cache::ensure): New method.
2411         (source_cache::get_line_charpos): New method.
2412         (extract_lines): Move lower.  Change parameters.
2413         (source_cache::get_source_lines): Move lower.
2414         * source-cache.h (class source_cache): Update comment.
2415         <get_line_charpos>: New method.
2416         <get_source_lines>: Update comment.
2417         <clear>: Clear m_offset_cache.
2418         <get_plain_source_lines>: Change parameters.
2419         <ensure>: New method
2420         <m_offset_cache>: New member.
2421         * source.c (forget_cached_source_info_for_objfile): Update.
2422         (info_source_command): Use g_source_cache.
2423         (find_source_lines, open_source_file_with_line_charpos): Remove.
2424         (print_source_lines_base, search_command_helper): Use g_source_cache.
2425         * source.h (open_source_file_with_line_charpos): Don't declare.
2426         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2427         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2428         Use g_source_cache.
2429
2430 2019-08-06  Tom Tromey  <tromey@adacore.com>
2431
2432         * source-cache.c (source_cache::get_plain_source_lines):
2433         Remove "first_line" and "last_line" parameters.
2434         (source_cache::get_source_lines): Cache plain text.
2435         * source-cache.h (class source_cache)
2436         <get_plain_source_lines>: Update.
2437
2438 2019-08-06  Tom Tromey  <tromey@adacore.com>
2439
2440         * source-cache.c (extract_lines): No longer a method.
2441         Changed type of parameter.  Include final newline.
2442         (selftests::extract_lines_test): New function.
2443         (_initialize_source_cache): Likewise.
2444         * source-cache.h (class source_cache)
2445         <extract_lines>: Don't declare.
2446
2447 2019-08-06  Tom Tromey  <tromey@adacore.com>
2448
2449         * breakpoint.c (init_breakpoint_sal): Update.
2450         (breakpoint): Update.
2451         * breakpoint.h (struct breakpoint) <filter>: Now a
2452         unique_xmalloc_ptr.
2453
2454 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2455
2456         * NEWS: Mention dictionary access on blocks.
2457         * python/py-block.c (blpy_getitem): New function.
2458         (block_object_as_mapping): New struct.
2459         (block_object_type): Use new struct for tp_as_mapping field.
2460
2461 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2462
2463         * objfiles.h (objfile): Add a comment describing partial symbols.
2464
2465 2019-08-05  Tom Tromey  <tromey@adacore.com>
2466
2467         * compile/compile.c (_initialize_compile): Use _(), not N_().
2468         * thread.c (_initialize_thread): Use _(), not N_().
2469         * stack.c (_initialize_stack): Use _(), not N_().
2470         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2471
2472 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2473
2474         * dwarf2read.c (struct dw2_symtab_iterator):
2475         <want_specific_block>: Remove.
2476         <block_index>: Change type to gdb::optional.
2477         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2478         change type of BLOCK_INDEX parameter to gdb::optional.
2479         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2480         (dw2_lookup_symbol): Don't pass argument for
2481         WANT_SPECIFIC_BLOCK.
2482         (dw2_expand_symtabs_for_function): Don't pass argument for
2483         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2484         (class dw2_debug_names_iterator)
2485         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2486         parameter, change BLOCK_INDEX type to gdb::optional.
2487         <m_want_specific_block>: Remove.
2488         <m_block_index>: Change type to gdb::optional.
2489         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2490         gdb::optional.  Re-write in function of gdb::optional.
2491         (dw2_debug_names_lookup_symbol): Don't pass argument for
2492         WANT_SPECIFIC_BLOCK.
2493         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2494         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2495         BLOCK_INDEX.
2496
2497 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2498
2499         * NEWS: Mention changes to "info sources" command.
2500
2501 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2502
2503         * symtab.c (filename_partial_match_opts): New struct type.
2504         (struct output_source_filename_data): New members
2505         regexp, c_regexp, partial_match.
2506         (output_source_filename): Use new members to decide to print file.
2507         (info_sources_option_defs): New variable.
2508         (make_info_sources_options_def_group, print_info_sources_header,
2509         info_sources_command_completer):
2510         New functions.
2511         (info_sources_command): Read new optional arguments.
2512         (_initialize_symtab): Update info sources help.
2513
2514 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2515
2516         * ada-lang.c (exception_support_info_v0): Renamed from...
2517         (default_exception_support_info): ... this.  Create new
2518         definition for v1.
2519         (ada_has_this_exception_support): Look up catch_handlers_sym.
2520         (ada_exception_support_info_sniffer): Try v0 after default.
2521
2522 2019-08-01  Tom Tromey  <tromey@adacore.com>
2523
2524         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2525         gdbarch.h.
2526
2527 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2528
2529         * s12z-tdep.c: Fix include path for s12z-opc.h.
2530
2531 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2532
2533         * NEWS: Require GNU make 3.82.
2534
2535 2019-07-16  Tom Tromey  <tom@tromey.com>
2536
2537         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2538         declare.
2539
2540 2019-07-30  Tom Tromey  <tromey@adacore.com>
2541
2542         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2543
2544 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2545
2546         * printcmd.c (print_address_symbolic): Print negative offsets.
2547         (build_address_symbolic): Force signed arithmetic when computing
2548         offset.
2549
2550 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2551
2552         PR/24474: Add a function to lookup static variables.
2553         * NEWS: Mention this new function.
2554         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2555         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2556         * python/python.c (python_GdbMethods): Add new function.
2557
2558 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2559
2560         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2561         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2562         (objfpy_lookup_static_symbol): New function.
2563         (objfile_object_methods): Add new functions.
2564
2565 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2566
2567         * NEWS: Mention 'set|show print frame-info'.  Mention new
2568         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2569         backtrace argument.  Mention that python frame filtering code
2570         is now consistent with what 'backtrace' command prints.
2571
2572 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2573
2574         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2575         comments.
2576         (print_frame_info_auto, print_frame_info_source_line,
2577         print_frame_info_location, print_frame_info_source_and_location,
2578         print_frame_info_location_and_address, print_frame_info_short_location):
2579         New declarations.
2580         (struct frame_print_options): New member print_frame_info.
2581         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2582         * stack.h (get_user_print_what_frame_info): New declaration.
2583         (frame_show_address): New declaration.
2584         * stack.c (print_frame_arguments_choices): New value 'presence'.
2585         (print_frame_info_auto, print_frame_info_source_line,
2586         print_frame_info_location, print_frame_info_source_and_location,
2587         print_frame_info_location_and_address, print_frame_info_short_location,
2588         print_frame_info_choices, print_frame_info_print_what): New definitions.
2589         (print_frame_args): Only print dots for args if print frame-arguments
2590         is 'presence'.
2591         (frame_print_option_defs): New element for "frame-info".
2592         (get_user_print_what_frame_info): New function.
2593         (frame_show_address): Make non static.  Move comment to stack.h.
2594         (print_frame_info_to_print_what): New function.
2595         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2596         to decide what to print.
2597         (backtrace_command_1): Handle the new print_frame_arguments_presence
2598         value.
2599         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2600         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2601         (py_print_frame): In non-mi mode, use LOCATION as default for
2602         print_what, similarly to frame information printed directly by
2603         backtrace command. Handle frame-info user option in non MI mode.
2604
2605 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2606
2607         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2608         Add case for debugging 32-bit target on 64-bit host.  Revise
2609         comment.
2610
2611 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2612
2613         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2614         instead of find_function_entry_range_from_pc.
2615
2616 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2617
2618         * stack.c (find_frame_funname): Remove code which preferred
2619         minsym over symtab sym in "certain pathological cases".
2620
2621         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2622         parameter.  Change type of "do_demangle" to bool.
2623         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2624         Pass suitable "prefer_sym_over_minsym" flag to
2625         build_address_symbolic().  Don't output "+" for negative offsets.
2626         * printcmd.c (print_address_symbolic): Update invocation of
2627         build_address_symbolic to include a "prefer_sym_over_minsym"
2628         flag.
2629         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2630         Restrict cases in which use of minimal symbol is preferred to that
2631         of a found symbol.  Update comments.
2632
2633         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2634         for entry pc when entry pc is out of range for that FDE.
2635
2636 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2637
2638         PR gdb/24839:
2639         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2640         type.
2641
2642 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2643
2644         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2645         this function's Python signature.
2646
2647
2648 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2649
2650         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2651         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2652         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2653         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2654         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2655
2656
2657 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2658
2659         * h8300-tdep.c (h8300_register_name_common): New.
2660         h8300_register_name): Use h8300_register_name_common.
2661         (h8300s_register_name): Likewise.
2662         (h8300sx_register_name): Likewise.
2663         (h8300h_register_nam): New.
2664         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2665
2666
2667 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2668
2669         * arm-tdep.c (arm_skip_cmse_entry): New function.
2670         (arm_is_sgstubs_section): New function.
2671         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2672
2673 2019-07-22  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2676         Don't self-assign.
2677
2678 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2681         type_print.
2682
2683 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2684
2685         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2686         so that GDB doesn't match any msymbols when searching in the
2687         TYPES_DOMAIN.
2688         (print_symbol_info): Print using typedef_print or type_print based
2689         on the type of the symbol.  Add updated FIXME comment moved from...
2690         (_initialize_symtab): ... move and update FIXME comment to above.
2691
2692 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * NEWS: Mention adding -q option to "info types".
2695         * symtab.c (struct info_types_options): New struct.
2696         (info_types_options_defs): New variable.
2697         (make_info_types_options_def_group): New function.
2698         (info_types_command): Use gdb::option framework to parse options.
2699         (info_types_command_completer): New function.
2700         (_initialize_symtab): Extend the help text on "info types" and
2701         register command completer.
2702
2703 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2704
2705         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2706         (lookup_symbol_in_objfile): Change int to block_enum and add a
2707         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2708
2709 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2710
2711         * MAINTAINERS (Write After Approval): Add self.
2712
2713 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2714
2715         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2716         instruction to the dummy code region.
2717
2718 2019-07-19  Tom Tromey  <tromey@adacore.com>
2719
2720         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2721         (ARGSUSED, PARAMS, __func__): Remove rules.
2722
2723 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2724
2725         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2726         * features/arm/arm-with-iwmmxt.c: Remove.
2727         * features/arm/arm-with-iwmmxt.xml: Remove.
2728         * features/arm/arm-with-m-fpa-layout.c: Remove.
2729         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2730         * features/arm/arm-with-m-vfp-d16.c: Remove.
2731         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2732         * features/arm/arm-with-m.c: Remove.
2733         * features/arm/arm-with-m.xml: Remove.
2734         * features/arm/arm-with-neon.c: Remove.
2735         * features/arm/arm-with-neon.xml: Remove.
2736         * features/arm/arm-with-vfpv2.c: Remove.
2737         * features/arm/arm-with-vfpv2.xml: Remove.
2738         * features/arm/arm-with-vfpv3.c: Remove.
2739         * features/arm/arm-with-vfpv3.xml: Remove.
2740
2741 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2742
2743         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2744
2745 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2746
2747         * arch/aarch32.c (aarch32_create_target_description): Create
2748         target descriptions using features.
2749         * arch/arm.c (arm_create_target_description)
2750         (arm_create_mprofile_target_description): Likewise.
2751         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2752
2753 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2754
2755         * Makefile.in: Add new files.
2756         * aarch32-tdep.c: New file.
2757         * aarch32-tdep.h: New file.
2758         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2759         Call aarch32_read_description.
2760         * arch/aarch32.c: New file.
2761         * arch/aarch32.h: New file.
2762         * arch/arm.c (arm_create_target_description)
2763         (arm_create_mprofile_target_description): New function.
2764         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2765         (arm_create_target_description)
2766         (arm_create_mprofile_target_description): New declaration.
2767         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2768         read_description functions.
2769         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2770         Likewise.
2771         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2772         * arm-tdep.c (tdesc_arm_list): New variable.
2773         (arm_register_g_packet_guesses): Call create description functions.
2774         (arm_read_description) (arm_read_mprofile_description): New
2775         function.
2776         * arm-tdep.h (arm_read_description)
2777         (arm_read_mprofile_description): Add declaration.
2778         * configure.tgt: Add new files.
2779
2780 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2781
2782         * top.c (new_ui_command): Open specified terminal just once.
2783
2784 2019-07-18  Tom Tromey  <tromey@adacore.com>
2785
2786         * symtab.c (main_name): Constify return type.
2787         * symfile.c (set_initial_language): Update.
2788         * symtab.h (main_name): Constify return type.
2789
2790 2019-07-17  Tom Tromey  <tom@tromey.com>
2791
2792         * tui/tui-winsource.c (tui_update_source_window)
2793         (tui_update_source_window_as_is)
2794         (tui_update_source_windows_with_line): Remove return.
2795         * tui/tui-disasm.c (tui_show_disassem)
2796         (tui_show_disassem_and_update_source): Remove return.
2797         * tui/tui.c (tui_reset): Remove return.
2798         * tui/tui-wingeneral.c
2799         (tui_check_and_display_highlight_if_needed): Remove return.
2800
2801 2019-07-17  Tom Tromey  <tom@tromey.com>
2802
2803         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2804
2805 2019-07-17  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-winsource.h (struct tui_exec_info_window)
2808         (struct tui_source_window_base): Move from tui-data.h.
2809         * tui/tui-winsource.c: Move many method definitions from
2810         elsewhere.  Remove "structuring" comments.
2811         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2812         (tui_source_window_base::refresh_window): Move to
2813         tui-winsource.c.
2814         * tui/tui-win.c (tui_source_window_base::refresh_all)
2815         (tui_source_window_base::update_tab_width)
2816         (tui_source_window_base::set_new_height)
2817         (tui_source_window_base::do_make_visible_with_new_height): Move to
2818         tui-winsource.c.
2819         * tui/tui-source.h: Update.
2820         * tui/tui-source.c (tui_source_window_base::reset): Move to
2821         tui-winsource.c.
2822         * tui/tui-disasm.h: Update.
2823         * tui/tui-data.h (struct tui_exec_info_window): Move to
2824         tui-winsource.h.
2825         (struct tui_source_window_base): Likewise.
2826         * tui/tui-data.c (tui_source_window_base::clear_detail)
2827         (tui_source_window_base, ~tui_source_window_base): Move to
2828         tui-winsource.c.
2829
2830 2019-07-17  Tom Tromey  <tom@tromey.com>
2831
2832         * tui/tui-win.c (tui_resize_all)
2833         (tui_source_window_base::update_tab_width)
2834         (tui_adjust_win_heights): Update.
2835         (tui_win_info::make_invisible_and_set_new_height): Rename from
2836         make_invisible_and_set_new_height.
2837         * tui/tui-data.h (struct tui_win_info)
2838         <make_invisible_and_set_new_height>: New method.
2839
2840 2019-07-17  Tom Tromey  <tom@tromey.com>
2841
2842         * tui/tui.c: Update.
2843         * tui/tui-source.h (struct tui_source_window): Move from
2844         tui-data.h.
2845         * tui/tui-layout.c: Update.
2846         * tui/tui-disasm.c: Update.
2847         * tui/tui-data.h (struct tui_source_window): Move to
2848         tui-source.h.
2849
2850 2019-07-17  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2853         tui-data.h.
2854         * tui/tui-data.h (struct tui_disasm_window): Move to
2855         tui-disasm.h.
2856
2857 2019-07-17  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-regs.h (struct tui_data_item_window): Move from
2860         tui-data.h.
2861         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2862         * tui/tui-data.h (struct tui_data_item_window): Move to
2863         tui-regs.h.
2864         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2865
2866 2019-07-17  Tom Tromey  <tom@tromey.com>
2867
2868         * tui/tui.c: Update.
2869         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2870         (tui_cmd_window::max_height): Move to tui-command.c.
2871         * tui/tui-layout.c: Update.
2872         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2873         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2874         tui-command.c.
2875         * tui/tui-command.h (struct tui_cmd_window): Move from
2876         tui-data.h.
2877         * tui/tui-command.c: Remove "structuring" comments.
2878         (tui_cmd_window::clear_detail)
2879         (tui_cmd_window::do_make_visible_with_new_height)
2880         (tui_cmd_window::max_height): Move from elsewhere.
2881
2882 2019-07-17  Tom Tromey  <tom@tromey.com>
2883
2884         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2885         Now static.
2886         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2887         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2888
2889 2019-07-17  Tom Tromey  <tom@tromey.com>
2890
2891         * tui/tui.c: Update.
2892         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2893         tui-regs.c.
2894         * tui/tui-windata.h: Remove file.
2895         * tui/tui-windata.c: Remove file.
2896         * tui/tui-win.c (tui_data_window::set_new_height)
2897         (tui_data_window::do_make_visible_with_new_height): Move to
2898         tui-regs.c.
2899         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2900         * tui/tui-regs.c: Remove "structuring" comments.
2901         (tui_data_window::first_data_item_displayed)
2902         (tui_data_window::delete_data_content_windows)
2903         (tui_data_window::erase_data_content)
2904         (tui_data_window::display_all_data)
2905         (tui_data_window::refresh_all)
2906         (tui_data_window::do_scroll_vertical)
2907         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2908         (tui_data_window::do_make_visible_with_new_height)
2909         (tui_data_window::refresh_window): Move from elsewhere.
2910         (_initialize_tui_regs): Move to end of file.
2911         * tui/tui-layout.c: Update.
2912         * tui/tui-hooks.c: Update.
2913         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2914         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2915         tui-regs.c.
2916         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2917
2918 2019-07-17  Tom Tromey  <tom@tromey.com>
2919
2920         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2921         seen.
2922
2923 2019-07-17  Tom Tromey  <tom@tromey.com>
2924
2925         * tui/tui-win.c (tui_source_window_base::set_new_height)
2926         (tui_source_window_base::do_make_visible_with_new_height): Use
2927         m_has_locator field directly.
2928         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2929         method.
2930         (struct tui_source_window_base) <has_locator>: Likewise.
2931
2932 2019-07-17  Tom Tromey  <tom@tromey.com>
2933
2934         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2935         Don't declare.
2936         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2937         Remove.
2938         * tui/tui-win.c (tui_source_window_base::set_new_height)
2939         (tui_source_window_base::set_new_height)
2940         (make_invisible_and_set_new_height)
2941         (tui_source_window_base::do_make_visible_with_new_height)
2942         (tui_source_window_base::do_make_visible_with_new_height):
2943         Update.
2944         * tui/tui-layout.c (show_source_disasm_command, show_data)
2945         (show_source_or_disasm_and_command): Update.
2946         * tui/tui-layout.c (show_layout): Update.
2947
2948 2019-07-17  Tom Tromey  <tom@tromey.com>
2949
2950         * tui/tui-layout.c (make_data_window): Remove.
2951         (show_data): Unify creation and re-initialization cases.
2952
2953 2019-07-17  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-layout.c (make_source_window, make_disasm_window):
2956         Remove.
2957         (show_data): Unify creation and re-initialization cases.
2958
2959 2019-07-17  Tom Tromey  <tom@tromey.com>
2960
2961         * tui/tui-layout.c (make_command_window): Remove.
2962         (show_source_disasm_command, show_source_or_disasm_and_command):
2963         Unify creation and re-initialization cases.
2964
2965 2019-07-17  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2968         creation and re-initialization cases.
2969
2970 2019-07-17  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-regs.c (tui_get_register): Return void.
2973
2974 2019-07-17  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2977         Simplify.
2978
2979 2019-07-17  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2982         resetting.
2983
2984 2019-07-17  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2987         * tui/tui-regs.c (tui_reg_layout): New function.
2988         (tui_show_registers, tui_reg_command): Use it.
2989         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2990         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2991         parameters.
2992         (tui_layout_command): Remove.
2993
2994 2019-07-17  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-layout.h (tui/tui-layout): Return void.
2997         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2998
2999 2019-07-17  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-layout.c (show_source_disasm_command, show_data):
3002         Update.
3003         (reset_locator): Remove.
3004         (show_source_or_disasm_and_command): Update.
3005
3006 2019-07-17  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-source.c (tui_source_window_base::reset): Remove
3009         win_type parameter.
3010         * tui/tui-layout.c (make_command_window, make_source_window)
3011         (make_disasm_window, make_data_window)
3012         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3013         (reset_locator, show_source_or_disasm_and_command): Update.
3014         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3015         win_type parameter.
3016         (struct tui_source_window_base) <reset>: Likewise.
3017
3018 2019-07-17  Tom Tromey  <tom@tromey.com>
3019
3020         * tui/tui-layout.c (show_source_disasm_command): Use
3021         reset_locator.
3022         (reset_locator): New function.
3023         (init_and_make_win): Remove.
3024         (show_source_or_disasm_and_command): Use reset_locator.
3025
3026 2019-07-17  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3029         condition.
3030         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3031         Remove condition.
3032         * tui/tui-source.c (tui_source_window_base::reset): New method.
3033         * tui/tui-layout.c (make_command_window): Don't call
3034         init_and_make_win.
3035         (make_source_window, make_disasm_window): Don't call
3036         make_source_or_disasm_window.
3037         (make_data_window): Don't call init_and_make_win.  Change calling
3038         convention.
3039         (show_source_disasm_command, show_data): Simplify.
3040         (make_source_or_disasm_window): Remove.
3041         (show_source_or_disasm_and_command): Simplify.
3042         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3043         (struct tui_source_window_base) <reset>: Likewise.
3044         <execution_info>: Remove initializer.
3045         * tui/tui-data.c (tui_source_window_base): Initialize
3046         execution_info.
3047
3048 2019-07-17  Tom Tromey  <tom@tromey.com>
3049
3050         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3051         variable.
3052
3053 2019-07-17  Tom Tromey  <tom@tromey.com>
3054
3055         * tui/tui.c (tui_rl_other_window): Update.
3056         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3057         superclass method first.  Always iterate over regs_content.
3058         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3059         method.
3060         * tui/tui-win.c (tui_set_focus_command): Update.
3061
3062 2019-07-17  Tom Tromey  <tom@tromey.com>
3063
3064         * tui/tui-win.c (tui_set_focus_command): Rename from
3065         tui_set_focus.  Call tui_enable.
3066         (tui_set_focus_command): Remove.
3067
3068 2019-07-17  Tom Tromey  <tom@tromey.com>
3069
3070         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3071         refresh_window.
3072         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3073         touchwin.
3074         (tui_data_window::refresh_window): Call refresh_window on data
3075         items.  Always call superclass refresh_window.
3076         (tui_win_info::refresh): Remove.
3077         (tui_source_window_base::refresh_window): Update.
3078         (tui_refresh_all): Update.
3079         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3080         refresh_window.
3081         (show_source_or_disasm_and_command): Likewise.
3082         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3083         (struct tui_source_window_base) <refresh>: Likewise.
3084
3085 2019-07-17  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-winsource.c (tui_clear_source_content)
3088         (tui_show_source_content): Update.
3089         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3090         whether content is empty.
3091         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3092         Remove.
3093
3094 2019-07-17  Tom Tromey  <tom@tromey.com>
3095
3096         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3097         window's contents.
3098         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3099         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3100
3101 2019-07-17  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3104         (struct tui_data_item_window): Update.
3105
3106 2019-07-17  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3109         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3110         defines.
3111
3112 2019-07-17  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-winsource.h (tui_erase_source_content)
3115         (tui_clear_source_content): Remove "display_prompt" parameter.
3116         * tui/tui-winsource.c (tui_update_source_window_as_is)
3117         (tui_update_source_windows_with_addr): Update.
3118         (tui_clear_source_content): Remove "display_prompt" parameter.
3119         (tui_erase_source_content): Likewise.  Simplify.
3120         (tui_show_source_content): Update.
3121         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3122         * tui/tui-stack.c (tui_show_frame_info): Update.
3123         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3124         Remove defines.
3125
3126 2019-07-17  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3129         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3130         parameter.
3131         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3132         parameter.
3133
3134 2019-07-17  Tom Tromey  <tom@tromey.com>
3135
3136         * tui/tui-winsource.c (tui_clear_source_content)
3137         (tui_show_source_content, tui_show_exec_info_content)
3138         (tui_clear_exec_info_content): Update.
3139         * tui/tui-stack.c (tui_show_locator_content): Update.
3140         (tui_show_frame_info): Update.
3141         * tui/tui-source.h (tui_source_window): Don't declare.
3142         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3143         from tui_source_is_displayed.
3144         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3145         Remove field.
3146         (struct tui_source_window_base) <content_in_use>: New field.  Now
3147         bool.
3148         (struct tui_source_window) <showing_source_p>: New method.
3149         (TUI_SRC_WIN): Change cast.
3150         * tui/tui-data.c (tui_initialize_static_data): Update.
3151
3152 2019-07-17  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3155         location_matches_p.
3156         * tui/tui-source.c (tui_source_window::location_matches_p): New
3157         method.
3158         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3159         method.
3160         * tui/tui-data.h (struct tui_source_window_base)
3161         <location_matches_p>: New method.
3162         (struct tui_source_window, struct tui_disasm_window)
3163         <location_matches_p>: Likewise.
3164
3165 2019-07-17  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-win.c (tui_set_win_height_command): Rename from
3168         tui_set_win_height.
3169         (tui_set_win_height_command): Remove.
3170
3171 2019-07-17  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-source.c (tui_source_window): New constructor.  Add
3174         observer.
3175         (~tui_source_window): New destructor.
3176         (tui_source_window::style_changed): New method.
3177         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3178         (tui_attach_detach_observers): Update.
3179         * tui/tui-data.h (struct tui_source_window): Make constructor not
3180         inline.  Add destructor.
3181         (struct tui_source_window) <style_changed>: New method.
3182         <m_observable>: New member.
3183
3184 2019-07-17  Tom Tromey  <tom@tromey.com>
3185
3186         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3187         * tui/tui-win.c (tui_resize_all): Fix typo.
3188
3189 2019-07-17  Tom Tromey  <tom@tromey.com>
3190
3191         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3192         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3193         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3194         * tui/tui-win.c (window_name_completer): Use foreach.
3195         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3196         (update_tab_width): Likewise.
3197         * tui/tui-layout.c (show_layout): Update.
3198         * tui/tui-data.h (class tui_window_iterator): New.
3199         (struct all_tui_windows): New.
3200         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3201
3202 2019-07-17  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3205         parameter.  Don't reference globals.
3206         (tui_reg_command): Update.
3207
3208 2019-07-17  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-regs.c (tui_show_registers): Simplify.
3211
3212 2019-07-17  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-regs.c (tui_show_registers): Update.
3215         (tui_show_register_group): Add win_info parameter.
3216
3217 2019-07-17  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3220         Rename from tui_display_reg_element_at_line.
3221         (tui_data_window::display_registers_from_line): Update.
3222         * tui/tui-data.h (struct tui_data_window)
3223         <display_reg_element_at_line>: New method.
3224
3225 2019-07-17  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-regs.h (tui_display_registers_from)
3228         (tui_display_registers_from_line): Don't declare.
3229         * tui/tui-windata.c (tui_data_window::display_all_data)
3230         (tui_data_window::refresh_all)
3231         (tui_data_window::do_scroll_vertical): Update.
3232         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3233         from tui_display_registers_from.
3234         (tui_display_reg_element_at_line): Update.
3235         (tui_data_window::display_registers_from_line): Rename from
3236         tui_display_registers_from_line.
3237         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3238         display_registers_from_line>: New methods.
3239
3240 2019-07-17  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3243         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3244         from tui_erase_data_content.
3245         (tui_data_window::display_all_data)
3246         (tui_data_window::refresh_all)
3247         (tui_data_window::do_scroll_vertical): Update.
3248         * tui/tui-regs.c (tui_show_registers): Update.
3249         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3250         New method.
3251
3252 2019-07-17  Tom Tromey  <tom@tromey.com>
3253
3254         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3255         declare.
3256         * tui/tui-windata.c
3257         (tui_data_window::delete_data_content_windows): Rename from
3258         tui_delete_data_content_windows.
3259         (tui_data_window::display_all_data)
3260         (tui_data_window::do_scroll_vertical): Update.
3261         * tui/tui-data.h (struct tui_data_window)
3262         <delete_data_content_windows>: New method.
3263
3264 2019-07-17  Tom Tromey  <tom@tromey.com>
3265
3266         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3267         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3268
3269 2019-07-17  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3272         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3273         from tui_display_all_data.
3274         * tui/tui-win.c
3275         (tui_data_window::do_make_visible_with_new_height): Update.
3276         * tui/tui-regs.c (tui_show_registers): Update.
3277         * tui/tui-layout.c (tui_set_layout): Update.
3278         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3279         method.
3280
3281 2019-07-17  Tom Tromey  <tom@tromey.com>
3282
3283         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3284         * tui/tui-windata.c (tui_display_data_from): Remove.
3285         (tui_data_window::refresh_all): Update.
3286
3287 2019-07-17  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3290         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3291         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3292         tui_display_registers_from_line.
3293         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3294         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3295         "force_display" parameter.
3296
3297 2019-07-17  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3300         declare.
3301         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3302         Rename from tui_first_reg_element_no_inline.
3303         (tui_display_reg_element_at_line)
3304         (tui_display_registers_from_line): Update.
3305         * tui/tui-data.h (struct tui_data_window)
3306         <first_reg_element_no_inline>: New method.
3307
3308 2019-07-17  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-windata.c (tui_display_data_from)
3311         (tui_data_window::do_scroll_vertical): Update.
3312         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3313         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3314         Rename from tui_line_from_reg_element_no.
3315         (tui_display_registers_from_line): Update.
3316         * tui/tui-data.h (struct tui_data_window)
3317         <line_from_reg_element_no>: New method.
3318
3319 2019-07-17  Tom Tromey  <tom@tromey.com>
3320
3321         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3322         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3323         tui_last_regs_line_no.
3324         (tui_display_reg_element_at_line)
3325         (tui_display_registers_from_line): Update.
3326         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3327         method.
3328
3329 2019-07-17  Tom Tromey  <tom@tromey.com>
3330
3331         PR tui/24722:
3332         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3333         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3334         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3335         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3336         (tui_update_breakpoint_info): Likewise.
3337         * tui/tui-hooks.c (tui_event_create_breakpoint)
3338         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3339         Update.
3340
3341 2019-07-17  Tom Tromey  <tom@tromey.com>
3342
3343         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3344
3345 2019-07-17  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-winsource.c (tui_update_source_window_as_is)
3348         (tui_update_source_windows_with_addr): Update.
3349         * tui/tui-source.h (tui_set_source_content)
3350         (tui_show_symtab_source): Add "win_info" parameter.
3351         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3352         parameter.
3353         (tui_show_symtab_source): Likewise.
3354
3355 2019-07-17  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-wingeneral.c
3358         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3359
3360 2019-07-17  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3363         (struct tui_cmd_window) <can_scroll>: New method.
3364         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3365         method.
3366
3367 2019-07-17  Tom Tromey  <tromey@adacore.com>
3368
3369         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3370         do_field_signed>: Rename.  Change type of "value".
3371         * ui-out.c (ui_out::field_signed): Rename from field_int.
3372         Change type of "value".
3373         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3374         type of "value".
3375         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3376         do_field_int.  Change type of "value".
3377         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3378         do_field_int.  Change type of "value".
3379         * tracepoint.c (trace_status_mi, tfind_1)
3380         (print_one_static_tracepoint_marker): Update.
3381         * thread.c (print_thread_info_1, print_selected_thread_frame):
3382         Update.
3383         * stack.c (print_frame, print_frame_info): Update.
3384         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3385         Update.
3386         * source.c (print_source_lines_base): Update.
3387         * skip.c (info_skip_command): Update.
3388         * record-btrace.c (btrace_ui_out_decode_error)
3389         (btrace_call_history_src_line): Update.
3390         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3391         Update.
3392         * progspace.c (print_program_space): Update.
3393         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3394         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3395         do_field_int.  Change type of "value".
3396         * mi/mi-out.c (mi_ui_out::do_table_begin)
3397         (mi_ui_out::do_table_header): Update.
3398         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3399         type of "value".
3400         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3401         (mi_cmd_data_list_changed_registers, output_register)
3402         (mi_cmd_data_read_memory, mi_load_progress)
3403         (mi_cmd_trace_frame_collected): Update.
3404         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3405         Update.
3406         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3407         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3408         (mi_cmd_var_list_children, varobj_update_one): Update.
3409         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3410         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3411         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3412         * inferior.c (print_inferior): Update.
3413         * gdb_bfd.c (print_one_bfd): Update.
3414         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3415         Update.
3416         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3417         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3418         do_field_int.  Change type of "value".
3419         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3420         do_field_int.  Change type of "value".
3421         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3422         (print_one_breakpoint_location, print_it_catch_fork)
3423         (print_one_catch_fork, print_it_catch_vfork)
3424         (print_one_catch_vfork, print_it_catch_solib)
3425         (print_it_catch_exec, print_it_ranged_breakpoint)
3426         (print_mention_watchpoint, print_mention_masked_watchpoint)
3427         (bkpt_print_it, update_static_tracepoint): Update.
3428         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3429         * break-catch-syscall.c (print_it_catch_syscall): Update.
3430         * ada-tasks.c (print_ada_task_info): Update.
3431         * ada-lang.c (print_it_exception, print_mention_exception):
3432         Update.
3433
3434 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3435
3436         PR breakpoints/24541
3437         * gdbarch.c: Regenerate.
3438         * gdbarch.h: Regenerate.
3439         * gdbarch.sh: Adjust return type and parameter types for
3440         'stap_adjust_register'.
3441         (i386_stap_adjust_register): Adjust signature and return new
3442         register name.
3443         * stap-probe.c (stap_parse_register_operand): Adjust use of
3444         'gdbarch_stap_adjust_register'.
3445
3446 2019-07-17  Tom Tromey  <tromey@adacore.com>
3447
3448         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3449         declare VEC.
3450         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3451         std::vector.
3452         (struct s390_process_info): Add initializers.
3453         (s390_add_process): Use new.
3454         (s390_linux_nat_target::low_forget_process): Use delete.
3455         (s390_linux_nat_target::low_new_fork)
3456         (s390_linux_nat_target::stopped_by_watchpoint)
3457         (s390_linux_nat_target::low_prepare_to_resume)
3458         (s390_linux_nat_target::insert_watchpoint)
3459         (s390_linux_nat_target::insert_hw_breakpoint)
3460         (s390_linux_nat_target::remove_watchpoint)
3461         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3462
3463 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3464
3465         * aarch64-fbsd-nat.c: Include regcache.h.
3466         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3467         argument.
3468         (aarch64_fbsd_nat_target::fetch_registers)
3469         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3470         variable.
3471         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3472
3473 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3474
3475         * fbsd-nat.c: Include gdbarch.h.
3476
3477 2019-07-15  Tom Tromey  <tromey@adacore.com>
3478
3479         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3480
3481 2019-07-15  Tom Tromey  <tromey@adacore.com>
3482
3483         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3484         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3485         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3486         * cli-out.c (cli_ui_out::do_field_int): New method.
3487         * ui-out.c (ui_out::field_unsigned): New method.
3488         * symfile.c (generic_load): Use field_unsigned.
3489         (print_transfer_performance): Likewise.
3490         * record-btrace.c (ui_out_field_uint): Remove.
3491         (btrace_call_history_insn_range, btrace_call_history): Use
3492         field_unsigned.
3493         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3494         field_unsigned.
3495         * ui-out.h (class ui_out) <field_unsigned>: New method.
3496         <do_field_unsigned>: Likewise.
3497
3498 2019-07-15  Tom Tromey  <tromey@adacore.com>
3499
3500         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3501         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3502         * target.c (flash_erase_command): Use field_string.
3503         * infrun.c (print_signal_received_reason): Use field_string.
3504         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3505         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3506         field_string.
3507         * ada-tasks.c (print_ada_task_info): Use field_string.
3508
3509 2019-07-15  Tom Tromey  <tromey@adacore.com>
3510
3511         * target.c (flash_erase_command): Use field_core_addr.
3512         * symfile.c (generic_load): Use field_core_addr.
3513         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3514         Use field_core_addr.
3515         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3516         field_core_addr.
3517
3518 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3519
3520         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3521         value if its desired type is smaller than a CORE_ADDR and signed.
3522
3523 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3524
3525         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3526         of changes to field names, and use new is_reference field to
3527         decide if a property is a reference or not.
3528         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3529         field.
3530         (struct dwarf2_property_baton): Update header comment, rename
3531         'referenced_type' to 'property_type' and update comments.
3532         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3533         default property type, store in property baton, update to take
3534         accound of renamed field.
3535         (read_func_scope): Update call to attr_to_dynamic_prop.
3536         (read_array_type): Likewise.
3537         (dwarf2_per_cu_addr_sized_int_type): New function.
3538         (read_subrange_index_type): Move type finding code to
3539         dwarf2_per_cu_addr_sized_int_type.
3540         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3541         (dwarf2_per_cu_addr_type): New function.
3542         (set_die_type): Update calls to attr_to_dynamic_prop.
3543
3544 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * dwarf2read.c (read_subrange_index_type): New function.
3547         (read_subrange_type): Move code into new function and call it.
3548         * gdbtypes.c (create_range_type): Add some asserts.
3549
3550 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3551
3552         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3553         update return statements.
3554         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3555         declaration, and update comment to match.
3556         * gdbtypes.c (resolve_dynamic_array): Update call to
3557         dwarf2_evaluate_property to match new return type.
3558
3559 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * valarith.c (value_subscripted_rvalue): Change lowerbound
3562         parameter type from int to LONGEST.
3563         * value.h (value_subscripted_rvalue): Likewise in declaration.
3564
3565 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3566
3567         * cli/cli-utils.c (info_print_command_completer): New function.
3568         * cli/cli-utils.h: Add 'completer.h' include, and forward
3569         declaration for 'struct cmd_list_element'.
3570         (info_print_command_completer): Declare.
3571         * stack.c (_initialize_stack): Add completer for 'info locals' and
3572         'info args'.
3573         * symtab.c (_initialize_symtab): Add completer for 'info
3574         variables' and 'info functions'.
3575         * NEWS: Mention completion for additional info commands.
3576
3577 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3578
3579         * cli/cli-utils.c (extract_info_print_args): Delete.
3580         (extract_arg_maybe_quoted): Delete.
3581         (info_print_options_defs): New variable.
3582         (make_info_print_options_def_group): New function.
3583         (extract_info_print_options): Define new function.
3584         * cli/cli-utils.h (extract_info_print_args): Delete.
3585         (struct info_print_options): New structure.
3586         (extract_info_print_options): Declare new function.
3587         * stack.c (info_locals_command): Update to use new
3588         extract_info_print_options, also add a header comment.
3589         (info_args_command): Likewise.
3590         * symtab.c (info_variables_command): Likewise.
3591         (info_functions_command): Likewise.
3592
3593 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3594
3595         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3596         to extract string arguments.
3597         * common/common-utils.c (extract_string_maybe_quoted): New function.
3598         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3599
3600 2019-07-11  Tom Tromey  <tromey@adacore.com>
3601
3602         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3603         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3604         * top.h (gdbinit): Don't declare.
3605         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3606         into...
3607         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3608         * top.c (gdb_init): Don't call init_cli_cmds.
3609         (gdbinit): Remove.
3610         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3611
3612 2019-07-11  Tom Tromey  <tromey@adacore.com>
3613
3614         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3615         after it has been moved.
3616
3617 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3618
3619         * valops.c (value_must_coerce_to_target): Change return type to
3620         bool.
3621         * value.h (value_must_coerce_to_target): Likewise.
3622
3623 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3624
3625         * breakpoint.c (is_hardware_watchpoint): Remove
3626         forward-declaration.
3627         (is_masked_watchpoint): Change return type to bool.
3628         (is_tracepoint): Likewise.
3629         (is_breakpoint): Likewise.
3630         (is_hardware_watchpoint): Likewise.
3631         (is_watchpoint): Likewise.
3632         (is_no_memory_software_watchpoint): Likewise.
3633         (is_catchpoint): Likewise.
3634         (breakpoint_1): Make FILTER parameter's return type bool.
3635         is_masked_watchpoint): Change return type to bool.
3636         (save_breakpoints): Make FILTER parameter's return type bool.
3637         * breakpoint.h (is_breakpoint): Change return type to bool.
3638         (is_watchpoint): Likewise.
3639         (is_catchpoint): Likewise.
3640         (is_tracepoint): Likewise.
3641
3642 2019-07-10  Tom Tromey  <tom@tromey.com>
3643
3644         * defs.h: Don't include gdbarch.h.
3645         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3646         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3647         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3648         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3649         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3650         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3651         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3652         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3653         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3654         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3655         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3656         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3657         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3658         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3659         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3660         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3661         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3662         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3663         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3664         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3665         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3666         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3667         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3668         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3669         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3670         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3671         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3672
3673 2019-07-10  Tom Tromey  <tromey@adacore.com>
3674
3675         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3676         * breakpoint.c (init_ada_exception_breakpoint): Register as
3677         bp_catchpoint.
3678         (print_one_breakpoint_location, print_one_breakpoint): Use
3679         is_ada_exception_catchpoint.
3680         * ada-lang.c (class ada_catchpoint_location): Pass
3681         bp_loc_software_breakpoint to bp_location constructor.
3682         (is_ada_exception_catchpoint): New function.
3683
3684 2019-07-10  Tom Tromey  <tromey@adacore.com>
3685
3686         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3687         VEC.
3688         (struct arm_exidx_entry): New method operator<.
3689         (struct arm_exidx_data) <section_maps>: Change type.
3690         (arm_exidx_data_free): Remove.
3691         (arm_exidx_data_key): Change type.  Move lower.
3692         (arm_exidx_new_objfile): Update.
3693         (arm_compare_exidx_entries): Remove.
3694         (arm_find_exidx_entry, _initialize_arm_tdep)
3695
3696 2019-07-10  Tom Tromey  <tromey@adacore.com>
3697
3698         * solib-spu.c (ocl_program_data_key): Change type.
3699         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3700         Update.
3701
3702 2019-07-10  Tom Tromey  <tromey@adacore.com>
3703
3704         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3705         (struct solib_aix_inferior_data) <library_list>: Change type.
3706         (solib_aix_inferior_data_handle): Change type.
3707         (get_solib_aix_inferior_data): Update.
3708         (solib_aix_free_library_list): Remove.
3709         (library_list_start_library): Update.
3710         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3711         return type.
3712         (solib_aix_get_library_list)
3713         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3714         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3715
3716 2019-07-10  Tom Tromey  <tromey@adacore.com>
3717
3718         * solib-dsbt.c (struct dsbt_info): Add initializers.
3719         (solib_dsbt_pspace_data): Change type.
3720         (dsbt_pspace_data_cleanup): Remove.
3721         (get_dsbt_info, _initialize_dsbt_solib): Update.
3722
3723 2019-07-10  Tom Tromey  <tromey@adacore.com>
3724
3725         * spu-tdep.c (spu_overlay_data): Change type.
3726         (spu_get_overlay_table, spu_overlay_new_objfile)
3727         (_initialize_spu_tdep): Update.
3728
3729 2019-07-10  Tom Tromey  <tromey@adacore.com>
3730
3731         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3732         destructor.
3733         (dbx_objfile_data_key): Change type and declare later.
3734         (DBX_SYMFILE_INFO): Rewrite.
3735         * dbxread.c (dbx_objfile_data_key): Change type.
3736         (dbx_symfile_init): Update.
3737         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3738         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3739         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3740
3741 2019-07-10  Tom Tromey  <tromey@adacore.com>
3742
3743         * jit.c (jit_program_space_key): Change type.  Move lower.
3744         (get_jit_program_space_data): Update.
3745         (jit_program_space_data_cleanup): Remove.
3746         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3747         Update.
3748         (struct jit_program_space_data): Add initializers.
3749
3750 2019-07-10  Tom Tromey  <tromey@adacore.com>
3751
3752         * solib-darwin.c (struct darwin_info): Add initializers.
3753         (solib_darwin_pspace_data): Change type.
3754         (darwin_pspace_data_cleanup): Remove.
3755         (get_darwin_info, _initialize_darwin_solib): Update.
3756
3757 2019-07-10  Tom Tromey  <tromey@adacore.com>
3758
3759         * remote-sim.c (struct sim_inferior_data): Add initializers,
3760         constructor, and destructor.
3761         (sim_inferior_data_key): Change type.  Move lower.
3762         (check_for_duplicate_sim_descriptor): Update.
3763         (get_sim_inferior_data): Use new.  Update.
3764         (~sim_inferior_data_cleanup): Rename from
3765         sim_inferior_data_cleanup.  Simplify.
3766         (gdbsim_close_inferior, simulator_command)
3767         (sim_command_completer, _initialize_remote_sim): Update.
3768         (next_pid, INITIAL_PID): Move earlier.
3769
3770 2019-07-10  Tom Tromey  <tromey@adacore.com>
3771
3772         * python/python-internal.h (create_thread_object): Return
3773         gdbpy_ref.
3774         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3775         * python/py-inferior.c (struct threadlist_entry): Add
3776         constructor.
3777         <thread_obj>: Now a gdbpy_ref.
3778         (thread_to_thread_object): Update.
3779         (add_thread_object): Use new.
3780         (delete_thread_object): Use delete.
3781         (infpy_threads): Update.
3782         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3783         GIL.
3784
3785 2019-07-10  Tom Tromey  <tromey@adacore.com>
3786
3787         * valops.c (value_cast): Specialize error message for Ada.
3788
3789 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3790
3791         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3792
3793 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3794
3795         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3796         bpstat_should_step): Return bool, adjust comments.
3797         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3798         bpstat_should_step): Likewise.
3799
3800 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3801
3802         * features/Makefile: Use feature target descriptions for Arm.
3803         * features/arm/arm-core.c: Generate new file.
3804         * features/arm/arm-fpa.c: Likewise.
3805         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3806         * features/arm/arm-m-profile.c: Likewise.
3807         * features/arm/arm-vfpv2.c: Likewise.
3808         * features/arm/arm-vfpv3.c: Likewise.
3809         * features/arm/xscale-iwmmxt.c: Likewise.
3810         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3811
3812 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3813
3814         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3815         ptrace earlier.
3816
3817 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3818
3819         * features/aarch64-pauth.c: Regenerate.
3820
3821 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3822
3823         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3824         bool.
3825         (bpstat_what): Use false instead of 0.
3826
3827 2019-07-09  Pedro Alves  <palves@redhat.com>
3828
3829         * break-catch-throw.c (is_exception_catchpoint): New.
3830         * breakpoint.c (print_one_breakpoint_location): New parameter
3831         'raw_loc'.  Handle it.  Use
3832         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3833         looking at the breakpoint's type.
3834         (print_one_breakpoint): If handling "maint info breakpoints", also
3835         print locations of exception catchpoints.
3836         * breakpoint.h (is_exception_catchpoint): Declare.
3837
3838 2019-07-09  Pedro Alves  <palves@redhat.com>
3839
3840         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3841         "addr" field.
3842         (allocate_location_exception_catchpoint): New.
3843         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3844         (initialize_throw_catchpoint_ops): Install
3845         allocate_location_exception_catchpoint as allocate_location
3846         method.
3847         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3848         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3849         bp_loc_other.
3850         (breakpoint_address_is_meaningful): Delete.
3851         (bl_address_is_meaningful): New.
3852         (breakpoint_locations_match): Adjust comment.
3853         (bp_location_from_bp_type): New, factored out of...
3854         (bp_location::bp_location(breakpoint *)): ... this.
3855         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3856         factored out of...
3857         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3858         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3859         breakpoint_address_is_meaningful.
3860         (bp_locations_compare): Adjust comment.
3861         (update_global_location_list): Use bl_address_is_meaningful
3862         instead of breakpoint_address_is_meaningful.
3863         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3864         explicit.
3865         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3866         * python/py-breakpoint.c (bppy_get_location): No longer check
3867         whether location is null.
3868
3869 2019-07-09  Pedro Alves  <palves@redhat.com>
3870
3871         PR c++/15468
3872         * breakpoint.c (print_one_breakpoint_location): Remove
3873         single-location assert.
3874
3875 2019-07-09  Tom Tromey  <tom@tromey.com>
3876
3877         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3878         * configure: Rebuild.
3879         * configure.ac: Change common to gdbsupport.
3880         * gdbsupport: Rename from common.
3881         * acinclude.m4: Change common to gdbsupport.
3882         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3883         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3884         gdbsupport.
3885         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3886         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3887         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3888         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3889         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3890         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3891         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3892         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3893         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3894         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3895         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3896         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3897         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3898         coff-pe-read.c, command.h, compile/compile-c-support.c,
3899         compile/compile-c.h, compile/compile-cplus-symbols.c,
3900         compile/compile-cplus-types.c, compile/compile-cplus.h,
3901         compile/compile-loc2c.c, compile/compile.c, completer.c,
3902         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3903         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3904         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3905         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3906         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3907         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3908         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3909         features/aarch64-core.c, features/aarch64-fpu.c,
3910         features/aarch64-pauth.c, features/aarch64-sve.c,
3911         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3912         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3913         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3914         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3915         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3916         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3917         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3918         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3919         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3920         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3921         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3922         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3923         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3924         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3925         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3926         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3927         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3928         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3929         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3930         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3931         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3932         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3933         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3934         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3935         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3936         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3937         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3938         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3939         minsyms.c, mips-linux-tdep.c, namespace.h,
3940         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3941         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3942         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3943         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3944         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3945         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3946         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3947         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3948         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3949         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3950         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3951         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3952         procfs.c, producer.c, progspace.h, psymtab.h,
3953         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3954         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3955         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3956         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3957         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3958         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3959         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3960         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3961         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3962         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3963         target-memory.c, target.c, target.h, target/waitstatus.c,
3964         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3965         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3966         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3967         unittests/array-view-selftests.c,
3968         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3969         unittests/common-utils-selftests.c,
3970         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3971         unittests/format_pieces-selftests.c,
3972         unittests/function-view-selftests.c,
3973         unittests/lookup_name_info-selftests.c,
3974         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3975         unittests/mkdir-recursive-selftests.c,
3976         unittests/observable-selftests.c,
3977         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3978         unittests/parse-connection-spec-selftests.c,
3979         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3980         unittests/scoped_fd-selftests.c,
3981         unittests/scoped_mmap-selftests.c,
3982         unittests/scoped_restore-selftests.c,
3983         unittests/string_view-selftests.c, unittests/style-selftests.c,
3984         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3985         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3986         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3987         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3988         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3989         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3990
3991 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3992
3993         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3994         bool value.
3995         (decode_digits_ordinary): Set explicit_line field in sal.
3996         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3997         symtab_and_line that was set on an explicit line number in
3998         assembler code.  Do always update the recorded symtab and line if
3999         we do skip the prologue.
4000
4001 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * breakpoint.c (set_breakpoint_location_function): Remove
4004         explicit_loc parameter.
4005         (momentary_breakpoint_from_master): Update call to
4006         set_breakpoint_location_function.
4007         (add_location_to_breakpoint): Likewise.
4008
4009 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4010
4011         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4012         required features based on default bfd type when no specific bfd
4013         is present.
4014
4015 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4016
4017         * NEWS: Mention that GDB printf and eval commands can now print
4018         C-style and Ada-style convenience var strings without
4019         calling the inferior.
4020         * printcmd.c (printf_c_string): Locally print GDB internal var
4021         instead of transiting via the inferior.
4022         (printf_wide_c_string): Likewise.
4023
4024 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4025
4026         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4027
4028 2019-07-04  Tom Tromey  <tom@tromey.com>
4029
4030         PR tui/24724:
4031         * tui/tui-winsource.c (tui_clear_source_content): Update.
4032         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4033         (tui_update_breakpoint_info): Update.
4034         (tui_set_exec_info_content): Update.
4035         * tui/tui-source.c (tui_set_source_content_nil): Update.
4036         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4037         has_break.
4038         * tui/tui-data.h (enum tui_bp_flag): New.
4039         (tui_bp_flags): New enum flags type.
4040         (struct tui_source_element) <break_mode>: Change type.  Rename
4041         from has_break.
4042         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4043         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4044         constants.
4045         * tui/tui-winsource.h: Fix comment.
4046
4047 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4048
4049         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4050         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4051         (store_fpregs_to_thread)
4052         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4053         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4054         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4055         (IWMMXT_REGS_SIZE): Add define.
4056         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4057         (fetch_vfp_regs, store_vfp_regs)
4058         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4059         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4060
4061 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4062
4063         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4064         defines.
4065         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4066         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4067         (ARM_INT_REGISTER_SIZE): ...to this.
4068         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4069         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4070         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4071         (arm_linux_collect_gregset, supply_nwfpe_register)
4072         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4073         defines.
4074         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4075         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4076         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4077         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4078         (arm_return_in_memory, arm_store_return_value)
4079         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4080         (arm_record_ld_st_multiple): Likewise.
4081         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4082         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4083
4084 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4085
4086         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4087         AARCH64_DISPLACED_MODIFIED_INSNS.
4088         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4089         (aarch64_displaced_step_copy_insn): Likewise.
4090         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4091         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4092         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4093         ARM_DISPLACED_MODIFIED_INSNS.
4094         * arm-tdep.c (arm_gdbarch_init): Likewise.
4095         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4096         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4097         (struct arm_displaced_step_closure): Use
4098         ARM_DISPLACED_MODIFIED_INSNS.
4099
4100 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4101
4102         * features/Makefile: Remove unused xml files.
4103         * features/aarch64.xml: Remove.
4104         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4105         * features/i386/amd64-avx-avx512.xml: Remove.
4106         * features/i386/amd64-avx-linux.xml: Remove.
4107         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4108         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4109         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4110         * features/i386/amd64-avx-mpx.xml: Remove.
4111         * features/i386/amd64-avx.xml: Remove.
4112         * features/i386/amd64-linux.xml: Remove.
4113         * features/i386/amd64-mpx-linux.xml: Remove.
4114         * features/i386/amd64-mpx.xml: Remove.
4115         * features/i386/amd64.xml: Remove.
4116         * features/i386/i386-avx-avx512-linux.xml: Remove.
4117         * features/i386/i386-avx-avx512.xml: Remove.
4118         * features/i386/i386-avx-linux.xml: Remove.
4119         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4120         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4121         * features/i386/i386-avx-mpx-linux.xml: Remove.
4122         * features/i386/i386-avx-mpx.xml: Remove.
4123         * features/i386/i386-avx.xml: Remove.
4124         * features/i386/i386-linux.xml: Remove.
4125         * features/i386/i386-mmx-linux.xml: Remove.
4126         * features/i386/i386-mmx.xml: Remove.
4127         * features/i386/i386-mpx-linux.xml: Remove.
4128         * features/i386/i386-mpx.xml: Remove.
4129         * features/i386/i386.xml: Remove.
4130         * features/i386/x32-avx-avx512-linux.xml: Remove.
4131         * features/i386/x32-avx-linux.xml: Remove.
4132         * features/i386/x32-linux.xml: Remove.
4133
4134 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4135
4136         * regformats/aarch64.dat: Remove.
4137         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4138         * regformats/i386/amd64-avx-linux.dat: Remove.
4139         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4140         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4141         * regformats/i386/amd64-linux.dat: Remove.
4142         * regformats/i386/amd64-mpx-linux.dat: Remove.
4143         * regformats/i386/amd64.dat: Remove.
4144         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4145         * regformats/i386/i386-avx-linux.dat: Remove.
4146         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4147         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4148         * regformats/i386/i386-linux.dat: Remove.
4149         * regformats/i386/i386-mmx-linux.dat: Remove.
4150         * regformats/i386/i386-mpx-linux.dat: Remove.
4151         * regformats/i386/i386.dat: Remove.
4152         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4153         * regformats/i386/x32-avx-linux.dat: Remove.
4154         * regformats/i386/x32-linux.dat: Remove.
4155
4156 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4157
4158         * aarch64-tdep.c: Remove xml self tests.
4159         * amd64-linux-tdep.c: Likewise.
4160         * amd64-tdep.c: Likewise.
4161         * i386-linux-tdep.c: Likewise.
4162         * i386-tdep.c: Likewise.
4163
4164 2019-07-03  Pedro Alves  <palves@redhat.com>
4165
4166         PR cli/24732
4167         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4168         (pipe_cmd_option_defs): New.
4169         (make_pipe_cmd_options_def_group): New.
4170         (pipe_command): Use gdb::option::process_options.
4171         (pipe_command_completer): New function.
4172         (_initialize_cli_cmds): Install completer for "pipe" command.
4173
4174 2019-07-03  Pedro Alves  <palves@redhat.com>
4175
4176         * cli/cli-option.c (union option_value) <string>: New field.
4177         (struct option_def_and_value): Add ctor, move ctor, dtor and
4178         use DISABLE_COPY_AND_ASSIGN.
4179         (option_def_and_value::clear_value): New.
4180         (parse_option, save_option_value_in_ctx, get_val_type_str)
4181         (add_setshow_cmds_for_options): Handle var_string.
4182         * cli-option.h (union option_def::var_address) <string>: New
4183         field.
4184         (struct string_option_def): New.
4185         * maint-test-options.c (struct test_options_opts): Add default
4186         ctor and use DISABLE_COPY_AND_ASSIGN.
4187         <string_opt>: New field.
4188         (test_options_opts::~test_options_opts): New.
4189         (test_options_opts::dump): Also dump "-string".
4190         (test_options_option_defs): Install "string.
4191
4192 2019-07-03  Pedro Alves  <palves@redhat.com>
4193
4194         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4195         option_value with a null enumeration.
4196         (complete_options): Save the option values in the context.
4197         (save_option_value_in_ctx): New, factored out from ...
4198         (process_options): ... here.
4199         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4200         of the function.
4201         * maint-test-options.c (test_options_opts::dump): New, factored
4202         out from ...
4203         (maintenance_test_options_command_mode): ... here.
4204         (maintenance_test_options_command_completion_result): Delete.
4205         (maintenance_test_options_command_completion_text): Update
4206         comment.
4207         (maintenance_show_test_options_completion_result): Change
4208         prototype.  Just print
4209         maintenance_test_options_command_completion_text.
4210         (save_completion_result): New.
4211         (maintenance_test_options_completer_mode): Pass options context to
4212         complete_options, and then save a dump.
4213         (_initialize_maint_test_options): Use add_cmd to install "maint
4214         show test-options-completion-result".
4215
4216 2019-07-03  Pedro Alves  <palves@redhat.com>
4217
4218         * NEWS (New commands): Mention "with" and "maint with".
4219         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4220         (with_command, with_command_completer): New.
4221         (pipe_command): Adjust to new repeat_previous
4222         interface.
4223         (_initialize_cli_cmds): Install the "with" command and its "w"
4224         alias.
4225         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4226         declarations.
4227         * cli/cli-setshow.c (parse_cli_var_uinteger)
4228         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4229         argument strings for all var_types.
4230         (get_setshow_command_value_string): New, factored out from ...
4231         (do_show_command): ... this.
4232         * cli/cli-setshow.h: Include <string>.
4233         (get_setshow_command_value_string): Declare.
4234         * command.h (repeat_previous): Now returns const char *.  Adjust
4235         comment.
4236         * maint.c: Include "cli/cli-cmds.h".
4237         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4238         (_initialize_maint_cmds): Register the "maintenance with" command.
4239         * top.c (repeat_previous): Move bits from pipe_command here:
4240         Return the saved command line, if any; error out if there's no
4241         command to relaunch.
4242
4243 2019-07-03  Pedro Alves  <palves@redhat.com>
4244
4245         * NEWS (New commands): Mention "maint set/show test-settings"
4246         instead of "maint test-settings".
4247         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4248         (maintenance_test_settings_set_list): Rename to ...
4249         (maintenance_set_test_settings_list): ... this.
4250         (maintenance_test_settings_show_list): Rename to  ...
4251         (maintenance_show_test_settings_list): ... this.
4252         (maintenance_test_settings_cmd): Delete.
4253         (maintenance_test_settings_set_cmd): ...
4254         (maintenance_set_test_settings_cmd): ... this.
4255         (maintenance_test_settings_show_cmd): ...
4256         (maintenance_show_test_settings_cmd): ... this.
4257         (maintenance_test_settings_show_value_cmd):
4258         (maintenance_show_test_settings_value_cmd): ... this.
4259         (_initialize_maint_test_settings): No longer install the "maint
4260         test-settings" prefix command.  Rename "maint test-settings set"
4261         to "maint set test-settings", and "maint test-settings show" to
4262         "maint show test-settings".  Adjust all subcommands.
4263
4264 2019-07-03  Pedro Alves  <palves@redhat.com>
4265
4266         * maint-test-settings.c: Fix file's intro comment.  Replace all
4267         references to "test-options" with references to "test-settings",
4268         in comments.
4269
4270 2019-07-03  Pedro Alves  <palves@redhat.com>
4271
4272         * maint-test-settings.c (maintenance_test_settings_xxx)
4273         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4274         New.
4275         (maintenance_test_settings_enums): Use them.
4276         (maintenance_test_settings_enum): Default to
4277         maintenance_test_settings_xxx.
4278         (_initialize_maint_test_settings): Initialize
4279         MAINTENANCE_TEST_SETTINGS_FILENAME.
4280
4281 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4282
4283         * breakpoint.h (remove_breakpoints_inf): Change return type to
4284         void, move function documentation here.
4285         * breakpoint.c (remove_breakpoints_inf): Change return type to
4286         void, move function documentation to header.
4287
4288 2019-07-02  Pedro Alves  <palves@redhat.com>
4289
4290         * NEWS (Completion improvements): Mention "info threads".
4291         * thread.c (struct info_threads_opts, info_threads_option_defs)
4292         (make_info_threads_options_def_group): New.
4293         (info_threads_command): Use gdb::option::process_options.
4294         (info_threads_command_completer): New.
4295         (_initialize_thread): Use gdb::option::build_help to build the
4296         help text for "info threads".
4297
4298 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4299
4300         * defs.h (generic_load): Move from here...
4301         * symfile.h (generic_load): ... to here.  Rename name parameter
4302         to args.
4303         * symfile.c (generic_load): Add comment.
4304
4305 2019-07-01  Tom Tromey  <tromey@adacore.com>
4306
4307         * dwarf2read.c
4308         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4309         declaration of without_params.  Fix formatting.
4310
4311 2019-07-01  Tom Tromey  <tromey@adacore.com>
4312
4313         * ada-exp.y (find_primitive_type): Update.
4314         * ada-lang.h (ada_lookup_symbol): Update.
4315         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4316         parameter.
4317         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4318
4319 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4320
4321         PR breakpoints/24541
4322         * gdbarch.c: Regenerate.
4323         * gdbarch.h: Regenerate.
4324         * gdbarch.sh: Add 'stap_adjust_register'.
4325         * i386-tdep.c: Include '<unordered_set>'.
4326         (i386_stap_adjust_register): New function.
4327         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4328         * stap-probe.c (stap_parse_register_operand): Call
4329         'gdbarch_stap_adjust_register'.
4330
4331 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4332
4333         PR python/24742
4334         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4335         * python/python.c (do_start_initialization): Use 'xmalloc'
4336         instead of 'PyMem_Malloc'.
4337
4338 2019-06-28  Tom Tromey  <tromey@adacore.com>
4339
4340         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4341         for Ada.
4342
4343 2019-06-27  Tom Tromey  <tromey@adacore.com>
4344
4345         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4346         objfile_key.
4347         (arm_find_mapping_symbol, arm_record_special_symbol)
4348         (_initialize_arm_tdep): Update.
4349         (arm_objfile_data_free): Remove.
4350
4351 2019-06-27  Tom Tromey  <tromey@adacore.com>
4352
4353         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4354         to cp_print_static_field.
4355
4356 2019-06-26  Tom Tromey  <tromey@adacore.com>
4357
4358         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4359         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4360         declare.
4361
4362 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4363
4364         * features/aarch64-core.c (create_feature_aarch64_core):
4365         Regenerate.
4366         * features/aarch64-core.xml: Add cpsr flags.
4367
4368 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4369
4370         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4371         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4372
4373 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4374
4375         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4376         field.
4377         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4378         use.
4379         (arm_record_special_symbol): Don't insert new symbol in sorted
4380         position, push it at the end.
4381
4382 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4383
4384         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4385         (arm_mapping_symbol_s): Remove.
4386         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4387         (arm_mapping_symbol_vec): New typedef.
4388         (struct arm_per_objfile): Add constructor.
4389         <section_maps>: Change type to
4390         std::unique_ptr<arm_mapping_symbol_vec[]>.
4391         (arm_compare_mapping_symbols): Remove.
4392         (arm_find_mapping_symbol): Adjust to section_maps type change.
4393         (arm_objfile_data_free): Call delete on arm_per_objfile.
4394         (arm_record_special_symbol): Adjust to section_maps type change.
4395         Allocate arm_per_objfile with new.
4396
4397 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4398
4399         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4400         with the command prefix.
4401
4402 2019-06-25  Tom Tromey  <tom@tromey.com>
4403
4404         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4405         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4406
4407 2019-06-25  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4410         type.
4411         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4412         protected.
4413
4414 2019-06-25  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-winsource.c
4417         (tui_source_window_base::set_is_exec_point_at): Add check against
4418         LOA_ADDRESS.
4419
4420 2019-06-25  Tom Tromey  <tom@tromey.com>
4421
4422         * tui/tui-source.c (tui_set_source_content): Don't check before
4423         xfree.
4424         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4425
4426 2019-06-25  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-winsource.h (tui_update_source_window_as_is)
4429         (tui_alloc_source_buffer, tui_line_is_displayed)
4430         (tui_addr_is_displayed): Change type of win_info.
4431         * tui/tui-winsource.c (tui_update_source_window_as_is)
4432         (tui_clear_source_content, tui_show_source_line)
4433         (tui_show_source_content, tui_source_window_base::refill)
4434         (tui_source_window_base::set_is_exec_point_at)
4435         (tui_source_window_base::set_is_exec_point_at)
4436         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4437         (tui_alloc_source_buffer, tui_line_is_displayed)
4438         (tui_addr_is_displayed): Change type of win_info.  Update.
4439         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4440         (tui_source_window_base::do_make_visible_with_new_height):
4441         Update.
4442         * tui/tui-source.c (tui_set_source_content)
4443         (tui_set_source_content_nil)
4444         (tui_source_window::do_scroll_vertical): Update.
4445         * tui/tui-layout.c (show_layout): Update.
4446         * tui/tui-disasm.c (tui_set_disassem_content)
4447         (tui_disasm_window::do_scroll_vertical): Update.
4448         * tui/tui-data.h (tui_win_content): Remove.
4449         (struct tui_gen_win_info) <content, content_size>: Remove.
4450         (struct tui_source_element): Add initializers and destructor.
4451         (union tui_which_element, struct tui_win_element): Remove.
4452         (struct tui_source_window_base) <content>: New field.
4453         (struct tui_data_window): Remove destructor.
4454         (tui_alloc_content, tui_free_win_content)
4455         (tui_free_all_source_wins_content): Don't declare.
4456         * tui/tui-data.c (tui_initialize_static_data): Update.
4457         (init_content_element, tui_alloc_content): Remove.
4458         (~tui_gen_win_info): Update.
4459         (~tui_data_window, tui_free_all_source_wins_content)
4460         (tui_free_win_content, free_content, free_content_elements):
4461         Remove.
4462
4463 2019-06-25  Tom Tromey  <tom@tromey.com>
4464
4465         * tui/tui-winsource.h (tui_clear_source_content)
4466         (tui_erase_source_content, tui_show_source_content): Change type
4467         of win_info.
4468         * tui/tui-winsource.c (tui_clear_source_content)
4469         (tui_erase_source_content, tui_show_source_content): Change type
4470         of win_info.
4471         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4472         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4473         win_info.
4474         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4475         win_info.
4476         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4477
4478 2019-06-25  Tom Tromey  <tom@tromey.com>
4479
4480         * tui/tui-winsource.c (tui_clear_source_content)
4481         (tui_source_window_base::set_is_exec_point_at): Update.
4482         * tui/tui-source.c (tui_set_source_content_nil): Update.
4483         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4484         a bool.
4485         * tui/tui-data.c (init_content_element): Update.
4486
4487 2019-06-25  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4490         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4491         * tui/tui-layout.c (init_and_make_win): Update.
4492         * tui/tui.h (enum tui_win_type): Update.
4493         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4494         tui_win_is_auxillary.
4495         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4496         tui_win_is_auxillary.
4497
4498 2019-06-25  Tom Tromey  <tom@tromey.com>
4499
4500         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4501         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4502         (tui_delete_data_content_windows, tui_display_all_data)
4503         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4504         Update.
4505         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4506         * tui/tui-regs.c (tui_last_regs_line_no)
4507         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4508         (tui_show_registers): Update.
4509         (tui_show_register_group): Return void.  Update.
4510         (tui_display_registers_from, tui_display_reg_element_at_line)
4511         (tui_display_registers_from_line, tui_check_register_values):
4512         Update.
4513         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4514         member.
4515         (struct tui_data_window) <regs_content>: Now a std::vector.
4516         <regs_content_count>: Remove.
4517         (tui_add_content_elements, tui_free_data_content): Don't declare.
4518         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4519         (init_content_element): Remove DATA_WIN case.  Add assert.
4520         (tui_add_content_elements): Remove.
4521         (tui_data_window): Update.
4522         (tui_free_data_content): Remove.
4523         (free_content_elements): Remove DATA_WIN case.
4524
4525 2019-06-25  Tom Tromey  <tom@tromey.com>
4526
4527         * tui/tui-data.c (tui_data_item_window): Update.
4528         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4529         * tui/tui-windata.c (tui_display_all_data)
4530         (tui_display_data_from_line): Update.
4531         (tui_check_data_values): Remove.
4532         * tui/tui-regs.c (tui_show_register_group)
4533         (tui_display_reg_element_at_line): Update.
4534         * tui/tui-hooks.c (tui_register_changed)
4535         (tui_refresh_frame_and_register_information): Call
4536         tui_check_register_values.
4537         * tui/tui-data.h (struct tui_data_window) <data_content,
4538         data_content_count, data_type>: Remove.
4539         (enum tui_data_type): Remove.
4540
4541         * tui/tui-data.c (tui_data_window::clear_detail)
4542         (~tui_data_window): Update.
4543
4544 2019-06-25  Tom Tromey  <tom@tromey.com>
4545
4546         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4547         declare.
4548         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4549         Rename from tui_first_data_item_displayed.  Update.
4550         (tui_data_window::refresh_all)
4551         (tui_data_window::do_scroll_vertical): Update.
4552         * tui/tui-data.h (struct tui_data_window)
4553         <first_data_item_displayed>: Declare new method.
4554
4555 2019-06-25  Tom Tromey  <tom@tromey.com>
4556
4557         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4558         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4559         contents...
4560         (tui_initialize_static_data): ...here.
4561
4562 2019-06-25  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4565         (tui_display_registers_from, tui_check_register_values): Update.
4566         (tui_display_register): Remove win_info parameter; update.
4567         (tui_get_register): Change type of parameters.
4568         * tui/tui-data.h (struct tui_data_element): Remove.
4569         (union tui_which_element) <data>: Remove.
4570         <data_window>: Change type.
4571         (struct tui_data_item_window): New.
4572         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4573         case.  Add assert.
4574         (~tui_data_item_window): New destructor.
4575         (free_content_elements): Remove DATA_ITEM_WIN case.
4576
4577 2019-06-25  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4580         Remove.
4581
4582 2019-06-25  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-data.h (struct tui_command_element): Remove.
4585         (union tui_which_element) <command>: Remove.
4586         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4587         assert.
4588         (free_content_elements): Remove CMD_WIN case.
4589
4590 2019-06-25  Tom Tromey  <tom@tromey.com>
4591
4592         * tui/tui-layout.c (tui_set_layout): Update.
4593         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4594         * tui/tui-data.c (layout_def): Update.
4595
4596 2019-06-25  Tom Tromey  <tom@tromey.com>
4597
4598         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4599         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4600         (tui_source_window_base::set_new_height): Update.
4601         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4602         Update.
4603         (tui_set_locator_fullname, tui_set_locator_info)
4604         (tui_show_frame_info): Update.
4605         * tui/tui-source.c (tui_set_source_content)
4606         (tui_source_is_displayed): Update.
4607         * tui/tui-layout.c (show_source_disasm_command, show_data)
4608         (show_source_or_disasm_and_command): Update.
4609         * tui/tui-disasm.c (tui_set_disassem_content)
4610         (tui_get_begin_asm_address): Update.
4611         * tui/tui-data.h (struct tui_locator_element): Remove.
4612         (union tui_which_element) <locator>: Remove.
4613         (struct tui_locator_window): New.
4614         (tui_locator_win_info_ptr): Change return type.
4615         * tui/tui-data.c (_locator): Change type.
4616         (tui_locator_win_info_ptr): Change return type.
4617         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4618         (tui_alloc_content): Add assert.
4619
4620 2019-06-25  Tom Tromey  <tom@tromey.com>
4621
4622         * tui/tui-winsource.c
4623         (tui_exec_info_window::maybe_allocate_content): New method.
4624         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4625         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4626         (make_source_or_disasm_window): Add cast.
4627         * tui/tui-data.h (union tui_which_element) <simple_string>:
4628         Remove.
4629         (struct tui_source_info): New.
4630         (struct tui_source_window_base) <execution_info>: Change type.
4631         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4632         case, and add assert.
4633         (tui_alloc_content): Add assert.
4634
4635 2019-06-25  Tom Tromey  <tom@tromey.com>
4636
4637         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4638         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4639         * tui/tui-data.c (tui_alloc_win_info): Remove.
4640
4641 2019-06-25  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4644         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4645         can_highlight.
4646
4647 2019-06-25  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4650         make_visible_with_new_height method.
4651         (tui_win_info::make_visible_with_new_height): New method.
4652         (tui_source_window_base::do_make_visible_with_new_height)
4653         (tui_data_window::do_make_visible_with_new_height)
4654         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4655         (make_visible_with_new_height): Remove.
4656         (tui_resize_all, tui_adjust_win_heights): Use
4657         make_visible_with_new_height method.
4658         * tui/tui-data.h (struct tui_win_info)
4659         <do_make_visible_with_new_height, make_visible_with_new_height>:
4660         New methods.
4661         (struct tui_source_window_base, struct tui_data_window)
4662         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4663         methods.
4664
4665 2019-06-25  Tom Tromey  <tom@tromey.com>
4666
4667         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4668         method.
4669         (update_tab_width): Call update_tab_width method.
4670         * tui/tui-data.h (struct tui_win_info)
4671         (struct tui_source_window_base) <update_tab_width>: New methods.
4672
4673 2019-06-25  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4676         parameter.
4677         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4678         parameter.
4679         (tui_gen_win_info::make_visible): Update.
4680         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4681         parameter.
4682         * tui/tui-data.h (enum tui_box): New enum.
4683         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4684
4685 2019-06-25  Tom Tromey  <tom@tromey.com>
4686
4687         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4688         init_and_make_win for EXEC_INFO_WIN.
4689         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4690         longer inline.
4691         (struct tui_win_info) <~tui_win_info>: Inline.
4692         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4693         Don't declare.
4694         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4695         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4696         Remove.
4697         (tui_initialize_static_data): Update.
4698         (~tui_gen_win_info): Handle more cleanup here.
4699         (~tui_source_window_base): Delete "execution_info".
4700         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4701
4702 2019-06-25  Tom Tromey  <tom@tromey.com>
4703
4704         * tui/tui-layout.c (make_command_window): Don't set
4705         can_highlight.
4706         (show_source_disasm_command): Call the reset method.
4707         (show_data): Don't set can_highlight.  Call the reset method.
4708         (tui_gen_win_info::reset): Rename from init_gen_win_info
4709         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4710         (show_source_or_disasm_and_command): Call the reset method.
4711         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4712         (struct tui_cmd_window): Set can_highlight.
4713
4714 2019-06-25  Tom Tromey  <tom@tromey.com>
4715
4716         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4717         from make_visible.
4718         (tui_make_visible, tui_make_invisible): Rewrite.
4719         (tui_win_info::make_visible): Remove.
4720         (tui_source_window_base::make_visible): Update.
4721         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4722         method.  Moved from...
4723         (struct tui_win_info) <make_visible>: ...here.
4724
4725 2019-06-25  Tom Tromey  <tom@tromey.com>
4726
4727         * tui/tui-winsource.c
4728         (tui_source_window_base::do_scroll_horizontal): Remove direction
4729         parameter.
4730         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4731         direction parameter.
4732         * tui/tui-win.c (tui_win_info::forward_scroll)
4733         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4734         (tui_win_info::right_scroll): Update.
4735         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4736         direction parameter.
4737         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4738         direction parameter.
4739         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4740         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4741         Remove direction parameter.
4742         (struct tui_source_window_base, struct tui_source_window)
4743         (struct tui_disasm_window, struct tui_data_window)
4744         (struct tui_cmd_window): Update.
4745
4746 2019-06-25  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-winsource.h (tui_set_exec_info_content)
4749         (tui_show_exec_info_content, tui_erase_exec_info_content)
4750         (tui_clear_exec_info_content, tui_update_exec_info): Change
4751         argument to tui_source_window_base.
4752         * tui/tui-winsource.c (tui_set_exec_info_content)
4753         (tui_show_exec_info_content, tui_erase_exec_info_content)
4754         (tui_clear_exec_info_content, tui_update_exec_info): Change
4755         argument to tui_source_window_base.
4756
4757 2019-06-25  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4760         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4761
4762 2019-06-25  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4765         check.
4766
4767 2019-06-25  Tom Tromey  <tom@tromey.com>
4768
4769         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4770         type to void.
4771         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4772         type to void.
4773         * tui/tui-source.c (tui_set_source_content): Update.
4774         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4775
4776 2019-06-25  Tom Tromey  <tom@tromey.com>
4777
4778         * tui/tui-win.c (window_name_completer, tui_set_focus)
4779         (tui_all_windows_info): Use name method.
4780         * tui/tui-data.h (struct tui_gen_win_info)
4781         (struct tui_source_window, struct tui_disasm_window)
4782         (struct tui_data_window, struct tui_cmd_window) <name>: New
4783         method.
4784         (tui_win_name): Don't declare.
4785         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4786         (tui_win_name): Remove.
4787
4788 2019-06-25  Tom Tromey  <tom@tromey.com>
4789
4790         * tui/tui-winsource.h (tui_update_source_window)
4791         (tui_update_source_window_as_is): Change parameter type.
4792         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4793         to be a tui_source_window_base.
4794         (tui_update_source_window_as_is): Likewise.
4795         * tui/tui-win.c (make_visible_with_new_height): Update.
4796
4797 2019-06-25  Tom Tromey  <tom@tromey.com>
4798
4799         * tui/tui-winsource.c (tui_erase_source_content)
4800         (tui_show_source_content, tui_show_exec_info_content)
4801         (tui_erase_exec_info_content): Use refresh_window method.
4802         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4803         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4804         from tui_refresh_win.
4805         (tui_data_window::refresh_window): New method.
4806         (tui_win_info::refresh, tui_source_window_base::refresh)
4807         (tui_refresh_all): Use refresh_window method.
4808         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4809         method.
4810         * tui/tui-regs.c (tui_display_register): Call refresh_window
4811         method.
4812         * tui/tui-layout.c (show_source_disasm_command)
4813         (show_source_or_disasm_and_command): Call refresh_window method.
4814         * tui/tui-data.h (struct tui_gen_win_info)
4815         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4816         New method.
4817
4818 2019-06-25  Tom Tromey  <tom@tromey.com>
4819
4820         * tui/tui.c (tui_rl_other_window, tui_enable)
4821         (tui_is_window_visible, tui_get_command_dimension): Update.
4822         * tui/tui-winsource.c (tui_update_source_window_as_is)
4823         (tui_clear_source_content, tui_erase_source_content)
4824         (tui_show_source_line, tui_source_window_base::refill)
4825         (tui_source_window_base::do_scroll_horizontal)
4826         (tui_source_window_base::set_is_exec_point_at)
4827         (tui_update_breakpoint_info, tui_set_exec_info_content)
4828         (tui_alloc_source_buffer, tui_line_is_displayed)
4829         (tui_addr_is_displayed): Update.
4830         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4831         (tui_check_and_display_highlight_if_needed)
4832         (tui_win_info::make_visible, tui_win_info::refresh)
4833         (tui_refresh_all): Update.
4834         * tui/tui-windata.c (tui_first_data_item_displayed)
4835         (tui_delete_data_content_windows, tui_erase_data_content)
4836         (tui_display_all_data, tui_data_window::refresh_all)
4837         (tui_check_data_values): Update.
4838         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4839         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4840         (tui_win_info::backward_scroll, tui_refresh_all_win)
4841         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4842         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4843         (tui_source_window_base::set_new_height)
4844         (tui_data_window::set_new_height)
4845         (make_invisible_and_set_new_height)
4846         (make_visible_with_new_height, new_height_ok)
4847         (parse_scrolling_args): Update.
4848         * tui/tui-stack.c (tui_show_frame_info): Update.
4849         * tui/tui-source.c (tui_set_source_content)
4850         (tui_set_source_content_nil, tui_source_is_displayed)
4851         (tui_source_window::do_scroll_vertical): Update.
4852         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4853         (tui_display_registers_from, tui_display_reg_element_at_line)
4854         (tui_check_register_values, tui_reg_command): Update.
4855         * tui/tui-layout.c (tui_default_win_height)
4856         (show_source_disasm_command, show_data, init_and_make_win)
4857         (show_source_or_disasm_and_command): Update.
4858         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4859         (tui_redisplay_readline, tui_mld_flush)
4860         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4861         (tui_getc): Update.
4862         * tui/tui-disasm.c (tui_set_disassem_content)
4863         (tui_disasm_window::do_scroll_vertical): Update.
4864         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4865         Now virtual.
4866         (struct tui_win_info): Derive from tui_gen_win_info.
4867         <~tui_win_info>: Mark as override.
4868         <generic>: Remove member.
4869         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4870         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4871         (~tui_data_window, ~tui_win_info)
4872         (tui_free_all_source_wins_content): Update.
4873         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4874
4875 2019-06-25  Tom Tromey  <tom@tromey.com>
4876
4877         * tui/tui-layout.c (init_and_make_win): Use new.
4878         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4879         destructor, initializers.
4880         (tui_alloc_generic_win_info): Don't declare.
4881         * tui/tui-data.c (_locator): Add argument to constructor.
4882         (source_win, disasm_win): New globals.
4883         (exec_info): Remove.
4884         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4885         Update.
4886         (tui_alloc_generic_win_info): Remove.
4887         (init_content_element): Use new.
4888         (tui_win_info::tui_win_info): Update.
4889         (free_content_elements) <case DATA_WIN>: Use delete.
4890
4891 2019-06-25  Tom Tromey  <tom@tromey.com>
4892
4893         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4894         * tui/tui-windata.c (tui_first_data_item_displayed)
4895         (tui_delete_data_content_windows): Update.
4896         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4897         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4898         (tui_display_registers_from, tui_check_register_values): Update.
4899         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4900         pointer.
4901         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4902         window.
4903         (tui_free_data_content): Update.
4904         (free_content_elements) <case DATA_WIN>: Free the window.
4905
4906 2019-06-25  Tom Tromey  <tom@tromey.com>
4907
4908         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4909         Update.
4910         * tui/tui-layout.c (make_command_window)
4911         (show_source_disasm_command, show_data, init_and_make_win)
4912         (show_source_or_disasm_and_command): Update.
4913         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4914         method.
4915         <can_highight, is_highlighted>: Now bool.
4916         (tui_set_win_highlight): Don't declare.
4917         * tui/tui-data.c (tui_set_win_highlight): Remove.
4918
4919 2019-06-25  Tom Tromey  <tom@tromey.com>
4920
4921         * tui/tui-wingeneral.c (make_visible): Remove check of window
4922         type.
4923
4924 2019-06-25  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui-win.c (tui_win_info::max_height)
4927         (tui_cmd_window::max_height): New methods.
4928         (new_height_ok): Call max_height.
4929         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4930         <max_height>: New method.
4931
4932 2019-06-25  Tom Tromey  <tom@tromey.com>
4933
4934         * tui/tui-win.c (tui_source_window_base::set_new_height)
4935         (tui_data_window::set_new_height): New methods.
4936         (make_invisible_and_set_new_height): Call set_new_height method.
4937         * tui/tui-data.h (struct tui_win_info)
4938         (struct tui_source_window_base, struct tui_data_window)
4939         <set_new_height>: New method.
4940
4941 2019-06-25  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4944         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4945         tui_refresh_data_win.
4946         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4947         method.
4948         (tui_refresh_all_win): Call the refresh_all method.
4949         (tui_set_focus): Likewise.
4950         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4951         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4952         Likewise.
4953
4954 2019-06-25  Tom Tromey  <tom@tromey.com>
4955
4956         * tui/tui-winsource.h (tui_refill_source_window)
4957         (tui_set_is_exec_point_at): Don't declare.
4958         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4959         (tui_source_window_base::refill): Rename from
4960         tui_refill_source_window.
4961         (tui_source_window_base::do_scroll_horizontal): Update.
4962         (tui_source_window_base::set_is_exec_point_at): Rename from
4963         tui_set_is_exec_point_at.
4964         (tui_update_all_breakpoint_info): Update.
4965         * tui/tui-stack.c (tui_show_frame_info): Update.
4966         * tui/tui-layout.c (show_data): Add cast.
4967         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4968         * tui/tui-data.h (struct tui_source_window_base) <refill,
4969         set_is_exec_point_at>: New methods.
4970         (tui_source_windows, tui_add_to_source_windows): Update types.
4971         (tui_add_to_source_windows): Remove redundant declaration.
4972         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4973         (tui_source_windows): Change return type.
4974         (tui_clear_source_windows_detail): Update.
4975         (tui_add_to_source_windows): Change type of parameter.
4976         (tui_free_all_source_wins_content): Update.
4977
4978 2019-06-25  Tom Tromey  <tom@tromey.com>
4979
4980         * tui/tui-wingeneral.c (tui_win_info::refresh)
4981         (tui_source_window_base::refresh): New methods.
4982         (tui_refresh_all): Call the refresh method.
4983         * tui/tui-data.h (struct tui_win_info)
4984         (struct tui_source_window_base) <refresh>: New method.
4985
4986 2019-06-25  Tom Tromey  <tom@tromey.com>
4987
4988         * tui/tui.h (tui_is_window_visible): Return bool.
4989         * tui/tui.c (tui_is_window_visible): Return bool.
4990         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4991         (tui_make_visible, tui_make_invisible)
4992         (tui_win_info::make_visible)
4993         (tui_source_window_base::make_visible, make_all_visible)
4994         (tui_make_all_visible, tui_make_all_invisible): Update.
4995         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4996         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4997         bool.
4998         (struct tui_win_info, struct tui_source_window_base)
4999         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5000         * tui/tui-data.c (tui_init_generic_part): Update.
5001
5002 2019-06-25  Tom Tromey  <tom@tromey.com>
5003
5004         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5005         (tui_source_window_base::make_visible): New methods.
5006         (make_all_visible): Make method call.
5007         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5008         (struct tui_source_window_base, struct tui_cmd_window): Override
5009         make_visible.
5010         (tui_win_is_source_type): Don't declare.
5011         * tui/tui-data.c (tui_win_is_source_type): Remove.
5012
5013 2019-06-25  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5016         NULL check.
5017
5018 2019-06-25  Tom Tromey  <tom@tromey.com>
5019
5020         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5021         Inline constructor.  Add initializers for members.
5022         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5023         constructors; now inline in class.
5024
5025 2019-06-25  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-regs.c (tui_show_registers): Update.
5028         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5029         bool.
5030         * tui/tui-data.c (tui_data_window::clear_detail)
5031         (tui_data_window): Update.
5032
5033 2019-06-25  Tom Tromey  <tom@tromey.com>
5034
5035         * tui/tui-windata.c (tui_display_all_data)
5036         (tui_display_data_from_line, tui_display_data_from)
5037         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5038         Update.
5039         * tui/tui-regs.c (tui_last_regs_line_no)
5040         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5041         (tui_show_registers, tui_show_register_group)
5042         (tui_display_registers_from, tui_display_reg_element_at_line)
5043         (tui_display_registers_from_line, tui_check_register_values)
5044         (tui_reg_next, tui_reg_prev): Update.
5045         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5046         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5047         tui_data_window.
5048         (struct tui_win_info) <detail>: Remove.  Add new fields from
5049         tui_data_info.
5050         (TUI_DATA_WIN): Add cast.
5051         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5052         (~tui_data_window): Simplify.
5053
5054 2019-06-25  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-layout.c (show_source_disasm_command)
5057         (show_source_or_disasm_and_command): Update.
5058         * tui/tui-io.c (update_cmdwin_start_line)
5059         (tui_redisplay_readline): Update.
5060         * tui/tui-data.h (struct tui_command_info): Remove.
5061         (struct tui_win_info) <detail>: Remove command_info member.
5062         (struct tui_data_window) <start_line>: New member, from
5063         tui_command_info.
5064         (TUI_CMD_WIN): Add casts.
5065
5066 2019-06-25  Tom Tromey  <tom@tromey.com>
5067
5068         * tui/tui-winsource.c (tui_update_source_window)
5069         (tui_refill_source_window)
5070         (tui_source_window_base::do_scroll_horizontal)
5071         (tui_update_breakpoint_info, tui_set_exec_info_content)
5072         (tui_show_exec_info_content, tui_erase_exec_info_content)
5073         (tui_clear_exec_info_content): Update.
5074         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5075         Update.
5076         * tui/tui-win.c (make_invisible_and_set_new_height)
5077         (make_visible_with_new_height): Update.
5078         * tui/tui-source.c (tui_set_source_content)
5079         (tui_show_symtab_source): Update.
5080         * tui/tui-layout.c (extract_display_start_addr)
5081         (show_source_disasm_command, show_data)
5082         (make_source_or_disasm_window)
5083         (show_source_or_disasm_and_command): Update.
5084         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5085         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5086         "gdbarch".
5087         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5088         to tui_source_window_base.
5089         (struct tui_win_info) <detail>: Remove source_info member.
5090         (struct tui_source_window_base) <has_locator>: Inline.
5091         Move contents from tui_source_info; rename has_locator member to
5092         m_has_locator.
5093         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5094         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5095         header file.
5096         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5097         Simplify.
5098         (tui_free_all_source_wins_content): Cast to
5099         tui_source_window_base.
5100
5101 2019-06-25  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-win.c (make_invisible_and_set_new_height)
5104         (make_visible_with_new_height): Call has_locator method.
5105         * tui/tui-layout.c (show_source_disasm_command, show_data)
5106         (show_source_or_disasm_and_command): Update for bool change.
5107         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5108         (tui_win_info) <has_locator>: New method.
5109         (struct tui_source_window_base) <has_locator>: New method.
5110         (tui_win_has_locator): Don't declare.
5111         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5112         from tui_win_has_locator.
5113         (tui_source_window_base): Use false, not FALSE.
5114
5115 2019-06-25  Tom Tromey  <tom@tromey.com>
5116
5117         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5118         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5119         clear_detail method directly.
5120         (tui_clear_win_detail): Remove.
5121
5122 2019-06-25  Tom Tromey  <tom@tromey.com>
5123
5124         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5125         "this", not TUI_DISASM_WIN.
5126
5127 2019-06-25  Tom Tromey  <tom@tromey.com>
5128
5129         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5130         declare.
5131         * tui/tui-winsource.c
5132         (tui_source_window_base::do_scroll_horizontal): Rename from
5133         tui_horizontal_source_scroll.
5134         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5135         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5136         from tui_vertical_data_scroll.
5137         * tui/tui-win.h (tui_scroll): Don't declare.
5138         * tui/tui-win.c (tui_win_info::forward_scroll)
5139         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5140         (tui_win_info::right_scroll): Rename and update.
5141         (tui_scroll_forward_command, tui_scroll_backward_command)
5142         (tui_scroll_left_command, tui_scroll_right_command): Update.
5143         (tui_scroll): Remove.
5144         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5145         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5146         from tui_vertical_source_scroll.
5147         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5148         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5149         from tui_vertical_disassem_scroll.
5150         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5151         do_scroll_horizontal>: New methods.
5152         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5153         Likewise.
5154         (struct tui_source_window_base): Add do_scroll_horizontal.
5155         (struct tui_source_window, struct tui_disasm_window): Add
5156         do_scroll_vertical.
5157         (struct tui_data_window, struct tui_cmd_window): Add
5158         do_scroll_horizontal and do_scroll_vertical.
5159         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5160
5161 2019-06-25  Tom Tromey  <tom@tromey.com>
5162
5163         * tui/tui-data.h (struct tui_source_window_base): New struct.
5164         (struct tui_source_window): Derive from tui_source_window_base.
5165         (struct tui_disasm_window): New struct.
5166         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5167         from tui_source_window::clear_detail.
5168         (tui_source_window_base): Rename from tui_source_window.
5169         (~tui_source_window_base): Rename from ~tui_source_window.
5170         (tui_alloc_win_info): Create a tui_disasm_window.
5171
5172 2019-06-25  Tom Tromey  <tom@tromey.com>
5173
5174         * tui/tui-data.h (struct tui_source_window)
5175         (struct tui_data_window): Declare destructors.
5176         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5177         destructors.
5178         (tui_win_info): Simplify.
5179
5180 2019-06-25  Tom Tromey  <tom@tromey.com>
5181
5182         * tui/tui-winsource.c (tui_display_main)
5183         (tui_update_source_windows_with_addr)
5184         (tui_update_all_breakpoint_info): Update.
5185         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5186         (new_height_ok, parse_scrolling_args): Update.
5187         * tui/tui-stack.c (tui_show_frame_info): Update.
5188         * tui/tui-data.h (struct tui_list): Remove.
5189         (tui_source_windows): Return a reference to a std::vector.
5190         * tui/tui-data.c (source_windows): Now a std::vector.
5191         (tui_source_windows): Change return type.
5192         (tui_clear_source_windows): Rewrite.
5193         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5194         (tui_free_all_source_wins_content): Rewrite.
5195
5196 2019-06-25  Tom Tromey  <tom@tromey.com>
5197
5198         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5199         (struct tui_data_window, struct tui_cmd_window): Declare
5200         clear_detail method.
5201         * tui/tui-data.c (tui_source_window::clear_detail)
5202         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5203         methods.
5204         (tui_clear_win_detail): Simplify.
5205
5206 2019-06-25  Tom Tromey  <tom@tromey.com>
5207
5208         * tui/tui-layout.c (make_source_window, make_disasm_window)
5209         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5210         Return the new window.
5211         (show_source_disasm_command, show_data)
5212         (show_source_or_disasm_and_command): Update.
5213
5214 2019-06-25  Tom Tromey  <tom@tromey.com>
5215
5216         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5217         parameter.  Return the new window.
5218         (show_source_disasm_command): Update and remove NULL check.
5219         (show_source_or_disasm_and_command): Update.
5220
5221 2019-06-25  Tom Tromey  <tom@tromey.com>
5222
5223         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5224
5225 2019-06-25  Tom Tromey  <tom@tromey.com>
5226
5227         * tui/tui-data.h (struct tui_win_info): Make constructor
5228         protected.  Make destructor virtual.  Add initializers.
5229         (tui_source_window, tui_data_window, tui_cmd_window): New
5230         classes.
5231         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5232         constructor.  Add "type" parameter.
5233         (tui_source_window, tui_data_window, tui_cmd_window): New
5234         constructors.
5235         (tui_alloc_win_info): Instantiate the appropriate subclass.
5236
5237 2019-06-25  Tom Tromey  <tom@tromey.com>
5238
5239         * tui/tui-win.c (tui_resize_all): Use delete.
5240         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5241         destructor.
5242         (tui_free_window): Don't declare.
5243         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5244         Update.
5245
5246 2019-06-25  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-data.h (struct tui_win_info): Add constructor.
5249         * tui/tui-data.c (tui_alloc_win_info): Use new.
5250         (tui_free_window): Use delete.
5251
5252 2019-06-22  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5255         declare.
5256         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5257
5258 2019-06-22  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5261         declare.
5262         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5263
5264 2019-06-22  Tom de Vries  <tdevries@suse.de>
5265
5266         * dwarf2read.c (create_addrmap_from_aranges)
5267         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5268         instead of '%zu'.
5269
5270 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5271
5272         * dwarf2read.h (dwarf2_section_info_def): Remove.
5273         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5274         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5275         std::vector<dwarf2_section_info>.
5276         (struct dwo_file) <~dwo_file>: Remove.
5277         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5278         types field.
5279         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5280         (dwarf2_read_debug_names): Likewise.
5281         (create_debug_types_hash_table): Change parameter type to
5282         array_view, adjust code accordingly.
5283         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5284         (partial_die_info::fixup): Likewise.
5285         (determine_prefix): Likewise.
5286         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5287
5288 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5289
5290         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5291         gdb_bfd_ref_ptr.
5292         <~dwo_file>: Remove call to gdb_bfd_unref.
5293         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5294         gdb_bfd_ref_ptr::get.
5295
5296 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5297
5298         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5299         type to htab_up.
5300         * dwarf2read.c (struct dwo_file): Initialize fields.
5301         <~dwo_file>: New.
5302         (free_dwo_file): Remove, move content to ~dwo_file.
5303         (struct dwo_file_deleter): Remove.
5304         (dwo_file_up>: Remove custom deleter.
5305         (free_dwo_files): Remove.
5306         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5307         dwo_files.
5308         (process_skeletonless_type_units): Call unique_ptr::get.
5309         (allocate_dwo_file_hash_table): Add deleter to created hash
5310         table.  Change return type to htab_up.
5311         (lookup_dwo_file_slot): Don't memset dwo_file, call
5312         unique_ptr::get.
5313         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5314         (create_dwo_unit_in_dwp_v2): Likewise.
5315         (open_and_init_dwo_file): Likewise.
5316         (free_dwo_file_from_slot): Remove.
5317
5318 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5319
5320         * dwarf2read.h (struct dwarf2_section_info) <readin,
5321         is_virtual>: Change type to bool.
5322         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5323         true instead of 1.
5324
5325 2019-06-19  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-data.h (tui_init_content_element): Don't declare.
5328
5329 2019-06-19  Tom Tromey  <tom@tromey.com>
5330
5331         * tui/tui-data.h (tui_init_win_info): Don't declare.
5332
5333 2019-06-19  Tom de Vries  <tdevries@suse.de>
5334
5335         * dwarf2read.h (abstract_to_concrete): Change type to
5336         std::unordered_map<sect_offset, std::vector<sect_offset>,
5337         gdb::hash_enum<sect_offset>>.
5338
5339 2019-06-19  Tom Tromey  <tromey@adacore.com>
5340
5341         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5342         EVAL_AVOID_SIDE_EFFECTS specially.
5343
5344 2019-06-19  Tom Tromey  <tromey@adacore.com>
5345
5346         * source-cache.c (highlighter): New global.
5347         (source_cache::get_source_lines): Create a highlighter on demand.
5348
5349 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5350
5351         * defs.h (deprecated_interactive_hook): Delete declaration.
5352         * interps.c (clear_interpreter_hooks): Remove use of
5353         deprecated_interactive_hook.
5354         * top.c (deprecated_interactive_hook): Delete definition.
5355         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5356
5357 2019-06-18  Tom de Vries  <tdevries@suse.de>
5358
5359         PR gdb/24515
5360         * dwarf2read.h (abstract_to_concrete): Change type from
5361         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5362         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5363         * dwarf2read.c (read_variable): Update.
5364         (dwarf2_fetch_die_loc_sect_off): Update.
5365
5366 2019-06-17  Tom de Vries  <tdevries@suse.de>
5367
5368         PR gdb/24617
5369         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5370         accessing parent[parent_len - 1].
5371
5372 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5373
5374         PR gdb/24364
5375         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5376         call dtrace_process_dof with NULL dof.
5377
5378 2019-06-16  Tom de Vries  <tdevries@suse.de>
5379
5380         PR gdb/24445
5381         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5382
5383 2019-06-16  Tom Tromey  <tom@tromey.com>
5384
5385         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5386         (make_all_visible): Use address of member.
5387
5388 2019-06-16  Tom Tromey  <tom@tromey.com>
5389
5390         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5391         (tui_free_window, free_content, free_content_elements): Remove
5392         unnecessary cast.
5393         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5394         cast.
5395         * tui/tui-regs.c (tui_show_register_group)
5396         (tui_display_registers_from, tui_display_reg_element_at_line):
5397         Remove unnecessary cast.
5398
5399 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5400
5401         * linux-nat.c (normal_mask): Delete.
5402         (_initialize_linux_nat): Don't initialise normal_mask.
5403
5404 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5405
5406         PR gdb/24445
5407         * dwarf-index-write.h (write_psymtabs_to_index): Add
5408         dwz_basename parameter.
5409         * dwarf-index-write.c (write_gdbindex): Move file writing to
5410         write_gdbindex_1.  Change return type void.
5411         (assert_file_size): Move up, remove filename parameter.
5412         (write_gdbindex_1): New function.
5413         (write_debug_names): Change return type to void, call
5414         assert_file_size.
5415         (struct index_wip_file): New struct.
5416         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5417         file logic to index_wip_file.  Write index for dwz file if
5418         needed.
5419         (save_gdb_index_command): Pass basename of dwz file, if present.
5420         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5421         build-id of dwz file, if present.
5422         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5423         (dwarf2_get_dwz_file): Likewise.
5424         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5425         (dwarf2_get_dwz_file): Likewise.
5426
5427 2019-06-16  Tom Tromey  <tom@tromey.com>
5428
5429         * coffread.c (process_coff_symbol): Use xstrdup.
5430         * value.c (create_internalvar): Use xstrdup.
5431
5432 2019-06-16  Tom Tromey  <tom@tromey.com>
5433
5434         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5435         * breakpoint.c (stopin_command, stopat_command)
5436         (until_break_command, decode_location_default): Remove unnecessary
5437         cast.
5438         * utils.c (subset_compare): Remove unnecessary cast.
5439         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5440         cast.
5441         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5442         cast.
5443         * infcmd.c (path_command): Remove unnecessary cast.
5444         * coffread.c (decode_type): Remove unnecessary cast.
5445         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5446         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5447         * tui/tui-stack.c (tui_show_locator_content)
5448         (tui_show_frame_info): Remove unnecessary cast.
5449         * tui/tui-win.c (tui_scroll_forward_command)
5450         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5451         (parse_scrolling_args): Remove unnecessary cast.
5452         * tui/tui-data.c (init_win_info, tui_del_window)
5453         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5454         (free_content_elements): Remove unnecessary cast.
5455         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5456         unnecessary cast.
5457         * tui/tui-source.c (tui_set_source_content)
5458         (tui_vertical_source_scroll): Remove unnecessary cast.
5459         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5460         cast.
5461         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5462         * tui/tui-regs.c (tui_display_registers_from)
5463         (tui_display_register): Remove unnecessary cast.
5464         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5465         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5466         (make_visible): Remove unnecessary cast.
5467         * tui/tui-winsource.c (tui_erase_source_content)
5468         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5469         unnecessary cast.
5470         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5471         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5472         * stabsread.c (read_type, read_array_type, read_range_type):
5473         Remove unnecessary cast.
5474         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5475         (parse_symbol, parse_type, upgrade_type, parse_external)
5476         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5477         unnecessary cast.
5478         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5479
5480 2019-06-16  Tom Tromey  <tom@tromey.com>
5481
5482         * tui/tui-data.c (tui_alloc_generic_win_info)
5483         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5484         checks.
5485
5486 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5487             Andrew Burgess  <andrew.burgess@embecosm.com>
5488
5489         * f-typeprint.c (f_print_type): Don't return early for not
5490         associated or not allocated types.
5491         (f_type_print_varspec_suffix): Add print_rank parameter and print
5492         ranks of array types in case they dangling.
5493         (f_type_print_base): Add print_rank parameter.
5494
5495 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * NEWS: Mention new MI commands.
5498         * break-catch-throw.c (enum exception_event_kind): Move to
5499         breakpoint.h.
5500         (print_mention_exception_catchpoint): Output text as a single
5501         message.
5502         (catch_exception_command_1): Rename to...
5503         (catch_exception_event): ...this, make non-static, update header
5504         command, and change some parameter types.
5505         (catch_catch_command): Update for changes to
5506         catch_exception_command_1.
5507         (catch_throw_command): Likewise.
5508         (catch_rethrow_command): Likewise.
5509         * breakpoint.c (enum exception_event_kind): Delete.
5510         * breakpoint.h (enum exception_event_kind): Moved here from
5511         break-catch-throw.c.
5512         (catch_exception_event): Declare.
5513         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5514         (mi_cmd_catch_throw): New function.
5515         (mi_cmd_catch_rethrow): New function.
5516         (mi_cmd_catch_catch): New function.
5517         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5518         'catch-catch' entries.
5519         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5520         (mi_cmd_catch_rethrow): Declare.
5521         (mi_cmd_catch_catch): Declare.
5522
5523 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5524
5525         * annotate.c (annotate_source_line): Change return type to void,
5526         update implementation to match.
5527         * annotate.h (annotate_source_line): Change return type to void,
5528         update header comment.
5529         * stack.c (print_frame_info): Don't change what frame information
5530         is printed based on whether annotations are on or not.
5531
5532 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5533
5534         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5535         (annotate_source): Make static.
5536         (annotate_source_line): Moved from source.c and renamed from
5537         identify_source_line.  Update the return type.
5538         * annotate.h (annotate_source): Delete declaration.
5539         (annotate_source_line): Declaration moved from source.h, and
5540         renamed from identify_source_line.  Return type updated.
5541         * source.c (identify_source_line): Moved to annotate.c and renamed
5542         to annotate_source_line.
5543         (info_line_command): Remove check of annotation_level.
5544         * source.h (identify_source_line): Move declaration to annotate.h
5545         and rename to annotate_source_line.
5546         * stack.c: Add 'annotate.h' include.
5547         (print_frame_info): Remove check of annotation_level before
5548         calling annotate_source_line.
5549
5550 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5551
5552         * source-cache.c (source_cache::get_plain_source_lines): Use
5553         open_source_file_with_line_charpos instead of just
5554         open_source_file, remove call to find_source_lines.
5555         (source_cache::get_source_lines): Likewise.
5556         * source.c (find_source_lines): Make static.
5557         (get_filename_and_charpos): Renamed into...
5558         (open_source_file_with_line_charpos): ..this along with changes to
5559         return a scoped_fd, and some other minor clean ups.
5560         (identify_source_line): Use open_source_file_with_line_charpos.
5561         (search_command_helper): Use open_source_file_with_line_charpos
5562         instead of just open_source_file, remove call to
5563         find_source_lines.
5564         * source.h (open_source_file_with_line_charpos): Declare new
5565         function.
5566         (find_source_lines): Delete declaration.
5567
5568 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5569
5570         * source.c (get_filename_and_charpos): Remove fullname
5571         parameter.
5572         (identify_source_line): Update call to get_filename_and_charpos.
5573
5574 2019-06-14  Tom Tromey  <tromey@adacore.com>
5575
5576         PR gdb/24502:
5577         * ui-style.h (skip_ansi_escape): Update comment.
5578         * ui-file.h (class no_terminal_escape_file): New class.
5579         * ui-file.c (no_terminal_escape_file::write)
5580         (no_terminal_escape_file::puts): New methods.
5581         * cli/cli-logging.c (handle_redirections): Use
5582         no_terminal_escape_file.
5583
5584 2019-06-14  Tom Tromey  <tromey@adacore.com>
5585
5586         * NEWS: Move convenience variable news above Python news.
5587
5588 2019-06-14  Tom Tromey  <tom@tromey.com>
5589
5590         * gnulib: Move directory to top-level.
5591         * configure.ac: Don't configure gnulib.
5592         * configure: Rebuild.
5593         * common/common-defs.h: Use new path to gnulib.
5594         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5595         (GNULIB_H): Remove.
5596         (INCGNU): Look in new gnulib location.
5597         (HFILES_NO_SRCDIR): Remove gnulib files.
5598         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5599         (generated_files): Remove GNULIB_H.
5600         ($(LIBGNU), all-lib): Remove targets.
5601         (distclean): Don't mention GNULIB_BUILDDIR.
5602         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5603
5604 2019-06-14  Tom Tromey  <tromey@adacore.com>
5605
5606         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5607         Warn if symbol file does not provide any symbols.
5608
5609 2019-06-14  Tom Tromey  <tromey@adacore.com>
5610
5611         * source.c (find_and_open_source): Respect basenames_may_differ.
5612
5613 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5614
5615         * annotate.c (annotate_breakpoints_invalid): Make use of
5616         scoped_restore_terminal_state.
5617         (annotate_frames_invalid): Likewise.
5618
5619 2019-06-14  Tom Tromey  <tromey@adacore.com>
5620
5621         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5622         allow assignment to an internalvar.
5623
5624 2019-06-14  Tom Tromey  <tromey@adacore.com>
5625
5626         * ada-lex.l: Allow "_" in attribute names.
5627
5628 2019-06-14  Tom Tromey  <tromey@adacore.com>
5629
5630         PR gdb/24653:
5631         * regcache.c (registers_changed): Don't call alloca.
5632         * top.c (execute_command): Don't call alloca.
5633
5634 2019-06-13  Pedro Alves  <palves@redhat.com>
5635
5636         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5637         'expression'.  When parsing an expression, error out if there's
5638         junk after "unlimited".
5639         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5640         (do_set_command): Adjust calls to is_unlimited_literal.
5641
5642 2019-06-13  Pedro Alves  <palves@redhat.com>
5643
5644         * compile/compile.c (make_compile_options_def_group): Add braces
5645         around array_view initializer.
5646         * thread.c (make_thread_apply_all_options_def_group)
5647         (make_thread_apply_all_options_def_group): Likewise.
5648
5649 2019-06-13  Pedro Alves  <palves@redhat.com>
5650
5651         * NEWS (New commands): Mention "maint test-options
5652         require-delimiter", "maint test-options unknown-is-error", "maint
5653         test-options unknown-is-operand" and "maint show
5654         test-options-completion-result".
5655         (New command options, command completion): New section.
5656         (Completion improvements): New section.
5657         Mention that you can abbreviate "unlimited".
5658
5659 2019-06-13  Pedro Alves  <palves@redhat.com>
5660
5661         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5662         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5663         * unittests/cli-utils-selftests.c (test_parse_flags)
5664         (test_parse_flags_qcs): Delete.
5665         (test_cli_utils): Don't call deleted functions.
5666
5667 2019-06-13  Pedro Alves  <palves@redhat.com>
5668
5669         * thread.c: Include "cli/cli-option.h".
5670         (tp_array_compar_ascending): Global.
5671         (tp_array_compar): Delete function.
5672         (tp_array_compar_ascending, tp_array_compar_descending): New
5673         functions.
5674         (ascending_option_def, qcs_flag_option_def)
5675         (thr_qcs_flags_option_defs)
5676         (make_thread_apply_all_options_def_group)
5677         (make_thread_apply_options_def_group): New.
5678         (thread_apply_all_command): Use gdb::option::process_options.
5679         (thread_apply_command_completer)
5680         (thread_apply_all_command_completer): New.
5681         (thread_apply_command): Use gdb::option::process_options.
5682         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5683         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5684         to generate help text of "thread apply".  Adjust "taas"'s help.
5685         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5686         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5687
5688 2019-06-13  Pedro Alves  <palves@redhat.com>
5689
5690         * thread.c (thread_apply_command): Check for invalid TID with
5691         isdigit instead of !isalpha.
5692
5693 2019-06-13  Pedro Alves  <palves@redhat.com>
5694
5695         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5696         (validate_flags_qcs): New.
5697         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5698         (validate_flags_qcs): Declare.
5699         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5700         (make_frame_apply_options_def_group): New.
5701         (frame_apply_command_count): Process options with
5702         gdb::option::process_options.
5703         (frame_apply_completer): New.
5704         (frame_apply_level_completer, frame_apply_all_completer)
5705         (frame_apply_completer): New.
5706         (_initialize_stack): Update help of "frame apply", "frame apply
5707         level", "frame apply all" and "faas" to mention supported options
5708         and install command completers.
5709         * stack.h (frame_apply_all_completer): Declare.
5710         * thread.c: Include "stack.h".
5711         (tfaas_command): Add "--".
5712         (_initialize_thread): Update help "tfaas" to mention supported
5713         options and install command completer.
5714
5715 2019-06-13  Pedro Alves  <palves@redhat.com>
5716
5717         * completer.c (complete_nested_command_line): New.
5718         (gdb_completion_word_break_characters_throw): Add assertion.
5719         * completer.h (complete_nested_command_line): Declare.
5720
5721 2019-06-13  Pedro Alves  <palves@redhat.com>
5722
5723         * stack.c (parse_backtrace_qualifiers): New.
5724         (backtrace_command): Use it.
5725         (backtrace_command_completer): Complete on qualifiers.
5726
5727 2019-06-13  Pedro Alves  <palves@redhat.com>
5728
5729         * frame.c: Include "cli/cli-option.h.
5730         (user_set_backtrace_options): New.
5731         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5732         Delete.
5733         (get_prev_frame): Adjust.
5734         (boolean_option_def, uinteger_option_def)
5735         (set_backtrace_option_defs): New.
5736         (_initialize_frame): Adjust and use
5737         gdb::option::add_setshow_cmds_for_options to install "set
5738         backtrace past-main" and "set backtrace past-entry".
5739         * frame.h: Include "cli/cli-option.h".
5740         (struct frame_print_options): Forward declare.
5741         (print_frame_arguments_all, print_frame_arguments_scalars)
5742         (print_frame_arguments_none): Declare.
5743         (print_entry_values): Delete declaration.
5744         (struct frame_print_options, user_frame_print_options): New.
5745         (struct set_backtrace_options): New.
5746         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5747         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5748         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5749         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5750         (list_args_or_locals): Add frame_print_options parameter.
5751         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5752         * python/py-framefilter.c (enumerate_args): Pass down
5753         USER_FRAME_PRINT_OPTIONS.
5754         * stack.c: Include "cli/cli-option.h".
5755         (print_frame_arguments_all, print_frame_arguments_scalars)
5756         (print_frame_arguments_none): Declare.
5757         (print_raw_frame_arguments, print_entry_values): Delete.
5758         (user_frame_print_options): New.
5759         (boolean_option_def, enum_option_def, frame_print_option_defs):
5760         New.
5761         (struct backtrace_cmd_options): New.
5762         (bt_flag_option_def): New.
5763         (backtrace_command_option_defs): New.
5764         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5765         (print_frame_arg, read_frame_arg, print_frame_args)
5766         (print_frame_info, print_frame): Add frame_print_options parameter
5767         and use it.
5768         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5769         (backtrace_command_1): Add frame_print_options and
5770         backtrace_cmd_options parameters and use them.
5771         (make_backtrace_options_def_group): New.
5772         (backtrace_command): Process command options with
5773         gdb::option::process_options.
5774         (backtrace_command_completer): New.
5775         (_initialize_stack): Extend "backtrace"'s help to mention
5776         supported options.  Install completer for "backtrace".
5777         Install some settings commands with add_setshow_cmds_for_options.
5778
5779 2019-06-13  Pedro Alves  <palves@redhat.com>
5780
5781         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5782         and that "set/show print raw frame-arguments" are now deprecated.
5783
5784         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5785         command.
5786         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5787         * stack.c (_initialize_stack): Install "set/show print
5788         raw-frame-arguments", and deprecate "set/show print raw
5789         frame-arguments".
5790         * valprint.c (_initialize_valprint): Deprecate "set/show print
5791         raw".
5792
5793 2019-06-13  Pedro Alves  <palves@redhat.com>
5794
5795         * compile/compile.c (struct compile_options): New.
5796         (compile_flag_option_def, compile_command_option_defs)
5797         (make_compile_options_def_group): New.
5798         (compile_file_command): Handle options with
5799         gdb::option::process_options.
5800         (compile_file_command_completer): New function.
5801         (compile_code_command): Handle options with
5802         gdb::option::process_options.
5803         (compile_code_command_completer): New function.
5804         (_initialize_compiler): Install completers for "compile code" and
5805         "compile file".  Mention available options in "compile code" and
5806         "compile code"'s help.
5807         * completer.c (advance_to_completion_word): New, factored out from
5808         ...
5809         (advance_to_expression_complete_word_point): ... this.
5810         (advance_to_filename_complete_word_point): New.
5811         * completer.h (advance_to_filename_complete_word_point): New
5812         declaration.
5813
5814 2019-06-13  Pedro Alves  <palves@redhat.com>
5815
5816         * compile/compile.c: Include "cli/cli-option.h".
5817         (compile_print_value): Scope data pointer is now a
5818         value_print_options pointer; adjust.
5819         (compile_print_command): Process options.  Scope data pointer is
5820         now a value_print_options pointer; adjust.
5821         (_initialize_compile): Update "compile print"'s help to include
5822         supported options.  Install a completer for "compile print".
5823         * cp-valprint.c (show_vtblprint, show_objectprint)
5824         (show_static_field_print): Delete.
5825         (_initialize_cp_valprint): Don't install "set print
5826         static-members", "set print vtbl", "set print object" here.
5827         * printcmd.c: Include "cli/cli-option.h" and
5828         "common/gdb_optional.h".
5829         (print_command_parse_format): Rework to fill in a
5830         value_print_options instead of a format_data.
5831         (print_value): Change parameter type from format_data pointer to
5832         value_print_options reference.  Adjust.
5833         (print_command_1): Process options.  Adjust to pass down a
5834         value_print_options.
5835         (print_command_completer): New.
5836         (_initialize_printcmd): Install print_command_completer as
5837         handle_brkchars completer for the "print" command.  Update
5838         "print"'s help to include supported options.
5839         * valprint.c: Include "cli/cli-option.h".
5840         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5841         here from cp-valprint.c.
5842         (boolean_option_def, uinteger_option_def)
5843         (value_print_option_defs, make_value_print_options_def_group):
5844         New.  Use gdb::option::add_setshow_cmds_for_options to install
5845         "set print elements", "set print null-stop", "set print repeats",
5846         "set print pretty", "set print union", "set print array", "set
5847         print address", "set print symbol", "set print array-indexes".
5848         * valprint.h: Include <string> and "cli/cli-option.h".
5849         (make_value_print_options_def_group): Declare.
5850         (print_value): Change parameter type from format_data pointer to
5851         value_print_options reference.
5852         (print_command_completer): Declare.
5853
5854 2019-06-13  Pedro Alves  <palves@redhat.com>
5855
5856         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5857         (COMMON_SFILES): Add maint-test-settings.c.
5858         * cli/cli-decode.c (boolean_enums): New global, factored out from
5859         ...
5860         (add_setshow_boolean_cmd): ... here.
5861         * cli/cli-decode.h (boolean_enums): Declare.
5862         * cli/cli-option.c: New file.
5863         * cli/cli-option.h: New file.
5864         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5865         factored out from ...
5866         (parse_cli_boolean_value(const char *)): ... this.
5867         (is_unlimited_literal): Change parameter type to pointer to
5868         pointer.  Adjust and advance ARG pointer.
5869         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5870         (parse_cli_var_enum): New, factored out from ...
5871         (do_set_command): ... this.  Adjust.
5872         * cli/cli-setshow.h (parse_cli_boolean_value)
5873         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5874         (parse_cli_var_enum): Declare.
5875         * cli/cli-utils.c: Include "cli/cli-option.h".
5876         (get_ulongest): New.
5877         * cli/cli-utils.h (get_ulongest): Declare.
5878         (check_for_argument): New overloads.
5879         * maint-test-options.c: New file.
5880
5881 2019-06-13  Pedro Alves  <palves@redhat.com>
5882
5883         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5884         parse a range if "-" is at the end of the string.
5885
5886 2019-06-13  Pedro Alves  <palves@redhat.com>
5887
5888         * cli/cli-setshow.c (parse_auto_binary_operation)
5889         (parse_cli_boolean_value): Don't allow "o".
5890
5891 2019-06-13  Pedro Alves  <palves@redhat.com>
5892
5893         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5894         * NEWS: Mention maint test-settings KIND.
5895         * maint-test-settings.c: New file.
5896
5897 2019-06-13  Pedro Alves  <palves@redhat.com>
5898
5899         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5900         completer.
5901         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5902         "set" completers.
5903
5904 2019-06-13  Pedro Alves  <palves@redhat.com>
5905
5906         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5907         after item.
5908
5909 2019-06-13  Pedro Alves  <palves@redhat.com>
5910
5911         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5912
5913 2019-06-13  Pedro Alves <palves@redhat.com>
5914
5915         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5916         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5917         call.
5918         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5919         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5920         calls.
5921         (check_for_argument): Skip spaces after argument.
5922
5923 2019-06-13  Pedro Alves  <palves@redhat.com>
5924
5925         * thread.c (thread_apply_command): Adjust TID parsing.
5926         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5927         detected before end of string.
5928         (tid_is_in_list): Error out if LIST is invalid.
5929
5930 2019-06-13  Pedro Alves  <palves@redhat.com>
5931
5932         * completer.c (complete_line_internal_1): Rewind completion word
5933         point.
5934         (completion_tracker::advance_custom_word_point_by): Change
5935         parameter type to int.
5936         * completer.h (completion_tracker::advance_custom_word_point_by):
5937         Likewise.
5938
5939 2019-06-13  Pedro Alves  <palves@redhat.com>
5940
5941         * completer.c (advance_to_completion_word): Handle delimiters.
5942
5943 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5944
5945         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5946
5947 2019-06-11  Tom Tromey  <tom@tromey.com>
5948
5949         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5950         (xmalloc_failed): Move to alloc.c.
5951         * alloc.c: New file.
5952         * Makefile.in (COMMON_SFILES): Add alloc.c.
5953
5954 2019-06-11  Tom Tromey  <tom@tromey.com>
5955
5956         * nat/linux-waitpid.c: Don't include server.h.
5957         (linux_debug): Remove.
5958         (my_waitpid): Update.
5959
5960 2019-06-11  Tom Tromey  <tromey@adacore.com>
5961
5962         * infcall.c (_initialize_infcall): Remove trailing newline from
5963         help.
5964         * user-regs.c (_initialize_user_regs): Remove trailing newline
5965         from help.
5966         * typeprint.c (_initialize_typeprint): Remove trailing newline
5967         from help.
5968         * reverse.c (_initialize_reverse): Remove trailing newlines from
5969         help.
5970         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5971         from help.
5972         * language.c (add_set_language_command): Remove trailing newline
5973         from help.
5974         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5975         help.
5976         * disasm.c (_initialize_disasm): Remove trailing newline from
5977         help.
5978         * top.c (init_main): Remove trailing newline from help.
5979         * interps.c (_initialize_interpreter): Remove trailing newline
5980         from help.
5981         * btrace.c (_initialize_btrace): Remove trailing newlines from
5982         help.
5983         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5984         from help.
5985         * python/python.c (_initialize_python): Remove trailing newline
5986         from help.
5987         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5988         help.
5989         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5990         from help.  Reformat some text.
5991         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5992         from help.
5993         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5994         newline from help.
5995
5996 2019-06-11  Tom Tromey  <tromey@adacore.com>
5997
5998         * darwin-nat.c (darwin_decode_exception_message)
5999         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6000
6001 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6002
6003         * valops.c (value_slice): Check for not allocated or not
6004         associated values.
6005
6006 2019-06-10  Tom de Vries  <tdevries@suse.de>
6007
6008         PR gdb/24618
6009         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6010         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6011         invalid.
6012
6013 2019-06-10  Tom de Vries  <tdevries@suse.de>
6014
6015         PR gdb/24611
6016         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6017         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6018
6019 2019-06-10  Tom de Vries  <tdevries@suse.de>
6020
6021         PR symtab/24545
6022         * symtab.c (struct demangled_name_entry): Add language field.
6023         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6024         static minimal symbol".  Set and use language field.
6025
6026 2019-06-10  Tom Tromey  <tromey@adacore.com>
6027
6028         * ada-lang.c (_initialize_ada_language): Update help text.
6029
6030 2019-06-10  Tom Tromey  <tromey@adacore.com>
6031
6032         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6033         with a newline.
6034         * guile/guile.c (handle_boot_error): Don't end warning with a
6035         newline.
6036         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6037         warning with a newline.
6038         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6039         newline.
6040         (s12z_frame_cache): Likewise.
6041         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6042         a newline.
6043         * solib-svr4.c (disable_probes_interface): Don't end warning with
6044         a newline.
6045         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6046         newline.
6047         * python/python.c (do_finish_initialization): Don't end warning
6048         with a newline.
6049
6050 2019-06-10  Tom Tromey  <tom@tromey.com>
6051
6052         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6053         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6054         gdbpy_enter.
6055
6056 2019-06-10  Tom Tromey  <tromey@adacore.com>
6057
6058         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6059         data.
6060         (elf_new_init): Don't call stabsread_new_init.
6061         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6062         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6063         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6064
6065 2019-06-10  Tom de Vries  <tdevries@suse.de>
6066
6067         PR symtab/16264
6068         PR symtab/24517
6069         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6070
6071 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6072
6073         * source.c (find_and_open_source): Also rewrite relative file
6074         names.
6075
6076 2019-04-26  Amos Bird  <amosbird@gmail.com>
6077
6078         * annotate.c (annotate_thread_exited): Add "thread-exited"
6079         annotation.
6080
6081 2019-06-06  Tom Tromey  <tromey@adacore.com>
6082
6083         * maint.h (class scoped_command_stats): Use
6084         DISABLE_COPY_AND_ASSIGN.
6085         <print_time>: New method.
6086         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6087         print_time.
6088         (scoped_command_stats::print_time): New method.
6089
6090 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6091
6092         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6093         instructions of lengths 6 or 8 bytes.
6094
6095 2019-06-04  Pedro Alves  <palves@redhat.com>
6096
6097         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6098
6099         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6100         * breakpoint.c (condition_completer): Likewise.
6101         * cli/cli-dump.c (scan_expression): Likewise.
6102         * common/filestuff.c (mkdir_recursive): Likewise.
6103         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6104         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6105         (gdb_abspath): Likewise.
6106         * compile/compile-cplus-types.c
6107         (compile_cplus_instance::decl_name): Likewise.
6108         * completer.c (complete_explicit_location):
6109         (signal_completer, reg_or_group_completer_1): Likewise.
6110         * cp-support.c (cp_remove_params_if_any): Likewise.
6111         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6112         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6113         * infcmd.c (strip_bg_char): Likewise.
6114         * linespec.c (copy_token_string): Likewise.
6115         * mi/mi-main.c (output_cores): Likewise.
6116         * psymtab.c (psymtab_search_name):
6117         * symfile.c (test_set_ext_lang_command): Likewise.
6118         * target.c (target_fileio_read_stralloc): Likewise.
6119         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6120         * value.c (complete_internalvar): Likewise.
6121
6122 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6123
6124         Add objfile property to gdb.Type.
6125         * NEWS: Mention Python API addition.
6126         * python/py-type.c (typy_get_objfile): New method.
6127
6128 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6129
6130         * NEWS: Mention the new set|show style [title|highlight].
6131         Mention changes to "show style", "help" and "apropos".
6132
6133 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6134
6135         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6136         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6137         instead of print_help_for_command.
6138         (print_doc_of_command): New function.
6139         (help_list): Add 'apropos -v word' suggestion.
6140         (print_help_for_command): Style the command name using title style.
6141         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6142         (_initialize_cli_cmds): Describe -v in apropos_command help.
6143
6144 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6145
6146         * cli/cli-style.h (cli_style_option): Add name in constructor,
6147         add m_name class member, add constructor with intensity,
6148         add name class function.
6149         (cli_style_option::add_setshow_commands): Remove name argument.
6150         (highlight_style, title_style): New styles.
6151         * cli/cli-style.c (do_show): New function that shows a style
6152         characteristic styling the style name with itself.
6153         (set_style_name): New function.
6154         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6155         Update all callers according to the changes in cli/cli-style.h.
6156         * utils.h (fputs_highlighted): New function.
6157         * utils.c (fputs_highlighted): Likewise.
6158
6159 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6160
6161         * NEWS: Mention new pipe command and new convenience variables.
6162
6163 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6164
6165         * cli/cli-cmds.c (pipe_command): New function.
6166         (_initialize_cli_cmds): Call add_com for pipe_command.
6167         Define | as an alias for pipe.
6168         (exit_status_set_internal_vars): New function.
6169         (shell_escape): Call exit_status_set_internal_vars.
6170         cli/cli-decode.c (find_command_name_length): Recognize | as
6171         a single character command.
6172
6173 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6174
6175         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6176         top.c (execute_command_to_ui_file): New function, mostly a copy
6177         of execute_command_to_string.
6178         (execute_command_to_string): Implement by calling
6179         execute_command_to_ui_file.
6180
6181 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6182
6183         * top.h (saved_command_line): Remove declaration.
6184         * top.c (previous_saved_command_line, previous_repeat_arguments):
6185         New variables.
6186         (saved_command_line): Make static, define together with other
6187         'repeat variables'.
6188         (dont_repeat): Clear repeat_arguments.
6189         (repeat_previous, get_saved_command_line, save_command_line):
6190         New functions.
6191         (gdb_init): Initialize saved_command_line
6192         and previous_saved_command_line.
6193         * main.c (captured_main_1): Remove saved_command_line initialization.
6194         * event-top.c (handle_line_of_input): Update to use
6195         the new 'repeat' related functions instead of direct access to
6196         saved_command_line.
6197         * command.h (repeat_previous, get_saved_command_line,
6198         save_command_line): New declarations.
6199         (dont_repeat): Add comment.
6200
6201 2019-05-30  Tom Tromey  <tromey@adacore.com>
6202
6203         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6204         Fix comment.
6205         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6206
6207 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6208
6209         PR cli/24587
6210         * completer.c (complete): Initialize variable word.
6211
6212 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6213
6214         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6215         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6216         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6217         'body' is NULL to the outter 'if', protecting the '!is_define'
6218         situation as well.
6219
6220 2019-05-29  Tom Tromey  <tromey@adacore.com>
6221
6222         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6223         (dwarf_unknown): New function.
6224         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6225         (dwarf_type_encoding_name): Use dwarf_unknown.
6226
6227 2019-05-29  Tom Tromey  <tromey@adacore.com>
6228
6229         PR c++/20020:
6230         * cp-valprint.c (cp_print_value_fields): Call
6231         cp_print_static_field inside "try".
6232
6233 2019-05-29  Tom Tromey  <tromey@adacore.com>
6234
6235         * inflow.c (struct terminal_info): Add default operator=.
6236         * configure: Rebuild.
6237         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6238         -Wdeprecated-copy-dtor, -Wredundant-move.
6239
6240 2019-05-29  Tom Tromey  <tromey@adacore.com>
6241
6242         * NEWS: Add entry.
6243         * infcmd.c (print_return_value_1): Handle finish_print
6244         option.
6245         (show_print_finish): New function.
6246         (_initialize_infcmd): Add "set/show print finish" commands.
6247         * valprint.c (user_print_options): Initialize new member.
6248         * valprint.h (struct value_print_options) <finish_print>: New
6249         member.
6250
6251 2019-05-28  Tom Tromey  <tromey@adacore.com>
6252
6253         * ada-lang.c (ada_remove_Xbn_suffix)
6254         (find_old_style_renaming_symbol)
6255         (parse_old_style_renaming): Remove.
6256         (ada_find_renaming_symbol): Don't call
6257         find_old_style_renaming_symbol.
6258         (ada_is_renaming_symbol): Rename from
6259         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6260         bool.  Now static.
6261         (ada_read_var_value): Update and simplify.
6262         * ada-exp.y (write_var_or_type): Remove old code.
6263
6264 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6265
6266         * event-top.c: Remove include comment.
6267         * inflow.c (class scoped_ignore_sigttou): Move from here...
6268         * inflow.h (class scoped_ignore_sigttou): ...to here.
6269         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6270         * top.c:  Remove include comment.
6271
6272 2019-05-27  Tom Tromey  <tom@tromey.com>
6273
6274         * NEWS: Fix typo.
6275
6276 2019-05-22  Tom Tromey  <tromey@adacore.com>
6277
6278         * target.c (target_follow_exec): Constify parameter.
6279         * target-delegates.c: Rebuild.
6280         * remote.c (remote_target::follow_exec): Constify parameter.
6281         * infrun.c (follow_exec): Constify parameter.
6282         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6283         (target_follow_exec): Likewise.
6284
6285 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6286
6287         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6288         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6289
6290 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6291
6292         * NEWS: Add debugredirect and testsuite sections.
6293
6294 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6295
6296         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6297         target descriptions using exclusively floating point register name
6298         aliases.
6299
6300 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6301
6302         PR gdb/18644:
6303         * f-lang.c (build_fortran_types): Handle the case where
6304         gdbarch_floatformat_for_type returns a nullptr.
6305
6306 2019-05-21  Tom de Vries  <tdevries@suse.de>
6307
6308         PR cli/24587
6309         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6310
6311 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         PR gdb/18644:
6314         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6315         16-byte floats.
6316         * i386-tdep.c (i386_floatformat_for_type): Use
6317         floatformats_ia64_quad for the 16-byte floating point component
6318         within a fortran 32-byte complex number.
6319
6320 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6321
6322         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6323         delete default constructor.
6324         (find_partial_die): Update to return const struct.
6325         (partial_die_parent_scope): Move variable declaration into scope
6326         of its use and change its type to auto.
6327         (guess_partial_die_structure_name): Likewise.
6328         (partial_die_info::fixup): Likewise.
6329
6330 2019-05-17  Tom Tromey  <tromey@adacore.com>
6331
6332         * source.c (find_and_open_source): Remove cast.
6333
6334 2019-05-17  Tom Tromey  <tromey@adacore.com>
6335
6336         * annotate.c (annotate_source): Make "filename" const.
6337         * annotate.h (annotate_source): Use const.
6338
6339 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6340
6341         * disasm.c (set_disassembler_options): Send errors to stderr.
6342
6343 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6344
6345         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6346         (cli_interp_base::set_logging): Check debug_redirect.
6347         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6348         * cli/cli-logging.c (debug_redirect): Add static variable.
6349         (pop_output_files): Add default param.
6350         (handle_redirections): Print debug setting.
6351         (show_logging_command): Likewise.
6352         (_initialize_cli_logging): Add debugredirect command.
6353         * interps.c (current_interp_set_logging): Add debug_redirect
6354         parameter.
6355         * interps.h (set_logging): Add debug_redirect parameter.
6356         (current_interp_set_logging): Likewise.
6357         * mi/mi-common.h: Likewise.
6358         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6359
6360 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6361             Tom Tromey  <tromey@adacore.com>
6362
6363         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6364         directly.
6365         * cli/cli-interp.h (make_logging_output): Remove declaration.
6366         * cli/cli-logging.c (make_logging_output): Remove function.
6367         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6368         directly.
6369         * ui-file.c (tee_file::tee_file): Remove bools.
6370         (tee_file::~tee_file): Remove deletes.
6371         * ui-file.h (tee_file): Remove bools.
6372
6373 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6374
6375         * mi/mi-cmds.h (mi_cmd_complete): New function.
6376         * mi/mi-main.c (mi_cmd_complete): Likewise.
6377         * mi/mi-cmds.c: Define new MI command -complete.
6378         * NEWS: Mention new -complete command.
6379
6380 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6381
6382         * completer.h (complete): New function.
6383         * completer.c (complete): Likewise.
6384         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6385         function defined in completer.h.
6386
6387 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6388
6389         * MAINTAINERS (Write After Approval): Add myself.
6390
6391 2019-05-17  Tom de Vries  <tdevries@suse.de>
6392
6393         PR gdb/24094
6394         * dwarf2read.c (struct cu_partial_die_info): New struct.
6395         (find_partial_die): Return cu_partial_die_info.
6396         (partial_die_parent_scope, guess_partial_die_structure_name)
6397         (partial_die_info::fixup): Handle new return type of find_partial_die.
6398
6399 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6400
6401         PR breakpoints/24541
6402         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6403         "std::string", simplifying the algorithm.
6404
6405 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6406
6407         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6408         (stap_static_probe_ops::get_probes): Likewise.
6409
6410 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6411
6412         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6413         '-')" and "else if".
6414         (stap_parse_single_operand): Join checks for
6415         "gdbarch_stap_parse_special_token_p" and
6416         "gdbarch_stap_parse_special_token" in the same "if" statement.
6417         Invert check when verifying for operation on register
6418         displacement.
6419
6420 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6421
6422         * stap-probe.c (stap_get_opcode): Update comment.
6423         (stap_get_expected_argument_type): Likewise.
6424         (handle_stap_probe): Likewise.
6425
6426 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6427
6428         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6429         return type to 'bool'.  Adjust comment.  Use 'bool' when
6430         appropriate.
6431         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6432         * stap-probe.c (stap_parse_argument_1): Likewise.
6433         (stap_is_operator): Likewise.
6434         (stap_is_generic_prefix): Likewise.
6435         (stap_is_register_prefix): Likewise.
6436         (stap_is_register_indirection_prefix): Likewise.
6437         (stap_is_integer_prefix): Likewise.
6438         (stap_generic_check_suffix): Likewise.
6439         (stap_check_integer_suffix): Likewise.
6440         (stap_check_register_suffix): Likewise.
6441         (stap_check_register_indirection_suffix): Likewise.
6442         (stap_parse_register_operand): Likewise.
6443         (stap_parse_single_operand): Likewise.
6444         (stap_parse_argument_1): Likewise.
6445         (stap_probe::get_argument_count): Likewise.
6446         (stap_is_operator): Likewise.
6447
6448 2019-05-16  Tom Tromey  <tromey@adacore.com>
6449
6450         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6451         keyword to foreach.
6452
6453 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6454
6455         * linux-thread-db.c (try_thread_db_load_1): Change return type
6456         to bool.
6457         (try_thread_db_load): Likewise.
6458         (try_thread_db_load_from_pdir_1): Likewise.
6459         (try_thread_db_load_from_pdir): Likewise.
6460         (try_thread_db_load_from_sdir): Likewise.
6461         (try_thread_db_load_from_dir): Likewise.
6462         (thread_db_load_search): Likewise.
6463         (has_libpthread): Likewise.
6464         (thread_db_load): Likewise.
6465
6466 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6467
6468         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6469         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6470         NULL, and complain/return if that's the case.
6471
6472 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6473
6474         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6475         (advance, posn, abstract_read_memory): New functions.
6476         [struct mem_read_abstraction]: New struct.
6477         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6478
6479 2019-05-14  Tom Tromey  <tromey@adacore.com>
6480
6481         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6482         value is not lval_memory.
6483
6484 2019-05-14  Tom Tromey  <tromey@adacore.com>
6485
6486         * solib.c (info_sharedlibrary_command): Style the file name.
6487
6488 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6489
6490         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6491         (aarch64_vnv_type): Likewise.
6492         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6493         * common/tdesc.c: Likewise.
6494         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6495         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6496         * features/aarch64-fpu.xml: Add ieee half view.
6497         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6498         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6499         * gdbtypes.h (struct builtin_type): Likewise.
6500         (struct objfile_type): Likewise.
6501
6502 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6503
6504         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6505         typo.
6506         * location.h (string_to_event_location): Likewise.
6507
6508 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6509
6510         GDB 8.3 released.
6511
6512 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6513
6514         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6515         New variable declaration.
6516         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6517         New variable.
6518         (print_one_breakpoint): Use ui_out::test_flags and new global
6519         variable to compute use_fixed_output.
6520         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6521         Remove.
6522         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6523         (mi_multi_location_breakpoint_output_fixed): Remove.
6524         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6525         new variable.
6526         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6527         fix_multi_location_breakpoint_output flag if version >= 3.
6528         * ui-out.h (enum ui_out_flag)
6529         <fix_multi_location_breakpoint_output>: New enumerator.
6530
6531 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6532
6533         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6534
6535 2019-05-10  Tom Tromey  <tromey@adacore.com>
6536
6537         * ada-lang.c (catch_ada_completer): New function.
6538         (_initialize_ada_language): Use it.
6539
6540 2019-05-10  Tom Tromey  <tromey@adacore.com>
6541
6542         * thread.c (print_thread_info): Make "requested_threads" const.
6543         * gdbthread.h (print_thread_info): Make "requested_threads"
6544         const.
6545         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6546         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6547
6548 2019-05-08  Tom Tromey  <tom@tromey.com>
6549
6550         * gdbtypes.c (objfile_type_data): Change type.
6551         (objfile_type, _initialize_gdbtypes): Update.
6552
6553 2019-05-08  Tom Tromey  <tom@tromey.com>
6554
6555         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6556         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6557         (_initialize_dwarf2_frame): Update.
6558
6559 2019-05-08  Tom Tromey  <tom@tromey.com>
6560
6561         * objc-lang.c (objc_objfile_data): Change type.
6562         (find_methods): Update.
6563         (_initialize_objc_lang): Remove.
6564
6565 2019-05-08  Tom Tromey  <tom@tromey.com>
6566
6567         * stabsread.c (rs6000_builtin_type_data): Change type.
6568         (rs6000_builtin_type, _initialize_stabsread): Update.
6569
6570 2019-05-08  Tom Tromey  <tom@tromey.com>
6571
6572         * mips-tdep.c (mips_pdr_data): Remove.
6573         (_initialize_mips_tdep): Update.
6574
6575 2019-05-08  Tom Tromey  <tom@tromey.com>
6576
6577         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6578         (hppa_init_objfile_priv_data, read_unwind_info)
6579         (find_unwind_entry, _initialize_hppa_tdep): Update.
6580
6581 2019-05-08  Tom Tromey  <tom@tromey.com>
6582
6583         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6584         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6585         on obstack.
6586         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6587
6588 2019-05-08  Tom Tromey  <tom@tromey.com>
6589
6590         * mdebugread.c (basic_type_data): Change type.
6591         (basic_type, _initialize_mdebugread): Update.
6592
6593 2019-05-08  Tom Tromey  <tom@tromey.com>
6594
6595         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6596
6597 2019-05-08  Tom Tromey  <tom@tromey.com>
6598
6599         * nto-tdep.c (nto_inferior_data_reg): Change type.
6600         (nto_inferior_data): Update.
6601         (nto_inferior_data_cleanup, nto_new_inferior_data)
6602         (_initialize_nto_tdep): Remove.
6603         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6604
6605 2019-05-08  Tom Tromey  <tom@tromey.com>
6606
6607         * ada-lang.c (struct ada_inferior_data): Add initializers.
6608         (ada_inferior_data): Change type.
6609         (ada_inferior_data_cleanup): Remove.
6610         (get_ada_inferior_data, ada_inferior_exit)
6611         (struct ada_pspace_data): Add initializers, destructor.
6612         (ada_pspace_data_handle): Change type.
6613         (get_ada_pspace_data): Update.
6614         (ada_pspace_data_cleanup): Remove.
6615
6616 2019-05-08  Tom Tromey  <tom@tromey.com>
6617
6618         * coffread.c (struct coff_symfile_info): Add initializers.
6619         (coff_objfile_data_key): Move lower.  Change type.
6620         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6621         Update.
6622         (coff_free_info): Remove.
6623
6624 2019-05-08  Tom Tromey  <tom@tromey.com>
6625
6626         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6627         (fbsd_pspace_data_handle): Move lower.  Change type.
6628         (get_fbsd_pspace_data): Update.
6629         (fbsd_pspace_data_cleanup): Remove.
6630         (_initialize_fbsd_tdep): Update.
6631
6632 2019-05-08  Tom Tromey  <tom@tromey.com>
6633
6634         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6635         (get_ada_tasks_pspace_data): Update.
6636         (ada_tasks_pspace_data_cleanup): Remove.
6637         (_initialize_tasks): Update.
6638         (ada_tasks_inferior_data_handle): Change type.
6639         (get_ada_tasks_inferior_data): Update.
6640         (ada_tasks_inferior_data_cleanup): Remove.
6641         (struct ada_tasks_pspace_data): Add initializers.
6642
6643 2019-05-08  Tom Tromey  <tom@tromey.com>
6644
6645         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6646         * symfile-debug.c (debug_sym_get_probes): Change type.
6647         * stap-probe.c (handle_stap_probe):
6648         (stap_static_probe_ops::get_probes): Change type.
6649         * probe.h (class static_probe_ops) <get_probes>: Change type.
6650         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6651         (parse_probes_in_pspace): Update.
6652         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6653         Update.
6654         (any_static_probe_ops::get_probes): Change type.
6655         * elfread.c (elfread_data): New typedef.
6656         (probe_key): Change type.
6657         (elf_get_probes): Likewise.  Update.
6658         (probe_key_free): Remove.
6659         (_initialize_elfread): Update.
6660         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6661         Change type.
6662         (dtrace_process_dof_probe, dtrace_process_dof)
6663         (dtrace_static_probe_ops::get_probe): Change type.
6664
6665 2019-05-08  Tom Tromey  <tom@tromey.com>
6666
6667         * xcoffread.c (struct xcoff_symfile_info): Rename from
6668         coff_symfile_info.  Add initializers.
6669         (xcoff_objfile_data_key): Move lower.  Change type.
6670         (XCOFF_DATA): Rewrite.
6671         (xcoff_free_info): Remove.
6672         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6673         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6674         (xcoff_initial_scan): Update.
6675
6676 2019-05-08  Tom Tromey  <tom@tromey.com>
6677
6678         * solib-svr4.c (struct svr4_info): Add initializers and
6679         destructor.
6680         <probes_table>: Now an htab_up.
6681         (solib_svr4_pspace_data): Change type.
6682         (free_probes_table): Simplify.
6683         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6684         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6685         (probes_table_remove_objfile_probes, register_solib_event_probe)
6686         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6687         (_initialize_svr4_solib): Update.
6688
6689 2019-05-08  Tom Tromey  <tom@tromey.com>
6690
6691         * remote.c (remote_pspace_data): Change type.
6692         (remote_pspace_data_cleanup): Remove.
6693         (get_remote_exec_file, set_pspace_remote_exec_file)
6694         (_initialize_remote): Update.
6695
6696 2019-05-08  Tom Tromey  <tom@tromey.com>
6697
6698         * breakpoint.c (breakpoint_objfile_key): Change type.
6699         (get_breakpoint_objfile_data): Update.
6700         (free_breakpoint_objfile_data): Remove.
6701         (_initialize_breakpoint): Update.
6702
6703 2019-05-08  Tom Tromey  <tom@tromey.com>
6704
6705         * linux-tdep.c (struct linux_info): Add initializers.
6706         (linux_inferior_data): Move.  Change type.
6707         (invalidate_linux_cache_inf): Update.
6708         (linux_inferior_data_cleanup): Remove.
6709         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6710
6711 2019-05-08  Tom Tromey  <tom@tromey.com>
6712
6713         * auxv.c (auxv_inferior_data): Move.  Change type.
6714         (auxv_inferior_data_cleanup): Remove.
6715         (invalidate_auxv_cache_inf): Rewrite.
6716         (get_auxv_inferior_data, _initialize_auxv): Update.
6717
6718 2019-05-08  Tom Tromey  <tom@tromey.com>
6719
6720         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6721         (symfile_debug_objfile_data_key): Change type.
6722         (symfile_debug_installed, debug_qf_has_symbols)
6723         (debug_qf_find_last_source_symtab)
6724         (debug_qf_forget_cached_source_info)
6725         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6726         (debug_qf_print_stats, debug_qf_dump)
6727         (debug_qf_expand_symtabs_for_function)
6728         (debug_qf_expand_all_symtabs)
6729         (debug_qf_expand_symtabs_with_fullname)
6730         (debug_qf_map_matching_symbols)
6731         (debug_qf_expand_symtabs_matching)
6732         (debug_qf_find_pc_sect_compunit_symtab)
6733         (debug_qf_map_symbol_filenames)
6734         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6735         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6736         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6737         (debug_sym_read_linetable, debug_sym_relocate): Update.
6738         (symfile_debug_free_objfile): Remove.
6739         (install_symfile_debug_logging, _initialize_symfile_debug):
6740         Update.
6741
6742 2019-05-08  Tom Tromey  <tom@tromey.com>
6743
6744         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6745         allocate_on_obstack.
6746         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6747         (get_dwarf2_per_objfile): Update.
6748         (set_dwarf2_per_objfile): Remove.
6749         (dwarf2_has_info, dwarf2_get_section_info): Update.
6750         (dwarf2_free_objfile): Remove.
6751         (_initialize_dwarf2_read): Update.
6752
6753 2019-05-08  Tom Tromey  <tom@tromey.com>
6754
6755         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6756         initializers.
6757         <unsupported_script_warning_printed,
6758         script_not_found_warning_printed>: Now bool.
6759         (auto_load_pspace_data): Change type.
6760         (~auto_load_pspace_info): Rename from
6761         auto_load_pspace_data_cleanup.
6762         (get_auto_load_pspace_data, init_loaded_scripts_info)
6763         (clear_section_scripts, maybe_print_unsupported_script_warning)
6764         (maybe_print_script_not_found_warning, _initialize_auto_load):
6765         Update.
6766
6767 2019-05-08  Tom Tromey  <tom@tromey.com>
6768
6769         * objfiles.c (objfile_pspace_info): Add destructor and
6770         initializers.
6771         (objfiles_pspace_data): Change type.
6772         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6773         (get_objfile_pspace_data): Update.
6774         (objfiles_bfd_data): Change type.
6775         (get_objfile_bfd_data): Update.
6776         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6777
6778 2019-05-08  Tom Tromey  <tom@tromey.com>
6779
6780         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6781         Change type.
6782         (get_catch_syscall_inferior_data): Update.
6783         (catch_syscall_inferior_data_cleanup): Remove.
6784         (_initialize_break_catch_syscall): Update.
6785
6786 2019-05-08  Tom Tromey  <tom@tromey.com>
6787
6788         * inflow.c (struct terminal_info): Add destructor and
6789         initializers.
6790         (inflow_inferior_data): Change type.
6791         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6792         (get_inflow_inferior_data, inflow_inferior_exit)
6793         (swap_terminal_info, _initialize_inflow): Update.
6794
6795 2019-05-08  Tom Tromey  <tom@tromey.com>
6796
6797         * target-dcache.c (target_dcache_cleanup): Remove.
6798         (target_dcache_aspace_key): Change type.
6799         (target_dcache_init_p, target_dcache_invalidate)
6800         (target_dcache_get, target_dcache_get_or_init)
6801         (_initialize_target_dcache): Update.
6802         * dcache.h (struct dcache_deleter): New.
6803
6804 2019-05-08  Tom Tromey  <tom@tromey.com>
6805
6806         * symtab.c (struct symbol_cache): Add destructor and
6807         initializers.
6808         (symbol_cache_key): Move.  Change type.
6809         (make_symbol_cache, free_symbol_cache): Remove.
6810         (get_symbol_cache): Update.
6811         (symbol_cache_cleanup): Remove.
6812         (ALL_PSPACES, symbol_cache_flush)
6813         (maintenance_print_symbol_cache)
6814         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6815         Update.
6816
6817 2019-05-08  Tom Tromey  <tom@tromey.com>
6818
6819         * symtab.c (struct main_info): Add destructor and initializers.
6820         (main_progspace_key): Move.  Change type.
6821         (get_main_info): Update.
6822         (main_info_cleanup): Remove.
6823         (_initialize_symtab): Update.
6824
6825 2019-05-08  Tom Tromey  <tom@tromey.com>
6826
6827         * registry.h (DECLARE_REGISTRY): Define the _key class.
6828
6829 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6830
6831         * NEWS: Merge two 'New commands' sections.
6832
6833 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6834
6835         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6836         parameter and use Ada language definition instead.
6837         (ada_val_print_ptr): Remove unused language parameter.
6838         (ada_val_print_num): Remove language parameter and use Ada language
6839         definition instead.
6840         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6841         parameter.
6842         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6843         parameter and use Ada language definition instead.
6844         (ada_val_print_1): Update all ada_val_print_xxx calls.
6845         Remove language parameter.
6846         (ada_val_print): Update ada_val_print_1 call.
6847
6848 2019-05-08  Tom Tromey  <tromey@adacore.com>
6849
6850         * remote.c (remote_hw_watchpoint_limit)
6851         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6852         Now static.
6853
6854 2019-05-08  Tom Tromey  <tromey@adacore.com>
6855
6856         * maint.c (_initialize_maint_cmds): Move initialization code to
6857         remote.c.
6858         (watchdog, show_watchdog): Move to remote.c.
6859         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6860         "watchdog" static.
6861         (_initialize_remote): Move initialization code from maint.c.
6862         * defs.h (watchdog): Don't declare.
6863
6864 2019-05-08  Tom Tromey  <tromey@adacore.com>
6865
6866         * tui/tui-interp.c: Include main.h.
6867         * interps.c: Include main.h.
6868         * main.h (interpreter_p): Declare.
6869         * defs.h (interpreter_p): Don't declare.
6870
6871 2019-05-08  Tom Tromey  <tromey@adacore.com>
6872
6873         * dwarf2loc.c: Include dwarf2read.h.
6874         * defs.h (read_unsigned_leb128): Don't declare.
6875         * dwarf2read.h (read_unsigned_leb128): Declare.
6876
6877 2019-05-08  Tom Tromey  <tromey@adacore.com>
6878
6879         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6880         method.
6881
6882 2019-05-08  Tom Tromey  <tromey@adacore.com>
6883
6884         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6885         when no wrap column is set.
6886
6887 2019-05-08  Tom Tromey  <tromey@adacore.com>
6888
6889         * c-lang.c (c_get_string): Handle non-C-style arrays.
6890
6891 2019-05-08  Tom Tromey  <tromey@adacore.com>
6892
6893         * typeprint.c (print_offset_data::update): Print the bit offset,
6894         not the number of bits remaining.
6895
6896 2019-05-08  Tom Tromey  <tromey@adacore.com>
6897
6898         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6899         padding at end of comment.
6900
6901 2019-05-08  Tom Tromey  <tromey@adacore.com>
6902
6903         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6904         Compare main types.
6905
6906 2019-05-06  Tom Tromey  <tom@tromey.com>
6907
6908         * common/scoped_mmap.c: Include common-defs.h.
6909         * common/scoped_mmap.h: Don't include config.h.
6910
6911 2019-05-04  Tom Tromey  <tom@tromey.com>
6912
6913         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6914         (struct aarch64_call_info): Add initializers.
6915         <si>: Now a std::vector.
6916         (pass_on_stack, aarch64_push_dummy_call): Update.
6917
6918 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6919             Tom Tromey  <tom@tromey.com>
6920
6921         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6922         (ppc_threads): Now a std::vector.  Now static.
6923         (hwdebug_find_thread_points_by_tid)
6924         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6925         Update.
6926
6927 2019-05-04  Tom Tromey  <tom@tromey.com>
6928
6929         * arc-tdep.c (arc_tdesc_init): Return bool.
6930
6931 2019-05-04  Tom Tromey  <tom@tromey.com>
6932
6933         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6934         Use gdb_assert_not_reached.
6935
6936 2019-05-04  Tom Tromey  <tom@tromey.com>
6937
6938         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6939         "false".
6940
6941 2019-05-04  Tom Tromey  <tom@tromey.com>
6942
6943         * arc-tdep.c (arc_tdesc_init): Use bool.
6944
6945 2019-05-04  Tom Tromey  <tom@tromey.com>
6946
6947         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6948
6949 2019-05-04  Tom Tromey  <tom@tromey.com>
6950
6951         * cli/cli-cmds.c (valid_command_p): Return bool.
6952
6953 2019-05-04  Tom Tromey  <tom@tromey.com>
6954
6955         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6956         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6957
6958 2019-05-04  Raul Tambre  <raul@tambre.ee>
6959
6960         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6961         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6962         operator for comparison.
6963
6964 2019-05-04  Tom Tromey  <tom@tromey.com>
6965
6966         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6967         (lookup_partial_symbol, print_partial_symbols)
6968         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6969         (psymbol_compare): Update.
6970         (add_psymbol_to_bcache): Clear the entire psymbol.
6971         (maintenance_check_psymtabs): Update.
6972         * psympriv.h (struct partial_symbol): Don't derive from
6973         general_symbol_info.
6974         <obj_section, unrelocated_address, address,
6975         set_unrelocated_address>: Update.
6976         <ginfo>: New member.
6977         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6978         (debug_names::write_psymbols): Update.
6979
6980 2019-05-04  Tom de Vries  <tdevries@suse.de>
6981
6982         * contrib/cc-with-tweaks.sh: Support -n arg.
6983
6984 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6985
6986         * corelow.c (core_target::detach): Ensure frame cache and
6987         register caches are cleared.
6988         inferior.c (exit_inferior_1): Likewise.
6989
6990 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6991             Tom Tromey  <tom@tromey.com>
6992
6993         * dictionary.c (collate_pending_symbols_by_language): Remove
6994         "struct" from foreach.
6995         * symtab.c (lookup_global_symbol_from_objfile)
6996         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6997         foreach.
6998         * ser-tcp.c (net_open): Remove "struct" from foreach.
6999         * objfiles.c (objfile_relocate, objfile_rebase)
7000         (objfile_has_symbols): Remove "struct" from foreach.
7001         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7002         from foreach.
7003         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7004         foreach.
7005         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7006         "struct" from foreach.
7007         * ada-lang.c (create_excep_cond_exprs)
7008         (ada_exception_catchpoint_cond_string): Remove "struct" from
7009         foreach.
7010
7011 2019-05-03  Tom Tromey  <tromey@adacore.com>
7012
7013         * ada-exp.y (convert_char_literal): Check suffix of each
7014         enumerator.
7015
7016 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7017
7018         PR ada/21406:
7019         * ada-exp.y (yywrap): Don't define.
7020         * ada-lex.l (%option): Add noyywrap
7021         (yywrap): Remove.
7022
7023 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7024
7025         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7026         _WIN32_WINNT to the XP level, unless already defined to a higher
7027         level.
7028
7029         * unittests/parse-connection-spec-selftests.c:
7030         * ser-tcp.c:
7031         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7032         override.
7033
7034         * symfile.c (find_separate_debug_file): Remove colon from the
7035         drive spec of DOS/Windows file names of the target, so that the
7036         file name produced from DEBUGDIR and the target's directory will
7037         be valid on DOS/Windows systems.
7038
7039 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7040
7041         * rust-lang.c (val_print_struct): Handle printing structures
7042         containing strings.
7043
7044 2019-05-02  Tom Tromey  <tromey@adacore.com>
7045
7046         * valarith.c (_initialize_valarith): Remove.
7047
7048 2019-05-01  Tom Tromey  <tromey@adacore.com>
7049
7050         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7051         bitfields.
7052
7053 2019-05-01  Tom Tromey  <tromey@adacore.com>
7054
7055         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7056         for big-endian copies.
7057
7058 2019-04-30  Ali Tamur  <tamur@google.com>
7059         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7060         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7061         (read_3_bytes): New function.
7062
7063 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7064
7065         * windows-nat.c (main_thread_id): Delete.
7066         (handle_output_debug_string): Replace main_thread_id by
7067         current_event.dwThreadId.
7068         (fake_create_process): Likewise.
7069         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7070         Do not set main_thread_id.
7071         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7072         current_event.dwThreadId.
7073         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7074
7075 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7076
7077         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7078         Use current_event.dwThreadId instead of main_thread_id.
7079
7080 2019-04-30  Tom Tromey  <tromey@adacore.com>
7081
7082         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7083         (create_excep_cond_exprs): Iterate over program spaces.
7084         (ada_exception_catchpoint_cond_string): Examine all minimal
7085         symbols for exception types.
7086
7087 2019-04-30  Tom Tromey  <tromey@adacore.com>
7088
7089         PR c++/24470:
7090         * dwarf2read.c (process_structure_scope): Handle case where type
7091         has template parameters but no symbol was created.
7092
7093 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7094             Chris January  <chris.january@arm.com>
7095
7096         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7097         qualifier.
7098         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7099
7100 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         * f-typeprint.c (f_print_type): Update rules for printing
7103         whitespace.
7104         (f_type_print_varspec_suffix): Likewise.
7105
7106 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7107             Chris January  <chris.january@arm.com>
7108
7109         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7110         function arguments.
7111
7112 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7113
7114         * f-lang.c (build_fortran_types): Change name of void type to
7115         lower case.
7116         * f-typeprint.c (f_type_print_base): Print the name of the void
7117         type, rather than a fixed string.
7118         * f-valprint.c (f_decorations): Use lower case void string.
7119
7120 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7121             Chris January  <chris.january@arm.com>
7122
7123         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7124         types for Fortran.
7125
7126 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7127             Chris January  <chris.january@arm.com>
7128             David Lecomber  <david.lecomber@arm.com>
7129
7130         * f-exp.y (BINOP_INTRINSIC): New token.
7131         (exp): New parser rule handling BINOP_INTRINSIC.
7132         (f77_keywords): Add new builtin procedures.
7133         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7134         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7135         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7136         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7137         (print_unop_subexp_f): New function.
7138         (print_binop_subexp_f): New function.
7139         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7140         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7141         (dump_subexp_body_f): Likewise.
7142         (operator_check_f): Likewise.
7143         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7144         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7145
7146 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7149         UNOP_KIND.
7150         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7151         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7152         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7153         (operator_length_f): New fuction.
7154         (print_subexp_f): New function.
7155         (op_name_f): New function.
7156         (dump_subexp_body_f): New function.
7157         (operator_check_f): New function.
7158         (exp_descriptor_f): Replace standard expression handling functions
7159         with new functions.
7160         * gdb/fortran-operator.def: New file.
7161         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7162         * gdb/std-operator.def: Remove UNOP_KIND.
7163
7164 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7165
7166         * std-operator.def: Remove unbalanced, stray double quote
7167         character.
7168
7169 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7170             Chris January  <chris.january@arm.com>
7171             Daniel Everett  <daniel.everett@arm.com>
7172             Nick Forrington  <nick.forrington@arm.com>
7173             Richard Bunt  <richard.bunt@arm.com>
7174
7175         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7176         of depth when printing anonymous structs or unions.
7177         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7178         Don't print either the top-level value, or the children if the
7179         max-depth is exceeded.
7180         (ppscm_print_children): When printing the key of a map, allow one
7181         extra level of depth.
7182         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7183         print either the top-level value, or the children if the max-depth
7184         is exceeded.
7185         (print_children): When printing the key of a map, allow one extra
7186         level of depth.
7187         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7188         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7189         (user_print_options): Initialise max_depth field.
7190         (val_print_scalar_or_string_type_p): New function.
7191         (val_print): Check to see if the max depth has been reached.
7192         (val_print_check_max_depth): Define new function.
7193         (show_print_max_depth): New function.
7194         (_initialize_valprint): Add 'print max-depth' option.
7195         * valprint.h (struct value_print_options) <max_depth>: New field.
7196         (val_print_check_max_depth): Declare new function.
7197         * NEWS: Document new feature.
7198
7199 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7200
7201         * ada-lang.c (ada_language_defn): Initialise new field.
7202         * c-lang.c (c_is_string_type_p): New function.
7203         (c_language_defn): Initialise new field.
7204         (cplus_language_defn): Initialise new field.
7205         (asm_language_defn): Initialise new field.
7206         (minimal_language_defn): Initialise new field.
7207         * c-lang.h (c_is_string_type_p): Declare new function.
7208         * d-lang.c (d_language_defn): Initialise new field.
7209         * f-lang.c (f_is_string_type_p): New function.
7210         (f_language_defn): Initialise new field.
7211         * go-lang.c (go_is_string_type_p): New function.
7212         (go_language_defn): Initialise new field.
7213         * language.c (default_is_string_type_p): New function.
7214         (unknown_language_defn): Initialise new field.
7215         (auto_language_defn): Initialise new field.
7216         * language.h (struct language_defn) <la_is_string_type_p>: New
7217         member variable.
7218         (default_is_string_type_p): Declare new function.
7219         * m2-lang.c (m2_language_defn): Initialise new field.
7220         * objc-lang.c (objc_language_defn): Initialise new field.
7221         * opencl-lang.c (opencl_language_defn): Initialise new field.
7222         * p-lang.c (pascal_is_string_type_p): New function.
7223         (pascal_language_defn): Initialise new field.
7224         * rust-lang.c (rust_is_string_type_p): New function.
7225         (rust_language_defn): Initialise new field.
7226
7227 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7228
7229         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7230         New field.
7231         * ada-lang.c (ada_language_defn): Initialise new field.
7232         * c-lang.c (c_language_defn): Likewise.
7233         (cplus_language_defn): Likewise.
7234         (asm_language_defn): Likewise.
7235         (minimal_language_defn): Likewise.
7236         * d-lang.c (d_language_defn): Likewise.
7237         * f-lang.c (f_language_defn): Likewise.
7238         * go-lang.c (go_language_defn): Likewise.
7239         * language.c (unknown_language_defn): Likewise.
7240         (auto_language_defn): Likewise.
7241         * m2-lang.c (m2_language_defn): Likewise.
7242         * objc-lang.c (objc_language_defn): Likewise.
7243         * opencl-lang.c (opencl_language_defn): Likewise.
7244         * p-lang.c (pascal_language_defn): Likewise.
7245         * rust-lang.c (rust_language_defn): Likewise.
7246
7247 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * ada-lang.c (ada_is_character_type): Change return type to bool.
7250         (ada_is_string_type): Likewise.
7251         * ada-lang.h (ada_is_character_type): Update declaration
7252         (ada_is_string_type): Likewise.
7253
7254 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7255
7256         Support style in 'frame|thread apply'
7257
7258         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7259         * record.c (record_start, record_stop): Update callers of
7260         execute_command_to_string with false.
7261         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7262         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7263         methods.
7264         (class string_file): New constructor with term_out parameter.
7265         Override methods term_out and can_emit_style_escape.  New member
7266         term_out.
7267         (class stdio_file): Override can_emit_style_escape.
7268         (class tee_file): Override term_out and can_emit_style_escape.
7269         * utils.h (can_emit_style_escape): Remove.
7270         * utils.c (can_emit_style_escape): Likewise.
7271         Update all callers of can_emit_style_escape (SOMESTREAM) to
7272         SOMESTREAM->can_emit_style_escape.
7273         * source-cache.c (source_cache::get_source_lines): Likewise.
7274         * stack.c (frame_apply_command_count): Call execute_command_to_string
7275         passing the term_out characteristic of the current gdb_stdout.
7276         * thread.c (thr_try_catch_cmd): Likewise.
7277         * top.c (execute_command_to_string): pass term_out parameter
7278         to construct the string_file for the command output.
7279         * ui-file.c (term_cli_styling): New function (most code moved
7280         from utils.c can_emit_style_escape).
7281         (string_file::string_file, string_file::can_emit_style_escape,
7282         stdio_file::can_emit_style_escape, tee_file::term_out,
7283         tee_file::can_emit_style_escape): New functions.
7284
7285 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7286
7287         * NEWS: Mention the new set|show may-call-functions.
7288         * infcall.c (may_call_functions_p): New variable.
7289         (show_may_call_functions_p): New function.
7290         (call_function_by_hand_dummy): Throws an error if not
7291         may-call-functions.
7292         (_initialize_infcall): Call add_setshow_boolean_cmd for
7293         may-call-functions.
7294
7295 2019-04-25  Keith Seitz  <keiths@redhat.com>
7296
7297         PR c++/24367
7298         * cp-support.c (inspect_type): Don't attempt substitutions
7299         of symbol with the same name.
7300
7301 2019-04-25  Tom Tromey  <tromey@adacore.com>
7302
7303         PR gdb/24475:
7304         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7305         static.
7306
7307 2019-04-25  Tom Tromey  <tromey@adacore.com>
7308
7309         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7310         rvalue reference.
7311         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7312         (gdb_xml_parser::parse): Use std::move.
7313         * python/python-internal.h (gdbpy_convert_exception): Take a const
7314         reference.
7315         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7316         std::move.
7317         * python/py-utils.c (gdbpy_convert_exception): Take a const
7318         reference.
7319         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7320         Use std::move.
7321         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7322         Use std::move.
7323         * mi/mi-main.c (mi_print_exception): Take a const reference.
7324         * main.c (handle_command_errors): Take a const reference.
7325         * linespec.c (parse_linespec): Use std::move.
7326         * infcall.c (run_inferior_call): Use std::move.
7327         (call_function_by_hand_dummy): Use std::move.
7328         * exec.c (try_open_exec_file): Use std::move.
7329         * exceptions.h (exception_print, exception_fprintf)
7330         (exception_print_same): Update.
7331         * exceptions.c (print_exception, exception_print)
7332         (exception_fprintf, exception_print_same): Change parameters to
7333         const reference.
7334         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7335         * common/new-op.c: Use std::move.
7336         * common/common-exceptions.h (struct gdb_exception): Add move
7337         constructor.
7338         (struct gdb_exception_error, struct gdb_exception_quit, struct
7339         gdb_quit_bad_alloc): Change constructor to move constructor.
7340         (throw_exception): Change parameter to rvalue reference.
7341         * common/common-exceptions.c (throw_exception): Take rvalue
7342         reference.
7343         * cli/cli-interp.c (safe_execute_command): Use std::move.
7344         * breakpoint.c (insert_bp_location, location_to_sals): Use
7345         std::move.
7346
7347 2019-04-25  Tom Tromey  <tromey@adacore.com>
7348
7349         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7350         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7351         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7352         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7353         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7354         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7355         guile/scm-value.c: Use unpack.
7356         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7357         gdbscm_gdb_exception.
7358         (gdbscm_throw_gdb_exception): Likewise.
7359         (struct gdbscm_gdb_exception): New.
7360         (unpack): New function.
7361         (gdbscm_wrap): Use unpack.
7362
7363 2019-04-25  Tom Tromey  <tromey@adacore.com>
7364
7365         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7366         (gdb_rl_callback_handler): Use std::move.
7367         * common/common-exceptions.h (struct gdb_exception): Add move
7368         assignment operator.
7369         (throw_exception_sjlj): Change "exception" to const reference.
7370         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7371         (throw_exception_sjlj): Change "exception" to const reference.
7372
7373 2019-04-25  Tom Tromey  <tromey@adacore.com>
7374
7375         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7376         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7377         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7378         Update.
7379         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7380         Update.
7381         * mi/mi-interp.c (mi_interp::exec): Update.
7382         * linespec.c (parse_linespec): Update.
7383         * infcall.c (run_inferior_call): Update.
7384         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7385         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7386         (gdbscm_lookup_global_symbol): Update.
7387         * guile/scm-param.c (gdbscm_parameter_value): Update.
7388         * guile/scm-frame.c (gdbscm_frame_read_register)
7389         (gdbscm_frame_read_var): Update.
7390         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7391         * exec.c (try_open_exec_file): Update.
7392         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7393         (gdb_rl_callback_handler): Update.
7394         * common/common-exceptions.h (exception_none): Don't declare.
7395         * common/common-exceptions.c (exception_none): Don't define.
7396         (struct catcher) <exception>: Update.
7397         * cli/cli-interp.c (safe_execute_command): Update.
7398         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7399
7400 2019-04-25  Ali Tamur  <tamur@google.com>
7401
7402         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7403         (read_attribute_value): Likewise.
7404         (dwarf2_read_addr_index): Update comment.
7405         (read_str_index): Add DW_FORM_strx.
7406         (dwarf2_string_attr): Likewise.
7407         (dwarf2_const_value_attr): Likewise.
7408         (dump_die_shallow): Likewise.
7409         (dwarf2_fetch_constant_bytes): Likewise.
7410         (skip_form_bytes): Likewise.
7411         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7412
7413 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7414
7415         PR corefiles/11608
7416         PR corefiles/18187
7417         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7418         OFFSET.  Verify if current mapping contains an ELF header.
7419         (linux_find_memory_regions_full): Adjust call to
7420         dump_mapping_p.
7421
7422 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7423             Kang Li <kanglictf@gmail.com>
7424
7425         PR gdb/21600
7426
7427         * dwarf2-frame.c (read_initial_length): Be consistent about using
7428         unsigned representation of length.
7429         (decode_frame_entry_1): Likewise.  Check for wraparound of
7430         end pointer as well as buffer overflow.
7431
7432 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7433
7434         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7435         "vq".
7436
7437 2019-04-24  Tom Tromey  <tromey@adacore.com>
7438
7439         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7440
7441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7442
7443         * s12z-tdep.c (s12z_unwind_pc): Delete.
7444         (s12z_unwind_sp): Delete.
7445         (s12z_gdbarch_init): Don't register deleted functions with
7446         gdbarch.
7447
7448 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7449
7450         * rl78-tdep.c (rl78_unwind_sp): Delete.
7451         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7452
7453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7454
7455         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7456         (xstormy16_unwind_pc): Delete.
7457         (xstormy16_dummy_id): Delete.
7458         (xstormy16_gdbarch_init): Don't register deleted functions with
7459         gdbarch.
7460
7461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7462
7463         * vax-tdep.c (vax_unwind_pc): Delete.
7464         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7465
7466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * v850-tdep.c (v850_unwind_sp): Delete.
7469         (v850_unwind_pc): Delete.
7470         (v850_dummy_id): Delete.
7471         (v850_gdbarch_init): Don't register deleted functions with
7472         gdbarch.
7473
7474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7475
7476         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7477         (tilegx_unwind_pc): Delete.
7478         (tilegx_unwind_dummy_id): Delete.
7479         (tilegx_gdbarch_init): Don't register deleted functions with
7480         gdbarch.
7481
7482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7483
7484         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7485         (tic6x_dummy_id): Delete.
7486         (tic6x_gdbarch_init): Don't register deleted functions with
7487         gdbarch.
7488
7489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7490
7491         * sparc-tdep.c (sparc_unwind_pc): Delete.
7492         (sparc32_gdbarch_init): Don't register deleted function with
7493         gdbarch.
7494
7495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7496
7497         * sh-tdep.c (sh_unwind_sp): Delete.
7498         (sh_unwind_pc): Delete.
7499         (sh_dummy_id): Delete.
7500         (sh_gdbarch_init): Don't register deleted functions with
7501         gdbarch.
7502
7503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7504
7505         * score-tdep.c (score_unwind_sp): Delete.
7506         (score_unwind_pc): Delete.
7507         (score_dummy_id): Delete.
7508         (score_gdbarch_init): Don't register deleted functions with
7509         gdbarch.
7510
7511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7512
7513         * rx-tdep.c (rx_unwind_pc): Delete.
7514         (rx_unwind_sp): Delete.
7515         (rx_dummy_id): Delete.
7516         (rx_gdbarch_init): Don't register deleted functions with
7517         gdbarch.  Update comment.
7518
7519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7522         (rs6000_dummy_id): Delete.
7523         (rs6000_gdbarch_init): Don't register deleted functions with
7524         gdbarch.
7525
7526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7527
7528         * or1k-tdep.c (or1k_dummy_id): Delete.
7529         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7530
7531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7532
7533         * nios2-tdep.c (nios2_dummy_id): Delete.
7534         (nios2_unwind_sp): Delete.
7535         (nios2_gdbarch_init): Don't register deleted functions with
7536         gdbarch.
7537
7538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7539
7540         * nds32-tdep.c (nds32_dummy_id): Delete.
7541         (nds32_unwind_pc): Delete.
7542         (nds32_unwind_sp): Delete.
7543         (nds32_gdbarch_init): Don't register deleted functions with
7544         gdbarch.
7545
7546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * msp430-tdep.c (msp430_unwind_pc): Delete.
7549         (msp430_unwind_sp): Delete.
7550         (msp430_dummy_id): Delete.
7551         (msp430_gdbarch_init): Don't register deleted functions with
7552         gdbarch.
7553
7554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * moxie-tdep.c (moxie_unwind_sp): Delete.
7557         (moxie_unwind_pc): Delete.
7558         (moxie_dummy_id): Delete.
7559         (moxie_gdbarch_init): Don't register deleted functions with
7560         gdbarch.
7561
7562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7563
7564         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7565         (mn10300_unwind_pc): Delete.
7566         (mn10300_unwind_sp): Delete.
7567         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7568         mn10300_unwind_sp.
7569         (mn10300_frame_unwind_init): Don't register deleted functions with
7570         gdbarch.
7571
7572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * mep-tdep.c (mep_unwind_pc): Delete.
7575         (mep_unwind_sp): Delete.
7576         (mep_dummy_id): Delete.
7577         (mep_gdbarch_init): Don't register deleted functions with
7578         gdbarch.
7579
7580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7581
7582         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7583         (m68hc11_unwind_sp): Delete.
7584         (m68hc11_gdbarch_init): Don't register deleted functions with
7585         gdbarch.
7586
7587 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7588
7589         * m32r-tdep.c (m32r_unwind_sp): Delete.
7590         (m32r_unwind_pc): Delete.
7591         (m32r_dummy_id): Delete.
7592         (m32r_gdbarch_init): Don't register deleted functions with
7593         gdbarch.
7594
7595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * m32c-tdep.c (m32c_unwind_pc): Delete.
7598         (m32c_unwind_sp): Delete.
7599         (m32c_dummy_id): Delete.
7600         (m32c_gdbarch_init): Don't register deleted functions with
7601         gdbarch.
7602
7603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7604
7605         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7606         (lm32_unwind_pc): Delete.
7607         (lm32_dummy_id): Delete.
7608         (lm32_gdbarch_init): Don't register deleted functions with
7609         gdbarch.
7610
7611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7612
7613         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7614         (iq2000_unwind_pc): Delete.
7615         (iq2000_dummy_id): Delete.
7616         (iq2000_gdbarch_init): Don't register deleted functions with
7617         gdbarch.
7618
7619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7620
7621         * nds32-tdep.c (nds32_type_align): Delete.
7622         (nds32_push_dummy_call): Use type_align instead.
7623
7624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7625
7626         * arm-tdep.c (arm_type_align): Only handle vector override case.
7627         (arm_push_dummy_call): Use type_align.
7628         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7629
7630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7631
7632         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7633         case.
7634         (pass_on_stack): Use type_align.
7635         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7636         function.
7637
7638 2019-04-23  Tom Tromey  <tromey@adacore.com>
7639
7640         * dwarf2read.c (line_header::file_name_at): Remove unused
7641         overload.
7642
7643 2019-04-23  Tom de Vries  <tdevries@suse.de>
7644
7645         PR gdb/24438
7646         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7647         invocation.
7648
7649
7650 2019-03-27  Ali Tamur  <tamur@google.com>
7651
7652         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7653         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7654         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7655         (dwarf_expr_context::get_addr_index): Likewise
7656         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7657         (symbol_needs_eval_context::get_addr_index): Likewise
7658         (disassemble_dwarf_expression): Add DW_OP_addrx
7659         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7660         (read_cutu_die_from_dwo): Update comment
7661         (skip_one_die): Add DW_FORM_addrx
7662         (read_attribute_value): Likewise
7663         (var_decode_location): Add DW_OP_addrx
7664         (dwarf2_const_value_attr): Add DW_FORM_addrx
7665         (dump_die_shallow): Likewise
7666         (dwarf2_fetch_constant_bytes): Likewise
7667         (decode_locdesc): Add DW_OP_addrx
7668         (skip_form_bytes): Add DW_FORM_addrx
7669
7670 2019-04-22  Ali Tamur  <tamur@google.com>
7671
7672         * MAINTAINERS (Write After Approval): Add self.
7673
7674 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7675
7676         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7677         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7678         (open_symbol_file_object): Likewise.
7679         (svr4_default_sos): Add info parameter.
7680         (svr4_read_so_list): Likewise.
7681         (svr4_current_sos_direct): Adjust functions calls to pass down
7682         info.
7683         (svr4_current_sos_1): Add info parameter.
7684         (svr4_current_sos): Call get_svr4_info, pass info down to
7685         svr4_current_sos_1.
7686         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7687         get_svr4_info.
7688         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7689         get_svr4_info.
7690         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7691         to get_svr4_info.
7692         (probes_table_remove_objfile_probes): Likewise.
7693         (register_solib_event_probe): Add info parameter.
7694         (solist_update_incremental): Pass info parameter down to
7695         svr4_read_so_list.
7696         (disable_probes_interface): Add info parameter.
7697         (svr4_handle_solib_event): Pass current_program_space to
7698         get_svr4_info.  Adjust disable_probes_interface cleanup.
7699         (svr4_create_probe_breakpoints): Add info parameter, pass it
7700         down to register_solib_event_probe.
7701         (svr4_create_solib_event_breakpoints): Add info parameter,
7702         pass it down to svr4_create_probe_breakpoints.
7703         (enable_break): Pass info down to
7704         svr4_create_solib_event_breakpoints.
7705         (svr4_solib_create_inferior_hook): Pass current_program_space to
7706         get_svr4_info.
7707         (svr4_clear_solib): Likewise.
7708
7709 2019-04-22  Pedro Alves  <palves@redhat.com>
7710
7711         * solib-svr4.c (svr4_free_objfile_observer): New.
7712         (probe_and_action::objfile): New field.
7713         (probes_table_htab_remove_objfile_probes)
7714         (probes_table_remove_objfile_probes): New functions.
7715         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7716         in the new probe_and_action.  Don't store the probe in 'lookup'.
7717         (svr4_create_probe_breakpoints): Pass objfile to
7718         register_solib_event_probe.
7719         (_initialize_svr4_solib): Register a free_objfile observer.
7720
7721 2019-04-19  Tom Tromey  <tom@tromey.com>
7722
7723         * common/queue.h: Remove.
7724
7725 2019-04-19  Tom Tromey  <tom@tromey.com>
7726
7727         * event-loop.c: Don't include "common/queue.h".
7728
7729 2019-04-19  Tom Tromey  <tom@tromey.com>
7730
7731         * remote.c (remote_target): Use delete.
7732         * remote-notif.h: Include <list>, not "common/queue.h".
7733         (notif_client_p): Remove typedef.
7734         (remote_notif_state): Add constructor, destructor, initializer.
7735         <notif_queue>: Now a std::list.
7736         (remote_notif_state_xfree): Don't declare.
7737         * remote-notif.c (remote_notif_process, handle_notification)
7738         (remote_notif_state_allocate): Update.
7739         (~remote_notif_state): Rename from remote_notif_state_xfree.
7740
7741 2019-04-19  Tom Tromey  <tom@tromey.com>
7742
7743         * symfile.c (reread_symbols): Update.
7744         * objfiles.c (objfile_register_static_link)
7745         (objfile_lookup_static_link): Update
7746         (~objfile) Don't delete static_links.
7747         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7748
7749 2019-04-19  Tom Tromey  <tom@tromey.com>
7750
7751         * type-stack.h (struct type_stack) <insert>: Constify string.
7752         * type-stack.c (type_stack::insert): Constify string.
7753         * gdbtypes.h (lookup_template_type): Update.
7754         (address_space_name_to_int): Update.
7755         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7756         const.
7757         (lookup_template_type): Make name const.
7758         * c-exp.y: Update rules.
7759         (lex_one_token, classify_name, classify_inner_name)
7760         (c_print_token): Update.
7761         * p-exp.y: Update rules.
7762         (yylex): Update.
7763         * f-exp.y: Update rules.
7764         (yylex): Update.
7765         * d-exp.y: Update rules.
7766         (lex_one_token, classify_name, classify_inner_name): Update.
7767         * parse.c (write_dollar_variable, copy_name): Return std::string.
7768         * parser-defs.h (copy_name): Change return type.
7769         * m2-exp.y: Update rules.
7770         (yylex): Update.
7771         * go-exp.y (lex_one_token): Update.
7772         Update rules.
7773         (classify_unsafe_function, classify_packaged_name)
7774         (classify_name, yylex): Update.
7775
7776 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7777
7778         * configure.ac: add --enable-source-highlight switch.
7779         * configure: Regenerate.
7780         * top.c (print_gdb_version): plumb --enable-source-highlight
7781         status to "show configuration".
7782
7783 2019-04-19  Tom Tromey  <tromey@adacore.com>
7784
7785         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7786         Check ADA_TYPE_P.
7787         (empty_record, ada_template_to_fixed_record_type_1)
7788         (template_to_static_fixed_type)
7789         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7790         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7791         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7792         macros.
7793
7794 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7795
7796         PR symtab/24423:
7797         * source.c (print_source_lines_base): Advance "iter" when a
7798         control character is seen.
7799
7800 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7801
7802         * inferior.h (struct infcall_suspend_state_deleter):
7803         Catch exception in destructor to avoid crash.
7804
7805 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7806
7807         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7808         close to the add_com "shell".
7809
7810 2019-04-18  Tom Tromey  <tromey@adacore.com>
7811
7812         * process-stratum-target.h (class process_stratum_target)
7813         <stratum>: Add "final".
7814
7815 2019-04-17  Tom Tromey  <tromey@adacore.com>
7816
7817         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7818         against nullptr before use.
7819
7820 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7821
7822         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7823
7824 2019-04-17  Jim Wilson  <jimw@sifive.com>
7825             Andrew Burgess  <andrew.burgess@embecosm.com>
7826
7827         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7828         code read might fail, assume 4-byte breakpoint in that case.
7829
7830 2019-04-15  Leszek Swirski  <leszeks@google.com>
7831
7832         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7833         rather than a hand-rolled POD check when checking for forced MEMORY
7834         classification.
7835
7836 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7837
7838         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7839         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7840         function.
7841         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7842         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7843         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7844         declaration.
7845
7846 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7847
7848         * aarch64-linux-nat.c
7849         (aarch64_linux_nat_target::thread_architecture): Add override.
7850         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7851         each VQ.
7852
7853 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7854
7855         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7856
7857 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7858
7859         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7860         target types of size 96-bits, add some additional comments, and
7861         check that the builtin type we found was the correct size.
7862
7863 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7864
7865         * utils.c (prompt_for_continue): Don't restore the styling at the
7866         end, as applied_style has the wrong value.  This fixes styling in
7867         long lists of file names that are interrupted by the "Continue?"
7868         prompt.
7869
7870 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7871
7872         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7873         * c-lang.c (c_language_defn): Likewise.
7874         (cplus_language_defn): Likewise.
7875         (asm_language_defn): Likewise.
7876         (minimal_language_defn): Likewise.
7877         * d-lang.c (d_language_defn): Likewise.
7878         * f-lang.c (f_language_defn): Likewise.
7879         * go-lang.c (go_language_defn): Likewise.
7880         * language.c (unknown_language_defn): Likewise.
7881         (auto_language_defn): Likewise.
7882         * language.h (struct language_defn): Remove la_magic field.
7883         (LANG_MAGIC): Delete.
7884         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7885         * objc-lang.c (objc_language_defn): Likewise.
7886         * opencl-lang.c (opencl_language_defn): Likewise.
7887         * p-lang.c (pascal_language_defn): Likewise.
7888         * rust-lang.c (rust_language_defn): Likewise.
7889
7890 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7891
7892         * riscv-tdep.c (riscv_type_align): New function.
7893         (riscv_type_alignment): Delete.
7894         (riscv_arg_location): Use 'type_align'.
7895         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7896
7897 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7898
7899         * gdbtypes.c (type_align): A struct with no non-static fields also
7900         has alignment of 1.
7901
7902 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7903
7904         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7905         component to 0.
7906         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7907         member.
7908         (riscv_struct_info::analyse): New implementation using new
7909         analyse_inner member function.
7910         (riscv_struct_info::field_offset): New member function.
7911         (riscv_struct_info::m_offsets): New member variable.
7912         (riscv_struct_info::analyse_inner): New private member function,
7913         takes the old implementation of riscv_struct_info::analyse but
7914         extended to track field offsets.
7915         (riscv_call_arg_struct): Update the struct folding special cases
7916         to handle cases where empty C++ structs, which are non-zero
7917         length, are found.
7918         (riscv_arg_location): Initialise the length of each location, a
7919         non-zero length now indicates the location is in use.
7920         (riscv_push_dummy_call): Allow for the first location having a
7921         non-zero offset when setting up arguments.
7922         (riscv_return_value): Likewise, but for return values.
7923
7924 2019-04-11  Tom Tromey  <tromey@adacore.com>
7925
7926         * utils.c (internal_vproblem): Make "msg" const.
7927
7928 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7929
7930         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7931         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7932         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7933         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7934
7935 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7936
7937         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7938         function.
7939         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7940         of amd64_collect_native_gregset.
7941         (amd64_linux_nat_target::store_registers): Likewise.
7942
7943 2019-04-10  Tom Tromey  <tom@tromey.com>
7944
7945         * symtab.c (lookup_global_symbol_from_objfile)
7946         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7947         * objfiles.h (class separate_debug_iterator): New.
7948         (class separate_debug_range): New.
7949         (struct objfile) <separate_debug_objfiles>: New method.
7950         (objfile_separate_debug_iterate): Don't declare.
7951         * objfiles.c (separate_debug_iterator::operator++): Rename from
7952         objfile_separate_debug_iterate.
7953         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7954         iterator.
7955         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7956         iterator.
7957
7958 2019-04-10  Tom Tromey  <tom@tromey.com>
7959
7960         * symfile.c (reread_symbols): Remove old comment.
7961         * objfiles.c (free_all_objfiles): Fix a typo.
7962
7963 2019-04-10  Tom Tromey  <tom@tromey.com>
7964
7965         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7966         * minsyms.c (lookup_minimal_symbol): Use foreach.
7967         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7968         (lookup_minimal_symbol_solib_trampoline): Likewise.
7969         * symfile.c (reread_symbols): Use foreach.
7970
7971 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7972             Tom Tromey  <tromey@adacore.com>
7973
7974         PR rust/24414:
7975         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7976         (rust_lex_int_test): Change "value" to be LONGEST.
7977         (rust_lex_tests): Add test for long integer literal.
7978
7979 2019-04-09  Tom Tromey  <tromey@adacore.com>
7980
7981         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7982         to bool.
7983         (extended_remote_target::attach): Update.
7984         (remote_target::remote_notice_new_inferior): Update.
7985         (remote_target::add_current_inferior_and_thread): Update.
7986         * inferior.c (exit_inferior_1): Use "false".
7987         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7988
7989 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7990
7991         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7992         the "start" command.
7993
7994 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7995
7996         * python/py-inferior.c (infpy_thread_from_thread_handle):
7997         Adjust comments to reflect renaming of thread_from_thread_handle
7998         to thread_from_handle.  Adjust keywords.  Fix type error message.
7999         (inferior_object_methods): Add thread_from_handle.  Retain
8000         thread_from_thread_handle, but mark it as deprecated.
8001
8002 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8003
8004         * gdbthread.h (find_thread_by_handle): Revise declaration.
8005         * thread.c (find_thread_by_handle): Likewise.  Adjust
8006         implementation too.
8007         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8008         support for buffer objects as handles.
8009
8010 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8011
8012         * python/py-infthread.c (thpy_thread_handle): New function.
8013         (thread_object_methods): Register thpy_thread_handle.
8014
8015 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8016
8017         * gdbthread.h (thread_to_thread_handle): Declare.
8018         * thread.c (gdbtypes.h): Include.
8019         (thread_to_thread_handle): New function.
8020
8021         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8022         (target_thread_info_to_thread_handle): Declare.
8023         * target.c (target_thread_info_to_thread_handle): New function.
8024         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8025         * target-delegates.c: Regenerate.
8026
8027         * linux-thread-db.c (class thread_db_target): Add method
8028         thread_info_to_thread_handle.
8029         (thread_db_target::thread_info_to_thread_handle): Define.
8030         * remote.c (class remote_target): Add new method
8031         thread_info_to_thread_handle.
8032         (remote_target::thread_info_to_thread_handle): Define.
8033
8034 2019-04-08  Pedro Alves  <palves@redhat.com>
8035
8036         * common/common-exceptions.c (throw_exception): Don't create
8037         named object to throw; throw directly.
8038         (throw_it): Likewise.  Don't initialize gdb_exception::message
8039         here, with new; pass FMT and AP to the ctor instead.
8040         * common/common-exceptions.h: Include <string>.
8041         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8042         const char *, va_list)): New ctor.  Use std::make_shared.
8043         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8044         errors)): Delete.
8045         (gdb_exception_error::gdb_exception_error(enum errors, const char
8046         *, va_list)): New.
8047         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8048         Add assertion.
8049         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8050         errors)): Delete.
8051         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8052         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8053         Add assertion.
8054
8055 2019-04-08  Tom Tromey  <tom@tromey.com>
8056
8057         * valops.c (value_rtti_indirect_type): Replace throw_exception
8058         with throw.
8059         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8060         with throw.
8061         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8062         throw.
8063         * target.c (target_translate_tls_address): Replace throw_exception
8064         with throw.
8065         * stack.c (frame_apply_command_count): Replace throw_exception
8066         with throw.
8067         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8068         throw.
8069         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8070         with throw.
8071         * rs6000-tdep.c (rs6000_frame_cache)
8072         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8073         * remote.c: Replace throw_exception with throw.
8074         * record-full.c (record_full_message, record_full_wait_1)
8075         (record_full_restore): Replace throw_exception with throw.
8076         * record-btrace.c:
8077         (get_thread_current_frame_id, record_btrace_start_replaying)
8078         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8079         (cmd_record_btrace_start): Replace throw_exception with throw.
8080         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8081         throw.
8082         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8083         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8084         * linespec.c:
8085         (find_linespec_symbols): Replace throw_exception with throw.
8086         * infrun.c (displaced_step_prepare, resume): Replace
8087         throw_exception with throw.
8088         * infcmd.c (post_create_inferior): Replace throw_exception with
8089         throw.
8090         * inf-loop.c (inferior_event_handler): Replace throw_exception
8091         with throw.
8092         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8093         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8094         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8095         (get_prev_frame_always, get_frame_pc_if_available)
8096         (get_frame_address_in_block_if_available, get_frame_language):
8097         Replace throw_exception with throw.
8098         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8099         throw_exception with throw.
8100         * eval.c (fetch_subexp_value, evaluate_var_value)
8101         (evaluate_funcall, evaluate_subexp_standard): Replace
8102         throw_exception with throw.
8103         * dwarf2loc.c (call_site_find_chain)
8104         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8105         Replace throw_exception with throw.
8106         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8107         with throw.
8108         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8109         throw.
8110         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8111         * completer.c (complete_line_internal): Replace throw_exception
8112         with throw.
8113         * compile/compile-object-run.c (compile_object_run): Replace
8114         throw_exception with throw.
8115         * cli/cli-script.c (process_next_line): Replace throw_exception
8116         with throw.
8117         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8118         (btrace_enable, btrace_maint_update_pt_packets): Replace
8119         throw_exception with throw.
8120         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8121         throw_exception with throw.
8122         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8123         throw_exception with throw.
8124         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8125         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8126         * aarch64-tdep.c (aarch64_make_prologue_cache)
8127         (aarch64_make_stub_cache): Replace throw_exception with throw.
8128
8129 2019-04-08  Tom Tromey  <tom@tromey.com>
8130
8131         * common/common-exceptions.c (throw_exception): Rename from
8132         throw_exception_cxx.  Remove old copy.  Make argument const.
8133         (throw_it): Create and throw exception objects directly.
8134         * common/common-exceptions.h (throw_exception): Make argument
8135         const.
8136         (struct gdb_exception_error): Add constructor.
8137         (struct gdb_exception_quit): Add constructor.
8138
8139 2019-04-08  Tom Tromey  <tom@tromey.com>
8140
8141         * common/common-exceptions.h (exception_rethrow): Don't declare.
8142         (TRY_SJLJ): Update comment.
8143         (TRY, CATCH, END_CATCH): Remove.
8144         * common/common-exceptions.c (exception_rethrow): Remove.
8145
8146 2019-04-08  Tom Tromey  <tom@tromey.com>
8147
8148         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8149         Remove.
8150         (gdb_exception_error): Rename from
8151         gdb_exception_RETURN_MASK_ERROR.
8152         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8153         (gdb_quit_bad_alloc): Update.
8154         * aarch64-tdep.c: Update.
8155         * ada-lang.c: Update.
8156         * ada-typeprint.c: Update.
8157         * ada-valprint.c: Update.
8158         * amd64-tdep.c: Update.
8159         * arch-utils.c: Update.
8160         * break-catch-throw.c: Update.
8161         * breakpoint.c: Update.
8162         * btrace.c: Update.
8163         * c-varobj.c: Update.
8164         * cli/cli-cmds.c: Update.
8165         * cli/cli-interp.c: Update.
8166         * cli/cli-script.c: Update.
8167         * common/common-exceptions.c: Update.
8168         * common/new-op.c: Update.
8169         * common/selftest.c: Update.
8170         * compile/compile-c-symbols.c: Update.
8171         * compile/compile-cplus-symbols.c: Update.
8172         * compile/compile-object-load.c: Update.
8173         * compile/compile-object-run.c: Update.
8174         * completer.c: Update.
8175         * corelow.c: Update.
8176         * cp-abi.c: Update.
8177         * cp-support.c: Update.
8178         * cp-valprint.c: Update.
8179         * darwin-nat.c: Update.
8180         * disasm-selftests.c: Update.
8181         * dtrace-probe.c: Update.
8182         * dwarf-index-cache.c: Update.
8183         * dwarf-index-write.c: Update.
8184         * dwarf2-frame-tailcall.c: Update.
8185         * dwarf2-frame.c: Update.
8186         * dwarf2loc.c: Update.
8187         * dwarf2read.c: Update.
8188         * eval.c: Update.
8189         * event-loop.c: Update.
8190         * event-top.c: Update.
8191         * exec.c: Update.
8192         * f-valprint.c: Update.
8193         * fbsd-tdep.c: Update.
8194         * frame-unwind.c: Update.
8195         * frame.c: Update.
8196         * gdbtypes.c: Update.
8197         * gnu-v3-abi.c: Update.
8198         * guile/guile-internal.h: Update.
8199         * guile/scm-block.c: Update.
8200         * guile/scm-breakpoint.c: Update.
8201         * guile/scm-cmd.c: Update.
8202         * guile/scm-disasm.c: Update.
8203         * guile/scm-frame.c: Update.
8204         * guile/scm-lazy-string.c: Update.
8205         * guile/scm-math.c: Update.
8206         * guile/scm-param.c: Update.
8207         * guile/scm-ports.c: Update.
8208         * guile/scm-pretty-print.c: Update.
8209         * guile/scm-symbol.c: Update.
8210         * guile/scm-symtab.c: Update.
8211         * guile/scm-type.c: Update.
8212         * guile/scm-value.c: Update.
8213         * i386-linux-tdep.c: Update.
8214         * i386-tdep.c: Update.
8215         * inf-loop.c: Update.
8216         * infcall.c: Update.
8217         * infcmd.c: Update.
8218         * infrun.c: Update.
8219         * jit.c: Update.
8220         * language.c: Update.
8221         * linespec.c: Update.
8222         * linux-fork.c: Update.
8223         * linux-nat.c: Update.
8224         * linux-tdep.c: Update.
8225         * linux-thread-db.c: Update.
8226         * main.c: Update.
8227         * mi/mi-cmd-break.c: Update.
8228         * mi/mi-cmd-stack.c: Update.
8229         * mi/mi-interp.c: Update.
8230         * mi/mi-main.c: Update.
8231         * objc-lang.c: Update.
8232         * p-valprint.c: Update.
8233         * parse.c: Update.
8234         * ppc-linux-tdep.c: Update.
8235         * printcmd.c: Update.
8236         * python/py-arch.c: Update.
8237         * python/py-breakpoint.c: Update.
8238         * python/py-cmd.c: Update.
8239         * python/py-finishbreakpoint.c: Update.
8240         * python/py-frame.c: Update.
8241         * python/py-framefilter.c: Update.
8242         * python/py-gdb-readline.c: Update.
8243         * python/py-inferior.c: Update.
8244         * python/py-infthread.c: Update.
8245         * python/py-lazy-string.c: Update.
8246         * python/py-linetable.c: Update.
8247         * python/py-objfile.c: Update.
8248         * python/py-param.c: Update.
8249         * python/py-prettyprint.c: Update.
8250         * python/py-progspace.c: Update.
8251         * python/py-record-btrace.c: Update.
8252         * python/py-record.c: Update.
8253         * python/py-symbol.c: Update.
8254         * python/py-type.c: Update.
8255         * python/py-unwind.c: Update.
8256         * python/py-utils.c: Update.
8257         * python/py-value.c: Update.
8258         * python/python.c: Update.
8259         * record-btrace.c: Update.
8260         * record-full.c: Update.
8261         * remote-fileio.c: Update.
8262         * remote.c: Update.
8263         * riscv-tdep.c: Update.
8264         * rs6000-aix-tdep.c: Update.
8265         * rs6000-tdep.c: Update.
8266         * rust-exp.y: Update.
8267         * rust-lang.c: Update.
8268         * s390-tdep.c: Update.
8269         * selftest-arch.c: Update.
8270         * solib-dsbt.c: Update.
8271         * solib-frv.c: Update.
8272         * solib-spu.c: Update.
8273         * solib-svr4.c: Update.
8274         * solib.c: Update.
8275         * sparc64-linux-tdep.c: Update.
8276         * stack.c: Update.
8277         * symfile-mem.c: Update.
8278         * symmisc.c: Update.
8279         * target.c: Update.
8280         * thread.c: Update.
8281         * top.c: Update.
8282         * tracefile-tfile.c: Update.
8283         * tui/tui.c: Update.
8284         * typeprint.c: Update.
8285         * unittests/cli-utils-selftests.c: Update.
8286         * unittests/parse-connection-spec-selftests.c: Update.
8287         * valops.c: Update.
8288         * valprint.c: Update.
8289         * value.c: Update.
8290         * varobj.c: Update.
8291         * windows-nat.c: Update.
8292         * x86-linux-nat.c: Update.
8293         * xml-support.c: Update.
8294
8295 2019-04-08  Tom Tromey  <tom@tromey.com>
8296
8297         * xml-support.c: Use C++ exception handling.
8298         * x86-linux-nat.c: Use C++ exception handling.
8299         * windows-nat.c: Use C++ exception handling.
8300         * varobj.c: Use C++ exception handling.
8301         * value.c: Use C++ exception handling.
8302         * valprint.c: Use C++ exception handling.
8303         * valops.c: Use C++ exception handling.
8304         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8305         handling.
8306         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8307         * typeprint.c: Use C++ exception handling.
8308         * tui/tui.c: Use C++ exception handling.
8309         * tracefile-tfile.c: Use C++ exception handling.
8310         * top.c: Use C++ exception handling.
8311         * thread.c: Use C++ exception handling.
8312         * target.c: Use C++ exception handling.
8313         * symmisc.c: Use C++ exception handling.
8314         * symfile-mem.c: Use C++ exception handling.
8315         * stack.c: Use C++ exception handling.
8316         * sparc64-linux-tdep.c: Use C++ exception handling.
8317         * solib.c: Use C++ exception handling.
8318         * solib-svr4.c: Use C++ exception handling.
8319         * solib-spu.c: Use C++ exception handling.
8320         * solib-frv.c: Use C++ exception handling.
8321         * solib-dsbt.c: Use C++ exception handling.
8322         * selftest-arch.c: Use C++ exception handling.
8323         * s390-tdep.c: Use C++ exception handling.
8324         * rust-lang.c: Use C++ exception handling.
8325         * rust-exp.y: Use C++ exception handling.
8326         * rs6000-tdep.c: Use C++ exception handling.
8327         * rs6000-aix-tdep.c: Use C++ exception handling.
8328         * riscv-tdep.c: Use C++ exception handling.
8329         * remote.c: Use C++ exception handling.
8330         * remote-fileio.c: Use C++ exception handling.
8331         * record-full.c: Use C++ exception handling.
8332         * record-btrace.c: Use C++ exception handling.
8333         * python/python.c: Use C++ exception handling.
8334         * python/py-value.c: Use C++ exception handling.
8335         * python/py-utils.c: Use C++ exception handling.
8336         * python/py-unwind.c: Use C++ exception handling.
8337         * python/py-type.c: Use C++ exception handling.
8338         * python/py-symbol.c: Use C++ exception handling.
8339         * python/py-record.c: Use C++ exception handling.
8340         * python/py-record-btrace.c: Use C++ exception handling.
8341         * python/py-progspace.c: Use C++ exception handling.
8342         * python/py-prettyprint.c: Use C++ exception handling.
8343         * python/py-param.c: Use C++ exception handling.
8344         * python/py-objfile.c: Use C++ exception handling.
8345         * python/py-linetable.c: Use C++ exception handling.
8346         * python/py-lazy-string.c: Use C++ exception handling.
8347         * python/py-infthread.c: Use C++ exception handling.
8348         * python/py-inferior.c: Use C++ exception handling.
8349         * python/py-gdb-readline.c: Use C++ exception handling.
8350         * python/py-framefilter.c: Use C++ exception handling.
8351         * python/py-frame.c: Use C++ exception handling.
8352         * python/py-finishbreakpoint.c: Use C++ exception handling.
8353         * python/py-cmd.c: Use C++ exception handling.
8354         * python/py-breakpoint.c: Use C++ exception handling.
8355         * python/py-arch.c: Use C++ exception handling.
8356         * printcmd.c: Use C++ exception handling.
8357         * ppc-linux-tdep.c: Use C++ exception handling.
8358         * parse.c: Use C++ exception handling.
8359         * p-valprint.c: Use C++ exception handling.
8360         * objc-lang.c: Use C++ exception handling.
8361         * mi/mi-main.c: Use C++ exception handling.
8362         * mi/mi-interp.c: Use C++ exception handling.
8363         * mi/mi-cmd-stack.c: Use C++ exception handling.
8364         * mi/mi-cmd-break.c: Use C++ exception handling.
8365         * main.c: Use C++ exception handling.
8366         * linux-thread-db.c: Use C++ exception handling.
8367         * linux-tdep.c: Use C++ exception handling.
8368         * linux-nat.c: Use C++ exception handling.
8369         * linux-fork.c: Use C++ exception handling.
8370         * linespec.c: Use C++ exception handling.
8371         * language.c: Use C++ exception handling.
8372         * jit.c: Use C++ exception handling.
8373         * infrun.c: Use C++ exception handling.
8374         * infcmd.c: Use C++ exception handling.
8375         * infcall.c: Use C++ exception handling.
8376         * inf-loop.c: Use C++ exception handling.
8377         * i386-tdep.c: Use C++ exception handling.
8378         * i386-linux-tdep.c: Use C++ exception handling.
8379         * guile/scm-value.c: Use C++ exception handling.
8380         * guile/scm-type.c: Use C++ exception handling.
8381         * guile/scm-symtab.c: Use C++ exception handling.
8382         * guile/scm-symbol.c: Use C++ exception handling.
8383         * guile/scm-pretty-print.c: Use C++ exception handling.
8384         * guile/scm-ports.c: Use C++ exception handling.
8385         * guile/scm-param.c: Use C++ exception handling.
8386         * guile/scm-math.c: Use C++ exception handling.
8387         * guile/scm-lazy-string.c: Use C++ exception handling.
8388         * guile/scm-frame.c: Use C++ exception handling.
8389         * guile/scm-disasm.c: Use C++ exception handling.
8390         * guile/scm-cmd.c: Use C++ exception handling.
8391         * guile/scm-breakpoint.c: Use C++ exception handling.
8392         * guile/scm-block.c: Use C++ exception handling.
8393         * guile/guile-internal.h: Use C++ exception handling.
8394         * gnu-v3-abi.c: Use C++ exception handling.
8395         * gdbtypes.c: Use C++ exception handling.
8396         * frame.c: Use C++ exception handling.
8397         * frame-unwind.c: Use C++ exception handling.
8398         * fbsd-tdep.c: Use C++ exception handling.
8399         * f-valprint.c: Use C++ exception handling.
8400         * exec.c: Use C++ exception handling.
8401         * event-top.c: Use C++ exception handling.
8402         * event-loop.c: Use C++ exception handling.
8403         * eval.c: Use C++ exception handling.
8404         * dwarf2read.c: Use C++ exception handling.
8405         * dwarf2loc.c: Use C++ exception handling.
8406         * dwarf2-frame.c: Use C++ exception handling.
8407         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8408         * dwarf-index-write.c: Use C++ exception handling.
8409         * dwarf-index-cache.c: Use C++ exception handling.
8410         * dtrace-probe.c: Use C++ exception handling.
8411         * disasm-selftests.c: Use C++ exception handling.
8412         * darwin-nat.c: Use C++ exception handling.
8413         * cp-valprint.c: Use C++ exception handling.
8414         * cp-support.c: Use C++ exception handling.
8415         * cp-abi.c: Use C++ exception handling.
8416         * corelow.c: Use C++ exception handling.
8417         * completer.c: Use C++ exception handling.
8418         * compile/compile-object-run.c: Use C++ exception handling.
8419         * compile/compile-object-load.c: Use C++ exception handling.
8420         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8421         * compile/compile-c-symbols.c: Use C++ exception handling.
8422         * common/selftest.c: Use C++ exception handling.
8423         * common/new-op.c: Use C++ exception handling.
8424         * cli/cli-script.c: Use C++ exception handling.
8425         * cli/cli-interp.c: Use C++ exception handling.
8426         * cli/cli-cmds.c: Use C++ exception handling.
8427         * c-varobj.c: Use C++ exception handling.
8428         * btrace.c: Use C++ exception handling.
8429         * breakpoint.c: Use C++ exception handling.
8430         * break-catch-throw.c: Use C++ exception handling.
8431         * arch-utils.c: Use C++ exception handling.
8432         * amd64-tdep.c: Use C++ exception handling.
8433         * ada-valprint.c: Use C++ exception handling.
8434         * ada-typeprint.c: Use C++ exception handling.
8435         * ada-lang.c: Use C++ exception handling.
8436         * aarch64-tdep.c: Use C++ exception handling.
8437
8438 2019-04-08  Tom Tromey  <tom@tromey.com>
8439
8440         * xml-support.c (gdb_xml_parser::parse): Update.
8441         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8442         * value.c (show_convenience): Update.
8443         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8444         (test_parse_flags_qcs): Update.
8445         * thread.c (thr_try_catch_cmd): Update.
8446         * target.c (target_translate_tls_address): Update.
8447         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8448         (info_frame_command_core, frame_apply_command_count): Update.
8449         * rust-exp.y (rust_lex_exception_test): Update.
8450         * riscv-tdep.c (riscv_print_one_register_info): Update.
8451         * remote.c (remote_target::enable_btrace): Update.
8452         * record-btrace.c (record_btrace_enable_warn): Update.
8453         * python/py-utils.c (gdbpy_convert_exception): Update.
8454         * printcmd.c (do_one_display, print_variable_and_value): Update.
8455         * mi/mi-main.c (mi_print_exception): Update.
8456         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8457         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8458         * linux-nat.c (linux_nat_target::attach): Update.
8459         * linux-fork.c (class scoped_switch_fork_info): Update.
8460         * infrun.c (displaced_step_prepare): Update.
8461         * infcall.c (call_function_by_hand_dummy): Update.
8462         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8463         * gnu-v3-abi.c (print_one_vtable): Update.
8464         * frame.c (get_prev_frame_always): Update.
8465         * f-valprint.c (info_common_command_for_block): Update.
8466         * exec.c (try_open_exec_file): Update.
8467         * exceptions.c (print_exception, exception_print)
8468         (exception_fprintf, exception_print_same): Update.
8469         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8470         * dwarf-index-cache.c (index_cache::store)
8471         (index_cache::lookup_gdb_index): Update.
8472         * darwin-nat.c (maybe_cache_shell): Update.
8473         * cp-valprint.c (cp_print_value_fields): Update.
8474         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8475         (gcc_cplus_symbol_address): Update.
8476         * compile/compile-c-symbols.c (gcc_convert_symbol)
8477         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8478         * common/selftest.c: Update.
8479         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8480         a std::string.
8481         (exception_try_scope_entry, exception_try_scope_exit): Don't
8482         declare.
8483         (struct exception_try_scope): Remove.
8484         (TRY): Don't use exception_try_scope.
8485         (struct gdb_exception): Add constructor, operator=.
8486         <what>: New method.
8487         (struct gdb_exception_RETURN_MASK_ALL)
8488         (struct gdb_exception_RETURN_MASK_ERROR)
8489         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8490         (struct gdb_quit_bad_alloc): Update.
8491         * common/common-exceptions.c (exception_none): Change
8492         initializer.
8493         (struct catcher) <state, exception>: Initialize inline.
8494         <prev>: Remove member.
8495         (current_catcher): Remove.
8496         (catchers): New global.
8497         (exceptions_state_mc_init): Simplify.
8498         (catcher_pop): Remove.
8499         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8500         (try_scope_depth, exception_try_scope_entry)
8501         (exception_try_scope_exit): Remove.
8502         (throw_exception_sjlj): Update.
8503         (exception_messages, exception_messages_size): Remove.
8504         (throw_it): Simplify.
8505         (gdb_exception_sliced_copy): Remove.
8506         (throw_exception_cxx): Update.
8507         * cli/cli-script.c (script_from_file): Update.
8508         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8509         Update.
8510         * ada-valprint.c (ada_val_print): Update.
8511         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8512         (create_excep_cond_exprs): Update.
8513
8514 2019-04-08  Tom Tromey  <tom@tromey.com>
8515
8516         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8517         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8518         (TRY, CATCH, END_CATCH): Remove some definitions.
8519         * common/common-exceptions.c: Don't use GDB_XCPT.
8520         (catcher_list_size): Remove.
8521         (throw_exception, throw_it): Simplify.
8522
8523 2019-04-05  Tom Tromey  <tom@tromey.com>
8524
8525         Revert the header-sorting patch.
8526         * ft32-tdep.c: Revert.
8527         * frv-tdep.c: Revert.
8528         * frv-linux-tdep.c: Revert.
8529         * frame.c: Revert.
8530         * frame-unwind.c: Revert.
8531         * frame-base.c: Revert.
8532         * fork-child.c: Revert.
8533         * findvar.c: Revert.
8534         * findcmd.c: Revert.
8535         * filesystem.c: Revert.
8536         * filename-seen-cache.h: Revert.
8537         * filename-seen-cache.c: Revert.
8538         * fbsd-tdep.c: Revert.
8539         * fbsd-nat.h: Revert.
8540         * fbsd-nat.c: Revert.
8541         * f-valprint.c: Revert.
8542         * f-typeprint.c: Revert.
8543         * f-lang.c: Revert.
8544         * extension.h: Revert.
8545         * extension.c: Revert.
8546         * extension-priv.h: Revert.
8547         * expprint.c: Revert.
8548         * exec.h: Revert.
8549         * exec.c: Revert.
8550         * exceptions.c: Revert.
8551         * event-top.c: Revert.
8552         * event-loop.c: Revert.
8553         * eval.c: Revert.
8554         * elfread.c: Revert.
8555         * dwarf2read.h: Revert.
8556         * dwarf2read.c: Revert.
8557         * dwarf2loc.c: Revert.
8558         * dwarf2expr.h: Revert.
8559         * dwarf2expr.c: Revert.
8560         * dwarf2-frame.c: Revert.
8561         * dwarf2-frame-tailcall.c: Revert.
8562         * dwarf-index-write.h: Revert.
8563         * dwarf-index-write.c: Revert.
8564         * dwarf-index-common.c: Revert.
8565         * dwarf-index-cache.h: Revert.
8566         * dwarf-index-cache.c: Revert.
8567         * dummy-frame.c: Revert.
8568         * dtrace-probe.c: Revert.
8569         * disasm.h: Revert.
8570         * disasm.c: Revert.
8571         * disasm-selftests.c: Revert.
8572         * dictionary.c: Revert.
8573         * dicos-tdep.c: Revert.
8574         * demangle.c: Revert.
8575         * dcache.h: Revert.
8576         * dcache.c: Revert.
8577         * darwin-nat.h: Revert.
8578         * darwin-nat.c: Revert.
8579         * darwin-nat-info.c: Revert.
8580         * d-valprint.c: Revert.
8581         * d-namespace.c: Revert.
8582         * d-lang.c: Revert.
8583         * ctf.c: Revert.
8584         * csky-tdep.c: Revert.
8585         * csky-linux-tdep.c: Revert.
8586         * cris-tdep.c: Revert.
8587         * cris-linux-tdep.c: Revert.
8588         * cp-valprint.c: Revert.
8589         * cp-support.c: Revert.
8590         * cp-namespace.c: Revert.
8591         * cp-abi.c: Revert.
8592         * corelow.c: Revert.
8593         * corefile.c: Revert.
8594         * continuations.c: Revert.
8595         * completer.h: Revert.
8596         * completer.c: Revert.
8597         * complaints.c: Revert.
8598         * coffread.c: Revert.
8599         * coff-pe-read.c: Revert.
8600         * cli-out.h: Revert.
8601         * cli-out.c: Revert.
8602         * charset.c: Revert.
8603         * c-varobj.c: Revert.
8604         * c-valprint.c: Revert.
8605         * c-typeprint.c: Revert.
8606         * c-lang.c: Revert.
8607         * buildsym.c: Revert.
8608         * buildsym-legacy.c: Revert.
8609         * build-id.h: Revert.
8610         * build-id.c: Revert.
8611         * btrace.c: Revert.
8612         * bsd-uthread.c: Revert.
8613         * breakpoint.h: Revert.
8614         * breakpoint.c: Revert.
8615         * break-catch-throw.c: Revert.
8616         * break-catch-syscall.c: Revert.
8617         * break-catch-sig.c: Revert.
8618         * blockframe.c: Revert.
8619         * block.c: Revert.
8620         * bfin-tdep.c: Revert.
8621         * bfin-linux-tdep.c: Revert.
8622         * bfd-target.c: Revert.
8623         * bcache.c: Revert.
8624         * ax-general.c: Revert.
8625         * ax-gdb.h: Revert.
8626         * ax-gdb.c: Revert.
8627         * avr-tdep.c: Revert.
8628         * auxv.c: Revert.
8629         * auto-load.c: Revert.
8630         * arm-wince-tdep.c: Revert.
8631         * arm-tdep.c: Revert.
8632         * arm-symbian-tdep.c: Revert.
8633         * arm-pikeos-tdep.c: Revert.
8634         * arm-obsd-tdep.c: Revert.
8635         * arm-nbsd-tdep.c: Revert.
8636         * arm-nbsd-nat.c: Revert.
8637         * arm-linux-tdep.c: Revert.
8638         * arm-linux-nat.c: Revert.
8639         * arm-fbsd-tdep.c: Revert.
8640         * arm-fbsd-nat.c: Revert.
8641         * arm-bsd-tdep.c: Revert.
8642         * arch-utils.c: Revert.
8643         * arc-tdep.c: Revert.
8644         * arc-newlib-tdep.c: Revert.
8645         * annotate.h: Revert.
8646         * annotate.c: Revert.
8647         * amd64-windows-tdep.c: Revert.
8648         * amd64-windows-nat.c: Revert.
8649         * amd64-tdep.c: Revert.
8650         * amd64-sol2-tdep.c: Revert.
8651         * amd64-obsd-tdep.c: Revert.
8652         * amd64-obsd-nat.c: Revert.
8653         * amd64-nbsd-tdep.c: Revert.
8654         * amd64-nbsd-nat.c: Revert.
8655         * amd64-nat.c: Revert.
8656         * amd64-linux-tdep.c: Revert.
8657         * amd64-linux-nat.c: Revert.
8658         * amd64-fbsd-tdep.c: Revert.
8659         * amd64-fbsd-nat.c: Revert.
8660         * amd64-dicos-tdep.c: Revert.
8661         * amd64-darwin-tdep.c: Revert.
8662         * amd64-bsd-nat.c: Revert.
8663         * alpha-tdep.c: Revert.
8664         * alpha-obsd-tdep.c: Revert.
8665         * alpha-nbsd-tdep.c: Revert.
8666         * alpha-mdebug-tdep.c: Revert.
8667         * alpha-linux-tdep.c: Revert.
8668         * alpha-linux-nat.c: Revert.
8669         * alpha-bsd-tdep.c: Revert.
8670         * alpha-bsd-nat.c: Revert.
8671         * aix-thread.c: Revert.
8672         * agent.c: Revert.
8673         * addrmap.c: Revert.
8674         * ada-varobj.c: Revert.
8675         * ada-valprint.c: Revert.
8676         * ada-typeprint.c: Revert.
8677         * ada-tasks.c: Revert.
8678         * ada-lang.c: Revert.
8679         * aarch64-tdep.c: Revert.
8680         * aarch64-ravenscar-thread.c: Revert.
8681         * aarch64-newlib-tdep.c: Revert.
8682         * aarch64-linux-tdep.c: Revert.
8683         * aarch64-linux-nat.c: Revert.
8684         * aarch64-fbsd-tdep.c: Revert.
8685         * aarch64-fbsd-nat.c: Revert.
8686         * aarch32-linux-nat.c: Revert.
8687
8688 2019-04-05  Tom Tromey  <tom@tromey.com>
8689
8690         * ft32-tdep.c: Sort headers.
8691         * frv-tdep.c: Sort headers.
8692         * frv-linux-tdep.c: Sort headers.
8693         * frame.c: Sort headers.
8694         * frame-unwind.c: Sort headers.
8695         * frame-base.c: Sort headers.
8696         * fork-child.c: Sort headers.
8697         * findvar.c: Sort headers.
8698         * findcmd.c: Sort headers.
8699         * filesystem.c: Sort headers.
8700         * filename-seen-cache.h: Sort headers.
8701         * filename-seen-cache.c: Sort headers.
8702         * fbsd-tdep.c: Sort headers.
8703         * fbsd-nat.h: Sort headers.
8704         * fbsd-nat.c: Sort headers.
8705         * f-valprint.c: Sort headers.
8706         * f-typeprint.c: Sort headers.
8707         * f-lang.c: Sort headers.
8708         * extension.h: Sort headers.
8709         * extension.c: Sort headers.
8710         * extension-priv.h: Sort headers.
8711         * expprint.c: Sort headers.
8712         * exec.h: Sort headers.
8713         * exec.c: Sort headers.
8714         * exceptions.c: Sort headers.
8715         * event-top.c: Sort headers.
8716         * event-loop.c: Sort headers.
8717         * eval.c: Sort headers.
8718         * elfread.c: Sort headers.
8719         * dwarf2read.h: Sort headers.
8720         * dwarf2read.c: Sort headers.
8721         * dwarf2loc.c: Sort headers.
8722         * dwarf2expr.h: Sort headers.
8723         * dwarf2expr.c: Sort headers.
8724         * dwarf2-frame.c: Sort headers.
8725         * dwarf2-frame-tailcall.c: Sort headers.
8726         * dwarf-index-write.h: Sort headers.
8727         * dwarf-index-write.c: Sort headers.
8728         * dwarf-index-common.c: Sort headers.
8729         * dwarf-index-cache.h: Sort headers.
8730         * dwarf-index-cache.c: Sort headers.
8731         * dummy-frame.c: Sort headers.
8732         * dtrace-probe.c: Sort headers.
8733         * disasm.h: Sort headers.
8734         * disasm.c: Sort headers.
8735         * disasm-selftests.c: Sort headers.
8736         * dictionary.c: Sort headers.
8737         * dicos-tdep.c: Sort headers.
8738         * demangle.c: Sort headers.
8739         * dcache.h: Sort headers.
8740         * dcache.c: Sort headers.
8741         * darwin-nat.h: Sort headers.
8742         * darwin-nat.c: Sort headers.
8743         * darwin-nat-info.c: Sort headers.
8744         * d-valprint.c: Sort headers.
8745         * d-namespace.c: Sort headers.
8746         * d-lang.c: Sort headers.
8747         * ctf.c: Sort headers.
8748         * csky-tdep.c: Sort headers.
8749         * csky-linux-tdep.c: Sort headers.
8750         * cris-tdep.c: Sort headers.
8751         * cris-linux-tdep.c: Sort headers.
8752         * cp-valprint.c: Sort headers.
8753         * cp-support.c: Sort headers.
8754         * cp-namespace.c: Sort headers.
8755         * cp-abi.c: Sort headers.
8756         * corelow.c: Sort headers.
8757         * corefile.c: Sort headers.
8758         * continuations.c: Sort headers.
8759         * completer.h: Sort headers.
8760         * completer.c: Sort headers.
8761         * complaints.c: Sort headers.
8762         * coffread.c: Sort headers.
8763         * coff-pe-read.c: Sort headers.
8764         * cli-out.h: Sort headers.
8765         * cli-out.c: Sort headers.
8766         * charset.c: Sort headers.
8767         * c-varobj.c: Sort headers.
8768         * c-valprint.c: Sort headers.
8769         * c-typeprint.c: Sort headers.
8770         * c-lang.c: Sort headers.
8771         * buildsym.c: Sort headers.
8772         * buildsym-legacy.c: Sort headers.
8773         * build-id.h: Sort headers.
8774         * build-id.c: Sort headers.
8775         * btrace.c: Sort headers.
8776         * bsd-uthread.c: Sort headers.
8777         * breakpoint.h: Sort headers.
8778         * breakpoint.c: Sort headers.
8779         * break-catch-throw.c: Sort headers.
8780         * break-catch-syscall.c: Sort headers.
8781         * break-catch-sig.c: Sort headers.
8782         * blockframe.c: Sort headers.
8783         * block.c: Sort headers.
8784         * bfin-tdep.c: Sort headers.
8785         * bfin-linux-tdep.c: Sort headers.
8786         * bfd-target.c: Sort headers.
8787         * bcache.c: Sort headers.
8788         * ax-general.c: Sort headers.
8789         * ax-gdb.h: Sort headers.
8790         * ax-gdb.c: Sort headers.
8791         * avr-tdep.c: Sort headers.
8792         * auxv.c: Sort headers.
8793         * auto-load.c: Sort headers.
8794         * arm-wince-tdep.c: Sort headers.
8795         * arm-tdep.c: Sort headers.
8796         * arm-symbian-tdep.c: Sort headers.
8797         * arm-pikeos-tdep.c: Sort headers.
8798         * arm-obsd-tdep.c: Sort headers.
8799         * arm-nbsd-tdep.c: Sort headers.
8800         * arm-nbsd-nat.c: Sort headers.
8801         * arm-linux-tdep.c: Sort headers.
8802         * arm-linux-nat.c: Sort headers.
8803         * arm-fbsd-tdep.c: Sort headers.
8804         * arm-fbsd-nat.c: Sort headers.
8805         * arm-bsd-tdep.c: Sort headers.
8806         * arch-utils.c: Sort headers.
8807         * arc-tdep.c: Sort headers.
8808         * arc-newlib-tdep.c: Sort headers.
8809         * annotate.h: Sort headers.
8810         * annotate.c: Sort headers.
8811         * amd64-windows-tdep.c: Sort headers.
8812         * amd64-windows-nat.c: Sort headers.
8813         * amd64-tdep.c: Sort headers.
8814         * amd64-sol2-tdep.c: Sort headers.
8815         * amd64-obsd-tdep.c: Sort headers.
8816         * amd64-obsd-nat.c: Sort headers.
8817         * amd64-nbsd-tdep.c: Sort headers.
8818         * amd64-nbsd-nat.c: Sort headers.
8819         * amd64-nat.c: Sort headers.
8820         * amd64-linux-tdep.c: Sort headers.
8821         * amd64-linux-nat.c: Sort headers.
8822         * amd64-fbsd-tdep.c: Sort headers.
8823         * amd64-fbsd-nat.c: Sort headers.
8824         * amd64-dicos-tdep.c: Sort headers.
8825         * amd64-darwin-tdep.c: Sort headers.
8826         * amd64-bsd-nat.c: Sort headers.
8827         * alpha-tdep.c: Sort headers.
8828         * alpha-obsd-tdep.c: Sort headers.
8829         * alpha-nbsd-tdep.c: Sort headers.
8830         * alpha-mdebug-tdep.c: Sort headers.
8831         * alpha-linux-tdep.c: Sort headers.
8832         * alpha-linux-nat.c: Sort headers.
8833         * alpha-bsd-tdep.c: Sort headers.
8834         * alpha-bsd-nat.c: Sort headers.
8835         * aix-thread.c: Sort headers.
8836         * agent.c: Sort headers.
8837         * addrmap.c: Sort headers.
8838         * ada-varobj.c: Sort headers.
8839         * ada-valprint.c: Sort headers.
8840         * ada-typeprint.c: Sort headers.
8841         * ada-tasks.c: Sort headers.
8842         * ada-lang.c: Sort headers.
8843         * aarch64-tdep.c: Sort headers.
8844         * aarch64-ravenscar-thread.c: Sort headers.
8845         * aarch64-newlib-tdep.c: Sort headers.
8846         * aarch64-linux-tdep.c: Sort headers.
8847         * aarch64-linux-nat.c: Sort headers.
8848         * aarch64-fbsd-tdep.c: Sort headers.
8849         * aarch64-fbsd-nat.c: Sort headers.
8850         * aarch32-linux-nat.c: Sort headers.
8851
8852 2019-04-04  Tom Tromey  <tom@tromey.com>
8853
8854         * varobj.c (varobj_create): Update.
8855         * rust-exp.y (struct rust_parser) <update_innermost_block,
8856         lookup_symbol>: New methods.
8857         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8858         Rename.
8859         (rust_parser::rust_lookup_type)
8860         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8861         * printcmd.c (display_command, do_one_display): Update.
8862         * parser-defs.h (struct parser_state) <parser_state>: Add
8863         "tracker" parameter.
8864         (block_tracker): New member.
8865         (class innermost_block_tracker) <innermost_block_tracker>: Add
8866         "types" parameter.
8867         <reset>: Remove method.
8868         (innermost_block): Don't declare.
8869         (null_post_parser): Update.
8870         * parse.c (innermost_block): Remove global.
8871         (write_dollar_variable): Update.
8872         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8873         Remove "tracker_types" parameter.
8874         (parse_expression): Add "tracker" parameter.
8875         (parse_expression_for_completion): Update.
8876         (null_post_parser): Add "tracker" parameter.
8877         * p-exp.y: Update rules.
8878         * m2-exp.y: Update rules.
8879         * language.h (struct language_defn) <la_post_parser>: Add
8880         "tracker" parameter.
8881         * go-exp.y: Update rules.
8882         * f-exp.y: Update rules.
8883         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8884         parameter.
8885         * d-exp.y: Update rules.
8886         * c-exp.y: Update rules.
8887         * breakpoint.c (set_breakpoint_condition): Create an
8888         innermost_block_tracker.
8889         (watch_command_1): Likewise.
8890         * ada-lang.c (resolve): Add "tracker" parameter.
8891         (resolve_subexp): Likewise.
8892         * ada-exp.y (write_var_from_sym): Update.
8893
8894 2019-04-04  Tom Tromey  <tom@tromey.com>
8895
8896         * type-stack.h: New file.
8897         * type-stack.c: New file.
8898         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8899         type-stack.h.
8900         (insert_into_type_stack, insert_type, push_type, push_type_int)
8901         (insert_type_address_space, pop_type, pop_type_int)
8902         (pop_typelist, pop_type_stack, append_type_stack)
8903         (push_type_stack, get_type_stack, push_typelist)
8904         (follow_type_instance_flags, follow_types): Don't declare.
8905         * parse.c (type_stack): Remove global.
8906         (parse_exp_in_context): Update.
8907         (insert_into_type_stack, insert_type, push_type, push_type_int)
8908         (insert_type_address_space, pop_type, pop_type_int)
8909         (pop_typelist, pop_type_stack, append_type_stack)
8910         (push_type_stack, get_type_stack, push_typelist)
8911         (follow_type_instance_flags, follow_types): Remove (moved to
8912         type-stack.c).
8913         * f-exp.y (type_stack): New global.
8914         Update rules.
8915         (push_kind_type, f_parse): Update.
8916         * d-exp.y (type_stack): New global.
8917         Update rules.
8918         (d_parse): Update.
8919         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8920         Update rules.
8921         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8922         (HFILES_NO_SRCDIR): Add type-stack.h.
8923
8924 2019-04-04  Tom Tromey  <tom@tromey.com>
8925
8926         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8927         (rust_parser::convert_ast_to_expression, rust_parse)
8928         (rust_lex_test_completion, rust_lex_tests): Update.
8929         * parser-defs.h (struct expr_completion_state): New.
8930         (struct parser_state) <parser_state>: Add completion parameter.
8931         <mark_struct_expression, mark_completion_tag>: New methods.
8932         <parse_completion, m_completion_state>: New members.
8933         (prefixify_expression, null_post_parser): Update.
8934         (mark_struct_expression, mark_completion_tag): Don't declare.
8935         * parse.c (parse_completion, expout_last_struct)
8936         (expout_tag_completion_type, expout_completion_name): Remove
8937         globals.
8938         (parser_state::mark_struct_expression)
8939         (parser_state::mark_completion_tag): Now methods.
8940         (prefixify_expression): Add last_struct parameter.
8941         (prefixify_subexp): Likewise.
8942         (parse_exp_1): Update.
8943         (parse_exp_in_context): Add cstate parameter.  Update.
8944         (parse_expression_for_completion): Create an
8945         expr_completion_state.
8946         (null_post_parser): Add "completion" parameter.
8947         * p-exp.y: Update rules.
8948         (yylex): Update.
8949         * language.h (struct language_defn) <la_post_parser>: Add
8950         "completing" parameter.
8951         * go-exp.y: Update rules.
8952         (lex_one_token): Update.
8953         * expression.h (parse_completion): Don't declare.
8954         * d-exp.y: Update rules.
8955         (lex_one_token): Update rules.
8956         * c-exp.y: Update rules.
8957         (lex_one_token): Update.
8958         * ada-lang.c (resolve): Add "parse_completion" parameter.
8959         (resolve_subexp): Likewise.
8960         (ada_resolve_function): Likewise.
8961
8962 2019-04-04  Tom Tromey  <tom@tromey.com>
8963
8964         * parser-defs.h (struct parser_state) <start_arglist,
8965         end_arglist>: New methods.
8966         <arglist_len, m_funcall_chain>: New members.
8967         (arglist_len, start_arglist, end_arglist): Don't declare.
8968         * parse.c (arglist_len, funcall_chain): Remove global.
8969         (start_arglist, end_arglist): Remove functions.
8970         (parse_exp_in_context): Update.
8971         * p-exp.y: Update rules.
8972         * m2-exp.y: Update rules.
8973         * go-exp.y: Update rules.
8974         * f-exp.y: Update rules.
8975         * d-exp.y: Update rules.
8976         * c-exp.y: Update rules.
8977
8978 2019-04-04  Tom Tromey  <tom@tromey.com>
8979
8980         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8981         lex_operator, push_back>: New methods.
8982         Update all rules.
8983         (rust_parser::lex_hex, lex_escape): Rename and update.
8984         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8985         (rust_parser::lex_operator): Rename and update.
8986         (rust_parser::lex_number, rustyylex, rustyyerror)
8987         (rust_lex_test_init, rust_lex_test_sequence)
8988         (rust_lex_test_push_back, rust_lex_tests): Update.
8989         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8990         parameter.
8991         <lexptr, prev_lexptr>: New members.
8992         (lexptr, prev_lexptr): Don't declare.
8993         * parse.c (lexptr, prev_lexptr): Remove globals.
8994         (parse_exp_in_context): Update.
8995         * p-exp.y (yylex, yyerror): Update.
8996         * m2-exp.y (parse_number, yylex, yyerror): Update.
8997         * go-exp.y (lex_one_token, yyerror): Update.
8998         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8999         * d-exp.y (lex_one_token, yyerror): Update.
9000         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9001         (lex_one_token, yyerror): Update.
9002         * ada-lex.l (YY_INPUT): Update.
9003         (rewind_to_char): Update.
9004         * ada-exp.y (yyerror): Update.
9005
9006 2019-04-04  Tom Tromey  <tom@tromey.com>
9007
9008         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9009         * parser-defs.h (struct parser_state) <parser_state>: Add new
9010         parameter.
9011         <comma_terminates>: New member.
9012         (comma_terminates): Don't declare global.
9013         * parse.c (comma_terminates): Remove global.
9014         (parse_exp_in_context): Update.
9015         * p-exp.y (yylex): Update.
9016         * m2-exp.y (yylex): Update.
9017         * go-exp.y (lex_one_token): Update.
9018         * f-exp.y (yylex): Update.
9019         * d-exp.y (lex_one_token): Update.
9020         * c-exp.y (lex_one_token): Update.
9021         * ada-lex.l: Update.
9022
9023 2019-04-04  Tom Tromey  <tom@tromey.com>
9024
9025         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9026         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9027         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9028         * parser-defs.h (paren_depth): Don't declare.
9029         * parse.c (paren_depth): Remove global.
9030         (parse_exp_in_context): Update.
9031         * p-exp.y (paren_depth): New global.
9032         (pascal_parse): Initialize it.
9033         * m2-exp.y (paren_depth): New global.
9034         (m2_parse): Initialize it.
9035         * go-exp.y (paren_depth): New global.
9036         (go_parse): Initialize it.
9037         * f-exp.y (paren_depth): New global.
9038         (f_parse): Initialize it.
9039         * d-exp.y (paren_depth): New global.
9040         (d_parse): Initialize it.
9041         * c-exp.y (paren_depth): New global.
9042         (c_parse): Initialize it.
9043         * ada-lex.l (paren_depth): New global.
9044         (lexer_init): Initialize it.
9045
9046 2019-04-04  Tom Tromey  <tom@tromey.com>
9047
9048         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9049         (rust_parser::convert_ast_to_type)
9050         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9051         * parser-defs.h (struct parser_state) <parser_state>: Add
9052         parameters.  Initialize new members.
9053         <expression_context_block, expression_context_pc>: New members.
9054         * parse.c (expression_context_block, expression_context_pc):
9055         Remove globals.
9056         (parse_exp_in_context): Update.
9057         * p-exp.y: Update all rules.
9058         (yylex): Update.
9059         * m2-exp.y: Update all rules.
9060         (yylex): Update.
9061         * go-exp.y (yylex): Update.
9062         * f-exp.y (yylex): Update.
9063         * d-exp.y: Update all rules.
9064         (yylex): Update.
9065         * c-exp.y: Update all rules.
9066         (lex_one_token, classify_name, yylex, c_parse): Update.
9067         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9068
9069 2019-04-04  Tom Tromey  <tom@tromey.com>
9070
9071         * gdbarch.h, gdbarch.c: Rebuild.
9072         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9073         * stap-probe.h:
9074         (struct stap_parse_info): Replace "parser_state" with
9075         "expr_builder".
9076         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9077         (parser_state): New class.
9078         * parse.c (expr_builder): Rename.
9079         (expr_builder::release): Rename.
9080         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9081         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9082         (write_exp_elt_longcst, write_exp_elt_floatcst)
9083         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9084         (write_exp_string_vector, write_exp_bitstring)
9085         (write_exp_msymbol, mark_struct_expression)
9086         (write_dollar_variable)
9087         (insert_type_address_space, increase_expout_size): Replace
9088         "parser_state" with "expr_builder".
9089         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9090         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9091         "parser_state" with "expr_builder".
9092
9093 2019-04-04  Tom Tromey  <tom@tromey.com>
9094
9095         * rust-exp.y: Replace "parse_language" with method call.
9096         * p-exp.y:
9097         (yylex): Replace "parse_language" with method call.
9098         * m2-exp.y:
9099         (yylex): Replace "parse_language" with method call.
9100         * go-exp.y (classify_name): Replace "parse_language" with method
9101         call.
9102         * f-exp.y (yylex): Replace "parse_language" with method call.
9103         * d-exp.y (lex_one_token): Replace "parse_language" with method
9104         call.
9105         * c-exp.y:
9106         (lex_one_token, classify_name, yylex): Replace "parse_language"
9107         with method call.
9108         * ada-exp.y (find_primitive_type, type_char)
9109         (type_system_address): Replace "parse_language" with method call.
9110
9111 2019-04-04  Tom Tromey  <tom@tromey.com>
9112
9113         * rust-exp.y: Replace "parse_gdbarch" with method call.
9114         * parse.c (write_dollar_variable, insert_type_address_space):
9115         Replace "parse_gdbarch" with method call.
9116         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9117         call.
9118         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9119         call.
9120         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9121         "parse_gdbarch" with method call.
9122         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9123         with method call.
9124         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9125         "parse_gdbarch" with method call.
9126         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9127         "parse_gdbarch" with method call.
9128         * c-exp.y (parse_type, parse_number, classify_name): Replace
9129         "parse_gdbarch" with method call.
9130         * ada-lex.l: Replace "parse_gdbarch" with method call.
9131         * ada-exp.y (parse_type, find_primitive_type, type_char)
9132         (type_system_address): Replace "parse_gdbarch" with method call.
9133
9134 2019-04-04  Tom Tromey  <tom@tromey.com>
9135
9136         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9137         * stap-probe.c (stap_parse_argument): Update.
9138         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9139         initial_size parameter.
9140         * rust-exp.y (rust_lex_tests): Update.
9141         * parse.c (parser_state): Update.
9142         (parse_exp_in_context): Update.
9143         * parser-defs.h (struct parser_state) <parser_state>: Remove
9144         "initial_size" parameter.
9145
9146 2019-04-04  Tom Tromey  <tom@tromey.com>
9147
9148         * parser-defs.h (increase_expout_size): Don't declare.
9149         * parse.c (increase_expout_size): Now static.
9150
9151 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9152
9153         * gnu-nat.c (gnu_nat_target::wait): Fix
9154         target_waitstatus_to_string call.
9155
9156 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9157
9158         * eval.c (evaluate_subexp_standard): Handle internal functions
9159         during Fortran function call handling.
9160
9161 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9162
9163         * NEWS: Mention new internal functions.
9164         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9165         (read_base_type): Use dwarf2_init_complex_target_type.
9166         * value.c (creal_internal_fn): New function.
9167         (cimag_internal_fn): New function.
9168         (_initialize_values): Register new internal functions.
9169
9170 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9171
9172         * infrun.c (stop_all_threads): If debug_infrun, always
9173         trace the wait status after wait_one, using
9174         target_waitstatus_to_string and target_pid_to_str.
9175         (handle_inferior_event): Replace various trace of
9176         wait status kind by a single trace.
9177         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9178         wait status kind image by target_waitstatus_to_string.
9179         * target/waitstatus.c (target_waitstatus_to_string): Fix
9180         obsolete comment.
9181
9182 2019-04-01  Tom Tromey  <tromey@adacore.com>
9183
9184         PR symtab/23331:
9185         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9186
9187 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9188             Pedro Alves  <palves@redhat.com>
9189
9190         * top.c (quit_force): Call 'finalize_values'.
9191         * value.c (finalize_values): New function.
9192         * value.h (finalize_values): Declare.
9193
9194 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9195
9196         * NEWS: Announce $_gdb_major and $_gdb_minor.
9197
9198         * top.c (init_gdb_version_vars): New function.
9199         (gdb_init): Call init_gdb_version_vars.
9200
9201 2019-03-29  Tom Tromey  <tromey@adacore.com>
9202
9203         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9204         help text.  Remove dead code.
9205
9206 2019-03-29  Keith Seitz  <keiths@redhat.com>
9207
9208         From Siddhesh Poyarekar:
9209         * f-lang.h (f77_get_upperbound): Return LONGEST.
9210         (f77_get_lowerbound): Likewise.
9211         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9212         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9213         print them.
9214         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9215         plongest to format print it.
9216         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9217         (f77_get_upperbound): Likewise.
9218         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9219         LOWER_BOUND to LONGEST.
9220         (f77_create_arrayprint_offset_tbl): Likewise.
9221
9222 2019-03-29  Keith Seitz  <keiths@redhat.com>
9223
9224         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9225         %s/pulongest for TYPE_LENGTH instead of %d in format
9226         strings.
9227         * ada-typerint.c (ada_print_type): Likewise.
9228         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9229         * compile/compile-c-support.c (generate_register_struct): Likewise.
9230         * gdbtypes.c (recursive_dump_type): Likewise.
9231         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9232         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9233         instead of %d in format strings.
9234         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9235         to std::min to ULONGEST.
9236         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9237         instead of %d in format strings.
9238         * tracepoint.c (info_scope_command): Likewise.
9239         * typeprint.c (print_offset_data::update)
9240         (print_offset_data::finish): Likewise.
9241         * xtensa-tdep.c (xtensa_store_return_value)
9242         (xtensa_push_dummy_call): Likewise.
9243
9244 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9245
9246         * windows-nat.c (display_selector): Fixed format specifications
9247         for 64-bit Cygwin.
9248
9249 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9250
9251         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9252
9253 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9254
9255         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9256         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9257         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9258         (nios2_linux_init_abi): Install it.
9259
9260 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9261
9262         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9263
9264 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9265
9266         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9267
9268 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9269             Tom Tromey  <tromey@adacore.com>
9270
9271         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9272
9273 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9274
9275         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9276         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9277         method to compute the bounds of range types. Also print "[evaluated]"
9278         if the bounds' values come from a dynamic evaluation.
9279
9280 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9281
9282         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9283         whitespace when pretty printing is on.
9284
9285 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9286
9287         * ppc-linux-nat.c: Add include.
9288
9289 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9290
9291         * NEWS: Mention AArch64 Pointer Authentication.
9292
9293 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9294
9295         * arm-linux-nat.c: Add include.
9296
9297 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9298
9299         * source-cache.c (source_cache::get_source_lines): Re-read
9300         fullname after calling open_source_file.
9301
9302 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9303
9304         * NEWS: Mention TLS support for FreeBSD.
9305
9306 2019-03-25  Tom Tromey  <tromey@adacore.com>
9307
9308         * minsyms.c (BUNCH_SIZE): Update comment.
9309         (~minimal_symbol_reader): Remove old comment.
9310         (compact_minimal_symbols): Update comment.
9311         (minimal_symbol_reader::install): Remove old comment.  Update
9312         other comments.
9313
9314 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9315
9316         * s390-linux-nat.c: Add include.
9317
9318 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9319
9320         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9321         Call linux_get_hwcap.
9322         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9323         Likewise.
9324         (aarch64_linux_get_hwcap): Remove function.
9325         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9326         declaration.
9327         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9328         linux_get_hwcap.
9329         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9330         * linux-tdep.c (linux_get_hwcap): Add function.
9331         (linux_get_hwcap2): Likewise.
9332         * linux-tdep.h (linux_get_hwcap): Add declaration.
9333         (linux_get_hwcap2): Likewise.
9334         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9335         (ppc_linux_get_hwcap2): Likewise.
9336         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9337         linux_get_hwcap.
9338         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9339         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9340         (ppc_linux_nat_target::read_description): Likewise.
9341         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9342         * s390-linux-nat.c: Likewise.
9343         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9344
9345 2019-03-24  Tom Tromey  <tom@tromey.com>
9346
9347         * ada-lang.c (standard_lookup): Simplify initialization.
9348         (ada_lookup_symbol_nonlocal): Simplify return.
9349         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9350         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9351         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9352         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9353         initialization.
9354         * solib.c (solib_global_lookup): Simplify.
9355         * symtab.c (null_block_symbol): Remove.
9356         (symbol_cache_lookup): Simplify returns.
9357         (lookup_language_this): Simplify returns.
9358         (lookup_symbol_aux): Simplify return.
9359         (lookup_local_symbol): Simplify returns.
9360         (lookup_global_symbol_from_objfile): Simplify return.
9361         (lookup_symbol_in_objfile_symtabs)
9362         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9363         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9364         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9365         * cp-namespace.c (cp_lookup_bare_symbol)
9366         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9367         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9368         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9369         (cp_lookup_symbol_via_imports): Simplify initialization.
9370         (find_symbol_in_baseclass): Likewise.
9371         * symtab.h (null_block_symbol): Remove.
9372         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9373         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9374         (d_lookup_symbol_module): Likewise.
9375         (find_symbol_in_baseclass): Simplify initialization.
9376
9377 2019-03-24  Tom Tromey  <tom@tromey.com>
9378
9379         * expression.h: Don't include symtab.h.
9380         (struct block): Forward declare.
9381
9382 2019-03-24  Tom Tromey  <tom@tromey.com>
9383
9384         * c-exp.y (typebase): Remove casts.
9385         * gdbtypes.c (lookup_unsigned_typename, )
9386         (lookup_signed_typename): Remove cast.
9387         * eval.c (parse_to_comma_and_eval): Remove cast.
9388         * parse.c (write_dollar_variable): Remove cast.
9389         * block.h (struct block) <superblock>: Now const.
9390         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9391         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9392         (map_block): Make "block" const.
9393         * symfile.h (struct quick_symbol_functions)
9394         <map_matching_symbols>: Constify block argument to "callback".
9395         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9396         const.
9397         (find_pc_sect_compunit_symtab): Make "b" const.
9398         (find_symbol_at_address): Likewise.
9399         (search_symbols): Likewise.
9400         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9401         (dw2_debug_names_lookup_symbol): Likewise.
9402         (dw2_map_matching_symbols): Update.
9403         * p-valprint.c (pascal_val_print): Remove "block".
9404         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9405         (aux_add_nonlocal_symbols): Make "block" const.
9406         (resolve_subexp): Remove cast.
9407         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9408         const.
9409         (iterate_over_file_blocks): Likewise.
9410         * f-exp.y (%union) <bval>: Remove.
9411         * coffread.c (patch_opaque_types): Make "b" const.
9412         * spu-tdep.c (spu_catch_start): Make "block" const.
9413         * c-valprint.c (print_unpacked_pointer): Remove "block".
9414         * symmisc.c (dump_symtab_1): Make "b" const.
9415         (block_depth): Make "block" const.
9416         * d-exp.y (%union) <bval>: Remove.
9417         * cp-support.h (cp_lookup_rtti_type): Update.
9418         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9419         * psymtab.c (psym_lookup_symbol): Make "block" const.
9420         (maintenance_check_psymtabs): Make "b" const.
9421         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9422         (enumerate_locals, enumerate_args): Update.
9423         * python/py-symtab.c (stpy_global_block): Make "block" const.
9424         (stpy_static_block): Likewise.
9425         * inline-frame.c (block_starting_point_at): Make "new_block"
9426         const.
9427         * block.c (find_block_in_blockvector): Make return type const.
9428         (blockvector_for_pc_sect): Make "b" const.
9429         (find_block_in_blockvector): Make "b" const.
9430
9431 2019-03-23  Tom Tromey  <tom@tromey.com>
9432
9433         * varobj.c (varobj_create): Update.
9434         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9435         * printcmd.c (display_command, do_one_display): Don't reset
9436         innermost_block.
9437         * parser-defs.h (enum innermost_block_tracker_type): Move to
9438         expression.h.
9439         (innermost_block): Update comment.
9440         * parse.c (parse_exp_1): Add tracker_types parameter.
9441         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9442         tracker_types parameter.  Reset innermost_block.
9443         (parse_exp_in_context): Remove.
9444         (parse_expression_for_completion): Update.
9445         * objfiles.c (~objfile): Don't reset expression_context_block or
9446         innermost_block.
9447         * expression.h (enum innermost_block_tracker_type): Move from
9448         parser-defs.h.
9449         (parse_exp_1): Add tracker_types parameter.
9450         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9451         reset innermost_block.
9452
9453 2019-03-23  Tom Tromey  <tom@tromey.com>
9454
9455         * objfiles.h: Include bcache.h.
9456
9457 2019-03-23  Tom Tromey  <tom@tromey.com>
9458
9459         * linespec.c (get_current_search_block): Use
9460         scoped_restore_current_language.
9461         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9462
9463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9464             Jiong Wang  <jiong.wang@arm.com>
9465
9466         * aarch64-linux-tdep.c
9467         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9468         section.
9469         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9470
9471 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9472             Jiong Wang  <jiong.wang@arm.com>
9473
9474         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9475         instructions.
9476         (aarch64_analyze_prologue_test): Add PACIASP test.
9477         (aarch64_prologue_prev_register): Unmask PC value.
9478
9479 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9480             Jiong Wang  <jiong.wang@arm.com>
9481
9482         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9483         (aarch64_dwarf2_prev_register): Unmask PC value.
9484         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9485         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9486         DW_CFA_AARCH64_negate_ra_state.
9487         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9488
9489 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9490             Jiong Wang  <jiong.wang@arm.com>
9491
9492         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9493         registers.
9494         (aarch64_pseudo_register_name): Likewise.
9495         (aarch64_pseudo_register_type): Likewise.
9496         (aarch64_pseudo_register_reggroup_p): Likewise.
9497         (aarch64_gdbarch_init): Add pauth registers.
9498         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9499         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9500         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9501         (struct gdbarch_tdep): Add regnum for ra_state.
9502
9503 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9504             Jiong Wang  <jiong.wang@arm.com>
9505
9506         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9507
9508 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9509             Jiong Wang  <jiong.wang@arm.com>
9510
9511         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9512         function.
9513         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9514         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9515         (aarch64_gdbarch_init): Add puth registers.
9516         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9517         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9518         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9519
9520 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9521             Jiong Wang  <jiong.wang@arm.com>
9522
9523         * aarch64-linux-nat.c
9524         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9525         * aarch64-linux-tdep.c
9526         (aarch64_linux_core_read_description): Likewise.
9527         (aarch64_linux_get_hwcap): New function.
9528         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9529         (aarch64_linux_get_hwcap): New declaration.
9530
9531 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9532             Jiong Wang  <jiong.wang@arm.com>
9533
9534         * aarch64-linux-nat.c
9535         (aarch64_linux_nat_target::read_description): Add pauth param.
9536         * aarch64-linux-tdep.c
9537         (aarch64_linux_core_read_description): Likewise.
9538         * aarch64-tdep.c (struct target_desc): Add in pauth.
9539         (aarch64_read_description): Add pauth param.
9540         (aarch64_gdbarch_init): Likewise.
9541         * aarch64-tdep.h (aarch64_read_description): Likewise.
9542         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9543         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9544         * features/Makefile: Add new files.
9545         * features/aarch64-pauth.c: New file.
9546         * features/aarch64-pauth.xml: New file.
9547
9548 2019-03-20  Tom Tromey  <tromey@adacore.com>
9549
9550         * infrun.c (handle_inferior_event): Rename from
9551         handle_inferior_event_1.  Create a scoped_value_mark.
9552         (handle_inferior_event): Remove.
9553
9554 2019-03-19  Tom Tromey  <tromey@adacore.com>
9555
9556         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9557         * infrun.h (print_stop_event): Add "displays" parameter.
9558         * infrun.c (print_stop_event): Add "displays" parameter.
9559
9560 2019-03-19  Pedro Alves  <palves@redhat.com>
9561
9562         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9563         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9564         to -1.  Fix TABs vs spaces.
9565         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9566         * tui/tui-out.h (tui_ui_out) Add intro comments.
9567         <m_line, m_start_of_line>: In-class initialize, and add describing
9568         comment.
9569
9570 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9571
9572         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9573         variable names.
9574         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9575
9576 2019-03-18  Pedro Alves  <palves@redhat.com>
9577             Eli Zaretskii <eliz@gnu.org>
9578
9579         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9580         m_line and m_start_of_line.
9581
9582 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9583
9584         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9585         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9586         it returns a newline.  This fixes a regression in TU mode, whereby
9587         the next line is output on the same screen line as the user input.
9588
9589 2019-03-18  Tom Tromey  <tromey@adacore.com>
9590
9591         * minsyms.c (minimal_symbol_reader::install): Remove call to
9592         obstack_blank.
9593
9594 2019-03-18  Pedro Alves  <palves@redhat.com>
9595
9596         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9597         New globals.
9598         (apply_style): New, factored out from ...
9599         (apply_ansi_escape): ... this.  Handle reverse video mode.
9600         (tui_set_reverse_mode): New function.
9601         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9602         * tui/tui-winsource.c (tui_show_source_line): Use
9603         tui_set_reverse_mode instead of setting A_STANDOUT.
9604         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9605         New setter methods.
9606
9607 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9608
9609         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9610         Handle tabs.
9611
9612 2019-03-18  Tom Tromey  <tromey@adacore.com>
9613
9614         * ada-lang.c (empty_array): Add "high" parameter.
9615         (ada_evaluate_subexp): Update.
9616
9617 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9618
9619         * unittests/string_view-selftests.c: Define
9620         _initialize_string_view_selftests unconditionally.
9621
9622 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9623
9624         PR gdb/24350
9625         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9626
9627 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9628
9629         PR gdb/24351
9630         * windows-nat.c (display_selector): Fix format specifiers.
9631
9632 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9633
9634         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9635         tui_refill_source_window instead of tui_refresh_win, to update the
9636         current execution line.  This fixes redisplay of the current line
9637         when stepping through the code with "next" or "step".
9638
9639 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9640
9641         * source-cache.c (source_cache::get_source_lines): Call
9642         find_source_lines to initialize s->nlines.  This fixes vertical
9643         scrolling of TUI source window when the DOWN arrow is pressed.
9644
9645 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9646
9647         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9648         linux-thread-db.c (_initialize_thread_db): Likewise.
9649
9650 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9651
9652         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9653         wclrtoeol in tui_show_source_line".  This reverts changes made in
9654         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9655
9656 2019-03-15  Tom Tromey  <tom@tromey.com>
9657
9658         * symtab.h (struct minimal_symbol): Derive from
9659         general_symbol_info.
9660         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9661         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9662         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9663         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9664         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9665         (MSYMBOL_SEARCH_NAME): Update.
9666         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9667         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9668         * minsyms.c (minimal_symbol_reader::record_full): Update.
9669
9670 2019-03-15  Tom Tromey  <tom@tromey.com>
9671
9672         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9673
9674 2019-03-15  Tom Tromey  <tom@tromey.com>
9675
9676         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9677         unique_xmalloc_ptr.
9678         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9679         Update.
9680         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9681         (build_minimal_symbol_hash_tables)
9682         (minimal_symbol_reader::install): Update.
9683
9684 2019-03-15  Tom Tromey  <tom@tromey.com>
9685
9686         * symtab.c (create_demangled_names_hash): Update.
9687         (symbol_set_names): Update.
9688         * objfiles.h (struct objfile_per_bfd_storage)
9689         <demangled_names_hash>: Now an htab_up.
9690         * objfiles.c (objfile_per_bfd_storage): Simplify.
9691
9692 2019-03-15  Tom Tromey  <tom@tromey.com>
9693
9694         * objfiles.h (struct objfile_per_bfd_storage): Declare
9695         destructor.
9696         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9697         New.
9698         (get_objfile_bfd_data): Use new.  Don't initialize
9699         language_of_main.
9700         (free_objfile_per_bfd_storage): Remove.
9701         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9702
9703 2019-03-15  Tom Tromey  <tom@tromey.com>
9704
9705         * symfile.c (reread_symbols): Update.
9706         * objfiles.c (objfile::objfile): Update.
9707         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9708         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9709         comment.
9710         (minimal_symbol_reader::install): Update.
9711         (terminate_minimal_symbol_table): Remove.
9712         * jit.c (jit_object_close_impl): Update.
9713
9714 2019-03-15  Tom Tromey  <tom@tromey.com>
9715
9716         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9717         initializations.
9718
9719 2019-03-15  Tom Tromey  <tom@tromey.com>
9720
9721         * objfiles.h (struct objfile_per_bfd_storage)
9722         <demangled_hash_languages>: Now a bitset.
9723         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9724         (lookup_minimal_symbol): Update.
9725
9726 2019-03-15  Tom Tromey  <tom@tromey.com>
9727
9728         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9729         Don't return the symbol.
9730         * coffread.c (record_minimal_symbol): Use record_full.
9731
9732 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9733
9734         The MS-Windows port of ncurses fails to switch to a color pair if
9735         one or both of the colors are the implicit default colors.  This
9736         change records the default colors when TUI is initialized, and
9737         then specifies them explicitly when a color pair uses the default
9738         colors.  This allows color styling in TUI mode on MS-Windows.
9739
9740         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9741         ncurses_norm_attr.
9742         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9743         colors in ncurses_norm_attr.
9744         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9745         "none", replace it with the default color recorded in
9746         ncurses_norm_attr.
9747
9748 2019-03-14  Tom Tromey  <tromey@adacore.com>
9749
9750         * source-cache.h (class source_cache) <get_source_lines>: Return
9751         std::string.
9752         * source-cache.c (source_cache::extract_lines): Handle case where
9753         first_pos==npos.  Return std::string.
9754         (source_cache::get_source_lines): Update.
9755
9756 2019-03-14  Tom Tromey  <tromey@adacore.com>
9757
9758         * NEWS: Add item for "style sources" commands.
9759         * source-cache.c (source_cache::get_source_lines): Check
9760         source_styling.
9761         * cli/cli-style.c (source_styling): New global.
9762         (_initialize_cli_style): Add "style sources" commands.
9763         (show_style_sources): New function.
9764         * cli/cli-style.h (source_styling): Declare.
9765
9766 2019-03-14  Pedro Alves  <palves@redhat.com>
9767             Tom Tromey  <tromey@adacore.com>
9768
9769         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9770         * tui/tui-winsource.c (tui_refill_source_window): New function,
9771         from...
9772         (tui_horizontal_source_scroll): ... here.  Move some logic.
9773         * cli/cli-style.c (set_style_enabled): Notify new observable.
9774         * tui/tui-hooks.c (tui_redisplay_source): New function.
9775         (tui_attach_detach_observers): Attach or detach
9776         tui_redisplay_source.
9777         * observable.h (source_styling_changed): New observable.
9778         * observable.c: Define source_styling_changed observable.
9779
9780 2019-03-13  Tom Tromey  <tromey@adacore.com>
9781
9782         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9783         (i386_gnu_nat_target::store_registers): Update.
9784         * target-debug.h (target_debug_print_std_string): New macro.
9785         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9786         * windows-tdep.c (display_one_tib): Update.
9787         * tui/tui-stack.c (tui_make_status_line): Update.
9788         * top.c (print_inferior_quit_action): Update.
9789         * thread.c (thr_try_catch_cmd): Update.
9790         (add_thread_with_info): Update.
9791         (thread_target_id_str): Update.
9792         (thr_try_catch_cmd): Update.
9793         (thread_command): Update.
9794         (thread_find_command): Update.
9795         * record-btrace.c (record_btrace_target::info_record)
9796         (record_btrace_resume_thread, record_btrace_target::resume)
9797         (record_btrace_cancel_resume, record_btrace_step_thread)
9798         (record_btrace_target::wait, record_btrace_target::wait)
9799         (record_btrace_target::wait, record_btrace_target::stop): Update.
9800         * progspace.c (print_program_space): Update.
9801         * process-stratum-target.c
9802         (process_stratum_target::thread_address_space): Update.
9803         * linux-fork.c (linux_fork_mourn_inferior)
9804         (detach_checkpoint_command, info_checkpoints_command)
9805         (linux_fork_context): Update.
9806         (linux_fork_detach): Update.
9807         (class scoped_switch_fork_info): Update.
9808         (delete_checkpoint_command): Update.
9809         * infrun.c (follow_fork_inferior): Update.
9810         (follow_fork_inferior): Update.
9811         (proceed_after_vfork_done): Update.
9812         (handle_vfork_child_exec_or_exit): Update.
9813         (follow_exec): Update.
9814         (displaced_step_prepare_throw): Update.
9815         (displaced_step_restore): Update.
9816         (start_step_over): Update.
9817         (resume_1): Update.
9818         (clear_proceed_status_thread): Update.
9819         (proceed): Update.
9820         (print_target_wait_results): Update.
9821         (do_target_wait): Update.
9822         (context_switch): Update.
9823         (stop_all_threads): Update.
9824         (restart_threads): Update.
9825         (finish_step_over): Update.
9826         (handle_signal_stop): Update.
9827         (switch_back_to_stepped_thread): Update.
9828         (keep_going_pass_signal): Update.
9829         (print_exited_reason): Update.
9830         (normal_stop): Update.
9831         * inferior.c (inferior_pid_to_str): Change return type.
9832         (print_selected_inferior): Update.
9833         (add_inferior): Update.
9834         (detach_inferior): Update.
9835         * dummy-frame.c (fprint_dummy_frames): Update.
9836         * dcache.c (dcache_info_1): Update.
9837         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9838         (btrace_fetch, btrace_clear): Update.
9839         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9840         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9841         type.
9842         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9843         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9844         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9845         * gdbarch.c, gdbarch.h: Rebuild.
9846         * gdbarch.sh (core_pid_to_str): Change return type.
9847         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9848         return type.
9849         (windows_nat_target::pid_to_str): Change return type.
9850         (windows_delete_thread): Update.
9851         (windows_nat_target::attach): Update.
9852         (windows_nat_target::files_info): Update.
9853         * target-delegates.c: Rebuild.
9854         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9855         return type.
9856         (sol_thread_target::pid_to_str): Change return type.
9857         * remote.c (class remote_target) <pid_to_str>: Change return
9858         type.
9859         (remote_target::pid_to_str): Change return type.
9860         (extended_remote_target::attach, remote_target::remote_stop_ns)
9861         (remote_target::remote_notif_remove_queued_reply)
9862         (remote_target::push_stop_reply, remote_target::disable_btrace):
9863         Update.
9864         (extended_remote_target::attach): Update.
9865         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9866         type.
9867         (gdbsim_target::pid_to_str): Change return type.
9868         * ravenscar-thread.c (struct ravenscar_thread_target)
9869         <pid_to_str>: Change return type.
9870         (ravenscar_thread_target::pid_to_str): Change return type.
9871         * procfs.c (class procfs_target) <pid_to_str>: Change return
9872         type.
9873         (procfs_target::pid_to_str): Change return type.
9874         (procfs_target::attach): Update.
9875         (procfs_target::detach): Update.
9876         (procfs_target::fetch_registers): Update.
9877         (procfs_target::store_registers): Update.
9878         (procfs_target::wait): Update.
9879         (procfs_target::files_info): Update.
9880         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9881         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9882         return type.
9883         (nto_procfs_target::pid_to_str): Change return type.
9884         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9885         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9886         return type.
9887         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9888         (exit_lwp): Update.
9889         (attach_proc_task_lwp_callback, get_detach_signal)
9890         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9891         (linux_nat_target::resume, wait_lwp, stop_callback)
9892         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9893         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9894         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9895         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9896         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9897         type.
9898         (inf_ptrace_target::attach): Update.
9899         (inf_ptrace_target::files_info): Update.
9900         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9901         type.
9902         (go32_nat_target::pid_to_str): Change return type.
9903         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9904         (gnu_nat_target::wait): Update.
9905         (gnu_nat_target::wait): Update.
9906         (gnu_nat_target::resume): Update.
9907         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9908         (fbsd_nat_target::wait): Update.
9909         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9910         type.
9911         (darwin_nat_target::attach): Update.
9912         * corelow.c (class core_target) <pid_to_str>: Change return type.
9913         (core_target::pid_to_str): Change return type.
9914         * target.c (normal_pid_to_str): Change return type.
9915         (default_pid_to_str): Likewise.
9916         (target_pid_to_str): Change return type.
9917         (target_translate_tls_address): Update.
9918         (target_announce_detach): Update.
9919         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9920         return type.
9921         (bsd_uthread_target::pid_to_str): Change return type.
9922         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9923         type.
9924         (bsd_kvm_target::pid_to_str): Change return type.
9925         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9926         return type.
9927         (aix_thread_target::pid_to_str): Change return type.
9928         * target.h (struct target_ops) <pid_to_str>: Change return type.
9929         (target_pid_to_str, normal_pid_to_str): Likewise.
9930         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9931         type.
9932         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9933         type.
9934         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9935         return type.
9936         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9937         type.
9938         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9939         type.
9940         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9941         return type.
9942
9943 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9944
9945         * NEWS: Mention that the new default MI version is 3.  Mention
9946         changes to the output of commands and events that deal with
9947         multi-location breakpoints.
9948         * breakpoint.c: Include "mi/mi-out.h".
9949         (print_one_breakpoint): Change output syntax if using MI version
9950         >= 3.
9951         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9952         New.
9953         (mi_multi_location_breakpoint_output_fixed): New.
9954         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9955         (mi_cmd_fix_multi_location_breakpoint_output): New.
9956         (mi_multi_location_breakpoint_output_fixed): New.
9957         * mi/mi-cmds.c (mi_cmds): Register command
9958         -fix-multi-location-breakpoint-output.
9959         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9960         interpreter "mi".
9961
9962 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9963
9964         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9965         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9966         instantiate mi_ui_out based on interpreter name.
9967         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9968         * mi/mi-main.c (mi_load_progress): Likewise.
9969
9970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9971
9972         * NEWS: Combine separate "New targets" sections for 8.3.
9973
9974 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9975
9976         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9977         (ppcfbsd_init_abi): Install gdbarch
9978         "fetch_tls_load_module_address" and "get_thread_local_address"
9979         methods.
9980
9981 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9982
9983         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9984         (riscv_fbsd_init_abi): Install gdbarch
9985         "fetch_tls_load_module_address" and "get_thread_local_address"
9986         methods.
9987
9988 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9989
9990         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9991         (i386fbsd_init_abi): Install gdbarch
9992         "fetch_tls_load_module_address" and "get_thread_local_address"
9993         methods.
9994
9995 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9996
9997         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9998         (amd64fbsd_init_abi): Install gdbarch
9999         "fetch_tls_load_module_address" and "get_thread_local_address"
10000         methods.
10001
10002 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10003
10004         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10005         (struct fbsd_pspace_data): New type.
10006         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10007         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10008         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10009         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10010         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10011
10012 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10013
10014         * gdbtypes.c (lookup_struct_elt): New function.
10015         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10016         * gdbtypes.h (struct struct_elt): New type.
10017         (lookup_struct_elt): New prototype.
10018
10019 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10020
10021         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10022         remove disabled code block.
10023
10024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10025
10026         * gdbarch.sh (get_thread_local_address): New method.
10027         * gdbarch.h, gdbarch.c: Regenerate.
10028         * target.c (target_translate_tls_address): Use
10029         gdbarch_get_thread_local_address if present instead of
10030         target::get_thread_local_address.
10031
10032 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10033
10034         * target.h (target::get_thread_local_address): Update comment.
10035
10036 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10037
10038         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10039         objfile->separate_debug_objfile_backlink if not NULL.
10040
10041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10042
10043         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10044         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10045         (amd64bsd_store_inferior_registers): Likewise.
10046         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10047         Enable segment base registers.
10048         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10049         PT_GETFSBASE and PT_GETGSBASE.
10050         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10051         PT_SETGSBASE.
10052         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10053         segment base registers.
10054         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10055
10056 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10057
10058         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10059         Update calls to i386_target_description to add 'segments'
10060         parameter.
10061         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10062         add segment base registers.
10063         * arch/i386.c (i386_create_target_description): Add 'segments'
10064         parameter to enable segment base registers.
10065         * arch/i386.h (i386_create_target_description): Likewise.
10066         * features/i386/32bit-segments.xml: New file.
10067         * features/i386/32bit-segments.c: Generate.
10068         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10069         call to i386_target_description to add 'segments' parameter.
10070         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10071         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10072         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10073         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10074         if feature is present.
10075         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10076         Add 'segments' parameter to call to i386_target_description.
10077         (i386_target_description): Add 'segments' parameter to enable
10078         segment base registers.
10079         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10080         to call to i386_target_description.
10081         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10082         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10083         Define I386_NUM_REGS.
10084         (i386_target_description): Add 'segments' parameter to enable
10085         segment base registers.
10086
10087 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10088
10089         PR/24325
10090         * source-cache.c: #undef open and close, to avoid unresolved
10091         externals during linking.
10092
10093 2019-03-12  Tom Tromey  <tromey@adacore.com>
10094
10095         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10096         const.  Add initializers.
10097         (_initialize_remote): Don't initialize ptid globals.
10098
10099 2019-03-12  Pedro Alves  <palves@redhat.com>
10100
10101         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10102
10103 2019-03-12  Pedro Alves  <palves@redhat.com>
10104
10105         * cp-name-parser.y (main): Remove unused 'len' variable.
10106
10107 2019-03-12  Tom Tromey  <tromey@adacore.com>
10108
10109         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10110         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10111
10112 2019-03-12  Tom Tromey  <tromey@adacore.com>
10113
10114         * linux-nat.c (iterate_over_lwps): Update.
10115         (stop_callback): Remove parameter.
10116         (stop_wait_callback, detach_callback, resume_set_callback)
10117         (select_singlestep_lwp_callback, set_ignore_sigint)
10118         (status_callback, resumed_callback, resume_clear_callback)
10119         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10120         data parameter.
10121         (linux_nat_target::detach, linux_nat_target::resume)
10122         (linux_stop_and_wait_all_lwps, select_event_lwp)
10123         (linux_nat_filter_event, linux_nat_wait_1)
10124         (linux_nat_target::kill, linux_nat_target::stop)
10125         (linux_nat_target::stop): Update.
10126         (linux_nat_resume_callback): Change type.
10127         (resume_stopped_resumed_lwps, count_events_callback)
10128         (select_event_lwp_callback): Likewise.
10129         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10130         * arm-linux-nat.c (struct update_registers_data): Remove.
10131         (update_registers_callback): Change type.
10132         (arm_linux_insert_hw_breakpoint1): Update.
10133         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10134         parameter.
10135         (x86_linux_dr_set_addr): Update.
10136         (x86_linux_dr_set_control): Update.
10137         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10138         (iterate_over_lwps): Use gdb::function_view.
10139         * nat/aarch64-linux-hw-point.c (struct
10140         aarch64_dr_update_callback_param): Remove.
10141         (debug_reg_change_callback): Change type.
10142         (aarch64_notify_debug_reg_change): Update.
10143         * s390-linux-nat.c (s390_refresh_per_info): Update.
10144
10145 2019-03-11  Tom Tromey  <tromey@adacore.com>
10146
10147         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10148         redundant assignment to "this_cu".
10149
10150 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10151
10152         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10153
10154 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10155
10156         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10157         from...
10158         (rank_one_type): ... this.
10159
10160 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10161
10162         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10163         from...
10164         (rank_one_type): ... this.
10165
10166 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10167
10168         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10169         from...
10170         (rank_one_type): ... this.
10171
10172 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10173
10174         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10175         from...
10176         (rank_one_type): ... this.
10177
10178 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10179
10180         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10181         from...
10182         (rank_one_type): ... this.
10183
10184 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10185
10186         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10187         from...
10188         (rank_one_type): ... this.
10189
10190 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10191
10192         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10193         from...
10194         (rank_one_type): ... this.
10195
10196 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10197
10198         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10199         from...
10200         (rank_one_type): ... this.
10201
10202 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10203
10204         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10205         from...
10206         (rank_one_type): ... this.
10207
10208 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10209
10210         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10211         from...
10212         (rank_one_type): ... this.
10213
10214 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10215
10216         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10217         from...
10218         (rank_one_type): ... this.
10219
10220 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10221
10222         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10223         from...
10224         (rank_one_type): ... this.
10225
10226 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10227
10228         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10229         inferior-events' shows the example events.
10230
10231 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10232
10233         Support styling on native MS-Windows console
10234
10235         PR/24315
10236         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10237         on MS-Windows if $TERM is not defined.
10238
10239         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10240
10241         * posix-hdep.c (gdb_console_fputs):
10242         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10243         functions.
10244         * ui-file.h (gdb_console_fputs): Add prototype.
10245
10246         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10247         back to fputs only if the former returns zero.
10248
10249 2019-03-07  Tom Tromey  <tom@tromey.com>
10250
10251         * symmisc.c (print_symbol_bcache_statistics): Update.
10252         (print_objfile_statistics): Update.
10253         * symfile.c (allocate_symtab): Update.
10254         * stabsread.c: Don't include bcache.h.
10255         * psymtab.h (struct psymbol_bcache): Don't declare.
10256         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10257         (psymbol_bcache_init, psymbol_bcache_free)
10258         (psymbol_bcache_get_bcache): Don't declare.
10259         * psymtab.c (struct psymbol_bcache): Remove.
10260         (psymtab_storage::psymtab_storage): Update.
10261         (psymtab_storage::~psymtab_storage): Update.
10262         (psymbol_bcache_init, psymbol_bcache_free)
10263         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10264         (add_psymbol_to_bcache): Update.
10265         (allocate_psymtab): Update.
10266         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10267         macro_cache>: No longer pointers.
10268         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10269         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10270         * macrotab.c (macro_bcache): Update.
10271         * macroexp.c: Don't include bcache.h.
10272         * gdbtypes.c (check_types_worklist): Update.
10273         (types_deeply_equal): Remove TRY/CATCH.  Update.
10274         * elfread.c (elf_symtab_read): Update.
10275         * dwarf2read.c: Don't include bcache.h.
10276         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10277         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10278         (print_bcache_statistics, bcache_memory_used): Don't declare.
10279         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10280         methods.  Rename all data members.
10281         * bcache.c (struct bcache): Move to bcache.h.
10282         (bcache::expand_hash_table): Rename from expand_hash_table.
10283         (bcache): Remove.
10284         (bcache::insert): Rename from bcache_full.
10285         (bcache::compare): Rename from bcache_compare.
10286         (bcache_xmalloc): Remove.
10287         (bcache::~bcache): Rename from bcache_xfree.
10288         (bcache::print_statistics): Rename from print_bcache_statistics.
10289         (bcache::memory_used): Rename from bcache_memory_used.
10290
10291 2019-03-07  Pedro Alves  <palves@redhat.com>
10292
10293         * infrun.c (normal_stop): Also check for
10294         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10295
10296 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * f-lang.c (value_from_host_double): Moved to...
10299         * value.c (value_from_host_double): ...here.
10300         * value.h (value_from_host_double): Declare.
10301         * guile/scm-math.c (vlscm_convert_typed_number): Use
10302         value_from_host_double.
10303         (vlscm_convert_number): Likewise.
10304         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10305         * python/py-value.c (convert_value_from_python): Likewise.
10306
10307 2019-03-06  Tom Tromey  <tom@tromey.com>
10308
10309         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10310
10311 2019-03-06  Tom Tromey  <tom@tromey.com>
10312
10313         * utils.h (free_current_contents): Don't declare.
10314         * utils.c (free_current_contents): Remove.
10315
10316 2019-03-06  Tom Tromey  <tom@tromey.com>
10317
10318         * top.c (quit_force): Update.
10319         * main.c (captured_command_loop): Update.
10320         * common/new-op.c (operator new): Update.
10321         * common/common-exceptions.c (struct catcher)
10322         <save_cleanup_chain>: Remove member.
10323         (exceptions_state_mc_init): Update.
10324         (exception_try_scope_entry): Return nullptr.
10325         (exception_try_scope_exit, exception_rethrow)
10326         (throw_exception_sjlj, throw_exception_cxx): Update.
10327         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10328         (all_cleanups, do_cleanups, discard_cleanups)
10329         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10330         (restore_cleanups, restore_final_cleanups): Don't declare.
10331         (do_final_cleanups): Remove parameter.
10332         * common/cleanups.c (cleanup_chain, make_cleanup)
10333         (make_cleanup_dtor, all_cleanups, do_cleanups)
10334         (discard_my_cleanups, discard_cleanups)
10335         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10336         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10337         (null_cleanup): Remove.
10338         (do_final_cleanups): Remove parameter.
10339
10340 2019-03-06  Tom Tromey  <tom@tromey.com>
10341
10342         * remote.c (remote_target::remote_parse_stop_reply): Use
10343         unique_xmalloc_ptr.
10344
10345 2019-03-06  Tom Tromey  <tom@tromey.com>
10346
10347         * stabsread.c (struct stabs_field_info): Rename from field_info.
10348         <list, fnlist>: Add initializers.
10349         <obstack>: New member.
10350         (read_member_functions, read_struct_fields, read_baseclasses):
10351         Allocate on obstack.  Don't use cleanups.
10352         (read_one_struct_field, read_member_functions, read_struct_fields)
10353         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10354         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10355         (read_struct_type): Update.
10356
10357 2019-03-06  Tom Tromey  <tom@tromey.com>
10358
10359         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10360         * common/filestuff.h (make_cleanup_close): Don't declare.
10361         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10362         Remove.
10363
10364 2019-03-06  Tom Tromey  <tom@tromey.com>
10365
10366         * solib-aix.c: Use make_scope_exit.
10367
10368 2019-03-06  Tom Tromey  <tom@tromey.com>
10369
10370         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10371         Use make_scope_exit.
10372
10373 2019-03-06  Tom Tromey  <tom@tromey.com>
10374
10375         * solib-svr4.c (disable_probes_interface): Remove parameter.
10376         (svr4_handle_solib_event): Use make_scope_exit.
10377
10378 2019-03-06  Tom Tromey  <tom@tromey.com>
10379
10380         * remote.c (struct stop_reply_deleter): Remove.
10381         (stop_reply_up): Update.
10382         (struct stop_reply): Derive from notif_event.  Don't typedef.
10383         <regcache>: Now a std::vector.
10384         (stop_reply_xfree): Remove.
10385         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10386         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10387         (remote_target::discard_pending_stop_replies): Use delete.
10388         (remote_target::remote_parse_stop_reply): Update.
10389         (remote_target::process_stop_reply): Update.
10390         * remote-notif.h (struct notif_event): Add virtual destructor.
10391         Remove "dtr" member.
10392         (struct notif_client) <alloc_event>: Return a unique_ptr.
10393         (notif_event_xfree): Don't declare.
10394         (notif_event_up): New typedef.
10395         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10396         (notif_event_xfree, do_notif_event_xfree): Remove.
10397         (remote_notif_state_xfree): Update.
10398
10399 2019-03-06  Tom Tromey  <tom@tromey.com>
10400
10401         * infrun.c (displaced_step_clear_cleanup): Now a
10402         forward_scope_exit type.
10403         (displaced_step_prepare_throw): Update.
10404         (displaced_step_fixup): Update.
10405
10406 2019-03-06  Tom Tromey  <tom@tromey.com>
10407
10408         * inferior.h (class inferior): Update comment.
10409         * gdbthread.h (class thread_info): Update comment.
10410
10411 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10412             Tom Tromey  <tom@tromey.com>
10413
10414         * stabsread.h (struct stab_section_list): Remove.
10415         (coffstab_build_psymtabs): Update.
10416         * dbxread.c (symbuf_sections): Now a std::vector.
10417         (sect_idx): New global.
10418         (fill_symbuf): Update.
10419         (coffstab_build_psymtabs): Change type of stabsects parameter.
10420         Update.
10421         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10422         std::vector.
10423         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10424         (coff_locate_sections): Update.
10425         (coff_symfile_read): Remove cleanups.  Update.
10426         (init_stringtab): Add storage parameter.
10427         (free_stringtab, free_stringtab_cleanup): Remove.
10428         (init_lineno): Add storage parameter.
10429         (free_linetab, free_linetab_cleanup): Remove.
10430
10431 2019-03-06  Pedro Alves  <palves@redhat.com>
10432
10433         * linux-fork.c (fork_info::clobber_regs): Delete.
10434         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10435         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10436         comment.  Adjust.
10437         (scoped_switch_fork_info::scoped_switch_fork_info)
10438         (checkpoint_command, linux_fork_context): Adjust
10439         fork_save_infrun_state calls.
10440
10441 2019-03-06  Pedro Alves  <palves@redhat.com>
10442
10443         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10444         (inf_has_multiple_threads): Return 'bool' and rewrite using
10445         inferior_info::threads().
10446
10447 2019-03-06  Pedro Alves  <palves@redhat.com>
10448
10449         * linux-fork.c: Include <list>.
10450         (fork_list): Now a std::list instance.
10451         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10452         (forks_exist_p, find_last_fork): Adjust.
10453         (new_fork): Delete.
10454         (one_fork_p): New.
10455         (add_fork): Adjust.
10456         (free_fork): Delete, folded into fork_info::~fork_info().
10457         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10458         Adjust.
10459         (init_fork_list): Delete.
10460         (linux_fork_killall, linux_fork_mourn_inferior)
10461         (linux_fork_detach, info_checkpoints_command): Adjust.
10462         (_initialize_linux_fork): No longer call init_fork_list.
10463
10464 2019-03-06  Pedro Alves  <palves@redhat.com>
10465
10466         * linux-fork.c (new_fork): New, split out of ...
10467         (add_fork): ... this.  Return void.  Move "first fork" special
10468         case from here, to ...
10469         (checkpoint_command): ... here.
10470         * linux-linux.h (add_fork): Return void.
10471
10472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10473
10474         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10475
10476 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10477             Chris January  <chris.january@arm.com>
10478             David Lecomber  <david.lecomber@arm.com>
10479
10480         * f-exp.y: New token, UNOP_INTRINSIC.
10481         (exp): New pattern using UNOP_INTRINSIC token.
10482         (f77_keywords): Add 'abs' keyword.
10483         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10484         (value_from_host_double): New function.
10485         (evaluate_subexp_f): Support UNOP_ABS.
10486
10487 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10488
10489         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10490         types.
10491
10492 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10493
10494         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10495         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10496         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10497
10498 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10499
10500         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10501
10502 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10503             Chris January  <chris.january@arm.com>
10504
10505         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10506         * f-exp.y: Define 'KIND' token.
10507         (exp): New pattern for KIND expressions.
10508         (ptype): Handle types with a kind extension.
10509         (direct_abs_decl): Extend to spot kind extensions.
10510         (f77_keywords): Add 'kind' to the list.
10511         (push_kind_type): New function.
10512         (convert_to_kind_type): New function.
10513         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10514         * parse.c (operator_length_standard): Likewise.
10515         * parser-defs.h (enum type_pieces): Add tp_kind.
10516         * std-operator.def: Add UNOP_KIND.
10517
10518 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10519
10520         * f-exp.y (f_parse): Set yydebug.
10521
10522 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10523
10524         * f-lang.c (evaluate_subexp_f): New function.
10525         (exp_descriptor_f): New global.
10526         (f_language_defn): Use exp_descriptor_f instead of
10527         exp_descriptor_standard.
10528
10529 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10530
10531         * f-exp.y (struct token): Add comments.
10532         (dot_ops): Remove uppercase versions and the end marker.
10533         (f77_keywords): Likewise.
10534         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10535         entries in the dot_ops array are case insensitive, and use
10536         strncasecmp to compare strings.  Also some whitespace cleanup in
10537         this area.  Similar for the f77_keywords array, except entries in
10538         this list might be case sensitive.
10539
10540 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10541
10542         * f-exp.y (struct f77_boolean_val): Add comments.
10543         (boolean_values): Remove uppercase versions, and end marker.
10544         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10545         and use strncasecmp to achieve case insensitivity.  Additionally,
10546         perform whitespace cleanup around this code.
10547
10548 2019-03-06  Tom Tromey  <tromey@adacore.com>
10549
10550         * remote-sim.c (gdbsim_target_open): Use result of
10551         gdb_argv::release.
10552
10553 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10554         Dirk Schubert  <dirk.schubert@arm.com>
10555         Chris January  <chris.january@arm.com>
10556
10557         * eval.c (evaluate_subexp_standard): Call Fortran argument
10558         wrapping logic.
10559         * f-lang.c (struct value): A value which can be passed into a
10560         Fortran function call.
10561         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10562         where appropriate.
10563         (struct type): Value ready for a Fortran function call.
10564         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10565         is needed.
10566         * f-lang.h (fortran_argument_convert): Declaration.
10567         (fortran_preserve_arg_pointer): Declaration.
10568         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10569
10570 2019-03-05  Tom Tromey  <tromey@adacore.com>
10571
10572         * python/py-prettyprint.c (print_string_repr): Remove #if.
10573         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10574
10575 2019-03-05  Tom Tromey  <tromey@adacore.com>
10576
10577         * target.c (the_dummy_target): Move later.  Change type to
10578         "dummy_target".
10579         (initialize_targets): Don't initialize the_dummy_target.
10580
10581 2019-03-05  Tom Tromey  <tromey@adacore.com>
10582
10583         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10584         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10585
10586 2019-03-05  Tom Tromey  <tromey@adacore.com>
10587
10588         * windows-nat.c (windows_nat_target::attach)
10589         (windows_nat_target::detach): Don't call gdb_flush.
10590         * valprint.c (generic_val_print, val_print, val_print_string):
10591         Don't call gdb_flush.
10592         * utils.c (defaulted_query): Don't call gdb_flush.
10593         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10594         * target.c (target_announce_detach): Don't call gdb_flush.
10595         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10596         * remote.c (extended_remote_target::attach): Don't call
10597         gdb_flush.
10598         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10599         * printcmd.c (do_examine): Don't call gdb_flush.
10600         (info_display_command): Don't call gdb_flush.
10601         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10602         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10603         * memattr.c (info_mem_command): Don't call gdb_flush.
10604         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10605         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10606         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10607         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10608         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10609         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10610         (gnu_nat_target::detach): Don't call gdb_flush.
10611         * f-valprint.c (f_val_print): Don't call gdb_flush.
10612         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10613         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10614         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10615         gdb_flush.
10616         * c-valprint.c (c_val_print): Don't call gdb_flush.
10617         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10618
10619 2019-03-05  Tom Tromey  <tromey@adacore.com>
10620
10621         * varobj.c (update_dynamic_varobj_children): Update.
10622         (install_default_visualizer): Use reset, not release.
10623         * value.c (set_internalvar): Update.
10624         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10625         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10626         ATTRIBUTE_UNUSED_RESULT.
10627
10628 2019-03-05  Tom Tromey  <tromey@adacore.com>
10629
10630         * remote.c (class scoped_remote_fd) <release>: Add
10631         ATTRIBUTE_UNUSED_RESULT.
10632
10633 2019-03-05  Tom Tromey  <tromey@adacore.com>
10634
10635         * macroexp.c (struct macro_buffer) <release>: Add
10636         ATTRIBUTE_UNUSED_RESULT.
10637
10638 2019-03-05  Tom Tromey  <tromey@adacore.com>
10639
10640         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10641         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10642         ATTRIBUTE_UNUSED_RESULT.
10643
10644 2019-03-05  Tom Tromey  <tromey@adacore.com>
10645
10646         * common/scoped_fd.h (class scoped_fd) <release>: Add
10647         ATTRIBUTE_UNUSED_RESULT.
10648
10649 2019-03-05  Tom Tromey  <tromey@adacore.com>
10650
10651         * parser-defs.h (struct parser_state) <release>: Add
10652         ATTRIBUTE_UNUSED_RESULT.
10653
10654 2019-03-05  Tom Tromey  <tromey@adacore.com>
10655
10656         * utils.h (class gdb_argv) <release>: Add
10657         ATTRIBUTE_UNUSED_RESULT.
10658         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10659
10660 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10661
10662         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10663         for-loop range, to avoid compiler warnings.
10664
10665         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10666         avoid compiler warnings about unused variables.
10667
10668         * NEWS: Mention end of support for native debugging on MS-Windows
10669         before XP.
10670
10671         PR gdb/24292
10672         * common/netstuff.c:
10673         * gdbserver/gdbreplay.c
10674         * gdbserver/remote-utils.c:
10675         * ser-tcp.c:
10676         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10677         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10678         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10679         'getaddrinfo' and 'freeaddrinfo' were not available before
10680         Windows XP, and mingw.org's MinGW headers by default define
10681         _WIN32_WINNT to 0x500.
10682
10683 2019-03-01  Gary Benson <gbenson@redhat.com>
10684
10685         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10686
10687 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10688             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10689
10690         PR gdb/8527
10691         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10692         set_sigint_trap, clear_sigint_trap.
10693
10694 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10695
10696         * target.c (target_detach): Clear the regcache and the
10697         frame cache.
10698
10699 2019-02-27  Pedro Alves  <palves@redhat.com>
10700
10701         * utils.c (set_screen_size): When we cap the height/width sizes,
10702         tweak the corresponding command variable to show "unlimited":
10703
10704 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10705             Pedro Alves  <palves@redhat.com>
10706
10707         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10708         before calling rl_set_screen_size.
10709
10710 2019-02-27  Tom Tromey  <tromey@adacore.com>
10711
10712         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10713         define.
10714         * python/py-value.c: Remove Python 2.4 workaround.
10715         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10716         workaround.
10717         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10718         Python 2.4 workaround.
10719         * python/python-internal.h: Remove Python 2.4 comment.
10720         (Py_ssize_t): Don't define.
10721         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10722         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10723         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10724         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10725         * python/python.c (do_start_initialization): Remove Python 2.4
10726         workaround.
10727         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10728         (print_children): Remove Python 2.4 workaround.
10729         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10730         workaround.
10731         (CHARBUFFERPROC_NAME): Remove.
10732         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10733         Python 2.4 workaround.
10734
10735 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10736
10737         * NEWS: Note minimum Python version.
10738
10739 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10740
10741         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10742         code from these functions.  Remove corresponding ifdefs.  Use
10743         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10744         Remove gotos and target of gotos.
10745         (infpy_search_memory): Likewise.
10746
10747 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10748
10749         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10750         (hppa_gdbarch_init): Don't register deleted functions with
10751         gdbarch.
10752
10753 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10754
10755         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10756         (h8300_unwind_sp): Delete.
10757         (h8300_dummy_id): Delete.
10758         (h8300_gdbarch_init): Don't register deleted functions with
10759         gdbarch.
10760
10761 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10762
10763         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10764         (ft32_unwind_pc): Delete.
10765         (ft32_unwind_sp): Delete.
10766         (ft32_gdbarch_init): Don't register deleted functions with
10767         gdbarch.
10768
10769 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10770
10771         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10772         (frv_unwind_pc): Delete.
10773         (frv_unwind_sp): Delete.
10774         (frv_gdbarch_init): Don't register deleted functions with
10775         gdbarch.
10776
10777 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10778
10779         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10780         (riscv_unwind_pc): Delete.
10781         (riscv_unwind_sp): Delete.
10782         (riscv_gdbarch_init): Don't register deleted functions with
10783         gdbarch.
10784
10785 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10786
10787         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10788         (csky_unwind_pc): Delete.
10789         (csky_unwind_sp): Delete.
10790         (csky_gdbarch_init): Don't register deleted functions with
10791         gdbarch.
10792
10793 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10794
10795         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10796         (cris_unwind_pc): Delete.
10797         (cris_unwind_sp): Delete.
10798         (cris_gdbarch_init): Don't register deleted functions with
10799         gdbarch.
10800
10801 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10802
10803         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10804         (bfin_unwind_pc): Delete.
10805         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10806
10807 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10808
10809         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10810         (arm_unwind_pc): Delete.
10811         (arm_unwind_sp): Delete.
10812         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10813
10814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10815
10816         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10817         (arc_unwind_pc): Delete.
10818         (arc_unwind_sp): Delete.
10819         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10820
10821 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10822
10823         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10824         (alpha_unwind_pc): Delete.
10825         (alpha_gdbarch_init): Don't register deleted functions with
10826         gdbarch.
10827
10828 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10829
10830         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10831         (aarch64_unwind_pc): Delete.
10832         (aarch64_unwind_sp): Delete.
10833         (aarch64_gdbarch_init): Don't register deleted functions with
10834         gdbarch.
10835
10836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10837
10838         * gdbtypes.c (type_align): Don't consider static members when
10839         computing structure alignment.
10840
10841 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10842
10843         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10844         return 0 for other types.
10845         * arch-utils.c (default_type_align): Always return 0.
10846         * gdbarch.h: Regenerate.
10847         * gdbarch.sh (type_align): Extend comment.
10848         * gdbtypes.c (type_align): Add additional comments, always call
10849         gdbarch_type_align before applying the default rules.
10850         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10851         generic code will then apply a suitable default.
10852         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10853         types, return 0 for other types.
10854
10855 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10856
10857         * NEWS: Create a new section for the next release branch.
10858         Rename the section of the current branch, now that it has
10859         been cut.
10860
10861 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10862
10863         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10864         * version.in: Bump version to 8.3.50.DATE-git.
10865
10866 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10867
10868         * aix-thread.c (ptid_cmp): Remove unused variable.
10869         (get_signaled_thread): Likewise.
10870         (store_regs_user_thread): Likewise.
10871         (store_regs_kernel_thread): Likewise.
10872         (fetch_regs_kernel_thread): Remove shadowed variable.
10873
10874 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10875
10876         * features/riscv/32bit-cpu.xml: Add register numbers.
10877         * features/riscv/32bit-fpu.c: Regenerate.
10878         * features/riscv/32bit-fpu.xml: Add register numbers.
10879         * features/riscv/64bit-cpu.xml: Add register numbers.
10880         * features/riscv/64bit-fpu.c: Regenerate.
10881         * features/riscv/64bit-fpu.xml: Add register numbers.
10882
10883 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10884
10885         * NEWS: Mention two argument form of gdb.Value constructor.
10886         * python/py-value.c (convert_buffer_and_type_to_value): New
10887         function.
10888         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10889         Add support for handling an optional second argument.  Call
10890         convert_buffer_and_type_to_value as appropriate.
10891         * python/python-internal.h (Py_buffer_deleter): New struct.
10892         (Py_buffer_up): New typedef.
10893
10894 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10895
10896         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10897         instead of releasing ownership.
10898
10899 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10900
10901         * dwarf2read.c (open_and_init_dwp_file): Call
10902         elf_numsections instead of bfd_count_sections to initialize
10903         dwp_file->num_sections.
10904
10905 2019-02-25  Tom Tromey  <tromey@adacore.com>
10906
10907         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10908
10909 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10910
10911         * gcore.in: Add '--readnever' option when invoking GDB.
10912
10913 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10914
10915         * MAINTAINERS: Update my email address.
10916
10917 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10918
10919         * build-id.c (build_id_to_debug_bfd_1): New function.
10920         (build_id_to_debug_bfd): Look for separate debug file in
10921         sysroot.
10922
10923 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10924
10925         * gdbarch.sh: Update the copyright year range that is placed into
10926         generated files.
10927
10928 2019-02-22  Keith Seitz  <keiths@redhat.com>
10929
10930         PR symtab/23853
10931         * linespec.c (create_sals_line_offset): Search for the default
10932         symtab's filename instead of its fullname.
10933
10934 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10935
10936         * NEWS: Update style defaults.
10937
10938 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10939
10940         * main.c (captured_main_1): Disable styling in batch mode.
10941
10942 2019-02-20  Tom Tromey  <tom@tromey.com>
10943
10944         * symtab.c (symtab_symbol_info): Fix typos.
10945
10946 2019-02-20  Tom Tromey  <tromey@adacore.com>
10947
10948         * findcmd.c (_initialize_mem_search): Use upper case for
10949         metasyntactic variables.
10950
10951 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10952
10953         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10954         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10955
10956 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10957
10958         * top.h (source_file_name): Change to std::string.
10959         * top.c (source_file_name): Likewise.
10960         (command_line_input): Adjust.
10961         * cli/cli-script.c (script_from_file): Adjust.
10962
10963 2019-02-19  Tom Tromey  <tromey@adacore.com>
10964
10965         * ravenscar-thread.c
10966         (ravenscar_thread_target::update_thread_list): Don't call
10967         ada_build_task_list.
10968         * ada-lang.h (ada_build_task_list): Don't declare.
10969         * ada-tasks.c (struct ada_tasks_inferior_data)
10970         <task_list_valid_p>: Now bool.
10971         (read_known_tasks, ada_task_list_changed)
10972         (ada_tasks_invalidate_inferior_data): Update.
10973         (read_known_tasks_array): Return bool.
10974         (read_known_tasks_list): Likewise.
10975         (read_known_tasks): Return void.
10976         (ada_build_task_list): Now static.
10977
10978 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10979
10980         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10981         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10982
10983 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10984
10985         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10986         variant for ada_tasks_pspace_data_handle and
10987         ada_tasks_inferior_data_handle.
10988         (ada_tasks_pspace_data_cleanup): New function.
10989         (ada_tasks_inferior_data_cleanup): New function.
10990
10991 2019-02-17  Tom Tromey  <tom@tromey.com>
10992
10993         * macrotab.h (macro_source_fullname): Return a std::string.
10994         * macrotab.c (macro_include, check_for_redefinition)
10995         (macro_undef, macro_lookup_definition, foreach_macro)
10996         (foreach_macro_in_scope): Update.
10997         (macro_source_fullname): Return a std::string.
10998         * macrocmd.c (show_pp_source_pos): Update.
10999
11000 2019-02-17  Tom Tromey  <tom@tromey.com>
11001
11002         * macrocmd.c (show_pp_source_pos): Style the file names.
11003
11004 2019-02-17  Tom Tromey  <tom@tromey.com>
11005
11006         PR tui/24197:
11007         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11008
11009 2019-02-17  Tom Tromey  <tom@tromey.com>
11010
11011         * ada-lang.c (user_select_syms): Use filtered printing.
11012         * utils.c (wrap_style): New global.
11013         (desired_style): Remove.
11014         (emit_style_escape): Add stream parameter.
11015         (set_output_style, reset_terminal_style, prompt_for_continue):
11016         Update.
11017         (flush_wrap_buffer): Only flush gdb_stdout.
11018         (wrap_here): Set wrap_style.
11019         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11020         treat escape sequences as a character.  Change when wrap buffer is
11021         flushed.
11022         (fputs_styled): Do not set the output style when the default is
11023         requested.
11024         * ui-style.h (struct ui_file_style) <is_default>: New method.
11025         * source.c (print_source_lines_base): Emit escape sequences in one
11026         piece.
11027
11028 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11029
11030         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11031         integers and enumeration types.
11032
11033 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11034
11035         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11036         instead of lookup_symbol_in_language
11037         (do_exact_match): New function.
11038         (ada_get_symbol_name_matcher): Return do_exact_match when
11039         doing a verbatim match.
11040
11041 2019-02-15  Tom Tromey  <tromey@adacore.com>
11042
11043         * ravenscar-thread.c (ravenscar_thread_target::resume)
11044         (ravenscar_thread_target::wait): Special case wildcard requests.
11045
11046 2019-02-15  Tom Tromey  <tromey@adacore.com>
11047
11048         * ravenscar-thread.c (base_ptid): Remove.
11049         (struct ravenscar_thread_target) <close>: New method.
11050         <m_base_ptid>: New member.
11051         <update_inferior_ptid, active_task, task_is_currently_active,
11052         runtime_initialized>: Declare methods.
11053         <ravenscar_thread_target>: Add constructor.
11054         (ravenscar_thread_target::task_is_currently_active)
11055         (ravenscar_thread_target::update_inferior_ptid)
11056         (ravenscar_runtime_initialized): Rename.  Now methods.
11057         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11058         (ravenscar_thread_target::update_thread_list): Update.
11059         (ravenscar_thread_target::active_task): Now method.
11060         (ravenscar_thread_target::store_registers)
11061         (ravenscar_thread_target::prepare_to_store)
11062         (ravenscar_thread_target::prepare_to_store)
11063         (ravenscar_thread_target::mourn_inferior): Update.
11064         (ravenscar_inferior_created): Use "new" to create target.
11065         (ravenscar_thread_target::get_ada_task_ptid): Update.
11066         (_initialize_ravenscar): Don't initialize base_ptid.
11067         (ravenscar_ops): Remove global.
11068
11069 2019-02-15  Tom Tromey  <tromey@adacore.com>
11070
11071         * target.h (push_target): Declare new overload.
11072         * target.c (push_target): New overload, taking an rvalue reference.
11073         * remote.c (remote_target::open_1): Use push_target overload.
11074         * corelow.c (core_target_open): Use push_target overload.
11075
11076 2019-02-15  Tom Tromey  <tromey@adacore.com>
11077
11078         * ravenscar-thread.c (is_ravenscar_task)
11079         (ravenscar_task_is_currently_active): Return bool.
11080         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11081         (_initialize_ravenscar): Remove "(void)".
11082         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11083         Return bool.
11084
11085 2019-02-15  Tom Tromey  <tromey@adacore.com>
11086
11087         * ravenscar-thread.c (ravenscar_runtime_initializer)
11088         (has_ravenscar_runtime, get_running_thread_id)
11089         (ravenscar_thread_target::resume): Fix indentation.
11090
11091 2019-02-15  Tom Tromey  <tromey@adacore.com>
11092
11093         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11094         from ravenscar_arch_ops.
11095         (sparc_ravenscar_ops::fetch_registers)
11096         (sparc_ravenscar_ops::store_registers): Now methods.
11097         (sparc_ravenscar_prepare_to_store): Remove.
11098         (sparc_ravenscar_ops): Redefine.
11099         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11100         methods and destructor.  Remove members.
11101         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11102         (ravenscar_thread_target::store_registers)
11103         (ravenscar_thread_target::prepare_to_store): Update.
11104         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11105         Remove.
11106         (struct ppc_ravenscar_powerpc_ops): Derive from
11107         ravenscar_arch_ops.
11108         (ppc_ravenscar_powerpc_ops::fetch_registers)
11109         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11110         (ppc_ravenscar_powerpc_ops): Redefine.
11111         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11112         (ppc_ravenscar_e500_ops::fetch_registers)
11113         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11114         (ppc_ravenscar_e500_ops): Redefine.
11115         * aarch64-ravenscar-thread.c
11116         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11117         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11118         (aarch64_ravenscar_fetch_registers)
11119         (aarch64_ravenscar_store_registers): Now methods.
11120         (aarch64_ravenscar_ops): Redefine.
11121
11122 2019-02-15  Tom Tromey  <tromey@adacore.com>
11123
11124         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11125         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11126         (ravenscar_thread_target::stopped_by_watchpoint)
11127         (ravenscar_thread_target::stopped_data_address)
11128         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11129
11130 2019-02-15  Tom Tromey  <tromey@adacore.com>
11131
11132         * ravenscar-thread.c: Fix some typos.
11133
11134 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11135             Tom Tromey  <tromey@adacore.com>
11136
11137         * ada-lang.c (ada_exception_sal): Change addr_string to a
11138         std::string.
11139         (create_ada_exception_catchpoint): Update.
11140
11141 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11142             Tom Tromey  <tromey@adacore.com>
11143
11144         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11145         (bp_location_ops): Remove.
11146         (base_breakpoint_allocate_location): Update.
11147         (free_bp_location): Update.
11148         * ada-lang.c (class ada_catchpoint_location)
11149         <ada_catchpoint_location>: Remove ops parameter.
11150         (ada_catchpoint_location_dtor): Remove.
11151         (ada_catchpoint_location_ops): Remove.
11152         (allocate_location_exception): Update.
11153         * breakpoint.h (struct bp_location_ops): Remove.
11154         (class bp_location) <bp_location>: Remove bp_location_ops
11155         parameter.
11156         <~bp_location>: Add destructor.
11157         <ops>: Remove.
11158
11159 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11160             Pedro Alves  <palves@redhat.com>
11161
11162         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11163         'PATH_MAX'.
11164
11165 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11166             Samuel Thibault  <samuel.thibault@gnu.org>
11167             Thomas Schwinge  <thomas@codesourcery.com>
11168
11169         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11170         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11171
11172 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11173
11174         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11175         (check_empty): Use "const char *".
11176
11177         * gnu-nat.c (gnu_nat_target::detach): Instead of
11178         'detach_inferior (pid)' call
11179         'detach_inferior (find_inferior_pid (pid))'.
11180
11181         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11182         'nat/fork-inferior.o'.
11183         * gnu-nat.c: #include "nat/fork-inferior.h".
11184
11185         * gnu-nat.c (gnu_nat_target::detach): Instead of
11186         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11187         * gnu-nat.h: #include "inf-child.h".
11188         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11189         'i386_gnu_nat_target::fetch_registers'.
11190         (gnu_store_registers): Rename/move to
11191         'i386_gnu_nat_target::store_registers'.
11192
11193         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11194         * gnu-nat.h (mach_thread_info): New function.
11195         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11196
11197         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11198
11199 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11200
11201         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11202
11203 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11204
11205         * windows-nat.c (windows_add_thread): Add new parameter
11206         "main_thread_p" with default value set to false.  Update
11207         function documentation as well as all callers.
11208         (windows_delete_thread): Likewise.
11209         (fake_create_process): Update call to windows_add_thread.
11210         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11211         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11212         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11213         call to windows_delete_thread.
11214
11215 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11216
11217         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11218
11219 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11220
11221         * symfile.c (find_separate_debug_file): Use canonical path of
11222         sysroot with child_path instead of gdb_sysroot if it is valid.
11223
11224 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11225
11226         * symfile.c (find_separate_debug_file): Use child_path to
11227         determine if an object file is under a sysroot.
11228
11229 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11230
11231         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11232         unittests/child-path-selftests.c.
11233         * common/pathstuff.c (child_path): New function.
11234         * common/pathstuff.h (child_path): New prototype.
11235         * unittests/child-path-selftests.c: New file.
11236
11237 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11238
11239         * symfile.c (find_separate_debug_file): Look for separate debug
11240         files in debug directories under the sysroot.
11241
11242 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11243
11244         * symtab.h (struct minimal_symbol data_p): New const method.
11245         (struct minimal_symbol text_p): Likewise.
11246         * symtab.c (output_source_filename): Use file name style
11247         to print file name.
11248         (print_symbol_info): Likewise.
11249         (print_msymbol_info): Use address style to print addresses.
11250         Use function name style to print executable text symbols.
11251         (expand_symtab_containing_pc): Use data_p.
11252         (find_pc_sect_compunit_symtab): Likewise.
11253
11254 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11255
11256         * breakpoint.c (describe_other_breakpoints): Use address style
11257         to print addresses.
11258         (say_where): Likewise.
11259
11260 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11261
11262         * ada-typeprint.c (print_func_type): Print function name
11263         style to print function name.
11264         * c-typeprint.c (c_print_type_1): Likewise.
11265
11266 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11267
11268         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11269         for execve.
11270
11271 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11272
11273         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11274         type_stack.
11275
11276 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11277
11278         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11279         TYPE_CODE_REF types.
11280
11281 2019-02-08  Jim Wilson  <jimw@sifive.com>
11282
11283         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11284         (riscv_linux_fregset): New.
11285         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11286
11287 2019-02-07  Tom Tromey  <tom@tromey.com>
11288
11289         * thread.c (thread_cancel_execution_command): Update.
11290         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11291         methods.
11292         (struct thread_fsm_ops): Remove.
11293         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11294         (thread_fsm_should_stop, thread_fsm_return_value)
11295         (thread_fsm_set_finished, thread_fsm_finished_p)
11296         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11297         Don't declare.
11298         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11299         * infrun.c (clear_proceed_status_thread)
11300         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11301         (print_stop_event): Update.
11302         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11303         Add constructor.
11304         (step_command_fsm_ops): Remove.
11305         (new_step_command_fsm): Remove.
11306         (step_1): Update.
11307         (step_command_fsm::should_stop): Rename from
11308         step_command_fsm_should_stop.
11309         (step_command_fsm::clean_up): Rename from
11310         step_command_fsm_clean_up.
11311         (step_command_fsm::do_async_reply_reason): Rename from
11312         step_command_fsm_async_reply_reason.
11313         (struct until_next_fsm): Inherit from thread_fsm.  Add
11314         constructor.
11315         (until_next_fsm_ops): Remove.
11316         (new_until_next_fsm): Remove.
11317         (until_next_fsm::should_stop): Rename from
11318         until_next_fsm_should_stop.
11319         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11320         (until_next_fsm::do_async_reply_reason): Rename from
11321         until_next_fsm_async_reply_reason.
11322         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11323         constructor.  Change type of breakpoint.
11324         (finish_command_fsm_ops): Remove.
11325         (new_finish_command_fsm): Remove.
11326         (finish_command_fsm::should_stop): Rename from
11327         finish_command_fsm_should_stop.
11328         (finish_command_fsm::clean_up): Rename from
11329         finish_command_fsm_clean_up.
11330         (finish_command_fsm::return_value): Rename from
11331         finish_command_fsm_return_value.
11332         (finish_command_fsm::do_async_reply_reason): Rename from
11333         finish_command_fsm_async_reply_reason.
11334         (finish_command): Update.
11335         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11336         Add constructor.
11337         (call_thread_fsm_ops): Remove.
11338         (call_thread_fsm::call_thread_fsm): Rename from
11339         new_call_thread_fsm.
11340         (call_thread_fsm::should_stop): Rename from
11341         call_thread_fsm_should_stop.
11342         (call_thread_fsm::should_notify_stop): Rename from
11343         call_thread_fsm_should_notify_stop.
11344         (run_inferior_call, call_function_by_hand_dummy): Update.
11345         * cli/cli-interp.c (should_print_stop_to_console): Update.
11346         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11347         Add constructor.  Change type of location_breakpoint,
11348         caller_breakpoint.
11349         (until_break_fsm_ops): Remove.
11350         (new_until_break_fsm): Remove.
11351         (until_break_fsm::should_stop): Rename from
11352         until_break_fsm_should_stop.
11353         (until_break_fsm::clean_up): Rename from
11354         until_break_fsm_clean_up.
11355         (until_break_fsm::do_async_reply_reason): Rename from
11356         until_break_fsm_async_reply_reason.
11357         (until_break_command): Update.
11358         * thread-fsm.c: Remove.
11359         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11360
11361 2019-02-07  Tom Tromey  <tom@tromey.com>
11362
11363         * yy-remap.h: Add include guard.
11364         * xtensa-tdep.h: Add include guard.
11365         * xcoffread.h: Rename include guard.
11366         * varobj-iter.h: Add include guard.
11367         * tui/tui.h: Rename include guard.
11368         * tui/tui-winsource.h: Rename include guard.
11369         * tui/tui-wingeneral.h: Rename include guard.
11370         * tui/tui-windata.h: Rename include guard.
11371         * tui/tui-win.h: Rename include guard.
11372         * tui/tui-stack.h: Rename include guard.
11373         * tui/tui-source.h: Rename include guard.
11374         * tui/tui-regs.h: Rename include guard.
11375         * tui/tui-out.h: Rename include guard.
11376         * tui/tui-layout.h: Rename include guard.
11377         * tui/tui-io.h: Rename include guard.
11378         * tui/tui-hooks.h: Rename include guard.
11379         * tui/tui-file.h: Rename include guard.
11380         * tui/tui-disasm.h: Rename include guard.
11381         * tui/tui-data.h: Rename include guard.
11382         * tui/tui-command.h: Rename include guard.
11383         * tic6x-tdep.h: Add include guard.
11384         * target/waitstatus.h: Rename include guard.
11385         * target/wait.h: Rename include guard.
11386         * target/target.h: Rename include guard.
11387         * target/resume.h: Rename include guard.
11388         * target-float.h: Rename include guard.
11389         * stabsread.h: Add include guard.
11390         * rs6000-tdep.h: Add include guard.
11391         * riscv-fbsd-tdep.h: Add include guard.
11392         * regformats/regdef.h: Rename include guard.
11393         * record.h: Rename include guard.
11394         * python/python.h: Rename include guard.
11395         * python/python-internal.h: Rename include guard.
11396         * python/py-stopevent.h: Rename include guard.
11397         * python/py-ref.h: Rename include guard.
11398         * python/py-record.h: Rename include guard.
11399         * python/py-record-full.h: Rename include guard.
11400         * python/py-record-btrace.h: Rename include guard.
11401         * python/py-instruction.h: Rename include guard.
11402         * python/py-events.h: Rename include guard.
11403         * python/py-event.h: Rename include guard.
11404         * procfs.h: Add include guard.
11405         * proc-utils.h: Add include guard.
11406         * p-lang.h: Add include guard.
11407         * or1k-tdep.h: Rename include guard.
11408         * observable.h: Rename include guard.
11409         * nto-tdep.h: Rename include guard.
11410         * nat/x86-linux.h: Rename include guard.
11411         * nat/x86-linux-dregs.h: Rename include guard.
11412         * nat/x86-gcc-cpuid.h: Add include guard.
11413         * nat/x86-dregs.h: Rename include guard.
11414         * nat/x86-cpuid.h: Rename include guard.
11415         * nat/ppc-linux.h: Rename include guard.
11416         * nat/mips-linux-watch.h: Rename include guard.
11417         * nat/linux-waitpid.h: Rename include guard.
11418         * nat/linux-ptrace.h: Rename include guard.
11419         * nat/linux-procfs.h: Rename include guard.
11420         * nat/linux-osdata.h: Rename include guard.
11421         * nat/linux-nat.h: Rename include guard.
11422         * nat/linux-namespaces.h: Rename include guard.
11423         * nat/linux-btrace.h: Rename include guard.
11424         * nat/glibc_thread_db.h: Rename include guard.
11425         * nat/gdb_thread_db.h: Rename include guard.
11426         * nat/gdb_ptrace.h: Rename include guard.
11427         * nat/fork-inferior.h: Rename include guard.
11428         * nat/amd64-linux-siginfo.h: Rename include guard.
11429         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11430         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11431         * nat/aarch64-linux.h: Rename include guard.
11432         * nat/aarch64-linux-hw-point.h: Rename include guard.
11433         * mn10300-tdep.h: Add include guard.
11434         * mips-linux-tdep.h: Add include guard.
11435         * mi/mi-parse.h: Rename include guard.
11436         * mi/mi-out.h: Rename include guard.
11437         * mi/mi-main.h: Rename include guard.
11438         * mi/mi-interp.h: Rename include guard.
11439         * mi/mi-getopt.h: Rename include guard.
11440         * mi/mi-console.h: Rename include guard.
11441         * mi/mi-common.h: Rename include guard.
11442         * mi/mi-cmds.h: Rename include guard.
11443         * mi/mi-cmd-break.h: Rename include guard.
11444         * m2-lang.h: Add include guard.
11445         * location.h: Rename include guard.
11446         * linux-record.h: Rename include guard.
11447         * linux-nat.h: Add include guard.
11448         * linux-fork.h: Add include guard.
11449         * i386-darwin-tdep.h: Rename include guard.
11450         * hppa-linux-offsets.h: Add include guard.
11451         * guile/guile.h: Rename include guard.
11452         * guile/guile-internal.h: Rename include guard.
11453         * gnu-nat.h: Rename include guard.
11454         * gdb-stabs.h: Rename include guard.
11455         * frv-tdep.h: Add include guard.
11456         * f-lang.h: Add include guard.
11457         * event-loop.h: Add include guard.
11458         * darwin-nat.h: Rename include guard.
11459         * cp-abi.h: Rename include guard.
11460         * config/sparc/nm-sol2.h: Rename include guard.
11461         * config/nm-nto.h: Rename include guard.
11462         * config/nm-linux.h: Add include guard.
11463         * config/i386/nm-i386gnu.h: Rename include guard.
11464         * config/djgpp/nl_types.h: Rename include guard.
11465         * config/djgpp/langinfo.h: Rename include guard.
11466         * compile/gcc-cp-plugin.h: Add include guard.
11467         * compile/gcc-c-plugin.h: Add include guard.
11468         * compile/compile.h: Rename include guard.
11469         * compile/compile-object-run.h: Rename include guard.
11470         * compile/compile-object-load.h: Rename include guard.
11471         * compile/compile-internal.h: Rename include guard.
11472         * compile/compile-cplus.h: Rename include guard.
11473         * compile/compile-c.h: Rename include guard.
11474         * common/xml-utils.h: Rename include guard.
11475         * common/x86-xstate.h: Rename include guard.
11476         * common/version.h: Rename include guard.
11477         * common/vec.h: Rename include guard.
11478         * common/tdesc.h: Rename include guard.
11479         * common/selftest.h: Rename include guard.
11480         * common/scoped_restore.h: Rename include guard.
11481         * common/scoped_mmap.h: Rename include guard.
11482         * common/scoped_fd.h: Rename include guard.
11483         * common/safe-iterator.h: Rename include guard.
11484         * common/run-time-clock.h: Rename include guard.
11485         * common/refcounted-object.h: Rename include guard.
11486         * common/queue.h: Rename include guard.
11487         * common/ptid.h: Rename include guard.
11488         * common/print-utils.h: Rename include guard.
11489         * common/preprocessor.h: Rename include guard.
11490         * common/pathstuff.h: Rename include guard.
11491         * common/observable.h: Rename include guard.
11492         * common/netstuff.h: Rename include guard.
11493         * common/job-control.h: Rename include guard.
11494         * common/host-defs.h: Rename include guard.
11495         * common/gdb_wait.h: Rename include guard.
11496         * common/gdb_vecs.h: Rename include guard.
11497         * common/gdb_unlinker.h: Rename include guard.
11498         * common/gdb_unique_ptr.h: Rename include guard.
11499         * common/gdb_tilde_expand.h: Rename include guard.
11500         * common/gdb_sys_time.h: Rename include guard.
11501         * common/gdb_string_view.h: Rename include guard.
11502         * common/gdb_splay_tree.h: Rename include guard.
11503         * common/gdb_setjmp.h: Rename include guard.
11504         * common/gdb_ref_ptr.h: Rename include guard.
11505         * common/gdb_optional.h: Rename include guard.
11506         * common/gdb_locale.h: Rename include guard.
11507         * common/gdb_assert.h: Rename include guard.
11508         * common/filtered-iterator.h: Rename include guard.
11509         * common/filestuff.h: Rename include guard.
11510         * common/fileio.h: Rename include guard.
11511         * common/environ.h: Rename include guard.
11512         * common/common-utils.h: Rename include guard.
11513         * common/common-types.h: Rename include guard.
11514         * common/common-regcache.h: Rename include guard.
11515         * common/common-inferior.h: Rename include guard.
11516         * common/common-gdbthread.h: Rename include guard.
11517         * common/common-exceptions.h: Rename include guard.
11518         * common/common-defs.h: Rename include guard.
11519         * common/common-debug.h: Rename include guard.
11520         * common/cleanups.h: Rename include guard.
11521         * common/buffer.h: Rename include guard.
11522         * common/btrace-common.h: Rename include guard.
11523         * common/break-common.h: Rename include guard.
11524         * cli/cli-utils.h: Rename include guard.
11525         * cli/cli-style.h: Rename include guard.
11526         * cli/cli-setshow.h: Rename include guard.
11527         * cli/cli-script.h: Rename include guard.
11528         * cli/cli-interp.h: Rename include guard.
11529         * cli/cli-decode.h: Rename include guard.
11530         * cli/cli-cmds.h: Rename include guard.
11531         * charset-list.h: Add include guard.
11532         * buildsym-legacy.h: Rename include guard.
11533         * bfin-tdep.h: Add include guard.
11534         * ax.h: Rename include guard.
11535         * arm-linux-tdep.h: Add include guard.
11536         * arm-fbsd-tdep.h: Add include guard.
11537         * arch/xtensa.h: Rename include guard.
11538         * arch/tic6x.h: Add include guard.
11539         * arch/i386.h: Add include guard.
11540         * arch/arm.h: Rename include guard.
11541         * arch/arm-linux.h: Rename include guard.
11542         * arch/arm-get-next-pcs.h: Rename include guard.
11543         * arch/amd64.h: Add include guard.
11544         * arch/aarch64-insn.h: Rename include guard.
11545         * arch-utils.h: Rename include guard.
11546         * annotate.h: Add include guard.
11547         * amd64-darwin-tdep.h: Rename include guard.
11548         * aarch64-linux-tdep.h: Add include guard.
11549         * aarch64-fbsd-tdep.h: Add include guard.
11550         * aarch32-linux-nat.h: Add include guard.
11551
11552 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11553
11554         * macrotab.c (macro_define_internal): New function that
11555         factorizes macro_define_object_internal and macro_define_function
11556         code.
11557         (macro_define_object_internal): Use macro_define_internal.
11558         (macro_define_function): Likewise.
11559
11560 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11561
11562         * macrocmd.c (extract_identifier): Return
11563         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11564         callers.
11565
11566 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11567
11568         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11569
11570 2019-02-05  Tom Tromey  <tom@tromey.com>
11571
11572         * target.c (target_stack::unpush): Move assertion earlier.
11573
11574 2019-01-30  Tom Tromey  <tom@tromey.com>
11575
11576         PR python/23615:
11577         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11578         (gdbpy_parse_and_eval): Likewise.
11579         * python/python-internal.h (gdbpy_allow_threads): New class.
11580
11581 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11582
11583         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11584         (aarch64_fbsd_fpregmap): Move earlier.
11585         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11586         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11587         instead of individual calls to trad_frame_set_reg_addr.
11588         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11589         earlier.
11590         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11591         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11592         instead of individual calls to trad_frame_set_reg_addr.
11593
11594 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11595
11596         * CONTRIBUTE: Replace contribution list with wiki link.
11597
11598 2019-01-25  Tom Tromey  <tom@tromey.com>
11599
11600         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11601
11602 2019-01-25  Tom Tromey  <tom@tromey.com>
11603
11604         * xtensa-linux-nat.c: Fix common/ includes.
11605         * xml-support.h: Fix common/ includes.
11606         * xml-support.c: Fix common/ includes.
11607         * x86-linux-nat.c: Fix common/ includes.
11608         * windows-nat.c: Fix common/ includes.
11609         * varobj.h: Fix common/ includes.
11610         * varobj.c: Fix common/ includes.
11611         * value.c: Fix common/ includes.
11612         * valops.c: Fix common/ includes.
11613         * utils.c: Fix common/ includes.
11614         * unittests/xml-utils-selftests.c: Fix common/ includes.
11615         * unittests/utils-selftests.c: Fix common/ includes.
11616         * unittests/unpack-selftests.c: Fix common/ includes.
11617         * unittests/tracepoint-selftests.c: Fix common/ includes.
11618         * unittests/style-selftests.c: Fix common/ includes.
11619         * unittests/string_view-selftests.c: Fix common/ includes.
11620         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11621         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11622         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11623         * unittests/rsp-low-selftests.c: Fix common/ includes.
11624         * unittests/parse-connection-spec-selftests.c: Fix common/
11625         includes.
11626         * unittests/optional-selftests.c: Fix common/ includes.
11627         * unittests/offset-type-selftests.c: Fix common/ includes.
11628         * unittests/observable-selftests.c: Fix common/ includes.
11629         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11630         * unittests/memrange-selftests.c: Fix common/ includes.
11631         * unittests/memory-map-selftests.c: Fix common/ includes.
11632         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11633         * unittests/function-view-selftests.c: Fix common/ includes.
11634         * unittests/environ-selftests.c: Fix common/ includes.
11635         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11636         * unittests/common-utils-selftests.c: Fix common/ includes.
11637         * unittests/cli-utils-selftests.c: Fix common/ includes.
11638         * unittests/array-view-selftests.c: Fix common/ includes.
11639         * ui-file.c: Fix common/ includes.
11640         * tui/tui-io.c: Fix common/ includes.
11641         * tracepoint.h: Fix common/ includes.
11642         * tracepoint.c: Fix common/ includes.
11643         * tracefile-tfile.c: Fix common/ includes.
11644         * top.h: Fix common/ includes.
11645         * top.c: Fix common/ includes.
11646         * thread.c: Fix common/ includes.
11647         * target/waitstatus.h: Fix common/ includes.
11648         * target/waitstatus.c: Fix common/ includes.
11649         * target.h: Fix common/ includes.
11650         * target.c: Fix common/ includes.
11651         * target-memory.c: Fix common/ includes.
11652         * target-descriptions.c: Fix common/ includes.
11653         * symtab.h: Fix common/ includes.
11654         * symfile.c: Fix common/ includes.
11655         * stap-probe.c: Fix common/ includes.
11656         * spu-linux-nat.c: Fix common/ includes.
11657         * sparc-nat.c: Fix common/ includes.
11658         * source.c: Fix common/ includes.
11659         * solib.c: Fix common/ includes.
11660         * solib-target.c: Fix common/ includes.
11661         * ser-unix.c: Fix common/ includes.
11662         * ser-tcp.c: Fix common/ includes.
11663         * ser-pipe.c: Fix common/ includes.
11664         * ser-base.c: Fix common/ includes.
11665         * selftest-arch.c: Fix common/ includes.
11666         * s12z-tdep.c: Fix common/ includes.
11667         * rust-exp.y: Fix common/ includes.
11668         * rs6000-aix-tdep.c: Fix common/ includes.
11669         * riscv-tdep.c: Fix common/ includes.
11670         * remote.c: Fix common/ includes.
11671         * remote-notif.h: Fix common/ includes.
11672         * remote-fileio.h: Fix common/ includes.
11673         * remote-fileio.c: Fix common/ includes.
11674         * regcache.h: Fix common/ includes.
11675         * regcache.c: Fix common/ includes.
11676         * record-btrace.c: Fix common/ includes.
11677         * python/python.c: Fix common/ includes.
11678         * python/py-type.c: Fix common/ includes.
11679         * python/py-inferior.c: Fix common/ includes.
11680         * progspace.h: Fix common/ includes.
11681         * producer.c: Fix common/ includes.
11682         * procfs.c: Fix common/ includes.
11683         * proc-api.c: Fix common/ includes.
11684         * printcmd.c: Fix common/ includes.
11685         * ppc-linux-nat.c: Fix common/ includes.
11686         * parser-defs.h: Fix common/ includes.
11687         * osdata.c: Fix common/ includes.
11688         * obsd-nat.c: Fix common/ includes.
11689         * nat/x86-linux.c: Fix common/ includes.
11690         * nat/x86-linux-dregs.c: Fix common/ includes.
11691         * nat/x86-dregs.h: Fix common/ includes.
11692         * nat/x86-dregs.c: Fix common/ includes.
11693         * nat/ppc-linux.c: Fix common/ includes.
11694         * nat/mips-linux-watch.h: Fix common/ includes.
11695         * nat/mips-linux-watch.c: Fix common/ includes.
11696         * nat/linux-waitpid.c: Fix common/ includes.
11697         * nat/linux-ptrace.h: Fix common/ includes.
11698         * nat/linux-ptrace.c: Fix common/ includes.
11699         * nat/linux-procfs.c: Fix common/ includes.
11700         * nat/linux-personality.c: Fix common/ includes.
11701         * nat/linux-osdata.c: Fix common/ includes.
11702         * nat/linux-namespaces.c: Fix common/ includes.
11703         * nat/linux-btrace.h: Fix common/ includes.
11704         * nat/linux-btrace.c: Fix common/ includes.
11705         * nat/fork-inferior.c: Fix common/ includes.
11706         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11707         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11708         * nat/aarch64-linux.c: Fix common/ includes.
11709         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11710         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11711         * namespace.h: Fix common/ includes.
11712         * mips-linux-tdep.c: Fix common/ includes.
11713         * minsyms.c: Fix common/ includes.
11714         * mi/mi-parse.h: Fix common/ includes.
11715         * mi/mi-main.c: Fix common/ includes.
11716         * mi/mi-cmd-env.c: Fix common/ includes.
11717         * memrange.h: Fix common/ includes.
11718         * memattr.c: Fix common/ includes.
11719         * maint.h: Fix common/ includes.
11720         * maint.c: Fix common/ includes.
11721         * main.c: Fix common/ includes.
11722         * machoread.c: Fix common/ includes.
11723         * location.c: Fix common/ includes.
11724         * linux-thread-db.c: Fix common/ includes.
11725         * linux-nat.c: Fix common/ includes.
11726         * linux-fork.c: Fix common/ includes.
11727         * inline-frame.c: Fix common/ includes.
11728         * infrun.c: Fix common/ includes.
11729         * inflow.c: Fix common/ includes.
11730         * inferior.h: Fix common/ includes.
11731         * inferior.c: Fix common/ includes.
11732         * infcmd.c: Fix common/ includes.
11733         * inf-ptrace.c: Fix common/ includes.
11734         * inf-child.c: Fix common/ includes.
11735         * ia64-linux-nat.c: Fix common/ includes.
11736         * i387-tdep.c: Fix common/ includes.
11737         * i386-tdep.c: Fix common/ includes.
11738         * i386-linux-tdep.c: Fix common/ includes.
11739         * i386-linux-nat.c: Fix common/ includes.
11740         * i386-go32-tdep.c: Fix common/ includes.
11741         * i386-fbsd-tdep.c: Fix common/ includes.
11742         * i386-fbsd-nat.c: Fix common/ includes.
11743         * guile/scm-type.c: Fix common/ includes.
11744         * guile/guile.c: Fix common/ includes.
11745         * go32-nat.c: Fix common/ includes.
11746         * gnu-nat.c: Fix common/ includes.
11747         * gdbthread.h: Fix common/ includes.
11748         * gdbarch-selftests.c: Fix common/ includes.
11749         * gdb_usleep.c: Fix common/ includes.
11750         * gdb_select.h: Fix common/ includes.
11751         * gdb_bfd.c: Fix common/ includes.
11752         * gcore.c: Fix common/ includes.
11753         * fork-child.c: Fix common/ includes.
11754         * findvar.c: Fix common/ includes.
11755         * fbsd-nat.c: Fix common/ includes.
11756         * event-top.c: Fix common/ includes.
11757         * event-loop.c: Fix common/ includes.
11758         * dwarf2read.c: Fix common/ includes.
11759         * dwarf2loc.c: Fix common/ includes.
11760         * dwarf2-frame.c: Fix common/ includes.
11761         * dwarf-index-cache.c: Fix common/ includes.
11762         * dtrace-probe.c: Fix common/ includes.
11763         * disasm-selftests.c: Fix common/ includes.
11764         * defs.h: Fix common/ includes.
11765         * csky-tdep.c: Fix common/ includes.
11766         * cp-valprint.c: Fix common/ includes.
11767         * cp-support.h: Fix common/ includes.
11768         * cp-support.c: Fix common/ includes.
11769         * corelow.c: Fix common/ includes.
11770         * completer.h: Fix common/ includes.
11771         * completer.c: Fix common/ includes.
11772         * compile/compile.c: Fix common/ includes.
11773         * compile/compile-loc2c.c: Fix common/ includes.
11774         * compile/compile-cplus-types.c: Fix common/ includes.
11775         * compile/compile-cplus-symbols.c: Fix common/ includes.
11776         * command.h: Fix common/ includes.
11777         * cli/cli-dump.c: Fix common/ includes.
11778         * cli/cli-cmds.c: Fix common/ includes.
11779         * charset.c: Fix common/ includes.
11780         * build-id.c: Fix common/ includes.
11781         * btrace.h: Fix common/ includes.
11782         * btrace.c: Fix common/ includes.
11783         * breakpoint.h: Fix common/ includes.
11784         * breakpoint.c: Fix common/ includes.
11785         * ax.h:
11786         (enum agent_op): Fix common/ includes.
11787         * ax-general.c (struct aop_map): Fix common/ includes.
11788         * ax-gdb.c: Fix common/ includes.
11789         * auxv.c: Fix common/ includes.
11790         * auto-load.c: Fix common/ includes.
11791         * arm-tdep.c: Fix common/ includes.
11792         * arch/riscv.c: Fix common/ includes.
11793         * arch/ppc-linux-common.c: Fix common/ includes.
11794         * arch/i386.c: Fix common/ includes.
11795         * arch/arm.c: Fix common/ includes.
11796         * arch/arm-linux.c: Fix common/ includes.
11797         * arch/arm-get-next-pcs.c: Fix common/ includes.
11798         * arch/amd64.c: Fix common/ includes.
11799         * arch/aarch64.c: Fix common/ includes.
11800         * arch/aarch64-insn.c: Fix common/ includes.
11801         * arch-utils.c: Fix common/ includes.
11802         * amd64-windows-tdep.c: Fix common/ includes.
11803         * amd64-tdep.c: Fix common/ includes.
11804         * amd64-sol2-tdep.c: Fix common/ includes.
11805         * amd64-obsd-tdep.c: Fix common/ includes.
11806         * amd64-nbsd-tdep.c: Fix common/ includes.
11807         * amd64-linux-tdep.c: Fix common/ includes.
11808         * amd64-linux-nat.c: Fix common/ includes.
11809         * amd64-fbsd-tdep.c: Fix common/ includes.
11810         * amd64-fbsd-nat.c: Fix common/ includes.
11811         * amd64-dicos-tdep.c: Fix common/ includes.
11812         * amd64-darwin-tdep.c: Fix common/ includes.
11813         * agent.c: Fix common/ includes.
11814         * ada-lang.h: Fix common/ includes.
11815         * ada-lang.c: Fix common/ includes.
11816         * aarch64-tdep.c: Fix common/ includes.
11817
11818 2019-01-25  Tom Tromey  <tom@tromey.com>
11819
11820         * common/create-version.sh: Use common/version.h.
11821
11822 2019-01-24  Pedro Alves  <palves@redhat.com>
11823
11824         * infrun.c (signal_stop, signal_print, signal_program)
11825         (signal_catch, signal_pass): Now arrays instead of pointers.
11826         (update_signals_program_target, do_target_resume)
11827         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11828         * linux-nat.c (linux_nat_target::pass_signals)
11829         (linux_nat_target::create_inferior, linux_nat_target::attach):
11830         Adjust.
11831         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11832         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11833         * procfs.c (procfs_target::pass_signals): Adjust.
11834         * record-full.c (record_full_target::resume): Adjust.
11835         * remote.c (remote_target::pass_signals)
11836         (remote_target::program_signals): Adjust.
11837         * target-debug.h (target_debug_print_signals): Now takes a
11838         gdb::array_view as parameter.  Adjust.
11839         * target.h (target_ops) <pass_signals, program_signals>: Replace
11840         pointer and length parameters with gdb::array_view.
11841         (target_pass_signals, target_program_signals): Likewise.
11842         * target-delegates.c: Regenerate.
11843
11844 2019-01-24  Pedro Alves  <palves@redhat.com>
11845
11846         * common/forward-scope-exit.h
11847         (forward_scope_exit::forward_scope_exit): Pass arguments to
11848         m_bind_function directly, instead of creating a std::bind and
11849         copying that.
11850
11851 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11852
11853         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11854         for static members.
11855         (pass_in_v_vfp_candidate): Likewise.
11856
11857 2019-01-23  Tom Tromey  <tom@tromey.com>
11858             Pedro Alves  <palves@redhat.com>
11859
11860         * regcache.c (class regcache_invalidator): Remove.
11861         (regcache::raw_write): Use make_scope_exit.
11862
11863 2019-01-23  Tom Tromey  <tom@tromey.com>
11864
11865         * ui-out.h (class ui_out_emit_type): Update comment.
11866
11867 2019-01-23  Tom Tromey  <tom@tromey.com>
11868
11869         * infrun.c (fetch_inferior_event): Update comment.
11870
11871 2019-01-23  Tom Tromey  <tom@tromey.com>
11872             Pedro Alves  <palves@redhat.com>
11873
11874         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11875         parameter.
11876         (fetch_inferior_event): Use SCOPE_EXIT.
11877
11878
11879 2019-01-23  Tom Tromey  <tom@tromey.com>
11880             Pedro Alves  <palves@redhat.com>
11881
11882         * infrun.c (disable_thread_events): Delete.
11883         (stop_all_threads): Use SCOPE_EXIT.
11884
11885 2019-01-23  Tom Tromey  <tom@tromey.com>
11886             Pedro Alves  <palves@redhat.com>
11887
11888         * symfile.c: Include forward-scope-exit.h.
11889         (clear_symtab_users_cleanup): Replace forward declaration with
11890         a FORWARD_SCOPE_EXIT.
11891         (syms_from_objfile_1): Use the forward_scope_exit and
11892         gdb::optional instead of cleanup_function.
11893         (reread_symbols): Use the forward_scope_exit instead of
11894         cleanup_function.
11895         (clear_symtab_users_cleanup): Remove function.
11896
11897 2019-01-23  Tom Tromey  <tom@tromey.com>
11898             Pedro Alves  <palves@redhat.com>
11899
11900         * linux-nat.c: Include scope-exit.h.
11901         (cleanup_target_stop): Remove.
11902         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11903         SCOPE_EXIT.
11904
11905 2019-01-23  Tom Tromey  <tom@tromey.com>
11906             Pedro Alves  <palves@redhat.com>
11907
11908         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11909         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11910
11911 2019-01-23  Tom Tromey  <tom@tromey.com>
11912             Andrew Burgess  <andrew.burgess@embecosm.com>
11913             Pedro Alves  <palves@redhat.com>
11914
11915         * infrun.c (fetch_inferior_event): Use scope_exit.
11916         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11917         * top.c (execute_command): Use scope_exit.
11918         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11919         * utils.c (do_bpstat_clear_actions_cleanup)
11920         (make_bpstat_clear_actions_cleanup): Remove.
11921
11922 2019-01-23  Tom Tromey  <tom@tromey.com>
11923             Pedro Alves  <palves@redhat.com>
11924
11925         * infrun.c: Include "common/scope-exit.h"
11926         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11927         (wait_for_inferior): Use SCOPE_EXIT.
11928         (fetch_inferior_event): Use scope_exit.
11929
11930 2019-01-23  Tom Tromey  <tom@tromey.com>
11931             Pedro Alves  <palves@redhat.com>
11932
11933         * breakpoint.c (create_breakpoint): Remove cleanup.
11934
11935 2019-01-23  Tom Tromey  <tom@tromey.com>
11936             Andrew Burgess  <andrew.burgess@embecosm.com>
11937             Pedro Alves  <palves@redhat.com>
11938
11939 2019-01-23  Pedro Alves  <palves@redhat.com>
11940
11941         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11942
11943 2019-01-23  Pedro Alves  <palves@redhat.com>
11944             Andrew Burgess  <andrew.burgess@embecosm.com>
11945
11946         * gdbthread.h: Include "common/forward-scope-exit.h".
11947         (scoped_finish_thread_state): Redefine custom class in terms of
11948         forward_scope_exit.
11949
11950 2019-01-23  Pedro Alves  <palves@redhat.com>
11951             Andrew Burgess  <andrew.burgess@embecosm.com>
11952
11953         * common/forward-scope-exit.h: New file.
11954
11955 2019-01-23  Pedro Alves  <palves@redhat.com>
11956             Andrew Burgess  <andrew.burgess@embecosm.com>
11957             Tom Tromey  <tom@tromey.com>
11958
11959         * common/scope-exit.h: New file.
11960
11961 2019-01-23  Pedro Alves  <palves@redhat.com>
11962
11963         * common/preprocessor.h (ESC): Rename to ...
11964         (ESC_PARENS): ... this.
11965         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11966         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11967
11968 2019-01-23  Tom Tromey  <tom@tromey.com>
11969
11970         * language.h (class scoped_switch_to_sym_language_if_auto):
11971         Initialize m_lang in both cases.
11972
11973 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11974
11975         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11976         with XCNEW.
11977
11978 2019-01-22  Tom Tromey  <tom@tromey.com>
11979
11980         * corelow.c: Do not include sys/file.h.
11981
11982 2019-01-22  Tom Tromey  <tom@tromey.com>
11983
11984         * tui/tui-wingeneral.h: Include gdb_curses.h.
11985
11986 2019-01-22  Tom Tromey  <tom@tromey.com>
11987
11988         * source-cache.h (class source_cache) <get_source_lines,
11989         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11990
11991 2019-01-22  Tom Tromey  <tom@tromey.com>
11992
11993         * remote-fileio.h (struct remote_target): Declare.
11994
11995 2019-01-22  Tom Tromey  <tom@tromey.com>
11996
11997         * python/py-arch.c: Do not include py-ref.h.
11998         * python/py-bpevent.c: Do not include py-ref.h.
11999         * python/py-cmd.c: Do not include py-ref.h.
12000         * python/py-continueevent.c: Do not include py-ref.h.
12001         * python/py-event.h: Do not include py-ref.h.
12002         * python/py-evtregistry.c: Do not include py-ref.h.
12003         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12004         * python/py-frame.c: Do not include py-ref.h.
12005         * python/py-framefilter.c: Do not include py-ref.h.
12006         * python/py-function.c: Do not include py-ref.h.
12007         * python/py-infevents.c: Do not include py-ref.h.
12008         * python/py-linetable.c: Do not include py-ref.h.
12009         * python/py-objfile.c: Do not include py-ref.h.
12010         * python/py-param.c: Do not include py-ref.h.
12011         * python/py-prettyprint.c: Do not include py-ref.h.
12012         * python/py-progspace.c: Do not include py-ref.h.
12013         * python/py-symbol.c: Do not include py-ref.h.
12014         * python/py-symtab.c: Do not include py-ref.h.
12015         * python/py-type.c: Do not include py-ref.h.
12016         * python/py-unwind.c: Do not include py-ref.h.
12017         * python/py-utils.c: Do not include py-ref.h.
12018         * python/py-value.c: Do not include py-ref.h.
12019         * python/py-varobj.c: Do not include py-ref.h.
12020         * python/py-xmethods.c: Do not include py-ref.h.
12021         * python/python.c: Do not include py-ref.h.
12022         * varobj.c: Do not include py-ref.h.
12023
12024 2019-01-22  Tom Tromey  <tom@tromey.com>
12025
12026         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12027         keyword for bcache.
12028
12029 2019-01-22  Tom Tromey  <tom@tromey.com>
12030
12031         * compile/compile-cplus-types.c: Remove a comment by #include.
12032
12033 2019-01-22  Tom Tromey  <tom@tromey.com>
12034
12035         * compile/gcc-c-plugin.h: Include compile-internal.h.
12036
12037 2019-01-22  Tom Tromey  <tom@tromey.com>
12038
12039         * stabsread.c (EXTERN): Do not define.
12040         (symnum, next_symbol_text_func, processing_gcc_compilation)
12041         (within_function, global_sym_chain, global_stabs)
12042         (previous_stab_code, this_object_header_files)
12043         (n_this_object_header_files)
12044         (n_allocated_this_object_header_files): Define.
12045         * stabsread.h (EXTERN): Never define.  Use "extern".
12046
12047 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12048
12049         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12050         history_value.
12051
12052 2019-01-21  Tom Tromey  <tom@tromey.com>
12053
12054         * ui-out.c: Fix includes.
12055         * tui/tui-source.c: Fix includes.
12056         * target.c: Fix includes.
12057         * remote.c: Fix includes.
12058         * regcache.c: Fix includes.
12059         * python/py-block.c: Fix includes.
12060         * printcmd.c: Fix includes.
12061         * or1k-tdep.c: Fix includes.
12062         * mi/mi-main.c: Fix includes.
12063         * m32r-tdep.c: Fix includes.
12064         * csky-tdep.c: Fix includes.
12065         * compile/compile-cplus-types.c: Fix includes.
12066         * cli/cli-interp.c: Fix includes.
12067
12068 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12069
12070         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12071         for padding.
12072
12073 2019-01-16  Tom Tromey  <tom@tromey.com>
12074
12075         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12076         earlier.
12077         (struct objfile) <msymbols_range>: Move from top level.
12078         <msymbols>: New method.
12079         (class objfile_msymbols): Remove.
12080         * symtab.c (default_collect_symbol_completion_matches_break_on):
12081         Update.
12082         * symmisc.c (dump_msymbols): Update.
12083         * stabsread.c (scan_file_globals): Update.
12084         * objc-lang.c (info_selectors_command, info_classes_command)
12085         (find_methods): Update.
12086         * minsyms.c (find_solib_trampoline_target): Update.
12087         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12088         * coffread.c (coff_symfile_read): Update.
12089         * ada-lang.c (ada_lookup_simple_minsym)
12090         (ada_collect_symbol_completion_matches): Update.
12091
12092 2019-01-16  Tom Tromey  <tom@tromey.com>
12093
12094         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12095         type.  Remove no-argument constructor.
12096         <iterator::operator++>: Simplify.
12097         <begin>: Update.
12098         <end>: Use minimal_symbol_count.
12099
12100 2019-01-16  Tom Tromey  <tom@tromey.com>
12101
12102         * objfiles.h (struct objfile) <psymtabs>: New method.
12103         (class objfile_psymtabs): Remove.
12104         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12105         typedef.
12106         <range>: New method.
12107         (require_partial_symbols): Change return type.
12108         * psymtab.c (require_partial_symbols)
12109         (psym_expand_symtabs_matching): Update.
12110         * mdebugread.c (parse_partial_symbols): Update.
12111         * dbxread.c (dbx_end_psymtab): Update.
12112
12113 2019-01-15  Tom Tromey  <tom@tromey.com>
12114
12115         * symtab.c (lookup_objfile_from_block)
12116         (lookup_symbol_in_objfile_symtabs)
12117         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12118         (find_line_symtab, info_sources_command)
12119         (default_collect_symbol_completion_matches_break_on)
12120         (make_source_files_completion_list): Update.
12121         * symmisc.c (print_objfile_statistics, dump_objfile)
12122         (maintenance_print_symbols, maintenance_info_symtabs)
12123         (maintenance_check_symtabs, maintenance_info_line_tables):
12124         Update.
12125         * source.c (select_source_symtab)
12126         (forget_cached_source_info_for_objfile): Update.
12127         * objfiles.h (class objfile_compunits): Remove.
12128         (struct objfile) <compunits_range>: New typedef.
12129         (compunits): New method.
12130         * objfiles.c (objfile_relocate1): Update.
12131         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12132         * maint.c (count_symtabs_and_blocks): Update.
12133         * linespec.c (iterate_over_all_matching_symtabs): Update.
12134         * cp-support.c (add_symbol_overload_list_qualified): Update.
12135         * coffread.c (coff_symtab_read): Update.
12136         * ada-lang.c (add_nonlocal_symbols)
12137         (ada_collect_symbol_completion_matches)
12138         (ada_add_global_exceptions): Update.
12139
12140 2019-01-15  Tom Tromey  <tom@tromey.com>
12141
12142         * progspace.h (program_space) <objfiles_safe_range>: New
12143         typedef.
12144         <objfiles_safe>: New method.
12145         * objfiles.h (class all_objfiles_safe): Remove.
12146         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12147         * jit.c (jit_inferior_exit_hook): Update.
12148
12149 2019-01-17  Tom Tromey  <tom@tromey.com>
12150
12151         * progspace.h (program_space) <objfiles_range>: New typedef.
12152         <objfiles>: New method.
12153         <objfiles_head>: Rename from objfiles.
12154         (object_files): Update.
12155         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12156         * guile/scm-pretty-print.c
12157         (ppscm_find_pretty_printer_from_objfiles): Update.
12158         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12159         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12160         Update.
12161         * python/py-progspace.c (pspy_get_objfiles): Update.
12162         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12163         Update.
12164         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12165         (objfpy_lookup_objfile_by_build_id): Update.
12166         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12167         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12168         Update.
12169         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12170         (expand_symtab_containing_pc, lookup_objfile_from_block)
12171         (lookup_static_symbol, basic_lookup_transparent_type)
12172         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12173         (find_line_symtab, info_sources_command)
12174         (default_collect_symbol_completion_matches_break_on)
12175         (make_source_files_completion_list, find_main_name): Update.
12176         * symmisc.c (print_symbol_bcache_statistics)
12177         (print_objfile_statistics, maintenance_print_symbols)
12178         (maintenance_print_msymbols, maintenance_print_objfiles)
12179         (maintenance_info_symtabs, maintenance_check_symtabs)
12180         (maintenance_expand_symtabs, maintenance_info_line_tables):
12181         Update.
12182         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12183         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12184         (map_overlay_command, unmap_overlay_command)
12185         (simple_overlay_update, expand_symtabs_matching)
12186         (map_symbol_filenames): Update.
12187         * symfile-debug.c (set_debug_symfile): Update.
12188         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12189         Update.
12190         * source.c (select_source_symtab, forget_cached_source_info):
12191         Update.
12192         * solib.c (solib_read_symbols): Update.
12193         * solib-spu.c (append_ocl_sos): Update.
12194         * psymtab.c (maintenance_print_psymbols)
12195         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12196         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12197         * printcmd.c (info_symbol_command): Update.
12198         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12199         Update.
12200         * objfiles.h (class all_objfiles): Remove.
12201         * objfiles.c (have_partial_symbols, have_full_symbols)
12202         (have_minimal_symbols, qsort_cmp, update_section_map)
12203         (shared_objfile_contains_address_p)
12204         (default_iterate_over_objfiles_in_search_order): Update.
12205         * objc-lang.c (info_selectors_command, info_classes_command)
12206         (find_methods): Update.
12207         * minsyms.c (find_solib_trampoline_target): Update.
12208         * maint.c (maintenance_info_sections)
12209         (maintenance_translate_address, count_symtabs_and_blocks):
12210         Update.
12211         * main.c (captured_main_1): Update.
12212         * linux-thread-db.c (try_thread_db_load_from_pdir)
12213         (has_libpthread): Update.
12214         * linespec.c (iterate_over_all_matching_symtabs)
12215         (search_minsyms_for_name): Update.
12216         * jit.c (jit_find_objf_with_entry_addr): Update.
12217         * hppa-tdep.c (find_unwind_entry)
12218         (hppa_lookup_stub_minimal_symbol): Update.
12219         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12220         Update.
12221         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12222         (elf_gnu_ifunc_resolve_by_got): Update.
12223         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12224         * dwarf-index-write.c (save_gdb_index_command): Update.
12225         * cp-support.c (add_symbol_overload_list_qualified): Update.
12226         * breakpoint.c (create_overlay_event_breakpoint)
12227         (create_longjmp_master_breakpoint)
12228         (create_std_terminate_master_breakpoint)
12229         (create_exception_master_breakpoint): Update.
12230         * blockframe.c (find_pc_partial_function): Update.
12231         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12232         (ada_collect_symbol_completion_matches)
12233         (ada_add_global_exceptions): Update.
12234
12235 2019-01-17  Tom Tromey  <tom@tromey.com>
12236
12237         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12238         declare VEC.
12239         (solib_target_parse_libraries): Change return type.
12240         (library_list_start_segment, library_list_start_section)
12241         (library_list_end_library, library_list_start_library); Update.
12242         (solib_target_free_library_list): Remove.
12243         (solib_target_parse_libraries): Remove cleanup.  Change return
12244         type.
12245         (solib_target_current_sos): Update.
12246
12247 2019-01-17  Tom Tromey  <tromey@bapiya>
12248
12249         * valprint.c: Replace "the the" with "the".
12250         * symtab.c: Replace "the the" with "the".
12251         * solib.c: Replace "the the" with "the".
12252         * solib-dsbt.c: Replace "the the" with "the".
12253         * linespec.c: Replace "the the" with "the".
12254         * dwarf2loc.h: Replace "the the" with "the".
12255         * amd64-windows-tdep.c: Replace "the the" with "the".
12256         * aarch64-tdep.c: Replace "the the" with "the".
12257
12258 2019-01-16  Keith Seitz  <keiths@redhat.com>
12259
12260         PR gdb/23773
12261         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12262         <builder>: Rename to ..
12263         <m_builder>: ... this and make private.
12264         (dwarf2_cu::get_builder): New method.  Change all users of
12265         `builder' to use this method.
12266         (dwarf2_start_symtab): Move to ...
12267         (dwarf2_cu::start_symtab): ... here.  Update all callers
12268         (setup_type_unit_groups): Move to ...
12269         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12270         callers.
12271         (dwarf2_cu::reset_builder): New method.
12272         (process_full_compunit, process_full_type_unit): Use
12273         dwarf2_cu::reset_builder.
12274         (follow_die_offset): Record the ancestor CU if it is different
12275         from the followed DIE's CU.
12276         (follow_die_sig_1): Likewise.
12277
12278 2019-01-15  Tom Tromey  <tom@tromey.com>
12279
12280         * remote.c (class remote_state) <buf>: Now a char_vector.
12281         <buf_size>: Remove.
12282         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12283         parameter.
12284         (remote_target::getpkt_or_notif_sane_1)
12285         (remote_target::getpkt_sane)
12286         (remote_target::getpkt_or_notif_sane): Likewise.
12287         (class remote_target) <putpkt>: New overload.
12288         (remote_target::read_frame): Change type of "buf_p".  Remove
12289         sizeof_p parameter.
12290         (packet_ok): New overload.
12291         (packet_check_result): New overload.
12292         Update all uses.
12293
12294 2019-01-14  Tom Tromey  <tom@tromey.com>
12295
12296         * remote-notif.c (handle_notification, remote_notif_ack)
12297         (remote_notif_parse): Make "buf" const.
12298         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12299         const.
12300         (remote_notif_parse, remote_notif_ack, handle_notification):
12301         Likewise.
12302         * remote.c (remote_notif_stop_parse): Make "buf" const.
12303         (remote_target::remote_parse_stop_reply): Make "buf" const.
12304         (remote_notif_stop_ack): Make "buf" const.
12305
12306 2019-01-14  Tom Tromey  <tom@tromey.com>
12307
12308         * remote.c (remote_console_output): Make parameter const.
12309
12310 2019-01-14  Tom Tromey  <tom@tromey.com>
12311
12312         * target-debug.h (target_debug_print_signals): Constify.
12313         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12314         * procfs.c (procfs_target::pass_signals): Update.
12315         * linux-nat.c (linux_nat_target::pass_signals): Update.
12316         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12317         * target-delegates.c: Rebuild.
12318         * remote.c (remote_target::program_signals): Update.
12319         (remote_target::pass_signals): Update.
12320         * target.c (target_pass_signals): Constify argument.
12321         (target_program_signals): Likewise.
12322         * target.h (struct target_ops) <pass_signals, program_signals>:
12323         Constify argument.
12324         (target_pass_signals, target_program_signals): Constify argument.
12325
12326 2019-01-14  Tom Tromey  <tom@tromey.com>
12327
12328         PR tui/28819:
12329         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12330
12331 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12332
12333         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12334         field.
12335         * rs6000-tdep.c: Include reggroups.h.
12336         (IS_V_ALIAS_PSEUDOREG): Define.
12337         (rs6000_register_name): Return names for the "vX" aliases.
12338         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12339         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12340         aliases.  Call default_register_reggroup_p for all other
12341         pseudo-registers.
12342         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12343         New functions.
12344         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12345         Handle "vX" aliases.
12346         (v_alias_pseudo_register_collect): New function.
12347         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12348         (rs6000_gdbarch_init): Initialize "vX" aliases as
12349         pseudo-registers.  Restore registration of
12350         rs6000_pseudo_register_reggroup_p with
12351         set_tdesc_pseudo_register_reggroup_p.
12352
12353 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12354
12355         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12356         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12357         set_gdbarch_num_pseudo_regs.
12358
12359 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12360
12361         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12362         Remove arg prefixname, add do_set and do_show.
12363         Add member functions set_list and show_list.
12364         * cli/cli-style.c (class cli_style_option): Update accordingly.
12365         (style_set_list): Move to file scope.
12366         (style_show_list): Likewise.
12367         (set_style): Call help_list.
12368         (show_style): Call cmd_show_list.
12369         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12370         Update to use the new macro.
12371
12372 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12373
12374         * ada-lang.c (_initialize_ada_language): Expand the help text
12375         for the "catch exception" command.
12376
12377 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12378
12379         * symtab.c (matching_obj_sections): Initialize obj,
12380         declare it closer to its usage.
12381
12382 2019-01-10  Tom Tromey  <tom@tromey.com>
12383
12384         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12385         (basic_inf_threads_range): Remove.
12386         (inf_threads_range, inf_non_exited_threads_range)
12387         (safe_inf_threads_range): Use next_adapter.
12388
12389 2019-01-10  Keith Seitz  <keiths@redhat.com>
12390
12391         PR gdb/23712
12392         PR symtab/23010
12393         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12394         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12395
12396 2019-01-10  Keith Seitz  <keiths@redhat.com>
12397
12398         PR gdb/23712
12399         PR symtab/23010
12400         * dictionary.c (pending_to_vector): Remove.
12401         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12402         Remove _1 suffix, replacing functions of the same name.  Update
12403         all callers.
12404         (dict_create_hashed, dict_create_hashed_expandable)
12405         (dict_create_linear, dict_create_linear_expandable, dict_free)
12406         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12407         Make functions static.
12408
12409 2019-01-10  Keith Seitz  <keiths@redhat.com>
12410
12411         PR gdb/23712
12412         PR symtab/23010
12413         * dictionary.h (struct dictionary): Replace declaration with
12414         multidictionary.
12415         (dict_create_hashed, dict_create_hashed_expandable)
12416         (dict_create_linear, dict_create_linear_expandable)
12417         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12418         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12419         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12420         taking multidictionary argument.
12421         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12422         * block.h (struct block) <dict>: Change to multidictionary
12423         and rename `multidict'.
12424         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12425         symmisc.c: Update all dictionary references to multidictionary.
12426
12427 2019-01-10  Keith Seitz  <keiths@redhat.com>
12428
12429         PR gdb/23712
12430         PR symtab/23010
12431         * dictionary.c: Include unordered_map.
12432         (pending_to_vector): New function.
12433         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12434         Rewrite the non-"_1" functions to take vector instead
12435         of linked list.
12436         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12437         "new" _1 versions of the same name.
12438         (multidictionary): Define.
12439         (std::hash<enum language): New definition.
12440         (collate_pending_symbols_by_language, mdict_create_hashed)
12441         (mdict_create_hashed_expandable, mdict_create_linear)
12442         (mdict_create_linear_expandable, mdict_free)
12443         (find_language_dictionary, create_new_language_dictionary)
12444         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12445         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12446         (mdict_size, mdict_empty): New functions.
12447         * dictionary.h (mdict_iterator): Define.
12448
12449 2019-01-10  Pedro Alves  <palves@redhat.com>
12450
12451         * breakpoint.c (read_uploaded_action)
12452         (create_tracepoint_from_upload): Adjust to use
12453         gdb::unique_xmalloc_ptr.
12454         * ctf.c (ctf_write_uploaded_tp):
12455         (SET_ARRAY_FIELD): Use emplace_back.
12456         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12457         * tracefile-tfile.c (tfile_write_uploaded_tp):
12458         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12459         gdb::unique_xmalloc_ptr.
12460         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12461         at_string, cond_string, cmd_strings>: Replace char pointers
12462         with gdb::unique_xmalloc_ptr.
12463
12464 2019-01-10  Pedro Alves  <palves@redhat.com>
12465
12466         * solib-target.c (library_list_start_library): Don't xstrdup name.
12467
12468 2019-01-10  Pedro Alves  <palves@redhat.com>
12469
12470         * mdebugread.c (parse_partial_symbols): Use
12471         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12472
12473 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12474
12475         * linux-fork.c (scoped_switch_fork_info)
12476         <~scoped_switch_fork_info>: Fix incorrect variable name.
12477
12478 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12479
12480         * linux-fork.c (scoped_switch_fork_info)
12481         <scoped_switch_fork_info>: Make explicit.
12482         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12483
12484 2019-01-10  Tom Tromey  <tom@tromey.com>
12485
12486         * objfiles.h (objfile::reset_psymtabs): Update.
12487         * objfiles.c (objfile::objfile): Update.
12488         * psymtab.h (psymtab_storage::obstack): Update.
12489         (psymtab_storage::m_obstack): Use gdb::optional.
12490         (class psymtab_storage): Update comment.  Remove objfile
12491         parameter.
12492         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12493
12494 2019-01-10  Tom Tromey  <tom@tromey.com>
12495
12496         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12497         <free_psymtabs>: Now private.
12498         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12499         (allocate_psymtab): Use new method.
12500
12501 2019-01-10  Tom Tromey  <tom@tromey.com>
12502
12503         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12504         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12505         * mdebugread.c (parse_partial_symbols): Use
12506         allocate_dependencies.
12507         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12508         allocate_dependencies.
12509         (process_psymtab_comp_unit_reader)
12510         (build_type_psymtab_dependencies): Likewise.
12511         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12512
12513 2019-01-10  Tom Tromey  <tom@tromey.com>
12514
12515         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12516         PSYMBOL_SET_LANGUAGE.
12517         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12518
12519 2019-01-10  Tom Tromey  <tom@tromey.com>
12520
12521         * psymtab.h (psymtab_storage::obstack): New method.
12522         <m_obstack>: Rename from obstack; now private.
12523         * psymtab.c (psymtab_storage): Update.
12524         * dwarf2read.c (create_addrmap_from_index)
12525         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12526         Update.
12527
12528 2019-01-10  Tom Tromey  <tom@tromey.com>
12529
12530         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12531         * objfiles.h (objfile::reset_psymtabs): New method.
12532
12533 2019-01-10  Tom Tromey  <tom@tromey.com>
12534
12535         * symmisc.c (print_symbol_bcache_statistics): Update.
12536         (print_objfile_statistics): Update.
12537         * symfile.c (reread_symbols): Update.
12538         * psymtab.h (class psymtab_storage): New.
12539         * psymtab.c (psymtab_storage): New constructor.
12540         (~psymtab_storage): New destructor.
12541         (require_partial_symbols): Update.
12542         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12543         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12544         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12545         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12546         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12547         (start_psymtab_common, end_psymtab_common)
12548         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12549         (allocate_psymtab): Update.
12550         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12551         Update.
12552         (dump_psymtab_addrmap, maintenance_print_psymbols)
12553         (maintenance_check_psymtabs): Update.
12554         (class objfile_psymtabs): Move to objfiles.h.
12555         * psympriv.h (discard_psymtab): Now inline.
12556         (psymtab_discarder::psymtab_discarder): Update.
12557         (psymtab_discarder::~psymtab_discarder): Update.
12558         (ALL_OBJFILE_PSYMTABS): Rewrite.
12559         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12560         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12561         Remove fields.
12562         <partial_symtabs>: New field.
12563         (class objfile_psymtabs): Move from psymtab.h.  Update.
12564         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12565         psymbol_cache.
12566         (objfile::~objfile): Don't destroy psymbol_cache.
12567         * mdebugread.c (parse_partial_symbols): Update.
12568         * dwarf2read.c (create_addrmap_from_index)
12569         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12570         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12571         (add_partial_subprogram, dwarf2_ranges_read): Update.
12572         * dwarf-index-write.c (write_address_map)
12573         (write_one_signatured_type, recursively_write_psymbols)
12574         (class debug_names, class debug_names, write_psymtabs_to_index):
12575         Update.
12576
12577 2019-01-10  Tom Tromey  <tom@tromey.com>
12578
12579         * symtab.h (SYMBOL_SET_NAMES): Update.
12580         (symbol_set_names): Update.
12581         (MSYMBOL_SET_NAMES): Update.
12582         * symtab.c (symbol_set_names): Change argument to be an
12583         objfile_per_bfd_storage.
12584         * psymtab.c (add_psymbol_to_bcache): Update.
12585         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12586
12587 2019-01-10  Tom Tromey  <tom@tromey.com>
12588
12589         * symtab.c (create_demangled_names_hash): Change argument to be an
12590         objfile_per_bfd_storage.
12591         (symbol_set_names): Update.
12592
12593 2019-01-10  Tom Tromey  <tom@tromey.com>
12594
12595         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12596         init_psymbol_list.
12597         * psymtab.c (init_psymbol_list): Do nothing if already called.
12598         * psympriv.h (init_psymbol_list): Add comment.
12599         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12600         init_psymbol_list.
12601         * dbxread.c (dbx_symfile_read): Unconditionally call
12602         init_psymbol_list.
12603
12604 2019-01-10  Tom Tromey  <tom@tromey.com>
12605
12606         * xcoffread.c (scan_xcoff_symtab): Update.
12607         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12608         "where".
12609         * mdebugread.c (parse_partial_symbols)
12610         (handle_psymbol_enumerators): Update.
12611         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12612         * dbxread.c (read_dbx_symtab): Update.
12613         * psympriv.h (psymbol_placement): New enum.
12614         (add_psymbol_to_list): Update.
12615
12616 2019-01-10  Tom Tromey  <tom@tromey.com>
12617
12618         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12619         static_psymbols parameters.
12620         (scan_xcoff_symtab): Update.
12621         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12622         static_psymbols parameters.
12623         * psympriv.h (start_psymtab_common): Update.
12624         * mdebugread.c (parse_partial_symbols): Update.
12625         * dwarf2read.c (create_partial_symtab): Update.
12626         * dbxread.c (read_dbx_symtab): Update.
12627         (start_psymtab): Remove global_psymbols and static_psymbols
12628         parameters.
12629
12630 2019-01-10  Tom Tromey  <tom@tromey.com>
12631
12632         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12633         * psymtab.c (allocate_psymtab): Add comment.
12634         * psympriv.h (allocate_psymtab): Add comment.
12635         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12636         initializations.
12637         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12638
12639 2019-01-10  Tom Tromey  <tom@tromey.com>
12640
12641         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12642         Don't declare.
12643         * mipsread.c: Include mdebugread.h.
12644         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12645         Declare.
12646         * elfread.c: Include mdebugread.h.
12647
12648 2019-01-09  Tom Tromey  <tom@tromey.com>
12649
12650         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12651         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12652         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12653         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12654         (psym_lookup_symbol, psym_find_last_source_symtab)
12655         (psym_forget_cached_source_info, psym_print_stats)
12656         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12657         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12658         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12659         (psym_find_compunit_symtab_by_address)
12660         (maintenance_print_psymbols, maintenance_info_psymtabs)
12661         (maintenance_check_psymtabs): Use ranged for.
12662         * psymtab.h (class objfile_psymtabs): New.
12663         (require_partial_symbols): Return objfile_psymtabs.
12664         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12665
12666 2019-01-09  Tom Tromey  <tom@tromey.com>
12667
12668         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12669         (find_pc_mapped_section, list_overlays_command)
12670         (map_overlay_command, unmap_overlay_command)
12671         (simple_overlay_update): Use all_objfiles.
12672         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12673         * printcmd.c (info_symbol_command): Use all_objfiles.
12674         * objfiles.h (ALL_OBJSECTIONS): Remove.
12675         * maint.c (maintenance_translate_address): Use all_objfiles.
12676         * gcore.c (gcore_create_callback): Use all_objfiles.
12677         (objfile_find_memory_regions): Likewise.
12678
12679 2019-01-09  Tom Tromey  <tom@tromey.com>
12680
12681         * symtab.c (find_line_symtab, info_sources_command)
12682         (make_source_files_completion_list): Use objfile_compunits.
12683         * source.c (select_source_symtab): Use objfile_compunits.
12684         * objfiles.h (struct objfile): Update comment.
12685         (ALL_OBJFILES): Remove.
12686         (ALL_FILETABS): Remove.
12687         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12688         objfile_compunits.
12689
12690 2019-01-09  Tom Tromey  <tom@tromey.com>
12691
12692         * symmisc.c (print_objfile_statistics, dump_objfile)
12693         (maintenance_print_symbols): Use compunit_filetabs.
12694         * source.c (forget_cached_source_info_for_objfile): Use
12695         compunit_filetabs.
12696         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12697         (ALL_FILETABS): Use compunit_filetabs.
12698         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12699         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12700
12701 2019-01-09  Tom Tromey  <tom@tromey.com>
12702
12703         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12704         (compunit_filetabs): New.
12705         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12706         compunit_filetabs.
12707         (info_sources_command, make_source_files_completion_list): Remove
12708         declaration.
12709         * symmisc.c (print_objfile_statistics, dump_objfile)
12710         (maintenance_print_symbols): Remove declaration.
12711         (maintenance_info_symtabs): Use compunit_filetabs.
12712         (maintenance_info_line_tables): Likewise.
12713         * source.c (select_source_symtab): Change local variable name.
12714         (forget_cached_source_info_for_objfile): Remove declaration.
12715         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12716         * objfiles.c (objfile_relocate1): Remove declaration.
12717         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12718         declaration.
12719         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12720         * coffread.c (coff_symtab_read): Remove declaration.
12721         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12722         compunit_filetabs.
12723
12724 2019-01-09  Tom Tromey  <tom@tromey.com>
12725
12726         * symtab.c (lookup_objfile_from_block)
12727         (find_pc_sect_compunit_symtab, search_symbols)
12728         (default_collect_symbol_completion_matches_break_on): Use
12729         objfile_compunits.
12730         * objfiles.h (ALL_COMPUNITS): Remove.
12731         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12732         * cp-support.c (add_symbol_overload_list_qualified): Use
12733         objfile_compunits.
12734         * ada-lang.c (ada_collect_symbol_completion_matches)
12735         (ada_add_global_exceptions): Use objfile_compunits.
12736
12737 2019-01-09  Tom Tromey  <tom@tromey.com>
12738
12739         * source.c (select_source_symtab)
12740         (forget_cached_source_info_for_objfile): Remove declaration.
12741         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12742         declaration.
12743         * maint.c (count_symtabs_and_blocks): Remove declaration.
12744         * cp-support.c (add_symbol_overload_list_qualified): Remove
12745         declaration.
12746         * coffread.c (coff_symtab_read): Remove declaration.
12747         * symtab.c (lookup_symbol_in_objfile_symtabs)
12748         (basic_lookup_transparent_type_1): Use objfile_compunits.
12749         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12750         (info_sources_command, search_symbols)
12751         (default_collect_symbol_completion_matches_break_on)
12752         (make_source_files_completion_list): Remove declaration.
12753         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12754         (ada_collect_symbol_completion_matches)
12755         (ada_add_global_exceptions): Remove declaration.
12756         * linespec.c (iterate_over_all_matching_symtabs): Use
12757         objfile_compunits.
12758         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12759         (class objfile_compunits): New.
12760         (ALL_COMPUNITS): Use objfile_compunits.
12761         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12762         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12763         objfile_compunits.
12764         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12765
12766 2019-01-09  Tom Tromey  <tom@tromey.com>
12767
12768         * symtab.c (search_symbols)
12769         (default_collect_symbol_completion_matches_break_on): Use
12770         objfile_msymbols.
12771         * ada-lang.c (ada_lookup_simple_minsym)
12772         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12773         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12774         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12775         objfile_msymbols.
12776         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12777         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12778         * objc-lang.c (find_methods): Use objfile_msymbols.
12779         (info_selectors_command, info_classes_command): Likewise.
12780         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12781         * objfiles.h (class objfile_msymbols): New.
12782         (ALL_OBJFILE_MSYMBOLS): Remove.
12783         (ALL_MSYMBOLS): Remove.
12784
12785 2019-01-09  Tom Tromey  <tom@tromey.com>
12786
12787         * common/next-iterator.h (next_adapter): Add Iterator template
12788         parameter.
12789         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12790         (class all_objfiles_safe): New.
12791         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12792         * objfiles.c (put_objfile_before): Update comment.
12793         (add_separate_debug_objfile): Likewise.
12794         (free_all_objfiles): Use all_objfiles_safe.
12795         (objfile_purge_solibs): Likewise.
12796
12797 2019-01-09  Tom Tromey  <tom@tromey.com>
12798
12799         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12800         (expand_symtab_containing_pc, lookup_static_symbol)
12801         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12802         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12803         all_objfiles.
12804         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12805         * breakpoint.c (create_overlay_event_breakpoint)
12806         (create_longjmp_master_breakpoint)
12807         (create_std_terminate_master_breakpoint)
12808         (create_exception_master_breakpoint): Use all_objfiles.
12809         * linux-thread-db.c (try_thread_db_load_from_pdir)
12810         (has_libpthread): Use all_objfiles.
12811         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12812         * linespec.c (iterate_over_all_matching_symtabs)
12813         (search_minsyms_for_name): Use all_objfiles.
12814         * maint.c (maintenance_info_sections): Use all_objfiles.
12815         * main.c (captured_main_1): Use all_objfiles.
12816         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12817         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12818         * guile/scm-pretty-print.c
12819         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12820         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12821         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12822         (maintenance_print_msymbols): Use all_objfiles.
12823         * source.c (select_source_symtab): Use all_objfiles.
12824         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12825         * symfile.c (remove_symbol_file_command)
12826         (expand_symtabs_matching, map_symbol_filenames): Use
12827         all_objfiles.
12828         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12829         all_objfiles.
12830         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12831         * objc-lang.c (find_methods): Use all_objfiles.
12832         * objfiles.c (have_partial_symbols, have_full_symbols)
12833         (have_minimal_symbols, qsort_cmp)
12834         (default_iterate_over_objfiles_in_search_order): Use
12835         all_objfiles.
12836         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12837         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12838         (maintenance_check_psymtabs): Use all_objfiles.
12839         (ALL_PSYMTABS): Remove.
12840         * compile/compile-object-run.c (do_module_cleanup): Use
12841         all_objfiles.
12842         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12843         * cp-support.c (add_symbol_overload_list_qualified): Use
12844         all_objfiles.
12845         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12846         Use all_objfiles.
12847         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12848         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12849         all_objfiles.
12850         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12851         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12852         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12853         Uses all_objfiles.
12854         * solib.c (solib_read_symbols): Use all_objfiles
12855
12856 2019-01-09  Tom Tromey  <tom@tromey.com>
12857
12858         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12859         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12860         all_objfiles.
12861         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12862         * symmisc.c (print_symbol_bcache_statistics)
12863         (print_objfile_statistics, maintenance_print_objfiles)
12864         (maintenance_info_symtabs, maintenance_check_symtabs)
12865         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12866         all_objfiles.
12867         * source.c (forget_cached_source_info): Use all_objfiles.
12868         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12869         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12870         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12871         * objfiles.c (update_section_map): Use all_objfiles.
12872         (shared_objfile_contains_address_p): Likewise.
12873         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12874         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12875
12876 2019-01-09  Tom Tromey  <tom@tromey.com>
12877
12878         * common/next-iterator.h: New file.
12879         * objfiles.h (class all_objfiles): New.
12880         (struct objfile_iterator): New.
12881
12882 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12883
12884         * NEWS: Move the description of the changed "frame", "select-frame",
12885          and "info frame" commands to the Changed commands section.
12886
12887 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12888
12889         * gdbtypes.c (check_stub_method_group): Remove handling of old
12890         mangling schemes.
12891         * linespec.c (find_methods): Likewise.
12892         * stabsread.c (read_member_functions): Likewise.
12893         * valops.c (search_struct_method): Likewise.
12894         (value_struct_elt_for_reference): Likewise.
12895         * NEWS: Mention this change.
12896
12897 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12898
12899         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12900         print_source_lines.
12901         * source.c (print_source_lines_base): Update line number check.
12902         (print_source_lines): New function.
12903         (source_lines_range::source_lines_range): New function.
12904         * source.h (class source_lines_range): New class.
12905         (print_source_lines): New declaration.
12906
12907 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12908
12909         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12910
12911 2019-01-08  Tom Tromey  <tom@tromey.com>
12912             Simon Marchi  <simon.marchi@ericsson.com>
12913
12914         PR gdb/24060
12915         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12916         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12917         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12918         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12919         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12920         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12921
12922 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12923
12924         * source.c (select_source_symtab): Move header comment to
12925         declaration in source.h.
12926         (forget_cached_source_info_for_objfile): Likewise.
12927         (forget_cached_source_info): Likewise.
12928         (identify_source_line): Likewise.
12929         * source.h (identify_source_line): Move declaration from symtab.h
12930         and add comment from source.c
12931         (print_source_lines): Likewise.
12932         (forget_cached_source_info_for_objfile): Likewise.
12933         (forget_cached_source_info): Likewise.
12934         (select_source_symtab): Likewise.
12935         (enum print_source_lines_flag): Move definition from symtab.h.
12936         * symtab.h (identify_source_line): Move declaration to source.h.
12937         (print_source_lines): Likewise.
12938         (forget_cached_source_info_for_objfile): Likewise.
12939         (forget_cached_source_info): Likewise.
12940         (select_source_symtab): Likewise.
12941         (enum print_source_lines_flag): Move definition to source.h.
12942         * tui/tui-hooks.c: Add 'source.h' include.
12943
12944 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12945
12946         * source.c (print_source_lines_base): Handle requests to print
12947         reverse line number sequences, and guard against empty lines
12948         string.
12949
12950 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12951
12952         * source.c (print_source_lines_base): Fix skip of '\r' if next
12953         character is '\n'.
12954
12955 2019-01-06  Tom Tromey  <tom@tromey.com>
12956
12957         * c-exp.y (struct c_parse_state) <macro_original_text,
12958         expansion_obstack>: New member.
12959         (macro_original_text, expansion_obstack): Remove globals.
12960         (scan_macro_expansion, scanning_macro_expansion)
12961         (finished_macro_expansion): Update.
12962         (scan_macro_cleanup): Remove.
12963         (yylex, c_parse): Update.
12964
12965 2019-01-06  Tom Tromey  <tom@tromey.com>
12966
12967         * c-exp.y (struct c_parse_state) <strings>: New member.
12968         (operator_stoken): Update.
12969
12970 2019-01-06  Tom Tromey  <tom@tromey.com>
12971
12972         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12973         (union type_stack_elt) <typelist_val>: Now a pointer to
12974         std::vector.
12975         (type_stack_cleanup): Don't declare.
12976         (push_typelist): Update.
12977         * parse.c (pop_typelist): Return a std::vector.
12978         (push_typelist): Take a std::vector.
12979         (follow_types): Update.  Do not free args.
12980         (type_stack_cleanup): Remove.
12981         * c-exp.y (struct c_parse_state): New.
12982         (cpstate): New global.
12983         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12984         (nonempty_typelist): Update.
12985         (func_mod): Create a new vector.
12986         (c_parse): Create a c_parse_state.
12987         (check_parameter_typelist): Do not delete params.
12988         (function_method): Update.  Do not delete type_list.
12989
12990 2019-01-06  Tom Tromey  <tom@tromey.com>
12991
12992         PR gdb/28155:
12993         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12994         check_typedef.
12995         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12996         (print_return_value): Likewise.
12997
12998 2019-01-05  Tom Tromey  <tom@tromey.com>
12999
13000         * contrib/cleanup_check.py: Remove.
13001         * contrib/gcc-with-excheck: Remove.
13002         * contrib/exsummary.py: Remove.
13003         * contrib/excheck.py: Remove.
13004
13005 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13006
13007         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13008         NULL. Initialize tpprev to NULL instead of assigning it
13009         to NULL on the next statement.
13010         * windows-nat.c (windows_delete_thread): Remove check for
13011         main_thread_id before printing thread exit notifications.
13012         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13013         Remove thread ID check against main_thread_id.
13014         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13015         windows_delete_thread.
13016         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13017
13018 2019-01-04  Tom Tromey  <tom@tromey.com>
13019
13020         * compile/compile.c (_initialize_compile): Use upper case for
13021         metasyntactic variables.
13022         * symmisc.c (_initialize_symmisc): Use upper case for
13023         metasyntactic variables.
13024         * psymtab.c (_initialize_psymtab): Use upper case for
13025         metasyntactic variables.
13026         * demangle.c (demangle_command): Use upper case for metasyntactic
13027         variables.
13028         (_initialize_demangler): Likewise.
13029         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13030         variables.
13031
13032 2019-01-03  Tom Tromey  <tom@tromey.com>
13033
13034         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13035
13036 2019-01-03  Tom Tromey  <tom@tromey.com>
13037
13038         * python/py-symtab.c (salpy_str): Update.
13039         (struct salpy_sal_object) <symtab>: Now a PyObject.
13040         (salpy_dealloc): Update.
13041         (del_objfile_sal): Use gdbpy_ref.
13042
13043 2019-01-03  Tom Tromey  <tom@tromey.com>
13044
13045         * python/py-type.c (convert_field): Use new_reference.  Return
13046         gdbpy_ref.
13047         (make_fielditem): Return gdbpy_ref.
13048         (typy_fields): Update.
13049         (typy_getitem): Update.
13050         (field_name): Return gdbpy_ref.  Use new_reference.
13051         (typy_iterator_iternext): Update.
13052
13053 2019-01-03  Tom Tromey  <tom@tromey.com>
13054
13055         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13056
13057 2019-01-03  Tom Tromey  <tom@tromey.com>
13058
13059         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13060         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13061         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13062         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13063         (pspy_set_type_printers): Likewise.
13064         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13065         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13066         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13067         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13068         (objfpy_set_type_printers): Likewise.
13069
13070 2019-01-03  Tom Tromey  <tom@tromey.com>
13071
13072         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13073         (gdbpy_print_stack): Use gdbpy_err_fetch.
13074         * python/python-internal.h (class gdbpy_err_fetch): New class.
13075         (class gdbpy_enter) <m_error_type, m_error_value,
13076         m_error_traceback>: Remove.
13077         <m_error>: New member.
13078         (gdbpy_exception_to_string): Don't declare.
13079         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13080         * python/py-value.c (convert_value_from_python): Use
13081         gdbpy_err_fetch.
13082         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13083         gdbpy_exception_to_string.
13084         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13085         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13086         gdbpy_err_fetch.
13087
13088 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13089
13090         * linux-nat.c (delete_lwp_cleanup): Delete.
13091         (struct lwp_deleter): New struct.
13092         (lwp_info_up): New typedef.
13093         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13094         lwp_info_up.
13095
13096 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13097
13098         * linux-fork.c (class scoped_switch_fork_info): New class.
13099         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13100
13101 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13102
13103         * valops.c (find_overload_match): Remove use of null_cleanup, and
13104         calls to do_cleanups.
13105
13106 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13107
13108         * compile/compile-cplus-types.c
13109         (compile_cplus_instance::decl_name): Handle changes to
13110         cp_func_name.
13111         * cp-support.c (cp_func_name): Update header comment, update
13112         return type.
13113         * cp-support.h (cp_func_name): Update return type in declaration.
13114         * valops.c (find_overload_match): Move temp_func local to top
13115         level of function and change its type.  Use temp_func to hold and
13116         delete temporary string obtained from cp_func_name.
13117
13118 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13119
13120         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13121         gdb::char_vector, remove cleanup, and update uses of `msg`.
13122
13123 2019-01-03  Jim Wilson  <jimw@sifive.com>
13124
13125         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13126
13127 2019-01-02  Tom Tromey  <tom@tromey.com>
13128
13129         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13130         (tdesc_parse_xml): Remove cleanups.
13131         * target-descriptions.h (make_cleanup_free_target_description):
13132         Don't declare.
13133         (target_desc_deleter): New struct.
13134         (target_desc_up): New typedef.
13135         * target-descriptions.c (target_desc_deleter::operator()): Rename
13136         from free_target_description.
13137         (make_cleanup_free_target_description): Remove.
13138
13139 2019-01-02  Tom Tromey  <tom@tromey.com>
13140
13141         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13142         constructor, destructor.
13143         (linespec_parser): Remove typedef.
13144         (~linespec_parser): Rename from linespec_parser_delete.
13145         (linespec_lex_to_end, linespec_complete_label)
13146         (linespec_complete): Update.
13147         (decode_line_full): Remove cleanups.
13148         (decode_line_1): Update.
13149
13150 2019-01-02  Tom Tromey  <tom@tromey.com>
13151
13152         * python/python-internal.h (inferior_to_inferior_object): Change
13153         return type.
13154         * python/py-exitedevent.c (create_exited_event_object): Update.
13155         * python/py-inferior.c (inferior_to_inferior_object): Return
13156         gdbpy_ref.
13157         (python_new_inferior, python_inferior_deleted)
13158         (thread_to_thread_object, delete_thread_object)
13159         (build_inferior_list, gdbpy_selected_inferior): Update.
13160         * python/py-infthread.c (create_thread_object): Update.  Also fail
13161         if inferior_to_inferior_object fails.
13162
13163 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13164
13165         * inferior.h (class inferior) <displaced_step_state>: New field.
13166         * infrun.h (struct displaced_step_state): Move here from
13167         infrun.c.  Initialize fields, add constructor.
13168         <inf>: Remove field.
13169         <reset>: New method.
13170         * infrun.c (struct displaced_step_inferior_state): Move to
13171         infrun.h.
13172         (displaced_step_inferior_states): Remove.
13173         (get_displaced_stepping_state): Adust.
13174         (displaced_step_in_progress_any_inferior): Adjust.
13175         (displaced_step_in_progress_thread): Adjust.
13176         (displaced_step_in_progress): Adjust.
13177         (add_displaced_stepping_state): Remove.
13178         (get_displaced_step_closure_by_addr): Adjust.
13179         (remove_displaced_stepping_state): Remove.
13180         (infrun_inferior_exit): Call displaced_step_state.reset.
13181         (use_displaced_stepping): Don't check for NULL.
13182         (displaced_step_prepare_throw): Call
13183         get_displaced_stepping_state.
13184         (displaced_step_fixup): Don't check for NULL.
13185         (prepare_for_detach): Don't check for NULL.
13186
13187 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13188
13189         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13190          in case of call that did not complete.
13191
13192 2019-01-02  Andrey Utkin  <autkin@undo.io>
13193
13194         * symfile.c (find_separate_debug_file): Fix search of debug files for
13195         remote debuggee.
13196
13197 2019-01-02  Tom Tromey  <tom@tromey.com>
13198
13199         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13200         indentation.
13201         * python/py-frame.c (frapy_older): Remove cast.
13202         (frapy_newer): Likewise.
13203         * python/py-breakpoint.c (local_setattro): Remove cast.
13204         * python/py-arch.c (archpy_name): Remove local variable.
13205         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13206
13207 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13208
13209         * unittests/basic_string_view/element_access/char/empty.cc:
13210         Fix year range in copyright header.
13211
13212 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13213
13214         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13215         Delete.
13216         <operator==>: Update with for removed field.
13217         <hash>: Likewise.
13218         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13219         <isa_features>: ...this.
13220         <abi_features>: New field.
13221         (riscv_isa_flen): Update comment.
13222         (riscv_abi_xlen): New declaration.
13223         (riscv_abi_flen): New declaration.
13224         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13225         isa_features.
13226         (riscv_abi_xlen): New function.
13227         (riscv_isa_flen): Update to get answer from isa_features.
13228         (riscv_abi_flen): New function.
13229         (riscv_has_fp_abi): Update to get answer from abi_features.
13230         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13231         xlen and flen.
13232         (riscv_call_info) <xlen, flen>: Update comment.
13233         (riscv_call_arg_struct): Remove invalid assertions
13234         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13235         is removed.
13236         (riscv_gdbarch_init): Gather isa features and abi features
13237         separately, ensure both match on the gdbarch when reusing an old
13238         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13239         a target with 64-bit float hardware.
13240
13241 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13242
13243         * source.c (search_command_helper): Stop reverse search
13244         when line 1 has been searched.
13245
13246 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13247
13248         * record-full.c (record_full_base_target::close): Rewrite
13249         record_full_core_buf_list free logic.
13250
13251 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13252
13253         * break-catch-syscall.c (print_one_catch_syscall): xfree
13254         the last text.
13255
13256 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13257
13258         * top.c (print_gdb_version): Update Copyright year in version
13259         message.
13260
13261 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13262
13263         Update copyright year range in all GDB files.
13264
13265 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13266
13267         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13268
13269 For older changes see ChangeLog-2018.
13270 \f
13271 Local Variables:
13272 mode: change-log
13273 left-margin: 8
13274 fill-column: 74
13275 version-control: never
13276 coding: utf-8
13277 End:
13278