gdb/ChangeLog

   1 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * symtab.c (info_module_cmdlist): New variable.
   4         (info_module_command): New function.
   5         (search_module_symbols): New function.
   6         (info_module_subcommand): New function.
   7         (struct info_modules_var_func_options): New struct.
   8         (info_modules_var_func_options_defs): New variable.
   9         (make_info_modules_var_func_options_def_group): New function.
  10         (info_module_functions_command): New function.
  11         (info_module_variables_command): New function.
  12         (info_module_var_func_command_completer): New function.
  13         (_initialize_symtab): Register new 'info module functions' and
  14         'info module variables' commands.
  15         * symtab.h (typedef symbol_search_in_module): New typedef.
  16         (search_module_symbols): Declare new function.
  17         * NEWS: Mention new commands.
  18
  19 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  20
  21         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
  22         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
  23         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
  24         MODULES_DOMAIN.
  25         (scan_partial_symbols): Only create partial module symbols for non
  26         declarations.
  27         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
  28         and MODULES_DOMAIN.
  29         * symtab.c (search_domain_name): Likewise.
  30         (search_symbols): Likewise.
  31         (print_symbol_info): Likewise.
  32         (symtab_symbol_info): Likewise.
  33         (info_modules_command): New function.
  34         (_initialize_symtab): Register 'info modules' command.
  35         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
  36         * NEWS: Mention new 'info modules' command.
  37
  38 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  39
  40         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
  41         and $_gdb_maint_setting_str.
  42
  43 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  44
  45         * cli/cli-cmds.c (setting_cmd, value_from_setting)
  46         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
  47         (str_value_from_setting, gdb_setting_str_internal_fn)
  48         (gdb_maint_setting_str_internal_fn): New functions.
  49         (_initialize_cli_cmds): Define the new convenience functions.
  50         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
  51         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
  52
  53 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  54
  55         * agent.c (set_can_use_agent): When the setting is turned on,
  56         look up agent symbols if we don't have them yet.
  57         (agent_new_objfile): Don't look up agent symbols when the agent
  58         setting is off.
  59
  60 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  61
  62         * config.in: Regenerate.
  63
  64 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  65
  66         * configure: Regenerate.
  67         * configure.ac: Check for strerror_r.
  68         * gdbsupport/common-utils.h (safe_strerror): Change return value
  69         to const char * and document that this function is now threadsafe.
  70         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
  71         thread_local and call strerror_r, if available.
  72         * utils.c (perror_string): Update.
  73         (print_sys_errmsg): Update.
  74
  75 2019-10-31  Luis Machado  <luis.machado@linaro.org>
  76
  77         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
  78         objfile_key.
  79         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
  80         objfile to fetch per-bfd data.
  81         (arm_find_exidx_entry): Likewise.
  82
  83 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
  84
  85         * gdbsupport/agent.c (debug_agent): Change type to bool.
  86         (use_agent): Likewise.
  87         (all_agent_symbols_look_up): Likewise.
  88         (agent_loaded_p): Change return value to bool.
  89         (agent_look_up_symbols): Update.
  90         (agent_capability_check): Change return value to bool.
  91         * gdbsupport/agent.h (agent_loaded_p): Likewise.
  92         (debug_agent): Change type to bool.
  93         (use_agent): Likewise.
  94         (agent_capability_check): Change return value to bool.
  95
  96 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
  99         (build_minimal_symbol_hash_tables): Code to clear the table moved
 100         to clear_minimal_symbol_hash_tables.
 101         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 102         when needed.
 103
 104 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 105
 106         * infcmd.c: Remove includes.
 107         * infrun.c: Remove includes.
 108
 109 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 110
 111         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 112         (grow_vect): Remove declaration.
 113         (ada_type_of_array): Remove declaration.
 114         (ada_update_initial_language): Remove declaration.
 115         (ada_fold_name): Remove declaration.
 116         (ada_fill_in_ada_prototype): Remove declaration.
 117         (user_select_syms): Remove declaration.
 118         (get_selections): Remove declaration.
 119         (ada_tag_type): Remove declaration.
 120         (ada_value_tag): Remove declaration.
 121         (ada_is_others_clause): Remove declaration.
 122         (ada_in_variant): Remove declaration.
 123         (ada_value_struct_elt): Remove declaration.
 124         (ada_attribute_name): Remove declaration.
 125         (ada_system_address_type): Remove declaration.
 126         * ada-lang.c (ada_watch_location_expression): Make static.
 127         (GROW_VECT): Move here from ada-lang.h.
 128         (grow_vect): Make static.
 129         (ada_update_initial_language): Make static.
 130         (ada_fold_name): Make static.
 131         (ada_type_of_array): Make static.
 132         (encoded_ordered_before): Move up.
 133         (sort_choices): Move up.
 134         (print_signatures): Move up.
 135         (ada_print_symbol_signature): Move up.
 136         (get_selections): Move up and make static.
 137         (user_select_syms): Move up and make static.
 138         (ada_value_struct_elt): Move up and make static.
 139         (ada_tag_type): Make static.
 140         (ada_value_tag): Make static.
 141         (ada_is_others_clause): Make static.
 142         (ada_in_variant): Make static.
 143         (ada_attribute_name): Make static.
 144
 145 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 146
 147         * ada-lang.c: Remove includes.
 148         * ada-typeprint.c: Remove includes.
 149         * ada-valprint.c: Remove includes.
 150
 151 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 152
 153         * addrmap.c: Add static assertions of type size, moved from
 154         _initialize_addrmap.
 155         (_initialize_addrmap): Remove.
 156
 157 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 158
 159         * coffread.c (record_minimal_symbol): Update.
 160         (process_coff_symbol): Update.
 161         * dbxread.c (read_dbx_symtab): Update.
 162         * dwarf2read.c (add_partial_symbol): Update.
 163         (fixup_go_packaging): Update.
 164         (load_partial_dies): Update.
 165         (new_symbol): Update.
 166         * elfread.c (record_minimal_symbol): Change signature to use
 167         gdb::string_view instead of name+len.
 168         (elf_symtab_read): Update.
 169         (elf_rel_plt_read): Update.
 170         * mdebugread.c (parse_partial_symbols): Update.
 171         (handle_psymbol_enumerators): Update.
 172         (new_symbol): Update.
 173         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 174         to use gdb::string_view instead of name+len.
 175         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 176         * psympriv.h (add_psymbol_to_list): Likewise.
 177         * psymtab.c (add_psymbol_to_bcache): Likewise.
 178         (add_psymbol_to_list): Likewise.
 179         * stabsread.c (define_symbol): Update.
 180         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 181         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 182         (symbol_set_names): Likewise.
 183         * xcoffread.c (scan_xcoff_symtab): Update.
 184
 185 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 186
 187         * symtab.h (symbol_set_names): Document that copy_name must be
 188         set to true for non-nullterminated strings.
 189         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 190         linkage_name if the entry was not found and we need to demangle.
 191
 192 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 193
 194         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 195         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 196         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 197         * gdbsupport/gdb_binary_search.h: New file.
 198
 199 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 200
 201         * NEWS: Mention new --with-system-gdbinit-dir option.
 202         * config.in: Regenerate.
 203         * configure: Regenerate.
 204         * configure.ac: Add new option --with-system-gdbinit-dir.
 205         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 206         for a ".gdb" suffix.
 207         * main.c (get_init_files): Change system_gdbinit argument to
 208         a vector and return the files in SYSTEM_GDBINIT_DIR in
 209         addition to SYSTEM_GDBINIT.
 210         (captured_main_1): Update.
 211         (print_gdb_help): Update.
 212         * top.c (print_gdb_configuration): Also print the value of
 213         SYSTEM_GDBINIT_DIR.
 214
 215 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 216
 217         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 218         that takes gdb::string_view arguments.
 219
 220 2019-10-26  Tom de Vries  <tdevries@suse.de>
 221
 222         * aarch64-linux-tdep.c: Fix typos in comments.
 223         * aarch64-tdep.c: Same.
 224         * ada-lang.c: Same.
 225         * amd64-nat.c: Same.
 226         * arc-tdep.c: Same.
 227         * arch/aarch64-insn.c: Same.
 228         * block.c: Same.
 229         * breakpoint.h: Same.
 230         * btrace.h: Same.
 231         * c-varobj.c: Same.
 232         * cli/cli-decode.c: Same.
 233         * cli/cli-script.c: Same.
 234         * cli/cli-utils.h: Same.
 235         * coff-pe-read.c: Same.
 236         * coffread.c: Same.
 237         * compile/compile-cplus-symbols.c: Same.
 238         * compile/compile-object-run.c: Same.
 239         * completer.c: Same.
 240         * corelow.c: Same.
 241         * cp-support.c: Same.
 242         * demangle.c: Same.
 243         * dwarf-index-write.c: Same.
 244         * dwarf2-frame.c: Same.
 245         * dwarf2-frame.h: Same.
 246         * eval.c: Same.
 247         * frame-base.h: Same.
 248         * frame.h: Same.
 249         * gdbcmd.h: Same.
 250         * gdbtypes.h: Same.
 251         * gnu-nat.c: Same.
 252         * guile/scm-objfile.c: Same.
 253         * i386-tdep.c: Same.
 254         * i386-tdep.h: Same.
 255         * infcall.c: Same.
 256         * infcall.h: Same.
 257         * linux-nat.c: Same.
 258         * m68k-tdep.c: Same.
 259         * macroexp.c: Same.
 260         * memattr.c: Same.
 261         * mi/mi-cmd-disas.c: Same.
 262         * mi/mi-getopt.h: Same.
 263         * mi/mi-main.c: Same.
 264         * minsyms.c: Same.
 265         * nat/aarch64-sve-linux-sigcontext.h: Same.
 266         * objfiles.h: Same.
 267         * ppc-linux-nat.c: Same.
 268         * ppc-linux-tdep.c: Same.
 269         * ppc-tdep.h: Same.
 270         * progspace.h: Same.
 271         * prologue-value.h: Same.
 272         * python/py-evtregistry.c: Same.
 273         * python/py-instruction.h: Same.
 274         * record-btrace.c: Same.
 275         * record-full.c: Same.
 276         * remote.c: Same.
 277         * rs6000-tdep.c: Same.
 278         * ser-tcp.c: Same.
 279         * sol-thread.c: Same.
 280         * sparc-sol2-tdep.c: Same.
 281         * sparc64-tdep.c: Same.
 282         * stabsread.c: Same.
 283         * symfile.c: Same.
 284         * symtab.h: Same.
 285         * target.c: Same.
 286         * tracepoint.c: Same.
 287         * tui/tui-data.h: Same.
 288         * tui/tui-io.c: Same.
 289         * tui/tui-win.c: Same.
 290         * tui/tui.c: Same.
 291         * unittests/rsp-low-selftests.c: Same.
 292         * user-regs.h: Same.
 293         * utils.c: Same.
 294         * utils.h: Same.
 295         * valarith.c: Same.
 296         * valops.c: Same.
 297         * valprint.c: Same.
 298         * valprint.h: Same.
 299         * value.c: Same.
 300         * value.h: Same.
 301         * varobj.c: Same.
 302         * x86-nat.h: Same.
 303         * xtensa-tdep.c: Same.
 304
 305 2019-10-25  Ali Tamur <tamur@google.com>
 306
 307         * charset.c (find_charset_names): Reflect API change.
 308
 309 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 310
 311         * symtab.c (struct demangled_name_entry): Change demangled name
 312         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 313         part of the struct anymore.
 314         (symbol_set_names): No longer obstack allocate + copy the demangled
 315         name, just store the allocated name from bfd.
 316
 317 2019-10-25  Tom Tromey  <tromey@adacore.com>
 318
 319         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 320         (bsearch_cie_cmp, add_cie): Remove.
 321         (find_cie): Reimplement.
 322         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 323         (dwarf2_build_frame_info): Update.
 324
 325 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 326
 327         PR gdb/25126
 328         * symfile.c (reread_symbols): Call forget_cached_source_info to
 329         clear the stale source cache.
 330
 331 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 332
 333         * configure: Regenerate.
 334         * configure.ac: Remove code that sets python_has_threads.
 335
 336 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 337
 338         * config.in: Regenerate.
 339         * configure: Regenerate.
 340         * configure.ac: Remove the code that uses sed to get the python
 341         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 342
 343 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 346         error paths.
 347
 348 2019-10-23  Tom Tromey  <tom@tromey.com>
 349
 350         * arc-tdep.c: Remove ".." from include.
 351         * frv-tdep.c: Remove ".." from include.
 352         * lm32-tdep.c: Remove ".." from include.
 353         * microblaze-tdep.c: Remove ".." from include.
 354         * or1k-tdep.h: Remove ".." from include.
 355         * s12z-tdep.c: Remove ".." from include.
 356         * Makefile.in (OPCODES_CFLAGS): Add comment.
 357         (TOP_CFLAGS): New variable.
 358         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 359
 360 2019-10-23  Tom Tromey  <tom@tromey.com>
 361
 362         * Makefile.in (READLINE_DIR): Update.
 363
 364 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 365
 366         * infcall.c (call_function_by_hand_dummy): Fix the function
 367         comment.  And extract out a code section into...
 368         (reserve_stack_space): ...this new function.
 369
 370 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 371
 372         * infcall.c (value_arg_coerce): Remove an unused parameter.
 373         (call_function_by_hand_dummy): Update the call to
 374         'value_arg_coerce'.
 375
 376 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 377
 378         * infcall.c (call_function_by_hand_dummy): Refactor.
 379
 380 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 381
 382         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 383
 384 2019-10-23  Tom Tromey  <tom@tromey.com>
 385
 386         * configure: Rebuild.
 387         * configure.ac: Don't check for sigprocmask.
 388         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 389
 390 2019-10-23  Tom Tromey  <tom@tromey.com>
 391
 392         * configure: Rebuild.
 393         * acinclude.m4: Use m4_include, not sinclude.
 394
 395 2019-10-23  Tom de Vries  <tdevries@suse.de>
 396
 397         PR breakpoints/24687
 398         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 399
 400 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 401
 402         * symtab.c (struct demangled_name_entry) <language>: Change from
 403         bitfield to regular variable.
 404
 405 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 406
 407         * symtab.c (struct demangled_name_entry): Add a constructor.
 408         (free_demangled_name_entry): New function to call the destructor
 409         for demangled_name_entry.
 410         (create_demangled_names_hash): Pass free_demangled_name_entry to
 411         htab_create_alloc.
 412         (symbol_set_names): Call placement new for demangled_name_entry.
 413         * utils.c: No longer include xxhash.h here, now that fast_hash
 414         is inlined in the header.
 415         * utils.h: Instead, include it here.
 416
 417 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 418
 419         * Makefile.in: Link with libxxhash.
 420         * config.in: Regenerate.
 421         * configure: Regenerate.
 422         * configure.ac: Search for libxxhash.
 423         * utils.c (fast_hash): Use xxhash if present.
 424
 425 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 426
 427         * utils.h (fast_hash): New function.
 428         * symtab.c (hash_demangled_name_entry): Call new function
 429         fast_hash.
 430
 431 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 432
 433         * symtab.c (struct demangled_name_entry): Change type of mangled
 434         to gdb::string_view. Also adds a constructor that takes the
 435         mangled name.
 436         (hash_demangled_name_entry): Update.
 437         (eq_demangled_name_entry): Update.
 438         (free_demangled_name_entry): New function to call the destructor
 439         now that this is not a POD anymore.
 440         (create_demangled_names_hash): Pass free_demangled_name_entry to
 441         htab_create_alloc.
 442         (symbol_set_names): Update.
 443
 444 2019-10-21  Ali Tamur  <tamu@google.com>
 445
 446         * dwarf2read.c (dir_index): Change type.
 447         (file_name_index): Likewise.
 448         (line_header::include_dir_at): Change comment and implementation on
 449         whether it is DWARF 5.
 450         (line_header::is_valid_file_index): New function.
 451         (line_header::file_name_at): Change comment and implementation on
 452         whether it is DWARF 5.
 453         (line_header::file_names): Change to private field renamed as
 454         m_file_names and introduce a new accessor method.
 455         (line_header::file_names_size): New method.
 456         (line_header::include_dirs): Change to private field and rename as
 457         m_include_dirs.
 458         (dw2_get_file_names_reader): Define local var at a smaller scope and
 459         reflect API change.
 460         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 461         (process_structure_scope): Likewise.
 462         (line_header::add_include_dir): Change message and reflect renaming.
 463         (line_header::add_file_name): Likewise.
 464         (read_formatted_entries): Handle DW_FORM_data16.
 465         (dwarf_decode_line_header): Fix line header length calculation.
 466         (psymtab_include_file_name): Change comment and API.
 467         (lnp_state_machine::m_file): Update comment and reflect type change.
 468         (lnp_state_machine::record_line): Reflect type change.
 469         (dwarf_decode_lines): Reflect API change.
 470         (file_file_name): Likewise.
 471         (file_full_name): Likewise.
 472
 473 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 474
 475         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 476
 477 2019-10-21  Tom Tromey  <tom@tromey.com>
 478
 479         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 480
 481 2019-10-21  Tom Tromey  <tom@tromey.com>
 482
 483         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 484         NM_H.   Use AC_CONFIG_LINKS.
 485         * configure: Rebuild.
 486         * Makefile.in (NM_H): New variable.
 487         (generated_files): Add NM_H.  Remove gcore.
 488         (nm.h, stamp-nmh): New targets.
 489
 490 2019-10-20  Tom Tromey  <tom@tromey.com>
 491
 492         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 493         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 494         obsolete comment.
 495         (put_objfile_before): Now static.
 496
 497 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 498
 499         * gdbsupport/common-utils.h (startswith): Change return type to
 500         bool.
 501
 502 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 503
 504         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 505         * breakpoint.c (bp_locations_compare): Rename to...
 506         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 507         (update_global_location_list): Use std::sort instead of qsort.
 508         * buildsym.c (compare_line_numbers): Rename to...
 509         (lte_is_less_than): ...this, and change to std::sort semantics.
 510         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 511         instead of qsort.
 512         * disasm.c (compare_lines): Rename to...
 513         (line_is_less_than): ...this, and change to std::sort semantics.
 514         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 515         of qsort.
 516         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 517         (fde_is_less_than): ...this, and change to std::sort semantics.
 518         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 519         * mdebugread.c (compare_blocks):
 520         (block_is_less_than): ...this, and change to std::sort semantics.
 521         (sort_blocks): Call std::sort instead of qsort.
 522         * objfiles.c (qsort_cmp): Rename to...
 523         (sort_cmp): ...this, and change to std::sort semantics.
 524         (update_section_map): Call std::sort instead of qsort.
 525         * remote.c (compare_pnums): Remove.
 526         (map_regcache_remote_table): Call std::sort instead of qsort.
 527         * utils.c (compare_positive_ints): Remove.
 528         * utils.h (compare_positive_ints): Remove.
 529         * xcoffread.c (compare_lte): Remove.
 530         (arrange_linetable): Call std::sort instead of qsort.
 531
 532 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 533
 534         * symfile.c (init_entry_point_info): Fix typo.
 535         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 536
 537 2019-10-18  Tom de Vries  <tdevries@suse.de>
 538
 539         * aarch64-tdep.c: Fix typos in comments.
 540         * ada-lang.c: Same.
 541         * ada-tasks.c: Same.
 542         * alpha-tdep.c: Same.
 543         * alpha-tdep.h: Same.
 544         * amd64-nat.c: Same.
 545         * amd64-windows-tdep.c: Same.
 546         * arc-tdep.c: Same.
 547         * arc-tdep.h: Same.
 548         * arch-utils.c: Same.
 549         * arm-nbsd-tdep.c: Same.
 550         * arm-tdep.c: Same.
 551         * ax-gdb.c: Same.
 552         * blockframe.c: Same.
 553         * btrace.c: Same.
 554         * c-varobj.c: Same.
 555         * coff-pe-read.c: Same.
 556         * coffread.c: Same.
 557         * cris-tdep.c: Same.
 558         * darwin-nat.c: Same.
 559         * dbxread.c: Same.
 560         * dcache.c: Same.
 561         * disasm.c: Same.
 562         * dtrace-probe.c: Same.
 563         * dwarf-index-write.c: Same.
 564         * dwarf2-frame-tailcall.c: Same.
 565         * dwarf2-frame.c: Same.
 566         * dwarf2read.c: Same.
 567         * eval.c: Same.
 568         * exceptions.c: Same.
 569         * fbsd-tdep.c: Same.
 570         * findvar.c: Same.
 571         * frame.c: Same.
 572         * frv-tdep.c: Same.
 573         * gnu-v3-abi.c: Same.
 574         * go32-nat.c: Same.
 575         * h8300-tdep.c: Same.
 576         * hppa-tdep.c: Same.
 577         * i386-linux-tdep.c: Same.
 578         * i386-tdep.c: Same.
 579         * ia64-libunwind-tdep.c: Same.
 580         * ia64-tdep.c: Same.
 581         * infcmd.c: Same.
 582         * infrun.c: Same.
 583         * linespec.c: Same.
 584         * linux-nat.c: Same.
 585         * linux-thread-db.c: Same.
 586         * machoread.c: Same.
 587         * mdebugread.c: Same.
 588         * mep-tdep.c: Same.
 589         * mn10300-tdep.c: Same.
 590         * namespace.c: Same.
 591         * objfiles.c: Same.
 592         * opencl-lang.c: Same.
 593         * or1k-tdep.c: Same.
 594         * osabi.c: Same.
 595         * ppc-linux-nat.c: Same.
 596         * ppc-linux-tdep.c: Same.
 597         * ppc-sysv-tdep.c: Same.
 598         * printcmd.c: Same.
 599         * procfs.c: Same.
 600         * record-btrace.c: Same.
 601         * record-full.c: Same.
 602         * remote-fileio.c: Same.
 603         * remote.c: Same.
 604         * rs6000-tdep.c: Same.
 605         * s12z-tdep.c: Same.
 606         * score-tdep.c: Same.
 607         * ser-base.c: Same.
 608         * ser-go32.c: Same.
 609         * skip.c: Same.
 610         * sol-thread.c: Same.
 611         * solib-svr4.c: Same.
 612         * solib.c: Same.
 613         * source.c: Same.
 614         * sparc-nat.c: Same.
 615         * sparc-sol2-tdep.c: Same.
 616         * sparc-tdep.c: Same.
 617         * sparc64-tdep.c: Same.
 618         * stabsread.c: Same.
 619         * stack.c: Same.
 620         * symfile.c: Same.
 621         * symtab.c: Same.
 622         * target-descriptions.c: Same.
 623         * target-float.c: Same.
 624         * thread.c: Same.
 625         * utils.c: Same.
 626         * valops.c: Same.
 627         * valprint.c: Same.
 628         * value.c: Same.
 629         * varobj.c: Same.
 630         * windows-nat.c: Same.
 631         * xcoffread.c: Same.
 632         * xstormy16-tdep.c: Same.
 633         * xtensa-tdep.c: Same.
 634
 635 2019-10-17  Tom Tromey  <tromey@adacore.com>
 636
 637         * configure: Rebuild.
 638         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 639         in AC_CONFIG_FILES invocation.
 640         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 641         new-style config.status invocation.
 642
 643 2019-10-17  Tom de Vries  <tdevries@suse.de>
 644
 645         * arm-nbsd-nat.c: Fix typos in comments.
 646         * arm-tdep.c: Same.
 647         * darwin-nat-info.c: Same.
 648         * dwarf2read.c: Same.
 649         * elfread.c: Same.
 650         * event-top.c: Same.
 651         * findvar.c: Same.
 652         * gdbtypes.c: Same.
 653         * hppa-tdep.c: Same.
 654         * i386-tdep.c: Same.
 655         * jit.c: Same.
 656         * main.c: Same.
 657         * mdebugread.c: Same.
 658         * moxie-tdep.c: Same.
 659         * nto-procfs.c: Same.
 660         * osabi.c: Same.
 661         * ppc-linux-tdep.c: Same.
 662         * remote.c: Same.
 663         * riscv-tdep.c: Same.
 664         * s390-tdep.c: Same.
 665         * sh-tdep.c: Same.
 666         * sparc-linux-tdep.c: Same.
 667         * sparc-nat.c: Same.
 668         * stack.c: Same.
 669         * target-descriptions.c: Same.
 670         * top.c: Same.
 671         * varobj.c: Same.
 672
 673 2019-10-16  Tom Tromey  <tom@tromey.com>
 674
 675         * objfiles.h (struct objfile) <original_name>: Now const.
 676
 677 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 678
 679         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 680         pass on to sigsetjmp's second argument.
 681         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 682
 683 2019-10-16  Keith Seitz  <keiths@redhat.com>
 684
 685         PR gdb/23567
 686         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 687         sections whose size is greater than the file size.
 688
 689 2019-10-16  Jim Wilson  <jimw@sifive.com>
 690
 691         * riscv-tdep.c (riscv_gcc_target_options): New.
 692         (riscv_gnu_triplet_regexp): New.
 693         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 694         set_gdbarch_gnu_triplet_regexp.
 695
 696 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 697
 698         * Makefile.in: Add xml-builtin.h.
 699         * features/feature_to_c.sh: Add an include for xml-builtin.h
 700         to ensure that the compiler checks that the types match.
 701         * xml-builtin.h: New file.
 702         * xml-support.c (fetch_xml_builtin): Add missing const.
 703         * xml-support.h: Remove declaration of xml_builtins.
 704
 705 2019-10-16  Tom de Vries  <tdevries@suse.de>
 706
 707         PR tdep/25096
 708         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 709         (amd64_classify_aggregate): ... here.
 710         (amd64_classify_aggregate_field): Handled fiels of nested structs
 711         recursively.
 712
 713 2019-10-16  Tom de Vries  <tdevries@suse.de>
 714
 715         PR tdep/24104
 716         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 717         that handles 'theclass'.
 718
 719 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * linespec.c (decode_digits_ordinary): Update comment.
 722         * make-target-delegates: No longer need to handle VEC case.
 723         * memrange.c (normalize_mem_ranges): Update comment.
 724         * namespace.c (add_using_directive): Update comment.
 725         * objc-lang.c (uniquify_strings): Update comment.
 726         * ppc-linux-nat.c (struct thread_points): Update comment.
 727         * probe.h (find_probes_in_objfile): Update comment.
 728         * target.h (enum flash_preserve_mode): Update comment.
 729         * varobj.c (varobj_restrict_range): Update comment.
 730         * varobj.h (varobj_list_children): Update comment.
 731
 732 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         * Makefile.in: Remove references to vec.h and vec.c.
 735         * aarch64-tdep.c: No longer include vec.h.
 736         * ada-lang.c: Likewise.
 737         * ada-lang.h: Likewise.
 738         * arm-tdep.c: Likewise.
 739         * ax.h: Likewise.
 740         * breakpoint.h: Likewise.
 741         * charset.c: Likewise.
 742         * cp-support.h: Likewise.
 743         * dtrace-probe.c: Likewise.
 744         * dwarf2read.c: Likewise.
 745         * extension.h: Likewise.
 746         * gdb_bfd.c: Likewise.
 747         * gdbsupport/gdb_vecs.h: Likewise.
 748         * gdbsupport/vec.c: Remove.
 749         * gdbsupport/vec.h: Remove.
 750         * gdbthread.h: Likewise.
 751         * guile/scm-type.c: Likewise.
 752         * inline-frame.c: Likewise.
 753         * machoread.c: Likewise.
 754         * memattr.c: Likewise.
 755         * memrange.h: Likewise.
 756         * namespace.h: Likewise.
 757         * nat/linux-btrace.h: Likewise.
 758         * osdata.c: Likewise.
 759         * parser-defs.h: Likewise.
 760         * progspace.h: Likewise.
 761         * python/py-type.c: Likewise.
 762         * record-btrace.c: Likewise.
 763         * rust-exp.y: Likewise.
 764         * solib-target.c: Likewise.
 765         * stap-probe.c: Likewise.
 766         * target-descriptions.c: Likewise.
 767         * target-memory.c: Likewise.
 768         * target.h: Likewise.
 769         * varobj.c: Likewise.
 770         * varobj.h: Likewise.
 771         * xml-support.h: Likewise.
 772
 773 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 774
 775         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 776         Update for new std::vector based implementation.
 777         (process_psymtab_comp_unit_reader): Likewise.
 778         (scan_partial_symbols): Likewise.
 779         (recursively_compute_inclusions): Likewise.
 780         (compute_compunit_symtab_includes): Likewise.
 781         (process_imported_unit_die): Likewise.
 782         (queue_and_load_dwo_tu): Likewise.
 783         (follow_die_sig_1): Likewise.
 784         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 785         (typedef dwarf2_per_cu_ptr): Remove.
 786         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 787         function.
 788         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 789         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 790         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 791         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 792         std::vector.
 793
 794 2019-10-15  Tom Tromey  <tromey@adacore.com>
 795
 796         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 797         TID.
 798
 799 2019-10-15  Tom Tromey  <tromey@adacore.com>
 800
 801         * windows-nat.c (windows_nat_target::fetch_registers)
 802         (windows_nat_target::store_registers): Rename "pid" to "tid".
 803
 804 2019-10-15  Tom Tromey  <tromey@adacore.com>
 805
 806         * gdbarch.h, gdbarch.c: Rebuild.
 807         * gdbarch.sh (gcc_target_options): Change return type to
 808         std::string.
 809         * compile/compile.c (get_args): Update.
 810         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 811         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 812         std::string.
 813         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 814         std::string.
 815         * arch-utils.c (default_gcc_target_options): Return std::string.
 816         * arch-utils.h (default_gcc_target_options): Return std::string.
 817         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 818
 819 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 820
 821         * breakpoint.c (breakpoint_chain): Make static.
 822         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 823         of accessing breakpoint_chain.
 824
 825 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 826
 827         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 828         to a gdb::function_view and return value to bool.
 829         * breakpoint.h (iterate_over_breakpoints): Likewise.
 830         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 831         (pop_dummy_frame): Update.
 832         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 833         (gdbscm_breakpoints): Update.
 834         * python/py-breakpoint.c (build_bp_list): Update.
 835         (gdbpy_breakpoints): Update.
 836         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 837         Update.
 838         (bpfinishpy_handle_stop): Update.
 839         (bpfinishpy_handle_exit): Update.
 840         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 841         (svr4_update_solib_event_breakpoints): Update.
 842
 843 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 844
 845         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 846         when unwrapping single-field structs.
 847
 848 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 849
 850         * dwarf2read.c: Remove includes.
 851
 852 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 853
 854         * ui-out.c (ui_out::call_do_message): Silence
 855         -Wformat-nonliteral warning.
 856
 857 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 858
 859         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 860         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 861         include: readline/tilde.h.
 862
 863 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 864
 865         * remote.c (remote_target::get_trace_status): Remove declaration of
 866         trace_regblock_size.
 867
 868 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 869
 870         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 871         (show_user): Remove declaration of cmdlist.
 872         * cli/cli-cmds.h (max_user_call_depth): Declare.
 873         * cli/cli-script.c (execute_user_command): Remove declaration
 874         of max_user_call_depth.
 875
 876 2019-10-11  Jim Wilson  <jimw@sifive.com>
 877
 878         * gdbsupport/print-utils.h (pulongest): Fix comment.
 879         (plongest): Likewise.
 880         (phex): Add missing comment, mention leading zeros.
 881         (phex_nz): Add mention of no leading zeros to comment.
 882
 883         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 884         plongest instead of unsigned long long cast.
 885
 886 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 887
 888         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 889         for external_editor_command and gdbtk_test.
 890
 891 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 892
 893         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 894         * varobj.c (varobjdebug): Move comment to...
 895         * varobj.h (varobjdebug): ...here, and declare.
 896
 897 2019-10-09  Tom Tromey  <tom@tromey.com>
 898
 899         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 900         erase_data_content.
 901
 902 2019-10-09  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 905         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 906         * tui/tui-command.c (tui_cmd_window::resize)
 907         (tui_refresh_cmd_win): Update.
 908         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 909         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 910         * tui/tui-data.c (~tui_gen_win_info): Remove.
 911         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 912         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 913         (tui_redisplay_readline, tui_mld_flush)
 914         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 915         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 916         (tui_data_window::erase_data_content)
 917         (tui_data_item_window::rerender)
 918         (tui_data_item_window::refresh_window): Update.
 919         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 920         (box_win, tui_gen_win_info::make_window)
 921         (tui_gen_win_info::make_visible): Update.
 922         (tui_delete_win): Remove.
 923         * tui/tui-winsource.c
 924         (tui_source_window_base::do_erase_source_content): Update.
 925         (tui_show_source_line, tui_source_window_base::update_tab_width)
 926         (tui_source_window_base::update_exec_info): Update.
 927         * tui/tui-data.h (struct curses_deleter): New.
 928         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 929         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 930
 931 2019-10-09  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 934
 935 2019-10-09  Tom Tromey  <tom@tromey.com>
 936
 937         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 938         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 939
 940 2019-10-09  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 943         window height directly.
 944         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 945         declare.
 946         * tui/tui-layout.c (tui_default_win_height): Remove.
 947         (tui_default_win_viewport_height): Remove.
 948
 949 2019-10-09  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui.h: Remove comments.
 952
 953 2019-10-09  Tom de Vries  <tdevries@suse.de>
 954
 955         * python/lib/gdb/printer/bound_registers.py: Use
 956         '^builtin_type_bound128' as regexp argument for
 957         add_builtin_pretty_printer.
 958
 959 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 960
 961         * guile/guile.c (guile_extension_script_ops): Remove forward
 962         declaration and mark as static.
 963         (guile_script_ops): Likewise.
 964         (extension_language_guile): Move further down in the file so
 965         it can reference the definitions for guile_{extension_,}script_ops.
 966
 967 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 968
 969         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 970         except SORTL, DFLTCC, and KDSA.
 971
 972 2019-10-08  Tom Tromey  <tromey@adacore.com>
 973
 974         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 975         (struct safe_symbol_file_add_args): Remove.
 976
 977 2019-10-08  Tom Tromey  <tromey@adacore.com>
 978
 979         * windows-nat.c: Don't include buildsym-legacy.h.
 980
 981 2019-10-08  Tom Tromey  <tromey@adacore.com>
 982
 983         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 984
 985 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 986
 987         * gdbtypes.c (overload_debug): Move comment to header.
 988         * gdbtypes.h (overload_debug): Declare.
 989         * valops.c: Remove declaration of overload_debug, instead
 990         include gdbtypes.h.
 991
 992 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 993
 994         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 995         through _().
 996         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 997         move comment...
 998         * language.h (lang_frame_mismatch_warn): ... here. Also add
 999         declaration.
1000         * top.c (lang_frame_mismatch_warn): Remove declaration.
1001         (check_frame_language_change): Pass lang_frame_mismatch_warn
1002         through _().
1003
1004 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1005
1006         * c-lang.h (vtbl_ptr_name): Declare.
1007         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1008         it from the header.
1009         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1010
1011 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1012
1013         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1014         gdb_static_assert.
1015
1016 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1017
1018         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1019         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1020         * ctfread.c: New file.
1021         * ctfread.h: New file.
1022         * elfread.c: Include ctfread.h.
1023         (struct elfinfo text_p): New member ctfsect.
1024         (elf_locate_sections): Mark CTF section.
1025         (elf_symfile_read): Call elfctf_build_psymtabs.
1026         * Makefile.in (LIBCTF): Add.
1027         (CLIBS): Use it.
1028         (CDEPS): Likewise.
1029         (DIST): Add ctfread.c.
1030
1031 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1032
1033         * ctfread.c (struct nextfield): Renamed to ...
1034         (struct ctf_nextfield): ... this.
1035         (struct field_info): Renamed to ...
1036         (strut ctf_field_info): ... this.
1037         (attach_fields_to_type): Update for renamed structures.
1038         (ctf_add_member_cb): Likewise.
1039         (ctf_add_enum_member_cb): Likewise.
1040         (process_struct_members): Likewise.
1041         (process_enum_type): Likewise.
1042
1043 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1044
1045         * tracectf.h: Rename, was ctf.h.
1046         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1047         * tracefile.c: Likewise.
1048         * tracepoint.c: Remove unused include ctf.h.
1049         * mi/mi-main.c: Likewise.
1050         * Makefile.in Replace ctf.c with tracectf.c.
1051
1052 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1053
1054         * version.in: Change version number to "9.0.50.DATE-git".
1055
1056 2019-10-03  Tom Tromey  <tom@tromey.com>
1057
1058         PR rust/24976:
1059         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1060
1061 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1064         cp_search_name_hash.
1065         * NEWS: Add entry about nested function support.
1066
1067 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1068             Andrew Burgess  <andrew.burgess@embecosm.com>
1069
1070         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1071         for nested static variables when searchin VAR_DOMAIN.
1072         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1073         global scope, update comment.
1074         (add_partial_subprogram): Call add_partial_subprogram recursively
1075         for nested subroutines when processinng Fortran.
1076         (load_partial_dies): Process the child entities of a subprogram
1077         when processing Fortran.
1078         (partial_die_parent_scope): Handle building scope
1079         for Fortran nested functions.
1080         (process_die): Record that nested functions have a scope.
1081         (new_symbol): Always record Fortran subprograms on the global
1082         symbol list.
1083         (determine_prefix): How to build the prefix for Fortran
1084         subprograms.
1085
1086 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1087
1088         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1089         have just sent the thread a SIGSTOP and are waiting for it to
1090         arrive.
1091
1092 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1093
1094         * btrace.c (btrace_add_pc): Remove whitespace before the template
1095         parameter in 'std::vector <...>'.
1096         (parse_xml_btrace_block): Likewise.
1097         (btrace_maint_decode_pt): Likewise.
1098         (btrace_maint_update_packets): Likewise.
1099         (btrace_maint_print_packets): Likewise.
1100         * btrace.h (struct btrace_maint_info): Likewise.
1101         * dwarf2read.c (struct type_unit_group): Likewise.
1102         (build_type_psymtabs_reader): Likewise.
1103         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1104         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1105         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1106
1107 2019-10-03  Tom de Vries  <tdevries@suse.de>
1108
1109         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1110         the first line of the help text for set/show style metadata.
1111
1112 2019-10-02  Tom Tromey  <tromey@adacore.com>
1113
1114         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1115         * gdbsupport/common-inferior.c: New file.
1116         * infcmd.c (startup_with_shell): Don't define.
1117         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1118         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1119         * inferior.h (startup_with_shell): Don't declare.
1120
1121 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1122
1123         * gdbsupport/gdb_assert.h: Include errors.h.
1124         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1125
1126 2019-10-02  Tom Tromey  <tromey@adacore.com>
1127
1128         * NEWS: Add $_ada_exception entry.
1129         * ada-lang.c (struct ada_catchpoint): Add constructor.
1130         <m_kind>: New member.
1131         (allocate_location_exception, re_set_exception): Remove
1132         "ex" parameter.
1133         (should_stop_exception): Compute $_ada_exception.
1134         (check_status_exception, print_it_exception)
1135         (print_one_exception, print_mention_exception): Remove
1136         "ex" parameter.
1137         (allocate_location_catch_exception, re_set_catch_exception)
1138         (check_status_exception, print_it_catch_exception)
1139         (print_one_catch_exception, print_mention_catch_exception)
1140         (print_recreate_catch_exception)
1141         (allocate_location_catch_exception_unhandled)
1142         (re_set_catch_exception_unhandled)
1143         (check_status_exception, print_it_catch_exception_unhandled)
1144         (print_one_catch_exception_unhandled)
1145         (print_mention_catch_exception_unhandled)
1146         (print_recreate_catch_exception_unhandled)
1147         (allocate_location_catch_assert, re_set_catch_assert)
1148         (check_status_assert, print_it_catch_assert)
1149         (print_one_catch_assert, print_mention_catch_assert)
1150         (print_recreate_catch_assert)
1151         (allocate_location_catch_handlers, re_set_catch_handlers)
1152         (check_status_handlers, print_it_catch_handlers)
1153         (print_one_catch_handlers, print_mention_catch_handlers)
1154         (print_recreate_catch_handlers): Remove.
1155         (create_ada_exception_catchpoint): Update.
1156         (initialize_ada_catchpoint_ops): Update.
1157
1158 2019-10-02  Tom Tromey  <tromey@adacore.com>
1159
1160         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1161         (create_excep_cond_exprs): Simplify exception string computation.
1162         (ada_exception_catchpoint_cond_string): Likewise.
1163
1164 2019-10-02  Tom Tromey  <tromey@adacore.com>
1165
1166         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1167         * ada-lang.c (lesseq_defined_than): Handle
1168         LOC_STATIC.
1169         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1170         parameter.
1171         (dwarf2_has_info): Likewise.
1172         (new_symbol): Set maybe_copied on symbol when
1173         appropriate.
1174         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1175         parameter.
1176         <can_copy>: New member.
1177         * elfread.c (record_minimal_symbol): Set maybe_copied
1178         on symbol when appropriate.
1179         (elf_symfile_read): Update call to dwarf2_has_info.
1180         * minsyms.c (lookup_minimal_symbol_linkage): New
1181         function.
1182         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1183         * symtab.c (get_symbol_address, get_msymbol_address):
1184         New functions.
1185         * symtab.h (get_symbol_address, get_msymbol_address):
1186         Declare.
1187         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1188         maybe_copied.
1189         (struct symbol, struct minimal_symbol) <maybe_copied>:
1190         New member.
1191
1192 2019-10-02  Tom Tromey  <tromey@adacore.com>
1193
1194         * source.c (struct current_source_location): New.
1195         (current_source_key): New global.
1196         (current_source_symtab, current_source_line)
1197         (current_source_pspace): Remove.
1198         (get_source_location): New function.
1199         (get_current_source_symtab_and_line)
1200         (set_default_source_symtab_and_line)
1201         (set_current_source_symtab_and_line)
1202         (clear_current_source_symtab_and_line, select_source_symtab)
1203         (info_source_command, print_source_lines_base)
1204         (info_line_command, search_command_helper, _initialize_source):
1205         Update.
1206
1207 2019-10-02  Tom Tromey  <tromey@adacore.com>
1208
1209         * source.c (select_source_symtab): Don't call
1210         decode_line_with_current_source.
1211
1212 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1213
1214         * symtab.c (lookup_global_symbol): Search global block.
1215
1216 2019-10-02  Tom Tromey  <tromey@adacore.com>
1217
1218         * coffread.c (process_coff_symbol): Update.
1219         * dwarf2read.c (var_decode_location, new_symbol): Update.
1220         * mdebugread.c (parse_symbol): Update.
1221         * objfiles.c (relocate_one_symbol): Update.
1222         * stabsread.c (define_symbol, fix_common_block)
1223         (scan_file_globals): Update.
1224         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1225         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1226         * xcoffread.c (process_xcoff_symbol): Update.
1227
1228 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1229
1230         * MAINTAINERS: Update my email address.
1231
1232 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1235         std::vector.
1236         (build_type_psymtabs_reader): Update for std::vector.
1237         (build_type_psymtab_dependencies): Likewise.
1238         * dwarf2read.h: Remove use of DEF_VEC_P.
1239         (typedef sig_type_ptr): Delete.
1240
1241 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1242
1243         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1244         to std::vector.
1245         (btrace_maint_decode_pt): Likewise, and move allocation of the
1246         vector outside of the loop.
1247         (btrace_maint_update_packets): Update to handle change from VEC to
1248         std::vector.
1249         (btrace_maint_print_packets): Likewise.
1250         (maint_info_btrace_cmd): Likewise.
1251         * btrace.h: Remove use of DEF_VEC_O.
1252         (typedef btrace_pt_packet_s): Delete.
1253         (struct btrace_maint_info) <packets>: Change fromm VEC to
1254         std::vector.
1255         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1256
1257 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1260         make accesses into the vector constant references.
1261         (btrace_add_pc): Update for std::vector.
1262         (btrace_stitch_bts): Likewise.
1263         (parse_xml_btrace_block): Likewise.
1264         (btrace_maint_update_packets): Likewise.
1265         (btrace_maint_print_packets): Likewise.
1266         (maint_info_btrace_cmd): Likewise.
1267         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1268         std::vector.
1269         (btrace_data::empty): Likewise.
1270         (btrace_data_append): Likewise.
1271         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1272         (typedef btrace_block_s): Delete.
1273         (struct btrace_block): Add constructor.
1274         (struct btrace_data_bts) <blocks>: Change to std::vector.
1275         * nat/linux-btrace.c (perf_event_read_bts): Update for
1276         std::vector.
1277         (linux_read_bts): Likewise.
1278
1279 2019-10-01  Tom Tromey  <tom@tromey.com>
1280
1281         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1282
1283 2019-10-01  Tom Tromey  <tom@tromey.com>
1284
1285         * stack.c (print_frame, info_frame_command_core): Use
1286         styled_string.
1287         * linux-thread-db.c (try_thread_db_load_1)
1288         (try_thread_db_load_from_pdir_1): Use styled_string.
1289         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1290         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1291         (maybe_print_unsupported_script_warning)
1292         (maybe_print_script_not_found_warning): Use styled_string.
1293         * ada-lang.c (user_select_syms): Use styled_string.
1294
1295 2019-10-01  Tom Tromey  <tom@tromey.com>
1296
1297         * p-lang.c (pascal_printstr): Use metadata style.
1298         * value.c (show_convenience): Use metadata style.
1299         * valprint.c (valprint_check_validity, val_print_optimized_out)
1300         (val_print_not_saved, val_print_unavailable)
1301         (val_print_invalid_address, generic_val_print, val_print)
1302         (value_check_printable, val_print_array_elements): Use metadata
1303         style.
1304         * ui-out.h (class ui_out) <field_fmt>: New overload.
1305         <do_field_fmt>: Add style parameter.
1306         * ui-out.c (ui_out::field_fmt): New overload.
1307         * typeprint.c (type_print_unknown_return_type)
1308         (val_print_not_allocated, val_print_not_associated): Use metadata
1309         style.
1310         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1311         parameter.
1312         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1313         * tracepoint.c (tvariables_info_1): Use metadata style.
1314         * stack.c (print_frame_arg, print_frame_info, print_frame)
1315         (info_frame_command_core): Use metadata style.
1316         * skip.c (info_skip_command): Use metadata style.
1317         * rust-lang.c (rust_print_enum): Use metadata style.
1318         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1319         metadata style.
1320         * python/py-framefilter.c (py_print_single_arg): Use metadata
1321         style.
1322         * printcmd.c (do_one_display, print_variable_and_value): Use
1323         metadata style.
1324         * p-valprint.c (pascal_val_print)
1325         (pascal_object_print_value_fields): Use metadata style.
1326         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1327         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1328         parameter.
1329         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1330         * m2-valprint.c (m2_print_long_set): Use metadata style.
1331         * m2-typeprint.c (m2_print_type): Use metadata style.
1332         * infcmd.c (print_return_value_1): Use metadata style.
1333         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1334         * f-valprint.c (info_common_command_for_block): Use metadata
1335         style.
1336         * f-typeprint.c (f_type_print_base): Use metadata style.
1337         * expprint.c (print_subexp_standard): Use metadata style.
1338         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1339         * cli/cli-style.h (class cli_style_option): Add constructor.
1340         (metadata_style): Declare.
1341         * cli/cli-style.c (metadata_style): New global.
1342         (_initialize_cli_style): Register metadata style.
1343         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1344         parameter.
1345         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1346         * c-typeprint.c (c_type_print_base_struct_union)
1347         (c_type_print_base_1): Use metadata style.
1348         * breakpoint.c (watchpoint_value_print)
1349         (print_one_breakpoint_location): Use metadata style.
1350         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1351         style.
1352         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1353         style.
1354         * ada-valprint.c (val_print_packed_array_elements, printstr)
1355         (print_field_values, ada_val_print_ref, ada_val_print): Use
1356         metadata style.
1357         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1358         style.
1359         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1360         style.
1361         * ada-lang.c (user_select_syms): Use metadata style.
1362
1363 2019-10-01  Tom Tromey  <tom@tromey.com>
1364
1365         * cli/cli-cmds.c (pwd_command): Style output.
1366
1367 2019-10-01  Pedro Alves  <palves@redhat.com>
1368             Tom Tromey  <tom@tromey.com>
1369
1370         * symtab.c (print_symbol_info): Use %ps.
1371         (print_msymbol_info): Use %ps.
1372         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1373         * printcmd.c (print_variable_and_value): Use %ps.
1374         * macrocmd.c (show_pp_source_pos): Use %ps.
1375         * infrun.c (print_exited_reason): Use ui_out::message.
1376         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1377         (describe_other_breakpoints): Use ui_out::message and new
1378         formats.
1379         (say_where): Use new formats.
1380         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1381         and new formats.
1382
1383 2019-10-01  Pedro Alves  <palves@redhat.com>
1384             Tom Tromey  <tom@tromey.com>
1385
1386         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1387         (test_gdb_formats): New function.
1388         (run_tests): Call it.
1389         (test_format_specifier): Update.
1390         * utils.h (fputs_filtered): Update comment.
1391         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1392         (fputs_styled_unfiltered): Declare.
1393         * utils.c (fputs_styled_unfiltered): New function.
1394         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1395         (vfprintf_filtered): Update.
1396         (vfprintf_unfiltered, vprintf_filtered): Update.
1397         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1398         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1399         disallow_ui_out_field>: New constants.
1400         (enum class field_kind): New.
1401         (struct base_field_s, struct signed_field_s): New.
1402         (signed_field): New function.
1403         (struct string_field_s): New.
1404         (string_field): New function.
1405         (struct styled_string_s): New.
1406         (styled_string): New function.
1407         (class ui_out) <message>: Add comment.
1408         <vmessage, call_do_message>: New methods.
1409         <do_message>: Add style parameter.
1410         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1411         methods.
1412         (ui_out::message): Rewrite.
1413         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1414         parameter.
1415         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1416         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1417         gdb_extensions parameter.
1418         (class format_piece): Add parameter to constructor.
1419         (n_int_args): New field.
1420         * gdbsupport/format.c (format_pieces::format_pieces): Add
1421         gdb_extensions parameter.  Handle '*'.
1422         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1423         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1424         vfprintf_styled_no_gdbfmt.
1425         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1426         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1427         unfiltered output.
1428         * ui-style.h (struct ui_file_style) <ptr>: New method.
1429
1430 2019-10-01  Tom Tromey  <tom@tromey.com>
1431
1432         * unittests/format_pieces-selftests.c: Update.  Add final format.
1433         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1434         empty literal pieces.
1435
1436 2019-10-01  Tom Tromey  <tom@tromey.com>
1437
1438         * ui-out.h (enum class ui_out_style_kind): Remove.
1439         (class ui_out) <field_string, field_stsream, do_field_string>:
1440         Change type of "style".
1441         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1442         (ui_out::field_string): Update.
1443         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1444         of "style".
1445         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1446         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1447         * stack.c (print_frame_arg, print_frame_info, print_frame):
1448         Update.
1449         * source.c (print_source_lines_base): Update.
1450         * solib.c (info_sharedlibrary_command): Update.
1451         * skip.c (info_skip_command): Update.
1452         * record-btrace.c (btrace_call_history_src_line)
1453         (btrace_call_history): Update.
1454         * python/py-framefilter.c (py_print_frame): Update.
1455         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1456         "style".
1457         * mi/mi-out.c (mi_ui_out::do_table_header)
1458         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1459         (mi_ui_out::do_field_string): Update.
1460         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1461         Update.
1462         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1463         "style".
1464         * cli-out.c (cli_ui_out::do_table_header)
1465         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1466         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1467         (cli_ui_out::do_field_fmt): Update.
1468         * breakpoint.c (print_breakpoint_location): Update.
1469         (update_static_tracepoint): Update.
1470
1471 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1472
1473         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1474         conversion of gdb_datadir.
1475         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1476         remove not needed c_str ().
1477
1478 2019-09-30  Ali Tamur <tamur@google.com>
1479
1480         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1481         (dwarf2_string_attr): Likewise.
1482
1483 2019-09-30  Ali Tamur <tamur@google.com>
1484
1485         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1486         (process_full_type_unit): Likewise.
1487         (dump_die_shallow): Likewise.
1488         (cu_debug_loc_section): Likewise.
1489
1490 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1491
1492         * minsyms.c (compare_minimal_symbols): Rename to...
1493         (minimal_symbol_is_less_than): ...this, and adjust to STL
1494         conventions (return bool, take arguments as references)
1495         (minimal_symbol_reader::install): Call std::sort instead
1496         of qsort.
1497
1498 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1499
1500         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1501         hash and why.
1502         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1503         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1504
1505 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1506
1507         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1508         * psympriv.h (add_psymbol_to_list): Move comment here and update
1509         it.
1510
1511 2019-09-29  Tom de Vries  <tdevries@suse.de>
1512
1513         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1514         Use $tmpdir/$(basename "$output_file").dwz instead of
1515         "${output_file}.dwz".
1516
1517 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1518
1519         PR gdb/25045
1520         * hppa-linux-nat.c: Include gdbarch.h.
1521
1522 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1523
1524         * blockframe.c (find_pc_partial_function): Change return type to bool.
1525         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1526         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1527         (stub_gnu_ifunc_resolve_name): Likewise.
1528         * symtab.c (compare_filenames_for_search): Likewise.
1529         (compare_glob_filenames_for_search): Likewise.
1530         (matching_obj_sections): Likewise.
1531         (symbol_matches_domain): Likewise.
1532         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1533         (find_line_pc): Change return type to bool.
1534         (find_line_pc_range): Likewise.
1535         (producer_is_realview): Likewise.
1536         * symtab.h (symbol_matches_domain): Likewise.
1537         (find_pc_partial_function): Likewise.
1538         (find_pc_line_pc_range): Likewise.
1539         (in_gnu_ifunc_stub): Likewise.
1540         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1541         (find_line_pc): Likewise.
1542         (find_line_pc_range): Likewise.
1543         (matching_obj_sections): Likewise.
1544         (find_line_symtab): Change out parameter to bool.
1545         (producer_is_realview): Change return type to bool.
1546         (compare_filenames_for_search): Likewise.
1547         (compare_glob_filenames_for_search): Likewise.
1548
1549 2019-09-26  Tom Tromey  <tom@tromey.com>
1550
1551         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1552         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1553         * gdb_usleep.h: Remove.
1554         * gdb_usleep.c: Remove.
1555         * utils.c: Don't include gdb_usleep.h.
1556
1557 2019-09-26  Tom Tromey  <tromey@adacore.com>
1558
1559         * python/py-type.c (type_to_type_object): Call check_typedef
1560         for stub types.
1561
1562 2019-09-26  Tom Tromey  <tom@tromey.com>
1563
1564         * utils.h (initialize_utils): Don't declare.
1565         * top.c (gdb_init): Don't call initialize_utils.
1566         * utils.c (initialize_utils): Remove.  Move contents...
1567         (_initialize_utils): ... here.
1568
1569 2019-09-25  Tom Tromey  <tom@tromey.com>
1570
1571         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1572         * utils.h (make_hex_string): Don't declare.
1573         * utils.c (make_hex_string): Remove.
1574
1575 2019-09-24  Tom de Vries  <tdevries@suse.de>
1576
1577         PR gdb/23815
1578         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1579         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1580
1581 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1582
1583         * NEWS: Mention new simulator port for PRU.
1584
1585 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1586
1587         * ada-exp.y (write_object_remaining): Update.
1588         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1589         and eliminate the static buffer.
1590         (ada_decode_symbol): Update.
1591         (ada_la_decode): Update.
1592         (ada_sniff_from_mangled_name): Update.
1593         (is_valid_name_for_wild_match): Update.
1594         (ada_lookup_name_info::matches): Update and simplify.
1595         (name_matches_regex): Update.
1596         (ada_add_global_exceptions): Update.
1597         * ada-lang.h (ada_decode): Update signature.
1598         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1599         * dwarf-index-write.c (debug_names::insert): Update.
1600
1601 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1602
1603         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1604         formatting.
1605
1606 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1607
1608         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1609         Change "nonzero" to "true" in documentation.
1610
1611 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1612
1613         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1614         (_initialize_darwin_solib): Don't set
1615         darwin_so_ops.lookup_lib_global_symbol.
1616         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1617         set_gdbarch_iterate_over_objfiles_in_search_order.
1618         (elf_lookup_lib_symbol): Rename to...
1619         (svr4_iterate_over_objfiles_in_search_order): this, and update
1620         to iterate semantics.
1621         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1622         * solib.c (solib_global_lookup): Remove.
1623         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1624         (solib_global_lookup): Remove.
1625         * symtab.c (lookup_global_or_static_symbol): Remove call to
1626         solib_global_lookup.
1627
1628 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1629
1630         * NEWS: Move entries about default MI version now being
1631         version 3, and about the GDB/MI fix for multi-location
1632         breakpoints to the "since GDB 8.3" section.
1633
1634 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1635
1636         GDB 8.3.1 released.
1637
1638 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1639
1640         * NEWS: Mention that Cell/B.E. debugging support was removed.
1641         * MAINTAINERS: Remove spu target.
1642
1643         * config/djgpp/fnchange.lst: Remove entries for removed files.
1644
1645         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1646         spu-multiarch.o, and spu-tdep.o.
1647         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1648         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1649         spu-multiarch.c, and spu-tdep.c.
1650         * spu-linux-nat.c: Remove file.
1651         * spu-multiarch.c: Remove file.
1652         * spu-tdep.c: Remove file.
1653         * spu-tdep.h: Remove file.
1654         * solib-spu.c: Remove file.
1655         * solib-spu.h: Remove file.
1656
1657         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1658         * configure.nat (spu-linux): Remove.
1659         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1660         solib-multiarch.o from gdb_target_obs.
1661         (spu*-*-*): Remove.
1662
1663         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1664         feature flag.
1665         (ppc_linux_no_features): Update.
1666         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1667         Cell/B.E. support.
1668         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1669         (tdesc_powerpc_cell64l): Likewise.
1670         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1671         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1672         Cell/B.E. support.
1673         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1674         Do not include "features/rs6000/powerpc-cell32l.c" or
1675         "features/rs6000/powerpc-cell64l.c".
1676         (ppc_linux_spu_section): Remove.
1677         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1678         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1679         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1680         (ppc_linux_spe_context_lookup): Remove.
1681         (ppc_linux_spe_context_inferior_created): Remove.
1682         (ppc_linux_spe_context_solib_loaded): Remove.
1683         (ppc_linux_spe_context_solib_unloaded): Remove.
1684         (ppc_linux_spe_context): Remove.
1685         (struct ppu2spu_cache): Remove.
1686         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1687         (struct ppu2spu_data): Remove.
1688         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1689         ppu2spu_unwind): Remove.
1690         (ppc_linux_init_abi): Remove Cell/B.E. support.
1691         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1692
1693         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1694         (rs6000/powerpc-cell64l-expedite): Likewise
1695         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1696         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1697         rs6000/powerpc-cell64l.xml.
1698         * features/rs6000/powerpc-cell32l.xml: Remove.
1699         * features/rs6000/powerpc-cell64l.xml: Likewise.
1700         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1701         * features/rs6000/powerpc-cell64l.c: Likewise.
1702         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1703         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1704         * regformats/reg-spu.dat: Remove.
1705
1706         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1707         * corelow.c (struct spuid_list): Remove.
1708         (add_to_spuid_list): Remove.
1709         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1710         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1711         (remote_protocol_features): Remove associated entries.
1712         (_initialize_remote): No longer initialize them.
1713         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1714         * linux-nat.c (SPUFS_MAGIC): Remove.
1715         (linux_proc_xfer_spu): Remove.
1716         (spu_enumerate_spu_ids): Remove.
1717         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1718         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1719         (linux_make_corefile_notes): No longer call it.
1720
1721         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1722         (cooked_write_test): Likewise.
1723
1724 2019-09-20  Tom Tromey  <tom@tromey.com>
1725
1726         * NEWS: Mention case-sensitivity of TUI commands.
1727         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1728         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1729         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1730
1731 2019-09-20  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-source.c (tui_source_window::set_contents): Use
1734         make_unique_xstrdup.
1735         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1736         make_unique_xstrdup.
1737
1738 2019-09-20  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-data.c: Remove separator comments.
1741         * tui/tui-layout.c: Remove separator comments.
1742         * tui/tui-win.c: Remove separator comments.
1743         * tui/tui-wingeneral.c: Remove separator comments.
1744
1745 2019-09-20  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui.h (strcat_to_buf): Don't declare.
1748         * tui/tui.c (strcat_to_buf): Remove.
1749
1750 2019-09-20  Tom Tromey  <tom@tromey.com>
1751
1752         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1753         from "fullname".
1754         * tui/tui-source.c (tui_source_window::set_contents)
1755         (tui_source_window::location_matches_p)
1756         (tui_source_window::maybe_update): Update.
1757
1758 2019-09-20  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1761         Update.
1762         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1763         prefix.
1764         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1765         (tui_data_window::line_from_reg_element_no)
1766         (tui_data_window::first_reg_element_no_inline)
1767         (tui_data_window::show_registers)
1768         (tui_data_window::show_register_group)
1769         (tui_data_window::display_registers_from)
1770         (tui_data_window::display_registers_from_line)
1771         (tui_data_window::first_data_item_displayed)
1772         (tui_data_window::delete_data_content_windows)
1773         (tui_data_window::erase_data_content)
1774         (tui_data_window::do_scroll_vertical)
1775         (tui_data_window::refresh_window)
1776         (tui_data_window::check_register_values): Update.
1777
1778 2019-09-20  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1781         (struct tui_locator_window) <full_name, proc_name>: Now
1782         std::string.
1783         * tui/tui-stack.c (tui_locator_window::make_status_line)
1784         (tui_locator_window::set_locator_fullname)
1785         (tui_locator_window::set_locator_info): Update.
1786         * tui/tui-source.c (tui_source_window::set_contents)
1787         (tui_source_window::showing_source_p): Update.
1788
1789 2019-09-20  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1792         Don't call tui_locator_win_info_ptr.
1793
1794 2019-09-20  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1797
1798 2019-09-20  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1801         height for locator.
1802         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1803         * tui/tui-layout.c (show_source_disasm_command, show_data)
1804         (show_source_or_disasm_and_command): Use 1 as height for locator.
1805
1806 2019-09-20  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui.c (tui_enable): Update.
1809         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1810         Update.
1811         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1812         Update.
1813         * tui/tui-data.c (win_resized): Now bool.
1814         (tui_win_resized): Return bool.
1815         (tui_set_win_resized_to): Accept a bool.
1816
1817 2019-09-20  Tom Tromey  <tom@tromey.com>
1818
1819         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1820         Change type of "refresh_values_only".
1821         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1822         type of "refresh_values_only".
1823
1824 2019-09-20  Tom Tromey  <tom@tromey.com>
1825
1826         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1827         std::string.
1828         (tui_disassemble): Add "pos" parameter.
1829         (tui_disasm_window::set_contents): Simplify.
1830
1831 2019-09-20  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.h (struct tui_source_window_base)
1834         <show_source_content>: Now private.
1835         * tui/tui-winsource.c
1836         (tui_source_window_base::show_source_content): Don't handle empty
1837         content case.
1838
1839 2019-09-20  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-layout.c (show_source_disasm_command)
1842         (show_source_or_disasm_and_command): Don't call
1843         show_source_content.
1844
1845 2019-09-20  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1848         Declare.
1849         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1850         from tui_make_status_line.
1851         (tui_locator_window::rerender): Update.
1852
1853 2019-09-20  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1856         (tui_locator_window::rerender): Update.
1857
1858 2019-09-20  Tom Tromey  <tom@tromey.com>
1859
1860         * tui/tui-winsource.h (struct tui_source_window_base)
1861         <~tui_source_window_base>: Don't declare.
1862         <fullname>: Remove.
1863         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1864         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1865         member.
1866         * tui/tui-source.c (tui_source_window::set_contents): Update.
1867         (tui_source_window::location_matches_p)
1868         (tui_source_window::maybe_update): Update.
1869
1870 2019-09-20  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-winsource.h (~tui_source_element): Remove.
1873         (tui_source_element): Update.
1874         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1875         * tui/tui-winsource.c (tui_show_source_line): Update.
1876         * tui/tui-source.c (tui_source_window::set_contents): Update.
1877         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1878
1879 2019-09-20  Tom Tromey  <tom@tromey.com>
1880
1881         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1882         declare.
1883         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1884         tui_clear_source_windows_detail.
1885         * tui/tui-winsource.h (struct tui_source_window_base)
1886         <clear_detail>: Don't declare.
1887         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1888         Remove.
1889         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1890
1891 2019-09-20  Tom Tromey  <tromey@adacore.com>
1892
1893         PR ada/24919:
1894         * block.c (contained_in): Fix final return value.
1895
1896 2019-09-20  Alan Modra  <amodra@gmail.com>
1897
1898         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1899         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1900         (read_indirect_string_from_dwz): Use bfd accessor.
1901         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1902         * machoread.c (macho_symfile_read_all_oso): Likewise.
1903         * solib.c (solib_bfd_open): Likewise.
1904
1905 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1906
1907         * eval.c: Move declaration of overload_resolution to...
1908         * value.h: ...here.
1909
1910 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1911
1912         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1913         * arm-linux-tdep.c: Likewise.
1914         * arm-nbsd-nat.c: Likewise.
1915         * arm-tdep.h: Declare arm_apcs_32.
1916         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1917
1918 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1919
1920         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1921         * dwarf2read.h: Declare dwarf_always_disassemble.
1922
1923 2019-09-19  Tom de Vries  <tdevries@suse.de>
1924
1925         PR gdb/25009
1926         * source-cache.c (source_cache::ensure): Catch exception thrown during
1927         construction of the highlighter.
1928
1929 2019-09-18  Alan Modra  <amodra@gmail.com>
1930
1931         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1932         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1933         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1934         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1935         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1936         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1937         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1938         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1939         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1940         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1941         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1942         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1943         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1944         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1945         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1946         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1947         * mi/mi-interp.c: Update throughout for bfd section macro and
1948         function changes.
1949         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1950         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1951
1952 2019-09-18  Tom Tromey  <tom@tromey.com>
1953
1954         * NEWS: Add entry.
1955         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1956         call rl_initialize.
1957         (tui_enable): Do not call rl_initialize.
1958
1959 2019-09-18  Christian Groessler  <chris@groessler.org>
1960
1961         * alpha-linux-nat.c: Include gdbarch.h.
1962
1963 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1964
1965         * ui-file.c: Include cli/cli-style.h.
1966         (term_cli_styling): Remove cli_styling declaration.
1967
1968 2019-09-18  Alan Modra  <amodra@gmail.com>
1969
1970         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1971         to bfd_asymbol_section.
1972
1973 2019-09-18  Alan Modra  <amodra@gmail.com>
1974
1975         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1976         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1977         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1978
1979 2019-09-18  Alan Modra  <amodra@gmail.com>
1980
1981         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1982         * spu-linux-nat.c (spu_bfd_open): Likewise.
1983
1984 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1985
1986         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1987         to bool to match definition in dwarf2read.c.
1988
1989 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1990
1991         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1992         (print_signatures): Likewise.
1993         (trust_pad_over_xvs): Likewise.
1994         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1995         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1996         * arm-linux-nat.c (arm_apcs_32): Likewise.
1997         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1998         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1999         * arm-tdep.c (arm_debug): Likewise.
2000         (arm_apcs_32): Likewise.
2001         * auto-load.c (debug_auto_load): Likewise.
2002         (auto_load_gdb_scripts): Likewise.
2003         (global_auto_load): Likewise.
2004         (auto_load_local_gdbinit): Likewise.
2005         (auto_load_local_gdbinit_loaded): Likewise.
2006         * auto-load.h (global_auto_load): Likewise.
2007         (auto_load_local_gdbinit): Likewise.
2008         (auto_load_local_gdbinit_loaded): Likewise.
2009         * breakpoint.c (disconnected_dprintf): Likewise.
2010         (breakpoint_proceeded): Likewise.
2011         (automatic_hardware_breakpoints): Likewise.
2012         (always_inserted_mode): Likewise.
2013         (target_exact_watchpoints): Likewise.
2014         (_initialize_breakpoint): Update.
2015         * breakpoint.h (target_exact_watchpoints): Change to bool.
2016         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2017         * cli/cli-cmds.c (trace_commands): Likewise.
2018         * cli/cli-cmds.h (trace_commands): Likewise.
2019         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2020         to bool*.
2021         * cli/cli-logging.c (logging_overwrite): Change to bool.
2022         (logging_redirect): Likewise.
2023         (debug_redirect): Likewise.
2024         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2025         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2026         to bool.
2027         <boolean_option_def>: Update.
2028         (struct flag_option_def): Change default type of Context to bool
2029         from int.
2030         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2031         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2032         (get_setshow_command_value_string): Likewise.
2033         * cli/cli-style.c (cli_styling): Change to bool.
2034         (source_styling): Likewise.
2035         * cli/cli-style.h (source_styling): Likewise.
2036         (cli_styling): Likewise.
2037         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2038         to bool.
2039         * command.h (var_types): Update comment.
2040         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2041         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2042         bool.
2043         (debug_compile_cplus_scopes): Likewise.
2044         * compile/compile-internal.h (compile_debug): Likewise.
2045         * compile/compile.c (compile_debug): Likewise.
2046         (struct compile_options) <raw>: Likewise.
2047         * cp-support.c (catch_demangler_crashes): Likewise.
2048         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2049         (usr_cmd_cris_dwarf2_cfi): Likewise.
2050         * csky-tdep.c (csky_debug): Likewise.
2051         * darwin-nat.c (enable_mach_exceptions): Likewise.
2052         * dcache.c (dcache_enabled_p): Likewise.
2053         * defs.h (info_verbose): Likewise.
2054         * demangle.c (demangle): Likewise.
2055         (asm_demangle): Likewise.
2056         * dwarf-index-cache.c (debug_index_cache): Likewise.
2057         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2058         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2059         * dwarf2read.c (check_physname): Likewise.
2060         (use_deprecated_index_sections): Likewise.
2061         (dwarf_always_disassemble): Likewise.
2062         * eval.c (overload_resolution): Likewise.
2063         * event-top.c (set_editing_cmd_var): Likewise.
2064         (exec_done_display_p): Likewise.
2065         * event-top.h (set_editing_cmd_var): Likewise.
2066         (exec_done_display_p): Likewise.
2067         * exec.c (write_files): Likewise.
2068         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2069         (debug_fbsd_nat): Likewise.
2070         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2071         Likewise.
2072         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2073         <backtrace_past_entry> Likewise.
2074         * gdb-demangle.h (demangle): Likewise.
2075         (asm_demangle): Likewise.
2076         * gdb_bfd.c (bfd_sharing): Likewise.
2077         * gdbcore.h (write_files): Likewise.
2078         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2079         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2080         * gdbthread.h (print_thread_events): Likewise.
2081         * gdbtypes.c (opaque_type_resolution): Likewise.
2082         (strict_type_checking): Likewise.
2083         * gnu-nat.c (gnu_debug_flag): Likewise.
2084         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2085         * guile/scm-param.c (pascm_variable): Add boolval.
2086         (add_setshow_generic): Update.
2087         (pascm_param_value): Update.
2088         (pascm_set_param_value_x): Update.
2089         * hppa-tdep.c (hppa_debug): Change to bool..
2090         * infcall.c (may_call_functions_p): Likewise.
2091         (coerce_float_to_double_p): Likewise.
2092         (unwind_on_signal_p): Likewise.
2093         (unwind_on_terminating_exception_p): Likewise.
2094         * infcmd.c (startup_with_shell): Likewise.
2095         * inferior.c (print_inferior_events): Likewise.
2096         * inferior.h (startup_with_shell): Likewise.
2097         (print_inferior_events): Likewise.
2098         * infrun.c (step_stop_if_no_debug): Likewise.
2099         (detach_fork): Likewise.
2100         (debug_displaced): Likewise.
2101         (disable_randomization): Likewise.
2102         (non_stop): Likewise.
2103         (non_stop_1): Likewise.
2104         (observer_mode): Likewise.
2105         (observer_mode_1): Likewise.
2106         (set_observer_mode): Update.
2107         (sched_multi): Change to bool.
2108         * infrun.h (debug_displaced): Likewise.
2109         (sched_multi): Likewise.
2110         (step_stop_if_no_debug): Likewise.
2111         (non_stop): Likewise.
2112         (disable_randomization): Likewise.
2113         * linux-tdep.c (use_coredump_filter): Likewise.
2114         (dump_excluded_mappings): Likewise.
2115         * linux-thread-db.c (auto_load_thread_db): Likewise.
2116         (check_thread_db_on_load): Likewise.
2117         * main.c (captured_main_1): Update.
2118         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2119         xx2_opt, boolean_opt>: Change to bool.
2120         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2121         * maint.c (maintenance_profile_p): Likewise.
2122         (per_command_time): Likewise.
2123         (per_command_space): Likewise.
2124         (per_command_symtab): Likewise.
2125         * memattr.c (inaccessible_by_default): Likewise.
2126         * mi/mi-main.c (mi_async): Likewise.
2127         (mi_async_1): Likewise.
2128         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2129         * nat/fork-inferior.h (startup_with_shell): Likewise.
2130         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2131         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2132         * nios2-tdep.c (nios2_debug): Likewise.
2133         * or1k-tdep.c (or1k_debug): Likewise.
2134         * parse.c (parser_debug): Likewise.
2135         * parser-defs.h (parser_debug): Likewise.
2136         * printcmd.c (print_symbol_filename): Likewise.
2137         * proc-api.c (procfs_trace): Likewise.
2138         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2139         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2140         (set_parameter_value): Update.
2141         (add_setshow_generic): Update.
2142         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2143         to bool*.
2144         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2145         int*.
2146         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2147         * record-btrace.c (record_btrace_target::store_registers): Update.
2148         * record-full.c (record_full_memory_query): Change to bool.
2149         (record_full_stop_at_limit): Likewise.
2150         * record-full.h (record_full_memory_query): Likewise.
2151         * remote-notif.c (notif_debug): Likewise.
2152         * remote-notif.h (notif_debug): Likewise.
2153         * remote.c (use_range_stepping): Likewise.
2154         (interrupt_on_connect): Likewise.
2155         (remote_break): Likewise.
2156         * ser-tcp.c (tcp_auto_retry): Likewise.
2157         * ser-unix.c (serial_hwflow): Likewise.
2158         * skip.c (debug_skip): Likewise.
2159         * solib-aix.c (solib_aix_debug): Likewise.
2160         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2161         (spu_auto_flush_cache_p): Likewise.
2162         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2163         Likewise.
2164         (struct info_print_options) <quiet>: Likewise.
2165         * symfile-debug.c (debug_symfile): Likewise.
2166         * symfile.c (auto_solib_add): Likewise.
2167         (separate_debug_file_debug): Likewise.
2168         * symfile.h (auto_solib_add): Likewise.
2169         (separate_debug_file_debug): Likewise.
2170         * symtab.c (basenames_may_differ): Likewise.
2171         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2172         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2173         (struct info_types_options) <quiet>: Likewise.
2174         * symtab.h (demangle): Likewise.
2175         (basenames_may_differ): Likewise.
2176         * target-dcache.c (stack_cache_enabled_1): Likewise.
2177         (code_cache_enabled_1): Likewise.
2178         * target.c (trust_readonly): Likewise.
2179         (may_write_registers): Likewise.
2180         (may_write_memory): Likewise.
2181         (may_insert_breakpoints): Likewise.
2182         (may_insert_tracepoints): Likewise.
2183         (may_insert_fast_tracepoints): Likewise.
2184         (may_stop): Likewise.
2185         (auto_connect_native_target): Likewise.
2186         (target_stop_and_wait): Update.
2187         (target_async_permitted): Change to bool.
2188         (target_async_permitted_1): Likewise.
2189         (may_write_registers_1): Likewise.
2190         (may_write_memory_1): Likewise.
2191         (may_insert_breakpoints_1): Likewise.
2192         (may_insert_tracepoints_1): Likewise.
2193         (may_insert_fast_tracepoints_1): Likewise.
2194         (may_stop_1): Likewise.
2195         * target.h (target_async_permitted): Likewise.
2196         (may_write_registers): Likewise.
2197         (may_write_memory): Likewise.
2198         (may_insert_breakpoints): Likewise.
2199         (may_insert_tracepoints): Likewise.
2200         (may_insert_fast_tracepoints): Likewise.
2201         (may_stop): Likewise.
2202         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2203         (make_thread_apply_all_options_def_group): Change argument from int*
2204         to bool*.
2205         (thread_apply_all_command): Update.
2206         (print_thread_events): Change to bool.
2207         * top.c (confirm): Likewise.
2208         (command_editing_p): Likewise.
2209         (history_expansion_p): Likewise.
2210         (write_history_p): Likewise.
2211         (info_verbose): Likewise.
2212         * top.h (confirm): Likewise.
2213         (history_expansion_p): Likewise.
2214         * tracepoint.c (disconnected_tracing): Likewise.
2215         (circular_trace_buffer): Likewise.
2216         * typeprint.c (print_methods): Likewise.
2217         (print_typedefs): Likewise.
2218         * utils.c (debug_timestamp): Likewise.
2219         (sevenbit_strings): Likewise.
2220         (pagination_enabled): Likewise.
2221         * utils.h (sevenbit_strings): Likewise.
2222         (pagination_enabled): Likewise.
2223         * valops.c (overload_resolution): Likewise.
2224         * valprint.h (struct value_print_options) <prettyformat_arrays,
2225         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2226         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2227         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2228         Likewise.
2229         * windows-nat.c (new_console): Likewise.
2230         (cygwin_exceptions): Likewise.
2231         (new_group): Likewise.
2232         (debug_exec): Likewise.
2233         (debug_events): Likewise.
2234         (debug_memory): Likewise.
2235         (debug_exceptions): Likewise.
2236         (useshell): Likewise.
2237         * windows-tdep.c (maint_display_all_tib): Likewise.
2238         * xml-support.c (debug_xml): Likewise.
2239
2240 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2241
2242         * source.c (prepare_path_for_appending): New function.
2243         (openp): Make use of new function.
2244         (find_and_open_source): Search for the compilation directory and
2245         source file as a relative path beneath the directory search path.
2246
2247 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2248
2249         * source-cache.c (source_cache::get_line_charpos): Catch
2250         exceptions and return false, this matches the behaviour documented
2251         in the header file.
2252
2253 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2254
2255         * ada-tasks.c (info_task): Remove quoting of the task's name.
2256
2257 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2258
2259         * symfile.c (auto_solib_add): Replace comment with a reference
2260         to the header file.
2261
2262 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2263
2264         * NEWS: Mention that gdb can now be compiled with Python 3
2265         on Windows.
2266
2267 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2268
2269         * maint.c (maint_print_section_data::maint_print_section_data):
2270         Force use of 'float log10 (float)' by casting the argument to
2271         float.
2272
2273 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * maint.c: Add 'cmath' include.
2276         (struct maint_print_section_data): New structure.
2277         (print_section_index): New function.
2278         (print_bfd_section_info): Add header comment, small whitespace
2279         cleanup, and update to call new print_section_index function.
2280         (print_objfile_section_info): Likewise.
2281         (maint_obj_section_from_bfd_section): New function.
2282         (print_bfd_section_info_maybe_relocated): New function.
2283         (maintenance_info_sections): Add header comment, always use
2284         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2285
2286 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2287
2288         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2289         inner scope, add check that the objfile has psymtabs before
2290         checking psymtabs_addrmap.
2291         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2292
2293 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2294
2295         * NEWS: Announce that Ada task names are now shown at more places,
2296         and between quotes (except in info task output).
2297         * gdb/ada-tasks.c (task_to_str): New function.
2298         (display_current_task_id): Call task_to_str.
2299         (task_command_1): Likewise.
2300         (print_ada_task_info): In non-mi mode, Properly align headers and data
2301         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2302
2303 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2304
2305         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2306         prstatus.pr_lwp.pr_info instead of making it up.
2307
2308 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2309
2310         * auto-load.c (auto_load_expand_dir_vars): Update.
2311         * defs.h (gdb_datadir): Change to std::string.
2312         (python_libdir): Likewise.
2313         (relocate_gdb_directory): Change return type to std::string.
2314         * guile/guile.c (gdbscm_data_directory): Update.
2315         (initialize_scheme_side): Update.
2316         * jit.c (jit_reader_dir): Change to std::string.
2317         (jit_reader_load_command): Update.
2318         * main.c (gdb_datadir): Change to std::string.
2319         (python_libdir): Likewise.
2320         (set_gdb_data_directory): Update.
2321         (relocate_path): Change to return std::string.
2322         (relocate_gdb_directory): Change to return std::string.
2323         (relocate_gdbinit_path_maybe_in_datadir): Update.
2324         (captured_main_1): Update.
2325         * python/python.c (do_start_initialization): Update.
2326         * top.c (show_gdb_datadir): Update.
2327         * xml-syscall.c (xml_init_syscalls_info): Update.
2328         (init_syscalls_info): Update.
2329
2330 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2331
2332         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2333         out of get_init_files.
2334         (get_init_files): Update.
2335
2336 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2337
2338         * main.c (get_init_files): Change to use std::string.
2339         (captured_main_1): Update.
2340         (print_gdb_help): Update.
2341
2342 2019-09-11  Ali Tamur  <tamur@google.com>
2343
2344         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2345         implementation.
2346
2347 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2348
2349         * dbxread.c (read_dbx_symtab): Update.
2350         * dwarf2read.c (load_partial_dies): Update.
2351         * mdebugread.c (parse_partial_symbols): Update.
2352         (handle_psymbol_enumerators): Update.
2353         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2354         * psymtab.c (add_psymbol_to_bcache): Likewise.
2355         (add_psymbol_to_list): Likewise.
2356         * symtab.c (symbol_set_names): Likewise.
2357         * symtab.h (symbol_set_names): Likewise.
2358         * xcoffread.c (scan_xcoff_symtab): Update.
2359
2360 2019-09-11  Tom Tromey  <tom@tromey.com>
2361
2362         * symfile-mem.c (symbol_file_add_from_memory): Use
2363         bfd_set_filename.
2364         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2365         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2366
2367 2019-09-10  Tom Tromey  <tromey@adacore.com>
2368
2369         * dwarf-index-write.c (write_psymbols): Extend error message.
2370         (debug_names::insert): Add Ada code.
2371         (debug_names::write_psymbols): Remove Ada check.
2372         (debug_names) <m_string_obstack>: New member.
2373         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2374         (gdb_index_symbol_name_matcher::matches): Remove.
2375         (mapped_index_base::find_name_components_bounds): Add "lang"
2376         parameter.
2377         (mapped_index_base::build_name_components): Also split names
2378         according to Ada syntax.
2379         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2380         type of "match_callback".
2381         (check_match, check_find_bounds_finds)
2382         (dw2_expand_symtabs_matching): Update.
2383         (dw2_debug_names_iterator): Add new constructor.
2384         (dw2_debug_names_map_matching_symbols): New function.
2385         (dw2_debug_names_expand_symtabs_matching): Update.
2386         (dwarf2_debug_names_functions): Use
2387         dw2_debug_names_map_matching_symbols.
2388
2389 2019-09-10  Tom Tromey  <tromey@adacore.com>
2390
2391         * dwarf2read.c (dw2_get_file_names_reader): Add the
2392         CU's file name to the results.
2393
2394 2019-09-10  Tom Tromey  <tromey@adacore.com>
2395
2396         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2397         map_matching_symbols.  Update.
2398         * dwarf2read.c (dw2_map_matching_symbols): Update.
2399         * psymtab.c (match_partial_symbol): Change type; update.
2400         (psym_map_matching_symbols): Likewise.
2401         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2402         type; update.
2403         * symfile.h (struct quick_symbol_functions)
2404         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2405         Remove "match".
2406
2407 2019-09-10  Tom Tromey  <tromey@adacore.com>
2408
2409         * psymtab.c (map_block): Remove.
2410         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2411         * symtab.c (iterate_over_symbols_terminated): New function.
2412         * symtab.c (iterate_over_symbols_terminated): Declare.
2413
2414 2019-09-10  Tom Tromey  <tromey@adacore.com>
2415
2416         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2417         * language.h (struct language_defn) <la_iterate_over_symbols>:
2418         Return bool.
2419         * symtab.c (iterate_over_symbols): Return bool.
2420         * symtab.h (iterate_over_symbols): Return bool.
2421
2422 2019-09-10  Tom Tromey  <tromey@adacore.com>
2423
2424         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2425         (add_nonlocal_symbols): Update.
2426         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2427         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2428         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2429         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2430         Change type of "callback".  Remove "data".
2431
2432
2433 2019-09-09  Ali Tamur  <tamur@google.com>
2434
2435         * dwarf2read.c (comp_unit_head): Update comment.
2436         (dwarf2_dwo_name): New function declaration.
2437         (dwarf_unit_type_name): New function declaration.
2438         (read_comp_unit_head): Add support for new compilation units,
2439         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2440         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2441         (currently named as "signature") in their header. Also clarify error
2442         messages.
2443         (lookup_dwo_id): New function. Returns the dwo id of the given
2444         compile unit.
2445         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2446         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2447         functions.
2448         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2449         (dwarf2_dwo_name): Get the dwo name if present.
2450         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2451         purposes.
2452
2453 2019-09-09  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2456
2457 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2458
2459         * python/python.c (do_start_initialization): Make progname_copy static,
2460         to avoid a leak report.
2461
2462 2019-09-08  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2465
2466 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2467
2468         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2469         Change type to gdb::optional<block_enum>.
2470         (dw2_symtab_iter_init): Change block_index parameter type
2471         to gdb::optional<block_enum>.
2472         (dw2_lookup_symbol): Change block_index parameter
2473         type to block_enum.c
2474         (dw2_debug_names_lookup_symbol): Likewise.
2475         * psymtab.c (psym_lookup_symbol): Likewise.
2476         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2477         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2478         Likewise.
2479
2480 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2481
2482         * defs.h (relocate_gdb_directory): Change int to bool in
2483         signature and rename flag to relocatable.
2484         * main.c (relocate_path): Likewise.
2485         (relocate_gdb_directory): Likewise.
2486
2487 2019-09-06  Alan Modra  <amodra@gmail.com>
2488
2489         * coffread.c (coff_symfile_read): Constify filename variable.
2490         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2491         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2492         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2493         * solib.c (reload_shared_libraries_1): Likewise.
2494         * symfile.c (reread_symbols): Likewise.
2495         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2496         * solib-darwin.c (darwin_bfd_open): Likewise.
2497         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2498
2499 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2500
2501         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2502         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2503
2504 2019-09-03  Tom Tromey  <tromey@adacore.com>
2505
2506         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2507         types.
2508         (has_negatives): Unbias a range type bound.
2509         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2510         * gdbtypes.c (operator==): Handle new field.
2511         (create_range_type): Add "bias" parameter.
2512         (create_static_range_type, resolve_dynamic_range): Update.
2513         * gdbtypes.h (struct range_bounds) <bias>: New member.
2514         (create_range_type): Add bias parameter.
2515         * printcmd.c (print_scalar_formatted): Unbias range types.
2516         * value.c (unpack_long): Unbias range types.
2517         (pack_long): Bias range types.
2518
2519 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2522         probe arguments.
2523
2524 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2527         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2528         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2529         (compile_probe_arg): Likewise.
2530         * probe.h (get_argument_count): Likewise.
2531         * solib-svr4.c (solib_event_probe_action): Likewise.
2532         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2533
2534 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2535
2536         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2537         code to here...
2538         (svr4_create_solib_event_breakpoints): ...from here.
2539
2540 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2541
2542         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2543         suffix from warning message.
2544
2545 2019-08-30  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-winsource.h (struct tui_source_window_base)
2548         <refresh_all>: Don't declare.
2549         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2550         Remove.
2551         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2552         tui_show_locator_content.
2553         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2554         declare.
2555         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2556         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2557         declare.
2558
2559 2019-08-30  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2562
2563 2019-08-30  Tom Tromey  <tom@tromey.com>
2564
2565         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2566         Remove unnecessary forward declarations.
2567
2568 2019-08-30  Tom Tromey  <tom@tromey.com>
2569
2570         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2571         rerender.
2572         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2573         tui_show_locator_content.
2574
2575 2019-08-30  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2578         (tui_locator_window::rerender): Rewrite using body of previous
2579         tui_show_locator_content.
2580
2581 2019-08-30  Tom Tromey  <tom@tromey.com>
2582
2583         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2584         set_locator_fullname>: New methods.
2585         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2586         Rename from tui_set_locator_fullname.
2587         (tui_locator_window::set_locator_info): Rename from
2588         tui_set_locator_info.  Return bool.
2589         (tui_update_locator_fullname, tui_show_frame_info): Update.
2590
2591 2019-08-30  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2594
2595 2019-08-30  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2598         call touchwin.
2599
2600 2019-08-30  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-wingeneral.c (box_win): Assume win_info and
2603         win_info->handle cannot be NULL.
2604
2605 2019-08-30  Tom Tromey  <tom@tromey.com>
2606
2607         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2608         refresh_window>: Declare.
2609         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2610         resize.
2611         (tui_data_item_window::rerender): Rename from
2612         tui_display_register.
2613         (tui_data_item_window::refresh_window): New method.
2614         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2615         no-op.
2616
2617 2019-08-30  Tom Tromey  <tom@tromey.com>
2618
2619         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2620         regs_column_count, current_group>: Move later.  Now private.
2621         <get_current_group>: New method.
2622         * tui/tui-regs.c (tui_reg_command): Update.
2623         * tui/tui-layout.c (tui_set_layout): Update.
2624
2625 2019-08-30  Tom Tromey  <tom@tromey.com>
2626
2627         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2628         (tui_data_window::rerender): Don't call
2629         check_and_display_highlight_if_needed.
2630         (tui_data_window::refresh_all): Remove call to
2631         erase_data_content.
2632
2633 2019-08-30  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2636         (tui_data_window::display_registers_from)
2637         (tui_data_window::display_reg_element_at_line)
2638         (tui_data_window::display_registers_from_line): Remove checks of
2639         "empty".
2640
2641 2019-08-30  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2644         Don't declare.
2645         * tui/tui-regs.c (tui_data_window::show_registers): Call
2646         rerender.
2647         (tui_data_window::rerender): Rename from display_all_data.
2648         (tui_data_window::rerender): Remove old implementation.
2649
2650 2019-08-30  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2653         text.
2654         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2655
2656 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2657             Sergio Durigan Junior  <sergiodj@redhat.com>
2658
2659         PR win32/24284
2660         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2661
2662 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2663
2664         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2665         when searching for types.
2666
2667 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2668
2669         * f-lang.c (f_language_defn): Use f_print_typedef.
2670         * f-lang.h (f_print_typedef): Declare.
2671         * f-typeprint.c (f_print_typedef): Define.
2672
2673 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2674
2675         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2676
2677 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2678
2679         * cli/cli-utils.c (info_print_options_defs): Delete.
2680         (make_info_print_options_def_group): Delete.
2681         (extract_info_print_options): Delete.
2682         (info_print_command_completer): Delete.
2683         (info_print_args_help): Add extra parameter, and optionally
2684         include text about -n flag.
2685         * cli/cli-utils.h (struct info_print_options): Delete.
2686         (extract_info_print_options): Delete declaration.
2687         (info_print_command_completer): Delete declaration.
2688         (info_print_args_help): Add extra parameter, extend header
2689         comment.
2690         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2691         search_symbols.
2692         * stack.c (struct info_print_options): New type.
2693         (info_print_options_defs): New file scoped variable.
2694         (make_info_print_options_def_group): New static function.
2695         (info_print_command_completer): New static function.
2696         (info_locals_command): Update to use new local functions.
2697         (info_args_command): Likewise.
2698         (_initialize_stack): Add extra parameter to calls to
2699         info_print_args_help.
2700         * symtab.c (search_symbols): Add extra parameter, use this to
2701         possibly excluse non-debug symbols.
2702         (symtab_symbol_info): Add extra parameter, which is passed on to
2703         search_symbols.
2704         (struct info_print_options): New type.
2705         (info_print_options_defs): New file scoped variable.
2706         (make_info_print_options_def_group): New static function.
2707         (info_print_command_completer): New static function.
2708         (info_variables_command): Update to use local functions, and pass
2709         extra parameter through to symtab_symbol_info.
2710         (info_functions_command): Likewise.
2711         (info_types_command): Pass additional argument through to
2712         symtab_symbol_info.
2713         (rbreak_command): Pass extra argument to search_symbols.
2714         (_initialize_symtab): Add extra arguments for calls to
2715         info_print_args_help, and update help text for 'info variables',
2716         'whereis', and 'info functions' commands.
2717         * symtab.h (search_symbols): Add extra argument to declaration.
2718         * NEWS: Mention new flags.
2719
2720 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2721
2722         * symtab.c (lookup_static_symbol): Call the new function (and move
2723         it down to be next to lookup_global_symbol).
2724         (struct global_sym_lookup_data): Add block_enum member and rename to...
2725         (struct global_or_static_sym_lookup_data): ...this.
2726         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2727         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2728         (lookup_symbol_global_or_static_iterator_cb): ...this.
2729         (lookup_global_or_static_symbol): New function.
2730         (lookup_global_symbol): Call new function.
2731
2732 2019-08-26  Tom de Vries  <tdevries@suse.de>
2733
2734         PR c++/24852
2735         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2736         when pc_probe.prob == NULL.
2737
2738 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2739
2740         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2741         variable symbol_linkage to symbol_linkage_.
2742
2743 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2744
2745         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2746         represent whether the symbol is static, dynamic, or we don't
2747         know.
2748
2749 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2750
2751         * gdb/rx-tdep.c (rx_register_names): New.
2752         (rx_register_name): Delete.
2753         (rx_psw_type): Delete.
2754         (rx_fpsw_type): Delete.
2755         (rx_register_type): Delete.
2756         (rx_gdbarch_init): Convert target-descriptions.
2757         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2758         * gdb/features/Makefile: Add rx.xml.
2759         * gdb/features/rx.xml: New.
2760         * gdb/features/rx.c: Generated.
2761         * gdb/NEWS: Mention target description support.
2762
2763 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2764
2765         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2766         *slot_ptr.
2767
2768 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2769
2770         * configure.ac: Don't check for 'dlfcn.h' (moved to
2771         gdbsupport/common.m4).
2772         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2773         'gdbsupport/'.
2774         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2775         * compile/compile-c-support.c: Include
2776         'gdbsupport/gdb-dlfcn.h'.
2777         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2778         * gdb-dlfcn.c: Move to...
2779         * gdbsupport/gdb-dlfcn.c: ... here.
2780         * gdb-dlfcn.h: Move to...
2781         * gdbsupport/gdb-dlfcn.h: ... here.
2782
2783 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2784
2785         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2786         the offset field signed.
2787
2788 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2789
2790         * python/lib/gdb/__init__.py (_execute_file): New function.
2791         * python/python.c (python_run_simple_file): Call gdb._execute_file
2792         on Windows.
2793
2794 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2795
2796         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2797         all uses as this was never set to anything but a zero value.
2798
2799 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2800
2801         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2802
2803 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2804
2805         * tui/tui-data.h (tui_gen_win_info): Add an =default
2806         move constructor, required by some GCC versions.
2807
2808 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2809
2810         * go32-nat.c (go32_sysinfo): Add hygon_p.
2811
2812 2019-08-20  Tom Tromey  <tom@tromey.com>
2813
2814         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2815         line_from_reg_element_no, first_reg_element_no_inline,
2816         display_all_data, delete_data_content_windows,
2817         erase_data_content>: Now private.
2818
2819 2019-08-20  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2822         (tui_unhighlight_win, tui_highlight_win)
2823         (tui_win_info::make_window): Update.
2824         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2825
2826 2019-08-20  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2829         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2830         (MAX_PID_WIDTH): Move to tui-stack.c.
2831         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2832         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2833         (MAX_PID_WIDTH): Move from tui-data.h.
2834
2835 2019-08-20  Tom Tromey  <tom@tromey.com>
2836
2837         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2838         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2839         (box_win): Update.
2840         (tui_gen_win_info::make_window): Rename from tui_make_window.
2841         (tui_win_info::make_window): New method.
2842         (tui_gen_win_info::make_visible): Update.
2843         * tui/tui-source.c (tui_source_window::set_contents): Update.
2844         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2845         (tui_data_window::display_registers_from): Update.
2846         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2847         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2848         Declare.
2849         <can_box>: Remove.
2850         <title>: Remove.
2851         (struct tui_win_info) <make_window>: Declare.
2852         <can_box>: Now virtual.
2853         <title>: New member.
2854         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2855         * tui/tui-command.c (tui_cmd_window::resize): Update.
2856
2857 2019-08-20  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2860         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2861         (tui_data_window::check_register_values): Update.
2862
2863 2019-08-20  Tom Tromey  <tom@tromey.com>
2864
2865         * tui/tui-regs.h (struct tui_data_window): Use
2866         DISABLE_COPY_AND_ASSIGN.
2867         <regs_content>: Change type, removing unique_ptr.
2868         <tui_data_window>: Add move constructor.
2869         * tui/tui-regs.c (tui_data_window::show_registers)
2870         (tui_data_window::show_register_group)
2871         (tui_data_window::display_registers_from)
2872         (tui_data_window::display_registers_from)
2873         (tui_data_window::first_data_item_displayed)
2874         (tui_data_window::delete_data_content_windows)
2875         (tui_data_window::rerender, tui_data_window::refresh_window)
2876         (tui_data_window::check_register_values): Update.
2877
2878 2019-08-20  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2881         show_register_group>: Declare.
2882         (tui_show_register_group): Don't declare.
2883         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2884         tui_show_registers.
2885         (tui_data_window::show_register_group): Rename from
2886         tui_show_register_group.
2887         (tui_data_window::check_register_values, tui_reg_command):
2888         Update.
2889         * tui/tui-layout.c (tui_set_layout): Update.
2890
2891 2019-08-20  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2894         Declare.
2895         (tui_check_register_values): Don't declare.
2896         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2897         from tui_check_register_values.
2898         * tui/tui-hooks.c (tui_register_changed): Update.
2899
2900 2019-08-20  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-regs.c (tui_reg_layout): Move later.
2903         (tui_show_registers): Don't enable TUI mode or change layout.
2904
2905 2019-08-20  Tom Tromey  <tom@tromey.com>
2906
2907         * tui/tui-regs.h (struct tui_data_item_window)
2908         <~tui_data_item_window>: Remove.
2909         <content>: Now a unique_xmalloc_ptr.
2910         * tui/tui-regs.c (tui_register_format): Return a
2911         unique_xmalloc_ptr.
2912         (tui_get_register): Update.
2913         (~tui_data_item_window): Remove.
2914         (tui_data_window::display_registers_from, tui_display_register):
2915         Update.
2916         * tui/tui-io.h (tui_expand_tabs): Update.
2917         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2918         Remove "col" parameter.
2919
2920 2019-08-20  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2923         field.
2924         * tui/tui-regs.c (~tui_data_item_window): Update.
2925
2926 2019-08-20  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2929         earlier.
2930
2931 2019-08-20  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2934
2935 2019-08-20  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-source.h (struct tui_source_window): Update.
2938         * tui/tui-regs.c (tui_show_registers): Update.
2939         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2940         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2941         (NO_REGS_STRING): Remove defines.
2942
2943 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2944
2945         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2946         unnecessary thread walk if remote doesn't support the packet.
2947
2948 2019-08-19  Tom Tromey  <tromey@adacore.com>
2949
2950         * python/py-value.c (value_has_field): Fix indentation.
2951
2952 2019-08-19  Tom Tromey  <tromey@adacore.com>
2953
2954         * printcmd.c (do_one_display, info_display_command): Update.
2955         * block.h (contained_in): Return bool.  Add allow_nested
2956         parameter.
2957         * block.c (contained_in): Return bool.  Add allow_nested
2958         parameter.
2959
2960 2019-08-19  Tom Tromey  <tom@tromey.com>
2961
2962         * configure: Rebuild.
2963         * configure.ac: Disallow the combination of -static-libstdc++ and
2964         source highlight.
2965         * source-cache.c (get_language_name): Handle rust.
2966         (source_cache::get_source_lines): Ignore highlighting exceptions.
2967
2968 2019-08-16  Tom Tromey  <tom@tromey.com>
2969
2970         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2971         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2972         (struct tui_source_window_base) <make_visible, refresh_window,
2973         resize>: Remove methods.
2974         <execution_info>: Remove field.
2975         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2976         (tui_show_source_line, tui_source_window_base)
2977         (~tui_source_window_base): Update.
2978         (tui_source_window_base::resize)
2979         (tui_source_window_base::make_visible)
2980         (tui_source_window_base::refresh_window): Remove.
2981         (tui_source_window_base::update_exec_info): Update.
2982         * tui/tui-source.c (tui_source_window::set_contents): Update.
2983         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2984
2985 2019-08-16  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2988         deprecated_query_hook.
2989
2990 2019-08-16  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2993         (tui_update_source_windows_with_line): Update.
2994         * tui/tui-source.h (struct tui_source_window)
2995         <show_symtab_source>: Declare.
2996         (tui_show_symtab_source): Don't declare.
2997         * tui/tui-source.c (tui_show_symtab_source): Rename from
2998         tui_show_symtab_source.
2999
3000 2019-08-16  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-winsource.h (struct tui_source_window_base)
3003         <set_contents>: Declare.
3004         * tui/tui-winsource.c
3005         (tui_source_window_base::update_source_window_as_is): Update.
3006         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3007         Declare.
3008         (tui_set_source_content): Don't declare.
3009         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3010         tui_set_source_content.
3011         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3012         Declare.
3013         (tui_set_disassem_content): Don't declare.
3014         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3015         tui_set_disassem_content.
3016
3017 2019-08-16  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-winsource.h (struct tui_source_window_base)
3020         <update_breakpoint_info>: Declare.
3021         (tui_update_breakpoint_info): Don't declare.
3022         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3023         (tui_update_all_breakpoint_info): Update.
3024         (tui_source_window_base::update_breakpoint_info): Rename from
3025         tui_update_breakpoint_info.
3026         (tui_source_window_base::update_exec_info): Update.
3027
3028 2019-08-16  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-winsource.h (struct tui_source_window_base)
3031         <update_source_window>: Declare.
3032         (tui_update_source_window): Don't declare.
3033         * tui/tui-winsource.c
3034         (tui_source_window_base::update_source_window): Rename from
3035         tui_update_source_window.
3036         (tui_source_window_base::rerender): Update.
3037         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3038         * tui/tui-disasm.c (tui_show_disassem)
3039         (tui_show_disassem_and_update_source)
3040         (tui_disasm_window::maybe_update): Update.
3041
3042 2019-08-16  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-winsource.h (struct tui_source_window_base)
3045         <update_source_window_as_is>: Declare.
3046         (tui_update_source_window_as_is): Don't declare.
3047         * tui/tui-winsource.c (tui_update_source_window): Update
3048         (tui_source_window_base::update_source_window_as_is): Rename from
3049         tui_update_source_window_as_is.
3050         (tui_source_window_base::refill): Update.
3051         * tui/tui-source.c (tui_show_symtab_source): Update.
3052         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3053         Update.
3054
3055 2019-08-16  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-winsource.h (tui_update_source_window)
3058         (tui_update_source_window_as_is): Remove "noerror" parameter.
3059         * tui/tui-winsource.c (tui_update_source_window)
3060         (tui_update_source_window_as_is): Remove "noerror" parameter.
3061         (tui_update_source_windows_with_addr)
3062         (tui_update_source_windows_with_line)
3063         (tui_source_window_base::rerender)
3064         (tui_source_window_base::refill): Update.
3065         * tui/tui-source.h (tui_set_source_content)
3066         (tui_show_symtab_source): Remove "noerror" parameter.
3067         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3068         parameter.
3069         (tui_show_symtab_source): Likewise.
3070         (tui_source_window::maybe_update): Update.
3071         * tui/tui-disasm.c (tui_show_disassem)
3072         (tui_show_disassem_and_update_source)
3073         (tui_disasm_window::do_scroll_vertical)
3074         (tui_disasm_window::maybe_update): Update.
3075
3076 2019-08-16  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui.c (tui_is_window_visible): Update.
3079         * tui/tui-wingeneral.c (tui_make_window)
3080         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3081         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3082         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3083         (tui_set_win_height_command, parse_scrolling_args): Update.
3084         * tui/tui-source.c (tui_source_window::style_changed): Update.
3085         * tui/tui-regs.c (tui_show_registers)
3086         (tui_data_window::first_data_item_displayed)
3087         (tui_data_window::delete_data_content_windows)
3088         (tui_check_register_values, tui_reg_command): Update.
3089         * tui/tui-disasm.c (tui_show_disassem): Update.
3090         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3091         method.
3092         <is_visible>: Remove field.
3093         * tui/tui-data.c (tui_next_win, tui_prev_win)
3094         (tui_delete_invisible_windows): Update.
3095
3096 2019-08-16  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-winsource.h (struct tui_source_window_base)
3099         <m_has_locator>: Remove.
3100         * tui/tui-layout.c (show_source_disasm_command, show_data)
3101         (show_source_or_disasm_and_command): Update.
3102
3103 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3104
3105         * NEWS (Other MI changes): New subsection.
3106         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3107         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3108         * arch-utils.c (default_get_pc_address_flags): New function.
3109         * arch-utils.h (default_get_pc_address_flags): New declaration.
3110         * gdbarch.sh: Add get_pc_address_flags.
3111         * gdbarch.c: Regenerate.
3112         * gdbarch.h: Likewise.
3113         * stack.c (print_pc): New function.
3114         (print_frame_info) (print_frame): Call print_pc.
3115
3116 2019-08-16  Tom de Vries  <tdevries@suse.de>
3117
3118         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3119         print_objfile_section_info.
3120
3121 2019-08-15  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3124         calling update_cmdwin_start_line.
3125         * tui/tui-winsource.h (struct tui_source_window_base)
3126         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3127         <rerender>: Declare.
3128         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3129         Call rerender.
3130         (tui_source_window_base::set_new_height): Remove.
3131         (tui_source_window_base::rerender): Rename from
3132         do_make_visible_with_new_height.
3133         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3134         resize method.
3135         (tui_win_info::make_invisible_and_set_new_height)
3136         (tui_win_info::make_visible_with_new_height): Remove.
3137         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3138         Declare.
3139         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3140         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3141         do_make_visible_with_new_height>: Don't declare.
3142         <rerender>: Declare.
3143         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3144         set_new_height.
3145         (tui_data_window::do_make_visible_with_new_height): Remove.
3146         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3147         call tui_show_locator_content.
3148         (tui_gen_win_info::resize): Call rerender.
3149         (show_source_or_disasm_and_command): Don't call
3150         tui_show_locator_content.
3151         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3152         method.
3153         (struct tui_win_info) <rerender>: Declare.
3154         <set_new_height, make_invisible_and_set_new_height,
3155         make_visible_with_new_height>: Don't declare.
3156         * tui/tui-data.c (tui_win_list::rerender): New method.
3157         * tui/tui-command.h (struct tui_cmd_window)
3158         <do_make_visible_with_new_height>: Don't declare.
3159         * tui/tui-command.c
3160         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3161
3162 2019-08-15  Tom Tromey  <tromey@adacore.com>
3163
3164         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3165         * ada-lang.c (ada_enum_name): Likewise.
3166
3167 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3168
3169         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3170         leading underscore.
3171         (GdbOutputErrorFile): Likewise.
3172         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3173         accordingly.
3174         (execute_unwinders): Rename to have a leading underscore.
3175         (auto_load_packages): Likewise.
3176         (global scope): Adjust call to auto_load_packages accordingly.
3177         (GdbSetPythonDirectory): Likewise.
3178         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3179         instead of execute_unwinders.
3180
3181 2019-08-15  Tom Tromey  <tom@tromey.com>
3182
3183         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3184         (show_data): Don't change window visibility.
3185         (tui_gen_win_info::resize): Remove special case for command
3186         window.  Use wresize, when available.
3187         (show_source_or_disasm_and_command): Don't change window
3188         visibility.
3189         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3190         <make_visible>: New method.
3191         * tui/tui-command.c (tui_cmd_window::resize): New method.
3192
3193 2019-08-15  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3196         (struct tui_source_windows): New.
3197         * tui/tui-winsource.c (tui_display_main): Update.
3198         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3199         (new_height_ok, parse_scrolling_args): Update.
3200         * tui/tui-layout.c (show_layout, show_data): Update.
3201         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3202         (tui_add_to_source_windows): Don't declare.
3203         * tui/tui-data.c (source_windows, tui_source_windows)
3204         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3205
3206 2019-08-15  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3209         Rename from reset.
3210         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3211         * tui/tui-layout.c (show_source_disasm_command, show_data):
3212         Update.
3213         (tui_gen_win_info::resize): Rename.
3214         (show_source_or_disasm_and_command): Update.
3215         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3216         reset.
3217
3218 2019-08-15  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3221         * tui/tui-interp.c (tui_interp::init): Don't call
3222         tui_initialize_static_data.
3223         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3224
3225 2019-08-15  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3228         examine tui_win_list.
3229
3230 2019-08-15  Tom Tromey  <tom@tromey.com>
3231
3232         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3233         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3234         tui_clear_source_content.
3235         (tui_clear_source_content): Remove.
3236         (tui_source_window_base::do_erase_source_content): Hoist call to
3237         content.clear().
3238         * tui/tui-stack.c (tui_show_frame_info): Don't call
3239         tui_clear_source_content.
3240
3241 2019-08-15  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-winsource.h (struct tui_source_window_base)
3244         <do_erase_source_content>: New method.
3245         <erase_source_content>: New method.
3246         (tui_erase_source_content): Don't declare.
3247         * tui/tui-winsource.c (tui_clear_source_content): Update.
3248         (tui_source_window_base::do_erase_source_content): Rename from
3249         tui_erase_source_content.
3250         (tui_source_window_base::show_source_content): Update.
3251         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3252         * tui/tui-source.h (struct tui_source_window)
3253         <erase_source_content>: New method.
3254         * tui/tui-disasm.h (struct tui_disasm_window)
3255         <erase_source_content>: New method.
3256
3257 2019-08-15  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3260         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3261         constructor.
3262         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3263         * tui/tui-source.c (tui_set_source_content): Update.
3264         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3265
3266 2019-08-15  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3269         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3270         tui-source.c.
3271         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3272         Declare.
3273         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3274         method.
3275         (tui_source_window::maybe_update): Update.
3276
3277 2019-08-15  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3280         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3281         tui-disasm.c.
3282         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3283         Declare.
3284         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3285         method.
3286         (tui_disasm_window::maybe_update): Update.
3287
3288 2019-08-15  Tom Tromey  <tom@tromey.com>
3289
3290         * tui/tui-winsource.h (struct tui_source_window_base)
3291         <maybe_update>: Declare.
3292         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3293         method.
3294         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3295         Declare.
3296         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3297         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3298         Declare.
3299         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3300
3301 2019-08-15  Tom Tromey  <tom@tromey.com>
3302
3303         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3304
3305 2019-08-15  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-wingeneral.c: Include tui-stack.h.
3308         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3309         (struct tui_locator_window): Move from tui-data.h.
3310         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3311         (tui_initialize_static_data): Move from tui-data.c.
3312         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3313         (struct tui_locator_window): Move to tui-stack.c.
3314         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3315         (tui_initialize_static_data): Move to tui-stack.c.
3316
3317 2019-08-15  Tom Tromey  <tom@tromey.com>
3318
3319         * tui/tui-layout.c (show_source_disasm_command)
3320         (show_source_or_disasm_and_command): Use make_visible method, not
3321         tui_make_window.
3322         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3323         Remove.
3324
3325 2019-08-15  Tom Tromey  <tom@tromey.com>
3326
3327         * tui/tui-wingeneral.h (tui_make_window): Update.
3328         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3329         parameter.
3330         (tui_gen_win_info::make_visible): Update.
3331         * tui/tui-regs.c (tui_data_window::display_registers_from):
3332         Update.
3333         * tui/tui-layout.c (show_source_disasm_command)
3334         (show_source_or_disasm_and_command): Update.
3335         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3336         (enum tui_box): Remove.
3337         (struct tui_win_info) <can_box>: New method.
3338         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3339         method.
3340
3341 2019-08-15  Tom de Vries  <tdevries@suse.de>
3342
3343         * linux-nat-trad.c: Include gdbarch.h.
3344
3345 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3346
3347         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3348         register sizes.
3349
3350 2019-08-14  Tom Tromey  <tromey@adacore.com>
3351
3352         * darwin-nat.c: Include gdbarch.h.
3353         * darwin-nat-info.c: Include gdbarch.h.
3354
3355 2019-08-13  Tom Tromey  <tom@tromey.com>
3356
3357         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3358         Remove.
3359         * tui/tui-data.c (tui_initialize_static_data): Update.
3360
3361 2019-08-13  Tom Tromey  <tom@tromey.com>
3362
3363         * tui/tui-winsource.h (struct tui_exec_info_window)
3364         <~tui_exec_info_window, maybe_allocate_content, get_content,
3365         m_content>: Remove.
3366         (struct tui_source_window_base) <set_exec_info_content,
3367         show_exec_info_content>: Don't declare.
3368         * tui/tui-winsource.c
3369         (tui_exec_info_window::maybe_allocate_content): Remove.
3370         (tui_source_window_base::update_exec_info): Rename from
3371         set_exec_info_content.
3372         (tui_source_window_base::show_exec_info_content)
3373         (tui_source_window_base::update_exec_info): Remove.
3374
3375 2019-08-13  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3378         declare.
3379         * tui/tui-winsource.c (tui_update_source_window_as_is)
3380         (tui_update_source_windows_with_addr, tui_erase_source_content):
3381         Update.
3382         (tui_clear_exec_info_content): Remove.
3383
3384 2019-08-13  Tom Tromey  <tom@tromey.com>
3385
3386         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3387         declare.
3388         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3389         call tui_erase_exec_info_content.
3390         (tui_clear_exec_info_content): Rename from
3391         tui_erase_exec_info_content.
3392         (tui_clear_exec_info_content): Delete.
3393
3394 2019-08-13  Tom Tromey  <tom@tromey.com>
3395
3396         * tui/tui-winsource.h (struct tui_source_window_base)
3397         <show_exec_info_content>: Declare.
3398         (tui_show_exec_info_content): Don't declare.
3399         * tui/tui-winsource.c
3400         (tui_source_window_base::show_exec_info_content): Rename from
3401         tui_show_exec_info_content.
3402         (tui_source_window_base::update_exec_info): Update.
3403
3404 2019-08-13  Tom Tromey  <tom@tromey.com>
3405
3406         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3407         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3408         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3409         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3410         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3411         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3412         ... here.
3413
3414 2019-08-13  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-winsource.h (struct tui_source_window_base)
3417         <update_exec_info>: Declare.
3418         (tui_update_exec_info): Don't declare.
3419         * tui/tui-winsource.c (tui_update_source_window_as_is)
3420         (tui_source_window_base::refresh_all)
3421         (tui_update_all_breakpoint_info): Update.
3422         (tui_source_window_base::update_exec_info): Rename from
3423         tui_update_exec_info.
3424         * tui/tui-stack.c (tui_show_frame_info): Update.
3425
3426 2019-08-13  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-winsource.h (struct tui_source_window_base)
3429         <set_exec_info_content>: Declare.
3430         (tui_set_exec_info_content): Don't declare.
3431         * tui/tui-winsource.c
3432         (tui_source_window_base::set_exec_info_content): Rename from
3433         tui_set_exec_info_content.
3434         (tui_update_exec_info): Update.
3435
3436 2019-08-13  Tom Tromey  <tom@tromey.com>
3437
3438         * tui/tui-winsource.h (struct tui_source_window_base)
3439         <show_source_content>: Declare.
3440         (tui_show_source_content): Don't declare.
3441         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3442         (tui_source_window_base::show_source_content): Rename from
3443         tui_show_source_content.
3444         (tui_source_window_base::refresh_all): Update.
3445         * tui/tui-layout.c (show_source_disasm_command)
3446         (show_source_or_disasm_and_command): Update.
3447
3448 2019-08-13  Tom Tromey  <tom@tromey.com>
3449
3450         * tui/tui-winsource.c (tui_erase_source_content)
3451         (tui_show_source_content, tui_source_window_base::refresh_all):
3452         Update.
3453         * tui/tui-wingeneral.h
3454         (tui_check_and_display_highlight_if_needed): Don't declare.
3455         * tui/tui-wingeneral.c
3456         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3457         check_and_display_highlight_if_needed.
3458         * tui/tui-win.c (tui_rehighlight_all)
3459         (tui_win_info::make_visible_with_new_height): Update.
3460         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3461         (tui_data_window::erase_data_content)
3462         (tui_data_window::display_all_data): Update.
3463         * tui/tui-data.h (struct tui_win_info)
3464         <check_and_display_highlight_if_needed>: Declare.
3465
3466 2019-08-13  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-win.c (tui_resize_all): Call
3469         tui_delete_invisible_windows.
3470         * tui/tui-layout.c (show_layout): Call
3471         tui_delete_invisible_windows.
3472         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3473         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3474
3475 2019-08-13  Tom Tromey  <tom@tromey.com>
3476
3477         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3478         tui_add_win_to_layout.
3479
3480 2019-08-13  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3483         * tui/tui-layout.c (tui_default_win_height): Now static.
3484
3485 2019-08-13  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3488         single switch.
3489         (show_source_disasm_command, show_source_or_disasm_and_command):
3490         Don't check current layout.
3491
3492 2019-08-13  Tom Tromey  <tom@tromey.com>
3493
3494         * tui/tui-wingeneral.c (make_all_visible): Remove.
3495         (tui_make_all_invisible): Simplify.
3496         * tui/tui-layout.c (tui_make_all_invisible): Move from
3497         tui-wingeneral.c; simplify.
3498         (show_layout): Hoist call to tui_make_all_invisible.
3499         (show_data): Don't call tui_make_all_invisible.
3500
3501 2019-08-13  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3504         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3505
3506 2019-08-13  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3509         tui-data.c.
3510         (show_source_disasm_command, show_data)
3511         (show_source_or_disasm_and_command): Don't use
3512         tui_set_current_layout_to.
3513         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3514         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3515         tui-layout.c.
3516         (tui_set_current_layout_to): Remove.
3517
3518 2019-08-13  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-layout.c (tui_set_layout): Update.
3521         * tui/tui-data.h (struct tui_layout_def): Remove.
3522         (tui_layout_def): Don't declare.
3523         * tui/tui-data.c (layout_def): Remove.
3524         (tui_layout_def): Remove.
3525
3526 2019-08-13  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-winsource.h (struct tui_source_window_base)
3529         <clear_detail>: No longer "override".
3530         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3531         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3532         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3533         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3534         Remove.
3535         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3536
3537 2019-08-13  Tom Tromey  <tromey@adacore.com>
3538
3539         * tracepoint.c: Don't include readline.h or history.h.
3540
3541 2019-08-12  Tom Tromey  <tom@tromey.com>
3542
3543         * configure: Rebuild.
3544         * configure.ac: Check for readline 7.
3545         * NEWS: Mention readline 7 requirement.
3546         * README: Update.
3547
3548 2019-08-12  Tom Tromey  <tom@tromey.com>
3549
3550         * mingw-hdep.c (gdb_select): Remove readline hack.
3551
3552 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3553
3554         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3555         when the function fails.
3556
3557 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3558
3559         * s390-tdep.c (s390_type_align): New function.
3560         (s390_gdbarch_init): Set it as type_align gdbarch method.
3561
3562 2019-08-09  Tom de Vries  <tdevries@suse.de>
3563
3564         PR gdb/24591
3565         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3566         pc_low with relocation offset.
3567
3568 2019-08-07  Tom Tromey  <tromey@adacore.com>
3569
3570         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3571         (print_frame_args): Update.
3572         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3573         Update.
3574         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3575         * frame.h (struct frame_arg): Add initializers.
3576         <error>: Now a unique_xmalloc_ptr.
3577
3578 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3579
3580         * NEWS: Expand the Pointer Authentication entry.
3581         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3582         (aarch64_frame_unmask_lr): ... to this.
3583         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3584         Call aarch64_frame_unmask_lr.
3585         * frame.c (struct frame_info): Add "masked" variable.
3586         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3587         (fprint_frame): Check for masked pc.
3588         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3589         declarations.
3590         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3591         * stack.c (print_frame): Check for masked pc.
3592
3593 2019-08-06  Tom Tromey  <tom@tromey.com>
3594
3595         * stabsread.c (patch_block_stabs, read_one_struct_field)
3596         (read_enum_type): Use obstack_strndup.
3597         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3598         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3599         * dwarf2read.c (guess_full_die_structure_name)
3600         (anonymous_struct_prefix): Use obstack_strndup.
3601         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3602         * c-exp.y (yylex): Use obstack_strndup.
3603         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3604         (write_var_or_type): Use obstack_strndup.
3605
3606 2019-08-06  Tom Tromey  <tom@tromey.com>
3607
3608         * symfile.c (reread_symbols): Use obstack_strdup.
3609         * stabsread.c (read_type): Use obstack_strdup.
3610         * gdb_obstack.h (obstack_strdup): New overload.
3611         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3612         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3613         (dwarf2_canonicalize_name): Use obstack_strdup.
3614         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3615         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3616         Use obstack_strdup.
3617
3618 2019-08-06  Tom Tromey  <tom@tromey.com>
3619
3620         * gdb_obstack.h (obstack_strdup): Define.
3621         * gdb_obstack.c (obstack_strdup): Don't define.
3622
3623 2019-08-06  Tom Tromey  <tom@tromey.com>
3624
3625         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3626         obstack_strdup.
3627         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3628         obstack_strdup.
3629         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3630         * stabsread.c (common_block_start): Use obstack_strdup.
3631         * objfiles.c (set_objfile_main_name, objfile): Use
3632         obstack_strdup.
3633         * namespace.c (add_using_directive): Use obstack_strdup.
3634         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3635         * jit.c (finalize_symtab): Use obstack_strdup.
3636         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3637         (guess_partial_die_structure_name, partial_die_info::fixup)
3638         (dwarf2_name): Use obstack_strdup.
3639         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3640         obstack_strdup.
3641         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3642         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3643         obstack_strdup.
3644         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3645
3646 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3647
3648         * unittests/help-doc-selftests.c: New file.
3649         * Makefile.in: Add the new file.
3650
3651 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3652
3653         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3654         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3655         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3656         the trailing '.' is not output, and the first character is uppercased.
3657         (print_help_for_command): Update call to print_doc_line.
3658         (print_doc_of_command): Likewise.
3659         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3660         * cli/cli-option.c (append_indented_doc): Do not append newline.
3661         (build_help_option): Append newline after first appended_indented_doc
3662         only if a second call is done.
3663         (build_help): Append 2 new lines before each option, except the first
3664         one.
3665         * compile/compile.c (_initialize_compile): Add new lines after
3666         %OPTIONS%, when not at the end of the help.
3667         Change help doc or code
3668         producing the help doc to respect the invariants.
3669         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3670         Also removed the new line after 'Options:', as all other commands
3671         do not put an empty line between 'Options:' and the first option.
3672         * printcmd.c (_initialize_printcmd): Likewise.
3673         * stack.c (_initialize_stack): Likewise.
3674         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3675         incorrectly telling COMMAND is optional.
3676         * ada-lang.c (_initialize_ada_language): Change help doc or code
3677         producing the help doc to respect the invariants.
3678         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3679         * breakpoint.c (_initialize_breakpoint): Likewise.
3680         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3681         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3682         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3683         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3684         _initialize_cli_style): Likewise.
3685         * corelow.c (core_target_info): Likewise.
3686         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3687         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3688         * filesystem.c (_initialize_filesystem): Likewise.
3689         * frame.c (_initialize_frame): Likewise.
3690         * gnu-nat.c (add_task_commands): Likewise.
3691         * infcall.c (_initialize_infcall): Likewise.
3692         * infcmd.c (_initialize_infcmd): Likewise.
3693         * interps.c (_initialize_interpreter): Likewise.
3694         * language.c (_initialize_language): Likewise.
3695         * linux-fork.c (_initialize_linux_fork): Likewise.
3696         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3697         * maint.c (_initialize_maint_cmds): Likewise.
3698         * memattr.c (_initialize_mem): Likewise.
3699         * printcmd.c (_initialize_printcmd): Likewise.
3700         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3701         _RegEx): Likewise.
3702         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3703         * record-btrace.c (_initialize_record_btrace): Likewise.
3704         * record-full.c (_initialize_record_full): Likewise.
3705         * record.c (_initialize_record): Likewise.
3706         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3707         * regcache.c (_initialize_regcache): Likewise.
3708         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3709         _initialize_remote): Likewise.
3710         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3711         * serial.c (_initialize_serial): Likewise.
3712         * skip.c (_initialize_step_skip): Likewise.
3713         * source.c (_initialize_source): Likewise.
3714         * stack.c (_initialize_stack): Likewise.
3715         * symfile.c (_initialize_symfile): Likewise.
3716         * symtab.c (_initialize_symtab): Likewise.
3717         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3718         * top.c (init_main): Likewise.
3719         * tracefile-tfile.c (tfile_target_info): Likewise.
3720         * tracepoint.c (_initialize_tracepoint): Likewise.
3721         * tui/tui-win.c (_initialize_tui_win): Likewise.
3722         * utils.c (add_internal_problem_command): Likewise.
3723         * valprint.c (value_print_option_defs): Likewise.
3724
3725 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3726
3727         PR build/24886
3728         * configure.ac: Drop enable-libmcheck support.
3729         * configure, config.in: Rebuild.
3730         * libmcheck.m4: Remove.
3731         * acinclude.m4: Don't include it.
3732         * Makefile.in: Don't distribute it.
3733         * top.c (print_gdb_configuration): Don't mention it.
3734
3735 2019-08-06  Tom Tromey  <tom@tromey.com>
3736
3737         * utils.c (set_output_style): Sometimes pass stream to
3738         emit_style_escape.
3739         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3740         * record-btrace.c (btrace_insn_history): Update.
3741         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3742         method.
3743         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3744         Update initializers.
3745         <m_uiout>: New field.
3746         <m_di>: Move lower.
3747         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3748         Remove "uiout" parameter.
3749         (dump_insns): Update.
3750         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3751         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3752
3753 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3754
3755         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3756         (error_in_psymtab_expansion): Likewise.
3757         (lookup_symbol_via_quick_fns): Likewise.
3758         (basic_lookup_transparent_type_quick): Likewise.
3759         (basic_lookup_transparent_type_1): Likewise.
3760
3761 2019-08-06  Tom Tromey  <tromey@adacore.com>
3762
3763         * source.c (last_source_error): Now bool.
3764         (print_source_lines_base): Make "noprint" bool.  Only open
3765         source file when last_source_visited changes.
3766
3767 2019-08-06  Tom Tromey  <tromey@adacore.com>
3768
3769         * annotate.c (annotate_source_line): Use g_source_cache.
3770         * source-cache.c (source_cache::get_plain_source_lines): Change
3771         parameters.  Populate m_offset_cache.
3772         (source_cache::ensure): New method.
3773         (source_cache::get_line_charpos): New method.
3774         (extract_lines): Move lower.  Change parameters.
3775         (source_cache::get_source_lines): Move lower.
3776         * source-cache.h (class source_cache): Update comment.
3777         <get_line_charpos>: New method.
3778         <get_source_lines>: Update comment.
3779         <clear>: Clear m_offset_cache.
3780         <get_plain_source_lines>: Change parameters.
3781         <ensure>: New method
3782         <m_offset_cache>: New member.
3783         * source.c (forget_cached_source_info_for_objfile): Update.
3784         (info_source_command): Use g_source_cache.
3785         (find_source_lines, open_source_file_with_line_charpos): Remove.
3786         (print_source_lines_base, search_command_helper): Use g_source_cache.
3787         * source.h (open_source_file_with_line_charpos): Don't declare.
3788         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3789         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3790         Use g_source_cache.
3791
3792 2019-08-06  Tom Tromey  <tromey@adacore.com>
3793
3794         * source-cache.c (source_cache::get_plain_source_lines):
3795         Remove "first_line" and "last_line" parameters.
3796         (source_cache::get_source_lines): Cache plain text.
3797         * source-cache.h (class source_cache)
3798         <get_plain_source_lines>: Update.
3799
3800 2019-08-06  Tom Tromey  <tromey@adacore.com>
3801
3802         * source-cache.c (extract_lines): No longer a method.
3803         Changed type of parameter.  Include final newline.
3804         (selftests::extract_lines_test): New function.
3805         (_initialize_source_cache): Likewise.
3806         * source-cache.h (class source_cache)
3807         <extract_lines>: Don't declare.
3808
3809 2019-08-06  Tom Tromey  <tromey@adacore.com>
3810
3811         * breakpoint.c (init_breakpoint_sal): Update.
3812         (breakpoint): Update.
3813         * breakpoint.h (struct breakpoint) <filter>: Now a
3814         unique_xmalloc_ptr.
3815
3816 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3817
3818         * NEWS: Mention dictionary access on blocks.
3819         * python/py-block.c (blpy_getitem): New function.
3820         (block_object_as_mapping): New struct.
3821         (block_object_type): Use new struct for tp_as_mapping field.
3822
3823 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3824
3825         * objfiles.h (objfile): Add a comment describing partial symbols.
3826
3827 2019-08-05  Tom Tromey  <tromey@adacore.com>
3828
3829         * compile/compile.c (_initialize_compile): Use _(), not N_().
3830         * thread.c (_initialize_thread): Use _(), not N_().
3831         * stack.c (_initialize_stack): Use _(), not N_().
3832         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3833
3834 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3835
3836         * dwarf2read.c (struct dw2_symtab_iterator):
3837         <want_specific_block>: Remove.
3838         <block_index>: Change type to gdb::optional.
3839         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3840         change type of BLOCK_INDEX parameter to gdb::optional.
3841         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3842         (dw2_lookup_symbol): Don't pass argument for
3843         WANT_SPECIFIC_BLOCK.
3844         (dw2_expand_symtabs_for_function): Don't pass argument for
3845         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3846         (class dw2_debug_names_iterator)
3847         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3848         parameter, change BLOCK_INDEX type to gdb::optional.
3849         <m_want_specific_block>: Remove.
3850         <m_block_index>: Change type to gdb::optional.
3851         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3852         gdb::optional.  Re-write in function of gdb::optional.
3853         (dw2_debug_names_lookup_symbol): Don't pass argument for
3854         WANT_SPECIFIC_BLOCK.
3855         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3856         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3857         BLOCK_INDEX.
3858
3859 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3860
3861         * NEWS: Mention changes to "info sources" command.
3862
3863 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3864
3865         * symtab.c (filename_partial_match_opts): New struct type.
3866         (struct output_source_filename_data): New members
3867         regexp, c_regexp, partial_match.
3868         (output_source_filename): Use new members to decide to print file.
3869         (info_sources_option_defs): New variable.
3870         (make_info_sources_options_def_group, print_info_sources_header,
3871         info_sources_command_completer):
3872         New functions.
3873         (info_sources_command): Read new optional arguments.
3874         (_initialize_symtab): Update info sources help.
3875
3876 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3877
3878         * ada-lang.c (exception_support_info_v0): Renamed from...
3879         (default_exception_support_info): ... this.  Create new
3880         definition for v1.
3881         (ada_has_this_exception_support): Look up catch_handlers_sym.
3882         (ada_exception_support_info_sniffer): Try v0 after default.
3883
3884 2019-08-01  Tom Tromey  <tromey@adacore.com>
3885
3886         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3887         gdbarch.h.
3888
3889 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3890
3891         * s12z-tdep.c: Fix include path for s12z-opc.h.
3892
3893 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3894
3895         * NEWS: Require GNU make 3.82.
3896
3897 2019-07-16  Tom Tromey  <tom@tromey.com>
3898
3899         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3900         declare.
3901
3902 2019-07-30  Tom Tromey  <tromey@adacore.com>
3903
3904         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3905
3906 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3907
3908         * printcmd.c (print_address_symbolic): Print negative offsets.
3909         (build_address_symbolic): Force signed arithmetic when computing
3910         offset.
3911
3912 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3913
3914         PR/24474: Add a function to lookup static variables.
3915         * NEWS: Mention this new function.
3916         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3917         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3918         * python/python.c (python_GdbMethods): Add new function.
3919
3920 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3921
3922         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3923         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3924         (objfpy_lookup_static_symbol): New function.
3925         (objfile_object_methods): Add new functions.
3926
3927 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3928
3929         * NEWS: Mention 'set|show print frame-info'.  Mention new
3930         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3931         backtrace argument.  Mention that python frame filtering code
3932         is now consistent with what 'backtrace' command prints.
3933
3934 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3935
3936         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3937         comments.
3938         (print_frame_info_auto, print_frame_info_source_line,
3939         print_frame_info_location, print_frame_info_source_and_location,
3940         print_frame_info_location_and_address, print_frame_info_short_location):
3941         New declarations.
3942         (struct frame_print_options): New member print_frame_info.
3943         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3944         * stack.h (get_user_print_what_frame_info): New declaration.
3945         (frame_show_address): New declaration.
3946         * stack.c (print_frame_arguments_choices): New value 'presence'.
3947         (print_frame_info_auto, print_frame_info_source_line,
3948         print_frame_info_location, print_frame_info_source_and_location,
3949         print_frame_info_location_and_address, print_frame_info_short_location,
3950         print_frame_info_choices, print_frame_info_print_what): New definitions.
3951         (print_frame_args): Only print dots for args if print frame-arguments
3952         is 'presence'.
3953         (frame_print_option_defs): New element for "frame-info".
3954         (get_user_print_what_frame_info): New function.
3955         (frame_show_address): Make non static.  Move comment to stack.h.
3956         (print_frame_info_to_print_what): New function.
3957         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3958         to decide what to print.
3959         (backtrace_command_1): Handle the new print_frame_arguments_presence
3960         value.
3961         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3962         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3963         (py_print_frame): In non-mi mode, use LOCATION as default for
3964         print_what, similarly to frame information printed directly by
3965         backtrace command. Handle frame-info user option in non MI mode.
3966
3967 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3968
3969         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3970         Add case for debugging 32-bit target on 64-bit host.  Revise
3971         comment.
3972
3973 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3974
3975         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3976         instead of find_function_entry_range_from_pc.
3977
3978 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3979
3980         * stack.c (find_frame_funname): Remove code which preferred
3981         minsym over symtab sym in "certain pathological cases".
3982
3983         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3984         parameter.  Change type of "do_demangle" to bool.
3985         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3986         Pass suitable "prefer_sym_over_minsym" flag to
3987         build_address_symbolic().  Don't output "+" for negative offsets.
3988         * printcmd.c (print_address_symbolic): Update invocation of
3989         build_address_symbolic to include a "prefer_sym_over_minsym"
3990         flag.
3991         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3992         Restrict cases in which use of minimal symbol is preferred to that
3993         of a found symbol.  Update comments.
3994
3995         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3996         for entry pc when entry pc is out of range for that FDE.
3997
3998 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3999
4000         PR gdb/24839:
4001         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4002         type.
4003
4004 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4005
4006         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4007         this function's Python signature.
4008
4009
4010 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4011
4012         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4013         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4014         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4015         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4016         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4017
4018
4019 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4020
4021         * h8300-tdep.c (h8300_register_name_common): New.
4022         h8300_register_name): Use h8300_register_name_common.
4023         (h8300s_register_name): Likewise.
4024         (h8300sx_register_name): Likewise.
4025         (h8300h_register_nam): New.
4026         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4027
4028
4029 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4030
4031         * arm-tdep.c (arm_skip_cmse_entry): New function.
4032         (arm_is_sgstubs_section): New function.
4033         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4034
4035 2019-07-22  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4038         Don't self-assign.
4039
4040 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4041
4042         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4043         type_print.
4044
4045 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4048         so that GDB doesn't match any msymbols when searching in the
4049         TYPES_DOMAIN.
4050         (print_symbol_info): Print using typedef_print or type_print based
4051         on the type of the symbol.  Add updated FIXME comment moved from...
4052         (_initialize_symtab): ... move and update FIXME comment to above.
4053
4054 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4055
4056         * NEWS: Mention adding -q option to "info types".
4057         * symtab.c (struct info_types_options): New struct.
4058         (info_types_options_defs): New variable.
4059         (make_info_types_options_def_group): New function.
4060         (info_types_command): Use gdb::option framework to parse options.
4061         (info_types_command_completer): New function.
4062         (_initialize_symtab): Extend the help text on "info types" and
4063         register command completer.
4064
4065 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4066
4067         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4068         (lookup_symbol_in_objfile): Change int to block_enum and add a
4069         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4070
4071 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4072
4073         * MAINTAINERS (Write After Approval): Add self.
4074
4075 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4076
4077         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4078         instruction to the dummy code region.
4079
4080 2019-07-19  Tom Tromey  <tromey@adacore.com>
4081
4082         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4083         (ARGSUSED, PARAMS, __func__): Remove rules.
4084
4085 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4086
4087         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4088         * features/arm/arm-with-iwmmxt.c: Remove.
4089         * features/arm/arm-with-iwmmxt.xml: Remove.
4090         * features/arm/arm-with-m-fpa-layout.c: Remove.
4091         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4092         * features/arm/arm-with-m-vfp-d16.c: Remove.
4093         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4094         * features/arm/arm-with-m.c: Remove.
4095         * features/arm/arm-with-m.xml: Remove.
4096         * features/arm/arm-with-neon.c: Remove.
4097         * features/arm/arm-with-neon.xml: Remove.
4098         * features/arm/arm-with-vfpv2.c: Remove.
4099         * features/arm/arm-with-vfpv2.xml: Remove.
4100         * features/arm/arm-with-vfpv3.c: Remove.
4101         * features/arm/arm-with-vfpv3.xml: Remove.
4102
4103 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4104
4105         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4106
4107 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4108
4109         * arch/aarch32.c (aarch32_create_target_description): Create
4110         target descriptions using features.
4111         * arch/arm.c (arm_create_target_description)
4112         (arm_create_mprofile_target_description): Likewise.
4113         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4114
4115 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4116
4117         * Makefile.in: Add new files.
4118         * aarch32-tdep.c: New file.
4119         * aarch32-tdep.h: New file.
4120         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4121         Call aarch32_read_description.
4122         * arch/aarch32.c: New file.
4123         * arch/aarch32.h: New file.
4124         * arch/arm.c (arm_create_target_description)
4125         (arm_create_mprofile_target_description): New function.
4126         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4127         (arm_create_target_description)
4128         (arm_create_mprofile_target_description): New declaration.
4129         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4130         read_description functions.
4131         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4132         Likewise.
4133         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4134         * arm-tdep.c (tdesc_arm_list): New variable.
4135         (arm_register_g_packet_guesses): Call create description functions.
4136         (arm_read_description) (arm_read_mprofile_description): New
4137         function.
4138         * arm-tdep.h (arm_read_description)
4139         (arm_read_mprofile_description): Add declaration.
4140         * configure.tgt: Add new files.
4141
4142 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4143
4144         * top.c (new_ui_command): Open specified terminal just once.
4145
4146 2019-07-18  Tom Tromey  <tromey@adacore.com>
4147
4148         * symtab.c (main_name): Constify return type.
4149         * symfile.c (set_initial_language): Update.
4150         * symtab.h (main_name): Constify return type.
4151
4152 2019-07-17  Tom Tromey  <tom@tromey.com>
4153
4154         * tui/tui-winsource.c (tui_update_source_window)
4155         (tui_update_source_window_as_is)
4156         (tui_update_source_windows_with_line): Remove return.
4157         * tui/tui-disasm.c (tui_show_disassem)
4158         (tui_show_disassem_and_update_source): Remove return.
4159         * tui/tui.c (tui_reset): Remove return.
4160         * tui/tui-wingeneral.c
4161         (tui_check_and_display_highlight_if_needed): Remove return.
4162
4163 2019-07-17  Tom Tromey  <tom@tromey.com>
4164
4165         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4166
4167 2019-07-17  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-winsource.h (struct tui_exec_info_window)
4170         (struct tui_source_window_base): Move from tui-data.h.
4171         * tui/tui-winsource.c: Move many method definitions from
4172         elsewhere.  Remove "structuring" comments.
4173         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4174         (tui_source_window_base::refresh_window): Move to
4175         tui-winsource.c.
4176         * tui/tui-win.c (tui_source_window_base::refresh_all)
4177         (tui_source_window_base::update_tab_width)
4178         (tui_source_window_base::set_new_height)
4179         (tui_source_window_base::do_make_visible_with_new_height): Move to
4180         tui-winsource.c.
4181         * tui/tui-source.h: Update.
4182         * tui/tui-source.c (tui_source_window_base::reset): Move to
4183         tui-winsource.c.
4184         * tui/tui-disasm.h: Update.
4185         * tui/tui-data.h (struct tui_exec_info_window): Move to
4186         tui-winsource.h.
4187         (struct tui_source_window_base): Likewise.
4188         * tui/tui-data.c (tui_source_window_base::clear_detail)
4189         (tui_source_window_base, ~tui_source_window_base): Move to
4190         tui-winsource.c.
4191
4192 2019-07-17  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-win.c (tui_resize_all)
4195         (tui_source_window_base::update_tab_width)
4196         (tui_adjust_win_heights): Update.
4197         (tui_win_info::make_invisible_and_set_new_height): Rename from
4198         make_invisible_and_set_new_height.
4199         * tui/tui-data.h (struct tui_win_info)
4200         <make_invisible_and_set_new_height>: New method.
4201
4202 2019-07-17  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui.c: Update.
4205         * tui/tui-source.h (struct tui_source_window): Move from
4206         tui-data.h.
4207         * tui/tui-layout.c: Update.
4208         * tui/tui-disasm.c: Update.
4209         * tui/tui-data.h (struct tui_source_window): Move to
4210         tui-source.h.
4211
4212 2019-07-17  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4215         tui-data.h.
4216         * tui/tui-data.h (struct tui_disasm_window): Move to
4217         tui-disasm.h.
4218
4219 2019-07-17  Tom Tromey  <tom@tromey.com>
4220
4221         * tui/tui-regs.h (struct tui_data_item_window): Move from
4222         tui-data.h.
4223         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4224         * tui/tui-data.h (struct tui_data_item_window): Move to
4225         tui-regs.h.
4226         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4227
4228 2019-07-17  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui.c: Update.
4231         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4232         (tui_cmd_window::max_height): Move to tui-command.c.
4233         * tui/tui-layout.c: Update.
4234         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4235         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4236         tui-command.c.
4237         * tui/tui-command.h (struct tui_cmd_window): Move from
4238         tui-data.h.
4239         * tui/tui-command.c: Remove "structuring" comments.
4240         (tui_cmd_window::clear_detail)
4241         (tui_cmd_window::do_make_visible_with_new_height)
4242         (tui_cmd_window::max_height): Move from elsewhere.
4243
4244 2019-07-17  Tom Tromey  <tom@tromey.com>
4245
4246         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4247         Now static.
4248         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4249         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4250
4251 2019-07-17  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui.c: Update.
4254         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4255         tui-regs.c.
4256         * tui/tui-windata.h: Remove file.
4257         * tui/tui-windata.c: Remove file.
4258         * tui/tui-win.c (tui_data_window::set_new_height)
4259         (tui_data_window::do_make_visible_with_new_height): Move to
4260         tui-regs.c.
4261         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4262         * tui/tui-regs.c: Remove "structuring" comments.
4263         (tui_data_window::first_data_item_displayed)
4264         (tui_data_window::delete_data_content_windows)
4265         (tui_data_window::erase_data_content)
4266         (tui_data_window::display_all_data)
4267         (tui_data_window::refresh_all)
4268         (tui_data_window::do_scroll_vertical)
4269         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4270         (tui_data_window::do_make_visible_with_new_height)
4271         (tui_data_window::refresh_window): Move from elsewhere.
4272         (_initialize_tui_regs): Move to end of file.
4273         * tui/tui-layout.c: Update.
4274         * tui/tui-hooks.c: Update.
4275         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4276         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4277         tui-regs.c.
4278         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4279
4280 2019-07-17  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4283         seen.
4284
4285 2019-07-17  Tom Tromey  <tom@tromey.com>
4286
4287         * tui/tui-win.c (tui_source_window_base::set_new_height)
4288         (tui_source_window_base::do_make_visible_with_new_height): Use
4289         m_has_locator field directly.
4290         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4291         method.
4292         (struct tui_source_window_base) <has_locator>: Likewise.
4293
4294 2019-07-17  Tom Tromey  <tom@tromey.com>
4295
4296         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4297         Don't declare.
4298         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4299         Remove.
4300         * tui/tui-win.c (tui_source_window_base::set_new_height)
4301         (tui_source_window_base::set_new_height)
4302         (make_invisible_and_set_new_height)
4303         (tui_source_window_base::do_make_visible_with_new_height)
4304         (tui_source_window_base::do_make_visible_with_new_height):
4305         Update.
4306         * tui/tui-layout.c (show_source_disasm_command, show_data)
4307         (show_source_or_disasm_and_command): Update.
4308         * tui/tui-layout.c (show_layout): Update.
4309
4310 2019-07-17  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-layout.c (make_data_window): Remove.
4313         (show_data): Unify creation and re-initialization cases.
4314
4315 2019-07-17  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-layout.c (make_source_window, make_disasm_window):
4318         Remove.
4319         (show_data): Unify creation and re-initialization cases.
4320
4321 2019-07-17  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui-layout.c (make_command_window): Remove.
4324         (show_source_disasm_command, show_source_or_disasm_and_command):
4325         Unify creation and re-initialization cases.
4326
4327 2019-07-17  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4330         creation and re-initialization cases.
4331
4332 2019-07-17  Tom Tromey  <tom@tromey.com>
4333
4334         * tui/tui-regs.c (tui_get_register): Return void.
4335
4336 2019-07-17  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4339         Simplify.
4340
4341 2019-07-17  Tom Tromey  <tom@tromey.com>
4342
4343         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4344         resetting.
4345
4346 2019-07-17  Tom Tromey  <tom@tromey.com>
4347
4348         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4349         * tui/tui-regs.c (tui_reg_layout): New function.
4350         (tui_show_registers, tui_reg_command): Use it.
4351         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4352         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4353         parameters.
4354         (tui_layout_command): Remove.
4355
4356 2019-07-17  Tom Tromey  <tom@tromey.com>
4357
4358         * tui/tui-layout.h (tui/tui-layout): Return void.
4359         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4360
4361 2019-07-17  Tom Tromey  <tom@tromey.com>
4362
4363         * tui/tui-layout.c (show_source_disasm_command, show_data):
4364         Update.
4365         (reset_locator): Remove.
4366         (show_source_or_disasm_and_command): Update.
4367
4368 2019-07-17  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-source.c (tui_source_window_base::reset): Remove
4371         win_type parameter.
4372         * tui/tui-layout.c (make_command_window, make_source_window)
4373         (make_disasm_window, make_data_window)
4374         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4375         (reset_locator, show_source_or_disasm_and_command): Update.
4376         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4377         win_type parameter.
4378         (struct tui_source_window_base) <reset>: Likewise.
4379
4380 2019-07-17  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-layout.c (show_source_disasm_command): Use
4383         reset_locator.
4384         (reset_locator): New function.
4385         (init_and_make_win): Remove.
4386         (show_source_or_disasm_and_command): Use reset_locator.
4387
4388 2019-07-17  Tom Tromey  <tom@tromey.com>
4389
4390         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4391         condition.
4392         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4393         Remove condition.
4394         * tui/tui-source.c (tui_source_window_base::reset): New method.
4395         * tui/tui-layout.c (make_command_window): Don't call
4396         init_and_make_win.
4397         (make_source_window, make_disasm_window): Don't call
4398         make_source_or_disasm_window.
4399         (make_data_window): Don't call init_and_make_win.  Change calling
4400         convention.
4401         (show_source_disasm_command, show_data): Simplify.
4402         (make_source_or_disasm_window): Remove.
4403         (show_source_or_disasm_and_command): Simplify.
4404         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4405         (struct tui_source_window_base) <reset>: Likewise.
4406         <execution_info>: Remove initializer.
4407         * tui/tui-data.c (tui_source_window_base): Initialize
4408         execution_info.
4409
4410 2019-07-17  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4413         variable.
4414
4415 2019-07-17  Tom Tromey  <tom@tromey.com>
4416
4417         * tui/tui.c (tui_rl_other_window): Update.
4418         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4419         superclass method first.  Always iterate over regs_content.
4420         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4421         method.
4422         * tui/tui-win.c (tui_set_focus_command): Update.
4423
4424 2019-07-17  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-win.c (tui_set_focus_command): Rename from
4427         tui_set_focus.  Call tui_enable.
4428         (tui_set_focus_command): Remove.
4429
4430 2019-07-17  Tom Tromey  <tom@tromey.com>
4431
4432         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4433         refresh_window.
4434         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4435         touchwin.
4436         (tui_data_window::refresh_window): Call refresh_window on data
4437         items.  Always call superclass refresh_window.
4438         (tui_win_info::refresh): Remove.
4439         (tui_source_window_base::refresh_window): Update.
4440         (tui_refresh_all): Update.
4441         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4442         refresh_window.
4443         (show_source_or_disasm_and_command): Likewise.
4444         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4445         (struct tui_source_window_base) <refresh>: Likewise.
4446
4447 2019-07-17  Tom Tromey  <tom@tromey.com>
4448
4449         * tui/tui-winsource.c (tui_clear_source_content)
4450         (tui_show_source_content): Update.
4451         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4452         whether content is empty.
4453         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4454         Remove.
4455
4456 2019-07-17  Tom Tromey  <tom@tromey.com>
4457
4458         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4459         window's contents.
4460         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4461         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4462
4463 2019-07-17  Tom Tromey  <tom@tromey.com>
4464
4465         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4466         (struct tui_data_item_window): Update.
4467
4468 2019-07-17  Tom Tromey  <tom@tromey.com>
4469
4470         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4471         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4472         defines.
4473
4474 2019-07-17  Tom Tromey  <tom@tromey.com>
4475
4476         * tui/tui-winsource.h (tui_erase_source_content)
4477         (tui_clear_source_content): Remove "display_prompt" parameter.
4478         * tui/tui-winsource.c (tui_update_source_window_as_is)
4479         (tui_update_source_windows_with_addr): Update.
4480         (tui_clear_source_content): Remove "display_prompt" parameter.
4481         (tui_erase_source_content): Likewise.  Simplify.
4482         (tui_show_source_content): Update.
4483         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4484         * tui/tui-stack.c (tui_show_frame_info): Update.
4485         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4486         Remove defines.
4487
4488 2019-07-17  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4491         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4492         parameter.
4493         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4494         parameter.
4495
4496 2019-07-17  Tom Tromey  <tom@tromey.com>
4497
4498         * tui/tui-winsource.c (tui_clear_source_content)
4499         (tui_show_source_content, tui_show_exec_info_content)
4500         (tui_clear_exec_info_content): Update.
4501         * tui/tui-stack.c (tui_show_locator_content): Update.
4502         (tui_show_frame_info): Update.
4503         * tui/tui-source.h (tui_source_window): Don't declare.
4504         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4505         from tui_source_is_displayed.
4506         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4507         Remove field.
4508         (struct tui_source_window_base) <content_in_use>: New field.  Now
4509         bool.
4510         (struct tui_source_window) <showing_source_p>: New method.
4511         (TUI_SRC_WIN): Change cast.
4512         * tui/tui-data.c (tui_initialize_static_data): Update.
4513
4514 2019-07-17  Tom Tromey  <tom@tromey.com>
4515
4516         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4517         location_matches_p.
4518         * tui/tui-source.c (tui_source_window::location_matches_p): New
4519         method.
4520         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4521         method.
4522         * tui/tui-data.h (struct tui_source_window_base)
4523         <location_matches_p>: New method.
4524         (struct tui_source_window, struct tui_disasm_window)
4525         <location_matches_p>: Likewise.
4526
4527 2019-07-17  Tom Tromey  <tom@tromey.com>
4528
4529         * tui/tui-win.c (tui_set_win_height_command): Rename from
4530         tui_set_win_height.
4531         (tui_set_win_height_command): Remove.
4532
4533 2019-07-17  Tom Tromey  <tom@tromey.com>
4534
4535         * tui/tui-source.c (tui_source_window): New constructor.  Add
4536         observer.
4537         (~tui_source_window): New destructor.
4538         (tui_source_window::style_changed): New method.
4539         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4540         (tui_attach_detach_observers): Update.
4541         * tui/tui-data.h (struct tui_source_window): Make constructor not
4542         inline.  Add destructor.
4543         (struct tui_source_window) <style_changed>: New method.
4544         <m_observable>: New member.
4545
4546 2019-07-17  Tom Tromey  <tom@tromey.com>
4547
4548         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4549         * tui/tui-win.c (tui_resize_all): Fix typo.
4550
4551 2019-07-17  Tom Tromey  <tom@tromey.com>
4552
4553         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4554         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4555         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4556         * tui/tui-win.c (window_name_completer): Use foreach.
4557         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4558         (update_tab_width): Likewise.
4559         * tui/tui-layout.c (show_layout): Update.
4560         * tui/tui-data.h (class tui_window_iterator): New.
4561         (struct all_tui_windows): New.
4562         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4563
4564 2019-07-17  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4567         parameter.  Don't reference globals.
4568         (tui_reg_command): Update.
4569
4570 2019-07-17  Tom Tromey  <tom@tromey.com>
4571
4572         * tui/tui-regs.c (tui_show_registers): Simplify.
4573
4574 2019-07-17  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-regs.c (tui_show_registers): Update.
4577         (tui_show_register_group): Add win_info parameter.
4578
4579 2019-07-17  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4582         Rename from tui_display_reg_element_at_line.
4583         (tui_data_window::display_registers_from_line): Update.
4584         * tui/tui-data.h (struct tui_data_window)
4585         <display_reg_element_at_line>: New method.
4586
4587 2019-07-17  Tom Tromey  <tom@tromey.com>
4588
4589         * tui/tui-regs.h (tui_display_registers_from)
4590         (tui_display_registers_from_line): Don't declare.
4591         * tui/tui-windata.c (tui_data_window::display_all_data)
4592         (tui_data_window::refresh_all)
4593         (tui_data_window::do_scroll_vertical): Update.
4594         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4595         from tui_display_registers_from.
4596         (tui_display_reg_element_at_line): Update.
4597         (tui_data_window::display_registers_from_line): Rename from
4598         tui_display_registers_from_line.
4599         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4600         display_registers_from_line>: New methods.
4601
4602 2019-07-17  Tom Tromey  <tom@tromey.com>
4603
4604         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4605         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4606         from tui_erase_data_content.
4607         (tui_data_window::display_all_data)
4608         (tui_data_window::refresh_all)
4609         (tui_data_window::do_scroll_vertical): Update.
4610         * tui/tui-regs.c (tui_show_registers): Update.
4611         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4612         New method.
4613
4614 2019-07-17  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4617         declare.
4618         * tui/tui-windata.c
4619         (tui_data_window::delete_data_content_windows): Rename from
4620         tui_delete_data_content_windows.
4621         (tui_data_window::display_all_data)
4622         (tui_data_window::do_scroll_vertical): Update.
4623         * tui/tui-data.h (struct tui_data_window)
4624         <delete_data_content_windows>: New method.
4625
4626 2019-07-17  Tom Tromey  <tom@tromey.com>
4627
4628         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4629         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4630
4631 2019-07-17  Tom Tromey  <tom@tromey.com>
4632
4633         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4634         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4635         from tui_display_all_data.
4636         * tui/tui-win.c
4637         (tui_data_window::do_make_visible_with_new_height): Update.
4638         * tui/tui-regs.c (tui_show_registers): Update.
4639         * tui/tui-layout.c (tui_set_layout): Update.
4640         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4641         method.
4642
4643 2019-07-17  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4646         * tui/tui-windata.c (tui_display_data_from): Remove.
4647         (tui_data_window::refresh_all): Update.
4648
4649 2019-07-17  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4652         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4653         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4654         tui_display_registers_from_line.
4655         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4656         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4657         "force_display" parameter.
4658
4659 2019-07-17  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4662         declare.
4663         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4664         Rename from tui_first_reg_element_no_inline.
4665         (tui_display_reg_element_at_line)
4666         (tui_display_registers_from_line): Update.
4667         * tui/tui-data.h (struct tui_data_window)
4668         <first_reg_element_no_inline>: New method.
4669
4670 2019-07-17  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-windata.c (tui_display_data_from)
4673         (tui_data_window::do_scroll_vertical): Update.
4674         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4675         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4676         Rename from tui_line_from_reg_element_no.
4677         (tui_display_registers_from_line): Update.
4678         * tui/tui-data.h (struct tui_data_window)
4679         <line_from_reg_element_no>: New method.
4680
4681 2019-07-17  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4684         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4685         tui_last_regs_line_no.
4686         (tui_display_reg_element_at_line)
4687         (tui_display_registers_from_line): Update.
4688         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4689         method.
4690
4691 2019-07-17  Tom Tromey  <tom@tromey.com>
4692
4693         PR tui/24722:
4694         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4695         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4696         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4697         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4698         (tui_update_breakpoint_info): Likewise.
4699         * tui/tui-hooks.c (tui_event_create_breakpoint)
4700         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4701         Update.
4702
4703 2019-07-17  Tom Tromey  <tom@tromey.com>
4704
4705         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4706
4707 2019-07-17  Tom Tromey  <tom@tromey.com>
4708
4709         * tui/tui-winsource.c (tui_update_source_window_as_is)
4710         (tui_update_source_windows_with_addr): Update.
4711         * tui/tui-source.h (tui_set_source_content)
4712         (tui_show_symtab_source): Add "win_info" parameter.
4713         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4714         parameter.
4715         (tui_show_symtab_source): Likewise.
4716
4717 2019-07-17  Tom Tromey  <tom@tromey.com>
4718
4719         * tui/tui-wingeneral.c
4720         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4721
4722 2019-07-17  Tom Tromey  <tom@tromey.com>
4723
4724         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4725         (struct tui_cmd_window) <can_scroll>: New method.
4726         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4727         method.
4728
4729 2019-07-17  Tom Tromey  <tromey@adacore.com>
4730
4731         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4732         do_field_signed>: Rename.  Change type of "value".
4733         * ui-out.c (ui_out::field_signed): Rename from field_int.
4734         Change type of "value".
4735         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4736         type of "value".
4737         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4738         do_field_int.  Change type of "value".
4739         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4740         do_field_int.  Change type of "value".
4741         * tracepoint.c (trace_status_mi, tfind_1)
4742         (print_one_static_tracepoint_marker): Update.
4743         * thread.c (print_thread_info_1, print_selected_thread_frame):
4744         Update.
4745         * stack.c (print_frame, print_frame_info): Update.
4746         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4747         Update.
4748         * source.c (print_source_lines_base): Update.
4749         * skip.c (info_skip_command): Update.
4750         * record-btrace.c (btrace_ui_out_decode_error)
4751         (btrace_call_history_src_line): Update.
4752         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4753         Update.
4754         * progspace.c (print_program_space): Update.
4755         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4756         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4757         do_field_int.  Change type of "value".
4758         * mi/mi-out.c (mi_ui_out::do_table_begin)
4759         (mi_ui_out::do_table_header): Update.
4760         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4761         type of "value".
4762         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4763         (mi_cmd_data_list_changed_registers, output_register)
4764         (mi_cmd_data_read_memory, mi_load_progress)
4765         (mi_cmd_trace_frame_collected): Update.
4766         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4767         Update.
4768         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4769         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4770         (mi_cmd_var_list_children, varobj_update_one): Update.
4771         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4772         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4773         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4774         * inferior.c (print_inferior): Update.
4775         * gdb_bfd.c (print_one_bfd): Update.
4776         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4777         Update.
4778         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4779         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4780         do_field_int.  Change type of "value".
4781         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4782         do_field_int.  Change type of "value".
4783         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4784         (print_one_breakpoint_location, print_it_catch_fork)
4785         (print_one_catch_fork, print_it_catch_vfork)
4786         (print_one_catch_vfork, print_it_catch_solib)
4787         (print_it_catch_exec, print_it_ranged_breakpoint)
4788         (print_mention_watchpoint, print_mention_masked_watchpoint)
4789         (bkpt_print_it, update_static_tracepoint): Update.
4790         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4791         * break-catch-syscall.c (print_it_catch_syscall): Update.
4792         * ada-tasks.c (print_ada_task_info): Update.
4793         * ada-lang.c (print_it_exception, print_mention_exception):
4794         Update.
4795
4796 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4797
4798         PR breakpoints/24541
4799         * gdbarch.c: Regenerate.
4800         * gdbarch.h: Regenerate.
4801         * gdbarch.sh: Adjust return type and parameter types for
4802         'stap_adjust_register'.
4803         (i386_stap_adjust_register): Adjust signature and return new
4804         register name.
4805         * stap-probe.c (stap_parse_register_operand): Adjust use of
4806         'gdbarch_stap_adjust_register'.
4807
4808 2019-07-17  Tom Tromey  <tromey@adacore.com>
4809
4810         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4811         declare VEC.
4812         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4813         std::vector.
4814         (struct s390_process_info): Add initializers.
4815         (s390_add_process): Use new.
4816         (s390_linux_nat_target::low_forget_process): Use delete.
4817         (s390_linux_nat_target::low_new_fork)
4818         (s390_linux_nat_target::stopped_by_watchpoint)
4819         (s390_linux_nat_target::low_prepare_to_resume)
4820         (s390_linux_nat_target::insert_watchpoint)
4821         (s390_linux_nat_target::insert_hw_breakpoint)
4822         (s390_linux_nat_target::remove_watchpoint)
4823         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4824
4825 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4826
4827         * aarch64-fbsd-nat.c: Include regcache.h.
4828         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4829         argument.
4830         (aarch64_fbsd_nat_target::fetch_registers)
4831         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4832         variable.
4833         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4834
4835 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4836
4837         * fbsd-nat.c: Include gdbarch.h.
4838
4839 2019-07-15  Tom Tromey  <tromey@adacore.com>
4840
4841         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4842
4843 2019-07-15  Tom Tromey  <tromey@adacore.com>
4844
4845         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4846         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4847         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4848         * cli-out.c (cli_ui_out::do_field_int): New method.
4849         * ui-out.c (ui_out::field_unsigned): New method.
4850         * symfile.c (generic_load): Use field_unsigned.
4851         (print_transfer_performance): Likewise.
4852         * record-btrace.c (ui_out_field_uint): Remove.
4853         (btrace_call_history_insn_range, btrace_call_history): Use
4854         field_unsigned.
4855         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4856         field_unsigned.
4857         * ui-out.h (class ui_out) <field_unsigned>: New method.
4858         <do_field_unsigned>: Likewise.
4859
4860 2019-07-15  Tom Tromey  <tromey@adacore.com>
4861
4862         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4863         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4864         * target.c (flash_erase_command): Use field_string.
4865         * infrun.c (print_signal_received_reason): Use field_string.
4866         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4867         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4868         field_string.
4869         * ada-tasks.c (print_ada_task_info): Use field_string.
4870
4871 2019-07-15  Tom Tromey  <tromey@adacore.com>
4872
4873         * target.c (flash_erase_command): Use field_core_addr.
4874         * symfile.c (generic_load): Use field_core_addr.
4875         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4876         Use field_core_addr.
4877         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4878         field_core_addr.
4879
4880 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4883         value if its desired type is smaller than a CORE_ADDR and signed.
4884
4885 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4886
4887         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4888         of changes to field names, and use new is_reference field to
4889         decide if a property is a reference or not.
4890         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4891         field.
4892         (struct dwarf2_property_baton): Update header comment, rename
4893         'referenced_type' to 'property_type' and update comments.
4894         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4895         default property type, store in property baton, update to take
4896         accound of renamed field.
4897         (read_func_scope): Update call to attr_to_dynamic_prop.
4898         (read_array_type): Likewise.
4899         (dwarf2_per_cu_addr_sized_int_type): New function.
4900         (read_subrange_index_type): Move type finding code to
4901         dwarf2_per_cu_addr_sized_int_type.
4902         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4903         (dwarf2_per_cu_addr_type): New function.
4904         (set_die_type): Update calls to attr_to_dynamic_prop.
4905
4906 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4907
4908         * dwarf2read.c (read_subrange_index_type): New function.
4909         (read_subrange_type): Move code into new function and call it.
4910         * gdbtypes.c (create_range_type): Add some asserts.
4911
4912 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4913
4914         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4915         update return statements.
4916         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4917         declaration, and update comment to match.
4918         * gdbtypes.c (resolve_dynamic_array): Update call to
4919         dwarf2_evaluate_property to match new return type.
4920
4921 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4922
4923         * valarith.c (value_subscripted_rvalue): Change lowerbound
4924         parameter type from int to LONGEST.
4925         * value.h (value_subscripted_rvalue): Likewise in declaration.
4926
4927 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * cli/cli-utils.c (info_print_command_completer): New function.
4930         * cli/cli-utils.h: Add 'completer.h' include, and forward
4931         declaration for 'struct cmd_list_element'.
4932         (info_print_command_completer): Declare.
4933         * stack.c (_initialize_stack): Add completer for 'info locals' and
4934         'info args'.
4935         * symtab.c (_initialize_symtab): Add completer for 'info
4936         variables' and 'info functions'.
4937         * NEWS: Mention completion for additional info commands.
4938
4939 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4940
4941         * cli/cli-utils.c (extract_info_print_args): Delete.
4942         (extract_arg_maybe_quoted): Delete.
4943         (info_print_options_defs): New variable.
4944         (make_info_print_options_def_group): New function.
4945         (extract_info_print_options): Define new function.
4946         * cli/cli-utils.h (extract_info_print_args): Delete.
4947         (struct info_print_options): New structure.
4948         (extract_info_print_options): Declare new function.
4949         * stack.c (info_locals_command): Update to use new
4950         extract_info_print_options, also add a header comment.
4951         (info_args_command): Likewise.
4952         * symtab.c (info_variables_command): Likewise.
4953         (info_functions_command): Likewise.
4954
4955 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4956
4957         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4958         to extract string arguments.
4959         * common/common-utils.c (extract_string_maybe_quoted): New function.
4960         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4961
4962 2019-07-11  Tom Tromey  <tromey@adacore.com>
4963
4964         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4965         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4966         * top.h (gdbinit): Don't declare.
4967         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4968         into...
4969         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4970         * top.c (gdb_init): Don't call init_cli_cmds.
4971         (gdbinit): Remove.
4972         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4973
4974 2019-07-11  Tom Tromey  <tromey@adacore.com>
4975
4976         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4977         after it has been moved.
4978
4979 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4980
4981         * valops.c (value_must_coerce_to_target): Change return type to
4982         bool.
4983         * value.h (value_must_coerce_to_target): Likewise.
4984
4985 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4986
4987         * breakpoint.c (is_hardware_watchpoint): Remove
4988         forward-declaration.
4989         (is_masked_watchpoint): Change return type to bool.
4990         (is_tracepoint): Likewise.
4991         (is_breakpoint): Likewise.
4992         (is_hardware_watchpoint): Likewise.
4993         (is_watchpoint): Likewise.
4994         (is_no_memory_software_watchpoint): Likewise.
4995         (is_catchpoint): Likewise.
4996         (breakpoint_1): Make FILTER parameter's return type bool.
4997         is_masked_watchpoint): Change return type to bool.
4998         (save_breakpoints): Make FILTER parameter's return type bool.
4999         * breakpoint.h (is_breakpoint): Change return type to bool.
5000         (is_watchpoint): Likewise.
5001         (is_catchpoint): Likewise.
5002         (is_tracepoint): Likewise.
5003
5004 2019-07-10  Tom Tromey  <tom@tromey.com>
5005
5006         * defs.h: Don't include gdbarch.h.
5007         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5008         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5009         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5010         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5011         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5012         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5013         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5014         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5015         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5016         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5017         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5018         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5019         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5020         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5021         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5022         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5023         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5024         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5025         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5026         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5027         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5028         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5029         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5030         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5031         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5032         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5033         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5034
5035 2019-07-10  Tom Tromey  <tromey@adacore.com>
5036
5037         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5038         * breakpoint.c (init_ada_exception_breakpoint): Register as
5039         bp_catchpoint.
5040         (print_one_breakpoint_location, print_one_breakpoint): Use
5041         is_ada_exception_catchpoint.
5042         * ada-lang.c (class ada_catchpoint_location): Pass
5043         bp_loc_software_breakpoint to bp_location constructor.
5044         (is_ada_exception_catchpoint): New function.
5045
5046 2019-07-10  Tom Tromey  <tromey@adacore.com>
5047
5048         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5049         VEC.
5050         (struct arm_exidx_entry): New method operator<.
5051         (struct arm_exidx_data) <section_maps>: Change type.
5052         (arm_exidx_data_free): Remove.
5053         (arm_exidx_data_key): Change type.  Move lower.
5054         (arm_exidx_new_objfile): Update.
5055         (arm_compare_exidx_entries): Remove.
5056         (arm_find_exidx_entry, _initialize_arm_tdep)
5057
5058 2019-07-10  Tom Tromey  <tromey@adacore.com>
5059
5060         * solib-spu.c (ocl_program_data_key): Change type.
5061         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5062         Update.
5063
5064 2019-07-10  Tom Tromey  <tromey@adacore.com>
5065
5066         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5067         (struct solib_aix_inferior_data) <library_list>: Change type.
5068         (solib_aix_inferior_data_handle): Change type.
5069         (get_solib_aix_inferior_data): Update.
5070         (solib_aix_free_library_list): Remove.
5071         (library_list_start_library): Update.
5072         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5073         return type.
5074         (solib_aix_get_library_list)
5075         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5076         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5077
5078 2019-07-10  Tom Tromey  <tromey@adacore.com>
5079
5080         * solib-dsbt.c (struct dsbt_info): Add initializers.
5081         (solib_dsbt_pspace_data): Change type.
5082         (dsbt_pspace_data_cleanup): Remove.
5083         (get_dsbt_info, _initialize_dsbt_solib): Update.
5084
5085 2019-07-10  Tom Tromey  <tromey@adacore.com>
5086
5087         * spu-tdep.c (spu_overlay_data): Change type.
5088         (spu_get_overlay_table, spu_overlay_new_objfile)
5089         (_initialize_spu_tdep): Update.
5090
5091 2019-07-10  Tom Tromey  <tromey@adacore.com>
5092
5093         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5094         destructor.
5095         (dbx_objfile_data_key): Change type and declare later.
5096         (DBX_SYMFILE_INFO): Rewrite.
5097         * dbxread.c (dbx_objfile_data_key): Change type.
5098         (dbx_symfile_init): Update.
5099         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5100         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5101         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5102
5103 2019-07-10  Tom Tromey  <tromey@adacore.com>
5104
5105         * jit.c (jit_program_space_key): Change type.  Move lower.
5106         (get_jit_program_space_data): Update.
5107         (jit_program_space_data_cleanup): Remove.
5108         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5109         Update.
5110         (struct jit_program_space_data): Add initializers.
5111
5112 2019-07-10  Tom Tromey  <tromey@adacore.com>
5113
5114         * solib-darwin.c (struct darwin_info): Add initializers.
5115         (solib_darwin_pspace_data): Change type.
5116         (darwin_pspace_data_cleanup): Remove.
5117         (get_darwin_info, _initialize_darwin_solib): Update.
5118
5119 2019-07-10  Tom Tromey  <tromey@adacore.com>
5120
5121         * remote-sim.c (struct sim_inferior_data): Add initializers,
5122         constructor, and destructor.
5123         (sim_inferior_data_key): Change type.  Move lower.
5124         (check_for_duplicate_sim_descriptor): Update.
5125         (get_sim_inferior_data): Use new.  Update.
5126         (~sim_inferior_data_cleanup): Rename from
5127         sim_inferior_data_cleanup.  Simplify.
5128         (gdbsim_close_inferior, simulator_command)
5129         (sim_command_completer, _initialize_remote_sim): Update.
5130         (next_pid, INITIAL_PID): Move earlier.
5131
5132 2019-07-10  Tom Tromey  <tromey@adacore.com>
5133
5134         * python/python-internal.h (create_thread_object): Return
5135         gdbpy_ref.
5136         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5137         * python/py-inferior.c (struct threadlist_entry): Add
5138         constructor.
5139         <thread_obj>: Now a gdbpy_ref.
5140         (thread_to_thread_object): Update.
5141         (add_thread_object): Use new.
5142         (delete_thread_object): Use delete.
5143         (infpy_threads): Update.
5144         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5145         GIL.
5146
5147 2019-07-10  Tom Tromey  <tromey@adacore.com>
5148
5149         * valops.c (value_cast): Specialize error message for Ada.
5150
5151 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5152
5153         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5154
5155 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5156
5157         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5158         bpstat_should_step): Return bool, adjust comments.
5159         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5160         bpstat_should_step): Likewise.
5161
5162 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5163
5164         * features/Makefile: Use feature target descriptions for Arm.
5165         * features/arm/arm-core.c: Generate new file.
5166         * features/arm/arm-fpa.c: Likewise.
5167         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5168         * features/arm/arm-m-profile.c: Likewise.
5169         * features/arm/arm-vfpv2.c: Likewise.
5170         * features/arm/arm-vfpv3.c: Likewise.
5171         * features/arm/xscale-iwmmxt.c: Likewise.
5172         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5173
5174 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5175
5176         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5177         ptrace earlier.
5178
5179 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5180
5181         * features/aarch64-pauth.c: Regenerate.
5182
5183 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5184
5185         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5186         bool.
5187         (bpstat_what): Use false instead of 0.
5188
5189 2019-07-09  Pedro Alves  <palves@redhat.com>
5190
5191         * break-catch-throw.c (is_exception_catchpoint): New.
5192         * breakpoint.c (print_one_breakpoint_location): New parameter
5193         'raw_loc'.  Handle it.  Use
5194         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5195         looking at the breakpoint's type.
5196         (print_one_breakpoint): If handling "maint info breakpoints", also
5197         print locations of exception catchpoints.
5198         * breakpoint.h (is_exception_catchpoint): Declare.
5199
5200 2019-07-09  Pedro Alves  <palves@redhat.com>
5201
5202         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5203         "addr" field.
5204         (allocate_location_exception_catchpoint): New.
5205         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5206         (initialize_throw_catchpoint_ops): Install
5207         allocate_location_exception_catchpoint as allocate_location
5208         method.
5209         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5210         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5211         bp_loc_other.
5212         (breakpoint_address_is_meaningful): Delete.
5213         (bl_address_is_meaningful): New.
5214         (breakpoint_locations_match): Adjust comment.
5215         (bp_location_from_bp_type): New, factored out of...
5216         (bp_location::bp_location(breakpoint *)): ... this.
5217         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5218         factored out of...
5219         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5220         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5221         breakpoint_address_is_meaningful.
5222         (bp_locations_compare): Adjust comment.
5223         (update_global_location_list): Use bl_address_is_meaningful
5224         instead of breakpoint_address_is_meaningful.
5225         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5226         explicit.
5227         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5228         * python/py-breakpoint.c (bppy_get_location): No longer check
5229         whether location is null.
5230
5231 2019-07-09  Pedro Alves  <palves@redhat.com>
5232
5233         PR c++/15468
5234         * breakpoint.c (print_one_breakpoint_location): Remove
5235         single-location assert.
5236
5237 2019-07-09  Tom Tromey  <tom@tromey.com>
5238
5239         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5240         * configure: Rebuild.
5241         * configure.ac: Change common to gdbsupport.
5242         * gdbsupport: Rename from common.
5243         * acinclude.m4: Change common to gdbsupport.
5244         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5245         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5246         gdbsupport.
5247         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5248         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5249         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5250         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5251         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5252         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5253         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5254         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5255         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5256         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5257         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5258         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5259         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5260         coff-pe-read.c, command.h, compile/compile-c-support.c,
5261         compile/compile-c.h, compile/compile-cplus-symbols.c,
5262         compile/compile-cplus-types.c, compile/compile-cplus.h,
5263         compile/compile-loc2c.c, compile/compile.c, completer.c,
5264         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5265         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5266         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5267         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5268         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5269         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5270         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5271         features/aarch64-core.c, features/aarch64-fpu.c,
5272         features/aarch64-pauth.c, features/aarch64-sve.c,
5273         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5274         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5275         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5276         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5277         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5278         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5279         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5280         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5281         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5282         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5283         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5284         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5285         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5286         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5287         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5288         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5289         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5290         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5291         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5292         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5293         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5294         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5295         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5296         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5297         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5298         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5299         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5300         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5301         minsyms.c, mips-linux-tdep.c, namespace.h,
5302         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5303         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5304         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5305         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5306         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5307         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5308         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5309         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5310         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5311         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5312         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5313         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5314         procfs.c, producer.c, progspace.h, psymtab.h,
5315         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5316         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5317         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5318         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5319         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5320         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5321         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5322         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5323         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5324         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5325         target-memory.c, target.c, target.h, target/waitstatus.c,
5326         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5327         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5328         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5329         unittests/array-view-selftests.c,
5330         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5331         unittests/common-utils-selftests.c,
5332         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5333         unittests/format_pieces-selftests.c,
5334         unittests/function-view-selftests.c,
5335         unittests/lookup_name_info-selftests.c,
5336         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5337         unittests/mkdir-recursive-selftests.c,
5338         unittests/observable-selftests.c,
5339         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5340         unittests/parse-connection-spec-selftests.c,
5341         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5342         unittests/scoped_fd-selftests.c,
5343         unittests/scoped_mmap-selftests.c,
5344         unittests/scoped_restore-selftests.c,
5345         unittests/string_view-selftests.c, unittests/style-selftests.c,
5346         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5347         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5348         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5349         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5350         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5351         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5352
5353 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5354
5355         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5356         bool value.
5357         (decode_digits_ordinary): Set explicit_line field in sal.
5358         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5359         symtab_and_line that was set on an explicit line number in
5360         assembler code.  Do always update the recorded symtab and line if
5361         we do skip the prologue.
5362
5363 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5364
5365         * breakpoint.c (set_breakpoint_location_function): Remove
5366         explicit_loc parameter.
5367         (momentary_breakpoint_from_master): Update call to
5368         set_breakpoint_location_function.
5369         (add_location_to_breakpoint): Likewise.
5370
5371 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5372
5373         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5374         required features based on default bfd type when no specific bfd
5375         is present.
5376
5377 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5378
5379         * NEWS: Mention that GDB printf and eval commands can now print
5380         C-style and Ada-style convenience var strings without
5381         calling the inferior.
5382         * printcmd.c (printf_c_string): Locally print GDB internal var
5383         instead of transiting via the inferior.
5384         (printf_wide_c_string): Likewise.
5385
5386 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5387
5388         PR breakpoints/25011
5389         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5390
5391 2019-07-04  Tom Tromey  <tom@tromey.com>
5392
5393         PR tui/24724:
5394         * tui/tui-winsource.c (tui_clear_source_content): Update.
5395         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5396         (tui_update_breakpoint_info): Update.
5397         (tui_set_exec_info_content): Update.
5398         * tui/tui-source.c (tui_set_source_content_nil): Update.
5399         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5400         has_break.
5401         * tui/tui-data.h (enum tui_bp_flag): New.
5402         (tui_bp_flags): New enum flags type.
5403         (struct tui_source_element) <break_mode>: Change type.  Rename
5404         from has_break.
5405         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5406         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5407         constants.
5408         * tui/tui-winsource.h: Fix comment.
5409
5410 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5411
5412         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5413         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5414         (store_fpregs_to_thread)
5415         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5416         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5417         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5418         (IWMMXT_REGS_SIZE): Add define.
5419         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5420         (fetch_vfp_regs, store_vfp_regs)
5421         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5422         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5423
5424 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5425
5426         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5427         defines.
5428         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5429         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5430         (ARM_INT_REGISTER_SIZE): ...to this.
5431         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5432         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5433         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5434         (arm_linux_collect_gregset, supply_nwfpe_register)
5435         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5436         defines.
5437         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5438         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5439         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5440         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5441         (arm_return_in_memory, arm_store_return_value)
5442         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5443         (arm_record_ld_st_multiple): Likewise.
5444         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5445         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5446
5447 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5448
5449         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5450         AARCH64_DISPLACED_MODIFIED_INSNS.
5451         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5452         (aarch64_displaced_step_copy_insn): Likewise.
5453         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5454         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5455         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5456         ARM_DISPLACED_MODIFIED_INSNS.
5457         * arm-tdep.c (arm_gdbarch_init): Likewise.
5458         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5459         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5460         (struct arm_displaced_step_closure): Use
5461         ARM_DISPLACED_MODIFIED_INSNS.
5462
5463 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5464
5465         * features/Makefile: Remove unused xml files.
5466         * features/aarch64.xml: Remove.
5467         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5468         * features/i386/amd64-avx-avx512.xml: Remove.
5469         * features/i386/amd64-avx-linux.xml: Remove.
5470         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5471         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5472         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5473         * features/i386/amd64-avx-mpx.xml: Remove.
5474         * features/i386/amd64-avx.xml: Remove.
5475         * features/i386/amd64-linux.xml: Remove.
5476         * features/i386/amd64-mpx-linux.xml: Remove.
5477         * features/i386/amd64-mpx.xml: Remove.
5478         * features/i386/amd64.xml: Remove.
5479         * features/i386/i386-avx-avx512-linux.xml: Remove.
5480         * features/i386/i386-avx-avx512.xml: Remove.
5481         * features/i386/i386-avx-linux.xml: Remove.
5482         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5483         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5484         * features/i386/i386-avx-mpx-linux.xml: Remove.
5485         * features/i386/i386-avx-mpx.xml: Remove.
5486         * features/i386/i386-avx.xml: Remove.
5487         * features/i386/i386-linux.xml: Remove.
5488         * features/i386/i386-mmx-linux.xml: Remove.
5489         * features/i386/i386-mmx.xml: Remove.
5490         * features/i386/i386-mpx-linux.xml: Remove.
5491         * features/i386/i386-mpx.xml: Remove.
5492         * features/i386/i386.xml: Remove.
5493         * features/i386/x32-avx-avx512-linux.xml: Remove.
5494         * features/i386/x32-avx-linux.xml: Remove.
5495         * features/i386/x32-linux.xml: Remove.
5496
5497 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5498
5499         * regformats/aarch64.dat: Remove.
5500         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5501         * regformats/i386/amd64-avx-linux.dat: Remove.
5502         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5503         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5504         * regformats/i386/amd64-linux.dat: Remove.
5505         * regformats/i386/amd64-mpx-linux.dat: Remove.
5506         * regformats/i386/amd64.dat: Remove.
5507         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5508         * regformats/i386/i386-avx-linux.dat: Remove.
5509         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5510         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5511         * regformats/i386/i386-linux.dat: Remove.
5512         * regformats/i386/i386-mmx-linux.dat: Remove.
5513         * regformats/i386/i386-mpx-linux.dat: Remove.
5514         * regformats/i386/i386.dat: Remove.
5515         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5516         * regformats/i386/x32-avx-linux.dat: Remove.
5517         * regformats/i386/x32-linux.dat: Remove.
5518
5519 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5520
5521         * aarch64-tdep.c: Remove xml self tests.
5522         * amd64-linux-tdep.c: Likewise.
5523         * amd64-tdep.c: Likewise.
5524         * i386-linux-tdep.c: Likewise.
5525         * i386-tdep.c: Likewise.
5526
5527 2019-07-03  Pedro Alves  <palves@redhat.com>
5528
5529         PR cli/24732
5530         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5531         (pipe_cmd_option_defs): New.
5532         (make_pipe_cmd_options_def_group): New.
5533         (pipe_command): Use gdb::option::process_options.
5534         (pipe_command_completer): New function.
5535         (_initialize_cli_cmds): Install completer for "pipe" command.
5536
5537 2019-07-03  Pedro Alves  <palves@redhat.com>
5538
5539         * cli/cli-option.c (union option_value) <string>: New field.
5540         (struct option_def_and_value): Add ctor, move ctor, dtor and
5541         use DISABLE_COPY_AND_ASSIGN.
5542         (option_def_and_value::clear_value): New.
5543         (parse_option, save_option_value_in_ctx, get_val_type_str)
5544         (add_setshow_cmds_for_options): Handle var_string.
5545         * cli-option.h (union option_def::var_address) <string>: New
5546         field.
5547         (struct string_option_def): New.
5548         * maint-test-options.c (struct test_options_opts): Add default
5549         ctor and use DISABLE_COPY_AND_ASSIGN.
5550         <string_opt>: New field.
5551         (test_options_opts::~test_options_opts): New.
5552         (test_options_opts::dump): Also dump "-string".
5553         (test_options_option_defs): Install "string.
5554
5555 2019-07-03  Pedro Alves  <palves@redhat.com>
5556
5557         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5558         option_value with a null enumeration.
5559         (complete_options): Save the option values in the context.
5560         (save_option_value_in_ctx): New, factored out from ...
5561         (process_options): ... here.
5562         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5563         of the function.
5564         * maint-test-options.c (test_options_opts::dump): New, factored
5565         out from ...
5566         (maintenance_test_options_command_mode): ... here.
5567         (maintenance_test_options_command_completion_result): Delete.
5568         (maintenance_test_options_command_completion_text): Update
5569         comment.
5570         (maintenance_show_test_options_completion_result): Change
5571         prototype.  Just print
5572         maintenance_test_options_command_completion_text.
5573         (save_completion_result): New.
5574         (maintenance_test_options_completer_mode): Pass options context to
5575         complete_options, and then save a dump.
5576         (_initialize_maint_test_options): Use add_cmd to install "maint
5577         show test-options-completion-result".
5578
5579 2019-07-03  Pedro Alves  <palves@redhat.com>
5580
5581         * NEWS (New commands): Mention "with" and "maint with".
5582         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5583         (with_command, with_command_completer): New.
5584         (pipe_command): Adjust to new repeat_previous
5585         interface.
5586         (_initialize_cli_cmds): Install the "with" command and its "w"
5587         alias.
5588         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5589         declarations.
5590         * cli/cli-setshow.c (parse_cli_var_uinteger)
5591         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5592         argument strings for all var_types.
5593         (get_setshow_command_value_string): New, factored out from ...
5594         (do_show_command): ... this.
5595         * cli/cli-setshow.h: Include <string>.
5596         (get_setshow_command_value_string): Declare.
5597         * command.h (repeat_previous): Now returns const char *.  Adjust
5598         comment.
5599         * maint.c: Include "cli/cli-cmds.h".
5600         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5601         (_initialize_maint_cmds): Register the "maintenance with" command.
5602         * top.c (repeat_previous): Move bits from pipe_command here:
5603         Return the saved command line, if any; error out if there's no
5604         command to relaunch.
5605
5606 2019-07-03  Pedro Alves  <palves@redhat.com>
5607
5608         * NEWS (New commands): Mention "maint set/show test-settings"
5609         instead of "maint test-settings".
5610         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5611         (maintenance_test_settings_set_list): Rename to ...
5612         (maintenance_set_test_settings_list): ... this.
5613         (maintenance_test_settings_show_list): Rename to  ...
5614         (maintenance_show_test_settings_list): ... this.
5615         (maintenance_test_settings_cmd): Delete.
5616         (maintenance_test_settings_set_cmd): ...
5617         (maintenance_set_test_settings_cmd): ... this.
5618         (maintenance_test_settings_show_cmd): ...
5619         (maintenance_show_test_settings_cmd): ... this.
5620         (maintenance_test_settings_show_value_cmd):
5621         (maintenance_show_test_settings_value_cmd): ... this.
5622         (_initialize_maint_test_settings): No longer install the "maint
5623         test-settings" prefix command.  Rename "maint test-settings set"
5624         to "maint set test-settings", and "maint test-settings show" to
5625         "maint show test-settings".  Adjust all subcommands.
5626
5627 2019-07-03  Pedro Alves  <palves@redhat.com>
5628
5629         * maint-test-settings.c: Fix file's intro comment.  Replace all
5630         references to "test-options" with references to "test-settings",
5631         in comments.
5632
5633 2019-07-03  Pedro Alves  <palves@redhat.com>
5634
5635         * maint-test-settings.c (maintenance_test_settings_xxx)
5636         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5637         New.
5638         (maintenance_test_settings_enums): Use them.
5639         (maintenance_test_settings_enum): Default to
5640         maintenance_test_settings_xxx.
5641         (_initialize_maint_test_settings): Initialize
5642         MAINTENANCE_TEST_SETTINGS_FILENAME.
5643
5644 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5645
5646         * breakpoint.h (remove_breakpoints_inf): Change return type to
5647         void, move function documentation here.
5648         * breakpoint.c (remove_breakpoints_inf): Change return type to
5649         void, move function documentation to header.
5650
5651 2019-07-02  Pedro Alves  <palves@redhat.com>
5652
5653         * NEWS (Completion improvements): Mention "info threads".
5654         * thread.c (struct info_threads_opts, info_threads_option_defs)
5655         (make_info_threads_options_def_group): New.
5656         (info_threads_command): Use gdb::option::process_options.
5657         (info_threads_command_completer): New.
5658         (_initialize_thread): Use gdb::option::build_help to build the
5659         help text for "info threads".
5660
5661 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5662
5663         * defs.h (generic_load): Move from here...
5664         * symfile.h (generic_load): ... to here.  Rename name parameter
5665         to args.
5666         * symfile.c (generic_load): Add comment.
5667
5668 2019-07-01  Tom Tromey  <tromey@adacore.com>
5669
5670         * dwarf2read.c
5671         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5672         declaration of without_params.  Fix formatting.
5673
5674 2019-07-01  Tom Tromey  <tromey@adacore.com>
5675
5676         * ada-exp.y (find_primitive_type): Update.
5677         * ada-lang.h (ada_lookup_symbol): Update.
5678         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5679         parameter.
5680         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5681
5682 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5683
5684         PR breakpoints/24541
5685         * gdbarch.c: Regenerate.
5686         * gdbarch.h: Regenerate.
5687         * gdbarch.sh: Add 'stap_adjust_register'.
5688         * i386-tdep.c: Include '<unordered_set>'.
5689         (i386_stap_adjust_register): New function.
5690         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5691         * stap-probe.c (stap_parse_register_operand): Call
5692         'gdbarch_stap_adjust_register'.
5693
5694 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5695
5696         PR python/24742
5697         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5698         * python/python.c (do_start_initialization): Use 'xmalloc'
5699         instead of 'PyMem_Malloc'.
5700
5701 2019-06-28  Tom Tromey  <tromey@adacore.com>
5702
5703         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5704         for Ada.
5705
5706 2019-06-27  Tom Tromey  <tromey@adacore.com>
5707
5708         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5709         objfile_key.
5710         (arm_find_mapping_symbol, arm_record_special_symbol)
5711         (_initialize_arm_tdep): Update.
5712         (arm_objfile_data_free): Remove.
5713
5714 2019-06-27  Tom Tromey  <tromey@adacore.com>
5715
5716         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5717         to cp_print_static_field.
5718
5719 2019-06-26  Tom Tromey  <tromey@adacore.com>
5720
5721         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5722         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5723         declare.
5724
5725 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5726
5727         * features/aarch64-core.c (create_feature_aarch64_core):
5728         Regenerate.
5729         * features/aarch64-core.xml: Add cpsr flags.
5730
5731 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5732
5733         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5734         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5735
5736 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5737
5738         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5739         field.
5740         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5741         use.
5742         (arm_record_special_symbol): Don't insert new symbol in sorted
5743         position, push it at the end.
5744
5745 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5746
5747         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5748         (arm_mapping_symbol_s): Remove.
5749         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5750         (arm_mapping_symbol_vec): New typedef.
5751         (struct arm_per_objfile): Add constructor.
5752         <section_maps>: Change type to
5753         std::unique_ptr<arm_mapping_symbol_vec[]>.
5754         (arm_compare_mapping_symbols): Remove.
5755         (arm_find_mapping_symbol): Adjust to section_maps type change.
5756         (arm_objfile_data_free): Call delete on arm_per_objfile.
5757         (arm_record_special_symbol): Adjust to section_maps type change.
5758         Allocate arm_per_objfile with new.
5759
5760 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5761
5762         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5763         with the command prefix.
5764
5765 2019-06-25  Tom Tromey  <tom@tromey.com>
5766
5767         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5768         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5769
5770 2019-06-25  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5773         type.
5774         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5775         protected.
5776
5777 2019-06-25  Tom Tromey  <tom@tromey.com>
5778
5779         * tui/tui-winsource.c
5780         (tui_source_window_base::set_is_exec_point_at): Add check against
5781         LOA_ADDRESS.
5782
5783 2019-06-25  Tom Tromey  <tom@tromey.com>
5784
5785         * tui/tui-source.c (tui_set_source_content): Don't check before
5786         xfree.
5787         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5788
5789 2019-06-25  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-winsource.h (tui_update_source_window_as_is)
5792         (tui_alloc_source_buffer, tui_line_is_displayed)
5793         (tui_addr_is_displayed): Change type of win_info.
5794         * tui/tui-winsource.c (tui_update_source_window_as_is)
5795         (tui_clear_source_content, tui_show_source_line)
5796         (tui_show_source_content, tui_source_window_base::refill)
5797         (tui_source_window_base::set_is_exec_point_at)
5798         (tui_source_window_base::set_is_exec_point_at)
5799         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5800         (tui_alloc_source_buffer, tui_line_is_displayed)
5801         (tui_addr_is_displayed): Change type of win_info.  Update.
5802         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5803         (tui_source_window_base::do_make_visible_with_new_height):
5804         Update.
5805         * tui/tui-source.c (tui_set_source_content)
5806         (tui_set_source_content_nil)
5807         (tui_source_window::do_scroll_vertical): Update.
5808         * tui/tui-layout.c (show_layout): Update.
5809         * tui/tui-disasm.c (tui_set_disassem_content)
5810         (tui_disasm_window::do_scroll_vertical): Update.
5811         * tui/tui-data.h (tui_win_content): Remove.
5812         (struct tui_gen_win_info) <content, content_size>: Remove.
5813         (struct tui_source_element): Add initializers and destructor.
5814         (union tui_which_element, struct tui_win_element): Remove.
5815         (struct tui_source_window_base) <content>: New field.
5816         (struct tui_data_window): Remove destructor.
5817         (tui_alloc_content, tui_free_win_content)
5818         (tui_free_all_source_wins_content): Don't declare.
5819         * tui/tui-data.c (tui_initialize_static_data): Update.
5820         (init_content_element, tui_alloc_content): Remove.
5821         (~tui_gen_win_info): Update.
5822         (~tui_data_window, tui_free_all_source_wins_content)
5823         (tui_free_win_content, free_content, free_content_elements):
5824         Remove.
5825
5826 2019-06-25  Tom Tromey  <tom@tromey.com>
5827
5828         * tui/tui-winsource.h (tui_clear_source_content)
5829         (tui_erase_source_content, tui_show_source_content): Change type
5830         of win_info.
5831         * tui/tui-winsource.c (tui_clear_source_content)
5832         (tui_erase_source_content, tui_show_source_content): Change type
5833         of win_info.
5834         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5835         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5836         win_info.
5837         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5838         win_info.
5839         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5840
5841 2019-06-25  Tom Tromey  <tom@tromey.com>
5842
5843         * tui/tui-winsource.c (tui_clear_source_content)
5844         (tui_source_window_base::set_is_exec_point_at): Update.
5845         * tui/tui-source.c (tui_set_source_content_nil): Update.
5846         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5847         a bool.
5848         * tui/tui-data.c (init_content_element): Update.
5849
5850 2019-06-25  Tom Tromey  <tom@tromey.com>
5851
5852         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5853         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5854         * tui/tui-layout.c (init_and_make_win): Update.
5855         * tui/tui.h (enum tui_win_type): Update.
5856         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5857         tui_win_is_auxillary.
5858         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5859         tui_win_is_auxillary.
5860
5861 2019-06-25  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5864         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5865         (tui_delete_data_content_windows, tui_display_all_data)
5866         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5867         Update.
5868         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5869         * tui/tui-regs.c (tui_last_regs_line_no)
5870         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5871         (tui_show_registers): Update.
5872         (tui_show_register_group): Return void.  Update.
5873         (tui_display_registers_from, tui_display_reg_element_at_line)
5874         (tui_display_registers_from_line, tui_check_register_values):
5875         Update.
5876         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5877         member.
5878         (struct tui_data_window) <regs_content>: Now a std::vector.
5879         <regs_content_count>: Remove.
5880         (tui_add_content_elements, tui_free_data_content): Don't declare.
5881         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5882         (init_content_element): Remove DATA_WIN case.  Add assert.
5883         (tui_add_content_elements): Remove.
5884         (tui_data_window): Update.
5885         (tui_free_data_content): Remove.
5886         (free_content_elements): Remove DATA_WIN case.
5887
5888 2019-06-25  Tom Tromey  <tom@tromey.com>
5889
5890         * tui/tui-data.c (tui_data_item_window): Update.
5891         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5892         * tui/tui-windata.c (tui_display_all_data)
5893         (tui_display_data_from_line): Update.
5894         (tui_check_data_values): Remove.
5895         * tui/tui-regs.c (tui_show_register_group)
5896         (tui_display_reg_element_at_line): Update.
5897         * tui/tui-hooks.c (tui_register_changed)
5898         (tui_refresh_frame_and_register_information): Call
5899         tui_check_register_values.
5900         * tui/tui-data.h (struct tui_data_window) <data_content,
5901         data_content_count, data_type>: Remove.
5902         (enum tui_data_type): Remove.
5903
5904         * tui/tui-data.c (tui_data_window::clear_detail)
5905         (~tui_data_window): Update.
5906
5907 2019-06-25  Tom Tromey  <tom@tromey.com>
5908
5909         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5910         declare.
5911         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5912         Rename from tui_first_data_item_displayed.  Update.
5913         (tui_data_window::refresh_all)
5914         (tui_data_window::do_scroll_vertical): Update.
5915         * tui/tui-data.h (struct tui_data_window)
5916         <first_data_item_displayed>: Declare new method.
5917
5918 2019-06-25  Tom Tromey  <tom@tromey.com>
5919
5920         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5921         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5922         contents...
5923         (tui_initialize_static_data): ...here.
5924
5925 2019-06-25  Tom Tromey  <tom@tromey.com>
5926
5927         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5928         (tui_display_registers_from, tui_check_register_values): Update.
5929         (tui_display_register): Remove win_info parameter; update.
5930         (tui_get_register): Change type of parameters.
5931         * tui/tui-data.h (struct tui_data_element): Remove.
5932         (union tui_which_element) <data>: Remove.
5933         <data_window>: Change type.
5934         (struct tui_data_item_window): New.
5935         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5936         case.  Add assert.
5937         (~tui_data_item_window): New destructor.
5938         (free_content_elements): Remove DATA_ITEM_WIN case.
5939
5940 2019-06-25  Tom Tromey  <tom@tromey.com>
5941
5942         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5943         Remove.
5944
5945 2019-06-25  Tom Tromey  <tom@tromey.com>
5946
5947         * tui/tui-data.h (struct tui_command_element): Remove.
5948         (union tui_which_element) <command>: Remove.
5949         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5950         assert.
5951         (free_content_elements): Remove CMD_WIN case.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-layout.c (tui_set_layout): Update.
5956         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5957         * tui/tui-data.c (layout_def): Update.
5958
5959 2019-06-25  Tom Tromey  <tom@tromey.com>
5960
5961         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5962         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5963         (tui_source_window_base::set_new_height): Update.
5964         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5965         Update.
5966         (tui_set_locator_fullname, tui_set_locator_info)
5967         (tui_show_frame_info): Update.
5968         * tui/tui-source.c (tui_set_source_content)
5969         (tui_source_is_displayed): Update.
5970         * tui/tui-layout.c (show_source_disasm_command, show_data)
5971         (show_source_or_disasm_and_command): Update.
5972         * tui/tui-disasm.c (tui_set_disassem_content)
5973         (tui_get_begin_asm_address): Update.
5974         * tui/tui-data.h (struct tui_locator_element): Remove.
5975         (union tui_which_element) <locator>: Remove.
5976         (struct tui_locator_window): New.
5977         (tui_locator_win_info_ptr): Change return type.
5978         * tui/tui-data.c (_locator): Change type.
5979         (tui_locator_win_info_ptr): Change return type.
5980         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5981         (tui_alloc_content): Add assert.
5982
5983 2019-06-25  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui-winsource.c
5986         (tui_exec_info_window::maybe_allocate_content): New method.
5987         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5988         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5989         (make_source_or_disasm_window): Add cast.
5990         * tui/tui-data.h (union tui_which_element) <simple_string>:
5991         Remove.
5992         (struct tui_source_info): New.
5993         (struct tui_source_window_base) <execution_info>: Change type.
5994         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5995         case, and add assert.
5996         (tui_alloc_content): Add assert.
5997
5998 2019-06-25  Tom Tromey  <tom@tromey.com>
5999
6000         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6001         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6002         * tui/tui-data.c (tui_alloc_win_info): Remove.
6003
6004 2019-06-25  Tom Tromey  <tom@tromey.com>
6005
6006         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6007         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6008         can_highlight.
6009
6010 2019-06-25  Tom Tromey  <tom@tromey.com>
6011
6012         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6013         make_visible_with_new_height method.
6014         (tui_win_info::make_visible_with_new_height): New method.
6015         (tui_source_window_base::do_make_visible_with_new_height)
6016         (tui_data_window::do_make_visible_with_new_height)
6017         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6018         (make_visible_with_new_height): Remove.
6019         (tui_resize_all, tui_adjust_win_heights): Use
6020         make_visible_with_new_height method.
6021         * tui/tui-data.h (struct tui_win_info)
6022         <do_make_visible_with_new_height, make_visible_with_new_height>:
6023         New methods.
6024         (struct tui_source_window_base, struct tui_data_window)
6025         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6026         methods.
6027
6028 2019-06-25  Tom Tromey  <tom@tromey.com>
6029
6030         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6031         method.
6032         (update_tab_width): Call update_tab_width method.
6033         * tui/tui-data.h (struct tui_win_info)
6034         (struct tui_source_window_base) <update_tab_width>: New methods.
6035
6036 2019-06-25  Tom Tromey  <tom@tromey.com>
6037
6038         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6039         parameter.
6040         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6041         parameter.
6042         (tui_gen_win_info::make_visible): Update.
6043         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6044         parameter.
6045         * tui/tui-data.h (enum tui_box): New enum.
6046         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6047
6048 2019-06-25  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6051         init_and_make_win for EXEC_INFO_WIN.
6052         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6053         longer inline.
6054         (struct tui_win_info) <~tui_win_info>: Inline.
6055         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6056         Don't declare.
6057         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6058         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6059         Remove.
6060         (tui_initialize_static_data): Update.
6061         (~tui_gen_win_info): Handle more cleanup here.
6062         (~tui_source_window_base): Delete "execution_info".
6063         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6064
6065 2019-06-25  Tom Tromey  <tom@tromey.com>
6066
6067         * tui/tui-layout.c (make_command_window): Don't set
6068         can_highlight.
6069         (show_source_disasm_command): Call the reset method.
6070         (show_data): Don't set can_highlight.  Call the reset method.
6071         (tui_gen_win_info::reset): Rename from init_gen_win_info
6072         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6073         (show_source_or_disasm_and_command): Call the reset method.
6074         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6075         (struct tui_cmd_window): Set can_highlight.
6076
6077 2019-06-25  Tom Tromey  <tom@tromey.com>
6078
6079         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6080         from make_visible.
6081         (tui_make_visible, tui_make_invisible): Rewrite.
6082         (tui_win_info::make_visible): Remove.
6083         (tui_source_window_base::make_visible): Update.
6084         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6085         method.  Moved from...
6086         (struct tui_win_info) <make_visible>: ...here.
6087
6088 2019-06-25  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-winsource.c
6091         (tui_source_window_base::do_scroll_horizontal): Remove direction
6092         parameter.
6093         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6094         direction parameter.
6095         * tui/tui-win.c (tui_win_info::forward_scroll)
6096         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6097         (tui_win_info::right_scroll): Update.
6098         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6099         direction parameter.
6100         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6101         direction parameter.
6102         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6103         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6104         Remove direction parameter.
6105         (struct tui_source_window_base, struct tui_source_window)
6106         (struct tui_disasm_window, struct tui_data_window)
6107         (struct tui_cmd_window): Update.
6108
6109 2019-06-25  Tom Tromey  <tom@tromey.com>
6110
6111         * tui/tui-winsource.h (tui_set_exec_info_content)
6112         (tui_show_exec_info_content, tui_erase_exec_info_content)
6113         (tui_clear_exec_info_content, tui_update_exec_info): Change
6114         argument to tui_source_window_base.
6115         * tui/tui-winsource.c (tui_set_exec_info_content)
6116         (tui_show_exec_info_content, tui_erase_exec_info_content)
6117         (tui_clear_exec_info_content, tui_update_exec_info): Change
6118         argument to tui_source_window_base.
6119
6120 2019-06-25  Tom Tromey  <tom@tromey.com>
6121
6122         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6123         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6124
6125 2019-06-25  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6128         check.
6129
6130 2019-06-25  Tom Tromey  <tom@tromey.com>
6131
6132         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6133         type to void.
6134         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6135         type to void.
6136         * tui/tui-source.c (tui_set_source_content): Update.
6137         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6138
6139 2019-06-25  Tom Tromey  <tom@tromey.com>
6140
6141         * tui/tui-win.c (window_name_completer, tui_set_focus)
6142         (tui_all_windows_info): Use name method.
6143         * tui/tui-data.h (struct tui_gen_win_info)
6144         (struct tui_source_window, struct tui_disasm_window)
6145         (struct tui_data_window, struct tui_cmd_window) <name>: New
6146         method.
6147         (tui_win_name): Don't declare.
6148         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6149         (tui_win_name): Remove.
6150
6151 2019-06-25  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui-winsource.h (tui_update_source_window)
6154         (tui_update_source_window_as_is): Change parameter type.
6155         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6156         to be a tui_source_window_base.
6157         (tui_update_source_window_as_is): Likewise.
6158         * tui/tui-win.c (make_visible_with_new_height): Update.
6159
6160 2019-06-25  Tom Tromey  <tom@tromey.com>
6161
6162         * tui/tui-winsource.c (tui_erase_source_content)
6163         (tui_show_source_content, tui_show_exec_info_content)
6164         (tui_erase_exec_info_content): Use refresh_window method.
6165         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6166         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6167         from tui_refresh_win.
6168         (tui_data_window::refresh_window): New method.
6169         (tui_win_info::refresh, tui_source_window_base::refresh)
6170         (tui_refresh_all): Use refresh_window method.
6171         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6172         method.
6173         * tui/tui-regs.c (tui_display_register): Call refresh_window
6174         method.
6175         * tui/tui-layout.c (show_source_disasm_command)
6176         (show_source_or_disasm_and_command): Call refresh_window method.
6177         * tui/tui-data.h (struct tui_gen_win_info)
6178         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6179         New method.
6180
6181 2019-06-25  Tom Tromey  <tom@tromey.com>
6182
6183         * tui/tui.c (tui_rl_other_window, tui_enable)
6184         (tui_is_window_visible, tui_get_command_dimension): Update.
6185         * tui/tui-winsource.c (tui_update_source_window_as_is)
6186         (tui_clear_source_content, tui_erase_source_content)
6187         (tui_show_source_line, tui_source_window_base::refill)
6188         (tui_source_window_base::do_scroll_horizontal)
6189         (tui_source_window_base::set_is_exec_point_at)
6190         (tui_update_breakpoint_info, tui_set_exec_info_content)
6191         (tui_alloc_source_buffer, tui_line_is_displayed)
6192         (tui_addr_is_displayed): Update.
6193         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6194         (tui_check_and_display_highlight_if_needed)
6195         (tui_win_info::make_visible, tui_win_info::refresh)
6196         (tui_refresh_all): Update.
6197         * tui/tui-windata.c (tui_first_data_item_displayed)
6198         (tui_delete_data_content_windows, tui_erase_data_content)
6199         (tui_display_all_data, tui_data_window::refresh_all)
6200         (tui_check_data_values): Update.
6201         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6202         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6203         (tui_win_info::backward_scroll, tui_refresh_all_win)
6204         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6205         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6206         (tui_source_window_base::set_new_height)
6207         (tui_data_window::set_new_height)
6208         (make_invisible_and_set_new_height)
6209         (make_visible_with_new_height, new_height_ok)
6210         (parse_scrolling_args): Update.
6211         * tui/tui-stack.c (tui_show_frame_info): Update.
6212         * tui/tui-source.c (tui_set_source_content)
6213         (tui_set_source_content_nil, tui_source_is_displayed)
6214         (tui_source_window::do_scroll_vertical): Update.
6215         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6216         (tui_display_registers_from, tui_display_reg_element_at_line)
6217         (tui_check_register_values, tui_reg_command): Update.
6218         * tui/tui-layout.c (tui_default_win_height)
6219         (show_source_disasm_command, show_data, init_and_make_win)
6220         (show_source_or_disasm_and_command): Update.
6221         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6222         (tui_redisplay_readline, tui_mld_flush)
6223         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6224         (tui_getc): Update.
6225         * tui/tui-disasm.c (tui_set_disassem_content)
6226         (tui_disasm_window::do_scroll_vertical): Update.
6227         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6228         Now virtual.
6229         (struct tui_win_info): Derive from tui_gen_win_info.
6230         <~tui_win_info>: Mark as override.
6231         <generic>: Remove member.
6232         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6233         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6234         (~tui_data_window, ~tui_win_info)
6235         (tui_free_all_source_wins_content): Update.
6236         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6237
6238 2019-06-25  Tom Tromey  <tom@tromey.com>
6239
6240         * tui/tui-layout.c (init_and_make_win): Use new.
6241         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6242         destructor, initializers.
6243         (tui_alloc_generic_win_info): Don't declare.
6244         * tui/tui-data.c (_locator): Add argument to constructor.
6245         (source_win, disasm_win): New globals.
6246         (exec_info): Remove.
6247         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6248         Update.
6249         (tui_alloc_generic_win_info): Remove.
6250         (init_content_element): Use new.
6251         (tui_win_info::tui_win_info): Update.
6252         (free_content_elements) <case DATA_WIN>: Use delete.
6253
6254 2019-06-25  Tom Tromey  <tom@tromey.com>
6255
6256         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6257         * tui/tui-windata.c (tui_first_data_item_displayed)
6258         (tui_delete_data_content_windows): Update.
6259         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6260         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6261         (tui_display_registers_from, tui_check_register_values): Update.
6262         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6263         pointer.
6264         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6265         window.
6266         (tui_free_data_content): Update.
6267         (free_content_elements) <case DATA_WIN>: Free the window.
6268
6269 2019-06-25  Tom Tromey  <tom@tromey.com>
6270
6271         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6272         Update.
6273         * tui/tui-layout.c (make_command_window)
6274         (show_source_disasm_command, show_data, init_and_make_win)
6275         (show_source_or_disasm_and_command): Update.
6276         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6277         method.
6278         <can_highight, is_highlighted>: Now bool.
6279         (tui_set_win_highlight): Don't declare.
6280         * tui/tui-data.c (tui_set_win_highlight): Remove.
6281
6282 2019-06-25  Tom Tromey  <tom@tromey.com>
6283
6284         * tui/tui-wingeneral.c (make_visible): Remove check of window
6285         type.
6286
6287 2019-06-25  Tom Tromey  <tom@tromey.com>
6288
6289         * tui/tui-win.c (tui_win_info::max_height)
6290         (tui_cmd_window::max_height): New methods.
6291         (new_height_ok): Call max_height.
6292         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6293         <max_height>: New method.
6294
6295 2019-06-25  Tom Tromey  <tom@tromey.com>
6296
6297         * tui/tui-win.c (tui_source_window_base::set_new_height)
6298         (tui_data_window::set_new_height): New methods.
6299         (make_invisible_and_set_new_height): Call set_new_height method.
6300         * tui/tui-data.h (struct tui_win_info)
6301         (struct tui_source_window_base, struct tui_data_window)
6302         <set_new_height>: New method.
6303
6304 2019-06-25  Tom Tromey  <tom@tromey.com>
6305
6306         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6307         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6308         tui_refresh_data_win.
6309         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6310         method.
6311         (tui_refresh_all_win): Call the refresh_all method.
6312         (tui_set_focus): Likewise.
6313         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6314         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6315         Likewise.
6316
6317 2019-06-25  Tom Tromey  <tom@tromey.com>
6318
6319         * tui/tui-winsource.h (tui_refill_source_window)
6320         (tui_set_is_exec_point_at): Don't declare.
6321         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6322         (tui_source_window_base::refill): Rename from
6323         tui_refill_source_window.
6324         (tui_source_window_base::do_scroll_horizontal): Update.
6325         (tui_source_window_base::set_is_exec_point_at): Rename from
6326         tui_set_is_exec_point_at.
6327         (tui_update_all_breakpoint_info): Update.
6328         * tui/tui-stack.c (tui_show_frame_info): Update.
6329         * tui/tui-layout.c (show_data): Add cast.
6330         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6331         * tui/tui-data.h (struct tui_source_window_base) <refill,
6332         set_is_exec_point_at>: New methods.
6333         (tui_source_windows, tui_add_to_source_windows): Update types.
6334         (tui_add_to_source_windows): Remove redundant declaration.
6335         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6336         (tui_source_windows): Change return type.
6337         (tui_clear_source_windows_detail): Update.
6338         (tui_add_to_source_windows): Change type of parameter.
6339         (tui_free_all_source_wins_content): Update.
6340
6341 2019-06-25  Tom Tromey  <tom@tromey.com>
6342
6343         * tui/tui-wingeneral.c (tui_win_info::refresh)
6344         (tui_source_window_base::refresh): New methods.
6345         (tui_refresh_all): Call the refresh method.
6346         * tui/tui-data.h (struct tui_win_info)
6347         (struct tui_source_window_base) <refresh>: New method.
6348
6349 2019-06-25  Tom Tromey  <tom@tromey.com>
6350
6351         * tui/tui.h (tui_is_window_visible): Return bool.
6352         * tui/tui.c (tui_is_window_visible): Return bool.
6353         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6354         (tui_make_visible, tui_make_invisible)
6355         (tui_win_info::make_visible)
6356         (tui_source_window_base::make_visible, make_all_visible)
6357         (tui_make_all_visible, tui_make_all_invisible): Update.
6358         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6359         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6360         bool.
6361         (struct tui_win_info, struct tui_source_window_base)
6362         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6363         * tui/tui-data.c (tui_init_generic_part): Update.
6364
6365 2019-06-25  Tom Tromey  <tom@tromey.com>
6366
6367         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6368         (tui_source_window_base::make_visible): New methods.
6369         (make_all_visible): Make method call.
6370         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6371         (struct tui_source_window_base, struct tui_cmd_window): Override
6372         make_visible.
6373         (tui_win_is_source_type): Don't declare.
6374         * tui/tui-data.c (tui_win_is_source_type): Remove.
6375
6376 2019-06-25  Tom Tromey  <tom@tromey.com>
6377
6378         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6379         NULL check.
6380
6381 2019-06-25  Tom Tromey  <tom@tromey.com>
6382
6383         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6384         Inline constructor.  Add initializers for members.
6385         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6386         constructors; now inline in class.
6387
6388 2019-06-25  Tom Tromey  <tom@tromey.com>
6389
6390         * tui/tui-regs.c (tui_show_registers): Update.
6391         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6392         bool.
6393         * tui/tui-data.c (tui_data_window::clear_detail)
6394         (tui_data_window): Update.
6395
6396 2019-06-25  Tom Tromey  <tom@tromey.com>
6397
6398         * tui/tui-windata.c (tui_display_all_data)
6399         (tui_display_data_from_line, tui_display_data_from)
6400         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6401         Update.
6402         * tui/tui-regs.c (tui_last_regs_line_no)
6403         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6404         (tui_show_registers, tui_show_register_group)
6405         (tui_display_registers_from, tui_display_reg_element_at_line)
6406         (tui_display_registers_from_line, tui_check_register_values)
6407         (tui_reg_next, tui_reg_prev): Update.
6408         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6409         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6410         tui_data_window.
6411         (struct tui_win_info) <detail>: Remove.  Add new fields from
6412         tui_data_info.
6413         (TUI_DATA_WIN): Add cast.
6414         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6415         (~tui_data_window): Simplify.
6416
6417 2019-06-25  Tom Tromey  <tom@tromey.com>
6418
6419         * tui/tui-layout.c (show_source_disasm_command)
6420         (show_source_or_disasm_and_command): Update.
6421         * tui/tui-io.c (update_cmdwin_start_line)
6422         (tui_redisplay_readline): Update.
6423         * tui/tui-data.h (struct tui_command_info): Remove.
6424         (struct tui_win_info) <detail>: Remove command_info member.
6425         (struct tui_data_window) <start_line>: New member, from
6426         tui_command_info.
6427         (TUI_CMD_WIN): Add casts.
6428
6429 2019-06-25  Tom Tromey  <tom@tromey.com>
6430
6431         * tui/tui-winsource.c (tui_update_source_window)
6432         (tui_refill_source_window)
6433         (tui_source_window_base::do_scroll_horizontal)
6434         (tui_update_breakpoint_info, tui_set_exec_info_content)
6435         (tui_show_exec_info_content, tui_erase_exec_info_content)
6436         (tui_clear_exec_info_content): Update.
6437         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6438         Update.
6439         * tui/tui-win.c (make_invisible_and_set_new_height)
6440         (make_visible_with_new_height): Update.
6441         * tui/tui-source.c (tui_set_source_content)
6442         (tui_show_symtab_source): Update.
6443         * tui/tui-layout.c (extract_display_start_addr)
6444         (show_source_disasm_command, show_data)
6445         (make_source_or_disasm_window)
6446         (show_source_or_disasm_and_command): Update.
6447         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6448         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6449         "gdbarch".
6450         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6451         to tui_source_window_base.
6452         (struct tui_win_info) <detail>: Remove source_info member.
6453         (struct tui_source_window_base) <has_locator>: Inline.
6454         Move contents from tui_source_info; rename has_locator member to
6455         m_has_locator.
6456         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6457         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6458         header file.
6459         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6460         Simplify.
6461         (tui_free_all_source_wins_content): Cast to
6462         tui_source_window_base.
6463
6464 2019-06-25  Tom Tromey  <tom@tromey.com>
6465
6466         * tui/tui-win.c (make_invisible_and_set_new_height)
6467         (make_visible_with_new_height): Call has_locator method.
6468         * tui/tui-layout.c (show_source_disasm_command, show_data)
6469         (show_source_or_disasm_and_command): Update for bool change.
6470         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6471         (tui_win_info) <has_locator>: New method.
6472         (struct tui_source_window_base) <has_locator>: New method.
6473         (tui_win_has_locator): Don't declare.
6474         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6475         from tui_win_has_locator.
6476         (tui_source_window_base): Use false, not FALSE.
6477
6478 2019-06-25  Tom Tromey  <tom@tromey.com>
6479
6480         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6481         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6482         clear_detail method directly.
6483         (tui_clear_win_detail): Remove.
6484
6485 2019-06-25  Tom Tromey  <tom@tromey.com>
6486
6487         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6488         "this", not TUI_DISASM_WIN.
6489
6490 2019-06-25  Tom Tromey  <tom@tromey.com>
6491
6492         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6493         declare.
6494         * tui/tui-winsource.c
6495         (tui_source_window_base::do_scroll_horizontal): Rename from
6496         tui_horizontal_source_scroll.
6497         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6498         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6499         from tui_vertical_data_scroll.
6500         * tui/tui-win.h (tui_scroll): Don't declare.
6501         * tui/tui-win.c (tui_win_info::forward_scroll)
6502         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6503         (tui_win_info::right_scroll): Rename and update.
6504         (tui_scroll_forward_command, tui_scroll_backward_command)
6505         (tui_scroll_left_command, tui_scroll_right_command): Update.
6506         (tui_scroll): Remove.
6507         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6508         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6509         from tui_vertical_source_scroll.
6510         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6511         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6512         from tui_vertical_disassem_scroll.
6513         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6514         do_scroll_horizontal>: New methods.
6515         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6516         Likewise.
6517         (struct tui_source_window_base): Add do_scroll_horizontal.
6518         (struct tui_source_window, struct tui_disasm_window): Add
6519         do_scroll_vertical.
6520         (struct tui_data_window, struct tui_cmd_window): Add
6521         do_scroll_horizontal and do_scroll_vertical.
6522         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6523
6524 2019-06-25  Tom Tromey  <tom@tromey.com>
6525
6526         * tui/tui-data.h (struct tui_source_window_base): New struct.
6527         (struct tui_source_window): Derive from tui_source_window_base.
6528         (struct tui_disasm_window): New struct.
6529         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6530         from tui_source_window::clear_detail.
6531         (tui_source_window_base): Rename from tui_source_window.
6532         (~tui_source_window_base): Rename from ~tui_source_window.
6533         (tui_alloc_win_info): Create a tui_disasm_window.
6534
6535 2019-06-25  Tom Tromey  <tom@tromey.com>
6536
6537         * tui/tui-data.h (struct tui_source_window)
6538         (struct tui_data_window): Declare destructors.
6539         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6540         destructors.
6541         (tui_win_info): Simplify.
6542
6543 2019-06-25  Tom Tromey  <tom@tromey.com>
6544
6545         * tui/tui-winsource.c (tui_display_main)
6546         (tui_update_source_windows_with_addr)
6547         (tui_update_all_breakpoint_info): Update.
6548         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6549         (new_height_ok, parse_scrolling_args): Update.
6550         * tui/tui-stack.c (tui_show_frame_info): Update.
6551         * tui/tui-data.h (struct tui_list): Remove.
6552         (tui_source_windows): Return a reference to a std::vector.
6553         * tui/tui-data.c (source_windows): Now a std::vector.
6554         (tui_source_windows): Change return type.
6555         (tui_clear_source_windows): Rewrite.
6556         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6557         (tui_free_all_source_wins_content): Rewrite.
6558
6559 2019-06-25  Tom Tromey  <tom@tromey.com>
6560
6561         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6562         (struct tui_data_window, struct tui_cmd_window): Declare
6563         clear_detail method.
6564         * tui/tui-data.c (tui_source_window::clear_detail)
6565         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6566         methods.
6567         (tui_clear_win_detail): Simplify.
6568
6569 2019-06-25  Tom Tromey  <tom@tromey.com>
6570
6571         * tui/tui-layout.c (make_source_window, make_disasm_window)
6572         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6573         Return the new window.
6574         (show_source_disasm_command, show_data)
6575         (show_source_or_disasm_and_command): Update.
6576
6577 2019-06-25  Tom Tromey  <tom@tromey.com>
6578
6579         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6580         parameter.  Return the new window.
6581         (show_source_disasm_command): Update and remove NULL check.
6582         (show_source_or_disasm_and_command): Update.
6583
6584 2019-06-25  Tom Tromey  <tom@tromey.com>
6585
6586         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6587
6588 2019-06-25  Tom Tromey  <tom@tromey.com>
6589
6590         * tui/tui-data.h (struct tui_win_info): Make constructor
6591         protected.  Make destructor virtual.  Add initializers.
6592         (tui_source_window, tui_data_window, tui_cmd_window): New
6593         classes.
6594         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6595         constructor.  Add "type" parameter.
6596         (tui_source_window, tui_data_window, tui_cmd_window): New
6597         constructors.
6598         (tui_alloc_win_info): Instantiate the appropriate subclass.
6599
6600 2019-06-25  Tom Tromey  <tom@tromey.com>
6601
6602         * tui/tui-win.c (tui_resize_all): Use delete.
6603         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6604         destructor.
6605         (tui_free_window): Don't declare.
6606         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6607         Update.
6608
6609 2019-06-25  Tom Tromey  <tom@tromey.com>
6610
6611         * tui/tui-data.h (struct tui_win_info): Add constructor.
6612         * tui/tui-data.c (tui_alloc_win_info): Use new.
6613         (tui_free_window): Use delete.
6614
6615 2019-06-22  Tom Tromey  <tom@tromey.com>
6616
6617         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6618         declare.
6619         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6620
6621 2019-06-22  Tom Tromey  <tom@tromey.com>
6622
6623         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6624         declare.
6625         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6626
6627 2019-06-22  Tom de Vries  <tdevries@suse.de>
6628
6629         * dwarf2read.c (create_addrmap_from_aranges)
6630         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6631         instead of '%zu'.
6632
6633 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6634
6635         * dwarf2read.h (dwarf2_section_info_def): Remove.
6636         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6637         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6638         std::vector<dwarf2_section_info>.
6639         (struct dwo_file) <~dwo_file>: Remove.
6640         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6641         types field.
6642         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6643         (dwarf2_read_debug_names): Likewise.
6644         (create_debug_types_hash_table): Change parameter type to
6645         array_view, adjust code accordingly.
6646         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6647         (partial_die_info::fixup): Likewise.
6648         (determine_prefix): Likewise.
6649         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6650
6651 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6652
6653         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6654         gdb_bfd_ref_ptr.
6655         <~dwo_file>: Remove call to gdb_bfd_unref.
6656         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6657         gdb_bfd_ref_ptr::get.
6658
6659 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6660
6661         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6662         type to htab_up.
6663         * dwarf2read.c (struct dwo_file): Initialize fields.
6664         <~dwo_file>: New.
6665         (free_dwo_file): Remove, move content to ~dwo_file.
6666         (struct dwo_file_deleter): Remove.
6667         (dwo_file_up>: Remove custom deleter.
6668         (free_dwo_files): Remove.
6669         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6670         dwo_files.
6671         (process_skeletonless_type_units): Call unique_ptr::get.
6672         (allocate_dwo_file_hash_table): Add deleter to created hash
6673         table.  Change return type to htab_up.
6674         (lookup_dwo_file_slot): Don't memset dwo_file, call
6675         unique_ptr::get.
6676         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6677         (create_dwo_unit_in_dwp_v2): Likewise.
6678         (open_and_init_dwo_file): Likewise.
6679         (free_dwo_file_from_slot): Remove.
6680
6681 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6682
6683         * dwarf2read.h (struct dwarf2_section_info) <readin,
6684         is_virtual>: Change type to bool.
6685         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6686         true instead of 1.
6687
6688 2019-06-19  Tom Tromey  <tom@tromey.com>
6689
6690         * tui/tui-data.h (tui_init_content_element): Don't declare.
6691
6692 2019-06-19  Tom Tromey  <tom@tromey.com>
6693
6694         * tui/tui-data.h (tui_init_win_info): Don't declare.
6695
6696 2019-06-19  Tom de Vries  <tdevries@suse.de>
6697
6698         * dwarf2read.h (abstract_to_concrete): Change type to
6699         std::unordered_map<sect_offset, std::vector<sect_offset>,
6700         gdb::hash_enum<sect_offset>>.
6701
6702 2019-06-19  Tom Tromey  <tromey@adacore.com>
6703
6704         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6705         EVAL_AVOID_SIDE_EFFECTS specially.
6706
6707 2019-06-19  Tom Tromey  <tromey@adacore.com>
6708
6709         * source-cache.c (highlighter): New global.
6710         (source_cache::get_source_lines): Create a highlighter on demand.
6711
6712 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6713
6714         * defs.h (deprecated_interactive_hook): Delete declaration.
6715         * interps.c (clear_interpreter_hooks): Remove use of
6716         deprecated_interactive_hook.
6717         * top.c (deprecated_interactive_hook): Delete definition.
6718         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6719
6720 2019-06-18  Tom de Vries  <tdevries@suse.de>
6721
6722         PR gdb/24515
6723         * dwarf2read.h (abstract_to_concrete): Change type from
6724         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6725         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6726         * dwarf2read.c (read_variable): Update.
6727         (dwarf2_fetch_die_loc_sect_off): Update.
6728
6729 2019-06-17  Tom de Vries  <tdevries@suse.de>
6730
6731         PR gdb/24617
6732         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6733         accessing parent[parent_len - 1].
6734
6735 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6736
6737         PR gdb/24364
6738         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6739         call dtrace_process_dof with NULL dof.
6740
6741 2019-06-16  Tom de Vries  <tdevries@suse.de>
6742
6743         PR gdb/24445
6744         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6745
6746 2019-06-16  Tom Tromey  <tom@tromey.com>
6747
6748         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6749         (make_all_visible): Use address of member.
6750
6751 2019-06-16  Tom Tromey  <tom@tromey.com>
6752
6753         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6754         (tui_free_window, free_content, free_content_elements): Remove
6755         unnecessary cast.
6756         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6757         cast.
6758         * tui/tui-regs.c (tui_show_register_group)
6759         (tui_display_registers_from, tui_display_reg_element_at_line):
6760         Remove unnecessary cast.
6761
6762 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6763
6764         * linux-nat.c (normal_mask): Delete.
6765         (_initialize_linux_nat): Don't initialise normal_mask.
6766
6767 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6768
6769         PR gdb/24445
6770         * dwarf-index-write.h (write_psymtabs_to_index): Add
6771         dwz_basename parameter.
6772         * dwarf-index-write.c (write_gdbindex): Move file writing to
6773         write_gdbindex_1.  Change return type void.
6774         (assert_file_size): Move up, remove filename parameter.
6775         (write_gdbindex_1): New function.
6776         (write_debug_names): Change return type to void, call
6777         assert_file_size.
6778         (struct index_wip_file): New struct.
6779         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6780         file logic to index_wip_file.  Write index for dwz file if
6781         needed.
6782         (save_gdb_index_command): Pass basename of dwz file, if present.
6783         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6784         build-id of dwz file, if present.
6785         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6786         (dwarf2_get_dwz_file): Likewise.
6787         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6788         (dwarf2_get_dwz_file): Likewise.
6789
6790 2019-06-16  Tom Tromey  <tom@tromey.com>
6791
6792         * coffread.c (process_coff_symbol): Use xstrdup.
6793         * value.c (create_internalvar): Use xstrdup.
6794
6795 2019-06-16  Tom Tromey  <tom@tromey.com>
6796
6797         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6798         * breakpoint.c (stopin_command, stopat_command)
6799         (until_break_command, decode_location_default): Remove unnecessary
6800         cast.
6801         * utils.c (subset_compare): Remove unnecessary cast.
6802         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6803         cast.
6804         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6805         cast.
6806         * infcmd.c (path_command): Remove unnecessary cast.
6807         * coffread.c (decode_type): Remove unnecessary cast.
6808         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6809         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6810         * tui/tui-stack.c (tui_show_locator_content)
6811         (tui_show_frame_info): Remove unnecessary cast.
6812         * tui/tui-win.c (tui_scroll_forward_command)
6813         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6814         (parse_scrolling_args): Remove unnecessary cast.
6815         * tui/tui-data.c (init_win_info, tui_del_window)
6816         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6817         (free_content_elements): Remove unnecessary cast.
6818         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6819         unnecessary cast.
6820         * tui/tui-source.c (tui_set_source_content)
6821         (tui_vertical_source_scroll): Remove unnecessary cast.
6822         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6823         cast.
6824         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6825         * tui/tui-regs.c (tui_display_registers_from)
6826         (tui_display_register): Remove unnecessary cast.
6827         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6828         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6829         (make_visible): Remove unnecessary cast.
6830         * tui/tui-winsource.c (tui_erase_source_content)
6831         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6832         unnecessary cast.
6833         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6834         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6835         * stabsread.c (read_type, read_array_type, read_range_type):
6836         Remove unnecessary cast.
6837         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6838         (parse_symbol, parse_type, upgrade_type, parse_external)
6839         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6840         unnecessary cast.
6841         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6842
6843 2019-06-16  Tom Tromey  <tom@tromey.com>
6844
6845         * tui/tui-data.c (tui_alloc_generic_win_info)
6846         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6847         checks.
6848
6849 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6850             Andrew Burgess  <andrew.burgess@embecosm.com>
6851
6852         * f-typeprint.c (f_print_type): Don't return early for not
6853         associated or not allocated types.
6854         (f_type_print_varspec_suffix): Add print_rank parameter and print
6855         ranks of array types in case they dangling.
6856         (f_type_print_base): Add print_rank parameter.
6857
6858 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6859
6860         * NEWS: Mention new MI commands.
6861         * break-catch-throw.c (enum exception_event_kind): Move to
6862         breakpoint.h.
6863         (print_mention_exception_catchpoint): Output text as a single
6864         message.
6865         (catch_exception_command_1): Rename to...
6866         (catch_exception_event): ...this, make non-static, update header
6867         command, and change some parameter types.
6868         (catch_catch_command): Update for changes to
6869         catch_exception_command_1.
6870         (catch_throw_command): Likewise.
6871         (catch_rethrow_command): Likewise.
6872         * breakpoint.c (enum exception_event_kind): Delete.
6873         * breakpoint.h (enum exception_event_kind): Moved here from
6874         break-catch-throw.c.
6875         (catch_exception_event): Declare.
6876         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6877         (mi_cmd_catch_throw): New function.
6878         (mi_cmd_catch_rethrow): New function.
6879         (mi_cmd_catch_catch): New function.
6880         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6881         'catch-catch' entries.
6882         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6883         (mi_cmd_catch_rethrow): Declare.
6884         (mi_cmd_catch_catch): Declare.
6885
6886 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6887
6888         * annotate.c (annotate_source_line): Change return type to void,
6889         update implementation to match.
6890         * annotate.h (annotate_source_line): Change return type to void,
6891         update header comment.
6892         * stack.c (print_frame_info): Don't change what frame information
6893         is printed based on whether annotations are on or not.
6894
6895 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6896
6897         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6898         (annotate_source): Make static.
6899         (annotate_source_line): Moved from source.c and renamed from
6900         identify_source_line.  Update the return type.
6901         * annotate.h (annotate_source): Delete declaration.
6902         (annotate_source_line): Declaration moved from source.h, and
6903         renamed from identify_source_line.  Return type updated.
6904         * source.c (identify_source_line): Moved to annotate.c and renamed
6905         to annotate_source_line.
6906         (info_line_command): Remove check of annotation_level.
6907         * source.h (identify_source_line): Move declaration to annotate.h
6908         and rename to annotate_source_line.
6909         * stack.c: Add 'annotate.h' include.
6910         (print_frame_info): Remove check of annotation_level before
6911         calling annotate_source_line.
6912
6913 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6914
6915         * source-cache.c (source_cache::get_plain_source_lines): Use
6916         open_source_file_with_line_charpos instead of just
6917         open_source_file, remove call to find_source_lines.
6918         (source_cache::get_source_lines): Likewise.
6919         * source.c (find_source_lines): Make static.
6920         (get_filename_and_charpos): Renamed into...
6921         (open_source_file_with_line_charpos): ..this along with changes to
6922         return a scoped_fd, and some other minor clean ups.
6923         (identify_source_line): Use open_source_file_with_line_charpos.
6924         (search_command_helper): Use open_source_file_with_line_charpos
6925         instead of just open_source_file, remove call to
6926         find_source_lines.
6927         * source.h (open_source_file_with_line_charpos): Declare new
6928         function.
6929         (find_source_lines): Delete declaration.
6930
6931 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6932
6933         * source.c (get_filename_and_charpos): Remove fullname
6934         parameter.
6935         (identify_source_line): Update call to get_filename_and_charpos.
6936
6937 2019-06-14  Tom Tromey  <tromey@adacore.com>
6938
6939         PR gdb/24502:
6940         * ui-style.h (skip_ansi_escape): Update comment.
6941         * ui-file.h (class no_terminal_escape_file): New class.
6942         * ui-file.c (no_terminal_escape_file::write)
6943         (no_terminal_escape_file::puts): New methods.
6944         * cli/cli-logging.c (handle_redirections): Use
6945         no_terminal_escape_file.
6946
6947 2019-06-14  Tom Tromey  <tromey@adacore.com>
6948
6949         * NEWS: Move convenience variable news above Python news.
6950
6951 2019-06-14  Tom Tromey  <tom@tromey.com>
6952
6953         * gnulib: Move directory to top-level.
6954         * configure.ac: Don't configure gnulib.
6955         * configure: Rebuild.
6956         * common/common-defs.h: Use new path to gnulib.
6957         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6958         (GNULIB_H): Remove.
6959         (INCGNU): Look in new gnulib location.
6960         (HFILES_NO_SRCDIR): Remove gnulib files.
6961         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6962         (generated_files): Remove GNULIB_H.
6963         ($(LIBGNU), all-lib): Remove targets.
6964         (distclean): Don't mention GNULIB_BUILDDIR.
6965         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6966
6967 2019-06-14  Tom Tromey  <tromey@adacore.com>
6968
6969         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6970         Warn if symbol file does not provide any symbols.
6971
6972 2019-06-14  Tom Tromey  <tromey@adacore.com>
6973
6974         * source.c (find_and_open_source): Respect basenames_may_differ.
6975
6976 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6977
6978         * annotate.c (annotate_breakpoints_invalid): Make use of
6979         scoped_restore_terminal_state.
6980         (annotate_frames_invalid): Likewise.
6981
6982 2019-06-14  Tom Tromey  <tromey@adacore.com>
6983
6984         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6985         allow assignment to an internalvar.
6986
6987 2019-06-14  Tom Tromey  <tromey@adacore.com>
6988
6989         * ada-lex.l: Allow "_" in attribute names.
6990
6991 2019-06-14  Tom Tromey  <tromey@adacore.com>
6992
6993         PR gdb/24653:
6994         * regcache.c (registers_changed): Don't call alloca.
6995         * top.c (execute_command): Don't call alloca.
6996
6997 2019-06-13  Pedro Alves  <palves@redhat.com>
6998
6999         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7000         'expression'.  When parsing an expression, error out if there's
7001         junk after "unlimited".
7002         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7003         (do_set_command): Adjust calls to is_unlimited_literal.
7004
7005 2019-06-13  Pedro Alves  <palves@redhat.com>
7006
7007         * compile/compile.c (make_compile_options_def_group): Add braces
7008         around array_view initializer.
7009         * thread.c (make_thread_apply_all_options_def_group)
7010         (make_thread_apply_all_options_def_group): Likewise.
7011
7012 2019-06-13  Pedro Alves  <palves@redhat.com>
7013
7014         * NEWS (New commands): Mention "maint test-options
7015         require-delimiter", "maint test-options unknown-is-error", "maint
7016         test-options unknown-is-operand" and "maint show
7017         test-options-completion-result".
7018         (New command options, command completion): New section.
7019         (Completion improvements): New section.
7020         Mention that you can abbreviate "unlimited".
7021
7022 2019-06-13  Pedro Alves  <palves@redhat.com>
7023
7024         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7025         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7026         * unittests/cli-utils-selftests.c (test_parse_flags)
7027         (test_parse_flags_qcs): Delete.
7028         (test_cli_utils): Don't call deleted functions.
7029
7030 2019-06-13  Pedro Alves  <palves@redhat.com>
7031
7032         * thread.c: Include "cli/cli-option.h".
7033         (tp_array_compar_ascending): Global.
7034         (tp_array_compar): Delete function.
7035         (tp_array_compar_ascending, tp_array_compar_descending): New
7036         functions.
7037         (ascending_option_def, qcs_flag_option_def)
7038         (thr_qcs_flags_option_defs)
7039         (make_thread_apply_all_options_def_group)
7040         (make_thread_apply_options_def_group): New.
7041         (thread_apply_all_command): Use gdb::option::process_options.
7042         (thread_apply_command_completer)
7043         (thread_apply_all_command_completer): New.
7044         (thread_apply_command): Use gdb::option::process_options.
7045         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7046         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7047         to generate help text of "thread apply".  Adjust "taas"'s help.
7048         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7049         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7050
7051 2019-06-13  Pedro Alves  <palves@redhat.com>
7052
7053         * thread.c (thread_apply_command): Check for invalid TID with
7054         isdigit instead of !isalpha.
7055
7056 2019-06-13  Pedro Alves  <palves@redhat.com>
7057
7058         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7059         (validate_flags_qcs): New.
7060         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7061         (validate_flags_qcs): Declare.
7062         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7063         (make_frame_apply_options_def_group): New.
7064         (frame_apply_command_count): Process options with
7065         gdb::option::process_options.
7066         (frame_apply_completer): New.
7067         (frame_apply_level_completer, frame_apply_all_completer)
7068         (frame_apply_completer): New.
7069         (_initialize_stack): Update help of "frame apply", "frame apply
7070         level", "frame apply all" and "faas" to mention supported options
7071         and install command completers.
7072         * stack.h (frame_apply_all_completer): Declare.
7073         * thread.c: Include "stack.h".
7074         (tfaas_command): Add "--".
7075         (_initialize_thread): Update help "tfaas" to mention supported
7076         options and install command completer.
7077
7078 2019-06-13  Pedro Alves  <palves@redhat.com>
7079
7080         * completer.c (complete_nested_command_line): New.
7081         (gdb_completion_word_break_characters_throw): Add assertion.
7082         * completer.h (complete_nested_command_line): Declare.
7083
7084 2019-06-13  Pedro Alves  <palves@redhat.com>
7085
7086         * stack.c (parse_backtrace_qualifiers): New.
7087         (backtrace_command): Use it.
7088         (backtrace_command_completer): Complete on qualifiers.
7089
7090 2019-06-13  Pedro Alves  <palves@redhat.com>
7091
7092         * frame.c: Include "cli/cli-option.h.
7093         (user_set_backtrace_options): New.
7094         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7095         Delete.
7096         (get_prev_frame): Adjust.
7097         (boolean_option_def, uinteger_option_def)
7098         (set_backtrace_option_defs): New.
7099         (_initialize_frame): Adjust and use
7100         gdb::option::add_setshow_cmds_for_options to install "set
7101         backtrace past-main" and "set backtrace past-entry".
7102         * frame.h: Include "cli/cli-option.h".
7103         (struct frame_print_options): Forward declare.
7104         (print_frame_arguments_all, print_frame_arguments_scalars)
7105         (print_frame_arguments_none): Declare.
7106         (print_entry_values): Delete declaration.
7107         (struct frame_print_options, user_frame_print_options): New.
7108         (struct set_backtrace_options): New.
7109         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7110         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7111         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7112         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7113         (list_args_or_locals): Add frame_print_options parameter.
7114         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7115         * python/py-framefilter.c (enumerate_args): Pass down
7116         USER_FRAME_PRINT_OPTIONS.
7117         * stack.c: Include "cli/cli-option.h".
7118         (print_frame_arguments_all, print_frame_arguments_scalars)
7119         (print_frame_arguments_none): Declare.
7120         (print_raw_frame_arguments, print_entry_values): Delete.
7121         (user_frame_print_options): New.
7122         (boolean_option_def, enum_option_def, frame_print_option_defs):
7123         New.
7124         (struct backtrace_cmd_options): New.
7125         (bt_flag_option_def): New.
7126         (backtrace_command_option_defs): New.
7127         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7128         (print_frame_arg, read_frame_arg, print_frame_args)
7129         (print_frame_info, print_frame): Add frame_print_options parameter
7130         and use it.
7131         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7132         (backtrace_command_1): Add frame_print_options and
7133         backtrace_cmd_options parameters and use them.
7134         (make_backtrace_options_def_group): New.
7135         (backtrace_command): Process command options with
7136         gdb::option::process_options.
7137         (backtrace_command_completer): New.
7138         (_initialize_stack): Extend "backtrace"'s help to mention
7139         supported options.  Install completer for "backtrace".
7140         Install some settings commands with add_setshow_cmds_for_options.
7141
7142 2019-06-13  Pedro Alves  <palves@redhat.com>
7143
7144         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7145         and that "set/show print raw frame-arguments" are now deprecated.
7146
7147         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7148         command.
7149         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7150         * stack.c (_initialize_stack): Install "set/show print
7151         raw-frame-arguments", and deprecate "set/show print raw
7152         frame-arguments".
7153         * valprint.c (_initialize_valprint): Deprecate "set/show print
7154         raw".
7155
7156 2019-06-13  Pedro Alves  <palves@redhat.com>
7157
7158         * compile/compile.c (struct compile_options): New.
7159         (compile_flag_option_def, compile_command_option_defs)
7160         (make_compile_options_def_group): New.
7161         (compile_file_command): Handle options with
7162         gdb::option::process_options.
7163         (compile_file_command_completer): New function.
7164         (compile_code_command): Handle options with
7165         gdb::option::process_options.
7166         (compile_code_command_completer): New function.
7167         (_initialize_compiler): Install completers for "compile code" and
7168         "compile file".  Mention available options in "compile code" and
7169         "compile code"'s help.
7170         * completer.c (advance_to_completion_word): New, factored out from
7171         ...
7172         (advance_to_expression_complete_word_point): ... this.
7173         (advance_to_filename_complete_word_point): New.
7174         * completer.h (advance_to_filename_complete_word_point): New
7175         declaration.
7176
7177 2019-06-13  Pedro Alves  <palves@redhat.com>
7178
7179         * compile/compile.c: Include "cli/cli-option.h".
7180         (compile_print_value): Scope data pointer is now a
7181         value_print_options pointer; adjust.
7182         (compile_print_command): Process options.  Scope data pointer is
7183         now a value_print_options pointer; adjust.
7184         (_initialize_compile): Update "compile print"'s help to include
7185         supported options.  Install a completer for "compile print".
7186         * cp-valprint.c (show_vtblprint, show_objectprint)
7187         (show_static_field_print): Delete.
7188         (_initialize_cp_valprint): Don't install "set print
7189         static-members", "set print vtbl", "set print object" here.
7190         * printcmd.c: Include "cli/cli-option.h" and
7191         "common/gdb_optional.h".
7192         (print_command_parse_format): Rework to fill in a
7193         value_print_options instead of a format_data.
7194         (print_value): Change parameter type from format_data pointer to
7195         value_print_options reference.  Adjust.
7196         (print_command_1): Process options.  Adjust to pass down a
7197         value_print_options.
7198         (print_command_completer): New.
7199         (_initialize_printcmd): Install print_command_completer as
7200         handle_brkchars completer for the "print" command.  Update
7201         "print"'s help to include supported options.
7202         * valprint.c: Include "cli/cli-option.h".
7203         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7204         here from cp-valprint.c.
7205         (boolean_option_def, uinteger_option_def)
7206         (value_print_option_defs, make_value_print_options_def_group):
7207         New.  Use gdb::option::add_setshow_cmds_for_options to install
7208         "set print elements", "set print null-stop", "set print repeats",
7209         "set print pretty", "set print union", "set print array", "set
7210         print address", "set print symbol", "set print array-indexes".
7211         * valprint.h: Include <string> and "cli/cli-option.h".
7212         (make_value_print_options_def_group): Declare.
7213         (print_value): Change parameter type from format_data pointer to
7214         value_print_options reference.
7215         (print_command_completer): Declare.
7216
7217 2019-06-13  Pedro Alves  <palves@redhat.com>
7218
7219         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7220         (COMMON_SFILES): Add maint-test-settings.c.
7221         * cli/cli-decode.c (boolean_enums): New global, factored out from
7222         ...
7223         (add_setshow_boolean_cmd): ... here.
7224         * cli/cli-decode.h (boolean_enums): Declare.
7225         * cli/cli-option.c: New file.
7226         * cli/cli-option.h: New file.
7227         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7228         factored out from ...
7229         (parse_cli_boolean_value(const char *)): ... this.
7230         (is_unlimited_literal): Change parameter type to pointer to
7231         pointer.  Adjust and advance ARG pointer.
7232         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7233         (parse_cli_var_enum): New, factored out from ...
7234         (do_set_command): ... this.  Adjust.
7235         * cli/cli-setshow.h (parse_cli_boolean_value)
7236         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7237         (parse_cli_var_enum): Declare.
7238         * cli/cli-utils.c: Include "cli/cli-option.h".
7239         (get_ulongest): New.
7240         * cli/cli-utils.h (get_ulongest): Declare.
7241         (check_for_argument): New overloads.
7242         * maint-test-options.c: New file.
7243
7244 2019-06-13  Pedro Alves  <palves@redhat.com>
7245
7246         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7247         parse a range if "-" is at the end of the string.
7248
7249 2019-06-13  Pedro Alves  <palves@redhat.com>
7250
7251         * cli/cli-setshow.c (parse_auto_binary_operation)
7252         (parse_cli_boolean_value): Don't allow "o".
7253
7254 2019-06-13  Pedro Alves  <palves@redhat.com>
7255
7256         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7257         * NEWS: Mention maint test-settings KIND.
7258         * maint-test-settings.c: New file.
7259
7260 2019-06-13  Pedro Alves  <palves@redhat.com>
7261
7262         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7263         completer.
7264         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7265         "set" completers.
7266
7267 2019-06-13  Pedro Alves  <palves@redhat.com>
7268
7269         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7270         after item.
7271
7272 2019-06-13  Pedro Alves  <palves@redhat.com>
7273
7274         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7275
7276 2019-06-13  Pedro Alves <palves@redhat.com>
7277
7278         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7279         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7280         call.
7281         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7282         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7283         calls.
7284         (check_for_argument): Skip spaces after argument.
7285
7286 2019-06-13  Pedro Alves  <palves@redhat.com>
7287
7288         * thread.c (thread_apply_command): Adjust TID parsing.
7289         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7290         detected before end of string.
7291         (tid_is_in_list): Error out if LIST is invalid.
7292
7293 2019-06-13  Pedro Alves  <palves@redhat.com>
7294
7295         * completer.c (complete_line_internal_1): Rewind completion word
7296         point.
7297         (completion_tracker::advance_custom_word_point_by): Change
7298         parameter type to int.
7299         * completer.h (completion_tracker::advance_custom_word_point_by):
7300         Likewise.
7301
7302 2019-06-13  Pedro Alves  <palves@redhat.com>
7303
7304         * completer.c (advance_to_completion_word): Handle delimiters.
7305
7306 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7307
7308         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7309
7310 2019-06-11  Tom Tromey  <tom@tromey.com>
7311
7312         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7313         (xmalloc_failed): Move to alloc.c.
7314         * alloc.c: New file.
7315         * Makefile.in (COMMON_SFILES): Add alloc.c.
7316
7317 2019-06-11  Tom Tromey  <tom@tromey.com>
7318
7319         * nat/linux-waitpid.c: Don't include server.h.
7320         (linux_debug): Remove.
7321         (my_waitpid): Update.
7322
7323 2019-06-11  Tom Tromey  <tromey@adacore.com>
7324
7325         * infcall.c (_initialize_infcall): Remove trailing newline from
7326         help.
7327         * user-regs.c (_initialize_user_regs): Remove trailing newline
7328         from help.
7329         * typeprint.c (_initialize_typeprint): Remove trailing newline
7330         from help.
7331         * reverse.c (_initialize_reverse): Remove trailing newlines from
7332         help.
7333         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7334         from help.
7335         * language.c (add_set_language_command): Remove trailing newline
7336         from help.
7337         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7338         help.
7339         * disasm.c (_initialize_disasm): Remove trailing newline from
7340         help.
7341         * top.c (init_main): Remove trailing newline from help.
7342         * interps.c (_initialize_interpreter): Remove trailing newline
7343         from help.
7344         * btrace.c (_initialize_btrace): Remove trailing newlines from
7345         help.
7346         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7347         from help.
7348         * python/python.c (_initialize_python): Remove trailing newline
7349         from help.
7350         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7351         help.
7352         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7353         from help.  Reformat some text.
7354         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7355         from help.
7356         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7357         newline from help.
7358
7359 2019-06-11  Tom Tromey  <tromey@adacore.com>
7360
7361         * darwin-nat.c (darwin_decode_exception_message)
7362         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7363
7364 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7365
7366         * valops.c (value_slice): Check for not allocated or not
7367         associated values.
7368
7369 2019-06-10  Tom de Vries  <tdevries@suse.de>
7370
7371         PR gdb/24618
7372         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7373         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7374         invalid.
7375
7376 2019-06-10  Tom de Vries  <tdevries@suse.de>
7377
7378         PR gdb/24611
7379         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7380         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7381
7382 2019-06-10  Tom de Vries  <tdevries@suse.de>
7383
7384         PR symtab/24545
7385         * symtab.c (struct demangled_name_entry): Add language field.
7386         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7387         static minimal symbol".  Set and use language field.
7388
7389 2019-06-10  Tom Tromey  <tromey@adacore.com>
7390
7391         * ada-lang.c (_initialize_ada_language): Update help text.
7392
7393 2019-06-10  Tom Tromey  <tromey@adacore.com>
7394
7395         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7396         with a newline.
7397         * guile/guile.c (handle_boot_error): Don't end warning with a
7398         newline.
7399         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7400         warning with a newline.
7401         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7402         newline.
7403         (s12z_frame_cache): Likewise.
7404         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7405         a newline.
7406         * solib-svr4.c (disable_probes_interface): Don't end warning with
7407         a newline.
7408         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7409         newline.
7410         * python/python.c (do_finish_initialization): Don't end warning
7411         with a newline.
7412
7413 2019-06-10  Tom Tromey  <tom@tromey.com>
7414
7415         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7416         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7417         gdbpy_enter.
7418
7419 2019-06-10  Tom Tromey  <tromey@adacore.com>
7420
7421         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7422         data.
7423         (elf_new_init): Don't call stabsread_new_init.
7424         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7425         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7426         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7427
7428 2019-06-10  Tom de Vries  <tdevries@suse.de>
7429
7430         PR symtab/16264
7431         PR symtab/24517
7432         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7433
7434 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7435
7436         * source.c (find_and_open_source): Also rewrite relative file
7437         names.
7438
7439 2019-04-26  Amos Bird  <amosbird@gmail.com>
7440
7441         * annotate.c (annotate_thread_exited): Add "thread-exited"
7442         annotation.
7443
7444 2019-06-06  Tom Tromey  <tromey@adacore.com>
7445
7446         * maint.h (class scoped_command_stats): Use
7447         DISABLE_COPY_AND_ASSIGN.
7448         <print_time>: New method.
7449         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7450         print_time.
7451         (scoped_command_stats::print_time): New method.
7452
7453 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7454
7455         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7456         instructions of lengths 6 or 8 bytes.
7457
7458 2019-06-04  Pedro Alves  <palves@redhat.com>
7459
7460         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7461
7462         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7463         * breakpoint.c (condition_completer): Likewise.
7464         * cli/cli-dump.c (scan_expression): Likewise.
7465         * common/filestuff.c (mkdir_recursive): Likewise.
7466         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7467         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7468         (gdb_abspath): Likewise.
7469         * compile/compile-cplus-types.c
7470         (compile_cplus_instance::decl_name): Likewise.
7471         * completer.c (complete_explicit_location):
7472         (signal_completer, reg_or_group_completer_1): Likewise.
7473         * cp-support.c (cp_remove_params_if_any): Likewise.
7474         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7475         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7476         * infcmd.c (strip_bg_char): Likewise.
7477         * linespec.c (copy_token_string): Likewise.
7478         * mi/mi-main.c (output_cores): Likewise.
7479         * psymtab.c (psymtab_search_name):
7480         * symfile.c (test_set_ext_lang_command): Likewise.
7481         * target.c (target_fileio_read_stralloc): Likewise.
7482         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7483         * value.c (complete_internalvar): Likewise.
7484
7485 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7486
7487         Add objfile property to gdb.Type.
7488         * NEWS: Mention Python API addition.
7489         * python/py-type.c (typy_get_objfile): New method.
7490
7491 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7492
7493         * NEWS: Mention the new set|show style [title|highlight].
7494         Mention changes to "show style", "help" and "apropos".
7495
7496 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7497
7498         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7499         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7500         instead of print_help_for_command.
7501         (print_doc_of_command): New function.
7502         (help_list): Add 'apropos -v word' suggestion.
7503         (print_help_for_command): Style the command name using title style.
7504         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7505         (_initialize_cli_cmds): Describe -v in apropos_command help.
7506
7507 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7508
7509         * cli/cli-style.h (cli_style_option): Add name in constructor,
7510         add m_name class member, add constructor with intensity,
7511         add name class function.
7512         (cli_style_option::add_setshow_commands): Remove name argument.
7513         (highlight_style, title_style): New styles.
7514         * cli/cli-style.c (do_show): New function that shows a style
7515         characteristic styling the style name with itself.
7516         (set_style_name): New function.
7517         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7518         Update all callers according to the changes in cli/cli-style.h.
7519         * utils.h (fputs_highlighted): New function.
7520         * utils.c (fputs_highlighted): Likewise.
7521
7522 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7523
7524         * NEWS: Mention new pipe command and new convenience variables.
7525
7526 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7527
7528         * cli/cli-cmds.c (pipe_command): New function.
7529         (_initialize_cli_cmds): Call add_com for pipe_command.
7530         Define | as an alias for pipe.
7531         (exit_status_set_internal_vars): New function.
7532         (shell_escape): Call exit_status_set_internal_vars.
7533         cli/cli-decode.c (find_command_name_length): Recognize | as
7534         a single character command.
7535
7536 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7537
7538         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7539         top.c (execute_command_to_ui_file): New function, mostly a copy
7540         of execute_command_to_string.
7541         (execute_command_to_string): Implement by calling
7542         execute_command_to_ui_file.
7543
7544 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7545
7546         * top.h (saved_command_line): Remove declaration.
7547         * top.c (previous_saved_command_line, previous_repeat_arguments):
7548         New variables.
7549         (saved_command_line): Make static, define together with other
7550         'repeat variables'.
7551         (dont_repeat): Clear repeat_arguments.
7552         (repeat_previous, get_saved_command_line, save_command_line):
7553         New functions.
7554         (gdb_init): Initialize saved_command_line
7555         and previous_saved_command_line.
7556         * main.c (captured_main_1): Remove saved_command_line initialization.
7557         * event-top.c (handle_line_of_input): Update to use
7558         the new 'repeat' related functions instead of direct access to
7559         saved_command_line.
7560         * command.h (repeat_previous, get_saved_command_line,
7561         save_command_line): New declarations.
7562         (dont_repeat): Add comment.
7563
7564 2019-05-30  Tom Tromey  <tromey@adacore.com>
7565
7566         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7567         Fix comment.
7568         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7569
7570 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7571
7572         PR cli/24587
7573         * completer.c (complete): Initialize variable word.
7574
7575 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7576
7577         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7578         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7579         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7580         'body' is NULL to the outter 'if', protecting the '!is_define'
7581         situation as well.
7582
7583 2019-05-29  Tom Tromey  <tromey@adacore.com>
7584
7585         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7586         (dwarf_unknown): New function.
7587         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7588         (dwarf_type_encoding_name): Use dwarf_unknown.
7589
7590 2019-05-29  Tom Tromey  <tromey@adacore.com>
7591
7592         PR c++/20020:
7593         * cp-valprint.c (cp_print_value_fields): Call
7594         cp_print_static_field inside "try".
7595
7596 2019-05-29  Tom Tromey  <tromey@adacore.com>
7597
7598         * inflow.c (struct terminal_info): Add default operator=.
7599         * configure: Rebuild.
7600         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7601         -Wdeprecated-copy-dtor, -Wredundant-move.
7602
7603 2019-05-29  Tom Tromey  <tromey@adacore.com>
7604
7605         * NEWS: Add entry.
7606         * infcmd.c (print_return_value_1): Handle finish_print
7607         option.
7608         (show_print_finish): New function.
7609         (_initialize_infcmd): Add "set/show print finish" commands.
7610         * valprint.c (user_print_options): Initialize new member.
7611         * valprint.h (struct value_print_options) <finish_print>: New
7612         member.
7613
7614 2019-05-28  Tom Tromey  <tromey@adacore.com>
7615
7616         * ada-lang.c (ada_remove_Xbn_suffix)
7617         (find_old_style_renaming_symbol)
7618         (parse_old_style_renaming): Remove.
7619         (ada_find_renaming_symbol): Don't call
7620         find_old_style_renaming_symbol.
7621         (ada_is_renaming_symbol): Rename from
7622         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7623         bool.  Now static.
7624         (ada_read_var_value): Update and simplify.
7625         * ada-exp.y (write_var_or_type): Remove old code.
7626
7627 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7628
7629         PR gdb/25010
7630         * event-top.c: Remove include comment.
7631         * inflow.c (class scoped_ignore_sigttou): Move from here...
7632         * inflow.h (class scoped_ignore_sigttou): ...to here.
7633         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7634         * top.c:  Remove include comment.
7635
7636 2019-05-27  Tom Tromey  <tom@tromey.com>
7637
7638         * NEWS: Fix typo.
7639
7640 2019-05-22  Tom Tromey  <tromey@adacore.com>
7641
7642         * target.c (target_follow_exec): Constify parameter.
7643         * target-delegates.c: Rebuild.
7644         * remote.c (remote_target::follow_exec): Constify parameter.
7645         * infrun.c (follow_exec): Constify parameter.
7646         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7647         (target_follow_exec): Likewise.
7648
7649 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7650
7651         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7652         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7653
7654 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7655
7656         * NEWS: Add debugredirect and testsuite sections.
7657
7658 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7659
7660         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7661         target descriptions using exclusively floating point register name
7662         aliases.
7663
7664 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7665
7666         PR gdb/18644:
7667         * f-lang.c (build_fortran_types): Handle the case where
7668         gdbarch_floatformat_for_type returns a nullptr.
7669
7670 2019-05-21  Tom de Vries  <tdevries@suse.de>
7671
7672         PR cli/24587
7673         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7674
7675 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7676
7677         PR gdb/18644:
7678         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7679         16-byte floats.
7680         * i386-tdep.c (i386_floatformat_for_type): Use
7681         floatformats_ia64_quad for the 16-byte floating point component
7682         within a fortran 32-byte complex number.
7683
7684 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7685
7686         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7687         delete default constructor.
7688         (find_partial_die): Update to return const struct.
7689         (partial_die_parent_scope): Move variable declaration into scope
7690         of its use and change its type to auto.
7691         (guess_partial_die_structure_name): Likewise.
7692         (partial_die_info::fixup): Likewise.
7693
7694 2019-05-17  Tom Tromey  <tromey@adacore.com>
7695
7696         * source.c (find_and_open_source): Remove cast.
7697
7698 2019-05-17  Tom Tromey  <tromey@adacore.com>
7699
7700         * annotate.c (annotate_source): Make "filename" const.
7701         * annotate.h (annotate_source): Use const.
7702
7703 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7704
7705         * disasm.c (set_disassembler_options): Send errors to stderr.
7706
7707 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7708
7709         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7710         (cli_interp_base::set_logging): Check debug_redirect.
7711         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7712         * cli/cli-logging.c (debug_redirect): Add static variable.
7713         (pop_output_files): Add default param.
7714         (handle_redirections): Print debug setting.
7715         (show_logging_command): Likewise.
7716         (_initialize_cli_logging): Add debugredirect command.
7717         * interps.c (current_interp_set_logging): Add debug_redirect
7718         parameter.
7719         * interps.h (set_logging): Add debug_redirect parameter.
7720         (current_interp_set_logging): Likewise.
7721         * mi/mi-common.h: Likewise.
7722         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7723
7724 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7725             Tom Tromey  <tromey@adacore.com>
7726
7727         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7728         directly.
7729         * cli/cli-interp.h (make_logging_output): Remove declaration.
7730         * cli/cli-logging.c (make_logging_output): Remove function.
7731         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7732         directly.
7733         * ui-file.c (tee_file::tee_file): Remove bools.
7734         (tee_file::~tee_file): Remove deletes.
7735         * ui-file.h (tee_file): Remove bools.
7736
7737 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7738
7739         * mi/mi-cmds.h (mi_cmd_complete): New function.
7740         * mi/mi-main.c (mi_cmd_complete): Likewise.
7741         * mi/mi-cmds.c: Define new MI command -complete.
7742         * NEWS: Mention new -complete command.
7743
7744 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7745
7746         * completer.h (complete): New function.
7747         * completer.c (complete): Likewise.
7748         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7749         function defined in completer.h.
7750
7751 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7752
7753         * MAINTAINERS (Write After Approval): Add myself.
7754
7755 2019-05-17  Tom de Vries  <tdevries@suse.de>
7756
7757         PR gdb/24094
7758         * dwarf2read.c (struct cu_partial_die_info): New struct.
7759         (find_partial_die): Return cu_partial_die_info.
7760         (partial_die_parent_scope, guess_partial_die_structure_name)
7761         (partial_die_info::fixup): Handle new return type of find_partial_die.
7762
7763 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7764
7765         PR breakpoints/24541
7766         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7767         "std::string", simplifying the algorithm.
7768
7769 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7770
7771         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7772         (stap_static_probe_ops::get_probes): Likewise.
7773
7774 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7775
7776         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7777         '-')" and "else if".
7778         (stap_parse_single_operand): Join checks for
7779         "gdbarch_stap_parse_special_token_p" and
7780         "gdbarch_stap_parse_special_token" in the same "if" statement.
7781         Invert check when verifying for operation on register
7782         displacement.
7783
7784 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7785
7786         * stap-probe.c (stap_get_opcode): Update comment.
7787         (stap_get_expected_argument_type): Likewise.
7788         (handle_stap_probe): Likewise.
7789
7790 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7791
7792         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7793         return type to 'bool'.  Adjust comment.  Use 'bool' when
7794         appropriate.
7795         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7796         * stap-probe.c (stap_parse_argument_1): Likewise.
7797         (stap_is_operator): Likewise.
7798         (stap_is_generic_prefix): Likewise.
7799         (stap_is_register_prefix): Likewise.
7800         (stap_is_register_indirection_prefix): Likewise.
7801         (stap_is_integer_prefix): Likewise.
7802         (stap_generic_check_suffix): Likewise.
7803         (stap_check_integer_suffix): Likewise.
7804         (stap_check_register_suffix): Likewise.
7805         (stap_check_register_indirection_suffix): Likewise.
7806         (stap_parse_register_operand): Likewise.
7807         (stap_parse_single_operand): Likewise.
7808         (stap_parse_argument_1): Likewise.
7809         (stap_probe::get_argument_count): Likewise.
7810         (stap_is_operator): Likewise.
7811
7812 2019-05-16  Tom Tromey  <tromey@adacore.com>
7813
7814         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7815         keyword to foreach.
7816
7817 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7818
7819         * linux-thread-db.c (try_thread_db_load_1): Change return type
7820         to bool.
7821         (try_thread_db_load): Likewise.
7822         (try_thread_db_load_from_pdir_1): Likewise.
7823         (try_thread_db_load_from_pdir): Likewise.
7824         (try_thread_db_load_from_sdir): Likewise.
7825         (try_thread_db_load_from_dir): Likewise.
7826         (thread_db_load_search): Likewise.
7827         (has_libpthread): Likewise.
7828         (thread_db_load): Likewise.
7829
7830 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7831
7832         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7833         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7834         NULL, and complain/return if that's the case.
7835
7836 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7837
7838         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7839         (advance, posn, abstract_read_memory): New functions.
7840         [struct mem_read_abstraction]: New struct.
7841         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7842
7843 2019-05-14  Tom Tromey  <tromey@adacore.com>
7844
7845         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7846         value is not lval_memory.
7847
7848 2019-05-14  Tom Tromey  <tromey@adacore.com>
7849
7850         * solib.c (info_sharedlibrary_command): Style the file name.
7851
7852 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7853
7854         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7855         (aarch64_vnv_type): Likewise.
7856         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7857         * common/tdesc.c: Likewise.
7858         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7859         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7860         * features/aarch64-fpu.xml: Add ieee half view.
7861         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7862         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7863         * gdbtypes.h (struct builtin_type): Likewise.
7864         (struct objfile_type): Likewise.
7865
7866 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7867
7868         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7869         typo.
7870         * location.h (string_to_event_location): Likewise.
7871
7872 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7873
7874         GDB 8.3 released.
7875
7876 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7877
7878         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7879         New variable declaration.
7880         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7881         New variable.
7882         (print_one_breakpoint): Use ui_out::test_flags and new global
7883         variable to compute use_fixed_output.
7884         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7885         Remove.
7886         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7887         (mi_multi_location_breakpoint_output_fixed): Remove.
7888         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7889         new variable.
7890         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7891         fix_multi_location_breakpoint_output flag if version >= 3.
7892         * ui-out.h (enum ui_out_flag)
7893         <fix_multi_location_breakpoint_output>: New enumerator.
7894
7895 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7896
7897         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7898
7899 2019-05-10  Tom Tromey  <tromey@adacore.com>
7900
7901         * ada-lang.c (catch_ada_completer): New function.
7902         (_initialize_ada_language): Use it.
7903
7904 2019-05-10  Tom Tromey  <tromey@adacore.com>
7905
7906         * thread.c (print_thread_info): Make "requested_threads" const.
7907         * gdbthread.h (print_thread_info): Make "requested_threads"
7908         const.
7909         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7910         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7911
7912 2019-05-08  Tom Tromey  <tom@tromey.com>
7913
7914         * gdbtypes.c (objfile_type_data): Change type.
7915         (objfile_type, _initialize_gdbtypes): Update.
7916
7917 2019-05-08  Tom Tromey  <tom@tromey.com>
7918
7919         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7920         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7921         (_initialize_dwarf2_frame): Update.
7922
7923 2019-05-08  Tom Tromey  <tom@tromey.com>
7924
7925         * objc-lang.c (objc_objfile_data): Change type.
7926         (find_methods): Update.
7927         (_initialize_objc_lang): Remove.
7928
7929 2019-05-08  Tom Tromey  <tom@tromey.com>
7930
7931         * stabsread.c (rs6000_builtin_type_data): Change type.
7932         (rs6000_builtin_type, _initialize_stabsread): Update.
7933
7934 2019-05-08  Tom Tromey  <tom@tromey.com>
7935
7936         * mips-tdep.c (mips_pdr_data): Remove.
7937         (_initialize_mips_tdep): Update.
7938
7939 2019-05-08  Tom Tromey  <tom@tromey.com>
7940
7941         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7942         (hppa_init_objfile_priv_data, read_unwind_info)
7943         (find_unwind_entry, _initialize_hppa_tdep): Update.
7944
7945 2019-05-08  Tom Tromey  <tom@tromey.com>
7946
7947         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7948         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7949         on obstack.
7950         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7951
7952 2019-05-08  Tom Tromey  <tom@tromey.com>
7953
7954         * mdebugread.c (basic_type_data): Change type.
7955         (basic_type, _initialize_mdebugread): Update.
7956
7957 2019-05-08  Tom Tromey  <tom@tromey.com>
7958
7959         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7960
7961 2019-05-08  Tom Tromey  <tom@tromey.com>
7962
7963         * nto-tdep.c (nto_inferior_data_reg): Change type.
7964         (nto_inferior_data): Update.
7965         (nto_inferior_data_cleanup, nto_new_inferior_data)
7966         (_initialize_nto_tdep): Remove.
7967         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7968
7969 2019-05-08  Tom Tromey  <tom@tromey.com>
7970
7971         * ada-lang.c (struct ada_inferior_data): Add initializers.
7972         (ada_inferior_data): Change type.
7973         (ada_inferior_data_cleanup): Remove.
7974         (get_ada_inferior_data, ada_inferior_exit)
7975         (struct ada_pspace_data): Add initializers, destructor.
7976         (ada_pspace_data_handle): Change type.
7977         (get_ada_pspace_data): Update.
7978         (ada_pspace_data_cleanup): Remove.
7979
7980 2019-05-08  Tom Tromey  <tom@tromey.com>
7981
7982         * coffread.c (struct coff_symfile_info): Add initializers.
7983         (coff_objfile_data_key): Move lower.  Change type.
7984         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7985         Update.
7986         (coff_free_info): Remove.
7987
7988 2019-05-08  Tom Tromey  <tom@tromey.com>
7989
7990         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7991         (fbsd_pspace_data_handle): Move lower.  Change type.
7992         (get_fbsd_pspace_data): Update.
7993         (fbsd_pspace_data_cleanup): Remove.
7994         (_initialize_fbsd_tdep): Update.
7995
7996 2019-05-08  Tom Tromey  <tom@tromey.com>
7997
7998         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7999         (get_ada_tasks_pspace_data): Update.
8000         (ada_tasks_pspace_data_cleanup): Remove.
8001         (_initialize_tasks): Update.
8002         (ada_tasks_inferior_data_handle): Change type.
8003         (get_ada_tasks_inferior_data): Update.
8004         (ada_tasks_inferior_data_cleanup): Remove.
8005         (struct ada_tasks_pspace_data): Add initializers.
8006
8007 2019-05-08  Tom Tromey  <tom@tromey.com>
8008
8009         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8010         * symfile-debug.c (debug_sym_get_probes): Change type.
8011         * stap-probe.c (handle_stap_probe):
8012         (stap_static_probe_ops::get_probes): Change type.
8013         * probe.h (class static_probe_ops) <get_probes>: Change type.
8014         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8015         (parse_probes_in_pspace): Update.
8016         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8017         Update.
8018         (any_static_probe_ops::get_probes): Change type.
8019         * elfread.c (elfread_data): New typedef.
8020         (probe_key): Change type.
8021         (elf_get_probes): Likewise.  Update.
8022         (probe_key_free): Remove.
8023         (_initialize_elfread): Update.
8024         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8025         Change type.
8026         (dtrace_process_dof_probe, dtrace_process_dof)
8027         (dtrace_static_probe_ops::get_probe): Change type.
8028
8029 2019-05-08  Tom Tromey  <tom@tromey.com>
8030
8031         * xcoffread.c (struct xcoff_symfile_info): Rename from
8032         coff_symfile_info.  Add initializers.
8033         (xcoff_objfile_data_key): Move lower.  Change type.
8034         (XCOFF_DATA): Rewrite.
8035         (xcoff_free_info): Remove.
8036         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8037         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8038         (xcoff_initial_scan): Update.
8039
8040 2019-05-08  Tom Tromey  <tom@tromey.com>
8041
8042         * solib-svr4.c (struct svr4_info): Add initializers and
8043         destructor.
8044         <probes_table>: Now an htab_up.
8045         (solib_svr4_pspace_data): Change type.
8046         (free_probes_table): Simplify.
8047         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8048         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8049         (probes_table_remove_objfile_probes, register_solib_event_probe)
8050         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8051         (_initialize_svr4_solib): Update.
8052
8053 2019-05-08  Tom Tromey  <tom@tromey.com>
8054
8055         * remote.c (remote_pspace_data): Change type.
8056         (remote_pspace_data_cleanup): Remove.
8057         (get_remote_exec_file, set_pspace_remote_exec_file)
8058         (_initialize_remote): Update.
8059
8060 2019-05-08  Tom Tromey  <tom@tromey.com>
8061
8062         * breakpoint.c (breakpoint_objfile_key): Change type.
8063         (get_breakpoint_objfile_data): Update.
8064         (free_breakpoint_objfile_data): Remove.
8065         (_initialize_breakpoint): Update.
8066
8067 2019-05-08  Tom Tromey  <tom@tromey.com>
8068
8069         * linux-tdep.c (struct linux_info): Add initializers.
8070         (linux_inferior_data): Move.  Change type.
8071         (invalidate_linux_cache_inf): Update.
8072         (linux_inferior_data_cleanup): Remove.
8073         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8074
8075 2019-05-08  Tom Tromey  <tom@tromey.com>
8076
8077         * auxv.c (auxv_inferior_data): Move.  Change type.
8078         (auxv_inferior_data_cleanup): Remove.
8079         (invalidate_auxv_cache_inf): Rewrite.
8080         (get_auxv_inferior_data, _initialize_auxv): Update.
8081
8082 2019-05-08  Tom Tromey  <tom@tromey.com>
8083
8084         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8085         (symfile_debug_objfile_data_key): Change type.
8086         (symfile_debug_installed, debug_qf_has_symbols)
8087         (debug_qf_find_last_source_symtab)
8088         (debug_qf_forget_cached_source_info)
8089         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8090         (debug_qf_print_stats, debug_qf_dump)
8091         (debug_qf_expand_symtabs_for_function)
8092         (debug_qf_expand_all_symtabs)
8093         (debug_qf_expand_symtabs_with_fullname)
8094         (debug_qf_map_matching_symbols)
8095         (debug_qf_expand_symtabs_matching)
8096         (debug_qf_find_pc_sect_compunit_symtab)
8097         (debug_qf_map_symbol_filenames)
8098         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8099         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8100         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8101         (debug_sym_read_linetable, debug_sym_relocate): Update.
8102         (symfile_debug_free_objfile): Remove.
8103         (install_symfile_debug_logging, _initialize_symfile_debug):
8104         Update.
8105
8106 2019-05-08  Tom Tromey  <tom@tromey.com>
8107
8108         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8109         allocate_on_obstack.
8110         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8111         (get_dwarf2_per_objfile): Update.
8112         (set_dwarf2_per_objfile): Remove.
8113         (dwarf2_has_info, dwarf2_get_section_info): Update.
8114         (dwarf2_free_objfile): Remove.
8115         (_initialize_dwarf2_read): Update.
8116
8117 2019-05-08  Tom Tromey  <tom@tromey.com>
8118
8119         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8120         initializers.
8121         <unsupported_script_warning_printed,
8122         script_not_found_warning_printed>: Now bool.
8123         (auto_load_pspace_data): Change type.
8124         (~auto_load_pspace_info): Rename from
8125         auto_load_pspace_data_cleanup.
8126         (get_auto_load_pspace_data, init_loaded_scripts_info)
8127         (clear_section_scripts, maybe_print_unsupported_script_warning)
8128         (maybe_print_script_not_found_warning, _initialize_auto_load):
8129         Update.
8130
8131 2019-05-08  Tom Tromey  <tom@tromey.com>
8132
8133         * objfiles.c (objfile_pspace_info): Add destructor and
8134         initializers.
8135         (objfiles_pspace_data): Change type.
8136         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8137         (get_objfile_pspace_data): Update.
8138         (objfiles_bfd_data): Change type.
8139         (get_objfile_bfd_data): Update.
8140         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8141
8142 2019-05-08  Tom Tromey  <tom@tromey.com>
8143
8144         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8145         Change type.
8146         (get_catch_syscall_inferior_data): Update.
8147         (catch_syscall_inferior_data_cleanup): Remove.
8148         (_initialize_break_catch_syscall): Update.
8149
8150 2019-05-08  Tom Tromey  <tom@tromey.com>
8151
8152         * inflow.c (struct terminal_info): Add destructor and
8153         initializers.
8154         (inflow_inferior_data): Change type.
8155         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8156         (get_inflow_inferior_data, inflow_inferior_exit)
8157         (swap_terminal_info, _initialize_inflow): Update.
8158
8159 2019-05-08  Tom Tromey  <tom@tromey.com>
8160
8161         * target-dcache.c (target_dcache_cleanup): Remove.
8162         (target_dcache_aspace_key): Change type.
8163         (target_dcache_init_p, target_dcache_invalidate)
8164         (target_dcache_get, target_dcache_get_or_init)
8165         (_initialize_target_dcache): Update.
8166         * dcache.h (struct dcache_deleter): New.
8167
8168 2019-05-08  Tom Tromey  <tom@tromey.com>
8169
8170         * symtab.c (struct symbol_cache): Add destructor and
8171         initializers.
8172         (symbol_cache_key): Move.  Change type.
8173         (make_symbol_cache, free_symbol_cache): Remove.
8174         (get_symbol_cache): Update.
8175         (symbol_cache_cleanup): Remove.
8176         (ALL_PSPACES, symbol_cache_flush)
8177         (maintenance_print_symbol_cache)
8178         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8179         Update.
8180
8181 2019-05-08  Tom Tromey  <tom@tromey.com>
8182
8183         * symtab.c (struct main_info): Add destructor and initializers.
8184         (main_progspace_key): Move.  Change type.
8185         (get_main_info): Update.
8186         (main_info_cleanup): Remove.
8187         (_initialize_symtab): Update.
8188
8189 2019-05-08  Tom Tromey  <tom@tromey.com>
8190
8191         * registry.h (DECLARE_REGISTRY): Define the _key class.
8192
8193 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * NEWS: Merge two 'New commands' sections.
8196
8197 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8198
8199         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8200         parameter and use Ada language definition instead.
8201         (ada_val_print_ptr): Remove unused language parameter.
8202         (ada_val_print_num): Remove language parameter and use Ada language
8203         definition instead.
8204         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8205         parameter.
8206         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8207         parameter and use Ada language definition instead.
8208         (ada_val_print_1): Update all ada_val_print_xxx calls.
8209         Remove language parameter.
8210         (ada_val_print): Update ada_val_print_1 call.
8211
8212 2019-05-08  Tom Tromey  <tromey@adacore.com>
8213
8214         * remote.c (remote_hw_watchpoint_limit)
8215         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8216         Now static.
8217
8218 2019-05-08  Tom Tromey  <tromey@adacore.com>
8219
8220         * maint.c (_initialize_maint_cmds): Move initialization code to
8221         remote.c.
8222         (watchdog, show_watchdog): Move to remote.c.
8223         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8224         "watchdog" static.
8225         (_initialize_remote): Move initialization code from maint.c.
8226         * defs.h (watchdog): Don't declare.
8227
8228 2019-05-08  Tom Tromey  <tromey@adacore.com>
8229
8230         * tui/tui-interp.c: Include main.h.
8231         * interps.c: Include main.h.
8232         * main.h (interpreter_p): Declare.
8233         * defs.h (interpreter_p): Don't declare.
8234
8235 2019-05-08  Tom Tromey  <tromey@adacore.com>
8236
8237         * dwarf2loc.c: Include dwarf2read.h.
8238         * defs.h (read_unsigned_leb128): Don't declare.
8239         * dwarf2read.h (read_unsigned_leb128): Declare.
8240
8241 2019-05-08  Tom Tromey  <tromey@adacore.com>
8242
8243         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8244         method.
8245
8246 2019-05-08  Tom Tromey  <tromey@adacore.com>
8247
8248         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8249         when no wrap column is set.
8250
8251 2019-05-08  Tom Tromey  <tromey@adacore.com>
8252
8253         * c-lang.c (c_get_string): Handle non-C-style arrays.
8254
8255 2019-05-08  Tom Tromey  <tromey@adacore.com>
8256
8257         * typeprint.c (print_offset_data::update): Print the bit offset,
8258         not the number of bits remaining.
8259
8260 2019-05-08  Tom Tromey  <tromey@adacore.com>
8261
8262         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8263         padding at end of comment.
8264
8265 2019-05-08  Tom Tromey  <tromey@adacore.com>
8266
8267         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8268         Compare main types.
8269
8270 2019-05-06  Tom Tromey  <tom@tromey.com>
8271
8272         * common/scoped_mmap.c: Include common-defs.h.
8273         * common/scoped_mmap.h: Don't include config.h.
8274
8275 2019-05-04  Tom Tromey  <tom@tromey.com>
8276
8277         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8278         (struct aarch64_call_info): Add initializers.
8279         <si>: Now a std::vector.
8280         (pass_on_stack, aarch64_push_dummy_call): Update.
8281
8282 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8283             Tom Tromey  <tom@tromey.com>
8284
8285         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8286         (ppc_threads): Now a std::vector.  Now static.
8287         (hwdebug_find_thread_points_by_tid)
8288         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8289         Update.
8290
8291 2019-05-04  Tom Tromey  <tom@tromey.com>
8292
8293         * arc-tdep.c (arc_tdesc_init): Return bool.
8294
8295 2019-05-04  Tom Tromey  <tom@tromey.com>
8296
8297         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8298         Use gdb_assert_not_reached.
8299
8300 2019-05-04  Tom Tromey  <tom@tromey.com>
8301
8302         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8303         "false".
8304
8305 2019-05-04  Tom Tromey  <tom@tromey.com>
8306
8307         * arc-tdep.c (arc_tdesc_init): Use bool.
8308
8309 2019-05-04  Tom Tromey  <tom@tromey.com>
8310
8311         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8312
8313 2019-05-04  Tom Tromey  <tom@tromey.com>
8314
8315         * cli/cli-cmds.c (valid_command_p): Return bool.
8316
8317 2019-05-04  Tom Tromey  <tom@tromey.com>
8318
8319         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8320         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8321
8322 2019-05-04  Raul Tambre  <raul@tambre.ee>
8323
8324         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8325         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8326         operator for comparison.
8327
8328 2019-05-04  Tom Tromey  <tom@tromey.com>
8329
8330         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8331         (lookup_partial_symbol, print_partial_symbols)
8332         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8333         (psymbol_compare): Update.
8334         (add_psymbol_to_bcache): Clear the entire psymbol.
8335         (maintenance_check_psymtabs): Update.
8336         * psympriv.h (struct partial_symbol): Don't derive from
8337         general_symbol_info.
8338         <obj_section, unrelocated_address, address,
8339         set_unrelocated_address>: Update.
8340         <ginfo>: New member.
8341         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8342         (debug_names::write_psymbols): Update.
8343
8344 2019-05-04  Tom de Vries  <tdevries@suse.de>
8345
8346         * contrib/cc-with-tweaks.sh: Support -n arg.
8347
8348 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8349
8350         * corelow.c (core_target::detach): Ensure frame cache and
8351         register caches are cleared.
8352         inferior.c (exit_inferior_1): Likewise.
8353
8354 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8355             Tom Tromey  <tom@tromey.com>
8356
8357         * dictionary.c (collate_pending_symbols_by_language): Remove
8358         "struct" from foreach.
8359         * symtab.c (lookup_global_symbol_from_objfile)
8360         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8361         foreach.
8362         * ser-tcp.c (net_open): Remove "struct" from foreach.
8363         * objfiles.c (objfile_relocate, objfile_rebase)
8364         (objfile_has_symbols): Remove "struct" from foreach.
8365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8366         from foreach.
8367         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8368         foreach.
8369         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8370         "struct" from foreach.
8371         * ada-lang.c (create_excep_cond_exprs)
8372         (ada_exception_catchpoint_cond_string): Remove "struct" from
8373         foreach.
8374
8375 2019-05-03  Tom Tromey  <tromey@adacore.com>
8376
8377         * ada-exp.y (convert_char_literal): Check suffix of each
8378         enumerator.
8379
8380 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8381
8382         PR ada/21406:
8383         * ada-exp.y (yywrap): Don't define.
8384         * ada-lex.l (%option): Add noyywrap
8385         (yywrap): Remove.
8386
8387 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8388
8389         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8390         _WIN32_WINNT to the XP level, unless already defined to a higher
8391         level.
8392
8393         * unittests/parse-connection-spec-selftests.c:
8394         * ser-tcp.c:
8395         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8396         override.
8397
8398         * symfile.c (find_separate_debug_file): Remove colon from the
8399         drive spec of DOS/Windows file names of the target, so that the
8400         file name produced from DEBUGDIR and the target's directory will
8401         be valid on DOS/Windows systems.
8402
8403 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8404
8405         * rust-lang.c (val_print_struct): Handle printing structures
8406         containing strings.
8407
8408 2019-05-02  Tom Tromey  <tromey@adacore.com>
8409
8410         * valarith.c (_initialize_valarith): Remove.
8411
8412 2019-05-01  Tom Tromey  <tromey@adacore.com>
8413
8414         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8415         bitfields.
8416
8417 2019-05-01  Tom Tromey  <tromey@adacore.com>
8418
8419         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8420         for big-endian copies.
8421
8422 2019-04-30  Ali Tamur  <tamur@google.com>
8423         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8424         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8425         (read_3_bytes): New function.
8426
8427 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8428
8429         * windows-nat.c (main_thread_id): Delete.
8430         (handle_output_debug_string): Replace main_thread_id by
8431         current_event.dwThreadId.
8432         (fake_create_process): Likewise.
8433         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8434         Do not set main_thread_id.
8435         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8436         current_event.dwThreadId.
8437         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8438
8439 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8440
8441         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8442         Use current_event.dwThreadId instead of main_thread_id.
8443
8444 2019-04-30  Tom Tromey  <tromey@adacore.com>
8445
8446         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8447         (create_excep_cond_exprs): Iterate over program spaces.
8448         (ada_exception_catchpoint_cond_string): Examine all minimal
8449         symbols for exception types.
8450
8451 2019-04-30  Tom Tromey  <tromey@adacore.com>
8452
8453         PR c++/24470:
8454         * dwarf2read.c (process_structure_scope): Handle case where type
8455         has template parameters but no symbol was created.
8456
8457 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8458             Chris January  <chris.january@arm.com>
8459
8460         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8461         qualifier.
8462         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8463
8464 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8465
8466         * f-typeprint.c (f_print_type): Update rules for printing
8467         whitespace.
8468         (f_type_print_varspec_suffix): Likewise.
8469
8470 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8471             Chris January  <chris.january@arm.com>
8472
8473         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8474         function arguments.
8475
8476 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8477
8478         * f-lang.c (build_fortran_types): Change name of void type to
8479         lower case.
8480         * f-typeprint.c (f_type_print_base): Print the name of the void
8481         type, rather than a fixed string.
8482         * f-valprint.c (f_decorations): Use lower case void string.
8483
8484 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8485             Chris January  <chris.january@arm.com>
8486
8487         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8488         types for Fortran.
8489
8490 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8491             Chris January  <chris.january@arm.com>
8492             David Lecomber  <david.lecomber@arm.com>
8493
8494         * f-exp.y (BINOP_INTRINSIC): New token.
8495         (exp): New parser rule handling BINOP_INTRINSIC.
8496         (f77_keywords): Add new builtin procedures.
8497         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8498         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8499         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8500         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8501         (print_unop_subexp_f): New function.
8502         (print_binop_subexp_f): New function.
8503         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8504         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8505         (dump_subexp_body_f): Likewise.
8506         (operator_check_f): Likewise.
8507         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8508         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8509
8510 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8511
8512         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8513         UNOP_KIND.
8514         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8515         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8516         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8517         (operator_length_f): New fuction.
8518         (print_subexp_f): New function.
8519         (op_name_f): New function.
8520         (dump_subexp_body_f): New function.
8521         (operator_check_f): New function.
8522         (exp_descriptor_f): Replace standard expression handling functions
8523         with new functions.
8524         * gdb/fortran-operator.def: New file.
8525         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8526         * gdb/std-operator.def: Remove UNOP_KIND.
8527
8528 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8529
8530         * std-operator.def: Remove unbalanced, stray double quote
8531         character.
8532
8533 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8534             Chris January  <chris.january@arm.com>
8535             Daniel Everett  <daniel.everett@arm.com>
8536             Nick Forrington  <nick.forrington@arm.com>
8537             Richard Bunt  <richard.bunt@arm.com>
8538
8539         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8540         of depth when printing anonymous structs or unions.
8541         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8542         Don't print either the top-level value, or the children if the
8543         max-depth is exceeded.
8544         (ppscm_print_children): When printing the key of a map, allow one
8545         extra level of depth.
8546         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8547         print either the top-level value, or the children if the max-depth
8548         is exceeded.
8549         (print_children): When printing the key of a map, allow one extra
8550         level of depth.
8551         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8552         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8553         (user_print_options): Initialise max_depth field.
8554         (val_print_scalar_or_string_type_p): New function.
8555         (val_print): Check to see if the max depth has been reached.
8556         (val_print_check_max_depth): Define new function.
8557         (show_print_max_depth): New function.
8558         (_initialize_valprint): Add 'print max-depth' option.
8559         * valprint.h (struct value_print_options) <max_depth>: New field.
8560         (val_print_check_max_depth): Declare new function.
8561         * NEWS: Document new feature.
8562
8563 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8564
8565         * ada-lang.c (ada_language_defn): Initialise new field.
8566         * c-lang.c (c_is_string_type_p): New function.
8567         (c_language_defn): Initialise new field.
8568         (cplus_language_defn): Initialise new field.
8569         (asm_language_defn): Initialise new field.
8570         (minimal_language_defn): Initialise new field.
8571         * c-lang.h (c_is_string_type_p): Declare new function.
8572         * d-lang.c (d_language_defn): Initialise new field.
8573         * f-lang.c (f_is_string_type_p): New function.
8574         (f_language_defn): Initialise new field.
8575         * go-lang.c (go_is_string_type_p): New function.
8576         (go_language_defn): Initialise new field.
8577         * language.c (default_is_string_type_p): New function.
8578         (unknown_language_defn): Initialise new field.
8579         (auto_language_defn): Initialise new field.
8580         * language.h (struct language_defn) <la_is_string_type_p>: New
8581         member variable.
8582         (default_is_string_type_p): Declare new function.
8583         * m2-lang.c (m2_language_defn): Initialise new field.
8584         * objc-lang.c (objc_language_defn): Initialise new field.
8585         * opencl-lang.c (opencl_language_defn): Initialise new field.
8586         * p-lang.c (pascal_is_string_type_p): New function.
8587         (pascal_language_defn): Initialise new field.
8588         * rust-lang.c (rust_is_string_type_p): New function.
8589         (rust_language_defn): Initialise new field.
8590
8591 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8592
8593         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8594         New field.
8595         * ada-lang.c (ada_language_defn): Initialise new field.
8596         * c-lang.c (c_language_defn): Likewise.
8597         (cplus_language_defn): Likewise.
8598         (asm_language_defn): Likewise.
8599         (minimal_language_defn): Likewise.
8600         * d-lang.c (d_language_defn): Likewise.
8601         * f-lang.c (f_language_defn): Likewise.
8602         * go-lang.c (go_language_defn): Likewise.
8603         * language.c (unknown_language_defn): Likewise.
8604         (auto_language_defn): Likewise.
8605         * m2-lang.c (m2_language_defn): Likewise.
8606         * objc-lang.c (objc_language_defn): Likewise.
8607         * opencl-lang.c (opencl_language_defn): Likewise.
8608         * p-lang.c (pascal_language_defn): Likewise.
8609         * rust-lang.c (rust_language_defn): Likewise.
8610
8611 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8612
8613         * ada-lang.c (ada_is_character_type): Change return type to bool.
8614         (ada_is_string_type): Likewise.
8615         * ada-lang.h (ada_is_character_type): Update declaration
8616         (ada_is_string_type): Likewise.
8617
8618 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8619
8620         Support style in 'frame|thread apply'
8621
8622         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8623         * record.c (record_start, record_stop): Update callers of
8624         execute_command_to_string with false.
8625         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8626         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8627         methods.
8628         (class string_file): New constructor with term_out parameter.
8629         Override methods term_out and can_emit_style_escape.  New member
8630         term_out.
8631         (class stdio_file): Override can_emit_style_escape.
8632         (class tee_file): Override term_out and can_emit_style_escape.
8633         * utils.h (can_emit_style_escape): Remove.
8634         * utils.c (can_emit_style_escape): Likewise.
8635         Update all callers of can_emit_style_escape (SOMESTREAM) to
8636         SOMESTREAM->can_emit_style_escape.
8637         * source-cache.c (source_cache::get_source_lines): Likewise.
8638         * stack.c (frame_apply_command_count): Call execute_command_to_string
8639         passing the term_out characteristic of the current gdb_stdout.
8640         * thread.c (thr_try_catch_cmd): Likewise.
8641         * top.c (execute_command_to_string): pass term_out parameter
8642         to construct the string_file for the command output.
8643         * ui-file.c (term_cli_styling): New function (most code moved
8644         from utils.c can_emit_style_escape).
8645         (string_file::string_file, string_file::can_emit_style_escape,
8646         stdio_file::can_emit_style_escape, tee_file::term_out,
8647         tee_file::can_emit_style_escape): New functions.
8648
8649 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8650
8651         * NEWS: Mention the new set|show may-call-functions.
8652         * infcall.c (may_call_functions_p): New variable.
8653         (show_may_call_functions_p): New function.
8654         (call_function_by_hand_dummy): Throws an error if not
8655         may-call-functions.
8656         (_initialize_infcall): Call add_setshow_boolean_cmd for
8657         may-call-functions.
8658
8659 2019-04-25  Keith Seitz  <keiths@redhat.com>
8660
8661         PR c++/24367
8662         * cp-support.c (inspect_type): Don't attempt substitutions
8663         of symbol with the same name.
8664
8665 2019-04-25  Tom Tromey  <tromey@adacore.com>
8666
8667         PR gdb/24475:
8668         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8669         static.
8670
8671 2019-04-25  Tom Tromey  <tromey@adacore.com>
8672
8673         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8674         rvalue reference.
8675         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8676         (gdb_xml_parser::parse): Use std::move.
8677         * python/python-internal.h (gdbpy_convert_exception): Take a const
8678         reference.
8679         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8680         std::move.
8681         * python/py-utils.c (gdbpy_convert_exception): Take a const
8682         reference.
8683         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8684         Use std::move.
8685         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8686         Use std::move.
8687         * mi/mi-main.c (mi_print_exception): Take a const reference.
8688         * main.c (handle_command_errors): Take a const reference.
8689         * linespec.c (parse_linespec): Use std::move.
8690         * infcall.c (run_inferior_call): Use std::move.
8691         (call_function_by_hand_dummy): Use std::move.
8692         * exec.c (try_open_exec_file): Use std::move.
8693         * exceptions.h (exception_print, exception_fprintf)
8694         (exception_print_same): Update.
8695         * exceptions.c (print_exception, exception_print)
8696         (exception_fprintf, exception_print_same): Change parameters to
8697         const reference.
8698         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8699         * common/new-op.c: Use std::move.
8700         * common/common-exceptions.h (struct gdb_exception): Add move
8701         constructor.
8702         (struct gdb_exception_error, struct gdb_exception_quit, struct
8703         gdb_quit_bad_alloc): Change constructor to move constructor.
8704         (throw_exception): Change parameter to rvalue reference.
8705         * common/common-exceptions.c (throw_exception): Take rvalue
8706         reference.
8707         * cli/cli-interp.c (safe_execute_command): Use std::move.
8708         * breakpoint.c (insert_bp_location, location_to_sals): Use
8709         std::move.
8710
8711 2019-04-25  Tom Tromey  <tromey@adacore.com>
8712
8713         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8714         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8715         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8716         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8717         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8718         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8719         guile/scm-value.c: Use unpack.
8720         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8721         gdbscm_gdb_exception.
8722         (gdbscm_throw_gdb_exception): Likewise.
8723         (struct gdbscm_gdb_exception): New.
8724         (unpack): New function.
8725         (gdbscm_wrap): Use unpack.
8726
8727 2019-04-25  Tom Tromey  <tromey@adacore.com>
8728
8729         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8730         (gdb_rl_callback_handler): Use std::move.
8731         * common/common-exceptions.h (struct gdb_exception): Add move
8732         assignment operator.
8733         (throw_exception_sjlj): Change "exception" to const reference.
8734         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8735         (throw_exception_sjlj): Change "exception" to const reference.
8736
8737 2019-04-25  Tom Tromey  <tromey@adacore.com>
8738
8739         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8740         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8741         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8742         Update.
8743         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8744         Update.
8745         * mi/mi-interp.c (mi_interp::exec): Update.
8746         * linespec.c (parse_linespec): Update.
8747         * infcall.c (run_inferior_call): Update.
8748         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8749         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8750         (gdbscm_lookup_global_symbol): Update.
8751         * guile/scm-param.c (gdbscm_parameter_value): Update.
8752         * guile/scm-frame.c (gdbscm_frame_read_register)
8753         (gdbscm_frame_read_var): Update.
8754         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8755         * exec.c (try_open_exec_file): Update.
8756         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8757         (gdb_rl_callback_handler): Update.
8758         * common/common-exceptions.h (exception_none): Don't declare.
8759         * common/common-exceptions.c (exception_none): Don't define.
8760         (struct catcher) <exception>: Update.
8761         * cli/cli-interp.c (safe_execute_command): Update.
8762         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8763
8764 2019-04-25  Ali Tamur  <tamur@google.com>
8765
8766         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8767         (read_attribute_value): Likewise.
8768         (dwarf2_read_addr_index): Update comment.
8769         (read_str_index): Add DW_FORM_strx.
8770         (dwarf2_string_attr): Likewise.
8771         (dwarf2_const_value_attr): Likewise.
8772         (dump_die_shallow): Likewise.
8773         (dwarf2_fetch_constant_bytes): Likewise.
8774         (skip_form_bytes): Likewise.
8775         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8776
8777 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8778
8779         PR corefiles/11608
8780         PR corefiles/18187
8781         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8782         OFFSET.  Verify if current mapping contains an ELF header.
8783         (linux_find_memory_regions_full): Adjust call to
8784         dump_mapping_p.
8785
8786 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8787             Kang Li <kanglictf@gmail.com>
8788
8789         PR gdb/21600
8790
8791         * dwarf2-frame.c (read_initial_length): Be consistent about using
8792         unsigned representation of length.
8793         (decode_frame_entry_1): Likewise.  Check for wraparound of
8794         end pointer as well as buffer overflow.
8795
8796 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8797
8798         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8799         "vq".
8800
8801 2019-04-24  Tom Tromey  <tromey@adacore.com>
8802
8803         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8804
8805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8806
8807         * s12z-tdep.c (s12z_unwind_pc): Delete.
8808         (s12z_unwind_sp): Delete.
8809         (s12z_gdbarch_init): Don't register deleted functions with
8810         gdbarch.
8811
8812 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8813
8814         * rl78-tdep.c (rl78_unwind_sp): Delete.
8815         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8816
8817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8818
8819         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8820         (xstormy16_unwind_pc): Delete.
8821         (xstormy16_dummy_id): Delete.
8822         (xstormy16_gdbarch_init): Don't register deleted functions with
8823         gdbarch.
8824
8825 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8826
8827         * vax-tdep.c (vax_unwind_pc): Delete.
8828         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8829
8830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8831
8832         * v850-tdep.c (v850_unwind_sp): Delete.
8833         (v850_unwind_pc): Delete.
8834         (v850_dummy_id): Delete.
8835         (v850_gdbarch_init): Don't register deleted functions with
8836         gdbarch.
8837
8838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8839
8840         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8841         (tilegx_unwind_pc): Delete.
8842         (tilegx_unwind_dummy_id): Delete.
8843         (tilegx_gdbarch_init): Don't register deleted functions with
8844         gdbarch.
8845
8846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8847
8848         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8849         (tic6x_dummy_id): Delete.
8850         (tic6x_gdbarch_init): Don't register deleted functions with
8851         gdbarch.
8852
8853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8854
8855         * sparc-tdep.c (sparc_unwind_pc): Delete.
8856         (sparc32_gdbarch_init): Don't register deleted function with
8857         gdbarch.
8858
8859 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * sh-tdep.c (sh_unwind_sp): Delete.
8862         (sh_unwind_pc): Delete.
8863         (sh_dummy_id): Delete.
8864         (sh_gdbarch_init): Don't register deleted functions with
8865         gdbarch.
8866
8867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8868
8869         * score-tdep.c (score_unwind_sp): Delete.
8870         (score_unwind_pc): Delete.
8871         (score_dummy_id): Delete.
8872         (score_gdbarch_init): Don't register deleted functions with
8873         gdbarch.
8874
8875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8876
8877         * rx-tdep.c (rx_unwind_pc): Delete.
8878         (rx_unwind_sp): Delete.
8879         (rx_dummy_id): Delete.
8880         (rx_gdbarch_init): Don't register deleted functions with
8881         gdbarch.  Update comment.
8882
8883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8884
8885         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8886         (rs6000_dummy_id): Delete.
8887         (rs6000_gdbarch_init): Don't register deleted functions with
8888         gdbarch.
8889
8890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * or1k-tdep.c (or1k_dummy_id): Delete.
8893         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8894
8895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * nios2-tdep.c (nios2_dummy_id): Delete.
8898         (nios2_unwind_sp): Delete.
8899         (nios2_gdbarch_init): Don't register deleted functions with
8900         gdbarch.
8901
8902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * nds32-tdep.c (nds32_dummy_id): Delete.
8905         (nds32_unwind_pc): Delete.
8906         (nds32_unwind_sp): Delete.
8907         (nds32_gdbarch_init): Don't register deleted functions with
8908         gdbarch.
8909
8910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8911
8912         * msp430-tdep.c (msp430_unwind_pc): Delete.
8913         (msp430_unwind_sp): Delete.
8914         (msp430_dummy_id): Delete.
8915         (msp430_gdbarch_init): Don't register deleted functions with
8916         gdbarch.
8917
8918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8919
8920         * moxie-tdep.c (moxie_unwind_sp): Delete.
8921         (moxie_unwind_pc): Delete.
8922         (moxie_dummy_id): Delete.
8923         (moxie_gdbarch_init): Don't register deleted functions with
8924         gdbarch.
8925
8926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8927
8928         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8929         (mn10300_unwind_pc): Delete.
8930         (mn10300_unwind_sp): Delete.
8931         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8932         mn10300_unwind_sp.
8933         (mn10300_frame_unwind_init): Don't register deleted functions with
8934         gdbarch.
8935
8936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8937
8938         * mep-tdep.c (mep_unwind_pc): Delete.
8939         (mep_unwind_sp): Delete.
8940         (mep_dummy_id): Delete.
8941         (mep_gdbarch_init): Don't register deleted functions with
8942         gdbarch.
8943
8944 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8945
8946         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8947         (m68hc11_unwind_sp): Delete.
8948         (m68hc11_gdbarch_init): Don't register deleted functions with
8949         gdbarch.
8950
8951 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8952
8953         * m32r-tdep.c (m32r_unwind_sp): Delete.
8954         (m32r_unwind_pc): Delete.
8955         (m32r_dummy_id): Delete.
8956         (m32r_gdbarch_init): Don't register deleted functions with
8957         gdbarch.
8958
8959 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8960
8961         * m32c-tdep.c (m32c_unwind_pc): Delete.
8962         (m32c_unwind_sp): Delete.
8963         (m32c_dummy_id): Delete.
8964         (m32c_gdbarch_init): Don't register deleted functions with
8965         gdbarch.
8966
8967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8968
8969         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8970         (lm32_unwind_pc): Delete.
8971         (lm32_dummy_id): Delete.
8972         (lm32_gdbarch_init): Don't register deleted functions with
8973         gdbarch.
8974
8975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8976
8977         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8978         (iq2000_unwind_pc): Delete.
8979         (iq2000_dummy_id): Delete.
8980         (iq2000_gdbarch_init): Don't register deleted functions with
8981         gdbarch.
8982
8983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8984
8985         * nds32-tdep.c (nds32_type_align): Delete.
8986         (nds32_push_dummy_call): Use type_align instead.
8987
8988 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8989
8990         * arm-tdep.c (arm_type_align): Only handle vector override case.
8991         (arm_push_dummy_call): Use type_align.
8992         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8993
8994 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8995
8996         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8997         case.
8998         (pass_on_stack): Use type_align.
8999         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9000         function.
9001
9002 2019-04-23  Tom Tromey  <tromey@adacore.com>
9003
9004         * dwarf2read.c (line_header::file_name_at): Remove unused
9005         overload.
9006
9007 2019-04-23  Tom de Vries  <tdevries@suse.de>
9008
9009         PR gdb/24438
9010         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9011         invocation.
9012
9013
9014 2019-03-27  Ali Tamur  <tamur@google.com>
9015
9016         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9017         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9018         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9019         (dwarf_expr_context::get_addr_index): Likewise
9020         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9021         (symbol_needs_eval_context::get_addr_index): Likewise
9022         (disassemble_dwarf_expression): Add DW_OP_addrx
9023         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9024         (read_cutu_die_from_dwo): Update comment
9025         (skip_one_die): Add DW_FORM_addrx
9026         (read_attribute_value): Likewise
9027         (var_decode_location): Add DW_OP_addrx
9028         (dwarf2_const_value_attr): Add DW_FORM_addrx
9029         (dump_die_shallow): Likewise
9030         (dwarf2_fetch_constant_bytes): Likewise
9031         (decode_locdesc): Add DW_OP_addrx
9032         (skip_form_bytes): Add DW_FORM_addrx
9033
9034 2019-04-22  Ali Tamur  <tamur@google.com>
9035
9036         * MAINTAINERS (Write After Approval): Add self.
9037
9038 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9039
9040         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9041         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9042         (open_symbol_file_object): Likewise.
9043         (svr4_default_sos): Add info parameter.
9044         (svr4_read_so_list): Likewise.
9045         (svr4_current_sos_direct): Adjust functions calls to pass down
9046         info.
9047         (svr4_current_sos_1): Add info parameter.
9048         (svr4_current_sos): Call get_svr4_info, pass info down to
9049         svr4_current_sos_1.
9050         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9051         get_svr4_info.
9052         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9053         get_svr4_info.
9054         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9055         to get_svr4_info.
9056         (probes_table_remove_objfile_probes): Likewise.
9057         (register_solib_event_probe): Add info parameter.
9058         (solist_update_incremental): Pass info parameter down to
9059         svr4_read_so_list.
9060         (disable_probes_interface): Add info parameter.
9061         (svr4_handle_solib_event): Pass current_program_space to
9062         get_svr4_info.  Adjust disable_probes_interface cleanup.
9063         (svr4_create_probe_breakpoints): Add info parameter, pass it
9064         down to register_solib_event_probe.
9065         (svr4_create_solib_event_breakpoints): Add info parameter,
9066         pass it down to svr4_create_probe_breakpoints.
9067         (enable_break): Pass info down to
9068         svr4_create_solib_event_breakpoints.
9069         (svr4_solib_create_inferior_hook): Pass current_program_space to
9070         get_svr4_info.
9071         (svr4_clear_solib): Likewise.
9072
9073 2019-04-22  Pedro Alves  <palves@redhat.com>
9074
9075         * solib-svr4.c (svr4_free_objfile_observer): New.
9076         (probe_and_action::objfile): New field.
9077         (probes_table_htab_remove_objfile_probes)
9078         (probes_table_remove_objfile_probes): New functions.
9079         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9080         in the new probe_and_action.  Don't store the probe in 'lookup'.
9081         (svr4_create_probe_breakpoints): Pass objfile to
9082         register_solib_event_probe.
9083         (_initialize_svr4_solib): Register a free_objfile observer.
9084
9085 2019-04-19  Tom Tromey  <tom@tromey.com>
9086
9087         * common/queue.h: Remove.
9088
9089 2019-04-19  Tom Tromey  <tom@tromey.com>
9090
9091         * event-loop.c: Don't include "common/queue.h".
9092
9093 2019-04-19  Tom Tromey  <tom@tromey.com>
9094
9095         * remote.c (remote_target): Use delete.
9096         * remote-notif.h: Include <list>, not "common/queue.h".
9097         (notif_client_p): Remove typedef.
9098         (remote_notif_state): Add constructor, destructor, initializer.
9099         <notif_queue>: Now a std::list.
9100         (remote_notif_state_xfree): Don't declare.
9101         * remote-notif.c (remote_notif_process, handle_notification)
9102         (remote_notif_state_allocate): Update.
9103         (~remote_notif_state): Rename from remote_notif_state_xfree.
9104
9105 2019-04-19  Tom Tromey  <tom@tromey.com>
9106
9107         * symfile.c (reread_symbols): Update.
9108         * objfiles.c (objfile_register_static_link)
9109         (objfile_lookup_static_link): Update
9110         (~objfile) Don't delete static_links.
9111         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9112
9113 2019-04-19  Tom Tromey  <tom@tromey.com>
9114
9115         * type-stack.h (struct type_stack) <insert>: Constify string.
9116         * type-stack.c (type_stack::insert): Constify string.
9117         * gdbtypes.h (lookup_template_type): Update.
9118         (address_space_name_to_int): Update.
9119         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9120         const.
9121         (lookup_template_type): Make name const.
9122         * c-exp.y: Update rules.
9123         (lex_one_token, classify_name, classify_inner_name)
9124         (c_print_token): Update.
9125         * p-exp.y: Update rules.
9126         (yylex): Update.
9127         * f-exp.y: Update rules.
9128         (yylex): Update.
9129         * d-exp.y: Update rules.
9130         (lex_one_token, classify_name, classify_inner_name): Update.
9131         * parse.c (write_dollar_variable, copy_name): Return std::string.
9132         * parser-defs.h (copy_name): Change return type.
9133         * m2-exp.y: Update rules.
9134         (yylex): Update.
9135         * go-exp.y (lex_one_token): Update.
9136         Update rules.
9137         (classify_unsafe_function, classify_packaged_name)
9138         (classify_name, yylex): Update.
9139
9140 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9141
9142         * configure.ac: add --enable-source-highlight switch.
9143         * configure: Regenerate.
9144         * top.c (print_gdb_version): plumb --enable-source-highlight
9145         status to "show configuration".
9146
9147 2019-04-19  Tom Tromey  <tromey@adacore.com>
9148
9149         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9150         Check ADA_TYPE_P.
9151         (empty_record, ada_template_to_fixed_record_type_1)
9152         (template_to_static_fixed_type)
9153         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9154         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9155         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9156         macros.
9157
9158 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9159
9160         PR symtab/24423:
9161         * source.c (print_source_lines_base): Advance "iter" when a
9162         control character is seen.
9163
9164 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9165
9166         * inferior.h (struct infcall_suspend_state_deleter):
9167         Catch exception in destructor to avoid crash.
9168
9169 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9170
9171         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9172         close to the add_com "shell".
9173
9174 2019-04-18  Tom Tromey  <tromey@adacore.com>
9175
9176         * process-stratum-target.h (class process_stratum_target)
9177         <stratum>: Add "final".
9178
9179 2019-04-17  Tom Tromey  <tromey@adacore.com>
9180
9181         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9182         against nullptr before use.
9183
9184 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9185
9186         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9187
9188 2019-04-17  Jim Wilson  <jimw@sifive.com>
9189             Andrew Burgess  <andrew.burgess@embecosm.com>
9190
9191         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9192         code read might fail, assume 4-byte breakpoint in that case.
9193
9194 2019-04-15  Leszek Swirski  <leszeks@google.com>
9195
9196         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9197         rather than a hand-rolled POD check when checking for forced MEMORY
9198         classification.
9199
9200 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9201
9202         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9203         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9204         function.
9205         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9206         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9207         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9208         declaration.
9209
9210 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9211
9212         * aarch64-linux-nat.c
9213         (aarch64_linux_nat_target::thread_architecture): Add override.
9214         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9215         each VQ.
9216
9217 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9218
9219         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9220
9221 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9224         target types of size 96-bits, add some additional comments, and
9225         check that the builtin type we found was the correct size.
9226
9227 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9228
9229         * utils.c (prompt_for_continue): Don't restore the styling at the
9230         end, as applied_style has the wrong value.  This fixes styling in
9231         long lists of file names that are interrupted by the "Continue?"
9232         prompt.
9233
9234 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9235
9236         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9237         * c-lang.c (c_language_defn): Likewise.
9238         (cplus_language_defn): Likewise.
9239         (asm_language_defn): Likewise.
9240         (minimal_language_defn): Likewise.
9241         * d-lang.c (d_language_defn): Likewise.
9242         * f-lang.c (f_language_defn): Likewise.
9243         * go-lang.c (go_language_defn): Likewise.
9244         * language.c (unknown_language_defn): Likewise.
9245         (auto_language_defn): Likewise.
9246         * language.h (struct language_defn): Remove la_magic field.
9247         (LANG_MAGIC): Delete.
9248         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9249         * objc-lang.c (objc_language_defn): Likewise.
9250         * opencl-lang.c (opencl_language_defn): Likewise.
9251         * p-lang.c (pascal_language_defn): Likewise.
9252         * rust-lang.c (rust_language_defn): Likewise.
9253
9254 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9255
9256         * riscv-tdep.c (riscv_type_align): New function.
9257         (riscv_type_alignment): Delete.
9258         (riscv_arg_location): Use 'type_align'.
9259         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9260
9261 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9262
9263         * gdbtypes.c (type_align): A struct with no non-static fields also
9264         has alignment of 1.
9265
9266 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9269         component to 0.
9270         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9271         member.
9272         (riscv_struct_info::analyse): New implementation using new
9273         analyse_inner member function.
9274         (riscv_struct_info::field_offset): New member function.
9275         (riscv_struct_info::m_offsets): New member variable.
9276         (riscv_struct_info::analyse_inner): New private member function,
9277         takes the old implementation of riscv_struct_info::analyse but
9278         extended to track field offsets.
9279         (riscv_call_arg_struct): Update the struct folding special cases
9280         to handle cases where empty C++ structs, which are non-zero
9281         length, are found.
9282         (riscv_arg_location): Initialise the length of each location, a
9283         non-zero length now indicates the location is in use.
9284         (riscv_push_dummy_call): Allow for the first location having a
9285         non-zero offset when setting up arguments.
9286         (riscv_return_value): Likewise, but for return values.
9287
9288 2019-04-11  Tom Tromey  <tromey@adacore.com>
9289
9290         * utils.c (internal_vproblem): Make "msg" const.
9291
9292 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9293
9294         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9295         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9296         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9297         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9298
9299 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9300
9301         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9302         function.
9303         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9304         of amd64_collect_native_gregset.
9305         (amd64_linux_nat_target::store_registers): Likewise.
9306
9307 2019-04-10  Tom Tromey  <tom@tromey.com>
9308
9309         * symtab.c (lookup_global_symbol_from_objfile)
9310         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9311         * objfiles.h (class separate_debug_iterator): New.
9312         (class separate_debug_range): New.
9313         (struct objfile) <separate_debug_objfiles>: New method.
9314         (objfile_separate_debug_iterate): Don't declare.
9315         * objfiles.c (separate_debug_iterator::operator++): Rename from
9316         objfile_separate_debug_iterate.
9317         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9318         iterator.
9319         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9320         iterator.
9321
9322 2019-04-10  Tom Tromey  <tom@tromey.com>
9323
9324         * symfile.c (reread_symbols): Remove old comment.
9325         * objfiles.c (free_all_objfiles): Fix a typo.
9326
9327 2019-04-10  Tom Tromey  <tom@tromey.com>
9328
9329         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9330         * minsyms.c (lookup_minimal_symbol): Use foreach.
9331         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9332         (lookup_minimal_symbol_solib_trampoline): Likewise.
9333         * symfile.c (reread_symbols): Use foreach.
9334
9335 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9336             Tom Tromey  <tromey@adacore.com>
9337
9338         PR rust/24414:
9339         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9340         (rust_lex_int_test): Change "value" to be LONGEST.
9341         (rust_lex_tests): Add test for long integer literal.
9342
9343 2019-04-09  Tom Tromey  <tromey@adacore.com>
9344
9345         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9346         to bool.
9347         (extended_remote_target::attach): Update.
9348         (remote_target::remote_notice_new_inferior): Update.
9349         (remote_target::add_current_inferior_and_thread): Update.
9350         * inferior.c (exit_inferior_1): Use "false".
9351         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9352
9353 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9354
9355         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9356         the "start" command.
9357
9358 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9359
9360         * python/py-inferior.c (infpy_thread_from_thread_handle):
9361         Adjust comments to reflect renaming of thread_from_thread_handle
9362         to thread_from_handle.  Adjust keywords.  Fix type error message.
9363         (inferior_object_methods): Add thread_from_handle.  Retain
9364         thread_from_thread_handle, but mark it as deprecated.
9365
9366 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9367
9368         * gdbthread.h (find_thread_by_handle): Revise declaration.
9369         * thread.c (find_thread_by_handle): Likewise.  Adjust
9370         implementation too.
9371         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9372         support for buffer objects as handles.
9373
9374 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9375
9376         * python/py-infthread.c (thpy_thread_handle): New function.
9377         (thread_object_methods): Register thpy_thread_handle.
9378
9379 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9380
9381         * gdbthread.h (thread_to_thread_handle): Declare.
9382         * thread.c (gdbtypes.h): Include.
9383         (thread_to_thread_handle): New function.
9384
9385         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9386         (target_thread_info_to_thread_handle): Declare.
9387         * target.c (target_thread_info_to_thread_handle): New function.
9388         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9389         * target-delegates.c: Regenerate.
9390
9391         * linux-thread-db.c (class thread_db_target): Add method
9392         thread_info_to_thread_handle.
9393         (thread_db_target::thread_info_to_thread_handle): Define.
9394         * remote.c (class remote_target): Add new method
9395         thread_info_to_thread_handle.
9396         (remote_target::thread_info_to_thread_handle): Define.
9397
9398 2019-04-08  Pedro Alves  <palves@redhat.com>
9399
9400         * common/common-exceptions.c (throw_exception): Don't create
9401         named object to throw; throw directly.
9402         (throw_it): Likewise.  Don't initialize gdb_exception::message
9403         here, with new; pass FMT and AP to the ctor instead.
9404         * common/common-exceptions.h: Include <string>.
9405         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9406         const char *, va_list)): New ctor.  Use std::make_shared.
9407         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9408         errors)): Delete.
9409         (gdb_exception_error::gdb_exception_error(enum errors, const char
9410         *, va_list)): New.
9411         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9412         Add assertion.
9413         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9414         errors)): Delete.
9415         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9416         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9417         Add assertion.
9418
9419 2019-04-08  Tom Tromey  <tom@tromey.com>
9420
9421         * valops.c (value_rtti_indirect_type): Replace throw_exception
9422         with throw.
9423         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9424         with throw.
9425         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9426         throw.
9427         * target.c (target_translate_tls_address): Replace throw_exception
9428         with throw.
9429         * stack.c (frame_apply_command_count): Replace throw_exception
9430         with throw.
9431         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9432         throw.
9433         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9434         with throw.
9435         * rs6000-tdep.c (rs6000_frame_cache)
9436         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9437         * remote.c: Replace throw_exception with throw.
9438         * record-full.c (record_full_message, record_full_wait_1)
9439         (record_full_restore): Replace throw_exception with throw.
9440         * record-btrace.c:
9441         (get_thread_current_frame_id, record_btrace_start_replaying)
9442         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9443         (cmd_record_btrace_start): Replace throw_exception with throw.
9444         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9445         throw.
9446         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9447         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9448         * linespec.c:
9449         (find_linespec_symbols): Replace throw_exception with throw.
9450         * infrun.c (displaced_step_prepare, resume): Replace
9451         throw_exception with throw.
9452         * infcmd.c (post_create_inferior): Replace throw_exception with
9453         throw.
9454         * inf-loop.c (inferior_event_handler): Replace throw_exception
9455         with throw.
9456         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9457         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9458         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9459         (get_prev_frame_always, get_frame_pc_if_available)
9460         (get_frame_address_in_block_if_available, get_frame_language):
9461         Replace throw_exception with throw.
9462         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9463         throw_exception with throw.
9464         * eval.c (fetch_subexp_value, evaluate_var_value)
9465         (evaluate_funcall, evaluate_subexp_standard): Replace
9466         throw_exception with throw.
9467         * dwarf2loc.c (call_site_find_chain)
9468         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9469         Replace throw_exception with throw.
9470         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9471         with throw.
9472         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9473         throw.
9474         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9475         * completer.c (complete_line_internal): Replace throw_exception
9476         with throw.
9477         * compile/compile-object-run.c (compile_object_run): Replace
9478         throw_exception with throw.
9479         * cli/cli-script.c (process_next_line): Replace throw_exception
9480         with throw.
9481         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9482         (btrace_enable, btrace_maint_update_pt_packets): Replace
9483         throw_exception with throw.
9484         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9485         throw_exception with throw.
9486         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9487         throw_exception with throw.
9488         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9489         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9490         * aarch64-tdep.c (aarch64_make_prologue_cache)
9491         (aarch64_make_stub_cache): Replace throw_exception with throw.
9492
9493 2019-04-08  Tom Tromey  <tom@tromey.com>
9494
9495         * common/common-exceptions.c (throw_exception): Rename from
9496         throw_exception_cxx.  Remove old copy.  Make argument const.
9497         (throw_it): Create and throw exception objects directly.
9498         * common/common-exceptions.h (throw_exception): Make argument
9499         const.
9500         (struct gdb_exception_error): Add constructor.
9501         (struct gdb_exception_quit): Add constructor.
9502
9503 2019-04-08  Tom Tromey  <tom@tromey.com>
9504
9505         * common/common-exceptions.h (exception_rethrow): Don't declare.
9506         (TRY_SJLJ): Update comment.
9507         (TRY, CATCH, END_CATCH): Remove.
9508         * common/common-exceptions.c (exception_rethrow): Remove.
9509
9510 2019-04-08  Tom Tromey  <tom@tromey.com>
9511
9512         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9513         Remove.
9514         (gdb_exception_error): Rename from
9515         gdb_exception_RETURN_MASK_ERROR.
9516         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9517         (gdb_quit_bad_alloc): Update.
9518         * aarch64-tdep.c: Update.
9519         * ada-lang.c: Update.
9520         * ada-typeprint.c: Update.
9521         * ada-valprint.c: Update.
9522         * amd64-tdep.c: Update.
9523         * arch-utils.c: Update.
9524         * break-catch-throw.c: Update.
9525         * breakpoint.c: Update.
9526         * btrace.c: Update.
9527         * c-varobj.c: Update.
9528         * cli/cli-cmds.c: Update.
9529         * cli/cli-interp.c: Update.
9530         * cli/cli-script.c: Update.
9531         * common/common-exceptions.c: Update.
9532         * common/new-op.c: Update.
9533         * common/selftest.c: Update.
9534         * compile/compile-c-symbols.c: Update.
9535         * compile/compile-cplus-symbols.c: Update.
9536         * compile/compile-object-load.c: Update.
9537         * compile/compile-object-run.c: Update.
9538         * completer.c: Update.
9539         * corelow.c: Update.
9540         * cp-abi.c: Update.
9541         * cp-support.c: Update.
9542         * cp-valprint.c: Update.
9543         * darwin-nat.c: Update.
9544         * disasm-selftests.c: Update.
9545         * dtrace-probe.c: Update.
9546         * dwarf-index-cache.c: Update.
9547         * dwarf-index-write.c: Update.
9548         * dwarf2-frame-tailcall.c: Update.
9549         * dwarf2-frame.c: Update.
9550         * dwarf2loc.c: Update.
9551         * dwarf2read.c: Update.
9552         * eval.c: Update.
9553         * event-loop.c: Update.
9554         * event-top.c: Update.
9555         * exec.c: Update.
9556         * f-valprint.c: Update.
9557         * fbsd-tdep.c: Update.
9558         * frame-unwind.c: Update.
9559         * frame.c: Update.
9560         * gdbtypes.c: Update.
9561         * gnu-v3-abi.c: Update.
9562         * guile/guile-internal.h: Update.
9563         * guile/scm-block.c: Update.
9564         * guile/scm-breakpoint.c: Update.
9565         * guile/scm-cmd.c: Update.
9566         * guile/scm-disasm.c: Update.
9567         * guile/scm-frame.c: Update.
9568         * guile/scm-lazy-string.c: Update.
9569         * guile/scm-math.c: Update.
9570         * guile/scm-param.c: Update.
9571         * guile/scm-ports.c: Update.
9572         * guile/scm-pretty-print.c: Update.
9573         * guile/scm-symbol.c: Update.
9574         * guile/scm-symtab.c: Update.
9575         * guile/scm-type.c: Update.
9576         * guile/scm-value.c: Update.
9577         * i386-linux-tdep.c: Update.
9578         * i386-tdep.c: Update.
9579         * inf-loop.c: Update.
9580         * infcall.c: Update.
9581         * infcmd.c: Update.
9582         * infrun.c: Update.
9583         * jit.c: Update.
9584         * language.c: Update.
9585         * linespec.c: Update.
9586         * linux-fork.c: Update.
9587         * linux-nat.c: Update.
9588         * linux-tdep.c: Update.
9589         * linux-thread-db.c: Update.
9590         * main.c: Update.
9591         * mi/mi-cmd-break.c: Update.
9592         * mi/mi-cmd-stack.c: Update.
9593         * mi/mi-interp.c: Update.
9594         * mi/mi-main.c: Update.
9595         * objc-lang.c: Update.
9596         * p-valprint.c: Update.
9597         * parse.c: Update.
9598         * ppc-linux-tdep.c: Update.
9599         * printcmd.c: Update.
9600         * python/py-arch.c: Update.
9601         * python/py-breakpoint.c: Update.
9602         * python/py-cmd.c: Update.
9603         * python/py-finishbreakpoint.c: Update.
9604         * python/py-frame.c: Update.
9605         * python/py-framefilter.c: Update.
9606         * python/py-gdb-readline.c: Update.
9607         * python/py-inferior.c: Update.
9608         * python/py-infthread.c: Update.
9609         * python/py-lazy-string.c: Update.
9610         * python/py-linetable.c: Update.
9611         * python/py-objfile.c: Update.
9612         * python/py-param.c: Update.
9613         * python/py-prettyprint.c: Update.
9614         * python/py-progspace.c: Update.
9615         * python/py-record-btrace.c: Update.
9616         * python/py-record.c: Update.
9617         * python/py-symbol.c: Update.
9618         * python/py-type.c: Update.
9619         * python/py-unwind.c: Update.
9620         * python/py-utils.c: Update.
9621         * python/py-value.c: Update.
9622         * python/python.c: Update.
9623         * record-btrace.c: Update.
9624         * record-full.c: Update.
9625         * remote-fileio.c: Update.
9626         * remote.c: Update.
9627         * riscv-tdep.c: Update.
9628         * rs6000-aix-tdep.c: Update.
9629         * rs6000-tdep.c: Update.
9630         * rust-exp.y: Update.
9631         * rust-lang.c: Update.
9632         * s390-tdep.c: Update.
9633         * selftest-arch.c: Update.
9634         * solib-dsbt.c: Update.
9635         * solib-frv.c: Update.
9636         * solib-spu.c: Update.
9637         * solib-svr4.c: Update.
9638         * solib.c: Update.
9639         * sparc64-linux-tdep.c: Update.
9640         * stack.c: Update.
9641         * symfile-mem.c: Update.
9642         * symmisc.c: Update.
9643         * target.c: Update.
9644         * thread.c: Update.
9645         * top.c: Update.
9646         * tracefile-tfile.c: Update.
9647         * tui/tui.c: Update.
9648         * typeprint.c: Update.
9649         * unittests/cli-utils-selftests.c: Update.
9650         * unittests/parse-connection-spec-selftests.c: Update.
9651         * valops.c: Update.
9652         * valprint.c: Update.
9653         * value.c: Update.
9654         * varobj.c: Update.
9655         * windows-nat.c: Update.
9656         * x86-linux-nat.c: Update.
9657         * xml-support.c: Update.
9658
9659 2019-04-08  Tom Tromey  <tom@tromey.com>
9660
9661         * xml-support.c: Use C++ exception handling.
9662         * x86-linux-nat.c: Use C++ exception handling.
9663         * windows-nat.c: Use C++ exception handling.
9664         * varobj.c: Use C++ exception handling.
9665         * value.c: Use C++ exception handling.
9666         * valprint.c: Use C++ exception handling.
9667         * valops.c: Use C++ exception handling.
9668         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9669         handling.
9670         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9671         * typeprint.c: Use C++ exception handling.
9672         * tui/tui.c: Use C++ exception handling.
9673         * tracefile-tfile.c: Use C++ exception handling.
9674         * top.c: Use C++ exception handling.
9675         * thread.c: Use C++ exception handling.
9676         * target.c: Use C++ exception handling.
9677         * symmisc.c: Use C++ exception handling.
9678         * symfile-mem.c: Use C++ exception handling.
9679         * stack.c: Use C++ exception handling.
9680         * sparc64-linux-tdep.c: Use C++ exception handling.
9681         * solib.c: Use C++ exception handling.
9682         * solib-svr4.c: Use C++ exception handling.
9683         * solib-spu.c: Use C++ exception handling.
9684         * solib-frv.c: Use C++ exception handling.
9685         * solib-dsbt.c: Use C++ exception handling.
9686         * selftest-arch.c: Use C++ exception handling.
9687         * s390-tdep.c: Use C++ exception handling.
9688         * rust-lang.c: Use C++ exception handling.
9689         * rust-exp.y: Use C++ exception handling.
9690         * rs6000-tdep.c: Use C++ exception handling.
9691         * rs6000-aix-tdep.c: Use C++ exception handling.
9692         * riscv-tdep.c: Use C++ exception handling.
9693         * remote.c: Use C++ exception handling.
9694         * remote-fileio.c: Use C++ exception handling.
9695         * record-full.c: Use C++ exception handling.
9696         * record-btrace.c: Use C++ exception handling.
9697         * python/python.c: Use C++ exception handling.
9698         * python/py-value.c: Use C++ exception handling.
9699         * python/py-utils.c: Use C++ exception handling.
9700         * python/py-unwind.c: Use C++ exception handling.
9701         * python/py-type.c: Use C++ exception handling.
9702         * python/py-symbol.c: Use C++ exception handling.
9703         * python/py-record.c: Use C++ exception handling.
9704         * python/py-record-btrace.c: Use C++ exception handling.
9705         * python/py-progspace.c: Use C++ exception handling.
9706         * python/py-prettyprint.c: Use C++ exception handling.
9707         * python/py-param.c: Use C++ exception handling.
9708         * python/py-objfile.c: Use C++ exception handling.
9709         * python/py-linetable.c: Use C++ exception handling.
9710         * python/py-lazy-string.c: Use C++ exception handling.
9711         * python/py-infthread.c: Use C++ exception handling.
9712         * python/py-inferior.c: Use C++ exception handling.
9713         * python/py-gdb-readline.c: Use C++ exception handling.
9714         * python/py-framefilter.c: Use C++ exception handling.
9715         * python/py-frame.c: Use C++ exception handling.
9716         * python/py-finishbreakpoint.c: Use C++ exception handling.
9717         * python/py-cmd.c: Use C++ exception handling.
9718         * python/py-breakpoint.c: Use C++ exception handling.
9719         * python/py-arch.c: Use C++ exception handling.
9720         * printcmd.c: Use C++ exception handling.
9721         * ppc-linux-tdep.c: Use C++ exception handling.
9722         * parse.c: Use C++ exception handling.
9723         * p-valprint.c: Use C++ exception handling.
9724         * objc-lang.c: Use C++ exception handling.
9725         * mi/mi-main.c: Use C++ exception handling.
9726         * mi/mi-interp.c: Use C++ exception handling.
9727         * mi/mi-cmd-stack.c: Use C++ exception handling.
9728         * mi/mi-cmd-break.c: Use C++ exception handling.
9729         * main.c: Use C++ exception handling.
9730         * linux-thread-db.c: Use C++ exception handling.
9731         * linux-tdep.c: Use C++ exception handling.
9732         * linux-nat.c: Use C++ exception handling.
9733         * linux-fork.c: Use C++ exception handling.
9734         * linespec.c: Use C++ exception handling.
9735         * language.c: Use C++ exception handling.
9736         * jit.c: Use C++ exception handling.
9737         * infrun.c: Use C++ exception handling.
9738         * infcmd.c: Use C++ exception handling.
9739         * infcall.c: Use C++ exception handling.
9740         * inf-loop.c: Use C++ exception handling.
9741         * i386-tdep.c: Use C++ exception handling.
9742         * i386-linux-tdep.c: Use C++ exception handling.
9743         * guile/scm-value.c: Use C++ exception handling.
9744         * guile/scm-type.c: Use C++ exception handling.
9745         * guile/scm-symtab.c: Use C++ exception handling.
9746         * guile/scm-symbol.c: Use C++ exception handling.
9747         * guile/scm-pretty-print.c: Use C++ exception handling.
9748         * guile/scm-ports.c: Use C++ exception handling.
9749         * guile/scm-param.c: Use C++ exception handling.
9750         * guile/scm-math.c: Use C++ exception handling.
9751         * guile/scm-lazy-string.c: Use C++ exception handling.
9752         * guile/scm-frame.c: Use C++ exception handling.
9753         * guile/scm-disasm.c: Use C++ exception handling.
9754         * guile/scm-cmd.c: Use C++ exception handling.
9755         * guile/scm-breakpoint.c: Use C++ exception handling.
9756         * guile/scm-block.c: Use C++ exception handling.
9757         * guile/guile-internal.h: Use C++ exception handling.
9758         * gnu-v3-abi.c: Use C++ exception handling.
9759         * gdbtypes.c: Use C++ exception handling.
9760         * frame.c: Use C++ exception handling.
9761         * frame-unwind.c: Use C++ exception handling.
9762         * fbsd-tdep.c: Use C++ exception handling.
9763         * f-valprint.c: Use C++ exception handling.
9764         * exec.c: Use C++ exception handling.
9765         * event-top.c: Use C++ exception handling.
9766         * event-loop.c: Use C++ exception handling.
9767         * eval.c: Use C++ exception handling.
9768         * dwarf2read.c: Use C++ exception handling.
9769         * dwarf2loc.c: Use C++ exception handling.
9770         * dwarf2-frame.c: Use C++ exception handling.
9771         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9772         * dwarf-index-write.c: Use C++ exception handling.
9773         * dwarf-index-cache.c: Use C++ exception handling.
9774         * dtrace-probe.c: Use C++ exception handling.
9775         * disasm-selftests.c: Use C++ exception handling.
9776         * darwin-nat.c: Use C++ exception handling.
9777         * cp-valprint.c: Use C++ exception handling.
9778         * cp-support.c: Use C++ exception handling.
9779         * cp-abi.c: Use C++ exception handling.
9780         * corelow.c: Use C++ exception handling.
9781         * completer.c: Use C++ exception handling.
9782         * compile/compile-object-run.c: Use C++ exception handling.
9783         * compile/compile-object-load.c: Use C++ exception handling.
9784         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9785         * compile/compile-c-symbols.c: Use C++ exception handling.
9786         * common/selftest.c: Use C++ exception handling.
9787         * common/new-op.c: Use C++ exception handling.
9788         * cli/cli-script.c: Use C++ exception handling.
9789         * cli/cli-interp.c: Use C++ exception handling.
9790         * cli/cli-cmds.c: Use C++ exception handling.
9791         * c-varobj.c: Use C++ exception handling.
9792         * btrace.c: Use C++ exception handling.
9793         * breakpoint.c: Use C++ exception handling.
9794         * break-catch-throw.c: Use C++ exception handling.
9795         * arch-utils.c: Use C++ exception handling.
9796         * amd64-tdep.c: Use C++ exception handling.
9797         * ada-valprint.c: Use C++ exception handling.
9798         * ada-typeprint.c: Use C++ exception handling.
9799         * ada-lang.c: Use C++ exception handling.
9800         * aarch64-tdep.c: Use C++ exception handling.
9801
9802 2019-04-08  Tom Tromey  <tom@tromey.com>
9803
9804         * xml-support.c (gdb_xml_parser::parse): Update.
9805         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9806         * value.c (show_convenience): Update.
9807         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9808         (test_parse_flags_qcs): Update.
9809         * thread.c (thr_try_catch_cmd): Update.
9810         * target.c (target_translate_tls_address): Update.
9811         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9812         (info_frame_command_core, frame_apply_command_count): Update.
9813         * rust-exp.y (rust_lex_exception_test): Update.
9814         * riscv-tdep.c (riscv_print_one_register_info): Update.
9815         * remote.c (remote_target::enable_btrace): Update.
9816         * record-btrace.c (record_btrace_enable_warn): Update.
9817         * python/py-utils.c (gdbpy_convert_exception): Update.
9818         * printcmd.c (do_one_display, print_variable_and_value): Update.
9819         * mi/mi-main.c (mi_print_exception): Update.
9820         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9821         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9822         * linux-nat.c (linux_nat_target::attach): Update.
9823         * linux-fork.c (class scoped_switch_fork_info): Update.
9824         * infrun.c (displaced_step_prepare): Update.
9825         * infcall.c (call_function_by_hand_dummy): Update.
9826         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9827         * gnu-v3-abi.c (print_one_vtable): Update.
9828         * frame.c (get_prev_frame_always): Update.
9829         * f-valprint.c (info_common_command_for_block): Update.
9830         * exec.c (try_open_exec_file): Update.
9831         * exceptions.c (print_exception, exception_print)
9832         (exception_fprintf, exception_print_same): Update.
9833         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9834         * dwarf-index-cache.c (index_cache::store)
9835         (index_cache::lookup_gdb_index): Update.
9836         * darwin-nat.c (maybe_cache_shell): Update.
9837         * cp-valprint.c (cp_print_value_fields): Update.
9838         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9839         (gcc_cplus_symbol_address): Update.
9840         * compile/compile-c-symbols.c (gcc_convert_symbol)
9841         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9842         * common/selftest.c: Update.
9843         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9844         a std::string.
9845         (exception_try_scope_entry, exception_try_scope_exit): Don't
9846         declare.
9847         (struct exception_try_scope): Remove.
9848         (TRY): Don't use exception_try_scope.
9849         (struct gdb_exception): Add constructor, operator=.
9850         <what>: New method.
9851         (struct gdb_exception_RETURN_MASK_ALL)
9852         (struct gdb_exception_RETURN_MASK_ERROR)
9853         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9854         (struct gdb_quit_bad_alloc): Update.
9855         * common/common-exceptions.c (exception_none): Change
9856         initializer.
9857         (struct catcher) <state, exception>: Initialize inline.
9858         <prev>: Remove member.
9859         (current_catcher): Remove.
9860         (catchers): New global.
9861         (exceptions_state_mc_init): Simplify.
9862         (catcher_pop): Remove.
9863         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9864         (try_scope_depth, exception_try_scope_entry)
9865         (exception_try_scope_exit): Remove.
9866         (throw_exception_sjlj): Update.
9867         (exception_messages, exception_messages_size): Remove.
9868         (throw_it): Simplify.
9869         (gdb_exception_sliced_copy): Remove.
9870         (throw_exception_cxx): Update.
9871         * cli/cli-script.c (script_from_file): Update.
9872         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9873         Update.
9874         * ada-valprint.c (ada_val_print): Update.
9875         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9876         (create_excep_cond_exprs): Update.
9877
9878 2019-04-08  Tom Tromey  <tom@tromey.com>
9879
9880         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9881         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9882         (TRY, CATCH, END_CATCH): Remove some definitions.
9883         * common/common-exceptions.c: Don't use GDB_XCPT.
9884         (catcher_list_size): Remove.
9885         (throw_exception, throw_it): Simplify.
9886
9887 2019-04-05  Tom Tromey  <tom@tromey.com>
9888
9889         Revert the header-sorting patch.
9890         * ft32-tdep.c: Revert.
9891         * frv-tdep.c: Revert.
9892         * frv-linux-tdep.c: Revert.
9893         * frame.c: Revert.
9894         * frame-unwind.c: Revert.
9895         * frame-base.c: Revert.
9896         * fork-child.c: Revert.
9897         * findvar.c: Revert.
9898         * findcmd.c: Revert.
9899         * filesystem.c: Revert.
9900         * filename-seen-cache.h: Revert.
9901         * filename-seen-cache.c: Revert.
9902         * fbsd-tdep.c: Revert.
9903         * fbsd-nat.h: Revert.
9904         * fbsd-nat.c: Revert.
9905         * f-valprint.c: Revert.
9906         * f-typeprint.c: Revert.
9907         * f-lang.c: Revert.
9908         * extension.h: Revert.
9909         * extension.c: Revert.
9910         * extension-priv.h: Revert.
9911         * expprint.c: Revert.
9912         * exec.h: Revert.
9913         * exec.c: Revert.
9914         * exceptions.c: Revert.
9915         * event-top.c: Revert.
9916         * event-loop.c: Revert.
9917         * eval.c: Revert.
9918         * elfread.c: Revert.
9919         * dwarf2read.h: Revert.
9920         * dwarf2read.c: Revert.
9921         * dwarf2loc.c: Revert.
9922         * dwarf2expr.h: Revert.
9923         * dwarf2expr.c: Revert.
9924         * dwarf2-frame.c: Revert.
9925         * dwarf2-frame-tailcall.c: Revert.
9926         * dwarf-index-write.h: Revert.
9927         * dwarf-index-write.c: Revert.
9928         * dwarf-index-common.c: Revert.
9929         * dwarf-index-cache.h: Revert.
9930         * dwarf-index-cache.c: Revert.
9931         * dummy-frame.c: Revert.
9932         * dtrace-probe.c: Revert.
9933         * disasm.h: Revert.
9934         * disasm.c: Revert.
9935         * disasm-selftests.c: Revert.
9936         * dictionary.c: Revert.
9937         * dicos-tdep.c: Revert.
9938         * demangle.c: Revert.
9939         * dcache.h: Revert.
9940         * dcache.c: Revert.
9941         * darwin-nat.h: Revert.
9942         * darwin-nat.c: Revert.
9943         * darwin-nat-info.c: Revert.
9944         * d-valprint.c: Revert.
9945         * d-namespace.c: Revert.
9946         * d-lang.c: Revert.
9947         * ctf.c: Revert.
9948         * csky-tdep.c: Revert.
9949         * csky-linux-tdep.c: Revert.
9950         * cris-tdep.c: Revert.
9951         * cris-linux-tdep.c: Revert.
9952         * cp-valprint.c: Revert.
9953         * cp-support.c: Revert.
9954         * cp-namespace.c: Revert.
9955         * cp-abi.c: Revert.
9956         * corelow.c: Revert.
9957         * corefile.c: Revert.
9958         * continuations.c: Revert.
9959         * completer.h: Revert.
9960         * completer.c: Revert.
9961         * complaints.c: Revert.
9962         * coffread.c: Revert.
9963         * coff-pe-read.c: Revert.
9964         * cli-out.h: Revert.
9965         * cli-out.c: Revert.
9966         * charset.c: Revert.
9967         * c-varobj.c: Revert.
9968         * c-valprint.c: Revert.
9969         * c-typeprint.c: Revert.
9970         * c-lang.c: Revert.
9971         * buildsym.c: Revert.
9972         * buildsym-legacy.c: Revert.
9973         * build-id.h: Revert.
9974         * build-id.c: Revert.
9975         * btrace.c: Revert.
9976         * bsd-uthread.c: Revert.
9977         * breakpoint.h: Revert.
9978         * breakpoint.c: Revert.
9979         * break-catch-throw.c: Revert.
9980         * break-catch-syscall.c: Revert.
9981         * break-catch-sig.c: Revert.
9982         * blockframe.c: Revert.
9983         * block.c: Revert.
9984         * bfin-tdep.c: Revert.
9985         * bfin-linux-tdep.c: Revert.
9986         * bfd-target.c: Revert.
9987         * bcache.c: Revert.
9988         * ax-general.c: Revert.
9989         * ax-gdb.h: Revert.
9990         * ax-gdb.c: Revert.
9991         * avr-tdep.c: Revert.
9992         * auxv.c: Revert.
9993         * auto-load.c: Revert.
9994         * arm-wince-tdep.c: Revert.
9995         * arm-tdep.c: Revert.
9996         * arm-symbian-tdep.c: Revert.
9997         * arm-pikeos-tdep.c: Revert.
9998         * arm-obsd-tdep.c: Revert.
9999         * arm-nbsd-tdep.c: Revert.
10000         * arm-nbsd-nat.c: Revert.
10001         * arm-linux-tdep.c: Revert.
10002         * arm-linux-nat.c: Revert.
10003         * arm-fbsd-tdep.c: Revert.
10004         * arm-fbsd-nat.c: Revert.
10005         * arm-bsd-tdep.c: Revert.
10006         * arch-utils.c: Revert.
10007         * arc-tdep.c: Revert.
10008         * arc-newlib-tdep.c: Revert.
10009         * annotate.h: Revert.
10010         * annotate.c: Revert.
10011         * amd64-windows-tdep.c: Revert.
10012         * amd64-windows-nat.c: Revert.
10013         * amd64-tdep.c: Revert.
10014         * amd64-sol2-tdep.c: Revert.
10015         * amd64-obsd-tdep.c: Revert.
10016         * amd64-obsd-nat.c: Revert.
10017         * amd64-nbsd-tdep.c: Revert.
10018         * amd64-nbsd-nat.c: Revert.
10019         * amd64-nat.c: Revert.
10020         * amd64-linux-tdep.c: Revert.
10021         * amd64-linux-nat.c: Revert.
10022         * amd64-fbsd-tdep.c: Revert.
10023         * amd64-fbsd-nat.c: Revert.
10024         * amd64-dicos-tdep.c: Revert.
10025         * amd64-darwin-tdep.c: Revert.
10026         * amd64-bsd-nat.c: Revert.
10027         * alpha-tdep.c: Revert.
10028         * alpha-obsd-tdep.c: Revert.
10029         * alpha-nbsd-tdep.c: Revert.
10030         * alpha-mdebug-tdep.c: Revert.
10031         * alpha-linux-tdep.c: Revert.
10032         * alpha-linux-nat.c: Revert.
10033         * alpha-bsd-tdep.c: Revert.
10034         * alpha-bsd-nat.c: Revert.
10035         * aix-thread.c: Revert.
10036         * agent.c: Revert.
10037         * addrmap.c: Revert.
10038         * ada-varobj.c: Revert.
10039         * ada-valprint.c: Revert.
10040         * ada-typeprint.c: Revert.
10041         * ada-tasks.c: Revert.
10042         * ada-lang.c: Revert.
10043         * aarch64-tdep.c: Revert.
10044         * aarch64-ravenscar-thread.c: Revert.
10045         * aarch64-newlib-tdep.c: Revert.
10046         * aarch64-linux-tdep.c: Revert.
10047         * aarch64-linux-nat.c: Revert.
10048         * aarch64-fbsd-tdep.c: Revert.
10049         * aarch64-fbsd-nat.c: Revert.
10050         * aarch32-linux-nat.c: Revert.
10051
10052 2019-04-05  Tom Tromey  <tom@tromey.com>
10053
10054         * ft32-tdep.c: Sort headers.
10055         * frv-tdep.c: Sort headers.
10056         * frv-linux-tdep.c: Sort headers.
10057         * frame.c: Sort headers.
10058         * frame-unwind.c: Sort headers.
10059         * frame-base.c: Sort headers.
10060         * fork-child.c: Sort headers.
10061         * findvar.c: Sort headers.
10062         * findcmd.c: Sort headers.
10063         * filesystem.c: Sort headers.
10064         * filename-seen-cache.h: Sort headers.
10065         * filename-seen-cache.c: Sort headers.
10066         * fbsd-tdep.c: Sort headers.
10067         * fbsd-nat.h: Sort headers.
10068         * fbsd-nat.c: Sort headers.
10069         * f-valprint.c: Sort headers.
10070         * f-typeprint.c: Sort headers.
10071         * f-lang.c: Sort headers.
10072         * extension.h: Sort headers.
10073         * extension.c: Sort headers.
10074         * extension-priv.h: Sort headers.
10075         * expprint.c: Sort headers.
10076         * exec.h: Sort headers.
10077         * exec.c: Sort headers.
10078         * exceptions.c: Sort headers.
10079         * event-top.c: Sort headers.
10080         * event-loop.c: Sort headers.
10081         * eval.c: Sort headers.
10082         * elfread.c: Sort headers.
10083         * dwarf2read.h: Sort headers.
10084         * dwarf2read.c: Sort headers.
10085         * dwarf2loc.c: Sort headers.
10086         * dwarf2expr.h: Sort headers.
10087         * dwarf2expr.c: Sort headers.
10088         * dwarf2-frame.c: Sort headers.
10089         * dwarf2-frame-tailcall.c: Sort headers.
10090         * dwarf-index-write.h: Sort headers.
10091         * dwarf-index-write.c: Sort headers.
10092         * dwarf-index-common.c: Sort headers.
10093         * dwarf-index-cache.h: Sort headers.
10094         * dwarf-index-cache.c: Sort headers.
10095         * dummy-frame.c: Sort headers.
10096         * dtrace-probe.c: Sort headers.
10097         * disasm.h: Sort headers.
10098         * disasm.c: Sort headers.
10099         * disasm-selftests.c: Sort headers.
10100         * dictionary.c: Sort headers.
10101         * dicos-tdep.c: Sort headers.
10102         * demangle.c: Sort headers.
10103         * dcache.h: Sort headers.
10104         * dcache.c: Sort headers.
10105         * darwin-nat.h: Sort headers.
10106         * darwin-nat.c: Sort headers.
10107         * darwin-nat-info.c: Sort headers.
10108         * d-valprint.c: Sort headers.
10109         * d-namespace.c: Sort headers.
10110         * d-lang.c: Sort headers.
10111         * ctf.c: Sort headers.
10112         * csky-tdep.c: Sort headers.
10113         * csky-linux-tdep.c: Sort headers.
10114         * cris-tdep.c: Sort headers.
10115         * cris-linux-tdep.c: Sort headers.
10116         * cp-valprint.c: Sort headers.
10117         * cp-support.c: Sort headers.
10118         * cp-namespace.c: Sort headers.
10119         * cp-abi.c: Sort headers.
10120         * corelow.c: Sort headers.
10121         * corefile.c: Sort headers.
10122         * continuations.c: Sort headers.
10123         * completer.h: Sort headers.
10124         * completer.c: Sort headers.
10125         * complaints.c: Sort headers.
10126         * coffread.c: Sort headers.
10127         * coff-pe-read.c: Sort headers.
10128         * cli-out.h: Sort headers.
10129         * cli-out.c: Sort headers.
10130         * charset.c: Sort headers.
10131         * c-varobj.c: Sort headers.
10132         * c-valprint.c: Sort headers.
10133         * c-typeprint.c: Sort headers.
10134         * c-lang.c: Sort headers.
10135         * buildsym.c: Sort headers.
10136         * buildsym-legacy.c: Sort headers.
10137         * build-id.h: Sort headers.
10138         * build-id.c: Sort headers.
10139         * btrace.c: Sort headers.
10140         * bsd-uthread.c: Sort headers.
10141         * breakpoint.h: Sort headers.
10142         * breakpoint.c: Sort headers.
10143         * break-catch-throw.c: Sort headers.
10144         * break-catch-syscall.c: Sort headers.
10145         * break-catch-sig.c: Sort headers.
10146         * blockframe.c: Sort headers.
10147         * block.c: Sort headers.
10148         * bfin-tdep.c: Sort headers.
10149         * bfin-linux-tdep.c: Sort headers.
10150         * bfd-target.c: Sort headers.
10151         * bcache.c: Sort headers.
10152         * ax-general.c: Sort headers.
10153         * ax-gdb.h: Sort headers.
10154         * ax-gdb.c: Sort headers.
10155         * avr-tdep.c: Sort headers.
10156         * auxv.c: Sort headers.
10157         * auto-load.c: Sort headers.
10158         * arm-wince-tdep.c: Sort headers.
10159         * arm-tdep.c: Sort headers.
10160         * arm-symbian-tdep.c: Sort headers.
10161         * arm-pikeos-tdep.c: Sort headers.
10162         * arm-obsd-tdep.c: Sort headers.
10163         * arm-nbsd-tdep.c: Sort headers.
10164         * arm-nbsd-nat.c: Sort headers.
10165         * arm-linux-tdep.c: Sort headers.
10166         * arm-linux-nat.c: Sort headers.
10167         * arm-fbsd-tdep.c: Sort headers.
10168         * arm-fbsd-nat.c: Sort headers.
10169         * arm-bsd-tdep.c: Sort headers.
10170         * arch-utils.c: Sort headers.
10171         * arc-tdep.c: Sort headers.
10172         * arc-newlib-tdep.c: Sort headers.
10173         * annotate.h: Sort headers.
10174         * annotate.c: Sort headers.
10175         * amd64-windows-tdep.c: Sort headers.
10176         * amd64-windows-nat.c: Sort headers.
10177         * amd64-tdep.c: Sort headers.
10178         * amd64-sol2-tdep.c: Sort headers.
10179         * amd64-obsd-tdep.c: Sort headers.
10180         * amd64-obsd-nat.c: Sort headers.
10181         * amd64-nbsd-tdep.c: Sort headers.
10182         * amd64-nbsd-nat.c: Sort headers.
10183         * amd64-nat.c: Sort headers.
10184         * amd64-linux-tdep.c: Sort headers.
10185         * amd64-linux-nat.c: Sort headers.
10186         * amd64-fbsd-tdep.c: Sort headers.
10187         * amd64-fbsd-nat.c: Sort headers.
10188         * amd64-dicos-tdep.c: Sort headers.
10189         * amd64-darwin-tdep.c: Sort headers.
10190         * amd64-bsd-nat.c: Sort headers.
10191         * alpha-tdep.c: Sort headers.
10192         * alpha-obsd-tdep.c: Sort headers.
10193         * alpha-nbsd-tdep.c: Sort headers.
10194         * alpha-mdebug-tdep.c: Sort headers.
10195         * alpha-linux-tdep.c: Sort headers.
10196         * alpha-linux-nat.c: Sort headers.
10197         * alpha-bsd-tdep.c: Sort headers.
10198         * alpha-bsd-nat.c: Sort headers.
10199         * aix-thread.c: Sort headers.
10200         * agent.c: Sort headers.
10201         * addrmap.c: Sort headers.
10202         * ada-varobj.c: Sort headers.
10203         * ada-valprint.c: Sort headers.
10204         * ada-typeprint.c: Sort headers.
10205         * ada-tasks.c: Sort headers.
10206         * ada-lang.c: Sort headers.
10207         * aarch64-tdep.c: Sort headers.
10208         * aarch64-ravenscar-thread.c: Sort headers.
10209         * aarch64-newlib-tdep.c: Sort headers.
10210         * aarch64-linux-tdep.c: Sort headers.
10211         * aarch64-linux-nat.c: Sort headers.
10212         * aarch64-fbsd-tdep.c: Sort headers.
10213         * aarch64-fbsd-nat.c: Sort headers.
10214         * aarch32-linux-nat.c: Sort headers.
10215
10216 2019-04-04  Tom Tromey  <tom@tromey.com>
10217
10218         * varobj.c (varobj_create): Update.
10219         * rust-exp.y (struct rust_parser) <update_innermost_block,
10220         lookup_symbol>: New methods.
10221         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10222         Rename.
10223         (rust_parser::rust_lookup_type)
10224         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10225         * printcmd.c (display_command, do_one_display): Update.
10226         * parser-defs.h (struct parser_state) <parser_state>: Add
10227         "tracker" parameter.
10228         (block_tracker): New member.
10229         (class innermost_block_tracker) <innermost_block_tracker>: Add
10230         "types" parameter.
10231         <reset>: Remove method.
10232         (innermost_block): Don't declare.
10233         (null_post_parser): Update.
10234         * parse.c (innermost_block): Remove global.
10235         (write_dollar_variable): Update.
10236         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10237         Remove "tracker_types" parameter.
10238         (parse_expression): Add "tracker" parameter.
10239         (parse_expression_for_completion): Update.
10240         (null_post_parser): Add "tracker" parameter.
10241         * p-exp.y: Update rules.
10242         * m2-exp.y: Update rules.
10243         * language.h (struct language_defn) <la_post_parser>: Add
10244         "tracker" parameter.
10245         * go-exp.y: Update rules.
10246         * f-exp.y: Update rules.
10247         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10248         parameter.
10249         * d-exp.y: Update rules.
10250         * c-exp.y: Update rules.
10251         * breakpoint.c (set_breakpoint_condition): Create an
10252         innermost_block_tracker.
10253         (watch_command_1): Likewise.
10254         * ada-lang.c (resolve): Add "tracker" parameter.
10255         (resolve_subexp): Likewise.
10256         * ada-exp.y (write_var_from_sym): Update.
10257
10258 2019-04-04  Tom Tromey  <tom@tromey.com>
10259
10260         * type-stack.h: New file.
10261         * type-stack.c: New file.
10262         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10263         type-stack.h.
10264         (insert_into_type_stack, insert_type, push_type, push_type_int)
10265         (insert_type_address_space, pop_type, pop_type_int)
10266         (pop_typelist, pop_type_stack, append_type_stack)
10267         (push_type_stack, get_type_stack, push_typelist)
10268         (follow_type_instance_flags, follow_types): Don't declare.
10269         * parse.c (type_stack): Remove global.
10270         (parse_exp_in_context): Update.
10271         (insert_into_type_stack, insert_type, push_type, push_type_int)
10272         (insert_type_address_space, pop_type, pop_type_int)
10273         (pop_typelist, pop_type_stack, append_type_stack)
10274         (push_type_stack, get_type_stack, push_typelist)
10275         (follow_type_instance_flags, follow_types): Remove (moved to
10276         type-stack.c).
10277         * f-exp.y (type_stack): New global.
10278         Update rules.
10279         (push_kind_type, f_parse): Update.
10280         * d-exp.y (type_stack): New global.
10281         Update rules.
10282         (d_parse): Update.
10283         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10284         Update rules.
10285         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10286         (HFILES_NO_SRCDIR): Add type-stack.h.
10287
10288 2019-04-04  Tom Tromey  <tom@tromey.com>
10289
10290         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10291         (rust_parser::convert_ast_to_expression, rust_parse)
10292         (rust_lex_test_completion, rust_lex_tests): Update.
10293         * parser-defs.h (struct expr_completion_state): New.
10294         (struct parser_state) <parser_state>: Add completion parameter.
10295         <mark_struct_expression, mark_completion_tag>: New methods.
10296         <parse_completion, m_completion_state>: New members.
10297         (prefixify_expression, null_post_parser): Update.
10298         (mark_struct_expression, mark_completion_tag): Don't declare.
10299         * parse.c (parse_completion, expout_last_struct)
10300         (expout_tag_completion_type, expout_completion_name): Remove
10301         globals.
10302         (parser_state::mark_struct_expression)
10303         (parser_state::mark_completion_tag): Now methods.
10304         (prefixify_expression): Add last_struct parameter.
10305         (prefixify_subexp): Likewise.
10306         (parse_exp_1): Update.
10307         (parse_exp_in_context): Add cstate parameter.  Update.
10308         (parse_expression_for_completion): Create an
10309         expr_completion_state.
10310         (null_post_parser): Add "completion" parameter.
10311         * p-exp.y: Update rules.
10312         (yylex): Update.
10313         * language.h (struct language_defn) <la_post_parser>: Add
10314         "completing" parameter.
10315         * go-exp.y: Update rules.
10316         (lex_one_token): Update.
10317         * expression.h (parse_completion): Don't declare.
10318         * d-exp.y: Update rules.
10319         (lex_one_token): Update rules.
10320         * c-exp.y: Update rules.
10321         (lex_one_token): Update.
10322         * ada-lang.c (resolve): Add "parse_completion" parameter.
10323         (resolve_subexp): Likewise.
10324         (ada_resolve_function): Likewise.
10325
10326 2019-04-04  Tom Tromey  <tom@tromey.com>
10327
10328         * parser-defs.h (struct parser_state) <start_arglist,
10329         end_arglist>: New methods.
10330         <arglist_len, m_funcall_chain>: New members.
10331         (arglist_len, start_arglist, end_arglist): Don't declare.
10332         * parse.c (arglist_len, funcall_chain): Remove global.
10333         (start_arglist, end_arglist): Remove functions.
10334         (parse_exp_in_context): Update.
10335         * p-exp.y: Update rules.
10336         * m2-exp.y: Update rules.
10337         * go-exp.y: Update rules.
10338         * f-exp.y: Update rules.
10339         * d-exp.y: Update rules.
10340         * c-exp.y: Update rules.
10341
10342 2019-04-04  Tom Tromey  <tom@tromey.com>
10343
10344         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10345         lex_operator, push_back>: New methods.
10346         Update all rules.
10347         (rust_parser::lex_hex, lex_escape): Rename and update.
10348         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10349         (rust_parser::lex_operator): Rename and update.
10350         (rust_parser::lex_number, rustyylex, rustyyerror)
10351         (rust_lex_test_init, rust_lex_test_sequence)
10352         (rust_lex_test_push_back, rust_lex_tests): Update.
10353         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10354         parameter.
10355         <lexptr, prev_lexptr>: New members.
10356         (lexptr, prev_lexptr): Don't declare.
10357         * parse.c (lexptr, prev_lexptr): Remove globals.
10358         (parse_exp_in_context): Update.
10359         * p-exp.y (yylex, yyerror): Update.
10360         * m2-exp.y (parse_number, yylex, yyerror): Update.
10361         * go-exp.y (lex_one_token, yyerror): Update.
10362         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10363         * d-exp.y (lex_one_token, yyerror): Update.
10364         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10365         (lex_one_token, yyerror): Update.
10366         * ada-lex.l (YY_INPUT): Update.
10367         (rewind_to_char): Update.
10368         * ada-exp.y (yyerror): Update.
10369
10370 2019-04-04  Tom Tromey  <tom@tromey.com>
10371
10372         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10373         * parser-defs.h (struct parser_state) <parser_state>: Add new
10374         parameter.
10375         <comma_terminates>: New member.
10376         (comma_terminates): Don't declare global.
10377         * parse.c (comma_terminates): Remove global.
10378         (parse_exp_in_context): Update.
10379         * p-exp.y (yylex): Update.
10380         * m2-exp.y (yylex): Update.
10381         * go-exp.y (lex_one_token): Update.
10382         * f-exp.y (yylex): Update.
10383         * d-exp.y (lex_one_token): Update.
10384         * c-exp.y (lex_one_token): Update.
10385         * ada-lex.l: Update.
10386
10387 2019-04-04  Tom Tromey  <tom@tromey.com>
10388
10389         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10390         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10391         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10392         * parser-defs.h (paren_depth): Don't declare.
10393         * parse.c (paren_depth): Remove global.
10394         (parse_exp_in_context): Update.
10395         * p-exp.y (paren_depth): New global.
10396         (pascal_parse): Initialize it.
10397         * m2-exp.y (paren_depth): New global.
10398         (m2_parse): Initialize it.
10399         * go-exp.y (paren_depth): New global.
10400         (go_parse): Initialize it.
10401         * f-exp.y (paren_depth): New global.
10402         (f_parse): Initialize it.
10403         * d-exp.y (paren_depth): New global.
10404         (d_parse): Initialize it.
10405         * c-exp.y (paren_depth): New global.
10406         (c_parse): Initialize it.
10407         * ada-lex.l (paren_depth): New global.
10408         (lexer_init): Initialize it.
10409
10410 2019-04-04  Tom Tromey  <tom@tromey.com>
10411
10412         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10413         (rust_parser::convert_ast_to_type)
10414         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10415         * parser-defs.h (struct parser_state) <parser_state>: Add
10416         parameters.  Initialize new members.
10417         <expression_context_block, expression_context_pc>: New members.
10418         * parse.c (expression_context_block, expression_context_pc):
10419         Remove globals.
10420         (parse_exp_in_context): Update.
10421         * p-exp.y: Update all rules.
10422         (yylex): Update.
10423         * m2-exp.y: Update all rules.
10424         (yylex): Update.
10425         * go-exp.y (yylex): Update.
10426         * f-exp.y (yylex): Update.
10427         * d-exp.y: Update all rules.
10428         (yylex): Update.
10429         * c-exp.y: Update all rules.
10430         (lex_one_token, classify_name, yylex, c_parse): Update.
10431         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10432
10433 2019-04-04  Tom Tromey  <tom@tromey.com>
10434
10435         * gdbarch.h, gdbarch.c: Rebuild.
10436         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10437         * stap-probe.h:
10438         (struct stap_parse_info): Replace "parser_state" with
10439         "expr_builder".
10440         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10441         (parser_state): New class.
10442         * parse.c (expr_builder): Rename.
10443         (expr_builder::release): Rename.
10444         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10445         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10446         (write_exp_elt_longcst, write_exp_elt_floatcst)
10447         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10448         (write_exp_string_vector, write_exp_bitstring)
10449         (write_exp_msymbol, mark_struct_expression)
10450         (write_dollar_variable)
10451         (insert_type_address_space, increase_expout_size): Replace
10452         "parser_state" with "expr_builder".
10453         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10454         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10455         "parser_state" with "expr_builder".
10456
10457 2019-04-04  Tom Tromey  <tom@tromey.com>
10458
10459         * rust-exp.y: Replace "parse_language" with method call.
10460         * p-exp.y:
10461         (yylex): Replace "parse_language" with method call.
10462         * m2-exp.y:
10463         (yylex): Replace "parse_language" with method call.
10464         * go-exp.y (classify_name): Replace "parse_language" with method
10465         call.
10466         * f-exp.y (yylex): Replace "parse_language" with method call.
10467         * d-exp.y (lex_one_token): Replace "parse_language" with method
10468         call.
10469         * c-exp.y:
10470         (lex_one_token, classify_name, yylex): Replace "parse_language"
10471         with method call.
10472         * ada-exp.y (find_primitive_type, type_char)
10473         (type_system_address): Replace "parse_language" with method call.
10474
10475 2019-04-04  Tom Tromey  <tom@tromey.com>
10476
10477         * rust-exp.y: Replace "parse_gdbarch" with method call.
10478         * parse.c (write_dollar_variable, insert_type_address_space):
10479         Replace "parse_gdbarch" with method call.
10480         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10481         call.
10482         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10483         call.
10484         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10485         "parse_gdbarch" with method call.
10486         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10487         with method call.
10488         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10489         "parse_gdbarch" with method call.
10490         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10491         "parse_gdbarch" with method call.
10492         * c-exp.y (parse_type, parse_number, classify_name): Replace
10493         "parse_gdbarch" with method call.
10494         * ada-lex.l: Replace "parse_gdbarch" with method call.
10495         * ada-exp.y (parse_type, find_primitive_type, type_char)
10496         (type_system_address): Replace "parse_gdbarch" with method call.
10497
10498 2019-04-04  Tom Tromey  <tom@tromey.com>
10499
10500         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10501         * stap-probe.c (stap_parse_argument): Update.
10502         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10503         initial_size parameter.
10504         * rust-exp.y (rust_lex_tests): Update.
10505         * parse.c (parser_state): Update.
10506         (parse_exp_in_context): Update.
10507         * parser-defs.h (struct parser_state) <parser_state>: Remove
10508         "initial_size" parameter.
10509
10510 2019-04-04  Tom Tromey  <tom@tromey.com>
10511
10512         * parser-defs.h (increase_expout_size): Don't declare.
10513         * parse.c (increase_expout_size): Now static.
10514
10515 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10516
10517         * gnu-nat.c (gnu_nat_target::wait): Fix
10518         target_waitstatus_to_string call.
10519
10520 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10521
10522         * eval.c (evaluate_subexp_standard): Handle internal functions
10523         during Fortran function call handling.
10524
10525 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10526
10527         * NEWS: Mention new internal functions.
10528         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10529         (read_base_type): Use dwarf2_init_complex_target_type.
10530         * value.c (creal_internal_fn): New function.
10531         (cimag_internal_fn): New function.
10532         (_initialize_values): Register new internal functions.
10533
10534 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10535
10536         * infrun.c (stop_all_threads): If debug_infrun, always
10537         trace the wait status after wait_one, using
10538         target_waitstatus_to_string and target_pid_to_str.
10539         (handle_inferior_event): Replace various trace of
10540         wait status kind by a single trace.
10541         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10542         wait status kind image by target_waitstatus_to_string.
10543         * target/waitstatus.c (target_waitstatus_to_string): Fix
10544         obsolete comment.
10545
10546 2019-04-01  Tom Tromey  <tromey@adacore.com>
10547
10548         PR symtab/23331:
10549         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10550
10551 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10552             Pedro Alves  <palves@redhat.com>
10553
10554         * top.c (quit_force): Call 'finalize_values'.
10555         * value.c (finalize_values): New function.
10556         * value.h (finalize_values): Declare.
10557
10558 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10559
10560         * NEWS: Announce $_gdb_major and $_gdb_minor.
10561
10562         * top.c (init_gdb_version_vars): New function.
10563         (gdb_init): Call init_gdb_version_vars.
10564
10565 2019-03-29  Tom Tromey  <tromey@adacore.com>
10566
10567         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10568         help text.  Remove dead code.
10569
10570 2019-03-29  Keith Seitz  <keiths@redhat.com>
10571
10572         From Siddhesh Poyarekar:
10573         * f-lang.h (f77_get_upperbound): Return LONGEST.
10574         (f77_get_lowerbound): Likewise.
10575         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10576         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10577         print them.
10578         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10579         plongest to format print it.
10580         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10581         (f77_get_upperbound): Likewise.
10582         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10583         LOWER_BOUND to LONGEST.
10584         (f77_create_arrayprint_offset_tbl): Likewise.
10585
10586 2019-03-29  Keith Seitz  <keiths@redhat.com>
10587
10588         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10589         %s/pulongest for TYPE_LENGTH instead of %d in format
10590         strings.
10591         * ada-typerint.c (ada_print_type): Likewise.
10592         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10593         * compile/compile-c-support.c (generate_register_struct): Likewise.
10594         * gdbtypes.c (recursive_dump_type): Likewise.
10595         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10596         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10597         instead of %d in format strings.
10598         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10599         to std::min to ULONGEST.
10600         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10601         instead of %d in format strings.
10602         * tracepoint.c (info_scope_command): Likewise.
10603         * typeprint.c (print_offset_data::update)
10604         (print_offset_data::finish): Likewise.
10605         * xtensa-tdep.c (xtensa_store_return_value)
10606         (xtensa_push_dummy_call): Likewise.
10607
10608 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10609
10610         * windows-nat.c (display_selector): Fixed format specifications
10611         for 64-bit Cygwin.
10612
10613 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10614
10615         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10616
10617 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10618
10619         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10620         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10621         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10622         (nios2_linux_init_abi): Install it.
10623
10624 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10625
10626         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10627
10628 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10629
10630         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10631
10632 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10633             Tom Tromey  <tromey@adacore.com>
10634
10635         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10636
10637 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10638
10639         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10640         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10641         method to compute the bounds of range types. Also print "[evaluated]"
10642         if the bounds' values come from a dynamic evaluation.
10643
10644 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10645
10646         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10647         whitespace when pretty printing is on.
10648
10649 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10650
10651         * ppc-linux-nat.c: Add include.
10652
10653 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10654
10655         * NEWS: Mention AArch64 Pointer Authentication.
10656
10657 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10658
10659         * arm-linux-nat.c: Add include.
10660
10661 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10662
10663         * source-cache.c (source_cache::get_source_lines): Re-read
10664         fullname after calling open_source_file.
10665
10666 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10667
10668         * NEWS: Mention TLS support for FreeBSD.
10669
10670 2019-03-25  Tom Tromey  <tromey@adacore.com>
10671
10672         * minsyms.c (BUNCH_SIZE): Update comment.
10673         (~minimal_symbol_reader): Remove old comment.
10674         (compact_minimal_symbols): Update comment.
10675         (minimal_symbol_reader::install): Remove old comment.  Update
10676         other comments.
10677
10678 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10679
10680         * s390-linux-nat.c: Add include.
10681
10682 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10683
10684         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10685         Call linux_get_hwcap.
10686         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10687         Likewise.
10688         (aarch64_linux_get_hwcap): Remove function.
10689         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10690         declaration.
10691         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10692         linux_get_hwcap.
10693         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10694         * linux-tdep.c (linux_get_hwcap): Add function.
10695         (linux_get_hwcap2): Likewise.
10696         * linux-tdep.h (linux_get_hwcap): Add declaration.
10697         (linux_get_hwcap2): Likewise.
10698         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10699         (ppc_linux_get_hwcap2): Likewise.
10700         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10701         linux_get_hwcap.
10702         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10703         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10704         (ppc_linux_nat_target::read_description): Likewise.
10705         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10706         * s390-linux-nat.c: Likewise.
10707         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10708
10709 2019-03-24  Tom Tromey  <tom@tromey.com>
10710
10711         * ada-lang.c (standard_lookup): Simplify initialization.
10712         (ada_lookup_symbol_nonlocal): Simplify return.
10713         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10714         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10715         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10716         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10717         initialization.
10718         * solib.c (solib_global_lookup): Simplify.
10719         * symtab.c (null_block_symbol): Remove.
10720         (symbol_cache_lookup): Simplify returns.
10721         (lookup_language_this): Simplify returns.
10722         (lookup_symbol_aux): Simplify return.
10723         (lookup_local_symbol): Simplify returns.
10724         (lookup_global_symbol_from_objfile): Simplify return.
10725         (lookup_symbol_in_objfile_symtabs)
10726         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10727         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10728         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10729         * cp-namespace.c (cp_lookup_bare_symbol)
10730         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10731         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10732         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10733         (cp_lookup_symbol_via_imports): Simplify initialization.
10734         (find_symbol_in_baseclass): Likewise.
10735         * symtab.h (null_block_symbol): Remove.
10736         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10737         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10738         (d_lookup_symbol_module): Likewise.
10739         (find_symbol_in_baseclass): Simplify initialization.
10740
10741 2019-03-24  Tom Tromey  <tom@tromey.com>
10742
10743         * expression.h: Don't include symtab.h.
10744         (struct block): Forward declare.
10745
10746 2019-03-24  Tom Tromey  <tom@tromey.com>
10747
10748         * c-exp.y (typebase): Remove casts.
10749         * gdbtypes.c (lookup_unsigned_typename, )
10750         (lookup_signed_typename): Remove cast.
10751         * eval.c (parse_to_comma_and_eval): Remove cast.
10752         * parse.c (write_dollar_variable): Remove cast.
10753         * block.h (struct block) <superblock>: Now const.
10754         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10755         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10756         (map_block): Make "block" const.
10757         * symfile.h (struct quick_symbol_functions)
10758         <map_matching_symbols>: Constify block argument to "callback".
10759         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10760         const.
10761         (find_pc_sect_compunit_symtab): Make "b" const.
10762         (find_symbol_at_address): Likewise.
10763         (search_symbols): Likewise.
10764         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10765         (dw2_debug_names_lookup_symbol): Likewise.
10766         (dw2_map_matching_symbols): Update.
10767         * p-valprint.c (pascal_val_print): Remove "block".
10768         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10769         (aux_add_nonlocal_symbols): Make "block" const.
10770         (resolve_subexp): Remove cast.
10771         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10772         const.
10773         (iterate_over_file_blocks): Likewise.
10774         * f-exp.y (%union) <bval>: Remove.
10775         * coffread.c (patch_opaque_types): Make "b" const.
10776         * spu-tdep.c (spu_catch_start): Make "block" const.
10777         * c-valprint.c (print_unpacked_pointer): Remove "block".
10778         * symmisc.c (dump_symtab_1): Make "b" const.
10779         (block_depth): Make "block" const.
10780         * d-exp.y (%union) <bval>: Remove.
10781         * cp-support.h (cp_lookup_rtti_type): Update.
10782         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10783         * psymtab.c (psym_lookup_symbol): Make "block" const.
10784         (maintenance_check_psymtabs): Make "b" const.
10785         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10786         (enumerate_locals, enumerate_args): Update.
10787         * python/py-symtab.c (stpy_global_block): Make "block" const.
10788         (stpy_static_block): Likewise.
10789         * inline-frame.c (block_starting_point_at): Make "new_block"
10790         const.
10791         * block.c (find_block_in_blockvector): Make return type const.
10792         (blockvector_for_pc_sect): Make "b" const.
10793         (find_block_in_blockvector): Make "b" const.
10794
10795 2019-03-23  Tom Tromey  <tom@tromey.com>
10796
10797         * varobj.c (varobj_create): Update.
10798         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10799         * printcmd.c (display_command, do_one_display): Don't reset
10800         innermost_block.
10801         * parser-defs.h (enum innermost_block_tracker_type): Move to
10802         expression.h.
10803         (innermost_block): Update comment.
10804         * parse.c (parse_exp_1): Add tracker_types parameter.
10805         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10806         tracker_types parameter.  Reset innermost_block.
10807         (parse_exp_in_context): Remove.
10808         (parse_expression_for_completion): Update.
10809         * objfiles.c (~objfile): Don't reset expression_context_block or
10810         innermost_block.
10811         * expression.h (enum innermost_block_tracker_type): Move from
10812         parser-defs.h.
10813         (parse_exp_1): Add tracker_types parameter.
10814         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10815         reset innermost_block.
10816
10817 2019-03-23  Tom Tromey  <tom@tromey.com>
10818
10819         * objfiles.h: Include bcache.h.
10820
10821 2019-03-23  Tom Tromey  <tom@tromey.com>
10822
10823         * linespec.c (get_current_search_block): Use
10824         scoped_restore_current_language.
10825         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10826
10827 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10828             Jiong Wang  <jiong.wang@arm.com>
10829
10830         * aarch64-linux-tdep.c
10831         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10832         section.
10833         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10834
10835 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10836             Jiong Wang  <jiong.wang@arm.com>
10837
10838         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10839         instructions.
10840         (aarch64_analyze_prologue_test): Add PACIASP test.
10841         (aarch64_prologue_prev_register): Unmask PC value.
10842
10843 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10844             Jiong Wang  <jiong.wang@arm.com>
10845
10846         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10847         (aarch64_dwarf2_prev_register): Unmask PC value.
10848         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10849         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10850         DW_CFA_AARCH64_negate_ra_state.
10851         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10852
10853 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10854             Jiong Wang  <jiong.wang@arm.com>
10855
10856         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10857         registers.
10858         (aarch64_pseudo_register_name): Likewise.
10859         (aarch64_pseudo_register_type): Likewise.
10860         (aarch64_pseudo_register_reggroup_p): Likewise.
10861         (aarch64_gdbarch_init): Add pauth registers.
10862         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10863         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10864         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10865         (struct gdbarch_tdep): Add regnum for ra_state.
10866
10867 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10868             Jiong Wang  <jiong.wang@arm.com>
10869
10870         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10871
10872 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10873             Jiong Wang  <jiong.wang@arm.com>
10874
10875         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10876         function.
10877         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10878         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10879         (aarch64_gdbarch_init): Add puth registers.
10880         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10881         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10882         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10883
10884 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10885             Jiong Wang  <jiong.wang@arm.com>
10886
10887         * aarch64-linux-nat.c
10888         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10889         * aarch64-linux-tdep.c
10890         (aarch64_linux_core_read_description): Likewise.
10891         (aarch64_linux_get_hwcap): New function.
10892         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10893         (aarch64_linux_get_hwcap): New declaration.
10894
10895 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10896             Jiong Wang  <jiong.wang@arm.com>
10897
10898         * aarch64-linux-nat.c
10899         (aarch64_linux_nat_target::read_description): Add pauth param.
10900         * aarch64-linux-tdep.c
10901         (aarch64_linux_core_read_description): Likewise.
10902         * aarch64-tdep.c (struct target_desc): Add in pauth.
10903         (aarch64_read_description): Add pauth param.
10904         (aarch64_gdbarch_init): Likewise.
10905         * aarch64-tdep.h (aarch64_read_description): Likewise.
10906         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10907         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10908         * features/Makefile: Add new files.
10909         * features/aarch64-pauth.c: New file.
10910         * features/aarch64-pauth.xml: New file.
10911
10912 2019-03-20  Tom Tromey  <tromey@adacore.com>
10913
10914         * infrun.c (handle_inferior_event): Rename from
10915         handle_inferior_event_1.  Create a scoped_value_mark.
10916         (handle_inferior_event): Remove.
10917
10918 2019-03-19  Tom Tromey  <tromey@adacore.com>
10919
10920         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10921         * infrun.h (print_stop_event): Add "displays" parameter.
10922         * infrun.c (print_stop_event): Add "displays" parameter.
10923
10924 2019-03-19  Pedro Alves  <palves@redhat.com>
10925
10926         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10927         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10928         to -1.  Fix TABs vs spaces.
10929         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10930         * tui/tui-out.h (tui_ui_out) Add intro comments.
10931         <m_line, m_start_of_line>: In-class initialize, and add describing
10932         comment.
10933
10934 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10935
10936         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10937         variable names.
10938         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10939
10940 2019-03-18  Pedro Alves  <palves@redhat.com>
10941             Eli Zaretskii <eliz@gnu.org>
10942
10943         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10944         m_line and m_start_of_line.
10945
10946 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10947
10948         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10949         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10950         it returns a newline.  This fixes a regression in TU mode, whereby
10951         the next line is output on the same screen line as the user input.
10952
10953 2019-03-18  Tom Tromey  <tromey@adacore.com>
10954
10955         * minsyms.c (minimal_symbol_reader::install): Remove call to
10956         obstack_blank.
10957
10958 2019-03-18  Pedro Alves  <palves@redhat.com>
10959
10960         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10961         New globals.
10962         (apply_style): New, factored out from ...
10963         (apply_ansi_escape): ... this.  Handle reverse video mode.
10964         (tui_set_reverse_mode): New function.
10965         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10966         * tui/tui-winsource.c (tui_show_source_line): Use
10967         tui_set_reverse_mode instead of setting A_STANDOUT.
10968         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10969         New setter methods.
10970
10971 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10972
10973         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10974         Handle tabs.
10975
10976 2019-03-18  Tom Tromey  <tromey@adacore.com>
10977
10978         * ada-lang.c (empty_array): Add "high" parameter.
10979         (ada_evaluate_subexp): Update.
10980
10981 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10982
10983         * unittests/string_view-selftests.c: Define
10984         _initialize_string_view_selftests unconditionally.
10985
10986 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10987
10988         PR gdb/24350
10989         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10990
10991 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10992
10993         PR gdb/24351
10994         * windows-nat.c (display_selector): Fix format specifiers.
10995
10996 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10997
10998         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10999         tui_refill_source_window instead of tui_refresh_win, to update the
11000         current execution line.  This fixes redisplay of the current line
11001         when stepping through the code with "next" or "step".
11002
11003 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11004
11005         * source-cache.c (source_cache::get_source_lines): Call
11006         find_source_lines to initialize s->nlines.  This fixes vertical
11007         scrolling of TUI source window when the DOWN arrow is pressed.
11008
11009 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11010
11011         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11012         linux-thread-db.c (_initialize_thread_db): Likewise.
11013
11014 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11015
11016         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11017         wclrtoeol in tui_show_source_line".  This reverts changes made in
11018         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11019
11020 2019-03-15  Tom Tromey  <tom@tromey.com>
11021
11022         * symtab.h (struct minimal_symbol): Derive from
11023         general_symbol_info.
11024         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11025         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11026         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11027         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11028         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11029         (MSYMBOL_SEARCH_NAME): Update.
11030         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11031         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11032         * minsyms.c (minimal_symbol_reader::record_full): Update.
11033
11034 2019-03-15  Tom Tromey  <tom@tromey.com>
11035
11036         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11037
11038 2019-03-15  Tom Tromey  <tom@tromey.com>
11039
11040         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11041         unique_xmalloc_ptr.
11042         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11043         Update.
11044         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11045         (build_minimal_symbol_hash_tables)
11046         (minimal_symbol_reader::install): Update.
11047
11048 2019-03-15  Tom Tromey  <tom@tromey.com>
11049
11050         * symtab.c (create_demangled_names_hash): Update.
11051         (symbol_set_names): Update.
11052         * objfiles.h (struct objfile_per_bfd_storage)
11053         <demangled_names_hash>: Now an htab_up.
11054         * objfiles.c (objfile_per_bfd_storage): Simplify.
11055
11056 2019-03-15  Tom Tromey  <tom@tromey.com>
11057
11058         * objfiles.h (struct objfile_per_bfd_storage): Declare
11059         destructor.
11060         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11061         New.
11062         (get_objfile_bfd_data): Use new.  Don't initialize
11063         language_of_main.
11064         (free_objfile_per_bfd_storage): Remove.
11065         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11066
11067 2019-03-15  Tom Tromey  <tom@tromey.com>
11068
11069         * symfile.c (reread_symbols): Update.
11070         * objfiles.c (objfile::objfile): Update.
11071         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11072         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11073         comment.
11074         (minimal_symbol_reader::install): Update.
11075         (terminate_minimal_symbol_table): Remove.
11076         * jit.c (jit_object_close_impl): Update.
11077
11078 2019-03-15  Tom Tromey  <tom@tromey.com>
11079
11080         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11081         initializations.
11082
11083 2019-03-15  Tom Tromey  <tom@tromey.com>
11084
11085         * objfiles.h (struct objfile_per_bfd_storage)
11086         <demangled_hash_languages>: Now a bitset.
11087         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11088         (lookup_minimal_symbol): Update.
11089
11090 2019-03-15  Tom Tromey  <tom@tromey.com>
11091
11092         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11093         Don't return the symbol.
11094         * coffread.c (record_minimal_symbol): Use record_full.
11095
11096 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11097
11098         The MS-Windows port of ncurses fails to switch to a color pair if
11099         one or both of the colors are the implicit default colors.  This
11100         change records the default colors when TUI is initialized, and
11101         then specifies them explicitly when a color pair uses the default
11102         colors.  This allows color styling in TUI mode on MS-Windows.
11103
11104         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11105         ncurses_norm_attr.
11106         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11107         colors in ncurses_norm_attr.
11108         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11109         "none", replace it with the default color recorded in
11110         ncurses_norm_attr.
11111
11112 2019-03-14  Tom Tromey  <tromey@adacore.com>
11113
11114         * source-cache.h (class source_cache) <get_source_lines>: Return
11115         std::string.
11116         * source-cache.c (source_cache::extract_lines): Handle case where
11117         first_pos==npos.  Return std::string.
11118         (source_cache::get_source_lines): Update.
11119
11120 2019-03-14  Tom Tromey  <tromey@adacore.com>
11121
11122         * NEWS: Add item for "style sources" commands.
11123         * source-cache.c (source_cache::get_source_lines): Check
11124         source_styling.
11125         * cli/cli-style.c (source_styling): New global.
11126         (_initialize_cli_style): Add "style sources" commands.
11127         (show_style_sources): New function.
11128         * cli/cli-style.h (source_styling): Declare.
11129
11130 2019-03-14  Pedro Alves  <palves@redhat.com>
11131             Tom Tromey  <tromey@adacore.com>
11132
11133         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11134         * tui/tui-winsource.c (tui_refill_source_window): New function,
11135         from...
11136         (tui_horizontal_source_scroll): ... here.  Move some logic.
11137         * cli/cli-style.c (set_style_enabled): Notify new observable.
11138         * tui/tui-hooks.c (tui_redisplay_source): New function.
11139         (tui_attach_detach_observers): Attach or detach
11140         tui_redisplay_source.
11141         * observable.h (source_styling_changed): New observable.
11142         * observable.c: Define source_styling_changed observable.
11143
11144 2019-03-13  Tom Tromey  <tromey@adacore.com>
11145
11146         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11147         (i386_gnu_nat_target::store_registers): Update.
11148         * target-debug.h (target_debug_print_std_string): New macro.
11149         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11150         * windows-tdep.c (display_one_tib): Update.
11151         * tui/tui-stack.c (tui_make_status_line): Update.
11152         * top.c (print_inferior_quit_action): Update.
11153         * thread.c (thr_try_catch_cmd): Update.
11154         (add_thread_with_info): Update.
11155         (thread_target_id_str): Update.
11156         (thr_try_catch_cmd): Update.
11157         (thread_command): Update.
11158         (thread_find_command): Update.
11159         * record-btrace.c (record_btrace_target::info_record)
11160         (record_btrace_resume_thread, record_btrace_target::resume)
11161         (record_btrace_cancel_resume, record_btrace_step_thread)
11162         (record_btrace_target::wait, record_btrace_target::wait)
11163         (record_btrace_target::wait, record_btrace_target::stop): Update.
11164         * progspace.c (print_program_space): Update.
11165         * process-stratum-target.c
11166         (process_stratum_target::thread_address_space): Update.
11167         * linux-fork.c (linux_fork_mourn_inferior)
11168         (detach_checkpoint_command, info_checkpoints_command)
11169         (linux_fork_context): Update.
11170         (linux_fork_detach): Update.
11171         (class scoped_switch_fork_info): Update.
11172         (delete_checkpoint_command): Update.
11173         * infrun.c (follow_fork_inferior): Update.
11174         (follow_fork_inferior): Update.
11175         (proceed_after_vfork_done): Update.
11176         (handle_vfork_child_exec_or_exit): Update.
11177         (follow_exec): Update.
11178         (displaced_step_prepare_throw): Update.
11179         (displaced_step_restore): Update.
11180         (start_step_over): Update.
11181         (resume_1): Update.
11182         (clear_proceed_status_thread): Update.
11183         (proceed): Update.
11184         (print_target_wait_results): Update.
11185         (do_target_wait): Update.
11186         (context_switch): Update.
11187         (stop_all_threads): Update.
11188         (restart_threads): Update.
11189         (finish_step_over): Update.
11190         (handle_signal_stop): Update.
11191         (switch_back_to_stepped_thread): Update.
11192         (keep_going_pass_signal): Update.
11193         (print_exited_reason): Update.
11194         (normal_stop): Update.
11195         * inferior.c (inferior_pid_to_str): Change return type.
11196         (print_selected_inferior): Update.
11197         (add_inferior): Update.
11198         (detach_inferior): Update.
11199         * dummy-frame.c (fprint_dummy_frames): Update.
11200         * dcache.c (dcache_info_1): Update.
11201         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11202         (btrace_fetch, btrace_clear): Update.
11203         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11204         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11205         type.
11206         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11207         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11208         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11209         * gdbarch.c, gdbarch.h: Rebuild.
11210         * gdbarch.sh (core_pid_to_str): Change return type.
11211         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11212         return type.
11213         (windows_nat_target::pid_to_str): Change return type.
11214         (windows_delete_thread): Update.
11215         (windows_nat_target::attach): Update.
11216         (windows_nat_target::files_info): Update.
11217         * target-delegates.c: Rebuild.
11218         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11219         return type.
11220         (sol_thread_target::pid_to_str): Change return type.
11221         * remote.c (class remote_target) <pid_to_str>: Change return
11222         type.
11223         (remote_target::pid_to_str): Change return type.
11224         (extended_remote_target::attach, remote_target::remote_stop_ns)
11225         (remote_target::remote_notif_remove_queued_reply)
11226         (remote_target::push_stop_reply, remote_target::disable_btrace):
11227         Update.
11228         (extended_remote_target::attach): Update.
11229         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11230         type.
11231         (gdbsim_target::pid_to_str): Change return type.
11232         * ravenscar-thread.c (struct ravenscar_thread_target)
11233         <pid_to_str>: Change return type.
11234         (ravenscar_thread_target::pid_to_str): Change return type.
11235         * procfs.c (class procfs_target) <pid_to_str>: Change return
11236         type.
11237         (procfs_target::pid_to_str): Change return type.
11238         (procfs_target::attach): Update.
11239         (procfs_target::detach): Update.
11240         (procfs_target::fetch_registers): Update.
11241         (procfs_target::store_registers): Update.
11242         (procfs_target::wait): Update.
11243         (procfs_target::files_info): Update.
11244         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11245         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11246         return type.
11247         (nto_procfs_target::pid_to_str): Change return type.
11248         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11249         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11250         return type.
11251         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11252         (exit_lwp): Update.
11253         (attach_proc_task_lwp_callback, get_detach_signal)
11254         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11255         (linux_nat_target::resume, wait_lwp, stop_callback)
11256         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11257         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11258         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11259         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11260         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11261         type.
11262         (inf_ptrace_target::attach): Update.
11263         (inf_ptrace_target::files_info): Update.
11264         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11265         type.
11266         (go32_nat_target::pid_to_str): Change return type.
11267         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11268         (gnu_nat_target::wait): Update.
11269         (gnu_nat_target::wait): Update.
11270         (gnu_nat_target::resume): Update.
11271         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11272         (fbsd_nat_target::wait): Update.
11273         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11274         type.
11275         (darwin_nat_target::attach): Update.
11276         * corelow.c (class core_target) <pid_to_str>: Change return type.
11277         (core_target::pid_to_str): Change return type.
11278         * target.c (normal_pid_to_str): Change return type.
11279         (default_pid_to_str): Likewise.
11280         (target_pid_to_str): Change return type.
11281         (target_translate_tls_address): Update.
11282         (target_announce_detach): Update.
11283         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11284         return type.
11285         (bsd_uthread_target::pid_to_str): Change return type.
11286         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11287         type.
11288         (bsd_kvm_target::pid_to_str): Change return type.
11289         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11290         return type.
11291         (aix_thread_target::pid_to_str): Change return type.
11292         * target.h (struct target_ops) <pid_to_str>: Change return type.
11293         (target_pid_to_str, normal_pid_to_str): Likewise.
11294         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11295         type.
11296         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11297         type.
11298         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11299         return type.
11300         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11301         type.
11302         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11303         type.
11304         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11305         return type.
11306
11307 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11308
11309         * NEWS: Mention that the new default MI version is 3.  Mention
11310         changes to the output of commands and events that deal with
11311         multi-location breakpoints.
11312         * breakpoint.c: Include "mi/mi-out.h".
11313         (print_one_breakpoint): Change output syntax if using MI version
11314         >= 3.
11315         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11316         New.
11317         (mi_multi_location_breakpoint_output_fixed): New.
11318         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11319         (mi_cmd_fix_multi_location_breakpoint_output): New.
11320         (mi_multi_location_breakpoint_output_fixed): New.
11321         * mi/mi-cmds.c (mi_cmds): Register command
11322         -fix-multi-location-breakpoint-output.
11323         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11324         interpreter "mi".
11325
11326 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11327
11328         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11329         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11330         instantiate mi_ui_out based on interpreter name.
11331         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11332         * mi/mi-main.c (mi_load_progress): Likewise.
11333
11334 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11335
11336         * NEWS: Combine separate "New targets" sections for 8.3.
11337
11338 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11339
11340         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11341         (ppcfbsd_init_abi): Install gdbarch
11342         "fetch_tls_load_module_address" and "get_thread_local_address"
11343         methods.
11344
11345 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11346
11347         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11348         (riscv_fbsd_init_abi): Install gdbarch
11349         "fetch_tls_load_module_address" and "get_thread_local_address"
11350         methods.
11351
11352 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11353
11354         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11355         (i386fbsd_init_abi): Install gdbarch
11356         "fetch_tls_load_module_address" and "get_thread_local_address"
11357         methods.
11358
11359 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11360
11361         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11362         (amd64fbsd_init_abi): Install gdbarch
11363         "fetch_tls_load_module_address" and "get_thread_local_address"
11364         methods.
11365
11366 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11367
11368         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11369         (struct fbsd_pspace_data): New type.
11370         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11371         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11372         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11373         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11374         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11375
11376 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11377
11378         * gdbtypes.c (lookup_struct_elt): New function.
11379         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11380         * gdbtypes.h (struct struct_elt): New type.
11381         (lookup_struct_elt): New prototype.
11382
11383 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11384
11385         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11386         remove disabled code block.
11387
11388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11389
11390         * gdbarch.sh (get_thread_local_address): New method.
11391         * gdbarch.h, gdbarch.c: Regenerate.
11392         * target.c (target_translate_tls_address): Use
11393         gdbarch_get_thread_local_address if present instead of
11394         target::get_thread_local_address.
11395
11396 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11397
11398         * target.h (target::get_thread_local_address): Update comment.
11399
11400 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11401
11402         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11403         objfile->separate_debug_objfile_backlink if not NULL.
11404
11405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11406
11407         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11408         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11409         (amd64bsd_store_inferior_registers): Likewise.
11410         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11411         Enable segment base registers.
11412         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11413         PT_GETFSBASE and PT_GETGSBASE.
11414         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11415         PT_SETGSBASE.
11416         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11417         segment base registers.
11418         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11419
11420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11421
11422         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11423         Update calls to i386_target_description to add 'segments'
11424         parameter.
11425         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11426         add segment base registers.
11427         * arch/i386.c (i386_create_target_description): Add 'segments'
11428         parameter to enable segment base registers.
11429         * arch/i386.h (i386_create_target_description): Likewise.
11430         * features/i386/32bit-segments.xml: New file.
11431         * features/i386/32bit-segments.c: Generate.
11432         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11433         call to i386_target_description to add 'segments' parameter.
11434         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11435         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11436         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11437         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11438         if feature is present.
11439         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11440         Add 'segments' parameter to call to i386_target_description.
11441         (i386_target_description): Add 'segments' parameter to enable
11442         segment base registers.
11443         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11444         to call to i386_target_description.
11445         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11446         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11447         Define I386_NUM_REGS.
11448         (i386_target_description): Add 'segments' parameter to enable
11449         segment base registers.
11450
11451 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11452
11453         PR/24325
11454         * source-cache.c: #undef open and close, to avoid unresolved
11455         externals during linking.
11456
11457 2019-03-12  Tom Tromey  <tromey@adacore.com>
11458
11459         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11460         const.  Add initializers.
11461         (_initialize_remote): Don't initialize ptid globals.
11462
11463 2019-03-12  Pedro Alves  <palves@redhat.com>
11464
11465         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11466
11467 2019-03-12  Pedro Alves  <palves@redhat.com>
11468
11469         * cp-name-parser.y (main): Remove unused 'len' variable.
11470
11471 2019-03-12  Tom Tromey  <tromey@adacore.com>
11472
11473         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11474         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11475
11476 2019-03-12  Tom Tromey  <tromey@adacore.com>
11477
11478         * linux-nat.c (iterate_over_lwps): Update.
11479         (stop_callback): Remove parameter.
11480         (stop_wait_callback, detach_callback, resume_set_callback)
11481         (select_singlestep_lwp_callback, set_ignore_sigint)
11482         (status_callback, resumed_callback, resume_clear_callback)
11483         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11484         data parameter.
11485         (linux_nat_target::detach, linux_nat_target::resume)
11486         (linux_stop_and_wait_all_lwps, select_event_lwp)
11487         (linux_nat_filter_event, linux_nat_wait_1)
11488         (linux_nat_target::kill, linux_nat_target::stop)
11489         (linux_nat_target::stop): Update.
11490         (linux_nat_resume_callback): Change type.
11491         (resume_stopped_resumed_lwps, count_events_callback)
11492         (select_event_lwp_callback): Likewise.
11493         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11494         * arm-linux-nat.c (struct update_registers_data): Remove.
11495         (update_registers_callback): Change type.
11496         (arm_linux_insert_hw_breakpoint1): Update.
11497         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11498         parameter.
11499         (x86_linux_dr_set_addr): Update.
11500         (x86_linux_dr_set_control): Update.
11501         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11502         (iterate_over_lwps): Use gdb::function_view.
11503         * nat/aarch64-linux-hw-point.c (struct
11504         aarch64_dr_update_callback_param): Remove.
11505         (debug_reg_change_callback): Change type.
11506         (aarch64_notify_debug_reg_change): Update.
11507         * s390-linux-nat.c (s390_refresh_per_info): Update.
11508
11509 2019-03-11  Tom Tromey  <tromey@adacore.com>
11510
11511         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11512         redundant assignment to "this_cu".
11513
11514 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11515
11516         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11517
11518 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11519
11520         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11521         from...
11522         (rank_one_type): ... this.
11523
11524 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11525
11526         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11527         from...
11528         (rank_one_type): ... this.
11529
11530 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11531
11532         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11533         from...
11534         (rank_one_type): ... this.
11535
11536 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11537
11538         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11539         from...
11540         (rank_one_type): ... this.
11541
11542 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11543
11544         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11545         from...
11546         (rank_one_type): ... this.
11547
11548 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11549
11550         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11551         from...
11552         (rank_one_type): ... this.
11553
11554 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11555
11556         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11557         from...
11558         (rank_one_type): ... this.
11559
11560 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11561
11562         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11563         from...
11564         (rank_one_type): ... this.
11565
11566 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11567
11568         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11569         from...
11570         (rank_one_type): ... this.
11571
11572 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11573
11574         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11575         from...
11576         (rank_one_type): ... this.
11577
11578 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11579
11580         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11581         from...
11582         (rank_one_type): ... this.
11583
11584 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11585
11586         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11587         from...
11588         (rank_one_type): ... this.
11589
11590 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11591
11592         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11593         inferior-events' shows the example events.
11594
11595 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11596
11597         Support styling on native MS-Windows console
11598
11599         PR/24315
11600         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11601         on MS-Windows if $TERM is not defined.
11602
11603         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11604
11605         * posix-hdep.c (gdb_console_fputs):
11606         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11607         functions.
11608         * ui-file.h (gdb_console_fputs): Add prototype.
11609
11610         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11611         back to fputs only if the former returns zero.
11612
11613 2019-03-07  Tom Tromey  <tom@tromey.com>
11614
11615         * symmisc.c (print_symbol_bcache_statistics): Update.
11616         (print_objfile_statistics): Update.
11617         * symfile.c (allocate_symtab): Update.
11618         * stabsread.c: Don't include bcache.h.
11619         * psymtab.h (struct psymbol_bcache): Don't declare.
11620         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11621         (psymbol_bcache_init, psymbol_bcache_free)
11622         (psymbol_bcache_get_bcache): Don't declare.
11623         * psymtab.c (struct psymbol_bcache): Remove.
11624         (psymtab_storage::psymtab_storage): Update.
11625         (psymtab_storage::~psymtab_storage): Update.
11626         (psymbol_bcache_init, psymbol_bcache_free)
11627         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11628         (add_psymbol_to_bcache): Update.
11629         (allocate_psymtab): Update.
11630         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11631         macro_cache>: No longer pointers.
11632         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11633         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11634         * macrotab.c (macro_bcache): Update.
11635         * macroexp.c: Don't include bcache.h.
11636         * gdbtypes.c (check_types_worklist): Update.
11637         (types_deeply_equal): Remove TRY/CATCH.  Update.
11638         * elfread.c (elf_symtab_read): Update.
11639         * dwarf2read.c: Don't include bcache.h.
11640         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11641         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11642         (print_bcache_statistics, bcache_memory_used): Don't declare.
11643         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11644         methods.  Rename all data members.
11645         * bcache.c (struct bcache): Move to bcache.h.
11646         (bcache::expand_hash_table): Rename from expand_hash_table.
11647         (bcache): Remove.
11648         (bcache::insert): Rename from bcache_full.
11649         (bcache::compare): Rename from bcache_compare.
11650         (bcache_xmalloc): Remove.
11651         (bcache::~bcache): Rename from bcache_xfree.
11652         (bcache::print_statistics): Rename from print_bcache_statistics.
11653         (bcache::memory_used): Rename from bcache_memory_used.
11654
11655 2019-03-07  Pedro Alves  <palves@redhat.com>
11656
11657         * infrun.c (normal_stop): Also check for
11658         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11659
11660 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11661
11662         * f-lang.c (value_from_host_double): Moved to...
11663         * value.c (value_from_host_double): ...here.
11664         * value.h (value_from_host_double): Declare.
11665         * guile/scm-math.c (vlscm_convert_typed_number): Use
11666         value_from_host_double.
11667         (vlscm_convert_number): Likewise.
11668         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11669         * python/py-value.c (convert_value_from_python): Likewise.
11670
11671 2019-03-06  Tom Tromey  <tom@tromey.com>
11672
11673         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11674
11675 2019-03-06  Tom Tromey  <tom@tromey.com>
11676
11677         * utils.h (free_current_contents): Don't declare.
11678         * utils.c (free_current_contents): Remove.
11679
11680 2019-03-06  Tom Tromey  <tom@tromey.com>
11681
11682         * top.c (quit_force): Update.
11683         * main.c (captured_command_loop): Update.
11684         * common/new-op.c (operator new): Update.
11685         * common/common-exceptions.c (struct catcher)
11686         <save_cleanup_chain>: Remove member.
11687         (exceptions_state_mc_init): Update.
11688         (exception_try_scope_entry): Return nullptr.
11689         (exception_try_scope_exit, exception_rethrow)
11690         (throw_exception_sjlj, throw_exception_cxx): Update.
11691         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11692         (all_cleanups, do_cleanups, discard_cleanups)
11693         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11694         (restore_cleanups, restore_final_cleanups): Don't declare.
11695         (do_final_cleanups): Remove parameter.
11696         * common/cleanups.c (cleanup_chain, make_cleanup)
11697         (make_cleanup_dtor, all_cleanups, do_cleanups)
11698         (discard_my_cleanups, discard_cleanups)
11699         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11700         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11701         (null_cleanup): Remove.
11702         (do_final_cleanups): Remove parameter.
11703
11704 2019-03-06  Tom Tromey  <tom@tromey.com>
11705
11706         * remote.c (remote_target::remote_parse_stop_reply): Use
11707         unique_xmalloc_ptr.
11708
11709 2019-03-06  Tom Tromey  <tom@tromey.com>
11710
11711         * stabsread.c (struct stabs_field_info): Rename from field_info.
11712         <list, fnlist>: Add initializers.
11713         <obstack>: New member.
11714         (read_member_functions, read_struct_fields, read_baseclasses):
11715         Allocate on obstack.  Don't use cleanups.
11716         (read_one_struct_field, read_member_functions, read_struct_fields)
11717         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11718         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11719         (read_struct_type): Update.
11720
11721 2019-03-06  Tom Tromey  <tom@tromey.com>
11722
11723         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11724         * common/filestuff.h (make_cleanup_close): Don't declare.
11725         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11726         Remove.
11727
11728 2019-03-06  Tom Tromey  <tom@tromey.com>
11729
11730         * solib-aix.c: Use make_scope_exit.
11731
11732 2019-03-06  Tom Tromey  <tom@tromey.com>
11733
11734         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11735         Use make_scope_exit.
11736
11737 2019-03-06  Tom Tromey  <tom@tromey.com>
11738
11739         * solib-svr4.c (disable_probes_interface): Remove parameter.
11740         (svr4_handle_solib_event): Use make_scope_exit.
11741
11742 2019-03-06  Tom Tromey  <tom@tromey.com>
11743
11744         * remote.c (struct stop_reply_deleter): Remove.
11745         (stop_reply_up): Update.
11746         (struct stop_reply): Derive from notif_event.  Don't typedef.
11747         <regcache>: Now a std::vector.
11748         (stop_reply_xfree): Remove.
11749         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11750         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11751         (remote_target::discard_pending_stop_replies): Use delete.
11752         (remote_target::remote_parse_stop_reply): Update.
11753         (remote_target::process_stop_reply): Update.
11754         * remote-notif.h (struct notif_event): Add virtual destructor.
11755         Remove "dtr" member.
11756         (struct notif_client) <alloc_event>: Return a unique_ptr.
11757         (notif_event_xfree): Don't declare.
11758         (notif_event_up): New typedef.
11759         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11760         (notif_event_xfree, do_notif_event_xfree): Remove.
11761         (remote_notif_state_xfree): Update.
11762
11763 2019-03-06  Tom Tromey  <tom@tromey.com>
11764
11765         * infrun.c (displaced_step_clear_cleanup): Now a
11766         forward_scope_exit type.
11767         (displaced_step_prepare_throw): Update.
11768         (displaced_step_fixup): Update.
11769
11770 2019-03-06  Tom Tromey  <tom@tromey.com>
11771
11772         * inferior.h (class inferior): Update comment.
11773         * gdbthread.h (class thread_info): Update comment.
11774
11775 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11776             Tom Tromey  <tom@tromey.com>
11777
11778         * stabsread.h (struct stab_section_list): Remove.
11779         (coffstab_build_psymtabs): Update.
11780         * dbxread.c (symbuf_sections): Now a std::vector.
11781         (sect_idx): New global.
11782         (fill_symbuf): Update.
11783         (coffstab_build_psymtabs): Change type of stabsects parameter.
11784         Update.
11785         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11786         std::vector.
11787         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11788         (coff_locate_sections): Update.
11789         (coff_symfile_read): Remove cleanups.  Update.
11790         (init_stringtab): Add storage parameter.
11791         (free_stringtab, free_stringtab_cleanup): Remove.
11792         (init_lineno): Add storage parameter.
11793         (free_linetab, free_linetab_cleanup): Remove.
11794
11795 2019-03-06  Pedro Alves  <palves@redhat.com>
11796
11797         * linux-fork.c (fork_info::clobber_regs): Delete.
11798         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11799         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11800         comment.  Adjust.
11801         (scoped_switch_fork_info::scoped_switch_fork_info)
11802         (checkpoint_command, linux_fork_context): Adjust
11803         fork_save_infrun_state calls.
11804
11805 2019-03-06  Pedro Alves  <palves@redhat.com>
11806
11807         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11808         (inf_has_multiple_threads): Return 'bool' and rewrite using
11809         inferior_info::threads().
11810
11811 2019-03-06  Pedro Alves  <palves@redhat.com>
11812
11813         * linux-fork.c: Include <list>.
11814         (fork_list): Now a std::list instance.
11815         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11816         (forks_exist_p, find_last_fork): Adjust.
11817         (new_fork): Delete.
11818         (one_fork_p): New.
11819         (add_fork): Adjust.
11820         (free_fork): Delete, folded into fork_info::~fork_info().
11821         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11822         Adjust.
11823         (init_fork_list): Delete.
11824         (linux_fork_killall, linux_fork_mourn_inferior)
11825         (linux_fork_detach, info_checkpoints_command): Adjust.
11826         (_initialize_linux_fork): No longer call init_fork_list.
11827
11828 2019-03-06  Pedro Alves  <palves@redhat.com>
11829
11830         * linux-fork.c (new_fork): New, split out of ...
11831         (add_fork): ... this.  Return void.  Move "first fork" special
11832         case from here, to ...
11833         (checkpoint_command): ... here.
11834         * linux-linux.h (add_fork): Return void.
11835
11836 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11837
11838         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11839
11840 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11841             Chris January  <chris.january@arm.com>
11842             David Lecomber  <david.lecomber@arm.com>
11843
11844         * f-exp.y: New token, UNOP_INTRINSIC.
11845         (exp): New pattern using UNOP_INTRINSIC token.
11846         (f77_keywords): Add 'abs' keyword.
11847         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11848         (value_from_host_double): New function.
11849         (evaluate_subexp_f): Support UNOP_ABS.
11850
11851 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11852
11853         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11854         types.
11855
11856 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11857
11858         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11859         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11860         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11861
11862 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11863
11864         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11865
11866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11867             Chris January  <chris.january@arm.com>
11868
11869         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11870         * f-exp.y: Define 'KIND' token.
11871         (exp): New pattern for KIND expressions.
11872         (ptype): Handle types with a kind extension.
11873         (direct_abs_decl): Extend to spot kind extensions.
11874         (f77_keywords): Add 'kind' to the list.
11875         (push_kind_type): New function.
11876         (convert_to_kind_type): New function.
11877         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11878         * parse.c (operator_length_standard): Likewise.
11879         * parser-defs.h (enum type_pieces): Add tp_kind.
11880         * std-operator.def: Add UNOP_KIND.
11881
11882 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11883
11884         * f-exp.y (f_parse): Set yydebug.
11885
11886 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11887
11888         * f-lang.c (evaluate_subexp_f): New function.
11889         (exp_descriptor_f): New global.
11890         (f_language_defn): Use exp_descriptor_f instead of
11891         exp_descriptor_standard.
11892
11893 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11894
11895         * f-exp.y (struct token): Add comments.
11896         (dot_ops): Remove uppercase versions and the end marker.
11897         (f77_keywords): Likewise.
11898         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11899         entries in the dot_ops array are case insensitive, and use
11900         strncasecmp to compare strings.  Also some whitespace cleanup in
11901         this area.  Similar for the f77_keywords array, except entries in
11902         this list might be case sensitive.
11903
11904 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11905
11906         * f-exp.y (struct f77_boolean_val): Add comments.
11907         (boolean_values): Remove uppercase versions, and end marker.
11908         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11909         and use strncasecmp to achieve case insensitivity.  Additionally,
11910         perform whitespace cleanup around this code.
11911
11912 2019-03-06  Tom Tromey  <tromey@adacore.com>
11913
11914         * remote-sim.c (gdbsim_target_open): Use result of
11915         gdb_argv::release.
11916
11917 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11918         Dirk Schubert  <dirk.schubert@arm.com>
11919         Chris January  <chris.january@arm.com>
11920
11921         * eval.c (evaluate_subexp_standard): Call Fortran argument
11922         wrapping logic.
11923         * f-lang.c (struct value): A value which can be passed into a
11924         Fortran function call.
11925         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11926         where appropriate.
11927         (struct type): Value ready for a Fortran function call.
11928         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11929         is needed.
11930         * f-lang.h (fortran_argument_convert): Declaration.
11931         (fortran_preserve_arg_pointer): Declaration.
11932         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11933
11934 2019-03-05  Tom Tromey  <tromey@adacore.com>
11935
11936         * python/py-prettyprint.c (print_string_repr): Remove #if.
11937         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11938
11939 2019-03-05  Tom Tromey  <tromey@adacore.com>
11940
11941         * target.c (the_dummy_target): Move later.  Change type to
11942         "dummy_target".
11943         (initialize_targets): Don't initialize the_dummy_target.
11944
11945 2019-03-05  Tom Tromey  <tromey@adacore.com>
11946
11947         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11948         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11949
11950 2019-03-05  Tom Tromey  <tromey@adacore.com>
11951
11952         * windows-nat.c (windows_nat_target::attach)
11953         (windows_nat_target::detach): Don't call gdb_flush.
11954         * valprint.c (generic_val_print, val_print, val_print_string):
11955         Don't call gdb_flush.
11956         * utils.c (defaulted_query): Don't call gdb_flush.
11957         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11958         * target.c (target_announce_detach): Don't call gdb_flush.
11959         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11960         * remote.c (extended_remote_target::attach): Don't call
11961         gdb_flush.
11962         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11963         * printcmd.c (do_examine): Don't call gdb_flush.
11964         (info_display_command): Don't call gdb_flush.
11965         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11966         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11967         * memattr.c (info_mem_command): Don't call gdb_flush.
11968         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11969         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11970         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11971         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11972         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11973         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11974         (gnu_nat_target::detach): Don't call gdb_flush.
11975         * f-valprint.c (f_val_print): Don't call gdb_flush.
11976         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11977         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11978         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11979         gdb_flush.
11980         * c-valprint.c (c_val_print): Don't call gdb_flush.
11981         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11982
11983 2019-03-05  Tom Tromey  <tromey@adacore.com>
11984
11985         * varobj.c (update_dynamic_varobj_children): Update.
11986         (install_default_visualizer): Use reset, not release.
11987         * value.c (set_internalvar): Update.
11988         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11989         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11990         ATTRIBUTE_UNUSED_RESULT.
11991
11992 2019-03-05  Tom Tromey  <tromey@adacore.com>
11993
11994         * remote.c (class scoped_remote_fd) <release>: Add
11995         ATTRIBUTE_UNUSED_RESULT.
11996
11997 2019-03-05  Tom Tromey  <tromey@adacore.com>
11998
11999         * macroexp.c (struct macro_buffer) <release>: Add
12000         ATTRIBUTE_UNUSED_RESULT.
12001
12002 2019-03-05  Tom Tromey  <tromey@adacore.com>
12003
12004         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12005         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12006         ATTRIBUTE_UNUSED_RESULT.
12007
12008 2019-03-05  Tom Tromey  <tromey@adacore.com>
12009
12010         * common/scoped_fd.h (class scoped_fd) <release>: Add
12011         ATTRIBUTE_UNUSED_RESULT.
12012
12013 2019-03-05  Tom Tromey  <tromey@adacore.com>
12014
12015         * parser-defs.h (struct parser_state) <release>: Add
12016         ATTRIBUTE_UNUSED_RESULT.
12017
12018 2019-03-05  Tom Tromey  <tromey@adacore.com>
12019
12020         * utils.h (class gdb_argv) <release>: Add
12021         ATTRIBUTE_UNUSED_RESULT.
12022         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12023
12024 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12025
12026         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12027         for-loop range, to avoid compiler warnings.
12028
12029         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12030         avoid compiler warnings about unused variables.
12031
12032         * NEWS: Mention end of support for native debugging on MS-Windows
12033         before XP.
12034
12035         PR gdb/24292
12036         * common/netstuff.c:
12037         * gdbserver/gdbreplay.c
12038         * gdbserver/remote-utils.c:
12039         * ser-tcp.c:
12040         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12041         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12042         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12043         'getaddrinfo' and 'freeaddrinfo' were not available before
12044         Windows XP, and mingw.org's MinGW headers by default define
12045         _WIN32_WINNT to 0x500.
12046
12047 2019-03-01  Gary Benson <gbenson@redhat.com>
12048
12049         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12050
12051 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12052             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12053
12054         PR gdb/8527
12055         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12056         set_sigint_trap, clear_sigint_trap.
12057
12058 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12059
12060         * target.c (target_detach): Clear the regcache and the
12061         frame cache.
12062
12063 2019-02-27  Pedro Alves  <palves@redhat.com>
12064
12065         * utils.c (set_screen_size): When we cap the height/width sizes,
12066         tweak the corresponding command variable to show "unlimited":
12067
12068 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12069             Pedro Alves  <palves@redhat.com>
12070
12071         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12072         before calling rl_set_screen_size.
12073
12074 2019-02-27  Tom Tromey  <tromey@adacore.com>
12075
12076         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12077         define.
12078         * python/py-value.c: Remove Python 2.4 workaround.
12079         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12080         workaround.
12081         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12082         Python 2.4 workaround.
12083         * python/python-internal.h: Remove Python 2.4 comment.
12084         (Py_ssize_t): Don't define.
12085         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12086         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12087         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12088         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12089         * python/python.c (do_start_initialization): Remove Python 2.4
12090         workaround.
12091         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12092         (print_children): Remove Python 2.4 workaround.
12093         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12094         workaround.
12095         (CHARBUFFERPROC_NAME): Remove.
12096         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12097         Python 2.4 workaround.
12098
12099 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12100
12101         * NEWS: Note minimum Python version.
12102
12103 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12104
12105         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12106         code from these functions.  Remove corresponding ifdefs.  Use
12107         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12108         Remove gotos and target of gotos.
12109         (infpy_search_memory): Likewise.
12110
12111 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12112
12113         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12114         (hppa_gdbarch_init): Don't register deleted functions with
12115         gdbarch.
12116
12117 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12118
12119         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12120         (h8300_unwind_sp): Delete.
12121         (h8300_dummy_id): Delete.
12122         (h8300_gdbarch_init): Don't register deleted functions with
12123         gdbarch.
12124
12125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12126
12127         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12128         (ft32_unwind_pc): Delete.
12129         (ft32_unwind_sp): Delete.
12130         (ft32_gdbarch_init): Don't register deleted functions with
12131         gdbarch.
12132
12133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12134
12135         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12136         (frv_unwind_pc): Delete.
12137         (frv_unwind_sp): Delete.
12138         (frv_gdbarch_init): Don't register deleted functions with
12139         gdbarch.
12140
12141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12142
12143         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12144         (riscv_unwind_pc): Delete.
12145         (riscv_unwind_sp): Delete.
12146         (riscv_gdbarch_init): Don't register deleted functions with
12147         gdbarch.
12148
12149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12150
12151         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12152         (csky_unwind_pc): Delete.
12153         (csky_unwind_sp): Delete.
12154         (csky_gdbarch_init): Don't register deleted functions with
12155         gdbarch.
12156
12157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12158
12159         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12160         (cris_unwind_pc): Delete.
12161         (cris_unwind_sp): Delete.
12162         (cris_gdbarch_init): Don't register deleted functions with
12163         gdbarch.
12164
12165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12166
12167         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12168         (bfin_unwind_pc): Delete.
12169         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12170
12171 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12172
12173         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12174         (arm_unwind_pc): Delete.
12175         (arm_unwind_sp): Delete.
12176         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12177
12178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12179
12180         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12181         (arc_unwind_pc): Delete.
12182         (arc_unwind_sp): Delete.
12183         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12184
12185 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12186
12187         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12188         (alpha_unwind_pc): Delete.
12189         (alpha_gdbarch_init): Don't register deleted functions with
12190         gdbarch.
12191
12192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12193
12194         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12195         (aarch64_unwind_pc): Delete.
12196         (aarch64_unwind_sp): Delete.
12197         (aarch64_gdbarch_init): Don't register deleted functions with
12198         gdbarch.
12199
12200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12201
12202         * gdbtypes.c (type_align): Don't consider static members when
12203         computing structure alignment.
12204
12205 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12206
12207         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12208         return 0 for other types.
12209         * arch-utils.c (default_type_align): Always return 0.
12210         * gdbarch.h: Regenerate.
12211         * gdbarch.sh (type_align): Extend comment.
12212         * gdbtypes.c (type_align): Add additional comments, always call
12213         gdbarch_type_align before applying the default rules.
12214         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12215         generic code will then apply a suitable default.
12216         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12217         types, return 0 for other types.
12218
12219 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12220
12221         * NEWS: Create a new section for the next release branch.
12222         Rename the section of the current branch, now that it has
12223         been cut.
12224
12225 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12226
12227         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12228         * version.in: Bump version to 8.3.50.DATE-git.
12229
12230 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12231
12232         * aix-thread.c (ptid_cmp): Remove unused variable.
12233         (get_signaled_thread): Likewise.
12234         (store_regs_user_thread): Likewise.
12235         (store_regs_kernel_thread): Likewise.
12236         (fetch_regs_kernel_thread): Remove shadowed variable.
12237
12238 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12239
12240         * features/riscv/32bit-cpu.xml: Add register numbers.
12241         * features/riscv/32bit-fpu.c: Regenerate.
12242         * features/riscv/32bit-fpu.xml: Add register numbers.
12243         * features/riscv/64bit-cpu.xml: Add register numbers.
12244         * features/riscv/64bit-fpu.c: Regenerate.
12245         * features/riscv/64bit-fpu.xml: Add register numbers.
12246
12247 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12248
12249         * NEWS: Mention two argument form of gdb.Value constructor.
12250         * python/py-value.c (convert_buffer_and_type_to_value): New
12251         function.
12252         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12253         Add support for handling an optional second argument.  Call
12254         convert_buffer_and_type_to_value as appropriate.
12255         * python/python-internal.h (Py_buffer_deleter): New struct.
12256         (Py_buffer_up): New typedef.
12257
12258 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12259
12260         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12261         instead of releasing ownership.
12262
12263 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12264
12265         * dwarf2read.c (open_and_init_dwp_file): Call
12266         elf_numsections instead of bfd_count_sections to initialize
12267         dwp_file->num_sections.
12268
12269 2019-02-25  Tom Tromey  <tromey@adacore.com>
12270
12271         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12272
12273 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12274
12275         * gcore.in: Add '--readnever' option when invoking GDB.
12276
12277 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12278
12279         * MAINTAINERS: Update my email address.
12280
12281 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12282
12283         * build-id.c (build_id_to_debug_bfd_1): New function.
12284         (build_id_to_debug_bfd): Look for separate debug file in
12285         sysroot.
12286
12287 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12288
12289         * gdbarch.sh: Update the copyright year range that is placed into
12290         generated files.
12291
12292 2019-02-22  Keith Seitz  <keiths@redhat.com>
12293
12294         PR symtab/23853
12295         * linespec.c (create_sals_line_offset): Search for the default
12296         symtab's filename instead of its fullname.
12297
12298 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12299
12300         * NEWS: Update style defaults.
12301
12302 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12303
12304         * main.c (captured_main_1): Disable styling in batch mode.
12305
12306 2019-02-20  Tom Tromey  <tom@tromey.com>
12307
12308         * symtab.c (symtab_symbol_info): Fix typos.
12309
12310 2019-02-20  Tom Tromey  <tromey@adacore.com>
12311
12312         * findcmd.c (_initialize_mem_search): Use upper case for
12313         metasyntactic variables.
12314
12315 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12316
12317         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12318         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12319
12320 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12321
12322         * top.h (source_file_name): Change to std::string.
12323         * top.c (source_file_name): Likewise.
12324         (command_line_input): Adjust.
12325         * cli/cli-script.c (script_from_file): Adjust.
12326
12327 2019-02-19  Tom Tromey  <tromey@adacore.com>
12328
12329         * ravenscar-thread.c
12330         (ravenscar_thread_target::update_thread_list): Don't call
12331         ada_build_task_list.
12332         * ada-lang.h (ada_build_task_list): Don't declare.
12333         * ada-tasks.c (struct ada_tasks_inferior_data)
12334         <task_list_valid_p>: Now bool.
12335         (read_known_tasks, ada_task_list_changed)
12336         (ada_tasks_invalidate_inferior_data): Update.
12337         (read_known_tasks_array): Return bool.
12338         (read_known_tasks_list): Likewise.
12339         (read_known_tasks): Return void.
12340         (ada_build_task_list): Now static.
12341
12342 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12343
12344         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12345         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12346
12347 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12348
12349         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12350         variant for ada_tasks_pspace_data_handle and
12351         ada_tasks_inferior_data_handle.
12352         (ada_tasks_pspace_data_cleanup): New function.
12353         (ada_tasks_inferior_data_cleanup): New function.
12354
12355 2019-02-17  Tom Tromey  <tom@tromey.com>
12356
12357         * macrotab.h (macro_source_fullname): Return a std::string.
12358         * macrotab.c (macro_include, check_for_redefinition)
12359         (macro_undef, macro_lookup_definition, foreach_macro)
12360         (foreach_macro_in_scope): Update.
12361         (macro_source_fullname): Return a std::string.
12362         * macrocmd.c (show_pp_source_pos): Update.
12363
12364 2019-02-17  Tom Tromey  <tom@tromey.com>
12365
12366         * macrocmd.c (show_pp_source_pos): Style the file names.
12367
12368 2019-02-17  Tom Tromey  <tom@tromey.com>
12369
12370         PR tui/24197:
12371         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12372
12373 2019-02-17  Tom Tromey  <tom@tromey.com>
12374
12375         * ada-lang.c (user_select_syms): Use filtered printing.
12376         * utils.c (wrap_style): New global.
12377         (desired_style): Remove.
12378         (emit_style_escape): Add stream parameter.
12379         (set_output_style, reset_terminal_style, prompt_for_continue):
12380         Update.
12381         (flush_wrap_buffer): Only flush gdb_stdout.
12382         (wrap_here): Set wrap_style.
12383         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12384         treat escape sequences as a character.  Change when wrap buffer is
12385         flushed.
12386         (fputs_styled): Do not set the output style when the default is
12387         requested.
12388         * ui-style.h (struct ui_file_style) <is_default>: New method.
12389         * source.c (print_source_lines_base): Emit escape sequences in one
12390         piece.
12391
12392 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12393
12394         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12395         integers and enumeration types.
12396
12397 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12398
12399         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12400         instead of lookup_symbol_in_language
12401         (do_exact_match): New function.
12402         (ada_get_symbol_name_matcher): Return do_exact_match when
12403         doing a verbatim match.
12404
12405 2019-02-15  Tom Tromey  <tromey@adacore.com>
12406
12407         * ravenscar-thread.c (ravenscar_thread_target::resume)
12408         (ravenscar_thread_target::wait): Special case wildcard requests.
12409
12410 2019-02-15  Tom Tromey  <tromey@adacore.com>
12411
12412         * ravenscar-thread.c (base_ptid): Remove.
12413         (struct ravenscar_thread_target) <close>: New method.
12414         <m_base_ptid>: New member.
12415         <update_inferior_ptid, active_task, task_is_currently_active,
12416         runtime_initialized>: Declare methods.
12417         <ravenscar_thread_target>: Add constructor.
12418         (ravenscar_thread_target::task_is_currently_active)
12419         (ravenscar_thread_target::update_inferior_ptid)
12420         (ravenscar_runtime_initialized): Rename.  Now methods.
12421         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12422         (ravenscar_thread_target::update_thread_list): Update.
12423         (ravenscar_thread_target::active_task): Now method.
12424         (ravenscar_thread_target::store_registers)
12425         (ravenscar_thread_target::prepare_to_store)
12426         (ravenscar_thread_target::prepare_to_store)
12427         (ravenscar_thread_target::mourn_inferior): Update.
12428         (ravenscar_inferior_created): Use "new" to create target.
12429         (ravenscar_thread_target::get_ada_task_ptid): Update.
12430         (_initialize_ravenscar): Don't initialize base_ptid.
12431         (ravenscar_ops): Remove global.
12432
12433 2019-02-15  Tom Tromey  <tromey@adacore.com>
12434
12435         * target.h (push_target): Declare new overload.
12436         * target.c (push_target): New overload, taking an rvalue reference.
12437         * remote.c (remote_target::open_1): Use push_target overload.
12438         * corelow.c (core_target_open): Use push_target overload.
12439
12440 2019-02-15  Tom Tromey  <tromey@adacore.com>
12441
12442         * ravenscar-thread.c (is_ravenscar_task)
12443         (ravenscar_task_is_currently_active): Return bool.
12444         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12445         (_initialize_ravenscar): Remove "(void)".
12446         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12447         Return bool.
12448
12449 2019-02-15  Tom Tromey  <tromey@adacore.com>
12450
12451         * ravenscar-thread.c (ravenscar_runtime_initializer)
12452         (has_ravenscar_runtime, get_running_thread_id)
12453         (ravenscar_thread_target::resume): Fix indentation.
12454
12455 2019-02-15  Tom Tromey  <tromey@adacore.com>
12456
12457         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12458         from ravenscar_arch_ops.
12459         (sparc_ravenscar_ops::fetch_registers)
12460         (sparc_ravenscar_ops::store_registers): Now methods.
12461         (sparc_ravenscar_prepare_to_store): Remove.
12462         (sparc_ravenscar_ops): Redefine.
12463         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12464         methods and destructor.  Remove members.
12465         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12466         (ravenscar_thread_target::store_registers)
12467         (ravenscar_thread_target::prepare_to_store): Update.
12468         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12469         Remove.
12470         (struct ppc_ravenscar_powerpc_ops): Derive from
12471         ravenscar_arch_ops.
12472         (ppc_ravenscar_powerpc_ops::fetch_registers)
12473         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12474         (ppc_ravenscar_powerpc_ops): Redefine.
12475         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12476         (ppc_ravenscar_e500_ops::fetch_registers)
12477         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12478         (ppc_ravenscar_e500_ops): Redefine.
12479         * aarch64-ravenscar-thread.c
12480         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12481         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12482         (aarch64_ravenscar_fetch_registers)
12483         (aarch64_ravenscar_store_registers): Now methods.
12484         (aarch64_ravenscar_ops): Redefine.
12485
12486 2019-02-15  Tom Tromey  <tromey@adacore.com>
12487
12488         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12489         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12490         (ravenscar_thread_target::stopped_by_watchpoint)
12491         (ravenscar_thread_target::stopped_data_address)
12492         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12493
12494 2019-02-15  Tom Tromey  <tromey@adacore.com>
12495
12496         * ravenscar-thread.c: Fix some typos.
12497
12498 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12499             Tom Tromey  <tromey@adacore.com>
12500
12501         * ada-lang.c (ada_exception_sal): Change addr_string to a
12502         std::string.
12503         (create_ada_exception_catchpoint): Update.
12504
12505 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12506             Tom Tromey  <tromey@adacore.com>
12507
12508         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12509         (bp_location_ops): Remove.
12510         (base_breakpoint_allocate_location): Update.
12511         (free_bp_location): Update.
12512         * ada-lang.c (class ada_catchpoint_location)
12513         <ada_catchpoint_location>: Remove ops parameter.
12514         (ada_catchpoint_location_dtor): Remove.
12515         (ada_catchpoint_location_ops): Remove.
12516         (allocate_location_exception): Update.
12517         * breakpoint.h (struct bp_location_ops): Remove.
12518         (class bp_location) <bp_location>: Remove bp_location_ops
12519         parameter.
12520         <~bp_location>: Add destructor.
12521         <ops>: Remove.
12522
12523 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12524             Pedro Alves  <palves@redhat.com>
12525
12526         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12527         'PATH_MAX'.
12528
12529 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12530             Samuel Thibault  <samuel.thibault@gnu.org>
12531             Thomas Schwinge  <thomas@codesourcery.com>
12532
12533         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12534         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12535
12536 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12537
12538         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12539         (check_empty): Use "const char *".
12540
12541         * gnu-nat.c (gnu_nat_target::detach): Instead of
12542         'detach_inferior (pid)' call
12543         'detach_inferior (find_inferior_pid (pid))'.
12544
12545         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12546         'nat/fork-inferior.o'.
12547         * gnu-nat.c: #include "nat/fork-inferior.h".
12548
12549         * gnu-nat.c (gnu_nat_target::detach): Instead of
12550         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12551         * gnu-nat.h: #include "inf-child.h".
12552         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12553         'i386_gnu_nat_target::fetch_registers'.
12554         (gnu_store_registers): Rename/move to
12555         'i386_gnu_nat_target::store_registers'.
12556
12557         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12558         * gnu-nat.h (mach_thread_info): New function.
12559         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12560
12561         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12562
12563 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12564
12565         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12566
12567 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12568
12569         * windows-nat.c (windows_add_thread): Add new parameter
12570         "main_thread_p" with default value set to false.  Update
12571         function documentation as well as all callers.
12572         (windows_delete_thread): Likewise.
12573         (fake_create_process): Update call to windows_add_thread.
12574         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12575         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12576         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12577         call to windows_delete_thread.
12578
12579 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12580
12581         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12582
12583 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12584
12585         * symfile.c (find_separate_debug_file): Use canonical path of
12586         sysroot with child_path instead of gdb_sysroot if it is valid.
12587
12588 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12589
12590         * symfile.c (find_separate_debug_file): Use child_path to
12591         determine if an object file is under a sysroot.
12592
12593 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12594
12595         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12596         unittests/child-path-selftests.c.
12597         * common/pathstuff.c (child_path): New function.
12598         * common/pathstuff.h (child_path): New prototype.
12599         * unittests/child-path-selftests.c: New file.
12600
12601 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12602
12603         * symfile.c (find_separate_debug_file): Look for separate debug
12604         files in debug directories under the sysroot.
12605
12606 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12607
12608         * symtab.h (struct minimal_symbol data_p): New const method.
12609         (struct minimal_symbol text_p): Likewise.
12610         * symtab.c (output_source_filename): Use file name style
12611         to print file name.
12612         (print_symbol_info): Likewise.
12613         (print_msymbol_info): Use address style to print addresses.
12614         Use function name style to print executable text symbols.
12615         (expand_symtab_containing_pc): Use data_p.
12616         (find_pc_sect_compunit_symtab): Likewise.
12617
12618 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12619
12620         * breakpoint.c (describe_other_breakpoints): Use address style
12621         to print addresses.
12622         (say_where): Likewise.
12623
12624 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12625
12626         * ada-typeprint.c (print_func_type): Print function name
12627         style to print function name.
12628         * c-typeprint.c (c_print_type_1): Likewise.
12629
12630 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12631
12632         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12633         for execve.
12634
12635 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12636
12637         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12638         type_stack.
12639
12640 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12641
12642         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12643         TYPE_CODE_REF types.
12644
12645 2019-02-08  Jim Wilson  <jimw@sifive.com>
12646
12647         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12648         (riscv_linux_fregset): New.
12649         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12650
12651 2019-02-07  Tom Tromey  <tom@tromey.com>
12652
12653         * thread.c (thread_cancel_execution_command): Update.
12654         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12655         methods.
12656         (struct thread_fsm_ops): Remove.
12657         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12658         (thread_fsm_should_stop, thread_fsm_return_value)
12659         (thread_fsm_set_finished, thread_fsm_finished_p)
12660         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12661         Don't declare.
12662         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12663         * infrun.c (clear_proceed_status_thread)
12664         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12665         (print_stop_event): Update.
12666         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12667         Add constructor.
12668         (step_command_fsm_ops): Remove.
12669         (new_step_command_fsm): Remove.
12670         (step_1): Update.
12671         (step_command_fsm::should_stop): Rename from
12672         step_command_fsm_should_stop.
12673         (step_command_fsm::clean_up): Rename from
12674         step_command_fsm_clean_up.
12675         (step_command_fsm::do_async_reply_reason): Rename from
12676         step_command_fsm_async_reply_reason.
12677         (struct until_next_fsm): Inherit from thread_fsm.  Add
12678         constructor.
12679         (until_next_fsm_ops): Remove.
12680         (new_until_next_fsm): Remove.
12681         (until_next_fsm::should_stop): Rename from
12682         until_next_fsm_should_stop.
12683         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12684         (until_next_fsm::do_async_reply_reason): Rename from
12685         until_next_fsm_async_reply_reason.
12686         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12687         constructor.  Change type of breakpoint.
12688         (finish_command_fsm_ops): Remove.
12689         (new_finish_command_fsm): Remove.
12690         (finish_command_fsm::should_stop): Rename from
12691         finish_command_fsm_should_stop.
12692         (finish_command_fsm::clean_up): Rename from
12693         finish_command_fsm_clean_up.
12694         (finish_command_fsm::return_value): Rename from
12695         finish_command_fsm_return_value.
12696         (finish_command_fsm::do_async_reply_reason): Rename from
12697         finish_command_fsm_async_reply_reason.
12698         (finish_command): Update.
12699         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12700         Add constructor.
12701         (call_thread_fsm_ops): Remove.
12702         (call_thread_fsm::call_thread_fsm): Rename from
12703         new_call_thread_fsm.
12704         (call_thread_fsm::should_stop): Rename from
12705         call_thread_fsm_should_stop.
12706         (call_thread_fsm::should_notify_stop): Rename from
12707         call_thread_fsm_should_notify_stop.
12708         (run_inferior_call, call_function_by_hand_dummy): Update.
12709         * cli/cli-interp.c (should_print_stop_to_console): Update.
12710         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12711         Add constructor.  Change type of location_breakpoint,
12712         caller_breakpoint.
12713         (until_break_fsm_ops): Remove.
12714         (new_until_break_fsm): Remove.
12715         (until_break_fsm::should_stop): Rename from
12716         until_break_fsm_should_stop.
12717         (until_break_fsm::clean_up): Rename from
12718         until_break_fsm_clean_up.
12719         (until_break_fsm::do_async_reply_reason): Rename from
12720         until_break_fsm_async_reply_reason.
12721         (until_break_command): Update.
12722         * thread-fsm.c: Remove.
12723         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12724
12725 2019-02-07  Tom Tromey  <tom@tromey.com>
12726
12727         * yy-remap.h: Add include guard.
12728         * xtensa-tdep.h: Add include guard.
12729         * xcoffread.h: Rename include guard.
12730         * varobj-iter.h: Add include guard.
12731         * tui/tui.h: Rename include guard.
12732         * tui/tui-winsource.h: Rename include guard.
12733         * tui/tui-wingeneral.h: Rename include guard.
12734         * tui/tui-windata.h: Rename include guard.
12735         * tui/tui-win.h: Rename include guard.
12736         * tui/tui-stack.h: Rename include guard.
12737         * tui/tui-source.h: Rename include guard.
12738         * tui/tui-regs.h: Rename include guard.
12739         * tui/tui-out.h: Rename include guard.
12740         * tui/tui-layout.h: Rename include guard.
12741         * tui/tui-io.h: Rename include guard.
12742         * tui/tui-hooks.h: Rename include guard.
12743         * tui/tui-file.h: Rename include guard.
12744         * tui/tui-disasm.h: Rename include guard.
12745         * tui/tui-data.h: Rename include guard.
12746         * tui/tui-command.h: Rename include guard.
12747         * tic6x-tdep.h: Add include guard.
12748         * target/waitstatus.h: Rename include guard.
12749         * target/wait.h: Rename include guard.
12750         * target/target.h: Rename include guard.
12751         * target/resume.h: Rename include guard.
12752         * target-float.h: Rename include guard.
12753         * stabsread.h: Add include guard.
12754         * rs6000-tdep.h: Add include guard.
12755         * riscv-fbsd-tdep.h: Add include guard.
12756         * regformats/regdef.h: Rename include guard.
12757         * record.h: Rename include guard.
12758         * python/python.h: Rename include guard.
12759         * python/python-internal.h: Rename include guard.
12760         * python/py-stopevent.h: Rename include guard.
12761         * python/py-ref.h: Rename include guard.
12762         * python/py-record.h: Rename include guard.
12763         * python/py-record-full.h: Rename include guard.
12764         * python/py-record-btrace.h: Rename include guard.
12765         * python/py-instruction.h: Rename include guard.
12766         * python/py-events.h: Rename include guard.
12767         * python/py-event.h: Rename include guard.
12768         * procfs.h: Add include guard.
12769         * proc-utils.h: Add include guard.
12770         * p-lang.h: Add include guard.
12771         * or1k-tdep.h: Rename include guard.
12772         * observable.h: Rename include guard.
12773         * nto-tdep.h: Rename include guard.
12774         * nat/x86-linux.h: Rename include guard.
12775         * nat/x86-linux-dregs.h: Rename include guard.
12776         * nat/x86-gcc-cpuid.h: Add include guard.
12777         * nat/x86-dregs.h: Rename include guard.
12778         * nat/x86-cpuid.h: Rename include guard.
12779         * nat/ppc-linux.h: Rename include guard.
12780         * nat/mips-linux-watch.h: Rename include guard.
12781         * nat/linux-waitpid.h: Rename include guard.
12782         * nat/linux-ptrace.h: Rename include guard.
12783         * nat/linux-procfs.h: Rename include guard.
12784         * nat/linux-osdata.h: Rename include guard.
12785         * nat/linux-nat.h: Rename include guard.
12786         * nat/linux-namespaces.h: Rename include guard.
12787         * nat/linux-btrace.h: Rename include guard.
12788         * nat/glibc_thread_db.h: Rename include guard.
12789         * nat/gdb_thread_db.h: Rename include guard.
12790         * nat/gdb_ptrace.h: Rename include guard.
12791         * nat/fork-inferior.h: Rename include guard.
12792         * nat/amd64-linux-siginfo.h: Rename include guard.
12793         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12794         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12795         * nat/aarch64-linux.h: Rename include guard.
12796         * nat/aarch64-linux-hw-point.h: Rename include guard.
12797         * mn10300-tdep.h: Add include guard.
12798         * mips-linux-tdep.h: Add include guard.
12799         * mi/mi-parse.h: Rename include guard.
12800         * mi/mi-out.h: Rename include guard.
12801         * mi/mi-main.h: Rename include guard.
12802         * mi/mi-interp.h: Rename include guard.
12803         * mi/mi-getopt.h: Rename include guard.
12804         * mi/mi-console.h: Rename include guard.
12805         * mi/mi-common.h: Rename include guard.
12806         * mi/mi-cmds.h: Rename include guard.
12807         * mi/mi-cmd-break.h: Rename include guard.
12808         * m2-lang.h: Add include guard.
12809         * location.h: Rename include guard.
12810         * linux-record.h: Rename include guard.
12811         * linux-nat.h: Add include guard.
12812         * linux-fork.h: Add include guard.
12813         * i386-darwin-tdep.h: Rename include guard.
12814         * hppa-linux-offsets.h: Add include guard.
12815         * guile/guile.h: Rename include guard.
12816         * guile/guile-internal.h: Rename include guard.
12817         * gnu-nat.h: Rename include guard.
12818         * gdb-stabs.h: Rename include guard.
12819         * frv-tdep.h: Add include guard.
12820         * f-lang.h: Add include guard.
12821         * event-loop.h: Add include guard.
12822         * darwin-nat.h: Rename include guard.
12823         * cp-abi.h: Rename include guard.
12824         * config/sparc/nm-sol2.h: Rename include guard.
12825         * config/nm-nto.h: Rename include guard.
12826         * config/nm-linux.h: Add include guard.
12827         * config/i386/nm-i386gnu.h: Rename include guard.
12828         * config/djgpp/nl_types.h: Rename include guard.
12829         * config/djgpp/langinfo.h: Rename include guard.
12830         * compile/gcc-cp-plugin.h: Add include guard.
12831         * compile/gcc-c-plugin.h: Add include guard.
12832         * compile/compile.h: Rename include guard.
12833         * compile/compile-object-run.h: Rename include guard.
12834         * compile/compile-object-load.h: Rename include guard.
12835         * compile/compile-internal.h: Rename include guard.
12836         * compile/compile-cplus.h: Rename include guard.
12837         * compile/compile-c.h: Rename include guard.
12838         * common/xml-utils.h: Rename include guard.
12839         * common/x86-xstate.h: Rename include guard.
12840         * common/version.h: Rename include guard.
12841         * common/vec.h: Rename include guard.
12842         * common/tdesc.h: Rename include guard.
12843         * common/selftest.h: Rename include guard.
12844         * common/scoped_restore.h: Rename include guard.
12845         * common/scoped_mmap.h: Rename include guard.
12846         * common/scoped_fd.h: Rename include guard.
12847         * common/safe-iterator.h: Rename include guard.
12848         * common/run-time-clock.h: Rename include guard.
12849         * common/refcounted-object.h: Rename include guard.
12850         * common/queue.h: Rename include guard.
12851         * common/ptid.h: Rename include guard.
12852         * common/print-utils.h: Rename include guard.
12853         * common/preprocessor.h: Rename include guard.
12854         * common/pathstuff.h: Rename include guard.
12855         * common/observable.h: Rename include guard.
12856         * common/netstuff.h: Rename include guard.
12857         * common/job-control.h: Rename include guard.
12858         * common/host-defs.h: Rename include guard.
12859         * common/gdb_wait.h: Rename include guard.
12860         * common/gdb_vecs.h: Rename include guard.
12861         * common/gdb_unlinker.h: Rename include guard.
12862         * common/gdb_unique_ptr.h: Rename include guard.
12863         * common/gdb_tilde_expand.h: Rename include guard.
12864         * common/gdb_sys_time.h: Rename include guard.
12865         * common/gdb_string_view.h: Rename include guard.
12866         * common/gdb_splay_tree.h: Rename include guard.
12867         * common/gdb_setjmp.h: Rename include guard.
12868         * common/gdb_ref_ptr.h: Rename include guard.
12869         * common/gdb_optional.h: Rename include guard.
12870         * common/gdb_locale.h: Rename include guard.
12871         * common/gdb_assert.h: Rename include guard.
12872         * common/filtered-iterator.h: Rename include guard.
12873         * common/filestuff.h: Rename include guard.
12874         * common/fileio.h: Rename include guard.
12875         * common/environ.h: Rename include guard.
12876         * common/common-utils.h: Rename include guard.
12877         * common/common-types.h: Rename include guard.
12878         * common/common-regcache.h: Rename include guard.
12879         * common/common-inferior.h: Rename include guard.
12880         * common/common-gdbthread.h: Rename include guard.
12881         * common/common-exceptions.h: Rename include guard.
12882         * common/common-defs.h: Rename include guard.
12883         * common/common-debug.h: Rename include guard.
12884         * common/cleanups.h: Rename include guard.
12885         * common/buffer.h: Rename include guard.
12886         * common/btrace-common.h: Rename include guard.
12887         * common/break-common.h: Rename include guard.
12888         * cli/cli-utils.h: Rename include guard.
12889         * cli/cli-style.h: Rename include guard.
12890         * cli/cli-setshow.h: Rename include guard.
12891         * cli/cli-script.h: Rename include guard.
12892         * cli/cli-interp.h: Rename include guard.
12893         * cli/cli-decode.h: Rename include guard.
12894         * cli/cli-cmds.h: Rename include guard.
12895         * charset-list.h: Add include guard.
12896         * buildsym-legacy.h: Rename include guard.
12897         * bfin-tdep.h: Add include guard.
12898         * ax.h: Rename include guard.
12899         * arm-linux-tdep.h: Add include guard.
12900         * arm-fbsd-tdep.h: Add include guard.
12901         * arch/xtensa.h: Rename include guard.
12902         * arch/tic6x.h: Add include guard.
12903         * arch/i386.h: Add include guard.
12904         * arch/arm.h: Rename include guard.
12905         * arch/arm-linux.h: Rename include guard.
12906         * arch/arm-get-next-pcs.h: Rename include guard.
12907         * arch/amd64.h: Add include guard.
12908         * arch/aarch64-insn.h: Rename include guard.
12909         * arch-utils.h: Rename include guard.
12910         * annotate.h: Add include guard.
12911         * amd64-darwin-tdep.h: Rename include guard.
12912         * aarch64-linux-tdep.h: Add include guard.
12913         * aarch64-fbsd-tdep.h: Add include guard.
12914         * aarch32-linux-nat.h: Add include guard.
12915
12916 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12917
12918         * macrotab.c (macro_define_internal): New function that
12919         factorizes macro_define_object_internal and macro_define_function
12920         code.
12921         (macro_define_object_internal): Use macro_define_internal.
12922         (macro_define_function): Likewise.
12923
12924 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12925
12926         * macrocmd.c (extract_identifier): Return
12927         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12928         callers.
12929
12930 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12931
12932         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12933
12934 2019-02-05  Tom Tromey  <tom@tromey.com>
12935
12936         * target.c (target_stack::unpush): Move assertion earlier.
12937
12938 2019-01-30  Tom Tromey  <tom@tromey.com>
12939
12940         PR python/23615:
12941         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12942         (gdbpy_parse_and_eval): Likewise.
12943         * python/python-internal.h (gdbpy_allow_threads): New class.
12944
12945 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12946
12947         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12948         (aarch64_fbsd_fpregmap): Move earlier.
12949         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12950         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12951         instead of individual calls to trad_frame_set_reg_addr.
12952         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12953         earlier.
12954         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12955         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12956         instead of individual calls to trad_frame_set_reg_addr.
12957
12958 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12959
12960         * CONTRIBUTE: Replace contribution list with wiki link.
12961
12962 2019-01-25  Tom Tromey  <tom@tromey.com>
12963
12964         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12965
12966 2019-01-25  Tom Tromey  <tom@tromey.com>
12967
12968         * xtensa-linux-nat.c: Fix common/ includes.
12969         * xml-support.h: Fix common/ includes.
12970         * xml-support.c: Fix common/ includes.
12971         * x86-linux-nat.c: Fix common/ includes.
12972         * windows-nat.c: Fix common/ includes.
12973         * varobj.h: Fix common/ includes.
12974         * varobj.c: Fix common/ includes.
12975         * value.c: Fix common/ includes.
12976         * valops.c: Fix common/ includes.
12977         * utils.c: Fix common/ includes.
12978         * unittests/xml-utils-selftests.c: Fix common/ includes.
12979         * unittests/utils-selftests.c: Fix common/ includes.
12980         * unittests/unpack-selftests.c: Fix common/ includes.
12981         * unittests/tracepoint-selftests.c: Fix common/ includes.
12982         * unittests/style-selftests.c: Fix common/ includes.
12983         * unittests/string_view-selftests.c: Fix common/ includes.
12984         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12985         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12986         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12987         * unittests/rsp-low-selftests.c: Fix common/ includes.
12988         * unittests/parse-connection-spec-selftests.c: Fix common/
12989         includes.
12990         * unittests/optional-selftests.c: Fix common/ includes.
12991         * unittests/offset-type-selftests.c: Fix common/ includes.
12992         * unittests/observable-selftests.c: Fix common/ includes.
12993         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12994         * unittests/memrange-selftests.c: Fix common/ includes.
12995         * unittests/memory-map-selftests.c: Fix common/ includes.
12996         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12997         * unittests/function-view-selftests.c: Fix common/ includes.
12998         * unittests/environ-selftests.c: Fix common/ includes.
12999         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13000         * unittests/common-utils-selftests.c: Fix common/ includes.
13001         * unittests/cli-utils-selftests.c: Fix common/ includes.
13002         * unittests/array-view-selftests.c: Fix common/ includes.
13003         * ui-file.c: Fix common/ includes.
13004         * tui/tui-io.c: Fix common/ includes.
13005         * tracepoint.h: Fix common/ includes.
13006         * tracepoint.c: Fix common/ includes.
13007         * tracefile-tfile.c: Fix common/ includes.
13008         * top.h: Fix common/ includes.
13009         * top.c: Fix common/ includes.
13010         * thread.c: Fix common/ includes.
13011         * target/waitstatus.h: Fix common/ includes.
13012         * target/waitstatus.c: Fix common/ includes.
13013         * target.h: Fix common/ includes.
13014         * target.c: Fix common/ includes.
13015         * target-memory.c: Fix common/ includes.
13016         * target-descriptions.c: Fix common/ includes.
13017         * symtab.h: Fix common/ includes.
13018         * symfile.c: Fix common/ includes.
13019         * stap-probe.c: Fix common/ includes.
13020         * spu-linux-nat.c: Fix common/ includes.
13021         * sparc-nat.c: Fix common/ includes.
13022         * source.c: Fix common/ includes.
13023         * solib.c: Fix common/ includes.
13024         * solib-target.c: Fix common/ includes.
13025         * ser-unix.c: Fix common/ includes.
13026         * ser-tcp.c: Fix common/ includes.
13027         * ser-pipe.c: Fix common/ includes.
13028         * ser-base.c: Fix common/ includes.
13029         * selftest-arch.c: Fix common/ includes.
13030         * s12z-tdep.c: Fix common/ includes.
13031         * rust-exp.y: Fix common/ includes.
13032         * rs6000-aix-tdep.c: Fix common/ includes.
13033         * riscv-tdep.c: Fix common/ includes.
13034         * remote.c: Fix common/ includes.
13035         * remote-notif.h: Fix common/ includes.
13036         * remote-fileio.h: Fix common/ includes.
13037         * remote-fileio.c: Fix common/ includes.
13038         * regcache.h: Fix common/ includes.
13039         * regcache.c: Fix common/ includes.
13040         * record-btrace.c: Fix common/ includes.
13041         * python/python.c: Fix common/ includes.
13042         * python/py-type.c: Fix common/ includes.
13043         * python/py-inferior.c: Fix common/ includes.
13044         * progspace.h: Fix common/ includes.
13045         * producer.c: Fix common/ includes.
13046         * procfs.c: Fix common/ includes.
13047         * proc-api.c: Fix common/ includes.
13048         * printcmd.c: Fix common/ includes.
13049         * ppc-linux-nat.c: Fix common/ includes.
13050         * parser-defs.h: Fix common/ includes.
13051         * osdata.c: Fix common/ includes.
13052         * obsd-nat.c: Fix common/ includes.
13053         * nat/x86-linux.c: Fix common/ includes.
13054         * nat/x86-linux-dregs.c: Fix common/ includes.
13055         * nat/x86-dregs.h: Fix common/ includes.
13056         * nat/x86-dregs.c: Fix common/ includes.
13057         * nat/ppc-linux.c: Fix common/ includes.
13058         * nat/mips-linux-watch.h: Fix common/ includes.
13059         * nat/mips-linux-watch.c: Fix common/ includes.
13060         * nat/linux-waitpid.c: Fix common/ includes.
13061         * nat/linux-ptrace.h: Fix common/ includes.
13062         * nat/linux-ptrace.c: Fix common/ includes.
13063         * nat/linux-procfs.c: Fix common/ includes.
13064         * nat/linux-personality.c: Fix common/ includes.
13065         * nat/linux-osdata.c: Fix common/ includes.
13066         * nat/linux-namespaces.c: Fix common/ includes.
13067         * nat/linux-btrace.h: Fix common/ includes.
13068         * nat/linux-btrace.c: Fix common/ includes.
13069         * nat/fork-inferior.c: Fix common/ includes.
13070         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13071         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13072         * nat/aarch64-linux.c: Fix common/ includes.
13073         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13074         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13075         * namespace.h: Fix common/ includes.
13076         * mips-linux-tdep.c: Fix common/ includes.
13077         * minsyms.c: Fix common/ includes.
13078         * mi/mi-parse.h: Fix common/ includes.
13079         * mi/mi-main.c: Fix common/ includes.
13080         * mi/mi-cmd-env.c: Fix common/ includes.
13081         * memrange.h: Fix common/ includes.
13082         * memattr.c: Fix common/ includes.
13083         * maint.h: Fix common/ includes.
13084         * maint.c: Fix common/ includes.
13085         * main.c: Fix common/ includes.
13086         * machoread.c: Fix common/ includes.
13087         * location.c: Fix common/ includes.
13088         * linux-thread-db.c: Fix common/ includes.
13089         * linux-nat.c: Fix common/ includes.
13090         * linux-fork.c: Fix common/ includes.
13091         * inline-frame.c: Fix common/ includes.
13092         * infrun.c: Fix common/ includes.
13093         * inflow.c: Fix common/ includes.
13094         * inferior.h: Fix common/ includes.
13095         * inferior.c: Fix common/ includes.
13096         * infcmd.c: Fix common/ includes.
13097         * inf-ptrace.c: Fix common/ includes.
13098         * inf-child.c: Fix common/ includes.
13099         * ia64-linux-nat.c: Fix common/ includes.
13100         * i387-tdep.c: Fix common/ includes.
13101         * i386-tdep.c: Fix common/ includes.
13102         * i386-linux-tdep.c: Fix common/ includes.
13103         * i386-linux-nat.c: Fix common/ includes.
13104         * i386-go32-tdep.c: Fix common/ includes.
13105         * i386-fbsd-tdep.c: Fix common/ includes.
13106         * i386-fbsd-nat.c: Fix common/ includes.
13107         * guile/scm-type.c: Fix common/ includes.
13108         * guile/guile.c: Fix common/ includes.
13109         * go32-nat.c: Fix common/ includes.
13110         * gnu-nat.c: Fix common/ includes.
13111         * gdbthread.h: Fix common/ includes.
13112         * gdbarch-selftests.c: Fix common/ includes.
13113         * gdb_usleep.c: Fix common/ includes.
13114         * gdb_select.h: Fix common/ includes.
13115         * gdb_bfd.c: Fix common/ includes.
13116         * gcore.c: Fix common/ includes.
13117         * fork-child.c: Fix common/ includes.
13118         * findvar.c: Fix common/ includes.
13119         * fbsd-nat.c: Fix common/ includes.
13120         * event-top.c: Fix common/ includes.
13121         * event-loop.c: Fix common/ includes.
13122         * dwarf2read.c: Fix common/ includes.
13123         * dwarf2loc.c: Fix common/ includes.
13124         * dwarf2-frame.c: Fix common/ includes.
13125         * dwarf-index-cache.c: Fix common/ includes.
13126         * dtrace-probe.c: Fix common/ includes.
13127         * disasm-selftests.c: Fix common/ includes.
13128         * defs.h: Fix common/ includes.
13129         * csky-tdep.c: Fix common/ includes.
13130         * cp-valprint.c: Fix common/ includes.
13131         * cp-support.h: Fix common/ includes.
13132         * cp-support.c: Fix common/ includes.
13133         * corelow.c: Fix common/ includes.
13134         * completer.h: Fix common/ includes.
13135         * completer.c: Fix common/ includes.
13136         * compile/compile.c: Fix common/ includes.
13137         * compile/compile-loc2c.c: Fix common/ includes.
13138         * compile/compile-cplus-types.c: Fix common/ includes.
13139         * compile/compile-cplus-symbols.c: Fix common/ includes.
13140         * command.h: Fix common/ includes.
13141         * cli/cli-dump.c: Fix common/ includes.
13142         * cli/cli-cmds.c: Fix common/ includes.
13143         * charset.c: Fix common/ includes.
13144         * build-id.c: Fix common/ includes.
13145         * btrace.h: Fix common/ includes.
13146         * btrace.c: Fix common/ includes.
13147         * breakpoint.h: Fix common/ includes.
13148         * breakpoint.c: Fix common/ includes.
13149         * ax.h:
13150         (enum agent_op): Fix common/ includes.
13151         * ax-general.c (struct aop_map): Fix common/ includes.
13152         * ax-gdb.c: Fix common/ includes.
13153         * auxv.c: Fix common/ includes.
13154         * auto-load.c: Fix common/ includes.
13155         * arm-tdep.c: Fix common/ includes.
13156         * arch/riscv.c: Fix common/ includes.
13157         * arch/ppc-linux-common.c: Fix common/ includes.
13158         * arch/i386.c: Fix common/ includes.
13159         * arch/arm.c: Fix common/ includes.
13160         * arch/arm-linux.c: Fix common/ includes.
13161         * arch/arm-get-next-pcs.c: Fix common/ includes.
13162         * arch/amd64.c: Fix common/ includes.
13163         * arch/aarch64.c: Fix common/ includes.
13164         * arch/aarch64-insn.c: Fix common/ includes.
13165         * arch-utils.c: Fix common/ includes.
13166         * amd64-windows-tdep.c: Fix common/ includes.
13167         * amd64-tdep.c: Fix common/ includes.
13168         * amd64-sol2-tdep.c: Fix common/ includes.
13169         * amd64-obsd-tdep.c: Fix common/ includes.
13170         * amd64-nbsd-tdep.c: Fix common/ includes.
13171         * amd64-linux-tdep.c: Fix common/ includes.
13172         * amd64-linux-nat.c: Fix common/ includes.
13173         * amd64-fbsd-tdep.c: Fix common/ includes.
13174         * amd64-fbsd-nat.c: Fix common/ includes.
13175         * amd64-dicos-tdep.c: Fix common/ includes.
13176         * amd64-darwin-tdep.c: Fix common/ includes.
13177         * agent.c: Fix common/ includes.
13178         * ada-lang.h: Fix common/ includes.
13179         * ada-lang.c: Fix common/ includes.
13180         * aarch64-tdep.c: Fix common/ includes.
13181
13182 2019-01-25  Tom Tromey  <tom@tromey.com>
13183
13184         * common/create-version.sh: Use common/version.h.
13185
13186 2019-01-24  Pedro Alves  <palves@redhat.com>
13187
13188         * infrun.c (signal_stop, signal_print, signal_program)
13189         (signal_catch, signal_pass): Now arrays instead of pointers.
13190         (update_signals_program_target, do_target_resume)
13191         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13192         * linux-nat.c (linux_nat_target::pass_signals)
13193         (linux_nat_target::create_inferior, linux_nat_target::attach):
13194         Adjust.
13195         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13196         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13197         * procfs.c (procfs_target::pass_signals): Adjust.
13198         * record-full.c (record_full_target::resume): Adjust.
13199         * remote.c (remote_target::pass_signals)
13200         (remote_target::program_signals): Adjust.
13201         * target-debug.h (target_debug_print_signals): Now takes a
13202         gdb::array_view as parameter.  Adjust.
13203         * target.h (target_ops) <pass_signals, program_signals>: Replace
13204         pointer and length parameters with gdb::array_view.
13205         (target_pass_signals, target_program_signals): Likewise.
13206         * target-delegates.c: Regenerate.
13207
13208 2019-01-24  Pedro Alves  <palves@redhat.com>
13209
13210         * common/forward-scope-exit.h
13211         (forward_scope_exit::forward_scope_exit): Pass arguments to
13212         m_bind_function directly, instead of creating a std::bind and
13213         copying that.
13214
13215 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13216
13217         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13218         for static members.
13219         (pass_in_v_vfp_candidate): Likewise.
13220
13221 2019-01-23  Tom Tromey  <tom@tromey.com>
13222             Pedro Alves  <palves@redhat.com>
13223
13224         * regcache.c (class regcache_invalidator): Remove.
13225         (regcache::raw_write): Use make_scope_exit.
13226
13227 2019-01-23  Tom Tromey  <tom@tromey.com>
13228
13229         * ui-out.h (class ui_out_emit_type): Update comment.
13230
13231 2019-01-23  Tom Tromey  <tom@tromey.com>
13232
13233         * infrun.c (fetch_inferior_event): Update comment.
13234
13235 2019-01-23  Tom Tromey  <tom@tromey.com>
13236             Pedro Alves  <palves@redhat.com>
13237
13238         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13239         parameter.
13240         (fetch_inferior_event): Use SCOPE_EXIT.
13241
13242
13243 2019-01-23  Tom Tromey  <tom@tromey.com>
13244             Pedro Alves  <palves@redhat.com>
13245
13246         * infrun.c (disable_thread_events): Delete.
13247         (stop_all_threads): Use SCOPE_EXIT.
13248
13249 2019-01-23  Tom Tromey  <tom@tromey.com>
13250             Pedro Alves  <palves@redhat.com>
13251
13252         * symfile.c: Include forward-scope-exit.h.
13253         (clear_symtab_users_cleanup): Replace forward declaration with
13254         a FORWARD_SCOPE_EXIT.
13255         (syms_from_objfile_1): Use the forward_scope_exit and
13256         gdb::optional instead of cleanup_function.
13257         (reread_symbols): Use the forward_scope_exit instead of
13258         cleanup_function.
13259         (clear_symtab_users_cleanup): Remove function.
13260
13261 2019-01-23  Tom Tromey  <tom@tromey.com>
13262             Pedro Alves  <palves@redhat.com>
13263
13264         * linux-nat.c: Include scope-exit.h.
13265         (cleanup_target_stop): Remove.
13266         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13267         SCOPE_EXIT.
13268
13269 2019-01-23  Tom Tromey  <tom@tromey.com>
13270             Pedro Alves  <palves@redhat.com>
13271
13272         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13273         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13274
13275 2019-01-23  Tom Tromey  <tom@tromey.com>
13276             Andrew Burgess  <andrew.burgess@embecosm.com>
13277             Pedro Alves  <palves@redhat.com>
13278
13279         * infrun.c (fetch_inferior_event): Use scope_exit.
13280         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13281         * top.c (execute_command): Use scope_exit.
13282         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13283         * utils.c (do_bpstat_clear_actions_cleanup)
13284         (make_bpstat_clear_actions_cleanup): Remove.
13285
13286 2019-01-23  Tom Tromey  <tom@tromey.com>
13287             Pedro Alves  <palves@redhat.com>
13288
13289         * infrun.c: Include "common/scope-exit.h"
13290         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13291         (wait_for_inferior): Use SCOPE_EXIT.
13292         (fetch_inferior_event): Use scope_exit.
13293
13294 2019-01-23  Tom Tromey  <tom@tromey.com>
13295             Pedro Alves  <palves@redhat.com>
13296
13297         * breakpoint.c (create_breakpoint): Remove cleanup.
13298
13299 2019-01-23  Tom Tromey  <tom@tromey.com>
13300             Andrew Burgess  <andrew.burgess@embecosm.com>
13301             Pedro Alves  <palves@redhat.com>
13302
13303 2019-01-23  Pedro Alves  <palves@redhat.com>
13304
13305         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13306
13307 2019-01-23  Pedro Alves  <palves@redhat.com>
13308             Andrew Burgess  <andrew.burgess@embecosm.com>
13309
13310         * gdbthread.h: Include "common/forward-scope-exit.h".
13311         (scoped_finish_thread_state): Redefine custom class in terms of
13312         forward_scope_exit.
13313
13314 2019-01-23  Pedro Alves  <palves@redhat.com>
13315             Andrew Burgess  <andrew.burgess@embecosm.com>
13316
13317         * common/forward-scope-exit.h: New file.
13318
13319 2019-01-23  Pedro Alves  <palves@redhat.com>
13320             Andrew Burgess  <andrew.burgess@embecosm.com>
13321             Tom Tromey  <tom@tromey.com>
13322
13323         * common/scope-exit.h: New file.
13324
13325 2019-01-23  Pedro Alves  <palves@redhat.com>
13326
13327         * common/preprocessor.h (ESC): Rename to ...
13328         (ESC_PARENS): ... this.
13329         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13330         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13331
13332 2019-01-23  Tom Tromey  <tom@tromey.com>
13333
13334         * language.h (class scoped_switch_to_sym_language_if_auto):
13335         Initialize m_lang in both cases.
13336
13337 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13338
13339         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13340         with XCNEW.
13341
13342 2019-01-22  Tom Tromey  <tom@tromey.com>
13343
13344         * corelow.c: Do not include sys/file.h.
13345
13346 2019-01-22  Tom Tromey  <tom@tromey.com>
13347
13348         * tui/tui-wingeneral.h: Include gdb_curses.h.
13349
13350 2019-01-22  Tom Tromey  <tom@tromey.com>
13351
13352         * source-cache.h (class source_cache) <get_source_lines,
13353         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13354
13355 2019-01-22  Tom Tromey  <tom@tromey.com>
13356
13357         * remote-fileio.h (struct remote_target): Declare.
13358
13359 2019-01-22  Tom Tromey  <tom@tromey.com>
13360
13361         * python/py-arch.c: Do not include py-ref.h.
13362         * python/py-bpevent.c: Do not include py-ref.h.
13363         * python/py-cmd.c: Do not include py-ref.h.
13364         * python/py-continueevent.c: Do not include py-ref.h.
13365         * python/py-event.h: Do not include py-ref.h.
13366         * python/py-evtregistry.c: Do not include py-ref.h.
13367         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13368         * python/py-frame.c: Do not include py-ref.h.
13369         * python/py-framefilter.c: Do not include py-ref.h.
13370         * python/py-function.c: Do not include py-ref.h.
13371         * python/py-infevents.c: Do not include py-ref.h.
13372         * python/py-linetable.c: Do not include py-ref.h.
13373         * python/py-objfile.c: Do not include py-ref.h.
13374         * python/py-param.c: Do not include py-ref.h.
13375         * python/py-prettyprint.c: Do not include py-ref.h.
13376         * python/py-progspace.c: Do not include py-ref.h.
13377         * python/py-symbol.c: Do not include py-ref.h.
13378         * python/py-symtab.c: Do not include py-ref.h.
13379         * python/py-type.c: Do not include py-ref.h.
13380         * python/py-unwind.c: Do not include py-ref.h.
13381         * python/py-utils.c: Do not include py-ref.h.
13382         * python/py-value.c: Do not include py-ref.h.
13383         * python/py-varobj.c: Do not include py-ref.h.
13384         * python/py-xmethods.c: Do not include py-ref.h.
13385         * python/python.c: Do not include py-ref.h.
13386         * varobj.c: Do not include py-ref.h.
13387
13388 2019-01-22  Tom Tromey  <tom@tromey.com>
13389
13390         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13391         keyword for bcache.
13392
13393 2019-01-22  Tom Tromey  <tom@tromey.com>
13394
13395         * compile/compile-cplus-types.c: Remove a comment by #include.
13396
13397 2019-01-22  Tom Tromey  <tom@tromey.com>
13398
13399         * compile/gcc-c-plugin.h: Include compile-internal.h.
13400
13401 2019-01-22  Tom Tromey  <tom@tromey.com>
13402
13403         * stabsread.c (EXTERN): Do not define.
13404         (symnum, next_symbol_text_func, processing_gcc_compilation)
13405         (within_function, global_sym_chain, global_stabs)
13406         (previous_stab_code, this_object_header_files)
13407         (n_this_object_header_files)
13408         (n_allocated_this_object_header_files): Define.
13409         * stabsread.h (EXTERN): Never define.  Use "extern".
13410
13411 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13412
13413         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13414         history_value.
13415
13416 2019-01-21  Tom Tromey  <tom@tromey.com>
13417
13418         * ui-out.c: Fix includes.
13419         * tui/tui-source.c: Fix includes.
13420         * target.c: Fix includes.
13421         * remote.c: Fix includes.
13422         * regcache.c: Fix includes.
13423         * python/py-block.c: Fix includes.
13424         * printcmd.c: Fix includes.
13425         * or1k-tdep.c: Fix includes.
13426         * mi/mi-main.c: Fix includes.
13427         * m32r-tdep.c: Fix includes.
13428         * csky-tdep.c: Fix includes.
13429         * compile/compile-cplus-types.c: Fix includes.
13430         * cli/cli-interp.c: Fix includes.
13431
13432 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13433
13434         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13435         for padding.
13436
13437 2019-01-16  Tom Tromey  <tom@tromey.com>
13438
13439         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13440         earlier.
13441         (struct objfile) <msymbols_range>: Move from top level.
13442         <msymbols>: New method.
13443         (class objfile_msymbols): Remove.
13444         * symtab.c (default_collect_symbol_completion_matches_break_on):
13445         Update.
13446         * symmisc.c (dump_msymbols): Update.
13447         * stabsread.c (scan_file_globals): Update.
13448         * objc-lang.c (info_selectors_command, info_classes_command)
13449         (find_methods): Update.
13450         * minsyms.c (find_solib_trampoline_target): Update.
13451         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13452         * coffread.c (coff_symfile_read): Update.
13453         * ada-lang.c (ada_lookup_simple_minsym)
13454         (ada_collect_symbol_completion_matches): Update.
13455
13456 2019-01-16  Tom Tromey  <tom@tromey.com>
13457
13458         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13459         type.  Remove no-argument constructor.
13460         <iterator::operator++>: Simplify.
13461         <begin>: Update.
13462         <end>: Use minimal_symbol_count.
13463
13464 2019-01-16  Tom Tromey  <tom@tromey.com>
13465
13466         * objfiles.h (struct objfile) <psymtabs>: New method.
13467         (class objfile_psymtabs): Remove.
13468         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13469         typedef.
13470         <range>: New method.
13471         (require_partial_symbols): Change return type.
13472         * psymtab.c (require_partial_symbols)
13473         (psym_expand_symtabs_matching): Update.
13474         * mdebugread.c (parse_partial_symbols): Update.
13475         * dbxread.c (dbx_end_psymtab): Update.
13476
13477 2019-01-15  Tom Tromey  <tom@tromey.com>
13478
13479         * symtab.c (lookup_objfile_from_block)
13480         (lookup_symbol_in_objfile_symtabs)
13481         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13482         (find_line_symtab, info_sources_command)
13483         (default_collect_symbol_completion_matches_break_on)
13484         (make_source_files_completion_list): Update.
13485         * symmisc.c (print_objfile_statistics, dump_objfile)
13486         (maintenance_print_symbols, maintenance_info_symtabs)
13487         (maintenance_check_symtabs, maintenance_info_line_tables):
13488         Update.
13489         * source.c (select_source_symtab)
13490         (forget_cached_source_info_for_objfile): Update.
13491         * objfiles.h (class objfile_compunits): Remove.
13492         (struct objfile) <compunits_range>: New typedef.
13493         (compunits): New method.
13494         * objfiles.c (objfile_relocate1): Update.
13495         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13496         * maint.c (count_symtabs_and_blocks): Update.
13497         * linespec.c (iterate_over_all_matching_symtabs): Update.
13498         * cp-support.c (add_symbol_overload_list_qualified): Update.
13499         * coffread.c (coff_symtab_read): Update.
13500         * ada-lang.c (add_nonlocal_symbols)
13501         (ada_collect_symbol_completion_matches)
13502         (ada_add_global_exceptions): Update.
13503
13504 2019-01-15  Tom Tromey  <tom@tromey.com>
13505
13506         * progspace.h (program_space) <objfiles_safe_range>: New
13507         typedef.
13508         <objfiles_safe>: New method.
13509         * objfiles.h (class all_objfiles_safe): Remove.
13510         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13511         * jit.c (jit_inferior_exit_hook): Update.
13512
13513 2019-01-17  Tom Tromey  <tom@tromey.com>
13514
13515         * progspace.h (program_space) <objfiles_range>: New typedef.
13516         <objfiles>: New method.
13517         <objfiles_head>: Rename from objfiles.
13518         (object_files): Update.
13519         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13520         * guile/scm-pretty-print.c
13521         (ppscm_find_pretty_printer_from_objfiles): Update.
13522         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13523         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13524         Update.
13525         * python/py-progspace.c (pspy_get_objfiles): Update.
13526         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13527         Update.
13528         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13529         (objfpy_lookup_objfile_by_build_id): Update.
13530         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13531         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13532         Update.
13533         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13534         (expand_symtab_containing_pc, lookup_objfile_from_block)
13535         (lookup_static_symbol, basic_lookup_transparent_type)
13536         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13537         (find_line_symtab, info_sources_command)
13538         (default_collect_symbol_completion_matches_break_on)
13539         (make_source_files_completion_list, find_main_name): Update.
13540         * symmisc.c (print_symbol_bcache_statistics)
13541         (print_objfile_statistics, maintenance_print_symbols)
13542         (maintenance_print_msymbols, maintenance_print_objfiles)
13543         (maintenance_info_symtabs, maintenance_check_symtabs)
13544         (maintenance_expand_symtabs, maintenance_info_line_tables):
13545         Update.
13546         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13547         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13548         (map_overlay_command, unmap_overlay_command)
13549         (simple_overlay_update, expand_symtabs_matching)
13550         (map_symbol_filenames): Update.
13551         * symfile-debug.c (set_debug_symfile): Update.
13552         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13553         Update.
13554         * source.c (select_source_symtab, forget_cached_source_info):
13555         Update.
13556         * solib.c (solib_read_symbols): Update.
13557         * solib-spu.c (append_ocl_sos): Update.
13558         * psymtab.c (maintenance_print_psymbols)
13559         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13560         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13561         * printcmd.c (info_symbol_command): Update.
13562         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13563         Update.
13564         * objfiles.h (class all_objfiles): Remove.
13565         * objfiles.c (have_partial_symbols, have_full_symbols)
13566         (have_minimal_symbols, qsort_cmp, update_section_map)
13567         (shared_objfile_contains_address_p)
13568         (default_iterate_over_objfiles_in_search_order): Update.
13569         * objc-lang.c (info_selectors_command, info_classes_command)
13570         (find_methods): Update.
13571         * minsyms.c (find_solib_trampoline_target): Update.
13572         * maint.c (maintenance_info_sections)
13573         (maintenance_translate_address, count_symtabs_and_blocks):
13574         Update.
13575         * main.c (captured_main_1): Update.
13576         * linux-thread-db.c (try_thread_db_load_from_pdir)
13577         (has_libpthread): Update.
13578         * linespec.c (iterate_over_all_matching_symtabs)
13579         (search_minsyms_for_name): Update.
13580         * jit.c (jit_find_objf_with_entry_addr): Update.
13581         * hppa-tdep.c (find_unwind_entry)
13582         (hppa_lookup_stub_minimal_symbol): Update.
13583         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13584         Update.
13585         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13586         (elf_gnu_ifunc_resolve_by_got): Update.
13587         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13588         * dwarf-index-write.c (save_gdb_index_command): Update.
13589         * cp-support.c (add_symbol_overload_list_qualified): Update.
13590         * breakpoint.c (create_overlay_event_breakpoint)
13591         (create_longjmp_master_breakpoint)
13592         (create_std_terminate_master_breakpoint)
13593         (create_exception_master_breakpoint): Update.
13594         * blockframe.c (find_pc_partial_function): Update.
13595         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13596         (ada_collect_symbol_completion_matches)
13597         (ada_add_global_exceptions): Update.
13598
13599 2019-01-17  Tom Tromey  <tom@tromey.com>
13600
13601         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13602         declare VEC.
13603         (solib_target_parse_libraries): Change return type.
13604         (library_list_start_segment, library_list_start_section)
13605         (library_list_end_library, library_list_start_library); Update.
13606         (solib_target_free_library_list): Remove.
13607         (solib_target_parse_libraries): Remove cleanup.  Change return
13608         type.
13609         (solib_target_current_sos): Update.
13610
13611 2019-01-17  Tom Tromey  <tromey@bapiya>
13612
13613         * valprint.c: Replace "the the" with "the".
13614         * symtab.c: Replace "the the" with "the".
13615         * solib.c: Replace "the the" with "the".
13616         * solib-dsbt.c: Replace "the the" with "the".
13617         * linespec.c: Replace "the the" with "the".
13618         * dwarf2loc.h: Replace "the the" with "the".
13619         * amd64-windows-tdep.c: Replace "the the" with "the".
13620         * aarch64-tdep.c: Replace "the the" with "the".
13621
13622 2019-01-16  Keith Seitz  <keiths@redhat.com>
13623
13624         PR gdb/23773
13625         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13626         <builder>: Rename to ..
13627         <m_builder>: ... this and make private.
13628         (dwarf2_cu::get_builder): New method.  Change all users of
13629         `builder' to use this method.
13630         (dwarf2_start_symtab): Move to ...
13631         (dwarf2_cu::start_symtab): ... here.  Update all callers
13632         (setup_type_unit_groups): Move to ...
13633         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13634         callers.
13635         (dwarf2_cu::reset_builder): New method.
13636         (process_full_compunit, process_full_type_unit): Use
13637         dwarf2_cu::reset_builder.
13638         (follow_die_offset): Record the ancestor CU if it is different
13639         from the followed DIE's CU.
13640         (follow_die_sig_1): Likewise.
13641
13642 2019-01-15  Tom Tromey  <tom@tromey.com>
13643
13644         * remote.c (class remote_state) <buf>: Now a char_vector.
13645         <buf_size>: Remove.
13646         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13647         parameter.
13648         (remote_target::getpkt_or_notif_sane_1)
13649         (remote_target::getpkt_sane)
13650         (remote_target::getpkt_or_notif_sane): Likewise.
13651         (class remote_target) <putpkt>: New overload.
13652         (remote_target::read_frame): Change type of "buf_p".  Remove
13653         sizeof_p parameter.
13654         (packet_ok): New overload.
13655         (packet_check_result): New overload.
13656         Update all uses.
13657
13658 2019-01-14  Tom Tromey  <tom@tromey.com>
13659
13660         * remote-notif.c (handle_notification, remote_notif_ack)
13661         (remote_notif_parse): Make "buf" const.
13662         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13663         const.
13664         (remote_notif_parse, remote_notif_ack, handle_notification):
13665         Likewise.
13666         * remote.c (remote_notif_stop_parse): Make "buf" const.
13667         (remote_target::remote_parse_stop_reply): Make "buf" const.
13668         (remote_notif_stop_ack): Make "buf" const.
13669
13670 2019-01-14  Tom Tromey  <tom@tromey.com>
13671
13672         * remote.c (remote_console_output): Make parameter const.
13673
13674 2019-01-14  Tom Tromey  <tom@tromey.com>
13675
13676         * target-debug.h (target_debug_print_signals): Constify.
13677         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13678         * procfs.c (procfs_target::pass_signals): Update.
13679         * linux-nat.c (linux_nat_target::pass_signals): Update.
13680         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13681         * target-delegates.c: Rebuild.
13682         * remote.c (remote_target::program_signals): Update.
13683         (remote_target::pass_signals): Update.
13684         * target.c (target_pass_signals): Constify argument.
13685         (target_program_signals): Likewise.
13686         * target.h (struct target_ops) <pass_signals, program_signals>:
13687         Constify argument.
13688         (target_pass_signals, target_program_signals): Constify argument.
13689
13690 2019-01-14  Tom Tromey  <tom@tromey.com>
13691
13692         PR tui/28819:
13693         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13694
13695 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13696
13697         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13698         field.
13699         * rs6000-tdep.c: Include reggroups.h.
13700         (IS_V_ALIAS_PSEUDOREG): Define.
13701         (rs6000_register_name): Return names for the "vX" aliases.
13702         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13703         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13704         aliases.  Call default_register_reggroup_p for all other
13705         pseudo-registers.
13706         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13707         New functions.
13708         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13709         Handle "vX" aliases.
13710         (v_alias_pseudo_register_collect): New function.
13711         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13712         (rs6000_gdbarch_init): Initialize "vX" aliases as
13713         pseudo-registers.  Restore registration of
13714         rs6000_pseudo_register_reggroup_p with
13715         set_tdesc_pseudo_register_reggroup_p.
13716
13717 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13718
13719         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13720         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13721         set_gdbarch_num_pseudo_regs.
13722
13723 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13724
13725         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13726         Remove arg prefixname, add do_set and do_show.
13727         Add member functions set_list and show_list.
13728         * cli/cli-style.c (class cli_style_option): Update accordingly.
13729         (style_set_list): Move to file scope.
13730         (style_show_list): Likewise.
13731         (set_style): Call help_list.
13732         (show_style): Call cmd_show_list.
13733         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13734         Update to use the new macro.
13735
13736 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13737
13738         * ada-lang.c (_initialize_ada_language): Expand the help text
13739         for the "catch exception" command.
13740
13741 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13742
13743         * symtab.c (matching_obj_sections): Initialize obj,
13744         declare it closer to its usage.
13745
13746 2019-01-10  Tom Tromey  <tom@tromey.com>
13747
13748         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13749         (basic_inf_threads_range): Remove.
13750         (inf_threads_range, inf_non_exited_threads_range)
13751         (safe_inf_threads_range): Use next_adapter.
13752
13753 2019-01-10  Keith Seitz  <keiths@redhat.com>
13754
13755         PR gdb/23712
13756         PR symtab/23010
13757         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13758         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13759
13760 2019-01-10  Keith Seitz  <keiths@redhat.com>
13761
13762         PR gdb/23712
13763         PR symtab/23010
13764         * dictionary.c (pending_to_vector): Remove.
13765         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13766         Remove _1 suffix, replacing functions of the same name.  Update
13767         all callers.
13768         (dict_create_hashed, dict_create_hashed_expandable)
13769         (dict_create_linear, dict_create_linear_expandable, dict_free)
13770         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13771         Make functions static.
13772
13773 2019-01-10  Keith Seitz  <keiths@redhat.com>
13774
13775         PR gdb/23712
13776         PR symtab/23010
13777         * dictionary.h (struct dictionary): Replace declaration with
13778         multidictionary.
13779         (dict_create_hashed, dict_create_hashed_expandable)
13780         (dict_create_linear, dict_create_linear_expandable)
13781         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13782         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13783         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13784         taking multidictionary argument.
13785         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13786         * block.h (struct block) <dict>: Change to multidictionary
13787         and rename `multidict'.
13788         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13789         symmisc.c: Update all dictionary references to multidictionary.
13790
13791 2019-01-10  Keith Seitz  <keiths@redhat.com>
13792
13793         PR gdb/23712
13794         PR symtab/23010
13795         * dictionary.c: Include unordered_map.
13796         (pending_to_vector): New function.
13797         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13798         Rewrite the non-"_1" functions to take vector instead
13799         of linked list.
13800         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13801         "new" _1 versions of the same name.
13802         (multidictionary): Define.
13803         (std::hash<enum language): New definition.
13804         (collate_pending_symbols_by_language, mdict_create_hashed)
13805         (mdict_create_hashed_expandable, mdict_create_linear)
13806         (mdict_create_linear_expandable, mdict_free)
13807         (find_language_dictionary, create_new_language_dictionary)
13808         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13809         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13810         (mdict_size, mdict_empty): New functions.
13811         * dictionary.h (mdict_iterator): Define.
13812
13813 2019-01-10  Pedro Alves  <palves@redhat.com>
13814
13815         * breakpoint.c (read_uploaded_action)
13816         (create_tracepoint_from_upload): Adjust to use
13817         gdb::unique_xmalloc_ptr.
13818         * ctf.c (ctf_write_uploaded_tp):
13819         (SET_ARRAY_FIELD): Use emplace_back.
13820         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13821         * tracefile-tfile.c (tfile_write_uploaded_tp):
13822         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13823         gdb::unique_xmalloc_ptr.
13824         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13825         at_string, cond_string, cmd_strings>: Replace char pointers
13826         with gdb::unique_xmalloc_ptr.
13827
13828 2019-01-10  Pedro Alves  <palves@redhat.com>
13829
13830         * solib-target.c (library_list_start_library): Don't xstrdup name.
13831
13832 2019-01-10  Pedro Alves  <palves@redhat.com>
13833
13834         * mdebugread.c (parse_partial_symbols): Use
13835         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13836
13837 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13838
13839         * linux-fork.c (scoped_switch_fork_info)
13840         <~scoped_switch_fork_info>: Fix incorrect variable name.
13841
13842 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13843
13844         * linux-fork.c (scoped_switch_fork_info)
13845         <scoped_switch_fork_info>: Make explicit.
13846         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13847
13848 2019-01-10  Tom Tromey  <tom@tromey.com>
13849
13850         * objfiles.h (objfile::reset_psymtabs): Update.
13851         * objfiles.c (objfile::objfile): Update.
13852         * psymtab.h (psymtab_storage::obstack): Update.
13853         (psymtab_storage::m_obstack): Use gdb::optional.
13854         (class psymtab_storage): Update comment.  Remove objfile
13855         parameter.
13856         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13857
13858 2019-01-10  Tom Tromey  <tom@tromey.com>
13859
13860         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13861         <free_psymtabs>: Now private.
13862         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13863         (allocate_psymtab): Use new method.
13864
13865 2019-01-10  Tom Tromey  <tom@tromey.com>
13866
13867         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13868         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13869         * mdebugread.c (parse_partial_symbols): Use
13870         allocate_dependencies.
13871         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13872         allocate_dependencies.
13873         (process_psymtab_comp_unit_reader)
13874         (build_type_psymtab_dependencies): Likewise.
13875         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13876
13877 2019-01-10  Tom Tromey  <tom@tromey.com>
13878
13879         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13880         PSYMBOL_SET_LANGUAGE.
13881         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13882
13883 2019-01-10  Tom Tromey  <tom@tromey.com>
13884
13885         * psymtab.h (psymtab_storage::obstack): New method.
13886         <m_obstack>: Rename from obstack; now private.
13887         * psymtab.c (psymtab_storage): Update.
13888         * dwarf2read.c (create_addrmap_from_index)
13889         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13890         Update.
13891
13892 2019-01-10  Tom Tromey  <tom@tromey.com>
13893
13894         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13895         * objfiles.h (objfile::reset_psymtabs): New method.
13896
13897 2019-01-10  Tom Tromey  <tom@tromey.com>
13898
13899         * symmisc.c (print_symbol_bcache_statistics): Update.
13900         (print_objfile_statistics): Update.
13901         * symfile.c (reread_symbols): Update.
13902         * psymtab.h (class psymtab_storage): New.
13903         * psymtab.c (psymtab_storage): New constructor.
13904         (~psymtab_storage): New destructor.
13905         (require_partial_symbols): Update.
13906         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13907         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13908         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13909         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13910         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13911         (start_psymtab_common, end_psymtab_common)
13912         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13913         (allocate_psymtab): Update.
13914         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13915         Update.
13916         (dump_psymtab_addrmap, maintenance_print_psymbols)
13917         (maintenance_check_psymtabs): Update.
13918         (class objfile_psymtabs): Move to objfiles.h.
13919         * psympriv.h (discard_psymtab): Now inline.
13920         (psymtab_discarder::psymtab_discarder): Update.
13921         (psymtab_discarder::~psymtab_discarder): Update.
13922         (ALL_OBJFILE_PSYMTABS): Rewrite.
13923         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13924         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13925         Remove fields.
13926         <partial_symtabs>: New field.
13927         (class objfile_psymtabs): Move from psymtab.h.  Update.
13928         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13929         psymbol_cache.
13930         (objfile::~objfile): Don't destroy psymbol_cache.
13931         * mdebugread.c (parse_partial_symbols): Update.
13932         * dwarf2read.c (create_addrmap_from_index)
13933         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13934         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13935         (add_partial_subprogram, dwarf2_ranges_read): Update.
13936         * dwarf-index-write.c (write_address_map)
13937         (write_one_signatured_type, recursively_write_psymbols)
13938         (class debug_names, class debug_names, write_psymtabs_to_index):
13939         Update.
13940
13941 2019-01-10  Tom Tromey  <tom@tromey.com>
13942
13943         * symtab.h (SYMBOL_SET_NAMES): Update.
13944         (symbol_set_names): Update.
13945         (MSYMBOL_SET_NAMES): Update.
13946         * symtab.c (symbol_set_names): Change argument to be an
13947         objfile_per_bfd_storage.
13948         * psymtab.c (add_psymbol_to_bcache): Update.
13949         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13950
13951 2019-01-10  Tom Tromey  <tom@tromey.com>
13952
13953         * symtab.c (create_demangled_names_hash): Change argument to be an
13954         objfile_per_bfd_storage.
13955         (symbol_set_names): Update.
13956
13957 2019-01-10  Tom Tromey  <tom@tromey.com>
13958
13959         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13960         init_psymbol_list.
13961         * psymtab.c (init_psymbol_list): Do nothing if already called.
13962         * psympriv.h (init_psymbol_list): Add comment.
13963         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13964         init_psymbol_list.
13965         * dbxread.c (dbx_symfile_read): Unconditionally call
13966         init_psymbol_list.
13967
13968 2019-01-10  Tom Tromey  <tom@tromey.com>
13969
13970         * xcoffread.c (scan_xcoff_symtab): Update.
13971         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13972         "where".
13973         * mdebugread.c (parse_partial_symbols)
13974         (handle_psymbol_enumerators): Update.
13975         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13976         * dbxread.c (read_dbx_symtab): Update.
13977         * psympriv.h (psymbol_placement): New enum.
13978         (add_psymbol_to_list): Update.
13979
13980 2019-01-10  Tom Tromey  <tom@tromey.com>
13981
13982         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13983         static_psymbols parameters.
13984         (scan_xcoff_symtab): Update.
13985         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13986         static_psymbols parameters.
13987         * psympriv.h (start_psymtab_common): Update.
13988         * mdebugread.c (parse_partial_symbols): Update.
13989         * dwarf2read.c (create_partial_symtab): Update.
13990         * dbxread.c (read_dbx_symtab): Update.
13991         (start_psymtab): Remove global_psymbols and static_psymbols
13992         parameters.
13993
13994 2019-01-10  Tom Tromey  <tom@tromey.com>
13995
13996         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13997         * psymtab.c (allocate_psymtab): Add comment.
13998         * psympriv.h (allocate_psymtab): Add comment.
13999         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14000         initializations.
14001         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14002
14003 2019-01-10  Tom Tromey  <tom@tromey.com>
14004
14005         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14006         Don't declare.
14007         * mipsread.c: Include mdebugread.h.
14008         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14009         Declare.
14010         * elfread.c: Include mdebugread.h.
14011
14012 2019-01-09  Tom Tromey  <tom@tromey.com>
14013
14014         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14015         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14016         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14017         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14018         (psym_lookup_symbol, psym_find_last_source_symtab)
14019         (psym_forget_cached_source_info, psym_print_stats)
14020         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14021         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14022         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14023         (psym_find_compunit_symtab_by_address)
14024         (maintenance_print_psymbols, maintenance_info_psymtabs)
14025         (maintenance_check_psymtabs): Use ranged for.
14026         * psymtab.h (class objfile_psymtabs): New.
14027         (require_partial_symbols): Return objfile_psymtabs.
14028         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14029
14030 2019-01-09  Tom Tromey  <tom@tromey.com>
14031
14032         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14033         (find_pc_mapped_section, list_overlays_command)
14034         (map_overlay_command, unmap_overlay_command)
14035         (simple_overlay_update): Use all_objfiles.
14036         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14037         * printcmd.c (info_symbol_command): Use all_objfiles.
14038         * objfiles.h (ALL_OBJSECTIONS): Remove.
14039         * maint.c (maintenance_translate_address): Use all_objfiles.
14040         * gcore.c (gcore_create_callback): Use all_objfiles.
14041         (objfile_find_memory_regions): Likewise.
14042
14043 2019-01-09  Tom Tromey  <tom@tromey.com>
14044
14045         * symtab.c (find_line_symtab, info_sources_command)
14046         (make_source_files_completion_list): Use objfile_compunits.
14047         * source.c (select_source_symtab): Use objfile_compunits.
14048         * objfiles.h (struct objfile): Update comment.
14049         (ALL_OBJFILES): Remove.
14050         (ALL_FILETABS): Remove.
14051         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14052         objfile_compunits.
14053
14054 2019-01-09  Tom Tromey  <tom@tromey.com>
14055
14056         * symmisc.c (print_objfile_statistics, dump_objfile)
14057         (maintenance_print_symbols): Use compunit_filetabs.
14058         * source.c (forget_cached_source_info_for_objfile): Use
14059         compunit_filetabs.
14060         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14061         (ALL_FILETABS): Use compunit_filetabs.
14062         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14063         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14064
14065 2019-01-09  Tom Tromey  <tom@tromey.com>
14066
14067         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14068         (compunit_filetabs): New.
14069         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14070         compunit_filetabs.
14071         (info_sources_command, make_source_files_completion_list): Remove
14072         declaration.
14073         * symmisc.c (print_objfile_statistics, dump_objfile)
14074         (maintenance_print_symbols): Remove declaration.
14075         (maintenance_info_symtabs): Use compunit_filetabs.
14076         (maintenance_info_line_tables): Likewise.
14077         * source.c (select_source_symtab): Change local variable name.
14078         (forget_cached_source_info_for_objfile): Remove declaration.
14079         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14080         * objfiles.c (objfile_relocate1): Remove declaration.
14081         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14082         declaration.
14083         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14084         * coffread.c (coff_symtab_read): Remove declaration.
14085         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14086         compunit_filetabs.
14087
14088 2019-01-09  Tom Tromey  <tom@tromey.com>
14089
14090         * symtab.c (lookup_objfile_from_block)
14091         (find_pc_sect_compunit_symtab, search_symbols)
14092         (default_collect_symbol_completion_matches_break_on): Use
14093         objfile_compunits.
14094         * objfiles.h (ALL_COMPUNITS): Remove.
14095         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14096         * cp-support.c (add_symbol_overload_list_qualified): Use
14097         objfile_compunits.
14098         * ada-lang.c (ada_collect_symbol_completion_matches)
14099         (ada_add_global_exceptions): Use objfile_compunits.
14100
14101 2019-01-09  Tom Tromey  <tom@tromey.com>
14102
14103         * source.c (select_source_symtab)
14104         (forget_cached_source_info_for_objfile): Remove declaration.
14105         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14106         declaration.
14107         * maint.c (count_symtabs_and_blocks): Remove declaration.
14108         * cp-support.c (add_symbol_overload_list_qualified): Remove
14109         declaration.
14110         * coffread.c (coff_symtab_read): Remove declaration.
14111         * symtab.c (lookup_symbol_in_objfile_symtabs)
14112         (basic_lookup_transparent_type_1): Use objfile_compunits.
14113         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14114         (info_sources_command, search_symbols)
14115         (default_collect_symbol_completion_matches_break_on)
14116         (make_source_files_completion_list): Remove declaration.
14117         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14118         (ada_collect_symbol_completion_matches)
14119         (ada_add_global_exceptions): Remove declaration.
14120         * linespec.c (iterate_over_all_matching_symtabs): Use
14121         objfile_compunits.
14122         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14123         (class objfile_compunits): New.
14124         (ALL_COMPUNITS): Use objfile_compunits.
14125         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14126         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14127         objfile_compunits.
14128         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14129
14130 2019-01-09  Tom Tromey  <tom@tromey.com>
14131
14132         * symtab.c (search_symbols)
14133         (default_collect_symbol_completion_matches_break_on): Use
14134         objfile_msymbols.
14135         * ada-lang.c (ada_lookup_simple_minsym)
14136         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14137         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14138         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14139         objfile_msymbols.
14140         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14141         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14142         * objc-lang.c (find_methods): Use objfile_msymbols.
14143         (info_selectors_command, info_classes_command): Likewise.
14144         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14145         * objfiles.h (class objfile_msymbols): New.
14146         (ALL_OBJFILE_MSYMBOLS): Remove.
14147         (ALL_MSYMBOLS): Remove.
14148
14149 2019-01-09  Tom Tromey  <tom@tromey.com>
14150
14151         * common/next-iterator.h (next_adapter): Add Iterator template
14152         parameter.
14153         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14154         (class all_objfiles_safe): New.
14155         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14156         * objfiles.c (put_objfile_before): Update comment.
14157         (add_separate_debug_objfile): Likewise.
14158         (free_all_objfiles): Use all_objfiles_safe.
14159         (objfile_purge_solibs): Likewise.
14160
14161 2019-01-09  Tom Tromey  <tom@tromey.com>
14162
14163         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14164         (expand_symtab_containing_pc, lookup_static_symbol)
14165         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14166         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14167         all_objfiles.
14168         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14169         * breakpoint.c (create_overlay_event_breakpoint)
14170         (create_longjmp_master_breakpoint)
14171         (create_std_terminate_master_breakpoint)
14172         (create_exception_master_breakpoint): Use all_objfiles.
14173         * linux-thread-db.c (try_thread_db_load_from_pdir)
14174         (has_libpthread): Use all_objfiles.
14175         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14176         * linespec.c (iterate_over_all_matching_symtabs)
14177         (search_minsyms_for_name): Use all_objfiles.
14178         * maint.c (maintenance_info_sections): Use all_objfiles.
14179         * main.c (captured_main_1): Use all_objfiles.
14180         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14181         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14182         * guile/scm-pretty-print.c
14183         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14184         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14185         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14186         (maintenance_print_msymbols): Use all_objfiles.
14187         * source.c (select_source_symtab): Use all_objfiles.
14188         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14189         * symfile.c (remove_symbol_file_command)
14190         (expand_symtabs_matching, map_symbol_filenames): Use
14191         all_objfiles.
14192         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14193         all_objfiles.
14194         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14195         * objc-lang.c (find_methods): Use all_objfiles.
14196         * objfiles.c (have_partial_symbols, have_full_symbols)
14197         (have_minimal_symbols, qsort_cmp)
14198         (default_iterate_over_objfiles_in_search_order): Use
14199         all_objfiles.
14200         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14201         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14202         (maintenance_check_psymtabs): Use all_objfiles.
14203         (ALL_PSYMTABS): Remove.
14204         * compile/compile-object-run.c (do_module_cleanup): Use
14205         all_objfiles.
14206         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14207         * cp-support.c (add_symbol_overload_list_qualified): Use
14208         all_objfiles.
14209         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14210         Use all_objfiles.
14211         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14212         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14213         all_objfiles.
14214         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14215         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14216         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14217         Uses all_objfiles.
14218         * solib.c (solib_read_symbols): Use all_objfiles
14219
14220 2019-01-09  Tom Tromey  <tom@tromey.com>
14221
14222         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14223         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14224         all_objfiles.
14225         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14226         * symmisc.c (print_symbol_bcache_statistics)
14227         (print_objfile_statistics, maintenance_print_objfiles)
14228         (maintenance_info_symtabs, maintenance_check_symtabs)
14229         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14230         all_objfiles.
14231         * source.c (forget_cached_source_info): Use all_objfiles.
14232         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14233         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14234         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14235         * objfiles.c (update_section_map): Use all_objfiles.
14236         (shared_objfile_contains_address_p): Likewise.
14237         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14238         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14239
14240 2019-01-09  Tom Tromey  <tom@tromey.com>
14241
14242         * common/next-iterator.h: New file.
14243         * objfiles.h (class all_objfiles): New.
14244         (struct objfile_iterator): New.
14245
14246 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14247
14248         * NEWS: Move the description of the changed "frame", "select-frame",
14249          and "info frame" commands to the Changed commands section.
14250
14251 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14252
14253         * gdbtypes.c (check_stub_method_group): Remove handling of old
14254         mangling schemes.
14255         * linespec.c (find_methods): Likewise.
14256         * stabsread.c (read_member_functions): Likewise.
14257         * valops.c (search_struct_method): Likewise.
14258         (value_struct_elt_for_reference): Likewise.
14259         * NEWS: Mention this change.
14260
14261 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14262
14263         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14264         print_source_lines.
14265         * source.c (print_source_lines_base): Update line number check.
14266         (print_source_lines): New function.
14267         (source_lines_range::source_lines_range): New function.
14268         * source.h (class source_lines_range): New class.
14269         (print_source_lines): New declaration.
14270
14271 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14272
14273         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14274
14275 2019-01-08  Tom Tromey  <tom@tromey.com>
14276             Simon Marchi  <simon.marchi@ericsson.com>
14277
14278         PR gdb/24060
14279         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14280         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14281         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14282         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14283         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14284         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14285
14286 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14287
14288         * source.c (select_source_symtab): Move header comment to
14289         declaration in source.h.
14290         (forget_cached_source_info_for_objfile): Likewise.
14291         (forget_cached_source_info): Likewise.
14292         (identify_source_line): Likewise.
14293         * source.h (identify_source_line): Move declaration from symtab.h
14294         and add comment from source.c
14295         (print_source_lines): Likewise.
14296         (forget_cached_source_info_for_objfile): Likewise.
14297         (forget_cached_source_info): Likewise.
14298         (select_source_symtab): Likewise.
14299         (enum print_source_lines_flag): Move definition from symtab.h.
14300         * symtab.h (identify_source_line): Move declaration to source.h.
14301         (print_source_lines): Likewise.
14302         (forget_cached_source_info_for_objfile): Likewise.
14303         (forget_cached_source_info): Likewise.
14304         (select_source_symtab): Likewise.
14305         (enum print_source_lines_flag): Move definition to source.h.
14306         * tui/tui-hooks.c: Add 'source.h' include.
14307
14308 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14309
14310         * source.c (print_source_lines_base): Handle requests to print
14311         reverse line number sequences, and guard against empty lines
14312         string.
14313
14314 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14315
14316         * source.c (print_source_lines_base): Fix skip of '\r' if next
14317         character is '\n'.
14318
14319 2019-01-06  Tom Tromey  <tom@tromey.com>
14320
14321         * c-exp.y (struct c_parse_state) <macro_original_text,
14322         expansion_obstack>: New member.
14323         (macro_original_text, expansion_obstack): Remove globals.
14324         (scan_macro_expansion, scanning_macro_expansion)
14325         (finished_macro_expansion): Update.
14326         (scan_macro_cleanup): Remove.
14327         (yylex, c_parse): Update.
14328
14329 2019-01-06  Tom Tromey  <tom@tromey.com>
14330
14331         * c-exp.y (struct c_parse_state) <strings>: New member.
14332         (operator_stoken): Update.
14333
14334 2019-01-06  Tom Tromey  <tom@tromey.com>
14335
14336         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14337         (union type_stack_elt) <typelist_val>: Now a pointer to
14338         std::vector.
14339         (type_stack_cleanup): Don't declare.
14340         (push_typelist): Update.
14341         * parse.c (pop_typelist): Return a std::vector.
14342         (push_typelist): Take a std::vector.
14343         (follow_types): Update.  Do not free args.
14344         (type_stack_cleanup): Remove.
14345         * c-exp.y (struct c_parse_state): New.
14346         (cpstate): New global.
14347         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14348         (nonempty_typelist): Update.
14349         (func_mod): Create a new vector.
14350         (c_parse): Create a c_parse_state.
14351         (check_parameter_typelist): Do not delete params.
14352         (function_method): Update.  Do not delete type_list.
14353
14354 2019-01-06  Tom Tromey  <tom@tromey.com>
14355
14356         PR gdb/28155:
14357         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14358         check_typedef.
14359         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14360         (print_return_value): Likewise.
14361
14362 2019-01-05  Tom Tromey  <tom@tromey.com>
14363
14364         * contrib/cleanup_check.py: Remove.
14365         * contrib/gcc-with-excheck: Remove.
14366         * contrib/exsummary.py: Remove.
14367         * contrib/excheck.py: Remove.
14368
14369 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14370
14371         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14372         NULL. Initialize tpprev to NULL instead of assigning it
14373         to NULL on the next statement.
14374         * windows-nat.c (windows_delete_thread): Remove check for
14375         main_thread_id before printing thread exit notifications.
14376         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14377         Remove thread ID check against main_thread_id.
14378         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14379         windows_delete_thread.
14380         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14381
14382 2019-01-04  Tom Tromey  <tom@tromey.com>
14383
14384         * compile/compile.c (_initialize_compile): Use upper case for
14385         metasyntactic variables.
14386         * symmisc.c (_initialize_symmisc): Use upper case for
14387         metasyntactic variables.
14388         * psymtab.c (_initialize_psymtab): Use upper case for
14389         metasyntactic variables.
14390         * demangle.c (demangle_command): Use upper case for metasyntactic
14391         variables.
14392         (_initialize_demangler): Likewise.
14393         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14394         variables.
14395
14396 2019-01-03  Tom Tromey  <tom@tromey.com>
14397
14398         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14399
14400 2019-01-03  Tom Tromey  <tom@tromey.com>
14401
14402         * python/py-symtab.c (salpy_str): Update.
14403         (struct salpy_sal_object) <symtab>: Now a PyObject.
14404         (salpy_dealloc): Update.
14405         (del_objfile_sal): Use gdbpy_ref.
14406
14407 2019-01-03  Tom Tromey  <tom@tromey.com>
14408
14409         * python/py-type.c (convert_field): Use new_reference.  Return
14410         gdbpy_ref.
14411         (make_fielditem): Return gdbpy_ref.
14412         (typy_fields): Update.
14413         (typy_getitem): Update.
14414         (field_name): Return gdbpy_ref.  Use new_reference.
14415         (typy_iterator_iternext): Update.
14416
14417 2019-01-03  Tom Tromey  <tom@tromey.com>
14418
14419         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14420
14421 2019-01-03  Tom Tromey  <tom@tromey.com>
14422
14423         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14424         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14425         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14426         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14427         (pspy_set_type_printers): Likewise.
14428         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14429         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14430         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14431         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14432         (objfpy_set_type_printers): Likewise.
14433
14434 2019-01-03  Tom Tromey  <tom@tromey.com>
14435
14436         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14437         (gdbpy_print_stack): Use gdbpy_err_fetch.
14438         * python/python-internal.h (class gdbpy_err_fetch): New class.
14439         (class gdbpy_enter) <m_error_type, m_error_value,
14440         m_error_traceback>: Remove.
14441         <m_error>: New member.
14442         (gdbpy_exception_to_string): Don't declare.
14443         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14444         * python/py-value.c (convert_value_from_python): Use
14445         gdbpy_err_fetch.
14446         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14447         gdbpy_exception_to_string.
14448         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14449         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14450         gdbpy_err_fetch.
14451
14452 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14453
14454         * linux-nat.c (delete_lwp_cleanup): Delete.
14455         (struct lwp_deleter): New struct.
14456         (lwp_info_up): New typedef.
14457         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14458         lwp_info_up.
14459
14460 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14461
14462         * linux-fork.c (class scoped_switch_fork_info): New class.
14463         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14464
14465 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14466
14467         * valops.c (find_overload_match): Remove use of null_cleanup, and
14468         calls to do_cleanups.
14469
14470 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14471
14472         * compile/compile-cplus-types.c
14473         (compile_cplus_instance::decl_name): Handle changes to
14474         cp_func_name.
14475         * cp-support.c (cp_func_name): Update header comment, update
14476         return type.
14477         * cp-support.h (cp_func_name): Update return type in declaration.
14478         * valops.c (find_overload_match): Move temp_func local to top
14479         level of function and change its type.  Use temp_func to hold and
14480         delete temporary string obtained from cp_func_name.
14481
14482 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14483
14484         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14485         gdb::char_vector, remove cleanup, and update uses of `msg`.
14486
14487 2019-01-03  Jim Wilson  <jimw@sifive.com>
14488
14489         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14490
14491 2019-01-02  Tom Tromey  <tom@tromey.com>
14492
14493         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14494         (tdesc_parse_xml): Remove cleanups.
14495         * target-descriptions.h (make_cleanup_free_target_description):
14496         Don't declare.
14497         (target_desc_deleter): New struct.
14498         (target_desc_up): New typedef.
14499         * target-descriptions.c (target_desc_deleter::operator()): Rename
14500         from free_target_description.
14501         (make_cleanup_free_target_description): Remove.
14502
14503 2019-01-02  Tom Tromey  <tom@tromey.com>
14504
14505         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14506         constructor, destructor.
14507         (linespec_parser): Remove typedef.
14508         (~linespec_parser): Rename from linespec_parser_delete.
14509         (linespec_lex_to_end, linespec_complete_label)
14510         (linespec_complete): Update.
14511         (decode_line_full): Remove cleanups.
14512         (decode_line_1): Update.
14513
14514 2019-01-02  Tom Tromey  <tom@tromey.com>
14515
14516         * python/python-internal.h (inferior_to_inferior_object): Change
14517         return type.
14518         * python/py-exitedevent.c (create_exited_event_object): Update.
14519         * python/py-inferior.c (inferior_to_inferior_object): Return
14520         gdbpy_ref.
14521         (python_new_inferior, python_inferior_deleted)
14522         (thread_to_thread_object, delete_thread_object)
14523         (build_inferior_list, gdbpy_selected_inferior): Update.
14524         * python/py-infthread.c (create_thread_object): Update.  Also fail
14525         if inferior_to_inferior_object fails.
14526
14527 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14528
14529         * inferior.h (class inferior) <displaced_step_state>: New field.
14530         * infrun.h (struct displaced_step_state): Move here from
14531         infrun.c.  Initialize fields, add constructor.
14532         <inf>: Remove field.
14533         <reset>: New method.
14534         * infrun.c (struct displaced_step_inferior_state): Move to
14535         infrun.h.
14536         (displaced_step_inferior_states): Remove.
14537         (get_displaced_stepping_state): Adust.
14538         (displaced_step_in_progress_any_inferior): Adjust.
14539         (displaced_step_in_progress_thread): Adjust.
14540         (displaced_step_in_progress): Adjust.
14541         (add_displaced_stepping_state): Remove.
14542         (get_displaced_step_closure_by_addr): Adjust.
14543         (remove_displaced_stepping_state): Remove.
14544         (infrun_inferior_exit): Call displaced_step_state.reset.
14545         (use_displaced_stepping): Don't check for NULL.
14546         (displaced_step_prepare_throw): Call
14547         get_displaced_stepping_state.
14548         (displaced_step_fixup): Don't check for NULL.
14549         (prepare_for_detach): Don't check for NULL.
14550
14551 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14552
14553         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14554          in case of call that did not complete.
14555
14556 2019-01-02  Andrey Utkin  <autkin@undo.io>
14557
14558         * symfile.c (find_separate_debug_file): Fix search of debug files for
14559         remote debuggee.
14560
14561 2019-01-02  Tom Tromey  <tom@tromey.com>
14562
14563         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14564         indentation.
14565         * python/py-frame.c (frapy_older): Remove cast.
14566         (frapy_newer): Likewise.
14567         * python/py-breakpoint.c (local_setattro): Remove cast.
14568         * python/py-arch.c (archpy_name): Remove local variable.
14569         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14570
14571 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14572
14573         * unittests/basic_string_view/element_access/char/empty.cc:
14574         Fix year range in copyright header.
14575
14576 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14577
14578         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14579         Delete.
14580         <operator==>: Update with for removed field.
14581         <hash>: Likewise.
14582         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14583         <isa_features>: ...this.
14584         <abi_features>: New field.
14585         (riscv_isa_flen): Update comment.
14586         (riscv_abi_xlen): New declaration.
14587         (riscv_abi_flen): New declaration.
14588         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14589         isa_features.
14590         (riscv_abi_xlen): New function.
14591         (riscv_isa_flen): Update to get answer from isa_features.
14592         (riscv_abi_flen): New function.
14593         (riscv_has_fp_abi): Update to get answer from abi_features.
14594         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14595         xlen and flen.
14596         (riscv_call_info) <xlen, flen>: Update comment.
14597         (riscv_call_arg_struct): Remove invalid assertions
14598         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14599         is removed.
14600         (riscv_gdbarch_init): Gather isa features and abi features
14601         separately, ensure both match on the gdbarch when reusing an old
14602         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14603         a target with 64-bit float hardware.
14604
14605 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14606
14607         * source.c (search_command_helper): Stop reverse search
14608         when line 1 has been searched.
14609
14610 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14611
14612         * record-full.c (record_full_base_target::close): Rewrite
14613         record_full_core_buf_list free logic.
14614
14615 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14616
14617         * break-catch-syscall.c (print_one_catch_syscall): xfree
14618         the last text.
14619
14620 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14621
14622         * top.c (print_gdb_version): Update Copyright year in version
14623         message.
14624
14625 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14626
14627         Update copyright year range in all GDB files.
14628
14629 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14630
14631         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14632
14633 For older changes see ChangeLog-2018.
14634 \f
14635 Local Variables:
14636 mode: change-log
14637 left-margin: 8
14638 fill-column: 74
14639 version-control: never
14640 coding: utf-8
14641 End:
14642