gdb/ChangeLog

   1 2019-08-29  Bernhard Wodok  <barto@gmx.net>
   2             Sergio Durigan Junior  <sergiodj@redhat.com>
   3
   4         PR win32/24284
   5         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
   6
   7 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
   8
   9         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  10         when searching for types.
  11
  12 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  13
  14         * f-lang.c (f_language_defn): Use f_print_typedef.
  15         * f-lang.h (f_print_typedef): Declare.
  16         * f-typeprint.c (f_print_typedef): Define.
  17
  18 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  19
  20         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  21
  22 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  23
  24         * cli/cli-utils.c (info_print_options_defs): Delete.
  25         (make_info_print_options_def_group): Delete.
  26         (extract_info_print_options): Delete.
  27         (info_print_command_completer): Delete.
  28         (info_print_args_help): Add extra parameter, and optionally
  29         include text about -n flag.
  30         * cli/cli-utils.h (struct info_print_options): Delete.
  31         (extract_info_print_options): Delete declaration.
  32         (info_print_command_completer): Delete declaration.
  33         (info_print_args_help): Add extra parameter, extend header
  34         comment.
  35         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  36         search_symbols.
  37         * stack.c (struct info_print_options): New type.
  38         (info_print_options_defs): New file scoped variable.
  39         (make_info_print_options_def_group): New static function.
  40         (info_print_command_completer): New static function.
  41         (info_locals_command): Update to use new local functions.
  42         (info_args_command): Likewise.
  43         (_initialize_stack): Add extra parameter to calls to
  44         info_print_args_help.
  45         * symtab.c (search_symbols): Add extra parameter, use this to
  46         possibly excluse non-debug symbols.
  47         (symtab_symbol_info): Add extra parameter, which is passed on to
  48         search_symbols.
  49         (struct info_print_options): New type.
  50         (info_print_options_defs): New file scoped variable.
  51         (make_info_print_options_def_group): New static function.
  52         (info_print_command_completer): New static function.
  53         (info_variables_command): Update to use local functions, and pass
  54         extra parameter through to symtab_symbol_info.
  55         (info_functions_command): Likewise.
  56         (info_types_command): Pass additional argument through to
  57         symtab_symbol_info.
  58         (rbreak_command): Pass extra argument to search_symbols.
  59         (_initialize_symtab): Add extra arguments for calls to
  60         info_print_args_help, and update help text for 'info variables',
  61         'whereis', and 'info functions' commands.
  62         * symtab.h (search_symbols): Add extra argument to declaration.
  63         * NEWS: Mention new flags.
  64
  65 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
  66
  67         * symtab.c (lookup_static_symbol): Call the new function (and move
  68         it down to be next to lookup_global_symbol).
  69         (struct global_sym_lookup_data): Add block_enum member and rename to...
  70         (struct global_or_static_sym_lookup_data): ...this.
  71         (lookup_symbol_global_iterator_cb): Pass block_index instead of
  72         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
  73         (lookup_symbol_global_or_static_iterator_cb): ...this.
  74         (lookup_global_or_static_symbol): New function.
  75         (lookup_global_symbol): Call new function.
  76
  77 2019-08-26  Tom de Vries  <tdevries@suse.de>
  78
  79         PR c++/24852
  80         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
  81         when pc_probe.prob == NULL.
  82
  83 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  84
  85         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
  86         variable symbol_linkage to symbol_linkage_.
  87
  88 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  89
  90         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
  91         represent whether the symbol is static, dynamic, or we don't
  92         know.
  93
  94 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
  95
  96         * gdb/rx-tdep.c (rx_register_names): New.
  97         (rx_register_name): Delete.
  98         (rx_psw_type): Delete.
  99         (rx_fpsw_type): Delete.
 100         (rx_register_type): Delete.
 101         (rx_gdbarch_init): Convert target-descriptions.
 102         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 103         * gdb/features/Makefile: Add rx.xml.
 104         * gdb/features/rx.xml: New.
 105         * gdb/features/rx.c: Generated.
 106         * gdb/NEWS: Mention target description support.
 107
 108 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 109
 110         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 111         *slot_ptr.
 112
 113 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 114
 115         * configure.ac: Don't check for 'dlfcn.h' (moved to
 116         gdbsupport/common.m4).
 117         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 118         'gdbsupport/'.
 119         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 120         * compile/compile-c-support.c: Include
 121         'gdbsupport/gdb-dlfcn.h'.
 122         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 123         * gdb-dlfcn.c: Move to...
 124         * gdbsupport/gdb-dlfcn.c: ... here.
 125         * gdb-dlfcn.h: Move to...
 126         * gdbsupport/gdb-dlfcn.h: ... here.
 127
 128 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 129
 130         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 131         the offset field signed.
 132
 133 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 134
 135         * python/lib/gdb/__init__.py (_execute_file): New function.
 136         * python/python.c (python_run_simple_file): Call gdb._execute_file
 137         on Windows.
 138
 139 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 140
 141         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 142         all uses as this was never set to anything but a zero value.
 143
 144 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 145
 146         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 147
 148 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * tui/tui-data.h (tui_gen_win_info): Add an =default
 151         move constructor, required by some GCC versions.
 152
 153 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 154
 155         * go32-nat.c (go32_sysinfo): Add hygon_p.
 156
 157 2019-08-20  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 160         line_from_reg_element_no, first_reg_element_no_inline,
 161         display_all_data, delete_data_content_windows,
 162         erase_data_content>: Now private.
 163
 164 2019-08-20  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 167         (tui_unhighlight_win, tui_highlight_win)
 168         (tui_win_info::make_window): Update.
 169         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 170
 171 2019-08-20  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 174         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 175         (MAX_PID_WIDTH): Move to tui-stack.c.
 176         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 177         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 178         (MAX_PID_WIDTH): Move from tui-data.h.
 179
 180 2019-08-20  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 183         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 184         (box_win): Update.
 185         (tui_gen_win_info::make_window): Rename from tui_make_window.
 186         (tui_win_info::make_window): New method.
 187         (tui_gen_win_info::make_visible): Update.
 188         * tui/tui-source.c (tui_source_window::set_contents): Update.
 189         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 190         (tui_data_window::display_registers_from): Update.
 191         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 192         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 193         Declare.
 194         <can_box>: Remove.
 195         <title>: Remove.
 196         (struct tui_win_info) <make_window>: Declare.
 197         <can_box>: Now virtual.
 198         <title>: New member.
 199         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 200         * tui/tui-command.c (tui_cmd_window::resize): Update.
 201
 202 2019-08-20  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 205         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 206         (tui_data_window::check_register_values): Update.
 207
 208 2019-08-20  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-regs.h (struct tui_data_window): Use
 211         DISABLE_COPY_AND_ASSIGN.
 212         <regs_content>: Change type, removing unique_ptr.
 213         <tui_data_window>: Add move constructor.
 214         * tui/tui-regs.c (tui_data_window::show_registers)
 215         (tui_data_window::show_register_group)
 216         (tui_data_window::display_registers_from)
 217         (tui_data_window::display_registers_from)
 218         (tui_data_window::first_data_item_displayed)
 219         (tui_data_window::delete_data_content_windows)
 220         (tui_data_window::rerender, tui_data_window::refresh_window)
 221         (tui_data_window::check_register_values): Update.
 222
 223 2019-08-20  Tom Tromey  <tom@tromey.com>
 224
 225         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 226         show_register_group>: Declare.
 227         (tui_show_register_group): Don't declare.
 228         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 229         tui_show_registers.
 230         (tui_data_window::show_register_group): Rename from
 231         tui_show_register_group.
 232         (tui_data_window::check_register_values, tui_reg_command):
 233         Update.
 234         * tui/tui-layout.c (tui_set_layout): Update.
 235
 236 2019-08-20  Tom Tromey  <tom@tromey.com>
 237
 238         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 239         Declare.
 240         (tui_check_register_values): Don't declare.
 241         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 242         from tui_check_register_values.
 243         * tui/tui-hooks.c (tui_register_changed): Update.
 244
 245 2019-08-20  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-regs.c (tui_reg_layout): Move later.
 248         (tui_show_registers): Don't enable TUI mode or change layout.
 249
 250 2019-08-20  Tom Tromey  <tom@tromey.com>
 251
 252         * tui/tui-regs.h (struct tui_data_item_window)
 253         <~tui_data_item_window>: Remove.
 254         <content>: Now a unique_xmalloc_ptr.
 255         * tui/tui-regs.c (tui_register_format): Return a
 256         unique_xmalloc_ptr.
 257         (tui_get_register): Update.
 258         (~tui_data_item_window): Remove.
 259         (tui_data_window::display_registers_from, tui_display_register):
 260         Update.
 261         * tui/tui-io.h (tui_expand_tabs): Update.
 262         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 263         Remove "col" parameter.
 264
 265 2019-08-20  Tom Tromey  <tom@tromey.com>
 266
 267         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 268         field.
 269         * tui/tui-regs.c (~tui_data_item_window): Update.
 270
 271 2019-08-20  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 274         earlier.
 275
 276 2019-08-20  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 279
 280 2019-08-20  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui-source.h (struct tui_source_window): Update.
 283         * tui/tui-regs.c (tui_show_registers): Update.
 284         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 285         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 286         (NO_REGS_STRING): Remove defines.
 287
 288 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 289
 290         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 291         unnecessary thread walk if remote doesn't support the packet.
 292
 293 2019-08-19  Tom Tromey  <tromey@adacore.com>
 294
 295         * python/py-value.c (value_has_field): Fix indentation.
 296
 297 2019-08-19  Tom Tromey  <tromey@adacore.com>
 298
 299         * printcmd.c (do_one_display, info_display_command): Update.
 300         * block.h (contained_in): Return bool.  Add allow_nested
 301         parameter.
 302         * block.c (contained_in): Return bool.  Add allow_nested
 303         parameter.
 304
 305 2019-08-19  Tom Tromey  <tom@tromey.com>
 306
 307         * configure: Rebuild.
 308         * configure.ac: Disallow the combination of -static-libstdc++ and
 309         source highlight.
 310         * source-cache.c (get_language_name): Handle rust.
 311         (source_cache::get_source_lines): Ignore highlighting exceptions.
 312
 313 2019-08-16  Tom Tromey  <tom@tromey.com>
 314
 315         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 316         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 317         (struct tui_source_window_base) <make_visible, refresh_window,
 318         resize>: Remove methods.
 319         <execution_info>: Remove field.
 320         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 321         (tui_show_source_line, tui_source_window_base)
 322         (~tui_source_window_base): Update.
 323         (tui_source_window_base::resize)
 324         (tui_source_window_base::make_visible)
 325         (tui_source_window_base::refresh_window): Remove.
 326         (tui_source_window_base::update_exec_info): Update.
 327         * tui/tui-source.c (tui_source_window::set_contents): Update.
 328         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 329
 330 2019-08-16  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 333         deprecated_query_hook.
 334
 335 2019-08-16  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 338         (tui_update_source_windows_with_line): Update.
 339         * tui/tui-source.h (struct tui_source_window)
 340         <show_symtab_source>: Declare.
 341         (tui_show_symtab_source): Don't declare.
 342         * tui/tui-source.c (tui_show_symtab_source): Rename from
 343         tui_show_symtab_source.
 344
 345 2019-08-16  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-winsource.h (struct tui_source_window_base)
 348         <set_contents>: Declare.
 349         * tui/tui-winsource.c
 350         (tui_source_window_base::update_source_window_as_is): Update.
 351         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 352         Declare.
 353         (tui_set_source_content): Don't declare.
 354         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 355         tui_set_source_content.
 356         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 357         Declare.
 358         (tui_set_disassem_content): Don't declare.
 359         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 360         tui_set_disassem_content.
 361
 362 2019-08-16  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-winsource.h (struct tui_source_window_base)
 365         <update_breakpoint_info>: Declare.
 366         (tui_update_breakpoint_info): Don't declare.
 367         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 368         (tui_update_all_breakpoint_info): Update.
 369         (tui_source_window_base::update_breakpoint_info): Rename from
 370         tui_update_breakpoint_info.
 371         (tui_source_window_base::update_exec_info): Update.
 372
 373 2019-08-16  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-winsource.h (struct tui_source_window_base)
 376         <update_source_window>: Declare.
 377         (tui_update_source_window): Don't declare.
 378         * tui/tui-winsource.c
 379         (tui_source_window_base::update_source_window): Rename from
 380         tui_update_source_window.
 381         (tui_source_window_base::rerender): Update.
 382         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 383         * tui/tui-disasm.c (tui_show_disassem)
 384         (tui_show_disassem_and_update_source)
 385         (tui_disasm_window::maybe_update): Update.
 386
 387 2019-08-16  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-winsource.h (struct tui_source_window_base)
 390         <update_source_window_as_is>: Declare.
 391         (tui_update_source_window_as_is): Don't declare.
 392         * tui/tui-winsource.c (tui_update_source_window): Update
 393         (tui_source_window_base::update_source_window_as_is): Rename from
 394         tui_update_source_window_as_is.
 395         (tui_source_window_base::refill): Update.
 396         * tui/tui-source.c (tui_show_symtab_source): Update.
 397         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 398         Update.
 399
 400 2019-08-16  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.h (tui_update_source_window)
 403         (tui_update_source_window_as_is): Remove "noerror" parameter.
 404         * tui/tui-winsource.c (tui_update_source_window)
 405         (tui_update_source_window_as_is): Remove "noerror" parameter.
 406         (tui_update_source_windows_with_addr)
 407         (tui_update_source_windows_with_line)
 408         (tui_source_window_base::rerender)
 409         (tui_source_window_base::refill): Update.
 410         * tui/tui-source.h (tui_set_source_content)
 411         (tui_show_symtab_source): Remove "noerror" parameter.
 412         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 413         parameter.
 414         (tui_show_symtab_source): Likewise.
 415         (tui_source_window::maybe_update): Update.
 416         * tui/tui-disasm.c (tui_show_disassem)
 417         (tui_show_disassem_and_update_source)
 418         (tui_disasm_window::do_scroll_vertical)
 419         (tui_disasm_window::maybe_update): Update.
 420
 421 2019-08-16  Tom Tromey  <tom@tromey.com>
 422
 423         * tui/tui.c (tui_is_window_visible): Update.
 424         * tui/tui-wingeneral.c (tui_make_window)
 425         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 426         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 427         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 428         (tui_set_win_height_command, parse_scrolling_args): Update.
 429         * tui/tui-source.c (tui_source_window::style_changed): Update.
 430         * tui/tui-regs.c (tui_show_registers)
 431         (tui_data_window::first_data_item_displayed)
 432         (tui_data_window::delete_data_content_windows)
 433         (tui_check_register_values, tui_reg_command): Update.
 434         * tui/tui-disasm.c (tui_show_disassem): Update.
 435         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 436         method.
 437         <is_visible>: Remove field.
 438         * tui/tui-data.c (tui_next_win, tui_prev_win)
 439         (tui_delete_invisible_windows): Update.
 440
 441 2019-08-16  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-winsource.h (struct tui_source_window_base)
 444         <m_has_locator>: Remove.
 445         * tui/tui-layout.c (show_source_disasm_command, show_data)
 446         (show_source_or_disasm_and_command): Update.
 447
 448 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 449
 450         * NEWS (Other MI changes): New subsection.
 451         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 452         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 453         * arch-utils.c (default_get_pc_address_flags): New function.
 454         * arch-utils.h (default_get_pc_address_flags): New declaration.
 455         * gdbarch.sh: Add get_pc_address_flags.
 456         * gdbarch.c: Regenerate.
 457         * gdbarch.h: Likewise.
 458         * stack.c (print_pc): New function.
 459         (print_frame_info) (print_frame): Call print_pc.
 460
 461 2019-08-16  Tom de Vries  <tdevries@suse.de>
 462
 463         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 464         print_objfile_section_info.
 465
 466 2019-08-15  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 469         calling update_cmdwin_start_line.
 470         * tui/tui-winsource.h (struct tui_source_window_base)
 471         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 472         <rerender>: Declare.
 473         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 474         Call rerender.
 475         (tui_source_window_base::set_new_height): Remove.
 476         (tui_source_window_base::rerender): Rename from
 477         do_make_visible_with_new_height.
 478         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 479         resize method.
 480         (tui_win_info::make_invisible_and_set_new_height)
 481         (tui_win_info::make_visible_with_new_height): Remove.
 482         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 483         Declare.
 484         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 485         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 486         do_make_visible_with_new_height>: Don't declare.
 487         <rerender>: Declare.
 488         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 489         set_new_height.
 490         (tui_data_window::do_make_visible_with_new_height): Remove.
 491         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 492         call tui_show_locator_content.
 493         (tui_gen_win_info::resize): Call rerender.
 494         (show_source_or_disasm_and_command): Don't call
 495         tui_show_locator_content.
 496         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 497         method.
 498         (struct tui_win_info) <rerender>: Declare.
 499         <set_new_height, make_invisible_and_set_new_height,
 500         make_visible_with_new_height>: Don't declare.
 501         * tui/tui-data.c (tui_win_list::rerender): New method.
 502         * tui/tui-command.h (struct tui_cmd_window)
 503         <do_make_visible_with_new_height>: Don't declare.
 504         * tui/tui-command.c
 505         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 506
 507 2019-08-15  Tom Tromey  <tromey@adacore.com>
 508
 509         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 510         * ada-lang.c (ada_enum_name): Likewise.
 511
 512 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 513
 514         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 515         leading underscore.
 516         (GdbOutputErrorFile): Likewise.
 517         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 518         accordingly.
 519         (execute_unwinders): Rename to have a leading underscore.
 520         (auto_load_packages): Likewise.
 521         (global scope): Adjust call to auto_load_packages accordingly.
 522         (GdbSetPythonDirectory): Likewise.
 523         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 524         instead of execute_unwinders.
 525
 526 2019-08-15  Tom Tromey  <tom@tromey.com>
 527
 528         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 529         (show_data): Don't change window visibility.
 530         (tui_gen_win_info::resize): Remove special case for command
 531         window.  Use wresize, when available.
 532         (show_source_or_disasm_and_command): Don't change window
 533         visibility.
 534         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 535         <make_visible>: New method.
 536         * tui/tui-command.c (tui_cmd_window::resize): New method.
 537
 538 2019-08-15  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 541         (struct tui_source_windows): New.
 542         * tui/tui-winsource.c (tui_display_main): Update.
 543         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 544         (new_height_ok, parse_scrolling_args): Update.
 545         * tui/tui-layout.c (show_layout, show_data): Update.
 546         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 547         (tui_add_to_source_windows): Don't declare.
 548         * tui/tui-data.c (source_windows, tui_source_windows)
 549         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 550
 551 2019-08-15  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 554         Rename from reset.
 555         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 556         * tui/tui-layout.c (show_source_disasm_command, show_data):
 557         Update.
 558         (tui_gen_win_info::resize): Rename.
 559         (show_source_or_disasm_and_command): Update.
 560         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 561         reset.
 562
 563 2019-08-15  Tom Tromey  <tom@tromey.com>
 564
 565         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 566         * tui/tui-interp.c (tui_interp::init): Don't call
 567         tui_initialize_static_data.
 568         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 569
 570 2019-08-15  Tom Tromey  <tom@tromey.com>
 571
 572         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 573         examine tui_win_list.
 574
 575 2019-08-15  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 578         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 579         tui_clear_source_content.
 580         (tui_clear_source_content): Remove.
 581         (tui_source_window_base::do_erase_source_content): Hoist call to
 582         content.clear().
 583         * tui/tui-stack.c (tui_show_frame_info): Don't call
 584         tui_clear_source_content.
 585
 586 2019-08-15  Tom Tromey  <tom@tromey.com>
 587
 588         * tui/tui-winsource.h (struct tui_source_window_base)
 589         <do_erase_source_content>: New method.
 590         <erase_source_content>: New method.
 591         (tui_erase_source_content): Don't declare.
 592         * tui/tui-winsource.c (tui_clear_source_content): Update.
 593         (tui_source_window_base::do_erase_source_content): Rename from
 594         tui_erase_source_content.
 595         (tui_source_window_base::show_source_content): Update.
 596         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 597         * tui/tui-source.h (struct tui_source_window)
 598         <erase_source_content>: New method.
 599         * tui/tui-disasm.h (struct tui_disasm_window)
 600         <erase_source_content>: New method.
 601
 602 2019-08-15  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 605         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 606         constructor.
 607         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 608         * tui/tui-source.c (tui_set_source_content): Update.
 609         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 610
 611 2019-08-15  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 614         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 615         tui-source.c.
 616         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 617         Declare.
 618         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 619         method.
 620         (tui_source_window::maybe_update): Update.
 621
 622 2019-08-15  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 625         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 626         tui-disasm.c.
 627         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 628         Declare.
 629         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 630         method.
 631         (tui_disasm_window::maybe_update): Update.
 632
 633 2019-08-15  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-winsource.h (struct tui_source_window_base)
 636         <maybe_update>: Declare.
 637         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 638         method.
 639         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 640         Declare.
 641         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 642         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 643         Declare.
 644         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 645
 646 2019-08-15  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 649
 650 2019-08-15  Tom Tromey  <tom@tromey.com>
 651
 652         * tui/tui-wingeneral.c: Include tui-stack.h.
 653         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 654         (struct tui_locator_window): Move from tui-data.h.
 655         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 656         (tui_initialize_static_data): Move from tui-data.c.
 657         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 658         (struct tui_locator_window): Move to tui-stack.c.
 659         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 660         (tui_initialize_static_data): Move to tui-stack.c.
 661
 662 2019-08-15  Tom Tromey  <tom@tromey.com>
 663
 664         * tui/tui-layout.c (show_source_disasm_command)
 665         (show_source_or_disasm_and_command): Use make_visible method, not
 666         tui_make_window.
 667         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 668         Remove.
 669
 670 2019-08-15  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-wingeneral.h (tui_make_window): Update.
 673         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 674         parameter.
 675         (tui_gen_win_info::make_visible): Update.
 676         * tui/tui-regs.c (tui_data_window::display_registers_from):
 677         Update.
 678         * tui/tui-layout.c (show_source_disasm_command)
 679         (show_source_or_disasm_and_command): Update.
 680         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 681         (enum tui_box): Remove.
 682         (struct tui_win_info) <can_box>: New method.
 683         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 684         method.
 685
 686 2019-08-15  Tom de Vries  <tdevries@suse.de>
 687
 688         * linux-nat-trad.c: Include gdbarch.h.
 689
 690 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 691
 692         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 693         register sizes.
 694
 695 2019-08-14  Tom Tromey  <tromey@adacore.com>
 696
 697         * darwin-nat.c: Include gdbarch.h.
 698         * darwin-nat-info.c: Include gdbarch.h.
 699
 700 2019-08-13  Tom Tromey  <tom@tromey.com>
 701
 702         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 703         Remove.
 704         * tui/tui-data.c (tui_initialize_static_data): Update.
 705
 706 2019-08-13  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-winsource.h (struct tui_exec_info_window)
 709         <~tui_exec_info_window, maybe_allocate_content, get_content,
 710         m_content>: Remove.
 711         (struct tui_source_window_base) <set_exec_info_content,
 712         show_exec_info_content>: Don't declare.
 713         * tui/tui-winsource.c
 714         (tui_exec_info_window::maybe_allocate_content): Remove.
 715         (tui_source_window_base::update_exec_info): Rename from
 716         set_exec_info_content.
 717         (tui_source_window_base::show_exec_info_content)
 718         (tui_source_window_base::update_exec_info): Remove.
 719
 720 2019-08-13  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 723         declare.
 724         * tui/tui-winsource.c (tui_update_source_window_as_is)
 725         (tui_update_source_windows_with_addr, tui_erase_source_content):
 726         Update.
 727         (tui_clear_exec_info_content): Remove.
 728
 729 2019-08-13  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 732         declare.
 733         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 734         call tui_erase_exec_info_content.
 735         (tui_clear_exec_info_content): Rename from
 736         tui_erase_exec_info_content.
 737         (tui_clear_exec_info_content): Delete.
 738
 739 2019-08-13  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-winsource.h (struct tui_source_window_base)
 742         <show_exec_info_content>: Declare.
 743         (tui_show_exec_info_content): Don't declare.
 744         * tui/tui-winsource.c
 745         (tui_source_window_base::show_exec_info_content): Rename from
 746         tui_show_exec_info_content.
 747         (tui_source_window_base::update_exec_info): Update.
 748
 749 2019-08-13  Tom Tromey  <tom@tromey.com>
 750
 751         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 752         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 753         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 754         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 755         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 756         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 757         ... here.
 758
 759 2019-08-13  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-winsource.h (struct tui_source_window_base)
 762         <update_exec_info>: Declare.
 763         (tui_update_exec_info): Don't declare.
 764         * tui/tui-winsource.c (tui_update_source_window_as_is)
 765         (tui_source_window_base::refresh_all)
 766         (tui_update_all_breakpoint_info): Update.
 767         (tui_source_window_base::update_exec_info): Rename from
 768         tui_update_exec_info.
 769         * tui/tui-stack.c (tui_show_frame_info): Update.
 770
 771 2019-08-13  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui-winsource.h (struct tui_source_window_base)
 774         <set_exec_info_content>: Declare.
 775         (tui_set_exec_info_content): Don't declare.
 776         * tui/tui-winsource.c
 777         (tui_source_window_base::set_exec_info_content): Rename from
 778         tui_set_exec_info_content.
 779         (tui_update_exec_info): Update.
 780
 781 2019-08-13  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-winsource.h (struct tui_source_window_base)
 784         <show_source_content>: Declare.
 785         (tui_show_source_content): Don't declare.
 786         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 787         (tui_source_window_base::show_source_content): Rename from
 788         tui_show_source_content.
 789         (tui_source_window_base::refresh_all): Update.
 790         * tui/tui-layout.c (show_source_disasm_command)
 791         (show_source_or_disasm_and_command): Update.
 792
 793 2019-08-13  Tom Tromey  <tom@tromey.com>
 794
 795         * tui/tui-winsource.c (tui_erase_source_content)
 796         (tui_show_source_content, tui_source_window_base::refresh_all):
 797         Update.
 798         * tui/tui-wingeneral.h
 799         (tui_check_and_display_highlight_if_needed): Don't declare.
 800         * tui/tui-wingeneral.c
 801         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 802         check_and_display_highlight_if_needed.
 803         * tui/tui-win.c (tui_rehighlight_all)
 804         (tui_win_info::make_visible_with_new_height): Update.
 805         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 806         (tui_data_window::erase_data_content)
 807         (tui_data_window::display_all_data): Update.
 808         * tui/tui-data.h (struct tui_win_info)
 809         <check_and_display_highlight_if_needed>: Declare.
 810
 811 2019-08-13  Tom Tromey  <tom@tromey.com>
 812
 813         * tui/tui-win.c (tui_resize_all): Call
 814         tui_delete_invisible_windows.
 815         * tui/tui-layout.c (show_layout): Call
 816         tui_delete_invisible_windows.
 817         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 818         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 819
 820 2019-08-13  Tom Tromey  <tom@tromey.com>
 821
 822         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 823         tui_add_win_to_layout.
 824
 825 2019-08-13  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 828         * tui/tui-layout.c (tui_default_win_height): Now static.
 829
 830 2019-08-13  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 833         single switch.
 834         (show_source_disasm_command, show_source_or_disasm_and_command):
 835         Don't check current layout.
 836
 837 2019-08-13  Tom Tromey  <tom@tromey.com>
 838
 839         * tui/tui-wingeneral.c (make_all_visible): Remove.
 840         (tui_make_all_invisible): Simplify.
 841         * tui/tui-layout.c (tui_make_all_invisible): Move from
 842         tui-wingeneral.c; simplify.
 843         (show_layout): Hoist call to tui_make_all_invisible.
 844         (show_data): Don't call tui_make_all_invisible.
 845
 846 2019-08-13  Tom Tromey  <tom@tromey.com>
 847
 848         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 849         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 850
 851 2019-08-13  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 854         tui-data.c.
 855         (show_source_disasm_command, show_data)
 856         (show_source_or_disasm_and_command): Don't use
 857         tui_set_current_layout_to.
 858         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 859         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 860         tui-layout.c.
 861         (tui_set_current_layout_to): Remove.
 862
 863 2019-08-13  Tom Tromey  <tom@tromey.com>
 864
 865         * tui/tui-layout.c (tui_set_layout): Update.
 866         * tui/tui-data.h (struct tui_layout_def): Remove.
 867         (tui_layout_def): Don't declare.
 868         * tui/tui-data.c (layout_def): Remove.
 869         (tui_layout_def): Remove.
 870
 871 2019-08-13  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-winsource.h (struct tui_source_window_base)
 874         <clear_detail>: No longer "override".
 875         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 876         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 877         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 878         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 879         Remove.
 880         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 881
 882 2019-08-13  Tom Tromey  <tromey@adacore.com>
 883
 884         * tracepoint.c: Don't include readline.h or history.h.
 885
 886 2019-08-12  Tom Tromey  <tom@tromey.com>
 887
 888         * configure: Rebuild.
 889         * configure.ac: Check for readline 7.
 890         * NEWS: Mention readline 7 requirement.
 891         * README: Update.
 892
 893 2019-08-12  Tom Tromey  <tom@tromey.com>
 894
 895         * mingw-hdep.c (gdb_select): Remove readline hack.
 896
 897 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 898
 899         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 900         when the function fails.
 901
 902 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 903
 904         * s390-tdep.c (s390_type_align): New function.
 905         (s390_gdbarch_init): Set it as type_align gdbarch method.
 906
 907 2019-08-09  Tom de Vries  <tdevries@suse.de>
 908
 909         PR gdb/24591
 910         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 911         pc_low with relocation offset.
 912
 913 2019-08-07  Tom Tromey  <tromey@adacore.com>
 914
 915         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 916         (print_frame_args): Update.
 917         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 918         Update.
 919         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 920         * frame.h (struct frame_arg): Add initializers.
 921         <error>: Now a unique_xmalloc_ptr.
 922
 923 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 924
 925         * NEWS: Expand the Pointer Authentication entry.
 926         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 927         (aarch64_frame_unmask_lr): ... to this.
 928         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 929         Call aarch64_frame_unmask_lr.
 930         * frame.c (struct frame_info): Add "masked" variable.
 931         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 932         (fprint_frame): Check for masked pc.
 933         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 934         declarations.
 935         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 936         * stack.c (print_frame): Check for masked pc.
 937
 938 2019-08-06  Tom Tromey  <tom@tromey.com>
 939
 940         * stabsread.c (patch_block_stabs, read_one_struct_field)
 941         (read_enum_type): Use obstack_strndup.
 942         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 943         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 944         * dwarf2read.c (guess_full_die_structure_name)
 945         (anonymous_struct_prefix): Use obstack_strndup.
 946         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 947         * c-exp.y (yylex): Use obstack_strndup.
 948         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 949         (write_var_or_type): Use obstack_strndup.
 950
 951 2019-08-06  Tom Tromey  <tom@tromey.com>
 952
 953         * symfile.c (reread_symbols): Use obstack_strdup.
 954         * stabsread.c (read_type): Use obstack_strdup.
 955         * gdb_obstack.h (obstack_strdup): New overload.
 956         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 957         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 958         (dwarf2_canonicalize_name): Use obstack_strdup.
 959         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 960         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 961         Use obstack_strdup.
 962
 963 2019-08-06  Tom Tromey  <tom@tromey.com>
 964
 965         * gdb_obstack.h (obstack_strdup): Define.
 966         * gdb_obstack.c (obstack_strdup): Don't define.
 967
 968 2019-08-06  Tom Tromey  <tom@tromey.com>
 969
 970         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 971         obstack_strdup.
 972         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 973         obstack_strdup.
 974         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 975         * stabsread.c (common_block_start): Use obstack_strdup.
 976         * objfiles.c (set_objfile_main_name, objfile): Use
 977         obstack_strdup.
 978         * namespace.c (add_using_directive): Use obstack_strdup.
 979         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 980         * jit.c (finalize_symtab): Use obstack_strdup.
 981         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 982         (guess_partial_die_structure_name, partial_die_info::fixup)
 983         (dwarf2_name): Use obstack_strdup.
 984         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 985         obstack_strdup.
 986         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 987         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 988         obstack_strdup.
 989         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 990
 991 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 992
 993         * unittests/help-doc-selftests.c: New file.
 994         * Makefile.in: Add the new file.
 995
 996 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 997
 998         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
 999         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1000         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1001         the trailing '.' is not output, and the first character is uppercased.
1002         (print_help_for_command): Update call to print_doc_line.
1003         (print_doc_of_command): Likewise.
1004         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1005         * cli/cli-option.c (append_indented_doc): Do not append newline.
1006         (build_help_option): Append newline after first appended_indented_doc
1007         only if a second call is done.
1008         (build_help): Append 2 new lines before each option, except the first
1009         one.
1010         * compile/compile.c (_initialize_compile): Add new lines after
1011         %OPTIONS%, when not at the end of the help.
1012         Change help doc or code
1013         producing the help doc to respect the invariants.
1014         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1015         Also removed the new line after 'Options:', as all other commands
1016         do not put an empty line between 'Options:' and the first option.
1017         * printcmd.c (_initialize_printcmd): Likewise.
1018         * stack.c (_initialize_stack): Likewise.
1019         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1020         incorrectly telling COMMAND is optional.
1021         * ada-lang.c (_initialize_ada_language): Change help doc or code
1022         producing the help doc to respect the invariants.
1023         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1024         * breakpoint.c (_initialize_breakpoint): Likewise.
1025         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1026         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1027         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1028         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1029         _initialize_cli_style): Likewise.
1030         * corelow.c (core_target_info): Likewise.
1031         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1032         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1033         * filesystem.c (_initialize_filesystem): Likewise.
1034         * frame.c (_initialize_frame): Likewise.
1035         * gnu-nat.c (add_task_commands): Likewise.
1036         * infcall.c (_initialize_infcall): Likewise.
1037         * infcmd.c (_initialize_infcmd): Likewise.
1038         * interps.c (_initialize_interpreter): Likewise.
1039         * language.c (_initialize_language): Likewise.
1040         * linux-fork.c (_initialize_linux_fork): Likewise.
1041         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1042         * maint.c (_initialize_maint_cmds): Likewise.
1043         * memattr.c (_initialize_mem): Likewise.
1044         * printcmd.c (_initialize_printcmd): Likewise.
1045         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1046         _RegEx): Likewise.
1047         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1048         * record-btrace.c (_initialize_record_btrace): Likewise.
1049         * record-full.c (_initialize_record_full): Likewise.
1050         * record.c (_initialize_record): Likewise.
1051         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1052         * regcache.c (_initialize_regcache): Likewise.
1053         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1054         _initialize_remote): Likewise.
1055         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1056         * serial.c (_initialize_serial): Likewise.
1057         * skip.c (_initialize_step_skip): Likewise.
1058         * source.c (_initialize_source): Likewise.
1059         * stack.c (_initialize_stack): Likewise.
1060         * symfile.c (_initialize_symfile): Likewise.
1061         * symtab.c (_initialize_symtab): Likewise.
1062         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1063         * top.c (init_main): Likewise.
1064         * tracefile-tfile.c (tfile_target_info): Likewise.
1065         * tracepoint.c (_initialize_tracepoint): Likewise.
1066         * tui/tui-win.c (_initialize_tui_win): Likewise.
1067         * utils.c (add_internal_problem_command): Likewise.
1068         * valprint.c (value_print_option_defs): Likewise.
1069
1070 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1071
1072         PR build/24886
1073         * configure.ac: Drop enable-libmcheck support.
1074         * configure, config.in: Rebuild.
1075         * libmcheck.m4: Remove.
1076         * acinclude.m4: Don't include it.
1077         * Makefile.in: Don't distribute it.
1078         * top.c (print_gdb_configuration): Don't mention it.
1079
1080 2019-08-06  Tom Tromey  <tom@tromey.com>
1081
1082         * utils.c (set_output_style): Sometimes pass stream to
1083         emit_style_escape.
1084         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1085         * record-btrace.c (btrace_insn_history): Update.
1086         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1087         method.
1088         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1089         Update initializers.
1090         <m_uiout>: New field.
1091         <m_di>: Move lower.
1092         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1093         Remove "uiout" parameter.
1094         (dump_insns): Update.
1095         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1096         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1097
1098 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1099
1100         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1101         (error_in_psymtab_expansion): Likewise.
1102         (lookup_symbol_via_quick_fns): Likewise.
1103         (basic_lookup_transparent_type_quick): Likewise.
1104         (basic_lookup_transparent_type_1): Likewise.
1105
1106 2019-08-06  Tom Tromey  <tromey@adacore.com>
1107
1108         * source.c (last_source_error): Now bool.
1109         (print_source_lines_base): Make "noprint" bool.  Only open
1110         source file when last_source_visited changes.
1111
1112 2019-08-06  Tom Tromey  <tromey@adacore.com>
1113
1114         * annotate.c (annotate_source_line): Use g_source_cache.
1115         * source-cache.c (source_cache::get_plain_source_lines): Change
1116         parameters.  Populate m_offset_cache.
1117         (source_cache::ensure): New method.
1118         (source_cache::get_line_charpos): New method.
1119         (extract_lines): Move lower.  Change parameters.
1120         (source_cache::get_source_lines): Move lower.
1121         * source-cache.h (class source_cache): Update comment.
1122         <get_line_charpos>: New method.
1123         <get_source_lines>: Update comment.
1124         <clear>: Clear m_offset_cache.
1125         <get_plain_source_lines>: Change parameters.
1126         <ensure>: New method
1127         <m_offset_cache>: New member.
1128         * source.c (forget_cached_source_info_for_objfile): Update.
1129         (info_source_command): Use g_source_cache.
1130         (find_source_lines, open_source_file_with_line_charpos): Remove.
1131         (print_source_lines_base, search_command_helper): Use g_source_cache.
1132         * source.h (open_source_file_with_line_charpos): Don't declare.
1133         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1134         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1135         Use g_source_cache.
1136
1137 2019-08-06  Tom Tromey  <tromey@adacore.com>
1138
1139         * source-cache.c (source_cache::get_plain_source_lines):
1140         Remove "first_line" and "last_line" parameters.
1141         (source_cache::get_source_lines): Cache plain text.
1142         * source-cache.h (class source_cache)
1143         <get_plain_source_lines>: Update.
1144
1145 2019-08-06  Tom Tromey  <tromey@adacore.com>
1146
1147         * source-cache.c (extract_lines): No longer a method.
1148         Changed type of parameter.  Include final newline.
1149         (selftests::extract_lines_test): New function.
1150         (_initialize_source_cache): Likewise.
1151         * source-cache.h (class source_cache)
1152         <extract_lines>: Don't declare.
1153
1154 2019-08-06  Tom Tromey  <tromey@adacore.com>
1155
1156         * breakpoint.c (init_breakpoint_sal): Update.
1157         (breakpoint): Update.
1158         * breakpoint.h (struct breakpoint) <filter>: Now a
1159         unique_xmalloc_ptr.
1160
1161 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1162
1163         * NEWS: Mention dictionary access on blocks.
1164         * python/py-block.c (blpy_getitem): New function.
1165         (block_object_as_mapping): New struct.
1166         (block_object_type): Use new struct for tp_as_mapping field.
1167
1168 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1169
1170         * objfiles.h (objfile): Add a comment describing partial symbols.
1171
1172 2019-08-05  Tom Tromey  <tromey@adacore.com>
1173
1174         * compile/compile.c (_initialize_compile): Use _(), not N_().
1175         * thread.c (_initialize_thread): Use _(), not N_().
1176         * stack.c (_initialize_stack): Use _(), not N_().
1177         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1178
1179 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1180
1181         * dwarf2read.c (struct dw2_symtab_iterator):
1182         <want_specific_block>: Remove.
1183         <block_index>: Change type to gdb::optional.
1184         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1185         change type of BLOCK_INDEX parameter to gdb::optional.
1186         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1187         (dw2_lookup_symbol): Don't pass argument for
1188         WANT_SPECIFIC_BLOCK.
1189         (dw2_expand_symtabs_for_function): Don't pass argument for
1190         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1191         (class dw2_debug_names_iterator)
1192         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1193         parameter, change BLOCK_INDEX type to gdb::optional.
1194         <m_want_specific_block>: Remove.
1195         <m_block_index>: Change type to gdb::optional.
1196         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1197         gdb::optional.  Re-write in function of gdb::optional.
1198         (dw2_debug_names_lookup_symbol): Don't pass argument for
1199         WANT_SPECIFIC_BLOCK.
1200         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1201         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1202         BLOCK_INDEX.
1203
1204 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1205
1206         * NEWS: Mention changes to "info sources" command.
1207
1208 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1209
1210         * symtab.c (filename_partial_match_opts): New struct type.
1211         (struct output_source_filename_data): New members
1212         regexp, c_regexp, partial_match.
1213         (output_source_filename): Use new members to decide to print file.
1214         (info_sources_option_defs): New variable.
1215         (make_info_sources_options_def_group, print_info_sources_header,
1216         info_sources_command_completer):
1217         New functions.
1218         (info_sources_command): Read new optional arguments.
1219         (_initialize_symtab): Update info sources help.
1220
1221 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1222
1223         * ada-lang.c (exception_support_info_v0): Renamed from...
1224         (default_exception_support_info): ... this.  Create new
1225         definition for v1.
1226         (ada_has_this_exception_support): Look up catch_handlers_sym.
1227         (ada_exception_support_info_sniffer): Try v0 after default.
1228
1229 2019-08-01  Tom Tromey  <tromey@adacore.com>
1230
1231         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1232         gdbarch.h.
1233
1234 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1235
1236         * s12z-tdep.c: Fix include path for s12z-opc.h.
1237
1238 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1239
1240         * NEWS: Require GNU make 3.82.
1241
1242 2019-07-16  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1245         declare.
1246
1247 2019-07-30  Tom Tromey  <tromey@adacore.com>
1248
1249         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1250
1251 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1252
1253         * printcmd.c (print_address_symbolic): Print negative offsets.
1254         (build_address_symbolic): Force signed arithmetic when computing
1255         offset.
1256
1257 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1258
1259         PR/24474: Add a function to lookup static variables.
1260         * NEWS: Mention this new function.
1261         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1262         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1263         * python/python.c (python_GdbMethods): Add new function.
1264
1265 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1266
1267         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1268         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1269         (objfpy_lookup_static_symbol): New function.
1270         (objfile_object_methods): Add new functions.
1271
1272 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1273
1274         * NEWS: Mention 'set|show print frame-info'.  Mention new
1275         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1276         backtrace argument.  Mention that python frame filtering code
1277         is now consistent with what 'backtrace' command prints.
1278
1279 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1280
1281         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1282         comments.
1283         (print_frame_info_auto, print_frame_info_source_line,
1284         print_frame_info_location, print_frame_info_source_and_location,
1285         print_frame_info_location_and_address, print_frame_info_short_location):
1286         New declarations.
1287         (struct frame_print_options): New member print_frame_info.
1288         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1289         * stack.h (get_user_print_what_frame_info): New declaration.
1290         (frame_show_address): New declaration.
1291         * stack.c (print_frame_arguments_choices): New value 'presence'.
1292         (print_frame_info_auto, print_frame_info_source_line,
1293         print_frame_info_location, print_frame_info_source_and_location,
1294         print_frame_info_location_and_address, print_frame_info_short_location,
1295         print_frame_info_choices, print_frame_info_print_what): New definitions.
1296         (print_frame_args): Only print dots for args if print frame-arguments
1297         is 'presence'.
1298         (frame_print_option_defs): New element for "frame-info".
1299         (get_user_print_what_frame_info): New function.
1300         (frame_show_address): Make non static.  Move comment to stack.h.
1301         (print_frame_info_to_print_what): New function.
1302         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1303         to decide what to print.
1304         (backtrace_command_1): Handle the new print_frame_arguments_presence
1305         value.
1306         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1307         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1308         (py_print_frame): In non-mi mode, use LOCATION as default for
1309         print_what, similarly to frame information printed directly by
1310         backtrace command. Handle frame-info user option in non MI mode.
1311
1312 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1313
1314         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1315         Add case for debugging 32-bit target on 64-bit host.  Revise
1316         comment.
1317
1318 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1319
1320         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1321         instead of find_function_entry_range_from_pc.
1322
1323 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1324
1325         * stack.c (find_frame_funname): Remove code which preferred
1326         minsym over symtab sym in "certain pathological cases".
1327
1328         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1329         parameter.  Change type of "do_demangle" to bool.
1330         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1331         Pass suitable "prefer_sym_over_minsym" flag to
1332         build_address_symbolic().  Don't output "+" for negative offsets.
1333         * printcmd.c (print_address_symbolic): Update invocation of
1334         build_address_symbolic to include a "prefer_sym_over_minsym"
1335         flag.
1336         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1337         Restrict cases in which use of minimal symbol is preferred to that
1338         of a found symbol.  Update comments.
1339
1340         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1341         for entry pc when entry pc is out of range for that FDE.
1342
1343 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1344
1345         PR gdb/24839:
1346         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1347         type.
1348
1349 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1350
1351         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1352         this function's Python signature.
1353
1354
1355 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1356
1357         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1358         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1359         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1360         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1361         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1362
1363
1364 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1365
1366         * h8300-tdep.c (h8300_register_name_common): New.
1367         h8300_register_name): Use h8300_register_name_common.
1368         (h8300s_register_name): Likewise.
1369         (h8300sx_register_name): Likewise.
1370         (h8300h_register_nam): New.
1371         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1372
1373
1374 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1375
1376         * arm-tdep.c (arm_skip_cmse_entry): New function.
1377         (arm_is_sgstubs_section): New function.
1378         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1379
1380 2019-07-22  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1383         Don't self-assign.
1384
1385 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1388         type_print.
1389
1390 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1391
1392         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1393         so that GDB doesn't match any msymbols when searching in the
1394         TYPES_DOMAIN.
1395         (print_symbol_info): Print using typedef_print or type_print based
1396         on the type of the symbol.  Add updated FIXME comment moved from...
1397         (_initialize_symtab): ... move and update FIXME comment to above.
1398
1399 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1400
1401         * NEWS: Mention adding -q option to "info types".
1402         * symtab.c (struct info_types_options): New struct.
1403         (info_types_options_defs): New variable.
1404         (make_info_types_options_def_group): New function.
1405         (info_types_command): Use gdb::option framework to parse options.
1406         (info_types_command_completer): New function.
1407         (_initialize_symtab): Extend the help text on "info types" and
1408         register command completer.
1409
1410 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1411
1412         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1413         (lookup_symbol_in_objfile): Change int to block_enum and add a
1414         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1415
1416 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1417
1418         * MAINTAINERS (Write After Approval): Add self.
1419
1420 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1421
1422         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1423         instruction to the dummy code region.
1424
1425 2019-07-19  Tom Tromey  <tromey@adacore.com>
1426
1427         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1428         (ARGSUSED, PARAMS, __func__): Remove rules.
1429
1430 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1431
1432         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1433         * features/arm/arm-with-iwmmxt.c: Remove.
1434         * features/arm/arm-with-iwmmxt.xml: Remove.
1435         * features/arm/arm-with-m-fpa-layout.c: Remove.
1436         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1437         * features/arm/arm-with-m-vfp-d16.c: Remove.
1438         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1439         * features/arm/arm-with-m.c: Remove.
1440         * features/arm/arm-with-m.xml: Remove.
1441         * features/arm/arm-with-neon.c: Remove.
1442         * features/arm/arm-with-neon.xml: Remove.
1443         * features/arm/arm-with-vfpv2.c: Remove.
1444         * features/arm/arm-with-vfpv2.xml: Remove.
1445         * features/arm/arm-with-vfpv3.c: Remove.
1446         * features/arm/arm-with-vfpv3.xml: Remove.
1447
1448 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1449
1450         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1451
1452 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1453
1454         * arch/aarch32.c (aarch32_create_target_description): Create
1455         target descriptions using features.
1456         * arch/arm.c (arm_create_target_description)
1457         (arm_create_mprofile_target_description): Likewise.
1458         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1459
1460 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1461
1462         * Makefile.in: Add new files.
1463         * aarch32-tdep.c: New file.
1464         * aarch32-tdep.h: New file.
1465         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1466         Call aarch32_read_description.
1467         * arch/aarch32.c: New file.
1468         * arch/aarch32.h: New file.
1469         * arch/arm.c (arm_create_target_description)
1470         (arm_create_mprofile_target_description): New function.
1471         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1472         (arm_create_target_description)
1473         (arm_create_mprofile_target_description): New declaration.
1474         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1475         read_description functions.
1476         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1477         Likewise.
1478         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1479         * arm-tdep.c (tdesc_arm_list): New variable.
1480         (arm_register_g_packet_guesses): Call create description functions.
1481         (arm_read_description) (arm_read_mprofile_description): New
1482         function.
1483         * arm-tdep.h (arm_read_description)
1484         (arm_read_mprofile_description): Add declaration.
1485         * configure.tgt: Add new files.
1486
1487 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1488
1489         * top.c (new_ui_command): Open specified terminal just once.
1490
1491 2019-07-18  Tom Tromey  <tromey@adacore.com>
1492
1493         * symtab.c (main_name): Constify return type.
1494         * symfile.c (set_initial_language): Update.
1495         * symtab.h (main_name): Constify return type.
1496
1497 2019-07-17  Tom Tromey  <tom@tromey.com>
1498
1499         * tui/tui-winsource.c (tui_update_source_window)
1500         (tui_update_source_window_as_is)
1501         (tui_update_source_windows_with_line): Remove return.
1502         * tui/tui-disasm.c (tui_show_disassem)
1503         (tui_show_disassem_and_update_source): Remove return.
1504         * tui/tui.c (tui_reset): Remove return.
1505         * tui/tui-wingeneral.c
1506         (tui_check_and_display_highlight_if_needed): Remove return.
1507
1508 2019-07-17  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1511
1512 2019-07-17  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-winsource.h (struct tui_exec_info_window)
1515         (struct tui_source_window_base): Move from tui-data.h.
1516         * tui/tui-winsource.c: Move many method definitions from
1517         elsewhere.  Remove "structuring" comments.
1518         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1519         (tui_source_window_base::refresh_window): Move to
1520         tui-winsource.c.
1521         * tui/tui-win.c (tui_source_window_base::refresh_all)
1522         (tui_source_window_base::update_tab_width)
1523         (tui_source_window_base::set_new_height)
1524         (tui_source_window_base::do_make_visible_with_new_height): Move to
1525         tui-winsource.c.
1526         * tui/tui-source.h: Update.
1527         * tui/tui-source.c (tui_source_window_base::reset): Move to
1528         tui-winsource.c.
1529         * tui/tui-disasm.h: Update.
1530         * tui/tui-data.h (struct tui_exec_info_window): Move to
1531         tui-winsource.h.
1532         (struct tui_source_window_base): Likewise.
1533         * tui/tui-data.c (tui_source_window_base::clear_detail)
1534         (tui_source_window_base, ~tui_source_window_base): Move to
1535         tui-winsource.c.
1536
1537 2019-07-17  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-win.c (tui_resize_all)
1540         (tui_source_window_base::update_tab_width)
1541         (tui_adjust_win_heights): Update.
1542         (tui_win_info::make_invisible_and_set_new_height): Rename from
1543         make_invisible_and_set_new_height.
1544         * tui/tui-data.h (struct tui_win_info)
1545         <make_invisible_and_set_new_height>: New method.
1546
1547 2019-07-17  Tom Tromey  <tom@tromey.com>
1548
1549         * tui/tui.c: Update.
1550         * tui/tui-source.h (struct tui_source_window): Move from
1551         tui-data.h.
1552         * tui/tui-layout.c: Update.
1553         * tui/tui-disasm.c: Update.
1554         * tui/tui-data.h (struct tui_source_window): Move to
1555         tui-source.h.
1556
1557 2019-07-17  Tom Tromey  <tom@tromey.com>
1558
1559         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1560         tui-data.h.
1561         * tui/tui-data.h (struct tui_disasm_window): Move to
1562         tui-disasm.h.
1563
1564 2019-07-17  Tom Tromey  <tom@tromey.com>
1565
1566         * tui/tui-regs.h (struct tui_data_item_window): Move from
1567         tui-data.h.
1568         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1569         * tui/tui-data.h (struct tui_data_item_window): Move to
1570         tui-regs.h.
1571         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1572
1573 2019-07-17  Tom Tromey  <tom@tromey.com>
1574
1575         * tui/tui.c: Update.
1576         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1577         (tui_cmd_window::max_height): Move to tui-command.c.
1578         * tui/tui-layout.c: Update.
1579         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1580         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1581         tui-command.c.
1582         * tui/tui-command.h (struct tui_cmd_window): Move from
1583         tui-data.h.
1584         * tui/tui-command.c: Remove "structuring" comments.
1585         (tui_cmd_window::clear_detail)
1586         (tui_cmd_window::do_make_visible_with_new_height)
1587         (tui_cmd_window::max_height): Move from elsewhere.
1588
1589 2019-07-17  Tom Tromey  <tom@tromey.com>
1590
1591         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1592         Now static.
1593         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1594         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1595
1596 2019-07-17  Tom Tromey  <tom@tromey.com>
1597
1598         * tui/tui.c: Update.
1599         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1600         tui-regs.c.
1601         * tui/tui-windata.h: Remove file.
1602         * tui/tui-windata.c: Remove file.
1603         * tui/tui-win.c (tui_data_window::set_new_height)
1604         (tui_data_window::do_make_visible_with_new_height): Move to
1605         tui-regs.c.
1606         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1607         * tui/tui-regs.c: Remove "structuring" comments.
1608         (tui_data_window::first_data_item_displayed)
1609         (tui_data_window::delete_data_content_windows)
1610         (tui_data_window::erase_data_content)
1611         (tui_data_window::display_all_data)
1612         (tui_data_window::refresh_all)
1613         (tui_data_window::do_scroll_vertical)
1614         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1615         (tui_data_window::do_make_visible_with_new_height)
1616         (tui_data_window::refresh_window): Move from elsewhere.
1617         (_initialize_tui_regs): Move to end of file.
1618         * tui/tui-layout.c: Update.
1619         * tui/tui-hooks.c: Update.
1620         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1621         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1622         tui-regs.c.
1623         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1624
1625 2019-07-17  Tom Tromey  <tom@tromey.com>
1626
1627         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1628         seen.
1629
1630 2019-07-17  Tom Tromey  <tom@tromey.com>
1631
1632         * tui/tui-win.c (tui_source_window_base::set_new_height)
1633         (tui_source_window_base::do_make_visible_with_new_height): Use
1634         m_has_locator field directly.
1635         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1636         method.
1637         (struct tui_source_window_base) <has_locator>: Likewise.
1638
1639 2019-07-17  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1642         Don't declare.
1643         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1644         Remove.
1645         * tui/tui-win.c (tui_source_window_base::set_new_height)
1646         (tui_source_window_base::set_new_height)
1647         (make_invisible_and_set_new_height)
1648         (tui_source_window_base::do_make_visible_with_new_height)
1649         (tui_source_window_base::do_make_visible_with_new_height):
1650         Update.
1651         * tui/tui-layout.c (show_source_disasm_command, show_data)
1652         (show_source_or_disasm_and_command): Update.
1653         * tui/tui-layout.c (show_layout): Update.
1654
1655 2019-07-17  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-layout.c (make_data_window): Remove.
1658         (show_data): Unify creation and re-initialization cases.
1659
1660 2019-07-17  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-layout.c (make_source_window, make_disasm_window):
1663         Remove.
1664         (show_data): Unify creation and re-initialization cases.
1665
1666 2019-07-17  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-layout.c (make_command_window): Remove.
1669         (show_source_disasm_command, show_source_or_disasm_and_command):
1670         Unify creation and re-initialization cases.
1671
1672 2019-07-17  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1675         creation and re-initialization cases.
1676
1677 2019-07-17  Tom Tromey  <tom@tromey.com>
1678
1679         * tui/tui-regs.c (tui_get_register): Return void.
1680
1681 2019-07-17  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1684         Simplify.
1685
1686 2019-07-17  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1689         resetting.
1690
1691 2019-07-17  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1694         * tui/tui-regs.c (tui_reg_layout): New function.
1695         (tui_show_registers, tui_reg_command): Use it.
1696         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1697         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1698         parameters.
1699         (tui_layout_command): Remove.
1700
1701 2019-07-17  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-layout.h (tui/tui-layout): Return void.
1704         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1705
1706 2019-07-17  Tom Tromey  <tom@tromey.com>
1707
1708         * tui/tui-layout.c (show_source_disasm_command, show_data):
1709         Update.
1710         (reset_locator): Remove.
1711         (show_source_or_disasm_and_command): Update.
1712
1713 2019-07-17  Tom Tromey  <tom@tromey.com>
1714
1715         * tui/tui-source.c (tui_source_window_base::reset): Remove
1716         win_type parameter.
1717         * tui/tui-layout.c (make_command_window, make_source_window)
1718         (make_disasm_window, make_data_window)
1719         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1720         (reset_locator, show_source_or_disasm_and_command): Update.
1721         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1722         win_type parameter.
1723         (struct tui_source_window_base) <reset>: Likewise.
1724
1725 2019-07-17  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-layout.c (show_source_disasm_command): Use
1728         reset_locator.
1729         (reset_locator): New function.
1730         (init_and_make_win): Remove.
1731         (show_source_or_disasm_and_command): Use reset_locator.
1732
1733 2019-07-17  Tom Tromey  <tom@tromey.com>
1734
1735         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1736         condition.
1737         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1738         Remove condition.
1739         * tui/tui-source.c (tui_source_window_base::reset): New method.
1740         * tui/tui-layout.c (make_command_window): Don't call
1741         init_and_make_win.
1742         (make_source_window, make_disasm_window): Don't call
1743         make_source_or_disasm_window.
1744         (make_data_window): Don't call init_and_make_win.  Change calling
1745         convention.
1746         (show_source_disasm_command, show_data): Simplify.
1747         (make_source_or_disasm_window): Remove.
1748         (show_source_or_disasm_and_command): Simplify.
1749         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1750         (struct tui_source_window_base) <reset>: Likewise.
1751         <execution_info>: Remove initializer.
1752         * tui/tui-data.c (tui_source_window_base): Initialize
1753         execution_info.
1754
1755 2019-07-17  Tom Tromey  <tom@tromey.com>
1756
1757         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1758         variable.
1759
1760 2019-07-17  Tom Tromey  <tom@tromey.com>
1761
1762         * tui/tui.c (tui_rl_other_window): Update.
1763         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1764         superclass method first.  Always iterate over regs_content.
1765         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1766         method.
1767         * tui/tui-win.c (tui_set_focus_command): Update.
1768
1769 2019-07-17  Tom Tromey  <tom@tromey.com>
1770
1771         * tui/tui-win.c (tui_set_focus_command): Rename from
1772         tui_set_focus.  Call tui_enable.
1773         (tui_set_focus_command): Remove.
1774
1775 2019-07-17  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1778         refresh_window.
1779         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1780         touchwin.
1781         (tui_data_window::refresh_window): Call refresh_window on data
1782         items.  Always call superclass refresh_window.
1783         (tui_win_info::refresh): Remove.
1784         (tui_source_window_base::refresh_window): Update.
1785         (tui_refresh_all): Update.
1786         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1787         refresh_window.
1788         (show_source_or_disasm_and_command): Likewise.
1789         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1790         (struct tui_source_window_base) <refresh>: Likewise.
1791
1792 2019-07-17  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-winsource.c (tui_clear_source_content)
1795         (tui_show_source_content): Update.
1796         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1797         whether content is empty.
1798         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1799         Remove.
1800
1801 2019-07-17  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1804         window's contents.
1805         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1806         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1807
1808 2019-07-17  Tom Tromey  <tom@tromey.com>
1809
1810         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1811         (struct tui_data_item_window): Update.
1812
1813 2019-07-17  Tom Tromey  <tom@tromey.com>
1814
1815         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1816         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1817         defines.
1818
1819 2019-07-17  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-winsource.h (tui_erase_source_content)
1822         (tui_clear_source_content): Remove "display_prompt" parameter.
1823         * tui/tui-winsource.c (tui_update_source_window_as_is)
1824         (tui_update_source_windows_with_addr): Update.
1825         (tui_clear_source_content): Remove "display_prompt" parameter.
1826         (tui_erase_source_content): Likewise.  Simplify.
1827         (tui_show_source_content): Update.
1828         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1829         * tui/tui-stack.c (tui_show_frame_info): Update.
1830         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1831         Remove defines.
1832
1833 2019-07-17  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1836         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1837         parameter.
1838         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1839         parameter.
1840
1841 2019-07-17  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-winsource.c (tui_clear_source_content)
1844         (tui_show_source_content, tui_show_exec_info_content)
1845         (tui_clear_exec_info_content): Update.
1846         * tui/tui-stack.c (tui_show_locator_content): Update.
1847         (tui_show_frame_info): Update.
1848         * tui/tui-source.h (tui_source_window): Don't declare.
1849         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1850         from tui_source_is_displayed.
1851         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1852         Remove field.
1853         (struct tui_source_window_base) <content_in_use>: New field.  Now
1854         bool.
1855         (struct tui_source_window) <showing_source_p>: New method.
1856         (TUI_SRC_WIN): Change cast.
1857         * tui/tui-data.c (tui_initialize_static_data): Update.
1858
1859 2019-07-17  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1862         location_matches_p.
1863         * tui/tui-source.c (tui_source_window::location_matches_p): New
1864         method.
1865         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1866         method.
1867         * tui/tui-data.h (struct tui_source_window_base)
1868         <location_matches_p>: New method.
1869         (struct tui_source_window, struct tui_disasm_window)
1870         <location_matches_p>: Likewise.
1871
1872 2019-07-17  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-win.c (tui_set_win_height_command): Rename from
1875         tui_set_win_height.
1876         (tui_set_win_height_command): Remove.
1877
1878 2019-07-17  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-source.c (tui_source_window): New constructor.  Add
1881         observer.
1882         (~tui_source_window): New destructor.
1883         (tui_source_window::style_changed): New method.
1884         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1885         (tui_attach_detach_observers): Update.
1886         * tui/tui-data.h (struct tui_source_window): Make constructor not
1887         inline.  Add destructor.
1888         (struct tui_source_window) <style_changed>: New method.
1889         <m_observable>: New member.
1890
1891 2019-07-17  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1894         * tui/tui-win.c (tui_resize_all): Fix typo.
1895
1896 2019-07-17  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1899         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1900         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1901         * tui/tui-win.c (window_name_completer): Use foreach.
1902         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1903         (update_tab_width): Likewise.
1904         * tui/tui-layout.c (show_layout): Update.
1905         * tui/tui-data.h (class tui_window_iterator): New.
1906         (struct all_tui_windows): New.
1907         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1908
1909 2019-07-17  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1912         parameter.  Don't reference globals.
1913         (tui_reg_command): Update.
1914
1915 2019-07-17  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-regs.c (tui_show_registers): Simplify.
1918
1919 2019-07-17  Tom Tromey  <tom@tromey.com>
1920
1921         * tui/tui-regs.c (tui_show_registers): Update.
1922         (tui_show_register_group): Add win_info parameter.
1923
1924 2019-07-17  Tom Tromey  <tom@tromey.com>
1925
1926         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1927         Rename from tui_display_reg_element_at_line.
1928         (tui_data_window::display_registers_from_line): Update.
1929         * tui/tui-data.h (struct tui_data_window)
1930         <display_reg_element_at_line>: New method.
1931
1932 2019-07-17  Tom Tromey  <tom@tromey.com>
1933
1934         * tui/tui-regs.h (tui_display_registers_from)
1935         (tui_display_registers_from_line): Don't declare.
1936         * tui/tui-windata.c (tui_data_window::display_all_data)
1937         (tui_data_window::refresh_all)
1938         (tui_data_window::do_scroll_vertical): Update.
1939         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1940         from tui_display_registers_from.
1941         (tui_display_reg_element_at_line): Update.
1942         (tui_data_window::display_registers_from_line): Rename from
1943         tui_display_registers_from_line.
1944         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1945         display_registers_from_line>: New methods.
1946
1947 2019-07-17  Tom Tromey  <tom@tromey.com>
1948
1949         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1950         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1951         from tui_erase_data_content.
1952         (tui_data_window::display_all_data)
1953         (tui_data_window::refresh_all)
1954         (tui_data_window::do_scroll_vertical): Update.
1955         * tui/tui-regs.c (tui_show_registers): Update.
1956         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1957         New method.
1958
1959 2019-07-17  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1962         declare.
1963         * tui/tui-windata.c
1964         (tui_data_window::delete_data_content_windows): Rename from
1965         tui_delete_data_content_windows.
1966         (tui_data_window::display_all_data)
1967         (tui_data_window::do_scroll_vertical): Update.
1968         * tui/tui-data.h (struct tui_data_window)
1969         <delete_data_content_windows>: New method.
1970
1971 2019-07-17  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1974         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1975
1976 2019-07-17  Tom Tromey  <tom@tromey.com>
1977
1978         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1979         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1980         from tui_display_all_data.
1981         * tui/tui-win.c
1982         (tui_data_window::do_make_visible_with_new_height): Update.
1983         * tui/tui-regs.c (tui_show_registers): Update.
1984         * tui/tui-layout.c (tui_set_layout): Update.
1985         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1986         method.
1987
1988 2019-07-17  Tom Tromey  <tom@tromey.com>
1989
1990         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1991         * tui/tui-windata.c (tui_display_data_from): Remove.
1992         (tui_data_window::refresh_all): Update.
1993
1994 2019-07-17  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1997         * tui/tui-windata.c (tui_display_data_from_line): Remove.
1998         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1999         tui_display_registers_from_line.
2000         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2001         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2002         "force_display" parameter.
2003
2004 2019-07-17  Tom Tromey  <tom@tromey.com>
2005
2006         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2007         declare.
2008         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2009         Rename from tui_first_reg_element_no_inline.
2010         (tui_display_reg_element_at_line)
2011         (tui_display_registers_from_line): Update.
2012         * tui/tui-data.h (struct tui_data_window)
2013         <first_reg_element_no_inline>: New method.
2014
2015 2019-07-17  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-windata.c (tui_display_data_from)
2018         (tui_data_window::do_scroll_vertical): Update.
2019         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2020         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2021         Rename from tui_line_from_reg_element_no.
2022         (tui_display_registers_from_line): Update.
2023         * tui/tui-data.h (struct tui_data_window)
2024         <line_from_reg_element_no>: New method.
2025
2026 2019-07-17  Tom Tromey  <tom@tromey.com>
2027
2028         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2029         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2030         tui_last_regs_line_no.
2031         (tui_display_reg_element_at_line)
2032         (tui_display_registers_from_line): Update.
2033         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2034         method.
2035
2036 2019-07-17  Tom Tromey  <tom@tromey.com>
2037
2038         PR tui/24722:
2039         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2040         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2041         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2042         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2043         (tui_update_breakpoint_info): Likewise.
2044         * tui/tui-hooks.c (tui_event_create_breakpoint)
2045         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2046         Update.
2047
2048 2019-07-17  Tom Tromey  <tom@tromey.com>
2049
2050         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2051
2052 2019-07-17  Tom Tromey  <tom@tromey.com>
2053
2054         * tui/tui-winsource.c (tui_update_source_window_as_is)
2055         (tui_update_source_windows_with_addr): Update.
2056         * tui/tui-source.h (tui_set_source_content)
2057         (tui_show_symtab_source): Add "win_info" parameter.
2058         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2059         parameter.
2060         (tui_show_symtab_source): Likewise.
2061
2062 2019-07-17  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-wingeneral.c
2065         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2066
2067 2019-07-17  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2070         (struct tui_cmd_window) <can_scroll>: New method.
2071         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2072         method.
2073
2074 2019-07-17  Tom Tromey  <tromey@adacore.com>
2075
2076         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2077         do_field_signed>: Rename.  Change type of "value".
2078         * ui-out.c (ui_out::field_signed): Rename from field_int.
2079         Change type of "value".
2080         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2081         type of "value".
2082         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2083         do_field_int.  Change type of "value".
2084         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2085         do_field_int.  Change type of "value".
2086         * tracepoint.c (trace_status_mi, tfind_1)
2087         (print_one_static_tracepoint_marker): Update.
2088         * thread.c (print_thread_info_1, print_selected_thread_frame):
2089         Update.
2090         * stack.c (print_frame, print_frame_info): Update.
2091         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2092         Update.
2093         * source.c (print_source_lines_base): Update.
2094         * skip.c (info_skip_command): Update.
2095         * record-btrace.c (btrace_ui_out_decode_error)
2096         (btrace_call_history_src_line): Update.
2097         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2098         Update.
2099         * progspace.c (print_program_space): Update.
2100         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2101         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2102         do_field_int.  Change type of "value".
2103         * mi/mi-out.c (mi_ui_out::do_table_begin)
2104         (mi_ui_out::do_table_header): Update.
2105         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2106         type of "value".
2107         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2108         (mi_cmd_data_list_changed_registers, output_register)
2109         (mi_cmd_data_read_memory, mi_load_progress)
2110         (mi_cmd_trace_frame_collected): Update.
2111         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2112         Update.
2113         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2114         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2115         (mi_cmd_var_list_children, varobj_update_one): Update.
2116         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2117         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2118         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2119         * inferior.c (print_inferior): Update.
2120         * gdb_bfd.c (print_one_bfd): Update.
2121         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2122         Update.
2123         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2124         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2125         do_field_int.  Change type of "value".
2126         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2127         do_field_int.  Change type of "value".
2128         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2129         (print_one_breakpoint_location, print_it_catch_fork)
2130         (print_one_catch_fork, print_it_catch_vfork)
2131         (print_one_catch_vfork, print_it_catch_solib)
2132         (print_it_catch_exec, print_it_ranged_breakpoint)
2133         (print_mention_watchpoint, print_mention_masked_watchpoint)
2134         (bkpt_print_it, update_static_tracepoint): Update.
2135         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2136         * break-catch-syscall.c (print_it_catch_syscall): Update.
2137         * ada-tasks.c (print_ada_task_info): Update.
2138         * ada-lang.c (print_it_exception, print_mention_exception):
2139         Update.
2140
2141 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         PR breakpoints/24541
2144         * gdbarch.c: Regenerate.
2145         * gdbarch.h: Regenerate.
2146         * gdbarch.sh: Adjust return type and parameter types for
2147         'stap_adjust_register'.
2148         (i386_stap_adjust_register): Adjust signature and return new
2149         register name.
2150         * stap-probe.c (stap_parse_register_operand): Adjust use of
2151         'gdbarch_stap_adjust_register'.
2152
2153 2019-07-17  Tom Tromey  <tromey@adacore.com>
2154
2155         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2156         declare VEC.
2157         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2158         std::vector.
2159         (struct s390_process_info): Add initializers.
2160         (s390_add_process): Use new.
2161         (s390_linux_nat_target::low_forget_process): Use delete.
2162         (s390_linux_nat_target::low_new_fork)
2163         (s390_linux_nat_target::stopped_by_watchpoint)
2164         (s390_linux_nat_target::low_prepare_to_resume)
2165         (s390_linux_nat_target::insert_watchpoint)
2166         (s390_linux_nat_target::insert_hw_breakpoint)
2167         (s390_linux_nat_target::remove_watchpoint)
2168         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2169
2170 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2171
2172         * aarch64-fbsd-nat.c: Include regcache.h.
2173         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2174         argument.
2175         (aarch64_fbsd_nat_target::fetch_registers)
2176         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2177         variable.
2178         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2179
2180 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2181
2182         * fbsd-nat.c: Include gdbarch.h.
2183
2184 2019-07-15  Tom Tromey  <tromey@adacore.com>
2185
2186         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2187
2188 2019-07-15  Tom Tromey  <tromey@adacore.com>
2189
2190         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2191         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2192         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2193         * cli-out.c (cli_ui_out::do_field_int): New method.
2194         * ui-out.c (ui_out::field_unsigned): New method.
2195         * symfile.c (generic_load): Use field_unsigned.
2196         (print_transfer_performance): Likewise.
2197         * record-btrace.c (ui_out_field_uint): Remove.
2198         (btrace_call_history_insn_range, btrace_call_history): Use
2199         field_unsigned.
2200         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2201         field_unsigned.
2202         * ui-out.h (class ui_out) <field_unsigned>: New method.
2203         <do_field_unsigned>: Likewise.
2204
2205 2019-07-15  Tom Tromey  <tromey@adacore.com>
2206
2207         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2208         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2209         * target.c (flash_erase_command): Use field_string.
2210         * infrun.c (print_signal_received_reason): Use field_string.
2211         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2212         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2213         field_string.
2214         * ada-tasks.c (print_ada_task_info): Use field_string.
2215
2216 2019-07-15  Tom Tromey  <tromey@adacore.com>
2217
2218         * target.c (flash_erase_command): Use field_core_addr.
2219         * symfile.c (generic_load): Use field_core_addr.
2220         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2221         Use field_core_addr.
2222         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2223         field_core_addr.
2224
2225 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2226
2227         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2228         value if its desired type is smaller than a CORE_ADDR and signed.
2229
2230 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2231
2232         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2233         of changes to field names, and use new is_reference field to
2234         decide if a property is a reference or not.
2235         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2236         field.
2237         (struct dwarf2_property_baton): Update header comment, rename
2238         'referenced_type' to 'property_type' and update comments.
2239         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2240         default property type, store in property baton, update to take
2241         accound of renamed field.
2242         (read_func_scope): Update call to attr_to_dynamic_prop.
2243         (read_array_type): Likewise.
2244         (dwarf2_per_cu_addr_sized_int_type): New function.
2245         (read_subrange_index_type): Move type finding code to
2246         dwarf2_per_cu_addr_sized_int_type.
2247         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2248         (dwarf2_per_cu_addr_type): New function.
2249         (set_die_type): Update calls to attr_to_dynamic_prop.
2250
2251 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * dwarf2read.c (read_subrange_index_type): New function.
2254         (read_subrange_type): Move code into new function and call it.
2255         * gdbtypes.c (create_range_type): Add some asserts.
2256
2257 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2260         update return statements.
2261         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2262         declaration, and update comment to match.
2263         * gdbtypes.c (resolve_dynamic_array): Update call to
2264         dwarf2_evaluate_property to match new return type.
2265
2266 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * valarith.c (value_subscripted_rvalue): Change lowerbound
2269         parameter type from int to LONGEST.
2270         * value.h (value_subscripted_rvalue): Likewise in declaration.
2271
2272 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * cli/cli-utils.c (info_print_command_completer): New function.
2275         * cli/cli-utils.h: Add 'completer.h' include, and forward
2276         declaration for 'struct cmd_list_element'.
2277         (info_print_command_completer): Declare.
2278         * stack.c (_initialize_stack): Add completer for 'info locals' and
2279         'info args'.
2280         * symtab.c (_initialize_symtab): Add completer for 'info
2281         variables' and 'info functions'.
2282         * NEWS: Mention completion for additional info commands.
2283
2284 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * cli/cli-utils.c (extract_info_print_args): Delete.
2287         (extract_arg_maybe_quoted): Delete.
2288         (info_print_options_defs): New variable.
2289         (make_info_print_options_def_group): New function.
2290         (extract_info_print_options): Define new function.
2291         * cli/cli-utils.h (extract_info_print_args): Delete.
2292         (struct info_print_options): New structure.
2293         (extract_info_print_options): Declare new function.
2294         * stack.c (info_locals_command): Update to use new
2295         extract_info_print_options, also add a header comment.
2296         (info_args_command): Likewise.
2297         * symtab.c (info_variables_command): Likewise.
2298         (info_functions_command): Likewise.
2299
2300 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2303         to extract string arguments.
2304         * common/common-utils.c (extract_string_maybe_quoted): New function.
2305         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2306
2307 2019-07-11  Tom Tromey  <tromey@adacore.com>
2308
2309         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2310         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2311         * top.h (gdbinit): Don't declare.
2312         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2313         into...
2314         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2315         * top.c (gdb_init): Don't call init_cli_cmds.
2316         (gdbinit): Remove.
2317         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2318
2319 2019-07-11  Tom Tromey  <tromey@adacore.com>
2320
2321         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2322         after it has been moved.
2323
2324 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2325
2326         * valops.c (value_must_coerce_to_target): Change return type to
2327         bool.
2328         * value.h (value_must_coerce_to_target): Likewise.
2329
2330 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2331
2332         * breakpoint.c (is_hardware_watchpoint): Remove
2333         forward-declaration.
2334         (is_masked_watchpoint): Change return type to bool.
2335         (is_tracepoint): Likewise.
2336         (is_breakpoint): Likewise.
2337         (is_hardware_watchpoint): Likewise.
2338         (is_watchpoint): Likewise.
2339         (is_no_memory_software_watchpoint): Likewise.
2340         (is_catchpoint): Likewise.
2341         (breakpoint_1): Make FILTER parameter's return type bool.
2342         is_masked_watchpoint): Change return type to bool.
2343         (save_breakpoints): Make FILTER parameter's return type bool.
2344         * breakpoint.h (is_breakpoint): Change return type to bool.
2345         (is_watchpoint): Likewise.
2346         (is_catchpoint): Likewise.
2347         (is_tracepoint): Likewise.
2348
2349 2019-07-10  Tom Tromey  <tom@tromey.com>
2350
2351         * defs.h: Don't include gdbarch.h.
2352         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2353         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2354         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2355         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2356         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2357         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2358         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2359         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2360         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2361         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2362         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2363         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2364         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2365         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2366         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2367         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2368         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2369         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2370         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2371         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2372         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2373         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2374         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2375         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2376         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2377         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2378         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2379
2380 2019-07-10  Tom Tromey  <tromey@adacore.com>
2381
2382         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2383         * breakpoint.c (init_ada_exception_breakpoint): Register as
2384         bp_catchpoint.
2385         (print_one_breakpoint_location, print_one_breakpoint): Use
2386         is_ada_exception_catchpoint.
2387         * ada-lang.c (class ada_catchpoint_location): Pass
2388         bp_loc_software_breakpoint to bp_location constructor.
2389         (is_ada_exception_catchpoint): New function.
2390
2391 2019-07-10  Tom Tromey  <tromey@adacore.com>
2392
2393         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2394         VEC.
2395         (struct arm_exidx_entry): New method operator<.
2396         (struct arm_exidx_data) <section_maps>: Change type.
2397         (arm_exidx_data_free): Remove.
2398         (arm_exidx_data_key): Change type.  Move lower.
2399         (arm_exidx_new_objfile): Update.
2400         (arm_compare_exidx_entries): Remove.
2401         (arm_find_exidx_entry, _initialize_arm_tdep)
2402
2403 2019-07-10  Tom Tromey  <tromey@adacore.com>
2404
2405         * solib-spu.c (ocl_program_data_key): Change type.
2406         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2407         Update.
2408
2409 2019-07-10  Tom Tromey  <tromey@adacore.com>
2410
2411         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2412         (struct solib_aix_inferior_data) <library_list>: Change type.
2413         (solib_aix_inferior_data_handle): Change type.
2414         (get_solib_aix_inferior_data): Update.
2415         (solib_aix_free_library_list): Remove.
2416         (library_list_start_library): Update.
2417         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2418         return type.
2419         (solib_aix_get_library_list)
2420         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2421         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2422
2423 2019-07-10  Tom Tromey  <tromey@adacore.com>
2424
2425         * solib-dsbt.c (struct dsbt_info): Add initializers.
2426         (solib_dsbt_pspace_data): Change type.
2427         (dsbt_pspace_data_cleanup): Remove.
2428         (get_dsbt_info, _initialize_dsbt_solib): Update.
2429
2430 2019-07-10  Tom Tromey  <tromey@adacore.com>
2431
2432         * spu-tdep.c (spu_overlay_data): Change type.
2433         (spu_get_overlay_table, spu_overlay_new_objfile)
2434         (_initialize_spu_tdep): Update.
2435
2436 2019-07-10  Tom Tromey  <tromey@adacore.com>
2437
2438         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2439         destructor.
2440         (dbx_objfile_data_key): Change type and declare later.
2441         (DBX_SYMFILE_INFO): Rewrite.
2442         * dbxread.c (dbx_objfile_data_key): Change type.
2443         (dbx_symfile_init): Update.
2444         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2445         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2446         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2447
2448 2019-07-10  Tom Tromey  <tromey@adacore.com>
2449
2450         * jit.c (jit_program_space_key): Change type.  Move lower.
2451         (get_jit_program_space_data): Update.
2452         (jit_program_space_data_cleanup): Remove.
2453         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2454         Update.
2455         (struct jit_program_space_data): Add initializers.
2456
2457 2019-07-10  Tom Tromey  <tromey@adacore.com>
2458
2459         * solib-darwin.c (struct darwin_info): Add initializers.
2460         (solib_darwin_pspace_data): Change type.
2461         (darwin_pspace_data_cleanup): Remove.
2462         (get_darwin_info, _initialize_darwin_solib): Update.
2463
2464 2019-07-10  Tom Tromey  <tromey@adacore.com>
2465
2466         * remote-sim.c (struct sim_inferior_data): Add initializers,
2467         constructor, and destructor.
2468         (sim_inferior_data_key): Change type.  Move lower.
2469         (check_for_duplicate_sim_descriptor): Update.
2470         (get_sim_inferior_data): Use new.  Update.
2471         (~sim_inferior_data_cleanup): Rename from
2472         sim_inferior_data_cleanup.  Simplify.
2473         (gdbsim_close_inferior, simulator_command)
2474         (sim_command_completer, _initialize_remote_sim): Update.
2475         (next_pid, INITIAL_PID): Move earlier.
2476
2477 2019-07-10  Tom Tromey  <tromey@adacore.com>
2478
2479         * python/python-internal.h (create_thread_object): Return
2480         gdbpy_ref.
2481         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2482         * python/py-inferior.c (struct threadlist_entry): Add
2483         constructor.
2484         <thread_obj>: Now a gdbpy_ref.
2485         (thread_to_thread_object): Update.
2486         (add_thread_object): Use new.
2487         (delete_thread_object): Use delete.
2488         (infpy_threads): Update.
2489         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2490         GIL.
2491
2492 2019-07-10  Tom Tromey  <tromey@adacore.com>
2493
2494         * valops.c (value_cast): Specialize error message for Ada.
2495
2496 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2497
2498         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2499
2500 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2501
2502         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2503         bpstat_should_step): Return bool, adjust comments.
2504         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2505         bpstat_should_step): Likewise.
2506
2507 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2508
2509         * features/Makefile: Use feature target descriptions for Arm.
2510         * features/arm/arm-core.c: Generate new file.
2511         * features/arm/arm-fpa.c: Likewise.
2512         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2513         * features/arm/arm-m-profile.c: Likewise.
2514         * features/arm/arm-vfpv2.c: Likewise.
2515         * features/arm/arm-vfpv3.c: Likewise.
2516         * features/arm/xscale-iwmmxt.c: Likewise.
2517         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2518
2519 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2520
2521         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2522         ptrace earlier.
2523
2524 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * features/aarch64-pauth.c: Regenerate.
2527
2528 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2529
2530         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2531         bool.
2532         (bpstat_what): Use false instead of 0.
2533
2534 2019-07-09  Pedro Alves  <palves@redhat.com>
2535
2536         * break-catch-throw.c (is_exception_catchpoint): New.
2537         * breakpoint.c (print_one_breakpoint_location): New parameter
2538         'raw_loc'.  Handle it.  Use
2539         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2540         looking at the breakpoint's type.
2541         (print_one_breakpoint): If handling "maint info breakpoints", also
2542         print locations of exception catchpoints.
2543         * breakpoint.h (is_exception_catchpoint): Declare.
2544
2545 2019-07-09  Pedro Alves  <palves@redhat.com>
2546
2547         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2548         "addr" field.
2549         (allocate_location_exception_catchpoint): New.
2550         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2551         (initialize_throw_catchpoint_ops): Install
2552         allocate_location_exception_catchpoint as allocate_location
2553         method.
2554         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2555         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2556         bp_loc_other.
2557         (breakpoint_address_is_meaningful): Delete.
2558         (bl_address_is_meaningful): New.
2559         (breakpoint_locations_match): Adjust comment.
2560         (bp_location_from_bp_type): New, factored out of...
2561         (bp_location::bp_location(breakpoint *)): ... this.
2562         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2563         factored out of...
2564         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2565         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2566         breakpoint_address_is_meaningful.
2567         (bp_locations_compare): Adjust comment.
2568         (update_global_location_list): Use bl_address_is_meaningful
2569         instead of breakpoint_address_is_meaningful.
2570         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2571         explicit.
2572         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2573         * python/py-breakpoint.c (bppy_get_location): No longer check
2574         whether location is null.
2575
2576 2019-07-09  Pedro Alves  <palves@redhat.com>
2577
2578         PR c++/15468
2579         * breakpoint.c (print_one_breakpoint_location): Remove
2580         single-location assert.
2581
2582 2019-07-09  Tom Tromey  <tom@tromey.com>
2583
2584         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2585         * configure: Rebuild.
2586         * configure.ac: Change common to gdbsupport.
2587         * gdbsupport: Rename from common.
2588         * acinclude.m4: Change common to gdbsupport.
2589         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2590         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2591         gdbsupport.
2592         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2593         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2594         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2595         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2596         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2597         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2598         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2599         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2600         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2601         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2602         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2603         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2604         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2605         coff-pe-read.c, command.h, compile/compile-c-support.c,
2606         compile/compile-c.h, compile/compile-cplus-symbols.c,
2607         compile/compile-cplus-types.c, compile/compile-cplus.h,
2608         compile/compile-loc2c.c, compile/compile.c, completer.c,
2609         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2610         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2611         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2612         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2613         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2614         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2615         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2616         features/aarch64-core.c, features/aarch64-fpu.c,
2617         features/aarch64-pauth.c, features/aarch64-sve.c,
2618         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2619         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2620         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2621         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2622         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2623         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2624         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2625         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2626         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2627         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2628         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2629         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2630         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2631         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2632         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2633         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2634         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2635         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2636         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2637         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2638         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2639         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2640         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2641         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2642         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2643         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2644         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2645         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2646         minsyms.c, mips-linux-tdep.c, namespace.h,
2647         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2648         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2649         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2650         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2651         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2652         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2653         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2654         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2655         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2656         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2657         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2658         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2659         procfs.c, producer.c, progspace.h, psymtab.h,
2660         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2661         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2662         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2663         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2664         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2665         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2666         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2667         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2668         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2669         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2670         target-memory.c, target.c, target.h, target/waitstatus.c,
2671         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2672         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2673         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2674         unittests/array-view-selftests.c,
2675         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2676         unittests/common-utils-selftests.c,
2677         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2678         unittests/format_pieces-selftests.c,
2679         unittests/function-view-selftests.c,
2680         unittests/lookup_name_info-selftests.c,
2681         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2682         unittests/mkdir-recursive-selftests.c,
2683         unittests/observable-selftests.c,
2684         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2685         unittests/parse-connection-spec-selftests.c,
2686         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2687         unittests/scoped_fd-selftests.c,
2688         unittests/scoped_mmap-selftests.c,
2689         unittests/scoped_restore-selftests.c,
2690         unittests/string_view-selftests.c, unittests/style-selftests.c,
2691         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2692         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2693         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2694         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2695         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2696         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2697
2698 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2699
2700         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2701         bool value.
2702         (decode_digits_ordinary): Set explicit_line field in sal.
2703         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2704         symtab_and_line that was set on an explicit line number in
2705         assembler code.  Do always update the recorded symtab and line if
2706         we do skip the prologue.
2707
2708 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2709
2710         * breakpoint.c (set_breakpoint_location_function): Remove
2711         explicit_loc parameter.
2712         (momentary_breakpoint_from_master): Update call to
2713         set_breakpoint_location_function.
2714         (add_location_to_breakpoint): Likewise.
2715
2716 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2717
2718         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2719         required features based on default bfd type when no specific bfd
2720         is present.
2721
2722 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2723
2724         * NEWS: Mention that GDB printf and eval commands can now print
2725         C-style and Ada-style convenience var strings without
2726         calling the inferior.
2727         * printcmd.c (printf_c_string): Locally print GDB internal var
2728         instead of transiting via the inferior.
2729         (printf_wide_c_string): Likewise.
2730
2731 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2732
2733         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2734
2735 2019-07-04  Tom Tromey  <tom@tromey.com>
2736
2737         PR tui/24724:
2738         * tui/tui-winsource.c (tui_clear_source_content): Update.
2739         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2740         (tui_update_breakpoint_info): Update.
2741         (tui_set_exec_info_content): Update.
2742         * tui/tui-source.c (tui_set_source_content_nil): Update.
2743         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2744         has_break.
2745         * tui/tui-data.h (enum tui_bp_flag): New.
2746         (tui_bp_flags): New enum flags type.
2747         (struct tui_source_element) <break_mode>: Change type.  Rename
2748         from has_break.
2749         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2750         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2751         constants.
2752         * tui/tui-winsource.h: Fix comment.
2753
2754 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2755
2756         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2757         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2758         (store_fpregs_to_thread)
2759         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2760         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2761         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2762         (IWMMXT_REGS_SIZE): Add define.
2763         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2764         (fetch_vfp_regs, store_vfp_regs)
2765         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2766         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2767
2768 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2769
2770         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2771         defines.
2772         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2773         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2774         (ARM_INT_REGISTER_SIZE): ...to this.
2775         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2776         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2777         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2778         (arm_linux_collect_gregset, supply_nwfpe_register)
2779         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2780         defines.
2781         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2782         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2783         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2784         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2785         (arm_return_in_memory, arm_store_return_value)
2786         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2787         (arm_record_ld_st_multiple): Likewise.
2788         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2789         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2790
2791 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2792
2793         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2794         AARCH64_DISPLACED_MODIFIED_INSNS.
2795         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2796         (aarch64_displaced_step_copy_insn): Likewise.
2797         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2798         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2799         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2800         ARM_DISPLACED_MODIFIED_INSNS.
2801         * arm-tdep.c (arm_gdbarch_init): Likewise.
2802         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2803         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2804         (struct arm_displaced_step_closure): Use
2805         ARM_DISPLACED_MODIFIED_INSNS.
2806
2807 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2808
2809         * features/Makefile: Remove unused xml files.
2810         * features/aarch64.xml: Remove.
2811         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2812         * features/i386/amd64-avx-avx512.xml: Remove.
2813         * features/i386/amd64-avx-linux.xml: Remove.
2814         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2815         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2816         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2817         * features/i386/amd64-avx-mpx.xml: Remove.
2818         * features/i386/amd64-avx.xml: Remove.
2819         * features/i386/amd64-linux.xml: Remove.
2820         * features/i386/amd64-mpx-linux.xml: Remove.
2821         * features/i386/amd64-mpx.xml: Remove.
2822         * features/i386/amd64.xml: Remove.
2823         * features/i386/i386-avx-avx512-linux.xml: Remove.
2824         * features/i386/i386-avx-avx512.xml: Remove.
2825         * features/i386/i386-avx-linux.xml: Remove.
2826         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2827         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2828         * features/i386/i386-avx-mpx-linux.xml: Remove.
2829         * features/i386/i386-avx-mpx.xml: Remove.
2830         * features/i386/i386-avx.xml: Remove.
2831         * features/i386/i386-linux.xml: Remove.
2832         * features/i386/i386-mmx-linux.xml: Remove.
2833         * features/i386/i386-mmx.xml: Remove.
2834         * features/i386/i386-mpx-linux.xml: Remove.
2835         * features/i386/i386-mpx.xml: Remove.
2836         * features/i386/i386.xml: Remove.
2837         * features/i386/x32-avx-avx512-linux.xml: Remove.
2838         * features/i386/x32-avx-linux.xml: Remove.
2839         * features/i386/x32-linux.xml: Remove.
2840
2841 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2842
2843         * regformats/aarch64.dat: Remove.
2844         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2845         * regformats/i386/amd64-avx-linux.dat: Remove.
2846         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2847         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2848         * regformats/i386/amd64-linux.dat: Remove.
2849         * regformats/i386/amd64-mpx-linux.dat: Remove.
2850         * regformats/i386/amd64.dat: Remove.
2851         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2852         * regformats/i386/i386-avx-linux.dat: Remove.
2853         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2854         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2855         * regformats/i386/i386-linux.dat: Remove.
2856         * regformats/i386/i386-mmx-linux.dat: Remove.
2857         * regformats/i386/i386-mpx-linux.dat: Remove.
2858         * regformats/i386/i386.dat: Remove.
2859         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2860         * regformats/i386/x32-avx-linux.dat: Remove.
2861         * regformats/i386/x32-linux.dat: Remove.
2862
2863 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2864
2865         * aarch64-tdep.c: Remove xml self tests.
2866         * amd64-linux-tdep.c: Likewise.
2867         * amd64-tdep.c: Likewise.
2868         * i386-linux-tdep.c: Likewise.
2869         * i386-tdep.c: Likewise.
2870
2871 2019-07-03  Pedro Alves  <palves@redhat.com>
2872
2873         PR cli/24732
2874         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2875         (pipe_cmd_option_defs): New.
2876         (make_pipe_cmd_options_def_group): New.
2877         (pipe_command): Use gdb::option::process_options.
2878         (pipe_command_completer): New function.
2879         (_initialize_cli_cmds): Install completer for "pipe" command.
2880
2881 2019-07-03  Pedro Alves  <palves@redhat.com>
2882
2883         * cli/cli-option.c (union option_value) <string>: New field.
2884         (struct option_def_and_value): Add ctor, move ctor, dtor and
2885         use DISABLE_COPY_AND_ASSIGN.
2886         (option_def_and_value::clear_value): New.
2887         (parse_option, save_option_value_in_ctx, get_val_type_str)
2888         (add_setshow_cmds_for_options): Handle var_string.
2889         * cli-option.h (union option_def::var_address) <string>: New
2890         field.
2891         (struct string_option_def): New.
2892         * maint-test-options.c (struct test_options_opts): Add default
2893         ctor and use DISABLE_COPY_AND_ASSIGN.
2894         <string_opt>: New field.
2895         (test_options_opts::~test_options_opts): New.
2896         (test_options_opts::dump): Also dump "-string".
2897         (test_options_option_defs): Install "string.
2898
2899 2019-07-03  Pedro Alves  <palves@redhat.com>
2900
2901         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2902         option_value with a null enumeration.
2903         (complete_options): Save the option values in the context.
2904         (save_option_value_in_ctx): New, factored out from ...
2905         (process_options): ... here.
2906         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2907         of the function.
2908         * maint-test-options.c (test_options_opts::dump): New, factored
2909         out from ...
2910         (maintenance_test_options_command_mode): ... here.
2911         (maintenance_test_options_command_completion_result): Delete.
2912         (maintenance_test_options_command_completion_text): Update
2913         comment.
2914         (maintenance_show_test_options_completion_result): Change
2915         prototype.  Just print
2916         maintenance_test_options_command_completion_text.
2917         (save_completion_result): New.
2918         (maintenance_test_options_completer_mode): Pass options context to
2919         complete_options, and then save a dump.
2920         (_initialize_maint_test_options): Use add_cmd to install "maint
2921         show test-options-completion-result".
2922
2923 2019-07-03  Pedro Alves  <palves@redhat.com>
2924
2925         * NEWS (New commands): Mention "with" and "maint with".
2926         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2927         (with_command, with_command_completer): New.
2928         (pipe_command): Adjust to new repeat_previous
2929         interface.
2930         (_initialize_cli_cmds): Install the "with" command and its "w"
2931         alias.
2932         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2933         declarations.
2934         * cli/cli-setshow.c (parse_cli_var_uinteger)
2935         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2936         argument strings for all var_types.
2937         (get_setshow_command_value_string): New, factored out from ...
2938         (do_show_command): ... this.
2939         * cli/cli-setshow.h: Include <string>.
2940         (get_setshow_command_value_string): Declare.
2941         * command.h (repeat_previous): Now returns const char *.  Adjust
2942         comment.
2943         * maint.c: Include "cli/cli-cmds.h".
2944         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2945         (_initialize_maint_cmds): Register the "maintenance with" command.
2946         * top.c (repeat_previous): Move bits from pipe_command here:
2947         Return the saved command line, if any; error out if there's no
2948         command to relaunch.
2949
2950 2019-07-03  Pedro Alves  <palves@redhat.com>
2951
2952         * NEWS (New commands): Mention "maint set/show test-settings"
2953         instead of "maint test-settings".
2954         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2955         (maintenance_test_settings_set_list): Rename to ...
2956         (maintenance_set_test_settings_list): ... this.
2957         (maintenance_test_settings_show_list): Rename to  ...
2958         (maintenance_show_test_settings_list): ... this.
2959         (maintenance_test_settings_cmd): Delete.
2960         (maintenance_test_settings_set_cmd): ...
2961         (maintenance_set_test_settings_cmd): ... this.
2962         (maintenance_test_settings_show_cmd): ...
2963         (maintenance_show_test_settings_cmd): ... this.
2964         (maintenance_test_settings_show_value_cmd):
2965         (maintenance_show_test_settings_value_cmd): ... this.
2966         (_initialize_maint_test_settings): No longer install the "maint
2967         test-settings" prefix command.  Rename "maint test-settings set"
2968         to "maint set test-settings", and "maint test-settings show" to
2969         "maint show test-settings".  Adjust all subcommands.
2970
2971 2019-07-03  Pedro Alves  <palves@redhat.com>
2972
2973         * maint-test-settings.c: Fix file's intro comment.  Replace all
2974         references to "test-options" with references to "test-settings",
2975         in comments.
2976
2977 2019-07-03  Pedro Alves  <palves@redhat.com>
2978
2979         * maint-test-settings.c (maintenance_test_settings_xxx)
2980         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2981         New.
2982         (maintenance_test_settings_enums): Use them.
2983         (maintenance_test_settings_enum): Default to
2984         maintenance_test_settings_xxx.
2985         (_initialize_maint_test_settings): Initialize
2986         MAINTENANCE_TEST_SETTINGS_FILENAME.
2987
2988 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2989
2990         * breakpoint.h (remove_breakpoints_inf): Change return type to
2991         void, move function documentation here.
2992         * breakpoint.c (remove_breakpoints_inf): Change return type to
2993         void, move function documentation to header.
2994
2995 2019-07-02  Pedro Alves  <palves@redhat.com>
2996
2997         * NEWS (Completion improvements): Mention "info threads".
2998         * thread.c (struct info_threads_opts, info_threads_option_defs)
2999         (make_info_threads_options_def_group): New.
3000         (info_threads_command): Use gdb::option::process_options.
3001         (info_threads_command_completer): New.
3002         (_initialize_thread): Use gdb::option::build_help to build the
3003         help text for "info threads".
3004
3005 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3006
3007         * defs.h (generic_load): Move from here...
3008         * symfile.h (generic_load): ... to here.  Rename name parameter
3009         to args.
3010         * symfile.c (generic_load): Add comment.
3011
3012 2019-07-01  Tom Tromey  <tromey@adacore.com>
3013
3014         * dwarf2read.c
3015         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3016         declaration of without_params.  Fix formatting.
3017
3018 2019-07-01  Tom Tromey  <tromey@adacore.com>
3019
3020         * ada-exp.y (find_primitive_type): Update.
3021         * ada-lang.h (ada_lookup_symbol): Update.
3022         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3023         parameter.
3024         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3025
3026 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3027
3028         PR breakpoints/24541
3029         * gdbarch.c: Regenerate.
3030         * gdbarch.h: Regenerate.
3031         * gdbarch.sh: Add 'stap_adjust_register'.
3032         * i386-tdep.c: Include '<unordered_set>'.
3033         (i386_stap_adjust_register): New function.
3034         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3035         * stap-probe.c (stap_parse_register_operand): Call
3036         'gdbarch_stap_adjust_register'.
3037
3038 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3039
3040         PR python/24742
3041         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3042         * python/python.c (do_start_initialization): Use 'xmalloc'
3043         instead of 'PyMem_Malloc'.
3044
3045 2019-06-28  Tom Tromey  <tromey@adacore.com>
3046
3047         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3048         for Ada.
3049
3050 2019-06-27  Tom Tromey  <tromey@adacore.com>
3051
3052         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3053         objfile_key.
3054         (arm_find_mapping_symbol, arm_record_special_symbol)
3055         (_initialize_arm_tdep): Update.
3056         (arm_objfile_data_free): Remove.
3057
3058 2019-06-27  Tom Tromey  <tromey@adacore.com>
3059
3060         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3061         to cp_print_static_field.
3062
3063 2019-06-26  Tom Tromey  <tromey@adacore.com>
3064
3065         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3066         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3067         declare.
3068
3069 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3070
3071         * features/aarch64-core.c (create_feature_aarch64_core):
3072         Regenerate.
3073         * features/aarch64-core.xml: Add cpsr flags.
3074
3075 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3076
3077         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3078         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3079
3080 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3081
3082         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3083         field.
3084         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3085         use.
3086         (arm_record_special_symbol): Don't insert new symbol in sorted
3087         position, push it at the end.
3088
3089 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3090
3091         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3092         (arm_mapping_symbol_s): Remove.
3093         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3094         (arm_mapping_symbol_vec): New typedef.
3095         (struct arm_per_objfile): Add constructor.
3096         <section_maps>: Change type to
3097         std::unique_ptr<arm_mapping_symbol_vec[]>.
3098         (arm_compare_mapping_symbols): Remove.
3099         (arm_find_mapping_symbol): Adjust to section_maps type change.
3100         (arm_objfile_data_free): Call delete on arm_per_objfile.
3101         (arm_record_special_symbol): Adjust to section_maps type change.
3102         Allocate arm_per_objfile with new.
3103
3104 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3105
3106         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3107         with the command prefix.
3108
3109 2019-06-25  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3112         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3113
3114 2019-06-25  Tom Tromey  <tom@tromey.com>
3115
3116         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3117         type.
3118         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3119         protected.
3120
3121 2019-06-25  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-winsource.c
3124         (tui_source_window_base::set_is_exec_point_at): Add check against
3125         LOA_ADDRESS.
3126
3127 2019-06-25  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-source.c (tui_set_source_content): Don't check before
3130         xfree.
3131         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3132
3133 2019-06-25  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-winsource.h (tui_update_source_window_as_is)
3136         (tui_alloc_source_buffer, tui_line_is_displayed)
3137         (tui_addr_is_displayed): Change type of win_info.
3138         * tui/tui-winsource.c (tui_update_source_window_as_is)
3139         (tui_clear_source_content, tui_show_source_line)
3140         (tui_show_source_content, tui_source_window_base::refill)
3141         (tui_source_window_base::set_is_exec_point_at)
3142         (tui_source_window_base::set_is_exec_point_at)
3143         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3144         (tui_alloc_source_buffer, tui_line_is_displayed)
3145         (tui_addr_is_displayed): Change type of win_info.  Update.
3146         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3147         (tui_source_window_base::do_make_visible_with_new_height):
3148         Update.
3149         * tui/tui-source.c (tui_set_source_content)
3150         (tui_set_source_content_nil)
3151         (tui_source_window::do_scroll_vertical): Update.
3152         * tui/tui-layout.c (show_layout): Update.
3153         * tui/tui-disasm.c (tui_set_disassem_content)
3154         (tui_disasm_window::do_scroll_vertical): Update.
3155         * tui/tui-data.h (tui_win_content): Remove.
3156         (struct tui_gen_win_info) <content, content_size>: Remove.
3157         (struct tui_source_element): Add initializers and destructor.
3158         (union tui_which_element, struct tui_win_element): Remove.
3159         (struct tui_source_window_base) <content>: New field.
3160         (struct tui_data_window): Remove destructor.
3161         (tui_alloc_content, tui_free_win_content)
3162         (tui_free_all_source_wins_content): Don't declare.
3163         * tui/tui-data.c (tui_initialize_static_data): Update.
3164         (init_content_element, tui_alloc_content): Remove.
3165         (~tui_gen_win_info): Update.
3166         (~tui_data_window, tui_free_all_source_wins_content)
3167         (tui_free_win_content, free_content, free_content_elements):
3168         Remove.
3169
3170 2019-06-25  Tom Tromey  <tom@tromey.com>
3171
3172         * tui/tui-winsource.h (tui_clear_source_content)
3173         (tui_erase_source_content, tui_show_source_content): Change type
3174         of win_info.
3175         * tui/tui-winsource.c (tui_clear_source_content)
3176         (tui_erase_source_content, tui_show_source_content): Change type
3177         of win_info.
3178         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3179         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3180         win_info.
3181         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3182         win_info.
3183         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3184
3185 2019-06-25  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-winsource.c (tui_clear_source_content)
3188         (tui_source_window_base::set_is_exec_point_at): Update.
3189         * tui/tui-source.c (tui_set_source_content_nil): Update.
3190         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3191         a bool.
3192         * tui/tui-data.c (init_content_element): Update.
3193
3194 2019-06-25  Tom Tromey  <tom@tromey.com>
3195
3196         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3197         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3198         * tui/tui-layout.c (init_and_make_win): Update.
3199         * tui/tui.h (enum tui_win_type): Update.
3200         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3201         tui_win_is_auxillary.
3202         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3203         tui_win_is_auxillary.
3204
3205 2019-06-25  Tom Tromey  <tom@tromey.com>
3206
3207         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3208         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3209         (tui_delete_data_content_windows, tui_display_all_data)
3210         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3211         Update.
3212         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3213         * tui/tui-regs.c (tui_last_regs_line_no)
3214         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3215         (tui_show_registers): Update.
3216         (tui_show_register_group): Return void.  Update.
3217         (tui_display_registers_from, tui_display_reg_element_at_line)
3218         (tui_display_registers_from_line, tui_check_register_values):
3219         Update.
3220         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3221         member.
3222         (struct tui_data_window) <regs_content>: Now a std::vector.
3223         <regs_content_count>: Remove.
3224         (tui_add_content_elements, tui_free_data_content): Don't declare.
3225         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3226         (init_content_element): Remove DATA_WIN case.  Add assert.
3227         (tui_add_content_elements): Remove.
3228         (tui_data_window): Update.
3229         (tui_free_data_content): Remove.
3230         (free_content_elements): Remove DATA_WIN case.
3231
3232 2019-06-25  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-data.c (tui_data_item_window): Update.
3235         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3236         * tui/tui-windata.c (tui_display_all_data)
3237         (tui_display_data_from_line): Update.
3238         (tui_check_data_values): Remove.
3239         * tui/tui-regs.c (tui_show_register_group)
3240         (tui_display_reg_element_at_line): Update.
3241         * tui/tui-hooks.c (tui_register_changed)
3242         (tui_refresh_frame_and_register_information): Call
3243         tui_check_register_values.
3244         * tui/tui-data.h (struct tui_data_window) <data_content,
3245         data_content_count, data_type>: Remove.
3246         (enum tui_data_type): Remove.
3247
3248         * tui/tui-data.c (tui_data_window::clear_detail)
3249         (~tui_data_window): Update.
3250
3251 2019-06-25  Tom Tromey  <tom@tromey.com>
3252
3253         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3254         declare.
3255         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3256         Rename from tui_first_data_item_displayed.  Update.
3257         (tui_data_window::refresh_all)
3258         (tui_data_window::do_scroll_vertical): Update.
3259         * tui/tui-data.h (struct tui_data_window)
3260         <first_data_item_displayed>: Declare new method.
3261
3262 2019-06-25  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3265         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3266         contents...
3267         (tui_initialize_static_data): ...here.
3268
3269 2019-06-25  Tom Tromey  <tom@tromey.com>
3270
3271         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3272         (tui_display_registers_from, tui_check_register_values): Update.
3273         (tui_display_register): Remove win_info parameter; update.
3274         (tui_get_register): Change type of parameters.
3275         * tui/tui-data.h (struct tui_data_element): Remove.
3276         (union tui_which_element) <data>: Remove.
3277         <data_window>: Change type.
3278         (struct tui_data_item_window): New.
3279         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3280         case.  Add assert.
3281         (~tui_data_item_window): New destructor.
3282         (free_content_elements): Remove DATA_ITEM_WIN case.
3283
3284 2019-06-25  Tom Tromey  <tom@tromey.com>
3285
3286         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3287         Remove.
3288
3289 2019-06-25  Tom Tromey  <tom@tromey.com>
3290
3291         * tui/tui-data.h (struct tui_command_element): Remove.
3292         (union tui_which_element) <command>: Remove.
3293         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3294         assert.
3295         (free_content_elements): Remove CMD_WIN case.
3296
3297 2019-06-25  Tom Tromey  <tom@tromey.com>
3298
3299         * tui/tui-layout.c (tui_set_layout): Update.
3300         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3301         * tui/tui-data.c (layout_def): Update.
3302
3303 2019-06-25  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3306         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3307         (tui_source_window_base::set_new_height): Update.
3308         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3309         Update.
3310         (tui_set_locator_fullname, tui_set_locator_info)
3311         (tui_show_frame_info): Update.
3312         * tui/tui-source.c (tui_set_source_content)
3313         (tui_source_is_displayed): Update.
3314         * tui/tui-layout.c (show_source_disasm_command, show_data)
3315         (show_source_or_disasm_and_command): Update.
3316         * tui/tui-disasm.c (tui_set_disassem_content)
3317         (tui_get_begin_asm_address): Update.
3318         * tui/tui-data.h (struct tui_locator_element): Remove.
3319         (union tui_which_element) <locator>: Remove.
3320         (struct tui_locator_window): New.
3321         (tui_locator_win_info_ptr): Change return type.
3322         * tui/tui-data.c (_locator): Change type.
3323         (tui_locator_win_info_ptr): Change return type.
3324         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3325         (tui_alloc_content): Add assert.
3326
3327 2019-06-25  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-winsource.c
3330         (tui_exec_info_window::maybe_allocate_content): New method.
3331         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3332         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3333         (make_source_or_disasm_window): Add cast.
3334         * tui/tui-data.h (union tui_which_element) <simple_string>:
3335         Remove.
3336         (struct tui_source_info): New.
3337         (struct tui_source_window_base) <execution_info>: Change type.
3338         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3339         case, and add assert.
3340         (tui_alloc_content): Add assert.
3341
3342 2019-06-25  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3345         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3346         * tui/tui-data.c (tui_alloc_win_info): Remove.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3351         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3352         can_highlight.
3353
3354 2019-06-25  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3357         make_visible_with_new_height method.
3358         (tui_win_info::make_visible_with_new_height): New method.
3359         (tui_source_window_base::do_make_visible_with_new_height)
3360         (tui_data_window::do_make_visible_with_new_height)
3361         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3362         (make_visible_with_new_height): Remove.
3363         (tui_resize_all, tui_adjust_win_heights): Use
3364         make_visible_with_new_height method.
3365         * tui/tui-data.h (struct tui_win_info)
3366         <do_make_visible_with_new_height, make_visible_with_new_height>:
3367         New methods.
3368         (struct tui_source_window_base, struct tui_data_window)
3369         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3370         methods.
3371
3372 2019-06-25  Tom Tromey  <tom@tromey.com>
3373
3374         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3375         method.
3376         (update_tab_width): Call update_tab_width method.
3377         * tui/tui-data.h (struct tui_win_info)
3378         (struct tui_source_window_base) <update_tab_width>: New methods.
3379
3380 2019-06-25  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3383         parameter.
3384         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3385         parameter.
3386         (tui_gen_win_info::make_visible): Update.
3387         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3388         parameter.
3389         * tui/tui-data.h (enum tui_box): New enum.
3390         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3391
3392 2019-06-25  Tom Tromey  <tom@tromey.com>
3393
3394         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3395         init_and_make_win for EXEC_INFO_WIN.
3396         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3397         longer inline.
3398         (struct tui_win_info) <~tui_win_info>: Inline.
3399         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3400         Don't declare.
3401         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3402         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3403         Remove.
3404         (tui_initialize_static_data): Update.
3405         (~tui_gen_win_info): Handle more cleanup here.
3406         (~tui_source_window_base): Delete "execution_info".
3407         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3408
3409 2019-06-25  Tom Tromey  <tom@tromey.com>
3410
3411         * tui/tui-layout.c (make_command_window): Don't set
3412         can_highlight.
3413         (show_source_disasm_command): Call the reset method.
3414         (show_data): Don't set can_highlight.  Call the reset method.
3415         (tui_gen_win_info::reset): Rename from init_gen_win_info
3416         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3417         (show_source_or_disasm_and_command): Call the reset method.
3418         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3419         (struct tui_cmd_window): Set can_highlight.
3420
3421 2019-06-25  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3424         from make_visible.
3425         (tui_make_visible, tui_make_invisible): Rewrite.
3426         (tui_win_info::make_visible): Remove.
3427         (tui_source_window_base::make_visible): Update.
3428         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3429         method.  Moved from...
3430         (struct tui_win_info) <make_visible>: ...here.
3431
3432 2019-06-25  Tom Tromey  <tom@tromey.com>
3433
3434         * tui/tui-winsource.c
3435         (tui_source_window_base::do_scroll_horizontal): Remove direction
3436         parameter.
3437         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3438         direction parameter.
3439         * tui/tui-win.c (tui_win_info::forward_scroll)
3440         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3441         (tui_win_info::right_scroll): Update.
3442         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3443         direction parameter.
3444         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3445         direction parameter.
3446         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3447         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3448         Remove direction parameter.
3449         (struct tui_source_window_base, struct tui_source_window)
3450         (struct tui_disasm_window, struct tui_data_window)
3451         (struct tui_cmd_window): Update.
3452
3453 2019-06-25  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-winsource.h (tui_set_exec_info_content)
3456         (tui_show_exec_info_content, tui_erase_exec_info_content)
3457         (tui_clear_exec_info_content, tui_update_exec_info): Change
3458         argument to tui_source_window_base.
3459         * tui/tui-winsource.c (tui_set_exec_info_content)
3460         (tui_show_exec_info_content, tui_erase_exec_info_content)
3461         (tui_clear_exec_info_content, tui_update_exec_info): Change
3462         argument to tui_source_window_base.
3463
3464 2019-06-25  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3467         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3468
3469 2019-06-25  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3472         check.
3473
3474 2019-06-25  Tom Tromey  <tom@tromey.com>
3475
3476         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3477         type to void.
3478         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3479         type to void.
3480         * tui/tui-source.c (tui_set_source_content): Update.
3481         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3482
3483 2019-06-25  Tom Tromey  <tom@tromey.com>
3484
3485         * tui/tui-win.c (window_name_completer, tui_set_focus)
3486         (tui_all_windows_info): Use name method.
3487         * tui/tui-data.h (struct tui_gen_win_info)
3488         (struct tui_source_window, struct tui_disasm_window)
3489         (struct tui_data_window, struct tui_cmd_window) <name>: New
3490         method.
3491         (tui_win_name): Don't declare.
3492         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3493         (tui_win_name): Remove.
3494
3495 2019-06-25  Tom Tromey  <tom@tromey.com>
3496
3497         * tui/tui-winsource.h (tui_update_source_window)
3498         (tui_update_source_window_as_is): Change parameter type.
3499         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3500         to be a tui_source_window_base.
3501         (tui_update_source_window_as_is): Likewise.
3502         * tui/tui-win.c (make_visible_with_new_height): Update.
3503
3504 2019-06-25  Tom Tromey  <tom@tromey.com>
3505
3506         * tui/tui-winsource.c (tui_erase_source_content)
3507         (tui_show_source_content, tui_show_exec_info_content)
3508         (tui_erase_exec_info_content): Use refresh_window method.
3509         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3510         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3511         from tui_refresh_win.
3512         (tui_data_window::refresh_window): New method.
3513         (tui_win_info::refresh, tui_source_window_base::refresh)
3514         (tui_refresh_all): Use refresh_window method.
3515         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3516         method.
3517         * tui/tui-regs.c (tui_display_register): Call refresh_window
3518         method.
3519         * tui/tui-layout.c (show_source_disasm_command)
3520         (show_source_or_disasm_and_command): Call refresh_window method.
3521         * tui/tui-data.h (struct tui_gen_win_info)
3522         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3523         New method.
3524
3525 2019-06-25  Tom Tromey  <tom@tromey.com>
3526
3527         * tui/tui.c (tui_rl_other_window, tui_enable)
3528         (tui_is_window_visible, tui_get_command_dimension): Update.
3529         * tui/tui-winsource.c (tui_update_source_window_as_is)
3530         (tui_clear_source_content, tui_erase_source_content)
3531         (tui_show_source_line, tui_source_window_base::refill)
3532         (tui_source_window_base::do_scroll_horizontal)
3533         (tui_source_window_base::set_is_exec_point_at)
3534         (tui_update_breakpoint_info, tui_set_exec_info_content)
3535         (tui_alloc_source_buffer, tui_line_is_displayed)
3536         (tui_addr_is_displayed): Update.
3537         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3538         (tui_check_and_display_highlight_if_needed)
3539         (tui_win_info::make_visible, tui_win_info::refresh)
3540         (tui_refresh_all): Update.
3541         * tui/tui-windata.c (tui_first_data_item_displayed)
3542         (tui_delete_data_content_windows, tui_erase_data_content)
3543         (tui_display_all_data, tui_data_window::refresh_all)
3544         (tui_check_data_values): Update.
3545         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3546         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3547         (tui_win_info::backward_scroll, tui_refresh_all_win)
3548         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3549         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3550         (tui_source_window_base::set_new_height)
3551         (tui_data_window::set_new_height)
3552         (make_invisible_and_set_new_height)
3553         (make_visible_with_new_height, new_height_ok)
3554         (parse_scrolling_args): Update.
3555         * tui/tui-stack.c (tui_show_frame_info): Update.
3556         * tui/tui-source.c (tui_set_source_content)
3557         (tui_set_source_content_nil, tui_source_is_displayed)
3558         (tui_source_window::do_scroll_vertical): Update.
3559         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3560         (tui_display_registers_from, tui_display_reg_element_at_line)
3561         (tui_check_register_values, tui_reg_command): Update.
3562         * tui/tui-layout.c (tui_default_win_height)
3563         (show_source_disasm_command, show_data, init_and_make_win)
3564         (show_source_or_disasm_and_command): Update.
3565         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3566         (tui_redisplay_readline, tui_mld_flush)
3567         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3568         (tui_getc): Update.
3569         * tui/tui-disasm.c (tui_set_disassem_content)
3570         (tui_disasm_window::do_scroll_vertical): Update.
3571         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3572         Now virtual.
3573         (struct tui_win_info): Derive from tui_gen_win_info.
3574         <~tui_win_info>: Mark as override.
3575         <generic>: Remove member.
3576         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3577         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3578         (~tui_data_window, ~tui_win_info)
3579         (tui_free_all_source_wins_content): Update.
3580         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3581
3582 2019-06-25  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-layout.c (init_and_make_win): Use new.
3585         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3586         destructor, initializers.
3587         (tui_alloc_generic_win_info): Don't declare.
3588         * tui/tui-data.c (_locator): Add argument to constructor.
3589         (source_win, disasm_win): New globals.
3590         (exec_info): Remove.
3591         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3592         Update.
3593         (tui_alloc_generic_win_info): Remove.
3594         (init_content_element): Use new.
3595         (tui_win_info::tui_win_info): Update.
3596         (free_content_elements) <case DATA_WIN>: Use delete.
3597
3598 2019-06-25  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3601         * tui/tui-windata.c (tui_first_data_item_displayed)
3602         (tui_delete_data_content_windows): Update.
3603         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3604         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3605         (tui_display_registers_from, tui_check_register_values): Update.
3606         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3607         pointer.
3608         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3609         window.
3610         (tui_free_data_content): Update.
3611         (free_content_elements) <case DATA_WIN>: Free the window.
3612
3613 2019-06-25  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3616         Update.
3617         * tui/tui-layout.c (make_command_window)
3618         (show_source_disasm_command, show_data, init_and_make_win)
3619         (show_source_or_disasm_and_command): Update.
3620         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3621         method.
3622         <can_highight, is_highlighted>: Now bool.
3623         (tui_set_win_highlight): Don't declare.
3624         * tui/tui-data.c (tui_set_win_highlight): Remove.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-wingeneral.c (make_visible): Remove check of window
3629         type.
3630
3631 2019-06-25  Tom Tromey  <tom@tromey.com>
3632
3633         * tui/tui-win.c (tui_win_info::max_height)
3634         (tui_cmd_window::max_height): New methods.
3635         (new_height_ok): Call max_height.
3636         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3637         <max_height>: New method.
3638
3639 2019-06-25  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-win.c (tui_source_window_base::set_new_height)
3642         (tui_data_window::set_new_height): New methods.
3643         (make_invisible_and_set_new_height): Call set_new_height method.
3644         * tui/tui-data.h (struct tui_win_info)
3645         (struct tui_source_window_base, struct tui_data_window)
3646         <set_new_height>: New method.
3647
3648 2019-06-25  Tom Tromey  <tom@tromey.com>
3649
3650         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3651         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3652         tui_refresh_data_win.
3653         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3654         method.
3655         (tui_refresh_all_win): Call the refresh_all method.
3656         (tui_set_focus): Likewise.
3657         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3658         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3659         Likewise.
3660
3661 2019-06-25  Tom Tromey  <tom@tromey.com>
3662
3663         * tui/tui-winsource.h (tui_refill_source_window)
3664         (tui_set_is_exec_point_at): Don't declare.
3665         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3666         (tui_source_window_base::refill): Rename from
3667         tui_refill_source_window.
3668         (tui_source_window_base::do_scroll_horizontal): Update.
3669         (tui_source_window_base::set_is_exec_point_at): Rename from
3670         tui_set_is_exec_point_at.
3671         (tui_update_all_breakpoint_info): Update.
3672         * tui/tui-stack.c (tui_show_frame_info): Update.
3673         * tui/tui-layout.c (show_data): Add cast.
3674         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3675         * tui/tui-data.h (struct tui_source_window_base) <refill,
3676         set_is_exec_point_at>: New methods.
3677         (tui_source_windows, tui_add_to_source_windows): Update types.
3678         (tui_add_to_source_windows): Remove redundant declaration.
3679         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3680         (tui_source_windows): Change return type.
3681         (tui_clear_source_windows_detail): Update.
3682         (tui_add_to_source_windows): Change type of parameter.
3683         (tui_free_all_source_wins_content): Update.
3684
3685 2019-06-25  Tom Tromey  <tom@tromey.com>
3686
3687         * tui/tui-wingeneral.c (tui_win_info::refresh)
3688         (tui_source_window_base::refresh): New methods.
3689         (tui_refresh_all): Call the refresh method.
3690         * tui/tui-data.h (struct tui_win_info)
3691         (struct tui_source_window_base) <refresh>: New method.
3692
3693 2019-06-25  Tom Tromey  <tom@tromey.com>
3694
3695         * tui/tui.h (tui_is_window_visible): Return bool.
3696         * tui/tui.c (tui_is_window_visible): Return bool.
3697         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3698         (tui_make_visible, tui_make_invisible)
3699         (tui_win_info::make_visible)
3700         (tui_source_window_base::make_visible, make_all_visible)
3701         (tui_make_all_visible, tui_make_all_invisible): Update.
3702         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3703         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3704         bool.
3705         (struct tui_win_info, struct tui_source_window_base)
3706         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3707         * tui/tui-data.c (tui_init_generic_part): Update.
3708
3709 2019-06-25  Tom Tromey  <tom@tromey.com>
3710
3711         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3712         (tui_source_window_base::make_visible): New methods.
3713         (make_all_visible): Make method call.
3714         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3715         (struct tui_source_window_base, struct tui_cmd_window): Override
3716         make_visible.
3717         (tui_win_is_source_type): Don't declare.
3718         * tui/tui-data.c (tui_win_is_source_type): Remove.
3719
3720 2019-06-25  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3723         NULL check.
3724
3725 2019-06-25  Tom Tromey  <tom@tromey.com>
3726
3727         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3728         Inline constructor.  Add initializers for members.
3729         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3730         constructors; now inline in class.
3731
3732 2019-06-25  Tom Tromey  <tom@tromey.com>
3733
3734         * tui/tui-regs.c (tui_show_registers): Update.
3735         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3736         bool.
3737         * tui/tui-data.c (tui_data_window::clear_detail)
3738         (tui_data_window): Update.
3739
3740 2019-06-25  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-windata.c (tui_display_all_data)
3743         (tui_display_data_from_line, tui_display_data_from)
3744         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3745         Update.
3746         * tui/tui-regs.c (tui_last_regs_line_no)
3747         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3748         (tui_show_registers, tui_show_register_group)
3749         (tui_display_registers_from, tui_display_reg_element_at_line)
3750         (tui_display_registers_from_line, tui_check_register_values)
3751         (tui_reg_next, tui_reg_prev): Update.
3752         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3753         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3754         tui_data_window.
3755         (struct tui_win_info) <detail>: Remove.  Add new fields from
3756         tui_data_info.
3757         (TUI_DATA_WIN): Add cast.
3758         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3759         (~tui_data_window): Simplify.
3760
3761 2019-06-25  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui-layout.c (show_source_disasm_command)
3764         (show_source_or_disasm_and_command): Update.
3765         * tui/tui-io.c (update_cmdwin_start_line)
3766         (tui_redisplay_readline): Update.
3767         * tui/tui-data.h (struct tui_command_info): Remove.
3768         (struct tui_win_info) <detail>: Remove command_info member.
3769         (struct tui_data_window) <start_line>: New member, from
3770         tui_command_info.
3771         (TUI_CMD_WIN): Add casts.
3772
3773 2019-06-25  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui-winsource.c (tui_update_source_window)
3776         (tui_refill_source_window)
3777         (tui_source_window_base::do_scroll_horizontal)
3778         (tui_update_breakpoint_info, tui_set_exec_info_content)
3779         (tui_show_exec_info_content, tui_erase_exec_info_content)
3780         (tui_clear_exec_info_content): Update.
3781         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3782         Update.
3783         * tui/tui-win.c (make_invisible_and_set_new_height)
3784         (make_visible_with_new_height): Update.
3785         * tui/tui-source.c (tui_set_source_content)
3786         (tui_show_symtab_source): Update.
3787         * tui/tui-layout.c (extract_display_start_addr)
3788         (show_source_disasm_command, show_data)
3789         (make_source_or_disasm_window)
3790         (show_source_or_disasm_and_command): Update.
3791         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3792         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3793         "gdbarch".
3794         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3795         to tui_source_window_base.
3796         (struct tui_win_info) <detail>: Remove source_info member.
3797         (struct tui_source_window_base) <has_locator>: Inline.
3798         Move contents from tui_source_info; rename has_locator member to
3799         m_has_locator.
3800         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3801         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3802         header file.
3803         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3804         Simplify.
3805         (tui_free_all_source_wins_content): Cast to
3806         tui_source_window_base.
3807
3808 2019-06-25  Tom Tromey  <tom@tromey.com>
3809
3810         * tui/tui-win.c (make_invisible_and_set_new_height)
3811         (make_visible_with_new_height): Call has_locator method.
3812         * tui/tui-layout.c (show_source_disasm_command, show_data)
3813         (show_source_or_disasm_and_command): Update for bool change.
3814         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3815         (tui_win_info) <has_locator>: New method.
3816         (struct tui_source_window_base) <has_locator>: New method.
3817         (tui_win_has_locator): Don't declare.
3818         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3819         from tui_win_has_locator.
3820         (tui_source_window_base): Use false, not FALSE.
3821
3822 2019-06-25  Tom Tromey  <tom@tromey.com>
3823
3824         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3825         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3826         clear_detail method directly.
3827         (tui_clear_win_detail): Remove.
3828
3829 2019-06-25  Tom Tromey  <tom@tromey.com>
3830
3831         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3832         "this", not TUI_DISASM_WIN.
3833
3834 2019-06-25  Tom Tromey  <tom@tromey.com>
3835
3836         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3837         declare.
3838         * tui/tui-winsource.c
3839         (tui_source_window_base::do_scroll_horizontal): Rename from
3840         tui_horizontal_source_scroll.
3841         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3842         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3843         from tui_vertical_data_scroll.
3844         * tui/tui-win.h (tui_scroll): Don't declare.
3845         * tui/tui-win.c (tui_win_info::forward_scroll)
3846         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3847         (tui_win_info::right_scroll): Rename and update.
3848         (tui_scroll_forward_command, tui_scroll_backward_command)
3849         (tui_scroll_left_command, tui_scroll_right_command): Update.
3850         (tui_scroll): Remove.
3851         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3852         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3853         from tui_vertical_source_scroll.
3854         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3855         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3856         from tui_vertical_disassem_scroll.
3857         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3858         do_scroll_horizontal>: New methods.
3859         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3860         Likewise.
3861         (struct tui_source_window_base): Add do_scroll_horizontal.
3862         (struct tui_source_window, struct tui_disasm_window): Add
3863         do_scroll_vertical.
3864         (struct tui_data_window, struct tui_cmd_window): Add
3865         do_scroll_horizontal and do_scroll_vertical.
3866         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3867
3868 2019-06-25  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-data.h (struct tui_source_window_base): New struct.
3871         (struct tui_source_window): Derive from tui_source_window_base.
3872         (struct tui_disasm_window): New struct.
3873         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3874         from tui_source_window::clear_detail.
3875         (tui_source_window_base): Rename from tui_source_window.
3876         (~tui_source_window_base): Rename from ~tui_source_window.
3877         (tui_alloc_win_info): Create a tui_disasm_window.
3878
3879 2019-06-25  Tom Tromey  <tom@tromey.com>
3880
3881         * tui/tui-data.h (struct tui_source_window)
3882         (struct tui_data_window): Declare destructors.
3883         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3884         destructors.
3885         (tui_win_info): Simplify.
3886
3887 2019-06-25  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-winsource.c (tui_display_main)
3890         (tui_update_source_windows_with_addr)
3891         (tui_update_all_breakpoint_info): Update.
3892         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3893         (new_height_ok, parse_scrolling_args): Update.
3894         * tui/tui-stack.c (tui_show_frame_info): Update.
3895         * tui/tui-data.h (struct tui_list): Remove.
3896         (tui_source_windows): Return a reference to a std::vector.
3897         * tui/tui-data.c (source_windows): Now a std::vector.
3898         (tui_source_windows): Change return type.
3899         (tui_clear_source_windows): Rewrite.
3900         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3901         (tui_free_all_source_wins_content): Rewrite.
3902
3903 2019-06-25  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3906         (struct tui_data_window, struct tui_cmd_window): Declare
3907         clear_detail method.
3908         * tui/tui-data.c (tui_source_window::clear_detail)
3909         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3910         methods.
3911         (tui_clear_win_detail): Simplify.
3912
3913 2019-06-25  Tom Tromey  <tom@tromey.com>
3914
3915         * tui/tui-layout.c (make_source_window, make_disasm_window)
3916         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3917         Return the new window.
3918         (show_source_disasm_command, show_data)
3919         (show_source_or_disasm_and_command): Update.
3920
3921 2019-06-25  Tom Tromey  <tom@tromey.com>
3922
3923         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3924         parameter.  Return the new window.
3925         (show_source_disasm_command): Update and remove NULL check.
3926         (show_source_or_disasm_and_command): Update.
3927
3928 2019-06-25  Tom Tromey  <tom@tromey.com>
3929
3930         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3931
3932 2019-06-25  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-data.h (struct tui_win_info): Make constructor
3935         protected.  Make destructor virtual.  Add initializers.
3936         (tui_source_window, tui_data_window, tui_cmd_window): New
3937         classes.
3938         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3939         constructor.  Add "type" parameter.
3940         (tui_source_window, tui_data_window, tui_cmd_window): New
3941         constructors.
3942         (tui_alloc_win_info): Instantiate the appropriate subclass.
3943
3944 2019-06-25  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-win.c (tui_resize_all): Use delete.
3947         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3948         destructor.
3949         (tui_free_window): Don't declare.
3950         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3951         Update.
3952
3953 2019-06-25  Tom Tromey  <tom@tromey.com>
3954
3955         * tui/tui-data.h (struct tui_win_info): Add constructor.
3956         * tui/tui-data.c (tui_alloc_win_info): Use new.
3957         (tui_free_window): Use delete.
3958
3959 2019-06-22  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3962         declare.
3963         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3964
3965 2019-06-22  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3968         declare.
3969         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3970
3971 2019-06-22  Tom de Vries  <tdevries@suse.de>
3972
3973         * dwarf2read.c (create_addrmap_from_aranges)
3974         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3975         instead of '%zu'.
3976
3977 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3978
3979         * dwarf2read.h (dwarf2_section_info_def): Remove.
3980         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3981         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3982         std::vector<dwarf2_section_info>.
3983         (struct dwo_file) <~dwo_file>: Remove.
3984         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3985         types field.
3986         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3987         (dwarf2_read_debug_names): Likewise.
3988         (create_debug_types_hash_table): Change parameter type to
3989         array_view, adjust code accordingly.
3990         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3991         (partial_die_info::fixup): Likewise.
3992         (determine_prefix): Likewise.
3993         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3994
3995 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
3996
3997         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3998         gdb_bfd_ref_ptr.
3999         <~dwo_file>: Remove call to gdb_bfd_unref.
4000         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4001         gdb_bfd_ref_ptr::get.
4002
4003 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4004
4005         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4006         type to htab_up.
4007         * dwarf2read.c (struct dwo_file): Initialize fields.
4008         <~dwo_file>: New.
4009         (free_dwo_file): Remove, move content to ~dwo_file.
4010         (struct dwo_file_deleter): Remove.
4011         (dwo_file_up>: Remove custom deleter.
4012         (free_dwo_files): Remove.
4013         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4014         dwo_files.
4015         (process_skeletonless_type_units): Call unique_ptr::get.
4016         (allocate_dwo_file_hash_table): Add deleter to created hash
4017         table.  Change return type to htab_up.
4018         (lookup_dwo_file_slot): Don't memset dwo_file, call
4019         unique_ptr::get.
4020         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4021         (create_dwo_unit_in_dwp_v2): Likewise.
4022         (open_and_init_dwo_file): Likewise.
4023         (free_dwo_file_from_slot): Remove.
4024
4025 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4026
4027         * dwarf2read.h (struct dwarf2_section_info) <readin,
4028         is_virtual>: Change type to bool.
4029         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4030         true instead of 1.
4031
4032 2019-06-19  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-data.h (tui_init_content_element): Don't declare.
4035
4036 2019-06-19  Tom Tromey  <tom@tromey.com>
4037
4038         * tui/tui-data.h (tui_init_win_info): Don't declare.
4039
4040 2019-06-19  Tom de Vries  <tdevries@suse.de>
4041
4042         * dwarf2read.h (abstract_to_concrete): Change type to
4043         std::unordered_map<sect_offset, std::vector<sect_offset>,
4044         gdb::hash_enum<sect_offset>>.
4045
4046 2019-06-19  Tom Tromey  <tromey@adacore.com>
4047
4048         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4049         EVAL_AVOID_SIDE_EFFECTS specially.
4050
4051 2019-06-19  Tom Tromey  <tromey@adacore.com>
4052
4053         * source-cache.c (highlighter): New global.
4054         (source_cache::get_source_lines): Create a highlighter on demand.
4055
4056 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * defs.h (deprecated_interactive_hook): Delete declaration.
4059         * interps.c (clear_interpreter_hooks): Remove use of
4060         deprecated_interactive_hook.
4061         * top.c (deprecated_interactive_hook): Delete definition.
4062         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4063
4064 2019-06-18  Tom de Vries  <tdevries@suse.de>
4065
4066         PR gdb/24515
4067         * dwarf2read.h (abstract_to_concrete): Change type from
4068         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4069         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4070         * dwarf2read.c (read_variable): Update.
4071         (dwarf2_fetch_die_loc_sect_off): Update.
4072
4073 2019-06-17  Tom de Vries  <tdevries@suse.de>
4074
4075         PR gdb/24617
4076         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4077         accessing parent[parent_len - 1].
4078
4079 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4080
4081         PR gdb/24364
4082         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4083         call dtrace_process_dof with NULL dof.
4084
4085 2019-06-16  Tom de Vries  <tdevries@suse.de>
4086
4087         PR gdb/24445
4088         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4089
4090 2019-06-16  Tom Tromey  <tom@tromey.com>
4091
4092         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4093         (make_all_visible): Use address of member.
4094
4095 2019-06-16  Tom Tromey  <tom@tromey.com>
4096
4097         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4098         (tui_free_window, free_content, free_content_elements): Remove
4099         unnecessary cast.
4100         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4101         cast.
4102         * tui/tui-regs.c (tui_show_register_group)
4103         (tui_display_registers_from, tui_display_reg_element_at_line):
4104         Remove unnecessary cast.
4105
4106 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * linux-nat.c (normal_mask): Delete.
4109         (_initialize_linux_nat): Don't initialise normal_mask.
4110
4111 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4112
4113         PR gdb/24445
4114         * dwarf-index-write.h (write_psymtabs_to_index): Add
4115         dwz_basename parameter.
4116         * dwarf-index-write.c (write_gdbindex): Move file writing to
4117         write_gdbindex_1.  Change return type void.
4118         (assert_file_size): Move up, remove filename parameter.
4119         (write_gdbindex_1): New function.
4120         (write_debug_names): Change return type to void, call
4121         assert_file_size.
4122         (struct index_wip_file): New struct.
4123         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4124         file logic to index_wip_file.  Write index for dwz file if
4125         needed.
4126         (save_gdb_index_command): Pass basename of dwz file, if present.
4127         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4128         build-id of dwz file, if present.
4129         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4130         (dwarf2_get_dwz_file): Likewise.
4131         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4132         (dwarf2_get_dwz_file): Likewise.
4133
4134 2019-06-16  Tom Tromey  <tom@tromey.com>
4135
4136         * coffread.c (process_coff_symbol): Use xstrdup.
4137         * value.c (create_internalvar): Use xstrdup.
4138
4139 2019-06-16  Tom Tromey  <tom@tromey.com>
4140
4141         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4142         * breakpoint.c (stopin_command, stopat_command)
4143         (until_break_command, decode_location_default): Remove unnecessary
4144         cast.
4145         * utils.c (subset_compare): Remove unnecessary cast.
4146         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4147         cast.
4148         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4149         cast.
4150         * infcmd.c (path_command): Remove unnecessary cast.
4151         * coffread.c (decode_type): Remove unnecessary cast.
4152         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4153         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4154         * tui/tui-stack.c (tui_show_locator_content)
4155         (tui_show_frame_info): Remove unnecessary cast.
4156         * tui/tui-win.c (tui_scroll_forward_command)
4157         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4158         (parse_scrolling_args): Remove unnecessary cast.
4159         * tui/tui-data.c (init_win_info, tui_del_window)
4160         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4161         (free_content_elements): Remove unnecessary cast.
4162         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4163         unnecessary cast.
4164         * tui/tui-source.c (tui_set_source_content)
4165         (tui_vertical_source_scroll): Remove unnecessary cast.
4166         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4167         cast.
4168         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4169         * tui/tui-regs.c (tui_display_registers_from)
4170         (tui_display_register): Remove unnecessary cast.
4171         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4172         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4173         (make_visible): Remove unnecessary cast.
4174         * tui/tui-winsource.c (tui_erase_source_content)
4175         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4176         unnecessary cast.
4177         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4178         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4179         * stabsread.c (read_type, read_array_type, read_range_type):
4180         Remove unnecessary cast.
4181         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4182         (parse_symbol, parse_type, upgrade_type, parse_external)
4183         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4184         unnecessary cast.
4185         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4186
4187 2019-06-16  Tom Tromey  <tom@tromey.com>
4188
4189         * tui/tui-data.c (tui_alloc_generic_win_info)
4190         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4191         checks.
4192
4193 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4194             Andrew Burgess  <andrew.burgess@embecosm.com>
4195
4196         * f-typeprint.c (f_print_type): Don't return early for not
4197         associated or not allocated types.
4198         (f_type_print_varspec_suffix): Add print_rank parameter and print
4199         ranks of array types in case they dangling.
4200         (f_type_print_base): Add print_rank parameter.
4201
4202 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4203
4204         * NEWS: Mention new MI commands.
4205         * break-catch-throw.c (enum exception_event_kind): Move to
4206         breakpoint.h.
4207         (print_mention_exception_catchpoint): Output text as a single
4208         message.
4209         (catch_exception_command_1): Rename to...
4210         (catch_exception_event): ...this, make non-static, update header
4211         command, and change some parameter types.
4212         (catch_catch_command): Update for changes to
4213         catch_exception_command_1.
4214         (catch_throw_command): Likewise.
4215         (catch_rethrow_command): Likewise.
4216         * breakpoint.c (enum exception_event_kind): Delete.
4217         * breakpoint.h (enum exception_event_kind): Moved here from
4218         break-catch-throw.c.
4219         (catch_exception_event): Declare.
4220         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4221         (mi_cmd_catch_throw): New function.
4222         (mi_cmd_catch_rethrow): New function.
4223         (mi_cmd_catch_catch): New function.
4224         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4225         'catch-catch' entries.
4226         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4227         (mi_cmd_catch_rethrow): Declare.
4228         (mi_cmd_catch_catch): Declare.
4229
4230 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * annotate.c (annotate_source_line): Change return type to void,
4233         update implementation to match.
4234         * annotate.h (annotate_source_line): Change return type to void,
4235         update header comment.
4236         * stack.c (print_frame_info): Don't change what frame information
4237         is printed based on whether annotations are on or not.
4238
4239 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4242         (annotate_source): Make static.
4243         (annotate_source_line): Moved from source.c and renamed from
4244         identify_source_line.  Update the return type.
4245         * annotate.h (annotate_source): Delete declaration.
4246         (annotate_source_line): Declaration moved from source.h, and
4247         renamed from identify_source_line.  Return type updated.
4248         * source.c (identify_source_line): Moved to annotate.c and renamed
4249         to annotate_source_line.
4250         (info_line_command): Remove check of annotation_level.
4251         * source.h (identify_source_line): Move declaration to annotate.h
4252         and rename to annotate_source_line.
4253         * stack.c: Add 'annotate.h' include.
4254         (print_frame_info): Remove check of annotation_level before
4255         calling annotate_source_line.
4256
4257 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * source-cache.c (source_cache::get_plain_source_lines): Use
4260         open_source_file_with_line_charpos instead of just
4261         open_source_file, remove call to find_source_lines.
4262         (source_cache::get_source_lines): Likewise.
4263         * source.c (find_source_lines): Make static.
4264         (get_filename_and_charpos): Renamed into...
4265         (open_source_file_with_line_charpos): ..this along with changes to
4266         return a scoped_fd, and some other minor clean ups.
4267         (identify_source_line): Use open_source_file_with_line_charpos.
4268         (search_command_helper): Use open_source_file_with_line_charpos
4269         instead of just open_source_file, remove call to
4270         find_source_lines.
4271         * source.h (open_source_file_with_line_charpos): Declare new
4272         function.
4273         (find_source_lines): Delete declaration.
4274
4275 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * source.c (get_filename_and_charpos): Remove fullname
4278         parameter.
4279         (identify_source_line): Update call to get_filename_and_charpos.
4280
4281 2019-06-14  Tom Tromey  <tromey@adacore.com>
4282
4283         PR gdb/24502:
4284         * ui-style.h (skip_ansi_escape): Update comment.
4285         * ui-file.h (class no_terminal_escape_file): New class.
4286         * ui-file.c (no_terminal_escape_file::write)
4287         (no_terminal_escape_file::puts): New methods.
4288         * cli/cli-logging.c (handle_redirections): Use
4289         no_terminal_escape_file.
4290
4291 2019-06-14  Tom Tromey  <tromey@adacore.com>
4292
4293         * NEWS: Move convenience variable news above Python news.
4294
4295 2019-06-14  Tom Tromey  <tom@tromey.com>
4296
4297         * gnulib: Move directory to top-level.
4298         * configure.ac: Don't configure gnulib.
4299         * configure: Rebuild.
4300         * common/common-defs.h: Use new path to gnulib.
4301         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4302         (GNULIB_H): Remove.
4303         (INCGNU): Look in new gnulib location.
4304         (HFILES_NO_SRCDIR): Remove gnulib files.
4305         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4306         (generated_files): Remove GNULIB_H.
4307         ($(LIBGNU), all-lib): Remove targets.
4308         (distclean): Don't mention GNULIB_BUILDDIR.
4309         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4310
4311 2019-06-14  Tom Tromey  <tromey@adacore.com>
4312
4313         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4314         Warn if symbol file does not provide any symbols.
4315
4316 2019-06-14  Tom Tromey  <tromey@adacore.com>
4317
4318         * source.c (find_and_open_source): Respect basenames_may_differ.
4319
4320 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4321
4322         * annotate.c (annotate_breakpoints_invalid): Make use of
4323         scoped_restore_terminal_state.
4324         (annotate_frames_invalid): Likewise.
4325
4326 2019-06-14  Tom Tromey  <tromey@adacore.com>
4327
4328         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4329         allow assignment to an internalvar.
4330
4331 2019-06-14  Tom Tromey  <tromey@adacore.com>
4332
4333         * ada-lex.l: Allow "_" in attribute names.
4334
4335 2019-06-14  Tom Tromey  <tromey@adacore.com>
4336
4337         PR gdb/24653:
4338         * regcache.c (registers_changed): Don't call alloca.
4339         * top.c (execute_command): Don't call alloca.
4340
4341 2019-06-13  Pedro Alves  <palves@redhat.com>
4342
4343         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4344         'expression'.  When parsing an expression, error out if there's
4345         junk after "unlimited".
4346         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4347         (do_set_command): Adjust calls to is_unlimited_literal.
4348
4349 2019-06-13  Pedro Alves  <palves@redhat.com>
4350
4351         * compile/compile.c (make_compile_options_def_group): Add braces
4352         around array_view initializer.
4353         * thread.c (make_thread_apply_all_options_def_group)
4354         (make_thread_apply_all_options_def_group): Likewise.
4355
4356 2019-06-13  Pedro Alves  <palves@redhat.com>
4357
4358         * NEWS (New commands): Mention "maint test-options
4359         require-delimiter", "maint test-options unknown-is-error", "maint
4360         test-options unknown-is-operand" and "maint show
4361         test-options-completion-result".
4362         (New command options, command completion): New section.
4363         (Completion improvements): New section.
4364         Mention that you can abbreviate "unlimited".
4365
4366 2019-06-13  Pedro Alves  <palves@redhat.com>
4367
4368         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4369         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4370         * unittests/cli-utils-selftests.c (test_parse_flags)
4371         (test_parse_flags_qcs): Delete.
4372         (test_cli_utils): Don't call deleted functions.
4373
4374 2019-06-13  Pedro Alves  <palves@redhat.com>
4375
4376         * thread.c: Include "cli/cli-option.h".
4377         (tp_array_compar_ascending): Global.
4378         (tp_array_compar): Delete function.
4379         (tp_array_compar_ascending, tp_array_compar_descending): New
4380         functions.
4381         (ascending_option_def, qcs_flag_option_def)
4382         (thr_qcs_flags_option_defs)
4383         (make_thread_apply_all_options_def_group)
4384         (make_thread_apply_options_def_group): New.
4385         (thread_apply_all_command): Use gdb::option::process_options.
4386         (thread_apply_command_completer)
4387         (thread_apply_all_command_completer): New.
4388         (thread_apply_command): Use gdb::option::process_options.
4389         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4390         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4391         to generate help text of "thread apply".  Adjust "taas"'s help.
4392         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4393         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4394
4395 2019-06-13  Pedro Alves  <palves@redhat.com>
4396
4397         * thread.c (thread_apply_command): Check for invalid TID with
4398         isdigit instead of !isalpha.
4399
4400 2019-06-13  Pedro Alves  <palves@redhat.com>
4401
4402         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4403         (validate_flags_qcs): New.
4404         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4405         (validate_flags_qcs): Declare.
4406         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4407         (make_frame_apply_options_def_group): New.
4408         (frame_apply_command_count): Process options with
4409         gdb::option::process_options.
4410         (frame_apply_completer): New.
4411         (frame_apply_level_completer, frame_apply_all_completer)
4412         (frame_apply_completer): New.
4413         (_initialize_stack): Update help of "frame apply", "frame apply
4414         level", "frame apply all" and "faas" to mention supported options
4415         and install command completers.
4416         * stack.h (frame_apply_all_completer): Declare.
4417         * thread.c: Include "stack.h".
4418         (tfaas_command): Add "--".
4419         (_initialize_thread): Update help "tfaas" to mention supported
4420         options and install command completer.
4421
4422 2019-06-13  Pedro Alves  <palves@redhat.com>
4423
4424         * completer.c (complete_nested_command_line): New.
4425         (gdb_completion_word_break_characters_throw): Add assertion.
4426         * completer.h (complete_nested_command_line): Declare.
4427
4428 2019-06-13  Pedro Alves  <palves@redhat.com>
4429
4430         * stack.c (parse_backtrace_qualifiers): New.
4431         (backtrace_command): Use it.
4432         (backtrace_command_completer): Complete on qualifiers.
4433
4434 2019-06-13  Pedro Alves  <palves@redhat.com>
4435
4436         * frame.c: Include "cli/cli-option.h.
4437         (user_set_backtrace_options): New.
4438         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4439         Delete.
4440         (get_prev_frame): Adjust.
4441         (boolean_option_def, uinteger_option_def)
4442         (set_backtrace_option_defs): New.
4443         (_initialize_frame): Adjust and use
4444         gdb::option::add_setshow_cmds_for_options to install "set
4445         backtrace past-main" and "set backtrace past-entry".
4446         * frame.h: Include "cli/cli-option.h".
4447         (struct frame_print_options): Forward declare.
4448         (print_frame_arguments_all, print_frame_arguments_scalars)
4449         (print_frame_arguments_none): Declare.
4450         (print_entry_values): Delete declaration.
4451         (struct frame_print_options, user_frame_print_options): New.
4452         (struct set_backtrace_options): New.
4453         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4454         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4455         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4456         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4457         (list_args_or_locals): Add frame_print_options parameter.
4458         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4459         * python/py-framefilter.c (enumerate_args): Pass down
4460         USER_FRAME_PRINT_OPTIONS.
4461         * stack.c: Include "cli/cli-option.h".
4462         (print_frame_arguments_all, print_frame_arguments_scalars)
4463         (print_frame_arguments_none): Declare.
4464         (print_raw_frame_arguments, print_entry_values): Delete.
4465         (user_frame_print_options): New.
4466         (boolean_option_def, enum_option_def, frame_print_option_defs):
4467         New.
4468         (struct backtrace_cmd_options): New.
4469         (bt_flag_option_def): New.
4470         (backtrace_command_option_defs): New.
4471         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4472         (print_frame_arg, read_frame_arg, print_frame_args)
4473         (print_frame_info, print_frame): Add frame_print_options parameter
4474         and use it.
4475         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4476         (backtrace_command_1): Add frame_print_options and
4477         backtrace_cmd_options parameters and use them.
4478         (make_backtrace_options_def_group): New.
4479         (backtrace_command): Process command options with
4480         gdb::option::process_options.
4481         (backtrace_command_completer): New.
4482         (_initialize_stack): Extend "backtrace"'s help to mention
4483         supported options.  Install completer for "backtrace".
4484         Install some settings commands with add_setshow_cmds_for_options.
4485
4486 2019-06-13  Pedro Alves  <palves@redhat.com>
4487
4488         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4489         and that "set/show print raw frame-arguments" are now deprecated.
4490
4491         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4492         command.
4493         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4494         * stack.c (_initialize_stack): Install "set/show print
4495         raw-frame-arguments", and deprecate "set/show print raw
4496         frame-arguments".
4497         * valprint.c (_initialize_valprint): Deprecate "set/show print
4498         raw".
4499
4500 2019-06-13  Pedro Alves  <palves@redhat.com>
4501
4502         * compile/compile.c (struct compile_options): New.
4503         (compile_flag_option_def, compile_command_option_defs)
4504         (make_compile_options_def_group): New.
4505         (compile_file_command): Handle options with
4506         gdb::option::process_options.
4507         (compile_file_command_completer): New function.
4508         (compile_code_command): Handle options with
4509         gdb::option::process_options.
4510         (compile_code_command_completer): New function.
4511         (_initialize_compiler): Install completers for "compile code" and
4512         "compile file".  Mention available options in "compile code" and
4513         "compile code"'s help.
4514         * completer.c (advance_to_completion_word): New, factored out from
4515         ...
4516         (advance_to_expression_complete_word_point): ... this.
4517         (advance_to_filename_complete_word_point): New.
4518         * completer.h (advance_to_filename_complete_word_point): New
4519         declaration.
4520
4521 2019-06-13  Pedro Alves  <palves@redhat.com>
4522
4523         * compile/compile.c: Include "cli/cli-option.h".
4524         (compile_print_value): Scope data pointer is now a
4525         value_print_options pointer; adjust.
4526         (compile_print_command): Process options.  Scope data pointer is
4527         now a value_print_options pointer; adjust.
4528         (_initialize_compile): Update "compile print"'s help to include
4529         supported options.  Install a completer for "compile print".
4530         * cp-valprint.c (show_vtblprint, show_objectprint)
4531         (show_static_field_print): Delete.
4532         (_initialize_cp_valprint): Don't install "set print
4533         static-members", "set print vtbl", "set print object" here.
4534         * printcmd.c: Include "cli/cli-option.h" and
4535         "common/gdb_optional.h".
4536         (print_command_parse_format): Rework to fill in a
4537         value_print_options instead of a format_data.
4538         (print_value): Change parameter type from format_data pointer to
4539         value_print_options reference.  Adjust.
4540         (print_command_1): Process options.  Adjust to pass down a
4541         value_print_options.
4542         (print_command_completer): New.
4543         (_initialize_printcmd): Install print_command_completer as
4544         handle_brkchars completer for the "print" command.  Update
4545         "print"'s help to include supported options.
4546         * valprint.c: Include "cli/cli-option.h".
4547         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4548         here from cp-valprint.c.
4549         (boolean_option_def, uinteger_option_def)
4550         (value_print_option_defs, make_value_print_options_def_group):
4551         New.  Use gdb::option::add_setshow_cmds_for_options to install
4552         "set print elements", "set print null-stop", "set print repeats",
4553         "set print pretty", "set print union", "set print array", "set
4554         print address", "set print symbol", "set print array-indexes".
4555         * valprint.h: Include <string> and "cli/cli-option.h".
4556         (make_value_print_options_def_group): Declare.
4557         (print_value): Change parameter type from format_data pointer to
4558         value_print_options reference.
4559         (print_command_completer): Declare.
4560
4561 2019-06-13  Pedro Alves  <palves@redhat.com>
4562
4563         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4564         (COMMON_SFILES): Add maint-test-settings.c.
4565         * cli/cli-decode.c (boolean_enums): New global, factored out from
4566         ...
4567         (add_setshow_boolean_cmd): ... here.
4568         * cli/cli-decode.h (boolean_enums): Declare.
4569         * cli/cli-option.c: New file.
4570         * cli/cli-option.h: New file.
4571         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4572         factored out from ...
4573         (parse_cli_boolean_value(const char *)): ... this.
4574         (is_unlimited_literal): Change parameter type to pointer to
4575         pointer.  Adjust and advance ARG pointer.
4576         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4577         (parse_cli_var_enum): New, factored out from ...
4578         (do_set_command): ... this.  Adjust.
4579         * cli/cli-setshow.h (parse_cli_boolean_value)
4580         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4581         (parse_cli_var_enum): Declare.
4582         * cli/cli-utils.c: Include "cli/cli-option.h".
4583         (get_ulongest): New.
4584         * cli/cli-utils.h (get_ulongest): Declare.
4585         (check_for_argument): New overloads.
4586         * maint-test-options.c: New file.
4587
4588 2019-06-13  Pedro Alves  <palves@redhat.com>
4589
4590         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4591         parse a range if "-" is at the end of the string.
4592
4593 2019-06-13  Pedro Alves  <palves@redhat.com>
4594
4595         * cli/cli-setshow.c (parse_auto_binary_operation)
4596         (parse_cli_boolean_value): Don't allow "o".
4597
4598 2019-06-13  Pedro Alves  <palves@redhat.com>
4599
4600         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4601         * NEWS: Mention maint test-settings KIND.
4602         * maint-test-settings.c: New file.
4603
4604 2019-06-13  Pedro Alves  <palves@redhat.com>
4605
4606         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4607         completer.
4608         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4609         "set" completers.
4610
4611 2019-06-13  Pedro Alves  <palves@redhat.com>
4612
4613         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4614         after item.
4615
4616 2019-06-13  Pedro Alves  <palves@redhat.com>
4617
4618         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4619
4620 2019-06-13  Pedro Alves <palves@redhat.com>
4621
4622         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4623         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4624         call.
4625         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4626         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4627         calls.
4628         (check_for_argument): Skip spaces after argument.
4629
4630 2019-06-13  Pedro Alves  <palves@redhat.com>
4631
4632         * thread.c (thread_apply_command): Adjust TID parsing.
4633         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4634         detected before end of string.
4635         (tid_is_in_list): Error out if LIST is invalid.
4636
4637 2019-06-13  Pedro Alves  <palves@redhat.com>
4638
4639         * completer.c (complete_line_internal_1): Rewind completion word
4640         point.
4641         (completion_tracker::advance_custom_word_point_by): Change
4642         parameter type to int.
4643         * completer.h (completion_tracker::advance_custom_word_point_by):
4644         Likewise.
4645
4646 2019-06-13  Pedro Alves  <palves@redhat.com>
4647
4648         * completer.c (advance_to_completion_word): Handle delimiters.
4649
4650 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4651
4652         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4653
4654 2019-06-11  Tom Tromey  <tom@tromey.com>
4655
4656         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4657         (xmalloc_failed): Move to alloc.c.
4658         * alloc.c: New file.
4659         * Makefile.in (COMMON_SFILES): Add alloc.c.
4660
4661 2019-06-11  Tom Tromey  <tom@tromey.com>
4662
4663         * nat/linux-waitpid.c: Don't include server.h.
4664         (linux_debug): Remove.
4665         (my_waitpid): Update.
4666
4667 2019-06-11  Tom Tromey  <tromey@adacore.com>
4668
4669         * infcall.c (_initialize_infcall): Remove trailing newline from
4670         help.
4671         * user-regs.c (_initialize_user_regs): Remove trailing newline
4672         from help.
4673         * typeprint.c (_initialize_typeprint): Remove trailing newline
4674         from help.
4675         * reverse.c (_initialize_reverse): Remove trailing newlines from
4676         help.
4677         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4678         from help.
4679         * language.c (add_set_language_command): Remove trailing newline
4680         from help.
4681         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4682         help.
4683         * disasm.c (_initialize_disasm): Remove trailing newline from
4684         help.
4685         * top.c (init_main): Remove trailing newline from help.
4686         * interps.c (_initialize_interpreter): Remove trailing newline
4687         from help.
4688         * btrace.c (_initialize_btrace): Remove trailing newlines from
4689         help.
4690         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4691         from help.
4692         * python/python.c (_initialize_python): Remove trailing newline
4693         from help.
4694         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4695         help.
4696         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4697         from help.  Reformat some text.
4698         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4699         from help.
4700         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4701         newline from help.
4702
4703 2019-06-11  Tom Tromey  <tromey@adacore.com>
4704
4705         * darwin-nat.c (darwin_decode_exception_message)
4706         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4707
4708 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * valops.c (value_slice): Check for not allocated or not
4711         associated values.
4712
4713 2019-06-10  Tom de Vries  <tdevries@suse.de>
4714
4715         PR gdb/24618
4716         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4717         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4718         invalid.
4719
4720 2019-06-10  Tom de Vries  <tdevries@suse.de>
4721
4722         PR gdb/24611
4723         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4724         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4725
4726 2019-06-10  Tom de Vries  <tdevries@suse.de>
4727
4728         PR symtab/24545
4729         * symtab.c (struct demangled_name_entry): Add language field.
4730         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4731         static minimal symbol".  Set and use language field.
4732
4733 2019-06-10  Tom Tromey  <tromey@adacore.com>
4734
4735         * ada-lang.c (_initialize_ada_language): Update help text.
4736
4737 2019-06-10  Tom Tromey  <tromey@adacore.com>
4738
4739         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4740         with a newline.
4741         * guile/guile.c (handle_boot_error): Don't end warning with a
4742         newline.
4743         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4744         warning with a newline.
4745         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4746         newline.
4747         (s12z_frame_cache): Likewise.
4748         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4749         a newline.
4750         * solib-svr4.c (disable_probes_interface): Don't end warning with
4751         a newline.
4752         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4753         newline.
4754         * python/python.c (do_finish_initialization): Don't end warning
4755         with a newline.
4756
4757 2019-06-10  Tom Tromey  <tom@tromey.com>
4758
4759         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4760         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4761         gdbpy_enter.
4762
4763 2019-06-10  Tom Tromey  <tromey@adacore.com>
4764
4765         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4766         data.
4767         (elf_new_init): Don't call stabsread_new_init.
4768         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4769         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4770         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4771
4772 2019-06-10  Tom de Vries  <tdevries@suse.de>
4773
4774         PR symtab/16264
4775         PR symtab/24517
4776         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4777
4778 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4779
4780         * source.c (find_and_open_source): Also rewrite relative file
4781         names.
4782
4783 2019-04-26  Amos Bird  <amosbird@gmail.com>
4784
4785         * annotate.c (annotate_thread_exited): Add "thread-exited"
4786         annotation.
4787
4788 2019-06-06  Tom Tromey  <tromey@adacore.com>
4789
4790         * maint.h (class scoped_command_stats): Use
4791         DISABLE_COPY_AND_ASSIGN.
4792         <print_time>: New method.
4793         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4794         print_time.
4795         (scoped_command_stats::print_time): New method.
4796
4797 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4798
4799         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4800         instructions of lengths 6 or 8 bytes.
4801
4802 2019-06-04  Pedro Alves  <palves@redhat.com>
4803
4804         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4805
4806         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4807         * breakpoint.c (condition_completer): Likewise.
4808         * cli/cli-dump.c (scan_expression): Likewise.
4809         * common/filestuff.c (mkdir_recursive): Likewise.
4810         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4811         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4812         (gdb_abspath): Likewise.
4813         * compile/compile-cplus-types.c
4814         (compile_cplus_instance::decl_name): Likewise.
4815         * completer.c (complete_explicit_location):
4816         (signal_completer, reg_or_group_completer_1): Likewise.
4817         * cp-support.c (cp_remove_params_if_any): Likewise.
4818         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4819         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4820         * infcmd.c (strip_bg_char): Likewise.
4821         * linespec.c (copy_token_string): Likewise.
4822         * mi/mi-main.c (output_cores): Likewise.
4823         * psymtab.c (psymtab_search_name):
4824         * symfile.c (test_set_ext_lang_command): Likewise.
4825         * target.c (target_fileio_read_stralloc): Likewise.
4826         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4827         * value.c (complete_internalvar): Likewise.
4828
4829 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4830
4831         Add objfile property to gdb.Type.
4832         * NEWS: Mention Python API addition.
4833         * python/py-type.c (typy_get_objfile): New method.
4834
4835 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4836
4837         * NEWS: Mention the new set|show style [title|highlight].
4838         Mention changes to "show style", "help" and "apropos".
4839
4840 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4841
4842         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4843         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4844         instead of print_help_for_command.
4845         (print_doc_of_command): New function.
4846         (help_list): Add 'apropos -v word' suggestion.
4847         (print_help_for_command): Style the command name using title style.
4848         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4849         (_initialize_cli_cmds): Describe -v in apropos_command help.
4850
4851 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4852
4853         * cli/cli-style.h (cli_style_option): Add name in constructor,
4854         add m_name class member, add constructor with intensity,
4855         add name class function.
4856         (cli_style_option::add_setshow_commands): Remove name argument.
4857         (highlight_style, title_style): New styles.
4858         * cli/cli-style.c (do_show): New function that shows a style
4859         characteristic styling the style name with itself.
4860         (set_style_name): New function.
4861         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4862         Update all callers according to the changes in cli/cli-style.h.
4863         * utils.h (fputs_highlighted): New function.
4864         * utils.c (fputs_highlighted): Likewise.
4865
4866 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4867
4868         * NEWS: Mention new pipe command and new convenience variables.
4869
4870 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4871
4872         * cli/cli-cmds.c (pipe_command): New function.
4873         (_initialize_cli_cmds): Call add_com for pipe_command.
4874         Define | as an alias for pipe.
4875         (exit_status_set_internal_vars): New function.
4876         (shell_escape): Call exit_status_set_internal_vars.
4877         cli/cli-decode.c (find_command_name_length): Recognize | as
4878         a single character command.
4879
4880 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4881
4882         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4883         top.c (execute_command_to_ui_file): New function, mostly a copy
4884         of execute_command_to_string.
4885         (execute_command_to_string): Implement by calling
4886         execute_command_to_ui_file.
4887
4888 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4889
4890         * top.h (saved_command_line): Remove declaration.
4891         * top.c (previous_saved_command_line, previous_repeat_arguments):
4892         New variables.
4893         (saved_command_line): Make static, define together with other
4894         'repeat variables'.
4895         (dont_repeat): Clear repeat_arguments.
4896         (repeat_previous, get_saved_command_line, save_command_line):
4897         New functions.
4898         (gdb_init): Initialize saved_command_line
4899         and previous_saved_command_line.
4900         * main.c (captured_main_1): Remove saved_command_line initialization.
4901         * event-top.c (handle_line_of_input): Update to use
4902         the new 'repeat' related functions instead of direct access to
4903         saved_command_line.
4904         * command.h (repeat_previous, get_saved_command_line,
4905         save_command_line): New declarations.
4906         (dont_repeat): Add comment.
4907
4908 2019-05-30  Tom Tromey  <tromey@adacore.com>
4909
4910         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4911         Fix comment.
4912         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4913
4914 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4915
4916         PR cli/24587
4917         * completer.c (complete): Initialize variable word.
4918
4919 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4920
4921         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4922         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4923         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4924         'body' is NULL to the outter 'if', protecting the '!is_define'
4925         situation as well.
4926
4927 2019-05-29  Tom Tromey  <tromey@adacore.com>
4928
4929         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4930         (dwarf_unknown): New function.
4931         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4932         (dwarf_type_encoding_name): Use dwarf_unknown.
4933
4934 2019-05-29  Tom Tromey  <tromey@adacore.com>
4935
4936         PR c++/20020:
4937         * cp-valprint.c (cp_print_value_fields): Call
4938         cp_print_static_field inside "try".
4939
4940 2019-05-29  Tom Tromey  <tromey@adacore.com>
4941
4942         * inflow.c (struct terminal_info): Add default operator=.
4943         * configure: Rebuild.
4944         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4945         -Wdeprecated-copy-dtor, -Wredundant-move.
4946
4947 2019-05-29  Tom Tromey  <tromey@adacore.com>
4948
4949         * NEWS: Add entry.
4950         * infcmd.c (print_return_value_1): Handle finish_print
4951         option.
4952         (show_print_finish): New function.
4953         (_initialize_infcmd): Add "set/show print finish" commands.
4954         * valprint.c (user_print_options): Initialize new member.
4955         * valprint.h (struct value_print_options) <finish_print>: New
4956         member.
4957
4958 2019-05-28  Tom Tromey  <tromey@adacore.com>
4959
4960         * ada-lang.c (ada_remove_Xbn_suffix)
4961         (find_old_style_renaming_symbol)
4962         (parse_old_style_renaming): Remove.
4963         (ada_find_renaming_symbol): Don't call
4964         find_old_style_renaming_symbol.
4965         (ada_is_renaming_symbol): Rename from
4966         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4967         bool.  Now static.
4968         (ada_read_var_value): Update and simplify.
4969         * ada-exp.y (write_var_or_type): Remove old code.
4970
4971 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4972
4973         * event-top.c: Remove include comment.
4974         * inflow.c (class scoped_ignore_sigttou): Move from here...
4975         * inflow.h (class scoped_ignore_sigttou): ...to here.
4976         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4977         * top.c:  Remove include comment.
4978
4979 2019-05-27  Tom Tromey  <tom@tromey.com>
4980
4981         * NEWS: Fix typo.
4982
4983 2019-05-22  Tom Tromey  <tromey@adacore.com>
4984
4985         * target.c (target_follow_exec): Constify parameter.
4986         * target-delegates.c: Rebuild.
4987         * remote.c (remote_target::follow_exec): Constify parameter.
4988         * infrun.c (follow_exec): Constify parameter.
4989         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4990         (target_follow_exec): Likewise.
4991
4992 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4993
4994         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4995         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4996
4997 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4998
4999         * NEWS: Add debugredirect and testsuite sections.
5000
5001 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5002
5003         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5004         target descriptions using exclusively floating point register name
5005         aliases.
5006
5007 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5008
5009         PR gdb/18644:
5010         * f-lang.c (build_fortran_types): Handle the case where
5011         gdbarch_floatformat_for_type returns a nullptr.
5012
5013 2019-05-21  Tom de Vries  <tdevries@suse.de>
5014
5015         PR cli/24587
5016         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5017
5018 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         PR gdb/18644:
5021         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5022         16-byte floats.
5023         * i386-tdep.c (i386_floatformat_for_type): Use
5024         floatformats_ia64_quad for the 16-byte floating point component
5025         within a fortran 32-byte complex number.
5026
5027 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5028
5029         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5030         delete default constructor.
5031         (find_partial_die): Update to return const struct.
5032         (partial_die_parent_scope): Move variable declaration into scope
5033         of its use and change its type to auto.
5034         (guess_partial_die_structure_name): Likewise.
5035         (partial_die_info::fixup): Likewise.
5036
5037 2019-05-17  Tom Tromey  <tromey@adacore.com>
5038
5039         * source.c (find_and_open_source): Remove cast.
5040
5041 2019-05-17  Tom Tromey  <tromey@adacore.com>
5042
5043         * annotate.c (annotate_source): Make "filename" const.
5044         * annotate.h (annotate_source): Use const.
5045
5046 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5047
5048         * disasm.c (set_disassembler_options): Send errors to stderr.
5049
5050 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5051
5052         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5053         (cli_interp_base::set_logging): Check debug_redirect.
5054         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5055         * cli/cli-logging.c (debug_redirect): Add static variable.
5056         (pop_output_files): Add default param.
5057         (handle_redirections): Print debug setting.
5058         (show_logging_command): Likewise.
5059         (_initialize_cli_logging): Add debugredirect command.
5060         * interps.c (current_interp_set_logging): Add debug_redirect
5061         parameter.
5062         * interps.h (set_logging): Add debug_redirect parameter.
5063         (current_interp_set_logging): Likewise.
5064         * mi/mi-common.h: Likewise.
5065         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5066
5067 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5068             Tom Tromey  <tromey@adacore.com>
5069
5070         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5071         directly.
5072         * cli/cli-interp.h (make_logging_output): Remove declaration.
5073         * cli/cli-logging.c (make_logging_output): Remove function.
5074         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5075         directly.
5076         * ui-file.c (tee_file::tee_file): Remove bools.
5077         (tee_file::~tee_file): Remove deletes.
5078         * ui-file.h (tee_file): Remove bools.
5079
5080 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5081
5082         * mi/mi-cmds.h (mi_cmd_complete): New function.
5083         * mi/mi-main.c (mi_cmd_complete): Likewise.
5084         * mi/mi-cmds.c: Define new MI command -complete.
5085         * NEWS: Mention new -complete command.
5086
5087 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5088
5089         * completer.h (complete): New function.
5090         * completer.c (complete): Likewise.
5091         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5092         function defined in completer.h.
5093
5094 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5095
5096         * MAINTAINERS (Write After Approval): Add myself.
5097
5098 2019-05-17  Tom de Vries  <tdevries@suse.de>
5099
5100         PR gdb/24094
5101         * dwarf2read.c (struct cu_partial_die_info): New struct.
5102         (find_partial_die): Return cu_partial_die_info.
5103         (partial_die_parent_scope, guess_partial_die_structure_name)
5104         (partial_die_info::fixup): Handle new return type of find_partial_die.
5105
5106 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5107
5108         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5109         "std::string", simplifying the algorithm.
5110
5111 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5112
5113         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5114         (stap_static_probe_ops::get_probes): Likewise.
5115
5116 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5117
5118         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5119         '-')" and "else if".
5120         (stap_parse_single_operand): Join checks for
5121         "gdbarch_stap_parse_special_token_p" and
5122         "gdbarch_stap_parse_special_token" in the same "if" statement.
5123         Invert check when verifying for operation on register
5124         displacement.
5125
5126 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5127
5128         * stap-probe.c (stap_get_opcode): Update comment.
5129         (stap_get_expected_argument_type): Likewise.
5130         (handle_stap_probe): Likewise.
5131
5132 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5133
5134         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5135         return type to 'bool'.  Adjust comment.  Use 'bool' when
5136         appropriate.
5137         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5138         * stap-probe.c (stap_parse_argument_1): Likewise.
5139         (stap_is_operator): Likewise.
5140         (stap_is_generic_prefix): Likewise.
5141         (stap_is_register_prefix): Likewise.
5142         (stap_is_register_indirection_prefix): Likewise.
5143         (stap_is_integer_prefix): Likewise.
5144         (stap_generic_check_suffix): Likewise.
5145         (stap_check_integer_suffix): Likewise.
5146         (stap_check_register_suffix): Likewise.
5147         (stap_check_register_indirection_suffix): Likewise.
5148         (stap_parse_register_operand): Likewise.
5149         (stap_parse_single_operand): Likewise.
5150         (stap_parse_argument_1): Likewise.
5151         (stap_probe::get_argument_count): Likewise.
5152         (stap_is_operator): Likewise.
5153
5154 2019-05-16  Tom Tromey  <tromey@adacore.com>
5155
5156         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5157         keyword to foreach.
5158
5159 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5160
5161         * linux-thread-db.c (try_thread_db_load_1): Change return type
5162         to bool.
5163         (try_thread_db_load): Likewise.
5164         (try_thread_db_load_from_pdir_1): Likewise.
5165         (try_thread_db_load_from_pdir): Likewise.
5166         (try_thread_db_load_from_sdir): Likewise.
5167         (try_thread_db_load_from_dir): Likewise.
5168         (thread_db_load_search): Likewise.
5169         (has_libpthread): Likewise.
5170         (thread_db_load): Likewise.
5171
5172 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5173
5174         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5175         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5176         NULL, and complain/return if that's the case.
5177
5178 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5179
5180         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5181         (advance, posn, abstract_read_memory): New functions.
5182         [struct mem_read_abstraction]: New struct.
5183         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5184
5185 2019-05-14  Tom Tromey  <tromey@adacore.com>
5186
5187         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5188         value is not lval_memory.
5189
5190 2019-05-14  Tom Tromey  <tromey@adacore.com>
5191
5192         * solib.c (info_sharedlibrary_command): Style the file name.
5193
5194 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5195
5196         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5197         (aarch64_vnv_type): Likewise.
5198         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5199         * common/tdesc.c: Likewise.
5200         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5201         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5202         * features/aarch64-fpu.xml: Add ieee half view.
5203         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5204         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5205         * gdbtypes.h (struct builtin_type): Likewise.
5206         (struct objfile_type): Likewise.
5207
5208 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5209
5210         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5211         typo.
5212         * location.h (string_to_event_location): Likewise.
5213
5214 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5215
5216         GDB 8.3 released.
5217
5218 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5219
5220         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5221         New variable declaration.
5222         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5223         New variable.
5224         (print_one_breakpoint): Use ui_out::test_flags and new global
5225         variable to compute use_fixed_output.
5226         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5227         Remove.
5228         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5229         (mi_multi_location_breakpoint_output_fixed): Remove.
5230         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5231         new variable.
5232         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5233         fix_multi_location_breakpoint_output flag if version >= 3.
5234         * ui-out.h (enum ui_out_flag)
5235         <fix_multi_location_breakpoint_output>: New enumerator.
5236
5237 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5238
5239         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5240
5241 2019-05-10  Tom Tromey  <tromey@adacore.com>
5242
5243         * ada-lang.c (catch_ada_completer): New function.
5244         (_initialize_ada_language): Use it.
5245
5246 2019-05-10  Tom Tromey  <tromey@adacore.com>
5247
5248         * thread.c (print_thread_info): Make "requested_threads" const.
5249         * gdbthread.h (print_thread_info): Make "requested_threads"
5250         const.
5251         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5252         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5253
5254 2019-05-08  Tom Tromey  <tom@tromey.com>
5255
5256         * gdbtypes.c (objfile_type_data): Change type.
5257         (objfile_type, _initialize_gdbtypes): Update.
5258
5259 2019-05-08  Tom Tromey  <tom@tromey.com>
5260
5261         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5262         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5263         (_initialize_dwarf2_frame): Update.
5264
5265 2019-05-08  Tom Tromey  <tom@tromey.com>
5266
5267         * objc-lang.c (objc_objfile_data): Change type.
5268         (find_methods): Update.
5269         (_initialize_objc_lang): Remove.
5270
5271 2019-05-08  Tom Tromey  <tom@tromey.com>
5272
5273         * stabsread.c (rs6000_builtin_type_data): Change type.
5274         (rs6000_builtin_type, _initialize_stabsread): Update.
5275
5276 2019-05-08  Tom Tromey  <tom@tromey.com>
5277
5278         * mips-tdep.c (mips_pdr_data): Remove.
5279         (_initialize_mips_tdep): Update.
5280
5281 2019-05-08  Tom Tromey  <tom@tromey.com>
5282
5283         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5284         (hppa_init_objfile_priv_data, read_unwind_info)
5285         (find_unwind_entry, _initialize_hppa_tdep): Update.
5286
5287 2019-05-08  Tom Tromey  <tom@tromey.com>
5288
5289         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5290         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5291         on obstack.
5292         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5293
5294 2019-05-08  Tom Tromey  <tom@tromey.com>
5295
5296         * mdebugread.c (basic_type_data): Change type.
5297         (basic_type, _initialize_mdebugread): Update.
5298
5299 2019-05-08  Tom Tromey  <tom@tromey.com>
5300
5301         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5302
5303 2019-05-08  Tom Tromey  <tom@tromey.com>
5304
5305         * nto-tdep.c (nto_inferior_data_reg): Change type.
5306         (nto_inferior_data): Update.
5307         (nto_inferior_data_cleanup, nto_new_inferior_data)
5308         (_initialize_nto_tdep): Remove.
5309         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5310
5311 2019-05-08  Tom Tromey  <tom@tromey.com>
5312
5313         * ada-lang.c (struct ada_inferior_data): Add initializers.
5314         (ada_inferior_data): Change type.
5315         (ada_inferior_data_cleanup): Remove.
5316         (get_ada_inferior_data, ada_inferior_exit)
5317         (struct ada_pspace_data): Add initializers, destructor.
5318         (ada_pspace_data_handle): Change type.
5319         (get_ada_pspace_data): Update.
5320         (ada_pspace_data_cleanup): Remove.
5321
5322 2019-05-08  Tom Tromey  <tom@tromey.com>
5323
5324         * coffread.c (struct coff_symfile_info): Add initializers.
5325         (coff_objfile_data_key): Move lower.  Change type.
5326         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5327         Update.
5328         (coff_free_info): Remove.
5329
5330 2019-05-08  Tom Tromey  <tom@tromey.com>
5331
5332         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5333         (fbsd_pspace_data_handle): Move lower.  Change type.
5334         (get_fbsd_pspace_data): Update.
5335         (fbsd_pspace_data_cleanup): Remove.
5336         (_initialize_fbsd_tdep): Update.
5337
5338 2019-05-08  Tom Tromey  <tom@tromey.com>
5339
5340         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5341         (get_ada_tasks_pspace_data): Update.
5342         (ada_tasks_pspace_data_cleanup): Remove.
5343         (_initialize_tasks): Update.
5344         (ada_tasks_inferior_data_handle): Change type.
5345         (get_ada_tasks_inferior_data): Update.
5346         (ada_tasks_inferior_data_cleanup): Remove.
5347         (struct ada_tasks_pspace_data): Add initializers.
5348
5349 2019-05-08  Tom Tromey  <tom@tromey.com>
5350
5351         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5352         * symfile-debug.c (debug_sym_get_probes): Change type.
5353         * stap-probe.c (handle_stap_probe):
5354         (stap_static_probe_ops::get_probes): Change type.
5355         * probe.h (class static_probe_ops) <get_probes>: Change type.
5356         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5357         (parse_probes_in_pspace): Update.
5358         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5359         Update.
5360         (any_static_probe_ops::get_probes): Change type.
5361         * elfread.c (elfread_data): New typedef.
5362         (probe_key): Change type.
5363         (elf_get_probes): Likewise.  Update.
5364         (probe_key_free): Remove.
5365         (_initialize_elfread): Update.
5366         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5367         Change type.
5368         (dtrace_process_dof_probe, dtrace_process_dof)
5369         (dtrace_static_probe_ops::get_probe): Change type.
5370
5371 2019-05-08  Tom Tromey  <tom@tromey.com>
5372
5373         * xcoffread.c (struct xcoff_symfile_info): Rename from
5374         coff_symfile_info.  Add initializers.
5375         (xcoff_objfile_data_key): Move lower.  Change type.
5376         (XCOFF_DATA): Rewrite.
5377         (xcoff_free_info): Remove.
5378         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5379         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5380         (xcoff_initial_scan): Update.
5381
5382 2019-05-08  Tom Tromey  <tom@tromey.com>
5383
5384         * solib-svr4.c (struct svr4_info): Add initializers and
5385         destructor.
5386         <probes_table>: Now an htab_up.
5387         (solib_svr4_pspace_data): Change type.
5388         (free_probes_table): Simplify.
5389         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5390         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5391         (probes_table_remove_objfile_probes, register_solib_event_probe)
5392         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5393         (_initialize_svr4_solib): Update.
5394
5395 2019-05-08  Tom Tromey  <tom@tromey.com>
5396
5397         * remote.c (remote_pspace_data): Change type.
5398         (remote_pspace_data_cleanup): Remove.
5399         (get_remote_exec_file, set_pspace_remote_exec_file)
5400         (_initialize_remote): Update.
5401
5402 2019-05-08  Tom Tromey  <tom@tromey.com>
5403
5404         * breakpoint.c (breakpoint_objfile_key): Change type.
5405         (get_breakpoint_objfile_data): Update.
5406         (free_breakpoint_objfile_data): Remove.
5407         (_initialize_breakpoint): Update.
5408
5409 2019-05-08  Tom Tromey  <tom@tromey.com>
5410
5411         * linux-tdep.c (struct linux_info): Add initializers.
5412         (linux_inferior_data): Move.  Change type.
5413         (invalidate_linux_cache_inf): Update.
5414         (linux_inferior_data_cleanup): Remove.
5415         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5416
5417 2019-05-08  Tom Tromey  <tom@tromey.com>
5418
5419         * auxv.c (auxv_inferior_data): Move.  Change type.
5420         (auxv_inferior_data_cleanup): Remove.
5421         (invalidate_auxv_cache_inf): Rewrite.
5422         (get_auxv_inferior_data, _initialize_auxv): Update.
5423
5424 2019-05-08  Tom Tromey  <tom@tromey.com>
5425
5426         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5427         (symfile_debug_objfile_data_key): Change type.
5428         (symfile_debug_installed, debug_qf_has_symbols)
5429         (debug_qf_find_last_source_symtab)
5430         (debug_qf_forget_cached_source_info)
5431         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5432         (debug_qf_print_stats, debug_qf_dump)
5433         (debug_qf_expand_symtabs_for_function)
5434         (debug_qf_expand_all_symtabs)
5435         (debug_qf_expand_symtabs_with_fullname)
5436         (debug_qf_map_matching_symbols)
5437         (debug_qf_expand_symtabs_matching)
5438         (debug_qf_find_pc_sect_compunit_symtab)
5439         (debug_qf_map_symbol_filenames)
5440         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5441         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5442         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5443         (debug_sym_read_linetable, debug_sym_relocate): Update.
5444         (symfile_debug_free_objfile): Remove.
5445         (install_symfile_debug_logging, _initialize_symfile_debug):
5446         Update.
5447
5448 2019-05-08  Tom Tromey  <tom@tromey.com>
5449
5450         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5451         allocate_on_obstack.
5452         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5453         (get_dwarf2_per_objfile): Update.
5454         (set_dwarf2_per_objfile): Remove.
5455         (dwarf2_has_info, dwarf2_get_section_info): Update.
5456         (dwarf2_free_objfile): Remove.
5457         (_initialize_dwarf2_read): Update.
5458
5459 2019-05-08  Tom Tromey  <tom@tromey.com>
5460
5461         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5462         initializers.
5463         <unsupported_script_warning_printed,
5464         script_not_found_warning_printed>: Now bool.
5465         (auto_load_pspace_data): Change type.
5466         (~auto_load_pspace_info): Rename from
5467         auto_load_pspace_data_cleanup.
5468         (get_auto_load_pspace_data, init_loaded_scripts_info)
5469         (clear_section_scripts, maybe_print_unsupported_script_warning)
5470         (maybe_print_script_not_found_warning, _initialize_auto_load):
5471         Update.
5472
5473 2019-05-08  Tom Tromey  <tom@tromey.com>
5474
5475         * objfiles.c (objfile_pspace_info): Add destructor and
5476         initializers.
5477         (objfiles_pspace_data): Change type.
5478         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5479         (get_objfile_pspace_data): Update.
5480         (objfiles_bfd_data): Change type.
5481         (get_objfile_bfd_data): Update.
5482         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5483
5484 2019-05-08  Tom Tromey  <tom@tromey.com>
5485
5486         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5487         Change type.
5488         (get_catch_syscall_inferior_data): Update.
5489         (catch_syscall_inferior_data_cleanup): Remove.
5490         (_initialize_break_catch_syscall): Update.
5491
5492 2019-05-08  Tom Tromey  <tom@tromey.com>
5493
5494         * inflow.c (struct terminal_info): Add destructor and
5495         initializers.
5496         (inflow_inferior_data): Change type.
5497         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5498         (get_inflow_inferior_data, inflow_inferior_exit)
5499         (swap_terminal_info, _initialize_inflow): Update.
5500
5501 2019-05-08  Tom Tromey  <tom@tromey.com>
5502
5503         * target-dcache.c (target_dcache_cleanup): Remove.
5504         (target_dcache_aspace_key): Change type.
5505         (target_dcache_init_p, target_dcache_invalidate)
5506         (target_dcache_get, target_dcache_get_or_init)
5507         (_initialize_target_dcache): Update.
5508         * dcache.h (struct dcache_deleter): New.
5509
5510 2019-05-08  Tom Tromey  <tom@tromey.com>
5511
5512         * symtab.c (struct symbol_cache): Add destructor and
5513         initializers.
5514         (symbol_cache_key): Move.  Change type.
5515         (make_symbol_cache, free_symbol_cache): Remove.
5516         (get_symbol_cache): Update.
5517         (symbol_cache_cleanup): Remove.
5518         (ALL_PSPACES, symbol_cache_flush)
5519         (maintenance_print_symbol_cache)
5520         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5521         Update.
5522
5523 2019-05-08  Tom Tromey  <tom@tromey.com>
5524
5525         * symtab.c (struct main_info): Add destructor and initializers.
5526         (main_progspace_key): Move.  Change type.
5527         (get_main_info): Update.
5528         (main_info_cleanup): Remove.
5529         (_initialize_symtab): Update.
5530
5531 2019-05-08  Tom Tromey  <tom@tromey.com>
5532
5533         * registry.h (DECLARE_REGISTRY): Define the _key class.
5534
5535 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5536
5537         * NEWS: Merge two 'New commands' sections.
5538
5539 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5540
5541         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5542         parameter and use Ada language definition instead.
5543         (ada_val_print_ptr): Remove unused language parameter.
5544         (ada_val_print_num): Remove language parameter and use Ada language
5545         definition instead.
5546         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5547         parameter.
5548         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5549         parameter and use Ada language definition instead.
5550         (ada_val_print_1): Update all ada_val_print_xxx calls.
5551         Remove language parameter.
5552         (ada_val_print): Update ada_val_print_1 call.
5553
5554 2019-05-08  Tom Tromey  <tromey@adacore.com>
5555
5556         * remote.c (remote_hw_watchpoint_limit)
5557         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5558         Now static.
5559
5560 2019-05-08  Tom Tromey  <tromey@adacore.com>
5561
5562         * maint.c (_initialize_maint_cmds): Move initialization code to
5563         remote.c.
5564         (watchdog, show_watchdog): Move to remote.c.
5565         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5566         "watchdog" static.
5567         (_initialize_remote): Move initialization code from maint.c.
5568         * defs.h (watchdog): Don't declare.
5569
5570 2019-05-08  Tom Tromey  <tromey@adacore.com>
5571
5572         * tui/tui-interp.c: Include main.h.
5573         * interps.c: Include main.h.
5574         * main.h (interpreter_p): Declare.
5575         * defs.h (interpreter_p): Don't declare.
5576
5577 2019-05-08  Tom Tromey  <tromey@adacore.com>
5578
5579         * dwarf2loc.c: Include dwarf2read.h.
5580         * defs.h (read_unsigned_leb128): Don't declare.
5581         * dwarf2read.h (read_unsigned_leb128): Declare.
5582
5583 2019-05-08  Tom Tromey  <tromey@adacore.com>
5584
5585         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5586         method.
5587
5588 2019-05-08  Tom Tromey  <tromey@adacore.com>
5589
5590         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5591         when no wrap column is set.
5592
5593 2019-05-08  Tom Tromey  <tromey@adacore.com>
5594
5595         * c-lang.c (c_get_string): Handle non-C-style arrays.
5596
5597 2019-05-08  Tom Tromey  <tromey@adacore.com>
5598
5599         * typeprint.c (print_offset_data::update): Print the bit offset,
5600         not the number of bits remaining.
5601
5602 2019-05-08  Tom Tromey  <tromey@adacore.com>
5603
5604         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5605         padding at end of comment.
5606
5607 2019-05-08  Tom Tromey  <tromey@adacore.com>
5608
5609         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5610         Compare main types.
5611
5612 2019-05-06  Tom Tromey  <tom@tromey.com>
5613
5614         * common/scoped_mmap.c: Include common-defs.h.
5615         * common/scoped_mmap.h: Don't include config.h.
5616
5617 2019-05-04  Tom Tromey  <tom@tromey.com>
5618
5619         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5620         (struct aarch64_call_info): Add initializers.
5621         <si>: Now a std::vector.
5622         (pass_on_stack, aarch64_push_dummy_call): Update.
5623
5624 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5625             Tom Tromey  <tom@tromey.com>
5626
5627         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5628         (ppc_threads): Now a std::vector.  Now static.
5629         (hwdebug_find_thread_points_by_tid)
5630         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5631         Update.
5632
5633 2019-05-04  Tom Tromey  <tom@tromey.com>
5634
5635         * arc-tdep.c (arc_tdesc_init): Return bool.
5636
5637 2019-05-04  Tom Tromey  <tom@tromey.com>
5638
5639         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5640         Use gdb_assert_not_reached.
5641
5642 2019-05-04  Tom Tromey  <tom@tromey.com>
5643
5644         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5645         "false".
5646
5647 2019-05-04  Tom Tromey  <tom@tromey.com>
5648
5649         * arc-tdep.c (arc_tdesc_init): Use bool.
5650
5651 2019-05-04  Tom Tromey  <tom@tromey.com>
5652
5653         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5654
5655 2019-05-04  Tom Tromey  <tom@tromey.com>
5656
5657         * cli/cli-cmds.c (valid_command_p): Return bool.
5658
5659 2019-05-04  Tom Tromey  <tom@tromey.com>
5660
5661         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5662         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5663
5664 2019-05-04  Raul Tambre  <raul@tambre.ee>
5665
5666         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5667         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5668         operator for comparison.
5669
5670 2019-05-04  Tom Tromey  <tom@tromey.com>
5671
5672         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5673         (lookup_partial_symbol, print_partial_symbols)
5674         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5675         (psymbol_compare): Update.
5676         (add_psymbol_to_bcache): Clear the entire psymbol.
5677         (maintenance_check_psymtabs): Update.
5678         * psympriv.h (struct partial_symbol): Don't derive from
5679         general_symbol_info.
5680         <obj_section, unrelocated_address, address,
5681         set_unrelocated_address>: Update.
5682         <ginfo>: New member.
5683         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5684         (debug_names::write_psymbols): Update.
5685
5686 2019-05-04  Tom de Vries  <tdevries@suse.de>
5687
5688         * contrib/cc-with-tweaks.sh: Support -n arg.
5689
5690 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5691
5692         * corelow.c (core_target::detach): Ensure frame cache and
5693         register caches are cleared.
5694         inferior.c (exit_inferior_1): Likewise.
5695
5696 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5697             Tom Tromey  <tom@tromey.com>
5698
5699         * dictionary.c (collate_pending_symbols_by_language): Remove
5700         "struct" from foreach.
5701         * symtab.c (lookup_global_symbol_from_objfile)
5702         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5703         foreach.
5704         * ser-tcp.c (net_open): Remove "struct" from foreach.
5705         * objfiles.c (objfile_relocate, objfile_rebase)
5706         (objfile_has_symbols): Remove "struct" from foreach.
5707         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5708         from foreach.
5709         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5710         foreach.
5711         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5712         "struct" from foreach.
5713         * ada-lang.c (create_excep_cond_exprs)
5714         (ada_exception_catchpoint_cond_string): Remove "struct" from
5715         foreach.
5716
5717 2019-05-03  Tom Tromey  <tromey@adacore.com>
5718
5719         * ada-exp.y (convert_char_literal): Check suffix of each
5720         enumerator.
5721
5722 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5723
5724         PR ada/21406:
5725         * ada-exp.y (yywrap): Don't define.
5726         * ada-lex.l (%option): Add noyywrap
5727         (yywrap): Remove.
5728
5729 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5730
5731         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5732         _WIN32_WINNT to the XP level, unless already defined to a higher
5733         level.
5734
5735         * unittests/parse-connection-spec-selftests.c:
5736         * ser-tcp.c:
5737         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5738         override.
5739
5740         * symfile.c (find_separate_debug_file): Remove colon from the
5741         drive spec of DOS/Windows file names of the target, so that the
5742         file name produced from DEBUGDIR and the target's directory will
5743         be valid on DOS/Windows systems.
5744
5745 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5746
5747         * rust-lang.c (val_print_struct): Handle printing structures
5748         containing strings.
5749
5750 2019-05-02  Tom Tromey  <tromey@adacore.com>
5751
5752         * valarith.c (_initialize_valarith): Remove.
5753
5754 2019-05-01  Tom Tromey  <tromey@adacore.com>
5755
5756         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5757         bitfields.
5758
5759 2019-05-01  Tom Tromey  <tromey@adacore.com>
5760
5761         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5762         for big-endian copies.
5763
5764 2019-04-30  Ali Tamur  <tamur@google.com>
5765         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5766         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5767         (read_3_bytes): New function.
5768
5769 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5770
5771         * windows-nat.c (main_thread_id): Delete.
5772         (handle_output_debug_string): Replace main_thread_id by
5773         current_event.dwThreadId.
5774         (fake_create_process): Likewise.
5775         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5776         Do not set main_thread_id.
5777         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5778         current_event.dwThreadId.
5779         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5780
5781 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5782
5783         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5784         Use current_event.dwThreadId instead of main_thread_id.
5785
5786 2019-04-30  Tom Tromey  <tromey@adacore.com>
5787
5788         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5789         (create_excep_cond_exprs): Iterate over program spaces.
5790         (ada_exception_catchpoint_cond_string): Examine all minimal
5791         symbols for exception types.
5792
5793 2019-04-30  Tom Tromey  <tromey@adacore.com>
5794
5795         PR c++/24470:
5796         * dwarf2read.c (process_structure_scope): Handle case where type
5797         has template parameters but no symbol was created.
5798
5799 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5800             Chris January  <chris.january@arm.com>
5801
5802         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5803         qualifier.
5804         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5805
5806 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * f-typeprint.c (f_print_type): Update rules for printing
5809         whitespace.
5810         (f_type_print_varspec_suffix): Likewise.
5811
5812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5813             Chris January  <chris.january@arm.com>
5814
5815         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5816         function arguments.
5817
5818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5819
5820         * f-lang.c (build_fortran_types): Change name of void type to
5821         lower case.
5822         * f-typeprint.c (f_type_print_base): Print the name of the void
5823         type, rather than a fixed string.
5824         * f-valprint.c (f_decorations): Use lower case void string.
5825
5826 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5827             Chris January  <chris.january@arm.com>
5828
5829         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5830         types for Fortran.
5831
5832 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5833             Chris January  <chris.january@arm.com>
5834             David Lecomber  <david.lecomber@arm.com>
5835
5836         * f-exp.y (BINOP_INTRINSIC): New token.
5837         (exp): New parser rule handling BINOP_INTRINSIC.
5838         (f77_keywords): Add new builtin procedures.
5839         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5840         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5841         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5842         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5843         (print_unop_subexp_f): New function.
5844         (print_binop_subexp_f): New function.
5845         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5846         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5847         (dump_subexp_body_f): Likewise.
5848         (operator_check_f): Likewise.
5849         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5850         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5851
5852 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5853
5854         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5855         UNOP_KIND.
5856         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5857         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5858         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5859         (operator_length_f): New fuction.
5860         (print_subexp_f): New function.
5861         (op_name_f): New function.
5862         (dump_subexp_body_f): New function.
5863         (operator_check_f): New function.
5864         (exp_descriptor_f): Replace standard expression handling functions
5865         with new functions.
5866         * gdb/fortran-operator.def: New file.
5867         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5868         * gdb/std-operator.def: Remove UNOP_KIND.
5869
5870 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5871
5872         * std-operator.def: Remove unbalanced, stray double quote
5873         character.
5874
5875 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5876             Chris January  <chris.january@arm.com>
5877             Daniel Everett  <daniel.everett@arm.com>
5878             Nick Forrington  <nick.forrington@arm.com>
5879             Richard Bunt  <richard.bunt@arm.com>
5880
5881         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5882         of depth when printing anonymous structs or unions.
5883         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5884         Don't print either the top-level value, or the children if the
5885         max-depth is exceeded.
5886         (ppscm_print_children): When printing the key of a map, allow one
5887         extra level of depth.
5888         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5889         print either the top-level value, or the children if the max-depth
5890         is exceeded.
5891         (print_children): When printing the key of a map, allow one extra
5892         level of depth.
5893         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5894         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5895         (user_print_options): Initialise max_depth field.
5896         (val_print_scalar_or_string_type_p): New function.
5897         (val_print): Check to see if the max depth has been reached.
5898         (val_print_check_max_depth): Define new function.
5899         (show_print_max_depth): New function.
5900         (_initialize_valprint): Add 'print max-depth' option.
5901         * valprint.h (struct value_print_options) <max_depth>: New field.
5902         (val_print_check_max_depth): Declare new function.
5903         * NEWS: Document new feature.
5904
5905 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5906
5907         * ada-lang.c (ada_language_defn): Initialise new field.
5908         * c-lang.c (c_is_string_type_p): New function.
5909         (c_language_defn): Initialise new field.
5910         (cplus_language_defn): Initialise new field.
5911         (asm_language_defn): Initialise new field.
5912         (minimal_language_defn): Initialise new field.
5913         * c-lang.h (c_is_string_type_p): Declare new function.
5914         * d-lang.c (d_language_defn): Initialise new field.
5915         * f-lang.c (f_is_string_type_p): New function.
5916         (f_language_defn): Initialise new field.
5917         * go-lang.c (go_is_string_type_p): New function.
5918         (go_language_defn): Initialise new field.
5919         * language.c (default_is_string_type_p): New function.
5920         (unknown_language_defn): Initialise new field.
5921         (auto_language_defn): Initialise new field.
5922         * language.h (struct language_defn) <la_is_string_type_p>: New
5923         member variable.
5924         (default_is_string_type_p): Declare new function.
5925         * m2-lang.c (m2_language_defn): Initialise new field.
5926         * objc-lang.c (objc_language_defn): Initialise new field.
5927         * opencl-lang.c (opencl_language_defn): Initialise new field.
5928         * p-lang.c (pascal_is_string_type_p): New function.
5929         (pascal_language_defn): Initialise new field.
5930         * rust-lang.c (rust_is_string_type_p): New function.
5931         (rust_language_defn): Initialise new field.
5932
5933 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5934
5935         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5936         New field.
5937         * ada-lang.c (ada_language_defn): Initialise new field.
5938         * c-lang.c (c_language_defn): Likewise.
5939         (cplus_language_defn): Likewise.
5940         (asm_language_defn): Likewise.
5941         (minimal_language_defn): Likewise.
5942         * d-lang.c (d_language_defn): Likewise.
5943         * f-lang.c (f_language_defn): Likewise.
5944         * go-lang.c (go_language_defn): Likewise.
5945         * language.c (unknown_language_defn): Likewise.
5946         (auto_language_defn): Likewise.
5947         * m2-lang.c (m2_language_defn): Likewise.
5948         * objc-lang.c (objc_language_defn): Likewise.
5949         * opencl-lang.c (opencl_language_defn): Likewise.
5950         * p-lang.c (pascal_language_defn): Likewise.
5951         * rust-lang.c (rust_language_defn): Likewise.
5952
5953 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * ada-lang.c (ada_is_character_type): Change return type to bool.
5956         (ada_is_string_type): Likewise.
5957         * ada-lang.h (ada_is_character_type): Update declaration
5958         (ada_is_string_type): Likewise.
5959
5960 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5961
5962         Support style in 'frame|thread apply'
5963
5964         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5965         * record.c (record_start, record_stop): Update callers of
5966         execute_command_to_string with false.
5967         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5968         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5969         methods.
5970         (class string_file): New constructor with term_out parameter.
5971         Override methods term_out and can_emit_style_escape.  New member
5972         term_out.
5973         (class stdio_file): Override can_emit_style_escape.
5974         (class tee_file): Override term_out and can_emit_style_escape.
5975         * utils.h (can_emit_style_escape): Remove.
5976         * utils.c (can_emit_style_escape): Likewise.
5977         Update all callers of can_emit_style_escape (SOMESTREAM) to
5978         SOMESTREAM->can_emit_style_escape.
5979         * source-cache.c (source_cache::get_source_lines): Likewise.
5980         * stack.c (frame_apply_command_count): Call execute_command_to_string
5981         passing the term_out characteristic of the current gdb_stdout.
5982         * thread.c (thr_try_catch_cmd): Likewise.
5983         * top.c (execute_command_to_string): pass term_out parameter
5984         to construct the string_file for the command output.
5985         * ui-file.c (term_cli_styling): New function (most code moved
5986         from utils.c can_emit_style_escape).
5987         (string_file::string_file, string_file::can_emit_style_escape,
5988         stdio_file::can_emit_style_escape, tee_file::term_out,
5989         tee_file::can_emit_style_escape): New functions.
5990
5991 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5992
5993         * NEWS: Mention the new set|show may-call-functions.
5994         * infcall.c (may_call_functions_p): New variable.
5995         (show_may_call_functions_p): New function.
5996         (call_function_by_hand_dummy): Throws an error if not
5997         may-call-functions.
5998         (_initialize_infcall): Call add_setshow_boolean_cmd for
5999         may-call-functions.
6000
6001 2019-04-25  Keith Seitz  <keiths@redhat.com>
6002
6003         PR c++/24367
6004         * cp-support.c (inspect_type): Don't attempt substitutions
6005         of symbol with the same name.
6006
6007 2019-04-25  Tom Tromey  <tromey@adacore.com>
6008
6009         PR gdb/24475:
6010         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6011         static.
6012
6013 2019-04-25  Tom Tromey  <tromey@adacore.com>
6014
6015         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6016         rvalue reference.
6017         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6018         (gdb_xml_parser::parse): Use std::move.
6019         * python/python-internal.h (gdbpy_convert_exception): Take a const
6020         reference.
6021         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6022         std::move.
6023         * python/py-utils.c (gdbpy_convert_exception): Take a const
6024         reference.
6025         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6026         Use std::move.
6027         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6028         Use std::move.
6029         * mi/mi-main.c (mi_print_exception): Take a const reference.
6030         * main.c (handle_command_errors): Take a const reference.
6031         * linespec.c (parse_linespec): Use std::move.
6032         * infcall.c (run_inferior_call): Use std::move.
6033         (call_function_by_hand_dummy): Use std::move.
6034         * exec.c (try_open_exec_file): Use std::move.
6035         * exceptions.h (exception_print, exception_fprintf)
6036         (exception_print_same): Update.
6037         * exceptions.c (print_exception, exception_print)
6038         (exception_fprintf, exception_print_same): Change parameters to
6039         const reference.
6040         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6041         * common/new-op.c: Use std::move.
6042         * common/common-exceptions.h (struct gdb_exception): Add move
6043         constructor.
6044         (struct gdb_exception_error, struct gdb_exception_quit, struct
6045         gdb_quit_bad_alloc): Change constructor to move constructor.
6046         (throw_exception): Change parameter to rvalue reference.
6047         * common/common-exceptions.c (throw_exception): Take rvalue
6048         reference.
6049         * cli/cli-interp.c (safe_execute_command): Use std::move.
6050         * breakpoint.c (insert_bp_location, location_to_sals): Use
6051         std::move.
6052
6053 2019-04-25  Tom Tromey  <tromey@adacore.com>
6054
6055         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6056         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6057         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6058         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6059         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6060         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6061         guile/scm-value.c: Use unpack.
6062         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6063         gdbscm_gdb_exception.
6064         (gdbscm_throw_gdb_exception): Likewise.
6065         (struct gdbscm_gdb_exception): New.
6066         (unpack): New function.
6067         (gdbscm_wrap): Use unpack.
6068
6069 2019-04-25  Tom Tromey  <tromey@adacore.com>
6070
6071         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6072         (gdb_rl_callback_handler): Use std::move.
6073         * common/common-exceptions.h (struct gdb_exception): Add move
6074         assignment operator.
6075         (throw_exception_sjlj): Change "exception" to const reference.
6076         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6077         (throw_exception_sjlj): Change "exception" to const reference.
6078
6079 2019-04-25  Tom Tromey  <tromey@adacore.com>
6080
6081         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6082         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6083         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6084         Update.
6085         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6086         Update.
6087         * mi/mi-interp.c (mi_interp::exec): Update.
6088         * linespec.c (parse_linespec): Update.
6089         * infcall.c (run_inferior_call): Update.
6090         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6091         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6092         (gdbscm_lookup_global_symbol): Update.
6093         * guile/scm-param.c (gdbscm_parameter_value): Update.
6094         * guile/scm-frame.c (gdbscm_frame_read_register)
6095         (gdbscm_frame_read_var): Update.
6096         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6097         * exec.c (try_open_exec_file): Update.
6098         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6099         (gdb_rl_callback_handler): Update.
6100         * common/common-exceptions.h (exception_none): Don't declare.
6101         * common/common-exceptions.c (exception_none): Don't define.
6102         (struct catcher) <exception>: Update.
6103         * cli/cli-interp.c (safe_execute_command): Update.
6104         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6105
6106 2019-04-25  Ali Tamur  <tamur@google.com>
6107
6108         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6109         (read_attribute_value): Likewise.
6110         (dwarf2_read_addr_index): Update comment.
6111         (read_str_index): Add DW_FORM_strx.
6112         (dwarf2_string_attr): Likewise.
6113         (dwarf2_const_value_attr): Likewise.
6114         (dump_die_shallow): Likewise.
6115         (dwarf2_fetch_constant_bytes): Likewise.
6116         (skip_form_bytes): Likewise.
6117         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6118
6119 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6120
6121         PR corefiles/11608
6122         PR corefiles/18187
6123         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6124         OFFSET.  Verify if current mapping contains an ELF header.
6125         (linux_find_memory_regions_full): Adjust call to
6126         dump_mapping_p.
6127
6128 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6129             Kang Li <kanglictf@gmail.com>
6130
6131         PR gdb/21600
6132
6133         * dwarf2-frame.c (read_initial_length): Be consistent about using
6134         unsigned representation of length.
6135         (decode_frame_entry_1): Likewise.  Check for wraparound of
6136         end pointer as well as buffer overflow.
6137
6138 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6139
6140         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6141         "vq".
6142
6143 2019-04-24  Tom Tromey  <tromey@adacore.com>
6144
6145         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6146
6147 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6148
6149         * s12z-tdep.c (s12z_unwind_pc): Delete.
6150         (s12z_unwind_sp): Delete.
6151         (s12z_gdbarch_init): Don't register deleted functions with
6152         gdbarch.
6153
6154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6155
6156         * rl78-tdep.c (rl78_unwind_sp): Delete.
6157         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6158
6159 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6160
6161         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6162         (xstormy16_unwind_pc): Delete.
6163         (xstormy16_dummy_id): Delete.
6164         (xstormy16_gdbarch_init): Don't register deleted functions with
6165         gdbarch.
6166
6167 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6168
6169         * vax-tdep.c (vax_unwind_pc): Delete.
6170         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6171
6172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * v850-tdep.c (v850_unwind_sp): Delete.
6175         (v850_unwind_pc): Delete.
6176         (v850_dummy_id): Delete.
6177         (v850_gdbarch_init): Don't register deleted functions with
6178         gdbarch.
6179
6180 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6181
6182         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6183         (tilegx_unwind_pc): Delete.
6184         (tilegx_unwind_dummy_id): Delete.
6185         (tilegx_gdbarch_init): Don't register deleted functions with
6186         gdbarch.
6187
6188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6189
6190         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6191         (tic6x_dummy_id): Delete.
6192         (tic6x_gdbarch_init): Don't register deleted functions with
6193         gdbarch.
6194
6195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6196
6197         * sparc-tdep.c (sparc_unwind_pc): Delete.
6198         (sparc32_gdbarch_init): Don't register deleted function with
6199         gdbarch.
6200
6201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * sh-tdep.c (sh_unwind_sp): Delete.
6204         (sh_unwind_pc): Delete.
6205         (sh_dummy_id): Delete.
6206         (sh_gdbarch_init): Don't register deleted functions with
6207         gdbarch.
6208
6209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6210
6211         * score-tdep.c (score_unwind_sp): Delete.
6212         (score_unwind_pc): Delete.
6213         (score_dummy_id): Delete.
6214         (score_gdbarch_init): Don't register deleted functions with
6215         gdbarch.
6216
6217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6218
6219         * rx-tdep.c (rx_unwind_pc): Delete.
6220         (rx_unwind_sp): Delete.
6221         (rx_dummy_id): Delete.
6222         (rx_gdbarch_init): Don't register deleted functions with
6223         gdbarch.  Update comment.
6224
6225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6226
6227         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6228         (rs6000_dummy_id): Delete.
6229         (rs6000_gdbarch_init): Don't register deleted functions with
6230         gdbarch.
6231
6232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * or1k-tdep.c (or1k_dummy_id): Delete.
6235         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6236
6237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6238
6239         * nios2-tdep.c (nios2_dummy_id): Delete.
6240         (nios2_unwind_sp): Delete.
6241         (nios2_gdbarch_init): Don't register deleted functions with
6242         gdbarch.
6243
6244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6245
6246         * nds32-tdep.c (nds32_dummy_id): Delete.
6247         (nds32_unwind_pc): Delete.
6248         (nds32_unwind_sp): Delete.
6249         (nds32_gdbarch_init): Don't register deleted functions with
6250         gdbarch.
6251
6252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6253
6254         * msp430-tdep.c (msp430_unwind_pc): Delete.
6255         (msp430_unwind_sp): Delete.
6256         (msp430_dummy_id): Delete.
6257         (msp430_gdbarch_init): Don't register deleted functions with
6258         gdbarch.
6259
6260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6261
6262         * moxie-tdep.c (moxie_unwind_sp): Delete.
6263         (moxie_unwind_pc): Delete.
6264         (moxie_dummy_id): Delete.
6265         (moxie_gdbarch_init): Don't register deleted functions with
6266         gdbarch.
6267
6268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6271         (mn10300_unwind_pc): Delete.
6272         (mn10300_unwind_sp): Delete.
6273         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6274         mn10300_unwind_sp.
6275         (mn10300_frame_unwind_init): Don't register deleted functions with
6276         gdbarch.
6277
6278 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6279
6280         * mep-tdep.c (mep_unwind_pc): Delete.
6281         (mep_unwind_sp): Delete.
6282         (mep_dummy_id): Delete.
6283         (mep_gdbarch_init): Don't register deleted functions with
6284         gdbarch.
6285
6286 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6287
6288         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6289         (m68hc11_unwind_sp): Delete.
6290         (m68hc11_gdbarch_init): Don't register deleted functions with
6291         gdbarch.
6292
6293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6294
6295         * m32r-tdep.c (m32r_unwind_sp): Delete.
6296         (m32r_unwind_pc): Delete.
6297         (m32r_dummy_id): Delete.
6298         (m32r_gdbarch_init): Don't register deleted functions with
6299         gdbarch.
6300
6301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6302
6303         * m32c-tdep.c (m32c_unwind_pc): Delete.
6304         (m32c_unwind_sp): Delete.
6305         (m32c_dummy_id): Delete.
6306         (m32c_gdbarch_init): Don't register deleted functions with
6307         gdbarch.
6308
6309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6312         (lm32_unwind_pc): Delete.
6313         (lm32_dummy_id): Delete.
6314         (lm32_gdbarch_init): Don't register deleted functions with
6315         gdbarch.
6316
6317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6320         (iq2000_unwind_pc): Delete.
6321         (iq2000_dummy_id): Delete.
6322         (iq2000_gdbarch_init): Don't register deleted functions with
6323         gdbarch.
6324
6325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6326
6327         * nds32-tdep.c (nds32_type_align): Delete.
6328         (nds32_push_dummy_call): Use type_align instead.
6329
6330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6331
6332         * arm-tdep.c (arm_type_align): Only handle vector override case.
6333         (arm_push_dummy_call): Use type_align.
6334         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6335
6336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6339         case.
6340         (pass_on_stack): Use type_align.
6341         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6342         function.
6343
6344 2019-04-23  Tom Tromey  <tromey@adacore.com>
6345
6346         * dwarf2read.c (line_header::file_name_at): Remove unused
6347         overload.
6348
6349 2019-04-23  Tom de Vries  <tdevries@suse.de>
6350
6351         PR gdb/24438
6352         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6353         invocation.
6354
6355
6356 2019-03-27  Ali Tamur  <tamur@google.com>
6357
6358         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6359         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6360         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6361         (dwarf_expr_context::get_addr_index): Likewise
6362         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6363         (symbol_needs_eval_context::get_addr_index): Likewise
6364         (disassemble_dwarf_expression): Add DW_OP_addrx
6365         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6366         (read_cutu_die_from_dwo): Update comment
6367         (skip_one_die): Add DW_FORM_addrx
6368         (read_attribute_value): Likewise
6369         (var_decode_location): Add DW_OP_addrx
6370         (dwarf2_const_value_attr): Add DW_FORM_addrx
6371         (dump_die_shallow): Likewise
6372         (dwarf2_fetch_constant_bytes): Likewise
6373         (decode_locdesc): Add DW_OP_addrx
6374         (skip_form_bytes): Add DW_FORM_addrx
6375
6376 2019-04-22  Ali Tamur  <tamur@google.com>
6377
6378         * MAINTAINERS (Write After Approval): Add self.
6379
6380 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6381
6382         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6383         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6384         (open_symbol_file_object): Likewise.
6385         (svr4_default_sos): Add info parameter.
6386         (svr4_read_so_list): Likewise.
6387         (svr4_current_sos_direct): Adjust functions calls to pass down
6388         info.
6389         (svr4_current_sos_1): Add info parameter.
6390         (svr4_current_sos): Call get_svr4_info, pass info down to
6391         svr4_current_sos_1.
6392         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6393         get_svr4_info.
6394         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6395         get_svr4_info.
6396         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6397         to get_svr4_info.
6398         (probes_table_remove_objfile_probes): Likewise.
6399         (register_solib_event_probe): Add info parameter.
6400         (solist_update_incremental): Pass info parameter down to
6401         svr4_read_so_list.
6402         (disable_probes_interface): Add info parameter.
6403         (svr4_handle_solib_event): Pass current_program_space to
6404         get_svr4_info.  Adjust disable_probes_interface cleanup.
6405         (svr4_create_probe_breakpoints): Add info parameter, pass it
6406         down to register_solib_event_probe.
6407         (svr4_create_solib_event_breakpoints): Add info parameter,
6408         pass it down to svr4_create_probe_breakpoints.
6409         (enable_break): Pass info down to
6410         svr4_create_solib_event_breakpoints.
6411         (svr4_solib_create_inferior_hook): Pass current_program_space to
6412         get_svr4_info.
6413         (svr4_clear_solib): Likewise.
6414
6415 2019-04-22  Pedro Alves  <palves@redhat.com>
6416
6417         * solib-svr4.c (svr4_free_objfile_observer): New.
6418         (probe_and_action::objfile): New field.
6419         (probes_table_htab_remove_objfile_probes)
6420         (probes_table_remove_objfile_probes): New functions.
6421         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6422         in the new probe_and_action.  Don't store the probe in 'lookup'.
6423         (svr4_create_probe_breakpoints): Pass objfile to
6424         register_solib_event_probe.
6425         (_initialize_svr4_solib): Register a free_objfile observer.
6426
6427 2019-04-19  Tom Tromey  <tom@tromey.com>
6428
6429         * common/queue.h: Remove.
6430
6431 2019-04-19  Tom Tromey  <tom@tromey.com>
6432
6433         * event-loop.c: Don't include "common/queue.h".
6434
6435 2019-04-19  Tom Tromey  <tom@tromey.com>
6436
6437         * remote.c (remote_target): Use delete.
6438         * remote-notif.h: Include <list>, not "common/queue.h".
6439         (notif_client_p): Remove typedef.
6440         (remote_notif_state): Add constructor, destructor, initializer.
6441         <notif_queue>: Now a std::list.
6442         (remote_notif_state_xfree): Don't declare.
6443         * remote-notif.c (remote_notif_process, handle_notification)
6444         (remote_notif_state_allocate): Update.
6445         (~remote_notif_state): Rename from remote_notif_state_xfree.
6446
6447 2019-04-19  Tom Tromey  <tom@tromey.com>
6448
6449         * symfile.c (reread_symbols): Update.
6450         * objfiles.c (objfile_register_static_link)
6451         (objfile_lookup_static_link): Update
6452         (~objfile) Don't delete static_links.
6453         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6454
6455 2019-04-19  Tom Tromey  <tom@tromey.com>
6456
6457         * type-stack.h (struct type_stack) <insert>: Constify string.
6458         * type-stack.c (type_stack::insert): Constify string.
6459         * gdbtypes.h (lookup_template_type): Update.
6460         (address_space_name_to_int): Update.
6461         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6462         const.
6463         (lookup_template_type): Make name const.
6464         * c-exp.y: Update rules.
6465         (lex_one_token, classify_name, classify_inner_name)
6466         (c_print_token): Update.
6467         * p-exp.y: Update rules.
6468         (yylex): Update.
6469         * f-exp.y: Update rules.
6470         (yylex): Update.
6471         * d-exp.y: Update rules.
6472         (lex_one_token, classify_name, classify_inner_name): Update.
6473         * parse.c (write_dollar_variable, copy_name): Return std::string.
6474         * parser-defs.h (copy_name): Change return type.
6475         * m2-exp.y: Update rules.
6476         (yylex): Update.
6477         * go-exp.y (lex_one_token): Update.
6478         Update rules.
6479         (classify_unsafe_function, classify_packaged_name)
6480         (classify_name, yylex): Update.
6481
6482 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6483
6484         * configure.ac: add --enable-source-highlight switch.
6485         * configure: Regenerate.
6486         * top.c (print_gdb_version): plumb --enable-source-highlight
6487         status to "show configuration".
6488
6489 2019-04-19  Tom Tromey  <tromey@adacore.com>
6490
6491         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6492         Check ADA_TYPE_P.
6493         (empty_record, ada_template_to_fixed_record_type_1)
6494         (template_to_static_fixed_type)
6495         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6496         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6497         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6498         macros.
6499
6500 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6501
6502         PR symtab/24423:
6503         * source.c (print_source_lines_base): Advance "iter" when a
6504         control character is seen.
6505
6506 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6507
6508         * inferior.h (struct infcall_suspend_state_deleter):
6509         Catch exception in destructor to avoid crash.
6510
6511 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6512
6513         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6514         close to the add_com "shell".
6515
6516 2019-04-18  Tom Tromey  <tromey@adacore.com>
6517
6518         * process-stratum-target.h (class process_stratum_target)
6519         <stratum>: Add "final".
6520
6521 2019-04-17  Tom Tromey  <tromey@adacore.com>
6522
6523         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6524         against nullptr before use.
6525
6526 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6527
6528         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6529
6530 2019-04-17  Jim Wilson  <jimw@sifive.com>
6531             Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6534         code read might fail, assume 4-byte breakpoint in that case.
6535
6536 2019-04-15  Leszek Swirski  <leszeks@google.com>
6537
6538         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6539         rather than a hand-rolled POD check when checking for forced MEMORY
6540         classification.
6541
6542 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6543
6544         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6545         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6546         function.
6547         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6548         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6549         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6550         declaration.
6551
6552 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6553
6554         * aarch64-linux-nat.c
6555         (aarch64_linux_nat_target::thread_architecture): Add override.
6556         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6557         each VQ.
6558
6559 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6560
6561         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6562
6563 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6564
6565         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6566         target types of size 96-bits, add some additional comments, and
6567         check that the builtin type we found was the correct size.
6568
6569 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6570
6571         * utils.c (prompt_for_continue): Don't restore the styling at the
6572         end, as applied_style has the wrong value.  This fixes styling in
6573         long lists of file names that are interrupted by the "Continue?"
6574         prompt.
6575
6576 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6577
6578         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6579         * c-lang.c (c_language_defn): Likewise.
6580         (cplus_language_defn): Likewise.
6581         (asm_language_defn): Likewise.
6582         (minimal_language_defn): Likewise.
6583         * d-lang.c (d_language_defn): Likewise.
6584         * f-lang.c (f_language_defn): Likewise.
6585         * go-lang.c (go_language_defn): Likewise.
6586         * language.c (unknown_language_defn): Likewise.
6587         (auto_language_defn): Likewise.
6588         * language.h (struct language_defn): Remove la_magic field.
6589         (LANG_MAGIC): Delete.
6590         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6591         * objc-lang.c (objc_language_defn): Likewise.
6592         * opencl-lang.c (opencl_language_defn): Likewise.
6593         * p-lang.c (pascal_language_defn): Likewise.
6594         * rust-lang.c (rust_language_defn): Likewise.
6595
6596 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6597
6598         * riscv-tdep.c (riscv_type_align): New function.
6599         (riscv_type_alignment): Delete.
6600         (riscv_arg_location): Use 'type_align'.
6601         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6602
6603 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6604
6605         * gdbtypes.c (type_align): A struct with no non-static fields also
6606         has alignment of 1.
6607
6608 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6609
6610         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6611         component to 0.
6612         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6613         member.
6614         (riscv_struct_info::analyse): New implementation using new
6615         analyse_inner member function.
6616         (riscv_struct_info::field_offset): New member function.
6617         (riscv_struct_info::m_offsets): New member variable.
6618         (riscv_struct_info::analyse_inner): New private member function,
6619         takes the old implementation of riscv_struct_info::analyse but
6620         extended to track field offsets.
6621         (riscv_call_arg_struct): Update the struct folding special cases
6622         to handle cases where empty C++ structs, which are non-zero
6623         length, are found.
6624         (riscv_arg_location): Initialise the length of each location, a
6625         non-zero length now indicates the location is in use.
6626         (riscv_push_dummy_call): Allow for the first location having a
6627         non-zero offset when setting up arguments.
6628         (riscv_return_value): Likewise, but for return values.
6629
6630 2019-04-11  Tom Tromey  <tromey@adacore.com>
6631
6632         * utils.c (internal_vproblem): Make "msg" const.
6633
6634 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6635
6636         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6637         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6638         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6639         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6640
6641 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6642
6643         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6644         function.
6645         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6646         of amd64_collect_native_gregset.
6647         (amd64_linux_nat_target::store_registers): Likewise.
6648
6649 2019-04-10  Tom Tromey  <tom@tromey.com>
6650
6651         * symtab.c (lookup_global_symbol_from_objfile)
6652         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6653         * objfiles.h (class separate_debug_iterator): New.
6654         (class separate_debug_range): New.
6655         (struct objfile) <separate_debug_objfiles>: New method.
6656         (objfile_separate_debug_iterate): Don't declare.
6657         * objfiles.c (separate_debug_iterator::operator++): Rename from
6658         objfile_separate_debug_iterate.
6659         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6660         iterator.
6661         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6662         iterator.
6663
6664 2019-04-10  Tom Tromey  <tom@tromey.com>
6665
6666         * symfile.c (reread_symbols): Remove old comment.
6667         * objfiles.c (free_all_objfiles): Fix a typo.
6668
6669 2019-04-10  Tom Tromey  <tom@tromey.com>
6670
6671         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6672         * minsyms.c (lookup_minimal_symbol): Use foreach.
6673         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6674         (lookup_minimal_symbol_solib_trampoline): Likewise.
6675         * symfile.c (reread_symbols): Use foreach.
6676
6677 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6678             Tom Tromey  <tromey@adacore.com>
6679
6680         PR rust/24414:
6681         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6682         (rust_lex_int_test): Change "value" to be LONGEST.
6683         (rust_lex_tests): Add test for long integer literal.
6684
6685 2019-04-09  Tom Tromey  <tromey@adacore.com>
6686
6687         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6688         to bool.
6689         (extended_remote_target::attach): Update.
6690         (remote_target::remote_notice_new_inferior): Update.
6691         (remote_target::add_current_inferior_and_thread): Update.
6692         * inferior.c (exit_inferior_1): Use "false".
6693         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6694
6695 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6696
6697         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6698         the "start" command.
6699
6700 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6701
6702         * python/py-inferior.c (infpy_thread_from_thread_handle):
6703         Adjust comments to reflect renaming of thread_from_thread_handle
6704         to thread_from_handle.  Adjust keywords.  Fix type error message.
6705         (inferior_object_methods): Add thread_from_handle.  Retain
6706         thread_from_thread_handle, but mark it as deprecated.
6707
6708 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6709
6710         * gdbthread.h (find_thread_by_handle): Revise declaration.
6711         * thread.c (find_thread_by_handle): Likewise.  Adjust
6712         implementation too.
6713         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6714         support for buffer objects as handles.
6715
6716 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6717
6718         * python/py-infthread.c (thpy_thread_handle): New function.
6719         (thread_object_methods): Register thpy_thread_handle.
6720
6721 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6722
6723         * gdbthread.h (thread_to_thread_handle): Declare.
6724         * thread.c (gdbtypes.h): Include.
6725         (thread_to_thread_handle): New function.
6726
6727         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6728         (target_thread_info_to_thread_handle): Declare.
6729         * target.c (target_thread_info_to_thread_handle): New function.
6730         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6731         * target-delegates.c: Regenerate.
6732
6733         * linux-thread-db.c (class thread_db_target): Add method
6734         thread_info_to_thread_handle.
6735         (thread_db_target::thread_info_to_thread_handle): Define.
6736         * remote.c (class remote_target): Add new method
6737         thread_info_to_thread_handle.
6738         (remote_target::thread_info_to_thread_handle): Define.
6739
6740 2019-04-08  Pedro Alves  <palves@redhat.com>
6741
6742         * common/common-exceptions.c (throw_exception): Don't create
6743         named object to throw; throw directly.
6744         (throw_it): Likewise.  Don't initialize gdb_exception::message
6745         here, with new; pass FMT and AP to the ctor instead.
6746         * common/common-exceptions.h: Include <string>.
6747         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6748         const char *, va_list)): New ctor.  Use std::make_shared.
6749         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6750         errors)): Delete.
6751         (gdb_exception_error::gdb_exception_error(enum errors, const char
6752         *, va_list)): New.
6753         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6754         Add assertion.
6755         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6756         errors)): Delete.
6757         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6758         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6759         Add assertion.
6760
6761 2019-04-08  Tom Tromey  <tom@tromey.com>
6762
6763         * valops.c (value_rtti_indirect_type): Replace throw_exception
6764         with throw.
6765         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6766         with throw.
6767         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6768         throw.
6769         * target.c (target_translate_tls_address): Replace throw_exception
6770         with throw.
6771         * stack.c (frame_apply_command_count): Replace throw_exception
6772         with throw.
6773         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6774         throw.
6775         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6776         with throw.
6777         * rs6000-tdep.c (rs6000_frame_cache)
6778         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6779         * remote.c: Replace throw_exception with throw.
6780         * record-full.c (record_full_message, record_full_wait_1)
6781         (record_full_restore): Replace throw_exception with throw.
6782         * record-btrace.c:
6783         (get_thread_current_frame_id, record_btrace_start_replaying)
6784         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6785         (cmd_record_btrace_start): Replace throw_exception with throw.
6786         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6787         throw.
6788         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6789         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6790         * linespec.c:
6791         (find_linespec_symbols): Replace throw_exception with throw.
6792         * infrun.c (displaced_step_prepare, resume): Replace
6793         throw_exception with throw.
6794         * infcmd.c (post_create_inferior): Replace throw_exception with
6795         throw.
6796         * inf-loop.c (inferior_event_handler): Replace throw_exception
6797         with throw.
6798         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6799         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6800         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6801         (get_prev_frame_always, get_frame_pc_if_available)
6802         (get_frame_address_in_block_if_available, get_frame_language):
6803         Replace throw_exception with throw.
6804         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6805         throw_exception with throw.
6806         * eval.c (fetch_subexp_value, evaluate_var_value)
6807         (evaluate_funcall, evaluate_subexp_standard): Replace
6808         throw_exception with throw.
6809         * dwarf2loc.c (call_site_find_chain)
6810         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6811         Replace throw_exception with throw.
6812         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6813         with throw.
6814         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6815         throw.
6816         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6817         * completer.c (complete_line_internal): Replace throw_exception
6818         with throw.
6819         * compile/compile-object-run.c (compile_object_run): Replace
6820         throw_exception with throw.
6821         * cli/cli-script.c (process_next_line): Replace throw_exception
6822         with throw.
6823         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6824         (btrace_enable, btrace_maint_update_pt_packets): Replace
6825         throw_exception with throw.
6826         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6827         throw_exception with throw.
6828         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6829         throw_exception with throw.
6830         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6831         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6832         * aarch64-tdep.c (aarch64_make_prologue_cache)
6833         (aarch64_make_stub_cache): Replace throw_exception with throw.
6834
6835 2019-04-08  Tom Tromey  <tom@tromey.com>
6836
6837         * common/common-exceptions.c (throw_exception): Rename from
6838         throw_exception_cxx.  Remove old copy.  Make argument const.
6839         (throw_it): Create and throw exception objects directly.
6840         * common/common-exceptions.h (throw_exception): Make argument
6841         const.
6842         (struct gdb_exception_error): Add constructor.
6843         (struct gdb_exception_quit): Add constructor.
6844
6845 2019-04-08  Tom Tromey  <tom@tromey.com>
6846
6847         * common/common-exceptions.h (exception_rethrow): Don't declare.
6848         (TRY_SJLJ): Update comment.
6849         (TRY, CATCH, END_CATCH): Remove.
6850         * common/common-exceptions.c (exception_rethrow): Remove.
6851
6852 2019-04-08  Tom Tromey  <tom@tromey.com>
6853
6854         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6855         Remove.
6856         (gdb_exception_error): Rename from
6857         gdb_exception_RETURN_MASK_ERROR.
6858         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6859         (gdb_quit_bad_alloc): Update.
6860         * aarch64-tdep.c: Update.
6861         * ada-lang.c: Update.
6862         * ada-typeprint.c: Update.
6863         * ada-valprint.c: Update.
6864         * amd64-tdep.c: Update.
6865         * arch-utils.c: Update.
6866         * break-catch-throw.c: Update.
6867         * breakpoint.c: Update.
6868         * btrace.c: Update.
6869         * c-varobj.c: Update.
6870         * cli/cli-cmds.c: Update.
6871         * cli/cli-interp.c: Update.
6872         * cli/cli-script.c: Update.
6873         * common/common-exceptions.c: Update.
6874         * common/new-op.c: Update.
6875         * common/selftest.c: Update.
6876         * compile/compile-c-symbols.c: Update.
6877         * compile/compile-cplus-symbols.c: Update.
6878         * compile/compile-object-load.c: Update.
6879         * compile/compile-object-run.c: Update.
6880         * completer.c: Update.
6881         * corelow.c: Update.
6882         * cp-abi.c: Update.
6883         * cp-support.c: Update.
6884         * cp-valprint.c: Update.
6885         * darwin-nat.c: Update.
6886         * disasm-selftests.c: Update.
6887         * dtrace-probe.c: Update.
6888         * dwarf-index-cache.c: Update.
6889         * dwarf-index-write.c: Update.
6890         * dwarf2-frame-tailcall.c: Update.
6891         * dwarf2-frame.c: Update.
6892         * dwarf2loc.c: Update.
6893         * dwarf2read.c: Update.
6894         * eval.c: Update.
6895         * event-loop.c: Update.
6896         * event-top.c: Update.
6897         * exec.c: Update.
6898         * f-valprint.c: Update.
6899         * fbsd-tdep.c: Update.
6900         * frame-unwind.c: Update.
6901         * frame.c: Update.
6902         * gdbtypes.c: Update.
6903         * gnu-v3-abi.c: Update.
6904         * guile/guile-internal.h: Update.
6905         * guile/scm-block.c: Update.
6906         * guile/scm-breakpoint.c: Update.
6907         * guile/scm-cmd.c: Update.
6908         * guile/scm-disasm.c: Update.
6909         * guile/scm-frame.c: Update.
6910         * guile/scm-lazy-string.c: Update.
6911         * guile/scm-math.c: Update.
6912         * guile/scm-param.c: Update.
6913         * guile/scm-ports.c: Update.
6914         * guile/scm-pretty-print.c: Update.
6915         * guile/scm-symbol.c: Update.
6916         * guile/scm-symtab.c: Update.
6917         * guile/scm-type.c: Update.
6918         * guile/scm-value.c: Update.
6919         * i386-linux-tdep.c: Update.
6920         * i386-tdep.c: Update.
6921         * inf-loop.c: Update.
6922         * infcall.c: Update.
6923         * infcmd.c: Update.
6924         * infrun.c: Update.
6925         * jit.c: Update.
6926         * language.c: Update.
6927         * linespec.c: Update.
6928         * linux-fork.c: Update.
6929         * linux-nat.c: Update.
6930         * linux-tdep.c: Update.
6931         * linux-thread-db.c: Update.
6932         * main.c: Update.
6933         * mi/mi-cmd-break.c: Update.
6934         * mi/mi-cmd-stack.c: Update.
6935         * mi/mi-interp.c: Update.
6936         * mi/mi-main.c: Update.
6937         * objc-lang.c: Update.
6938         * p-valprint.c: Update.
6939         * parse.c: Update.
6940         * ppc-linux-tdep.c: Update.
6941         * printcmd.c: Update.
6942         * python/py-arch.c: Update.
6943         * python/py-breakpoint.c: Update.
6944         * python/py-cmd.c: Update.
6945         * python/py-finishbreakpoint.c: Update.
6946         * python/py-frame.c: Update.
6947         * python/py-framefilter.c: Update.
6948         * python/py-gdb-readline.c: Update.
6949         * python/py-inferior.c: Update.
6950         * python/py-infthread.c: Update.
6951         * python/py-lazy-string.c: Update.
6952         * python/py-linetable.c: Update.
6953         * python/py-objfile.c: Update.
6954         * python/py-param.c: Update.
6955         * python/py-prettyprint.c: Update.
6956         * python/py-progspace.c: Update.
6957         * python/py-record-btrace.c: Update.
6958         * python/py-record.c: Update.
6959         * python/py-symbol.c: Update.
6960         * python/py-type.c: Update.
6961         * python/py-unwind.c: Update.
6962         * python/py-utils.c: Update.
6963         * python/py-value.c: Update.
6964         * python/python.c: Update.
6965         * record-btrace.c: Update.
6966         * record-full.c: Update.
6967         * remote-fileio.c: Update.
6968         * remote.c: Update.
6969         * riscv-tdep.c: Update.
6970         * rs6000-aix-tdep.c: Update.
6971         * rs6000-tdep.c: Update.
6972         * rust-exp.y: Update.
6973         * rust-lang.c: Update.
6974         * s390-tdep.c: Update.
6975         * selftest-arch.c: Update.
6976         * solib-dsbt.c: Update.
6977         * solib-frv.c: Update.
6978         * solib-spu.c: Update.
6979         * solib-svr4.c: Update.
6980         * solib.c: Update.
6981         * sparc64-linux-tdep.c: Update.
6982         * stack.c: Update.
6983         * symfile-mem.c: Update.
6984         * symmisc.c: Update.
6985         * target.c: Update.
6986         * thread.c: Update.
6987         * top.c: Update.
6988         * tracefile-tfile.c: Update.
6989         * tui/tui.c: Update.
6990         * typeprint.c: Update.
6991         * unittests/cli-utils-selftests.c: Update.
6992         * unittests/parse-connection-spec-selftests.c: Update.
6993         * valops.c: Update.
6994         * valprint.c: Update.
6995         * value.c: Update.
6996         * varobj.c: Update.
6997         * windows-nat.c: Update.
6998         * x86-linux-nat.c: Update.
6999         * xml-support.c: Update.
7000
7001 2019-04-08  Tom Tromey  <tom@tromey.com>
7002
7003         * xml-support.c: Use C++ exception handling.
7004         * x86-linux-nat.c: Use C++ exception handling.
7005         * windows-nat.c: Use C++ exception handling.
7006         * varobj.c: Use C++ exception handling.
7007         * value.c: Use C++ exception handling.
7008         * valprint.c: Use C++ exception handling.
7009         * valops.c: Use C++ exception handling.
7010         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7011         handling.
7012         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7013         * typeprint.c: Use C++ exception handling.
7014         * tui/tui.c: Use C++ exception handling.
7015         * tracefile-tfile.c: Use C++ exception handling.
7016         * top.c: Use C++ exception handling.
7017         * thread.c: Use C++ exception handling.
7018         * target.c: Use C++ exception handling.
7019         * symmisc.c: Use C++ exception handling.
7020         * symfile-mem.c: Use C++ exception handling.
7021         * stack.c: Use C++ exception handling.
7022         * sparc64-linux-tdep.c: Use C++ exception handling.
7023         * solib.c: Use C++ exception handling.
7024         * solib-svr4.c: Use C++ exception handling.
7025         * solib-spu.c: Use C++ exception handling.
7026         * solib-frv.c: Use C++ exception handling.
7027         * solib-dsbt.c: Use C++ exception handling.
7028         * selftest-arch.c: Use C++ exception handling.
7029         * s390-tdep.c: Use C++ exception handling.
7030         * rust-lang.c: Use C++ exception handling.
7031         * rust-exp.y: Use C++ exception handling.
7032         * rs6000-tdep.c: Use C++ exception handling.
7033         * rs6000-aix-tdep.c: Use C++ exception handling.
7034         * riscv-tdep.c: Use C++ exception handling.
7035         * remote.c: Use C++ exception handling.
7036         * remote-fileio.c: Use C++ exception handling.
7037         * record-full.c: Use C++ exception handling.
7038         * record-btrace.c: Use C++ exception handling.
7039         * python/python.c: Use C++ exception handling.
7040         * python/py-value.c: Use C++ exception handling.
7041         * python/py-utils.c: Use C++ exception handling.
7042         * python/py-unwind.c: Use C++ exception handling.
7043         * python/py-type.c: Use C++ exception handling.
7044         * python/py-symbol.c: Use C++ exception handling.
7045         * python/py-record.c: Use C++ exception handling.
7046         * python/py-record-btrace.c: Use C++ exception handling.
7047         * python/py-progspace.c: Use C++ exception handling.
7048         * python/py-prettyprint.c: Use C++ exception handling.
7049         * python/py-param.c: Use C++ exception handling.
7050         * python/py-objfile.c: Use C++ exception handling.
7051         * python/py-linetable.c: Use C++ exception handling.
7052         * python/py-lazy-string.c: Use C++ exception handling.
7053         * python/py-infthread.c: Use C++ exception handling.
7054         * python/py-inferior.c: Use C++ exception handling.
7055         * python/py-gdb-readline.c: Use C++ exception handling.
7056         * python/py-framefilter.c: Use C++ exception handling.
7057         * python/py-frame.c: Use C++ exception handling.
7058         * python/py-finishbreakpoint.c: Use C++ exception handling.
7059         * python/py-cmd.c: Use C++ exception handling.
7060         * python/py-breakpoint.c: Use C++ exception handling.
7061         * python/py-arch.c: Use C++ exception handling.
7062         * printcmd.c: Use C++ exception handling.
7063         * ppc-linux-tdep.c: Use C++ exception handling.
7064         * parse.c: Use C++ exception handling.
7065         * p-valprint.c: Use C++ exception handling.
7066         * objc-lang.c: Use C++ exception handling.
7067         * mi/mi-main.c: Use C++ exception handling.
7068         * mi/mi-interp.c: Use C++ exception handling.
7069         * mi/mi-cmd-stack.c: Use C++ exception handling.
7070         * mi/mi-cmd-break.c: Use C++ exception handling.
7071         * main.c: Use C++ exception handling.
7072         * linux-thread-db.c: Use C++ exception handling.
7073         * linux-tdep.c: Use C++ exception handling.
7074         * linux-nat.c: Use C++ exception handling.
7075         * linux-fork.c: Use C++ exception handling.
7076         * linespec.c: Use C++ exception handling.
7077         * language.c: Use C++ exception handling.
7078         * jit.c: Use C++ exception handling.
7079         * infrun.c: Use C++ exception handling.
7080         * infcmd.c: Use C++ exception handling.
7081         * infcall.c: Use C++ exception handling.
7082         * inf-loop.c: Use C++ exception handling.
7083         * i386-tdep.c: Use C++ exception handling.
7084         * i386-linux-tdep.c: Use C++ exception handling.
7085         * guile/scm-value.c: Use C++ exception handling.
7086         * guile/scm-type.c: Use C++ exception handling.
7087         * guile/scm-symtab.c: Use C++ exception handling.
7088         * guile/scm-symbol.c: Use C++ exception handling.
7089         * guile/scm-pretty-print.c: Use C++ exception handling.
7090         * guile/scm-ports.c: Use C++ exception handling.
7091         * guile/scm-param.c: Use C++ exception handling.
7092         * guile/scm-math.c: Use C++ exception handling.
7093         * guile/scm-lazy-string.c: Use C++ exception handling.
7094         * guile/scm-frame.c: Use C++ exception handling.
7095         * guile/scm-disasm.c: Use C++ exception handling.
7096         * guile/scm-cmd.c: Use C++ exception handling.
7097         * guile/scm-breakpoint.c: Use C++ exception handling.
7098         * guile/scm-block.c: Use C++ exception handling.
7099         * guile/guile-internal.h: Use C++ exception handling.
7100         * gnu-v3-abi.c: Use C++ exception handling.
7101         * gdbtypes.c: Use C++ exception handling.
7102         * frame.c: Use C++ exception handling.
7103         * frame-unwind.c: Use C++ exception handling.
7104         * fbsd-tdep.c: Use C++ exception handling.
7105         * f-valprint.c: Use C++ exception handling.
7106         * exec.c: Use C++ exception handling.
7107         * event-top.c: Use C++ exception handling.
7108         * event-loop.c: Use C++ exception handling.
7109         * eval.c: Use C++ exception handling.
7110         * dwarf2read.c: Use C++ exception handling.
7111         * dwarf2loc.c: Use C++ exception handling.
7112         * dwarf2-frame.c: Use C++ exception handling.
7113         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7114         * dwarf-index-write.c: Use C++ exception handling.
7115         * dwarf-index-cache.c: Use C++ exception handling.
7116         * dtrace-probe.c: Use C++ exception handling.
7117         * disasm-selftests.c: Use C++ exception handling.
7118         * darwin-nat.c: Use C++ exception handling.
7119         * cp-valprint.c: Use C++ exception handling.
7120         * cp-support.c: Use C++ exception handling.
7121         * cp-abi.c: Use C++ exception handling.
7122         * corelow.c: Use C++ exception handling.
7123         * completer.c: Use C++ exception handling.
7124         * compile/compile-object-run.c: Use C++ exception handling.
7125         * compile/compile-object-load.c: Use C++ exception handling.
7126         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7127         * compile/compile-c-symbols.c: Use C++ exception handling.
7128         * common/selftest.c: Use C++ exception handling.
7129         * common/new-op.c: Use C++ exception handling.
7130         * cli/cli-script.c: Use C++ exception handling.
7131         * cli/cli-interp.c: Use C++ exception handling.
7132         * cli/cli-cmds.c: Use C++ exception handling.
7133         * c-varobj.c: Use C++ exception handling.
7134         * btrace.c: Use C++ exception handling.
7135         * breakpoint.c: Use C++ exception handling.
7136         * break-catch-throw.c: Use C++ exception handling.
7137         * arch-utils.c: Use C++ exception handling.
7138         * amd64-tdep.c: Use C++ exception handling.
7139         * ada-valprint.c: Use C++ exception handling.
7140         * ada-typeprint.c: Use C++ exception handling.
7141         * ada-lang.c: Use C++ exception handling.
7142         * aarch64-tdep.c: Use C++ exception handling.
7143
7144 2019-04-08  Tom Tromey  <tom@tromey.com>
7145
7146         * xml-support.c (gdb_xml_parser::parse): Update.
7147         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7148         * value.c (show_convenience): Update.
7149         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7150         (test_parse_flags_qcs): Update.
7151         * thread.c (thr_try_catch_cmd): Update.
7152         * target.c (target_translate_tls_address): Update.
7153         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7154         (info_frame_command_core, frame_apply_command_count): Update.
7155         * rust-exp.y (rust_lex_exception_test): Update.
7156         * riscv-tdep.c (riscv_print_one_register_info): Update.
7157         * remote.c (remote_target::enable_btrace): Update.
7158         * record-btrace.c (record_btrace_enable_warn): Update.
7159         * python/py-utils.c (gdbpy_convert_exception): Update.
7160         * printcmd.c (do_one_display, print_variable_and_value): Update.
7161         * mi/mi-main.c (mi_print_exception): Update.
7162         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7163         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7164         * linux-nat.c (linux_nat_target::attach): Update.
7165         * linux-fork.c (class scoped_switch_fork_info): Update.
7166         * infrun.c (displaced_step_prepare): Update.
7167         * infcall.c (call_function_by_hand_dummy): Update.
7168         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7169         * gnu-v3-abi.c (print_one_vtable): Update.
7170         * frame.c (get_prev_frame_always): Update.
7171         * f-valprint.c (info_common_command_for_block): Update.
7172         * exec.c (try_open_exec_file): Update.
7173         * exceptions.c (print_exception, exception_print)
7174         (exception_fprintf, exception_print_same): Update.
7175         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7176         * dwarf-index-cache.c (index_cache::store)
7177         (index_cache::lookup_gdb_index): Update.
7178         * darwin-nat.c (maybe_cache_shell): Update.
7179         * cp-valprint.c (cp_print_value_fields): Update.
7180         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7181         (gcc_cplus_symbol_address): Update.
7182         * compile/compile-c-symbols.c (gcc_convert_symbol)
7183         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7184         * common/selftest.c: Update.
7185         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7186         a std::string.
7187         (exception_try_scope_entry, exception_try_scope_exit): Don't
7188         declare.
7189         (struct exception_try_scope): Remove.
7190         (TRY): Don't use exception_try_scope.
7191         (struct gdb_exception): Add constructor, operator=.
7192         <what>: New method.
7193         (struct gdb_exception_RETURN_MASK_ALL)
7194         (struct gdb_exception_RETURN_MASK_ERROR)
7195         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7196         (struct gdb_quit_bad_alloc): Update.
7197         * common/common-exceptions.c (exception_none): Change
7198         initializer.
7199         (struct catcher) <state, exception>: Initialize inline.
7200         <prev>: Remove member.
7201         (current_catcher): Remove.
7202         (catchers): New global.
7203         (exceptions_state_mc_init): Simplify.
7204         (catcher_pop): Remove.
7205         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7206         (try_scope_depth, exception_try_scope_entry)
7207         (exception_try_scope_exit): Remove.
7208         (throw_exception_sjlj): Update.
7209         (exception_messages, exception_messages_size): Remove.
7210         (throw_it): Simplify.
7211         (gdb_exception_sliced_copy): Remove.
7212         (throw_exception_cxx): Update.
7213         * cli/cli-script.c (script_from_file): Update.
7214         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7215         Update.
7216         * ada-valprint.c (ada_val_print): Update.
7217         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7218         (create_excep_cond_exprs): Update.
7219
7220 2019-04-08  Tom Tromey  <tom@tromey.com>
7221
7222         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7223         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7224         (TRY, CATCH, END_CATCH): Remove some definitions.
7225         * common/common-exceptions.c: Don't use GDB_XCPT.
7226         (catcher_list_size): Remove.
7227         (throw_exception, throw_it): Simplify.
7228
7229 2019-04-05  Tom Tromey  <tom@tromey.com>
7230
7231         Revert the header-sorting patch.
7232         * ft32-tdep.c: Revert.
7233         * frv-tdep.c: Revert.
7234         * frv-linux-tdep.c: Revert.
7235         * frame.c: Revert.
7236         * frame-unwind.c: Revert.
7237         * frame-base.c: Revert.
7238         * fork-child.c: Revert.
7239         * findvar.c: Revert.
7240         * findcmd.c: Revert.
7241         * filesystem.c: Revert.
7242         * filename-seen-cache.h: Revert.
7243         * filename-seen-cache.c: Revert.
7244         * fbsd-tdep.c: Revert.
7245         * fbsd-nat.h: Revert.
7246         * fbsd-nat.c: Revert.
7247         * f-valprint.c: Revert.
7248         * f-typeprint.c: Revert.
7249         * f-lang.c: Revert.
7250         * extension.h: Revert.
7251         * extension.c: Revert.
7252         * extension-priv.h: Revert.
7253         * expprint.c: Revert.
7254         * exec.h: Revert.
7255         * exec.c: Revert.
7256         * exceptions.c: Revert.
7257         * event-top.c: Revert.
7258         * event-loop.c: Revert.
7259         * eval.c: Revert.
7260         * elfread.c: Revert.
7261         * dwarf2read.h: Revert.
7262         * dwarf2read.c: Revert.
7263         * dwarf2loc.c: Revert.
7264         * dwarf2expr.h: Revert.
7265         * dwarf2expr.c: Revert.
7266         * dwarf2-frame.c: Revert.
7267         * dwarf2-frame-tailcall.c: Revert.
7268         * dwarf-index-write.h: Revert.
7269         * dwarf-index-write.c: Revert.
7270         * dwarf-index-common.c: Revert.
7271         * dwarf-index-cache.h: Revert.
7272         * dwarf-index-cache.c: Revert.
7273         * dummy-frame.c: Revert.
7274         * dtrace-probe.c: Revert.
7275         * disasm.h: Revert.
7276         * disasm.c: Revert.
7277         * disasm-selftests.c: Revert.
7278         * dictionary.c: Revert.
7279         * dicos-tdep.c: Revert.
7280         * demangle.c: Revert.
7281         * dcache.h: Revert.
7282         * dcache.c: Revert.
7283         * darwin-nat.h: Revert.
7284         * darwin-nat.c: Revert.
7285         * darwin-nat-info.c: Revert.
7286         * d-valprint.c: Revert.
7287         * d-namespace.c: Revert.
7288         * d-lang.c: Revert.
7289         * ctf.c: Revert.
7290         * csky-tdep.c: Revert.
7291         * csky-linux-tdep.c: Revert.
7292         * cris-tdep.c: Revert.
7293         * cris-linux-tdep.c: Revert.
7294         * cp-valprint.c: Revert.
7295         * cp-support.c: Revert.
7296         * cp-namespace.c: Revert.
7297         * cp-abi.c: Revert.
7298         * corelow.c: Revert.
7299         * corefile.c: Revert.
7300         * continuations.c: Revert.
7301         * completer.h: Revert.
7302         * completer.c: Revert.
7303         * complaints.c: Revert.
7304         * coffread.c: Revert.
7305         * coff-pe-read.c: Revert.
7306         * cli-out.h: Revert.
7307         * cli-out.c: Revert.
7308         * charset.c: Revert.
7309         * c-varobj.c: Revert.
7310         * c-valprint.c: Revert.
7311         * c-typeprint.c: Revert.
7312         * c-lang.c: Revert.
7313         * buildsym.c: Revert.
7314         * buildsym-legacy.c: Revert.
7315         * build-id.h: Revert.
7316         * build-id.c: Revert.
7317         * btrace.c: Revert.
7318         * bsd-uthread.c: Revert.
7319         * breakpoint.h: Revert.
7320         * breakpoint.c: Revert.
7321         * break-catch-throw.c: Revert.
7322         * break-catch-syscall.c: Revert.
7323         * break-catch-sig.c: Revert.
7324         * blockframe.c: Revert.
7325         * block.c: Revert.
7326         * bfin-tdep.c: Revert.
7327         * bfin-linux-tdep.c: Revert.
7328         * bfd-target.c: Revert.
7329         * bcache.c: Revert.
7330         * ax-general.c: Revert.
7331         * ax-gdb.h: Revert.
7332         * ax-gdb.c: Revert.
7333         * avr-tdep.c: Revert.
7334         * auxv.c: Revert.
7335         * auto-load.c: Revert.
7336         * arm-wince-tdep.c: Revert.
7337         * arm-tdep.c: Revert.
7338         * arm-symbian-tdep.c: Revert.
7339         * arm-pikeos-tdep.c: Revert.
7340         * arm-obsd-tdep.c: Revert.
7341         * arm-nbsd-tdep.c: Revert.
7342         * arm-nbsd-nat.c: Revert.
7343         * arm-linux-tdep.c: Revert.
7344         * arm-linux-nat.c: Revert.
7345         * arm-fbsd-tdep.c: Revert.
7346         * arm-fbsd-nat.c: Revert.
7347         * arm-bsd-tdep.c: Revert.
7348         * arch-utils.c: Revert.
7349         * arc-tdep.c: Revert.
7350         * arc-newlib-tdep.c: Revert.
7351         * annotate.h: Revert.
7352         * annotate.c: Revert.
7353         * amd64-windows-tdep.c: Revert.
7354         * amd64-windows-nat.c: Revert.
7355         * amd64-tdep.c: Revert.
7356         * amd64-sol2-tdep.c: Revert.
7357         * amd64-obsd-tdep.c: Revert.
7358         * amd64-obsd-nat.c: Revert.
7359         * amd64-nbsd-tdep.c: Revert.
7360         * amd64-nbsd-nat.c: Revert.
7361         * amd64-nat.c: Revert.
7362         * amd64-linux-tdep.c: Revert.
7363         * amd64-linux-nat.c: Revert.
7364         * amd64-fbsd-tdep.c: Revert.
7365         * amd64-fbsd-nat.c: Revert.
7366         * amd64-dicos-tdep.c: Revert.
7367         * amd64-darwin-tdep.c: Revert.
7368         * amd64-bsd-nat.c: Revert.
7369         * alpha-tdep.c: Revert.
7370         * alpha-obsd-tdep.c: Revert.
7371         * alpha-nbsd-tdep.c: Revert.
7372         * alpha-mdebug-tdep.c: Revert.
7373         * alpha-linux-tdep.c: Revert.
7374         * alpha-linux-nat.c: Revert.
7375         * alpha-bsd-tdep.c: Revert.
7376         * alpha-bsd-nat.c: Revert.
7377         * aix-thread.c: Revert.
7378         * agent.c: Revert.
7379         * addrmap.c: Revert.
7380         * ada-varobj.c: Revert.
7381         * ada-valprint.c: Revert.
7382         * ada-typeprint.c: Revert.
7383         * ada-tasks.c: Revert.
7384         * ada-lang.c: Revert.
7385         * aarch64-tdep.c: Revert.
7386         * aarch64-ravenscar-thread.c: Revert.
7387         * aarch64-newlib-tdep.c: Revert.
7388         * aarch64-linux-tdep.c: Revert.
7389         * aarch64-linux-nat.c: Revert.
7390         * aarch64-fbsd-tdep.c: Revert.
7391         * aarch64-fbsd-nat.c: Revert.
7392         * aarch32-linux-nat.c: Revert.
7393
7394 2019-04-05  Tom Tromey  <tom@tromey.com>
7395
7396         * ft32-tdep.c: Sort headers.
7397         * frv-tdep.c: Sort headers.
7398         * frv-linux-tdep.c: Sort headers.
7399         * frame.c: Sort headers.
7400         * frame-unwind.c: Sort headers.
7401         * frame-base.c: Sort headers.
7402         * fork-child.c: Sort headers.
7403         * findvar.c: Sort headers.
7404         * findcmd.c: Sort headers.
7405         * filesystem.c: Sort headers.
7406         * filename-seen-cache.h: Sort headers.
7407         * filename-seen-cache.c: Sort headers.
7408         * fbsd-tdep.c: Sort headers.
7409         * fbsd-nat.h: Sort headers.
7410         * fbsd-nat.c: Sort headers.
7411         * f-valprint.c: Sort headers.
7412         * f-typeprint.c: Sort headers.
7413         * f-lang.c: Sort headers.
7414         * extension.h: Sort headers.
7415         * extension.c: Sort headers.
7416         * extension-priv.h: Sort headers.
7417         * expprint.c: Sort headers.
7418         * exec.h: Sort headers.
7419         * exec.c: Sort headers.
7420         * exceptions.c: Sort headers.
7421         * event-top.c: Sort headers.
7422         * event-loop.c: Sort headers.
7423         * eval.c: Sort headers.
7424         * elfread.c: Sort headers.
7425         * dwarf2read.h: Sort headers.
7426         * dwarf2read.c: Sort headers.
7427         * dwarf2loc.c: Sort headers.
7428         * dwarf2expr.h: Sort headers.
7429         * dwarf2expr.c: Sort headers.
7430         * dwarf2-frame.c: Sort headers.
7431         * dwarf2-frame-tailcall.c: Sort headers.
7432         * dwarf-index-write.h: Sort headers.
7433         * dwarf-index-write.c: Sort headers.
7434         * dwarf-index-common.c: Sort headers.
7435         * dwarf-index-cache.h: Sort headers.
7436         * dwarf-index-cache.c: Sort headers.
7437         * dummy-frame.c: Sort headers.
7438         * dtrace-probe.c: Sort headers.
7439         * disasm.h: Sort headers.
7440         * disasm.c: Sort headers.
7441         * disasm-selftests.c: Sort headers.
7442         * dictionary.c: Sort headers.
7443         * dicos-tdep.c: Sort headers.
7444         * demangle.c: Sort headers.
7445         * dcache.h: Sort headers.
7446         * dcache.c: Sort headers.
7447         * darwin-nat.h: Sort headers.
7448         * darwin-nat.c: Sort headers.
7449         * darwin-nat-info.c: Sort headers.
7450         * d-valprint.c: Sort headers.
7451         * d-namespace.c: Sort headers.
7452         * d-lang.c: Sort headers.
7453         * ctf.c: Sort headers.
7454         * csky-tdep.c: Sort headers.
7455         * csky-linux-tdep.c: Sort headers.
7456         * cris-tdep.c: Sort headers.
7457         * cris-linux-tdep.c: Sort headers.
7458         * cp-valprint.c: Sort headers.
7459         * cp-support.c: Sort headers.
7460         * cp-namespace.c: Sort headers.
7461         * cp-abi.c: Sort headers.
7462         * corelow.c: Sort headers.
7463         * corefile.c: Sort headers.
7464         * continuations.c: Sort headers.
7465         * completer.h: Sort headers.
7466         * completer.c: Sort headers.
7467         * complaints.c: Sort headers.
7468         * coffread.c: Sort headers.
7469         * coff-pe-read.c: Sort headers.
7470         * cli-out.h: Sort headers.
7471         * cli-out.c: Sort headers.
7472         * charset.c: Sort headers.
7473         * c-varobj.c: Sort headers.
7474         * c-valprint.c: Sort headers.
7475         * c-typeprint.c: Sort headers.
7476         * c-lang.c: Sort headers.
7477         * buildsym.c: Sort headers.
7478         * buildsym-legacy.c: Sort headers.
7479         * build-id.h: Sort headers.
7480         * build-id.c: Sort headers.
7481         * btrace.c: Sort headers.
7482         * bsd-uthread.c: Sort headers.
7483         * breakpoint.h: Sort headers.
7484         * breakpoint.c: Sort headers.
7485         * break-catch-throw.c: Sort headers.
7486         * break-catch-syscall.c: Sort headers.
7487         * break-catch-sig.c: Sort headers.
7488         * blockframe.c: Sort headers.
7489         * block.c: Sort headers.
7490         * bfin-tdep.c: Sort headers.
7491         * bfin-linux-tdep.c: Sort headers.
7492         * bfd-target.c: Sort headers.
7493         * bcache.c: Sort headers.
7494         * ax-general.c: Sort headers.
7495         * ax-gdb.h: Sort headers.
7496         * ax-gdb.c: Sort headers.
7497         * avr-tdep.c: Sort headers.
7498         * auxv.c: Sort headers.
7499         * auto-load.c: Sort headers.
7500         * arm-wince-tdep.c: Sort headers.
7501         * arm-tdep.c: Sort headers.
7502         * arm-symbian-tdep.c: Sort headers.
7503         * arm-pikeos-tdep.c: Sort headers.
7504         * arm-obsd-tdep.c: Sort headers.
7505         * arm-nbsd-tdep.c: Sort headers.
7506         * arm-nbsd-nat.c: Sort headers.
7507         * arm-linux-tdep.c: Sort headers.
7508         * arm-linux-nat.c: Sort headers.
7509         * arm-fbsd-tdep.c: Sort headers.
7510         * arm-fbsd-nat.c: Sort headers.
7511         * arm-bsd-tdep.c: Sort headers.
7512         * arch-utils.c: Sort headers.
7513         * arc-tdep.c: Sort headers.
7514         * arc-newlib-tdep.c: Sort headers.
7515         * annotate.h: Sort headers.
7516         * annotate.c: Sort headers.
7517         * amd64-windows-tdep.c: Sort headers.
7518         * amd64-windows-nat.c: Sort headers.
7519         * amd64-tdep.c: Sort headers.
7520         * amd64-sol2-tdep.c: Sort headers.
7521         * amd64-obsd-tdep.c: Sort headers.
7522         * amd64-obsd-nat.c: Sort headers.
7523         * amd64-nbsd-tdep.c: Sort headers.
7524         * amd64-nbsd-nat.c: Sort headers.
7525         * amd64-nat.c: Sort headers.
7526         * amd64-linux-tdep.c: Sort headers.
7527         * amd64-linux-nat.c: Sort headers.
7528         * amd64-fbsd-tdep.c: Sort headers.
7529         * amd64-fbsd-nat.c: Sort headers.
7530         * amd64-dicos-tdep.c: Sort headers.
7531         * amd64-darwin-tdep.c: Sort headers.
7532         * amd64-bsd-nat.c: Sort headers.
7533         * alpha-tdep.c: Sort headers.
7534         * alpha-obsd-tdep.c: Sort headers.
7535         * alpha-nbsd-tdep.c: Sort headers.
7536         * alpha-mdebug-tdep.c: Sort headers.
7537         * alpha-linux-tdep.c: Sort headers.
7538         * alpha-linux-nat.c: Sort headers.
7539         * alpha-bsd-tdep.c: Sort headers.
7540         * alpha-bsd-nat.c: Sort headers.
7541         * aix-thread.c: Sort headers.
7542         * agent.c: Sort headers.
7543         * addrmap.c: Sort headers.
7544         * ada-varobj.c: Sort headers.
7545         * ada-valprint.c: Sort headers.
7546         * ada-typeprint.c: Sort headers.
7547         * ada-tasks.c: Sort headers.
7548         * ada-lang.c: Sort headers.
7549         * aarch64-tdep.c: Sort headers.
7550         * aarch64-ravenscar-thread.c: Sort headers.
7551         * aarch64-newlib-tdep.c: Sort headers.
7552         * aarch64-linux-tdep.c: Sort headers.
7553         * aarch64-linux-nat.c: Sort headers.
7554         * aarch64-fbsd-tdep.c: Sort headers.
7555         * aarch64-fbsd-nat.c: Sort headers.
7556         * aarch32-linux-nat.c: Sort headers.
7557
7558 2019-04-04  Tom Tromey  <tom@tromey.com>
7559
7560         * varobj.c (varobj_create): Update.
7561         * rust-exp.y (struct rust_parser) <update_innermost_block,
7562         lookup_symbol>: New methods.
7563         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7564         Rename.
7565         (rust_parser::rust_lookup_type)
7566         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7567         * printcmd.c (display_command, do_one_display): Update.
7568         * parser-defs.h (struct parser_state) <parser_state>: Add
7569         "tracker" parameter.
7570         (block_tracker): New member.
7571         (class innermost_block_tracker) <innermost_block_tracker>: Add
7572         "types" parameter.
7573         <reset>: Remove method.
7574         (innermost_block): Don't declare.
7575         (null_post_parser): Update.
7576         * parse.c (innermost_block): Remove global.
7577         (write_dollar_variable): Update.
7578         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7579         Remove "tracker_types" parameter.
7580         (parse_expression): Add "tracker" parameter.
7581         (parse_expression_for_completion): Update.
7582         (null_post_parser): Add "tracker" parameter.
7583         * p-exp.y: Update rules.
7584         * m2-exp.y: Update rules.
7585         * language.h (struct language_defn) <la_post_parser>: Add
7586         "tracker" parameter.
7587         * go-exp.y: Update rules.
7588         * f-exp.y: Update rules.
7589         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7590         parameter.
7591         * d-exp.y: Update rules.
7592         * c-exp.y: Update rules.
7593         * breakpoint.c (set_breakpoint_condition): Create an
7594         innermost_block_tracker.
7595         (watch_command_1): Likewise.
7596         * ada-lang.c (resolve): Add "tracker" parameter.
7597         (resolve_subexp): Likewise.
7598         * ada-exp.y (write_var_from_sym): Update.
7599
7600 2019-04-04  Tom Tromey  <tom@tromey.com>
7601
7602         * type-stack.h: New file.
7603         * type-stack.c: New file.
7604         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7605         type-stack.h.
7606         (insert_into_type_stack, insert_type, push_type, push_type_int)
7607         (insert_type_address_space, pop_type, pop_type_int)
7608         (pop_typelist, pop_type_stack, append_type_stack)
7609         (push_type_stack, get_type_stack, push_typelist)
7610         (follow_type_instance_flags, follow_types): Don't declare.
7611         * parse.c (type_stack): Remove global.
7612         (parse_exp_in_context): Update.
7613         (insert_into_type_stack, insert_type, push_type, push_type_int)
7614         (insert_type_address_space, pop_type, pop_type_int)
7615         (pop_typelist, pop_type_stack, append_type_stack)
7616         (push_type_stack, get_type_stack, push_typelist)
7617         (follow_type_instance_flags, follow_types): Remove (moved to
7618         type-stack.c).
7619         * f-exp.y (type_stack): New global.
7620         Update rules.
7621         (push_kind_type, f_parse): Update.
7622         * d-exp.y (type_stack): New global.
7623         Update rules.
7624         (d_parse): Update.
7625         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7626         Update rules.
7627         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7628         (HFILES_NO_SRCDIR): Add type-stack.h.
7629
7630 2019-04-04  Tom Tromey  <tom@tromey.com>
7631
7632         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7633         (rust_parser::convert_ast_to_expression, rust_parse)
7634         (rust_lex_test_completion, rust_lex_tests): Update.
7635         * parser-defs.h (struct expr_completion_state): New.
7636         (struct parser_state) <parser_state>: Add completion parameter.
7637         <mark_struct_expression, mark_completion_tag>: New methods.
7638         <parse_completion, m_completion_state>: New members.
7639         (prefixify_expression, null_post_parser): Update.
7640         (mark_struct_expression, mark_completion_tag): Don't declare.
7641         * parse.c (parse_completion, expout_last_struct)
7642         (expout_tag_completion_type, expout_completion_name): Remove
7643         globals.
7644         (parser_state::mark_struct_expression)
7645         (parser_state::mark_completion_tag): Now methods.
7646         (prefixify_expression): Add last_struct parameter.
7647         (prefixify_subexp): Likewise.
7648         (parse_exp_1): Update.
7649         (parse_exp_in_context): Add cstate parameter.  Update.
7650         (parse_expression_for_completion): Create an
7651         expr_completion_state.
7652         (null_post_parser): Add "completion" parameter.
7653         * p-exp.y: Update rules.
7654         (yylex): Update.
7655         * language.h (struct language_defn) <la_post_parser>: Add
7656         "completing" parameter.
7657         * go-exp.y: Update rules.
7658         (lex_one_token): Update.
7659         * expression.h (parse_completion): Don't declare.
7660         * d-exp.y: Update rules.
7661         (lex_one_token): Update rules.
7662         * c-exp.y: Update rules.
7663         (lex_one_token): Update.
7664         * ada-lang.c (resolve): Add "parse_completion" parameter.
7665         (resolve_subexp): Likewise.
7666         (ada_resolve_function): Likewise.
7667
7668 2019-04-04  Tom Tromey  <tom@tromey.com>
7669
7670         * parser-defs.h (struct parser_state) <start_arglist,
7671         end_arglist>: New methods.
7672         <arglist_len, m_funcall_chain>: New members.
7673         (arglist_len, start_arglist, end_arglist): Don't declare.
7674         * parse.c (arglist_len, funcall_chain): Remove global.
7675         (start_arglist, end_arglist): Remove functions.
7676         (parse_exp_in_context): Update.
7677         * p-exp.y: Update rules.
7678         * m2-exp.y: Update rules.
7679         * go-exp.y: Update rules.
7680         * f-exp.y: Update rules.
7681         * d-exp.y: Update rules.
7682         * c-exp.y: Update rules.
7683
7684 2019-04-04  Tom Tromey  <tom@tromey.com>
7685
7686         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7687         lex_operator, push_back>: New methods.
7688         Update all rules.
7689         (rust_parser::lex_hex, lex_escape): Rename and update.
7690         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7691         (rust_parser::lex_operator): Rename and update.
7692         (rust_parser::lex_number, rustyylex, rustyyerror)
7693         (rust_lex_test_init, rust_lex_test_sequence)
7694         (rust_lex_test_push_back, rust_lex_tests): Update.
7695         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7696         parameter.
7697         <lexptr, prev_lexptr>: New members.
7698         (lexptr, prev_lexptr): Don't declare.
7699         * parse.c (lexptr, prev_lexptr): Remove globals.
7700         (parse_exp_in_context): Update.
7701         * p-exp.y (yylex, yyerror): Update.
7702         * m2-exp.y (parse_number, yylex, yyerror): Update.
7703         * go-exp.y (lex_one_token, yyerror): Update.
7704         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7705         * d-exp.y (lex_one_token, yyerror): Update.
7706         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7707         (lex_one_token, yyerror): Update.
7708         * ada-lex.l (YY_INPUT): Update.
7709         (rewind_to_char): Update.
7710         * ada-exp.y (yyerror): Update.
7711
7712 2019-04-04  Tom Tromey  <tom@tromey.com>
7713
7714         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7715         * parser-defs.h (struct parser_state) <parser_state>: Add new
7716         parameter.
7717         <comma_terminates>: New member.
7718         (comma_terminates): Don't declare global.
7719         * parse.c (comma_terminates): Remove global.
7720         (parse_exp_in_context): Update.
7721         * p-exp.y (yylex): Update.
7722         * m2-exp.y (yylex): Update.
7723         * go-exp.y (lex_one_token): Update.
7724         * f-exp.y (yylex): Update.
7725         * d-exp.y (lex_one_token): Update.
7726         * c-exp.y (lex_one_token): Update.
7727         * ada-lex.l: Update.
7728
7729 2019-04-04  Tom Tromey  <tom@tromey.com>
7730
7731         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7732         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7733         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7734         * parser-defs.h (paren_depth): Don't declare.
7735         * parse.c (paren_depth): Remove global.
7736         (parse_exp_in_context): Update.
7737         * p-exp.y (paren_depth): New global.
7738         (pascal_parse): Initialize it.
7739         * m2-exp.y (paren_depth): New global.
7740         (m2_parse): Initialize it.
7741         * go-exp.y (paren_depth): New global.
7742         (go_parse): Initialize it.
7743         * f-exp.y (paren_depth): New global.
7744         (f_parse): Initialize it.
7745         * d-exp.y (paren_depth): New global.
7746         (d_parse): Initialize it.
7747         * c-exp.y (paren_depth): New global.
7748         (c_parse): Initialize it.
7749         * ada-lex.l (paren_depth): New global.
7750         (lexer_init): Initialize it.
7751
7752 2019-04-04  Tom Tromey  <tom@tromey.com>
7753
7754         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7755         (rust_parser::convert_ast_to_type)
7756         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7757         * parser-defs.h (struct parser_state) <parser_state>: Add
7758         parameters.  Initialize new members.
7759         <expression_context_block, expression_context_pc>: New members.
7760         * parse.c (expression_context_block, expression_context_pc):
7761         Remove globals.
7762         (parse_exp_in_context): Update.
7763         * p-exp.y: Update all rules.
7764         (yylex): Update.
7765         * m2-exp.y: Update all rules.
7766         (yylex): Update.
7767         * go-exp.y (yylex): Update.
7768         * f-exp.y (yylex): Update.
7769         * d-exp.y: Update all rules.
7770         (yylex): Update.
7771         * c-exp.y: Update all rules.
7772         (lex_one_token, classify_name, yylex, c_parse): Update.
7773         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7774
7775 2019-04-04  Tom Tromey  <tom@tromey.com>
7776
7777         * gdbarch.h, gdbarch.c: Rebuild.
7778         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7779         * stap-probe.h:
7780         (struct stap_parse_info): Replace "parser_state" with
7781         "expr_builder".
7782         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7783         (parser_state): New class.
7784         * parse.c (expr_builder): Rename.
7785         (expr_builder::release): Rename.
7786         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7787         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7788         (write_exp_elt_longcst, write_exp_elt_floatcst)
7789         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7790         (write_exp_string_vector, write_exp_bitstring)
7791         (write_exp_msymbol, mark_struct_expression)
7792         (write_dollar_variable)
7793         (insert_type_address_space, increase_expout_size): Replace
7794         "parser_state" with "expr_builder".
7795         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7796         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7797         "parser_state" with "expr_builder".
7798
7799 2019-04-04  Tom Tromey  <tom@tromey.com>
7800
7801         * rust-exp.y: Replace "parse_language" with method call.
7802         * p-exp.y:
7803         (yylex): Replace "parse_language" with method call.
7804         * m2-exp.y:
7805         (yylex): Replace "parse_language" with method call.
7806         * go-exp.y (classify_name): Replace "parse_language" with method
7807         call.
7808         * f-exp.y (yylex): Replace "parse_language" with method call.
7809         * d-exp.y (lex_one_token): Replace "parse_language" with method
7810         call.
7811         * c-exp.y:
7812         (lex_one_token, classify_name, yylex): Replace "parse_language"
7813         with method call.
7814         * ada-exp.y (find_primitive_type, type_char)
7815         (type_system_address): Replace "parse_language" with method call.
7816
7817 2019-04-04  Tom Tromey  <tom@tromey.com>
7818
7819         * rust-exp.y: Replace "parse_gdbarch" with method call.
7820         * parse.c (write_dollar_variable, insert_type_address_space):
7821         Replace "parse_gdbarch" with method call.
7822         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7823         call.
7824         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7825         call.
7826         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7827         "parse_gdbarch" with method call.
7828         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7829         with method call.
7830         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7831         "parse_gdbarch" with method call.
7832         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7833         "parse_gdbarch" with method call.
7834         * c-exp.y (parse_type, parse_number, classify_name): Replace
7835         "parse_gdbarch" with method call.
7836         * ada-lex.l: Replace "parse_gdbarch" with method call.
7837         * ada-exp.y (parse_type, find_primitive_type, type_char)
7838         (type_system_address): Replace "parse_gdbarch" with method call.
7839
7840 2019-04-04  Tom Tromey  <tom@tromey.com>
7841
7842         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7843         * stap-probe.c (stap_parse_argument): Update.
7844         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7845         initial_size parameter.
7846         * rust-exp.y (rust_lex_tests): Update.
7847         * parse.c (parser_state): Update.
7848         (parse_exp_in_context): Update.
7849         * parser-defs.h (struct parser_state) <parser_state>: Remove
7850         "initial_size" parameter.
7851
7852 2019-04-04  Tom Tromey  <tom@tromey.com>
7853
7854         * parser-defs.h (increase_expout_size): Don't declare.
7855         * parse.c (increase_expout_size): Now static.
7856
7857 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7858
7859         * gnu-nat.c (gnu_nat_target::wait): Fix
7860         target_waitstatus_to_string call.
7861
7862 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7863
7864         * eval.c (evaluate_subexp_standard): Handle internal functions
7865         during Fortran function call handling.
7866
7867 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * NEWS: Mention new internal functions.
7870         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7871         (read_base_type): Use dwarf2_init_complex_target_type.
7872         * value.c (creal_internal_fn): New function.
7873         (cimag_internal_fn): New function.
7874         (_initialize_values): Register new internal functions.
7875
7876 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7877
7878         * infrun.c (stop_all_threads): If debug_infrun, always
7879         trace the wait status after wait_one, using
7880         target_waitstatus_to_string and target_pid_to_str.
7881         (handle_inferior_event): Replace various trace of
7882         wait status kind by a single trace.
7883         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7884         wait status kind image by target_waitstatus_to_string.
7885         * target/waitstatus.c (target_waitstatus_to_string): Fix
7886         obsolete comment.
7887
7888 2019-04-01  Tom Tromey  <tromey@adacore.com>
7889
7890         PR symtab/23331:
7891         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7892
7893 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7894             Pedro Alves  <palves@redhat.com>
7895
7896         * top.c (quit_force): Call 'finalize_values'.
7897         * value.c (finalize_values): New function.
7898         * value.h (finalize_values): Declare.
7899
7900 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7901
7902         * NEWS: Announce $_gdb_major and $_gdb_minor.
7903
7904         * top.c (init_gdb_version_vars): New function.
7905         (gdb_init): Call init_gdb_version_vars.
7906
7907 2019-03-29  Tom Tromey  <tromey@adacore.com>
7908
7909         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7910         help text.  Remove dead code.
7911
7912 2019-03-29  Keith Seitz  <keiths@redhat.com>
7913
7914         From Siddhesh Poyarekar:
7915         * f-lang.h (f77_get_upperbound): Return LONGEST.
7916         (f77_get_lowerbound): Likewise.
7917         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7918         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7919         print them.
7920         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7921         plongest to format print it.
7922         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7923         (f77_get_upperbound): Likewise.
7924         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7925         LOWER_BOUND to LONGEST.
7926         (f77_create_arrayprint_offset_tbl): Likewise.
7927
7928 2019-03-29  Keith Seitz  <keiths@redhat.com>
7929
7930         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7931         %s/pulongest for TYPE_LENGTH instead of %d in format
7932         strings.
7933         * ada-typerint.c (ada_print_type): Likewise.
7934         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7935         * compile/compile-c-support.c (generate_register_struct): Likewise.
7936         * gdbtypes.c (recursive_dump_type): Likewise.
7937         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7938         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7939         instead of %d in format strings.
7940         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7941         to std::min to ULONGEST.
7942         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7943         instead of %d in format strings.
7944         * tracepoint.c (info_scope_command): Likewise.
7945         * typeprint.c (print_offset_data::update)
7946         (print_offset_data::finish): Likewise.
7947         * xtensa-tdep.c (xtensa_store_return_value)
7948         (xtensa_push_dummy_call): Likewise.
7949
7950 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7951
7952         * windows-nat.c (display_selector): Fixed format specifications
7953         for 64-bit Cygwin.
7954
7955 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7956
7957         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7958
7959 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7960
7961         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7962         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7963         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7964         (nios2_linux_init_abi): Install it.
7965
7966 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7967
7968         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7969
7970 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7971
7972         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7973
7974 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7975             Tom Tromey  <tromey@adacore.com>
7976
7977         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7978
7979 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7980
7981         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7982         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7983         method to compute the bounds of range types. Also print "[evaluated]"
7984         if the bounds' values come from a dynamic evaluation.
7985
7986 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7987
7988         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7989         whitespace when pretty printing is on.
7990
7991 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7992
7993         * ppc-linux-nat.c: Add include.
7994
7995 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7996
7997         * NEWS: Mention AArch64 Pointer Authentication.
7998
7999 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8000
8001         * arm-linux-nat.c: Add include.
8002
8003 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8004
8005         * source-cache.c (source_cache::get_source_lines): Re-read
8006         fullname after calling open_source_file.
8007
8008 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8009
8010         * NEWS: Mention TLS support for FreeBSD.
8011
8012 2019-03-25  Tom Tromey  <tromey@adacore.com>
8013
8014         * minsyms.c (BUNCH_SIZE): Update comment.
8015         (~minimal_symbol_reader): Remove old comment.
8016         (compact_minimal_symbols): Update comment.
8017         (minimal_symbol_reader::install): Remove old comment.  Update
8018         other comments.
8019
8020 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8021
8022         * s390-linux-nat.c: Add include.
8023
8024 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8025
8026         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8027         Call linux_get_hwcap.
8028         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8029         Likewise.
8030         (aarch64_linux_get_hwcap): Remove function.
8031         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8032         declaration.
8033         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8034         linux_get_hwcap.
8035         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8036         * linux-tdep.c (linux_get_hwcap): Add function.
8037         (linux_get_hwcap2): Likewise.
8038         * linux-tdep.h (linux_get_hwcap): Add declaration.
8039         (linux_get_hwcap2): Likewise.
8040         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8041         (ppc_linux_get_hwcap2): Likewise.
8042         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8043         linux_get_hwcap.
8044         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8045         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8046         (ppc_linux_nat_target::read_description): Likewise.
8047         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8048         * s390-linux-nat.c: Likewise.
8049         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8050
8051 2019-03-24  Tom Tromey  <tom@tromey.com>
8052
8053         * ada-lang.c (standard_lookup): Simplify initialization.
8054         (ada_lookup_symbol_nonlocal): Simplify return.
8055         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8056         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8057         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8058         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8059         initialization.
8060         * solib.c (solib_global_lookup): Simplify.
8061         * symtab.c (null_block_symbol): Remove.
8062         (symbol_cache_lookup): Simplify returns.
8063         (lookup_language_this): Simplify returns.
8064         (lookup_symbol_aux): Simplify return.
8065         (lookup_local_symbol): Simplify returns.
8066         (lookup_global_symbol_from_objfile): Simplify return.
8067         (lookup_symbol_in_objfile_symtabs)
8068         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8069         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8070         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8071         * cp-namespace.c (cp_lookup_bare_symbol)
8072         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8073         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8074         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8075         (cp_lookup_symbol_via_imports): Simplify initialization.
8076         (find_symbol_in_baseclass): Likewise.
8077         * symtab.h (null_block_symbol): Remove.
8078         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8079         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8080         (d_lookup_symbol_module): Likewise.
8081         (find_symbol_in_baseclass): Simplify initialization.
8082
8083 2019-03-24  Tom Tromey  <tom@tromey.com>
8084
8085         * expression.h: Don't include symtab.h.
8086         (struct block): Forward declare.
8087
8088 2019-03-24  Tom Tromey  <tom@tromey.com>
8089
8090         * c-exp.y (typebase): Remove casts.
8091         * gdbtypes.c (lookup_unsigned_typename, )
8092         (lookup_signed_typename): Remove cast.
8093         * eval.c (parse_to_comma_and_eval): Remove cast.
8094         * parse.c (write_dollar_variable): Remove cast.
8095         * block.h (struct block) <superblock>: Now const.
8096         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8097         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8098         (map_block): Make "block" const.
8099         * symfile.h (struct quick_symbol_functions)
8100         <map_matching_symbols>: Constify block argument to "callback".
8101         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8102         const.
8103         (find_pc_sect_compunit_symtab): Make "b" const.
8104         (find_symbol_at_address): Likewise.
8105         (search_symbols): Likewise.
8106         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8107         (dw2_debug_names_lookup_symbol): Likewise.
8108         (dw2_map_matching_symbols): Update.
8109         * p-valprint.c (pascal_val_print): Remove "block".
8110         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8111         (aux_add_nonlocal_symbols): Make "block" const.
8112         (resolve_subexp): Remove cast.
8113         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8114         const.
8115         (iterate_over_file_blocks): Likewise.
8116         * f-exp.y (%union) <bval>: Remove.
8117         * coffread.c (patch_opaque_types): Make "b" const.
8118         * spu-tdep.c (spu_catch_start): Make "block" const.
8119         * c-valprint.c (print_unpacked_pointer): Remove "block".
8120         * symmisc.c (dump_symtab_1): Make "b" const.
8121         (block_depth): Make "block" const.
8122         * d-exp.y (%union) <bval>: Remove.
8123         * cp-support.h (cp_lookup_rtti_type): Update.
8124         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8125         * psymtab.c (psym_lookup_symbol): Make "block" const.
8126         (maintenance_check_psymtabs): Make "b" const.
8127         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8128         (enumerate_locals, enumerate_args): Update.
8129         * python/py-symtab.c (stpy_global_block): Make "block" const.
8130         (stpy_static_block): Likewise.
8131         * inline-frame.c (block_starting_point_at): Make "new_block"
8132         const.
8133         * block.c (find_block_in_blockvector): Make return type const.
8134         (blockvector_for_pc_sect): Make "b" const.
8135         (find_block_in_blockvector): Make "b" const.
8136
8137 2019-03-23  Tom Tromey  <tom@tromey.com>
8138
8139         * varobj.c (varobj_create): Update.
8140         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8141         * printcmd.c (display_command, do_one_display): Don't reset
8142         innermost_block.
8143         * parser-defs.h (enum innermost_block_tracker_type): Move to
8144         expression.h.
8145         (innermost_block): Update comment.
8146         * parse.c (parse_exp_1): Add tracker_types parameter.
8147         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8148         tracker_types parameter.  Reset innermost_block.
8149         (parse_exp_in_context): Remove.
8150         (parse_expression_for_completion): Update.
8151         * objfiles.c (~objfile): Don't reset expression_context_block or
8152         innermost_block.
8153         * expression.h (enum innermost_block_tracker_type): Move from
8154         parser-defs.h.
8155         (parse_exp_1): Add tracker_types parameter.
8156         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8157         reset innermost_block.
8158
8159 2019-03-23  Tom Tromey  <tom@tromey.com>
8160
8161         * objfiles.h: Include bcache.h.
8162
8163 2019-03-23  Tom Tromey  <tom@tromey.com>
8164
8165         * linespec.c (get_current_search_block): Use
8166         scoped_restore_current_language.
8167         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8168
8169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8170             Jiong Wang  <jiong.wang@arm.com>
8171
8172         * aarch64-linux-tdep.c
8173         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8174         section.
8175         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8176
8177 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8178             Jiong Wang  <jiong.wang@arm.com>
8179
8180         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8181         instructions.
8182         (aarch64_analyze_prologue_test): Add PACIASP test.
8183         (aarch64_prologue_prev_register): Unmask PC value.
8184
8185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8186             Jiong Wang  <jiong.wang@arm.com>
8187
8188         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8189         (aarch64_dwarf2_prev_register): Unmask PC value.
8190         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8191         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8192         DW_CFA_AARCH64_negate_ra_state.
8193         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8194
8195 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8196             Jiong Wang  <jiong.wang@arm.com>
8197
8198         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8199         registers.
8200         (aarch64_pseudo_register_name): Likewise.
8201         (aarch64_pseudo_register_type): Likewise.
8202         (aarch64_pseudo_register_reggroup_p): Likewise.
8203         (aarch64_gdbarch_init): Add pauth registers.
8204         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8205         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8206         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8207         (struct gdbarch_tdep): Add regnum for ra_state.
8208
8209 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8210             Jiong Wang  <jiong.wang@arm.com>
8211
8212         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8213
8214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8215             Jiong Wang  <jiong.wang@arm.com>
8216
8217         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8218         function.
8219         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8220         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8221         (aarch64_gdbarch_init): Add puth registers.
8222         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8223         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8224         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8225
8226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8227             Jiong Wang  <jiong.wang@arm.com>
8228
8229         * aarch64-linux-nat.c
8230         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8231         * aarch64-linux-tdep.c
8232         (aarch64_linux_core_read_description): Likewise.
8233         (aarch64_linux_get_hwcap): New function.
8234         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8235         (aarch64_linux_get_hwcap): New declaration.
8236
8237 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8238             Jiong Wang  <jiong.wang@arm.com>
8239
8240         * aarch64-linux-nat.c
8241         (aarch64_linux_nat_target::read_description): Add pauth param.
8242         * aarch64-linux-tdep.c
8243         (aarch64_linux_core_read_description): Likewise.
8244         * aarch64-tdep.c (struct target_desc): Add in pauth.
8245         (aarch64_read_description): Add pauth param.
8246         (aarch64_gdbarch_init): Likewise.
8247         * aarch64-tdep.h (aarch64_read_description): Likewise.
8248         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8249         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8250         * features/Makefile: Add new files.
8251         * features/aarch64-pauth.c: New file.
8252         * features/aarch64-pauth.xml: New file.
8253
8254 2019-03-20  Tom Tromey  <tromey@adacore.com>
8255
8256         * infrun.c (handle_inferior_event): Rename from
8257         handle_inferior_event_1.  Create a scoped_value_mark.
8258         (handle_inferior_event): Remove.
8259
8260 2019-03-19  Tom Tromey  <tromey@adacore.com>
8261
8262         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8263         * infrun.h (print_stop_event): Add "displays" parameter.
8264         * infrun.c (print_stop_event): Add "displays" parameter.
8265
8266 2019-03-19  Pedro Alves  <palves@redhat.com>
8267
8268         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8269         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8270         to -1.  Fix TABs vs spaces.
8271         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8272         * tui/tui-out.h (tui_ui_out) Add intro comments.
8273         <m_line, m_start_of_line>: In-class initialize, and add describing
8274         comment.
8275
8276 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8277
8278         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8279         variable names.
8280         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8281
8282 2019-03-18  Pedro Alves  <palves@redhat.com>
8283             Eli Zaretskii <eliz@gnu.org>
8284
8285         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8286         m_line and m_start_of_line.
8287
8288 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8289
8290         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8291         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8292         it returns a newline.  This fixes a regression in TU mode, whereby
8293         the next line is output on the same screen line as the user input.
8294
8295 2019-03-18  Tom Tromey  <tromey@adacore.com>
8296
8297         * minsyms.c (minimal_symbol_reader::install): Remove call to
8298         obstack_blank.
8299
8300 2019-03-18  Pedro Alves  <palves@redhat.com>
8301
8302         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8303         New globals.
8304         (apply_style): New, factored out from ...
8305         (apply_ansi_escape): ... this.  Handle reverse video mode.
8306         (tui_set_reverse_mode): New function.
8307         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8308         * tui/tui-winsource.c (tui_show_source_line): Use
8309         tui_set_reverse_mode instead of setting A_STANDOUT.
8310         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8311         New setter methods.
8312
8313 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8314
8315         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8316         Handle tabs.
8317
8318 2019-03-18  Tom Tromey  <tromey@adacore.com>
8319
8320         * ada-lang.c (empty_array): Add "high" parameter.
8321         (ada_evaluate_subexp): Update.
8322
8323 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8324
8325         * unittests/string_view-selftests.c: Define
8326         _initialize_string_view_selftests unconditionally.
8327
8328 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8329
8330         PR gdb/24350
8331         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8332
8333 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8334
8335         PR gdb/24351
8336         * windows-nat.c (display_selector): Fix format specifiers.
8337
8338 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8339
8340         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8341         tui_refill_source_window instead of tui_refresh_win, to update the
8342         current execution line.  This fixes redisplay of the current line
8343         when stepping through the code with "next" or "step".
8344
8345 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8346
8347         * source-cache.c (source_cache::get_source_lines): Call
8348         find_source_lines to initialize s->nlines.  This fixes vertical
8349         scrolling of TUI source window when the DOWN arrow is pressed.
8350
8351 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8352
8353         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8354         linux-thread-db.c (_initialize_thread_db): Likewise.
8355
8356 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8357
8358         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8359         wclrtoeol in tui_show_source_line".  This reverts changes made in
8360         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8361
8362 2019-03-15  Tom Tromey  <tom@tromey.com>
8363
8364         * symtab.h (struct minimal_symbol): Derive from
8365         general_symbol_info.
8366         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8367         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8368         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8369         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8370         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8371         (MSYMBOL_SEARCH_NAME): Update.
8372         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8373         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8374         * minsyms.c (minimal_symbol_reader::record_full): Update.
8375
8376 2019-03-15  Tom Tromey  <tom@tromey.com>
8377
8378         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8379
8380 2019-03-15  Tom Tromey  <tom@tromey.com>
8381
8382         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8383         unique_xmalloc_ptr.
8384         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8385         Update.
8386         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8387         (build_minimal_symbol_hash_tables)
8388         (minimal_symbol_reader::install): Update.
8389
8390 2019-03-15  Tom Tromey  <tom@tromey.com>
8391
8392         * symtab.c (create_demangled_names_hash): Update.
8393         (symbol_set_names): Update.
8394         * objfiles.h (struct objfile_per_bfd_storage)
8395         <demangled_names_hash>: Now an htab_up.
8396         * objfiles.c (objfile_per_bfd_storage): Simplify.
8397
8398 2019-03-15  Tom Tromey  <tom@tromey.com>
8399
8400         * objfiles.h (struct objfile_per_bfd_storage): Declare
8401         destructor.
8402         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8403         New.
8404         (get_objfile_bfd_data): Use new.  Don't initialize
8405         language_of_main.
8406         (free_objfile_per_bfd_storage): Remove.
8407         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8408
8409 2019-03-15  Tom Tromey  <tom@tromey.com>
8410
8411         * symfile.c (reread_symbols): Update.
8412         * objfiles.c (objfile::objfile): Update.
8413         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8414         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8415         comment.
8416         (minimal_symbol_reader::install): Update.
8417         (terminate_minimal_symbol_table): Remove.
8418         * jit.c (jit_object_close_impl): Update.
8419
8420 2019-03-15  Tom Tromey  <tom@tromey.com>
8421
8422         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8423         initializations.
8424
8425 2019-03-15  Tom Tromey  <tom@tromey.com>
8426
8427         * objfiles.h (struct objfile_per_bfd_storage)
8428         <demangled_hash_languages>: Now a bitset.
8429         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8430         (lookup_minimal_symbol): Update.
8431
8432 2019-03-15  Tom Tromey  <tom@tromey.com>
8433
8434         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8435         Don't return the symbol.
8436         * coffread.c (record_minimal_symbol): Use record_full.
8437
8438 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8439
8440         The MS-Windows port of ncurses fails to switch to a color pair if
8441         one or both of the colors are the implicit default colors.  This
8442         change records the default colors when TUI is initialized, and
8443         then specifies them explicitly when a color pair uses the default
8444         colors.  This allows color styling in TUI mode on MS-Windows.
8445
8446         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8447         ncurses_norm_attr.
8448         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8449         colors in ncurses_norm_attr.
8450         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8451         "none", replace it with the default color recorded in
8452         ncurses_norm_attr.
8453
8454 2019-03-14  Tom Tromey  <tromey@adacore.com>
8455
8456         * source-cache.h (class source_cache) <get_source_lines>: Return
8457         std::string.
8458         * source-cache.c (source_cache::extract_lines): Handle case where
8459         first_pos==npos.  Return std::string.
8460         (source_cache::get_source_lines): Update.
8461
8462 2019-03-14  Tom Tromey  <tromey@adacore.com>
8463
8464         * NEWS: Add item for "style sources" commands.
8465         * source-cache.c (source_cache::get_source_lines): Check
8466         source_styling.
8467         * cli/cli-style.c (source_styling): New global.
8468         (_initialize_cli_style): Add "style sources" commands.
8469         (show_style_sources): New function.
8470         * cli/cli-style.h (source_styling): Declare.
8471
8472 2019-03-14  Pedro Alves  <palves@redhat.com>
8473             Tom Tromey  <tromey@adacore.com>
8474
8475         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8476         * tui/tui-winsource.c (tui_refill_source_window): New function,
8477         from...
8478         (tui_horizontal_source_scroll): ... here.  Move some logic.
8479         * cli/cli-style.c (set_style_enabled): Notify new observable.
8480         * tui/tui-hooks.c (tui_redisplay_source): New function.
8481         (tui_attach_detach_observers): Attach or detach
8482         tui_redisplay_source.
8483         * observable.h (source_styling_changed): New observable.
8484         * observable.c: Define source_styling_changed observable.
8485
8486 2019-03-13  Tom Tromey  <tromey@adacore.com>
8487
8488         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8489         (i386_gnu_nat_target::store_registers): Update.
8490         * target-debug.h (target_debug_print_std_string): New macro.
8491         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8492         * windows-tdep.c (display_one_tib): Update.
8493         * tui/tui-stack.c (tui_make_status_line): Update.
8494         * top.c (print_inferior_quit_action): Update.
8495         * thread.c (thr_try_catch_cmd): Update.
8496         (add_thread_with_info): Update.
8497         (thread_target_id_str): Update.
8498         (thr_try_catch_cmd): Update.
8499         (thread_command): Update.
8500         (thread_find_command): Update.
8501         * record-btrace.c (record_btrace_target::info_record)
8502         (record_btrace_resume_thread, record_btrace_target::resume)
8503         (record_btrace_cancel_resume, record_btrace_step_thread)
8504         (record_btrace_target::wait, record_btrace_target::wait)
8505         (record_btrace_target::wait, record_btrace_target::stop): Update.
8506         * progspace.c (print_program_space): Update.
8507         * process-stratum-target.c
8508         (process_stratum_target::thread_address_space): Update.
8509         * linux-fork.c (linux_fork_mourn_inferior)
8510         (detach_checkpoint_command, info_checkpoints_command)
8511         (linux_fork_context): Update.
8512         (linux_fork_detach): Update.
8513         (class scoped_switch_fork_info): Update.
8514         (delete_checkpoint_command): Update.
8515         * infrun.c (follow_fork_inferior): Update.
8516         (follow_fork_inferior): Update.
8517         (proceed_after_vfork_done): Update.
8518         (handle_vfork_child_exec_or_exit): Update.
8519         (follow_exec): Update.
8520         (displaced_step_prepare_throw): Update.
8521         (displaced_step_restore): Update.
8522         (start_step_over): Update.
8523         (resume_1): Update.
8524         (clear_proceed_status_thread): Update.
8525         (proceed): Update.
8526         (print_target_wait_results): Update.
8527         (do_target_wait): Update.
8528         (context_switch): Update.
8529         (stop_all_threads): Update.
8530         (restart_threads): Update.
8531         (finish_step_over): Update.
8532         (handle_signal_stop): Update.
8533         (switch_back_to_stepped_thread): Update.
8534         (keep_going_pass_signal): Update.
8535         (print_exited_reason): Update.
8536         (normal_stop): Update.
8537         * inferior.c (inferior_pid_to_str): Change return type.
8538         (print_selected_inferior): Update.
8539         (add_inferior): Update.
8540         (detach_inferior): Update.
8541         * dummy-frame.c (fprint_dummy_frames): Update.
8542         * dcache.c (dcache_info_1): Update.
8543         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8544         (btrace_fetch, btrace_clear): Update.
8545         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8546         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8547         type.
8548         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8549         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8550         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8551         * gdbarch.c, gdbarch.h: Rebuild.
8552         * gdbarch.sh (core_pid_to_str): Change return type.
8553         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8554         return type.
8555         (windows_nat_target::pid_to_str): Change return type.
8556         (windows_delete_thread): Update.
8557         (windows_nat_target::attach): Update.
8558         (windows_nat_target::files_info): Update.
8559         * target-delegates.c: Rebuild.
8560         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8561         return type.
8562         (sol_thread_target::pid_to_str): Change return type.
8563         * remote.c (class remote_target) <pid_to_str>: Change return
8564         type.
8565         (remote_target::pid_to_str): Change return type.
8566         (extended_remote_target::attach, remote_target::remote_stop_ns)
8567         (remote_target::remote_notif_remove_queued_reply)
8568         (remote_target::push_stop_reply, remote_target::disable_btrace):
8569         Update.
8570         (extended_remote_target::attach): Update.
8571         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8572         type.
8573         (gdbsim_target::pid_to_str): Change return type.
8574         * ravenscar-thread.c (struct ravenscar_thread_target)
8575         <pid_to_str>: Change return type.
8576         (ravenscar_thread_target::pid_to_str): Change return type.
8577         * procfs.c (class procfs_target) <pid_to_str>: Change return
8578         type.
8579         (procfs_target::pid_to_str): Change return type.
8580         (procfs_target::attach): Update.
8581         (procfs_target::detach): Update.
8582         (procfs_target::fetch_registers): Update.
8583         (procfs_target::store_registers): Update.
8584         (procfs_target::wait): Update.
8585         (procfs_target::files_info): Update.
8586         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8587         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8588         return type.
8589         (nto_procfs_target::pid_to_str): Change return type.
8590         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8591         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8592         return type.
8593         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8594         (exit_lwp): Update.
8595         (attach_proc_task_lwp_callback, get_detach_signal)
8596         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8597         (linux_nat_target::resume, wait_lwp, stop_callback)
8598         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8599         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8600         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8601         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8602         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8603         type.
8604         (inf_ptrace_target::attach): Update.
8605         (inf_ptrace_target::files_info): Update.
8606         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8607         type.
8608         (go32_nat_target::pid_to_str): Change return type.
8609         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8610         (gnu_nat_target::wait): Update.
8611         (gnu_nat_target::wait): Update.
8612         (gnu_nat_target::resume): Update.
8613         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8614         (fbsd_nat_target::wait): Update.
8615         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8616         type.
8617         (darwin_nat_target::attach): Update.
8618         * corelow.c (class core_target) <pid_to_str>: Change return type.
8619         (core_target::pid_to_str): Change return type.
8620         * target.c (normal_pid_to_str): Change return type.
8621         (default_pid_to_str): Likewise.
8622         (target_pid_to_str): Change return type.
8623         (target_translate_tls_address): Update.
8624         (target_announce_detach): Update.
8625         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8626         return type.
8627         (bsd_uthread_target::pid_to_str): Change return type.
8628         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8629         type.
8630         (bsd_kvm_target::pid_to_str): Change return type.
8631         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8632         return type.
8633         (aix_thread_target::pid_to_str): Change return type.
8634         * target.h (struct target_ops) <pid_to_str>: Change return type.
8635         (target_pid_to_str, normal_pid_to_str): Likewise.
8636         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8637         type.
8638         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8639         type.
8640         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8641         return type.
8642         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8643         type.
8644         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8645         type.
8646         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8647         return type.
8648
8649 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8650
8651         * NEWS: Mention that the new default MI version is 3.  Mention
8652         changes to the output of commands and events that deal with
8653         multi-location breakpoints.
8654         * breakpoint.c: Include "mi/mi-out.h".
8655         (print_one_breakpoint): Change output syntax if using MI version
8656         >= 3.
8657         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8658         New.
8659         (mi_multi_location_breakpoint_output_fixed): New.
8660         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8661         (mi_cmd_fix_multi_location_breakpoint_output): New.
8662         (mi_multi_location_breakpoint_output_fixed): New.
8663         * mi/mi-cmds.c (mi_cmds): Register command
8664         -fix-multi-location-breakpoint-output.
8665         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8666         interpreter "mi".
8667
8668 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8669
8670         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8671         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8672         instantiate mi_ui_out based on interpreter name.
8673         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8674         * mi/mi-main.c (mi_load_progress): Likewise.
8675
8676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8677
8678         * NEWS: Combine separate "New targets" sections for 8.3.
8679
8680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8681
8682         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8683         (ppcfbsd_init_abi): Install gdbarch
8684         "fetch_tls_load_module_address" and "get_thread_local_address"
8685         methods.
8686
8687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8688
8689         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8690         (riscv_fbsd_init_abi): Install gdbarch
8691         "fetch_tls_load_module_address" and "get_thread_local_address"
8692         methods.
8693
8694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8695
8696         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8697         (i386fbsd_init_abi): Install gdbarch
8698         "fetch_tls_load_module_address" and "get_thread_local_address"
8699         methods.
8700
8701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8702
8703         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8704         (amd64fbsd_init_abi): Install gdbarch
8705         "fetch_tls_load_module_address" and "get_thread_local_address"
8706         methods.
8707
8708 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8709
8710         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8711         (struct fbsd_pspace_data): New type.
8712         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8713         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8714         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8715         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8716         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8717
8718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8719
8720         * gdbtypes.c (lookup_struct_elt): New function.
8721         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8722         * gdbtypes.h (struct struct_elt): New type.
8723         (lookup_struct_elt): New prototype.
8724
8725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8726
8727         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8728         remove disabled code block.
8729
8730 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8731
8732         * gdbarch.sh (get_thread_local_address): New method.
8733         * gdbarch.h, gdbarch.c: Regenerate.
8734         * target.c (target_translate_tls_address): Use
8735         gdbarch_get_thread_local_address if present instead of
8736         target::get_thread_local_address.
8737
8738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8739
8740         * target.h (target::get_thread_local_address): Update comment.
8741
8742 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8743
8744         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8745         objfile->separate_debug_objfile_backlink if not NULL.
8746
8747 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8748
8749         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8750         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8751         (amd64bsd_store_inferior_registers): Likewise.
8752         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8753         Enable segment base registers.
8754         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8755         PT_GETFSBASE and PT_GETGSBASE.
8756         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8757         PT_SETGSBASE.
8758         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8759         segment base registers.
8760         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8761
8762 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8763
8764         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8765         Update calls to i386_target_description to add 'segments'
8766         parameter.
8767         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8768         add segment base registers.
8769         * arch/i386.c (i386_create_target_description): Add 'segments'
8770         parameter to enable segment base registers.
8771         * arch/i386.h (i386_create_target_description): Likewise.
8772         * features/i386/32bit-segments.xml: New file.
8773         * features/i386/32bit-segments.c: Generate.
8774         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8775         call to i386_target_description to add 'segments' parameter.
8776         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8777         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8778         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8779         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8780         if feature is present.
8781         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8782         Add 'segments' parameter to call to i386_target_description.
8783         (i386_target_description): Add 'segments' parameter to enable
8784         segment base registers.
8785         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8786         to call to i386_target_description.
8787         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8788         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8789         Define I386_NUM_REGS.
8790         (i386_target_description): Add 'segments' parameter to enable
8791         segment base registers.
8792
8793 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8794
8795         PR/24325
8796         * source-cache.c: #undef open and close, to avoid unresolved
8797         externals during linking.
8798
8799 2019-03-12  Tom Tromey  <tromey@adacore.com>
8800
8801         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8802         const.  Add initializers.
8803         (_initialize_remote): Don't initialize ptid globals.
8804
8805 2019-03-12  Pedro Alves  <palves@redhat.com>
8806
8807         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8808
8809 2019-03-12  Pedro Alves  <palves@redhat.com>
8810
8811         * cp-name-parser.y (main): Remove unused 'len' variable.
8812
8813 2019-03-12  Tom Tromey  <tromey@adacore.com>
8814
8815         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8816         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8817
8818 2019-03-12  Tom Tromey  <tromey@adacore.com>
8819
8820         * linux-nat.c (iterate_over_lwps): Update.
8821         (stop_callback): Remove parameter.
8822         (stop_wait_callback, detach_callback, resume_set_callback)
8823         (select_singlestep_lwp_callback, set_ignore_sigint)
8824         (status_callback, resumed_callback, resume_clear_callback)
8825         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8826         data parameter.
8827         (linux_nat_target::detach, linux_nat_target::resume)
8828         (linux_stop_and_wait_all_lwps, select_event_lwp)
8829         (linux_nat_filter_event, linux_nat_wait_1)
8830         (linux_nat_target::kill, linux_nat_target::stop)
8831         (linux_nat_target::stop): Update.
8832         (linux_nat_resume_callback): Change type.
8833         (resume_stopped_resumed_lwps, count_events_callback)
8834         (select_event_lwp_callback): Likewise.
8835         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8836         * arm-linux-nat.c (struct update_registers_data): Remove.
8837         (update_registers_callback): Change type.
8838         (arm_linux_insert_hw_breakpoint1): Update.
8839         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8840         parameter.
8841         (x86_linux_dr_set_addr): Update.
8842         (x86_linux_dr_set_control): Update.
8843         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8844         (iterate_over_lwps): Use gdb::function_view.
8845         * nat/aarch64-linux-hw-point.c (struct
8846         aarch64_dr_update_callback_param): Remove.
8847         (debug_reg_change_callback): Change type.
8848         (aarch64_notify_debug_reg_change): Update.
8849         * s390-linux-nat.c (s390_refresh_per_info): Update.
8850
8851 2019-03-11  Tom Tromey  <tromey@adacore.com>
8852
8853         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8854         redundant assignment to "this_cu".
8855
8856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8857
8858         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8859
8860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8861
8862         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8863         from...
8864         (rank_one_type): ... this.
8865
8866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8867
8868         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8869         from...
8870         (rank_one_type): ... this.
8871
8872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8873
8874         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8875         from...
8876         (rank_one_type): ... this.
8877
8878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8879
8880         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8881         from...
8882         (rank_one_type): ... this.
8883
8884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8885
8886         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8887         from...
8888         (rank_one_type): ... this.
8889
8890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8891
8892         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8893         from...
8894         (rank_one_type): ... this.
8895
8896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8897
8898         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8899         from...
8900         (rank_one_type): ... this.
8901
8902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8903
8904         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8905         from...
8906         (rank_one_type): ... this.
8907
8908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8909
8910         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8911         from...
8912         (rank_one_type): ... this.
8913
8914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8915
8916         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8917         from...
8918         (rank_one_type): ... this.
8919
8920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8921
8922         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8923         from...
8924         (rank_one_type): ... this.
8925
8926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8927
8928         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8929         from...
8930         (rank_one_type): ... this.
8931
8932 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8933
8934         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8935         inferior-events' shows the example events.
8936
8937 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8938
8939         Support styling on native MS-Windows console
8940
8941         PR/24315
8942         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8943         on MS-Windows if $TERM is not defined.
8944
8945         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8946
8947         * posix-hdep.c (gdb_console_fputs):
8948         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8949         functions.
8950         * ui-file.h (gdb_console_fputs): Add prototype.
8951
8952         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8953         back to fputs only if the former returns zero.
8954
8955 2019-03-07  Tom Tromey  <tom@tromey.com>
8956
8957         * symmisc.c (print_symbol_bcache_statistics): Update.
8958         (print_objfile_statistics): Update.
8959         * symfile.c (allocate_symtab): Update.
8960         * stabsread.c: Don't include bcache.h.
8961         * psymtab.h (struct psymbol_bcache): Don't declare.
8962         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8963         (psymbol_bcache_init, psymbol_bcache_free)
8964         (psymbol_bcache_get_bcache): Don't declare.
8965         * psymtab.c (struct psymbol_bcache): Remove.
8966         (psymtab_storage::psymtab_storage): Update.
8967         (psymtab_storage::~psymtab_storage): Update.
8968         (psymbol_bcache_init, psymbol_bcache_free)
8969         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8970         (add_psymbol_to_bcache): Update.
8971         (allocate_psymtab): Update.
8972         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8973         macro_cache>: No longer pointers.
8974         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8975         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8976         * macrotab.c (macro_bcache): Update.
8977         * macroexp.c: Don't include bcache.h.
8978         * gdbtypes.c (check_types_worklist): Update.
8979         (types_deeply_equal): Remove TRY/CATCH.  Update.
8980         * elfread.c (elf_symtab_read): Update.
8981         * dwarf2read.c: Don't include bcache.h.
8982         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8983         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8984         (print_bcache_statistics, bcache_memory_used): Don't declare.
8985         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8986         methods.  Rename all data members.
8987         * bcache.c (struct bcache): Move to bcache.h.
8988         (bcache::expand_hash_table): Rename from expand_hash_table.
8989         (bcache): Remove.
8990         (bcache::insert): Rename from bcache_full.
8991         (bcache::compare): Rename from bcache_compare.
8992         (bcache_xmalloc): Remove.
8993         (bcache::~bcache): Rename from bcache_xfree.
8994         (bcache::print_statistics): Rename from print_bcache_statistics.
8995         (bcache::memory_used): Rename from bcache_memory_used.
8996
8997 2019-03-07  Pedro Alves  <palves@redhat.com>
8998
8999         * infrun.c (normal_stop): Also check for
9000         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9001
9002 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9003
9004         * f-lang.c (value_from_host_double): Moved to...
9005         * value.c (value_from_host_double): ...here.
9006         * value.h (value_from_host_double): Declare.
9007         * guile/scm-math.c (vlscm_convert_typed_number): Use
9008         value_from_host_double.
9009         (vlscm_convert_number): Likewise.
9010         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9011         * python/py-value.c (convert_value_from_python): Likewise.
9012
9013 2019-03-06  Tom Tromey  <tom@tromey.com>
9014
9015         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9016
9017 2019-03-06  Tom Tromey  <tom@tromey.com>
9018
9019         * utils.h (free_current_contents): Don't declare.
9020         * utils.c (free_current_contents): Remove.
9021
9022 2019-03-06  Tom Tromey  <tom@tromey.com>
9023
9024         * top.c (quit_force): Update.
9025         * main.c (captured_command_loop): Update.
9026         * common/new-op.c (operator new): Update.
9027         * common/common-exceptions.c (struct catcher)
9028         <save_cleanup_chain>: Remove member.
9029         (exceptions_state_mc_init): Update.
9030         (exception_try_scope_entry): Return nullptr.
9031         (exception_try_scope_exit, exception_rethrow)
9032         (throw_exception_sjlj, throw_exception_cxx): Update.
9033         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9034         (all_cleanups, do_cleanups, discard_cleanups)
9035         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9036         (restore_cleanups, restore_final_cleanups): Don't declare.
9037         (do_final_cleanups): Remove parameter.
9038         * common/cleanups.c (cleanup_chain, make_cleanup)
9039         (make_cleanup_dtor, all_cleanups, do_cleanups)
9040         (discard_my_cleanups, discard_cleanups)
9041         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9042         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9043         (null_cleanup): Remove.
9044         (do_final_cleanups): Remove parameter.
9045
9046 2019-03-06  Tom Tromey  <tom@tromey.com>
9047
9048         * remote.c (remote_target::remote_parse_stop_reply): Use
9049         unique_xmalloc_ptr.
9050
9051 2019-03-06  Tom Tromey  <tom@tromey.com>
9052
9053         * stabsread.c (struct stabs_field_info): Rename from field_info.
9054         <list, fnlist>: Add initializers.
9055         <obstack>: New member.
9056         (read_member_functions, read_struct_fields, read_baseclasses):
9057         Allocate on obstack.  Don't use cleanups.
9058         (read_one_struct_field, read_member_functions, read_struct_fields)
9059         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9060         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9061         (read_struct_type): Update.
9062
9063 2019-03-06  Tom Tromey  <tom@tromey.com>
9064
9065         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9066         * common/filestuff.h (make_cleanup_close): Don't declare.
9067         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9068         Remove.
9069
9070 2019-03-06  Tom Tromey  <tom@tromey.com>
9071
9072         * solib-aix.c: Use make_scope_exit.
9073
9074 2019-03-06  Tom Tromey  <tom@tromey.com>
9075
9076         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9077         Use make_scope_exit.
9078
9079 2019-03-06  Tom Tromey  <tom@tromey.com>
9080
9081         * solib-svr4.c (disable_probes_interface): Remove parameter.
9082         (svr4_handle_solib_event): Use make_scope_exit.
9083
9084 2019-03-06  Tom Tromey  <tom@tromey.com>
9085
9086         * remote.c (struct stop_reply_deleter): Remove.
9087         (stop_reply_up): Update.
9088         (struct stop_reply): Derive from notif_event.  Don't typedef.
9089         <regcache>: Now a std::vector.
9090         (stop_reply_xfree): Remove.
9091         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9092         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9093         (remote_target::discard_pending_stop_replies): Use delete.
9094         (remote_target::remote_parse_stop_reply): Update.
9095         (remote_target::process_stop_reply): Update.
9096         * remote-notif.h (struct notif_event): Add virtual destructor.
9097         Remove "dtr" member.
9098         (struct notif_client) <alloc_event>: Return a unique_ptr.
9099         (notif_event_xfree): Don't declare.
9100         (notif_event_up): New typedef.
9101         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9102         (notif_event_xfree, do_notif_event_xfree): Remove.
9103         (remote_notif_state_xfree): Update.
9104
9105 2019-03-06  Tom Tromey  <tom@tromey.com>
9106
9107         * infrun.c (displaced_step_clear_cleanup): Now a
9108         forward_scope_exit type.
9109         (displaced_step_prepare_throw): Update.
9110         (displaced_step_fixup): Update.
9111
9112 2019-03-06  Tom Tromey  <tom@tromey.com>
9113
9114         * inferior.h (class inferior): Update comment.
9115         * gdbthread.h (class thread_info): Update comment.
9116
9117 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9118             Tom Tromey  <tom@tromey.com>
9119
9120         * stabsread.h (struct stab_section_list): Remove.
9121         (coffstab_build_psymtabs): Update.
9122         * dbxread.c (symbuf_sections): Now a std::vector.
9123         (sect_idx): New global.
9124         (fill_symbuf): Update.
9125         (coffstab_build_psymtabs): Change type of stabsects parameter.
9126         Update.
9127         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9128         std::vector.
9129         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9130         (coff_locate_sections): Update.
9131         (coff_symfile_read): Remove cleanups.  Update.
9132         (init_stringtab): Add storage parameter.
9133         (free_stringtab, free_stringtab_cleanup): Remove.
9134         (init_lineno): Add storage parameter.
9135         (free_linetab, free_linetab_cleanup): Remove.
9136
9137 2019-03-06  Pedro Alves  <palves@redhat.com>
9138
9139         * linux-fork.c (fork_info::clobber_regs): Delete.
9140         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9141         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9142         comment.  Adjust.
9143         (scoped_switch_fork_info::scoped_switch_fork_info)
9144         (checkpoint_command, linux_fork_context): Adjust
9145         fork_save_infrun_state calls.
9146
9147 2019-03-06  Pedro Alves  <palves@redhat.com>
9148
9149         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9150         (inf_has_multiple_threads): Return 'bool' and rewrite using
9151         inferior_info::threads().
9152
9153 2019-03-06  Pedro Alves  <palves@redhat.com>
9154
9155         * linux-fork.c: Include <list>.
9156         (fork_list): Now a std::list instance.
9157         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9158         (forks_exist_p, find_last_fork): Adjust.
9159         (new_fork): Delete.
9160         (one_fork_p): New.
9161         (add_fork): Adjust.
9162         (free_fork): Delete, folded into fork_info::~fork_info().
9163         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9164         Adjust.
9165         (init_fork_list): Delete.
9166         (linux_fork_killall, linux_fork_mourn_inferior)
9167         (linux_fork_detach, info_checkpoints_command): Adjust.
9168         (_initialize_linux_fork): No longer call init_fork_list.
9169
9170 2019-03-06  Pedro Alves  <palves@redhat.com>
9171
9172         * linux-fork.c (new_fork): New, split out of ...
9173         (add_fork): ... this.  Return void.  Move "first fork" special
9174         case from here, to ...
9175         (checkpoint_command): ... here.
9176         * linux-linux.h (add_fork): Return void.
9177
9178 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9179
9180         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9181
9182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9183             Chris January  <chris.january@arm.com>
9184             David Lecomber  <david.lecomber@arm.com>
9185
9186         * f-exp.y: New token, UNOP_INTRINSIC.
9187         (exp): New pattern using UNOP_INTRINSIC token.
9188         (f77_keywords): Add 'abs' keyword.
9189         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9190         (value_from_host_double): New function.
9191         (evaluate_subexp_f): Support UNOP_ABS.
9192
9193 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9194
9195         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9196         types.
9197
9198 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9201         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9202         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9203
9204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9205
9206         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9207
9208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9209             Chris January  <chris.january@arm.com>
9210
9211         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9212         * f-exp.y: Define 'KIND' token.
9213         (exp): New pattern for KIND expressions.
9214         (ptype): Handle types with a kind extension.
9215         (direct_abs_decl): Extend to spot kind extensions.
9216         (f77_keywords): Add 'kind' to the list.
9217         (push_kind_type): New function.
9218         (convert_to_kind_type): New function.
9219         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9220         * parse.c (operator_length_standard): Likewise.
9221         * parser-defs.h (enum type_pieces): Add tp_kind.
9222         * std-operator.def: Add UNOP_KIND.
9223
9224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * f-exp.y (f_parse): Set yydebug.
9227
9228 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9229
9230         * f-lang.c (evaluate_subexp_f): New function.
9231         (exp_descriptor_f): New global.
9232         (f_language_defn): Use exp_descriptor_f instead of
9233         exp_descriptor_standard.
9234
9235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * f-exp.y (struct token): Add comments.
9238         (dot_ops): Remove uppercase versions and the end marker.
9239         (f77_keywords): Likewise.
9240         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9241         entries in the dot_ops array are case insensitive, and use
9242         strncasecmp to compare strings.  Also some whitespace cleanup in
9243         this area.  Similar for the f77_keywords array, except entries in
9244         this list might be case sensitive.
9245
9246 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9247
9248         * f-exp.y (struct f77_boolean_val): Add comments.
9249         (boolean_values): Remove uppercase versions, and end marker.
9250         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9251         and use strncasecmp to achieve case insensitivity.  Additionally,
9252         perform whitespace cleanup around this code.
9253
9254 2019-03-06  Tom Tromey  <tromey@adacore.com>
9255
9256         * remote-sim.c (gdbsim_target_open): Use result of
9257         gdb_argv::release.
9258
9259 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9260         Dirk Schubert  <dirk.schubert@arm.com>
9261         Chris January  <chris.january@arm.com>
9262
9263         * eval.c (evaluate_subexp_standard): Call Fortran argument
9264         wrapping logic.
9265         * f-lang.c (struct value): A value which can be passed into a
9266         Fortran function call.
9267         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9268         where appropriate.
9269         (struct type): Value ready for a Fortran function call.
9270         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9271         is needed.
9272         * f-lang.h (fortran_argument_convert): Declaration.
9273         (fortran_preserve_arg_pointer): Declaration.
9274         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9275
9276 2019-03-05  Tom Tromey  <tromey@adacore.com>
9277
9278         * python/py-prettyprint.c (print_string_repr): Remove #if.
9279         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9280
9281 2019-03-05  Tom Tromey  <tromey@adacore.com>
9282
9283         * target.c (the_dummy_target): Move later.  Change type to
9284         "dummy_target".
9285         (initialize_targets): Don't initialize the_dummy_target.
9286
9287 2019-03-05  Tom Tromey  <tromey@adacore.com>
9288
9289         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9290         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9291
9292 2019-03-05  Tom Tromey  <tromey@adacore.com>
9293
9294         * windows-nat.c (windows_nat_target::attach)
9295         (windows_nat_target::detach): Don't call gdb_flush.
9296         * valprint.c (generic_val_print, val_print, val_print_string):
9297         Don't call gdb_flush.
9298         * utils.c (defaulted_query): Don't call gdb_flush.
9299         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9300         * target.c (target_announce_detach): Don't call gdb_flush.
9301         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9302         * remote.c (extended_remote_target::attach): Don't call
9303         gdb_flush.
9304         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9305         * printcmd.c (do_examine): Don't call gdb_flush.
9306         (info_display_command): Don't call gdb_flush.
9307         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9308         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9309         * memattr.c (info_mem_command): Don't call gdb_flush.
9310         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9311         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9312         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9313         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9314         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9315         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9316         (gnu_nat_target::detach): Don't call gdb_flush.
9317         * f-valprint.c (f_val_print): Don't call gdb_flush.
9318         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9319         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9320         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9321         gdb_flush.
9322         * c-valprint.c (c_val_print): Don't call gdb_flush.
9323         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9324
9325 2019-03-05  Tom Tromey  <tromey@adacore.com>
9326
9327         * varobj.c (update_dynamic_varobj_children): Update.
9328         (install_default_visualizer): Use reset, not release.
9329         * value.c (set_internalvar): Update.
9330         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9331         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9332         ATTRIBUTE_UNUSED_RESULT.
9333
9334 2019-03-05  Tom Tromey  <tromey@adacore.com>
9335
9336         * remote.c (class scoped_remote_fd) <release>: Add
9337         ATTRIBUTE_UNUSED_RESULT.
9338
9339 2019-03-05  Tom Tromey  <tromey@adacore.com>
9340
9341         * macroexp.c (struct macro_buffer) <release>: Add
9342         ATTRIBUTE_UNUSED_RESULT.
9343
9344 2019-03-05  Tom Tromey  <tromey@adacore.com>
9345
9346         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9347         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9348         ATTRIBUTE_UNUSED_RESULT.
9349
9350 2019-03-05  Tom Tromey  <tromey@adacore.com>
9351
9352         * common/scoped_fd.h (class scoped_fd) <release>: Add
9353         ATTRIBUTE_UNUSED_RESULT.
9354
9355 2019-03-05  Tom Tromey  <tromey@adacore.com>
9356
9357         * parser-defs.h (struct parser_state) <release>: Add
9358         ATTRIBUTE_UNUSED_RESULT.
9359
9360 2019-03-05  Tom Tromey  <tromey@adacore.com>
9361
9362         * utils.h (class gdb_argv) <release>: Add
9363         ATTRIBUTE_UNUSED_RESULT.
9364         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9365
9366 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9367
9368         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9369         for-loop range, to avoid compiler warnings.
9370
9371         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9372         avoid compiler warnings about unused variables.
9373
9374         * NEWS: Mention end of support for native debugging on MS-Windows
9375         before XP.
9376
9377         PR gdb/24292
9378         * common/netstuff.c:
9379         * gdbserver/gdbreplay.c
9380         * gdbserver/remote-utils.c:
9381         * ser-tcp.c:
9382         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9383         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9384         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9385         'getaddrinfo' and 'freeaddrinfo' were not available before
9386         Windows XP, and mingw.org's MinGW headers by default define
9387         _WIN32_WINNT to 0x500.
9388
9389 2019-03-01  Gary Benson <gbenson@redhat.com>
9390
9391         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9392
9393 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9394             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9395
9396         PR gdb/8527
9397         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9398         set_sigint_trap, clear_sigint_trap.
9399
9400 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9401
9402         * target.c (target_detach): Clear the regcache and the
9403         frame cache.
9404
9405 2019-02-27  Pedro Alves  <palves@redhat.com>
9406
9407         * utils.c (set_screen_size): When we cap the height/width sizes,
9408         tweak the corresponding command variable to show "unlimited":
9409
9410 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9411             Pedro Alves  <palves@redhat.com>
9412
9413         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9414         before calling rl_set_screen_size.
9415
9416 2019-02-27  Tom Tromey  <tromey@adacore.com>
9417
9418         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9419         define.
9420         * python/py-value.c: Remove Python 2.4 workaround.
9421         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9422         workaround.
9423         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9424         Python 2.4 workaround.
9425         * python/python-internal.h: Remove Python 2.4 comment.
9426         (Py_ssize_t): Don't define.
9427         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9428         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9429         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9430         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9431         * python/python.c (do_start_initialization): Remove Python 2.4
9432         workaround.
9433         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9434         (print_children): Remove Python 2.4 workaround.
9435         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9436         workaround.
9437         (CHARBUFFERPROC_NAME): Remove.
9438         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9439         Python 2.4 workaround.
9440
9441 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9442
9443         * NEWS: Note minimum Python version.
9444
9445 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9446
9447         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9448         code from these functions.  Remove corresponding ifdefs.  Use
9449         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9450         Remove gotos and target of gotos.
9451         (infpy_search_memory): Likewise.
9452
9453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9454
9455         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9456         (hppa_gdbarch_init): Don't register deleted functions with
9457         gdbarch.
9458
9459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9460
9461         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9462         (h8300_unwind_sp): Delete.
9463         (h8300_dummy_id): Delete.
9464         (h8300_gdbarch_init): Don't register deleted functions with
9465         gdbarch.
9466
9467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9468
9469         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9470         (ft32_unwind_pc): Delete.
9471         (ft32_unwind_sp): Delete.
9472         (ft32_gdbarch_init): Don't register deleted functions with
9473         gdbarch.
9474
9475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9476
9477         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9478         (frv_unwind_pc): Delete.
9479         (frv_unwind_sp): Delete.
9480         (frv_gdbarch_init): Don't register deleted functions with
9481         gdbarch.
9482
9483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9484
9485         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9486         (riscv_unwind_pc): Delete.
9487         (riscv_unwind_sp): Delete.
9488         (riscv_gdbarch_init): Don't register deleted functions with
9489         gdbarch.
9490
9491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9492
9493         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9494         (csky_unwind_pc): Delete.
9495         (csky_unwind_sp): Delete.
9496         (csky_gdbarch_init): Don't register deleted functions with
9497         gdbarch.
9498
9499 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9500
9501         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9502         (cris_unwind_pc): Delete.
9503         (cris_unwind_sp): Delete.
9504         (cris_gdbarch_init): Don't register deleted functions with
9505         gdbarch.
9506
9507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9508
9509         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9510         (bfin_unwind_pc): Delete.
9511         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9512
9513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9516         (arm_unwind_pc): Delete.
9517         (arm_unwind_sp): Delete.
9518         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9519
9520 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9521
9522         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9523         (arc_unwind_pc): Delete.
9524         (arc_unwind_sp): Delete.
9525         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9526
9527 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9528
9529         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9530         (alpha_unwind_pc): Delete.
9531         (alpha_gdbarch_init): Don't register deleted functions with
9532         gdbarch.
9533
9534 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9535
9536         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9537         (aarch64_unwind_pc): Delete.
9538         (aarch64_unwind_sp): Delete.
9539         (aarch64_gdbarch_init): Don't register deleted functions with
9540         gdbarch.
9541
9542 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9543
9544         * gdbtypes.c (type_align): Don't consider static members when
9545         computing structure alignment.
9546
9547 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9548
9549         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9550         return 0 for other types.
9551         * arch-utils.c (default_type_align): Always return 0.
9552         * gdbarch.h: Regenerate.
9553         * gdbarch.sh (type_align): Extend comment.
9554         * gdbtypes.c (type_align): Add additional comments, always call
9555         gdbarch_type_align before applying the default rules.
9556         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9557         generic code will then apply a suitable default.
9558         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9559         types, return 0 for other types.
9560
9561 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9562
9563         * NEWS: Create a new section for the next release branch.
9564         Rename the section of the current branch, now that it has
9565         been cut.
9566
9567 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9568
9569         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9570         * version.in: Bump version to 8.3.50.DATE-git.
9571
9572 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9573
9574         * aix-thread.c (ptid_cmp): Remove unused variable.
9575         (get_signaled_thread): Likewise.
9576         (store_regs_user_thread): Likewise.
9577         (store_regs_kernel_thread): Likewise.
9578         (fetch_regs_kernel_thread): Remove shadowed variable.
9579
9580 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9581
9582         * features/riscv/32bit-cpu.xml: Add register numbers.
9583         * features/riscv/32bit-fpu.c: Regenerate.
9584         * features/riscv/32bit-fpu.xml: Add register numbers.
9585         * features/riscv/64bit-cpu.xml: Add register numbers.
9586         * features/riscv/64bit-fpu.c: Regenerate.
9587         * features/riscv/64bit-fpu.xml: Add register numbers.
9588
9589 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9590
9591         * NEWS: Mention two argument form of gdb.Value constructor.
9592         * python/py-value.c (convert_buffer_and_type_to_value): New
9593         function.
9594         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9595         Add support for handling an optional second argument.  Call
9596         convert_buffer_and_type_to_value as appropriate.
9597         * python/python-internal.h (Py_buffer_deleter): New struct.
9598         (Py_buffer_up): New typedef.
9599
9600 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9601
9602         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9603         instead of releasing ownership.
9604
9605 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9606
9607         * dwarf2read.c (open_and_init_dwp_file): Call
9608         elf_numsections instead of bfd_count_sections to initialize
9609         dwp_file->num_sections.
9610
9611 2019-02-25  Tom Tromey  <tromey@adacore.com>
9612
9613         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9614
9615 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9616
9617         * gcore.in: Add '--readnever' option when invoking GDB.
9618
9619 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9620
9621         * MAINTAINERS: Update my email address.
9622
9623 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9624
9625         * build-id.c (build_id_to_debug_bfd_1): New function.
9626         (build_id_to_debug_bfd): Look for separate debug file in
9627         sysroot.
9628
9629 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9630
9631         * gdbarch.sh: Update the copyright year range that is placed into
9632         generated files.
9633
9634 2019-02-22  Keith Seitz  <keiths@redhat.com>
9635
9636         PR symtab/23853
9637         * linespec.c (create_sals_line_offset): Search for the default
9638         symtab's filename instead of its fullname.
9639
9640 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9641
9642         * NEWS: Update style defaults.
9643
9644 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9645
9646         * main.c (captured_main_1): Disable styling in batch mode.
9647
9648 2019-02-20  Tom Tromey  <tom@tromey.com>
9649
9650         * symtab.c (symtab_symbol_info): Fix typos.
9651
9652 2019-02-20  Tom Tromey  <tromey@adacore.com>
9653
9654         * findcmd.c (_initialize_mem_search): Use upper case for
9655         metasyntactic variables.
9656
9657 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9658
9659         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9660         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9661
9662 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9663
9664         * top.h (source_file_name): Change to std::string.
9665         * top.c (source_file_name): Likewise.
9666         (command_line_input): Adjust.
9667         * cli/cli-script.c (script_from_file): Adjust.
9668
9669 2019-02-19  Tom Tromey  <tromey@adacore.com>
9670
9671         * ravenscar-thread.c
9672         (ravenscar_thread_target::update_thread_list): Don't call
9673         ada_build_task_list.
9674         * ada-lang.h (ada_build_task_list): Don't declare.
9675         * ada-tasks.c (struct ada_tasks_inferior_data)
9676         <task_list_valid_p>: Now bool.
9677         (read_known_tasks, ada_task_list_changed)
9678         (ada_tasks_invalidate_inferior_data): Update.
9679         (read_known_tasks_array): Return bool.
9680         (read_known_tasks_list): Likewise.
9681         (read_known_tasks): Return void.
9682         (ada_build_task_list): Now static.
9683
9684 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9685
9686         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9687         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9688
9689 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9690
9691         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9692         variant for ada_tasks_pspace_data_handle and
9693         ada_tasks_inferior_data_handle.
9694         (ada_tasks_pspace_data_cleanup): New function.
9695         (ada_tasks_inferior_data_cleanup): New function.
9696
9697 2019-02-17  Tom Tromey  <tom@tromey.com>
9698
9699         * macrotab.h (macro_source_fullname): Return a std::string.
9700         * macrotab.c (macro_include, check_for_redefinition)
9701         (macro_undef, macro_lookup_definition, foreach_macro)
9702         (foreach_macro_in_scope): Update.
9703         (macro_source_fullname): Return a std::string.
9704         * macrocmd.c (show_pp_source_pos): Update.
9705
9706 2019-02-17  Tom Tromey  <tom@tromey.com>
9707
9708         * macrocmd.c (show_pp_source_pos): Style the file names.
9709
9710 2019-02-17  Tom Tromey  <tom@tromey.com>
9711
9712         PR tui/24197:
9713         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9714
9715 2019-02-17  Tom Tromey  <tom@tromey.com>
9716
9717         * ada-lang.c (user_select_syms): Use filtered printing.
9718         * utils.c (wrap_style): New global.
9719         (desired_style): Remove.
9720         (emit_style_escape): Add stream parameter.
9721         (set_output_style, reset_terminal_style, prompt_for_continue):
9722         Update.
9723         (flush_wrap_buffer): Only flush gdb_stdout.
9724         (wrap_here): Set wrap_style.
9725         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9726         treat escape sequences as a character.  Change when wrap buffer is
9727         flushed.
9728         (fputs_styled): Do not set the output style when the default is
9729         requested.
9730         * ui-style.h (struct ui_file_style) <is_default>: New method.
9731         * source.c (print_source_lines_base): Emit escape sequences in one
9732         piece.
9733
9734 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9735
9736         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9737         integers and enumeration types.
9738
9739 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9740
9741         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9742         instead of lookup_symbol_in_language
9743         (do_exact_match): New function.
9744         (ada_get_symbol_name_matcher): Return do_exact_match when
9745         doing a verbatim match.
9746
9747 2019-02-15  Tom Tromey  <tromey@adacore.com>
9748
9749         * ravenscar-thread.c (ravenscar_thread_target::resume)
9750         (ravenscar_thread_target::wait): Special case wildcard requests.
9751
9752 2019-02-15  Tom Tromey  <tromey@adacore.com>
9753
9754         * ravenscar-thread.c (base_ptid): Remove.
9755         (struct ravenscar_thread_target) <close>: New method.
9756         <m_base_ptid>: New member.
9757         <update_inferior_ptid, active_task, task_is_currently_active,
9758         runtime_initialized>: Declare methods.
9759         <ravenscar_thread_target>: Add constructor.
9760         (ravenscar_thread_target::task_is_currently_active)
9761         (ravenscar_thread_target::update_inferior_ptid)
9762         (ravenscar_runtime_initialized): Rename.  Now methods.
9763         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9764         (ravenscar_thread_target::update_thread_list): Update.
9765         (ravenscar_thread_target::active_task): Now method.
9766         (ravenscar_thread_target::store_registers)
9767         (ravenscar_thread_target::prepare_to_store)
9768         (ravenscar_thread_target::prepare_to_store)
9769         (ravenscar_thread_target::mourn_inferior): Update.
9770         (ravenscar_inferior_created): Use "new" to create target.
9771         (ravenscar_thread_target::get_ada_task_ptid): Update.
9772         (_initialize_ravenscar): Don't initialize base_ptid.
9773         (ravenscar_ops): Remove global.
9774
9775 2019-02-15  Tom Tromey  <tromey@adacore.com>
9776
9777         * target.h (push_target): Declare new overload.
9778         * target.c (push_target): New overload, taking an rvalue reference.
9779         * remote.c (remote_target::open_1): Use push_target overload.
9780         * corelow.c (core_target_open): Use push_target overload.
9781
9782 2019-02-15  Tom Tromey  <tromey@adacore.com>
9783
9784         * ravenscar-thread.c (is_ravenscar_task)
9785         (ravenscar_task_is_currently_active): Return bool.
9786         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9787         (_initialize_ravenscar): Remove "(void)".
9788         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9789         Return bool.
9790
9791 2019-02-15  Tom Tromey  <tromey@adacore.com>
9792
9793         * ravenscar-thread.c (ravenscar_runtime_initializer)
9794         (has_ravenscar_runtime, get_running_thread_id)
9795         (ravenscar_thread_target::resume): Fix indentation.
9796
9797 2019-02-15  Tom Tromey  <tromey@adacore.com>
9798
9799         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9800         from ravenscar_arch_ops.
9801         (sparc_ravenscar_ops::fetch_registers)
9802         (sparc_ravenscar_ops::store_registers): Now methods.
9803         (sparc_ravenscar_prepare_to_store): Remove.
9804         (sparc_ravenscar_ops): Redefine.
9805         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9806         methods and destructor.  Remove members.
9807         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9808         (ravenscar_thread_target::store_registers)
9809         (ravenscar_thread_target::prepare_to_store): Update.
9810         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9811         Remove.
9812         (struct ppc_ravenscar_powerpc_ops): Derive from
9813         ravenscar_arch_ops.
9814         (ppc_ravenscar_powerpc_ops::fetch_registers)
9815         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9816         (ppc_ravenscar_powerpc_ops): Redefine.
9817         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9818         (ppc_ravenscar_e500_ops::fetch_registers)
9819         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9820         (ppc_ravenscar_e500_ops): Redefine.
9821         * aarch64-ravenscar-thread.c
9822         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9823         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9824         (aarch64_ravenscar_fetch_registers)
9825         (aarch64_ravenscar_store_registers): Now methods.
9826         (aarch64_ravenscar_ops): Redefine.
9827
9828 2019-02-15  Tom Tromey  <tromey@adacore.com>
9829
9830         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9831         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9832         (ravenscar_thread_target::stopped_by_watchpoint)
9833         (ravenscar_thread_target::stopped_data_address)
9834         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9835
9836 2019-02-15  Tom Tromey  <tromey@adacore.com>
9837
9838         * ravenscar-thread.c: Fix some typos.
9839
9840 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9841             Tom Tromey  <tromey@adacore.com>
9842
9843         * ada-lang.c (ada_exception_sal): Change addr_string to a
9844         std::string.
9845         (create_ada_exception_catchpoint): Update.
9846
9847 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9848             Tom Tromey  <tromey@adacore.com>
9849
9850         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9851         (bp_location_ops): Remove.
9852         (base_breakpoint_allocate_location): Update.
9853         (free_bp_location): Update.
9854         * ada-lang.c (class ada_catchpoint_location)
9855         <ada_catchpoint_location>: Remove ops parameter.
9856         (ada_catchpoint_location_dtor): Remove.
9857         (ada_catchpoint_location_ops): Remove.
9858         (allocate_location_exception): Update.
9859         * breakpoint.h (struct bp_location_ops): Remove.
9860         (class bp_location) <bp_location>: Remove bp_location_ops
9861         parameter.
9862         <~bp_location>: Add destructor.
9863         <ops>: Remove.
9864
9865 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9866             Pedro Alves  <palves@redhat.com>
9867
9868         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9869         'PATH_MAX'.
9870
9871 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9872             Samuel Thibault  <samuel.thibault@gnu.org>
9873             Thomas Schwinge  <thomas@codesourcery.com>
9874
9875         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9876         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9877
9878 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9879
9880         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9881         (check_empty): Use "const char *".
9882
9883         * gnu-nat.c (gnu_nat_target::detach): Instead of
9884         'detach_inferior (pid)' call
9885         'detach_inferior (find_inferior_pid (pid))'.
9886
9887         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9888         'nat/fork-inferior.o'.
9889         * gnu-nat.c: #include "nat/fork-inferior.h".
9890
9891         * gnu-nat.c (gnu_nat_target::detach): Instead of
9892         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9893         * gnu-nat.h: #include "inf-child.h".
9894         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9895         'i386_gnu_nat_target::fetch_registers'.
9896         (gnu_store_registers): Rename/move to
9897         'i386_gnu_nat_target::store_registers'.
9898
9899         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9900         * gnu-nat.h (mach_thread_info): New function.
9901         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9902
9903         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9904
9905 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9906
9907         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9908
9909 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9910
9911         * windows-nat.c (windows_add_thread): Add new parameter
9912         "main_thread_p" with default value set to false.  Update
9913         function documentation as well as all callers.
9914         (windows_delete_thread): Likewise.
9915         (fake_create_process): Update call to windows_add_thread.
9916         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9917         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9918         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9919         call to windows_delete_thread.
9920
9921 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9922
9923         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9924
9925 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9926
9927         * symfile.c (find_separate_debug_file): Use canonical path of
9928         sysroot with child_path instead of gdb_sysroot if it is valid.
9929
9930 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9931
9932         * symfile.c (find_separate_debug_file): Use child_path to
9933         determine if an object file is under a sysroot.
9934
9935 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9936
9937         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9938         unittests/child-path-selftests.c.
9939         * common/pathstuff.c (child_path): New function.
9940         * common/pathstuff.h (child_path): New prototype.
9941         * unittests/child-path-selftests.c: New file.
9942
9943 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9944
9945         * symfile.c (find_separate_debug_file): Look for separate debug
9946         files in debug directories under the sysroot.
9947
9948 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9949
9950         * symtab.h (struct minimal_symbol data_p): New const method.
9951         (struct minimal_symbol text_p): Likewise.
9952         * symtab.c (output_source_filename): Use file name style
9953         to print file name.
9954         (print_symbol_info): Likewise.
9955         (print_msymbol_info): Use address style to print addresses.
9956         Use function name style to print executable text symbols.
9957         (expand_symtab_containing_pc): Use data_p.
9958         (find_pc_sect_compunit_symtab): Likewise.
9959
9960 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9961
9962         * breakpoint.c (describe_other_breakpoints): Use address style
9963         to print addresses.
9964         (say_where): Likewise.
9965
9966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9967
9968         * ada-typeprint.c (print_func_type): Print function name
9969         style to print function name.
9970         * c-typeprint.c (c_print_type_1): Likewise.
9971
9972 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9973
9974         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9975         for execve.
9976
9977 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9978
9979         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9980         type_stack.
9981
9982 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9983
9984         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9985         TYPE_CODE_REF types.
9986
9987 2019-02-08  Jim Wilson  <jimw@sifive.com>
9988
9989         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9990         (riscv_linux_fregset): New.
9991         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9992
9993 2019-02-07  Tom Tromey  <tom@tromey.com>
9994
9995         * thread.c (thread_cancel_execution_command): Update.
9996         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9997         methods.
9998         (struct thread_fsm_ops): Remove.
9999         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10000         (thread_fsm_should_stop, thread_fsm_return_value)
10001         (thread_fsm_set_finished, thread_fsm_finished_p)
10002         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10003         Don't declare.
10004         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10005         * infrun.c (clear_proceed_status_thread)
10006         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10007         (print_stop_event): Update.
10008         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10009         Add constructor.
10010         (step_command_fsm_ops): Remove.
10011         (new_step_command_fsm): Remove.
10012         (step_1): Update.
10013         (step_command_fsm::should_stop): Rename from
10014         step_command_fsm_should_stop.
10015         (step_command_fsm::clean_up): Rename from
10016         step_command_fsm_clean_up.
10017         (step_command_fsm::do_async_reply_reason): Rename from
10018         step_command_fsm_async_reply_reason.
10019         (struct until_next_fsm): Inherit from thread_fsm.  Add
10020         constructor.
10021         (until_next_fsm_ops): Remove.
10022         (new_until_next_fsm): Remove.
10023         (until_next_fsm::should_stop): Rename from
10024         until_next_fsm_should_stop.
10025         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10026         (until_next_fsm::do_async_reply_reason): Rename from
10027         until_next_fsm_async_reply_reason.
10028         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10029         constructor.  Change type of breakpoint.
10030         (finish_command_fsm_ops): Remove.
10031         (new_finish_command_fsm): Remove.
10032         (finish_command_fsm::should_stop): Rename from
10033         finish_command_fsm_should_stop.
10034         (finish_command_fsm::clean_up): Rename from
10035         finish_command_fsm_clean_up.
10036         (finish_command_fsm::return_value): Rename from
10037         finish_command_fsm_return_value.
10038         (finish_command_fsm::do_async_reply_reason): Rename from
10039         finish_command_fsm_async_reply_reason.
10040         (finish_command): Update.
10041         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10042         Add constructor.
10043         (call_thread_fsm_ops): Remove.
10044         (call_thread_fsm::call_thread_fsm): Rename from
10045         new_call_thread_fsm.
10046         (call_thread_fsm::should_stop): Rename from
10047         call_thread_fsm_should_stop.
10048         (call_thread_fsm::should_notify_stop): Rename from
10049         call_thread_fsm_should_notify_stop.
10050         (run_inferior_call, call_function_by_hand_dummy): Update.
10051         * cli/cli-interp.c (should_print_stop_to_console): Update.
10052         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10053         Add constructor.  Change type of location_breakpoint,
10054         caller_breakpoint.
10055         (until_break_fsm_ops): Remove.
10056         (new_until_break_fsm): Remove.
10057         (until_break_fsm::should_stop): Rename from
10058         until_break_fsm_should_stop.
10059         (until_break_fsm::clean_up): Rename from
10060         until_break_fsm_clean_up.
10061         (until_break_fsm::do_async_reply_reason): Rename from
10062         until_break_fsm_async_reply_reason.
10063         (until_break_command): Update.
10064         * thread-fsm.c: Remove.
10065         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10066
10067 2019-02-07  Tom Tromey  <tom@tromey.com>
10068
10069         * yy-remap.h: Add include guard.
10070         * xtensa-tdep.h: Add include guard.
10071         * xcoffread.h: Rename include guard.
10072         * varobj-iter.h: Add include guard.
10073         * tui/tui.h: Rename include guard.
10074         * tui/tui-winsource.h: Rename include guard.
10075         * tui/tui-wingeneral.h: Rename include guard.
10076         * tui/tui-windata.h: Rename include guard.
10077         * tui/tui-win.h: Rename include guard.
10078         * tui/tui-stack.h: Rename include guard.
10079         * tui/tui-source.h: Rename include guard.
10080         * tui/tui-regs.h: Rename include guard.
10081         * tui/tui-out.h: Rename include guard.
10082         * tui/tui-layout.h: Rename include guard.
10083         * tui/tui-io.h: Rename include guard.
10084         * tui/tui-hooks.h: Rename include guard.
10085         * tui/tui-file.h: Rename include guard.
10086         * tui/tui-disasm.h: Rename include guard.
10087         * tui/tui-data.h: Rename include guard.
10088         * tui/tui-command.h: Rename include guard.
10089         * tic6x-tdep.h: Add include guard.
10090         * target/waitstatus.h: Rename include guard.
10091         * target/wait.h: Rename include guard.
10092         * target/target.h: Rename include guard.
10093         * target/resume.h: Rename include guard.
10094         * target-float.h: Rename include guard.
10095         * stabsread.h: Add include guard.
10096         * rs6000-tdep.h: Add include guard.
10097         * riscv-fbsd-tdep.h: Add include guard.
10098         * regformats/regdef.h: Rename include guard.
10099         * record.h: Rename include guard.
10100         * python/python.h: Rename include guard.
10101         * python/python-internal.h: Rename include guard.
10102         * python/py-stopevent.h: Rename include guard.
10103         * python/py-ref.h: Rename include guard.
10104         * python/py-record.h: Rename include guard.
10105         * python/py-record-full.h: Rename include guard.
10106         * python/py-record-btrace.h: Rename include guard.
10107         * python/py-instruction.h: Rename include guard.
10108         * python/py-events.h: Rename include guard.
10109         * python/py-event.h: Rename include guard.
10110         * procfs.h: Add include guard.
10111         * proc-utils.h: Add include guard.
10112         * p-lang.h: Add include guard.
10113         * or1k-tdep.h: Rename include guard.
10114         * observable.h: Rename include guard.
10115         * nto-tdep.h: Rename include guard.
10116         * nat/x86-linux.h: Rename include guard.
10117         * nat/x86-linux-dregs.h: Rename include guard.
10118         * nat/x86-gcc-cpuid.h: Add include guard.
10119         * nat/x86-dregs.h: Rename include guard.
10120         * nat/x86-cpuid.h: Rename include guard.
10121         * nat/ppc-linux.h: Rename include guard.
10122         * nat/mips-linux-watch.h: Rename include guard.
10123         * nat/linux-waitpid.h: Rename include guard.
10124         * nat/linux-ptrace.h: Rename include guard.
10125         * nat/linux-procfs.h: Rename include guard.
10126         * nat/linux-osdata.h: Rename include guard.
10127         * nat/linux-nat.h: Rename include guard.
10128         * nat/linux-namespaces.h: Rename include guard.
10129         * nat/linux-btrace.h: Rename include guard.
10130         * nat/glibc_thread_db.h: Rename include guard.
10131         * nat/gdb_thread_db.h: Rename include guard.
10132         * nat/gdb_ptrace.h: Rename include guard.
10133         * nat/fork-inferior.h: Rename include guard.
10134         * nat/amd64-linux-siginfo.h: Rename include guard.
10135         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10136         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10137         * nat/aarch64-linux.h: Rename include guard.
10138         * nat/aarch64-linux-hw-point.h: Rename include guard.
10139         * mn10300-tdep.h: Add include guard.
10140         * mips-linux-tdep.h: Add include guard.
10141         * mi/mi-parse.h: Rename include guard.
10142         * mi/mi-out.h: Rename include guard.
10143         * mi/mi-main.h: Rename include guard.
10144         * mi/mi-interp.h: Rename include guard.
10145         * mi/mi-getopt.h: Rename include guard.
10146         * mi/mi-console.h: Rename include guard.
10147         * mi/mi-common.h: Rename include guard.
10148         * mi/mi-cmds.h: Rename include guard.
10149         * mi/mi-cmd-break.h: Rename include guard.
10150         * m2-lang.h: Add include guard.
10151         * location.h: Rename include guard.
10152         * linux-record.h: Rename include guard.
10153         * linux-nat.h: Add include guard.
10154         * linux-fork.h: Add include guard.
10155         * i386-darwin-tdep.h: Rename include guard.
10156         * hppa-linux-offsets.h: Add include guard.
10157         * guile/guile.h: Rename include guard.
10158         * guile/guile-internal.h: Rename include guard.
10159         * gnu-nat.h: Rename include guard.
10160         * gdb-stabs.h: Rename include guard.
10161         * frv-tdep.h: Add include guard.
10162         * f-lang.h: Add include guard.
10163         * event-loop.h: Add include guard.
10164         * darwin-nat.h: Rename include guard.
10165         * cp-abi.h: Rename include guard.
10166         * config/sparc/nm-sol2.h: Rename include guard.
10167         * config/nm-nto.h: Rename include guard.
10168         * config/nm-linux.h: Add include guard.
10169         * config/i386/nm-i386gnu.h: Rename include guard.
10170         * config/djgpp/nl_types.h: Rename include guard.
10171         * config/djgpp/langinfo.h: Rename include guard.
10172         * compile/gcc-cp-plugin.h: Add include guard.
10173         * compile/gcc-c-plugin.h: Add include guard.
10174         * compile/compile.h: Rename include guard.
10175         * compile/compile-object-run.h: Rename include guard.
10176         * compile/compile-object-load.h: Rename include guard.
10177         * compile/compile-internal.h: Rename include guard.
10178         * compile/compile-cplus.h: Rename include guard.
10179         * compile/compile-c.h: Rename include guard.
10180         * common/xml-utils.h: Rename include guard.
10181         * common/x86-xstate.h: Rename include guard.
10182         * common/version.h: Rename include guard.
10183         * common/vec.h: Rename include guard.
10184         * common/tdesc.h: Rename include guard.
10185         * common/selftest.h: Rename include guard.
10186         * common/scoped_restore.h: Rename include guard.
10187         * common/scoped_mmap.h: Rename include guard.
10188         * common/scoped_fd.h: Rename include guard.
10189         * common/safe-iterator.h: Rename include guard.
10190         * common/run-time-clock.h: Rename include guard.
10191         * common/refcounted-object.h: Rename include guard.
10192         * common/queue.h: Rename include guard.
10193         * common/ptid.h: Rename include guard.
10194         * common/print-utils.h: Rename include guard.
10195         * common/preprocessor.h: Rename include guard.
10196         * common/pathstuff.h: Rename include guard.
10197         * common/observable.h: Rename include guard.
10198         * common/netstuff.h: Rename include guard.
10199         * common/job-control.h: Rename include guard.
10200         * common/host-defs.h: Rename include guard.
10201         * common/gdb_wait.h: Rename include guard.
10202         * common/gdb_vecs.h: Rename include guard.
10203         * common/gdb_unlinker.h: Rename include guard.
10204         * common/gdb_unique_ptr.h: Rename include guard.
10205         * common/gdb_tilde_expand.h: Rename include guard.
10206         * common/gdb_sys_time.h: Rename include guard.
10207         * common/gdb_string_view.h: Rename include guard.
10208         * common/gdb_splay_tree.h: Rename include guard.
10209         * common/gdb_setjmp.h: Rename include guard.
10210         * common/gdb_ref_ptr.h: Rename include guard.
10211         * common/gdb_optional.h: Rename include guard.
10212         * common/gdb_locale.h: Rename include guard.
10213         * common/gdb_assert.h: Rename include guard.
10214         * common/filtered-iterator.h: Rename include guard.
10215         * common/filestuff.h: Rename include guard.
10216         * common/fileio.h: Rename include guard.
10217         * common/environ.h: Rename include guard.
10218         * common/common-utils.h: Rename include guard.
10219         * common/common-types.h: Rename include guard.
10220         * common/common-regcache.h: Rename include guard.
10221         * common/common-inferior.h: Rename include guard.
10222         * common/common-gdbthread.h: Rename include guard.
10223         * common/common-exceptions.h: Rename include guard.
10224         * common/common-defs.h: Rename include guard.
10225         * common/common-debug.h: Rename include guard.
10226         * common/cleanups.h: Rename include guard.
10227         * common/buffer.h: Rename include guard.
10228         * common/btrace-common.h: Rename include guard.
10229         * common/break-common.h: Rename include guard.
10230         * cli/cli-utils.h: Rename include guard.
10231         * cli/cli-style.h: Rename include guard.
10232         * cli/cli-setshow.h: Rename include guard.
10233         * cli/cli-script.h: Rename include guard.
10234         * cli/cli-interp.h: Rename include guard.
10235         * cli/cli-decode.h: Rename include guard.
10236         * cli/cli-cmds.h: Rename include guard.
10237         * charset-list.h: Add include guard.
10238         * buildsym-legacy.h: Rename include guard.
10239         * bfin-tdep.h: Add include guard.
10240         * ax.h: Rename include guard.
10241         * arm-linux-tdep.h: Add include guard.
10242         * arm-fbsd-tdep.h: Add include guard.
10243         * arch/xtensa.h: Rename include guard.
10244         * arch/tic6x.h: Add include guard.
10245         * arch/i386.h: Add include guard.
10246         * arch/arm.h: Rename include guard.
10247         * arch/arm-linux.h: Rename include guard.
10248         * arch/arm-get-next-pcs.h: Rename include guard.
10249         * arch/amd64.h: Add include guard.
10250         * arch/aarch64-insn.h: Rename include guard.
10251         * arch-utils.h: Rename include guard.
10252         * annotate.h: Add include guard.
10253         * amd64-darwin-tdep.h: Rename include guard.
10254         * aarch64-linux-tdep.h: Add include guard.
10255         * aarch64-fbsd-tdep.h: Add include guard.
10256         * aarch32-linux-nat.h: Add include guard.
10257
10258 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10259
10260         * macrotab.c (macro_define_internal): New function that
10261         factorizes macro_define_object_internal and macro_define_function
10262         code.
10263         (macro_define_object_internal): Use macro_define_internal.
10264         (macro_define_function): Likewise.
10265
10266 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10267
10268         * macrocmd.c (extract_identifier): Return
10269         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10270         callers.
10271
10272 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10273
10274         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10275
10276 2019-02-05  Tom Tromey  <tom@tromey.com>
10277
10278         * target.c (target_stack::unpush): Move assertion earlier.
10279
10280 2019-01-30  Tom Tromey  <tom@tromey.com>
10281
10282         PR python/23615:
10283         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10284         (gdbpy_parse_and_eval): Likewise.
10285         * python/python-internal.h (gdbpy_allow_threads): New class.
10286
10287 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10288
10289         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10290         (aarch64_fbsd_fpregmap): Move earlier.
10291         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10292         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10293         instead of individual calls to trad_frame_set_reg_addr.
10294         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10295         earlier.
10296         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10297         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10298         instead of individual calls to trad_frame_set_reg_addr.
10299
10300 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10301
10302         * CONTRIBUTE: Replace contribution list with wiki link.
10303
10304 2019-01-25  Tom Tromey  <tom@tromey.com>
10305
10306         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10307
10308 2019-01-25  Tom Tromey  <tom@tromey.com>
10309
10310         * xtensa-linux-nat.c: Fix common/ includes.
10311         * xml-support.h: Fix common/ includes.
10312         * xml-support.c: Fix common/ includes.
10313         * x86-linux-nat.c: Fix common/ includes.
10314         * windows-nat.c: Fix common/ includes.
10315         * varobj.h: Fix common/ includes.
10316         * varobj.c: Fix common/ includes.
10317         * value.c: Fix common/ includes.
10318         * valops.c: Fix common/ includes.
10319         * utils.c: Fix common/ includes.
10320         * unittests/xml-utils-selftests.c: Fix common/ includes.
10321         * unittests/utils-selftests.c: Fix common/ includes.
10322         * unittests/unpack-selftests.c: Fix common/ includes.
10323         * unittests/tracepoint-selftests.c: Fix common/ includes.
10324         * unittests/style-selftests.c: Fix common/ includes.
10325         * unittests/string_view-selftests.c: Fix common/ includes.
10326         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10327         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10328         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10329         * unittests/rsp-low-selftests.c: Fix common/ includes.
10330         * unittests/parse-connection-spec-selftests.c: Fix common/
10331         includes.
10332         * unittests/optional-selftests.c: Fix common/ includes.
10333         * unittests/offset-type-selftests.c: Fix common/ includes.
10334         * unittests/observable-selftests.c: Fix common/ includes.
10335         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10336         * unittests/memrange-selftests.c: Fix common/ includes.
10337         * unittests/memory-map-selftests.c: Fix common/ includes.
10338         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10339         * unittests/function-view-selftests.c: Fix common/ includes.
10340         * unittests/environ-selftests.c: Fix common/ includes.
10341         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10342         * unittests/common-utils-selftests.c: Fix common/ includes.
10343         * unittests/cli-utils-selftests.c: Fix common/ includes.
10344         * unittests/array-view-selftests.c: Fix common/ includes.
10345         * ui-file.c: Fix common/ includes.
10346         * tui/tui-io.c: Fix common/ includes.
10347         * tracepoint.h: Fix common/ includes.
10348         * tracepoint.c: Fix common/ includes.
10349         * tracefile-tfile.c: Fix common/ includes.
10350         * top.h: Fix common/ includes.
10351         * top.c: Fix common/ includes.
10352         * thread.c: Fix common/ includes.
10353         * target/waitstatus.h: Fix common/ includes.
10354         * target/waitstatus.c: Fix common/ includes.
10355         * target.h: Fix common/ includes.
10356         * target.c: Fix common/ includes.
10357         * target-memory.c: Fix common/ includes.
10358         * target-descriptions.c: Fix common/ includes.
10359         * symtab.h: Fix common/ includes.
10360         * symfile.c: Fix common/ includes.
10361         * stap-probe.c: Fix common/ includes.
10362         * spu-linux-nat.c: Fix common/ includes.
10363         * sparc-nat.c: Fix common/ includes.
10364         * source.c: Fix common/ includes.
10365         * solib.c: Fix common/ includes.
10366         * solib-target.c: Fix common/ includes.
10367         * ser-unix.c: Fix common/ includes.
10368         * ser-tcp.c: Fix common/ includes.
10369         * ser-pipe.c: Fix common/ includes.
10370         * ser-base.c: Fix common/ includes.
10371         * selftest-arch.c: Fix common/ includes.
10372         * s12z-tdep.c: Fix common/ includes.
10373         * rust-exp.y: Fix common/ includes.
10374         * rs6000-aix-tdep.c: Fix common/ includes.
10375         * riscv-tdep.c: Fix common/ includes.
10376         * remote.c: Fix common/ includes.
10377         * remote-notif.h: Fix common/ includes.
10378         * remote-fileio.h: Fix common/ includes.
10379         * remote-fileio.c: Fix common/ includes.
10380         * regcache.h: Fix common/ includes.
10381         * regcache.c: Fix common/ includes.
10382         * record-btrace.c: Fix common/ includes.
10383         * python/python.c: Fix common/ includes.
10384         * python/py-type.c: Fix common/ includes.
10385         * python/py-inferior.c: Fix common/ includes.
10386         * progspace.h: Fix common/ includes.
10387         * producer.c: Fix common/ includes.
10388         * procfs.c: Fix common/ includes.
10389         * proc-api.c: Fix common/ includes.
10390         * printcmd.c: Fix common/ includes.
10391         * ppc-linux-nat.c: Fix common/ includes.
10392         * parser-defs.h: Fix common/ includes.
10393         * osdata.c: Fix common/ includes.
10394         * obsd-nat.c: Fix common/ includes.
10395         * nat/x86-linux.c: Fix common/ includes.
10396         * nat/x86-linux-dregs.c: Fix common/ includes.
10397         * nat/x86-dregs.h: Fix common/ includes.
10398         * nat/x86-dregs.c: Fix common/ includes.
10399         * nat/ppc-linux.c: Fix common/ includes.
10400         * nat/mips-linux-watch.h: Fix common/ includes.
10401         * nat/mips-linux-watch.c: Fix common/ includes.
10402         * nat/linux-waitpid.c: Fix common/ includes.
10403         * nat/linux-ptrace.h: Fix common/ includes.
10404         * nat/linux-ptrace.c: Fix common/ includes.
10405         * nat/linux-procfs.c: Fix common/ includes.
10406         * nat/linux-personality.c: Fix common/ includes.
10407         * nat/linux-osdata.c: Fix common/ includes.
10408         * nat/linux-namespaces.c: Fix common/ includes.
10409         * nat/linux-btrace.h: Fix common/ includes.
10410         * nat/linux-btrace.c: Fix common/ includes.
10411         * nat/fork-inferior.c: Fix common/ includes.
10412         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10413         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10414         * nat/aarch64-linux.c: Fix common/ includes.
10415         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10416         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10417         * namespace.h: Fix common/ includes.
10418         * mips-linux-tdep.c: Fix common/ includes.
10419         * minsyms.c: Fix common/ includes.
10420         * mi/mi-parse.h: Fix common/ includes.
10421         * mi/mi-main.c: Fix common/ includes.
10422         * mi/mi-cmd-env.c: Fix common/ includes.
10423         * memrange.h: Fix common/ includes.
10424         * memattr.c: Fix common/ includes.
10425         * maint.h: Fix common/ includes.
10426         * maint.c: Fix common/ includes.
10427         * main.c: Fix common/ includes.
10428         * machoread.c: Fix common/ includes.
10429         * location.c: Fix common/ includes.
10430         * linux-thread-db.c: Fix common/ includes.
10431         * linux-nat.c: Fix common/ includes.
10432         * linux-fork.c: Fix common/ includes.
10433         * inline-frame.c: Fix common/ includes.
10434         * infrun.c: Fix common/ includes.
10435         * inflow.c: Fix common/ includes.
10436         * inferior.h: Fix common/ includes.
10437         * inferior.c: Fix common/ includes.
10438         * infcmd.c: Fix common/ includes.
10439         * inf-ptrace.c: Fix common/ includes.
10440         * inf-child.c: Fix common/ includes.
10441         * ia64-linux-nat.c: Fix common/ includes.
10442         * i387-tdep.c: Fix common/ includes.
10443         * i386-tdep.c: Fix common/ includes.
10444         * i386-linux-tdep.c: Fix common/ includes.
10445         * i386-linux-nat.c: Fix common/ includes.
10446         * i386-go32-tdep.c: Fix common/ includes.
10447         * i386-fbsd-tdep.c: Fix common/ includes.
10448         * i386-fbsd-nat.c: Fix common/ includes.
10449         * guile/scm-type.c: Fix common/ includes.
10450         * guile/guile.c: Fix common/ includes.
10451         * go32-nat.c: Fix common/ includes.
10452         * gnu-nat.c: Fix common/ includes.
10453         * gdbthread.h: Fix common/ includes.
10454         * gdbarch-selftests.c: Fix common/ includes.
10455         * gdb_usleep.c: Fix common/ includes.
10456         * gdb_select.h: Fix common/ includes.
10457         * gdb_bfd.c: Fix common/ includes.
10458         * gcore.c: Fix common/ includes.
10459         * fork-child.c: Fix common/ includes.
10460         * findvar.c: Fix common/ includes.
10461         * fbsd-nat.c: Fix common/ includes.
10462         * event-top.c: Fix common/ includes.
10463         * event-loop.c: Fix common/ includes.
10464         * dwarf2read.c: Fix common/ includes.
10465         * dwarf2loc.c: Fix common/ includes.
10466         * dwarf2-frame.c: Fix common/ includes.
10467         * dwarf-index-cache.c: Fix common/ includes.
10468         * dtrace-probe.c: Fix common/ includes.
10469         * disasm-selftests.c: Fix common/ includes.
10470         * defs.h: Fix common/ includes.
10471         * csky-tdep.c: Fix common/ includes.
10472         * cp-valprint.c: Fix common/ includes.
10473         * cp-support.h: Fix common/ includes.
10474         * cp-support.c: Fix common/ includes.
10475         * corelow.c: Fix common/ includes.
10476         * completer.h: Fix common/ includes.
10477         * completer.c: Fix common/ includes.
10478         * compile/compile.c: Fix common/ includes.
10479         * compile/compile-loc2c.c: Fix common/ includes.
10480         * compile/compile-cplus-types.c: Fix common/ includes.
10481         * compile/compile-cplus-symbols.c: Fix common/ includes.
10482         * command.h: Fix common/ includes.
10483         * cli/cli-dump.c: Fix common/ includes.
10484         * cli/cli-cmds.c: Fix common/ includes.
10485         * charset.c: Fix common/ includes.
10486         * build-id.c: Fix common/ includes.
10487         * btrace.h: Fix common/ includes.
10488         * btrace.c: Fix common/ includes.
10489         * breakpoint.h: Fix common/ includes.
10490         * breakpoint.c: Fix common/ includes.
10491         * ax.h:
10492         (enum agent_op): Fix common/ includes.
10493         * ax-general.c (struct aop_map): Fix common/ includes.
10494         * ax-gdb.c: Fix common/ includes.
10495         * auxv.c: Fix common/ includes.
10496         * auto-load.c: Fix common/ includes.
10497         * arm-tdep.c: Fix common/ includes.
10498         * arch/riscv.c: Fix common/ includes.
10499         * arch/ppc-linux-common.c: Fix common/ includes.
10500         * arch/i386.c: Fix common/ includes.
10501         * arch/arm.c: Fix common/ includes.
10502         * arch/arm-linux.c: Fix common/ includes.
10503         * arch/arm-get-next-pcs.c: Fix common/ includes.
10504         * arch/amd64.c: Fix common/ includes.
10505         * arch/aarch64.c: Fix common/ includes.
10506         * arch/aarch64-insn.c: Fix common/ includes.
10507         * arch-utils.c: Fix common/ includes.
10508         * amd64-windows-tdep.c: Fix common/ includes.
10509         * amd64-tdep.c: Fix common/ includes.
10510         * amd64-sol2-tdep.c: Fix common/ includes.
10511         * amd64-obsd-tdep.c: Fix common/ includes.
10512         * amd64-nbsd-tdep.c: Fix common/ includes.
10513         * amd64-linux-tdep.c: Fix common/ includes.
10514         * amd64-linux-nat.c: Fix common/ includes.
10515         * amd64-fbsd-tdep.c: Fix common/ includes.
10516         * amd64-fbsd-nat.c: Fix common/ includes.
10517         * amd64-dicos-tdep.c: Fix common/ includes.
10518         * amd64-darwin-tdep.c: Fix common/ includes.
10519         * agent.c: Fix common/ includes.
10520         * ada-lang.h: Fix common/ includes.
10521         * ada-lang.c: Fix common/ includes.
10522         * aarch64-tdep.c: Fix common/ includes.
10523
10524 2019-01-25  Tom Tromey  <tom@tromey.com>
10525
10526         * common/create-version.sh: Use common/version.h.
10527
10528 2019-01-24  Pedro Alves  <palves@redhat.com>
10529
10530         * infrun.c (signal_stop, signal_print, signal_program)
10531         (signal_catch, signal_pass): Now arrays instead of pointers.
10532         (update_signals_program_target, do_target_resume)
10533         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10534         * linux-nat.c (linux_nat_target::pass_signals)
10535         (linux_nat_target::create_inferior, linux_nat_target::attach):
10536         Adjust.
10537         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10538         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10539         * procfs.c (procfs_target::pass_signals): Adjust.
10540         * record-full.c (record_full_target::resume): Adjust.
10541         * remote.c (remote_target::pass_signals)
10542         (remote_target::program_signals): Adjust.
10543         * target-debug.h (target_debug_print_signals): Now takes a
10544         gdb::array_view as parameter.  Adjust.
10545         * target.h (target_ops) <pass_signals, program_signals>: Replace
10546         pointer and length parameters with gdb::array_view.
10547         (target_pass_signals, target_program_signals): Likewise.
10548         * target-delegates.c: Regenerate.
10549
10550 2019-01-24  Pedro Alves  <palves@redhat.com>
10551
10552         * common/forward-scope-exit.h
10553         (forward_scope_exit::forward_scope_exit): Pass arguments to
10554         m_bind_function directly, instead of creating a std::bind and
10555         copying that.
10556
10557 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10558
10559         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10560         for static members.
10561         (pass_in_v_vfp_candidate): Likewise.
10562
10563 2019-01-23  Tom Tromey  <tom@tromey.com>
10564             Pedro Alves  <palves@redhat.com>
10565
10566         * regcache.c (class regcache_invalidator): Remove.
10567         (regcache::raw_write): Use make_scope_exit.
10568
10569 2019-01-23  Tom Tromey  <tom@tromey.com>
10570
10571         * ui-out.h (class ui_out_emit_type): Update comment.
10572
10573 2019-01-23  Tom Tromey  <tom@tromey.com>
10574
10575         * infrun.c (fetch_inferior_event): Update comment.
10576
10577 2019-01-23  Tom Tromey  <tom@tromey.com>
10578             Pedro Alves  <palves@redhat.com>
10579
10580         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10581         parameter.
10582         (fetch_inferior_event): Use SCOPE_EXIT.
10583
10584
10585 2019-01-23  Tom Tromey  <tom@tromey.com>
10586             Pedro Alves  <palves@redhat.com>
10587
10588         * infrun.c (disable_thread_events): Delete.
10589         (stop_all_threads): Use SCOPE_EXIT.
10590
10591 2019-01-23  Tom Tromey  <tom@tromey.com>
10592             Pedro Alves  <palves@redhat.com>
10593
10594         * symfile.c: Include forward-scope-exit.h.
10595         (clear_symtab_users_cleanup): Replace forward declaration with
10596         a FORWARD_SCOPE_EXIT.
10597         (syms_from_objfile_1): Use the forward_scope_exit and
10598         gdb::optional instead of cleanup_function.
10599         (reread_symbols): Use the forward_scope_exit instead of
10600         cleanup_function.
10601         (clear_symtab_users_cleanup): Remove function.
10602
10603 2019-01-23  Tom Tromey  <tom@tromey.com>
10604             Pedro Alves  <palves@redhat.com>
10605
10606         * linux-nat.c: Include scope-exit.h.
10607         (cleanup_target_stop): Remove.
10608         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10609         SCOPE_EXIT.
10610
10611 2019-01-23  Tom Tromey  <tom@tromey.com>
10612             Pedro Alves  <palves@redhat.com>
10613
10614         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10615         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10616
10617 2019-01-23  Tom Tromey  <tom@tromey.com>
10618             Andrew Burgess  <andrew.burgess@embecosm.com>
10619             Pedro Alves  <palves@redhat.com>
10620
10621         * infrun.c (fetch_inferior_event): Use scope_exit.
10622         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10623         * top.c (execute_command): Use scope_exit.
10624         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10625         * utils.c (do_bpstat_clear_actions_cleanup)
10626         (make_bpstat_clear_actions_cleanup): Remove.
10627
10628 2019-01-23  Tom Tromey  <tom@tromey.com>
10629             Pedro Alves  <palves@redhat.com>
10630
10631         * infrun.c: Include "common/scope-exit.h"
10632         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10633         (wait_for_inferior): Use SCOPE_EXIT.
10634         (fetch_inferior_event): Use scope_exit.
10635
10636 2019-01-23  Tom Tromey  <tom@tromey.com>
10637             Pedro Alves  <palves@redhat.com>
10638
10639         * breakpoint.c (create_breakpoint): Remove cleanup.
10640
10641 2019-01-23  Tom Tromey  <tom@tromey.com>
10642             Andrew Burgess  <andrew.burgess@embecosm.com>
10643             Pedro Alves  <palves@redhat.com>
10644
10645 2019-01-23  Pedro Alves  <palves@redhat.com>
10646
10647         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10648
10649 2019-01-23  Pedro Alves  <palves@redhat.com>
10650             Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * gdbthread.h: Include "common/forward-scope-exit.h".
10653         (scoped_finish_thread_state): Redefine custom class in terms of
10654         forward_scope_exit.
10655
10656 2019-01-23  Pedro Alves  <palves@redhat.com>
10657             Andrew Burgess  <andrew.burgess@embecosm.com>
10658
10659         * common/forward-scope-exit.h: New file.
10660
10661 2019-01-23  Pedro Alves  <palves@redhat.com>
10662             Andrew Burgess  <andrew.burgess@embecosm.com>
10663             Tom Tromey  <tom@tromey.com>
10664
10665         * common/scope-exit.h: New file.
10666
10667 2019-01-23  Pedro Alves  <palves@redhat.com>
10668
10669         * common/preprocessor.h (ESC): Rename to ...
10670         (ESC_PARENS): ... this.
10671         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10672         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10673
10674 2019-01-23  Tom Tromey  <tom@tromey.com>
10675
10676         * language.h (class scoped_switch_to_sym_language_if_auto):
10677         Initialize m_lang in both cases.
10678
10679 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10680
10681         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10682         with XCNEW.
10683
10684 2019-01-22  Tom Tromey  <tom@tromey.com>
10685
10686         * corelow.c: Do not include sys/file.h.
10687
10688 2019-01-22  Tom Tromey  <tom@tromey.com>
10689
10690         * tui/tui-wingeneral.h: Include gdb_curses.h.
10691
10692 2019-01-22  Tom Tromey  <tom@tromey.com>
10693
10694         * source-cache.h (class source_cache) <get_source_lines,
10695         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10696
10697 2019-01-22  Tom Tromey  <tom@tromey.com>
10698
10699         * remote-fileio.h (struct remote_target): Declare.
10700
10701 2019-01-22  Tom Tromey  <tom@tromey.com>
10702
10703         * python/py-arch.c: Do not include py-ref.h.
10704         * python/py-bpevent.c: Do not include py-ref.h.
10705         * python/py-cmd.c: Do not include py-ref.h.
10706         * python/py-continueevent.c: Do not include py-ref.h.
10707         * python/py-event.h: Do not include py-ref.h.
10708         * python/py-evtregistry.c: Do not include py-ref.h.
10709         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10710         * python/py-frame.c: Do not include py-ref.h.
10711         * python/py-framefilter.c: Do not include py-ref.h.
10712         * python/py-function.c: Do not include py-ref.h.
10713         * python/py-infevents.c: Do not include py-ref.h.
10714         * python/py-linetable.c: Do not include py-ref.h.
10715         * python/py-objfile.c: Do not include py-ref.h.
10716         * python/py-param.c: Do not include py-ref.h.
10717         * python/py-prettyprint.c: Do not include py-ref.h.
10718         * python/py-progspace.c: Do not include py-ref.h.
10719         * python/py-symbol.c: Do not include py-ref.h.
10720         * python/py-symtab.c: Do not include py-ref.h.
10721         * python/py-type.c: Do not include py-ref.h.
10722         * python/py-unwind.c: Do not include py-ref.h.
10723         * python/py-utils.c: Do not include py-ref.h.
10724         * python/py-value.c: Do not include py-ref.h.
10725         * python/py-varobj.c: Do not include py-ref.h.
10726         * python/py-xmethods.c: Do not include py-ref.h.
10727         * python/python.c: Do not include py-ref.h.
10728         * varobj.c: Do not include py-ref.h.
10729
10730 2019-01-22  Tom Tromey  <tom@tromey.com>
10731
10732         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10733         keyword for bcache.
10734
10735 2019-01-22  Tom Tromey  <tom@tromey.com>
10736
10737         * compile/compile-cplus-types.c: Remove a comment by #include.
10738
10739 2019-01-22  Tom Tromey  <tom@tromey.com>
10740
10741         * compile/gcc-c-plugin.h: Include compile-internal.h.
10742
10743 2019-01-22  Tom Tromey  <tom@tromey.com>
10744
10745         * stabsread.c (EXTERN): Do not define.
10746         (symnum, next_symbol_text_func, processing_gcc_compilation)
10747         (within_function, global_sym_chain, global_stabs)
10748         (previous_stab_code, this_object_header_files)
10749         (n_this_object_header_files)
10750         (n_allocated_this_object_header_files): Define.
10751         * stabsread.h (EXTERN): Never define.  Use "extern".
10752
10753 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10754
10755         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10756         history_value.
10757
10758 2019-01-21  Tom Tromey  <tom@tromey.com>
10759
10760         * ui-out.c: Fix includes.
10761         * tui/tui-source.c: Fix includes.
10762         * target.c: Fix includes.
10763         * remote.c: Fix includes.
10764         * regcache.c: Fix includes.
10765         * python/py-block.c: Fix includes.
10766         * printcmd.c: Fix includes.
10767         * or1k-tdep.c: Fix includes.
10768         * mi/mi-main.c: Fix includes.
10769         * m32r-tdep.c: Fix includes.
10770         * csky-tdep.c: Fix includes.
10771         * compile/compile-cplus-types.c: Fix includes.
10772         * cli/cli-interp.c: Fix includes.
10773
10774 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10775
10776         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10777         for padding.
10778
10779 2019-01-16  Tom Tromey  <tom@tromey.com>
10780
10781         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10782         earlier.
10783         (struct objfile) <msymbols_range>: Move from top level.
10784         <msymbols>: New method.
10785         (class objfile_msymbols): Remove.
10786         * symtab.c (default_collect_symbol_completion_matches_break_on):
10787         Update.
10788         * symmisc.c (dump_msymbols): Update.
10789         * stabsread.c (scan_file_globals): Update.
10790         * objc-lang.c (info_selectors_command, info_classes_command)
10791         (find_methods): Update.
10792         * minsyms.c (find_solib_trampoline_target): Update.
10793         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10794         * coffread.c (coff_symfile_read): Update.
10795         * ada-lang.c (ada_lookup_simple_minsym)
10796         (ada_collect_symbol_completion_matches): Update.
10797
10798 2019-01-16  Tom Tromey  <tom@tromey.com>
10799
10800         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10801         type.  Remove no-argument constructor.
10802         <iterator::operator++>: Simplify.
10803         <begin>: Update.
10804         <end>: Use minimal_symbol_count.
10805
10806 2019-01-16  Tom Tromey  <tom@tromey.com>
10807
10808         * objfiles.h (struct objfile) <psymtabs>: New method.
10809         (class objfile_psymtabs): Remove.
10810         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10811         typedef.
10812         <range>: New method.
10813         (require_partial_symbols): Change return type.
10814         * psymtab.c (require_partial_symbols)
10815         (psym_expand_symtabs_matching): Update.
10816         * mdebugread.c (parse_partial_symbols): Update.
10817         * dbxread.c (dbx_end_psymtab): Update.
10818
10819 2019-01-15  Tom Tromey  <tom@tromey.com>
10820
10821         * symtab.c (lookup_objfile_from_block)
10822         (lookup_symbol_in_objfile_symtabs)
10823         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10824         (find_line_symtab, info_sources_command)
10825         (default_collect_symbol_completion_matches_break_on)
10826         (make_source_files_completion_list): Update.
10827         * symmisc.c (print_objfile_statistics, dump_objfile)
10828         (maintenance_print_symbols, maintenance_info_symtabs)
10829         (maintenance_check_symtabs, maintenance_info_line_tables):
10830         Update.
10831         * source.c (select_source_symtab)
10832         (forget_cached_source_info_for_objfile): Update.
10833         * objfiles.h (class objfile_compunits): Remove.
10834         (struct objfile) <compunits_range>: New typedef.
10835         (compunits): New method.
10836         * objfiles.c (objfile_relocate1): Update.
10837         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10838         * maint.c (count_symtabs_and_blocks): Update.
10839         * linespec.c (iterate_over_all_matching_symtabs): Update.
10840         * cp-support.c (add_symbol_overload_list_qualified): Update.
10841         * coffread.c (coff_symtab_read): Update.
10842         * ada-lang.c (add_nonlocal_symbols)
10843         (ada_collect_symbol_completion_matches)
10844         (ada_add_global_exceptions): Update.
10845
10846 2019-01-15  Tom Tromey  <tom@tromey.com>
10847
10848         * progspace.h (program_space) <objfiles_safe_range>: New
10849         typedef.
10850         <objfiles_safe>: New method.
10851         * objfiles.h (class all_objfiles_safe): Remove.
10852         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10853         * jit.c (jit_inferior_exit_hook): Update.
10854
10855 2019-01-17  Tom Tromey  <tom@tromey.com>
10856
10857         * progspace.h (program_space) <objfiles_range>: New typedef.
10858         <objfiles>: New method.
10859         <objfiles_head>: Rename from objfiles.
10860         (object_files): Update.
10861         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10862         * guile/scm-pretty-print.c
10863         (ppscm_find_pretty_printer_from_objfiles): Update.
10864         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10865         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10866         Update.
10867         * python/py-progspace.c (pspy_get_objfiles): Update.
10868         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10869         Update.
10870         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10871         (objfpy_lookup_objfile_by_build_id): Update.
10872         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10873         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10874         Update.
10875         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10876         (expand_symtab_containing_pc, lookup_objfile_from_block)
10877         (lookup_static_symbol, basic_lookup_transparent_type)
10878         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10879         (find_line_symtab, info_sources_command)
10880         (default_collect_symbol_completion_matches_break_on)
10881         (make_source_files_completion_list, find_main_name): Update.
10882         * symmisc.c (print_symbol_bcache_statistics)
10883         (print_objfile_statistics, maintenance_print_symbols)
10884         (maintenance_print_msymbols, maintenance_print_objfiles)
10885         (maintenance_info_symtabs, maintenance_check_symtabs)
10886         (maintenance_expand_symtabs, maintenance_info_line_tables):
10887         Update.
10888         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10889         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10890         (map_overlay_command, unmap_overlay_command)
10891         (simple_overlay_update, expand_symtabs_matching)
10892         (map_symbol_filenames): Update.
10893         * symfile-debug.c (set_debug_symfile): Update.
10894         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10895         Update.
10896         * source.c (select_source_symtab, forget_cached_source_info):
10897         Update.
10898         * solib.c (solib_read_symbols): Update.
10899         * solib-spu.c (append_ocl_sos): Update.
10900         * psymtab.c (maintenance_print_psymbols)
10901         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10902         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10903         * printcmd.c (info_symbol_command): Update.
10904         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10905         Update.
10906         * objfiles.h (class all_objfiles): Remove.
10907         * objfiles.c (have_partial_symbols, have_full_symbols)
10908         (have_minimal_symbols, qsort_cmp, update_section_map)
10909         (shared_objfile_contains_address_p)
10910         (default_iterate_over_objfiles_in_search_order): Update.
10911         * objc-lang.c (info_selectors_command, info_classes_command)
10912         (find_methods): Update.
10913         * minsyms.c (find_solib_trampoline_target): Update.
10914         * maint.c (maintenance_info_sections)
10915         (maintenance_translate_address, count_symtabs_and_blocks):
10916         Update.
10917         * main.c (captured_main_1): Update.
10918         * linux-thread-db.c (try_thread_db_load_from_pdir)
10919         (has_libpthread): Update.
10920         * linespec.c (iterate_over_all_matching_symtabs)
10921         (search_minsyms_for_name): Update.
10922         * jit.c (jit_find_objf_with_entry_addr): Update.
10923         * hppa-tdep.c (find_unwind_entry)
10924         (hppa_lookup_stub_minimal_symbol): Update.
10925         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10926         Update.
10927         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10928         (elf_gnu_ifunc_resolve_by_got): Update.
10929         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10930         * dwarf-index-write.c (save_gdb_index_command): Update.
10931         * cp-support.c (add_symbol_overload_list_qualified): Update.
10932         * breakpoint.c (create_overlay_event_breakpoint)
10933         (create_longjmp_master_breakpoint)
10934         (create_std_terminate_master_breakpoint)
10935         (create_exception_master_breakpoint): Update.
10936         * blockframe.c (find_pc_partial_function): Update.
10937         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10938         (ada_collect_symbol_completion_matches)
10939         (ada_add_global_exceptions): Update.
10940
10941 2019-01-17  Tom Tromey  <tom@tromey.com>
10942
10943         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10944         declare VEC.
10945         (solib_target_parse_libraries): Change return type.
10946         (library_list_start_segment, library_list_start_section)
10947         (library_list_end_library, library_list_start_library); Update.
10948         (solib_target_free_library_list): Remove.
10949         (solib_target_parse_libraries): Remove cleanup.  Change return
10950         type.
10951         (solib_target_current_sos): Update.
10952
10953 2019-01-17  Tom Tromey  <tromey@bapiya>
10954
10955         * valprint.c: Replace "the the" with "the".
10956         * symtab.c: Replace "the the" with "the".
10957         * solib.c: Replace "the the" with "the".
10958         * solib-dsbt.c: Replace "the the" with "the".
10959         * linespec.c: Replace "the the" with "the".
10960         * dwarf2loc.h: Replace "the the" with "the".
10961         * amd64-windows-tdep.c: Replace "the the" with "the".
10962         * aarch64-tdep.c: Replace "the the" with "the".
10963
10964 2019-01-16  Keith Seitz  <keiths@redhat.com>
10965
10966         PR gdb/23773
10967         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10968         <builder>: Rename to ..
10969         <m_builder>: ... this and make private.
10970         (dwarf2_cu::get_builder): New method.  Change all users of
10971         `builder' to use this method.
10972         (dwarf2_start_symtab): Move to ...
10973         (dwarf2_cu::start_symtab): ... here.  Update all callers
10974         (setup_type_unit_groups): Move to ...
10975         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10976         callers.
10977         (dwarf2_cu::reset_builder): New method.
10978         (process_full_compunit, process_full_type_unit): Use
10979         dwarf2_cu::reset_builder.
10980         (follow_die_offset): Record the ancestor CU if it is different
10981         from the followed DIE's CU.
10982         (follow_die_sig_1): Likewise.
10983
10984 2019-01-15  Tom Tromey  <tom@tromey.com>
10985
10986         * remote.c (class remote_state) <buf>: Now a char_vector.
10987         <buf_size>: Remove.
10988         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10989         parameter.
10990         (remote_target::getpkt_or_notif_sane_1)
10991         (remote_target::getpkt_sane)
10992         (remote_target::getpkt_or_notif_sane): Likewise.
10993         (class remote_target) <putpkt>: New overload.
10994         (remote_target::read_frame): Change type of "buf_p".  Remove
10995         sizeof_p parameter.
10996         (packet_ok): New overload.
10997         (packet_check_result): New overload.
10998         Update all uses.
10999
11000 2019-01-14  Tom Tromey  <tom@tromey.com>
11001
11002         * remote-notif.c (handle_notification, remote_notif_ack)
11003         (remote_notif_parse): Make "buf" const.
11004         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11005         const.
11006         (remote_notif_parse, remote_notif_ack, handle_notification):
11007         Likewise.
11008         * remote.c (remote_notif_stop_parse): Make "buf" const.
11009         (remote_target::remote_parse_stop_reply): Make "buf" const.
11010         (remote_notif_stop_ack): Make "buf" const.
11011
11012 2019-01-14  Tom Tromey  <tom@tromey.com>
11013
11014         * remote.c (remote_console_output): Make parameter const.
11015
11016 2019-01-14  Tom Tromey  <tom@tromey.com>
11017
11018         * target-debug.h (target_debug_print_signals): Constify.
11019         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11020         * procfs.c (procfs_target::pass_signals): Update.
11021         * linux-nat.c (linux_nat_target::pass_signals): Update.
11022         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11023         * target-delegates.c: Rebuild.
11024         * remote.c (remote_target::program_signals): Update.
11025         (remote_target::pass_signals): Update.
11026         * target.c (target_pass_signals): Constify argument.
11027         (target_program_signals): Likewise.
11028         * target.h (struct target_ops) <pass_signals, program_signals>:
11029         Constify argument.
11030         (target_pass_signals, target_program_signals): Constify argument.
11031
11032 2019-01-14  Tom Tromey  <tom@tromey.com>
11033
11034         PR tui/28819:
11035         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11036
11037 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11038
11039         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11040         field.
11041         * rs6000-tdep.c: Include reggroups.h.
11042         (IS_V_ALIAS_PSEUDOREG): Define.
11043         (rs6000_register_name): Return names for the "vX" aliases.
11044         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11045         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11046         aliases.  Call default_register_reggroup_p for all other
11047         pseudo-registers.
11048         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11049         New functions.
11050         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11051         Handle "vX" aliases.
11052         (v_alias_pseudo_register_collect): New function.
11053         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11054         (rs6000_gdbarch_init): Initialize "vX" aliases as
11055         pseudo-registers.  Restore registration of
11056         rs6000_pseudo_register_reggroup_p with
11057         set_tdesc_pseudo_register_reggroup_p.
11058
11059 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11060
11061         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11062         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11063         set_gdbarch_num_pseudo_regs.
11064
11065 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11066
11067         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11068         Remove arg prefixname, add do_set and do_show.
11069         Add member functions set_list and show_list.
11070         * cli/cli-style.c (class cli_style_option): Update accordingly.
11071         (style_set_list): Move to file scope.
11072         (style_show_list): Likewise.
11073         (set_style): Call help_list.
11074         (show_style): Call cmd_show_list.
11075         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11076         Update to use the new macro.
11077
11078 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11079
11080         * ada-lang.c (_initialize_ada_language): Expand the help text
11081         for the "catch exception" command.
11082
11083 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11084
11085         * symtab.c (matching_obj_sections): Initialize obj,
11086         declare it closer to its usage.
11087
11088 2019-01-10  Tom Tromey  <tom@tromey.com>
11089
11090         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11091         (basic_inf_threads_range): Remove.
11092         (inf_threads_range, inf_non_exited_threads_range)
11093         (safe_inf_threads_range): Use next_adapter.
11094
11095 2019-01-10  Keith Seitz  <keiths@redhat.com>
11096
11097         PR gdb/23712
11098         PR symtab/23010
11099         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11100         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11101
11102 2019-01-10  Keith Seitz  <keiths@redhat.com>
11103
11104         PR gdb/23712
11105         PR symtab/23010
11106         * dictionary.c (pending_to_vector): Remove.
11107         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11108         Remove _1 suffix, replacing functions of the same name.  Update
11109         all callers.
11110         (dict_create_hashed, dict_create_hashed_expandable)
11111         (dict_create_linear, dict_create_linear_expandable, dict_free)
11112         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11113         Make functions static.
11114
11115 2019-01-10  Keith Seitz  <keiths@redhat.com>
11116
11117         PR gdb/23712
11118         PR symtab/23010
11119         * dictionary.h (struct dictionary): Replace declaration with
11120         multidictionary.
11121         (dict_create_hashed, dict_create_hashed_expandable)
11122         (dict_create_linear, dict_create_linear_expandable)
11123         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11124         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11125         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11126         taking multidictionary argument.
11127         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11128         * block.h (struct block) <dict>: Change to multidictionary
11129         and rename `multidict'.
11130         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11131         symmisc.c: Update all dictionary references to multidictionary.
11132
11133 2019-01-10  Keith Seitz  <keiths@redhat.com>
11134
11135         PR gdb/23712
11136         PR symtab/23010
11137         * dictionary.c: Include unordered_map.
11138         (pending_to_vector): New function.
11139         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11140         Rewrite the non-"_1" functions to take vector instead
11141         of linked list.
11142         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11143         "new" _1 versions of the same name.
11144         (multidictionary): Define.
11145         (std::hash<enum language): New definition.
11146         (collate_pending_symbols_by_language, mdict_create_hashed)
11147         (mdict_create_hashed_expandable, mdict_create_linear)
11148         (mdict_create_linear_expandable, mdict_free)
11149         (find_language_dictionary, create_new_language_dictionary)
11150         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11151         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11152         (mdict_size, mdict_empty): New functions.
11153         * dictionary.h (mdict_iterator): Define.
11154
11155 2019-01-10  Pedro Alves  <palves@redhat.com>
11156
11157         * breakpoint.c (read_uploaded_action)
11158         (create_tracepoint_from_upload): Adjust to use
11159         gdb::unique_xmalloc_ptr.
11160         * ctf.c (ctf_write_uploaded_tp):
11161         (SET_ARRAY_FIELD): Use emplace_back.
11162         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11163         * tracefile-tfile.c (tfile_write_uploaded_tp):
11164         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11165         gdb::unique_xmalloc_ptr.
11166         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11167         at_string, cond_string, cmd_strings>: Replace char pointers
11168         with gdb::unique_xmalloc_ptr.
11169
11170 2019-01-10  Pedro Alves  <palves@redhat.com>
11171
11172         * solib-target.c (library_list_start_library): Don't xstrdup name.
11173
11174 2019-01-10  Pedro Alves  <palves@redhat.com>
11175
11176         * mdebugread.c (parse_partial_symbols): Use
11177         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11178
11179 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11180
11181         * linux-fork.c (scoped_switch_fork_info)
11182         <~scoped_switch_fork_info>: Fix incorrect variable name.
11183
11184 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11185
11186         * linux-fork.c (scoped_switch_fork_info)
11187         <scoped_switch_fork_info>: Make explicit.
11188         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11189
11190 2019-01-10  Tom Tromey  <tom@tromey.com>
11191
11192         * objfiles.h (objfile::reset_psymtabs): Update.
11193         * objfiles.c (objfile::objfile): Update.
11194         * psymtab.h (psymtab_storage::obstack): Update.
11195         (psymtab_storage::m_obstack): Use gdb::optional.
11196         (class psymtab_storage): Update comment.  Remove objfile
11197         parameter.
11198         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11199
11200 2019-01-10  Tom Tromey  <tom@tromey.com>
11201
11202         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11203         <free_psymtabs>: Now private.
11204         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11205         (allocate_psymtab): Use new method.
11206
11207 2019-01-10  Tom Tromey  <tom@tromey.com>
11208
11209         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11210         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11211         * mdebugread.c (parse_partial_symbols): Use
11212         allocate_dependencies.
11213         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11214         allocate_dependencies.
11215         (process_psymtab_comp_unit_reader)
11216         (build_type_psymtab_dependencies): Likewise.
11217         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11218
11219 2019-01-10  Tom Tromey  <tom@tromey.com>
11220
11221         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11222         PSYMBOL_SET_LANGUAGE.
11223         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11224
11225 2019-01-10  Tom Tromey  <tom@tromey.com>
11226
11227         * psymtab.h (psymtab_storage::obstack): New method.
11228         <m_obstack>: Rename from obstack; now private.
11229         * psymtab.c (psymtab_storage): Update.
11230         * dwarf2read.c (create_addrmap_from_index)
11231         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11232         Update.
11233
11234 2019-01-10  Tom Tromey  <tom@tromey.com>
11235
11236         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11237         * objfiles.h (objfile::reset_psymtabs): New method.
11238
11239 2019-01-10  Tom Tromey  <tom@tromey.com>
11240
11241         * symmisc.c (print_symbol_bcache_statistics): Update.
11242         (print_objfile_statistics): Update.
11243         * symfile.c (reread_symbols): Update.
11244         * psymtab.h (class psymtab_storage): New.
11245         * psymtab.c (psymtab_storage): New constructor.
11246         (~psymtab_storage): New destructor.
11247         (require_partial_symbols): Update.
11248         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11249         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11250         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11251         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11252         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11253         (start_psymtab_common, end_psymtab_common)
11254         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11255         (allocate_psymtab): Update.
11256         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11257         Update.
11258         (dump_psymtab_addrmap, maintenance_print_psymbols)
11259         (maintenance_check_psymtabs): Update.
11260         (class objfile_psymtabs): Move to objfiles.h.
11261         * psympriv.h (discard_psymtab): Now inline.
11262         (psymtab_discarder::psymtab_discarder): Update.
11263         (psymtab_discarder::~psymtab_discarder): Update.
11264         (ALL_OBJFILE_PSYMTABS): Rewrite.
11265         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11266         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11267         Remove fields.
11268         <partial_symtabs>: New field.
11269         (class objfile_psymtabs): Move from psymtab.h.  Update.
11270         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11271         psymbol_cache.
11272         (objfile::~objfile): Don't destroy psymbol_cache.
11273         * mdebugread.c (parse_partial_symbols): Update.
11274         * dwarf2read.c (create_addrmap_from_index)
11275         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11276         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11277         (add_partial_subprogram, dwarf2_ranges_read): Update.
11278         * dwarf-index-write.c (write_address_map)
11279         (write_one_signatured_type, recursively_write_psymbols)
11280         (class debug_names, class debug_names, write_psymtabs_to_index):
11281         Update.
11282
11283 2019-01-10  Tom Tromey  <tom@tromey.com>
11284
11285         * symtab.h (SYMBOL_SET_NAMES): Update.
11286         (symbol_set_names): Update.
11287         (MSYMBOL_SET_NAMES): Update.
11288         * symtab.c (symbol_set_names): Change argument to be an
11289         objfile_per_bfd_storage.
11290         * psymtab.c (add_psymbol_to_bcache): Update.
11291         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11292
11293 2019-01-10  Tom Tromey  <tom@tromey.com>
11294
11295         * symtab.c (create_demangled_names_hash): Change argument to be an
11296         objfile_per_bfd_storage.
11297         (symbol_set_names): Update.
11298
11299 2019-01-10  Tom Tromey  <tom@tromey.com>
11300
11301         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11302         init_psymbol_list.
11303         * psymtab.c (init_psymbol_list): Do nothing if already called.
11304         * psympriv.h (init_psymbol_list): Add comment.
11305         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11306         init_psymbol_list.
11307         * dbxread.c (dbx_symfile_read): Unconditionally call
11308         init_psymbol_list.
11309
11310 2019-01-10  Tom Tromey  <tom@tromey.com>
11311
11312         * xcoffread.c (scan_xcoff_symtab): Update.
11313         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11314         "where".
11315         * mdebugread.c (parse_partial_symbols)
11316         (handle_psymbol_enumerators): Update.
11317         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11318         * dbxread.c (read_dbx_symtab): Update.
11319         * psympriv.h (psymbol_placement): New enum.
11320         (add_psymbol_to_list): Update.
11321
11322 2019-01-10  Tom Tromey  <tom@tromey.com>
11323
11324         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11325         static_psymbols parameters.
11326         (scan_xcoff_symtab): Update.
11327         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11328         static_psymbols parameters.
11329         * psympriv.h (start_psymtab_common): Update.
11330         * mdebugread.c (parse_partial_symbols): Update.
11331         * dwarf2read.c (create_partial_symtab): Update.
11332         * dbxread.c (read_dbx_symtab): Update.
11333         (start_psymtab): Remove global_psymbols and static_psymbols
11334         parameters.
11335
11336 2019-01-10  Tom Tromey  <tom@tromey.com>
11337
11338         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11339         * psymtab.c (allocate_psymtab): Add comment.
11340         * psympriv.h (allocate_psymtab): Add comment.
11341         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11342         initializations.
11343         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11344
11345 2019-01-10  Tom Tromey  <tom@tromey.com>
11346
11347         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11348         Don't declare.
11349         * mipsread.c: Include mdebugread.h.
11350         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11351         Declare.
11352         * elfread.c: Include mdebugread.h.
11353
11354 2019-01-09  Tom Tromey  <tom@tromey.com>
11355
11356         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11357         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11358         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11359         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11360         (psym_lookup_symbol, psym_find_last_source_symtab)
11361         (psym_forget_cached_source_info, psym_print_stats)
11362         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11363         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11364         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11365         (psym_find_compunit_symtab_by_address)
11366         (maintenance_print_psymbols, maintenance_info_psymtabs)
11367         (maintenance_check_psymtabs): Use ranged for.
11368         * psymtab.h (class objfile_psymtabs): New.
11369         (require_partial_symbols): Return objfile_psymtabs.
11370         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11371
11372 2019-01-09  Tom Tromey  <tom@tromey.com>
11373
11374         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11375         (find_pc_mapped_section, list_overlays_command)
11376         (map_overlay_command, unmap_overlay_command)
11377         (simple_overlay_update): Use all_objfiles.
11378         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11379         * printcmd.c (info_symbol_command): Use all_objfiles.
11380         * objfiles.h (ALL_OBJSECTIONS): Remove.
11381         * maint.c (maintenance_translate_address): Use all_objfiles.
11382         * gcore.c (gcore_create_callback): Use all_objfiles.
11383         (objfile_find_memory_regions): Likewise.
11384
11385 2019-01-09  Tom Tromey  <tom@tromey.com>
11386
11387         * symtab.c (find_line_symtab, info_sources_command)
11388         (make_source_files_completion_list): Use objfile_compunits.
11389         * source.c (select_source_symtab): Use objfile_compunits.
11390         * objfiles.h (struct objfile): Update comment.
11391         (ALL_OBJFILES): Remove.
11392         (ALL_FILETABS): Remove.
11393         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11394         objfile_compunits.
11395
11396 2019-01-09  Tom Tromey  <tom@tromey.com>
11397
11398         * symmisc.c (print_objfile_statistics, dump_objfile)
11399         (maintenance_print_symbols): Use compunit_filetabs.
11400         * source.c (forget_cached_source_info_for_objfile): Use
11401         compunit_filetabs.
11402         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11403         (ALL_FILETABS): Use compunit_filetabs.
11404         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11405         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11406
11407 2019-01-09  Tom Tromey  <tom@tromey.com>
11408
11409         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11410         (compunit_filetabs): New.
11411         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11412         compunit_filetabs.
11413         (info_sources_command, make_source_files_completion_list): Remove
11414         declaration.
11415         * symmisc.c (print_objfile_statistics, dump_objfile)
11416         (maintenance_print_symbols): Remove declaration.
11417         (maintenance_info_symtabs): Use compunit_filetabs.
11418         (maintenance_info_line_tables): Likewise.
11419         * source.c (select_source_symtab): Change local variable name.
11420         (forget_cached_source_info_for_objfile): Remove declaration.
11421         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11422         * objfiles.c (objfile_relocate1): Remove declaration.
11423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11424         declaration.
11425         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11426         * coffread.c (coff_symtab_read): Remove declaration.
11427         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11428         compunit_filetabs.
11429
11430 2019-01-09  Tom Tromey  <tom@tromey.com>
11431
11432         * symtab.c (lookup_objfile_from_block)
11433         (find_pc_sect_compunit_symtab, search_symbols)
11434         (default_collect_symbol_completion_matches_break_on): Use
11435         objfile_compunits.
11436         * objfiles.h (ALL_COMPUNITS): Remove.
11437         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11438         * cp-support.c (add_symbol_overload_list_qualified): Use
11439         objfile_compunits.
11440         * ada-lang.c (ada_collect_symbol_completion_matches)
11441         (ada_add_global_exceptions): Use objfile_compunits.
11442
11443 2019-01-09  Tom Tromey  <tom@tromey.com>
11444
11445         * source.c (select_source_symtab)
11446         (forget_cached_source_info_for_objfile): Remove declaration.
11447         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11448         declaration.
11449         * maint.c (count_symtabs_and_blocks): Remove declaration.
11450         * cp-support.c (add_symbol_overload_list_qualified): Remove
11451         declaration.
11452         * coffread.c (coff_symtab_read): Remove declaration.
11453         * symtab.c (lookup_symbol_in_objfile_symtabs)
11454         (basic_lookup_transparent_type_1): Use objfile_compunits.
11455         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11456         (info_sources_command, search_symbols)
11457         (default_collect_symbol_completion_matches_break_on)
11458         (make_source_files_completion_list): Remove declaration.
11459         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11460         (ada_collect_symbol_completion_matches)
11461         (ada_add_global_exceptions): Remove declaration.
11462         * linespec.c (iterate_over_all_matching_symtabs): Use
11463         objfile_compunits.
11464         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11465         (class objfile_compunits): New.
11466         (ALL_COMPUNITS): Use objfile_compunits.
11467         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11468         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11469         objfile_compunits.
11470         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11471
11472 2019-01-09  Tom Tromey  <tom@tromey.com>
11473
11474         * symtab.c (search_symbols)
11475         (default_collect_symbol_completion_matches_break_on): Use
11476         objfile_msymbols.
11477         * ada-lang.c (ada_lookup_simple_minsym)
11478         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11479         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11480         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11481         objfile_msymbols.
11482         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11483         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11484         * objc-lang.c (find_methods): Use objfile_msymbols.
11485         (info_selectors_command, info_classes_command): Likewise.
11486         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11487         * objfiles.h (class objfile_msymbols): New.
11488         (ALL_OBJFILE_MSYMBOLS): Remove.
11489         (ALL_MSYMBOLS): Remove.
11490
11491 2019-01-09  Tom Tromey  <tom@tromey.com>
11492
11493         * common/next-iterator.h (next_adapter): Add Iterator template
11494         parameter.
11495         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11496         (class all_objfiles_safe): New.
11497         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11498         * objfiles.c (put_objfile_before): Update comment.
11499         (add_separate_debug_objfile): Likewise.
11500         (free_all_objfiles): Use all_objfiles_safe.
11501         (objfile_purge_solibs): Likewise.
11502
11503 2019-01-09  Tom Tromey  <tom@tromey.com>
11504
11505         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11506         (expand_symtab_containing_pc, lookup_static_symbol)
11507         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11508         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11509         all_objfiles.
11510         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11511         * breakpoint.c (create_overlay_event_breakpoint)
11512         (create_longjmp_master_breakpoint)
11513         (create_std_terminate_master_breakpoint)
11514         (create_exception_master_breakpoint): Use all_objfiles.
11515         * linux-thread-db.c (try_thread_db_load_from_pdir)
11516         (has_libpthread): Use all_objfiles.
11517         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11518         * linespec.c (iterate_over_all_matching_symtabs)
11519         (search_minsyms_for_name): Use all_objfiles.
11520         * maint.c (maintenance_info_sections): Use all_objfiles.
11521         * main.c (captured_main_1): Use all_objfiles.
11522         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11523         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11524         * guile/scm-pretty-print.c
11525         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11526         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11527         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11528         (maintenance_print_msymbols): Use all_objfiles.
11529         * source.c (select_source_symtab): Use all_objfiles.
11530         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11531         * symfile.c (remove_symbol_file_command)
11532         (expand_symtabs_matching, map_symbol_filenames): Use
11533         all_objfiles.
11534         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11535         all_objfiles.
11536         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11537         * objc-lang.c (find_methods): Use all_objfiles.
11538         * objfiles.c (have_partial_symbols, have_full_symbols)
11539         (have_minimal_symbols, qsort_cmp)
11540         (default_iterate_over_objfiles_in_search_order): Use
11541         all_objfiles.
11542         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11543         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11544         (maintenance_check_psymtabs): Use all_objfiles.
11545         (ALL_PSYMTABS): Remove.
11546         * compile/compile-object-run.c (do_module_cleanup): Use
11547         all_objfiles.
11548         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11549         * cp-support.c (add_symbol_overload_list_qualified): Use
11550         all_objfiles.
11551         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11552         Use all_objfiles.
11553         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11554         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11555         all_objfiles.
11556         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11557         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11558         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11559         Uses all_objfiles.
11560         * solib.c (solib_read_symbols): Use all_objfiles
11561
11562 2019-01-09  Tom Tromey  <tom@tromey.com>
11563
11564         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11565         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11566         all_objfiles.
11567         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11568         * symmisc.c (print_symbol_bcache_statistics)
11569         (print_objfile_statistics, maintenance_print_objfiles)
11570         (maintenance_info_symtabs, maintenance_check_symtabs)
11571         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11572         all_objfiles.
11573         * source.c (forget_cached_source_info): Use all_objfiles.
11574         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11575         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11576         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11577         * objfiles.c (update_section_map): Use all_objfiles.
11578         (shared_objfile_contains_address_p): Likewise.
11579         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11580         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11581
11582 2019-01-09  Tom Tromey  <tom@tromey.com>
11583
11584         * common/next-iterator.h: New file.
11585         * objfiles.h (class all_objfiles): New.
11586         (struct objfile_iterator): New.
11587
11588 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11589
11590         * NEWS: Move the description of the changed "frame", "select-frame",
11591          and "info frame" commands to the Changed commands section.
11592
11593 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11594
11595         * gdbtypes.c (check_stub_method_group): Remove handling of old
11596         mangling schemes.
11597         * linespec.c (find_methods): Likewise.
11598         * stabsread.c (read_member_functions): Likewise.
11599         * valops.c (search_struct_method): Likewise.
11600         (value_struct_elt_for_reference): Likewise.
11601         * NEWS: Mention this change.
11602
11603 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11604
11605         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11606         print_source_lines.
11607         * source.c (print_source_lines_base): Update line number check.
11608         (print_source_lines): New function.
11609         (source_lines_range::source_lines_range): New function.
11610         * source.h (class source_lines_range): New class.
11611         (print_source_lines): New declaration.
11612
11613 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11614
11615         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11616
11617 2019-01-08  Tom Tromey  <tom@tromey.com>
11618             Simon Marchi  <simon.marchi@ericsson.com>
11619
11620         PR gdb/24060
11621         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11622         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11623         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11624         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11625         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11626         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11627
11628 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11629
11630         * source.c (select_source_symtab): Move header comment to
11631         declaration in source.h.
11632         (forget_cached_source_info_for_objfile): Likewise.
11633         (forget_cached_source_info): Likewise.
11634         (identify_source_line): Likewise.
11635         * source.h (identify_source_line): Move declaration from symtab.h
11636         and add comment from source.c
11637         (print_source_lines): Likewise.
11638         (forget_cached_source_info_for_objfile): Likewise.
11639         (forget_cached_source_info): Likewise.
11640         (select_source_symtab): Likewise.
11641         (enum print_source_lines_flag): Move definition from symtab.h.
11642         * symtab.h (identify_source_line): Move declaration to source.h.
11643         (print_source_lines): Likewise.
11644         (forget_cached_source_info_for_objfile): Likewise.
11645         (forget_cached_source_info): Likewise.
11646         (select_source_symtab): Likewise.
11647         (enum print_source_lines_flag): Move definition to source.h.
11648         * tui/tui-hooks.c: Add 'source.h' include.
11649
11650 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11651
11652         * source.c (print_source_lines_base): Handle requests to print
11653         reverse line number sequences, and guard against empty lines
11654         string.
11655
11656 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11657
11658         * source.c (print_source_lines_base): Fix skip of '\r' if next
11659         character is '\n'.
11660
11661 2019-01-06  Tom Tromey  <tom@tromey.com>
11662
11663         * c-exp.y (struct c_parse_state) <macro_original_text,
11664         expansion_obstack>: New member.
11665         (macro_original_text, expansion_obstack): Remove globals.
11666         (scan_macro_expansion, scanning_macro_expansion)
11667         (finished_macro_expansion): Update.
11668         (scan_macro_cleanup): Remove.
11669         (yylex, c_parse): Update.
11670
11671 2019-01-06  Tom Tromey  <tom@tromey.com>
11672
11673         * c-exp.y (struct c_parse_state) <strings>: New member.
11674         (operator_stoken): Update.
11675
11676 2019-01-06  Tom Tromey  <tom@tromey.com>
11677
11678         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11679         (union type_stack_elt) <typelist_val>: Now a pointer to
11680         std::vector.
11681         (type_stack_cleanup): Don't declare.
11682         (push_typelist): Update.
11683         * parse.c (pop_typelist): Return a std::vector.
11684         (push_typelist): Take a std::vector.
11685         (follow_types): Update.  Do not free args.
11686         (type_stack_cleanup): Remove.
11687         * c-exp.y (struct c_parse_state): New.
11688         (cpstate): New global.
11689         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11690         (nonempty_typelist): Update.
11691         (func_mod): Create a new vector.
11692         (c_parse): Create a c_parse_state.
11693         (check_parameter_typelist): Do not delete params.
11694         (function_method): Update.  Do not delete type_list.
11695
11696 2019-01-06  Tom Tromey  <tom@tromey.com>
11697
11698         PR gdb/28155:
11699         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11700         check_typedef.
11701         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11702         (print_return_value): Likewise.
11703
11704 2019-01-05  Tom Tromey  <tom@tromey.com>
11705
11706         * contrib/cleanup_check.py: Remove.
11707         * contrib/gcc-with-excheck: Remove.
11708         * contrib/exsummary.py: Remove.
11709         * contrib/excheck.py: Remove.
11710
11711 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11712
11713         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11714         NULL. Initialize tpprev to NULL instead of assigning it
11715         to NULL on the next statement.
11716         * windows-nat.c (windows_delete_thread): Remove check for
11717         main_thread_id before printing thread exit notifications.
11718         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11719         Remove thread ID check against main_thread_id.
11720         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11721         windows_delete_thread.
11722         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11723
11724 2019-01-04  Tom Tromey  <tom@tromey.com>
11725
11726         * compile/compile.c (_initialize_compile): Use upper case for
11727         metasyntactic variables.
11728         * symmisc.c (_initialize_symmisc): Use upper case for
11729         metasyntactic variables.
11730         * psymtab.c (_initialize_psymtab): Use upper case for
11731         metasyntactic variables.
11732         * demangle.c (demangle_command): Use upper case for metasyntactic
11733         variables.
11734         (_initialize_demangler): Likewise.
11735         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11736         variables.
11737
11738 2019-01-03  Tom Tromey  <tom@tromey.com>
11739
11740         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11741
11742 2019-01-03  Tom Tromey  <tom@tromey.com>
11743
11744         * python/py-symtab.c (salpy_str): Update.
11745         (struct salpy_sal_object) <symtab>: Now a PyObject.
11746         (salpy_dealloc): Update.
11747         (del_objfile_sal): Use gdbpy_ref.
11748
11749 2019-01-03  Tom Tromey  <tom@tromey.com>
11750
11751         * python/py-type.c (convert_field): Use new_reference.  Return
11752         gdbpy_ref.
11753         (make_fielditem): Return gdbpy_ref.
11754         (typy_fields): Update.
11755         (typy_getitem): Update.
11756         (field_name): Return gdbpy_ref.  Use new_reference.
11757         (typy_iterator_iternext): Update.
11758
11759 2019-01-03  Tom Tromey  <tom@tromey.com>
11760
11761         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11762
11763 2019-01-03  Tom Tromey  <tom@tromey.com>
11764
11765         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11766         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11767         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11768         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11769         (pspy_set_type_printers): Likewise.
11770         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11771         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11772         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11773         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11774         (objfpy_set_type_printers): Likewise.
11775
11776 2019-01-03  Tom Tromey  <tom@tromey.com>
11777
11778         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11779         (gdbpy_print_stack): Use gdbpy_err_fetch.
11780         * python/python-internal.h (class gdbpy_err_fetch): New class.
11781         (class gdbpy_enter) <m_error_type, m_error_value,
11782         m_error_traceback>: Remove.
11783         <m_error>: New member.
11784         (gdbpy_exception_to_string): Don't declare.
11785         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11786         * python/py-value.c (convert_value_from_python): Use
11787         gdbpy_err_fetch.
11788         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11789         gdbpy_exception_to_string.
11790         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11791         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11792         gdbpy_err_fetch.
11793
11794 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11795
11796         * linux-nat.c (delete_lwp_cleanup): Delete.
11797         (struct lwp_deleter): New struct.
11798         (lwp_info_up): New typedef.
11799         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11800         lwp_info_up.
11801
11802 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11803
11804         * linux-fork.c (class scoped_switch_fork_info): New class.
11805         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11806
11807 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11808
11809         * valops.c (find_overload_match): Remove use of null_cleanup, and
11810         calls to do_cleanups.
11811
11812 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11813
11814         * compile/compile-cplus-types.c
11815         (compile_cplus_instance::decl_name): Handle changes to
11816         cp_func_name.
11817         * cp-support.c (cp_func_name): Update header comment, update
11818         return type.
11819         * cp-support.h (cp_func_name): Update return type in declaration.
11820         * valops.c (find_overload_match): Move temp_func local to top
11821         level of function and change its type.  Use temp_func to hold and
11822         delete temporary string obtained from cp_func_name.
11823
11824 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11825
11826         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11827         gdb::char_vector, remove cleanup, and update uses of `msg`.
11828
11829 2019-01-03  Jim Wilson  <jimw@sifive.com>
11830
11831         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11832
11833 2019-01-02  Tom Tromey  <tom@tromey.com>
11834
11835         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11836         (tdesc_parse_xml): Remove cleanups.
11837         * target-descriptions.h (make_cleanup_free_target_description):
11838         Don't declare.
11839         (target_desc_deleter): New struct.
11840         (target_desc_up): New typedef.
11841         * target-descriptions.c (target_desc_deleter::operator()): Rename
11842         from free_target_description.
11843         (make_cleanup_free_target_description): Remove.
11844
11845 2019-01-02  Tom Tromey  <tom@tromey.com>
11846
11847         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11848         constructor, destructor.
11849         (linespec_parser): Remove typedef.
11850         (~linespec_parser): Rename from linespec_parser_delete.
11851         (linespec_lex_to_end, linespec_complete_label)
11852         (linespec_complete): Update.
11853         (decode_line_full): Remove cleanups.
11854         (decode_line_1): Update.
11855
11856 2019-01-02  Tom Tromey  <tom@tromey.com>
11857
11858         * python/python-internal.h (inferior_to_inferior_object): Change
11859         return type.
11860         * python/py-exitedevent.c (create_exited_event_object): Update.
11861         * python/py-inferior.c (inferior_to_inferior_object): Return
11862         gdbpy_ref.
11863         (python_new_inferior, python_inferior_deleted)
11864         (thread_to_thread_object, delete_thread_object)
11865         (build_inferior_list, gdbpy_selected_inferior): Update.
11866         * python/py-infthread.c (create_thread_object): Update.  Also fail
11867         if inferior_to_inferior_object fails.
11868
11869 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11870
11871         * inferior.h (class inferior) <displaced_step_state>: New field.
11872         * infrun.h (struct displaced_step_state): Move here from
11873         infrun.c.  Initialize fields, add constructor.
11874         <inf>: Remove field.
11875         <reset>: New method.
11876         * infrun.c (struct displaced_step_inferior_state): Move to
11877         infrun.h.
11878         (displaced_step_inferior_states): Remove.
11879         (get_displaced_stepping_state): Adust.
11880         (displaced_step_in_progress_any_inferior): Adjust.
11881         (displaced_step_in_progress_thread): Adjust.
11882         (displaced_step_in_progress): Adjust.
11883         (add_displaced_stepping_state): Remove.
11884         (get_displaced_step_closure_by_addr): Adjust.
11885         (remove_displaced_stepping_state): Remove.
11886         (infrun_inferior_exit): Call displaced_step_state.reset.
11887         (use_displaced_stepping): Don't check for NULL.
11888         (displaced_step_prepare_throw): Call
11889         get_displaced_stepping_state.
11890         (displaced_step_fixup): Don't check for NULL.
11891         (prepare_for_detach): Don't check for NULL.
11892
11893 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11894
11895         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11896          in case of call that did not complete.
11897
11898 2019-01-02  Andrey Utkin  <autkin@undo.io>
11899
11900         * symfile.c (find_separate_debug_file): Fix search of debug files for
11901         remote debuggee.
11902
11903 2019-01-02  Tom Tromey  <tom@tromey.com>
11904
11905         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11906         indentation.
11907         * python/py-frame.c (frapy_older): Remove cast.
11908         (frapy_newer): Likewise.
11909         * python/py-breakpoint.c (local_setattro): Remove cast.
11910         * python/py-arch.c (archpy_name): Remove local variable.
11911         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11912
11913 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11914
11915         * unittests/basic_string_view/element_access/char/empty.cc:
11916         Fix year range in copyright header.
11917
11918 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11919
11920         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11921         Delete.
11922         <operator==>: Update with for removed field.
11923         <hash>: Likewise.
11924         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11925         <isa_features>: ...this.
11926         <abi_features>: New field.
11927         (riscv_isa_flen): Update comment.
11928         (riscv_abi_xlen): New declaration.
11929         (riscv_abi_flen): New declaration.
11930         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11931         isa_features.
11932         (riscv_abi_xlen): New function.
11933         (riscv_isa_flen): Update to get answer from isa_features.
11934         (riscv_abi_flen): New function.
11935         (riscv_has_fp_abi): Update to get answer from abi_features.
11936         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11937         xlen and flen.
11938         (riscv_call_info) <xlen, flen>: Update comment.
11939         (riscv_call_arg_struct): Remove invalid assertions
11940         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11941         is removed.
11942         (riscv_gdbarch_init): Gather isa features and abi features
11943         separately, ensure both match on the gdbarch when reusing an old
11944         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11945         a target with 64-bit float hardware.
11946
11947 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11948
11949         * source.c (search_command_helper): Stop reverse search
11950         when line 1 has been searched.
11951
11952 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11953
11954         * record-full.c (record_full_base_target::close): Rewrite
11955         record_full_core_buf_list free logic.
11956
11957 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11958
11959         * break-catch-syscall.c (print_one_catch_syscall): xfree
11960         the last text.
11961
11962 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11963
11964         * top.c (print_gdb_version): Update Copyright year in version
11965         message.
11966
11967 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11968
11969         Update copyright year range in all GDB files.
11970
11971 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11972
11973         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11974
11975 For older changes see ChangeLog-2018.
11976 \f
11977 Local Variables:
11978 mode: change-log
11979 left-margin: 8
11980 fill-column: 74
11981 version-control: never
11982 coding: utf-8
11983 End:
11984