gdb/ChangeLog

   1 2020-06-18  Pedro Alves  <palves@redhat.com>
   2
   3         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
   4         inferior_ptid.
   5
   6 2020-06-18  Pedro Alves  <palves@redhat.com>
   7
   8         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
   9         inferior_ptid.
  10         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
  11         thread.
  12         (nto_procfs_target::detach): Avoid referencing
  13         inferior_ptid.  Use switch_to_no_thread instead of writing to
  14         inferior_ptid directly.
  15         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
  16         instead of writing to inferior_ptid directly.
  17         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
  18         to thread.
  19
  20 2020-06-18  Pedro Alves  <palves@redhat.com>
  21
  22         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
  23         after creating it, instead of writing to inferior_ptid.
  24         (gdbsim_target_open): Use switch_to_no_thread instead of writing
  25         to inferior_ptid directly.
  26         (gdbsim_target::wait): Don't write to inferior_ptid.
  27
  28 2020-06-18  Pedro Alves  <palves@redhat.com>
  29
  30         * remote.c (remote_target::remote_notice_new_inferior): Use
  31         switch_to_thread instead of writing to inferior_ptid directly.
  32         (remote_target::add_current_inferior_and_thread): Use
  33         switch_to_no_thread instead of writing to inferior_ptid directly.
  34         (extended_remote_target::attach): Use switch_to_inferior_no_thread
  35         and switch_to_thread instead of using set_current_inferior or
  36         writing to inferior_ptid directly.
  37
  38 2020-06-18  Pedro Alves  <palves@redhat.com>
  39
  40         * tracectf.c (ctf_target_open): Switch to added thread instead of
  41         writing to inferior_ptid directly.
  42         (ctf_target::close): Use switch_to_no_thread instead of writing to
  43         inferior_ptid directly.
  44
  45 2020-06-18  Pedro Alves  <palves@redhat.com>
  46
  47         * tracefile-tfile.c (tfile_target_open): Don't write to
  48         inferior_ptid directly, instead switch to added thread.
  49         (tfile_target::close): Use switch_to_no_thread instead of writing
  50         to inferior_ptid directly.
  51
  52 2020-06-18  Pedro Alves  <palves@redhat.com>
  53
  54         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
  55         (procfs_target::detach): Use switch_to_no_thread
  56         instead of writing to inferior_ptid directly.
  57         (do_attach): Change return type to void.  Switch to the added
  58         thread.
  59         (procfs_target::create_inferior): Switch to the added thread.
  60         (procfs_do_thread_registers): Don't write to inferior_ptid.
  61
  62 2020-06-18  Pedro Alves  <palves@redhat.com>
  63
  64         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
  65         of writing to inferior_ptid.
  66         (scoped_restore_exited_inferior): Delete.
  67         (handle_vfork_child_exec_or_exit): Simplify using
  68         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
  69         instead of writing to inferior_ptid.
  70         (THREAD_STOPPED_BY): Delete.
  71         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
  72         (thread_stopped_by_hw_breakpoint): Delete.
  73         (save_waitstatus): Use
  74         scoped_restore_current_thread+switch_to_thread, and call
  75         target_stopped_by_watchpoint instead of
  76         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
  77         instead of thread_stopped_by_sw_breakpoint, and
  78         target_stopped_by_hw_breakpoint instead of
  79         thread_stopped_by_hw_breakpoint.
  80         (handle_inferior_event)
  81         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
  82         inferior_ptid directly, nor
  83         set_current_inferior/set_current_program_space.  Use
  84         switch_to_thread / switch_to_inferior_no_thread instead.
  85
  86 2020-06-18  Pedro Alves  <palves@redhat.com>
  87
  88         * target.c (generic_mourn_inferior): Use switch_to_no_thread
  89         instead of writing to inferior_ptid.
  90
  91 2020-06-18  Pedro Alves  <palves@redhat.com>
  92
  93         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
  94         added thread.
  95         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
  96         to the added thread.
  97         (inf_ptrace_target::detach_success): Use switch_to_no_thread
  98         instead of writing to inferior_ptid.
  99
 100 2020-06-18  Pedro Alves  <palves@redhat.com>
 101
 102         * gdbarch-selftests.c: Include "progspace-and-thread.h".
 103         (register_to_value_test): Mock a program_space too.  Heap-allocate
 104         the address space.  Don't write to inferior_ptid.  Use
 105         switch_to_thread instead.
 106
 107 2020-06-18  Pedro Alves  <palves@redhat.com>
 108
 109         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
 110         Delete.
 111         (find_signalled_thread()): New, factored out from
 112         linux_make_corefile_notes and adjusted to handle exited threads.
 113         (linux_make_corefile_notes): Adjust to use the new
 114         find_signalled_thread.
 115
 116 2020-06-18  Pedro Alves  <palves@redhat.com>
 117
 118         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
 119         of saving/restoring inferior_ptid.
 120
 121 2020-06-17  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
 124         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
 125         declare.
 126         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
 127
 128 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
 129
 130         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
 131         of partial symtabs.
 132
 133 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 134
 135         * regformats/reg-arm.dat: Remove.
 136         * regformats/reg-bfin.dat: Remove.
 137         * regformats/reg-cris.dat: Remove.
 138         * regformats/reg-crisv32.dat: Remove.
 139         * regformats/reg-m32r.dat: Remove.
 140         * regformats/reg-tilegx.dat: Remove.
 141         * regformats/reg-tilegx32.dat: Remove.
 142
 143 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 144
 145         * features/Makefile (WHICH): Remove arm files.
 146         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 147         * regformats/arm/arm-with-neon.dat: Remove.
 148         * regformats/arm/arm-with-vfpv2.dat: Remove.
 149         * regformats/arm/arm-with-vfpv3.dat: Remove.
 150
 151 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 152
 153         * features/Makefile (XMLTOC): Remove rx.xml.
 154
 155 2020-06-17  Pedro Alves  <palves@redhat.com>
 156
 157         * gdbthread.h (thread_control_state) <trap_expected> Update
 158         comments.
 159
 160 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 161
 162         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
 163         ada_language::lookup_symbol_nonlocal.
 164         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
 165         (ada_language::lookup_symbol_nonlocal): New member function,
 166         implementation from ada_lookup_symbol_nonlocal.
 167         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
 168         initializer.
 169         (cplus_language_data): Delete la_lookup_symbol_nonlocal
 170         initializer.
 171         (cplus_language::lookup_symbol_nonlocal): New member function.
 172         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
 173         (minimal_language_data) Likewise.
 174         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
 175         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
 176         initializer.
 177         (d_language::lookup_symbol_nonlocal): New member function.
 178         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
 179         initializer.
 180         (f_language::lookup_symbol_nonlocal): New member function.
 181         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
 182         initializer.
 183         * language.c (unknown_language_data): Likewise.
 184         (auto_language_data): Likewise.
 185         * language.h (language_data): Delete la_lookup_symbol_nonlocal
 186         field.
 187         (language_defn::lookup_symbol_nonlocal): New member function.
 188         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
 189         initializer.
 190         * objc-lang.c (objc_language_data): Likewise.
 191         * opencl-lang.c (opencl_language_data): Likewise.
 192         * p-lang.c (pascal_language_data): Likewise.
 193         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
 194         rust_language::lookup_symbol_nonlocal.
 195         (rust_language_data): Delete la_lookup_symbol_nonlocal
 196         initializer.
 197         (rust_language::lookup_symbol_nonlocal): New member function,
 198         implementation from rust_lookup_symbol_nonlocal.
 199         * symtab.c (lookup_symbol_aux): Update call to
 200         lookup_symbol_nonlocal.
 201         (basic_lookup_symbol_nonlocal): Rename to...
 202         (language_defn::lookup_symbol_nonlocal): ...this, and update
 203         header comment.  Remove language_defn parameter, and replace with
 204         uses of `this'.
 205         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
 206
 207 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * ada-lang.c (ada_language_data): Delete la_value_print_inner
 210         initializer.
 211         (ada_language::value_print_inner): New member function.
 212         * c-lang.c (c_language_data): Delete la_value_print_inner
 213         initializer.
 214         (cplus_language_data): Likewise.
 215         (asm_language_data): Likewise.
 216         (minimal_language_data): Likewise.
 217         * d-lang.c (d_language_data): Likewise.
 218         (d_language::value_print_inner): New member function.
 219         * f-lang.c (f_language_data): Delete la_value_print_inner
 220         initializer.
 221         (f_language::value_print_inner): New member function.
 222         * f-lang.h (f_value_print_innner): Rename to...
 223         (f_value_print_inner): ...this (note spelling of 'inner').
 224         * f-valprint.c (f_value_print_innner): Rename to...
 225         (f_value_print_inner): ...this (note spelling of 'inner').
 226         * go-lang.c (go_language_data): Delete la_value_print_inner
 227         initializer.
 228         (go_language::value_print_inner): New member function.
 229         * language.c (language_defn::value_print_inner): Define new member
 230         function.
 231         (unk_lang_value_print_inner): Delete.
 232         (unknown_language_data): Delete la_value_print_inner initializer.
 233         (unknown_language::value_print_inner): New member function.
 234         (auto_language_data): Delete la_value_print_inner initializer.
 235         (auto_language::value_print_inner): New member function.
 236         * language.h (language_data): Delete la_value_print_inner field.
 237         (language_defn::value_print_inner): Delcare new member function.
 238         * m2-lang.c (m2_language_data): Delete la_value_print_inner
 239         initializer.
 240         (m2_language::value_print_inner): New member function.
 241         * objc-lang.c (objc_language_data): Delete la_value_print_inner
 242         initializer.
 243         * opencl-lang.c (opencl_language_data): Likewise.
 244         * p-lang.c (pascal_language_data): Likewise.
 245         (pascal_language::value_print_inner): New member function.
 246         * rust-lang.c (rust_language_data): Delete la_value_print_inner
 247         initializer.
 248         (rust_language::value_print_inner): New member function.
 249         * valprint.c (do_val_print): Update call to value_print_inner.
 250
 251 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 252
 253         * ada-lang.c (ada_language_data): Delete la_value_print
 254         initializer.
 255         (ada_language::value_print): New member function.
 256         * c-lang.c (c_language_data): Delete la_value_print initializer.
 257         (cplus_language_data): Likewise.
 258         (asm_language_data): Likewise.
 259         (minimal_language_data): Likewise.
 260         * d-lang.c (d_language_data): Likewise.
 261         * f-lang.c (f_language_data): Likewise.
 262         * go-lang.c (go_language_data): Likewise.
 263         * language.c (unk_lang_value_print): Delete.
 264         (language_defn::value_print): Define new member function.
 265         (unknown_language_data): Delete la_value_print initializer.
 266         (unknown_language::value_print): New member function.
 267         (auto_language_data): Delete la_value_print initializer.
 268         (auto_language::value_print): New member function.
 269         * language.h (language_data): Delete la_value_print field.
 270         (language_defn::value_print): Declare new member function.
 271         (LA_VALUE_PRINT): Update call to value_print.
 272         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
 273         * objc-lang.c (objc_language_data): Likewise.
 274         * opencl-lang.c (opencl_language_data): Likewise.
 275         * p-lang.c (pascal_language_data): Likewise.
 276         (pascal_language::value_print): New member function.
 277         * rust-lang.c (rust_language_data): Delete la_value_print
 278         initializer.
 279
 280 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * ada-lang.c (ada_watch_location_expression): Rename to
 283         ada_language::watch_location_expression.
 284         (ada_language_data): Delete la_watch_location_expression
 285         initializer.
 286         (ada_language::watch_location_expression): New member function,
 287         implementation from ada_watch_location_expression.
 288         * breakpoint.c (watch_command_1): Update call to
 289         watch_location_expression.
 290         * c-lang.c (c_watch_location_expression): Rename to
 291         language_defn::watch_location_expression.
 292         (c_language_data): Delete la_watch_location_expression
 293         initializer.
 294         (cplus_language_data): Likewise.
 295         (asm_language_data): Likewise.
 296         (minimal_language_data): Likewise.
 297         * c-lang.h (c_watch_location_expression): Delete declaration.
 298         * d-lang.c (d_language_data): Delete la_watch_location_expression
 299         initializer.
 300         * f-lang.c (f_language_data): Likewise.
 301         * go-lang.c (go_language_data): Likewise.
 302         * language.c (language_defn::watch_location_expression): Member
 303         function implementation from c_watch_location_expression.
 304         (unknown_language_data): Delete la_watch_location_expression
 305         initializer.
 306         (auto_language_data): Likewise.
 307         * language.h (language_data): Delete la_watch_location_expression
 308         field.
 309         (language_defn::watch_location_expression): Declare new member
 310         function.
 311         * m2-lang.c (m2_language_data): Delete
 312         la_watch_location_expression initializer.
 313         * objc-lang.c (objc_language_data): Likewise.
 314         * opencl-lang.c (opencl_language_data): Likewise.
 315         * p-lang.c (pascal_language_data): Likewise.
 316         * rust-lang.c (rust_watch_location_expression): Rename to
 317         rust_language::watch_location_expression.
 318         (rust_language_data): Delete la_watch_location_expression
 319         initializer.
 320         (rust_language::watch_location_expression): New member function,
 321         implementation from rust_watch_location_expression.
 322
 323 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
 326         ada_language::collect_symbol_completion_matches.
 327         (ada_language_data): Delete la_collect_symbol_completion_matches
 328         initializer.
 329         (ada_language::collect_symbol_completion_matches): New member
 330         function, implementation from
 331         ada_collect_symbol_completion_matches.
 332         * c-lang.c (c_language_data): Delete
 333         la_collect_symbol_completion_matches initializer.
 334         (cplus_language_data): Likewise.
 335         (asm_language_data): Likewise.
 336         (minimal_language_data): Likewise.
 337         * d-lang.c (d_language_data): Likewise.
 338         * f-lang.c (f_collect_symbol_completion_matches): Rename to
 339         f_language::collect_symbol_completion_matches.
 340         (f_language_data): Delete la_collect_symbol_completion_matches
 341         initializer.
 342         (f_language::collect_symbol_completion_matches) New member
 343         function, implementation from f_collect_symbol_completion_matches.
 344         * go-lang.c (go_language_data): Delete
 345         la_collect_symbol_completion_matches initializer.
 346         * language.c (unknown_language_data): Likewise.
 347         (auto_language_data): Likewise.
 348         * language.h (language_data): Delete
 349         la_collect_symbol_completion_matches field.
 350         (language_defn::collect_symbol_completion_matches): New member
 351         function.
 352         * m2-lang.c (m2_language_data): Delete
 353         la_collect_symbol_completion_matches initializer.
 354         * objc-lang.c (objc_language_data): Likewise.
 355         * opencl-lang.c (opencl_language_data): Likewise.
 356         * p-lang.c (pascal_language_data): Likewise.
 357         * rust-lang.c (rust_language_data): Likewise.
 358         * symtab.c (default_collect_symbol_completion_matches): Delete.
 359         (collect_symbol_completion_matches): Update call to
 360         collect_symbol_completion_matches.
 361         (collect_symbol_completion_matches_type): Likewise.
 362         * symtab.h (default_collect_symbol_completion_matches): Delete
 363         declaration.
 364
 365 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 366
 367         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
 368         (ada_language_data): Delete la_word_break_characters initializer.
 369         (ada_language::word_break_characters): New member function.
 370         * c-lang.c (c_language_data): Delete la_word_break_characters
 371         initializer.
 372         (cplus_language_data): Likewise.
 373         (asm_language_data): Likewise.
 374         (minimal_language_data): Likewise.
 375         * completer.c: Update global comment.
 376         (advance_to_expression_complete_word_point): Update call to
 377         word_break_characters.
 378         (complete_files_symbols): Likewise.
 379         (complete_line_internal_1): Likewise.
 380         (default_completer_handle_brkchars): Likewise.
 381         (skip_quoted_chars): Likewise.
 382         * d-lang.c (d_language_data): Delete la_word_break_characters
 383         initializer.
 384         * f-lang.c (f_word_break_characters): Delete.
 385         (f_language_data): Delete la_word_break_characters initializer.
 386         (f_language::word_break_characters): New member function.
 387         * go-lang.c (go_language_data): Delete la_word_break_characters
 388         initializer.
 389         * language.c (unknown_language_data): Likewise.
 390         (auto_language_data): Likewise.
 391         * language.h (default_word_break_characters): Move declaration to
 392         earlier in the file.
 393         (language_data): Delete la_word_break_characters field.
 394         (language_defn::word_break_characters): New member function.
 395         * m2-lang.c (m2_language_data): Delete la_word_break_characters
 396         initializer.
 397         * objc-lang.c (objc_language_data): Likewise.
 398         * opencl-lang.c (opencl_language_data): Likewise.
 399         * p-lang.c (pascal_language_data): Likewise.
 400         * rust-lang.c (rust_language_data): Likewise.
 401
 402 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 403
 404         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
 405         (ada_language_data): Delete la_get_symbol_name_matcher
 406         initializer.
 407         (language_defn::get_symbol_name_matcher_inner): New member
 408         function.
 409         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
 410         initializer.
 411         (cplus_language_data): Likewise.
 412         (cplus_language::get_symbol_name_matcher_inner): New member
 413         function.
 414         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
 415         (minimal_language_data): Likewise.
 416         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
 417         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
 418         initializer.
 419         * dictionary.c (iter_match_first_hashed): Update call to
 420         get_symbol_name_matcher.
 421         (iter_match_next_hashed): Likewise.
 422         (iter_match_next_linear): Likewise.
 423         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
 424         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
 425         initializer.
 426         (f_language::get_symbol_name_matcher_inner): New member function.
 427         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
 428         initializer.
 429         * language.c (default_symbol_name_matcher): Update header comment,
 430         make static.
 431         (language_defn::get_symbol_name_matcher): New definition.
 432         (language_defn::get_symbol_name_matcher_inner): Likewise.
 433         (get_symbol_name_matcher): Delete.
 434         (unknown_language_data): Delete la_get_symbol_name_matcher
 435         initializer.
 436         (auto_language_data): Likewise.
 437         * language.h (language_data): Delete la_get_symbol_name_matcher
 438         field.
 439         (language_defn::get_symbol_name_matcher): New member function.
 440         (language_defn::get_symbol_name_matcher_inner): Likewise.
 441         (default_symbol_name_matcher): Delete declaration.
 442         * linespec.c (find_methods): Update call to
 443         get_symbol_name_matcher.
 444         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
 445         initializer.
 446         * minsyms.c (lookup_minimal_symbol): Update call to
 447         get_symbol_name_matcher.
 448         (iterate_over_minimal_symbols): Likewise.
 449         * objc-lang.c (objc_language_data): Delete
 450         la_get_symbol_name_matcher initializer.
 451         * opencl-lang.c (opencl_language_data): Likewise.
 452         * p-lang.c (pascal_language_data): Likewise.
 453         * psymtab.c (psymbol_name_matches): Update call to
 454         get_symbol_name_matcher.
 455         * rust-lang.c (rust_language_data): Delete
 456         la_get_symbol_name_matcher initializer.
 457         * symtab.c (symbol_matches_search_name): Update call to
 458         get_symbol_name_matcher.
 459         (compare_symbol_name): Likewise.
 460
 461 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 462
 463         * ada-lang.c (ada_language_data): Delete la_compute_program
 464         initializer.
 465         * c-lang.c (c_language_data): Likewise.
 466         (c_language::compute_program): New member function.
 467         (cplus_language_data): Delete la_compute_program initializer.
 468         (cplus_language::compute_program): New member function.
 469         (asm_language_data): Delete la_compute_program initializer.
 470         (minimal_language_data): Likewise.
 471         * c-lang.h (c_compute_program): Update comment.
 472         (cplus_compute_program): Likewise.
 473         * compile/compile-c-support.c (c_compute_program): Likewise.
 474         (cplus_compute_program): Likewise.
 475         * compile/compile.c (compile_to_object): Update call to
 476         la_compute_program.
 477         * d-lang.c (d_language_data): Delete la_compute_program
 478         initializer.
 479         * f-lang.c (f_language_data): Likewise.
 480         * go-lang.c (go_language_data): Likewise.
 481         * language.c (unknown_language_data): Likewise.
 482         (auto_language_data): Likewise.
 483         * language.h (language_data): Delete la_compute_program field.
 484         (language_defn::compute_program): New member function.
 485         * m2-lang.c (m2_language_data): Delete la_compute_program
 486         initializer.
 487         * objc-lang.c (objc_language_data): Likewise.
 488         * opencl-lang.c (opencl_language_data): Likewise.
 489         * p-lang.c (pascal_language_data): Likewise.
 490         * rust-lang.c (rust_language_data): Likewise.
 491
 492 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * ada-lang.c (ada_language_data) Delete
 495         la_class_name_from_physname initializer.
 496         * c-lang.c (c_language_data): Likewise.
 497         (cplus_language_data): Likewise.
 498         (cplus_language::class_name_from_physname): New member function.
 499         (asm_language_data): Delete la_class_name_from_physname
 500         initializer.
 501         (minimal_language_data): Likewise.
 502         * d-lang.c (d_language_data): Likewise.
 503         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
 504         method on language_defn class.
 505         (guess_full_die_structure_name): Likewise.
 506         * f-lang.c (f_language_data): Delete la_class_name_from_physname
 507         initializer.
 508         * go-lang.c (go_language_data): Likewise.
 509         * language.c (language_class_name_from_physname): Delete.
 510         (unk_lang_class_name): Delete.
 511         (unknown_language_data): Delete la_class_name_from_physname
 512         initializer.
 513         (auto_language_data): Likewise.
 514         * language.h (language_data): Delete la_class_name_from_physname
 515         field.
 516         (language_defn::class_name_from_physname): New function.
 517         (language_class_name_from_physname): Delete declaration.
 518         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
 519         initializer.
 520         * objc-lang.c (objc_language_data): Likewise.
 521         * opencl-lang.c (opencl_language_data): Likewise.
 522         * p-lang.c (pascal_language_data): Likewise.
 523         * rust-lang.c (rust_language_data): Likewise.
 524
 525 2020-06-16  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-data.h (STATUS_NAME): New macro.
 528         * tui/tui-layout.c (tui_remove_some_windows)
 529         (initialize_known_windows, tui_register_window)
 530         (tui_layout_split::remove_windows, initialize_layouts)
 531         (tui_new_layout_command): Don't use hard-coded window names.
 532
 533 2020-06-16  Tom Tromey  <tom@tromey.com>
 534
 535         PR tui/25348:
 536         * tui/tui.c (tui_ensure_readline_initialized): Rename from
 537         tui_initialize_readline.  Only run once.  Call rl_initialize.
 538         * tui/tui.h (tui_ensure_readline_initialized): Rename from
 539         tui_initialize_readline.
 540         * tui/tui-io.c (tui_setup_io): Call
 541         tui_ensure_readline_initialized.
 542         * tui/tui-interp.c (tui_interp::init): Update.
 543
 544 2020-06-16  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
 547         Also preserve the status window.
 548
 549 2020-06-16  Tom Tromey  <tom@tromey.com>
 550
 551         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
 552         where m_window==nullptr.
 553
 554 2020-06-15  Tom Tromey  <tromey@adacore.com>
 555
 556         * windows-nat.c (windows_nat::handle_output_debug_string):
 557         Update.
 558         (windows_nat::handle_ms_vc_exception): Update.
 559         * target.h (target_read_string): Change API.
 560         * target.c (target_read_string): Change API.
 561         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
 562         Update.
 563         * solib-frv.c (frv_current_sos): Update.
 564         * solib-dsbt.c (dsbt_current_sos): Update.
 565         * solib-darwin.c (darwin_current_sos): Update.
 566         * linux-thread-db.c (inferior_has_bug): Update.
 567         * expprint.c (print_subexp_standard): Update.
 568         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
 569         (ada_exception_message_1): Update.
 570
 571 2020-06-15  Tom Tromey  <tromey@adacore.com>
 572
 573         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
 574
 575 2020-06-15  Tom Tromey  <tromey@adacore.com>
 576
 577         * valprint.c (read_string): Update comment.
 578         * target.c (MIN): Remove.
 579         (target_read_string): Rewrite.
 580
 581 2020-06-15  Tom Tromey  <tromey@adacore.com>
 582
 583         * corefile.c (read_memory_string): Remove.
 584         * ada-valprint.c (ada_value_print_ptr): Update.
 585         * ada-lang.h (ada_tag_name): Change return type.
 586         * ada-lang.c (type_from_tag): Update.
 587         (ada_tag_name_from_tsd): Change return type.  Use
 588         target_read_string.
 589         (ada_tag_name): Likewise.
 590         * gdbcore.h (read_memory_string): Don't declare.
 591
 592 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
 593
 594         * symtab.c (rbreak_command): Ignore Windows drive colon.
 595
 596 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
 597
 598         * NEWS: Mention removed GDBserver host support.
 599
 600 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
 601
 602         * features/riscv/rebuild-csr-xml.sh: Updated.
 603
 604 2020-06-11  Tom Tromey  <tom@tromey.com>
 605
 606         PR gdb/18318:
 607         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
 608
 609 2020-06-09  Jonny Grant  <jg@jguk.org>
 610 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
 611
 612         * main.c (captured_main_1): Don't print new line after help.
 613         (print_gdb_help): add mailing list and IRC channel information
 614         to --help.  Add new lines between items in the footer.  Remove
 615         quotes around bug url.
 616
 617 2020-06-11  Keith Seitz  <keiths@redhat.com>
 618
 619         PR gdb/21356
 620         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
 621         Resolve typedefs for type length calculations.
 622
 623 2020-06-10  Tom de Vries  <tdevries@suse.de>
 624
 625         PR ada/24713
 626         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
 627         (write_psymbols): Enable .gdb_index for ada.
 628         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
 629         ada.
 630
 631 2020-06-10  Tom de Vries  <tdevries@suse.de>
 632
 633         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
 634         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
 635         namei" instead of "const char *name" argument.
 636         (dw2_map_matching_symbols): Use "offset_type namei" variant of
 637         dw2_symtab_iter_init.
 638
 639 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 640
 641         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
 642         to use type::field and field::type instead.
 643
 644 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 645
 646         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
 647         to use field::type instead.
 648
 649 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 650
 651         * gdbtypes.h (struct field) <type, set_type>: New methods.
 652         Rename `type` field to...
 653         <m_type>: ... this.  Change references throughout to use type or
 654         set_type methods.
 655         (FIELD_TYPE): Use field::type.  Change call sites that modify
 656         the field's type to use field::set_type instead.
 657
 658 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 659
 660         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
 661         to use type::index_type instead.
 662
 663 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
 664
 665         * gdbtypes.h (struct type) <index_type, set_index_type>: New
 666         methods.
 667         (TYPE_INDEX_TYPE): Use type::index_type.
 668         * gdbtypes.c (create_array_type_with_stride): Likewise.
 669
 670 2020-06-07  Tom Tromey  <tom@tromey.com>
 671
 672         * valprint.c (generic_val_print_float): Remove "embedded_offset"
 673         parameter.
 674         (generic_value_print): Update.
 675
 676 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         Revert commit 982a38f60b0.
 679         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
 680
 681 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 682
 683         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
 684         avoid use after free.
 685
 686 2020-06-05  Tom de Vries  <tdevries@suse.de>
 687
 688         * NEWS: Fix typos.
 689
 690 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
 691
 692         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
 693         the per_bfd object.
 694         (dwarf2_read_debug_names): Likewise.
 695         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
 696         object when re-using a per_bfd object with an index.
 697
 698 2020-06-03  Tom de Vries  <tdevries@suse.de>
 699
 700         PR symtab/26046
 701         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
 702         children for C++.
 703         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
 704         DW_TAG_subprogram.
 705
 706 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * ada-lang.c (ada_language_data): Delete skip_trampoline
 709         initializer.
 710         * c-lang.c (c_language_data): Likewise.
 711         (cplus_language_data): Likewise.
 712         (cplus_language::skip_trampoline): New member function.
 713         (asm_language_data): Delete skip_trampoline initializer.
 714         (minimal_language_data): Likewise.
 715         * d-lang.c (d_language_data): Likewise.
 716         * f-lang.c (f_language_data): Likewise.
 717         * go-lang.c (go_language_data): Likewise.
 718         * language.c (unk_lang_trampoline): Delete function.
 719         (skip_language_trampoline): Update.
 720         (unknown_language_data): Delete skip_trampoline initializer.
 721         (auto_language_data): Likewise.
 722         * language.h (language_data): Delete skip_trampoline field.
 723         (language_defn::skip_trampoline): New function.
 724         * m2-lang.c (m2_language_data): Delete skip_trampoline
 725         initializer.
 726         * objc-lang.c (objc_skip_trampoline): Delete function, move
 727         implementation to objc_language::skip_trampoline.
 728         (objc_language_data): Delete skip_trampoline initializer.
 729         (objc_language::skip_trampoline): New member function with
 730         implementation from objc_skip_trampoline.
 731         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
 732         initializer.
 733         * p-lang.c (pascal_language_data): Likewise.
 734         * rust-lang.c (rust_language_data): Likewise.
 735
 736 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
 739         (ada_language::demangle): New member function.
 740         * c-lang.c (c_language_data): Delete la_demangle initializer.
 741         (cplus_language_data): Delete la_demangle initializer.
 742         (cplus_language::demangle): New member function.
 743         (asm_language_data): Delete la_demangle initializer.
 744         (minimal_language_data): Delete la_demangle initializer.
 745         * d-lang.c (d_language_data): Delete la_demangle initializer.
 746         (d_language::demangle): New member function.
 747         * f-lang.c (f_language_data): Delete la_demangle initializer.
 748         (f_language::demangle): New member function.
 749         * go-lang.c (go_language_data): Delete la_demangle initializer.
 750         (go_language::demangle): New member function.
 751         * language.c (language_demangle): Update.
 752         (unk_lang_demangle): Delete.
 753         (unknown_language_data): Delete la_demangle initializer.
 754         (unknown_language::demangle): New member function.
 755         (auto_language_data): Delete la_demangle initializer.
 756         (auto_language::demangle): New member function.
 757         * language.h (language_data): Delete la_demangle field.
 758         (language_defn::demangle): New function.
 759         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
 760         * objc-lang.c (objc_language_data): Delete la_demangle
 761         initializer.
 762         (objc_language::demangle): New member function.
 763         * opencl-lang.c (opencl_language_data): Delete la_demangle
 764         initializer.
 765         * p-lang.c (pascal_language_data): Likewise.
 766         * rust-lang.c (rust_language_data): Likewise.
 767         (rust_language::demangle): New member function.
 768
 769 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 770
 771         * ada-lang.c (ada_language_data): Delete la_print_type
 772         initializer.
 773         (ada_language::print_type): New member function.
 774         * c-lang.c (c_language_data): Delete la_print_type initializer.
 775         (c_language::print_type): New member function.
 776         (cplus_language_data): Delete la_print_type initializer.
 777         (cplus_language::print_type): New member function.
 778         (asm_language_data): Delete la_print_type initializer.
 779         (asm_language::print_type): New member function.
 780         (minimal_language_data): Delete la_print_type initializer.
 781         (minimal_language::print_type): New member function.
 782         * d-lang.c (d_language_data): Delete la_print_type initializer.
 783         (d_language::print_type): New member function.
 784         * f-lang.c (f_language_data): Delete la_print_type initializer.
 785         (f_language::print_type): New member function.
 786         * go-lang.c (go_language_data): Delete la_print_type initializer.
 787         (go_language::print_type): New member function.
 788         * language.c (unk_lang_print_type): Delete.
 789         (unknown_language_data): Delete la_print_type initializer.
 790         (unknown_language::print_type): New member function.
 791         (auto_language_data): Delete la_print_type initializer.
 792         (auto_language::print_type): New member function.
 793         * language.h (language_data): Delete la_print_type field.
 794         (language_defn::print_type): New function.
 795         (LA_PRINT_TYPE): Update.
 796         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
 797         (m2_language::print_type): New member function.
 798         * objc-lang.c (objc_language_data): Delete la_print_type
 799         initializer.
 800         (objc_language::print_type): New member function.
 801         * opencl-lang.c (opencl_print_type): Delete, implementation moved
 802         to opencl_language::print_type.
 803         (opencl_language_data): Delete la_print_type initializer.
 804         (opencl_language::print_type): New member function, implementation
 805         from opencl_print_type.
 806         * p-lang.c (pascal_language_data): Delete la_print_type
 807         initializer.
 808         (pascal_language::print_type): New member function.
 809         * rust-lang.c (rust_print_type): Delete, implementation moved to
 810         rust_language::print_type.
 811         (rust_language_data): Delete la_print_type initializer.
 812         (rust_language::print_type): New member function, implementation
 813         from rust_print_type.
 814
 815 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 816
 817         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
 818         implementation moves to...
 819         (ada_language::sniff_from_mangled_name): ...here.  Update return
 820         type.
 821         (ada_language_data): Delete la_sniff_from_mangled_name
 822         initializer.
 823         * c-lang.c (c_language_data): Likewise.
 824         (cplus_language_data): Likewise.
 825         (cplus_language::sniff_from_mangled_name): New member function,
 826         implementation taken from gdb_sniff_from_mangled_name.
 827         (asm_language_data): Delete la_sniff_from_mangled_name
 828         initializer.
 829         (minimal_language_data): Likewise.
 830         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
 831         implementation moves to cplus_language::sniff_from_mangled_name.
 832         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
 833         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
 834         moves to...
 835         (d_language::sniff_from_mangled_name): ...here.
 836         (d_language_data): Delete la_sniff_from_mangled_name initializer.
 837         * f-lang.c (f_language_data): Likewise.
 838         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
 839         moves to...
 840         (go_language::sniff_from_mangled_name): ...here.
 841         (go_language_data): Delete la_sniff_from_mangled_name initializer.
 842         * language.c (language_sniff_from_mangled_name): Delete.
 843         (unknown_language_data): Delete la_sniff_from_mangled_name
 844         initializer.
 845         (auto_language_data): Likewise.
 846         * language.h (language_data): Delete la_sniff_from_mangled_name
 847         field.
 848         (language_defn::sniff_from_mangled_name): New function.
 849         (language_sniff_from_mangled_name): Delete declaration.
 850         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
 851         field.
 852         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
 853         implementation moves to...
 854         (objc_language::sniff_from_mangled_name): ...here.
 855         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
 856         * opencl-lang.c (opencl_language_data): Likewise.
 857         * p-lang.c (pascal_language_data): Likewise.
 858         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
 859         implementation moves to...
 860         (rust_language::sniff_from_mangled_name): ...here.
 861         (rust_language_data): Delete la_sniff_from_mangled_name
 862         initializer.
 863         * symtab.c (symbol_find_demangled_name): Call
 864         sniff_from_mangled_name member function.
 865
 866 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 867
 868         * ada-lang.c (ada_language_data): Delete la_search_name_hash
 869         initializer.
 870         * c-lang.c (c_language_data): Likewise.
 871         (cplus_language_data): Likewise.
 872         (cplus_language::search_name_hash): New member function.
 873         (asm_language_data): Delete la_search_name_hash initializer.
 874         (minimal_language_data): Likewise.
 875         * d-lang.c (d_language_data): Likewise.
 876         * dictionary.c (default_search_name_hash): Rename to...
 877         (language_defn::search_name_hash): ...this.
 878         * f-lang.c (f_language_data): Likewise.
 879         (f_language::search_name_hash): New member function.
 880         * go-lang.c (go_language_data): Delete la_search_name_hash
 881         initializer.
 882         * language.c (unknown_language_data): Likewise.
 883         (auto_language_data): Likewise.
 884         * language.h (struct language_data): Delete la_search_name_hash
 885         field.
 886         (language_defn::search_name_hash): Declare new member function.
 887         (default_search_name_hash): Delete declaration.
 888         * m2-lang.c (m2_language_data): Delete la_search_name_hash
 889         initializer.
 890         * objc-lang.c (objc_language_data): Likewise.
 891         * opencl-lang.c (opencl_language_data): Likewise.
 892         * p-lang.c (pascal_language_data): Likewise.
 893         * rust-lang.c (rust_language_data): Likewise.
 894         * symtab.c (search_name_hash): Update call.
 895
 896 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
 899         initializer.
 900         * c-lang.c (class compile_instance): Declare.
 901         (c_language_data): Delete la_get_compile_instance initializer.
 902         (c_language::get_compile_instance): New member function.
 903         (cplus_language_data): Delete la_get_compile_instance initializer.
 904         (cplus_language::get_compile_instance): New member function.
 905         (asm_language_data): Delete la_get_compile_instance initializer.
 906         (minimal_language_data): Likewise.
 907         * c-lang.h (c_get_compile_context): Update comment.
 908         (cplus_get_compile_context): Update comment.
 909         * compile/compile.c (compile_to_object): Update calls, don't rely
 910         on function pointer being NULL.
 911         * d-lang.c (d_language_data): Delete la_get_compile_instance
 912         initializer.
 913         * f-lang.c (f_language_data): Likewise.
 914         * go-lang.c (go_language_data): Likewise.
 915         * language.c (unknown_language_data): Likewise.
 916         (auto_language_data): Likewise.
 917         * language.h (language_data): Delete la_get_compile_instance field.
 918         (language_defn::get_compile_instance): New member function.
 919         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
 920         initializer.
 921         * objc-lang.c (objc_language_data): Likewise.
 922         * opencl-lang.c (opencl_language_data): Likewise.
 923         * p-lang.c (pascal_language_data): Likewise.
 924         * rust-lang.c (rust_language_data): Likewise.
 925
 926 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 927
 928         * ada-lang.c (ada_add_all_symbols): Update comment.
 929         (ada_iterate_over_symbols): Delete, move implementation to...
 930         (ada_language::iterate_over_symbols): ...here, a new member
 931         function, rewrite to use range based for loop.
 932         (ada_language_data): Delete la_iterate_over_symbols initializer.
 933         * c-lang.c (c_language_data): Likewise.
 934         (cplus_language_data): Likewise.
 935         (asm_language_data): Likewise.
 936         (minimal_language_data): Likewise.
 937         * d-lang.c (d_language_data): Likewise.
 938         * f-lang.c (f_language_data): Likewise.
 939         * go-lang.c (go_language_data): Likewise.
 940         * language.c (unknown_language_data): Likewise.
 941         (auto_language_data): Likewise.
 942         * language.h (language_data): Delete la_iterate_over_symbols field.
 943         (language_defn::iterate_over_symbols): New member function.
 944         (LA_ITERATE_OVER_SYMBOLS): Update.
 945         * linespec.c (iterate_over_all_matching_symtabs): Update.
 946         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
 947         initializer.
 948         * objc-lang.c (objc_language_data): Likewise.
 949         * opencl-lang.c (opencl_language_data): Likewise.
 950         * p-lang.c (pascal_language_data): Likewise.
 951         * rust-lang.c (rust_language_data): Likewise.
 952
 953 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * ada-lang.c (ada_language_data): Delete
 956         la_lookup_transparent_type initializer.
 957         * c-lang.c (c_language_data): Likewise.
 958         (cplus_language_data): Likewise.
 959         (cplus_language::lookup_transparent_type): New member function.
 960         (asm_language_data): Delete la_lookup_transparent_type
 961         initializer.
 962         (minimal_language_data): Likewise.
 963         * d-lang.c (d_language_data): Likewise.
 964         * f-lang.c (f_language_data): Likewise.
 965         * go-lang.c (go_language_data): Likewise.
 966         * language.c (unknown_language_data): Likewise.
 967         (auto_language_data): Likewise.
 968         * language.h (struct language_data): Delete
 969         la_lookup_transparent_type field.
 970         (language_defn::lookup_transparent_type): New member function.
 971         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
 972         initializer.
 973         * objc-lang.c (objc_language_data): Likewise.
 974         * opencl-lang.c (opencl_language_data): Likewise.
 975         * p-lang.c (pascal_language_data): Likewise.
 976         * rust-lang.c (rust_language_data): Likewise.
 977         * symtab.c (symbol_matches_domain): Update call.
 978
 979 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 980
 981         * ada-lang.c (ada_language_arch_info): Delete function, move
 982         implementation to...
 983         (ada_language::language_arch_info): ...here, a new member
 984         function.
 985         (ada_language_data): Delete la_language_arch_info.
 986         * c-lang.c (c_language_data): Likewise.
 987         (c_language::language_arch_info): New member function.
 988         (cplus_language_arch_info): Delete function, move
 989         implementation to...
 990         (cplus_language::language_arch_info): ...here, a new member
 991         function.
 992         (cplus_language_data): Delete la_language_arch_info.
 993         (asm_language_data): Likewise.
 994         (asm_language::language_arch_info): New member function.
 995         (minimal_language_data): Delete la_language_arch_info.
 996         (minimal_language::language_arch_info): New member function.
 997         * d-lang.c (d_language_arch_info): Delete function, move
 998         implementation to...
 999         (d_language::language_arch_info): ...here, a new member
1000         function.
1001         (d_language_data): Delete la_language_arch_info.
1002         * f-lang.c (f_language_arch_info): Delete function, move
1003         implementation to...
1004         (f_language::language_arch_info): ...here, a new member
1005         function.
1006         (f_language_data): Delete la_language_arch_info.
1007         * go-lang.c (go_language_arch_info): Delete function, move
1008         implementation to...
1009         (go_language::language_arch_info): ...here, a new member
1010         function.
1011         (go_language_data): Delete la_language_arch_info.
1012         * language.c (unknown_language_data): Likewise.
1013         (unknown_language::language_arch_info): New member function.
1014         (auto_language_data): Delete la_language_arch_info.
1015         (auto_language::language_arch_info): New member function.
1016         (language_gdbarch_post_init): Update call to
1017         la_language_arch_info.
1018         * language.h (language_data): Delete la_language_arch_info
1019         function pointer.
1020         (language_defn::language_arch_info): New function.
1021         * m2-lang.c (m2_language_arch_info): Delete function, move
1022         implementation to...
1023         (m2_language::language_arch_info): ...here, a new member
1024         function.
1025         (m2_language_data): Delete la_language_arch_info.
1026         * objc-lang.c (objc_language_arch_info): Delete function, move
1027         implementation to...
1028         (objc_language::language_arch_info): ...here, a new member
1029         function.
1030         (objc_language_data): Delete la_language_arch_info.
1031         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1032         implementation to...
1033         (opencl_language::language_arch_info): ...here, a new member
1034         function.
1035         (opencl_language_data): Delete la_language_arch_info.
1036         * p-lang.c (pascal_language_arch_info): Delete function, move
1037         implementation to...
1038         (pascal_language::language_arch_info): ...here, a new member
1039         function.
1040         (pascal_language_data): Delete la_language_arch_info.
1041         * rust-lang.c (rust_language_arch_info): Delete function, move
1042         implementation to...
1043         (rust_language::language_arch_info): ...here, a new member
1044         function.
1045         (rust_language_data): Delete la_language_arch_info.
1046
1047 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1048
1049         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1050         initializer.
1051         * c-lang.c (c_language_data): Likewise.
1052         (cplus_language_data): Likewise.
1053         (cplus_language::pass_by_reference_info): New method.
1054         (asm_language_data): Delete la_pass_by_reference initializer.
1055         (minimal_language_data): Likewise.
1056         * cp-abi.c (cp_pass_by_reference): Remove use of
1057         default_pass_by_reference.
1058         * d-lang.c (d_language_data): Likewise.
1059         * f-lang.c (f_language_data): Likewise.
1060         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1061         default_pass_by_reference.
1062         * go-lang.c (go_language_data): Likewise.
1063         * language.c (language_pass_by_reference): Update.
1064         (default_pass_by_reference): Delete.
1065         (unknown_language_data): Delete la_pass_by_reference
1066         initializer.
1067         (auto_language_data): Likewise.
1068         * language.h (struct language_data): Delete la_pass_by_reference
1069         field.
1070         (language_defn::pass_by_reference_info): New member function.
1071         (default_pass_by_reference): Delete declaration.
1072         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1073         initializer.
1074         * objc-lang.c (objc_language_data): Likewise.
1075         * opencl-lang.c (opencl_language_data): Likewise.
1076         * p-lang.c (pascal_language_data): Likewise.
1077         * rust-lang.c (rust_language_data): Likewise.
1078
1079 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1080
1081         * ada-lang.c (ada_read_var_value): Delete function, move
1082         implementation to...
1083         (ada_language::read_var_value): ...here.
1084         (ada_language_data): Delete la_read_var_value initializer.
1085         * c-lang.c (c_language_data): Likewise.
1086         (cplus_language_data): Likewise.
1087         (minimal_language_data): Likewise.
1088         * d-lang.c (d_language_data): Likewise.
1089         * f-lang.c (f_language_data): Likewise.
1090         * findvar.c (default_read_var_value): Rename to...
1091         (language_defn::read_var_value): ...this.
1092         * findvar.c (read_var_value): Update header comment, and change to
1093         call member function instead of function pointer.
1094         * go-lang.c (go_language_data): Likewise.
1095         * language.c (unknown_language_data): Delete la_read_var_value
1096         initializer.
1097         (auto_language_data): Likewise.
1098         * language.h (struct language_data): Delete la_read_var_value
1099         field.
1100         (language_defn::read_var_value): New member function.
1101         (default_read_var_value): Delete declaration.
1102         * m2-lang.c (m2_language_data): Delete la_read_var_value
1103         initializer.
1104         * objc-lang.c (objc_language_data): Likewise.
1105         * opencl-lang.c (opencl_language_data): Likewise.
1106         * p-lang.c (pascal_language_data): Likewise.
1107         * rust-lang.c (rust_language_data): Likewise.
1108         * value.h (default_read_var_value): Delete declaration.
1109
1110 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1111
1112         * ada-lang.c (ada_print_array_index): Delete function, move
1113         implementation to...
1114         (ada_language::print_array_index): ...here.
1115         (ada_language_data): Delete la_print_array_index initializer.
1116         * c-lang.c (c_language_data): Likewise.
1117         (cplus_language_data): Likewise.
1118         (minimal_language_data): Likewise.
1119         * d-lang.c (d_language_data): Likewise.
1120         * f-lang.c (f_language_data): Likewise.
1121         * go-lang.c (go_language_data): Likewise.
1122         * language.c (default_print_array_index): Delete function, move
1123         implementation to...
1124         (language_defn::print_array_index): ...here.
1125         (unknown_language_data): Delete la_print_array_index initializer.
1126         (auto_language_data): Likewise.
1127         * language.h (struct language_data): Delete la_print_array_index
1128         field.
1129         (language_defn::print_array_index): New member function.
1130         (LA_PRINT_ARRAY_INDEX): Update.
1131         (default_print_array_index): Delete declaration.
1132         * m2-lang.c (m2_language_data): Delete la_print_array_index
1133         initializer.
1134         * objc-lang.c (objc_language_data): Likewise.
1135         * opencl-lang.c (opencl_language_data): Likewise.
1136         * p-lang.c (pascal_language_data): Likewise.
1137         * rust-lang.c (rust_language_data): Likewise.
1138
1139 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1140
1141         * gdb/ada-lang.c (ada_language_defn): Convert to...
1142         (ada_language_data): ...this.
1143         (class ada_language): New class.
1144         (ada_language_defn): New static global.
1145         * gdb/c-lang.c (c_language_defn): Convert to...
1146         (c_language_data): ...this.
1147         (class c_language): New class.
1148         (c_language_defn): New static global.
1149         (cplus_language_defn): Convert to...
1150         (cplus_language_data): ...this.
1151         (class cplus_language): New class.
1152         (cplus_language_defn): New static global.
1153         (asm_language_defn): Convert to...
1154         (asm_language_data): ...this.
1155         (class asm_language): New class.
1156         (asm_language_defn): New static global.
1157         (minimal_language_defn): Convert to...
1158         (minimal_language_data): ...this.
1159         (class minimal_language): New class.
1160         (minimal_language_defn): New static global.
1161         * gdb/d-lang.c (d_language_defn): Convert to...
1162         (d_language_data): ...this.
1163         (class d_language): New class.
1164         (d_language_defn): New static global.
1165         * gdb/f-lang.c (f_language_defn): Convert to...
1166         (f_language_data): ...this.
1167         (class f_language): New class.
1168         (f_language_defn): New static global.
1169         * gdb/go-lang.c (go_language_defn): Convert to...
1170         (go_language_data): ...this.
1171         (class go_language): New class.
1172         (go_language_defn): New static global.
1173         * gdb/language.c (unknown_language_defn): Remove declaration.
1174         (current_language): Initialize to nullptr, real initialization is
1175         moved to _initialize_language.
1176         (languages): Delete global.
1177         (language_defn::languages): Define.
1178         (set_language_command): Use language_defn::languages.
1179         (set_language): Likewise.
1180         (range_error): Likewise.
1181         (language_enum): Likewise.
1182         (language_def): Likewise.
1183         (add_set_language_command): Use language_def::languages for the
1184         language list, and language_def to lookup language pointers.
1185         (skip_language_trampoline): Use language_defn::languages.
1186         (unknown_language_defn): Convert to...
1187         (unknown_language_data): ...this.
1188         (class unknown_language): New class.
1189         (unknown_language_defn): New static global.
1190         (auto_language_defn): Convert to...
1191         (auto_language_data): ...this.
1192         (class auto_language): New class.
1193         (auto_language_defn): New static global.
1194         (language_gdbarch_post_init): Use language_defn::languages.
1195         (_initialize_language): Initialize current_language.
1196         * gdb/language.h (struct language_defn): Rename to...
1197         (struct language_data): ...this.
1198         (struct language_defn): New.
1199         (auto_language_defn): Delete.
1200         (unknown_language_defn): Delete.
1201         (minimal_language_defn): Delete.
1202         (ada_language_defn): Delete.
1203         (asm_language_defn): Delete.
1204         (c_language_defn): Delete.
1205         (cplus_language_defn): Delete.
1206         (d_language_defn): Delete.
1207         (f_language_defn): Delete.
1208         (go_language_defn): Delete.
1209         (m2_language_defn): Delete.
1210         (objc_language_defn): Delete.
1211         (opencl_language_defn): Delete.
1212         (pascal_language_defn): Delete.
1213         (rust_language_defn): Delete.
1214         * gdb/m2-lang.c (m2_language_defn): Convert to...
1215         (m2_language_data): ...this.
1216         (class m2_language): New class.
1217         (m2_language_defn): New static global.
1218         * gdb/objc-lang.c (objc_language_defn): Convert to...
1219         (objc_language_data): ...this.
1220         (class objc_language): New class.
1221         (objc_language_defn): New static global.
1222         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
1223         (opencl_language_data): ...this.
1224         (class opencl_language): New class.
1225         (opencl_language_defn): New static global.
1226         * gdb/p-lang.c (pascal_language_defn): Convert to...
1227         (pascal_language_data): ...this.
1228         (class pascal_language): New class.
1229         (pascal_language_defn): New static global.
1230         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
1231         language pointer, update comment format.
1232         * gdb/rust-lang.c (rust_language_defn): Convert to...
1233         (rust_language_data): ...this.
1234         (class rust_language): New class.
1235         (rust_language_defn): New static global.
1236
1237 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1238
1239         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
1240         member variable.
1241         <m_stmt_at_address>: New member variable.
1242         (lnp_state_machine::record_line): Don't record some lines, update
1243         tracking of is_stmt at the same address.
1244         (lnp_state_machine::lnp_state_machine): Initialise new member
1245         variables.
1246
1247 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1248
1249         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
1250         "-include gnu-nat-mig.h".
1251         * gnu-nat-mig.h: New file.
1252         * gnu-nat.c: Include "gnu-nat-mig.h".
1253         (exc_server, msg_reply_server, notify_server,
1254         process_reply_server): Remove declarations.
1255
1256 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1257
1258         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
1259         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
1260         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
1261         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
1262         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
1263         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
1264         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
1265         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
1266         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
1267         to gnu_nat_target class.
1268         * gnu-nat.c: Likewise.
1269         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
1270         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
1271         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
1272         object.
1273         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
1274         instead of `gnu_target'.
1275
1276 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1277
1278         * i386-gnu-tdep.c: Include "gdbcore.h"
1279         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
1280         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
1281         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
1282         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
1283         i386_gnu_sigcontext_addr): New functions
1284         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
1285         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
1286         tdep.
1287
1288 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1289
1290         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
1291         before fork_inferior call. Avoid calling it if target_is_pushed returns
1292         true.
1293
1294 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1295
1296         * gnu-nat.h (gnu_target): New variable declaration.
1297         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
1298         gnu_target.
1299         * gnu-nat.c (gnu_target): New variable.
1300         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
1301         add_thread_silent, and add_thread calls.
1302         (gnu_nat_target::create_inferior): Pass gnu_target to
1303         add_thread_silent, thread_change_ptid call.
1304         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
1305         call.
1306
1307 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1308
1309         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
1310         (gnu_nat_target::find_memory_regions): Remove unused
1311         `old_address' variable.
1312
1313 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1314
1315         * gnu-nat.c: Include "gdbarch.h".
1316
1317 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1318
1319         * reply_mig_hack.awk (Error return): Cast function through
1320         void *, to bypass compiler function call check.
1321
1322 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1323
1324         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
1325         $(srcdir)/reply_mig_hack.awk.
1326
1327 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1328
1329         * gnu-nat.h (gnu_debug_flag): Set type to bool.
1330
1331 2020-05-30  Jonny Grant  <jg@jguk.org>
1332
1333         * configure.ac (ACX_BUGURL): change bug URL to https.
1334
1335 2020-05-30  Pedro Alves  <palves@redhat.com>
1336
1337         * cp-support.c (replace_typedefs_template): New.
1338         (replace_typedefs_qualified_name): Handle
1339         DEMANGLE_COMPONENT_TEMPLATE.
1340
1341 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
1342
1343         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
1344         dwarf2/index-cache.h, dwarf2/index-write.c,
1345         dwarf2/index-write.h, dwarf2/line-header.c,
1346         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
1347         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
1348         variables and fields from `dwarf2_per_objfile` to just
1349         `per_objfile` throughout.
1350
1351 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
1352
1353         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1354         <push_dwarf_reg_entry_value>: Add comment.
1355
1356 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
1357             Keith Seitz  <keiths@redhat.com>
1358
1359         * python/python.c (do_start_initialization): Call PyEval_SaveThread
1360         instead of PyEval_ReleaseLock.
1361         (class gdbpy_gil): Move to earlier in file.
1362         (finalize_python): Set gdb_python_initialized.
1363         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
1364         when not initialized.
1365
1366 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
1367
1368         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1369         <push_dwarf_reg_entry_value>: Remove assert.  Override
1370         per_objfile with caller_per_objfile.
1371
1372 2020-05-28  Tom de Vries  <tdevries@suse.de>
1373
1374         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
1375         PR gold/15646 workaround to symbol kind "type".
1376
1377 2020-05-27  Tom Tromey  <tromey@adacore.com>
1378
1379         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
1380
1381 2020-05-27  Tom Tromey  <tromey@adacore.com>
1382
1383         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
1384         Use htab_find_with_hash.
1385         <add_abbrev>: Remove "abbrev_number" parameter.
1386         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
1387         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
1388         (hash_abbrev): Add comment.
1389         (abbrev_table::lookup_abbrev): Move to header file.
1390         (abbrev_table::read): Update.
1391
1392 2020-05-27  Tom Tromey  <tromey@adacore.com>
1393
1394         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
1395         method.
1396         <canonical_name>: New member.
1397         <raw_name>: Rename from "name".
1398         (partial_die_info): Initialize canonical_name.
1399         (scan_partial_symbols): Check raw_name.
1400         (partial_die_parent_scope, partial_die_full_name)
1401         (add_partial_symbol, add_partial_subprogram)
1402         (add_partial_enumeration, load_partial_dies): Use "name" method.
1403         (partial_die_info::name): New method.
1404         (partial_die_info::read, guess_partial_die_structure_name)
1405         (partial_die_info::fixup): Update.
1406
1407 2020-05-27  Tom Tromey  <tromey@adacore.com>
1408
1409         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
1410         <get_ref_die_offset>: Inline.
1411         <get_ref_die_offset_complaint>: New method.
1412         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
1413         (attribute::get_ref_die_offset_complaint): Rename from
1414         get_ref_die_offset.  Just issue complaint.
1415
1416 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1417
1418         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
1419
1420 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1421
1422         * exec.c (exec_file_attach): Use errno value of first openp failure.
1423
1424 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1425
1426         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
1427         Don't close thread handle.
1428
1429 2020-05-27  Tom Tromey  <tom@tromey.com>
1430             Simon Marchi  <simon.marchi@efficios.com>
1431
1432         * objfiles.h (struct objfile) <partial_symtabs>: Now a
1433         shared_ptr.
1434         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
1435         member.
1436         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
1437         dwarf2_per_bfd_objfile_data_key>: New globals.
1438         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
1439         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
1440         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
1441         shared.
1442         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
1443         short-circuit when sharing.
1444         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
1445         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
1446
1447 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1448
1449         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
1450         to...
1451         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
1452         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
1453
1454 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1455
1456         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
1457         build_name_components, find_name_components_bounds>:
1458         Add per_objfile parameter.
1459         (struct mapped_index) <symbol_name_at>: Likewise.
1460         (struct mapped_debug_names): Remove constructor.
1461         <dwarf2_per_objfile>: Remove field.
1462         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
1463         (mapped_index_base::find_name_components_bounds,
1464         mapped_index_base::build_name_components,
1465         dw2_expand_symtabs_matching_symbol): Likewise.
1466         (class mock_mapped_index) <symbol_name_at>: Likewise.
1467         (check_match): Likewise.
1468         (check_find_bounds_finds): Likewise.
1469         (test_mapped_index_find_name_component_bounds): Update.
1470         (CHECK_MATCH): Update.
1471         (dw2_expand_symtabs_matching): Update.
1472         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
1473         per_objfile parameter.
1474         <find_vec_in_debug_names>: Likewise.
1475         <m_per_objfile>: New field.
1476         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
1477         parameter.
1478         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
1479         (dw2_debug_names_iterator::next): Update.
1480         (dw2_debug_names_lookup_symbol): Update.
1481         (dw2_debug_names_expand_symtabs_for_function): Update.
1482         (dw2_debug_names_map_matching_symbols): Update.
1483         (dw2_debug_names_expand_symtabs_matching): Update.
1484         (dwarf2_read_debug_names): Update.
1485
1486 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1487
1488         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
1489         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
1490         move to dwarf2_per_objfile.
1491         <read_in_chain>: Remove.
1492         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
1493         remove_all_cus, age_comp_units>: New methods.
1494         <m_dwarf2_cus>: New member.
1495         (struct dwarf2_per_cu_data) <cu>: Remove.
1496         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
1497         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
1498         moved to methods of dwarf2_per_objfile.
1499         (dwarf2_clear_marks): Remove.
1500         (dwarf2_queue_item::~dwarf2_queue_item): Update.
1501         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
1502         (dwarf2_per_bfd::free_cached_comp_units): Remove.
1503         (dwarf2_per_objfile::remove_all_cus): New.
1504         (class free_cached_comp_units) <~free_cached_comp_units>:
1505         Update.
1506         (load_cu): Update.
1507         (dw2_do_instantiate_symtab): Adjust.
1508         (fill_in_sig_entry_from_dwo_entry): Adjust.
1509         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1510         (cutu_reader::cutu_reader): Likewise.
1511         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
1512         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
1513         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
1514         and dwarf2_per_objfile::age_comp_units.
1515         (load_partial_comp_unit): Update.
1516         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
1517         (process_queue): Likewise.
1518         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
1519         backlink.
1520         (dwarf2_read_addr_index): Likewise.
1521         (follow_die_offset): Likewise.
1522         (dwarf2_fetch_die_loc_sect_off): Likewise.
1523         (dwarf2_fetch_constant_bytes): Likewise.
1524         (dwarf2_fetch_die_type_sect_off): Likewise.
1525         (follow_die_sig_1): Likewise.
1526         (load_full_type_unit): Likewise.
1527         (read_signatured_type): Likewise.
1528         (dwarf2_cu::dwarf2_cu): Don't set cu field.
1529         (dwarf2_cu::~dwarf2_cu): Remove.
1530         (dwarf2_per_objfile::get_cu): New.
1531         (dwarf2_per_objfile::set_cu): New.
1532         (age_cached_comp_units): Rename to...
1533         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
1534         to std::unordered_map.
1535         (free_one_cached_comp_unit): Rename to...
1536         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
1537         to std::unordered_map.
1538         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
1539         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
1540         a dwarf2_per_objfile in data.
1541         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
1542         (dwarf2_clear_marks): Remove.
1543
1544 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1545
1546         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
1547         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
1548         (init_tu_and_read_dwo_dies): Likewise.
1549         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
1550         (cutu_reader::cutu_reader): Likewise.
1551         (load_partial_comp_unit): Likewise.
1552         (process_psymtab_comp_unit): Update.
1553         (build_type_psymtabs_1): Update.
1554         (process_skeletonless_type_unit): Update.
1555         (load_full_comp_unit): Update.
1556         (find_partial_die): Update.
1557         (dwarf2_read_addr_index): Update.
1558         (read_signatured_type): Update.
1559
1560 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1561
1562         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
1563         m_header_read_in>: New fields.
1564         <get_header>: New method.
1565         * dwarf2/read.c (per_cu_header_read_in): Remove.
1566         (dwarf2_per_cu_data::get_header): New.
1567         (dwarf2_per_cu_data::addr_size): Update.
1568         (dwarf2_per_cu_data::offset_size): Update.
1569         (dwarf2_per_cu_data::ref_addr_size): Update.
1570
1571 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1572
1573         * dwarf2/read.c (load_cu): Return dwarf2_cu.
1574         (dw2_do_instantiate_symtab): Update.
1575         (queue_and_load_all_dwo_tus): Change parameter from
1576         dwarf2_per_cu_data to dwarf2_cu.
1577         (dwarf2_fetch_die_loc_sect_off): Update.
1578         (dwarf2_fetch_constant_bytes): Update.
1579         (dwarf2_fetch_die_type_sect_off): Update.
1580
1581 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1582
1583         * dwarf2/read.c (process_full_comp_unit,
1584         process_full_type_unit): Remove per_cu, per_objfile paramters.
1585         Add dwarf2_cu parameter.
1586         (process_queue): Update.
1587
1588 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1589
1590         * dwarf2/read.c (create_cu_from_index_list): Replace
1591         dwarf2_per_objfile parameter with dwarf2_per_bfd.
1592         (create_cus_from_index_list): Likewise.
1593         (create_cus_from_index): Likewise.
1594         (create_signatured_type_table_from_index): Likewise.
1595         (create_cus_from_debug_names_list): Likewise.
1596         (create_cus_from_debug_names): Likewise.
1597         (dwarf2_read_gdb_index): Update.
1598         (dwarf2_read_debug_names): Update.
1599
1600 2020-05-27  Tom Tromey  <tom@tromey.com>
1601             Simon Marchi  <simon.marchi@efficios.com>
1602
1603         * dwarf2/read.h (struct dwarf2_per_objfile)
1604         <get_type_for_signatured_type, set_type_for_signatured_type>:
1605         New methods.
1606         <m_type_map>: New member.
1607         (struct signatured_type) <type>: Remove.
1608         * dwarf2/read.c
1609         (dwarf2_per_objfile::get_type_for_signatured_type,
1610         dwarf2_per_objfile::set_type_for_signatured_type): New.
1611         (get_signatured_type): Use new methods.
1612
1613 2020-05-27  Tom Tromey  <tom@tromey.com>
1614             Simon Marchi  <simon.marchi@efficios.com>
1615
1616         * dwarf2/read.h (struct type_unit_group_unshareable): New.
1617         (struct dwarf2_per_objfile) <type_units>: New member.
1618         <get_type_unit_group_unshareable>: New method.
1619         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
1620         num_symtabs, symtabs>: Remove; move to
1621         type_unit_group_unshareable.
1622         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
1623         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
1624         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
1625
1626 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1627
1628         * dwarf2/read.h (struct dwarf2_per_cu_data):
1629         <dwarf2_per_objfile>: Remove.
1630         * dwarf2/read.c (create_cu_from_index_list): Don't assign
1631         dwarf2_per_objfile.
1632         (create_signatured_type_table_from_index): Likewise.
1633         (create_signatured_type_table_from_debug_names): Likewise.
1634         (create_debug_type_hash_table): Likewise.
1635         (fill_in_sig_entry_from_dwo_entry): Likewise.
1636         (create_type_unit_group): Likewise.
1637         (read_comp_units_from_section): Likewise.
1638         (create_cus_hash_table): Likewise.
1639
1640 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1641
1642         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
1643         dwarf2_per_cu_data::dwarf2_per_objfile.
1644         (compute_compunit_symtab_includes): Likewise.
1645         (dwarf2_cu::start_symtab): Likewise.
1646
1647 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1648
1649         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
1650         parameter.
1651         * dwarf2/read.c (get_die_type_at_offset): Likewise.
1652         (read_namespace_alias): Update.
1653         (lookup_die_type): Update.
1654         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
1655         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
1656         Update.
1657         (disassemble_dwarf_expression): Update.
1658
1659 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1660
1661         * dwarf2/read.h (struct dwarf2_queue_item): Add
1662         dwarf2_per_objfile parameter, assign new parameter.
1663         <per_objfile>: New field.
1664         * dwarf2/read.c (free_one_cached_comp_unit): Add
1665         dwarf2_per_objfile parameter.
1666         (queue_comp_unit): Likewise.
1667         (dw2_do_instantiate_symtab): Update.
1668         (process_psymtab_comp_unit): Update.
1669         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
1670         (process_imported_unit_die): Update.
1671         (queue_and_load_dwo_tu): Update.
1672         (follow_die_offset): Update.
1673         (follow_die_sig_1): Update.
1674
1675 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1676
1677         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
1678         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
1679         (read_call_site_scope): Assign per_objfile.
1680         (dwarf2_per_cu_data::objfile): Remove.
1681         * gdbtypes.h (struct call_site) <per_objfile>: New member.
1682         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
1683         dwarf2_per_objfile parameter.
1684         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
1685         dwarf2_per_objfile parameter.
1686         (dwarf_expr_reg_to_entry_parameter): Add output
1687         dwarf2_per_objfile parameter.
1688         (locexpr_get_frame_base): Update.
1689         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
1690         <push_dwarf_reg_entry_value>: Update.
1691         <call_site_to_target_addr>: Update.
1692         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
1693         parameter.
1694         (value_of_dwarf_reg_entry): Update.
1695         (rw_pieced_value): Update.
1696         (indirect_synthetic_pointer): Update.
1697         (dwarf2_evaluate_property): Update.
1698         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
1699         parameter.
1700         (locexpr_read_variable): Update.
1701         (locexpr_get_symbol_read_needs): Update.
1702         (loclist_read_variable): Update.
1703
1704 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1705
1706         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
1707         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1708         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1709         parameter.
1710         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
1711         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
1712         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
1713         parameter.
1714         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
1715         sect_variable_value): Add dwarf2_per_objfile parameter.
1716         (class dwarf_evaluate_loc_desc) <dwarf_call,
1717         dwarf_variable_value>: Update.
1718         (fetch_const_value_from_synthetic_pointer): Add
1719         dwarf2_per_objfile parameter.
1720         (fetch_const_value_from_synthetic_pointer): Update.
1721         (coerced_pieced_ref): Update.
1722         (class symbol_needs_eval_context) <dwarf_call,
1723         dwarf_variable_value>: Update.
1724         (dwarf2_compile_expr_to_ax): Update.
1725
1726 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1727
1728         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
1729         parameter.
1730         (dwarf2_evaluate_loc_desc_full): Update.
1731
1732 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1733
1734         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
1735         parameter.
1736         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
1737         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
1738         dwarf2_per_objfile parameter.
1739         (decode_debug_loc_dwo_addresses): Likewise.
1740         (dwarf2_find_location_expression): Update.
1741         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
1742         (locexpr_describe_location_piece): Add dwarf2_per_objfile
1743         parameter.
1744         (disassemble_dwarf_expression): Add dwarf2_per_objfile
1745         parameter.
1746         (locexpr_describe_location_1): Likewise.
1747         (locexpr_describe_location): Update.
1748
1749 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1750
1751         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
1752         Remove.
1753         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
1754         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
1755         (dwarf2_compile_property_to_c): Update.
1756         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
1757         use text offset from objfile.
1758         (locexpr_tracepoint_var_ref): Update.
1759         (locexpr_generate_c_location): Update.
1760         (loclist_describe_location): Update.
1761         (loclist_tracepoint_var_ref): Update.
1762         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
1763         dwarf2_per_objfile parameter.
1764         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
1765         use text offset from objfile.
1766         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
1767
1768 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1769
1770         * dwarf2/expr.h (struct dwarf_expr_context)
1771         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
1772         <offset>: Remove.
1773         <per_objfile>: New member.
1774         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
1775         dwarf2_per_objfile parameter.  Don't set offset, set
1776         per_objfile.
1777         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
1778         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
1779         a dwarf2_per_objfile object instead of an offset.
1780         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
1781         constructor.
1782         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
1783         to dwarf2_expr_executor constructor.  Don't set offset.
1784         (dwarf2_fetch_cfa_info): Update.
1785         (struct dwarf2_frame_cache) <text_offset>: Remove.
1786         <per_objfile>: New field.
1787         (dwarf2_frame_cache): Update.
1788         (dwarf2_frame_prev_register): Update.
1789         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1790         <dwarf_evaluate_loc_desc>: Add constructor.
1791         (dwarf2_evaluate_loc_desc_full): Update.
1792         (dwarf2_locexpr_baton_eval): Update.
1793         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
1794         Add constructor.
1795         (dwarf2_loc_desc_get_symbol_read_needs): Update.
1796
1797 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1798
1799         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
1800         addr_sized_int_type>: Move to dwarf2_cu.
1801         <int_type>: Move to dwarf2_per_objfile.
1802         (struct dwarf2_per_objfile) <int_type>: Move here.
1803         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
1804         addr_sized_int_type>: Move here.
1805         (read_func_scope): Update.
1806         (read_array_type): Update.
1807         (read_tag_string_type): Update.
1808         (attr_to_dynamic_prop): Update.
1809         (dwarf2_per_cu_data::int_type): Rename to...
1810         (dwarf2_per_objfile::int_type): ... this.
1811         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
1812         (dwarf2_cu::addr_sized_int_type): ... this.
1813         (read_subrange_type): Update.
1814         (dwarf2_per_cu_data::addr_type): Rename to...
1815         (dwarf2_cu::addr_type): ... this.
1816         (set_die_type): Update.
1817
1818 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1819
1820         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
1821         data through per_cu->cu.
1822
1823 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1824
1825         * dwarf2/read.c (lookup_dwo_comp_unit): Change
1826         dwarf2_per_cu_data parameter fo dwarf2_cu.
1827         (lookup_dwo_type_unit): Likewise.
1828         (read_cutu_die_from_dwo): Likewise.
1829         (lookup_dwo_unit): Likewise.
1830         (open_and_init_dwo_file): Likewise.
1831         (lookup_dwo_cutu): Likewise.
1832         (lookup_dwo_comp_unit): Likewise.
1833         (lookup_dwo_type_unit): Likewise.
1834         (cutu_reader::init_tu_and_read_dwo_dies): Update.
1835         (cutu_reader::cutu_reader): Update.
1836
1837 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1838
1839         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
1840         parameter.
1841         (process_full_type_unit): Likewise.
1842         (process_queue): Update.
1843
1844 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1845
1846         * dwarf2/read.c (recursively_compute_inclusions): Add
1847         dwarf2_per_objfile parameter.
1848         (compute_compunit_symtab_includes): Likewise.
1849         (process_cu_includes): Update.
1850
1851 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1852
1853         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
1854         parameter.
1855         (create_type_unit_group): Update.
1856         (process_psymtab_comp_unit_reader): Update.
1857         (build_type_psymtabs_reader): Update.
1858
1859 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1860
1861         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
1862         object through m_this_cu->cu.
1863
1864 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1865
1866         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
1867         the info parameter.
1868         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
1869
1870 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1871
1872         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
1873         per_objfile parameter.
1874         (load_full_type_unit): Add per_objfile parameter.
1875         (read_signatured_type): Likewise.
1876         (load_full_comp_unit): Likewise.
1877         (load_cu): Likewise.
1878         (dw2_do_instantiate_symtab): Likewise.
1879         (dw2_get_file_names): Likewise.
1880         (dw2_map_symtabs_matching_filename): Update.
1881         (dw_expand_symtabs_matching_file_matcher): Update.
1882         (dw2_map_symbol_filenames): Update.
1883         (process_psymtab_comp_unit): Add per_objfile parameter.
1884         (build_type_psymtabs_1): Update.
1885         (process_skeletonless_type_unit): Update.
1886         (dwarf2_build_psymtabs_hard): Update.
1887         (load_partial_comp_unit): Add per_objfile parameter.
1888         (scan_partial_symbols): Update.
1889         (load_full_comp_unit): Add per_objfile parameter.
1890         (process_imported_unit_die): Update.
1891         (create_cus_hash_table): Update.
1892         (find_partial_die): Update.
1893         (dwarf2_read_addr_index): Update.
1894         (follow_die_offset): Update.
1895         (dwarf2_fetch_die_loc_sect_off): Update.
1896         (dwarf2_fetch_constant_bytes): Update.
1897         (dwarf2_fetch_die_type_sect_off): Update.
1898         (follow_die_sig_1): Update.
1899         (load_full_type_unit): Add per_objfile parameter.
1900         (read_signatured_type): Likewise.
1901
1902 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1903
1904         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
1905         of objfile_name.
1906
1907 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1908
1909         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
1910         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1911         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
1912         field.
1913         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
1914         (create_cus_from_index): Update.
1915         (dwarf2_read_gdb_index): Update.
1916         (create_cus_from_debug_names): Update.
1917         (dwarf2_read_debug_names): Update.
1918         (get_abbrev_section_for_cu): Update.
1919         (create_all_comp_units): Update.
1920         (read_attribute_value): Update.
1921         (get_debug_line_section): Update.
1922         * dwarf2/index-cache.c (index_cache::store): Update.
1923         * dwarf2/index-write.c (save_gdb_index_command): Update.
1924         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
1925
1926 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
1927
1928         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
1929         member.
1930         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
1931         dwarf2_per_cu_data::per_bfd.
1932         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
1933         (create_type_unit_group): Likewise.
1934         (queue_comp_unit): Remove reference to
1935         per_cu->dwarf2_per_objfile.
1936         (maybe_queue_comp_unit): Likewise.
1937         (fill_in_sig_entry_from_dwo_entry): Assign new field.
1938         (create_cus_hash_table): Assign new field.
1939
1940 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1941
1942         * dwarf2/read.c: Replace
1943         dwarf2_cu->per_cu->dwarf2_per_objfile references with
1944         dwarf2_cu->per_objfile throughout.
1945
1946 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1947
1948         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
1949         parameter, don't use per_cu->dwarf2_per_objfile.
1950         (dw2_instantiate_symtab): Likewise.
1951         (dw2_find_last_source_symtab): Update.
1952         (dw2_map_expand_apply): Update.
1953         (dw2_lookup_symbol): Update.
1954         (dw2_expand_symtabs_for_function): Update.
1955         (dw2_expand_all_symtabs): Update.
1956         (dw2_expand_symtabs_with_fullname): Update.
1957         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
1958         don't use per_cu->dwarf2_per_objfile.
1959         (dw2_expand_marked_cus): Update.
1960         (dw2_find_pc_sect_compunit_symtab): Update.
1961         (dw2_debug_names_lookup_symbol): Update.
1962         (dw2_debug_names_expand_symtabs_for_function): Update.
1963         (dw2_debug_names_map_matching_symbols): Update.
1964         (dwarf2_psymtab::expand_psymtab): Update.
1965
1966 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1967
1968         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
1969         <per_objfile>: New member.
1970         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
1971         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
1972         call to dwarf2_cu.
1973         (cutu_reader::cutu_reader): Update.
1974         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
1975
1976 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1977
1978         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
1979         struct dwarf2_per_objfile.
1980         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
1981         dwarf2_per_bfd.
1982         * dwarf2/read.c (set_die_type): Update.
1983         (get_die_type_at_offset): Update.
1984
1985 2020-05-27  Tom Tromey  <tom@tromey.com>
1986             Simon Marchi  <simon.marchi@efficios.com>
1987
1988         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
1989         method.
1990         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
1991         get_symtab, set_symtab>: New methods.
1992         <m_symtabs>: New field.
1993         (struct dwarf2_psymtab): Derive from partial_symtab.
1994         <readin_p, get_compunit_symtab>: Declare methods.
1995         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
1996         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
1997         New methods.
1998         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
1999         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2000         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2001         (dw2_symtab_iter_next, dw2_print_stats)
2002         (dw2_expand_symtabs_with_fullname)
2003         (dw2_expand_symtabs_matching_one)
2004         (dw_expand_symtabs_matching_file_matcher)
2005         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2006         (dw2_debug_names_iterator::next)
2007         (dw2_debug_names_map_matching_symbols)
2008         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2009         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2010         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2011         New methods.
2012         (get_compunit_symtab, process_full_comp_unit)
2013         (process_full_type_unit): Update.
2014         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2015
2016 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2017
2018         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2019         then introduce a new dwarf2_per_objfile type.
2020         <read_line_string>: Move to the new dwarf2_per_objfile type.
2021         <objfile>: Likewise.
2022         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2023         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2024         dwarf2_per_objfile->per_bfd.
2025         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2026         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2027         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2028         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2029         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2030         (dwarf2_per_objfile::locate_sections): Rename to...
2031         (dwarf2_per_bfd::locate_sections): ... this.
2032         (dwarf2_per_objfile::get_cutu): Rename to...
2033         (dwarf2_per_bfd::get_cutu): ... this.
2034         (dwarf2_per_objfile::get_cu): Rename to...
2035         (dwarf2_per_bfd::get_cu): ... this.
2036         (dwarf2_per_objfile::get_tu): Rename to...
2037         (dwarf2_per_bfd::get_tu): ... this.
2038         (dwarf2_per_objfile::allocate_per_cu): Rename to...
2039         (dwarf2_per_bfd::allocate_per_cu): ... this.
2040         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
2041         (dwarf2_per_bfd::allocate_signatured_type): ... this.
2042         (get_gdb_index_contents_ftype): Change parameter from
2043         dwarf2_per_objfile to dwarf2_per_bfd.
2044         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2045         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2046
2047 2020-05-27  Tom Tromey  <tom@tromey.com>
2048             Simon Marchi  <simon.marchi@efficios.com>
2049
2050         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2051         (allocate_piece_closure): Set "per_objfile" member.
2052         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2053         (locexpr_describe_location, loclist_describe_location): Use new
2054         member.
2055         * dwarf2/read.c (read_call_site_scope)
2056         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2057         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2058         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2059         handle_data_member_location): Set per_objfile member.
2060         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2061         member.
2062         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2063
2064 2020-05-27  Tom Tromey  <tom@tromey.com>
2065
2066         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2067         allocate_signatured_type>: Declare new methods.
2068         <m_num_psymtabs>: New member.
2069         (struct dwarf2_per_cu_data) <index>: New member.
2070         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2071         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2072         (create_cu_from_index_list): Use allocate_per_cu.
2073         (create_signatured_type_table_from_index)
2074         (create_signatured_type_table_from_debug_names)
2075         (create_debug_type_hash_table, add_type_unit)
2076         (read_comp_units_from_section): Use allocate_signatured_type.
2077
2078 2020-05-27  Tom Tromey  <tom@tromey.com>
2079
2080         * psymtab.c (partial_map_expand_apply)
2081         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2082         (psym_lookup_global_symbol_language)
2083         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2084         (psym_print_stats, psym_expand_symtabs_for_function)
2085         (psym_map_symbol_filenames, psym_map_matching_symbols)
2086         (psym_expand_symtabs_matching)
2087         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2088         (maintenance_check_psymtabs): Update.
2089         * psympriv.h (struct partial_symtab) <readin_p,
2090         get_compunit_symtab>: Add objfile parameter.
2091         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2092         Likewise.
2093         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2094         get_compunit_symtab>: Likewise.
2095         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2096
2097 2020-05-27  Tom Tromey  <tom@tromey.com>
2098
2099         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2100         member.
2101         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2102         (create_cu_from_index_list)
2103         (create_signatured_type_table_from_index)
2104         (create_signatured_type_table_from_debug_names)
2105         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2106         (dwarf2_create_include_psymtab)
2107         (create_debug_type_hash_table, add_type_unit)
2108         (create_type_unit_group, read_comp_units_from_section)
2109         (dwarf2_compute_name, create_cus_hash_table)
2110         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2111         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2112         obstack.
2113         (dw2_get_real_path): Likewise.  Change argument to
2114         dwarf2_per_objfile.
2115
2116 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2117
2118         PR tdep/26000
2119         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2120         for ldrd (immediate).
2121
2122 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2123
2124         * command.h: Add comment giving the name of class_tui.
2125         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2126         create the fake command for the help for class_tui.
2127
2128 2020-05-26  Tom Tromey  <tromey@adacore.com>
2129
2130         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2131         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2132         (val_atr): New function.
2133         (value_val_atr): Use it.
2134         * ada-valprint.c (print_optional_low_bound): Change low bound
2135         handling for enums.
2136         (val_print_packed_array_elements): Don't call discrete_position.
2137         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2138         discrete_position for enum types.
2139         * language.c (default_print_array_index): Change type.
2140         * language.h (struct language_defn) <la_print_array_index>: Add
2141         index_type parameter, change type of index_value.
2142         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2143         (default_print_array_index): Update.
2144         * valprint.c (maybe_print_array_index): Don't call
2145         value_from_longest.  Update.
2146         (value_print_array_elements): Don't call discrete_position.
2147
2148 2020-05-26  Tom Tromey  <tromey@adacore.com>
2149
2150         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2151         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2152
2153 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2154
2155         PR gdb/13519
2156         * avr-tdep.c (avr_integer_to_address): Return data or code
2157         address accordingly to the second 'type' argument of the
2158         function.
2159
2160 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2161
2162         * infcmd.c, inferior.h: (construct_inferior_arguments):
2163         Moved function from here to gdbsupport/common-inferior.{h,cc}
2164
2165 2020-05-23  Tom Tromey  <tom@tromey.com>
2166
2167         Revert commit eca1f90c:
2168         * NEWS: Remove entry for completion styling.
2169         * completer.c (_rl_completion_prefix_display_length): Move
2170         declaration later.
2171         (gdb_fnprint): Revert.
2172         (gdb_display_match_list_1): Likewise.
2173         * cli/cli-style.c (completion_prefix_style)
2174         (completion_difference_style, completion_suffix_style): Remove.
2175         (_initialize_cli_style): Revert.
2176         * cli/cli-style.h (completion_prefix_style)
2177         (completion_difference_style, completion_suffix_style): Don't
2178         declare.
2179
2180 2020-05-24  Pedro Alves  <palves@redhat.com>
2181
2182         * symtab.c (completion_list_add_name): Return boolean indication
2183         of whether the symbol matched.
2184         (completion_list_add_symbol): Don't try to remove C++ aliases if
2185         the symbol didn't match in the first place.
2186         * symtab.h (completion_list_add_name): Return bool.
2187
2188 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2189
2190         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2191         type::field.
2192
2193 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2194
2195         GDB 9.2 released.
2196
2197 2020-05-23  Tom Tromey  <tom@tromey.com>
2198
2199         * NEWS: Add entry for completion styling.
2200         * completer.c (_rl_completion_prefix_display_length): Move
2201         declaration earlier.
2202         (gdb_fnprint): Use completion_style.
2203         (gdb_display_match_list_1): Likewise.
2204         * cli/cli-style.c (completion_prefix_style)
2205         (completion_difference_style, completion_suffix_style): New
2206         globals.
2207         (_initialize_cli_style): Register new globals.
2208         * cli/cli-style.h (completion_prefix_style)
2209         (completion_difference_style, completion_suffix_style): Declare.
2210
2211 2020-05-23  Pedro Alves  <palves@redhat.com>
2212
2213         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2214         (parse_escape): Use ISDIGIT instead of isdigit.
2215         (puts_debug): Use gdb_isprint instead of isprint.
2216         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2217         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
2218         ISSPACE instead of isspace.
2219         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
2220         instead of isspace.
2221         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
2222         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
2223         instead of isxdigit and ISDIGIT instead of isdigit.
2224
2225 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2226
2227         * gdbtypes.h (struct type) <field>: New method.
2228         (TYPE_FIELDS): Remove, replace all uses with either type::fields
2229         or type::field.
2230
2231 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2232
2233         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
2234         (TYPE_FIELDS): Use type::fields.  Change all call sites that
2235         modify the propery to use type::set_fields instead.
2236
2237 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2238
2239         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
2240         type::num_fields instead.
2241
2242 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2243
2244         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
2245         methods.
2246         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
2247         that modify the number of fields to use type::set_num_fields
2248         instead.
2249
2250 2020-05-22  Tom Tromey  <tromey@adacore.com>
2251
2252         * compile/compile-object-load.h (munmap_list_free): Don't
2253         declare.
2254
2255 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2256
2257         * annotate.c (annotate_source_line): Update return type, add call
2258         to update current symtab and line.
2259         * annotate.h (annotate_source_line): Update return type, and
2260         extend header comment.
2261         * source.c (info_line_command): Check annotation_level before
2262         calling annotate_source_line.
2263         * stack.c (print_frame_info): If calling annotate_source_line
2264         returns true, then don't print any other source line information.
2265
2266 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2267
2268         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
2269
2270 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2271
2272         * coffread.c (patch_type): Remove NULL check before xfree.
2273         * corefile.c (set_gnutarget): Likewise.
2274         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
2275         * exec.c (build_section_table): Likewise.
2276         * remote.c (remote_target::pass_signals): Likewise.
2277         * utils.c (n_spaces): Likewise.
2278         * cli/cli-script.c (document_command): Likewise.
2279         * i386-windows-tdep.c (core_process_module_section): Likewise.
2280         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
2281
2282 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
2283
2284         * symfile.c (reread_symbols): Clear objfile's section_offsets
2285         vector and section indices, re-compute them by calling
2286         sym_offsets.
2287
2288 2020-05-20  Tom Tromey  <tromey@adacore.com>
2289
2290         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
2291         (desc_one_bound, desc_index_type): Compute field name.
2292
2293 2020-05-20  Tom de Vries  <tdevries@suse.de>
2294
2295         PR symtab/25833
2296         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
2297
2298 2020-05-20  Alan Modra  <amodra@gmail.com>
2299
2300         PR 25993
2301         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
2302         bfd_set_filename.
2303         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
2304         passed to bfd_set_filename.
2305         * symfile-mem.c (add_vsyscall_page): Likewise for string
2306         passed to symbol_file_add_from_memory.
2307         (symbol_file_add_from_memory): Make name param a const char* and
2308         don't strdup.
2309
2310 2020-05-20  Alan Modra  <amodra@gmail.com>
2311
2312         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
2313         rather than accessing bfd->filename directly.
2314         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
2315         and use bfd_section_name.
2316         * dwarf2/frame.c (decode_frame_entry): Likewise.
2317         * exec.c (exec_set_section_address): Likewise.
2318         * solib-aix.c (solib_aix_bfd_open): Likewise.
2319         * stap-probe.c (get_stap_base_address): Likewise.
2320         * symfile.c (reread_symbols): Likewise.
2321
2322 2020-05-19  Tom Tromey  <tromey@adacore.com>
2323
2324         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
2325
2326 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2327
2328         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
2329
2330 2020-05-19  Pedro Alves  <palves@redhat.com>
2331
2332         * NEWS (set exec-file-mismatch): Adjust entry.
2333         * exec.c: Include "build-id.h".
2334         (validate_exec_file): Try to match build IDs instead of filenames.
2335         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
2336         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
2337         and pass down 'warn_if_slow'.
2338         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
2339         gdb_bfd_open_closure to pass it down.
2340         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
2341
2342 2020-05-19  Pedro Alves  <palves@redhat.com>
2343
2344         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
2345         * target.c (target_fileio_open_1): Rename to target_fileio_open
2346         and make extern.  Use bool.
2347         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
2348         (target_fileio_read_alloc_1): Adjust.
2349         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
2350         (target_fileio_open_warn_if_slow): Delete declaration.
2351
2352 2020-05-19  Pedro Alves  <palves@redhat.com>
2353
2354         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
2355         Adjust all callers.
2356
2357 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
2358
2359         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
2360         whether disp is negative.
2361
2362 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2363
2364         * symfile.h (struct symfile_segment_data)
2365         <~symfile_segment_data>: Remove.
2366         <segment_info>: Change to std::vector.
2367         * symfile.c (default_symfile_segments): Update.
2368         * elfread.c (elf_symfile_segments): Update.
2369
2370 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2371
2372         * symfile.h (struct symfile_segment_data) <struct segment>: New.
2373         <segments>: New.
2374         <segment_bases, segment_sizes>: Remove.
2375         * symfile.c (default_symfile_segments): Update.
2376         * elfread.c (elf_symfile_segments): Update.
2377         * remote.c (remote_target::get_offsets): Update.
2378         * solib-target.c (solib_target_relocate_section_addresses):
2379         Update.
2380
2381 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2382
2383         * symfile.h (struct symfile_segment_data): Initialize fields.
2384         <~symfile_segment_data>: Add.
2385         (symfile_segment_data_up): New.
2386         (struct sym_fns) <sym_segments>: Return a
2387         symfile_segment_data_up.
2388         (default_symfile_segments): Return a symfile_segment_data_up.
2389         (free_symfile_segment_data): Remove.
2390         (get_symfile_segment_data): Return a symfile_segment_data_up.
2391         * symfile.c (default_symfile_segments): Likewise.
2392         (get_symfile_segment_data): Likewise.
2393         (free_symfile_segment_data): Remove.
2394         (symfile_find_segment_sections): Update.
2395         * elfread.c (elf_symfile_segments): Return a
2396         symfile_segment_data_up.
2397         * remote.c (remote_target::get_offsets): Update.
2398         * solib-target.c (solib_target_relocate_section_addresses):
2399         Update.
2400         * symfile-debug.c (debug_sym_segments): Return a
2401         symfile_segment_data_up.
2402
2403 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2404
2405         PR build/25981
2406         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
2407         Hardcode register numbers.
2408
2409         PR build/25981
2410         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
2411         procfs_find_LDT_entry): Remove.
2412         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
2413         procfs_find_LDT_entry): Remove.
2414         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
2415         Remove.
2416
2417 2020-05-17  Pedro Alves  <palves@redhat.com>
2418             Andrew Burgess  <andrew.burgess@embecosm.com>
2419             Keno Fischer  <keno@juliacomputing.com>
2420
2421         PR gdb/25741
2422         * breakpoint.c (build_target_condition_list): Update comments.
2423         (build_target_command_list): Update comments and skip matching
2424         locations.
2425         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
2426         a separate function.  Simplify "set breakpoint auto-hw off"
2427         handling.
2428         (insert_breakpoints): Update comment.
2429         (tracepoint_locations_match): New parameter.  For breakpoints,
2430         compare location types too, if the caller wants to.
2431         (handle_automatic_hardware_breakpoints): New functions.
2432         (bp_location_is_less_than): Also sort by location type and
2433         hardware breakpoint length.
2434         (update_global_location_list): Handle "set breakpoint auto-hw on"
2435         here.
2436         (update_breakpoint_locations): Ask breakpoint_locations_match to
2437         ignore location types.
2438
2439 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2440
2441         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
2442         type::name instead.
2443
2444 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2445
2446         * gdbtypes.h (struct type) <name, set_name>: New methods.
2447         (TYPE_CODE): Use type::name.  Change all call sites used to set
2448         the name to use type::set_name instead.
2449
2450 2020-05-16  Tom Tromey  <tom@tromey.com>
2451
2452         * top.c (quit_force): Update.
2453         * infrun.c (handle_no_resumed): Update.
2454         * top.h (all_uis): New function.
2455         (ALL_UIS): Remove.
2456
2457 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2458
2459         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
2460
2461 2020-05-16  Pedro Alves  <palves@redhat.com>
2462
2463         * ia64-linux-nat.c
2464         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
2465         Declare method.
2466         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
2467
2468 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
2469
2470         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
2471         (sparc64_adi_info): Likewise.
2472
2473 2020-05-15  Tom Tromey  <tom@tromey.com>
2474
2475         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
2476         block_objfile.
2477         (lookup_objfile_from_block): Remove.
2478         (lookup_symbol_in_block, lookup_symbol_in_static_block)
2479         (lookup_global_symbol): Use block_objfile.
2480         * symtab.h (lookup_objfile_from_block): Don't declare.
2481         * printcmd.c (clear_dangling_display_expressions): Use
2482         block_objfile.
2483         * parse.c (operator_check_standard): Use block_objfile.
2484
2485 2020-05-15  Tom Tromey  <tom@tromey.com>
2486
2487         * language.c (language_alloc_type_symbol): Set
2488         SYMBOL_SECTION.
2489         * symtab.c (initialize_objfile_symbol): Remove.
2490         (allocate_symbol): Remove.
2491         (allocate_template_symbol): Remove.
2492         * dwarf2/read.c (fixup_go_packaging): Use "new".
2493         (new_symbol): Use "new".
2494         (read_variable): Don't call initialize_objfile_symbol.  Use
2495         "new".
2496         (read_func_scope): Use "new".
2497         * xcoffread.c (process_xcoff_symbol): Don't call
2498         initialize_objfile_symbol.
2499         (SYMBOL_DUP): Remove.
2500         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
2501         "new".
2502         * symtab.h (allocate_symbol, initialize_objfile_symbol)
2503         (allocate_template_symbol): Don't declare.
2504         (struct symbol): Add copy constructor.  Change defaults.
2505         * jit.c (finalize_symtab): Use "new".
2506         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
2507         Use "new".
2508         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
2509         (common_block_end): Use "new".
2510         * mdebugread.c (parse_symbol): Use "new".
2511         (new_symbol): Likewise.
2512
2513 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2514
2515         * NEWS: Mention changes to help and apropos.
2516
2517 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2518
2519         * command.h (enum command_class): Improve comments, document
2520         that class_alias is for user-defined aliases, give the class
2521         name for each class, remove unused class_xdb.
2522         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
2523         * breakpoint.c (_initialize_breakpoint): Replace class_alias
2524         by a precise class.
2525         * infcmd.c (_initialize_infcmd): Likewise.
2526         * reverse.c (_initialize_reverse): Likewise.
2527         * stack.c (_initialize_stack): Likewise.
2528         * symfile.c (_initialize_symfile): Likewise.
2529         * tracepoint.c (_initialize_tracepoint): Likewise.
2530
2531 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2532
2533         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
2534         when their aliased command is traversed.
2535         (help_cmd): Add fput_command_names_styled call to
2536         output command name and aliases when command has an alias.
2537
2538 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2539
2540         * cli/cli-decode.h (help_cmd_list): Remove declaration.
2541         * cli/cli-decode.c (help_cmd_list): Declare as static,
2542         remove prefix argument, use bool for recurse arg, rework to show the aliases of
2543         a command together with the command.
2544         (fput_command_name_styled, fput_command_names_styled): New functions.
2545         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
2546         fput_command_name_styled.
2547         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
2548         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
2549
2550 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2551
2552         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
2553         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
2554         * command.h (cmd_show_list): Likewise.
2555         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
2556         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
2557
2558 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2559
2560         * unittests/command-def-selftests.c (traverse_command_structure):
2561         Verify all commands of a list have the same prefix command and
2562         that only the top cmdlist commands have a null prefix.
2563
2564 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2565
2566         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
2567         as prefix, not one of its aliases.
2568         (set_cmd_prefix): Remove.
2569         (do_add_cmd): Centralize the setting of the prefix of a command, when
2570         command is defined after its full chain of prefix commands.
2571         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
2572         (add_setshow_cmd_full): Likewise.
2573         (update_prefix_field_of_prefixed_commands): New function.
2574         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
2575         update_prefix_field_of_prefixed_commands.
2576         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
2577         addresses of remote_set_cmdlist and remote_show_cmdlist given
2578         as argument, not the address of an argument.
2579         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
2580         * gdb/remote.c (_initialize_remote): Likewise.
2581
2582 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2583
2584         * cli/cli-cmds.c (alias_command): Check for an existing alias
2585         using lookup_cmd_composition, as valid_command_p is too strict
2586         and forbids aliases that are the prefix of an existing alias
2587         or command.
2588         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
2589         command is properly recognised as a valid command.
2590
2591 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2592
2593         * unittests/help-doc-selftests.c: Rename to
2594         unittests/command-def-selftests.c
2595         * unittests/command-def-selftests.c (help_doc_tests): Update some
2596         comments.
2597         (command_structure_tests, traverse_command_structure): New namespace
2598         and function.
2599         (command_structure_invariants_tests): New function.
2600         (_initialize_command_def_selftests) Renamed from
2601         _initialize_help_doc_selftests, register command_structure_invariants
2602         selftest.
2603
2604 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2605
2606         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
2607         an alias of 'show'.
2608
2609 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
2610
2611         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
2612         ada_is_fixed_point_type.  Update all callers.
2613         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
2614         all callers.
2615         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
2616         Update all callers.
2617         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
2618         print_fixed_point_type.  Update all callers.
2619         * ada-valprint.c (ada_value_print_num): Replace call to
2620         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
2621
2622 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
2623
2624         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
2625         processors.
2626         (cpu_supports_bts): Add CV_AMD case.
2627
2628 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
2629             Simon Marchi  <simon.marchi@efficios.com>
2630
2631         * infrun.c (stop_all_threads): Collect multiple wait events at
2632         each pass.
2633
2634 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2635
2636         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
2637         type::code instead.
2638
2639 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
2640
2641         * gdbtypes.h (struct type) <code, set_code>: New methods.
2642         (TYPE_CODE): Use type::code.  Change all call sites used to set
2643         the code to use type::set_code instead.
2644
2645 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2646             Tom de Vries  <tdevries@suse.de>
2647             Pedro Alves  <palves@redhat.com>
2648
2649         PR threads/25478
2650         * infrun.c (stop_all_threads): Do NOT ignore
2651         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
2652         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
2653         received.
2654         (handle_no_resumed): Remove code handling a live inferior with no
2655         threads.
2656         * remote.c (has_single_non_exited_thread): New.
2657         (remote_target::update_thread_list): Do not delete a thread if is
2658         the last thread of the process.
2659         * thread.c (thread_select): Call delete_exited_threads instead of
2660         prune_threads.
2661
2662 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2663
2664         * infrun.c (stop_all_threads): Enable/disable thread events of all
2665         targets.  Move a debug message denoting the end of the function
2666         into the SCOPED_EXIT block.
2667
2668 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2669
2670         * process-stratum-target.h: Include <set>.
2671         (all_non_exited_process_targets, switch_to_target_no_thread): New
2672         function declarations.
2673         * process-stratum-target.c (all_non_exited_process_targets)
2674         (switch_to_target_no_thread): New function implementations.
2675
2676 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2677
2678         * infrun.c (handle_inferior_event): Extract out a piece of code
2679         into...
2680         (mark_non_executing_threads): ...this new function.
2681
2682 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2683
2684         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
2685         use.
2686
2687 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2688
2689         * regcache.c (regcache_read_pc_protected): New function
2690         implementation that returns 0 if the PC cannot read via
2691         'regcache_read_pc'.
2692         * infrun.c (proceed): Call 'regcache_read_pc_protected'
2693         instead of 'regcache_read_pc'.
2694         (keep_going_pass_signal): Ditto.
2695
2696 2020-05-13  Tom Tromey  <tromey@adacore.com>
2697
2698         * ada-lang.c (align_value): Remove.
2699         (ada_template_to_fixed_record_type_1): Use align_up.
2700
2701 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2702
2703         * async-event.c: Update the copyright year.
2704         * async-event.h: Update the copyright year.
2705
2706 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
2707
2708         * objfiles.h (is_addr_in_objfile,
2709         shared_objfile_contains_address_p): Return bool.
2710         * objfile.c (is_addr_in_objfile,
2711         shared_objfile_contains_address_p): Return bool.
2712
2713 2020-05-11  Tom Tromey  <tromey@adacore.com>
2714
2715         * cli/cli-cmds.c (info_command): Restore.
2716         (_initialize_cli_cmds): Use add_prefix_command for "info".
2717         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
2718
2719 2020-05-11  Tom Tromey  <tromey@adacore.com>
2720
2721         * ada-lang.c (ada_value_primitive_field): Now public.
2722         * ada-lang.h (ada_value_primitive_field): Declare.
2723         * ada-valprint.c (print_field_values): Use
2724         ada_value_primitive_field for wrapper fields.
2725
2726 2020-05-11  Tom de Vries  <tdevries@suse.de>
2727
2728         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
2729         MODULE_DOMAIN.
2730
2731 2020-05-11  Tom de Vries  <tdevries@suse.de>
2732
2733         PR symtab/25941
2734         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
2735         with length 0, if not gdb-produced.
2736         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
2737
2738 2020-05-09  Tom de Vries  <tdevries@suse.de>
2739
2740         PR gdb/25955
2741         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
2742         calculation.
2743
2744 2020-05-09  Tom Tromey  <tom@tromey.com>
2745
2746         * top.c (server_command): Now bool.
2747         * top.h (server_command): Now bool.
2748
2749 2020-05-08  Tom Tromey  <tromey@adacore.com>
2750
2751         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
2752         already being processed.
2753
2754 2020-05-08  Tom Tromey  <tom@tromey.com>
2755
2756         * printcmd.c (struct display) <next>: Remove.
2757         <display>: New constructor.
2758         <exp_string>: Now a std::string.
2759         <enabled_p>: Now a bool.
2760         (display_number): Move definition earlier.
2761         (displays): Rename from display_chain.  Now a std::vector.
2762         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
2763         (display_command): Update.
2764         (do_one_display, disable_display)
2765         (enable_disable_display_command, do_enable_disable_display):
2766         Update.
2767         (free_display): Remove.
2768         (clear_displays): Rewrite.
2769         (delete_display): Update.
2770         (map_display_numbers): Use function_view.  Remove "data"
2771         parameter.  Update.
2772         (do_delete_display): Remove.
2773         (undisplay_command): Update.
2774         (do_one_display, do_displays, disable_display)
2775         (info_display_command): Update.
2776         (do_enable_disable_display): Remove.
2777         (enable_disable_display_command)
2778         (clear_dangling_display_expressions): Update.
2779
2780 2020-05-08  Tom Tromey  <tom@tromey.com>
2781
2782         * symtab.c (set_symbol_cache_size)
2783         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
2784         (maintenance_print_symbol_cache_statistics): Update.
2785         * symmisc.c (print_symbol_bcache_statistics)
2786         (print_objfile_statistics, maintenance_print_objfiles)
2787         (maintenance_info_symtabs, maintenance_check_symtabs)
2788         (maintenance_expand_symtabs, maintenance_info_line_tables):
2789         Update.
2790         * symfile-debug.c (set_debug_symfile): Update.
2791         * source.c (forget_cached_source_info): Update.
2792         * python/python.c (gdbpy_progspaces): Update.
2793         * psymtab.c (maintenance_info_psymtabs): Update.
2794         * probe.c (parse_probes): Update.
2795         * linespec.c (iterate_over_all_matching_symtabs)
2796         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
2797         * guile/scm-progspace.c (gdbscm_progspaces): Update.
2798         * exec.c (exec_target::close): Update.
2799         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
2800         * breakpoint.c (print_one_breakpoint_location)
2801         (create_longjmp_master_breakpoint)
2802         (create_std_terminate_master_breakpoint): Update.
2803         * progspace.c (program_spaces): Now a std::vector.
2804         (maybe_new_address_space): Update.
2805         (add_program_space): Remove.
2806         (program_space::program_space): Update.
2807         (remove_program_space): Update.
2808         (number_of_program_spaces): Remove.
2809         (print_program_space, update_address_spaces): Update.
2810         * progspace.h (program_spaces): Change type.
2811         (ALL_PSPACES): Remove.
2812         (number_of_program_spaces): Don't declare.
2813         (struct program_space) <next>: Remove.
2814
2815 2020-05-08  Tom Tromey  <tom@tromey.com>
2816
2817         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
2818         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
2819         (enable_break): Update.
2820         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
2821         (frv_fdpic_find_canonical_descriptor): Update.
2822         (frv_fetch_objfile_link_map): Update.
2823         * progspace.c (program_space::free_all_objfiles): Update.
2824         (program_space::solibs): New method.
2825         * progspace.h (struct program_space) <solibs>: New method.
2826         * solist.h (master_so_list): Don't declare.
2827         (ALL_SO_LIBS): Remove.
2828         * solib.h (so_list_head): Remove.
2829         (update_solib_list): Update comment.
2830         * solib.c (master_so_list): Remove.
2831         (solib_used, update_solib_list, solib_add)
2832         (info_sharedlibrary_command, clear_solib)
2833         (reload_shared_libraries_1, remove_user_added_objfile): Update.
2834
2835 2020-05-08  Tom Tromey  <tom@tromey.com>
2836
2837         * extension.c (extension_languages): Now a std::array.
2838         (ALL_EXTENSION_LANGUAGES): Remove.
2839         (get_ext_lang_defn, get_ext_lang_of_file)
2840         (eval_ext_lang_from_control_command): Update.
2841         (finish_ext_lang_initialization)
2842         (auto_load_ext_lang_scripts_for_objfile)
2843         (ext_lang_type_printers::ext_lang_type_printers)
2844         (apply_ext_lang_type_printers)
2845         (ext_lang_type_printers::~ext_lang_type_printers)
2846         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
2847         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
2848         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
2849         (get_matching_xmethod_workers, ext_lang_colorize)
2850         (ext_lang_before_prompt): Update.
2851         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
2852
2853 2020-05-08  Tom Tromey  <tom@tromey.com>
2854
2855         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
2856         overload.
2857         <swap_string, m_string>: Remove.
2858         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
2859         Update.
2860         * stabsread.c (define_symbol, read_type): Update.
2861         * linespec.c (find_linespec_symbols): Update.
2862         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
2863         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
2864         * dbxread.c (read_dbx_symtab): Update.
2865         * cp-support.h (cp_canonicalize_string_full)
2866         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
2867         Return unique_xmalloc_ptr.
2868         * cp-support.c (inspect_type): Update.
2869         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
2870         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
2871         Likewise.
2872         * c-typeprint.c (print_name_maybe_canonical): Update.
2873         * break-catch-throw.c (check_status_exception_catchpoint):
2874         Update.
2875
2876 2020-05-08  Tom de Vries  <tdevries@suse.de>
2877
2878         * infrun.c (follow_fork): Copy current_line and current_symtab to
2879         child thread.
2880
2881 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2882
2883         * async-event.c (struct async_signal_handler, struct
2884         async_event_handler): Reformat, remove typedef.
2885
2886 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2887
2888         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
2889         access thistype->main_type->dyn_prop_list directly.
2890
2891 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2892
2893         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
2894         (remove_dyn_prop): Remove.  Update all users to use
2895         type::remove_dyn_prop.
2896         * gdbtypes.c (remove_dyn_prop): Rename to...
2897         (type::remove_dyn_prop): ... this.
2898
2899 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
2900
2901         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
2902         (add_dyn_prop): Remove.  Update all users to use
2903         type::add_dyn_prop.
2904         * gdbtypes.c (add_dyn_prop): Rename to...
2905         (type::add_dyn_prop): ... this.
2906
2907 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
2908
2909         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
2910         (get_dyn_prop): Remove.  Update all users to use
2911         type::dyn_prop.
2912         * gdbtypes.c (get_dyn_prop): Rename to...
2913         (type::dyn_prop): ... this.
2914
2915 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2916
2917         * gdbtypes.h (struct main_type) <flag_static>: Remove.
2918
2919 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
2920
2921         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
2922         instruction, skip it if it's there.
2923
2924 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
2925
2926         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
2927
2928 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
2929
2930         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
2931         * gdbtypes.c (recursive_dump_type): Remove use of
2932         TYPE_INCOMPLETE.
2933
2934 2020-05-03  Tom Tromey  <tom@tromey.com>
2935
2936         * breakpoint.c (catch_command, tcatch_command): Remove.
2937         (_initialize_breakpoint): Use add_basic_prefix_cmd,
2938         add_show_prefix_cmd.
2939         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
2940         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
2941         Remove.
2942         (add_internal_problem_command): Use add_basic_prefix_cmd,
2943         add_show_prefix_cmd.
2944         * mips-tdep.c (set_mipsfpu_command): Remove.
2945         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
2946         * dwarf2/index-cache.c (set_index_cache_command): Remove.
2947         (_initialize_index_cache): Use add_basic_prefix_cmd.
2948         * memattr.c (dummy_cmd): Remove.
2949         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
2950         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
2951         (_initialize_tui_win): Use add_basic_prefix_cmd,
2952         add_show_prefix_cmd.
2953         * cli/cli-logging.c (set_logging_command): Remove.
2954         (_initialize_cli_logging): Use add_basic_prefix_cmd,
2955         add_show_prefix_cmd.
2956         (show_logging_command): Remove.
2957         * target.c (target_command): Remove.
2958         (add_target): Use add_basic_prefix_cmd.
2959
2960 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
2961
2962         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
2963
2964 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2965
2966         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
2967         info_command.
2968
2969 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
2970
2971         * nbsd-nat.c (nbsd_enable_proc_events)
2972         (nbsd_nat_target::post_startup_inferior): Add.
2973         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
2974         (nbsd_nat_target::update_thread_list): Rewrite.
2975         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
2976         "PTRACE_LWP_CREATE".
2977         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
2978
2979 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2980
2981         * stack.c (_initialize_stack): Remove duplicated creation
2982         of "frame" command and "f" alias.
2983
2984 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2985
2986         PR gdb/18706
2987         * gdbtypes.c (check_typedef): Calculate size of array of
2988         stubbed type.
2989
2990 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
2991
2992         PR gdb/15559
2993         * i386-tdep.c (i386_push_dummy_call): Call
2994         i386_thiscall_push_dummy_call.
2995         (i386_thiscall_push_dummy_call): New function.
2996         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
2997         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
2998         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
2999
3000 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3001
3002         * gdbarch.sh (do_read): Add shellcheck disable directive for
3003         warning SC2162.
3004
3005 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3006
3007         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3008         "referenced but not assigned" warning.
3009
3010 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3011
3012         * gdbarch.sh: Remove code that sets fallbackdefault.
3013
3014 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3015
3016         * gdbarch.sh: Use shell operators && and || instead of
3017         -a and -o.
3018
3019 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3020
3021         * gdbarch.sh: Use $(...) instead of `...`.
3022
3023 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3024
3025         * gdbarch.sh: Use double quotes around variables.
3026
3027 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3028
3029         * gdbarch.sh: Use %s with printf, instead of variables in the
3030         format string.
3031
3032 2020-04-29  Tom Tromey  <tromey@adacore.com>
3033
3034         PR ada/25875:
3035         * dwarf2/read.c (update_enumeration_type_from_children): Compute
3036         type fields here.
3037         (read_enumeration_type): Call
3038         update_enumeration_type_from_children later.  Update comments.
3039         (process_enumeration_scope): Don't create type fields.
3040
3041 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3042
3043         * nbsd-tdep.c: Include "xml-syscall.h".
3044         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3045
3046 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3047
3048         * nbsd-nat.c: Include "sys/wait.h".
3049         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3050         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3051         (nbsd_nat_target::remove_exec_catchpoint)
3052         (nbsd_nat_target::set_syscall_catchpoint): Add.
3053         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3054         (nbsd_nat_target::insert_exec_catchpoint)
3055         (nbsd_nat_target::remove_exec_catchpoint)
3056         (nbsd_nat_target::set_syscall_catchpoint): Add.
3057         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3058         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3059         `nbsd_get_syscall_number'.
3060
3061 2020-04-29  Tom Tromey  <tom@tromey.com>
3062
3063         * stack.c (print_block_frame_labels): Remove.
3064
3065 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3066
3067         PR gdb/17320
3068         * ada-valprint.c (val_print_packed_array_elements): Move array
3069         end bracket to new line.
3070         (ada_val_print_string): Remove extra spaces before first array
3071         element.
3072         * c-valprint.c (c_value_print_array): Likewise.
3073         * m2-valprint.c (m2_print_array_contents): Likewise.
3074         (m2_value_print_inner): Likewise.
3075         * p-valprint.c (pascal_value_print_inner): Likewise.
3076         * valprint.c (generic_val_print_array): Likewise.
3077         (value_print_array_elements): Move first array element and array
3078         end bracket to new line.
3079
3080 2020-04-29  Tom de Vries  <tdevries@suse.de>
3081
3082         PR symtab/25889
3083         * linespec.c (find_method): Fix ix calculation.
3084
3085 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3086
3087         * syscalls/update-netbsd.sh: New file.
3088         * syscalls/netbsd.xml: Regenerate.
3089         * data-directory/Makefile.in: Register `netbsd.xml' in
3090         `SYSCALLS_FILES'.
3091
3092 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3093
3094         * syscalls/update-freebsd.sh: Add double quotes.
3095
3096 2020-04-28  Tom Tromey  <tom@tromey.com>
3097
3098         * NEWS: Update.
3099         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3100         (cmdpy_init): Allow class_tui.
3101
3102 2020-04-28 Mark Williams <mark@myosotissp.com>
3103
3104         PR gdb/24480
3105         * dwarf2read.c: Add missing assingments to list_in_scope when
3106         start_symtab was already called.
3107
3108 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3109
3110         PR gdb/25881
3111         * dwarf2/read.c (offset_map_type): Use
3112         gdb:hash_enum<sect_offset> as hash function.
3113
3114 2020-04-28  Tom de Vries  <tdevries@suse.de>
3115
3116         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3117         with DW_AT_signature.
3118
3119 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3120
3121         * configure.ac: Remove check for fs_base/gs_base in
3122         user_regs_struct.
3123         * configure: Re-generate.
3124         * config.in: Re-generate.
3125         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3126         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3127         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3128
3129 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3130
3131         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3132         problematic inline frame unwinding situation.
3133         * frame.c (frame_id_computed_p): New function.
3134         * frame.h (frame_id_computed_p): New prototype.
3135
3136 2020-04-26  Tom Tromey  <tom@tromey.com>
3137
3138         * command.h (enum command_class) <class_pseudo>: Remove.
3139
3140 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3141
3142         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3143         and whitespace.
3144
3145 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3146
3147         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3148         `PT_GET_PROCESS_STATE' block.
3149
3150 2020-04-24  Tom Tromey  <tom@tromey.com>
3151
3152         * symtab.h (symbol_get_demangled_name): Don't declare.
3153         * symtab.c (symbol_get_demangled_name): Remove.
3154         (general_symbol_info::natural_name)
3155         (general_symbol_info::demangled_name): Update.
3156
3157 2020-04-24  Tom Tromey  <tom@tromey.com>
3158
3159         PR rust/25025:
3160         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3161
3162 2020-04-24  Tom Tromey  <tom@tromey.com>
3163
3164         PR symtab/12707:
3165         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3166         exists.
3167         (new_symbol): Likewise.
3168         * compile/compile-object-load.c (get_out_value_type): Use
3169         symbol_matches_search_name.
3170
3171 2020-04-24  Tom Tromey  <tom@tromey.com>
3172
3173         * dwarf2/read.c (add_partial_symbol): Do not call
3174         compute_and_set_names.
3175
3176 2020-04-24  Tom Tromey  <tom@tromey.com>
3177
3178         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3179         overload.
3180
3181 2020-04-24  Tom Tromey  <tom@tromey.com>
3182
3183         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3184         (add_psymbol_to_list): New overload.  Make old overload call new
3185         one.
3186         * psympriv.h (add_psymbol_to_list): New overload.
3187
3188 2020-04-24  Tom Tromey  <tom@tromey.com>
3189
3190         * dwarf2/read.c (partial_die_info::read) <case
3191         DW_AT_linkage_name>: Use value_as_string.
3192         (dwarf2_string_attr): Use value_as_string.
3193         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3194         method.
3195         * dwarf2/attribute.c (attribute::value_as_string): New method.
3196
3197 2020-04-24  Tom Tromey  <tom@tromey.com>
3198
3199         * symtab.c (general_symbol_info::natural_name)
3200         (general_symbol_info::demangled_name): Check for language_rust.
3201
3202 2020-04-24  Tom Tromey  <tom@tromey.com>
3203
3204         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3205         (dwarf2_physname): ... from here.
3206         (partial_die_info::read): Add Rust "{" hack.
3207
3208 2020-04-24  Tom Tromey  <tom@tromey.com>
3209
3210         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3211         method.
3212         (symbol_set_demangled_name): Don't declare.
3213         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3214         symbol_set_demangled_name.
3215         (general_symbol_info::set_language)
3216         (general_symbol_info::compute_and_set_names): Update.
3217         * minsyms.c (minimal_symbol_reader::install): Update.
3218         * dwarf2/read.c (new_symbol): Update.
3219
3220 2020-04-24  Tom Tromey  <tromey@adacore.com>
3221
3222         PR python/23662:
3223         * python/py-type.c (convert_field): Handle
3224         FIELD_LOC_KIND_DWARF_BLOCK.
3225         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
3226         (typy_get_dynamic): Nw function.
3227         (type_object_getset): Add "dynamic".
3228         * NEWS: Add entry.
3229
3230 2020-04-24  Tom Tromey  <tromey@adacore.com>
3231
3232         * ada-typeprint.c (print_choices, print_variant_part)
3233         (print_record_field_types_dynamic): New functions.
3234         (print_record_field_types): Use print_record_field_types_dynamic.
3235
3236 2020-04-24  Tom Tromey  <tromey@adacore.com>
3237
3238         * dwarf2/read.c (handle_data_member_location): New overload.
3239         (dwarf2_add_field): Use it.
3240         (decode_locdesc): Add "computed" parameter.  Update comment.
3241         * gdbtypes.c (is_dynamic_type_internal): Also look for
3242         FIELD_LOC_KIND_DWARF_BLOCK.
3243         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
3244         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
3245         virtual base classes.
3246         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
3247         FIELD_LOC_KIND_DWARF_BLOCK.
3248
3249 2020-04-24  Tom Tromey  <tromey@adacore.com>
3250
3251         * dwarf2/read.c (read_structure_type): Handle dynamic length.
3252         * gdbtypes.c (is_dynamic_type_internal): Check
3253         TYPE_HAS_DYNAMIC_LENGTH.
3254         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
3255         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
3256         New macros.
3257         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
3258         constant.
3259
3260 2020-04-24  Tom Tromey  <tromey@adacore.com>
3261
3262         * dwarf2/read.c (struct variant_field): Rewrite.
3263         (struct variant_part_builder): New.
3264         (struct nextfield): Remove "variant" field.  Add "offset".
3265         (struct field_info): Add "current_variant_part" and
3266         "variant_parts".
3267         (alloc_discriminant_info): Remove.
3268         (alloc_rust_variant): New function.
3269         (quirk_rust_enum): Update.
3270         (dwarf2_add_field): Set "offset" member.  Don't handle
3271         DW_TAG_variant_part.
3272         (offset_map_type): New typedef.
3273         (convert_variant_range, create_one_variant)
3274         (create_one_variant_part, create_variant_parts)
3275         (add_variant_property): New functions.
3276         (dwarf2_attach_fields_to_type): Call add_variant_property.
3277         (read_structure_type): Don't handle DW_TAG_variant_part.
3278         (handle_variant_part, handle_variant): New functions.
3279         (handle_struct_member_die): Use them.
3280         (process_structure_scope): Don't handle variant parts.
3281         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
3282         (struct discriminant_info): Remove.
3283         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
3284         (struct main_type) <flag_discriminated_union>: Remove.
3285         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
3286         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
3287         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
3288         Update.
3289         * valops.c (value_union_variant): Remove.
3290         * value.h (value_union_variant): Don't declare.
3291
3292 2020-04-24  Tom Tromey  <tromey@adacore.com>
3293
3294         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
3295         (ada_value_primitive_packed_val): Update.
3296         * ada-valprint.c (ada_value_print_1): Update.
3297         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
3298         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
3299         just an address.  Use evaluate_for_locexpr_baton.
3300         (dwarf2_evaluate_property): Update.
3301         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
3302         array_view.
3303         * findvar.c (default_read_var_value): Update.
3304         * gdbtypes.c (compute_variant_fields_inner)
3305         (resolve_dynamic_type_internal): Update.
3306         (resolve_dynamic_type): Change type of valaddr parameter.
3307         * gdbtypes.h (resolve_dynamic_type): Update.
3308         * valarith.c (value_subscripted_rvalue): Update.
3309         * value.c (value_from_contents_and_address): Update.
3310
3311 2020-04-24  Tom Tromey  <tromey@adacore.com>
3312
3313         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
3314         "push_initial_value" parameter.
3315         (dwarf2_evaluate_property): Likewise.
3316         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
3317
3318 2020-04-24  Tom Tromey  <tromey@adacore.com>
3319
3320         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
3321         (variant::matches, compute_variant_fields_recurse)
3322         (compute_variant_fields_inner, compute_variant_fields): New
3323         functions.
3324         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
3325         Use resolved_type after type is made.
3326         (operator==): Add new cases.
3327         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
3328         (struct discriminant_range, struct variant, struct variant_part):
3329         New.
3330         (union dynamic_prop_data) <variant_parts, original_type>: New
3331         members.
3332         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
3333         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
3334         constants.
3335         * value.c (unpack_bits_as_long): Now public.
3336         * value.h (unpack_bits_as_long): Declare.
3337
3338 2020-04-24  Tom Tromey  <tromey@adacore.com>
3339
3340         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
3341         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
3342
3343 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
3344
3345         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
3346
3347 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
3348
3349         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
3350         (remove_fork_catchpoint, post_startup_inferior)
3351         (post_attach): Move...
3352         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
3353         (remove_fork_catchpoint, post_startup_inferior)
3354         (post_attach): ...here.
3355         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
3356         (remove_fork_catchpoint, post_startup_inferior)
3357         (post_attach): Move...
3358         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
3359         (remove_fork_catchpoint, post_startup_inferior)
3360         (post_attach): ...here.
3361
3362 2020-04-24  Tom Tromey  <tromey@adacore.com>
3363
3364         * nat/windows-nat.h (struct windows_thread_info)
3365         <pc_adjusted>: New member.
3366         * windows-nat.c (windows_fetch_one_register): Check
3367         pc_adjusted.
3368         (windows_nat_target::get_windows_debug_event)
3369         (windows_nat_target::wait): Set pc_adjusted.
3370
3371 2020-04-24  Tom de Vries  <tdevries@suse.de>
3372
3373         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
3374         Run gdb-add-index inside temp dir.
3375
3376 2020-04-23  Tom Tromey  <tromey@adacore.com>
3377
3378         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
3379         in loop.
3380
3381 2020-04-23  Luis Machado  <luis.machado@linaro.org>
3382
3383         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
3384         get_frame_register instead of gdbarch_unwind_pc.
3385
3386 2020-04-23  Tom de Vries  <tdevries@suse.de>
3387
3388         * symtab.c (lookup_global_symbol): Prefer def over decl.
3389
3390 2020-04-23  Tom de Vries  <tdevries@suse.de>
3391
3392         PR symtab/25807
3393         * block.c (best_symbol, better_symbol): Promote to external.
3394         * block.h (best_symbol, better_symbol): Declare.
3395         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
3396         decl.
3397
3398 2020-04-23  Tom Tromey  <tromey@adacore.com>
3399
3400         PR ada/25837:
3401         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
3402         "const char *", not a "const std::string &".
3403         <name_and_matcher::operator==>: Update.
3404         * unittests/lookup_name_info-selftests.c: Change type of
3405         "result".
3406
3407 2020-04-23  Tom Tromey  <tom@tromey.com>
3408
3409         * inferior.h (iterate_over_inferiors): Don't declare.
3410         * inferior.c (iterate_over_inferiors): Remove.
3411         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
3412         Remove.
3413         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
3414         use iterate_over_inferiors.
3415         (darwin_resume_inferior_it)
3416         (struct resume_inferior_threads_param)
3417         (darwin_resume_inferior_threads_it): Remove.
3418         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
3419
3420 2020-04-23  Tom de Vries  <tdevries@suse.de>
3421
3422         * blockframe.c (find_pc_partial_function): Use
3423         find_pc_sect_compunit_symtab rather than
3424         objfile->sf->qf->find_pc_sect_compunit_symtab.
3425
3426 2020-04-22  Tom de Vries  <tdevries@suse.de>
3427
3428         PR symtab/25764
3429         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
3430         in psymtabs.
3431
3432 2020-04-22  Tom de Vries  <tdevries@suse.de>
3433
3434         PR symtab/25801
3435         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
3436         symtabs.
3437
3438 2020-04-22  Tom de Vries  <tdevries@suse.de>
3439
3440         PR symtab/25700
3441         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
3442         CU if already created.
3443
3444 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3445
3446         * infrun.c (displaced_step_fixup): Switch to the event_thread
3447         before calling displaced_step_restore, not after.
3448
3449 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3450
3451         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
3452         its inferior is not recorded by us.
3453         (record_btrace_target_open): Replace call to
3454         all_non_exited_threads () with call to current_inferior
3455         ()->non_exited_threads ().
3456         (record_btrace_target::stop_recording): Likewise.
3457         (record_btrace_target::close): Likewise.
3458         (record_btrace_target::wait): Likewise.
3459         (record_btrace_target::record_stop_replaying): Likewise.
3460
3461 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3462
3463         * btrace.c (btrace_enable): Throw an error on double enables and
3464         when enabling recording fails.
3465         (btrace_disable): Throw an error if the thread is not recorded.
3466
3467 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3468
3469         * record-btrace.c (record_btrace_target::fetch_registers): Forward
3470         request if we do not have a thread_info.
3471
3472 2020-04-21  Tom de Vries  <tdevries@suse.de>
3473
3474         PR gdb/25471
3475         * thread.c
3476         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
3477         exception in get_frame_id.
3478
3479 2020-04-20  Tom Tromey  <tromey@adacore.com>
3480
3481         * python/python.c (struct gdbpy_event): Mark move constructor as
3482         noexcept.
3483         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
3484         constructor as noexcept.
3485         * completer.h (struct completion_result): Mark move constructor as
3486         noexcept.
3487         * completer.c (completion_result::completion_result): Use
3488         initialization style.  Don't call reset_match_list.
3489
3490 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
3491
3492         * MAINTAINERS (Write After Approval): Add myself.
3493
3494 2020-04-18  Tom Tromey  <tom@tromey.com>
3495
3496         * windows-tdep.c (init_w32_command_list)
3497         (w32_prefix_command_valid): Restore.
3498         (_initialize_windows_tdep): Call init_w32_command_list.
3499
3500 2020-04-18  Tom Tromey  <tom@tromey.com>
3501
3502         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
3503         * value.c (value_fn_field): Update.
3504         * valops.c (find_function_in_inferior)
3505         (value_allocate_space_in_inferior): Update.
3506         * tui/tui-winsource.c (tui_update_source_windows_with_line):
3507         Update.
3508         * tui/tui-source.c (tui_source_window::set_contents): Update.
3509         * symtab.c (lookup_global_or_static_symbol)
3510         (find_function_start_sal_1, skip_prologue_sal)
3511         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
3512         * symmisc.c (dump_msymbols, dump_symtab_1)
3513         (maintenance_print_one_line_table): Update.
3514         * symfile.c (init_entry_point_info, section_is_mapped)
3515         (list_overlays_command, simple_read_overlay_table)
3516         (simple_overlay_update_1): Update.
3517         * stap-probe.c (handle_stap_probe): Update.
3518         * stabsread.c (dbx_init_float_type, define_symbol)
3519         (read_one_struct_field, read_enum_type, read_range_type): Update.
3520         * source.c (info_line_command): Update.
3521         * python/python.c (gdbpy_source_objfile_script)
3522         (gdbpy_execute_objfile_script): Update.
3523         * python/py-type.c (save_objfile_types): Update.
3524         * python/py-objfile.c (py_free_objfile): Update.
3525         * python/py-inferior.c (python_new_objfile): Update.
3526         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
3527         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
3528         (maintenance_check_psymtabs): Update.
3529         * printcmd.c (info_address_command): Update.
3530         * objfiles.h (struct objfile) <arch>: New method, from
3531         get_objfile_arch.
3532         (get_objfile_arch): Don't declare.
3533         * objfiles.c (get_objfile_arch): Remove.
3534         (filter_overlapping_sections): Update.
3535         * minsyms.c (msymbol_is_function): Update.
3536         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
3537         (output_nondebug_symbol): Update.
3538         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
3539         (mdebug_expand_psymtab): Update.
3540         * machoread.c (macho_add_oso_symfile): Update.
3541         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
3542         Update.
3543         * linux-fork.c (checkpoint_command): Update.
3544         * linespec.c (convert_linespec_to_sals): Update.
3545         * jit.c (finalize_symtab): Update.
3546         * infrun.c (insert_exception_resume_from_probe): Update.
3547         * ia64-tdep.c (ia64_find_unwind_table): Update.
3548         * hppa-tdep.c (internalize_unwinds): Update.
3549         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
3550         Update.
3551         * gcore.c (call_target_sbrk): Update.
3552         * elfread.c (record_minimal_symbol, elf_symtab_read)
3553         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
3554         (elf_gnu_ifunc_resolve_by_got): Update.
3555         * dwarf2/read.c (create_addrmap_from_index)
3556         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3557         (read_debug_names_from_section)
3558         (process_psymtab_comp_unit_reader, add_partial_symbol)
3559         (add_partial_subprogram, process_full_comp_unit)
3560         (read_file_scope, read_func_scope, read_lexical_block_scope)
3561         (read_call_site_scope, dwarf2_ranges_read)
3562         (dwarf2_record_block_ranges, dwarf2_add_field)
3563         (mark_common_block_symbol_computed, read_tag_pointer_type)
3564         (read_tag_string_type, dwarf2_init_float_type)
3565         (dwarf2_init_complex_target_type, read_base_type)
3566         (partial_die_info::read, partial_die_info::read)
3567         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
3568         (dwarf2_fetch_die_loc_sect_off): Update.
3569         * dwarf2/loc.c (dwarf2_find_location_expression)
3570         (class dwarf_evaluate_loc_desc, rw_pieced_value)
3571         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
3572         (dwarf2_loc_desc_get_symbol_read_needs)
3573         (locexpr_describe_location_piece, locexpr_describe_location_1)
3574         (loclist_describe_location): Update.
3575         * dwarf2/index-write.c (write_debug_names): Update.
3576         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
3577         * dtrace-probe.c (dtrace_process_dof): Update.
3578         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
3579         (process_one_symbol): Update.
3580         * ctfread.c (ctf_init_float_type, read_base_type): Update.
3581         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
3582         (coff_read_enum_type): Update.
3583         * cli/cli-cmds.c (edit_command, list_command): Update.
3584         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
3585         * breakpoint.c (create_overlay_event_breakpoint)
3586         (create_longjmp_master_breakpoint)
3587         (create_std_terminate_master_breakpoint)
3588         (create_exception_master_breakpoint, get_sal_arch): Update.
3589         * block.c (block_gdbarch): Update.
3590         * annotate.c (annotate_source_line): Update.
3591
3592 2020-04-17  Tom Tromey  <tromey@adacore.com>
3593
3594         * auto-load.c (show_auto_load_cmd): Remove.
3595         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
3596         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
3597         (maintenance_print_arc_command): Remove.
3598         * tui/tui-win.c (tui_command): Remove.
3599         (tui_get_cmd_list): Use add_basic_prefix_cmd.
3600         * tui/tui-layout.c (tui_layout_command): Remove.
3601         (_initialize_tui_layout): Use add_basic_prefix_cmd.
3602         * python/python.c (user_set_python, user_show_python): Remove.
3603         (_initialize_python): Use add_basic_prefix_cmd,
3604         add_show_prefix_cmd.
3605         * guile/guile.c (set_guile_command, show_guile_command): Remove.
3606         (install_gdb_commands): Use add_basic_prefix_cmd,
3607         add_show_prefix_cmd.
3608         (info_guile_command): Remove.
3609         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
3610         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
3611         add_show_prefix_cmd.
3612         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
3613         Remove do_set and do_show parameters.
3614         * cli/cli-style.c (set_style, show_style): Remove.
3615         (_initialize_cli_style): Use add_basic_prefix_cmd,
3616         add_show_prefix_cmd.
3617         (cli_style_option::add_setshow_commands): Remove do_set and
3618         do_show parameters.
3619         (cli_style_option::add_setshow_commands): Use
3620         add_basic_prefix_cmd, add_show_prefix_cmd.
3621         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
3622         (set_style_name): Remove.
3623         * cli/cli-dump.c (dump_command, append_command): Remove.
3624         (srec_dump_command, ihex_dump_command, verilog_dump_command)
3625         (tekhex_dump_command, binary_dump_command)
3626         (binary_append_command): Remove.
3627         (_initialize_cli_dump): Use add_basic_prefix_cmd.
3628         * windows-tdep.c (w32_prefix_command_valid): Remove global.
3629         (init_w32_command_list): Remove; move into ...
3630         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
3631         * valprint.c (set_print, show_print, set_print_raw)
3632         (show_print_raw): Remove.
3633         (_initialize_valprint): Use add_basic_prefix_cmd,
3634         add_show_prefix_cmd.
3635         * typeprint.c (set_print_type, show_print_type): Remove.
3636         (_initialize_typeprint): Use add_basic_prefix_cmd,
3637         add_show_prefix_cmd.
3638         * record.c (set_record_command, show_record_command): Remove.
3639         (_initialize_record): Use add_basic_prefix_cmd,
3640         add_show_prefix_cmd.
3641         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
3642         add_show_prefix_cmd.
3643         (info_command, show_command, set_debug, show_debug): Remove.
3644         * top.h (set_history, show_history): Don't declare.
3645         * top.c (set_history, show_history): Remove.
3646         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
3647         (unset_tdesc_cmd): Remove.
3648         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
3649         add_show_prefix_cmd.
3650         * symtab.c (info_module_command): Remove.
3651         (_initialize_symtab): Use add_basic_prefix_cmd.
3652         * symfile.c (overlay_command): Remove.
3653         (_initialize_symfile): Use add_basic_prefix_cmd.
3654         * sparc64-tdep.c (info_adi_command): Remove.
3655         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
3656         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
3657         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
3658         add_show_prefix_cmd.
3659         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
3660         (_initialize_serial): Use add_basic_prefix_cmd,
3661         add_show_prefix_cmd.
3662         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
3663         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
3664         add_show_prefix_cmd.
3665         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
3666         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
3667         add_show_prefix_cmd.
3668         * riscv-tdep.c (show_riscv_command, set_riscv_command)
3669         (show_debug_riscv_command, set_debug_riscv_command): Remove.
3670         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
3671         add_show_prefix_cmd.
3672         * remote.c (remote_command, set_remote_cmd): Remove.
3673         (_initialize_remote): Use add_basic_prefix_cmd.
3674         * record-full.c (set_record_full_command)
3675         (show_record_full_command): Remove.
3676         (_initialize_record_full): Use add_basic_prefix_cmd,
3677         add_show_prefix_cmd.
3678         * record-btrace.c (cmd_set_record_btrace)
3679         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
3680         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
3681         (cmd_show_record_btrace_pt): Remove.
3682         (_initialize_record_btrace): Use add_basic_prefix_cmd,
3683         add_show_prefix_cmd.
3684         * ravenscar-thread.c (set_ravenscar_command)
3685         (show_ravenscar_command): Remove.
3686         (_initialize_ravenscar): Use add_basic_prefix_cmd,
3687         add_show_prefix_cmd.
3688         * mips-tdep.c (show_mips_command, set_mips_command)
3689         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
3690         add_show_prefix_cmd.
3691         * maint.c (maintenance_command, maintenance_info_command)
3692         (maintenance_check_command, maintenance_print_command)
3693         (maintenance_set_cmd, maintenance_show_cmd): Remove.
3694         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
3695         add_show_prefix_cmd.
3696         (show_per_command_cmd): Remove.
3697         * maint-test-settings.c (maintenance_set_test_settings_cmd):
3698         Remove.
3699         (maintenance_show_test_settings_cmd): Remove.
3700         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
3701         add_show_prefix_cmd.
3702         * maint-test-options.c (maintenance_test_options_command):
3703         Remove.
3704         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
3705         * macrocmd.c (macro_command): Remove
3706         (_initialize_macrocmd): Use add_basic_prefix_cmd.
3707         * language.c (set_check, show_check): Remove.
3708         (_initialize_language): Use add_basic_prefix_cmd,
3709         add_show_prefix_cmd.
3710         * infcmd.c (unset_command): Remove.
3711         (_initialize_infcmd): Use add_basic_prefix_cmd.
3712         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
3713         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
3714         add_show_prefix_cmd.
3715         * go32-nat.c (go32_info_dos_command): Remove.
3716         (_initialize_go32_nat): Use add_basic_prefix_cmd.
3717         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
3718         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
3719         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
3720         (_initialize_frame): Use add_basic_prefix_cmd,
3721         add_show_prefix_cmd.
3722         * dcache.c (set_dcache_command, show_dcache_command): Remove.
3723         (_initialize_dcache): Use add_basic_prefix_cmd,
3724         add_show_prefix_cmd.
3725         * cp-support.c (maint_cplus_command): Remove.
3726         (_initialize_cp_support): Use add_basic_prefix_cmd.
3727         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
3728         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
3729         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
3730         add_basic_prefix_cmd, add_show_prefix_cmd.
3731         * breakpoint.c (save_command): Remove.
3732         (_initialize_breakpoint): Use add_basic_prefix_cmd.
3733         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
3734         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
3735         add_show_prefix_cmd.
3736         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
3737         (set_ada_command, show_ada_command): Remove.
3738         (_initialize_ada_language): Use add_basic_prefix_cmd,
3739         add_show_prefix_cmd.
3740         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
3741
3742 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
3743
3744         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
3745         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
3746
3747 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3748
3749         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
3750         warning messages.
3751
3752 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
3753
3754         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
3755         import table is not at beginning of .idata section.
3756
3757 2020-04-16  Pedro Alves  <palves@redhat.com>
3758
3759         * inferior.c (delete_inferior): Use delete operator directly
3760         instead of delete_program_space.
3761         * progspace.c (add_program_space): New, factored out from
3762         program_space::program_space.
3763         (remove_program_space): New, factored out from
3764         delete_program_space.
3765         (program_space::program_space): Remove intro comment.  Rewrite.
3766         (program_space::~program_space): Remove intro comment.  Call
3767         remove_program_space.
3768         (delete_program_space): Delete.
3769         * progspace.h (program_space::program_space): Make explicit.  Move
3770         intro comment here, adjusted.
3771         (program_space::~program_space): Move intro comment here,
3772         adjusted.
3773         (delete_program_space): Remove.
3774
3775 2020-04-16  Tom Tromey  <tromey@adacore.com>
3776
3777         * windows-nat.c (windows_nat::handle_access_violation): New
3778         function.
3779         * nat/windows-nat.h (handle_access_violation): Declare.
3780         * nat/windows-nat.c (handle_exception): Move Cygwin code to
3781         windows-nat.c.  Call handle_access_violation.
3782
3783 2020-04-16  Tom de Vries  <tdevries@suse.de>
3784
3785         PR symtab/25791
3786         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
3787         CUs without psymtab.
3788
3789 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
3790
3791         * python/python.c (do_start_initialization): Don't call
3792         PyEval_InitThreads for Python 3.9 and beyond.
3793
3794 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
3795
3796         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
3797         thread functions.
3798         (obsd_nat_target::wait): Likewise.
3799
3800 2020-04-15  Tom Tromey  <tromey@adacore.com>
3801
3802         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
3803         (DEBUG_EXCEPT): Use debug_printf.
3804
3805 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3806
3807         * completer.c (class completion_tracker::completion_hash_entry)
3808         <hash_name>: New member function.
3809         (completion_tracker::discard_completions): New callback to hash a
3810         completion_hash_entry, pass this to htab_create_alloc.
3811
3812 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
3813
3814         * windows-nat.c (windows_make_so): Warn rather than stopping with
3815         an error if realpath() fails.
3816
3817 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
3818
3819         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
3820         (nbsd_nat_target::info_proc): Add do_status.
3821
3822 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
3823             Tom de Vries  <tdevries@suse.de>
3824
3825         PR symtab/25718
3826         * psympriv.h (struct partial_symtab::read_symtab)
3827         (struct partial_symtab::expand_psymtab)
3828         (struct partial_symtab::read_dependencies): Update comments.
3829         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
3830         read_symtab for includer.
3831         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
3832         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
3833         (struct dwarf2_include_psymtab::m_readin): Remove.
3834         (struct dwarf2_include_psymtab::includer): New member function.
3835         (dwarf2_psymtab::expand_psymtab): Assert !readin.
3836
3837 2020-04-14  Tom de Vries  <tdevries@suse.de>
3838
3839         PR symtab/25720
3840         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
3841         with NULL symbol_matcher and lookup_name.
3842         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
3843         and lookup_name.
3844         * dwarf2/read.c (dw2_expand_symtabs_matching)
3845         (dw2_debug_names_expand_symtabs_matching): Same.
3846         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
3847         Make lookup_name a pointer.  Update comment.
3848         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
3849         lookup_name being a pointer.
3850         * symfile.c (expand_symtabs_matching): Same.
3851         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
3852         * linespec.c (iterate_over_all_matching_symtabs): Same.
3853
3854 2020-04-13  Tom Tromey  <tom@tromey.com>
3855
3856         * run-on-main-thread.c: Update include.
3857         * unittests/main-thread-selftests.c: Update include.
3858         * tui/tui-win.c: Update include.
3859         * tui/tui-io.c: Update include.
3860         * tui/tui-interp.c: Update include.
3861         * tui/tui-hooks.c: Update include.
3862         * top.h: Update include.
3863         * top.c: Update include.
3864         * ser-base.c: Update include.
3865         * remote.c: Update include.
3866         * remote-notif.c: Update include.
3867         * remote-fileio.c: Update include.
3868         * record-full.c: Update include.
3869         * record-btrace.c: Update include.
3870         * python/python.c: Update include.
3871         * posix-hdep.c: Update include.
3872         * mingw-hdep.c: Update include.
3873         * mi/mi-main.c: Update include.
3874         * mi/mi-interp.c: Update include.
3875         * main.c: Update include.
3876         * linux-nat.c: Update include.
3877         * interps.c: Update include.
3878         * infrun.c: Update include.
3879         * inf-loop.c: Update include.
3880         * event-top.c: Update include.
3881         * event-loop.c: Move to ../gdbsupport/.
3882         * event-loop.h: Move to ../gdbsupport/.
3883         * async-event.h: Update include.
3884         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
3885
3886 2020-04-13  Tom Tromey  <tom@tromey.com>
3887
3888         * tui/tui-win.c: Include async-event.h.
3889         * remote.c: Include async-event.h.
3890         * remote-notif.c: Include async-event.h.
3891         * record-full.c: Include async-event.h.
3892         * record-btrace.c: Include async-event.h.
3893         * infrun.c: Include async-event.h.
3894         * event-top.c: Include async-event.h.
3895         * event-loop.h: Move some declarations to async-event.h.
3896         * event-loop.c: Don't include ser-event.h or top.h.  Move some
3897         code to async-event.c.
3898         * async-event.h: New file.
3899         * async-event.c: New file.
3900         * Makefile.in (COMMON_SFILES): Add async-event.c.
3901         (HFILES_NO_SRCDIR): Add async-event.h.
3902
3903 2020-04-13  Tom Tromey  <tom@tromey.com>
3904
3905         * utils.c (flush_streams): New function.
3906         * event-loop.c (gdb_wait_for_event): Call flush_streams.
3907
3908 2020-04-13  Tom Tromey  <tom@tromey.com>
3909
3910         * event-loop.c (handle_file_event): Use warning, not
3911         printf_unfiltered.
3912
3913 2020-04-13  Tom Tromey  <tom@tromey.com>
3914
3915         * event-loop.c: Include <chrono>.
3916
3917 2020-04-13  Tom Tromey  <tom@tromey.com>
3918
3919         * gdb_select.h: Move to ../gdbsupport/.
3920         * event-loop.c: Update include path.
3921         * top.c: Update include path.
3922         * ser-base.c: Update include path.
3923         * ui-file.c: Update include path.
3924         * ser-tcp.c: Update include path.
3925         * guile/scm-ports.c: Update include path.
3926         * posix-hdep.c: Update include path.
3927         * ser-unix.c: Update include path.
3928         * gdb_usleep.c: Update include path.
3929         * mingw-hdep.c: Update include path.
3930         * inflow.c: Update include path.
3931         * infrun.c: Update include path.
3932         * event-top.c: Update include path.
3933
3934 2020-04-13  Tom Tromey  <tom@tromey.com>
3935
3936         * configure: Rebuild.
3937         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
3938
3939 2020-04-13  Tom Tromey  <tom@tromey.com>
3940
3941         * event-loop.h (start_event_loop): Don't declare.
3942         * event-loop.c (start_event_loop): Move...
3943         * main.c (start_event_loop): ...here.  Now static.
3944
3945 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
3946
3947         * MAINTAINERS: Update my email address.
3948
3949 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3950
3951         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
3952         IP_ALL.
3953
3954 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3955
3956         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
3957         (nbsd_nat_target::info_proc): Add do_cmdline.
3958
3959 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3960
3961         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
3962         (nbsd_nat_target::info_proc): Add do_cwd.
3963
3964 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
3965
3966         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
3967
3968 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
3969
3970         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
3971         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
3972         (nbsd_nat_target::info_proc): New functions.
3973         * nbsd-nat.c (kinfo_get_vmmap): New function.
3974         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
3975         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
3976         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
3977         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
3978         functions.
3979         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
3980         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
3981         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
3982         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
3983         (KINFO_VME_FLAG_GROWS_DOWN): New.
3984
3985 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
3986
3987         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
3988         bit shift.
3989
3990 2020-04-10  Tom Tromey  <tromey@adacore.com>
3991
3992         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
3993
3994 2020-04-10  Tom Tromey  <tromey@adacore.com>
3995
3996         * symtab.c (get_symbol_address, get_msymbol_address): Skip
3997         separate debug files.
3998
3999 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4000
4001         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4002         Move to...
4003         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4004         ... here.
4005         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4006         Check for STATUS_WX86_BREAKPOINT.
4007         (windows_nat_target::wait): Same.
4008
4009 2020-04-10  Tom de Vries  <tdevries@suse.de>
4010
4011         PR cli/25808
4012         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4013
4014 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4015
4016         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4017         (Write After Approval): Remove Tom de Vries.
4018
4019 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4020
4021         revert partially:
4022         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4023
4024         * buildsym.c (record_line): Fix undefined behavior and preserve
4025         lines at eof.
4026
4027 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4028
4029         * auxv.h (svr4_auxv_parse): New.
4030         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4031         and generic_auxv_parse.
4032         (svr4_auxv_parse): Add.
4033         * obsd-tdep.c: Include "auxv.h".
4034         (obsd_auxv_parse): Remove.
4035         (obsd_init_abi): Remove comment.
4036         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
4037         from `obsd_auxv_parse' to `svr4_auxv_parse'.
4038         * nbsd-tdep.c: Include "auxv.h".
4039         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
4040
4041 2020-04-08  Tom Tromey  <tromey@adacore.com>
4042
4043         * nat/windows-nat.h (last_wait_event): Don't declare.
4044         (wait_for_debug_event): Update comment.
4045         * nat/windows-nat.c (last_wait_event): Now static.
4046
4047 2020-04-08  Tom Tromey  <tromey@adacore.com>
4048
4049         * windows-nat.c (wait_for_debug_event): Move to
4050         nat/windows-nat.c.
4051         * nat/windows-nat.h (wait_for_debug_event): Declare.
4052         * nat/windows-nat.c (wait_for_debug_event): Move from
4053         windows-nat.c.  No longer static.
4054
4055 2020-04-08  Tom Tromey  <tromey@adacore.com>
4056
4057         * windows-nat.c (get_windows_debug_event): Use
4058         fetch_pending_stop.
4059         * nat/windows-nat.h (fetch_pending_stop): Declare.
4060         * nat/windows-nat.c (fetch_pending_stop): New function.
4061
4062 2020-04-08  Tom Tromey  <tromey@adacore.com>
4063
4064         * windows-nat.c (windows_continue): Use matching_pending_stop and
4065         continue_last_debug_event.
4066         * nat/windows-nat.h (matching_pending_stop)
4067         (continue_last_debug_event): Declare.
4068         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4069         (matching_pending_stop, continue_last_debug_event): New
4070         functions.
4071
4072 2020-04-08  Tom Tromey  <tromey@adacore.com>
4073
4074         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4075         (handle_exception_result): Move to nat/windows-nat.h.
4076         (DEBUG_EXCEPTION_SIMPLE): Remove.
4077         (windows_nat::handle_ms_vc_exception): New function.
4078         (handle_exception): Move to nat/windows-nat.c.
4079         (get_windows_debug_event): Update.
4080         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4081         nat/windows-nat.c.
4082         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4083         (handle_exception_result): Move from windows-nat.c.
4084         (handle_exception): Declare.
4085         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4086         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4087         windows-nat.c.
4088
4089 2020-04-08  Tom Tromey  <tromey@adacore.com>
4090
4091         * windows-nat.c (exception_count, event_count): Remove.
4092         (handle_exception, get_windows_debug_event)
4093         (do_initial_windows_stuff): Update.
4094
4095 2020-04-08  Tom Tromey  <tromey@adacore.com>
4096
4097         * windows-nat.c (windows_nat::handle_load_dll)
4098         (windows_nat::handle_unload_dll): Rename.  No longer static.
4099         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4100         Declare.
4101
4102 2020-04-08  Tom Tromey  <tromey@adacore.com>
4103
4104         * complaints.h (stop_whining): Declare at top-level.
4105         (complaint): Don't declare stop_whining.
4106
4107 2020-04-08  Tom Tromey  <tromey@adacore.com>
4108
4109         * windows-nat.c (windows_nat::handle_output_debug_string):
4110         Rename.  No longer static.
4111         * nat/windows-nat.h (handle_output_debug_string): Declare.
4112
4113 2020-04-08  Tom Tromey  <tromey@adacore.com>
4114
4115         * windows-nat.c (current_process_handle, current_process_id)
4116         (main_thread_id, last_sig, current_event, last_wait_event)
4117         (current_windows_thread, desired_stop_thread_id, pending_stops)
4118         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4119         (display_selectors, fake_create_process)
4120         (get_windows_debug_event): Update.
4121         * nat/windows-nat.h (current_process_handle, current_process_id)
4122         (main_thread_id, last_sig, current_event, last_wait_event)
4123         (current_windows_thread, desired_stop_thread_id, pending_stops)
4124         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4125         * nat/windows-nat.c (current_process_handle, current_process_id)
4126         (main_thread_id, last_sig, current_event, last_wait_event)
4127         (current_windows_thread, desired_stop_thread_id, pending_stops)
4128         (siginfo_er): New globals.  Move from windows-nat.c.
4129
4130 2020-04-08  Tom Tromey  <tromey@adacore.com>
4131
4132         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4133         (handle_load_dll): Update.
4134         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4135
4136 2020-04-08  Tom Tromey  <tromey@adacore.com>
4137
4138         * windows-nat.c (enum thread_disposition_type): Move to
4139         nat/windows-nat.h.
4140         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4141         static.
4142         (windows_add_thread, windows_nat_target::fetch_registers)
4143         (windows_nat_target::store_registers, handle_exception)
4144         (windows_nat_target::resume, get_windows_debug_event)
4145         (windows_nat_target::get_tib_address)
4146         (windows_nat_target::thread_name)
4147         (windows_nat_target::thread_alive): Update.
4148         * nat/windows-nat.h (enum thread_disposition_type): Move from
4149         windows-nat.c.
4150         (thread_rec): Declare.
4151
4152 2020-04-08  Tom Tromey  <tromey@adacore.com>
4153
4154         * windows-nat.c: Add "using namespace".
4155         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4156         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4157
4158 2020-04-08  Tom Tromey  <tromey@adacore.com>
4159
4160         * nat/windows-nat.h (struct windows_thread_info): Declare
4161         destructor.
4162         * nat/windows-nat.c (~windows_thread_info): New.
4163
4164 2020-04-08  Tom Tromey  <tromey@adacore.com>
4165
4166         PR gdb/22992
4167         * windows-nat.c (current_event): Update comment.
4168         (last_wait_event, desired_stop_thread_id): New globals.
4169         (struct pending_stop): New.
4170         (pending_stops): New global.
4171         (windows_nat_target) <stopped_by_sw_breakpoint>
4172         <supports_stopped_by_sw_breakpoint>: New methods.
4173         (windows_fetch_one_register): Add assertions.  Adjust PC.
4174         (windows_continue): Handle pending stops.  Suspend other threads
4175         when stepping.  Use last_wait_event
4176         (wait_for_debug_event): New function.
4177         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4178         pending stops.  Queue spurious stops.
4179         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4180         (windows_nat_target::kill): Use wait_for_debug_event.
4181         * nat/windows-nat.h (struct windows_thread_info)
4182         <stopped_at_software_breakpoint>: New field.
4183         * nat/windows-nat.c (windows_thread_info::resume): Clear
4184         stopped_at_software_breakpoint.
4185
4186 2020-04-08  Tom Tromey  <tromey@adacore.com>
4187
4188         * windows-nat.c (enum thread_disposition_type): New.
4189         (thread_rec): Replace "get_context" parameter with "disposition";
4190         change type.
4191         (windows_add_thread, windows_nat_target::fetch_registers)
4192         (windows_nat_target::store_registers, handle_exception)
4193         (windows_nat_target::resume, get_windows_debug_event)
4194         (windows_nat_target::get_tib_address)
4195         (windows_nat_target::thread_name)
4196         (windows_nat_target::thread_alive): Update.
4197
4198 2020-04-08  Tom Tromey  <tromey@adacore.com>
4199
4200         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4201         (windows_continue): Use windows_continue::resume.
4202         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4203         resume>: Declare new methods.
4204         * nat/windows-nat.c: New file.
4205         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4206
4207 2020-04-08  Tom Tromey  <tromey@adacore.com>
4208
4209         * windows-nat.c (windows_add_thread, windows_delete_thread)
4210         (windows_nat_target::fetch_registers)
4211         (windows_nat_target::store_registers, fake_create_process)
4212         (windows_nat_target::resume, windows_nat_target::resume)
4213         (get_windows_debug_event, windows_nat_target::wait)
4214         (windows_nat_target::pid_to_str)
4215         (windows_nat_target::get_tib_address)
4216         (windows_nat_target::get_ada_task_ptid)
4217         (windows_nat_target::thread_name)
4218         (windows_nat_target::thread_alive): Use lwp, not tid.
4219
4220 2020-04-08  Tom Tromey  <tromey@adacore.com>
4221
4222         * windows-nat.c (handle_exception)
4223         (windows_nat_target::thread_name): Update.
4224         * nat/windows-nat.h (windows_thread_info): Remove destructor.
4225         <name>: Now unique_xmalloc_ptr.
4226
4227 2020-04-08  Tom Tromey  <tromey@adacore.com>
4228
4229         * windows-nat.c (thread_rec)
4230         (windows_nat_target::fetch_registers): Update.
4231         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
4232         Update comment.
4233         <debug_registers_changed, reload_context>: Now bool.
4234
4235 2020-04-08  Tom Tromey  <tromey@adacore.com>
4236
4237         * windows-nat.c (windows_add_thread): Use new.
4238         (windows_init_thread_list, windows_delete_thread): Use delete.
4239         (get_windows_debug_event): Update.
4240         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
4241         destructor, and initializers.
4242
4243 2020-04-08  Tom Tromey  <tromey@adacore.com>
4244
4245         * windows-nat.c (struct windows_thread_info): Remove.
4246         * nat/windows-nat.h: New file.
4247
4248 2020-04-08  Tom Tromey  <tromey@adacore.com>
4249
4250         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
4251         (thread_rec, windows_add_thread, windows_delete_thread)
4252         (windows_continue): Update.
4253
4254 2020-04-08  Tom Tromey  <tromey@adacore.com>
4255
4256         * windows-nat.c (struct windows_thread_info): Remove typedef.
4257         (thread_head): Remove.
4258         (thread_list): New global.
4259         (thread_rec, windows_add_thread, windows_init_thread_list)
4260         (windows_delete_thread, windows_continue): Update.
4261
4262 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4263
4264         * windows-tdep.h (windows_init_abi): Add comment.
4265         (cygwin_init_abi): New declaration.
4266         * windows-tdep.c: Split signal enumeration in two, one for
4267         Windows and one for Cygwin.
4268         (windows_gdb_signal_to_target): Only deal with signal of the
4269         Windows OS ABI.
4270         (cygwin_gdb_signal_to_target): New function.
4271         (windows_init_abi): Rename to windows_init_abi_common, don't set
4272         gdb_signal_to_target gdbarch method.  Add new new function with
4273         this name.
4274         (cygwin_init_abi): New function.
4275         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
4276         comment.  Don't call windows_init_abi.
4277         (amd64_windows_init_abi): Add comment, call windows_init_abi.
4278         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
4279         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
4280         i386_windows_init_abi_common, don't call windows_init_abi.  Add
4281         a new function of this name.
4282         (i386_cygwin_init_abi): New function.
4283         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
4284         OS ABI Cygwin.
4285
4286 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4287
4288         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
4289         parameter.c.
4290         (dwarf2_read_gdb_index): Update.
4291
4292 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
4293
4294         * nbsd-tdep.c: Include "objfiles.h".
4295         (nbsd_skip_solib_resolver): New.
4296         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
4297
4298 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4299
4300         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
4301         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
4302         with DW_LLE_base_addressx are being emitted in DWARFv5.
4303         Add the newly added kind DW_LOC_OFFSET_PAIR also.
4304         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
4305         unsigned integer.
4306
4307 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4308
4309         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
4310         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
4311         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
4312         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
4313         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
4314         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
4315         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
4316
4317
4318 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4319
4320         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
4321         (read_loclist_index): New function definition.
4322         (lookup_loclist_base): New function definition.
4323         (read_loclist_header): New function definition.
4324         (dwarf2_cu): Add loclist_base and loclist_header field.
4325         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
4326         (read_full_die_1): Read the value of DW_AT_loclists_base.
4327         (read_attribute_reprocess): Handle DW_FORM_loclistx.
4328         (read_attribute_value): Handle DW_FORM_loclistx.
4329         (skip_one_die): Handle DW_FORM_loclistx.
4330         (loclist_header): New structure declaration.
4331         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
4332
4333 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4334
4335         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
4336         constructor.  Remove `addr` parameter from other constructor and
4337         add `per_cu` parameter.
4338         * dwarf2/read.c (create_partial_symtab): Update.
4339
4340 2020-04-07  Tom de Vries  <tdevries@suse.de>
4341
4342         PR symtab/25796
4343         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
4344         (partial_die_info::fixup): Inherit has_const_value.
4345
4346 2020-04-07  Tom de Vries  <tdevries@suse.de>
4347
4348         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
4349         symbols without address.
4350
4351 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4352
4353         * nbsd-nat.h (struct thread_info): Add forward declaration.
4354         (nbsd_nat_target::thread_alive): Add.
4355         (nbsd_nat_target::thread_name): Likewise.
4356         (nbsd_nat_target::update_thread_list): Likewise.
4357         (update_thread_list::post_attach): Likewise.
4358         (post_attach::pid_to_str): Likewise.
4359         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
4360         (nbsd_thread_lister): Add.
4361         (nbsd_nat_target::thread_alive): Likewise.
4362         (nbsd_nat_target::thread_name): Likewise.
4363         (nbsd_add_threads): Likewise.
4364         (update_thread_list::post_attach): Likewise.
4365         (nbsd_nat_target::update_thread_list): Likewise.
4366         (post_attach::pid_to_str): Likewise.
4367
4368 2020-04-06  Tom Tromey  <tromey@adacore.com>
4369
4370         * ada-valprint.c (print_variant_part): Extract the variant field.
4371         (print_field_values): Use the field as the outer value when
4372         recursing.
4373
4374 2020-04-06  Tom Tromey  <tromey@adacore.com>
4375
4376         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
4377         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
4378         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
4379         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
4380         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
4381
4382 2020-04-06  Tom Tromey  <tromey@adacore.com>
4383
4384         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
4385         TYPE_CODE_ERROR.
4386
4387 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4388
4389         * nbsd-tdep.c: Include "gdbarch.h".
4390         Define enum with NetBSD signal numbers.
4391         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
4392         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
4393         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
4394         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
4395         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
4396         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
4397         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
4398         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
4399         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
4400         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
4401         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
4402         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
4403
4404 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
4405
4406         PR gdb/25325
4407         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
4408
4409 2020-04-03  Tom Tromey  <tromey@adacore.com>
4410
4411         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
4412         Read constant block.
4413
4414 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4415
4416         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
4417         (gdb_bfd_get_full_section_contents): New declaration.
4418         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
4419         * windows-tdep.c (is_linked_with_cygwin_dll): Use
4420         gdb_bfd_get_full_section_contents.
4421
4422 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4423
4424         * exec.c (build_section_table): Replace internal_error with
4425         gdb_assert.
4426         (section_table_xfer_memory_partial): Likewise.
4427         * mdebugread.c (parse_partial_symbols): Likewise.
4428         * psymtab.c (lookup_partial_symbol): Likewise.
4429         * utils.c (wrap_here): Likewise.
4430
4431 2020-04-02  Tom Tromey  <tromey@adacore.com>
4432
4433         * f-lang.c (build_fortran_types): Use arch_type to initialize
4434         builtin_complex_s32 in the TYPE_CODE_ERROR case.
4435
4436 2020-04-02  Tom Tromey  <tromey@adacore.com>
4437
4438         * dwarf2/read.c (partial_die_info::read): Do not create a vector
4439         of attributes.
4440
4441 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4442             Bernd Edlinger <bernd.edlinger@hotmail.de>
4443             Tom Tromey  <tromey@adacore.com>
4444
4445         * buildsym.c (buildsym_compunit::record_line): Remove
4446         deduplication code.
4447
4448 2020-04-02  Tom de Vries  <tdevries@suse.de>
4449
4450         PR ada/24671
4451         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
4452
4453 2020-04-02  Tom de Vries  <tdevries@suse.de>
4454
4455         * dwarf2/read.c (dwarf2_gdb_index_functions,
4456         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
4457         NULL.
4458         * psymtab.c (psym_lookup_global_symbol_language): New function.
4459         (psym_functions): Init psym_lookup_global_symbol_language with
4460         psym_lookup_global_symbol_language.
4461         * symfile-debug.c (debug_sym_quick_functions): Init
4462         lookup_global_symbol_language with NULL.
4463         * symfile.c (set_initial_language): Remove fixme comment.
4464         * symfile.h (struct quick_symbol_functions): Add
4465         lookup_global_symbol_language.
4466         * symtab.c (find_quick_global_symbol_language): New function.
4467         (find_main_name): Use find_quick_global_symbol_language.
4468
4469 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4470
4471         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
4472
4473 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4474
4475         * buildsym.c (record_line): Fix undefined behavior and preserve
4476         lines at eof.
4477
4478 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4479
4480         * buildsym.c (record_line): Fix the resizing condition.
4481
4482 2020-04-01  Tom Tromey  <tom@tromey.com>
4483
4484         * value.h (value_literal_complex): Add comment.
4485         * valops.c (value_literal_complex): Refer to value.h.
4486
4487 2020-04-01  Tom Tromey  <tom@tromey.com>
4488
4489         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
4490         (scalar_type): New rule, from typebase.
4491         (typebase): Use scalar_type.  Recognize complex types.
4492         (field_name): Handle FLOAT_KEYWORD.
4493         (ident_tokens): Add _Complex and __complex__.
4494
4495 2020-04-01  Tom Tromey  <tom@tromey.com>
4496
4497         PR exp/25299:
4498         * valarith.c (promotion_type, complex_binop): New functions.
4499         (scalar_binop): Handle complex numbers.  Use promotion_type.
4500         (value_pos, value_neg, value_complement): Handle complex numbers.
4501
4502 2020-04-01  Tom Tromey  <tom@tromey.com>
4503
4504         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
4505         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
4506         (parse_number): Handle complex numbers.
4507
4508 2020-04-01  Tom Tromey  <tom@tromey.com>
4509
4510         * c-valprint.c (c_decorations): Change complex suffix to "i".
4511
4512 2020-04-01  Tom Tromey  <tom@tromey.com>
4513
4514         * valprint.c (generic_value_print_complex): Use accessors.
4515         * value.h (value_real_part, value_imaginary_part): Declare.
4516         * valops.c (value_real_part, value_imaginary_part): New
4517         functions.
4518         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
4519
4520 2020-04-01  Tom Tromey  <tom@tromey.com>
4521
4522         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
4523         (read_range_type): Update.
4524         * mdebugread.c (basic_type): Update.
4525         * go-lang.c (build_go_types): Use init_complex_type.
4526         * gdbtypes.h (struct main_type) <complex_type>: New member.
4527         (init_complex_type): Update.
4528         (arch_complex_type): Don't declare.
4529         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
4530         Make name if none given.  Use alloc_type_copy.  Look for cached
4531         complex type.
4532         (arch_complex_type): Remove.
4533         (gdbtypes_post_init): Use init_complex_type.
4534         * f-lang.c (build_fortran_types): Use init_complex_type.
4535         * dwarf2/read.c (read_base_type): Update.
4536         * d-lang.c (build_d_types): Use init_complex_type.
4537         * ctfread.c (read_base_type): Update.
4538
4539 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4540
4541         * infrun.c (stop_all_threads): Update assertion, plus when
4542         stopping threads, take into account that we might be trying
4543         to stop an all-stop target.
4544         (stop_waiting): Call 'stop_all_threads' if there exists a
4545         non-stop target.
4546
4547 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4548
4549         * target.h (exists_non_stop_target): New function declaration.
4550         * target.c (exists_non_stop_target): New function.
4551
4552 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
4553
4554         PR gdb/24789
4555         * eval.c (is_integral_or_integral_reference): New function.
4556         (evaluate_subexp_standard): Allow integer references in
4557         pointer arithmetic.
4558
4559 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4560
4561         * remote.c (remote_target::remote_parse_stop_reply): Remove the
4562         check for no ptid in the stop reply when the target is non-stop.
4563
4564 2020-04-01  Tom Tromey  <tromey@adacore.com>
4565
4566         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
4567         "name" parameter to rvalue reference.  Initialize m_name_holder.
4568         <lookup_name_info>: New overloads.
4569         <name>: Return gdb::string_view.
4570         <c_str>: New method.
4571         <make_ignore_params>: Update.
4572         <search_name_hash>: Update.
4573         <language_lookup_name>: Return const char *.
4574         <m_name>: Change type.
4575         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
4576         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
4577         (lookup_name_info::match_any): Update.
4578         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
4579         Update.
4580         * minsyms.c (linkage_name_str): Update.
4581         * language.c (default_symbol_name_matcher): Update.
4582         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
4583         Update.
4584         * ada-lang.c (ada_fold_name): Change parameter to string_view.
4585         (ada_lookup_name_info::ada_lookup_name_info): Update.
4586         (literal_symbol_name_matcher): Update.
4587
4588 2020-04-01  Tom Tromey  <tromey@adacore.com>
4589
4590         * psymtab.c (psymtab_search_name): Remove function.
4591         (psym_lookup_symbol): Create search name and lookup name here.
4592         (lookup_partial_symbol): Remove "name" parameter; add
4593         lookup_name.
4594         (psym_expand_symtabs_for_function): Update.
4595
4596 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
4597
4598         PR tui/25597:
4599         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
4600
4601 2020-03-31  Tom Tromey  <tromey@adacore.com>
4602
4603         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
4604         memcpy.
4605
4606 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
4607
4608         * features/riscv/32bit-csr.xml: Regenerated.
4609         * features/riscv/64bit-csr.xml: Regenerated.
4610
4611 2020-03-30  Tom Tromey  <tromey@adacore.com>
4612
4613         * ada-valprint.c (print_variant_part): Update.
4614         * ada-lang.h (ada_which_variant_applies): Update.
4615         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
4616         outer_valaddr parameters; replace with "outer" value parameter.
4617         (to_fixed_variant_branch_type): Update.
4618
4619 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4620
4621         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
4622         <list>.  Remove inclusion of observable.h.
4623         (PPC_DEBUG_CURRENT_VERSION): Move up define.
4624         (struct arch_lwp_info): New struct.
4625         (class ppc_linux_dreg_interface): New class.
4626         (struct ppc_linux_process_info): New struct.
4627         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
4628         <low_new_clone, low_forget_process, low_prepare_to_resume>
4629         <copy_thread_dreg_state, mark_thread_stale>
4630         <mark_debug_registers_changed, register_hw_breakpoint>
4631         <clear_hw_breakpoint, register_wp, clear_wp>
4632         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
4633         <num_memory_accesses, get_trigger_type>
4634         <create_watchpoint_request, hwdebug_point_cmp>
4635         <init_arch_lwp_info, get_arch_lwp_info>
4636         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
4637         methods.
4638         <struct ptid_hash>: New inner struct.
4639         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
4640         members.
4641         (saved_dabr_value, hwdebug_info, max_slots_number)
4642         (struct hw_break_tuple, struct thread_points, ppc_threads)
4643         (have_ptrace_hwdebug_interface)
4644         (hwdebug_find_thread_points_by_tid)
4645         (hwdebug_insert_point, hwdebug_remove_point): Remove.
4646         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
4647         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
4648         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
4649         use m_dreg_interface.
4650         (hwdebug_point_cmp): Change to...
4651         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
4652         reference arguments instead of pointers.
4653         (ppc_linux_nat_target::ranged_break_num_registers): Use
4654         m_dreg_interface.
4655         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
4656         m_dreg_interface.  Call register_hw_breakpoint.
4657         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
4658         m_dreg_interface.  Call clear_hw_breakpoint.
4659         (get_trigger_type): Change to...
4660         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
4661         comment.
4662         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
4663         use m_dreg_interface.  Call register_hw_breakpoint.
4664         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
4665         use m_dreg_interface.  Call clear_hw_breakpoint.
4666         (can_use_watchpoint_cond_accel): Change to...
4667         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
4668         method.  Update comment, use m_dreg_interface and
4669         m_process_info.
4670         (calculate_dvc): Change to...
4671         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
4672         m_dreg_interface.
4673         (num_memory_accesses): Change to...
4674         (ppc_linux_nat_target::num_memory_accesses): ...this method.
4675         (check_condition): Change to...
4676         (ppc_linux_nat_target::check_condition): ...this method.
4677         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
4678         comment, use m_dreg_interface.
4679         (create_watchpoint_request): Change to...
4680         (ppc_linux_nat_target::create_watchpoint_request): ...this
4681         method.  Use m_dreg_interface.
4682         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
4683         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
4684         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
4685         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
4686         (ppc_linux_nat_target::low_forget_process)
4687         (ppc_linux_nat_target::low_new_fork)
4688         (ppc_linux_nat_target::low_new_clone)
4689         (ppc_linux_nat_target::low_delete_thread)
4690         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
4691         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
4692         only call mark_thread_stale.
4693         (ppc_linux_thread_exit): Remove.
4694         (ppc_linux_nat_target::stopped_data_address): Change to...
4695         (ppc_linux_nat_target::low_stopped_data_address): This. Add
4696         comment, use m_dreg_interface and m_thread_hw_breakpoints.
4697         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
4698         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
4699         comment.  Call low_stopped_data_address.
4700         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
4701         m_dreg_interface.
4702         (ppc_linux_nat_target::masked_watch_num_registers): Use
4703         m_dreg_interface.
4704         (ppc_linux_nat_target::copy_thread_dreg_state)
4705         (ppc_linux_nat_target::mark_thread_stale)
4706         (ppc_linux_nat_target::mark_debug_registers_changed)
4707         (ppc_linux_nat_target::register_hw_breakpoint)
4708         (ppc_linux_nat_target::clear_hw_breakpoint)
4709         (ppc_linux_nat_target::register_wp)
4710         (ppc_linux_nat_target::clear_wp)
4711         (ppc_linux_nat_target::init_arch_lwp_info)
4712         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
4713         (_initialize_ppc_linux_nat): Remove observer callback.
4714
4715 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4716
4717         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
4718         (ppc_linux_nat_target::auxv_parse)
4719         (ppc_linux_nat_target::read_description)
4720         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
4721         Move up.
4722
4723 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4724
4725         * linux-nat.h (low_new_clone): New method.
4726         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
4727
4728 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4729
4730         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
4731         (dbx_expand_psymtab): ... this.
4732         (start_psymtab): Update.
4733         * mdebugread.c (psymtab_to_symtab_1): Rename to...
4734         (mdebug_expand_psymtab): ... this.
4735         (parse_partial_symbols): Update.
4736         (new_psymtab): Update.
4737         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
4738         (xcoff_expand_psymtab): ... this.
4739         (xcoff_start_psymtab): Update.
4740
4741 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4742
4743         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
4744         <expand_dependencies>: ... this.
4745         * psymtab.c (partial_symtab::read_dependencies): Rename to...
4746         (partial_symtab::expand_dependencies): ... this.
4747         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
4748         Update.
4749         (dwarf2_psymtab::expand_psymtab): Update.
4750         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
4751         * mdebugread.c (psymtab_to_symtab_1): Update.
4752         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
4753
4754 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
4755
4756         * psympriv.h (discard_psymtab): Remove.
4757         * dbxread.c (dbx_end_psymtab): Update.
4758         * xcoffread.c (xcoff_end_psymtab): Update.
4759
4760 2020-03-28  Tom Tromey  <tom@tromey.com>
4761
4762         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
4763         comment.
4764
4765 2020-03-28  Tom Tromey  <tom@tromey.com>
4766
4767         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
4768
4769 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
4770
4771         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4772
4773 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
4774
4775         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
4776
4777 2020-03-26  Tom Tromey  <tom@tromey.com>
4778
4779         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
4780         (mark_common_block_symbol_computed, read_tag_string_type)
4781         (attr_to_dynamic_prop, read_subrange_type): Update.
4782         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
4783         to be methods on struct attribute.
4784         (skip_one_die, process_imported_unit_die, read_namespace_alias)
4785         (read_call_site_scope, partial_die_info::read)
4786         (partial_die_info::read, lookup_die_type, follow_die_ref):
4787         Update.
4788         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
4789         from dwarf2_get_ref_die_offset.
4790         (attribute::constant_value): New method, from
4791         dwarf2_get_attr_constant_value.
4792         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
4793         Declare method.
4794         <constant_value>: New method.
4795
4796 2020-03-26  Tom Tromey  <tom@tromey.com>
4797
4798         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
4799         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
4800         (dwarf_type_encoding_name): Move to stringify.c.
4801         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
4802         * dwarf2/stringify.c: New file.
4803         * dwarf2/stringify.h: New file.
4804
4805 2020-03-26  Tom Tromey  <tom@tromey.com>
4806
4807         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
4808         Rewrite.
4809
4810 2020-03-26  Tom Tromey  <tom@tromey.com>
4811
4812         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
4813         methods.
4814         * dwarf2/read.c (lookup_addr_base): Move to die.h.
4815         (lookup_ranges_base): Likewise.
4816         (read_cutu_die_from_dwo, read_full_die_1): Update.
4817
4818 2020-03-26  Tom Tromey  <tom@tromey.com>
4819
4820         * dwarf2/read.c (read_import_statement, read_file_scope)
4821         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
4822         (read_lexical_block_scope, read_call_site_scope)
4823         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
4824         (handle_struct_member_die, process_structure_scope)
4825         (update_enumeration_type_from_children)
4826         (process_enumeration_scope, read_array_type, read_common_block)
4827         (read_namespace, read_module, read_subroutine_type): Update.
4828         (sibling_die): Remove.
4829
4830 2020-03-26  Tom Tromey  <tom@tromey.com>
4831
4832         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
4833         (build_type_psymtabs_reader, read_structure_type)
4834         (read_enumeration_type, read_full_die_1): Update.
4835         (dwarf2_attr_no_follow): Move to die.h.
4836         * dwarf2/die.h (struct die_info) <attr>: New method.
4837
4838 2020-03-26  Tom Tromey  <tom@tromey.com>
4839
4840         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
4841         <base_address>: Now an optional.
4842         (dwarf2_find_base_address, dwarf2_rnglists_process)
4843         (dwarf2_ranges_process, fill_in_loclist_baton)
4844         (dwarf2_symbol_mark_computed): Update.
4845
4846 2020-03-26  Tom Tromey  <tom@tromey.com>
4847
4848         * dwarf2/read.c (struct die_info): Move to die.h.
4849         * dwarf2/die.h: New file.
4850
4851 2020-03-26  Tom Tromey  <tom@tromey.com>
4852
4853         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
4854         * dwarf2/read.c
4855         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4856         Move to line-header.c.
4857         (read_checked_initial_length_and_offset, read_formatted_entries):
4858         Likewise.
4859         (dwarf_decode_line_header): Split into two.
4860         * dwarf2/line-header.c
4861         (dwarf2_statement_list_fits_in_line_number_section_complaint):
4862         Move from read.c.
4863         (read_checked_initial_length_and_offset, read_formatted_entries):
4864         Likewise.
4865         (dwarf_decode_line_header): New function, split from read.c.
4866
4867 2020-03-26  Tom Tromey  <tom@tromey.com>
4868
4869         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
4870         Declare method.
4871         * dwarf2/read.c (read_attribute_value): Update.
4872         (dwarf2_per_objfile::read_line_string): Rename from
4873         read_indirect_line_string.
4874         (read_formatted_entries): Update.
4875
4876 2020-03-26  Tom Tromey  <tom@tromey.com>
4877
4878         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
4879         variable.
4880
4881 2020-03-26  Tom Tromey  <tom@tromey.com>
4882
4883         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
4884         const.
4885         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
4886         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
4887         parameter const.
4888
4889 2020-03-26  Tom Tromey  <tom@tromey.com>
4890
4891         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
4892         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
4893         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
4894         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
4895
4896 2020-03-26  Tom Tromey  <tom@tromey.com>
4897
4898         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
4899         file_names_size, file_full_name, file_file_name>: Use const.
4900         <file_name_at, file_names>: Add const overload.
4901         * dwarf2/line-header.c (line_header::file_file_name)
4902         (line_header::file_full_name): Update.
4903
4904 2020-03-26  Tom Tromey  <tom@tromey.com>
4905
4906         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
4907         (macro_start_file, consume_improper_spaces)
4908         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
4909         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
4910         (dwarf_decode_macros): Move to macro.c.
4911         * dwarf2/macro.c: New file.
4912         * dwarf2/macro.h: New file.
4913         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
4914
4915 2020-03-26  Tom Tromey  <tom@tromey.com>
4916
4917         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
4918         method.
4919         * dwarf2/section.c: New method.  From
4920         read_indirect_string_at_offset_from.
4921         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
4922         (read_indirect_string_at_offset_from): Move to section.c.
4923         (read_indirect_string_at_offset): Rewrite.
4924         (read_indirect_line_string_at_offset): Remove.
4925         (read_indirect_string, read_indirect_line_string)
4926         (dwarf_decode_macro_bytes): Update.
4927
4928 2020-03-26  Tom Tromey  <tom@tromey.com>
4929
4930         * dwarf2/section.h (struct dwarf2_section_info)
4931         <overload_complaint>: Declare.
4932         (dwarf2_section_buffer_overflow_complaint): Don't declare.
4933         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
4934         Rename from dwarf2_section_buffer_overflow_complaint.
4935         * dwarf2/read.c (skip_one_die, partial_die_info::read)
4936         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
4937
4938 2020-03-26  Tom Tromey  <tom@tromey.com>
4939
4940         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
4941         Declare.
4942         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
4943         Move from read.c.
4944         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
4945         to section.c.
4946
4947 2020-03-26  Tom Tromey  <tom@tromey.com>
4948
4949         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
4950
4951 2020-03-26  Tom Tromey  <tom@tromey.com>
4952
4953         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
4954         "builder".
4955         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
4956         parameter.
4957         (dwarf_decode_macros): Update.
4958
4959 2020-03-26  Tom Tromey  <tom@tromey.com>
4960
4961         * dwarf2/read.c (read_attribute_value): Update.
4962         (read_indirect_string_from_dwz): Move to dwz.c; change into
4963         method.
4964         (dwarf_decode_macro_bytes): Update.
4965         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
4966         * dwarf2/dwz.c: New file.
4967         * Makefile.in (COMMON_SFILES): Add dwz.c.
4968
4969 2020-03-26  Tom Tromey  <tom@tromey.com>
4970
4971         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
4972         * dwarf2/read.c: Add include.
4973         * dwarf2/index-write.c: Add include.
4974         * dwarf2/index-cache.c: Add include.
4975         * dwarf2/dwz.h: New file.
4976
4977 2020-03-25  Tom Tromey  <tom@tromey.com>
4978
4979         * compile/compile-object-load.c (get_out_value_type): Mention
4980         correct symbol name in error message.
4981
4982 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
4983
4984         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
4985
4986 2020-03-25  Tom de Vries  <tdevries@suse.de>
4987
4988         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
4989         * symmisc.c (dump_symtab_1): Print user and includes fields.
4990         (maintenance_info_symtabs): Same.
4991
4992 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         PR gdb/25534
4995         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
4996         (riscv_regcache_cooked_write): New function.
4997         (riscv_push_dummy_call): Use new function.
4998         (riscv_return_value): Likewise.
4999
5000 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5001
5002         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5003         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5004         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5005         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5006         * infrun.c (follow_fork): Likewise.
5007         (follow_fork_inferior): Likewise.
5008         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5009         * linux-nat.h (class linux_nat_target): Likewise.
5010         * remote.c (class remote_target) <follow_fork>: Likewise.
5011         (remote_target::follow_fork): Likewise.
5012         * target-delegates.c: Re-generate.
5013         * target.c (default_follow_fork): Likewise.
5014         (target_follow_fork): Likewise.
5015         * target.h (struct target_ops) <follow_fork>: Likewise.
5016         (target_follow_fork): Likewise.
5017
5018 2020-03-24  Tom de Vries  <tdevries@suse.de>
5019
5020         * psymtab.c (maintenance_info_psymtabs): Print user field.
5021
5022 2020-03-20  Tom Tromey  <tromey@adacore.com>
5023
5024         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5025         const.
5026         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5027         const.
5028
5029 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5030
5031         * ptrace.m4: Don't check for ptrace declaration.
5032         * config.in: Re-generate.
5033         * configure: Re-generate.
5034         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5035         not defined.
5036
5037 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5038
5039         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
5040         `PTRACE_TYPE_RET'.
5041         * i386-bsd-nat.c (gdb_ptrace): Likewise.
5042         * sparc-nat.c (gdb_ptrace): Likewise.
5043         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5044
5045 2020-03-20  Tom Tromey  <tromey@adacore.com>
5046
5047         * c-exp.y (lex_one_token): Fix assert.
5048
5049 2020-03-20  Tom Tromey  <tromey@adacore.com>
5050
5051         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5052         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5053         strncpy call.
5054
5055 2020-03-20  Tom Tromey  <tromey@adacore.com>
5056
5057         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5058
5059 2020-03-20  Tom Tromey  <tromey@adacore.com>
5060
5061         * ada-valprint.c (print_variant_part): Remove parameters; switch
5062         to value-based API.
5063         (print_field_values): Likewise.
5064         (ada_val_print_struct_union): Likewise.
5065         (ada_value_print_1): Update.
5066
5067 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5068
5069         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5070         nbsd_nat_target instead of inf_ptrace_target.
5071         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5072         nbsd_nat_target.
5073
5074 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5075
5076         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5077         it to the ptrace call.
5078         * (store_registers): Likewise.
5079
5080 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5081
5082         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5083         it to the ptrace call.
5084         * (store_registers): Likewise.
5085
5086 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5087
5088         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5089         valid, fetch vg value from ptrace.
5090
5091 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5092         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5093         * inf-ptrace.c: Likewise.
5094         * (gdb_ptrace): Add.
5095         * (inf_ptrace_target::resume): Update.
5096         * (inf_ptrace_target::xfer_partial): Likewise.
5097         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5098         * (inf_ptrace_peek_poke): Update.
5099
5100 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5101
5102         * x86-bsd-nat.c (gdb_ptrace): New.
5103         * (x86bsd_dr_set): Add new argument `ptid'.
5104         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5105         x86bsd_dr_set_addr): Update.
5106
5107 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5108
5109         * remote.c (remote_target::process_stop_reply): Handle events for
5110         all threads differently.
5111
5112 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5113
5114         * completer.c (completion_tracker::remove_completion): Define new
5115         function.
5116         * completer.h (completion_tracker::remove_completion): Declare new
5117         function.
5118         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5119         when adding a C++ function symbol.
5120
5121 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5122
5123         * completer.c (completion_tracker::completion_hash_entry): Define
5124         new class.
5125         (advance_to_filename_complete_word_point): Call
5126         recompute_lowest_common_denominator.
5127         (completion_tracker::completion_tracker): Call discard_completions
5128         to setup the hash table.
5129         (completion_tracker::discard_completions): Allow for being called
5130         from the constructor, pass new equal function, and element deleter
5131         when constructing the hash table.  Initialise new class member
5132         variables.
5133         (completion_tracker::maybe_add_completion): Remove use of
5134         m_entries_vec, and store more information into m_entries_hash.
5135         (completion_tracker::recompute_lcd_visitor): New function, most
5136         content taken from...
5137         (completion_tracker::recompute_lowest_common_denominator):
5138         ...here, this now just visits each item in the hash calling the
5139         above visitor.
5140         (completion_tracker::build_completion_result): Remove use of
5141         m_entries_vec, call recompute_lowest_common_denominator.
5142         * completer.h (completion_tracker::have_completions): Remove use
5143         of m_entries_vec.
5144         (completion_tracker::completion_hash_entry): Declare new class.
5145         (completion_tracker::recompute_lowest_common_denominator): Change
5146         function signature.
5147         (completion_tracker::recompute_lcd_visitor): Declare new function.
5148         (completion_tracker::m_entries_vec): Delete.
5149         (completion_tracker::m_entries_hash): Initialize to NULL.
5150         (completion_tracker::m_lowest_common_denominator_valid): New
5151         member variable.
5152         (completion_tracker::m_lowest_common_denominator_max_length): New
5153         member variable.
5154
5155 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5156
5157         * regformats/regdef.h: Put reg in gdb namespace.
5158
5159 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5160
5161         * i386-bsd-nat.c (gdb_ptrace): New.
5162         * (i386bsd_fetch_inferior_registers,
5163         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5164         * (i386bsd_fetch_inferior_registers,
5165         i386bsd_store_inferior_registers) Use gdb_ptrace.
5166
5167 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5168
5169         * amd64-bsd-nat.c (gdb_ptrace): New.
5170         * (amd64bsd_fetch_inferior_registers,
5171         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5172         * (amd64bsd_fetch_inferior_registers,
5173         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5174
5175 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5176
5177         * user-regs.c (user_reg::read): Rename to...
5178         (user_reg::xread): ...this.
5179         * (append_user_reg): Rename argument `read' to `xread'.
5180         * (user_reg_add_builtin): Likewise.
5181         * (user_reg_add): Likewise.
5182         * (value_of_user_reg): Likewise.
5183
5184 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5185
5186         * sparc-nat.c (gdb_ptrace): New.
5187         * sparc-nat.c (sparc_fetch_inferior_registers)
5188         (sparc_store_inferior_registers) Remove obsolete comment.
5189         * sparc-nat.c (sparc_fetch_inferior_registers)
5190         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5191         * sparc-nat.c (sparc_fetch_inferior_registers)
5192         (sparc_store_inferior_registers) Use gdb_ptrace.
5193
5194 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5195
5196         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5197         it to the ptrace call.
5198         * sh-nbsd-nat.c (store_registers): Likewise.
5199
5200 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5201
5202         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5203         nbsd_nat_target instead of inf_ptrace_target.
5204         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5205         nbsd_nat_target.
5206
5207 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5208
5209         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5210
5211 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5212
5213         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5214         <sys/sysctl.h>.
5215         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5216
5217 2020-03-17  Tom de Vries  <tdevries@suse.de>
5218
5219         PR gdb/23710
5220         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
5221         fields.
5222         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
5223         fields.
5224         (process_imported_unit_die): Skip import of c++ CUs.
5225
5226 2020-03-16  Tom Tromey  <tom@tromey.com>
5227
5228         * p-valprint.c (pascal_object_print_value): Initialize
5229         base_value.
5230
5231 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
5232             Shahab Vahedi  <shahab@synopsys.com>
5233
5234         * Makefile.in: Add arch/arc.o
5235         * configure.tgt: Likewise.
5236         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
5237         (_initialize_arc_tdep): Don't initialize old target descriptions.
5238         (arc_read_description): New function to cache target descriptions.
5239         * arc-tdep.h (arc_read_description): Add proto type.
5240         * arch/arc.c: New file.
5241         * arch/arc.h: Likewise.
5242         * features/Makefile: Replace old target descriptions with new.
5243         * features/arc-arcompact.c: Remove.
5244         * features/arc-arcompact.xml: Likewise.
5245         * features/arc-v2.c: Likewise
5246         * features/arc-v2.xml: Likewise
5247         * features/arc/aux-arcompact.xml: New file.
5248         * features/arc/aux-v2.xml: Likewise.
5249         * features/arc/core-arcompact.xml: Likewise.
5250         * features/arc/core-v2.xml: Likewise.
5251         * features/arc/aux-arcompact.c: Generate.
5252         * features/arc/aux-v2.c: Likewise.
5253         * features/arc/core-arcompact.c: Likewise.
5254         * features/arc/core-v2.c: Likewise.
5255         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
5256
5257 2020-03-16  Tom Tromey  <tromey@adacore.com>
5258
5259         PR gdb/25663:
5260         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
5261         putting value into bcache.
5262
5263 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5264
5265         PR gdb/21500
5266         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
5267         to...
5268         (amd64_windows_init_abi_common): ... this.  Don't set size of
5269         long type.
5270         (amd64_windows_init_abi): New function.
5271         (amd64_cygwin_init_abi): New function.
5272         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
5273         the Cygwin OS ABI.
5274         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
5275         comment.
5276
5277 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5278
5279         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
5280         * windows-tdep.c (CYGWIN_DLL_NAME): New.
5281         (pe_import_directory_entry): New struct type.
5282         (is_linked_with_cygwin_dll): New function.
5283         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
5284         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
5285         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
5286
5287 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5288
5289         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
5290         i386_cygwin_core_osabi_sniffer.
5291
5292 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5293
5294         * i386-cygwin-tdep.c: Rename to...
5295         * i386-windows-tdep.c: ... this.
5296         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
5297         i386-windows-tdep.c.
5298         * configure.tgt: Likewise.
5299
5300 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5301
5302         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
5303         * osabi.c (gdb_osabi_names): Add "Windows".
5304         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
5305         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
5306         (i386_cygwin_core_osabi_sniffer): New function, extracted from
5307         i386_cygwin_osabi_sniffer.
5308         (_initialize_i386_cygwin_tdep): Register OS ABI
5309         GDB_OSABI_WINDOWS for i386.
5310         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
5311         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
5312         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
5313         for x86-64.
5314         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
5315         when the target matches '*-*-mingw*'.
5316
5317 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5318
5319         * defs.h (enum gdb_osabi): Move to...
5320         * osabi.h (enum gdb_osabi): ... here.
5321         * gdbarch.sh: Include osabi.h in gdbarch.h.
5322         * gdbarch.h: Re-generate.
5323
5324 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5325
5326         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
5327         function.
5328         (_initialize_amd64_windows_tdep): Register osabi sniffer.
5329
5330 2020-03-14  Tom Tromey  <tom@tromey.com>
5331
5332         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
5333         for C++.
5334         (c_type_print_modifier): Likewise.  Add "language" parameter.
5335         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
5336         (c_type_print_base_1): Update.
5337         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
5338         constants.
5339         * type-stack.c (type_stack::insert): Handle tp_atomic and
5340         tp_restrict.
5341         (type_stack::follow_type_instance_flags): Likewise.
5342         (type_stack::follow_types): Likewise.  Merge type-following code.
5343         * c-exp.y (RESTRICT, ATOMIC): New tokens.
5344         (space_identifier, cv_with_space_id)
5345         (const_or_volatile_or_space_identifier_noopt)
5346         (const_or_volatile_or_space_identifier): Remove.
5347         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
5348         rules.
5349         (ptr_operator, typebase): Update.
5350         (enum token_flag) <FLAG_C>: New constant.
5351         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
5352         "_Atomic".
5353         (lex_one_token): Handle FLAG_C.
5354
5355 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5356
5357         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
5358         it to the ptrace call.
5359         * m68k-bsd-nat.c (store_registers): Likewise.
5360
5361 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5362
5363         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
5364         gdb_byte *.
5365         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
5366         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
5367         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
5368
5369 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5370
5371         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
5372         nbsd_nat_target instead of inf_ptrace_target.
5373         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5374         nbsd_nat_target.
5375
5376 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5377
5378         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
5379         register_t.
5380
5381 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5382
5383         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
5384         it to the ptrace call.
5385         * alpha-bsd-nat.c (store_registers): Likewise.
5386
5387 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5388
5389         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
5390         includes.
5391         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
5392         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
5393         fill_fpregset): Likewise.
5394
5395 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5396
5397         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
5398         nbsd_nat_target instead of inf_ptrace_target.
5399         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5400         nbsd_nat_target.
5401
5402 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5403
5404         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
5405         register_t.
5406
5407 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5408
5409         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
5410         it to the ptrace call.
5411         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
5412         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
5413         * arm-nbsd-nat.c (store_register): Likewise.
5414         * arm-nbsd-nat.c (store_regs): Likewise.
5415         * arm-nbsd-nat.c (store_fp_register): Likewise.
5416         * arm-nbsd-nat.c (store_fp_regs): Likewise.
5417
5418 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5419
5420         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
5421         nbsd_nat_target instead of inf_ptrace_target.
5422         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5423         nbsd_nat_target.
5424
5425 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5426
5427         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
5428         it to the ptrace call.
5429         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
5430
5431 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5432
5433         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
5434         it to the ptrace call.
5435         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
5436
5437 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5438
5439         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
5440         gdb_byte *.
5441         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
5442
5443 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5444
5445         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
5446         instead of inf_ptrace_target.
5447         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5448         nbsd_nat_target.
5449
5450 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5451
5452         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5453         register_t.
5454
5455 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5456
5457         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5458         register_t.
5459
5460 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5461
5462         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
5463         register_t.
5464
5465 2020-03-13  Tom Tromey  <tom@tromey.com>
5466
5467         * value.h (val_print): Don't declare.
5468         * valprint.h (val_print_array_elements)
5469         (val_print_scalar_formatted, generic_val_print): Don't declare.
5470         * valprint.c (generic_val_print_array): Take a struct value.
5471         (generic_val_print_ptr, generic_val_print_memberptr)
5472         (generic_val_print_bool, generic_val_print_int)
5473         (generic_val_print_char, generic_val_print_complex)
5474         (generic_val_print): Remove.
5475         (generic_value_print): Update.
5476         (do_val_print): Remove unused parameters.  Don't call
5477         la_val_print.
5478         (val_print): Remove.
5479         (common_val_print): Update.  Don't call value_check_printable.
5480         (val_print_scalar_formatted, val_print_array_elements): Remove.
5481         * rust-lang.c (rust_val_print): Remove.
5482         (rust_language_defn): Update.
5483         * p-valprint.c (pascal_val_print): Remove.
5484         (pascal_value_print_inner): Update.
5485         (pascal_object_print_val_fields, pascal_object_print_val):
5486         Remove.
5487         (pascal_object_print_static_field): Update.
5488         * p-lang.h (pascal_val_print): Don't declare.
5489         * p-lang.c (pascal_language_defn): Update.
5490         * opencl-lang.c (opencl_language_defn): Update.
5491         * objc-lang.c (objc_language_defn): Update.
5492         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
5493         * m2-lang.h (m2_val_print): Don't declare.
5494         * m2-lang.c (m2_language_defn): Update.
5495         * language.h (struct language_defn) <la_val_print>: Remove.
5496         * language.c (unk_lang_value_print_inner): Rename.  Change
5497         argument types.
5498         (unknown_language_defn, auto_language_defn): Update.
5499         * go-valprint.c (go_val_print): Remove.
5500         * go-lang.h (go_val_print): Don't declare.
5501         * go-lang.c (go_language_defn): Update.
5502         * f-valprint.c (f_val_print): Remove.
5503         * f-lang.h (f_value_print): Don't declare.
5504         * f-lang.c (f_language_defn): Update.
5505         * d-valprint.c (d_val_print): Remove.
5506         * d-lang.h (d_value_print): Don't declare.
5507         * d-lang.c (d_language_defn): Update.
5508         * cp-valprint.c (cp_print_value_fields)
5509         (cp_print_value_fields_rtti, cp_print_value): Remove.
5510         (cp_print_static_field): Update.
5511         * c-valprint.c (c_val_print_array, c_val_print_ptr)
5512         (c_val_print_struct, c_val_print_union, c_val_print_int)
5513         (c_val_print_memberptr, c_val_print): Remove.
5514         * c-lang.h (c_val_print_array, cp_print_value_fields)
5515         (cp_print_value_fields_rtti): Don't declare.
5516         * c-lang.c (c_language_defn, cplus_language_defn)
5517         (asm_language_defn, minimal_language_defn): Update.
5518         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
5519         (ada_val_print_enum): Take a struct value.
5520         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
5521         (ada_val_print): Remove.
5522         (ada_value_print_1): Update.
5523         (printable_val_type): Remove.
5524         * ada-lang.h (ada_val_print): Don't declare.
5525         * ada-lang.c (ada_language_defn): Update.
5526
5527 2020-03-13  Tom Tromey  <tom@tromey.com>
5528
5529         * valprint.c (do_val_print): Update.
5530         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
5531         a struct value.
5532         (value_to_value_object_no_release): Declare.
5533         * python/py-value.c (value_to_value_object_no_release): New
5534         function.
5535         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
5536         struct value.
5537         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
5538         function.
5539         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
5540         a struct value.
5541         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
5542         Declare.
5543         (gdbscm_apply_val_pretty_printer): Take a struct value.
5544         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
5545         value.
5546         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
5547         value.
5548         * extension-priv.h (struct extension_language_ops)
5549         <apply_val_pretty_printer>: Take a struct value.
5550         * cp-valprint.c (cp_print_value): Create a struct value.
5551         (cp_print_value): Update.
5552
5553 2020-03-13  Tom Tromey  <tom@tromey.com>
5554
5555         * ada-valprint.c (print_field_values): Call common_val_print.
5556
5557 2020-03-13  Tom Tromey  <tom@tromey.com>
5558
5559         * ada-valprint.c (val_print_packed_array_elements): Remove
5560         bitoffset and val parameters.  Call common_val_print.
5561         (ada_val_print_string): Remove offset, address, and original_value
5562         parameters.
5563         (ada_val_print_array): Update.
5564         (ada_value_print_array): New function.
5565         (ada_value_print_1): Call it.
5566
5567 2020-03-13  Tom Tromey  <tom@tromey.com>
5568
5569         * ada-valprint.c (ada_value_print): Use common_val_print.
5570
5571 2020-03-13  Tom Tromey  <tom@tromey.com>
5572
5573         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
5574
5575 2020-03-13  Tom Tromey  <tom@tromey.com>
5576
5577         * ada-valprint.c (ada_value_print_num): New function.
5578         (ada_value_print_1): Use it.
5579
5580 2020-03-13  Tom Tromey  <tom@tromey.com>
5581
5582         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
5583
5584 2020-03-13  Tom Tromey  <tom@tromey.com>
5585
5586         * ada-valprint.c (ada_value_print_ptr): New function.
5587         (ada_value_print_1): Use it.
5588
5589 2020-03-13  Tom Tromey  <tom@tromey.com>
5590
5591         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
5592         call common_val_print.
5593         (ada_val_print_1): Update.
5594         (ada_value_print_1): New function.
5595         (ada_value_print_inner): Rewrite.
5596
5597 2020-03-13  Tom Tromey  <tom@tromey.com>
5598
5599         * cp-valprint.c (cp_print_value_fields): Update.
5600         (cp_print_value): New function.
5601
5602 2020-03-13  Tom Tromey  <tom@tromey.com>
5603
5604         * m2-valprint.c (m2_value_print_inner): Use
5605         cp_print_value_fields.
5606         * cp-valprint.c (cp_print_value_fields): New function.
5607         * c-valprint.c (c_value_print_struct): New function.
5608         (c_value_print_inner): Use c_value_print_struct.
5609         * c-lang.h (cp_print_value_fields): Declare.
5610
5611 2020-03-13  Tom Tromey  <tom@tromey.com>
5612
5613         * c-valprint.c (c_value_print_array): New function.
5614         (c_value_print_inner): Use it.
5615
5616 2020-03-13  Tom Tromey  <tom@tromey.com>
5617
5618         * c-valprint.c (c_value_print_memberptr): New function.
5619         (c_value_print_inner): Use it.
5620
5621 2020-03-13  Tom Tromey  <tom@tromey.com>
5622
5623         * c-valprint.c (c_value_print_int): New function.
5624         (c_value_print_inner): Use it.
5625
5626 2020-03-13  Tom Tromey  <tom@tromey.com>
5627
5628         * c-valprint.c (c_value_print_ptr): New function.
5629         (c_value_print_inner): Use it.
5630
5631 2020-03-13  Tom Tromey  <tom@tromey.com>
5632
5633         * c-valprint.c (c_value_print_inner): Rewrite.
5634
5635 2020-03-13  Tom Tromey  <tom@tromey.com>
5636
5637         * valprint.c (generic_value_print_complex): New function.
5638         (generic_value_print): Use it.
5639
5640 2020-03-13  Tom Tromey  <tom@tromey.com>
5641
5642         * valprint.c (generic_val_print_float): Don't call
5643         val_print_scalar_formatted.
5644         (generic_val_print, generic_value_print): Update.
5645
5646 2020-03-13  Tom Tromey  <tom@tromey.com>
5647
5648         * valprint.c (generic_value_print_char): New function
5649         (generic_value_print): Use it.
5650
5651 2020-03-13  Tom Tromey  <tom@tromey.com>
5652
5653         * valprint.c (generic_value_print_int): New function.
5654         (generic_value_print): Use it.
5655
5656 2020-03-13  Tom Tromey  <tom@tromey.com>
5657
5658         * valprint.c (generic_value_print_bool): New function.
5659         (generic_value_print): Use it.
5660
5661 2020-03-13  Tom Tromey  <tom@tromey.com>
5662
5663         * valprint.c (generic_val_print_func): Simplify.
5664         (generic_val_print, generic_value_print): Update.
5665
5666 2020-03-13  Tom Tromey  <tom@tromey.com>
5667
5668         * valprint.c (generic_val_print_flags): Remove.
5669         (generic_val_print, generic_value_print): Update.
5670         (val_print_type_code_flags): Add original_value parameter.
5671
5672 2020-03-13  Tom Tromey  <tom@tromey.com>
5673
5674         * valprint.c (generic_val_print): Update.
5675         (generic_value_print): Update.
5676         * valprint.c (generic_val_print_enum): Don't call
5677         val_print_scalar_formatted.
5678
5679 2020-03-13  Tom Tromey  <tom@tromey.com>
5680
5681         * valprint.c (generic_value_print): Call generic_value_print_ptr.
5682         * valprint.c (generic_value_print_ptr): New function.
5683
5684 2020-03-13  Tom Tromey  <tom@tromey.com>
5685
5686         * valprint.c (generic_value_print): Rewrite.
5687
5688 2020-03-13  Tom Tromey  <tom@tromey.com>
5689
5690         * p-valprint.c (pascal_object_print_value_fields)
5691         (pascal_object_print_value): New functions.
5692
5693 2020-03-13  Tom Tromey  <tom@tromey.com>
5694
5695         * p-valprint.c (pascal_value_print_inner): Rewrite.
5696
5697 2020-03-13  Tom Tromey  <tom@tromey.com>
5698
5699         * f-valprint.c (f_value_print_innner): Rewrite.
5700
5701 2020-03-13  Tom Tromey  <tom@tromey.com>
5702
5703         * m2-valprint.c (m2_print_unbounded_array): New overload.
5704         (m2_print_unbounded_array): Update.
5705         (m2_print_array_contents): Take a struct value.
5706         (m2_value_print_inner): Rewrite.
5707
5708 2020-03-13  Tom Tromey  <tom@tromey.com>
5709
5710         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
5711         (d_value_print_inner): New function.
5712         * d-lang.h (d_value_print_inner): Declare.
5713         * d-lang.c (d_language_defn): Use d_value_print_inner.
5714
5715 2020-03-13  Tom Tromey  <tom@tromey.com>
5716
5717         * go-valprint.c (go_value_print_inner): New function.
5718         * go-lang.h (go_value_print_inner): Declare.
5719         * go-lang.c (go_language_defn): Use go_value_print_inner.
5720
5721 2020-03-13  Tom Tromey  <tom@tromey.com>
5722
5723         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
5724         API.
5725         (rust_val_print): Rewrite.
5726         (rust_value_print_inner): New function, from rust_val_print.
5727         (rust_language_defn): Use rust_value_print_inner.
5728
5729 2020-03-13  Tom Tromey  <tom@tromey.com>
5730
5731         * ada-valprint.c (ada_value_print_inner): New function.
5732         * ada-lang.h (ada_value_print_inner): Declare.
5733         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
5734
5735 2020-03-13  Tom Tromey  <tom@tromey.com>
5736
5737         * f-valprint.c (f_value_print_innner): New function.
5738         * f-lang.h (f_value_print_innner): Declare.
5739         * f-lang.c (f_language_defn): Use f_value_print_innner.
5740
5741 2020-03-13  Tom Tromey  <tom@tromey.com>
5742
5743         * p-valprint.c (pascal_value_print_inner): New function.
5744         * p-lang.h (pascal_value_print_inner): Declare.
5745         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
5746
5747 2020-03-13  Tom Tromey  <tom@tromey.com>
5748
5749         * m2-valprint.c (m2_value_print_inner): New function.
5750         * m2-lang.h (m2_value_print_inner): Declare.
5751         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
5752
5753 2020-03-13  Tom Tromey  <tom@tromey.com>
5754
5755         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
5756         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
5757         * c-valprint.c (c_value_print_inner): New function.
5758         * c-lang.h (c_value_print_inner): Declare.
5759         * c-lang.c (c_language_defn, cplus_language_defn)
5760         (asm_language_defn, minimal_language_defn): Use
5761         c_value_print_inner.
5762
5763 2020-03-13  Tom Tromey  <tom@tromey.com>
5764
5765         * p-valprint.c (pascal_object_print_value_fields): Now static.
5766         * p-lang.h (pascal_object_print_value_fields): Don't declare.
5767
5768 2020-03-13  Tom Tromey  <tom@tromey.com>
5769
5770         * c-valprint.c (c_val_print_array): Simplify.
5771
5772 2020-03-13  Tom Tromey  <tom@tromey.com>
5773
5774         * valprint.c (value_print_array_elements): New function.
5775         * valprint.h (value_print_array_elements): Declare.
5776
5777 2020-03-13  Tom Tromey  <tom@tromey.com>
5778
5779         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
5780         * mips-tdep.c (mips_print_register): Use
5781         value_print_scalar_formatted.
5782
5783 2020-03-13  Tom Tromey  <tom@tromey.com>
5784
5785         * valprint.h (value_print_scalar_formatted): Declare.
5786         * valprint.c (value_print_scalar_formatted): New function.
5787
5788 2020-03-13  Tom Tromey  <tom@tromey.com>
5789
5790         * valprint.h (generic_value_print): Declare.
5791         * valprint.c (generic_value_print): New function.
5792
5793 2020-03-13  Tom Tromey  <tom@tromey.com>
5794
5795         * valprint.c (do_val_print): Call la_value_print_inner, if
5796         available.
5797         * rust-lang.c (rust_language_defn): Update.
5798         * p-lang.c (pascal_language_defn): Update.
5799         * opencl-lang.c (opencl_language_defn): Update.
5800         * objc-lang.c (objc_language_defn): Update.
5801         * m2-lang.c (m2_language_defn): Update.
5802         * language.h (struct language_defn) <la_value_print_inner>: New
5803         member.
5804         * language.c (unknown_language_defn, auto_language_defn): Update.
5805         * go-lang.c (go_language_defn): Update.
5806         * f-lang.c (f_language_defn): Update.
5807         * d-lang.c (d_language_defn): Update.
5808         * c-lang.c (c_language_defn, cplus_language_defn)
5809         (asm_language_defn, minimal_language_defn): Update.
5810         * ada-lang.c (ada_language_defn): Update.
5811
5812 2020-03-13  Tom Tromey  <tom@tromey.com>
5813
5814         * c-valprint.c (c_value_print): Use common_val_print.
5815
5816 2020-03-13  Tom Tromey  <tom@tromey.com>
5817
5818         * cp-valprint.c (cp_print_static_field): Use common_val_print.
5819
5820 2020-03-13  Tom Tromey  <tom@tromey.com>
5821
5822         * f-valprint.c (f77_print_array_1, f_val_print): Use
5823         common_val_print.
5824
5825 2020-03-13  Tom Tromey  <tom@tromey.com>
5826
5827         * riscv-tdep.c (riscv_print_one_register_info): Use
5828         common_val_print.
5829
5830 2020-03-13  Tom Tromey  <tom@tromey.com>
5831
5832         * mi/mi-main.c (output_register): Use common_val_print.
5833
5834 2020-03-13  Tom Tromey  <tom@tromey.com>
5835
5836         * infcmd.c (default_print_one_register_info): Use
5837         common_val_print.
5838
5839 2020-03-13  Tom Tromey  <tom@tromey.com>
5840
5841         * valprint.h (common_val_print_checked): Declare.
5842         * valprint.c (common_val_print_checked): New function.
5843         * stack.c (print_frame_arg): Use common_val_print_checked.
5844
5845 2020-03-13  Tom Tromey  <tom@tromey.com>
5846
5847         * valprint.c (do_val_print): New function, from val_print.
5848         (val_print): Use do_val_print.
5849         (common_val_print): Use do_val_print.
5850
5851 2020-03-13  Tom Tromey  <tom@tromey.com>
5852
5853         * valprint.c (value_print): Use scoped_value_mark.
5854
5855 2020-03-13  Tom de Vries  <tdevries@suse.de>
5856
5857         PR symtab/25646
5858         * psymtab.c (partial_symtab::partial_symtab): Don't set
5859         globals_offset and statics_offset.  Push element onto
5860         current_global_psymbols and current_static_psymbols stacks.
5861         (concat): New function.
5862         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
5863         element from current_global_psymbols and current_static_psymbols
5864         stacks.  Concat popped elements to global_psymbols and
5865         static_symbols.
5866         (add_psymbol_to_list): Use current_global_psymbols and
5867         current_static_psymbols stacks.
5868         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
5869         current_static_psymbols fields.
5870
5871 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5872
5873         * corelow.c (sniff_core_bfd): Remove.
5874         (class core_target) <m_core_vec>: Remove.
5875         (core_target::core_target): Update.
5876         (core_file_fns): Remove.
5877         (deprecated_add_core_fns): Remove.
5878         (default_core_sniffer): Remove.
5879         (sniff_core_bfd): Remove.
5880         (default_check_format): Remove.
5881         (gdb_check_format): Remove.
5882         (core_target_open): Update.
5883         (core_target::get_core_register_section): Update.
5884         (get_core_registers_cb): Update.
5885         (core_target::fetch_registers): Update.
5886         * gdbcore.h (struct core_fns): Remove.
5887         (deprecated_add_core_fns): Remove.
5888         (default_core_sniffer): Remove.
5889         (default_check_format): Remove.
5890
5891 2020-03-12  Tom Tromey  <tom@tromey.com>
5892
5893         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
5894         CORE_ADDR.
5895         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
5896
5897 2020-03-12  Tom Tromey  <tom@tromey.com>
5898
5899         * remote.c (remote_target::download_tracepoint)
5900         (remote_target::enable_tracepoint)
5901         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
5902         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
5903         sprintf_vma.
5904
5905 2020-03-12  Tom Tromey  <tom@tromey.com>
5906
5907         * symfile-mem.c: Update CORE_ADDR size assert.
5908
5909 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5910
5911         * selftest.m4: Move to gdbsupport/.
5912         * acinclude.m4: Update path to selftest.m4.
5913
5914 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5915
5916         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
5917         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
5918         gdbarch-selfselftests.c and selftest-arch.c.
5919         (SUBDIR_UNITTESTS_OBS): Rename to...
5920         (SELFTESTS_OBS): ... this.
5921         (COMMON_SFILES): Remove disasm-selftests.c and
5922         gdbarch-selftests.c.
5923         * configure.ac: Don't add selftest-arch.{c,o} to
5924         CONFIG_{SRCS,OBS}.
5925         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
5926         preprocessor conditions.
5927
5928 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5929
5930         * configure.ac: Don't source bfd/development.sh.
5931         * selftest.m4: Modify comment.
5932         * configure: Re-generate.
5933
5934 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
5935
5936         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
5937         not "true" or "false".
5938         * configure: Re-generate.
5939
5940 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
5941
5942         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
5943         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
5944         renamed to arm_nbsd_supply_gregset.
5945         (fetch_register): Update to call arm_nbsd_supply_gregset.
5946         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
5947         (arm_netbsd_nat_target::fetch_registers): Update.
5948         (fetch_elfcore_registers): Removed.
5949         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
5950         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
5951         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
5952         not require NetBSD system headers.
5953         (arm_nbsd_regset): New struct.
5954         (arm_nbsd_iterate_over_regset_sections): New function.
5955         (arm_netbsd_init_abi_common): Updated to call
5956         set_gdbarch_iterate_over_regset_sections.
5957         * arm-nbsd-tdep.h: New file.
5958
5959 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
5960
5961         * symtab.c (find_pc_sect_line): Add check which prevents infinite
5962         recursion.
5963
5964 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
5965
5966         * configure: Re-generate.
5967
5968 2020-03-11  Tom Tromey  <tromey@adacore.com>
5969
5970         * ada-typeprint.c (print_choices): Fix comment.
5971
5972 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5973
5974         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
5975         previous item in the list, when the list has no items.
5976
5977 2020-03-11  Tom de Vries  <tdevries@suse.de>
5978
5979         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
5980         PROP_LOCLIST handling code.
5981
5982 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5983
5984         * buildsym-legacy.c (record_line): Pass extra parameter to
5985         record_line.
5986         * buildsym.c (buildsym_compunit::record_line): Take an extra
5987         parameter, reduce duplication in the line table, and record the
5988         is_stmt flag in the line table.
5989         * buildsym.h (buildsym_compunit::record_line): Add extra
5990         parameter.
5991         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
5992         non-statement lines.
5993         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
5994         this to the symtab builder.
5995         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
5996         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
5997         through to dwarf_record_line_1.
5998         * infrun.c (process_event_stop_test): When stepping, don't stop at
5999         a non-statement instruction, and only refresh the step info when
6000         we land in the middle of a line's range.  Also add an extra
6001         comment.
6002         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6003         field.
6004         * record-btrace.c (btrace_find_line_range): Only record lines
6005         marked as is-statement.
6006         * stack.c (frame_show_address): Show the frame address if we are
6007         in a non-statement sal.
6008         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6009         (maintenance_print_one_line_table): Print a header for the is_stmt
6010         column, and include is_stmt information in the output.
6011         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6012         preference to non-statements.
6013         (find_pcs_for_symtab_line): Prefer is-statement entries.
6014         (find_line_common): Likewise.
6015         * symtab.h (struct linetable_entry): Add is_stmt field.
6016         (struct symtab_and_line): Likewise.
6017         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6018         arranging the line table.
6019
6020 2020-03-07  Tom de Vries  <tdevries@suse.de>
6021
6022         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6023         DIE.
6024
6025 2020-03-07  Tom Tromey  <tom@tromey.com>
6026
6027         * valops.c (value_literal_complex): Remove obsolete comment.
6028         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6029         comment.
6030
6031 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6032
6033         * infrun.h: Forward-declare thread_info.
6034         (set_step_info): Add thread_info parameter, add doc.
6035         * infrun.c (set_step_info): Add thread_info parameter, move doc
6036         to header.
6037         * infrun.c (process_event_stop_test): Pass thread to
6038         set_step_info call.
6039         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
6040         set_step_info.
6041         (prepare_one_step): Add thread_info parameter, pass it to
6042         set_step_frame and prepare_one_step (recursive) call.
6043         (step_1): Pass thread to prepare_one_step call.
6044         (step_command_fsm::should_stop): Pass thread to
6045         prepare_one_step.
6046         (until_next_fsm): Pass thread to set_step_frame call.
6047         (finish_command): Pass thread to set_step_info call.
6048
6049 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6050
6051         * windows-tdep.c (windows_solib_create_inferior_hook):
6052         Check if inferior is running.
6053
6054 2020-03-06  Tom de Vries  <tdevries@suse.de>
6055
6056         * NEWS: Fix "the the".
6057         * ctfread.c: Same.
6058
6059 2020-03-06  Tom de Vries  <tdevries@suse.de>
6060
6061         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6062
6063 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6064
6065         * .dir-locals.el: Add a comment referencing the other copies of
6066         this file.
6067
6068 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6069
6070         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6071         psargs.
6072
6073 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6074
6075         * .gitattributes: New file.
6076
6077 2020-03-04  Tom Tromey  <tom@tromey.com>
6078
6079         * symmisc.c (print_symbol_bcache_statistics)
6080         (print_objfile_statistics): Update.
6081         * symfile.c (allocate_symtab): Use intern.
6082         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6083         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6084         macro_cache>: Remove.
6085         <string_cache>: New member.
6086         (struct objfile) <intern>: New methods.
6087         * elfread.c (elf_symtab_read): Use intern.
6088         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6089         (dwarf2_compute_name, dwarf2_physname)
6090         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6091         names.
6092         (guess_partial_die_structure_name): Update.
6093         (partial_die_info::fixup): Intern name.
6094         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6095         name.
6096         (dwarf2_name): Intern name.  Update.
6097         * buildsym.c (buildsym_compunit::get_macro_table): Use
6098         string_cache.
6099
6100 2020-03-04  Tom Tromey  <tom@tromey.com>
6101
6102         * jit.c (bfd_open_from_target_memory): Make "target" const.
6103         * corefile.c (gnutarget): Now const.
6104         * gdbcore.h (gnutarget): Now const.
6105
6106 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6107
6108         * NEWS: Mention support for WOW64 processes.
6109         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6110         (amd64_windows_segment_register_p): Remove static.
6111         (_initialize_amd64_windows_nat): Update.
6112         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6113         * i386-windows-nat.c (context_offset): Update.
6114         (i386_mappings): Rename and remove static.
6115         (i386_windows_segment_register_p): Remove static.
6116         (_initialize_i386_windows_nat): Update.
6117         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6118         (STATUS_WX86_SINGLE_STEP): New macro.
6119         (EnumProcessModulesEx): New macro.
6120         (Wow64SuspendThread): New macro.
6121         (Wow64GetThreadContext): New macro.
6122         (Wow64SetThreadContext): New macro.
6123         (Wow64GetThreadSelectorEntry): New macro.
6124         (windows_set_context_register_offsets): Add static.
6125         (windows_set_segment_register_p): Likewise.
6126         (windows_add_thread): Adapt for WOW64 processes.
6127         (windows_fetch_one_register): Likewise.
6128         (windows_nat_target::fetch_registers): Likewise.
6129         (windows_store_one_register): Likewise.
6130         (display_selector): Likewise.
6131         (display_selectors): Likewise.
6132         (handle_exception): Likewise.
6133         (windows_continue): Likewise.
6134         (windows_nat_target::resume): Likewise.
6135         (windows_add_all_dlls): Likewise.
6136         (do_initial_windows_stuff): Likewise.
6137         (windows_nat_target::attach): Likewise.
6138         (windows_get_exec_module_filename): Likewise.
6139         (windows_nat_target::create_inferior): Likewise.
6140         (windows_xfer_siginfo): Likewise.
6141         (_initialize_loadable): Initialize Wow64SuspendThread,
6142         Wow64GetThreadContext, Wow64SetThreadContext,
6143         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6144         * windows-nat.h (windows_set_context_register_offsets):
6145         Remove declaration.
6146         (windows_set_segment_register_p): Likewise.
6147         (i386_windows_segment_register_p): Add declaration.
6148         (amd64_windows_segment_register_p): Likewise.
6149
6150 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6151
6152         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6153         in "info registers" for AArch64/ARM.
6154
6155         The change caused "info registers" to not print GPR's.
6156
6157         gdb/ChangeLog:
6158
6159         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6160
6161         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6162         when reg->group is empty and reggroup is not.
6163
6164 2020-03-03  Tom Tromey  <tromey@adacore.com>
6165
6166         * dwarf2/frame.c (struct dwarf2_frame_cache)
6167         <checked_tailcall_bottom, entry_cfa_sp_offset,
6168         entry_cfa_sp_offset_p>: Remove members.
6169         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6170         (dwarf2_frame_prev_register): Don't call
6171         dwarf2_tailcall_sniffer_first.
6172         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6173         * frame-unwind.c (add_unwinder): New fuction.
6174         (frame_unwind_init): Use it.  Add tailcall unwinder.
6175
6176 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6177             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6178
6179         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6180         value should be printed as true.
6181
6182 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6183
6184         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6185         (windows_init_abi): Set and use windows_so_ops.
6186
6187 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6188
6189         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6190         when verifying if dealing with a convenience variable.
6191
6192 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6193
6194         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6195
6196 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6197
6198         * infrun.c (gdbarch_supports_displaced_stepping): New.
6199         (use_displaced_stepping): Break up conditions in smaller pieces.
6200         Use gdbarch_supports_displaced_stepping.
6201         (displaced_step_prepare_throw): Use
6202         gdbarch_supports_displaced_stepping.
6203
6204 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6205
6206         * NEWS: Mention new behaviour of the history filename.
6207         * top.c (write_history_p): Add comment.
6208         (show_write_history_p): Add header comment, give a different
6209         message when history writing is on, but the history filename is
6210         empty.
6211         (history_filename): Add comment.
6212         (history_filename_empty): New function.
6213         (show_history_filename): Add header comment, give a different
6214         message when the filename is empty.
6215         (init_history): Compare history_filename against nullptr, and only
6216         read history if the filename is not empty.
6217         (set_history_filename): Add header comment, and only make
6218         non-empty filenames absolute.
6219         (init_main): Make the filename argument to 'set history filename'
6220         optional.
6221
6222 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
6223
6224         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
6225         (arm_supply_vfpregset): ...this, and update to use VFP registers.
6226         (fetch_fp_register): Update.
6227         (fetch_fp_regs): Update.
6228         (store_fp_register): Update.
6229         (store_fp_regs): Update.
6230         (arm_netbsd_nat_target::read_description): New function.
6231         (fetch_elfcore_registers): Update.
6232
6233 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6234
6235         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
6236         general_thread if the stop reply is missing a thread-id.
6237         (remote_target::process_stop_reply): Use the first non-exited
6238         thread if the target didn't pass a thread-id.
6239         * infrun.c (do_target_wait): Move call to
6240         switch_to_inferior_no_thread to ....
6241         (do_target_wait_1): ... here.
6242
6243 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
6244
6245         * debuginfod-support.c: Include defs.h first.
6246
6247 2020-02-28  Tom de Vries  <tdevries@suse.de>
6248
6249         * symfile.c (set_initial_language): Use default language for lookup.
6250
6251 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
6252
6253         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
6254         reader variable, pass `this` to read_cutu_die_from_dwo.
6255
6256 2020-02-27  Aaron Merey  <amerey@redhat.com>
6257
6258         * source.c (open_source_file): Check for nullptr when computing
6259         srcpath.
6260
6261 2020-02-27  Tom Tromey  <tromey@adacore.com>
6262
6263         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
6264         member.
6265         (dwarf2_add_field): Don't update nfields.
6266         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
6267
6268 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
6271         abs.
6272
6273 2020-02-26  Tom Tromey  <tom@tromey.com>
6274
6275         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
6276         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
6277         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
6278         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
6279         per_cu_data.
6280
6281 2020-02-26  Tom Tromey  <tom@tromey.com>
6282
6283         * dwarf2/index-write.c (psym_index_map): Change type.
6284         (add_address_entry_worker, write_one_signatured_type)
6285         (recursively_count_psymbols, recursively_write_psymbols)
6286         (class debug_names, psyms_seen_size, write_gdbindex)
6287         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
6288
6289 2020-02-26  Aaron Merey  <amerey@redhat.com>
6290
6291         * Makefile.in: Handle optional debuginfod support.
6292         * NEWS: Update.
6293         * README: Add --with-debuginfod summary.
6294         * config.in: Regenerate.
6295         * configure: Regenerate.
6296         * configure.ac: Handle optional debuginfod support.
6297         * debuginfod-support.c: debuginfod helper functions.
6298         * debuginfod-support.h: Ditto.
6299         * doc/gdb.texinfo: Add --with-debuginfod to configure options
6300         summary.
6301         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
6302         when a dwz file cannot be found.
6303         * elfread.c (elf_symfile_read): Query debuginfod servers when a
6304         debuginfo file cannot be found.
6305         * source.c (open_source_file): Query debuginfod servers when a
6306         source file cannot be found.
6307         * top.c (print_gdb_configuration): Include
6308         --{with,without}-debuginfod in the output.
6309
6310 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
6311
6312         * thread.c (thr_try_catch_cmd): Print thread name.
6313
6314 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
6315
6316         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
6317         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6318         dwarf2_fetch_die_type_sect_off): Move to...
6319         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
6320         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6321         dwarf2_fetch_die_type_sect_off): ... here.
6322         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
6323         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6324         dwarf2_fetch_die_type_sect_off): Move doc to header file.
6325
6326 2020-02-26  Tom de Vries  <tdevries@suse.de>
6327
6328         PR gdb/25603
6329         * symfile.c (set_initial_language): Exit-early if
6330         language_mode == language_mode_manual.
6331
6332 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6333
6334         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
6335         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
6336         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
6337
6338 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6339
6340         * gdbtypes.c (create_array_type_with_stride): Handle negative
6341         array strides.
6342         * valarith.c (value_subscripted_rvalue): Likewise.
6343
6344 2020-02-25  Luis Machado  <luis.machado@linaro.org>
6345
6346         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
6347
6348 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6349
6350         * loc.h (dwarf2_get_die_type): Move to...
6351         * read.h (dwarf2_get_die_type): ... here.
6352         * read.c (dwarf2_get_die_type): Move doc to header.
6353
6354 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
6355
6356         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
6357         'gnulib/Makefile.in' to the list.
6358
6359 2020-02-24  Tom Tromey  <tom@tromey.com>
6360
6361         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
6362         Remove.
6363         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
6364         XOBNEWVEC.
6365
6366 2020-02-24  Tom Tromey  <tom@tromey.com>
6367
6368         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
6369         New method.
6370         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
6371         (dw2_do_instantiate_symtab, dw2_get_file_names)
6372         (build_type_psymtab_dependencies, load_full_type_unit): Update.
6373
6374 2020-02-24  Tom Tromey  <tom@tromey.com>
6375
6376         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
6377         make_scoped_restore.
6378         (dwarf2_psymtab::read_symtab): Don't clear
6379         reading_partial_symbols.
6380
6381 2020-02-24  Tom de Vries  <tdevries@suse.de>
6382
6383         PR gdb/25592
6384         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
6385
6386 2020-02-24  Tom de Vries  <tdevries@suse.de>
6387
6388         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
6389         commands layout next/prev/regs.
6390
6391 2020-02-22  Tom Tromey  <tom@tromey.com>
6392
6393         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
6394         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
6395
6396 2020-02-22  Tom Tromey  <tom@tromey.com>
6397
6398         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
6399
6400 2020-02-22  Tom Tromey  <tom@tromey.com>
6401
6402         * tui/tui-win.c (_initialize_tui_win): Add usage text.
6403         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
6404         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
6405         * tui/tui.c (_initialize_tui): Add usage text.
6406
6407 2020-02-22  Tom Tromey  <tom@tromey.com>
6408
6409         * tui/tui-win.c (tui_set_focus_command)
6410         (tui_set_win_height_command): Use error_no_arg.
6411         (_initialize_tui_win): Update help text.
6412         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
6413
6414 2020-02-22  Tom Tromey  <tom@tromey.com>
6415
6416         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
6417         * tui/tui-disasm.h (struct tui_disasm_window)
6418         <display_start_addr>: Declare.
6419         * tui/tui-source.h (struct tui_source_window)
6420         <display_start_addr>: Declare.
6421         * tui/tui-winsource.h (struct tui_source_window_base)
6422         <show_source_line, display_start_addr>: New methods.
6423         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
6424         Rename and move to protected section.
6425         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
6426         (tui_source_window_base::do_erase_source_content): Update.
6427         (tui_source_window_base::show_source_line): Now a method.
6428         (tui_source_window_base::show_source_content)
6429         (tui_source_window_base::tui_source_window_base)
6430         (tui_source_window_base::rerender)
6431         (tui_source_window_base::refill)
6432         (tui_source_window_base::do_scroll_horizontal)
6433         (tui_source_window_base::set_is_exec_point_at)
6434         (tui_source_window_base::update_breakpoint_info)
6435         (tui_source_window_base::update_exec_info): Update.
6436         * tui/tui-source.c (tui_source_window::set_contents)
6437         (tui_source_window::showing_source_p)
6438         (tui_source_window::do_scroll_vertical)
6439         (tui_source_window::location_matches_p)
6440         (tui_source_window::line_is_displayed): Update.
6441         (tui_source_window::display_start_addr): New method.
6442         * tui/tui-disasm.c (tui_disasm_window::set_contents)
6443         (tui_disasm_window::do_scroll_vertical)
6444         (tui_disasm_window::location_matches_p): Update.
6445         (tui_disasm_window::display_start_addr): New method.
6446
6447 2020-02-22  Tom Tromey  <tom@tromey.com>
6448
6449         * NEWS: Add entry for gdb.register_window_type.
6450         * tui/tui-layout.h (window_factory): New typedef.
6451         (tui_register_window): Declare.
6452         * tui/tui-layout.c (saved_tui_windows): New global.
6453         (tui_apply_current_layout): Use it.
6454         (tui_register_window): New function.
6455         * python/python.c (do_start_initialization): Call
6456         gdbpy_initialize_tui.
6457         (python_GdbMethods): Add "register_window_type" function.
6458         * python/python-internal.h (gdbpy_register_tui_window)
6459         (gdbpy_initialize_tui): Declare.
6460         * python/py-tui.c: New file.
6461         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
6462
6463 2020-02-22  Tom Tromey  <tom@tromey.com>
6464
6465         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
6466
6467 2020-02-22  Tom Tromey  <tom@tromey.com>
6468
6469         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
6470         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
6471         * tui/tui-data.c (tui_set_win_with_focus): Remove.
6472         (tui_set_win_focus_to): Move from tui-win.c.
6473
6474 2020-02-22  Tom Tromey  <tom@tromey.com>
6475
6476         * tui/tui-layout.c (make_standard_window, get_locator_window): New
6477         functions.
6478         (known_window_types): New global.
6479         (tui_get_window_by_name): Reimplement.
6480         (initialize_known_windows): New function.
6481         (validate_window_name): Rewrite.
6482         (_initialize_tui_layout): Call initialize_known_windows.
6483
6484 2020-02-22  Tom Tromey  <tom@tromey.com>
6485
6486         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
6487         Remove constants.
6488         * tui/tui-winsource.h (struct tui_source_window_base)
6489         <tui_source_window_base>: Remove parameter.
6490         * tui/tui-winsource.c
6491         (tui_source_window_base::tui_source_window_base): Remove
6492         parameter.
6493         (tui_source_window_base::refill): Update.
6494         * tui/tui-stack.h (struct tui_locator_window)
6495         <tui_locator_window>: Update.
6496         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
6497         Default the constructor.
6498         * tui/tui-regs.h (struct tui_data_item_window)
6499         <tui_data_item_window>: Default the constructor.
6500         (struct tui_data_window) <tui_data_window>: Likewise.
6501         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
6502         Default the constructor.
6503         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
6504         Default the constructor.
6505         <type>: Remove.
6506         (struct tui_win_info) <tui_win_info>: Default the constructor.
6507         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
6508         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
6509         Default the constructor.
6510
6511 2020-02-22  Tom Tromey  <tom@tromey.com>
6512
6513         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
6514         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
6515         * tui/tui-win.c (tui_resize_all): Don't call
6516         tui_delete_invisible_windows.
6517         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
6518         done.
6519         (tui_set_layout): Update.
6520         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
6521         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
6522         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
6523
6524 2020-02-22  Tom Tromey  <tom@tromey.com>
6525
6526         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
6527         correctly.
6528
6529 2020-02-22  Tom Tromey  <tom@tromey.com>
6530
6531         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
6532
6533 2020-02-22  Tom Tromey  <tom@tromey.com>
6534
6535         * tui/tui-winsource.h (struct tui_source_window_iterator)
6536         <inner_iterator>: New etytypedef.
6537         <tui_source_window_iterator>: Take "end" parameter.
6538         <tui_source_window_iterator>: Take iterator.
6539         <operator*, advance>: Update.
6540         <m_iter>: Change type.
6541         <m_end>: New field.
6542         (struct tui_source_windows) <begin, end>: Update.
6543         * tui/tui-layout.c (tui_windows): New global.
6544         (tui_apply_current_layout): Clear tui_windows.
6545         (tui_layout_window::apply): Update tui_windows.
6546         * tui/tui-data.h (tui_windows): Declare.
6547         (all_tui_windows): Now inline function.
6548         (class tui_window_iterator, struct all_tui_windows): Remove.
6549
6550 2020-02-22  Tom Tromey  <tom@tromey.com>
6551
6552         PR tui/17850:
6553         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
6554         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
6555         "height" argument.
6556         (class tui_layout_window) <get_sizes>: Likewise.
6557         (class tui_layout_split) <tui_layout_split>: Add "vertical"
6558         argument.
6559         <get_sizes>: Add "height" argument.
6560         <m_vertical>: New field.
6561         * tui/tui-layout.c (tui_layout_split::clone): Update.
6562         (tui_layout_split::get_sizes): Add "height" argument.
6563         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
6564         (tui_new_layout_command): Parse "-horizontal".
6565         (_initialize_tui_layout): Update help string.
6566         (tui_layout_split::specification): Add "-horizontal" when needed.
6567         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
6568         argument.
6569         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
6570         New methods.
6571
6572 2020-02-22  Tom Tromey  <tom@tromey.com>
6573
6574         * tui/tui-layout.h (enum tui_adjust_result): New.
6575         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
6576         (class tui_layout_window) <adjust_size>: Return
6577         tui_adjust_result.  Rewrite.
6578         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
6579         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
6580
6581 2020-02-22  Tom Tromey  <tom@tromey.com>
6582
6583         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
6584         parameter and return types.
6585         (class tui_layout_base) <specification>: Add "depth".
6586         (class tui_layout_window) <specification>: Add "depth".
6587         (class tui_layout_split) <specification>: Add "depth".
6588         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
6589         and return types.
6590         (tui_new_layout_command): Parse sub-layouts.
6591         (_initialize_tui_layout): Update help string.
6592         (tui_layout_window::specification): Add "depth".
6593         (add_layout_command): Update.
6594
6595 2020-02-22  Tom Tromey  <tom@tromey.com>
6596
6597         * NEWS: Add "tui new-layout" item.
6598         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
6599         Add new-layout command to help text.
6600         (validate_window_name): New function.
6601         (tui_new_layout_command): New function.
6602         (_initialize_tui_layout): Register "new-layout".
6603         (tui_layout_window::specification): New method.
6604         (tui_layout_window::specification): New method.
6605         * tui/tui-layout.h (class tui_layout_base) <specification>: New
6606         method.
6607         (class tui_layout_window) <specification>: New method.
6608         (class tui_layout_split) <specification>: New method.
6609
6610 2020-02-22  Tom Tromey  <tom@tromey.com>
6611
6612         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
6613         * tui/tui-win.c (window_name_completer): Update comment.
6614         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
6615         Declare method.
6616         (class tui_layout_window) <replace_window>: Likewise.
6617         (class tui_layout_split) <replace_window>: Likewise.
6618         (tui_set_layout): Don't declare.
6619         (tui_set_initial_layout): Declare function.
6620         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
6621         (asm_regs_layout): New globals.
6622         (tui_current_layout, show_layout): Remove.
6623         (tui_set_layout, tui_add_win_to_layout): Rewrite.
6624         (find_layout, tui_apply_layout): New function.
6625         (layout_completer): Remove.
6626         (tui_next_layout): Reimplement.
6627         (tui_next_layout_command): New function.
6628         (tui_set_initial_layout, tui_prev_layout_command): New functions.
6629         (tui_regs_layout): Reimplement.
6630         (tui_regs_layout_command): New function.
6631         (extract_display_start_addr): Rewrite.
6632         (next_layout, prev_layout): Remove.
6633         (tui_layout_window::replace_window): New method.
6634         (tui_layout_split::replace_window): New method.
6635         (destroy_layout): New function.
6636         (layout_list): New global.
6637         (add_layout_command): New function.
6638         (initialize_layouts): Update.
6639         (tui_layout_command): New function.
6640         (_initialize_tui_layout): Install "layout" commands.
6641         * tui/tui-data.h (enum tui_layout_type): Remove.
6642         (tui_current_layout): Don't declare.
6643
6644 2020-02-22  Tom Tromey  <tom@tromey.com>
6645
6646         * tui/tui-regs.c (tui_reg_layout): Remove.
6647         (tui_reg_command): Use tui_regs_layout.
6648         * tui/tui-layout.h (tui_reg_command): Declare.
6649         * tui/tui-layout.c (tui_reg_command): New function.
6650
6651 2020-02-22  Tom Tromey  <tom@tromey.com>
6652
6653         * tui/tui.c (tui_rl_delete_other_windows): Call
6654         tui_remove_some_windows.
6655         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
6656         Declare method.
6657         (class tui_layout_window) <remove_windows>: New method.
6658         (class tui_layout_split) <remove_windows>: Declare.
6659         (tui_remove_some_windows): Declare.
6660         * tui/tui-layout.c (tui_remove_some_windows): New function.
6661         (tui_layout_split::remove_windows): New method.
6662
6663 2020-02-22  Tom Tromey  <tom@tromey.com>
6664
6665         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
6666         * tui/tui-layout.h (tui_next_layout): Declare.
6667         * tui/tui-layout.c (tui_next_layout): New function.
6668
6669 2020-02-22  Tom Tromey  <tom@tromey.com>
6670
6671         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
6672         correct coordinates.
6673
6674 2020-02-22  Tom Tromey  <tom@tromey.com>
6675
6676         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
6677         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
6678         DATA_WIN case.
6679
6680 2020-02-22  Tom Tromey  <tom@tromey.com>
6681
6682         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
6683         TUI_DISASM_WIN, not tui_win_list.
6684
6685 2020-02-22  Tom Tromey  <tom@tromey.com>
6686
6687         * valprint.c (generic_val_print_enum_1)
6688         (val_print_type_code_flags): Style member names.
6689         * rust-lang.c (val_print_struct, rust_print_enum)
6690         (rust_print_struct_def, rust_internal_print_type): Style member
6691         names.
6692         * p-valprint.c (pascal_object_print_value_fields): Style member
6693         names.  Only call fprintf_symbol_filtered for static members.
6694         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
6695         * f-valprint.c (f_val_print): Style member names.
6696         * f-typeprint.c (f_type_print_base): Style member names.
6697         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
6698         call fprintf_symbol_filtered for static members.
6699         (cp_print_class_member): Style member names.
6700         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
6701         member names.
6702         * ada-valprint.c (ada_print_scalar): Style enum names.
6703         (ada_val_print_enum): Likewise.
6704         * ada-typeprint.c (print_enum_type): Style enum names.
6705
6706 2020-02-21  Tom Tromey  <tom@tromey.com>
6707
6708         * psympriv.h (struct partial_symtab): Update comment.
6709
6710 2020-02-21  Tom Tromey  <tromey@adacore.com>
6711
6712         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
6713         type is CORE_ADDR.
6714
6715 2020-02-21  Tom de Vries  <tdevries@suse.de>
6716
6717         PR gdb/25534
6718         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
6719         if dependencies[i]->user != NULL.
6720
6721 2020-02-21  Ali Tamur  <tamur@google.com>
6722
6723         * dwarf2/read.c (dwarf2_name): Add null check.
6724
6725 2020-02-20  Tom Tromey  <tom@tromey.com>
6726
6727         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
6728         ">=", in binary search.
6729         (dwarf2_find_containing_comp_unit): New overload.
6730         (run_test): New self-test.
6731         (_initialize_dwarf2_read): Register new test.
6732
6733 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
6734
6735         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
6736         * riscv-tdep.h: Likewise.
6737         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
6738         rv32-only CSR.
6739         * features/riscv/64bit-csr.xml: Regenerated.
6740
6741 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
6742             Tom Tromey  <tom@tromey.com>
6743
6744         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
6745         of 'fputc_unfiltered'.
6746         (putchar_unfiltered): Call 'fputc_unfiltered'.
6747         (fputc_unfiltered): Call 'fputs_unfiltered'.
6748
6749 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * config.in: Regenerate.
6752         * configure: Regenerate.
6753         * configure.ac: Add --with-python-libdir option.
6754         * main.c: Use WITH_PYTHON_LIBDIR.
6755
6756 2020-02-19  Tom Tromey  <tom@tromey.com>
6757
6758         * symtab.c (general_symbol_info::compute_and_set_names): Use
6759         obstack_strndup.  Simplify call to symbol_set_demangled_name.
6760
6761 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
6762
6763         * dwarf2/read.c (allocate_signatured_type_table,
6764         allocate_dwo_unit_table, allocate_type_unit_groups_table,
6765         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
6766         Remove objfile parameter, update all callers.
6767
6768 2020-02-19  Doug Evans  <dje@google.com>
6769
6770         PR rust/25535
6771         * rust-lang.c (rust_print_enum): Apply embedded_offset to
6772         rust_enum_variant calculation.
6773
6774 2020-02-19  Tom Tromey  <tromey@adacore.com>
6775
6776         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
6777
6778 2020-02-19  Tom Tromey  <tromey@adacore.com>
6779
6780         * ada-lang.c (cache_symbol): Use obstack_strdup.
6781
6782 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6783
6784         * configure: Regenerate.
6785
6786 2020-02-19  Tom Tromey  <tromey@adacore.com>
6787
6788         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
6789         NULL check.
6790
6791 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
6792
6793         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
6794
6795 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6796
6797         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
6798         if GDBSERVER is not defined.
6799         (riscv_tdesc_cache): Likewise, also store const target_desc.
6800         (STATIC_IN_GDB): Define.
6801         (riscv_create_target_description): Update declaration with
6802         STATIC_IN_GDB.
6803         (riscv_lookup_target_description): New function, only define if
6804         GDBSERVER is not defined.
6805         * arch/riscv.h (riscv_create_target_description): Declare only
6806         when GDBSERVER is defined.
6807         (riscv_lookup_target_description): New declaration when GDBSERVER
6808         is not defined.
6809         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
6810         (riscv_linux_read_features): ...this, and return
6811         riscv_gdbarch_features instead of target_desc.
6812         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
6813         (riscv_linux_read_description): Rename to...
6814         (riscv_linux_read_features): ...this.
6815         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
6816         Update to use riscv_gdbarch_features and
6817         riscv_lookup_target_description.
6818         * riscv-tdep.c (riscv_find_default_target_description): Use
6819         riscv_lookup_target_description instead of
6820         riscv_create_target_description.
6821
6822 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6823
6824         * valprint.c (generic_val_print_enum_1): When printing a flag
6825         enum with value 0 and there is no enumerator with value 0, print
6826         just "0" instead of "(unknown: 0x0)".
6827
6828 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6829
6830         * valprint.c (generic_val_print_enum_1): Print unknown part of
6831         flag enum in hex.
6832
6833 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6834
6835         * dwarf2/read.c (update_enumeration_type_from_children): Allow
6836         flag enums to contain duplicate enumerators.
6837         * valprint.c (generic_val_print_enum_1): Update comment.
6838
6839 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6840
6841         * dwarf2/read.c: Include "count-one-bits.h".
6842         (update_enumeration_type_from_children): If an enumerator has
6843         multiple bits set, don't treat the enumeration as a "flag enum".
6844         * valprint.c (generic_val_print_enum_1): Assert that enumerators
6845         of flag enums have 0 or 1 bit set.
6846
6847 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6848
6849         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
6850         conversion.
6851         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6852         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6853         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6854         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6855         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6856
6857 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
6858
6859         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
6860
6861 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6862
6863         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
6864         displaced_step_closure_up.
6865         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6866         (struct displaced_step_closure_up):
6867         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6868         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6869         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
6870         Likewise.
6871         * gdbarch.sh (displaced_step_copy_insn): Likewise.
6872         * gdbarch.c, gdbarch.h: Re-generate.
6873         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
6874         displaced_step_closure_up.
6875         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6876         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6877         * infrun.h (displaced_step_closure_up): New type alias.
6878         (struct displaced_step_inferior_state) <step_closure>: Change
6879         type to displaced_step_closure_up.
6880         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
6881         displaced_step_closure_up.
6882         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6883
6884 2020-02-14  Tom Tromey  <tom@tromey.com>
6885
6886         * minidebug.c (gnu_debug_key): New global.
6887         (find_separate_debug_file_in_section): Use it.
6888
6889 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6890
6891         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
6892         std::unique_ptr.
6893         * gdbarch.c: Re-generate.
6894         * gdbarch.h: Re-generate.
6895         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
6896         change.
6897         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
6898         type to std::unique_ptr.
6899         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
6900         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
6901         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
6902         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
6903         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
6904         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
6905         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
6906         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
6907         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
6908
6909 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6910
6911         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
6912         std::unique_ptr.
6913         (displaced_step_clear): Rename to...
6914         (displaced_step_reset): ... this.  Just call displaced->reset ().
6915         (displaced_step_clear_cleanup): Rename to...
6916         (displaced_step_reset_cleanup): ... this.
6917         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
6918         (displaced_step_fixup): Likewise.
6919         (resume_1): Likewise.
6920         (handle_inferior_event): Restore child's memory before calling
6921         displaced_step_fixup on the parent.
6922         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
6923         to std::unique_ptr.
6924         <step_closure>: Change type to std::unique_ptr.
6925
6926 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
6927
6928         * arm-tdep.c: Include count-one-bits.h.
6929         (cleanup_block_store_pc): Use count_one_bits.
6930         (cleanup_block_load_pc): Use count_one_bits.
6931         (arm_copy_block_xfer): Use count_one_bits.
6932         (thumb2_copy_block_xfer): Use count_one_bits.
6933         (thumb_copy_pop_pc_16bit): Use count_one_bits.
6934         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
6935         (thumb_get_next_pcs_raw): Use count_one_bits.
6936         (arm_get_next_pcs_raw): Use count_one_bits_l.
6937         * arch/arm.c (bitcount): Remove.
6938         * arch/arm.h (bitcount): Remove.
6939
6940 2020-02-14  Tom Tromey  <tromey@adacore.com>
6941
6942         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
6943         Update.
6944         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
6945         * dwarf2/loc.c (call_site_find_chain_1): Return
6946         unique_xmalloc_ptr.
6947         (call_site_find_chain): Likewise.
6948
6949 2020-02-14  Richard Biener  <rguenther@suse.de>
6950
6951         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
6952         on expression with division operators.
6953
6954 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6955
6956         * MAINTAINERS (Write After Approval): Adding myself.
6957
6958 2020-02-12  Tom Tromey  <tom@tromey.com>
6959
6960         * event-loop.c (event_data, gdb_event, event_handler_func):
6961         Remove.
6962
6963 2020-02-12  Tom Tromey  <tom@tromey.com>
6964
6965         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
6966         (dwarf2_frame_objfile_data): Add comment.
6967         (find_comp_unit, set_comp_unit): New functions.
6968         (dwarf2_frame_find_fde): Use find_comp_unit.
6969         (dwarf2_build_frame_info): Use set_comp_unit.
6970
6971 2020-02-12  Tom Tromey  <tom@tromey.com>
6972
6973         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
6974         (comp_unit): Don't initialize objfile.
6975         (execute_cfa_program): Add text_offset parameter.
6976         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
6977         (dwarf2_frame_cache): Update.
6978         (dwarf2_build_frame_info): Don't set "objfile" member.
6979
6980 2020-02-12  Tom Tromey  <tom@tromey.com>
6981
6982         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
6983         (decode_frame_entry): Likewise.
6984         (dwarf2_build_frame_info): Update.
6985
6986 2020-02-12  Tom Tromey  <tom@tromey.com>
6987
6988         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
6989         (decode_frame_entry_1): Use the comp_unit obstack.
6990
6991 2020-02-12  Tom Tromey  <tom@tromey.com>
6992
6993         * dwarf2/frame.c (struct comp_unit): Add initializers and
6994         constructor.
6995         (dwarf2_frame_objfile_data): Store a comp_unit.
6996         (dwarf2_frame_find_fde): Update.
6997         (dwarf2_build_frame_info): Use "new".
6998
6999 2020-02-12  Tom Tromey  <tom@tromey.com>
7000
7001         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7002         (dwarf2_fde_table): Typedef for std::vector.
7003         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7004         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7005         (decode_frame_entry): Update.
7006         (dwarf2_build_frame_info): Use "new".
7007
7008 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7009
7010         * arm-tdep.c (arm_gdbarch_init): Update.
7011         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7012         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7013         have_neon, is_m>: Change to bool.
7014
7015 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7016
7017         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7018
7019 2020-02-12  Tom Tromey  <tom@tromey.com>
7020
7021         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7022
7023 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7024
7025         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7026         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7027
7028 2020-02-11  Tom Tromey  <tom@tromey.com>
7029
7030         * psymtab.h: Update comment.
7031
7032 2020-02-11  Tom Tromey  <tom@tromey.com>
7033
7034         * gdb_obstack.h (struct auto_obstack): Use
7035         DISABLE_COPY_AND_ASSIGN.
7036
7037 2020-02-11  Tom Tromey  <tom@tromey.com>
7038
7039         * dwarf2/frame.h (struct objfile): Don't forward declare.
7040
7041 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7042
7043         * cris-tdep.c (cris_supply_gregset): Change signature to match
7044         what struct regset expects.
7045         (cris_regset): New struct.
7046         (fetch_core_registers): Remove.
7047         (cris_iterate_over_regset_sections): New function.
7048         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7049         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7050
7051 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7052
7053         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7054         registers.
7055
7056 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7057
7058         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7059
7060 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7061
7062         * configure: Re-generate.
7063
7064 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7065
7066         * configure: Re-generate.
7067
7068 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7069
7070         * acinclude: Update warning.m4 path.
7071         * warning.m4: Move to gdbsupport.
7072
7073 2020-02-11  Tom Tromey  <tromey@adacore.com>
7074
7075         * remote.c (remote_console_output): Update.
7076         * printcmd.c (printf_command): Update.
7077         * event-loop.c (gdb_wait_for_event): Update.
7078         * linux-nat.c (sigchld_handler): Update.
7079         * remote-sim.c (gdb_os_write_stdout): Update.
7080         (gdb_os_flush_stdout): Update.
7081         (gdb_os_flush_stderr): Update.
7082         (gdb_os_write_stderr): Update.
7083         * exceptions.c (print_exception): Update.
7084         * remote-fileio.c (remote_fileio_func_read): Update.
7085         (remote_fileio_func_write): Update.
7086         * tui/tui.c (tui_enable): Update.
7087         * tui/tui-interp.c (tui_interp::init): Update.
7088         * utils.c (init_page_info): Update.
7089         (putchar_unfiltered, fputc_unfiltered): Update.
7090         (gdb_flush): Update.
7091         (emit_style_escape): Update.
7092         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7093         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7094         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7095         (stderr_file::write): Update.
7096         (stderr_file::puts): Update.
7097         * ui-file.h (ui_file_isatty, ui_file_write)
7098         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7099         (ui_file_puts): Don't declare.
7100
7101 2020-02-10  Tom de Vries  <tdevries@suse.de>
7102
7103         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7104         sentinel to char *.
7105
7106 2020-02-09  Tom de Vries  <tdevries@suse.de>
7107
7108         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7109         filename if it matches "<artificial>".
7110
7111 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7112
7113         * windows-tdep.c (struct enum_value_name): New struct.
7114         (create_enum): New function.
7115         (windows_get_siginfo_type): Create and use enum types.
7116
7117 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7118
7119         * NEWS: Mention $_siginfo support for Windows.
7120         * windows-nat.c (handle_exception): Set siginfo_er.
7121         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7122         (windows_xfer_siginfo): New function.
7123         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7124         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7125         (init_windows_gdbarch_data): New function.
7126         (get_windows_gdbarch_data): New function.
7127         (windows_get_siginfo_type): New function.
7128         (windows_init_abi): Register windows_get_siginfo_type.
7129         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7130
7131 2020-02-08  Tom Tromey  <tom@tromey.com>
7132
7133         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7134         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7135         <keep>: Declare method.
7136         <m_keep>: Remove member.
7137         <~cutu_reader>: Remove.
7138         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7139         (cutu_reader::cutu_reader): Update.
7140         (cutu_reader::keep): Rename from ~cutu_reader.
7141         (process_psymtab_comp_unit, build_type_psymtabs_1)
7142         (process_skeletonless_type_unit, load_partial_comp_unit)
7143         (load_full_comp_unit, dwarf2_read_addr_index)
7144         (read_signatured_type): Update.
7145
7146 2020-02-08  Tom Tromey  <tom@tromey.com>
7147
7148         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7149         "want_partial_unit" parameter.
7150         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7151         Inline check for DW_TAG_partial_unit.
7152         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7153
7154 2020-02-08  Tom Tromey  <tom@tromey.com>
7155
7156         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7157         read.c.
7158         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7159         read.c.
7160
7161 2020-02-08  Tom Tromey  <tom@tromey.com>
7162
7163         * dwarf2/read.c (read_address): Move to comp-unit.c.
7164         (dwarf2_rnglists_process, dwarf2_ranges_process)
7165         (read_attribute_value, dwarf_decode_lines_1)
7166         (var_decode_location, decode_locdesc): Update.
7167         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7168         read.c.  Remove "cu" parameter.
7169         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7170         method.
7171
7172 2020-02-08  Tom Tromey  <tom@tromey.com>
7173
7174         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7175         (read_indirect_line_string): Update.
7176         * dwarf2/comp-unit.c (read_offset): Remove.
7177         (read_comp_unit_head): Update.
7178         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7179         method.
7180         (read_offset): Don't declare.
7181
7182 2020-02-08  Tom Tromey  <tom@tromey.com>
7183
7184         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7185         * dwarf2/read.c (struct comp_unit_head): Move to
7186         dwarf2/comp-unit.h.
7187         (enum class rcuh_kind): Move to comp-unit.h.
7188         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7189         (read_comp_unit_head, error_check_comp_unit_head)
7190         (read_and_check_comp_unit_head): Move to comp-unit.c.
7191         (read_offset, dwarf_unit_type_name): Likewise.
7192         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7193         (cutu_reader::cutu_reader, read_call_site_scope)
7194         (find_partial_die, follow_die_offset): Update.
7195         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7196
7197 2020-02-08  Tom Tromey  <tom@tromey.com>
7198
7199         * dwarf2/read.c (read_offset_1): Move to leb.c.
7200         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7201         (dwarf_decode_macro_bytes): Update.
7202         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7203         * dwarf2/leb.h (read_offset): Declare.
7204
7205 2020-02-08  Tom Tromey  <tom@tromey.com>
7206
7207         * dwarf2/read.c (dwarf2_section_size): Remove.
7208         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7209         Update.
7210         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7211
7212 2020-02-08  Tom Tromey  <tom@tromey.com>
7213
7214         * dwarf2/read.c (read_initial_length): Move to leb.c.
7215         * dwarf2/leb.h (read_initial_length): Declare.
7216         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7217         handle_nonstd parameter.
7218         * dwarf2/frame.c (read_initial_length): Remove.
7219         (decode_frame_entry_1): Update.
7220
7221 2020-02-08  Tom Tromey  <tom@tromey.com>
7222
7223         * dwarf2/loc.c (dwarf2_find_location_expression)
7224         (dwarf_evaluate_loc_desc::get_tls_address)
7225         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
7226         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
7227         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
7228         (dwarf2_compile_property_to_c)
7229         (dwarf2_loc_desc_get_symbol_read_needs)
7230         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
7231         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
7232         (loclist_describe_location, loclist_tracepoint_var_ref)
7233         (loclist_generate_c_location): Update.
7234         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
7235         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
7236         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
7237         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
7238         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
7239         (dwarf2_per_cu_data::addr_size)
7240         (dwarf2_per_cu_data::ref_addr_size)
7241         (dwarf2_per_cu_data::text_offset)
7242         (dwarf2_per_cu_data::addr_type): Now methods.
7243         (per_cu_header_read_in): Make per_cu "const".
7244         (dwarf2_version): Remove.
7245         (dwarf2_per_cu_data::int_type): Now a method.
7246         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
7247         (set_die_type, read_array_type, read_subrange_index_type)
7248         (read_tag_string_type, read_subrange_type): Update.
7249         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
7250         offset_size, ref_addr_size, text_offset, addr_type, version,
7251         objfile, int_type, addr_sized_int_type>: Declare methods.
7252
7253 2020-02-08  Tom Tromey  <tom@tromey.com>
7254
7255         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
7256         Move earlier.
7257
7258 2020-02-08  Tom Tromey  <tom@tromey.com>
7259
7260         * dwarf2/read.h (dwarf_line_debug): Declare.
7261         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
7262         * dwarf2/read.c: Move line_header code to new files.
7263         (dwarf_line_debug): No longer static.
7264         * dwarf2/line-header.c: New file.
7265         * dwarf2/line-header.h: New file.
7266
7267 2020-02-08  Tom Tromey  <tom@tromey.com>
7268
7269         * dwarf2/read.c (struct line_header) <file_full_name,
7270         file_file_name>: Return unique_xmalloc_ptr.
7271         (line_header::file_file_name): Update.
7272         (line_header::file_full_name): Update.
7273         (dw2_get_file_names_reader): Update.
7274         (macro_start_file): Update.
7275
7276 2020-02-08  Tom Tromey  <tom@tromey.com>
7277
7278         * dwarf2/read.c (struct line_header) <file_full_name,
7279         file_file_name>: Declare methods.
7280         (dw2_get_file_names_reader): Update.
7281         (file_file_name): Now a method.
7282         (file_full_name): Likewise.
7283         (macro_start_file): Update.
7284
7285 2020-02-08  Tom Tromey  <tom@tromey.com>
7286
7287         * dwarf2/read.c (dwarf_always_disassemble)
7288         (show_dwarf_always_disassemble): Move to loc.c.
7289         (_initialize_dwarf2_read): Move "always-disassemble" registration
7290         to loc.c.
7291         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
7292         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
7293         static.
7294         (show_dwarf_always_disassemble): Move from read.c.
7295         (_initialize_dwarf2loc): Move always-disassemble from read.c.
7296
7297 2020-02-08  Tom Tromey  <tom@tromey.com>
7298
7299         * dwarf2/read.c (~dwarf2_per_objfile): Update.
7300         (create_quick_file_names_table): Return htab_up.
7301         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
7302         Update.
7303         * dwarf2/read.h (struct dwarf2_per_objfile)
7304         <quick_file_names_table>: Now htab_up.
7305
7306 2020-02-08  Tom Tromey  <tom@tromey.com>
7307
7308         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
7309
7310 2020-02-08  Tom Tromey  <tom@tromey.com>
7311
7312         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
7313         Rewrite.
7314         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
7315         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
7316         (abbrev_table::abbrev_table): No longer inline.
7317         (ABBREV_HASH_SIZE): Remove.
7318         (abbrev_table::m_abbrevs): Now an htab_up.
7319
7320 2020-02-08  Tom Tromey  <tom@tromey.com>
7321
7322         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
7323         (cutu_reader): Update.
7324         (build_type_psymtabs_1): Update.
7325         * dwarf2/abbrev.c (abbrev_table::read): Rename.
7326         (abbrev_table::alloc_abbrev): Update.
7327         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
7328         (abbrev_table::read): New static method, renamed from
7329         abbrev_table_read_table.
7330         (abbrev_table::alloc_abbrev)
7331         (abbrev_table::add_abbrev): Now private.
7332         (abbrev_table::abbrev_table): Now private.
7333         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
7334
7335 2020-02-08  Tom Tromey  <tom@tromey.com>
7336
7337         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
7338         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
7339         htab_up.
7340
7341 2020-02-08  Tom Tromey  <tom@tromey.com>
7342
7343         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
7344         htab_up.
7345         (lookup_dwo_unit_in_dwp): Update.
7346         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
7347         on obstack.
7348
7349 2020-02-08  Tom Tromey  <tom@tromey.com>
7350
7351         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
7352         obstack.
7353
7354 2020-02-08  Tom Tromey  <tom@tromey.com>
7355
7356         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
7357         line_header_hash.
7358         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
7359         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
7360         Change type to htab_up.
7361
7362 2020-02-08  Tom Tromey  <tom@tromey.com>
7363
7364         * dwarf2/read.c (allocate_type_unit_groups_table): Return
7365         htab_up.  Don't allocate on obstack.
7366         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
7367         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
7368         Change type to htab_up.
7369
7370 2020-02-08  Tom Tromey  <tom@tromey.com>
7371
7372         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
7373         Change type to htab_up.
7374         * dwarf2/read.c (create_signatured_type_table_from_index)
7375         (create_signatured_type_table_from_debug_names)
7376         (create_all_type_units, add_type_unit)
7377         (lookup_dwo_signatured_type, lookup_signatured_type)
7378         (process_skeletonless_type_unit): Update.
7379         (create_debug_type_hash_table, create_debug_types_hash_table):
7380         Change type of types_htab.
7381         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
7382         htab_up.  Don't allocate on obstack.
7383         (create_cus_hash_table): Change type of cus_htab parameter.
7384         (struct dwo_file) <cus, tus>: Now htab_up.
7385         (lookup_dwo_signatured_type, lookup_dwo_cutu)
7386         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
7387         (queue_and_load_all_dwo_tus): Update.
7388         * dwarf2/index-write.c (write_gdbindex): Update.
7389         (write_debug_names): Update.
7390
7391 2020-02-08  Tom Tromey  <tom@tromey.com>
7392
7393         * dwarf2/read.h (struct dwarf2_queue_item): Move from
7394         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
7395         destructor.
7396         (struct dwarf2_per_objfile) <queue>: New member.
7397         * dwarf2/read.c (struct dwarf2_queue_item): Move to
7398         dwarf2/read.h.
7399         (dwarf2_queue, dwarf2_queue_tail): Remove.
7400         (class dwarf2_queue_guard): Add parameter to constructor.  Use
7401         DISABLE_COPY_AND_ASSIGN.
7402         <m_per_objfile>: New member.
7403         <~dwarf2_queue_guard>: Rewrite.
7404         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
7405         Update.
7406         (~dwarf2_queue_item): New.
7407
7408 2020-02-08  Tom Tromey  <tom@tromey.com>
7409
7410         * dwarf2/read.c (struct die_info) <has_children>: New member.
7411         (dw2_get_file_names_reader): Remove has_children.
7412         (dw2_get_file_names): Update.
7413         (read_cutu_die_from_dwo): Remove has_children.
7414         (cutu_reader::init_tu_and_read_dwo_dies)
7415         (cutu_reader::cutu_reader): Update.
7416         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
7417         Remove has_children.
7418         (build_type_psymtabs_1, process_skeletonless_type_unit)
7419         (load_partial_comp_unit, load_full_comp_unit): Update.
7420         (create_dwo_cu_reader): Remove has_children.
7421         (create_cus_hash_table, read_die_and_children): Update.
7422         (read_full_die_1,read_full_die): Remove has_children.
7423         (read_signatured_type): Update.
7424         (class cutu_reader) <has_children>: Remove.
7425
7426 2020-02-08  Tom Tromey  <tom@tromey.com>
7427
7428         * dwarf2/expr.c: Rename from dwarf2expr.c.
7429         * dwarf2/expr.h: Rename from dwarf2expr.h.
7430         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
7431         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
7432         * dwarf2/frame.c: Rename from dwarf2-frame.c.
7433         * dwarf2/frame.h: Rename from dwarf2-frame.h.
7434         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
7435         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
7436         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
7437         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
7438         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
7439         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
7440         * dwarf2/loc.c: Rename from dwarf2loc.c.
7441         * dwarf2/loc.h: Rename from dwarf2loc.h.
7442         * dwarf2/read.c: Rename from dwarf2read.c.
7443         * dwarf2/read.h: Rename from dwarf2read.h.
7444         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
7445         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
7446         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
7447         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
7448         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
7449         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
7450         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
7451         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
7452         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
7453         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
7454         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
7455         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
7456         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
7457         Update.
7458         * Makefile.in (COMMON_SFILES): Update.
7459         (HFILES_NO_SRCDIR): Update.
7460
7461 2020-02-08  Tom Tromey  <tom@tromey.com>
7462
7463         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
7464         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
7465
7466 2020-02-08  Tom Tromey  <tom@tromey.com>
7467
7468         * dwarf2read.h (struct die_info): Don't declare.
7469
7470 2020-02-08  Tom Tromey  <tom@tromey.com>
7471
7472         * dwarf2read.h (die_info_ptr): Remove typedef.
7473
7474 2020-02-08  Tom Tromey  <tom@tromey.com>
7475
7476         * dwarf2read.c (read_call_site_scope)
7477         (handle_data_member_location, dwarf2_add_member_fn)
7478         (mark_common_block_symbol_computed, read_common_block)
7479         (attr_to_dynamic_prop, partial_die_info::read)
7480         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
7481         (dwarf2_symbol_mark_computed, set_die_type): Update.
7482         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
7483         method.
7484         (attr_form_is_block): Don't declare.
7485         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
7486
7487 2020-02-08  Tom Tromey  <tom@tromey.com>
7488
7489         * dwarf2read.c (dwarf2_find_base_address, )
7490         (read_call_site_scope, rust_containing_type)
7491         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
7492         (handle_data_member_location, dwarf2_add_member_fn)
7493         (get_alignment, read_structure_type, process_structure_scope)
7494         (mark_common_block_symbol_computed, read_common_block)
7495         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
7496         (partial_die_info::read, read_attribute_value, new_symbol)
7497         (lookup_die_type, dwarf2_get_ref_die_offset)
7498         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
7499         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
7500         (dwarf2_symbol_mark_computed): Update.
7501         * dwarf2/attribute.h (struct attribute) <value_as_address,
7502         form_is_section_offset, form_is_constant, form_is_ref>: Declare
7503         methods.
7504         (value_as_address, attr_form_is_section_offset)
7505         (attr_form_is_constant, attr_form_is_ref): Don't declare.
7506         * dwarf2/attribute.c (attribute::value_as_address)
7507         (attribute::form_is_section_offset, attribute::form_is_constant)
7508         (attribute::form_is_ref): Now methods.
7509
7510 2020-02-08  Tom Tromey  <tom@tromey.com>
7511
7512         * dwarf2read.c (struct attribute, DW_STRING)
7513         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
7514         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
7515         (attr_form_is_block, attr_form_is_section_offset)
7516         (attr_form_is_constant, attr_form_is_ref): Move.
7517         * dwarf2/attribute.h: New file.
7518         * dwarf2/attribute.c: New file, from dwarf2read.c.
7519         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
7520
7521 2020-02-08  Tom Tromey  <tom@tromey.com>
7522
7523         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
7524         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
7525         Move.
7526         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
7527         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
7528         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
7529         abbrev.c.
7530         * dwarf2/abbrev.h: New file.
7531         * dwarf2/abbrev.c: New file, from dwarf2read.c.
7532         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
7533
7534 2020-02-08  Tom Tromey  <tom@tromey.com>
7535
7536         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
7537         (dwarf2_section_size, dwarf2_get_section_info)
7538         (create_signatured_type_table_from_debug_names)
7539         (create_addrmap_from_aranges, read_debug_names_from_section)
7540         (get_gdb_index_contents_from_section, read_comp_unit_head)
7541         (error_check_comp_unit_head, read_abbrev_offset)
7542         (create_debug_type_hash_table, init_cu_die_reader)
7543         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
7544         (read_comp_units_from_section, create_cus_hash_table)
7545         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
7546         (create_dwp_v2_section, dwarf2_rnglists_process)
7547         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
7548         (abbrev_table_read_table, read_indirect_string_at_offset_from)
7549         (read_indirect_string_from_dwz, read_addr_index_1)
7550         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
7551         (dwarf_decode_macro_bytes, dwarf_decode_macros)
7552         (fill_in_loclist_baton): Update.
7553         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
7554         get_containing_section, get_bfd_owner, get_bfd_section,
7555         get_file_name, get_id, get_flags, empty, read>: Declare methods.
7556         (dwarf2_read_section, get_section_name, get_section_file_name)
7557         (get_containing_section, get_section_bfd_owner)
7558         (get_section_bfd_section, get_section_name, get_section_file_name)
7559         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
7560         declare.
7561         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
7562         (dwarf2_section_info::get_bfd_owner)
7563         (dwarf2_section_info::get_bfd_section)
7564         (dwarf2_section_info::get_name)
7565         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
7566         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
7567         (dwarf2_section_info::read): Now methods.
7568         * dwarf-index-write.c (class debug_names): Update.
7569
7570 2020-02-08  Tom Tromey  <tom@tromey.com>
7571
7572         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
7573         Move to dwarf2/section.h.
7574         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
7575         (get_section_bfd_section, get_section_name)
7576         (get_section_file_name, get_section_id, get_section_flags)
7577         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
7578         dwarf2/section.c.
7579         * dwarf2/section.h: New file.
7580         * dwarf2/section.c: New file, from dwarf2read.c.
7581         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
7582
7583 2020-02-08  Tom Tromey  <tom@tromey.com>
7584
7585         * dwarf2read.h (read_unsigned_leb128): Don't declare.
7586         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
7587         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
7588         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
7589         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
7590         * dwarf2/leb.h: New file, from dwarf2read.c.
7591         * dwarf2/leb.c: New file, from dwarf2read.c.
7592         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
7593         Remove.
7594         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
7595         (COMMON_SFILES): Add dwarf2/leb.c.
7596
7597 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
7598
7599         GDB 9.1 released.
7600
7601 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7602
7603         PR gdb/25190:
7604         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
7605         * gdb/remote.c (remote_console_output): Update.
7606         * gdb/ui-file.c (fputs_unfiltered): Rename to...
7607         (ui_file_puts): ...this.
7608         * gdb/ui-file.h (ui_file_puts): Add declaration.
7609         * gdb/utils.c (emit_style_escape): Update.
7610         (flush_wrap_buffer): Update.
7611         (fputs_maybe_filtered): Update.
7612         (fputs_unfiltered): Add function.
7613
7614 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
7615
7616         * gdb/event-loop.c (gdb_wait_for_event): Update.
7617         * gdb/printcmd.c (printf_command): Update.
7618         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
7619         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
7620         (gdb_os_flush_stderr): Update.
7621         * gdb/remote.c (remote_console_output): Update.
7622         * gdb/ui-file.c (gdb_flush): Rename to...
7623         (ui_file_flush): ...this.
7624         (stderr_file::write): Update.
7625         (stderr_file::puts): Update.
7626         * gdb/ui-file.h (gdb_flush): Rename to...
7627         (ui_file_flush): ...this.
7628         * gdb/utils.c (gdb_flush): Add function.
7629         * gdb/utils.h (gdb_flush): Add declaration.
7630
7631 2020-02-07  Tom Tromey  <tromey@adacore.com>
7632
7633         PR breakpoints/24915:
7634         * source.c (find_and_open_source): Do not check basenames_may_differ.
7635
7636 2020-02-07  Tom Tromey  <tom@tromey.com>
7637
7638         * README: Update gdbserver documentation.
7639         * gdbserver: Move to top level.
7640         * configure.tgt (build_gdbserver): Remove.
7641         * configure.ac: Remove --enable-gdbserver.
7642         * configure: Rebuild.
7643         * Makefile.in (distclean): Don't mention gdbserver.
7644
7645 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7646
7647         * source-cache.c (source_cache::ensure): Surround
7648         get_plain_source_lines with a try/catch.
7649         (source_cache::get_line_charpos): Get rid of try/catch
7650         and only check for the return value of "ensure".
7651         * tui/tui-source.c (tui_source_window::set_contents):
7652         Simplify "nlines" calculation.
7653
7654 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
7655
7656         * MAINTAINERS (Write After Approval): Add myself.
7657
7658 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7659
7660         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
7661         function call.
7662
7663 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
7664
7665         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
7666
7667 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
7668
7669         * nat/riscv-linux-tdesc.h: New file.
7670         * nat/riscv-linux-tdesc.c: New file, taking code from...
7671         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7672         ... here.
7673         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
7674         NATDEPFILES.
7675
7676 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
7677
7678         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
7679         we don't set the fake simulator ptid to the null_ptid.
7680
7681 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
7682
7683         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
7684         * gdbthread.h (class thread_info) <resumed>: Likewise.
7685         * infrun.c (resume_1): Likewise.
7686         (proceed): Likewise.
7687         (infrun_thread_stop_requested): Likewise.
7688         (stop_all_threads): Likewise.
7689         (handle_inferior_event): Likewise.
7690         (restart_threads): Likewise.
7691         (finish_step_over): Likewise.
7692         (keep_going_stepped_thread): Likewise.
7693         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
7694         (linux_handle_extended_wait): Likewise.
7695         * record-btrace.c (get_thread_current_frame_id): Likewise.
7696         * record-full.c (record_full_wait_1): Likewise.
7697         * remote.c (remote_target::process_initial_stop_replies): Likewise.
7698         * target.c (target_resume): Likewise.
7699         * thread.c (set_running_thread): Likewise.
7700
7701 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7702
7703         * f-valprint.c (f77_print_array_1): Changed datatype of index
7704         variable to LONGEST from int to enable it to contain bound
7705         values correctly.
7706
7707 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
7708
7709         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
7710         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
7711         offsets according to FLEN determined.
7712         (riscv_linux_nat_target::read_description): Determine FLEN
7713         dynamically.
7714         (riscv_linux_nat_target::fetch_registers): Size regset buffer
7715         according to FLEN determined.
7716         (riscv_linux_nat_target::store_registers): Likewise.
7717
7718 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
7719
7720         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7721         when reg->group is empty and reggroup is not.
7722
7723 2020-01-31  Tom Tromey  <tromey@adacore.com>
7724
7725         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
7726         Call beneath target's mourn_inferior after unpushing.
7727
7728 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         PR tui/9765
7731         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
7732         have enough lines to fill the screen, still return the lowest
7733         address we found.
7734
7735 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
7738         '-', '<', and '>' commands.
7739
7740 2020-01-29  Pedro Alves  <palves@redhat.com>
7741             Sergio Durigan Junior  <sergiodj@redhat.com>
7742
7743         * infcmd.c (construct_inferior_arguments): Assert that
7744         'argc' is greater than 0.
7745
7746 2020-01-29  Luis Machado  <luis.machado@linaro.org>
7747
7748         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
7749         (BRK_INSN_MASK): Define to 0xd4200000.
7750         (aarch64_program_breakpoint_here_p): New function.
7751         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
7752         * arch-utils.c (default_program_breakpoint_here_p): Moved from
7753         breakpoint.c.
7754         * arch-utils.h (default_program_breakpoint_here_p): Moved from
7755         breakpoint.h
7756         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
7757         call gdbarch_program_breakpoint_here_p.
7758         (program_breakpoint_here): Moved to arch-utils.c, renamed to
7759         default_program_breakpoint_here_p, changed return type to bool and
7760         simplified.
7761         * breakpoint.h (program_breakpoint_here): Moved prototype to
7762         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
7763         return type to bool.
7764         * gdbarch.c: Regenerate.
7765         * gdbarch.h: Regenerate.
7766         * gdbarch.sh (program_breakpoint_here_p): New method.
7767         * infrun.c (handle_signal_stop): Call
7768         gdbarch_program_breakpoint_here_p.
7769
7770 2020-01-26  Tom Tromey  <tom@tromey.com>
7771
7772         * ctfread.c (struct ctf_fp_info): Reindent.
7773         (_initialize_ctfread): Remove.
7774
7775 2020-01-26  Tom Tromey  <tom@tromey.com>
7776
7777         * psymtab.c (partial_map_expand_apply)
7778         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
7779         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
7780         (psym_print_stats, psym_expand_symtabs_for_function)
7781         (psym_map_symbol_filenames, psym_map_matching_symbols)
7782         (psym_expand_symtabs_matching)
7783         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
7784         (maintenance_check_psymtabs): Use new methods.
7785         * psympriv.h (struct partial_symtab) <readin_p,
7786         get_compunit_symtab>: New methods.
7787         <readin, compunit_symtab>: Remove members.
7788         (struct standard_psymtab): New.
7789         (struct legacy_psymtab): Derive from standard_psymtab.
7790         * dwarf2read.h (struct dwarf2_psymtab): Derive from
7791         standard_psymtab.
7792         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
7793
7794 2020-01-26  Tom Tromey  <tom@tromey.com>
7795
7796         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
7797         read_dependencies.  Add assert.
7798         * psymtab.c (partial_symtab::read_dependencies): New method.
7799         * psympriv.h (struct partial_symtab) <read_dependencies>: New
7800         method.
7801         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
7802         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
7803         read_dependencies.
7804         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
7805         Add assert.
7806
7807 2020-01-26  Tom Tromey  <tom@tromey.com>
7808
7809         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
7810         Call expand_psymtab.
7811         (xcoff_read_symtab): Call expand_psymtab.
7812         (xcoff_start_psymtab, xcoff_end_psymtab): Set
7813         legacy_expand_psymtab.
7814         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
7815         method.
7816         (struct legacy_psymtab) <expand_psymtab>: Implement.
7817         <legacy_expand_psymtab>: New member.
7818         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
7819         (parse_partial_symbols): Set legacy_expand_psymtab.
7820         (psymtab_to_symtab_1): Change argument order.  Call
7821         expand_psymtab.
7822         (new_psymtab): Set legacy_expand_psymtab.
7823         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
7824         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
7825         expand_psymtab.
7826         (dwarf2_psymtab::expand_psymtab): Rename from
7827         psymtab_to_symtab_1.  Call expand_psymtab.
7828         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
7829         (dbx_end_psymtab): Likewise.
7830         (dbx_psymtab_to_symtab_1): Change argument order. Call
7831         expand_psymtab.
7832         (dbx_read_symtab): Call expand_psymtab.
7833         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
7834         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
7835         (ctf_psymtab::read_symtab): Call expand_psymtab.
7836
7837 2020-01-26  Tom Tromey  <tom@tromey.com>
7838
7839         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
7840         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
7841         messages.
7842         * mdebugread.c (mdebug_read_symtab): Remove prints.
7843         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
7844         assert.
7845         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
7846
7847 2020-01-26  Tom Tromey  <tom@tromey.com>
7848
7849         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
7850         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
7851         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
7852         legacy_symtab.
7853         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
7854         * psymtab.c (psymtab_to_symtab): Call method.
7855         (dump_psymtab): Update.
7856         * psympriv.h (struct partial_symtab): Add virtual destructor.
7857         <read_symtab>: New method.
7858         (struct legacy_symtab): New.
7859         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
7860         (struct pst_map) <pst>: Now a legacy_psymtab.
7861         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
7862         (new_psymtab): Use legacy_psymtab.
7863         * dwarf2read.h (struct dwarf2_psymtab): New.
7864         (struct dwarf2_per_cu_data) <psymtab>: Use it.
7865         * dwarf2read.c (dwarf2_create_include_psymtab)
7866         (dwarf2_build_include_psymtabs, create_type_unit_group)
7867         (create_partial_symtab, process_psymtab_comp_unit_reader)
7868         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
7869         (set_partial_user): Use dwarf2_psymtab.
7870         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
7871         (psymtab_to_symtab_1, process_full_comp_unit)
7872         (process_full_type_unit, dwarf2_ranges_read)
7873         (dwarf2_get_pc_bounds, psymtab_include_file_name)
7874         (dwarf_decode_lines): Use dwarf2_psymtab.
7875         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
7876         (add_address_entry_worker, write_one_signatured_type)
7877         (recursively_count_psymbols, recursively_write_psymbols)
7878         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
7879         (write_debug_names): Likewise.
7880         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
7881         <pst>: Now a legacy_psymtab.
7882         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
7883         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
7884         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
7885         * ctfread.c (struct ctf_psymtab): New.
7886         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
7887         ctf_psymtab.
7888         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
7889         (create_partial_symtab): Return a ctf_psymtab.
7890         (scan_partial_symbols): Update.
7891
7892 2020-01-26  Tom Tromey  <tom@tromey.com>
7893
7894         * xcoffread.c (xcoff_start_psymtab): Use new.
7895         * psymtab.c (partial_symtab::partial_symtab): New constructor,
7896         renamed from start_psymtab_common.
7897         * psympriv.h (struct partial_symtab): Add new constructor.
7898         (start_psymtab_common): Don't declare.
7899         * mdebugread.c (parse_partial_symbols): Use new.
7900         * dwarf2read.c (create_partial_symtab): Use new.
7901         * dbxread.c (start_psymtab): Use new.
7902         * ctfread.c (create_partial_symtab): Use new.
7903
7904 2020-01-26  Tom Tromey  <tom@tromey.com>
7905
7906         * xcoffread.c (xcoff_end_psymtab): Use new.
7907         * psymtab.c (start_psymtab_common): Use new.
7908         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
7909         Update.
7910         * psympriv.h (struct partial_symtab): Add parameters to
7911         constructor.  Don't inline.
7912         (allocate_psymtab): Don't declare.
7913         * mdebugread.c (new_psymtab): Use new.
7914         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
7915         * dbxread.c (dbx_end_psymtab): Use new.
7916
7917 2020-01-26  Tom Tromey  <tom@tromey.com>
7918
7919         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
7920         allocate_psymtab.  Update documentation.
7921         * psymtab.c (psymtab_storage::install_psymtab): Rename from
7922         allocate_psymtab.  Do not use new.
7923         (allocate_psymtab): Use new.  Update.
7924
7925 2020-01-26  Tom Tromey  <tom@tromey.com>
7926
7927         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
7928         * psymtab.c (psym_print_stats): Update.
7929         * psympriv.h (struct partial_symtab) <readin,
7930         psymtabs_addrmap_supported, anonymous>: Now bool.
7931         * mdebugread.c (psymtab_to_symtab_1): Update.
7932         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
7933         (build_type_psymtabs_reader, psymtab_to_symtab_1)
7934         (process_full_comp_unit, process_full_type_unit): Update.
7935         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
7936         * ctfread.c (psymtab_to_symtab): Update.
7937
7938 2020-01-26  Tom Tromey  <tom@tromey.com>
7939
7940         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
7941         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
7942         * psymtab.c (psymtab_storage): Delete psymtabs.
7943         (psymtab_storage::allocate_psymtab): Use new.
7944         (psymtab_storage::discard_psymtab): Use delete.
7945         * psympriv.h (struct partial_symtab): Add constructor and
7946         initializers.
7947
7948 2020-01-26  Tom Tromey  <tom@tromey.com>
7949
7950         * machoread.c: Do not include psympriv.h.
7951
7952 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7953
7954         * NEWS: Mention the new option and the set/show commands.
7955
7956 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7957
7958         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
7959         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
7960         (validate_exec_file): New variables, enums, functions.
7961         (exec_file_locate_attach, print_section_info): Style the filenames.
7962         (_initialize_exec): Install show_exec_file_mismatch_command and
7963          set_exec_file_mismatch_command.
7964         * gdbcore.h (validate_exec_file): Declare.
7965         * infcmd.c (attach_command): Call validate_exec_file.
7966         * remote.c ( remote_target::remote_add_inferior): Likewise.
7967
7968 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7969
7970         * frame.c (find_frame_sal): Move call to get_next_frame into more
7971         inner scope.
7972         * inline-frame.c (inilne_state) <inline_state>: Update argument
7973         types.
7974         (inilne_state) <skipped_symbol>: Rename to...
7975         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
7976         (skip_inline_frames): Build vector of skipped symbols and use this
7977         to reate the inline_state.
7978         (inline_skipped_symbol): Add a comment and some assertions, fetch
7979         skipped symbol from the list.
7980
7981 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * buildsym.c (lte_is_less_than): Delete.
7984         (buildsym_compunit::end_symtab_with_blockvector): Create local
7985         lambda function to sort line table entries, and use
7986         std::stable_sort instead of std::sort.
7987         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
7988         markers when looking for a previous line.
7989
7990 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
7991
7992         * dwarf2read.c (lnp_state_machine::record_line): Include
7993         end_sequence parameter in debug print out.  Record the line if we
7994         are at an end_sequence marker even if it's not the start of a
7995         statement.
7996         * symmisc.c (maintenance_print_one_line_table): Print end of
7997         sequence markers with 'END' not '0'.
7998
7999 2020-01-24  Pedro Alves  <palves@redhat.com>
8000
8001         PR gdb/25410
8002         * thread.c (scoped_restore_current_thread::restore): Use
8003         switch_to_inferior_no_thread.
8004         * exec.c: Include "progspace-and-thread.h".
8005         (add_target_sections, remove_target_sections):
8006         scoped_restore_current_pspace_and_thread instead of
8007         scoped_restore_current_thread.
8008         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8009         and aspace to the inferior before calling clone_program_space.
8010         Remove stale comment.
8011
8012 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8013
8014         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8015         (arm_netbsd_nat_target::fetch_registers): ...this.
8016         (arm_nbsd_nat_target::store_registers): Rename to...
8017         (arm_netbsd_nat_target::store_registers): ...this.
8018
8019 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8020
8021         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8022         register_t.
8023
8024 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8025
8026         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8027         Update comment.
8028         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8029         Likewise.
8030         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8031         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8032         the correct replacement (iterate_over_regset_sections).
8033         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8034         Update comment.
8035
8036 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
8037
8038         PR gdb/23718
8039         * gdb/python/python.c (execute_gdb_command): Call
8040         async_enable_stdin in catch block.
8041
8042 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8043
8044         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8045         SWITCH_THRU_ALL_UIS.
8046
8047 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8048
8049         PR tui/9765
8050         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8051         comment, add extra parameter, and update to store previous symbol
8052         when appropriate.
8053         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8054         add extra parameter.
8055         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8056         remove unneeded parameter, add try/catch around gdb_print_insn,
8057         rewrite to add items to asm_lines vector.
8058         (tui_find_backward_disassembly_start_address): New function.
8059         (tui_find_disassembly_address): Updated throughout.
8060         (tui_disasm_window::set_contents): Update for changes to
8061         tui_disassemble.
8062         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8063         number of lines to scroll.
8064
8065 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8066
8067         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8068         (SECT_OFF_DATA): Likewise.
8069         (SECT_OFF_RODATA): Likewise.
8070         (SECT_OFF_TEXT): Likewise.
8071         (SECT_OFF_BSS): Likewise.
8072         (struct objfile) <text_section_offset, data_section_offset>: New
8073         methods.
8074         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8075         objfile::text_section_offset.
8076         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8077         * coffread.c (coff_symtab_read): Likewise.
8078         (enter_linenos): Likewise.
8079         (process_coff_symbol): Likewise.
8080         * ctfread.c (get_objfile_text_range): Likewise.
8081         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8082         Use objfile::data_section_offset.
8083         * dwarf2-frame.c (execute_cfa_program): Use
8084         objfile::text_section_offset.
8085         (dwarf2_frame_find_fde): Likewise.
8086         * dwarf2read.c (create_addrmap_from_index): Likewise.
8087         (create_addrmap_from_aranges): Likewise.
8088         (dw2_find_pc_sect_compunit_symtab): Likewise.
8089         (process_psymtab_comp_unit_reader): Likewise.
8090         (add_partial_symbol): Likewise.
8091         (add_partial_subprogram): Likewise.
8092         (process_full_comp_unit): Likewise.
8093         (read_file_scope): Likewise.
8094         (read_func_scope): Likewise.
8095         (read_lexical_block_scope): Likewise.
8096         (read_call_site_scope): Likewise.
8097         (dwarf2_rnglists_process): Likewise.
8098         (dwarf2_ranges_process): Likewise.
8099         (dwarf2_ranges_read): Likewise.
8100         (dwarf_decode_lines_1): Likewise.
8101         (new_symbol): Likewise.
8102         (dwarf2_fetch_die_loc_sect_off): Likewise.
8103         (dwarf2_per_cu_text_offset): Likewise.
8104         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8105         * hppa-tdep.c (read_unwind_info): Likewise.
8106         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8107         * psympriv.h (struct partial_symtab): Likewise.
8108         * psymtab.c (find_pc_sect_psymtab): Likewise.
8109         * solib-svr4.c (enable_break): Likewise.
8110         * stap-probe.c (relocate_address): Use
8111         objfile::data_section_offset.
8112         * xcoffread.c (enter_line_range): Use
8113         objfile::text_section_offset.
8114         (read_xcoff_symtab): Likewise.
8115
8116 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8117
8118         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8119         declaration to narrower scopes.
8120
8121 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8122
8123         * darwin-nat.h (struct darwin_exception_msg, enum
8124         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8125         Move up.
8126         (class darwin_nat_target) <wait_1, check_new_threads,
8127         decode_exception_message, decode_message, stop_inferior,
8128         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8129         * darwin-nat.c (darwin_check_new_threads): Rename to...
8130         (darwin_nat_target::check_new_threads): ... this.
8131         (darwin_suspend_inferior_it): Remove.
8132         (darwin_decode_exception_message): Rename to...
8133         (darwin_nat_target::decode_exception_message): ... this.
8134         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8135         (darwin_decode_message): Rename to...
8136         (darwin_nat_target::decode_message): ... this.
8137         (cancel_breakpoint): Rename to...
8138         (darwin_nat_target::cancel_breakpoint): ... this.
8139         (darwin_wait): Rename to...
8140         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8141         instead of iterate_over_inferiors.
8142         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8143         (darwin_stop_inferior): Rename to...
8144         (darwin_nat_target::stop_inferior): ... this.
8145         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8146         (darwin_init_thread_list): Rename to...
8147         (darwin_nat_target::init_thread_list): ... this.
8148         (darwin_ptrace_him): Rename to...
8149         (darwin_nat_target::ptrace_him): ... this.
8150         (darwin_nat_target::create_inferior): Pass lambda function to
8151         fork_inferior.
8152         (darwin_nat_target::detach): Call stop_inferior instead of
8153         darwin_stop_inferior.
8154         * fork-inferior.h (fork_inferior): Change init_trace_fun
8155         parameter to gdb::function_view.
8156         * fork-inferior.c (fork_inferior): Likewise.
8157
8158 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8159
8160         * i386-cygwin-tdep.c (core_process_module_section): Update.
8161         * windows-nat.c (struct lm_info_windows): Add text_offset.
8162         (windows_xfer_shared_libraries): Update.
8163         * windows-tdep.c (windows_xfer_shared_library):
8164         Add text_offset_cached argument.
8165         * windows-tdep.h (windows_xfer_shared_library): Update.
8166
8167 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8168
8169         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8170
8171 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8172
8173         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8174         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8175         replace with range-based for.
8176         (gdbsim_interrupt_inferior): Remove.
8177         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8178         with a range-based for.  Inline code from
8179         gdbsim_interrupt_inferior.
8180
8181 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8182
8183         * infrun.c (proceed): Fix indentation.
8184
8185 2020-01-21  Tom Tromey  <tromey@adacore.com>
8186
8187         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8188         * python/python.c (python_extension_ops): Update.
8189         (gdbpy_colorize): New function.
8190         * python/lib/gdb/__init__.py (colorize): New function.
8191         * extension.h (ext_lang_colorize): Declare.
8192         * extension.c (ext_lang_colorize): New function.
8193         * extension-priv.h (struct extension_language_ops) <colorize>: New
8194         member.
8195         * cli/cli-style.c (_initialize_cli_style): Update help text.
8196
8197 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8198
8199         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8200         <cond>: Change type to bool.
8201         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8202         (aarch64_displaced_step_cb): Likewise.
8203         (aarch64_displaced_step_tb): Likewise.
8204
8205 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8206
8207         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8208         output.
8209
8210 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8211
8212         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8213         <pc_adjust>: Adjust the documentation.
8214         (aarch64_displaced_step_fixup): Check if PC really moved before
8215         adjusting it.
8216
8217 2020-01-19  Tom Tromey  <tom@tromey.com>
8218
8219         * disasm.c (~gdb_disassembler): New destructor.
8220         (gdb_buffered_insn_length): Call disassemble_free_target.
8221         * disasm.h (class gdb_disassembler): Declare destructor.  Use
8222         DISABLE_COPY_AND_ASSIGN.
8223
8224 2020-01-19  Tom Tromey  <tom@tromey.com>
8225
8226         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
8227         (die_reader_func_ftype): Remove.
8228         (cutu_reader): New class.
8229         (dw2_get_file_names_reader): Remove "data" parameter.
8230         (dw2_get_file_names): Use cutu_reader.
8231         (create_debug_type_hash_table): Update.
8232         (read_cutu_die_from_dwo): Update comment.
8233         (lookup_dwo_unit): Add dwo_name parameter.
8234         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
8235         die_reader_func_ftype and data parameters.
8236         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
8237         Remove die_reader_func_ftype and data parameters.
8238         (~cutu_reader): New; from init_cutu_and_read_dies.
8239         (cutu_reader::cutu_reader): Rename from
8240         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
8241         and data parameters.
8242         (init_cutu_and_read_dies_simple): Remove.
8243         (struct process_psymtab_comp_unit_data): Remove.
8244         (process_psymtab_comp_unit_reader): Remove data parameter; add
8245         want_partial_unit and pretend_language parameters.
8246         (process_psymtab_comp_unit): Use cutu_reader.
8247         (build_type_psymtabs_reader): Remove data parameter.
8248         (build_type_psymtabs_1): Use cutu_reader.
8249         (process_skeletonless_type_unit): Likewise.
8250         (load_partial_comp_unit_reader): Remove.
8251         (load_partial_comp_unit): Use cutu_reader.
8252         (load_full_comp_unit_reader): Remove.
8253         (load_full_comp_unit): Use cutu_reader.
8254         (struct create_dwo_cu_data): Remove.
8255         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
8256         dwo_unit parameters.
8257         (create_cus_hash_table): Use cutu_reader.
8258         (struct dwarf2_read_addr_index_data): Remove.
8259         (dwarf2_read_addr_index_reader): Remove.
8260         (dwarf2_read_addr_index): Use cutu_reader.
8261         (read_signatured_type_reader): Remove.
8262         (read_signatured_type): Use cutu_reader.
8263
8264 2020-01-19  Tom Tromey  <tom@tromey.com>
8265
8266         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
8267         * tui/tui-wingeneral.h (class tui_suppress_output): New.
8268         (tui_wrefresh): Declare.
8269         * tui/tui-wingeneral.c (suppress_output): New global.
8270         (tui_suppress_output, ~tui_suppress_output): New constructor and
8271         destructor.
8272         (tui_wrefresh): New function.
8273         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
8274         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
8275         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
8276         method.
8277         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
8278         tui_wrefresh.
8279         (tui_data_window::no_refresh): New method.
8280         (tui_data_item_window::refresh_window): Call tui_wrefresh.
8281         (tui_reg_command): Use tui_suppress_output
8282         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
8283         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
8284         method.
8285         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
8286
8287 2020-01-19  Tom Tromey  <tom@tromey.com>
8288
8289         * tui/tui-winsource.c (tui_update_source_windows_with_line):
8290         Handle case where symtab is null.
8291
8292 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
8293
8294         * linux-fork.c (one_fork_p): Simplify.
8295
8296 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8297
8298         * top.c (struct qt_args): Remove.
8299         (kill_or_detach): Change return type to void, replace `void *`
8300         parameter with a proper one.
8301         (print_inferior_quit_action):  Likewise.
8302         (quit_confirm): Use range-based for loop to iterate over inferiors.
8303         (quit_force): Likewise.
8304
8305 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8306
8307         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
8308         `void *` parameter with proper parameters.
8309         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
8310         (print_one_inferior): Change return type to void, replace `void *`
8311         parameter with proper parameters.
8312         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
8313         inferiors.
8314         (get_other_inferior): Remove.
8315         (mi_cmd_remove_inferior): Use range-based loop to iterate over
8316         inferiors.
8317
8318 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8319
8320         * mi/mi-interp.c (report_initial_inferior): Remove.
8321         (mi_interp::init): Use range-based for to iterate over inferiors.
8322
8323 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8324
8325         * python/py-inferior.c (build_inferior_list): Remove.
8326         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
8327
8328 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
8329
8330         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
8331         (btrace_stitch_trace): Likewise.
8332         * charset.c (intermediate_encoding): Likewise (vaild).
8333         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
8334         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
8335         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
8336
8337 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
8338
8339         * windows-tdep.c (windows_get_tlb_type):
8340         Add rtl_user_process_parameters type.
8341
8342 2020-01-16  Pedro Alves  <palves@redhat.com>
8343             Norbert Lange  <nolange79@gmail.com>
8344
8345         PR build/24805
8346         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
8347         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
8348         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
8349         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
8350         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
8351         (ps_plog): Redeclare exported functions with default visibility.
8352
8353 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
8354
8355         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
8356         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
8357
8358 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
8359
8360         * infcmd.c (post_create_inferior): Use get_thread_regcache
8361         instead of get_current_regcache.
8362
8363 2020-01-14  Tom Tromey  <tom@tromey.com>
8364
8365         PR symtab/12535:
8366         * python/python.c (gdbpy_decode_line): Treat empty string the same
8367         as no argument.
8368
8369 2020-01-14  Tom Tromey  <tom@tromey.com>
8370
8371         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
8372
8373 2020-01-14  Tom Tromey  <tom@tromey.com>
8374
8375         * nat/linux-btrace.c: Don't include <config.h>.
8376         * nat/linux-ptrace.c: Don't include <config.h>.
8377         * nat/x86-linux-dregs.c: Don't include <config.h>.
8378
8379 2020-01-14  Tom Tromey  <tom@tromey.com>
8380
8381         * configure: Rebuild.
8382         * configure.ac: Move many checks to ../gdbsupport/common.m4.
8383
8384 2020-01-14  Tom Tromey  <tom@tromey.com>
8385
8386         * nat/x86-linux-dregs.c: Include configh.h.
8387         * nat/linux-ptrace.c: Include configh.h.
8388         * nat/linux-btrace.c: Include configh.h.
8389         * defs.h: Include config.h, bfd.h.
8390         * configure.ac: Don't source common.host.
8391         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
8392         * configure: Rebuild.
8393         * acinclude.m4: Update path.
8394         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
8395         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
8396         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
8397         (CLIBS): Add LIBSUPPORT.
8398         (CDEPS): Likewise.
8399         (COMMON_SFILES): Remove gdbsupport files.
8400         (HFILES_NO_SRCDIR): Likewise.
8401         (stamp-version): Update path to create-version.sh.
8402         (ALLDEPFILES): Remove gdbsupport files.
8403
8404 2020-01-14  Tom Tromey  <tom@tromey.com>
8405
8406         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
8407         USE_WIN32API when needed.
8408         * configure.ac (USE_WIN32API): Don't define.
8409         (WIN32LIBS): Use WIN32APILIBS.
8410         * configure: Rebuild.
8411
8412 2020-01-14  Tom Tromey  <tom@tromey.com>
8413
8414         * configure: Rebuild.
8415         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
8416
8417 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8418
8419         * skip.c (skip_function_command): Make skip w/o arguments use the
8420         name of the inlined function if pc is inside any inlined function.
8421
8422 2020-01-14  Luis Machado  <luis.machado@linaro.org>
8423
8424         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
8425         * infrun.c (resume_1): Likewise.
8426         (handle_inferior_event): Remove stale comment.
8427         * linux-nat.c (linux_nat_target::resume): Update comments.
8428         (save_stop_reason): Likewise.
8429         (linux_nat_filter_event): Likewise.
8430         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
8431
8432 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8433
8434         * elfread.c (record_minimal_symbol): Set section index to 0 for
8435         non-allocatable sections.
8436
8437
8438 2020-01-13  Ali Tamur <tamur@google.com>
8439
8440         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
8441         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
8442         to gdb::optional.  Update comments.
8443         (dwo_file): Update comments.
8444         (read_attribute): Update API to take an additional out parameter,
8445         need_reprocess.  This is used to mark attributes that need other
8446         attributes (e.g. str_offsets_base) for correct computation which may not
8447         have been read yet.
8448         (read_attribute_reprocess): New function declaration.
8449         (read_addr_index): Likewise.
8450         (read_dwo_str_index): Likewise.
8451         (read_stub_str_index): Likewise.
8452         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
8453         (lookup_addr_base): New function definition.
8454         (lookup_ranges_base): Likewise.
8455         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
8456         lookup_ranges_base.
8457         (init_cutu_and_read_dies): Update comments.
8458         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
8459         unit.  This is used to inherit parent's str_offsets_base and addr_base.
8460         Update comments.
8461         (init_cutu_and_read_dies_simple): Reflect API changes.
8462         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
8463         (create_cus_hash_table): Change API to take parent compile unit.
8464         Reflect API changes.
8465         (open_and_init_dwo_file): Reflect API changes.
8466         (dwarf2_get_pc_bounds): Update comments.
8467         (dwarf2_record_block_ranges): Likewise.
8468         (read_full_die_1): Change implementation to reprocess attributes that
8469         need str_offsets_base and addr_base.
8470         (partial_die_info::read): Likewise.
8471         (read_attribute_reprocess): New function definition.
8472         (read_attribute_value): Change API to take an additional out parameter,
8473         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
8474         when a non-dwo compile unit has index based attributes.
8475         (read_attribute): Reflect API changes.
8476         (read_addr_index_1): Reflect API changes.  Update comments.
8477         (dwarf2_read_addr_index_data): Reflect API changes.
8478         (dwarf2_read_addr_index): Likewise.
8479         (read_str_index): Change API and implementation.  This becomes a helper
8480         to be used by the new string index related methods.  Update error
8481         message and comments.
8482         (read_dwo_str_index): New function definition.
8483         (read_stub_str_index): Likewise.
8484         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
8485         * symfile.h (dwarf2_debug_sections): Likewise.
8486         * xcoffread.c (dwarf2_debug_sections): Likewise.
8487
8488 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8489
8490         * gdbcore.h (struct core_fns) <core_read_registers>: Change
8491         core_reg_sect type to gdb_byte *.
8492         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
8493         * cris-tdep.c (fetch_core_registers): Likewise.
8494         * corelow.c (core_target::get_core_register_section): Change
8495         type of `contents` to gdb::byte_vector.
8496
8497 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8498
8499         * tui/tui-wingeneral.c (box_win): Position the title in the center
8500         of the border.
8501
8502 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8503
8504         * corelow.c (core_target::get_core_register_section): Use
8505           std::vector instead of alloca.
8506
8507 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8508
8509         * warning.m4: Add -Wmissing-declarations to build_warnings.
8510         * configure: Re-generate.
8511
8512 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8513
8514         * python/python.c (init__gdb_module): Add declaration.
8515
8516 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
8517
8518         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
8519         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
8520         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
8521         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
8522         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
8523         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
8524         * ada-exp.y (_initialize_ada_exp): Add declaration.
8525         * ada-lang.c (_initialize_ada_language): Add declaration.
8526         * ada-tasks.c (_initialize_tasks): Add declaration.
8527         * agent.c (_initialize_agent): Add declaration.
8528         * aix-thread.c (_initialize_aix_thread): Add declaration.
8529         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
8530         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
8531         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
8532         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
8533         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
8534         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
8535         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
8536         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
8537         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
8538         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
8539         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
8540         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
8541         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
8542         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
8543         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
8544         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
8545         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
8546         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
8547         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
8548         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
8549         * annotate.c (_initialize_annotate): Add declaration.
8550         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
8551         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
8552         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
8553         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
8554         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
8555         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
8556         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
8557         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
8558         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
8559         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
8560         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
8561         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
8562         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
8563         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
8564         * auto-load.c (_initialize_auto_load): Add declaration.
8565         * auxv.c (_initialize_auxv): Add declaration.
8566         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
8567         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
8568         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
8569         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
8570         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
8571         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
8572         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
8573         * breakpoint.c (_initialize_breakpoint): Add declaration.
8574         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
8575         * btrace.c (_initialize_btrace): Add declaration.
8576         * charset.c (_initialize_charset): Add declaration.
8577         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
8578         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
8579         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
8580         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
8581         * cli/cli-script.c (_initialize_cli_script): Add declaration.
8582         * cli/cli-style.c (_initialize_cli_style): Add declaration.
8583         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
8584         * coffread.c (_initialize_coffread): Add declaration.
8585         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
8586         * compile/compile.c (_initialize_compile): Add declaration.
8587         * complaints.c (_initialize_complaints): Add declaration.
8588         * completer.c (_initialize_completer): Add declaration.
8589         * copying.c (_initialize_copying): Add declaration.
8590         * corefile.c (_initialize_core): Add declaration.
8591         * corelow.c (_initialize_corelow): Add declaration.
8592         * cp-abi.c (_initialize_cp_abi): Add declaration.
8593         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
8594         * cp-support.c (_initialize_cp_support): Add declaration.
8595         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
8596         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
8597         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
8598         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
8599         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
8600         * ctfread.c (_initialize_ctfread): Add declaration.
8601         * d-lang.c (_initialize_d_language): Add declaration.
8602         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
8603         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
8604         * dbxread.c (_initialize_dbxread): Add declaration.
8605         * dcache.c (_initialize_dcache): Add declaration.
8606         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
8607         * disasm.c (_initialize_disasm): Add declaration.
8608         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
8609         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
8610         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
8611         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
8612         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
8613         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
8614         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
8615         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
8616         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
8617         * elfread.c (_initialize_elfread): Add declaration.
8618         * exec.c (_initialize_exec): Add declaration.
8619         * extension.c (_initialize_extension): Add declaration.
8620         * f-lang.c (_initialize_f_language): Add declaration.
8621         * f-valprint.c (_initialize_f_valprint): Add declaration.
8622         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
8623         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
8624         * filesystem.c (_initialize_filesystem): Add declaration.
8625         * findcmd.c (_initialize_mem_search): Add declaration.
8626         * findvar.c (_initialize_findvar): Add declaration.
8627         * fork-child.c (_initialize_fork_child): Add declaration.
8628         * frame-base.c (_initialize_frame_base): Add declaration.
8629         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
8630         * frame.c (_initialize_frame): Add declaration.
8631         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
8632         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
8633         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
8634         * gcore.c (_initialize_gcore): Add declaration.
8635         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
8636         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
8637         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
8638         * gdbarch.c (_initialize_gdbarch): Add declaration.
8639         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
8640         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
8641         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
8642         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
8643         * go-lang.c (_initialize_go_language): Add declaration.
8644         * go32-nat.c (_initialize_go32_nat): Add declaration.
8645         * guile/guile.c (_initialize_guile): Add declaration.
8646         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
8647         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
8648         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
8649         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
8650         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
8651         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
8652         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
8653         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
8654         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
8655         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
8656         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
8657         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
8658         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
8659         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
8660         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
8661         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
8662         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
8663         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
8664         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
8665         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
8666         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
8667         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
8668         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
8669         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
8670         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
8671         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
8672         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
8673         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
8674         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
8675         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
8676         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
8677         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
8678         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
8679         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
8680         * infcall.c (_initialize_infcall): Add declaration.
8681         * infcmd.c (_initialize_infcmd): Add declaration.
8682         * inflow.c (_initialize_inflow): Add declaration.
8683         * infrun.c (_initialize_infrun): Add declaration.
8684         * interps.c (_initialize_interpreter): Add declaration.
8685         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
8686         * jit.c (_initialize_jit): Add declaration.
8687         * language.c (_initialize_language): Add declaration.
8688         * linux-fork.c (_initialize_linux_fork): Add declaration.
8689         * linux-nat.c (_initialize_linux_nat): Add declaration.
8690         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
8691         * linux-thread-db.c (_initialize_thread_db): Add declaration.
8692         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
8693         * m2-lang.c (_initialize_m2_language): Add declaration.
8694         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
8695         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
8696         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
8697         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
8698         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
8699         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
8700         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
8701         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
8702         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
8703         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
8704         * machoread.c (_initialize_machoread): Add declaration.
8705         * macrocmd.c (_initialize_macrocmd): Add declaration.
8706         * macroscope.c (_initialize_macroscope): Add declaration.
8707         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
8708         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
8709         * maint.c (_initialize_maint_cmds): Add declaration.
8710         * mdebugread.c (_initialize_mdebugread): Add declaration.
8711         * memattr.c (_initialize_mem): Add declaration.
8712         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
8713         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
8714         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
8715         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
8716         * mi/mi-main.c (_initialize_mi_main): Add declaration.
8717         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
8718         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
8719         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
8720         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
8721         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
8722         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
8723         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
8724         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
8725         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
8726         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
8727         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
8728         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
8729         * mipsread.c (_initialize_mipsread): Add declaration.
8730         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
8731         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
8732         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
8733         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
8734         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
8735         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
8736         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
8737         * nto-procfs.c (_initialize_procfs): Add declaration.
8738         * objc-lang.c (_initialize_objc_language): Add declaration.
8739         * observable.c (_initialize_observer): Add declaration.
8740         * opencl-lang.c (_initialize_opencl_language): Add declaration.
8741         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
8742         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
8743         * osabi.c (_initialize_gdb_osabi): Add declaration.
8744         * osdata.c (_initialize_osdata): Add declaration.
8745         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
8746         * parse.c (_initialize_parse): Add declaration.
8747         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
8748         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
8749         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
8750         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
8751         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
8752         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
8753         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
8754         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
8755         * printcmd.c (_initialize_printcmd): Add declaration.
8756         * probe.c (_initialize_probe): Add declaration.
8757         * proc-api.c (_initialize_proc_api): Add declaration.
8758         * proc-events.c (_initialize_proc_events): Add declaration.
8759         * proc-service.c (_initialize_proc_service): Add declaration.
8760         * procfs.c (_initialize_procfs): Add declaration.
8761         * producer.c (_initialize_producer): Add declaration.
8762         * psymtab.c (_initialize_psymtab): Add declaration.
8763         * python/python.c (_initialize_python): Add declaration.
8764         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
8765         * record-btrace.c (_initialize_record_btrace): Add declaration.
8766         * record-full.c (_initialize_record_full): Add declaration.
8767         * record.c (_initialize_record): Add declaration.
8768         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
8769         * regcache.c (_initialize_regcache): Add declaration.
8770         * reggroups.c (_initialize_reggroup): Add declaration.
8771         * remote-notif.c (_initialize_notif): Add declaration.
8772         * remote-sim.c (_initialize_remote_sim): Add declaration.
8773         * remote.c (_initialize_remote): Add declaration.
8774         * reverse.c (_initialize_reverse): Add declaration.
8775         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
8776         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
8777         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
8778         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
8779         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
8780         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
8781         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
8782         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
8783         Add declaration.
8784         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
8785         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
8786         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
8787         * rust-exp.y (_initialize_rust_exp): Add declaration.
8788         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
8789         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
8790         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
8791         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
8792         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
8793         * score-tdep.c (_initialize_score_tdep): Add declaration.
8794         * ser-go32.c (_initialize_ser_dos): Add declaration.
8795         * ser-mingw.c (_initialize_ser_windows): Add declaration.
8796         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
8797         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
8798         * ser-uds.c (_initialize_ser_socket): Add declaration.
8799         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
8800         * serial.c (_initialize_serial): Add declaration.
8801         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
8802         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
8803         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
8804         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
8805         * skip.c (_initialize_step_skip): Add declaration.
8806         * sol-thread.c (_initialize_sol_thread): Add declaration.
8807         * solib-aix.c (_initialize_solib_aix): Add declaration.
8808         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
8809         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
8810         * solib-frv.c (_initialize_frv_solib): Add declaration.
8811         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
8812         * solib-target.c (_initialize_solib_target): Add declaration.
8813         * solib.c (_initialize_solib): Add declaration.
8814         * source-cache.c (_initialize_source_cache): Add declaration.
8815         * source.c (_initialize_source): Add declaration.
8816         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
8817         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
8818         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
8819         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
8820         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
8821         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
8822         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
8823         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
8824         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
8825         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
8826         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
8827         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
8828         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
8829         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
8830         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
8831         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
8832         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
8833         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
8834         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
8835         * stabsread.c (_initialize_stabsread): Add declaration.
8836         * stack.c (_initialize_stack): Add declaration.
8837         * stap-probe.c (_initialize_stap_probe): Add declaration.
8838         * std-regs.c (_initialize_frame_reg): Add declaration.
8839         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
8840         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
8841         * symfile.c (_initialize_symfile): Add declaration.
8842         * symmisc.c (_initialize_symmisc): Add declaration.
8843         * symtab.c (_initialize_symtab): Add declaration.
8844         * target.c (_initialize_target): Add declaration.
8845         * target-connection.c (_initialize_target_connection): Add
8846         declaration.
8847         * target-dcache.c (_initialize_target_dcache): Add declaration.
8848         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
8849         * thread.c (_initialize_thread): Add declaration.
8850         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
8851         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
8852         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
8853         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
8854         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
8855         * tracectf.c (_initialize_ctf): Add declaration.
8856         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
8857         * tracefile.c (_initialize_tracefile): Add declaration.
8858         * tracepoint.c (_initialize_tracepoint): Add declaration.
8859         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
8860         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
8861         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
8862         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
8863         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
8864         * tui/tui-win.c (_initialize_tui_win): Add declaration.
8865         * tui/tui.c (_initialize_tui): Add declaration.
8866         * typeprint.c (_initialize_typeprint): Add declaration.
8867         * ui-style.c (_initialize_ui_style): Add declaration.
8868         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
8869         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
8870         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
8871         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
8872         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
8873         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
8874         * unittests/filtered_iterator-selftests.c
8875         (_initialize_filtered_iterator_selftests): Add declaration.
8876         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
8877         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
8878         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
8879         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
8880         * unittests/main-thread-selftests.c
8881         (_initialize_main_thread_selftests): Add declaration.
8882         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
8883         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
8884         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
8885         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
8886         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
8887         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
8888         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
8889         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
8890         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
8891         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
8892         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
8893         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
8894         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
8895         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
8896         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
8897         declaration.
8898         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
8899         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
8900         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
8901         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
8902         * user-regs.c (_initialize_user_regs): Add declaration.
8903         * utils.c (_initialize_utils): Add declaration.
8904         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
8905         * valops.c (_initialize_valops): Add declaration.
8906         * valprint.c (_initialize_valprint): Add declaration.
8907         * value.c (_initialize_values): Add declaration.
8908         * varobj.c (_initialize_varobj): Add declaration.
8909         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
8910         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
8911         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
8912         * windows-nat.c (_initialize_windows_nat): Add declaration.
8913         (_initialize_check_for_gdb_ini): Add declaration.
8914         (_initialize_loadable): Add declaration.
8915         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
8916         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
8917         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
8918         * xcoffread.c (_initialize_xcoffread): Add declaration.
8919         * xml-support.c (_initialize_xml_support): Add declaration.
8920         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
8921         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
8922         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
8923         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
8924
8925 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8926
8927         * regformats/regdat.sh: Generate declaration for init function.
8928
8929 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
8930
8931         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
8932         up.
8933         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
8934         close_one_inferior>: New methods.
8935         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
8936         pass down target to find_inferior_pid.
8937         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
8938         Pass down target to find_inferior_ptid.
8939         (gdbsim_target::create_inferior): Pass down target to
8940         add_thread_silent.
8941         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
8942         target down to find_inferior_ptid and switch_to_thread.
8943         (gdbsim_target::close): Update to call close_one_inferior.
8944         (struct resume_data): Remove.
8945         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
8946         directly, rather than through a void pointer.
8947         (gdbsim_target::resume): Update to call resume_one_inferior.
8948
8949 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
8950
8951         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
8952
8953 2020-01-12  Pedro Alves  <palves@redhat.com>
8954
8955         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
8956         directly for the current inferior instead of
8957         discard_all_inferiors.
8958         (discard_all_inferiors): Delete.
8959
8960 2020-01-11  Tom Tromey  <tom@tromey.com>
8961
8962         * tui/tui-wingeneral.c (box_win): Check cli_styling.
8963         * tui/tui-winsource.c (tui_source_window_base::refill): Use
8964         deprecated_safe_get_selected_frame.
8965
8966 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
8967
8968         * inferior.c (print_inferior): Switch inferior before printing it.
8969
8970 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
8971             Pedro Alves  <palves@redhat.com>
8972
8973         * progspace-and-thread.c (switch_to_program_space_and_thread):
8974         Assert there's an inferior for PSPACE.  Use
8975         switch_to_inferior_no_thread to switch the inferior too.
8976         * progspace.c (program_space::~program_space): Call
8977         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
8978         (program_space::free_all_objfiles): Don't call clear_symtab_users
8979         here.
8980         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
8981
8982 2020-01-10  Pedro Alves  <palves@redhat.com>
8983
8984         * NEWS: Mention multi-target debugging, "info connections", and
8985         "add-inferior -no-connection".
8986
8987 2020-01-10  Pedro Alves  <palves@redhat.com>
8988
8989         * infrun.c: Include "target-connection.h".
8990         (check_multi_target_resumption): New.
8991         (proceed): Call it.
8992         * target-connection.c (make_target_connection_string): Make
8993         extern.
8994         * target-connection.h (make_target_connection_string): Declare.
8995
8996 2020-01-10  Pedro Alves  <palves@redhat.com>
8997
8998         * Makefile.in (COMMON_SFILES): Add target-connection.c.
8999         * inferior.c (uiout_field_connection): New function.
9000         (print_inferior): Add new "connection-id" column.
9001         (add_inferior_command): Show connection number/string of added
9002         inferior.
9003         * process-stratum-target.h
9004         (process_stratum_target::connection_string): New virtual method.
9005         (process_stratum_target::connection_number): New field.
9006         * remote.c (remote_target::connection_string): New override.
9007         * target-connection.c: New file.
9008         * target-connection.h: New file.
9009         * target.c (decref_target): Remove process_stratum targets from
9010         the connection list.
9011         (target_stack::push): Add process_stratum targets to the
9012         connection list.
9013
9014 2020-01-10  Pedro Alves  <palves@redhat.com>
9015
9016         Revert:
9017         2016-04-12  Pedro Alves  <palves@redhat.com>
9018         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9019         Remove references to name.
9020         * serial.h (struct serial) <name>: Delete.
9021
9022 2020-01-10  Pedro Alves  <palves@redhat.com>
9023
9024         * gdbarch-selftests.c (register_to_value_test): Remove "target
9025         already pushed" check.
9026
9027 2020-01-10  Pedro Alves  <palves@redhat.com>
9028             John Baldwin  <jhb@FreeBSD.org>
9029
9030         * aarch64-linux-nat.c
9031         (aarch64_linux_nat_target::thread_architecture): Adjust.
9032         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9033         (task_command_1): Likewise.
9034         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9035         (aix_thread_target::wait, aix_thread_target::fetch_registers)
9036         (aix_thread_target::store_registers)
9037         (aix_thread_target::thread_alive): Adjust.
9038         * amd64-fbsd-tdep.c: Include "inferior.h".
9039         (amd64fbsd_get_thread_local_address): Pass down target.
9040         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
9041         thread's gdbarch instead of target_gdbarch.
9042         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
9043         get_last_target_status.
9044         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9045         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9046         inferiors.
9047         (update_inserted_breakpoint_locations): Skip if inferiors with no
9048         execution.
9049         (update_global_location_list): When handling moribund locations,
9050         find representative inferior for location's pspace, and use thread
9051         count of its process_stratum target.
9052         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9053         * bsd-uthread.c (bsd_uthread_target::wait): Use
9054         as_process_stratum_target and adjust thread_change_ptid and
9055         add_thread calls.
9056         (bsd_uthread_target::update_thread_list): Use
9057         as_process_stratum_target and adjust find_thread_ptid,
9058         thread_change_ptid and add_thread calls.
9059         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9060         find_thread_ptid call.
9061         * corelow.c (add_to_thread_list): Adjust add_thread call.
9062         (core_target_open): Adjust add_thread_silent and thread_count
9063         calls.
9064         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9065         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9066         * event-top.c (async_disconnect): Pop targets from all inferiors.
9067         * exec.c (add_target_sections): Push exec target on all inferiors
9068         sharing the program space.
9069         (remove_target_sections): Remove the exec target from all
9070         inferiors sharing the program space.
9071         (exec_on_vfork): New.
9072         * exec.h (exec_on_vfork): Declare.
9073         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9074         Pass it down.
9075         (fbsd_nat_target::update_thread_list): Adjust.
9076         (fbsd_nat_target::resume): Adjust.
9077         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9078         down.
9079         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9080         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9081         get_thread_arch_regcache call.
9082         * fork-child.c (gdb_startup_inferior): Pass target down to
9083         startup_inferior and set_executing.
9084         * gdbthread.h (struct process_stratum_target): Forward declare.
9085         (add_thread, add_thread_silent, add_thread_with_info)
9086         (in_thread_list): Add process_stratum_target parameter.
9087         (find_thread_ptid(inferior*, ptid_t)): New overload.
9088         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9089         parameter.
9090         (all_threads()): Delete overload.
9091         (all_threads, all_non_exited_threads): Add process_stratum_target
9092         parameter.
9093         (all_threads_safe): Use brace initialization.
9094         (thread_count): Add process_stratum_target parameter.
9095         (set_resumed, set_running, set_stop_requested, set_executing)
9096         (threads_are_executing, finish_thread_state): Add
9097         process_stratum_target parameter.
9098         (switch_to_thread): Use is_current_thread.
9099         * i386-fbsd-tdep.c: Include "inferior.h".
9100         (i386fbsd_get_thread_local_address): Pass down target.
9101         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9102         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9103         have_inferiors check.
9104         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9105         (inf_ptrace_target::attach): Adjust.
9106         * infcall.c (run_inferior_call): Adjust.
9107         * infcmd.c (run_command_1): Pass target to
9108         scoped_finish_thread_state.
9109         (proceed_thread_callback): Skip inferiors with no execution.
9110         (continue_command): Rename 'all_threads' local to avoid hiding
9111         'all_threads' function.  Adjust get_last_target_status call.
9112         (prepare_one_step): Adjust set_running call.
9113         (signal_command): Use user_visible_resume_target.  Compare thread
9114         pointers instead of inferior_ptid.
9115         (info_program_command): Adjust to pass down target.
9116         (attach_command): Mark target's 'thread_executing' flag.
9117         (stop_current_target_threads_ns): New, factored out from ...
9118         (interrupt_target_1): ... this.  Switch inferior before making
9119         target calls.
9120         * inferior-iter.h
9121         (struct all_inferiors_iterator, struct all_inferiors_range)
9122         (struct all_inferiors_safe_range)
9123         (struct all_non_exited_inferiors_range): Filter on
9124         process_stratum_target too.  Remove explicit.
9125         * inferior.c (inferior::inferior): Push dummy target on target
9126         stack.
9127         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9128         Add process_stratum_target parameter, and pass it down.
9129         (have_live_inferiors): Adjust.
9130         (switch_to_inferior_and_push_target): New.
9131         (add_inferior_command, clone_inferior_command): Handle
9132         "-no-connection" parameter.  Use
9133         switch_to_inferior_and_push_target.
9134         (_initialize_inferior): Mention "-no-connection" option in
9135         the help of "add-inferior" and "clone-inferior" commands.
9136         * inferior.h: Include "process-stratum-target.h".
9137         (interrupt_target_1): Use bool.
9138         (struct inferior) <push_target, unpush_target, target_is_pushed,
9139         find_target_beneath, top_target, process_target, target_at,
9140         m_stack>: New.
9141         (discard_all_inferiors): Delete.
9142         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9143         (all_inferiors, all_non_exited_inferiors): Add
9144         process_stratum_target parameter.
9145         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9146         (target_last_proc_target): New global.
9147         (follow_fork_inferior): Push target on new inferior.  Pass target
9148         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9149         reference count.
9150         (follow_fork): Adjust get_last_target_status call.  Also consider
9151         target.
9152         (follow_exec): Push target on new inferior.
9153         (struct execution_control_state) <target>: New field.
9154         (user_visible_resume_target): New.
9155         (do_target_resume): Call target_async.
9156         (resume_1): Set target's threads_executing flag.  Consider resume
9157         target.
9158         (commit_resume_all_targets): New.
9159         (proceed): Also consider resume target.  Skip threads of inferiors
9160         with no execution.  Commit resumtion in all targets.
9161         (start_remote): Pass current inferior to wait_for_inferior.
9162         (infrun_thread_stop_requested): Consider target as well.  Pass
9163         thread_info pointer to clear_inline_frame_state instead of ptid.
9164         (infrun_thread_thread_exit): Consider target as well.
9165         (random_pending_event_thread): New inferior parameter.  Use it.
9166         (do_target_wait): Rename to ...
9167         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9168         down.
9169         (threads_are_resumed_pending_p, do_target_wait): New.
9170         (prepare_for_detach): Adjust calls.
9171         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9172         do_target_wait_1 instead of do_target_wait.
9173         (fetch_inferior_event): Adjust.  Switch to representative
9174         inferior.  Pass target down.
9175         (set_last_target_status): Add process_stratum_target parameter.
9176         Save target in global.
9177         (get_last_target_status): Add process_stratum_target parameter and
9178         handle it.
9179         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9180         (context_switch): Check inferior_ptid == null_ptid before calling
9181         inferior_thread().
9182         (get_inferior_stop_soon): Pass down target.
9183         (wait_one): Rename to ...
9184         (poll_one_curr_target): ... this.
9185         (struct wait_one_event): New.
9186         (wait_one): New.
9187         (stop_all_threads): Adjust.
9188         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9189         event's target.
9190         (switch_back_to_stepped_thread): Also consider target.
9191         (print_stop_event): Update.
9192         (normal_stop): Update.  Also consider the resume target.
9193         * infrun.h (wait_for_inferior): Remove declaration.
9194         (user_visible_resume_target): New declaration.
9195         (get_last_target_status, set_last_target_status): New
9196         process_stratum_target parameter.
9197         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9198         process_stratum_target parameter, and use it.
9199         (clear_inline_frame_state (thread_info*)): New.
9200         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9201         process_stratum_target parameter.
9202         (clear_inline_frame_state (thread_info*)): Declare.
9203         * linux-fork.c (delete_checkpoint_command): Pass target down to
9204         find_thread_ptid.
9205         (checkpoint_command): Adjust.
9206         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9207         instead of just tweaking inferior_ptid.
9208         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9209         (exit_lwp): Pass target down to find_thread_ptid.
9210         (attach_proc_task_lwp_callback): Pass target down to
9211         add_thread/set_running/set_executing.
9212         (linux_nat_target::attach): Pass target down to
9213         thread_change_ptid.
9214         (get_detach_signal): Pass target down to find_thread_ptid.
9215         Consider last target status's target.
9216         (linux_resume_one_lwp_throw, resume_lwp)
9217         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
9218         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
9219         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
9220         (linux_nat_target::async_wait_fd): New.
9221         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
9222         target down.
9223         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
9224         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
9225         * linux-thread-db.c (struct thread_db_info::process_target): New
9226         field.
9227         (add_thread_db_info): Save target.
9228         (get_thread_db_info): New process_stratum_target parameter.  Also
9229         match target.
9230         (delete_thread_db_info): New process_stratum_target parameter.
9231         Also match target.
9232         (thread_from_lwp): Adjust to pass down target.
9233         (thread_db_notice_clone): Pass down target.
9234         (check_thread_db_callback): Pass down target.
9235         (try_thread_db_load_1): Always push the thread_db target.
9236         (try_thread_db_load, record_thread): Pass target down.
9237         (thread_db_target::detach): Pass target down.  Always unpush the
9238         thread_db target.
9239         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
9240         target down.  Always unpush the thread_db target.
9241         (find_new_threads_callback, thread_db_find_new_threads_2)
9242         (thread_db_target::update_thread_list): Pass target down.
9243         (thread_db_target::pid_to_str): Pass current inferior down.
9244         (thread_db_target::get_thread_local_address): Pass target down.
9245         (thread_db_target::resume, maintenance_check_libthread_db): Pass
9246         target down.
9247         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
9248         * procfs.c (procfs_target::procfs_init_inferior): Declare.
9249         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
9250         (procfs_init_inferior): Rename to ...
9251         (procfs_target::procfs_init_inferior): ... this and adjust.
9252         (procfs_target::create_inferior, procfs_notice_thread)
9253         (procfs_do_thread_registers): Adjust.
9254         * ppc-fbsd-tdep.c: Include "inferior.h".
9255         (ppcfbsd_get_thread_local_address): Pass down target.
9256         * proc-service.c (ps_xfer_memory): Switch current inferior and
9257         program space as well.
9258         (get_ps_regcache): Pass target down.
9259         * process-stratum-target.c
9260         (process_stratum_target::thread_address_space)
9261         (process_stratum_target::thread_architecture): Pass target down.
9262         * process-stratum-target.h
9263         (process_stratum_target::threads_executing): New field.
9264         (as_process_stratum_target): New.
9265         * ravenscar-thread.c
9266         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
9267         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
9268         down.
9269         * record-btrace.c (record_btrace_target::info_record): Adjust.
9270         (record_btrace_target::record_method)
9271         (record_btrace_target::record_is_replaying)
9272         (record_btrace_target::fetch_registers)
9273         (get_thread_current_frame_id, record_btrace_target::resume)
9274         (record_btrace_target::wait, record_btrace_target::stop): Pass
9275         target down.
9276         * record-full.c (record_full_wait_1): Switch to event thread.
9277         Pass target down.
9278         * regcache.c (regcache::regcache)
9279         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
9280         process_stratum_target parameter and handle it.
9281         (current_thread_target): New global.
9282         (get_thread_regcache): Add process_stratum_target parameter and
9283         handle it.  Switch inferior before calling target method.
9284         (get_thread_regcache): Pass target down.
9285         (get_thread_regcache_for_ptid): Pass target down.
9286         (registers_changed_ptid): Add process_stratum_target parameter and
9287         handle it.
9288         (registers_changed_thread, registers_changed): Pass target down.
9289         (test_get_thread_arch_aspace_regcache): New.
9290         (current_regcache_test): Define a couple local test_target_ops
9291         instances and use them for testing.
9292         (readwrite_regcache): Pass process_stratum_target parameter.
9293         (cooked_read_test, cooked_write_test): Pass mock_target down.
9294         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
9295         (get_thread_arch_aspace_regcache): Add process_stratum_target
9296         parameter.
9297         (regcache::target): New method.
9298         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
9299         (regcache::registers_changed_ptid): Add process_stratum_target
9300         parameter.
9301         (regcache::m_target): New field.
9302         (registers_changed_ptid): Add process_stratum_target parameter.
9303         * remote.c (remote_state::supports_vCont_probed): New field.
9304         (remote_target::async_wait_fd): New method.
9305         (remote_unpush_and_throw): Add remote_target parameter.
9306         (get_current_remote_target): Adjust.
9307         (remote_target::remote_add_inferior): Push target.
9308         (remote_target::remote_add_thread)
9309         (remote_target::remote_notice_new_inferior)
9310         (get_remote_thread_info): Pass target down.
9311         (remote_target::update_thread_list): Skip threads of inferiors
9312         bound to other targets.  (remote_target::close): Don't discard
9313         inferiors.  (remote_target::add_current_inferior_and_thread)
9314         (remote_target::process_initial_stop_replies)
9315         (remote_target::start_remote)
9316         (remote_target::remote_serial_quit_handler): Pass down target.
9317         (remote_target::remote_unpush_target): New remote_target
9318         parameter.  Unpush the target from all inferiors.
9319         (remote_target::remote_unpush_and_throw): New remote_target
9320         parameter.  Pass it down.
9321         (remote_target::open_1): Check whether the current inferior has
9322         execution instead of checking whether any inferior is live.  Pass
9323         target down.
9324         (remote_target::remote_detach_1): Pass down target.  Use
9325         remote_unpush_target.
9326         (extended_remote_target::attach): Pass down target.
9327         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
9328         (remote_target::append_resumption): Pass down target.
9329         (remote_target::append_pending_thread_resumptions)
9330         (remote_target::remote_resume_with_hc, remote_target::resume)
9331         (remote_target::commit_resume): Pass down target.
9332         (remote_target::remote_stop_ns): Check supports_vCont_probed.
9333         (remote_target::interrupt_query)
9334         (remote_target::remove_new_fork_children)
9335         (remote_target::check_pending_events_prevent_wildcard_vcont)
9336         (remote_target::remote_parse_stop_reply)
9337         (remote_target::process_stop_reply): Pass down target.
9338         (first_remote_resumed_thread): New remote_target parameter.  Pass
9339         it down.
9340         (remote_target::wait_as): Pass down target.
9341         (unpush_and_perror): New remote_target parameter.  Pass it down.
9342         (remote_target::readchar, remote_target::remote_serial_write)
9343         (remote_target::getpkt_or_notif_sane_1)
9344         (remote_target::kill_new_fork_children, remote_target::kill): Pass
9345         down target.
9346         (remote_target::mourn_inferior): Pass down target.  Use
9347         remote_unpush_target.
9348         (remote_target::core_of_thread)
9349         (remote_target::remote_btrace_maybe_reopen): Pass down target.
9350         (remote_target::pid_to_exec_file)
9351         (remote_target::thread_handle_to_thread_info): Pass down target.
9352         (remote_target::async_wait_fd): New.
9353         * riscv-fbsd-tdep.c: Include "inferior.h".
9354         (riscv_fbsd_get_thread_local_address): Pass down target.
9355         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
9356         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
9357         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
9358         Adjust.
9359         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
9360         * solib-svr4.c (enable_break): Pass down target.
9361         * spu-multiarch.c (parse_spufs_run): Pass down target.
9362         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
9363         * target-delegates.c: Regenerate.
9364         * target.c (g_target_stack): Delete.
9365         (current_top_target): Return the current inferior's top target.
9366         (target_has_execution_1): Refer to the passed-in inferior's top
9367         target.
9368         (target_supports_terminal_ours): Check whether the initial
9369         inferior was already created.
9370         (decref_target): New.
9371         (target_stack::push): Incref/decref the target.
9372         (push_target, push_target, unpush_target): Adjust.
9373         (target_stack::unpush): Defref target.
9374         (target_is_pushed): Return bool.  Adjust to refer to the current
9375         inferior's target stack.
9376         (dispose_inferior): Delete, and inline parts ...
9377         (target_preopen): ... here.  Only dispose of the current inferior.
9378         (target_detach): Hold strong target reference while detaching.
9379         Pass target down.
9380         (target_thread_name): Add assertion.
9381         (target_resume): Pass down target.
9382         (target_ops::beneath, find_target_at): Adjust to refer to the
9383         current inferior's target stack.
9384         (get_dummy_target): New.
9385         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
9386         has a thread running.
9387         (initialize_targets): Rename to ...
9388         (_initialize_target): ... this.
9389         * target.h: Include "gdbsupport/refcounted-object.h".
9390         (struct target_ops): Inherit refcounted_object.
9391         (target_ops::shortname, target_ops::longname): Make const.
9392         (target_ops::async_wait_fd): New method.
9393         (decref_target): Declare.
9394         (struct target_ops_ref_policy): New.
9395         (target_ops_ref): New typedef.
9396         (get_dummy_target): Declare function.
9397         (target_is_pushed): Return bool.
9398         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
9399         (all_matching_threads_iterator::all_matching_threads_iterator):
9400         Handle filter target.
9401         * thread-iter.h (struct all_matching_threads_iterator, struct
9402         all_matching_threads_range, class all_non_exited_threads_range):
9403         Filter by target too.  Remove explicit.
9404         * thread.c (threads_executing): Delete.
9405         (inferior_thread): Pass down current inferior.
9406         (clear_thread_inferior_resources): Pass down thread pointer
9407         instead of ptid_t.
9408         (add_thread_silent, add_thread_with_info, add_thread): Add
9409         process_stratum_target parameter.  Use it for thread and inferior
9410         searches.
9411         (is_current_thread): New.
9412         (thread_info::deletable): Use it.
9413         (find_thread_ptid, thread_count, in_thread_list)
9414         (thread_change_ptid, set_resumed, set_running): New
9415         process_stratum_target parameter.  Pass it down.
9416         (set_executing): New process_stratum_target parameter.  Pass it
9417         down.  Adjust reference to 'threads_executing'.
9418         (threads_are_executing): New process_stratum_target parameter.
9419         Adjust reference to 'threads_executing'.
9420         (set_stop_requested, finish_thread_state): New
9421         process_stratum_target parameter.  Pass it down.
9422         (switch_to_thread): Also match inferior.
9423         (switch_to_thread): New process_stratum_target parameter.  Pass it
9424         down.
9425         (update_threads_executing): Reimplement.
9426         * top.c (quit_force): Pop targets from all inferior.
9427         (gdb_init): Don't call initialize_targets.
9428         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
9429         Declare.
9430         (windows_add_thread, windows_delete_thread): Adjust.
9431         (get_windows_debug_event): Rename to ...
9432         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
9433         * tracefile-tfile.c (tfile_target_open): Pass down target.
9434         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
9435         Forward declare.
9436         (switch_to_thread): Add process_stratum_target parameter.
9437         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
9438         parameter.  Use it.
9439         (mi_on_resume): Pass target down.
9440         * nat/fork-inferior.c (startup_inferior): Add
9441         process_stratum_target parameter.  Pass it down.
9442         * nat/fork-inferior.h (startup_inferior): Add
9443         process_stratum_target parameter.
9444         * python/py-threadevent.c (py_get_event_thread): Pass target down.
9445
9446 2020-01-10  Pedro Alves  <palves@redhat.com>
9447
9448         * remote.c (remote_target::start_remote): Don't set inferior_ptid
9449         directly.  Instead find the first thread in the thread list and
9450         use switch_to_thread.
9451
9452 2020-01-10  Pedro Alves  <palves@redhat.com>
9453
9454         * remote.c (remote_target::remote_add_inferior): Don't bind a
9455         process to the current inferior if the current inferior is already
9456         bound to a process.
9457
9458 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9459             Pedro Alves  <palves@redhat.com>
9460
9461         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
9462         If no process is specified, return null_ptid instead of
9463         inferior_ptid.
9464         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
9465         TARGET_WAITKIND_SIGNALLED with no pid.
9466
9467 2020-01-10  Pedro Alves  <palves@redhat.com>
9468
9469         * remote.c (first_remote_resumed_thread): New.
9470         (remote_target::wait_as): Use it as default event_ptid instead of
9471         inferior_ptid.
9472
9473 2020-01-10  Pedro Alves  <palves@redhat.com>
9474
9475         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
9476
9477 2020-01-10  Pedro Alves  <palves@redhat.com>
9478
9479         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
9480         not -1.
9481
9482 2020-01-10  Pedro Alves  <palves@redhat.com>
9483
9484         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
9485         ptid to get_last_target_status.
9486         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
9487         ptid to get_last_target_status.
9488         * infcmd.c (continue_command): Don't pass a target_waitstatus to
9489         get_last_target_status.
9490         (info_program_command): Don't pass a target_waitstatus to
9491         get_last_target_status.
9492         * infrun.c (init_wait_for_inferior): Use
9493         nullify_last_target_wait_ptid.
9494         (get_last_target_status): Handle nullptr arguments.
9495         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
9496         (print_stop_event): Don't pass a ptid to get_last_target_status.
9497         (normal_stop): Don't pass a ptid to get_last_target_status.
9498         * infrun.h (get_last_target_status, set_last_target_status): Move
9499         comments here and update.
9500         (nullify_last_target_wait_ptid): Declare.
9501         * linux-fork.c (fork_load_infrun_state): Remove local extern
9502         declaration of nullify_last_target_wait_ptid.
9503         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
9504         to get_last_target_status.
9505
9506 2020-01-10  Pedro Alves  <palves@redhat.com>
9507
9508         * gdbthread.h (scoped_restore_current_thread)
9509         <dont_restore, restore, m_dont_restore>: Declare.
9510         * thread.c (thread_alive): Add assertion.  Return bool.
9511         (switch_to_thread_if_alive): New.
9512         (prune_threads): Switch inferior/thread.
9513         (print_thread_info_1): Switch thread before calling target methods.
9514         (scoped_restore_current_thread::restore): New, factored out from
9515         ...
9516         (scoped_restore_current_thread::~scoped_restore_current_thread):
9517         ... this.
9518         (scoped_restore_current_thread::scoped_restore_current_thread):
9519         Add assertion.
9520         (thread_apply_all_command, thread_select): Use
9521         switch_to_thread_if_alive.
9522         * infrun.c (proceed, restart_threads, handle_signal_stop)
9523         (switch_back_to_stepped_thread): Switch current thread before
9524         calling target methods.
9525
9526 2020-01-10  Pedro Alves <palves@redhat.com>
9527
9528         * inferior.c (switch_to_inferior_no_thread): New function,
9529         factored out from ...
9530         (inferior_command): ... here.
9531         * inferior.h (switch_to_inferior_no_thread): Declare.
9532         * mi/mi-main.c (run_one_inferior): Use
9533         switch_to_inferior_no_thread.
9534
9535 2020-01-10  Pedro Alves  <palves@redhat.com>
9536
9537         * infcmd.c (kill_command): Remove dead code.
9538
9539 2020-01-10  Pedro Alves  <palves@redhat.com>
9540
9541         * remote.c (remote_target::mourn_inferior): No longer check
9542         whether the target is running.
9543
9544 2020-01-10  Pedro Alves  <palves@redhat.com>
9545
9546         * corelow.c (core_target::has_execution): Change parameter type to
9547         inferior pointer.
9548         * inferior.c (number_of_live_inferiors): Use
9549         inferior::has_execution instead of target_has_execution_1.
9550         * inferior.h (inferior::has_execution): New.
9551         * linux-thread-db.c (thread_db_target::update_thread_list): Use
9552         inferior::has_execution instead of target_has_execution_1.
9553         * process-stratum-target.c
9554         (process_stratum_target::has_execution): Change parameter type to
9555         inferior pointer.  Check the inferior's PID instead of
9556         inferior_ptid.
9557         * process-stratum-target.h
9558         (process_stratum_target::has_execution): Change parameter type to
9559         inferior pointer.
9560         * record-full.c (record_full_core_target::has_execution): Change
9561         parameter type to inferior pointer.
9562         * target.c (target_has_execution_1): Change parameter type to
9563         inferior pointer.
9564         (target_has_execution_current): Adjust.
9565         * target.h (target_ops::has_execution): Change parameter type to
9566         inferior pointer.
9567         (target_has_execution_1): Change parameter type to inferior
9568         pointer.  Change return type to bool.
9569         * tracefile.h (tracefile_target::has_execution): Change parameter
9570         type to inferior pointer.
9571
9572 2020-01-10  Pedro Alves  <palves@redhat.com>
9573
9574         * exceptions.c (print_flush): Remove current_top_target() check.
9575
9576 2020-01-10  Pedro Alves  <palves@redhat.com>
9577
9578         * remote.c (show_remote_exec_file): Show the current inferior's
9579         exec-file instead of the command variable's value.
9580
9581 2020-01-10  Pedro Alves  <palves@redhat.com>
9582
9583         * record-full.c (record_full_resume_ptid): New global.
9584         (record_full_target::resume): Set it.
9585         (record_full_wait_1): Use record_full_resume_ptid instead of
9586         inferior_ptid.
9587
9588 2020-01-10  Pedro Alves  <palves@redhat.com>
9589
9590         * gdbthread.h (scoped_restore_current_thread)
9591         <dont_restore, restore, m_dont_restore>: Declare.
9592         * thread.c (thread_alive): Add assertion.  Return bool.
9593         (switch_to_thread_if_alive): New.
9594         (prune_threads): Switch inferior/thread.
9595         (print_thread_info_1): Switch thread before calling target methods.
9596         (scoped_restore_current_thread::restore): New, factored out from
9597         ...
9598         (scoped_restore_current_thread::~scoped_restore_current_thread):
9599         ... this.
9600         (scoped_restore_current_thread::scoped_restore_current_thread):
9601         Add assertion.
9602         (thread_apply_all_command, thread_select): Use
9603         switch_to_thread_if_alive.
9604
9605 2020-01-10  George Barrett  <bob@bob131.so>
9606
9607         * stap-probe.c (stap_modify_semaphore): Don't check for null
9608         semaphores.
9609         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
9610         for null semaphores.
9611
9612 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9613
9614         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
9615         all source windows, and maintain horizontal scroll status while
9616         doing so.
9617
9618 2020-01-09  Tom Tromey  <tom@tromey.com>
9619
9620         PR tui/18932:
9621         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
9622         update_source_window, not print_source_lines.
9623
9624 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9625
9626         * tui/tui.c (tui_enable): Register tui hooks after calling
9627         tui_display_main.
9628
9629 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9630
9631         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
9632
9633 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
9634
9635         * thread.c (print_thread_info_1): Fix indentation.
9636
9637 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
9638
9639         * symtab.c (general_symbol_info::compute_and_set_names): Move the
9640         unique_xmalloc_ptr outside the if to always free the demangled name.
9641
9642 2020-01-08  Tom Tromey  <tromey@adacore.com>
9643
9644         * xcoffread.c (enter_line_range, read_xcoff_symtab)
9645         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
9646         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
9647         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
9648         Remove.
9649         (section_offsets): New typedef.
9650         * symtab.c (fixup_section, get_msymbol_address): Update.
9651         * symmisc.c (dump_msymbols): Update.
9652         * symfile.h (relative_addr_info_to_section_offsets)
9653         (symfile_map_offsets_to_segments): Update.
9654         * symfile.c (build_section_addr_info_from_objfile)
9655         (init_objfile_sect_indices): Update.
9656         (struct place_section_arg): Change type of "offsets".
9657         (place_section): Update.
9658         (relative_addr_info_to_section_offsets): Change type of
9659         "section_offsets".  Remove "num_sections" parameter.
9660         (default_symfile_offsets, syms_from_objfile_1)
9661         (set_objfile_default_section_offset): Update.
9662         (reread_symbols): No need to preserve section offsets by hand.
9663         (symfile_map_offsets_to_segments): Change type of "offsets".
9664         * stap-probe.c (relocate_address): Update.
9665         * stabsread.h (process_one_symbol): Update.
9666         * solib-target.c (struct lm_info_target) <offsets>: Change type.
9667         (solib_target_relocate_section_addresses): Update.
9668         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
9669         Update.
9670         * solib-frv.c (frv_relocate_main_executable): Update.
9671         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
9672         * solib-aix.c (solib_aix_get_section_offsets): Change return
9673         type.
9674         (solib_aix_solib_create_inferior_hook): Update.
9675         * remote.c (remote_target::get_offsets): Update.
9676         * psymtab.c (find_pc_sect_psymtab): Update.
9677         * psympriv.h (struct partial_symbol) <address, text_low,
9678         text_high>: Update.
9679         * objfiles.h (obj_section_offset): Update.
9680         (struct objfile) <section_offsets>: Change type.
9681         <num_sections>: Remove.
9682         (objfile_relocate): Update.
9683         * objfiles.c (entry_point_address_query): Update
9684         (relocate_one_symbol): Change type of "section_offsets".
9685         (objfile_relocate1, objfile_relocate1): Change type of
9686         "new_offsets".
9687         (objfile_rebase1): Update.
9688         * mipsread.c (mipscoff_symfile_read): Update.
9689         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
9690         parameter.
9691         * mdebugread.c (parse_symbol): Change type of "section_offsets".
9692         (parse_external, psymtab_to_symtab_1): Update.
9693         * machoread.c (macho_symfile_offsets): Update.
9694         * ia64-tdep.c (ia64_find_unwind_table): Update.
9695         * hppa-tdep.c (read_unwind_info): Update.
9696         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
9697         * dwarf2read.c (create_addrmap_from_index)
9698         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9699         (process_psymtab_comp_unit_reader, add_partial_symbol)
9700         (add_partial_subprogram, process_full_comp_unit)
9701         (read_file_scope, read_func_scope, read_lexical_block_scope)
9702         (read_call_site_scope, dwarf2_rnglists_process)
9703         (dwarf2_ranges_process, dwarf2_ranges_read)
9704         (dwarf_decode_lines_1, var_decode_location, new_symbol)
9705         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
9706         Update.
9707         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
9708         Update.
9709         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
9710         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
9711         (process_one_symbol): Change type of "section_offsets".
9712         * ctfread.c (get_objfile_text_range): Update.
9713         * coffread.c (coff_symtab_read, enter_linenos)
9714         (process_coff_symbol): Update.
9715         * coff-pe-read.c (add_pe_forwarded_sym): Update.
9716         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
9717
9718 2020-01-08  Tom Tromey  <tromey@adacore.com>
9719
9720         * dwarf2read.c (parse_macro_definition): Use std::string.
9721         (parse_macro_definition): Likewise.
9722
9723 2020-01-08  Tom Tromey  <tromey@adacore.com>
9724
9725         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
9726         (ATTR_ALLOC_CHUNK): Remove.
9727
9728 2020-01-08  Tom Tromey  <tromey@adacore.com>
9729
9730         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
9731
9732 2020-01-08  Tom Tromey  <tromey@adacore.com>
9733
9734         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
9735         (dwarf2_compute_name, open_dwo_file): Likewise.
9736         (process_enumeration_scope): Use std::vector.
9737         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
9738         (partial_die_info::fixup, dwarf2_start_subfile)
9739         (guess_full_die_structure_name, dwarf2_name): Likewise.
9740         (determine_prefix): Update.
9741         (guess_full_die_structure_name): Make return type const.
9742         (partial_die_full_name): Return unique_xmalloc_ptr.
9743         (DW_FIELD_ALLOC_CHUNK): Remove.
9744
9745 2020-01-07  Tom Tromey  <tromey@adacore.com>
9746
9747         PR build/24937:
9748         * stap-probe.c (class stap_static_probe_ops): Add constructor.
9749
9750 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9751
9752         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
9753
9754 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9755
9756         * stack.c (print_frame_info): Move disassemble_next_line code
9757         inside source_print block.
9758
9759 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9760
9761         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
9762         gdb/signals.h, as we are now using native signal symbols.
9763
9764 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9765
9766         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
9767         overflow by an early check of content vs threshold.
9768         * tui/tui-source.c (tui_source_window::line_is_displayed):
9769         Likewise.
9770
9771 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9772
9773         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
9774
9775 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
9776
9777         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
9778         export table if no section contains it's RVA.
9779
9780 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9781
9782         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
9783
9784 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
9785
9786         * source.c (print_source_lines_base): Set last_line_listed.
9787
9788 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
9789
9790         * tui/tui-disasm.c: Remove trailing spaces.
9791
9792 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
9793             Pedro Alves  <palves@redhat.com>
9794
9795         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
9796         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
9797         (windows_gdb_signal_to_target): New function, uses the above
9798         enumeration to convert GDB internal signal codes to equivalent
9799         Windows codes.
9800         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
9801         * windows-nat.c: Include "gdb_wait.h".
9802         (get_windows_debug_event): Extract the fatal exception from the
9803         exit status and convert to the equivalent Posix signal number.
9804         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
9805         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
9806         * gdbsupport/gdb_wait.c: New file, implements
9807         windows_status_to_termsig.
9808         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
9809         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
9810
9811 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9812
9813         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
9814         show_layout.
9815
9816 2020-01-05  Luis Machado  <luis.machado@linaro.org>
9817
9818         * aarch64-linux-nat.c
9819         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
9820         and bfd_mach_aarch64.
9821
9822 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9823
9824         * ui-file.c (stdio_file::can_emit_style_escape)
9825         (tee_file::can_emit_style_escape): Ensure style is used also on
9826         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
9827         to gdb_stdout.
9828         * main.c (set_gdb_data_directory): Use file style to output the
9829         warning that the given pathname is not a directory.
9830         * top.c (show_history_filename, gdb_safe_append_history)
9831         (show_gdb_datadir): Use file style.
9832
9833 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9834
9835         * solib-target.c (struct lm_info_target):
9836         Change offsets to be a unique_xmalloc_ptr.
9837         (solib_target_relocate_section_addresses): Update.
9838
9839 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
9840
9841         * windows-nat.c (windows_clear_solib): Free so_list linked list.
9842
9843 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9844
9845         * MAINTAINERS (Write After Approval): Add myself.
9846
9847 2020-01-02  Luis Machado  <luis.machado@linaro.org>
9848
9849         * proc-service.c (get_ps_regcache): Remove reference to obsolete
9850         Cell BE architecture.
9851         * target.h (struct target_ops) <thread_architecture>: Likewise.
9852
9853 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9854
9855         * Makefile.in: Use INSTALL_PROGRAM_ENV.
9856
9857 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
9858
9859         * MAINTAINERS (Write After Approval): Add myself.
9860
9861 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9862
9863         * gdbarch.sh: Update copyright year range of generated files.
9864
9865 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9866
9867         Update copyright year range in all GDB files.
9868
9869 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9870
9871         * copyright.py: Convert to Python 3.
9872
9873 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9874
9875         * copyright.py: Adapt after move of gnulib directory from gdb
9876         directory to toplevel directory.
9877
9878 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9879
9880         * copyright.py (main): Exit if run from the wrong directory.
9881
9882 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9883
9884         * top.c (print_gdb_version): Change copyright year to 2020.
9885
9886 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
9887
9888         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
9889
9890 For older changes see ChangeLog-2019.
9891 \f
9892 Local Variables:
9893 mode: change-log
9894 left-margin: 8
9895 fill-column: 74
9896 version-control: never
9897 coding: utf-8
9898 End: