gdb/ChangeLog

   1 2019-06-27  Tom Tromey  <tromey@adacore.com>
   2
   3         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
   4         objfile_key.
   5         (arm_find_mapping_symbol, arm_record_special_symbol)
   6         (_initialize_arm_tdep): Update.
   7         (arm_objfile_data_free): Remove.
   8
   9 2019-06-27  Tom Tromey  <tromey@adacore.com>
  10
  11         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
  12         to cp_print_static_field.
  13
  14 2019-06-26  Tom Tromey  <tromey@adacore.com>
  15
  16         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
  17         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
  18         declare.
  19
  20 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  21
  22         * features/aarch64-core.c (create_feature_aarch64_core):
  23         Regenerate.
  24         * features/aarch64-core.xml: Add cpsr flags.
  25
  26 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
  27
  28         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
  29         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
  30
  31 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  32
  33         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
  34         field.
  35         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
  36         use.
  37         (arm_record_special_symbol): Don't insert new symbol in sorted
  38         position, push it at the end.
  39
  40 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
  41
  42         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
  43         (arm_mapping_symbol_s): Remove.
  44         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
  45         (arm_mapping_symbol_vec): New typedef.
  46         (struct arm_per_objfile): Add constructor.
  47         <section_maps>: Change type to
  48         std::unique_ptr<arm_mapping_symbol_vec[]>.
  49         (arm_compare_mapping_symbols): Remove.
  50         (arm_find_mapping_symbol): Adjust to section_maps type change.
  51         (arm_objfile_data_free): Call delete on arm_per_objfile.
  52         (arm_record_special_symbol): Adjust to section_maps type change.
  53         Allocate arm_per_objfile with new.
  54
  55 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  56
  57         * cli/cli-cmds.c (alias_command): Compare the alias prefix
  58         with the command prefix.
  59
  60 2019-06-25  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
  63         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
  64
  65 2019-06-25  Tom Tromey  <tom@tromey.com>
  66
  67         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
  68         type.
  69         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
  70         protected.
  71
  72 2019-06-25  Tom Tromey  <tom@tromey.com>
  73
  74         * tui/tui-winsource.c
  75         (tui_source_window_base::set_is_exec_point_at): Add check against
  76         LOA_ADDRESS.
  77
  78 2019-06-25  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-source.c (tui_set_source_content): Don't check before
  81         xfree.
  82         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
  83
  84 2019-06-25  Tom Tromey  <tom@tromey.com>
  85
  86         * tui/tui-winsource.h (tui_update_source_window_as_is)
  87         (tui_alloc_source_buffer, tui_line_is_displayed)
  88         (tui_addr_is_displayed): Change type of win_info.
  89         * tui/tui-winsource.c (tui_update_source_window_as_is)
  90         (tui_clear_source_content, tui_show_source_line)
  91         (tui_show_source_content, tui_source_window_base::refill)
  92         (tui_source_window_base::set_is_exec_point_at)
  93         (tui_source_window_base::set_is_exec_point_at)
  94         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
  95         (tui_alloc_source_buffer, tui_line_is_displayed)
  96         (tui_addr_is_displayed): Change type of win_info.  Update.
  97         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
  98         (tui_source_window_base::do_make_visible_with_new_height):
  99         Update.
 100         * tui/tui-source.c (tui_set_source_content)
 101         (tui_set_source_content_nil)
 102         (tui_source_window::do_scroll_vertical): Update.
 103         * tui/tui-layout.c (show_layout): Update.
 104         * tui/tui-disasm.c (tui_set_disassem_content)
 105         (tui_disasm_window::do_scroll_vertical): Update.
 106         * tui/tui-data.h (tui_win_content): Remove.
 107         (struct tui_gen_win_info) <content, content_size>: Remove.
 108         (struct tui_source_element): Add initializers and destructor.
 109         (union tui_which_element, struct tui_win_element): Remove.
 110         (struct tui_source_window_base) <content>: New field.
 111         (struct tui_data_window): Remove destructor.
 112         (tui_alloc_content, tui_free_win_content)
 113         (tui_free_all_source_wins_content): Don't declare.
 114         * tui/tui-data.c (tui_initialize_static_data): Update.
 115         (init_content_element, tui_alloc_content): Remove.
 116         (~tui_gen_win_info): Update.
 117         (~tui_data_window, tui_free_all_source_wins_content)
 118         (tui_free_win_content, free_content, free_content_elements):
 119         Remove.
 120
 121 2019-06-25  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-winsource.h (tui_clear_source_content)
 124         (tui_erase_source_content, tui_show_source_content): Change type
 125         of win_info.
 126         * tui/tui-winsource.c (tui_clear_source_content)
 127         (tui_erase_source_content, tui_show_source_content): Change type
 128         of win_info.
 129         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 130         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 131         win_info.
 132         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 133         win_info.
 134         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 135
 136 2019-06-25  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-winsource.c (tui_clear_source_content)
 139         (tui_source_window_base::set_is_exec_point_at): Update.
 140         * tui/tui-source.c (tui_set_source_content_nil): Update.
 141         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 142         a bool.
 143         * tui/tui-data.c (init_content_element): Update.
 144
 145 2019-06-25  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 148         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 149         * tui/tui-layout.c (init_and_make_win): Update.
 150         * tui/tui.h (enum tui_win_type): Update.
 151         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 152         tui_win_is_auxillary.
 153         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 154         tui_win_is_auxillary.
 155
 156 2019-06-25  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 159         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 160         (tui_delete_data_content_windows, tui_display_all_data)
 161         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 162         Update.
 163         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 164         * tui/tui-regs.c (tui_last_regs_line_no)
 165         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 166         (tui_show_registers): Update.
 167         (tui_show_register_group): Return void.  Update.
 168         (tui_display_registers_from, tui_display_reg_element_at_line)
 169         (tui_display_registers_from_line, tui_check_register_values):
 170         Update.
 171         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 172         member.
 173         (struct tui_data_window) <regs_content>: Now a std::vector.
 174         <regs_content_count>: Remove.
 175         (tui_add_content_elements, tui_free_data_content): Don't declare.
 176         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 177         (init_content_element): Remove DATA_WIN case.  Add assert.
 178         (tui_add_content_elements): Remove.
 179         (tui_data_window): Update.
 180         (tui_free_data_content): Remove.
 181         (free_content_elements): Remove DATA_WIN case.
 182
 183 2019-06-25  Tom Tromey  <tom@tromey.com>
 184
 185         * tui/tui-data.c (tui_data_item_window): Update.
 186         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 187         * tui/tui-windata.c (tui_display_all_data)
 188         (tui_display_data_from_line): Update.
 189         (tui_check_data_values): Remove.
 190         * tui/tui-regs.c (tui_show_register_group)
 191         (tui_display_reg_element_at_line): Update.
 192         * tui/tui-hooks.c (tui_register_changed)
 193         (tui_refresh_frame_and_register_information): Call
 194         tui_check_register_values.
 195         * tui/tui-data.h (struct tui_data_window) <data_content,
 196         data_content_count, data_type>: Remove.
 197         (enum tui_data_type): Remove.
 198
 199         * tui/tui-data.c (tui_data_window::clear_detail)
 200         (~tui_data_window): Update.
 201
 202 2019-06-25  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 205         declare.
 206         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 207         Rename from tui_first_data_item_displayed.  Update.
 208         (tui_data_window::refresh_all)
 209         (tui_data_window::do_scroll_vertical): Update.
 210         * tui/tui-data.h (struct tui_data_window)
 211         <first_data_item_displayed>: Declare new method.
 212
 213 2019-06-25  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 216         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 217         contents...
 218         (tui_initialize_static_data): ...here.
 219
 220 2019-06-25  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 223         (tui_display_registers_from, tui_check_register_values): Update.
 224         (tui_display_register): Remove win_info parameter; update.
 225         (tui_get_register): Change type of parameters.
 226         * tui/tui-data.h (struct tui_data_element): Remove.
 227         (union tui_which_element) <data>: Remove.
 228         <data_window>: Change type.
 229         (struct tui_data_item_window): New.
 230         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 231         case.  Add assert.
 232         (~tui_data_item_window): New destructor.
 233         (free_content_elements): Remove DATA_ITEM_WIN case.
 234
 235 2019-06-25  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 238         Remove.
 239
 240 2019-06-25  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-data.h (struct tui_command_element): Remove.
 243         (union tui_which_element) <command>: Remove.
 244         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 245         assert.
 246         (free_content_elements): Remove CMD_WIN case.
 247
 248 2019-06-25  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-layout.c (tui_set_layout): Update.
 251         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 252         * tui/tui-data.c (layout_def): Update.
 253
 254 2019-06-25  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 257         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 258         (tui_source_window_base::set_new_height): Update.
 259         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 260         Update.
 261         (tui_set_locator_fullname, tui_set_locator_info)
 262         (tui_show_frame_info): Update.
 263         * tui/tui-source.c (tui_set_source_content)
 264         (tui_source_is_displayed): Update.
 265         * tui/tui-layout.c (show_source_disasm_command, show_data)
 266         (show_source_or_disasm_and_command): Update.
 267         * tui/tui-disasm.c (tui_set_disassem_content)
 268         (tui_get_begin_asm_address): Update.
 269         * tui/tui-data.h (struct tui_locator_element): Remove.
 270         (union tui_which_element) <locator>: Remove.
 271         (struct tui_locator_window): New.
 272         (tui_locator_win_info_ptr): Change return type.
 273         * tui/tui-data.c (_locator): Change type.
 274         (tui_locator_win_info_ptr): Change return type.
 275         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 276         (tui_alloc_content): Add assert.
 277
 278 2019-06-25  Tom Tromey  <tom@tromey.com>
 279
 280         * tui/tui-winsource.c
 281         (tui_exec_info_window::maybe_allocate_content): New method.
 282         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 283         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 284         (make_source_or_disasm_window): Add cast.
 285         * tui/tui-data.h (union tui_which_element) <simple_string>:
 286         Remove.
 287         (struct tui_source_info): New.
 288         (struct tui_source_window_base) <execution_info>: Change type.
 289         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 290         case, and add assert.
 291         (tui_alloc_content): Add assert.
 292
 293 2019-06-25  Tom Tromey  <tom@tromey.com>
 294
 295         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 296         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 297         * tui/tui-data.c (tui_alloc_win_info): Remove.
 298
 299 2019-06-25  Tom Tromey  <tom@tromey.com>
 300
 301         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 302         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 303         can_highlight.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 308         make_visible_with_new_height method.
 309         (tui_win_info::make_visible_with_new_height): New method.
 310         (tui_source_window_base::do_make_visible_with_new_height)
 311         (tui_data_window::do_make_visible_with_new_height)
 312         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 313         (make_visible_with_new_height): Remove.
 314         (tui_resize_all, tui_adjust_win_heights): Use
 315         make_visible_with_new_height method.
 316         * tui/tui-data.h (struct tui_win_info)
 317         <do_make_visible_with_new_height, make_visible_with_new_height>:
 318         New methods.
 319         (struct tui_source_window_base, struct tui_data_window)
 320         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 321         methods.
 322
 323 2019-06-25  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 326         method.
 327         (update_tab_width): Call update_tab_width method.
 328         * tui/tui-data.h (struct tui_win_info)
 329         (struct tui_source_window_base) <update_tab_width>: New methods.
 330
 331 2019-06-25  Tom Tromey  <tom@tromey.com>
 332
 333         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 334         parameter.
 335         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 336         parameter.
 337         (tui_gen_win_info::make_visible): Update.
 338         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 339         parameter.
 340         * tui/tui-data.h (enum tui_box): New enum.
 341         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 342
 343 2019-06-25  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 346         init_and_make_win for EXEC_INFO_WIN.
 347         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 348         longer inline.
 349         (struct tui_win_info) <~tui_win_info>: Inline.
 350         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 351         Don't declare.
 352         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 353         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 354         Remove.
 355         (tui_initialize_static_data): Update.
 356         (~tui_gen_win_info): Handle more cleanup here.
 357         (~tui_source_window_base): Delete "execution_info".
 358         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 359
 360 2019-06-25  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-layout.c (make_command_window): Don't set
 363         can_highlight.
 364         (show_source_disasm_command): Call the reset method.
 365         (show_data): Don't set can_highlight.  Call the reset method.
 366         (tui_gen_win_info::reset): Rename from init_gen_win_info
 367         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 368         (show_source_or_disasm_and_command): Call the reset method.
 369         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 370         (struct tui_cmd_window): Set can_highlight.
 371
 372 2019-06-25  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 375         from make_visible.
 376         (tui_make_visible, tui_make_invisible): Rewrite.
 377         (tui_win_info::make_visible): Remove.
 378         (tui_source_window_base::make_visible): Update.
 379         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 380         method.  Moved from...
 381         (struct tui_win_info) <make_visible>: ...here.
 382
 383 2019-06-25  Tom Tromey  <tom@tromey.com>
 384
 385         * tui/tui-winsource.c
 386         (tui_source_window_base::do_scroll_horizontal): Remove direction
 387         parameter.
 388         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 389         direction parameter.
 390         * tui/tui-win.c (tui_win_info::forward_scroll)
 391         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 392         (tui_win_info::right_scroll): Update.
 393         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 394         direction parameter.
 395         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 396         direction parameter.
 397         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 398         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 399         Remove direction parameter.
 400         (struct tui_source_window_base, struct tui_source_window)
 401         (struct tui_disasm_window, struct tui_data_window)
 402         (struct tui_cmd_window): Update.
 403
 404 2019-06-25  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-winsource.h (tui_set_exec_info_content)
 407         (tui_show_exec_info_content, tui_erase_exec_info_content)
 408         (tui_clear_exec_info_content, tui_update_exec_info): Change
 409         argument to tui_source_window_base.
 410         * tui/tui-winsource.c (tui_set_exec_info_content)
 411         (tui_show_exec_info_content, tui_erase_exec_info_content)
 412         (tui_clear_exec_info_content, tui_update_exec_info): Change
 413         argument to tui_source_window_base.
 414
 415 2019-06-25  Tom Tromey  <tom@tromey.com>
 416
 417         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 418         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 419
 420 2019-06-25  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 423         check.
 424
 425 2019-06-25  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 428         type to void.
 429         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 430         type to void.
 431         * tui/tui-source.c (tui_set_source_content): Update.
 432         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 433
 434 2019-06-25  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-win.c (window_name_completer, tui_set_focus)
 437         (tui_all_windows_info): Use name method.
 438         * tui/tui-data.h (struct tui_gen_win_info)
 439         (struct tui_source_window, struct tui_disasm_window)
 440         (struct tui_data_window, struct tui_cmd_window) <name>: New
 441         method.
 442         (tui_win_name): Don't declare.
 443         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 444         (tui_win_name): Remove.
 445
 446 2019-06-25  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-winsource.h (tui_update_source_window)
 449         (tui_update_source_window_as_is): Change parameter type.
 450         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 451         to be a tui_source_window_base.
 452         (tui_update_source_window_as_is): Likewise.
 453         * tui/tui-win.c (make_visible_with_new_height): Update.
 454
 455 2019-06-25  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-winsource.c (tui_erase_source_content)
 458         (tui_show_source_content, tui_show_exec_info_content)
 459         (tui_erase_exec_info_content): Use refresh_window method.
 460         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 461         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 462         from tui_refresh_win.
 463         (tui_data_window::refresh_window): New method.
 464         (tui_win_info::refresh, tui_source_window_base::refresh)
 465         (tui_refresh_all): Use refresh_window method.
 466         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 467         method.
 468         * tui/tui-regs.c (tui_display_register): Call refresh_window
 469         method.
 470         * tui/tui-layout.c (show_source_disasm_command)
 471         (show_source_or_disasm_and_command): Call refresh_window method.
 472         * tui/tui-data.h (struct tui_gen_win_info)
 473         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 474         New method.
 475
 476 2019-06-25  Tom Tromey  <tom@tromey.com>
 477
 478         * tui/tui.c (tui_rl_other_window, tui_enable)
 479         (tui_is_window_visible, tui_get_command_dimension): Update.
 480         * tui/tui-winsource.c (tui_update_source_window_as_is)
 481         (tui_clear_source_content, tui_erase_source_content)
 482         (tui_show_source_line, tui_source_window_base::refill)
 483         (tui_source_window_base::do_scroll_horizontal)
 484         (tui_source_window_base::set_is_exec_point_at)
 485         (tui_update_breakpoint_info, tui_set_exec_info_content)
 486         (tui_alloc_source_buffer, tui_line_is_displayed)
 487         (tui_addr_is_displayed): Update.
 488         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 489         (tui_check_and_display_highlight_if_needed)
 490         (tui_win_info::make_visible, tui_win_info::refresh)
 491         (tui_refresh_all): Update.
 492         * tui/tui-windata.c (tui_first_data_item_displayed)
 493         (tui_delete_data_content_windows, tui_erase_data_content)
 494         (tui_display_all_data, tui_data_window::refresh_all)
 495         (tui_check_data_values): Update.
 496         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 497         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 498         (tui_win_info::backward_scroll, tui_refresh_all_win)
 499         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 500         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 501         (tui_source_window_base::set_new_height)
 502         (tui_data_window::set_new_height)
 503         (make_invisible_and_set_new_height)
 504         (make_visible_with_new_height, new_height_ok)
 505         (parse_scrolling_args): Update.
 506         * tui/tui-stack.c (tui_show_frame_info): Update.
 507         * tui/tui-source.c (tui_set_source_content)
 508         (tui_set_source_content_nil, tui_source_is_displayed)
 509         (tui_source_window::do_scroll_vertical): Update.
 510         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 511         (tui_display_registers_from, tui_display_reg_element_at_line)
 512         (tui_check_register_values, tui_reg_command): Update.
 513         * tui/tui-layout.c (tui_default_win_height)
 514         (show_source_disasm_command, show_data, init_and_make_win)
 515         (show_source_or_disasm_and_command): Update.
 516         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 517         (tui_redisplay_readline, tui_mld_flush)
 518         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 519         (tui_getc): Update.
 520         * tui/tui-disasm.c (tui_set_disassem_content)
 521         (tui_disasm_window::do_scroll_vertical): Update.
 522         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 523         Now virtual.
 524         (struct tui_win_info): Derive from tui_gen_win_info.
 525         <~tui_win_info>: Mark as override.
 526         <generic>: Remove member.
 527         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 528         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 529         (~tui_data_window, ~tui_win_info)
 530         (tui_free_all_source_wins_content): Update.
 531         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 532
 533 2019-06-25  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-layout.c (init_and_make_win): Use new.
 536         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 537         destructor, initializers.
 538         (tui_alloc_generic_win_info): Don't declare.
 539         * tui/tui-data.c (_locator): Add argument to constructor.
 540         (source_win, disasm_win): New globals.
 541         (exec_info): Remove.
 542         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 543         Update.
 544         (tui_alloc_generic_win_info): Remove.
 545         (init_content_element): Use new.
 546         (tui_win_info::tui_win_info): Update.
 547         (free_content_elements) <case DATA_WIN>: Use delete.
 548
 549 2019-06-25  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 552         * tui/tui-windata.c (tui_first_data_item_displayed)
 553         (tui_delete_data_content_windows): Update.
 554         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 555         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 556         (tui_display_registers_from, tui_check_register_values): Update.
 557         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 558         pointer.
 559         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 560         window.
 561         (tui_free_data_content): Update.
 562         (free_content_elements) <case DATA_WIN>: Free the window.
 563
 564 2019-06-25  Tom Tromey  <tom@tromey.com>
 565
 566         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 567         Update.
 568         * tui/tui-layout.c (make_command_window)
 569         (show_source_disasm_command, show_data, init_and_make_win)
 570         (show_source_or_disasm_and_command): Update.
 571         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 572         method.
 573         <can_highight, is_highlighted>: Now bool.
 574         (tui_set_win_highlight): Don't declare.
 575         * tui/tui-data.c (tui_set_win_highlight): Remove.
 576
 577 2019-06-25  Tom Tromey  <tom@tromey.com>
 578
 579         * tui/tui-wingeneral.c (make_visible): Remove check of window
 580         type.
 581
 582 2019-06-25  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-win.c (tui_win_info::max_height)
 585         (tui_cmd_window::max_height): New methods.
 586         (new_height_ok): Call max_height.
 587         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 588         <max_height>: New method.
 589
 590 2019-06-25  Tom Tromey  <tom@tromey.com>
 591
 592         * tui/tui-win.c (tui_source_window_base::set_new_height)
 593         (tui_data_window::set_new_height): New methods.
 594         (make_invisible_and_set_new_height): Call set_new_height method.
 595         * tui/tui-data.h (struct tui_win_info)
 596         (struct tui_source_window_base, struct tui_data_window)
 597         <set_new_height>: New method.
 598
 599 2019-06-25  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 602         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 603         tui_refresh_data_win.
 604         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 605         method.
 606         (tui_refresh_all_win): Call the refresh_all method.
 607         (tui_set_focus): Likewise.
 608         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 609         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 610         Likewise.
 611
 612 2019-06-25  Tom Tromey  <tom@tromey.com>
 613
 614         * tui/tui-winsource.h (tui_refill_source_window)
 615         (tui_set_is_exec_point_at): Don't declare.
 616         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 617         (tui_source_window_base::refill): Rename from
 618         tui_refill_source_window.
 619         (tui_source_window_base::do_scroll_horizontal): Update.
 620         (tui_source_window_base::set_is_exec_point_at): Rename from
 621         tui_set_is_exec_point_at.
 622         (tui_update_all_breakpoint_info): Update.
 623         * tui/tui-stack.c (tui_show_frame_info): Update.
 624         * tui/tui-layout.c (show_data): Add cast.
 625         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 626         * tui/tui-data.h (struct tui_source_window_base) <refill,
 627         set_is_exec_point_at>: New methods.
 628         (tui_source_windows, tui_add_to_source_windows): Update types.
 629         (tui_add_to_source_windows): Remove redundant declaration.
 630         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 631         (tui_source_windows): Change return type.
 632         (tui_clear_source_windows_detail): Update.
 633         (tui_add_to_source_windows): Change type of parameter.
 634         (tui_free_all_source_wins_content): Update.
 635
 636 2019-06-25  Tom Tromey  <tom@tromey.com>
 637
 638         * tui/tui-wingeneral.c (tui_win_info::refresh)
 639         (tui_source_window_base::refresh): New methods.
 640         (tui_refresh_all): Call the refresh method.
 641         * tui/tui-data.h (struct tui_win_info)
 642         (struct tui_source_window_base) <refresh>: New method.
 643
 644 2019-06-25  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui.h (tui_is_window_visible): Return bool.
 647         * tui/tui.c (tui_is_window_visible): Return bool.
 648         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 649         (tui_make_visible, tui_make_invisible)
 650         (tui_win_info::make_visible)
 651         (tui_source_window_base::make_visible, make_all_visible)
 652         (tui_make_all_visible, tui_make_all_invisible): Update.
 653         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 654         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 655         bool.
 656         (struct tui_win_info, struct tui_source_window_base)
 657         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 658         * tui/tui-data.c (tui_init_generic_part): Update.
 659
 660 2019-06-25  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 663         (tui_source_window_base::make_visible): New methods.
 664         (make_all_visible): Make method call.
 665         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 666         (struct tui_source_window_base, struct tui_cmd_window): Override
 667         make_visible.
 668         (tui_win_is_source_type): Don't declare.
 669         * tui/tui-data.c (tui_win_is_source_type): Remove.
 670
 671 2019-06-25  Tom Tromey  <tom@tromey.com>
 672
 673         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 674         NULL check.
 675
 676 2019-06-25  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 679         Inline constructor.  Add initializers for members.
 680         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 681         constructors; now inline in class.
 682
 683 2019-06-25  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-regs.c (tui_show_registers): Update.
 686         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 687         bool.
 688         * tui/tui-data.c (tui_data_window::clear_detail)
 689         (tui_data_window): Update.
 690
 691 2019-06-25  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-windata.c (tui_display_all_data)
 694         (tui_display_data_from_line, tui_display_data_from)
 695         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 696         Update.
 697         * tui/tui-regs.c (tui_last_regs_line_no)
 698         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 699         (tui_show_registers, tui_show_register_group)
 700         (tui_display_registers_from, tui_display_reg_element_at_line)
 701         (tui_display_registers_from_line, tui_check_register_values)
 702         (tui_reg_next, tui_reg_prev): Update.
 703         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 704         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 705         tui_data_window.
 706         (struct tui_win_info) <detail>: Remove.  Add new fields from
 707         tui_data_info.
 708         (TUI_DATA_WIN): Add cast.
 709         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 710         (~tui_data_window): Simplify.
 711
 712 2019-06-25  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-layout.c (show_source_disasm_command)
 715         (show_source_or_disasm_and_command): Update.
 716         * tui/tui-io.c (update_cmdwin_start_line)
 717         (tui_redisplay_readline): Update.
 718         * tui/tui-data.h (struct tui_command_info): Remove.
 719         (struct tui_win_info) <detail>: Remove command_info member.
 720         (struct tui_data_window) <start_line>: New member, from
 721         tui_command_info.
 722         (TUI_CMD_WIN): Add casts.
 723
 724 2019-06-25  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-winsource.c (tui_update_source_window)
 727         (tui_refill_source_window)
 728         (tui_source_window_base::do_scroll_horizontal)
 729         (tui_update_breakpoint_info, tui_set_exec_info_content)
 730         (tui_show_exec_info_content, tui_erase_exec_info_content)
 731         (tui_clear_exec_info_content): Update.
 732         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 733         Update.
 734         * tui/tui-win.c (make_invisible_and_set_new_height)
 735         (make_visible_with_new_height): Update.
 736         * tui/tui-source.c (tui_set_source_content)
 737         (tui_show_symtab_source): Update.
 738         * tui/tui-layout.c (extract_display_start_addr)
 739         (show_source_disasm_command, show_data)
 740         (make_source_or_disasm_window)
 741         (show_source_or_disasm_and_command): Update.
 742         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 743         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 744         "gdbarch".
 745         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 746         to tui_source_window_base.
 747         (struct tui_win_info) <detail>: Remove source_info member.
 748         (struct tui_source_window_base) <has_locator>: Inline.
 749         Move contents from tui_source_info; rename has_locator member to
 750         m_has_locator.
 751         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 752         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 753         header file.
 754         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 755         Simplify.
 756         (tui_free_all_source_wins_content): Cast to
 757         tui_source_window_base.
 758
 759 2019-06-25  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-win.c (make_invisible_and_set_new_height)
 762         (make_visible_with_new_height): Call has_locator method.
 763         * tui/tui-layout.c (show_source_disasm_command, show_data)
 764         (show_source_or_disasm_and_command): Update for bool change.
 765         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 766         (tui_win_info) <has_locator>: New method.
 767         (struct tui_source_window_base) <has_locator>: New method.
 768         (tui_win_has_locator): Don't declare.
 769         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 770         from tui_win_has_locator.
 771         (tui_source_window_base): Use false, not FALSE.
 772
 773 2019-06-25  Tom Tromey  <tom@tromey.com>
 774
 775         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 776         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 777         clear_detail method directly.
 778         (tui_clear_win_detail): Remove.
 779
 780 2019-06-25  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 783         "this", not TUI_DISASM_WIN.
 784
 785 2019-06-25  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 788         declare.
 789         * tui/tui-winsource.c
 790         (tui_source_window_base::do_scroll_horizontal): Rename from
 791         tui_horizontal_source_scroll.
 792         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 793         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 794         from tui_vertical_data_scroll.
 795         * tui/tui-win.h (tui_scroll): Don't declare.
 796         * tui/tui-win.c (tui_win_info::forward_scroll)
 797         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 798         (tui_win_info::right_scroll): Rename and update.
 799         (tui_scroll_forward_command, tui_scroll_backward_command)
 800         (tui_scroll_left_command, tui_scroll_right_command): Update.
 801         (tui_scroll): Remove.
 802         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 803         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 804         from tui_vertical_source_scroll.
 805         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 806         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 807         from tui_vertical_disassem_scroll.
 808         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 809         do_scroll_horizontal>: New methods.
 810         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 811         Likewise.
 812         (struct tui_source_window_base): Add do_scroll_horizontal.
 813         (struct tui_source_window, struct tui_disasm_window): Add
 814         do_scroll_vertical.
 815         (struct tui_data_window, struct tui_cmd_window): Add
 816         do_scroll_horizontal and do_scroll_vertical.
 817         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 818
 819 2019-06-25  Tom Tromey  <tom@tromey.com>
 820
 821         * tui/tui-data.h (struct tui_source_window_base): New struct.
 822         (struct tui_source_window): Derive from tui_source_window_base.
 823         (struct tui_disasm_window): New struct.
 824         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 825         from tui_source_window::clear_detail.
 826         (tui_source_window_base): Rename from tui_source_window.
 827         (~tui_source_window_base): Rename from ~tui_source_window.
 828         (tui_alloc_win_info): Create a tui_disasm_window.
 829
 830 2019-06-25  Tom Tromey  <tom@tromey.com>
 831
 832         * tui/tui-data.h (struct tui_source_window)
 833         (struct tui_data_window): Declare destructors.
 834         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 835         destructors.
 836         (tui_win_info): Simplify.
 837
 838 2019-06-25  Tom Tromey  <tom@tromey.com>
 839
 840         * tui/tui-winsource.c (tui_display_main)
 841         (tui_update_source_windows_with_addr)
 842         (tui_update_all_breakpoint_info): Update.
 843         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 844         (new_height_ok, parse_scrolling_args): Update.
 845         * tui/tui-stack.c (tui_show_frame_info): Update.
 846         * tui/tui-data.h (struct tui_list): Remove.
 847         (tui_source_windows): Return a reference to a std::vector.
 848         * tui/tui-data.c (source_windows): Now a std::vector.
 849         (tui_source_windows): Change return type.
 850         (tui_clear_source_windows): Rewrite.
 851         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 852         (tui_free_all_source_wins_content): Rewrite.
 853
 854 2019-06-25  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 857         (struct tui_data_window, struct tui_cmd_window): Declare
 858         clear_detail method.
 859         * tui/tui-data.c (tui_source_window::clear_detail)
 860         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 861         methods.
 862         (tui_clear_win_detail): Simplify.
 863
 864 2019-06-25  Tom Tromey  <tom@tromey.com>
 865
 866         * tui/tui-layout.c (make_source_window, make_disasm_window)
 867         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 868         Return the new window.
 869         (show_source_disasm_command, show_data)
 870         (show_source_or_disasm_and_command): Update.
 871
 872 2019-06-25  Tom Tromey  <tom@tromey.com>
 873
 874         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 875         parameter.  Return the new window.
 876         (show_source_disasm_command): Update and remove NULL check.
 877         (show_source_or_disasm_and_command): Update.
 878
 879 2019-06-25  Tom Tromey  <tom@tromey.com>
 880
 881         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 882
 883 2019-06-25  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui-data.h (struct tui_win_info): Make constructor
 886         protected.  Make destructor virtual.  Add initializers.
 887         (tui_source_window, tui_data_window, tui_cmd_window): New
 888         classes.
 889         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 890         constructor.  Add "type" parameter.
 891         (tui_source_window, tui_data_window, tui_cmd_window): New
 892         constructors.
 893         (tui_alloc_win_info): Instantiate the appropriate subclass.
 894
 895 2019-06-25  Tom Tromey  <tom@tromey.com>
 896
 897         * tui/tui-win.c (tui_resize_all): Use delete.
 898         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 899         destructor.
 900         (tui_free_window): Don't declare.
 901         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 902         Update.
 903
 904 2019-06-25  Tom Tromey  <tom@tromey.com>
 905
 906         * tui/tui-data.h (struct tui_win_info): Add constructor.
 907         * tui/tui-data.c (tui_alloc_win_info): Use new.
 908         (tui_free_window): Use delete.
 909
 910 2019-06-22  Tom Tromey  <tom@tromey.com>
 911
 912         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 913         declare.
 914         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 915
 916 2019-06-22  Tom Tromey  <tom@tromey.com>
 917
 918         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 919         declare.
 920         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 921
 922 2019-06-22  Tom de Vries  <tdevries@suse.de>
 923
 924         * dwarf2read.c (create_addrmap_from_aranges)
 925         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 926         instead of '%zu'.
 927
 928 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 929
 930         * dwarf2read.h (dwarf2_section_info_def): Remove.
 931         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 932         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 933         std::vector<dwarf2_section_info>.
 934         (struct dwo_file) <~dwo_file>: Remove.
 935         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 936         types field.
 937         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 938         (dwarf2_read_debug_names): Likewise.
 939         (create_debug_types_hash_table): Change parameter type to
 940         array_view, adjust code accordingly.
 941         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 942         (partial_die_info::fixup): Likewise.
 943         (determine_prefix): Likewise.
 944         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 945
 946 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 947
 948         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 949         gdb_bfd_ref_ptr.
 950         <~dwo_file>: Remove call to gdb_bfd_unref.
 951         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 952         gdb_bfd_ref_ptr::get.
 953
 954 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 955
 956         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 957         type to htab_up.
 958         * dwarf2read.c (struct dwo_file): Initialize fields.
 959         <~dwo_file>: New.
 960         (free_dwo_file): Remove, move content to ~dwo_file.
 961         (struct dwo_file_deleter): Remove.
 962         (dwo_file_up>: Remove custom deleter.
 963         (free_dwo_files): Remove.
 964         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 965         dwo_files.
 966         (process_skeletonless_type_units): Call unique_ptr::get.
 967         (allocate_dwo_file_hash_table): Add deleter to created hash
 968         table.  Change return type to htab_up.
 969         (lookup_dwo_file_slot): Don't memset dwo_file, call
 970         unique_ptr::get.
 971         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 972         (create_dwo_unit_in_dwp_v2): Likewise.
 973         (open_and_init_dwo_file): Likewise.
 974         (free_dwo_file_from_slot): Remove.
 975
 976 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 977
 978         * dwarf2read.h (struct dwarf2_section_info) <readin,
 979         is_virtual>: Change type to bool.
 980         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 981         true instead of 1.
 982
 983 2019-06-19  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-data.h (tui_init_content_element): Don't declare.
 986
 987 2019-06-19  Tom Tromey  <tom@tromey.com>
 988
 989         * tui/tui-data.h (tui_init_win_info): Don't declare.
 990
 991 2019-06-19  Tom de Vries  <tdevries@suse.de>
 992
 993         * dwarf2read.h (abstract_to_concrete): Change type to
 994         std::unordered_map<sect_offset, std::vector<sect_offset>,
 995         gdb::hash_enum<sect_offset>>.
 996
 997 2019-06-19  Tom Tromey  <tromey@adacore.com>
 998
 999         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1000         EVAL_AVOID_SIDE_EFFECTS specially.
1001
1002 2019-06-19  Tom Tromey  <tromey@adacore.com>
1003
1004         * source-cache.c (highlighter): New global.
1005         (source_cache::get_source_lines): Create a highlighter on demand.
1006
1007 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1008
1009         * defs.h (deprecated_interactive_hook): Delete declaration.
1010         * interps.c (clear_interpreter_hooks): Remove use of
1011         deprecated_interactive_hook.
1012         * top.c (deprecated_interactive_hook): Delete definition.
1013         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1014
1015 2019-06-18  Tom de Vries  <tdevries@suse.de>
1016
1017         PR gdb/24515
1018         * dwarf2read.h (abstract_to_concrete): Change type from
1019         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1020         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1021         * dwarf2read.c (read_variable): Update.
1022         (dwarf2_fetch_die_loc_sect_off): Update.
1023
1024 2019-06-17  Tom de Vries  <tdevries@suse.de>
1025
1026         PR gdb/24617
1027         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1028         accessing parent[parent_len - 1].
1029
1030 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1031
1032         PR gdb/24364
1033         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1034         call dtrace_process_dof with NULL dof.
1035
1036 2019-06-16  Tom de Vries  <tdevries@suse.de>
1037
1038         PR gdb/24445
1039         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1040
1041 2019-06-16  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1044         (make_all_visible): Use address of member.
1045
1046 2019-06-16  Tom Tromey  <tom@tromey.com>
1047
1048         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1049         (tui_free_window, free_content, free_content_elements): Remove
1050         unnecessary cast.
1051         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1052         cast.
1053         * tui/tui-regs.c (tui_show_register_group)
1054         (tui_display_registers_from, tui_display_reg_element_at_line):
1055         Remove unnecessary cast.
1056
1057 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * linux-nat.c (normal_mask): Delete.
1060         (_initialize_linux_nat): Don't initialise normal_mask.
1061
1062 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1063
1064         PR gdb/24445
1065         * dwarf-index-write.h (write_psymtabs_to_index): Add
1066         dwz_basename parameter.
1067         * dwarf-index-write.c (write_gdbindex): Move file writing to
1068         write_gdbindex_1.  Change return type void.
1069         (assert_file_size): Move up, remove filename parameter.
1070         (write_gdbindex_1): New function.
1071         (write_debug_names): Change return type to void, call
1072         assert_file_size.
1073         (struct index_wip_file): New struct.
1074         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1075         file logic to index_wip_file.  Write index for dwz file if
1076         needed.
1077         (save_gdb_index_command): Pass basename of dwz file, if present.
1078         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1079         build-id of dwz file, if present.
1080         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1081         (dwarf2_get_dwz_file): Likewise.
1082         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1083         (dwarf2_get_dwz_file): Likewise.
1084
1085 2019-06-16  Tom Tromey  <tom@tromey.com>
1086
1087         * coffread.c (process_coff_symbol): Use xstrdup.
1088         * value.c (create_internalvar): Use xstrdup.
1089
1090 2019-06-16  Tom Tromey  <tom@tromey.com>
1091
1092         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1093         * breakpoint.c (stopin_command, stopat_command)
1094         (until_break_command, decode_location_default): Remove unnecessary
1095         cast.
1096         * utils.c (subset_compare): Remove unnecessary cast.
1097         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1098         cast.
1099         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1100         cast.
1101         * infcmd.c (path_command): Remove unnecessary cast.
1102         * coffread.c (decode_type): Remove unnecessary cast.
1103         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1104         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1105         * tui/tui-stack.c (tui_show_locator_content)
1106         (tui_show_frame_info): Remove unnecessary cast.
1107         * tui/tui-win.c (tui_scroll_forward_command)
1108         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1109         (parse_scrolling_args): Remove unnecessary cast.
1110         * tui/tui-data.c (init_win_info, tui_del_window)
1111         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1112         (free_content_elements): Remove unnecessary cast.
1113         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1114         unnecessary cast.
1115         * tui/tui-source.c (tui_set_source_content)
1116         (tui_vertical_source_scroll): Remove unnecessary cast.
1117         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1118         cast.
1119         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1120         * tui/tui-regs.c (tui_display_registers_from)
1121         (tui_display_register): Remove unnecessary cast.
1122         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1123         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1124         (make_visible): Remove unnecessary cast.
1125         * tui/tui-winsource.c (tui_erase_source_content)
1126         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1127         unnecessary cast.
1128         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1129         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1130         * stabsread.c (read_type, read_array_type, read_range_type):
1131         Remove unnecessary cast.
1132         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1133         (parse_symbol, parse_type, upgrade_type, parse_external)
1134         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1135         unnecessary cast.
1136         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1137
1138 2019-06-16  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-data.c (tui_alloc_generic_win_info)
1141         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1142         checks.
1143
1144 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1145             Andrew Burgess  <andrew.burgess@embecosm.com>
1146
1147         * f-typeprint.c (f_print_type): Don't return early for not
1148         associated or not allocated types.
1149         (f_type_print_varspec_suffix): Add print_rank parameter and print
1150         ranks of array types in case they dangling.
1151         (f_type_print_base): Add print_rank parameter.
1152
1153 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1154
1155         * NEWS: Mention new MI commands.
1156         * break-catch-throw.c (enum exception_event_kind): Move to
1157         breakpoint.h.
1158         (print_mention_exception_catchpoint): Output text as a single
1159         message.
1160         (catch_exception_command_1): Rename to...
1161         (catch_exception_event): ...this, make non-static, update header
1162         command, and change some parameter types.
1163         (catch_catch_command): Update for changes to
1164         catch_exception_command_1.
1165         (catch_throw_command): Likewise.
1166         (catch_rethrow_command): Likewise.
1167         * breakpoint.c (enum exception_event_kind): Delete.
1168         * breakpoint.h (enum exception_event_kind): Moved here from
1169         break-catch-throw.c.
1170         (catch_exception_event): Declare.
1171         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1172         (mi_cmd_catch_throw): New function.
1173         (mi_cmd_catch_rethrow): New function.
1174         (mi_cmd_catch_catch): New function.
1175         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1176         'catch-catch' entries.
1177         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1178         (mi_cmd_catch_rethrow): Declare.
1179         (mi_cmd_catch_catch): Declare.
1180
1181 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1182
1183         * annotate.c (annotate_source_line): Change return type to void,
1184         update implementation to match.
1185         * annotate.h (annotate_source_line): Change return type to void,
1186         update header comment.
1187         * stack.c (print_frame_info): Don't change what frame information
1188         is printed based on whether annotations are on or not.
1189
1190 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1191
1192         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1193         (annotate_source): Make static.
1194         (annotate_source_line): Moved from source.c and renamed from
1195         identify_source_line.  Update the return type.
1196         * annotate.h (annotate_source): Delete declaration.
1197         (annotate_source_line): Declaration moved from source.h, and
1198         renamed from identify_source_line.  Return type updated.
1199         * source.c (identify_source_line): Moved to annotate.c and renamed
1200         to annotate_source_line.
1201         (info_line_command): Remove check of annotation_level.
1202         * source.h (identify_source_line): Move declaration to annotate.h
1203         and rename to annotate_source_line.
1204         * stack.c: Add 'annotate.h' include.
1205         (print_frame_info): Remove check of annotation_level before
1206         calling annotate_source_line.
1207
1208 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * source-cache.c (source_cache::get_plain_source_lines): Use
1211         open_source_file_with_line_charpos instead of just
1212         open_source_file, remove call to find_source_lines.
1213         (source_cache::get_source_lines): Likewise.
1214         * source.c (find_source_lines): Make static.
1215         (get_filename_and_charpos): Renamed into...
1216         (open_source_file_with_line_charpos): ..this along with changes to
1217         return a scoped_fd, and some other minor clean ups.
1218         (identify_source_line): Use open_source_file_with_line_charpos.
1219         (search_command_helper): Use open_source_file_with_line_charpos
1220         instead of just open_source_file, remove call to
1221         find_source_lines.
1222         * source.h (open_source_file_with_line_charpos): Declare new
1223         function.
1224         (find_source_lines): Delete declaration.
1225
1226 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * source.c (get_filename_and_charpos): Remove fullname
1229         parameter.
1230         (identify_source_line): Update call to get_filename_and_charpos.
1231
1232 2019-06-14  Tom Tromey  <tromey@adacore.com>
1233
1234         PR gdb/24502:
1235         * ui-style.h (skip_ansi_escape): Update comment.
1236         * ui-file.h (class no_terminal_escape_file): New class.
1237         * ui-file.c (no_terminal_escape_file::write)
1238         (no_terminal_escape_file::puts): New methods.
1239         * cli/cli-logging.c (handle_redirections): Use
1240         no_terminal_escape_file.
1241
1242 2019-06-14  Tom Tromey  <tromey@adacore.com>
1243
1244         * NEWS: Move convenience variable news above Python news.
1245
1246 2019-06-14  Tom Tromey  <tom@tromey.com>
1247
1248         * gnulib: Move directory to top-level.
1249         * configure.ac: Don't configure gnulib.
1250         * configure: Rebuild.
1251         * common/common-defs.h: Use new path to gnulib.
1252         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1253         (GNULIB_H): Remove.
1254         (INCGNU): Look in new gnulib location.
1255         (HFILES_NO_SRCDIR): Remove gnulib files.
1256         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1257         (generated_files): Remove GNULIB_H.
1258         ($(LIBGNU), all-lib): Remove targets.
1259         (distclean): Don't mention GNULIB_BUILDDIR.
1260         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1261
1262 2019-06-14  Tom Tromey  <tromey@adacore.com>
1263
1264         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1265         Warn if symbol file does not provide any symbols.
1266
1267 2019-06-14  Tom Tromey  <tromey@adacore.com>
1268
1269         * source.c (find_and_open_source): Respect basenames_may_differ.
1270
1271 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * annotate.c (annotate_breakpoints_invalid): Make use of
1274         scoped_restore_terminal_state.
1275         (annotate_frames_invalid): Likewise.
1276
1277 2019-06-14  Tom Tromey  <tromey@adacore.com>
1278
1279         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1280         allow assignment to an internalvar.
1281
1282 2019-06-14  Tom Tromey  <tromey@adacore.com>
1283
1284         * ada-lex.l: Allow "_" in attribute names.
1285
1286 2019-06-14  Tom Tromey  <tromey@adacore.com>
1287
1288         PR gdb/24653:
1289         * regcache.c (registers_changed): Don't call alloca.
1290         * top.c (execute_command): Don't call alloca.
1291
1292 2019-06-13  Pedro Alves  <palves@redhat.com>
1293
1294         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1295         'expression'.  When parsing an expression, error out if there's
1296         junk after "unlimited".
1297         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1298         (do_set_command): Adjust calls to is_unlimited_literal.
1299
1300 2019-06-13  Pedro Alves  <palves@redhat.com>
1301
1302         * compile/compile.c (make_compile_options_def_group): Add braces
1303         around array_view initializer.
1304         * thread.c (make_thread_apply_all_options_def_group)
1305         (make_thread_apply_all_options_def_group): Likewise.
1306
1307 2019-06-13  Pedro Alves  <palves@redhat.com>
1308
1309         * NEWS (New commands): Mention "maint test-options
1310         require-delimiter", "maint test-options unknown-is-error", "maint
1311         test-options unknown-is-operand" and "maint show
1312         test-options-completion-result".
1313         (New command options, command completion): New section.
1314         (Completion improvements): New section.
1315         Mention that you can abbreviate "unlimited".
1316
1317 2019-06-13  Pedro Alves  <palves@redhat.com>
1318
1319         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1320         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1321         * unittests/cli-utils-selftests.c (test_parse_flags)
1322         (test_parse_flags_qcs): Delete.
1323         (test_cli_utils): Don't call deleted functions.
1324
1325 2019-06-13  Pedro Alves  <palves@redhat.com>
1326
1327         * thread.c: Include "cli/cli-option.h".
1328         (tp_array_compar_ascending): Global.
1329         (tp_array_compar): Delete function.
1330         (tp_array_compar_ascending, tp_array_compar_descending): New
1331         functions.
1332         (ascending_option_def, qcs_flag_option_def)
1333         (thr_qcs_flags_option_defs)
1334         (make_thread_apply_all_options_def_group)
1335         (make_thread_apply_options_def_group): New.
1336         (thread_apply_all_command): Use gdb::option::process_options.
1337         (thread_apply_command_completer)
1338         (thread_apply_all_command_completer): New.
1339         (thread_apply_command): Use gdb::option::process_options.
1340         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1341         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1342         to generate help text of "thread apply".  Adjust "taas"'s help.
1343         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1344         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1345
1346 2019-06-13  Pedro Alves  <palves@redhat.com>
1347
1348         * thread.c (thread_apply_command): Check for invalid TID with
1349         isdigit instead of !isalpha.
1350
1351 2019-06-13  Pedro Alves  <palves@redhat.com>
1352
1353         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1354         (validate_flags_qcs): New.
1355         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1356         (validate_flags_qcs): Declare.
1357         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1358         (make_frame_apply_options_def_group): New.
1359         (frame_apply_command_count): Process options with
1360         gdb::option::process_options.
1361         (frame_apply_completer): New.
1362         (frame_apply_level_completer, frame_apply_all_completer)
1363         (frame_apply_completer): New.
1364         (_initialize_stack): Update help of "frame apply", "frame apply
1365         level", "frame apply all" and "faas" to mention supported options
1366         and install command completers.
1367         * stack.h (frame_apply_all_completer): Declare.
1368         * thread.c: Include "stack.h".
1369         (tfaas_command): Add "--".
1370         (_initialize_thread): Update help "tfaas" to mention supported
1371         options and install command completer.
1372
1373 2019-06-13  Pedro Alves  <palves@redhat.com>
1374
1375         * completer.c (complete_nested_command_line): New.
1376         (gdb_completion_word_break_characters_throw): Add assertion.
1377         * completer.h (complete_nested_command_line): Declare.
1378
1379 2019-06-13  Pedro Alves  <palves@redhat.com>
1380
1381         * stack.c (parse_backtrace_qualifiers): New.
1382         (backtrace_command): Use it.
1383         (backtrace_command_completer): Complete on qualifiers.
1384
1385 2019-06-13  Pedro Alves  <palves@redhat.com>
1386
1387         * frame.c: Include "cli/cli-option.h.
1388         (user_set_backtrace_options): New.
1389         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1390         Delete.
1391         (get_prev_frame): Adjust.
1392         (boolean_option_def, uinteger_option_def)
1393         (set_backtrace_option_defs): New.
1394         (_initialize_frame): Adjust and use
1395         gdb::option::add_setshow_cmds_for_options to install "set
1396         backtrace past-main" and "set backtrace past-entry".
1397         * frame.h: Include "cli/cli-option.h".
1398         (struct frame_print_options): Forward declare.
1399         (print_frame_arguments_all, print_frame_arguments_scalars)
1400         (print_frame_arguments_none): Declare.
1401         (print_entry_values): Delete declaration.
1402         (struct frame_print_options, user_frame_print_options): New.
1403         (struct set_backtrace_options): New.
1404         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1405         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1406         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1407         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1408         (list_args_or_locals): Add frame_print_options parameter.
1409         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1410         * python/py-framefilter.c (enumerate_args): Pass down
1411         USER_FRAME_PRINT_OPTIONS.
1412         * stack.c: Include "cli/cli-option.h".
1413         (print_frame_arguments_all, print_frame_arguments_scalars)
1414         (print_frame_arguments_none): Declare.
1415         (print_raw_frame_arguments, print_entry_values): Delete.
1416         (user_frame_print_options): New.
1417         (boolean_option_def, enum_option_def, frame_print_option_defs):
1418         New.
1419         (struct backtrace_cmd_options): New.
1420         (bt_flag_option_def): New.
1421         (backtrace_command_option_defs): New.
1422         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1423         (print_frame_arg, read_frame_arg, print_frame_args)
1424         (print_frame_info, print_frame): Add frame_print_options parameter
1425         and use it.
1426         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1427         (backtrace_command_1): Add frame_print_options and
1428         backtrace_cmd_options parameters and use them.
1429         (make_backtrace_options_def_group): New.
1430         (backtrace_command): Process command options with
1431         gdb::option::process_options.
1432         (backtrace_command_completer): New.
1433         (_initialize_stack): Extend "backtrace"'s help to mention
1434         supported options.  Install completer for "backtrace".
1435         Install some settings commands with add_setshow_cmds_for_options.
1436
1437 2019-06-13  Pedro Alves  <palves@redhat.com>
1438
1439         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1440         and that "set/show print raw frame-arguments" are now deprecated.
1441
1442         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1443         command.
1444         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1445         * stack.c (_initialize_stack): Install "set/show print
1446         raw-frame-arguments", and deprecate "set/show print raw
1447         frame-arguments".
1448         * valprint.c (_initialize_valprint): Deprecate "set/show print
1449         raw".
1450
1451 2019-06-13  Pedro Alves  <palves@redhat.com>
1452
1453         * compile/compile.c (struct compile_options): New.
1454         (compile_flag_option_def, compile_command_option_defs)
1455         (make_compile_options_def_group): New.
1456         (compile_file_command): Handle options with
1457         gdb::option::process_options.
1458         (compile_file_command_completer): New function.
1459         (compile_code_command): Handle options with
1460         gdb::option::process_options.
1461         (compile_code_command_completer): New function.
1462         (_initialize_compiler): Install completers for "compile code" and
1463         "compile file".  Mention available options in "compile code" and
1464         "compile code"'s help.
1465         * completer.c (advance_to_completion_word): New, factored out from
1466         ...
1467         (advance_to_expression_complete_word_point): ... this.
1468         (advance_to_filename_complete_word_point): New.
1469         * completer.h (advance_to_filename_complete_word_point): New
1470         declaration.
1471
1472 2019-06-13  Pedro Alves  <palves@redhat.com>
1473
1474         * compile/compile.c: Include "cli/cli-option.h".
1475         (compile_print_value): Scope data pointer is now a
1476         value_print_options pointer; adjust.
1477         (compile_print_command): Process options.  Scope data pointer is
1478         now a value_print_options pointer; adjust.
1479         (_initialize_compile): Update "compile print"'s help to include
1480         supported options.  Install a completer for "compile print".
1481         * cp-valprint.c (show_vtblprint, show_objectprint)
1482         (show_static_field_print): Delete.
1483         (_initialize_cp_valprint): Don't install "set print
1484         static-members", "set print vtbl", "set print object" here.
1485         * printcmd.c: Include "cli/cli-option.h" and
1486         "common/gdb_optional.h".
1487         (print_command_parse_format): Rework to fill in a
1488         value_print_options instead of a format_data.
1489         (print_value): Change parameter type from format_data pointer to
1490         value_print_options reference.  Adjust.
1491         (print_command_1): Process options.  Adjust to pass down a
1492         value_print_options.
1493         (print_command_completer): New.
1494         (_initialize_printcmd): Install print_command_completer as
1495         handle_brkchars completer for the "print" command.  Update
1496         "print"'s help to include supported options.
1497         * valprint.c: Include "cli/cli-option.h".
1498         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1499         here from cp-valprint.c.
1500         (boolean_option_def, uinteger_option_def)
1501         (value_print_option_defs, make_value_print_options_def_group):
1502         New.  Use gdb::option::add_setshow_cmds_for_options to install
1503         "set print elements", "set print null-stop", "set print repeats",
1504         "set print pretty", "set print union", "set print array", "set
1505         print address", "set print symbol", "set print array-indexes".
1506         * valprint.h: Include <string> and "cli/cli-option.h".
1507         (make_value_print_options_def_group): Declare.
1508         (print_value): Change parameter type from format_data pointer to
1509         value_print_options reference.
1510         (print_command_completer): Declare.
1511
1512 2019-06-13  Pedro Alves  <palves@redhat.com>
1513
1514         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1515         (COMMON_SFILES): Add maint-test-settings.c.
1516         * cli/cli-decode.c (boolean_enums): New global, factored out from
1517         ...
1518         (add_setshow_boolean_cmd): ... here.
1519         * cli/cli-decode.h (boolean_enums): Declare.
1520         * cli/cli-option.c: New file.
1521         * cli/cli-option.h: New file.
1522         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1523         factored out from ...
1524         (parse_cli_boolean_value(const char *)): ... this.
1525         (is_unlimited_literal): Change parameter type to pointer to
1526         pointer.  Adjust and advance ARG pointer.
1527         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1528         (parse_cli_var_enum): New, factored out from ...
1529         (do_set_command): ... this.  Adjust.
1530         * cli/cli-setshow.h (parse_cli_boolean_value)
1531         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1532         (parse_cli_var_enum): Declare.
1533         * cli/cli-utils.c: Include "cli/cli-option.h".
1534         (get_ulongest): New.
1535         * cli/cli-utils.h (get_ulongest): Declare.
1536         (check_for_argument): New overloads.
1537         * maint-test-options.c: New file.
1538
1539 2019-06-13  Pedro Alves  <palves@redhat.com>
1540
1541         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1542         parse a range if "-" is at the end of the string.
1543
1544 2019-06-13  Pedro Alves  <palves@redhat.com>
1545
1546         * cli/cli-setshow.c (parse_auto_binary_operation)
1547         (parse_cli_boolean_value): Don't allow "o".
1548
1549 2019-06-13  Pedro Alves  <palves@redhat.com>
1550
1551         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1552         * NEWS: Mention maint test-settings KIND.
1553         * maint-test-settings.c: New file.
1554
1555 2019-06-13  Pedro Alves  <palves@redhat.com>
1556
1557         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1558         completer.
1559         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1560         "set" completers.
1561
1562 2019-06-13  Pedro Alves  <palves@redhat.com>
1563
1564         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1565         after item.
1566
1567 2019-06-13  Pedro Alves  <palves@redhat.com>
1568
1569         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1570
1571 2019-06-13  Pedro Alves <palves@redhat.com>
1572
1573         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1574         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1575         call.
1576         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1577         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1578         calls.
1579         (check_for_argument): Skip spaces after argument.
1580
1581 2019-06-13  Pedro Alves  <palves@redhat.com>
1582
1583         * thread.c (thread_apply_command): Adjust TID parsing.
1584         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1585         detected before end of string.
1586         (tid_is_in_list): Error out if LIST is invalid.
1587
1588 2019-06-13  Pedro Alves  <palves@redhat.com>
1589
1590         * completer.c (complete_line_internal_1): Rewind completion word
1591         point.
1592         (completion_tracker::advance_custom_word_point_by): Change
1593         parameter type to int.
1594         * completer.h (completion_tracker::advance_custom_word_point_by):
1595         Likewise.
1596
1597 2019-06-13  Pedro Alves  <palves@redhat.com>
1598
1599         * completer.c (advance_to_completion_word): Handle delimiters.
1600
1601 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1602
1603         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1604
1605 2019-06-11  Tom Tromey  <tom@tromey.com>
1606
1607         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1608         (xmalloc_failed): Move to alloc.c.
1609         * alloc.c: New file.
1610         * Makefile.in (COMMON_SFILES): Add alloc.c.
1611
1612 2019-06-11  Tom Tromey  <tom@tromey.com>
1613
1614         * nat/linux-waitpid.c: Don't include server.h.
1615         (linux_debug): Remove.
1616         (my_waitpid): Update.
1617
1618 2019-06-11  Tom Tromey  <tromey@adacore.com>
1619
1620         * infcall.c (_initialize_infcall): Remove trailing newline from
1621         help.
1622         * user-regs.c (_initialize_user_regs): Remove trailing newline
1623         from help.
1624         * typeprint.c (_initialize_typeprint): Remove trailing newline
1625         from help.
1626         * reverse.c (_initialize_reverse): Remove trailing newlines from
1627         help.
1628         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1629         from help.
1630         * language.c (add_set_language_command): Remove trailing newline
1631         from help.
1632         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1633         help.
1634         * disasm.c (_initialize_disasm): Remove trailing newline from
1635         help.
1636         * top.c (init_main): Remove trailing newline from help.
1637         * interps.c (_initialize_interpreter): Remove trailing newline
1638         from help.
1639         * btrace.c (_initialize_btrace): Remove trailing newlines from
1640         help.
1641         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1642         from help.
1643         * python/python.c (_initialize_python): Remove trailing newline
1644         from help.
1645         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1646         help.
1647         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1648         from help.  Reformat some text.
1649         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1650         from help.
1651         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1652         newline from help.
1653
1654 2019-06-11  Tom Tromey  <tromey@adacore.com>
1655
1656         * darwin-nat.c (darwin_decode_exception_message)
1657         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1658
1659 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1660
1661         * valops.c (value_slice): Check for not allocated or not
1662         associated values.
1663
1664 2019-06-10  Tom de Vries  <tdevries@suse.de>
1665
1666         PR gdb/24618
1667         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1668         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1669         invalid.
1670
1671 2019-06-10  Tom de Vries  <tdevries@suse.de>
1672
1673         PR gdb/24611
1674         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1675         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1676
1677 2019-06-10  Tom de Vries  <tdevries@suse.de>
1678
1679         PR symtab/24545
1680         * symtab.c (struct demangled_name_entry): Add language field.
1681         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1682         static minimal symbol".  Set and use language field.
1683
1684 2019-06-10  Tom Tromey  <tromey@adacore.com>
1685
1686         * ada-lang.c (_initialize_ada_language): Update help text.
1687
1688 2019-06-10  Tom Tromey  <tromey@adacore.com>
1689
1690         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1691         with a newline.
1692         * guile/guile.c (handle_boot_error): Don't end warning with a
1693         newline.
1694         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1695         warning with a newline.
1696         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1697         newline.
1698         (s12z_frame_cache): Likewise.
1699         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1700         a newline.
1701         * solib-svr4.c (disable_probes_interface): Don't end warning with
1702         a newline.
1703         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1704         newline.
1705         * python/python.c (do_finish_initialization): Don't end warning
1706         with a newline.
1707
1708 2019-06-10  Tom Tromey  <tom@tromey.com>
1709
1710         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1711         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1712         gdbpy_enter.
1713
1714 2019-06-10  Tom Tromey  <tromey@adacore.com>
1715
1716         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1717         data.
1718         (elf_new_init): Don't call stabsread_new_init.
1719         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1720         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1721         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1722
1723 2019-06-10  Tom de Vries  <tdevries@suse.de>
1724
1725         PR symtab/16264
1726         PR symtab/24517
1727         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1728
1729 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1730
1731         * source.c (find_and_open_source): Also rewrite relative file
1732         names.
1733
1734 2019-04-26  Amos Bird  <amosbird@gmail.com>
1735
1736         * annotate.c (annotate_thread_exited): Add "thread-exited"
1737         annotation.
1738
1739 2019-06-06  Tom Tromey  <tromey@adacore.com>
1740
1741         * maint.h (class scoped_command_stats): Use
1742         DISABLE_COPY_AND_ASSIGN.
1743         <print_time>: New method.
1744         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1745         print_time.
1746         (scoped_command_stats::print_time): New method.
1747
1748 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1751         instructions of lengths 6 or 8 bytes.
1752
1753 2019-06-04  Pedro Alves  <palves@redhat.com>
1754
1755         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1756
1757         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1758         * breakpoint.c (condition_completer): Likewise.
1759         * cli/cli-dump.c (scan_expression): Likewise.
1760         * common/filestuff.c (mkdir_recursive): Likewise.
1761         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1762         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1763         (gdb_abspath): Likewise.
1764         * compile/compile-cplus-types.c
1765         (compile_cplus_instance::decl_name): Likewise.
1766         * completer.c (complete_explicit_location):
1767         (signal_completer, reg_or_group_completer_1): Likewise.
1768         * cp-support.c (cp_remove_params_if_any): Likewise.
1769         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1770         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1771         * infcmd.c (strip_bg_char): Likewise.
1772         * linespec.c (copy_token_string): Likewise.
1773         * mi/mi-main.c (output_cores): Likewise.
1774         * psymtab.c (psymtab_search_name):
1775         * symfile.c (test_set_ext_lang_command): Likewise.
1776         * target.c (target_fileio_read_stralloc): Likewise.
1777         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1778         * value.c (complete_internalvar): Likewise.
1779
1780 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1781
1782         Add objfile property to gdb.Type.
1783         * NEWS: Mention Python API addition.
1784         * python/py-type.c (typy_get_objfile): New method.
1785
1786 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1787
1788         * NEWS: Mention the new set|show style [title|highlight].
1789         Mention changes to "show style", "help" and "apropos".
1790
1791 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1792
1793         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1794         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1795         instead of print_help_for_command.
1796         (print_doc_of_command): New function.
1797         (help_list): Add 'apropos -v word' suggestion.
1798         (print_help_for_command): Style the command name using title style.
1799         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1800         (_initialize_cli_cmds): Describe -v in apropos_command help.
1801
1802 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1803
1804         * cli/cli-style.h (cli_style_option): Add name in constructor,
1805         add m_name class member, add constructor with intensity,
1806         add name class function.
1807         (cli_style_option::add_setshow_commands): Remove name argument.
1808         (highlight_style, title_style): New styles.
1809         * cli/cli-style.c (do_show): New function that shows a style
1810         characteristic styling the style name with itself.
1811         (set_style_name): New function.
1812         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1813         Update all callers according to the changes in cli/cli-style.h.
1814         * utils.h (fputs_highlighted): New function.
1815         * utils.c (fputs_highlighted): Likewise.
1816
1817 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1818
1819         * NEWS: Mention new pipe command and new convenience variables.
1820
1821 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1822
1823         * cli/cli-cmds.c (pipe_command): New function.
1824         (_initialize_cli_cmds): Call add_com for pipe_command.
1825         Define | as an alias for pipe.
1826         (exit_status_set_internal_vars): New function.
1827         (shell_escape): Call exit_status_set_internal_vars.
1828         cli/cli-decode.c (find_command_name_length): Recognize | as
1829         a single character command.
1830
1831 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1832
1833         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1834         top.c (execute_command_to_ui_file): New function, mostly a copy
1835         of execute_command_to_string.
1836         (execute_command_to_string): Implement by calling
1837         execute_command_to_ui_file.
1838
1839 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1840
1841         * top.h (saved_command_line): Remove declaration.
1842         * top.c (previous_saved_command_line, previous_repeat_arguments):
1843         New variables.
1844         (saved_command_line): Make static, define together with other
1845         'repeat variables'.
1846         (dont_repeat): Clear repeat_arguments.
1847         (repeat_previous, get_saved_command_line, save_command_line):
1848         New functions.
1849         (gdb_init): Initialize saved_command_line
1850         and previous_saved_command_line.
1851         * main.c (captured_main_1): Remove saved_command_line initialization.
1852         * event-top.c (handle_line_of_input): Update to use
1853         the new 'repeat' related functions instead of direct access to
1854         saved_command_line.
1855         * command.h (repeat_previous, get_saved_command_line,
1856         save_command_line): New declarations.
1857         (dont_repeat): Add comment.
1858
1859 2019-05-30  Tom Tromey  <tromey@adacore.com>
1860
1861         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1862         Fix comment.
1863         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1864
1865 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1866
1867         PR cli/24587
1868         * completer.c (complete): Initialize variable word.
1869
1870 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1871
1872         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1873         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1874         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1875         'body' is NULL to the outter 'if', protecting the '!is_define'
1876         situation as well.
1877
1878 2019-05-29  Tom Tromey  <tromey@adacore.com>
1879
1880         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1881         (dwarf_unknown): New function.
1882         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1883         (dwarf_type_encoding_name): Use dwarf_unknown.
1884
1885 2019-05-29  Tom Tromey  <tromey@adacore.com>
1886
1887         PR c++/20020:
1888         * cp-valprint.c (cp_print_value_fields): Call
1889         cp_print_static_field inside "try".
1890
1891 2019-05-29  Tom Tromey  <tromey@adacore.com>
1892
1893         * inflow.c (struct terminal_info): Add default operator=.
1894         * configure: Rebuild.
1895         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1896         -Wdeprecated-copy-dtor, -Wredundant-move.
1897
1898 2019-05-29  Tom Tromey  <tromey@adacore.com>
1899
1900         * NEWS: Add entry.
1901         * infcmd.c (print_return_value_1): Handle finish_print
1902         option.
1903         (show_print_finish): New function.
1904         (_initialize_infcmd): Add "set/show print finish" commands.
1905         * valprint.c (user_print_options): Initialize new member.
1906         * valprint.h (struct value_print_options) <finish_print>: New
1907         member.
1908
1909 2019-05-28  Tom Tromey  <tromey@adacore.com>
1910
1911         * ada-lang.c (ada_remove_Xbn_suffix)
1912         (find_old_style_renaming_symbol)
1913         (parse_old_style_renaming): Remove.
1914         (ada_find_renaming_symbol): Don't call
1915         find_old_style_renaming_symbol.
1916         (ada_is_renaming_symbol): Rename from
1917         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1918         bool.  Now static.
1919         (ada_read_var_value): Update and simplify.
1920         * ada-exp.y (write_var_or_type): Remove old code.
1921
1922 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1923
1924         * event-top.c: Remove include comment.
1925         * inflow.c (class scoped_ignore_sigttou): Move from here...
1926         * inflow.h (class scoped_ignore_sigttou): ...to here.
1927         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1928         * top.c:  Remove include comment.
1929
1930 2019-05-27  Tom Tromey  <tom@tromey.com>
1931
1932         * NEWS: Fix typo.
1933
1934 2019-05-22  Tom Tromey  <tromey@adacore.com>
1935
1936         * target.c (target_follow_exec): Constify parameter.
1937         * target-delegates.c: Rebuild.
1938         * remote.c (remote_target::follow_exec): Constify parameter.
1939         * infrun.c (follow_exec): Constify parameter.
1940         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1941         (target_follow_exec): Likewise.
1942
1943 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1944
1945         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1946         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1947
1948 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1949
1950         * NEWS: Add debugredirect and testsuite sections.
1951
1952 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1953
1954         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1955         target descriptions using exclusively floating point register name
1956         aliases.
1957
1958 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1959
1960         PR gdb/18644:
1961         * f-lang.c (build_fortran_types): Handle the case where
1962         gdbarch_floatformat_for_type returns a nullptr.
1963
1964 2019-05-21  Tom de Vries  <tdevries@suse.de>
1965
1966         PR cli/24587
1967         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1968
1969 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1970
1971         PR gdb/18644:
1972         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1973         16-byte floats.
1974         * i386-tdep.c (i386_floatformat_for_type): Use
1975         floatformats_ia64_quad for the 16-byte floating point component
1976         within a fortran 32-byte complex number.
1977
1978 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1979
1980         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1981         delete default constructor.
1982         (find_partial_die): Update to return const struct.
1983         (partial_die_parent_scope): Move variable declaration into scope
1984         of its use and change its type to auto.
1985         (guess_partial_die_structure_name): Likewise.
1986         (partial_die_info::fixup): Likewise.
1987
1988 2019-05-17  Tom Tromey  <tromey@adacore.com>
1989
1990         * source.c (find_and_open_source): Remove cast.
1991
1992 2019-05-17  Tom Tromey  <tromey@adacore.com>
1993
1994         * annotate.c (annotate_source): Make "filename" const.
1995         * annotate.h (annotate_source): Use const.
1996
1997 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1998
1999         * disasm.c (set_disassembler_options): Send errors to stderr.
2000
2001 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2002
2003         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2004         (cli_interp_base::set_logging): Check debug_redirect.
2005         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2006         * cli/cli-logging.c (debug_redirect): Add static variable.
2007         (pop_output_files): Add default param.
2008         (handle_redirections): Print debug setting.
2009         (show_logging_command): Likewise.
2010         (_initialize_cli_logging): Add debugredirect command.
2011         * interps.c (current_interp_set_logging): Add debug_redirect
2012         parameter.
2013         * interps.h (set_logging): Add debug_redirect parameter.
2014         (current_interp_set_logging): Likewise.
2015         * mi/mi-common.h: Likewise.
2016         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2017
2018 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2019             Tom Tromey  <tromey@adacore.com>
2020
2021         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2022         directly.
2023         * cli/cli-interp.h (make_logging_output): Remove declaration.
2024         * cli/cli-logging.c (make_logging_output): Remove function.
2025         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2026         directly.
2027         * ui-file.c (tee_file::tee_file): Remove bools.
2028         (tee_file::~tee_file): Remove deletes.
2029         * ui-file.h (tee_file): Remove bools.
2030
2031 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2032
2033         * mi/mi-cmds.h (mi_cmd_complete): New function.
2034         * mi/mi-main.c (mi_cmd_complete): Likewise.
2035         * mi/mi-cmds.c: Define new MI command -complete.
2036         * NEWS: Mention new -complete command.
2037
2038 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2039
2040         * completer.h (complete): New function.
2041         * completer.c (complete): Likewise.
2042         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2043         function defined in completer.h.
2044
2045 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2046
2047         * MAINTAINERS (Write After Approval): Add myself.
2048
2049 2019-05-17  Tom de Vries  <tdevries@suse.de>
2050
2051         PR gdb/24094
2052         * dwarf2read.c (struct cu_partial_die_info): New struct.
2053         (find_partial_die): Return cu_partial_die_info.
2054         (partial_die_parent_scope, guess_partial_die_structure_name)
2055         (partial_die_info::fixup): Handle new return type of find_partial_die.
2056
2057 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2058
2059         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2060         "std::string", simplifying the algorithm.
2061
2062 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2063
2064         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2065         (stap_static_probe_ops::get_probes): Likewise.
2066
2067 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2068
2069         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2070         '-')" and "else if".
2071         (stap_parse_single_operand): Join checks for
2072         "gdbarch_stap_parse_special_token_p" and
2073         "gdbarch_stap_parse_special_token" in the same "if" statement.
2074         Invert check when verifying for operation on register
2075         displacement.
2076
2077 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2078
2079         * stap-probe.c (stap_get_opcode): Update comment.
2080         (stap_get_expected_argument_type): Likewise.
2081         (handle_stap_probe): Likewise.
2082
2083 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2084
2085         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2086         return type to 'bool'.  Adjust comment.  Use 'bool' when
2087         appropriate.
2088         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2089         * stap-probe.c (stap_parse_argument_1): Likewise.
2090         (stap_is_operator): Likewise.
2091         (stap_is_generic_prefix): Likewise.
2092         (stap_is_register_prefix): Likewise.
2093         (stap_is_register_indirection_prefix): Likewise.
2094         (stap_is_integer_prefix): Likewise.
2095         (stap_generic_check_suffix): Likewise.
2096         (stap_check_integer_suffix): Likewise.
2097         (stap_check_register_suffix): Likewise.
2098         (stap_check_register_indirection_suffix): Likewise.
2099         (stap_parse_register_operand): Likewise.
2100         (stap_parse_single_operand): Likewise.
2101         (stap_parse_argument_1): Likewise.
2102         (stap_probe::get_argument_count): Likewise.
2103         (stap_is_operator): Likewise.
2104
2105 2019-05-16  Tom Tromey  <tromey@adacore.com>
2106
2107         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2108         keyword to foreach.
2109
2110 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2111
2112         * linux-thread-db.c (try_thread_db_load_1): Change return type
2113         to bool.
2114         (try_thread_db_load): Likewise.
2115         (try_thread_db_load_from_pdir_1): Likewise.
2116         (try_thread_db_load_from_pdir): Likewise.
2117         (try_thread_db_load_from_sdir): Likewise.
2118         (try_thread_db_load_from_dir): Likewise.
2119         (thread_db_load_search): Likewise.
2120         (has_libpthread): Likewise.
2121         (thread_db_load): Likewise.
2122
2123 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2124
2125         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2126         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2127         NULL, and complain/return if that's the case.
2128
2129 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2130
2131         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2132         (advance, posn, abstract_read_memory): New functions.
2133         [struct mem_read_abstraction]: New struct.
2134         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2135
2136 2019-05-14  Tom Tromey  <tromey@adacore.com>
2137
2138         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2139         value is not lval_memory.
2140
2141 2019-05-14  Tom Tromey  <tromey@adacore.com>
2142
2143         * solib.c (info_sharedlibrary_command): Style the file name.
2144
2145 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2146
2147         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2148         (aarch64_vnv_type): Likewise.
2149         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2150         * common/tdesc.c: Likewise.
2151         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2152         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2153         * features/aarch64-fpu.xml: Add ieee half view.
2154         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2155         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2156         * gdbtypes.h (struct builtin_type): Likewise.
2157         (struct objfile_type): Likewise.
2158
2159 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2160
2161         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2162         typo.
2163         * location.h (string_to_event_location): Likewise.
2164
2165 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2166
2167         GDB 8.3 released.
2168
2169 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2170
2171         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2172         New variable declaration.
2173         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2174         New variable.
2175         (print_one_breakpoint): Use ui_out::test_flags and new global
2176         variable to compute use_fixed_output.
2177         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2178         Remove.
2179         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2180         (mi_multi_location_breakpoint_output_fixed): Remove.
2181         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2182         new variable.
2183         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2184         fix_multi_location_breakpoint_output flag if version >= 3.
2185         * ui-out.h (enum ui_out_flag)
2186         <fix_multi_location_breakpoint_output>: New enumerator.
2187
2188 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2189
2190         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2191
2192 2019-05-10  Tom Tromey  <tromey@adacore.com>
2193
2194         * ada-lang.c (catch_ada_completer): New function.
2195         (_initialize_ada_language): Use it.
2196
2197 2019-05-10  Tom Tromey  <tromey@adacore.com>
2198
2199         * thread.c (print_thread_info): Make "requested_threads" const.
2200         * gdbthread.h (print_thread_info): Make "requested_threads"
2201         const.
2202         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2203         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2204
2205 2019-05-08  Tom Tromey  <tom@tromey.com>
2206
2207         * gdbtypes.c (objfile_type_data): Change type.
2208         (objfile_type, _initialize_gdbtypes): Update.
2209
2210 2019-05-08  Tom Tromey  <tom@tromey.com>
2211
2212         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2213         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2214         (_initialize_dwarf2_frame): Update.
2215
2216 2019-05-08  Tom Tromey  <tom@tromey.com>
2217
2218         * objc-lang.c (objc_objfile_data): Change type.
2219         (find_methods): Update.
2220         (_initialize_objc_lang): Remove.
2221
2222 2019-05-08  Tom Tromey  <tom@tromey.com>
2223
2224         * stabsread.c (rs6000_builtin_type_data): Change type.
2225         (rs6000_builtin_type, _initialize_stabsread): Update.
2226
2227 2019-05-08  Tom Tromey  <tom@tromey.com>
2228
2229         * mips-tdep.c (mips_pdr_data): Remove.
2230         (_initialize_mips_tdep): Update.
2231
2232 2019-05-08  Tom Tromey  <tom@tromey.com>
2233
2234         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2235         (hppa_init_objfile_priv_data, read_unwind_info)
2236         (find_unwind_entry, _initialize_hppa_tdep): Update.
2237
2238 2019-05-08  Tom Tromey  <tom@tromey.com>
2239
2240         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2241         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2242         on obstack.
2243         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2244
2245 2019-05-08  Tom Tromey  <tom@tromey.com>
2246
2247         * mdebugread.c (basic_type_data): Change type.
2248         (basic_type, _initialize_mdebugread): Update.
2249
2250 2019-05-08  Tom Tromey  <tom@tromey.com>
2251
2252         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2253
2254 2019-05-08  Tom Tromey  <tom@tromey.com>
2255
2256         * nto-tdep.c (nto_inferior_data_reg): Change type.
2257         (nto_inferior_data): Update.
2258         (nto_inferior_data_cleanup, nto_new_inferior_data)
2259         (_initialize_nto_tdep): Remove.
2260         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2261
2262 2019-05-08  Tom Tromey  <tom@tromey.com>
2263
2264         * ada-lang.c (struct ada_inferior_data): Add initializers.
2265         (ada_inferior_data): Change type.
2266         (ada_inferior_data_cleanup): Remove.
2267         (get_ada_inferior_data, ada_inferior_exit)
2268         (struct ada_pspace_data): Add initializers, destructor.
2269         (ada_pspace_data_handle): Change type.
2270         (get_ada_pspace_data): Update.
2271         (ada_pspace_data_cleanup): Remove.
2272
2273 2019-05-08  Tom Tromey  <tom@tromey.com>
2274
2275         * coffread.c (struct coff_symfile_info): Add initializers.
2276         (coff_objfile_data_key): Move lower.  Change type.
2277         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2278         Update.
2279         (coff_free_info): Remove.
2280
2281 2019-05-08  Tom Tromey  <tom@tromey.com>
2282
2283         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2284         (fbsd_pspace_data_handle): Move lower.  Change type.
2285         (get_fbsd_pspace_data): Update.
2286         (fbsd_pspace_data_cleanup): Remove.
2287         (_initialize_fbsd_tdep): Update.
2288
2289 2019-05-08  Tom Tromey  <tom@tromey.com>
2290
2291         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2292         (get_ada_tasks_pspace_data): Update.
2293         (ada_tasks_pspace_data_cleanup): Remove.
2294         (_initialize_tasks): Update.
2295         (ada_tasks_inferior_data_handle): Change type.
2296         (get_ada_tasks_inferior_data): Update.
2297         (ada_tasks_inferior_data_cleanup): Remove.
2298         (struct ada_tasks_pspace_data): Add initializers.
2299
2300 2019-05-08  Tom Tromey  <tom@tromey.com>
2301
2302         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2303         * symfile-debug.c (debug_sym_get_probes): Change type.
2304         * stap-probe.c (handle_stap_probe):
2305         (stap_static_probe_ops::get_probes): Change type.
2306         * probe.h (class static_probe_ops) <get_probes>: Change type.
2307         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2308         (parse_probes_in_pspace): Update.
2309         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2310         Update.
2311         (any_static_probe_ops::get_probes): Change type.
2312         * elfread.c (elfread_data): New typedef.
2313         (probe_key): Change type.
2314         (elf_get_probes): Likewise.  Update.
2315         (probe_key_free): Remove.
2316         (_initialize_elfread): Update.
2317         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2318         Change type.
2319         (dtrace_process_dof_probe, dtrace_process_dof)
2320         (dtrace_static_probe_ops::get_probe): Change type.
2321
2322 2019-05-08  Tom Tromey  <tom@tromey.com>
2323
2324         * xcoffread.c (struct xcoff_symfile_info): Rename from
2325         coff_symfile_info.  Add initializers.
2326         (xcoff_objfile_data_key): Move lower.  Change type.
2327         (XCOFF_DATA): Rewrite.
2328         (xcoff_free_info): Remove.
2329         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2330         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2331         (xcoff_initial_scan): Update.
2332
2333 2019-05-08  Tom Tromey  <tom@tromey.com>
2334
2335         * solib-svr4.c (struct svr4_info): Add initializers and
2336         destructor.
2337         <probes_table>: Now an htab_up.
2338         (solib_svr4_pspace_data): Change type.
2339         (free_probes_table): Simplify.
2340         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2341         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2342         (probes_table_remove_objfile_probes, register_solib_event_probe)
2343         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2344         (_initialize_svr4_solib): Update.
2345
2346 2019-05-08  Tom Tromey  <tom@tromey.com>
2347
2348         * remote.c (remote_pspace_data): Change type.
2349         (remote_pspace_data_cleanup): Remove.
2350         (get_remote_exec_file, set_pspace_remote_exec_file)
2351         (_initialize_remote): Update.
2352
2353 2019-05-08  Tom Tromey  <tom@tromey.com>
2354
2355         * breakpoint.c (breakpoint_objfile_key): Change type.
2356         (get_breakpoint_objfile_data): Update.
2357         (free_breakpoint_objfile_data): Remove.
2358         (_initialize_breakpoint): Update.
2359
2360 2019-05-08  Tom Tromey  <tom@tromey.com>
2361
2362         * linux-tdep.c (struct linux_info): Add initializers.
2363         (linux_inferior_data): Move.  Change type.
2364         (invalidate_linux_cache_inf): Update.
2365         (linux_inferior_data_cleanup): Remove.
2366         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2367
2368 2019-05-08  Tom Tromey  <tom@tromey.com>
2369
2370         * auxv.c (auxv_inferior_data): Move.  Change type.
2371         (auxv_inferior_data_cleanup): Remove.
2372         (invalidate_auxv_cache_inf): Rewrite.
2373         (get_auxv_inferior_data, _initialize_auxv): Update.
2374
2375 2019-05-08  Tom Tromey  <tom@tromey.com>
2376
2377         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2378         (symfile_debug_objfile_data_key): Change type.
2379         (symfile_debug_installed, debug_qf_has_symbols)
2380         (debug_qf_find_last_source_symtab)
2381         (debug_qf_forget_cached_source_info)
2382         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2383         (debug_qf_print_stats, debug_qf_dump)
2384         (debug_qf_expand_symtabs_for_function)
2385         (debug_qf_expand_all_symtabs)
2386         (debug_qf_expand_symtabs_with_fullname)
2387         (debug_qf_map_matching_symbols)
2388         (debug_qf_expand_symtabs_matching)
2389         (debug_qf_find_pc_sect_compunit_symtab)
2390         (debug_qf_map_symbol_filenames)
2391         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2392         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2393         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2394         (debug_sym_read_linetable, debug_sym_relocate): Update.
2395         (symfile_debug_free_objfile): Remove.
2396         (install_symfile_debug_logging, _initialize_symfile_debug):
2397         Update.
2398
2399 2019-05-08  Tom Tromey  <tom@tromey.com>
2400
2401         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2402         allocate_on_obstack.
2403         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2404         (get_dwarf2_per_objfile): Update.
2405         (set_dwarf2_per_objfile): Remove.
2406         (dwarf2_has_info, dwarf2_get_section_info): Update.
2407         (dwarf2_free_objfile): Remove.
2408         (_initialize_dwarf2_read): Update.
2409
2410 2019-05-08  Tom Tromey  <tom@tromey.com>
2411
2412         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2413         initializers.
2414         <unsupported_script_warning_printed,
2415         script_not_found_warning_printed>: Now bool.
2416         (auto_load_pspace_data): Change type.
2417         (~auto_load_pspace_info): Rename from
2418         auto_load_pspace_data_cleanup.
2419         (get_auto_load_pspace_data, init_loaded_scripts_info)
2420         (clear_section_scripts, maybe_print_unsupported_script_warning)
2421         (maybe_print_script_not_found_warning, _initialize_auto_load):
2422         Update.
2423
2424 2019-05-08  Tom Tromey  <tom@tromey.com>
2425
2426         * objfiles.c (objfile_pspace_info): Add destructor and
2427         initializers.
2428         (objfiles_pspace_data): Change type.
2429         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2430         (get_objfile_pspace_data): Update.
2431         (objfiles_bfd_data): Change type.
2432         (get_objfile_bfd_data): Update.
2433         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2434
2435 2019-05-08  Tom Tromey  <tom@tromey.com>
2436
2437         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2438         Change type.
2439         (get_catch_syscall_inferior_data): Update.
2440         (catch_syscall_inferior_data_cleanup): Remove.
2441         (_initialize_break_catch_syscall): Update.
2442
2443 2019-05-08  Tom Tromey  <tom@tromey.com>
2444
2445         * inflow.c (struct terminal_info): Add destructor and
2446         initializers.
2447         (inflow_inferior_data): Change type.
2448         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2449         (get_inflow_inferior_data, inflow_inferior_exit)
2450         (swap_terminal_info, _initialize_inflow): Update.
2451
2452 2019-05-08  Tom Tromey  <tom@tromey.com>
2453
2454         * target-dcache.c (target_dcache_cleanup): Remove.
2455         (target_dcache_aspace_key): Change type.
2456         (target_dcache_init_p, target_dcache_invalidate)
2457         (target_dcache_get, target_dcache_get_or_init)
2458         (_initialize_target_dcache): Update.
2459         * dcache.h (struct dcache_deleter): New.
2460
2461 2019-05-08  Tom Tromey  <tom@tromey.com>
2462
2463         * symtab.c (struct symbol_cache): Add destructor and
2464         initializers.
2465         (symbol_cache_key): Move.  Change type.
2466         (make_symbol_cache, free_symbol_cache): Remove.
2467         (get_symbol_cache): Update.
2468         (symbol_cache_cleanup): Remove.
2469         (ALL_PSPACES, symbol_cache_flush)
2470         (maintenance_print_symbol_cache)
2471         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2472         Update.
2473
2474 2019-05-08  Tom Tromey  <tom@tromey.com>
2475
2476         * symtab.c (struct main_info): Add destructor and initializers.
2477         (main_progspace_key): Move.  Change type.
2478         (get_main_info): Update.
2479         (main_info_cleanup): Remove.
2480         (_initialize_symtab): Update.
2481
2482 2019-05-08  Tom Tromey  <tom@tromey.com>
2483
2484         * registry.h (DECLARE_REGISTRY): Define the _key class.
2485
2486 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2487
2488         * NEWS: Merge two 'New commands' sections.
2489
2490 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2491
2492         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2493         parameter and use Ada language definition instead.
2494         (ada_val_print_ptr): Remove unused language parameter.
2495         (ada_val_print_num): Remove language parameter and use Ada language
2496         definition instead.
2497         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2498         parameter.
2499         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2500         parameter and use Ada language definition instead.
2501         (ada_val_print_1): Update all ada_val_print_xxx calls.
2502         Remove language parameter.
2503         (ada_val_print): Update ada_val_print_1 call.
2504
2505 2019-05-08  Tom Tromey  <tromey@adacore.com>
2506
2507         * remote.c (remote_hw_watchpoint_limit)
2508         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2509         Now static.
2510
2511 2019-05-08  Tom Tromey  <tromey@adacore.com>
2512
2513         * maint.c (_initialize_maint_cmds): Move initialization code to
2514         remote.c.
2515         (watchdog, show_watchdog): Move to remote.c.
2516         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2517         "watchdog" static.
2518         (_initialize_remote): Move initialization code from maint.c.
2519         * defs.h (watchdog): Don't declare.
2520
2521 2019-05-08  Tom Tromey  <tromey@adacore.com>
2522
2523         * tui/tui-interp.c: Include main.h.
2524         * interps.c: Include main.h.
2525         * main.h (interpreter_p): Declare.
2526         * defs.h (interpreter_p): Don't declare.
2527
2528 2019-05-08  Tom Tromey  <tromey@adacore.com>
2529
2530         * dwarf2loc.c: Include dwarf2read.h.
2531         * defs.h (read_unsigned_leb128): Don't declare.
2532         * dwarf2read.h (read_unsigned_leb128): Declare.
2533
2534 2019-05-08  Tom Tromey  <tromey@adacore.com>
2535
2536         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2537         method.
2538
2539 2019-05-08  Tom Tromey  <tromey@adacore.com>
2540
2541         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2542         when no wrap column is set.
2543
2544 2019-05-08  Tom Tromey  <tromey@adacore.com>
2545
2546         * c-lang.c (c_get_string): Handle non-C-style arrays.
2547
2548 2019-05-08  Tom Tromey  <tromey@adacore.com>
2549
2550         * typeprint.c (print_offset_data::update): Print the bit offset,
2551         not the number of bits remaining.
2552
2553 2019-05-08  Tom Tromey  <tromey@adacore.com>
2554
2555         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2556         padding at end of comment.
2557
2558 2019-05-08  Tom Tromey  <tromey@adacore.com>
2559
2560         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2561         Compare main types.
2562
2563 2019-05-06  Tom Tromey  <tom@tromey.com>
2564
2565         * common/scoped_mmap.c: Include common-defs.h.
2566         * common/scoped_mmap.h: Don't include config.h.
2567
2568 2019-05-04  Tom Tromey  <tom@tromey.com>
2569
2570         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2571         (struct aarch64_call_info): Add initializers.
2572         <si>: Now a std::vector.
2573         (pass_on_stack, aarch64_push_dummy_call): Update.
2574
2575 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2576             Tom Tromey  <tom@tromey.com>
2577
2578         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2579         (ppc_threads): Now a std::vector.  Now static.
2580         (hwdebug_find_thread_points_by_tid)
2581         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2582         Update.
2583
2584 2019-05-04  Tom Tromey  <tom@tromey.com>
2585
2586         * arc-tdep.c (arc_tdesc_init): Return bool.
2587
2588 2019-05-04  Tom Tromey  <tom@tromey.com>
2589
2590         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2591         Use gdb_assert_not_reached.
2592
2593 2019-05-04  Tom Tromey  <tom@tromey.com>
2594
2595         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2596         "false".
2597
2598 2019-05-04  Tom Tromey  <tom@tromey.com>
2599
2600         * arc-tdep.c (arc_tdesc_init): Use bool.
2601
2602 2019-05-04  Tom Tromey  <tom@tromey.com>
2603
2604         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2605
2606 2019-05-04  Tom Tromey  <tom@tromey.com>
2607
2608         * cli/cli-cmds.c (valid_command_p): Return bool.
2609
2610 2019-05-04  Tom Tromey  <tom@tromey.com>
2611
2612         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2613         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2614
2615 2019-05-04  Raul Tambre  <raul@tambre.ee>
2616
2617         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2618         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2619         operator for comparison.
2620
2621 2019-05-04  Tom Tromey  <tom@tromey.com>
2622
2623         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2624         (lookup_partial_symbol, print_partial_symbols)
2625         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2626         (psymbol_compare): Update.
2627         (add_psymbol_to_bcache): Clear the entire psymbol.
2628         (maintenance_check_psymtabs): Update.
2629         * psympriv.h (struct partial_symbol): Don't derive from
2630         general_symbol_info.
2631         <obj_section, unrelocated_address, address,
2632         set_unrelocated_address>: Update.
2633         <ginfo>: New member.
2634         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2635         (debug_names::write_psymbols): Update.
2636
2637 2019-05-04  Tom de Vries  <tdevries@suse.de>
2638
2639         * contrib/cc-with-tweaks.sh: Support -n arg.
2640
2641 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2642
2643         * corelow.c (core_target::detach): Ensure frame cache and
2644         register caches are cleared.
2645         inferior.c (exit_inferior_1): Likewise.
2646
2647 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2648             Tom Tromey  <tom@tromey.com>
2649
2650         * dictionary.c (collate_pending_symbols_by_language): Remove
2651         "struct" from foreach.
2652         * symtab.c (lookup_global_symbol_from_objfile)
2653         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2654         foreach.
2655         * ser-tcp.c (net_open): Remove "struct" from foreach.
2656         * objfiles.c (objfile_relocate, objfile_rebase)
2657         (objfile_has_symbols): Remove "struct" from foreach.
2658         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2659         from foreach.
2660         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2661         foreach.
2662         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2663         "struct" from foreach.
2664         * ada-lang.c (create_excep_cond_exprs)
2665         (ada_exception_catchpoint_cond_string): Remove "struct" from
2666         foreach.
2667
2668 2019-05-03  Tom Tromey  <tromey@adacore.com>
2669
2670         * ada-exp.y (convert_char_literal): Check suffix of each
2671         enumerator.
2672
2673 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2674
2675         PR ada/21406:
2676         * ada-exp.y (yywrap): Don't define.
2677         * ada-lex.l (%option): Add noyywrap
2678         (yywrap): Remove.
2679
2680 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2681
2682         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2683         _WIN32_WINNT to the XP level, unless already defined to a higher
2684         level.
2685
2686         * unittests/parse-connection-spec-selftests.c:
2687         * ser-tcp.c:
2688         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2689         override.
2690
2691         * symfile.c (find_separate_debug_file): Remove colon from the
2692         drive spec of DOS/Windows file names of the target, so that the
2693         file name produced from DEBUGDIR and the target's directory will
2694         be valid on DOS/Windows systems.
2695
2696 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * rust-lang.c (val_print_struct): Handle printing structures
2699         containing strings.
2700
2701 2019-05-02  Tom Tromey  <tromey@adacore.com>
2702
2703         * valarith.c (_initialize_valarith): Remove.
2704
2705 2019-05-01  Tom Tromey  <tromey@adacore.com>
2706
2707         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2708         bitfields.
2709
2710 2019-05-01  Tom Tromey  <tromey@adacore.com>
2711
2712         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2713         for big-endian copies.
2714
2715 2019-04-30  Ali Tamur  <tamur@google.com>
2716         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2717         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2718         (read_3_bytes): New function.
2719
2720 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2721
2722         * windows-nat.c (main_thread_id): Delete.
2723         (handle_output_debug_string): Replace main_thread_id by
2724         current_event.dwThreadId.
2725         (fake_create_process): Likewise.
2726         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2727         Do not set main_thread_id.
2728         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2729         current_event.dwThreadId.
2730         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2731
2732 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2733
2734         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2735         Use current_event.dwThreadId instead of main_thread_id.
2736
2737 2019-04-30  Tom Tromey  <tromey@adacore.com>
2738
2739         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2740         (create_excep_cond_exprs): Iterate over program spaces.
2741         (ada_exception_catchpoint_cond_string): Examine all minimal
2742         symbols for exception types.
2743
2744 2019-04-30  Tom Tromey  <tromey@adacore.com>
2745
2746         PR c++/24470:
2747         * dwarf2read.c (process_structure_scope): Handle case where type
2748         has template parameters but no symbol was created.
2749
2750 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2751             Chris January  <chris.january@arm.com>
2752
2753         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2754         qualifier.
2755         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2756
2757 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2758
2759         * f-typeprint.c (f_print_type): Update rules for printing
2760         whitespace.
2761         (f_type_print_varspec_suffix): Likewise.
2762
2763 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2764             Chris January  <chris.january@arm.com>
2765
2766         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2767         function arguments.
2768
2769 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * f-lang.c (build_fortran_types): Change name of void type to
2772         lower case.
2773         * f-typeprint.c (f_type_print_base): Print the name of the void
2774         type, rather than a fixed string.
2775         * f-valprint.c (f_decorations): Use lower case void string.
2776
2777 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2778             Chris January  <chris.january@arm.com>
2779
2780         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2781         types for Fortran.
2782
2783 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2784             Chris January  <chris.january@arm.com>
2785             David Lecomber  <david.lecomber@arm.com>
2786
2787         * f-exp.y (BINOP_INTRINSIC): New token.
2788         (exp): New parser rule handling BINOP_INTRINSIC.
2789         (f77_keywords): Add new builtin procedures.
2790         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2791         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2792         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2793         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2794         (print_unop_subexp_f): New function.
2795         (print_binop_subexp_f): New function.
2796         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2797         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2798         (dump_subexp_body_f): Likewise.
2799         (operator_check_f): Likewise.
2800         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2801         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2802
2803 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2804
2805         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2806         UNOP_KIND.
2807         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2808         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2809         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2810         (operator_length_f): New fuction.
2811         (print_subexp_f): New function.
2812         (op_name_f): New function.
2813         (dump_subexp_body_f): New function.
2814         (operator_check_f): New function.
2815         (exp_descriptor_f): Replace standard expression handling functions
2816         with new functions.
2817         * gdb/fortran-operator.def: New file.
2818         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2819         * gdb/std-operator.def: Remove UNOP_KIND.
2820
2821 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2822
2823         * std-operator.def: Remove unbalanced, stray double quote
2824         character.
2825
2826 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2827             Chris January  <chris.january@arm.com>
2828             Daniel Everett  <daniel.everett@arm.com>
2829             Nick Forrington  <nick.forrington@arm.com>
2830             Richard Bunt  <richard.bunt@arm.com>
2831
2832         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2833         of depth when printing anonymous structs or unions.
2834         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2835         Don't print either the top-level value, or the children if the
2836         max-depth is exceeded.
2837         (ppscm_print_children): When printing the key of a map, allow one
2838         extra level of depth.
2839         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2840         print either the top-level value, or the children if the max-depth
2841         is exceeded.
2842         (print_children): When printing the key of a map, allow one extra
2843         level of depth.
2844         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2845         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2846         (user_print_options): Initialise max_depth field.
2847         (val_print_scalar_or_string_type_p): New function.
2848         (val_print): Check to see if the max depth has been reached.
2849         (val_print_check_max_depth): Define new function.
2850         (show_print_max_depth): New function.
2851         (_initialize_valprint): Add 'print max-depth' option.
2852         * valprint.h (struct value_print_options) <max_depth>: New field.
2853         (val_print_check_max_depth): Declare new function.
2854         * NEWS: Document new feature.
2855
2856 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2857
2858         * ada-lang.c (ada_language_defn): Initialise new field.
2859         * c-lang.c (c_is_string_type_p): New function.
2860         (c_language_defn): Initialise new field.
2861         (cplus_language_defn): Initialise new field.
2862         (asm_language_defn): Initialise new field.
2863         (minimal_language_defn): Initialise new field.
2864         * c-lang.h (c_is_string_type_p): Declare new function.
2865         * d-lang.c (d_language_defn): Initialise new field.
2866         * f-lang.c (f_is_string_type_p): New function.
2867         (f_language_defn): Initialise new field.
2868         * go-lang.c (go_is_string_type_p): New function.
2869         (go_language_defn): Initialise new field.
2870         * language.c (default_is_string_type_p): New function.
2871         (unknown_language_defn): Initialise new field.
2872         (auto_language_defn): Initialise new field.
2873         * language.h (struct language_defn) <la_is_string_type_p>: New
2874         member variable.
2875         (default_is_string_type_p): Declare new function.
2876         * m2-lang.c (m2_language_defn): Initialise new field.
2877         * objc-lang.c (objc_language_defn): Initialise new field.
2878         * opencl-lang.c (opencl_language_defn): Initialise new field.
2879         * p-lang.c (pascal_is_string_type_p): New function.
2880         (pascal_language_defn): Initialise new field.
2881         * rust-lang.c (rust_is_string_type_p): New function.
2882         (rust_language_defn): Initialise new field.
2883
2884 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2887         New field.
2888         * ada-lang.c (ada_language_defn): Initialise new field.
2889         * c-lang.c (c_language_defn): Likewise.
2890         (cplus_language_defn): Likewise.
2891         (asm_language_defn): Likewise.
2892         (minimal_language_defn): Likewise.
2893         * d-lang.c (d_language_defn): Likewise.
2894         * f-lang.c (f_language_defn): Likewise.
2895         * go-lang.c (go_language_defn): Likewise.
2896         * language.c (unknown_language_defn): Likewise.
2897         (auto_language_defn): Likewise.
2898         * m2-lang.c (m2_language_defn): Likewise.
2899         * objc-lang.c (objc_language_defn): Likewise.
2900         * opencl-lang.c (opencl_language_defn): Likewise.
2901         * p-lang.c (pascal_language_defn): Likewise.
2902         * rust-lang.c (rust_language_defn): Likewise.
2903
2904 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2905
2906         * ada-lang.c (ada_is_character_type): Change return type to bool.
2907         (ada_is_string_type): Likewise.
2908         * ada-lang.h (ada_is_character_type): Update declaration
2909         (ada_is_string_type): Likewise.
2910
2911 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2912
2913         Support style in 'frame|thread apply'
2914
2915         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2916         * record.c (record_start, record_stop): Update callers of
2917         execute_command_to_string with false.
2918         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2919         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2920         methods.
2921         (class string_file): New constructor with term_out parameter.
2922         Override methods term_out and can_emit_style_escape.  New member
2923         term_out.
2924         (class stdio_file): Override can_emit_style_escape.
2925         (class tee_file): Override term_out and can_emit_style_escape.
2926         * utils.h (can_emit_style_escape): Remove.
2927         * utils.c (can_emit_style_escape): Likewise.
2928         Update all callers of can_emit_style_escape (SOMESTREAM) to
2929         SOMESTREAM->can_emit_style_escape.
2930         * source-cache.c (source_cache::get_source_lines): Likewise.
2931         * stack.c (frame_apply_command_count): Call execute_command_to_string
2932         passing the term_out characteristic of the current gdb_stdout.
2933         * thread.c (thr_try_catch_cmd): Likewise.
2934         * top.c (execute_command_to_string): pass term_out parameter
2935         to construct the string_file for the command output.
2936         * ui-file.c (term_cli_styling): New function (most code moved
2937         from utils.c can_emit_style_escape).
2938         (string_file::string_file, string_file::can_emit_style_escape,
2939         stdio_file::can_emit_style_escape, tee_file::term_out,
2940         tee_file::can_emit_style_escape): New functions.
2941
2942 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2943
2944         * NEWS: Mention the new set|show may-call-functions.
2945         * infcall.c (may_call_functions_p): New variable.
2946         (show_may_call_functions_p): New function.
2947         (call_function_by_hand_dummy): Throws an error if not
2948         may-call-functions.
2949         (_initialize_infcall): Call add_setshow_boolean_cmd for
2950         may-call-functions.
2951
2952 2019-04-25  Keith Seitz  <keiths@redhat.com>
2953
2954         PR c++/24367
2955         * cp-support.c (inspect_type): Don't attempt substitutions
2956         of symbol with the same name.
2957
2958 2019-04-25  Tom Tromey  <tromey@adacore.com>
2959
2960         PR gdb/24475:
2961         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2962         static.
2963
2964 2019-04-25  Tom Tromey  <tromey@adacore.com>
2965
2966         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2967         rvalue reference.
2968         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2969         (gdb_xml_parser::parse): Use std::move.
2970         * python/python-internal.h (gdbpy_convert_exception): Take a const
2971         reference.
2972         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2973         std::move.
2974         * python/py-utils.c (gdbpy_convert_exception): Take a const
2975         reference.
2976         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2977         Use std::move.
2978         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2979         Use std::move.
2980         * mi/mi-main.c (mi_print_exception): Take a const reference.
2981         * main.c (handle_command_errors): Take a const reference.
2982         * linespec.c (parse_linespec): Use std::move.
2983         * infcall.c (run_inferior_call): Use std::move.
2984         (call_function_by_hand_dummy): Use std::move.
2985         * exec.c (try_open_exec_file): Use std::move.
2986         * exceptions.h (exception_print, exception_fprintf)
2987         (exception_print_same): Update.
2988         * exceptions.c (print_exception, exception_print)
2989         (exception_fprintf, exception_print_same): Change parameters to
2990         const reference.
2991         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2992         * common/new-op.c: Use std::move.
2993         * common/common-exceptions.h (struct gdb_exception): Add move
2994         constructor.
2995         (struct gdb_exception_error, struct gdb_exception_quit, struct
2996         gdb_quit_bad_alloc): Change constructor to move constructor.
2997         (throw_exception): Change parameter to rvalue reference.
2998         * common/common-exceptions.c (throw_exception): Take rvalue
2999         reference.
3000         * cli/cli-interp.c (safe_execute_command): Use std::move.
3001         * breakpoint.c (insert_bp_location, location_to_sals): Use
3002         std::move.
3003
3004 2019-04-25  Tom Tromey  <tromey@adacore.com>
3005
3006         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3007         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3008         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3009         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3010         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3011         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3012         guile/scm-value.c: Use unpack.
3013         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3014         gdbscm_gdb_exception.
3015         (gdbscm_throw_gdb_exception): Likewise.
3016         (struct gdbscm_gdb_exception): New.
3017         (unpack): New function.
3018         (gdbscm_wrap): Use unpack.
3019
3020 2019-04-25  Tom Tromey  <tromey@adacore.com>
3021
3022         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3023         (gdb_rl_callback_handler): Use std::move.
3024         * common/common-exceptions.h (struct gdb_exception): Add move
3025         assignment operator.
3026         (throw_exception_sjlj): Change "exception" to const reference.
3027         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3028         (throw_exception_sjlj): Change "exception" to const reference.
3029
3030 2019-04-25  Tom Tromey  <tromey@adacore.com>
3031
3032         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3033         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3034         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3035         Update.
3036         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3037         Update.
3038         * mi/mi-interp.c (mi_interp::exec): Update.
3039         * linespec.c (parse_linespec): Update.
3040         * infcall.c (run_inferior_call): Update.
3041         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3042         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3043         (gdbscm_lookup_global_symbol): Update.
3044         * guile/scm-param.c (gdbscm_parameter_value): Update.
3045         * guile/scm-frame.c (gdbscm_frame_read_register)
3046         (gdbscm_frame_read_var): Update.
3047         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3048         * exec.c (try_open_exec_file): Update.
3049         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3050         (gdb_rl_callback_handler): Update.
3051         * common/common-exceptions.h (exception_none): Don't declare.
3052         * common/common-exceptions.c (exception_none): Don't define.
3053         (struct catcher) <exception>: Update.
3054         * cli/cli-interp.c (safe_execute_command): Update.
3055         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3056
3057 2019-04-25  Ali Tamur  <tamur@google.com>
3058
3059         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3060         (read_attribute_value): Likewise.
3061         (dwarf2_read_addr_index): Update comment.
3062         (read_str_index): Add DW_FORM_strx.
3063         (dwarf2_string_attr): Likewise.
3064         (dwarf2_const_value_attr): Likewise.
3065         (dump_die_shallow): Likewise.
3066         (dwarf2_fetch_constant_bytes): Likewise.
3067         (skip_form_bytes): Likewise.
3068         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3069
3070 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3071
3072         PR corefiles/11608
3073         PR corefiles/18187
3074         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3075         OFFSET.  Verify if current mapping contains an ELF header.
3076         (linux_find_memory_regions_full): Adjust call to
3077         dump_mapping_p.
3078
3079 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3080             Kang Li <kanglictf@gmail.com>
3081
3082         PR gdb/21600
3083
3084         * dwarf2-frame.c (read_initial_length): Be consistent about using
3085         unsigned representation of length.
3086         (decode_frame_entry_1): Likewise.  Check for wraparound of
3087         end pointer as well as buffer overflow.
3088
3089 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3090
3091         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3092         "vq".
3093
3094 2019-04-24  Tom Tromey  <tromey@adacore.com>
3095
3096         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3097
3098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3099
3100         * s12z-tdep.c (s12z_unwind_pc): Delete.
3101         (s12z_unwind_sp): Delete.
3102         (s12z_gdbarch_init): Don't register deleted functions with
3103         gdbarch.
3104
3105 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3106
3107         * rl78-tdep.c (rl78_unwind_sp): Delete.
3108         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3109
3110 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3113         (xstormy16_unwind_pc): Delete.
3114         (xstormy16_dummy_id): Delete.
3115         (xstormy16_gdbarch_init): Don't register deleted functions with
3116         gdbarch.
3117
3118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3119
3120         * vax-tdep.c (vax_unwind_pc): Delete.
3121         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3122
3123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3124
3125         * v850-tdep.c (v850_unwind_sp): Delete.
3126         (v850_unwind_pc): Delete.
3127         (v850_dummy_id): Delete.
3128         (v850_gdbarch_init): Don't register deleted functions with
3129         gdbarch.
3130
3131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3132
3133         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3134         (tilegx_unwind_pc): Delete.
3135         (tilegx_unwind_dummy_id): Delete.
3136         (tilegx_gdbarch_init): Don't register deleted functions with
3137         gdbarch.
3138
3139 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3140
3141         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3142         (tic6x_dummy_id): Delete.
3143         (tic6x_gdbarch_init): Don't register deleted functions with
3144         gdbarch.
3145
3146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3147
3148         * sparc-tdep.c (sparc_unwind_pc): Delete.
3149         (sparc32_gdbarch_init): Don't register deleted function with
3150         gdbarch.
3151
3152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3153
3154         * sh-tdep.c (sh_unwind_sp): Delete.
3155         (sh_unwind_pc): Delete.
3156         (sh_dummy_id): Delete.
3157         (sh_gdbarch_init): Don't register deleted functions with
3158         gdbarch.
3159
3160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3161
3162         * score-tdep.c (score_unwind_sp): Delete.
3163         (score_unwind_pc): Delete.
3164         (score_dummy_id): Delete.
3165         (score_gdbarch_init): Don't register deleted functions with
3166         gdbarch.
3167
3168 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3169
3170         * rx-tdep.c (rx_unwind_pc): Delete.
3171         (rx_unwind_sp): Delete.
3172         (rx_dummy_id): Delete.
3173         (rx_gdbarch_init): Don't register deleted functions with
3174         gdbarch.  Update comment.
3175
3176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3177
3178         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3179         (rs6000_dummy_id): Delete.
3180         (rs6000_gdbarch_init): Don't register deleted functions with
3181         gdbarch.
3182
3183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3184
3185         * or1k-tdep.c (or1k_dummy_id): Delete.
3186         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3187
3188 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3189
3190         * nios2-tdep.c (nios2_dummy_id): Delete.
3191         (nios2_unwind_sp): Delete.
3192         (nios2_gdbarch_init): Don't register deleted functions with
3193         gdbarch.
3194
3195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3196
3197         * nds32-tdep.c (nds32_dummy_id): Delete.
3198         (nds32_unwind_pc): Delete.
3199         (nds32_unwind_sp): Delete.
3200         (nds32_gdbarch_init): Don't register deleted functions with
3201         gdbarch.
3202
3203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3204
3205         * msp430-tdep.c (msp430_unwind_pc): Delete.
3206         (msp430_unwind_sp): Delete.
3207         (msp430_dummy_id): Delete.
3208         (msp430_gdbarch_init): Don't register deleted functions with
3209         gdbarch.
3210
3211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3212
3213         * moxie-tdep.c (moxie_unwind_sp): Delete.
3214         (moxie_unwind_pc): Delete.
3215         (moxie_dummy_id): Delete.
3216         (moxie_gdbarch_init): Don't register deleted functions with
3217         gdbarch.
3218
3219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3222         (mn10300_unwind_pc): Delete.
3223         (mn10300_unwind_sp): Delete.
3224         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3225         mn10300_unwind_sp.
3226         (mn10300_frame_unwind_init): Don't register deleted functions with
3227         gdbarch.
3228
3229 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3230
3231         * mep-tdep.c (mep_unwind_pc): Delete.
3232         (mep_unwind_sp): Delete.
3233         (mep_dummy_id): Delete.
3234         (mep_gdbarch_init): Don't register deleted functions with
3235         gdbarch.
3236
3237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3240         (m68hc11_unwind_sp): Delete.
3241         (m68hc11_gdbarch_init): Don't register deleted functions with
3242         gdbarch.
3243
3244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3245
3246         * m32r-tdep.c (m32r_unwind_sp): Delete.
3247         (m32r_unwind_pc): Delete.
3248         (m32r_dummy_id): Delete.
3249         (m32r_gdbarch_init): Don't register deleted functions with
3250         gdbarch.
3251
3252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * m32c-tdep.c (m32c_unwind_pc): Delete.
3255         (m32c_unwind_sp): Delete.
3256         (m32c_dummy_id): Delete.
3257         (m32c_gdbarch_init): Don't register deleted functions with
3258         gdbarch.
3259
3260 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3261
3262         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3263         (lm32_unwind_pc): Delete.
3264         (lm32_dummy_id): Delete.
3265         (lm32_gdbarch_init): Don't register deleted functions with
3266         gdbarch.
3267
3268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3271         (iq2000_unwind_pc): Delete.
3272         (iq2000_dummy_id): Delete.
3273         (iq2000_gdbarch_init): Don't register deleted functions with
3274         gdbarch.
3275
3276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3277
3278         * nds32-tdep.c (nds32_type_align): Delete.
3279         (nds32_push_dummy_call): Use type_align instead.
3280
3281 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3282
3283         * arm-tdep.c (arm_type_align): Only handle vector override case.
3284         (arm_push_dummy_call): Use type_align.
3285         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3286
3287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3288
3289         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3290         case.
3291         (pass_on_stack): Use type_align.
3292         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3293         function.
3294
3295 2019-04-23  Tom Tromey  <tromey@adacore.com>
3296
3297         * dwarf2read.c (line_header::file_name_at): Remove unused
3298         overload.
3299
3300 2019-04-23  Tom de Vries  <tdevries@suse.de>
3301
3302         PR gdb/24438
3303         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3304         invocation.
3305
3306
3307 2019-03-27  Ali Tamur  <tamur@google.com>
3308
3309         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3310         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3311         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3312         (dwarf_expr_context::get_addr_index): Likewise
3313         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3314         (symbol_needs_eval_context::get_addr_index): Likewise
3315         (disassemble_dwarf_expression): Add DW_OP_addrx
3316         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3317         (read_cutu_die_from_dwo): Update comment
3318         (skip_one_die): Add DW_FORM_addrx
3319         (read_attribute_value): Likewise
3320         (var_decode_location): Add DW_OP_addrx
3321         (dwarf2_const_value_attr): Add DW_FORM_addrx
3322         (dump_die_shallow): Likewise
3323         (dwarf2_fetch_constant_bytes): Likewise
3324         (decode_locdesc): Add DW_OP_addrx
3325         (skip_form_bytes): Add DW_FORM_addrx
3326
3327 2019-04-22  Ali Tamur  <tamur@google.com>
3328
3329         * MAINTAINERS (Write After Approval): Add self.
3330
3331 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3332
3333         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3334         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3335         (open_symbol_file_object): Likewise.
3336         (svr4_default_sos): Add info parameter.
3337         (svr4_read_so_list): Likewise.
3338         (svr4_current_sos_direct): Adjust functions calls to pass down
3339         info.
3340         (svr4_current_sos_1): Add info parameter.
3341         (svr4_current_sos): Call get_svr4_info, pass info down to
3342         svr4_current_sos_1.
3343         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3344         get_svr4_info.
3345         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3346         get_svr4_info.
3347         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3348         to get_svr4_info.
3349         (probes_table_remove_objfile_probes): Likewise.
3350         (register_solib_event_probe): Add info parameter.
3351         (solist_update_incremental): Pass info parameter down to
3352         svr4_read_so_list.
3353         (disable_probes_interface): Add info parameter.
3354         (svr4_handle_solib_event): Pass current_program_space to
3355         get_svr4_info.  Adjust disable_probes_interface cleanup.
3356         (svr4_create_probe_breakpoints): Add info parameter, pass it
3357         down to register_solib_event_probe.
3358         (svr4_create_solib_event_breakpoints): Add info parameter,
3359         pass it down to svr4_create_probe_breakpoints.
3360         (enable_break): Pass info down to
3361         svr4_create_solib_event_breakpoints.
3362         (svr4_solib_create_inferior_hook): Pass current_program_space to
3363         get_svr4_info.
3364         (svr4_clear_solib): Likewise.
3365
3366 2019-04-22  Pedro Alves  <palves@redhat.com>
3367
3368         * solib-svr4.c (svr4_free_objfile_observer): New.
3369         (probe_and_action::objfile): New field.
3370         (probes_table_htab_remove_objfile_probes)
3371         (probes_table_remove_objfile_probes): New functions.
3372         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3373         in the new probe_and_action.  Don't store the probe in 'lookup'.
3374         (svr4_create_probe_breakpoints): Pass objfile to
3375         register_solib_event_probe.
3376         (_initialize_svr4_solib): Register a free_objfile observer.
3377
3378 2019-04-19  Tom Tromey  <tom@tromey.com>
3379
3380         * common/queue.h: Remove.
3381
3382 2019-04-19  Tom Tromey  <tom@tromey.com>
3383
3384         * event-loop.c: Don't include "common/queue.h".
3385
3386 2019-04-19  Tom Tromey  <tom@tromey.com>
3387
3388         * remote.c (remote_target): Use delete.
3389         * remote-notif.h: Include <list>, not "common/queue.h".
3390         (notif_client_p): Remove typedef.
3391         (remote_notif_state): Add constructor, destructor, initializer.
3392         <notif_queue>: Now a std::list.
3393         (remote_notif_state_xfree): Don't declare.
3394         * remote-notif.c (remote_notif_process, handle_notification)
3395         (remote_notif_state_allocate): Update.
3396         (~remote_notif_state): Rename from remote_notif_state_xfree.
3397
3398 2019-04-19  Tom Tromey  <tom@tromey.com>
3399
3400         * symfile.c (reread_symbols): Update.
3401         * objfiles.c (objfile_register_static_link)
3402         (objfile_lookup_static_link): Update
3403         (~objfile) Don't delete static_links.
3404         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3405
3406 2019-04-19  Tom Tromey  <tom@tromey.com>
3407
3408         * type-stack.h (struct type_stack) <insert>: Constify string.
3409         * type-stack.c (type_stack::insert): Constify string.
3410         * gdbtypes.h (lookup_template_type): Update.
3411         (address_space_name_to_int): Update.
3412         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3413         const.
3414         (lookup_template_type): Make name const.
3415         * c-exp.y: Update rules.
3416         (lex_one_token, classify_name, classify_inner_name)
3417         (c_print_token): Update.
3418         * p-exp.y: Update rules.
3419         (yylex): Update.
3420         * f-exp.y: Update rules.
3421         (yylex): Update.
3422         * d-exp.y: Update rules.
3423         (lex_one_token, classify_name, classify_inner_name): Update.
3424         * parse.c (write_dollar_variable, copy_name): Return std::string.
3425         * parser-defs.h (copy_name): Change return type.
3426         * m2-exp.y: Update rules.
3427         (yylex): Update.
3428         * go-exp.y (lex_one_token): Update.
3429         Update rules.
3430         (classify_unsafe_function, classify_packaged_name)
3431         (classify_name, yylex): Update.
3432
3433 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3434
3435         * configure.ac: add --enable-source-highlight switch.
3436         * configure: Regenerate.
3437         * top.c (print_gdb_version): plumb --enable-source-highlight
3438         status to "show configuration".
3439
3440 2019-04-19  Tom Tromey  <tromey@adacore.com>
3441
3442         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3443         Check ADA_TYPE_P.
3444         (empty_record, ada_template_to_fixed_record_type_1)
3445         (template_to_static_fixed_type)
3446         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3447         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3448         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3449         macros.
3450
3451 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3452
3453         PR symtab/24423:
3454         * source.c (print_source_lines_base): Advance "iter" when a
3455         control character is seen.
3456
3457 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3458
3459         * inferior.h (struct infcall_suspend_state_deleter):
3460         Catch exception in destructor to avoid crash.
3461
3462 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3463
3464         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3465         close to the add_com "shell".
3466
3467 2019-04-18  Tom Tromey  <tromey@adacore.com>
3468
3469         * process-stratum-target.h (class process_stratum_target)
3470         <stratum>: Add "final".
3471
3472 2019-04-17  Tom Tromey  <tromey@adacore.com>
3473
3474         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3475         against nullptr before use.
3476
3477 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3478
3479         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3480
3481 2019-04-17  Jim Wilson  <jimw@sifive.com>
3482             Andrew Burgess  <andrew.burgess@embecosm.com>
3483
3484         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3485         code read might fail, assume 4-byte breakpoint in that case.
3486
3487 2019-04-15  Leszek Swirski  <leszeks@google.com>
3488
3489         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3490         rather than a hand-rolled POD check when checking for forced MEMORY
3491         classification.
3492
3493 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3494
3495         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3496         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3497         function.
3498         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3499         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3500         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3501         declaration.
3502
3503 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3504
3505         * aarch64-linux-nat.c
3506         (aarch64_linux_nat_target::thread_architecture): Add override.
3507         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3508         each VQ.
3509
3510 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3511
3512         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3513
3514 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3515
3516         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3517         target types of size 96-bits, add some additional comments, and
3518         check that the builtin type we found was the correct size.
3519
3520 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3521
3522         * utils.c (prompt_for_continue): Don't restore the styling at the
3523         end, as applied_style has the wrong value.  This fixes styling in
3524         long lists of file names that are interrupted by the "Continue?"
3525         prompt.
3526
3527 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3528
3529         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3530         * c-lang.c (c_language_defn): Likewise.
3531         (cplus_language_defn): Likewise.
3532         (asm_language_defn): Likewise.
3533         (minimal_language_defn): Likewise.
3534         * d-lang.c (d_language_defn): Likewise.
3535         * f-lang.c (f_language_defn): Likewise.
3536         * go-lang.c (go_language_defn): Likewise.
3537         * language.c (unknown_language_defn): Likewise.
3538         (auto_language_defn): Likewise.
3539         * language.h (struct language_defn): Remove la_magic field.
3540         (LANG_MAGIC): Delete.
3541         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3542         * objc-lang.c (objc_language_defn): Likewise.
3543         * opencl-lang.c (opencl_language_defn): Likewise.
3544         * p-lang.c (pascal_language_defn): Likewise.
3545         * rust-lang.c (rust_language_defn): Likewise.
3546
3547 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3548
3549         * riscv-tdep.c (riscv_type_align): New function.
3550         (riscv_type_alignment): Delete.
3551         (riscv_arg_location): Use 'type_align'.
3552         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3553
3554 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3555
3556         * gdbtypes.c (type_align): A struct with no non-static fields also
3557         has alignment of 1.
3558
3559 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3562         component to 0.
3563         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3564         member.
3565         (riscv_struct_info::analyse): New implementation using new
3566         analyse_inner member function.
3567         (riscv_struct_info::field_offset): New member function.
3568         (riscv_struct_info::m_offsets): New member variable.
3569         (riscv_struct_info::analyse_inner): New private member function,
3570         takes the old implementation of riscv_struct_info::analyse but
3571         extended to track field offsets.
3572         (riscv_call_arg_struct): Update the struct folding special cases
3573         to handle cases where empty C++ structs, which are non-zero
3574         length, are found.
3575         (riscv_arg_location): Initialise the length of each location, a
3576         non-zero length now indicates the location is in use.
3577         (riscv_push_dummy_call): Allow for the first location having a
3578         non-zero offset when setting up arguments.
3579         (riscv_return_value): Likewise, but for return values.
3580
3581 2019-04-11  Tom Tromey  <tromey@adacore.com>
3582
3583         * utils.c (internal_vproblem): Make "msg" const.
3584
3585 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3586
3587         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3588         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3589         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3590         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3591
3592 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3593
3594         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3595         function.
3596         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3597         of amd64_collect_native_gregset.
3598         (amd64_linux_nat_target::store_registers): Likewise.
3599
3600 2019-04-10  Tom Tromey  <tom@tromey.com>
3601
3602         * symtab.c (lookup_global_symbol_from_objfile)
3603         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3604         * objfiles.h (class separate_debug_iterator): New.
3605         (class separate_debug_range): New.
3606         (struct objfile) <separate_debug_objfiles>: New method.
3607         (objfile_separate_debug_iterate): Don't declare.
3608         * objfiles.c (separate_debug_iterator::operator++): Rename from
3609         objfile_separate_debug_iterate.
3610         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3611         iterator.
3612         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3613         iterator.
3614
3615 2019-04-10  Tom Tromey  <tom@tromey.com>
3616
3617         * symfile.c (reread_symbols): Remove old comment.
3618         * objfiles.c (free_all_objfiles): Fix a typo.
3619
3620 2019-04-10  Tom Tromey  <tom@tromey.com>
3621
3622         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3623         * minsyms.c (lookup_minimal_symbol): Use foreach.
3624         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3625         (lookup_minimal_symbol_solib_trampoline): Likewise.
3626         * symfile.c (reread_symbols): Use foreach.
3627
3628 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3629             Tom Tromey  <tromey@adacore.com>
3630
3631         PR rust/24414:
3632         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3633         (rust_lex_int_test): Change "value" to be LONGEST.
3634         (rust_lex_tests): Add test for long integer literal.
3635
3636 2019-04-09  Tom Tromey  <tromey@adacore.com>
3637
3638         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3639         to bool.
3640         (extended_remote_target::attach): Update.
3641         (remote_target::remote_notice_new_inferior): Update.
3642         (remote_target::add_current_inferior_and_thread): Update.
3643         * inferior.c (exit_inferior_1): Use "false".
3644         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3645
3646 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3647
3648         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3649         the "start" command.
3650
3651 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3652
3653         * python/py-inferior.c (infpy_thread_from_thread_handle):
3654         Adjust comments to reflect renaming of thread_from_thread_handle
3655         to thread_from_handle.  Adjust keywords.  Fix type error message.
3656         (inferior_object_methods): Add thread_from_handle.  Retain
3657         thread_from_thread_handle, but mark it as deprecated.
3658
3659 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3660
3661         * gdbthread.h (find_thread_by_handle): Revise declaration.
3662         * thread.c (find_thread_by_handle): Likewise.  Adjust
3663         implementation too.
3664         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3665         support for buffer objects as handles.
3666
3667 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3668
3669         * python/py-infthread.c (thpy_thread_handle): New function.
3670         (thread_object_methods): Register thpy_thread_handle.
3671
3672 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3673
3674         * gdbthread.h (thread_to_thread_handle): Declare.
3675         * thread.c (gdbtypes.h): Include.
3676         (thread_to_thread_handle): New function.
3677
3678         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3679         (target_thread_info_to_thread_handle): Declare.
3680         * target.c (target_thread_info_to_thread_handle): New function.
3681         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3682         * target-delegates.c: Regenerate.
3683
3684         * linux-thread-db.c (class thread_db_target): Add method
3685         thread_info_to_thread_handle.
3686         (thread_db_target::thread_info_to_thread_handle): Define.
3687         * remote.c (class remote_target): Add new method
3688         thread_info_to_thread_handle.
3689         (remote_target::thread_info_to_thread_handle): Define.
3690
3691 2019-04-08  Pedro Alves  <palves@redhat.com>
3692
3693         * common/common-exceptions.c (throw_exception): Don't create
3694         named object to throw; throw directly.
3695         (throw_it): Likewise.  Don't initialize gdb_exception::message
3696         here, with new; pass FMT and AP to the ctor instead.
3697         * common/common-exceptions.h: Include <string>.
3698         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3699         const char *, va_list)): New ctor.  Use std::make_shared.
3700         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3701         errors)): Delete.
3702         (gdb_exception_error::gdb_exception_error(enum errors, const char
3703         *, va_list)): New.
3704         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3705         Add assertion.
3706         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3707         errors)): Delete.
3708         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3709         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3710         Add assertion.
3711
3712 2019-04-08  Tom Tromey  <tom@tromey.com>
3713
3714         * valops.c (value_rtti_indirect_type): Replace throw_exception
3715         with throw.
3716         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3717         with throw.
3718         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3719         throw.
3720         * target.c (target_translate_tls_address): Replace throw_exception
3721         with throw.
3722         * stack.c (frame_apply_command_count): Replace throw_exception
3723         with throw.
3724         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3725         throw.
3726         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3727         with throw.
3728         * rs6000-tdep.c (rs6000_frame_cache)
3729         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3730         * remote.c: Replace throw_exception with throw.
3731         * record-full.c (record_full_message, record_full_wait_1)
3732         (record_full_restore): Replace throw_exception with throw.
3733         * record-btrace.c:
3734         (get_thread_current_frame_id, record_btrace_start_replaying)
3735         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3736         (cmd_record_btrace_start): Replace throw_exception with throw.
3737         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3738         throw.
3739         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3740         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3741         * linespec.c:
3742         (find_linespec_symbols): Replace throw_exception with throw.
3743         * infrun.c (displaced_step_prepare, resume): Replace
3744         throw_exception with throw.
3745         * infcmd.c (post_create_inferior): Replace throw_exception with
3746         throw.
3747         * inf-loop.c (inferior_event_handler): Replace throw_exception
3748         with throw.
3749         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3750         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3751         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3752         (get_prev_frame_always, get_frame_pc_if_available)
3753         (get_frame_address_in_block_if_available, get_frame_language):
3754         Replace throw_exception with throw.
3755         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3756         throw_exception with throw.
3757         * eval.c (fetch_subexp_value, evaluate_var_value)
3758         (evaluate_funcall, evaluate_subexp_standard): Replace
3759         throw_exception with throw.
3760         * dwarf2loc.c (call_site_find_chain)
3761         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3762         Replace throw_exception with throw.
3763         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3764         with throw.
3765         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3766         throw.
3767         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3768         * completer.c (complete_line_internal): Replace throw_exception
3769         with throw.
3770         * compile/compile-object-run.c (compile_object_run): Replace
3771         throw_exception with throw.
3772         * cli/cli-script.c (process_next_line): Replace throw_exception
3773         with throw.
3774         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3775         (btrace_enable, btrace_maint_update_pt_packets): Replace
3776         throw_exception with throw.
3777         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3778         throw_exception with throw.
3779         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3780         throw_exception with throw.
3781         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3782         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3783         * aarch64-tdep.c (aarch64_make_prologue_cache)
3784         (aarch64_make_stub_cache): Replace throw_exception with throw.
3785
3786 2019-04-08  Tom Tromey  <tom@tromey.com>
3787
3788         * common/common-exceptions.c (throw_exception): Rename from
3789         throw_exception_cxx.  Remove old copy.  Make argument const.
3790         (throw_it): Create and throw exception objects directly.
3791         * common/common-exceptions.h (throw_exception): Make argument
3792         const.
3793         (struct gdb_exception_error): Add constructor.
3794         (struct gdb_exception_quit): Add constructor.
3795
3796 2019-04-08  Tom Tromey  <tom@tromey.com>
3797
3798         * common/common-exceptions.h (exception_rethrow): Don't declare.
3799         (TRY_SJLJ): Update comment.
3800         (TRY, CATCH, END_CATCH): Remove.
3801         * common/common-exceptions.c (exception_rethrow): Remove.
3802
3803 2019-04-08  Tom Tromey  <tom@tromey.com>
3804
3805         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3806         Remove.
3807         (gdb_exception_error): Rename from
3808         gdb_exception_RETURN_MASK_ERROR.
3809         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3810         (gdb_quit_bad_alloc): Update.
3811         * aarch64-tdep.c: Update.
3812         * ada-lang.c: Update.
3813         * ada-typeprint.c: Update.
3814         * ada-valprint.c: Update.
3815         * amd64-tdep.c: Update.
3816         * arch-utils.c: Update.
3817         * break-catch-throw.c: Update.
3818         * breakpoint.c: Update.
3819         * btrace.c: Update.
3820         * c-varobj.c: Update.
3821         * cli/cli-cmds.c: Update.
3822         * cli/cli-interp.c: Update.
3823         * cli/cli-script.c: Update.
3824         * common/common-exceptions.c: Update.
3825         * common/new-op.c: Update.
3826         * common/selftest.c: Update.
3827         * compile/compile-c-symbols.c: Update.
3828         * compile/compile-cplus-symbols.c: Update.
3829         * compile/compile-object-load.c: Update.
3830         * compile/compile-object-run.c: Update.
3831         * completer.c: Update.
3832         * corelow.c: Update.
3833         * cp-abi.c: Update.
3834         * cp-support.c: Update.
3835         * cp-valprint.c: Update.
3836         * darwin-nat.c: Update.
3837         * disasm-selftests.c: Update.
3838         * dtrace-probe.c: Update.
3839         * dwarf-index-cache.c: Update.
3840         * dwarf-index-write.c: Update.
3841         * dwarf2-frame-tailcall.c: Update.
3842         * dwarf2-frame.c: Update.
3843         * dwarf2loc.c: Update.
3844         * dwarf2read.c: Update.
3845         * eval.c: Update.
3846         * event-loop.c: Update.
3847         * event-top.c: Update.
3848         * exec.c: Update.
3849         * f-valprint.c: Update.
3850         * fbsd-tdep.c: Update.
3851         * frame-unwind.c: Update.
3852         * frame.c: Update.
3853         * gdbtypes.c: Update.
3854         * gnu-v3-abi.c: Update.
3855         * guile/guile-internal.h: Update.
3856         * guile/scm-block.c: Update.
3857         * guile/scm-breakpoint.c: Update.
3858         * guile/scm-cmd.c: Update.
3859         * guile/scm-disasm.c: Update.
3860         * guile/scm-frame.c: Update.
3861         * guile/scm-lazy-string.c: Update.
3862         * guile/scm-math.c: Update.
3863         * guile/scm-param.c: Update.
3864         * guile/scm-ports.c: Update.
3865         * guile/scm-pretty-print.c: Update.
3866         * guile/scm-symbol.c: Update.
3867         * guile/scm-symtab.c: Update.
3868         * guile/scm-type.c: Update.
3869         * guile/scm-value.c: Update.
3870         * i386-linux-tdep.c: Update.
3871         * i386-tdep.c: Update.
3872         * inf-loop.c: Update.
3873         * infcall.c: Update.
3874         * infcmd.c: Update.
3875         * infrun.c: Update.
3876         * jit.c: Update.
3877         * language.c: Update.
3878         * linespec.c: Update.
3879         * linux-fork.c: Update.
3880         * linux-nat.c: Update.
3881         * linux-tdep.c: Update.
3882         * linux-thread-db.c: Update.
3883         * main.c: Update.
3884         * mi/mi-cmd-break.c: Update.
3885         * mi/mi-cmd-stack.c: Update.
3886         * mi/mi-interp.c: Update.
3887         * mi/mi-main.c: Update.
3888         * objc-lang.c: Update.
3889         * p-valprint.c: Update.
3890         * parse.c: Update.
3891         * ppc-linux-tdep.c: Update.
3892         * printcmd.c: Update.
3893         * python/py-arch.c: Update.
3894         * python/py-breakpoint.c: Update.
3895         * python/py-cmd.c: Update.
3896         * python/py-finishbreakpoint.c: Update.
3897         * python/py-frame.c: Update.
3898         * python/py-framefilter.c: Update.
3899         * python/py-gdb-readline.c: Update.
3900         * python/py-inferior.c: Update.
3901         * python/py-infthread.c: Update.
3902         * python/py-lazy-string.c: Update.
3903         * python/py-linetable.c: Update.
3904         * python/py-objfile.c: Update.
3905         * python/py-param.c: Update.
3906         * python/py-prettyprint.c: Update.
3907         * python/py-progspace.c: Update.
3908         * python/py-record-btrace.c: Update.
3909         * python/py-record.c: Update.
3910         * python/py-symbol.c: Update.
3911         * python/py-type.c: Update.
3912         * python/py-unwind.c: Update.
3913         * python/py-utils.c: Update.
3914         * python/py-value.c: Update.
3915         * python/python.c: Update.
3916         * record-btrace.c: Update.
3917         * record-full.c: Update.
3918         * remote-fileio.c: Update.
3919         * remote.c: Update.
3920         * riscv-tdep.c: Update.
3921         * rs6000-aix-tdep.c: Update.
3922         * rs6000-tdep.c: Update.
3923         * rust-exp.y: Update.
3924         * rust-lang.c: Update.
3925         * s390-tdep.c: Update.
3926         * selftest-arch.c: Update.
3927         * solib-dsbt.c: Update.
3928         * solib-frv.c: Update.
3929         * solib-spu.c: Update.
3930         * solib-svr4.c: Update.
3931         * solib.c: Update.
3932         * sparc64-linux-tdep.c: Update.
3933         * stack.c: Update.
3934         * symfile-mem.c: Update.
3935         * symmisc.c: Update.
3936         * target.c: Update.
3937         * thread.c: Update.
3938         * top.c: Update.
3939         * tracefile-tfile.c: Update.
3940         * tui/tui.c: Update.
3941         * typeprint.c: Update.
3942         * unittests/cli-utils-selftests.c: Update.
3943         * unittests/parse-connection-spec-selftests.c: Update.
3944         * valops.c: Update.
3945         * valprint.c: Update.
3946         * value.c: Update.
3947         * varobj.c: Update.
3948         * windows-nat.c: Update.
3949         * x86-linux-nat.c: Update.
3950         * xml-support.c: Update.
3951
3952 2019-04-08  Tom Tromey  <tom@tromey.com>
3953
3954         * xml-support.c: Use C++ exception handling.
3955         * x86-linux-nat.c: Use C++ exception handling.
3956         * windows-nat.c: Use C++ exception handling.
3957         * varobj.c: Use C++ exception handling.
3958         * value.c: Use C++ exception handling.
3959         * valprint.c: Use C++ exception handling.
3960         * valops.c: Use C++ exception handling.
3961         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3962         handling.
3963         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3964         * typeprint.c: Use C++ exception handling.
3965         * tui/tui.c: Use C++ exception handling.
3966         * tracefile-tfile.c: Use C++ exception handling.
3967         * top.c: Use C++ exception handling.
3968         * thread.c: Use C++ exception handling.
3969         * target.c: Use C++ exception handling.
3970         * symmisc.c: Use C++ exception handling.
3971         * symfile-mem.c: Use C++ exception handling.
3972         * stack.c: Use C++ exception handling.
3973         * sparc64-linux-tdep.c: Use C++ exception handling.
3974         * solib.c: Use C++ exception handling.
3975         * solib-svr4.c: Use C++ exception handling.
3976         * solib-spu.c: Use C++ exception handling.
3977         * solib-frv.c: Use C++ exception handling.
3978         * solib-dsbt.c: Use C++ exception handling.
3979         * selftest-arch.c: Use C++ exception handling.
3980         * s390-tdep.c: Use C++ exception handling.
3981         * rust-lang.c: Use C++ exception handling.
3982         * rust-exp.y: Use C++ exception handling.
3983         * rs6000-tdep.c: Use C++ exception handling.
3984         * rs6000-aix-tdep.c: Use C++ exception handling.
3985         * riscv-tdep.c: Use C++ exception handling.
3986         * remote.c: Use C++ exception handling.
3987         * remote-fileio.c: Use C++ exception handling.
3988         * record-full.c: Use C++ exception handling.
3989         * record-btrace.c: Use C++ exception handling.
3990         * python/python.c: Use C++ exception handling.
3991         * python/py-value.c: Use C++ exception handling.
3992         * python/py-utils.c: Use C++ exception handling.
3993         * python/py-unwind.c: Use C++ exception handling.
3994         * python/py-type.c: Use C++ exception handling.
3995         * python/py-symbol.c: Use C++ exception handling.
3996         * python/py-record.c: Use C++ exception handling.
3997         * python/py-record-btrace.c: Use C++ exception handling.
3998         * python/py-progspace.c: Use C++ exception handling.
3999         * python/py-prettyprint.c: Use C++ exception handling.
4000         * python/py-param.c: Use C++ exception handling.
4001         * python/py-objfile.c: Use C++ exception handling.
4002         * python/py-linetable.c: Use C++ exception handling.
4003         * python/py-lazy-string.c: Use C++ exception handling.
4004         * python/py-infthread.c: Use C++ exception handling.
4005         * python/py-inferior.c: Use C++ exception handling.
4006         * python/py-gdb-readline.c: Use C++ exception handling.
4007         * python/py-framefilter.c: Use C++ exception handling.
4008         * python/py-frame.c: Use C++ exception handling.
4009         * python/py-finishbreakpoint.c: Use C++ exception handling.
4010         * python/py-cmd.c: Use C++ exception handling.
4011         * python/py-breakpoint.c: Use C++ exception handling.
4012         * python/py-arch.c: Use C++ exception handling.
4013         * printcmd.c: Use C++ exception handling.
4014         * ppc-linux-tdep.c: Use C++ exception handling.
4015         * parse.c: Use C++ exception handling.
4016         * p-valprint.c: Use C++ exception handling.
4017         * objc-lang.c: Use C++ exception handling.
4018         * mi/mi-main.c: Use C++ exception handling.
4019         * mi/mi-interp.c: Use C++ exception handling.
4020         * mi/mi-cmd-stack.c: Use C++ exception handling.
4021         * mi/mi-cmd-break.c: Use C++ exception handling.
4022         * main.c: Use C++ exception handling.
4023         * linux-thread-db.c: Use C++ exception handling.
4024         * linux-tdep.c: Use C++ exception handling.
4025         * linux-nat.c: Use C++ exception handling.
4026         * linux-fork.c: Use C++ exception handling.
4027         * linespec.c: Use C++ exception handling.
4028         * language.c: Use C++ exception handling.
4029         * jit.c: Use C++ exception handling.
4030         * infrun.c: Use C++ exception handling.
4031         * infcmd.c: Use C++ exception handling.
4032         * infcall.c: Use C++ exception handling.
4033         * inf-loop.c: Use C++ exception handling.
4034         * i386-tdep.c: Use C++ exception handling.
4035         * i386-linux-tdep.c: Use C++ exception handling.
4036         * guile/scm-value.c: Use C++ exception handling.
4037         * guile/scm-type.c: Use C++ exception handling.
4038         * guile/scm-symtab.c: Use C++ exception handling.
4039         * guile/scm-symbol.c: Use C++ exception handling.
4040         * guile/scm-pretty-print.c: Use C++ exception handling.
4041         * guile/scm-ports.c: Use C++ exception handling.
4042         * guile/scm-param.c: Use C++ exception handling.
4043         * guile/scm-math.c: Use C++ exception handling.
4044         * guile/scm-lazy-string.c: Use C++ exception handling.
4045         * guile/scm-frame.c: Use C++ exception handling.
4046         * guile/scm-disasm.c: Use C++ exception handling.
4047         * guile/scm-cmd.c: Use C++ exception handling.
4048         * guile/scm-breakpoint.c: Use C++ exception handling.
4049         * guile/scm-block.c: Use C++ exception handling.
4050         * guile/guile-internal.h: Use C++ exception handling.
4051         * gnu-v3-abi.c: Use C++ exception handling.
4052         * gdbtypes.c: Use C++ exception handling.
4053         * frame.c: Use C++ exception handling.
4054         * frame-unwind.c: Use C++ exception handling.
4055         * fbsd-tdep.c: Use C++ exception handling.
4056         * f-valprint.c: Use C++ exception handling.
4057         * exec.c: Use C++ exception handling.
4058         * event-top.c: Use C++ exception handling.
4059         * event-loop.c: Use C++ exception handling.
4060         * eval.c: Use C++ exception handling.
4061         * dwarf2read.c: Use C++ exception handling.
4062         * dwarf2loc.c: Use C++ exception handling.
4063         * dwarf2-frame.c: Use C++ exception handling.
4064         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4065         * dwarf-index-write.c: Use C++ exception handling.
4066         * dwarf-index-cache.c: Use C++ exception handling.
4067         * dtrace-probe.c: Use C++ exception handling.
4068         * disasm-selftests.c: Use C++ exception handling.
4069         * darwin-nat.c: Use C++ exception handling.
4070         * cp-valprint.c: Use C++ exception handling.
4071         * cp-support.c: Use C++ exception handling.
4072         * cp-abi.c: Use C++ exception handling.
4073         * corelow.c: Use C++ exception handling.
4074         * completer.c: Use C++ exception handling.
4075         * compile/compile-object-run.c: Use C++ exception handling.
4076         * compile/compile-object-load.c: Use C++ exception handling.
4077         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4078         * compile/compile-c-symbols.c: Use C++ exception handling.
4079         * common/selftest.c: Use C++ exception handling.
4080         * common/new-op.c: Use C++ exception handling.
4081         * cli/cli-script.c: Use C++ exception handling.
4082         * cli/cli-interp.c: Use C++ exception handling.
4083         * cli/cli-cmds.c: Use C++ exception handling.
4084         * c-varobj.c: Use C++ exception handling.
4085         * btrace.c: Use C++ exception handling.
4086         * breakpoint.c: Use C++ exception handling.
4087         * break-catch-throw.c: Use C++ exception handling.
4088         * arch-utils.c: Use C++ exception handling.
4089         * amd64-tdep.c: Use C++ exception handling.
4090         * ada-valprint.c: Use C++ exception handling.
4091         * ada-typeprint.c: Use C++ exception handling.
4092         * ada-lang.c: Use C++ exception handling.
4093         * aarch64-tdep.c: Use C++ exception handling.
4094
4095 2019-04-08  Tom Tromey  <tom@tromey.com>
4096
4097         * xml-support.c (gdb_xml_parser::parse): Update.
4098         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4099         * value.c (show_convenience): Update.
4100         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4101         (test_parse_flags_qcs): Update.
4102         * thread.c (thr_try_catch_cmd): Update.
4103         * target.c (target_translate_tls_address): Update.
4104         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4105         (info_frame_command_core, frame_apply_command_count): Update.
4106         * rust-exp.y (rust_lex_exception_test): Update.
4107         * riscv-tdep.c (riscv_print_one_register_info): Update.
4108         * remote.c (remote_target::enable_btrace): Update.
4109         * record-btrace.c (record_btrace_enable_warn): Update.
4110         * python/py-utils.c (gdbpy_convert_exception): Update.
4111         * printcmd.c (do_one_display, print_variable_and_value): Update.
4112         * mi/mi-main.c (mi_print_exception): Update.
4113         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4114         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4115         * linux-nat.c (linux_nat_target::attach): Update.
4116         * linux-fork.c (class scoped_switch_fork_info): Update.
4117         * infrun.c (displaced_step_prepare): Update.
4118         * infcall.c (call_function_by_hand_dummy): Update.
4119         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4120         * gnu-v3-abi.c (print_one_vtable): Update.
4121         * frame.c (get_prev_frame_always): Update.
4122         * f-valprint.c (info_common_command_for_block): Update.
4123         * exec.c (try_open_exec_file): Update.
4124         * exceptions.c (print_exception, exception_print)
4125         (exception_fprintf, exception_print_same): Update.
4126         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4127         * dwarf-index-cache.c (index_cache::store)
4128         (index_cache::lookup_gdb_index): Update.
4129         * darwin-nat.c (maybe_cache_shell): Update.
4130         * cp-valprint.c (cp_print_value_fields): Update.
4131         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4132         (gcc_cplus_symbol_address): Update.
4133         * compile/compile-c-symbols.c (gcc_convert_symbol)
4134         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4135         * common/selftest.c: Update.
4136         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4137         a std::string.
4138         (exception_try_scope_entry, exception_try_scope_exit): Don't
4139         declare.
4140         (struct exception_try_scope): Remove.
4141         (TRY): Don't use exception_try_scope.
4142         (struct gdb_exception): Add constructor, operator=.
4143         <what>: New method.
4144         (struct gdb_exception_RETURN_MASK_ALL)
4145         (struct gdb_exception_RETURN_MASK_ERROR)
4146         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4147         (struct gdb_quit_bad_alloc): Update.
4148         * common/common-exceptions.c (exception_none): Change
4149         initializer.
4150         (struct catcher) <state, exception>: Initialize inline.
4151         <prev>: Remove member.
4152         (current_catcher): Remove.
4153         (catchers): New global.
4154         (exceptions_state_mc_init): Simplify.
4155         (catcher_pop): Remove.
4156         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4157         (try_scope_depth, exception_try_scope_entry)
4158         (exception_try_scope_exit): Remove.
4159         (throw_exception_sjlj): Update.
4160         (exception_messages, exception_messages_size): Remove.
4161         (throw_it): Simplify.
4162         (gdb_exception_sliced_copy): Remove.
4163         (throw_exception_cxx): Update.
4164         * cli/cli-script.c (script_from_file): Update.
4165         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4166         Update.
4167         * ada-valprint.c (ada_val_print): Update.
4168         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4169         (create_excep_cond_exprs): Update.
4170
4171 2019-04-08  Tom Tromey  <tom@tromey.com>
4172
4173         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4174         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4175         (TRY, CATCH, END_CATCH): Remove some definitions.
4176         * common/common-exceptions.c: Don't use GDB_XCPT.
4177         (catcher_list_size): Remove.
4178         (throw_exception, throw_it): Simplify.
4179
4180 2019-04-05  Tom Tromey  <tom@tromey.com>
4181
4182         Revert the header-sorting patch.
4183         * ft32-tdep.c: Revert.
4184         * frv-tdep.c: Revert.
4185         * frv-linux-tdep.c: Revert.
4186         * frame.c: Revert.
4187         * frame-unwind.c: Revert.
4188         * frame-base.c: Revert.
4189         * fork-child.c: Revert.
4190         * findvar.c: Revert.
4191         * findcmd.c: Revert.
4192         * filesystem.c: Revert.
4193         * filename-seen-cache.h: Revert.
4194         * filename-seen-cache.c: Revert.
4195         * fbsd-tdep.c: Revert.
4196         * fbsd-nat.h: Revert.
4197         * fbsd-nat.c: Revert.
4198         * f-valprint.c: Revert.
4199         * f-typeprint.c: Revert.
4200         * f-lang.c: Revert.
4201         * extension.h: Revert.
4202         * extension.c: Revert.
4203         * extension-priv.h: Revert.
4204         * expprint.c: Revert.
4205         * exec.h: Revert.
4206         * exec.c: Revert.
4207         * exceptions.c: Revert.
4208         * event-top.c: Revert.
4209         * event-loop.c: Revert.
4210         * eval.c: Revert.
4211         * elfread.c: Revert.
4212         * dwarf2read.h: Revert.
4213         * dwarf2read.c: Revert.
4214         * dwarf2loc.c: Revert.
4215         * dwarf2expr.h: Revert.
4216         * dwarf2expr.c: Revert.
4217         * dwarf2-frame.c: Revert.
4218         * dwarf2-frame-tailcall.c: Revert.
4219         * dwarf-index-write.h: Revert.
4220         * dwarf-index-write.c: Revert.
4221         * dwarf-index-common.c: Revert.
4222         * dwarf-index-cache.h: Revert.
4223         * dwarf-index-cache.c: Revert.
4224         * dummy-frame.c: Revert.
4225         * dtrace-probe.c: Revert.
4226         * disasm.h: Revert.
4227         * disasm.c: Revert.
4228         * disasm-selftests.c: Revert.
4229         * dictionary.c: Revert.
4230         * dicos-tdep.c: Revert.
4231         * demangle.c: Revert.
4232         * dcache.h: Revert.
4233         * dcache.c: Revert.
4234         * darwin-nat.h: Revert.
4235         * darwin-nat.c: Revert.
4236         * darwin-nat-info.c: Revert.
4237         * d-valprint.c: Revert.
4238         * d-namespace.c: Revert.
4239         * d-lang.c: Revert.
4240         * ctf.c: Revert.
4241         * csky-tdep.c: Revert.
4242         * csky-linux-tdep.c: Revert.
4243         * cris-tdep.c: Revert.
4244         * cris-linux-tdep.c: Revert.
4245         * cp-valprint.c: Revert.
4246         * cp-support.c: Revert.
4247         * cp-namespace.c: Revert.
4248         * cp-abi.c: Revert.
4249         * corelow.c: Revert.
4250         * corefile.c: Revert.
4251         * continuations.c: Revert.
4252         * completer.h: Revert.
4253         * completer.c: Revert.
4254         * complaints.c: Revert.
4255         * coffread.c: Revert.
4256         * coff-pe-read.c: Revert.
4257         * cli-out.h: Revert.
4258         * cli-out.c: Revert.
4259         * charset.c: Revert.
4260         * c-varobj.c: Revert.
4261         * c-valprint.c: Revert.
4262         * c-typeprint.c: Revert.
4263         * c-lang.c: Revert.
4264         * buildsym.c: Revert.
4265         * buildsym-legacy.c: Revert.
4266         * build-id.h: Revert.
4267         * build-id.c: Revert.
4268         * btrace.c: Revert.
4269         * bsd-uthread.c: Revert.
4270         * breakpoint.h: Revert.
4271         * breakpoint.c: Revert.
4272         * break-catch-throw.c: Revert.
4273         * break-catch-syscall.c: Revert.
4274         * break-catch-sig.c: Revert.
4275         * blockframe.c: Revert.
4276         * block.c: Revert.
4277         * bfin-tdep.c: Revert.
4278         * bfin-linux-tdep.c: Revert.
4279         * bfd-target.c: Revert.
4280         * bcache.c: Revert.
4281         * ax-general.c: Revert.
4282         * ax-gdb.h: Revert.
4283         * ax-gdb.c: Revert.
4284         * avr-tdep.c: Revert.
4285         * auxv.c: Revert.
4286         * auto-load.c: Revert.
4287         * arm-wince-tdep.c: Revert.
4288         * arm-tdep.c: Revert.
4289         * arm-symbian-tdep.c: Revert.
4290         * arm-pikeos-tdep.c: Revert.
4291         * arm-obsd-tdep.c: Revert.
4292         * arm-nbsd-tdep.c: Revert.
4293         * arm-nbsd-nat.c: Revert.
4294         * arm-linux-tdep.c: Revert.
4295         * arm-linux-nat.c: Revert.
4296         * arm-fbsd-tdep.c: Revert.
4297         * arm-fbsd-nat.c: Revert.
4298         * arm-bsd-tdep.c: Revert.
4299         * arch-utils.c: Revert.
4300         * arc-tdep.c: Revert.
4301         * arc-newlib-tdep.c: Revert.
4302         * annotate.h: Revert.
4303         * annotate.c: Revert.
4304         * amd64-windows-tdep.c: Revert.
4305         * amd64-windows-nat.c: Revert.
4306         * amd64-tdep.c: Revert.
4307         * amd64-sol2-tdep.c: Revert.
4308         * amd64-obsd-tdep.c: Revert.
4309         * amd64-obsd-nat.c: Revert.
4310         * amd64-nbsd-tdep.c: Revert.
4311         * amd64-nbsd-nat.c: Revert.
4312         * amd64-nat.c: Revert.
4313         * amd64-linux-tdep.c: Revert.
4314         * amd64-linux-nat.c: Revert.
4315         * amd64-fbsd-tdep.c: Revert.
4316         * amd64-fbsd-nat.c: Revert.
4317         * amd64-dicos-tdep.c: Revert.
4318         * amd64-darwin-tdep.c: Revert.
4319         * amd64-bsd-nat.c: Revert.
4320         * alpha-tdep.c: Revert.
4321         * alpha-obsd-tdep.c: Revert.
4322         * alpha-nbsd-tdep.c: Revert.
4323         * alpha-mdebug-tdep.c: Revert.
4324         * alpha-linux-tdep.c: Revert.
4325         * alpha-linux-nat.c: Revert.
4326         * alpha-bsd-tdep.c: Revert.
4327         * alpha-bsd-nat.c: Revert.
4328         * aix-thread.c: Revert.
4329         * agent.c: Revert.
4330         * addrmap.c: Revert.
4331         * ada-varobj.c: Revert.
4332         * ada-valprint.c: Revert.
4333         * ada-typeprint.c: Revert.
4334         * ada-tasks.c: Revert.
4335         * ada-lang.c: Revert.
4336         * aarch64-tdep.c: Revert.
4337         * aarch64-ravenscar-thread.c: Revert.
4338         * aarch64-newlib-tdep.c: Revert.
4339         * aarch64-linux-tdep.c: Revert.
4340         * aarch64-linux-nat.c: Revert.
4341         * aarch64-fbsd-tdep.c: Revert.
4342         * aarch64-fbsd-nat.c: Revert.
4343         * aarch32-linux-nat.c: Revert.
4344
4345 2019-04-05  Tom Tromey  <tom@tromey.com>
4346
4347         * ft32-tdep.c: Sort headers.
4348         * frv-tdep.c: Sort headers.
4349         * frv-linux-tdep.c: Sort headers.
4350         * frame.c: Sort headers.
4351         * frame-unwind.c: Sort headers.
4352         * frame-base.c: Sort headers.
4353         * fork-child.c: Sort headers.
4354         * findvar.c: Sort headers.
4355         * findcmd.c: Sort headers.
4356         * filesystem.c: Sort headers.
4357         * filename-seen-cache.h: Sort headers.
4358         * filename-seen-cache.c: Sort headers.
4359         * fbsd-tdep.c: Sort headers.
4360         * fbsd-nat.h: Sort headers.
4361         * fbsd-nat.c: Sort headers.
4362         * f-valprint.c: Sort headers.
4363         * f-typeprint.c: Sort headers.
4364         * f-lang.c: Sort headers.
4365         * extension.h: Sort headers.
4366         * extension.c: Sort headers.
4367         * extension-priv.h: Sort headers.
4368         * expprint.c: Sort headers.
4369         * exec.h: Sort headers.
4370         * exec.c: Sort headers.
4371         * exceptions.c: Sort headers.
4372         * event-top.c: Sort headers.
4373         * event-loop.c: Sort headers.
4374         * eval.c: Sort headers.
4375         * elfread.c: Sort headers.
4376         * dwarf2read.h: Sort headers.
4377         * dwarf2read.c: Sort headers.
4378         * dwarf2loc.c: Sort headers.
4379         * dwarf2expr.h: Sort headers.
4380         * dwarf2expr.c: Sort headers.
4381         * dwarf2-frame.c: Sort headers.
4382         * dwarf2-frame-tailcall.c: Sort headers.
4383         * dwarf-index-write.h: Sort headers.
4384         * dwarf-index-write.c: Sort headers.
4385         * dwarf-index-common.c: Sort headers.
4386         * dwarf-index-cache.h: Sort headers.
4387         * dwarf-index-cache.c: Sort headers.
4388         * dummy-frame.c: Sort headers.
4389         * dtrace-probe.c: Sort headers.
4390         * disasm.h: Sort headers.
4391         * disasm.c: Sort headers.
4392         * disasm-selftests.c: Sort headers.
4393         * dictionary.c: Sort headers.
4394         * dicos-tdep.c: Sort headers.
4395         * demangle.c: Sort headers.
4396         * dcache.h: Sort headers.
4397         * dcache.c: Sort headers.
4398         * darwin-nat.h: Sort headers.
4399         * darwin-nat.c: Sort headers.
4400         * darwin-nat-info.c: Sort headers.
4401         * d-valprint.c: Sort headers.
4402         * d-namespace.c: Sort headers.
4403         * d-lang.c: Sort headers.
4404         * ctf.c: Sort headers.
4405         * csky-tdep.c: Sort headers.
4406         * csky-linux-tdep.c: Sort headers.
4407         * cris-tdep.c: Sort headers.
4408         * cris-linux-tdep.c: Sort headers.
4409         * cp-valprint.c: Sort headers.
4410         * cp-support.c: Sort headers.
4411         * cp-namespace.c: Sort headers.
4412         * cp-abi.c: Sort headers.
4413         * corelow.c: Sort headers.
4414         * corefile.c: Sort headers.
4415         * continuations.c: Sort headers.
4416         * completer.h: Sort headers.
4417         * completer.c: Sort headers.
4418         * complaints.c: Sort headers.
4419         * coffread.c: Sort headers.
4420         * coff-pe-read.c: Sort headers.
4421         * cli-out.h: Sort headers.
4422         * cli-out.c: Sort headers.
4423         * charset.c: Sort headers.
4424         * c-varobj.c: Sort headers.
4425         * c-valprint.c: Sort headers.
4426         * c-typeprint.c: Sort headers.
4427         * c-lang.c: Sort headers.
4428         * buildsym.c: Sort headers.
4429         * buildsym-legacy.c: Sort headers.
4430         * build-id.h: Sort headers.
4431         * build-id.c: Sort headers.
4432         * btrace.c: Sort headers.
4433         * bsd-uthread.c: Sort headers.
4434         * breakpoint.h: Sort headers.
4435         * breakpoint.c: Sort headers.
4436         * break-catch-throw.c: Sort headers.
4437         * break-catch-syscall.c: Sort headers.
4438         * break-catch-sig.c: Sort headers.
4439         * blockframe.c: Sort headers.
4440         * block.c: Sort headers.
4441         * bfin-tdep.c: Sort headers.
4442         * bfin-linux-tdep.c: Sort headers.
4443         * bfd-target.c: Sort headers.
4444         * bcache.c: Sort headers.
4445         * ax-general.c: Sort headers.
4446         * ax-gdb.h: Sort headers.
4447         * ax-gdb.c: Sort headers.
4448         * avr-tdep.c: Sort headers.
4449         * auxv.c: Sort headers.
4450         * auto-load.c: Sort headers.
4451         * arm-wince-tdep.c: Sort headers.
4452         * arm-tdep.c: Sort headers.
4453         * arm-symbian-tdep.c: Sort headers.
4454         * arm-pikeos-tdep.c: Sort headers.
4455         * arm-obsd-tdep.c: Sort headers.
4456         * arm-nbsd-tdep.c: Sort headers.
4457         * arm-nbsd-nat.c: Sort headers.
4458         * arm-linux-tdep.c: Sort headers.
4459         * arm-linux-nat.c: Sort headers.
4460         * arm-fbsd-tdep.c: Sort headers.
4461         * arm-fbsd-nat.c: Sort headers.
4462         * arm-bsd-tdep.c: Sort headers.
4463         * arch-utils.c: Sort headers.
4464         * arc-tdep.c: Sort headers.
4465         * arc-newlib-tdep.c: Sort headers.
4466         * annotate.h: Sort headers.
4467         * annotate.c: Sort headers.
4468         * amd64-windows-tdep.c: Sort headers.
4469         * amd64-windows-nat.c: Sort headers.
4470         * amd64-tdep.c: Sort headers.
4471         * amd64-sol2-tdep.c: Sort headers.
4472         * amd64-obsd-tdep.c: Sort headers.
4473         * amd64-obsd-nat.c: Sort headers.
4474         * amd64-nbsd-tdep.c: Sort headers.
4475         * amd64-nbsd-nat.c: Sort headers.
4476         * amd64-nat.c: Sort headers.
4477         * amd64-linux-tdep.c: Sort headers.
4478         * amd64-linux-nat.c: Sort headers.
4479         * amd64-fbsd-tdep.c: Sort headers.
4480         * amd64-fbsd-nat.c: Sort headers.
4481         * amd64-dicos-tdep.c: Sort headers.
4482         * amd64-darwin-tdep.c: Sort headers.
4483         * amd64-bsd-nat.c: Sort headers.
4484         * alpha-tdep.c: Sort headers.
4485         * alpha-obsd-tdep.c: Sort headers.
4486         * alpha-nbsd-tdep.c: Sort headers.
4487         * alpha-mdebug-tdep.c: Sort headers.
4488         * alpha-linux-tdep.c: Sort headers.
4489         * alpha-linux-nat.c: Sort headers.
4490         * alpha-bsd-tdep.c: Sort headers.
4491         * alpha-bsd-nat.c: Sort headers.
4492         * aix-thread.c: Sort headers.
4493         * agent.c: Sort headers.
4494         * addrmap.c: Sort headers.
4495         * ada-varobj.c: Sort headers.
4496         * ada-valprint.c: Sort headers.
4497         * ada-typeprint.c: Sort headers.
4498         * ada-tasks.c: Sort headers.
4499         * ada-lang.c: Sort headers.
4500         * aarch64-tdep.c: Sort headers.
4501         * aarch64-ravenscar-thread.c: Sort headers.
4502         * aarch64-newlib-tdep.c: Sort headers.
4503         * aarch64-linux-tdep.c: Sort headers.
4504         * aarch64-linux-nat.c: Sort headers.
4505         * aarch64-fbsd-tdep.c: Sort headers.
4506         * aarch64-fbsd-nat.c: Sort headers.
4507         * aarch32-linux-nat.c: Sort headers.
4508
4509 2019-04-04  Tom Tromey  <tom@tromey.com>
4510
4511         * varobj.c (varobj_create): Update.
4512         * rust-exp.y (struct rust_parser) <update_innermost_block,
4513         lookup_symbol>: New methods.
4514         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4515         Rename.
4516         (rust_parser::rust_lookup_type)
4517         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4518         * printcmd.c (display_command, do_one_display): Update.
4519         * parser-defs.h (struct parser_state) <parser_state>: Add
4520         "tracker" parameter.
4521         (block_tracker): New member.
4522         (class innermost_block_tracker) <innermost_block_tracker>: Add
4523         "types" parameter.
4524         <reset>: Remove method.
4525         (innermost_block): Don't declare.
4526         (null_post_parser): Update.
4527         * parse.c (innermost_block): Remove global.
4528         (write_dollar_variable): Update.
4529         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4530         Remove "tracker_types" parameter.
4531         (parse_expression): Add "tracker" parameter.
4532         (parse_expression_for_completion): Update.
4533         (null_post_parser): Add "tracker" parameter.
4534         * p-exp.y: Update rules.
4535         * m2-exp.y: Update rules.
4536         * language.h (struct language_defn) <la_post_parser>: Add
4537         "tracker" parameter.
4538         * go-exp.y: Update rules.
4539         * f-exp.y: Update rules.
4540         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4541         parameter.
4542         * d-exp.y: Update rules.
4543         * c-exp.y: Update rules.
4544         * breakpoint.c (set_breakpoint_condition): Create an
4545         innermost_block_tracker.
4546         (watch_command_1): Likewise.
4547         * ada-lang.c (resolve): Add "tracker" parameter.
4548         (resolve_subexp): Likewise.
4549         * ada-exp.y (write_var_from_sym): Update.
4550
4551 2019-04-04  Tom Tromey  <tom@tromey.com>
4552
4553         * type-stack.h: New file.
4554         * type-stack.c: New file.
4555         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4556         type-stack.h.
4557         (insert_into_type_stack, insert_type, push_type, push_type_int)
4558         (insert_type_address_space, pop_type, pop_type_int)
4559         (pop_typelist, pop_type_stack, append_type_stack)
4560         (push_type_stack, get_type_stack, push_typelist)
4561         (follow_type_instance_flags, follow_types): Don't declare.
4562         * parse.c (type_stack): Remove global.
4563         (parse_exp_in_context): Update.
4564         (insert_into_type_stack, insert_type, push_type, push_type_int)
4565         (insert_type_address_space, pop_type, pop_type_int)
4566         (pop_typelist, pop_type_stack, append_type_stack)
4567         (push_type_stack, get_type_stack, push_typelist)
4568         (follow_type_instance_flags, follow_types): Remove (moved to
4569         type-stack.c).
4570         * f-exp.y (type_stack): New global.
4571         Update rules.
4572         (push_kind_type, f_parse): Update.
4573         * d-exp.y (type_stack): New global.
4574         Update rules.
4575         (d_parse): Update.
4576         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4577         Update rules.
4578         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4579         (HFILES_NO_SRCDIR): Add type-stack.h.
4580
4581 2019-04-04  Tom Tromey  <tom@tromey.com>
4582
4583         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4584         (rust_parser::convert_ast_to_expression, rust_parse)
4585         (rust_lex_test_completion, rust_lex_tests): Update.
4586         * parser-defs.h (struct expr_completion_state): New.
4587         (struct parser_state) <parser_state>: Add completion parameter.
4588         <mark_struct_expression, mark_completion_tag>: New methods.
4589         <parse_completion, m_completion_state>: New members.
4590         (prefixify_expression, null_post_parser): Update.
4591         (mark_struct_expression, mark_completion_tag): Don't declare.
4592         * parse.c (parse_completion, expout_last_struct)
4593         (expout_tag_completion_type, expout_completion_name): Remove
4594         globals.
4595         (parser_state::mark_struct_expression)
4596         (parser_state::mark_completion_tag): Now methods.
4597         (prefixify_expression): Add last_struct parameter.
4598         (prefixify_subexp): Likewise.
4599         (parse_exp_1): Update.
4600         (parse_exp_in_context): Add cstate parameter.  Update.
4601         (parse_expression_for_completion): Create an
4602         expr_completion_state.
4603         (null_post_parser): Add "completion" parameter.
4604         * p-exp.y: Update rules.
4605         (yylex): Update.
4606         * language.h (struct language_defn) <la_post_parser>: Add
4607         "completing" parameter.
4608         * go-exp.y: Update rules.
4609         (lex_one_token): Update.
4610         * expression.h (parse_completion): Don't declare.
4611         * d-exp.y: Update rules.
4612         (lex_one_token): Update rules.
4613         * c-exp.y: Update rules.
4614         (lex_one_token): Update.
4615         * ada-lang.c (resolve): Add "parse_completion" parameter.
4616         (resolve_subexp): Likewise.
4617         (ada_resolve_function): Likewise.
4618
4619 2019-04-04  Tom Tromey  <tom@tromey.com>
4620
4621         * parser-defs.h (struct parser_state) <start_arglist,
4622         end_arglist>: New methods.
4623         <arglist_len, m_funcall_chain>: New members.
4624         (arglist_len, start_arglist, end_arglist): Don't declare.
4625         * parse.c (arglist_len, funcall_chain): Remove global.
4626         (start_arglist, end_arglist): Remove functions.
4627         (parse_exp_in_context): Update.
4628         * p-exp.y: Update rules.
4629         * m2-exp.y: Update rules.
4630         * go-exp.y: Update rules.
4631         * f-exp.y: Update rules.
4632         * d-exp.y: Update rules.
4633         * c-exp.y: Update rules.
4634
4635 2019-04-04  Tom Tromey  <tom@tromey.com>
4636
4637         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4638         lex_operator, push_back>: New methods.
4639         Update all rules.
4640         (rust_parser::lex_hex, lex_escape): Rename and update.
4641         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4642         (rust_parser::lex_operator): Rename and update.
4643         (rust_parser::lex_number, rustyylex, rustyyerror)
4644         (rust_lex_test_init, rust_lex_test_sequence)
4645         (rust_lex_test_push_back, rust_lex_tests): Update.
4646         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4647         parameter.
4648         <lexptr, prev_lexptr>: New members.
4649         (lexptr, prev_lexptr): Don't declare.
4650         * parse.c (lexptr, prev_lexptr): Remove globals.
4651         (parse_exp_in_context): Update.
4652         * p-exp.y (yylex, yyerror): Update.
4653         * m2-exp.y (parse_number, yylex, yyerror): Update.
4654         * go-exp.y (lex_one_token, yyerror): Update.
4655         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4656         * d-exp.y (lex_one_token, yyerror): Update.
4657         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4658         (lex_one_token, yyerror): Update.
4659         * ada-lex.l (YY_INPUT): Update.
4660         (rewind_to_char): Update.
4661         * ada-exp.y (yyerror): Update.
4662
4663 2019-04-04  Tom Tromey  <tom@tromey.com>
4664
4665         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4666         * parser-defs.h (struct parser_state) <parser_state>: Add new
4667         parameter.
4668         <comma_terminates>: New member.
4669         (comma_terminates): Don't declare global.
4670         * parse.c (comma_terminates): Remove global.
4671         (parse_exp_in_context): Update.
4672         * p-exp.y (yylex): Update.
4673         * m2-exp.y (yylex): Update.
4674         * go-exp.y (lex_one_token): Update.
4675         * f-exp.y (yylex): Update.
4676         * d-exp.y (lex_one_token): Update.
4677         * c-exp.y (lex_one_token): Update.
4678         * ada-lex.l: Update.
4679
4680 2019-04-04  Tom Tromey  <tom@tromey.com>
4681
4682         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4683         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4684         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4685         * parser-defs.h (paren_depth): Don't declare.
4686         * parse.c (paren_depth): Remove global.
4687         (parse_exp_in_context): Update.
4688         * p-exp.y (paren_depth): New global.
4689         (pascal_parse): Initialize it.
4690         * m2-exp.y (paren_depth): New global.
4691         (m2_parse): Initialize it.
4692         * go-exp.y (paren_depth): New global.
4693         (go_parse): Initialize it.
4694         * f-exp.y (paren_depth): New global.
4695         (f_parse): Initialize it.
4696         * d-exp.y (paren_depth): New global.
4697         (d_parse): Initialize it.
4698         * c-exp.y (paren_depth): New global.
4699         (c_parse): Initialize it.
4700         * ada-lex.l (paren_depth): New global.
4701         (lexer_init): Initialize it.
4702
4703 2019-04-04  Tom Tromey  <tom@tromey.com>
4704
4705         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4706         (rust_parser::convert_ast_to_type)
4707         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4708         * parser-defs.h (struct parser_state) <parser_state>: Add
4709         parameters.  Initialize new members.
4710         <expression_context_block, expression_context_pc>: New members.
4711         * parse.c (expression_context_block, expression_context_pc):
4712         Remove globals.
4713         (parse_exp_in_context): Update.
4714         * p-exp.y: Update all rules.
4715         (yylex): Update.
4716         * m2-exp.y: Update all rules.
4717         (yylex): Update.
4718         * go-exp.y (yylex): Update.
4719         * f-exp.y (yylex): Update.
4720         * d-exp.y: Update all rules.
4721         (yylex): Update.
4722         * c-exp.y: Update all rules.
4723         (lex_one_token, classify_name, yylex, c_parse): Update.
4724         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4725
4726 2019-04-04  Tom Tromey  <tom@tromey.com>
4727
4728         * gdbarch.h, gdbarch.c: Rebuild.
4729         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4730         * stap-probe.h:
4731         (struct stap_parse_info): Replace "parser_state" with
4732         "expr_builder".
4733         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4734         (parser_state): New class.
4735         * parse.c (expr_builder): Rename.
4736         (expr_builder::release): Rename.
4737         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4738         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4739         (write_exp_elt_longcst, write_exp_elt_floatcst)
4740         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4741         (write_exp_string_vector, write_exp_bitstring)
4742         (write_exp_msymbol, mark_struct_expression)
4743         (write_dollar_variable)
4744         (insert_type_address_space, increase_expout_size): Replace
4745         "parser_state" with "expr_builder".
4746         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4747         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4748         "parser_state" with "expr_builder".
4749
4750 2019-04-04  Tom Tromey  <tom@tromey.com>
4751
4752         * rust-exp.y: Replace "parse_language" with method call.
4753         * p-exp.y:
4754         (yylex): Replace "parse_language" with method call.
4755         * m2-exp.y:
4756         (yylex): Replace "parse_language" with method call.
4757         * go-exp.y (classify_name): Replace "parse_language" with method
4758         call.
4759         * f-exp.y (yylex): Replace "parse_language" with method call.
4760         * d-exp.y (lex_one_token): Replace "parse_language" with method
4761         call.
4762         * c-exp.y:
4763         (lex_one_token, classify_name, yylex): Replace "parse_language"
4764         with method call.
4765         * ada-exp.y (find_primitive_type, type_char)
4766         (type_system_address): Replace "parse_language" with method call.
4767
4768 2019-04-04  Tom Tromey  <tom@tromey.com>
4769
4770         * rust-exp.y: Replace "parse_gdbarch" with method call.
4771         * parse.c (write_dollar_variable, insert_type_address_space):
4772         Replace "parse_gdbarch" with method call.
4773         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4774         call.
4775         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4776         call.
4777         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4778         "parse_gdbarch" with method call.
4779         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4780         with method call.
4781         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4782         "parse_gdbarch" with method call.
4783         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4784         "parse_gdbarch" with method call.
4785         * c-exp.y (parse_type, parse_number, classify_name): Replace
4786         "parse_gdbarch" with method call.
4787         * ada-lex.l: Replace "parse_gdbarch" with method call.
4788         * ada-exp.y (parse_type, find_primitive_type, type_char)
4789         (type_system_address): Replace "parse_gdbarch" with method call.
4790
4791 2019-04-04  Tom Tromey  <tom@tromey.com>
4792
4793         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4794         * stap-probe.c (stap_parse_argument): Update.
4795         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4796         initial_size parameter.
4797         * rust-exp.y (rust_lex_tests): Update.
4798         * parse.c (parser_state): Update.
4799         (parse_exp_in_context): Update.
4800         * parser-defs.h (struct parser_state) <parser_state>: Remove
4801         "initial_size" parameter.
4802
4803 2019-04-04  Tom Tromey  <tom@tromey.com>
4804
4805         * parser-defs.h (increase_expout_size): Don't declare.
4806         * parse.c (increase_expout_size): Now static.
4807
4808 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4809
4810         * gnu-nat.c (gnu_nat_target::wait): Fix
4811         target_waitstatus_to_string call.
4812
4813 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4814
4815         * eval.c (evaluate_subexp_standard): Handle internal functions
4816         during Fortran function call handling.
4817
4818 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4819
4820         * NEWS: Mention new internal functions.
4821         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4822         (read_base_type): Use dwarf2_init_complex_target_type.
4823         * value.c (creal_internal_fn): New function.
4824         (cimag_internal_fn): New function.
4825         (_initialize_values): Register new internal functions.
4826
4827 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4828
4829         * infrun.c (stop_all_threads): If debug_infrun, always
4830         trace the wait status after wait_one, using
4831         target_waitstatus_to_string and target_pid_to_str.
4832         (handle_inferior_event): Replace various trace of
4833         wait status kind by a single trace.
4834         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4835         wait status kind image by target_waitstatus_to_string.
4836         * target/waitstatus.c (target_waitstatus_to_string): Fix
4837         obsolete comment.
4838
4839 2019-04-01  Tom Tromey  <tromey@adacore.com>
4840
4841         PR symtab/23331:
4842         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4843
4844 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4845             Pedro Alves  <palves@redhat.com>
4846
4847         * top.c (quit_force): Call 'finalize_values'.
4848         * value.c (finalize_values): New function.
4849         * value.h (finalize_values): Declare.
4850
4851 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4852
4853         * NEWS: Announce $_gdb_major and $_gdb_minor.
4854
4855         * top.c (init_gdb_version_vars): New function.
4856         (gdb_init): Call init_gdb_version_vars.
4857
4858 2019-03-29  Tom Tromey  <tromey@adacore.com>
4859
4860         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4861         help text.  Remove dead code.
4862
4863 2019-03-29  Keith Seitz  <keiths@redhat.com>
4864
4865         From Siddhesh Poyarekar:
4866         * f-lang.h (f77_get_upperbound): Return LONGEST.
4867         (f77_get_lowerbound): Likewise.
4868         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4869         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4870         print them.
4871         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4872         plongest to format print it.
4873         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4874         (f77_get_upperbound): Likewise.
4875         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4876         LOWER_BOUND to LONGEST.
4877         (f77_create_arrayprint_offset_tbl): Likewise.
4878
4879 2019-03-29  Keith Seitz  <keiths@redhat.com>
4880
4881         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4882         %s/pulongest for TYPE_LENGTH instead of %d in format
4883         strings.
4884         * ada-typerint.c (ada_print_type): Likewise.
4885         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4886         * compile/compile-c-support.c (generate_register_struct): Likewise.
4887         * gdbtypes.c (recursive_dump_type): Likewise.
4888         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4889         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4890         instead of %d in format strings.
4891         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4892         to std::min to ULONGEST.
4893         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4894         instead of %d in format strings.
4895         * tracepoint.c (info_scope_command): Likewise.
4896         * typeprint.c (print_offset_data::update)
4897         (print_offset_data::finish): Likewise.
4898         * xtensa-tdep.c (xtensa_store_return_value)
4899         (xtensa_push_dummy_call): Likewise.
4900
4901 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4902
4903         * windows-nat.c (display_selector): Fixed format specifications
4904         for 64-bit Cygwin.
4905
4906 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4907
4908         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4909
4910 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4911
4912         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4913         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4914         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4915         (nios2_linux_init_abi): Install it.
4916
4917 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4918
4919         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4920
4921 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4922
4923         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4924
4925 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4926             Tom Tromey  <tromey@adacore.com>
4927
4928         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4929
4930 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4931
4932         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4933         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4934         method to compute the bounds of range types. Also print "[evaluated]"
4935         if the bounds' values come from a dynamic evaluation.
4936
4937 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4938
4939         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4940         whitespace when pretty printing is on.
4941
4942 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4943
4944         * ppc-linux-nat.c: Add include.
4945
4946 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4947
4948         * NEWS: Mention AArch64 Pointer Authentication.
4949
4950 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4951
4952         * arm-linux-nat.c: Add include.
4953
4954 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4955
4956         * source-cache.c (source_cache::get_source_lines): Re-read
4957         fullname after calling open_source_file.
4958
4959 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4960
4961         * NEWS: Mention TLS support for FreeBSD.
4962
4963 2019-03-25  Tom Tromey  <tromey@adacore.com>
4964
4965         * minsyms.c (BUNCH_SIZE): Update comment.
4966         (~minimal_symbol_reader): Remove old comment.
4967         (compact_minimal_symbols): Update comment.
4968         (minimal_symbol_reader::install): Remove old comment.  Update
4969         other comments.
4970
4971 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4972
4973         * s390-linux-nat.c: Add include.
4974
4975 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4976
4977         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4978         Call linux_get_hwcap.
4979         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4980         Likewise.
4981         (aarch64_linux_get_hwcap): Remove function.
4982         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4983         declaration.
4984         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4985         linux_get_hwcap.
4986         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4987         * linux-tdep.c (linux_get_hwcap): Add function.
4988         (linux_get_hwcap2): Likewise.
4989         * linux-tdep.h (linux_get_hwcap): Add declaration.
4990         (linux_get_hwcap2): Likewise.
4991         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4992         (ppc_linux_get_hwcap2): Likewise.
4993         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4994         linux_get_hwcap.
4995         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4996         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4997         (ppc_linux_nat_target::read_description): Likewise.
4998         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4999         * s390-linux-nat.c: Likewise.
5000         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5001
5002 2019-03-24  Tom Tromey  <tom@tromey.com>
5003
5004         * ada-lang.c (standard_lookup): Simplify initialization.
5005         (ada_lookup_symbol_nonlocal): Simplify return.
5006         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5007         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5008         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5009         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5010         initialization.
5011         * solib.c (solib_global_lookup): Simplify.
5012         * symtab.c (null_block_symbol): Remove.
5013         (symbol_cache_lookup): Simplify returns.
5014         (lookup_language_this): Simplify returns.
5015         (lookup_symbol_aux): Simplify return.
5016         (lookup_local_symbol): Simplify returns.
5017         (lookup_global_symbol_from_objfile): Simplify return.
5018         (lookup_symbol_in_objfile_symtabs)
5019         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5020         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5021         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5022         * cp-namespace.c (cp_lookup_bare_symbol)
5023         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5024         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5025         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5026         (cp_lookup_symbol_via_imports): Simplify initialization.
5027         (find_symbol_in_baseclass): Likewise.
5028         * symtab.h (null_block_symbol): Remove.
5029         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5030         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5031         (d_lookup_symbol_module): Likewise.
5032         (find_symbol_in_baseclass): Simplify initialization.
5033
5034 2019-03-24  Tom Tromey  <tom@tromey.com>
5035
5036         * expression.h: Don't include symtab.h.
5037         (struct block): Forward declare.
5038
5039 2019-03-24  Tom Tromey  <tom@tromey.com>
5040
5041         * c-exp.y (typebase): Remove casts.
5042         * gdbtypes.c (lookup_unsigned_typename, )
5043         (lookup_signed_typename): Remove cast.
5044         * eval.c (parse_to_comma_and_eval): Remove cast.
5045         * parse.c (write_dollar_variable): Remove cast.
5046         * block.h (struct block) <superblock>: Now const.
5047         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5048         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5049         (map_block): Make "block" const.
5050         * symfile.h (struct quick_symbol_functions)
5051         <map_matching_symbols>: Constify block argument to "callback".
5052         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5053         const.
5054         (find_pc_sect_compunit_symtab): Make "b" const.
5055         (find_symbol_at_address): Likewise.
5056         (search_symbols): Likewise.
5057         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5058         (dw2_debug_names_lookup_symbol): Likewise.
5059         (dw2_map_matching_symbols): Update.
5060         * p-valprint.c (pascal_val_print): Remove "block".
5061         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5062         (aux_add_nonlocal_symbols): Make "block" const.
5063         (resolve_subexp): Remove cast.
5064         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5065         const.
5066         (iterate_over_file_blocks): Likewise.
5067         * f-exp.y (%union) <bval>: Remove.
5068         * coffread.c (patch_opaque_types): Make "b" const.
5069         * spu-tdep.c (spu_catch_start): Make "block" const.
5070         * c-valprint.c (print_unpacked_pointer): Remove "block".
5071         * symmisc.c (dump_symtab_1): Make "b" const.
5072         (block_depth): Make "block" const.
5073         * d-exp.y (%union) <bval>: Remove.
5074         * cp-support.h (cp_lookup_rtti_type): Update.
5075         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5076         * psymtab.c (psym_lookup_symbol): Make "block" const.
5077         (maintenance_check_psymtabs): Make "b" const.
5078         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5079         (enumerate_locals, enumerate_args): Update.
5080         * python/py-symtab.c (stpy_global_block): Make "block" const.
5081         (stpy_static_block): Likewise.
5082         * inline-frame.c (block_starting_point_at): Make "new_block"
5083         const.
5084         * block.c (find_block_in_blockvector): Make return type const.
5085         (blockvector_for_pc_sect): Make "b" const.
5086         (find_block_in_blockvector): Make "b" const.
5087
5088 2019-03-23  Tom Tromey  <tom@tromey.com>
5089
5090         * varobj.c (varobj_create): Update.
5091         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5092         * printcmd.c (display_command, do_one_display): Don't reset
5093         innermost_block.
5094         * parser-defs.h (enum innermost_block_tracker_type): Move to
5095         expression.h.
5096         (innermost_block): Update comment.
5097         * parse.c (parse_exp_1): Add tracker_types parameter.
5098         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5099         tracker_types parameter.  Reset innermost_block.
5100         (parse_exp_in_context): Remove.
5101         (parse_expression_for_completion): Update.
5102         * objfiles.c (~objfile): Don't reset expression_context_block or
5103         innermost_block.
5104         * expression.h (enum innermost_block_tracker_type): Move from
5105         parser-defs.h.
5106         (parse_exp_1): Add tracker_types parameter.
5107         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5108         reset innermost_block.
5109
5110 2019-03-23  Tom Tromey  <tom@tromey.com>
5111
5112         * objfiles.h: Include bcache.h.
5113
5114 2019-03-23  Tom Tromey  <tom@tromey.com>
5115
5116         * linespec.c (get_current_search_block): Use
5117         scoped_restore_current_language.
5118         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5119
5120 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5121             Jiong Wang  <jiong.wang@arm.com>
5122
5123         * aarch64-linux-tdep.c
5124         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5125         section.
5126         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5127
5128 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5129             Jiong Wang  <jiong.wang@arm.com>
5130
5131         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5132         instructions.
5133         (aarch64_analyze_prologue_test): Add PACIASP test.
5134         (aarch64_prologue_prev_register): Unmask PC value.
5135
5136 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5137             Jiong Wang  <jiong.wang@arm.com>
5138
5139         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5140         (aarch64_dwarf2_prev_register): Unmask PC value.
5141         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5142         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5143         DW_CFA_AARCH64_negate_ra_state.
5144         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5145
5146 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5147             Jiong Wang  <jiong.wang@arm.com>
5148
5149         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5150         registers.
5151         (aarch64_pseudo_register_name): Likewise.
5152         (aarch64_pseudo_register_type): Likewise.
5153         (aarch64_pseudo_register_reggroup_p): Likewise.
5154         (aarch64_gdbarch_init): Add pauth registers.
5155         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5156         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5157         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5158         (struct gdbarch_tdep): Add regnum for ra_state.
5159
5160 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5161             Jiong Wang  <jiong.wang@arm.com>
5162
5163         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5164
5165 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5166             Jiong Wang  <jiong.wang@arm.com>
5167
5168         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5169         function.
5170         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5171         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5172         (aarch64_gdbarch_init): Add puth registers.
5173         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5174         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5175         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5176
5177 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5178             Jiong Wang  <jiong.wang@arm.com>
5179
5180         * aarch64-linux-nat.c
5181         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5182         * aarch64-linux-tdep.c
5183         (aarch64_linux_core_read_description): Likewise.
5184         (aarch64_linux_get_hwcap): New function.
5185         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5186         (aarch64_linux_get_hwcap): New declaration.
5187
5188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5189             Jiong Wang  <jiong.wang@arm.com>
5190
5191         * aarch64-linux-nat.c
5192         (aarch64_linux_nat_target::read_description): Add pauth param.
5193         * aarch64-linux-tdep.c
5194         (aarch64_linux_core_read_description): Likewise.
5195         * aarch64-tdep.c (struct target_desc): Add in pauth.
5196         (aarch64_read_description): Add pauth param.
5197         (aarch64_gdbarch_init): Likewise.
5198         * aarch64-tdep.h (aarch64_read_description): Likewise.
5199         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5200         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5201         * features/Makefile: Add new files.
5202         * features/aarch64-pauth.c: New file.
5203         * features/aarch64-pauth.xml: New file.
5204
5205 2019-03-20  Tom Tromey  <tromey@adacore.com>
5206
5207         * infrun.c (handle_inferior_event): Rename from
5208         handle_inferior_event_1.  Create a scoped_value_mark.
5209         (handle_inferior_event): Remove.
5210
5211 2019-03-19  Tom Tromey  <tromey@adacore.com>
5212
5213         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5214         * infrun.h (print_stop_event): Add "displays" parameter.
5215         * infrun.c (print_stop_event): Add "displays" parameter.
5216
5217 2019-03-19  Pedro Alves  <palves@redhat.com>
5218
5219         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5220         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5221         to -1.  Fix TABs vs spaces.
5222         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5223         * tui/tui-out.h (tui_ui_out) Add intro comments.
5224         <m_line, m_start_of_line>: In-class initialize, and add describing
5225         comment.
5226
5227 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5228
5229         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5230         variable names.
5231         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5232
5233 2019-03-18  Pedro Alves  <palves@redhat.com>
5234             Eli Zaretskii <eliz@gnu.org>
5235
5236         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5237         m_line and m_start_of_line.
5238
5239 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5240
5241         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5242         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5243         it returns a newline.  This fixes a regression in TU mode, whereby
5244         the next line is output on the same screen line as the user input.
5245
5246 2019-03-18  Tom Tromey  <tromey@adacore.com>
5247
5248         * minsyms.c (minimal_symbol_reader::install): Remove call to
5249         obstack_blank.
5250
5251 2019-03-18  Pedro Alves  <palves@redhat.com>
5252
5253         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5254         New globals.
5255         (apply_style): New, factored out from ...
5256         (apply_ansi_escape): ... this.  Handle reverse video mode.
5257         (tui_set_reverse_mode): New function.
5258         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5259         * tui/tui-winsource.c (tui_show_source_line): Use
5260         tui_set_reverse_mode instead of setting A_STANDOUT.
5261         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5262         New setter methods.
5263
5264 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5265
5266         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5267         Handle tabs.
5268
5269 2019-03-18  Tom Tromey  <tromey@adacore.com>
5270
5271         * ada-lang.c (empty_array): Add "high" parameter.
5272         (ada_evaluate_subexp): Update.
5273
5274 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5275
5276         * unittests/string_view-selftests.c: Define
5277         _initialize_string_view_selftests unconditionally.
5278
5279 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5280
5281         PR gdb/24350
5282         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5283
5284 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5285
5286         PR gdb/24351
5287         * windows-nat.c (display_selector): Fix format specifiers.
5288
5289 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5290
5291         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5292         tui_refill_source_window instead of tui_refresh_win, to update the
5293         current execution line.  This fixes redisplay of the current line
5294         when stepping through the code with "next" or "step".
5295
5296 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5297
5298         * source-cache.c (source_cache::get_source_lines): Call
5299         find_source_lines to initialize s->nlines.  This fixes vertical
5300         scrolling of TUI source window when the DOWN arrow is pressed.
5301
5302 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5303
5304         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5305         linux-thread-db.c (_initialize_thread_db): Likewise.
5306
5307 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5308
5309         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5310         wclrtoeol in tui_show_source_line".  This reverts changes made in
5311         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5312
5313 2019-03-15  Tom Tromey  <tom@tromey.com>
5314
5315         * symtab.h (struct minimal_symbol): Derive from
5316         general_symbol_info.
5317         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5318         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5319         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5320         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5321         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5322         (MSYMBOL_SEARCH_NAME): Update.
5323         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5324         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5325         * minsyms.c (minimal_symbol_reader::record_full): Update.
5326
5327 2019-03-15  Tom Tromey  <tom@tromey.com>
5328
5329         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5330
5331 2019-03-15  Tom Tromey  <tom@tromey.com>
5332
5333         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5334         unique_xmalloc_ptr.
5335         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5336         Update.
5337         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5338         (build_minimal_symbol_hash_tables)
5339         (minimal_symbol_reader::install): Update.
5340
5341 2019-03-15  Tom Tromey  <tom@tromey.com>
5342
5343         * symtab.c (create_demangled_names_hash): Update.
5344         (symbol_set_names): Update.
5345         * objfiles.h (struct objfile_per_bfd_storage)
5346         <demangled_names_hash>: Now an htab_up.
5347         * objfiles.c (objfile_per_bfd_storage): Simplify.
5348
5349 2019-03-15  Tom Tromey  <tom@tromey.com>
5350
5351         * objfiles.h (struct objfile_per_bfd_storage): Declare
5352         destructor.
5353         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5354         New.
5355         (get_objfile_bfd_data): Use new.  Don't initialize
5356         language_of_main.
5357         (free_objfile_per_bfd_storage): Remove.
5358         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5359
5360 2019-03-15  Tom Tromey  <tom@tromey.com>
5361
5362         * symfile.c (reread_symbols): Update.
5363         * objfiles.c (objfile::objfile): Update.
5364         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5365         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5366         comment.
5367         (minimal_symbol_reader::install): Update.
5368         (terminate_minimal_symbol_table): Remove.
5369         * jit.c (jit_object_close_impl): Update.
5370
5371 2019-03-15  Tom Tromey  <tom@tromey.com>
5372
5373         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5374         initializations.
5375
5376 2019-03-15  Tom Tromey  <tom@tromey.com>
5377
5378         * objfiles.h (struct objfile_per_bfd_storage)
5379         <demangled_hash_languages>: Now a bitset.
5380         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5381         (lookup_minimal_symbol): Update.
5382
5383 2019-03-15  Tom Tromey  <tom@tromey.com>
5384
5385         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5386         Don't return the symbol.
5387         * coffread.c (record_minimal_symbol): Use record_full.
5388
5389 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5390
5391         The MS-Windows port of ncurses fails to switch to a color pair if
5392         one or both of the colors are the implicit default colors.  This
5393         change records the default colors when TUI is initialized, and
5394         then specifies them explicitly when a color pair uses the default
5395         colors.  This allows color styling in TUI mode on MS-Windows.
5396
5397         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5398         ncurses_norm_attr.
5399         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5400         colors in ncurses_norm_attr.
5401         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5402         "none", replace it with the default color recorded in
5403         ncurses_norm_attr.
5404
5405 2019-03-14  Tom Tromey  <tromey@adacore.com>
5406
5407         * source-cache.h (class source_cache) <get_source_lines>: Return
5408         std::string.
5409         * source-cache.c (source_cache::extract_lines): Handle case where
5410         first_pos==npos.  Return std::string.
5411         (source_cache::get_source_lines): Update.
5412
5413 2019-03-14  Tom Tromey  <tromey@adacore.com>
5414
5415         * NEWS: Add item for "style sources" commands.
5416         * source-cache.c (source_cache::get_source_lines): Check
5417         source_styling.
5418         * cli/cli-style.c (source_styling): New global.
5419         (_initialize_cli_style): Add "style sources" commands.
5420         (show_style_sources): New function.
5421         * cli/cli-style.h (source_styling): Declare.
5422
5423 2019-03-14  Pedro Alves  <palves@redhat.com>
5424             Tom Tromey  <tromey@adacore.com>
5425
5426         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5427         * tui/tui-winsource.c (tui_refill_source_window): New function,
5428         from...
5429         (tui_horizontal_source_scroll): ... here.  Move some logic.
5430         * cli/cli-style.c (set_style_enabled): Notify new observable.
5431         * tui/tui-hooks.c (tui_redisplay_source): New function.
5432         (tui_attach_detach_observers): Attach or detach
5433         tui_redisplay_source.
5434         * observable.h (source_styling_changed): New observable.
5435         * observable.c: Define source_styling_changed observable.
5436
5437 2019-03-13  Tom Tromey  <tromey@adacore.com>
5438
5439         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5440         (i386_gnu_nat_target::store_registers): Update.
5441         * target-debug.h (target_debug_print_std_string): New macro.
5442         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5443         * windows-tdep.c (display_one_tib): Update.
5444         * tui/tui-stack.c (tui_make_status_line): Update.
5445         * top.c (print_inferior_quit_action): Update.
5446         * thread.c (thr_try_catch_cmd): Update.
5447         (add_thread_with_info): Update.
5448         (thread_target_id_str): Update.
5449         (thr_try_catch_cmd): Update.
5450         (thread_command): Update.
5451         (thread_find_command): Update.
5452         * record-btrace.c (record_btrace_target::info_record)
5453         (record_btrace_resume_thread, record_btrace_target::resume)
5454         (record_btrace_cancel_resume, record_btrace_step_thread)
5455         (record_btrace_target::wait, record_btrace_target::wait)
5456         (record_btrace_target::wait, record_btrace_target::stop): Update.
5457         * progspace.c (print_program_space): Update.
5458         * process-stratum-target.c
5459         (process_stratum_target::thread_address_space): Update.
5460         * linux-fork.c (linux_fork_mourn_inferior)
5461         (detach_checkpoint_command, info_checkpoints_command)
5462         (linux_fork_context): Update.
5463         (linux_fork_detach): Update.
5464         (class scoped_switch_fork_info): Update.
5465         (delete_checkpoint_command): Update.
5466         * infrun.c (follow_fork_inferior): Update.
5467         (follow_fork_inferior): Update.
5468         (proceed_after_vfork_done): Update.
5469         (handle_vfork_child_exec_or_exit): Update.
5470         (follow_exec): Update.
5471         (displaced_step_prepare_throw): Update.
5472         (displaced_step_restore): Update.
5473         (start_step_over): Update.
5474         (resume_1): Update.
5475         (clear_proceed_status_thread): Update.
5476         (proceed): Update.
5477         (print_target_wait_results): Update.
5478         (do_target_wait): Update.
5479         (context_switch): Update.
5480         (stop_all_threads): Update.
5481         (restart_threads): Update.
5482         (finish_step_over): Update.
5483         (handle_signal_stop): Update.
5484         (switch_back_to_stepped_thread): Update.
5485         (keep_going_pass_signal): Update.
5486         (print_exited_reason): Update.
5487         (normal_stop): Update.
5488         * inferior.c (inferior_pid_to_str): Change return type.
5489         (print_selected_inferior): Update.
5490         (add_inferior): Update.
5491         (detach_inferior): Update.
5492         * dummy-frame.c (fprint_dummy_frames): Update.
5493         * dcache.c (dcache_info_1): Update.
5494         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5495         (btrace_fetch, btrace_clear): Update.
5496         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5497         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5498         type.
5499         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5500         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5501         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5502         * gdbarch.c, gdbarch.h: Rebuild.
5503         * gdbarch.sh (core_pid_to_str): Change return type.
5504         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5505         return type.
5506         (windows_nat_target::pid_to_str): Change return type.
5507         (windows_delete_thread): Update.
5508         (windows_nat_target::attach): Update.
5509         (windows_nat_target::files_info): Update.
5510         * target-delegates.c: Rebuild.
5511         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5512         return type.
5513         (sol_thread_target::pid_to_str): Change return type.
5514         * remote.c (class remote_target) <pid_to_str>: Change return
5515         type.
5516         (remote_target::pid_to_str): Change return type.
5517         (extended_remote_target::attach, remote_target::remote_stop_ns)
5518         (remote_target::remote_notif_remove_queued_reply)
5519         (remote_target::push_stop_reply, remote_target::disable_btrace):
5520         Update.
5521         (extended_remote_target::attach): Update.
5522         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5523         type.
5524         (gdbsim_target::pid_to_str): Change return type.
5525         * ravenscar-thread.c (struct ravenscar_thread_target)
5526         <pid_to_str>: Change return type.
5527         (ravenscar_thread_target::pid_to_str): Change return type.
5528         * procfs.c (class procfs_target) <pid_to_str>: Change return
5529         type.
5530         (procfs_target::pid_to_str): Change return type.
5531         (procfs_target::attach): Update.
5532         (procfs_target::detach): Update.
5533         (procfs_target::fetch_registers): Update.
5534         (procfs_target::store_registers): Update.
5535         (procfs_target::wait): Update.
5536         (procfs_target::files_info): Update.
5537         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5538         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5539         return type.
5540         (nto_procfs_target::pid_to_str): Change return type.
5541         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5542         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5543         return type.
5544         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5545         (exit_lwp): Update.
5546         (attach_proc_task_lwp_callback, get_detach_signal)
5547         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5548         (linux_nat_target::resume, wait_lwp, stop_callback)
5549         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5550         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5551         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5552         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5553         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5554         type.
5555         (inf_ptrace_target::attach): Update.
5556         (inf_ptrace_target::files_info): Update.
5557         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5558         type.
5559         (go32_nat_target::pid_to_str): Change return type.
5560         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5561         (gnu_nat_target::wait): Update.
5562         (gnu_nat_target::wait): Update.
5563         (gnu_nat_target::resume): Update.
5564         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5565         (fbsd_nat_target::wait): Update.
5566         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5567         type.
5568         (darwin_nat_target::attach): Update.
5569         * corelow.c (class core_target) <pid_to_str>: Change return type.
5570         (core_target::pid_to_str): Change return type.
5571         * target.c (normal_pid_to_str): Change return type.
5572         (default_pid_to_str): Likewise.
5573         (target_pid_to_str): Change return type.
5574         (target_translate_tls_address): Update.
5575         (target_announce_detach): Update.
5576         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5577         return type.
5578         (bsd_uthread_target::pid_to_str): Change return type.
5579         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5580         type.
5581         (bsd_kvm_target::pid_to_str): Change return type.
5582         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5583         return type.
5584         (aix_thread_target::pid_to_str): Change return type.
5585         * target.h (struct target_ops) <pid_to_str>: Change return type.
5586         (target_pid_to_str, normal_pid_to_str): Likewise.
5587         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5588         type.
5589         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5590         type.
5591         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5592         return type.
5593         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5594         type.
5595         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5596         type.
5597         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5598         return type.
5599
5600 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5601
5602         * NEWS: Mention that the new default MI version is 3.  Mention
5603         changes to the output of commands and events that deal with
5604         multi-location breakpoints.
5605         * breakpoint.c: Include "mi/mi-out.h".
5606         (print_one_breakpoint): Change output syntax if using MI version
5607         >= 3.
5608         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5609         New.
5610         (mi_multi_location_breakpoint_output_fixed): New.
5611         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5612         (mi_cmd_fix_multi_location_breakpoint_output): New.
5613         (mi_multi_location_breakpoint_output_fixed): New.
5614         * mi/mi-cmds.c (mi_cmds): Register command
5615         -fix-multi-location-breakpoint-output.
5616         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5617         interpreter "mi".
5618
5619 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5620
5621         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5622         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5623         instantiate mi_ui_out based on interpreter name.
5624         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5625         * mi/mi-main.c (mi_load_progress): Likewise.
5626
5627 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5628
5629         * NEWS: Combine separate "New targets" sections for 8.3.
5630
5631 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5632
5633         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5634         (ppcfbsd_init_abi): Install gdbarch
5635         "fetch_tls_load_module_address" and "get_thread_local_address"
5636         methods.
5637
5638 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5639
5640         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5641         (riscv_fbsd_init_abi): Install gdbarch
5642         "fetch_tls_load_module_address" and "get_thread_local_address"
5643         methods.
5644
5645 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5646
5647         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5648         (i386fbsd_init_abi): Install gdbarch
5649         "fetch_tls_load_module_address" and "get_thread_local_address"
5650         methods.
5651
5652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5653
5654         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5655         (amd64fbsd_init_abi): Install gdbarch
5656         "fetch_tls_load_module_address" and "get_thread_local_address"
5657         methods.
5658
5659 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5660
5661         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5662         (struct fbsd_pspace_data): New type.
5663         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5664         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5665         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5666         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5667         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5668
5669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5670
5671         * gdbtypes.c (lookup_struct_elt): New function.
5672         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5673         * gdbtypes.h (struct struct_elt): New type.
5674         (lookup_struct_elt): New prototype.
5675
5676 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5677
5678         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5679         remove disabled code block.
5680
5681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5682
5683         * gdbarch.sh (get_thread_local_address): New method.
5684         * gdbarch.h, gdbarch.c: Regenerate.
5685         * target.c (target_translate_tls_address): Use
5686         gdbarch_get_thread_local_address if present instead of
5687         target::get_thread_local_address.
5688
5689 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5690
5691         * target.h (target::get_thread_local_address): Update comment.
5692
5693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5694
5695         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5696         objfile->separate_debug_objfile_backlink if not NULL.
5697
5698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5699
5700         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5701         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5702         (amd64bsd_store_inferior_registers): Likewise.
5703         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5704         Enable segment base registers.
5705         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5706         PT_GETFSBASE and PT_GETGSBASE.
5707         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5708         PT_SETGSBASE.
5709         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5710         segment base registers.
5711         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5712
5713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5714
5715         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5716         Update calls to i386_target_description to add 'segments'
5717         parameter.
5718         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5719         add segment base registers.
5720         * arch/i386.c (i386_create_target_description): Add 'segments'
5721         parameter to enable segment base registers.
5722         * arch/i386.h (i386_create_target_description): Likewise.
5723         * features/i386/32bit-segments.xml: New file.
5724         * features/i386/32bit-segments.c: Generate.
5725         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5726         call to i386_target_description to add 'segments' parameter.
5727         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5728         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5729         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5730         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5731         if feature is present.
5732         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5733         Add 'segments' parameter to call to i386_target_description.
5734         (i386_target_description): Add 'segments' parameter to enable
5735         segment base registers.
5736         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5737         to call to i386_target_description.
5738         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5739         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5740         Define I386_NUM_REGS.
5741         (i386_target_description): Add 'segments' parameter to enable
5742         segment base registers.
5743
5744 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5745
5746         PR/24325
5747         * source-cache.c: #undef open and close, to avoid unresolved
5748         externals during linking.
5749
5750 2019-03-12  Tom Tromey  <tromey@adacore.com>
5751
5752         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5753         const.  Add initializers.
5754         (_initialize_remote): Don't initialize ptid globals.
5755
5756 2019-03-12  Pedro Alves  <palves@redhat.com>
5757
5758         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5759
5760 2019-03-12  Pedro Alves  <palves@redhat.com>
5761
5762         * cp-name-parser.y (main): Remove unused 'len' variable.
5763
5764 2019-03-12  Tom Tromey  <tromey@adacore.com>
5765
5766         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5767         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5768
5769 2019-03-12  Tom Tromey  <tromey@adacore.com>
5770
5771         * linux-nat.c (iterate_over_lwps): Update.
5772         (stop_callback): Remove parameter.
5773         (stop_wait_callback, detach_callback, resume_set_callback)
5774         (select_singlestep_lwp_callback, set_ignore_sigint)
5775         (status_callback, resumed_callback, resume_clear_callback)
5776         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5777         data parameter.
5778         (linux_nat_target::detach, linux_nat_target::resume)
5779         (linux_stop_and_wait_all_lwps, select_event_lwp)
5780         (linux_nat_filter_event, linux_nat_wait_1)
5781         (linux_nat_target::kill, linux_nat_target::stop)
5782         (linux_nat_target::stop): Update.
5783         (linux_nat_resume_callback): Change type.
5784         (resume_stopped_resumed_lwps, count_events_callback)
5785         (select_event_lwp_callback): Likewise.
5786         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5787         * arm-linux-nat.c (struct update_registers_data): Remove.
5788         (update_registers_callback): Change type.
5789         (arm_linux_insert_hw_breakpoint1): Update.
5790         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5791         parameter.
5792         (x86_linux_dr_set_addr): Update.
5793         (x86_linux_dr_set_control): Update.
5794         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5795         (iterate_over_lwps): Use gdb::function_view.
5796         * nat/aarch64-linux-hw-point.c (struct
5797         aarch64_dr_update_callback_param): Remove.
5798         (debug_reg_change_callback): Change type.
5799         (aarch64_notify_debug_reg_change): Update.
5800         * s390-linux-nat.c (s390_refresh_per_info): Update.
5801
5802 2019-03-11  Tom Tromey  <tromey@adacore.com>
5803
5804         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5805         redundant assignment to "this_cu".
5806
5807 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5808
5809         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5810
5811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5812
5813         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5814         from...
5815         (rank_one_type): ... this.
5816
5817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5818
5819         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5820         from...
5821         (rank_one_type): ... this.
5822
5823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5824
5825         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5826         from...
5827         (rank_one_type): ... this.
5828
5829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5830
5831         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5832         from...
5833         (rank_one_type): ... this.
5834
5835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5836
5837         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5838         from...
5839         (rank_one_type): ... this.
5840
5841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5842
5843         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5844         from...
5845         (rank_one_type): ... this.
5846
5847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5848
5849         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5850         from...
5851         (rank_one_type): ... this.
5852
5853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5854
5855         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5856         from...
5857         (rank_one_type): ... this.
5858
5859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5860
5861         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5862         from...
5863         (rank_one_type): ... this.
5864
5865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5866
5867         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5868         from...
5869         (rank_one_type): ... this.
5870
5871 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5872
5873         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5874         from...
5875         (rank_one_type): ... this.
5876
5877 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5878
5879         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5880         from...
5881         (rank_one_type): ... this.
5882
5883 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5884
5885         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5886         inferior-events' shows the example events.
5887
5888 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5889
5890         Support styling on native MS-Windows console
5891
5892         PR/24315
5893         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5894         on MS-Windows if $TERM is not defined.
5895
5896         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5897
5898         * posix-hdep.c (gdb_console_fputs):
5899         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5900         functions.
5901         * ui-file.h (gdb_console_fputs): Add prototype.
5902
5903         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5904         back to fputs only if the former returns zero.
5905
5906 2019-03-07  Tom Tromey  <tom@tromey.com>
5907
5908         * symmisc.c (print_symbol_bcache_statistics): Update.
5909         (print_objfile_statistics): Update.
5910         * symfile.c (allocate_symtab): Update.
5911         * stabsread.c: Don't include bcache.h.
5912         * psymtab.h (struct psymbol_bcache): Don't declare.
5913         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5914         (psymbol_bcache_init, psymbol_bcache_free)
5915         (psymbol_bcache_get_bcache): Don't declare.
5916         * psymtab.c (struct psymbol_bcache): Remove.
5917         (psymtab_storage::psymtab_storage): Update.
5918         (psymtab_storage::~psymtab_storage): Update.
5919         (psymbol_bcache_init, psymbol_bcache_free)
5920         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5921         (add_psymbol_to_bcache): Update.
5922         (allocate_psymtab): Update.
5923         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5924         macro_cache>: No longer pointers.
5925         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5926         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5927         * macrotab.c (macro_bcache): Update.
5928         * macroexp.c: Don't include bcache.h.
5929         * gdbtypes.c (check_types_worklist): Update.
5930         (types_deeply_equal): Remove TRY/CATCH.  Update.
5931         * elfread.c (elf_symtab_read): Update.
5932         * dwarf2read.c: Don't include bcache.h.
5933         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5934         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5935         (print_bcache_statistics, bcache_memory_used): Don't declare.
5936         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5937         methods.  Rename all data members.
5938         * bcache.c (struct bcache): Move to bcache.h.
5939         (bcache::expand_hash_table): Rename from expand_hash_table.
5940         (bcache): Remove.
5941         (bcache::insert): Rename from bcache_full.
5942         (bcache::compare): Rename from bcache_compare.
5943         (bcache_xmalloc): Remove.
5944         (bcache::~bcache): Rename from bcache_xfree.
5945         (bcache::print_statistics): Rename from print_bcache_statistics.
5946         (bcache::memory_used): Rename from bcache_memory_used.
5947
5948 2019-03-07  Pedro Alves  <palves@redhat.com>
5949
5950         * infrun.c (normal_stop): Also check for
5951         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5952
5953 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5954
5955         * f-lang.c (value_from_host_double): Moved to...
5956         * value.c (value_from_host_double): ...here.
5957         * value.h (value_from_host_double): Declare.
5958         * guile/scm-math.c (vlscm_convert_typed_number): Use
5959         value_from_host_double.
5960         (vlscm_convert_number): Likewise.
5961         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5962         * python/py-value.c (convert_value_from_python): Likewise.
5963
5964 2019-03-06  Tom Tromey  <tom@tromey.com>
5965
5966         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5967
5968 2019-03-06  Tom Tromey  <tom@tromey.com>
5969
5970         * utils.h (free_current_contents): Don't declare.
5971         * utils.c (free_current_contents): Remove.
5972
5973 2019-03-06  Tom Tromey  <tom@tromey.com>
5974
5975         * top.c (quit_force): Update.
5976         * main.c (captured_command_loop): Update.
5977         * common/new-op.c (operator new): Update.
5978         * common/common-exceptions.c (struct catcher)
5979         <save_cleanup_chain>: Remove member.
5980         (exceptions_state_mc_init): Update.
5981         (exception_try_scope_entry): Return nullptr.
5982         (exception_try_scope_exit, exception_rethrow)
5983         (throw_exception_sjlj, throw_exception_cxx): Update.
5984         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5985         (all_cleanups, do_cleanups, discard_cleanups)
5986         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5987         (restore_cleanups, restore_final_cleanups): Don't declare.
5988         (do_final_cleanups): Remove parameter.
5989         * common/cleanups.c (cleanup_chain, make_cleanup)
5990         (make_cleanup_dtor, all_cleanups, do_cleanups)
5991         (discard_my_cleanups, discard_cleanups)
5992         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5993         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5994         (null_cleanup): Remove.
5995         (do_final_cleanups): Remove parameter.
5996
5997 2019-03-06  Tom Tromey  <tom@tromey.com>
5998
5999         * remote.c (remote_target::remote_parse_stop_reply): Use
6000         unique_xmalloc_ptr.
6001
6002 2019-03-06  Tom Tromey  <tom@tromey.com>
6003
6004         * stabsread.c (struct stabs_field_info): Rename from field_info.
6005         <list, fnlist>: Add initializers.
6006         <obstack>: New member.
6007         (read_member_functions, read_struct_fields, read_baseclasses):
6008         Allocate on obstack.  Don't use cleanups.
6009         (read_one_struct_field, read_member_functions, read_struct_fields)
6010         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6011         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6012         (read_struct_type): Update.
6013
6014 2019-03-06  Tom Tromey  <tom@tromey.com>
6015
6016         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6017         * common/filestuff.h (make_cleanup_close): Don't declare.
6018         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6019         Remove.
6020
6021 2019-03-06  Tom Tromey  <tom@tromey.com>
6022
6023         * solib-aix.c: Use make_scope_exit.
6024
6025 2019-03-06  Tom Tromey  <tom@tromey.com>
6026
6027         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6028         Use make_scope_exit.
6029
6030 2019-03-06  Tom Tromey  <tom@tromey.com>
6031
6032         * solib-svr4.c (disable_probes_interface): Remove parameter.
6033         (svr4_handle_solib_event): Use make_scope_exit.
6034
6035 2019-03-06  Tom Tromey  <tom@tromey.com>
6036
6037         * remote.c (struct stop_reply_deleter): Remove.
6038         (stop_reply_up): Update.
6039         (struct stop_reply): Derive from notif_event.  Don't typedef.
6040         <regcache>: Now a std::vector.
6041         (stop_reply_xfree): Remove.
6042         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6043         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6044         (remote_target::discard_pending_stop_replies): Use delete.
6045         (remote_target::remote_parse_stop_reply): Update.
6046         (remote_target::process_stop_reply): Update.
6047         * remote-notif.h (struct notif_event): Add virtual destructor.
6048         Remove "dtr" member.
6049         (struct notif_client) <alloc_event>: Return a unique_ptr.
6050         (notif_event_xfree): Don't declare.
6051         (notif_event_up): New typedef.
6052         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6053         (notif_event_xfree, do_notif_event_xfree): Remove.
6054         (remote_notif_state_xfree): Update.
6055
6056 2019-03-06  Tom Tromey  <tom@tromey.com>
6057
6058         * infrun.c (displaced_step_clear_cleanup): Now a
6059         forward_scope_exit type.
6060         (displaced_step_prepare_throw): Update.
6061         (displaced_step_fixup): Update.
6062
6063 2019-03-06  Tom Tromey  <tom@tromey.com>
6064
6065         * inferior.h (class inferior): Update comment.
6066         * gdbthread.h (class thread_info): Update comment.
6067
6068 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6069             Tom Tromey  <tom@tromey.com>
6070
6071         * stabsread.h (struct stab_section_list): Remove.
6072         (coffstab_build_psymtabs): Update.
6073         * dbxread.c (symbuf_sections): Now a std::vector.
6074         (sect_idx): New global.
6075         (fill_symbuf): Update.
6076         (coffstab_build_psymtabs): Change type of stabsects parameter.
6077         Update.
6078         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6079         std::vector.
6080         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6081         (coff_locate_sections): Update.
6082         (coff_symfile_read): Remove cleanups.  Update.
6083         (init_stringtab): Add storage parameter.
6084         (free_stringtab, free_stringtab_cleanup): Remove.
6085         (init_lineno): Add storage parameter.
6086         (free_linetab, free_linetab_cleanup): Remove.
6087
6088 2019-03-06  Pedro Alves  <palves@redhat.com>
6089
6090         * linux-fork.c (fork_info::clobber_regs): Delete.
6091         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6092         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6093         comment.  Adjust.
6094         (scoped_switch_fork_info::scoped_switch_fork_info)
6095         (checkpoint_command, linux_fork_context): Adjust
6096         fork_save_infrun_state calls.
6097
6098 2019-03-06  Pedro Alves  <palves@redhat.com>
6099
6100         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6101         (inf_has_multiple_threads): Return 'bool' and rewrite using
6102         inferior_info::threads().
6103
6104 2019-03-06  Pedro Alves  <palves@redhat.com>
6105
6106         * linux-fork.c: Include <list>.
6107         (fork_list): Now a std::list instance.
6108         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6109         (forks_exist_p, find_last_fork): Adjust.
6110         (new_fork): Delete.
6111         (one_fork_p): New.
6112         (add_fork): Adjust.
6113         (free_fork): Delete, folded into fork_info::~fork_info().
6114         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6115         Adjust.
6116         (init_fork_list): Delete.
6117         (linux_fork_killall, linux_fork_mourn_inferior)
6118         (linux_fork_detach, info_checkpoints_command): Adjust.
6119         (_initialize_linux_fork): No longer call init_fork_list.
6120
6121 2019-03-06  Pedro Alves  <palves@redhat.com>
6122
6123         * linux-fork.c (new_fork): New, split out of ...
6124         (add_fork): ... this.  Return void.  Move "first fork" special
6125         case from here, to ...
6126         (checkpoint_command): ... here.
6127         * linux-linux.h (add_fork): Return void.
6128
6129 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6130
6131         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6132
6133 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6134             Chris January  <chris.january@arm.com>
6135             David Lecomber  <david.lecomber@arm.com>
6136
6137         * f-exp.y: New token, UNOP_INTRINSIC.
6138         (exp): New pattern using UNOP_INTRINSIC token.
6139         (f77_keywords): Add 'abs' keyword.
6140         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6141         (value_from_host_double): New function.
6142         (evaluate_subexp_f): Support UNOP_ABS.
6143
6144 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6145
6146         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6147         types.
6148
6149 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6150
6151         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6152         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6153         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6154
6155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6156
6157         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6158
6159 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6160             Chris January  <chris.january@arm.com>
6161
6162         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6163         * f-exp.y: Define 'KIND' token.
6164         (exp): New pattern for KIND expressions.
6165         (ptype): Handle types with a kind extension.
6166         (direct_abs_decl): Extend to spot kind extensions.
6167         (f77_keywords): Add 'kind' to the list.
6168         (push_kind_type): New function.
6169         (convert_to_kind_type): New function.
6170         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6171         * parse.c (operator_length_standard): Likewise.
6172         * parser-defs.h (enum type_pieces): Add tp_kind.
6173         * std-operator.def: Add UNOP_KIND.
6174
6175 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6176
6177         * f-exp.y (f_parse): Set yydebug.
6178
6179 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6180
6181         * f-lang.c (evaluate_subexp_f): New function.
6182         (exp_descriptor_f): New global.
6183         (f_language_defn): Use exp_descriptor_f instead of
6184         exp_descriptor_standard.
6185
6186 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * f-exp.y (struct token): Add comments.
6189         (dot_ops): Remove uppercase versions and the end marker.
6190         (f77_keywords): Likewise.
6191         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6192         entries in the dot_ops array are case insensitive, and use
6193         strncasecmp to compare strings.  Also some whitespace cleanup in
6194         this area.  Similar for the f77_keywords array, except entries in
6195         this list might be case sensitive.
6196
6197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6198
6199         * f-exp.y (struct f77_boolean_val): Add comments.
6200         (boolean_values): Remove uppercase versions, and end marker.
6201         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6202         and use strncasecmp to achieve case insensitivity.  Additionally,
6203         perform whitespace cleanup around this code.
6204
6205 2019-03-06  Tom Tromey  <tromey@adacore.com>
6206
6207         * remote-sim.c (gdbsim_target_open): Use result of
6208         gdb_argv::release.
6209
6210 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6211         Dirk Schubert  <dirk.schubert@arm.com>
6212         Chris January  <chris.january@arm.com>
6213
6214         * eval.c (evaluate_subexp_standard): Call Fortran argument
6215         wrapping logic.
6216         * f-lang.c (struct value): A value which can be passed into a
6217         Fortran function call.
6218         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6219         where appropriate.
6220         (struct type): Value ready for a Fortran function call.
6221         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6222         is needed.
6223         * f-lang.h (fortran_argument_convert): Declaration.
6224         (fortran_preserve_arg_pointer): Declaration.
6225         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6226
6227 2019-03-05  Tom Tromey  <tromey@adacore.com>
6228
6229         * python/py-prettyprint.c (print_string_repr): Remove #if.
6230         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6231
6232 2019-03-05  Tom Tromey  <tromey@adacore.com>
6233
6234         * target.c (the_dummy_target): Move later.  Change type to
6235         "dummy_target".
6236         (initialize_targets): Don't initialize the_dummy_target.
6237
6238 2019-03-05  Tom Tromey  <tromey@adacore.com>
6239
6240         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6241         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6242
6243 2019-03-05  Tom Tromey  <tromey@adacore.com>
6244
6245         * windows-nat.c (windows_nat_target::attach)
6246         (windows_nat_target::detach): Don't call gdb_flush.
6247         * valprint.c (generic_val_print, val_print, val_print_string):
6248         Don't call gdb_flush.
6249         * utils.c (defaulted_query): Don't call gdb_flush.
6250         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6251         * target.c (target_announce_detach): Don't call gdb_flush.
6252         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6253         * remote.c (extended_remote_target::attach): Don't call
6254         gdb_flush.
6255         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6256         * printcmd.c (do_examine): Don't call gdb_flush.
6257         (info_display_command): Don't call gdb_flush.
6258         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6259         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6260         * memattr.c (info_mem_command): Don't call gdb_flush.
6261         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6262         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6263         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6264         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6265         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6266         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6267         (gnu_nat_target::detach): Don't call gdb_flush.
6268         * f-valprint.c (f_val_print): Don't call gdb_flush.
6269         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6270         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6271         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6272         gdb_flush.
6273         * c-valprint.c (c_val_print): Don't call gdb_flush.
6274         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6275
6276 2019-03-05  Tom Tromey  <tromey@adacore.com>
6277
6278         * varobj.c (update_dynamic_varobj_children): Update.
6279         (install_default_visualizer): Use reset, not release.
6280         * value.c (set_internalvar): Update.
6281         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6282         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6283         ATTRIBUTE_UNUSED_RESULT.
6284
6285 2019-03-05  Tom Tromey  <tromey@adacore.com>
6286
6287         * remote.c (class scoped_remote_fd) <release>: Add
6288         ATTRIBUTE_UNUSED_RESULT.
6289
6290 2019-03-05  Tom Tromey  <tromey@adacore.com>
6291
6292         * macroexp.c (struct macro_buffer) <release>: Add
6293         ATTRIBUTE_UNUSED_RESULT.
6294
6295 2019-03-05  Tom Tromey  <tromey@adacore.com>
6296
6297         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6298         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6299         ATTRIBUTE_UNUSED_RESULT.
6300
6301 2019-03-05  Tom Tromey  <tromey@adacore.com>
6302
6303         * common/scoped_fd.h (class scoped_fd) <release>: Add
6304         ATTRIBUTE_UNUSED_RESULT.
6305
6306 2019-03-05  Tom Tromey  <tromey@adacore.com>
6307
6308         * parser-defs.h (struct parser_state) <release>: Add
6309         ATTRIBUTE_UNUSED_RESULT.
6310
6311 2019-03-05  Tom Tromey  <tromey@adacore.com>
6312
6313         * utils.h (class gdb_argv) <release>: Add
6314         ATTRIBUTE_UNUSED_RESULT.
6315         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6316
6317 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6318
6319         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6320         for-loop range, to avoid compiler warnings.
6321
6322         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6323         avoid compiler warnings about unused variables.
6324
6325         * NEWS: Mention end of support for native debugging on MS-Windows
6326         before XP.
6327
6328         PR gdb/24292
6329         * common/netstuff.c:
6330         * gdbserver/gdbreplay.c
6331         * gdbserver/remote-utils.c:
6332         * ser-tcp.c:
6333         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6334         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6335         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6336         'getaddrinfo' and 'freeaddrinfo' were not available before
6337         Windows XP, and mingw.org's MinGW headers by default define
6338         _WIN32_WINNT to 0x500.
6339
6340 2019-03-01  Gary Benson <gbenson@redhat.com>
6341
6342         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6343
6344 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6345             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6346
6347         PR gdb/8527
6348         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6349         set_sigint_trap, clear_sigint_trap.
6350
6351 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6352
6353         * target.c (target_detach): Clear the regcache and the
6354         frame cache.
6355
6356 2019-02-27  Pedro Alves  <palves@redhat.com>
6357
6358         * utils.c (set_screen_size): When we cap the height/width sizes,
6359         tweak the corresponding command variable to show "unlimited":
6360
6361 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6362             Pedro Alves  <palves@redhat.com>
6363
6364         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6365         before calling rl_set_screen_size.
6366
6367 2019-02-27  Tom Tromey  <tromey@adacore.com>
6368
6369         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6370         define.
6371         * python/py-value.c: Remove Python 2.4 workaround.
6372         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6373         workaround.
6374         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6375         Python 2.4 workaround.
6376         * python/python-internal.h: Remove Python 2.4 comment.
6377         (Py_ssize_t): Don't define.
6378         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6379         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6380         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6381         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6382         * python/python.c (do_start_initialization): Remove Python 2.4
6383         workaround.
6384         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6385         (print_children): Remove Python 2.4 workaround.
6386         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6387         workaround.
6388         (CHARBUFFERPROC_NAME): Remove.
6389         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6390         Python 2.4 workaround.
6391
6392 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6393
6394         * NEWS: Note minimum Python version.
6395
6396 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6397
6398         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6399         code from these functions.  Remove corresponding ifdefs.  Use
6400         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6401         Remove gotos and target of gotos.
6402         (infpy_search_memory): Likewise.
6403
6404 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6405
6406         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6407         (hppa_gdbarch_init): Don't register deleted functions with
6408         gdbarch.
6409
6410 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6411
6412         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6413         (h8300_unwind_sp): Delete.
6414         (h8300_dummy_id): Delete.
6415         (h8300_gdbarch_init): Don't register deleted functions with
6416         gdbarch.
6417
6418 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6419
6420         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6421         (ft32_unwind_pc): Delete.
6422         (ft32_unwind_sp): Delete.
6423         (ft32_gdbarch_init): Don't register deleted functions with
6424         gdbarch.
6425
6426 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6429         (frv_unwind_pc): Delete.
6430         (frv_unwind_sp): Delete.
6431         (frv_gdbarch_init): Don't register deleted functions with
6432         gdbarch.
6433
6434 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6435
6436         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6437         (riscv_unwind_pc): Delete.
6438         (riscv_unwind_sp): Delete.
6439         (riscv_gdbarch_init): Don't register deleted functions with
6440         gdbarch.
6441
6442 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6445         (csky_unwind_pc): Delete.
6446         (csky_unwind_sp): Delete.
6447         (csky_gdbarch_init): Don't register deleted functions with
6448         gdbarch.
6449
6450 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6451
6452         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6453         (cris_unwind_pc): Delete.
6454         (cris_unwind_sp): Delete.
6455         (cris_gdbarch_init): Don't register deleted functions with
6456         gdbarch.
6457
6458 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6459
6460         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6461         (bfin_unwind_pc): Delete.
6462         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6463
6464 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6465
6466         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6467         (arm_unwind_pc): Delete.
6468         (arm_unwind_sp): Delete.
6469         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6470
6471 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6472
6473         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6474         (arc_unwind_pc): Delete.
6475         (arc_unwind_sp): Delete.
6476         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6477
6478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6479
6480         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6481         (alpha_unwind_pc): Delete.
6482         (alpha_gdbarch_init): Don't register deleted functions with
6483         gdbarch.
6484
6485 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6486
6487         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6488         (aarch64_unwind_pc): Delete.
6489         (aarch64_unwind_sp): Delete.
6490         (aarch64_gdbarch_init): Don't register deleted functions with
6491         gdbarch.
6492
6493 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6494
6495         * gdbtypes.c (type_align): Don't consider static members when
6496         computing structure alignment.
6497
6498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6499
6500         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6501         return 0 for other types.
6502         * arch-utils.c (default_type_align): Always return 0.
6503         * gdbarch.h: Regenerate.
6504         * gdbarch.sh (type_align): Extend comment.
6505         * gdbtypes.c (type_align): Add additional comments, always call
6506         gdbarch_type_align before applying the default rules.
6507         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6508         generic code will then apply a suitable default.
6509         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6510         types, return 0 for other types.
6511
6512 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6513
6514         * NEWS: Create a new section for the next release branch.
6515         Rename the section of the current branch, now that it has
6516         been cut.
6517
6518 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6519
6520         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6521         * version.in: Bump version to 8.3.50.DATE-git.
6522
6523 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6524
6525         * aix-thread.c (ptid_cmp): Remove unused variable.
6526         (get_signaled_thread): Likewise.
6527         (store_regs_user_thread): Likewise.
6528         (store_regs_kernel_thread): Likewise.
6529         (fetch_regs_kernel_thread): Remove shadowed variable.
6530
6531 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * features/riscv/32bit-cpu.xml: Add register numbers.
6534         * features/riscv/32bit-fpu.c: Regenerate.
6535         * features/riscv/32bit-fpu.xml: Add register numbers.
6536         * features/riscv/64bit-cpu.xml: Add register numbers.
6537         * features/riscv/64bit-fpu.c: Regenerate.
6538         * features/riscv/64bit-fpu.xml: Add register numbers.
6539
6540 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6541
6542         * NEWS: Mention two argument form of gdb.Value constructor.
6543         * python/py-value.c (convert_buffer_and_type_to_value): New
6544         function.
6545         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6546         Add support for handling an optional second argument.  Call
6547         convert_buffer_and_type_to_value as appropriate.
6548         * python/python-internal.h (Py_buffer_deleter): New struct.
6549         (Py_buffer_up): New typedef.
6550
6551 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6552
6553         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6554         instead of releasing ownership.
6555
6556 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6557
6558         * dwarf2read.c (open_and_init_dwp_file): Call
6559         elf_numsections instead of bfd_count_sections to initialize
6560         dwp_file->num_sections.
6561
6562 2019-02-25  Tom Tromey  <tromey@adacore.com>
6563
6564         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6565
6566 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6567
6568         * gcore.in: Add '--readnever' option when invoking GDB.
6569
6570 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6571
6572         * MAINTAINERS: Update my email address.
6573
6574 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6575
6576         * build-id.c (build_id_to_debug_bfd_1): New function.
6577         (build_id_to_debug_bfd): Look for separate debug file in
6578         sysroot.
6579
6580 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6581
6582         * gdbarch.sh: Update the copyright year range that is placed into
6583         generated files.
6584
6585 2019-02-22  Keith Seitz  <keiths@redhat.com>
6586
6587         PR symtab/23853
6588         * linespec.c (create_sals_line_offset): Search for the default
6589         symtab's filename instead of its fullname.
6590
6591 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6592
6593         * NEWS: Update style defaults.
6594
6595 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6596
6597         * main.c (captured_main_1): Disable styling in batch mode.
6598
6599 2019-02-20  Tom Tromey  <tom@tromey.com>
6600
6601         * symtab.c (symtab_symbol_info): Fix typos.
6602
6603 2019-02-20  Tom Tromey  <tromey@adacore.com>
6604
6605         * findcmd.c (_initialize_mem_search): Use upper case for
6606         metasyntactic variables.
6607
6608 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6609
6610         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6611         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6612
6613 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6614
6615         * top.h (source_file_name): Change to std::string.
6616         * top.c (source_file_name): Likewise.
6617         (command_line_input): Adjust.
6618         * cli/cli-script.c (script_from_file): Adjust.
6619
6620 2019-02-19  Tom Tromey  <tromey@adacore.com>
6621
6622         * ravenscar-thread.c
6623         (ravenscar_thread_target::update_thread_list): Don't call
6624         ada_build_task_list.
6625         * ada-lang.h (ada_build_task_list): Don't declare.
6626         * ada-tasks.c (struct ada_tasks_inferior_data)
6627         <task_list_valid_p>: Now bool.
6628         (read_known_tasks, ada_task_list_changed)
6629         (ada_tasks_invalidate_inferior_data): Update.
6630         (read_known_tasks_array): Return bool.
6631         (read_known_tasks_list): Likewise.
6632         (read_known_tasks): Return void.
6633         (ada_build_task_list): Now static.
6634
6635 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6636
6637         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6638         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6639
6640 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6641
6642         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6643         variant for ada_tasks_pspace_data_handle and
6644         ada_tasks_inferior_data_handle.
6645         (ada_tasks_pspace_data_cleanup): New function.
6646         (ada_tasks_inferior_data_cleanup): New function.
6647
6648 2019-02-17  Tom Tromey  <tom@tromey.com>
6649
6650         * macrotab.h (macro_source_fullname): Return a std::string.
6651         * macrotab.c (macro_include, check_for_redefinition)
6652         (macro_undef, macro_lookup_definition, foreach_macro)
6653         (foreach_macro_in_scope): Update.
6654         (macro_source_fullname): Return a std::string.
6655         * macrocmd.c (show_pp_source_pos): Update.
6656
6657 2019-02-17  Tom Tromey  <tom@tromey.com>
6658
6659         * macrocmd.c (show_pp_source_pos): Style the file names.
6660
6661 2019-02-17  Tom Tromey  <tom@tromey.com>
6662
6663         PR tui/24197:
6664         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6665
6666 2019-02-17  Tom Tromey  <tom@tromey.com>
6667
6668         * ada-lang.c (user_select_syms): Use filtered printing.
6669         * utils.c (wrap_style): New global.
6670         (desired_style): Remove.
6671         (emit_style_escape): Add stream parameter.
6672         (set_output_style, reset_terminal_style, prompt_for_continue):
6673         Update.
6674         (flush_wrap_buffer): Only flush gdb_stdout.
6675         (wrap_here): Set wrap_style.
6676         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6677         treat escape sequences as a character.  Change when wrap buffer is
6678         flushed.
6679         (fputs_styled): Do not set the output style when the default is
6680         requested.
6681         * ui-style.h (struct ui_file_style) <is_default>: New method.
6682         * source.c (print_source_lines_base): Emit escape sequences in one
6683         piece.
6684
6685 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6686
6687         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6688         integers and enumeration types.
6689
6690 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6691
6692         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6693         instead of lookup_symbol_in_language
6694         (do_exact_match): New function.
6695         (ada_get_symbol_name_matcher): Return do_exact_match when
6696         doing a verbatim match.
6697
6698 2019-02-15  Tom Tromey  <tromey@adacore.com>
6699
6700         * ravenscar-thread.c (ravenscar_thread_target::resume)
6701         (ravenscar_thread_target::wait): Special case wildcard requests.
6702
6703 2019-02-15  Tom Tromey  <tromey@adacore.com>
6704
6705         * ravenscar-thread.c (base_ptid): Remove.
6706         (struct ravenscar_thread_target) <close>: New method.
6707         <m_base_ptid>: New member.
6708         <update_inferior_ptid, active_task, task_is_currently_active,
6709         runtime_initialized>: Declare methods.
6710         <ravenscar_thread_target>: Add constructor.
6711         (ravenscar_thread_target::task_is_currently_active)
6712         (ravenscar_thread_target::update_inferior_ptid)
6713         (ravenscar_runtime_initialized): Rename.  Now methods.
6714         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6715         (ravenscar_thread_target::update_thread_list): Update.
6716         (ravenscar_thread_target::active_task): Now method.
6717         (ravenscar_thread_target::store_registers)
6718         (ravenscar_thread_target::prepare_to_store)
6719         (ravenscar_thread_target::prepare_to_store)
6720         (ravenscar_thread_target::mourn_inferior): Update.
6721         (ravenscar_inferior_created): Use "new" to create target.
6722         (ravenscar_thread_target::get_ada_task_ptid): Update.
6723         (_initialize_ravenscar): Don't initialize base_ptid.
6724         (ravenscar_ops): Remove global.
6725
6726 2019-02-15  Tom Tromey  <tromey@adacore.com>
6727
6728         * target.h (push_target): Declare new overload.
6729         * target.c (push_target): New overload, taking an rvalue reference.
6730         * remote.c (remote_target::open_1): Use push_target overload.
6731         * corelow.c (core_target_open): Use push_target overload.
6732
6733 2019-02-15  Tom Tromey  <tromey@adacore.com>
6734
6735         * ravenscar-thread.c (is_ravenscar_task)
6736         (ravenscar_task_is_currently_active): Return bool.
6737         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6738         (_initialize_ravenscar): Remove "(void)".
6739         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6740         Return bool.
6741
6742 2019-02-15  Tom Tromey  <tromey@adacore.com>
6743
6744         * ravenscar-thread.c (ravenscar_runtime_initializer)
6745         (has_ravenscar_runtime, get_running_thread_id)
6746         (ravenscar_thread_target::resume): Fix indentation.
6747
6748 2019-02-15  Tom Tromey  <tromey@adacore.com>
6749
6750         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6751         from ravenscar_arch_ops.
6752         (sparc_ravenscar_ops::fetch_registers)
6753         (sparc_ravenscar_ops::store_registers): Now methods.
6754         (sparc_ravenscar_prepare_to_store): Remove.
6755         (sparc_ravenscar_ops): Redefine.
6756         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6757         methods and destructor.  Remove members.
6758         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6759         (ravenscar_thread_target::store_registers)
6760         (ravenscar_thread_target::prepare_to_store): Update.
6761         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6762         Remove.
6763         (struct ppc_ravenscar_powerpc_ops): Derive from
6764         ravenscar_arch_ops.
6765         (ppc_ravenscar_powerpc_ops::fetch_registers)
6766         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6767         (ppc_ravenscar_powerpc_ops): Redefine.
6768         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6769         (ppc_ravenscar_e500_ops::fetch_registers)
6770         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6771         (ppc_ravenscar_e500_ops): Redefine.
6772         * aarch64-ravenscar-thread.c
6773         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6774         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6775         (aarch64_ravenscar_fetch_registers)
6776         (aarch64_ravenscar_store_registers): Now methods.
6777         (aarch64_ravenscar_ops): Redefine.
6778
6779 2019-02-15  Tom Tromey  <tromey@adacore.com>
6780
6781         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6782         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6783         (ravenscar_thread_target::stopped_by_watchpoint)
6784         (ravenscar_thread_target::stopped_data_address)
6785         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6786
6787 2019-02-15  Tom Tromey  <tromey@adacore.com>
6788
6789         * ravenscar-thread.c: Fix some typos.
6790
6791 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6792             Tom Tromey  <tromey@adacore.com>
6793
6794         * ada-lang.c (ada_exception_sal): Change addr_string to a
6795         std::string.
6796         (create_ada_exception_catchpoint): Update.
6797
6798 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6799             Tom Tromey  <tromey@adacore.com>
6800
6801         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6802         (bp_location_ops): Remove.
6803         (base_breakpoint_allocate_location): Update.
6804         (free_bp_location): Update.
6805         * ada-lang.c (class ada_catchpoint_location)
6806         <ada_catchpoint_location>: Remove ops parameter.
6807         (ada_catchpoint_location_dtor): Remove.
6808         (ada_catchpoint_location_ops): Remove.
6809         (allocate_location_exception): Update.
6810         * breakpoint.h (struct bp_location_ops): Remove.
6811         (class bp_location) <bp_location>: Remove bp_location_ops
6812         parameter.
6813         <~bp_location>: Add destructor.
6814         <ops>: Remove.
6815
6816 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6817             Pedro Alves  <palves@redhat.com>
6818
6819         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6820         'PATH_MAX'.
6821
6822 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6823             Samuel Thibault  <samuel.thibault@gnu.org>
6824             Thomas Schwinge  <thomas@codesourcery.com>
6825
6826         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6827         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6828
6829 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6830
6831         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6832         (check_empty): Use "const char *".
6833
6834         * gnu-nat.c (gnu_nat_target::detach): Instead of
6835         'detach_inferior (pid)' call
6836         'detach_inferior (find_inferior_pid (pid))'.
6837
6838         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6839         'nat/fork-inferior.o'.
6840         * gnu-nat.c: #include "nat/fork-inferior.h".
6841
6842         * gnu-nat.c (gnu_nat_target::detach): Instead of
6843         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6844         * gnu-nat.h: #include "inf-child.h".
6845         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6846         'i386_gnu_nat_target::fetch_registers'.
6847         (gnu_store_registers): Rename/move to
6848         'i386_gnu_nat_target::store_registers'.
6849
6850         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6851         * gnu-nat.h (mach_thread_info): New function.
6852         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6853
6854         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6855
6856 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6857
6858         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6859
6860 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6861
6862         * windows-nat.c (windows_add_thread): Add new parameter
6863         "main_thread_p" with default value set to false.  Update
6864         function documentation as well as all callers.
6865         (windows_delete_thread): Likewise.
6866         (fake_create_process): Update call to windows_add_thread.
6867         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6868         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6869         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6870         call to windows_delete_thread.
6871
6872 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6873
6874         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6875
6876 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6877
6878         * symfile.c (find_separate_debug_file): Use canonical path of
6879         sysroot with child_path instead of gdb_sysroot if it is valid.
6880
6881 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6882
6883         * symfile.c (find_separate_debug_file): Use child_path to
6884         determine if an object file is under a sysroot.
6885
6886 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6887
6888         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6889         unittests/child-path-selftests.c.
6890         * common/pathstuff.c (child_path): New function.
6891         * common/pathstuff.h (child_path): New prototype.
6892         * unittests/child-path-selftests.c: New file.
6893
6894 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6895
6896         * symfile.c (find_separate_debug_file): Look for separate debug
6897         files in debug directories under the sysroot.
6898
6899 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6900
6901         * symtab.h (struct minimal_symbol data_p): New const method.
6902         (struct minimal_symbol text_p): Likewise.
6903         * symtab.c (output_source_filename): Use file name style
6904         to print file name.
6905         (print_symbol_info): Likewise.
6906         (print_msymbol_info): Use address style to print addresses.
6907         Use function name style to print executable text symbols.
6908         (expand_symtab_containing_pc): Use data_p.
6909         (find_pc_sect_compunit_symtab): Likewise.
6910
6911 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6912
6913         * breakpoint.c (describe_other_breakpoints): Use address style
6914         to print addresses.
6915         (say_where): Likewise.
6916
6917 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6918
6919         * ada-typeprint.c (print_func_type): Print function name
6920         style to print function name.
6921         * c-typeprint.c (c_print_type_1): Likewise.
6922
6923 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6924
6925         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6926         for execve.
6927
6928 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6929
6930         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6931         type_stack.
6932
6933 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6934
6935         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6936         TYPE_CODE_REF types.
6937
6938 2019-02-08  Jim Wilson  <jimw@sifive.com>
6939
6940         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6941         (riscv_linux_fregset): New.
6942         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6943
6944 2019-02-07  Tom Tromey  <tom@tromey.com>
6945
6946         * thread.c (thread_cancel_execution_command): Update.
6947         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6948         methods.
6949         (struct thread_fsm_ops): Remove.
6950         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6951         (thread_fsm_should_stop, thread_fsm_return_value)
6952         (thread_fsm_set_finished, thread_fsm_finished_p)
6953         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6954         Don't declare.
6955         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6956         * infrun.c (clear_proceed_status_thread)
6957         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6958         (print_stop_event): Update.
6959         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6960         Add constructor.
6961         (step_command_fsm_ops): Remove.
6962         (new_step_command_fsm): Remove.
6963         (step_1): Update.
6964         (step_command_fsm::should_stop): Rename from
6965         step_command_fsm_should_stop.
6966         (step_command_fsm::clean_up): Rename from
6967         step_command_fsm_clean_up.
6968         (step_command_fsm::do_async_reply_reason): Rename from
6969         step_command_fsm_async_reply_reason.
6970         (struct until_next_fsm): Inherit from thread_fsm.  Add
6971         constructor.
6972         (until_next_fsm_ops): Remove.
6973         (new_until_next_fsm): Remove.
6974         (until_next_fsm::should_stop): Rename from
6975         until_next_fsm_should_stop.
6976         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6977         (until_next_fsm::do_async_reply_reason): Rename from
6978         until_next_fsm_async_reply_reason.
6979         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6980         constructor.  Change type of breakpoint.
6981         (finish_command_fsm_ops): Remove.
6982         (new_finish_command_fsm): Remove.
6983         (finish_command_fsm::should_stop): Rename from
6984         finish_command_fsm_should_stop.
6985         (finish_command_fsm::clean_up): Rename from
6986         finish_command_fsm_clean_up.
6987         (finish_command_fsm::return_value): Rename from
6988         finish_command_fsm_return_value.
6989         (finish_command_fsm::do_async_reply_reason): Rename from
6990         finish_command_fsm_async_reply_reason.
6991         (finish_command): Update.
6992         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6993         Add constructor.
6994         (call_thread_fsm_ops): Remove.
6995         (call_thread_fsm::call_thread_fsm): Rename from
6996         new_call_thread_fsm.
6997         (call_thread_fsm::should_stop): Rename from
6998         call_thread_fsm_should_stop.
6999         (call_thread_fsm::should_notify_stop): Rename from
7000         call_thread_fsm_should_notify_stop.
7001         (run_inferior_call, call_function_by_hand_dummy): Update.
7002         * cli/cli-interp.c (should_print_stop_to_console): Update.
7003         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7004         Add constructor.  Change type of location_breakpoint,
7005         caller_breakpoint.
7006         (until_break_fsm_ops): Remove.
7007         (new_until_break_fsm): Remove.
7008         (until_break_fsm::should_stop): Rename from
7009         until_break_fsm_should_stop.
7010         (until_break_fsm::clean_up): Rename from
7011         until_break_fsm_clean_up.
7012         (until_break_fsm::do_async_reply_reason): Rename from
7013         until_break_fsm_async_reply_reason.
7014         (until_break_command): Update.
7015         * thread-fsm.c: Remove.
7016         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7017
7018 2019-02-07  Tom Tromey  <tom@tromey.com>
7019
7020         * yy-remap.h: Add include guard.
7021         * xtensa-tdep.h: Add include guard.
7022         * xcoffread.h: Rename include guard.
7023         * varobj-iter.h: Add include guard.
7024         * tui/tui.h: Rename include guard.
7025         * tui/tui-winsource.h: Rename include guard.
7026         * tui/tui-wingeneral.h: Rename include guard.
7027         * tui/tui-windata.h: Rename include guard.
7028         * tui/tui-win.h: Rename include guard.
7029         * tui/tui-stack.h: Rename include guard.
7030         * tui/tui-source.h: Rename include guard.
7031         * tui/tui-regs.h: Rename include guard.
7032         * tui/tui-out.h: Rename include guard.
7033         * tui/tui-layout.h: Rename include guard.
7034         * tui/tui-io.h: Rename include guard.
7035         * tui/tui-hooks.h: Rename include guard.
7036         * tui/tui-file.h: Rename include guard.
7037         * tui/tui-disasm.h: Rename include guard.
7038         * tui/tui-data.h: Rename include guard.
7039         * tui/tui-command.h: Rename include guard.
7040         * tic6x-tdep.h: Add include guard.
7041         * target/waitstatus.h: Rename include guard.
7042         * target/wait.h: Rename include guard.
7043         * target/target.h: Rename include guard.
7044         * target/resume.h: Rename include guard.
7045         * target-float.h: Rename include guard.
7046         * stabsread.h: Add include guard.
7047         * rs6000-tdep.h: Add include guard.
7048         * riscv-fbsd-tdep.h: Add include guard.
7049         * regformats/regdef.h: Rename include guard.
7050         * record.h: Rename include guard.
7051         * python/python.h: Rename include guard.
7052         * python/python-internal.h: Rename include guard.
7053         * python/py-stopevent.h: Rename include guard.
7054         * python/py-ref.h: Rename include guard.
7055         * python/py-record.h: Rename include guard.
7056         * python/py-record-full.h: Rename include guard.
7057         * python/py-record-btrace.h: Rename include guard.
7058         * python/py-instruction.h: Rename include guard.
7059         * python/py-events.h: Rename include guard.
7060         * python/py-event.h: Rename include guard.
7061         * procfs.h: Add include guard.
7062         * proc-utils.h: Add include guard.
7063         * p-lang.h: Add include guard.
7064         * or1k-tdep.h: Rename include guard.
7065         * observable.h: Rename include guard.
7066         * nto-tdep.h: Rename include guard.
7067         * nat/x86-linux.h: Rename include guard.
7068         * nat/x86-linux-dregs.h: Rename include guard.
7069         * nat/x86-gcc-cpuid.h: Add include guard.
7070         * nat/x86-dregs.h: Rename include guard.
7071         * nat/x86-cpuid.h: Rename include guard.
7072         * nat/ppc-linux.h: Rename include guard.
7073         * nat/mips-linux-watch.h: Rename include guard.
7074         * nat/linux-waitpid.h: Rename include guard.
7075         * nat/linux-ptrace.h: Rename include guard.
7076         * nat/linux-procfs.h: Rename include guard.
7077         * nat/linux-osdata.h: Rename include guard.
7078         * nat/linux-nat.h: Rename include guard.
7079         * nat/linux-namespaces.h: Rename include guard.
7080         * nat/linux-btrace.h: Rename include guard.
7081         * nat/glibc_thread_db.h: Rename include guard.
7082         * nat/gdb_thread_db.h: Rename include guard.
7083         * nat/gdb_ptrace.h: Rename include guard.
7084         * nat/fork-inferior.h: Rename include guard.
7085         * nat/amd64-linux-siginfo.h: Rename include guard.
7086         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7087         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7088         * nat/aarch64-linux.h: Rename include guard.
7089         * nat/aarch64-linux-hw-point.h: Rename include guard.
7090         * mn10300-tdep.h: Add include guard.
7091         * mips-linux-tdep.h: Add include guard.
7092         * mi/mi-parse.h: Rename include guard.
7093         * mi/mi-out.h: Rename include guard.
7094         * mi/mi-main.h: Rename include guard.
7095         * mi/mi-interp.h: Rename include guard.
7096         * mi/mi-getopt.h: Rename include guard.
7097         * mi/mi-console.h: Rename include guard.
7098         * mi/mi-common.h: Rename include guard.
7099         * mi/mi-cmds.h: Rename include guard.
7100         * mi/mi-cmd-break.h: Rename include guard.
7101         * m2-lang.h: Add include guard.
7102         * location.h: Rename include guard.
7103         * linux-record.h: Rename include guard.
7104         * linux-nat.h: Add include guard.
7105         * linux-fork.h: Add include guard.
7106         * i386-darwin-tdep.h: Rename include guard.
7107         * hppa-linux-offsets.h: Add include guard.
7108         * guile/guile.h: Rename include guard.
7109         * guile/guile-internal.h: Rename include guard.
7110         * gnu-nat.h: Rename include guard.
7111         * gdb-stabs.h: Rename include guard.
7112         * frv-tdep.h: Add include guard.
7113         * f-lang.h: Add include guard.
7114         * event-loop.h: Add include guard.
7115         * darwin-nat.h: Rename include guard.
7116         * cp-abi.h: Rename include guard.
7117         * config/sparc/nm-sol2.h: Rename include guard.
7118         * config/nm-nto.h: Rename include guard.
7119         * config/nm-linux.h: Add include guard.
7120         * config/i386/nm-i386gnu.h: Rename include guard.
7121         * config/djgpp/nl_types.h: Rename include guard.
7122         * config/djgpp/langinfo.h: Rename include guard.
7123         * compile/gcc-cp-plugin.h: Add include guard.
7124         * compile/gcc-c-plugin.h: Add include guard.
7125         * compile/compile.h: Rename include guard.
7126         * compile/compile-object-run.h: Rename include guard.
7127         * compile/compile-object-load.h: Rename include guard.
7128         * compile/compile-internal.h: Rename include guard.
7129         * compile/compile-cplus.h: Rename include guard.
7130         * compile/compile-c.h: Rename include guard.
7131         * common/xml-utils.h: Rename include guard.
7132         * common/x86-xstate.h: Rename include guard.
7133         * common/version.h: Rename include guard.
7134         * common/vec.h: Rename include guard.
7135         * common/tdesc.h: Rename include guard.
7136         * common/selftest.h: Rename include guard.
7137         * common/scoped_restore.h: Rename include guard.
7138         * common/scoped_mmap.h: Rename include guard.
7139         * common/scoped_fd.h: Rename include guard.
7140         * common/safe-iterator.h: Rename include guard.
7141         * common/run-time-clock.h: Rename include guard.
7142         * common/refcounted-object.h: Rename include guard.
7143         * common/queue.h: Rename include guard.
7144         * common/ptid.h: Rename include guard.
7145         * common/print-utils.h: Rename include guard.
7146         * common/preprocessor.h: Rename include guard.
7147         * common/pathstuff.h: Rename include guard.
7148         * common/observable.h: Rename include guard.
7149         * common/netstuff.h: Rename include guard.
7150         * common/job-control.h: Rename include guard.
7151         * common/host-defs.h: Rename include guard.
7152         * common/gdb_wait.h: Rename include guard.
7153         * common/gdb_vecs.h: Rename include guard.
7154         * common/gdb_unlinker.h: Rename include guard.
7155         * common/gdb_unique_ptr.h: Rename include guard.
7156         * common/gdb_tilde_expand.h: Rename include guard.
7157         * common/gdb_sys_time.h: Rename include guard.
7158         * common/gdb_string_view.h: Rename include guard.
7159         * common/gdb_splay_tree.h: Rename include guard.
7160         * common/gdb_setjmp.h: Rename include guard.
7161         * common/gdb_ref_ptr.h: Rename include guard.
7162         * common/gdb_optional.h: Rename include guard.
7163         * common/gdb_locale.h: Rename include guard.
7164         * common/gdb_assert.h: Rename include guard.
7165         * common/filtered-iterator.h: Rename include guard.
7166         * common/filestuff.h: Rename include guard.
7167         * common/fileio.h: Rename include guard.
7168         * common/environ.h: Rename include guard.
7169         * common/common-utils.h: Rename include guard.
7170         * common/common-types.h: Rename include guard.
7171         * common/common-regcache.h: Rename include guard.
7172         * common/common-inferior.h: Rename include guard.
7173         * common/common-gdbthread.h: Rename include guard.
7174         * common/common-exceptions.h: Rename include guard.
7175         * common/common-defs.h: Rename include guard.
7176         * common/common-debug.h: Rename include guard.
7177         * common/cleanups.h: Rename include guard.
7178         * common/buffer.h: Rename include guard.
7179         * common/btrace-common.h: Rename include guard.
7180         * common/break-common.h: Rename include guard.
7181         * cli/cli-utils.h: Rename include guard.
7182         * cli/cli-style.h: Rename include guard.
7183         * cli/cli-setshow.h: Rename include guard.
7184         * cli/cli-script.h: Rename include guard.
7185         * cli/cli-interp.h: Rename include guard.
7186         * cli/cli-decode.h: Rename include guard.
7187         * cli/cli-cmds.h: Rename include guard.
7188         * charset-list.h: Add include guard.
7189         * buildsym-legacy.h: Rename include guard.
7190         * bfin-tdep.h: Add include guard.
7191         * ax.h: Rename include guard.
7192         * arm-linux-tdep.h: Add include guard.
7193         * arm-fbsd-tdep.h: Add include guard.
7194         * arch/xtensa.h: Rename include guard.
7195         * arch/tic6x.h: Add include guard.
7196         * arch/i386.h: Add include guard.
7197         * arch/arm.h: Rename include guard.
7198         * arch/arm-linux.h: Rename include guard.
7199         * arch/arm-get-next-pcs.h: Rename include guard.
7200         * arch/amd64.h: Add include guard.
7201         * arch/aarch64-insn.h: Rename include guard.
7202         * arch-utils.h: Rename include guard.
7203         * annotate.h: Add include guard.
7204         * amd64-darwin-tdep.h: Rename include guard.
7205         * aarch64-linux-tdep.h: Add include guard.
7206         * aarch64-fbsd-tdep.h: Add include guard.
7207         * aarch32-linux-nat.h: Add include guard.
7208
7209 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7210
7211         * macrotab.c (macro_define_internal): New function that
7212         factorizes macro_define_object_internal and macro_define_function
7213         code.
7214         (macro_define_object_internal): Use macro_define_internal.
7215         (macro_define_function): Likewise.
7216
7217 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7218
7219         * macrocmd.c (extract_identifier): Return
7220         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7221         callers.
7222
7223 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7224
7225         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7226
7227 2019-02-05  Tom Tromey  <tom@tromey.com>
7228
7229         * target.c (target_stack::unpush): Move assertion earlier.
7230
7231 2019-01-30  Tom Tromey  <tom@tromey.com>
7232
7233         PR python/23615:
7234         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7235         (gdbpy_parse_and_eval): Likewise.
7236         * python/python-internal.h (gdbpy_allow_threads): New class.
7237
7238 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7239
7240         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7241         (aarch64_fbsd_fpregmap): Move earlier.
7242         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7243         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7244         instead of individual calls to trad_frame_set_reg_addr.
7245         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7246         earlier.
7247         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7248         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7249         instead of individual calls to trad_frame_set_reg_addr.
7250
7251 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7252
7253         * CONTRIBUTE: Replace contribution list with wiki link.
7254
7255 2019-01-25  Tom Tromey  <tom@tromey.com>
7256
7257         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7258
7259 2019-01-25  Tom Tromey  <tom@tromey.com>
7260
7261         * xtensa-linux-nat.c: Fix common/ includes.
7262         * xml-support.h: Fix common/ includes.
7263         * xml-support.c: Fix common/ includes.
7264         * x86-linux-nat.c: Fix common/ includes.
7265         * windows-nat.c: Fix common/ includes.
7266         * varobj.h: Fix common/ includes.
7267         * varobj.c: Fix common/ includes.
7268         * value.c: Fix common/ includes.
7269         * valops.c: Fix common/ includes.
7270         * utils.c: Fix common/ includes.
7271         * unittests/xml-utils-selftests.c: Fix common/ includes.
7272         * unittests/utils-selftests.c: Fix common/ includes.
7273         * unittests/unpack-selftests.c: Fix common/ includes.
7274         * unittests/tracepoint-selftests.c: Fix common/ includes.
7275         * unittests/style-selftests.c: Fix common/ includes.
7276         * unittests/string_view-selftests.c: Fix common/ includes.
7277         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7278         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7279         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7280         * unittests/rsp-low-selftests.c: Fix common/ includes.
7281         * unittests/parse-connection-spec-selftests.c: Fix common/
7282         includes.
7283         * unittests/optional-selftests.c: Fix common/ includes.
7284         * unittests/offset-type-selftests.c: Fix common/ includes.
7285         * unittests/observable-selftests.c: Fix common/ includes.
7286         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7287         * unittests/memrange-selftests.c: Fix common/ includes.
7288         * unittests/memory-map-selftests.c: Fix common/ includes.
7289         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7290         * unittests/function-view-selftests.c: Fix common/ includes.
7291         * unittests/environ-selftests.c: Fix common/ includes.
7292         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7293         * unittests/common-utils-selftests.c: Fix common/ includes.
7294         * unittests/cli-utils-selftests.c: Fix common/ includes.
7295         * unittests/array-view-selftests.c: Fix common/ includes.
7296         * ui-file.c: Fix common/ includes.
7297         * tui/tui-io.c: Fix common/ includes.
7298         * tracepoint.h: Fix common/ includes.
7299         * tracepoint.c: Fix common/ includes.
7300         * tracefile-tfile.c: Fix common/ includes.
7301         * top.h: Fix common/ includes.
7302         * top.c: Fix common/ includes.
7303         * thread.c: Fix common/ includes.
7304         * target/waitstatus.h: Fix common/ includes.
7305         * target/waitstatus.c: Fix common/ includes.
7306         * target.h: Fix common/ includes.
7307         * target.c: Fix common/ includes.
7308         * target-memory.c: Fix common/ includes.
7309         * target-descriptions.c: Fix common/ includes.
7310         * symtab.h: Fix common/ includes.
7311         * symfile.c: Fix common/ includes.
7312         * stap-probe.c: Fix common/ includes.
7313         * spu-linux-nat.c: Fix common/ includes.
7314         * sparc-nat.c: Fix common/ includes.
7315         * source.c: Fix common/ includes.
7316         * solib.c: Fix common/ includes.
7317         * solib-target.c: Fix common/ includes.
7318         * ser-unix.c: Fix common/ includes.
7319         * ser-tcp.c: Fix common/ includes.
7320         * ser-pipe.c: Fix common/ includes.
7321         * ser-base.c: Fix common/ includes.
7322         * selftest-arch.c: Fix common/ includes.
7323         * s12z-tdep.c: Fix common/ includes.
7324         * rust-exp.y: Fix common/ includes.
7325         * rs6000-aix-tdep.c: Fix common/ includes.
7326         * riscv-tdep.c: Fix common/ includes.
7327         * remote.c: Fix common/ includes.
7328         * remote-notif.h: Fix common/ includes.
7329         * remote-fileio.h: Fix common/ includes.
7330         * remote-fileio.c: Fix common/ includes.
7331         * regcache.h: Fix common/ includes.
7332         * regcache.c: Fix common/ includes.
7333         * record-btrace.c: Fix common/ includes.
7334         * python/python.c: Fix common/ includes.
7335         * python/py-type.c: Fix common/ includes.
7336         * python/py-inferior.c: Fix common/ includes.
7337         * progspace.h: Fix common/ includes.
7338         * producer.c: Fix common/ includes.
7339         * procfs.c: Fix common/ includes.
7340         * proc-api.c: Fix common/ includes.
7341         * printcmd.c: Fix common/ includes.
7342         * ppc-linux-nat.c: Fix common/ includes.
7343         * parser-defs.h: Fix common/ includes.
7344         * osdata.c: Fix common/ includes.
7345         * obsd-nat.c: Fix common/ includes.
7346         * nat/x86-linux.c: Fix common/ includes.
7347         * nat/x86-linux-dregs.c: Fix common/ includes.
7348         * nat/x86-dregs.h: Fix common/ includes.
7349         * nat/x86-dregs.c: Fix common/ includes.
7350         * nat/ppc-linux.c: Fix common/ includes.
7351         * nat/mips-linux-watch.h: Fix common/ includes.
7352         * nat/mips-linux-watch.c: Fix common/ includes.
7353         * nat/linux-waitpid.c: Fix common/ includes.
7354         * nat/linux-ptrace.h: Fix common/ includes.
7355         * nat/linux-ptrace.c: Fix common/ includes.
7356         * nat/linux-procfs.c: Fix common/ includes.
7357         * nat/linux-personality.c: Fix common/ includes.
7358         * nat/linux-osdata.c: Fix common/ includes.
7359         * nat/linux-namespaces.c: Fix common/ includes.
7360         * nat/linux-btrace.h: Fix common/ includes.
7361         * nat/linux-btrace.c: Fix common/ includes.
7362         * nat/fork-inferior.c: Fix common/ includes.
7363         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7364         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7365         * nat/aarch64-linux.c: Fix common/ includes.
7366         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7367         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7368         * namespace.h: Fix common/ includes.
7369         * mips-linux-tdep.c: Fix common/ includes.
7370         * minsyms.c: Fix common/ includes.
7371         * mi/mi-parse.h: Fix common/ includes.
7372         * mi/mi-main.c: Fix common/ includes.
7373         * mi/mi-cmd-env.c: Fix common/ includes.
7374         * memrange.h: Fix common/ includes.
7375         * memattr.c: Fix common/ includes.
7376         * maint.h: Fix common/ includes.
7377         * maint.c: Fix common/ includes.
7378         * main.c: Fix common/ includes.
7379         * machoread.c: Fix common/ includes.
7380         * location.c: Fix common/ includes.
7381         * linux-thread-db.c: Fix common/ includes.
7382         * linux-nat.c: Fix common/ includes.
7383         * linux-fork.c: Fix common/ includes.
7384         * inline-frame.c: Fix common/ includes.
7385         * infrun.c: Fix common/ includes.
7386         * inflow.c: Fix common/ includes.
7387         * inferior.h: Fix common/ includes.
7388         * inferior.c: Fix common/ includes.
7389         * infcmd.c: Fix common/ includes.
7390         * inf-ptrace.c: Fix common/ includes.
7391         * inf-child.c: Fix common/ includes.
7392         * ia64-linux-nat.c: Fix common/ includes.
7393         * i387-tdep.c: Fix common/ includes.
7394         * i386-tdep.c: Fix common/ includes.
7395         * i386-linux-tdep.c: Fix common/ includes.
7396         * i386-linux-nat.c: Fix common/ includes.
7397         * i386-go32-tdep.c: Fix common/ includes.
7398         * i386-fbsd-tdep.c: Fix common/ includes.
7399         * i386-fbsd-nat.c: Fix common/ includes.
7400         * guile/scm-type.c: Fix common/ includes.
7401         * guile/guile.c: Fix common/ includes.
7402         * go32-nat.c: Fix common/ includes.
7403         * gnu-nat.c: Fix common/ includes.
7404         * gdbthread.h: Fix common/ includes.
7405         * gdbarch-selftests.c: Fix common/ includes.
7406         * gdb_usleep.c: Fix common/ includes.
7407         * gdb_select.h: Fix common/ includes.
7408         * gdb_bfd.c: Fix common/ includes.
7409         * gcore.c: Fix common/ includes.
7410         * fork-child.c: Fix common/ includes.
7411         * findvar.c: Fix common/ includes.
7412         * fbsd-nat.c: Fix common/ includes.
7413         * event-top.c: Fix common/ includes.
7414         * event-loop.c: Fix common/ includes.
7415         * dwarf2read.c: Fix common/ includes.
7416         * dwarf2loc.c: Fix common/ includes.
7417         * dwarf2-frame.c: Fix common/ includes.
7418         * dwarf-index-cache.c: Fix common/ includes.
7419         * dtrace-probe.c: Fix common/ includes.
7420         * disasm-selftests.c: Fix common/ includes.
7421         * defs.h: Fix common/ includes.
7422         * csky-tdep.c: Fix common/ includes.
7423         * cp-valprint.c: Fix common/ includes.
7424         * cp-support.h: Fix common/ includes.
7425         * cp-support.c: Fix common/ includes.
7426         * corelow.c: Fix common/ includes.
7427         * completer.h: Fix common/ includes.
7428         * completer.c: Fix common/ includes.
7429         * compile/compile.c: Fix common/ includes.
7430         * compile/compile-loc2c.c: Fix common/ includes.
7431         * compile/compile-cplus-types.c: Fix common/ includes.
7432         * compile/compile-cplus-symbols.c: Fix common/ includes.
7433         * command.h: Fix common/ includes.
7434         * cli/cli-dump.c: Fix common/ includes.
7435         * cli/cli-cmds.c: Fix common/ includes.
7436         * charset.c: Fix common/ includes.
7437         * build-id.c: Fix common/ includes.
7438         * btrace.h: Fix common/ includes.
7439         * btrace.c: Fix common/ includes.
7440         * breakpoint.h: Fix common/ includes.
7441         * breakpoint.c: Fix common/ includes.
7442         * ax.h:
7443         (enum agent_op): Fix common/ includes.
7444         * ax-general.c (struct aop_map): Fix common/ includes.
7445         * ax-gdb.c: Fix common/ includes.
7446         * auxv.c: Fix common/ includes.
7447         * auto-load.c: Fix common/ includes.
7448         * arm-tdep.c: Fix common/ includes.
7449         * arch/riscv.c: Fix common/ includes.
7450         * arch/ppc-linux-common.c: Fix common/ includes.
7451         * arch/i386.c: Fix common/ includes.
7452         * arch/arm.c: Fix common/ includes.
7453         * arch/arm-linux.c: Fix common/ includes.
7454         * arch/arm-get-next-pcs.c: Fix common/ includes.
7455         * arch/amd64.c: Fix common/ includes.
7456         * arch/aarch64.c: Fix common/ includes.
7457         * arch/aarch64-insn.c: Fix common/ includes.
7458         * arch-utils.c: Fix common/ includes.
7459         * amd64-windows-tdep.c: Fix common/ includes.
7460         * amd64-tdep.c: Fix common/ includes.
7461         * amd64-sol2-tdep.c: Fix common/ includes.
7462         * amd64-obsd-tdep.c: Fix common/ includes.
7463         * amd64-nbsd-tdep.c: Fix common/ includes.
7464         * amd64-linux-tdep.c: Fix common/ includes.
7465         * amd64-linux-nat.c: Fix common/ includes.
7466         * amd64-fbsd-tdep.c: Fix common/ includes.
7467         * amd64-fbsd-nat.c: Fix common/ includes.
7468         * amd64-dicos-tdep.c: Fix common/ includes.
7469         * amd64-darwin-tdep.c: Fix common/ includes.
7470         * agent.c: Fix common/ includes.
7471         * ada-lang.h: Fix common/ includes.
7472         * ada-lang.c: Fix common/ includes.
7473         * aarch64-tdep.c: Fix common/ includes.
7474
7475 2019-01-25  Tom Tromey  <tom@tromey.com>
7476
7477         * common/create-version.sh: Use common/version.h.
7478
7479 2019-01-24  Pedro Alves  <palves@redhat.com>
7480
7481         * infrun.c (signal_stop, signal_print, signal_program)
7482         (signal_catch, signal_pass): Now arrays instead of pointers.
7483         (update_signals_program_target, do_target_resume)
7484         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7485         * linux-nat.c (linux_nat_target::pass_signals)
7486         (linux_nat_target::create_inferior, linux_nat_target::attach):
7487         Adjust.
7488         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7489         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7490         * procfs.c (procfs_target::pass_signals): Adjust.
7491         * record-full.c (record_full_target::resume): Adjust.
7492         * remote.c (remote_target::pass_signals)
7493         (remote_target::program_signals): Adjust.
7494         * target-debug.h (target_debug_print_signals): Now takes a
7495         gdb::array_view as parameter.  Adjust.
7496         * target.h (target_ops) <pass_signals, program_signals>: Replace
7497         pointer and length parameters with gdb::array_view.
7498         (target_pass_signals, target_program_signals): Likewise.
7499         * target-delegates.c: Regenerate.
7500
7501 2019-01-24  Pedro Alves  <palves@redhat.com>
7502
7503         * common/forward-scope-exit.h
7504         (forward_scope_exit::forward_scope_exit): Pass arguments to
7505         m_bind_function directly, instead of creating a std::bind and
7506         copying that.
7507
7508 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7509
7510         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7511         for static members.
7512         (pass_in_v_vfp_candidate): Likewise.
7513
7514 2019-01-23  Tom Tromey  <tom@tromey.com>
7515             Pedro Alves  <palves@redhat.com>
7516
7517         * regcache.c (class regcache_invalidator): Remove.
7518         (regcache::raw_write): Use make_scope_exit.
7519
7520 2019-01-23  Tom Tromey  <tom@tromey.com>
7521
7522         * ui-out.h (class ui_out_emit_type): Update comment.
7523
7524 2019-01-23  Tom Tromey  <tom@tromey.com>
7525
7526         * infrun.c (fetch_inferior_event): Update comment.
7527
7528 2019-01-23  Tom Tromey  <tom@tromey.com>
7529             Pedro Alves  <palves@redhat.com>
7530
7531         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7532         parameter.
7533         (fetch_inferior_event): Use SCOPE_EXIT.
7534
7535
7536 2019-01-23  Tom Tromey  <tom@tromey.com>
7537             Pedro Alves  <palves@redhat.com>
7538
7539         * infrun.c (disable_thread_events): Delete.
7540         (stop_all_threads): Use SCOPE_EXIT.
7541
7542 2019-01-23  Tom Tromey  <tom@tromey.com>
7543             Pedro Alves  <palves@redhat.com>
7544
7545         * symfile.c: Include forward-scope-exit.h.
7546         (clear_symtab_users_cleanup): Replace forward declaration with
7547         a FORWARD_SCOPE_EXIT.
7548         (syms_from_objfile_1): Use the forward_scope_exit and
7549         gdb::optional instead of cleanup_function.
7550         (reread_symbols): Use the forward_scope_exit instead of
7551         cleanup_function.
7552         (clear_symtab_users_cleanup): Remove function.
7553
7554 2019-01-23  Tom Tromey  <tom@tromey.com>
7555             Pedro Alves  <palves@redhat.com>
7556
7557         * linux-nat.c: Include scope-exit.h.
7558         (cleanup_target_stop): Remove.
7559         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7560         SCOPE_EXIT.
7561
7562 2019-01-23  Tom Tromey  <tom@tromey.com>
7563             Pedro Alves  <palves@redhat.com>
7564
7565         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7566         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7567
7568 2019-01-23  Tom Tromey  <tom@tromey.com>
7569             Andrew Burgess  <andrew.burgess@embecosm.com>
7570             Pedro Alves  <palves@redhat.com>
7571
7572         * infrun.c (fetch_inferior_event): Use scope_exit.
7573         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7574         * top.c (execute_command): Use scope_exit.
7575         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7576         * utils.c (do_bpstat_clear_actions_cleanup)
7577         (make_bpstat_clear_actions_cleanup): Remove.
7578
7579 2019-01-23  Tom Tromey  <tom@tromey.com>
7580             Pedro Alves  <palves@redhat.com>
7581
7582         * infrun.c: Include "common/scope-exit.h"
7583         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7584         (wait_for_inferior): Use SCOPE_EXIT.
7585         (fetch_inferior_event): Use scope_exit.
7586
7587 2019-01-23  Tom Tromey  <tom@tromey.com>
7588             Pedro Alves  <palves@redhat.com>
7589
7590         * breakpoint.c (create_breakpoint): Remove cleanup.
7591
7592 2019-01-23  Tom Tromey  <tom@tromey.com>
7593             Andrew Burgess  <andrew.burgess@embecosm.com>
7594             Pedro Alves  <palves@redhat.com>
7595
7596 2019-01-23  Pedro Alves  <palves@redhat.com>
7597
7598         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7599
7600 2019-01-23  Pedro Alves  <palves@redhat.com>
7601             Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         * gdbthread.h: Include "common/forward-scope-exit.h".
7604         (scoped_finish_thread_state): Redefine custom class in terms of
7605         forward_scope_exit.
7606
7607 2019-01-23  Pedro Alves  <palves@redhat.com>
7608             Andrew Burgess  <andrew.burgess@embecosm.com>
7609
7610         * common/forward-scope-exit.h: New file.
7611
7612 2019-01-23  Pedro Alves  <palves@redhat.com>
7613             Andrew Burgess  <andrew.burgess@embecosm.com>
7614             Tom Tromey  <tom@tromey.com>
7615
7616         * common/scope-exit.h: New file.
7617
7618 2019-01-23  Pedro Alves  <palves@redhat.com>
7619
7620         * common/preprocessor.h (ESC): Rename to ...
7621         (ESC_PARENS): ... this.
7622         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7623         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7624
7625 2019-01-23  Tom Tromey  <tom@tromey.com>
7626
7627         * language.h (class scoped_switch_to_sym_language_if_auto):
7628         Initialize m_lang in both cases.
7629
7630 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7631
7632         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7633         with XCNEW.
7634
7635 2019-01-22  Tom Tromey  <tom@tromey.com>
7636
7637         * corelow.c: Do not include sys/file.h.
7638
7639 2019-01-22  Tom Tromey  <tom@tromey.com>
7640
7641         * tui/tui-wingeneral.h: Include gdb_curses.h.
7642
7643 2019-01-22  Tom Tromey  <tom@tromey.com>
7644
7645         * source-cache.h (class source_cache) <get_source_lines,
7646         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7647
7648 2019-01-22  Tom Tromey  <tom@tromey.com>
7649
7650         * remote-fileio.h (struct remote_target): Declare.
7651
7652 2019-01-22  Tom Tromey  <tom@tromey.com>
7653
7654         * python/py-arch.c: Do not include py-ref.h.
7655         * python/py-bpevent.c: Do not include py-ref.h.
7656         * python/py-cmd.c: Do not include py-ref.h.
7657         * python/py-continueevent.c: Do not include py-ref.h.
7658         * python/py-event.h: Do not include py-ref.h.
7659         * python/py-evtregistry.c: Do not include py-ref.h.
7660         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7661         * python/py-frame.c: Do not include py-ref.h.
7662         * python/py-framefilter.c: Do not include py-ref.h.
7663         * python/py-function.c: Do not include py-ref.h.
7664         * python/py-infevents.c: Do not include py-ref.h.
7665         * python/py-linetable.c: Do not include py-ref.h.
7666         * python/py-objfile.c: Do not include py-ref.h.
7667         * python/py-param.c: Do not include py-ref.h.
7668         * python/py-prettyprint.c: Do not include py-ref.h.
7669         * python/py-progspace.c: Do not include py-ref.h.
7670         * python/py-symbol.c: Do not include py-ref.h.
7671         * python/py-symtab.c: Do not include py-ref.h.
7672         * python/py-type.c: Do not include py-ref.h.
7673         * python/py-unwind.c: Do not include py-ref.h.
7674         * python/py-utils.c: Do not include py-ref.h.
7675         * python/py-value.c: Do not include py-ref.h.
7676         * python/py-varobj.c: Do not include py-ref.h.
7677         * python/py-xmethods.c: Do not include py-ref.h.
7678         * python/python.c: Do not include py-ref.h.
7679         * varobj.c: Do not include py-ref.h.
7680
7681 2019-01-22  Tom Tromey  <tom@tromey.com>
7682
7683         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7684         keyword for bcache.
7685
7686 2019-01-22  Tom Tromey  <tom@tromey.com>
7687
7688         * compile/compile-cplus-types.c: Remove a comment by #include.
7689
7690 2019-01-22  Tom Tromey  <tom@tromey.com>
7691
7692         * compile/gcc-c-plugin.h: Include compile-internal.h.
7693
7694 2019-01-22  Tom Tromey  <tom@tromey.com>
7695
7696         * stabsread.c (EXTERN): Do not define.
7697         (symnum, next_symbol_text_func, processing_gcc_compilation)
7698         (within_function, global_sym_chain, global_stabs)
7699         (previous_stab_code, this_object_header_files)
7700         (n_this_object_header_files)
7701         (n_allocated_this_object_header_files): Define.
7702         * stabsread.h (EXTERN): Never define.  Use "extern".
7703
7704 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7705
7706         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7707         history_value.
7708
7709 2019-01-21  Tom Tromey  <tom@tromey.com>
7710
7711         * ui-out.c: Fix includes.
7712         * tui/tui-source.c: Fix includes.
7713         * target.c: Fix includes.
7714         * remote.c: Fix includes.
7715         * regcache.c: Fix includes.
7716         * python/py-block.c: Fix includes.
7717         * printcmd.c: Fix includes.
7718         * or1k-tdep.c: Fix includes.
7719         * mi/mi-main.c: Fix includes.
7720         * m32r-tdep.c: Fix includes.
7721         * csky-tdep.c: Fix includes.
7722         * compile/compile-cplus-types.c: Fix includes.
7723         * cli/cli-interp.c: Fix includes.
7724
7725 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7726
7727         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7728         for padding.
7729
7730 2019-01-16  Tom Tromey  <tom@tromey.com>
7731
7732         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7733         earlier.
7734         (struct objfile) <msymbols_range>: Move from top level.
7735         <msymbols>: New method.
7736         (class objfile_msymbols): Remove.
7737         * symtab.c (default_collect_symbol_completion_matches_break_on):
7738         Update.
7739         * symmisc.c (dump_msymbols): Update.
7740         * stabsread.c (scan_file_globals): Update.
7741         * objc-lang.c (info_selectors_command, info_classes_command)
7742         (find_methods): Update.
7743         * minsyms.c (find_solib_trampoline_target): Update.
7744         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7745         * coffread.c (coff_symfile_read): Update.
7746         * ada-lang.c (ada_lookup_simple_minsym)
7747         (ada_collect_symbol_completion_matches): Update.
7748
7749 2019-01-16  Tom Tromey  <tom@tromey.com>
7750
7751         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7752         type.  Remove no-argument constructor.
7753         <iterator::operator++>: Simplify.
7754         <begin>: Update.
7755         <end>: Use minimal_symbol_count.
7756
7757 2019-01-16  Tom Tromey  <tom@tromey.com>
7758
7759         * objfiles.h (struct objfile) <psymtabs>: New method.
7760         (class objfile_psymtabs): Remove.
7761         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7762         typedef.
7763         <range>: New method.
7764         (require_partial_symbols): Change return type.
7765         * psymtab.c (require_partial_symbols)
7766         (psym_expand_symtabs_matching): Update.
7767         * mdebugread.c (parse_partial_symbols): Update.
7768         * dbxread.c (dbx_end_psymtab): Update.
7769
7770 2019-01-15  Tom Tromey  <tom@tromey.com>
7771
7772         * symtab.c (lookup_objfile_from_block)
7773         (lookup_symbol_in_objfile_symtabs)
7774         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7775         (find_line_symtab, info_sources_command)
7776         (default_collect_symbol_completion_matches_break_on)
7777         (make_source_files_completion_list): Update.
7778         * symmisc.c (print_objfile_statistics, dump_objfile)
7779         (maintenance_print_symbols, maintenance_info_symtabs)
7780         (maintenance_check_symtabs, maintenance_info_line_tables):
7781         Update.
7782         * source.c (select_source_symtab)
7783         (forget_cached_source_info_for_objfile): Update.
7784         * objfiles.h (class objfile_compunits): Remove.
7785         (struct objfile) <compunits_range>: New typedef.
7786         (compunits): New method.
7787         * objfiles.c (objfile_relocate1): Update.
7788         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7789         * maint.c (count_symtabs_and_blocks): Update.
7790         * linespec.c (iterate_over_all_matching_symtabs): Update.
7791         * cp-support.c (add_symbol_overload_list_qualified): Update.
7792         * coffread.c (coff_symtab_read): Update.
7793         * ada-lang.c (add_nonlocal_symbols)
7794         (ada_collect_symbol_completion_matches)
7795         (ada_add_global_exceptions): Update.
7796
7797 2019-01-15  Tom Tromey  <tom@tromey.com>
7798
7799         * progspace.h (program_space) <objfiles_safe_range>: New
7800         typedef.
7801         <objfiles_safe>: New method.
7802         * objfiles.h (class all_objfiles_safe): Remove.
7803         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7804         * jit.c (jit_inferior_exit_hook): Update.
7805
7806 2019-01-17  Tom Tromey  <tom@tromey.com>
7807
7808         * progspace.h (program_space) <objfiles_range>: New typedef.
7809         <objfiles>: New method.
7810         <objfiles_head>: Rename from objfiles.
7811         (object_files): Update.
7812         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7813         * guile/scm-pretty-print.c
7814         (ppscm_find_pretty_printer_from_objfiles): Update.
7815         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7816         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7817         Update.
7818         * python/py-progspace.c (pspy_get_objfiles): Update.
7819         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7820         Update.
7821         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7822         (objfpy_lookup_objfile_by_build_id): Update.
7823         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7824         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7825         Update.
7826         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7827         (expand_symtab_containing_pc, lookup_objfile_from_block)
7828         (lookup_static_symbol, basic_lookup_transparent_type)
7829         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7830         (find_line_symtab, info_sources_command)
7831         (default_collect_symbol_completion_matches_break_on)
7832         (make_source_files_completion_list, find_main_name): Update.
7833         * symmisc.c (print_symbol_bcache_statistics)
7834         (print_objfile_statistics, maintenance_print_symbols)
7835         (maintenance_print_msymbols, maintenance_print_objfiles)
7836         (maintenance_info_symtabs, maintenance_check_symtabs)
7837         (maintenance_expand_symtabs, maintenance_info_line_tables):
7838         Update.
7839         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7840         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7841         (map_overlay_command, unmap_overlay_command)
7842         (simple_overlay_update, expand_symtabs_matching)
7843         (map_symbol_filenames): Update.
7844         * symfile-debug.c (set_debug_symfile): Update.
7845         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7846         Update.
7847         * source.c (select_source_symtab, forget_cached_source_info):
7848         Update.
7849         * solib.c (solib_read_symbols): Update.
7850         * solib-spu.c (append_ocl_sos): Update.
7851         * psymtab.c (maintenance_print_psymbols)
7852         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7853         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7854         * printcmd.c (info_symbol_command): Update.
7855         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7856         Update.
7857         * objfiles.h (class all_objfiles): Remove.
7858         * objfiles.c (have_partial_symbols, have_full_symbols)
7859         (have_minimal_symbols, qsort_cmp, update_section_map)
7860         (shared_objfile_contains_address_p)
7861         (default_iterate_over_objfiles_in_search_order): Update.
7862         * objc-lang.c (info_selectors_command, info_classes_command)
7863         (find_methods): Update.
7864         * minsyms.c (find_solib_trampoline_target): Update.
7865         * maint.c (maintenance_info_sections)
7866         (maintenance_translate_address, count_symtabs_and_blocks):
7867         Update.
7868         * main.c (captured_main_1): Update.
7869         * linux-thread-db.c (try_thread_db_load_from_pdir)
7870         (has_libpthread): Update.
7871         * linespec.c (iterate_over_all_matching_symtabs)
7872         (search_minsyms_for_name): Update.
7873         * jit.c (jit_find_objf_with_entry_addr): Update.
7874         * hppa-tdep.c (find_unwind_entry)
7875         (hppa_lookup_stub_minimal_symbol): Update.
7876         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7877         Update.
7878         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7879         (elf_gnu_ifunc_resolve_by_got): Update.
7880         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7881         * dwarf-index-write.c (save_gdb_index_command): Update.
7882         * cp-support.c (add_symbol_overload_list_qualified): Update.
7883         * breakpoint.c (create_overlay_event_breakpoint)
7884         (create_longjmp_master_breakpoint)
7885         (create_std_terminate_master_breakpoint)
7886         (create_exception_master_breakpoint): Update.
7887         * blockframe.c (find_pc_partial_function): Update.
7888         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7889         (ada_collect_symbol_completion_matches)
7890         (ada_add_global_exceptions): Update.
7891
7892 2019-01-17  Tom Tromey  <tom@tromey.com>
7893
7894         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7895         declare VEC.
7896         (solib_target_parse_libraries): Change return type.
7897         (library_list_start_segment, library_list_start_section)
7898         (library_list_end_library, library_list_start_library); Update.
7899         (solib_target_free_library_list): Remove.
7900         (solib_target_parse_libraries): Remove cleanup.  Change return
7901         type.
7902         (solib_target_current_sos): Update.
7903
7904 2019-01-17  Tom Tromey  <tromey@bapiya>
7905
7906         * valprint.c: Replace "the the" with "the".
7907         * symtab.c: Replace "the the" with "the".
7908         * solib.c: Replace "the the" with "the".
7909         * solib-dsbt.c: Replace "the the" with "the".
7910         * linespec.c: Replace "the the" with "the".
7911         * dwarf2loc.h: Replace "the the" with "the".
7912         * amd64-windows-tdep.c: Replace "the the" with "the".
7913         * aarch64-tdep.c: Replace "the the" with "the".
7914
7915 2019-01-16  Keith Seitz  <keiths@redhat.com>
7916
7917         PR gdb/23773
7918         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7919         <builder>: Rename to ..
7920         <m_builder>: ... this and make private.
7921         (dwarf2_cu::get_builder): New method.  Change all users of
7922         `builder' to use this method.
7923         (dwarf2_start_symtab): Move to ...
7924         (dwarf2_cu::start_symtab): ... here.  Update all callers
7925         (setup_type_unit_groups): Move to ...
7926         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7927         callers.
7928         (dwarf2_cu::reset_builder): New method.
7929         (process_full_compunit, process_full_type_unit): Use
7930         dwarf2_cu::reset_builder.
7931         (follow_die_offset): Record the ancestor CU if it is different
7932         from the followed DIE's CU.
7933         (follow_die_sig_1): Likewise.
7934
7935 2019-01-15  Tom Tromey  <tom@tromey.com>
7936
7937         * remote.c (class remote_state) <buf>: Now a char_vector.
7938         <buf_size>: Remove.
7939         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7940         parameter.
7941         (remote_target::getpkt_or_notif_sane_1)
7942         (remote_target::getpkt_sane)
7943         (remote_target::getpkt_or_notif_sane): Likewise.
7944         (class remote_target) <putpkt>: New overload.
7945         (remote_target::read_frame): Change type of "buf_p".  Remove
7946         sizeof_p parameter.
7947         (packet_ok): New overload.
7948         (packet_check_result): New overload.
7949         Update all uses.
7950
7951 2019-01-14  Tom Tromey  <tom@tromey.com>
7952
7953         * remote-notif.c (handle_notification, remote_notif_ack)
7954         (remote_notif_parse): Make "buf" const.
7955         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7956         const.
7957         (remote_notif_parse, remote_notif_ack, handle_notification):
7958         Likewise.
7959         * remote.c (remote_notif_stop_parse): Make "buf" const.
7960         (remote_target::remote_parse_stop_reply): Make "buf" const.
7961         (remote_notif_stop_ack): Make "buf" const.
7962
7963 2019-01-14  Tom Tromey  <tom@tromey.com>
7964
7965         * remote.c (remote_console_output): Make parameter const.
7966
7967 2019-01-14  Tom Tromey  <tom@tromey.com>
7968
7969         * target-debug.h (target_debug_print_signals): Constify.
7970         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7971         * procfs.c (procfs_target::pass_signals): Update.
7972         * linux-nat.c (linux_nat_target::pass_signals): Update.
7973         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7974         * target-delegates.c: Rebuild.
7975         * remote.c (remote_target::program_signals): Update.
7976         (remote_target::pass_signals): Update.
7977         * target.c (target_pass_signals): Constify argument.
7978         (target_program_signals): Likewise.
7979         * target.h (struct target_ops) <pass_signals, program_signals>:
7980         Constify argument.
7981         (target_pass_signals, target_program_signals): Constify argument.
7982
7983 2019-01-14  Tom Tromey  <tom@tromey.com>
7984
7985         PR tui/28819:
7986         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7987
7988 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7989
7990         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7991         field.
7992         * rs6000-tdep.c: Include reggroups.h.
7993         (IS_V_ALIAS_PSEUDOREG): Define.
7994         (rs6000_register_name): Return names for the "vX" aliases.
7995         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7996         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7997         aliases.  Call default_register_reggroup_p for all other
7998         pseudo-registers.
7999         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8000         New functions.
8001         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8002         Handle "vX" aliases.
8003         (v_alias_pseudo_register_collect): New function.
8004         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8005         (rs6000_gdbarch_init): Initialize "vX" aliases as
8006         pseudo-registers.  Restore registration of
8007         rs6000_pseudo_register_reggroup_p with
8008         set_tdesc_pseudo_register_reggroup_p.
8009
8010 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8011
8012         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8013         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8014         set_gdbarch_num_pseudo_regs.
8015
8016 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8017
8018         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8019         Remove arg prefixname, add do_set and do_show.
8020         Add member functions set_list and show_list.
8021         * cli/cli-style.c (class cli_style_option): Update accordingly.
8022         (style_set_list): Move to file scope.
8023         (style_show_list): Likewise.
8024         (set_style): Call help_list.
8025         (show_style): Call cmd_show_list.
8026         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8027         Update to use the new macro.
8028
8029 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8030
8031         * ada-lang.c (_initialize_ada_language): Expand the help text
8032         for the "catch exception" command.
8033
8034 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8035
8036         * symtab.c (matching_obj_sections): Initialize obj,
8037         declare it closer to its usage.
8038
8039 2019-01-10  Tom Tromey  <tom@tromey.com>
8040
8041         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8042         (basic_inf_threads_range): Remove.
8043         (inf_threads_range, inf_non_exited_threads_range)
8044         (safe_inf_threads_range): Use next_adapter.
8045
8046 2019-01-10  Keith Seitz  <keiths@redhat.com>
8047
8048         PR gdb/23712
8049         PR symtab/23010
8050         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8051         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8052
8053 2019-01-10  Keith Seitz  <keiths@redhat.com>
8054
8055         PR gdb/23712
8056         PR symtab/23010
8057         * dictionary.c (pending_to_vector): Remove.
8058         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8059         Remove _1 suffix, replacing functions of the same name.  Update
8060         all callers.
8061         (dict_create_hashed, dict_create_hashed_expandable)
8062         (dict_create_linear, dict_create_linear_expandable, dict_free)
8063         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8064         Make functions static.
8065
8066 2019-01-10  Keith Seitz  <keiths@redhat.com>
8067
8068         PR gdb/23712
8069         PR symtab/23010
8070         * dictionary.h (struct dictionary): Replace declaration with
8071         multidictionary.
8072         (dict_create_hashed, dict_create_hashed_expandable)
8073         (dict_create_linear, dict_create_linear_expandable)
8074         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8075         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8076         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8077         taking multidictionary argument.
8078         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8079         * block.h (struct block) <dict>: Change to multidictionary
8080         and rename `multidict'.
8081         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8082         symmisc.c: Update all dictionary references to multidictionary.
8083
8084 2019-01-10  Keith Seitz  <keiths@redhat.com>
8085
8086         PR gdb/23712
8087         PR symtab/23010
8088         * dictionary.c: Include unordered_map.
8089         (pending_to_vector): New function.
8090         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8091         Rewrite the non-"_1" functions to take vector instead
8092         of linked list.
8093         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8094         "new" _1 versions of the same name.
8095         (multidictionary): Define.
8096         (std::hash<enum language): New definition.
8097         (collate_pending_symbols_by_language, mdict_create_hashed)
8098         (mdict_create_hashed_expandable, mdict_create_linear)
8099         (mdict_create_linear_expandable, mdict_free)
8100         (find_language_dictionary, create_new_language_dictionary)
8101         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8102         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8103         (mdict_size, mdict_empty): New functions.
8104         * dictionary.h (mdict_iterator): Define.
8105
8106 2019-01-10  Pedro Alves  <palves@redhat.com>
8107
8108         * breakpoint.c (read_uploaded_action)
8109         (create_tracepoint_from_upload): Adjust to use
8110         gdb::unique_xmalloc_ptr.
8111         * ctf.c (ctf_write_uploaded_tp):
8112         (SET_ARRAY_FIELD): Use emplace_back.
8113         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8114         * tracefile-tfile.c (tfile_write_uploaded_tp):
8115         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8116         gdb::unique_xmalloc_ptr.
8117         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8118         at_string, cond_string, cmd_strings>: Replace char pointers
8119         with gdb::unique_xmalloc_ptr.
8120
8121 2019-01-10  Pedro Alves  <palves@redhat.com>
8122
8123         * solib-target.c (library_list_start_library): Don't xstrdup name.
8124
8125 2019-01-10  Pedro Alves  <palves@redhat.com>
8126
8127         * mdebugread.c (parse_partial_symbols): Use
8128         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8129
8130 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8131
8132         * linux-fork.c (scoped_switch_fork_info)
8133         <~scoped_switch_fork_info>: Fix incorrect variable name.
8134
8135 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * linux-fork.c (scoped_switch_fork_info)
8138         <scoped_switch_fork_info>: Make explicit.
8139         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8140
8141 2019-01-10  Tom Tromey  <tom@tromey.com>
8142
8143         * objfiles.h (objfile::reset_psymtabs): Update.
8144         * objfiles.c (objfile::objfile): Update.
8145         * psymtab.h (psymtab_storage::obstack): Update.
8146         (psymtab_storage::m_obstack): Use gdb::optional.
8147         (class psymtab_storage): Update comment.  Remove objfile
8148         parameter.
8149         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8150
8151 2019-01-10  Tom Tromey  <tom@tromey.com>
8152
8153         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8154         <free_psymtabs>: Now private.
8155         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8156         (allocate_psymtab): Use new method.
8157
8158 2019-01-10  Tom Tromey  <tom@tromey.com>
8159
8160         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8161         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8162         * mdebugread.c (parse_partial_symbols): Use
8163         allocate_dependencies.
8164         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8165         allocate_dependencies.
8166         (process_psymtab_comp_unit_reader)
8167         (build_type_psymtab_dependencies): Likewise.
8168         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8169
8170 2019-01-10  Tom Tromey  <tom@tromey.com>
8171
8172         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8173         PSYMBOL_SET_LANGUAGE.
8174         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8175
8176 2019-01-10  Tom Tromey  <tom@tromey.com>
8177
8178         * psymtab.h (psymtab_storage::obstack): New method.
8179         <m_obstack>: Rename from obstack; now private.
8180         * psymtab.c (psymtab_storage): Update.
8181         * dwarf2read.c (create_addrmap_from_index)
8182         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8183         Update.
8184
8185 2019-01-10  Tom Tromey  <tom@tromey.com>
8186
8187         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8188         * objfiles.h (objfile::reset_psymtabs): New method.
8189
8190 2019-01-10  Tom Tromey  <tom@tromey.com>
8191
8192         * symmisc.c (print_symbol_bcache_statistics): Update.
8193         (print_objfile_statistics): Update.
8194         * symfile.c (reread_symbols): Update.
8195         * psymtab.h (class psymtab_storage): New.
8196         * psymtab.c (psymtab_storage): New constructor.
8197         (~psymtab_storage): New destructor.
8198         (require_partial_symbols): Update.
8199         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8200         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8201         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8202         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8203         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8204         (start_psymtab_common, end_psymtab_common)
8205         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8206         (allocate_psymtab): Update.
8207         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8208         Update.
8209         (dump_psymtab_addrmap, maintenance_print_psymbols)
8210         (maintenance_check_psymtabs): Update.
8211         (class objfile_psymtabs): Move to objfiles.h.
8212         * psympriv.h (discard_psymtab): Now inline.
8213         (psymtab_discarder::psymtab_discarder): Update.
8214         (psymtab_discarder::~psymtab_discarder): Update.
8215         (ALL_OBJFILE_PSYMTABS): Rewrite.
8216         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8217         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8218         Remove fields.
8219         <partial_symtabs>: New field.
8220         (class objfile_psymtabs): Move from psymtab.h.  Update.
8221         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8222         psymbol_cache.
8223         (objfile::~objfile): Don't destroy psymbol_cache.
8224         * mdebugread.c (parse_partial_symbols): Update.
8225         * dwarf2read.c (create_addrmap_from_index)
8226         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8227         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8228         (add_partial_subprogram, dwarf2_ranges_read): Update.
8229         * dwarf-index-write.c (write_address_map)
8230         (write_one_signatured_type, recursively_write_psymbols)
8231         (class debug_names, class debug_names, write_psymtabs_to_index):
8232         Update.
8233
8234 2019-01-10  Tom Tromey  <tom@tromey.com>
8235
8236         * symtab.h (SYMBOL_SET_NAMES): Update.
8237         (symbol_set_names): Update.
8238         (MSYMBOL_SET_NAMES): Update.
8239         * symtab.c (symbol_set_names): Change argument to be an
8240         objfile_per_bfd_storage.
8241         * psymtab.c (add_psymbol_to_bcache): Update.
8242         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8243
8244 2019-01-10  Tom Tromey  <tom@tromey.com>
8245
8246         * symtab.c (create_demangled_names_hash): Change argument to be an
8247         objfile_per_bfd_storage.
8248         (symbol_set_names): Update.
8249
8250 2019-01-10  Tom Tromey  <tom@tromey.com>
8251
8252         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8253         init_psymbol_list.
8254         * psymtab.c (init_psymbol_list): Do nothing if already called.
8255         * psympriv.h (init_psymbol_list): Add comment.
8256         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8257         init_psymbol_list.
8258         * dbxread.c (dbx_symfile_read): Unconditionally call
8259         init_psymbol_list.
8260
8261 2019-01-10  Tom Tromey  <tom@tromey.com>
8262
8263         * xcoffread.c (scan_xcoff_symtab): Update.
8264         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8265         "where".
8266         * mdebugread.c (parse_partial_symbols)
8267         (handle_psymbol_enumerators): Update.
8268         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8269         * dbxread.c (read_dbx_symtab): Update.
8270         * psympriv.h (psymbol_placement): New enum.
8271         (add_psymbol_to_list): Update.
8272
8273 2019-01-10  Tom Tromey  <tom@tromey.com>
8274
8275         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8276         static_psymbols parameters.
8277         (scan_xcoff_symtab): Update.
8278         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8279         static_psymbols parameters.
8280         * psympriv.h (start_psymtab_common): Update.
8281         * mdebugread.c (parse_partial_symbols): Update.
8282         * dwarf2read.c (create_partial_symtab): Update.
8283         * dbxread.c (read_dbx_symtab): Update.
8284         (start_psymtab): Remove global_psymbols and static_psymbols
8285         parameters.
8286
8287 2019-01-10  Tom Tromey  <tom@tromey.com>
8288
8289         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8290         * psymtab.c (allocate_psymtab): Add comment.
8291         * psympriv.h (allocate_psymtab): Add comment.
8292         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8293         initializations.
8294         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8295
8296 2019-01-10  Tom Tromey  <tom@tromey.com>
8297
8298         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8299         Don't declare.
8300         * mipsread.c: Include mdebugread.h.
8301         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8302         Declare.
8303         * elfread.c: Include mdebugread.h.
8304
8305 2019-01-09  Tom Tromey  <tom@tromey.com>
8306
8307         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8308         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8309         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8310         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8311         (psym_lookup_symbol, psym_find_last_source_symtab)
8312         (psym_forget_cached_source_info, psym_print_stats)
8313         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8314         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8315         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8316         (psym_find_compunit_symtab_by_address)
8317         (maintenance_print_psymbols, maintenance_info_psymtabs)
8318         (maintenance_check_psymtabs): Use ranged for.
8319         * psymtab.h (class objfile_psymtabs): New.
8320         (require_partial_symbols): Return objfile_psymtabs.
8321         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8322
8323 2019-01-09  Tom Tromey  <tom@tromey.com>
8324
8325         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8326         (find_pc_mapped_section, list_overlays_command)
8327         (map_overlay_command, unmap_overlay_command)
8328         (simple_overlay_update): Use all_objfiles.
8329         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8330         * printcmd.c (info_symbol_command): Use all_objfiles.
8331         * objfiles.h (ALL_OBJSECTIONS): Remove.
8332         * maint.c (maintenance_translate_address): Use all_objfiles.
8333         * gcore.c (gcore_create_callback): Use all_objfiles.
8334         (objfile_find_memory_regions): Likewise.
8335
8336 2019-01-09  Tom Tromey  <tom@tromey.com>
8337
8338         * symtab.c (find_line_symtab, info_sources_command)
8339         (make_source_files_completion_list): Use objfile_compunits.
8340         * source.c (select_source_symtab): Use objfile_compunits.
8341         * objfiles.h (struct objfile): Update comment.
8342         (ALL_OBJFILES): Remove.
8343         (ALL_FILETABS): Remove.
8344         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8345         objfile_compunits.
8346
8347 2019-01-09  Tom Tromey  <tom@tromey.com>
8348
8349         * symmisc.c (print_objfile_statistics, dump_objfile)
8350         (maintenance_print_symbols): Use compunit_filetabs.
8351         * source.c (forget_cached_source_info_for_objfile): Use
8352         compunit_filetabs.
8353         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8354         (ALL_FILETABS): Use compunit_filetabs.
8355         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8356         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8357
8358 2019-01-09  Tom Tromey  <tom@tromey.com>
8359
8360         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8361         (compunit_filetabs): New.
8362         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8363         compunit_filetabs.
8364         (info_sources_command, make_source_files_completion_list): Remove
8365         declaration.
8366         * symmisc.c (print_objfile_statistics, dump_objfile)
8367         (maintenance_print_symbols): Remove declaration.
8368         (maintenance_info_symtabs): Use compunit_filetabs.
8369         (maintenance_info_line_tables): Likewise.
8370         * source.c (select_source_symtab): Change local variable name.
8371         (forget_cached_source_info_for_objfile): Remove declaration.
8372         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8373         * objfiles.c (objfile_relocate1): Remove declaration.
8374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8375         declaration.
8376         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8377         * coffread.c (coff_symtab_read): Remove declaration.
8378         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8379         compunit_filetabs.
8380
8381 2019-01-09  Tom Tromey  <tom@tromey.com>
8382
8383         * symtab.c (lookup_objfile_from_block)
8384         (find_pc_sect_compunit_symtab, search_symbols)
8385         (default_collect_symbol_completion_matches_break_on): Use
8386         objfile_compunits.
8387         * objfiles.h (ALL_COMPUNITS): Remove.
8388         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8389         * cp-support.c (add_symbol_overload_list_qualified): Use
8390         objfile_compunits.
8391         * ada-lang.c (ada_collect_symbol_completion_matches)
8392         (ada_add_global_exceptions): Use objfile_compunits.
8393
8394 2019-01-09  Tom Tromey  <tom@tromey.com>
8395
8396         * source.c (select_source_symtab)
8397         (forget_cached_source_info_for_objfile): Remove declaration.
8398         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8399         declaration.
8400         * maint.c (count_symtabs_and_blocks): Remove declaration.
8401         * cp-support.c (add_symbol_overload_list_qualified): Remove
8402         declaration.
8403         * coffread.c (coff_symtab_read): Remove declaration.
8404         * symtab.c (lookup_symbol_in_objfile_symtabs)
8405         (basic_lookup_transparent_type_1): Use objfile_compunits.
8406         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8407         (info_sources_command, search_symbols)
8408         (default_collect_symbol_completion_matches_break_on)
8409         (make_source_files_completion_list): Remove declaration.
8410         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8411         (ada_collect_symbol_completion_matches)
8412         (ada_add_global_exceptions): Remove declaration.
8413         * linespec.c (iterate_over_all_matching_symtabs): Use
8414         objfile_compunits.
8415         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8416         (class objfile_compunits): New.
8417         (ALL_COMPUNITS): Use objfile_compunits.
8418         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8419         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8420         objfile_compunits.
8421         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8422
8423 2019-01-09  Tom Tromey  <tom@tromey.com>
8424
8425         * symtab.c (search_symbols)
8426         (default_collect_symbol_completion_matches_break_on): Use
8427         objfile_msymbols.
8428         * ada-lang.c (ada_lookup_simple_minsym)
8429         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8430         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8431         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8432         objfile_msymbols.
8433         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8434         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8435         * objc-lang.c (find_methods): Use objfile_msymbols.
8436         (info_selectors_command, info_classes_command): Likewise.
8437         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8438         * objfiles.h (class objfile_msymbols): New.
8439         (ALL_OBJFILE_MSYMBOLS): Remove.
8440         (ALL_MSYMBOLS): Remove.
8441
8442 2019-01-09  Tom Tromey  <tom@tromey.com>
8443
8444         * common/next-iterator.h (next_adapter): Add Iterator template
8445         parameter.
8446         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8447         (class all_objfiles_safe): New.
8448         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8449         * objfiles.c (put_objfile_before): Update comment.
8450         (add_separate_debug_objfile): Likewise.
8451         (free_all_objfiles): Use all_objfiles_safe.
8452         (objfile_purge_solibs): Likewise.
8453
8454 2019-01-09  Tom Tromey  <tom@tromey.com>
8455
8456         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8457         (expand_symtab_containing_pc, lookup_static_symbol)
8458         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8459         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8460         all_objfiles.
8461         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8462         * breakpoint.c (create_overlay_event_breakpoint)
8463         (create_longjmp_master_breakpoint)
8464         (create_std_terminate_master_breakpoint)
8465         (create_exception_master_breakpoint): Use all_objfiles.
8466         * linux-thread-db.c (try_thread_db_load_from_pdir)
8467         (has_libpthread): Use all_objfiles.
8468         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8469         * linespec.c (iterate_over_all_matching_symtabs)
8470         (search_minsyms_for_name): Use all_objfiles.
8471         * maint.c (maintenance_info_sections): Use all_objfiles.
8472         * main.c (captured_main_1): Use all_objfiles.
8473         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8474         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8475         * guile/scm-pretty-print.c
8476         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8477         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8478         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8479         (maintenance_print_msymbols): Use all_objfiles.
8480         * source.c (select_source_symtab): Use all_objfiles.
8481         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8482         * symfile.c (remove_symbol_file_command)
8483         (expand_symtabs_matching, map_symbol_filenames): Use
8484         all_objfiles.
8485         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8486         all_objfiles.
8487         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8488         * objc-lang.c (find_methods): Use all_objfiles.
8489         * objfiles.c (have_partial_symbols, have_full_symbols)
8490         (have_minimal_symbols, qsort_cmp)
8491         (default_iterate_over_objfiles_in_search_order): Use
8492         all_objfiles.
8493         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8494         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8495         (maintenance_check_psymtabs): Use all_objfiles.
8496         (ALL_PSYMTABS): Remove.
8497         * compile/compile-object-run.c (do_module_cleanup): Use
8498         all_objfiles.
8499         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8500         * cp-support.c (add_symbol_overload_list_qualified): Use
8501         all_objfiles.
8502         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8503         Use all_objfiles.
8504         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8505         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8506         all_objfiles.
8507         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8508         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8509         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8510         Uses all_objfiles.
8511         * solib.c (solib_read_symbols): Use all_objfiles
8512
8513 2019-01-09  Tom Tromey  <tom@tromey.com>
8514
8515         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8516         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8517         all_objfiles.
8518         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8519         * symmisc.c (print_symbol_bcache_statistics)
8520         (print_objfile_statistics, maintenance_print_objfiles)
8521         (maintenance_info_symtabs, maintenance_check_symtabs)
8522         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8523         all_objfiles.
8524         * source.c (forget_cached_source_info): Use all_objfiles.
8525         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8526         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8527         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8528         * objfiles.c (update_section_map): Use all_objfiles.
8529         (shared_objfile_contains_address_p): Likewise.
8530         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8531         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8532
8533 2019-01-09  Tom Tromey  <tom@tromey.com>
8534
8535         * common/next-iterator.h: New file.
8536         * objfiles.h (class all_objfiles): New.
8537         (struct objfile_iterator): New.
8538
8539 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8540
8541         * NEWS: Move the description of the changed "frame", "select-frame",
8542          and "info frame" commands to the Changed commands section.
8543
8544 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8545
8546         * gdbtypes.c (check_stub_method_group): Remove handling of old
8547         mangling schemes.
8548         * linespec.c (find_methods): Likewise.
8549         * stabsread.c (read_member_functions): Likewise.
8550         * valops.c (search_struct_method): Likewise.
8551         (value_struct_elt_for_reference): Likewise.
8552         * NEWS: Mention this change.
8553
8554 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8555
8556         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8557         print_source_lines.
8558         * source.c (print_source_lines_base): Update line number check.
8559         (print_source_lines): New function.
8560         (source_lines_range::source_lines_range): New function.
8561         * source.h (class source_lines_range): New class.
8562         (print_source_lines): New declaration.
8563
8564 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8565
8566         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8567
8568 2019-01-08  Tom Tromey  <tom@tromey.com>
8569             Simon Marchi  <simon.marchi@ericsson.com>
8570
8571         PR gdb/24060
8572         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8573         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8574         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8575         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8576         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8577         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8578
8579 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * source.c (select_source_symtab): Move header comment to
8582         declaration in source.h.
8583         (forget_cached_source_info_for_objfile): Likewise.
8584         (forget_cached_source_info): Likewise.
8585         (identify_source_line): Likewise.
8586         * source.h (identify_source_line): Move declaration from symtab.h
8587         and add comment from source.c
8588         (print_source_lines): Likewise.
8589         (forget_cached_source_info_for_objfile): Likewise.
8590         (forget_cached_source_info): Likewise.
8591         (select_source_symtab): Likewise.
8592         (enum print_source_lines_flag): Move definition from symtab.h.
8593         * symtab.h (identify_source_line): Move declaration to source.h.
8594         (print_source_lines): Likewise.
8595         (forget_cached_source_info_for_objfile): Likewise.
8596         (forget_cached_source_info): Likewise.
8597         (select_source_symtab): Likewise.
8598         (enum print_source_lines_flag): Move definition to source.h.
8599         * tui/tui-hooks.c: Add 'source.h' include.
8600
8601 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8602
8603         * source.c (print_source_lines_base): Handle requests to print
8604         reverse line number sequences, and guard against empty lines
8605         string.
8606
8607 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8608
8609         * source.c (print_source_lines_base): Fix skip of '\r' if next
8610         character is '\n'.
8611
8612 2019-01-06  Tom Tromey  <tom@tromey.com>
8613
8614         * c-exp.y (struct c_parse_state) <macro_original_text,
8615         expansion_obstack>: New member.
8616         (macro_original_text, expansion_obstack): Remove globals.
8617         (scan_macro_expansion, scanning_macro_expansion)
8618         (finished_macro_expansion): Update.
8619         (scan_macro_cleanup): Remove.
8620         (yylex, c_parse): Update.
8621
8622 2019-01-06  Tom Tromey  <tom@tromey.com>
8623
8624         * c-exp.y (struct c_parse_state) <strings>: New member.
8625         (operator_stoken): Update.
8626
8627 2019-01-06  Tom Tromey  <tom@tromey.com>
8628
8629         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8630         (union type_stack_elt) <typelist_val>: Now a pointer to
8631         std::vector.
8632         (type_stack_cleanup): Don't declare.
8633         (push_typelist): Update.
8634         * parse.c (pop_typelist): Return a std::vector.
8635         (push_typelist): Take a std::vector.
8636         (follow_types): Update.  Do not free args.
8637         (type_stack_cleanup): Remove.
8638         * c-exp.y (struct c_parse_state): New.
8639         (cpstate): New global.
8640         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8641         (nonempty_typelist): Update.
8642         (func_mod): Create a new vector.
8643         (c_parse): Create a c_parse_state.
8644         (check_parameter_typelist): Do not delete params.
8645         (function_method): Update.  Do not delete type_list.
8646
8647 2019-01-06  Tom Tromey  <tom@tromey.com>
8648
8649         PR gdb/28155:
8650         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8651         check_typedef.
8652         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8653         (print_return_value): Likewise.
8654
8655 2019-01-05  Tom Tromey  <tom@tromey.com>
8656
8657         * contrib/cleanup_check.py: Remove.
8658         * contrib/gcc-with-excheck: Remove.
8659         * contrib/exsummary.py: Remove.
8660         * contrib/excheck.py: Remove.
8661
8662 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8663
8664         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8665         NULL. Initialize tpprev to NULL instead of assigning it
8666         to NULL on the next statement.
8667         * windows-nat.c (windows_delete_thread): Remove check for
8668         main_thread_id before printing thread exit notifications.
8669         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8670         Remove thread ID check against main_thread_id.
8671         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8672         windows_delete_thread.
8673         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8674
8675 2019-01-04  Tom Tromey  <tom@tromey.com>
8676
8677         * compile/compile.c (_initialize_compile): Use upper case for
8678         metasyntactic variables.
8679         * symmisc.c (_initialize_symmisc): Use upper case for
8680         metasyntactic variables.
8681         * psymtab.c (_initialize_psymtab): Use upper case for
8682         metasyntactic variables.
8683         * demangle.c (demangle_command): Use upper case for metasyntactic
8684         variables.
8685         (_initialize_demangler): Likewise.
8686         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8687         variables.
8688
8689 2019-01-03  Tom Tromey  <tom@tromey.com>
8690
8691         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8692
8693 2019-01-03  Tom Tromey  <tom@tromey.com>
8694
8695         * python/py-symtab.c (salpy_str): Update.
8696         (struct salpy_sal_object) <symtab>: Now a PyObject.
8697         (salpy_dealloc): Update.
8698         (del_objfile_sal): Use gdbpy_ref.
8699
8700 2019-01-03  Tom Tromey  <tom@tromey.com>
8701
8702         * python/py-type.c (convert_field): Use new_reference.  Return
8703         gdbpy_ref.
8704         (make_fielditem): Return gdbpy_ref.
8705         (typy_fields): Update.
8706         (typy_getitem): Update.
8707         (field_name): Return gdbpy_ref.  Use new_reference.
8708         (typy_iterator_iternext): Update.
8709
8710 2019-01-03  Tom Tromey  <tom@tromey.com>
8711
8712         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8713
8714 2019-01-03  Tom Tromey  <tom@tromey.com>
8715
8716         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8717         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8718         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8719         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8720         (pspy_set_type_printers): Likewise.
8721         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8722         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8723         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8724         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8725         (objfpy_set_type_printers): Likewise.
8726
8727 2019-01-03  Tom Tromey  <tom@tromey.com>
8728
8729         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8730         (gdbpy_print_stack): Use gdbpy_err_fetch.
8731         * python/python-internal.h (class gdbpy_err_fetch): New class.
8732         (class gdbpy_enter) <m_error_type, m_error_value,
8733         m_error_traceback>: Remove.
8734         <m_error>: New member.
8735         (gdbpy_exception_to_string): Don't declare.
8736         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8737         * python/py-value.c (convert_value_from_python): Use
8738         gdbpy_err_fetch.
8739         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8740         gdbpy_exception_to_string.
8741         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8742         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8743         gdbpy_err_fetch.
8744
8745 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8746
8747         * linux-nat.c (delete_lwp_cleanup): Delete.
8748         (struct lwp_deleter): New struct.
8749         (lwp_info_up): New typedef.
8750         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8751         lwp_info_up.
8752
8753 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * linux-fork.c (class scoped_switch_fork_info): New class.
8756         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8757
8758 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8759
8760         * valops.c (find_overload_match): Remove use of null_cleanup, and
8761         calls to do_cleanups.
8762
8763 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8764
8765         * compile/compile-cplus-types.c
8766         (compile_cplus_instance::decl_name): Handle changes to
8767         cp_func_name.
8768         * cp-support.c (cp_func_name): Update header comment, update
8769         return type.
8770         * cp-support.h (cp_func_name): Update return type in declaration.
8771         * valops.c (find_overload_match): Move temp_func local to top
8772         level of function and change its type.  Use temp_func to hold and
8773         delete temporary string obtained from cp_func_name.
8774
8775 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8778         gdb::char_vector, remove cleanup, and update uses of `msg`.
8779
8780 2019-01-03  Jim Wilson  <jimw@sifive.com>
8781
8782         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8783
8784 2019-01-02  Tom Tromey  <tom@tromey.com>
8785
8786         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8787         (tdesc_parse_xml): Remove cleanups.
8788         * target-descriptions.h (make_cleanup_free_target_description):
8789         Don't declare.
8790         (target_desc_deleter): New struct.
8791         (target_desc_up): New typedef.
8792         * target-descriptions.c (target_desc_deleter::operator()): Rename
8793         from free_target_description.
8794         (make_cleanup_free_target_description): Remove.
8795
8796 2019-01-02  Tom Tromey  <tom@tromey.com>
8797
8798         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8799         constructor, destructor.
8800         (linespec_parser): Remove typedef.
8801         (~linespec_parser): Rename from linespec_parser_delete.
8802         (linespec_lex_to_end, linespec_complete_label)
8803         (linespec_complete): Update.
8804         (decode_line_full): Remove cleanups.
8805         (decode_line_1): Update.
8806
8807 2019-01-02  Tom Tromey  <tom@tromey.com>
8808
8809         * python/python-internal.h (inferior_to_inferior_object): Change
8810         return type.
8811         * python/py-exitedevent.c (create_exited_event_object): Update.
8812         * python/py-inferior.c (inferior_to_inferior_object): Return
8813         gdbpy_ref.
8814         (python_new_inferior, python_inferior_deleted)
8815         (thread_to_thread_object, delete_thread_object)
8816         (build_inferior_list, gdbpy_selected_inferior): Update.
8817         * python/py-infthread.c (create_thread_object): Update.  Also fail
8818         if inferior_to_inferior_object fails.
8819
8820 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8821
8822         * inferior.h (class inferior) <displaced_step_state>: New field.
8823         * infrun.h (struct displaced_step_state): Move here from
8824         infrun.c.  Initialize fields, add constructor.
8825         <inf>: Remove field.
8826         <reset>: New method.
8827         * infrun.c (struct displaced_step_inferior_state): Move to
8828         infrun.h.
8829         (displaced_step_inferior_states): Remove.
8830         (get_displaced_stepping_state): Adust.
8831         (displaced_step_in_progress_any_inferior): Adjust.
8832         (displaced_step_in_progress_thread): Adjust.
8833         (displaced_step_in_progress): Adjust.
8834         (add_displaced_stepping_state): Remove.
8835         (get_displaced_step_closure_by_addr): Adjust.
8836         (remove_displaced_stepping_state): Remove.
8837         (infrun_inferior_exit): Call displaced_step_state.reset.
8838         (use_displaced_stepping): Don't check for NULL.
8839         (displaced_step_prepare_throw): Call
8840         get_displaced_stepping_state.
8841         (displaced_step_fixup): Don't check for NULL.
8842         (prepare_for_detach): Don't check for NULL.
8843
8844 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8845
8846         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8847          in case of call that did not complete.
8848
8849 2019-01-02  Andrey Utkin  <autkin@undo.io>
8850
8851         * symfile.c (find_separate_debug_file): Fix search of debug files for
8852         remote debuggee.
8853
8854 2019-01-02  Tom Tromey  <tom@tromey.com>
8855
8856         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8857         indentation.
8858         * python/py-frame.c (frapy_older): Remove cast.
8859         (frapy_newer): Likewise.
8860         * python/py-breakpoint.c (local_setattro): Remove cast.
8861         * python/py-arch.c (archpy_name): Remove local variable.
8862         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8863
8864 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8865
8866         * unittests/basic_string_view/element_access/char/empty.cc:
8867         Fix year range in copyright header.
8868
8869 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8870
8871         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8872         Delete.
8873         <operator==>: Update with for removed field.
8874         <hash>: Likewise.
8875         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8876         <isa_features>: ...this.
8877         <abi_features>: New field.
8878         (riscv_isa_flen): Update comment.
8879         (riscv_abi_xlen): New declaration.
8880         (riscv_abi_flen): New declaration.
8881         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8882         isa_features.
8883         (riscv_abi_xlen): New function.
8884         (riscv_isa_flen): Update to get answer from isa_features.
8885         (riscv_abi_flen): New function.
8886         (riscv_has_fp_abi): Update to get answer from abi_features.
8887         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8888         xlen and flen.
8889         (riscv_call_info) <xlen, flen>: Update comment.
8890         (riscv_call_arg_struct): Remove invalid assertions
8891         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8892         is removed.
8893         (riscv_gdbarch_init): Gather isa features and abi features
8894         separately, ensure both match on the gdbarch when reusing an old
8895         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8896         a target with 64-bit float hardware.
8897
8898 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8899
8900         * source.c (search_command_helper): Stop reverse search
8901         when line 1 has been searched.
8902
8903 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8904
8905         * record-full.c (record_full_base_target::close): Rewrite
8906         record_full_core_buf_list free logic.
8907
8908 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8909
8910         * break-catch-syscall.c (print_one_catch_syscall): xfree
8911         the last text.
8912
8913 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8914
8915         * top.c (print_gdb_version): Update Copyright year in version
8916         message.
8917
8918 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8919
8920         Update copyright year range in all GDB files.
8921
8922 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8923
8924         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8925
8926 For older changes see ChangeLog-2018.
8927 \f
8928 Local Variables:
8929 mode: change-log
8930 left-margin: 8
8931 fill-column: 74
8932 version-control: never
8933 coding: utf-8
8934 End:
8935