gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
   4         (tui_data_window::rerender): Don't call
   5         check_and_display_highlight_if_needed.
   6         (tui_data_window::refresh_all): Remove call to
   7         erase_data_content.
   8
   9 2019-08-30  Tom Tromey  <tom@tromey.com>
  10
  11         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
  12         (tui_data_window::display_registers_from)
  13         (tui_data_window::display_reg_element_at_line)
  14         (tui_data_window::display_registers_from_line): Remove checks of
  15         "empty".
  16
  17 2019-08-30  Tom Tromey  <tom@tromey.com>
  18
  19         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
  20         Don't declare.
  21         * tui/tui-regs.c (tui_data_window::show_registers): Call
  22         rerender.
  23         (tui_data_window::rerender): Rename from display_all_data.
  24         (tui_data_window::rerender): Remove old implementation.
  25
  26 2019-08-30  Tom Tromey  <tom@tromey.com>
  27
  28         * tui/tui-regs.c (tui_data_window::display_all_data): Change
  29         text.
  30         * tui/tui-data.h (NO_DATA_STRING): Remove define.
  31
  32 2019-08-29  Bernhard Wodok  <barto@gmx.net>
  33             Sergio Durigan Junior  <sergiodj@redhat.com>
  34
  35         PR win32/24284
  36         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  37
  38 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  41         when searching for types.
  42
  43 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * f-lang.c (f_language_defn): Use f_print_typedef.
  46         * f-lang.h (f_print_typedef): Declare.
  47         * f-typeprint.c (f_print_typedef): Define.
  48
  49 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  50
  51         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  52
  53 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * cli/cli-utils.c (info_print_options_defs): Delete.
  56         (make_info_print_options_def_group): Delete.
  57         (extract_info_print_options): Delete.
  58         (info_print_command_completer): Delete.
  59         (info_print_args_help): Add extra parameter, and optionally
  60         include text about -n flag.
  61         * cli/cli-utils.h (struct info_print_options): Delete.
  62         (extract_info_print_options): Delete declaration.
  63         (info_print_command_completer): Delete declaration.
  64         (info_print_args_help): Add extra parameter, extend header
  65         comment.
  66         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  67         search_symbols.
  68         * stack.c (struct info_print_options): New type.
  69         (info_print_options_defs): New file scoped variable.
  70         (make_info_print_options_def_group): New static function.
  71         (info_print_command_completer): New static function.
  72         (info_locals_command): Update to use new local functions.
  73         (info_args_command): Likewise.
  74         (_initialize_stack): Add extra parameter to calls to
  75         info_print_args_help.
  76         * symtab.c (search_symbols): Add extra parameter, use this to
  77         possibly excluse non-debug symbols.
  78         (symtab_symbol_info): Add extra parameter, which is passed on to
  79         search_symbols.
  80         (struct info_print_options): New type.
  81         (info_print_options_defs): New file scoped variable.
  82         (make_info_print_options_def_group): New static function.
  83         (info_print_command_completer): New static function.
  84         (info_variables_command): Update to use local functions, and pass
  85         extra parameter through to symtab_symbol_info.
  86         (info_functions_command): Likewise.
  87         (info_types_command): Pass additional argument through to
  88         symtab_symbol_info.
  89         (rbreak_command): Pass extra argument to search_symbols.
  90         (_initialize_symtab): Add extra arguments for calls to
  91         info_print_args_help, and update help text for 'info variables',
  92         'whereis', and 'info functions' commands.
  93         * symtab.h (search_symbols): Add extra argument to declaration.
  94         * NEWS: Mention new flags.
  95
  96 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * symtab.c (lookup_static_symbol): Call the new function (and move
  99         it down to be next to lookup_global_symbol).
 100         (struct global_sym_lookup_data): Add block_enum member and rename to...
 101         (struct global_or_static_sym_lookup_data): ...this.
 102         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 103         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 104         (lookup_symbol_global_or_static_iterator_cb): ...this.
 105         (lookup_global_or_static_symbol): New function.
 106         (lookup_global_symbol): Call new function.
 107
 108 2019-08-26  Tom de Vries  <tdevries@suse.de>
 109
 110         PR c++/24852
 111         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 112         when pc_probe.prob == NULL.
 113
 114 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 115
 116         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 117         variable symbol_linkage to symbol_linkage_.
 118
 119 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 120
 121         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 122         represent whether the symbol is static, dynamic, or we don't
 123         know.
 124
 125 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 126
 127         * gdb/rx-tdep.c (rx_register_names): New.
 128         (rx_register_name): Delete.
 129         (rx_psw_type): Delete.
 130         (rx_fpsw_type): Delete.
 131         (rx_register_type): Delete.
 132         (rx_gdbarch_init): Convert target-descriptions.
 133         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 134         * gdb/features/Makefile: Add rx.xml.
 135         * gdb/features/rx.xml: New.
 136         * gdb/features/rx.c: Generated.
 137         * gdb/NEWS: Mention target description support.
 138
 139 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 140
 141         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 142         *slot_ptr.
 143
 144 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 145
 146         * configure.ac: Don't check for 'dlfcn.h' (moved to
 147         gdbsupport/common.m4).
 148         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 149         'gdbsupport/'.
 150         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 151         * compile/compile-c-support.c: Include
 152         'gdbsupport/gdb-dlfcn.h'.
 153         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 154         * gdb-dlfcn.c: Move to...
 155         * gdbsupport/gdb-dlfcn.c: ... here.
 156         * gdb-dlfcn.h: Move to...
 157         * gdbsupport/gdb-dlfcn.h: ... here.
 158
 159 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 160
 161         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 162         the offset field signed.
 163
 164 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 165
 166         * python/lib/gdb/__init__.py (_execute_file): New function.
 167         * python/python.c (python_run_simple_file): Call gdb._execute_file
 168         on Windows.
 169
 170 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 173         all uses as this was never set to anything but a zero value.
 174
 175 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 176
 177         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 178
 179 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 180
 181         * tui/tui-data.h (tui_gen_win_info): Add an =default
 182         move constructor, required by some GCC versions.
 183
 184 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 185
 186         * go32-nat.c (go32_sysinfo): Add hygon_p.
 187
 188 2019-08-20  Tom Tromey  <tom@tromey.com>
 189
 190         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 191         line_from_reg_element_no, first_reg_element_no_inline,
 192         display_all_data, delete_data_content_windows,
 193         erase_data_content>: Now private.
 194
 195 2019-08-20  Tom Tromey  <tom@tromey.com>
 196
 197         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 198         (tui_unhighlight_win, tui_highlight_win)
 199         (tui_win_info::make_window): Update.
 200         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 201
 202 2019-08-20  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 205         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 206         (MAX_PID_WIDTH): Move to tui-stack.c.
 207         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 208         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 209         (MAX_PID_WIDTH): Move from tui-data.h.
 210
 211 2019-08-20  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 214         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 215         (box_win): Update.
 216         (tui_gen_win_info::make_window): Rename from tui_make_window.
 217         (tui_win_info::make_window): New method.
 218         (tui_gen_win_info::make_visible): Update.
 219         * tui/tui-source.c (tui_source_window::set_contents): Update.
 220         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 221         (tui_data_window::display_registers_from): Update.
 222         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 223         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 224         Declare.
 225         <can_box>: Remove.
 226         <title>: Remove.
 227         (struct tui_win_info) <make_window>: Declare.
 228         <can_box>: Now virtual.
 229         <title>: New member.
 230         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 231         * tui/tui-command.c (tui_cmd_window::resize): Update.
 232
 233 2019-08-20  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 236         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 237         (tui_data_window::check_register_values): Update.
 238
 239 2019-08-20  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-regs.h (struct tui_data_window): Use
 242         DISABLE_COPY_AND_ASSIGN.
 243         <regs_content>: Change type, removing unique_ptr.
 244         <tui_data_window>: Add move constructor.
 245         * tui/tui-regs.c (tui_data_window::show_registers)
 246         (tui_data_window::show_register_group)
 247         (tui_data_window::display_registers_from)
 248         (tui_data_window::display_registers_from)
 249         (tui_data_window::first_data_item_displayed)
 250         (tui_data_window::delete_data_content_windows)
 251         (tui_data_window::rerender, tui_data_window::refresh_window)
 252         (tui_data_window::check_register_values): Update.
 253
 254 2019-08-20  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 257         show_register_group>: Declare.
 258         (tui_show_register_group): Don't declare.
 259         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 260         tui_show_registers.
 261         (tui_data_window::show_register_group): Rename from
 262         tui_show_register_group.
 263         (tui_data_window::check_register_values, tui_reg_command):
 264         Update.
 265         * tui/tui-layout.c (tui_set_layout): Update.
 266
 267 2019-08-20  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 270         Declare.
 271         (tui_check_register_values): Don't declare.
 272         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 273         from tui_check_register_values.
 274         * tui/tui-hooks.c (tui_register_changed): Update.
 275
 276 2019-08-20  Tom Tromey  <tom@tromey.com>
 277
 278         * tui/tui-regs.c (tui_reg_layout): Move later.
 279         (tui_show_registers): Don't enable TUI mode or change layout.
 280
 281 2019-08-20  Tom Tromey  <tom@tromey.com>
 282
 283         * tui/tui-regs.h (struct tui_data_item_window)
 284         <~tui_data_item_window>: Remove.
 285         <content>: Now a unique_xmalloc_ptr.
 286         * tui/tui-regs.c (tui_register_format): Return a
 287         unique_xmalloc_ptr.
 288         (tui_get_register): Update.
 289         (~tui_data_item_window): Remove.
 290         (tui_data_window::display_registers_from, tui_display_register):
 291         Update.
 292         * tui/tui-io.h (tui_expand_tabs): Update.
 293         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 294         Remove "col" parameter.
 295
 296 2019-08-20  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 299         field.
 300         * tui/tui-regs.c (~tui_data_item_window): Update.
 301
 302 2019-08-20  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 305         earlier.
 306
 307 2019-08-20  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 310
 311 2019-08-20  Tom Tromey  <tom@tromey.com>
 312
 313         * tui/tui-source.h (struct tui_source_window): Update.
 314         * tui/tui-regs.c (tui_show_registers): Update.
 315         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 316         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 317         (NO_REGS_STRING): Remove defines.
 318
 319 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 320
 321         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 322         unnecessary thread walk if remote doesn't support the packet.
 323
 324 2019-08-19  Tom Tromey  <tromey@adacore.com>
 325
 326         * python/py-value.c (value_has_field): Fix indentation.
 327
 328 2019-08-19  Tom Tromey  <tromey@adacore.com>
 329
 330         * printcmd.c (do_one_display, info_display_command): Update.
 331         * block.h (contained_in): Return bool.  Add allow_nested
 332         parameter.
 333         * block.c (contained_in): Return bool.  Add allow_nested
 334         parameter.
 335
 336 2019-08-19  Tom Tromey  <tom@tromey.com>
 337
 338         * configure: Rebuild.
 339         * configure.ac: Disallow the combination of -static-libstdc++ and
 340         source highlight.
 341         * source-cache.c (get_language_name): Handle rust.
 342         (source_cache::get_source_lines): Ignore highlighting exceptions.
 343
 344 2019-08-16  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 347         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 348         (struct tui_source_window_base) <make_visible, refresh_window,
 349         resize>: Remove methods.
 350         <execution_info>: Remove field.
 351         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 352         (tui_show_source_line, tui_source_window_base)
 353         (~tui_source_window_base): Update.
 354         (tui_source_window_base::resize)
 355         (tui_source_window_base::make_visible)
 356         (tui_source_window_base::refresh_window): Remove.
 357         (tui_source_window_base::update_exec_info): Update.
 358         * tui/tui-source.c (tui_source_window::set_contents): Update.
 359         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 360
 361 2019-08-16  Tom Tromey  <tom@tromey.com>
 362
 363         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 364         deprecated_query_hook.
 365
 366 2019-08-16  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 369         (tui_update_source_windows_with_line): Update.
 370         * tui/tui-source.h (struct tui_source_window)
 371         <show_symtab_source>: Declare.
 372         (tui_show_symtab_source): Don't declare.
 373         * tui/tui-source.c (tui_show_symtab_source): Rename from
 374         tui_show_symtab_source.
 375
 376 2019-08-16  Tom Tromey  <tom@tromey.com>
 377
 378         * tui/tui-winsource.h (struct tui_source_window_base)
 379         <set_contents>: Declare.
 380         * tui/tui-winsource.c
 381         (tui_source_window_base::update_source_window_as_is): Update.
 382         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 383         Declare.
 384         (tui_set_source_content): Don't declare.
 385         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 386         tui_set_source_content.
 387         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 388         Declare.
 389         (tui_set_disassem_content): Don't declare.
 390         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 391         tui_set_disassem_content.
 392
 393 2019-08-16  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-winsource.h (struct tui_source_window_base)
 396         <update_breakpoint_info>: Declare.
 397         (tui_update_breakpoint_info): Don't declare.
 398         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 399         (tui_update_all_breakpoint_info): Update.
 400         (tui_source_window_base::update_breakpoint_info): Rename from
 401         tui_update_breakpoint_info.
 402         (tui_source_window_base::update_exec_info): Update.
 403
 404 2019-08-16  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-winsource.h (struct tui_source_window_base)
 407         <update_source_window>: Declare.
 408         (tui_update_source_window): Don't declare.
 409         * tui/tui-winsource.c
 410         (tui_source_window_base::update_source_window): Rename from
 411         tui_update_source_window.
 412         (tui_source_window_base::rerender): Update.
 413         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 414         * tui/tui-disasm.c (tui_show_disassem)
 415         (tui_show_disassem_and_update_source)
 416         (tui_disasm_window::maybe_update): Update.
 417
 418 2019-08-16  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-winsource.h (struct tui_source_window_base)
 421         <update_source_window_as_is>: Declare.
 422         (tui_update_source_window_as_is): Don't declare.
 423         * tui/tui-winsource.c (tui_update_source_window): Update
 424         (tui_source_window_base::update_source_window_as_is): Rename from
 425         tui_update_source_window_as_is.
 426         (tui_source_window_base::refill): Update.
 427         * tui/tui-source.c (tui_show_symtab_source): Update.
 428         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 429         Update.
 430
 431 2019-08-16  Tom Tromey  <tom@tromey.com>
 432
 433         * tui/tui-winsource.h (tui_update_source_window)
 434         (tui_update_source_window_as_is): Remove "noerror" parameter.
 435         * tui/tui-winsource.c (tui_update_source_window)
 436         (tui_update_source_window_as_is): Remove "noerror" parameter.
 437         (tui_update_source_windows_with_addr)
 438         (tui_update_source_windows_with_line)
 439         (tui_source_window_base::rerender)
 440         (tui_source_window_base::refill): Update.
 441         * tui/tui-source.h (tui_set_source_content)
 442         (tui_show_symtab_source): Remove "noerror" parameter.
 443         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 444         parameter.
 445         (tui_show_symtab_source): Likewise.
 446         (tui_source_window::maybe_update): Update.
 447         * tui/tui-disasm.c (tui_show_disassem)
 448         (tui_show_disassem_and_update_source)
 449         (tui_disasm_window::do_scroll_vertical)
 450         (tui_disasm_window::maybe_update): Update.
 451
 452 2019-08-16  Tom Tromey  <tom@tromey.com>
 453
 454         * tui/tui.c (tui_is_window_visible): Update.
 455         * tui/tui-wingeneral.c (tui_make_window)
 456         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 457         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 458         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 459         (tui_set_win_height_command, parse_scrolling_args): Update.
 460         * tui/tui-source.c (tui_source_window::style_changed): Update.
 461         * tui/tui-regs.c (tui_show_registers)
 462         (tui_data_window::first_data_item_displayed)
 463         (tui_data_window::delete_data_content_windows)
 464         (tui_check_register_values, tui_reg_command): Update.
 465         * tui/tui-disasm.c (tui_show_disassem): Update.
 466         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 467         method.
 468         <is_visible>: Remove field.
 469         * tui/tui-data.c (tui_next_win, tui_prev_win)
 470         (tui_delete_invisible_windows): Update.
 471
 472 2019-08-16  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-winsource.h (struct tui_source_window_base)
 475         <m_has_locator>: Remove.
 476         * tui/tui-layout.c (show_source_disasm_command, show_data)
 477         (show_source_or_disasm_and_command): Update.
 478
 479 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 480
 481         * NEWS (Other MI changes): New subsection.
 482         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 483         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 484         * arch-utils.c (default_get_pc_address_flags): New function.
 485         * arch-utils.h (default_get_pc_address_flags): New declaration.
 486         * gdbarch.sh: Add get_pc_address_flags.
 487         * gdbarch.c: Regenerate.
 488         * gdbarch.h: Likewise.
 489         * stack.c (print_pc): New function.
 490         (print_frame_info) (print_frame): Call print_pc.
 491
 492 2019-08-16  Tom de Vries  <tdevries@suse.de>
 493
 494         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 495         print_objfile_section_info.
 496
 497 2019-08-15  Tom Tromey  <tom@tromey.com>
 498
 499         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 500         calling update_cmdwin_start_line.
 501         * tui/tui-winsource.h (struct tui_source_window_base)
 502         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 503         <rerender>: Declare.
 504         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 505         Call rerender.
 506         (tui_source_window_base::set_new_height): Remove.
 507         (tui_source_window_base::rerender): Rename from
 508         do_make_visible_with_new_height.
 509         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 510         resize method.
 511         (tui_win_info::make_invisible_and_set_new_height)
 512         (tui_win_info::make_visible_with_new_height): Remove.
 513         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 514         Declare.
 515         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 516         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 517         do_make_visible_with_new_height>: Don't declare.
 518         <rerender>: Declare.
 519         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 520         set_new_height.
 521         (tui_data_window::do_make_visible_with_new_height): Remove.
 522         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 523         call tui_show_locator_content.
 524         (tui_gen_win_info::resize): Call rerender.
 525         (show_source_or_disasm_and_command): Don't call
 526         tui_show_locator_content.
 527         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 528         method.
 529         (struct tui_win_info) <rerender>: Declare.
 530         <set_new_height, make_invisible_and_set_new_height,
 531         make_visible_with_new_height>: Don't declare.
 532         * tui/tui-data.c (tui_win_list::rerender): New method.
 533         * tui/tui-command.h (struct tui_cmd_window)
 534         <do_make_visible_with_new_height>: Don't declare.
 535         * tui/tui-command.c
 536         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 537
 538 2019-08-15  Tom Tromey  <tromey@adacore.com>
 539
 540         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 541         * ada-lang.c (ada_enum_name): Likewise.
 542
 543 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 544
 545         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 546         leading underscore.
 547         (GdbOutputErrorFile): Likewise.
 548         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 549         accordingly.
 550         (execute_unwinders): Rename to have a leading underscore.
 551         (auto_load_packages): Likewise.
 552         (global scope): Adjust call to auto_load_packages accordingly.
 553         (GdbSetPythonDirectory): Likewise.
 554         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 555         instead of execute_unwinders.
 556
 557 2019-08-15  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 560         (show_data): Don't change window visibility.
 561         (tui_gen_win_info::resize): Remove special case for command
 562         window.  Use wresize, when available.
 563         (show_source_or_disasm_and_command): Don't change window
 564         visibility.
 565         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 566         <make_visible>: New method.
 567         * tui/tui-command.c (tui_cmd_window::resize): New method.
 568
 569 2019-08-15  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 572         (struct tui_source_windows): New.
 573         * tui/tui-winsource.c (tui_display_main): Update.
 574         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 575         (new_height_ok, parse_scrolling_args): Update.
 576         * tui/tui-layout.c (show_layout, show_data): Update.
 577         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 578         (tui_add_to_source_windows): Don't declare.
 579         * tui/tui-data.c (source_windows, tui_source_windows)
 580         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 581
 582 2019-08-15  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 585         Rename from reset.
 586         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 587         * tui/tui-layout.c (show_source_disasm_command, show_data):
 588         Update.
 589         (tui_gen_win_info::resize): Rename.
 590         (show_source_or_disasm_and_command): Update.
 591         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 592         reset.
 593
 594 2019-08-15  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 597         * tui/tui-interp.c (tui_interp::init): Don't call
 598         tui_initialize_static_data.
 599         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 600
 601 2019-08-15  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 604         examine tui_win_list.
 605
 606 2019-08-15  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 609         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 610         tui_clear_source_content.
 611         (tui_clear_source_content): Remove.
 612         (tui_source_window_base::do_erase_source_content): Hoist call to
 613         content.clear().
 614         * tui/tui-stack.c (tui_show_frame_info): Don't call
 615         tui_clear_source_content.
 616
 617 2019-08-15  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-winsource.h (struct tui_source_window_base)
 620         <do_erase_source_content>: New method.
 621         <erase_source_content>: New method.
 622         (tui_erase_source_content): Don't declare.
 623         * tui/tui-winsource.c (tui_clear_source_content): Update.
 624         (tui_source_window_base::do_erase_source_content): Rename from
 625         tui_erase_source_content.
 626         (tui_source_window_base::show_source_content): Update.
 627         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 628         * tui/tui-source.h (struct tui_source_window)
 629         <erase_source_content>: New method.
 630         * tui/tui-disasm.h (struct tui_disasm_window)
 631         <erase_source_content>: New method.
 632
 633 2019-08-15  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 636         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 637         constructor.
 638         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 639         * tui/tui-source.c (tui_set_source_content): Update.
 640         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 641
 642 2019-08-15  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 645         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 646         tui-source.c.
 647         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 648         Declare.
 649         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 650         method.
 651         (tui_source_window::maybe_update): Update.
 652
 653 2019-08-15  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 656         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 657         tui-disasm.c.
 658         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 659         Declare.
 660         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 661         method.
 662         (tui_disasm_window::maybe_update): Update.
 663
 664 2019-08-15  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.h (struct tui_source_window_base)
 667         <maybe_update>: Declare.
 668         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 669         method.
 670         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 671         Declare.
 672         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 673         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 674         Declare.
 675         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 676
 677 2019-08-15  Tom Tromey  <tom@tromey.com>
 678
 679         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 680
 681 2019-08-15  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui-wingeneral.c: Include tui-stack.h.
 684         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 685         (struct tui_locator_window): Move from tui-data.h.
 686         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 687         (tui_initialize_static_data): Move from tui-data.c.
 688         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 689         (struct tui_locator_window): Move to tui-stack.c.
 690         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 691         (tui_initialize_static_data): Move to tui-stack.c.
 692
 693 2019-08-15  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-layout.c (show_source_disasm_command)
 696         (show_source_or_disasm_and_command): Use make_visible method, not
 697         tui_make_window.
 698         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 699         Remove.
 700
 701 2019-08-15  Tom Tromey  <tom@tromey.com>
 702
 703         * tui/tui-wingeneral.h (tui_make_window): Update.
 704         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 705         parameter.
 706         (tui_gen_win_info::make_visible): Update.
 707         * tui/tui-regs.c (tui_data_window::display_registers_from):
 708         Update.
 709         * tui/tui-layout.c (show_source_disasm_command)
 710         (show_source_or_disasm_and_command): Update.
 711         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 712         (enum tui_box): Remove.
 713         (struct tui_win_info) <can_box>: New method.
 714         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 715         method.
 716
 717 2019-08-15  Tom de Vries  <tdevries@suse.de>
 718
 719         * linux-nat-trad.c: Include gdbarch.h.
 720
 721 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 722
 723         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 724         register sizes.
 725
 726 2019-08-14  Tom Tromey  <tromey@adacore.com>
 727
 728         * darwin-nat.c: Include gdbarch.h.
 729         * darwin-nat-info.c: Include gdbarch.h.
 730
 731 2019-08-13  Tom Tromey  <tom@tromey.com>
 732
 733         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 734         Remove.
 735         * tui/tui-data.c (tui_initialize_static_data): Update.
 736
 737 2019-08-13  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-winsource.h (struct tui_exec_info_window)
 740         <~tui_exec_info_window, maybe_allocate_content, get_content,
 741         m_content>: Remove.
 742         (struct tui_source_window_base) <set_exec_info_content,
 743         show_exec_info_content>: Don't declare.
 744         * tui/tui-winsource.c
 745         (tui_exec_info_window::maybe_allocate_content): Remove.
 746         (tui_source_window_base::update_exec_info): Rename from
 747         set_exec_info_content.
 748         (tui_source_window_base::show_exec_info_content)
 749         (tui_source_window_base::update_exec_info): Remove.
 750
 751 2019-08-13  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 754         declare.
 755         * tui/tui-winsource.c (tui_update_source_window_as_is)
 756         (tui_update_source_windows_with_addr, tui_erase_source_content):
 757         Update.
 758         (tui_clear_exec_info_content): Remove.
 759
 760 2019-08-13  Tom Tromey  <tom@tromey.com>
 761
 762         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 763         declare.
 764         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 765         call tui_erase_exec_info_content.
 766         (tui_clear_exec_info_content): Rename from
 767         tui_erase_exec_info_content.
 768         (tui_clear_exec_info_content): Delete.
 769
 770 2019-08-13  Tom Tromey  <tom@tromey.com>
 771
 772         * tui/tui-winsource.h (struct tui_source_window_base)
 773         <show_exec_info_content>: Declare.
 774         (tui_show_exec_info_content): Don't declare.
 775         * tui/tui-winsource.c
 776         (tui_source_window_base::show_exec_info_content): Rename from
 777         tui_show_exec_info_content.
 778         (tui_source_window_base::update_exec_info): Update.
 779
 780 2019-08-13  Tom Tromey  <tom@tromey.com>
 781
 782         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 783         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 784         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 785         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 786         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 787         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 788         ... here.
 789
 790 2019-08-13  Tom Tromey  <tom@tromey.com>
 791
 792         * tui/tui-winsource.h (struct tui_source_window_base)
 793         <update_exec_info>: Declare.
 794         (tui_update_exec_info): Don't declare.
 795         * tui/tui-winsource.c (tui_update_source_window_as_is)
 796         (tui_source_window_base::refresh_all)
 797         (tui_update_all_breakpoint_info): Update.
 798         (tui_source_window_base::update_exec_info): Rename from
 799         tui_update_exec_info.
 800         * tui/tui-stack.c (tui_show_frame_info): Update.
 801
 802 2019-08-13  Tom Tromey  <tom@tromey.com>
 803
 804         * tui/tui-winsource.h (struct tui_source_window_base)
 805         <set_exec_info_content>: Declare.
 806         (tui_set_exec_info_content): Don't declare.
 807         * tui/tui-winsource.c
 808         (tui_source_window_base::set_exec_info_content): Rename from
 809         tui_set_exec_info_content.
 810         (tui_update_exec_info): Update.
 811
 812 2019-08-13  Tom Tromey  <tom@tromey.com>
 813
 814         * tui/tui-winsource.h (struct tui_source_window_base)
 815         <show_source_content>: Declare.
 816         (tui_show_source_content): Don't declare.
 817         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 818         (tui_source_window_base::show_source_content): Rename from
 819         tui_show_source_content.
 820         (tui_source_window_base::refresh_all): Update.
 821         * tui/tui-layout.c (show_source_disasm_command)
 822         (show_source_or_disasm_and_command): Update.
 823
 824 2019-08-13  Tom Tromey  <tom@tromey.com>
 825
 826         * tui/tui-winsource.c (tui_erase_source_content)
 827         (tui_show_source_content, tui_source_window_base::refresh_all):
 828         Update.
 829         * tui/tui-wingeneral.h
 830         (tui_check_and_display_highlight_if_needed): Don't declare.
 831         * tui/tui-wingeneral.c
 832         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 833         check_and_display_highlight_if_needed.
 834         * tui/tui-win.c (tui_rehighlight_all)
 835         (tui_win_info::make_visible_with_new_height): Update.
 836         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 837         (tui_data_window::erase_data_content)
 838         (tui_data_window::display_all_data): Update.
 839         * tui/tui-data.h (struct tui_win_info)
 840         <check_and_display_highlight_if_needed>: Declare.
 841
 842 2019-08-13  Tom Tromey  <tom@tromey.com>
 843
 844         * tui/tui-win.c (tui_resize_all): Call
 845         tui_delete_invisible_windows.
 846         * tui/tui-layout.c (show_layout): Call
 847         tui_delete_invisible_windows.
 848         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 849         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 850
 851 2019-08-13  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 854         tui_add_win_to_layout.
 855
 856 2019-08-13  Tom Tromey  <tom@tromey.com>
 857
 858         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 859         * tui/tui-layout.c (tui_default_win_height): Now static.
 860
 861 2019-08-13  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 864         single switch.
 865         (show_source_disasm_command, show_source_or_disasm_and_command):
 866         Don't check current layout.
 867
 868 2019-08-13  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-wingeneral.c (make_all_visible): Remove.
 871         (tui_make_all_invisible): Simplify.
 872         * tui/tui-layout.c (tui_make_all_invisible): Move from
 873         tui-wingeneral.c; simplify.
 874         (show_layout): Hoist call to tui_make_all_invisible.
 875         (show_data): Don't call tui_make_all_invisible.
 876
 877 2019-08-13  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 880         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 881
 882 2019-08-13  Tom Tromey  <tom@tromey.com>
 883
 884         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 885         tui-data.c.
 886         (show_source_disasm_command, show_data)
 887         (show_source_or_disasm_and_command): Don't use
 888         tui_set_current_layout_to.
 889         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 890         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 891         tui-layout.c.
 892         (tui_set_current_layout_to): Remove.
 893
 894 2019-08-13  Tom Tromey  <tom@tromey.com>
 895
 896         * tui/tui-layout.c (tui_set_layout): Update.
 897         * tui/tui-data.h (struct tui_layout_def): Remove.
 898         (tui_layout_def): Don't declare.
 899         * tui/tui-data.c (layout_def): Remove.
 900         (tui_layout_def): Remove.
 901
 902 2019-08-13  Tom Tromey  <tom@tromey.com>
 903
 904         * tui/tui-winsource.h (struct tui_source_window_base)
 905         <clear_detail>: No longer "override".
 906         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 907         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 908         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 909         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 910         Remove.
 911         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 912
 913 2019-08-13  Tom Tromey  <tromey@adacore.com>
 914
 915         * tracepoint.c: Don't include readline.h or history.h.
 916
 917 2019-08-12  Tom Tromey  <tom@tromey.com>
 918
 919         * configure: Rebuild.
 920         * configure.ac: Check for readline 7.
 921         * NEWS: Mention readline 7 requirement.
 922         * README: Update.
 923
 924 2019-08-12  Tom Tromey  <tom@tromey.com>
 925
 926         * mingw-hdep.c (gdb_select): Remove readline hack.
 927
 928 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 929
 930         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 931         when the function fails.
 932
 933 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 934
 935         * s390-tdep.c (s390_type_align): New function.
 936         (s390_gdbarch_init): Set it as type_align gdbarch method.
 937
 938 2019-08-09  Tom de Vries  <tdevries@suse.de>
 939
 940         PR gdb/24591
 941         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 942         pc_low with relocation offset.
 943
 944 2019-08-07  Tom Tromey  <tromey@adacore.com>
 945
 946         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 947         (print_frame_args): Update.
 948         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 949         Update.
 950         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 951         * frame.h (struct frame_arg): Add initializers.
 952         <error>: Now a unique_xmalloc_ptr.
 953
 954 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 955
 956         * NEWS: Expand the Pointer Authentication entry.
 957         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 958         (aarch64_frame_unmask_lr): ... to this.
 959         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 960         Call aarch64_frame_unmask_lr.
 961         * frame.c (struct frame_info): Add "masked" variable.
 962         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 963         (fprint_frame): Check for masked pc.
 964         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 965         declarations.
 966         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 967         * stack.c (print_frame): Check for masked pc.
 968
 969 2019-08-06  Tom Tromey  <tom@tromey.com>
 970
 971         * stabsread.c (patch_block_stabs, read_one_struct_field)
 972         (read_enum_type): Use obstack_strndup.
 973         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 974         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 975         * dwarf2read.c (guess_full_die_structure_name)
 976         (anonymous_struct_prefix): Use obstack_strndup.
 977         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 978         * c-exp.y (yylex): Use obstack_strndup.
 979         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 980         (write_var_or_type): Use obstack_strndup.
 981
 982 2019-08-06  Tom Tromey  <tom@tromey.com>
 983
 984         * symfile.c (reread_symbols): Use obstack_strdup.
 985         * stabsread.c (read_type): Use obstack_strdup.
 986         * gdb_obstack.h (obstack_strdup): New overload.
 987         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 988         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 989         (dwarf2_canonicalize_name): Use obstack_strdup.
 990         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 991         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 992         Use obstack_strdup.
 993
 994 2019-08-06  Tom Tromey  <tom@tromey.com>
 995
 996         * gdb_obstack.h (obstack_strdup): Define.
 997         * gdb_obstack.c (obstack_strdup): Don't define.
 998
 999 2019-08-06  Tom Tromey  <tom@tromey.com>
1000
1001         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1002         obstack_strdup.
1003         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1004         obstack_strdup.
1005         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1006         * stabsread.c (common_block_start): Use obstack_strdup.
1007         * objfiles.c (set_objfile_main_name, objfile): Use
1008         obstack_strdup.
1009         * namespace.c (add_using_directive): Use obstack_strdup.
1010         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1011         * jit.c (finalize_symtab): Use obstack_strdup.
1012         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1013         (guess_partial_die_structure_name, partial_die_info::fixup)
1014         (dwarf2_name): Use obstack_strdup.
1015         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1016         obstack_strdup.
1017         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1018         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1019         obstack_strdup.
1020         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1021
1022 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1023
1024         * unittests/help-doc-selftests.c: New file.
1025         * Makefile.in: Add the new file.
1026
1027 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1028
1029         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1030         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1031         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1032         the trailing '.' is not output, and the first character is uppercased.
1033         (print_help_for_command): Update call to print_doc_line.
1034         (print_doc_of_command): Likewise.
1035         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1036         * cli/cli-option.c (append_indented_doc): Do not append newline.
1037         (build_help_option): Append newline after first appended_indented_doc
1038         only if a second call is done.
1039         (build_help): Append 2 new lines before each option, except the first
1040         one.
1041         * compile/compile.c (_initialize_compile): Add new lines after
1042         %OPTIONS%, when not at the end of the help.
1043         Change help doc or code
1044         producing the help doc to respect the invariants.
1045         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1046         Also removed the new line after 'Options:', as all other commands
1047         do not put an empty line between 'Options:' and the first option.
1048         * printcmd.c (_initialize_printcmd): Likewise.
1049         * stack.c (_initialize_stack): Likewise.
1050         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1051         incorrectly telling COMMAND is optional.
1052         * ada-lang.c (_initialize_ada_language): Change help doc or code
1053         producing the help doc to respect the invariants.
1054         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1055         * breakpoint.c (_initialize_breakpoint): Likewise.
1056         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1057         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1058         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1059         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1060         _initialize_cli_style): Likewise.
1061         * corelow.c (core_target_info): Likewise.
1062         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1063         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1064         * filesystem.c (_initialize_filesystem): Likewise.
1065         * frame.c (_initialize_frame): Likewise.
1066         * gnu-nat.c (add_task_commands): Likewise.
1067         * infcall.c (_initialize_infcall): Likewise.
1068         * infcmd.c (_initialize_infcmd): Likewise.
1069         * interps.c (_initialize_interpreter): Likewise.
1070         * language.c (_initialize_language): Likewise.
1071         * linux-fork.c (_initialize_linux_fork): Likewise.
1072         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1073         * maint.c (_initialize_maint_cmds): Likewise.
1074         * memattr.c (_initialize_mem): Likewise.
1075         * printcmd.c (_initialize_printcmd): Likewise.
1076         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1077         _RegEx): Likewise.
1078         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1079         * record-btrace.c (_initialize_record_btrace): Likewise.
1080         * record-full.c (_initialize_record_full): Likewise.
1081         * record.c (_initialize_record): Likewise.
1082         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1083         * regcache.c (_initialize_regcache): Likewise.
1084         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1085         _initialize_remote): Likewise.
1086         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1087         * serial.c (_initialize_serial): Likewise.
1088         * skip.c (_initialize_step_skip): Likewise.
1089         * source.c (_initialize_source): Likewise.
1090         * stack.c (_initialize_stack): Likewise.
1091         * symfile.c (_initialize_symfile): Likewise.
1092         * symtab.c (_initialize_symtab): Likewise.
1093         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1094         * top.c (init_main): Likewise.
1095         * tracefile-tfile.c (tfile_target_info): Likewise.
1096         * tracepoint.c (_initialize_tracepoint): Likewise.
1097         * tui/tui-win.c (_initialize_tui_win): Likewise.
1098         * utils.c (add_internal_problem_command): Likewise.
1099         * valprint.c (value_print_option_defs): Likewise.
1100
1101 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1102
1103         PR build/24886
1104         * configure.ac: Drop enable-libmcheck support.
1105         * configure, config.in: Rebuild.
1106         * libmcheck.m4: Remove.
1107         * acinclude.m4: Don't include it.
1108         * Makefile.in: Don't distribute it.
1109         * top.c (print_gdb_configuration): Don't mention it.
1110
1111 2019-08-06  Tom Tromey  <tom@tromey.com>
1112
1113         * utils.c (set_output_style): Sometimes pass stream to
1114         emit_style_escape.
1115         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1116         * record-btrace.c (btrace_insn_history): Update.
1117         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1118         method.
1119         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1120         Update initializers.
1121         <m_uiout>: New field.
1122         <m_di>: Move lower.
1123         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1124         Remove "uiout" parameter.
1125         (dump_insns): Update.
1126         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1127         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1128
1129 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1130
1131         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1132         (error_in_psymtab_expansion): Likewise.
1133         (lookup_symbol_via_quick_fns): Likewise.
1134         (basic_lookup_transparent_type_quick): Likewise.
1135         (basic_lookup_transparent_type_1): Likewise.
1136
1137 2019-08-06  Tom Tromey  <tromey@adacore.com>
1138
1139         * source.c (last_source_error): Now bool.
1140         (print_source_lines_base): Make "noprint" bool.  Only open
1141         source file when last_source_visited changes.
1142
1143 2019-08-06  Tom Tromey  <tromey@adacore.com>
1144
1145         * annotate.c (annotate_source_line): Use g_source_cache.
1146         * source-cache.c (source_cache::get_plain_source_lines): Change
1147         parameters.  Populate m_offset_cache.
1148         (source_cache::ensure): New method.
1149         (source_cache::get_line_charpos): New method.
1150         (extract_lines): Move lower.  Change parameters.
1151         (source_cache::get_source_lines): Move lower.
1152         * source-cache.h (class source_cache): Update comment.
1153         <get_line_charpos>: New method.
1154         <get_source_lines>: Update comment.
1155         <clear>: Clear m_offset_cache.
1156         <get_plain_source_lines>: Change parameters.
1157         <ensure>: New method
1158         <m_offset_cache>: New member.
1159         * source.c (forget_cached_source_info_for_objfile): Update.
1160         (info_source_command): Use g_source_cache.
1161         (find_source_lines, open_source_file_with_line_charpos): Remove.
1162         (print_source_lines_base, search_command_helper): Use g_source_cache.
1163         * source.h (open_source_file_with_line_charpos): Don't declare.
1164         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1165         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1166         Use g_source_cache.
1167
1168 2019-08-06  Tom Tromey  <tromey@adacore.com>
1169
1170         * source-cache.c (source_cache::get_plain_source_lines):
1171         Remove "first_line" and "last_line" parameters.
1172         (source_cache::get_source_lines): Cache plain text.
1173         * source-cache.h (class source_cache)
1174         <get_plain_source_lines>: Update.
1175
1176 2019-08-06  Tom Tromey  <tromey@adacore.com>
1177
1178         * source-cache.c (extract_lines): No longer a method.
1179         Changed type of parameter.  Include final newline.
1180         (selftests::extract_lines_test): New function.
1181         (_initialize_source_cache): Likewise.
1182         * source-cache.h (class source_cache)
1183         <extract_lines>: Don't declare.
1184
1185 2019-08-06  Tom Tromey  <tromey@adacore.com>
1186
1187         * breakpoint.c (init_breakpoint_sal): Update.
1188         (breakpoint): Update.
1189         * breakpoint.h (struct breakpoint) <filter>: Now a
1190         unique_xmalloc_ptr.
1191
1192 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1193
1194         * NEWS: Mention dictionary access on blocks.
1195         * python/py-block.c (blpy_getitem): New function.
1196         (block_object_as_mapping): New struct.
1197         (block_object_type): Use new struct for tp_as_mapping field.
1198
1199 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1200
1201         * objfiles.h (objfile): Add a comment describing partial symbols.
1202
1203 2019-08-05  Tom Tromey  <tromey@adacore.com>
1204
1205         * compile/compile.c (_initialize_compile): Use _(), not N_().
1206         * thread.c (_initialize_thread): Use _(), not N_().
1207         * stack.c (_initialize_stack): Use _(), not N_().
1208         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1209
1210 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1211
1212         * dwarf2read.c (struct dw2_symtab_iterator):
1213         <want_specific_block>: Remove.
1214         <block_index>: Change type to gdb::optional.
1215         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1216         change type of BLOCK_INDEX parameter to gdb::optional.
1217         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1218         (dw2_lookup_symbol): Don't pass argument for
1219         WANT_SPECIFIC_BLOCK.
1220         (dw2_expand_symtabs_for_function): Don't pass argument for
1221         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1222         (class dw2_debug_names_iterator)
1223         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1224         parameter, change BLOCK_INDEX type to gdb::optional.
1225         <m_want_specific_block>: Remove.
1226         <m_block_index>: Change type to gdb::optional.
1227         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1228         gdb::optional.  Re-write in function of gdb::optional.
1229         (dw2_debug_names_lookup_symbol): Don't pass argument for
1230         WANT_SPECIFIC_BLOCK.
1231         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1232         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1233         BLOCK_INDEX.
1234
1235 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1236
1237         * NEWS: Mention changes to "info sources" command.
1238
1239 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1240
1241         * symtab.c (filename_partial_match_opts): New struct type.
1242         (struct output_source_filename_data): New members
1243         regexp, c_regexp, partial_match.
1244         (output_source_filename): Use new members to decide to print file.
1245         (info_sources_option_defs): New variable.
1246         (make_info_sources_options_def_group, print_info_sources_header,
1247         info_sources_command_completer):
1248         New functions.
1249         (info_sources_command): Read new optional arguments.
1250         (_initialize_symtab): Update info sources help.
1251
1252 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1253
1254         * ada-lang.c (exception_support_info_v0): Renamed from...
1255         (default_exception_support_info): ... this.  Create new
1256         definition for v1.
1257         (ada_has_this_exception_support): Look up catch_handlers_sym.
1258         (ada_exception_support_info_sniffer): Try v0 after default.
1259
1260 2019-08-01  Tom Tromey  <tromey@adacore.com>
1261
1262         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1263         gdbarch.h.
1264
1265 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1266
1267         * s12z-tdep.c: Fix include path for s12z-opc.h.
1268
1269 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1270
1271         * NEWS: Require GNU make 3.82.
1272
1273 2019-07-16  Tom Tromey  <tom@tromey.com>
1274
1275         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1276         declare.
1277
1278 2019-07-30  Tom Tromey  <tromey@adacore.com>
1279
1280         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1281
1282 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1283
1284         * printcmd.c (print_address_symbolic): Print negative offsets.
1285         (build_address_symbolic): Force signed arithmetic when computing
1286         offset.
1287
1288 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1289
1290         PR/24474: Add a function to lookup static variables.
1291         * NEWS: Mention this new function.
1292         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1293         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1294         * python/python.c (python_GdbMethods): Add new function.
1295
1296 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1297
1298         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1299         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1300         (objfpy_lookup_static_symbol): New function.
1301         (objfile_object_methods): Add new functions.
1302
1303 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1304
1305         * NEWS: Mention 'set|show print frame-info'.  Mention new
1306         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1307         backtrace argument.  Mention that python frame filtering code
1308         is now consistent with what 'backtrace' command prints.
1309
1310 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1311
1312         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1313         comments.
1314         (print_frame_info_auto, print_frame_info_source_line,
1315         print_frame_info_location, print_frame_info_source_and_location,
1316         print_frame_info_location_and_address, print_frame_info_short_location):
1317         New declarations.
1318         (struct frame_print_options): New member print_frame_info.
1319         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1320         * stack.h (get_user_print_what_frame_info): New declaration.
1321         (frame_show_address): New declaration.
1322         * stack.c (print_frame_arguments_choices): New value 'presence'.
1323         (print_frame_info_auto, print_frame_info_source_line,
1324         print_frame_info_location, print_frame_info_source_and_location,
1325         print_frame_info_location_and_address, print_frame_info_short_location,
1326         print_frame_info_choices, print_frame_info_print_what): New definitions.
1327         (print_frame_args): Only print dots for args if print frame-arguments
1328         is 'presence'.
1329         (frame_print_option_defs): New element for "frame-info".
1330         (get_user_print_what_frame_info): New function.
1331         (frame_show_address): Make non static.  Move comment to stack.h.
1332         (print_frame_info_to_print_what): New function.
1333         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1334         to decide what to print.
1335         (backtrace_command_1): Handle the new print_frame_arguments_presence
1336         value.
1337         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1338         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1339         (py_print_frame): In non-mi mode, use LOCATION as default for
1340         print_what, similarly to frame information printed directly by
1341         backtrace command. Handle frame-info user option in non MI mode.
1342
1343 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1344
1345         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1346         Add case for debugging 32-bit target on 64-bit host.  Revise
1347         comment.
1348
1349 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1350
1351         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1352         instead of find_function_entry_range_from_pc.
1353
1354 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1355
1356         * stack.c (find_frame_funname): Remove code which preferred
1357         minsym over symtab sym in "certain pathological cases".
1358
1359         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1360         parameter.  Change type of "do_demangle" to bool.
1361         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1362         Pass suitable "prefer_sym_over_minsym" flag to
1363         build_address_symbolic().  Don't output "+" for negative offsets.
1364         * printcmd.c (print_address_symbolic): Update invocation of
1365         build_address_symbolic to include a "prefer_sym_over_minsym"
1366         flag.
1367         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1368         Restrict cases in which use of minimal symbol is preferred to that
1369         of a found symbol.  Update comments.
1370
1371         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1372         for entry pc when entry pc is out of range for that FDE.
1373
1374 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1375
1376         PR gdb/24839:
1377         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1378         type.
1379
1380 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1381
1382         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1383         this function's Python signature.
1384
1385
1386 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1387
1388         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1389         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1390         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1391         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1392         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1393
1394
1395 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1396
1397         * h8300-tdep.c (h8300_register_name_common): New.
1398         h8300_register_name): Use h8300_register_name_common.
1399         (h8300s_register_name): Likewise.
1400         (h8300sx_register_name): Likewise.
1401         (h8300h_register_nam): New.
1402         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1403
1404
1405 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1406
1407         * arm-tdep.c (arm_skip_cmse_entry): New function.
1408         (arm_is_sgstubs_section): New function.
1409         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1410
1411 2019-07-22  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1414         Don't self-assign.
1415
1416 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1417
1418         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1419         type_print.
1420
1421 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1422
1423         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1424         so that GDB doesn't match any msymbols when searching in the
1425         TYPES_DOMAIN.
1426         (print_symbol_info): Print using typedef_print or type_print based
1427         on the type of the symbol.  Add updated FIXME comment moved from...
1428         (_initialize_symtab): ... move and update FIXME comment to above.
1429
1430 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * NEWS: Mention adding -q option to "info types".
1433         * symtab.c (struct info_types_options): New struct.
1434         (info_types_options_defs): New variable.
1435         (make_info_types_options_def_group): New function.
1436         (info_types_command): Use gdb::option framework to parse options.
1437         (info_types_command_completer): New function.
1438         (_initialize_symtab): Extend the help text on "info types" and
1439         register command completer.
1440
1441 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1442
1443         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1444         (lookup_symbol_in_objfile): Change int to block_enum and add a
1445         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1446
1447 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1448
1449         * MAINTAINERS (Write After Approval): Add self.
1450
1451 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1454         instruction to the dummy code region.
1455
1456 2019-07-19  Tom Tromey  <tromey@adacore.com>
1457
1458         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1459         (ARGSUSED, PARAMS, __func__): Remove rules.
1460
1461 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1462
1463         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1464         * features/arm/arm-with-iwmmxt.c: Remove.
1465         * features/arm/arm-with-iwmmxt.xml: Remove.
1466         * features/arm/arm-with-m-fpa-layout.c: Remove.
1467         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1468         * features/arm/arm-with-m-vfp-d16.c: Remove.
1469         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1470         * features/arm/arm-with-m.c: Remove.
1471         * features/arm/arm-with-m.xml: Remove.
1472         * features/arm/arm-with-neon.c: Remove.
1473         * features/arm/arm-with-neon.xml: Remove.
1474         * features/arm/arm-with-vfpv2.c: Remove.
1475         * features/arm/arm-with-vfpv2.xml: Remove.
1476         * features/arm/arm-with-vfpv3.c: Remove.
1477         * features/arm/arm-with-vfpv3.xml: Remove.
1478
1479 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1480
1481         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1482
1483 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1484
1485         * arch/aarch32.c (aarch32_create_target_description): Create
1486         target descriptions using features.
1487         * arch/arm.c (arm_create_target_description)
1488         (arm_create_mprofile_target_description): Likewise.
1489         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1490
1491 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1492
1493         * Makefile.in: Add new files.
1494         * aarch32-tdep.c: New file.
1495         * aarch32-tdep.h: New file.
1496         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1497         Call aarch32_read_description.
1498         * arch/aarch32.c: New file.
1499         * arch/aarch32.h: New file.
1500         * arch/arm.c (arm_create_target_description)
1501         (arm_create_mprofile_target_description): New function.
1502         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1503         (arm_create_target_description)
1504         (arm_create_mprofile_target_description): New declaration.
1505         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1506         read_description functions.
1507         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1508         Likewise.
1509         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1510         * arm-tdep.c (tdesc_arm_list): New variable.
1511         (arm_register_g_packet_guesses): Call create description functions.
1512         (arm_read_description) (arm_read_mprofile_description): New
1513         function.
1514         * arm-tdep.h (arm_read_description)
1515         (arm_read_mprofile_description): Add declaration.
1516         * configure.tgt: Add new files.
1517
1518 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1519
1520         * top.c (new_ui_command): Open specified terminal just once.
1521
1522 2019-07-18  Tom Tromey  <tromey@adacore.com>
1523
1524         * symtab.c (main_name): Constify return type.
1525         * symfile.c (set_initial_language): Update.
1526         * symtab.h (main_name): Constify return type.
1527
1528 2019-07-17  Tom Tromey  <tom@tromey.com>
1529
1530         * tui/tui-winsource.c (tui_update_source_window)
1531         (tui_update_source_window_as_is)
1532         (tui_update_source_windows_with_line): Remove return.
1533         * tui/tui-disasm.c (tui_show_disassem)
1534         (tui_show_disassem_and_update_source): Remove return.
1535         * tui/tui.c (tui_reset): Remove return.
1536         * tui/tui-wingeneral.c
1537         (tui_check_and_display_highlight_if_needed): Remove return.
1538
1539 2019-07-17  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-winsource.h (struct tui_exec_info_window)
1546         (struct tui_source_window_base): Move from tui-data.h.
1547         * tui/tui-winsource.c: Move many method definitions from
1548         elsewhere.  Remove "structuring" comments.
1549         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1550         (tui_source_window_base::refresh_window): Move to
1551         tui-winsource.c.
1552         * tui/tui-win.c (tui_source_window_base::refresh_all)
1553         (tui_source_window_base::update_tab_width)
1554         (tui_source_window_base::set_new_height)
1555         (tui_source_window_base::do_make_visible_with_new_height): Move to
1556         tui-winsource.c.
1557         * tui/tui-source.h: Update.
1558         * tui/tui-source.c (tui_source_window_base::reset): Move to
1559         tui-winsource.c.
1560         * tui/tui-disasm.h: Update.
1561         * tui/tui-data.h (struct tui_exec_info_window): Move to
1562         tui-winsource.h.
1563         (struct tui_source_window_base): Likewise.
1564         * tui/tui-data.c (tui_source_window_base::clear_detail)
1565         (tui_source_window_base, ~tui_source_window_base): Move to
1566         tui-winsource.c.
1567
1568 2019-07-17  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-win.c (tui_resize_all)
1571         (tui_source_window_base::update_tab_width)
1572         (tui_adjust_win_heights): Update.
1573         (tui_win_info::make_invisible_and_set_new_height): Rename from
1574         make_invisible_and_set_new_height.
1575         * tui/tui-data.h (struct tui_win_info)
1576         <make_invisible_and_set_new_height>: New method.
1577
1578 2019-07-17  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui.c: Update.
1581         * tui/tui-source.h (struct tui_source_window): Move from
1582         tui-data.h.
1583         * tui/tui-layout.c: Update.
1584         * tui/tui-disasm.c: Update.
1585         * tui/tui-data.h (struct tui_source_window): Move to
1586         tui-source.h.
1587
1588 2019-07-17  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1591         tui-data.h.
1592         * tui/tui-data.h (struct tui_disasm_window): Move to
1593         tui-disasm.h.
1594
1595 2019-07-17  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-regs.h (struct tui_data_item_window): Move from
1598         tui-data.h.
1599         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1600         * tui/tui-data.h (struct tui_data_item_window): Move to
1601         tui-regs.h.
1602         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1603
1604 2019-07-17  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui.c: Update.
1607         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1608         (tui_cmd_window::max_height): Move to tui-command.c.
1609         * tui/tui-layout.c: Update.
1610         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1611         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1612         tui-command.c.
1613         * tui/tui-command.h (struct tui_cmd_window): Move from
1614         tui-data.h.
1615         * tui/tui-command.c: Remove "structuring" comments.
1616         (tui_cmd_window::clear_detail)
1617         (tui_cmd_window::do_make_visible_with_new_height)
1618         (tui_cmd_window::max_height): Move from elsewhere.
1619
1620 2019-07-17  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1623         Now static.
1624         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1625         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1626
1627 2019-07-17  Tom Tromey  <tom@tromey.com>
1628
1629         * tui/tui.c: Update.
1630         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1631         tui-regs.c.
1632         * tui/tui-windata.h: Remove file.
1633         * tui/tui-windata.c: Remove file.
1634         * tui/tui-win.c (tui_data_window::set_new_height)
1635         (tui_data_window::do_make_visible_with_new_height): Move to
1636         tui-regs.c.
1637         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1638         * tui/tui-regs.c: Remove "structuring" comments.
1639         (tui_data_window::first_data_item_displayed)
1640         (tui_data_window::delete_data_content_windows)
1641         (tui_data_window::erase_data_content)
1642         (tui_data_window::display_all_data)
1643         (tui_data_window::refresh_all)
1644         (tui_data_window::do_scroll_vertical)
1645         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1646         (tui_data_window::do_make_visible_with_new_height)
1647         (tui_data_window::refresh_window): Move from elsewhere.
1648         (_initialize_tui_regs): Move to end of file.
1649         * tui/tui-layout.c: Update.
1650         * tui/tui-hooks.c: Update.
1651         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1652         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1653         tui-regs.c.
1654         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1655
1656 2019-07-17  Tom Tromey  <tom@tromey.com>
1657
1658         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1659         seen.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-win.c (tui_source_window_base::set_new_height)
1664         (tui_source_window_base::do_make_visible_with_new_height): Use
1665         m_has_locator field directly.
1666         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1667         method.
1668         (struct tui_source_window_base) <has_locator>: Likewise.
1669
1670 2019-07-17  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1673         Don't declare.
1674         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1675         Remove.
1676         * tui/tui-win.c (tui_source_window_base::set_new_height)
1677         (tui_source_window_base::set_new_height)
1678         (make_invisible_and_set_new_height)
1679         (tui_source_window_base::do_make_visible_with_new_height)
1680         (tui_source_window_base::do_make_visible_with_new_height):
1681         Update.
1682         * tui/tui-layout.c (show_source_disasm_command, show_data)
1683         (show_source_or_disasm_and_command): Update.
1684         * tui/tui-layout.c (show_layout): Update.
1685
1686 2019-07-17  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-layout.c (make_data_window): Remove.
1689         (show_data): Unify creation and re-initialization cases.
1690
1691 2019-07-17  Tom Tromey  <tom@tromey.com>
1692
1693         * tui/tui-layout.c (make_source_window, make_disasm_window):
1694         Remove.
1695         (show_data): Unify creation and re-initialization cases.
1696
1697 2019-07-17  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui-layout.c (make_command_window): Remove.
1700         (show_source_disasm_command, show_source_or_disasm_and_command):
1701         Unify creation and re-initialization cases.
1702
1703 2019-07-17  Tom Tromey  <tom@tromey.com>
1704
1705         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1706         creation and re-initialization cases.
1707
1708 2019-07-17  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-regs.c (tui_get_register): Return void.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1715         Simplify.
1716
1717 2019-07-17  Tom Tromey  <tom@tromey.com>
1718
1719         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1720         resetting.
1721
1722 2019-07-17  Tom Tromey  <tom@tromey.com>
1723
1724         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1725         * tui/tui-regs.c (tui_reg_layout): New function.
1726         (tui_show_registers, tui_reg_command): Use it.
1727         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1728         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1729         parameters.
1730         (tui_layout_command): Remove.
1731
1732 2019-07-17  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-layout.h (tui/tui-layout): Return void.
1735         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1736
1737 2019-07-17  Tom Tromey  <tom@tromey.com>
1738
1739         * tui/tui-layout.c (show_source_disasm_command, show_data):
1740         Update.
1741         (reset_locator): Remove.
1742         (show_source_or_disasm_and_command): Update.
1743
1744 2019-07-17  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-source.c (tui_source_window_base::reset): Remove
1747         win_type parameter.
1748         * tui/tui-layout.c (make_command_window, make_source_window)
1749         (make_disasm_window, make_data_window)
1750         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1751         (reset_locator, show_source_or_disasm_and_command): Update.
1752         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1753         win_type parameter.
1754         (struct tui_source_window_base) <reset>: Likewise.
1755
1756 2019-07-17  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-layout.c (show_source_disasm_command): Use
1759         reset_locator.
1760         (reset_locator): New function.
1761         (init_and_make_win): Remove.
1762         (show_source_or_disasm_and_command): Use reset_locator.
1763
1764 2019-07-17  Tom Tromey  <tom@tromey.com>
1765
1766         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1767         condition.
1768         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1769         Remove condition.
1770         * tui/tui-source.c (tui_source_window_base::reset): New method.
1771         * tui/tui-layout.c (make_command_window): Don't call
1772         init_and_make_win.
1773         (make_source_window, make_disasm_window): Don't call
1774         make_source_or_disasm_window.
1775         (make_data_window): Don't call init_and_make_win.  Change calling
1776         convention.
1777         (show_source_disasm_command, show_data): Simplify.
1778         (make_source_or_disasm_window): Remove.
1779         (show_source_or_disasm_and_command): Simplify.
1780         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1781         (struct tui_source_window_base) <reset>: Likewise.
1782         <execution_info>: Remove initializer.
1783         * tui/tui-data.c (tui_source_window_base): Initialize
1784         execution_info.
1785
1786 2019-07-17  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1789         variable.
1790
1791 2019-07-17  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui.c (tui_rl_other_window): Update.
1794         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1795         superclass method first.  Always iterate over regs_content.
1796         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1797         method.
1798         * tui/tui-win.c (tui_set_focus_command): Update.
1799
1800 2019-07-17  Tom Tromey  <tom@tromey.com>
1801
1802         * tui/tui-win.c (tui_set_focus_command): Rename from
1803         tui_set_focus.  Call tui_enable.
1804         (tui_set_focus_command): Remove.
1805
1806 2019-07-17  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1809         refresh_window.
1810         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1811         touchwin.
1812         (tui_data_window::refresh_window): Call refresh_window on data
1813         items.  Always call superclass refresh_window.
1814         (tui_win_info::refresh): Remove.
1815         (tui_source_window_base::refresh_window): Update.
1816         (tui_refresh_all): Update.
1817         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1818         refresh_window.
1819         (show_source_or_disasm_and_command): Likewise.
1820         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1821         (struct tui_source_window_base) <refresh>: Likewise.
1822
1823 2019-07-17  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-winsource.c (tui_clear_source_content)
1826         (tui_show_source_content): Update.
1827         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1828         whether content is empty.
1829         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1830         Remove.
1831
1832 2019-07-17  Tom Tromey  <tom@tromey.com>
1833
1834         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1835         window's contents.
1836         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1837         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1838
1839 2019-07-17  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1842         (struct tui_data_item_window): Update.
1843
1844 2019-07-17  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1847         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1848         defines.
1849
1850 2019-07-17  Tom Tromey  <tom@tromey.com>
1851
1852         * tui/tui-winsource.h (tui_erase_source_content)
1853         (tui_clear_source_content): Remove "display_prompt" parameter.
1854         * tui/tui-winsource.c (tui_update_source_window_as_is)
1855         (tui_update_source_windows_with_addr): Update.
1856         (tui_clear_source_content): Remove "display_prompt" parameter.
1857         (tui_erase_source_content): Likewise.  Simplify.
1858         (tui_show_source_content): Update.
1859         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1860         * tui/tui-stack.c (tui_show_frame_info): Update.
1861         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1862         Remove defines.
1863
1864 2019-07-17  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1867         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1868         parameter.
1869         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1870         parameter.
1871
1872 2019-07-17  Tom Tromey  <tom@tromey.com>
1873
1874         * tui/tui-winsource.c (tui_clear_source_content)
1875         (tui_show_source_content, tui_show_exec_info_content)
1876         (tui_clear_exec_info_content): Update.
1877         * tui/tui-stack.c (tui_show_locator_content): Update.
1878         (tui_show_frame_info): Update.
1879         * tui/tui-source.h (tui_source_window): Don't declare.
1880         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1881         from tui_source_is_displayed.
1882         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1883         Remove field.
1884         (struct tui_source_window_base) <content_in_use>: New field.  Now
1885         bool.
1886         (struct tui_source_window) <showing_source_p>: New method.
1887         (TUI_SRC_WIN): Change cast.
1888         * tui/tui-data.c (tui_initialize_static_data): Update.
1889
1890 2019-07-17  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1893         location_matches_p.
1894         * tui/tui-source.c (tui_source_window::location_matches_p): New
1895         method.
1896         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1897         method.
1898         * tui/tui-data.h (struct tui_source_window_base)
1899         <location_matches_p>: New method.
1900         (struct tui_source_window, struct tui_disasm_window)
1901         <location_matches_p>: Likewise.
1902
1903 2019-07-17  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-win.c (tui_set_win_height_command): Rename from
1906         tui_set_win_height.
1907         (tui_set_win_height_command): Remove.
1908
1909 2019-07-17  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-source.c (tui_source_window): New constructor.  Add
1912         observer.
1913         (~tui_source_window): New destructor.
1914         (tui_source_window::style_changed): New method.
1915         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1916         (tui_attach_detach_observers): Update.
1917         * tui/tui-data.h (struct tui_source_window): Make constructor not
1918         inline.  Add destructor.
1919         (struct tui_source_window) <style_changed>: New method.
1920         <m_observable>: New member.
1921
1922 2019-07-17  Tom Tromey  <tom@tromey.com>
1923
1924         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1925         * tui/tui-win.c (tui_resize_all): Fix typo.
1926
1927 2019-07-17  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1930         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1931         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1932         * tui/tui-win.c (window_name_completer): Use foreach.
1933         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1934         (update_tab_width): Likewise.
1935         * tui/tui-layout.c (show_layout): Update.
1936         * tui/tui-data.h (class tui_window_iterator): New.
1937         (struct all_tui_windows): New.
1938         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1939
1940 2019-07-17  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1943         parameter.  Don't reference globals.
1944         (tui_reg_command): Update.
1945
1946 2019-07-17  Tom Tromey  <tom@tromey.com>
1947
1948         * tui/tui-regs.c (tui_show_registers): Simplify.
1949
1950 2019-07-17  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-regs.c (tui_show_registers): Update.
1953         (tui_show_register_group): Add win_info parameter.
1954
1955 2019-07-17  Tom Tromey  <tom@tromey.com>
1956
1957         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1958         Rename from tui_display_reg_element_at_line.
1959         (tui_data_window::display_registers_from_line): Update.
1960         * tui/tui-data.h (struct tui_data_window)
1961         <display_reg_element_at_line>: New method.
1962
1963 2019-07-17  Tom Tromey  <tom@tromey.com>
1964
1965         * tui/tui-regs.h (tui_display_registers_from)
1966         (tui_display_registers_from_line): Don't declare.
1967         * tui/tui-windata.c (tui_data_window::display_all_data)
1968         (tui_data_window::refresh_all)
1969         (tui_data_window::do_scroll_vertical): Update.
1970         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1971         from tui_display_registers_from.
1972         (tui_display_reg_element_at_line): Update.
1973         (tui_data_window::display_registers_from_line): Rename from
1974         tui_display_registers_from_line.
1975         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1976         display_registers_from_line>: New methods.
1977
1978 2019-07-17  Tom Tromey  <tom@tromey.com>
1979
1980         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1981         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1982         from tui_erase_data_content.
1983         (tui_data_window::display_all_data)
1984         (tui_data_window::refresh_all)
1985         (tui_data_window::do_scroll_vertical): Update.
1986         * tui/tui-regs.c (tui_show_registers): Update.
1987         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1988         New method.
1989
1990 2019-07-17  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1993         declare.
1994         * tui/tui-windata.c
1995         (tui_data_window::delete_data_content_windows): Rename from
1996         tui_delete_data_content_windows.
1997         (tui_data_window::display_all_data)
1998         (tui_data_window::do_scroll_vertical): Update.
1999         * tui/tui-data.h (struct tui_data_window)
2000         <delete_data_content_windows>: New method.
2001
2002 2019-07-17  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2005         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2006
2007 2019-07-17  Tom Tromey  <tom@tromey.com>
2008
2009         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2010         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2011         from tui_display_all_data.
2012         * tui/tui-win.c
2013         (tui_data_window::do_make_visible_with_new_height): Update.
2014         * tui/tui-regs.c (tui_show_registers): Update.
2015         * tui/tui-layout.c (tui_set_layout): Update.
2016         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2017         method.
2018
2019 2019-07-17  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2022         * tui/tui-windata.c (tui_display_data_from): Remove.
2023         (tui_data_window::refresh_all): Update.
2024
2025 2019-07-17  Tom Tromey  <tom@tromey.com>
2026
2027         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2028         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2029         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2030         tui_display_registers_from_line.
2031         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2032         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2033         "force_display" parameter.
2034
2035 2019-07-17  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2038         declare.
2039         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2040         Rename from tui_first_reg_element_no_inline.
2041         (tui_display_reg_element_at_line)
2042         (tui_display_registers_from_line): Update.
2043         * tui/tui-data.h (struct tui_data_window)
2044         <first_reg_element_no_inline>: New method.
2045
2046 2019-07-17  Tom Tromey  <tom@tromey.com>
2047
2048         * tui/tui-windata.c (tui_display_data_from)
2049         (tui_data_window::do_scroll_vertical): Update.
2050         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2051         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2052         Rename from tui_line_from_reg_element_no.
2053         (tui_display_registers_from_line): Update.
2054         * tui/tui-data.h (struct tui_data_window)
2055         <line_from_reg_element_no>: New method.
2056
2057 2019-07-17  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2060         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2061         tui_last_regs_line_no.
2062         (tui_display_reg_element_at_line)
2063         (tui_display_registers_from_line): Update.
2064         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2065         method.
2066
2067 2019-07-17  Tom Tromey  <tom@tromey.com>
2068
2069         PR tui/24722:
2070         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2071         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2072         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2073         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2074         (tui_update_breakpoint_info): Likewise.
2075         * tui/tui-hooks.c (tui_event_create_breakpoint)
2076         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2077         Update.
2078
2079 2019-07-17  Tom Tromey  <tom@tromey.com>
2080
2081         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2082
2083 2019-07-17  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-winsource.c (tui_update_source_window_as_is)
2086         (tui_update_source_windows_with_addr): Update.
2087         * tui/tui-source.h (tui_set_source_content)
2088         (tui_show_symtab_source): Add "win_info" parameter.
2089         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2090         parameter.
2091         (tui_show_symtab_source): Likewise.
2092
2093 2019-07-17  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-wingeneral.c
2096         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2097
2098 2019-07-17  Tom Tromey  <tom@tromey.com>
2099
2100         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2101         (struct tui_cmd_window) <can_scroll>: New method.
2102         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2103         method.
2104
2105 2019-07-17  Tom Tromey  <tromey@adacore.com>
2106
2107         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2108         do_field_signed>: Rename.  Change type of "value".
2109         * ui-out.c (ui_out::field_signed): Rename from field_int.
2110         Change type of "value".
2111         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2112         type of "value".
2113         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2114         do_field_int.  Change type of "value".
2115         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2116         do_field_int.  Change type of "value".
2117         * tracepoint.c (trace_status_mi, tfind_1)
2118         (print_one_static_tracepoint_marker): Update.
2119         * thread.c (print_thread_info_1, print_selected_thread_frame):
2120         Update.
2121         * stack.c (print_frame, print_frame_info): Update.
2122         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2123         Update.
2124         * source.c (print_source_lines_base): Update.
2125         * skip.c (info_skip_command): Update.
2126         * record-btrace.c (btrace_ui_out_decode_error)
2127         (btrace_call_history_src_line): Update.
2128         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2129         Update.
2130         * progspace.c (print_program_space): Update.
2131         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2132         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2133         do_field_int.  Change type of "value".
2134         * mi/mi-out.c (mi_ui_out::do_table_begin)
2135         (mi_ui_out::do_table_header): Update.
2136         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2137         type of "value".
2138         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2139         (mi_cmd_data_list_changed_registers, output_register)
2140         (mi_cmd_data_read_memory, mi_load_progress)
2141         (mi_cmd_trace_frame_collected): Update.
2142         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2143         Update.
2144         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2145         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2146         (mi_cmd_var_list_children, varobj_update_one): Update.
2147         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2148         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2149         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2150         * inferior.c (print_inferior): Update.
2151         * gdb_bfd.c (print_one_bfd): Update.
2152         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2153         Update.
2154         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2155         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2156         do_field_int.  Change type of "value".
2157         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2158         do_field_int.  Change type of "value".
2159         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2160         (print_one_breakpoint_location, print_it_catch_fork)
2161         (print_one_catch_fork, print_it_catch_vfork)
2162         (print_one_catch_vfork, print_it_catch_solib)
2163         (print_it_catch_exec, print_it_ranged_breakpoint)
2164         (print_mention_watchpoint, print_mention_masked_watchpoint)
2165         (bkpt_print_it, update_static_tracepoint): Update.
2166         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2167         * break-catch-syscall.c (print_it_catch_syscall): Update.
2168         * ada-tasks.c (print_ada_task_info): Update.
2169         * ada-lang.c (print_it_exception, print_mention_exception):
2170         Update.
2171
2172 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2173
2174         PR breakpoints/24541
2175         * gdbarch.c: Regenerate.
2176         * gdbarch.h: Regenerate.
2177         * gdbarch.sh: Adjust return type and parameter types for
2178         'stap_adjust_register'.
2179         (i386_stap_adjust_register): Adjust signature and return new
2180         register name.
2181         * stap-probe.c (stap_parse_register_operand): Adjust use of
2182         'gdbarch_stap_adjust_register'.
2183
2184 2019-07-17  Tom Tromey  <tromey@adacore.com>
2185
2186         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2187         declare VEC.
2188         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2189         std::vector.
2190         (struct s390_process_info): Add initializers.
2191         (s390_add_process): Use new.
2192         (s390_linux_nat_target::low_forget_process): Use delete.
2193         (s390_linux_nat_target::low_new_fork)
2194         (s390_linux_nat_target::stopped_by_watchpoint)
2195         (s390_linux_nat_target::low_prepare_to_resume)
2196         (s390_linux_nat_target::insert_watchpoint)
2197         (s390_linux_nat_target::insert_hw_breakpoint)
2198         (s390_linux_nat_target::remove_watchpoint)
2199         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2200
2201 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2202
2203         * aarch64-fbsd-nat.c: Include regcache.h.
2204         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2205         argument.
2206         (aarch64_fbsd_nat_target::fetch_registers)
2207         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2208         variable.
2209         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2210
2211 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2212
2213         * fbsd-nat.c: Include gdbarch.h.
2214
2215 2019-07-15  Tom Tromey  <tromey@adacore.com>
2216
2217         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2218
2219 2019-07-15  Tom Tromey  <tromey@adacore.com>
2220
2221         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2222         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2223         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2224         * cli-out.c (cli_ui_out::do_field_int): New method.
2225         * ui-out.c (ui_out::field_unsigned): New method.
2226         * symfile.c (generic_load): Use field_unsigned.
2227         (print_transfer_performance): Likewise.
2228         * record-btrace.c (ui_out_field_uint): Remove.
2229         (btrace_call_history_insn_range, btrace_call_history): Use
2230         field_unsigned.
2231         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2232         field_unsigned.
2233         * ui-out.h (class ui_out) <field_unsigned>: New method.
2234         <do_field_unsigned>: Likewise.
2235
2236 2019-07-15  Tom Tromey  <tromey@adacore.com>
2237
2238         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2239         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2240         * target.c (flash_erase_command): Use field_string.
2241         * infrun.c (print_signal_received_reason): Use field_string.
2242         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2243         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2244         field_string.
2245         * ada-tasks.c (print_ada_task_info): Use field_string.
2246
2247 2019-07-15  Tom Tromey  <tromey@adacore.com>
2248
2249         * target.c (flash_erase_command): Use field_core_addr.
2250         * symfile.c (generic_load): Use field_core_addr.
2251         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2252         Use field_core_addr.
2253         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2254         field_core_addr.
2255
2256 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2257
2258         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2259         value if its desired type is smaller than a CORE_ADDR and signed.
2260
2261 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2264         of changes to field names, and use new is_reference field to
2265         decide if a property is a reference or not.
2266         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2267         field.
2268         (struct dwarf2_property_baton): Update header comment, rename
2269         'referenced_type' to 'property_type' and update comments.
2270         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2271         default property type, store in property baton, update to take
2272         accound of renamed field.
2273         (read_func_scope): Update call to attr_to_dynamic_prop.
2274         (read_array_type): Likewise.
2275         (dwarf2_per_cu_addr_sized_int_type): New function.
2276         (read_subrange_index_type): Move type finding code to
2277         dwarf2_per_cu_addr_sized_int_type.
2278         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2279         (dwarf2_per_cu_addr_type): New function.
2280         (set_die_type): Update calls to attr_to_dynamic_prop.
2281
2282 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * dwarf2read.c (read_subrange_index_type): New function.
2285         (read_subrange_type): Move code into new function and call it.
2286         * gdbtypes.c (create_range_type): Add some asserts.
2287
2288 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2291         update return statements.
2292         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2293         declaration, and update comment to match.
2294         * gdbtypes.c (resolve_dynamic_array): Update call to
2295         dwarf2_evaluate_property to match new return type.
2296
2297 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2298
2299         * valarith.c (value_subscripted_rvalue): Change lowerbound
2300         parameter type from int to LONGEST.
2301         * value.h (value_subscripted_rvalue): Likewise in declaration.
2302
2303 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2304
2305         * cli/cli-utils.c (info_print_command_completer): New function.
2306         * cli/cli-utils.h: Add 'completer.h' include, and forward
2307         declaration for 'struct cmd_list_element'.
2308         (info_print_command_completer): Declare.
2309         * stack.c (_initialize_stack): Add completer for 'info locals' and
2310         'info args'.
2311         * symtab.c (_initialize_symtab): Add completer for 'info
2312         variables' and 'info functions'.
2313         * NEWS: Mention completion for additional info commands.
2314
2315 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * cli/cli-utils.c (extract_info_print_args): Delete.
2318         (extract_arg_maybe_quoted): Delete.
2319         (info_print_options_defs): New variable.
2320         (make_info_print_options_def_group): New function.
2321         (extract_info_print_options): Define new function.
2322         * cli/cli-utils.h (extract_info_print_args): Delete.
2323         (struct info_print_options): New structure.
2324         (extract_info_print_options): Declare new function.
2325         * stack.c (info_locals_command): Update to use new
2326         extract_info_print_options, also add a header comment.
2327         (info_args_command): Likewise.
2328         * symtab.c (info_variables_command): Likewise.
2329         (info_functions_command): Likewise.
2330
2331 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2332
2333         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2334         to extract string arguments.
2335         * common/common-utils.c (extract_string_maybe_quoted): New function.
2336         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2337
2338 2019-07-11  Tom Tromey  <tromey@adacore.com>
2339
2340         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2341         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2342         * top.h (gdbinit): Don't declare.
2343         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2344         into...
2345         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2346         * top.c (gdb_init): Don't call init_cli_cmds.
2347         (gdbinit): Remove.
2348         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2349
2350 2019-07-11  Tom Tromey  <tromey@adacore.com>
2351
2352         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2353         after it has been moved.
2354
2355 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2356
2357         * valops.c (value_must_coerce_to_target): Change return type to
2358         bool.
2359         * value.h (value_must_coerce_to_target): Likewise.
2360
2361 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2362
2363         * breakpoint.c (is_hardware_watchpoint): Remove
2364         forward-declaration.
2365         (is_masked_watchpoint): Change return type to bool.
2366         (is_tracepoint): Likewise.
2367         (is_breakpoint): Likewise.
2368         (is_hardware_watchpoint): Likewise.
2369         (is_watchpoint): Likewise.
2370         (is_no_memory_software_watchpoint): Likewise.
2371         (is_catchpoint): Likewise.
2372         (breakpoint_1): Make FILTER parameter's return type bool.
2373         is_masked_watchpoint): Change return type to bool.
2374         (save_breakpoints): Make FILTER parameter's return type bool.
2375         * breakpoint.h (is_breakpoint): Change return type to bool.
2376         (is_watchpoint): Likewise.
2377         (is_catchpoint): Likewise.
2378         (is_tracepoint): Likewise.
2379
2380 2019-07-10  Tom Tromey  <tom@tromey.com>
2381
2382         * defs.h: Don't include gdbarch.h.
2383         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2384         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2385         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2386         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2387         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2388         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2389         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2390         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2391         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2392         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2393         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2394         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2395         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2396         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2397         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2398         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2399         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2400         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2401         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2402         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2403         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2404         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2405         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2406         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2407         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2408         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2409         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2410
2411 2019-07-10  Tom Tromey  <tromey@adacore.com>
2412
2413         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2414         * breakpoint.c (init_ada_exception_breakpoint): Register as
2415         bp_catchpoint.
2416         (print_one_breakpoint_location, print_one_breakpoint): Use
2417         is_ada_exception_catchpoint.
2418         * ada-lang.c (class ada_catchpoint_location): Pass
2419         bp_loc_software_breakpoint to bp_location constructor.
2420         (is_ada_exception_catchpoint): New function.
2421
2422 2019-07-10  Tom Tromey  <tromey@adacore.com>
2423
2424         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2425         VEC.
2426         (struct arm_exidx_entry): New method operator<.
2427         (struct arm_exidx_data) <section_maps>: Change type.
2428         (arm_exidx_data_free): Remove.
2429         (arm_exidx_data_key): Change type.  Move lower.
2430         (arm_exidx_new_objfile): Update.
2431         (arm_compare_exidx_entries): Remove.
2432         (arm_find_exidx_entry, _initialize_arm_tdep)
2433
2434 2019-07-10  Tom Tromey  <tromey@adacore.com>
2435
2436         * solib-spu.c (ocl_program_data_key): Change type.
2437         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2438         Update.
2439
2440 2019-07-10  Tom Tromey  <tromey@adacore.com>
2441
2442         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2443         (struct solib_aix_inferior_data) <library_list>: Change type.
2444         (solib_aix_inferior_data_handle): Change type.
2445         (get_solib_aix_inferior_data): Update.
2446         (solib_aix_free_library_list): Remove.
2447         (library_list_start_library): Update.
2448         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2449         return type.
2450         (solib_aix_get_library_list)
2451         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2452         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2453
2454 2019-07-10  Tom Tromey  <tromey@adacore.com>
2455
2456         * solib-dsbt.c (struct dsbt_info): Add initializers.
2457         (solib_dsbt_pspace_data): Change type.
2458         (dsbt_pspace_data_cleanup): Remove.
2459         (get_dsbt_info, _initialize_dsbt_solib): Update.
2460
2461 2019-07-10  Tom Tromey  <tromey@adacore.com>
2462
2463         * spu-tdep.c (spu_overlay_data): Change type.
2464         (spu_get_overlay_table, spu_overlay_new_objfile)
2465         (_initialize_spu_tdep): Update.
2466
2467 2019-07-10  Tom Tromey  <tromey@adacore.com>
2468
2469         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2470         destructor.
2471         (dbx_objfile_data_key): Change type and declare later.
2472         (DBX_SYMFILE_INFO): Rewrite.
2473         * dbxread.c (dbx_objfile_data_key): Change type.
2474         (dbx_symfile_init): Update.
2475         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2476         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2477         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2478
2479 2019-07-10  Tom Tromey  <tromey@adacore.com>
2480
2481         * jit.c (jit_program_space_key): Change type.  Move lower.
2482         (get_jit_program_space_data): Update.
2483         (jit_program_space_data_cleanup): Remove.
2484         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2485         Update.
2486         (struct jit_program_space_data): Add initializers.
2487
2488 2019-07-10  Tom Tromey  <tromey@adacore.com>
2489
2490         * solib-darwin.c (struct darwin_info): Add initializers.
2491         (solib_darwin_pspace_data): Change type.
2492         (darwin_pspace_data_cleanup): Remove.
2493         (get_darwin_info, _initialize_darwin_solib): Update.
2494
2495 2019-07-10  Tom Tromey  <tromey@adacore.com>
2496
2497         * remote-sim.c (struct sim_inferior_data): Add initializers,
2498         constructor, and destructor.
2499         (sim_inferior_data_key): Change type.  Move lower.
2500         (check_for_duplicate_sim_descriptor): Update.
2501         (get_sim_inferior_data): Use new.  Update.
2502         (~sim_inferior_data_cleanup): Rename from
2503         sim_inferior_data_cleanup.  Simplify.
2504         (gdbsim_close_inferior, simulator_command)
2505         (sim_command_completer, _initialize_remote_sim): Update.
2506         (next_pid, INITIAL_PID): Move earlier.
2507
2508 2019-07-10  Tom Tromey  <tromey@adacore.com>
2509
2510         * python/python-internal.h (create_thread_object): Return
2511         gdbpy_ref.
2512         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2513         * python/py-inferior.c (struct threadlist_entry): Add
2514         constructor.
2515         <thread_obj>: Now a gdbpy_ref.
2516         (thread_to_thread_object): Update.
2517         (add_thread_object): Use new.
2518         (delete_thread_object): Use delete.
2519         (infpy_threads): Update.
2520         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2521         GIL.
2522
2523 2019-07-10  Tom Tromey  <tromey@adacore.com>
2524
2525         * valops.c (value_cast): Specialize error message for Ada.
2526
2527 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2528
2529         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2530
2531 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2532
2533         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2534         bpstat_should_step): Return bool, adjust comments.
2535         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2536         bpstat_should_step): Likewise.
2537
2538 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2539
2540         * features/Makefile: Use feature target descriptions for Arm.
2541         * features/arm/arm-core.c: Generate new file.
2542         * features/arm/arm-fpa.c: Likewise.
2543         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2544         * features/arm/arm-m-profile.c: Likewise.
2545         * features/arm/arm-vfpv2.c: Likewise.
2546         * features/arm/arm-vfpv3.c: Likewise.
2547         * features/arm/xscale-iwmmxt.c: Likewise.
2548         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2549
2550 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2551
2552         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2553         ptrace earlier.
2554
2555 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2556
2557         * features/aarch64-pauth.c: Regenerate.
2558
2559 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2560
2561         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2562         bool.
2563         (bpstat_what): Use false instead of 0.
2564
2565 2019-07-09  Pedro Alves  <palves@redhat.com>
2566
2567         * break-catch-throw.c (is_exception_catchpoint): New.
2568         * breakpoint.c (print_one_breakpoint_location): New parameter
2569         'raw_loc'.  Handle it.  Use
2570         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2571         looking at the breakpoint's type.
2572         (print_one_breakpoint): If handling "maint info breakpoints", also
2573         print locations of exception catchpoints.
2574         * breakpoint.h (is_exception_catchpoint): Declare.
2575
2576 2019-07-09  Pedro Alves  <palves@redhat.com>
2577
2578         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2579         "addr" field.
2580         (allocate_location_exception_catchpoint): New.
2581         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2582         (initialize_throw_catchpoint_ops): Install
2583         allocate_location_exception_catchpoint as allocate_location
2584         method.
2585         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2586         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2587         bp_loc_other.
2588         (breakpoint_address_is_meaningful): Delete.
2589         (bl_address_is_meaningful): New.
2590         (breakpoint_locations_match): Adjust comment.
2591         (bp_location_from_bp_type): New, factored out of...
2592         (bp_location::bp_location(breakpoint *)): ... this.
2593         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2594         factored out of...
2595         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2596         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2597         breakpoint_address_is_meaningful.
2598         (bp_locations_compare): Adjust comment.
2599         (update_global_location_list): Use bl_address_is_meaningful
2600         instead of breakpoint_address_is_meaningful.
2601         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2602         explicit.
2603         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2604         * python/py-breakpoint.c (bppy_get_location): No longer check
2605         whether location is null.
2606
2607 2019-07-09  Pedro Alves  <palves@redhat.com>
2608
2609         PR c++/15468
2610         * breakpoint.c (print_one_breakpoint_location): Remove
2611         single-location assert.
2612
2613 2019-07-09  Tom Tromey  <tom@tromey.com>
2614
2615         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2616         * configure: Rebuild.
2617         * configure.ac: Change common to gdbsupport.
2618         * gdbsupport: Rename from common.
2619         * acinclude.m4: Change common to gdbsupport.
2620         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2621         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2622         gdbsupport.
2623         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2624         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2625         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2626         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2627         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2628         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2629         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2630         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2631         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2632         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2633         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2634         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2635         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2636         coff-pe-read.c, command.h, compile/compile-c-support.c,
2637         compile/compile-c.h, compile/compile-cplus-symbols.c,
2638         compile/compile-cplus-types.c, compile/compile-cplus.h,
2639         compile/compile-loc2c.c, compile/compile.c, completer.c,
2640         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2641         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2642         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2643         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2644         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2645         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2646         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2647         features/aarch64-core.c, features/aarch64-fpu.c,
2648         features/aarch64-pauth.c, features/aarch64-sve.c,
2649         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2650         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2651         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2652         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2653         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2654         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2655         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2656         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2657         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2658         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2659         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2660         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2661         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2662         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2663         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2664         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2665         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2666         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2667         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2668         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2669         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2670         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2671         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2672         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2673         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2674         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2675         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2676         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2677         minsyms.c, mips-linux-tdep.c, namespace.h,
2678         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2679         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2680         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2681         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2682         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2683         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2684         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2685         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2686         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2687         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2688         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2689         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2690         procfs.c, producer.c, progspace.h, psymtab.h,
2691         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2692         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2693         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2694         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2695         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2696         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2697         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2698         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2699         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2700         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2701         target-memory.c, target.c, target.h, target/waitstatus.c,
2702         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2703         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2704         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2705         unittests/array-view-selftests.c,
2706         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2707         unittests/common-utils-selftests.c,
2708         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2709         unittests/format_pieces-selftests.c,
2710         unittests/function-view-selftests.c,
2711         unittests/lookup_name_info-selftests.c,
2712         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2713         unittests/mkdir-recursive-selftests.c,
2714         unittests/observable-selftests.c,
2715         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2716         unittests/parse-connection-spec-selftests.c,
2717         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2718         unittests/scoped_fd-selftests.c,
2719         unittests/scoped_mmap-selftests.c,
2720         unittests/scoped_restore-selftests.c,
2721         unittests/string_view-selftests.c, unittests/style-selftests.c,
2722         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2723         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2724         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2725         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2726         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2727         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2728
2729 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2730
2731         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2732         bool value.
2733         (decode_digits_ordinary): Set explicit_line field in sal.
2734         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2735         symtab_and_line that was set on an explicit line number in
2736         assembler code.  Do always update the recorded symtab and line if
2737         we do skip the prologue.
2738
2739 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2740
2741         * breakpoint.c (set_breakpoint_location_function): Remove
2742         explicit_loc parameter.
2743         (momentary_breakpoint_from_master): Update call to
2744         set_breakpoint_location_function.
2745         (add_location_to_breakpoint): Likewise.
2746
2747 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2748
2749         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2750         required features based on default bfd type when no specific bfd
2751         is present.
2752
2753 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2754
2755         * NEWS: Mention that GDB printf and eval commands can now print
2756         C-style and Ada-style convenience var strings without
2757         calling the inferior.
2758         * printcmd.c (printf_c_string): Locally print GDB internal var
2759         instead of transiting via the inferior.
2760         (printf_wide_c_string): Likewise.
2761
2762 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2763
2764         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2765
2766 2019-07-04  Tom Tromey  <tom@tromey.com>
2767
2768         PR tui/24724:
2769         * tui/tui-winsource.c (tui_clear_source_content): Update.
2770         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2771         (tui_update_breakpoint_info): Update.
2772         (tui_set_exec_info_content): Update.
2773         * tui/tui-source.c (tui_set_source_content_nil): Update.
2774         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2775         has_break.
2776         * tui/tui-data.h (enum tui_bp_flag): New.
2777         (tui_bp_flags): New enum flags type.
2778         (struct tui_source_element) <break_mode>: Change type.  Rename
2779         from has_break.
2780         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2781         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2782         constants.
2783         * tui/tui-winsource.h: Fix comment.
2784
2785 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2786
2787         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2788         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2789         (store_fpregs_to_thread)
2790         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2791         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2792         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2793         (IWMMXT_REGS_SIZE): Add define.
2794         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2795         (fetch_vfp_regs, store_vfp_regs)
2796         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2797         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2798
2799 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2800
2801         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2802         defines.
2803         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2804         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2805         (ARM_INT_REGISTER_SIZE): ...to this.
2806         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2807         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2808         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2809         (arm_linux_collect_gregset, supply_nwfpe_register)
2810         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2811         defines.
2812         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2813         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2814         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2815         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2816         (arm_return_in_memory, arm_store_return_value)
2817         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2818         (arm_record_ld_st_multiple): Likewise.
2819         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2820         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2821
2822 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2823
2824         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2825         AARCH64_DISPLACED_MODIFIED_INSNS.
2826         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2827         (aarch64_displaced_step_copy_insn): Likewise.
2828         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2829         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2830         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2831         ARM_DISPLACED_MODIFIED_INSNS.
2832         * arm-tdep.c (arm_gdbarch_init): Likewise.
2833         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2834         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2835         (struct arm_displaced_step_closure): Use
2836         ARM_DISPLACED_MODIFIED_INSNS.
2837
2838 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2839
2840         * features/Makefile: Remove unused xml files.
2841         * features/aarch64.xml: Remove.
2842         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2843         * features/i386/amd64-avx-avx512.xml: Remove.
2844         * features/i386/amd64-avx-linux.xml: Remove.
2845         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2846         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2847         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2848         * features/i386/amd64-avx-mpx.xml: Remove.
2849         * features/i386/amd64-avx.xml: Remove.
2850         * features/i386/amd64-linux.xml: Remove.
2851         * features/i386/amd64-mpx-linux.xml: Remove.
2852         * features/i386/amd64-mpx.xml: Remove.
2853         * features/i386/amd64.xml: Remove.
2854         * features/i386/i386-avx-avx512-linux.xml: Remove.
2855         * features/i386/i386-avx-avx512.xml: Remove.
2856         * features/i386/i386-avx-linux.xml: Remove.
2857         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2858         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2859         * features/i386/i386-avx-mpx-linux.xml: Remove.
2860         * features/i386/i386-avx-mpx.xml: Remove.
2861         * features/i386/i386-avx.xml: Remove.
2862         * features/i386/i386-linux.xml: Remove.
2863         * features/i386/i386-mmx-linux.xml: Remove.
2864         * features/i386/i386-mmx.xml: Remove.
2865         * features/i386/i386-mpx-linux.xml: Remove.
2866         * features/i386/i386-mpx.xml: Remove.
2867         * features/i386/i386.xml: Remove.
2868         * features/i386/x32-avx-avx512-linux.xml: Remove.
2869         * features/i386/x32-avx-linux.xml: Remove.
2870         * features/i386/x32-linux.xml: Remove.
2871
2872 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2873
2874         * regformats/aarch64.dat: Remove.
2875         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2876         * regformats/i386/amd64-avx-linux.dat: Remove.
2877         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2878         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2879         * regformats/i386/amd64-linux.dat: Remove.
2880         * regformats/i386/amd64-mpx-linux.dat: Remove.
2881         * regformats/i386/amd64.dat: Remove.
2882         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2883         * regformats/i386/i386-avx-linux.dat: Remove.
2884         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2885         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2886         * regformats/i386/i386-linux.dat: Remove.
2887         * regformats/i386/i386-mmx-linux.dat: Remove.
2888         * regformats/i386/i386-mpx-linux.dat: Remove.
2889         * regformats/i386/i386.dat: Remove.
2890         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2891         * regformats/i386/x32-avx-linux.dat: Remove.
2892         * regformats/i386/x32-linux.dat: Remove.
2893
2894 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2895
2896         * aarch64-tdep.c: Remove xml self tests.
2897         * amd64-linux-tdep.c: Likewise.
2898         * amd64-tdep.c: Likewise.
2899         * i386-linux-tdep.c: Likewise.
2900         * i386-tdep.c: Likewise.
2901
2902 2019-07-03  Pedro Alves  <palves@redhat.com>
2903
2904         PR cli/24732
2905         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2906         (pipe_cmd_option_defs): New.
2907         (make_pipe_cmd_options_def_group): New.
2908         (pipe_command): Use gdb::option::process_options.
2909         (pipe_command_completer): New function.
2910         (_initialize_cli_cmds): Install completer for "pipe" command.
2911
2912 2019-07-03  Pedro Alves  <palves@redhat.com>
2913
2914         * cli/cli-option.c (union option_value) <string>: New field.
2915         (struct option_def_and_value): Add ctor, move ctor, dtor and
2916         use DISABLE_COPY_AND_ASSIGN.
2917         (option_def_and_value::clear_value): New.
2918         (parse_option, save_option_value_in_ctx, get_val_type_str)
2919         (add_setshow_cmds_for_options): Handle var_string.
2920         * cli-option.h (union option_def::var_address) <string>: New
2921         field.
2922         (struct string_option_def): New.
2923         * maint-test-options.c (struct test_options_opts): Add default
2924         ctor and use DISABLE_COPY_AND_ASSIGN.
2925         <string_opt>: New field.
2926         (test_options_opts::~test_options_opts): New.
2927         (test_options_opts::dump): Also dump "-string".
2928         (test_options_option_defs): Install "string.
2929
2930 2019-07-03  Pedro Alves  <palves@redhat.com>
2931
2932         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2933         option_value with a null enumeration.
2934         (complete_options): Save the option values in the context.
2935         (save_option_value_in_ctx): New, factored out from ...
2936         (process_options): ... here.
2937         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2938         of the function.
2939         * maint-test-options.c (test_options_opts::dump): New, factored
2940         out from ...
2941         (maintenance_test_options_command_mode): ... here.
2942         (maintenance_test_options_command_completion_result): Delete.
2943         (maintenance_test_options_command_completion_text): Update
2944         comment.
2945         (maintenance_show_test_options_completion_result): Change
2946         prototype.  Just print
2947         maintenance_test_options_command_completion_text.
2948         (save_completion_result): New.
2949         (maintenance_test_options_completer_mode): Pass options context to
2950         complete_options, and then save a dump.
2951         (_initialize_maint_test_options): Use add_cmd to install "maint
2952         show test-options-completion-result".
2953
2954 2019-07-03  Pedro Alves  <palves@redhat.com>
2955
2956         * NEWS (New commands): Mention "with" and "maint with".
2957         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2958         (with_command, with_command_completer): New.
2959         (pipe_command): Adjust to new repeat_previous
2960         interface.
2961         (_initialize_cli_cmds): Install the "with" command and its "w"
2962         alias.
2963         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2964         declarations.
2965         * cli/cli-setshow.c (parse_cli_var_uinteger)
2966         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2967         argument strings for all var_types.
2968         (get_setshow_command_value_string): New, factored out from ...
2969         (do_show_command): ... this.
2970         * cli/cli-setshow.h: Include <string>.
2971         (get_setshow_command_value_string): Declare.
2972         * command.h (repeat_previous): Now returns const char *.  Adjust
2973         comment.
2974         * maint.c: Include "cli/cli-cmds.h".
2975         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2976         (_initialize_maint_cmds): Register the "maintenance with" command.
2977         * top.c (repeat_previous): Move bits from pipe_command here:
2978         Return the saved command line, if any; error out if there's no
2979         command to relaunch.
2980
2981 2019-07-03  Pedro Alves  <palves@redhat.com>
2982
2983         * NEWS (New commands): Mention "maint set/show test-settings"
2984         instead of "maint test-settings".
2985         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2986         (maintenance_test_settings_set_list): Rename to ...
2987         (maintenance_set_test_settings_list): ... this.
2988         (maintenance_test_settings_show_list): Rename to  ...
2989         (maintenance_show_test_settings_list): ... this.
2990         (maintenance_test_settings_cmd): Delete.
2991         (maintenance_test_settings_set_cmd): ...
2992         (maintenance_set_test_settings_cmd): ... this.
2993         (maintenance_test_settings_show_cmd): ...
2994         (maintenance_show_test_settings_cmd): ... this.
2995         (maintenance_test_settings_show_value_cmd):
2996         (maintenance_show_test_settings_value_cmd): ... this.
2997         (_initialize_maint_test_settings): No longer install the "maint
2998         test-settings" prefix command.  Rename "maint test-settings set"
2999         to "maint set test-settings", and "maint test-settings show" to
3000         "maint show test-settings".  Adjust all subcommands.
3001
3002 2019-07-03  Pedro Alves  <palves@redhat.com>
3003
3004         * maint-test-settings.c: Fix file's intro comment.  Replace all
3005         references to "test-options" with references to "test-settings",
3006         in comments.
3007
3008 2019-07-03  Pedro Alves  <palves@redhat.com>
3009
3010         * maint-test-settings.c (maintenance_test_settings_xxx)
3011         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3012         New.
3013         (maintenance_test_settings_enums): Use them.
3014         (maintenance_test_settings_enum): Default to
3015         maintenance_test_settings_xxx.
3016         (_initialize_maint_test_settings): Initialize
3017         MAINTENANCE_TEST_SETTINGS_FILENAME.
3018
3019 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3020
3021         * breakpoint.h (remove_breakpoints_inf): Change return type to
3022         void, move function documentation here.
3023         * breakpoint.c (remove_breakpoints_inf): Change return type to
3024         void, move function documentation to header.
3025
3026 2019-07-02  Pedro Alves  <palves@redhat.com>
3027
3028         * NEWS (Completion improvements): Mention "info threads".
3029         * thread.c (struct info_threads_opts, info_threads_option_defs)
3030         (make_info_threads_options_def_group): New.
3031         (info_threads_command): Use gdb::option::process_options.
3032         (info_threads_command_completer): New.
3033         (_initialize_thread): Use gdb::option::build_help to build the
3034         help text for "info threads".
3035
3036 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3037
3038         * defs.h (generic_load): Move from here...
3039         * symfile.h (generic_load): ... to here.  Rename name parameter
3040         to args.
3041         * symfile.c (generic_load): Add comment.
3042
3043 2019-07-01  Tom Tromey  <tromey@adacore.com>
3044
3045         * dwarf2read.c
3046         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3047         declaration of without_params.  Fix formatting.
3048
3049 2019-07-01  Tom Tromey  <tromey@adacore.com>
3050
3051         * ada-exp.y (find_primitive_type): Update.
3052         * ada-lang.h (ada_lookup_symbol): Update.
3053         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3054         parameter.
3055         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3056
3057 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3058
3059         PR breakpoints/24541
3060         * gdbarch.c: Regenerate.
3061         * gdbarch.h: Regenerate.
3062         * gdbarch.sh: Add 'stap_adjust_register'.
3063         * i386-tdep.c: Include '<unordered_set>'.
3064         (i386_stap_adjust_register): New function.
3065         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3066         * stap-probe.c (stap_parse_register_operand): Call
3067         'gdbarch_stap_adjust_register'.
3068
3069 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3070
3071         PR python/24742
3072         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3073         * python/python.c (do_start_initialization): Use 'xmalloc'
3074         instead of 'PyMem_Malloc'.
3075
3076 2019-06-28  Tom Tromey  <tromey@adacore.com>
3077
3078         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3079         for Ada.
3080
3081 2019-06-27  Tom Tromey  <tromey@adacore.com>
3082
3083         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3084         objfile_key.
3085         (arm_find_mapping_symbol, arm_record_special_symbol)
3086         (_initialize_arm_tdep): Update.
3087         (arm_objfile_data_free): Remove.
3088
3089 2019-06-27  Tom Tromey  <tromey@adacore.com>
3090
3091         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3092         to cp_print_static_field.
3093
3094 2019-06-26  Tom Tromey  <tromey@adacore.com>
3095
3096         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3097         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3098         declare.
3099
3100 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3101
3102         * features/aarch64-core.c (create_feature_aarch64_core):
3103         Regenerate.
3104         * features/aarch64-core.xml: Add cpsr flags.
3105
3106 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3107
3108         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3109         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3110
3111 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3112
3113         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3114         field.
3115         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3116         use.
3117         (arm_record_special_symbol): Don't insert new symbol in sorted
3118         position, push it at the end.
3119
3120 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3121
3122         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3123         (arm_mapping_symbol_s): Remove.
3124         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3125         (arm_mapping_symbol_vec): New typedef.
3126         (struct arm_per_objfile): Add constructor.
3127         <section_maps>: Change type to
3128         std::unique_ptr<arm_mapping_symbol_vec[]>.
3129         (arm_compare_mapping_symbols): Remove.
3130         (arm_find_mapping_symbol): Adjust to section_maps type change.
3131         (arm_objfile_data_free): Call delete on arm_per_objfile.
3132         (arm_record_special_symbol): Adjust to section_maps type change.
3133         Allocate arm_per_objfile with new.
3134
3135 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3136
3137         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3138         with the command prefix.
3139
3140 2019-06-25  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3143         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3144
3145 2019-06-25  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3148         type.
3149         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3150         protected.
3151
3152 2019-06-25  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-winsource.c
3155         (tui_source_window_base::set_is_exec_point_at): Add check against
3156         LOA_ADDRESS.
3157
3158 2019-06-25  Tom Tromey  <tom@tromey.com>
3159
3160         * tui/tui-source.c (tui_set_source_content): Don't check before
3161         xfree.
3162         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3163
3164 2019-06-25  Tom Tromey  <tom@tromey.com>
3165
3166         * tui/tui-winsource.h (tui_update_source_window_as_is)
3167         (tui_alloc_source_buffer, tui_line_is_displayed)
3168         (tui_addr_is_displayed): Change type of win_info.
3169         * tui/tui-winsource.c (tui_update_source_window_as_is)
3170         (tui_clear_source_content, tui_show_source_line)
3171         (tui_show_source_content, tui_source_window_base::refill)
3172         (tui_source_window_base::set_is_exec_point_at)
3173         (tui_source_window_base::set_is_exec_point_at)
3174         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3175         (tui_alloc_source_buffer, tui_line_is_displayed)
3176         (tui_addr_is_displayed): Change type of win_info.  Update.
3177         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3178         (tui_source_window_base::do_make_visible_with_new_height):
3179         Update.
3180         * tui/tui-source.c (tui_set_source_content)
3181         (tui_set_source_content_nil)
3182         (tui_source_window::do_scroll_vertical): Update.
3183         * tui/tui-layout.c (show_layout): Update.
3184         * tui/tui-disasm.c (tui_set_disassem_content)
3185         (tui_disasm_window::do_scroll_vertical): Update.
3186         * tui/tui-data.h (tui_win_content): Remove.
3187         (struct tui_gen_win_info) <content, content_size>: Remove.
3188         (struct tui_source_element): Add initializers and destructor.
3189         (union tui_which_element, struct tui_win_element): Remove.
3190         (struct tui_source_window_base) <content>: New field.
3191         (struct tui_data_window): Remove destructor.
3192         (tui_alloc_content, tui_free_win_content)
3193         (tui_free_all_source_wins_content): Don't declare.
3194         * tui/tui-data.c (tui_initialize_static_data): Update.
3195         (init_content_element, tui_alloc_content): Remove.
3196         (~tui_gen_win_info): Update.
3197         (~tui_data_window, tui_free_all_source_wins_content)
3198         (tui_free_win_content, free_content, free_content_elements):
3199         Remove.
3200
3201 2019-06-25  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-winsource.h (tui_clear_source_content)
3204         (tui_erase_source_content, tui_show_source_content): Change type
3205         of win_info.
3206         * tui/tui-winsource.c (tui_clear_source_content)
3207         (tui_erase_source_content, tui_show_source_content): Change type
3208         of win_info.
3209         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3210         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3211         win_info.
3212         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3213         win_info.
3214         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3215
3216 2019-06-25  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-winsource.c (tui_clear_source_content)
3219         (tui_source_window_base::set_is_exec_point_at): Update.
3220         * tui/tui-source.c (tui_set_source_content_nil): Update.
3221         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3222         a bool.
3223         * tui/tui-data.c (init_content_element): Update.
3224
3225 2019-06-25  Tom Tromey  <tom@tromey.com>
3226
3227         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3228         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3229         * tui/tui-layout.c (init_and_make_win): Update.
3230         * tui/tui.h (enum tui_win_type): Update.
3231         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3232         tui_win_is_auxillary.
3233         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3234         tui_win_is_auxillary.
3235
3236 2019-06-25  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3239         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3240         (tui_delete_data_content_windows, tui_display_all_data)
3241         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3242         Update.
3243         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3244         * tui/tui-regs.c (tui_last_regs_line_no)
3245         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3246         (tui_show_registers): Update.
3247         (tui_show_register_group): Return void.  Update.
3248         (tui_display_registers_from, tui_display_reg_element_at_line)
3249         (tui_display_registers_from_line, tui_check_register_values):
3250         Update.
3251         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3252         member.
3253         (struct tui_data_window) <regs_content>: Now a std::vector.
3254         <regs_content_count>: Remove.
3255         (tui_add_content_elements, tui_free_data_content): Don't declare.
3256         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3257         (init_content_element): Remove DATA_WIN case.  Add assert.
3258         (tui_add_content_elements): Remove.
3259         (tui_data_window): Update.
3260         (tui_free_data_content): Remove.
3261         (free_content_elements): Remove DATA_WIN case.
3262
3263 2019-06-25  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-data.c (tui_data_item_window): Update.
3266         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3267         * tui/tui-windata.c (tui_display_all_data)
3268         (tui_display_data_from_line): Update.
3269         (tui_check_data_values): Remove.
3270         * tui/tui-regs.c (tui_show_register_group)
3271         (tui_display_reg_element_at_line): Update.
3272         * tui/tui-hooks.c (tui_register_changed)
3273         (tui_refresh_frame_and_register_information): Call
3274         tui_check_register_values.
3275         * tui/tui-data.h (struct tui_data_window) <data_content,
3276         data_content_count, data_type>: Remove.
3277         (enum tui_data_type): Remove.
3278
3279         * tui/tui-data.c (tui_data_window::clear_detail)
3280         (~tui_data_window): Update.
3281
3282 2019-06-25  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3285         declare.
3286         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3287         Rename from tui_first_data_item_displayed.  Update.
3288         (tui_data_window::refresh_all)
3289         (tui_data_window::do_scroll_vertical): Update.
3290         * tui/tui-data.h (struct tui_data_window)
3291         <first_data_item_displayed>: Declare new method.
3292
3293 2019-06-25  Tom Tromey  <tom@tromey.com>
3294
3295         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3296         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3297         contents...
3298         (tui_initialize_static_data): ...here.
3299
3300 2019-06-25  Tom Tromey  <tom@tromey.com>
3301
3302         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3303         (tui_display_registers_from, tui_check_register_values): Update.
3304         (tui_display_register): Remove win_info parameter; update.
3305         (tui_get_register): Change type of parameters.
3306         * tui/tui-data.h (struct tui_data_element): Remove.
3307         (union tui_which_element) <data>: Remove.
3308         <data_window>: Change type.
3309         (struct tui_data_item_window): New.
3310         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3311         case.  Add assert.
3312         (~tui_data_item_window): New destructor.
3313         (free_content_elements): Remove DATA_ITEM_WIN case.
3314
3315 2019-06-25  Tom Tromey  <tom@tromey.com>
3316
3317         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3318         Remove.
3319
3320 2019-06-25  Tom Tromey  <tom@tromey.com>
3321
3322         * tui/tui-data.h (struct tui_command_element): Remove.
3323         (union tui_which_element) <command>: Remove.
3324         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3325         assert.
3326         (free_content_elements): Remove CMD_WIN case.
3327
3328 2019-06-25  Tom Tromey  <tom@tromey.com>
3329
3330         * tui/tui-layout.c (tui_set_layout): Update.
3331         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3332         * tui/tui-data.c (layout_def): Update.
3333
3334 2019-06-25  Tom Tromey  <tom@tromey.com>
3335
3336         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3337         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3338         (tui_source_window_base::set_new_height): Update.
3339         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3340         Update.
3341         (tui_set_locator_fullname, tui_set_locator_info)
3342         (tui_show_frame_info): Update.
3343         * tui/tui-source.c (tui_set_source_content)
3344         (tui_source_is_displayed): Update.
3345         * tui/tui-layout.c (show_source_disasm_command, show_data)
3346         (show_source_or_disasm_and_command): Update.
3347         * tui/tui-disasm.c (tui_set_disassem_content)
3348         (tui_get_begin_asm_address): Update.
3349         * tui/tui-data.h (struct tui_locator_element): Remove.
3350         (union tui_which_element) <locator>: Remove.
3351         (struct tui_locator_window): New.
3352         (tui_locator_win_info_ptr): Change return type.
3353         * tui/tui-data.c (_locator): Change type.
3354         (tui_locator_win_info_ptr): Change return type.
3355         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3356         (tui_alloc_content): Add assert.
3357
3358 2019-06-25  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-winsource.c
3361         (tui_exec_info_window::maybe_allocate_content): New method.
3362         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3363         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3364         (make_source_or_disasm_window): Add cast.
3365         * tui/tui-data.h (union tui_which_element) <simple_string>:
3366         Remove.
3367         (struct tui_source_info): New.
3368         (struct tui_source_window_base) <execution_info>: Change type.
3369         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3370         case, and add assert.
3371         (tui_alloc_content): Add assert.
3372
3373 2019-06-25  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3376         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3377         * tui/tui-data.c (tui_alloc_win_info): Remove.
3378
3379 2019-06-25  Tom Tromey  <tom@tromey.com>
3380
3381         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3382         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3383         can_highlight.
3384
3385 2019-06-25  Tom Tromey  <tom@tromey.com>
3386
3387         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3388         make_visible_with_new_height method.
3389         (tui_win_info::make_visible_with_new_height): New method.
3390         (tui_source_window_base::do_make_visible_with_new_height)
3391         (tui_data_window::do_make_visible_with_new_height)
3392         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3393         (make_visible_with_new_height): Remove.
3394         (tui_resize_all, tui_adjust_win_heights): Use
3395         make_visible_with_new_height method.
3396         * tui/tui-data.h (struct tui_win_info)
3397         <do_make_visible_with_new_height, make_visible_with_new_height>:
3398         New methods.
3399         (struct tui_source_window_base, struct tui_data_window)
3400         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3401         methods.
3402
3403 2019-06-25  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3406         method.
3407         (update_tab_width): Call update_tab_width method.
3408         * tui/tui-data.h (struct tui_win_info)
3409         (struct tui_source_window_base) <update_tab_width>: New methods.
3410
3411 2019-06-25  Tom Tromey  <tom@tromey.com>
3412
3413         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3414         parameter.
3415         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3416         parameter.
3417         (tui_gen_win_info::make_visible): Update.
3418         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3419         parameter.
3420         * tui/tui-data.h (enum tui_box): New enum.
3421         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3422
3423 2019-06-25  Tom Tromey  <tom@tromey.com>
3424
3425         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3426         init_and_make_win for EXEC_INFO_WIN.
3427         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3428         longer inline.
3429         (struct tui_win_info) <~tui_win_info>: Inline.
3430         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3431         Don't declare.
3432         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3433         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3434         Remove.
3435         (tui_initialize_static_data): Update.
3436         (~tui_gen_win_info): Handle more cleanup here.
3437         (~tui_source_window_base): Delete "execution_info".
3438         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3439
3440 2019-06-25  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-layout.c (make_command_window): Don't set
3443         can_highlight.
3444         (show_source_disasm_command): Call the reset method.
3445         (show_data): Don't set can_highlight.  Call the reset method.
3446         (tui_gen_win_info::reset): Rename from init_gen_win_info
3447         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3448         (show_source_or_disasm_and_command): Call the reset method.
3449         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3450         (struct tui_cmd_window): Set can_highlight.
3451
3452 2019-06-25  Tom Tromey  <tom@tromey.com>
3453
3454         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3455         from make_visible.
3456         (tui_make_visible, tui_make_invisible): Rewrite.
3457         (tui_win_info::make_visible): Remove.
3458         (tui_source_window_base::make_visible): Update.
3459         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3460         method.  Moved from...
3461         (struct tui_win_info) <make_visible>: ...here.
3462
3463 2019-06-25  Tom Tromey  <tom@tromey.com>
3464
3465         * tui/tui-winsource.c
3466         (tui_source_window_base::do_scroll_horizontal): Remove direction
3467         parameter.
3468         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3469         direction parameter.
3470         * tui/tui-win.c (tui_win_info::forward_scroll)
3471         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3472         (tui_win_info::right_scroll): Update.
3473         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3474         direction parameter.
3475         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3476         direction parameter.
3477         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3478         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3479         Remove direction parameter.
3480         (struct tui_source_window_base, struct tui_source_window)
3481         (struct tui_disasm_window, struct tui_data_window)
3482         (struct tui_cmd_window): Update.
3483
3484 2019-06-25  Tom Tromey  <tom@tromey.com>
3485
3486         * tui/tui-winsource.h (tui_set_exec_info_content)
3487         (tui_show_exec_info_content, tui_erase_exec_info_content)
3488         (tui_clear_exec_info_content, tui_update_exec_info): Change
3489         argument to tui_source_window_base.
3490         * tui/tui-winsource.c (tui_set_exec_info_content)
3491         (tui_show_exec_info_content, tui_erase_exec_info_content)
3492         (tui_clear_exec_info_content, tui_update_exec_info): Change
3493         argument to tui_source_window_base.
3494
3495 2019-06-25  Tom Tromey  <tom@tromey.com>
3496
3497         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3498         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3499
3500 2019-06-25  Tom Tromey  <tom@tromey.com>
3501
3502         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3503         check.
3504
3505 2019-06-25  Tom Tromey  <tom@tromey.com>
3506
3507         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3508         type to void.
3509         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3510         type to void.
3511         * tui/tui-source.c (tui_set_source_content): Update.
3512         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3513
3514 2019-06-25  Tom Tromey  <tom@tromey.com>
3515
3516         * tui/tui-win.c (window_name_completer, tui_set_focus)
3517         (tui_all_windows_info): Use name method.
3518         * tui/tui-data.h (struct tui_gen_win_info)
3519         (struct tui_source_window, struct tui_disasm_window)
3520         (struct tui_data_window, struct tui_cmd_window) <name>: New
3521         method.
3522         (tui_win_name): Don't declare.
3523         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3524         (tui_win_name): Remove.
3525
3526 2019-06-25  Tom Tromey  <tom@tromey.com>
3527
3528         * tui/tui-winsource.h (tui_update_source_window)
3529         (tui_update_source_window_as_is): Change parameter type.
3530         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3531         to be a tui_source_window_base.
3532         (tui_update_source_window_as_is): Likewise.
3533         * tui/tui-win.c (make_visible_with_new_height): Update.
3534
3535 2019-06-25  Tom Tromey  <tom@tromey.com>
3536
3537         * tui/tui-winsource.c (tui_erase_source_content)
3538         (tui_show_source_content, tui_show_exec_info_content)
3539         (tui_erase_exec_info_content): Use refresh_window method.
3540         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3541         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3542         from tui_refresh_win.
3543         (tui_data_window::refresh_window): New method.
3544         (tui_win_info::refresh, tui_source_window_base::refresh)
3545         (tui_refresh_all): Use refresh_window method.
3546         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3547         method.
3548         * tui/tui-regs.c (tui_display_register): Call refresh_window
3549         method.
3550         * tui/tui-layout.c (show_source_disasm_command)
3551         (show_source_or_disasm_and_command): Call refresh_window method.
3552         * tui/tui-data.h (struct tui_gen_win_info)
3553         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3554         New method.
3555
3556 2019-06-25  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui.c (tui_rl_other_window, tui_enable)
3559         (tui_is_window_visible, tui_get_command_dimension): Update.
3560         * tui/tui-winsource.c (tui_update_source_window_as_is)
3561         (tui_clear_source_content, tui_erase_source_content)
3562         (tui_show_source_line, tui_source_window_base::refill)
3563         (tui_source_window_base::do_scroll_horizontal)
3564         (tui_source_window_base::set_is_exec_point_at)
3565         (tui_update_breakpoint_info, tui_set_exec_info_content)
3566         (tui_alloc_source_buffer, tui_line_is_displayed)
3567         (tui_addr_is_displayed): Update.
3568         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3569         (tui_check_and_display_highlight_if_needed)
3570         (tui_win_info::make_visible, tui_win_info::refresh)
3571         (tui_refresh_all): Update.
3572         * tui/tui-windata.c (tui_first_data_item_displayed)
3573         (tui_delete_data_content_windows, tui_erase_data_content)
3574         (tui_display_all_data, tui_data_window::refresh_all)
3575         (tui_check_data_values): Update.
3576         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3577         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3578         (tui_win_info::backward_scroll, tui_refresh_all_win)
3579         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3580         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3581         (tui_source_window_base::set_new_height)
3582         (tui_data_window::set_new_height)
3583         (make_invisible_and_set_new_height)
3584         (make_visible_with_new_height, new_height_ok)
3585         (parse_scrolling_args): Update.
3586         * tui/tui-stack.c (tui_show_frame_info): Update.
3587         * tui/tui-source.c (tui_set_source_content)
3588         (tui_set_source_content_nil, tui_source_is_displayed)
3589         (tui_source_window::do_scroll_vertical): Update.
3590         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3591         (tui_display_registers_from, tui_display_reg_element_at_line)
3592         (tui_check_register_values, tui_reg_command): Update.
3593         * tui/tui-layout.c (tui_default_win_height)
3594         (show_source_disasm_command, show_data, init_and_make_win)
3595         (show_source_or_disasm_and_command): Update.
3596         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3597         (tui_redisplay_readline, tui_mld_flush)
3598         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3599         (tui_getc): Update.
3600         * tui/tui-disasm.c (tui_set_disassem_content)
3601         (tui_disasm_window::do_scroll_vertical): Update.
3602         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3603         Now virtual.
3604         (struct tui_win_info): Derive from tui_gen_win_info.
3605         <~tui_win_info>: Mark as override.
3606         <generic>: Remove member.
3607         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3608         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3609         (~tui_data_window, ~tui_win_info)
3610         (tui_free_all_source_wins_content): Update.
3611         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3612
3613 2019-06-25  Tom Tromey  <tom@tromey.com>
3614
3615         * tui/tui-layout.c (init_and_make_win): Use new.
3616         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3617         destructor, initializers.
3618         (tui_alloc_generic_win_info): Don't declare.
3619         * tui/tui-data.c (_locator): Add argument to constructor.
3620         (source_win, disasm_win): New globals.
3621         (exec_info): Remove.
3622         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3623         Update.
3624         (tui_alloc_generic_win_info): Remove.
3625         (init_content_element): Use new.
3626         (tui_win_info::tui_win_info): Update.
3627         (free_content_elements) <case DATA_WIN>: Use delete.
3628
3629 2019-06-25  Tom Tromey  <tom@tromey.com>
3630
3631         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3632         * tui/tui-windata.c (tui_first_data_item_displayed)
3633         (tui_delete_data_content_windows): Update.
3634         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3635         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3636         (tui_display_registers_from, tui_check_register_values): Update.
3637         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3638         pointer.
3639         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3640         window.
3641         (tui_free_data_content): Update.
3642         (free_content_elements) <case DATA_WIN>: Free the window.
3643
3644 2019-06-25  Tom Tromey  <tom@tromey.com>
3645
3646         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3647         Update.
3648         * tui/tui-layout.c (make_command_window)
3649         (show_source_disasm_command, show_data, init_and_make_win)
3650         (show_source_or_disasm_and_command): Update.
3651         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3652         method.
3653         <can_highight, is_highlighted>: Now bool.
3654         (tui_set_win_highlight): Don't declare.
3655         * tui/tui-data.c (tui_set_win_highlight): Remove.
3656
3657 2019-06-25  Tom Tromey  <tom@tromey.com>
3658
3659         * tui/tui-wingeneral.c (make_visible): Remove check of window
3660         type.
3661
3662 2019-06-25  Tom Tromey  <tom@tromey.com>
3663
3664         * tui/tui-win.c (tui_win_info::max_height)
3665         (tui_cmd_window::max_height): New methods.
3666         (new_height_ok): Call max_height.
3667         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3668         <max_height>: New method.
3669
3670 2019-06-25  Tom Tromey  <tom@tromey.com>
3671
3672         * tui/tui-win.c (tui_source_window_base::set_new_height)
3673         (tui_data_window::set_new_height): New methods.
3674         (make_invisible_and_set_new_height): Call set_new_height method.
3675         * tui/tui-data.h (struct tui_win_info)
3676         (struct tui_source_window_base, struct tui_data_window)
3677         <set_new_height>: New method.
3678
3679 2019-06-25  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3682         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3683         tui_refresh_data_win.
3684         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3685         method.
3686         (tui_refresh_all_win): Call the refresh_all method.
3687         (tui_set_focus): Likewise.
3688         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3689         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3690         Likewise.
3691
3692 2019-06-25  Tom Tromey  <tom@tromey.com>
3693
3694         * tui/tui-winsource.h (tui_refill_source_window)
3695         (tui_set_is_exec_point_at): Don't declare.
3696         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3697         (tui_source_window_base::refill): Rename from
3698         tui_refill_source_window.
3699         (tui_source_window_base::do_scroll_horizontal): Update.
3700         (tui_source_window_base::set_is_exec_point_at): Rename from
3701         tui_set_is_exec_point_at.
3702         (tui_update_all_breakpoint_info): Update.
3703         * tui/tui-stack.c (tui_show_frame_info): Update.
3704         * tui/tui-layout.c (show_data): Add cast.
3705         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3706         * tui/tui-data.h (struct tui_source_window_base) <refill,
3707         set_is_exec_point_at>: New methods.
3708         (tui_source_windows, tui_add_to_source_windows): Update types.
3709         (tui_add_to_source_windows): Remove redundant declaration.
3710         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3711         (tui_source_windows): Change return type.
3712         (tui_clear_source_windows_detail): Update.
3713         (tui_add_to_source_windows): Change type of parameter.
3714         (tui_free_all_source_wins_content): Update.
3715
3716 2019-06-25  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-wingeneral.c (tui_win_info::refresh)
3719         (tui_source_window_base::refresh): New methods.
3720         (tui_refresh_all): Call the refresh method.
3721         * tui/tui-data.h (struct tui_win_info)
3722         (struct tui_source_window_base) <refresh>: New method.
3723
3724 2019-06-25  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui.h (tui_is_window_visible): Return bool.
3727         * tui/tui.c (tui_is_window_visible): Return bool.
3728         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3729         (tui_make_visible, tui_make_invisible)
3730         (tui_win_info::make_visible)
3731         (tui_source_window_base::make_visible, make_all_visible)
3732         (tui_make_all_visible, tui_make_all_invisible): Update.
3733         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3734         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3735         bool.
3736         (struct tui_win_info, struct tui_source_window_base)
3737         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3738         * tui/tui-data.c (tui_init_generic_part): Update.
3739
3740 2019-06-25  Tom Tromey  <tom@tromey.com>
3741
3742         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3743         (tui_source_window_base::make_visible): New methods.
3744         (make_all_visible): Make method call.
3745         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3746         (struct tui_source_window_base, struct tui_cmd_window): Override
3747         make_visible.
3748         (tui_win_is_source_type): Don't declare.
3749         * tui/tui-data.c (tui_win_is_source_type): Remove.
3750
3751 2019-06-25  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3754         NULL check.
3755
3756 2019-06-25  Tom Tromey  <tom@tromey.com>
3757
3758         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3759         Inline constructor.  Add initializers for members.
3760         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3761         constructors; now inline in class.
3762
3763 2019-06-25  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-regs.c (tui_show_registers): Update.
3766         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3767         bool.
3768         * tui/tui-data.c (tui_data_window::clear_detail)
3769         (tui_data_window): Update.
3770
3771 2019-06-25  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui-windata.c (tui_display_all_data)
3774         (tui_display_data_from_line, tui_display_data_from)
3775         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3776         Update.
3777         * tui/tui-regs.c (tui_last_regs_line_no)
3778         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3779         (tui_show_registers, tui_show_register_group)
3780         (tui_display_registers_from, tui_display_reg_element_at_line)
3781         (tui_display_registers_from_line, tui_check_register_values)
3782         (tui_reg_next, tui_reg_prev): Update.
3783         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3784         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3785         tui_data_window.
3786         (struct tui_win_info) <detail>: Remove.  Add new fields from
3787         tui_data_info.
3788         (TUI_DATA_WIN): Add cast.
3789         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3790         (~tui_data_window): Simplify.
3791
3792 2019-06-25  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-layout.c (show_source_disasm_command)
3795         (show_source_or_disasm_and_command): Update.
3796         * tui/tui-io.c (update_cmdwin_start_line)
3797         (tui_redisplay_readline): Update.
3798         * tui/tui-data.h (struct tui_command_info): Remove.
3799         (struct tui_win_info) <detail>: Remove command_info member.
3800         (struct tui_data_window) <start_line>: New member, from
3801         tui_command_info.
3802         (TUI_CMD_WIN): Add casts.
3803
3804 2019-06-25  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-winsource.c (tui_update_source_window)
3807         (tui_refill_source_window)
3808         (tui_source_window_base::do_scroll_horizontal)
3809         (tui_update_breakpoint_info, tui_set_exec_info_content)
3810         (tui_show_exec_info_content, tui_erase_exec_info_content)
3811         (tui_clear_exec_info_content): Update.
3812         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3813         Update.
3814         * tui/tui-win.c (make_invisible_and_set_new_height)
3815         (make_visible_with_new_height): Update.
3816         * tui/tui-source.c (tui_set_source_content)
3817         (tui_show_symtab_source): Update.
3818         * tui/tui-layout.c (extract_display_start_addr)
3819         (show_source_disasm_command, show_data)
3820         (make_source_or_disasm_window)
3821         (show_source_or_disasm_and_command): Update.
3822         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3823         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3824         "gdbarch".
3825         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3826         to tui_source_window_base.
3827         (struct tui_win_info) <detail>: Remove source_info member.
3828         (struct tui_source_window_base) <has_locator>: Inline.
3829         Move contents from tui_source_info; rename has_locator member to
3830         m_has_locator.
3831         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3832         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3833         header file.
3834         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3835         Simplify.
3836         (tui_free_all_source_wins_content): Cast to
3837         tui_source_window_base.
3838
3839 2019-06-25  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui-win.c (make_invisible_and_set_new_height)
3842         (make_visible_with_new_height): Call has_locator method.
3843         * tui/tui-layout.c (show_source_disasm_command, show_data)
3844         (show_source_or_disasm_and_command): Update for bool change.
3845         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3846         (tui_win_info) <has_locator>: New method.
3847         (struct tui_source_window_base) <has_locator>: New method.
3848         (tui_win_has_locator): Don't declare.
3849         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3850         from tui_win_has_locator.
3851         (tui_source_window_base): Use false, not FALSE.
3852
3853 2019-06-25  Tom Tromey  <tom@tromey.com>
3854
3855         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3856         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3857         clear_detail method directly.
3858         (tui_clear_win_detail): Remove.
3859
3860 2019-06-25  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3863         "this", not TUI_DISASM_WIN.
3864
3865 2019-06-25  Tom Tromey  <tom@tromey.com>
3866
3867         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3868         declare.
3869         * tui/tui-winsource.c
3870         (tui_source_window_base::do_scroll_horizontal): Rename from
3871         tui_horizontal_source_scroll.
3872         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3873         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3874         from tui_vertical_data_scroll.
3875         * tui/tui-win.h (tui_scroll): Don't declare.
3876         * tui/tui-win.c (tui_win_info::forward_scroll)
3877         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3878         (tui_win_info::right_scroll): Rename and update.
3879         (tui_scroll_forward_command, tui_scroll_backward_command)
3880         (tui_scroll_left_command, tui_scroll_right_command): Update.
3881         (tui_scroll): Remove.
3882         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3883         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3884         from tui_vertical_source_scroll.
3885         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3886         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3887         from tui_vertical_disassem_scroll.
3888         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3889         do_scroll_horizontal>: New methods.
3890         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3891         Likewise.
3892         (struct tui_source_window_base): Add do_scroll_horizontal.
3893         (struct tui_source_window, struct tui_disasm_window): Add
3894         do_scroll_vertical.
3895         (struct tui_data_window, struct tui_cmd_window): Add
3896         do_scroll_horizontal and do_scroll_vertical.
3897         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3898
3899 2019-06-25  Tom Tromey  <tom@tromey.com>
3900
3901         * tui/tui-data.h (struct tui_source_window_base): New struct.
3902         (struct tui_source_window): Derive from tui_source_window_base.
3903         (struct tui_disasm_window): New struct.
3904         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3905         from tui_source_window::clear_detail.
3906         (tui_source_window_base): Rename from tui_source_window.
3907         (~tui_source_window_base): Rename from ~tui_source_window.
3908         (tui_alloc_win_info): Create a tui_disasm_window.
3909
3910 2019-06-25  Tom Tromey  <tom@tromey.com>
3911
3912         * tui/tui-data.h (struct tui_source_window)
3913         (struct tui_data_window): Declare destructors.
3914         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3915         destructors.
3916         (tui_win_info): Simplify.
3917
3918 2019-06-25  Tom Tromey  <tom@tromey.com>
3919
3920         * tui/tui-winsource.c (tui_display_main)
3921         (tui_update_source_windows_with_addr)
3922         (tui_update_all_breakpoint_info): Update.
3923         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3924         (new_height_ok, parse_scrolling_args): Update.
3925         * tui/tui-stack.c (tui_show_frame_info): Update.
3926         * tui/tui-data.h (struct tui_list): Remove.
3927         (tui_source_windows): Return a reference to a std::vector.
3928         * tui/tui-data.c (source_windows): Now a std::vector.
3929         (tui_source_windows): Change return type.
3930         (tui_clear_source_windows): Rewrite.
3931         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3932         (tui_free_all_source_wins_content): Rewrite.
3933
3934 2019-06-25  Tom Tromey  <tom@tromey.com>
3935
3936         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3937         (struct tui_data_window, struct tui_cmd_window): Declare
3938         clear_detail method.
3939         * tui/tui-data.c (tui_source_window::clear_detail)
3940         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3941         methods.
3942         (tui_clear_win_detail): Simplify.
3943
3944 2019-06-25  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-layout.c (make_source_window, make_disasm_window)
3947         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3948         Return the new window.
3949         (show_source_disasm_command, show_data)
3950         (show_source_or_disasm_and_command): Update.
3951
3952 2019-06-25  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3955         parameter.  Return the new window.
3956         (show_source_disasm_command): Update and remove NULL check.
3957         (show_source_or_disasm_and_command): Update.
3958
3959 2019-06-25  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3962
3963 2019-06-25  Tom Tromey  <tom@tromey.com>
3964
3965         * tui/tui-data.h (struct tui_win_info): Make constructor
3966         protected.  Make destructor virtual.  Add initializers.
3967         (tui_source_window, tui_data_window, tui_cmd_window): New
3968         classes.
3969         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3970         constructor.  Add "type" parameter.
3971         (tui_source_window, tui_data_window, tui_cmd_window): New
3972         constructors.
3973         (tui_alloc_win_info): Instantiate the appropriate subclass.
3974
3975 2019-06-25  Tom Tromey  <tom@tromey.com>
3976
3977         * tui/tui-win.c (tui_resize_all): Use delete.
3978         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3979         destructor.
3980         (tui_free_window): Don't declare.
3981         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3982         Update.
3983
3984 2019-06-25  Tom Tromey  <tom@tromey.com>
3985
3986         * tui/tui-data.h (struct tui_win_info): Add constructor.
3987         * tui/tui-data.c (tui_alloc_win_info): Use new.
3988         (tui_free_window): Use delete.
3989
3990 2019-06-22  Tom Tromey  <tom@tromey.com>
3991
3992         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3993         declare.
3994         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3995
3996 2019-06-22  Tom Tromey  <tom@tromey.com>
3997
3998         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3999         declare.
4000         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4001
4002 2019-06-22  Tom de Vries  <tdevries@suse.de>
4003
4004         * dwarf2read.c (create_addrmap_from_aranges)
4005         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4006         instead of '%zu'.
4007
4008 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4009
4010         * dwarf2read.h (dwarf2_section_info_def): Remove.
4011         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4012         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4013         std::vector<dwarf2_section_info>.
4014         (struct dwo_file) <~dwo_file>: Remove.
4015         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4016         types field.
4017         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4018         (dwarf2_read_debug_names): Likewise.
4019         (create_debug_types_hash_table): Change parameter type to
4020         array_view, adjust code accordingly.
4021         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4022         (partial_die_info::fixup): Likewise.
4023         (determine_prefix): Likewise.
4024         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4025
4026 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4027
4028         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4029         gdb_bfd_ref_ptr.
4030         <~dwo_file>: Remove call to gdb_bfd_unref.
4031         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4032         gdb_bfd_ref_ptr::get.
4033
4034 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4035
4036         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4037         type to htab_up.
4038         * dwarf2read.c (struct dwo_file): Initialize fields.
4039         <~dwo_file>: New.
4040         (free_dwo_file): Remove, move content to ~dwo_file.
4041         (struct dwo_file_deleter): Remove.
4042         (dwo_file_up>: Remove custom deleter.
4043         (free_dwo_files): Remove.
4044         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4045         dwo_files.
4046         (process_skeletonless_type_units): Call unique_ptr::get.
4047         (allocate_dwo_file_hash_table): Add deleter to created hash
4048         table.  Change return type to htab_up.
4049         (lookup_dwo_file_slot): Don't memset dwo_file, call
4050         unique_ptr::get.
4051         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4052         (create_dwo_unit_in_dwp_v2): Likewise.
4053         (open_and_init_dwo_file): Likewise.
4054         (free_dwo_file_from_slot): Remove.
4055
4056 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4057
4058         * dwarf2read.h (struct dwarf2_section_info) <readin,
4059         is_virtual>: Change type to bool.
4060         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4061         true instead of 1.
4062
4063 2019-06-19  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-data.h (tui_init_content_element): Don't declare.
4066
4067 2019-06-19  Tom Tromey  <tom@tromey.com>
4068
4069         * tui/tui-data.h (tui_init_win_info): Don't declare.
4070
4071 2019-06-19  Tom de Vries  <tdevries@suse.de>
4072
4073         * dwarf2read.h (abstract_to_concrete): Change type to
4074         std::unordered_map<sect_offset, std::vector<sect_offset>,
4075         gdb::hash_enum<sect_offset>>.
4076
4077 2019-06-19  Tom Tromey  <tromey@adacore.com>
4078
4079         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4080         EVAL_AVOID_SIDE_EFFECTS specially.
4081
4082 2019-06-19  Tom Tromey  <tromey@adacore.com>
4083
4084         * source-cache.c (highlighter): New global.
4085         (source_cache::get_source_lines): Create a highlighter on demand.
4086
4087 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4088
4089         * defs.h (deprecated_interactive_hook): Delete declaration.
4090         * interps.c (clear_interpreter_hooks): Remove use of
4091         deprecated_interactive_hook.
4092         * top.c (deprecated_interactive_hook): Delete definition.
4093         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4094
4095 2019-06-18  Tom de Vries  <tdevries@suse.de>
4096
4097         PR gdb/24515
4098         * dwarf2read.h (abstract_to_concrete): Change type from
4099         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4100         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4101         * dwarf2read.c (read_variable): Update.
4102         (dwarf2_fetch_die_loc_sect_off): Update.
4103
4104 2019-06-17  Tom de Vries  <tdevries@suse.de>
4105
4106         PR gdb/24617
4107         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4108         accessing parent[parent_len - 1].
4109
4110 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4111
4112         PR gdb/24364
4113         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4114         call dtrace_process_dof with NULL dof.
4115
4116 2019-06-16  Tom de Vries  <tdevries@suse.de>
4117
4118         PR gdb/24445
4119         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4120
4121 2019-06-16  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4124         (make_all_visible): Use address of member.
4125
4126 2019-06-16  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4129         (tui_free_window, free_content, free_content_elements): Remove
4130         unnecessary cast.
4131         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4132         cast.
4133         * tui/tui-regs.c (tui_show_register_group)
4134         (tui_display_registers_from, tui_display_reg_element_at_line):
4135         Remove unnecessary cast.
4136
4137 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4138
4139         * linux-nat.c (normal_mask): Delete.
4140         (_initialize_linux_nat): Don't initialise normal_mask.
4141
4142 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4143
4144         PR gdb/24445
4145         * dwarf-index-write.h (write_psymtabs_to_index): Add
4146         dwz_basename parameter.
4147         * dwarf-index-write.c (write_gdbindex): Move file writing to
4148         write_gdbindex_1.  Change return type void.
4149         (assert_file_size): Move up, remove filename parameter.
4150         (write_gdbindex_1): New function.
4151         (write_debug_names): Change return type to void, call
4152         assert_file_size.
4153         (struct index_wip_file): New struct.
4154         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4155         file logic to index_wip_file.  Write index for dwz file if
4156         needed.
4157         (save_gdb_index_command): Pass basename of dwz file, if present.
4158         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4159         build-id of dwz file, if present.
4160         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4161         (dwarf2_get_dwz_file): Likewise.
4162         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4163         (dwarf2_get_dwz_file): Likewise.
4164
4165 2019-06-16  Tom Tromey  <tom@tromey.com>
4166
4167         * coffread.c (process_coff_symbol): Use xstrdup.
4168         * value.c (create_internalvar): Use xstrdup.
4169
4170 2019-06-16  Tom Tromey  <tom@tromey.com>
4171
4172         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4173         * breakpoint.c (stopin_command, stopat_command)
4174         (until_break_command, decode_location_default): Remove unnecessary
4175         cast.
4176         * utils.c (subset_compare): Remove unnecessary cast.
4177         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4178         cast.
4179         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4180         cast.
4181         * infcmd.c (path_command): Remove unnecessary cast.
4182         * coffread.c (decode_type): Remove unnecessary cast.
4183         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4184         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4185         * tui/tui-stack.c (tui_show_locator_content)
4186         (tui_show_frame_info): Remove unnecessary cast.
4187         * tui/tui-win.c (tui_scroll_forward_command)
4188         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4189         (parse_scrolling_args): Remove unnecessary cast.
4190         * tui/tui-data.c (init_win_info, tui_del_window)
4191         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4192         (free_content_elements): Remove unnecessary cast.
4193         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4194         unnecessary cast.
4195         * tui/tui-source.c (tui_set_source_content)
4196         (tui_vertical_source_scroll): Remove unnecessary cast.
4197         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4198         cast.
4199         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4200         * tui/tui-regs.c (tui_display_registers_from)
4201         (tui_display_register): Remove unnecessary cast.
4202         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4203         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4204         (make_visible): Remove unnecessary cast.
4205         * tui/tui-winsource.c (tui_erase_source_content)
4206         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4207         unnecessary cast.
4208         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4209         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4210         * stabsread.c (read_type, read_array_type, read_range_type):
4211         Remove unnecessary cast.
4212         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4213         (parse_symbol, parse_type, upgrade_type, parse_external)
4214         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4215         unnecessary cast.
4216         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4217
4218 2019-06-16  Tom Tromey  <tom@tromey.com>
4219
4220         * tui/tui-data.c (tui_alloc_generic_win_info)
4221         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4222         checks.
4223
4224 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4225             Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * f-typeprint.c (f_print_type): Don't return early for not
4228         associated or not allocated types.
4229         (f_type_print_varspec_suffix): Add print_rank parameter and print
4230         ranks of array types in case they dangling.
4231         (f_type_print_base): Add print_rank parameter.
4232
4233 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4234
4235         * NEWS: Mention new MI commands.
4236         * break-catch-throw.c (enum exception_event_kind): Move to
4237         breakpoint.h.
4238         (print_mention_exception_catchpoint): Output text as a single
4239         message.
4240         (catch_exception_command_1): Rename to...
4241         (catch_exception_event): ...this, make non-static, update header
4242         command, and change some parameter types.
4243         (catch_catch_command): Update for changes to
4244         catch_exception_command_1.
4245         (catch_throw_command): Likewise.
4246         (catch_rethrow_command): Likewise.
4247         * breakpoint.c (enum exception_event_kind): Delete.
4248         * breakpoint.h (enum exception_event_kind): Moved here from
4249         break-catch-throw.c.
4250         (catch_exception_event): Declare.
4251         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4252         (mi_cmd_catch_throw): New function.
4253         (mi_cmd_catch_rethrow): New function.
4254         (mi_cmd_catch_catch): New function.
4255         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4256         'catch-catch' entries.
4257         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4258         (mi_cmd_catch_rethrow): Declare.
4259         (mi_cmd_catch_catch): Declare.
4260
4261 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4262
4263         * annotate.c (annotate_source_line): Change return type to void,
4264         update implementation to match.
4265         * annotate.h (annotate_source_line): Change return type to void,
4266         update header comment.
4267         * stack.c (print_frame_info): Don't change what frame information
4268         is printed based on whether annotations are on or not.
4269
4270 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4271
4272         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4273         (annotate_source): Make static.
4274         (annotate_source_line): Moved from source.c and renamed from
4275         identify_source_line.  Update the return type.
4276         * annotate.h (annotate_source): Delete declaration.
4277         (annotate_source_line): Declaration moved from source.h, and
4278         renamed from identify_source_line.  Return type updated.
4279         * source.c (identify_source_line): Moved to annotate.c and renamed
4280         to annotate_source_line.
4281         (info_line_command): Remove check of annotation_level.
4282         * source.h (identify_source_line): Move declaration to annotate.h
4283         and rename to annotate_source_line.
4284         * stack.c: Add 'annotate.h' include.
4285         (print_frame_info): Remove check of annotation_level before
4286         calling annotate_source_line.
4287
4288 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4289
4290         * source-cache.c (source_cache::get_plain_source_lines): Use
4291         open_source_file_with_line_charpos instead of just
4292         open_source_file, remove call to find_source_lines.
4293         (source_cache::get_source_lines): Likewise.
4294         * source.c (find_source_lines): Make static.
4295         (get_filename_and_charpos): Renamed into...
4296         (open_source_file_with_line_charpos): ..this along with changes to
4297         return a scoped_fd, and some other minor clean ups.
4298         (identify_source_line): Use open_source_file_with_line_charpos.
4299         (search_command_helper): Use open_source_file_with_line_charpos
4300         instead of just open_source_file, remove call to
4301         find_source_lines.
4302         * source.h (open_source_file_with_line_charpos): Declare new
4303         function.
4304         (find_source_lines): Delete declaration.
4305
4306 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4307
4308         * source.c (get_filename_and_charpos): Remove fullname
4309         parameter.
4310         (identify_source_line): Update call to get_filename_and_charpos.
4311
4312 2019-06-14  Tom Tromey  <tromey@adacore.com>
4313
4314         PR gdb/24502:
4315         * ui-style.h (skip_ansi_escape): Update comment.
4316         * ui-file.h (class no_terminal_escape_file): New class.
4317         * ui-file.c (no_terminal_escape_file::write)
4318         (no_terminal_escape_file::puts): New methods.
4319         * cli/cli-logging.c (handle_redirections): Use
4320         no_terminal_escape_file.
4321
4322 2019-06-14  Tom Tromey  <tromey@adacore.com>
4323
4324         * NEWS: Move convenience variable news above Python news.
4325
4326 2019-06-14  Tom Tromey  <tom@tromey.com>
4327
4328         * gnulib: Move directory to top-level.
4329         * configure.ac: Don't configure gnulib.
4330         * configure: Rebuild.
4331         * common/common-defs.h: Use new path to gnulib.
4332         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4333         (GNULIB_H): Remove.
4334         (INCGNU): Look in new gnulib location.
4335         (HFILES_NO_SRCDIR): Remove gnulib files.
4336         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4337         (generated_files): Remove GNULIB_H.
4338         ($(LIBGNU), all-lib): Remove targets.
4339         (distclean): Don't mention GNULIB_BUILDDIR.
4340         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4341
4342 2019-06-14  Tom Tromey  <tromey@adacore.com>
4343
4344         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4345         Warn if symbol file does not provide any symbols.
4346
4347 2019-06-14  Tom Tromey  <tromey@adacore.com>
4348
4349         * source.c (find_and_open_source): Respect basenames_may_differ.
4350
4351 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4352
4353         * annotate.c (annotate_breakpoints_invalid): Make use of
4354         scoped_restore_terminal_state.
4355         (annotate_frames_invalid): Likewise.
4356
4357 2019-06-14  Tom Tromey  <tromey@adacore.com>
4358
4359         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4360         allow assignment to an internalvar.
4361
4362 2019-06-14  Tom Tromey  <tromey@adacore.com>
4363
4364         * ada-lex.l: Allow "_" in attribute names.
4365
4366 2019-06-14  Tom Tromey  <tromey@adacore.com>
4367
4368         PR gdb/24653:
4369         * regcache.c (registers_changed): Don't call alloca.
4370         * top.c (execute_command): Don't call alloca.
4371
4372 2019-06-13  Pedro Alves  <palves@redhat.com>
4373
4374         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4375         'expression'.  When parsing an expression, error out if there's
4376         junk after "unlimited".
4377         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4378         (do_set_command): Adjust calls to is_unlimited_literal.
4379
4380 2019-06-13  Pedro Alves  <palves@redhat.com>
4381
4382         * compile/compile.c (make_compile_options_def_group): Add braces
4383         around array_view initializer.
4384         * thread.c (make_thread_apply_all_options_def_group)
4385         (make_thread_apply_all_options_def_group): Likewise.
4386
4387 2019-06-13  Pedro Alves  <palves@redhat.com>
4388
4389         * NEWS (New commands): Mention "maint test-options
4390         require-delimiter", "maint test-options unknown-is-error", "maint
4391         test-options unknown-is-operand" and "maint show
4392         test-options-completion-result".
4393         (New command options, command completion): New section.
4394         (Completion improvements): New section.
4395         Mention that you can abbreviate "unlimited".
4396
4397 2019-06-13  Pedro Alves  <palves@redhat.com>
4398
4399         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4400         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4401         * unittests/cli-utils-selftests.c (test_parse_flags)
4402         (test_parse_flags_qcs): Delete.
4403         (test_cli_utils): Don't call deleted functions.
4404
4405 2019-06-13  Pedro Alves  <palves@redhat.com>
4406
4407         * thread.c: Include "cli/cli-option.h".
4408         (tp_array_compar_ascending): Global.
4409         (tp_array_compar): Delete function.
4410         (tp_array_compar_ascending, tp_array_compar_descending): New
4411         functions.
4412         (ascending_option_def, qcs_flag_option_def)
4413         (thr_qcs_flags_option_defs)
4414         (make_thread_apply_all_options_def_group)
4415         (make_thread_apply_options_def_group): New.
4416         (thread_apply_all_command): Use gdb::option::process_options.
4417         (thread_apply_command_completer)
4418         (thread_apply_all_command_completer): New.
4419         (thread_apply_command): Use gdb::option::process_options.
4420         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4421         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4422         to generate help text of "thread apply".  Adjust "taas"'s help.
4423         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4424         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4425
4426 2019-06-13  Pedro Alves  <palves@redhat.com>
4427
4428         * thread.c (thread_apply_command): Check for invalid TID with
4429         isdigit instead of !isalpha.
4430
4431 2019-06-13  Pedro Alves  <palves@redhat.com>
4432
4433         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4434         (validate_flags_qcs): New.
4435         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4436         (validate_flags_qcs): Declare.
4437         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4438         (make_frame_apply_options_def_group): New.
4439         (frame_apply_command_count): Process options with
4440         gdb::option::process_options.
4441         (frame_apply_completer): New.
4442         (frame_apply_level_completer, frame_apply_all_completer)
4443         (frame_apply_completer): New.
4444         (_initialize_stack): Update help of "frame apply", "frame apply
4445         level", "frame apply all" and "faas" to mention supported options
4446         and install command completers.
4447         * stack.h (frame_apply_all_completer): Declare.
4448         * thread.c: Include "stack.h".
4449         (tfaas_command): Add "--".
4450         (_initialize_thread): Update help "tfaas" to mention supported
4451         options and install command completer.
4452
4453 2019-06-13  Pedro Alves  <palves@redhat.com>
4454
4455         * completer.c (complete_nested_command_line): New.
4456         (gdb_completion_word_break_characters_throw): Add assertion.
4457         * completer.h (complete_nested_command_line): Declare.
4458
4459 2019-06-13  Pedro Alves  <palves@redhat.com>
4460
4461         * stack.c (parse_backtrace_qualifiers): New.
4462         (backtrace_command): Use it.
4463         (backtrace_command_completer): Complete on qualifiers.
4464
4465 2019-06-13  Pedro Alves  <palves@redhat.com>
4466
4467         * frame.c: Include "cli/cli-option.h.
4468         (user_set_backtrace_options): New.
4469         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4470         Delete.
4471         (get_prev_frame): Adjust.
4472         (boolean_option_def, uinteger_option_def)
4473         (set_backtrace_option_defs): New.
4474         (_initialize_frame): Adjust and use
4475         gdb::option::add_setshow_cmds_for_options to install "set
4476         backtrace past-main" and "set backtrace past-entry".
4477         * frame.h: Include "cli/cli-option.h".
4478         (struct frame_print_options): Forward declare.
4479         (print_frame_arguments_all, print_frame_arguments_scalars)
4480         (print_frame_arguments_none): Declare.
4481         (print_entry_values): Delete declaration.
4482         (struct frame_print_options, user_frame_print_options): New.
4483         (struct set_backtrace_options): New.
4484         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4485         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4486         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4487         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4488         (list_args_or_locals): Add frame_print_options parameter.
4489         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4490         * python/py-framefilter.c (enumerate_args): Pass down
4491         USER_FRAME_PRINT_OPTIONS.
4492         * stack.c: Include "cli/cli-option.h".
4493         (print_frame_arguments_all, print_frame_arguments_scalars)
4494         (print_frame_arguments_none): Declare.
4495         (print_raw_frame_arguments, print_entry_values): Delete.
4496         (user_frame_print_options): New.
4497         (boolean_option_def, enum_option_def, frame_print_option_defs):
4498         New.
4499         (struct backtrace_cmd_options): New.
4500         (bt_flag_option_def): New.
4501         (backtrace_command_option_defs): New.
4502         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4503         (print_frame_arg, read_frame_arg, print_frame_args)
4504         (print_frame_info, print_frame): Add frame_print_options parameter
4505         and use it.
4506         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4507         (backtrace_command_1): Add frame_print_options and
4508         backtrace_cmd_options parameters and use them.
4509         (make_backtrace_options_def_group): New.
4510         (backtrace_command): Process command options with
4511         gdb::option::process_options.
4512         (backtrace_command_completer): New.
4513         (_initialize_stack): Extend "backtrace"'s help to mention
4514         supported options.  Install completer for "backtrace".
4515         Install some settings commands with add_setshow_cmds_for_options.
4516
4517 2019-06-13  Pedro Alves  <palves@redhat.com>
4518
4519         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4520         and that "set/show print raw frame-arguments" are now deprecated.
4521
4522         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4523         command.
4524         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4525         * stack.c (_initialize_stack): Install "set/show print
4526         raw-frame-arguments", and deprecate "set/show print raw
4527         frame-arguments".
4528         * valprint.c (_initialize_valprint): Deprecate "set/show print
4529         raw".
4530
4531 2019-06-13  Pedro Alves  <palves@redhat.com>
4532
4533         * compile/compile.c (struct compile_options): New.
4534         (compile_flag_option_def, compile_command_option_defs)
4535         (make_compile_options_def_group): New.
4536         (compile_file_command): Handle options with
4537         gdb::option::process_options.
4538         (compile_file_command_completer): New function.
4539         (compile_code_command): Handle options with
4540         gdb::option::process_options.
4541         (compile_code_command_completer): New function.
4542         (_initialize_compiler): Install completers for "compile code" and
4543         "compile file".  Mention available options in "compile code" and
4544         "compile code"'s help.
4545         * completer.c (advance_to_completion_word): New, factored out from
4546         ...
4547         (advance_to_expression_complete_word_point): ... this.
4548         (advance_to_filename_complete_word_point): New.
4549         * completer.h (advance_to_filename_complete_word_point): New
4550         declaration.
4551
4552 2019-06-13  Pedro Alves  <palves@redhat.com>
4553
4554         * compile/compile.c: Include "cli/cli-option.h".
4555         (compile_print_value): Scope data pointer is now a
4556         value_print_options pointer; adjust.
4557         (compile_print_command): Process options.  Scope data pointer is
4558         now a value_print_options pointer; adjust.
4559         (_initialize_compile): Update "compile print"'s help to include
4560         supported options.  Install a completer for "compile print".
4561         * cp-valprint.c (show_vtblprint, show_objectprint)
4562         (show_static_field_print): Delete.
4563         (_initialize_cp_valprint): Don't install "set print
4564         static-members", "set print vtbl", "set print object" here.
4565         * printcmd.c: Include "cli/cli-option.h" and
4566         "common/gdb_optional.h".
4567         (print_command_parse_format): Rework to fill in a
4568         value_print_options instead of a format_data.
4569         (print_value): Change parameter type from format_data pointer to
4570         value_print_options reference.  Adjust.
4571         (print_command_1): Process options.  Adjust to pass down a
4572         value_print_options.
4573         (print_command_completer): New.
4574         (_initialize_printcmd): Install print_command_completer as
4575         handle_brkchars completer for the "print" command.  Update
4576         "print"'s help to include supported options.
4577         * valprint.c: Include "cli/cli-option.h".
4578         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4579         here from cp-valprint.c.
4580         (boolean_option_def, uinteger_option_def)
4581         (value_print_option_defs, make_value_print_options_def_group):
4582         New.  Use gdb::option::add_setshow_cmds_for_options to install
4583         "set print elements", "set print null-stop", "set print repeats",
4584         "set print pretty", "set print union", "set print array", "set
4585         print address", "set print symbol", "set print array-indexes".
4586         * valprint.h: Include <string> and "cli/cli-option.h".
4587         (make_value_print_options_def_group): Declare.
4588         (print_value): Change parameter type from format_data pointer to
4589         value_print_options reference.
4590         (print_command_completer): Declare.
4591
4592 2019-06-13  Pedro Alves  <palves@redhat.com>
4593
4594         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4595         (COMMON_SFILES): Add maint-test-settings.c.
4596         * cli/cli-decode.c (boolean_enums): New global, factored out from
4597         ...
4598         (add_setshow_boolean_cmd): ... here.
4599         * cli/cli-decode.h (boolean_enums): Declare.
4600         * cli/cli-option.c: New file.
4601         * cli/cli-option.h: New file.
4602         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4603         factored out from ...
4604         (parse_cli_boolean_value(const char *)): ... this.
4605         (is_unlimited_literal): Change parameter type to pointer to
4606         pointer.  Adjust and advance ARG pointer.
4607         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4608         (parse_cli_var_enum): New, factored out from ...
4609         (do_set_command): ... this.  Adjust.
4610         * cli/cli-setshow.h (parse_cli_boolean_value)
4611         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4612         (parse_cli_var_enum): Declare.
4613         * cli/cli-utils.c: Include "cli/cli-option.h".
4614         (get_ulongest): New.
4615         * cli/cli-utils.h (get_ulongest): Declare.
4616         (check_for_argument): New overloads.
4617         * maint-test-options.c: New file.
4618
4619 2019-06-13  Pedro Alves  <palves@redhat.com>
4620
4621         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4622         parse a range if "-" is at the end of the string.
4623
4624 2019-06-13  Pedro Alves  <palves@redhat.com>
4625
4626         * cli/cli-setshow.c (parse_auto_binary_operation)
4627         (parse_cli_boolean_value): Don't allow "o".
4628
4629 2019-06-13  Pedro Alves  <palves@redhat.com>
4630
4631         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4632         * NEWS: Mention maint test-settings KIND.
4633         * maint-test-settings.c: New file.
4634
4635 2019-06-13  Pedro Alves  <palves@redhat.com>
4636
4637         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4638         completer.
4639         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4640         "set" completers.
4641
4642 2019-06-13  Pedro Alves  <palves@redhat.com>
4643
4644         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4645         after item.
4646
4647 2019-06-13  Pedro Alves  <palves@redhat.com>
4648
4649         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4650
4651 2019-06-13  Pedro Alves <palves@redhat.com>
4652
4653         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4654         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4655         call.
4656         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4657         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4658         calls.
4659         (check_for_argument): Skip spaces after argument.
4660
4661 2019-06-13  Pedro Alves  <palves@redhat.com>
4662
4663         * thread.c (thread_apply_command): Adjust TID parsing.
4664         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4665         detected before end of string.
4666         (tid_is_in_list): Error out if LIST is invalid.
4667
4668 2019-06-13  Pedro Alves  <palves@redhat.com>
4669
4670         * completer.c (complete_line_internal_1): Rewind completion word
4671         point.
4672         (completion_tracker::advance_custom_word_point_by): Change
4673         parameter type to int.
4674         * completer.h (completion_tracker::advance_custom_word_point_by):
4675         Likewise.
4676
4677 2019-06-13  Pedro Alves  <palves@redhat.com>
4678
4679         * completer.c (advance_to_completion_word): Handle delimiters.
4680
4681 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4682
4683         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4684
4685 2019-06-11  Tom Tromey  <tom@tromey.com>
4686
4687         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4688         (xmalloc_failed): Move to alloc.c.
4689         * alloc.c: New file.
4690         * Makefile.in (COMMON_SFILES): Add alloc.c.
4691
4692 2019-06-11  Tom Tromey  <tom@tromey.com>
4693
4694         * nat/linux-waitpid.c: Don't include server.h.
4695         (linux_debug): Remove.
4696         (my_waitpid): Update.
4697
4698 2019-06-11  Tom Tromey  <tromey@adacore.com>
4699
4700         * infcall.c (_initialize_infcall): Remove trailing newline from
4701         help.
4702         * user-regs.c (_initialize_user_regs): Remove trailing newline
4703         from help.
4704         * typeprint.c (_initialize_typeprint): Remove trailing newline
4705         from help.
4706         * reverse.c (_initialize_reverse): Remove trailing newlines from
4707         help.
4708         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4709         from help.
4710         * language.c (add_set_language_command): Remove trailing newline
4711         from help.
4712         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4713         help.
4714         * disasm.c (_initialize_disasm): Remove trailing newline from
4715         help.
4716         * top.c (init_main): Remove trailing newline from help.
4717         * interps.c (_initialize_interpreter): Remove trailing newline
4718         from help.
4719         * btrace.c (_initialize_btrace): Remove trailing newlines from
4720         help.
4721         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4722         from help.
4723         * python/python.c (_initialize_python): Remove trailing newline
4724         from help.
4725         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4726         help.
4727         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4728         from help.  Reformat some text.
4729         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4730         from help.
4731         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4732         newline from help.
4733
4734 2019-06-11  Tom Tromey  <tromey@adacore.com>
4735
4736         * darwin-nat.c (darwin_decode_exception_message)
4737         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4738
4739 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4740
4741         * valops.c (value_slice): Check for not allocated or not
4742         associated values.
4743
4744 2019-06-10  Tom de Vries  <tdevries@suse.de>
4745
4746         PR gdb/24618
4747         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4748         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4749         invalid.
4750
4751 2019-06-10  Tom de Vries  <tdevries@suse.de>
4752
4753         PR gdb/24611
4754         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4755         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4756
4757 2019-06-10  Tom de Vries  <tdevries@suse.de>
4758
4759         PR symtab/24545
4760         * symtab.c (struct demangled_name_entry): Add language field.
4761         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4762         static minimal symbol".  Set and use language field.
4763
4764 2019-06-10  Tom Tromey  <tromey@adacore.com>
4765
4766         * ada-lang.c (_initialize_ada_language): Update help text.
4767
4768 2019-06-10  Tom Tromey  <tromey@adacore.com>
4769
4770         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4771         with a newline.
4772         * guile/guile.c (handle_boot_error): Don't end warning with a
4773         newline.
4774         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4775         warning with a newline.
4776         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4777         newline.
4778         (s12z_frame_cache): Likewise.
4779         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4780         a newline.
4781         * solib-svr4.c (disable_probes_interface): Don't end warning with
4782         a newline.
4783         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4784         newline.
4785         * python/python.c (do_finish_initialization): Don't end warning
4786         with a newline.
4787
4788 2019-06-10  Tom Tromey  <tom@tromey.com>
4789
4790         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4791         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4792         gdbpy_enter.
4793
4794 2019-06-10  Tom Tromey  <tromey@adacore.com>
4795
4796         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4797         data.
4798         (elf_new_init): Don't call stabsread_new_init.
4799         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4800         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4801         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4802
4803 2019-06-10  Tom de Vries  <tdevries@suse.de>
4804
4805         PR symtab/16264
4806         PR symtab/24517
4807         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4808
4809 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4810
4811         * source.c (find_and_open_source): Also rewrite relative file
4812         names.
4813
4814 2019-04-26  Amos Bird  <amosbird@gmail.com>
4815
4816         * annotate.c (annotate_thread_exited): Add "thread-exited"
4817         annotation.
4818
4819 2019-06-06  Tom Tromey  <tromey@adacore.com>
4820
4821         * maint.h (class scoped_command_stats): Use
4822         DISABLE_COPY_AND_ASSIGN.
4823         <print_time>: New method.
4824         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4825         print_time.
4826         (scoped_command_stats::print_time): New method.
4827
4828 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4829
4830         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4831         instructions of lengths 6 or 8 bytes.
4832
4833 2019-06-04  Pedro Alves  <palves@redhat.com>
4834
4835         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4836
4837         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4838         * breakpoint.c (condition_completer): Likewise.
4839         * cli/cli-dump.c (scan_expression): Likewise.
4840         * common/filestuff.c (mkdir_recursive): Likewise.
4841         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4842         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4843         (gdb_abspath): Likewise.
4844         * compile/compile-cplus-types.c
4845         (compile_cplus_instance::decl_name): Likewise.
4846         * completer.c (complete_explicit_location):
4847         (signal_completer, reg_or_group_completer_1): Likewise.
4848         * cp-support.c (cp_remove_params_if_any): Likewise.
4849         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4850         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4851         * infcmd.c (strip_bg_char): Likewise.
4852         * linespec.c (copy_token_string): Likewise.
4853         * mi/mi-main.c (output_cores): Likewise.
4854         * psymtab.c (psymtab_search_name):
4855         * symfile.c (test_set_ext_lang_command): Likewise.
4856         * target.c (target_fileio_read_stralloc): Likewise.
4857         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4858         * value.c (complete_internalvar): Likewise.
4859
4860 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4861
4862         Add objfile property to gdb.Type.
4863         * NEWS: Mention Python API addition.
4864         * python/py-type.c (typy_get_objfile): New method.
4865
4866 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4867
4868         * NEWS: Mention the new set|show style [title|highlight].
4869         Mention changes to "show style", "help" and "apropos".
4870
4871 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4872
4873         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4874         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4875         instead of print_help_for_command.
4876         (print_doc_of_command): New function.
4877         (help_list): Add 'apropos -v word' suggestion.
4878         (print_help_for_command): Style the command name using title style.
4879         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4880         (_initialize_cli_cmds): Describe -v in apropos_command help.
4881
4882 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4883
4884         * cli/cli-style.h (cli_style_option): Add name in constructor,
4885         add m_name class member, add constructor with intensity,
4886         add name class function.
4887         (cli_style_option::add_setshow_commands): Remove name argument.
4888         (highlight_style, title_style): New styles.
4889         * cli/cli-style.c (do_show): New function that shows a style
4890         characteristic styling the style name with itself.
4891         (set_style_name): New function.
4892         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4893         Update all callers according to the changes in cli/cli-style.h.
4894         * utils.h (fputs_highlighted): New function.
4895         * utils.c (fputs_highlighted): Likewise.
4896
4897 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4898
4899         * NEWS: Mention new pipe command and new convenience variables.
4900
4901 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4902
4903         * cli/cli-cmds.c (pipe_command): New function.
4904         (_initialize_cli_cmds): Call add_com for pipe_command.
4905         Define | as an alias for pipe.
4906         (exit_status_set_internal_vars): New function.
4907         (shell_escape): Call exit_status_set_internal_vars.
4908         cli/cli-decode.c (find_command_name_length): Recognize | as
4909         a single character command.
4910
4911 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4912
4913         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4914         top.c (execute_command_to_ui_file): New function, mostly a copy
4915         of execute_command_to_string.
4916         (execute_command_to_string): Implement by calling
4917         execute_command_to_ui_file.
4918
4919 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4920
4921         * top.h (saved_command_line): Remove declaration.
4922         * top.c (previous_saved_command_line, previous_repeat_arguments):
4923         New variables.
4924         (saved_command_line): Make static, define together with other
4925         'repeat variables'.
4926         (dont_repeat): Clear repeat_arguments.
4927         (repeat_previous, get_saved_command_line, save_command_line):
4928         New functions.
4929         (gdb_init): Initialize saved_command_line
4930         and previous_saved_command_line.
4931         * main.c (captured_main_1): Remove saved_command_line initialization.
4932         * event-top.c (handle_line_of_input): Update to use
4933         the new 'repeat' related functions instead of direct access to
4934         saved_command_line.
4935         * command.h (repeat_previous, get_saved_command_line,
4936         save_command_line): New declarations.
4937         (dont_repeat): Add comment.
4938
4939 2019-05-30  Tom Tromey  <tromey@adacore.com>
4940
4941         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4942         Fix comment.
4943         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4944
4945 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4946
4947         PR cli/24587
4948         * completer.c (complete): Initialize variable word.
4949
4950 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4951
4952         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4953         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4954         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4955         'body' is NULL to the outter 'if', protecting the '!is_define'
4956         situation as well.
4957
4958 2019-05-29  Tom Tromey  <tromey@adacore.com>
4959
4960         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4961         (dwarf_unknown): New function.
4962         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4963         (dwarf_type_encoding_name): Use dwarf_unknown.
4964
4965 2019-05-29  Tom Tromey  <tromey@adacore.com>
4966
4967         PR c++/20020:
4968         * cp-valprint.c (cp_print_value_fields): Call
4969         cp_print_static_field inside "try".
4970
4971 2019-05-29  Tom Tromey  <tromey@adacore.com>
4972
4973         * inflow.c (struct terminal_info): Add default operator=.
4974         * configure: Rebuild.
4975         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4976         -Wdeprecated-copy-dtor, -Wredundant-move.
4977
4978 2019-05-29  Tom Tromey  <tromey@adacore.com>
4979
4980         * NEWS: Add entry.
4981         * infcmd.c (print_return_value_1): Handle finish_print
4982         option.
4983         (show_print_finish): New function.
4984         (_initialize_infcmd): Add "set/show print finish" commands.
4985         * valprint.c (user_print_options): Initialize new member.
4986         * valprint.h (struct value_print_options) <finish_print>: New
4987         member.
4988
4989 2019-05-28  Tom Tromey  <tromey@adacore.com>
4990
4991         * ada-lang.c (ada_remove_Xbn_suffix)
4992         (find_old_style_renaming_symbol)
4993         (parse_old_style_renaming): Remove.
4994         (ada_find_renaming_symbol): Don't call
4995         find_old_style_renaming_symbol.
4996         (ada_is_renaming_symbol): Rename from
4997         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4998         bool.  Now static.
4999         (ada_read_var_value): Update and simplify.
5000         * ada-exp.y (write_var_or_type): Remove old code.
5001
5002 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5003
5004         * event-top.c: Remove include comment.
5005         * inflow.c (class scoped_ignore_sigttou): Move from here...
5006         * inflow.h (class scoped_ignore_sigttou): ...to here.
5007         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5008         * top.c:  Remove include comment.
5009
5010 2019-05-27  Tom Tromey  <tom@tromey.com>
5011
5012         * NEWS: Fix typo.
5013
5014 2019-05-22  Tom Tromey  <tromey@adacore.com>
5015
5016         * target.c (target_follow_exec): Constify parameter.
5017         * target-delegates.c: Rebuild.
5018         * remote.c (remote_target::follow_exec): Constify parameter.
5019         * infrun.c (follow_exec): Constify parameter.
5020         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5021         (target_follow_exec): Likewise.
5022
5023 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5024
5025         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5026         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5027
5028 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5029
5030         * NEWS: Add debugredirect and testsuite sections.
5031
5032 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5033
5034         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5035         target descriptions using exclusively floating point register name
5036         aliases.
5037
5038 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5039
5040         PR gdb/18644:
5041         * f-lang.c (build_fortran_types): Handle the case where
5042         gdbarch_floatformat_for_type returns a nullptr.
5043
5044 2019-05-21  Tom de Vries  <tdevries@suse.de>
5045
5046         PR cli/24587
5047         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5048
5049 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         PR gdb/18644:
5052         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5053         16-byte floats.
5054         * i386-tdep.c (i386_floatformat_for_type): Use
5055         floatformats_ia64_quad for the 16-byte floating point component
5056         within a fortran 32-byte complex number.
5057
5058 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5061         delete default constructor.
5062         (find_partial_die): Update to return const struct.
5063         (partial_die_parent_scope): Move variable declaration into scope
5064         of its use and change its type to auto.
5065         (guess_partial_die_structure_name): Likewise.
5066         (partial_die_info::fixup): Likewise.
5067
5068 2019-05-17  Tom Tromey  <tromey@adacore.com>
5069
5070         * source.c (find_and_open_source): Remove cast.
5071
5072 2019-05-17  Tom Tromey  <tromey@adacore.com>
5073
5074         * annotate.c (annotate_source): Make "filename" const.
5075         * annotate.h (annotate_source): Use const.
5076
5077 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5078
5079         * disasm.c (set_disassembler_options): Send errors to stderr.
5080
5081 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5082
5083         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5084         (cli_interp_base::set_logging): Check debug_redirect.
5085         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5086         * cli/cli-logging.c (debug_redirect): Add static variable.
5087         (pop_output_files): Add default param.
5088         (handle_redirections): Print debug setting.
5089         (show_logging_command): Likewise.
5090         (_initialize_cli_logging): Add debugredirect command.
5091         * interps.c (current_interp_set_logging): Add debug_redirect
5092         parameter.
5093         * interps.h (set_logging): Add debug_redirect parameter.
5094         (current_interp_set_logging): Likewise.
5095         * mi/mi-common.h: Likewise.
5096         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5097
5098 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5099             Tom Tromey  <tromey@adacore.com>
5100
5101         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5102         directly.
5103         * cli/cli-interp.h (make_logging_output): Remove declaration.
5104         * cli/cli-logging.c (make_logging_output): Remove function.
5105         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5106         directly.
5107         * ui-file.c (tee_file::tee_file): Remove bools.
5108         (tee_file::~tee_file): Remove deletes.
5109         * ui-file.h (tee_file): Remove bools.
5110
5111 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5112
5113         * mi/mi-cmds.h (mi_cmd_complete): New function.
5114         * mi/mi-main.c (mi_cmd_complete): Likewise.
5115         * mi/mi-cmds.c: Define new MI command -complete.
5116         * NEWS: Mention new -complete command.
5117
5118 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5119
5120         * completer.h (complete): New function.
5121         * completer.c (complete): Likewise.
5122         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5123         function defined in completer.h.
5124
5125 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5126
5127         * MAINTAINERS (Write After Approval): Add myself.
5128
5129 2019-05-17  Tom de Vries  <tdevries@suse.de>
5130
5131         PR gdb/24094
5132         * dwarf2read.c (struct cu_partial_die_info): New struct.
5133         (find_partial_die): Return cu_partial_die_info.
5134         (partial_die_parent_scope, guess_partial_die_structure_name)
5135         (partial_die_info::fixup): Handle new return type of find_partial_die.
5136
5137 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5138
5139         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5140         "std::string", simplifying the algorithm.
5141
5142 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5143
5144         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5145         (stap_static_probe_ops::get_probes): Likewise.
5146
5147 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5148
5149         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5150         '-')" and "else if".
5151         (stap_parse_single_operand): Join checks for
5152         "gdbarch_stap_parse_special_token_p" and
5153         "gdbarch_stap_parse_special_token" in the same "if" statement.
5154         Invert check when verifying for operation on register
5155         displacement.
5156
5157 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5158
5159         * stap-probe.c (stap_get_opcode): Update comment.
5160         (stap_get_expected_argument_type): Likewise.
5161         (handle_stap_probe): Likewise.
5162
5163 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5164
5165         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5166         return type to 'bool'.  Adjust comment.  Use 'bool' when
5167         appropriate.
5168         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5169         * stap-probe.c (stap_parse_argument_1): Likewise.
5170         (stap_is_operator): Likewise.
5171         (stap_is_generic_prefix): Likewise.
5172         (stap_is_register_prefix): Likewise.
5173         (stap_is_register_indirection_prefix): Likewise.
5174         (stap_is_integer_prefix): Likewise.
5175         (stap_generic_check_suffix): Likewise.
5176         (stap_check_integer_suffix): Likewise.
5177         (stap_check_register_suffix): Likewise.
5178         (stap_check_register_indirection_suffix): Likewise.
5179         (stap_parse_register_operand): Likewise.
5180         (stap_parse_single_operand): Likewise.
5181         (stap_parse_argument_1): Likewise.
5182         (stap_probe::get_argument_count): Likewise.
5183         (stap_is_operator): Likewise.
5184
5185 2019-05-16  Tom Tromey  <tromey@adacore.com>
5186
5187         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5188         keyword to foreach.
5189
5190 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5191
5192         * linux-thread-db.c (try_thread_db_load_1): Change return type
5193         to bool.
5194         (try_thread_db_load): Likewise.
5195         (try_thread_db_load_from_pdir_1): Likewise.
5196         (try_thread_db_load_from_pdir): Likewise.
5197         (try_thread_db_load_from_sdir): Likewise.
5198         (try_thread_db_load_from_dir): Likewise.
5199         (thread_db_load_search): Likewise.
5200         (has_libpthread): Likewise.
5201         (thread_db_load): Likewise.
5202
5203 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5204
5205         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5206         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5207         NULL, and complain/return if that's the case.
5208
5209 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5210
5211         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5212         (advance, posn, abstract_read_memory): New functions.
5213         [struct mem_read_abstraction]: New struct.
5214         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5215
5216 2019-05-14  Tom Tromey  <tromey@adacore.com>
5217
5218         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5219         value is not lval_memory.
5220
5221 2019-05-14  Tom Tromey  <tromey@adacore.com>
5222
5223         * solib.c (info_sharedlibrary_command): Style the file name.
5224
5225 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5226
5227         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5228         (aarch64_vnv_type): Likewise.
5229         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5230         * common/tdesc.c: Likewise.
5231         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5232         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5233         * features/aarch64-fpu.xml: Add ieee half view.
5234         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5235         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5236         * gdbtypes.h (struct builtin_type): Likewise.
5237         (struct objfile_type): Likewise.
5238
5239 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5240
5241         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5242         typo.
5243         * location.h (string_to_event_location): Likewise.
5244
5245 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5246
5247         GDB 8.3 released.
5248
5249 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5250
5251         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5252         New variable declaration.
5253         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5254         New variable.
5255         (print_one_breakpoint): Use ui_out::test_flags and new global
5256         variable to compute use_fixed_output.
5257         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5258         Remove.
5259         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5260         (mi_multi_location_breakpoint_output_fixed): Remove.
5261         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5262         new variable.
5263         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5264         fix_multi_location_breakpoint_output flag if version >= 3.
5265         * ui-out.h (enum ui_out_flag)
5266         <fix_multi_location_breakpoint_output>: New enumerator.
5267
5268 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5269
5270         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5271
5272 2019-05-10  Tom Tromey  <tromey@adacore.com>
5273
5274         * ada-lang.c (catch_ada_completer): New function.
5275         (_initialize_ada_language): Use it.
5276
5277 2019-05-10  Tom Tromey  <tromey@adacore.com>
5278
5279         * thread.c (print_thread_info): Make "requested_threads" const.
5280         * gdbthread.h (print_thread_info): Make "requested_threads"
5281         const.
5282         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5283         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5284
5285 2019-05-08  Tom Tromey  <tom@tromey.com>
5286
5287         * gdbtypes.c (objfile_type_data): Change type.
5288         (objfile_type, _initialize_gdbtypes): Update.
5289
5290 2019-05-08  Tom Tromey  <tom@tromey.com>
5291
5292         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5293         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5294         (_initialize_dwarf2_frame): Update.
5295
5296 2019-05-08  Tom Tromey  <tom@tromey.com>
5297
5298         * objc-lang.c (objc_objfile_data): Change type.
5299         (find_methods): Update.
5300         (_initialize_objc_lang): Remove.
5301
5302 2019-05-08  Tom Tromey  <tom@tromey.com>
5303
5304         * stabsread.c (rs6000_builtin_type_data): Change type.
5305         (rs6000_builtin_type, _initialize_stabsread): Update.
5306
5307 2019-05-08  Tom Tromey  <tom@tromey.com>
5308
5309         * mips-tdep.c (mips_pdr_data): Remove.
5310         (_initialize_mips_tdep): Update.
5311
5312 2019-05-08  Tom Tromey  <tom@tromey.com>
5313
5314         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5315         (hppa_init_objfile_priv_data, read_unwind_info)
5316         (find_unwind_entry, _initialize_hppa_tdep): Update.
5317
5318 2019-05-08  Tom Tromey  <tom@tromey.com>
5319
5320         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5321         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5322         on obstack.
5323         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5324
5325 2019-05-08  Tom Tromey  <tom@tromey.com>
5326
5327         * mdebugread.c (basic_type_data): Change type.
5328         (basic_type, _initialize_mdebugread): Update.
5329
5330 2019-05-08  Tom Tromey  <tom@tromey.com>
5331
5332         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5333
5334 2019-05-08  Tom Tromey  <tom@tromey.com>
5335
5336         * nto-tdep.c (nto_inferior_data_reg): Change type.
5337         (nto_inferior_data): Update.
5338         (nto_inferior_data_cleanup, nto_new_inferior_data)
5339         (_initialize_nto_tdep): Remove.
5340         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5341
5342 2019-05-08  Tom Tromey  <tom@tromey.com>
5343
5344         * ada-lang.c (struct ada_inferior_data): Add initializers.
5345         (ada_inferior_data): Change type.
5346         (ada_inferior_data_cleanup): Remove.
5347         (get_ada_inferior_data, ada_inferior_exit)
5348         (struct ada_pspace_data): Add initializers, destructor.
5349         (ada_pspace_data_handle): Change type.
5350         (get_ada_pspace_data): Update.
5351         (ada_pspace_data_cleanup): Remove.
5352
5353 2019-05-08  Tom Tromey  <tom@tromey.com>
5354
5355         * coffread.c (struct coff_symfile_info): Add initializers.
5356         (coff_objfile_data_key): Move lower.  Change type.
5357         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5358         Update.
5359         (coff_free_info): Remove.
5360
5361 2019-05-08  Tom Tromey  <tom@tromey.com>
5362
5363         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5364         (fbsd_pspace_data_handle): Move lower.  Change type.
5365         (get_fbsd_pspace_data): Update.
5366         (fbsd_pspace_data_cleanup): Remove.
5367         (_initialize_fbsd_tdep): Update.
5368
5369 2019-05-08  Tom Tromey  <tom@tromey.com>
5370
5371         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5372         (get_ada_tasks_pspace_data): Update.
5373         (ada_tasks_pspace_data_cleanup): Remove.
5374         (_initialize_tasks): Update.
5375         (ada_tasks_inferior_data_handle): Change type.
5376         (get_ada_tasks_inferior_data): Update.
5377         (ada_tasks_inferior_data_cleanup): Remove.
5378         (struct ada_tasks_pspace_data): Add initializers.
5379
5380 2019-05-08  Tom Tromey  <tom@tromey.com>
5381
5382         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5383         * symfile-debug.c (debug_sym_get_probes): Change type.
5384         * stap-probe.c (handle_stap_probe):
5385         (stap_static_probe_ops::get_probes): Change type.
5386         * probe.h (class static_probe_ops) <get_probes>: Change type.
5387         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5388         (parse_probes_in_pspace): Update.
5389         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5390         Update.
5391         (any_static_probe_ops::get_probes): Change type.
5392         * elfread.c (elfread_data): New typedef.
5393         (probe_key): Change type.
5394         (elf_get_probes): Likewise.  Update.
5395         (probe_key_free): Remove.
5396         (_initialize_elfread): Update.
5397         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5398         Change type.
5399         (dtrace_process_dof_probe, dtrace_process_dof)
5400         (dtrace_static_probe_ops::get_probe): Change type.
5401
5402 2019-05-08  Tom Tromey  <tom@tromey.com>
5403
5404         * xcoffread.c (struct xcoff_symfile_info): Rename from
5405         coff_symfile_info.  Add initializers.
5406         (xcoff_objfile_data_key): Move lower.  Change type.
5407         (XCOFF_DATA): Rewrite.
5408         (xcoff_free_info): Remove.
5409         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5410         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5411         (xcoff_initial_scan): Update.
5412
5413 2019-05-08  Tom Tromey  <tom@tromey.com>
5414
5415         * solib-svr4.c (struct svr4_info): Add initializers and
5416         destructor.
5417         <probes_table>: Now an htab_up.
5418         (solib_svr4_pspace_data): Change type.
5419         (free_probes_table): Simplify.
5420         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5421         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5422         (probes_table_remove_objfile_probes, register_solib_event_probe)
5423         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5424         (_initialize_svr4_solib): Update.
5425
5426 2019-05-08  Tom Tromey  <tom@tromey.com>
5427
5428         * remote.c (remote_pspace_data): Change type.
5429         (remote_pspace_data_cleanup): Remove.
5430         (get_remote_exec_file, set_pspace_remote_exec_file)
5431         (_initialize_remote): Update.
5432
5433 2019-05-08  Tom Tromey  <tom@tromey.com>
5434
5435         * breakpoint.c (breakpoint_objfile_key): Change type.
5436         (get_breakpoint_objfile_data): Update.
5437         (free_breakpoint_objfile_data): Remove.
5438         (_initialize_breakpoint): Update.
5439
5440 2019-05-08  Tom Tromey  <tom@tromey.com>
5441
5442         * linux-tdep.c (struct linux_info): Add initializers.
5443         (linux_inferior_data): Move.  Change type.
5444         (invalidate_linux_cache_inf): Update.
5445         (linux_inferior_data_cleanup): Remove.
5446         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5447
5448 2019-05-08  Tom Tromey  <tom@tromey.com>
5449
5450         * auxv.c (auxv_inferior_data): Move.  Change type.
5451         (auxv_inferior_data_cleanup): Remove.
5452         (invalidate_auxv_cache_inf): Rewrite.
5453         (get_auxv_inferior_data, _initialize_auxv): Update.
5454
5455 2019-05-08  Tom Tromey  <tom@tromey.com>
5456
5457         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5458         (symfile_debug_objfile_data_key): Change type.
5459         (symfile_debug_installed, debug_qf_has_symbols)
5460         (debug_qf_find_last_source_symtab)
5461         (debug_qf_forget_cached_source_info)
5462         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5463         (debug_qf_print_stats, debug_qf_dump)
5464         (debug_qf_expand_symtabs_for_function)
5465         (debug_qf_expand_all_symtabs)
5466         (debug_qf_expand_symtabs_with_fullname)
5467         (debug_qf_map_matching_symbols)
5468         (debug_qf_expand_symtabs_matching)
5469         (debug_qf_find_pc_sect_compunit_symtab)
5470         (debug_qf_map_symbol_filenames)
5471         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5472         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5473         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5474         (debug_sym_read_linetable, debug_sym_relocate): Update.
5475         (symfile_debug_free_objfile): Remove.
5476         (install_symfile_debug_logging, _initialize_symfile_debug):
5477         Update.
5478
5479 2019-05-08  Tom Tromey  <tom@tromey.com>
5480
5481         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5482         allocate_on_obstack.
5483         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5484         (get_dwarf2_per_objfile): Update.
5485         (set_dwarf2_per_objfile): Remove.
5486         (dwarf2_has_info, dwarf2_get_section_info): Update.
5487         (dwarf2_free_objfile): Remove.
5488         (_initialize_dwarf2_read): Update.
5489
5490 2019-05-08  Tom Tromey  <tom@tromey.com>
5491
5492         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5493         initializers.
5494         <unsupported_script_warning_printed,
5495         script_not_found_warning_printed>: Now bool.
5496         (auto_load_pspace_data): Change type.
5497         (~auto_load_pspace_info): Rename from
5498         auto_load_pspace_data_cleanup.
5499         (get_auto_load_pspace_data, init_loaded_scripts_info)
5500         (clear_section_scripts, maybe_print_unsupported_script_warning)
5501         (maybe_print_script_not_found_warning, _initialize_auto_load):
5502         Update.
5503
5504 2019-05-08  Tom Tromey  <tom@tromey.com>
5505
5506         * objfiles.c (objfile_pspace_info): Add destructor and
5507         initializers.
5508         (objfiles_pspace_data): Change type.
5509         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5510         (get_objfile_pspace_data): Update.
5511         (objfiles_bfd_data): Change type.
5512         (get_objfile_bfd_data): Update.
5513         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5514
5515 2019-05-08  Tom Tromey  <tom@tromey.com>
5516
5517         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5518         Change type.
5519         (get_catch_syscall_inferior_data): Update.
5520         (catch_syscall_inferior_data_cleanup): Remove.
5521         (_initialize_break_catch_syscall): Update.
5522
5523 2019-05-08  Tom Tromey  <tom@tromey.com>
5524
5525         * inflow.c (struct terminal_info): Add destructor and
5526         initializers.
5527         (inflow_inferior_data): Change type.
5528         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5529         (get_inflow_inferior_data, inflow_inferior_exit)
5530         (swap_terminal_info, _initialize_inflow): Update.
5531
5532 2019-05-08  Tom Tromey  <tom@tromey.com>
5533
5534         * target-dcache.c (target_dcache_cleanup): Remove.
5535         (target_dcache_aspace_key): Change type.
5536         (target_dcache_init_p, target_dcache_invalidate)
5537         (target_dcache_get, target_dcache_get_or_init)
5538         (_initialize_target_dcache): Update.
5539         * dcache.h (struct dcache_deleter): New.
5540
5541 2019-05-08  Tom Tromey  <tom@tromey.com>
5542
5543         * symtab.c (struct symbol_cache): Add destructor and
5544         initializers.
5545         (symbol_cache_key): Move.  Change type.
5546         (make_symbol_cache, free_symbol_cache): Remove.
5547         (get_symbol_cache): Update.
5548         (symbol_cache_cleanup): Remove.
5549         (ALL_PSPACES, symbol_cache_flush)
5550         (maintenance_print_symbol_cache)
5551         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5552         Update.
5553
5554 2019-05-08  Tom Tromey  <tom@tromey.com>
5555
5556         * symtab.c (struct main_info): Add destructor and initializers.
5557         (main_progspace_key): Move.  Change type.
5558         (get_main_info): Update.
5559         (main_info_cleanup): Remove.
5560         (_initialize_symtab): Update.
5561
5562 2019-05-08  Tom Tromey  <tom@tromey.com>
5563
5564         * registry.h (DECLARE_REGISTRY): Define the _key class.
5565
5566 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5567
5568         * NEWS: Merge two 'New commands' sections.
5569
5570 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5571
5572         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5573         parameter and use Ada language definition instead.
5574         (ada_val_print_ptr): Remove unused language parameter.
5575         (ada_val_print_num): Remove language parameter and use Ada language
5576         definition instead.
5577         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5578         parameter.
5579         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5580         parameter and use Ada language definition instead.
5581         (ada_val_print_1): Update all ada_val_print_xxx calls.
5582         Remove language parameter.
5583         (ada_val_print): Update ada_val_print_1 call.
5584
5585 2019-05-08  Tom Tromey  <tromey@adacore.com>
5586
5587         * remote.c (remote_hw_watchpoint_limit)
5588         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5589         Now static.
5590
5591 2019-05-08  Tom Tromey  <tromey@adacore.com>
5592
5593         * maint.c (_initialize_maint_cmds): Move initialization code to
5594         remote.c.
5595         (watchdog, show_watchdog): Move to remote.c.
5596         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5597         "watchdog" static.
5598         (_initialize_remote): Move initialization code from maint.c.
5599         * defs.h (watchdog): Don't declare.
5600
5601 2019-05-08  Tom Tromey  <tromey@adacore.com>
5602
5603         * tui/tui-interp.c: Include main.h.
5604         * interps.c: Include main.h.
5605         * main.h (interpreter_p): Declare.
5606         * defs.h (interpreter_p): Don't declare.
5607
5608 2019-05-08  Tom Tromey  <tromey@adacore.com>
5609
5610         * dwarf2loc.c: Include dwarf2read.h.
5611         * defs.h (read_unsigned_leb128): Don't declare.
5612         * dwarf2read.h (read_unsigned_leb128): Declare.
5613
5614 2019-05-08  Tom Tromey  <tromey@adacore.com>
5615
5616         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5617         method.
5618
5619 2019-05-08  Tom Tromey  <tromey@adacore.com>
5620
5621         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5622         when no wrap column is set.
5623
5624 2019-05-08  Tom Tromey  <tromey@adacore.com>
5625
5626         * c-lang.c (c_get_string): Handle non-C-style arrays.
5627
5628 2019-05-08  Tom Tromey  <tromey@adacore.com>
5629
5630         * typeprint.c (print_offset_data::update): Print the bit offset,
5631         not the number of bits remaining.
5632
5633 2019-05-08  Tom Tromey  <tromey@adacore.com>
5634
5635         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5636         padding at end of comment.
5637
5638 2019-05-08  Tom Tromey  <tromey@adacore.com>
5639
5640         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5641         Compare main types.
5642
5643 2019-05-06  Tom Tromey  <tom@tromey.com>
5644
5645         * common/scoped_mmap.c: Include common-defs.h.
5646         * common/scoped_mmap.h: Don't include config.h.
5647
5648 2019-05-04  Tom Tromey  <tom@tromey.com>
5649
5650         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5651         (struct aarch64_call_info): Add initializers.
5652         <si>: Now a std::vector.
5653         (pass_on_stack, aarch64_push_dummy_call): Update.
5654
5655 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5656             Tom Tromey  <tom@tromey.com>
5657
5658         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5659         (ppc_threads): Now a std::vector.  Now static.
5660         (hwdebug_find_thread_points_by_tid)
5661         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5662         Update.
5663
5664 2019-05-04  Tom Tromey  <tom@tromey.com>
5665
5666         * arc-tdep.c (arc_tdesc_init): Return bool.
5667
5668 2019-05-04  Tom Tromey  <tom@tromey.com>
5669
5670         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5671         Use gdb_assert_not_reached.
5672
5673 2019-05-04  Tom Tromey  <tom@tromey.com>
5674
5675         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5676         "false".
5677
5678 2019-05-04  Tom Tromey  <tom@tromey.com>
5679
5680         * arc-tdep.c (arc_tdesc_init): Use bool.
5681
5682 2019-05-04  Tom Tromey  <tom@tromey.com>
5683
5684         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5685
5686 2019-05-04  Tom Tromey  <tom@tromey.com>
5687
5688         * cli/cli-cmds.c (valid_command_p): Return bool.
5689
5690 2019-05-04  Tom Tromey  <tom@tromey.com>
5691
5692         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5693         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5694
5695 2019-05-04  Raul Tambre  <raul@tambre.ee>
5696
5697         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5698         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5699         operator for comparison.
5700
5701 2019-05-04  Tom Tromey  <tom@tromey.com>
5702
5703         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5704         (lookup_partial_symbol, print_partial_symbols)
5705         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5706         (psymbol_compare): Update.
5707         (add_psymbol_to_bcache): Clear the entire psymbol.
5708         (maintenance_check_psymtabs): Update.
5709         * psympriv.h (struct partial_symbol): Don't derive from
5710         general_symbol_info.
5711         <obj_section, unrelocated_address, address,
5712         set_unrelocated_address>: Update.
5713         <ginfo>: New member.
5714         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5715         (debug_names::write_psymbols): Update.
5716
5717 2019-05-04  Tom de Vries  <tdevries@suse.de>
5718
5719         * contrib/cc-with-tweaks.sh: Support -n arg.
5720
5721 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5722
5723         * corelow.c (core_target::detach): Ensure frame cache and
5724         register caches are cleared.
5725         inferior.c (exit_inferior_1): Likewise.
5726
5727 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5728             Tom Tromey  <tom@tromey.com>
5729
5730         * dictionary.c (collate_pending_symbols_by_language): Remove
5731         "struct" from foreach.
5732         * symtab.c (lookup_global_symbol_from_objfile)
5733         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5734         foreach.
5735         * ser-tcp.c (net_open): Remove "struct" from foreach.
5736         * objfiles.c (objfile_relocate, objfile_rebase)
5737         (objfile_has_symbols): Remove "struct" from foreach.
5738         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5739         from foreach.
5740         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5741         foreach.
5742         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5743         "struct" from foreach.
5744         * ada-lang.c (create_excep_cond_exprs)
5745         (ada_exception_catchpoint_cond_string): Remove "struct" from
5746         foreach.
5747
5748 2019-05-03  Tom Tromey  <tromey@adacore.com>
5749
5750         * ada-exp.y (convert_char_literal): Check suffix of each
5751         enumerator.
5752
5753 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5754
5755         PR ada/21406:
5756         * ada-exp.y (yywrap): Don't define.
5757         * ada-lex.l (%option): Add noyywrap
5758         (yywrap): Remove.
5759
5760 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5761
5762         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5763         _WIN32_WINNT to the XP level, unless already defined to a higher
5764         level.
5765
5766         * unittests/parse-connection-spec-selftests.c:
5767         * ser-tcp.c:
5768         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5769         override.
5770
5771         * symfile.c (find_separate_debug_file): Remove colon from the
5772         drive spec of DOS/Windows file names of the target, so that the
5773         file name produced from DEBUGDIR and the target's directory will
5774         be valid on DOS/Windows systems.
5775
5776 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5777
5778         * rust-lang.c (val_print_struct): Handle printing structures
5779         containing strings.
5780
5781 2019-05-02  Tom Tromey  <tromey@adacore.com>
5782
5783         * valarith.c (_initialize_valarith): Remove.
5784
5785 2019-05-01  Tom Tromey  <tromey@adacore.com>
5786
5787         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5788         bitfields.
5789
5790 2019-05-01  Tom Tromey  <tromey@adacore.com>
5791
5792         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5793         for big-endian copies.
5794
5795 2019-04-30  Ali Tamur  <tamur@google.com>
5796         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5797         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5798         (read_3_bytes): New function.
5799
5800 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5801
5802         * windows-nat.c (main_thread_id): Delete.
5803         (handle_output_debug_string): Replace main_thread_id by
5804         current_event.dwThreadId.
5805         (fake_create_process): Likewise.
5806         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5807         Do not set main_thread_id.
5808         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5809         current_event.dwThreadId.
5810         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5811
5812 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5813
5814         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5815         Use current_event.dwThreadId instead of main_thread_id.
5816
5817 2019-04-30  Tom Tromey  <tromey@adacore.com>
5818
5819         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5820         (create_excep_cond_exprs): Iterate over program spaces.
5821         (ada_exception_catchpoint_cond_string): Examine all minimal
5822         symbols for exception types.
5823
5824 2019-04-30  Tom Tromey  <tromey@adacore.com>
5825
5826         PR c++/24470:
5827         * dwarf2read.c (process_structure_scope): Handle case where type
5828         has template parameters but no symbol was created.
5829
5830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5831             Chris January  <chris.january@arm.com>
5832
5833         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5834         qualifier.
5835         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5836
5837 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5838
5839         * f-typeprint.c (f_print_type): Update rules for printing
5840         whitespace.
5841         (f_type_print_varspec_suffix): Likewise.
5842
5843 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5844             Chris January  <chris.january@arm.com>
5845
5846         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5847         function arguments.
5848
5849 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5850
5851         * f-lang.c (build_fortran_types): Change name of void type to
5852         lower case.
5853         * f-typeprint.c (f_type_print_base): Print the name of the void
5854         type, rather than a fixed string.
5855         * f-valprint.c (f_decorations): Use lower case void string.
5856
5857 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5858             Chris January  <chris.january@arm.com>
5859
5860         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5861         types for Fortran.
5862
5863 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5864             Chris January  <chris.january@arm.com>
5865             David Lecomber  <david.lecomber@arm.com>
5866
5867         * f-exp.y (BINOP_INTRINSIC): New token.
5868         (exp): New parser rule handling BINOP_INTRINSIC.
5869         (f77_keywords): Add new builtin procedures.
5870         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5871         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5872         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5873         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5874         (print_unop_subexp_f): New function.
5875         (print_binop_subexp_f): New function.
5876         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5877         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5878         (dump_subexp_body_f): Likewise.
5879         (operator_check_f): Likewise.
5880         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5881         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5882
5883 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5884
5885         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5886         UNOP_KIND.
5887         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5888         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5889         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5890         (operator_length_f): New fuction.
5891         (print_subexp_f): New function.
5892         (op_name_f): New function.
5893         (dump_subexp_body_f): New function.
5894         (operator_check_f): New function.
5895         (exp_descriptor_f): Replace standard expression handling functions
5896         with new functions.
5897         * gdb/fortran-operator.def: New file.
5898         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5899         * gdb/std-operator.def: Remove UNOP_KIND.
5900
5901 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5902
5903         * std-operator.def: Remove unbalanced, stray double quote
5904         character.
5905
5906 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5907             Chris January  <chris.january@arm.com>
5908             Daniel Everett  <daniel.everett@arm.com>
5909             Nick Forrington  <nick.forrington@arm.com>
5910             Richard Bunt  <richard.bunt@arm.com>
5911
5912         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5913         of depth when printing anonymous structs or unions.
5914         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5915         Don't print either the top-level value, or the children if the
5916         max-depth is exceeded.
5917         (ppscm_print_children): When printing the key of a map, allow one
5918         extra level of depth.
5919         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5920         print either the top-level value, or the children if the max-depth
5921         is exceeded.
5922         (print_children): When printing the key of a map, allow one extra
5923         level of depth.
5924         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5925         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5926         (user_print_options): Initialise max_depth field.
5927         (val_print_scalar_or_string_type_p): New function.
5928         (val_print): Check to see if the max depth has been reached.
5929         (val_print_check_max_depth): Define new function.
5930         (show_print_max_depth): New function.
5931         (_initialize_valprint): Add 'print max-depth' option.
5932         * valprint.h (struct value_print_options) <max_depth>: New field.
5933         (val_print_check_max_depth): Declare new function.
5934         * NEWS: Document new feature.
5935
5936 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5937
5938         * ada-lang.c (ada_language_defn): Initialise new field.
5939         * c-lang.c (c_is_string_type_p): New function.
5940         (c_language_defn): Initialise new field.
5941         (cplus_language_defn): Initialise new field.
5942         (asm_language_defn): Initialise new field.
5943         (minimal_language_defn): Initialise new field.
5944         * c-lang.h (c_is_string_type_p): Declare new function.
5945         * d-lang.c (d_language_defn): Initialise new field.
5946         * f-lang.c (f_is_string_type_p): New function.
5947         (f_language_defn): Initialise new field.
5948         * go-lang.c (go_is_string_type_p): New function.
5949         (go_language_defn): Initialise new field.
5950         * language.c (default_is_string_type_p): New function.
5951         (unknown_language_defn): Initialise new field.
5952         (auto_language_defn): Initialise new field.
5953         * language.h (struct language_defn) <la_is_string_type_p>: New
5954         member variable.
5955         (default_is_string_type_p): Declare new function.
5956         * m2-lang.c (m2_language_defn): Initialise new field.
5957         * objc-lang.c (objc_language_defn): Initialise new field.
5958         * opencl-lang.c (opencl_language_defn): Initialise new field.
5959         * p-lang.c (pascal_is_string_type_p): New function.
5960         (pascal_language_defn): Initialise new field.
5961         * rust-lang.c (rust_is_string_type_p): New function.
5962         (rust_language_defn): Initialise new field.
5963
5964 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5965
5966         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5967         New field.
5968         * ada-lang.c (ada_language_defn): Initialise new field.
5969         * c-lang.c (c_language_defn): Likewise.
5970         (cplus_language_defn): Likewise.
5971         (asm_language_defn): Likewise.
5972         (minimal_language_defn): Likewise.
5973         * d-lang.c (d_language_defn): Likewise.
5974         * f-lang.c (f_language_defn): Likewise.
5975         * go-lang.c (go_language_defn): Likewise.
5976         * language.c (unknown_language_defn): Likewise.
5977         (auto_language_defn): Likewise.
5978         * m2-lang.c (m2_language_defn): Likewise.
5979         * objc-lang.c (objc_language_defn): Likewise.
5980         * opencl-lang.c (opencl_language_defn): Likewise.
5981         * p-lang.c (pascal_language_defn): Likewise.
5982         * rust-lang.c (rust_language_defn): Likewise.
5983
5984 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5985
5986         * ada-lang.c (ada_is_character_type): Change return type to bool.
5987         (ada_is_string_type): Likewise.
5988         * ada-lang.h (ada_is_character_type): Update declaration
5989         (ada_is_string_type): Likewise.
5990
5991 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5992
5993         Support style in 'frame|thread apply'
5994
5995         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5996         * record.c (record_start, record_stop): Update callers of
5997         execute_command_to_string with false.
5998         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5999         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6000         methods.
6001         (class string_file): New constructor with term_out parameter.
6002         Override methods term_out and can_emit_style_escape.  New member
6003         term_out.
6004         (class stdio_file): Override can_emit_style_escape.
6005         (class tee_file): Override term_out and can_emit_style_escape.
6006         * utils.h (can_emit_style_escape): Remove.
6007         * utils.c (can_emit_style_escape): Likewise.
6008         Update all callers of can_emit_style_escape (SOMESTREAM) to
6009         SOMESTREAM->can_emit_style_escape.
6010         * source-cache.c (source_cache::get_source_lines): Likewise.
6011         * stack.c (frame_apply_command_count): Call execute_command_to_string
6012         passing the term_out characteristic of the current gdb_stdout.
6013         * thread.c (thr_try_catch_cmd): Likewise.
6014         * top.c (execute_command_to_string): pass term_out parameter
6015         to construct the string_file for the command output.
6016         * ui-file.c (term_cli_styling): New function (most code moved
6017         from utils.c can_emit_style_escape).
6018         (string_file::string_file, string_file::can_emit_style_escape,
6019         stdio_file::can_emit_style_escape, tee_file::term_out,
6020         tee_file::can_emit_style_escape): New functions.
6021
6022 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6023
6024         * NEWS: Mention the new set|show may-call-functions.
6025         * infcall.c (may_call_functions_p): New variable.
6026         (show_may_call_functions_p): New function.
6027         (call_function_by_hand_dummy): Throws an error if not
6028         may-call-functions.
6029         (_initialize_infcall): Call add_setshow_boolean_cmd for
6030         may-call-functions.
6031
6032 2019-04-25  Keith Seitz  <keiths@redhat.com>
6033
6034         PR c++/24367
6035         * cp-support.c (inspect_type): Don't attempt substitutions
6036         of symbol with the same name.
6037
6038 2019-04-25  Tom Tromey  <tromey@adacore.com>
6039
6040         PR gdb/24475:
6041         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6042         static.
6043
6044 2019-04-25  Tom Tromey  <tromey@adacore.com>
6045
6046         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6047         rvalue reference.
6048         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6049         (gdb_xml_parser::parse): Use std::move.
6050         * python/python-internal.h (gdbpy_convert_exception): Take a const
6051         reference.
6052         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6053         std::move.
6054         * python/py-utils.c (gdbpy_convert_exception): Take a const
6055         reference.
6056         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6057         Use std::move.
6058         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6059         Use std::move.
6060         * mi/mi-main.c (mi_print_exception): Take a const reference.
6061         * main.c (handle_command_errors): Take a const reference.
6062         * linespec.c (parse_linespec): Use std::move.
6063         * infcall.c (run_inferior_call): Use std::move.
6064         (call_function_by_hand_dummy): Use std::move.
6065         * exec.c (try_open_exec_file): Use std::move.
6066         * exceptions.h (exception_print, exception_fprintf)
6067         (exception_print_same): Update.
6068         * exceptions.c (print_exception, exception_print)
6069         (exception_fprintf, exception_print_same): Change parameters to
6070         const reference.
6071         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6072         * common/new-op.c: Use std::move.
6073         * common/common-exceptions.h (struct gdb_exception): Add move
6074         constructor.
6075         (struct gdb_exception_error, struct gdb_exception_quit, struct
6076         gdb_quit_bad_alloc): Change constructor to move constructor.
6077         (throw_exception): Change parameter to rvalue reference.
6078         * common/common-exceptions.c (throw_exception): Take rvalue
6079         reference.
6080         * cli/cli-interp.c (safe_execute_command): Use std::move.
6081         * breakpoint.c (insert_bp_location, location_to_sals): Use
6082         std::move.
6083
6084 2019-04-25  Tom Tromey  <tromey@adacore.com>
6085
6086         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6087         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6088         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6089         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6090         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6091         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6092         guile/scm-value.c: Use unpack.
6093         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6094         gdbscm_gdb_exception.
6095         (gdbscm_throw_gdb_exception): Likewise.
6096         (struct gdbscm_gdb_exception): New.
6097         (unpack): New function.
6098         (gdbscm_wrap): Use unpack.
6099
6100 2019-04-25  Tom Tromey  <tromey@adacore.com>
6101
6102         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6103         (gdb_rl_callback_handler): Use std::move.
6104         * common/common-exceptions.h (struct gdb_exception): Add move
6105         assignment operator.
6106         (throw_exception_sjlj): Change "exception" to const reference.
6107         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6108         (throw_exception_sjlj): Change "exception" to const reference.
6109
6110 2019-04-25  Tom Tromey  <tromey@adacore.com>
6111
6112         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6113         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6114         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6115         Update.
6116         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6117         Update.
6118         * mi/mi-interp.c (mi_interp::exec): Update.
6119         * linespec.c (parse_linespec): Update.
6120         * infcall.c (run_inferior_call): Update.
6121         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6122         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6123         (gdbscm_lookup_global_symbol): Update.
6124         * guile/scm-param.c (gdbscm_parameter_value): Update.
6125         * guile/scm-frame.c (gdbscm_frame_read_register)
6126         (gdbscm_frame_read_var): Update.
6127         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6128         * exec.c (try_open_exec_file): Update.
6129         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6130         (gdb_rl_callback_handler): Update.
6131         * common/common-exceptions.h (exception_none): Don't declare.
6132         * common/common-exceptions.c (exception_none): Don't define.
6133         (struct catcher) <exception>: Update.
6134         * cli/cli-interp.c (safe_execute_command): Update.
6135         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6136
6137 2019-04-25  Ali Tamur  <tamur@google.com>
6138
6139         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6140         (read_attribute_value): Likewise.
6141         (dwarf2_read_addr_index): Update comment.
6142         (read_str_index): Add DW_FORM_strx.
6143         (dwarf2_string_attr): Likewise.
6144         (dwarf2_const_value_attr): Likewise.
6145         (dump_die_shallow): Likewise.
6146         (dwarf2_fetch_constant_bytes): Likewise.
6147         (skip_form_bytes): Likewise.
6148         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6149
6150 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6151
6152         PR corefiles/11608
6153         PR corefiles/18187
6154         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6155         OFFSET.  Verify if current mapping contains an ELF header.
6156         (linux_find_memory_regions_full): Adjust call to
6157         dump_mapping_p.
6158
6159 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6160             Kang Li <kanglictf@gmail.com>
6161
6162         PR gdb/21600
6163
6164         * dwarf2-frame.c (read_initial_length): Be consistent about using
6165         unsigned representation of length.
6166         (decode_frame_entry_1): Likewise.  Check for wraparound of
6167         end pointer as well as buffer overflow.
6168
6169 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6170
6171         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6172         "vq".
6173
6174 2019-04-24  Tom Tromey  <tromey@adacore.com>
6175
6176         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6177
6178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * s12z-tdep.c (s12z_unwind_pc): Delete.
6181         (s12z_unwind_sp): Delete.
6182         (s12z_gdbarch_init): Don't register deleted functions with
6183         gdbarch.
6184
6185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6186
6187         * rl78-tdep.c (rl78_unwind_sp): Delete.
6188         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6189
6190 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6191
6192         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6193         (xstormy16_unwind_pc): Delete.
6194         (xstormy16_dummy_id): Delete.
6195         (xstormy16_gdbarch_init): Don't register deleted functions with
6196         gdbarch.
6197
6198 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6199
6200         * vax-tdep.c (vax_unwind_pc): Delete.
6201         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6202
6203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6204
6205         * v850-tdep.c (v850_unwind_sp): Delete.
6206         (v850_unwind_pc): Delete.
6207         (v850_dummy_id): Delete.
6208         (v850_gdbarch_init): Don't register deleted functions with
6209         gdbarch.
6210
6211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6214         (tilegx_unwind_pc): Delete.
6215         (tilegx_unwind_dummy_id): Delete.
6216         (tilegx_gdbarch_init): Don't register deleted functions with
6217         gdbarch.
6218
6219 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6220
6221         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6222         (tic6x_dummy_id): Delete.
6223         (tic6x_gdbarch_init): Don't register deleted functions with
6224         gdbarch.
6225
6226 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6227
6228         * sparc-tdep.c (sparc_unwind_pc): Delete.
6229         (sparc32_gdbarch_init): Don't register deleted function with
6230         gdbarch.
6231
6232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * sh-tdep.c (sh_unwind_sp): Delete.
6235         (sh_unwind_pc): Delete.
6236         (sh_dummy_id): Delete.
6237         (sh_gdbarch_init): Don't register deleted functions with
6238         gdbarch.
6239
6240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6241
6242         * score-tdep.c (score_unwind_sp): Delete.
6243         (score_unwind_pc): Delete.
6244         (score_dummy_id): Delete.
6245         (score_gdbarch_init): Don't register deleted functions with
6246         gdbarch.
6247
6248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6249
6250         * rx-tdep.c (rx_unwind_pc): Delete.
6251         (rx_unwind_sp): Delete.
6252         (rx_dummy_id): Delete.
6253         (rx_gdbarch_init): Don't register deleted functions with
6254         gdbarch.  Update comment.
6255
6256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6259         (rs6000_dummy_id): Delete.
6260         (rs6000_gdbarch_init): Don't register deleted functions with
6261         gdbarch.
6262
6263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6264
6265         * or1k-tdep.c (or1k_dummy_id): Delete.
6266         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6267
6268 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6269
6270         * nios2-tdep.c (nios2_dummy_id): Delete.
6271         (nios2_unwind_sp): Delete.
6272         (nios2_gdbarch_init): Don't register deleted functions with
6273         gdbarch.
6274
6275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6276
6277         * nds32-tdep.c (nds32_dummy_id): Delete.
6278         (nds32_unwind_pc): Delete.
6279         (nds32_unwind_sp): Delete.
6280         (nds32_gdbarch_init): Don't register deleted functions with
6281         gdbarch.
6282
6283 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6284
6285         * msp430-tdep.c (msp430_unwind_pc): Delete.
6286         (msp430_unwind_sp): Delete.
6287         (msp430_dummy_id): Delete.
6288         (msp430_gdbarch_init): Don't register deleted functions with
6289         gdbarch.
6290
6291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6292
6293         * moxie-tdep.c (moxie_unwind_sp): Delete.
6294         (moxie_unwind_pc): Delete.
6295         (moxie_dummy_id): Delete.
6296         (moxie_gdbarch_init): Don't register deleted functions with
6297         gdbarch.
6298
6299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6302         (mn10300_unwind_pc): Delete.
6303         (mn10300_unwind_sp): Delete.
6304         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6305         mn10300_unwind_sp.
6306         (mn10300_frame_unwind_init): Don't register deleted functions with
6307         gdbarch.
6308
6309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * mep-tdep.c (mep_unwind_pc): Delete.
6312         (mep_unwind_sp): Delete.
6313         (mep_dummy_id): Delete.
6314         (mep_gdbarch_init): Don't register deleted functions with
6315         gdbarch.
6316
6317 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6318
6319         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6320         (m68hc11_unwind_sp): Delete.
6321         (m68hc11_gdbarch_init): Don't register deleted functions with
6322         gdbarch.
6323
6324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * m32r-tdep.c (m32r_unwind_sp): Delete.
6327         (m32r_unwind_pc): Delete.
6328         (m32r_dummy_id): Delete.
6329         (m32r_gdbarch_init): Don't register deleted functions with
6330         gdbarch.
6331
6332 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6333
6334         * m32c-tdep.c (m32c_unwind_pc): Delete.
6335         (m32c_unwind_sp): Delete.
6336         (m32c_dummy_id): Delete.
6337         (m32c_gdbarch_init): Don't register deleted functions with
6338         gdbarch.
6339
6340 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6341
6342         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6343         (lm32_unwind_pc): Delete.
6344         (lm32_dummy_id): Delete.
6345         (lm32_gdbarch_init): Don't register deleted functions with
6346         gdbarch.
6347
6348 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6351         (iq2000_unwind_pc): Delete.
6352         (iq2000_dummy_id): Delete.
6353         (iq2000_gdbarch_init): Don't register deleted functions with
6354         gdbarch.
6355
6356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * nds32-tdep.c (nds32_type_align): Delete.
6359         (nds32_push_dummy_call): Use type_align instead.
6360
6361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6362
6363         * arm-tdep.c (arm_type_align): Only handle vector override case.
6364         (arm_push_dummy_call): Use type_align.
6365         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6366
6367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6368
6369         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6370         case.
6371         (pass_on_stack): Use type_align.
6372         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6373         function.
6374
6375 2019-04-23  Tom Tromey  <tromey@adacore.com>
6376
6377         * dwarf2read.c (line_header::file_name_at): Remove unused
6378         overload.
6379
6380 2019-04-23  Tom de Vries  <tdevries@suse.de>
6381
6382         PR gdb/24438
6383         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6384         invocation.
6385
6386
6387 2019-03-27  Ali Tamur  <tamur@google.com>
6388
6389         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6390         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6391         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6392         (dwarf_expr_context::get_addr_index): Likewise
6393         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6394         (symbol_needs_eval_context::get_addr_index): Likewise
6395         (disassemble_dwarf_expression): Add DW_OP_addrx
6396         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6397         (read_cutu_die_from_dwo): Update comment
6398         (skip_one_die): Add DW_FORM_addrx
6399         (read_attribute_value): Likewise
6400         (var_decode_location): Add DW_OP_addrx
6401         (dwarf2_const_value_attr): Add DW_FORM_addrx
6402         (dump_die_shallow): Likewise
6403         (dwarf2_fetch_constant_bytes): Likewise
6404         (decode_locdesc): Add DW_OP_addrx
6405         (skip_form_bytes): Add DW_FORM_addrx
6406
6407 2019-04-22  Ali Tamur  <tamur@google.com>
6408
6409         * MAINTAINERS (Write After Approval): Add self.
6410
6411 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6412
6413         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6414         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6415         (open_symbol_file_object): Likewise.
6416         (svr4_default_sos): Add info parameter.
6417         (svr4_read_so_list): Likewise.
6418         (svr4_current_sos_direct): Adjust functions calls to pass down
6419         info.
6420         (svr4_current_sos_1): Add info parameter.
6421         (svr4_current_sos): Call get_svr4_info, pass info down to
6422         svr4_current_sos_1.
6423         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6424         get_svr4_info.
6425         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6426         get_svr4_info.
6427         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6428         to get_svr4_info.
6429         (probes_table_remove_objfile_probes): Likewise.
6430         (register_solib_event_probe): Add info parameter.
6431         (solist_update_incremental): Pass info parameter down to
6432         svr4_read_so_list.
6433         (disable_probes_interface): Add info parameter.
6434         (svr4_handle_solib_event): Pass current_program_space to
6435         get_svr4_info.  Adjust disable_probes_interface cleanup.
6436         (svr4_create_probe_breakpoints): Add info parameter, pass it
6437         down to register_solib_event_probe.
6438         (svr4_create_solib_event_breakpoints): Add info parameter,
6439         pass it down to svr4_create_probe_breakpoints.
6440         (enable_break): Pass info down to
6441         svr4_create_solib_event_breakpoints.
6442         (svr4_solib_create_inferior_hook): Pass current_program_space to
6443         get_svr4_info.
6444         (svr4_clear_solib): Likewise.
6445
6446 2019-04-22  Pedro Alves  <palves@redhat.com>
6447
6448         * solib-svr4.c (svr4_free_objfile_observer): New.
6449         (probe_and_action::objfile): New field.
6450         (probes_table_htab_remove_objfile_probes)
6451         (probes_table_remove_objfile_probes): New functions.
6452         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6453         in the new probe_and_action.  Don't store the probe in 'lookup'.
6454         (svr4_create_probe_breakpoints): Pass objfile to
6455         register_solib_event_probe.
6456         (_initialize_svr4_solib): Register a free_objfile observer.
6457
6458 2019-04-19  Tom Tromey  <tom@tromey.com>
6459
6460         * common/queue.h: Remove.
6461
6462 2019-04-19  Tom Tromey  <tom@tromey.com>
6463
6464         * event-loop.c: Don't include "common/queue.h".
6465
6466 2019-04-19  Tom Tromey  <tom@tromey.com>
6467
6468         * remote.c (remote_target): Use delete.
6469         * remote-notif.h: Include <list>, not "common/queue.h".
6470         (notif_client_p): Remove typedef.
6471         (remote_notif_state): Add constructor, destructor, initializer.
6472         <notif_queue>: Now a std::list.
6473         (remote_notif_state_xfree): Don't declare.
6474         * remote-notif.c (remote_notif_process, handle_notification)
6475         (remote_notif_state_allocate): Update.
6476         (~remote_notif_state): Rename from remote_notif_state_xfree.
6477
6478 2019-04-19  Tom Tromey  <tom@tromey.com>
6479
6480         * symfile.c (reread_symbols): Update.
6481         * objfiles.c (objfile_register_static_link)
6482         (objfile_lookup_static_link): Update
6483         (~objfile) Don't delete static_links.
6484         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6485
6486 2019-04-19  Tom Tromey  <tom@tromey.com>
6487
6488         * type-stack.h (struct type_stack) <insert>: Constify string.
6489         * type-stack.c (type_stack::insert): Constify string.
6490         * gdbtypes.h (lookup_template_type): Update.
6491         (address_space_name_to_int): Update.
6492         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6493         const.
6494         (lookup_template_type): Make name const.
6495         * c-exp.y: Update rules.
6496         (lex_one_token, classify_name, classify_inner_name)
6497         (c_print_token): Update.
6498         * p-exp.y: Update rules.
6499         (yylex): Update.
6500         * f-exp.y: Update rules.
6501         (yylex): Update.
6502         * d-exp.y: Update rules.
6503         (lex_one_token, classify_name, classify_inner_name): Update.
6504         * parse.c (write_dollar_variable, copy_name): Return std::string.
6505         * parser-defs.h (copy_name): Change return type.
6506         * m2-exp.y: Update rules.
6507         (yylex): Update.
6508         * go-exp.y (lex_one_token): Update.
6509         Update rules.
6510         (classify_unsafe_function, classify_packaged_name)
6511         (classify_name, yylex): Update.
6512
6513 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6514
6515         * configure.ac: add --enable-source-highlight switch.
6516         * configure: Regenerate.
6517         * top.c (print_gdb_version): plumb --enable-source-highlight
6518         status to "show configuration".
6519
6520 2019-04-19  Tom Tromey  <tromey@adacore.com>
6521
6522         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6523         Check ADA_TYPE_P.
6524         (empty_record, ada_template_to_fixed_record_type_1)
6525         (template_to_static_fixed_type)
6526         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6527         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6528         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6529         macros.
6530
6531 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6532
6533         PR symtab/24423:
6534         * source.c (print_source_lines_base): Advance "iter" when a
6535         control character is seen.
6536
6537 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6538
6539         * inferior.h (struct infcall_suspend_state_deleter):
6540         Catch exception in destructor to avoid crash.
6541
6542 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6543
6544         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6545         close to the add_com "shell".
6546
6547 2019-04-18  Tom Tromey  <tromey@adacore.com>
6548
6549         * process-stratum-target.h (class process_stratum_target)
6550         <stratum>: Add "final".
6551
6552 2019-04-17  Tom Tromey  <tromey@adacore.com>
6553
6554         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6555         against nullptr before use.
6556
6557 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6558
6559         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6560
6561 2019-04-17  Jim Wilson  <jimw@sifive.com>
6562             Andrew Burgess  <andrew.burgess@embecosm.com>
6563
6564         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6565         code read might fail, assume 4-byte breakpoint in that case.
6566
6567 2019-04-15  Leszek Swirski  <leszeks@google.com>
6568
6569         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6570         rather than a hand-rolled POD check when checking for forced MEMORY
6571         classification.
6572
6573 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6574
6575         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6576         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6577         function.
6578         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6579         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6580         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6581         declaration.
6582
6583 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6584
6585         * aarch64-linux-nat.c
6586         (aarch64_linux_nat_target::thread_architecture): Add override.
6587         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6588         each VQ.
6589
6590 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6591
6592         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6593
6594 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6595
6596         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6597         target types of size 96-bits, add some additional comments, and
6598         check that the builtin type we found was the correct size.
6599
6600 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6601
6602         * utils.c (prompt_for_continue): Don't restore the styling at the
6603         end, as applied_style has the wrong value.  This fixes styling in
6604         long lists of file names that are interrupted by the "Continue?"
6605         prompt.
6606
6607 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6608
6609         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6610         * c-lang.c (c_language_defn): Likewise.
6611         (cplus_language_defn): Likewise.
6612         (asm_language_defn): Likewise.
6613         (minimal_language_defn): Likewise.
6614         * d-lang.c (d_language_defn): Likewise.
6615         * f-lang.c (f_language_defn): Likewise.
6616         * go-lang.c (go_language_defn): Likewise.
6617         * language.c (unknown_language_defn): Likewise.
6618         (auto_language_defn): Likewise.
6619         * language.h (struct language_defn): Remove la_magic field.
6620         (LANG_MAGIC): Delete.
6621         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6622         * objc-lang.c (objc_language_defn): Likewise.
6623         * opencl-lang.c (opencl_language_defn): Likewise.
6624         * p-lang.c (pascal_language_defn): Likewise.
6625         * rust-lang.c (rust_language_defn): Likewise.
6626
6627 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6628
6629         * riscv-tdep.c (riscv_type_align): New function.
6630         (riscv_type_alignment): Delete.
6631         (riscv_arg_location): Use 'type_align'.
6632         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6633
6634 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6635
6636         * gdbtypes.c (type_align): A struct with no non-static fields also
6637         has alignment of 1.
6638
6639 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6640
6641         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6642         component to 0.
6643         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6644         member.
6645         (riscv_struct_info::analyse): New implementation using new
6646         analyse_inner member function.
6647         (riscv_struct_info::field_offset): New member function.
6648         (riscv_struct_info::m_offsets): New member variable.
6649         (riscv_struct_info::analyse_inner): New private member function,
6650         takes the old implementation of riscv_struct_info::analyse but
6651         extended to track field offsets.
6652         (riscv_call_arg_struct): Update the struct folding special cases
6653         to handle cases where empty C++ structs, which are non-zero
6654         length, are found.
6655         (riscv_arg_location): Initialise the length of each location, a
6656         non-zero length now indicates the location is in use.
6657         (riscv_push_dummy_call): Allow for the first location having a
6658         non-zero offset when setting up arguments.
6659         (riscv_return_value): Likewise, but for return values.
6660
6661 2019-04-11  Tom Tromey  <tromey@adacore.com>
6662
6663         * utils.c (internal_vproblem): Make "msg" const.
6664
6665 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6666
6667         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6668         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6669         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6670         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6671
6672 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6673
6674         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6675         function.
6676         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6677         of amd64_collect_native_gregset.
6678         (amd64_linux_nat_target::store_registers): Likewise.
6679
6680 2019-04-10  Tom Tromey  <tom@tromey.com>
6681
6682         * symtab.c (lookup_global_symbol_from_objfile)
6683         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6684         * objfiles.h (class separate_debug_iterator): New.
6685         (class separate_debug_range): New.
6686         (struct objfile) <separate_debug_objfiles>: New method.
6687         (objfile_separate_debug_iterate): Don't declare.
6688         * objfiles.c (separate_debug_iterator::operator++): Rename from
6689         objfile_separate_debug_iterate.
6690         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6691         iterator.
6692         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6693         iterator.
6694
6695 2019-04-10  Tom Tromey  <tom@tromey.com>
6696
6697         * symfile.c (reread_symbols): Remove old comment.
6698         * objfiles.c (free_all_objfiles): Fix a typo.
6699
6700 2019-04-10  Tom Tromey  <tom@tromey.com>
6701
6702         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6703         * minsyms.c (lookup_minimal_symbol): Use foreach.
6704         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6705         (lookup_minimal_symbol_solib_trampoline): Likewise.
6706         * symfile.c (reread_symbols): Use foreach.
6707
6708 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6709             Tom Tromey  <tromey@adacore.com>
6710
6711         PR rust/24414:
6712         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6713         (rust_lex_int_test): Change "value" to be LONGEST.
6714         (rust_lex_tests): Add test for long integer literal.
6715
6716 2019-04-09  Tom Tromey  <tromey@adacore.com>
6717
6718         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6719         to bool.
6720         (extended_remote_target::attach): Update.
6721         (remote_target::remote_notice_new_inferior): Update.
6722         (remote_target::add_current_inferior_and_thread): Update.
6723         * inferior.c (exit_inferior_1): Use "false".
6724         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6725
6726 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6727
6728         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6729         the "start" command.
6730
6731 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6732
6733         * python/py-inferior.c (infpy_thread_from_thread_handle):
6734         Adjust comments to reflect renaming of thread_from_thread_handle
6735         to thread_from_handle.  Adjust keywords.  Fix type error message.
6736         (inferior_object_methods): Add thread_from_handle.  Retain
6737         thread_from_thread_handle, but mark it as deprecated.
6738
6739 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6740
6741         * gdbthread.h (find_thread_by_handle): Revise declaration.
6742         * thread.c (find_thread_by_handle): Likewise.  Adjust
6743         implementation too.
6744         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6745         support for buffer objects as handles.
6746
6747 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6748
6749         * python/py-infthread.c (thpy_thread_handle): New function.
6750         (thread_object_methods): Register thpy_thread_handle.
6751
6752 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6753
6754         * gdbthread.h (thread_to_thread_handle): Declare.
6755         * thread.c (gdbtypes.h): Include.
6756         (thread_to_thread_handle): New function.
6757
6758         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6759         (target_thread_info_to_thread_handle): Declare.
6760         * target.c (target_thread_info_to_thread_handle): New function.
6761         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6762         * target-delegates.c: Regenerate.
6763
6764         * linux-thread-db.c (class thread_db_target): Add method
6765         thread_info_to_thread_handle.
6766         (thread_db_target::thread_info_to_thread_handle): Define.
6767         * remote.c (class remote_target): Add new method
6768         thread_info_to_thread_handle.
6769         (remote_target::thread_info_to_thread_handle): Define.
6770
6771 2019-04-08  Pedro Alves  <palves@redhat.com>
6772
6773         * common/common-exceptions.c (throw_exception): Don't create
6774         named object to throw; throw directly.
6775         (throw_it): Likewise.  Don't initialize gdb_exception::message
6776         here, with new; pass FMT and AP to the ctor instead.
6777         * common/common-exceptions.h: Include <string>.
6778         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6779         const char *, va_list)): New ctor.  Use std::make_shared.
6780         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6781         errors)): Delete.
6782         (gdb_exception_error::gdb_exception_error(enum errors, const char
6783         *, va_list)): New.
6784         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6785         Add assertion.
6786         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6787         errors)): Delete.
6788         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6789         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6790         Add assertion.
6791
6792 2019-04-08  Tom Tromey  <tom@tromey.com>
6793
6794         * valops.c (value_rtti_indirect_type): Replace throw_exception
6795         with throw.
6796         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6797         with throw.
6798         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6799         throw.
6800         * target.c (target_translate_tls_address): Replace throw_exception
6801         with throw.
6802         * stack.c (frame_apply_command_count): Replace throw_exception
6803         with throw.
6804         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6805         throw.
6806         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6807         with throw.
6808         * rs6000-tdep.c (rs6000_frame_cache)
6809         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6810         * remote.c: Replace throw_exception with throw.
6811         * record-full.c (record_full_message, record_full_wait_1)
6812         (record_full_restore): Replace throw_exception with throw.
6813         * record-btrace.c:
6814         (get_thread_current_frame_id, record_btrace_start_replaying)
6815         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6816         (cmd_record_btrace_start): Replace throw_exception with throw.
6817         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6818         throw.
6819         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6820         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6821         * linespec.c:
6822         (find_linespec_symbols): Replace throw_exception with throw.
6823         * infrun.c (displaced_step_prepare, resume): Replace
6824         throw_exception with throw.
6825         * infcmd.c (post_create_inferior): Replace throw_exception with
6826         throw.
6827         * inf-loop.c (inferior_event_handler): Replace throw_exception
6828         with throw.
6829         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6830         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6831         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6832         (get_prev_frame_always, get_frame_pc_if_available)
6833         (get_frame_address_in_block_if_available, get_frame_language):
6834         Replace throw_exception with throw.
6835         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6836         throw_exception with throw.
6837         * eval.c (fetch_subexp_value, evaluate_var_value)
6838         (evaluate_funcall, evaluate_subexp_standard): Replace
6839         throw_exception with throw.
6840         * dwarf2loc.c (call_site_find_chain)
6841         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6842         Replace throw_exception with throw.
6843         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6844         with throw.
6845         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6846         throw.
6847         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6848         * completer.c (complete_line_internal): Replace throw_exception
6849         with throw.
6850         * compile/compile-object-run.c (compile_object_run): Replace
6851         throw_exception with throw.
6852         * cli/cli-script.c (process_next_line): Replace throw_exception
6853         with throw.
6854         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6855         (btrace_enable, btrace_maint_update_pt_packets): Replace
6856         throw_exception with throw.
6857         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6858         throw_exception with throw.
6859         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6860         throw_exception with throw.
6861         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6862         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6863         * aarch64-tdep.c (aarch64_make_prologue_cache)
6864         (aarch64_make_stub_cache): Replace throw_exception with throw.
6865
6866 2019-04-08  Tom Tromey  <tom@tromey.com>
6867
6868         * common/common-exceptions.c (throw_exception): Rename from
6869         throw_exception_cxx.  Remove old copy.  Make argument const.
6870         (throw_it): Create and throw exception objects directly.
6871         * common/common-exceptions.h (throw_exception): Make argument
6872         const.
6873         (struct gdb_exception_error): Add constructor.
6874         (struct gdb_exception_quit): Add constructor.
6875
6876 2019-04-08  Tom Tromey  <tom@tromey.com>
6877
6878         * common/common-exceptions.h (exception_rethrow): Don't declare.
6879         (TRY_SJLJ): Update comment.
6880         (TRY, CATCH, END_CATCH): Remove.
6881         * common/common-exceptions.c (exception_rethrow): Remove.
6882
6883 2019-04-08  Tom Tromey  <tom@tromey.com>
6884
6885         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6886         Remove.
6887         (gdb_exception_error): Rename from
6888         gdb_exception_RETURN_MASK_ERROR.
6889         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6890         (gdb_quit_bad_alloc): Update.
6891         * aarch64-tdep.c: Update.
6892         * ada-lang.c: Update.
6893         * ada-typeprint.c: Update.
6894         * ada-valprint.c: Update.
6895         * amd64-tdep.c: Update.
6896         * arch-utils.c: Update.
6897         * break-catch-throw.c: Update.
6898         * breakpoint.c: Update.
6899         * btrace.c: Update.
6900         * c-varobj.c: Update.
6901         * cli/cli-cmds.c: Update.
6902         * cli/cli-interp.c: Update.
6903         * cli/cli-script.c: Update.
6904         * common/common-exceptions.c: Update.
6905         * common/new-op.c: Update.
6906         * common/selftest.c: Update.
6907         * compile/compile-c-symbols.c: Update.
6908         * compile/compile-cplus-symbols.c: Update.
6909         * compile/compile-object-load.c: Update.
6910         * compile/compile-object-run.c: Update.
6911         * completer.c: Update.
6912         * corelow.c: Update.
6913         * cp-abi.c: Update.
6914         * cp-support.c: Update.
6915         * cp-valprint.c: Update.
6916         * darwin-nat.c: Update.
6917         * disasm-selftests.c: Update.
6918         * dtrace-probe.c: Update.
6919         * dwarf-index-cache.c: Update.
6920         * dwarf-index-write.c: Update.
6921         * dwarf2-frame-tailcall.c: Update.
6922         * dwarf2-frame.c: Update.
6923         * dwarf2loc.c: Update.
6924         * dwarf2read.c: Update.
6925         * eval.c: Update.
6926         * event-loop.c: Update.
6927         * event-top.c: Update.
6928         * exec.c: Update.
6929         * f-valprint.c: Update.
6930         * fbsd-tdep.c: Update.
6931         * frame-unwind.c: Update.
6932         * frame.c: Update.
6933         * gdbtypes.c: Update.
6934         * gnu-v3-abi.c: Update.
6935         * guile/guile-internal.h: Update.
6936         * guile/scm-block.c: Update.
6937         * guile/scm-breakpoint.c: Update.
6938         * guile/scm-cmd.c: Update.
6939         * guile/scm-disasm.c: Update.
6940         * guile/scm-frame.c: Update.
6941         * guile/scm-lazy-string.c: Update.
6942         * guile/scm-math.c: Update.
6943         * guile/scm-param.c: Update.
6944         * guile/scm-ports.c: Update.
6945         * guile/scm-pretty-print.c: Update.
6946         * guile/scm-symbol.c: Update.
6947         * guile/scm-symtab.c: Update.
6948         * guile/scm-type.c: Update.
6949         * guile/scm-value.c: Update.
6950         * i386-linux-tdep.c: Update.
6951         * i386-tdep.c: Update.
6952         * inf-loop.c: Update.
6953         * infcall.c: Update.
6954         * infcmd.c: Update.
6955         * infrun.c: Update.
6956         * jit.c: Update.
6957         * language.c: Update.
6958         * linespec.c: Update.
6959         * linux-fork.c: Update.
6960         * linux-nat.c: Update.
6961         * linux-tdep.c: Update.
6962         * linux-thread-db.c: Update.
6963         * main.c: Update.
6964         * mi/mi-cmd-break.c: Update.
6965         * mi/mi-cmd-stack.c: Update.
6966         * mi/mi-interp.c: Update.
6967         * mi/mi-main.c: Update.
6968         * objc-lang.c: Update.
6969         * p-valprint.c: Update.
6970         * parse.c: Update.
6971         * ppc-linux-tdep.c: Update.
6972         * printcmd.c: Update.
6973         * python/py-arch.c: Update.
6974         * python/py-breakpoint.c: Update.
6975         * python/py-cmd.c: Update.
6976         * python/py-finishbreakpoint.c: Update.
6977         * python/py-frame.c: Update.
6978         * python/py-framefilter.c: Update.
6979         * python/py-gdb-readline.c: Update.
6980         * python/py-inferior.c: Update.
6981         * python/py-infthread.c: Update.
6982         * python/py-lazy-string.c: Update.
6983         * python/py-linetable.c: Update.
6984         * python/py-objfile.c: Update.
6985         * python/py-param.c: Update.
6986         * python/py-prettyprint.c: Update.
6987         * python/py-progspace.c: Update.
6988         * python/py-record-btrace.c: Update.
6989         * python/py-record.c: Update.
6990         * python/py-symbol.c: Update.
6991         * python/py-type.c: Update.
6992         * python/py-unwind.c: Update.
6993         * python/py-utils.c: Update.
6994         * python/py-value.c: Update.
6995         * python/python.c: Update.
6996         * record-btrace.c: Update.
6997         * record-full.c: Update.
6998         * remote-fileio.c: Update.
6999         * remote.c: Update.
7000         * riscv-tdep.c: Update.
7001         * rs6000-aix-tdep.c: Update.
7002         * rs6000-tdep.c: Update.
7003         * rust-exp.y: Update.
7004         * rust-lang.c: Update.
7005         * s390-tdep.c: Update.
7006         * selftest-arch.c: Update.
7007         * solib-dsbt.c: Update.
7008         * solib-frv.c: Update.
7009         * solib-spu.c: Update.
7010         * solib-svr4.c: Update.
7011         * solib.c: Update.
7012         * sparc64-linux-tdep.c: Update.
7013         * stack.c: Update.
7014         * symfile-mem.c: Update.
7015         * symmisc.c: Update.
7016         * target.c: Update.
7017         * thread.c: Update.
7018         * top.c: Update.
7019         * tracefile-tfile.c: Update.
7020         * tui/tui.c: Update.
7021         * typeprint.c: Update.
7022         * unittests/cli-utils-selftests.c: Update.
7023         * unittests/parse-connection-spec-selftests.c: Update.
7024         * valops.c: Update.
7025         * valprint.c: Update.
7026         * value.c: Update.
7027         * varobj.c: Update.
7028         * windows-nat.c: Update.
7029         * x86-linux-nat.c: Update.
7030         * xml-support.c: Update.
7031
7032 2019-04-08  Tom Tromey  <tom@tromey.com>
7033
7034         * xml-support.c: Use C++ exception handling.
7035         * x86-linux-nat.c: Use C++ exception handling.
7036         * windows-nat.c: Use C++ exception handling.
7037         * varobj.c: Use C++ exception handling.
7038         * value.c: Use C++ exception handling.
7039         * valprint.c: Use C++ exception handling.
7040         * valops.c: Use C++ exception handling.
7041         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7042         handling.
7043         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7044         * typeprint.c: Use C++ exception handling.
7045         * tui/tui.c: Use C++ exception handling.
7046         * tracefile-tfile.c: Use C++ exception handling.
7047         * top.c: Use C++ exception handling.
7048         * thread.c: Use C++ exception handling.
7049         * target.c: Use C++ exception handling.
7050         * symmisc.c: Use C++ exception handling.
7051         * symfile-mem.c: Use C++ exception handling.
7052         * stack.c: Use C++ exception handling.
7053         * sparc64-linux-tdep.c: Use C++ exception handling.
7054         * solib.c: Use C++ exception handling.
7055         * solib-svr4.c: Use C++ exception handling.
7056         * solib-spu.c: Use C++ exception handling.
7057         * solib-frv.c: Use C++ exception handling.
7058         * solib-dsbt.c: Use C++ exception handling.
7059         * selftest-arch.c: Use C++ exception handling.
7060         * s390-tdep.c: Use C++ exception handling.
7061         * rust-lang.c: Use C++ exception handling.
7062         * rust-exp.y: Use C++ exception handling.
7063         * rs6000-tdep.c: Use C++ exception handling.
7064         * rs6000-aix-tdep.c: Use C++ exception handling.
7065         * riscv-tdep.c: Use C++ exception handling.
7066         * remote.c: Use C++ exception handling.
7067         * remote-fileio.c: Use C++ exception handling.
7068         * record-full.c: Use C++ exception handling.
7069         * record-btrace.c: Use C++ exception handling.
7070         * python/python.c: Use C++ exception handling.
7071         * python/py-value.c: Use C++ exception handling.
7072         * python/py-utils.c: Use C++ exception handling.
7073         * python/py-unwind.c: Use C++ exception handling.
7074         * python/py-type.c: Use C++ exception handling.
7075         * python/py-symbol.c: Use C++ exception handling.
7076         * python/py-record.c: Use C++ exception handling.
7077         * python/py-record-btrace.c: Use C++ exception handling.
7078         * python/py-progspace.c: Use C++ exception handling.
7079         * python/py-prettyprint.c: Use C++ exception handling.
7080         * python/py-param.c: Use C++ exception handling.
7081         * python/py-objfile.c: Use C++ exception handling.
7082         * python/py-linetable.c: Use C++ exception handling.
7083         * python/py-lazy-string.c: Use C++ exception handling.
7084         * python/py-infthread.c: Use C++ exception handling.
7085         * python/py-inferior.c: Use C++ exception handling.
7086         * python/py-gdb-readline.c: Use C++ exception handling.
7087         * python/py-framefilter.c: Use C++ exception handling.
7088         * python/py-frame.c: Use C++ exception handling.
7089         * python/py-finishbreakpoint.c: Use C++ exception handling.
7090         * python/py-cmd.c: Use C++ exception handling.
7091         * python/py-breakpoint.c: Use C++ exception handling.
7092         * python/py-arch.c: Use C++ exception handling.
7093         * printcmd.c: Use C++ exception handling.
7094         * ppc-linux-tdep.c: Use C++ exception handling.
7095         * parse.c: Use C++ exception handling.
7096         * p-valprint.c: Use C++ exception handling.
7097         * objc-lang.c: Use C++ exception handling.
7098         * mi/mi-main.c: Use C++ exception handling.
7099         * mi/mi-interp.c: Use C++ exception handling.
7100         * mi/mi-cmd-stack.c: Use C++ exception handling.
7101         * mi/mi-cmd-break.c: Use C++ exception handling.
7102         * main.c: Use C++ exception handling.
7103         * linux-thread-db.c: Use C++ exception handling.
7104         * linux-tdep.c: Use C++ exception handling.
7105         * linux-nat.c: Use C++ exception handling.
7106         * linux-fork.c: Use C++ exception handling.
7107         * linespec.c: Use C++ exception handling.
7108         * language.c: Use C++ exception handling.
7109         * jit.c: Use C++ exception handling.
7110         * infrun.c: Use C++ exception handling.
7111         * infcmd.c: Use C++ exception handling.
7112         * infcall.c: Use C++ exception handling.
7113         * inf-loop.c: Use C++ exception handling.
7114         * i386-tdep.c: Use C++ exception handling.
7115         * i386-linux-tdep.c: Use C++ exception handling.
7116         * guile/scm-value.c: Use C++ exception handling.
7117         * guile/scm-type.c: Use C++ exception handling.
7118         * guile/scm-symtab.c: Use C++ exception handling.
7119         * guile/scm-symbol.c: Use C++ exception handling.
7120         * guile/scm-pretty-print.c: Use C++ exception handling.
7121         * guile/scm-ports.c: Use C++ exception handling.
7122         * guile/scm-param.c: Use C++ exception handling.
7123         * guile/scm-math.c: Use C++ exception handling.
7124         * guile/scm-lazy-string.c: Use C++ exception handling.
7125         * guile/scm-frame.c: Use C++ exception handling.
7126         * guile/scm-disasm.c: Use C++ exception handling.
7127         * guile/scm-cmd.c: Use C++ exception handling.
7128         * guile/scm-breakpoint.c: Use C++ exception handling.
7129         * guile/scm-block.c: Use C++ exception handling.
7130         * guile/guile-internal.h: Use C++ exception handling.
7131         * gnu-v3-abi.c: Use C++ exception handling.
7132         * gdbtypes.c: Use C++ exception handling.
7133         * frame.c: Use C++ exception handling.
7134         * frame-unwind.c: Use C++ exception handling.
7135         * fbsd-tdep.c: Use C++ exception handling.
7136         * f-valprint.c: Use C++ exception handling.
7137         * exec.c: Use C++ exception handling.
7138         * event-top.c: Use C++ exception handling.
7139         * event-loop.c: Use C++ exception handling.
7140         * eval.c: Use C++ exception handling.
7141         * dwarf2read.c: Use C++ exception handling.
7142         * dwarf2loc.c: Use C++ exception handling.
7143         * dwarf2-frame.c: Use C++ exception handling.
7144         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7145         * dwarf-index-write.c: Use C++ exception handling.
7146         * dwarf-index-cache.c: Use C++ exception handling.
7147         * dtrace-probe.c: Use C++ exception handling.
7148         * disasm-selftests.c: Use C++ exception handling.
7149         * darwin-nat.c: Use C++ exception handling.
7150         * cp-valprint.c: Use C++ exception handling.
7151         * cp-support.c: Use C++ exception handling.
7152         * cp-abi.c: Use C++ exception handling.
7153         * corelow.c: Use C++ exception handling.
7154         * completer.c: Use C++ exception handling.
7155         * compile/compile-object-run.c: Use C++ exception handling.
7156         * compile/compile-object-load.c: Use C++ exception handling.
7157         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7158         * compile/compile-c-symbols.c: Use C++ exception handling.
7159         * common/selftest.c: Use C++ exception handling.
7160         * common/new-op.c: Use C++ exception handling.
7161         * cli/cli-script.c: Use C++ exception handling.
7162         * cli/cli-interp.c: Use C++ exception handling.
7163         * cli/cli-cmds.c: Use C++ exception handling.
7164         * c-varobj.c: Use C++ exception handling.
7165         * btrace.c: Use C++ exception handling.
7166         * breakpoint.c: Use C++ exception handling.
7167         * break-catch-throw.c: Use C++ exception handling.
7168         * arch-utils.c: Use C++ exception handling.
7169         * amd64-tdep.c: Use C++ exception handling.
7170         * ada-valprint.c: Use C++ exception handling.
7171         * ada-typeprint.c: Use C++ exception handling.
7172         * ada-lang.c: Use C++ exception handling.
7173         * aarch64-tdep.c: Use C++ exception handling.
7174
7175 2019-04-08  Tom Tromey  <tom@tromey.com>
7176
7177         * xml-support.c (gdb_xml_parser::parse): Update.
7178         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7179         * value.c (show_convenience): Update.
7180         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7181         (test_parse_flags_qcs): Update.
7182         * thread.c (thr_try_catch_cmd): Update.
7183         * target.c (target_translate_tls_address): Update.
7184         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7185         (info_frame_command_core, frame_apply_command_count): Update.
7186         * rust-exp.y (rust_lex_exception_test): Update.
7187         * riscv-tdep.c (riscv_print_one_register_info): Update.
7188         * remote.c (remote_target::enable_btrace): Update.
7189         * record-btrace.c (record_btrace_enable_warn): Update.
7190         * python/py-utils.c (gdbpy_convert_exception): Update.
7191         * printcmd.c (do_one_display, print_variable_and_value): Update.
7192         * mi/mi-main.c (mi_print_exception): Update.
7193         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7194         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7195         * linux-nat.c (linux_nat_target::attach): Update.
7196         * linux-fork.c (class scoped_switch_fork_info): Update.
7197         * infrun.c (displaced_step_prepare): Update.
7198         * infcall.c (call_function_by_hand_dummy): Update.
7199         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7200         * gnu-v3-abi.c (print_one_vtable): Update.
7201         * frame.c (get_prev_frame_always): Update.
7202         * f-valprint.c (info_common_command_for_block): Update.
7203         * exec.c (try_open_exec_file): Update.
7204         * exceptions.c (print_exception, exception_print)
7205         (exception_fprintf, exception_print_same): Update.
7206         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7207         * dwarf-index-cache.c (index_cache::store)
7208         (index_cache::lookup_gdb_index): Update.
7209         * darwin-nat.c (maybe_cache_shell): Update.
7210         * cp-valprint.c (cp_print_value_fields): Update.
7211         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7212         (gcc_cplus_symbol_address): Update.
7213         * compile/compile-c-symbols.c (gcc_convert_symbol)
7214         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7215         * common/selftest.c: Update.
7216         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7217         a std::string.
7218         (exception_try_scope_entry, exception_try_scope_exit): Don't
7219         declare.
7220         (struct exception_try_scope): Remove.
7221         (TRY): Don't use exception_try_scope.
7222         (struct gdb_exception): Add constructor, operator=.
7223         <what>: New method.
7224         (struct gdb_exception_RETURN_MASK_ALL)
7225         (struct gdb_exception_RETURN_MASK_ERROR)
7226         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7227         (struct gdb_quit_bad_alloc): Update.
7228         * common/common-exceptions.c (exception_none): Change
7229         initializer.
7230         (struct catcher) <state, exception>: Initialize inline.
7231         <prev>: Remove member.
7232         (current_catcher): Remove.
7233         (catchers): New global.
7234         (exceptions_state_mc_init): Simplify.
7235         (catcher_pop): Remove.
7236         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7237         (try_scope_depth, exception_try_scope_entry)
7238         (exception_try_scope_exit): Remove.
7239         (throw_exception_sjlj): Update.
7240         (exception_messages, exception_messages_size): Remove.
7241         (throw_it): Simplify.
7242         (gdb_exception_sliced_copy): Remove.
7243         (throw_exception_cxx): Update.
7244         * cli/cli-script.c (script_from_file): Update.
7245         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7246         Update.
7247         * ada-valprint.c (ada_val_print): Update.
7248         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7249         (create_excep_cond_exprs): Update.
7250
7251 2019-04-08  Tom Tromey  <tom@tromey.com>
7252
7253         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7254         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7255         (TRY, CATCH, END_CATCH): Remove some definitions.
7256         * common/common-exceptions.c: Don't use GDB_XCPT.
7257         (catcher_list_size): Remove.
7258         (throw_exception, throw_it): Simplify.
7259
7260 2019-04-05  Tom Tromey  <tom@tromey.com>
7261
7262         Revert the header-sorting patch.
7263         * ft32-tdep.c: Revert.
7264         * frv-tdep.c: Revert.
7265         * frv-linux-tdep.c: Revert.
7266         * frame.c: Revert.
7267         * frame-unwind.c: Revert.
7268         * frame-base.c: Revert.
7269         * fork-child.c: Revert.
7270         * findvar.c: Revert.
7271         * findcmd.c: Revert.
7272         * filesystem.c: Revert.
7273         * filename-seen-cache.h: Revert.
7274         * filename-seen-cache.c: Revert.
7275         * fbsd-tdep.c: Revert.
7276         * fbsd-nat.h: Revert.
7277         * fbsd-nat.c: Revert.
7278         * f-valprint.c: Revert.
7279         * f-typeprint.c: Revert.
7280         * f-lang.c: Revert.
7281         * extension.h: Revert.
7282         * extension.c: Revert.
7283         * extension-priv.h: Revert.
7284         * expprint.c: Revert.
7285         * exec.h: Revert.
7286         * exec.c: Revert.
7287         * exceptions.c: Revert.
7288         * event-top.c: Revert.
7289         * event-loop.c: Revert.
7290         * eval.c: Revert.
7291         * elfread.c: Revert.
7292         * dwarf2read.h: Revert.
7293         * dwarf2read.c: Revert.
7294         * dwarf2loc.c: Revert.
7295         * dwarf2expr.h: Revert.
7296         * dwarf2expr.c: Revert.
7297         * dwarf2-frame.c: Revert.
7298         * dwarf2-frame-tailcall.c: Revert.
7299         * dwarf-index-write.h: Revert.
7300         * dwarf-index-write.c: Revert.
7301         * dwarf-index-common.c: Revert.
7302         * dwarf-index-cache.h: Revert.
7303         * dwarf-index-cache.c: Revert.
7304         * dummy-frame.c: Revert.
7305         * dtrace-probe.c: Revert.
7306         * disasm.h: Revert.
7307         * disasm.c: Revert.
7308         * disasm-selftests.c: Revert.
7309         * dictionary.c: Revert.
7310         * dicos-tdep.c: Revert.
7311         * demangle.c: Revert.
7312         * dcache.h: Revert.
7313         * dcache.c: Revert.
7314         * darwin-nat.h: Revert.
7315         * darwin-nat.c: Revert.
7316         * darwin-nat-info.c: Revert.
7317         * d-valprint.c: Revert.
7318         * d-namespace.c: Revert.
7319         * d-lang.c: Revert.
7320         * ctf.c: Revert.
7321         * csky-tdep.c: Revert.
7322         * csky-linux-tdep.c: Revert.
7323         * cris-tdep.c: Revert.
7324         * cris-linux-tdep.c: Revert.
7325         * cp-valprint.c: Revert.
7326         * cp-support.c: Revert.
7327         * cp-namespace.c: Revert.
7328         * cp-abi.c: Revert.
7329         * corelow.c: Revert.
7330         * corefile.c: Revert.
7331         * continuations.c: Revert.
7332         * completer.h: Revert.
7333         * completer.c: Revert.
7334         * complaints.c: Revert.
7335         * coffread.c: Revert.
7336         * coff-pe-read.c: Revert.
7337         * cli-out.h: Revert.
7338         * cli-out.c: Revert.
7339         * charset.c: Revert.
7340         * c-varobj.c: Revert.
7341         * c-valprint.c: Revert.
7342         * c-typeprint.c: Revert.
7343         * c-lang.c: Revert.
7344         * buildsym.c: Revert.
7345         * buildsym-legacy.c: Revert.
7346         * build-id.h: Revert.
7347         * build-id.c: Revert.
7348         * btrace.c: Revert.
7349         * bsd-uthread.c: Revert.
7350         * breakpoint.h: Revert.
7351         * breakpoint.c: Revert.
7352         * break-catch-throw.c: Revert.
7353         * break-catch-syscall.c: Revert.
7354         * break-catch-sig.c: Revert.
7355         * blockframe.c: Revert.
7356         * block.c: Revert.
7357         * bfin-tdep.c: Revert.
7358         * bfin-linux-tdep.c: Revert.
7359         * bfd-target.c: Revert.
7360         * bcache.c: Revert.
7361         * ax-general.c: Revert.
7362         * ax-gdb.h: Revert.
7363         * ax-gdb.c: Revert.
7364         * avr-tdep.c: Revert.
7365         * auxv.c: Revert.
7366         * auto-load.c: Revert.
7367         * arm-wince-tdep.c: Revert.
7368         * arm-tdep.c: Revert.
7369         * arm-symbian-tdep.c: Revert.
7370         * arm-pikeos-tdep.c: Revert.
7371         * arm-obsd-tdep.c: Revert.
7372         * arm-nbsd-tdep.c: Revert.
7373         * arm-nbsd-nat.c: Revert.
7374         * arm-linux-tdep.c: Revert.
7375         * arm-linux-nat.c: Revert.
7376         * arm-fbsd-tdep.c: Revert.
7377         * arm-fbsd-nat.c: Revert.
7378         * arm-bsd-tdep.c: Revert.
7379         * arch-utils.c: Revert.
7380         * arc-tdep.c: Revert.
7381         * arc-newlib-tdep.c: Revert.
7382         * annotate.h: Revert.
7383         * annotate.c: Revert.
7384         * amd64-windows-tdep.c: Revert.
7385         * amd64-windows-nat.c: Revert.
7386         * amd64-tdep.c: Revert.
7387         * amd64-sol2-tdep.c: Revert.
7388         * amd64-obsd-tdep.c: Revert.
7389         * amd64-obsd-nat.c: Revert.
7390         * amd64-nbsd-tdep.c: Revert.
7391         * amd64-nbsd-nat.c: Revert.
7392         * amd64-nat.c: Revert.
7393         * amd64-linux-tdep.c: Revert.
7394         * amd64-linux-nat.c: Revert.
7395         * amd64-fbsd-tdep.c: Revert.
7396         * amd64-fbsd-nat.c: Revert.
7397         * amd64-dicos-tdep.c: Revert.
7398         * amd64-darwin-tdep.c: Revert.
7399         * amd64-bsd-nat.c: Revert.
7400         * alpha-tdep.c: Revert.
7401         * alpha-obsd-tdep.c: Revert.
7402         * alpha-nbsd-tdep.c: Revert.
7403         * alpha-mdebug-tdep.c: Revert.
7404         * alpha-linux-tdep.c: Revert.
7405         * alpha-linux-nat.c: Revert.
7406         * alpha-bsd-tdep.c: Revert.
7407         * alpha-bsd-nat.c: Revert.
7408         * aix-thread.c: Revert.
7409         * agent.c: Revert.
7410         * addrmap.c: Revert.
7411         * ada-varobj.c: Revert.
7412         * ada-valprint.c: Revert.
7413         * ada-typeprint.c: Revert.
7414         * ada-tasks.c: Revert.
7415         * ada-lang.c: Revert.
7416         * aarch64-tdep.c: Revert.
7417         * aarch64-ravenscar-thread.c: Revert.
7418         * aarch64-newlib-tdep.c: Revert.
7419         * aarch64-linux-tdep.c: Revert.
7420         * aarch64-linux-nat.c: Revert.
7421         * aarch64-fbsd-tdep.c: Revert.
7422         * aarch64-fbsd-nat.c: Revert.
7423         * aarch32-linux-nat.c: Revert.
7424
7425 2019-04-05  Tom Tromey  <tom@tromey.com>
7426
7427         * ft32-tdep.c: Sort headers.
7428         * frv-tdep.c: Sort headers.
7429         * frv-linux-tdep.c: Sort headers.
7430         * frame.c: Sort headers.
7431         * frame-unwind.c: Sort headers.
7432         * frame-base.c: Sort headers.
7433         * fork-child.c: Sort headers.
7434         * findvar.c: Sort headers.
7435         * findcmd.c: Sort headers.
7436         * filesystem.c: Sort headers.
7437         * filename-seen-cache.h: Sort headers.
7438         * filename-seen-cache.c: Sort headers.
7439         * fbsd-tdep.c: Sort headers.
7440         * fbsd-nat.h: Sort headers.
7441         * fbsd-nat.c: Sort headers.
7442         * f-valprint.c: Sort headers.
7443         * f-typeprint.c: Sort headers.
7444         * f-lang.c: Sort headers.
7445         * extension.h: Sort headers.
7446         * extension.c: Sort headers.
7447         * extension-priv.h: Sort headers.
7448         * expprint.c: Sort headers.
7449         * exec.h: Sort headers.
7450         * exec.c: Sort headers.
7451         * exceptions.c: Sort headers.
7452         * event-top.c: Sort headers.
7453         * event-loop.c: Sort headers.
7454         * eval.c: Sort headers.
7455         * elfread.c: Sort headers.
7456         * dwarf2read.h: Sort headers.
7457         * dwarf2read.c: Sort headers.
7458         * dwarf2loc.c: Sort headers.
7459         * dwarf2expr.h: Sort headers.
7460         * dwarf2expr.c: Sort headers.
7461         * dwarf2-frame.c: Sort headers.
7462         * dwarf2-frame-tailcall.c: Sort headers.
7463         * dwarf-index-write.h: Sort headers.
7464         * dwarf-index-write.c: Sort headers.
7465         * dwarf-index-common.c: Sort headers.
7466         * dwarf-index-cache.h: Sort headers.
7467         * dwarf-index-cache.c: Sort headers.
7468         * dummy-frame.c: Sort headers.
7469         * dtrace-probe.c: Sort headers.
7470         * disasm.h: Sort headers.
7471         * disasm.c: Sort headers.
7472         * disasm-selftests.c: Sort headers.
7473         * dictionary.c: Sort headers.
7474         * dicos-tdep.c: Sort headers.
7475         * demangle.c: Sort headers.
7476         * dcache.h: Sort headers.
7477         * dcache.c: Sort headers.
7478         * darwin-nat.h: Sort headers.
7479         * darwin-nat.c: Sort headers.
7480         * darwin-nat-info.c: Sort headers.
7481         * d-valprint.c: Sort headers.
7482         * d-namespace.c: Sort headers.
7483         * d-lang.c: Sort headers.
7484         * ctf.c: Sort headers.
7485         * csky-tdep.c: Sort headers.
7486         * csky-linux-tdep.c: Sort headers.
7487         * cris-tdep.c: Sort headers.
7488         * cris-linux-tdep.c: Sort headers.
7489         * cp-valprint.c: Sort headers.
7490         * cp-support.c: Sort headers.
7491         * cp-namespace.c: Sort headers.
7492         * cp-abi.c: Sort headers.
7493         * corelow.c: Sort headers.
7494         * corefile.c: Sort headers.
7495         * continuations.c: Sort headers.
7496         * completer.h: Sort headers.
7497         * completer.c: Sort headers.
7498         * complaints.c: Sort headers.
7499         * coffread.c: Sort headers.
7500         * coff-pe-read.c: Sort headers.
7501         * cli-out.h: Sort headers.
7502         * cli-out.c: Sort headers.
7503         * charset.c: Sort headers.
7504         * c-varobj.c: Sort headers.
7505         * c-valprint.c: Sort headers.
7506         * c-typeprint.c: Sort headers.
7507         * c-lang.c: Sort headers.
7508         * buildsym.c: Sort headers.
7509         * buildsym-legacy.c: Sort headers.
7510         * build-id.h: Sort headers.
7511         * build-id.c: Sort headers.
7512         * btrace.c: Sort headers.
7513         * bsd-uthread.c: Sort headers.
7514         * breakpoint.h: Sort headers.
7515         * breakpoint.c: Sort headers.
7516         * break-catch-throw.c: Sort headers.
7517         * break-catch-syscall.c: Sort headers.
7518         * break-catch-sig.c: Sort headers.
7519         * blockframe.c: Sort headers.
7520         * block.c: Sort headers.
7521         * bfin-tdep.c: Sort headers.
7522         * bfin-linux-tdep.c: Sort headers.
7523         * bfd-target.c: Sort headers.
7524         * bcache.c: Sort headers.
7525         * ax-general.c: Sort headers.
7526         * ax-gdb.h: Sort headers.
7527         * ax-gdb.c: Sort headers.
7528         * avr-tdep.c: Sort headers.
7529         * auxv.c: Sort headers.
7530         * auto-load.c: Sort headers.
7531         * arm-wince-tdep.c: Sort headers.
7532         * arm-tdep.c: Sort headers.
7533         * arm-symbian-tdep.c: Sort headers.
7534         * arm-pikeos-tdep.c: Sort headers.
7535         * arm-obsd-tdep.c: Sort headers.
7536         * arm-nbsd-tdep.c: Sort headers.
7537         * arm-nbsd-nat.c: Sort headers.
7538         * arm-linux-tdep.c: Sort headers.
7539         * arm-linux-nat.c: Sort headers.
7540         * arm-fbsd-tdep.c: Sort headers.
7541         * arm-fbsd-nat.c: Sort headers.
7542         * arm-bsd-tdep.c: Sort headers.
7543         * arch-utils.c: Sort headers.
7544         * arc-tdep.c: Sort headers.
7545         * arc-newlib-tdep.c: Sort headers.
7546         * annotate.h: Sort headers.
7547         * annotate.c: Sort headers.
7548         * amd64-windows-tdep.c: Sort headers.
7549         * amd64-windows-nat.c: Sort headers.
7550         * amd64-tdep.c: Sort headers.
7551         * amd64-sol2-tdep.c: Sort headers.
7552         * amd64-obsd-tdep.c: Sort headers.
7553         * amd64-obsd-nat.c: Sort headers.
7554         * amd64-nbsd-tdep.c: Sort headers.
7555         * amd64-nbsd-nat.c: Sort headers.
7556         * amd64-nat.c: Sort headers.
7557         * amd64-linux-tdep.c: Sort headers.
7558         * amd64-linux-nat.c: Sort headers.
7559         * amd64-fbsd-tdep.c: Sort headers.
7560         * amd64-fbsd-nat.c: Sort headers.
7561         * amd64-dicos-tdep.c: Sort headers.
7562         * amd64-darwin-tdep.c: Sort headers.
7563         * amd64-bsd-nat.c: Sort headers.
7564         * alpha-tdep.c: Sort headers.
7565         * alpha-obsd-tdep.c: Sort headers.
7566         * alpha-nbsd-tdep.c: Sort headers.
7567         * alpha-mdebug-tdep.c: Sort headers.
7568         * alpha-linux-tdep.c: Sort headers.
7569         * alpha-linux-nat.c: Sort headers.
7570         * alpha-bsd-tdep.c: Sort headers.
7571         * alpha-bsd-nat.c: Sort headers.
7572         * aix-thread.c: Sort headers.
7573         * agent.c: Sort headers.
7574         * addrmap.c: Sort headers.
7575         * ada-varobj.c: Sort headers.
7576         * ada-valprint.c: Sort headers.
7577         * ada-typeprint.c: Sort headers.
7578         * ada-tasks.c: Sort headers.
7579         * ada-lang.c: Sort headers.
7580         * aarch64-tdep.c: Sort headers.
7581         * aarch64-ravenscar-thread.c: Sort headers.
7582         * aarch64-newlib-tdep.c: Sort headers.
7583         * aarch64-linux-tdep.c: Sort headers.
7584         * aarch64-linux-nat.c: Sort headers.
7585         * aarch64-fbsd-tdep.c: Sort headers.
7586         * aarch64-fbsd-nat.c: Sort headers.
7587         * aarch32-linux-nat.c: Sort headers.
7588
7589 2019-04-04  Tom Tromey  <tom@tromey.com>
7590
7591         * varobj.c (varobj_create): Update.
7592         * rust-exp.y (struct rust_parser) <update_innermost_block,
7593         lookup_symbol>: New methods.
7594         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7595         Rename.
7596         (rust_parser::rust_lookup_type)
7597         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7598         * printcmd.c (display_command, do_one_display): Update.
7599         * parser-defs.h (struct parser_state) <parser_state>: Add
7600         "tracker" parameter.
7601         (block_tracker): New member.
7602         (class innermost_block_tracker) <innermost_block_tracker>: Add
7603         "types" parameter.
7604         <reset>: Remove method.
7605         (innermost_block): Don't declare.
7606         (null_post_parser): Update.
7607         * parse.c (innermost_block): Remove global.
7608         (write_dollar_variable): Update.
7609         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7610         Remove "tracker_types" parameter.
7611         (parse_expression): Add "tracker" parameter.
7612         (parse_expression_for_completion): Update.
7613         (null_post_parser): Add "tracker" parameter.
7614         * p-exp.y: Update rules.
7615         * m2-exp.y: Update rules.
7616         * language.h (struct language_defn) <la_post_parser>: Add
7617         "tracker" parameter.
7618         * go-exp.y: Update rules.
7619         * f-exp.y: Update rules.
7620         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7621         parameter.
7622         * d-exp.y: Update rules.
7623         * c-exp.y: Update rules.
7624         * breakpoint.c (set_breakpoint_condition): Create an
7625         innermost_block_tracker.
7626         (watch_command_1): Likewise.
7627         * ada-lang.c (resolve): Add "tracker" parameter.
7628         (resolve_subexp): Likewise.
7629         * ada-exp.y (write_var_from_sym): Update.
7630
7631 2019-04-04  Tom Tromey  <tom@tromey.com>
7632
7633         * type-stack.h: New file.
7634         * type-stack.c: New file.
7635         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7636         type-stack.h.
7637         (insert_into_type_stack, insert_type, push_type, push_type_int)
7638         (insert_type_address_space, pop_type, pop_type_int)
7639         (pop_typelist, pop_type_stack, append_type_stack)
7640         (push_type_stack, get_type_stack, push_typelist)
7641         (follow_type_instance_flags, follow_types): Don't declare.
7642         * parse.c (type_stack): Remove global.
7643         (parse_exp_in_context): Update.
7644         (insert_into_type_stack, insert_type, push_type, push_type_int)
7645         (insert_type_address_space, pop_type, pop_type_int)
7646         (pop_typelist, pop_type_stack, append_type_stack)
7647         (push_type_stack, get_type_stack, push_typelist)
7648         (follow_type_instance_flags, follow_types): Remove (moved to
7649         type-stack.c).
7650         * f-exp.y (type_stack): New global.
7651         Update rules.
7652         (push_kind_type, f_parse): Update.
7653         * d-exp.y (type_stack): New global.
7654         Update rules.
7655         (d_parse): Update.
7656         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7657         Update rules.
7658         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7659         (HFILES_NO_SRCDIR): Add type-stack.h.
7660
7661 2019-04-04  Tom Tromey  <tom@tromey.com>
7662
7663         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7664         (rust_parser::convert_ast_to_expression, rust_parse)
7665         (rust_lex_test_completion, rust_lex_tests): Update.
7666         * parser-defs.h (struct expr_completion_state): New.
7667         (struct parser_state) <parser_state>: Add completion parameter.
7668         <mark_struct_expression, mark_completion_tag>: New methods.
7669         <parse_completion, m_completion_state>: New members.
7670         (prefixify_expression, null_post_parser): Update.
7671         (mark_struct_expression, mark_completion_tag): Don't declare.
7672         * parse.c (parse_completion, expout_last_struct)
7673         (expout_tag_completion_type, expout_completion_name): Remove
7674         globals.
7675         (parser_state::mark_struct_expression)
7676         (parser_state::mark_completion_tag): Now methods.
7677         (prefixify_expression): Add last_struct parameter.
7678         (prefixify_subexp): Likewise.
7679         (parse_exp_1): Update.
7680         (parse_exp_in_context): Add cstate parameter.  Update.
7681         (parse_expression_for_completion): Create an
7682         expr_completion_state.
7683         (null_post_parser): Add "completion" parameter.
7684         * p-exp.y: Update rules.
7685         (yylex): Update.
7686         * language.h (struct language_defn) <la_post_parser>: Add
7687         "completing" parameter.
7688         * go-exp.y: Update rules.
7689         (lex_one_token): Update.
7690         * expression.h (parse_completion): Don't declare.
7691         * d-exp.y: Update rules.
7692         (lex_one_token): Update rules.
7693         * c-exp.y: Update rules.
7694         (lex_one_token): Update.
7695         * ada-lang.c (resolve): Add "parse_completion" parameter.
7696         (resolve_subexp): Likewise.
7697         (ada_resolve_function): Likewise.
7698
7699 2019-04-04  Tom Tromey  <tom@tromey.com>
7700
7701         * parser-defs.h (struct parser_state) <start_arglist,
7702         end_arglist>: New methods.
7703         <arglist_len, m_funcall_chain>: New members.
7704         (arglist_len, start_arglist, end_arglist): Don't declare.
7705         * parse.c (arglist_len, funcall_chain): Remove global.
7706         (start_arglist, end_arglist): Remove functions.
7707         (parse_exp_in_context): Update.
7708         * p-exp.y: Update rules.
7709         * m2-exp.y: Update rules.
7710         * go-exp.y: Update rules.
7711         * f-exp.y: Update rules.
7712         * d-exp.y: Update rules.
7713         * c-exp.y: Update rules.
7714
7715 2019-04-04  Tom Tromey  <tom@tromey.com>
7716
7717         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7718         lex_operator, push_back>: New methods.
7719         Update all rules.
7720         (rust_parser::lex_hex, lex_escape): Rename and update.
7721         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7722         (rust_parser::lex_operator): Rename and update.
7723         (rust_parser::lex_number, rustyylex, rustyyerror)
7724         (rust_lex_test_init, rust_lex_test_sequence)
7725         (rust_lex_test_push_back, rust_lex_tests): Update.
7726         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7727         parameter.
7728         <lexptr, prev_lexptr>: New members.
7729         (lexptr, prev_lexptr): Don't declare.
7730         * parse.c (lexptr, prev_lexptr): Remove globals.
7731         (parse_exp_in_context): Update.
7732         * p-exp.y (yylex, yyerror): Update.
7733         * m2-exp.y (parse_number, yylex, yyerror): Update.
7734         * go-exp.y (lex_one_token, yyerror): Update.
7735         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7736         * d-exp.y (lex_one_token, yyerror): Update.
7737         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7738         (lex_one_token, yyerror): Update.
7739         * ada-lex.l (YY_INPUT): Update.
7740         (rewind_to_char): Update.
7741         * ada-exp.y (yyerror): Update.
7742
7743 2019-04-04  Tom Tromey  <tom@tromey.com>
7744
7745         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7746         * parser-defs.h (struct parser_state) <parser_state>: Add new
7747         parameter.
7748         <comma_terminates>: New member.
7749         (comma_terminates): Don't declare global.
7750         * parse.c (comma_terminates): Remove global.
7751         (parse_exp_in_context): Update.
7752         * p-exp.y (yylex): Update.
7753         * m2-exp.y (yylex): Update.
7754         * go-exp.y (lex_one_token): Update.
7755         * f-exp.y (yylex): Update.
7756         * d-exp.y (lex_one_token): Update.
7757         * c-exp.y (lex_one_token): Update.
7758         * ada-lex.l: Update.
7759
7760 2019-04-04  Tom Tromey  <tom@tromey.com>
7761
7762         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7763         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7764         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7765         * parser-defs.h (paren_depth): Don't declare.
7766         * parse.c (paren_depth): Remove global.
7767         (parse_exp_in_context): Update.
7768         * p-exp.y (paren_depth): New global.
7769         (pascal_parse): Initialize it.
7770         * m2-exp.y (paren_depth): New global.
7771         (m2_parse): Initialize it.
7772         * go-exp.y (paren_depth): New global.
7773         (go_parse): Initialize it.
7774         * f-exp.y (paren_depth): New global.
7775         (f_parse): Initialize it.
7776         * d-exp.y (paren_depth): New global.
7777         (d_parse): Initialize it.
7778         * c-exp.y (paren_depth): New global.
7779         (c_parse): Initialize it.
7780         * ada-lex.l (paren_depth): New global.
7781         (lexer_init): Initialize it.
7782
7783 2019-04-04  Tom Tromey  <tom@tromey.com>
7784
7785         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7786         (rust_parser::convert_ast_to_type)
7787         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7788         * parser-defs.h (struct parser_state) <parser_state>: Add
7789         parameters.  Initialize new members.
7790         <expression_context_block, expression_context_pc>: New members.
7791         * parse.c (expression_context_block, expression_context_pc):
7792         Remove globals.
7793         (parse_exp_in_context): Update.
7794         * p-exp.y: Update all rules.
7795         (yylex): Update.
7796         * m2-exp.y: Update all rules.
7797         (yylex): Update.
7798         * go-exp.y (yylex): Update.
7799         * f-exp.y (yylex): Update.
7800         * d-exp.y: Update all rules.
7801         (yylex): Update.
7802         * c-exp.y: Update all rules.
7803         (lex_one_token, classify_name, yylex, c_parse): Update.
7804         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7805
7806 2019-04-04  Tom Tromey  <tom@tromey.com>
7807
7808         * gdbarch.h, gdbarch.c: Rebuild.
7809         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7810         * stap-probe.h:
7811         (struct stap_parse_info): Replace "parser_state" with
7812         "expr_builder".
7813         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7814         (parser_state): New class.
7815         * parse.c (expr_builder): Rename.
7816         (expr_builder::release): Rename.
7817         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7818         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7819         (write_exp_elt_longcst, write_exp_elt_floatcst)
7820         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7821         (write_exp_string_vector, write_exp_bitstring)
7822         (write_exp_msymbol, mark_struct_expression)
7823         (write_dollar_variable)
7824         (insert_type_address_space, increase_expout_size): Replace
7825         "parser_state" with "expr_builder".
7826         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7827         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7828         "parser_state" with "expr_builder".
7829
7830 2019-04-04  Tom Tromey  <tom@tromey.com>
7831
7832         * rust-exp.y: Replace "parse_language" with method call.
7833         * p-exp.y:
7834         (yylex): Replace "parse_language" with method call.
7835         * m2-exp.y:
7836         (yylex): Replace "parse_language" with method call.
7837         * go-exp.y (classify_name): Replace "parse_language" with method
7838         call.
7839         * f-exp.y (yylex): Replace "parse_language" with method call.
7840         * d-exp.y (lex_one_token): Replace "parse_language" with method
7841         call.
7842         * c-exp.y:
7843         (lex_one_token, classify_name, yylex): Replace "parse_language"
7844         with method call.
7845         * ada-exp.y (find_primitive_type, type_char)
7846         (type_system_address): Replace "parse_language" with method call.
7847
7848 2019-04-04  Tom Tromey  <tom@tromey.com>
7849
7850         * rust-exp.y: Replace "parse_gdbarch" with method call.
7851         * parse.c (write_dollar_variable, insert_type_address_space):
7852         Replace "parse_gdbarch" with method call.
7853         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7854         call.
7855         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7856         call.
7857         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7858         "parse_gdbarch" with method call.
7859         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7860         with method call.
7861         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7862         "parse_gdbarch" with method call.
7863         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7864         "parse_gdbarch" with method call.
7865         * c-exp.y (parse_type, parse_number, classify_name): Replace
7866         "parse_gdbarch" with method call.
7867         * ada-lex.l: Replace "parse_gdbarch" with method call.
7868         * ada-exp.y (parse_type, find_primitive_type, type_char)
7869         (type_system_address): Replace "parse_gdbarch" with method call.
7870
7871 2019-04-04  Tom Tromey  <tom@tromey.com>
7872
7873         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7874         * stap-probe.c (stap_parse_argument): Update.
7875         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7876         initial_size parameter.
7877         * rust-exp.y (rust_lex_tests): Update.
7878         * parse.c (parser_state): Update.
7879         (parse_exp_in_context): Update.
7880         * parser-defs.h (struct parser_state) <parser_state>: Remove
7881         "initial_size" parameter.
7882
7883 2019-04-04  Tom Tromey  <tom@tromey.com>
7884
7885         * parser-defs.h (increase_expout_size): Don't declare.
7886         * parse.c (increase_expout_size): Now static.
7887
7888 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7889
7890         * gnu-nat.c (gnu_nat_target::wait): Fix
7891         target_waitstatus_to_string call.
7892
7893 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7894
7895         * eval.c (evaluate_subexp_standard): Handle internal functions
7896         during Fortran function call handling.
7897
7898 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7899
7900         * NEWS: Mention new internal functions.
7901         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7902         (read_base_type): Use dwarf2_init_complex_target_type.
7903         * value.c (creal_internal_fn): New function.
7904         (cimag_internal_fn): New function.
7905         (_initialize_values): Register new internal functions.
7906
7907 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7908
7909         * infrun.c (stop_all_threads): If debug_infrun, always
7910         trace the wait status after wait_one, using
7911         target_waitstatus_to_string and target_pid_to_str.
7912         (handle_inferior_event): Replace various trace of
7913         wait status kind by a single trace.
7914         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7915         wait status kind image by target_waitstatus_to_string.
7916         * target/waitstatus.c (target_waitstatus_to_string): Fix
7917         obsolete comment.
7918
7919 2019-04-01  Tom Tromey  <tromey@adacore.com>
7920
7921         PR symtab/23331:
7922         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7923
7924 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7925             Pedro Alves  <palves@redhat.com>
7926
7927         * top.c (quit_force): Call 'finalize_values'.
7928         * value.c (finalize_values): New function.
7929         * value.h (finalize_values): Declare.
7930
7931 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7932
7933         * NEWS: Announce $_gdb_major and $_gdb_minor.
7934
7935         * top.c (init_gdb_version_vars): New function.
7936         (gdb_init): Call init_gdb_version_vars.
7937
7938 2019-03-29  Tom Tromey  <tromey@adacore.com>
7939
7940         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7941         help text.  Remove dead code.
7942
7943 2019-03-29  Keith Seitz  <keiths@redhat.com>
7944
7945         From Siddhesh Poyarekar:
7946         * f-lang.h (f77_get_upperbound): Return LONGEST.
7947         (f77_get_lowerbound): Likewise.
7948         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7949         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7950         print them.
7951         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7952         plongest to format print it.
7953         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7954         (f77_get_upperbound): Likewise.
7955         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7956         LOWER_BOUND to LONGEST.
7957         (f77_create_arrayprint_offset_tbl): Likewise.
7958
7959 2019-03-29  Keith Seitz  <keiths@redhat.com>
7960
7961         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7962         %s/pulongest for TYPE_LENGTH instead of %d in format
7963         strings.
7964         * ada-typerint.c (ada_print_type): Likewise.
7965         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7966         * compile/compile-c-support.c (generate_register_struct): Likewise.
7967         * gdbtypes.c (recursive_dump_type): Likewise.
7968         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7969         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7970         instead of %d in format strings.
7971         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7972         to std::min to ULONGEST.
7973         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7974         instead of %d in format strings.
7975         * tracepoint.c (info_scope_command): Likewise.
7976         * typeprint.c (print_offset_data::update)
7977         (print_offset_data::finish): Likewise.
7978         * xtensa-tdep.c (xtensa_store_return_value)
7979         (xtensa_push_dummy_call): Likewise.
7980
7981 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7982
7983         * windows-nat.c (display_selector): Fixed format specifications
7984         for 64-bit Cygwin.
7985
7986 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7987
7988         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7989
7990 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7991
7992         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7993         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7994         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7995         (nios2_linux_init_abi): Install it.
7996
7997 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7998
7999         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8000
8001 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8002
8003         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8004
8005 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8006             Tom Tromey  <tromey@adacore.com>
8007
8008         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8009
8010 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8011
8012         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8013         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8014         method to compute the bounds of range types. Also print "[evaluated]"
8015         if the bounds' values come from a dynamic evaluation.
8016
8017 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8018
8019         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8020         whitespace when pretty printing is on.
8021
8022 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8023
8024         * ppc-linux-nat.c: Add include.
8025
8026 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8027
8028         * NEWS: Mention AArch64 Pointer Authentication.
8029
8030 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8031
8032         * arm-linux-nat.c: Add include.
8033
8034 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8035
8036         * source-cache.c (source_cache::get_source_lines): Re-read
8037         fullname after calling open_source_file.
8038
8039 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8040
8041         * NEWS: Mention TLS support for FreeBSD.
8042
8043 2019-03-25  Tom Tromey  <tromey@adacore.com>
8044
8045         * minsyms.c (BUNCH_SIZE): Update comment.
8046         (~minimal_symbol_reader): Remove old comment.
8047         (compact_minimal_symbols): Update comment.
8048         (minimal_symbol_reader::install): Remove old comment.  Update
8049         other comments.
8050
8051 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8052
8053         * s390-linux-nat.c: Add include.
8054
8055 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8056
8057         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8058         Call linux_get_hwcap.
8059         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8060         Likewise.
8061         (aarch64_linux_get_hwcap): Remove function.
8062         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8063         declaration.
8064         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8065         linux_get_hwcap.
8066         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8067         * linux-tdep.c (linux_get_hwcap): Add function.
8068         (linux_get_hwcap2): Likewise.
8069         * linux-tdep.h (linux_get_hwcap): Add declaration.
8070         (linux_get_hwcap2): Likewise.
8071         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8072         (ppc_linux_get_hwcap2): Likewise.
8073         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8074         linux_get_hwcap.
8075         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8076         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8077         (ppc_linux_nat_target::read_description): Likewise.
8078         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8079         * s390-linux-nat.c: Likewise.
8080         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8081
8082 2019-03-24  Tom Tromey  <tom@tromey.com>
8083
8084         * ada-lang.c (standard_lookup): Simplify initialization.
8085         (ada_lookup_symbol_nonlocal): Simplify return.
8086         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8087         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8088         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8089         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8090         initialization.
8091         * solib.c (solib_global_lookup): Simplify.
8092         * symtab.c (null_block_symbol): Remove.
8093         (symbol_cache_lookup): Simplify returns.
8094         (lookup_language_this): Simplify returns.
8095         (lookup_symbol_aux): Simplify return.
8096         (lookup_local_symbol): Simplify returns.
8097         (lookup_global_symbol_from_objfile): Simplify return.
8098         (lookup_symbol_in_objfile_symtabs)
8099         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8100         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8101         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8102         * cp-namespace.c (cp_lookup_bare_symbol)
8103         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8104         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8105         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8106         (cp_lookup_symbol_via_imports): Simplify initialization.
8107         (find_symbol_in_baseclass): Likewise.
8108         * symtab.h (null_block_symbol): Remove.
8109         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8110         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8111         (d_lookup_symbol_module): Likewise.
8112         (find_symbol_in_baseclass): Simplify initialization.
8113
8114 2019-03-24  Tom Tromey  <tom@tromey.com>
8115
8116         * expression.h: Don't include symtab.h.
8117         (struct block): Forward declare.
8118
8119 2019-03-24  Tom Tromey  <tom@tromey.com>
8120
8121         * c-exp.y (typebase): Remove casts.
8122         * gdbtypes.c (lookup_unsigned_typename, )
8123         (lookup_signed_typename): Remove cast.
8124         * eval.c (parse_to_comma_and_eval): Remove cast.
8125         * parse.c (write_dollar_variable): Remove cast.
8126         * block.h (struct block) <superblock>: Now const.
8127         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8128         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8129         (map_block): Make "block" const.
8130         * symfile.h (struct quick_symbol_functions)
8131         <map_matching_symbols>: Constify block argument to "callback".
8132         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8133         const.
8134         (find_pc_sect_compunit_symtab): Make "b" const.
8135         (find_symbol_at_address): Likewise.
8136         (search_symbols): Likewise.
8137         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8138         (dw2_debug_names_lookup_symbol): Likewise.
8139         (dw2_map_matching_symbols): Update.
8140         * p-valprint.c (pascal_val_print): Remove "block".
8141         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8142         (aux_add_nonlocal_symbols): Make "block" const.
8143         (resolve_subexp): Remove cast.
8144         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8145         const.
8146         (iterate_over_file_blocks): Likewise.
8147         * f-exp.y (%union) <bval>: Remove.
8148         * coffread.c (patch_opaque_types): Make "b" const.
8149         * spu-tdep.c (spu_catch_start): Make "block" const.
8150         * c-valprint.c (print_unpacked_pointer): Remove "block".
8151         * symmisc.c (dump_symtab_1): Make "b" const.
8152         (block_depth): Make "block" const.
8153         * d-exp.y (%union) <bval>: Remove.
8154         * cp-support.h (cp_lookup_rtti_type): Update.
8155         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8156         * psymtab.c (psym_lookup_symbol): Make "block" const.
8157         (maintenance_check_psymtabs): Make "b" const.
8158         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8159         (enumerate_locals, enumerate_args): Update.
8160         * python/py-symtab.c (stpy_global_block): Make "block" const.
8161         (stpy_static_block): Likewise.
8162         * inline-frame.c (block_starting_point_at): Make "new_block"
8163         const.
8164         * block.c (find_block_in_blockvector): Make return type const.
8165         (blockvector_for_pc_sect): Make "b" const.
8166         (find_block_in_blockvector): Make "b" const.
8167
8168 2019-03-23  Tom Tromey  <tom@tromey.com>
8169
8170         * varobj.c (varobj_create): Update.
8171         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8172         * printcmd.c (display_command, do_one_display): Don't reset
8173         innermost_block.
8174         * parser-defs.h (enum innermost_block_tracker_type): Move to
8175         expression.h.
8176         (innermost_block): Update comment.
8177         * parse.c (parse_exp_1): Add tracker_types parameter.
8178         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8179         tracker_types parameter.  Reset innermost_block.
8180         (parse_exp_in_context): Remove.
8181         (parse_expression_for_completion): Update.
8182         * objfiles.c (~objfile): Don't reset expression_context_block or
8183         innermost_block.
8184         * expression.h (enum innermost_block_tracker_type): Move from
8185         parser-defs.h.
8186         (parse_exp_1): Add tracker_types parameter.
8187         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8188         reset innermost_block.
8189
8190 2019-03-23  Tom Tromey  <tom@tromey.com>
8191
8192         * objfiles.h: Include bcache.h.
8193
8194 2019-03-23  Tom Tromey  <tom@tromey.com>
8195
8196         * linespec.c (get_current_search_block): Use
8197         scoped_restore_current_language.
8198         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8199
8200 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8201             Jiong Wang  <jiong.wang@arm.com>
8202
8203         * aarch64-linux-tdep.c
8204         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8205         section.
8206         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8207
8208 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8209             Jiong Wang  <jiong.wang@arm.com>
8210
8211         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8212         instructions.
8213         (aarch64_analyze_prologue_test): Add PACIASP test.
8214         (aarch64_prologue_prev_register): Unmask PC value.
8215
8216 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8217             Jiong Wang  <jiong.wang@arm.com>
8218
8219         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8220         (aarch64_dwarf2_prev_register): Unmask PC value.
8221         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8222         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8223         DW_CFA_AARCH64_negate_ra_state.
8224         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8225
8226 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8227             Jiong Wang  <jiong.wang@arm.com>
8228
8229         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8230         registers.
8231         (aarch64_pseudo_register_name): Likewise.
8232         (aarch64_pseudo_register_type): Likewise.
8233         (aarch64_pseudo_register_reggroup_p): Likewise.
8234         (aarch64_gdbarch_init): Add pauth registers.
8235         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8236         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8237         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8238         (struct gdbarch_tdep): Add regnum for ra_state.
8239
8240 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8241             Jiong Wang  <jiong.wang@arm.com>
8242
8243         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8244
8245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8246             Jiong Wang  <jiong.wang@arm.com>
8247
8248         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8249         function.
8250         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8251         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8252         (aarch64_gdbarch_init): Add puth registers.
8253         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8254         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8255         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8256
8257 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8258             Jiong Wang  <jiong.wang@arm.com>
8259
8260         * aarch64-linux-nat.c
8261         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8262         * aarch64-linux-tdep.c
8263         (aarch64_linux_core_read_description): Likewise.
8264         (aarch64_linux_get_hwcap): New function.
8265         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8266         (aarch64_linux_get_hwcap): New declaration.
8267
8268 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8269             Jiong Wang  <jiong.wang@arm.com>
8270
8271         * aarch64-linux-nat.c
8272         (aarch64_linux_nat_target::read_description): Add pauth param.
8273         * aarch64-linux-tdep.c
8274         (aarch64_linux_core_read_description): Likewise.
8275         * aarch64-tdep.c (struct target_desc): Add in pauth.
8276         (aarch64_read_description): Add pauth param.
8277         (aarch64_gdbarch_init): Likewise.
8278         * aarch64-tdep.h (aarch64_read_description): Likewise.
8279         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8280         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8281         * features/Makefile: Add new files.
8282         * features/aarch64-pauth.c: New file.
8283         * features/aarch64-pauth.xml: New file.
8284
8285 2019-03-20  Tom Tromey  <tromey@adacore.com>
8286
8287         * infrun.c (handle_inferior_event): Rename from
8288         handle_inferior_event_1.  Create a scoped_value_mark.
8289         (handle_inferior_event): Remove.
8290
8291 2019-03-19  Tom Tromey  <tromey@adacore.com>
8292
8293         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8294         * infrun.h (print_stop_event): Add "displays" parameter.
8295         * infrun.c (print_stop_event): Add "displays" parameter.
8296
8297 2019-03-19  Pedro Alves  <palves@redhat.com>
8298
8299         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8300         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8301         to -1.  Fix TABs vs spaces.
8302         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8303         * tui/tui-out.h (tui_ui_out) Add intro comments.
8304         <m_line, m_start_of_line>: In-class initialize, and add describing
8305         comment.
8306
8307 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8308
8309         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8310         variable names.
8311         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8312
8313 2019-03-18  Pedro Alves  <palves@redhat.com>
8314             Eli Zaretskii <eliz@gnu.org>
8315
8316         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8317         m_line and m_start_of_line.
8318
8319 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8320
8321         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8322         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8323         it returns a newline.  This fixes a regression in TU mode, whereby
8324         the next line is output on the same screen line as the user input.
8325
8326 2019-03-18  Tom Tromey  <tromey@adacore.com>
8327
8328         * minsyms.c (minimal_symbol_reader::install): Remove call to
8329         obstack_blank.
8330
8331 2019-03-18  Pedro Alves  <palves@redhat.com>
8332
8333         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8334         New globals.
8335         (apply_style): New, factored out from ...
8336         (apply_ansi_escape): ... this.  Handle reverse video mode.
8337         (tui_set_reverse_mode): New function.
8338         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8339         * tui/tui-winsource.c (tui_show_source_line): Use
8340         tui_set_reverse_mode instead of setting A_STANDOUT.
8341         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8342         New setter methods.
8343
8344 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8345
8346         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8347         Handle tabs.
8348
8349 2019-03-18  Tom Tromey  <tromey@adacore.com>
8350
8351         * ada-lang.c (empty_array): Add "high" parameter.
8352         (ada_evaluate_subexp): Update.
8353
8354 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8355
8356         * unittests/string_view-selftests.c: Define
8357         _initialize_string_view_selftests unconditionally.
8358
8359 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8360
8361         PR gdb/24350
8362         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8363
8364 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8365
8366         PR gdb/24351
8367         * windows-nat.c (display_selector): Fix format specifiers.
8368
8369 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8370
8371         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8372         tui_refill_source_window instead of tui_refresh_win, to update the
8373         current execution line.  This fixes redisplay of the current line
8374         when stepping through the code with "next" or "step".
8375
8376 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8377
8378         * source-cache.c (source_cache::get_source_lines): Call
8379         find_source_lines to initialize s->nlines.  This fixes vertical
8380         scrolling of TUI source window when the DOWN arrow is pressed.
8381
8382 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8383
8384         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8385         linux-thread-db.c (_initialize_thread_db): Likewise.
8386
8387 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8388
8389         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8390         wclrtoeol in tui_show_source_line".  This reverts changes made in
8391         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8392
8393 2019-03-15  Tom Tromey  <tom@tromey.com>
8394
8395         * symtab.h (struct minimal_symbol): Derive from
8396         general_symbol_info.
8397         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8398         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8399         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8400         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8401         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8402         (MSYMBOL_SEARCH_NAME): Update.
8403         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8404         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8405         * minsyms.c (minimal_symbol_reader::record_full): Update.
8406
8407 2019-03-15  Tom Tromey  <tom@tromey.com>
8408
8409         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8410
8411 2019-03-15  Tom Tromey  <tom@tromey.com>
8412
8413         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8414         unique_xmalloc_ptr.
8415         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8416         Update.
8417         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8418         (build_minimal_symbol_hash_tables)
8419         (minimal_symbol_reader::install): Update.
8420
8421 2019-03-15  Tom Tromey  <tom@tromey.com>
8422
8423         * symtab.c (create_demangled_names_hash): Update.
8424         (symbol_set_names): Update.
8425         * objfiles.h (struct objfile_per_bfd_storage)
8426         <demangled_names_hash>: Now an htab_up.
8427         * objfiles.c (objfile_per_bfd_storage): Simplify.
8428
8429 2019-03-15  Tom Tromey  <tom@tromey.com>
8430
8431         * objfiles.h (struct objfile_per_bfd_storage): Declare
8432         destructor.
8433         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8434         New.
8435         (get_objfile_bfd_data): Use new.  Don't initialize
8436         language_of_main.
8437         (free_objfile_per_bfd_storage): Remove.
8438         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8439
8440 2019-03-15  Tom Tromey  <tom@tromey.com>
8441
8442         * symfile.c (reread_symbols): Update.
8443         * objfiles.c (objfile::objfile): Update.
8444         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8445         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8446         comment.
8447         (minimal_symbol_reader::install): Update.
8448         (terminate_minimal_symbol_table): Remove.
8449         * jit.c (jit_object_close_impl): Update.
8450
8451 2019-03-15  Tom Tromey  <tom@tromey.com>
8452
8453         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8454         initializations.
8455
8456 2019-03-15  Tom Tromey  <tom@tromey.com>
8457
8458         * objfiles.h (struct objfile_per_bfd_storage)
8459         <demangled_hash_languages>: Now a bitset.
8460         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8461         (lookup_minimal_symbol): Update.
8462
8463 2019-03-15  Tom Tromey  <tom@tromey.com>
8464
8465         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8466         Don't return the symbol.
8467         * coffread.c (record_minimal_symbol): Use record_full.
8468
8469 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8470
8471         The MS-Windows port of ncurses fails to switch to a color pair if
8472         one or both of the colors are the implicit default colors.  This
8473         change records the default colors when TUI is initialized, and
8474         then specifies them explicitly when a color pair uses the default
8475         colors.  This allows color styling in TUI mode on MS-Windows.
8476
8477         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8478         ncurses_norm_attr.
8479         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8480         colors in ncurses_norm_attr.
8481         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8482         "none", replace it with the default color recorded in
8483         ncurses_norm_attr.
8484
8485 2019-03-14  Tom Tromey  <tromey@adacore.com>
8486
8487         * source-cache.h (class source_cache) <get_source_lines>: Return
8488         std::string.
8489         * source-cache.c (source_cache::extract_lines): Handle case where
8490         first_pos==npos.  Return std::string.
8491         (source_cache::get_source_lines): Update.
8492
8493 2019-03-14  Tom Tromey  <tromey@adacore.com>
8494
8495         * NEWS: Add item for "style sources" commands.
8496         * source-cache.c (source_cache::get_source_lines): Check
8497         source_styling.
8498         * cli/cli-style.c (source_styling): New global.
8499         (_initialize_cli_style): Add "style sources" commands.
8500         (show_style_sources): New function.
8501         * cli/cli-style.h (source_styling): Declare.
8502
8503 2019-03-14  Pedro Alves  <palves@redhat.com>
8504             Tom Tromey  <tromey@adacore.com>
8505
8506         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8507         * tui/tui-winsource.c (tui_refill_source_window): New function,
8508         from...
8509         (tui_horizontal_source_scroll): ... here.  Move some logic.
8510         * cli/cli-style.c (set_style_enabled): Notify new observable.
8511         * tui/tui-hooks.c (tui_redisplay_source): New function.
8512         (tui_attach_detach_observers): Attach or detach
8513         tui_redisplay_source.
8514         * observable.h (source_styling_changed): New observable.
8515         * observable.c: Define source_styling_changed observable.
8516
8517 2019-03-13  Tom Tromey  <tromey@adacore.com>
8518
8519         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8520         (i386_gnu_nat_target::store_registers): Update.
8521         * target-debug.h (target_debug_print_std_string): New macro.
8522         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8523         * windows-tdep.c (display_one_tib): Update.
8524         * tui/tui-stack.c (tui_make_status_line): Update.
8525         * top.c (print_inferior_quit_action): Update.
8526         * thread.c (thr_try_catch_cmd): Update.
8527         (add_thread_with_info): Update.
8528         (thread_target_id_str): Update.
8529         (thr_try_catch_cmd): Update.
8530         (thread_command): Update.
8531         (thread_find_command): Update.
8532         * record-btrace.c (record_btrace_target::info_record)
8533         (record_btrace_resume_thread, record_btrace_target::resume)
8534         (record_btrace_cancel_resume, record_btrace_step_thread)
8535         (record_btrace_target::wait, record_btrace_target::wait)
8536         (record_btrace_target::wait, record_btrace_target::stop): Update.
8537         * progspace.c (print_program_space): Update.
8538         * process-stratum-target.c
8539         (process_stratum_target::thread_address_space): Update.
8540         * linux-fork.c (linux_fork_mourn_inferior)
8541         (detach_checkpoint_command, info_checkpoints_command)
8542         (linux_fork_context): Update.
8543         (linux_fork_detach): Update.
8544         (class scoped_switch_fork_info): Update.
8545         (delete_checkpoint_command): Update.
8546         * infrun.c (follow_fork_inferior): Update.
8547         (follow_fork_inferior): Update.
8548         (proceed_after_vfork_done): Update.
8549         (handle_vfork_child_exec_or_exit): Update.
8550         (follow_exec): Update.
8551         (displaced_step_prepare_throw): Update.
8552         (displaced_step_restore): Update.
8553         (start_step_over): Update.
8554         (resume_1): Update.
8555         (clear_proceed_status_thread): Update.
8556         (proceed): Update.
8557         (print_target_wait_results): Update.
8558         (do_target_wait): Update.
8559         (context_switch): Update.
8560         (stop_all_threads): Update.
8561         (restart_threads): Update.
8562         (finish_step_over): Update.
8563         (handle_signal_stop): Update.
8564         (switch_back_to_stepped_thread): Update.
8565         (keep_going_pass_signal): Update.
8566         (print_exited_reason): Update.
8567         (normal_stop): Update.
8568         * inferior.c (inferior_pid_to_str): Change return type.
8569         (print_selected_inferior): Update.
8570         (add_inferior): Update.
8571         (detach_inferior): Update.
8572         * dummy-frame.c (fprint_dummy_frames): Update.
8573         * dcache.c (dcache_info_1): Update.
8574         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8575         (btrace_fetch, btrace_clear): Update.
8576         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8577         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8578         type.
8579         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8580         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8581         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8582         * gdbarch.c, gdbarch.h: Rebuild.
8583         * gdbarch.sh (core_pid_to_str): Change return type.
8584         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8585         return type.
8586         (windows_nat_target::pid_to_str): Change return type.
8587         (windows_delete_thread): Update.
8588         (windows_nat_target::attach): Update.
8589         (windows_nat_target::files_info): Update.
8590         * target-delegates.c: Rebuild.
8591         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8592         return type.
8593         (sol_thread_target::pid_to_str): Change return type.
8594         * remote.c (class remote_target) <pid_to_str>: Change return
8595         type.
8596         (remote_target::pid_to_str): Change return type.
8597         (extended_remote_target::attach, remote_target::remote_stop_ns)
8598         (remote_target::remote_notif_remove_queued_reply)
8599         (remote_target::push_stop_reply, remote_target::disable_btrace):
8600         Update.
8601         (extended_remote_target::attach): Update.
8602         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8603         type.
8604         (gdbsim_target::pid_to_str): Change return type.
8605         * ravenscar-thread.c (struct ravenscar_thread_target)
8606         <pid_to_str>: Change return type.
8607         (ravenscar_thread_target::pid_to_str): Change return type.
8608         * procfs.c (class procfs_target) <pid_to_str>: Change return
8609         type.
8610         (procfs_target::pid_to_str): Change return type.
8611         (procfs_target::attach): Update.
8612         (procfs_target::detach): Update.
8613         (procfs_target::fetch_registers): Update.
8614         (procfs_target::store_registers): Update.
8615         (procfs_target::wait): Update.
8616         (procfs_target::files_info): Update.
8617         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8618         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8619         return type.
8620         (nto_procfs_target::pid_to_str): Change return type.
8621         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8622         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8623         return type.
8624         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8625         (exit_lwp): Update.
8626         (attach_proc_task_lwp_callback, get_detach_signal)
8627         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8628         (linux_nat_target::resume, wait_lwp, stop_callback)
8629         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8630         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8631         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8632         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8633         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8634         type.
8635         (inf_ptrace_target::attach): Update.
8636         (inf_ptrace_target::files_info): Update.
8637         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8638         type.
8639         (go32_nat_target::pid_to_str): Change return type.
8640         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8641         (gnu_nat_target::wait): Update.
8642         (gnu_nat_target::wait): Update.
8643         (gnu_nat_target::resume): Update.
8644         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8645         (fbsd_nat_target::wait): Update.
8646         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8647         type.
8648         (darwin_nat_target::attach): Update.
8649         * corelow.c (class core_target) <pid_to_str>: Change return type.
8650         (core_target::pid_to_str): Change return type.
8651         * target.c (normal_pid_to_str): Change return type.
8652         (default_pid_to_str): Likewise.
8653         (target_pid_to_str): Change return type.
8654         (target_translate_tls_address): Update.
8655         (target_announce_detach): Update.
8656         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8657         return type.
8658         (bsd_uthread_target::pid_to_str): Change return type.
8659         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8660         type.
8661         (bsd_kvm_target::pid_to_str): Change return type.
8662         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8663         return type.
8664         (aix_thread_target::pid_to_str): Change return type.
8665         * target.h (struct target_ops) <pid_to_str>: Change return type.
8666         (target_pid_to_str, normal_pid_to_str): Likewise.
8667         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8668         type.
8669         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8670         type.
8671         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8672         return type.
8673         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8674         type.
8675         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8676         type.
8677         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8678         return type.
8679
8680 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8681
8682         * NEWS: Mention that the new default MI version is 3.  Mention
8683         changes to the output of commands and events that deal with
8684         multi-location breakpoints.
8685         * breakpoint.c: Include "mi/mi-out.h".
8686         (print_one_breakpoint): Change output syntax if using MI version
8687         >= 3.
8688         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8689         New.
8690         (mi_multi_location_breakpoint_output_fixed): New.
8691         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8692         (mi_cmd_fix_multi_location_breakpoint_output): New.
8693         (mi_multi_location_breakpoint_output_fixed): New.
8694         * mi/mi-cmds.c (mi_cmds): Register command
8695         -fix-multi-location-breakpoint-output.
8696         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8697         interpreter "mi".
8698
8699 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8700
8701         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8702         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8703         instantiate mi_ui_out based on interpreter name.
8704         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8705         * mi/mi-main.c (mi_load_progress): Likewise.
8706
8707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8708
8709         * NEWS: Combine separate "New targets" sections for 8.3.
8710
8711 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8712
8713         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8714         (ppcfbsd_init_abi): Install gdbarch
8715         "fetch_tls_load_module_address" and "get_thread_local_address"
8716         methods.
8717
8718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8719
8720         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8721         (riscv_fbsd_init_abi): Install gdbarch
8722         "fetch_tls_load_module_address" and "get_thread_local_address"
8723         methods.
8724
8725 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8726
8727         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8728         (i386fbsd_init_abi): Install gdbarch
8729         "fetch_tls_load_module_address" and "get_thread_local_address"
8730         methods.
8731
8732 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8733
8734         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8735         (amd64fbsd_init_abi): Install gdbarch
8736         "fetch_tls_load_module_address" and "get_thread_local_address"
8737         methods.
8738
8739 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8740
8741         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8742         (struct fbsd_pspace_data): New type.
8743         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8744         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8745         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8746         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8747         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8748
8749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8750
8751         * gdbtypes.c (lookup_struct_elt): New function.
8752         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8753         * gdbtypes.h (struct struct_elt): New type.
8754         (lookup_struct_elt): New prototype.
8755
8756 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8757
8758         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8759         remove disabled code block.
8760
8761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8762
8763         * gdbarch.sh (get_thread_local_address): New method.
8764         * gdbarch.h, gdbarch.c: Regenerate.
8765         * target.c (target_translate_tls_address): Use
8766         gdbarch_get_thread_local_address if present instead of
8767         target::get_thread_local_address.
8768
8769 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8770
8771         * target.h (target::get_thread_local_address): Update comment.
8772
8773 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8774
8775         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8776         objfile->separate_debug_objfile_backlink if not NULL.
8777
8778 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8779
8780         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8781         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8782         (amd64bsd_store_inferior_registers): Likewise.
8783         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8784         Enable segment base registers.
8785         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8786         PT_GETFSBASE and PT_GETGSBASE.
8787         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8788         PT_SETGSBASE.
8789         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8790         segment base registers.
8791         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8792
8793 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8794
8795         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8796         Update calls to i386_target_description to add 'segments'
8797         parameter.
8798         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8799         add segment base registers.
8800         * arch/i386.c (i386_create_target_description): Add 'segments'
8801         parameter to enable segment base registers.
8802         * arch/i386.h (i386_create_target_description): Likewise.
8803         * features/i386/32bit-segments.xml: New file.
8804         * features/i386/32bit-segments.c: Generate.
8805         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8806         call to i386_target_description to add 'segments' parameter.
8807         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8808         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8809         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8810         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8811         if feature is present.
8812         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8813         Add 'segments' parameter to call to i386_target_description.
8814         (i386_target_description): Add 'segments' parameter to enable
8815         segment base registers.
8816         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8817         to call to i386_target_description.
8818         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8819         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8820         Define I386_NUM_REGS.
8821         (i386_target_description): Add 'segments' parameter to enable
8822         segment base registers.
8823
8824 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8825
8826         PR/24325
8827         * source-cache.c: #undef open and close, to avoid unresolved
8828         externals during linking.
8829
8830 2019-03-12  Tom Tromey  <tromey@adacore.com>
8831
8832         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8833         const.  Add initializers.
8834         (_initialize_remote): Don't initialize ptid globals.
8835
8836 2019-03-12  Pedro Alves  <palves@redhat.com>
8837
8838         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8839
8840 2019-03-12  Pedro Alves  <palves@redhat.com>
8841
8842         * cp-name-parser.y (main): Remove unused 'len' variable.
8843
8844 2019-03-12  Tom Tromey  <tromey@adacore.com>
8845
8846         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8847         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8848
8849 2019-03-12  Tom Tromey  <tromey@adacore.com>
8850
8851         * linux-nat.c (iterate_over_lwps): Update.
8852         (stop_callback): Remove parameter.
8853         (stop_wait_callback, detach_callback, resume_set_callback)
8854         (select_singlestep_lwp_callback, set_ignore_sigint)
8855         (status_callback, resumed_callback, resume_clear_callback)
8856         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8857         data parameter.
8858         (linux_nat_target::detach, linux_nat_target::resume)
8859         (linux_stop_and_wait_all_lwps, select_event_lwp)
8860         (linux_nat_filter_event, linux_nat_wait_1)
8861         (linux_nat_target::kill, linux_nat_target::stop)
8862         (linux_nat_target::stop): Update.
8863         (linux_nat_resume_callback): Change type.
8864         (resume_stopped_resumed_lwps, count_events_callback)
8865         (select_event_lwp_callback): Likewise.
8866         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8867         * arm-linux-nat.c (struct update_registers_data): Remove.
8868         (update_registers_callback): Change type.
8869         (arm_linux_insert_hw_breakpoint1): Update.
8870         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8871         parameter.
8872         (x86_linux_dr_set_addr): Update.
8873         (x86_linux_dr_set_control): Update.
8874         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8875         (iterate_over_lwps): Use gdb::function_view.
8876         * nat/aarch64-linux-hw-point.c (struct
8877         aarch64_dr_update_callback_param): Remove.
8878         (debug_reg_change_callback): Change type.
8879         (aarch64_notify_debug_reg_change): Update.
8880         * s390-linux-nat.c (s390_refresh_per_info): Update.
8881
8882 2019-03-11  Tom Tromey  <tromey@adacore.com>
8883
8884         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8885         redundant assignment to "this_cu".
8886
8887 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8888
8889         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8890
8891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8892
8893         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8894         from...
8895         (rank_one_type): ... this.
8896
8897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8898
8899         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8900         from...
8901         (rank_one_type): ... this.
8902
8903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8904
8905         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8906         from...
8907         (rank_one_type): ... this.
8908
8909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8910
8911         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8912         from...
8913         (rank_one_type): ... this.
8914
8915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8916
8917         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8918         from...
8919         (rank_one_type): ... this.
8920
8921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8922
8923         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8924         from...
8925         (rank_one_type): ... this.
8926
8927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8928
8929         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8930         from...
8931         (rank_one_type): ... this.
8932
8933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8934
8935         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8936         from...
8937         (rank_one_type): ... this.
8938
8939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8940
8941         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8942         from...
8943         (rank_one_type): ... this.
8944
8945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8946
8947         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8948         from...
8949         (rank_one_type): ... this.
8950
8951 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8952
8953         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8954         from...
8955         (rank_one_type): ... this.
8956
8957 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8958
8959         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8960         from...
8961         (rank_one_type): ... this.
8962
8963 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8964
8965         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8966         inferior-events' shows the example events.
8967
8968 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8969
8970         Support styling on native MS-Windows console
8971
8972         PR/24315
8973         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8974         on MS-Windows if $TERM is not defined.
8975
8976         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8977
8978         * posix-hdep.c (gdb_console_fputs):
8979         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8980         functions.
8981         * ui-file.h (gdb_console_fputs): Add prototype.
8982
8983         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8984         back to fputs only if the former returns zero.
8985
8986 2019-03-07  Tom Tromey  <tom@tromey.com>
8987
8988         * symmisc.c (print_symbol_bcache_statistics): Update.
8989         (print_objfile_statistics): Update.
8990         * symfile.c (allocate_symtab): Update.
8991         * stabsread.c: Don't include bcache.h.
8992         * psymtab.h (struct psymbol_bcache): Don't declare.
8993         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8994         (psymbol_bcache_init, psymbol_bcache_free)
8995         (psymbol_bcache_get_bcache): Don't declare.
8996         * psymtab.c (struct psymbol_bcache): Remove.
8997         (psymtab_storage::psymtab_storage): Update.
8998         (psymtab_storage::~psymtab_storage): Update.
8999         (psymbol_bcache_init, psymbol_bcache_free)
9000         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9001         (add_psymbol_to_bcache): Update.
9002         (allocate_psymtab): Update.
9003         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9004         macro_cache>: No longer pointers.
9005         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9006         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9007         * macrotab.c (macro_bcache): Update.
9008         * macroexp.c: Don't include bcache.h.
9009         * gdbtypes.c (check_types_worklist): Update.
9010         (types_deeply_equal): Remove TRY/CATCH.  Update.
9011         * elfread.c (elf_symtab_read): Update.
9012         * dwarf2read.c: Don't include bcache.h.
9013         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9014         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9015         (print_bcache_statistics, bcache_memory_used): Don't declare.
9016         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9017         methods.  Rename all data members.
9018         * bcache.c (struct bcache): Move to bcache.h.
9019         (bcache::expand_hash_table): Rename from expand_hash_table.
9020         (bcache): Remove.
9021         (bcache::insert): Rename from bcache_full.
9022         (bcache::compare): Rename from bcache_compare.
9023         (bcache_xmalloc): Remove.
9024         (bcache::~bcache): Rename from bcache_xfree.
9025         (bcache::print_statistics): Rename from print_bcache_statistics.
9026         (bcache::memory_used): Rename from bcache_memory_used.
9027
9028 2019-03-07  Pedro Alves  <palves@redhat.com>
9029
9030         * infrun.c (normal_stop): Also check for
9031         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9032
9033 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9034
9035         * f-lang.c (value_from_host_double): Moved to...
9036         * value.c (value_from_host_double): ...here.
9037         * value.h (value_from_host_double): Declare.
9038         * guile/scm-math.c (vlscm_convert_typed_number): Use
9039         value_from_host_double.
9040         (vlscm_convert_number): Likewise.
9041         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9042         * python/py-value.c (convert_value_from_python): Likewise.
9043
9044 2019-03-06  Tom Tromey  <tom@tromey.com>
9045
9046         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9047
9048 2019-03-06  Tom Tromey  <tom@tromey.com>
9049
9050         * utils.h (free_current_contents): Don't declare.
9051         * utils.c (free_current_contents): Remove.
9052
9053 2019-03-06  Tom Tromey  <tom@tromey.com>
9054
9055         * top.c (quit_force): Update.
9056         * main.c (captured_command_loop): Update.
9057         * common/new-op.c (operator new): Update.
9058         * common/common-exceptions.c (struct catcher)
9059         <save_cleanup_chain>: Remove member.
9060         (exceptions_state_mc_init): Update.
9061         (exception_try_scope_entry): Return nullptr.
9062         (exception_try_scope_exit, exception_rethrow)
9063         (throw_exception_sjlj, throw_exception_cxx): Update.
9064         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9065         (all_cleanups, do_cleanups, discard_cleanups)
9066         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9067         (restore_cleanups, restore_final_cleanups): Don't declare.
9068         (do_final_cleanups): Remove parameter.
9069         * common/cleanups.c (cleanup_chain, make_cleanup)
9070         (make_cleanup_dtor, all_cleanups, do_cleanups)
9071         (discard_my_cleanups, discard_cleanups)
9072         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9073         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9074         (null_cleanup): Remove.
9075         (do_final_cleanups): Remove parameter.
9076
9077 2019-03-06  Tom Tromey  <tom@tromey.com>
9078
9079         * remote.c (remote_target::remote_parse_stop_reply): Use
9080         unique_xmalloc_ptr.
9081
9082 2019-03-06  Tom Tromey  <tom@tromey.com>
9083
9084         * stabsread.c (struct stabs_field_info): Rename from field_info.
9085         <list, fnlist>: Add initializers.
9086         <obstack>: New member.
9087         (read_member_functions, read_struct_fields, read_baseclasses):
9088         Allocate on obstack.  Don't use cleanups.
9089         (read_one_struct_field, read_member_functions, read_struct_fields)
9090         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9091         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9092         (read_struct_type): Update.
9093
9094 2019-03-06  Tom Tromey  <tom@tromey.com>
9095
9096         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9097         * common/filestuff.h (make_cleanup_close): Don't declare.
9098         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9099         Remove.
9100
9101 2019-03-06  Tom Tromey  <tom@tromey.com>
9102
9103         * solib-aix.c: Use make_scope_exit.
9104
9105 2019-03-06  Tom Tromey  <tom@tromey.com>
9106
9107         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9108         Use make_scope_exit.
9109
9110 2019-03-06  Tom Tromey  <tom@tromey.com>
9111
9112         * solib-svr4.c (disable_probes_interface): Remove parameter.
9113         (svr4_handle_solib_event): Use make_scope_exit.
9114
9115 2019-03-06  Tom Tromey  <tom@tromey.com>
9116
9117         * remote.c (struct stop_reply_deleter): Remove.
9118         (stop_reply_up): Update.
9119         (struct stop_reply): Derive from notif_event.  Don't typedef.
9120         <regcache>: Now a std::vector.
9121         (stop_reply_xfree): Remove.
9122         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9123         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9124         (remote_target::discard_pending_stop_replies): Use delete.
9125         (remote_target::remote_parse_stop_reply): Update.
9126         (remote_target::process_stop_reply): Update.
9127         * remote-notif.h (struct notif_event): Add virtual destructor.
9128         Remove "dtr" member.
9129         (struct notif_client) <alloc_event>: Return a unique_ptr.
9130         (notif_event_xfree): Don't declare.
9131         (notif_event_up): New typedef.
9132         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9133         (notif_event_xfree, do_notif_event_xfree): Remove.
9134         (remote_notif_state_xfree): Update.
9135
9136 2019-03-06  Tom Tromey  <tom@tromey.com>
9137
9138         * infrun.c (displaced_step_clear_cleanup): Now a
9139         forward_scope_exit type.
9140         (displaced_step_prepare_throw): Update.
9141         (displaced_step_fixup): Update.
9142
9143 2019-03-06  Tom Tromey  <tom@tromey.com>
9144
9145         * inferior.h (class inferior): Update comment.
9146         * gdbthread.h (class thread_info): Update comment.
9147
9148 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9149             Tom Tromey  <tom@tromey.com>
9150
9151         * stabsread.h (struct stab_section_list): Remove.
9152         (coffstab_build_psymtabs): Update.
9153         * dbxread.c (symbuf_sections): Now a std::vector.
9154         (sect_idx): New global.
9155         (fill_symbuf): Update.
9156         (coffstab_build_psymtabs): Change type of stabsects parameter.
9157         Update.
9158         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9159         std::vector.
9160         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9161         (coff_locate_sections): Update.
9162         (coff_symfile_read): Remove cleanups.  Update.
9163         (init_stringtab): Add storage parameter.
9164         (free_stringtab, free_stringtab_cleanup): Remove.
9165         (init_lineno): Add storage parameter.
9166         (free_linetab, free_linetab_cleanup): Remove.
9167
9168 2019-03-06  Pedro Alves  <palves@redhat.com>
9169
9170         * linux-fork.c (fork_info::clobber_regs): Delete.
9171         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9172         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9173         comment.  Adjust.
9174         (scoped_switch_fork_info::scoped_switch_fork_info)
9175         (checkpoint_command, linux_fork_context): Adjust
9176         fork_save_infrun_state calls.
9177
9178 2019-03-06  Pedro Alves  <palves@redhat.com>
9179
9180         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9181         (inf_has_multiple_threads): Return 'bool' and rewrite using
9182         inferior_info::threads().
9183
9184 2019-03-06  Pedro Alves  <palves@redhat.com>
9185
9186         * linux-fork.c: Include <list>.
9187         (fork_list): Now a std::list instance.
9188         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9189         (forks_exist_p, find_last_fork): Adjust.
9190         (new_fork): Delete.
9191         (one_fork_p): New.
9192         (add_fork): Adjust.
9193         (free_fork): Delete, folded into fork_info::~fork_info().
9194         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9195         Adjust.
9196         (init_fork_list): Delete.
9197         (linux_fork_killall, linux_fork_mourn_inferior)
9198         (linux_fork_detach, info_checkpoints_command): Adjust.
9199         (_initialize_linux_fork): No longer call init_fork_list.
9200
9201 2019-03-06  Pedro Alves  <palves@redhat.com>
9202
9203         * linux-fork.c (new_fork): New, split out of ...
9204         (add_fork): ... this.  Return void.  Move "first fork" special
9205         case from here, to ...
9206         (checkpoint_command): ... here.
9207         * linux-linux.h (add_fork): Return void.
9208
9209 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9210
9211         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9212
9213 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9214             Chris January  <chris.january@arm.com>
9215             David Lecomber  <david.lecomber@arm.com>
9216
9217         * f-exp.y: New token, UNOP_INTRINSIC.
9218         (exp): New pattern using UNOP_INTRINSIC token.
9219         (f77_keywords): Add 'abs' keyword.
9220         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9221         (value_from_host_double): New function.
9222         (evaluate_subexp_f): Support UNOP_ABS.
9223
9224 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9225
9226         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9227         types.
9228
9229 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9230
9231         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9232         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9233         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9234
9235 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9238
9239 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9240             Chris January  <chris.january@arm.com>
9241
9242         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9243         * f-exp.y: Define 'KIND' token.
9244         (exp): New pattern for KIND expressions.
9245         (ptype): Handle types with a kind extension.
9246         (direct_abs_decl): Extend to spot kind extensions.
9247         (f77_keywords): Add 'kind' to the list.
9248         (push_kind_type): New function.
9249         (convert_to_kind_type): New function.
9250         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9251         * parse.c (operator_length_standard): Likewise.
9252         * parser-defs.h (enum type_pieces): Add tp_kind.
9253         * std-operator.def: Add UNOP_KIND.
9254
9255 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9256
9257         * f-exp.y (f_parse): Set yydebug.
9258
9259 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9260
9261         * f-lang.c (evaluate_subexp_f): New function.
9262         (exp_descriptor_f): New global.
9263         (f_language_defn): Use exp_descriptor_f instead of
9264         exp_descriptor_standard.
9265
9266 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9267
9268         * f-exp.y (struct token): Add comments.
9269         (dot_ops): Remove uppercase versions and the end marker.
9270         (f77_keywords): Likewise.
9271         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9272         entries in the dot_ops array are case insensitive, and use
9273         strncasecmp to compare strings.  Also some whitespace cleanup in
9274         this area.  Similar for the f77_keywords array, except entries in
9275         this list might be case sensitive.
9276
9277 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9278
9279         * f-exp.y (struct f77_boolean_val): Add comments.
9280         (boolean_values): Remove uppercase versions, and end marker.
9281         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9282         and use strncasecmp to achieve case insensitivity.  Additionally,
9283         perform whitespace cleanup around this code.
9284
9285 2019-03-06  Tom Tromey  <tromey@adacore.com>
9286
9287         * remote-sim.c (gdbsim_target_open): Use result of
9288         gdb_argv::release.
9289
9290 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9291         Dirk Schubert  <dirk.schubert@arm.com>
9292         Chris January  <chris.january@arm.com>
9293
9294         * eval.c (evaluate_subexp_standard): Call Fortran argument
9295         wrapping logic.
9296         * f-lang.c (struct value): A value which can be passed into a
9297         Fortran function call.
9298         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9299         where appropriate.
9300         (struct type): Value ready for a Fortran function call.
9301         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9302         is needed.
9303         * f-lang.h (fortran_argument_convert): Declaration.
9304         (fortran_preserve_arg_pointer): Declaration.
9305         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9306
9307 2019-03-05  Tom Tromey  <tromey@adacore.com>
9308
9309         * python/py-prettyprint.c (print_string_repr): Remove #if.
9310         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9311
9312 2019-03-05  Tom Tromey  <tromey@adacore.com>
9313
9314         * target.c (the_dummy_target): Move later.  Change type to
9315         "dummy_target".
9316         (initialize_targets): Don't initialize the_dummy_target.
9317
9318 2019-03-05  Tom Tromey  <tromey@adacore.com>
9319
9320         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9321         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9322
9323 2019-03-05  Tom Tromey  <tromey@adacore.com>
9324
9325         * windows-nat.c (windows_nat_target::attach)
9326         (windows_nat_target::detach): Don't call gdb_flush.
9327         * valprint.c (generic_val_print, val_print, val_print_string):
9328         Don't call gdb_flush.
9329         * utils.c (defaulted_query): Don't call gdb_flush.
9330         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9331         * target.c (target_announce_detach): Don't call gdb_flush.
9332         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9333         * remote.c (extended_remote_target::attach): Don't call
9334         gdb_flush.
9335         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9336         * printcmd.c (do_examine): Don't call gdb_flush.
9337         (info_display_command): Don't call gdb_flush.
9338         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9339         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9340         * memattr.c (info_mem_command): Don't call gdb_flush.
9341         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9342         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9343         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9344         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9345         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9346         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9347         (gnu_nat_target::detach): Don't call gdb_flush.
9348         * f-valprint.c (f_val_print): Don't call gdb_flush.
9349         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9350         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9351         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9352         gdb_flush.
9353         * c-valprint.c (c_val_print): Don't call gdb_flush.
9354         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9355
9356 2019-03-05  Tom Tromey  <tromey@adacore.com>
9357
9358         * varobj.c (update_dynamic_varobj_children): Update.
9359         (install_default_visualizer): Use reset, not release.
9360         * value.c (set_internalvar): Update.
9361         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9362         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9363         ATTRIBUTE_UNUSED_RESULT.
9364
9365 2019-03-05  Tom Tromey  <tromey@adacore.com>
9366
9367         * remote.c (class scoped_remote_fd) <release>: Add
9368         ATTRIBUTE_UNUSED_RESULT.
9369
9370 2019-03-05  Tom Tromey  <tromey@adacore.com>
9371
9372         * macroexp.c (struct macro_buffer) <release>: Add
9373         ATTRIBUTE_UNUSED_RESULT.
9374
9375 2019-03-05  Tom Tromey  <tromey@adacore.com>
9376
9377         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9378         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9379         ATTRIBUTE_UNUSED_RESULT.
9380
9381 2019-03-05  Tom Tromey  <tromey@adacore.com>
9382
9383         * common/scoped_fd.h (class scoped_fd) <release>: Add
9384         ATTRIBUTE_UNUSED_RESULT.
9385
9386 2019-03-05  Tom Tromey  <tromey@adacore.com>
9387
9388         * parser-defs.h (struct parser_state) <release>: Add
9389         ATTRIBUTE_UNUSED_RESULT.
9390
9391 2019-03-05  Tom Tromey  <tromey@adacore.com>
9392
9393         * utils.h (class gdb_argv) <release>: Add
9394         ATTRIBUTE_UNUSED_RESULT.
9395         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9396
9397 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9398
9399         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9400         for-loop range, to avoid compiler warnings.
9401
9402         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9403         avoid compiler warnings about unused variables.
9404
9405         * NEWS: Mention end of support for native debugging on MS-Windows
9406         before XP.
9407
9408         PR gdb/24292
9409         * common/netstuff.c:
9410         * gdbserver/gdbreplay.c
9411         * gdbserver/remote-utils.c:
9412         * ser-tcp.c:
9413         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9414         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9415         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9416         'getaddrinfo' and 'freeaddrinfo' were not available before
9417         Windows XP, and mingw.org's MinGW headers by default define
9418         _WIN32_WINNT to 0x500.
9419
9420 2019-03-01  Gary Benson <gbenson@redhat.com>
9421
9422         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9423
9424 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9425             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9426
9427         PR gdb/8527
9428         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9429         set_sigint_trap, clear_sigint_trap.
9430
9431 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9432
9433         * target.c (target_detach): Clear the regcache and the
9434         frame cache.
9435
9436 2019-02-27  Pedro Alves  <palves@redhat.com>
9437
9438         * utils.c (set_screen_size): When we cap the height/width sizes,
9439         tweak the corresponding command variable to show "unlimited":
9440
9441 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9442             Pedro Alves  <palves@redhat.com>
9443
9444         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9445         before calling rl_set_screen_size.
9446
9447 2019-02-27  Tom Tromey  <tromey@adacore.com>
9448
9449         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9450         define.
9451         * python/py-value.c: Remove Python 2.4 workaround.
9452         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9453         workaround.
9454         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9455         Python 2.4 workaround.
9456         * python/python-internal.h: Remove Python 2.4 comment.
9457         (Py_ssize_t): Don't define.
9458         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9459         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9460         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9461         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9462         * python/python.c (do_start_initialization): Remove Python 2.4
9463         workaround.
9464         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9465         (print_children): Remove Python 2.4 workaround.
9466         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9467         workaround.
9468         (CHARBUFFERPROC_NAME): Remove.
9469         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9470         Python 2.4 workaround.
9471
9472 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9473
9474         * NEWS: Note minimum Python version.
9475
9476 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9477
9478         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9479         code from these functions.  Remove corresponding ifdefs.  Use
9480         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9481         Remove gotos and target of gotos.
9482         (infpy_search_memory): Likewise.
9483
9484 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9485
9486         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9487         (hppa_gdbarch_init): Don't register deleted functions with
9488         gdbarch.
9489
9490 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9491
9492         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9493         (h8300_unwind_sp): Delete.
9494         (h8300_dummy_id): Delete.
9495         (h8300_gdbarch_init): Don't register deleted functions with
9496         gdbarch.
9497
9498 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9499
9500         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9501         (ft32_unwind_pc): Delete.
9502         (ft32_unwind_sp): Delete.
9503         (ft32_gdbarch_init): Don't register deleted functions with
9504         gdbarch.
9505
9506 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9507
9508         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9509         (frv_unwind_pc): Delete.
9510         (frv_unwind_sp): Delete.
9511         (frv_gdbarch_init): Don't register deleted functions with
9512         gdbarch.
9513
9514 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9515
9516         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9517         (riscv_unwind_pc): Delete.
9518         (riscv_unwind_sp): Delete.
9519         (riscv_gdbarch_init): Don't register deleted functions with
9520         gdbarch.
9521
9522 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9523
9524         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9525         (csky_unwind_pc): Delete.
9526         (csky_unwind_sp): Delete.
9527         (csky_gdbarch_init): Don't register deleted functions with
9528         gdbarch.
9529
9530 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9531
9532         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9533         (cris_unwind_pc): Delete.
9534         (cris_unwind_sp): Delete.
9535         (cris_gdbarch_init): Don't register deleted functions with
9536         gdbarch.
9537
9538 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9539
9540         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9541         (bfin_unwind_pc): Delete.
9542         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9543
9544 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9545
9546         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9547         (arm_unwind_pc): Delete.
9548         (arm_unwind_sp): Delete.
9549         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9550
9551 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9552
9553         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9554         (arc_unwind_pc): Delete.
9555         (arc_unwind_sp): Delete.
9556         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9557
9558 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9559
9560         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9561         (alpha_unwind_pc): Delete.
9562         (alpha_gdbarch_init): Don't register deleted functions with
9563         gdbarch.
9564
9565 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9566
9567         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9568         (aarch64_unwind_pc): Delete.
9569         (aarch64_unwind_sp): Delete.
9570         (aarch64_gdbarch_init): Don't register deleted functions with
9571         gdbarch.
9572
9573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9574
9575         * gdbtypes.c (type_align): Don't consider static members when
9576         computing structure alignment.
9577
9578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9579
9580         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9581         return 0 for other types.
9582         * arch-utils.c (default_type_align): Always return 0.
9583         * gdbarch.h: Regenerate.
9584         * gdbarch.sh (type_align): Extend comment.
9585         * gdbtypes.c (type_align): Add additional comments, always call
9586         gdbarch_type_align before applying the default rules.
9587         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9588         generic code will then apply a suitable default.
9589         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9590         types, return 0 for other types.
9591
9592 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9593
9594         * NEWS: Create a new section for the next release branch.
9595         Rename the section of the current branch, now that it has
9596         been cut.
9597
9598 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9599
9600         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9601         * version.in: Bump version to 8.3.50.DATE-git.
9602
9603 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9604
9605         * aix-thread.c (ptid_cmp): Remove unused variable.
9606         (get_signaled_thread): Likewise.
9607         (store_regs_user_thread): Likewise.
9608         (store_regs_kernel_thread): Likewise.
9609         (fetch_regs_kernel_thread): Remove shadowed variable.
9610
9611 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9612
9613         * features/riscv/32bit-cpu.xml: Add register numbers.
9614         * features/riscv/32bit-fpu.c: Regenerate.
9615         * features/riscv/32bit-fpu.xml: Add register numbers.
9616         * features/riscv/64bit-cpu.xml: Add register numbers.
9617         * features/riscv/64bit-fpu.c: Regenerate.
9618         * features/riscv/64bit-fpu.xml: Add register numbers.
9619
9620 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9621
9622         * NEWS: Mention two argument form of gdb.Value constructor.
9623         * python/py-value.c (convert_buffer_and_type_to_value): New
9624         function.
9625         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9626         Add support for handling an optional second argument.  Call
9627         convert_buffer_and_type_to_value as appropriate.
9628         * python/python-internal.h (Py_buffer_deleter): New struct.
9629         (Py_buffer_up): New typedef.
9630
9631 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9632
9633         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9634         instead of releasing ownership.
9635
9636 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9637
9638         * dwarf2read.c (open_and_init_dwp_file): Call
9639         elf_numsections instead of bfd_count_sections to initialize
9640         dwp_file->num_sections.
9641
9642 2019-02-25  Tom Tromey  <tromey@adacore.com>
9643
9644         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9645
9646 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9647
9648         * gcore.in: Add '--readnever' option when invoking GDB.
9649
9650 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9651
9652         * MAINTAINERS: Update my email address.
9653
9654 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9655
9656         * build-id.c (build_id_to_debug_bfd_1): New function.
9657         (build_id_to_debug_bfd): Look for separate debug file in
9658         sysroot.
9659
9660 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9661
9662         * gdbarch.sh: Update the copyright year range that is placed into
9663         generated files.
9664
9665 2019-02-22  Keith Seitz  <keiths@redhat.com>
9666
9667         PR symtab/23853
9668         * linespec.c (create_sals_line_offset): Search for the default
9669         symtab's filename instead of its fullname.
9670
9671 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9672
9673         * NEWS: Update style defaults.
9674
9675 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9676
9677         * main.c (captured_main_1): Disable styling in batch mode.
9678
9679 2019-02-20  Tom Tromey  <tom@tromey.com>
9680
9681         * symtab.c (symtab_symbol_info): Fix typos.
9682
9683 2019-02-20  Tom Tromey  <tromey@adacore.com>
9684
9685         * findcmd.c (_initialize_mem_search): Use upper case for
9686         metasyntactic variables.
9687
9688 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9689
9690         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9691         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9692
9693 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9694
9695         * top.h (source_file_name): Change to std::string.
9696         * top.c (source_file_name): Likewise.
9697         (command_line_input): Adjust.
9698         * cli/cli-script.c (script_from_file): Adjust.
9699
9700 2019-02-19  Tom Tromey  <tromey@adacore.com>
9701
9702         * ravenscar-thread.c
9703         (ravenscar_thread_target::update_thread_list): Don't call
9704         ada_build_task_list.
9705         * ada-lang.h (ada_build_task_list): Don't declare.
9706         * ada-tasks.c (struct ada_tasks_inferior_data)
9707         <task_list_valid_p>: Now bool.
9708         (read_known_tasks, ada_task_list_changed)
9709         (ada_tasks_invalidate_inferior_data): Update.
9710         (read_known_tasks_array): Return bool.
9711         (read_known_tasks_list): Likewise.
9712         (read_known_tasks): Return void.
9713         (ada_build_task_list): Now static.
9714
9715 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9716
9717         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9718         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9719
9720 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9721
9722         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9723         variant for ada_tasks_pspace_data_handle and
9724         ada_tasks_inferior_data_handle.
9725         (ada_tasks_pspace_data_cleanup): New function.
9726         (ada_tasks_inferior_data_cleanup): New function.
9727
9728 2019-02-17  Tom Tromey  <tom@tromey.com>
9729
9730         * macrotab.h (macro_source_fullname): Return a std::string.
9731         * macrotab.c (macro_include, check_for_redefinition)
9732         (macro_undef, macro_lookup_definition, foreach_macro)
9733         (foreach_macro_in_scope): Update.
9734         (macro_source_fullname): Return a std::string.
9735         * macrocmd.c (show_pp_source_pos): Update.
9736
9737 2019-02-17  Tom Tromey  <tom@tromey.com>
9738
9739         * macrocmd.c (show_pp_source_pos): Style the file names.
9740
9741 2019-02-17  Tom Tromey  <tom@tromey.com>
9742
9743         PR tui/24197:
9744         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9745
9746 2019-02-17  Tom Tromey  <tom@tromey.com>
9747
9748         * ada-lang.c (user_select_syms): Use filtered printing.
9749         * utils.c (wrap_style): New global.
9750         (desired_style): Remove.
9751         (emit_style_escape): Add stream parameter.
9752         (set_output_style, reset_terminal_style, prompt_for_continue):
9753         Update.
9754         (flush_wrap_buffer): Only flush gdb_stdout.
9755         (wrap_here): Set wrap_style.
9756         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9757         treat escape sequences as a character.  Change when wrap buffer is
9758         flushed.
9759         (fputs_styled): Do not set the output style when the default is
9760         requested.
9761         * ui-style.h (struct ui_file_style) <is_default>: New method.
9762         * source.c (print_source_lines_base): Emit escape sequences in one
9763         piece.
9764
9765 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9766
9767         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9768         integers and enumeration types.
9769
9770 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9771
9772         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9773         instead of lookup_symbol_in_language
9774         (do_exact_match): New function.
9775         (ada_get_symbol_name_matcher): Return do_exact_match when
9776         doing a verbatim match.
9777
9778 2019-02-15  Tom Tromey  <tromey@adacore.com>
9779
9780         * ravenscar-thread.c (ravenscar_thread_target::resume)
9781         (ravenscar_thread_target::wait): Special case wildcard requests.
9782
9783 2019-02-15  Tom Tromey  <tromey@adacore.com>
9784
9785         * ravenscar-thread.c (base_ptid): Remove.
9786         (struct ravenscar_thread_target) <close>: New method.
9787         <m_base_ptid>: New member.
9788         <update_inferior_ptid, active_task, task_is_currently_active,
9789         runtime_initialized>: Declare methods.
9790         <ravenscar_thread_target>: Add constructor.
9791         (ravenscar_thread_target::task_is_currently_active)
9792         (ravenscar_thread_target::update_inferior_ptid)
9793         (ravenscar_runtime_initialized): Rename.  Now methods.
9794         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9795         (ravenscar_thread_target::update_thread_list): Update.
9796         (ravenscar_thread_target::active_task): Now method.
9797         (ravenscar_thread_target::store_registers)
9798         (ravenscar_thread_target::prepare_to_store)
9799         (ravenscar_thread_target::prepare_to_store)
9800         (ravenscar_thread_target::mourn_inferior): Update.
9801         (ravenscar_inferior_created): Use "new" to create target.
9802         (ravenscar_thread_target::get_ada_task_ptid): Update.
9803         (_initialize_ravenscar): Don't initialize base_ptid.
9804         (ravenscar_ops): Remove global.
9805
9806 2019-02-15  Tom Tromey  <tromey@adacore.com>
9807
9808         * target.h (push_target): Declare new overload.
9809         * target.c (push_target): New overload, taking an rvalue reference.
9810         * remote.c (remote_target::open_1): Use push_target overload.
9811         * corelow.c (core_target_open): Use push_target overload.
9812
9813 2019-02-15  Tom Tromey  <tromey@adacore.com>
9814
9815         * ravenscar-thread.c (is_ravenscar_task)
9816         (ravenscar_task_is_currently_active): Return bool.
9817         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9818         (_initialize_ravenscar): Remove "(void)".
9819         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9820         Return bool.
9821
9822 2019-02-15  Tom Tromey  <tromey@adacore.com>
9823
9824         * ravenscar-thread.c (ravenscar_runtime_initializer)
9825         (has_ravenscar_runtime, get_running_thread_id)
9826         (ravenscar_thread_target::resume): Fix indentation.
9827
9828 2019-02-15  Tom Tromey  <tromey@adacore.com>
9829
9830         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9831         from ravenscar_arch_ops.
9832         (sparc_ravenscar_ops::fetch_registers)
9833         (sparc_ravenscar_ops::store_registers): Now methods.
9834         (sparc_ravenscar_prepare_to_store): Remove.
9835         (sparc_ravenscar_ops): Redefine.
9836         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9837         methods and destructor.  Remove members.
9838         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9839         (ravenscar_thread_target::store_registers)
9840         (ravenscar_thread_target::prepare_to_store): Update.
9841         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9842         Remove.
9843         (struct ppc_ravenscar_powerpc_ops): Derive from
9844         ravenscar_arch_ops.
9845         (ppc_ravenscar_powerpc_ops::fetch_registers)
9846         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9847         (ppc_ravenscar_powerpc_ops): Redefine.
9848         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9849         (ppc_ravenscar_e500_ops::fetch_registers)
9850         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9851         (ppc_ravenscar_e500_ops): Redefine.
9852         * aarch64-ravenscar-thread.c
9853         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9854         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9855         (aarch64_ravenscar_fetch_registers)
9856         (aarch64_ravenscar_store_registers): Now methods.
9857         (aarch64_ravenscar_ops): Redefine.
9858
9859 2019-02-15  Tom Tromey  <tromey@adacore.com>
9860
9861         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9862         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9863         (ravenscar_thread_target::stopped_by_watchpoint)
9864         (ravenscar_thread_target::stopped_data_address)
9865         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9866
9867 2019-02-15  Tom Tromey  <tromey@adacore.com>
9868
9869         * ravenscar-thread.c: Fix some typos.
9870
9871 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9872             Tom Tromey  <tromey@adacore.com>
9873
9874         * ada-lang.c (ada_exception_sal): Change addr_string to a
9875         std::string.
9876         (create_ada_exception_catchpoint): Update.
9877
9878 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9879             Tom Tromey  <tromey@adacore.com>
9880
9881         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9882         (bp_location_ops): Remove.
9883         (base_breakpoint_allocate_location): Update.
9884         (free_bp_location): Update.
9885         * ada-lang.c (class ada_catchpoint_location)
9886         <ada_catchpoint_location>: Remove ops parameter.
9887         (ada_catchpoint_location_dtor): Remove.
9888         (ada_catchpoint_location_ops): Remove.
9889         (allocate_location_exception): Update.
9890         * breakpoint.h (struct bp_location_ops): Remove.
9891         (class bp_location) <bp_location>: Remove bp_location_ops
9892         parameter.
9893         <~bp_location>: Add destructor.
9894         <ops>: Remove.
9895
9896 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9897             Pedro Alves  <palves@redhat.com>
9898
9899         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9900         'PATH_MAX'.
9901
9902 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9903             Samuel Thibault  <samuel.thibault@gnu.org>
9904             Thomas Schwinge  <thomas@codesourcery.com>
9905
9906         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9907         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9908
9909 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9910
9911         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9912         (check_empty): Use "const char *".
9913
9914         * gnu-nat.c (gnu_nat_target::detach): Instead of
9915         'detach_inferior (pid)' call
9916         'detach_inferior (find_inferior_pid (pid))'.
9917
9918         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9919         'nat/fork-inferior.o'.
9920         * gnu-nat.c: #include "nat/fork-inferior.h".
9921
9922         * gnu-nat.c (gnu_nat_target::detach): Instead of
9923         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9924         * gnu-nat.h: #include "inf-child.h".
9925         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9926         'i386_gnu_nat_target::fetch_registers'.
9927         (gnu_store_registers): Rename/move to
9928         'i386_gnu_nat_target::store_registers'.
9929
9930         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9931         * gnu-nat.h (mach_thread_info): New function.
9932         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9933
9934         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9935
9936 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9937
9938         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9939
9940 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9941
9942         * windows-nat.c (windows_add_thread): Add new parameter
9943         "main_thread_p" with default value set to false.  Update
9944         function documentation as well as all callers.
9945         (windows_delete_thread): Likewise.
9946         (fake_create_process): Update call to windows_add_thread.
9947         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9948         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9949         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9950         call to windows_delete_thread.
9951
9952 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9953
9954         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9955
9956 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9957
9958         * symfile.c (find_separate_debug_file): Use canonical path of
9959         sysroot with child_path instead of gdb_sysroot if it is valid.
9960
9961 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9962
9963         * symfile.c (find_separate_debug_file): Use child_path to
9964         determine if an object file is under a sysroot.
9965
9966 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9967
9968         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9969         unittests/child-path-selftests.c.
9970         * common/pathstuff.c (child_path): New function.
9971         * common/pathstuff.h (child_path): New prototype.
9972         * unittests/child-path-selftests.c: New file.
9973
9974 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9975
9976         * symfile.c (find_separate_debug_file): Look for separate debug
9977         files in debug directories under the sysroot.
9978
9979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9980
9981         * symtab.h (struct minimal_symbol data_p): New const method.
9982         (struct minimal_symbol text_p): Likewise.
9983         * symtab.c (output_source_filename): Use file name style
9984         to print file name.
9985         (print_symbol_info): Likewise.
9986         (print_msymbol_info): Use address style to print addresses.
9987         Use function name style to print executable text symbols.
9988         (expand_symtab_containing_pc): Use data_p.
9989         (find_pc_sect_compunit_symtab): Likewise.
9990
9991 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9992
9993         * breakpoint.c (describe_other_breakpoints): Use address style
9994         to print addresses.
9995         (say_where): Likewise.
9996
9997 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9998
9999         * ada-typeprint.c (print_func_type): Print function name
10000         style to print function name.
10001         * c-typeprint.c (c_print_type_1): Likewise.
10002
10003 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10004
10005         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10006         for execve.
10007
10008 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10009
10010         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10011         type_stack.
10012
10013 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10014
10015         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10016         TYPE_CODE_REF types.
10017
10018 2019-02-08  Jim Wilson  <jimw@sifive.com>
10019
10020         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10021         (riscv_linux_fregset): New.
10022         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10023
10024 2019-02-07  Tom Tromey  <tom@tromey.com>
10025
10026         * thread.c (thread_cancel_execution_command): Update.
10027         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10028         methods.
10029         (struct thread_fsm_ops): Remove.
10030         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10031         (thread_fsm_should_stop, thread_fsm_return_value)
10032         (thread_fsm_set_finished, thread_fsm_finished_p)
10033         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10034         Don't declare.
10035         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10036         * infrun.c (clear_proceed_status_thread)
10037         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10038         (print_stop_event): Update.
10039         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10040         Add constructor.
10041         (step_command_fsm_ops): Remove.
10042         (new_step_command_fsm): Remove.
10043         (step_1): Update.
10044         (step_command_fsm::should_stop): Rename from
10045         step_command_fsm_should_stop.
10046         (step_command_fsm::clean_up): Rename from
10047         step_command_fsm_clean_up.
10048         (step_command_fsm::do_async_reply_reason): Rename from
10049         step_command_fsm_async_reply_reason.
10050         (struct until_next_fsm): Inherit from thread_fsm.  Add
10051         constructor.
10052         (until_next_fsm_ops): Remove.
10053         (new_until_next_fsm): Remove.
10054         (until_next_fsm::should_stop): Rename from
10055         until_next_fsm_should_stop.
10056         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10057         (until_next_fsm::do_async_reply_reason): Rename from
10058         until_next_fsm_async_reply_reason.
10059         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10060         constructor.  Change type of breakpoint.
10061         (finish_command_fsm_ops): Remove.
10062         (new_finish_command_fsm): Remove.
10063         (finish_command_fsm::should_stop): Rename from
10064         finish_command_fsm_should_stop.
10065         (finish_command_fsm::clean_up): Rename from
10066         finish_command_fsm_clean_up.
10067         (finish_command_fsm::return_value): Rename from
10068         finish_command_fsm_return_value.
10069         (finish_command_fsm::do_async_reply_reason): Rename from
10070         finish_command_fsm_async_reply_reason.
10071         (finish_command): Update.
10072         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10073         Add constructor.
10074         (call_thread_fsm_ops): Remove.
10075         (call_thread_fsm::call_thread_fsm): Rename from
10076         new_call_thread_fsm.
10077         (call_thread_fsm::should_stop): Rename from
10078         call_thread_fsm_should_stop.
10079         (call_thread_fsm::should_notify_stop): Rename from
10080         call_thread_fsm_should_notify_stop.
10081         (run_inferior_call, call_function_by_hand_dummy): Update.
10082         * cli/cli-interp.c (should_print_stop_to_console): Update.
10083         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10084         Add constructor.  Change type of location_breakpoint,
10085         caller_breakpoint.
10086         (until_break_fsm_ops): Remove.
10087         (new_until_break_fsm): Remove.
10088         (until_break_fsm::should_stop): Rename from
10089         until_break_fsm_should_stop.
10090         (until_break_fsm::clean_up): Rename from
10091         until_break_fsm_clean_up.
10092         (until_break_fsm::do_async_reply_reason): Rename from
10093         until_break_fsm_async_reply_reason.
10094         (until_break_command): Update.
10095         * thread-fsm.c: Remove.
10096         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10097
10098 2019-02-07  Tom Tromey  <tom@tromey.com>
10099
10100         * yy-remap.h: Add include guard.
10101         * xtensa-tdep.h: Add include guard.
10102         * xcoffread.h: Rename include guard.
10103         * varobj-iter.h: Add include guard.
10104         * tui/tui.h: Rename include guard.
10105         * tui/tui-winsource.h: Rename include guard.
10106         * tui/tui-wingeneral.h: Rename include guard.
10107         * tui/tui-windata.h: Rename include guard.
10108         * tui/tui-win.h: Rename include guard.
10109         * tui/tui-stack.h: Rename include guard.
10110         * tui/tui-source.h: Rename include guard.
10111         * tui/tui-regs.h: Rename include guard.
10112         * tui/tui-out.h: Rename include guard.
10113         * tui/tui-layout.h: Rename include guard.
10114         * tui/tui-io.h: Rename include guard.
10115         * tui/tui-hooks.h: Rename include guard.
10116         * tui/tui-file.h: Rename include guard.
10117         * tui/tui-disasm.h: Rename include guard.
10118         * tui/tui-data.h: Rename include guard.
10119         * tui/tui-command.h: Rename include guard.
10120         * tic6x-tdep.h: Add include guard.
10121         * target/waitstatus.h: Rename include guard.
10122         * target/wait.h: Rename include guard.
10123         * target/target.h: Rename include guard.
10124         * target/resume.h: Rename include guard.
10125         * target-float.h: Rename include guard.
10126         * stabsread.h: Add include guard.
10127         * rs6000-tdep.h: Add include guard.
10128         * riscv-fbsd-tdep.h: Add include guard.
10129         * regformats/regdef.h: Rename include guard.
10130         * record.h: Rename include guard.
10131         * python/python.h: Rename include guard.
10132         * python/python-internal.h: Rename include guard.
10133         * python/py-stopevent.h: Rename include guard.
10134         * python/py-ref.h: Rename include guard.
10135         * python/py-record.h: Rename include guard.
10136         * python/py-record-full.h: Rename include guard.
10137         * python/py-record-btrace.h: Rename include guard.
10138         * python/py-instruction.h: Rename include guard.
10139         * python/py-events.h: Rename include guard.
10140         * python/py-event.h: Rename include guard.
10141         * procfs.h: Add include guard.
10142         * proc-utils.h: Add include guard.
10143         * p-lang.h: Add include guard.
10144         * or1k-tdep.h: Rename include guard.
10145         * observable.h: Rename include guard.
10146         * nto-tdep.h: Rename include guard.
10147         * nat/x86-linux.h: Rename include guard.
10148         * nat/x86-linux-dregs.h: Rename include guard.
10149         * nat/x86-gcc-cpuid.h: Add include guard.
10150         * nat/x86-dregs.h: Rename include guard.
10151         * nat/x86-cpuid.h: Rename include guard.
10152         * nat/ppc-linux.h: Rename include guard.
10153         * nat/mips-linux-watch.h: Rename include guard.
10154         * nat/linux-waitpid.h: Rename include guard.
10155         * nat/linux-ptrace.h: Rename include guard.
10156         * nat/linux-procfs.h: Rename include guard.
10157         * nat/linux-osdata.h: Rename include guard.
10158         * nat/linux-nat.h: Rename include guard.
10159         * nat/linux-namespaces.h: Rename include guard.
10160         * nat/linux-btrace.h: Rename include guard.
10161         * nat/glibc_thread_db.h: Rename include guard.
10162         * nat/gdb_thread_db.h: Rename include guard.
10163         * nat/gdb_ptrace.h: Rename include guard.
10164         * nat/fork-inferior.h: Rename include guard.
10165         * nat/amd64-linux-siginfo.h: Rename include guard.
10166         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10167         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10168         * nat/aarch64-linux.h: Rename include guard.
10169         * nat/aarch64-linux-hw-point.h: Rename include guard.
10170         * mn10300-tdep.h: Add include guard.
10171         * mips-linux-tdep.h: Add include guard.
10172         * mi/mi-parse.h: Rename include guard.
10173         * mi/mi-out.h: Rename include guard.
10174         * mi/mi-main.h: Rename include guard.
10175         * mi/mi-interp.h: Rename include guard.
10176         * mi/mi-getopt.h: Rename include guard.
10177         * mi/mi-console.h: Rename include guard.
10178         * mi/mi-common.h: Rename include guard.
10179         * mi/mi-cmds.h: Rename include guard.
10180         * mi/mi-cmd-break.h: Rename include guard.
10181         * m2-lang.h: Add include guard.
10182         * location.h: Rename include guard.
10183         * linux-record.h: Rename include guard.
10184         * linux-nat.h: Add include guard.
10185         * linux-fork.h: Add include guard.
10186         * i386-darwin-tdep.h: Rename include guard.
10187         * hppa-linux-offsets.h: Add include guard.
10188         * guile/guile.h: Rename include guard.
10189         * guile/guile-internal.h: Rename include guard.
10190         * gnu-nat.h: Rename include guard.
10191         * gdb-stabs.h: Rename include guard.
10192         * frv-tdep.h: Add include guard.
10193         * f-lang.h: Add include guard.
10194         * event-loop.h: Add include guard.
10195         * darwin-nat.h: Rename include guard.
10196         * cp-abi.h: Rename include guard.
10197         * config/sparc/nm-sol2.h: Rename include guard.
10198         * config/nm-nto.h: Rename include guard.
10199         * config/nm-linux.h: Add include guard.
10200         * config/i386/nm-i386gnu.h: Rename include guard.
10201         * config/djgpp/nl_types.h: Rename include guard.
10202         * config/djgpp/langinfo.h: Rename include guard.
10203         * compile/gcc-cp-plugin.h: Add include guard.
10204         * compile/gcc-c-plugin.h: Add include guard.
10205         * compile/compile.h: Rename include guard.
10206         * compile/compile-object-run.h: Rename include guard.
10207         * compile/compile-object-load.h: Rename include guard.
10208         * compile/compile-internal.h: Rename include guard.
10209         * compile/compile-cplus.h: Rename include guard.
10210         * compile/compile-c.h: Rename include guard.
10211         * common/xml-utils.h: Rename include guard.
10212         * common/x86-xstate.h: Rename include guard.
10213         * common/version.h: Rename include guard.
10214         * common/vec.h: Rename include guard.
10215         * common/tdesc.h: Rename include guard.
10216         * common/selftest.h: Rename include guard.
10217         * common/scoped_restore.h: Rename include guard.
10218         * common/scoped_mmap.h: Rename include guard.
10219         * common/scoped_fd.h: Rename include guard.
10220         * common/safe-iterator.h: Rename include guard.
10221         * common/run-time-clock.h: Rename include guard.
10222         * common/refcounted-object.h: Rename include guard.
10223         * common/queue.h: Rename include guard.
10224         * common/ptid.h: Rename include guard.
10225         * common/print-utils.h: Rename include guard.
10226         * common/preprocessor.h: Rename include guard.
10227         * common/pathstuff.h: Rename include guard.
10228         * common/observable.h: Rename include guard.
10229         * common/netstuff.h: Rename include guard.
10230         * common/job-control.h: Rename include guard.
10231         * common/host-defs.h: Rename include guard.
10232         * common/gdb_wait.h: Rename include guard.
10233         * common/gdb_vecs.h: Rename include guard.
10234         * common/gdb_unlinker.h: Rename include guard.
10235         * common/gdb_unique_ptr.h: Rename include guard.
10236         * common/gdb_tilde_expand.h: Rename include guard.
10237         * common/gdb_sys_time.h: Rename include guard.
10238         * common/gdb_string_view.h: Rename include guard.
10239         * common/gdb_splay_tree.h: Rename include guard.
10240         * common/gdb_setjmp.h: Rename include guard.
10241         * common/gdb_ref_ptr.h: Rename include guard.
10242         * common/gdb_optional.h: Rename include guard.
10243         * common/gdb_locale.h: Rename include guard.
10244         * common/gdb_assert.h: Rename include guard.
10245         * common/filtered-iterator.h: Rename include guard.
10246         * common/filestuff.h: Rename include guard.
10247         * common/fileio.h: Rename include guard.
10248         * common/environ.h: Rename include guard.
10249         * common/common-utils.h: Rename include guard.
10250         * common/common-types.h: Rename include guard.
10251         * common/common-regcache.h: Rename include guard.
10252         * common/common-inferior.h: Rename include guard.
10253         * common/common-gdbthread.h: Rename include guard.
10254         * common/common-exceptions.h: Rename include guard.
10255         * common/common-defs.h: Rename include guard.
10256         * common/common-debug.h: Rename include guard.
10257         * common/cleanups.h: Rename include guard.
10258         * common/buffer.h: Rename include guard.
10259         * common/btrace-common.h: Rename include guard.
10260         * common/break-common.h: Rename include guard.
10261         * cli/cli-utils.h: Rename include guard.
10262         * cli/cli-style.h: Rename include guard.
10263         * cli/cli-setshow.h: Rename include guard.
10264         * cli/cli-script.h: Rename include guard.
10265         * cli/cli-interp.h: Rename include guard.
10266         * cli/cli-decode.h: Rename include guard.
10267         * cli/cli-cmds.h: Rename include guard.
10268         * charset-list.h: Add include guard.
10269         * buildsym-legacy.h: Rename include guard.
10270         * bfin-tdep.h: Add include guard.
10271         * ax.h: Rename include guard.
10272         * arm-linux-tdep.h: Add include guard.
10273         * arm-fbsd-tdep.h: Add include guard.
10274         * arch/xtensa.h: Rename include guard.
10275         * arch/tic6x.h: Add include guard.
10276         * arch/i386.h: Add include guard.
10277         * arch/arm.h: Rename include guard.
10278         * arch/arm-linux.h: Rename include guard.
10279         * arch/arm-get-next-pcs.h: Rename include guard.
10280         * arch/amd64.h: Add include guard.
10281         * arch/aarch64-insn.h: Rename include guard.
10282         * arch-utils.h: Rename include guard.
10283         * annotate.h: Add include guard.
10284         * amd64-darwin-tdep.h: Rename include guard.
10285         * aarch64-linux-tdep.h: Add include guard.
10286         * aarch64-fbsd-tdep.h: Add include guard.
10287         * aarch32-linux-nat.h: Add include guard.
10288
10289 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10290
10291         * macrotab.c (macro_define_internal): New function that
10292         factorizes macro_define_object_internal and macro_define_function
10293         code.
10294         (macro_define_object_internal): Use macro_define_internal.
10295         (macro_define_function): Likewise.
10296
10297 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10298
10299         * macrocmd.c (extract_identifier): Return
10300         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10301         callers.
10302
10303 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10304
10305         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10306
10307 2019-02-05  Tom Tromey  <tom@tromey.com>
10308
10309         * target.c (target_stack::unpush): Move assertion earlier.
10310
10311 2019-01-30  Tom Tromey  <tom@tromey.com>
10312
10313         PR python/23615:
10314         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10315         (gdbpy_parse_and_eval): Likewise.
10316         * python/python-internal.h (gdbpy_allow_threads): New class.
10317
10318 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10319
10320         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10321         (aarch64_fbsd_fpregmap): Move earlier.
10322         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10323         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10324         instead of individual calls to trad_frame_set_reg_addr.
10325         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10326         earlier.
10327         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10328         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10329         instead of individual calls to trad_frame_set_reg_addr.
10330
10331 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10332
10333         * CONTRIBUTE: Replace contribution list with wiki link.
10334
10335 2019-01-25  Tom Tromey  <tom@tromey.com>
10336
10337         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10338
10339 2019-01-25  Tom Tromey  <tom@tromey.com>
10340
10341         * xtensa-linux-nat.c: Fix common/ includes.
10342         * xml-support.h: Fix common/ includes.
10343         * xml-support.c: Fix common/ includes.
10344         * x86-linux-nat.c: Fix common/ includes.
10345         * windows-nat.c: Fix common/ includes.
10346         * varobj.h: Fix common/ includes.
10347         * varobj.c: Fix common/ includes.
10348         * value.c: Fix common/ includes.
10349         * valops.c: Fix common/ includes.
10350         * utils.c: Fix common/ includes.
10351         * unittests/xml-utils-selftests.c: Fix common/ includes.
10352         * unittests/utils-selftests.c: Fix common/ includes.
10353         * unittests/unpack-selftests.c: Fix common/ includes.
10354         * unittests/tracepoint-selftests.c: Fix common/ includes.
10355         * unittests/style-selftests.c: Fix common/ includes.
10356         * unittests/string_view-selftests.c: Fix common/ includes.
10357         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10358         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10359         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10360         * unittests/rsp-low-selftests.c: Fix common/ includes.
10361         * unittests/parse-connection-spec-selftests.c: Fix common/
10362         includes.
10363         * unittests/optional-selftests.c: Fix common/ includes.
10364         * unittests/offset-type-selftests.c: Fix common/ includes.
10365         * unittests/observable-selftests.c: Fix common/ includes.
10366         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10367         * unittests/memrange-selftests.c: Fix common/ includes.
10368         * unittests/memory-map-selftests.c: Fix common/ includes.
10369         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10370         * unittests/function-view-selftests.c: Fix common/ includes.
10371         * unittests/environ-selftests.c: Fix common/ includes.
10372         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10373         * unittests/common-utils-selftests.c: Fix common/ includes.
10374         * unittests/cli-utils-selftests.c: Fix common/ includes.
10375         * unittests/array-view-selftests.c: Fix common/ includes.
10376         * ui-file.c: Fix common/ includes.
10377         * tui/tui-io.c: Fix common/ includes.
10378         * tracepoint.h: Fix common/ includes.
10379         * tracepoint.c: Fix common/ includes.
10380         * tracefile-tfile.c: Fix common/ includes.
10381         * top.h: Fix common/ includes.
10382         * top.c: Fix common/ includes.
10383         * thread.c: Fix common/ includes.
10384         * target/waitstatus.h: Fix common/ includes.
10385         * target/waitstatus.c: Fix common/ includes.
10386         * target.h: Fix common/ includes.
10387         * target.c: Fix common/ includes.
10388         * target-memory.c: Fix common/ includes.
10389         * target-descriptions.c: Fix common/ includes.
10390         * symtab.h: Fix common/ includes.
10391         * symfile.c: Fix common/ includes.
10392         * stap-probe.c: Fix common/ includes.
10393         * spu-linux-nat.c: Fix common/ includes.
10394         * sparc-nat.c: Fix common/ includes.
10395         * source.c: Fix common/ includes.
10396         * solib.c: Fix common/ includes.
10397         * solib-target.c: Fix common/ includes.
10398         * ser-unix.c: Fix common/ includes.
10399         * ser-tcp.c: Fix common/ includes.
10400         * ser-pipe.c: Fix common/ includes.
10401         * ser-base.c: Fix common/ includes.
10402         * selftest-arch.c: Fix common/ includes.
10403         * s12z-tdep.c: Fix common/ includes.
10404         * rust-exp.y: Fix common/ includes.
10405         * rs6000-aix-tdep.c: Fix common/ includes.
10406         * riscv-tdep.c: Fix common/ includes.
10407         * remote.c: Fix common/ includes.
10408         * remote-notif.h: Fix common/ includes.
10409         * remote-fileio.h: Fix common/ includes.
10410         * remote-fileio.c: Fix common/ includes.
10411         * regcache.h: Fix common/ includes.
10412         * regcache.c: Fix common/ includes.
10413         * record-btrace.c: Fix common/ includes.
10414         * python/python.c: Fix common/ includes.
10415         * python/py-type.c: Fix common/ includes.
10416         * python/py-inferior.c: Fix common/ includes.
10417         * progspace.h: Fix common/ includes.
10418         * producer.c: Fix common/ includes.
10419         * procfs.c: Fix common/ includes.
10420         * proc-api.c: Fix common/ includes.
10421         * printcmd.c: Fix common/ includes.
10422         * ppc-linux-nat.c: Fix common/ includes.
10423         * parser-defs.h: Fix common/ includes.
10424         * osdata.c: Fix common/ includes.
10425         * obsd-nat.c: Fix common/ includes.
10426         * nat/x86-linux.c: Fix common/ includes.
10427         * nat/x86-linux-dregs.c: Fix common/ includes.
10428         * nat/x86-dregs.h: Fix common/ includes.
10429         * nat/x86-dregs.c: Fix common/ includes.
10430         * nat/ppc-linux.c: Fix common/ includes.
10431         * nat/mips-linux-watch.h: Fix common/ includes.
10432         * nat/mips-linux-watch.c: Fix common/ includes.
10433         * nat/linux-waitpid.c: Fix common/ includes.
10434         * nat/linux-ptrace.h: Fix common/ includes.
10435         * nat/linux-ptrace.c: Fix common/ includes.
10436         * nat/linux-procfs.c: Fix common/ includes.
10437         * nat/linux-personality.c: Fix common/ includes.
10438         * nat/linux-osdata.c: Fix common/ includes.
10439         * nat/linux-namespaces.c: Fix common/ includes.
10440         * nat/linux-btrace.h: Fix common/ includes.
10441         * nat/linux-btrace.c: Fix common/ includes.
10442         * nat/fork-inferior.c: Fix common/ includes.
10443         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10444         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10445         * nat/aarch64-linux.c: Fix common/ includes.
10446         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10447         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10448         * namespace.h: Fix common/ includes.
10449         * mips-linux-tdep.c: Fix common/ includes.
10450         * minsyms.c: Fix common/ includes.
10451         * mi/mi-parse.h: Fix common/ includes.
10452         * mi/mi-main.c: Fix common/ includes.
10453         * mi/mi-cmd-env.c: Fix common/ includes.
10454         * memrange.h: Fix common/ includes.
10455         * memattr.c: Fix common/ includes.
10456         * maint.h: Fix common/ includes.
10457         * maint.c: Fix common/ includes.
10458         * main.c: Fix common/ includes.
10459         * machoread.c: Fix common/ includes.
10460         * location.c: Fix common/ includes.
10461         * linux-thread-db.c: Fix common/ includes.
10462         * linux-nat.c: Fix common/ includes.
10463         * linux-fork.c: Fix common/ includes.
10464         * inline-frame.c: Fix common/ includes.
10465         * infrun.c: Fix common/ includes.
10466         * inflow.c: Fix common/ includes.
10467         * inferior.h: Fix common/ includes.
10468         * inferior.c: Fix common/ includes.
10469         * infcmd.c: Fix common/ includes.
10470         * inf-ptrace.c: Fix common/ includes.
10471         * inf-child.c: Fix common/ includes.
10472         * ia64-linux-nat.c: Fix common/ includes.
10473         * i387-tdep.c: Fix common/ includes.
10474         * i386-tdep.c: Fix common/ includes.
10475         * i386-linux-tdep.c: Fix common/ includes.
10476         * i386-linux-nat.c: Fix common/ includes.
10477         * i386-go32-tdep.c: Fix common/ includes.
10478         * i386-fbsd-tdep.c: Fix common/ includes.
10479         * i386-fbsd-nat.c: Fix common/ includes.
10480         * guile/scm-type.c: Fix common/ includes.
10481         * guile/guile.c: Fix common/ includes.
10482         * go32-nat.c: Fix common/ includes.
10483         * gnu-nat.c: Fix common/ includes.
10484         * gdbthread.h: Fix common/ includes.
10485         * gdbarch-selftests.c: Fix common/ includes.
10486         * gdb_usleep.c: Fix common/ includes.
10487         * gdb_select.h: Fix common/ includes.
10488         * gdb_bfd.c: Fix common/ includes.
10489         * gcore.c: Fix common/ includes.
10490         * fork-child.c: Fix common/ includes.
10491         * findvar.c: Fix common/ includes.
10492         * fbsd-nat.c: Fix common/ includes.
10493         * event-top.c: Fix common/ includes.
10494         * event-loop.c: Fix common/ includes.
10495         * dwarf2read.c: Fix common/ includes.
10496         * dwarf2loc.c: Fix common/ includes.
10497         * dwarf2-frame.c: Fix common/ includes.
10498         * dwarf-index-cache.c: Fix common/ includes.
10499         * dtrace-probe.c: Fix common/ includes.
10500         * disasm-selftests.c: Fix common/ includes.
10501         * defs.h: Fix common/ includes.
10502         * csky-tdep.c: Fix common/ includes.
10503         * cp-valprint.c: Fix common/ includes.
10504         * cp-support.h: Fix common/ includes.
10505         * cp-support.c: Fix common/ includes.
10506         * corelow.c: Fix common/ includes.
10507         * completer.h: Fix common/ includes.
10508         * completer.c: Fix common/ includes.
10509         * compile/compile.c: Fix common/ includes.
10510         * compile/compile-loc2c.c: Fix common/ includes.
10511         * compile/compile-cplus-types.c: Fix common/ includes.
10512         * compile/compile-cplus-symbols.c: Fix common/ includes.
10513         * command.h: Fix common/ includes.
10514         * cli/cli-dump.c: Fix common/ includes.
10515         * cli/cli-cmds.c: Fix common/ includes.
10516         * charset.c: Fix common/ includes.
10517         * build-id.c: Fix common/ includes.
10518         * btrace.h: Fix common/ includes.
10519         * btrace.c: Fix common/ includes.
10520         * breakpoint.h: Fix common/ includes.
10521         * breakpoint.c: Fix common/ includes.
10522         * ax.h:
10523         (enum agent_op): Fix common/ includes.
10524         * ax-general.c (struct aop_map): Fix common/ includes.
10525         * ax-gdb.c: Fix common/ includes.
10526         * auxv.c: Fix common/ includes.
10527         * auto-load.c: Fix common/ includes.
10528         * arm-tdep.c: Fix common/ includes.
10529         * arch/riscv.c: Fix common/ includes.
10530         * arch/ppc-linux-common.c: Fix common/ includes.
10531         * arch/i386.c: Fix common/ includes.
10532         * arch/arm.c: Fix common/ includes.
10533         * arch/arm-linux.c: Fix common/ includes.
10534         * arch/arm-get-next-pcs.c: Fix common/ includes.
10535         * arch/amd64.c: Fix common/ includes.
10536         * arch/aarch64.c: Fix common/ includes.
10537         * arch/aarch64-insn.c: Fix common/ includes.
10538         * arch-utils.c: Fix common/ includes.
10539         * amd64-windows-tdep.c: Fix common/ includes.
10540         * amd64-tdep.c: Fix common/ includes.
10541         * amd64-sol2-tdep.c: Fix common/ includes.
10542         * amd64-obsd-tdep.c: Fix common/ includes.
10543         * amd64-nbsd-tdep.c: Fix common/ includes.
10544         * amd64-linux-tdep.c: Fix common/ includes.
10545         * amd64-linux-nat.c: Fix common/ includes.
10546         * amd64-fbsd-tdep.c: Fix common/ includes.
10547         * amd64-fbsd-nat.c: Fix common/ includes.
10548         * amd64-dicos-tdep.c: Fix common/ includes.
10549         * amd64-darwin-tdep.c: Fix common/ includes.
10550         * agent.c: Fix common/ includes.
10551         * ada-lang.h: Fix common/ includes.
10552         * ada-lang.c: Fix common/ includes.
10553         * aarch64-tdep.c: Fix common/ includes.
10554
10555 2019-01-25  Tom Tromey  <tom@tromey.com>
10556
10557         * common/create-version.sh: Use common/version.h.
10558
10559 2019-01-24  Pedro Alves  <palves@redhat.com>
10560
10561         * infrun.c (signal_stop, signal_print, signal_program)
10562         (signal_catch, signal_pass): Now arrays instead of pointers.
10563         (update_signals_program_target, do_target_resume)
10564         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10565         * linux-nat.c (linux_nat_target::pass_signals)
10566         (linux_nat_target::create_inferior, linux_nat_target::attach):
10567         Adjust.
10568         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10569         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10570         * procfs.c (procfs_target::pass_signals): Adjust.
10571         * record-full.c (record_full_target::resume): Adjust.
10572         * remote.c (remote_target::pass_signals)
10573         (remote_target::program_signals): Adjust.
10574         * target-debug.h (target_debug_print_signals): Now takes a
10575         gdb::array_view as parameter.  Adjust.
10576         * target.h (target_ops) <pass_signals, program_signals>: Replace
10577         pointer and length parameters with gdb::array_view.
10578         (target_pass_signals, target_program_signals): Likewise.
10579         * target-delegates.c: Regenerate.
10580
10581 2019-01-24  Pedro Alves  <palves@redhat.com>
10582
10583         * common/forward-scope-exit.h
10584         (forward_scope_exit::forward_scope_exit): Pass arguments to
10585         m_bind_function directly, instead of creating a std::bind and
10586         copying that.
10587
10588 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10589
10590         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10591         for static members.
10592         (pass_in_v_vfp_candidate): Likewise.
10593
10594 2019-01-23  Tom Tromey  <tom@tromey.com>
10595             Pedro Alves  <palves@redhat.com>
10596
10597         * regcache.c (class regcache_invalidator): Remove.
10598         (regcache::raw_write): Use make_scope_exit.
10599
10600 2019-01-23  Tom Tromey  <tom@tromey.com>
10601
10602         * ui-out.h (class ui_out_emit_type): Update comment.
10603
10604 2019-01-23  Tom Tromey  <tom@tromey.com>
10605
10606         * infrun.c (fetch_inferior_event): Update comment.
10607
10608 2019-01-23  Tom Tromey  <tom@tromey.com>
10609             Pedro Alves  <palves@redhat.com>
10610
10611         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10612         parameter.
10613         (fetch_inferior_event): Use SCOPE_EXIT.
10614
10615
10616 2019-01-23  Tom Tromey  <tom@tromey.com>
10617             Pedro Alves  <palves@redhat.com>
10618
10619         * infrun.c (disable_thread_events): Delete.
10620         (stop_all_threads): Use SCOPE_EXIT.
10621
10622 2019-01-23  Tom Tromey  <tom@tromey.com>
10623             Pedro Alves  <palves@redhat.com>
10624
10625         * symfile.c: Include forward-scope-exit.h.
10626         (clear_symtab_users_cleanup): Replace forward declaration with
10627         a FORWARD_SCOPE_EXIT.
10628         (syms_from_objfile_1): Use the forward_scope_exit and
10629         gdb::optional instead of cleanup_function.
10630         (reread_symbols): Use the forward_scope_exit instead of
10631         cleanup_function.
10632         (clear_symtab_users_cleanup): Remove function.
10633
10634 2019-01-23  Tom Tromey  <tom@tromey.com>
10635             Pedro Alves  <palves@redhat.com>
10636
10637         * linux-nat.c: Include scope-exit.h.
10638         (cleanup_target_stop): Remove.
10639         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10640         SCOPE_EXIT.
10641
10642 2019-01-23  Tom Tromey  <tom@tromey.com>
10643             Pedro Alves  <palves@redhat.com>
10644
10645         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10646         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10647
10648 2019-01-23  Tom Tromey  <tom@tromey.com>
10649             Andrew Burgess  <andrew.burgess@embecosm.com>
10650             Pedro Alves  <palves@redhat.com>
10651
10652         * infrun.c (fetch_inferior_event): Use scope_exit.
10653         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10654         * top.c (execute_command): Use scope_exit.
10655         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10656         * utils.c (do_bpstat_clear_actions_cleanup)
10657         (make_bpstat_clear_actions_cleanup): Remove.
10658
10659 2019-01-23  Tom Tromey  <tom@tromey.com>
10660             Pedro Alves  <palves@redhat.com>
10661
10662         * infrun.c: Include "common/scope-exit.h"
10663         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10664         (wait_for_inferior): Use SCOPE_EXIT.
10665         (fetch_inferior_event): Use scope_exit.
10666
10667 2019-01-23  Tom Tromey  <tom@tromey.com>
10668             Pedro Alves  <palves@redhat.com>
10669
10670         * breakpoint.c (create_breakpoint): Remove cleanup.
10671
10672 2019-01-23  Tom Tromey  <tom@tromey.com>
10673             Andrew Burgess  <andrew.burgess@embecosm.com>
10674             Pedro Alves  <palves@redhat.com>
10675
10676 2019-01-23  Pedro Alves  <palves@redhat.com>
10677
10678         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10679
10680 2019-01-23  Pedro Alves  <palves@redhat.com>
10681             Andrew Burgess  <andrew.burgess@embecosm.com>
10682
10683         * gdbthread.h: Include "common/forward-scope-exit.h".
10684         (scoped_finish_thread_state): Redefine custom class in terms of
10685         forward_scope_exit.
10686
10687 2019-01-23  Pedro Alves  <palves@redhat.com>
10688             Andrew Burgess  <andrew.burgess@embecosm.com>
10689
10690         * common/forward-scope-exit.h: New file.
10691
10692 2019-01-23  Pedro Alves  <palves@redhat.com>
10693             Andrew Burgess  <andrew.burgess@embecosm.com>
10694             Tom Tromey  <tom@tromey.com>
10695
10696         * common/scope-exit.h: New file.
10697
10698 2019-01-23  Pedro Alves  <palves@redhat.com>
10699
10700         * common/preprocessor.h (ESC): Rename to ...
10701         (ESC_PARENS): ... this.
10702         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10703         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10704
10705 2019-01-23  Tom Tromey  <tom@tromey.com>
10706
10707         * language.h (class scoped_switch_to_sym_language_if_auto):
10708         Initialize m_lang in both cases.
10709
10710 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10711
10712         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10713         with XCNEW.
10714
10715 2019-01-22  Tom Tromey  <tom@tromey.com>
10716
10717         * corelow.c: Do not include sys/file.h.
10718
10719 2019-01-22  Tom Tromey  <tom@tromey.com>
10720
10721         * tui/tui-wingeneral.h: Include gdb_curses.h.
10722
10723 2019-01-22  Tom Tromey  <tom@tromey.com>
10724
10725         * source-cache.h (class source_cache) <get_source_lines,
10726         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10727
10728 2019-01-22  Tom Tromey  <tom@tromey.com>
10729
10730         * remote-fileio.h (struct remote_target): Declare.
10731
10732 2019-01-22  Tom Tromey  <tom@tromey.com>
10733
10734         * python/py-arch.c: Do not include py-ref.h.
10735         * python/py-bpevent.c: Do not include py-ref.h.
10736         * python/py-cmd.c: Do not include py-ref.h.
10737         * python/py-continueevent.c: Do not include py-ref.h.
10738         * python/py-event.h: Do not include py-ref.h.
10739         * python/py-evtregistry.c: Do not include py-ref.h.
10740         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10741         * python/py-frame.c: Do not include py-ref.h.
10742         * python/py-framefilter.c: Do not include py-ref.h.
10743         * python/py-function.c: Do not include py-ref.h.
10744         * python/py-infevents.c: Do not include py-ref.h.
10745         * python/py-linetable.c: Do not include py-ref.h.
10746         * python/py-objfile.c: Do not include py-ref.h.
10747         * python/py-param.c: Do not include py-ref.h.
10748         * python/py-prettyprint.c: Do not include py-ref.h.
10749         * python/py-progspace.c: Do not include py-ref.h.
10750         * python/py-symbol.c: Do not include py-ref.h.
10751         * python/py-symtab.c: Do not include py-ref.h.
10752         * python/py-type.c: Do not include py-ref.h.
10753         * python/py-unwind.c: Do not include py-ref.h.
10754         * python/py-utils.c: Do not include py-ref.h.
10755         * python/py-value.c: Do not include py-ref.h.
10756         * python/py-varobj.c: Do not include py-ref.h.
10757         * python/py-xmethods.c: Do not include py-ref.h.
10758         * python/python.c: Do not include py-ref.h.
10759         * varobj.c: Do not include py-ref.h.
10760
10761 2019-01-22  Tom Tromey  <tom@tromey.com>
10762
10763         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10764         keyword for bcache.
10765
10766 2019-01-22  Tom Tromey  <tom@tromey.com>
10767
10768         * compile/compile-cplus-types.c: Remove a comment by #include.
10769
10770 2019-01-22  Tom Tromey  <tom@tromey.com>
10771
10772         * compile/gcc-c-plugin.h: Include compile-internal.h.
10773
10774 2019-01-22  Tom Tromey  <tom@tromey.com>
10775
10776         * stabsread.c (EXTERN): Do not define.
10777         (symnum, next_symbol_text_func, processing_gcc_compilation)
10778         (within_function, global_sym_chain, global_stabs)
10779         (previous_stab_code, this_object_header_files)
10780         (n_this_object_header_files)
10781         (n_allocated_this_object_header_files): Define.
10782         * stabsread.h (EXTERN): Never define.  Use "extern".
10783
10784 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10785
10786         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10787         history_value.
10788
10789 2019-01-21  Tom Tromey  <tom@tromey.com>
10790
10791         * ui-out.c: Fix includes.
10792         * tui/tui-source.c: Fix includes.
10793         * target.c: Fix includes.
10794         * remote.c: Fix includes.
10795         * regcache.c: Fix includes.
10796         * python/py-block.c: Fix includes.
10797         * printcmd.c: Fix includes.
10798         * or1k-tdep.c: Fix includes.
10799         * mi/mi-main.c: Fix includes.
10800         * m32r-tdep.c: Fix includes.
10801         * csky-tdep.c: Fix includes.
10802         * compile/compile-cplus-types.c: Fix includes.
10803         * cli/cli-interp.c: Fix includes.
10804
10805 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10806
10807         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10808         for padding.
10809
10810 2019-01-16  Tom Tromey  <tom@tromey.com>
10811
10812         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10813         earlier.
10814         (struct objfile) <msymbols_range>: Move from top level.
10815         <msymbols>: New method.
10816         (class objfile_msymbols): Remove.
10817         * symtab.c (default_collect_symbol_completion_matches_break_on):
10818         Update.
10819         * symmisc.c (dump_msymbols): Update.
10820         * stabsread.c (scan_file_globals): Update.
10821         * objc-lang.c (info_selectors_command, info_classes_command)
10822         (find_methods): Update.
10823         * minsyms.c (find_solib_trampoline_target): Update.
10824         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10825         * coffread.c (coff_symfile_read): Update.
10826         * ada-lang.c (ada_lookup_simple_minsym)
10827         (ada_collect_symbol_completion_matches): Update.
10828
10829 2019-01-16  Tom Tromey  <tom@tromey.com>
10830
10831         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10832         type.  Remove no-argument constructor.
10833         <iterator::operator++>: Simplify.
10834         <begin>: Update.
10835         <end>: Use minimal_symbol_count.
10836
10837 2019-01-16  Tom Tromey  <tom@tromey.com>
10838
10839         * objfiles.h (struct objfile) <psymtabs>: New method.
10840         (class objfile_psymtabs): Remove.
10841         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10842         typedef.
10843         <range>: New method.
10844         (require_partial_symbols): Change return type.
10845         * psymtab.c (require_partial_symbols)
10846         (psym_expand_symtabs_matching): Update.
10847         * mdebugread.c (parse_partial_symbols): Update.
10848         * dbxread.c (dbx_end_psymtab): Update.
10849
10850 2019-01-15  Tom Tromey  <tom@tromey.com>
10851
10852         * symtab.c (lookup_objfile_from_block)
10853         (lookup_symbol_in_objfile_symtabs)
10854         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10855         (find_line_symtab, info_sources_command)
10856         (default_collect_symbol_completion_matches_break_on)
10857         (make_source_files_completion_list): Update.
10858         * symmisc.c (print_objfile_statistics, dump_objfile)
10859         (maintenance_print_symbols, maintenance_info_symtabs)
10860         (maintenance_check_symtabs, maintenance_info_line_tables):
10861         Update.
10862         * source.c (select_source_symtab)
10863         (forget_cached_source_info_for_objfile): Update.
10864         * objfiles.h (class objfile_compunits): Remove.
10865         (struct objfile) <compunits_range>: New typedef.
10866         (compunits): New method.
10867         * objfiles.c (objfile_relocate1): Update.
10868         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10869         * maint.c (count_symtabs_and_blocks): Update.
10870         * linespec.c (iterate_over_all_matching_symtabs): Update.
10871         * cp-support.c (add_symbol_overload_list_qualified): Update.
10872         * coffread.c (coff_symtab_read): Update.
10873         * ada-lang.c (add_nonlocal_symbols)
10874         (ada_collect_symbol_completion_matches)
10875         (ada_add_global_exceptions): Update.
10876
10877 2019-01-15  Tom Tromey  <tom@tromey.com>
10878
10879         * progspace.h (program_space) <objfiles_safe_range>: New
10880         typedef.
10881         <objfiles_safe>: New method.
10882         * objfiles.h (class all_objfiles_safe): Remove.
10883         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10884         * jit.c (jit_inferior_exit_hook): Update.
10885
10886 2019-01-17  Tom Tromey  <tom@tromey.com>
10887
10888         * progspace.h (program_space) <objfiles_range>: New typedef.
10889         <objfiles>: New method.
10890         <objfiles_head>: Rename from objfiles.
10891         (object_files): Update.
10892         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10893         * guile/scm-pretty-print.c
10894         (ppscm_find_pretty_printer_from_objfiles): Update.
10895         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10896         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10897         Update.
10898         * python/py-progspace.c (pspy_get_objfiles): Update.
10899         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10900         Update.
10901         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10902         (objfpy_lookup_objfile_by_build_id): Update.
10903         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10904         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10905         Update.
10906         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10907         (expand_symtab_containing_pc, lookup_objfile_from_block)
10908         (lookup_static_symbol, basic_lookup_transparent_type)
10909         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10910         (find_line_symtab, info_sources_command)
10911         (default_collect_symbol_completion_matches_break_on)
10912         (make_source_files_completion_list, find_main_name): Update.
10913         * symmisc.c (print_symbol_bcache_statistics)
10914         (print_objfile_statistics, maintenance_print_symbols)
10915         (maintenance_print_msymbols, maintenance_print_objfiles)
10916         (maintenance_info_symtabs, maintenance_check_symtabs)
10917         (maintenance_expand_symtabs, maintenance_info_line_tables):
10918         Update.
10919         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10920         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10921         (map_overlay_command, unmap_overlay_command)
10922         (simple_overlay_update, expand_symtabs_matching)
10923         (map_symbol_filenames): Update.
10924         * symfile-debug.c (set_debug_symfile): Update.
10925         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10926         Update.
10927         * source.c (select_source_symtab, forget_cached_source_info):
10928         Update.
10929         * solib.c (solib_read_symbols): Update.
10930         * solib-spu.c (append_ocl_sos): Update.
10931         * psymtab.c (maintenance_print_psymbols)
10932         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10933         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10934         * printcmd.c (info_symbol_command): Update.
10935         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10936         Update.
10937         * objfiles.h (class all_objfiles): Remove.
10938         * objfiles.c (have_partial_symbols, have_full_symbols)
10939         (have_minimal_symbols, qsort_cmp, update_section_map)
10940         (shared_objfile_contains_address_p)
10941         (default_iterate_over_objfiles_in_search_order): Update.
10942         * objc-lang.c (info_selectors_command, info_classes_command)
10943         (find_methods): Update.
10944         * minsyms.c (find_solib_trampoline_target): Update.
10945         * maint.c (maintenance_info_sections)
10946         (maintenance_translate_address, count_symtabs_and_blocks):
10947         Update.
10948         * main.c (captured_main_1): Update.
10949         * linux-thread-db.c (try_thread_db_load_from_pdir)
10950         (has_libpthread): Update.
10951         * linespec.c (iterate_over_all_matching_symtabs)
10952         (search_minsyms_for_name): Update.
10953         * jit.c (jit_find_objf_with_entry_addr): Update.
10954         * hppa-tdep.c (find_unwind_entry)
10955         (hppa_lookup_stub_minimal_symbol): Update.
10956         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10957         Update.
10958         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10959         (elf_gnu_ifunc_resolve_by_got): Update.
10960         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10961         * dwarf-index-write.c (save_gdb_index_command): Update.
10962         * cp-support.c (add_symbol_overload_list_qualified): Update.
10963         * breakpoint.c (create_overlay_event_breakpoint)
10964         (create_longjmp_master_breakpoint)
10965         (create_std_terminate_master_breakpoint)
10966         (create_exception_master_breakpoint): Update.
10967         * blockframe.c (find_pc_partial_function): Update.
10968         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10969         (ada_collect_symbol_completion_matches)
10970         (ada_add_global_exceptions): Update.
10971
10972 2019-01-17  Tom Tromey  <tom@tromey.com>
10973
10974         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10975         declare VEC.
10976         (solib_target_parse_libraries): Change return type.
10977         (library_list_start_segment, library_list_start_section)
10978         (library_list_end_library, library_list_start_library); Update.
10979         (solib_target_free_library_list): Remove.
10980         (solib_target_parse_libraries): Remove cleanup.  Change return
10981         type.
10982         (solib_target_current_sos): Update.
10983
10984 2019-01-17  Tom Tromey  <tromey@bapiya>
10985
10986         * valprint.c: Replace "the the" with "the".
10987         * symtab.c: Replace "the the" with "the".
10988         * solib.c: Replace "the the" with "the".
10989         * solib-dsbt.c: Replace "the the" with "the".
10990         * linespec.c: Replace "the the" with "the".
10991         * dwarf2loc.h: Replace "the the" with "the".
10992         * amd64-windows-tdep.c: Replace "the the" with "the".
10993         * aarch64-tdep.c: Replace "the the" with "the".
10994
10995 2019-01-16  Keith Seitz  <keiths@redhat.com>
10996
10997         PR gdb/23773
10998         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10999         <builder>: Rename to ..
11000         <m_builder>: ... this and make private.
11001         (dwarf2_cu::get_builder): New method.  Change all users of
11002         `builder' to use this method.
11003         (dwarf2_start_symtab): Move to ...
11004         (dwarf2_cu::start_symtab): ... here.  Update all callers
11005         (setup_type_unit_groups): Move to ...
11006         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11007         callers.
11008         (dwarf2_cu::reset_builder): New method.
11009         (process_full_compunit, process_full_type_unit): Use
11010         dwarf2_cu::reset_builder.
11011         (follow_die_offset): Record the ancestor CU if it is different
11012         from the followed DIE's CU.
11013         (follow_die_sig_1): Likewise.
11014
11015 2019-01-15  Tom Tromey  <tom@tromey.com>
11016
11017         * remote.c (class remote_state) <buf>: Now a char_vector.
11018         <buf_size>: Remove.
11019         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11020         parameter.
11021         (remote_target::getpkt_or_notif_sane_1)
11022         (remote_target::getpkt_sane)
11023         (remote_target::getpkt_or_notif_sane): Likewise.
11024         (class remote_target) <putpkt>: New overload.
11025         (remote_target::read_frame): Change type of "buf_p".  Remove
11026         sizeof_p parameter.
11027         (packet_ok): New overload.
11028         (packet_check_result): New overload.
11029         Update all uses.
11030
11031 2019-01-14  Tom Tromey  <tom@tromey.com>
11032
11033         * remote-notif.c (handle_notification, remote_notif_ack)
11034         (remote_notif_parse): Make "buf" const.
11035         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11036         const.
11037         (remote_notif_parse, remote_notif_ack, handle_notification):
11038         Likewise.
11039         * remote.c (remote_notif_stop_parse): Make "buf" const.
11040         (remote_target::remote_parse_stop_reply): Make "buf" const.
11041         (remote_notif_stop_ack): Make "buf" const.
11042
11043 2019-01-14  Tom Tromey  <tom@tromey.com>
11044
11045         * remote.c (remote_console_output): Make parameter const.
11046
11047 2019-01-14  Tom Tromey  <tom@tromey.com>
11048
11049         * target-debug.h (target_debug_print_signals): Constify.
11050         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11051         * procfs.c (procfs_target::pass_signals): Update.
11052         * linux-nat.c (linux_nat_target::pass_signals): Update.
11053         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11054         * target-delegates.c: Rebuild.
11055         * remote.c (remote_target::program_signals): Update.
11056         (remote_target::pass_signals): Update.
11057         * target.c (target_pass_signals): Constify argument.
11058         (target_program_signals): Likewise.
11059         * target.h (struct target_ops) <pass_signals, program_signals>:
11060         Constify argument.
11061         (target_pass_signals, target_program_signals): Constify argument.
11062
11063 2019-01-14  Tom Tromey  <tom@tromey.com>
11064
11065         PR tui/28819:
11066         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11067
11068 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11069
11070         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11071         field.
11072         * rs6000-tdep.c: Include reggroups.h.
11073         (IS_V_ALIAS_PSEUDOREG): Define.
11074         (rs6000_register_name): Return names for the "vX" aliases.
11075         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11076         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11077         aliases.  Call default_register_reggroup_p for all other
11078         pseudo-registers.
11079         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11080         New functions.
11081         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11082         Handle "vX" aliases.
11083         (v_alias_pseudo_register_collect): New function.
11084         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11085         (rs6000_gdbarch_init): Initialize "vX" aliases as
11086         pseudo-registers.  Restore registration of
11087         rs6000_pseudo_register_reggroup_p with
11088         set_tdesc_pseudo_register_reggroup_p.
11089
11090 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11091
11092         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11093         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11094         set_gdbarch_num_pseudo_regs.
11095
11096 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11097
11098         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11099         Remove arg prefixname, add do_set and do_show.
11100         Add member functions set_list and show_list.
11101         * cli/cli-style.c (class cli_style_option): Update accordingly.
11102         (style_set_list): Move to file scope.
11103         (style_show_list): Likewise.
11104         (set_style): Call help_list.
11105         (show_style): Call cmd_show_list.
11106         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11107         Update to use the new macro.
11108
11109 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11110
11111         * ada-lang.c (_initialize_ada_language): Expand the help text
11112         for the "catch exception" command.
11113
11114 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11115
11116         * symtab.c (matching_obj_sections): Initialize obj,
11117         declare it closer to its usage.
11118
11119 2019-01-10  Tom Tromey  <tom@tromey.com>
11120
11121         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11122         (basic_inf_threads_range): Remove.
11123         (inf_threads_range, inf_non_exited_threads_range)
11124         (safe_inf_threads_range): Use next_adapter.
11125
11126 2019-01-10  Keith Seitz  <keiths@redhat.com>
11127
11128         PR gdb/23712
11129         PR symtab/23010
11130         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11131         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11132
11133 2019-01-10  Keith Seitz  <keiths@redhat.com>
11134
11135         PR gdb/23712
11136         PR symtab/23010
11137         * dictionary.c (pending_to_vector): Remove.
11138         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11139         Remove _1 suffix, replacing functions of the same name.  Update
11140         all callers.
11141         (dict_create_hashed, dict_create_hashed_expandable)
11142         (dict_create_linear, dict_create_linear_expandable, dict_free)
11143         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11144         Make functions static.
11145
11146 2019-01-10  Keith Seitz  <keiths@redhat.com>
11147
11148         PR gdb/23712
11149         PR symtab/23010
11150         * dictionary.h (struct dictionary): Replace declaration with
11151         multidictionary.
11152         (dict_create_hashed, dict_create_hashed_expandable)
11153         (dict_create_linear, dict_create_linear_expandable)
11154         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11155         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11156         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11157         taking multidictionary argument.
11158         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11159         * block.h (struct block) <dict>: Change to multidictionary
11160         and rename `multidict'.
11161         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11162         symmisc.c: Update all dictionary references to multidictionary.
11163
11164 2019-01-10  Keith Seitz  <keiths@redhat.com>
11165
11166         PR gdb/23712
11167         PR symtab/23010
11168         * dictionary.c: Include unordered_map.
11169         (pending_to_vector): New function.
11170         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11171         Rewrite the non-"_1" functions to take vector instead
11172         of linked list.
11173         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11174         "new" _1 versions of the same name.
11175         (multidictionary): Define.
11176         (std::hash<enum language): New definition.
11177         (collate_pending_symbols_by_language, mdict_create_hashed)
11178         (mdict_create_hashed_expandable, mdict_create_linear)
11179         (mdict_create_linear_expandable, mdict_free)
11180         (find_language_dictionary, create_new_language_dictionary)
11181         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11182         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11183         (mdict_size, mdict_empty): New functions.
11184         * dictionary.h (mdict_iterator): Define.
11185
11186 2019-01-10  Pedro Alves  <palves@redhat.com>
11187
11188         * breakpoint.c (read_uploaded_action)
11189         (create_tracepoint_from_upload): Adjust to use
11190         gdb::unique_xmalloc_ptr.
11191         * ctf.c (ctf_write_uploaded_tp):
11192         (SET_ARRAY_FIELD): Use emplace_back.
11193         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11194         * tracefile-tfile.c (tfile_write_uploaded_tp):
11195         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11196         gdb::unique_xmalloc_ptr.
11197         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11198         at_string, cond_string, cmd_strings>: Replace char pointers
11199         with gdb::unique_xmalloc_ptr.
11200
11201 2019-01-10  Pedro Alves  <palves@redhat.com>
11202
11203         * solib-target.c (library_list_start_library): Don't xstrdup name.
11204
11205 2019-01-10  Pedro Alves  <palves@redhat.com>
11206
11207         * mdebugread.c (parse_partial_symbols): Use
11208         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11209
11210 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11211
11212         * linux-fork.c (scoped_switch_fork_info)
11213         <~scoped_switch_fork_info>: Fix incorrect variable name.
11214
11215 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11216
11217         * linux-fork.c (scoped_switch_fork_info)
11218         <scoped_switch_fork_info>: Make explicit.
11219         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11220
11221 2019-01-10  Tom Tromey  <tom@tromey.com>
11222
11223         * objfiles.h (objfile::reset_psymtabs): Update.
11224         * objfiles.c (objfile::objfile): Update.
11225         * psymtab.h (psymtab_storage::obstack): Update.
11226         (psymtab_storage::m_obstack): Use gdb::optional.
11227         (class psymtab_storage): Update comment.  Remove objfile
11228         parameter.
11229         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11230
11231 2019-01-10  Tom Tromey  <tom@tromey.com>
11232
11233         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11234         <free_psymtabs>: Now private.
11235         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11236         (allocate_psymtab): Use new method.
11237
11238 2019-01-10  Tom Tromey  <tom@tromey.com>
11239
11240         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11241         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11242         * mdebugread.c (parse_partial_symbols): Use
11243         allocate_dependencies.
11244         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11245         allocate_dependencies.
11246         (process_psymtab_comp_unit_reader)
11247         (build_type_psymtab_dependencies): Likewise.
11248         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11249
11250 2019-01-10  Tom Tromey  <tom@tromey.com>
11251
11252         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11253         PSYMBOL_SET_LANGUAGE.
11254         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11255
11256 2019-01-10  Tom Tromey  <tom@tromey.com>
11257
11258         * psymtab.h (psymtab_storage::obstack): New method.
11259         <m_obstack>: Rename from obstack; now private.
11260         * psymtab.c (psymtab_storage): Update.
11261         * dwarf2read.c (create_addrmap_from_index)
11262         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11263         Update.
11264
11265 2019-01-10  Tom Tromey  <tom@tromey.com>
11266
11267         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11268         * objfiles.h (objfile::reset_psymtabs): New method.
11269
11270 2019-01-10  Tom Tromey  <tom@tromey.com>
11271
11272         * symmisc.c (print_symbol_bcache_statistics): Update.
11273         (print_objfile_statistics): Update.
11274         * symfile.c (reread_symbols): Update.
11275         * psymtab.h (class psymtab_storage): New.
11276         * psymtab.c (psymtab_storage): New constructor.
11277         (~psymtab_storage): New destructor.
11278         (require_partial_symbols): Update.
11279         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11280         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11281         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11282         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11283         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11284         (start_psymtab_common, end_psymtab_common)
11285         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11286         (allocate_psymtab): Update.
11287         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11288         Update.
11289         (dump_psymtab_addrmap, maintenance_print_psymbols)
11290         (maintenance_check_psymtabs): Update.
11291         (class objfile_psymtabs): Move to objfiles.h.
11292         * psympriv.h (discard_psymtab): Now inline.
11293         (psymtab_discarder::psymtab_discarder): Update.
11294         (psymtab_discarder::~psymtab_discarder): Update.
11295         (ALL_OBJFILE_PSYMTABS): Rewrite.
11296         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11297         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11298         Remove fields.
11299         <partial_symtabs>: New field.
11300         (class objfile_psymtabs): Move from psymtab.h.  Update.
11301         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11302         psymbol_cache.
11303         (objfile::~objfile): Don't destroy psymbol_cache.
11304         * mdebugread.c (parse_partial_symbols): Update.
11305         * dwarf2read.c (create_addrmap_from_index)
11306         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11307         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11308         (add_partial_subprogram, dwarf2_ranges_read): Update.
11309         * dwarf-index-write.c (write_address_map)
11310         (write_one_signatured_type, recursively_write_psymbols)
11311         (class debug_names, class debug_names, write_psymtabs_to_index):
11312         Update.
11313
11314 2019-01-10  Tom Tromey  <tom@tromey.com>
11315
11316         * symtab.h (SYMBOL_SET_NAMES): Update.
11317         (symbol_set_names): Update.
11318         (MSYMBOL_SET_NAMES): Update.
11319         * symtab.c (symbol_set_names): Change argument to be an
11320         objfile_per_bfd_storage.
11321         * psymtab.c (add_psymbol_to_bcache): Update.
11322         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11323
11324 2019-01-10  Tom Tromey  <tom@tromey.com>
11325
11326         * symtab.c (create_demangled_names_hash): Change argument to be an
11327         objfile_per_bfd_storage.
11328         (symbol_set_names): Update.
11329
11330 2019-01-10  Tom Tromey  <tom@tromey.com>
11331
11332         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11333         init_psymbol_list.
11334         * psymtab.c (init_psymbol_list): Do nothing if already called.
11335         * psympriv.h (init_psymbol_list): Add comment.
11336         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11337         init_psymbol_list.
11338         * dbxread.c (dbx_symfile_read): Unconditionally call
11339         init_psymbol_list.
11340
11341 2019-01-10  Tom Tromey  <tom@tromey.com>
11342
11343         * xcoffread.c (scan_xcoff_symtab): Update.
11344         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11345         "where".
11346         * mdebugread.c (parse_partial_symbols)
11347         (handle_psymbol_enumerators): Update.
11348         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11349         * dbxread.c (read_dbx_symtab): Update.
11350         * psympriv.h (psymbol_placement): New enum.
11351         (add_psymbol_to_list): Update.
11352
11353 2019-01-10  Tom Tromey  <tom@tromey.com>
11354
11355         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11356         static_psymbols parameters.
11357         (scan_xcoff_symtab): Update.
11358         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11359         static_psymbols parameters.
11360         * psympriv.h (start_psymtab_common): Update.
11361         * mdebugread.c (parse_partial_symbols): Update.
11362         * dwarf2read.c (create_partial_symtab): Update.
11363         * dbxread.c (read_dbx_symtab): Update.
11364         (start_psymtab): Remove global_psymbols and static_psymbols
11365         parameters.
11366
11367 2019-01-10  Tom Tromey  <tom@tromey.com>
11368
11369         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11370         * psymtab.c (allocate_psymtab): Add comment.
11371         * psympriv.h (allocate_psymtab): Add comment.
11372         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11373         initializations.
11374         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11375
11376 2019-01-10  Tom Tromey  <tom@tromey.com>
11377
11378         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11379         Don't declare.
11380         * mipsread.c: Include mdebugread.h.
11381         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11382         Declare.
11383         * elfread.c: Include mdebugread.h.
11384
11385 2019-01-09  Tom Tromey  <tom@tromey.com>
11386
11387         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11388         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11389         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11390         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11391         (psym_lookup_symbol, psym_find_last_source_symtab)
11392         (psym_forget_cached_source_info, psym_print_stats)
11393         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11394         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11395         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11396         (psym_find_compunit_symtab_by_address)
11397         (maintenance_print_psymbols, maintenance_info_psymtabs)
11398         (maintenance_check_psymtabs): Use ranged for.
11399         * psymtab.h (class objfile_psymtabs): New.
11400         (require_partial_symbols): Return objfile_psymtabs.
11401         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11402
11403 2019-01-09  Tom Tromey  <tom@tromey.com>
11404
11405         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11406         (find_pc_mapped_section, list_overlays_command)
11407         (map_overlay_command, unmap_overlay_command)
11408         (simple_overlay_update): Use all_objfiles.
11409         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11410         * printcmd.c (info_symbol_command): Use all_objfiles.
11411         * objfiles.h (ALL_OBJSECTIONS): Remove.
11412         * maint.c (maintenance_translate_address): Use all_objfiles.
11413         * gcore.c (gcore_create_callback): Use all_objfiles.
11414         (objfile_find_memory_regions): Likewise.
11415
11416 2019-01-09  Tom Tromey  <tom@tromey.com>
11417
11418         * symtab.c (find_line_symtab, info_sources_command)
11419         (make_source_files_completion_list): Use objfile_compunits.
11420         * source.c (select_source_symtab): Use objfile_compunits.
11421         * objfiles.h (struct objfile): Update comment.
11422         (ALL_OBJFILES): Remove.
11423         (ALL_FILETABS): Remove.
11424         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11425         objfile_compunits.
11426
11427 2019-01-09  Tom Tromey  <tom@tromey.com>
11428
11429         * symmisc.c (print_objfile_statistics, dump_objfile)
11430         (maintenance_print_symbols): Use compunit_filetabs.
11431         * source.c (forget_cached_source_info_for_objfile): Use
11432         compunit_filetabs.
11433         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11434         (ALL_FILETABS): Use compunit_filetabs.
11435         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11436         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11437
11438 2019-01-09  Tom Tromey  <tom@tromey.com>
11439
11440         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11441         (compunit_filetabs): New.
11442         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11443         compunit_filetabs.
11444         (info_sources_command, make_source_files_completion_list): Remove
11445         declaration.
11446         * symmisc.c (print_objfile_statistics, dump_objfile)
11447         (maintenance_print_symbols): Remove declaration.
11448         (maintenance_info_symtabs): Use compunit_filetabs.
11449         (maintenance_info_line_tables): Likewise.
11450         * source.c (select_source_symtab): Change local variable name.
11451         (forget_cached_source_info_for_objfile): Remove declaration.
11452         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11453         * objfiles.c (objfile_relocate1): Remove declaration.
11454         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11455         declaration.
11456         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11457         * coffread.c (coff_symtab_read): Remove declaration.
11458         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11459         compunit_filetabs.
11460
11461 2019-01-09  Tom Tromey  <tom@tromey.com>
11462
11463         * symtab.c (lookup_objfile_from_block)
11464         (find_pc_sect_compunit_symtab, search_symbols)
11465         (default_collect_symbol_completion_matches_break_on): Use
11466         objfile_compunits.
11467         * objfiles.h (ALL_COMPUNITS): Remove.
11468         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11469         * cp-support.c (add_symbol_overload_list_qualified): Use
11470         objfile_compunits.
11471         * ada-lang.c (ada_collect_symbol_completion_matches)
11472         (ada_add_global_exceptions): Use objfile_compunits.
11473
11474 2019-01-09  Tom Tromey  <tom@tromey.com>
11475
11476         * source.c (select_source_symtab)
11477         (forget_cached_source_info_for_objfile): Remove declaration.
11478         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11479         declaration.
11480         * maint.c (count_symtabs_and_blocks): Remove declaration.
11481         * cp-support.c (add_symbol_overload_list_qualified): Remove
11482         declaration.
11483         * coffread.c (coff_symtab_read): Remove declaration.
11484         * symtab.c (lookup_symbol_in_objfile_symtabs)
11485         (basic_lookup_transparent_type_1): Use objfile_compunits.
11486         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11487         (info_sources_command, search_symbols)
11488         (default_collect_symbol_completion_matches_break_on)
11489         (make_source_files_completion_list): Remove declaration.
11490         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11491         (ada_collect_symbol_completion_matches)
11492         (ada_add_global_exceptions): Remove declaration.
11493         * linespec.c (iterate_over_all_matching_symtabs): Use
11494         objfile_compunits.
11495         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11496         (class objfile_compunits): New.
11497         (ALL_COMPUNITS): Use objfile_compunits.
11498         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11499         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11500         objfile_compunits.
11501         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11502
11503 2019-01-09  Tom Tromey  <tom@tromey.com>
11504
11505         * symtab.c (search_symbols)
11506         (default_collect_symbol_completion_matches_break_on): Use
11507         objfile_msymbols.
11508         * ada-lang.c (ada_lookup_simple_minsym)
11509         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11510         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11511         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11512         objfile_msymbols.
11513         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11514         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11515         * objc-lang.c (find_methods): Use objfile_msymbols.
11516         (info_selectors_command, info_classes_command): Likewise.
11517         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11518         * objfiles.h (class objfile_msymbols): New.
11519         (ALL_OBJFILE_MSYMBOLS): Remove.
11520         (ALL_MSYMBOLS): Remove.
11521
11522 2019-01-09  Tom Tromey  <tom@tromey.com>
11523
11524         * common/next-iterator.h (next_adapter): Add Iterator template
11525         parameter.
11526         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11527         (class all_objfiles_safe): New.
11528         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11529         * objfiles.c (put_objfile_before): Update comment.
11530         (add_separate_debug_objfile): Likewise.
11531         (free_all_objfiles): Use all_objfiles_safe.
11532         (objfile_purge_solibs): Likewise.
11533
11534 2019-01-09  Tom Tromey  <tom@tromey.com>
11535
11536         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11537         (expand_symtab_containing_pc, lookup_static_symbol)
11538         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11539         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11540         all_objfiles.
11541         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11542         * breakpoint.c (create_overlay_event_breakpoint)
11543         (create_longjmp_master_breakpoint)
11544         (create_std_terminate_master_breakpoint)
11545         (create_exception_master_breakpoint): Use all_objfiles.
11546         * linux-thread-db.c (try_thread_db_load_from_pdir)
11547         (has_libpthread): Use all_objfiles.
11548         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11549         * linespec.c (iterate_over_all_matching_symtabs)
11550         (search_minsyms_for_name): Use all_objfiles.
11551         * maint.c (maintenance_info_sections): Use all_objfiles.
11552         * main.c (captured_main_1): Use all_objfiles.
11553         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11554         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11555         * guile/scm-pretty-print.c
11556         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11557         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11558         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11559         (maintenance_print_msymbols): Use all_objfiles.
11560         * source.c (select_source_symtab): Use all_objfiles.
11561         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11562         * symfile.c (remove_symbol_file_command)
11563         (expand_symtabs_matching, map_symbol_filenames): Use
11564         all_objfiles.
11565         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11566         all_objfiles.
11567         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11568         * objc-lang.c (find_methods): Use all_objfiles.
11569         * objfiles.c (have_partial_symbols, have_full_symbols)
11570         (have_minimal_symbols, qsort_cmp)
11571         (default_iterate_over_objfiles_in_search_order): Use
11572         all_objfiles.
11573         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11574         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11575         (maintenance_check_psymtabs): Use all_objfiles.
11576         (ALL_PSYMTABS): Remove.
11577         * compile/compile-object-run.c (do_module_cleanup): Use
11578         all_objfiles.
11579         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11580         * cp-support.c (add_symbol_overload_list_qualified): Use
11581         all_objfiles.
11582         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11583         Use all_objfiles.
11584         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11585         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11586         all_objfiles.
11587         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11588         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11589         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11590         Uses all_objfiles.
11591         * solib.c (solib_read_symbols): Use all_objfiles
11592
11593 2019-01-09  Tom Tromey  <tom@tromey.com>
11594
11595         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11596         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11597         all_objfiles.
11598         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11599         * symmisc.c (print_symbol_bcache_statistics)
11600         (print_objfile_statistics, maintenance_print_objfiles)
11601         (maintenance_info_symtabs, maintenance_check_symtabs)
11602         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11603         all_objfiles.
11604         * source.c (forget_cached_source_info): Use all_objfiles.
11605         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11606         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11607         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11608         * objfiles.c (update_section_map): Use all_objfiles.
11609         (shared_objfile_contains_address_p): Likewise.
11610         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11611         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11612
11613 2019-01-09  Tom Tromey  <tom@tromey.com>
11614
11615         * common/next-iterator.h: New file.
11616         * objfiles.h (class all_objfiles): New.
11617         (struct objfile_iterator): New.
11618
11619 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11620
11621         * NEWS: Move the description of the changed "frame", "select-frame",
11622          and "info frame" commands to the Changed commands section.
11623
11624 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11625
11626         * gdbtypes.c (check_stub_method_group): Remove handling of old
11627         mangling schemes.
11628         * linespec.c (find_methods): Likewise.
11629         * stabsread.c (read_member_functions): Likewise.
11630         * valops.c (search_struct_method): Likewise.
11631         (value_struct_elt_for_reference): Likewise.
11632         * NEWS: Mention this change.
11633
11634 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11635
11636         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11637         print_source_lines.
11638         * source.c (print_source_lines_base): Update line number check.
11639         (print_source_lines): New function.
11640         (source_lines_range::source_lines_range): New function.
11641         * source.h (class source_lines_range): New class.
11642         (print_source_lines): New declaration.
11643
11644 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11645
11646         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11647
11648 2019-01-08  Tom Tromey  <tom@tromey.com>
11649             Simon Marchi  <simon.marchi@ericsson.com>
11650
11651         PR gdb/24060
11652         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11653         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11654         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11655         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11656         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11657         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11658
11659 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11660
11661         * source.c (select_source_symtab): Move header comment to
11662         declaration in source.h.
11663         (forget_cached_source_info_for_objfile): Likewise.
11664         (forget_cached_source_info): Likewise.
11665         (identify_source_line): Likewise.
11666         * source.h (identify_source_line): Move declaration from symtab.h
11667         and add comment from source.c
11668         (print_source_lines): Likewise.
11669         (forget_cached_source_info_for_objfile): Likewise.
11670         (forget_cached_source_info): Likewise.
11671         (select_source_symtab): Likewise.
11672         (enum print_source_lines_flag): Move definition from symtab.h.
11673         * symtab.h (identify_source_line): Move declaration to source.h.
11674         (print_source_lines): Likewise.
11675         (forget_cached_source_info_for_objfile): Likewise.
11676         (forget_cached_source_info): Likewise.
11677         (select_source_symtab): Likewise.
11678         (enum print_source_lines_flag): Move definition to source.h.
11679         * tui/tui-hooks.c: Add 'source.h' include.
11680
11681 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11682
11683         * source.c (print_source_lines_base): Handle requests to print
11684         reverse line number sequences, and guard against empty lines
11685         string.
11686
11687 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11688
11689         * source.c (print_source_lines_base): Fix skip of '\r' if next
11690         character is '\n'.
11691
11692 2019-01-06  Tom Tromey  <tom@tromey.com>
11693
11694         * c-exp.y (struct c_parse_state) <macro_original_text,
11695         expansion_obstack>: New member.
11696         (macro_original_text, expansion_obstack): Remove globals.
11697         (scan_macro_expansion, scanning_macro_expansion)
11698         (finished_macro_expansion): Update.
11699         (scan_macro_cleanup): Remove.
11700         (yylex, c_parse): Update.
11701
11702 2019-01-06  Tom Tromey  <tom@tromey.com>
11703
11704         * c-exp.y (struct c_parse_state) <strings>: New member.
11705         (operator_stoken): Update.
11706
11707 2019-01-06  Tom Tromey  <tom@tromey.com>
11708
11709         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11710         (union type_stack_elt) <typelist_val>: Now a pointer to
11711         std::vector.
11712         (type_stack_cleanup): Don't declare.
11713         (push_typelist): Update.
11714         * parse.c (pop_typelist): Return a std::vector.
11715         (push_typelist): Take a std::vector.
11716         (follow_types): Update.  Do not free args.
11717         (type_stack_cleanup): Remove.
11718         * c-exp.y (struct c_parse_state): New.
11719         (cpstate): New global.
11720         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11721         (nonempty_typelist): Update.
11722         (func_mod): Create a new vector.
11723         (c_parse): Create a c_parse_state.
11724         (check_parameter_typelist): Do not delete params.
11725         (function_method): Update.  Do not delete type_list.
11726
11727 2019-01-06  Tom Tromey  <tom@tromey.com>
11728
11729         PR gdb/28155:
11730         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11731         check_typedef.
11732         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11733         (print_return_value): Likewise.
11734
11735 2019-01-05  Tom Tromey  <tom@tromey.com>
11736
11737         * contrib/cleanup_check.py: Remove.
11738         * contrib/gcc-with-excheck: Remove.
11739         * contrib/exsummary.py: Remove.
11740         * contrib/excheck.py: Remove.
11741
11742 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11743
11744         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11745         NULL. Initialize tpprev to NULL instead of assigning it
11746         to NULL on the next statement.
11747         * windows-nat.c (windows_delete_thread): Remove check for
11748         main_thread_id before printing thread exit notifications.
11749         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11750         Remove thread ID check against main_thread_id.
11751         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11752         windows_delete_thread.
11753         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11754
11755 2019-01-04  Tom Tromey  <tom@tromey.com>
11756
11757         * compile/compile.c (_initialize_compile): Use upper case for
11758         metasyntactic variables.
11759         * symmisc.c (_initialize_symmisc): Use upper case for
11760         metasyntactic variables.
11761         * psymtab.c (_initialize_psymtab): Use upper case for
11762         metasyntactic variables.
11763         * demangle.c (demangle_command): Use upper case for metasyntactic
11764         variables.
11765         (_initialize_demangler): Likewise.
11766         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11767         variables.
11768
11769 2019-01-03  Tom Tromey  <tom@tromey.com>
11770
11771         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11772
11773 2019-01-03  Tom Tromey  <tom@tromey.com>
11774
11775         * python/py-symtab.c (salpy_str): Update.
11776         (struct salpy_sal_object) <symtab>: Now a PyObject.
11777         (salpy_dealloc): Update.
11778         (del_objfile_sal): Use gdbpy_ref.
11779
11780 2019-01-03  Tom Tromey  <tom@tromey.com>
11781
11782         * python/py-type.c (convert_field): Use new_reference.  Return
11783         gdbpy_ref.
11784         (make_fielditem): Return gdbpy_ref.
11785         (typy_fields): Update.
11786         (typy_getitem): Update.
11787         (field_name): Return gdbpy_ref.  Use new_reference.
11788         (typy_iterator_iternext): Update.
11789
11790 2019-01-03  Tom Tromey  <tom@tromey.com>
11791
11792         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11793
11794 2019-01-03  Tom Tromey  <tom@tromey.com>
11795
11796         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11797         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11798         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11799         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11800         (pspy_set_type_printers): Likewise.
11801         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11802         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11803         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11804         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11805         (objfpy_set_type_printers): Likewise.
11806
11807 2019-01-03  Tom Tromey  <tom@tromey.com>
11808
11809         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11810         (gdbpy_print_stack): Use gdbpy_err_fetch.
11811         * python/python-internal.h (class gdbpy_err_fetch): New class.
11812         (class gdbpy_enter) <m_error_type, m_error_value,
11813         m_error_traceback>: Remove.
11814         <m_error>: New member.
11815         (gdbpy_exception_to_string): Don't declare.
11816         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11817         * python/py-value.c (convert_value_from_python): Use
11818         gdbpy_err_fetch.
11819         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11820         gdbpy_exception_to_string.
11821         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11822         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11823         gdbpy_err_fetch.
11824
11825 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11826
11827         * linux-nat.c (delete_lwp_cleanup): Delete.
11828         (struct lwp_deleter): New struct.
11829         (lwp_info_up): New typedef.
11830         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11831         lwp_info_up.
11832
11833 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11834
11835         * linux-fork.c (class scoped_switch_fork_info): New class.
11836         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11837
11838 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11839
11840         * valops.c (find_overload_match): Remove use of null_cleanup, and
11841         calls to do_cleanups.
11842
11843 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11844
11845         * compile/compile-cplus-types.c
11846         (compile_cplus_instance::decl_name): Handle changes to
11847         cp_func_name.
11848         * cp-support.c (cp_func_name): Update header comment, update
11849         return type.
11850         * cp-support.h (cp_func_name): Update return type in declaration.
11851         * valops.c (find_overload_match): Move temp_func local to top
11852         level of function and change its type.  Use temp_func to hold and
11853         delete temporary string obtained from cp_func_name.
11854
11855 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11856
11857         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11858         gdb::char_vector, remove cleanup, and update uses of `msg`.
11859
11860 2019-01-03  Jim Wilson  <jimw@sifive.com>
11861
11862         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11863
11864 2019-01-02  Tom Tromey  <tom@tromey.com>
11865
11866         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11867         (tdesc_parse_xml): Remove cleanups.
11868         * target-descriptions.h (make_cleanup_free_target_description):
11869         Don't declare.
11870         (target_desc_deleter): New struct.
11871         (target_desc_up): New typedef.
11872         * target-descriptions.c (target_desc_deleter::operator()): Rename
11873         from free_target_description.
11874         (make_cleanup_free_target_description): Remove.
11875
11876 2019-01-02  Tom Tromey  <tom@tromey.com>
11877
11878         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11879         constructor, destructor.
11880         (linespec_parser): Remove typedef.
11881         (~linespec_parser): Rename from linespec_parser_delete.
11882         (linespec_lex_to_end, linespec_complete_label)
11883         (linespec_complete): Update.
11884         (decode_line_full): Remove cleanups.
11885         (decode_line_1): Update.
11886
11887 2019-01-02  Tom Tromey  <tom@tromey.com>
11888
11889         * python/python-internal.h (inferior_to_inferior_object): Change
11890         return type.
11891         * python/py-exitedevent.c (create_exited_event_object): Update.
11892         * python/py-inferior.c (inferior_to_inferior_object): Return
11893         gdbpy_ref.
11894         (python_new_inferior, python_inferior_deleted)
11895         (thread_to_thread_object, delete_thread_object)
11896         (build_inferior_list, gdbpy_selected_inferior): Update.
11897         * python/py-infthread.c (create_thread_object): Update.  Also fail
11898         if inferior_to_inferior_object fails.
11899
11900 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11901
11902         * inferior.h (class inferior) <displaced_step_state>: New field.
11903         * infrun.h (struct displaced_step_state): Move here from
11904         infrun.c.  Initialize fields, add constructor.
11905         <inf>: Remove field.
11906         <reset>: New method.
11907         * infrun.c (struct displaced_step_inferior_state): Move to
11908         infrun.h.
11909         (displaced_step_inferior_states): Remove.
11910         (get_displaced_stepping_state): Adust.
11911         (displaced_step_in_progress_any_inferior): Adjust.
11912         (displaced_step_in_progress_thread): Adjust.
11913         (displaced_step_in_progress): Adjust.
11914         (add_displaced_stepping_state): Remove.
11915         (get_displaced_step_closure_by_addr): Adjust.
11916         (remove_displaced_stepping_state): Remove.
11917         (infrun_inferior_exit): Call displaced_step_state.reset.
11918         (use_displaced_stepping): Don't check for NULL.
11919         (displaced_step_prepare_throw): Call
11920         get_displaced_stepping_state.
11921         (displaced_step_fixup): Don't check for NULL.
11922         (prepare_for_detach): Don't check for NULL.
11923
11924 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11925
11926         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11927          in case of call that did not complete.
11928
11929 2019-01-02  Andrey Utkin  <autkin@undo.io>
11930
11931         * symfile.c (find_separate_debug_file): Fix search of debug files for
11932         remote debuggee.
11933
11934 2019-01-02  Tom Tromey  <tom@tromey.com>
11935
11936         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11937         indentation.
11938         * python/py-frame.c (frapy_older): Remove cast.
11939         (frapy_newer): Likewise.
11940         * python/py-breakpoint.c (local_setattro): Remove cast.
11941         * python/py-arch.c (archpy_name): Remove local variable.
11942         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11943
11944 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11945
11946         * unittests/basic_string_view/element_access/char/empty.cc:
11947         Fix year range in copyright header.
11948
11949 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11950
11951         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11952         Delete.
11953         <operator==>: Update with for removed field.
11954         <hash>: Likewise.
11955         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11956         <isa_features>: ...this.
11957         <abi_features>: New field.
11958         (riscv_isa_flen): Update comment.
11959         (riscv_abi_xlen): New declaration.
11960         (riscv_abi_flen): New declaration.
11961         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11962         isa_features.
11963         (riscv_abi_xlen): New function.
11964         (riscv_isa_flen): Update to get answer from isa_features.
11965         (riscv_abi_flen): New function.
11966         (riscv_has_fp_abi): Update to get answer from abi_features.
11967         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11968         xlen and flen.
11969         (riscv_call_info) <xlen, flen>: Update comment.
11970         (riscv_call_arg_struct): Remove invalid assertions
11971         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11972         is removed.
11973         (riscv_gdbarch_init): Gather isa features and abi features
11974         separately, ensure both match on the gdbarch when reusing an old
11975         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11976         a target with 64-bit float hardware.
11977
11978 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11979
11980         * source.c (search_command_helper): Stop reverse search
11981         when line 1 has been searched.
11982
11983 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11984
11985         * record-full.c (record_full_base_target::close): Rewrite
11986         record_full_core_buf_list free logic.
11987
11988 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11989
11990         * break-catch-syscall.c (print_one_catch_syscall): xfree
11991         the last text.
11992
11993 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11994
11995         * top.c (print_gdb_version): Update Copyright year in version
11996         message.
11997
11998 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11999
12000         Update copyright year range in all GDB files.
12001
12002 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12003
12004         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12005
12006 For older changes see ChangeLog-2018.
12007 \f
12008 Local Variables:
12009 mode: change-log
12010 left-margin: 8
12011 fill-column: 74
12012 version-control: never
12013 coding: utf-8
12014 End:
12015