gdb/ChangeLog

   1 2019-08-30  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-regs.c (tui_data_window::display_all_data): Change
   4         text.
   5         * tui/tui-data.h (NO_DATA_STRING): Remove define.
   6
   7 2019-08-29  Bernhard Wodok  <barto@gmx.net>
   8             Sergio Durigan Junior  <sergiodj@redhat.com>
   9
  10         PR win32/24284
  11         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
  12
  13 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  14
  15         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
  16         when searching for types.
  17
  18 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
  19
  20         * f-lang.c (f_language_defn): Use f_print_typedef.
  21         * f-lang.h (f_print_typedef): Declare.
  22         * f-typeprint.c (f_print_typedef): Define.
  23
  24 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
  25
  26         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
  27
  28 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  29
  30         * cli/cli-utils.c (info_print_options_defs): Delete.
  31         (make_info_print_options_def_group): Delete.
  32         (extract_info_print_options): Delete.
  33         (info_print_command_completer): Delete.
  34         (info_print_args_help): Add extra parameter, and optionally
  35         include text about -n flag.
  36         * cli/cli-utils.h (struct info_print_options): Delete.
  37         (extract_info_print_options): Delete declaration.
  38         (info_print_command_completer): Delete declaration.
  39         (info_print_args_help): Add extra parameter, extend header
  40         comment.
  41         * python/python.c (gdbpy_rbreak): Pass additional parameter to
  42         search_symbols.
  43         * stack.c (struct info_print_options): New type.
  44         (info_print_options_defs): New file scoped variable.
  45         (make_info_print_options_def_group): New static function.
  46         (info_print_command_completer): New static function.
  47         (info_locals_command): Update to use new local functions.
  48         (info_args_command): Likewise.
  49         (_initialize_stack): Add extra parameter to calls to
  50         info_print_args_help.
  51         * symtab.c (search_symbols): Add extra parameter, use this to
  52         possibly excluse non-debug symbols.
  53         (symtab_symbol_info): Add extra parameter, which is passed on to
  54         search_symbols.
  55         (struct info_print_options): New type.
  56         (info_print_options_defs): New file scoped variable.
  57         (make_info_print_options_def_group): New static function.
  58         (info_print_command_completer): New static function.
  59         (info_variables_command): Update to use local functions, and pass
  60         extra parameter through to symtab_symbol_info.
  61         (info_functions_command): Likewise.
  62         (info_types_command): Pass additional argument through to
  63         symtab_symbol_info.
  64         (rbreak_command): Pass extra argument to search_symbols.
  65         (_initialize_symtab): Add extra arguments for calls to
  66         info_print_args_help, and update help text for 'info variables',
  67         'whereis', and 'info functions' commands.
  68         * symtab.h (search_symbols): Add extra argument to declaration.
  69         * NEWS: Mention new flags.
  70
  71 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
  72
  73         * symtab.c (lookup_static_symbol): Call the new function (and move
  74         it down to be next to lookup_global_symbol).
  75         (struct global_sym_lookup_data): Add block_enum member and rename to...
  76         (struct global_or_static_sym_lookup_data): ...this.
  77         (lookup_symbol_global_iterator_cb): Pass block_index instead of
  78         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
  79         (lookup_symbol_global_or_static_iterator_cb): ...this.
  80         (lookup_global_or_static_symbol): New function.
  81         (lookup_global_symbol): Call new function.
  82
  83 2019-08-26  Tom de Vries  <tdevries@suse.de>
  84
  85         PR c++/24852
  86         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
  87         when pc_probe.prob == NULL.
  88
  89 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  90
  91         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
  92         variable symbol_linkage to symbol_linkage_.
  93
  94 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
  95
  96         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
  97         represent whether the symbol is static, dynamic, or we don't
  98         know.
  99
 100 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 101
 102         * gdb/rx-tdep.c (rx_register_names): New.
 103         (rx_register_name): Delete.
 104         (rx_psw_type): Delete.
 105         (rx_fpsw_type): Delete.
 106         (rx_register_type): Delete.
 107         (rx_gdbarch_init): Convert target-descriptions.
 108         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 109         * gdb/features/Makefile: Add rx.xml.
 110         * gdb/features/rx.xml: New.
 111         * gdb/features/rx.c: Generated.
 112         * gdb/NEWS: Mention target description support.
 113
 114 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 115
 116         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 117         *slot_ptr.
 118
 119 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 120
 121         * configure.ac: Don't check for 'dlfcn.h' (moved to
 122         gdbsupport/common.m4).
 123         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 124         'gdbsupport/'.
 125         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 126         * compile/compile-c-support.c: Include
 127         'gdbsupport/gdb-dlfcn.h'.
 128         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 129         * gdb-dlfcn.c: Move to...
 130         * gdbsupport/gdb-dlfcn.c: ... here.
 131         * gdb-dlfcn.h: Move to...
 132         * gdbsupport/gdb-dlfcn.h: ... here.
 133
 134 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 135
 136         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 137         the offset field signed.
 138
 139 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 140
 141         * python/lib/gdb/__init__.py (_execute_file): New function.
 142         * python/python.c (python_run_simple_file): Call gdb._execute_file
 143         on Windows.
 144
 145 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 146
 147         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 148         all uses as this was never set to anything but a zero value.
 149
 150 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 151
 152         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 153
 154 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 155
 156         * tui/tui-data.h (tui_gen_win_info): Add an =default
 157         move constructor, required by some GCC versions.
 158
 159 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 160
 161         * go32-nat.c (go32_sysinfo): Add hygon_p.
 162
 163 2019-08-20  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 166         line_from_reg_element_no, first_reg_element_no_inline,
 167         display_all_data, delete_data_content_windows,
 168         erase_data_content>: Now private.
 169
 170 2019-08-20  Tom Tromey  <tom@tromey.com>
 171
 172         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 173         (tui_unhighlight_win, tui_highlight_win)
 174         (tui_win_info::make_window): Update.
 175         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 176
 177 2019-08-20  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 180         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 181         (MAX_PID_WIDTH): Move to tui-stack.c.
 182         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 183         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 184         (MAX_PID_WIDTH): Move from tui-data.h.
 185
 186 2019-08-20  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 189         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 190         (box_win): Update.
 191         (tui_gen_win_info::make_window): Rename from tui_make_window.
 192         (tui_win_info::make_window): New method.
 193         (tui_gen_win_info::make_visible): Update.
 194         * tui/tui-source.c (tui_source_window::set_contents): Update.
 195         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 196         (tui_data_window::display_registers_from): Update.
 197         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 198         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 199         Declare.
 200         <can_box>: Remove.
 201         <title>: Remove.
 202         (struct tui_win_info) <make_window>: Declare.
 203         <can_box>: Now virtual.
 204         <title>: New member.
 205         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 206         * tui/tui-command.c (tui_cmd_window::resize): Update.
 207
 208 2019-08-20  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 211         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 212         (tui_data_window::check_register_values): Update.
 213
 214 2019-08-20  Tom Tromey  <tom@tromey.com>
 215
 216         * tui/tui-regs.h (struct tui_data_window): Use
 217         DISABLE_COPY_AND_ASSIGN.
 218         <regs_content>: Change type, removing unique_ptr.
 219         <tui_data_window>: Add move constructor.
 220         * tui/tui-regs.c (tui_data_window::show_registers)
 221         (tui_data_window::show_register_group)
 222         (tui_data_window::display_registers_from)
 223         (tui_data_window::display_registers_from)
 224         (tui_data_window::first_data_item_displayed)
 225         (tui_data_window::delete_data_content_windows)
 226         (tui_data_window::rerender, tui_data_window::refresh_window)
 227         (tui_data_window::check_register_values): Update.
 228
 229 2019-08-20  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 232         show_register_group>: Declare.
 233         (tui_show_register_group): Don't declare.
 234         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 235         tui_show_registers.
 236         (tui_data_window::show_register_group): Rename from
 237         tui_show_register_group.
 238         (tui_data_window::check_register_values, tui_reg_command):
 239         Update.
 240         * tui/tui-layout.c (tui_set_layout): Update.
 241
 242 2019-08-20  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 245         Declare.
 246         (tui_check_register_values): Don't declare.
 247         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 248         from tui_check_register_values.
 249         * tui/tui-hooks.c (tui_register_changed): Update.
 250
 251 2019-08-20  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-regs.c (tui_reg_layout): Move later.
 254         (tui_show_registers): Don't enable TUI mode or change layout.
 255
 256 2019-08-20  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-regs.h (struct tui_data_item_window)
 259         <~tui_data_item_window>: Remove.
 260         <content>: Now a unique_xmalloc_ptr.
 261         * tui/tui-regs.c (tui_register_format): Return a
 262         unique_xmalloc_ptr.
 263         (tui_get_register): Update.
 264         (~tui_data_item_window): Remove.
 265         (tui_data_window::display_registers_from, tui_display_register):
 266         Update.
 267         * tui/tui-io.h (tui_expand_tabs): Update.
 268         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 269         Remove "col" parameter.
 270
 271 2019-08-20  Tom Tromey  <tom@tromey.com>
 272
 273         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 274         field.
 275         * tui/tui-regs.c (~tui_data_item_window): Update.
 276
 277 2019-08-20  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 280         earlier.
 281
 282 2019-08-20  Tom Tromey  <tom@tromey.com>
 283
 284         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 285
 286 2019-08-20  Tom Tromey  <tom@tromey.com>
 287
 288         * tui/tui-source.h (struct tui_source_window): Update.
 289         * tui/tui-regs.c (tui_show_registers): Update.
 290         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 291         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 292         (NO_REGS_STRING): Remove defines.
 293
 294 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 295
 296         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 297         unnecessary thread walk if remote doesn't support the packet.
 298
 299 2019-08-19  Tom Tromey  <tromey@adacore.com>
 300
 301         * python/py-value.c (value_has_field): Fix indentation.
 302
 303 2019-08-19  Tom Tromey  <tromey@adacore.com>
 304
 305         * printcmd.c (do_one_display, info_display_command): Update.
 306         * block.h (contained_in): Return bool.  Add allow_nested
 307         parameter.
 308         * block.c (contained_in): Return bool.  Add allow_nested
 309         parameter.
 310
 311 2019-08-19  Tom Tromey  <tom@tromey.com>
 312
 313         * configure: Rebuild.
 314         * configure.ac: Disallow the combination of -static-libstdc++ and
 315         source highlight.
 316         * source-cache.c (get_language_name): Handle rust.
 317         (source_cache::get_source_lines): Ignore highlighting exceptions.
 318
 319 2019-08-16  Tom Tromey  <tom@tromey.com>
 320
 321         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 322         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 323         (struct tui_source_window_base) <make_visible, refresh_window,
 324         resize>: Remove methods.
 325         <execution_info>: Remove field.
 326         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 327         (tui_show_source_line, tui_source_window_base)
 328         (~tui_source_window_base): Update.
 329         (tui_source_window_base::resize)
 330         (tui_source_window_base::make_visible)
 331         (tui_source_window_base::refresh_window): Remove.
 332         (tui_source_window_base::update_exec_info): Update.
 333         * tui/tui-source.c (tui_source_window::set_contents): Update.
 334         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 335
 336 2019-08-16  Tom Tromey  <tom@tromey.com>
 337
 338         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 339         deprecated_query_hook.
 340
 341 2019-08-16  Tom Tromey  <tom@tromey.com>
 342
 343         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 344         (tui_update_source_windows_with_line): Update.
 345         * tui/tui-source.h (struct tui_source_window)
 346         <show_symtab_source>: Declare.
 347         (tui_show_symtab_source): Don't declare.
 348         * tui/tui-source.c (tui_show_symtab_source): Rename from
 349         tui_show_symtab_source.
 350
 351 2019-08-16  Tom Tromey  <tom@tromey.com>
 352
 353         * tui/tui-winsource.h (struct tui_source_window_base)
 354         <set_contents>: Declare.
 355         * tui/tui-winsource.c
 356         (tui_source_window_base::update_source_window_as_is): Update.
 357         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 358         Declare.
 359         (tui_set_source_content): Don't declare.
 360         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 361         tui_set_source_content.
 362         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 363         Declare.
 364         (tui_set_disassem_content): Don't declare.
 365         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 366         tui_set_disassem_content.
 367
 368 2019-08-16  Tom Tromey  <tom@tromey.com>
 369
 370         * tui/tui-winsource.h (struct tui_source_window_base)
 371         <update_breakpoint_info>: Declare.
 372         (tui_update_breakpoint_info): Don't declare.
 373         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 374         (tui_update_all_breakpoint_info): Update.
 375         (tui_source_window_base::update_breakpoint_info): Rename from
 376         tui_update_breakpoint_info.
 377         (tui_source_window_base::update_exec_info): Update.
 378
 379 2019-08-16  Tom Tromey  <tom@tromey.com>
 380
 381         * tui/tui-winsource.h (struct tui_source_window_base)
 382         <update_source_window>: Declare.
 383         (tui_update_source_window): Don't declare.
 384         * tui/tui-winsource.c
 385         (tui_source_window_base::update_source_window): Rename from
 386         tui_update_source_window.
 387         (tui_source_window_base::rerender): Update.
 388         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 389         * tui/tui-disasm.c (tui_show_disassem)
 390         (tui_show_disassem_and_update_source)
 391         (tui_disasm_window::maybe_update): Update.
 392
 393 2019-08-16  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-winsource.h (struct tui_source_window_base)
 396         <update_source_window_as_is>: Declare.
 397         (tui_update_source_window_as_is): Don't declare.
 398         * tui/tui-winsource.c (tui_update_source_window): Update
 399         (tui_source_window_base::update_source_window_as_is): Rename from
 400         tui_update_source_window_as_is.
 401         (tui_source_window_base::refill): Update.
 402         * tui/tui-source.c (tui_show_symtab_source): Update.
 403         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 404         Update.
 405
 406 2019-08-16  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-winsource.h (tui_update_source_window)
 409         (tui_update_source_window_as_is): Remove "noerror" parameter.
 410         * tui/tui-winsource.c (tui_update_source_window)
 411         (tui_update_source_window_as_is): Remove "noerror" parameter.
 412         (tui_update_source_windows_with_addr)
 413         (tui_update_source_windows_with_line)
 414         (tui_source_window_base::rerender)
 415         (tui_source_window_base::refill): Update.
 416         * tui/tui-source.h (tui_set_source_content)
 417         (tui_show_symtab_source): Remove "noerror" parameter.
 418         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 419         parameter.
 420         (tui_show_symtab_source): Likewise.
 421         (tui_source_window::maybe_update): Update.
 422         * tui/tui-disasm.c (tui_show_disassem)
 423         (tui_show_disassem_and_update_source)
 424         (tui_disasm_window::do_scroll_vertical)
 425         (tui_disasm_window::maybe_update): Update.
 426
 427 2019-08-16  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui.c (tui_is_window_visible): Update.
 430         * tui/tui-wingeneral.c (tui_make_window)
 431         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 432         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 433         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 434         (tui_set_win_height_command, parse_scrolling_args): Update.
 435         * tui/tui-source.c (tui_source_window::style_changed): Update.
 436         * tui/tui-regs.c (tui_show_registers)
 437         (tui_data_window::first_data_item_displayed)
 438         (tui_data_window::delete_data_content_windows)
 439         (tui_check_register_values, tui_reg_command): Update.
 440         * tui/tui-disasm.c (tui_show_disassem): Update.
 441         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 442         method.
 443         <is_visible>: Remove field.
 444         * tui/tui-data.c (tui_next_win, tui_prev_win)
 445         (tui_delete_invisible_windows): Update.
 446
 447 2019-08-16  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.h (struct tui_source_window_base)
 450         <m_has_locator>: Remove.
 451         * tui/tui-layout.c (show_source_disasm_command, show_data)
 452         (show_source_or_disasm_and_command): Update.
 453
 454 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 455
 456         * NEWS (Other MI changes): New subsection.
 457         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 458         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 459         * arch-utils.c (default_get_pc_address_flags): New function.
 460         * arch-utils.h (default_get_pc_address_flags): New declaration.
 461         * gdbarch.sh: Add get_pc_address_flags.
 462         * gdbarch.c: Regenerate.
 463         * gdbarch.h: Likewise.
 464         * stack.c (print_pc): New function.
 465         (print_frame_info) (print_frame): Call print_pc.
 466
 467 2019-08-16  Tom de Vries  <tdevries@suse.de>
 468
 469         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 470         print_objfile_section_info.
 471
 472 2019-08-15  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 475         calling update_cmdwin_start_line.
 476         * tui/tui-winsource.h (struct tui_source_window_base)
 477         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 478         <rerender>: Declare.
 479         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 480         Call rerender.
 481         (tui_source_window_base::set_new_height): Remove.
 482         (tui_source_window_base::rerender): Rename from
 483         do_make_visible_with_new_height.
 484         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 485         resize method.
 486         (tui_win_info::make_invisible_and_set_new_height)
 487         (tui_win_info::make_visible_with_new_height): Remove.
 488         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 489         Declare.
 490         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 491         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 492         do_make_visible_with_new_height>: Don't declare.
 493         <rerender>: Declare.
 494         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 495         set_new_height.
 496         (tui_data_window::do_make_visible_with_new_height): Remove.
 497         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 498         call tui_show_locator_content.
 499         (tui_gen_win_info::resize): Call rerender.
 500         (show_source_or_disasm_and_command): Don't call
 501         tui_show_locator_content.
 502         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 503         method.
 504         (struct tui_win_info) <rerender>: Declare.
 505         <set_new_height, make_invisible_and_set_new_height,
 506         make_visible_with_new_height>: Don't declare.
 507         * tui/tui-data.c (tui_win_list::rerender): New method.
 508         * tui/tui-command.h (struct tui_cmd_window)
 509         <do_make_visible_with_new_height>: Don't declare.
 510         * tui/tui-command.c
 511         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 512
 513 2019-08-15  Tom Tromey  <tromey@adacore.com>
 514
 515         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 516         * ada-lang.c (ada_enum_name): Likewise.
 517
 518 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 519
 520         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 521         leading underscore.
 522         (GdbOutputErrorFile): Likewise.
 523         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 524         accordingly.
 525         (execute_unwinders): Rename to have a leading underscore.
 526         (auto_load_packages): Likewise.
 527         (global scope): Adjust call to auto_load_packages accordingly.
 528         (GdbSetPythonDirectory): Likewise.
 529         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 530         instead of execute_unwinders.
 531
 532 2019-08-15  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 535         (show_data): Don't change window visibility.
 536         (tui_gen_win_info::resize): Remove special case for command
 537         window.  Use wresize, when available.
 538         (show_source_or_disasm_and_command): Don't change window
 539         visibility.
 540         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 541         <make_visible>: New method.
 542         * tui/tui-command.c (tui_cmd_window::resize): New method.
 543
 544 2019-08-15  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 547         (struct tui_source_windows): New.
 548         * tui/tui-winsource.c (tui_display_main): Update.
 549         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 550         (new_height_ok, parse_scrolling_args): Update.
 551         * tui/tui-layout.c (show_layout, show_data): Update.
 552         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 553         (tui_add_to_source_windows): Don't declare.
 554         * tui/tui-data.c (source_windows, tui_source_windows)
 555         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 556
 557 2019-08-15  Tom Tromey  <tom@tromey.com>
 558
 559         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 560         Rename from reset.
 561         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 562         * tui/tui-layout.c (show_source_disasm_command, show_data):
 563         Update.
 564         (tui_gen_win_info::resize): Rename.
 565         (show_source_or_disasm_and_command): Update.
 566         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 567         reset.
 568
 569 2019-08-15  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 572         * tui/tui-interp.c (tui_interp::init): Don't call
 573         tui_initialize_static_data.
 574         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 575
 576 2019-08-15  Tom Tromey  <tom@tromey.com>
 577
 578         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 579         examine tui_win_list.
 580
 581 2019-08-15  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 584         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 585         tui_clear_source_content.
 586         (tui_clear_source_content): Remove.
 587         (tui_source_window_base::do_erase_source_content): Hoist call to
 588         content.clear().
 589         * tui/tui-stack.c (tui_show_frame_info): Don't call
 590         tui_clear_source_content.
 591
 592 2019-08-15  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.h (struct tui_source_window_base)
 595         <do_erase_source_content>: New method.
 596         <erase_source_content>: New method.
 597         (tui_erase_source_content): Don't declare.
 598         * tui/tui-winsource.c (tui_clear_source_content): Update.
 599         (tui_source_window_base::do_erase_source_content): Rename from
 600         tui_erase_source_content.
 601         (tui_source_window_base::show_source_content): Update.
 602         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 603         * tui/tui-source.h (struct tui_source_window)
 604         <erase_source_content>: New method.
 605         * tui/tui-disasm.h (struct tui_disasm_window)
 606         <erase_source_content>: New method.
 607
 608 2019-08-15  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 611         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
 612         constructor.
 613         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
 614         * tui/tui-source.c (tui_set_source_content): Update.
 615         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 616
 617 2019-08-15  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
 620         * tui/tui-winsource.c (tui_line_is_displayed): Move to
 621         tui-source.c.
 622         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
 623         Declare.
 624         * tui/tui-source.c (tui_source_window::line_is_displayed): New
 625         method.
 626         (tui_source_window::maybe_update): Update.
 627
 628 2019-08-15  Tom Tromey  <tom@tromey.com>
 629
 630         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
 631         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
 632         tui-disasm.c.
 633         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
 634         Declare.
 635         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
 636         method.
 637         (tui_disasm_window::maybe_update): Update.
 638
 639 2019-08-15  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-winsource.h (struct tui_source_window_base)
 642         <maybe_update>: Declare.
 643         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
 644         method.
 645         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 646         Declare.
 647         * tui/tui-source.c (tui_source_window::maybe_update): New method.
 648         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 649         Declare.
 650         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
 651
 652 2019-08-15  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
 655
 656 2019-08-15  Tom Tromey  <tom@tromey.com>
 657
 658         * tui/tui-wingeneral.c: Include tui-stack.h.
 659         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
 660         (struct tui_locator_window): Move from tui-data.h.
 661         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
 662         (tui_initialize_static_data): Move from tui-data.c.
 663         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
 664         (struct tui_locator_window): Move to tui-stack.c.
 665         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
 666         (tui_initialize_static_data): Move to tui-stack.c.
 667
 668 2019-08-15  Tom Tromey  <tom@tromey.com>
 669
 670         * tui/tui-layout.c (show_source_disasm_command)
 671         (show_source_or_disasm_and_command): Use make_visible method, not
 672         tui_make_window.
 673         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
 674         Remove.
 675
 676 2019-08-15  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-wingeneral.h (tui_make_window): Update.
 679         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
 680         parameter.
 681         (tui_gen_win_info::make_visible): Update.
 682         * tui/tui-regs.c (tui_data_window::display_registers_from):
 683         Update.
 684         * tui/tui-layout.c (show_source_disasm_command)
 685         (show_source_or_disasm_and_command): Update.
 686         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 687         (enum tui_box): Remove.
 688         (struct tui_win_info) <can_box>: New method.
 689         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
 690         method.
 691
 692 2019-08-15  Tom de Vries  <tdevries@suse.de>
 693
 694         * linux-nat-trad.c: Include gdbarch.h.
 695
 696 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
 697
 698         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
 699         register sizes.
 700
 701 2019-08-14  Tom Tromey  <tromey@adacore.com>
 702
 703         * darwin-nat.c: Include gdbarch.h.
 704         * darwin-nat-info.c: Include gdbarch.h.
 705
 706 2019-08-13  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
 709         Remove.
 710         * tui/tui-data.c (tui_initialize_static_data): Update.
 711
 712 2019-08-13  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-winsource.h (struct tui_exec_info_window)
 715         <~tui_exec_info_window, maybe_allocate_content, get_content,
 716         m_content>: Remove.
 717         (struct tui_source_window_base) <set_exec_info_content,
 718         show_exec_info_content>: Don't declare.
 719         * tui/tui-winsource.c
 720         (tui_exec_info_window::maybe_allocate_content): Remove.
 721         (tui_source_window_base::update_exec_info): Rename from
 722         set_exec_info_content.
 723         (tui_source_window_base::show_exec_info_content)
 724         (tui_source_window_base::update_exec_info): Remove.
 725
 726 2019-08-13  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
 729         declare.
 730         * tui/tui-winsource.c (tui_update_source_window_as_is)
 731         (tui_update_source_windows_with_addr, tui_erase_source_content):
 732         Update.
 733         (tui_clear_exec_info_content): Remove.
 734
 735 2019-08-13  Tom Tromey  <tom@tromey.com>
 736
 737         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
 738         declare.
 739         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
 740         call tui_erase_exec_info_content.
 741         (tui_clear_exec_info_content): Rename from
 742         tui_erase_exec_info_content.
 743         (tui_clear_exec_info_content): Delete.
 744
 745 2019-08-13  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-winsource.h (struct tui_source_window_base)
 748         <show_exec_info_content>: Declare.
 749         (tui_show_exec_info_content): Don't declare.
 750         * tui/tui-winsource.c
 751         (tui_source_window_base::show_exec_info_content): Rename from
 752         tui_show_exec_info_content.
 753         (tui_source_window_base::update_exec_info): Update.
 754
 755 2019-08-13  Tom Tromey  <tom@tromey.com>
 756
 757         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
 758         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
 759         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
 760         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
 761         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
 762         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
 763         ... here.
 764
 765 2019-08-13  Tom Tromey  <tom@tromey.com>
 766
 767         * tui/tui-winsource.h (struct tui_source_window_base)
 768         <update_exec_info>: Declare.
 769         (tui_update_exec_info): Don't declare.
 770         * tui/tui-winsource.c (tui_update_source_window_as_is)
 771         (tui_source_window_base::refresh_all)
 772         (tui_update_all_breakpoint_info): Update.
 773         (tui_source_window_base::update_exec_info): Rename from
 774         tui_update_exec_info.
 775         * tui/tui-stack.c (tui_show_frame_info): Update.
 776
 777 2019-08-13  Tom Tromey  <tom@tromey.com>
 778
 779         * tui/tui-winsource.h (struct tui_source_window_base)
 780         <set_exec_info_content>: Declare.
 781         (tui_set_exec_info_content): Don't declare.
 782         * tui/tui-winsource.c
 783         (tui_source_window_base::set_exec_info_content): Rename from
 784         tui_set_exec_info_content.
 785         (tui_update_exec_info): Update.
 786
 787 2019-08-13  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-winsource.h (struct tui_source_window_base)
 790         <show_source_content>: Declare.
 791         (tui_show_source_content): Don't declare.
 792         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 793         (tui_source_window_base::show_source_content): Rename from
 794         tui_show_source_content.
 795         (tui_source_window_base::refresh_all): Update.
 796         * tui/tui-layout.c (show_source_disasm_command)
 797         (show_source_or_disasm_and_command): Update.
 798
 799 2019-08-13  Tom Tromey  <tom@tromey.com>
 800
 801         * tui/tui-winsource.c (tui_erase_source_content)
 802         (tui_show_source_content, tui_source_window_base::refresh_all):
 803         Update.
 804         * tui/tui-wingeneral.h
 805         (tui_check_and_display_highlight_if_needed): Don't declare.
 806         * tui/tui-wingeneral.c
 807         (tui_win_info::check_and_display_highlight_if_needed): Rename from
 808         check_and_display_highlight_if_needed.
 809         * tui/tui-win.c (tui_rehighlight_all)
 810         (tui_win_info::make_visible_with_new_height): Update.
 811         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 812         (tui_data_window::erase_data_content)
 813         (tui_data_window::display_all_data): Update.
 814         * tui/tui-data.h (struct tui_win_info)
 815         <check_and_display_highlight_if_needed>: Declare.
 816
 817 2019-08-13  Tom Tromey  <tom@tromey.com>
 818
 819         * tui/tui-win.c (tui_resize_all): Call
 820         tui_delete_invisible_windows.
 821         * tui/tui-layout.c (show_layout): Call
 822         tui_delete_invisible_windows.
 823         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
 824         * tui/tui-data.c (tui_delete_invisible_windows): New function.
 825
 826 2019-08-13  Tom Tromey  <tom@tromey.com>
 827
 828         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
 829         tui_add_win_to_layout.
 830
 831 2019-08-13  Tom Tromey  <tom@tromey.com>
 832
 833         * tui/tui-layout.h (tui_default_win_height): Don't declare.
 834         * tui/tui-layout.c (tui_default_win_height): Now static.
 835
 836 2019-08-13  Tom Tromey  <tom@tromey.com>
 837
 838         * tui/tui-layout.c (show_layout): Unify all layout cases into a
 839         single switch.
 840         (show_source_disasm_command, show_source_or_disasm_and_command):
 841         Don't check current layout.
 842
 843 2019-08-13  Tom Tromey  <tom@tromey.com>
 844
 845         * tui/tui-wingeneral.c (make_all_visible): Remove.
 846         (tui_make_all_invisible): Simplify.
 847         * tui/tui-layout.c (tui_make_all_invisible): Move from
 848         tui-wingeneral.c; simplify.
 849         (show_layout): Hoist call to tui_make_all_invisible.
 850         (show_data): Don't call tui_make_all_invisible.
 851
 852 2019-08-13  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
 855         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
 856
 857 2019-08-13  Tom Tromey  <tom@tromey.com>
 858
 859         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
 860         tui-data.c.
 861         (show_source_disasm_command, show_data)
 862         (show_source_or_disasm_and_command): Don't use
 863         tui_set_current_layout_to.
 864         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
 865         * tui/tui-data.c (current_layout, tui_current_layout): Move to
 866         tui-layout.c.
 867         (tui_set_current_layout_to): Remove.
 868
 869 2019-08-13  Tom Tromey  <tom@tromey.com>
 870
 871         * tui/tui-layout.c (tui_set_layout): Update.
 872         * tui/tui-data.h (struct tui_layout_def): Remove.
 873         (tui_layout_def): Don't declare.
 874         * tui/tui-data.c (layout_def): Remove.
 875         (tui_layout_def): Remove.
 876
 877 2019-08-13  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-winsource.h (struct tui_source_window_base)
 880         <clear_detail>: No longer "override".
 881         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
 882         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
 883         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
 884         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
 885         Remove.
 886         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
 887
 888 2019-08-13  Tom Tromey  <tromey@adacore.com>
 889
 890         * tracepoint.c: Don't include readline.h or history.h.
 891
 892 2019-08-12  Tom Tromey  <tom@tromey.com>
 893
 894         * configure: Rebuild.
 895         * configure.ac: Check for readline 7.
 896         * NEWS: Mention readline 7 requirement.
 897         * README: Update.
 898
 899 2019-08-12  Tom Tromey  <tom@tromey.com>
 900
 901         * mingw-hdep.c (gdb_select): Remove readline hack.
 902
 903 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 904
 905         * blockframe.c (find_pc_partial_function): Set *block to nullptr
 906         when the function fails.
 907
 908 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
 909
 910         * s390-tdep.c (s390_type_align): New function.
 911         (s390_gdbarch_init): Set it as type_align gdbarch method.
 912
 913 2019-08-09  Tom de Vries  <tdevries@suse.de>
 914
 915         PR gdb/24591
 916         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
 917         pc_low with relocation offset.
 918
 919 2019-08-07  Tom Tromey  <tromey@adacore.com>
 920
 921         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 922         (print_frame_args): Update.
 923         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
 924         Update.
 925         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 926         * frame.h (struct frame_arg): Add initializers.
 927         <error>: Now a unique_xmalloc_ptr.
 928
 929 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
 930
 931         * NEWS: Expand the Pointer Authentication entry.
 932         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
 933         (aarch64_frame_unmask_lr): ... to this.
 934         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
 935         Call aarch64_frame_unmask_lr.
 936         * frame.c (struct frame_info): Add "masked" variable.
 937         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
 938         (fprint_frame): Check for masked pc.
 939         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
 940         declarations.
 941         * python/py-framefilter.c (py_print_frame): Check for masked pc.
 942         * stack.c (print_frame): Check for masked pc.
 943
 944 2019-08-06  Tom Tromey  <tom@tromey.com>
 945
 946         * stabsread.c (patch_block_stabs, read_one_struct_field)
 947         (read_enum_type): Use obstack_strndup.
 948         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
 949         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
 950         * dwarf2read.c (guess_full_die_structure_name)
 951         (anonymous_struct_prefix): Use obstack_strndup.
 952         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
 953         * c-exp.y (yylex): Use obstack_strndup.
 954         * ada-exp.y (write_object_renaming, write_ambiguous_var)
 955         (write_var_or_type): Use obstack_strndup.
 956
 957 2019-08-06  Tom Tromey  <tom@tromey.com>
 958
 959         * symfile.c (reread_symbols): Use obstack_strdup.
 960         * stabsread.c (read_type): Use obstack_strdup.
 961         * gdb_obstack.h (obstack_strdup): New overload.
 962         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
 963         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
 964         (dwarf2_canonicalize_name): Use obstack_strdup.
 965         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
 966         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
 967         Use obstack_strdup.
 968
 969 2019-08-06  Tom Tromey  <tom@tromey.com>
 970
 971         * gdb_obstack.h (obstack_strdup): Define.
 972         * gdb_obstack.c (obstack_strdup): Don't define.
 973
 974 2019-08-06  Tom Tromey  <tom@tromey.com>
 975
 976         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
 977         obstack_strdup.
 978         * typeprint.c (typedef_hash_table::find_global_typedef): Use
 979         obstack_strdup.
 980         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
 981         * stabsread.c (common_block_start): Use obstack_strdup.
 982         * objfiles.c (set_objfile_main_name, objfile): Use
 983         obstack_strdup.
 984         * namespace.c (add_using_directive): Use obstack_strdup.
 985         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
 986         * jit.c (finalize_symtab): Use obstack_strdup.
 987         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
 988         (guess_partial_die_structure_name, partial_die_info::fixup)
 989         (dwarf2_name): Use obstack_strdup.
 990         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
 991         obstack_strdup.
 992         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
 993         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 994         obstack_strdup.
 995         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
 996
 997 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 998
 999         * unittests/help-doc-selftests.c: New file.
1000         * Makefile.in: Add the new file.
1001
1002 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1003
1004         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1005         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1006         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1007         the trailing '.' is not output, and the first character is uppercased.
1008         (print_help_for_command): Update call to print_doc_line.
1009         (print_doc_of_command): Likewise.
1010         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1011         * cli/cli-option.c (append_indented_doc): Do not append newline.
1012         (build_help_option): Append newline after first appended_indented_doc
1013         only if a second call is done.
1014         (build_help): Append 2 new lines before each option, except the first
1015         one.
1016         * compile/compile.c (_initialize_compile): Add new lines after
1017         %OPTIONS%, when not at the end of the help.
1018         Change help doc or code
1019         producing the help doc to respect the invariants.
1020         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1021         Also removed the new line after 'Options:', as all other commands
1022         do not put an empty line between 'Options:' and the first option.
1023         * printcmd.c (_initialize_printcmd): Likewise.
1024         * stack.c (_initialize_stack): Likewise.
1025         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1026         incorrectly telling COMMAND is optional.
1027         * ada-lang.c (_initialize_ada_language): Change help doc or code
1028         producing the help doc to respect the invariants.
1029         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1030         * breakpoint.c (_initialize_breakpoint): Likewise.
1031         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1032         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1033         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1034         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1035         _initialize_cli_style): Likewise.
1036         * corelow.c (core_target_info): Likewise.
1037         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1038         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1039         * filesystem.c (_initialize_filesystem): Likewise.
1040         * frame.c (_initialize_frame): Likewise.
1041         * gnu-nat.c (add_task_commands): Likewise.
1042         * infcall.c (_initialize_infcall): Likewise.
1043         * infcmd.c (_initialize_infcmd): Likewise.
1044         * interps.c (_initialize_interpreter): Likewise.
1045         * language.c (_initialize_language): Likewise.
1046         * linux-fork.c (_initialize_linux_fork): Likewise.
1047         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1048         * maint.c (_initialize_maint_cmds): Likewise.
1049         * memattr.c (_initialize_mem): Likewise.
1050         * printcmd.c (_initialize_printcmd): Likewise.
1051         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1052         _RegEx): Likewise.
1053         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1054         * record-btrace.c (_initialize_record_btrace): Likewise.
1055         * record-full.c (_initialize_record_full): Likewise.
1056         * record.c (_initialize_record): Likewise.
1057         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1058         * regcache.c (_initialize_regcache): Likewise.
1059         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1060         _initialize_remote): Likewise.
1061         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1062         * serial.c (_initialize_serial): Likewise.
1063         * skip.c (_initialize_step_skip): Likewise.
1064         * source.c (_initialize_source): Likewise.
1065         * stack.c (_initialize_stack): Likewise.
1066         * symfile.c (_initialize_symfile): Likewise.
1067         * symtab.c (_initialize_symtab): Likewise.
1068         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1069         * top.c (init_main): Likewise.
1070         * tracefile-tfile.c (tfile_target_info): Likewise.
1071         * tracepoint.c (_initialize_tracepoint): Likewise.
1072         * tui/tui-win.c (_initialize_tui_win): Likewise.
1073         * utils.c (add_internal_problem_command): Likewise.
1074         * valprint.c (value_print_option_defs): Likewise.
1075
1076 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1077
1078         PR build/24886
1079         * configure.ac: Drop enable-libmcheck support.
1080         * configure, config.in: Rebuild.
1081         * libmcheck.m4: Remove.
1082         * acinclude.m4: Don't include it.
1083         * Makefile.in: Don't distribute it.
1084         * top.c (print_gdb_configuration): Don't mention it.
1085
1086 2019-08-06  Tom Tromey  <tom@tromey.com>
1087
1088         * utils.c (set_output_style): Sometimes pass stream to
1089         emit_style_escape.
1090         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1091         * record-btrace.c (btrace_insn_history): Update.
1092         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1093         method.
1094         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1095         Update initializers.
1096         <m_uiout>: New field.
1097         <m_di>: Move lower.
1098         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1099         Remove "uiout" parameter.
1100         (dump_insns): Update.
1101         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1102         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1103
1104 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1105
1106         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1107         (error_in_psymtab_expansion): Likewise.
1108         (lookup_symbol_via_quick_fns): Likewise.
1109         (basic_lookup_transparent_type_quick): Likewise.
1110         (basic_lookup_transparent_type_1): Likewise.
1111
1112 2019-08-06  Tom Tromey  <tromey@adacore.com>
1113
1114         * source.c (last_source_error): Now bool.
1115         (print_source_lines_base): Make "noprint" bool.  Only open
1116         source file when last_source_visited changes.
1117
1118 2019-08-06  Tom Tromey  <tromey@adacore.com>
1119
1120         * annotate.c (annotate_source_line): Use g_source_cache.
1121         * source-cache.c (source_cache::get_plain_source_lines): Change
1122         parameters.  Populate m_offset_cache.
1123         (source_cache::ensure): New method.
1124         (source_cache::get_line_charpos): New method.
1125         (extract_lines): Move lower.  Change parameters.
1126         (source_cache::get_source_lines): Move lower.
1127         * source-cache.h (class source_cache): Update comment.
1128         <get_line_charpos>: New method.
1129         <get_source_lines>: Update comment.
1130         <clear>: Clear m_offset_cache.
1131         <get_plain_source_lines>: Change parameters.
1132         <ensure>: New method
1133         <m_offset_cache>: New member.
1134         * source.c (forget_cached_source_info_for_objfile): Update.
1135         (info_source_command): Use g_source_cache.
1136         (find_source_lines, open_source_file_with_line_charpos): Remove.
1137         (print_source_lines_base, search_command_helper): Use g_source_cache.
1138         * source.h (open_source_file_with_line_charpos): Don't declare.
1139         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1140         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1141         Use g_source_cache.
1142
1143 2019-08-06  Tom Tromey  <tromey@adacore.com>
1144
1145         * source-cache.c (source_cache::get_plain_source_lines):
1146         Remove "first_line" and "last_line" parameters.
1147         (source_cache::get_source_lines): Cache plain text.
1148         * source-cache.h (class source_cache)
1149         <get_plain_source_lines>: Update.
1150
1151 2019-08-06  Tom Tromey  <tromey@adacore.com>
1152
1153         * source-cache.c (extract_lines): No longer a method.
1154         Changed type of parameter.  Include final newline.
1155         (selftests::extract_lines_test): New function.
1156         (_initialize_source_cache): Likewise.
1157         * source-cache.h (class source_cache)
1158         <extract_lines>: Don't declare.
1159
1160 2019-08-06  Tom Tromey  <tromey@adacore.com>
1161
1162         * breakpoint.c (init_breakpoint_sal): Update.
1163         (breakpoint): Update.
1164         * breakpoint.h (struct breakpoint) <filter>: Now a
1165         unique_xmalloc_ptr.
1166
1167 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1168
1169         * NEWS: Mention dictionary access on blocks.
1170         * python/py-block.c (blpy_getitem): New function.
1171         (block_object_as_mapping): New struct.
1172         (block_object_type): Use new struct for tp_as_mapping field.
1173
1174 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1175
1176         * objfiles.h (objfile): Add a comment describing partial symbols.
1177
1178 2019-08-05  Tom Tromey  <tromey@adacore.com>
1179
1180         * compile/compile.c (_initialize_compile): Use _(), not N_().
1181         * thread.c (_initialize_thread): Use _(), not N_().
1182         * stack.c (_initialize_stack): Use _(), not N_().
1183         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1184
1185 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1186
1187         * dwarf2read.c (struct dw2_symtab_iterator):
1188         <want_specific_block>: Remove.
1189         <block_index>: Change type to gdb::optional.
1190         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1191         change type of BLOCK_INDEX parameter to gdb::optional.
1192         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1193         (dw2_lookup_symbol): Don't pass argument for
1194         WANT_SPECIFIC_BLOCK.
1195         (dw2_expand_symtabs_for_function): Don't pass argument for
1196         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1197         (class dw2_debug_names_iterator)
1198         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1199         parameter, change BLOCK_INDEX type to gdb::optional.
1200         <m_want_specific_block>: Remove.
1201         <m_block_index>: Change type to gdb::optional.
1202         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1203         gdb::optional.  Re-write in function of gdb::optional.
1204         (dw2_debug_names_lookup_symbol): Don't pass argument for
1205         WANT_SPECIFIC_BLOCK.
1206         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1207         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1208         BLOCK_INDEX.
1209
1210 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1211
1212         * NEWS: Mention changes to "info sources" command.
1213
1214 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1215
1216         * symtab.c (filename_partial_match_opts): New struct type.
1217         (struct output_source_filename_data): New members
1218         regexp, c_regexp, partial_match.
1219         (output_source_filename): Use new members to decide to print file.
1220         (info_sources_option_defs): New variable.
1221         (make_info_sources_options_def_group, print_info_sources_header,
1222         info_sources_command_completer):
1223         New functions.
1224         (info_sources_command): Read new optional arguments.
1225         (_initialize_symtab): Update info sources help.
1226
1227 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1228
1229         * ada-lang.c (exception_support_info_v0): Renamed from...
1230         (default_exception_support_info): ... this.  Create new
1231         definition for v1.
1232         (ada_has_this_exception_support): Look up catch_handlers_sym.
1233         (ada_exception_support_info_sniffer): Try v0 after default.
1234
1235 2019-08-01  Tom Tromey  <tromey@adacore.com>
1236
1237         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1238         gdbarch.h.
1239
1240 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1241
1242         * s12z-tdep.c: Fix include path for s12z-opc.h.
1243
1244 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1245
1246         * NEWS: Require GNU make 3.82.
1247
1248 2019-07-16  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1251         declare.
1252
1253 2019-07-30  Tom Tromey  <tromey@adacore.com>
1254
1255         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1256
1257 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1258
1259         * printcmd.c (print_address_symbolic): Print negative offsets.
1260         (build_address_symbolic): Force signed arithmetic when computing
1261         offset.
1262
1263 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1264
1265         PR/24474: Add a function to lookup static variables.
1266         * NEWS: Mention this new function.
1267         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1268         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1269         * python/python.c (python_GdbMethods): Add new function.
1270
1271 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1272
1273         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1274         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1275         (objfpy_lookup_static_symbol): New function.
1276         (objfile_object_methods): Add new functions.
1277
1278 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1279
1280         * NEWS: Mention 'set|show print frame-info'.  Mention new
1281         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1282         backtrace argument.  Mention that python frame filtering code
1283         is now consistent with what 'backtrace' command prints.
1284
1285 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1286
1287         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1288         comments.
1289         (print_frame_info_auto, print_frame_info_source_line,
1290         print_frame_info_location, print_frame_info_source_and_location,
1291         print_frame_info_location_and_address, print_frame_info_short_location):
1292         New declarations.
1293         (struct frame_print_options): New member print_frame_info.
1294         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1295         * stack.h (get_user_print_what_frame_info): New declaration.
1296         (frame_show_address): New declaration.
1297         * stack.c (print_frame_arguments_choices): New value 'presence'.
1298         (print_frame_info_auto, print_frame_info_source_line,
1299         print_frame_info_location, print_frame_info_source_and_location,
1300         print_frame_info_location_and_address, print_frame_info_short_location,
1301         print_frame_info_choices, print_frame_info_print_what): New definitions.
1302         (print_frame_args): Only print dots for args if print frame-arguments
1303         is 'presence'.
1304         (frame_print_option_defs): New element for "frame-info".
1305         (get_user_print_what_frame_info): New function.
1306         (frame_show_address): Make non static.  Move comment to stack.h.
1307         (print_frame_info_to_print_what): New function.
1308         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1309         to decide what to print.
1310         (backtrace_command_1): Handle the new print_frame_arguments_presence
1311         value.
1312         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1313         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1314         (py_print_frame): In non-mi mode, use LOCATION as default for
1315         print_what, similarly to frame information printed directly by
1316         backtrace command. Handle frame-info user option in non MI mode.
1317
1318 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1319
1320         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1321         Add case for debugging 32-bit target on 64-bit host.  Revise
1322         comment.
1323
1324 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1325
1326         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1327         instead of find_function_entry_range_from_pc.
1328
1329 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1330
1331         * stack.c (find_frame_funname): Remove code which preferred
1332         minsym over symtab sym in "certain pathological cases".
1333
1334         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1335         parameter.  Change type of "do_demangle" to bool.
1336         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1337         Pass suitable "prefer_sym_over_minsym" flag to
1338         build_address_symbolic().  Don't output "+" for negative offsets.
1339         * printcmd.c (print_address_symbolic): Update invocation of
1340         build_address_symbolic to include a "prefer_sym_over_minsym"
1341         flag.
1342         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1343         Restrict cases in which use of minimal symbol is preferred to that
1344         of a found symbol.  Update comments.
1345
1346         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1347         for entry pc when entry pc is out of range for that FDE.
1348
1349 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1350
1351         PR gdb/24839:
1352         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1353         type.
1354
1355 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1356
1357         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1358         this function's Python signature.
1359
1360
1361 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1362
1363         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1364         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1365         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1366         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1367         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1368
1369
1370 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1371
1372         * h8300-tdep.c (h8300_register_name_common): New.
1373         h8300_register_name): Use h8300_register_name_common.
1374         (h8300s_register_name): Likewise.
1375         (h8300sx_register_name): Likewise.
1376         (h8300h_register_nam): New.
1377         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1378
1379
1380 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1381
1382         * arm-tdep.c (arm_skip_cmse_entry): New function.
1383         (arm_is_sgstubs_section): New function.
1384         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1385
1386 2019-07-22  Tom Tromey  <tom@tromey.com>
1387
1388         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1389         Don't self-assign.
1390
1391 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1394         type_print.
1395
1396 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1397
1398         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1399         so that GDB doesn't match any msymbols when searching in the
1400         TYPES_DOMAIN.
1401         (print_symbol_info): Print using typedef_print or type_print based
1402         on the type of the symbol.  Add updated FIXME comment moved from...
1403         (_initialize_symtab): ... move and update FIXME comment to above.
1404
1405 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * NEWS: Mention adding -q option to "info types".
1408         * symtab.c (struct info_types_options): New struct.
1409         (info_types_options_defs): New variable.
1410         (make_info_types_options_def_group): New function.
1411         (info_types_command): Use gdb::option framework to parse options.
1412         (info_types_command_completer): New function.
1413         (_initialize_symtab): Extend the help text on "info types" and
1414         register command completer.
1415
1416 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1417
1418         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1419         (lookup_symbol_in_objfile): Change int to block_enum and add a
1420         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1421
1422 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1423
1424         * MAINTAINERS (Write After Approval): Add self.
1425
1426 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1427
1428         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1429         instruction to the dummy code region.
1430
1431 2019-07-19  Tom Tromey  <tromey@adacore.com>
1432
1433         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1434         (ARGSUSED, PARAMS, __func__): Remove rules.
1435
1436 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1437
1438         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1439         * features/arm/arm-with-iwmmxt.c: Remove.
1440         * features/arm/arm-with-iwmmxt.xml: Remove.
1441         * features/arm/arm-with-m-fpa-layout.c: Remove.
1442         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1443         * features/arm/arm-with-m-vfp-d16.c: Remove.
1444         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1445         * features/arm/arm-with-m.c: Remove.
1446         * features/arm/arm-with-m.xml: Remove.
1447         * features/arm/arm-with-neon.c: Remove.
1448         * features/arm/arm-with-neon.xml: Remove.
1449         * features/arm/arm-with-vfpv2.c: Remove.
1450         * features/arm/arm-with-vfpv2.xml: Remove.
1451         * features/arm/arm-with-vfpv3.c: Remove.
1452         * features/arm/arm-with-vfpv3.xml: Remove.
1453
1454 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1455
1456         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1457
1458 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1459
1460         * arch/aarch32.c (aarch32_create_target_description): Create
1461         target descriptions using features.
1462         * arch/arm.c (arm_create_target_description)
1463         (arm_create_mprofile_target_description): Likewise.
1464         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1465
1466 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * Makefile.in: Add new files.
1469         * aarch32-tdep.c: New file.
1470         * aarch32-tdep.h: New file.
1471         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1472         Call aarch32_read_description.
1473         * arch/aarch32.c: New file.
1474         * arch/aarch32.h: New file.
1475         * arch/arm.c (arm_create_target_description)
1476         (arm_create_mprofile_target_description): New function.
1477         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1478         (arm_create_target_description)
1479         (arm_create_mprofile_target_description): New declaration.
1480         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1481         read_description functions.
1482         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1483         Likewise.
1484         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1485         * arm-tdep.c (tdesc_arm_list): New variable.
1486         (arm_register_g_packet_guesses): Call create description functions.
1487         (arm_read_description) (arm_read_mprofile_description): New
1488         function.
1489         * arm-tdep.h (arm_read_description)
1490         (arm_read_mprofile_description): Add declaration.
1491         * configure.tgt: Add new files.
1492
1493 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1494
1495         * top.c (new_ui_command): Open specified terminal just once.
1496
1497 2019-07-18  Tom Tromey  <tromey@adacore.com>
1498
1499         * symtab.c (main_name): Constify return type.
1500         * symfile.c (set_initial_language): Update.
1501         * symtab.h (main_name): Constify return type.
1502
1503 2019-07-17  Tom Tromey  <tom@tromey.com>
1504
1505         * tui/tui-winsource.c (tui_update_source_window)
1506         (tui_update_source_window_as_is)
1507         (tui_update_source_windows_with_line): Remove return.
1508         * tui/tui-disasm.c (tui_show_disassem)
1509         (tui_show_disassem_and_update_source): Remove return.
1510         * tui/tui.c (tui_reset): Remove return.
1511         * tui/tui-wingeneral.c
1512         (tui_check_and_display_highlight_if_needed): Remove return.
1513
1514 2019-07-17  Tom Tromey  <tom@tromey.com>
1515
1516         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1517
1518 2019-07-17  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-winsource.h (struct tui_exec_info_window)
1521         (struct tui_source_window_base): Move from tui-data.h.
1522         * tui/tui-winsource.c: Move many method definitions from
1523         elsewhere.  Remove "structuring" comments.
1524         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1525         (tui_source_window_base::refresh_window): Move to
1526         tui-winsource.c.
1527         * tui/tui-win.c (tui_source_window_base::refresh_all)
1528         (tui_source_window_base::update_tab_width)
1529         (tui_source_window_base::set_new_height)
1530         (tui_source_window_base::do_make_visible_with_new_height): Move to
1531         tui-winsource.c.
1532         * tui/tui-source.h: Update.
1533         * tui/tui-source.c (tui_source_window_base::reset): Move to
1534         tui-winsource.c.
1535         * tui/tui-disasm.h: Update.
1536         * tui/tui-data.h (struct tui_exec_info_window): Move to
1537         tui-winsource.h.
1538         (struct tui_source_window_base): Likewise.
1539         * tui/tui-data.c (tui_source_window_base::clear_detail)
1540         (tui_source_window_base, ~tui_source_window_base): Move to
1541         tui-winsource.c.
1542
1543 2019-07-17  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-win.c (tui_resize_all)
1546         (tui_source_window_base::update_tab_width)
1547         (tui_adjust_win_heights): Update.
1548         (tui_win_info::make_invisible_and_set_new_height): Rename from
1549         make_invisible_and_set_new_height.
1550         * tui/tui-data.h (struct tui_win_info)
1551         <make_invisible_and_set_new_height>: New method.
1552
1553 2019-07-17  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui.c: Update.
1556         * tui/tui-source.h (struct tui_source_window): Move from
1557         tui-data.h.
1558         * tui/tui-layout.c: Update.
1559         * tui/tui-disasm.c: Update.
1560         * tui/tui-data.h (struct tui_source_window): Move to
1561         tui-source.h.
1562
1563 2019-07-17  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1566         tui-data.h.
1567         * tui/tui-data.h (struct tui_disasm_window): Move to
1568         tui-disasm.h.
1569
1570 2019-07-17  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-regs.h (struct tui_data_item_window): Move from
1573         tui-data.h.
1574         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1575         * tui/tui-data.h (struct tui_data_item_window): Move to
1576         tui-regs.h.
1577         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1578
1579 2019-07-17  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui.c: Update.
1582         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1583         (tui_cmd_window::max_height): Move to tui-command.c.
1584         * tui/tui-layout.c: Update.
1585         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1586         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1587         tui-command.c.
1588         * tui/tui-command.h (struct tui_cmd_window): Move from
1589         tui-data.h.
1590         * tui/tui-command.c: Remove "structuring" comments.
1591         (tui_cmd_window::clear_detail)
1592         (tui_cmd_window::do_make_visible_with_new_height)
1593         (tui_cmd_window::max_height): Move from elsewhere.
1594
1595 2019-07-17  Tom Tromey  <tom@tromey.com>
1596
1597         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1598         Now static.
1599         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1600         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1601
1602 2019-07-17  Tom Tromey  <tom@tromey.com>
1603
1604         * tui/tui.c: Update.
1605         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1606         tui-regs.c.
1607         * tui/tui-windata.h: Remove file.
1608         * tui/tui-windata.c: Remove file.
1609         * tui/tui-win.c (tui_data_window::set_new_height)
1610         (tui_data_window::do_make_visible_with_new_height): Move to
1611         tui-regs.c.
1612         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1613         * tui/tui-regs.c: Remove "structuring" comments.
1614         (tui_data_window::first_data_item_displayed)
1615         (tui_data_window::delete_data_content_windows)
1616         (tui_data_window::erase_data_content)
1617         (tui_data_window::display_all_data)
1618         (tui_data_window::refresh_all)
1619         (tui_data_window::do_scroll_vertical)
1620         (tui_data_window::clear_detail, tui_data_window::set_new_height)
1621         (tui_data_window::do_make_visible_with_new_height)
1622         (tui_data_window::refresh_window): Move from elsewhere.
1623         (_initialize_tui_regs): Move to end of file.
1624         * tui/tui-layout.c: Update.
1625         * tui/tui-hooks.c: Update.
1626         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1627         * tui/tui-data.c (tui_data_window::clear_detail): Move to
1628         tui-regs.c.
1629         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1630
1631 2019-07-17  Tom Tromey  <tom@tromey.com>
1632
1633         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1634         seen.
1635
1636 2019-07-17  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-win.c (tui_source_window_base::set_new_height)
1639         (tui_source_window_base::do_make_visible_with_new_height): Use
1640         m_has_locator field directly.
1641         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1642         method.
1643         (struct tui_source_window_base) <has_locator>: Likewise.
1644
1645 2019-07-17  Tom Tromey  <tom@tromey.com>
1646
1647         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1648         Don't declare.
1649         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1650         Remove.
1651         * tui/tui-win.c (tui_source_window_base::set_new_height)
1652         (tui_source_window_base::set_new_height)
1653         (make_invisible_and_set_new_height)
1654         (tui_source_window_base::do_make_visible_with_new_height)
1655         (tui_source_window_base::do_make_visible_with_new_height):
1656         Update.
1657         * tui/tui-layout.c (show_source_disasm_command, show_data)
1658         (show_source_or_disasm_and_command): Update.
1659         * tui/tui-layout.c (show_layout): Update.
1660
1661 2019-07-17  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-layout.c (make_data_window): Remove.
1664         (show_data): Unify creation and re-initialization cases.
1665
1666 2019-07-17  Tom Tromey  <tom@tromey.com>
1667
1668         * tui/tui-layout.c (make_source_window, make_disasm_window):
1669         Remove.
1670         (show_data): Unify creation and re-initialization cases.
1671
1672 2019-07-17  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-layout.c (make_command_window): Remove.
1675         (show_source_disasm_command, show_source_or_disasm_and_command):
1676         Unify creation and re-initialization cases.
1677
1678 2019-07-17  Tom Tromey  <tom@tromey.com>
1679
1680         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1681         creation and re-initialization cases.
1682
1683 2019-07-17  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-regs.c (tui_get_register): Return void.
1686
1687 2019-07-17  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1690         Simplify.
1691
1692 2019-07-17  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-layout.c (show_source_disasm_command): Simplify window
1695         resetting.
1696
1697 2019-07-17  Tom Tromey  <tom@tromey.com>
1698
1699         * tui/tui.h (tui_set_layout_by_name): Don't declare.
1700         * tui/tui-regs.c (tui_reg_layout): New function.
1701         (tui_show_registers, tui_reg_command): Use it.
1702         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1703         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
1704         parameters.
1705         (tui_layout_command): Remove.
1706
1707 2019-07-17  Tom Tromey  <tom@tromey.com>
1708
1709         * tui/tui-layout.h (tui/tui-layout): Return void.
1710         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
1711
1712 2019-07-17  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-layout.c (show_source_disasm_command, show_data):
1715         Update.
1716         (reset_locator): Remove.
1717         (show_source_or_disasm_and_command): Update.
1718
1719 2019-07-17  Tom Tromey  <tom@tromey.com>
1720
1721         * tui/tui-source.c (tui_source_window_base::reset): Remove
1722         win_type parameter.
1723         * tui/tui-layout.c (make_command_window, make_source_window)
1724         (make_disasm_window, make_data_window)
1725         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1726         (reset_locator, show_source_or_disasm_and_command): Update.
1727         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1728         win_type parameter.
1729         (struct tui_source_window_base) <reset>: Likewise.
1730
1731 2019-07-17  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-layout.c (show_source_disasm_command): Use
1734         reset_locator.
1735         (reset_locator): New function.
1736         (init_and_make_win): Remove.
1737         (show_source_or_disasm_and_command): Use reset_locator.
1738
1739 2019-07-17  Tom Tromey  <tom@tromey.com>
1740
1741         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1742         condition.
1743         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1744         Remove condition.
1745         * tui/tui-source.c (tui_source_window_base::reset): New method.
1746         * tui/tui-layout.c (make_command_window): Don't call
1747         init_and_make_win.
1748         (make_source_window, make_disasm_window): Don't call
1749         make_source_or_disasm_window.
1750         (make_data_window): Don't call init_and_make_win.  Change calling
1751         convention.
1752         (show_source_disasm_command, show_data): Simplify.
1753         (make_source_or_disasm_window): Remove.
1754         (show_source_or_disasm_and_command): Simplify.
1755         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1756         (struct tui_source_window_base) <reset>: Likewise.
1757         <execution_info>: Remove initializer.
1758         * tui/tui-data.c (tui_source_window_base): Initialize
1759         execution_info.
1760
1761 2019-07-17  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1764         variable.
1765
1766 2019-07-17  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui.c (tui_rl_other_window): Update.
1769         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1770         superclass method first.  Always iterate over regs_content.
1771         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1772         method.
1773         * tui/tui-win.c (tui_set_focus_command): Update.
1774
1775 2019-07-17  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-win.c (tui_set_focus_command): Rename from
1778         tui_set_focus.  Call tui_enable.
1779         (tui_set_focus_command): Remove.
1780
1781 2019-07-17  Tom Tromey  <tom@tromey.com>
1782
1783         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1784         refresh_window.
1785         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1786         touchwin.
1787         (tui_data_window::refresh_window): Call refresh_window on data
1788         items.  Always call superclass refresh_window.
1789         (tui_win_info::refresh): Remove.
1790         (tui_source_window_base::refresh_window): Update.
1791         (tui_refresh_all): Update.
1792         * tui/tui-layout.c (show_source_disasm_command): Remove call to
1793         refresh_window.
1794         (show_source_or_disasm_and_command): Likewise.
1795         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1796         (struct tui_source_window_base) <refresh>: Likewise.
1797
1798 2019-07-17  Tom Tromey  <tom@tromey.com>
1799
1800         * tui/tui-winsource.c (tui_clear_source_content)
1801         (tui_show_source_content): Update.
1802         * tui/tui-source.c (tui_source_window::showing_source_p): Check
1803         whether content is empty.
1804         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1805         Remove.
1806
1807 2019-07-17  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-winsource.c (tui_erase_source_content): Clear the
1810         window's contents.
1811         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1812         * tui/tui-source.c (tui_set_source_content_nil): Remove.
1813
1814 2019-07-17  Tom Tromey  <tom@tromey.com>
1815
1816         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1817         (struct tui_data_item_window): Update.
1818
1819 2019-07-17  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1822         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1823         defines.
1824
1825 2019-07-17  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui-winsource.h (tui_erase_source_content)
1828         (tui_clear_source_content): Remove "display_prompt" parameter.
1829         * tui/tui-winsource.c (tui_update_source_window_as_is)
1830         (tui_update_source_windows_with_addr): Update.
1831         (tui_clear_source_content): Remove "display_prompt" parameter.
1832         (tui_erase_source_content): Likewise.  Simplify.
1833         (tui_show_source_content): Update.
1834         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1835         * tui/tui-stack.c (tui_show_frame_info): Update.
1836         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1837         Remove defines.
1838
1839 2019-07-17  Tom Tromey  <tom@tromey.com>
1840
1841         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1842         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1843         parameter.
1844         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1845         parameter.
1846
1847 2019-07-17  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-winsource.c (tui_clear_source_content)
1850         (tui_show_source_content, tui_show_exec_info_content)
1851         (tui_clear_exec_info_content): Update.
1852         * tui/tui-stack.c (tui_show_locator_content): Update.
1853         (tui_show_frame_info): Update.
1854         * tui/tui-source.h (tui_source_window): Don't declare.
1855         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1856         from tui_source_is_displayed.
1857         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1858         Remove field.
1859         (struct tui_source_window_base) <content_in_use>: New field.  Now
1860         bool.
1861         (struct tui_source_window) <showing_source_p>: New method.
1862         (TUI_SRC_WIN): Change cast.
1863         * tui/tui-data.c (tui_initialize_static_data): Update.
1864
1865 2019-07-17  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1868         location_matches_p.
1869         * tui/tui-source.c (tui_source_window::location_matches_p): New
1870         method.
1871         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1872         method.
1873         * tui/tui-data.h (struct tui_source_window_base)
1874         <location_matches_p>: New method.
1875         (struct tui_source_window, struct tui_disasm_window)
1876         <location_matches_p>: Likewise.
1877
1878 2019-07-17  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-win.c (tui_set_win_height_command): Rename from
1881         tui_set_win_height.
1882         (tui_set_win_height_command): Remove.
1883
1884 2019-07-17  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-source.c (tui_source_window): New constructor.  Add
1887         observer.
1888         (~tui_source_window): New destructor.
1889         (tui_source_window::style_changed): New method.
1890         * tui/tui-hooks.c (tui_redisplay_source): Remove.
1891         (tui_attach_detach_observers): Update.
1892         * tui/tui-data.h (struct tui_source_window): Make constructor not
1893         inline.  Add destructor.
1894         (struct tui_source_window) <style_changed>: New method.
1895         <m_observable>: New member.
1896
1897 2019-07-17  Tom Tromey  <tom@tromey.com>
1898
1899         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1900         * tui/tui-win.c (tui_resize_all): Fix typo.
1901
1902 2019-07-17  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-wingeneral.h (tui_refresh_all): Update.
1905         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1906         (tui_refresh_all): Remove "list" parameter.  Use foreach.
1907         * tui/tui-win.c (window_name_completer): Use foreach.
1908         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1909         (update_tab_width): Likewise.
1910         * tui/tui-layout.c (show_layout): Update.
1911         * tui/tui-data.h (class tui_window_iterator): New.
1912         (struct all_tui_windows): New.
1913         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1914
1915 2019-07-17  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1918         parameter.  Don't reference globals.
1919         (tui_reg_command): Update.
1920
1921 2019-07-17  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-regs.c (tui_show_registers): Simplify.
1924
1925 2019-07-17  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-regs.c (tui_show_registers): Update.
1928         (tui_show_register_group): Add win_info parameter.
1929
1930 2019-07-17  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1933         Rename from tui_display_reg_element_at_line.
1934         (tui_data_window::display_registers_from_line): Update.
1935         * tui/tui-data.h (struct tui_data_window)
1936         <display_reg_element_at_line>: New method.
1937
1938 2019-07-17  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-regs.h (tui_display_registers_from)
1941         (tui_display_registers_from_line): Don't declare.
1942         * tui/tui-windata.c (tui_data_window::display_all_data)
1943         (tui_data_window::refresh_all)
1944         (tui_data_window::do_scroll_vertical): Update.
1945         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1946         from tui_display_registers_from.
1947         (tui_display_reg_element_at_line): Update.
1948         (tui_data_window::display_registers_from_line): Rename from
1949         tui_display_registers_from_line.
1950         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1951         display_registers_from_line>: New methods.
1952
1953 2019-07-17  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1956         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1957         from tui_erase_data_content.
1958         (tui_data_window::display_all_data)
1959         (tui_data_window::refresh_all)
1960         (tui_data_window::do_scroll_vertical): Update.
1961         * tui/tui-regs.c (tui_show_registers): Update.
1962         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1963         New method.
1964
1965 2019-07-17  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1968         declare.
1969         * tui/tui-windata.c
1970         (tui_data_window::delete_data_content_windows): Rename from
1971         tui_delete_data_content_windows.
1972         (tui_data_window::display_all_data)
1973         (tui_data_window::do_scroll_vertical): Update.
1974         * tui/tui-data.h (struct tui_data_window)
1975         <delete_data_content_windows>: New method.
1976
1977 2019-07-17  Tom Tromey  <tom@tromey.com>
1978
1979         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1980         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1981
1982 2019-07-17  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-windata.h (tui_display_all_data): Don't declare.
1985         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1986         from tui_display_all_data.
1987         * tui/tui-win.c
1988         (tui_data_window::do_make_visible_with_new_height): Update.
1989         * tui/tui-regs.c (tui_show_registers): Update.
1990         * tui/tui-layout.c (tui_set_layout): Update.
1991         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1992         method.
1993
1994 2019-07-17  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-windata.h (tui_display_data_from): Don't declare.
1997         * tui/tui-windata.c (tui_display_data_from): Remove.
1998         (tui_data_window::refresh_all): Update.
1999
2000 2019-07-17  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2003         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2004         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2005         tui_display_registers_from_line.
2006         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2007         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2008         "force_display" parameter.
2009
2010 2019-07-17  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2013         declare.
2014         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2015         Rename from tui_first_reg_element_no_inline.
2016         (tui_display_reg_element_at_line)
2017         (tui_display_registers_from_line): Update.
2018         * tui/tui-data.h (struct tui_data_window)
2019         <first_reg_element_no_inline>: New method.
2020
2021 2019-07-17  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-windata.c (tui_display_data_from)
2024         (tui_data_window::do_scroll_vertical): Update.
2025         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2026         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2027         Rename from tui_line_from_reg_element_no.
2028         (tui_display_registers_from_line): Update.
2029         * tui/tui-data.h (struct tui_data_window)
2030         <line_from_reg_element_no>: New method.
2031
2032 2019-07-17  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2035         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2036         tui_last_regs_line_no.
2037         (tui_display_reg_element_at_line)
2038         (tui_display_registers_from_line): Update.
2039         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2040         method.
2041
2042 2019-07-17  Tom Tromey  <tom@tromey.com>
2043
2044         PR tui/24722:
2045         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2046         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2047         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2048         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2049         (tui_update_breakpoint_info): Likewise.
2050         * tui/tui-hooks.c (tui_event_create_breakpoint)
2051         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2052         Update.
2053
2054 2019-07-17  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2057
2058 2019-07-17  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-winsource.c (tui_update_source_window_as_is)
2061         (tui_update_source_windows_with_addr): Update.
2062         * tui/tui-source.h (tui_set_source_content)
2063         (tui_show_symtab_source): Add "win_info" parameter.
2064         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2065         parameter.
2066         (tui_show_symtab_source): Likewise.
2067
2068 2019-07-17  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-wingeneral.c
2071         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2072
2073 2019-07-17  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2076         (struct tui_cmd_window) <can_scroll>: New method.
2077         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2078         method.
2079
2080 2019-07-17  Tom Tromey  <tromey@adacore.com>
2081
2082         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2083         do_field_signed>: Rename.  Change type of "value".
2084         * ui-out.c (ui_out::field_signed): Rename from field_int.
2085         Change type of "value".
2086         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2087         type of "value".
2088         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2089         do_field_int.  Change type of "value".
2090         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2091         do_field_int.  Change type of "value".
2092         * tracepoint.c (trace_status_mi, tfind_1)
2093         (print_one_static_tracepoint_marker): Update.
2094         * thread.c (print_thread_info_1, print_selected_thread_frame):
2095         Update.
2096         * stack.c (print_frame, print_frame_info): Update.
2097         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2098         Update.
2099         * source.c (print_source_lines_base): Update.
2100         * skip.c (info_skip_command): Update.
2101         * record-btrace.c (btrace_ui_out_decode_error)
2102         (btrace_call_history_src_line): Update.
2103         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2104         Update.
2105         * progspace.c (print_program_space): Update.
2106         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2107         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2108         do_field_int.  Change type of "value".
2109         * mi/mi-out.c (mi_ui_out::do_table_begin)
2110         (mi_ui_out::do_table_header): Update.
2111         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2112         type of "value".
2113         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2114         (mi_cmd_data_list_changed_registers, output_register)
2115         (mi_cmd_data_read_memory, mi_load_progress)
2116         (mi_cmd_trace_frame_collected): Update.
2117         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2118         Update.
2119         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2120         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2121         (mi_cmd_var_list_children, varobj_update_one): Update.
2122         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2123         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2124         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2125         * inferior.c (print_inferior): Update.
2126         * gdb_bfd.c (print_one_bfd): Update.
2127         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2128         Update.
2129         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2130         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2131         do_field_int.  Change type of "value".
2132         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2133         do_field_int.  Change type of "value".
2134         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2135         (print_one_breakpoint_location, print_it_catch_fork)
2136         (print_one_catch_fork, print_it_catch_vfork)
2137         (print_one_catch_vfork, print_it_catch_solib)
2138         (print_it_catch_exec, print_it_ranged_breakpoint)
2139         (print_mention_watchpoint, print_mention_masked_watchpoint)
2140         (bkpt_print_it, update_static_tracepoint): Update.
2141         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2142         * break-catch-syscall.c (print_it_catch_syscall): Update.
2143         * ada-tasks.c (print_ada_task_info): Update.
2144         * ada-lang.c (print_it_exception, print_mention_exception):
2145         Update.
2146
2147 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2148
2149         PR breakpoints/24541
2150         * gdbarch.c: Regenerate.
2151         * gdbarch.h: Regenerate.
2152         * gdbarch.sh: Adjust return type and parameter types for
2153         'stap_adjust_register'.
2154         (i386_stap_adjust_register): Adjust signature and return new
2155         register name.
2156         * stap-probe.c (stap_parse_register_operand): Adjust use of
2157         'gdbarch_stap_adjust_register'.
2158
2159 2019-07-17  Tom Tromey  <tromey@adacore.com>
2160
2161         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2162         declare VEC.
2163         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2164         std::vector.
2165         (struct s390_process_info): Add initializers.
2166         (s390_add_process): Use new.
2167         (s390_linux_nat_target::low_forget_process): Use delete.
2168         (s390_linux_nat_target::low_new_fork)
2169         (s390_linux_nat_target::stopped_by_watchpoint)
2170         (s390_linux_nat_target::low_prepare_to_resume)
2171         (s390_linux_nat_target::insert_watchpoint)
2172         (s390_linux_nat_target::insert_hw_breakpoint)
2173         (s390_linux_nat_target::remove_watchpoint)
2174         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2175
2176 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2177
2178         * aarch64-fbsd-nat.c: Include regcache.h.
2179         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2180         argument.
2181         (aarch64_fbsd_nat_target::fetch_registers)
2182         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2183         variable.
2184         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2185
2186 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2187
2188         * fbsd-nat.c: Include gdbarch.h.
2189
2190 2019-07-15  Tom Tromey  <tromey@adacore.com>
2191
2192         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2193
2194 2019-07-15  Tom Tromey  <tromey@adacore.com>
2195
2196         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2197         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2198         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2199         * cli-out.c (cli_ui_out::do_field_int): New method.
2200         * ui-out.c (ui_out::field_unsigned): New method.
2201         * symfile.c (generic_load): Use field_unsigned.
2202         (print_transfer_performance): Likewise.
2203         * record-btrace.c (ui_out_field_uint): Remove.
2204         (btrace_call_history_insn_range, btrace_call_history): Use
2205         field_unsigned.
2206         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2207         field_unsigned.
2208         * ui-out.h (class ui_out) <field_unsigned>: New method.
2209         <do_field_unsigned>: Likewise.
2210
2211 2019-07-15  Tom Tromey  <tromey@adacore.com>
2212
2213         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2214         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2215         * target.c (flash_erase_command): Use field_string.
2216         * infrun.c (print_signal_received_reason): Use field_string.
2217         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2218         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2219         field_string.
2220         * ada-tasks.c (print_ada_task_info): Use field_string.
2221
2222 2019-07-15  Tom Tromey  <tromey@adacore.com>
2223
2224         * target.c (flash_erase_command): Use field_core_addr.
2225         * symfile.c (generic_load): Use field_core_addr.
2226         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2227         Use field_core_addr.
2228         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2229         field_core_addr.
2230
2231 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2234         value if its desired type is smaller than a CORE_ADDR and signed.
2235
2236 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2237
2238         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2239         of changes to field names, and use new is_reference field to
2240         decide if a property is a reference or not.
2241         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2242         field.
2243         (struct dwarf2_property_baton): Update header comment, rename
2244         'referenced_type' to 'property_type' and update comments.
2245         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2246         default property type, store in property baton, update to take
2247         accound of renamed field.
2248         (read_func_scope): Update call to attr_to_dynamic_prop.
2249         (read_array_type): Likewise.
2250         (dwarf2_per_cu_addr_sized_int_type): New function.
2251         (read_subrange_index_type): Move type finding code to
2252         dwarf2_per_cu_addr_sized_int_type.
2253         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2254         (dwarf2_per_cu_addr_type): New function.
2255         (set_die_type): Update calls to attr_to_dynamic_prop.
2256
2257 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2258
2259         * dwarf2read.c (read_subrange_index_type): New function.
2260         (read_subrange_type): Move code into new function and call it.
2261         * gdbtypes.c (create_range_type): Add some asserts.
2262
2263 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2264
2265         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2266         update return statements.
2267         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2268         declaration, and update comment to match.
2269         * gdbtypes.c (resolve_dynamic_array): Update call to
2270         dwarf2_evaluate_property to match new return type.
2271
2272 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * valarith.c (value_subscripted_rvalue): Change lowerbound
2275         parameter type from int to LONGEST.
2276         * value.h (value_subscripted_rvalue): Likewise in declaration.
2277
2278 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * cli/cli-utils.c (info_print_command_completer): New function.
2281         * cli/cli-utils.h: Add 'completer.h' include, and forward
2282         declaration for 'struct cmd_list_element'.
2283         (info_print_command_completer): Declare.
2284         * stack.c (_initialize_stack): Add completer for 'info locals' and
2285         'info args'.
2286         * symtab.c (_initialize_symtab): Add completer for 'info
2287         variables' and 'info functions'.
2288         * NEWS: Mention completion for additional info commands.
2289
2290 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2291
2292         * cli/cli-utils.c (extract_info_print_args): Delete.
2293         (extract_arg_maybe_quoted): Delete.
2294         (info_print_options_defs): New variable.
2295         (make_info_print_options_def_group): New function.
2296         (extract_info_print_options): Define new function.
2297         * cli/cli-utils.h (extract_info_print_args): Delete.
2298         (struct info_print_options): New structure.
2299         (extract_info_print_options): Declare new function.
2300         * stack.c (info_locals_command): Update to use new
2301         extract_info_print_options, also add a header comment.
2302         (info_args_command): Likewise.
2303         * symtab.c (info_variables_command): Likewise.
2304         (info_functions_command): Likewise.
2305
2306 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2307
2308         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2309         to extract string arguments.
2310         * common/common-utils.c (extract_string_maybe_quoted): New function.
2311         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2312
2313 2019-07-11  Tom Tromey  <tromey@adacore.com>
2314
2315         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2316         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2317         * top.h (gdbinit): Don't declare.
2318         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2319         into...
2320         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2321         * top.c (gdb_init): Don't call init_cli_cmds.
2322         (gdbinit): Remove.
2323         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2324
2325 2019-07-11  Tom Tromey  <tromey@adacore.com>
2326
2327         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2328         after it has been moved.
2329
2330 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2331
2332         * valops.c (value_must_coerce_to_target): Change return type to
2333         bool.
2334         * value.h (value_must_coerce_to_target): Likewise.
2335
2336 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2337
2338         * breakpoint.c (is_hardware_watchpoint): Remove
2339         forward-declaration.
2340         (is_masked_watchpoint): Change return type to bool.
2341         (is_tracepoint): Likewise.
2342         (is_breakpoint): Likewise.
2343         (is_hardware_watchpoint): Likewise.
2344         (is_watchpoint): Likewise.
2345         (is_no_memory_software_watchpoint): Likewise.
2346         (is_catchpoint): Likewise.
2347         (breakpoint_1): Make FILTER parameter's return type bool.
2348         is_masked_watchpoint): Change return type to bool.
2349         (save_breakpoints): Make FILTER parameter's return type bool.
2350         * breakpoint.h (is_breakpoint): Change return type to bool.
2351         (is_watchpoint): Likewise.
2352         (is_catchpoint): Likewise.
2353         (is_tracepoint): Likewise.
2354
2355 2019-07-10  Tom Tromey  <tom@tromey.com>
2356
2357         * defs.h: Don't include gdbarch.h.
2358         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2359         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2360         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2361         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2362         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2363         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2364         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2365         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2366         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2367         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2368         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2369         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2370         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2371         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2372         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2373         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2374         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2375         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2376         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2377         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2378         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2379         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2380         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2381         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2382         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2383         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2384         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2385
2386 2019-07-10  Tom Tromey  <tromey@adacore.com>
2387
2388         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2389         * breakpoint.c (init_ada_exception_breakpoint): Register as
2390         bp_catchpoint.
2391         (print_one_breakpoint_location, print_one_breakpoint): Use
2392         is_ada_exception_catchpoint.
2393         * ada-lang.c (class ada_catchpoint_location): Pass
2394         bp_loc_software_breakpoint to bp_location constructor.
2395         (is_ada_exception_catchpoint): New function.
2396
2397 2019-07-10  Tom Tromey  <tromey@adacore.com>
2398
2399         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2400         VEC.
2401         (struct arm_exidx_entry): New method operator<.
2402         (struct arm_exidx_data) <section_maps>: Change type.
2403         (arm_exidx_data_free): Remove.
2404         (arm_exidx_data_key): Change type.  Move lower.
2405         (arm_exidx_new_objfile): Update.
2406         (arm_compare_exidx_entries): Remove.
2407         (arm_find_exidx_entry, _initialize_arm_tdep)
2408
2409 2019-07-10  Tom Tromey  <tromey@adacore.com>
2410
2411         * solib-spu.c (ocl_program_data_key): Change type.
2412         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2413         Update.
2414
2415 2019-07-10  Tom Tromey  <tromey@adacore.com>
2416
2417         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2418         (struct solib_aix_inferior_data) <library_list>: Change type.
2419         (solib_aix_inferior_data_handle): Change type.
2420         (get_solib_aix_inferior_data): Update.
2421         (solib_aix_free_library_list): Remove.
2422         (library_list_start_library): Update.
2423         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2424         return type.
2425         (solib_aix_get_library_list)
2426         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2427         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2428
2429 2019-07-10  Tom Tromey  <tromey@adacore.com>
2430
2431         * solib-dsbt.c (struct dsbt_info): Add initializers.
2432         (solib_dsbt_pspace_data): Change type.
2433         (dsbt_pspace_data_cleanup): Remove.
2434         (get_dsbt_info, _initialize_dsbt_solib): Update.
2435
2436 2019-07-10  Tom Tromey  <tromey@adacore.com>
2437
2438         * spu-tdep.c (spu_overlay_data): Change type.
2439         (spu_get_overlay_table, spu_overlay_new_objfile)
2440         (_initialize_spu_tdep): Update.
2441
2442 2019-07-10  Tom Tromey  <tromey@adacore.com>
2443
2444         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2445         destructor.
2446         (dbx_objfile_data_key): Change type and declare later.
2447         (DBX_SYMFILE_INFO): Rewrite.
2448         * dbxread.c (dbx_objfile_data_key): Change type.
2449         (dbx_symfile_init): Update.
2450         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2451         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2452         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2453
2454 2019-07-10  Tom Tromey  <tromey@adacore.com>
2455
2456         * jit.c (jit_program_space_key): Change type.  Move lower.
2457         (get_jit_program_space_data): Update.
2458         (jit_program_space_data_cleanup): Remove.
2459         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2460         Update.
2461         (struct jit_program_space_data): Add initializers.
2462
2463 2019-07-10  Tom Tromey  <tromey@adacore.com>
2464
2465         * solib-darwin.c (struct darwin_info): Add initializers.
2466         (solib_darwin_pspace_data): Change type.
2467         (darwin_pspace_data_cleanup): Remove.
2468         (get_darwin_info, _initialize_darwin_solib): Update.
2469
2470 2019-07-10  Tom Tromey  <tromey@adacore.com>
2471
2472         * remote-sim.c (struct sim_inferior_data): Add initializers,
2473         constructor, and destructor.
2474         (sim_inferior_data_key): Change type.  Move lower.
2475         (check_for_duplicate_sim_descriptor): Update.
2476         (get_sim_inferior_data): Use new.  Update.
2477         (~sim_inferior_data_cleanup): Rename from
2478         sim_inferior_data_cleanup.  Simplify.
2479         (gdbsim_close_inferior, simulator_command)
2480         (sim_command_completer, _initialize_remote_sim): Update.
2481         (next_pid, INITIAL_PID): Move earlier.
2482
2483 2019-07-10  Tom Tromey  <tromey@adacore.com>
2484
2485         * python/python-internal.h (create_thread_object): Return
2486         gdbpy_ref.
2487         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2488         * python/py-inferior.c (struct threadlist_entry): Add
2489         constructor.
2490         <thread_obj>: Now a gdbpy_ref.
2491         (thread_to_thread_object): Update.
2492         (add_thread_object): Use new.
2493         (delete_thread_object): Use delete.
2494         (infpy_threads): Update.
2495         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2496         GIL.
2497
2498 2019-07-10  Tom Tromey  <tromey@adacore.com>
2499
2500         * valops.c (value_cast): Specialize error message for Ada.
2501
2502 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2503
2504         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2505
2506 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2507
2508         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2509         bpstat_should_step): Return bool, adjust comments.
2510         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2511         bpstat_should_step): Likewise.
2512
2513 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2514
2515         * features/Makefile: Use feature target descriptions for Arm.
2516         * features/arm/arm-core.c: Generate new file.
2517         * features/arm/arm-fpa.c: Likewise.
2518         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2519         * features/arm/arm-m-profile.c: Likewise.
2520         * features/arm/arm-vfpv2.c: Likewise.
2521         * features/arm/arm-vfpv3.c: Likewise.
2522         * features/arm/xscale-iwmmxt.c: Likewise.
2523         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2524
2525 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2526
2527         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2528         ptrace earlier.
2529
2530 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2531
2532         * features/aarch64-pauth.c: Regenerate.
2533
2534 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2535
2536         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2537         bool.
2538         (bpstat_what): Use false instead of 0.
2539
2540 2019-07-09  Pedro Alves  <palves@redhat.com>
2541
2542         * break-catch-throw.c (is_exception_catchpoint): New.
2543         * breakpoint.c (print_one_breakpoint_location): New parameter
2544         'raw_loc'.  Handle it.  Use
2545         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2546         looking at the breakpoint's type.
2547         (print_one_breakpoint): If handling "maint info breakpoints", also
2548         print locations of exception catchpoints.
2549         * breakpoint.h (is_exception_catchpoint): Declare.
2550
2551 2019-07-09  Pedro Alves  <palves@redhat.com>
2552
2553         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2554         "addr" field.
2555         (allocate_location_exception_catchpoint): New.
2556         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2557         (initialize_throw_catchpoint_ops): Install
2558         allocate_location_exception_catchpoint as allocate_location
2559         method.
2560         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2561         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2562         bp_loc_other.
2563         (breakpoint_address_is_meaningful): Delete.
2564         (bl_address_is_meaningful): New.
2565         (breakpoint_locations_match): Adjust comment.
2566         (bp_location_from_bp_type): New, factored out of...
2567         (bp_location::bp_location(breakpoint *)): ... this.
2568         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2569         factored out of...
2570         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2571         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2572         breakpoint_address_is_meaningful.
2573         (bp_locations_compare): Adjust comment.
2574         (update_global_location_list): Use bl_address_is_meaningful
2575         instead of breakpoint_address_is_meaningful.
2576         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2577         explicit.
2578         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2579         * python/py-breakpoint.c (bppy_get_location): No longer check
2580         whether location is null.
2581
2582 2019-07-09  Pedro Alves  <palves@redhat.com>
2583
2584         PR c++/15468
2585         * breakpoint.c (print_one_breakpoint_location): Remove
2586         single-location assert.
2587
2588 2019-07-09  Tom Tromey  <tom@tromey.com>
2589
2590         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2591         * configure: Rebuild.
2592         * configure.ac: Change common to gdbsupport.
2593         * gdbsupport: Rename from common.
2594         * acinclude.m4: Change common to gdbsupport.
2595         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2596         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2597         gdbsupport.
2598         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2599         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2600         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2601         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2602         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2603         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2604         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2605         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2606         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2607         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2608         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2609         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2610         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2611         coff-pe-read.c, command.h, compile/compile-c-support.c,
2612         compile/compile-c.h, compile/compile-cplus-symbols.c,
2613         compile/compile-cplus-types.c, compile/compile-cplus.h,
2614         compile/compile-loc2c.c, compile/compile.c, completer.c,
2615         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2616         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2617         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2618         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2619         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2620         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2621         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2622         features/aarch64-core.c, features/aarch64-fpu.c,
2623         features/aarch64-pauth.c, features/aarch64-sve.c,
2624         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2625         features/i386/32bit-core.c, features/i386/32bit-linux.c,
2626         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2627         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2628         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2629         features/i386/64bit-core.c, features/i386/64bit-linux.c,
2630         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2631         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2632         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2633         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2634         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2635         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2636         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2637         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2638         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2639         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2640         go32-nat.c, guile/guile.c, guile/scm-ports.c,
2641         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2642         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2643         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2644         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2645         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2646         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2647         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2648         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2649         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2650         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2651         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2652         minsyms.c, mips-linux-tdep.c, namespace.h,
2653         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2654         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2655         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2656         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2657         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2658         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2659         nat/linux-waitpid.c, nat/mips-linux-watch.c,
2660         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2661         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2662         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2663         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2664         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2665         procfs.c, producer.c, progspace.h, psymtab.h,
2666         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2667         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2668         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2669         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2670         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2671         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2672         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2673         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2674         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2675         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2676         target-memory.c, target.c, target.h, target/waitstatus.c,
2677         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2678         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2679         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2680         unittests/array-view-selftests.c,
2681         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2682         unittests/common-utils-selftests.c,
2683         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2684         unittests/format_pieces-selftests.c,
2685         unittests/function-view-selftests.c,
2686         unittests/lookup_name_info-selftests.c,
2687         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2688         unittests/mkdir-recursive-selftests.c,
2689         unittests/observable-selftests.c,
2690         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2691         unittests/parse-connection-spec-selftests.c,
2692         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2693         unittests/scoped_fd-selftests.c,
2694         unittests/scoped_mmap-selftests.c,
2695         unittests/scoped_restore-selftests.c,
2696         unittests/string_view-selftests.c, unittests/style-selftests.c,
2697         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2698         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2699         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2700         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2701         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2702         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2703
2704 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * linespec.c (decode_digits_list_mode): Set explicit_line to a
2707         bool value.
2708         (decode_digits_ordinary): Set explicit_line field in sal.
2709         * symtab.c (skip_prologue_sal): Don't skip prologue for a
2710         symtab_and_line that was set on an explicit line number in
2711         assembler code.  Do always update the recorded symtab and line if
2712         we do skip the prologue.
2713
2714 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2715
2716         * breakpoint.c (set_breakpoint_location_function): Remove
2717         explicit_loc parameter.
2718         (momentary_breakpoint_from_master): Update call to
2719         set_breakpoint_location_function.
2720         (add_location_to_breakpoint): Likewise.
2721
2722 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2723
2724         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2725         required features based on default bfd type when no specific bfd
2726         is present.
2727
2728 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2729
2730         * NEWS: Mention that GDB printf and eval commands can now print
2731         C-style and Ada-style convenience var strings without
2732         calling the inferior.
2733         * printcmd.c (printf_c_string): Locally print GDB internal var
2734         instead of transiting via the inferior.
2735         (printf_wide_c_string): Likewise.
2736
2737 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2738
2739         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2740
2741 2019-07-04  Tom Tromey  <tom@tromey.com>
2742
2743         PR tui/24724:
2744         * tui/tui-winsource.c (tui_clear_source_content): Update.
2745         (tui_source_window_base::set_is_exec_point_at): Fix comment.
2746         (tui_update_breakpoint_info): Update.
2747         (tui_set_exec_info_content): Update.
2748         * tui/tui-source.c (tui_set_source_content_nil): Update.
2749         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2750         has_break.
2751         * tui/tui-data.h (enum tui_bp_flag): New.
2752         (tui_bp_flags): New enum flags type.
2753         (struct tui_source_element) <break_mode>: Change type.  Rename
2754         from has_break.
2755         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2756         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
2757         constants.
2758         * tui/tui-winsource.h: Fix comment.
2759
2760 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2761
2762         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2763         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2764         (store_fpregs_to_thread)
2765         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2766         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2767         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2768         (IWMMXT_REGS_SIZE): Add define.
2769         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2770         (fetch_vfp_regs, store_vfp_regs)
2771         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2772         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2773
2774 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2775
2776         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2777         defines.
2778         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2779         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2780         (ARM_INT_REGISTER_SIZE): ...to this.
2781         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2782         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2783         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2784         (arm_linux_collect_gregset, supply_nwfpe_register)
2785         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2786         defines.
2787         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2788         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2789         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2790         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2791         (arm_return_in_memory, arm_store_return_value)
2792         (arm_get_longjmp_target, arm_register_g_packet_guesses)
2793         (arm_record_ld_st_multiple): Likewise.
2794         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2795         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2796
2797 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2798
2799         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2800         AARCH64_DISPLACED_MODIFIED_INSNS.
2801         * aarch64-tdep.c (struct aarch64_displaced_step_data)
2802         (aarch64_displaced_step_copy_insn): Likewise.
2803         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2804         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2805         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2806         ARM_DISPLACED_MODIFIED_INSNS.
2807         * arm-tdep.c (arm_gdbarch_init): Likewise.
2808         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2809         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2810         (struct arm_displaced_step_closure): Use
2811         ARM_DISPLACED_MODIFIED_INSNS.
2812
2813 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2814
2815         * features/Makefile: Remove unused xml files.
2816         * features/aarch64.xml: Remove.
2817         * features/i386/amd64-avx-avx512-linux.xml: Remove.
2818         * features/i386/amd64-avx-avx512.xml: Remove.
2819         * features/i386/amd64-avx-linux.xml: Remove.
2820         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2821         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2822         * features/i386/amd64-avx-mpx-linux.xml: Remove.
2823         * features/i386/amd64-avx-mpx.xml: Remove.
2824         * features/i386/amd64-avx.xml: Remove.
2825         * features/i386/amd64-linux.xml: Remove.
2826         * features/i386/amd64-mpx-linux.xml: Remove.
2827         * features/i386/amd64-mpx.xml: Remove.
2828         * features/i386/amd64.xml: Remove.
2829         * features/i386/i386-avx-avx512-linux.xml: Remove.
2830         * features/i386/i386-avx-avx512.xml: Remove.
2831         * features/i386/i386-avx-linux.xml: Remove.
2832         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2833         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2834         * features/i386/i386-avx-mpx-linux.xml: Remove.
2835         * features/i386/i386-avx-mpx.xml: Remove.
2836         * features/i386/i386-avx.xml: Remove.
2837         * features/i386/i386-linux.xml: Remove.
2838         * features/i386/i386-mmx-linux.xml: Remove.
2839         * features/i386/i386-mmx.xml: Remove.
2840         * features/i386/i386-mpx-linux.xml: Remove.
2841         * features/i386/i386-mpx.xml: Remove.
2842         * features/i386/i386.xml: Remove.
2843         * features/i386/x32-avx-avx512-linux.xml: Remove.
2844         * features/i386/x32-avx-linux.xml: Remove.
2845         * features/i386/x32-linux.xml: Remove.
2846
2847 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * regformats/aarch64.dat: Remove.
2850         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2851         * regformats/i386/amd64-avx-linux.dat: Remove.
2852         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2853         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2854         * regformats/i386/amd64-linux.dat: Remove.
2855         * regformats/i386/amd64-mpx-linux.dat: Remove.
2856         * regformats/i386/amd64.dat: Remove.
2857         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2858         * regformats/i386/i386-avx-linux.dat: Remove.
2859         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2860         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2861         * regformats/i386/i386-linux.dat: Remove.
2862         * regformats/i386/i386-mmx-linux.dat: Remove.
2863         * regformats/i386/i386-mpx-linux.dat: Remove.
2864         * regformats/i386/i386.dat: Remove.
2865         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2866         * regformats/i386/x32-avx-linux.dat: Remove.
2867         * regformats/i386/x32-linux.dat: Remove.
2868
2869 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
2870
2871         * aarch64-tdep.c: Remove xml self tests.
2872         * amd64-linux-tdep.c: Likewise.
2873         * amd64-tdep.c: Likewise.
2874         * i386-linux-tdep.c: Likewise.
2875         * i386-tdep.c: Likewise.
2876
2877 2019-07-03  Pedro Alves  <palves@redhat.com>
2878
2879         PR cli/24732
2880         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2881         (pipe_cmd_option_defs): New.
2882         (make_pipe_cmd_options_def_group): New.
2883         (pipe_command): Use gdb::option::process_options.
2884         (pipe_command_completer): New function.
2885         (_initialize_cli_cmds): Install completer for "pipe" command.
2886
2887 2019-07-03  Pedro Alves  <palves@redhat.com>
2888
2889         * cli/cli-option.c (union option_value) <string>: New field.
2890         (struct option_def_and_value): Add ctor, move ctor, dtor and
2891         use DISABLE_COPY_AND_ASSIGN.
2892         (option_def_and_value::clear_value): New.
2893         (parse_option, save_option_value_in_ctx, get_val_type_str)
2894         (add_setshow_cmds_for_options): Handle var_string.
2895         * cli-option.h (union option_def::var_address) <string>: New
2896         field.
2897         (struct string_option_def): New.
2898         * maint-test-options.c (struct test_options_opts): Add default
2899         ctor and use DISABLE_COPY_AND_ASSIGN.
2900         <string_opt>: New field.
2901         (test_options_opts::~test_options_opts): New.
2902         (test_options_opts::dump): Also dump "-string".
2903         (test_options_option_defs): Install "string.
2904
2905 2019-07-03  Pedro Alves  <palves@redhat.com>
2906
2907         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2908         option_value with a null enumeration.
2909         (complete_options): Save the option values in the context.
2910         (save_option_value_in_ctx): New, factored out from ...
2911         (process_options): ... here.
2912         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2913         of the function.
2914         * maint-test-options.c (test_options_opts::dump): New, factored
2915         out from ...
2916         (maintenance_test_options_command_mode): ... here.
2917         (maintenance_test_options_command_completion_result): Delete.
2918         (maintenance_test_options_command_completion_text): Update
2919         comment.
2920         (maintenance_show_test_options_completion_result): Change
2921         prototype.  Just print
2922         maintenance_test_options_command_completion_text.
2923         (save_completion_result): New.
2924         (maintenance_test_options_completer_mode): Pass options context to
2925         complete_options, and then save a dump.
2926         (_initialize_maint_test_options): Use add_cmd to install "maint
2927         show test-options-completion-result".
2928
2929 2019-07-03  Pedro Alves  <palves@redhat.com>
2930
2931         * NEWS (New commands): Mention "with" and "maint with".
2932         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2933         (with_command, with_command_completer): New.
2934         (pipe_command): Adjust to new repeat_previous
2935         interface.
2936         (_initialize_cli_cmds): Install the "with" command and its "w"
2937         alias.
2938         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2939         declarations.
2940         * cli/cli-setshow.c (parse_cli_var_uinteger)
2941         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2942         argument strings for all var_types.
2943         (get_setshow_command_value_string): New, factored out from ...
2944         (do_show_command): ... this.
2945         * cli/cli-setshow.h: Include <string>.
2946         (get_setshow_command_value_string): Declare.
2947         * command.h (repeat_previous): Now returns const char *.  Adjust
2948         comment.
2949         * maint.c: Include "cli/cli-cmds.h".
2950         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2951         (_initialize_maint_cmds): Register the "maintenance with" command.
2952         * top.c (repeat_previous): Move bits from pipe_command here:
2953         Return the saved command line, if any; error out if there's no
2954         command to relaunch.
2955
2956 2019-07-03  Pedro Alves  <palves@redhat.com>
2957
2958         * NEWS (New commands): Mention "maint set/show test-settings"
2959         instead of "maint test-settings".
2960         * maint-test-settings.c (maintenance_test_settings_list): Delete.
2961         (maintenance_test_settings_set_list): Rename to ...
2962         (maintenance_set_test_settings_list): ... this.
2963         (maintenance_test_settings_show_list): Rename to  ...
2964         (maintenance_show_test_settings_list): ... this.
2965         (maintenance_test_settings_cmd): Delete.
2966         (maintenance_test_settings_set_cmd): ...
2967         (maintenance_set_test_settings_cmd): ... this.
2968         (maintenance_test_settings_show_cmd): ...
2969         (maintenance_show_test_settings_cmd): ... this.
2970         (maintenance_test_settings_show_value_cmd):
2971         (maintenance_show_test_settings_value_cmd): ... this.
2972         (_initialize_maint_test_settings): No longer install the "maint
2973         test-settings" prefix command.  Rename "maint test-settings set"
2974         to "maint set test-settings", and "maint test-settings show" to
2975         "maint show test-settings".  Adjust all subcommands.
2976
2977 2019-07-03  Pedro Alves  <palves@redhat.com>
2978
2979         * maint-test-settings.c: Fix file's intro comment.  Replace all
2980         references to "test-options" with references to "test-settings",
2981         in comments.
2982
2983 2019-07-03  Pedro Alves  <palves@redhat.com>
2984
2985         * maint-test-settings.c (maintenance_test_settings_xxx)
2986         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2987         New.
2988         (maintenance_test_settings_enums): Use them.
2989         (maintenance_test_settings_enum): Default to
2990         maintenance_test_settings_xxx.
2991         (_initialize_maint_test_settings): Initialize
2992         MAINTENANCE_TEST_SETTINGS_FILENAME.
2993
2994 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
2995
2996         * breakpoint.h (remove_breakpoints_inf): Change return type to
2997         void, move function documentation here.
2998         * breakpoint.c (remove_breakpoints_inf): Change return type to
2999         void, move function documentation to header.
3000
3001 2019-07-02  Pedro Alves  <palves@redhat.com>
3002
3003         * NEWS (Completion improvements): Mention "info threads".
3004         * thread.c (struct info_threads_opts, info_threads_option_defs)
3005         (make_info_threads_options_def_group): New.
3006         (info_threads_command): Use gdb::option::process_options.
3007         (info_threads_command_completer): New.
3008         (_initialize_thread): Use gdb::option::build_help to build the
3009         help text for "info threads".
3010
3011 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3012
3013         * defs.h (generic_load): Move from here...
3014         * symfile.h (generic_load): ... to here.  Rename name parameter
3015         to args.
3016         * symfile.c (generic_load): Add comment.
3017
3018 2019-07-01  Tom Tromey  <tromey@adacore.com>
3019
3020         * dwarf2read.c
3021         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3022         declaration of without_params.  Fix formatting.
3023
3024 2019-07-01  Tom Tromey  <tromey@adacore.com>
3025
3026         * ada-exp.y (find_primitive_type): Update.
3027         * ada-lang.h (ada_lookup_symbol): Update.
3028         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3029         parameter.
3030         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3031
3032 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3033
3034         PR breakpoints/24541
3035         * gdbarch.c: Regenerate.
3036         * gdbarch.h: Regenerate.
3037         * gdbarch.sh: Add 'stap_adjust_register'.
3038         * i386-tdep.c: Include '<unordered_set>'.
3039         (i386_stap_adjust_register): New function.
3040         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3041         * stap-probe.c (stap_parse_register_operand): Call
3042         'gdbarch_stap_adjust_register'.
3043
3044 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3045
3046         PR python/24742
3047         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3048         * python/python.c (do_start_initialization): Use 'xmalloc'
3049         instead of 'PyMem_Malloc'.
3050
3051 2019-06-28  Tom Tromey  <tromey@adacore.com>
3052
3053         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3054         for Ada.
3055
3056 2019-06-27  Tom Tromey  <tromey@adacore.com>
3057
3058         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3059         objfile_key.
3060         (arm_find_mapping_symbol, arm_record_special_symbol)
3061         (_initialize_arm_tdep): Update.
3062         (arm_objfile_data_free): Remove.
3063
3064 2019-06-27  Tom Tromey  <tromey@adacore.com>
3065
3066         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3067         to cp_print_static_field.
3068
3069 2019-06-26  Tom Tromey  <tromey@adacore.com>
3070
3071         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3072         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3073         declare.
3074
3075 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3076
3077         * features/aarch64-core.c (create_feature_aarch64_core):
3078         Regenerate.
3079         * features/aarch64-core.xml: Add cpsr flags.
3080
3081 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3082
3083         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3084         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3085
3086 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3087
3088         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3089         field.
3090         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3091         use.
3092         (arm_record_special_symbol): Don't insert new symbol in sorted
3093         position, push it at the end.
3094
3095 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3096
3097         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3098         (arm_mapping_symbol_s): Remove.
3099         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3100         (arm_mapping_symbol_vec): New typedef.
3101         (struct arm_per_objfile): Add constructor.
3102         <section_maps>: Change type to
3103         std::unique_ptr<arm_mapping_symbol_vec[]>.
3104         (arm_compare_mapping_symbols): Remove.
3105         (arm_find_mapping_symbol): Adjust to section_maps type change.
3106         (arm_objfile_data_free): Call delete on arm_per_objfile.
3107         (arm_record_special_symbol): Adjust to section_maps type change.
3108         Allocate arm_per_objfile with new.
3109
3110 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3111
3112         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3113         with the command prefix.
3114
3115 2019-06-25  Tom Tromey  <tom@tromey.com>
3116
3117         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3118         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3119
3120 2019-06-25  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3123         type.
3124         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3125         protected.
3126
3127 2019-06-25  Tom Tromey  <tom@tromey.com>
3128
3129         * tui/tui-winsource.c
3130         (tui_source_window_base::set_is_exec_point_at): Add check against
3131         LOA_ADDRESS.
3132
3133 2019-06-25  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-source.c (tui_set_source_content): Don't check before
3136         xfree.
3137         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3138
3139 2019-06-25  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-winsource.h (tui_update_source_window_as_is)
3142         (tui_alloc_source_buffer, tui_line_is_displayed)
3143         (tui_addr_is_displayed): Change type of win_info.
3144         * tui/tui-winsource.c (tui_update_source_window_as_is)
3145         (tui_clear_source_content, tui_show_source_line)
3146         (tui_show_source_content, tui_source_window_base::refill)
3147         (tui_source_window_base::set_is_exec_point_at)
3148         (tui_source_window_base::set_is_exec_point_at)
3149         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3150         (tui_alloc_source_buffer, tui_line_is_displayed)
3151         (tui_addr_is_displayed): Change type of win_info.  Update.
3152         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3153         (tui_source_window_base::do_make_visible_with_new_height):
3154         Update.
3155         * tui/tui-source.c (tui_set_source_content)
3156         (tui_set_source_content_nil)
3157         (tui_source_window::do_scroll_vertical): Update.
3158         * tui/tui-layout.c (show_layout): Update.
3159         * tui/tui-disasm.c (tui_set_disassem_content)
3160         (tui_disasm_window::do_scroll_vertical): Update.
3161         * tui/tui-data.h (tui_win_content): Remove.
3162         (struct tui_gen_win_info) <content, content_size>: Remove.
3163         (struct tui_source_element): Add initializers and destructor.
3164         (union tui_which_element, struct tui_win_element): Remove.
3165         (struct tui_source_window_base) <content>: New field.
3166         (struct tui_data_window): Remove destructor.
3167         (tui_alloc_content, tui_free_win_content)
3168         (tui_free_all_source_wins_content): Don't declare.
3169         * tui/tui-data.c (tui_initialize_static_data): Update.
3170         (init_content_element, tui_alloc_content): Remove.
3171         (~tui_gen_win_info): Update.
3172         (~tui_data_window, tui_free_all_source_wins_content)
3173         (tui_free_win_content, free_content, free_content_elements):
3174         Remove.
3175
3176 2019-06-25  Tom Tromey  <tom@tromey.com>
3177
3178         * tui/tui-winsource.h (tui_clear_source_content)
3179         (tui_erase_source_content, tui_show_source_content): Change type
3180         of win_info.
3181         * tui/tui-winsource.c (tui_clear_source_content)
3182         (tui_erase_source_content, tui_show_source_content): Change type
3183         of win_info.
3184         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3185         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3186         win_info.
3187         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3188         win_info.
3189         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3190
3191 2019-06-25  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-winsource.c (tui_clear_source_content)
3194         (tui_source_window_base::set_is_exec_point_at): Update.
3195         * tui/tui-source.c (tui_set_source_content_nil): Update.
3196         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3197         a bool.
3198         * tui/tui-data.c (init_content_element): Update.
3199
3200 2019-06-25  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3203         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3204         * tui/tui-layout.c (init_and_make_win): Update.
3205         * tui/tui.h (enum tui_win_type): Update.
3206         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3207         tui_win_is_auxillary.
3208         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3209         tui_win_is_auxillary.
3210
3211 2019-06-25  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3214         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3215         (tui_delete_data_content_windows, tui_display_all_data)
3216         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3217         Update.
3218         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3219         * tui/tui-regs.c (tui_last_regs_line_no)
3220         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3221         (tui_show_registers): Update.
3222         (tui_show_register_group): Return void.  Update.
3223         (tui_display_registers_from, tui_display_reg_element_at_line)
3224         (tui_display_registers_from_line, tui_check_register_values):
3225         Update.
3226         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3227         member.
3228         (struct tui_data_window) <regs_content>: Now a std::vector.
3229         <regs_content_count>: Remove.
3230         (tui_add_content_elements, tui_free_data_content): Don't declare.
3231         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3232         (init_content_element): Remove DATA_WIN case.  Add assert.
3233         (tui_add_content_elements): Remove.
3234         (tui_data_window): Update.
3235         (tui_free_data_content): Remove.
3236         (free_content_elements): Remove DATA_WIN case.
3237
3238 2019-06-25  Tom Tromey  <tom@tromey.com>
3239
3240         * tui/tui-data.c (tui_data_item_window): Update.
3241         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3242         * tui/tui-windata.c (tui_display_all_data)
3243         (tui_display_data_from_line): Update.
3244         (tui_check_data_values): Remove.
3245         * tui/tui-regs.c (tui_show_register_group)
3246         (tui_display_reg_element_at_line): Update.
3247         * tui/tui-hooks.c (tui_register_changed)
3248         (tui_refresh_frame_and_register_information): Call
3249         tui_check_register_values.
3250         * tui/tui-data.h (struct tui_data_window) <data_content,
3251         data_content_count, data_type>: Remove.
3252         (enum tui_data_type): Remove.
3253
3254         * tui/tui-data.c (tui_data_window::clear_detail)
3255         (~tui_data_window): Update.
3256
3257 2019-06-25  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3260         declare.
3261         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3262         Rename from tui_first_data_item_displayed.  Update.
3263         (tui_data_window::refresh_all)
3264         (tui_data_window::do_scroll_vertical): Update.
3265         * tui/tui-data.h (struct tui_data_window)
3266         <first_data_item_displayed>: Declare new method.
3267
3268 2019-06-25  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3271         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3272         contents...
3273         (tui_initialize_static_data): ...here.
3274
3275 2019-06-25  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3278         (tui_display_registers_from, tui_check_register_values): Update.
3279         (tui_display_register): Remove win_info parameter; update.
3280         (tui_get_register): Change type of parameters.
3281         * tui/tui-data.h (struct tui_data_element): Remove.
3282         (union tui_which_element) <data>: Remove.
3283         <data_window>: Change type.
3284         (struct tui_data_item_window): New.
3285         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3286         case.  Add assert.
3287         (~tui_data_item_window): New destructor.
3288         (free_content_elements): Remove DATA_ITEM_WIN case.
3289
3290 2019-06-25  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3293         Remove.
3294
3295 2019-06-25  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-data.h (struct tui_command_element): Remove.
3298         (union tui_which_element) <command>: Remove.
3299         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3300         assert.
3301         (free_content_elements): Remove CMD_WIN case.
3302
3303 2019-06-25  Tom Tromey  <tom@tromey.com>
3304
3305         * tui/tui-layout.c (tui_set_layout): Update.
3306         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3307         * tui/tui-data.c (layout_def): Update.
3308
3309 2019-06-25  Tom Tromey  <tom@tromey.com>
3310
3311         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3312         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3313         (tui_source_window_base::set_new_height): Update.
3314         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3315         Update.
3316         (tui_set_locator_fullname, tui_set_locator_info)
3317         (tui_show_frame_info): Update.
3318         * tui/tui-source.c (tui_set_source_content)
3319         (tui_source_is_displayed): Update.
3320         * tui/tui-layout.c (show_source_disasm_command, show_data)
3321         (show_source_or_disasm_and_command): Update.
3322         * tui/tui-disasm.c (tui_set_disassem_content)
3323         (tui_get_begin_asm_address): Update.
3324         * tui/tui-data.h (struct tui_locator_element): Remove.
3325         (union tui_which_element) <locator>: Remove.
3326         (struct tui_locator_window): New.
3327         (tui_locator_win_info_ptr): Change return type.
3328         * tui/tui-data.c (_locator): Change type.
3329         (tui_locator_win_info_ptr): Change return type.
3330         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3331         (tui_alloc_content): Add assert.
3332
3333 2019-06-25  Tom Tromey  <tom@tromey.com>
3334
3335         * tui/tui-winsource.c
3336         (tui_exec_info_window::maybe_allocate_content): New method.
3337         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3338         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3339         (make_source_or_disasm_window): Add cast.
3340         * tui/tui-data.h (union tui_which_element) <simple_string>:
3341         Remove.
3342         (struct tui_source_info): New.
3343         (struct tui_source_window_base) <execution_info>: Change type.
3344         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3345         case, and add assert.
3346         (tui_alloc_content): Add assert.
3347
3348 2019-06-25  Tom Tromey  <tom@tromey.com>
3349
3350         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3351         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3352         * tui/tui-data.c (tui_alloc_win_info): Remove.
3353
3354 2019-06-25  Tom Tromey  <tom@tromey.com>
3355
3356         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3357         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3358         can_highlight.
3359
3360 2019-06-25  Tom Tromey  <tom@tromey.com>
3361
3362         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3363         make_visible_with_new_height method.
3364         (tui_win_info::make_visible_with_new_height): New method.
3365         (tui_source_window_base::do_make_visible_with_new_height)
3366         (tui_data_window::do_make_visible_with_new_height)
3367         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3368         (make_visible_with_new_height): Remove.
3369         (tui_resize_all, tui_adjust_win_heights): Use
3370         make_visible_with_new_height method.
3371         * tui/tui-data.h (struct tui_win_info)
3372         <do_make_visible_with_new_height, make_visible_with_new_height>:
3373         New methods.
3374         (struct tui_source_window_base, struct tui_data_window)
3375         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3376         methods.
3377
3378 2019-06-25  Tom Tromey  <tom@tromey.com>
3379
3380         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3381         method.
3382         (update_tab_width): Call update_tab_width method.
3383         * tui/tui-data.h (struct tui_win_info)
3384         (struct tui_source_window_base) <update_tab_width>: New methods.
3385
3386 2019-06-25  Tom Tromey  <tom@tromey.com>
3387
3388         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3389         parameter.
3390         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3391         parameter.
3392         (tui_gen_win_info::make_visible): Update.
3393         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3394         parameter.
3395         * tui/tui-data.h (enum tui_box): New enum.
3396         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3397
3398 2019-06-25  Tom Tromey  <tom@tromey.com>
3399
3400         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3401         init_and_make_win for EXEC_INFO_WIN.
3402         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3403         longer inline.
3404         (struct tui_win_info) <~tui_win_info>: Inline.
3405         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3406         Don't declare.
3407         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3408         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3409         Remove.
3410         (tui_initialize_static_data): Update.
3411         (~tui_gen_win_info): Handle more cleanup here.
3412         (~tui_source_window_base): Delete "execution_info".
3413         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3414
3415 2019-06-25  Tom Tromey  <tom@tromey.com>
3416
3417         * tui/tui-layout.c (make_command_window): Don't set
3418         can_highlight.
3419         (show_source_disasm_command): Call the reset method.
3420         (show_data): Don't set can_highlight.  Call the reset method.
3421         (tui_gen_win_info::reset): Rename from init_gen_win_info
3422         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3423         (show_source_or_disasm_and_command): Call the reset method.
3424         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3425         (struct tui_cmd_window): Set can_highlight.
3426
3427 2019-06-25  Tom Tromey  <tom@tromey.com>
3428
3429         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3430         from make_visible.
3431         (tui_make_visible, tui_make_invisible): Rewrite.
3432         (tui_win_info::make_visible): Remove.
3433         (tui_source_window_base::make_visible): Update.
3434         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3435         method.  Moved from...
3436         (struct tui_win_info) <make_visible>: ...here.
3437
3438 2019-06-25  Tom Tromey  <tom@tromey.com>
3439
3440         * tui/tui-winsource.c
3441         (tui_source_window_base::do_scroll_horizontal): Remove direction
3442         parameter.
3443         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3444         direction parameter.
3445         * tui/tui-win.c (tui_win_info::forward_scroll)
3446         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3447         (tui_win_info::right_scroll): Update.
3448         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3449         direction parameter.
3450         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3451         direction parameter.
3452         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3453         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3454         Remove direction parameter.
3455         (struct tui_source_window_base, struct tui_source_window)
3456         (struct tui_disasm_window, struct tui_data_window)
3457         (struct tui_cmd_window): Update.
3458
3459 2019-06-25  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-winsource.h (tui_set_exec_info_content)
3462         (tui_show_exec_info_content, tui_erase_exec_info_content)
3463         (tui_clear_exec_info_content, tui_update_exec_info): Change
3464         argument to tui_source_window_base.
3465         * tui/tui-winsource.c (tui_set_exec_info_content)
3466         (tui_show_exec_info_content, tui_erase_exec_info_content)
3467         (tui_clear_exec_info_content, tui_update_exec_info): Change
3468         argument to tui_source_window_base.
3469
3470 2019-06-25  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3473         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3474
3475 2019-06-25  Tom Tromey  <tom@tromey.com>
3476
3477         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3478         check.
3479
3480 2019-06-25  Tom Tromey  <tom@tromey.com>
3481
3482         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3483         type to void.
3484         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3485         type to void.
3486         * tui/tui-source.c (tui_set_source_content): Update.
3487         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3488
3489 2019-06-25  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-win.c (window_name_completer, tui_set_focus)
3492         (tui_all_windows_info): Use name method.
3493         * tui/tui-data.h (struct tui_gen_win_info)
3494         (struct tui_source_window, struct tui_disasm_window)
3495         (struct tui_data_window, struct tui_cmd_window) <name>: New
3496         method.
3497         (tui_win_name): Don't declare.
3498         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3499         (tui_win_name): Remove.
3500
3501 2019-06-25  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-winsource.h (tui_update_source_window)
3504         (tui_update_source_window_as_is): Change parameter type.
3505         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3506         to be a tui_source_window_base.
3507         (tui_update_source_window_as_is): Likewise.
3508         * tui/tui-win.c (make_visible_with_new_height): Update.
3509
3510 2019-06-25  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-winsource.c (tui_erase_source_content)
3513         (tui_show_source_content, tui_show_exec_info_content)
3514         (tui_erase_exec_info_content): Use refresh_window method.
3515         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3516         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3517         from tui_refresh_win.
3518         (tui_data_window::refresh_window): New method.
3519         (tui_win_info::refresh, tui_source_window_base::refresh)
3520         (tui_refresh_all): Use refresh_window method.
3521         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3522         method.
3523         * tui/tui-regs.c (tui_display_register): Call refresh_window
3524         method.
3525         * tui/tui-layout.c (show_source_disasm_command)
3526         (show_source_or_disasm_and_command): Call refresh_window method.
3527         * tui/tui-data.h (struct tui_gen_win_info)
3528         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3529         New method.
3530
3531 2019-06-25  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui.c (tui_rl_other_window, tui_enable)
3534         (tui_is_window_visible, tui_get_command_dimension): Update.
3535         * tui/tui-winsource.c (tui_update_source_window_as_is)
3536         (tui_clear_source_content, tui_erase_source_content)
3537         (tui_show_source_line, tui_source_window_base::refill)
3538         (tui_source_window_base::do_scroll_horizontal)
3539         (tui_source_window_base::set_is_exec_point_at)
3540         (tui_update_breakpoint_info, tui_set_exec_info_content)
3541         (tui_alloc_source_buffer, tui_line_is_displayed)
3542         (tui_addr_is_displayed): Update.
3543         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3544         (tui_check_and_display_highlight_if_needed)
3545         (tui_win_info::make_visible, tui_win_info::refresh)
3546         (tui_refresh_all): Update.
3547         * tui/tui-windata.c (tui_first_data_item_displayed)
3548         (tui_delete_data_content_windows, tui_erase_data_content)
3549         (tui_display_all_data, tui_data_window::refresh_all)
3550         (tui_check_data_values): Update.
3551         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3552         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3553         (tui_win_info::backward_scroll, tui_refresh_all_win)
3554         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3555         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3556         (tui_source_window_base::set_new_height)
3557         (tui_data_window::set_new_height)
3558         (make_invisible_and_set_new_height)
3559         (make_visible_with_new_height, new_height_ok)
3560         (parse_scrolling_args): Update.
3561         * tui/tui-stack.c (tui_show_frame_info): Update.
3562         * tui/tui-source.c (tui_set_source_content)
3563         (tui_set_source_content_nil, tui_source_is_displayed)
3564         (tui_source_window::do_scroll_vertical): Update.
3565         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3566         (tui_display_registers_from, tui_display_reg_element_at_line)
3567         (tui_check_register_values, tui_reg_command): Update.
3568         * tui/tui-layout.c (tui_default_win_height)
3569         (show_source_disasm_command, show_data, init_and_make_win)
3570         (show_source_or_disasm_and_command): Update.
3571         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3572         (tui_redisplay_readline, tui_mld_flush)
3573         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3574         (tui_getc): Update.
3575         * tui/tui-disasm.c (tui_set_disassem_content)
3576         (tui_disasm_window::do_scroll_vertical): Update.
3577         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3578         Now virtual.
3579         (struct tui_win_info): Derive from tui_gen_win_info.
3580         <~tui_win_info>: Mark as override.
3581         <generic>: Remove member.
3582         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3583         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3584         (~tui_data_window, ~tui_win_info)
3585         (tui_free_all_source_wins_content): Update.
3586         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3587
3588 2019-06-25  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-layout.c (init_and_make_win): Use new.
3591         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3592         destructor, initializers.
3593         (tui_alloc_generic_win_info): Don't declare.
3594         * tui/tui-data.c (_locator): Add argument to constructor.
3595         (source_win, disasm_win): New globals.
3596         (exec_info): Remove.
3597         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3598         Update.
3599         (tui_alloc_generic_win_info): Remove.
3600         (init_content_element): Use new.
3601         (tui_win_info::tui_win_info): Update.
3602         (free_content_elements) <case DATA_WIN>: Use delete.
3603
3604 2019-06-25  Tom Tromey  <tom@tromey.com>
3605
3606         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3607         * tui/tui-windata.c (tui_first_data_item_displayed)
3608         (tui_delete_data_content_windows): Update.
3609         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3610         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3611         (tui_display_registers_from, tui_check_register_values): Update.
3612         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3613         pointer.
3614         * tui/tui-data.c (init_content_element): Update.  Allocate the new
3615         window.
3616         (tui_free_data_content): Update.
3617         (free_content_elements) <case DATA_WIN>: Free the window.
3618
3619 2019-06-25  Tom Tromey  <tom@tromey.com>
3620
3621         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3622         Update.
3623         * tui/tui-layout.c (make_command_window)
3624         (show_source_disasm_command, show_data, init_and_make_win)
3625         (show_source_or_disasm_and_command): Update.
3626         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3627         method.
3628         <can_highight, is_highlighted>: Now bool.
3629         (tui_set_win_highlight): Don't declare.
3630         * tui/tui-data.c (tui_set_win_highlight): Remove.
3631
3632 2019-06-25  Tom Tromey  <tom@tromey.com>
3633
3634         * tui/tui-wingeneral.c (make_visible): Remove check of window
3635         type.
3636
3637 2019-06-25  Tom Tromey  <tom@tromey.com>
3638
3639         * tui/tui-win.c (tui_win_info::max_height)
3640         (tui_cmd_window::max_height): New methods.
3641         (new_height_ok): Call max_height.
3642         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3643         <max_height>: New method.
3644
3645 2019-06-25  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-win.c (tui_source_window_base::set_new_height)
3648         (tui_data_window::set_new_height): New methods.
3649         (make_invisible_and_set_new_height): Call set_new_height method.
3650         * tui/tui-data.h (struct tui_win_info)
3651         (struct tui_source_window_base, struct tui_data_window)
3652         <set_new_height>: New method.
3653
3654 2019-06-25  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3657         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3658         tui_refresh_data_win.
3659         * tui/tui-win.c (tui_source_window_base::refresh_all): New
3660         method.
3661         (tui_refresh_all_win): Call the refresh_all method.
3662         (tui_set_focus): Likewise.
3663         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3664         (struct tui_source_window_base, struct tui_data_window) <refresh>:
3665         Likewise.
3666
3667 2019-06-25  Tom Tromey  <tom@tromey.com>
3668
3669         * tui/tui-winsource.h (tui_refill_source_window)
3670         (tui_set_is_exec_point_at): Don't declare.
3671         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3672         (tui_source_window_base::refill): Rename from
3673         tui_refill_source_window.
3674         (tui_source_window_base::do_scroll_horizontal): Update.
3675         (tui_source_window_base::set_is_exec_point_at): Rename from
3676         tui_set_is_exec_point_at.
3677         (tui_update_all_breakpoint_info): Update.
3678         * tui/tui-stack.c (tui_show_frame_info): Update.
3679         * tui/tui-layout.c (show_data): Add cast.
3680         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3681         * tui/tui-data.h (struct tui_source_window_base) <refill,
3682         set_is_exec_point_at>: New methods.
3683         (tui_source_windows, tui_add_to_source_windows): Update types.
3684         (tui_add_to_source_windows): Remove redundant declaration.
3685         * tui/tui-data.c (source_windows): Store tui_source_window_base.
3686         (tui_source_windows): Change return type.
3687         (tui_clear_source_windows_detail): Update.
3688         (tui_add_to_source_windows): Change type of parameter.
3689         (tui_free_all_source_wins_content): Update.
3690
3691 2019-06-25  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-wingeneral.c (tui_win_info::refresh)
3694         (tui_source_window_base::refresh): New methods.
3695         (tui_refresh_all): Call the refresh method.
3696         * tui/tui-data.h (struct tui_win_info)
3697         (struct tui_source_window_base) <refresh>: New method.
3698
3699 2019-06-25  Tom Tromey  <tom@tromey.com>
3700
3701         * tui/tui.h (tui_is_window_visible): Return bool.
3702         * tui/tui.c (tui_is_window_visible): Return bool.
3703         * tui/tui-wingeneral.c (tui_make_window, make_visible)
3704         (tui_make_visible, tui_make_invisible)
3705         (tui_win_info::make_visible)
3706         (tui_source_window_base::make_visible, make_all_visible)
3707         (tui_make_all_visible, tui_make_all_invisible): Update.
3708         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3709         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3710         bool.
3711         (struct tui_win_info, struct tui_source_window_base)
3712         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3713         * tui/tui-data.c (tui_init_generic_part): Update.
3714
3715 2019-06-25  Tom Tromey  <tom@tromey.com>
3716
3717         * tui/tui-wingeneral.c (tui_win_info::make_visible)
3718         (tui_source_window_base::make_visible): New methods.
3719         (make_all_visible): Make method call.
3720         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3721         (struct tui_source_window_base, struct tui_cmd_window): Override
3722         make_visible.
3723         (tui_win_is_source_type): Don't declare.
3724         * tui/tui-data.c (tui_win_is_source_type): Remove.
3725
3726 2019-06-25  Tom Tromey  <tom@tromey.com>
3727
3728         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3729         NULL check.
3730
3731 2019-06-25  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3734         Inline constructor.  Add initializers for members.
3735         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3736         constructors; now inline in class.
3737
3738 2019-06-25  Tom Tromey  <tom@tromey.com>
3739
3740         * tui/tui-regs.c (tui_show_registers): Update.
3741         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3742         bool.
3743         * tui/tui-data.c (tui_data_window::clear_detail)
3744         (tui_data_window): Update.
3745
3746 2019-06-25  Tom Tromey  <tom@tromey.com>
3747
3748         * tui/tui-windata.c (tui_display_all_data)
3749         (tui_display_data_from_line, tui_display_data_from)
3750         (tui_check_data_values, tui_data_window::do_scroll_vertical):
3751         Update.
3752         * tui/tui-regs.c (tui_last_regs_line_no)
3753         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3754         (tui_show_registers, tui_show_register_group)
3755         (tui_display_registers_from, tui_display_reg_element_at_line)
3756         (tui_display_registers_from_line, tui_check_register_values)
3757         (tui_reg_next, tui_reg_prev): Update.
3758         * tui/tui-layout.c (tui_set_layout, show_data): Update.
3759         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
3760         tui_data_window.
3761         (struct tui_win_info) <detail>: Remove.  Add new fields from
3762         tui_data_info.
3763         (TUI_DATA_WIN): Add cast.
3764         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3765         (~tui_data_window): Simplify.
3766
3767 2019-06-25  Tom Tromey  <tom@tromey.com>
3768
3769         * tui/tui-layout.c (show_source_disasm_command)
3770         (show_source_or_disasm_and_command): Update.
3771         * tui/tui-io.c (update_cmdwin_start_line)
3772         (tui_redisplay_readline): Update.
3773         * tui/tui-data.h (struct tui_command_info): Remove.
3774         (struct tui_win_info) <detail>: Remove command_info member.
3775         (struct tui_data_window) <start_line>: New member, from
3776         tui_command_info.
3777         (TUI_CMD_WIN): Add casts.
3778
3779 2019-06-25  Tom Tromey  <tom@tromey.com>
3780
3781         * tui/tui-winsource.c (tui_update_source_window)
3782         (tui_refill_source_window)
3783         (tui_source_window_base::do_scroll_horizontal)
3784         (tui_update_breakpoint_info, tui_set_exec_info_content)
3785         (tui_show_exec_info_content, tui_erase_exec_info_content)
3786         (tui_clear_exec_info_content): Update.
3787         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3788         Update.
3789         * tui/tui-win.c (make_invisible_and_set_new_height)
3790         (make_visible_with_new_height): Update.
3791         * tui/tui-source.c (tui_set_source_content)
3792         (tui_show_symtab_source): Update.
3793         * tui/tui-layout.c (extract_display_start_addr)
3794         (show_source_disasm_command, show_data)
3795         (make_source_or_disasm_window)
3796         (show_source_or_disasm_and_command): Update.
3797         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3798         (tui_disasm_window::do_scroll_vertical): Remove shadowing
3799         "gdbarch".
3800         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
3801         to tui_source_window_base.
3802         (struct tui_win_info) <detail>: Remove source_info member.
3803         (struct tui_source_window_base) <has_locator>: Inline.
3804         Move contents from tui_source_info; rename has_locator member to
3805         m_has_locator.
3806         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3807         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3808         header file.
3809         (tui_source_window_base::clear_detail, ~tui_source_window_base):
3810         Simplify.
3811         (tui_free_all_source_wins_content): Cast to
3812         tui_source_window_base.
3813
3814 2019-06-25  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-win.c (make_invisible_and_set_new_height)
3817         (make_visible_with_new_height): Call has_locator method.
3818         * tui/tui-layout.c (show_source_disasm_command, show_data)
3819         (show_source_or_disasm_and_command): Update for bool change.
3820         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3821         (tui_win_info) <has_locator>: New method.
3822         (struct tui_source_window_base) <has_locator>: New method.
3823         (tui_win_has_locator): Don't declare.
3824         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3825         from tui_win_has_locator.
3826         (tui_source_window_base): Use false, not FALSE.
3827
3828 2019-06-25  Tom Tromey  <tom@tromey.com>
3829
3830         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3831         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3832         clear_detail method directly.
3833         (tui_clear_win_detail): Remove.
3834
3835 2019-06-25  Tom Tromey  <tom@tromey.com>
3836
3837         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3838         "this", not TUI_DISASM_WIN.
3839
3840 2019-06-25  Tom Tromey  <tom@tromey.com>
3841
3842         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
3843         declare.
3844         * tui/tui-winsource.c
3845         (tui_source_window_base::do_scroll_horizontal): Rename from
3846         tui_horizontal_source_scroll.
3847         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3848         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3849         from tui_vertical_data_scroll.
3850         * tui/tui-win.h (tui_scroll): Don't declare.
3851         * tui/tui-win.c (tui_win_info::forward_scroll)
3852         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3853         (tui_win_info::right_scroll): Rename and update.
3854         (tui_scroll_forward_command, tui_scroll_backward_command)
3855         (tui_scroll_left_command, tui_scroll_right_command): Update.
3856         (tui_scroll): Remove.
3857         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3858         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3859         from tui_vertical_source_scroll.
3860         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3861         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3862         from tui_vertical_disassem_scroll.
3863         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3864         do_scroll_horizontal>: New methods.
3865         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3866         Likewise.
3867         (struct tui_source_window_base): Add do_scroll_horizontal.
3868         (struct tui_source_window, struct tui_disasm_window): Add
3869         do_scroll_vertical.
3870         (struct tui_data_window, struct tui_cmd_window): Add
3871         do_scroll_horizontal and do_scroll_vertical.
3872         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3873
3874 2019-06-25  Tom Tromey  <tom@tromey.com>
3875
3876         * tui/tui-data.h (struct tui_source_window_base): New struct.
3877         (struct tui_source_window): Derive from tui_source_window_base.
3878         (struct tui_disasm_window): New struct.
3879         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3880         from tui_source_window::clear_detail.
3881         (tui_source_window_base): Rename from tui_source_window.
3882         (~tui_source_window_base): Rename from ~tui_source_window.
3883         (tui_alloc_win_info): Create a tui_disasm_window.
3884
3885 2019-06-25  Tom Tromey  <tom@tromey.com>
3886
3887         * tui/tui-data.h (struct tui_source_window)
3888         (struct tui_data_window): Declare destructors.
3889         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3890         destructors.
3891         (tui_win_info): Simplify.
3892
3893 2019-06-25  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui-winsource.c (tui_display_main)
3896         (tui_update_source_windows_with_addr)
3897         (tui_update_all_breakpoint_info): Update.
3898         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3899         (new_height_ok, parse_scrolling_args): Update.
3900         * tui/tui-stack.c (tui_show_frame_info): Update.
3901         * tui/tui-data.h (struct tui_list): Remove.
3902         (tui_source_windows): Return a reference to a std::vector.
3903         * tui/tui-data.c (source_windows): Now a std::vector.
3904         (tui_source_windows): Change return type.
3905         (tui_clear_source_windows): Rewrite.
3906         (tui_clear_source_windows_detail, tui_add_to_source_windows)
3907         (tui_free_all_source_wins_content): Rewrite.
3908
3909 2019-06-25  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3912         (struct tui_data_window, struct tui_cmd_window): Declare
3913         clear_detail method.
3914         * tui/tui-data.c (tui_source_window::clear_detail)
3915         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3916         methods.
3917         (tui_clear_win_detail): Simplify.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui-layout.c (make_source_window, make_disasm_window)
3922         (make_source_or_disasm_window): Remove win_info_ptr parameter.
3923         Return the new window.
3924         (show_source_disasm_command, show_data)
3925         (show_source_or_disasm_and_command): Update.
3926
3927 2019-06-25  Tom Tromey  <tom@tromey.com>
3928
3929         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3930         parameter.  Return the new window.
3931         (show_source_disasm_command): Update and remove NULL check.
3932         (show_source_or_disasm_and_command): Update.
3933
3934 2019-06-25  Tom Tromey  <tom@tromey.com>
3935
3936         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3937
3938 2019-06-25  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-data.h (struct tui_win_info): Make constructor
3941         protected.  Make destructor virtual.  Add initializers.
3942         (tui_source_window, tui_data_window, tui_cmd_window): New
3943         classes.
3944         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
3945         constructor.  Add "type" parameter.
3946         (tui_source_window, tui_data_window, tui_cmd_window): New
3947         constructors.
3948         (tui_alloc_win_info): Instantiate the appropriate subclass.
3949
3950 2019-06-25  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-win.c (tui_resize_all): Use delete.
3953         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3954         destructor.
3955         (tui_free_window): Don't declare.
3956         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3957         Update.
3958
3959 2019-06-25  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-data.h (struct tui_win_info): Add constructor.
3962         * tui/tui-data.c (tui_alloc_win_info): Use new.
3963         (tui_free_window): Use delete.
3964
3965 2019-06-22  Tom Tromey  <tom@tromey.com>
3966
3967         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3968         declare.
3969         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3970
3971 2019-06-22  Tom Tromey  <tom@tromey.com>
3972
3973         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3974         declare.
3975         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3976
3977 2019-06-22  Tom de Vries  <tdevries@suse.de>
3978
3979         * dwarf2read.c (create_addrmap_from_aranges)
3980         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3981         instead of '%zu'.
3982
3983 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
3984
3985         * dwarf2read.h (dwarf2_section_info_def): Remove.
3986         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3987         * dwarf2read.c (struct dwo_sections) <types>: Change type to
3988         std::vector<dwarf2_section_info>.
3989         (struct dwo_file) <~dwo_file>: Remove.
3990         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3991         types field.
3992         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3993         (dwarf2_read_debug_names): Likewise.
3994         (create_debug_types_hash_table): Change parameter type to
3995         array_view, adjust code accordingly.
3996         (dwarf2_locate_dwo_sections): Adjust to std::vector.
3997         (partial_die_info::fixup): Likewise.
3998         (determine_prefix): Likewise.
3999         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4000
4001 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4002
4003         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4004         gdb_bfd_ref_ptr.
4005         <~dwo_file>: Remove call to gdb_bfd_unref.
4006         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4007         gdb_bfd_ref_ptr::get.
4008
4009 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4010
4011         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4012         type to htab_up.
4013         * dwarf2read.c (struct dwo_file): Initialize fields.
4014         <~dwo_file>: New.
4015         (free_dwo_file): Remove, move content to ~dwo_file.
4016         (struct dwo_file_deleter): Remove.
4017         (dwo_file_up>: Remove custom deleter.
4018         (free_dwo_files): Remove.
4019         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4020         dwo_files.
4021         (process_skeletonless_type_units): Call unique_ptr::get.
4022         (allocate_dwo_file_hash_table): Add deleter to created hash
4023         table.  Change return type to htab_up.
4024         (lookup_dwo_file_slot): Don't memset dwo_file, call
4025         unique_ptr::get.
4026         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4027         (create_dwo_unit_in_dwp_v2): Likewise.
4028         (open_and_init_dwo_file): Likewise.
4029         (free_dwo_file_from_slot): Remove.
4030
4031 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4032
4033         * dwarf2read.h (struct dwarf2_section_info) <readin,
4034         is_virtual>: Change type to bool.
4035         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4036         true instead of 1.
4037
4038 2019-06-19  Tom Tromey  <tom@tromey.com>
4039
4040         * tui/tui-data.h (tui_init_content_element): Don't declare.
4041
4042 2019-06-19  Tom Tromey  <tom@tromey.com>
4043
4044         * tui/tui-data.h (tui_init_win_info): Don't declare.
4045
4046 2019-06-19  Tom de Vries  <tdevries@suse.de>
4047
4048         * dwarf2read.h (abstract_to_concrete): Change type to
4049         std::unordered_map<sect_offset, std::vector<sect_offset>,
4050         gdb::hash_enum<sect_offset>>.
4051
4052 2019-06-19  Tom Tromey  <tromey@adacore.com>
4053
4054         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4055         EVAL_AVOID_SIDE_EFFECTS specially.
4056
4057 2019-06-19  Tom Tromey  <tromey@adacore.com>
4058
4059         * source-cache.c (highlighter): New global.
4060         (source_cache::get_source_lines): Create a highlighter on demand.
4061
4062 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4063
4064         * defs.h (deprecated_interactive_hook): Delete declaration.
4065         * interps.c (clear_interpreter_hooks): Remove use of
4066         deprecated_interactive_hook.
4067         * top.c (deprecated_interactive_hook): Delete definition.
4068         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4069
4070 2019-06-18  Tom de Vries  <tdevries@suse.de>
4071
4072         PR gdb/24515
4073         * dwarf2read.h (abstract_to_concrete): Change type from
4074         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4075         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4076         * dwarf2read.c (read_variable): Update.
4077         (dwarf2_fetch_die_loc_sect_off): Update.
4078
4079 2019-06-17  Tom de Vries  <tdevries@suse.de>
4080
4081         PR gdb/24617
4082         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4083         accessing parent[parent_len - 1].
4084
4085 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4086
4087         PR gdb/24364
4088         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4089         call dtrace_process_dof with NULL dof.
4090
4091 2019-06-16  Tom de Vries  <tdevries@suse.de>
4092
4093         PR gdb/24445
4094         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4095
4096 2019-06-16  Tom Tromey  <tom@tromey.com>
4097
4098         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4099         (make_all_visible): Use address of member.
4100
4101 2019-06-16  Tom Tromey  <tom@tromey.com>
4102
4103         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4104         (tui_free_window, free_content, free_content_elements): Remove
4105         unnecessary cast.
4106         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4107         cast.
4108         * tui/tui-regs.c (tui_show_register_group)
4109         (tui_display_registers_from, tui_display_reg_element_at_line):
4110         Remove unnecessary cast.
4111
4112 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4113
4114         * linux-nat.c (normal_mask): Delete.
4115         (_initialize_linux_nat): Don't initialise normal_mask.
4116
4117 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4118
4119         PR gdb/24445
4120         * dwarf-index-write.h (write_psymtabs_to_index): Add
4121         dwz_basename parameter.
4122         * dwarf-index-write.c (write_gdbindex): Move file writing to
4123         write_gdbindex_1.  Change return type void.
4124         (assert_file_size): Move up, remove filename parameter.
4125         (write_gdbindex_1): New function.
4126         (write_debug_names): Change return type to void, call
4127         assert_file_size.
4128         (struct index_wip_file): New struct.
4129         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4130         file logic to index_wip_file.  Write index for dwz file if
4131         needed.
4132         (save_gdb_index_command): Pass basename of dwz file, if present.
4133         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4134         build-id of dwz file, if present.
4135         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4136         (dwarf2_get_dwz_file): Likewise.
4137         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4138         (dwarf2_get_dwz_file): Likewise.
4139
4140 2019-06-16  Tom Tromey  <tom@tromey.com>
4141
4142         * coffread.c (process_coff_symbol): Use xstrdup.
4143         * value.c (create_internalvar): Use xstrdup.
4144
4145 2019-06-16  Tom Tromey  <tom@tromey.com>
4146
4147         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4148         * breakpoint.c (stopin_command, stopat_command)
4149         (until_break_command, decode_location_default): Remove unnecessary
4150         cast.
4151         * utils.c (subset_compare): Remove unnecessary cast.
4152         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4153         cast.
4154         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4155         cast.
4156         * infcmd.c (path_command): Remove unnecessary cast.
4157         * coffread.c (decode_type): Remove unnecessary cast.
4158         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4159         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4160         * tui/tui-stack.c (tui_show_locator_content)
4161         (tui_show_frame_info): Remove unnecessary cast.
4162         * tui/tui-win.c (tui_scroll_forward_command)
4163         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4164         (parse_scrolling_args): Remove unnecessary cast.
4165         * tui/tui-data.c (init_win_info, tui_del_window)
4166         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4167         (free_content_elements): Remove unnecessary cast.
4168         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4169         unnecessary cast.
4170         * tui/tui-source.c (tui_set_source_content)
4171         (tui_vertical_source_scroll): Remove unnecessary cast.
4172         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4173         cast.
4174         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4175         * tui/tui-regs.c (tui_display_registers_from)
4176         (tui_display_register): Remove unnecessary cast.
4177         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4178         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4179         (make_visible): Remove unnecessary cast.
4180         * tui/tui-winsource.c (tui_erase_source_content)
4181         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4182         unnecessary cast.
4183         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4184         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4185         * stabsread.c (read_type, read_array_type, read_range_type):
4186         Remove unnecessary cast.
4187         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4188         (parse_symbol, parse_type, upgrade_type, parse_external)
4189         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4190         unnecessary cast.
4191         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4192
4193 2019-06-16  Tom Tromey  <tom@tromey.com>
4194
4195         * tui/tui-data.c (tui_alloc_generic_win_info)
4196         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4197         checks.
4198
4199 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4200             Andrew Burgess  <andrew.burgess@embecosm.com>
4201
4202         * f-typeprint.c (f_print_type): Don't return early for not
4203         associated or not allocated types.
4204         (f_type_print_varspec_suffix): Add print_rank parameter and print
4205         ranks of array types in case they dangling.
4206         (f_type_print_base): Add print_rank parameter.
4207
4208 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4209
4210         * NEWS: Mention new MI commands.
4211         * break-catch-throw.c (enum exception_event_kind): Move to
4212         breakpoint.h.
4213         (print_mention_exception_catchpoint): Output text as a single
4214         message.
4215         (catch_exception_command_1): Rename to...
4216         (catch_exception_event): ...this, make non-static, update header
4217         command, and change some parameter types.
4218         (catch_catch_command): Update for changes to
4219         catch_exception_command_1.
4220         (catch_throw_command): Likewise.
4221         (catch_rethrow_command): Likewise.
4222         * breakpoint.c (enum exception_event_kind): Delete.
4223         * breakpoint.h (enum exception_event_kind): Moved here from
4224         break-catch-throw.c.
4225         (catch_exception_event): Declare.
4226         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4227         (mi_cmd_catch_throw): New function.
4228         (mi_cmd_catch_rethrow): New function.
4229         (mi_cmd_catch_catch): New function.
4230         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4231         'catch-catch' entries.
4232         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4233         (mi_cmd_catch_rethrow): Declare.
4234         (mi_cmd_catch_catch): Declare.
4235
4236 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4237
4238         * annotate.c (annotate_source_line): Change return type to void,
4239         update implementation to match.
4240         * annotate.h (annotate_source_line): Change return type to void,
4241         update header comment.
4242         * stack.c (print_frame_info): Don't change what frame information
4243         is printed based on whether annotations are on or not.
4244
4245 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4248         (annotate_source): Make static.
4249         (annotate_source_line): Moved from source.c and renamed from
4250         identify_source_line.  Update the return type.
4251         * annotate.h (annotate_source): Delete declaration.
4252         (annotate_source_line): Declaration moved from source.h, and
4253         renamed from identify_source_line.  Return type updated.
4254         * source.c (identify_source_line): Moved to annotate.c and renamed
4255         to annotate_source_line.
4256         (info_line_command): Remove check of annotation_level.
4257         * source.h (identify_source_line): Move declaration to annotate.h
4258         and rename to annotate_source_line.
4259         * stack.c: Add 'annotate.h' include.
4260         (print_frame_info): Remove check of annotation_level before
4261         calling annotate_source_line.
4262
4263 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4264
4265         * source-cache.c (source_cache::get_plain_source_lines): Use
4266         open_source_file_with_line_charpos instead of just
4267         open_source_file, remove call to find_source_lines.
4268         (source_cache::get_source_lines): Likewise.
4269         * source.c (find_source_lines): Make static.
4270         (get_filename_and_charpos): Renamed into...
4271         (open_source_file_with_line_charpos): ..this along with changes to
4272         return a scoped_fd, and some other minor clean ups.
4273         (identify_source_line): Use open_source_file_with_line_charpos.
4274         (search_command_helper): Use open_source_file_with_line_charpos
4275         instead of just open_source_file, remove call to
4276         find_source_lines.
4277         * source.h (open_source_file_with_line_charpos): Declare new
4278         function.
4279         (find_source_lines): Delete declaration.
4280
4281 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4282
4283         * source.c (get_filename_and_charpos): Remove fullname
4284         parameter.
4285         (identify_source_line): Update call to get_filename_and_charpos.
4286
4287 2019-06-14  Tom Tromey  <tromey@adacore.com>
4288
4289         PR gdb/24502:
4290         * ui-style.h (skip_ansi_escape): Update comment.
4291         * ui-file.h (class no_terminal_escape_file): New class.
4292         * ui-file.c (no_terminal_escape_file::write)
4293         (no_terminal_escape_file::puts): New methods.
4294         * cli/cli-logging.c (handle_redirections): Use
4295         no_terminal_escape_file.
4296
4297 2019-06-14  Tom Tromey  <tromey@adacore.com>
4298
4299         * NEWS: Move convenience variable news above Python news.
4300
4301 2019-06-14  Tom Tromey  <tom@tromey.com>
4302
4303         * gnulib: Move directory to top-level.
4304         * configure.ac: Don't configure gnulib.
4305         * configure: Rebuild.
4306         * common/common-defs.h: Use new path to gnulib.
4307         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4308         (GNULIB_H): Remove.
4309         (INCGNU): Look in new gnulib location.
4310         (HFILES_NO_SRCDIR): Remove gnulib files.
4311         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4312         (generated_files): Remove GNULIB_H.
4313         ($(LIBGNU), all-lib): Remove targets.
4314         (distclean): Don't mention GNULIB_BUILDDIR.
4315         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4316
4317 2019-06-14  Tom Tromey  <tromey@adacore.com>
4318
4319         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4320         Warn if symbol file does not provide any symbols.
4321
4322 2019-06-14  Tom Tromey  <tromey@adacore.com>
4323
4324         * source.c (find_and_open_source): Respect basenames_may_differ.
4325
4326 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4327
4328         * annotate.c (annotate_breakpoints_invalid): Make use of
4329         scoped_restore_terminal_state.
4330         (annotate_frames_invalid): Likewise.
4331
4332 2019-06-14  Tom Tromey  <tromey@adacore.com>
4333
4334         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4335         allow assignment to an internalvar.
4336
4337 2019-06-14  Tom Tromey  <tromey@adacore.com>
4338
4339         * ada-lex.l: Allow "_" in attribute names.
4340
4341 2019-06-14  Tom Tromey  <tromey@adacore.com>
4342
4343         PR gdb/24653:
4344         * regcache.c (registers_changed): Don't call alloca.
4345         * top.c (execute_command): Don't call alloca.
4346
4347 2019-06-13  Pedro Alves  <palves@redhat.com>
4348
4349         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4350         'expression'.  When parsing an expression, error out if there's
4351         junk after "unlimited".
4352         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4353         (do_set_command): Adjust calls to is_unlimited_literal.
4354
4355 2019-06-13  Pedro Alves  <palves@redhat.com>
4356
4357         * compile/compile.c (make_compile_options_def_group): Add braces
4358         around array_view initializer.
4359         * thread.c (make_thread_apply_all_options_def_group)
4360         (make_thread_apply_all_options_def_group): Likewise.
4361
4362 2019-06-13  Pedro Alves  <palves@redhat.com>
4363
4364         * NEWS (New commands): Mention "maint test-options
4365         require-delimiter", "maint test-options unknown-is-error", "maint
4366         test-options unknown-is-operand" and "maint show
4367         test-options-completion-result".
4368         (New command options, command completion): New section.
4369         (Completion improvements): New section.
4370         Mention that you can abbreviate "unlimited".
4371
4372 2019-06-13  Pedro Alves  <palves@redhat.com>
4373
4374         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4375         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4376         * unittests/cli-utils-selftests.c (test_parse_flags)
4377         (test_parse_flags_qcs): Delete.
4378         (test_cli_utils): Don't call deleted functions.
4379
4380 2019-06-13  Pedro Alves  <palves@redhat.com>
4381
4382         * thread.c: Include "cli/cli-option.h".
4383         (tp_array_compar_ascending): Global.
4384         (tp_array_compar): Delete function.
4385         (tp_array_compar_ascending, tp_array_compar_descending): New
4386         functions.
4387         (ascending_option_def, qcs_flag_option_def)
4388         (thr_qcs_flags_option_defs)
4389         (make_thread_apply_all_options_def_group)
4390         (make_thread_apply_options_def_group): New.
4391         (thread_apply_all_command): Use gdb::option::process_options.
4392         (thread_apply_command_completer)
4393         (thread_apply_all_command_completer): New.
4394         (thread_apply_command): Use gdb::option::process_options.
4395         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4396         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4397         to generate help text of "thread apply".  Adjust "taas"'s help.
4398         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4399         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4400
4401 2019-06-13  Pedro Alves  <palves@redhat.com>
4402
4403         * thread.c (thread_apply_command): Check for invalid TID with
4404         isdigit instead of !isalpha.
4405
4406 2019-06-13  Pedro Alves  <palves@redhat.com>
4407
4408         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4409         (validate_flags_qcs): New.
4410         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4411         (validate_flags_qcs): Declare.
4412         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4413         (make_frame_apply_options_def_group): New.
4414         (frame_apply_command_count): Process options with
4415         gdb::option::process_options.
4416         (frame_apply_completer): New.
4417         (frame_apply_level_completer, frame_apply_all_completer)
4418         (frame_apply_completer): New.
4419         (_initialize_stack): Update help of "frame apply", "frame apply
4420         level", "frame apply all" and "faas" to mention supported options
4421         and install command completers.
4422         * stack.h (frame_apply_all_completer): Declare.
4423         * thread.c: Include "stack.h".
4424         (tfaas_command): Add "--".
4425         (_initialize_thread): Update help "tfaas" to mention supported
4426         options and install command completer.
4427
4428 2019-06-13  Pedro Alves  <palves@redhat.com>
4429
4430         * completer.c (complete_nested_command_line): New.
4431         (gdb_completion_word_break_characters_throw): Add assertion.
4432         * completer.h (complete_nested_command_line): Declare.
4433
4434 2019-06-13  Pedro Alves  <palves@redhat.com>
4435
4436         * stack.c (parse_backtrace_qualifiers): New.
4437         (backtrace_command): Use it.
4438         (backtrace_command_completer): Complete on qualifiers.
4439
4440 2019-06-13  Pedro Alves  <palves@redhat.com>
4441
4442         * frame.c: Include "cli/cli-option.h.
4443         (user_set_backtrace_options): New.
4444         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4445         Delete.
4446         (get_prev_frame): Adjust.
4447         (boolean_option_def, uinteger_option_def)
4448         (set_backtrace_option_defs): New.
4449         (_initialize_frame): Adjust and use
4450         gdb::option::add_setshow_cmds_for_options to install "set
4451         backtrace past-main" and "set backtrace past-entry".
4452         * frame.h: Include "cli/cli-option.h".
4453         (struct frame_print_options): Forward declare.
4454         (print_frame_arguments_all, print_frame_arguments_scalars)
4455         (print_frame_arguments_none): Declare.
4456         (print_entry_values): Delete declaration.
4457         (struct frame_print_options, user_frame_print_options): New.
4458         (struct set_backtrace_options): New.
4459         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4460         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4461         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4462         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4463         (list_args_or_locals): Add frame_print_options parameter.
4464         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4465         * python/py-framefilter.c (enumerate_args): Pass down
4466         USER_FRAME_PRINT_OPTIONS.
4467         * stack.c: Include "cli/cli-option.h".
4468         (print_frame_arguments_all, print_frame_arguments_scalars)
4469         (print_frame_arguments_none): Declare.
4470         (print_raw_frame_arguments, print_entry_values): Delete.
4471         (user_frame_print_options): New.
4472         (boolean_option_def, enum_option_def, frame_print_option_defs):
4473         New.
4474         (struct backtrace_cmd_options): New.
4475         (bt_flag_option_def): New.
4476         (backtrace_command_option_defs): New.
4477         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4478         (print_frame_arg, read_frame_arg, print_frame_args)
4479         (print_frame_info, print_frame): Add frame_print_options parameter
4480         and use it.
4481         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4482         (backtrace_command_1): Add frame_print_options and
4483         backtrace_cmd_options parameters and use them.
4484         (make_backtrace_options_def_group): New.
4485         (backtrace_command): Process command options with
4486         gdb::option::process_options.
4487         (backtrace_command_completer): New.
4488         (_initialize_stack): Extend "backtrace"'s help to mention
4489         supported options.  Install completer for "backtrace".
4490         Install some settings commands with add_setshow_cmds_for_options.
4491
4492 2019-06-13  Pedro Alves  <palves@redhat.com>
4493
4494         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4495         and that "set/show print raw frame-arguments" are now deprecated.
4496
4497         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4498         command.
4499         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4500         * stack.c (_initialize_stack): Install "set/show print
4501         raw-frame-arguments", and deprecate "set/show print raw
4502         frame-arguments".
4503         * valprint.c (_initialize_valprint): Deprecate "set/show print
4504         raw".
4505
4506 2019-06-13  Pedro Alves  <palves@redhat.com>
4507
4508         * compile/compile.c (struct compile_options): New.
4509         (compile_flag_option_def, compile_command_option_defs)
4510         (make_compile_options_def_group): New.
4511         (compile_file_command): Handle options with
4512         gdb::option::process_options.
4513         (compile_file_command_completer): New function.
4514         (compile_code_command): Handle options with
4515         gdb::option::process_options.
4516         (compile_code_command_completer): New function.
4517         (_initialize_compiler): Install completers for "compile code" and
4518         "compile file".  Mention available options in "compile code" and
4519         "compile code"'s help.
4520         * completer.c (advance_to_completion_word): New, factored out from
4521         ...
4522         (advance_to_expression_complete_word_point): ... this.
4523         (advance_to_filename_complete_word_point): New.
4524         * completer.h (advance_to_filename_complete_word_point): New
4525         declaration.
4526
4527 2019-06-13  Pedro Alves  <palves@redhat.com>
4528
4529         * compile/compile.c: Include "cli/cli-option.h".
4530         (compile_print_value): Scope data pointer is now a
4531         value_print_options pointer; adjust.
4532         (compile_print_command): Process options.  Scope data pointer is
4533         now a value_print_options pointer; adjust.
4534         (_initialize_compile): Update "compile print"'s help to include
4535         supported options.  Install a completer for "compile print".
4536         * cp-valprint.c (show_vtblprint, show_objectprint)
4537         (show_static_field_print): Delete.
4538         (_initialize_cp_valprint): Don't install "set print
4539         static-members", "set print vtbl", "set print object" here.
4540         * printcmd.c: Include "cli/cli-option.h" and
4541         "common/gdb_optional.h".
4542         (print_command_parse_format): Rework to fill in a
4543         value_print_options instead of a format_data.
4544         (print_value): Change parameter type from format_data pointer to
4545         value_print_options reference.  Adjust.
4546         (print_command_1): Process options.  Adjust to pass down a
4547         value_print_options.
4548         (print_command_completer): New.
4549         (_initialize_printcmd): Install print_command_completer as
4550         handle_brkchars completer for the "print" command.  Update
4551         "print"'s help to include supported options.
4552         * valprint.c: Include "cli/cli-option.h".
4553         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4554         here from cp-valprint.c.
4555         (boolean_option_def, uinteger_option_def)
4556         (value_print_option_defs, make_value_print_options_def_group):
4557         New.  Use gdb::option::add_setshow_cmds_for_options to install
4558         "set print elements", "set print null-stop", "set print repeats",
4559         "set print pretty", "set print union", "set print array", "set
4560         print address", "set print symbol", "set print array-indexes".
4561         * valprint.h: Include <string> and "cli/cli-option.h".
4562         (make_value_print_options_def_group): Declare.
4563         (print_value): Change parameter type from format_data pointer to
4564         value_print_options reference.
4565         (print_command_completer): Declare.
4566
4567 2019-06-13  Pedro Alves  <palves@redhat.com>
4568
4569         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4570         (COMMON_SFILES): Add maint-test-settings.c.
4571         * cli/cli-decode.c (boolean_enums): New global, factored out from
4572         ...
4573         (add_setshow_boolean_cmd): ... here.
4574         * cli/cli-decode.h (boolean_enums): Declare.
4575         * cli/cli-option.c: New file.
4576         * cli/cli-option.h: New file.
4577         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4578         factored out from ...
4579         (parse_cli_boolean_value(const char *)): ... this.
4580         (is_unlimited_literal): Change parameter type to pointer to
4581         pointer.  Adjust and advance ARG pointer.
4582         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4583         (parse_cli_var_enum): New, factored out from ...
4584         (do_set_command): ... this.  Adjust.
4585         * cli/cli-setshow.h (parse_cli_boolean_value)
4586         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4587         (parse_cli_var_enum): Declare.
4588         * cli/cli-utils.c: Include "cli/cli-option.h".
4589         (get_ulongest): New.
4590         * cli/cli-utils.h (get_ulongest): Declare.
4591         (check_for_argument): New overloads.
4592         * maint-test-options.c: New file.
4593
4594 2019-06-13  Pedro Alves  <palves@redhat.com>
4595
4596         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4597         parse a range if "-" is at the end of the string.
4598
4599 2019-06-13  Pedro Alves  <palves@redhat.com>
4600
4601         * cli/cli-setshow.c (parse_auto_binary_operation)
4602         (parse_cli_boolean_value): Don't allow "o".
4603
4604 2019-06-13  Pedro Alves  <palves@redhat.com>
4605
4606         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4607         * NEWS: Mention maint test-settings KIND.
4608         * maint-test-settings.c: New file.
4609
4610 2019-06-13  Pedro Alves  <palves@redhat.com>
4611
4612         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4613         completer.
4614         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4615         "set" completers.
4616
4617 2019-06-13  Pedro Alves  <palves@redhat.com>
4618
4619         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4620         after item.
4621
4622 2019-06-13  Pedro Alves  <palves@redhat.com>
4623
4624         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4625
4626 2019-06-13  Pedro Alves <palves@redhat.com>
4627
4628         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4629         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4630         call.
4631         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4632         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4633         calls.
4634         (check_for_argument): Skip spaces after argument.
4635
4636 2019-06-13  Pedro Alves  <palves@redhat.com>
4637
4638         * thread.c (thread_apply_command): Adjust TID parsing.
4639         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4640         detected before end of string.
4641         (tid_is_in_list): Error out if LIST is invalid.
4642
4643 2019-06-13  Pedro Alves  <palves@redhat.com>
4644
4645         * completer.c (complete_line_internal_1): Rewind completion word
4646         point.
4647         (completion_tracker::advance_custom_word_point_by): Change
4648         parameter type to int.
4649         * completer.h (completion_tracker::advance_custom_word_point_by):
4650         Likewise.
4651
4652 2019-06-13  Pedro Alves  <palves@redhat.com>
4653
4654         * completer.c (advance_to_completion_word): Handle delimiters.
4655
4656 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
4657
4658         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4659
4660 2019-06-11  Tom Tromey  <tom@tromey.com>
4661
4662         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4663         (xmalloc_failed): Move to alloc.c.
4664         * alloc.c: New file.
4665         * Makefile.in (COMMON_SFILES): Add alloc.c.
4666
4667 2019-06-11  Tom Tromey  <tom@tromey.com>
4668
4669         * nat/linux-waitpid.c: Don't include server.h.
4670         (linux_debug): Remove.
4671         (my_waitpid): Update.
4672
4673 2019-06-11  Tom Tromey  <tromey@adacore.com>
4674
4675         * infcall.c (_initialize_infcall): Remove trailing newline from
4676         help.
4677         * user-regs.c (_initialize_user_regs): Remove trailing newline
4678         from help.
4679         * typeprint.c (_initialize_typeprint): Remove trailing newline
4680         from help.
4681         * reverse.c (_initialize_reverse): Remove trailing newlines from
4682         help.
4683         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4684         from help.
4685         * language.c (add_set_language_command): Remove trailing newline
4686         from help.
4687         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4688         help.
4689         * disasm.c (_initialize_disasm): Remove trailing newline from
4690         help.
4691         * top.c (init_main): Remove trailing newline from help.
4692         * interps.c (_initialize_interpreter): Remove trailing newline
4693         from help.
4694         * btrace.c (_initialize_btrace): Remove trailing newlines from
4695         help.
4696         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4697         from help.
4698         * python/python.c (_initialize_python): Remove trailing newline
4699         from help.
4700         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4701         help.
4702         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4703         from help.  Reformat some text.
4704         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4705         from help.
4706         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4707         newline from help.
4708
4709 2019-06-11  Tom Tromey  <tromey@adacore.com>
4710
4711         * darwin-nat.c (darwin_decode_exception_message)
4712         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4713
4714 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * valops.c (value_slice): Check for not allocated or not
4717         associated values.
4718
4719 2019-06-10  Tom de Vries  <tdevries@suse.de>
4720
4721         PR gdb/24618
4722         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4723         sure an empty slot (defined by a 32-bit zero pair) is recognized as
4724         invalid.
4725
4726 2019-06-10  Tom de Vries  <tdevries@suse.de>
4727
4728         PR gdb/24611
4729         * linespec.c (linespec_lexer_lex_string): Remove incorrect
4730         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
4731
4732 2019-06-10  Tom de Vries  <tdevries@suse.de>
4733
4734         PR symtab/24545
4735         * symtab.c (struct demangled_name_entry): Add language field.
4736         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
4737         static minimal symbol".  Set and use language field.
4738
4739 2019-06-10  Tom Tromey  <tromey@adacore.com>
4740
4741         * ada-lang.c (_initialize_ada_language): Update help text.
4742
4743 2019-06-10  Tom Tromey  <tromey@adacore.com>
4744
4745         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4746         with a newline.
4747         * guile/guile.c (handle_boot_error): Don't end warning with a
4748         newline.
4749         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4750         warning with a newline.
4751         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4752         newline.
4753         (s12z_frame_cache): Likewise.
4754         * dwarf-index-cache.c (index_cache::store): Don't end warning with
4755         a newline.
4756         * solib-svr4.c (disable_probes_interface): Don't end warning with
4757         a newline.
4758         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4759         newline.
4760         * python/python.c (do_finish_initialization): Don't end warning
4761         with a newline.
4762
4763 2019-06-10  Tom Tromey  <tom@tromey.com>
4764
4765         * python/py-breakpoint.c (gdbpy_breakpoint_created)
4766         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4767         gdbpy_enter.
4768
4769 2019-06-10  Tom Tromey  <tromey@adacore.com>
4770
4771         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4772         data.
4773         (elf_new_init): Don't call stabsread_new_init.
4774         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4775         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
4776         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4777
4778 2019-06-10  Tom de Vries  <tdevries@suse.de>
4779
4780         PR symtab/16264
4781         PR symtab/24517
4782         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4783
4784 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
4785
4786         * source.c (find_and_open_source): Also rewrite relative file
4787         names.
4788
4789 2019-04-26  Amos Bird  <amosbird@gmail.com>
4790
4791         * annotate.c (annotate_thread_exited): Add "thread-exited"
4792         annotation.
4793
4794 2019-06-06  Tom Tromey  <tromey@adacore.com>
4795
4796         * maint.h (class scoped_command_stats): Use
4797         DISABLE_COPY_AND_ASSIGN.
4798         <print_time>: New method.
4799         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4800         print_time.
4801         (scoped_command_stats::print_time): New method.
4802
4803 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4806         instructions of lengths 6 or 8 bytes.
4807
4808 2019-06-04  Pedro Alves  <palves@redhat.com>
4809
4810         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4811
4812         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4813         * breakpoint.c (condition_completer): Likewise.
4814         * cli/cli-dump.c (scan_expression): Likewise.
4815         * common/filestuff.c (mkdir_recursive): Likewise.
4816         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4817         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4818         (gdb_abspath): Likewise.
4819         * compile/compile-cplus-types.c
4820         (compile_cplus_instance::decl_name): Likewise.
4821         * completer.c (complete_explicit_location):
4822         (signal_completer, reg_or_group_completer_1): Likewise.
4823         * cp-support.c (cp_remove_params_if_any): Likewise.
4824         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4825         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4826         * infcmd.c (strip_bg_char): Likewise.
4827         * linespec.c (copy_token_string): Likewise.
4828         * mi/mi-main.c (output_cores): Likewise.
4829         * psymtab.c (psymtab_search_name):
4830         * symfile.c (test_set_ext_lang_command): Likewise.
4831         * target.c (target_fileio_read_stralloc): Likewise.
4832         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4833         * value.c (complete_internalvar): Likewise.
4834
4835 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
4836
4837         Add objfile property to gdb.Type.
4838         * NEWS: Mention Python API addition.
4839         * python/py-type.c (typy_get_objfile): New method.
4840
4841 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4842
4843         * NEWS: Mention the new set|show style [title|highlight].
4844         Mention changes to "show style", "help" and "apropos".
4845
4846 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4847
4848         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4849         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
4850         instead of print_help_for_command.
4851         (print_doc_of_command): New function.
4852         (help_list): Add 'apropos -v word' suggestion.
4853         (print_help_for_command): Style the command name using title style.
4854         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4855         (_initialize_cli_cmds): Describe -v in apropos_command help.
4856
4857 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4858
4859         * cli/cli-style.h (cli_style_option): Add name in constructor,
4860         add m_name class member, add constructor with intensity,
4861         add name class function.
4862         (cli_style_option::add_setshow_commands): Remove name argument.
4863         (highlight_style, title_style): New styles.
4864         * cli/cli-style.c (do_show): New function that shows a style
4865         characteristic styling the style name with itself.
4866         (set_style_name): New function.
4867         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4868         Update all callers according to the changes in cli/cli-style.h.
4869         * utils.h (fputs_highlighted): New function.
4870         * utils.c (fputs_highlighted): Likewise.
4871
4872 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4873
4874         * NEWS: Mention new pipe command and new convenience variables.
4875
4876 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4877
4878         * cli/cli-cmds.c (pipe_command): New function.
4879         (_initialize_cli_cmds): Call add_com for pipe_command.
4880         Define | as an alias for pipe.
4881         (exit_status_set_internal_vars): New function.
4882         (shell_escape): Call exit_status_set_internal_vars.
4883         cli/cli-decode.c (find_command_name_length): Recognize | as
4884         a single character command.
4885
4886 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4887
4888         * gdbcmd.h (execute_command_to_ui_file): New declaration.
4889         top.c (execute_command_to_ui_file): New function, mostly a copy
4890         of execute_command_to_string.
4891         (execute_command_to_string): Implement by calling
4892         execute_command_to_ui_file.
4893
4894 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4895
4896         * top.h (saved_command_line): Remove declaration.
4897         * top.c (previous_saved_command_line, previous_repeat_arguments):
4898         New variables.
4899         (saved_command_line): Make static, define together with other
4900         'repeat variables'.
4901         (dont_repeat): Clear repeat_arguments.
4902         (repeat_previous, get_saved_command_line, save_command_line):
4903         New functions.
4904         (gdb_init): Initialize saved_command_line
4905         and previous_saved_command_line.
4906         * main.c (captured_main_1): Remove saved_command_line initialization.
4907         * event-top.c (handle_line_of_input): Update to use
4908         the new 'repeat' related functions instead of direct access to
4909         saved_command_line.
4910         * command.h (repeat_previous, get_saved_command_line,
4911         save_command_line): New declarations.
4912         (dont_repeat): Add comment.
4913
4914 2019-05-30  Tom Tromey  <tromey@adacore.com>
4915
4916         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4917         Fix comment.
4918         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4919
4920 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
4921
4922         PR cli/24587
4923         * completer.c (complete): Initialize variable word.
4924
4925 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
4926
4927         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4928         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4929         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4930         'body' is NULL to the outter 'if', protecting the '!is_define'
4931         situation as well.
4932
4933 2019-05-29  Tom Tromey  <tromey@adacore.com>
4934
4935         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4936         (dwarf_unknown): New function.
4937         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4938         (dwarf_type_encoding_name): Use dwarf_unknown.
4939
4940 2019-05-29  Tom Tromey  <tromey@adacore.com>
4941
4942         PR c++/20020:
4943         * cp-valprint.c (cp_print_value_fields): Call
4944         cp_print_static_field inside "try".
4945
4946 2019-05-29  Tom Tromey  <tromey@adacore.com>
4947
4948         * inflow.c (struct terminal_info): Add default operator=.
4949         * configure: Rebuild.
4950         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4951         -Wdeprecated-copy-dtor, -Wredundant-move.
4952
4953 2019-05-29  Tom Tromey  <tromey@adacore.com>
4954
4955         * NEWS: Add entry.
4956         * infcmd.c (print_return_value_1): Handle finish_print
4957         option.
4958         (show_print_finish): New function.
4959         (_initialize_infcmd): Add "set/show print finish" commands.
4960         * valprint.c (user_print_options): Initialize new member.
4961         * valprint.h (struct value_print_options) <finish_print>: New
4962         member.
4963
4964 2019-05-28  Tom Tromey  <tromey@adacore.com>
4965
4966         * ada-lang.c (ada_remove_Xbn_suffix)
4967         (find_old_style_renaming_symbol)
4968         (parse_old_style_renaming): Remove.
4969         (ada_find_renaming_symbol): Don't call
4970         find_old_style_renaming_symbol.
4971         (ada_is_renaming_symbol): Rename from
4972         ada_find_renaming_symbol.  Remove "block" parameter.  Return
4973         bool.  Now static.
4974         (ada_read_var_value): Update and simplify.
4975         * ada-exp.y (write_var_or_type): Remove old code.
4976
4977 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
4978
4979         * event-top.c: Remove include comment.
4980         * inflow.c (class scoped_ignore_sigttou): Move from here...
4981         * inflow.h (class scoped_ignore_sigttou): ...to here.
4982         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4983         * top.c:  Remove include comment.
4984
4985 2019-05-27  Tom Tromey  <tom@tromey.com>
4986
4987         * NEWS: Fix typo.
4988
4989 2019-05-22  Tom Tromey  <tromey@adacore.com>
4990
4991         * target.c (target_follow_exec): Constify parameter.
4992         * target-delegates.c: Rebuild.
4993         * remote.c (remote_target::follow_exec): Constify parameter.
4994         * infrun.c (follow_exec): Constify parameter.
4995         * target.h (struct target_ops) <follow_exec>: Constify parameter.
4996         (target_follow_exec): Likewise.
4997
4998 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
4999
5000         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5001         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5002
5003 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5004
5005         * NEWS: Add debugredirect and testsuite sections.
5006
5007 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5008
5009         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5010         target descriptions using exclusively floating point register name
5011         aliases.
5012
5013 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5014
5015         PR gdb/18644:
5016         * f-lang.c (build_fortran_types): Handle the case where
5017         gdbarch_floatformat_for_type returns a nullptr.
5018
5019 2019-05-21  Tom de Vries  <tdevries@suse.de>
5020
5021         PR cli/24587
5022         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5023
5024 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5025
5026         PR gdb/18644:
5027         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5028         16-byte floats.
5029         * i386-tdep.c (i386_floatformat_for_type): Use
5030         floatformats_ia64_quad for the 16-byte floating point component
5031         within a fortran 32-byte complex number.
5032
5033 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5034
5035         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5036         delete default constructor.
5037         (find_partial_die): Update to return const struct.
5038         (partial_die_parent_scope): Move variable declaration into scope
5039         of its use and change its type to auto.
5040         (guess_partial_die_structure_name): Likewise.
5041         (partial_die_info::fixup): Likewise.
5042
5043 2019-05-17  Tom Tromey  <tromey@adacore.com>
5044
5045         * source.c (find_and_open_source): Remove cast.
5046
5047 2019-05-17  Tom Tromey  <tromey@adacore.com>
5048
5049         * annotate.c (annotate_source): Make "filename" const.
5050         * annotate.h (annotate_source): Use const.
5051
5052 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5053
5054         * disasm.c (set_disassembler_options): Send errors to stderr.
5055
5056 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5057
5058         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5059         (cli_interp_base::set_logging): Check debug_redirect.
5060         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5061         * cli/cli-logging.c (debug_redirect): Add static variable.
5062         (pop_output_files): Add default param.
5063         (handle_redirections): Print debug setting.
5064         (show_logging_command): Likewise.
5065         (_initialize_cli_logging): Add debugredirect command.
5066         * interps.c (current_interp_set_logging): Add debug_redirect
5067         parameter.
5068         * interps.h (set_logging): Add debug_redirect parameter.
5069         (current_interp_set_logging): Likewise.
5070         * mi/mi-common.h: Likewise.
5071         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5072
5073 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5074             Tom Tromey  <tromey@adacore.com>
5075
5076         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5077         directly.
5078         * cli/cli-interp.h (make_logging_output): Remove declaration.
5079         * cli/cli-logging.c (make_logging_output): Remove function.
5080         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5081         directly.
5082         * ui-file.c (tee_file::tee_file): Remove bools.
5083         (tee_file::~tee_file): Remove deletes.
5084         * ui-file.h (tee_file): Remove bools.
5085
5086 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5087
5088         * mi/mi-cmds.h (mi_cmd_complete): New function.
5089         * mi/mi-main.c (mi_cmd_complete): Likewise.
5090         * mi/mi-cmds.c: Define new MI command -complete.
5091         * NEWS: Mention new -complete command.
5092
5093 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5094
5095         * completer.h (complete): New function.
5096         * completer.c (complete): Likewise.
5097         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5098         function defined in completer.h.
5099
5100 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5101
5102         * MAINTAINERS (Write After Approval): Add myself.
5103
5104 2019-05-17  Tom de Vries  <tdevries@suse.de>
5105
5106         PR gdb/24094
5107         * dwarf2read.c (struct cu_partial_die_info): New struct.
5108         (find_partial_die): Return cu_partial_die_info.
5109         (partial_die_parent_scope, guess_partial_die_structure_name)
5110         (partial_die_info::fixup): Handle new return type of find_partial_die.
5111
5112 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5113
5114         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5115         "std::string", simplifying the algorithm.
5116
5117 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5118
5119         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5120         (stap_static_probe_ops::get_probes): Likewise.
5121
5122 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5123
5124         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5125         '-')" and "else if".
5126         (stap_parse_single_operand): Join checks for
5127         "gdbarch_stap_parse_special_token_p" and
5128         "gdbarch_stap_parse_special_token" in the same "if" statement.
5129         Invert check when verifying for operation on register
5130         displacement.
5131
5132 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5133
5134         * stap-probe.c (stap_get_opcode): Update comment.
5135         (stap_get_expected_argument_type): Likewise.
5136         (handle_stap_probe): Likewise.
5137
5138 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5139
5140         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5141         return type to 'bool'.  Adjust comment.  Use 'bool' when
5142         appropriate.
5143         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5144         * stap-probe.c (stap_parse_argument_1): Likewise.
5145         (stap_is_operator): Likewise.
5146         (stap_is_generic_prefix): Likewise.
5147         (stap_is_register_prefix): Likewise.
5148         (stap_is_register_indirection_prefix): Likewise.
5149         (stap_is_integer_prefix): Likewise.
5150         (stap_generic_check_suffix): Likewise.
5151         (stap_check_integer_suffix): Likewise.
5152         (stap_check_register_suffix): Likewise.
5153         (stap_check_register_indirection_suffix): Likewise.
5154         (stap_parse_register_operand): Likewise.
5155         (stap_parse_single_operand): Likewise.
5156         (stap_parse_argument_1): Likewise.
5157         (stap_probe::get_argument_count): Likewise.
5158         (stap_is_operator): Likewise.
5159
5160 2019-05-16  Tom Tromey  <tromey@adacore.com>
5161
5162         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5163         keyword to foreach.
5164
5165 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5166
5167         * linux-thread-db.c (try_thread_db_load_1): Change return type
5168         to bool.
5169         (try_thread_db_load): Likewise.
5170         (try_thread_db_load_from_pdir_1): Likewise.
5171         (try_thread_db_load_from_pdir): Likewise.
5172         (try_thread_db_load_from_sdir): Likewise.
5173         (try_thread_db_load_from_dir): Likewise.
5174         (thread_db_load_search): Likewise.
5175         (has_libpthread): Likewise.
5176         (thread_db_load): Likewise.
5177
5178 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5179
5180         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5181         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5182         NULL, and complain/return if that's the case.
5183
5184 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5185
5186         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5187         (advance, posn, abstract_read_memory): New functions.
5188         [struct mem_read_abstraction]: New struct.
5189         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5190
5191 2019-05-14  Tom Tromey  <tromey@adacore.com>
5192
5193         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5194         value is not lval_memory.
5195
5196 2019-05-14  Tom Tromey  <tromey@adacore.com>
5197
5198         * solib.c (info_sharedlibrary_command): Style the file name.
5199
5200 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5201
5202         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5203         (aarch64_vnv_type): Likewise.
5204         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5205         * common/tdesc.c: Likewise.
5206         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5207         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5208         * features/aarch64-fpu.xml: Add ieee half view.
5209         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5210         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5211         * gdbtypes.h (struct builtin_type): Likewise.
5212         (struct objfile_type): Likewise.
5213
5214 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5215
5216         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5217         typo.
5218         * location.h (string_to_event_location): Likewise.
5219
5220 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5221
5222         GDB 8.3 released.
5223
5224 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5225
5226         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5227         New variable declaration.
5228         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5229         New variable.
5230         (print_one_breakpoint): Use ui_out::test_flags and new global
5231         variable to compute use_fixed_output.
5232         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5233         Remove.
5234         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5235         (mi_multi_location_breakpoint_output_fixed): Remove.
5236         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5237         new variable.
5238         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5239         fix_multi_location_breakpoint_output flag if version >= 3.
5240         * ui-out.h (enum ui_out_flag)
5241         <fix_multi_location_breakpoint_output>: New enumerator.
5242
5243 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5244
5245         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5246
5247 2019-05-10  Tom Tromey  <tromey@adacore.com>
5248
5249         * ada-lang.c (catch_ada_completer): New function.
5250         (_initialize_ada_language): Use it.
5251
5252 2019-05-10  Tom Tromey  <tromey@adacore.com>
5253
5254         * thread.c (print_thread_info): Make "requested_threads" const.
5255         * gdbthread.h (print_thread_info): Make "requested_threads"
5256         const.
5257         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5258         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5259
5260 2019-05-08  Tom Tromey  <tom@tromey.com>
5261
5262         * gdbtypes.c (objfile_type_data): Change type.
5263         (objfile_type, _initialize_gdbtypes): Update.
5264
5265 2019-05-08  Tom Tromey  <tom@tromey.com>
5266
5267         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5268         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5269         (_initialize_dwarf2_frame): Update.
5270
5271 2019-05-08  Tom Tromey  <tom@tromey.com>
5272
5273         * objc-lang.c (objc_objfile_data): Change type.
5274         (find_methods): Update.
5275         (_initialize_objc_lang): Remove.
5276
5277 2019-05-08  Tom Tromey  <tom@tromey.com>
5278
5279         * stabsread.c (rs6000_builtin_type_data): Change type.
5280         (rs6000_builtin_type, _initialize_stabsread): Update.
5281
5282 2019-05-08  Tom Tromey  <tom@tromey.com>
5283
5284         * mips-tdep.c (mips_pdr_data): Remove.
5285         (_initialize_mips_tdep): Update.
5286
5287 2019-05-08  Tom Tromey  <tom@tromey.com>
5288
5289         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5290         (hppa_init_objfile_priv_data, read_unwind_info)
5291         (find_unwind_entry, _initialize_hppa_tdep): Update.
5292
5293 2019-05-08  Tom Tromey  <tom@tromey.com>
5294
5295         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5296         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5297         on obstack.
5298         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5299
5300 2019-05-08  Tom Tromey  <tom@tromey.com>
5301
5302         * mdebugread.c (basic_type_data): Change type.
5303         (basic_type, _initialize_mdebugread): Update.
5304
5305 2019-05-08  Tom Tromey  <tom@tromey.com>
5306
5307         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5308
5309 2019-05-08  Tom Tromey  <tom@tromey.com>
5310
5311         * nto-tdep.c (nto_inferior_data_reg): Change type.
5312         (nto_inferior_data): Update.
5313         (nto_inferior_data_cleanup, nto_new_inferior_data)
5314         (_initialize_nto_tdep): Remove.
5315         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5316
5317 2019-05-08  Tom Tromey  <tom@tromey.com>
5318
5319         * ada-lang.c (struct ada_inferior_data): Add initializers.
5320         (ada_inferior_data): Change type.
5321         (ada_inferior_data_cleanup): Remove.
5322         (get_ada_inferior_data, ada_inferior_exit)
5323         (struct ada_pspace_data): Add initializers, destructor.
5324         (ada_pspace_data_handle): Change type.
5325         (get_ada_pspace_data): Update.
5326         (ada_pspace_data_cleanup): Remove.
5327
5328 2019-05-08  Tom Tromey  <tom@tromey.com>
5329
5330         * coffread.c (struct coff_symfile_info): Add initializers.
5331         (coff_objfile_data_key): Move lower.  Change type.
5332         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5333         Update.
5334         (coff_free_info): Remove.
5335
5336 2019-05-08  Tom Tromey  <tom@tromey.com>
5337
5338         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5339         (fbsd_pspace_data_handle): Move lower.  Change type.
5340         (get_fbsd_pspace_data): Update.
5341         (fbsd_pspace_data_cleanup): Remove.
5342         (_initialize_fbsd_tdep): Update.
5343
5344 2019-05-08  Tom Tromey  <tom@tromey.com>
5345
5346         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5347         (get_ada_tasks_pspace_data): Update.
5348         (ada_tasks_pspace_data_cleanup): Remove.
5349         (_initialize_tasks): Update.
5350         (ada_tasks_inferior_data_handle): Change type.
5351         (get_ada_tasks_inferior_data): Update.
5352         (ada_tasks_inferior_data_cleanup): Remove.
5353         (struct ada_tasks_pspace_data): Add initializers.
5354
5355 2019-05-08  Tom Tromey  <tom@tromey.com>
5356
5357         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5358         * symfile-debug.c (debug_sym_get_probes): Change type.
5359         * stap-probe.c (handle_stap_probe):
5360         (stap_static_probe_ops::get_probes): Change type.
5361         * probe.h (class static_probe_ops) <get_probes>: Change type.
5362         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5363         (parse_probes_in_pspace): Update.
5364         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5365         Update.
5366         (any_static_probe_ops::get_probes): Change type.
5367         * elfread.c (elfread_data): New typedef.
5368         (probe_key): Change type.
5369         (elf_get_probes): Likewise.  Update.
5370         (probe_key_free): Remove.
5371         (_initialize_elfread): Update.
5372         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5373         Change type.
5374         (dtrace_process_dof_probe, dtrace_process_dof)
5375         (dtrace_static_probe_ops::get_probe): Change type.
5376
5377 2019-05-08  Tom Tromey  <tom@tromey.com>
5378
5379         * xcoffread.c (struct xcoff_symfile_info): Rename from
5380         coff_symfile_info.  Add initializers.
5381         (xcoff_objfile_data_key): Move lower.  Change type.
5382         (XCOFF_DATA): Rewrite.
5383         (xcoff_free_info): Remove.
5384         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5385         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5386         (xcoff_initial_scan): Update.
5387
5388 2019-05-08  Tom Tromey  <tom@tromey.com>
5389
5390         * solib-svr4.c (struct svr4_info): Add initializers and
5391         destructor.
5392         <probes_table>: Now an htab_up.
5393         (solib_svr4_pspace_data): Change type.
5394         (free_probes_table): Simplify.
5395         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5396         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5397         (probes_table_remove_objfile_probes, register_solib_event_probe)
5398         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5399         (_initialize_svr4_solib): Update.
5400
5401 2019-05-08  Tom Tromey  <tom@tromey.com>
5402
5403         * remote.c (remote_pspace_data): Change type.
5404         (remote_pspace_data_cleanup): Remove.
5405         (get_remote_exec_file, set_pspace_remote_exec_file)
5406         (_initialize_remote): Update.
5407
5408 2019-05-08  Tom Tromey  <tom@tromey.com>
5409
5410         * breakpoint.c (breakpoint_objfile_key): Change type.
5411         (get_breakpoint_objfile_data): Update.
5412         (free_breakpoint_objfile_data): Remove.
5413         (_initialize_breakpoint): Update.
5414
5415 2019-05-08  Tom Tromey  <tom@tromey.com>
5416
5417         * linux-tdep.c (struct linux_info): Add initializers.
5418         (linux_inferior_data): Move.  Change type.
5419         (invalidate_linux_cache_inf): Update.
5420         (linux_inferior_data_cleanup): Remove.
5421         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5422
5423 2019-05-08  Tom Tromey  <tom@tromey.com>
5424
5425         * auxv.c (auxv_inferior_data): Move.  Change type.
5426         (auxv_inferior_data_cleanup): Remove.
5427         (invalidate_auxv_cache_inf): Rewrite.
5428         (get_auxv_inferior_data, _initialize_auxv): Update.
5429
5430 2019-05-08  Tom Tromey  <tom@tromey.com>
5431
5432         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5433         (symfile_debug_objfile_data_key): Change type.
5434         (symfile_debug_installed, debug_qf_has_symbols)
5435         (debug_qf_find_last_source_symtab)
5436         (debug_qf_forget_cached_source_info)
5437         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5438         (debug_qf_print_stats, debug_qf_dump)
5439         (debug_qf_expand_symtabs_for_function)
5440         (debug_qf_expand_all_symtabs)
5441         (debug_qf_expand_symtabs_with_fullname)
5442         (debug_qf_map_matching_symbols)
5443         (debug_qf_expand_symtabs_matching)
5444         (debug_qf_find_pc_sect_compunit_symtab)
5445         (debug_qf_map_symbol_filenames)
5446         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5447         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5448         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5449         (debug_sym_read_linetable, debug_sym_relocate): Update.
5450         (symfile_debug_free_objfile): Remove.
5451         (install_symfile_debug_logging, _initialize_symfile_debug):
5452         Update.
5453
5454 2019-05-08  Tom Tromey  <tom@tromey.com>
5455
5456         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5457         allocate_on_obstack.
5458         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5459         (get_dwarf2_per_objfile): Update.
5460         (set_dwarf2_per_objfile): Remove.
5461         (dwarf2_has_info, dwarf2_get_section_info): Update.
5462         (dwarf2_free_objfile): Remove.
5463         (_initialize_dwarf2_read): Update.
5464
5465 2019-05-08  Tom Tromey  <tom@tromey.com>
5466
5467         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5468         initializers.
5469         <unsupported_script_warning_printed,
5470         script_not_found_warning_printed>: Now bool.
5471         (auto_load_pspace_data): Change type.
5472         (~auto_load_pspace_info): Rename from
5473         auto_load_pspace_data_cleanup.
5474         (get_auto_load_pspace_data, init_loaded_scripts_info)
5475         (clear_section_scripts, maybe_print_unsupported_script_warning)
5476         (maybe_print_script_not_found_warning, _initialize_auto_load):
5477         Update.
5478
5479 2019-05-08  Tom Tromey  <tom@tromey.com>
5480
5481         * objfiles.c (objfile_pspace_info): Add destructor and
5482         initializers.
5483         (objfiles_pspace_data): Change type.
5484         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5485         (get_objfile_pspace_data): Update.
5486         (objfiles_bfd_data): Change type.
5487         (get_objfile_bfd_data): Update.
5488         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5489
5490 2019-05-08  Tom Tromey  <tom@tromey.com>
5491
5492         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5493         Change type.
5494         (get_catch_syscall_inferior_data): Update.
5495         (catch_syscall_inferior_data_cleanup): Remove.
5496         (_initialize_break_catch_syscall): Update.
5497
5498 2019-05-08  Tom Tromey  <tom@tromey.com>
5499
5500         * inflow.c (struct terminal_info): Add destructor and
5501         initializers.
5502         (inflow_inferior_data): Change type.
5503         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5504         (get_inflow_inferior_data, inflow_inferior_exit)
5505         (swap_terminal_info, _initialize_inflow): Update.
5506
5507 2019-05-08  Tom Tromey  <tom@tromey.com>
5508
5509         * target-dcache.c (target_dcache_cleanup): Remove.
5510         (target_dcache_aspace_key): Change type.
5511         (target_dcache_init_p, target_dcache_invalidate)
5512         (target_dcache_get, target_dcache_get_or_init)
5513         (_initialize_target_dcache): Update.
5514         * dcache.h (struct dcache_deleter): New.
5515
5516 2019-05-08  Tom Tromey  <tom@tromey.com>
5517
5518         * symtab.c (struct symbol_cache): Add destructor and
5519         initializers.
5520         (symbol_cache_key): Move.  Change type.
5521         (make_symbol_cache, free_symbol_cache): Remove.
5522         (get_symbol_cache): Update.
5523         (symbol_cache_cleanup): Remove.
5524         (ALL_PSPACES, symbol_cache_flush)
5525         (maintenance_print_symbol_cache)
5526         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5527         Update.
5528
5529 2019-05-08  Tom Tromey  <tom@tromey.com>
5530
5531         * symtab.c (struct main_info): Add destructor and initializers.
5532         (main_progspace_key): Move.  Change type.
5533         (get_main_info): Update.
5534         (main_info_cleanup): Remove.
5535         (_initialize_symtab): Update.
5536
5537 2019-05-08  Tom Tromey  <tom@tromey.com>
5538
5539         * registry.h (DECLARE_REGISTRY): Define the _key class.
5540
5541 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5542
5543         * NEWS: Merge two 'New commands' sections.
5544
5545 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5546
5547         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5548         parameter and use Ada language definition instead.
5549         (ada_val_print_ptr): Remove unused language parameter.
5550         (ada_val_print_num): Remove language parameter and use Ada language
5551         definition instead.
5552         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5553         parameter.
5554         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5555         parameter and use Ada language definition instead.
5556         (ada_val_print_1): Update all ada_val_print_xxx calls.
5557         Remove language parameter.
5558         (ada_val_print): Update ada_val_print_1 call.
5559
5560 2019-05-08  Tom Tromey  <tromey@adacore.com>
5561
5562         * remote.c (remote_hw_watchpoint_limit)
5563         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5564         Now static.
5565
5566 2019-05-08  Tom Tromey  <tromey@adacore.com>
5567
5568         * maint.c (_initialize_maint_cmds): Move initialization code to
5569         remote.c.
5570         (watchdog, show_watchdog): Move to remote.c.
5571         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5572         "watchdog" static.
5573         (_initialize_remote): Move initialization code from maint.c.
5574         * defs.h (watchdog): Don't declare.
5575
5576 2019-05-08  Tom Tromey  <tromey@adacore.com>
5577
5578         * tui/tui-interp.c: Include main.h.
5579         * interps.c: Include main.h.
5580         * main.h (interpreter_p): Declare.
5581         * defs.h (interpreter_p): Don't declare.
5582
5583 2019-05-08  Tom Tromey  <tromey@adacore.com>
5584
5585         * dwarf2loc.c: Include dwarf2read.h.
5586         * defs.h (read_unsigned_leb128): Don't declare.
5587         * dwarf2read.h (read_unsigned_leb128): Declare.
5588
5589 2019-05-08  Tom Tromey  <tromey@adacore.com>
5590
5591         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5592         method.
5593
5594 2019-05-08  Tom Tromey  <tromey@adacore.com>
5595
5596         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5597         when no wrap column is set.
5598
5599 2019-05-08  Tom Tromey  <tromey@adacore.com>
5600
5601         * c-lang.c (c_get_string): Handle non-C-style arrays.
5602
5603 2019-05-08  Tom Tromey  <tromey@adacore.com>
5604
5605         * typeprint.c (print_offset_data::update): Print the bit offset,
5606         not the number of bits remaining.
5607
5608 2019-05-08  Tom Tromey  <tromey@adacore.com>
5609
5610         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5611         padding at end of comment.
5612
5613 2019-05-08  Tom Tromey  <tromey@adacore.com>
5614
5615         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5616         Compare main types.
5617
5618 2019-05-06  Tom Tromey  <tom@tromey.com>
5619
5620         * common/scoped_mmap.c: Include common-defs.h.
5621         * common/scoped_mmap.h: Don't include config.h.
5622
5623 2019-05-04  Tom Tromey  <tom@tromey.com>
5624
5625         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5626         (struct aarch64_call_info): Add initializers.
5627         <si>: Now a std::vector.
5628         (pass_on_stack, aarch64_push_dummy_call): Update.
5629
5630 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
5631             Tom Tromey  <tom@tromey.com>
5632
5633         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5634         (ppc_threads): Now a std::vector.  Now static.
5635         (hwdebug_find_thread_points_by_tid)
5636         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5637         Update.
5638
5639 2019-05-04  Tom Tromey  <tom@tromey.com>
5640
5641         * arc-tdep.c (arc_tdesc_init): Return bool.
5642
5643 2019-05-04  Tom Tromey  <tom@tromey.com>
5644
5645         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5646         Use gdb_assert_not_reached.
5647
5648 2019-05-04  Tom Tromey  <tom@tromey.com>
5649
5650         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5651         "false".
5652
5653 2019-05-04  Tom Tromey  <tom@tromey.com>
5654
5655         * arc-tdep.c (arc_tdesc_init): Use bool.
5656
5657 2019-05-04  Tom Tromey  <tom@tromey.com>
5658
5659         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5660
5661 2019-05-04  Tom Tromey  <tom@tromey.com>
5662
5663         * cli/cli-cmds.c (valid_command_p): Return bool.
5664
5665 2019-05-04  Tom Tromey  <tom@tromey.com>
5666
5667         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5668         * command.h (valid_user_defined_cmd_name_p): Channge return type.
5669
5670 2019-05-04  Raul Tambre  <raul@tambre.ee>
5671
5672         * python/lib/gdb/prompt.py (_ExtendedPrompt)
5673         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5674         operator for comparison.
5675
5676 2019-05-04  Tom Tromey  <tom@tromey.com>
5677
5678         * psymtab.c (psymbol_name_matches, match_partial_symbol)
5679         (lookup_partial_symbol, print_partial_symbols)
5680         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5681         (psymbol_compare): Update.
5682         (add_psymbol_to_bcache): Clear the entire psymbol.
5683         (maintenance_check_psymtabs): Update.
5684         * psympriv.h (struct partial_symbol): Don't derive from
5685         general_symbol_info.
5686         <obj_section, unrelocated_address, address,
5687         set_unrelocated_address>: Update.
5688         <ginfo>: New member.
5689         * dwarf-index-write.c (write_psymbols, debug_names::insert)
5690         (debug_names::write_psymbols): Update.
5691
5692 2019-05-04  Tom de Vries  <tdevries@suse.de>
5693
5694         * contrib/cc-with-tweaks.sh: Support -n arg.
5695
5696 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5697
5698         * corelow.c (core_target::detach): Ensure frame cache and
5699         register caches are cleared.
5700         inferior.c (exit_inferior_1): Likewise.
5701
5702 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
5703             Tom Tromey  <tom@tromey.com>
5704
5705         * dictionary.c (collate_pending_symbols_by_language): Remove
5706         "struct" from foreach.
5707         * symtab.c (lookup_global_symbol_from_objfile)
5708         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5709         foreach.
5710         * ser-tcp.c (net_open): Remove "struct" from foreach.
5711         * objfiles.c (objfile_relocate, objfile_rebase)
5712         (objfile_has_symbols): Remove "struct" from foreach.
5713         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5714         from foreach.
5715         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5716         foreach.
5717         * darwin-nat.c (thread_info_from_private_thread_info): Remove
5718         "struct" from foreach.
5719         * ada-lang.c (create_excep_cond_exprs)
5720         (ada_exception_catchpoint_cond_string): Remove "struct" from
5721         foreach.
5722
5723 2019-05-03  Tom Tromey  <tromey@adacore.com>
5724
5725         * ada-exp.y (convert_char_literal): Check suffix of each
5726         enumerator.
5727
5728 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
5729
5730         PR ada/21406:
5731         * ada-exp.y (yywrap): Don't define.
5732         * ada-lex.l (%option): Add noyywrap
5733         (yywrap): Remove.
5734
5735 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
5736
5737         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5738         _WIN32_WINNT to the XP level, unless already defined to a higher
5739         level.
5740
5741         * unittests/parse-connection-spec-selftests.c:
5742         * ser-tcp.c:
5743         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
5744         override.
5745
5746         * symfile.c (find_separate_debug_file): Remove colon from the
5747         drive spec of DOS/Windows file names of the target, so that the
5748         file name produced from DEBUGDIR and the target's directory will
5749         be valid on DOS/Windows systems.
5750
5751 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5752
5753         * rust-lang.c (val_print_struct): Handle printing structures
5754         containing strings.
5755
5756 2019-05-02  Tom Tromey  <tromey@adacore.com>
5757
5758         * valarith.c (_initialize_valarith): Remove.
5759
5760 2019-05-01  Tom Tromey  <tromey@adacore.com>
5761
5762         * ada-lang.c (ada_value_primitive_field): Treat more fields as
5763         bitfields.
5764
5765 2019-05-01  Tom Tromey  <tromey@adacore.com>
5766
5767         * ada-lang.c (ada_value_assign): Correctly compute starting offset
5768         for big-endian copies.
5769
5770 2019-04-30  Ali Tamur  <tamur@google.com>
5771         * gdb/dwarf2read.c (read_3_bytes): New declaration.
5772         (read_attribute_value): Added DW_FORM_strx1-4 cases.
5773         (read_3_bytes): New function.
5774
5775 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5776
5777         * windows-nat.c (main_thread_id): Delete.
5778         (handle_output_debug_string): Replace main_thread_id by
5779         current_event.dwThreadId.
5780         (fake_create_process): Likewise.
5781         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5782         Do not set main_thread_id.
5783         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5784         current_event.dwThreadId.
5785         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5786
5787 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
5788
5789         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5790         Use current_event.dwThreadId instead of main_thread_id.
5791
5792 2019-04-30  Tom Tromey  <tromey@adacore.com>
5793
5794         * ada-lang.c (ada_lookup_simple_minsyms): New function.
5795         (create_excep_cond_exprs): Iterate over program spaces.
5796         (ada_exception_catchpoint_cond_string): Examine all minimal
5797         symbols for exception types.
5798
5799 2019-04-30  Tom Tromey  <tromey@adacore.com>
5800
5801         PR c++/24470:
5802         * dwarf2read.c (process_structure_scope): Handle case where type
5803         has template parameters but no symbol was created.
5804
5805 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5806             Chris January  <chris.january@arm.com>
5807
5808         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5809         qualifier.
5810         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5811
5812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5813
5814         * f-typeprint.c (f_print_type): Update rules for printing
5815         whitespace.
5816         (f_type_print_varspec_suffix): Likewise.
5817
5818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5819             Chris January  <chris.january@arm.com>
5820
5821         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5822         function arguments.
5823
5824 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5825
5826         * f-lang.c (build_fortran_types): Change name of void type to
5827         lower case.
5828         * f-typeprint.c (f_type_print_base): Print the name of the void
5829         type, rather than a fixed string.
5830         * f-valprint.c (f_decorations): Use lower case void string.
5831
5832 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5833             Chris January  <chris.january@arm.com>
5834
5835         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5836         types for Fortran.
5837
5838 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5839             Chris January  <chris.january@arm.com>
5840             David Lecomber  <david.lecomber@arm.com>
5841
5842         * f-exp.y (BINOP_INTRINSIC): New token.
5843         (exp): New parser rule handling BINOP_INTRINSIC.
5844         (f77_keywords): Add new builtin procedures.
5845         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5846         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5847         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5848         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5849         (print_unop_subexp_f): New function.
5850         (print_binop_subexp_f): New function.
5851         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5852         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5853         (dump_subexp_body_f): Likewise.
5854         (operator_check_f): Likewise.
5855         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5856         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5857
5858 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5861         UNOP_KIND.
5862         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5863         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5864         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5865         (operator_length_f): New fuction.
5866         (print_subexp_f): New function.
5867         (op_name_f): New function.
5868         (dump_subexp_body_f): New function.
5869         (operator_check_f): New function.
5870         (exp_descriptor_f): Replace standard expression handling functions
5871         with new functions.
5872         * gdb/fortran-operator.def: New file.
5873         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5874         * gdb/std-operator.def: Remove UNOP_KIND.
5875
5876 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
5877
5878         * std-operator.def: Remove unbalanced, stray double quote
5879         character.
5880
5881 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5882             Chris January  <chris.january@arm.com>
5883             Daniel Everett  <daniel.everett@arm.com>
5884             Nick Forrington  <nick.forrington@arm.com>
5885             Richard Bunt  <richard.bunt@arm.com>
5886
5887         * cp-valprint.c (cp_print_value_fields): Allow an additional level
5888         of depth when printing anonymous structs or unions.
5889         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5890         Don't print either the top-level value, or the children if the
5891         max-depth is exceeded.
5892         (ppscm_print_children): When printing the key of a map, allow one
5893         extra level of depth.
5894         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5895         print either the top-level value, or the children if the max-depth
5896         is exceeded.
5897         (print_children): When printing the key of a map, allow one extra
5898         level of depth.
5899         * python/py-value.c (valpy_format_string): Add max_depth keyword.
5900         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5901         (user_print_options): Initialise max_depth field.
5902         (val_print_scalar_or_string_type_p): New function.
5903         (val_print): Check to see if the max depth has been reached.
5904         (val_print_check_max_depth): Define new function.
5905         (show_print_max_depth): New function.
5906         (_initialize_valprint): Add 'print max-depth' option.
5907         * valprint.h (struct value_print_options) <max_depth>: New field.
5908         (val_print_check_max_depth): Declare new function.
5909         * NEWS: Document new feature.
5910
5911 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5912
5913         * ada-lang.c (ada_language_defn): Initialise new field.
5914         * c-lang.c (c_is_string_type_p): New function.
5915         (c_language_defn): Initialise new field.
5916         (cplus_language_defn): Initialise new field.
5917         (asm_language_defn): Initialise new field.
5918         (minimal_language_defn): Initialise new field.
5919         * c-lang.h (c_is_string_type_p): Declare new function.
5920         * d-lang.c (d_language_defn): Initialise new field.
5921         * f-lang.c (f_is_string_type_p): New function.
5922         (f_language_defn): Initialise new field.
5923         * go-lang.c (go_is_string_type_p): New function.
5924         (go_language_defn): Initialise new field.
5925         * language.c (default_is_string_type_p): New function.
5926         (unknown_language_defn): Initialise new field.
5927         (auto_language_defn): Initialise new field.
5928         * language.h (struct language_defn) <la_is_string_type_p>: New
5929         member variable.
5930         (default_is_string_type_p): Declare new function.
5931         * m2-lang.c (m2_language_defn): Initialise new field.
5932         * objc-lang.c (objc_language_defn): Initialise new field.
5933         * opencl-lang.c (opencl_language_defn): Initialise new field.
5934         * p-lang.c (pascal_is_string_type_p): New function.
5935         (pascal_language_defn): Initialise new field.
5936         * rust-lang.c (rust_is_string_type_p): New function.
5937         (rust_language_defn): Initialise new field.
5938
5939 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5940
5941         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5942         New field.
5943         * ada-lang.c (ada_language_defn): Initialise new field.
5944         * c-lang.c (c_language_defn): Likewise.
5945         (cplus_language_defn): Likewise.
5946         (asm_language_defn): Likewise.
5947         (minimal_language_defn): Likewise.
5948         * d-lang.c (d_language_defn): Likewise.
5949         * f-lang.c (f_language_defn): Likewise.
5950         * go-lang.c (go_language_defn): Likewise.
5951         * language.c (unknown_language_defn): Likewise.
5952         (auto_language_defn): Likewise.
5953         * m2-lang.c (m2_language_defn): Likewise.
5954         * objc-lang.c (objc_language_defn): Likewise.
5955         * opencl-lang.c (opencl_language_defn): Likewise.
5956         * p-lang.c (pascal_language_defn): Likewise.
5957         * rust-lang.c (rust_language_defn): Likewise.
5958
5959 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
5960
5961         * ada-lang.c (ada_is_character_type): Change return type to bool.
5962         (ada_is_string_type): Likewise.
5963         * ada-lang.h (ada_is_character_type): Update declaration
5964         (ada_is_string_type): Likewise.
5965
5966 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5967
5968         Support style in 'frame|thread apply'
5969
5970         * gdbcmd.h (execute_command_to_string): New term_out parameter.
5971         * record.c (record_start, record_stop): Update callers of
5972         execute_command_to_string with false.
5973         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5974         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5975         methods.
5976         (class string_file): New constructor with term_out parameter.
5977         Override methods term_out and can_emit_style_escape.  New member
5978         term_out.
5979         (class stdio_file): Override can_emit_style_escape.
5980         (class tee_file): Override term_out and can_emit_style_escape.
5981         * utils.h (can_emit_style_escape): Remove.
5982         * utils.c (can_emit_style_escape): Likewise.
5983         Update all callers of can_emit_style_escape (SOMESTREAM) to
5984         SOMESTREAM->can_emit_style_escape.
5985         * source-cache.c (source_cache::get_source_lines): Likewise.
5986         * stack.c (frame_apply_command_count): Call execute_command_to_string
5987         passing the term_out characteristic of the current gdb_stdout.
5988         * thread.c (thr_try_catch_cmd): Likewise.
5989         * top.c (execute_command_to_string): pass term_out parameter
5990         to construct the string_file for the command output.
5991         * ui-file.c (term_cli_styling): New function (most code moved
5992         from utils.c can_emit_style_escape).
5993         (string_file::string_file, string_file::can_emit_style_escape,
5994         stdio_file::can_emit_style_escape, tee_file::term_out,
5995         tee_file::can_emit_style_escape): New functions.
5996
5997 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5998
5999         * NEWS: Mention the new set|show may-call-functions.
6000         * infcall.c (may_call_functions_p): New variable.
6001         (show_may_call_functions_p): New function.
6002         (call_function_by_hand_dummy): Throws an error if not
6003         may-call-functions.
6004         (_initialize_infcall): Call add_setshow_boolean_cmd for
6005         may-call-functions.
6006
6007 2019-04-25  Keith Seitz  <keiths@redhat.com>
6008
6009         PR c++/24367
6010         * cp-support.c (inspect_type): Don't attempt substitutions
6011         of symbol with the same name.
6012
6013 2019-04-25  Tom Tromey  <tromey@adacore.com>
6014
6015         PR gdb/24475:
6016         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6017         static.
6018
6019 2019-04-25  Tom Tromey  <tromey@adacore.com>
6020
6021         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6022         rvalue reference.
6023         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6024         (gdb_xml_parser::parse): Use std::move.
6025         * python/python-internal.h (gdbpy_convert_exception): Take a const
6026         reference.
6027         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6028         std::move.
6029         * python/py-utils.c (gdbpy_convert_exception): Take a const
6030         reference.
6031         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6032         Use std::move.
6033         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6034         Use std::move.
6035         * mi/mi-main.c (mi_print_exception): Take a const reference.
6036         * main.c (handle_command_errors): Take a const reference.
6037         * linespec.c (parse_linespec): Use std::move.
6038         * infcall.c (run_inferior_call): Use std::move.
6039         (call_function_by_hand_dummy): Use std::move.
6040         * exec.c (try_open_exec_file): Use std::move.
6041         * exceptions.h (exception_print, exception_fprintf)
6042         (exception_print_same): Update.
6043         * exceptions.c (print_exception, exception_print)
6044         (exception_fprintf, exception_print_same): Change parameters to
6045         const reference.
6046         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6047         * common/new-op.c: Use std::move.
6048         * common/common-exceptions.h (struct gdb_exception): Add move
6049         constructor.
6050         (struct gdb_exception_error, struct gdb_exception_quit, struct
6051         gdb_quit_bad_alloc): Change constructor to move constructor.
6052         (throw_exception): Change parameter to rvalue reference.
6053         * common/common-exceptions.c (throw_exception): Take rvalue
6054         reference.
6055         * cli/cli-interp.c (safe_execute_command): Use std::move.
6056         * breakpoint.c (insert_bp_location, location_to_sals): Use
6057         std::move.
6058
6059 2019-04-25  Tom Tromey  <tromey@adacore.com>
6060
6061         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6062         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6063         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6064         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6065         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6066         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6067         guile/scm-value.c: Use unpack.
6068         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6069         gdbscm_gdb_exception.
6070         (gdbscm_throw_gdb_exception): Likewise.
6071         (struct gdbscm_gdb_exception): New.
6072         (unpack): New function.
6073         (gdbscm_wrap): Use unpack.
6074
6075 2019-04-25  Tom Tromey  <tromey@adacore.com>
6076
6077         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6078         (gdb_rl_callback_handler): Use std::move.
6079         * common/common-exceptions.h (struct gdb_exception): Add move
6080         assignment operator.
6081         (throw_exception_sjlj): Change "exception" to const reference.
6082         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6083         (throw_exception_sjlj): Change "exception" to const reference.
6084
6085 2019-04-25  Tom Tromey  <tromey@adacore.com>
6086
6087         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6088         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6089         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6090         Update.
6091         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6092         Update.
6093         * mi/mi-interp.c (mi_interp::exec): Update.
6094         * linespec.c (parse_linespec): Update.
6095         * infcall.c (run_inferior_call): Update.
6096         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6097         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6098         (gdbscm_lookup_global_symbol): Update.
6099         * guile/scm-param.c (gdbscm_parameter_value): Update.
6100         * guile/scm-frame.c (gdbscm_frame_read_register)
6101         (gdbscm_frame_read_var): Update.
6102         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6103         * exec.c (try_open_exec_file): Update.
6104         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6105         (gdb_rl_callback_handler): Update.
6106         * common/common-exceptions.h (exception_none): Don't declare.
6107         * common/common-exceptions.c (exception_none): Don't define.
6108         (struct catcher) <exception>: Update.
6109         * cli/cli-interp.c (safe_execute_command): Update.
6110         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6111
6112 2019-04-25  Ali Tamur  <tamur@google.com>
6113
6114         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6115         (read_attribute_value): Likewise.
6116         (dwarf2_read_addr_index): Update comment.
6117         (read_str_index): Add DW_FORM_strx.
6118         (dwarf2_string_attr): Likewise.
6119         (dwarf2_const_value_attr): Likewise.
6120         (dump_die_shallow): Likewise.
6121         (dwarf2_fetch_constant_bytes): Likewise.
6122         (skip_form_bytes): Likewise.
6123         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6124
6125 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6126
6127         PR corefiles/11608
6128         PR corefiles/18187
6129         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6130         OFFSET.  Verify if current mapping contains an ELF header.
6131         (linux_find_memory_regions_full): Adjust call to
6132         dump_mapping_p.
6133
6134 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6135             Kang Li <kanglictf@gmail.com>
6136
6137         PR gdb/21600
6138
6139         * dwarf2-frame.c (read_initial_length): Be consistent about using
6140         unsigned representation of length.
6141         (decode_frame_entry_1): Likewise.  Check for wraparound of
6142         end pointer as well as buffer overflow.
6143
6144 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6145
6146         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6147         "vq".
6148
6149 2019-04-24  Tom Tromey  <tromey@adacore.com>
6150
6151         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6152
6153 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6154
6155         * s12z-tdep.c (s12z_unwind_pc): Delete.
6156         (s12z_unwind_sp): Delete.
6157         (s12z_gdbarch_init): Don't register deleted functions with
6158         gdbarch.
6159
6160 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6161
6162         * rl78-tdep.c (rl78_unwind_sp): Delete.
6163         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6164
6165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6166
6167         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6168         (xstormy16_unwind_pc): Delete.
6169         (xstormy16_dummy_id): Delete.
6170         (xstormy16_gdbarch_init): Don't register deleted functions with
6171         gdbarch.
6172
6173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6174
6175         * vax-tdep.c (vax_unwind_pc): Delete.
6176         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6177
6178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6179
6180         * v850-tdep.c (v850_unwind_sp): Delete.
6181         (v850_unwind_pc): Delete.
6182         (v850_dummy_id): Delete.
6183         (v850_gdbarch_init): Don't register deleted functions with
6184         gdbarch.
6185
6186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6187
6188         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6189         (tilegx_unwind_pc): Delete.
6190         (tilegx_unwind_dummy_id): Delete.
6191         (tilegx_gdbarch_init): Don't register deleted functions with
6192         gdbarch.
6193
6194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6195
6196         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6197         (tic6x_dummy_id): Delete.
6198         (tic6x_gdbarch_init): Don't register deleted functions with
6199         gdbarch.
6200
6201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6202
6203         * sparc-tdep.c (sparc_unwind_pc): Delete.
6204         (sparc32_gdbarch_init): Don't register deleted function with
6205         gdbarch.
6206
6207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6208
6209         * sh-tdep.c (sh_unwind_sp): Delete.
6210         (sh_unwind_pc): Delete.
6211         (sh_dummy_id): Delete.
6212         (sh_gdbarch_init): Don't register deleted functions with
6213         gdbarch.
6214
6215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6216
6217         * score-tdep.c (score_unwind_sp): Delete.
6218         (score_unwind_pc): Delete.
6219         (score_dummy_id): Delete.
6220         (score_gdbarch_init): Don't register deleted functions with
6221         gdbarch.
6222
6223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6224
6225         * rx-tdep.c (rx_unwind_pc): Delete.
6226         (rx_unwind_sp): Delete.
6227         (rx_dummy_id): Delete.
6228         (rx_gdbarch_init): Don't register deleted functions with
6229         gdbarch.  Update comment.
6230
6231 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6232
6233         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6234         (rs6000_dummy_id): Delete.
6235         (rs6000_gdbarch_init): Don't register deleted functions with
6236         gdbarch.
6237
6238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         * or1k-tdep.c (or1k_dummy_id): Delete.
6241         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6242
6243 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6244
6245         * nios2-tdep.c (nios2_dummy_id): Delete.
6246         (nios2_unwind_sp): Delete.
6247         (nios2_gdbarch_init): Don't register deleted functions with
6248         gdbarch.
6249
6250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6251
6252         * nds32-tdep.c (nds32_dummy_id): Delete.
6253         (nds32_unwind_pc): Delete.
6254         (nds32_unwind_sp): Delete.
6255         (nds32_gdbarch_init): Don't register deleted functions with
6256         gdbarch.
6257
6258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6259
6260         * msp430-tdep.c (msp430_unwind_pc): Delete.
6261         (msp430_unwind_sp): Delete.
6262         (msp430_dummy_id): Delete.
6263         (msp430_gdbarch_init): Don't register deleted functions with
6264         gdbarch.
6265
6266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6267
6268         * moxie-tdep.c (moxie_unwind_sp): Delete.
6269         (moxie_unwind_pc): Delete.
6270         (moxie_dummy_id): Delete.
6271         (moxie_gdbarch_init): Don't register deleted functions with
6272         gdbarch.
6273
6274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6275
6276         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6277         (mn10300_unwind_pc): Delete.
6278         (mn10300_unwind_sp): Delete.
6279         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6280         mn10300_unwind_sp.
6281         (mn10300_frame_unwind_init): Don't register deleted functions with
6282         gdbarch.
6283
6284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6285
6286         * mep-tdep.c (mep_unwind_pc): Delete.
6287         (mep_unwind_sp): Delete.
6288         (mep_dummy_id): Delete.
6289         (mep_gdbarch_init): Don't register deleted functions with
6290         gdbarch.
6291
6292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6293
6294         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6295         (m68hc11_unwind_sp): Delete.
6296         (m68hc11_gdbarch_init): Don't register deleted functions with
6297         gdbarch.
6298
6299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * m32r-tdep.c (m32r_unwind_sp): Delete.
6302         (m32r_unwind_pc): Delete.
6303         (m32r_dummy_id): Delete.
6304         (m32r_gdbarch_init): Don't register deleted functions with
6305         gdbarch.
6306
6307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6308
6309         * m32c-tdep.c (m32c_unwind_pc): Delete.
6310         (m32c_unwind_sp): Delete.
6311         (m32c_dummy_id): Delete.
6312         (m32c_gdbarch_init): Don't register deleted functions with
6313         gdbarch.
6314
6315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6316
6317         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6318         (lm32_unwind_pc): Delete.
6319         (lm32_dummy_id): Delete.
6320         (lm32_gdbarch_init): Don't register deleted functions with
6321         gdbarch.
6322
6323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6324
6325         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6326         (iq2000_unwind_pc): Delete.
6327         (iq2000_dummy_id): Delete.
6328         (iq2000_gdbarch_init): Don't register deleted functions with
6329         gdbarch.
6330
6331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6332
6333         * nds32-tdep.c (nds32_type_align): Delete.
6334         (nds32_push_dummy_call): Use type_align instead.
6335
6336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6337
6338         * arm-tdep.c (arm_type_align): Only handle vector override case.
6339         (arm_push_dummy_call): Use type_align.
6340         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6341
6342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6343
6344         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6345         case.
6346         (pass_on_stack): Use type_align.
6347         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6348         function.
6349
6350 2019-04-23  Tom Tromey  <tromey@adacore.com>
6351
6352         * dwarf2read.c (line_header::file_name_at): Remove unused
6353         overload.
6354
6355 2019-04-23  Tom de Vries  <tdevries@suse.de>
6356
6357         PR gdb/24438
6358         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6359         invocation.
6360
6361
6362 2019-03-27  Ali Tamur  <tamur@google.com>
6363
6364         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6365         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6366         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6367         (dwarf_expr_context::get_addr_index): Likewise
6368         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6369         (symbol_needs_eval_context::get_addr_index): Likewise
6370         (disassemble_dwarf_expression): Add DW_OP_addrx
6371         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6372         (read_cutu_die_from_dwo): Update comment
6373         (skip_one_die): Add DW_FORM_addrx
6374         (read_attribute_value): Likewise
6375         (var_decode_location): Add DW_OP_addrx
6376         (dwarf2_const_value_attr): Add DW_FORM_addrx
6377         (dump_die_shallow): Likewise
6378         (dwarf2_fetch_constant_bytes): Likewise
6379         (decode_locdesc): Add DW_OP_addrx
6380         (skip_form_bytes): Add DW_FORM_addrx
6381
6382 2019-04-22  Ali Tamur  <tamur@google.com>
6383
6384         * MAINTAINERS (Write After Approval): Add self.
6385
6386 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6387
6388         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6389         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6390         (open_symbol_file_object): Likewise.
6391         (svr4_default_sos): Add info parameter.
6392         (svr4_read_so_list): Likewise.
6393         (svr4_current_sos_direct): Adjust functions calls to pass down
6394         info.
6395         (svr4_current_sos_1): Add info parameter.
6396         (svr4_current_sos): Call get_svr4_info, pass info down to
6397         svr4_current_sos_1.
6398         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6399         get_svr4_info.
6400         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6401         get_svr4_info.
6402         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6403         to get_svr4_info.
6404         (probes_table_remove_objfile_probes): Likewise.
6405         (register_solib_event_probe): Add info parameter.
6406         (solist_update_incremental): Pass info parameter down to
6407         svr4_read_so_list.
6408         (disable_probes_interface): Add info parameter.
6409         (svr4_handle_solib_event): Pass current_program_space to
6410         get_svr4_info.  Adjust disable_probes_interface cleanup.
6411         (svr4_create_probe_breakpoints): Add info parameter, pass it
6412         down to register_solib_event_probe.
6413         (svr4_create_solib_event_breakpoints): Add info parameter,
6414         pass it down to svr4_create_probe_breakpoints.
6415         (enable_break): Pass info down to
6416         svr4_create_solib_event_breakpoints.
6417         (svr4_solib_create_inferior_hook): Pass current_program_space to
6418         get_svr4_info.
6419         (svr4_clear_solib): Likewise.
6420
6421 2019-04-22  Pedro Alves  <palves@redhat.com>
6422
6423         * solib-svr4.c (svr4_free_objfile_observer): New.
6424         (probe_and_action::objfile): New field.
6425         (probes_table_htab_remove_objfile_probes)
6426         (probes_table_remove_objfile_probes): New functions.
6427         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6428         in the new probe_and_action.  Don't store the probe in 'lookup'.
6429         (svr4_create_probe_breakpoints): Pass objfile to
6430         register_solib_event_probe.
6431         (_initialize_svr4_solib): Register a free_objfile observer.
6432
6433 2019-04-19  Tom Tromey  <tom@tromey.com>
6434
6435         * common/queue.h: Remove.
6436
6437 2019-04-19  Tom Tromey  <tom@tromey.com>
6438
6439         * event-loop.c: Don't include "common/queue.h".
6440
6441 2019-04-19  Tom Tromey  <tom@tromey.com>
6442
6443         * remote.c (remote_target): Use delete.
6444         * remote-notif.h: Include <list>, not "common/queue.h".
6445         (notif_client_p): Remove typedef.
6446         (remote_notif_state): Add constructor, destructor, initializer.
6447         <notif_queue>: Now a std::list.
6448         (remote_notif_state_xfree): Don't declare.
6449         * remote-notif.c (remote_notif_process, handle_notification)
6450         (remote_notif_state_allocate): Update.
6451         (~remote_notif_state): Rename from remote_notif_state_xfree.
6452
6453 2019-04-19  Tom Tromey  <tom@tromey.com>
6454
6455         * symfile.c (reread_symbols): Update.
6456         * objfiles.c (objfile_register_static_link)
6457         (objfile_lookup_static_link): Update
6458         (~objfile) Don't delete static_links.
6459         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6460
6461 2019-04-19  Tom Tromey  <tom@tromey.com>
6462
6463         * type-stack.h (struct type_stack) <insert>: Constify string.
6464         * type-stack.c (type_stack::insert): Constify string.
6465         * gdbtypes.h (lookup_template_type): Update.
6466         (address_space_name_to_int): Update.
6467         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6468         const.
6469         (lookup_template_type): Make name const.
6470         * c-exp.y: Update rules.
6471         (lex_one_token, classify_name, classify_inner_name)
6472         (c_print_token): Update.
6473         * p-exp.y: Update rules.
6474         (yylex): Update.
6475         * f-exp.y: Update rules.
6476         (yylex): Update.
6477         * d-exp.y: Update rules.
6478         (lex_one_token, classify_name, classify_inner_name): Update.
6479         * parse.c (write_dollar_variable, copy_name): Return std::string.
6480         * parser-defs.h (copy_name): Change return type.
6481         * m2-exp.y: Update rules.
6482         (yylex): Update.
6483         * go-exp.y (lex_one_token): Update.
6484         Update rules.
6485         (classify_unsafe_function, classify_packaged_name)
6486         (classify_name, yylex): Update.
6487
6488 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6489
6490         * configure.ac: add --enable-source-highlight switch.
6491         * configure: Regenerate.
6492         * top.c (print_gdb_version): plumb --enable-source-highlight
6493         status to "show configuration".
6494
6495 2019-04-19  Tom Tromey  <tromey@adacore.com>
6496
6497         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6498         Check ADA_TYPE_P.
6499         (empty_record, ada_template_to_fixed_record_type_1)
6500         (template_to_static_fixed_type)
6501         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6502         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6503         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6504         macros.
6505
6506 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6507
6508         PR symtab/24423:
6509         * source.c (print_source_lines_base): Advance "iter" when a
6510         control character is seen.
6511
6512 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6513
6514         * inferior.h (struct infcall_suspend_state_deleter):
6515         Catch exception in destructor to avoid crash.
6516
6517 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6518
6519         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6520         close to the add_com "shell".
6521
6522 2019-04-18  Tom Tromey  <tromey@adacore.com>
6523
6524         * process-stratum-target.h (class process_stratum_target)
6525         <stratum>: Add "final".
6526
6527 2019-04-17  Tom Tromey  <tromey@adacore.com>
6528
6529         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6530         against nullptr before use.
6531
6532 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6533
6534         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6535
6536 2019-04-17  Jim Wilson  <jimw@sifive.com>
6537             Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6540         code read might fail, assume 4-byte breakpoint in that case.
6541
6542 2019-04-15  Leszek Swirski  <leszeks@google.com>
6543
6544         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6545         rather than a hand-rolled POD check when checking for forced MEMORY
6546         classification.
6547
6548 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6549
6550         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6551         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6552         function.
6553         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6554         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6555         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6556         declaration.
6557
6558 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6559
6560         * aarch64-linux-nat.c
6561         (aarch64_linux_nat_target::thread_architecture): Add override.
6562         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6563         each VQ.
6564
6565 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6566
6567         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6568
6569 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6570
6571         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6572         target types of size 96-bits, add some additional comments, and
6573         check that the builtin type we found was the correct size.
6574
6575 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6576
6577         * utils.c (prompt_for_continue): Don't restore the styling at the
6578         end, as applied_style has the wrong value.  This fixes styling in
6579         long lists of file names that are interrupted by the "Continue?"
6580         prompt.
6581
6582 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6585         * c-lang.c (c_language_defn): Likewise.
6586         (cplus_language_defn): Likewise.
6587         (asm_language_defn): Likewise.
6588         (minimal_language_defn): Likewise.
6589         * d-lang.c (d_language_defn): Likewise.
6590         * f-lang.c (f_language_defn): Likewise.
6591         * go-lang.c (go_language_defn): Likewise.
6592         * language.c (unknown_language_defn): Likewise.
6593         (auto_language_defn): Likewise.
6594         * language.h (struct language_defn): Remove la_magic field.
6595         (LANG_MAGIC): Delete.
6596         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6597         * objc-lang.c (objc_language_defn): Likewise.
6598         * opencl-lang.c (opencl_language_defn): Likewise.
6599         * p-lang.c (pascal_language_defn): Likewise.
6600         * rust-lang.c (rust_language_defn): Likewise.
6601
6602 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6603
6604         * riscv-tdep.c (riscv_type_align): New function.
6605         (riscv_type_alignment): Delete.
6606         (riscv_arg_location): Use 'type_align'.
6607         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6608
6609 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6610
6611         * gdbtypes.c (type_align): A struct with no non-static fields also
6612         has alignment of 1.
6613
6614 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6615
6616         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6617         component to 0.
6618         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6619         member.
6620         (riscv_struct_info::analyse): New implementation using new
6621         analyse_inner member function.
6622         (riscv_struct_info::field_offset): New member function.
6623         (riscv_struct_info::m_offsets): New member variable.
6624         (riscv_struct_info::analyse_inner): New private member function,
6625         takes the old implementation of riscv_struct_info::analyse but
6626         extended to track field offsets.
6627         (riscv_call_arg_struct): Update the struct folding special cases
6628         to handle cases where empty C++ structs, which are non-zero
6629         length, are found.
6630         (riscv_arg_location): Initialise the length of each location, a
6631         non-zero length now indicates the location is in use.
6632         (riscv_push_dummy_call): Allow for the first location having a
6633         non-zero offset when setting up arguments.
6634         (riscv_return_value): Likewise, but for return values.
6635
6636 2019-04-11  Tom Tromey  <tromey@adacore.com>
6637
6638         * utils.c (internal_vproblem): Make "msg" const.
6639
6640 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
6641
6642         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6643         * trad-frame.c (trad_frame_reset_saved_regs): New function.
6644         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6645         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6646
6647 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
6648
6649         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6650         function.
6651         (fill_gregset): Call amd64_linux_collect_native_gregset instead
6652         of amd64_collect_native_gregset.
6653         (amd64_linux_nat_target::store_registers): Likewise.
6654
6655 2019-04-10  Tom Tromey  <tom@tromey.com>
6656
6657         * symtab.c (lookup_global_symbol_from_objfile)
6658         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6659         * objfiles.h (class separate_debug_iterator): New.
6660         (class separate_debug_range): New.
6661         (struct objfile) <separate_debug_objfiles>: New method.
6662         (objfile_separate_debug_iterate): Don't declare.
6663         * objfiles.c (separate_debug_iterator::operator++): Rename from
6664         objfile_separate_debug_iterate.
6665         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6666         iterator.
6667         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6668         iterator.
6669
6670 2019-04-10  Tom Tromey  <tom@tromey.com>
6671
6672         * symfile.c (reread_symbols): Remove old comment.
6673         * objfiles.c (free_all_objfiles): Fix a typo.
6674
6675 2019-04-10  Tom Tromey  <tom@tromey.com>
6676
6677         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6678         * minsyms.c (lookup_minimal_symbol): Use foreach.
6679         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6680         (lookup_minimal_symbol_solib_trampoline): Likewise.
6681         * symfile.c (reread_symbols): Use foreach.
6682
6683 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
6684             Tom Tromey  <tromey@adacore.com>
6685
6686         PR rust/24414:
6687         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6688         (rust_lex_int_test): Change "value" to be LONGEST.
6689         (rust_lex_tests): Add test for long integer literal.
6690
6691 2019-04-09  Tom Tromey  <tromey@adacore.com>
6692
6693         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6694         to bool.
6695         (extended_remote_target::attach): Update.
6696         (remote_target::remote_notice_new_inferior): Update.
6697         (remote_target::add_current_inferior_and_thread): Update.
6698         * inferior.c (exit_inferior_1): Use "false".
6699         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6700
6701 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
6702
6703         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
6704         the "start" command.
6705
6706 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6707
6708         * python/py-inferior.c (infpy_thread_from_thread_handle):
6709         Adjust comments to reflect renaming of thread_from_thread_handle
6710         to thread_from_handle.  Adjust keywords.  Fix type error message.
6711         (inferior_object_methods): Add thread_from_handle.  Retain
6712         thread_from_thread_handle, but mark it as deprecated.
6713
6714 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6715
6716         * gdbthread.h (find_thread_by_handle): Revise declaration.
6717         * thread.c (find_thread_by_handle): Likewise.  Adjust
6718         implementation too.
6719         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6720         support for buffer objects as handles.
6721
6722 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6723
6724         * python/py-infthread.c (thpy_thread_handle): New function.
6725         (thread_object_methods): Register thpy_thread_handle.
6726
6727 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
6728
6729         * gdbthread.h (thread_to_thread_handle): Declare.
6730         * thread.c (gdbtypes.h): Include.
6731         (thread_to_thread_handle): New function.
6732
6733         * target.h (struct target_ops): Add thread_info_to_thread_handle.
6734         (target_thread_info_to_thread_handle): Declare.
6735         * target.c (target_thread_info_to_thread_handle): New function.
6736         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6737         * target-delegates.c: Regenerate.
6738
6739         * linux-thread-db.c (class thread_db_target): Add method
6740         thread_info_to_thread_handle.
6741         (thread_db_target::thread_info_to_thread_handle): Define.
6742         * remote.c (class remote_target): Add new method
6743         thread_info_to_thread_handle.
6744         (remote_target::thread_info_to_thread_handle): Define.
6745
6746 2019-04-08  Pedro Alves  <palves@redhat.com>
6747
6748         * common/common-exceptions.c (throw_exception): Don't create
6749         named object to throw; throw directly.
6750         (throw_it): Likewise.  Don't initialize gdb_exception::message
6751         here, with new; pass FMT and AP to the ctor instead.
6752         * common/common-exceptions.h: Include <string>.
6753         (gdb_exception::gdb_exception(enum return_reason, enum errors,
6754         const char *, va_list)): New ctor.  Use std::make_shared.
6755         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6756         errors)): Delete.
6757         (gdb_exception_error::gdb_exception_error(enum errors, const char
6758         *, va_list)): New.
6759         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6760         Add assertion.
6761         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6762         errors)): Delete.
6763         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6764         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6765         Add assertion.
6766
6767 2019-04-08  Tom Tromey  <tom@tromey.com>
6768
6769         * valops.c (value_rtti_indirect_type): Replace throw_exception
6770         with throw.
6771         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6772         with throw.
6773         * thread.c (thr_try_catch_cmd): Replace throw_exception with
6774         throw.
6775         * target.c (target_translate_tls_address): Replace throw_exception
6776         with throw.
6777         * stack.c (frame_apply_command_count): Replace throw_exception
6778         with throw.
6779         * solib-spu.c (append_ocl_sos): Replace throw_exception with
6780         throw.
6781         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6782         with throw.
6783         * rs6000-tdep.c (rs6000_frame_cache)
6784         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6785         * remote.c: Replace throw_exception with throw.
6786         * record-full.c (record_full_message, record_full_wait_1)
6787         (record_full_restore): Replace throw_exception with throw.
6788         * record-btrace.c:
6789         (get_thread_current_frame_id, record_btrace_start_replaying)
6790         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6791         (cmd_record_btrace_start): Replace throw_exception with throw.
6792         * parse.c (parse_exp_in_context_1): Replace throw_exception with
6793         throw.
6794         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6795         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6796         * linespec.c:
6797         (find_linespec_symbols): Replace throw_exception with throw.
6798         * infrun.c (displaced_step_prepare, resume): Replace
6799         throw_exception with throw.
6800         * infcmd.c (post_create_inferior): Replace throw_exception with
6801         throw.
6802         * inf-loop.c (inferior_event_handler): Replace throw_exception
6803         with throw.
6804         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6805         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6806         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6807         (get_prev_frame_always, get_frame_pc_if_available)
6808         (get_frame_address_in_block_if_available, get_frame_language):
6809         Replace throw_exception with throw.
6810         * frame-unwind.c (frame_unwind_try_unwinder): Replace
6811         throw_exception with throw.
6812         * eval.c (fetch_subexp_value, evaluate_var_value)
6813         (evaluate_funcall, evaluate_subexp_standard): Replace
6814         throw_exception with throw.
6815         * dwarf2loc.c (call_site_find_chain)
6816         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6817         Replace throw_exception with throw.
6818         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6819         with throw.
6820         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6821         throw.
6822         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6823         * completer.c (complete_line_internal): Replace throw_exception
6824         with throw.
6825         * compile/compile-object-run.c (compile_object_run): Replace
6826         throw_exception with throw.
6827         * cli/cli-script.c (process_next_line): Replace throw_exception
6828         with throw.
6829         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6830         (btrace_enable, btrace_maint_update_pt_packets): Replace
6831         throw_exception with throw.
6832         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6833         throw_exception with throw.
6834         * break-catch-throw.c (re_set_exception_catchpoint): Replace
6835         throw_exception with throw.
6836         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6837         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6838         * aarch64-tdep.c (aarch64_make_prologue_cache)
6839         (aarch64_make_stub_cache): Replace throw_exception with throw.
6840
6841 2019-04-08  Tom Tromey  <tom@tromey.com>
6842
6843         * common/common-exceptions.c (throw_exception): Rename from
6844         throw_exception_cxx.  Remove old copy.  Make argument const.
6845         (throw_it): Create and throw exception objects directly.
6846         * common/common-exceptions.h (throw_exception): Make argument
6847         const.
6848         (struct gdb_exception_error): Add constructor.
6849         (struct gdb_exception_quit): Add constructor.
6850
6851 2019-04-08  Tom Tromey  <tom@tromey.com>
6852
6853         * common/common-exceptions.h (exception_rethrow): Don't declare.
6854         (TRY_SJLJ): Update comment.
6855         (TRY, CATCH, END_CATCH): Remove.
6856         * common/common-exceptions.c (exception_rethrow): Remove.
6857
6858 2019-04-08  Tom Tromey  <tom@tromey.com>
6859
6860         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6861         Remove.
6862         (gdb_exception_error): Rename from
6863         gdb_exception_RETURN_MASK_ERROR.
6864         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6865         (gdb_quit_bad_alloc): Update.
6866         * aarch64-tdep.c: Update.
6867         * ada-lang.c: Update.
6868         * ada-typeprint.c: Update.
6869         * ada-valprint.c: Update.
6870         * amd64-tdep.c: Update.
6871         * arch-utils.c: Update.
6872         * break-catch-throw.c: Update.
6873         * breakpoint.c: Update.
6874         * btrace.c: Update.
6875         * c-varobj.c: Update.
6876         * cli/cli-cmds.c: Update.
6877         * cli/cli-interp.c: Update.
6878         * cli/cli-script.c: Update.
6879         * common/common-exceptions.c: Update.
6880         * common/new-op.c: Update.
6881         * common/selftest.c: Update.
6882         * compile/compile-c-symbols.c: Update.
6883         * compile/compile-cplus-symbols.c: Update.
6884         * compile/compile-object-load.c: Update.
6885         * compile/compile-object-run.c: Update.
6886         * completer.c: Update.
6887         * corelow.c: Update.
6888         * cp-abi.c: Update.
6889         * cp-support.c: Update.
6890         * cp-valprint.c: Update.
6891         * darwin-nat.c: Update.
6892         * disasm-selftests.c: Update.
6893         * dtrace-probe.c: Update.
6894         * dwarf-index-cache.c: Update.
6895         * dwarf-index-write.c: Update.
6896         * dwarf2-frame-tailcall.c: Update.
6897         * dwarf2-frame.c: Update.
6898         * dwarf2loc.c: Update.
6899         * dwarf2read.c: Update.
6900         * eval.c: Update.
6901         * event-loop.c: Update.
6902         * event-top.c: Update.
6903         * exec.c: Update.
6904         * f-valprint.c: Update.
6905         * fbsd-tdep.c: Update.
6906         * frame-unwind.c: Update.
6907         * frame.c: Update.
6908         * gdbtypes.c: Update.
6909         * gnu-v3-abi.c: Update.
6910         * guile/guile-internal.h: Update.
6911         * guile/scm-block.c: Update.
6912         * guile/scm-breakpoint.c: Update.
6913         * guile/scm-cmd.c: Update.
6914         * guile/scm-disasm.c: Update.
6915         * guile/scm-frame.c: Update.
6916         * guile/scm-lazy-string.c: Update.
6917         * guile/scm-math.c: Update.
6918         * guile/scm-param.c: Update.
6919         * guile/scm-ports.c: Update.
6920         * guile/scm-pretty-print.c: Update.
6921         * guile/scm-symbol.c: Update.
6922         * guile/scm-symtab.c: Update.
6923         * guile/scm-type.c: Update.
6924         * guile/scm-value.c: Update.
6925         * i386-linux-tdep.c: Update.
6926         * i386-tdep.c: Update.
6927         * inf-loop.c: Update.
6928         * infcall.c: Update.
6929         * infcmd.c: Update.
6930         * infrun.c: Update.
6931         * jit.c: Update.
6932         * language.c: Update.
6933         * linespec.c: Update.
6934         * linux-fork.c: Update.
6935         * linux-nat.c: Update.
6936         * linux-tdep.c: Update.
6937         * linux-thread-db.c: Update.
6938         * main.c: Update.
6939         * mi/mi-cmd-break.c: Update.
6940         * mi/mi-cmd-stack.c: Update.
6941         * mi/mi-interp.c: Update.
6942         * mi/mi-main.c: Update.
6943         * objc-lang.c: Update.
6944         * p-valprint.c: Update.
6945         * parse.c: Update.
6946         * ppc-linux-tdep.c: Update.
6947         * printcmd.c: Update.
6948         * python/py-arch.c: Update.
6949         * python/py-breakpoint.c: Update.
6950         * python/py-cmd.c: Update.
6951         * python/py-finishbreakpoint.c: Update.
6952         * python/py-frame.c: Update.
6953         * python/py-framefilter.c: Update.
6954         * python/py-gdb-readline.c: Update.
6955         * python/py-inferior.c: Update.
6956         * python/py-infthread.c: Update.
6957         * python/py-lazy-string.c: Update.
6958         * python/py-linetable.c: Update.
6959         * python/py-objfile.c: Update.
6960         * python/py-param.c: Update.
6961         * python/py-prettyprint.c: Update.
6962         * python/py-progspace.c: Update.
6963         * python/py-record-btrace.c: Update.
6964         * python/py-record.c: Update.
6965         * python/py-symbol.c: Update.
6966         * python/py-type.c: Update.
6967         * python/py-unwind.c: Update.
6968         * python/py-utils.c: Update.
6969         * python/py-value.c: Update.
6970         * python/python.c: Update.
6971         * record-btrace.c: Update.
6972         * record-full.c: Update.
6973         * remote-fileio.c: Update.
6974         * remote.c: Update.
6975         * riscv-tdep.c: Update.
6976         * rs6000-aix-tdep.c: Update.
6977         * rs6000-tdep.c: Update.
6978         * rust-exp.y: Update.
6979         * rust-lang.c: Update.
6980         * s390-tdep.c: Update.
6981         * selftest-arch.c: Update.
6982         * solib-dsbt.c: Update.
6983         * solib-frv.c: Update.
6984         * solib-spu.c: Update.
6985         * solib-svr4.c: Update.
6986         * solib.c: Update.
6987         * sparc64-linux-tdep.c: Update.
6988         * stack.c: Update.
6989         * symfile-mem.c: Update.
6990         * symmisc.c: Update.
6991         * target.c: Update.
6992         * thread.c: Update.
6993         * top.c: Update.
6994         * tracefile-tfile.c: Update.
6995         * tui/tui.c: Update.
6996         * typeprint.c: Update.
6997         * unittests/cli-utils-selftests.c: Update.
6998         * unittests/parse-connection-spec-selftests.c: Update.
6999         * valops.c: Update.
7000         * valprint.c: Update.
7001         * value.c: Update.
7002         * varobj.c: Update.
7003         * windows-nat.c: Update.
7004         * x86-linux-nat.c: Update.
7005         * xml-support.c: Update.
7006
7007 2019-04-08  Tom Tromey  <tom@tromey.com>
7008
7009         * xml-support.c: Use C++ exception handling.
7010         * x86-linux-nat.c: Use C++ exception handling.
7011         * windows-nat.c: Use C++ exception handling.
7012         * varobj.c: Use C++ exception handling.
7013         * value.c: Use C++ exception handling.
7014         * valprint.c: Use C++ exception handling.
7015         * valops.c: Use C++ exception handling.
7016         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7017         handling.
7018         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7019         * typeprint.c: Use C++ exception handling.
7020         * tui/tui.c: Use C++ exception handling.
7021         * tracefile-tfile.c: Use C++ exception handling.
7022         * top.c: Use C++ exception handling.
7023         * thread.c: Use C++ exception handling.
7024         * target.c: Use C++ exception handling.
7025         * symmisc.c: Use C++ exception handling.
7026         * symfile-mem.c: Use C++ exception handling.
7027         * stack.c: Use C++ exception handling.
7028         * sparc64-linux-tdep.c: Use C++ exception handling.
7029         * solib.c: Use C++ exception handling.
7030         * solib-svr4.c: Use C++ exception handling.
7031         * solib-spu.c: Use C++ exception handling.
7032         * solib-frv.c: Use C++ exception handling.
7033         * solib-dsbt.c: Use C++ exception handling.
7034         * selftest-arch.c: Use C++ exception handling.
7035         * s390-tdep.c: Use C++ exception handling.
7036         * rust-lang.c: Use C++ exception handling.
7037         * rust-exp.y: Use C++ exception handling.
7038         * rs6000-tdep.c: Use C++ exception handling.
7039         * rs6000-aix-tdep.c: Use C++ exception handling.
7040         * riscv-tdep.c: Use C++ exception handling.
7041         * remote.c: Use C++ exception handling.
7042         * remote-fileio.c: Use C++ exception handling.
7043         * record-full.c: Use C++ exception handling.
7044         * record-btrace.c: Use C++ exception handling.
7045         * python/python.c: Use C++ exception handling.
7046         * python/py-value.c: Use C++ exception handling.
7047         * python/py-utils.c: Use C++ exception handling.
7048         * python/py-unwind.c: Use C++ exception handling.
7049         * python/py-type.c: Use C++ exception handling.
7050         * python/py-symbol.c: Use C++ exception handling.
7051         * python/py-record.c: Use C++ exception handling.
7052         * python/py-record-btrace.c: Use C++ exception handling.
7053         * python/py-progspace.c: Use C++ exception handling.
7054         * python/py-prettyprint.c: Use C++ exception handling.
7055         * python/py-param.c: Use C++ exception handling.
7056         * python/py-objfile.c: Use C++ exception handling.
7057         * python/py-linetable.c: Use C++ exception handling.
7058         * python/py-lazy-string.c: Use C++ exception handling.
7059         * python/py-infthread.c: Use C++ exception handling.
7060         * python/py-inferior.c: Use C++ exception handling.
7061         * python/py-gdb-readline.c: Use C++ exception handling.
7062         * python/py-framefilter.c: Use C++ exception handling.
7063         * python/py-frame.c: Use C++ exception handling.
7064         * python/py-finishbreakpoint.c: Use C++ exception handling.
7065         * python/py-cmd.c: Use C++ exception handling.
7066         * python/py-breakpoint.c: Use C++ exception handling.
7067         * python/py-arch.c: Use C++ exception handling.
7068         * printcmd.c: Use C++ exception handling.
7069         * ppc-linux-tdep.c: Use C++ exception handling.
7070         * parse.c: Use C++ exception handling.
7071         * p-valprint.c: Use C++ exception handling.
7072         * objc-lang.c: Use C++ exception handling.
7073         * mi/mi-main.c: Use C++ exception handling.
7074         * mi/mi-interp.c: Use C++ exception handling.
7075         * mi/mi-cmd-stack.c: Use C++ exception handling.
7076         * mi/mi-cmd-break.c: Use C++ exception handling.
7077         * main.c: Use C++ exception handling.
7078         * linux-thread-db.c: Use C++ exception handling.
7079         * linux-tdep.c: Use C++ exception handling.
7080         * linux-nat.c: Use C++ exception handling.
7081         * linux-fork.c: Use C++ exception handling.
7082         * linespec.c: Use C++ exception handling.
7083         * language.c: Use C++ exception handling.
7084         * jit.c: Use C++ exception handling.
7085         * infrun.c: Use C++ exception handling.
7086         * infcmd.c: Use C++ exception handling.
7087         * infcall.c: Use C++ exception handling.
7088         * inf-loop.c: Use C++ exception handling.
7089         * i386-tdep.c: Use C++ exception handling.
7090         * i386-linux-tdep.c: Use C++ exception handling.
7091         * guile/scm-value.c: Use C++ exception handling.
7092         * guile/scm-type.c: Use C++ exception handling.
7093         * guile/scm-symtab.c: Use C++ exception handling.
7094         * guile/scm-symbol.c: Use C++ exception handling.
7095         * guile/scm-pretty-print.c: Use C++ exception handling.
7096         * guile/scm-ports.c: Use C++ exception handling.
7097         * guile/scm-param.c: Use C++ exception handling.
7098         * guile/scm-math.c: Use C++ exception handling.
7099         * guile/scm-lazy-string.c: Use C++ exception handling.
7100         * guile/scm-frame.c: Use C++ exception handling.
7101         * guile/scm-disasm.c: Use C++ exception handling.
7102         * guile/scm-cmd.c: Use C++ exception handling.
7103         * guile/scm-breakpoint.c: Use C++ exception handling.
7104         * guile/scm-block.c: Use C++ exception handling.
7105         * guile/guile-internal.h: Use C++ exception handling.
7106         * gnu-v3-abi.c: Use C++ exception handling.
7107         * gdbtypes.c: Use C++ exception handling.
7108         * frame.c: Use C++ exception handling.
7109         * frame-unwind.c: Use C++ exception handling.
7110         * fbsd-tdep.c: Use C++ exception handling.
7111         * f-valprint.c: Use C++ exception handling.
7112         * exec.c: Use C++ exception handling.
7113         * event-top.c: Use C++ exception handling.
7114         * event-loop.c: Use C++ exception handling.
7115         * eval.c: Use C++ exception handling.
7116         * dwarf2read.c: Use C++ exception handling.
7117         * dwarf2loc.c: Use C++ exception handling.
7118         * dwarf2-frame.c: Use C++ exception handling.
7119         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7120         * dwarf-index-write.c: Use C++ exception handling.
7121         * dwarf-index-cache.c: Use C++ exception handling.
7122         * dtrace-probe.c: Use C++ exception handling.
7123         * disasm-selftests.c: Use C++ exception handling.
7124         * darwin-nat.c: Use C++ exception handling.
7125         * cp-valprint.c: Use C++ exception handling.
7126         * cp-support.c: Use C++ exception handling.
7127         * cp-abi.c: Use C++ exception handling.
7128         * corelow.c: Use C++ exception handling.
7129         * completer.c: Use C++ exception handling.
7130         * compile/compile-object-run.c: Use C++ exception handling.
7131         * compile/compile-object-load.c: Use C++ exception handling.
7132         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7133         * compile/compile-c-symbols.c: Use C++ exception handling.
7134         * common/selftest.c: Use C++ exception handling.
7135         * common/new-op.c: Use C++ exception handling.
7136         * cli/cli-script.c: Use C++ exception handling.
7137         * cli/cli-interp.c: Use C++ exception handling.
7138         * cli/cli-cmds.c: Use C++ exception handling.
7139         * c-varobj.c: Use C++ exception handling.
7140         * btrace.c: Use C++ exception handling.
7141         * breakpoint.c: Use C++ exception handling.
7142         * break-catch-throw.c: Use C++ exception handling.
7143         * arch-utils.c: Use C++ exception handling.
7144         * amd64-tdep.c: Use C++ exception handling.
7145         * ada-valprint.c: Use C++ exception handling.
7146         * ada-typeprint.c: Use C++ exception handling.
7147         * ada-lang.c: Use C++ exception handling.
7148         * aarch64-tdep.c: Use C++ exception handling.
7149
7150 2019-04-08  Tom Tromey  <tom@tromey.com>
7151
7152         * xml-support.c (gdb_xml_parser::parse): Update.
7153         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7154         * value.c (show_convenience): Update.
7155         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7156         (test_parse_flags_qcs): Update.
7157         * thread.c (thr_try_catch_cmd): Update.
7158         * target.c (target_translate_tls_address): Update.
7159         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7160         (info_frame_command_core, frame_apply_command_count): Update.
7161         * rust-exp.y (rust_lex_exception_test): Update.
7162         * riscv-tdep.c (riscv_print_one_register_info): Update.
7163         * remote.c (remote_target::enable_btrace): Update.
7164         * record-btrace.c (record_btrace_enable_warn): Update.
7165         * python/py-utils.c (gdbpy_convert_exception): Update.
7166         * printcmd.c (do_one_display, print_variable_and_value): Update.
7167         * mi/mi-main.c (mi_print_exception): Update.
7168         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7169         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7170         * linux-nat.c (linux_nat_target::attach): Update.
7171         * linux-fork.c (class scoped_switch_fork_info): Update.
7172         * infrun.c (displaced_step_prepare): Update.
7173         * infcall.c (call_function_by_hand_dummy): Update.
7174         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7175         * gnu-v3-abi.c (print_one_vtable): Update.
7176         * frame.c (get_prev_frame_always): Update.
7177         * f-valprint.c (info_common_command_for_block): Update.
7178         * exec.c (try_open_exec_file): Update.
7179         * exceptions.c (print_exception, exception_print)
7180         (exception_fprintf, exception_print_same): Update.
7181         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7182         * dwarf-index-cache.c (index_cache::store)
7183         (index_cache::lookup_gdb_index): Update.
7184         * darwin-nat.c (maybe_cache_shell): Update.
7185         * cp-valprint.c (cp_print_value_fields): Update.
7186         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7187         (gcc_cplus_symbol_address): Update.
7188         * compile/compile-c-symbols.c (gcc_convert_symbol)
7189         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7190         * common/selftest.c: Update.
7191         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7192         a std::string.
7193         (exception_try_scope_entry, exception_try_scope_exit): Don't
7194         declare.
7195         (struct exception_try_scope): Remove.
7196         (TRY): Don't use exception_try_scope.
7197         (struct gdb_exception): Add constructor, operator=.
7198         <what>: New method.
7199         (struct gdb_exception_RETURN_MASK_ALL)
7200         (struct gdb_exception_RETURN_MASK_ERROR)
7201         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7202         (struct gdb_quit_bad_alloc): Update.
7203         * common/common-exceptions.c (exception_none): Change
7204         initializer.
7205         (struct catcher) <state, exception>: Initialize inline.
7206         <prev>: Remove member.
7207         (current_catcher): Remove.
7208         (catchers): New global.
7209         (exceptions_state_mc_init): Simplify.
7210         (catcher_pop): Remove.
7211         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7212         (try_scope_depth, exception_try_scope_entry)
7213         (exception_try_scope_exit): Remove.
7214         (throw_exception_sjlj): Update.
7215         (exception_messages, exception_messages_size): Remove.
7216         (throw_it): Simplify.
7217         (gdb_exception_sliced_copy): Remove.
7218         (throw_exception_cxx): Update.
7219         * cli/cli-script.c (script_from_file): Update.
7220         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7221         Update.
7222         * ada-valprint.c (ada_val_print): Update.
7223         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7224         (create_excep_cond_exprs): Update.
7225
7226 2019-04-08  Tom Tromey  <tom@tromey.com>
7227
7228         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7229         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7230         (TRY, CATCH, END_CATCH): Remove some definitions.
7231         * common/common-exceptions.c: Don't use GDB_XCPT.
7232         (catcher_list_size): Remove.
7233         (throw_exception, throw_it): Simplify.
7234
7235 2019-04-05  Tom Tromey  <tom@tromey.com>
7236
7237         Revert the header-sorting patch.
7238         * ft32-tdep.c: Revert.
7239         * frv-tdep.c: Revert.
7240         * frv-linux-tdep.c: Revert.
7241         * frame.c: Revert.
7242         * frame-unwind.c: Revert.
7243         * frame-base.c: Revert.
7244         * fork-child.c: Revert.
7245         * findvar.c: Revert.
7246         * findcmd.c: Revert.
7247         * filesystem.c: Revert.
7248         * filename-seen-cache.h: Revert.
7249         * filename-seen-cache.c: Revert.
7250         * fbsd-tdep.c: Revert.
7251         * fbsd-nat.h: Revert.
7252         * fbsd-nat.c: Revert.
7253         * f-valprint.c: Revert.
7254         * f-typeprint.c: Revert.
7255         * f-lang.c: Revert.
7256         * extension.h: Revert.
7257         * extension.c: Revert.
7258         * extension-priv.h: Revert.
7259         * expprint.c: Revert.
7260         * exec.h: Revert.
7261         * exec.c: Revert.
7262         * exceptions.c: Revert.
7263         * event-top.c: Revert.
7264         * event-loop.c: Revert.
7265         * eval.c: Revert.
7266         * elfread.c: Revert.
7267         * dwarf2read.h: Revert.
7268         * dwarf2read.c: Revert.
7269         * dwarf2loc.c: Revert.
7270         * dwarf2expr.h: Revert.
7271         * dwarf2expr.c: Revert.
7272         * dwarf2-frame.c: Revert.
7273         * dwarf2-frame-tailcall.c: Revert.
7274         * dwarf-index-write.h: Revert.
7275         * dwarf-index-write.c: Revert.
7276         * dwarf-index-common.c: Revert.
7277         * dwarf-index-cache.h: Revert.
7278         * dwarf-index-cache.c: Revert.
7279         * dummy-frame.c: Revert.
7280         * dtrace-probe.c: Revert.
7281         * disasm.h: Revert.
7282         * disasm.c: Revert.
7283         * disasm-selftests.c: Revert.
7284         * dictionary.c: Revert.
7285         * dicos-tdep.c: Revert.
7286         * demangle.c: Revert.
7287         * dcache.h: Revert.
7288         * dcache.c: Revert.
7289         * darwin-nat.h: Revert.
7290         * darwin-nat.c: Revert.
7291         * darwin-nat-info.c: Revert.
7292         * d-valprint.c: Revert.
7293         * d-namespace.c: Revert.
7294         * d-lang.c: Revert.
7295         * ctf.c: Revert.
7296         * csky-tdep.c: Revert.
7297         * csky-linux-tdep.c: Revert.
7298         * cris-tdep.c: Revert.
7299         * cris-linux-tdep.c: Revert.
7300         * cp-valprint.c: Revert.
7301         * cp-support.c: Revert.
7302         * cp-namespace.c: Revert.
7303         * cp-abi.c: Revert.
7304         * corelow.c: Revert.
7305         * corefile.c: Revert.
7306         * continuations.c: Revert.
7307         * completer.h: Revert.
7308         * completer.c: Revert.
7309         * complaints.c: Revert.
7310         * coffread.c: Revert.
7311         * coff-pe-read.c: Revert.
7312         * cli-out.h: Revert.
7313         * cli-out.c: Revert.
7314         * charset.c: Revert.
7315         * c-varobj.c: Revert.
7316         * c-valprint.c: Revert.
7317         * c-typeprint.c: Revert.
7318         * c-lang.c: Revert.
7319         * buildsym.c: Revert.
7320         * buildsym-legacy.c: Revert.
7321         * build-id.h: Revert.
7322         * build-id.c: Revert.
7323         * btrace.c: Revert.
7324         * bsd-uthread.c: Revert.
7325         * breakpoint.h: Revert.
7326         * breakpoint.c: Revert.
7327         * break-catch-throw.c: Revert.
7328         * break-catch-syscall.c: Revert.
7329         * break-catch-sig.c: Revert.
7330         * blockframe.c: Revert.
7331         * block.c: Revert.
7332         * bfin-tdep.c: Revert.
7333         * bfin-linux-tdep.c: Revert.
7334         * bfd-target.c: Revert.
7335         * bcache.c: Revert.
7336         * ax-general.c: Revert.
7337         * ax-gdb.h: Revert.
7338         * ax-gdb.c: Revert.
7339         * avr-tdep.c: Revert.
7340         * auxv.c: Revert.
7341         * auto-load.c: Revert.
7342         * arm-wince-tdep.c: Revert.
7343         * arm-tdep.c: Revert.
7344         * arm-symbian-tdep.c: Revert.
7345         * arm-pikeos-tdep.c: Revert.
7346         * arm-obsd-tdep.c: Revert.
7347         * arm-nbsd-tdep.c: Revert.
7348         * arm-nbsd-nat.c: Revert.
7349         * arm-linux-tdep.c: Revert.
7350         * arm-linux-nat.c: Revert.
7351         * arm-fbsd-tdep.c: Revert.
7352         * arm-fbsd-nat.c: Revert.
7353         * arm-bsd-tdep.c: Revert.
7354         * arch-utils.c: Revert.
7355         * arc-tdep.c: Revert.
7356         * arc-newlib-tdep.c: Revert.
7357         * annotate.h: Revert.
7358         * annotate.c: Revert.
7359         * amd64-windows-tdep.c: Revert.
7360         * amd64-windows-nat.c: Revert.
7361         * amd64-tdep.c: Revert.
7362         * amd64-sol2-tdep.c: Revert.
7363         * amd64-obsd-tdep.c: Revert.
7364         * amd64-obsd-nat.c: Revert.
7365         * amd64-nbsd-tdep.c: Revert.
7366         * amd64-nbsd-nat.c: Revert.
7367         * amd64-nat.c: Revert.
7368         * amd64-linux-tdep.c: Revert.
7369         * amd64-linux-nat.c: Revert.
7370         * amd64-fbsd-tdep.c: Revert.
7371         * amd64-fbsd-nat.c: Revert.
7372         * amd64-dicos-tdep.c: Revert.
7373         * amd64-darwin-tdep.c: Revert.
7374         * amd64-bsd-nat.c: Revert.
7375         * alpha-tdep.c: Revert.
7376         * alpha-obsd-tdep.c: Revert.
7377         * alpha-nbsd-tdep.c: Revert.
7378         * alpha-mdebug-tdep.c: Revert.
7379         * alpha-linux-tdep.c: Revert.
7380         * alpha-linux-nat.c: Revert.
7381         * alpha-bsd-tdep.c: Revert.
7382         * alpha-bsd-nat.c: Revert.
7383         * aix-thread.c: Revert.
7384         * agent.c: Revert.
7385         * addrmap.c: Revert.
7386         * ada-varobj.c: Revert.
7387         * ada-valprint.c: Revert.
7388         * ada-typeprint.c: Revert.
7389         * ada-tasks.c: Revert.
7390         * ada-lang.c: Revert.
7391         * aarch64-tdep.c: Revert.
7392         * aarch64-ravenscar-thread.c: Revert.
7393         * aarch64-newlib-tdep.c: Revert.
7394         * aarch64-linux-tdep.c: Revert.
7395         * aarch64-linux-nat.c: Revert.
7396         * aarch64-fbsd-tdep.c: Revert.
7397         * aarch64-fbsd-nat.c: Revert.
7398         * aarch32-linux-nat.c: Revert.
7399
7400 2019-04-05  Tom Tromey  <tom@tromey.com>
7401
7402         * ft32-tdep.c: Sort headers.
7403         * frv-tdep.c: Sort headers.
7404         * frv-linux-tdep.c: Sort headers.
7405         * frame.c: Sort headers.
7406         * frame-unwind.c: Sort headers.
7407         * frame-base.c: Sort headers.
7408         * fork-child.c: Sort headers.
7409         * findvar.c: Sort headers.
7410         * findcmd.c: Sort headers.
7411         * filesystem.c: Sort headers.
7412         * filename-seen-cache.h: Sort headers.
7413         * filename-seen-cache.c: Sort headers.
7414         * fbsd-tdep.c: Sort headers.
7415         * fbsd-nat.h: Sort headers.
7416         * fbsd-nat.c: Sort headers.
7417         * f-valprint.c: Sort headers.
7418         * f-typeprint.c: Sort headers.
7419         * f-lang.c: Sort headers.
7420         * extension.h: Sort headers.
7421         * extension.c: Sort headers.
7422         * extension-priv.h: Sort headers.
7423         * expprint.c: Sort headers.
7424         * exec.h: Sort headers.
7425         * exec.c: Sort headers.
7426         * exceptions.c: Sort headers.
7427         * event-top.c: Sort headers.
7428         * event-loop.c: Sort headers.
7429         * eval.c: Sort headers.
7430         * elfread.c: Sort headers.
7431         * dwarf2read.h: Sort headers.
7432         * dwarf2read.c: Sort headers.
7433         * dwarf2loc.c: Sort headers.
7434         * dwarf2expr.h: Sort headers.
7435         * dwarf2expr.c: Sort headers.
7436         * dwarf2-frame.c: Sort headers.
7437         * dwarf2-frame-tailcall.c: Sort headers.
7438         * dwarf-index-write.h: Sort headers.
7439         * dwarf-index-write.c: Sort headers.
7440         * dwarf-index-common.c: Sort headers.
7441         * dwarf-index-cache.h: Sort headers.
7442         * dwarf-index-cache.c: Sort headers.
7443         * dummy-frame.c: Sort headers.
7444         * dtrace-probe.c: Sort headers.
7445         * disasm.h: Sort headers.
7446         * disasm.c: Sort headers.
7447         * disasm-selftests.c: Sort headers.
7448         * dictionary.c: Sort headers.
7449         * dicos-tdep.c: Sort headers.
7450         * demangle.c: Sort headers.
7451         * dcache.h: Sort headers.
7452         * dcache.c: Sort headers.
7453         * darwin-nat.h: Sort headers.
7454         * darwin-nat.c: Sort headers.
7455         * darwin-nat-info.c: Sort headers.
7456         * d-valprint.c: Sort headers.
7457         * d-namespace.c: Sort headers.
7458         * d-lang.c: Sort headers.
7459         * ctf.c: Sort headers.
7460         * csky-tdep.c: Sort headers.
7461         * csky-linux-tdep.c: Sort headers.
7462         * cris-tdep.c: Sort headers.
7463         * cris-linux-tdep.c: Sort headers.
7464         * cp-valprint.c: Sort headers.
7465         * cp-support.c: Sort headers.
7466         * cp-namespace.c: Sort headers.
7467         * cp-abi.c: Sort headers.
7468         * corelow.c: Sort headers.
7469         * corefile.c: Sort headers.
7470         * continuations.c: Sort headers.
7471         * completer.h: Sort headers.
7472         * completer.c: Sort headers.
7473         * complaints.c: Sort headers.
7474         * coffread.c: Sort headers.
7475         * coff-pe-read.c: Sort headers.
7476         * cli-out.h: Sort headers.
7477         * cli-out.c: Sort headers.
7478         * charset.c: Sort headers.
7479         * c-varobj.c: Sort headers.
7480         * c-valprint.c: Sort headers.
7481         * c-typeprint.c: Sort headers.
7482         * c-lang.c: Sort headers.
7483         * buildsym.c: Sort headers.
7484         * buildsym-legacy.c: Sort headers.
7485         * build-id.h: Sort headers.
7486         * build-id.c: Sort headers.
7487         * btrace.c: Sort headers.
7488         * bsd-uthread.c: Sort headers.
7489         * breakpoint.h: Sort headers.
7490         * breakpoint.c: Sort headers.
7491         * break-catch-throw.c: Sort headers.
7492         * break-catch-syscall.c: Sort headers.
7493         * break-catch-sig.c: Sort headers.
7494         * blockframe.c: Sort headers.
7495         * block.c: Sort headers.
7496         * bfin-tdep.c: Sort headers.
7497         * bfin-linux-tdep.c: Sort headers.
7498         * bfd-target.c: Sort headers.
7499         * bcache.c: Sort headers.
7500         * ax-general.c: Sort headers.
7501         * ax-gdb.h: Sort headers.
7502         * ax-gdb.c: Sort headers.
7503         * avr-tdep.c: Sort headers.
7504         * auxv.c: Sort headers.
7505         * auto-load.c: Sort headers.
7506         * arm-wince-tdep.c: Sort headers.
7507         * arm-tdep.c: Sort headers.
7508         * arm-symbian-tdep.c: Sort headers.
7509         * arm-pikeos-tdep.c: Sort headers.
7510         * arm-obsd-tdep.c: Sort headers.
7511         * arm-nbsd-tdep.c: Sort headers.
7512         * arm-nbsd-nat.c: Sort headers.
7513         * arm-linux-tdep.c: Sort headers.
7514         * arm-linux-nat.c: Sort headers.
7515         * arm-fbsd-tdep.c: Sort headers.
7516         * arm-fbsd-nat.c: Sort headers.
7517         * arm-bsd-tdep.c: Sort headers.
7518         * arch-utils.c: Sort headers.
7519         * arc-tdep.c: Sort headers.
7520         * arc-newlib-tdep.c: Sort headers.
7521         * annotate.h: Sort headers.
7522         * annotate.c: Sort headers.
7523         * amd64-windows-tdep.c: Sort headers.
7524         * amd64-windows-nat.c: Sort headers.
7525         * amd64-tdep.c: Sort headers.
7526         * amd64-sol2-tdep.c: Sort headers.
7527         * amd64-obsd-tdep.c: Sort headers.
7528         * amd64-obsd-nat.c: Sort headers.
7529         * amd64-nbsd-tdep.c: Sort headers.
7530         * amd64-nbsd-nat.c: Sort headers.
7531         * amd64-nat.c: Sort headers.
7532         * amd64-linux-tdep.c: Sort headers.
7533         * amd64-linux-nat.c: Sort headers.
7534         * amd64-fbsd-tdep.c: Sort headers.
7535         * amd64-fbsd-nat.c: Sort headers.
7536         * amd64-dicos-tdep.c: Sort headers.
7537         * amd64-darwin-tdep.c: Sort headers.
7538         * amd64-bsd-nat.c: Sort headers.
7539         * alpha-tdep.c: Sort headers.
7540         * alpha-obsd-tdep.c: Sort headers.
7541         * alpha-nbsd-tdep.c: Sort headers.
7542         * alpha-mdebug-tdep.c: Sort headers.
7543         * alpha-linux-tdep.c: Sort headers.
7544         * alpha-linux-nat.c: Sort headers.
7545         * alpha-bsd-tdep.c: Sort headers.
7546         * alpha-bsd-nat.c: Sort headers.
7547         * aix-thread.c: Sort headers.
7548         * agent.c: Sort headers.
7549         * addrmap.c: Sort headers.
7550         * ada-varobj.c: Sort headers.
7551         * ada-valprint.c: Sort headers.
7552         * ada-typeprint.c: Sort headers.
7553         * ada-tasks.c: Sort headers.
7554         * ada-lang.c: Sort headers.
7555         * aarch64-tdep.c: Sort headers.
7556         * aarch64-ravenscar-thread.c: Sort headers.
7557         * aarch64-newlib-tdep.c: Sort headers.
7558         * aarch64-linux-tdep.c: Sort headers.
7559         * aarch64-linux-nat.c: Sort headers.
7560         * aarch64-fbsd-tdep.c: Sort headers.
7561         * aarch64-fbsd-nat.c: Sort headers.
7562         * aarch32-linux-nat.c: Sort headers.
7563
7564 2019-04-04  Tom Tromey  <tom@tromey.com>
7565
7566         * varobj.c (varobj_create): Update.
7567         * rust-exp.y (struct rust_parser) <update_innermost_block,
7568         lookup_symbol>: New methods.
7569         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7570         Rename.
7571         (rust_parser::rust_lookup_type)
7572         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7573         * printcmd.c (display_command, do_one_display): Update.
7574         * parser-defs.h (struct parser_state) <parser_state>: Add
7575         "tracker" parameter.
7576         (block_tracker): New member.
7577         (class innermost_block_tracker) <innermost_block_tracker>: Add
7578         "types" parameter.
7579         <reset>: Remove method.
7580         (innermost_block): Don't declare.
7581         (null_post_parser): Update.
7582         * parse.c (innermost_block): Remove global.
7583         (write_dollar_variable): Update.
7584         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7585         Remove "tracker_types" parameter.
7586         (parse_expression): Add "tracker" parameter.
7587         (parse_expression_for_completion): Update.
7588         (null_post_parser): Add "tracker" parameter.
7589         * p-exp.y: Update rules.
7590         * m2-exp.y: Update rules.
7591         * language.h (struct language_defn) <la_post_parser>: Add
7592         "tracker" parameter.
7593         * go-exp.y: Update rules.
7594         * f-exp.y: Update rules.
7595         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7596         parameter.
7597         * d-exp.y: Update rules.
7598         * c-exp.y: Update rules.
7599         * breakpoint.c (set_breakpoint_condition): Create an
7600         innermost_block_tracker.
7601         (watch_command_1): Likewise.
7602         * ada-lang.c (resolve): Add "tracker" parameter.
7603         (resolve_subexp): Likewise.
7604         * ada-exp.y (write_var_from_sym): Update.
7605
7606 2019-04-04  Tom Tromey  <tom@tromey.com>
7607
7608         * type-stack.h: New file.
7609         * type-stack.c: New file.
7610         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7611         type-stack.h.
7612         (insert_into_type_stack, insert_type, push_type, push_type_int)
7613         (insert_type_address_space, pop_type, pop_type_int)
7614         (pop_typelist, pop_type_stack, append_type_stack)
7615         (push_type_stack, get_type_stack, push_typelist)
7616         (follow_type_instance_flags, follow_types): Don't declare.
7617         * parse.c (type_stack): Remove global.
7618         (parse_exp_in_context): Update.
7619         (insert_into_type_stack, insert_type, push_type, push_type_int)
7620         (insert_type_address_space, pop_type, pop_type_int)
7621         (pop_typelist, pop_type_stack, append_type_stack)
7622         (push_type_stack, get_type_stack, push_typelist)
7623         (follow_type_instance_flags, follow_types): Remove (moved to
7624         type-stack.c).
7625         * f-exp.y (type_stack): New global.
7626         Update rules.
7627         (push_kind_type, f_parse): Update.
7628         * d-exp.y (type_stack): New global.
7629         Update rules.
7630         (d_parse): Update.
7631         * c-exp.y (struct c_parse_state) <type_stack>: New member.
7632         Update rules.
7633         * Makefile.in (COMMON_SFILES): Add type-stack.c.
7634         (HFILES_NO_SRCDIR): Add type-stack.h.
7635
7636 2019-04-04  Tom Tromey  <tom@tromey.com>
7637
7638         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7639         (rust_parser::convert_ast_to_expression, rust_parse)
7640         (rust_lex_test_completion, rust_lex_tests): Update.
7641         * parser-defs.h (struct expr_completion_state): New.
7642         (struct parser_state) <parser_state>: Add completion parameter.
7643         <mark_struct_expression, mark_completion_tag>: New methods.
7644         <parse_completion, m_completion_state>: New members.
7645         (prefixify_expression, null_post_parser): Update.
7646         (mark_struct_expression, mark_completion_tag): Don't declare.
7647         * parse.c (parse_completion, expout_last_struct)
7648         (expout_tag_completion_type, expout_completion_name): Remove
7649         globals.
7650         (parser_state::mark_struct_expression)
7651         (parser_state::mark_completion_tag): Now methods.
7652         (prefixify_expression): Add last_struct parameter.
7653         (prefixify_subexp): Likewise.
7654         (parse_exp_1): Update.
7655         (parse_exp_in_context): Add cstate parameter.  Update.
7656         (parse_expression_for_completion): Create an
7657         expr_completion_state.
7658         (null_post_parser): Add "completion" parameter.
7659         * p-exp.y: Update rules.
7660         (yylex): Update.
7661         * language.h (struct language_defn) <la_post_parser>: Add
7662         "completing" parameter.
7663         * go-exp.y: Update rules.
7664         (lex_one_token): Update.
7665         * expression.h (parse_completion): Don't declare.
7666         * d-exp.y: Update rules.
7667         (lex_one_token): Update rules.
7668         * c-exp.y: Update rules.
7669         (lex_one_token): Update.
7670         * ada-lang.c (resolve): Add "parse_completion" parameter.
7671         (resolve_subexp): Likewise.
7672         (ada_resolve_function): Likewise.
7673
7674 2019-04-04  Tom Tromey  <tom@tromey.com>
7675
7676         * parser-defs.h (struct parser_state) <start_arglist,
7677         end_arglist>: New methods.
7678         <arglist_len, m_funcall_chain>: New members.
7679         (arglist_len, start_arglist, end_arglist): Don't declare.
7680         * parse.c (arglist_len, funcall_chain): Remove global.
7681         (start_arglist, end_arglist): Remove functions.
7682         (parse_exp_in_context): Update.
7683         * p-exp.y: Update rules.
7684         * m2-exp.y: Update rules.
7685         * go-exp.y: Update rules.
7686         * f-exp.y: Update rules.
7687         * d-exp.y: Update rules.
7688         * c-exp.y: Update rules.
7689
7690 2019-04-04  Tom Tromey  <tom@tromey.com>
7691
7692         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7693         lex_operator, push_back>: New methods.
7694         Update all rules.
7695         (rust_parser::lex_hex, lex_escape): Rename and update.
7696         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7697         (rust_parser::lex_operator): Rename and update.
7698         (rust_parser::lex_number, rustyylex, rustyyerror)
7699         (rust_lex_test_init, rust_lex_test_sequence)
7700         (rust_lex_test_push_back, rust_lex_tests): Update.
7701         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7702         parameter.
7703         <lexptr, prev_lexptr>: New members.
7704         (lexptr, prev_lexptr): Don't declare.
7705         * parse.c (lexptr, prev_lexptr): Remove globals.
7706         (parse_exp_in_context): Update.
7707         * p-exp.y (yylex, yyerror): Update.
7708         * m2-exp.y (parse_number, yylex, yyerror): Update.
7709         * go-exp.y (lex_one_token, yyerror): Update.
7710         * f-exp.y (match_string_literal, yylex, yyerror): Update.
7711         * d-exp.y (lex_one_token, yyerror): Update.
7712         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7713         (lex_one_token, yyerror): Update.
7714         * ada-lex.l (YY_INPUT): Update.
7715         (rewind_to_char): Update.
7716         * ada-exp.y (yyerror): Update.
7717
7718 2019-04-04  Tom Tromey  <tom@tromey.com>
7719
7720         * rust-exp.y (rustyylex, rust_lex_tests): Update.
7721         * parser-defs.h (struct parser_state) <parser_state>: Add new
7722         parameter.
7723         <comma_terminates>: New member.
7724         (comma_terminates): Don't declare global.
7725         * parse.c (comma_terminates): Remove global.
7726         (parse_exp_in_context): Update.
7727         * p-exp.y (yylex): Update.
7728         * m2-exp.y (yylex): Update.
7729         * go-exp.y (lex_one_token): Update.
7730         * f-exp.y (yylex): Update.
7731         * d-exp.y (lex_one_token): Update.
7732         * c-exp.y (lex_one_token): Update.
7733         * ada-lex.l: Update.
7734
7735 2019-04-04  Tom Tromey  <tom@tromey.com>
7736
7737         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7738         (rustyylex, rust_lex_test_init, rust_lex_test_one)
7739         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7740         * parser-defs.h (paren_depth): Don't declare.
7741         * parse.c (paren_depth): Remove global.
7742         (parse_exp_in_context): Update.
7743         * p-exp.y (paren_depth): New global.
7744         (pascal_parse): Initialize it.
7745         * m2-exp.y (paren_depth): New global.
7746         (m2_parse): Initialize it.
7747         * go-exp.y (paren_depth): New global.
7748         (go_parse): Initialize it.
7749         * f-exp.y (paren_depth): New global.
7750         (f_parse): Initialize it.
7751         * d-exp.y (paren_depth): New global.
7752         (d_parse): Initialize it.
7753         * c-exp.y (paren_depth): New global.
7754         (c_parse): Initialize it.
7755         * ada-lex.l (paren_depth): New global.
7756         (lexer_init): Initialize it.
7757
7758 2019-04-04  Tom Tromey  <tom@tromey.com>
7759
7760         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7761         (rust_parser::convert_ast_to_type)
7762         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7763         * parser-defs.h (struct parser_state) <parser_state>: Add
7764         parameters.  Initialize new members.
7765         <expression_context_block, expression_context_pc>: New members.
7766         * parse.c (expression_context_block, expression_context_pc):
7767         Remove globals.
7768         (parse_exp_in_context): Update.
7769         * p-exp.y: Update all rules.
7770         (yylex): Update.
7771         * m2-exp.y: Update all rules.
7772         (yylex): Update.
7773         * go-exp.y (yylex): Update.
7774         * f-exp.y (yylex): Update.
7775         * d-exp.y: Update all rules.
7776         (yylex): Update.
7777         * c-exp.y: Update all rules.
7778         (lex_one_token, classify_name, yylex, c_parse): Update.
7779         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7780
7781 2019-04-04  Tom Tromey  <tom@tromey.com>
7782
7783         * gdbarch.h, gdbarch.c: Rebuild.
7784         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7785         * stap-probe.h:
7786         (struct stap_parse_info): Replace "parser_state" with
7787         "expr_builder".
7788         * parser-defs.h (struct expr_builder): Rename from "parser_state".
7789         (parser_state): New class.
7790         * parse.c (expr_builder): Rename.
7791         (expr_builder::release): Rename.
7792         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7793         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7794         (write_exp_elt_longcst, write_exp_elt_floatcst)
7795         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7796         (write_exp_string_vector, write_exp_bitstring)
7797         (write_exp_msymbol, mark_struct_expression)
7798         (write_dollar_variable)
7799         (insert_type_address_space, increase_expout_size): Replace
7800         "parser_state" with "expr_builder".
7801         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7802         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7803         "parser_state" with "expr_builder".
7804
7805 2019-04-04  Tom Tromey  <tom@tromey.com>
7806
7807         * rust-exp.y: Replace "parse_language" with method call.
7808         * p-exp.y:
7809         (yylex): Replace "parse_language" with method call.
7810         * m2-exp.y:
7811         (yylex): Replace "parse_language" with method call.
7812         * go-exp.y (classify_name): Replace "parse_language" with method
7813         call.
7814         * f-exp.y (yylex): Replace "parse_language" with method call.
7815         * d-exp.y (lex_one_token): Replace "parse_language" with method
7816         call.
7817         * c-exp.y:
7818         (lex_one_token, classify_name, yylex): Replace "parse_language"
7819         with method call.
7820         * ada-exp.y (find_primitive_type, type_char)
7821         (type_system_address): Replace "parse_language" with method call.
7822
7823 2019-04-04  Tom Tromey  <tom@tromey.com>
7824
7825         * rust-exp.y: Replace "parse_gdbarch" with method call.
7826         * parse.c (write_dollar_variable, insert_type_address_space):
7827         Replace "parse_gdbarch" with method call.
7828         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7829         call.
7830         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7831         call.
7832         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7833         "parse_gdbarch" with method call.
7834         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7835         with method call.
7836         * f-exp.y (parse_type, parse_f_type, yylex): Replace
7837         "parse_gdbarch" with method call.
7838         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7839         "parse_gdbarch" with method call.
7840         * c-exp.y (parse_type, parse_number, classify_name): Replace
7841         "parse_gdbarch" with method call.
7842         * ada-lex.l: Replace "parse_gdbarch" with method call.
7843         * ada-exp.y (parse_type, find_primitive_type, type_char)
7844         (type_system_address): Replace "parse_gdbarch" with method call.
7845
7846 2019-04-04  Tom Tromey  <tom@tromey.com>
7847
7848         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7849         * stap-probe.c (stap_parse_argument): Update.
7850         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7851         initial_size parameter.
7852         * rust-exp.y (rust_lex_tests): Update.
7853         * parse.c (parser_state): Update.
7854         (parse_exp_in_context): Update.
7855         * parser-defs.h (struct parser_state) <parser_state>: Remove
7856         "initial_size" parameter.
7857
7858 2019-04-04  Tom Tromey  <tom@tromey.com>
7859
7860         * parser-defs.h (increase_expout_size): Don't declare.
7861         * parse.c (increase_expout_size): Now static.
7862
7863 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
7864
7865         * gnu-nat.c (gnu_nat_target::wait): Fix
7866         target_waitstatus_to_string call.
7867
7868 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7869
7870         * eval.c (evaluate_subexp_standard): Handle internal functions
7871         during Fortran function call handling.
7872
7873 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7874
7875         * NEWS: Mention new internal functions.
7876         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7877         (read_base_type): Use dwarf2_init_complex_target_type.
7878         * value.c (creal_internal_fn): New function.
7879         (cimag_internal_fn): New function.
7880         (_initialize_values): Register new internal functions.
7881
7882 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7883
7884         * infrun.c (stop_all_threads): If debug_infrun, always
7885         trace the wait status after wait_one, using
7886         target_waitstatus_to_string and target_pid_to_str.
7887         (handle_inferior_event): Replace various trace of
7888         wait status kind by a single trace.
7889         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7890         wait status kind image by target_waitstatus_to_string.
7891         * target/waitstatus.c (target_waitstatus_to_string): Fix
7892         obsolete comment.
7893
7894 2019-04-01  Tom Tromey  <tromey@adacore.com>
7895
7896         PR symtab/23331:
7897         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7898
7899 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
7900             Pedro Alves  <palves@redhat.com>
7901
7902         * top.c (quit_force): Call 'finalize_values'.
7903         * value.c (finalize_values): New function.
7904         * value.h (finalize_values): Declare.
7905
7906 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
7907
7908         * NEWS: Announce $_gdb_major and $_gdb_minor.
7909
7910         * top.c (init_gdb_version_vars): New function.
7911         (gdb_init): Call init_gdb_version_vars.
7912
7913 2019-03-29  Tom Tromey  <tromey@adacore.com>
7914
7915         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
7916         help text.  Remove dead code.
7917
7918 2019-03-29  Keith Seitz  <keiths@redhat.com>
7919
7920         From Siddhesh Poyarekar:
7921         * f-lang.h (f77_get_upperbound): Return LONGEST.
7922         (f77_get_lowerbound): Likewise.
7923         * f-typeprint.c (f_type_print_varspec_suffix): Expand
7924         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
7925         print them.
7926         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
7927         plongest to format print it.
7928         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7929         (f77_get_upperbound): Likewise.
7930         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7931         LOWER_BOUND to LONGEST.
7932         (f77_create_arrayprint_offset_tbl): Likewise.
7933
7934 2019-03-29  Keith Seitz  <keiths@redhat.com>
7935
7936         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7937         %s/pulongest for TYPE_LENGTH instead of %d in format
7938         strings.
7939         * ada-typerint.c (ada_print_type): Likewise.
7940         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7941         * compile/compile-c-support.c (generate_register_struct): Likewise.
7942         * gdbtypes.c (recursive_dump_type): Likewise.
7943         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7944         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
7945         instead of %d in format strings.
7946         * riscv-tdep.c (riscv_type_alignment): Cast second argument
7947         to std::min to ULONGEST.
7948         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7949         instead of %d in format strings.
7950         * tracepoint.c (info_scope_command): Likewise.
7951         * typeprint.c (print_offset_data::update)
7952         (print_offset_data::finish): Likewise.
7953         * xtensa-tdep.c (xtensa_store_return_value)
7954         (xtensa_push_dummy_call): Likewise.
7955
7956 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
7957
7958         * windows-nat.c (display_selector): Fixed format specifications
7959         for 64-bit Cygwin.
7960
7961 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7962
7963         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7964
7965 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
7966
7967         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7968         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7969         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7970         (nios2_linux_init_abi): Install it.
7971
7972 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7973
7974         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7975
7976 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
7977
7978         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7979
7980 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7981             Tom Tromey  <tromey@adacore.com>
7982
7983         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7984
7985 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
7986
7987         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7988         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7989         method to compute the bounds of range types. Also print "[evaluated]"
7990         if the bounds' values come from a dynamic evaluation.
7991
7992 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7993
7994         * cp-valprint.c (cp_print_value_fields): Don't print trailing
7995         whitespace when pretty printing is on.
7996
7997 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
7998
7999         * ppc-linux-nat.c: Add include.
8000
8001 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8002
8003         * NEWS: Mention AArch64 Pointer Authentication.
8004
8005 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8006
8007         * arm-linux-nat.c: Add include.
8008
8009 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8010
8011         * source-cache.c (source_cache::get_source_lines): Re-read
8012         fullname after calling open_source_file.
8013
8014 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8015
8016         * NEWS: Mention TLS support for FreeBSD.
8017
8018 2019-03-25  Tom Tromey  <tromey@adacore.com>
8019
8020         * minsyms.c (BUNCH_SIZE): Update comment.
8021         (~minimal_symbol_reader): Remove old comment.
8022         (compact_minimal_symbols): Update comment.
8023         (minimal_symbol_reader::install): Remove old comment.  Update
8024         other comments.
8025
8026 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8027
8028         * s390-linux-nat.c: Add include.
8029
8030 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8031
8032         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8033         Call linux_get_hwcap.
8034         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8035         Likewise.
8036         (aarch64_linux_get_hwcap): Remove function.
8037         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8038         declaration.
8039         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8040         linux_get_hwcap.
8041         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8042         * linux-tdep.c (linux_get_hwcap): Add function.
8043         (linux_get_hwcap2): Likewise.
8044         * linux-tdep.h (linux_get_hwcap): Add declaration.
8045         (linux_get_hwcap2): Likewise.
8046         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8047         (ppc_linux_get_hwcap2): Likewise.
8048         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8049         linux_get_hwcap.
8050         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8051         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8052         (ppc_linux_nat_target::read_description): Likewise.
8053         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8054         * s390-linux-nat.c: Likewise.
8055         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8056
8057 2019-03-24  Tom Tromey  <tom@tromey.com>
8058
8059         * ada-lang.c (standard_lookup): Simplify initialization.
8060         (ada_lookup_symbol_nonlocal): Simplify return.
8061         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8062         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8063         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8064         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8065         initialization.
8066         * solib.c (solib_global_lookup): Simplify.
8067         * symtab.c (null_block_symbol): Remove.
8068         (symbol_cache_lookup): Simplify returns.
8069         (lookup_language_this): Simplify returns.
8070         (lookup_symbol_aux): Simplify return.
8071         (lookup_local_symbol): Simplify returns.
8072         (lookup_global_symbol_from_objfile): Simplify return.
8073         (lookup_symbol_in_objfile_symtabs)
8074         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8075         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8076         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8077         * cp-namespace.c (cp_lookup_bare_symbol)
8078         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8079         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8080         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8081         (cp_lookup_symbol_via_imports): Simplify initialization.
8082         (find_symbol_in_baseclass): Likewise.
8083         * symtab.h (null_block_symbol): Remove.
8084         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8085         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8086         (d_lookup_symbol_module): Likewise.
8087         (find_symbol_in_baseclass): Simplify initialization.
8088
8089 2019-03-24  Tom Tromey  <tom@tromey.com>
8090
8091         * expression.h: Don't include symtab.h.
8092         (struct block): Forward declare.
8093
8094 2019-03-24  Tom Tromey  <tom@tromey.com>
8095
8096         * c-exp.y (typebase): Remove casts.
8097         * gdbtypes.c (lookup_unsigned_typename, )
8098         (lookup_signed_typename): Remove cast.
8099         * eval.c (parse_to_comma_and_eval): Remove cast.
8100         * parse.c (write_dollar_variable): Remove cast.
8101         * block.h (struct block) <superblock>: Now const.
8102         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8103         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8104         (map_block): Make "block" const.
8105         * symfile.h (struct quick_symbol_functions)
8106         <map_matching_symbols>: Constify block argument to "callback".
8107         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8108         const.
8109         (find_pc_sect_compunit_symtab): Make "b" const.
8110         (find_symbol_at_address): Likewise.
8111         (search_symbols): Likewise.
8112         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8113         (dw2_debug_names_lookup_symbol): Likewise.
8114         (dw2_map_matching_symbols): Update.
8115         * p-valprint.c (pascal_val_print): Remove "block".
8116         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8117         (aux_add_nonlocal_symbols): Make "block" const.
8118         (resolve_subexp): Remove cast.
8119         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8120         const.
8121         (iterate_over_file_blocks): Likewise.
8122         * f-exp.y (%union) <bval>: Remove.
8123         * coffread.c (patch_opaque_types): Make "b" const.
8124         * spu-tdep.c (spu_catch_start): Make "block" const.
8125         * c-valprint.c (print_unpacked_pointer): Remove "block".
8126         * symmisc.c (dump_symtab_1): Make "b" const.
8127         (block_depth): Make "block" const.
8128         * d-exp.y (%union) <bval>: Remove.
8129         * cp-support.h (cp_lookup_rtti_type): Update.
8130         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8131         * psymtab.c (psym_lookup_symbol): Make "block" const.
8132         (maintenance_check_psymtabs): Make "b" const.
8133         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8134         (enumerate_locals, enumerate_args): Update.
8135         * python/py-symtab.c (stpy_global_block): Make "block" const.
8136         (stpy_static_block): Likewise.
8137         * inline-frame.c (block_starting_point_at): Make "new_block"
8138         const.
8139         * block.c (find_block_in_blockvector): Make return type const.
8140         (blockvector_for_pc_sect): Make "b" const.
8141         (find_block_in_blockvector): Make "b" const.
8142
8143 2019-03-23  Tom Tromey  <tom@tromey.com>
8144
8145         * varobj.c (varobj_create): Update.
8146         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8147         * printcmd.c (display_command, do_one_display): Don't reset
8148         innermost_block.
8149         * parser-defs.h (enum innermost_block_tracker_type): Move to
8150         expression.h.
8151         (innermost_block): Update comment.
8152         * parse.c (parse_exp_1): Add tracker_types parameter.
8153         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8154         tracker_types parameter.  Reset innermost_block.
8155         (parse_exp_in_context): Remove.
8156         (parse_expression_for_completion): Update.
8157         * objfiles.c (~objfile): Don't reset expression_context_block or
8158         innermost_block.
8159         * expression.h (enum innermost_block_tracker_type): Move from
8160         parser-defs.h.
8161         (parse_exp_1): Add tracker_types parameter.
8162         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8163         reset innermost_block.
8164
8165 2019-03-23  Tom Tromey  <tom@tromey.com>
8166
8167         * objfiles.h: Include bcache.h.
8168
8169 2019-03-23  Tom Tromey  <tom@tromey.com>
8170
8171         * linespec.c (get_current_search_block): Use
8172         scoped_restore_current_language.
8173         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8174
8175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8176             Jiong Wang  <jiong.wang@arm.com>
8177
8178         * aarch64-linux-tdep.c
8179         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8180         section.
8181         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8182
8183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8184             Jiong Wang  <jiong.wang@arm.com>
8185
8186         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8187         instructions.
8188         (aarch64_analyze_prologue_test): Add PACIASP test.
8189         (aarch64_prologue_prev_register): Unmask PC value.
8190
8191 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8192             Jiong Wang  <jiong.wang@arm.com>
8193
8194         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8195         (aarch64_dwarf2_prev_register): Unmask PC value.
8196         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8197         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8198         DW_CFA_AARCH64_negate_ra_state.
8199         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8200
8201 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8202             Jiong Wang  <jiong.wang@arm.com>
8203
8204         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8205         registers.
8206         (aarch64_pseudo_register_name): Likewise.
8207         (aarch64_pseudo_register_type): Likewise.
8208         (aarch64_pseudo_register_reggroup_p): Likewise.
8209         (aarch64_gdbarch_init): Add pauth registers.
8210         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8211         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8212         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8213         (struct gdbarch_tdep): Add regnum for ra_state.
8214
8215 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8216             Jiong Wang  <jiong.wang@arm.com>
8217
8218         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8219
8220 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8221             Jiong Wang  <jiong.wang@arm.com>
8222
8223         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8224         function.
8225         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8226         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8227         (aarch64_gdbarch_init): Add puth registers.
8228         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8229         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8230         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8231
8232 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8233             Jiong Wang  <jiong.wang@arm.com>
8234
8235         * aarch64-linux-nat.c
8236         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8237         * aarch64-linux-tdep.c
8238         (aarch64_linux_core_read_description): Likewise.
8239         (aarch64_linux_get_hwcap): New function.
8240         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8241         (aarch64_linux_get_hwcap): New declaration.
8242
8243 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8244             Jiong Wang  <jiong.wang@arm.com>
8245
8246         * aarch64-linux-nat.c
8247         (aarch64_linux_nat_target::read_description): Add pauth param.
8248         * aarch64-linux-tdep.c
8249         (aarch64_linux_core_read_description): Likewise.
8250         * aarch64-tdep.c (struct target_desc): Add in pauth.
8251         (aarch64_read_description): Add pauth param.
8252         (aarch64_gdbarch_init): Likewise.
8253         * aarch64-tdep.h (aarch64_read_description): Likewise.
8254         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8255         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8256         * features/Makefile: Add new files.
8257         * features/aarch64-pauth.c: New file.
8258         * features/aarch64-pauth.xml: New file.
8259
8260 2019-03-20  Tom Tromey  <tromey@adacore.com>
8261
8262         * infrun.c (handle_inferior_event): Rename from
8263         handle_inferior_event_1.  Create a scoped_value_mark.
8264         (handle_inferior_event): Remove.
8265
8266 2019-03-19  Tom Tromey  <tromey@adacore.com>
8267
8268         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8269         * infrun.h (print_stop_event): Add "displays" parameter.
8270         * infrun.c (print_stop_event): Add "displays" parameter.
8271
8272 2019-03-19  Pedro Alves  <palves@redhat.com>
8273
8274         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8275         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8276         to -1.  Fix TABs vs spaces.
8277         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8278         * tui/tui-out.h (tui_ui_out) Add intro comments.
8279         <m_line, m_start_of_line>: In-class initialize, and add describing
8280         comment.
8281
8282 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8283
8284         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8285         variable names.
8286         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8287
8288 2019-03-18  Pedro Alves  <palves@redhat.com>
8289             Eli Zaretskii <eliz@gnu.org>
8290
8291         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8292         m_line and m_start_of_line.
8293
8294 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8295
8296         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8297         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8298         it returns a newline.  This fixes a regression in TU mode, whereby
8299         the next line is output on the same screen line as the user input.
8300
8301 2019-03-18  Tom Tromey  <tromey@adacore.com>
8302
8303         * minsyms.c (minimal_symbol_reader::install): Remove call to
8304         obstack_blank.
8305
8306 2019-03-18  Pedro Alves  <palves@redhat.com>
8307
8308         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8309         New globals.
8310         (apply_style): New, factored out from ...
8311         (apply_ansi_escape): ... this.  Handle reverse video mode.
8312         (tui_set_reverse_mode): New function.
8313         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8314         * tui/tui-winsource.c (tui_show_source_line): Use
8315         tui_set_reverse_mode instead of setting A_STANDOUT.
8316         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8317         New setter methods.
8318
8319 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8320
8321         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8322         Handle tabs.
8323
8324 2019-03-18  Tom Tromey  <tromey@adacore.com>
8325
8326         * ada-lang.c (empty_array): Add "high" parameter.
8327         (ada_evaluate_subexp): Update.
8328
8329 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8330
8331         * unittests/string_view-selftests.c: Define
8332         _initialize_string_view_selftests unconditionally.
8333
8334 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8335
8336         PR gdb/24350
8337         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8338
8339 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8340
8341         PR gdb/24351
8342         * windows-nat.c (display_selector): Fix format specifiers.
8343
8344 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8345
8346         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8347         tui_refill_source_window instead of tui_refresh_win, to update the
8348         current execution line.  This fixes redisplay of the current line
8349         when stepping through the code with "next" or "step".
8350
8351 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8352
8353         * source-cache.c (source_cache::get_source_lines): Call
8354         find_source_lines to initialize s->nlines.  This fixes vertical
8355         scrolling of TUI source window when the DOWN arrow is pressed.
8356
8357 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8358
8359         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8360         linux-thread-db.c (_initialize_thread_db): Likewise.
8361
8362 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8363
8364         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8365         wclrtoeol in tui_show_source_line".  This reverts changes made in
8366         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8367
8368 2019-03-15  Tom Tromey  <tom@tromey.com>
8369
8370         * symtab.h (struct minimal_symbol): Derive from
8371         general_symbol_info.
8372         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8373         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8374         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8375         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8376         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8377         (MSYMBOL_SEARCH_NAME): Update.
8378         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8379         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8380         * minsyms.c (minimal_symbol_reader::record_full): Update.
8381
8382 2019-03-15  Tom Tromey  <tom@tromey.com>
8383
8384         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8385
8386 2019-03-15  Tom Tromey  <tom@tromey.com>
8387
8388         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8389         unique_xmalloc_ptr.
8390         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8391         Update.
8392         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8393         (build_minimal_symbol_hash_tables)
8394         (minimal_symbol_reader::install): Update.
8395
8396 2019-03-15  Tom Tromey  <tom@tromey.com>
8397
8398         * symtab.c (create_demangled_names_hash): Update.
8399         (symbol_set_names): Update.
8400         * objfiles.h (struct objfile_per_bfd_storage)
8401         <demangled_names_hash>: Now an htab_up.
8402         * objfiles.c (objfile_per_bfd_storage): Simplify.
8403
8404 2019-03-15  Tom Tromey  <tom@tromey.com>
8405
8406         * objfiles.h (struct objfile_per_bfd_storage): Declare
8407         destructor.
8408         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8409         New.
8410         (get_objfile_bfd_data): Use new.  Don't initialize
8411         language_of_main.
8412         (free_objfile_per_bfd_storage): Remove.
8413         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8414
8415 2019-03-15  Tom Tromey  <tom@tromey.com>
8416
8417         * symfile.c (reread_symbols): Update.
8418         * objfiles.c (objfile::objfile): Update.
8419         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8420         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8421         comment.
8422         (minimal_symbol_reader::install): Update.
8423         (terminate_minimal_symbol_table): Remove.
8424         * jit.c (jit_object_close_impl): Update.
8425
8426 2019-03-15  Tom Tromey  <tom@tromey.com>
8427
8428         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8429         initializations.
8430
8431 2019-03-15  Tom Tromey  <tom@tromey.com>
8432
8433         * objfiles.h (struct objfile_per_bfd_storage)
8434         <demangled_hash_languages>: Now a bitset.
8435         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8436         (lookup_minimal_symbol): Update.
8437
8438 2019-03-15  Tom Tromey  <tom@tromey.com>
8439
8440         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8441         Don't return the symbol.
8442         * coffread.c (record_minimal_symbol): Use record_full.
8443
8444 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8445
8446         The MS-Windows port of ncurses fails to switch to a color pair if
8447         one or both of the colors are the implicit default colors.  This
8448         change records the default colors when TUI is initialized, and
8449         then specifies them explicitly when a color pair uses the default
8450         colors.  This allows color styling in TUI mode on MS-Windows.
8451
8452         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8453         ncurses_norm_attr.
8454         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8455         colors in ncurses_norm_attr.
8456         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8457         "none", replace it with the default color recorded in
8458         ncurses_norm_attr.
8459
8460 2019-03-14  Tom Tromey  <tromey@adacore.com>
8461
8462         * source-cache.h (class source_cache) <get_source_lines>: Return
8463         std::string.
8464         * source-cache.c (source_cache::extract_lines): Handle case where
8465         first_pos==npos.  Return std::string.
8466         (source_cache::get_source_lines): Update.
8467
8468 2019-03-14  Tom Tromey  <tromey@adacore.com>
8469
8470         * NEWS: Add item for "style sources" commands.
8471         * source-cache.c (source_cache::get_source_lines): Check
8472         source_styling.
8473         * cli/cli-style.c (source_styling): New global.
8474         (_initialize_cli_style): Add "style sources" commands.
8475         (show_style_sources): New function.
8476         * cli/cli-style.h (source_styling): Declare.
8477
8478 2019-03-14  Pedro Alves  <palves@redhat.com>
8479             Tom Tromey  <tromey@adacore.com>
8480
8481         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8482         * tui/tui-winsource.c (tui_refill_source_window): New function,
8483         from...
8484         (tui_horizontal_source_scroll): ... here.  Move some logic.
8485         * cli/cli-style.c (set_style_enabled): Notify new observable.
8486         * tui/tui-hooks.c (tui_redisplay_source): New function.
8487         (tui_attach_detach_observers): Attach or detach
8488         tui_redisplay_source.
8489         * observable.h (source_styling_changed): New observable.
8490         * observable.c: Define source_styling_changed observable.
8491
8492 2019-03-13  Tom Tromey  <tromey@adacore.com>
8493
8494         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8495         (i386_gnu_nat_target::store_registers): Update.
8496         * target-debug.h (target_debug_print_std_string): New macro.
8497         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8498         * windows-tdep.c (display_one_tib): Update.
8499         * tui/tui-stack.c (tui_make_status_line): Update.
8500         * top.c (print_inferior_quit_action): Update.
8501         * thread.c (thr_try_catch_cmd): Update.
8502         (add_thread_with_info): Update.
8503         (thread_target_id_str): Update.
8504         (thr_try_catch_cmd): Update.
8505         (thread_command): Update.
8506         (thread_find_command): Update.
8507         * record-btrace.c (record_btrace_target::info_record)
8508         (record_btrace_resume_thread, record_btrace_target::resume)
8509         (record_btrace_cancel_resume, record_btrace_step_thread)
8510         (record_btrace_target::wait, record_btrace_target::wait)
8511         (record_btrace_target::wait, record_btrace_target::stop): Update.
8512         * progspace.c (print_program_space): Update.
8513         * process-stratum-target.c
8514         (process_stratum_target::thread_address_space): Update.
8515         * linux-fork.c (linux_fork_mourn_inferior)
8516         (detach_checkpoint_command, info_checkpoints_command)
8517         (linux_fork_context): Update.
8518         (linux_fork_detach): Update.
8519         (class scoped_switch_fork_info): Update.
8520         (delete_checkpoint_command): Update.
8521         * infrun.c (follow_fork_inferior): Update.
8522         (follow_fork_inferior): Update.
8523         (proceed_after_vfork_done): Update.
8524         (handle_vfork_child_exec_or_exit): Update.
8525         (follow_exec): Update.
8526         (displaced_step_prepare_throw): Update.
8527         (displaced_step_restore): Update.
8528         (start_step_over): Update.
8529         (resume_1): Update.
8530         (clear_proceed_status_thread): Update.
8531         (proceed): Update.
8532         (print_target_wait_results): Update.
8533         (do_target_wait): Update.
8534         (context_switch): Update.
8535         (stop_all_threads): Update.
8536         (restart_threads): Update.
8537         (finish_step_over): Update.
8538         (handle_signal_stop): Update.
8539         (switch_back_to_stepped_thread): Update.
8540         (keep_going_pass_signal): Update.
8541         (print_exited_reason): Update.
8542         (normal_stop): Update.
8543         * inferior.c (inferior_pid_to_str): Change return type.
8544         (print_selected_inferior): Update.
8545         (add_inferior): Update.
8546         (detach_inferior): Update.
8547         * dummy-frame.c (fprint_dummy_frames): Update.
8548         * dcache.c (dcache_info_1): Update.
8549         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8550         (btrace_fetch, btrace_clear): Update.
8551         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8552         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8553         type.
8554         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8555         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8556         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8557         * gdbarch.c, gdbarch.h: Rebuild.
8558         * gdbarch.sh (core_pid_to_str): Change return type.
8559         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8560         return type.
8561         (windows_nat_target::pid_to_str): Change return type.
8562         (windows_delete_thread): Update.
8563         (windows_nat_target::attach): Update.
8564         (windows_nat_target::files_info): Update.
8565         * target-delegates.c: Rebuild.
8566         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8567         return type.
8568         (sol_thread_target::pid_to_str): Change return type.
8569         * remote.c (class remote_target) <pid_to_str>: Change return
8570         type.
8571         (remote_target::pid_to_str): Change return type.
8572         (extended_remote_target::attach, remote_target::remote_stop_ns)
8573         (remote_target::remote_notif_remove_queued_reply)
8574         (remote_target::push_stop_reply, remote_target::disable_btrace):
8575         Update.
8576         (extended_remote_target::attach): Update.
8577         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8578         type.
8579         (gdbsim_target::pid_to_str): Change return type.
8580         * ravenscar-thread.c (struct ravenscar_thread_target)
8581         <pid_to_str>: Change return type.
8582         (ravenscar_thread_target::pid_to_str): Change return type.
8583         * procfs.c (class procfs_target) <pid_to_str>: Change return
8584         type.
8585         (procfs_target::pid_to_str): Change return type.
8586         (procfs_target::attach): Update.
8587         (procfs_target::detach): Update.
8588         (procfs_target::fetch_registers): Update.
8589         (procfs_target::store_registers): Update.
8590         (procfs_target::wait): Update.
8591         (procfs_target::files_info): Update.
8592         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8593         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8594         return type.
8595         (nto_procfs_target::pid_to_str): Change return type.
8596         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8597         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8598         return type.
8599         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8600         (exit_lwp): Update.
8601         (attach_proc_task_lwp_callback, get_detach_signal)
8602         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8603         (linux_nat_target::resume, wait_lwp, stop_callback)
8604         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8605         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8606         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8607         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8608         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8609         type.
8610         (inf_ptrace_target::attach): Update.
8611         (inf_ptrace_target::files_info): Update.
8612         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8613         type.
8614         (go32_nat_target::pid_to_str): Change return type.
8615         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8616         (gnu_nat_target::wait): Update.
8617         (gnu_nat_target::wait): Update.
8618         (gnu_nat_target::resume): Update.
8619         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8620         (fbsd_nat_target::wait): Update.
8621         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8622         type.
8623         (darwin_nat_target::attach): Update.
8624         * corelow.c (class core_target) <pid_to_str>: Change return type.
8625         (core_target::pid_to_str): Change return type.
8626         * target.c (normal_pid_to_str): Change return type.
8627         (default_pid_to_str): Likewise.
8628         (target_pid_to_str): Change return type.
8629         (target_translate_tls_address): Update.
8630         (target_announce_detach): Update.
8631         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8632         return type.
8633         (bsd_uthread_target::pid_to_str): Change return type.
8634         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8635         type.
8636         (bsd_kvm_target::pid_to_str): Change return type.
8637         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8638         return type.
8639         (aix_thread_target::pid_to_str): Change return type.
8640         * target.h (struct target_ops) <pid_to_str>: Change return type.
8641         (target_pid_to_str, normal_pid_to_str): Likewise.
8642         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8643         type.
8644         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8645         type.
8646         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8647         return type.
8648         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8649         type.
8650         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8651         type.
8652         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8653         return type.
8654
8655 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
8656
8657         * NEWS: Mention that the new default MI version is 3.  Mention
8658         changes to the output of commands and events that deal with
8659         multi-location breakpoints.
8660         * breakpoint.c: Include "mi/mi-out.h".
8661         (print_one_breakpoint): Change output syntax if using MI version
8662         >= 3.
8663         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8664         New.
8665         (mi_multi_location_breakpoint_output_fixed): New.
8666         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8667         (mi_cmd_fix_multi_location_breakpoint_output): New.
8668         (mi_multi_location_breakpoint_output_fixed): New.
8669         * mi/mi-cmds.c (mi_cmds): Register command
8670         -fix-multi-location-breakpoint-output.
8671         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8672         interpreter "mi".
8673
8674 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
8675
8676         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8677         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8678         instantiate mi_ui_out based on interpreter name.
8679         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8680         * mi/mi-main.c (mi_load_progress): Likewise.
8681
8682 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8683
8684         * NEWS: Combine separate "New targets" sections for 8.3.
8685
8686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8687
8688         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8689         (ppcfbsd_init_abi): Install gdbarch
8690         "fetch_tls_load_module_address" and "get_thread_local_address"
8691         methods.
8692
8693 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8694
8695         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8696         (riscv_fbsd_init_abi): Install gdbarch
8697         "fetch_tls_load_module_address" and "get_thread_local_address"
8698         methods.
8699
8700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8701
8702         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8703         (i386fbsd_init_abi): Install gdbarch
8704         "fetch_tls_load_module_address" and "get_thread_local_address"
8705         methods.
8706
8707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8708
8709         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8710         (amd64fbsd_init_abi): Install gdbarch
8711         "fetch_tls_load_module_address" and "get_thread_local_address"
8712         methods.
8713
8714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8715
8716         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8717         (struct fbsd_pspace_data): New type.
8718         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8719         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8720         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8721         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8722         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8723
8724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8725
8726         * gdbtypes.c (lookup_struct_elt): New function.
8727         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8728         * gdbtypes.h (struct struct_elt): New type.
8729         (lookup_struct_elt): New prototype.
8730
8731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8732
8733         * gdbtypes.c (lookup_struct_elt_type): Update comment and
8734         remove disabled code block.
8735
8736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8737
8738         * gdbarch.sh (get_thread_local_address): New method.
8739         * gdbarch.h, gdbarch.c: Regenerate.
8740         * target.c (target_translate_tls_address): Use
8741         gdbarch_get_thread_local_address if present instead of
8742         target::get_thread_local_address.
8743
8744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8745
8746         * target.h (target::get_thread_local_address): Update comment.
8747
8748 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8749
8750         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8751         objfile->separate_debug_objfile_backlink if not NULL.
8752
8753 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8754
8755         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8756         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8757         (amd64bsd_store_inferior_registers): Likewise.
8758         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8759         Enable segment base registers.
8760         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8761         PT_GETFSBASE and PT_GETGSBASE.
8762         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8763         PT_SETGSBASE.
8764         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8765         segment base registers.
8766         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8767
8768 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
8769
8770         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8771         Update calls to i386_target_description to add 'segments'
8772         parameter.
8773         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
8774         add segment base registers.
8775         * arch/i386.c (i386_create_target_description): Add 'segments'
8776         parameter to enable segment base registers.
8777         * arch/i386.h (i386_create_target_description): Likewise.
8778         * features/i386/32bit-segments.xml: New file.
8779         * features/i386/32bit-segments.c: Generate.
8780         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8781         call to i386_target_description to add 'segments' parameter.
8782         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8783         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8784         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8785         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8786         if feature is present.
8787         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8788         Add 'segments' parameter to call to i386_target_description.
8789         (i386_target_description): Add 'segments' parameter to enable
8790         segment base registers.
8791         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8792         to call to i386_target_description.
8793         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8794         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8795         Define I386_NUM_REGS.
8796         (i386_target_description): Add 'segments' parameter to enable
8797         segment base registers.
8798
8799 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
8800
8801         PR/24325
8802         * source-cache.c: #undef open and close, to avoid unresolved
8803         externals during linking.
8804
8805 2019-03-12  Tom Tromey  <tromey@adacore.com>
8806
8807         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8808         const.  Add initializers.
8809         (_initialize_remote): Don't initialize ptid globals.
8810
8811 2019-03-12  Pedro Alves  <palves@redhat.com>
8812
8813         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8814
8815 2019-03-12  Pedro Alves  <palves@redhat.com>
8816
8817         * cp-name-parser.y (main): Remove unused 'len' variable.
8818
8819 2019-03-12  Tom Tromey  <tromey@adacore.com>
8820
8821         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8822         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8823
8824 2019-03-12  Tom Tromey  <tromey@adacore.com>
8825
8826         * linux-nat.c (iterate_over_lwps): Update.
8827         (stop_callback): Remove parameter.
8828         (stop_wait_callback, detach_callback, resume_set_callback)
8829         (select_singlestep_lwp_callback, set_ignore_sigint)
8830         (status_callback, resumed_callback, resume_clear_callback)
8831         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8832         data parameter.
8833         (linux_nat_target::detach, linux_nat_target::resume)
8834         (linux_stop_and_wait_all_lwps, select_event_lwp)
8835         (linux_nat_filter_event, linux_nat_wait_1)
8836         (linux_nat_target::kill, linux_nat_target::stop)
8837         (linux_nat_target::stop): Update.
8838         (linux_nat_resume_callback): Change type.
8839         (resume_stopped_resumed_lwps, count_events_callback)
8840         (select_event_lwp_callback): Likewise.
8841         (linux_stop_lwp, linux_nat_stop_lwp): Update.
8842         * arm-linux-nat.c (struct update_registers_data): Remove.
8843         (update_registers_callback): Change type.
8844         (arm_linux_insert_hw_breakpoint1): Update.
8845         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8846         parameter.
8847         (x86_linux_dr_set_addr): Update.
8848         (x86_linux_dr_set_control): Update.
8849         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8850         (iterate_over_lwps): Use gdb::function_view.
8851         * nat/aarch64-linux-hw-point.c (struct
8852         aarch64_dr_update_callback_param): Remove.
8853         (debug_reg_change_callback): Change type.
8854         (aarch64_notify_debug_reg_change): Update.
8855         * s390-linux-nat.c (s390_refresh_per_info): Update.
8856
8857 2019-03-11  Tom Tromey  <tromey@adacore.com>
8858
8859         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8860         redundant assignment to "this_cu".
8861
8862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8863
8864         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8865
8866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8867
8868         * gdbtypes.c (rank_one_type_parm_set): New function extracted
8869         from...
8870         (rank_one_type): ... this.
8871
8872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8873
8874         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8875         from...
8876         (rank_one_type): ... this.
8877
8878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8879
8880         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8881         from...
8882         (rank_one_type): ... this.
8883
8884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8885
8886         * gdbtypes.c (rank_one_type_parm_float): New function extracted
8887         from...
8888         (rank_one_type): ... this.
8889
8890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8891
8892         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8893         from...
8894         (rank_one_type): ... this.
8895
8896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8897
8898         * gdbtypes.c (rank_one_type_parm_range): New function extracted
8899         from...
8900         (rank_one_type): ... this.
8901
8902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8903
8904         * gdbtypes.c (rank_one_type_parm_char): New function extracted
8905         from...
8906         (rank_one_type): ... this.
8907
8908 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8909
8910         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8911         from...
8912         (rank_one_type): ... this.
8913
8914 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8915
8916         * gdbtypes.c (rank_one_type_parm_int): New function extracted
8917         from...
8918         (rank_one_type): ... this.
8919
8920 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8921
8922         * gdbtypes.c (rank_one_type_parm_func): New function extracted
8923         from...
8924         (rank_one_type): ... this.
8925
8926 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8927
8928         * gdbtypes.c (rank_one_type_parm_array): New function extracted
8929         from...
8930         (rank_one_type): ... this.
8931
8932 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
8933
8934         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8935         from...
8936         (rank_one_type): ... this.
8937
8938 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8939
8940         * inferior.c (initialize_inferiors): Ensure 'help set/show print
8941         inferior-events' shows the example events.
8942
8943 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
8944
8945         Support styling on native MS-Windows console
8946
8947         PR/24315
8948         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8949         on MS-Windows if $TERM is not defined.
8950
8951         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8952
8953         * posix-hdep.c (gdb_console_fputs):
8954         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8955         functions.
8956         * ui-file.h (gdb_console_fputs): Add prototype.
8957
8958         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8959         back to fputs only if the former returns zero.
8960
8961 2019-03-07  Tom Tromey  <tom@tromey.com>
8962
8963         * symmisc.c (print_symbol_bcache_statistics): Update.
8964         (print_objfile_statistics): Update.
8965         * symfile.c (allocate_symtab): Update.
8966         * stabsread.c: Don't include bcache.h.
8967         * psymtab.h (struct psymbol_bcache): Don't declare.
8968         (class psymtab_storage) <psymbol_cache>: Now a bcache.
8969         (psymbol_bcache_init, psymbol_bcache_free)
8970         (psymbol_bcache_get_bcache): Don't declare.
8971         * psymtab.c (struct psymbol_bcache): Remove.
8972         (psymtab_storage::psymtab_storage): Update.
8973         (psymtab_storage::~psymtab_storage): Update.
8974         (psymbol_bcache_init, psymbol_bcache_free)
8975         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8976         (add_psymbol_to_bcache): Update.
8977         (allocate_psymtab): Update.
8978         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8979         macro_cache>: No longer pointers.
8980         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8981         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8982         * macrotab.c (macro_bcache): Update.
8983         * macroexp.c: Don't include bcache.h.
8984         * gdbtypes.c (check_types_worklist): Update.
8985         (types_deeply_equal): Remove TRY/CATCH.  Update.
8986         * elfread.c (elf_symtab_read): Update.
8987         * dwarf2read.c: Don't include bcache.h.
8988         * buildsym.c (buildsym_compunit::get_macro_table): Update.
8989         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8990         (print_bcache_statistics, bcache_memory_used): Don't declare.
8991         (struct bcache): Move from bcache.c.  Add constructor, destructor,
8992         methods.  Rename all data members.
8993         * bcache.c (struct bcache): Move to bcache.h.
8994         (bcache::expand_hash_table): Rename from expand_hash_table.
8995         (bcache): Remove.
8996         (bcache::insert): Rename from bcache_full.
8997         (bcache::compare): Rename from bcache_compare.
8998         (bcache_xmalloc): Remove.
8999         (bcache::~bcache): Rename from bcache_xfree.
9000         (bcache::print_statistics): Rename from print_bcache_statistics.
9001         (bcache::memory_used): Rename from bcache_memory_used.
9002
9003 2019-03-07  Pedro Alves  <palves@redhat.com>
9004
9005         * infrun.c (normal_stop): Also check for
9006         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9007
9008 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9009
9010         * f-lang.c (value_from_host_double): Moved to...
9011         * value.c (value_from_host_double): ...here.
9012         * value.h (value_from_host_double): Declare.
9013         * guile/scm-math.c (vlscm_convert_typed_number): Use
9014         value_from_host_double.
9015         (vlscm_convert_number): Likewise.
9016         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9017         * python/py-value.c (convert_value_from_python): Likewise.
9018
9019 2019-03-06  Tom Tromey  <tom@tromey.com>
9020
9021         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9022
9023 2019-03-06  Tom Tromey  <tom@tromey.com>
9024
9025         * utils.h (free_current_contents): Don't declare.
9026         * utils.c (free_current_contents): Remove.
9027
9028 2019-03-06  Tom Tromey  <tom@tromey.com>
9029
9030         * top.c (quit_force): Update.
9031         * main.c (captured_command_loop): Update.
9032         * common/new-op.c (operator new): Update.
9033         * common/common-exceptions.c (struct catcher)
9034         <save_cleanup_chain>: Remove member.
9035         (exceptions_state_mc_init): Update.
9036         (exception_try_scope_entry): Return nullptr.
9037         (exception_try_scope_exit, exception_rethrow)
9038         (throw_exception_sjlj, throw_exception_cxx): Update.
9039         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9040         (all_cleanups, do_cleanups, discard_cleanups)
9041         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9042         (restore_cleanups, restore_final_cleanups): Don't declare.
9043         (do_final_cleanups): Remove parameter.
9044         * common/cleanups.c (cleanup_chain, make_cleanup)
9045         (make_cleanup_dtor, all_cleanups, do_cleanups)
9046         (discard_my_cleanups, discard_cleanups)
9047         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9048         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9049         (null_cleanup): Remove.
9050         (do_final_cleanups): Remove parameter.
9051
9052 2019-03-06  Tom Tromey  <tom@tromey.com>
9053
9054         * remote.c (remote_target::remote_parse_stop_reply): Use
9055         unique_xmalloc_ptr.
9056
9057 2019-03-06  Tom Tromey  <tom@tromey.com>
9058
9059         * stabsread.c (struct stabs_field_info): Rename from field_info.
9060         <list, fnlist>: Add initializers.
9061         <obstack>: New member.
9062         (read_member_functions, read_struct_fields, read_baseclasses):
9063         Allocate on obstack.  Don't use cleanups.
9064         (read_one_struct_field, read_member_functions, read_struct_fields)
9065         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9066         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9067         (read_struct_type): Update.
9068
9069 2019-03-06  Tom Tromey  <tom@tromey.com>
9070
9071         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9072         * common/filestuff.h (make_cleanup_close): Don't declare.
9073         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9074         Remove.
9075
9076 2019-03-06  Tom Tromey  <tom@tromey.com>
9077
9078         * solib-aix.c: Use make_scope_exit.
9079
9080 2019-03-06  Tom Tromey  <tom@tromey.com>
9081
9082         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9083         Use make_scope_exit.
9084
9085 2019-03-06  Tom Tromey  <tom@tromey.com>
9086
9087         * solib-svr4.c (disable_probes_interface): Remove parameter.
9088         (svr4_handle_solib_event): Use make_scope_exit.
9089
9090 2019-03-06  Tom Tromey  <tom@tromey.com>
9091
9092         * remote.c (struct stop_reply_deleter): Remove.
9093         (stop_reply_up): Update.
9094         (struct stop_reply): Derive from notif_event.  Don't typedef.
9095         <regcache>: Now a std::vector.
9096         (stop_reply_xfree): Remove.
9097         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9098         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9099         (remote_target::discard_pending_stop_replies): Use delete.
9100         (remote_target::remote_parse_stop_reply): Update.
9101         (remote_target::process_stop_reply): Update.
9102         * remote-notif.h (struct notif_event): Add virtual destructor.
9103         Remove "dtr" member.
9104         (struct notif_client) <alloc_event>: Return a unique_ptr.
9105         (notif_event_xfree): Don't declare.
9106         (notif_event_up): New typedef.
9107         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9108         (notif_event_xfree, do_notif_event_xfree): Remove.
9109         (remote_notif_state_xfree): Update.
9110
9111 2019-03-06  Tom Tromey  <tom@tromey.com>
9112
9113         * infrun.c (displaced_step_clear_cleanup): Now a
9114         forward_scope_exit type.
9115         (displaced_step_prepare_throw): Update.
9116         (displaced_step_fixup): Update.
9117
9118 2019-03-06  Tom Tromey  <tom@tromey.com>
9119
9120         * inferior.h (class inferior): Update comment.
9121         * gdbthread.h (class thread_info): Update comment.
9122
9123 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9124             Tom Tromey  <tom@tromey.com>
9125
9126         * stabsread.h (struct stab_section_list): Remove.
9127         (coffstab_build_psymtabs): Update.
9128         * dbxread.c (symbuf_sections): Now a std::vector.
9129         (sect_idx): New global.
9130         (fill_symbuf): Update.
9131         (coffstab_build_psymtabs): Change type of stabsects parameter.
9132         Update.
9133         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9134         std::vector.
9135         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9136         (coff_locate_sections): Update.
9137         (coff_symfile_read): Remove cleanups.  Update.
9138         (init_stringtab): Add storage parameter.
9139         (free_stringtab, free_stringtab_cleanup): Remove.
9140         (init_lineno): Add storage parameter.
9141         (free_linetab, free_linetab_cleanup): Remove.
9142
9143 2019-03-06  Pedro Alves  <palves@redhat.com>
9144
9145         * linux-fork.c (fork_info::clobber_regs): Delete.
9146         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9147         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9148         comment.  Adjust.
9149         (scoped_switch_fork_info::scoped_switch_fork_info)
9150         (checkpoint_command, linux_fork_context): Adjust
9151         fork_save_infrun_state calls.
9152
9153 2019-03-06  Pedro Alves  <palves@redhat.com>
9154
9155         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9156         (inf_has_multiple_threads): Return 'bool' and rewrite using
9157         inferior_info::threads().
9158
9159 2019-03-06  Pedro Alves  <palves@redhat.com>
9160
9161         * linux-fork.c: Include <list>.
9162         (fork_list): Now a std::list instance.
9163         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9164         (forks_exist_p, find_last_fork): Adjust.
9165         (new_fork): Delete.
9166         (one_fork_p): New.
9167         (add_fork): Adjust.
9168         (free_fork): Delete, folded into fork_info::~fork_info().
9169         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9170         Adjust.
9171         (init_fork_list): Delete.
9172         (linux_fork_killall, linux_fork_mourn_inferior)
9173         (linux_fork_detach, info_checkpoints_command): Adjust.
9174         (_initialize_linux_fork): No longer call init_fork_list.
9175
9176 2019-03-06  Pedro Alves  <palves@redhat.com>
9177
9178         * linux-fork.c (new_fork): New, split out of ...
9179         (add_fork): ... this.  Return void.  Move "first fork" special
9180         case from here, to ...
9181         (checkpoint_command): ... here.
9182         * linux-linux.h (add_fork): Return void.
9183
9184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9187
9188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9189             Chris January  <chris.january@arm.com>
9190             David Lecomber  <david.lecomber@arm.com>
9191
9192         * f-exp.y: New token, UNOP_INTRINSIC.
9193         (exp): New pattern using UNOP_INTRINSIC token.
9194         (f77_keywords): Add 'abs' keyword.
9195         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9196         (value_from_host_double): New function.
9197         (evaluate_subexp_f): Support UNOP_ABS.
9198
9199 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9200
9201         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9202         types.
9203
9204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9205
9206         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9207         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9208         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9209
9210 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9211
9212         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9213
9214 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9215             Chris January  <chris.january@arm.com>
9216
9217         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9218         * f-exp.y: Define 'KIND' token.
9219         (exp): New pattern for KIND expressions.
9220         (ptype): Handle types with a kind extension.
9221         (direct_abs_decl): Extend to spot kind extensions.
9222         (f77_keywords): Add 'kind' to the list.
9223         (push_kind_type): New function.
9224         (convert_to_kind_type): New function.
9225         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9226         * parse.c (operator_length_standard): Likewise.
9227         * parser-defs.h (enum type_pieces): Add tp_kind.
9228         * std-operator.def: Add UNOP_KIND.
9229
9230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9231
9232         * f-exp.y (f_parse): Set yydebug.
9233
9234 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9235
9236         * f-lang.c (evaluate_subexp_f): New function.
9237         (exp_descriptor_f): New global.
9238         (f_language_defn): Use exp_descriptor_f instead of
9239         exp_descriptor_standard.
9240
9241 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9242
9243         * f-exp.y (struct token): Add comments.
9244         (dot_ops): Remove uppercase versions and the end marker.
9245         (f77_keywords): Likewise.
9246         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9247         entries in the dot_ops array are case insensitive, and use
9248         strncasecmp to compare strings.  Also some whitespace cleanup in
9249         this area.  Similar for the f77_keywords array, except entries in
9250         this list might be case sensitive.
9251
9252 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9253
9254         * f-exp.y (struct f77_boolean_val): Add comments.
9255         (boolean_values): Remove uppercase versions, and end marker.
9256         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9257         and use strncasecmp to achieve case insensitivity.  Additionally,
9258         perform whitespace cleanup around this code.
9259
9260 2019-03-06  Tom Tromey  <tromey@adacore.com>
9261
9262         * remote-sim.c (gdbsim_target_open): Use result of
9263         gdb_argv::release.
9264
9265 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9266         Dirk Schubert  <dirk.schubert@arm.com>
9267         Chris January  <chris.january@arm.com>
9268
9269         * eval.c (evaluate_subexp_standard): Call Fortran argument
9270         wrapping logic.
9271         * f-lang.c (struct value): A value which can be passed into a
9272         Fortran function call.
9273         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9274         where appropriate.
9275         (struct type): Value ready for a Fortran function call.
9276         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9277         is needed.
9278         * f-lang.h (fortran_argument_convert): Declaration.
9279         (fortran_preserve_arg_pointer): Declaration.
9280         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9281
9282 2019-03-05  Tom Tromey  <tromey@adacore.com>
9283
9284         * python/py-prettyprint.c (print_string_repr): Remove #if.
9285         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9286
9287 2019-03-05  Tom Tromey  <tromey@adacore.com>
9288
9289         * target.c (the_dummy_target): Move later.  Change type to
9290         "dummy_target".
9291         (initialize_targets): Don't initialize the_dummy_target.
9292
9293 2019-03-05  Tom Tromey  <tromey@adacore.com>
9294
9295         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9296         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9297
9298 2019-03-05  Tom Tromey  <tromey@adacore.com>
9299
9300         * windows-nat.c (windows_nat_target::attach)
9301         (windows_nat_target::detach): Don't call gdb_flush.
9302         * valprint.c (generic_val_print, val_print, val_print_string):
9303         Don't call gdb_flush.
9304         * utils.c (defaulted_query): Don't call gdb_flush.
9305         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9306         * target.c (target_announce_detach): Don't call gdb_flush.
9307         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9308         * remote.c (extended_remote_target::attach): Don't call
9309         gdb_flush.
9310         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9311         * printcmd.c (do_examine): Don't call gdb_flush.
9312         (info_display_command): Don't call gdb_flush.
9313         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9314         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9315         * memattr.c (info_mem_command): Don't call gdb_flush.
9316         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9317         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9318         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9319         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9320         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9321         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9322         (gnu_nat_target::detach): Don't call gdb_flush.
9323         * f-valprint.c (f_val_print): Don't call gdb_flush.
9324         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9325         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9326         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9327         gdb_flush.
9328         * c-valprint.c (c_val_print): Don't call gdb_flush.
9329         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9330
9331 2019-03-05  Tom Tromey  <tromey@adacore.com>
9332
9333         * varobj.c (update_dynamic_varobj_children): Update.
9334         (install_default_visualizer): Use reset, not release.
9335         * value.c (set_internalvar): Update.
9336         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9337         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9338         ATTRIBUTE_UNUSED_RESULT.
9339
9340 2019-03-05  Tom Tromey  <tromey@adacore.com>
9341
9342         * remote.c (class scoped_remote_fd) <release>: Add
9343         ATTRIBUTE_UNUSED_RESULT.
9344
9345 2019-03-05  Tom Tromey  <tromey@adacore.com>
9346
9347         * macroexp.c (struct macro_buffer) <release>: Add
9348         ATTRIBUTE_UNUSED_RESULT.
9349
9350 2019-03-05  Tom Tromey  <tromey@adacore.com>
9351
9352         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9353         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9354         ATTRIBUTE_UNUSED_RESULT.
9355
9356 2019-03-05  Tom Tromey  <tromey@adacore.com>
9357
9358         * common/scoped_fd.h (class scoped_fd) <release>: Add
9359         ATTRIBUTE_UNUSED_RESULT.
9360
9361 2019-03-05  Tom Tromey  <tromey@adacore.com>
9362
9363         * parser-defs.h (struct parser_state) <release>: Add
9364         ATTRIBUTE_UNUSED_RESULT.
9365
9366 2019-03-05  Tom Tromey  <tromey@adacore.com>
9367
9368         * utils.h (class gdb_argv) <release>: Add
9369         ATTRIBUTE_UNUSED_RESULT.
9370         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9371
9372 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9373
9374         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9375         for-loop range, to avoid compiler warnings.
9376
9377         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9378         avoid compiler warnings about unused variables.
9379
9380         * NEWS: Mention end of support for native debugging on MS-Windows
9381         before XP.
9382
9383         PR gdb/24292
9384         * common/netstuff.c:
9385         * gdbserver/gdbreplay.c
9386         * gdbserver/remote-utils.c:
9387         * ser-tcp.c:
9388         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9389         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9390         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9391         'getaddrinfo' and 'freeaddrinfo' were not available before
9392         Windows XP, and mingw.org's MinGW headers by default define
9393         _WIN32_WINNT to 0x500.
9394
9395 2019-03-01  Gary Benson <gbenson@redhat.com>
9396
9397         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9398
9399 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9400             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9401
9402         PR gdb/8527
9403         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9404         set_sigint_trap, clear_sigint_trap.
9405
9406 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9407
9408         * target.c (target_detach): Clear the regcache and the
9409         frame cache.
9410
9411 2019-02-27  Pedro Alves  <palves@redhat.com>
9412
9413         * utils.c (set_screen_size): When we cap the height/width sizes,
9414         tweak the corresponding command variable to show "unlimited":
9415
9416 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9417             Pedro Alves  <palves@redhat.com>
9418
9419         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9420         before calling rl_set_screen_size.
9421
9422 2019-02-27  Tom Tromey  <tromey@adacore.com>
9423
9424         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9425         define.
9426         * python/py-value.c: Remove Python 2.4 workaround.
9427         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9428         workaround.
9429         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9430         Python 2.4 workaround.
9431         * python/python-internal.h: Remove Python 2.4 comment.
9432         (Py_ssize_t): Don't define.
9433         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9434         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9435         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9436         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9437         * python/python.c (do_start_initialization): Remove Python 2.4
9438         workaround.
9439         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9440         (print_children): Remove Python 2.4 workaround.
9441         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9442         workaround.
9443         (CHARBUFFERPROC_NAME): Remove.
9444         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9445         Python 2.4 workaround.
9446
9447 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9448
9449         * NEWS: Note minimum Python version.
9450
9451 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9452
9453         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9454         code from these functions.  Remove corresponding ifdefs.  Use
9455         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9456         Remove gotos and target of gotos.
9457         (infpy_search_memory): Likewise.
9458
9459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9460
9461         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9462         (hppa_gdbarch_init): Don't register deleted functions with
9463         gdbarch.
9464
9465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9466
9467         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9468         (h8300_unwind_sp): Delete.
9469         (h8300_dummy_id): Delete.
9470         (h8300_gdbarch_init): Don't register deleted functions with
9471         gdbarch.
9472
9473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9474
9475         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9476         (ft32_unwind_pc): Delete.
9477         (ft32_unwind_sp): Delete.
9478         (ft32_gdbarch_init): Don't register deleted functions with
9479         gdbarch.
9480
9481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9482
9483         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9484         (frv_unwind_pc): Delete.
9485         (frv_unwind_sp): Delete.
9486         (frv_gdbarch_init): Don't register deleted functions with
9487         gdbarch.
9488
9489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9490
9491         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9492         (riscv_unwind_pc): Delete.
9493         (riscv_unwind_sp): Delete.
9494         (riscv_gdbarch_init): Don't register deleted functions with
9495         gdbarch.
9496
9497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9498
9499         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9500         (csky_unwind_pc): Delete.
9501         (csky_unwind_sp): Delete.
9502         (csky_gdbarch_init): Don't register deleted functions with
9503         gdbarch.
9504
9505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9506
9507         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9508         (cris_unwind_pc): Delete.
9509         (cris_unwind_sp): Delete.
9510         (cris_gdbarch_init): Don't register deleted functions with
9511         gdbarch.
9512
9513 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9514
9515         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9516         (bfin_unwind_pc): Delete.
9517         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9518
9519 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9520
9521         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9522         (arm_unwind_pc): Delete.
9523         (arm_unwind_sp): Delete.
9524         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9525
9526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9527
9528         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9529         (arc_unwind_pc): Delete.
9530         (arc_unwind_sp): Delete.
9531         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9532
9533 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9534
9535         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9536         (alpha_unwind_pc): Delete.
9537         (alpha_gdbarch_init): Don't register deleted functions with
9538         gdbarch.
9539
9540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9541
9542         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9543         (aarch64_unwind_pc): Delete.
9544         (aarch64_unwind_sp): Delete.
9545         (aarch64_gdbarch_init): Don't register deleted functions with
9546         gdbarch.
9547
9548 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9549
9550         * gdbtypes.c (type_align): Don't consider static members when
9551         computing structure alignment.
9552
9553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9554
9555         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9556         return 0 for other types.
9557         * arch-utils.c (default_type_align): Always return 0.
9558         * gdbarch.h: Regenerate.
9559         * gdbarch.sh (type_align): Extend comment.
9560         * gdbtypes.c (type_align): Add additional comments, always call
9561         gdbarch_type_align before applying the default rules.
9562         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9563         generic code will then apply a suitable default.
9564         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9565         types, return 0 for other types.
9566
9567 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9568
9569         * NEWS: Create a new section for the next release branch.
9570         Rename the section of the current branch, now that it has
9571         been cut.
9572
9573 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9574
9575         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9576         * version.in: Bump version to 8.3.50.DATE-git.
9577
9578 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9579
9580         * aix-thread.c (ptid_cmp): Remove unused variable.
9581         (get_signaled_thread): Likewise.
9582         (store_regs_user_thread): Likewise.
9583         (store_regs_kernel_thread): Likewise.
9584         (fetch_regs_kernel_thread): Remove shadowed variable.
9585
9586 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9587
9588         * features/riscv/32bit-cpu.xml: Add register numbers.
9589         * features/riscv/32bit-fpu.c: Regenerate.
9590         * features/riscv/32bit-fpu.xml: Add register numbers.
9591         * features/riscv/64bit-cpu.xml: Add register numbers.
9592         * features/riscv/64bit-fpu.c: Regenerate.
9593         * features/riscv/64bit-fpu.xml: Add register numbers.
9594
9595 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9596
9597         * NEWS: Mention two argument form of gdb.Value constructor.
9598         * python/py-value.c (convert_buffer_and_type_to_value): New
9599         function.
9600         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9601         Add support for handling an optional second argument.  Call
9602         convert_buffer_and_type_to_value as appropriate.
9603         * python/python-internal.h (Py_buffer_deleter): New struct.
9604         (Py_buffer_up): New typedef.
9605
9606 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9607
9608         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9609         instead of releasing ownership.
9610
9611 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
9612
9613         * dwarf2read.c (open_and_init_dwp_file): Call
9614         elf_numsections instead of bfd_count_sections to initialize
9615         dwp_file->num_sections.
9616
9617 2019-02-25  Tom Tromey  <tromey@adacore.com>
9618
9619         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9620
9621 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
9622
9623         * gcore.in: Add '--readnever' option when invoking GDB.
9624
9625 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9626
9627         * MAINTAINERS: Update my email address.
9628
9629 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
9630
9631         * build-id.c (build_id_to_debug_bfd_1): New function.
9632         (build_id_to_debug_bfd): Look for separate debug file in
9633         sysroot.
9634
9635 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
9636
9637         * gdbarch.sh: Update the copyright year range that is placed into
9638         generated files.
9639
9640 2019-02-22  Keith Seitz  <keiths@redhat.com>
9641
9642         PR symtab/23853
9643         * linespec.c (create_sals_line_offset): Search for the default
9644         symtab's filename instead of its fullname.
9645
9646 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9647
9648         * NEWS: Update style defaults.
9649
9650 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
9651
9652         * main.c (captured_main_1): Disable styling in batch mode.
9653
9654 2019-02-20  Tom Tromey  <tom@tromey.com>
9655
9656         * symtab.c (symtab_symbol_info): Fix typos.
9657
9658 2019-02-20  Tom Tromey  <tromey@adacore.com>
9659
9660         * findcmd.c (_initialize_mem_search): Use upper case for
9661         metasyntactic variables.
9662
9663 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
9664
9665         * aarch64-tdep.c (aarch64_add_reggroups): New function.
9666         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9667
9668 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
9669
9670         * top.h (source_file_name): Change to std::string.
9671         * top.c (source_file_name): Likewise.
9672         (command_line_input): Adjust.
9673         * cli/cli-script.c (script_from_file): Adjust.
9674
9675 2019-02-19  Tom Tromey  <tromey@adacore.com>
9676
9677         * ravenscar-thread.c
9678         (ravenscar_thread_target::update_thread_list): Don't call
9679         ada_build_task_list.
9680         * ada-lang.h (ada_build_task_list): Don't declare.
9681         * ada-tasks.c (struct ada_tasks_inferior_data)
9682         <task_list_valid_p>: Now bool.
9683         (read_known_tasks, ada_task_list_changed)
9684         (ada_tasks_invalidate_inferior_data): Update.
9685         (read_known_tasks_array): Return bool.
9686         (read_known_tasks_list): Likewise.
9687         (read_known_tasks): Return void.
9688         (ada_build_task_list): Now static.
9689
9690 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9691
9692         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9693         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9694
9695 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9696
9697         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9698         variant for ada_tasks_pspace_data_handle and
9699         ada_tasks_inferior_data_handle.
9700         (ada_tasks_pspace_data_cleanup): New function.
9701         (ada_tasks_inferior_data_cleanup): New function.
9702
9703 2019-02-17  Tom Tromey  <tom@tromey.com>
9704
9705         * macrotab.h (macro_source_fullname): Return a std::string.
9706         * macrotab.c (macro_include, check_for_redefinition)
9707         (macro_undef, macro_lookup_definition, foreach_macro)
9708         (foreach_macro_in_scope): Update.
9709         (macro_source_fullname): Return a std::string.
9710         * macrocmd.c (show_pp_source_pos): Update.
9711
9712 2019-02-17  Tom Tromey  <tom@tromey.com>
9713
9714         * macrocmd.c (show_pp_source_pos): Style the file names.
9715
9716 2019-02-17  Tom Tromey  <tom@tromey.com>
9717
9718         PR tui/24197:
9719         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9720
9721 2019-02-17  Tom Tromey  <tom@tromey.com>
9722
9723         * ada-lang.c (user_select_syms): Use filtered printing.
9724         * utils.c (wrap_style): New global.
9725         (desired_style): Remove.
9726         (emit_style_escape): Add stream parameter.
9727         (set_output_style, reset_terminal_style, prompt_for_continue):
9728         Update.
9729         (flush_wrap_buffer): Only flush gdb_stdout.
9730         (wrap_here): Set wrap_style.
9731         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
9732         treat escape sequences as a character.  Change when wrap buffer is
9733         flushed.
9734         (fputs_styled): Do not set the output style when the default is
9735         requested.
9736         * ui-style.h (struct ui_file_style) <is_default>: New method.
9737         * source.c (print_source_lines_base): Emit escape sequences in one
9738         piece.
9739
9740 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9741
9742         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9743         integers and enumeration types.
9744
9745 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
9746
9747         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9748         instead of lookup_symbol_in_language
9749         (do_exact_match): New function.
9750         (ada_get_symbol_name_matcher): Return do_exact_match when
9751         doing a verbatim match.
9752
9753 2019-02-15  Tom Tromey  <tromey@adacore.com>
9754
9755         * ravenscar-thread.c (ravenscar_thread_target::resume)
9756         (ravenscar_thread_target::wait): Special case wildcard requests.
9757
9758 2019-02-15  Tom Tromey  <tromey@adacore.com>
9759
9760         * ravenscar-thread.c (base_ptid): Remove.
9761         (struct ravenscar_thread_target) <close>: New method.
9762         <m_base_ptid>: New member.
9763         <update_inferior_ptid, active_task, task_is_currently_active,
9764         runtime_initialized>: Declare methods.
9765         <ravenscar_thread_target>: Add constructor.
9766         (ravenscar_thread_target::task_is_currently_active)
9767         (ravenscar_thread_target::update_inferior_ptid)
9768         (ravenscar_runtime_initialized): Rename.  Now methods.
9769         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9770         (ravenscar_thread_target::update_thread_list): Update.
9771         (ravenscar_thread_target::active_task): Now method.
9772         (ravenscar_thread_target::store_registers)
9773         (ravenscar_thread_target::prepare_to_store)
9774         (ravenscar_thread_target::prepare_to_store)
9775         (ravenscar_thread_target::mourn_inferior): Update.
9776         (ravenscar_inferior_created): Use "new" to create target.
9777         (ravenscar_thread_target::get_ada_task_ptid): Update.
9778         (_initialize_ravenscar): Don't initialize base_ptid.
9779         (ravenscar_ops): Remove global.
9780
9781 2019-02-15  Tom Tromey  <tromey@adacore.com>
9782
9783         * target.h (push_target): Declare new overload.
9784         * target.c (push_target): New overload, taking an rvalue reference.
9785         * remote.c (remote_target::open_1): Use push_target overload.
9786         * corelow.c (core_target_open): Use push_target overload.
9787
9788 2019-02-15  Tom Tromey  <tromey@adacore.com>
9789
9790         * ravenscar-thread.c (is_ravenscar_task)
9791         (ravenscar_task_is_currently_active): Return bool.
9792         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9793         (_initialize_ravenscar): Remove "(void)".
9794         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9795         Return bool.
9796
9797 2019-02-15  Tom Tromey  <tromey@adacore.com>
9798
9799         * ravenscar-thread.c (ravenscar_runtime_initializer)
9800         (has_ravenscar_runtime, get_running_thread_id)
9801         (ravenscar_thread_target::resume): Fix indentation.
9802
9803 2019-02-15  Tom Tromey  <tromey@adacore.com>
9804
9805         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9806         from ravenscar_arch_ops.
9807         (sparc_ravenscar_ops::fetch_registers)
9808         (sparc_ravenscar_ops::store_registers): Now methods.
9809         (sparc_ravenscar_prepare_to_store): Remove.
9810         (sparc_ravenscar_ops): Redefine.
9811         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9812         methods and destructor.  Remove members.
9813         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9814         (ravenscar_thread_target::store_registers)
9815         (ravenscar_thread_target::prepare_to_store): Update.
9816         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9817         Remove.
9818         (struct ppc_ravenscar_powerpc_ops): Derive from
9819         ravenscar_arch_ops.
9820         (ppc_ravenscar_powerpc_ops::fetch_registers)
9821         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9822         (ppc_ravenscar_powerpc_ops): Redefine.
9823         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9824         (ppc_ravenscar_e500_ops::fetch_registers)
9825         (ppc_ravenscar_e500_ops::store_registers): Now methods.
9826         (ppc_ravenscar_e500_ops): Redefine.
9827         * aarch64-ravenscar-thread.c
9828         (aarch64_ravenscar_generic_prepare_to_store): Remove.
9829         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9830         (aarch64_ravenscar_fetch_registers)
9831         (aarch64_ravenscar_store_registers): Now methods.
9832         (aarch64_ravenscar_ops): Redefine.
9833
9834 2019-02-15  Tom Tromey  <tromey@adacore.com>
9835
9836         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9837         (ravenscar_thread_target::stopped_by_hw_breakpoint)
9838         (ravenscar_thread_target::stopped_by_watchpoint)
9839         (ravenscar_thread_target::stopped_data_address)
9840         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9841
9842 2019-02-15  Tom Tromey  <tromey@adacore.com>
9843
9844         * ravenscar-thread.c: Fix some typos.
9845
9846 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9847             Tom Tromey  <tromey@adacore.com>
9848
9849         * ada-lang.c (ada_exception_sal): Change addr_string to a
9850         std::string.
9851         (create_ada_exception_catchpoint): Update.
9852
9853 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9854             Tom Tromey  <tromey@adacore.com>
9855
9856         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9857         (bp_location_ops): Remove.
9858         (base_breakpoint_allocate_location): Update.
9859         (free_bp_location): Update.
9860         * ada-lang.c (class ada_catchpoint_location)
9861         <ada_catchpoint_location>: Remove ops parameter.
9862         (ada_catchpoint_location_dtor): Remove.
9863         (ada_catchpoint_location_ops): Remove.
9864         (allocate_location_exception): Update.
9865         * breakpoint.h (struct bp_location_ops): Remove.
9866         (class bp_location) <bp_location>: Remove bp_location_ops
9867         parameter.
9868         <~bp_location>: Add destructor.
9869         <ops>: Remove.
9870
9871 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9872             Pedro Alves  <palves@redhat.com>
9873
9874         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9875         'PATH_MAX'.
9876
9877 2019-02-14  David Michael  <fedora.dm0@gmail.com>
9878             Samuel Thibault  <samuel.thibault@gnu.org>
9879             Thomas Schwinge  <thomas@codesourcery.com>
9880
9881         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9882         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9883
9884 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
9885
9886         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9887         (check_empty): Use "const char *".
9888
9889         * gnu-nat.c (gnu_nat_target::detach): Instead of
9890         'detach_inferior (pid)' call
9891         'detach_inferior (find_inferior_pid (pid))'.
9892
9893         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9894         'nat/fork-inferior.o'.
9895         * gnu-nat.c: #include "nat/fork-inferior.h".
9896
9897         * gnu-nat.c (gnu_nat_target::detach): Instead of
9898         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9899         * gnu-nat.h: #include "inf-child.h".
9900         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9901         'i386_gnu_nat_target::fetch_registers'.
9902         (gnu_store_registers): Rename/move to
9903         'i386_gnu_nat_target::store_registers'.
9904
9905         * config/i386/nm-i386gnu.h: Don't "#include" any files.
9906         * gnu-nat.h (mach_thread_info): New function.
9907         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9908
9909         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9910
9911 2019-02-14  Frederic Konrad  <konrad@adacore.com>
9912
9913         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9914
9915 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
9916
9917         * windows-nat.c (windows_add_thread): Add new parameter
9918         "main_thread_p" with default value set to false.  Update
9919         function documentation as well as all callers.
9920         (windows_delete_thread): Likewise.
9921         (fake_create_process): Update call to windows_add_thread.
9922         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9923         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9924         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9925         call to windows_delete_thread.
9926
9927 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
9928
9929         * MAINTAINERS: Add Andrew Burgess as global maintainer.
9930
9931 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9932
9933         * symfile.c (find_separate_debug_file): Use canonical path of
9934         sysroot with child_path instead of gdb_sysroot if it is valid.
9935
9936 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9937
9938         * symfile.c (find_separate_debug_file): Use child_path to
9939         determine if an object file is under a sysroot.
9940
9941 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9942
9943         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9944         unittests/child-path-selftests.c.
9945         * common/pathstuff.c (child_path): New function.
9946         * common/pathstuff.h (child_path): New prototype.
9947         * unittests/child-path-selftests.c: New file.
9948
9949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
9950
9951         * symfile.c (find_separate_debug_file): Look for separate debug
9952         files in debug directories under the sysroot.
9953
9954 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9955
9956         * symtab.h (struct minimal_symbol data_p): New const method.
9957         (struct minimal_symbol text_p): Likewise.
9958         * symtab.c (output_source_filename): Use file name style
9959         to print file name.
9960         (print_symbol_info): Likewise.
9961         (print_msymbol_info): Use address style to print addresses.
9962         Use function name style to print executable text symbols.
9963         (expand_symtab_containing_pc): Use data_p.
9964         (find_pc_sect_compunit_symtab): Likewise.
9965
9966 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9967
9968         * breakpoint.c (describe_other_breakpoints): Use address style
9969         to print addresses.
9970         (say_where): Likewise.
9971
9972 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9973
9974         * ada-typeprint.c (print_func_type): Print function name
9975         style to print function name.
9976         * c-typeprint.c (c_print_type_1): Likewise.
9977
9978 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
9979
9980         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9981         for execve.
9982
9983 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9984
9985         * c-exp.y (direct_abs_decl): Use emplace_back to record the
9986         type_stack.
9987
9988 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
9989
9990         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9991         TYPE_CODE_REF types.
9992
9993 2019-02-08  Jim Wilson  <jimw@sifive.com>
9994
9995         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9996         (riscv_linux_fregset): New.
9997         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9998
9999 2019-02-07  Tom Tromey  <tom@tromey.com>
10000
10001         * thread.c (thread_cancel_execution_command): Update.
10002         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10003         methods.
10004         (struct thread_fsm_ops): Remove.
10005         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10006         (thread_fsm_should_stop, thread_fsm_return_value)
10007         (thread_fsm_set_finished, thread_fsm_finished_p)
10008         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10009         Don't declare.
10010         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10011         * infrun.c (clear_proceed_status_thread)
10012         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10013         (print_stop_event): Update.
10014         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10015         Add constructor.
10016         (step_command_fsm_ops): Remove.
10017         (new_step_command_fsm): Remove.
10018         (step_1): Update.
10019         (step_command_fsm::should_stop): Rename from
10020         step_command_fsm_should_stop.
10021         (step_command_fsm::clean_up): Rename from
10022         step_command_fsm_clean_up.
10023         (step_command_fsm::do_async_reply_reason): Rename from
10024         step_command_fsm_async_reply_reason.
10025         (struct until_next_fsm): Inherit from thread_fsm.  Add
10026         constructor.
10027         (until_next_fsm_ops): Remove.
10028         (new_until_next_fsm): Remove.
10029         (until_next_fsm::should_stop): Rename from
10030         until_next_fsm_should_stop.
10031         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10032         (until_next_fsm::do_async_reply_reason): Rename from
10033         until_next_fsm_async_reply_reason.
10034         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10035         constructor.  Change type of breakpoint.
10036         (finish_command_fsm_ops): Remove.
10037         (new_finish_command_fsm): Remove.
10038         (finish_command_fsm::should_stop): Rename from
10039         finish_command_fsm_should_stop.
10040         (finish_command_fsm::clean_up): Rename from
10041         finish_command_fsm_clean_up.
10042         (finish_command_fsm::return_value): Rename from
10043         finish_command_fsm_return_value.
10044         (finish_command_fsm::do_async_reply_reason): Rename from
10045         finish_command_fsm_async_reply_reason.
10046         (finish_command): Update.
10047         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10048         Add constructor.
10049         (call_thread_fsm_ops): Remove.
10050         (call_thread_fsm::call_thread_fsm): Rename from
10051         new_call_thread_fsm.
10052         (call_thread_fsm::should_stop): Rename from
10053         call_thread_fsm_should_stop.
10054         (call_thread_fsm::should_notify_stop): Rename from
10055         call_thread_fsm_should_notify_stop.
10056         (run_inferior_call, call_function_by_hand_dummy): Update.
10057         * cli/cli-interp.c (should_print_stop_to_console): Update.
10058         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10059         Add constructor.  Change type of location_breakpoint,
10060         caller_breakpoint.
10061         (until_break_fsm_ops): Remove.
10062         (new_until_break_fsm): Remove.
10063         (until_break_fsm::should_stop): Rename from
10064         until_break_fsm_should_stop.
10065         (until_break_fsm::clean_up): Rename from
10066         until_break_fsm_clean_up.
10067         (until_break_fsm::do_async_reply_reason): Rename from
10068         until_break_fsm_async_reply_reason.
10069         (until_break_command): Update.
10070         * thread-fsm.c: Remove.
10071         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10072
10073 2019-02-07  Tom Tromey  <tom@tromey.com>
10074
10075         * yy-remap.h: Add include guard.
10076         * xtensa-tdep.h: Add include guard.
10077         * xcoffread.h: Rename include guard.
10078         * varobj-iter.h: Add include guard.
10079         * tui/tui.h: Rename include guard.
10080         * tui/tui-winsource.h: Rename include guard.
10081         * tui/tui-wingeneral.h: Rename include guard.
10082         * tui/tui-windata.h: Rename include guard.
10083         * tui/tui-win.h: Rename include guard.
10084         * tui/tui-stack.h: Rename include guard.
10085         * tui/tui-source.h: Rename include guard.
10086         * tui/tui-regs.h: Rename include guard.
10087         * tui/tui-out.h: Rename include guard.
10088         * tui/tui-layout.h: Rename include guard.
10089         * tui/tui-io.h: Rename include guard.
10090         * tui/tui-hooks.h: Rename include guard.
10091         * tui/tui-file.h: Rename include guard.
10092         * tui/tui-disasm.h: Rename include guard.
10093         * tui/tui-data.h: Rename include guard.
10094         * tui/tui-command.h: Rename include guard.
10095         * tic6x-tdep.h: Add include guard.
10096         * target/waitstatus.h: Rename include guard.
10097         * target/wait.h: Rename include guard.
10098         * target/target.h: Rename include guard.
10099         * target/resume.h: Rename include guard.
10100         * target-float.h: Rename include guard.
10101         * stabsread.h: Add include guard.
10102         * rs6000-tdep.h: Add include guard.
10103         * riscv-fbsd-tdep.h: Add include guard.
10104         * regformats/regdef.h: Rename include guard.
10105         * record.h: Rename include guard.
10106         * python/python.h: Rename include guard.
10107         * python/python-internal.h: Rename include guard.
10108         * python/py-stopevent.h: Rename include guard.
10109         * python/py-ref.h: Rename include guard.
10110         * python/py-record.h: Rename include guard.
10111         * python/py-record-full.h: Rename include guard.
10112         * python/py-record-btrace.h: Rename include guard.
10113         * python/py-instruction.h: Rename include guard.
10114         * python/py-events.h: Rename include guard.
10115         * python/py-event.h: Rename include guard.
10116         * procfs.h: Add include guard.
10117         * proc-utils.h: Add include guard.
10118         * p-lang.h: Add include guard.
10119         * or1k-tdep.h: Rename include guard.
10120         * observable.h: Rename include guard.
10121         * nto-tdep.h: Rename include guard.
10122         * nat/x86-linux.h: Rename include guard.
10123         * nat/x86-linux-dregs.h: Rename include guard.
10124         * nat/x86-gcc-cpuid.h: Add include guard.
10125         * nat/x86-dregs.h: Rename include guard.
10126         * nat/x86-cpuid.h: Rename include guard.
10127         * nat/ppc-linux.h: Rename include guard.
10128         * nat/mips-linux-watch.h: Rename include guard.
10129         * nat/linux-waitpid.h: Rename include guard.
10130         * nat/linux-ptrace.h: Rename include guard.
10131         * nat/linux-procfs.h: Rename include guard.
10132         * nat/linux-osdata.h: Rename include guard.
10133         * nat/linux-nat.h: Rename include guard.
10134         * nat/linux-namespaces.h: Rename include guard.
10135         * nat/linux-btrace.h: Rename include guard.
10136         * nat/glibc_thread_db.h: Rename include guard.
10137         * nat/gdb_thread_db.h: Rename include guard.
10138         * nat/gdb_ptrace.h: Rename include guard.
10139         * nat/fork-inferior.h: Rename include guard.
10140         * nat/amd64-linux-siginfo.h: Rename include guard.
10141         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10142         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10143         * nat/aarch64-linux.h: Rename include guard.
10144         * nat/aarch64-linux-hw-point.h: Rename include guard.
10145         * mn10300-tdep.h: Add include guard.
10146         * mips-linux-tdep.h: Add include guard.
10147         * mi/mi-parse.h: Rename include guard.
10148         * mi/mi-out.h: Rename include guard.
10149         * mi/mi-main.h: Rename include guard.
10150         * mi/mi-interp.h: Rename include guard.
10151         * mi/mi-getopt.h: Rename include guard.
10152         * mi/mi-console.h: Rename include guard.
10153         * mi/mi-common.h: Rename include guard.
10154         * mi/mi-cmds.h: Rename include guard.
10155         * mi/mi-cmd-break.h: Rename include guard.
10156         * m2-lang.h: Add include guard.
10157         * location.h: Rename include guard.
10158         * linux-record.h: Rename include guard.
10159         * linux-nat.h: Add include guard.
10160         * linux-fork.h: Add include guard.
10161         * i386-darwin-tdep.h: Rename include guard.
10162         * hppa-linux-offsets.h: Add include guard.
10163         * guile/guile.h: Rename include guard.
10164         * guile/guile-internal.h: Rename include guard.
10165         * gnu-nat.h: Rename include guard.
10166         * gdb-stabs.h: Rename include guard.
10167         * frv-tdep.h: Add include guard.
10168         * f-lang.h: Add include guard.
10169         * event-loop.h: Add include guard.
10170         * darwin-nat.h: Rename include guard.
10171         * cp-abi.h: Rename include guard.
10172         * config/sparc/nm-sol2.h: Rename include guard.
10173         * config/nm-nto.h: Rename include guard.
10174         * config/nm-linux.h: Add include guard.
10175         * config/i386/nm-i386gnu.h: Rename include guard.
10176         * config/djgpp/nl_types.h: Rename include guard.
10177         * config/djgpp/langinfo.h: Rename include guard.
10178         * compile/gcc-cp-plugin.h: Add include guard.
10179         * compile/gcc-c-plugin.h: Add include guard.
10180         * compile/compile.h: Rename include guard.
10181         * compile/compile-object-run.h: Rename include guard.
10182         * compile/compile-object-load.h: Rename include guard.
10183         * compile/compile-internal.h: Rename include guard.
10184         * compile/compile-cplus.h: Rename include guard.
10185         * compile/compile-c.h: Rename include guard.
10186         * common/xml-utils.h: Rename include guard.
10187         * common/x86-xstate.h: Rename include guard.
10188         * common/version.h: Rename include guard.
10189         * common/vec.h: Rename include guard.
10190         * common/tdesc.h: Rename include guard.
10191         * common/selftest.h: Rename include guard.
10192         * common/scoped_restore.h: Rename include guard.
10193         * common/scoped_mmap.h: Rename include guard.
10194         * common/scoped_fd.h: Rename include guard.
10195         * common/safe-iterator.h: Rename include guard.
10196         * common/run-time-clock.h: Rename include guard.
10197         * common/refcounted-object.h: Rename include guard.
10198         * common/queue.h: Rename include guard.
10199         * common/ptid.h: Rename include guard.
10200         * common/print-utils.h: Rename include guard.
10201         * common/preprocessor.h: Rename include guard.
10202         * common/pathstuff.h: Rename include guard.
10203         * common/observable.h: Rename include guard.
10204         * common/netstuff.h: Rename include guard.
10205         * common/job-control.h: Rename include guard.
10206         * common/host-defs.h: Rename include guard.
10207         * common/gdb_wait.h: Rename include guard.
10208         * common/gdb_vecs.h: Rename include guard.
10209         * common/gdb_unlinker.h: Rename include guard.
10210         * common/gdb_unique_ptr.h: Rename include guard.
10211         * common/gdb_tilde_expand.h: Rename include guard.
10212         * common/gdb_sys_time.h: Rename include guard.
10213         * common/gdb_string_view.h: Rename include guard.
10214         * common/gdb_splay_tree.h: Rename include guard.
10215         * common/gdb_setjmp.h: Rename include guard.
10216         * common/gdb_ref_ptr.h: Rename include guard.
10217         * common/gdb_optional.h: Rename include guard.
10218         * common/gdb_locale.h: Rename include guard.
10219         * common/gdb_assert.h: Rename include guard.
10220         * common/filtered-iterator.h: Rename include guard.
10221         * common/filestuff.h: Rename include guard.
10222         * common/fileio.h: Rename include guard.
10223         * common/environ.h: Rename include guard.
10224         * common/common-utils.h: Rename include guard.
10225         * common/common-types.h: Rename include guard.
10226         * common/common-regcache.h: Rename include guard.
10227         * common/common-inferior.h: Rename include guard.
10228         * common/common-gdbthread.h: Rename include guard.
10229         * common/common-exceptions.h: Rename include guard.
10230         * common/common-defs.h: Rename include guard.
10231         * common/common-debug.h: Rename include guard.
10232         * common/cleanups.h: Rename include guard.
10233         * common/buffer.h: Rename include guard.
10234         * common/btrace-common.h: Rename include guard.
10235         * common/break-common.h: Rename include guard.
10236         * cli/cli-utils.h: Rename include guard.
10237         * cli/cli-style.h: Rename include guard.
10238         * cli/cli-setshow.h: Rename include guard.
10239         * cli/cli-script.h: Rename include guard.
10240         * cli/cli-interp.h: Rename include guard.
10241         * cli/cli-decode.h: Rename include guard.
10242         * cli/cli-cmds.h: Rename include guard.
10243         * charset-list.h: Add include guard.
10244         * buildsym-legacy.h: Rename include guard.
10245         * bfin-tdep.h: Add include guard.
10246         * ax.h: Rename include guard.
10247         * arm-linux-tdep.h: Add include guard.
10248         * arm-fbsd-tdep.h: Add include guard.
10249         * arch/xtensa.h: Rename include guard.
10250         * arch/tic6x.h: Add include guard.
10251         * arch/i386.h: Add include guard.
10252         * arch/arm.h: Rename include guard.
10253         * arch/arm-linux.h: Rename include guard.
10254         * arch/arm-get-next-pcs.h: Rename include guard.
10255         * arch/amd64.h: Add include guard.
10256         * arch/aarch64-insn.h: Rename include guard.
10257         * arch-utils.h: Rename include guard.
10258         * annotate.h: Add include guard.
10259         * amd64-darwin-tdep.h: Rename include guard.
10260         * aarch64-linux-tdep.h: Add include guard.
10261         * aarch64-fbsd-tdep.h: Add include guard.
10262         * aarch32-linux-nat.h: Add include guard.
10263
10264 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10265
10266         * macrotab.c (macro_define_internal): New function that
10267         factorizes macro_define_object_internal and macro_define_function
10268         code.
10269         (macro_define_object_internal): Use macro_define_internal.
10270         (macro_define_function): Likewise.
10271
10272 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10273
10274         * macrocmd.c (extract_identifier): Return
10275         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10276         callers.
10277
10278 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10279
10280         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10281
10282 2019-02-05  Tom Tromey  <tom@tromey.com>
10283
10284         * target.c (target_stack::unpush): Move assertion earlier.
10285
10286 2019-01-30  Tom Tromey  <tom@tromey.com>
10287
10288         PR python/23615:
10289         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10290         (gdbpy_parse_and_eval): Likewise.
10291         * python/python-internal.h (gdbpy_allow_threads): New class.
10292
10293 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10294
10295         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10296         (aarch64_fbsd_fpregmap): Move earlier.
10297         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10298         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10299         instead of individual calls to trad_frame_set_reg_addr.
10300         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10301         earlier.
10302         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10303         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10304         instead of individual calls to trad_frame_set_reg_addr.
10305
10306 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10307
10308         * CONTRIBUTE: Replace contribution list with wiki link.
10309
10310 2019-01-25  Tom Tromey  <tom@tromey.com>
10311
10312         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10313
10314 2019-01-25  Tom Tromey  <tom@tromey.com>
10315
10316         * xtensa-linux-nat.c: Fix common/ includes.
10317         * xml-support.h: Fix common/ includes.
10318         * xml-support.c: Fix common/ includes.
10319         * x86-linux-nat.c: Fix common/ includes.
10320         * windows-nat.c: Fix common/ includes.
10321         * varobj.h: Fix common/ includes.
10322         * varobj.c: Fix common/ includes.
10323         * value.c: Fix common/ includes.
10324         * valops.c: Fix common/ includes.
10325         * utils.c: Fix common/ includes.
10326         * unittests/xml-utils-selftests.c: Fix common/ includes.
10327         * unittests/utils-selftests.c: Fix common/ includes.
10328         * unittests/unpack-selftests.c: Fix common/ includes.
10329         * unittests/tracepoint-selftests.c: Fix common/ includes.
10330         * unittests/style-selftests.c: Fix common/ includes.
10331         * unittests/string_view-selftests.c: Fix common/ includes.
10332         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10333         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10334         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10335         * unittests/rsp-low-selftests.c: Fix common/ includes.
10336         * unittests/parse-connection-spec-selftests.c: Fix common/
10337         includes.
10338         * unittests/optional-selftests.c: Fix common/ includes.
10339         * unittests/offset-type-selftests.c: Fix common/ includes.
10340         * unittests/observable-selftests.c: Fix common/ includes.
10341         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10342         * unittests/memrange-selftests.c: Fix common/ includes.
10343         * unittests/memory-map-selftests.c: Fix common/ includes.
10344         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10345         * unittests/function-view-selftests.c: Fix common/ includes.
10346         * unittests/environ-selftests.c: Fix common/ includes.
10347         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10348         * unittests/common-utils-selftests.c: Fix common/ includes.
10349         * unittests/cli-utils-selftests.c: Fix common/ includes.
10350         * unittests/array-view-selftests.c: Fix common/ includes.
10351         * ui-file.c: Fix common/ includes.
10352         * tui/tui-io.c: Fix common/ includes.
10353         * tracepoint.h: Fix common/ includes.
10354         * tracepoint.c: Fix common/ includes.
10355         * tracefile-tfile.c: Fix common/ includes.
10356         * top.h: Fix common/ includes.
10357         * top.c: Fix common/ includes.
10358         * thread.c: Fix common/ includes.
10359         * target/waitstatus.h: Fix common/ includes.
10360         * target/waitstatus.c: Fix common/ includes.
10361         * target.h: Fix common/ includes.
10362         * target.c: Fix common/ includes.
10363         * target-memory.c: Fix common/ includes.
10364         * target-descriptions.c: Fix common/ includes.
10365         * symtab.h: Fix common/ includes.
10366         * symfile.c: Fix common/ includes.
10367         * stap-probe.c: Fix common/ includes.
10368         * spu-linux-nat.c: Fix common/ includes.
10369         * sparc-nat.c: Fix common/ includes.
10370         * source.c: Fix common/ includes.
10371         * solib.c: Fix common/ includes.
10372         * solib-target.c: Fix common/ includes.
10373         * ser-unix.c: Fix common/ includes.
10374         * ser-tcp.c: Fix common/ includes.
10375         * ser-pipe.c: Fix common/ includes.
10376         * ser-base.c: Fix common/ includes.
10377         * selftest-arch.c: Fix common/ includes.
10378         * s12z-tdep.c: Fix common/ includes.
10379         * rust-exp.y: Fix common/ includes.
10380         * rs6000-aix-tdep.c: Fix common/ includes.
10381         * riscv-tdep.c: Fix common/ includes.
10382         * remote.c: Fix common/ includes.
10383         * remote-notif.h: Fix common/ includes.
10384         * remote-fileio.h: Fix common/ includes.
10385         * remote-fileio.c: Fix common/ includes.
10386         * regcache.h: Fix common/ includes.
10387         * regcache.c: Fix common/ includes.
10388         * record-btrace.c: Fix common/ includes.
10389         * python/python.c: Fix common/ includes.
10390         * python/py-type.c: Fix common/ includes.
10391         * python/py-inferior.c: Fix common/ includes.
10392         * progspace.h: Fix common/ includes.
10393         * producer.c: Fix common/ includes.
10394         * procfs.c: Fix common/ includes.
10395         * proc-api.c: Fix common/ includes.
10396         * printcmd.c: Fix common/ includes.
10397         * ppc-linux-nat.c: Fix common/ includes.
10398         * parser-defs.h: Fix common/ includes.
10399         * osdata.c: Fix common/ includes.
10400         * obsd-nat.c: Fix common/ includes.
10401         * nat/x86-linux.c: Fix common/ includes.
10402         * nat/x86-linux-dregs.c: Fix common/ includes.
10403         * nat/x86-dregs.h: Fix common/ includes.
10404         * nat/x86-dregs.c: Fix common/ includes.
10405         * nat/ppc-linux.c: Fix common/ includes.
10406         * nat/mips-linux-watch.h: Fix common/ includes.
10407         * nat/mips-linux-watch.c: Fix common/ includes.
10408         * nat/linux-waitpid.c: Fix common/ includes.
10409         * nat/linux-ptrace.h: Fix common/ includes.
10410         * nat/linux-ptrace.c: Fix common/ includes.
10411         * nat/linux-procfs.c: Fix common/ includes.
10412         * nat/linux-personality.c: Fix common/ includes.
10413         * nat/linux-osdata.c: Fix common/ includes.
10414         * nat/linux-namespaces.c: Fix common/ includes.
10415         * nat/linux-btrace.h: Fix common/ includes.
10416         * nat/linux-btrace.c: Fix common/ includes.
10417         * nat/fork-inferior.c: Fix common/ includes.
10418         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10419         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10420         * nat/aarch64-linux.c: Fix common/ includes.
10421         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10422         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10423         * namespace.h: Fix common/ includes.
10424         * mips-linux-tdep.c: Fix common/ includes.
10425         * minsyms.c: Fix common/ includes.
10426         * mi/mi-parse.h: Fix common/ includes.
10427         * mi/mi-main.c: Fix common/ includes.
10428         * mi/mi-cmd-env.c: Fix common/ includes.
10429         * memrange.h: Fix common/ includes.
10430         * memattr.c: Fix common/ includes.
10431         * maint.h: Fix common/ includes.
10432         * maint.c: Fix common/ includes.
10433         * main.c: Fix common/ includes.
10434         * machoread.c: Fix common/ includes.
10435         * location.c: Fix common/ includes.
10436         * linux-thread-db.c: Fix common/ includes.
10437         * linux-nat.c: Fix common/ includes.
10438         * linux-fork.c: Fix common/ includes.
10439         * inline-frame.c: Fix common/ includes.
10440         * infrun.c: Fix common/ includes.
10441         * inflow.c: Fix common/ includes.
10442         * inferior.h: Fix common/ includes.
10443         * inferior.c: Fix common/ includes.
10444         * infcmd.c: Fix common/ includes.
10445         * inf-ptrace.c: Fix common/ includes.
10446         * inf-child.c: Fix common/ includes.
10447         * ia64-linux-nat.c: Fix common/ includes.
10448         * i387-tdep.c: Fix common/ includes.
10449         * i386-tdep.c: Fix common/ includes.
10450         * i386-linux-tdep.c: Fix common/ includes.
10451         * i386-linux-nat.c: Fix common/ includes.
10452         * i386-go32-tdep.c: Fix common/ includes.
10453         * i386-fbsd-tdep.c: Fix common/ includes.
10454         * i386-fbsd-nat.c: Fix common/ includes.
10455         * guile/scm-type.c: Fix common/ includes.
10456         * guile/guile.c: Fix common/ includes.
10457         * go32-nat.c: Fix common/ includes.
10458         * gnu-nat.c: Fix common/ includes.
10459         * gdbthread.h: Fix common/ includes.
10460         * gdbarch-selftests.c: Fix common/ includes.
10461         * gdb_usleep.c: Fix common/ includes.
10462         * gdb_select.h: Fix common/ includes.
10463         * gdb_bfd.c: Fix common/ includes.
10464         * gcore.c: Fix common/ includes.
10465         * fork-child.c: Fix common/ includes.
10466         * findvar.c: Fix common/ includes.
10467         * fbsd-nat.c: Fix common/ includes.
10468         * event-top.c: Fix common/ includes.
10469         * event-loop.c: Fix common/ includes.
10470         * dwarf2read.c: Fix common/ includes.
10471         * dwarf2loc.c: Fix common/ includes.
10472         * dwarf2-frame.c: Fix common/ includes.
10473         * dwarf-index-cache.c: Fix common/ includes.
10474         * dtrace-probe.c: Fix common/ includes.
10475         * disasm-selftests.c: Fix common/ includes.
10476         * defs.h: Fix common/ includes.
10477         * csky-tdep.c: Fix common/ includes.
10478         * cp-valprint.c: Fix common/ includes.
10479         * cp-support.h: Fix common/ includes.
10480         * cp-support.c: Fix common/ includes.
10481         * corelow.c: Fix common/ includes.
10482         * completer.h: Fix common/ includes.
10483         * completer.c: Fix common/ includes.
10484         * compile/compile.c: Fix common/ includes.
10485         * compile/compile-loc2c.c: Fix common/ includes.
10486         * compile/compile-cplus-types.c: Fix common/ includes.
10487         * compile/compile-cplus-symbols.c: Fix common/ includes.
10488         * command.h: Fix common/ includes.
10489         * cli/cli-dump.c: Fix common/ includes.
10490         * cli/cli-cmds.c: Fix common/ includes.
10491         * charset.c: Fix common/ includes.
10492         * build-id.c: Fix common/ includes.
10493         * btrace.h: Fix common/ includes.
10494         * btrace.c: Fix common/ includes.
10495         * breakpoint.h: Fix common/ includes.
10496         * breakpoint.c: Fix common/ includes.
10497         * ax.h:
10498         (enum agent_op): Fix common/ includes.
10499         * ax-general.c (struct aop_map): Fix common/ includes.
10500         * ax-gdb.c: Fix common/ includes.
10501         * auxv.c: Fix common/ includes.
10502         * auto-load.c: Fix common/ includes.
10503         * arm-tdep.c: Fix common/ includes.
10504         * arch/riscv.c: Fix common/ includes.
10505         * arch/ppc-linux-common.c: Fix common/ includes.
10506         * arch/i386.c: Fix common/ includes.
10507         * arch/arm.c: Fix common/ includes.
10508         * arch/arm-linux.c: Fix common/ includes.
10509         * arch/arm-get-next-pcs.c: Fix common/ includes.
10510         * arch/amd64.c: Fix common/ includes.
10511         * arch/aarch64.c: Fix common/ includes.
10512         * arch/aarch64-insn.c: Fix common/ includes.
10513         * arch-utils.c: Fix common/ includes.
10514         * amd64-windows-tdep.c: Fix common/ includes.
10515         * amd64-tdep.c: Fix common/ includes.
10516         * amd64-sol2-tdep.c: Fix common/ includes.
10517         * amd64-obsd-tdep.c: Fix common/ includes.
10518         * amd64-nbsd-tdep.c: Fix common/ includes.
10519         * amd64-linux-tdep.c: Fix common/ includes.
10520         * amd64-linux-nat.c: Fix common/ includes.
10521         * amd64-fbsd-tdep.c: Fix common/ includes.
10522         * amd64-fbsd-nat.c: Fix common/ includes.
10523         * amd64-dicos-tdep.c: Fix common/ includes.
10524         * amd64-darwin-tdep.c: Fix common/ includes.
10525         * agent.c: Fix common/ includes.
10526         * ada-lang.h: Fix common/ includes.
10527         * ada-lang.c: Fix common/ includes.
10528         * aarch64-tdep.c: Fix common/ includes.
10529
10530 2019-01-25  Tom Tromey  <tom@tromey.com>
10531
10532         * common/create-version.sh: Use common/version.h.
10533
10534 2019-01-24  Pedro Alves  <palves@redhat.com>
10535
10536         * infrun.c (signal_stop, signal_print, signal_program)
10537         (signal_catch, signal_pass): Now arrays instead of pointers.
10538         (update_signals_program_target, do_target_resume)
10539         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10540         * linux-nat.c (linux_nat_target::pass_signals)
10541         (linux_nat_target::create_inferior, linux_nat_target::attach):
10542         Adjust.
10543         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10544         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10545         * procfs.c (procfs_target::pass_signals): Adjust.
10546         * record-full.c (record_full_target::resume): Adjust.
10547         * remote.c (remote_target::pass_signals)
10548         (remote_target::program_signals): Adjust.
10549         * target-debug.h (target_debug_print_signals): Now takes a
10550         gdb::array_view as parameter.  Adjust.
10551         * target.h (target_ops) <pass_signals, program_signals>: Replace
10552         pointer and length parameters with gdb::array_view.
10553         (target_pass_signals, target_program_signals): Likewise.
10554         * target-delegates.c: Regenerate.
10555
10556 2019-01-24  Pedro Alves  <palves@redhat.com>
10557
10558         * common/forward-scope-exit.h
10559         (forward_scope_exit::forward_scope_exit): Pass arguments to
10560         m_bind_function directly, instead of creating a std::bind and
10561         copying that.
10562
10563 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10564
10565         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10566         for static members.
10567         (pass_in_v_vfp_candidate): Likewise.
10568
10569 2019-01-23  Tom Tromey  <tom@tromey.com>
10570             Pedro Alves  <palves@redhat.com>
10571
10572         * regcache.c (class regcache_invalidator): Remove.
10573         (regcache::raw_write): Use make_scope_exit.
10574
10575 2019-01-23  Tom Tromey  <tom@tromey.com>
10576
10577         * ui-out.h (class ui_out_emit_type): Update comment.
10578
10579 2019-01-23  Tom Tromey  <tom@tromey.com>
10580
10581         * infrun.c (fetch_inferior_event): Update comment.
10582
10583 2019-01-23  Tom Tromey  <tom@tromey.com>
10584             Pedro Alves  <palves@redhat.com>
10585
10586         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10587         parameter.
10588         (fetch_inferior_event): Use SCOPE_EXIT.
10589
10590
10591 2019-01-23  Tom Tromey  <tom@tromey.com>
10592             Pedro Alves  <palves@redhat.com>
10593
10594         * infrun.c (disable_thread_events): Delete.
10595         (stop_all_threads): Use SCOPE_EXIT.
10596
10597 2019-01-23  Tom Tromey  <tom@tromey.com>
10598             Pedro Alves  <palves@redhat.com>
10599
10600         * symfile.c: Include forward-scope-exit.h.
10601         (clear_symtab_users_cleanup): Replace forward declaration with
10602         a FORWARD_SCOPE_EXIT.
10603         (syms_from_objfile_1): Use the forward_scope_exit and
10604         gdb::optional instead of cleanup_function.
10605         (reread_symbols): Use the forward_scope_exit instead of
10606         cleanup_function.
10607         (clear_symtab_users_cleanup): Remove function.
10608
10609 2019-01-23  Tom Tromey  <tom@tromey.com>
10610             Pedro Alves  <palves@redhat.com>
10611
10612         * linux-nat.c: Include scope-exit.h.
10613         (cleanup_target_stop): Remove.
10614         (linux_nat_target::static_tracepoint_markers_by_strid): Use
10615         SCOPE_EXIT.
10616
10617 2019-01-23  Tom Tromey  <tom@tromey.com>
10618             Pedro Alves  <palves@redhat.com>
10619
10620         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10621         (call_function_by_hand_dummy): Use SCOPE_EXIT.
10622
10623 2019-01-23  Tom Tromey  <tom@tromey.com>
10624             Andrew Burgess  <andrew.burgess@embecosm.com>
10625             Pedro Alves  <palves@redhat.com>
10626
10627         * infrun.c (fetch_inferior_event): Use scope_exit.
10628         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10629         * top.c (execute_command): Use scope_exit.
10630         * breakpoint.c (bpstat_do_actions): Use scope_exit.
10631         * utils.c (do_bpstat_clear_actions_cleanup)
10632         (make_bpstat_clear_actions_cleanup): Remove.
10633
10634 2019-01-23  Tom Tromey  <tom@tromey.com>
10635             Pedro Alves  <palves@redhat.com>
10636
10637         * infrun.c: Include "common/scope-exit.h"
10638         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10639         (wait_for_inferior): Use SCOPE_EXIT.
10640         (fetch_inferior_event): Use scope_exit.
10641
10642 2019-01-23  Tom Tromey  <tom@tromey.com>
10643             Pedro Alves  <palves@redhat.com>
10644
10645         * breakpoint.c (create_breakpoint): Remove cleanup.
10646
10647 2019-01-23  Tom Tromey  <tom@tromey.com>
10648             Andrew Burgess  <andrew.burgess@embecosm.com>
10649             Pedro Alves  <palves@redhat.com>
10650
10651 2019-01-23  Pedro Alves  <palves@redhat.com>
10652
10653         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10654
10655 2019-01-23  Pedro Alves  <palves@redhat.com>
10656             Andrew Burgess  <andrew.burgess@embecosm.com>
10657
10658         * gdbthread.h: Include "common/forward-scope-exit.h".
10659         (scoped_finish_thread_state): Redefine custom class in terms of
10660         forward_scope_exit.
10661
10662 2019-01-23  Pedro Alves  <palves@redhat.com>
10663             Andrew Burgess  <andrew.burgess@embecosm.com>
10664
10665         * common/forward-scope-exit.h: New file.
10666
10667 2019-01-23  Pedro Alves  <palves@redhat.com>
10668             Andrew Burgess  <andrew.burgess@embecosm.com>
10669             Tom Tromey  <tom@tromey.com>
10670
10671         * common/scope-exit.h: New file.
10672
10673 2019-01-23  Pedro Alves  <palves@redhat.com>
10674
10675         * common/preprocessor.h (ESC): Rename to ...
10676         (ESC_PARENS): ... this.
10677         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10678         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10679
10680 2019-01-23  Tom Tromey  <tom@tromey.com>
10681
10682         * language.h (class scoped_switch_to_sym_language_if_auto):
10683         Initialize m_lang in both cases.
10684
10685 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
10686
10687         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10688         with XCNEW.
10689
10690 2019-01-22  Tom Tromey  <tom@tromey.com>
10691
10692         * corelow.c: Do not include sys/file.h.
10693
10694 2019-01-22  Tom Tromey  <tom@tromey.com>
10695
10696         * tui/tui-wingeneral.h: Include gdb_curses.h.
10697
10698 2019-01-22  Tom Tromey  <tom@tromey.com>
10699
10700         * source-cache.h (class source_cache) <get_source_lines,
10701         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10702
10703 2019-01-22  Tom Tromey  <tom@tromey.com>
10704
10705         * remote-fileio.h (struct remote_target): Declare.
10706
10707 2019-01-22  Tom Tromey  <tom@tromey.com>
10708
10709         * python/py-arch.c: Do not include py-ref.h.
10710         * python/py-bpevent.c: Do not include py-ref.h.
10711         * python/py-cmd.c: Do not include py-ref.h.
10712         * python/py-continueevent.c: Do not include py-ref.h.
10713         * python/py-event.h: Do not include py-ref.h.
10714         * python/py-evtregistry.c: Do not include py-ref.h.
10715         * python/py-finishbreakpoint.c: Do not include py-ref.h.
10716         * python/py-frame.c: Do not include py-ref.h.
10717         * python/py-framefilter.c: Do not include py-ref.h.
10718         * python/py-function.c: Do not include py-ref.h.
10719         * python/py-infevents.c: Do not include py-ref.h.
10720         * python/py-linetable.c: Do not include py-ref.h.
10721         * python/py-objfile.c: Do not include py-ref.h.
10722         * python/py-param.c: Do not include py-ref.h.
10723         * python/py-prettyprint.c: Do not include py-ref.h.
10724         * python/py-progspace.c: Do not include py-ref.h.
10725         * python/py-symbol.c: Do not include py-ref.h.
10726         * python/py-symtab.c: Do not include py-ref.h.
10727         * python/py-type.c: Do not include py-ref.h.
10728         * python/py-unwind.c: Do not include py-ref.h.
10729         * python/py-utils.c: Do not include py-ref.h.
10730         * python/py-value.c: Do not include py-ref.h.
10731         * python/py-varobj.c: Do not include py-ref.h.
10732         * python/py-xmethods.c: Do not include py-ref.h.
10733         * python/python.c: Do not include py-ref.h.
10734         * varobj.c: Do not include py-ref.h.
10735
10736 2019-01-22  Tom Tromey  <tom@tromey.com>
10737
10738         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10739         keyword for bcache.
10740
10741 2019-01-22  Tom Tromey  <tom@tromey.com>
10742
10743         * compile/compile-cplus-types.c: Remove a comment by #include.
10744
10745 2019-01-22  Tom Tromey  <tom@tromey.com>
10746
10747         * compile/gcc-c-plugin.h: Include compile-internal.h.
10748
10749 2019-01-22  Tom Tromey  <tom@tromey.com>
10750
10751         * stabsread.c (EXTERN): Do not define.
10752         (symnum, next_symbol_text_func, processing_gcc_compilation)
10753         (within_function, global_sym_chain, global_stabs)
10754         (previous_stab_code, this_object_header_files)
10755         (n_this_object_header_files)
10756         (n_allocated_this_object_header_files): Define.
10757         * stabsread.h (EXTERN): Never define.  Use "extern".
10758
10759 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10760
10761         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10762         history_value.
10763
10764 2019-01-21  Tom Tromey  <tom@tromey.com>
10765
10766         * ui-out.c: Fix includes.
10767         * tui/tui-source.c: Fix includes.
10768         * target.c: Fix includes.
10769         * remote.c: Fix includes.
10770         * regcache.c: Fix includes.
10771         * python/py-block.c: Fix includes.
10772         * printcmd.c: Fix includes.
10773         * or1k-tdep.c: Fix includes.
10774         * mi/mi-main.c: Fix includes.
10775         * m32r-tdep.c: Fix includes.
10776         * csky-tdep.c: Fix includes.
10777         * compile/compile-cplus-types.c: Fix includes.
10778         * cli/cli-interp.c: Fix includes.
10779
10780 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
10781
10782         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10783         for padding.
10784
10785 2019-01-16  Tom Tromey  <tom@tromey.com>
10786
10787         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
10788         earlier.
10789         (struct objfile) <msymbols_range>: Move from top level.
10790         <msymbols>: New method.
10791         (class objfile_msymbols): Remove.
10792         * symtab.c (default_collect_symbol_completion_matches_break_on):
10793         Update.
10794         * symmisc.c (dump_msymbols): Update.
10795         * stabsread.c (scan_file_globals): Update.
10796         * objc-lang.c (info_selectors_command, info_classes_command)
10797         (find_methods): Update.
10798         * minsyms.c (find_solib_trampoline_target): Update.
10799         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10800         * coffread.c (coff_symfile_read): Update.
10801         * ada-lang.c (ada_lookup_simple_minsym)
10802         (ada_collect_symbol_completion_matches): Update.
10803
10804 2019-01-16  Tom Tromey  <tom@tromey.com>
10805
10806         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10807         type.  Remove no-argument constructor.
10808         <iterator::operator++>: Simplify.
10809         <begin>: Update.
10810         <end>: Use minimal_symbol_count.
10811
10812 2019-01-16  Tom Tromey  <tom@tromey.com>
10813
10814         * objfiles.h (struct objfile) <psymtabs>: New method.
10815         (class objfile_psymtabs): Remove.
10816         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10817         typedef.
10818         <range>: New method.
10819         (require_partial_symbols): Change return type.
10820         * psymtab.c (require_partial_symbols)
10821         (psym_expand_symtabs_matching): Update.
10822         * mdebugread.c (parse_partial_symbols): Update.
10823         * dbxread.c (dbx_end_psymtab): Update.
10824
10825 2019-01-15  Tom Tromey  <tom@tromey.com>
10826
10827         * symtab.c (lookup_objfile_from_block)
10828         (lookup_symbol_in_objfile_symtabs)
10829         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10830         (find_line_symtab, info_sources_command)
10831         (default_collect_symbol_completion_matches_break_on)
10832         (make_source_files_completion_list): Update.
10833         * symmisc.c (print_objfile_statistics, dump_objfile)
10834         (maintenance_print_symbols, maintenance_info_symtabs)
10835         (maintenance_check_symtabs, maintenance_info_line_tables):
10836         Update.
10837         * source.c (select_source_symtab)
10838         (forget_cached_source_info_for_objfile): Update.
10839         * objfiles.h (class objfile_compunits): Remove.
10840         (struct objfile) <compunits_range>: New typedef.
10841         (compunits): New method.
10842         * objfiles.c (objfile_relocate1): Update.
10843         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10844         * maint.c (count_symtabs_and_blocks): Update.
10845         * linespec.c (iterate_over_all_matching_symtabs): Update.
10846         * cp-support.c (add_symbol_overload_list_qualified): Update.
10847         * coffread.c (coff_symtab_read): Update.
10848         * ada-lang.c (add_nonlocal_symbols)
10849         (ada_collect_symbol_completion_matches)
10850         (ada_add_global_exceptions): Update.
10851
10852 2019-01-15  Tom Tromey  <tom@tromey.com>
10853
10854         * progspace.h (program_space) <objfiles_safe_range>: New
10855         typedef.
10856         <objfiles_safe>: New method.
10857         * objfiles.h (class all_objfiles_safe): Remove.
10858         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10859         * jit.c (jit_inferior_exit_hook): Update.
10860
10861 2019-01-17  Tom Tromey  <tom@tromey.com>
10862
10863         * progspace.h (program_space) <objfiles_range>: New typedef.
10864         <objfiles>: New method.
10865         <objfiles_head>: Rename from objfiles.
10866         (object_files): Update.
10867         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10868         * guile/scm-pretty-print.c
10869         (ppscm_find_pretty_printer_from_objfiles): Update.
10870         * guile/scm-objfile.c (gdbscm_objfiles): Update.
10871         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10872         Update.
10873         * python/py-progspace.c (pspy_get_objfiles): Update.
10874         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10875         Update.
10876         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10877         (objfpy_lookup_objfile_by_build_id): Update.
10878         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10879         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10880         Update.
10881         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10882         (expand_symtab_containing_pc, lookup_objfile_from_block)
10883         (lookup_static_symbol, basic_lookup_transparent_type)
10884         (find_pc_sect_compunit_symtab, find_symbol_at_address)
10885         (find_line_symtab, info_sources_command)
10886         (default_collect_symbol_completion_matches_break_on)
10887         (make_source_files_completion_list, find_main_name): Update.
10888         * symmisc.c (print_symbol_bcache_statistics)
10889         (print_objfile_statistics, maintenance_print_symbols)
10890         (maintenance_print_msymbols, maintenance_print_objfiles)
10891         (maintenance_info_symtabs, maintenance_check_symtabs)
10892         (maintenance_expand_symtabs, maintenance_info_line_tables):
10893         Update.
10894         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10895         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10896         (map_overlay_command, unmap_overlay_command)
10897         (simple_overlay_update, expand_symtabs_matching)
10898         (map_symbol_filenames): Update.
10899         * symfile-debug.c (set_debug_symfile): Update.
10900         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10901         Update.
10902         * source.c (select_source_symtab, forget_cached_source_info):
10903         Update.
10904         * solib.c (solib_read_symbols): Update.
10905         * solib-spu.c (append_ocl_sos): Update.
10906         * psymtab.c (maintenance_print_psymbols)
10907         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10908         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10909         * printcmd.c (info_symbol_command): Update.
10910         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10911         Update.
10912         * objfiles.h (class all_objfiles): Remove.
10913         * objfiles.c (have_partial_symbols, have_full_symbols)
10914         (have_minimal_symbols, qsort_cmp, update_section_map)
10915         (shared_objfile_contains_address_p)
10916         (default_iterate_over_objfiles_in_search_order): Update.
10917         * objc-lang.c (info_selectors_command, info_classes_command)
10918         (find_methods): Update.
10919         * minsyms.c (find_solib_trampoline_target): Update.
10920         * maint.c (maintenance_info_sections)
10921         (maintenance_translate_address, count_symtabs_and_blocks):
10922         Update.
10923         * main.c (captured_main_1): Update.
10924         * linux-thread-db.c (try_thread_db_load_from_pdir)
10925         (has_libpthread): Update.
10926         * linespec.c (iterate_over_all_matching_symtabs)
10927         (search_minsyms_for_name): Update.
10928         * jit.c (jit_find_objf_with_entry_addr): Update.
10929         * hppa-tdep.c (find_unwind_entry)
10930         (hppa_lookup_stub_minimal_symbol): Update.
10931         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10932         Update.
10933         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10934         (elf_gnu_ifunc_resolve_by_got): Update.
10935         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10936         * dwarf-index-write.c (save_gdb_index_command): Update.
10937         * cp-support.c (add_symbol_overload_list_qualified): Update.
10938         * breakpoint.c (create_overlay_event_breakpoint)
10939         (create_longjmp_master_breakpoint)
10940         (create_std_terminate_master_breakpoint)
10941         (create_exception_master_breakpoint): Update.
10942         * blockframe.c (find_pc_partial_function): Update.
10943         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10944         (ada_collect_symbol_completion_matches)
10945         (ada_add_global_exceptions): Update.
10946
10947 2019-01-17  Tom Tromey  <tom@tromey.com>
10948
10949         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
10950         declare VEC.
10951         (solib_target_parse_libraries): Change return type.
10952         (library_list_start_segment, library_list_start_section)
10953         (library_list_end_library, library_list_start_library); Update.
10954         (solib_target_free_library_list): Remove.
10955         (solib_target_parse_libraries): Remove cleanup.  Change return
10956         type.
10957         (solib_target_current_sos): Update.
10958
10959 2019-01-17  Tom Tromey  <tromey@bapiya>
10960
10961         * valprint.c: Replace "the the" with "the".
10962         * symtab.c: Replace "the the" with "the".
10963         * solib.c: Replace "the the" with "the".
10964         * solib-dsbt.c: Replace "the the" with "the".
10965         * linespec.c: Replace "the the" with "the".
10966         * dwarf2loc.h: Replace "the the" with "the".
10967         * amd64-windows-tdep.c: Replace "the the" with "the".
10968         * aarch64-tdep.c: Replace "the the" with "the".
10969
10970 2019-01-16  Keith Seitz  <keiths@redhat.com>
10971
10972         PR gdb/23773
10973         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10974         <builder>: Rename to ..
10975         <m_builder>: ... this and make private.
10976         (dwarf2_cu::get_builder): New method.  Change all users of
10977         `builder' to use this method.
10978         (dwarf2_start_symtab): Move to ...
10979         (dwarf2_cu::start_symtab): ... here.  Update all callers
10980         (setup_type_unit_groups): Move to ...
10981         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
10982         callers.
10983         (dwarf2_cu::reset_builder): New method.
10984         (process_full_compunit, process_full_type_unit): Use
10985         dwarf2_cu::reset_builder.
10986         (follow_die_offset): Record the ancestor CU if it is different
10987         from the followed DIE's CU.
10988         (follow_die_sig_1): Likewise.
10989
10990 2019-01-15  Tom Tromey  <tom@tromey.com>
10991
10992         * remote.c (class remote_state) <buf>: Now a char_vector.
10993         <buf_size>: Remove.
10994         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
10995         parameter.
10996         (remote_target::getpkt_or_notif_sane_1)
10997         (remote_target::getpkt_sane)
10998         (remote_target::getpkt_or_notif_sane): Likewise.
10999         (class remote_target) <putpkt>: New overload.
11000         (remote_target::read_frame): Change type of "buf_p".  Remove
11001         sizeof_p parameter.
11002         (packet_ok): New overload.
11003         (packet_check_result): New overload.
11004         Update all uses.
11005
11006 2019-01-14  Tom Tromey  <tom@tromey.com>
11007
11008         * remote-notif.c (handle_notification, remote_notif_ack)
11009         (remote_notif_parse): Make "buf" const.
11010         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11011         const.
11012         (remote_notif_parse, remote_notif_ack, handle_notification):
11013         Likewise.
11014         * remote.c (remote_notif_stop_parse): Make "buf" const.
11015         (remote_target::remote_parse_stop_reply): Make "buf" const.
11016         (remote_notif_stop_ack): Make "buf" const.
11017
11018 2019-01-14  Tom Tromey  <tom@tromey.com>
11019
11020         * remote.c (remote_console_output): Make parameter const.
11021
11022 2019-01-14  Tom Tromey  <tom@tromey.com>
11023
11024         * target-debug.h (target_debug_print_signals): Constify.
11025         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11026         * procfs.c (procfs_target::pass_signals): Update.
11027         * linux-nat.c (linux_nat_target::pass_signals): Update.
11028         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11029         * target-delegates.c: Rebuild.
11030         * remote.c (remote_target::program_signals): Update.
11031         (remote_target::pass_signals): Update.
11032         * target.c (target_pass_signals): Constify argument.
11033         (target_program_signals): Likewise.
11034         * target.h (struct target_ops) <pass_signals, program_signals>:
11035         Constify argument.
11036         (target_pass_signals, target_program_signals): Constify argument.
11037
11038 2019-01-14  Tom Tromey  <tom@tromey.com>
11039
11040         PR tui/28819:
11041         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11042
11043 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11044
11045         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11046         field.
11047         * rs6000-tdep.c: Include reggroups.h.
11048         (IS_V_ALIAS_PSEUDOREG): Define.
11049         (rs6000_register_name): Return names for the "vX" aliases.
11050         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11051         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11052         aliases.  Call default_register_reggroup_p for all other
11053         pseudo-registers.
11054         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11055         New functions.
11056         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11057         Handle "vX" aliases.
11058         (v_alias_pseudo_register_collect): New function.
11059         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11060         (rs6000_gdbarch_init): Initialize "vX" aliases as
11061         pseudo-registers.  Restore registration of
11062         rs6000_pseudo_register_reggroup_p with
11063         set_tdesc_pseudo_register_reggroup_p.
11064
11065 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11066
11067         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11068         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11069         set_gdbarch_num_pseudo_regs.
11070
11071 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11072
11073         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11074         Remove arg prefixname, add do_set and do_show.
11075         Add member functions set_list and show_list.
11076         * cli/cli-style.c (class cli_style_option): Update accordingly.
11077         (style_set_list): Move to file scope.
11078         (style_show_list): Likewise.
11079         (set_style): Call help_list.
11080         (show_style): Call cmd_show_list.
11081         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11082         Update to use the new macro.
11083
11084 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11085
11086         * ada-lang.c (_initialize_ada_language): Expand the help text
11087         for the "catch exception" command.
11088
11089 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11090
11091         * symtab.c (matching_obj_sections): Initialize obj,
11092         declare it closer to its usage.
11093
11094 2019-01-10  Tom Tromey  <tom@tromey.com>
11095
11096         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11097         (basic_inf_threads_range): Remove.
11098         (inf_threads_range, inf_non_exited_threads_range)
11099         (safe_inf_threads_range): Use next_adapter.
11100
11101 2019-01-10  Keith Seitz  <keiths@redhat.com>
11102
11103         PR gdb/23712
11104         PR symtab/23010
11105         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11106         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11107
11108 2019-01-10  Keith Seitz  <keiths@redhat.com>
11109
11110         PR gdb/23712
11111         PR symtab/23010
11112         * dictionary.c (pending_to_vector): Remove.
11113         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11114         Remove _1 suffix, replacing functions of the same name.  Update
11115         all callers.
11116         (dict_create_hashed, dict_create_hashed_expandable)
11117         (dict_create_linear, dict_create_linear_expandable, dict_free)
11118         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11119         Make functions static.
11120
11121 2019-01-10  Keith Seitz  <keiths@redhat.com>
11122
11123         PR gdb/23712
11124         PR symtab/23010
11125         * dictionary.h (struct dictionary): Replace declaration with
11126         multidictionary.
11127         (dict_create_hashed, dict_create_hashed_expandable)
11128         (dict_create_linear, dict_create_linear_expandable)
11129         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11130         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11131         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11132         taking multidictionary argument.
11133         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11134         * block.h (struct block) <dict>: Change to multidictionary
11135         and rename `multidict'.
11136         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11137         symmisc.c: Update all dictionary references to multidictionary.
11138
11139 2019-01-10  Keith Seitz  <keiths@redhat.com>
11140
11141         PR gdb/23712
11142         PR symtab/23010
11143         * dictionary.c: Include unordered_map.
11144         (pending_to_vector): New function.
11145         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11146         Rewrite the non-"_1" functions to take vector instead
11147         of linked list.
11148         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11149         "new" _1 versions of the same name.
11150         (multidictionary): Define.
11151         (std::hash<enum language): New definition.
11152         (collate_pending_symbols_by_language, mdict_create_hashed)
11153         (mdict_create_hashed_expandable, mdict_create_linear)
11154         (mdict_create_linear_expandable, mdict_free)
11155         (find_language_dictionary, create_new_language_dictionary)
11156         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11157         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11158         (mdict_size, mdict_empty): New functions.
11159         * dictionary.h (mdict_iterator): Define.
11160
11161 2019-01-10  Pedro Alves  <palves@redhat.com>
11162
11163         * breakpoint.c (read_uploaded_action)
11164         (create_tracepoint_from_upload): Adjust to use
11165         gdb::unique_xmalloc_ptr.
11166         * ctf.c (ctf_write_uploaded_tp):
11167         (SET_ARRAY_FIELD): Use emplace_back.
11168         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11169         * tracefile-tfile.c (tfile_write_uploaded_tp):
11170         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11171         gdb::unique_xmalloc_ptr.
11172         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11173         at_string, cond_string, cmd_strings>: Replace char pointers
11174         with gdb::unique_xmalloc_ptr.
11175
11176 2019-01-10  Pedro Alves  <palves@redhat.com>
11177
11178         * solib-target.c (library_list_start_library): Don't xstrdup name.
11179
11180 2019-01-10  Pedro Alves  <palves@redhat.com>
11181
11182         * mdebugread.c (parse_partial_symbols): Use
11183         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11184
11185 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11186
11187         * linux-fork.c (scoped_switch_fork_info)
11188         <~scoped_switch_fork_info>: Fix incorrect variable name.
11189
11190 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11191
11192         * linux-fork.c (scoped_switch_fork_info)
11193         <scoped_switch_fork_info>: Make explicit.
11194         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11195
11196 2019-01-10  Tom Tromey  <tom@tromey.com>
11197
11198         * objfiles.h (objfile::reset_psymtabs): Update.
11199         * objfiles.c (objfile::objfile): Update.
11200         * psymtab.h (psymtab_storage::obstack): Update.
11201         (psymtab_storage::m_obstack): Use gdb::optional.
11202         (class psymtab_storage): Update comment.  Remove objfile
11203         parameter.
11204         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11205
11206 2019-01-10  Tom Tromey  <tom@tromey.com>
11207
11208         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11209         <free_psymtabs>: Now private.
11210         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11211         (allocate_psymtab): Use new method.
11212
11213 2019-01-10  Tom Tromey  <tom@tromey.com>
11214
11215         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11216         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11217         * mdebugread.c (parse_partial_symbols): Use
11218         allocate_dependencies.
11219         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11220         allocate_dependencies.
11221         (process_psymtab_comp_unit_reader)
11222         (build_type_psymtab_dependencies): Likewise.
11223         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11224
11225 2019-01-10  Tom Tromey  <tom@tromey.com>
11226
11227         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11228         PSYMBOL_SET_LANGUAGE.
11229         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11230
11231 2019-01-10  Tom Tromey  <tom@tromey.com>
11232
11233         * psymtab.h (psymtab_storage::obstack): New method.
11234         <m_obstack>: Rename from obstack; now private.
11235         * psymtab.c (psymtab_storage): Update.
11236         * dwarf2read.c (create_addrmap_from_index)
11237         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11238         Update.
11239
11240 2019-01-10  Tom Tromey  <tom@tromey.com>
11241
11242         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11243         * objfiles.h (objfile::reset_psymtabs): New method.
11244
11245 2019-01-10  Tom Tromey  <tom@tromey.com>
11246
11247         * symmisc.c (print_symbol_bcache_statistics): Update.
11248         (print_objfile_statistics): Update.
11249         * symfile.c (reread_symbols): Update.
11250         * psymtab.h (class psymtab_storage): New.
11251         * psymtab.c (psymtab_storage): New constructor.
11252         (~psymtab_storage): New destructor.
11253         (require_partial_symbols): Update.
11254         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11255         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11256         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11257         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11258         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11259         (start_psymtab_common, end_psymtab_common)
11260         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11261         (allocate_psymtab): Update.
11262         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11263         Update.
11264         (dump_psymtab_addrmap, maintenance_print_psymbols)
11265         (maintenance_check_psymtabs): Update.
11266         (class objfile_psymtabs): Move to objfiles.h.
11267         * psympriv.h (discard_psymtab): Now inline.
11268         (psymtab_discarder::psymtab_discarder): Update.
11269         (psymtab_discarder::~psymtab_discarder): Update.
11270         (ALL_OBJFILE_PSYMTABS): Rewrite.
11271         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11272         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11273         Remove fields.
11274         <partial_symtabs>: New field.
11275         (class objfile_psymtabs): Move from psymtab.h.  Update.
11276         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11277         psymbol_cache.
11278         (objfile::~objfile): Don't destroy psymbol_cache.
11279         * mdebugread.c (parse_partial_symbols): Update.
11280         * dwarf2read.c (create_addrmap_from_index)
11281         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11282         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11283         (add_partial_subprogram, dwarf2_ranges_read): Update.
11284         * dwarf-index-write.c (write_address_map)
11285         (write_one_signatured_type, recursively_write_psymbols)
11286         (class debug_names, class debug_names, write_psymtabs_to_index):
11287         Update.
11288
11289 2019-01-10  Tom Tromey  <tom@tromey.com>
11290
11291         * symtab.h (SYMBOL_SET_NAMES): Update.
11292         (symbol_set_names): Update.
11293         (MSYMBOL_SET_NAMES): Update.
11294         * symtab.c (symbol_set_names): Change argument to be an
11295         objfile_per_bfd_storage.
11296         * psymtab.c (add_psymbol_to_bcache): Update.
11297         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11298
11299 2019-01-10  Tom Tromey  <tom@tromey.com>
11300
11301         * symtab.c (create_demangled_names_hash): Change argument to be an
11302         objfile_per_bfd_storage.
11303         (symbol_set_names): Update.
11304
11305 2019-01-10  Tom Tromey  <tom@tromey.com>
11306
11307         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11308         init_psymbol_list.
11309         * psymtab.c (init_psymbol_list): Do nothing if already called.
11310         * psympriv.h (init_psymbol_list): Add comment.
11311         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11312         init_psymbol_list.
11313         * dbxread.c (dbx_symfile_read): Unconditionally call
11314         init_psymbol_list.
11315
11316 2019-01-10  Tom Tromey  <tom@tromey.com>
11317
11318         * xcoffread.c (scan_xcoff_symtab): Update.
11319         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11320         "where".
11321         * mdebugread.c (parse_partial_symbols)
11322         (handle_psymbol_enumerators): Update.
11323         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11324         * dbxread.c (read_dbx_symtab): Update.
11325         * psympriv.h (psymbol_placement): New enum.
11326         (add_psymbol_to_list): Update.
11327
11328 2019-01-10  Tom Tromey  <tom@tromey.com>
11329
11330         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11331         static_psymbols parameters.
11332         (scan_xcoff_symtab): Update.
11333         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11334         static_psymbols parameters.
11335         * psympriv.h (start_psymtab_common): Update.
11336         * mdebugread.c (parse_partial_symbols): Update.
11337         * dwarf2read.c (create_partial_symtab): Update.
11338         * dbxread.c (read_dbx_symtab): Update.
11339         (start_psymtab): Remove global_psymbols and static_psymbols
11340         parameters.
11341
11342 2019-01-10  Tom Tromey  <tom@tromey.com>
11343
11344         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11345         * psymtab.c (allocate_psymtab): Add comment.
11346         * psympriv.h (allocate_psymtab): Add comment.
11347         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11348         initializations.
11349         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11350
11351 2019-01-10  Tom Tromey  <tom@tromey.com>
11352
11353         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11354         Don't declare.
11355         * mipsread.c: Include mdebugread.h.
11356         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11357         Declare.
11358         * elfread.c: Include mdebugread.h.
11359
11360 2019-01-09  Tom Tromey  <tom@tromey.com>
11361
11362         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11363         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11364         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11365         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11366         (psym_lookup_symbol, psym_find_last_source_symtab)
11367         (psym_forget_cached_source_info, psym_print_stats)
11368         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11369         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11370         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11371         (psym_find_compunit_symtab_by_address)
11372         (maintenance_print_psymbols, maintenance_info_psymtabs)
11373         (maintenance_check_psymtabs): Use ranged for.
11374         * psymtab.h (class objfile_psymtabs): New.
11375         (require_partial_symbols): Return objfile_psymtabs.
11376         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11377
11378 2019-01-09  Tom Tromey  <tom@tromey.com>
11379
11380         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11381         (find_pc_mapped_section, list_overlays_command)
11382         (map_overlay_command, unmap_overlay_command)
11383         (simple_overlay_update): Use all_objfiles.
11384         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11385         * printcmd.c (info_symbol_command): Use all_objfiles.
11386         * objfiles.h (ALL_OBJSECTIONS): Remove.
11387         * maint.c (maintenance_translate_address): Use all_objfiles.
11388         * gcore.c (gcore_create_callback): Use all_objfiles.
11389         (objfile_find_memory_regions): Likewise.
11390
11391 2019-01-09  Tom Tromey  <tom@tromey.com>
11392
11393         * symtab.c (find_line_symtab, info_sources_command)
11394         (make_source_files_completion_list): Use objfile_compunits.
11395         * source.c (select_source_symtab): Use objfile_compunits.
11396         * objfiles.h (struct objfile): Update comment.
11397         (ALL_OBJFILES): Remove.
11398         (ALL_FILETABS): Remove.
11399         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11400         objfile_compunits.
11401
11402 2019-01-09  Tom Tromey  <tom@tromey.com>
11403
11404         * symmisc.c (print_objfile_statistics, dump_objfile)
11405         (maintenance_print_symbols): Use compunit_filetabs.
11406         * source.c (forget_cached_source_info_for_objfile): Use
11407         compunit_filetabs.
11408         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11409         (ALL_FILETABS): Use compunit_filetabs.
11410         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11411         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11412
11413 2019-01-09  Tom Tromey  <tom@tromey.com>
11414
11415         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11416         (compunit_filetabs): New.
11417         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11418         compunit_filetabs.
11419         (info_sources_command, make_source_files_completion_list): Remove
11420         declaration.
11421         * symmisc.c (print_objfile_statistics, dump_objfile)
11422         (maintenance_print_symbols): Remove declaration.
11423         (maintenance_info_symtabs): Use compunit_filetabs.
11424         (maintenance_info_line_tables): Likewise.
11425         * source.c (select_source_symtab): Change local variable name.
11426         (forget_cached_source_info_for_objfile): Remove declaration.
11427         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11428         * objfiles.c (objfile_relocate1): Remove declaration.
11429         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11430         declaration.
11431         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11432         * coffread.c (coff_symtab_read): Remove declaration.
11433         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11434         compunit_filetabs.
11435
11436 2019-01-09  Tom Tromey  <tom@tromey.com>
11437
11438         * symtab.c (lookup_objfile_from_block)
11439         (find_pc_sect_compunit_symtab, search_symbols)
11440         (default_collect_symbol_completion_matches_break_on): Use
11441         objfile_compunits.
11442         * objfiles.h (ALL_COMPUNITS): Remove.
11443         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11444         * cp-support.c (add_symbol_overload_list_qualified): Use
11445         objfile_compunits.
11446         * ada-lang.c (ada_collect_symbol_completion_matches)
11447         (ada_add_global_exceptions): Use objfile_compunits.
11448
11449 2019-01-09  Tom Tromey  <tom@tromey.com>
11450
11451         * source.c (select_source_symtab)
11452         (forget_cached_source_info_for_objfile): Remove declaration.
11453         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11454         declaration.
11455         * maint.c (count_symtabs_and_blocks): Remove declaration.
11456         * cp-support.c (add_symbol_overload_list_qualified): Remove
11457         declaration.
11458         * coffread.c (coff_symtab_read): Remove declaration.
11459         * symtab.c (lookup_symbol_in_objfile_symtabs)
11460         (basic_lookup_transparent_type_1): Use objfile_compunits.
11461         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11462         (info_sources_command, search_symbols)
11463         (default_collect_symbol_completion_matches_break_on)
11464         (make_source_files_completion_list): Remove declaration.
11465         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11466         (ada_collect_symbol_completion_matches)
11467         (ada_add_global_exceptions): Remove declaration.
11468         * linespec.c (iterate_over_all_matching_symtabs): Use
11469         objfile_compunits.
11470         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11471         (class objfile_compunits): New.
11472         (ALL_COMPUNITS): Use objfile_compunits.
11473         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11474         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11475         objfile_compunits.
11476         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11477
11478 2019-01-09  Tom Tromey  <tom@tromey.com>
11479
11480         * symtab.c (search_symbols)
11481         (default_collect_symbol_completion_matches_break_on): Use
11482         objfile_msymbols.
11483         * ada-lang.c (ada_lookup_simple_minsym)
11484         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11485         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11486         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11487         objfile_msymbols.
11488         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11489         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11490         * objc-lang.c (find_methods): Use objfile_msymbols.
11491         (info_selectors_command, info_classes_command): Likewise.
11492         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11493         * objfiles.h (class objfile_msymbols): New.
11494         (ALL_OBJFILE_MSYMBOLS): Remove.
11495         (ALL_MSYMBOLS): Remove.
11496
11497 2019-01-09  Tom Tromey  <tom@tromey.com>
11498
11499         * common/next-iterator.h (next_adapter): Add Iterator template
11500         parameter.
11501         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11502         (class all_objfiles_safe): New.
11503         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11504         * objfiles.c (put_objfile_before): Update comment.
11505         (add_separate_debug_objfile): Likewise.
11506         (free_all_objfiles): Use all_objfiles_safe.
11507         (objfile_purge_solibs): Likewise.
11508
11509 2019-01-09  Tom Tromey  <tom@tromey.com>
11510
11511         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11512         (expand_symtab_containing_pc, lookup_static_symbol)
11513         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11514         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11515         all_objfiles.
11516         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11517         * breakpoint.c (create_overlay_event_breakpoint)
11518         (create_longjmp_master_breakpoint)
11519         (create_std_terminate_master_breakpoint)
11520         (create_exception_master_breakpoint): Use all_objfiles.
11521         * linux-thread-db.c (try_thread_db_load_from_pdir)
11522         (has_libpthread): Use all_objfiles.
11523         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11524         * linespec.c (iterate_over_all_matching_symtabs)
11525         (search_minsyms_for_name): Use all_objfiles.
11526         * maint.c (maintenance_info_sections): Use all_objfiles.
11527         * main.c (captured_main_1): Use all_objfiles.
11528         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11529         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11530         * guile/scm-pretty-print.c
11531         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11532         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11533         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11534         (maintenance_print_msymbols): Use all_objfiles.
11535         * source.c (select_source_symtab): Use all_objfiles.
11536         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11537         * symfile.c (remove_symbol_file_command)
11538         (expand_symtabs_matching, map_symbol_filenames): Use
11539         all_objfiles.
11540         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11541         all_objfiles.
11542         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11543         * objc-lang.c (find_methods): Use all_objfiles.
11544         * objfiles.c (have_partial_symbols, have_full_symbols)
11545         (have_minimal_symbols, qsort_cmp)
11546         (default_iterate_over_objfiles_in_search_order): Use
11547         all_objfiles.
11548         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11549         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11550         (maintenance_check_psymtabs): Use all_objfiles.
11551         (ALL_PSYMTABS): Remove.
11552         * compile/compile-object-run.c (do_module_cleanup): Use
11553         all_objfiles.
11554         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11555         * cp-support.c (add_symbol_overload_list_qualified): Use
11556         all_objfiles.
11557         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11558         Use all_objfiles.
11559         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11560         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11561         all_objfiles.
11562         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11563         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11564         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11565         Uses all_objfiles.
11566         * solib.c (solib_read_symbols): Use all_objfiles
11567
11568 2019-01-09  Tom Tromey  <tom@tromey.com>
11569
11570         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11571         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11572         all_objfiles.
11573         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11574         * symmisc.c (print_symbol_bcache_statistics)
11575         (print_objfile_statistics, maintenance_print_objfiles)
11576         (maintenance_info_symtabs, maintenance_check_symtabs)
11577         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11578         all_objfiles.
11579         * source.c (forget_cached_source_info): Use all_objfiles.
11580         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11581         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11582         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11583         * objfiles.c (update_section_map): Use all_objfiles.
11584         (shared_objfile_contains_address_p): Likewise.
11585         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11586         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11587
11588 2019-01-09  Tom Tromey  <tom@tromey.com>
11589
11590         * common/next-iterator.h: New file.
11591         * objfiles.h (class all_objfiles): New.
11592         (struct objfile_iterator): New.
11593
11594 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11595
11596         * NEWS: Move the description of the changed "frame", "select-frame",
11597          and "info frame" commands to the Changed commands section.
11598
11599 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11600
11601         * gdbtypes.c (check_stub_method_group): Remove handling of old
11602         mangling schemes.
11603         * linespec.c (find_methods): Likewise.
11604         * stabsread.c (read_member_functions): Likewise.
11605         * valops.c (search_struct_method): Likewise.
11606         (value_struct_elt_for_reference): Likewise.
11607         * NEWS: Mention this change.
11608
11609 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11610
11611         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11612         print_source_lines.
11613         * source.c (print_source_lines_base): Update line number check.
11614         (print_source_lines): New function.
11615         (source_lines_range::source_lines_range): New function.
11616         * source.h (class source_lines_range): New class.
11617         (print_source_lines): New declaration.
11618
11619 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11620
11621         * linespec.c (linespec_state_destructor): Free self->canonical_names.
11622
11623 2019-01-08  Tom Tromey  <tom@tromey.com>
11624             Simon Marchi  <simon.marchi@ericsson.com>
11625
11626         PR gdb/24060
11627         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11628         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11629         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11630         * f-exp.y (DOLLAR_VARIABLE): Likewise.
11631         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11632         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11633
11634 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11635
11636         * source.c (select_source_symtab): Move header comment to
11637         declaration in source.h.
11638         (forget_cached_source_info_for_objfile): Likewise.
11639         (forget_cached_source_info): Likewise.
11640         (identify_source_line): Likewise.
11641         * source.h (identify_source_line): Move declaration from symtab.h
11642         and add comment from source.c
11643         (print_source_lines): Likewise.
11644         (forget_cached_source_info_for_objfile): Likewise.
11645         (forget_cached_source_info): Likewise.
11646         (select_source_symtab): Likewise.
11647         (enum print_source_lines_flag): Move definition from symtab.h.
11648         * symtab.h (identify_source_line): Move declaration to source.h.
11649         (print_source_lines): Likewise.
11650         (forget_cached_source_info_for_objfile): Likewise.
11651         (forget_cached_source_info): Likewise.
11652         (select_source_symtab): Likewise.
11653         (enum print_source_lines_flag): Move definition to source.h.
11654         * tui/tui-hooks.c: Add 'source.h' include.
11655
11656 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11657
11658         * source.c (print_source_lines_base): Handle requests to print
11659         reverse line number sequences, and guard against empty lines
11660         string.
11661
11662 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
11663
11664         * source.c (print_source_lines_base): Fix skip of '\r' if next
11665         character is '\n'.
11666
11667 2019-01-06  Tom Tromey  <tom@tromey.com>
11668
11669         * c-exp.y (struct c_parse_state) <macro_original_text,
11670         expansion_obstack>: New member.
11671         (macro_original_text, expansion_obstack): Remove globals.
11672         (scan_macro_expansion, scanning_macro_expansion)
11673         (finished_macro_expansion): Update.
11674         (scan_macro_cleanup): Remove.
11675         (yylex, c_parse): Update.
11676
11677 2019-01-06  Tom Tromey  <tom@tromey.com>
11678
11679         * c-exp.y (struct c_parse_state) <strings>: New member.
11680         (operator_stoken): Update.
11681
11682 2019-01-06  Tom Tromey  <tom@tromey.com>
11683
11684         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
11685         (union type_stack_elt) <typelist_val>: Now a pointer to
11686         std::vector.
11687         (type_stack_cleanup): Don't declare.
11688         (push_typelist): Update.
11689         * parse.c (pop_typelist): Return a std::vector.
11690         (push_typelist): Take a std::vector.
11691         (follow_types): Update.  Do not free args.
11692         (type_stack_cleanup): Remove.
11693         * c-exp.y (struct c_parse_state): New.
11694         (cpstate): New global.
11695         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11696         (nonempty_typelist): Update.
11697         (func_mod): Create a new vector.
11698         (c_parse): Create a c_parse_state.
11699         (check_parameter_typelist): Do not delete params.
11700         (function_method): Update.  Do not delete type_list.
11701
11702 2019-01-06  Tom Tromey  <tom@tromey.com>
11703
11704         PR gdb/28155:
11705         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11706         check_typedef.
11707         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11708         (print_return_value): Likewise.
11709
11710 2019-01-05  Tom Tromey  <tom@tromey.com>
11711
11712         * contrib/cleanup_check.py: Remove.
11713         * contrib/gcc-with-excheck: Remove.
11714         * contrib/exsummary.py: Remove.
11715         * contrib/excheck.py: Remove.
11716
11717 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
11718
11719         * thread.c (delete_thread_1): Add gdb_assert that THR is not
11720         NULL. Initialize tpprev to NULL instead of assigning it
11721         to NULL on the next statement.
11722         * windows-nat.c (windows_delete_thread): Remove check for
11723         main_thread_id before printing thread exit notifications.
11724         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11725         Remove thread ID check against main_thread_id.
11726         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11727         windows_delete_thread.
11728         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11729
11730 2019-01-04  Tom Tromey  <tom@tromey.com>
11731
11732         * compile/compile.c (_initialize_compile): Use upper case for
11733         metasyntactic variables.
11734         * symmisc.c (_initialize_symmisc): Use upper case for
11735         metasyntactic variables.
11736         * psymtab.c (_initialize_psymtab): Use upper case for
11737         metasyntactic variables.
11738         * demangle.c (demangle_command): Use upper case for metasyntactic
11739         variables.
11740         (_initialize_demangler): Likewise.
11741         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11742         variables.
11743
11744 2019-01-03  Tom Tromey  <tom@tromey.com>
11745
11746         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11747
11748 2019-01-03  Tom Tromey  <tom@tromey.com>
11749
11750         * python/py-symtab.c (salpy_str): Update.
11751         (struct salpy_sal_object) <symtab>: Now a PyObject.
11752         (salpy_dealloc): Update.
11753         (del_objfile_sal): Use gdbpy_ref.
11754
11755 2019-01-03  Tom Tromey  <tom@tromey.com>
11756
11757         * python/py-type.c (convert_field): Use new_reference.  Return
11758         gdbpy_ref.
11759         (make_fielditem): Return gdbpy_ref.
11760         (typy_fields): Update.
11761         (typy_getitem): Update.
11762         (field_name): Return gdbpy_ref.  Use new_reference.
11763         (typy_iterator_iternext): Update.
11764
11765 2019-01-03  Tom Tromey  <tom@tromey.com>
11766
11767         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11768
11769 2019-01-03  Tom Tromey  <tom@tromey.com>
11770
11771         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11772         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11773         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11774         (pspy_set_frame_filters, pspy_set_frame_unwinders)
11775         (pspy_set_type_printers): Likewise.
11776         * python/py-function.c (fnpy_init): Use gdbpy_ref.
11777         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11778         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11779         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11780         (objfpy_set_type_printers): Likewise.
11781
11782 2019-01-03  Tom Tromey  <tom@tromey.com>
11783
11784         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11785         (gdbpy_print_stack): Use gdbpy_err_fetch.
11786         * python/python-internal.h (class gdbpy_err_fetch): New class.
11787         (class gdbpy_enter) <m_error_type, m_error_value,
11788         m_error_traceback>: Remove.
11789         <m_error>: New member.
11790         (gdbpy_exception_to_string): Don't declare.
11791         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11792         * python/py-value.c (convert_value_from_python): Use
11793         gdbpy_err_fetch.
11794         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11795         gdbpy_exception_to_string.
11796         (gdbpy_handle_exception): Use gdbpy_err_fetch.
11797         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11798         gdbpy_err_fetch.
11799
11800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11801
11802         * linux-nat.c (delete_lwp_cleanup): Delete.
11803         (struct lwp_deleter): New struct.
11804         (lwp_info_up): New typedef.
11805         (linux_nat_target::follow_fork): Delete cleanup, and make use of
11806         lwp_info_up.
11807
11808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11809
11810         * linux-fork.c (class scoped_switch_fork_info): New class.
11811         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11812
11813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11814
11815         * valops.c (find_overload_match): Remove use of null_cleanup, and
11816         calls to do_cleanups.
11817
11818 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11819
11820         * compile/compile-cplus-types.c
11821         (compile_cplus_instance::decl_name): Handle changes to
11822         cp_func_name.
11823         * cp-support.c (cp_func_name): Update header comment, update
11824         return type.
11825         * cp-support.h (cp_func_name): Update return type in declaration.
11826         * valops.c (find_overload_match): Move temp_func local to top
11827         level of function and change its type.  Use temp_func to hold and
11828         delete temporary string obtained from cp_func_name.
11829
11830 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
11831
11832         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11833         gdb::char_vector, remove cleanup, and update uses of `msg`.
11834
11835 2019-01-03  Jim Wilson  <jimw@sifive.com>
11836
11837         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11838
11839 2019-01-02  Tom Tromey  <tom@tromey.com>
11840
11841         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11842         (tdesc_parse_xml): Remove cleanups.
11843         * target-descriptions.h (make_cleanup_free_target_description):
11844         Don't declare.
11845         (target_desc_deleter): New struct.
11846         (target_desc_up): New typedef.
11847         * target-descriptions.c (target_desc_deleter::operator()): Rename
11848         from free_target_description.
11849         (make_cleanup_free_target_description): Remove.
11850
11851 2019-01-02  Tom Tromey  <tom@tromey.com>
11852
11853         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
11854         constructor, destructor.
11855         (linespec_parser): Remove typedef.
11856         (~linespec_parser): Rename from linespec_parser_delete.
11857         (linespec_lex_to_end, linespec_complete_label)
11858         (linespec_complete): Update.
11859         (decode_line_full): Remove cleanups.
11860         (decode_line_1): Update.
11861
11862 2019-01-02  Tom Tromey  <tom@tromey.com>
11863
11864         * python/python-internal.h (inferior_to_inferior_object): Change
11865         return type.
11866         * python/py-exitedevent.c (create_exited_event_object): Update.
11867         * python/py-inferior.c (inferior_to_inferior_object): Return
11868         gdbpy_ref.
11869         (python_new_inferior, python_inferior_deleted)
11870         (thread_to_thread_object, delete_thread_object)
11871         (build_inferior_list, gdbpy_selected_inferior): Update.
11872         * python/py-infthread.c (create_thread_object): Update.  Also fail
11873         if inferior_to_inferior_object fails.
11874
11875 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
11876
11877         * inferior.h (class inferior) <displaced_step_state>: New field.
11878         * infrun.h (struct displaced_step_state): Move here from
11879         infrun.c.  Initialize fields, add constructor.
11880         <inf>: Remove field.
11881         <reset>: New method.
11882         * infrun.c (struct displaced_step_inferior_state): Move to
11883         infrun.h.
11884         (displaced_step_inferior_states): Remove.
11885         (get_displaced_stepping_state): Adust.
11886         (displaced_step_in_progress_any_inferior): Adjust.
11887         (displaced_step_in_progress_thread): Adjust.
11888         (displaced_step_in_progress): Adjust.
11889         (add_displaced_stepping_state): Remove.
11890         (get_displaced_step_closure_by_addr): Adjust.
11891         (remove_displaced_stepping_state): Remove.
11892         (infrun_inferior_exit): Call displaced_step_state.reset.
11893         (use_displaced_stepping): Don't check for NULL.
11894         (displaced_step_prepare_throw): Call
11895         get_displaced_stepping_state.
11896         (displaced_step_fixup): Don't check for NULL.
11897         (prepare_for_detach): Don't check for NULL.
11898
11899 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11900
11901         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11902          in case of call that did not complete.
11903
11904 2019-01-02  Andrey Utkin  <autkin@undo.io>
11905
11906         * symfile.c (find_separate_debug_file): Fix search of debug files for
11907         remote debuggee.
11908
11909 2019-01-02  Tom Tromey  <tom@tromey.com>
11910
11911         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11912         indentation.
11913         * python/py-frame.c (frapy_older): Remove cast.
11914         (frapy_newer): Likewise.
11915         * python/py-breakpoint.c (local_setattro): Remove cast.
11916         * python/py-arch.c (archpy_name): Remove local variable.
11917         * python/py-type.c (gdbpy_lookup_type): Remove cast.
11918
11919 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
11920
11921         * unittests/basic_string_view/element_access/char/empty.cc:
11922         Fix year range in copyright header.
11923
11924 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11925
11926         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11927         Delete.
11928         <operator==>: Update with for removed field.
11929         <hash>: Likewise.
11930         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11931         <isa_features>: ...this.
11932         <abi_features>: New field.
11933         (riscv_isa_flen): Update comment.
11934         (riscv_abi_xlen): New declaration.
11935         (riscv_abi_flen): New declaration.
11936         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11937         isa_features.
11938         (riscv_abi_xlen): New function.
11939         (riscv_isa_flen): Update to get answer from isa_features.
11940         (riscv_abi_flen): New function.
11941         (riscv_has_fp_abi): Update to get answer from abi_features.
11942         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11943         xlen and flen.
11944         (riscv_call_info) <xlen, flen>: Update comment.
11945         (riscv_call_arg_struct): Remove invalid assertions
11946         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11947         is removed.
11948         (riscv_gdbarch_init): Gather isa features and abi features
11949         separately, ensure both match on the gdbarch when reusing an old
11950         gdbarch.  Relax an error check to allow 32-bit abi float to run on
11951         a target with 64-bit float hardware.
11952
11953 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11954
11955         * source.c (search_command_helper): Stop reverse search
11956         when line 1 has been searched.
11957
11958 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11959
11960         * record-full.c (record_full_base_target::close): Rewrite
11961         record_full_core_buf_list free logic.
11962
11963 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11964
11965         * break-catch-syscall.c (print_one_catch_syscall): xfree
11966         the last text.
11967
11968 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11969
11970         * top.c (print_gdb_version): Update Copyright year in version
11971         message.
11972
11973 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
11974
11975         Update copyright year range in all GDB files.
11976
11977 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
11978
11979         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
11980
11981 For older changes see ChangeLog-2018.
11982 \f
11983 Local Variables:
11984 mode: change-log
11985 left-margin: 8
11986 fill-column: 74
11987 version-control: never
11988 coding: utf-8
11989 End:
11990