gdb/ChangeLog

   1 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
   4         whitespace to underscore.
   5         (maint_print_c_tdesc_cmd): Use fake filename for target
   6         descriptions that came from the target.
   7         (_initialize_target_descriptions): Add filename command completion
   8         for 'maint print c-tdesc'.
   9
  10 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
  11
  12         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
  13         lines.
  14
  15 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
  16
  17         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
  18         lines.
  19         (dwarf2_find_location_expression): Likewise.
  20         (call_site_parameter_matches): Likewise.
  21         (dwarf2_compile_expr_to_ax): Likewise.
  22         (disassemble_dwarf_expression): Likewise.
  23         (loclist_describe_location): Likewise.
  24
  25 2020-06-23  Pedro Alves  <palves@redhat.com>
  26
  27         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
  28         progspace-and-thread.h.  Include scoped-mock-context.h instead.
  29         (register_to_value_test): Use scoped_mock_context.
  30         * regcache.c: Include "scoped-mock-context.h".
  31         (cooked_read_test): Don't error out if a target is already pushed.
  32         Use scoped_mock_context.  Adjust.
  33         * scoped-mock-context.h: New file.
  34
  35 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
  38         initializer.
  39         (ada_language::is_string_type_p): New member function.
  40         * c-lang.c (c_language_data): Delete la_is_string_type_p
  41         initializer.
  42         (cplus_language_data): Likewise.
  43         (asm_language_data): Likewise.
  44         (minimal_language_data): Likewise.
  45         * d-lang.c (d_language_data): Likewise.
  46         * f-lang.c (f_is_string_type_p): Delete function, implementation
  47         moved to f_language::is_string_type_p.
  48         (f_language_data): Delete la_is_string_type_p initializer.
  49         (f_language::is_string_type_p): New member function,
  50         implementation from f_is_string_type_p.
  51         * go-lang.c (go_is_string_type_p): Delete function, implementation
  52         moved to go_language::is_string_type_p.
  53         (go_language_data): Delete la_is_string_type_p initializer.
  54         (go_language::is_string_type_p): New member function,
  55         implementation from go_is_string_type_p.
  56         * language.c (language_defn::is_string_type_p): Define new member
  57         function.
  58         (default_is_string_type_p): Make static, add comment copied from
  59         header file.
  60         (unknown_language_data): Delete la_is_string_type_p initializer.
  61         (unknown_language::is_string_type_p): New member function.
  62         (auto_language_data): Delete la_is_string_type_p initializer.
  63         (auto_language::is_string_type_p): New member function.
  64         * language.h (language_data): Delete la_is_string_type_p field.
  65         (language_defn::is_string_type_p): Declare new function.
  66         (default_is_string_type_p): Delete desclaration, move comment to
  67         definition.
  68         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
  69         moved to m2_language::is_string_type_p.
  70         (m2_language_data): Delete la_is_string_type_p initializer.
  71         (m2_language::is_string_type_p): New member function,
  72         implementation from m2_is_string_type_p.
  73         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
  74         initializer.
  75         * opencl-lang.c (opencl_language_data): Likewise.
  76         * p-lang.c (pascal_is_string_type_p): Delete function,
  77         implementation moved to pascal_language::is_string_type_p.
  78         (pascal_language_data): Delete la_is_string_type_p initializer.
  79         (pascal_language::is_string_type_p): New member function,
  80         implementation from pascal_is_string_type_p.
  81         * rust-lang.c (rust_is_string_type_p): Delete function,
  82         implementation moved to rust_language::is_string_type_p.
  83         (rust_language_data): Delete la_is_string_type_p initializer.
  84         (rust_language::is_string_type_p): New member function,
  85         implementation from rust_is_string_type_p.
  86         * valprint.c (val_print_scalar_or_string_type_p): Update call to
  87         is_string_type_p.
  88
  89 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  90
  91         * ada-lang.c (ada_language_data): Delete la_print_typedef
  92         initializer.
  93         (ada_language::print_typedef): New member function.
  94         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
  95         (cplus_language_data): Likewise.
  96         (asm_language_data): Likewise.
  97         (minimal_language_data): Likewise.
  98         * d-lang.c (d_language_data): Likewise.
  99         * f-lang.c (f_language_data): Likewise.
 100         (f_language::print_typedef): New member function.
 101         * go-lang.c (go_language_data): Delete la_print_typedef
 102         initializer.
 103         * language.c (language_defn::print_typedef): Define member
 104         function.
 105         (unknown_language_data): Delete la_print_typedef initializer.
 106         (unknown_language::print_typedef): New member function.
 107         (auto_language_data): Delete la_print_typedef initializer.
 108         (auto_language::print_typedef): New member function.
 109         * language.h (language_data): Delete la_print_typedef field.
 110         (language_defn::print_typedef): Declare new member function.
 111         (LA_PRINT_TYPEDEF): Update call to print_typedef.
 112         (default_print_typedef): Delete declaration.
 113         * m2-lang.c (m2_language_data): Delete la_print_typedef
 114         initializer.
 115         (m2_language::print_typedef): New member function.
 116         * objc-lang.c (objc_language_data): Delete la_print_typedef
 117         initializer.
 118         * opencl-lang.c (opencl_language_data): Likewise.
 119         * p-lang.c (pascal_language_data): Likewise.
 120         (pascal_language::print_typedef): New member function.
 121         * rust-lang.c (rust_print_typedef): Delete function,
 122         implementation moved to rust_language::print_typedef.
 123         (rust_language): Delete la_print_typedef initializer.
 124         (rust_language::print_typedef): New member function,
 125         implementation from rust_print_typedef.
 126         * typeprint.c (default_print_typedef): Delete.
 127
 128 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 129
 130         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
 131         (ada_language::printstr): New member function.
 132         * c-lang.c (c_language_data): Delete la_printstr initializer.
 133         (cplus_language_data): Likewise.
 134         (asm_language_data): Likewise.
 135         (minimal_language_data): Likewise.
 136         * d-lang.c (d_language_data): Likewise.
 137         * f-lang.c (f_printstr): Rename to f_language::printstr.
 138         (f_language_data): Delete la_printstr initializer.
 139         (f_language::printstr): New member function, implementation from
 140         f_printstr.
 141         * go-lang.c (go_language_data): Delete la_printstr initializer.
 142         * language.c (language_defn::printstr): Define new member
 143         function.
 144         (unk_lang_printstr): Delete.
 145         (unknown_language_data): Delete la_printstr initializer.
 146         (unknown_language::printstr): New member function.
 147         (auto_language_data): Delete la_printstr initializer.
 148         (auto_language::printstr): New member function.
 149         * language.h (language_data): Delete la_printstr field.
 150         (language_defn::printstr): Declare new member function.
 151         (LA_PRINT_STRING): Update call to printstr.
 152         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
 153         (m2_language_data): Delete la_printstr initializer.
 154         (m2_language::printstr): New member function, implementation from
 155         m2_printstr.
 156         * objc-lang.c (objc_language_data): Delete la_printstr
 157         initializer.
 158         * opencl-lang.c (opencl_language_data): Likewise.
 159         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
 160         (pascal_language_data): Delete la_printstr initializer.
 161         (pascal_language::printstr): New member function, implementation
 162         from pascal_printstr.
 163         * p-lang.h (pascal_printstr): Delete declaration.
 164         * rust-lang.c (rust_printstr): Update header comment.
 165         (rust_language_data): Delete la_printstr initializer.
 166         (rust_language::printstr): New member function.
 167
 168 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
 171         (ada_language::printchar): New member function.
 172         * c-lang.c (c_language_data): Delete la_printchar initializer.
 173         (cplus_language_data): Likewise.
 174         (asm_language_data): Likewise.
 175         (minimal_language_data): Likewise.
 176         * d-lang.c (d_language_data): Likewise.
 177         * f-lang.c (f_printchar): Rename to f_language::printchar.
 178         (f_language_data): Delete la_printchar initializer.
 179         (f_language::printchar): New member function, implementation from
 180         f_printchar.
 181         * go-lang.c (go_language_data): Delete la_printchar initializer.
 182         * language.c (unk_lang_printchar): Delete.
 183         (language_defn::printchar): Define new member function.
 184         (unknown_language_data): Delete la_printchar initializer.
 185         (unknown_language::printchar): New member function.
 186         (auto_language_data): Delete la_printchar initializer.
 187         (auto_language::printchar): New member function.
 188         * language.h (language_data): Delete la_printchar field.
 189         (language_defn::printchar): Declare new member function.
 190         (LA_PRINT_CHAR): Update call to printchar.
 191         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
 192         (m2_language::printchar): New member function.
 193         * objc-lang.c (objc_language_data): Delete la_printchar
 194         initializer.
 195         * opencl-lang.c (opencl_language_data): Likewise.
 196         * p-lang.c (pascal_language_data): Delete la_printchar
 197         initializer.
 198         (pascal_language::printchar): New member function.
 199         * rust-lang.c (rust_printchar): Rename to
 200         rust_language::printchar.
 201         (rust_language_data): Delete la_printchar initializer.
 202         (rust_language::printchar): New member function, implementation
 203         from rust_printchar.
 204
 205 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 206
 207         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
 208         (ada_language_data): Delete la_emitchar initializer.
 209         (ada_language::emitchar): New member function, implementation from
 210         emit_char.
 211         * c-lang.c (c_language_data): Delete la_emitchar initializer.
 212         (cplus_language_data): Likewise.
 213         (asm_language_data): Likewise.
 214         (minimal_language_data): Likewise.
 215         * d-lang.c (d_language_data): Likewise.
 216         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
 217         (f_language_data): Delete la_emitchar initializer.
 218         (f_language::emitchar): New member function, implementation from
 219         f_emit_char.
 220         * go-lang.c (go_language_data): Delete la_emitchar initializer.
 221         * language.c (unk_lang_emit_char): Delete.
 222         (language_defn::emitchar): New member function definition.
 223         (unknown_language_data): Delete la_emitchar initializer.
 224         (unknown_language::emitchar): New member function.
 225         (auto_language_data): Delete la_emitchar initializer.
 226         (auto_language::emitchar): New member function.
 227         * language.h (language_data): Delete la_emitchar field.
 228         (language_defn::emitchar): New member field declaration.
 229         (LA_EMIT_CHAR): Update call to emitchar.
 230         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
 231         (m2_language_data): Delete la_emitchar initializer.
 232         (m2_language::emitchar): New member function, implementation from
 233         m2_emit_char.
 234         * objc-lang.c (objc_language_data): Delete la_emitchar
 235         initializer.
 236         * opencl-lang.c (opencl_language_data): Likewise.
 237         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
 238         (pascal_language_data): Delete la_emitchar initializer.
 239         (pascal_language::emitchar): New member function, implementation
 240         from pascal_emit_char.
 241         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
 242         (rust_language_data): Delete la_emitchar initializer.
 243         (rust_language::emitchar): New member function, implementation
 244         from rust_emitchar.
 245
 246 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 247
 248         * ada-lang.c (resolve): Rename to ada_language::post_parser.
 249         (ada_language_data): Delete la_post_parser initializer.
 250         (ada_language::post_parser): New member function.
 251         * c-lang.c (c_language_data): Delete la_post_parser initializer.
 252         (cplus_language_data): Likewise.
 253         (asm_language_data): Likewise.
 254         (minimal_language_data): Likewise.
 255         * d-lang.c (d_language_data): Likewise.
 256         * f-lang.c (f_language_data): Likewise.
 257         * go-lang.c (go_language_data): Likewise.
 258         * language.c (unknown_language_data): Likewise.
 259         (auto_language_data): Likewise.
 260         * language.h (language_data): Delete la_post_parser field.
 261         (language_defn::post_parser): New member function.
 262         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
 263         * objc-lang.c (objc_language_data): Likewise.
 264         * opencl-lang.c (opencl_language_data): Likewise.
 265         * p-lang.c (pascal_language_data): Likewise.
 266         * parse.c (parse_exp_in_context): Update call to post_parser.
 267         (null_post_parser): Delete definition.
 268         * parser-defs.h (null_post_parser): Delete declaration.
 269         * rust-lang.c (rust_language_data): Delete la_post_parser
 270         initializer.
 271
 272 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 273
 274         * ada-lang.c (parse): Rename to ada_language::parser.
 275         (ada_language_data): Delete la_parser initializer.
 276         (ada_language::parser): New member function, implementation from
 277         parse.
 278         * c-lang.c (c_language_data): Delete la_parser initializer.
 279         (cplus_language_data): Likewise.
 280         (asm_language_data): Likewise.
 281         (minimal_language_data): Likewise.
 282         * d-lang.c (d_language_data): Likewise.
 283         (d_language::parser): New member function.
 284         * f-lang.c (f_language_data): Delete la_parser initializer.
 285         (f_language::parser): New member function.
 286         * go-lang.c (go_language_data): Delete la_parser initializer.
 287         (go_language::parser): New member function.
 288         * language.c (unk_lang_parser): Delete.
 289         (language_defn::parser): Define new member function.
 290         (unknown_language_data): Delete la_parser initializer.
 291         (unknown_language::parser): New member function.
 292         (auto_language_data): Delete la_parser initializer.
 293         (auto_language::parser): New member function.
 294         * language.h (language_data): Delete la_parser field.
 295         (language_defn::parser): Declare new member function.
 296         * m2-lang.c (m2_language_data): Delete la_parser initializer.
 297         (m2_language::parser): New member function.
 298         * objc-lang.c (objc_language_data): Delete la_parser initializer.
 299         * opencl-lang.c (opencl_language_data): Likewise.
 300         * p-lang.c (pascal_language_data): Likewise.
 301         (pascal_language::parser): New member function.
 302         * parse.c (parse_exp_in_context): Update call to parser.
 303         * rust-lang.c (rust_language_data): Delete la_parser initializer.
 304         (rust_language::parser): New member function.
 305
 306 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 307
 308         * top.c (print_gdb_configuration): Print --with-python-libdir
 309         configuration value.
 310
 311 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 312
 313         * NEWS: Mention change to the alias command.
 314
 315 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 316
 317         * cli/cli-cmds.c (lookup_cmd_for_default_args)
 318         (alias_command_completer)
 319         (make_alias_options_def_group): New functions.
 320         (alias_opts, alias_option_defs): New struct and array.
 321         (alias_usage_error): Update usage.
 322         (alias_command): Handles optional DEFAULT-ARGS... arguments.
 323         Use option framework.
 324         (_initialize_cli_cmds): Update alias command help.
 325         Update aliases command help.
 326         (show_user):
 327         Add NULL for new default_args lookup_cmd argument.
 328         (valid_command_p): Rename to validate_aliased_command.
 329         Add NULL for new default_args lookup_cmd argument.  Verify that the
 330         aliased_command has no default args.
 331         * cli/cli-decode.c (help_cmd): Show aliases definitions.
 332         (lookup_cmd_1, lookup_cmd): New argument default_args.
 333         (add_alias_cmd):
 334         Add NULL for new default_args lookup_cmd argument.
 335         (print_help_for_command): Show default args under the layout
 336          alias some_alias = some_aliased_cmd some_alias_default_arg.
 337         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
 338         xfree default_args in destructor.
 339         * cli/cli-script.c (process_next_line, do_define_command):
 340         Add NULL for new default_args lookup_cmd argument.
 341         * command.h: Declare new default_args argument in lookup_cmd
 342         and lookup_cmd_1.
 343         * completer.c (complete_line_internal_1):
 344         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 345         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 346         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
 347         Likewise.
 348         * infcmd.c (_initialize_infcmd): Likewise.
 349         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
 350         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 351         * python/py-param.c (add_setshow_generic): Likewise.
 352         * remote.c (_initialize_remote): Likewise.
 353         * top.c (execute_command): Prepend default_args if command has some.
 354         (set_verbose):
 355         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 356         * tracepoint.c (validate_actionline, encode_actions_1):
 357         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 358
 359 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 360
 361         * jit.c (jit_read_descriptor): Use bool as the return type.
 362         (jit_breakpoint_re_set_internal): Use bool as the return type.
 363         Invert the return value logic; return true if the jit breakpoint
 364         has been successfully initialized.
 365         (jit_inferior_init): Update the call to
 366         jit_breakpoint_re_set_internal.
 367
 368 2020-06-22  Pedro Alves  <palves@redhat.com>
 369
 370         PR gdb/25939
 371         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
 372         Use the current inferior instead.  Don't return
 373         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
 374         wait again.
 375         * sol-thread.c (sol_thread_target::wait): Don't reference
 376         inferior_ptid.
 377         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
 378         (sol_update_thread_list_callback): Use the current inferior's pid
 379         instead of inferior_ptid.
 380
 381 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 382
 383         * procfs.c: Cleanup many comments.
 384
 385         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
 386         (AFTER_WATCHFLAG): Replace by value.
 387
 388         (MAIN_PROC_NAME_FORMAT): Inline ...
 389         (create_procinfo): ... here.
 390
 391         (procfs_debug_inferior): Remove SYS_exec handling.
 392         (syscall_is_exec): Likewise.
 393         (procfs_set_exec_trap): Likewise.
 394
 395         (syscall_is_lwp_exit): Inline in callers.
 396         (syscall_is_exit): Likewise.
 397         (syscall_is_exec): Likewise.
 398         (syscall_is_lwp_create): Likewise.
 399
 400         (invalidate_cache): Remove #if 0 code.
 401
 402         (make_signal_thread_runnable):  Remove.
 403         (procfs_target::resume): Remove #if 0 code.
 404
 405 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 406
 407         PR gdb/25939
 408         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
 409         call ...
 410         (procfs_target::create_inferior): ... here.
 411
 412 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 413
 414         * exec.c (validate_exec_file): Ensure the build-id is up to
 415         date by calling reopen_exec_file (that checks file timestamp
 416         to decide to re-read the file).
 417
 418 2020-06-18  Pedro Alves  <palves@redhat.com>
 419
 420         PR gdb/25412
 421         * gdbthread.h (delete_thread, delete_thread_silent)
 422         (find_thread_ptid): Update comments.
 423         * thread.c (current_thread_): New global.
 424         (is_current_thread): Move higher, and reimplement.
 425         (inferior_thread): Reimplement.
 426         (set_thread_exited): Use bool.  Add assertions.
 427         (add_thread_silent): Simplify thread-reuse handling by always
 428         calling delete_thread.
 429         (delete_thread): Remove intro comment.
 430         (find_thread_ptid): Skip exited threads.
 431         (switch_to_thread_no_regs): Write to current_thread_.
 432         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
 433         INFERIOR_PTID.  Clear current_thread_.
 434
 435 2020-06-18  Pedro Alves  <palves@redhat.com>
 436
 437         * aix-thread.c (pd_update): Use switch_to_thread.
 438
 439 2020-06-18  Pedro Alves  <palves@redhat.com>
 440
 441         * ravenscar-thread.c (ravenscar_thread_target): Update.
 442         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
 443         (ravenscar_thread_target::add_active_thread): ... this.  Don't
 444         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
 445         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
 446
 447 2020-06-18  Pedro Alves  <palves@redhat.com>
 448
 449         * nat/windows-nat.c (current_windows_thread): Remove.
 450         * nat/windows-nat.h (current_windows_thread): Remove.
 451         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
 452         Adjust.
 453         (display_selectors): Adjust to fetch the current
 454         windows_thread_info based on inferior_ptid.
 455         (fake_create_process): No longer write to current_windows_thread.
 456         (windows_nat_target::get_windows_debug_event):
 457         Don't set inferior_ptid or current_windows_thread.
 458         (windows_nat_target::wait): Adjust to not rely on
 459         current_windows_thread.
 460         (do_initial_windows_stuff): Now a method of windows_nat_target.
 461         Switch to the last_ptid thread.
 462         (windows_nat_target::attach): Adjust.
 463         (windows_nat_target::detach): Use switch_to_no_thread instead of
 464         writing to inferior_ptid directly.
 465         (windows_nat_target::create_inferior): Adjust.
 466
 467 2020-06-18  Pedro Alves  <palves@redhat.com>
 468
 469         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
 470
 471 2020-06-18  Pedro Alves  <palves@redhat.com>
 472
 473         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
 474         after creating it, instead of writing to inferior_ptid.  Don't
 475         write to inferior_ptid.
 476
 477 2020-06-18  Pedro Alves  <palves@redhat.com>
 478
 479         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
 480
 481 2020-06-18  Pedro Alves  <palves@redhat.com>
 482
 483         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
 484         it, instead of writing to inferior_ptid.
 485
 486 2020-06-18  Pedro Alves  <palves@redhat.com>
 487
 488         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
 489         to inferior_ptid.
 490
 491 2020-06-18  Pedro Alves  <palves@redhat.com>
 492
 493         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
 494         instead of writing to inferior_ptid directly.
 495
 496 2020-06-18  Pedro Alves  <palves@redhat.com>
 497
 498         * corelow.c (core_target::close): Use switch_to_no_thread instead
 499         of writing to inferior_ptid directly.
 500         (add_to_thread_list, core_target_open): Use switch_to_thread
 501         instead of writing to inferior_ptid directly.
 502
 503 2020-06-18  Pedro Alves  <palves@redhat.com>
 504
 505         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
 506         inferior_ptid.
 507         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
 508         inferior_ptid.
 509         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
 510         inferior_ptid directly.
 511         (darwin_nat_target::init_thread_list): Switch to thread, instead
 512         of writing to inferior_ptid.
 513         (darwin_nat_target::attach): Don't write to inferior_ptid.
 514         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
 515
 516 2020-06-18  Pedro Alves  <palves@redhat.com>
 517
 518         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
 519         thread.
 520         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
 521         Instead use switch_to_thread.
 522         (gnu_nat_target::detach): Use switch_to_no_thread
 523         instead of writing to inferior_ptid directly.  Used passed-in
 524         inferior instead of looking up the inferior by pid.
 525
 526 2020-06-18  Pedro Alves  <palves@redhat.com>
 527
 528         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
 529         inferior_ptid.
 530
 531 2020-06-18  Pedro Alves  <palves@redhat.com>
 532
 533         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
 534         inferior_ptid.
 535         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
 536         thread.
 537         (nto_procfs_target::detach): Avoid referencing
 538         inferior_ptid.  Use switch_to_no_thread instead of writing to
 539         inferior_ptid directly.
 540         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
 541         instead of writing to inferior_ptid directly.
 542         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
 543         to thread.
 544
 545 2020-06-18  Pedro Alves  <palves@redhat.com>
 546
 547         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
 548         after creating it, instead of writing to inferior_ptid.
 549         (gdbsim_target_open): Use switch_to_no_thread instead of writing
 550         to inferior_ptid directly.
 551         (gdbsim_target::wait): Don't write to inferior_ptid.
 552
 553 2020-06-18  Pedro Alves  <palves@redhat.com>
 554
 555         * remote.c (remote_target::remote_notice_new_inferior): Use
 556         switch_to_thread instead of writing to inferior_ptid directly.
 557         (remote_target::add_current_inferior_and_thread): Use
 558         switch_to_no_thread instead of writing to inferior_ptid directly.
 559         (extended_remote_target::attach): Use switch_to_inferior_no_thread
 560         and switch_to_thread instead of using set_current_inferior or
 561         writing to inferior_ptid directly.
 562
 563 2020-06-18  Pedro Alves  <palves@redhat.com>
 564
 565         * tracectf.c (ctf_target_open): Switch to added thread instead of
 566         writing to inferior_ptid directly.
 567         (ctf_target::close): Use switch_to_no_thread instead of writing to
 568         inferior_ptid directly.
 569
 570 2020-06-18  Pedro Alves  <palves@redhat.com>
 571
 572         * tracefile-tfile.c (tfile_target_open): Don't write to
 573         inferior_ptid directly, instead switch to added thread.
 574         (tfile_target::close): Use switch_to_no_thread instead of writing
 575         to inferior_ptid directly.
 576
 577 2020-06-18  Pedro Alves  <palves@redhat.com>
 578
 579         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
 580         (procfs_target::detach): Use switch_to_no_thread
 581         instead of writing to inferior_ptid directly.
 582         (do_attach): Change return type to void.  Switch to the added
 583         thread.
 584         (procfs_target::create_inferior): Switch to the added thread.
 585         (procfs_do_thread_registers): Don't write to inferior_ptid.
 586
 587 2020-06-18  Pedro Alves  <palves@redhat.com>
 588
 589         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
 590         of writing to inferior_ptid.
 591         (scoped_restore_exited_inferior): Delete.
 592         (handle_vfork_child_exec_or_exit): Simplify using
 593         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
 594         instead of writing to inferior_ptid.
 595         (THREAD_STOPPED_BY): Delete.
 596         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
 597         (thread_stopped_by_hw_breakpoint): Delete.
 598         (save_waitstatus): Use
 599         scoped_restore_current_thread+switch_to_thread, and call
 600         target_stopped_by_watchpoint instead of
 601         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
 602         instead of thread_stopped_by_sw_breakpoint, and
 603         target_stopped_by_hw_breakpoint instead of
 604         thread_stopped_by_hw_breakpoint.
 605         (handle_inferior_event)
 606         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
 607         inferior_ptid directly, nor
 608         set_current_inferior/set_current_program_space.  Use
 609         switch_to_thread / switch_to_inferior_no_thread instead.
 610
 611 2020-06-18  Pedro Alves  <palves@redhat.com>
 612
 613         * target.c (generic_mourn_inferior): Use switch_to_no_thread
 614         instead of writing to inferior_ptid.
 615
 616 2020-06-18  Pedro Alves  <palves@redhat.com>
 617
 618         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
 619         added thread.
 620         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
 621         to the added thread.
 622         (inf_ptrace_target::detach_success): Use switch_to_no_thread
 623         instead of writing to inferior_ptid.
 624
 625 2020-06-18  Pedro Alves  <palves@redhat.com>
 626
 627         * gdbarch-selftests.c: Include "progspace-and-thread.h".
 628         (register_to_value_test): Mock a program_space too.  Heap-allocate
 629         the address space.  Don't write to inferior_ptid.  Use
 630         switch_to_thread instead.
 631
 632 2020-06-18  Pedro Alves  <palves@redhat.com>
 633
 634         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
 635         Delete.
 636         (find_signalled_thread()): New, factored out from
 637         linux_make_corefile_notes and adjusted to handle exited threads.
 638         (linux_make_corefile_notes): Adjust to use the new
 639         find_signalled_thread.
 640
 641 2020-06-18  Pedro Alves  <palves@redhat.com>
 642
 643         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
 644         of saving/restoring inferior_ptid.
 645
 646 2020-06-17  Tom Tromey  <tom@tromey.com>
 647
 648         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
 649         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
 650         declare.
 651         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
 652
 653 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
 654
 655         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
 656         of partial symtabs.
 657
 658 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 659
 660         * regformats/reg-arm.dat: Remove.
 661         * regformats/reg-bfin.dat: Remove.
 662         * regformats/reg-cris.dat: Remove.
 663         * regformats/reg-crisv32.dat: Remove.
 664         * regformats/reg-m32r.dat: Remove.
 665         * regformats/reg-tilegx.dat: Remove.
 666         * regformats/reg-tilegx32.dat: Remove.
 667
 668 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 669
 670         * features/Makefile (WHICH): Remove arm files.
 671         * regformats/arm/arm-with-iwmmxt.dat: Remove.
 672         * regformats/arm/arm-with-neon.dat: Remove.
 673         * regformats/arm/arm-with-vfpv2.dat: Remove.
 674         * regformats/arm/arm-with-vfpv3.dat: Remove.
 675
 676 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
 677
 678         * features/Makefile (XMLTOC): Remove rx.xml.
 679
 680 2020-06-17  Pedro Alves  <palves@redhat.com>
 681
 682         * gdbthread.h (thread_control_state) <trap_expected> Update
 683         comments.
 684
 685 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 686
 687         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
 688         ada_language::lookup_symbol_nonlocal.
 689         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
 690         (ada_language::lookup_symbol_nonlocal): New member function,
 691         implementation from ada_lookup_symbol_nonlocal.
 692         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
 693         initializer.
 694         (cplus_language_data): Delete la_lookup_symbol_nonlocal
 695         initializer.
 696         (cplus_language::lookup_symbol_nonlocal): New member function.
 697         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
 698         (minimal_language_data) Likewise.
 699         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
 700         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
 701         initializer.
 702         (d_language::lookup_symbol_nonlocal): New member function.
 703         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
 704         initializer.
 705         (f_language::lookup_symbol_nonlocal): New member function.
 706         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
 707         initializer.
 708         * language.c (unknown_language_data): Likewise.
 709         (auto_language_data): Likewise.
 710         * language.h (language_data): Delete la_lookup_symbol_nonlocal
 711         field.
 712         (language_defn::lookup_symbol_nonlocal): New member function.
 713         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
 714         initializer.
 715         * objc-lang.c (objc_language_data): Likewise.
 716         * opencl-lang.c (opencl_language_data): Likewise.
 717         * p-lang.c (pascal_language_data): Likewise.
 718         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
 719         rust_language::lookup_symbol_nonlocal.
 720         (rust_language_data): Delete la_lookup_symbol_nonlocal
 721         initializer.
 722         (rust_language::lookup_symbol_nonlocal): New member function,
 723         implementation from rust_lookup_symbol_nonlocal.
 724         * symtab.c (lookup_symbol_aux): Update call to
 725         lookup_symbol_nonlocal.
 726         (basic_lookup_symbol_nonlocal): Rename to...
 727         (language_defn::lookup_symbol_nonlocal): ...this, and update
 728         header comment.  Remove language_defn parameter, and replace with
 729         uses of `this'.
 730         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
 731
 732 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 733
 734         * ada-lang.c (ada_language_data): Delete la_value_print_inner
 735         initializer.
 736         (ada_language::value_print_inner): New member function.
 737         * c-lang.c (c_language_data): Delete la_value_print_inner
 738         initializer.
 739         (cplus_language_data): Likewise.
 740         (asm_language_data): Likewise.
 741         (minimal_language_data): Likewise.
 742         * d-lang.c (d_language_data): Likewise.
 743         (d_language::value_print_inner): New member function.
 744         * f-lang.c (f_language_data): Delete la_value_print_inner
 745         initializer.
 746         (f_language::value_print_inner): New member function.
 747         * f-lang.h (f_value_print_innner): Rename to...
 748         (f_value_print_inner): ...this (note spelling of 'inner').
 749         * f-valprint.c (f_value_print_innner): Rename to...
 750         (f_value_print_inner): ...this (note spelling of 'inner').
 751         * go-lang.c (go_language_data): Delete la_value_print_inner
 752         initializer.
 753         (go_language::value_print_inner): New member function.
 754         * language.c (language_defn::value_print_inner): Define new member
 755         function.
 756         (unk_lang_value_print_inner): Delete.
 757         (unknown_language_data): Delete la_value_print_inner initializer.
 758         (unknown_language::value_print_inner): New member function.
 759         (auto_language_data): Delete la_value_print_inner initializer.
 760         (auto_language::value_print_inner): New member function.
 761         * language.h (language_data): Delete la_value_print_inner field.
 762         (language_defn::value_print_inner): Delcare new member function.
 763         * m2-lang.c (m2_language_data): Delete la_value_print_inner
 764         initializer.
 765         (m2_language::value_print_inner): New member function.
 766         * objc-lang.c (objc_language_data): Delete la_value_print_inner
 767         initializer.
 768         * opencl-lang.c (opencl_language_data): Likewise.
 769         * p-lang.c (pascal_language_data): Likewise.
 770         (pascal_language::value_print_inner): New member function.
 771         * rust-lang.c (rust_language_data): Delete la_value_print_inner
 772         initializer.
 773         (rust_language::value_print_inner): New member function.
 774         * valprint.c (do_val_print): Update call to value_print_inner.
 775
 776 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * ada-lang.c (ada_language_data): Delete la_value_print
 779         initializer.
 780         (ada_language::value_print): New member function.
 781         * c-lang.c (c_language_data): Delete la_value_print initializer.
 782         (cplus_language_data): Likewise.
 783         (asm_language_data): Likewise.
 784         (minimal_language_data): Likewise.
 785         * d-lang.c (d_language_data): Likewise.
 786         * f-lang.c (f_language_data): Likewise.
 787         * go-lang.c (go_language_data): Likewise.
 788         * language.c (unk_lang_value_print): Delete.
 789         (language_defn::value_print): Define new member function.
 790         (unknown_language_data): Delete la_value_print initializer.
 791         (unknown_language::value_print): New member function.
 792         (auto_language_data): Delete la_value_print initializer.
 793         (auto_language::value_print): New member function.
 794         * language.h (language_data): Delete la_value_print field.
 795         (language_defn::value_print): Declare new member function.
 796         (LA_VALUE_PRINT): Update call to value_print.
 797         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
 798         * objc-lang.c (objc_language_data): Likewise.
 799         * opencl-lang.c (opencl_language_data): Likewise.
 800         * p-lang.c (pascal_language_data): Likewise.
 801         (pascal_language::value_print): New member function.
 802         * rust-lang.c (rust_language_data): Delete la_value_print
 803         initializer.
 804
 805 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * ada-lang.c (ada_watch_location_expression): Rename to
 808         ada_language::watch_location_expression.
 809         (ada_language_data): Delete la_watch_location_expression
 810         initializer.
 811         (ada_language::watch_location_expression): New member function,
 812         implementation from ada_watch_location_expression.
 813         * breakpoint.c (watch_command_1): Update call to
 814         watch_location_expression.
 815         * c-lang.c (c_watch_location_expression): Rename to
 816         language_defn::watch_location_expression.
 817         (c_language_data): Delete la_watch_location_expression
 818         initializer.
 819         (cplus_language_data): Likewise.
 820         (asm_language_data): Likewise.
 821         (minimal_language_data): Likewise.
 822         * c-lang.h (c_watch_location_expression): Delete declaration.
 823         * d-lang.c (d_language_data): Delete la_watch_location_expression
 824         initializer.
 825         * f-lang.c (f_language_data): Likewise.
 826         * go-lang.c (go_language_data): Likewise.
 827         * language.c (language_defn::watch_location_expression): Member
 828         function implementation from c_watch_location_expression.
 829         (unknown_language_data): Delete la_watch_location_expression
 830         initializer.
 831         (auto_language_data): Likewise.
 832         * language.h (language_data): Delete la_watch_location_expression
 833         field.
 834         (language_defn::watch_location_expression): Declare new member
 835         function.
 836         * m2-lang.c (m2_language_data): Delete
 837         la_watch_location_expression initializer.
 838         * objc-lang.c (objc_language_data): Likewise.
 839         * opencl-lang.c (opencl_language_data): Likewise.
 840         * p-lang.c (pascal_language_data): Likewise.
 841         * rust-lang.c (rust_watch_location_expression): Rename to
 842         rust_language::watch_location_expression.
 843         (rust_language_data): Delete la_watch_location_expression
 844         initializer.
 845         (rust_language::watch_location_expression): New member function,
 846         implementation from rust_watch_location_expression.
 847
 848 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 849
 850         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
 851         ada_language::collect_symbol_completion_matches.
 852         (ada_language_data): Delete la_collect_symbol_completion_matches
 853         initializer.
 854         (ada_language::collect_symbol_completion_matches): New member
 855         function, implementation from
 856         ada_collect_symbol_completion_matches.
 857         * c-lang.c (c_language_data): Delete
 858         la_collect_symbol_completion_matches initializer.
 859         (cplus_language_data): Likewise.
 860         (asm_language_data): Likewise.
 861         (minimal_language_data): Likewise.
 862         * d-lang.c (d_language_data): Likewise.
 863         * f-lang.c (f_collect_symbol_completion_matches): Rename to
 864         f_language::collect_symbol_completion_matches.
 865         (f_language_data): Delete la_collect_symbol_completion_matches
 866         initializer.
 867         (f_language::collect_symbol_completion_matches) New member
 868         function, implementation from f_collect_symbol_completion_matches.
 869         * go-lang.c (go_language_data): Delete
 870         la_collect_symbol_completion_matches initializer.
 871         * language.c (unknown_language_data): Likewise.
 872         (auto_language_data): Likewise.
 873         * language.h (language_data): Delete
 874         la_collect_symbol_completion_matches field.
 875         (language_defn::collect_symbol_completion_matches): New member
 876         function.
 877         * m2-lang.c (m2_language_data): Delete
 878         la_collect_symbol_completion_matches initializer.
 879         * objc-lang.c (objc_language_data): Likewise.
 880         * opencl-lang.c (opencl_language_data): Likewise.
 881         * p-lang.c (pascal_language_data): Likewise.
 882         * rust-lang.c (rust_language_data): Likewise.
 883         * symtab.c (default_collect_symbol_completion_matches): Delete.
 884         (collect_symbol_completion_matches): Update call to
 885         collect_symbol_completion_matches.
 886         (collect_symbol_completion_matches_type): Likewise.
 887         * symtab.h (default_collect_symbol_completion_matches): Delete
 888         declaration.
 889
 890 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 891
 892         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
 893         (ada_language_data): Delete la_word_break_characters initializer.
 894         (ada_language::word_break_characters): New member function.
 895         * c-lang.c (c_language_data): Delete la_word_break_characters
 896         initializer.
 897         (cplus_language_data): Likewise.
 898         (asm_language_data): Likewise.
 899         (minimal_language_data): Likewise.
 900         * completer.c: Update global comment.
 901         (advance_to_expression_complete_word_point): Update call to
 902         word_break_characters.
 903         (complete_files_symbols): Likewise.
 904         (complete_line_internal_1): Likewise.
 905         (default_completer_handle_brkchars): Likewise.
 906         (skip_quoted_chars): Likewise.
 907         * d-lang.c (d_language_data): Delete la_word_break_characters
 908         initializer.
 909         * f-lang.c (f_word_break_characters): Delete.
 910         (f_language_data): Delete la_word_break_characters initializer.
 911         (f_language::word_break_characters): New member function.
 912         * go-lang.c (go_language_data): Delete la_word_break_characters
 913         initializer.
 914         * language.c (unknown_language_data): Likewise.
 915         (auto_language_data): Likewise.
 916         * language.h (default_word_break_characters): Move declaration to
 917         earlier in the file.
 918         (language_data): Delete la_word_break_characters field.
 919         (language_defn::word_break_characters): New member function.
 920         * m2-lang.c (m2_language_data): Delete la_word_break_characters
 921         initializer.
 922         * objc-lang.c (objc_language_data): Likewise.
 923         * opencl-lang.c (opencl_language_data): Likewise.
 924         * p-lang.c (pascal_language_data): Likewise.
 925         * rust-lang.c (rust_language_data): Likewise.
 926
 927 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
 930         (ada_language_data): Delete la_get_symbol_name_matcher
 931         initializer.
 932         (language_defn::get_symbol_name_matcher_inner): New member
 933         function.
 934         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
 935         initializer.
 936         (cplus_language_data): Likewise.
 937         (cplus_language::get_symbol_name_matcher_inner): New member
 938         function.
 939         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
 940         (minimal_language_data): Likewise.
 941         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
 942         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
 943         initializer.
 944         * dictionary.c (iter_match_first_hashed): Update call to
 945         get_symbol_name_matcher.
 946         (iter_match_next_hashed): Likewise.
 947         (iter_match_next_linear): Likewise.
 948         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
 949         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
 950         initializer.
 951         (f_language::get_symbol_name_matcher_inner): New member function.
 952         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
 953         initializer.
 954         * language.c (default_symbol_name_matcher): Update header comment,
 955         make static.
 956         (language_defn::get_symbol_name_matcher): New definition.
 957         (language_defn::get_symbol_name_matcher_inner): Likewise.
 958         (get_symbol_name_matcher): Delete.
 959         (unknown_language_data): Delete la_get_symbol_name_matcher
 960         initializer.
 961         (auto_language_data): Likewise.
 962         * language.h (language_data): Delete la_get_symbol_name_matcher
 963         field.
 964         (language_defn::get_symbol_name_matcher): New member function.
 965         (language_defn::get_symbol_name_matcher_inner): Likewise.
 966         (default_symbol_name_matcher): Delete declaration.
 967         * linespec.c (find_methods): Update call to
 968         get_symbol_name_matcher.
 969         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
 970         initializer.
 971         * minsyms.c (lookup_minimal_symbol): Update call to
 972         get_symbol_name_matcher.
 973         (iterate_over_minimal_symbols): Likewise.
 974         * objc-lang.c (objc_language_data): Delete
 975         la_get_symbol_name_matcher initializer.
 976         * opencl-lang.c (opencl_language_data): Likewise.
 977         * p-lang.c (pascal_language_data): Likewise.
 978         * psymtab.c (psymbol_name_matches): Update call to
 979         get_symbol_name_matcher.
 980         * rust-lang.c (rust_language_data): Delete
 981         la_get_symbol_name_matcher initializer.
 982         * symtab.c (symbol_matches_search_name): Update call to
 983         get_symbol_name_matcher.
 984         (compare_symbol_name): Likewise.
 985
 986 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 987
 988         * ada-lang.c (ada_language_data): Delete la_compute_program
 989         initializer.
 990         * c-lang.c (c_language_data): Likewise.
 991         (c_language::compute_program): New member function.
 992         (cplus_language_data): Delete la_compute_program initializer.
 993         (cplus_language::compute_program): New member function.
 994         (asm_language_data): Delete la_compute_program initializer.
 995         (minimal_language_data): Likewise.
 996         * c-lang.h (c_compute_program): Update comment.
 997         (cplus_compute_program): Likewise.
 998         * compile/compile-c-support.c (c_compute_program): Likewise.
 999         (cplus_compute_program): Likewise.
1000         * compile/compile.c (compile_to_object): Update call to
1001         la_compute_program.
1002         * d-lang.c (d_language_data): Delete la_compute_program
1003         initializer.
1004         * f-lang.c (f_language_data): Likewise.
1005         * go-lang.c (go_language_data): Likewise.
1006         * language.c (unknown_language_data): Likewise.
1007         (auto_language_data): Likewise.
1008         * language.h (language_data): Delete la_compute_program field.
1009         (language_defn::compute_program): New member function.
1010         * m2-lang.c (m2_language_data): Delete la_compute_program
1011         initializer.
1012         * objc-lang.c (objc_language_data): Likewise.
1013         * opencl-lang.c (opencl_language_data): Likewise.
1014         * p-lang.c (pascal_language_data): Likewise.
1015         * rust-lang.c (rust_language_data): Likewise.
1016
1017 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * ada-lang.c (ada_language_data) Delete
1020         la_class_name_from_physname initializer.
1021         * c-lang.c (c_language_data): Likewise.
1022         (cplus_language_data): Likewise.
1023         (cplus_language::class_name_from_physname): New member function.
1024         (asm_language_data): Delete la_class_name_from_physname
1025         initializer.
1026         (minimal_language_data): Likewise.
1027         * d-lang.c (d_language_data): Likewise.
1028         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
1029         method on language_defn class.
1030         (guess_full_die_structure_name): Likewise.
1031         * f-lang.c (f_language_data): Delete la_class_name_from_physname
1032         initializer.
1033         * go-lang.c (go_language_data): Likewise.
1034         * language.c (language_class_name_from_physname): Delete.
1035         (unk_lang_class_name): Delete.
1036         (unknown_language_data): Delete la_class_name_from_physname
1037         initializer.
1038         (auto_language_data): Likewise.
1039         * language.h (language_data): Delete la_class_name_from_physname
1040         field.
1041         (language_defn::class_name_from_physname): New function.
1042         (language_class_name_from_physname): Delete declaration.
1043         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
1044         initializer.
1045         * objc-lang.c (objc_language_data): Likewise.
1046         * opencl-lang.c (opencl_language_data): Likewise.
1047         * p-lang.c (pascal_language_data): Likewise.
1048         * rust-lang.c (rust_language_data): Likewise.
1049
1050 2020-06-16  Tom Tromey  <tom@tromey.com>
1051
1052         * tui/tui-data.h (STATUS_NAME): New macro.
1053         * tui/tui-layout.c (tui_remove_some_windows)
1054         (initialize_known_windows, tui_register_window)
1055         (tui_layout_split::remove_windows, initialize_layouts)
1056         (tui_new_layout_command): Don't use hard-coded window names.
1057
1058 2020-06-16  Tom Tromey  <tom@tromey.com>
1059
1060         PR tui/25348:
1061         * tui/tui.c (tui_ensure_readline_initialized): Rename from
1062         tui_initialize_readline.  Only run once.  Call rl_initialize.
1063         * tui/tui.h (tui_ensure_readline_initialized): Rename from
1064         tui_initialize_readline.
1065         * tui/tui-io.c (tui_setup_io): Call
1066         tui_ensure_readline_initialized.
1067         * tui/tui-interp.c (tui_interp::init): Update.
1068
1069 2020-06-16  Tom Tromey  <tom@tromey.com>
1070
1071         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
1072         Also preserve the status window.
1073
1074 2020-06-16  Tom Tromey  <tom@tromey.com>
1075
1076         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
1077         where m_window==nullptr.
1078
1079 2020-06-15  Tom Tromey  <tromey@adacore.com>
1080
1081         * windows-nat.c (windows_nat::handle_output_debug_string):
1082         Update.
1083         (windows_nat::handle_ms_vc_exception): Update.
1084         * target.h (target_read_string): Change API.
1085         * target.c (target_read_string): Change API.
1086         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1087         Update.
1088         * solib-frv.c (frv_current_sos): Update.
1089         * solib-dsbt.c (dsbt_current_sos): Update.
1090         * solib-darwin.c (darwin_current_sos): Update.
1091         * linux-thread-db.c (inferior_has_bug): Update.
1092         * expprint.c (print_subexp_standard): Update.
1093         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
1094         (ada_exception_message_1): Update.
1095
1096 2020-06-15  Tom Tromey  <tromey@adacore.com>
1097
1098         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
1099
1100 2020-06-15  Tom Tromey  <tromey@adacore.com>
1101
1102         * valprint.c (read_string): Update comment.
1103         * target.c (MIN): Remove.
1104         (target_read_string): Rewrite.
1105
1106 2020-06-15  Tom Tromey  <tromey@adacore.com>
1107
1108         * corefile.c (read_memory_string): Remove.
1109         * ada-valprint.c (ada_value_print_ptr): Update.
1110         * ada-lang.h (ada_tag_name): Change return type.
1111         * ada-lang.c (type_from_tag): Update.
1112         (ada_tag_name_from_tsd): Change return type.  Use
1113         target_read_string.
1114         (ada_tag_name): Likewise.
1115         * gdbcore.h (read_memory_string): Don't declare.
1116
1117 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
1118
1119         * symtab.c (rbreak_command): Ignore Windows drive colon.
1120
1121 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
1122
1123         * NEWS: Mention removed GDBserver host support.
1124
1125 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
1126
1127         * features/riscv/rebuild-csr-xml.sh: Updated.
1128
1129 2020-06-11  Tom Tromey  <tom@tromey.com>
1130
1131         PR gdb/18318:
1132         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
1133
1134 2020-06-09  Jonny Grant  <jg@jguk.org>
1135 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
1136
1137         * main.c (captured_main_1): Don't print new line after help.
1138         (print_gdb_help): add mailing list and IRC channel information
1139         to --help.  Add new lines between items in the footer.  Remove
1140         quotes around bug url.
1141
1142 2020-06-11  Keith Seitz  <keiths@redhat.com>
1143
1144         PR gdb/21356
1145         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
1146         Resolve typedefs for type length calculations.
1147
1148 2020-06-10  Tom de Vries  <tdevries@suse.de>
1149
1150         PR ada/24713
1151         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
1152         (write_psymbols): Enable .gdb_index for ada.
1153         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
1154         ada.
1155
1156 2020-06-10  Tom de Vries  <tdevries@suse.de>
1157
1158         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
1159         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
1160         namei" instead of "const char *name" argument.
1161         (dw2_map_matching_symbols): Use "offset_type namei" variant of
1162         dw2_symtab_iter_init.
1163
1164 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1165
1166         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
1167         to use type::field and field::type instead.
1168
1169 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1170
1171         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
1172         to use field::type instead.
1173
1174 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1175
1176         * gdbtypes.h (struct field) <type, set_type>: New methods.
1177         Rename `type` field to...
1178         <m_type>: ... this.  Change references throughout to use type or
1179         set_type methods.
1180         (FIELD_TYPE): Use field::type.  Change call sites that modify
1181         the field's type to use field::set_type instead.
1182
1183 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1184
1185         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
1186         to use type::index_type instead.
1187
1188 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1189
1190         * gdbtypes.h (struct type) <index_type, set_index_type>: New
1191         methods.
1192         (TYPE_INDEX_TYPE): Use type::index_type.
1193         * gdbtypes.c (create_array_type_with_stride): Likewise.
1194
1195 2020-06-07  Tom Tromey  <tom@tromey.com>
1196
1197         * valprint.c (generic_val_print_float): Remove "embedded_offset"
1198         parameter.
1199         (generic_value_print): Update.
1200
1201 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1202
1203         Revert commit 982a38f60b0.
1204         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
1205
1206 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1207
1208         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
1209         avoid use after free.
1210
1211 2020-06-05  Tom de Vries  <tdevries@suse.de>
1212
1213         * NEWS: Fix typos.
1214
1215 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
1216
1217         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
1218         the per_bfd object.
1219         (dwarf2_read_debug_names): Likewise.
1220         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
1221         object when re-using a per_bfd object with an index.
1222
1223 2020-06-03  Tom de Vries  <tdevries@suse.de>
1224
1225         PR symtab/26046
1226         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
1227         children for C++.
1228         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
1229         DW_TAG_subprogram.
1230
1231 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1232
1233         * ada-lang.c (ada_language_data): Delete skip_trampoline
1234         initializer.
1235         * c-lang.c (c_language_data): Likewise.
1236         (cplus_language_data): Likewise.
1237         (cplus_language::skip_trampoline): New member function.
1238         (asm_language_data): Delete skip_trampoline initializer.
1239         (minimal_language_data): Likewise.
1240         * d-lang.c (d_language_data): Likewise.
1241         * f-lang.c (f_language_data): Likewise.
1242         * go-lang.c (go_language_data): Likewise.
1243         * language.c (unk_lang_trampoline): Delete function.
1244         (skip_language_trampoline): Update.
1245         (unknown_language_data): Delete skip_trampoline initializer.
1246         (auto_language_data): Likewise.
1247         * language.h (language_data): Delete skip_trampoline field.
1248         (language_defn::skip_trampoline): New function.
1249         * m2-lang.c (m2_language_data): Delete skip_trampoline
1250         initializer.
1251         * objc-lang.c (objc_skip_trampoline): Delete function, move
1252         implementation to objc_language::skip_trampoline.
1253         (objc_language_data): Delete skip_trampoline initializer.
1254         (objc_language::skip_trampoline): New member function with
1255         implementation from objc_skip_trampoline.
1256         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
1257         initializer.
1258         * p-lang.c (pascal_language_data): Likewise.
1259         * rust-lang.c (rust_language_data): Likewise.
1260
1261 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
1264         (ada_language::demangle): New member function.
1265         * c-lang.c (c_language_data): Delete la_demangle initializer.
1266         (cplus_language_data): Delete la_demangle initializer.
1267         (cplus_language::demangle): New member function.
1268         (asm_language_data): Delete la_demangle initializer.
1269         (minimal_language_data): Delete la_demangle initializer.
1270         * d-lang.c (d_language_data): Delete la_demangle initializer.
1271         (d_language::demangle): New member function.
1272         * f-lang.c (f_language_data): Delete la_demangle initializer.
1273         (f_language::demangle): New member function.
1274         * go-lang.c (go_language_data): Delete la_demangle initializer.
1275         (go_language::demangle): New member function.
1276         * language.c (language_demangle): Update.
1277         (unk_lang_demangle): Delete.
1278         (unknown_language_data): Delete la_demangle initializer.
1279         (unknown_language::demangle): New member function.
1280         (auto_language_data): Delete la_demangle initializer.
1281         (auto_language::demangle): New member function.
1282         * language.h (language_data): Delete la_demangle field.
1283         (language_defn::demangle): New function.
1284         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
1285         * objc-lang.c (objc_language_data): Delete la_demangle
1286         initializer.
1287         (objc_language::demangle): New member function.
1288         * opencl-lang.c (opencl_language_data): Delete la_demangle
1289         initializer.
1290         * p-lang.c (pascal_language_data): Likewise.
1291         * rust-lang.c (rust_language_data): Likewise.
1292         (rust_language::demangle): New member function.
1293
1294 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1295
1296         * ada-lang.c (ada_language_data): Delete la_print_type
1297         initializer.
1298         (ada_language::print_type): New member function.
1299         * c-lang.c (c_language_data): Delete la_print_type initializer.
1300         (c_language::print_type): New member function.
1301         (cplus_language_data): Delete la_print_type initializer.
1302         (cplus_language::print_type): New member function.
1303         (asm_language_data): Delete la_print_type initializer.
1304         (asm_language::print_type): New member function.
1305         (minimal_language_data): Delete la_print_type initializer.
1306         (minimal_language::print_type): New member function.
1307         * d-lang.c (d_language_data): Delete la_print_type initializer.
1308         (d_language::print_type): New member function.
1309         * f-lang.c (f_language_data): Delete la_print_type initializer.
1310         (f_language::print_type): New member function.
1311         * go-lang.c (go_language_data): Delete la_print_type initializer.
1312         (go_language::print_type): New member function.
1313         * language.c (unk_lang_print_type): Delete.
1314         (unknown_language_data): Delete la_print_type initializer.
1315         (unknown_language::print_type): New member function.
1316         (auto_language_data): Delete la_print_type initializer.
1317         (auto_language::print_type): New member function.
1318         * language.h (language_data): Delete la_print_type field.
1319         (language_defn::print_type): New function.
1320         (LA_PRINT_TYPE): Update.
1321         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
1322         (m2_language::print_type): New member function.
1323         * objc-lang.c (objc_language_data): Delete la_print_type
1324         initializer.
1325         (objc_language::print_type): New member function.
1326         * opencl-lang.c (opencl_print_type): Delete, implementation moved
1327         to opencl_language::print_type.
1328         (opencl_language_data): Delete la_print_type initializer.
1329         (opencl_language::print_type): New member function, implementation
1330         from opencl_print_type.
1331         * p-lang.c (pascal_language_data): Delete la_print_type
1332         initializer.
1333         (pascal_language::print_type): New member function.
1334         * rust-lang.c (rust_print_type): Delete, implementation moved to
1335         rust_language::print_type.
1336         (rust_language_data): Delete la_print_type initializer.
1337         (rust_language::print_type): New member function, implementation
1338         from rust_print_type.
1339
1340 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1341
1342         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
1343         implementation moves to...
1344         (ada_language::sniff_from_mangled_name): ...here.  Update return
1345         type.
1346         (ada_language_data): Delete la_sniff_from_mangled_name
1347         initializer.
1348         * c-lang.c (c_language_data): Likewise.
1349         (cplus_language_data): Likewise.
1350         (cplus_language::sniff_from_mangled_name): New member function,
1351         implementation taken from gdb_sniff_from_mangled_name.
1352         (asm_language_data): Delete la_sniff_from_mangled_name
1353         initializer.
1354         (minimal_language_data): Likewise.
1355         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
1356         implementation moves to cplus_language::sniff_from_mangled_name.
1357         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
1358         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
1359         moves to...
1360         (d_language::sniff_from_mangled_name): ...here.
1361         (d_language_data): Delete la_sniff_from_mangled_name initializer.
1362         * f-lang.c (f_language_data): Likewise.
1363         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
1364         moves to...
1365         (go_language::sniff_from_mangled_name): ...here.
1366         (go_language_data): Delete la_sniff_from_mangled_name initializer.
1367         * language.c (language_sniff_from_mangled_name): Delete.
1368         (unknown_language_data): Delete la_sniff_from_mangled_name
1369         initializer.
1370         (auto_language_data): Likewise.
1371         * language.h (language_data): Delete la_sniff_from_mangled_name
1372         field.
1373         (language_defn::sniff_from_mangled_name): New function.
1374         (language_sniff_from_mangled_name): Delete declaration.
1375         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
1376         field.
1377         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
1378         implementation moves to...
1379         (objc_language::sniff_from_mangled_name): ...here.
1380         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
1381         * opencl-lang.c (opencl_language_data): Likewise.
1382         * p-lang.c (pascal_language_data): Likewise.
1383         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
1384         implementation moves to...
1385         (rust_language::sniff_from_mangled_name): ...here.
1386         (rust_language_data): Delete la_sniff_from_mangled_name
1387         initializer.
1388         * symtab.c (symbol_find_demangled_name): Call
1389         sniff_from_mangled_name member function.
1390
1391 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1392
1393         * ada-lang.c (ada_language_data): Delete la_search_name_hash
1394         initializer.
1395         * c-lang.c (c_language_data): Likewise.
1396         (cplus_language_data): Likewise.
1397         (cplus_language::search_name_hash): New member function.
1398         (asm_language_data): Delete la_search_name_hash initializer.
1399         (minimal_language_data): Likewise.
1400         * d-lang.c (d_language_data): Likewise.
1401         * dictionary.c (default_search_name_hash): Rename to...
1402         (language_defn::search_name_hash): ...this.
1403         * f-lang.c (f_language_data): Likewise.
1404         (f_language::search_name_hash): New member function.
1405         * go-lang.c (go_language_data): Delete la_search_name_hash
1406         initializer.
1407         * language.c (unknown_language_data): Likewise.
1408         (auto_language_data): Likewise.
1409         * language.h (struct language_data): Delete la_search_name_hash
1410         field.
1411         (language_defn::search_name_hash): Declare new member function.
1412         (default_search_name_hash): Delete declaration.
1413         * m2-lang.c (m2_language_data): Delete la_search_name_hash
1414         initializer.
1415         * objc-lang.c (objc_language_data): Likewise.
1416         * opencl-lang.c (opencl_language_data): Likewise.
1417         * p-lang.c (pascal_language_data): Likewise.
1418         * rust-lang.c (rust_language_data): Likewise.
1419         * symtab.c (search_name_hash): Update call.
1420
1421 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1422
1423         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
1424         initializer.
1425         * c-lang.c (class compile_instance): Declare.
1426         (c_language_data): Delete la_get_compile_instance initializer.
1427         (c_language::get_compile_instance): New member function.
1428         (cplus_language_data): Delete la_get_compile_instance initializer.
1429         (cplus_language::get_compile_instance): New member function.
1430         (asm_language_data): Delete la_get_compile_instance initializer.
1431         (minimal_language_data): Likewise.
1432         * c-lang.h (c_get_compile_context): Update comment.
1433         (cplus_get_compile_context): Update comment.
1434         * compile/compile.c (compile_to_object): Update calls, don't rely
1435         on function pointer being NULL.
1436         * d-lang.c (d_language_data): Delete la_get_compile_instance
1437         initializer.
1438         * f-lang.c (f_language_data): Likewise.
1439         * go-lang.c (go_language_data): Likewise.
1440         * language.c (unknown_language_data): Likewise.
1441         (auto_language_data): Likewise.
1442         * language.h (language_data): Delete la_get_compile_instance field.
1443         (language_defn::get_compile_instance): New member function.
1444         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
1445         initializer.
1446         * objc-lang.c (objc_language_data): Likewise.
1447         * opencl-lang.c (opencl_language_data): Likewise.
1448         * p-lang.c (pascal_language_data): Likewise.
1449         * rust-lang.c (rust_language_data): Likewise.
1450
1451 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1452
1453         * ada-lang.c (ada_add_all_symbols): Update comment.
1454         (ada_iterate_over_symbols): Delete, move implementation to...
1455         (ada_language::iterate_over_symbols): ...here, a new member
1456         function, rewrite to use range based for loop.
1457         (ada_language_data): Delete la_iterate_over_symbols initializer.
1458         * c-lang.c (c_language_data): Likewise.
1459         (cplus_language_data): Likewise.
1460         (asm_language_data): Likewise.
1461         (minimal_language_data): Likewise.
1462         * d-lang.c (d_language_data): Likewise.
1463         * f-lang.c (f_language_data): Likewise.
1464         * go-lang.c (go_language_data): Likewise.
1465         * language.c (unknown_language_data): Likewise.
1466         (auto_language_data): Likewise.
1467         * language.h (language_data): Delete la_iterate_over_symbols field.
1468         (language_defn::iterate_over_symbols): New member function.
1469         (LA_ITERATE_OVER_SYMBOLS): Update.
1470         * linespec.c (iterate_over_all_matching_symtabs): Update.
1471         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
1472         initializer.
1473         * objc-lang.c (objc_language_data): Likewise.
1474         * opencl-lang.c (opencl_language_data): Likewise.
1475         * p-lang.c (pascal_language_data): Likewise.
1476         * rust-lang.c (rust_language_data): Likewise.
1477
1478 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1479
1480         * ada-lang.c (ada_language_data): Delete
1481         la_lookup_transparent_type initializer.
1482         * c-lang.c (c_language_data): Likewise.
1483         (cplus_language_data): Likewise.
1484         (cplus_language::lookup_transparent_type): New member function.
1485         (asm_language_data): Delete la_lookup_transparent_type
1486         initializer.
1487         (minimal_language_data): Likewise.
1488         * d-lang.c (d_language_data): Likewise.
1489         * f-lang.c (f_language_data): Likewise.
1490         * go-lang.c (go_language_data): Likewise.
1491         * language.c (unknown_language_data): Likewise.
1492         (auto_language_data): Likewise.
1493         * language.h (struct language_data): Delete
1494         la_lookup_transparent_type field.
1495         (language_defn::lookup_transparent_type): New member function.
1496         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
1497         initializer.
1498         * objc-lang.c (objc_language_data): Likewise.
1499         * opencl-lang.c (opencl_language_data): Likewise.
1500         * p-lang.c (pascal_language_data): Likewise.
1501         * rust-lang.c (rust_language_data): Likewise.
1502         * symtab.c (symbol_matches_domain): Update call.
1503
1504 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1505
1506         * ada-lang.c (ada_language_arch_info): Delete function, move
1507         implementation to...
1508         (ada_language::language_arch_info): ...here, a new member
1509         function.
1510         (ada_language_data): Delete la_language_arch_info.
1511         * c-lang.c (c_language_data): Likewise.
1512         (c_language::language_arch_info): New member function.
1513         (cplus_language_arch_info): Delete function, move
1514         implementation to...
1515         (cplus_language::language_arch_info): ...here, a new member
1516         function.
1517         (cplus_language_data): Delete la_language_arch_info.
1518         (asm_language_data): Likewise.
1519         (asm_language::language_arch_info): New member function.
1520         (minimal_language_data): Delete la_language_arch_info.
1521         (minimal_language::language_arch_info): New member function.
1522         * d-lang.c (d_language_arch_info): Delete function, move
1523         implementation to...
1524         (d_language::language_arch_info): ...here, a new member
1525         function.
1526         (d_language_data): Delete la_language_arch_info.
1527         * f-lang.c (f_language_arch_info): Delete function, move
1528         implementation to...
1529         (f_language::language_arch_info): ...here, a new member
1530         function.
1531         (f_language_data): Delete la_language_arch_info.
1532         * go-lang.c (go_language_arch_info): Delete function, move
1533         implementation to...
1534         (go_language::language_arch_info): ...here, a new member
1535         function.
1536         (go_language_data): Delete la_language_arch_info.
1537         * language.c (unknown_language_data): Likewise.
1538         (unknown_language::language_arch_info): New member function.
1539         (auto_language_data): Delete la_language_arch_info.
1540         (auto_language::language_arch_info): New member function.
1541         (language_gdbarch_post_init): Update call to
1542         la_language_arch_info.
1543         * language.h (language_data): Delete la_language_arch_info
1544         function pointer.
1545         (language_defn::language_arch_info): New function.
1546         * m2-lang.c (m2_language_arch_info): Delete function, move
1547         implementation to...
1548         (m2_language::language_arch_info): ...here, a new member
1549         function.
1550         (m2_language_data): Delete la_language_arch_info.
1551         * objc-lang.c (objc_language_arch_info): Delete function, move
1552         implementation to...
1553         (objc_language::language_arch_info): ...here, a new member
1554         function.
1555         (objc_language_data): Delete la_language_arch_info.
1556         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1557         implementation to...
1558         (opencl_language::language_arch_info): ...here, a new member
1559         function.
1560         (opencl_language_data): Delete la_language_arch_info.
1561         * p-lang.c (pascal_language_arch_info): Delete function, move
1562         implementation to...
1563         (pascal_language::language_arch_info): ...here, a new member
1564         function.
1565         (pascal_language_data): Delete la_language_arch_info.
1566         * rust-lang.c (rust_language_arch_info): Delete function, move
1567         implementation to...
1568         (rust_language::language_arch_info): ...here, a new member
1569         function.
1570         (rust_language_data): Delete la_language_arch_info.
1571
1572 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1573
1574         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
1575         initializer.
1576         * c-lang.c (c_language_data): Likewise.
1577         (cplus_language_data): Likewise.
1578         (cplus_language::pass_by_reference_info): New method.
1579         (asm_language_data): Delete la_pass_by_reference initializer.
1580         (minimal_language_data): Likewise.
1581         * cp-abi.c (cp_pass_by_reference): Remove use of
1582         default_pass_by_reference.
1583         * d-lang.c (d_language_data): Likewise.
1584         * f-lang.c (f_language_data): Likewise.
1585         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
1586         default_pass_by_reference.
1587         * go-lang.c (go_language_data): Likewise.
1588         * language.c (language_pass_by_reference): Update.
1589         (default_pass_by_reference): Delete.
1590         (unknown_language_data): Delete la_pass_by_reference
1591         initializer.
1592         (auto_language_data): Likewise.
1593         * language.h (struct language_data): Delete la_pass_by_reference
1594         field.
1595         (language_defn::pass_by_reference_info): New member function.
1596         (default_pass_by_reference): Delete declaration.
1597         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
1598         initializer.
1599         * objc-lang.c (objc_language_data): Likewise.
1600         * opencl-lang.c (opencl_language_data): Likewise.
1601         * p-lang.c (pascal_language_data): Likewise.
1602         * rust-lang.c (rust_language_data): Likewise.
1603
1604 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1605
1606         * ada-lang.c (ada_read_var_value): Delete function, move
1607         implementation to...
1608         (ada_language::read_var_value): ...here.
1609         (ada_language_data): Delete la_read_var_value initializer.
1610         * c-lang.c (c_language_data): Likewise.
1611         (cplus_language_data): Likewise.
1612         (minimal_language_data): Likewise.
1613         * d-lang.c (d_language_data): Likewise.
1614         * f-lang.c (f_language_data): Likewise.
1615         * findvar.c (default_read_var_value): Rename to...
1616         (language_defn::read_var_value): ...this.
1617         * findvar.c (read_var_value): Update header comment, and change to
1618         call member function instead of function pointer.
1619         * go-lang.c (go_language_data): Likewise.
1620         * language.c (unknown_language_data): Delete la_read_var_value
1621         initializer.
1622         (auto_language_data): Likewise.
1623         * language.h (struct language_data): Delete la_read_var_value
1624         field.
1625         (language_defn::read_var_value): New member function.
1626         (default_read_var_value): Delete declaration.
1627         * m2-lang.c (m2_language_data): Delete la_read_var_value
1628         initializer.
1629         * objc-lang.c (objc_language_data): Likewise.
1630         * opencl-lang.c (opencl_language_data): Likewise.
1631         * p-lang.c (pascal_language_data): Likewise.
1632         * rust-lang.c (rust_language_data): Likewise.
1633         * value.h (default_read_var_value): Delete declaration.
1634
1635 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1636
1637         * ada-lang.c (ada_print_array_index): Delete function, move
1638         implementation to...
1639         (ada_language::print_array_index): ...here.
1640         (ada_language_data): Delete la_print_array_index initializer.
1641         * c-lang.c (c_language_data): Likewise.
1642         (cplus_language_data): Likewise.
1643         (minimal_language_data): Likewise.
1644         * d-lang.c (d_language_data): Likewise.
1645         * f-lang.c (f_language_data): Likewise.
1646         * go-lang.c (go_language_data): Likewise.
1647         * language.c (default_print_array_index): Delete function, move
1648         implementation to...
1649         (language_defn::print_array_index): ...here.
1650         (unknown_language_data): Delete la_print_array_index initializer.
1651         (auto_language_data): Likewise.
1652         * language.h (struct language_data): Delete la_print_array_index
1653         field.
1654         (language_defn::print_array_index): New member function.
1655         (LA_PRINT_ARRAY_INDEX): Update.
1656         (default_print_array_index): Delete declaration.
1657         * m2-lang.c (m2_language_data): Delete la_print_array_index
1658         initializer.
1659         * objc-lang.c (objc_language_data): Likewise.
1660         * opencl-lang.c (opencl_language_data): Likewise.
1661         * p-lang.c (pascal_language_data): Likewise.
1662         * rust-lang.c (rust_language_data): Likewise.
1663
1664 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1665
1666         * gdb/ada-lang.c (ada_language_defn): Convert to...
1667         (ada_language_data): ...this.
1668         (class ada_language): New class.
1669         (ada_language_defn): New static global.
1670         * gdb/c-lang.c (c_language_defn): Convert to...
1671         (c_language_data): ...this.
1672         (class c_language): New class.
1673         (c_language_defn): New static global.
1674         (cplus_language_defn): Convert to...
1675         (cplus_language_data): ...this.
1676         (class cplus_language): New class.
1677         (cplus_language_defn): New static global.
1678         (asm_language_defn): Convert to...
1679         (asm_language_data): ...this.
1680         (class asm_language): New class.
1681         (asm_language_defn): New static global.
1682         (minimal_language_defn): Convert to...
1683         (minimal_language_data): ...this.
1684         (class minimal_language): New class.
1685         (minimal_language_defn): New static global.
1686         * gdb/d-lang.c (d_language_defn): Convert to...
1687         (d_language_data): ...this.
1688         (class d_language): New class.
1689         (d_language_defn): New static global.
1690         * gdb/f-lang.c (f_language_defn): Convert to...
1691         (f_language_data): ...this.
1692         (class f_language): New class.
1693         (f_language_defn): New static global.
1694         * gdb/go-lang.c (go_language_defn): Convert to...
1695         (go_language_data): ...this.
1696         (class go_language): New class.
1697         (go_language_defn): New static global.
1698         * gdb/language.c (unknown_language_defn): Remove declaration.
1699         (current_language): Initialize to nullptr, real initialization is
1700         moved to _initialize_language.
1701         (languages): Delete global.
1702         (language_defn::languages): Define.
1703         (set_language_command): Use language_defn::languages.
1704         (set_language): Likewise.
1705         (range_error): Likewise.
1706         (language_enum): Likewise.
1707         (language_def): Likewise.
1708         (add_set_language_command): Use language_def::languages for the
1709         language list, and language_def to lookup language pointers.
1710         (skip_language_trampoline): Use language_defn::languages.
1711         (unknown_language_defn): Convert to...
1712         (unknown_language_data): ...this.
1713         (class unknown_language): New class.
1714         (unknown_language_defn): New static global.
1715         (auto_language_defn): Convert to...
1716         (auto_language_data): ...this.
1717         (class auto_language): New class.
1718         (auto_language_defn): New static global.
1719         (language_gdbarch_post_init): Use language_defn::languages.
1720         (_initialize_language): Initialize current_language.
1721         * gdb/language.h (struct language_defn): Rename to...
1722         (struct language_data): ...this.
1723         (struct language_defn): New.
1724         (auto_language_defn): Delete.
1725         (unknown_language_defn): Delete.
1726         (minimal_language_defn): Delete.
1727         (ada_language_defn): Delete.
1728         (asm_language_defn): Delete.
1729         (c_language_defn): Delete.
1730         (cplus_language_defn): Delete.
1731         (d_language_defn): Delete.
1732         (f_language_defn): Delete.
1733         (go_language_defn): Delete.
1734         (m2_language_defn): Delete.
1735         (objc_language_defn): Delete.
1736         (opencl_language_defn): Delete.
1737         (pascal_language_defn): Delete.
1738         (rust_language_defn): Delete.
1739         * gdb/m2-lang.c (m2_language_defn): Convert to...
1740         (m2_language_data): ...this.
1741         (class m2_language): New class.
1742         (m2_language_defn): New static global.
1743         * gdb/objc-lang.c (objc_language_defn): Convert to...
1744         (objc_language_data): ...this.
1745         (class objc_language): New class.
1746         (objc_language_defn): New static global.
1747         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
1748         (opencl_language_data): ...this.
1749         (class opencl_language): New class.
1750         (opencl_language_defn): New static global.
1751         * gdb/p-lang.c (pascal_language_defn): Convert to...
1752         (pascal_language_data): ...this.
1753         (class pascal_language): New class.
1754         (pascal_language_defn): New static global.
1755         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
1756         language pointer, update comment format.
1757         * gdb/rust-lang.c (rust_language_defn): Convert to...
1758         (rust_language_data): ...this.
1759         (class rust_language): New class.
1760         (rust_language_defn): New static global.
1761
1762 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
1765         member variable.
1766         <m_stmt_at_address>: New member variable.
1767         (lnp_state_machine::record_line): Don't record some lines, update
1768         tracking of is_stmt at the same address.
1769         (lnp_state_machine::lnp_state_machine): Initialise new member
1770         variables.
1771
1772 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1773
1774         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
1775         "-include gnu-nat-mig.h".
1776         * gnu-nat-mig.h: New file.
1777         * gnu-nat.c: Include "gnu-nat-mig.h".
1778         (exc_server, msg_reply_server, notify_server,
1779         process_reply_server): Remove declarations.
1780
1781 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1782
1783         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
1784         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
1785         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
1786         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
1787         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
1788         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
1789         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
1790         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
1791         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
1792         to gnu_nat_target class.
1793         * gnu-nat.c: Likewise.
1794         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
1795         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
1796         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
1797         object.
1798         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
1799         instead of `gnu_target'.
1800
1801 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1802
1803         * i386-gnu-tdep.c: Include "gdbcore.h"
1804         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
1805         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
1806         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
1807         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
1808         i386_gnu_sigcontext_addr): New functions
1809         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
1810         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
1811         tdep.
1812
1813 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1814
1815         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
1816         before fork_inferior call. Avoid calling it if target_is_pushed returns
1817         true.
1818
1819 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1820
1821         * gnu-nat.h (gnu_target): New variable declaration.
1822         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
1823         gnu_target.
1824         * gnu-nat.c (gnu_target): New variable.
1825         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
1826         add_thread_silent, and add_thread calls.
1827         (gnu_nat_target::create_inferior): Pass gnu_target to
1828         add_thread_silent, thread_change_ptid call.
1829         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
1830         call.
1831
1832 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1833
1834         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
1835         (gnu_nat_target::find_memory_regions): Remove unused
1836         `old_address' variable.
1837
1838 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1839
1840         * gnu-nat.c: Include "gdbarch.h".
1841
1842 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1843
1844         * reply_mig_hack.awk (Error return): Cast function through
1845         void *, to bypass compiler function call check.
1846
1847 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1848
1849         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
1850         $(srcdir)/reply_mig_hack.awk.
1851
1852 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
1853
1854         * gnu-nat.h (gnu_debug_flag): Set type to bool.
1855
1856 2020-05-30  Jonny Grant  <jg@jguk.org>
1857
1858         * configure.ac (ACX_BUGURL): change bug URL to https.
1859
1860 2020-05-30  Pedro Alves  <palves@redhat.com>
1861
1862         * cp-support.c (replace_typedefs_template): New.
1863         (replace_typedefs_qualified_name): Handle
1864         DEMANGLE_COMPONENT_TEMPLATE.
1865
1866 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
1867
1868         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
1869         dwarf2/index-cache.h, dwarf2/index-write.c,
1870         dwarf2/index-write.h, dwarf2/line-header.c,
1871         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
1872         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
1873         variables and fields from `dwarf2_per_objfile` to just
1874         `per_objfile` throughout.
1875
1876 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
1877
1878         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1879         <push_dwarf_reg_entry_value>: Add comment.
1880
1881 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
1882             Keith Seitz  <keiths@redhat.com>
1883
1884         * python/python.c (do_start_initialization): Call PyEval_SaveThread
1885         instead of PyEval_ReleaseLock.
1886         (class gdbpy_gil): Move to earlier in file.
1887         (finalize_python): Set gdb_python_initialized.
1888         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
1889         when not initialized.
1890
1891 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
1892
1893         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
1894         <push_dwarf_reg_entry_value>: Remove assert.  Override
1895         per_objfile with caller_per_objfile.
1896
1897 2020-05-28  Tom de Vries  <tdevries@suse.de>
1898
1899         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
1900         PR gold/15646 workaround to symbol kind "type".
1901
1902 2020-05-27  Tom Tromey  <tromey@adacore.com>
1903
1904         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
1905
1906 2020-05-27  Tom Tromey  <tromey@adacore.com>
1907
1908         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
1909         Use htab_find_with_hash.
1910         <add_abbrev>: Remove "abbrev_number" parameter.
1911         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
1912         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
1913         (hash_abbrev): Add comment.
1914         (abbrev_table::lookup_abbrev): Move to header file.
1915         (abbrev_table::read): Update.
1916
1917 2020-05-27  Tom Tromey  <tromey@adacore.com>
1918
1919         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
1920         method.
1921         <canonical_name>: New member.
1922         <raw_name>: Rename from "name".
1923         (partial_die_info): Initialize canonical_name.
1924         (scan_partial_symbols): Check raw_name.
1925         (partial_die_parent_scope, partial_die_full_name)
1926         (add_partial_symbol, add_partial_subprogram)
1927         (add_partial_enumeration, load_partial_dies): Use "name" method.
1928         (partial_die_info::name): New method.
1929         (partial_die_info::read, guess_partial_die_structure_name)
1930         (partial_die_info::fixup): Update.
1931
1932 2020-05-27  Tom Tromey  <tromey@adacore.com>
1933
1934         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
1935         <get_ref_die_offset>: Inline.
1936         <get_ref_die_offset_complaint>: New method.
1937         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
1938         (attribute::get_ref_die_offset_complaint): Rename from
1939         get_ref_die_offset.  Just issue complaint.
1940
1941 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1942
1943         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
1944
1945 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1946
1947         * exec.c (exec_file_attach): Use errno value of first openp failure.
1948
1949 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
1950
1951         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
1952         Don't close thread handle.
1953
1954 2020-05-27  Tom Tromey  <tom@tromey.com>
1955             Simon Marchi  <simon.marchi@efficios.com>
1956
1957         * objfiles.h (struct objfile) <partial_symtabs>: Now a
1958         shared_ptr.
1959         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
1960         member.
1961         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
1962         dwarf2_per_bfd_objfile_data_key>: New globals.
1963         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
1964         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
1965         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
1966         shared.
1967         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
1968         short-circuit when sharing.
1969         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
1970         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
1971
1972 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1973
1974         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
1975         to...
1976         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
1977         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
1978
1979 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
1980
1981         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
1982         build_name_components, find_name_components_bounds>:
1983         Add per_objfile parameter.
1984         (struct mapped_index) <symbol_name_at>: Likewise.
1985         (struct mapped_debug_names): Remove constructor.
1986         <dwarf2_per_objfile>: Remove field.
1987         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
1988         (mapped_index_base::find_name_components_bounds,
1989         mapped_index_base::build_name_components,
1990         dw2_expand_symtabs_matching_symbol): Likewise.
1991         (class mock_mapped_index) <symbol_name_at>: Likewise.
1992         (check_match): Likewise.
1993         (check_find_bounds_finds): Likewise.
1994         (test_mapped_index_find_name_component_bounds): Update.
1995         (CHECK_MATCH): Update.
1996         (dw2_expand_symtabs_matching): Update.
1997         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
1998         per_objfile parameter.
1999         <find_vec_in_debug_names>: Likewise.
2000         <m_per_objfile>: New field.
2001         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
2002         parameter.
2003         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
2004         (dw2_debug_names_iterator::next): Update.
2005         (dw2_debug_names_lookup_symbol): Update.
2006         (dw2_debug_names_expand_symtabs_for_function): Update.
2007         (dw2_debug_names_map_matching_symbols): Update.
2008         (dw2_debug_names_expand_symtabs_matching): Update.
2009         (dwarf2_read_debug_names): Update.
2010
2011 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2012
2013         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
2014         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
2015         move to dwarf2_per_objfile.
2016         <read_in_chain>: Remove.
2017         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
2018         remove_all_cus, age_comp_units>: New methods.
2019         <m_dwarf2_cus>: New member.
2020         (struct dwarf2_per_cu_data) <cu>: Remove.
2021         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
2022         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
2023         moved to methods of dwarf2_per_objfile.
2024         (dwarf2_clear_marks): Remove.
2025         (dwarf2_queue_item::~dwarf2_queue_item): Update.
2026         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
2027         (dwarf2_per_bfd::free_cached_comp_units): Remove.
2028         (dwarf2_per_objfile::remove_all_cus): New.
2029         (class free_cached_comp_units) <~free_cached_comp_units>:
2030         Update.
2031         (load_cu): Update.
2032         (dw2_do_instantiate_symtab): Adjust.
2033         (fill_in_sig_entry_from_dwo_entry): Adjust.
2034         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2035         (cutu_reader::cutu_reader): Likewise.
2036         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
2037         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
2038         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
2039         and dwarf2_per_objfile::age_comp_units.
2040         (load_partial_comp_unit): Update.
2041         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
2042         (process_queue): Likewise.
2043         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
2044         backlink.
2045         (dwarf2_read_addr_index): Likewise.
2046         (follow_die_offset): Likewise.
2047         (dwarf2_fetch_die_loc_sect_off): Likewise.
2048         (dwarf2_fetch_constant_bytes): Likewise.
2049         (dwarf2_fetch_die_type_sect_off): Likewise.
2050         (follow_die_sig_1): Likewise.
2051         (load_full_type_unit): Likewise.
2052         (read_signatured_type): Likewise.
2053         (dwarf2_cu::dwarf2_cu): Don't set cu field.
2054         (dwarf2_cu::~dwarf2_cu): Remove.
2055         (dwarf2_per_objfile::get_cu): New.
2056         (dwarf2_per_objfile::set_cu): New.
2057         (age_cached_comp_units): Rename to...
2058         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
2059         to std::unordered_map.
2060         (free_one_cached_comp_unit): Rename to...
2061         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
2062         to std::unordered_map.
2063         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
2064         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
2065         a dwarf2_per_objfile in data.
2066         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
2067         (dwarf2_clear_marks): Remove.
2068
2069 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2070
2071         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
2072         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
2073         (init_tu_and_read_dwo_dies): Likewise.
2074         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
2075         (cutu_reader::cutu_reader): Likewise.
2076         (load_partial_comp_unit): Likewise.
2077         (process_psymtab_comp_unit): Update.
2078         (build_type_psymtabs_1): Update.
2079         (process_skeletonless_type_unit): Update.
2080         (load_full_comp_unit): Update.
2081         (find_partial_die): Update.
2082         (dwarf2_read_addr_index): Update.
2083         (read_signatured_type): Update.
2084
2085 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2086
2087         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
2088         m_header_read_in>: New fields.
2089         <get_header>: New method.
2090         * dwarf2/read.c (per_cu_header_read_in): Remove.
2091         (dwarf2_per_cu_data::get_header): New.
2092         (dwarf2_per_cu_data::addr_size): Update.
2093         (dwarf2_per_cu_data::offset_size): Update.
2094         (dwarf2_per_cu_data::ref_addr_size): Update.
2095
2096 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2097
2098         * dwarf2/read.c (load_cu): Return dwarf2_cu.
2099         (dw2_do_instantiate_symtab): Update.
2100         (queue_and_load_all_dwo_tus): Change parameter from
2101         dwarf2_per_cu_data to dwarf2_cu.
2102         (dwarf2_fetch_die_loc_sect_off): Update.
2103         (dwarf2_fetch_constant_bytes): Update.
2104         (dwarf2_fetch_die_type_sect_off): Update.
2105
2106 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2107
2108         * dwarf2/read.c (process_full_comp_unit,
2109         process_full_type_unit): Remove per_cu, per_objfile paramters.
2110         Add dwarf2_cu parameter.
2111         (process_queue): Update.
2112
2113 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2114
2115         * dwarf2/read.c (create_cu_from_index_list): Replace
2116         dwarf2_per_objfile parameter with dwarf2_per_bfd.
2117         (create_cus_from_index_list): Likewise.
2118         (create_cus_from_index): Likewise.
2119         (create_signatured_type_table_from_index): Likewise.
2120         (create_cus_from_debug_names_list): Likewise.
2121         (create_cus_from_debug_names): Likewise.
2122         (dwarf2_read_gdb_index): Update.
2123         (dwarf2_read_debug_names): Update.
2124
2125 2020-05-27  Tom Tromey  <tom@tromey.com>
2126             Simon Marchi  <simon.marchi@efficios.com>
2127
2128         * dwarf2/read.h (struct dwarf2_per_objfile)
2129         <get_type_for_signatured_type, set_type_for_signatured_type>:
2130         New methods.
2131         <m_type_map>: New member.
2132         (struct signatured_type) <type>: Remove.
2133         * dwarf2/read.c
2134         (dwarf2_per_objfile::get_type_for_signatured_type,
2135         dwarf2_per_objfile::set_type_for_signatured_type): New.
2136         (get_signatured_type): Use new methods.
2137
2138 2020-05-27  Tom Tromey  <tom@tromey.com>
2139             Simon Marchi  <simon.marchi@efficios.com>
2140
2141         * dwarf2/read.h (struct type_unit_group_unshareable): New.
2142         (struct dwarf2_per_objfile) <type_units>: New member.
2143         <get_type_unit_group_unshareable>: New method.
2144         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
2145         num_symtabs, symtabs>: Remove; move to
2146         type_unit_group_unshareable.
2147         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
2148         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
2149         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
2150
2151 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2152
2153         * dwarf2/read.h (struct dwarf2_per_cu_data):
2154         <dwarf2_per_objfile>: Remove.
2155         * dwarf2/read.c (create_cu_from_index_list): Don't assign
2156         dwarf2_per_objfile.
2157         (create_signatured_type_table_from_index): Likewise.
2158         (create_signatured_type_table_from_debug_names): Likewise.
2159         (create_debug_type_hash_table): Likewise.
2160         (fill_in_sig_entry_from_dwo_entry): Likewise.
2161         (create_type_unit_group): Likewise.
2162         (read_comp_units_from_section): Likewise.
2163         (create_cus_hash_table): Likewise.
2164
2165 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2166
2167         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
2168         dwarf2_per_cu_data::dwarf2_per_objfile.
2169         (compute_compunit_symtab_includes): Likewise.
2170         (dwarf2_cu::start_symtab): Likewise.
2171
2172 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2173
2174         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
2175         parameter.
2176         * dwarf2/read.c (get_die_type_at_offset): Likewise.
2177         (read_namespace_alias): Update.
2178         (lookup_die_type): Update.
2179         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
2180         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
2181         Update.
2182         (disassemble_dwarf_expression): Update.
2183
2184 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2185
2186         * dwarf2/read.h (struct dwarf2_queue_item): Add
2187         dwarf2_per_objfile parameter, assign new parameter.
2188         <per_objfile>: New field.
2189         * dwarf2/read.c (free_one_cached_comp_unit): Add
2190         dwarf2_per_objfile parameter.
2191         (queue_comp_unit): Likewise.
2192         (dw2_do_instantiate_symtab): Update.
2193         (process_psymtab_comp_unit): Update.
2194         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
2195         (process_imported_unit_die): Update.
2196         (queue_and_load_dwo_tu): Update.
2197         (follow_die_offset): Update.
2198         (follow_die_sig_1): Update.
2199
2200 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2201
2202         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
2203         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
2204         (read_call_site_scope): Assign per_objfile.
2205         (dwarf2_per_cu_data::objfile): Remove.
2206         * gdbtypes.h (struct call_site) <per_objfile>: New member.
2207         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
2208         dwarf2_per_objfile parameter.
2209         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
2210         dwarf2_per_objfile parameter.
2211         (dwarf_expr_reg_to_entry_parameter): Add output
2212         dwarf2_per_objfile parameter.
2213         (locexpr_get_frame_base): Update.
2214         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
2215         <push_dwarf_reg_entry_value>: Update.
2216         <call_site_to_target_addr>: Update.
2217         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
2218         parameter.
2219         (value_of_dwarf_reg_entry): Update.
2220         (rw_pieced_value): Update.
2221         (indirect_synthetic_pointer): Update.
2222         (dwarf2_evaluate_property): Update.
2223         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
2224         parameter.
2225         (locexpr_read_variable): Update.
2226         (locexpr_get_symbol_read_needs): Update.
2227         (loclist_read_variable): Update.
2228
2229 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2230
2231         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2232         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2233         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2234         parameter.
2235         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2236         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2237         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2238         parameter.
2239         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
2240         sect_variable_value): Add dwarf2_per_objfile parameter.
2241         (class dwarf_evaluate_loc_desc) <dwarf_call,
2242         dwarf_variable_value>: Update.
2243         (fetch_const_value_from_synthetic_pointer): Add
2244         dwarf2_per_objfile parameter.
2245         (fetch_const_value_from_synthetic_pointer): Update.
2246         (coerced_pieced_ref): Update.
2247         (class symbol_needs_eval_context) <dwarf_call,
2248         dwarf_variable_value>: Update.
2249         (dwarf2_compile_expr_to_ax): Update.
2250
2251 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2252
2253         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
2254         parameter.
2255         (dwarf2_evaluate_loc_desc_full): Update.
2256
2257 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2258
2259         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
2260         parameter.
2261         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
2262         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
2263         dwarf2_per_objfile parameter.
2264         (decode_debug_loc_dwo_addresses): Likewise.
2265         (dwarf2_find_location_expression): Update.
2266         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
2267         (locexpr_describe_location_piece): Add dwarf2_per_objfile
2268         parameter.
2269         (disassemble_dwarf_expression): Add dwarf2_per_objfile
2270         parameter.
2271         (locexpr_describe_location_1): Likewise.
2272         (locexpr_describe_location): Update.
2273
2274 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2275
2276         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
2277         Remove.
2278         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
2279         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
2280         (dwarf2_compile_property_to_c): Update.
2281         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
2282         use text offset from objfile.
2283         (locexpr_tracepoint_var_ref): Update.
2284         (locexpr_generate_c_location): Update.
2285         (loclist_describe_location): Update.
2286         (loclist_tracepoint_var_ref): Update.
2287         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
2288         dwarf2_per_objfile parameter.
2289         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
2290         use text offset from objfile.
2291         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
2292
2293 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2294
2295         * dwarf2/expr.h (struct dwarf_expr_context)
2296         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
2297         <offset>: Remove.
2298         <per_objfile>: New member.
2299         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
2300         dwarf2_per_objfile parameter.  Don't set offset, set
2301         per_objfile.
2302         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
2303         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
2304         a dwarf2_per_objfile object instead of an offset.
2305         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
2306         constructor.
2307         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
2308         to dwarf2_expr_executor constructor.  Don't set offset.
2309         (dwarf2_fetch_cfa_info): Update.
2310         (struct dwarf2_frame_cache) <text_offset>: Remove.
2311         <per_objfile>: New field.
2312         (dwarf2_frame_cache): Update.
2313         (dwarf2_frame_prev_register): Update.
2314         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2315         <dwarf_evaluate_loc_desc>: Add constructor.
2316         (dwarf2_evaluate_loc_desc_full): Update.
2317         (dwarf2_locexpr_baton_eval): Update.
2318         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
2319         Add constructor.
2320         (dwarf2_loc_desc_get_symbol_read_needs): Update.
2321
2322 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2323
2324         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
2325         addr_sized_int_type>: Move to dwarf2_cu.
2326         <int_type>: Move to dwarf2_per_objfile.
2327         (struct dwarf2_per_objfile) <int_type>: Move here.
2328         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
2329         addr_sized_int_type>: Move here.
2330         (read_func_scope): Update.
2331         (read_array_type): Update.
2332         (read_tag_string_type): Update.
2333         (attr_to_dynamic_prop): Update.
2334         (dwarf2_per_cu_data::int_type): Rename to...
2335         (dwarf2_per_objfile::int_type): ... this.
2336         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
2337         (dwarf2_cu::addr_sized_int_type): ... this.
2338         (read_subrange_type): Update.
2339         (dwarf2_per_cu_data::addr_type): Rename to...
2340         (dwarf2_cu::addr_type): ... this.
2341         (set_die_type): Update.
2342
2343 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2344
2345         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
2346         data through per_cu->cu.
2347
2348 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2349
2350         * dwarf2/read.c (lookup_dwo_comp_unit): Change
2351         dwarf2_per_cu_data parameter fo dwarf2_cu.
2352         (lookup_dwo_type_unit): Likewise.
2353         (read_cutu_die_from_dwo): Likewise.
2354         (lookup_dwo_unit): Likewise.
2355         (open_and_init_dwo_file): Likewise.
2356         (lookup_dwo_cutu): Likewise.
2357         (lookup_dwo_comp_unit): Likewise.
2358         (lookup_dwo_type_unit): Likewise.
2359         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2360         (cutu_reader::cutu_reader): Update.
2361
2362 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2363
2364         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
2365         parameter.
2366         (process_full_type_unit): Likewise.
2367         (process_queue): Update.
2368
2369 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2370
2371         * dwarf2/read.c (recursively_compute_inclusions): Add
2372         dwarf2_per_objfile parameter.
2373         (compute_compunit_symtab_includes): Likewise.
2374         (process_cu_includes): Update.
2375
2376 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2377
2378         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
2379         parameter.
2380         (create_type_unit_group): Update.
2381         (process_psymtab_comp_unit_reader): Update.
2382         (build_type_psymtabs_reader): Update.
2383
2384 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2385
2386         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
2387         object through m_this_cu->cu.
2388
2389 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2390
2391         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
2392         the info parameter.
2393         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
2394
2395 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2396
2397         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
2398         per_objfile parameter.
2399         (load_full_type_unit): Add per_objfile parameter.
2400         (read_signatured_type): Likewise.
2401         (load_full_comp_unit): Likewise.
2402         (load_cu): Likewise.
2403         (dw2_do_instantiate_symtab): Likewise.
2404         (dw2_get_file_names): Likewise.
2405         (dw2_map_symtabs_matching_filename): Update.
2406         (dw_expand_symtabs_matching_file_matcher): Update.
2407         (dw2_map_symbol_filenames): Update.
2408         (process_psymtab_comp_unit): Add per_objfile parameter.
2409         (build_type_psymtabs_1): Update.
2410         (process_skeletonless_type_unit): Update.
2411         (dwarf2_build_psymtabs_hard): Update.
2412         (load_partial_comp_unit): Add per_objfile parameter.
2413         (scan_partial_symbols): Update.
2414         (load_full_comp_unit): Add per_objfile parameter.
2415         (process_imported_unit_die): Update.
2416         (create_cus_hash_table): Update.
2417         (find_partial_die): Update.
2418         (dwarf2_read_addr_index): Update.
2419         (follow_die_offset): Update.
2420         (dwarf2_fetch_die_loc_sect_off): Update.
2421         (dwarf2_fetch_constant_bytes): Update.
2422         (dwarf2_fetch_die_type_sect_off): Update.
2423         (follow_die_sig_1): Update.
2424         (load_full_type_unit): Add per_objfile parameter.
2425         (read_signatured_type): Likewise.
2426
2427 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
2430         of objfile_name.
2431
2432 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2433
2434         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
2435         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2436         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
2437         field.
2438         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2439         (create_cus_from_index): Update.
2440         (dwarf2_read_gdb_index): Update.
2441         (create_cus_from_debug_names): Update.
2442         (dwarf2_read_debug_names): Update.
2443         (get_abbrev_section_for_cu): Update.
2444         (create_all_comp_units): Update.
2445         (read_attribute_value): Update.
2446         (get_debug_line_section): Update.
2447         * dwarf2/index-cache.c (index_cache::store): Update.
2448         * dwarf2/index-write.c (save_gdb_index_command): Update.
2449         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
2450
2451 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2452
2453         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
2454         member.
2455         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
2456         dwarf2_per_cu_data::per_bfd.
2457         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
2458         (create_type_unit_group): Likewise.
2459         (queue_comp_unit): Remove reference to
2460         per_cu->dwarf2_per_objfile.
2461         (maybe_queue_comp_unit): Likewise.
2462         (fill_in_sig_entry_from_dwo_entry): Assign new field.
2463         (create_cus_hash_table): Assign new field.
2464
2465 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2466
2467         * dwarf2/read.c: Replace
2468         dwarf2_cu->per_cu->dwarf2_per_objfile references with
2469         dwarf2_cu->per_objfile throughout.
2470
2471 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2472
2473         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
2474         parameter, don't use per_cu->dwarf2_per_objfile.
2475         (dw2_instantiate_symtab): Likewise.
2476         (dw2_find_last_source_symtab): Update.
2477         (dw2_map_expand_apply): Update.
2478         (dw2_lookup_symbol): Update.
2479         (dw2_expand_symtabs_for_function): Update.
2480         (dw2_expand_all_symtabs): Update.
2481         (dw2_expand_symtabs_with_fullname): Update.
2482         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
2483         don't use per_cu->dwarf2_per_objfile.
2484         (dw2_expand_marked_cus): Update.
2485         (dw2_find_pc_sect_compunit_symtab): Update.
2486         (dw2_debug_names_lookup_symbol): Update.
2487         (dw2_debug_names_expand_symtabs_for_function): Update.
2488         (dw2_debug_names_map_matching_symbols): Update.
2489         (dwarf2_psymtab::expand_psymtab): Update.
2490
2491 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2492
2493         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
2494         <per_objfile>: New member.
2495         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
2496         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
2497         call to dwarf2_cu.
2498         (cutu_reader::cutu_reader): Update.
2499         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
2500
2501 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2502
2503         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
2504         struct dwarf2_per_objfile.
2505         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
2506         dwarf2_per_bfd.
2507         * dwarf2/read.c (set_die_type): Update.
2508         (get_die_type_at_offset): Update.
2509
2510 2020-05-27  Tom Tromey  <tom@tromey.com>
2511             Simon Marchi  <simon.marchi@efficios.com>
2512
2513         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
2514         method.
2515         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
2516         get_symtab, set_symtab>: New methods.
2517         <m_symtabs>: New field.
2518         (struct dwarf2_psymtab): Derive from partial_symtab.
2519         <readin_p, get_compunit_symtab>: Declare methods.
2520         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
2521         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
2522         New methods.
2523         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
2524         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2525         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2526         (dw2_symtab_iter_next, dw2_print_stats)
2527         (dw2_expand_symtabs_with_fullname)
2528         (dw2_expand_symtabs_matching_one)
2529         (dw_expand_symtabs_matching_file_matcher)
2530         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2531         (dw2_debug_names_iterator::next)
2532         (dw2_debug_names_map_matching_symbols)
2533         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2534         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2535         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2536         New methods.
2537         (get_compunit_symtab, process_full_comp_unit)
2538         (process_full_type_unit): Update.
2539         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2540
2541 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2542
2543         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2544         then introduce a new dwarf2_per_objfile type.
2545         <read_line_string>: Move to the new dwarf2_per_objfile type.
2546         <objfile>: Likewise.
2547         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2548         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2549         dwarf2_per_objfile->per_bfd.
2550         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2551         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2552         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2553         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2554         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2555         (dwarf2_per_objfile::locate_sections): Rename to...
2556         (dwarf2_per_bfd::locate_sections): ... this.
2557         (dwarf2_per_objfile::get_cutu): Rename to...
2558         (dwarf2_per_bfd::get_cutu): ... this.
2559         (dwarf2_per_objfile::get_cu): Rename to...
2560         (dwarf2_per_bfd::get_cu): ... this.
2561         (dwarf2_per_objfile::get_tu): Rename to...
2562         (dwarf2_per_bfd::get_tu): ... this.
2563         (dwarf2_per_objfile::allocate_per_cu): Rename to...
2564         (dwarf2_per_bfd::allocate_per_cu): ... this.
2565         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
2566         (dwarf2_per_bfd::allocate_signatured_type): ... this.
2567         (get_gdb_index_contents_ftype): Change parameter from
2568         dwarf2_per_objfile to dwarf2_per_bfd.
2569         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
2570         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
2571
2572 2020-05-27  Tom Tromey  <tom@tromey.com>
2573             Simon Marchi  <simon.marchi@efficios.com>
2574
2575         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
2576         (allocate_piece_closure): Set "per_objfile" member.
2577         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
2578         (locexpr_describe_location, loclist_describe_location): Use new
2579         member.
2580         * dwarf2/read.c (read_call_site_scope)
2581         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
2582         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
2583         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
2584         handle_data_member_location): Set per_objfile member.
2585         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
2586         member.
2587         (struct dwarf2_loclist_baton) <per_objfile>: New member.
2588
2589 2020-05-27  Tom Tromey  <tom@tromey.com>
2590
2591         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
2592         allocate_signatured_type>: Declare new methods.
2593         <m_num_psymtabs>: New member.
2594         (struct dwarf2_per_cu_data) <index>: New member.
2595         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
2596         (dwarf2_per_objfile::allocate_signatured_type): New methods.
2597         (create_cu_from_index_list): Use allocate_per_cu.
2598         (create_signatured_type_table_from_index)
2599         (create_signatured_type_table_from_debug_names)
2600         (create_debug_type_hash_table, add_type_unit)
2601         (read_comp_units_from_section): Use allocate_signatured_type.
2602
2603 2020-05-27  Tom Tromey  <tom@tromey.com>
2604
2605         * psymtab.c (partial_map_expand_apply)
2606         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
2607         (psym_lookup_global_symbol_language)
2608         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
2609         (psym_print_stats, psym_expand_symtabs_for_function)
2610         (psym_map_symbol_filenames, psym_map_matching_symbols)
2611         (psym_expand_symtabs_matching)
2612         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
2613         (maintenance_check_psymtabs): Update.
2614         * psympriv.h (struct partial_symtab) <readin_p,
2615         get_compunit_symtab>: Add objfile parameter.
2616         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
2617         Likewise.
2618         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
2619         get_compunit_symtab>: Likewise.
2620         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
2621
2622 2020-05-27  Tom Tromey  <tom@tromey.com>
2623
2624         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
2625         member.
2626         * dwarf2/read.c (delete_file_name_entry): Fix comment.
2627         (create_cu_from_index_list)
2628         (create_signatured_type_table_from_index)
2629         (create_signatured_type_table_from_debug_names)
2630         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
2631         (dwarf2_create_include_psymtab)
2632         (create_debug_type_hash_table, add_type_unit)
2633         (create_type_unit_group, read_comp_units_from_section)
2634         (dwarf2_compute_name, create_cus_hash_table)
2635         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
2636         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
2637         obstack.
2638         (dw2_get_real_path): Likewise.  Change argument to
2639         dwarf2_per_objfile.
2640
2641 2020-05-27  Luis Machado  <luis.machado@linaro.org>
2642
2643         PR tdep/26000
2644         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
2645         for ldrd (immediate).
2646
2647 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2648
2649         * command.h: Add comment giving the name of class_tui.
2650         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
2651         create the fake command for the help for class_tui.
2652
2653 2020-05-26  Tom Tromey  <tromey@adacore.com>
2654
2655         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
2656         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
2657         (val_atr): New function.
2658         (value_val_atr): Use it.
2659         * ada-valprint.c (print_optional_low_bound): Change low bound
2660         handling for enums.
2661         (val_print_packed_array_elements): Don't call discrete_position.
2662         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
2663         discrete_position for enum types.
2664         * language.c (default_print_array_index): Change type.
2665         * language.h (struct language_defn) <la_print_array_index>: Add
2666         index_type parameter, change type of index_value.
2667         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
2668         (default_print_array_index): Update.
2669         * valprint.c (maybe_print_array_index): Don't call
2670         value_from_longest.  Update.
2671         (value_print_array_elements): Don't call discrete_position.
2672
2673 2020-05-26  Tom Tromey  <tromey@adacore.com>
2674
2675         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
2676         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
2677
2678 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
2679
2680         PR gdb/13519
2681         * avr-tdep.c (avr_integer_to_address): Return data or code
2682         address accordingly to the second 'type' argument of the
2683         function.
2684
2685 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
2686
2687         * infcmd.c, inferior.h: (construct_inferior_arguments):
2688         Moved function from here to gdbsupport/common-inferior.{h,cc}
2689
2690 2020-05-23  Tom Tromey  <tom@tromey.com>
2691
2692         Revert commit eca1f90c:
2693         * NEWS: Remove entry for completion styling.
2694         * completer.c (_rl_completion_prefix_display_length): Move
2695         declaration later.
2696         (gdb_fnprint): Revert.
2697         (gdb_display_match_list_1): Likewise.
2698         * cli/cli-style.c (completion_prefix_style)
2699         (completion_difference_style, completion_suffix_style): Remove.
2700         (_initialize_cli_style): Revert.
2701         * cli/cli-style.h (completion_prefix_style)
2702         (completion_difference_style, completion_suffix_style): Don't
2703         declare.
2704
2705 2020-05-24  Pedro Alves  <palves@redhat.com>
2706
2707         * symtab.c (completion_list_add_name): Return boolean indication
2708         of whether the symbol matched.
2709         (completion_list_add_symbol): Don't try to remove C++ aliases if
2710         the symbol didn't match in the first place.
2711         * symtab.h (completion_list_add_name): Return bool.
2712
2713 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
2714
2715         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
2716         type::field.
2717
2718 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
2719
2720         GDB 9.2 released.
2721
2722 2020-05-23  Tom Tromey  <tom@tromey.com>
2723
2724         * NEWS: Add entry for completion styling.
2725         * completer.c (_rl_completion_prefix_display_length): Move
2726         declaration earlier.
2727         (gdb_fnprint): Use completion_style.
2728         (gdb_display_match_list_1): Likewise.
2729         * cli/cli-style.c (completion_prefix_style)
2730         (completion_difference_style, completion_suffix_style): New
2731         globals.
2732         (_initialize_cli_style): Register new globals.
2733         * cli/cli-style.h (completion_prefix_style)
2734         (completion_difference_style, completion_suffix_style): Declare.
2735
2736 2020-05-23  Pedro Alves  <palves@redhat.com>
2737
2738         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
2739         (parse_escape): Use ISDIGIT instead of isdigit.
2740         (puts_debug): Use gdb_isprint instead of isprint.
2741         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
2742         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
2743         ISSPACE instead of isspace.
2744         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
2745         instead of isspace.
2746         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
2747         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
2748         instead of isxdigit and ISDIGIT instead of isdigit.
2749
2750 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2751
2752         * gdbtypes.h (struct type) <field>: New method.
2753         (TYPE_FIELDS): Remove, replace all uses with either type::fields
2754         or type::field.
2755
2756 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2757
2758         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
2759         (TYPE_FIELDS): Use type::fields.  Change all call sites that
2760         modify the propery to use type::set_fields instead.
2761
2762 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2763
2764         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
2765         type::num_fields instead.
2766
2767 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
2768
2769         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
2770         methods.
2771         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
2772         that modify the number of fields to use type::set_num_fields
2773         instead.
2774
2775 2020-05-22  Tom Tromey  <tromey@adacore.com>
2776
2777         * compile/compile-object-load.h (munmap_list_free): Don't
2778         declare.
2779
2780 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2781
2782         * annotate.c (annotate_source_line): Update return type, add call
2783         to update current symtab and line.
2784         * annotate.h (annotate_source_line): Update return type, and
2785         extend header comment.
2786         * source.c (info_line_command): Check annotation_level before
2787         calling annotate_source_line.
2788         * stack.c (print_frame_info): If calling annotate_source_line
2789         returns true, then don't print any other source line information.
2790
2791 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2792
2793         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
2794
2795 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
2796
2797         * coffread.c (patch_type): Remove NULL check before xfree.
2798         * corefile.c (set_gnutarget): Likewise.
2799         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
2800         * exec.c (build_section_table): Likewise.
2801         * remote.c (remote_target::pass_signals): Likewise.
2802         * utils.c (n_spaces): Likewise.
2803         * cli/cli-script.c (document_command): Likewise.
2804         * i386-windows-tdep.c (core_process_module_section): Likewise.
2805         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
2806
2807 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
2808
2809         * symfile.c (reread_symbols): Clear objfile's section_offsets
2810         vector and section indices, re-compute them by calling
2811         sym_offsets.
2812
2813 2020-05-20  Tom Tromey  <tromey@adacore.com>
2814
2815         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
2816         (desc_one_bound, desc_index_type): Compute field name.
2817
2818 2020-05-20  Tom de Vries  <tdevries@suse.de>
2819
2820         PR symtab/25833
2821         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
2822
2823 2020-05-20  Alan Modra  <amodra@gmail.com>
2824
2825         PR 25993
2826         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
2827         bfd_set_filename.
2828         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
2829         passed to bfd_set_filename.
2830         * symfile-mem.c (add_vsyscall_page): Likewise for string
2831         passed to symbol_file_add_from_memory.
2832         (symbol_file_add_from_memory): Make name param a const char* and
2833         don't strdup.
2834
2835 2020-05-20  Alan Modra  <amodra@gmail.com>
2836
2837         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
2838         rather than accessing bfd->filename directly.
2839         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
2840         and use bfd_section_name.
2841         * dwarf2/frame.c (decode_frame_entry): Likewise.
2842         * exec.c (exec_set_section_address): Likewise.
2843         * solib-aix.c (solib_aix_bfd_open): Likewise.
2844         * stap-probe.c (get_stap_base_address): Likewise.
2845         * symfile.c (reread_symbols): Likewise.
2846
2847 2020-05-19  Tom Tromey  <tromey@adacore.com>
2848
2849         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
2850
2851 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2852
2853         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
2854
2855 2020-05-19  Pedro Alves  <palves@redhat.com>
2856
2857         * NEWS (set exec-file-mismatch): Adjust entry.
2858         * exec.c: Include "build-id.h".
2859         (validate_exec_file): Try to match build IDs instead of filenames.
2860         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
2861         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
2862         and pass down 'warn_if_slow'.
2863         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
2864         gdb_bfd_open_closure to pass it down.
2865         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
2866
2867 2020-05-19  Pedro Alves  <palves@redhat.com>
2868
2869         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
2870         * target.c (target_fileio_open_1): Rename to target_fileio_open
2871         and make extern.  Use bool.
2872         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
2873         (target_fileio_read_alloc_1): Adjust.
2874         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
2875         (target_fileio_open_warn_if_slow): Delete declaration.
2876
2877 2020-05-19  Pedro Alves  <palves@redhat.com>
2878
2879         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
2880         Adjust all callers.
2881
2882 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
2883
2884         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
2885         whether disp is negative.
2886
2887 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2888
2889         * symfile.h (struct symfile_segment_data)
2890         <~symfile_segment_data>: Remove.
2891         <segment_info>: Change to std::vector.
2892         * symfile.c (default_symfile_segments): Update.
2893         * elfread.c (elf_symfile_segments): Update.
2894
2895 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2896
2897         * symfile.h (struct symfile_segment_data) <struct segment>: New.
2898         <segments>: New.
2899         <segment_bases, segment_sizes>: Remove.
2900         * symfile.c (default_symfile_segments): Update.
2901         * elfread.c (elf_symfile_segments): Update.
2902         * remote.c (remote_target::get_offsets): Update.
2903         * solib-target.c (solib_target_relocate_section_addresses):
2904         Update.
2905
2906 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
2907
2908         * symfile.h (struct symfile_segment_data): Initialize fields.
2909         <~symfile_segment_data>: Add.
2910         (symfile_segment_data_up): New.
2911         (struct sym_fns) <sym_segments>: Return a
2912         symfile_segment_data_up.
2913         (default_symfile_segments): Return a symfile_segment_data_up.
2914         (free_symfile_segment_data): Remove.
2915         (get_symfile_segment_data): Return a symfile_segment_data_up.
2916         * symfile.c (default_symfile_segments): Likewise.
2917         (get_symfile_segment_data): Likewise.
2918         (free_symfile_segment_data): Remove.
2919         (symfile_find_segment_sections): Update.
2920         * elfread.c (elf_symfile_segments): Return a
2921         symfile_segment_data_up.
2922         * remote.c (remote_target::get_offsets): Update.
2923         * solib-target.c (solib_target_relocate_section_addresses):
2924         Update.
2925         * symfile-debug.c (debug_sym_segments): Return a
2926         symfile_segment_data_up.
2927
2928 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2929
2930         PR build/25981
2931         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
2932         Hardcode register numbers.
2933
2934         PR build/25981
2935         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
2936         procfs_find_LDT_entry): Remove.
2937         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
2938         procfs_find_LDT_entry): Remove.
2939         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
2940         Remove.
2941
2942 2020-05-17  Pedro Alves  <palves@redhat.com>
2943             Andrew Burgess  <andrew.burgess@embecosm.com>
2944             Keno Fischer  <keno@juliacomputing.com>
2945
2946         PR gdb/25741
2947         * breakpoint.c (build_target_condition_list): Update comments.
2948         (build_target_command_list): Update comments and skip matching
2949         locations.
2950         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
2951         a separate function.  Simplify "set breakpoint auto-hw off"
2952         handling.
2953         (insert_breakpoints): Update comment.
2954         (tracepoint_locations_match): New parameter.  For breakpoints,
2955         compare location types too, if the caller wants to.
2956         (handle_automatic_hardware_breakpoints): New functions.
2957         (bp_location_is_less_than): Also sort by location type and
2958         hardware breakpoint length.
2959         (update_global_location_list): Handle "set breakpoint auto-hw on"
2960         here.
2961         (update_breakpoint_locations): Ask breakpoint_locations_match to
2962         ignore location types.
2963
2964 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2965
2966         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
2967         type::name instead.
2968
2969 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2970
2971         * gdbtypes.h (struct type) <name, set_name>: New methods.
2972         (TYPE_CODE): Use type::name.  Change all call sites used to set
2973         the name to use type::set_name instead.
2974
2975 2020-05-16  Tom Tromey  <tom@tromey.com>
2976
2977         * top.c (quit_force): Update.
2978         * infrun.c (handle_no_resumed): Update.
2979         * top.h (all_uis): New function.
2980         (ALL_UIS): Remove.
2981
2982 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
2983
2984         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
2985
2986 2020-05-16  Pedro Alves  <palves@redhat.com>
2987
2988         * ia64-linux-nat.c
2989         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
2990         Declare method.
2991         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
2992
2993 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
2994
2995         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
2996         (sparc64_adi_info): Likewise.
2997
2998 2020-05-15  Tom Tromey  <tom@tromey.com>
2999
3000         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
3001         block_objfile.
3002         (lookup_objfile_from_block): Remove.
3003         (lookup_symbol_in_block, lookup_symbol_in_static_block)
3004         (lookup_global_symbol): Use block_objfile.
3005         * symtab.h (lookup_objfile_from_block): Don't declare.
3006         * printcmd.c (clear_dangling_display_expressions): Use
3007         block_objfile.
3008         * parse.c (operator_check_standard): Use block_objfile.
3009
3010 2020-05-15  Tom Tromey  <tom@tromey.com>
3011
3012         * language.c (language_alloc_type_symbol): Set
3013         SYMBOL_SECTION.
3014         * symtab.c (initialize_objfile_symbol): Remove.
3015         (allocate_symbol): Remove.
3016         (allocate_template_symbol): Remove.
3017         * dwarf2/read.c (fixup_go_packaging): Use "new".
3018         (new_symbol): Use "new".
3019         (read_variable): Don't call initialize_objfile_symbol.  Use
3020         "new".
3021         (read_func_scope): Use "new".
3022         * xcoffread.c (process_xcoff_symbol): Don't call
3023         initialize_objfile_symbol.
3024         (SYMBOL_DUP): Remove.
3025         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
3026         "new".
3027         * symtab.h (allocate_symbol, initialize_objfile_symbol)
3028         (allocate_template_symbol): Don't declare.
3029         (struct symbol): Add copy constructor.  Change defaults.
3030         * jit.c (finalize_symtab): Use "new".
3031         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
3032         Use "new".
3033         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
3034         (common_block_end): Use "new".
3035         * mdebugread.c (parse_symbol): Use "new".
3036         (new_symbol): Likewise.
3037
3038 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3039
3040         * NEWS: Mention changes to help and apropos.
3041
3042 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3043
3044         * command.h (enum command_class): Improve comments, document
3045         that class_alias is for user-defined aliases, give the class
3046         name for each class, remove unused class_xdb.
3047         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
3048         * breakpoint.c (_initialize_breakpoint): Replace class_alias
3049         by a precise class.
3050         * infcmd.c (_initialize_infcmd): Likewise.
3051         * reverse.c (_initialize_reverse): Likewise.
3052         * stack.c (_initialize_stack): Likewise.
3053         * symfile.c (_initialize_symfile): Likewise.
3054         * tracepoint.c (_initialize_tracepoint): Likewise.
3055
3056 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3057
3058         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
3059         when their aliased command is traversed.
3060         (help_cmd): Add fput_command_names_styled call to
3061         output command name and aliases when command has an alias.
3062
3063 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3064
3065         * cli/cli-decode.h (help_cmd_list): Remove declaration.
3066         * cli/cli-decode.c (help_cmd_list): Declare as static,
3067         remove prefix argument, use bool for recurse arg, rework to show the aliases of
3068         a command together with the command.
3069         (fput_command_name_styled, fput_command_names_styled): New functions.
3070         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
3071         fput_command_name_styled.
3072         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
3073         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
3074
3075 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3076
3077         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
3078         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
3079         * command.h (cmd_show_list): Likewise.
3080         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
3081         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
3082
3083 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3084
3085         * unittests/command-def-selftests.c (traverse_command_structure):
3086         Verify all commands of a list have the same prefix command and
3087         that only the top cmdlist commands have a null prefix.
3088
3089 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3090
3091         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
3092         as prefix, not one of its aliases.
3093         (set_cmd_prefix): Remove.
3094         (do_add_cmd): Centralize the setting of the prefix of a command, when
3095         command is defined after its full chain of prefix commands.
3096         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
3097         (add_setshow_cmd_full): Likewise.
3098         (update_prefix_field_of_prefixed_commands): New function.
3099         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
3100         update_prefix_field_of_prefixed_commands.
3101         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
3102         addresses of remote_set_cmdlist and remote_show_cmdlist given
3103         as argument, not the address of an argument.
3104         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
3105         * gdb/remote.c (_initialize_remote): Likewise.
3106
3107 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3108
3109         * cli/cli-cmds.c (alias_command): Check for an existing alias
3110         using lookup_cmd_composition, as valid_command_p is too strict
3111         and forbids aliases that are the prefix of an existing alias
3112         or command.
3113         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
3114         command is properly recognised as a valid command.
3115
3116 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3117
3118         * unittests/help-doc-selftests.c: Rename to
3119         unittests/command-def-selftests.c
3120         * unittests/command-def-selftests.c (help_doc_tests): Update some
3121         comments.
3122         (command_structure_tests, traverse_command_structure): New namespace
3123         and function.
3124         (command_structure_invariants_tests): New function.
3125         (_initialize_command_def_selftests) Renamed from
3126         _initialize_help_doc_selftests, register command_structure_invariants
3127         selftest.
3128
3129 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3130
3131         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
3132         an alias of 'show'.
3133
3134 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
3135
3136         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
3137         ada_is_fixed_point_type.  Update all callers.
3138         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
3139         all callers.
3140         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
3141         Update all callers.
3142         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
3143         print_fixed_point_type.  Update all callers.
3144         * ada-valprint.c (ada_value_print_num): Replace call to
3145         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
3146
3147 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
3148
3149         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
3150         processors.
3151         (cpu_supports_bts): Add CV_AMD case.
3152
3153 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
3154             Simon Marchi  <simon.marchi@efficios.com>
3155
3156         * infrun.c (stop_all_threads): Collect multiple wait events at
3157         each pass.
3158
3159 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3160
3161         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
3162         type::code instead.
3163
3164 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3165
3166         * gdbtypes.h (struct type) <code, set_code>: New methods.
3167         (TYPE_CODE): Use type::code.  Change all call sites used to set
3168         the code to use type::set_code instead.
3169
3170 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3171             Tom de Vries  <tdevries@suse.de>
3172             Pedro Alves  <palves@redhat.com>
3173
3174         PR threads/25478
3175         * infrun.c (stop_all_threads): Do NOT ignore
3176         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
3177         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
3178         received.
3179         (handle_no_resumed): Remove code handling a live inferior with no
3180         threads.
3181         * remote.c (has_single_non_exited_thread): New.
3182         (remote_target::update_thread_list): Do not delete a thread if is
3183         the last thread of the process.
3184         * thread.c (thread_select): Call delete_exited_threads instead of
3185         prune_threads.
3186
3187 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3188
3189         * infrun.c (stop_all_threads): Enable/disable thread events of all
3190         targets.  Move a debug message denoting the end of the function
3191         into the SCOPED_EXIT block.
3192
3193 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3194
3195         * process-stratum-target.h: Include <set>.
3196         (all_non_exited_process_targets, switch_to_target_no_thread): New
3197         function declarations.
3198         * process-stratum-target.c (all_non_exited_process_targets)
3199         (switch_to_target_no_thread): New function implementations.
3200
3201 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3202
3203         * infrun.c (handle_inferior_event): Extract out a piece of code
3204         into...
3205         (mark_non_executing_threads): ...this new function.
3206
3207 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3208
3209         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
3210         use.
3211
3212 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3213
3214         * regcache.c (regcache_read_pc_protected): New function
3215         implementation that returns 0 if the PC cannot read via
3216         'regcache_read_pc'.
3217         * infrun.c (proceed): Call 'regcache_read_pc_protected'
3218         instead of 'regcache_read_pc'.
3219         (keep_going_pass_signal): Ditto.
3220
3221 2020-05-13  Tom Tromey  <tromey@adacore.com>
3222
3223         * ada-lang.c (align_value): Remove.
3224         (ada_template_to_fixed_record_type_1): Use align_up.
3225
3226 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3227
3228         * async-event.c: Update the copyright year.
3229         * async-event.h: Update the copyright year.
3230
3231 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
3232
3233         * objfiles.h (is_addr_in_objfile,
3234         shared_objfile_contains_address_p): Return bool.
3235         * objfile.c (is_addr_in_objfile,
3236         shared_objfile_contains_address_p): Return bool.
3237
3238 2020-05-11  Tom Tromey  <tromey@adacore.com>
3239
3240         * cli/cli-cmds.c (info_command): Restore.
3241         (_initialize_cli_cmds): Use add_prefix_command for "info".
3242         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
3243
3244 2020-05-11  Tom Tromey  <tromey@adacore.com>
3245
3246         * ada-lang.c (ada_value_primitive_field): Now public.
3247         * ada-lang.h (ada_value_primitive_field): Declare.
3248         * ada-valprint.c (print_field_values): Use
3249         ada_value_primitive_field for wrapper fields.
3250
3251 2020-05-11  Tom de Vries  <tdevries@suse.de>
3252
3253         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
3254         MODULE_DOMAIN.
3255
3256 2020-05-11  Tom de Vries  <tdevries@suse.de>
3257
3258         PR symtab/25941
3259         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
3260         with length 0, if not gdb-produced.
3261         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
3262
3263 2020-05-09  Tom de Vries  <tdevries@suse.de>
3264
3265         PR gdb/25955
3266         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
3267         calculation.
3268
3269 2020-05-09  Tom Tromey  <tom@tromey.com>
3270
3271         * top.c (server_command): Now bool.
3272         * top.h (server_command): Now bool.
3273
3274 2020-05-08  Tom Tromey  <tromey@adacore.com>
3275
3276         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
3277         already being processed.
3278
3279 2020-05-08  Tom Tromey  <tom@tromey.com>
3280
3281         * printcmd.c (struct display) <next>: Remove.
3282         <display>: New constructor.
3283         <exp_string>: Now a std::string.
3284         <enabled_p>: Now a bool.
3285         (display_number): Move definition earlier.
3286         (displays): Rename from display_chain.  Now a std::vector.
3287         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
3288         (display_command): Update.
3289         (do_one_display, disable_display)
3290         (enable_disable_display_command, do_enable_disable_display):
3291         Update.
3292         (free_display): Remove.
3293         (clear_displays): Rewrite.
3294         (delete_display): Update.
3295         (map_display_numbers): Use function_view.  Remove "data"
3296         parameter.  Update.
3297         (do_delete_display): Remove.
3298         (undisplay_command): Update.
3299         (do_one_display, do_displays, disable_display)
3300         (info_display_command): Update.
3301         (do_enable_disable_display): Remove.
3302         (enable_disable_display_command)
3303         (clear_dangling_display_expressions): Update.
3304
3305 2020-05-08  Tom Tromey  <tom@tromey.com>
3306
3307         * symtab.c (set_symbol_cache_size)
3308         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
3309         (maintenance_print_symbol_cache_statistics): Update.
3310         * symmisc.c (print_symbol_bcache_statistics)
3311         (print_objfile_statistics, maintenance_print_objfiles)
3312         (maintenance_info_symtabs, maintenance_check_symtabs)
3313         (maintenance_expand_symtabs, maintenance_info_line_tables):
3314         Update.
3315         * symfile-debug.c (set_debug_symfile): Update.
3316         * source.c (forget_cached_source_info): Update.
3317         * python/python.c (gdbpy_progspaces): Update.
3318         * psymtab.c (maintenance_info_psymtabs): Update.
3319         * probe.c (parse_probes): Update.
3320         * linespec.c (iterate_over_all_matching_symtabs)
3321         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
3322         * guile/scm-progspace.c (gdbscm_progspaces): Update.
3323         * exec.c (exec_target::close): Update.
3324         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
3325         * breakpoint.c (print_one_breakpoint_location)
3326         (create_longjmp_master_breakpoint)
3327         (create_std_terminate_master_breakpoint): Update.
3328         * progspace.c (program_spaces): Now a std::vector.
3329         (maybe_new_address_space): Update.
3330         (add_program_space): Remove.
3331         (program_space::program_space): Update.
3332         (remove_program_space): Update.
3333         (number_of_program_spaces): Remove.
3334         (print_program_space, update_address_spaces): Update.
3335         * progspace.h (program_spaces): Change type.
3336         (ALL_PSPACES): Remove.
3337         (number_of_program_spaces): Don't declare.
3338         (struct program_space) <next>: Remove.
3339
3340 2020-05-08  Tom Tromey  <tom@tromey.com>
3341
3342         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
3343         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
3344         (enable_break): Update.
3345         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
3346         (frv_fdpic_find_canonical_descriptor): Update.
3347         (frv_fetch_objfile_link_map): Update.
3348         * progspace.c (program_space::free_all_objfiles): Update.
3349         (program_space::solibs): New method.
3350         * progspace.h (struct program_space) <solibs>: New method.
3351         * solist.h (master_so_list): Don't declare.
3352         (ALL_SO_LIBS): Remove.
3353         * solib.h (so_list_head): Remove.
3354         (update_solib_list): Update comment.
3355         * solib.c (master_so_list): Remove.
3356         (solib_used, update_solib_list, solib_add)
3357         (info_sharedlibrary_command, clear_solib)
3358         (reload_shared_libraries_1, remove_user_added_objfile): Update.
3359
3360 2020-05-08  Tom Tromey  <tom@tromey.com>
3361
3362         * extension.c (extension_languages): Now a std::array.
3363         (ALL_EXTENSION_LANGUAGES): Remove.
3364         (get_ext_lang_defn, get_ext_lang_of_file)
3365         (eval_ext_lang_from_control_command): Update.
3366         (finish_ext_lang_initialization)
3367         (auto_load_ext_lang_scripts_for_objfile)
3368         (ext_lang_type_printers::ext_lang_type_printers)
3369         (apply_ext_lang_type_printers)
3370         (ext_lang_type_printers::~ext_lang_type_printers)
3371         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
3372         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
3373         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
3374         (get_matching_xmethod_workers, ext_lang_colorize)
3375         (ext_lang_before_prompt): Update.
3376         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
3377
3378 2020-05-08  Tom Tromey  <tom@tromey.com>
3379
3380         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
3381         overload.
3382         <swap_string, m_string>: Remove.
3383         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
3384         Update.
3385         * stabsread.c (define_symbol, read_type): Update.
3386         * linespec.c (find_linespec_symbols): Update.
3387         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
3388         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
3389         * dbxread.c (read_dbx_symtab): Update.
3390         * cp-support.h (cp_canonicalize_string_full)
3391         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
3392         Return unique_xmalloc_ptr.
3393         * cp-support.c (inspect_type): Update.
3394         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
3395         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
3396         Likewise.
3397         * c-typeprint.c (print_name_maybe_canonical): Update.
3398         * break-catch-throw.c (check_status_exception_catchpoint):
3399         Update.
3400
3401 2020-05-08  Tom de Vries  <tdevries@suse.de>
3402
3403         * infrun.c (follow_fork): Copy current_line and current_symtab to
3404         child thread.
3405
3406 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3407
3408         * async-event.c (struct async_signal_handler, struct
3409         async_event_handler): Reformat, remove typedef.
3410
3411 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3412
3413         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
3414         access thistype->main_type->dyn_prop_list directly.
3415
3416 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3417
3418         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
3419         (remove_dyn_prop): Remove.  Update all users to use
3420         type::remove_dyn_prop.
3421         * gdbtypes.c (remove_dyn_prop): Rename to...
3422         (type::remove_dyn_prop): ... this.
3423
3424 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
3425
3426         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
3427         (add_dyn_prop): Remove.  Update all users to use
3428         type::add_dyn_prop.
3429         * gdbtypes.c (add_dyn_prop): Rename to...
3430         (type::add_dyn_prop): ... this.
3431
3432 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3433
3434         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
3435         (get_dyn_prop): Remove.  Update all users to use
3436         type::dyn_prop.
3437         * gdbtypes.c (get_dyn_prop): Rename to...
3438         (type::dyn_prop): ... this.
3439
3440 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3441
3442         * gdbtypes.h (struct main_type) <flag_static>: Remove.
3443
3444 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3445
3446         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
3447         instruction, skip it if it's there.
3448
3449 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
3450
3451         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
3452
3453 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
3454
3455         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
3456         * gdbtypes.c (recursive_dump_type): Remove use of
3457         TYPE_INCOMPLETE.
3458
3459 2020-05-03  Tom Tromey  <tom@tromey.com>
3460
3461         * breakpoint.c (catch_command, tcatch_command): Remove.
3462         (_initialize_breakpoint): Use add_basic_prefix_cmd,
3463         add_show_prefix_cmd.
3464         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
3465         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
3466         Remove.
3467         (add_internal_problem_command): Use add_basic_prefix_cmd,
3468         add_show_prefix_cmd.
3469         * mips-tdep.c (set_mipsfpu_command): Remove.
3470         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
3471         * dwarf2/index-cache.c (set_index_cache_command): Remove.
3472         (_initialize_index_cache): Use add_basic_prefix_cmd.
3473         * memattr.c (dummy_cmd): Remove.
3474         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
3475         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
3476         (_initialize_tui_win): Use add_basic_prefix_cmd,
3477         add_show_prefix_cmd.
3478         * cli/cli-logging.c (set_logging_command): Remove.
3479         (_initialize_cli_logging): Use add_basic_prefix_cmd,
3480         add_show_prefix_cmd.
3481         (show_logging_command): Remove.
3482         * target.c (target_command): Remove.
3483         (add_target): Use add_basic_prefix_cmd.
3484
3485 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
3486
3487         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
3488
3489 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3490
3491         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
3492         info_command.
3493
3494 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
3495
3496         * nbsd-nat.c (nbsd_enable_proc_events)
3497         (nbsd_nat_target::post_startup_inferior): Add.
3498         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
3499         (nbsd_nat_target::update_thread_list): Rewrite.
3500         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
3501         "PTRACE_LWP_CREATE".
3502         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
3503
3504 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3505
3506         * stack.c (_initialize_stack): Remove duplicated creation
3507         of "frame" command and "f" alias.
3508
3509 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3510
3511         PR gdb/18706
3512         * gdbtypes.c (check_typedef): Calculate size of array of
3513         stubbed type.
3514
3515 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3516
3517         PR gdb/15559
3518         * i386-tdep.c (i386_push_dummy_call): Call
3519         i386_thiscall_push_dummy_call.
3520         (i386_thiscall_push_dummy_call): New function.
3521         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
3522         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
3523         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
3524
3525 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3526
3527         * gdbarch.sh (do_read): Add shellcheck disable directive for
3528         warning SC2162.
3529
3530 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3531
3532         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3533         "referenced but not assigned" warning.
3534
3535 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3536
3537         * gdbarch.sh: Remove code that sets fallbackdefault.
3538
3539 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3540
3541         * gdbarch.sh: Use shell operators && and || instead of
3542         -a and -o.
3543
3544 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3545
3546         * gdbarch.sh: Use $(...) instead of `...`.
3547
3548 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3549
3550         * gdbarch.sh: Use double quotes around variables.
3551
3552 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3553
3554         * gdbarch.sh: Use %s with printf, instead of variables in the
3555         format string.
3556
3557 2020-04-29  Tom Tromey  <tromey@adacore.com>
3558
3559         PR ada/25875:
3560         * dwarf2/read.c (update_enumeration_type_from_children): Compute
3561         type fields here.
3562         (read_enumeration_type): Call
3563         update_enumeration_type_from_children later.  Update comments.
3564         (process_enumeration_scope): Don't create type fields.
3565
3566 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3567
3568         * nbsd-tdep.c: Include "xml-syscall.h".
3569         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
3570
3571 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
3572
3573         * nbsd-nat.c: Include "sys/wait.h".
3574         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
3575         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
3576         (nbsd_nat_target::remove_exec_catchpoint)
3577         (nbsd_nat_target::set_syscall_catchpoint): Add.
3578         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
3579         (nbsd_nat_target::insert_exec_catchpoint)
3580         (nbsd_nat_target::remove_exec_catchpoint)
3581         (nbsd_nat_target::set_syscall_catchpoint): Add.
3582         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
3583         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
3584         `nbsd_get_syscall_number'.
3585
3586 2020-04-29  Tom Tromey  <tom@tromey.com>
3587
3588         * stack.c (print_block_frame_labels): Remove.
3589
3590 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
3591
3592         PR gdb/17320
3593         * ada-valprint.c (val_print_packed_array_elements): Move array
3594         end bracket to new line.
3595         (ada_val_print_string): Remove extra spaces before first array
3596         element.
3597         * c-valprint.c (c_value_print_array): Likewise.
3598         * m2-valprint.c (m2_print_array_contents): Likewise.
3599         (m2_value_print_inner): Likewise.
3600         * p-valprint.c (pascal_value_print_inner): Likewise.
3601         * valprint.c (generic_val_print_array): Likewise.
3602         (value_print_array_elements): Move first array element and array
3603         end bracket to new line.
3604
3605 2020-04-29  Tom de Vries  <tdevries@suse.de>
3606
3607         PR symtab/25889
3608         * linespec.c (find_method): Fix ix calculation.
3609
3610 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
3611
3612         * syscalls/update-netbsd.sh: New file.
3613         * syscalls/netbsd.xml: Regenerate.
3614         * data-directory/Makefile.in: Register `netbsd.xml' in
3615         `SYSCALLS_FILES'.
3616
3617 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3618
3619         * syscalls/update-freebsd.sh: Add double quotes.
3620
3621 2020-04-28  Tom Tromey  <tom@tromey.com>
3622
3623         * NEWS: Update.
3624         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
3625         (cmdpy_init): Allow class_tui.
3626
3627 2020-04-28 Mark Williams <mark@myosotissp.com>
3628
3629         PR gdb/24480
3630         * dwarf2read.c: Add missing assingments to list_in_scope when
3631         start_symtab was already called.
3632
3633 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
3634
3635         PR gdb/25881
3636         * dwarf2/read.c (offset_map_type): Use
3637         gdb:hash_enum<sect_offset> as hash function.
3638
3639 2020-04-28  Tom de Vries  <tdevries@suse.de>
3640
3641         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
3642         with DW_AT_signature.
3643
3644 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
3645
3646         * configure.ac: Remove check for fs_base/gs_base in
3647         user_regs_struct.
3648         * configure: Re-generate.
3649         * config.in: Re-generate.
3650         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
3651         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
3652         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
3653
3654 2020-04-27  Luis Machado  <luis.machado@linaro.org>
3655
3656         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
3657         problematic inline frame unwinding situation.
3658         * frame.c (frame_id_computed_p): New function.
3659         * frame.h (frame_id_computed_p): New prototype.
3660
3661 2020-04-26  Tom Tromey  <tom@tromey.com>
3662
3663         * command.h (enum command_class) <class_pseudo>: Remove.
3664
3665 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3666
3667         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
3668         and whitespace.
3669
3670 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
3671
3672         * inf-ptrace.c (inf_ptrace_target::wait): Remove
3673         `PT_GET_PROCESS_STATE' block.
3674
3675 2020-04-24  Tom Tromey  <tom@tromey.com>
3676
3677         * symtab.h (symbol_get_demangled_name): Don't declare.
3678         * symtab.c (symbol_get_demangled_name): Remove.
3679         (general_symbol_info::natural_name)
3680         (general_symbol_info::demangled_name): Update.
3681
3682 2020-04-24  Tom Tromey  <tom@tromey.com>
3683
3684         PR rust/25025:
3685         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
3686
3687 2020-04-24  Tom Tromey  <tom@tromey.com>
3688
3689         PR symtab/12707:
3690         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
3691         exists.
3692         (new_symbol): Likewise.
3693         * compile/compile-object-load.c (get_out_value_type): Use
3694         symbol_matches_search_name.
3695
3696 2020-04-24  Tom Tromey  <tom@tromey.com>
3697
3698         * dwarf2/read.c (add_partial_symbol): Do not call
3699         compute_and_set_names.
3700
3701 2020-04-24  Tom Tromey  <tom@tromey.com>
3702
3703         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
3704         overload.
3705
3706 2020-04-24  Tom Tromey  <tom@tromey.com>
3707
3708         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
3709         (add_psymbol_to_list): New overload.  Make old overload call new
3710         one.
3711         * psympriv.h (add_psymbol_to_list): New overload.
3712
3713 2020-04-24  Tom Tromey  <tom@tromey.com>
3714
3715         * dwarf2/read.c (partial_die_info::read) <case
3716         DW_AT_linkage_name>: Use value_as_string.
3717         (dwarf2_string_attr): Use value_as_string.
3718         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
3719         method.
3720         * dwarf2/attribute.c (attribute::value_as_string): New method.
3721
3722 2020-04-24  Tom Tromey  <tom@tromey.com>
3723
3724         * symtab.c (general_symbol_info::natural_name)
3725         (general_symbol_info::demangled_name): Check for language_rust.
3726
3727 2020-04-24  Tom Tromey  <tom@tromey.com>
3728
3729         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
3730         (dwarf2_physname): ... from here.
3731         (partial_die_info::read): Add Rust "{" hack.
3732
3733 2020-04-24  Tom Tromey  <tom@tromey.com>
3734
3735         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
3736         method.
3737         (symbol_set_demangled_name): Don't declare.
3738         * symtab.c (general_symbol_info::set_demangled_name): Rename from
3739         symbol_set_demangled_name.
3740         (general_symbol_info::set_language)
3741         (general_symbol_info::compute_and_set_names): Update.
3742         * minsyms.c (minimal_symbol_reader::install): Update.
3743         * dwarf2/read.c (new_symbol): Update.
3744
3745 2020-04-24  Tom Tromey  <tromey@adacore.com>
3746
3747         PR python/23662:
3748         * python/py-type.c (convert_field): Handle
3749         FIELD_LOC_KIND_DWARF_BLOCK.
3750         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
3751         (typy_get_dynamic): Nw function.
3752         (type_object_getset): Add "dynamic".
3753         * NEWS: Add entry.
3754
3755 2020-04-24  Tom Tromey  <tromey@adacore.com>
3756
3757         * ada-typeprint.c (print_choices, print_variant_part)
3758         (print_record_field_types_dynamic): New functions.
3759         (print_record_field_types): Use print_record_field_types_dynamic.
3760
3761 2020-04-24  Tom Tromey  <tromey@adacore.com>
3762
3763         * dwarf2/read.c (handle_data_member_location): New overload.
3764         (dwarf2_add_field): Use it.
3765         (decode_locdesc): Add "computed" parameter.  Update comment.
3766         * gdbtypes.c (is_dynamic_type_internal): Also look for
3767         FIELD_LOC_KIND_DWARF_BLOCK.
3768         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
3769         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
3770         virtual base classes.
3771         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
3772         FIELD_LOC_KIND_DWARF_BLOCK.
3773
3774 2020-04-24  Tom Tromey  <tromey@adacore.com>
3775
3776         * dwarf2/read.c (read_structure_type): Handle dynamic length.
3777         * gdbtypes.c (is_dynamic_type_internal): Check
3778         TYPE_HAS_DYNAMIC_LENGTH.
3779         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
3780         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
3781         New macros.
3782         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
3783         constant.
3784
3785 2020-04-24  Tom Tromey  <tromey@adacore.com>
3786
3787         * dwarf2/read.c (struct variant_field): Rewrite.
3788         (struct variant_part_builder): New.
3789         (struct nextfield): Remove "variant" field.  Add "offset".
3790         (struct field_info): Add "current_variant_part" and
3791         "variant_parts".
3792         (alloc_discriminant_info): Remove.
3793         (alloc_rust_variant): New function.
3794         (quirk_rust_enum): Update.
3795         (dwarf2_add_field): Set "offset" member.  Don't handle
3796         DW_TAG_variant_part.
3797         (offset_map_type): New typedef.
3798         (convert_variant_range, create_one_variant)
3799         (create_one_variant_part, create_variant_parts)
3800         (add_variant_property): New functions.
3801         (dwarf2_attach_fields_to_type): Call add_variant_property.
3802         (read_structure_type): Don't handle DW_TAG_variant_part.
3803         (handle_variant_part, handle_variant): New functions.
3804         (handle_struct_member_die): Use them.
3805         (process_structure_scope): Don't handle variant parts.
3806         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
3807         (struct discriminant_info): Remove.
3808         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
3809         (struct main_type) <flag_discriminated_union>: Remove.
3810         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
3811         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
3812         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
3813         Update.
3814         * valops.c (value_union_variant): Remove.
3815         * value.h (value_union_variant): Don't declare.
3816
3817 2020-04-24  Tom Tromey  <tromey@adacore.com>
3818
3819         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
3820         (ada_value_primitive_packed_val): Update.
3821         * ada-valprint.c (ada_value_print_1): Update.
3822         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
3823         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
3824         just an address.  Use evaluate_for_locexpr_baton.
3825         (dwarf2_evaluate_property): Update.
3826         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
3827         array_view.
3828         * findvar.c (default_read_var_value): Update.
3829         * gdbtypes.c (compute_variant_fields_inner)
3830         (resolve_dynamic_type_internal): Update.
3831         (resolve_dynamic_type): Change type of valaddr parameter.
3832         * gdbtypes.h (resolve_dynamic_type): Update.
3833         * valarith.c (value_subscripted_rvalue): Update.
3834         * value.c (value_from_contents_and_address): Update.
3835
3836 2020-04-24  Tom Tromey  <tromey@adacore.com>
3837
3838         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
3839         "push_initial_value" parameter.
3840         (dwarf2_evaluate_property): Likewise.
3841         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
3842
3843 2020-04-24  Tom Tromey  <tromey@adacore.com>
3844
3845         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
3846         (variant::matches, compute_variant_fields_recurse)
3847         (compute_variant_fields_inner, compute_variant_fields): New
3848         functions.
3849         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
3850         Use resolved_type after type is made.
3851         (operator==): Add new cases.
3852         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
3853         (struct discriminant_range, struct variant, struct variant_part):
3854         New.
3855         (union dynamic_prop_data) <variant_parts, original_type>: New
3856         members.
3857         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
3858         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
3859         constants.
3860         * value.c (unpack_bits_as_long): Now public.
3861         * value.h (unpack_bits_as_long): Declare.
3862
3863 2020-04-24  Tom Tromey  <tromey@adacore.com>
3864
3865         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
3866         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
3867
3868 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
3869
3870         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
3871
3872 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
3873
3874         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
3875         (remove_fork_catchpoint, post_startup_inferior)
3876         (post_attach): Move...
3877         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
3878         (remove_fork_catchpoint, post_startup_inferior)
3879         (post_attach): ...here.
3880         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
3881         (remove_fork_catchpoint, post_startup_inferior)
3882         (post_attach): Move...
3883         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
3884         (remove_fork_catchpoint, post_startup_inferior)
3885         (post_attach): ...here.
3886
3887 2020-04-24  Tom Tromey  <tromey@adacore.com>
3888
3889         * nat/windows-nat.h (struct windows_thread_info)
3890         <pc_adjusted>: New member.
3891         * windows-nat.c (windows_fetch_one_register): Check
3892         pc_adjusted.
3893         (windows_nat_target::get_windows_debug_event)
3894         (windows_nat_target::wait): Set pc_adjusted.
3895
3896 2020-04-24  Tom de Vries  <tdevries@suse.de>
3897
3898         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
3899         Run gdb-add-index inside temp dir.
3900
3901 2020-04-23  Tom Tromey  <tromey@adacore.com>
3902
3903         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
3904         in loop.
3905
3906 2020-04-23  Luis Machado  <luis.machado@linaro.org>
3907
3908         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
3909         get_frame_register instead of gdbarch_unwind_pc.
3910
3911 2020-04-23  Tom de Vries  <tdevries@suse.de>
3912
3913         * symtab.c (lookup_global_symbol): Prefer def over decl.
3914
3915 2020-04-23  Tom de Vries  <tdevries@suse.de>
3916
3917         PR symtab/25807
3918         * block.c (best_symbol, better_symbol): Promote to external.
3919         * block.h (best_symbol, better_symbol): Declare.
3920         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
3921         decl.
3922
3923 2020-04-23  Tom Tromey  <tromey@adacore.com>
3924
3925         PR ada/25837:
3926         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
3927         "const char *", not a "const std::string &".
3928         <name_and_matcher::operator==>: Update.
3929         * unittests/lookup_name_info-selftests.c: Change type of
3930         "result".
3931
3932 2020-04-23  Tom Tromey  <tom@tromey.com>
3933
3934         * inferior.h (iterate_over_inferiors): Don't declare.
3935         * inferior.c (iterate_over_inferiors): Remove.
3936         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
3937         Remove.
3938         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
3939         use iterate_over_inferiors.
3940         (darwin_resume_inferior_it)
3941         (struct resume_inferior_threads_param)
3942         (darwin_resume_inferior_threads_it): Remove.
3943         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
3944
3945 2020-04-23  Tom de Vries  <tdevries@suse.de>
3946
3947         * blockframe.c (find_pc_partial_function): Use
3948         find_pc_sect_compunit_symtab rather than
3949         objfile->sf->qf->find_pc_sect_compunit_symtab.
3950
3951 2020-04-22  Tom de Vries  <tdevries@suse.de>
3952
3953         PR symtab/25764
3954         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
3955         in psymtabs.
3956
3957 2020-04-22  Tom de Vries  <tdevries@suse.de>
3958
3959         PR symtab/25801
3960         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
3961         symtabs.
3962
3963 2020-04-22  Tom de Vries  <tdevries@suse.de>
3964
3965         PR symtab/25700
3966         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
3967         CU if already created.
3968
3969 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3970
3971         * infrun.c (displaced_step_fixup): Switch to the event_thread
3972         before calling displaced_step_restore, not after.
3973
3974 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3975
3976         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
3977         its inferior is not recorded by us.
3978         (record_btrace_target_open): Replace call to
3979         all_non_exited_threads () with call to current_inferior
3980         ()->non_exited_threads ().
3981         (record_btrace_target::stop_recording): Likewise.
3982         (record_btrace_target::close): Likewise.
3983         (record_btrace_target::wait): Likewise.
3984         (record_btrace_target::record_stop_replaying): Likewise.
3985
3986 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3987
3988         * btrace.c (btrace_enable): Throw an error on double enables and
3989         when enabling recording fails.
3990         (btrace_disable): Throw an error if the thread is not recorded.
3991
3992 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
3993
3994         * record-btrace.c (record_btrace_target::fetch_registers): Forward
3995         request if we do not have a thread_info.
3996
3997 2020-04-21  Tom de Vries  <tdevries@suse.de>
3998
3999         PR gdb/25471
4000         * thread.c
4001         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
4002         exception in get_frame_id.
4003
4004 2020-04-20  Tom Tromey  <tromey@adacore.com>
4005
4006         * python/python.c (struct gdbpy_event): Mark move constructor as
4007         noexcept.
4008         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
4009         constructor as noexcept.
4010         * completer.h (struct completion_result): Mark move constructor as
4011         noexcept.
4012         * completer.c (completion_result::completion_result): Use
4013         initialization style.  Don't call reset_match_list.
4014
4015 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
4016
4017         * MAINTAINERS (Write After Approval): Add myself.
4018
4019 2020-04-18  Tom Tromey  <tom@tromey.com>
4020
4021         * windows-tdep.c (init_w32_command_list)
4022         (w32_prefix_command_valid): Restore.
4023         (_initialize_windows_tdep): Call init_w32_command_list.
4024
4025 2020-04-18  Tom Tromey  <tom@tromey.com>
4026
4027         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
4028         * value.c (value_fn_field): Update.
4029         * valops.c (find_function_in_inferior)
4030         (value_allocate_space_in_inferior): Update.
4031         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4032         Update.
4033         * tui/tui-source.c (tui_source_window::set_contents): Update.
4034         * symtab.c (lookup_global_or_static_symbol)
4035         (find_function_start_sal_1, skip_prologue_sal)
4036         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
4037         * symmisc.c (dump_msymbols, dump_symtab_1)
4038         (maintenance_print_one_line_table): Update.
4039         * symfile.c (init_entry_point_info, section_is_mapped)
4040         (list_overlays_command, simple_read_overlay_table)
4041         (simple_overlay_update_1): Update.
4042         * stap-probe.c (handle_stap_probe): Update.
4043         * stabsread.c (dbx_init_float_type, define_symbol)
4044         (read_one_struct_field, read_enum_type, read_range_type): Update.
4045         * source.c (info_line_command): Update.
4046         * python/python.c (gdbpy_source_objfile_script)
4047         (gdbpy_execute_objfile_script): Update.
4048         * python/py-type.c (save_objfile_types): Update.
4049         * python/py-objfile.c (py_free_objfile): Update.
4050         * python/py-inferior.c (python_new_objfile): Update.
4051         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
4052         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
4053         (maintenance_check_psymtabs): Update.
4054         * printcmd.c (info_address_command): Update.
4055         * objfiles.h (struct objfile) <arch>: New method, from
4056         get_objfile_arch.
4057         (get_objfile_arch): Don't declare.
4058         * objfiles.c (get_objfile_arch): Remove.
4059         (filter_overlapping_sections): Update.
4060         * minsyms.c (msymbol_is_function): Update.
4061         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
4062         (output_nondebug_symbol): Update.
4063         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
4064         (mdebug_expand_psymtab): Update.
4065         * machoread.c (macho_add_oso_symfile): Update.
4066         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
4067         Update.
4068         * linux-fork.c (checkpoint_command): Update.
4069         * linespec.c (convert_linespec_to_sals): Update.
4070         * jit.c (finalize_symtab): Update.
4071         * infrun.c (insert_exception_resume_from_probe): Update.
4072         * ia64-tdep.c (ia64_find_unwind_table): Update.
4073         * hppa-tdep.c (internalize_unwinds): Update.
4074         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
4075         Update.
4076         * gcore.c (call_target_sbrk): Update.
4077         * elfread.c (record_minimal_symbol, elf_symtab_read)
4078         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
4079         (elf_gnu_ifunc_resolve_by_got): Update.
4080         * dwarf2/read.c (create_addrmap_from_index)
4081         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4082         (read_debug_names_from_section)
4083         (process_psymtab_comp_unit_reader, add_partial_symbol)
4084         (add_partial_subprogram, process_full_comp_unit)
4085         (read_file_scope, read_func_scope, read_lexical_block_scope)
4086         (read_call_site_scope, dwarf2_ranges_read)
4087         (dwarf2_record_block_ranges, dwarf2_add_field)
4088         (mark_common_block_symbol_computed, read_tag_pointer_type)
4089         (read_tag_string_type, dwarf2_init_float_type)
4090         (dwarf2_init_complex_target_type, read_base_type)
4091         (partial_die_info::read, partial_die_info::read)
4092         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
4093         (dwarf2_fetch_die_loc_sect_off): Update.
4094         * dwarf2/loc.c (dwarf2_find_location_expression)
4095         (class dwarf_evaluate_loc_desc, rw_pieced_value)
4096         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
4097         (dwarf2_loc_desc_get_symbol_read_needs)
4098         (locexpr_describe_location_piece, locexpr_describe_location_1)
4099         (loclist_describe_location): Update.
4100         * dwarf2/index-write.c (write_debug_names): Update.
4101         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
4102         * dtrace-probe.c (dtrace_process_dof): Update.
4103         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
4104         (process_one_symbol): Update.
4105         * ctfread.c (ctf_init_float_type, read_base_type): Update.
4106         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
4107         (coff_read_enum_type): Update.
4108         * cli/cli-cmds.c (edit_command, list_command): Update.
4109         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
4110         * breakpoint.c (create_overlay_event_breakpoint)
4111         (create_longjmp_master_breakpoint)
4112         (create_std_terminate_master_breakpoint)
4113         (create_exception_master_breakpoint, get_sal_arch): Update.
4114         * block.c (block_gdbarch): Update.
4115         * annotate.c (annotate_source_line): Update.
4116
4117 2020-04-17  Tom Tromey  <tromey@adacore.com>
4118
4119         * auto-load.c (show_auto_load_cmd): Remove.
4120         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
4121         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
4122         (maintenance_print_arc_command): Remove.
4123         * tui/tui-win.c (tui_command): Remove.
4124         (tui_get_cmd_list): Use add_basic_prefix_cmd.
4125         * tui/tui-layout.c (tui_layout_command): Remove.
4126         (_initialize_tui_layout): Use add_basic_prefix_cmd.
4127         * python/python.c (user_set_python, user_show_python): Remove.
4128         (_initialize_python): Use add_basic_prefix_cmd,
4129         add_show_prefix_cmd.
4130         * guile/guile.c (set_guile_command, show_guile_command): Remove.
4131         (install_gdb_commands): Use add_basic_prefix_cmd,
4132         add_show_prefix_cmd.
4133         (info_guile_command): Remove.
4134         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
4135         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
4136         add_show_prefix_cmd.
4137         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
4138         Remove do_set and do_show parameters.
4139         * cli/cli-style.c (set_style, show_style): Remove.
4140         (_initialize_cli_style): Use add_basic_prefix_cmd,
4141         add_show_prefix_cmd.
4142         (cli_style_option::add_setshow_commands): Remove do_set and
4143         do_show parameters.
4144         (cli_style_option::add_setshow_commands): Use
4145         add_basic_prefix_cmd, add_show_prefix_cmd.
4146         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
4147         (set_style_name): Remove.
4148         * cli/cli-dump.c (dump_command, append_command): Remove.
4149         (srec_dump_command, ihex_dump_command, verilog_dump_command)
4150         (tekhex_dump_command, binary_dump_command)
4151         (binary_append_command): Remove.
4152         (_initialize_cli_dump): Use add_basic_prefix_cmd.
4153         * windows-tdep.c (w32_prefix_command_valid): Remove global.
4154         (init_w32_command_list): Remove; move into ...
4155         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
4156         * valprint.c (set_print, show_print, set_print_raw)
4157         (show_print_raw): Remove.
4158         (_initialize_valprint): Use add_basic_prefix_cmd,
4159         add_show_prefix_cmd.
4160         * typeprint.c (set_print_type, show_print_type): Remove.
4161         (_initialize_typeprint): Use add_basic_prefix_cmd,
4162         add_show_prefix_cmd.
4163         * record.c (set_record_command, show_record_command): Remove.
4164         (_initialize_record): Use add_basic_prefix_cmd,
4165         add_show_prefix_cmd.
4166         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
4167         add_show_prefix_cmd.
4168         (info_command, show_command, set_debug, show_debug): Remove.
4169         * top.h (set_history, show_history): Don't declare.
4170         * top.c (set_history, show_history): Remove.
4171         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
4172         (unset_tdesc_cmd): Remove.
4173         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
4174         add_show_prefix_cmd.
4175         * symtab.c (info_module_command): Remove.
4176         (_initialize_symtab): Use add_basic_prefix_cmd.
4177         * symfile.c (overlay_command): Remove.
4178         (_initialize_symfile): Use add_basic_prefix_cmd.
4179         * sparc64-tdep.c (info_adi_command): Remove.
4180         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
4181         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
4182         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
4183         add_show_prefix_cmd.
4184         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
4185         (_initialize_serial): Use add_basic_prefix_cmd,
4186         add_show_prefix_cmd.
4187         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
4188         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
4189         add_show_prefix_cmd.
4190         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
4191         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
4192         add_show_prefix_cmd.
4193         * riscv-tdep.c (show_riscv_command, set_riscv_command)
4194         (show_debug_riscv_command, set_debug_riscv_command): Remove.
4195         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
4196         add_show_prefix_cmd.
4197         * remote.c (remote_command, set_remote_cmd): Remove.
4198         (_initialize_remote): Use add_basic_prefix_cmd.
4199         * record-full.c (set_record_full_command)
4200         (show_record_full_command): Remove.
4201         (_initialize_record_full): Use add_basic_prefix_cmd,
4202         add_show_prefix_cmd.
4203         * record-btrace.c (cmd_set_record_btrace)
4204         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
4205         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
4206         (cmd_show_record_btrace_pt): Remove.
4207         (_initialize_record_btrace): Use add_basic_prefix_cmd,
4208         add_show_prefix_cmd.
4209         * ravenscar-thread.c (set_ravenscar_command)
4210         (show_ravenscar_command): Remove.
4211         (_initialize_ravenscar): Use add_basic_prefix_cmd,
4212         add_show_prefix_cmd.
4213         * mips-tdep.c (show_mips_command, set_mips_command)
4214         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
4215         add_show_prefix_cmd.
4216         * maint.c (maintenance_command, maintenance_info_command)
4217         (maintenance_check_command, maintenance_print_command)
4218         (maintenance_set_cmd, maintenance_show_cmd): Remove.
4219         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
4220         add_show_prefix_cmd.
4221         (show_per_command_cmd): Remove.
4222         * maint-test-settings.c (maintenance_set_test_settings_cmd):
4223         Remove.
4224         (maintenance_show_test_settings_cmd): Remove.
4225         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
4226         add_show_prefix_cmd.
4227         * maint-test-options.c (maintenance_test_options_command):
4228         Remove.
4229         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
4230         * macrocmd.c (macro_command): Remove
4231         (_initialize_macrocmd): Use add_basic_prefix_cmd.
4232         * language.c (set_check, show_check): Remove.
4233         (_initialize_language): Use add_basic_prefix_cmd,
4234         add_show_prefix_cmd.
4235         * infcmd.c (unset_command): Remove.
4236         (_initialize_infcmd): Use add_basic_prefix_cmd.
4237         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
4238         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
4239         add_show_prefix_cmd.
4240         * go32-nat.c (go32_info_dos_command): Remove.
4241         (_initialize_go32_nat): Use add_basic_prefix_cmd.
4242         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
4243         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
4244         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
4245         (_initialize_frame): Use add_basic_prefix_cmd,
4246         add_show_prefix_cmd.
4247         * dcache.c (set_dcache_command, show_dcache_command): Remove.
4248         (_initialize_dcache): Use add_basic_prefix_cmd,
4249         add_show_prefix_cmd.
4250         * cp-support.c (maint_cplus_command): Remove.
4251         (_initialize_cp_support): Use add_basic_prefix_cmd.
4252         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
4253         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
4254         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
4255         add_basic_prefix_cmd, add_show_prefix_cmd.
4256         * breakpoint.c (save_command): Remove.
4257         (_initialize_breakpoint): Use add_basic_prefix_cmd.
4258         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
4259         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
4260         add_show_prefix_cmd.
4261         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
4262         (set_ada_command, show_ada_command): Remove.
4263         (_initialize_ada_language): Use add_basic_prefix_cmd,
4264         add_show_prefix_cmd.
4265         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
4266
4267 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
4268
4269         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
4270         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
4271
4272 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4273
4274         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
4275         warning messages.
4276
4277 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4278
4279         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
4280         import table is not at beginning of .idata section.
4281
4282 2020-04-16  Pedro Alves  <palves@redhat.com>
4283
4284         * inferior.c (delete_inferior): Use delete operator directly
4285         instead of delete_program_space.
4286         * progspace.c (add_program_space): New, factored out from
4287         program_space::program_space.
4288         (remove_program_space): New, factored out from
4289         delete_program_space.
4290         (program_space::program_space): Remove intro comment.  Rewrite.
4291         (program_space::~program_space): Remove intro comment.  Call
4292         remove_program_space.
4293         (delete_program_space): Delete.
4294         * progspace.h (program_space::program_space): Make explicit.  Move
4295         intro comment here, adjusted.
4296         (program_space::~program_space): Move intro comment here,
4297         adjusted.
4298         (delete_program_space): Remove.
4299
4300 2020-04-16  Tom Tromey  <tromey@adacore.com>
4301
4302         * windows-nat.c (windows_nat::handle_access_violation): New
4303         function.
4304         * nat/windows-nat.h (handle_access_violation): Declare.
4305         * nat/windows-nat.c (handle_exception): Move Cygwin code to
4306         windows-nat.c.  Call handle_access_violation.
4307
4308 2020-04-16  Tom de Vries  <tdevries@suse.de>
4309
4310         PR symtab/25791
4311         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
4312         CUs without psymtab.
4313
4314 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
4315
4316         * python/python.c (do_start_initialization): Don't call
4317         PyEval_InitThreads for Python 3.9 and beyond.
4318
4319 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
4320
4321         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
4322         thread functions.
4323         (obsd_nat_target::wait): Likewise.
4324
4325 2020-04-15  Tom Tromey  <tromey@adacore.com>
4326
4327         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
4328         (DEBUG_EXCEPT): Use debug_printf.
4329
4330 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4331
4332         * completer.c (class completion_tracker::completion_hash_entry)
4333         <hash_name>: New member function.
4334         (completion_tracker::discard_completions): New callback to hash a
4335         completion_hash_entry, pass this to htab_create_alloc.
4336
4337 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
4338
4339         * windows-nat.c (windows_make_so): Warn rather than stopping with
4340         an error if realpath() fails.
4341
4342 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
4343
4344         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
4345         (nbsd_nat_target::info_proc): Add do_status.
4346
4347 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
4348             Tom de Vries  <tdevries@suse.de>
4349
4350         PR symtab/25718
4351         * psympriv.h (struct partial_symtab::read_symtab)
4352         (struct partial_symtab::expand_psymtab)
4353         (struct partial_symtab::read_dependencies): Update comments.
4354         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
4355         read_symtab for includer.
4356         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
4357         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
4358         (struct dwarf2_include_psymtab::m_readin): Remove.
4359         (struct dwarf2_include_psymtab::includer): New member function.
4360         (dwarf2_psymtab::expand_psymtab): Assert !readin.
4361
4362 2020-04-14  Tom de Vries  <tdevries@suse.de>
4363
4364         PR symtab/25720
4365         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
4366         with NULL symbol_matcher and lookup_name.
4367         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
4368         and lookup_name.
4369         * dwarf2/read.c (dw2_expand_symtabs_matching)
4370         (dw2_debug_names_expand_symtabs_matching): Same.
4371         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
4372         Make lookup_name a pointer.  Update comment.
4373         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
4374         lookup_name being a pointer.
4375         * symfile.c (expand_symtabs_matching): Same.
4376         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
4377         * linespec.c (iterate_over_all_matching_symtabs): Same.
4378
4379 2020-04-13  Tom Tromey  <tom@tromey.com>
4380
4381         * run-on-main-thread.c: Update include.
4382         * unittests/main-thread-selftests.c: Update include.
4383         * tui/tui-win.c: Update include.
4384         * tui/tui-io.c: Update include.
4385         * tui/tui-interp.c: Update include.
4386         * tui/tui-hooks.c: Update include.
4387         * top.h: Update include.
4388         * top.c: Update include.
4389         * ser-base.c: Update include.
4390         * remote.c: Update include.
4391         * remote-notif.c: Update include.
4392         * remote-fileio.c: Update include.
4393         * record-full.c: Update include.
4394         * record-btrace.c: Update include.
4395         * python/python.c: Update include.
4396         * posix-hdep.c: Update include.
4397         * mingw-hdep.c: Update include.
4398         * mi/mi-main.c: Update include.
4399         * mi/mi-interp.c: Update include.
4400         * main.c: Update include.
4401         * linux-nat.c: Update include.
4402         * interps.c: Update include.
4403         * infrun.c: Update include.
4404         * inf-loop.c: Update include.
4405         * event-top.c: Update include.
4406         * event-loop.c: Move to ../gdbsupport/.
4407         * event-loop.h: Move to ../gdbsupport/.
4408         * async-event.h: Update include.
4409         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
4410
4411 2020-04-13  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui-win.c: Include async-event.h.
4414         * remote.c: Include async-event.h.
4415         * remote-notif.c: Include async-event.h.
4416         * record-full.c: Include async-event.h.
4417         * record-btrace.c: Include async-event.h.
4418         * infrun.c: Include async-event.h.
4419         * event-top.c: Include async-event.h.
4420         * event-loop.h: Move some declarations to async-event.h.
4421         * event-loop.c: Don't include ser-event.h or top.h.  Move some
4422         code to async-event.c.
4423         * async-event.h: New file.
4424         * async-event.c: New file.
4425         * Makefile.in (COMMON_SFILES): Add async-event.c.
4426         (HFILES_NO_SRCDIR): Add async-event.h.
4427
4428 2020-04-13  Tom Tromey  <tom@tromey.com>
4429
4430         * utils.c (flush_streams): New function.
4431         * event-loop.c (gdb_wait_for_event): Call flush_streams.
4432
4433 2020-04-13  Tom Tromey  <tom@tromey.com>
4434
4435         * event-loop.c (handle_file_event): Use warning, not
4436         printf_unfiltered.
4437
4438 2020-04-13  Tom Tromey  <tom@tromey.com>
4439
4440         * event-loop.c: Include <chrono>.
4441
4442 2020-04-13  Tom Tromey  <tom@tromey.com>
4443
4444         * gdb_select.h: Move to ../gdbsupport/.
4445         * event-loop.c: Update include path.
4446         * top.c: Update include path.
4447         * ser-base.c: Update include path.
4448         * ui-file.c: Update include path.
4449         * ser-tcp.c: Update include path.
4450         * guile/scm-ports.c: Update include path.
4451         * posix-hdep.c: Update include path.
4452         * ser-unix.c: Update include path.
4453         * gdb_usleep.c: Update include path.
4454         * mingw-hdep.c: Update include path.
4455         * inflow.c: Update include path.
4456         * infrun.c: Update include path.
4457         * event-top.c: Update include path.
4458
4459 2020-04-13  Tom Tromey  <tom@tromey.com>
4460
4461         * configure: Rebuild.
4462         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
4463
4464 2020-04-13  Tom Tromey  <tom@tromey.com>
4465
4466         * event-loop.h (start_event_loop): Don't declare.
4467         * event-loop.c (start_event_loop): Move...
4468         * main.c (start_event_loop): ...here.  Now static.
4469
4470 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
4471
4472         * MAINTAINERS: Update my email address.
4473
4474 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4475
4476         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
4477         IP_ALL.
4478
4479 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4480
4481         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
4482         (nbsd_nat_target::info_proc): Add do_cmdline.
4483
4484 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4485
4486         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
4487         (nbsd_nat_target::info_proc): Add do_cwd.
4488
4489 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4490
4491         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
4492
4493 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
4494
4495         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
4496         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
4497         (nbsd_nat_target::info_proc): New functions.
4498         * nbsd-nat.c (kinfo_get_vmmap): New function.
4499         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
4500         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
4501         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
4502         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
4503         functions.
4504         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
4505         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4506         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4507         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
4508         (KINFO_VME_FLAG_GROWS_DOWN): New.
4509
4510 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
4511
4512         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
4513         bit shift.
4514
4515 2020-04-10  Tom Tromey  <tromey@adacore.com>
4516
4517         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
4518
4519 2020-04-10  Tom Tromey  <tromey@adacore.com>
4520
4521         * symtab.c (get_symbol_address, get_msymbol_address): Skip
4522         separate debug files.
4523
4524 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4525
4526         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4527         Move to...
4528         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4529         ... here.
4530         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4531         Check for STATUS_WX86_BREAKPOINT.
4532         (windows_nat_target::wait): Same.
4533
4534 2020-04-10  Tom de Vries  <tdevries@suse.de>
4535
4536         PR cli/25808
4537         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4538
4539 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4540
4541         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4542         (Write After Approval): Remove Tom de Vries.
4543
4544 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4545
4546         revert partially:
4547         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4548
4549         * buildsym.c (record_line): Fix undefined behavior and preserve
4550         lines at eof.
4551
4552 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4553
4554         * auxv.h (svr4_auxv_parse): New.
4555         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4556         and generic_auxv_parse.
4557         (svr4_auxv_parse): Add.
4558         * obsd-tdep.c: Include "auxv.h".
4559         (obsd_auxv_parse): Remove.
4560         (obsd_init_abi): Remove comment.
4561         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
4562         from `obsd_auxv_parse' to `svr4_auxv_parse'.
4563         * nbsd-tdep.c: Include "auxv.h".
4564         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
4565
4566 2020-04-08  Tom Tromey  <tromey@adacore.com>
4567
4568         * nat/windows-nat.h (last_wait_event): Don't declare.
4569         (wait_for_debug_event): Update comment.
4570         * nat/windows-nat.c (last_wait_event): Now static.
4571
4572 2020-04-08  Tom Tromey  <tromey@adacore.com>
4573
4574         * windows-nat.c (wait_for_debug_event): Move to
4575         nat/windows-nat.c.
4576         * nat/windows-nat.h (wait_for_debug_event): Declare.
4577         * nat/windows-nat.c (wait_for_debug_event): Move from
4578         windows-nat.c.  No longer static.
4579
4580 2020-04-08  Tom Tromey  <tromey@adacore.com>
4581
4582         * windows-nat.c (get_windows_debug_event): Use
4583         fetch_pending_stop.
4584         * nat/windows-nat.h (fetch_pending_stop): Declare.
4585         * nat/windows-nat.c (fetch_pending_stop): New function.
4586
4587 2020-04-08  Tom Tromey  <tromey@adacore.com>
4588
4589         * windows-nat.c (windows_continue): Use matching_pending_stop and
4590         continue_last_debug_event.
4591         * nat/windows-nat.h (matching_pending_stop)
4592         (continue_last_debug_event): Declare.
4593         * nat/windows-nat.c (DEBUG_EVENTS): New define.
4594         (matching_pending_stop, continue_last_debug_event): New
4595         functions.
4596
4597 2020-04-08  Tom Tromey  <tromey@adacore.com>
4598
4599         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
4600         (handle_exception_result): Move to nat/windows-nat.h.
4601         (DEBUG_EXCEPTION_SIMPLE): Remove.
4602         (windows_nat::handle_ms_vc_exception): New function.
4603         (handle_exception): Move to nat/windows-nat.c.
4604         (get_windows_debug_event): Update.
4605         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
4606         nat/windows-nat.c.
4607         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
4608         (handle_exception_result): Move from windows-nat.c.
4609         (handle_exception): Declare.
4610         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
4611         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
4612         windows-nat.c.
4613
4614 2020-04-08  Tom Tromey  <tromey@adacore.com>
4615
4616         * windows-nat.c (exception_count, event_count): Remove.
4617         (handle_exception, get_windows_debug_event)
4618         (do_initial_windows_stuff): Update.
4619
4620 2020-04-08  Tom Tromey  <tromey@adacore.com>
4621
4622         * windows-nat.c (windows_nat::handle_load_dll)
4623         (windows_nat::handle_unload_dll): Rename.  No longer static.
4624         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
4625         Declare.
4626
4627 2020-04-08  Tom Tromey  <tromey@adacore.com>
4628
4629         * complaints.h (stop_whining): Declare at top-level.
4630         (complaint): Don't declare stop_whining.
4631
4632 2020-04-08  Tom Tromey  <tromey@adacore.com>
4633
4634         * windows-nat.c (windows_nat::handle_output_debug_string):
4635         Rename.  No longer static.
4636         * nat/windows-nat.h (handle_output_debug_string): Declare.
4637
4638 2020-04-08  Tom Tromey  <tromey@adacore.com>
4639
4640         * windows-nat.c (current_process_handle, current_process_id)
4641         (main_thread_id, last_sig, current_event, last_wait_event)
4642         (current_windows_thread, desired_stop_thread_id, pending_stops)
4643         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
4644         (display_selectors, fake_create_process)
4645         (get_windows_debug_event): Update.
4646         * nat/windows-nat.h (current_process_handle, current_process_id)
4647         (main_thread_id, last_sig, current_event, last_wait_event)
4648         (current_windows_thread, desired_stop_thread_id, pending_stops)
4649         (struct pending_stop, siginfo_er): Move from windows-nat.c.
4650         * nat/windows-nat.c (current_process_handle, current_process_id)
4651         (main_thread_id, last_sig, current_event, last_wait_event)
4652         (current_windows_thread, desired_stop_thread_id, pending_stops)
4653         (siginfo_er): New globals.  Move from windows-nat.c.
4654
4655 2020-04-08  Tom Tromey  <tromey@adacore.com>
4656
4657         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
4658         (handle_load_dll): Update.
4659         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
4660
4661 2020-04-08  Tom Tromey  <tromey@adacore.com>
4662
4663         * windows-nat.c (enum thread_disposition_type): Move to
4664         nat/windows-nat.h.
4665         (windows_nat::thread_rec): Rename from thread_rec.  No longer
4666         static.
4667         (windows_add_thread, windows_nat_target::fetch_registers)
4668         (windows_nat_target::store_registers, handle_exception)
4669         (windows_nat_target::resume, get_windows_debug_event)
4670         (windows_nat_target::get_tib_address)
4671         (windows_nat_target::thread_name)
4672         (windows_nat_target::thread_alive): Update.
4673         * nat/windows-nat.h (enum thread_disposition_type): Move from
4674         windows-nat.c.
4675         (thread_rec): Declare.
4676
4677 2020-04-08  Tom Tromey  <tromey@adacore.com>
4678
4679         * windows-nat.c: Add "using namespace".
4680         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
4681         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
4682
4683 2020-04-08  Tom Tromey  <tromey@adacore.com>
4684
4685         * nat/windows-nat.h (struct windows_thread_info): Declare
4686         destructor.
4687         * nat/windows-nat.c (~windows_thread_info): New.
4688
4689 2020-04-08  Tom Tromey  <tromey@adacore.com>
4690
4691         PR gdb/22992
4692         * windows-nat.c (current_event): Update comment.
4693         (last_wait_event, desired_stop_thread_id): New globals.
4694         (struct pending_stop): New.
4695         (pending_stops): New global.
4696         (windows_nat_target) <stopped_by_sw_breakpoint>
4697         <supports_stopped_by_sw_breakpoint>: New methods.
4698         (windows_fetch_one_register): Add assertions.  Adjust PC.
4699         (windows_continue): Handle pending stops.  Suspend other threads
4700         when stepping.  Use last_wait_event
4701         (wait_for_debug_event): New function.
4702         (get_windows_debug_event): Use wait_for_debug_event.  Handle
4703         pending stops.  Queue spurious stops.
4704         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
4705         (windows_nat_target::kill): Use wait_for_debug_event.
4706         * nat/windows-nat.h (struct windows_thread_info)
4707         <stopped_at_software_breakpoint>: New field.
4708         * nat/windows-nat.c (windows_thread_info::resume): Clear
4709         stopped_at_software_breakpoint.
4710
4711 2020-04-08  Tom Tromey  <tromey@adacore.com>
4712
4713         * windows-nat.c (enum thread_disposition_type): New.
4714         (thread_rec): Replace "get_context" parameter with "disposition";
4715         change type.
4716         (windows_add_thread, windows_nat_target::fetch_registers)
4717         (windows_nat_target::store_registers, handle_exception)
4718         (windows_nat_target::resume, get_windows_debug_event)
4719         (windows_nat_target::get_tib_address)
4720         (windows_nat_target::thread_name)
4721         (windows_nat_target::thread_alive): Update.
4722
4723 2020-04-08  Tom Tromey  <tromey@adacore.com>
4724
4725         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
4726         (windows_continue): Use windows_continue::resume.
4727         * nat/windows-nat.h (struct windows_thread_info) <suspend,
4728         resume>: Declare new methods.
4729         * nat/windows-nat.c: New file.
4730         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
4731
4732 2020-04-08  Tom Tromey  <tromey@adacore.com>
4733
4734         * windows-nat.c (windows_add_thread, windows_delete_thread)
4735         (windows_nat_target::fetch_registers)
4736         (windows_nat_target::store_registers, fake_create_process)
4737         (windows_nat_target::resume, windows_nat_target::resume)
4738         (get_windows_debug_event, windows_nat_target::wait)
4739         (windows_nat_target::pid_to_str)
4740         (windows_nat_target::get_tib_address)
4741         (windows_nat_target::get_ada_task_ptid)
4742         (windows_nat_target::thread_name)
4743         (windows_nat_target::thread_alive): Use lwp, not tid.
4744
4745 2020-04-08  Tom Tromey  <tromey@adacore.com>
4746
4747         * windows-nat.c (handle_exception)
4748         (windows_nat_target::thread_name): Update.
4749         * nat/windows-nat.h (windows_thread_info): Remove destructor.
4750         <name>: Now unique_xmalloc_ptr.
4751
4752 2020-04-08  Tom Tromey  <tromey@adacore.com>
4753
4754         * windows-nat.c (thread_rec)
4755         (windows_nat_target::fetch_registers): Update.
4756         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
4757         Update comment.
4758         <debug_registers_changed, reload_context>: Now bool.
4759
4760 2020-04-08  Tom Tromey  <tromey@adacore.com>
4761
4762         * windows-nat.c (windows_add_thread): Use new.
4763         (windows_init_thread_list, windows_delete_thread): Use delete.
4764         (get_windows_debug_event): Update.
4765         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
4766         destructor, and initializers.
4767
4768 2020-04-08  Tom Tromey  <tromey@adacore.com>
4769
4770         * windows-nat.c (struct windows_thread_info): Remove.
4771         * nat/windows-nat.h: New file.
4772
4773 2020-04-08  Tom Tromey  <tromey@adacore.com>
4774
4775         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
4776         (thread_rec, windows_add_thread, windows_delete_thread)
4777         (windows_continue): Update.
4778
4779 2020-04-08  Tom Tromey  <tromey@adacore.com>
4780
4781         * windows-nat.c (struct windows_thread_info): Remove typedef.
4782         (thread_head): Remove.
4783         (thread_list): New global.
4784         (thread_rec, windows_add_thread, windows_init_thread_list)
4785         (windows_delete_thread, windows_continue): Update.
4786
4787 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4788
4789         * windows-tdep.h (windows_init_abi): Add comment.
4790         (cygwin_init_abi): New declaration.
4791         * windows-tdep.c: Split signal enumeration in two, one for
4792         Windows and one for Cygwin.
4793         (windows_gdb_signal_to_target): Only deal with signal of the
4794         Windows OS ABI.
4795         (cygwin_gdb_signal_to_target): New function.
4796         (windows_init_abi): Rename to windows_init_abi_common, don't set
4797         gdb_signal_to_target gdbarch method.  Add new new function with
4798         this name.
4799         (cygwin_init_abi): New function.
4800         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
4801         comment.  Don't call windows_init_abi.
4802         (amd64_windows_init_abi): Add comment, call windows_init_abi.
4803         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
4804         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
4805         i386_windows_init_abi_common, don't call windows_init_abi.  Add
4806         a new function of this name.
4807         (i386_cygwin_init_abi): New function.
4808         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
4809         OS ABI Cygwin.
4810
4811 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
4812
4813         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
4814         parameter.c.
4815         (dwarf2_read_gdb_index): Update.
4816
4817 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
4818
4819         * nbsd-tdep.c: Include "objfiles.h".
4820         (nbsd_skip_solib_resolver): New.
4821         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
4822
4823 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4824
4825         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
4826         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
4827         with DW_LLE_base_addressx are being emitted in DWARFv5.
4828         Add the newly added kind DW_LOC_OFFSET_PAIR also.
4829         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
4830         unsigned integer.
4831
4832 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4833
4834         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
4835         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
4836         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
4837         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
4838         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
4839         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
4840         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
4841
4842
4843 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
4844
4845         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
4846         (read_loclist_index): New function definition.
4847         (lookup_loclist_base): New function definition.
4848         (read_loclist_header): New function definition.
4849         (dwarf2_cu): Add loclist_base and loclist_header field.
4850         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
4851         (read_full_die_1): Read the value of DW_AT_loclists_base.
4852         (read_attribute_reprocess): Handle DW_FORM_loclistx.
4853         (read_attribute_value): Handle DW_FORM_loclistx.
4854         (skip_one_die): Handle DW_FORM_loclistx.
4855         (loclist_header): New structure declaration.
4856         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
4857
4858 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
4859
4860         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
4861         constructor.  Remove `addr` parameter from other constructor and
4862         add `per_cu` parameter.
4863         * dwarf2/read.c (create_partial_symtab): Update.
4864
4865 2020-04-07  Tom de Vries  <tdevries@suse.de>
4866
4867         PR symtab/25796
4868         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
4869         (partial_die_info::fixup): Inherit has_const_value.
4870
4871 2020-04-07  Tom de Vries  <tdevries@suse.de>
4872
4873         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
4874         symbols without address.
4875
4876 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4877
4878         * nbsd-nat.h (struct thread_info): Add forward declaration.
4879         (nbsd_nat_target::thread_alive): Add.
4880         (nbsd_nat_target::thread_name): Likewise.
4881         (nbsd_nat_target::update_thread_list): Likewise.
4882         (update_thread_list::post_attach): Likewise.
4883         (post_attach::pid_to_str): Likewise.
4884         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
4885         (nbsd_thread_lister): Add.
4886         (nbsd_nat_target::thread_alive): Likewise.
4887         (nbsd_nat_target::thread_name): Likewise.
4888         (nbsd_add_threads): Likewise.
4889         (update_thread_list::post_attach): Likewise.
4890         (nbsd_nat_target::update_thread_list): Likewise.
4891         (post_attach::pid_to_str): Likewise.
4892
4893 2020-04-06  Tom Tromey  <tromey@adacore.com>
4894
4895         * ada-valprint.c (print_variant_part): Extract the variant field.
4896         (print_field_values): Use the field as the outer value when
4897         recursing.
4898
4899 2020-04-06  Tom Tromey  <tromey@adacore.com>
4900
4901         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
4902         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
4903         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
4904         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
4905         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
4906
4907 2020-04-06  Tom Tromey  <tromey@adacore.com>
4908
4909         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
4910         TYPE_CODE_ERROR.
4911
4912 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
4913
4914         * nbsd-tdep.c: Include "gdbarch.h".
4915         Define enum with NetBSD signal numbers.
4916         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
4917         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
4918         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
4919         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
4920         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
4921         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
4922         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
4923         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
4924         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
4925         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
4926         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
4927         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
4928
4929 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
4930
4931         PR gdb/25325
4932         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
4933
4934 2020-04-03  Tom Tromey  <tromey@adacore.com>
4935
4936         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
4937         Read constant block.
4938
4939 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4940
4941         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
4942         (gdb_bfd_get_full_section_contents): New declaration.
4943         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
4944         * windows-tdep.c (is_linked_with_cygwin_dll): Use
4945         gdb_bfd_get_full_section_contents.
4946
4947 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
4948
4949         * exec.c (build_section_table): Replace internal_error with
4950         gdb_assert.
4951         (section_table_xfer_memory_partial): Likewise.
4952         * mdebugread.c (parse_partial_symbols): Likewise.
4953         * psymtab.c (lookup_partial_symbol): Likewise.
4954         * utils.c (wrap_here): Likewise.
4955
4956 2020-04-02  Tom Tromey  <tromey@adacore.com>
4957
4958         * f-lang.c (build_fortran_types): Use arch_type to initialize
4959         builtin_complex_s32 in the TYPE_CODE_ERROR case.
4960
4961 2020-04-02  Tom Tromey  <tromey@adacore.com>
4962
4963         * dwarf2/read.c (partial_die_info::read): Do not create a vector
4964         of attributes.
4965
4966 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4967             Bernd Edlinger <bernd.edlinger@hotmail.de>
4968             Tom Tromey  <tromey@adacore.com>
4969
4970         * buildsym.c (buildsym_compunit::record_line): Remove
4971         deduplication code.
4972
4973 2020-04-02  Tom de Vries  <tdevries@suse.de>
4974
4975         PR ada/24671
4976         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
4977
4978 2020-04-02  Tom de Vries  <tdevries@suse.de>
4979
4980         * dwarf2/read.c (dwarf2_gdb_index_functions,
4981         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
4982         NULL.
4983         * psymtab.c (psym_lookup_global_symbol_language): New function.
4984         (psym_functions): Init psym_lookup_global_symbol_language with
4985         psym_lookup_global_symbol_language.
4986         * symfile-debug.c (debug_sym_quick_functions): Init
4987         lookup_global_symbol_language with NULL.
4988         * symfile.c (set_initial_language): Remove fixme comment.
4989         * symfile.h (struct quick_symbol_functions): Add
4990         lookup_global_symbol_language.
4991         * symtab.c (find_quick_global_symbol_language): New function.
4992         (find_main_name): Use find_quick_global_symbol_language.
4993
4994 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
4995
4996         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
4997
4998 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4999
5000         * buildsym.c (record_line): Fix undefined behavior and preserve
5001         lines at eof.
5002
5003 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5004
5005         * buildsym.c (record_line): Fix the resizing condition.
5006
5007 2020-04-01  Tom Tromey  <tom@tromey.com>
5008
5009         * value.h (value_literal_complex): Add comment.
5010         * valops.c (value_literal_complex): Refer to value.h.
5011
5012 2020-04-01  Tom Tromey  <tom@tromey.com>
5013
5014         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
5015         (scalar_type): New rule, from typebase.
5016         (typebase): Use scalar_type.  Recognize complex types.
5017         (field_name): Handle FLOAT_KEYWORD.
5018         (ident_tokens): Add _Complex and __complex__.
5019
5020 2020-04-01  Tom Tromey  <tom@tromey.com>
5021
5022         PR exp/25299:
5023         * valarith.c (promotion_type, complex_binop): New functions.
5024         (scalar_binop): Handle complex numbers.  Use promotion_type.
5025         (value_pos, value_neg, value_complement): Handle complex numbers.
5026
5027 2020-04-01  Tom Tromey  <tom@tromey.com>
5028
5029         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
5030         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
5031         (parse_number): Handle complex numbers.
5032
5033 2020-04-01  Tom Tromey  <tom@tromey.com>
5034
5035         * c-valprint.c (c_decorations): Change complex suffix to "i".
5036
5037 2020-04-01  Tom Tromey  <tom@tromey.com>
5038
5039         * valprint.c (generic_value_print_complex): Use accessors.
5040         * value.h (value_real_part, value_imaginary_part): Declare.
5041         * valops.c (value_real_part, value_imaginary_part): New
5042         functions.
5043         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
5044
5045 2020-04-01  Tom Tromey  <tom@tromey.com>
5046
5047         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
5048         (read_range_type): Update.
5049         * mdebugread.c (basic_type): Update.
5050         * go-lang.c (build_go_types): Use init_complex_type.
5051         * gdbtypes.h (struct main_type) <complex_type>: New member.
5052         (init_complex_type): Update.
5053         (arch_complex_type): Don't declare.
5054         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
5055         Make name if none given.  Use alloc_type_copy.  Look for cached
5056         complex type.
5057         (arch_complex_type): Remove.
5058         (gdbtypes_post_init): Use init_complex_type.
5059         * f-lang.c (build_fortran_types): Use init_complex_type.
5060         * dwarf2/read.c (read_base_type): Update.
5061         * d-lang.c (build_d_types): Use init_complex_type.
5062         * ctfread.c (read_base_type): Update.
5063
5064 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5065
5066         * infrun.c (stop_all_threads): Update assertion, plus when
5067         stopping threads, take into account that we might be trying
5068         to stop an all-stop target.
5069         (stop_waiting): Call 'stop_all_threads' if there exists a
5070         non-stop target.
5071
5072 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5073
5074         * target.h (exists_non_stop_target): New function declaration.
5075         * target.c (exists_non_stop_target): New function.
5076
5077 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
5078
5079         PR gdb/24789
5080         * eval.c (is_integral_or_integral_reference): New function.
5081         (evaluate_subexp_standard): Allow integer references in
5082         pointer arithmetic.
5083
5084 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5085
5086         * remote.c (remote_target::remote_parse_stop_reply): Remove the
5087         check for no ptid in the stop reply when the target is non-stop.
5088
5089 2020-04-01  Tom Tromey  <tromey@adacore.com>
5090
5091         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
5092         "name" parameter to rvalue reference.  Initialize m_name_holder.
5093         <lookup_name_info>: New overloads.
5094         <name>: Return gdb::string_view.
5095         <c_str>: New method.
5096         <make_ignore_params>: Update.
5097         <search_name_hash>: Update.
5098         <language_lookup_name>: Return const char *.
5099         <m_name>: Change type.
5100         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
5101         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
5102         (lookup_name_info::match_any): Update.
5103         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
5104         Update.
5105         * minsyms.c (linkage_name_str): Update.
5106         * language.c (default_symbol_name_matcher): Update.
5107         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
5108         Update.
5109         * ada-lang.c (ada_fold_name): Change parameter to string_view.
5110         (ada_lookup_name_info::ada_lookup_name_info): Update.
5111         (literal_symbol_name_matcher): Update.
5112
5113 2020-04-01  Tom Tromey  <tromey@adacore.com>
5114
5115         * psymtab.c (psymtab_search_name): Remove function.
5116         (psym_lookup_symbol): Create search name and lookup name here.
5117         (lookup_partial_symbol): Remove "name" parameter; add
5118         lookup_name.
5119         (psym_expand_symtabs_for_function): Update.
5120
5121 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
5122
5123         PR tui/25597:
5124         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
5125
5126 2020-03-31  Tom Tromey  <tromey@adacore.com>
5127
5128         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
5129         memcpy.
5130
5131 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
5132
5133         * features/riscv/32bit-csr.xml: Regenerated.
5134         * features/riscv/64bit-csr.xml: Regenerated.
5135
5136 2020-03-30  Tom Tromey  <tromey@adacore.com>
5137
5138         * ada-valprint.c (print_variant_part): Update.
5139         * ada-lang.h (ada_which_variant_applies): Update.
5140         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
5141         outer_valaddr parameters; replace with "outer" value parameter.
5142         (to_fixed_variant_branch_type): Update.
5143
5144 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5145
5146         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
5147         <list>.  Remove inclusion of observable.h.
5148         (PPC_DEBUG_CURRENT_VERSION): Move up define.
5149         (struct arch_lwp_info): New struct.
5150         (class ppc_linux_dreg_interface): New class.
5151         (struct ppc_linux_process_info): New struct.
5152         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
5153         <low_new_clone, low_forget_process, low_prepare_to_resume>
5154         <copy_thread_dreg_state, mark_thread_stale>
5155         <mark_debug_registers_changed, register_hw_breakpoint>
5156         <clear_hw_breakpoint, register_wp, clear_wp>
5157         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
5158         <num_memory_accesses, get_trigger_type>
5159         <create_watchpoint_request, hwdebug_point_cmp>
5160         <init_arch_lwp_info, get_arch_lwp_info>
5161         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
5162         methods.
5163         <struct ptid_hash>: New inner struct.
5164         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
5165         members.
5166         (saved_dabr_value, hwdebug_info, max_slots_number)
5167         (struct hw_break_tuple, struct thread_points, ppc_threads)
5168         (have_ptrace_hwdebug_interface)
5169         (hwdebug_find_thread_points_by_tid)
5170         (hwdebug_insert_point, hwdebug_remove_point): Remove.
5171         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
5172         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
5173         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
5174         use m_dreg_interface.
5175         (hwdebug_point_cmp): Change to...
5176         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
5177         reference arguments instead of pointers.
5178         (ppc_linux_nat_target::ranged_break_num_registers): Use
5179         m_dreg_interface.
5180         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
5181         m_dreg_interface.  Call register_hw_breakpoint.
5182         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
5183         m_dreg_interface.  Call clear_hw_breakpoint.
5184         (get_trigger_type): Change to...
5185         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
5186         comment.
5187         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
5188         use m_dreg_interface.  Call register_hw_breakpoint.
5189         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
5190         use m_dreg_interface.  Call clear_hw_breakpoint.
5191         (can_use_watchpoint_cond_accel): Change to...
5192         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
5193         method.  Update comment, use m_dreg_interface and
5194         m_process_info.
5195         (calculate_dvc): Change to...
5196         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
5197         m_dreg_interface.
5198         (num_memory_accesses): Change to...
5199         (ppc_linux_nat_target::num_memory_accesses): ...this method.
5200         (check_condition): Change to...
5201         (ppc_linux_nat_target::check_condition): ...this method.
5202         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
5203         comment, use m_dreg_interface.
5204         (create_watchpoint_request): Change to...
5205         (ppc_linux_nat_target::create_watchpoint_request): ...this
5206         method.  Use m_dreg_interface.
5207         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
5208         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
5209         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
5210         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
5211         (ppc_linux_nat_target::low_forget_process)
5212         (ppc_linux_nat_target::low_new_fork)
5213         (ppc_linux_nat_target::low_new_clone)
5214         (ppc_linux_nat_target::low_delete_thread)
5215         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
5216         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
5217         only call mark_thread_stale.
5218         (ppc_linux_thread_exit): Remove.
5219         (ppc_linux_nat_target::stopped_data_address): Change to...
5220         (ppc_linux_nat_target::low_stopped_data_address): This. Add
5221         comment, use m_dreg_interface and m_thread_hw_breakpoints.
5222         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
5223         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
5224         comment.  Call low_stopped_data_address.
5225         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
5226         m_dreg_interface.
5227         (ppc_linux_nat_target::masked_watch_num_registers): Use
5228         m_dreg_interface.
5229         (ppc_linux_nat_target::copy_thread_dreg_state)
5230         (ppc_linux_nat_target::mark_thread_stale)
5231         (ppc_linux_nat_target::mark_debug_registers_changed)
5232         (ppc_linux_nat_target::register_hw_breakpoint)
5233         (ppc_linux_nat_target::clear_hw_breakpoint)
5234         (ppc_linux_nat_target::register_wp)
5235         (ppc_linux_nat_target::clear_wp)
5236         (ppc_linux_nat_target::init_arch_lwp_info)
5237         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
5238         (_initialize_ppc_linux_nat): Remove observer callback.
5239
5240 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5241
5242         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
5243         (ppc_linux_nat_target::auxv_parse)
5244         (ppc_linux_nat_target::read_description)
5245         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
5246         Move up.
5247
5248 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5249
5250         * linux-nat.h (low_new_clone): New method.
5251         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
5252
5253 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5254
5255         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
5256         (dbx_expand_psymtab): ... this.
5257         (start_psymtab): Update.
5258         * mdebugread.c (psymtab_to_symtab_1): Rename to...
5259         (mdebug_expand_psymtab): ... this.
5260         (parse_partial_symbols): Update.
5261         (new_psymtab): Update.
5262         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
5263         (xcoff_expand_psymtab): ... this.
5264         (xcoff_start_psymtab): Update.
5265
5266 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5267
5268         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
5269         <expand_dependencies>: ... this.
5270         * psymtab.c (partial_symtab::read_dependencies): Rename to...
5271         (partial_symtab::expand_dependencies): ... this.
5272         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
5273         Update.
5274         (dwarf2_psymtab::expand_psymtab): Update.
5275         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5276         * mdebugread.c (psymtab_to_symtab_1): Update.
5277         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5278
5279 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5280
5281         * psympriv.h (discard_psymtab): Remove.
5282         * dbxread.c (dbx_end_psymtab): Update.
5283         * xcoffread.c (xcoff_end_psymtab): Update.
5284
5285 2020-03-28  Tom Tromey  <tom@tromey.com>
5286
5287         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
5288         comment.
5289
5290 2020-03-28  Tom Tromey  <tom@tromey.com>
5291
5292         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
5293
5294 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
5295
5296         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5297
5298 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
5299
5300         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
5301
5302 2020-03-26  Tom Tromey  <tom@tromey.com>
5303
5304         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
5305         (mark_common_block_symbol_computed, read_tag_string_type)
5306         (attr_to_dynamic_prop, read_subrange_type): Update.
5307         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
5308         to be methods on struct attribute.
5309         (skip_one_die, process_imported_unit_die, read_namespace_alias)
5310         (read_call_site_scope, partial_die_info::read)
5311         (partial_die_info::read, lookup_die_type, follow_die_ref):
5312         Update.
5313         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
5314         from dwarf2_get_ref_die_offset.
5315         (attribute::constant_value): New method, from
5316         dwarf2_get_attr_constant_value.
5317         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
5318         Declare method.
5319         <constant_value>: New method.
5320
5321 2020-03-26  Tom Tromey  <tom@tromey.com>
5322
5323         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
5324         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
5325         (dwarf_type_encoding_name): Move to stringify.c.
5326         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
5327         * dwarf2/stringify.c: New file.
5328         * dwarf2/stringify.h: New file.
5329
5330 2020-03-26  Tom Tromey  <tom@tromey.com>
5331
5332         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
5333         Rewrite.
5334
5335 2020-03-26  Tom Tromey  <tom@tromey.com>
5336
5337         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
5338         methods.
5339         * dwarf2/read.c (lookup_addr_base): Move to die.h.
5340         (lookup_ranges_base): Likewise.
5341         (read_cutu_die_from_dwo, read_full_die_1): Update.
5342
5343 2020-03-26  Tom Tromey  <tom@tromey.com>
5344
5345         * dwarf2/read.c (read_import_statement, read_file_scope)
5346         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
5347         (read_lexical_block_scope, read_call_site_scope)
5348         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
5349         (handle_struct_member_die, process_structure_scope)
5350         (update_enumeration_type_from_children)
5351         (process_enumeration_scope, read_array_type, read_common_block)
5352         (read_namespace, read_module, read_subroutine_type): Update.
5353         (sibling_die): Remove.
5354
5355 2020-03-26  Tom Tromey  <tom@tromey.com>
5356
5357         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
5358         (build_type_psymtabs_reader, read_structure_type)
5359         (read_enumeration_type, read_full_die_1): Update.
5360         (dwarf2_attr_no_follow): Move to die.h.
5361         * dwarf2/die.h (struct die_info) <attr>: New method.
5362
5363 2020-03-26  Tom Tromey  <tom@tromey.com>
5364
5365         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
5366         <base_address>: Now an optional.
5367         (dwarf2_find_base_address, dwarf2_rnglists_process)
5368         (dwarf2_ranges_process, fill_in_loclist_baton)
5369         (dwarf2_symbol_mark_computed): Update.
5370
5371 2020-03-26  Tom Tromey  <tom@tromey.com>
5372
5373         * dwarf2/read.c (struct die_info): Move to die.h.
5374         * dwarf2/die.h: New file.
5375
5376 2020-03-26  Tom Tromey  <tom@tromey.com>
5377
5378         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
5379         * dwarf2/read.c
5380         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5381         Move to line-header.c.
5382         (read_checked_initial_length_and_offset, read_formatted_entries):
5383         Likewise.
5384         (dwarf_decode_line_header): Split into two.
5385         * dwarf2/line-header.c
5386         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5387         Move from read.c.
5388         (read_checked_initial_length_and_offset, read_formatted_entries):
5389         Likewise.
5390         (dwarf_decode_line_header): New function, split from read.c.
5391
5392 2020-03-26  Tom Tromey  <tom@tromey.com>
5393
5394         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
5395         Declare method.
5396         * dwarf2/read.c (read_attribute_value): Update.
5397         (dwarf2_per_objfile::read_line_string): Rename from
5398         read_indirect_line_string.
5399         (read_formatted_entries): Update.
5400
5401 2020-03-26  Tom Tromey  <tom@tromey.com>
5402
5403         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
5404         variable.
5405
5406 2020-03-26  Tom Tromey  <tom@tromey.com>
5407
5408         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
5409         const.
5410         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
5411         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
5412         parameter const.
5413
5414 2020-03-26  Tom Tromey  <tom@tromey.com>
5415
5416         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
5417         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
5418         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
5419         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
5420
5421 2020-03-26  Tom Tromey  <tom@tromey.com>
5422
5423         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
5424         file_names_size, file_full_name, file_file_name>: Use const.
5425         <file_name_at, file_names>: Add const overload.
5426         * dwarf2/line-header.c (line_header::file_file_name)
5427         (line_header::file_full_name): Update.
5428
5429 2020-03-26  Tom Tromey  <tom@tromey.com>
5430
5431         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
5432         (macro_start_file, consume_improper_spaces)
5433         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
5434         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
5435         (dwarf_decode_macros): Move to macro.c.
5436         * dwarf2/macro.c: New file.
5437         * dwarf2/macro.h: New file.
5438         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
5439
5440 2020-03-26  Tom Tromey  <tom@tromey.com>
5441
5442         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
5443         method.
5444         * dwarf2/section.c: New method.  From
5445         read_indirect_string_at_offset_from.
5446         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
5447         (read_indirect_string_at_offset_from): Move to section.c.
5448         (read_indirect_string_at_offset): Rewrite.
5449         (read_indirect_line_string_at_offset): Remove.
5450         (read_indirect_string, read_indirect_line_string)
5451         (dwarf_decode_macro_bytes): Update.
5452
5453 2020-03-26  Tom Tromey  <tom@tromey.com>
5454
5455         * dwarf2/section.h (struct dwarf2_section_info)
5456         <overload_complaint>: Declare.
5457         (dwarf2_section_buffer_overflow_complaint): Don't declare.
5458         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
5459         Rename from dwarf2_section_buffer_overflow_complaint.
5460         * dwarf2/read.c (skip_one_die, partial_die_info::read)
5461         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
5462
5463 2020-03-26  Tom Tromey  <tom@tromey.com>
5464
5465         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
5466         Declare.
5467         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
5468         Move from read.c.
5469         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
5470         to section.c.
5471
5472 2020-03-26  Tom Tromey  <tom@tromey.com>
5473
5474         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
5475
5476 2020-03-26  Tom Tromey  <tom@tromey.com>
5477
5478         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
5479         "builder".
5480         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
5481         parameter.
5482         (dwarf_decode_macros): Update.
5483
5484 2020-03-26  Tom Tromey  <tom@tromey.com>
5485
5486         * dwarf2/read.c (read_attribute_value): Update.
5487         (read_indirect_string_from_dwz): Move to dwz.c; change into
5488         method.
5489         (dwarf_decode_macro_bytes): Update.
5490         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
5491         * dwarf2/dwz.c: New file.
5492         * Makefile.in (COMMON_SFILES): Add dwz.c.
5493
5494 2020-03-26  Tom Tromey  <tom@tromey.com>
5495
5496         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
5497         * dwarf2/read.c: Add include.
5498         * dwarf2/index-write.c: Add include.
5499         * dwarf2/index-cache.c: Add include.
5500         * dwarf2/dwz.h: New file.
5501
5502 2020-03-25  Tom Tromey  <tom@tromey.com>
5503
5504         * compile/compile-object-load.c (get_out_value_type): Mention
5505         correct symbol name in error message.
5506
5507 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
5508
5509         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5510
5511 2020-03-25  Tom de Vries  <tdevries@suse.de>
5512
5513         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
5514         * symmisc.c (dump_symtab_1): Print user and includes fields.
5515         (maintenance_info_symtabs): Same.
5516
5517 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
5518
5519         PR gdb/25534
5520         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
5521         (riscv_regcache_cooked_write): New function.
5522         (riscv_push_dummy_call): Use new function.
5523         (riscv_return_value): Likewise.
5524
5525 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5526
5527         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5528         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5529         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5530         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5531         * infrun.c (follow_fork): Likewise.
5532         (follow_fork_inferior): Likewise.
5533         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5534         * linux-nat.h (class linux_nat_target): Likewise.
5535         * remote.c (class remote_target) <follow_fork>: Likewise.
5536         (remote_target::follow_fork): Likewise.
5537         * target-delegates.c: Re-generate.
5538         * target.c (default_follow_fork): Likewise.
5539         (target_follow_fork): Likewise.
5540         * target.h (struct target_ops) <follow_fork>: Likewise.
5541         (target_follow_fork): Likewise.
5542
5543 2020-03-24  Tom de Vries  <tdevries@suse.de>
5544
5545         * psymtab.c (maintenance_info_psymtabs): Print user field.
5546
5547 2020-03-20  Tom Tromey  <tromey@adacore.com>
5548
5549         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5550         const.
5551         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5552         const.
5553
5554 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5555
5556         * ptrace.m4: Don't check for ptrace declaration.
5557         * config.in: Re-generate.
5558         * configure: Re-generate.
5559         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5560         not defined.
5561
5562 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5563
5564         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
5565         `PTRACE_TYPE_RET'.
5566         * i386-bsd-nat.c (gdb_ptrace): Likewise.
5567         * sparc-nat.c (gdb_ptrace): Likewise.
5568         * x86-bsd-nat.c (gdb_ptrace): Likewise.
5569
5570 2020-03-20  Tom Tromey  <tromey@adacore.com>
5571
5572         * c-exp.y (lex_one_token): Fix assert.
5573
5574 2020-03-20  Tom Tromey  <tromey@adacore.com>
5575
5576         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
5577         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
5578         strncpy call.
5579
5580 2020-03-20  Tom Tromey  <tromey@adacore.com>
5581
5582         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
5583
5584 2020-03-20  Tom Tromey  <tromey@adacore.com>
5585
5586         * ada-valprint.c (print_variant_part): Remove parameters; switch
5587         to value-based API.
5588         (print_field_values): Likewise.
5589         (ada_val_print_struct_union): Likewise.
5590         (ada_value_print_1): Update.
5591
5592 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5593
5594         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
5595         nbsd_nat_target instead of inf_ptrace_target.
5596         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5597         nbsd_nat_target.
5598
5599 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5600
5601         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
5602         it to the ptrace call.
5603         * (store_registers): Likewise.
5604
5605 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
5606
5607         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
5608         it to the ptrace call.
5609         * (store_registers): Likewise.
5610
5611 2020-03-19  Luis Machado  <luis.machado@linaro.org>
5612
5613         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
5614         valid, fetch vg value from ptrace.
5615
5616 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5617         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
5618         * inf-ptrace.c: Likewise.
5619         * (gdb_ptrace): Add.
5620         * (inf_ptrace_target::resume): Update.
5621         * (inf_ptrace_target::xfer_partial): Likewise.
5622         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
5623         * (inf_ptrace_peek_poke): Update.
5624
5625 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
5626
5627         * x86-bsd-nat.c (gdb_ptrace): New.
5628         * (x86bsd_dr_set): Add new argument `ptid'.
5629         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
5630         x86bsd_dr_set_addr): Update.
5631
5632 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5633
5634         * remote.c (remote_target::process_stop_reply): Handle events for
5635         all threads differently.
5636
5637 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5638
5639         * completer.c (completion_tracker::remove_completion): Define new
5640         function.
5641         * completer.h (completion_tracker::remove_completion): Declare new
5642         function.
5643         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
5644         when adding a C++ function symbol.
5645
5646 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5647
5648         * completer.c (completion_tracker::completion_hash_entry): Define
5649         new class.
5650         (advance_to_filename_complete_word_point): Call
5651         recompute_lowest_common_denominator.
5652         (completion_tracker::completion_tracker): Call discard_completions
5653         to setup the hash table.
5654         (completion_tracker::discard_completions): Allow for being called
5655         from the constructor, pass new equal function, and element deleter
5656         when constructing the hash table.  Initialise new class member
5657         variables.
5658         (completion_tracker::maybe_add_completion): Remove use of
5659         m_entries_vec, and store more information into m_entries_hash.
5660         (completion_tracker::recompute_lcd_visitor): New function, most
5661         content taken from...
5662         (completion_tracker::recompute_lowest_common_denominator):
5663         ...here, this now just visits each item in the hash calling the
5664         above visitor.
5665         (completion_tracker::build_completion_result): Remove use of
5666         m_entries_vec, call recompute_lowest_common_denominator.
5667         * completer.h (completion_tracker::have_completions): Remove use
5668         of m_entries_vec.
5669         (completion_tracker::completion_hash_entry): Declare new class.
5670         (completion_tracker::recompute_lowest_common_denominator): Change
5671         function signature.
5672         (completion_tracker::recompute_lcd_visitor): Declare new function.
5673         (completion_tracker::m_entries_vec): Delete.
5674         (completion_tracker::m_entries_hash): Initialize to NULL.
5675         (completion_tracker::m_lowest_common_denominator_valid): New
5676         member variable.
5677         (completion_tracker::m_lowest_common_denominator_max_length): New
5678         member variable.
5679
5680 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5681
5682         * regformats/regdef.h: Put reg in gdb namespace.
5683
5684 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5685
5686         * i386-bsd-nat.c (gdb_ptrace): New.
5687         * (i386bsd_fetch_inferior_registers,
5688         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5689         * (i386bsd_fetch_inferior_registers,
5690         i386bsd_store_inferior_registers) Use gdb_ptrace.
5691
5692 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5693
5694         * amd64-bsd-nat.c (gdb_ptrace): New.
5695         * (amd64bsd_fetch_inferior_registers,
5696         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
5697         * (amd64bsd_fetch_inferior_registers,
5698         amd64bsd_store_inferior_registers) Use gdb_ptrace.
5699
5700 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5701
5702         * user-regs.c (user_reg::read): Rename to...
5703         (user_reg::xread): ...this.
5704         * (append_user_reg): Rename argument `read' to `xread'.
5705         * (user_reg_add_builtin): Likewise.
5706         * (user_reg_add): Likewise.
5707         * (value_of_user_reg): Likewise.
5708
5709 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5710
5711         * sparc-nat.c (gdb_ptrace): New.
5712         * sparc-nat.c (sparc_fetch_inferior_registers)
5713         (sparc_store_inferior_registers) Remove obsolete comment.
5714         * sparc-nat.c (sparc_fetch_inferior_registers)
5715         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
5716         * sparc-nat.c (sparc_fetch_inferior_registers)
5717         (sparc_store_inferior_registers) Use gdb_ptrace.
5718
5719 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5720
5721         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
5722         it to the ptrace call.
5723         * sh-nbsd-nat.c (store_registers): Likewise.
5724
5725 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5726
5727         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
5728         nbsd_nat_target instead of inf_ptrace_target.
5729         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5730         nbsd_nat_target.
5731
5732 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5733
5734         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
5735
5736 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
5737
5738         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
5739         <sys/sysctl.h>.
5740         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
5741
5742 2020-03-17  Tom de Vries  <tdevries@suse.de>
5743
5744         PR gdb/23710
5745         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
5746         fields.
5747         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
5748         fields.
5749         (process_imported_unit_die): Skip import of c++ CUs.
5750
5751 2020-03-16  Tom Tromey  <tom@tromey.com>
5752
5753         * p-valprint.c (pascal_object_print_value): Initialize
5754         base_value.
5755
5756 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
5757             Shahab Vahedi  <shahab@synopsys.com>
5758
5759         * Makefile.in: Add arch/arc.o
5760         * configure.tgt: Likewise.
5761         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
5762         (_initialize_arc_tdep): Don't initialize old target descriptions.
5763         (arc_read_description): New function to cache target descriptions.
5764         * arc-tdep.h (arc_read_description): Add proto type.
5765         * arch/arc.c: New file.
5766         * arch/arc.h: Likewise.
5767         * features/Makefile: Replace old target descriptions with new.
5768         * features/arc-arcompact.c: Remove.
5769         * features/arc-arcompact.xml: Likewise.
5770         * features/arc-v2.c: Likewise
5771         * features/arc-v2.xml: Likewise
5772         * features/arc/aux-arcompact.xml: New file.
5773         * features/arc/aux-v2.xml: Likewise.
5774         * features/arc/core-arcompact.xml: Likewise.
5775         * features/arc/core-v2.xml: Likewise.
5776         * features/arc/aux-arcompact.c: Generate.
5777         * features/arc/aux-v2.c: Likewise.
5778         * features/arc/core-arcompact.c: Likewise.
5779         * features/arc/core-v2.c: Likewise.
5780         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
5781
5782 2020-03-16  Tom Tromey  <tromey@adacore.com>
5783
5784         PR gdb/25663:
5785         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
5786         putting value into bcache.
5787
5788 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5789
5790         PR gdb/21500
5791         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
5792         to...
5793         (amd64_windows_init_abi_common): ... this.  Don't set size of
5794         long type.
5795         (amd64_windows_init_abi): New function.
5796         (amd64_cygwin_init_abi): New function.
5797         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
5798         the Cygwin OS ABI.
5799         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
5800         comment.
5801
5802 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5803
5804         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
5805         * windows-tdep.c (CYGWIN_DLL_NAME): New.
5806         (pe_import_directory_entry): New struct type.
5807         (is_linked_with_cygwin_dll): New function.
5808         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
5809         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
5810         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
5811
5812 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5813
5814         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
5815         i386_cygwin_core_osabi_sniffer.
5816
5817 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5818
5819         * i386-cygwin-tdep.c: Rename to...
5820         * i386-windows-tdep.c: ... this.
5821         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
5822         i386-windows-tdep.c.
5823         * configure.tgt: Likewise.
5824
5825 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5826
5827         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
5828         * osabi.c (gdb_osabi_names): Add "Windows".
5829         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
5830         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
5831         (i386_cygwin_core_osabi_sniffer): New function, extracted from
5832         i386_cygwin_osabi_sniffer.
5833         (_initialize_i386_cygwin_tdep): Register OS ABI
5834         GDB_OSABI_WINDOWS for i386.
5835         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
5836         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
5837         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
5838         for x86-64.
5839         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
5840         when the target matches '*-*-mingw*'.
5841
5842 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5843
5844         * defs.h (enum gdb_osabi): Move to...
5845         * osabi.h (enum gdb_osabi): ... here.
5846         * gdbarch.sh: Include osabi.h in gdbarch.h.
5847         * gdbarch.h: Re-generate.
5848
5849 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
5850
5851         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
5852         function.
5853         (_initialize_amd64_windows_tdep): Register osabi sniffer.
5854
5855 2020-03-14  Tom Tromey  <tom@tromey.com>
5856
5857         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
5858         for C++.
5859         (c_type_print_modifier): Likewise.  Add "language" parameter.
5860         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
5861         (c_type_print_base_1): Update.
5862         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
5863         constants.
5864         * type-stack.c (type_stack::insert): Handle tp_atomic and
5865         tp_restrict.
5866         (type_stack::follow_type_instance_flags): Likewise.
5867         (type_stack::follow_types): Likewise.  Merge type-following code.
5868         * c-exp.y (RESTRICT, ATOMIC): New tokens.
5869         (space_identifier, cv_with_space_id)
5870         (const_or_volatile_or_space_identifier_noopt)
5871         (const_or_volatile_or_space_identifier): Remove.
5872         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
5873         rules.
5874         (ptr_operator, typebase): Update.
5875         (enum token_flag) <FLAG_C>: New constant.
5876         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
5877         "_Atomic".
5878         (lex_one_token): Handle FLAG_C.
5879
5880 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5881
5882         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
5883         it to the ptrace call.
5884         * m68k-bsd-nat.c (store_registers): Likewise.
5885
5886 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5887
5888         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
5889         gdb_byte *.
5890         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
5891         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
5892         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
5893
5894 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5895
5896         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
5897         nbsd_nat_target instead of inf_ptrace_target.
5898         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5899         nbsd_nat_target.
5900
5901 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5902
5903         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
5904         register_t.
5905
5906 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5907
5908         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
5909         it to the ptrace call.
5910         * alpha-bsd-nat.c (store_registers): Likewise.
5911
5912 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5913
5914         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
5915         includes.
5916         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
5917         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
5918         fill_fpregset): Likewise.
5919
5920 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5921
5922         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
5923         nbsd_nat_target instead of inf_ptrace_target.
5924         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5925         nbsd_nat_target.
5926
5927 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5928
5929         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
5930         register_t.
5931
5932 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5933
5934         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
5935         it to the ptrace call.
5936         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
5937         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
5938         * arm-nbsd-nat.c (store_register): Likewise.
5939         * arm-nbsd-nat.c (store_regs): Likewise.
5940         * arm-nbsd-nat.c (store_fp_register): Likewise.
5941         * arm-nbsd-nat.c (store_fp_regs): Likewise.
5942
5943 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5944
5945         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
5946         nbsd_nat_target instead of inf_ptrace_target.
5947         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
5948         nbsd_nat_target.
5949
5950 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5951
5952         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
5953         it to the ptrace call.
5954         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
5955
5956 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5957
5958         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
5959         it to the ptrace call.
5960         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
5961
5962 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5963
5964         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
5965         gdb_byte *.
5966         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
5967
5968 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5969
5970         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
5971         instead of inf_ptrace_target.
5972         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
5973         nbsd_nat_target.
5974
5975 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5976
5977         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5978         register_t.
5979
5980 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5981
5982         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5983         register_t.
5984
5985 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
5986
5987         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
5988         register_t.
5989
5990 2020-03-13  Tom Tromey  <tom@tromey.com>
5991
5992         * value.h (val_print): Don't declare.
5993         * valprint.h (val_print_array_elements)
5994         (val_print_scalar_formatted, generic_val_print): Don't declare.
5995         * valprint.c (generic_val_print_array): Take a struct value.
5996         (generic_val_print_ptr, generic_val_print_memberptr)
5997         (generic_val_print_bool, generic_val_print_int)
5998         (generic_val_print_char, generic_val_print_complex)
5999         (generic_val_print): Remove.
6000         (generic_value_print): Update.
6001         (do_val_print): Remove unused parameters.  Don't call
6002         la_val_print.
6003         (val_print): Remove.
6004         (common_val_print): Update.  Don't call value_check_printable.
6005         (val_print_scalar_formatted, val_print_array_elements): Remove.
6006         * rust-lang.c (rust_val_print): Remove.
6007         (rust_language_defn): Update.
6008         * p-valprint.c (pascal_val_print): Remove.
6009         (pascal_value_print_inner): Update.
6010         (pascal_object_print_val_fields, pascal_object_print_val):
6011         Remove.
6012         (pascal_object_print_static_field): Update.
6013         * p-lang.h (pascal_val_print): Don't declare.
6014         * p-lang.c (pascal_language_defn): Update.
6015         * opencl-lang.c (opencl_language_defn): Update.
6016         * objc-lang.c (objc_language_defn): Update.
6017         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
6018         * m2-lang.h (m2_val_print): Don't declare.
6019         * m2-lang.c (m2_language_defn): Update.
6020         * language.h (struct language_defn) <la_val_print>: Remove.
6021         * language.c (unk_lang_value_print_inner): Rename.  Change
6022         argument types.
6023         (unknown_language_defn, auto_language_defn): Update.
6024         * go-valprint.c (go_val_print): Remove.
6025         * go-lang.h (go_val_print): Don't declare.
6026         * go-lang.c (go_language_defn): Update.
6027         * f-valprint.c (f_val_print): Remove.
6028         * f-lang.h (f_value_print): Don't declare.
6029         * f-lang.c (f_language_defn): Update.
6030         * d-valprint.c (d_val_print): Remove.
6031         * d-lang.h (d_value_print): Don't declare.
6032         * d-lang.c (d_language_defn): Update.
6033         * cp-valprint.c (cp_print_value_fields)
6034         (cp_print_value_fields_rtti, cp_print_value): Remove.
6035         (cp_print_static_field): Update.
6036         * c-valprint.c (c_val_print_array, c_val_print_ptr)
6037         (c_val_print_struct, c_val_print_union, c_val_print_int)
6038         (c_val_print_memberptr, c_val_print): Remove.
6039         * c-lang.h (c_val_print_array, cp_print_value_fields)
6040         (cp_print_value_fields_rtti): Don't declare.
6041         * c-lang.c (c_language_defn, cplus_language_defn)
6042         (asm_language_defn, minimal_language_defn): Update.
6043         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
6044         (ada_val_print_enum): Take a struct value.
6045         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
6046         (ada_val_print): Remove.
6047         (ada_value_print_1): Update.
6048         (printable_val_type): Remove.
6049         * ada-lang.h (ada_val_print): Don't declare.
6050         * ada-lang.c (ada_language_defn): Update.
6051
6052 2020-03-13  Tom Tromey  <tom@tromey.com>
6053
6054         * valprint.c (do_val_print): Update.
6055         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
6056         a struct value.
6057         (value_to_value_object_no_release): Declare.
6058         * python/py-value.c (value_to_value_object_no_release): New
6059         function.
6060         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
6061         struct value.
6062         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
6063         function.
6064         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
6065         a struct value.
6066         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
6067         Declare.
6068         (gdbscm_apply_val_pretty_printer): Take a struct value.
6069         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
6070         value.
6071         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
6072         value.
6073         * extension-priv.h (struct extension_language_ops)
6074         <apply_val_pretty_printer>: Take a struct value.
6075         * cp-valprint.c (cp_print_value): Create a struct value.
6076         (cp_print_value): Update.
6077
6078 2020-03-13  Tom Tromey  <tom@tromey.com>
6079
6080         * ada-valprint.c (print_field_values): Call common_val_print.
6081
6082 2020-03-13  Tom Tromey  <tom@tromey.com>
6083
6084         * ada-valprint.c (val_print_packed_array_elements): Remove
6085         bitoffset and val parameters.  Call common_val_print.
6086         (ada_val_print_string): Remove offset, address, and original_value
6087         parameters.
6088         (ada_val_print_array): Update.
6089         (ada_value_print_array): New function.
6090         (ada_value_print_1): Call it.
6091
6092 2020-03-13  Tom Tromey  <tom@tromey.com>
6093
6094         * ada-valprint.c (ada_value_print): Use common_val_print.
6095
6096 2020-03-13  Tom Tromey  <tom@tromey.com>
6097
6098         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
6099
6100 2020-03-13  Tom Tromey  <tom@tromey.com>
6101
6102         * ada-valprint.c (ada_value_print_num): New function.
6103         (ada_value_print_1): Use it.
6104
6105 2020-03-13  Tom Tromey  <tom@tromey.com>
6106
6107         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
6108
6109 2020-03-13  Tom Tromey  <tom@tromey.com>
6110
6111         * ada-valprint.c (ada_value_print_ptr): New function.
6112         (ada_value_print_1): Use it.
6113
6114 2020-03-13  Tom Tromey  <tom@tromey.com>
6115
6116         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
6117         call common_val_print.
6118         (ada_val_print_1): Update.
6119         (ada_value_print_1): New function.
6120         (ada_value_print_inner): Rewrite.
6121
6122 2020-03-13  Tom Tromey  <tom@tromey.com>
6123
6124         * cp-valprint.c (cp_print_value_fields): Update.
6125         (cp_print_value): New function.
6126
6127 2020-03-13  Tom Tromey  <tom@tromey.com>
6128
6129         * m2-valprint.c (m2_value_print_inner): Use
6130         cp_print_value_fields.
6131         * cp-valprint.c (cp_print_value_fields): New function.
6132         * c-valprint.c (c_value_print_struct): New function.
6133         (c_value_print_inner): Use c_value_print_struct.
6134         * c-lang.h (cp_print_value_fields): Declare.
6135
6136 2020-03-13  Tom Tromey  <tom@tromey.com>
6137
6138         * c-valprint.c (c_value_print_array): New function.
6139         (c_value_print_inner): Use it.
6140
6141 2020-03-13  Tom Tromey  <tom@tromey.com>
6142
6143         * c-valprint.c (c_value_print_memberptr): New function.
6144         (c_value_print_inner): Use it.
6145
6146 2020-03-13  Tom Tromey  <tom@tromey.com>
6147
6148         * c-valprint.c (c_value_print_int): New function.
6149         (c_value_print_inner): Use it.
6150
6151 2020-03-13  Tom Tromey  <tom@tromey.com>
6152
6153         * c-valprint.c (c_value_print_ptr): New function.
6154         (c_value_print_inner): Use it.
6155
6156 2020-03-13  Tom Tromey  <tom@tromey.com>
6157
6158         * c-valprint.c (c_value_print_inner): Rewrite.
6159
6160 2020-03-13  Tom Tromey  <tom@tromey.com>
6161
6162         * valprint.c (generic_value_print_complex): New function.
6163         (generic_value_print): Use it.
6164
6165 2020-03-13  Tom Tromey  <tom@tromey.com>
6166
6167         * valprint.c (generic_val_print_float): Don't call
6168         val_print_scalar_formatted.
6169         (generic_val_print, generic_value_print): Update.
6170
6171 2020-03-13  Tom Tromey  <tom@tromey.com>
6172
6173         * valprint.c (generic_value_print_char): New function
6174         (generic_value_print): Use it.
6175
6176 2020-03-13  Tom Tromey  <tom@tromey.com>
6177
6178         * valprint.c (generic_value_print_int): New function.
6179         (generic_value_print): Use it.
6180
6181 2020-03-13  Tom Tromey  <tom@tromey.com>
6182
6183         * valprint.c (generic_value_print_bool): New function.
6184         (generic_value_print): Use it.
6185
6186 2020-03-13  Tom Tromey  <tom@tromey.com>
6187
6188         * valprint.c (generic_val_print_func): Simplify.
6189         (generic_val_print, generic_value_print): Update.
6190
6191 2020-03-13  Tom Tromey  <tom@tromey.com>
6192
6193         * valprint.c (generic_val_print_flags): Remove.
6194         (generic_val_print, generic_value_print): Update.
6195         (val_print_type_code_flags): Add original_value parameter.
6196
6197 2020-03-13  Tom Tromey  <tom@tromey.com>
6198
6199         * valprint.c (generic_val_print): Update.
6200         (generic_value_print): Update.
6201         * valprint.c (generic_val_print_enum): Don't call
6202         val_print_scalar_formatted.
6203
6204 2020-03-13  Tom Tromey  <tom@tromey.com>
6205
6206         * valprint.c (generic_value_print): Call generic_value_print_ptr.
6207         * valprint.c (generic_value_print_ptr): New function.
6208
6209 2020-03-13  Tom Tromey  <tom@tromey.com>
6210
6211         * valprint.c (generic_value_print): Rewrite.
6212
6213 2020-03-13  Tom Tromey  <tom@tromey.com>
6214
6215         * p-valprint.c (pascal_object_print_value_fields)
6216         (pascal_object_print_value): New functions.
6217
6218 2020-03-13  Tom Tromey  <tom@tromey.com>
6219
6220         * p-valprint.c (pascal_value_print_inner): Rewrite.
6221
6222 2020-03-13  Tom Tromey  <tom@tromey.com>
6223
6224         * f-valprint.c (f_value_print_innner): Rewrite.
6225
6226 2020-03-13  Tom Tromey  <tom@tromey.com>
6227
6228         * m2-valprint.c (m2_print_unbounded_array): New overload.
6229         (m2_print_unbounded_array): Update.
6230         (m2_print_array_contents): Take a struct value.
6231         (m2_value_print_inner): Rewrite.
6232
6233 2020-03-13  Tom Tromey  <tom@tromey.com>
6234
6235         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
6236         (d_value_print_inner): New function.
6237         * d-lang.h (d_value_print_inner): Declare.
6238         * d-lang.c (d_language_defn): Use d_value_print_inner.
6239
6240 2020-03-13  Tom Tromey  <tom@tromey.com>
6241
6242         * go-valprint.c (go_value_print_inner): New function.
6243         * go-lang.h (go_value_print_inner): Declare.
6244         * go-lang.c (go_language_defn): Use go_value_print_inner.
6245
6246 2020-03-13  Tom Tromey  <tom@tromey.com>
6247
6248         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
6249         API.
6250         (rust_val_print): Rewrite.
6251         (rust_value_print_inner): New function, from rust_val_print.
6252         (rust_language_defn): Use rust_value_print_inner.
6253
6254 2020-03-13  Tom Tromey  <tom@tromey.com>
6255
6256         * ada-valprint.c (ada_value_print_inner): New function.
6257         * ada-lang.h (ada_value_print_inner): Declare.
6258         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
6259
6260 2020-03-13  Tom Tromey  <tom@tromey.com>
6261
6262         * f-valprint.c (f_value_print_innner): New function.
6263         * f-lang.h (f_value_print_innner): Declare.
6264         * f-lang.c (f_language_defn): Use f_value_print_innner.
6265
6266 2020-03-13  Tom Tromey  <tom@tromey.com>
6267
6268         * p-valprint.c (pascal_value_print_inner): New function.
6269         * p-lang.h (pascal_value_print_inner): Declare.
6270         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
6271
6272 2020-03-13  Tom Tromey  <tom@tromey.com>
6273
6274         * m2-valprint.c (m2_value_print_inner): New function.
6275         * m2-lang.h (m2_value_print_inner): Declare.
6276         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
6277
6278 2020-03-13  Tom Tromey  <tom@tromey.com>
6279
6280         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
6281         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
6282         * c-valprint.c (c_value_print_inner): New function.
6283         * c-lang.h (c_value_print_inner): Declare.
6284         * c-lang.c (c_language_defn, cplus_language_defn)
6285         (asm_language_defn, minimal_language_defn): Use
6286         c_value_print_inner.
6287
6288 2020-03-13  Tom Tromey  <tom@tromey.com>
6289
6290         * p-valprint.c (pascal_object_print_value_fields): Now static.
6291         * p-lang.h (pascal_object_print_value_fields): Don't declare.
6292
6293 2020-03-13  Tom Tromey  <tom@tromey.com>
6294
6295         * c-valprint.c (c_val_print_array): Simplify.
6296
6297 2020-03-13  Tom Tromey  <tom@tromey.com>
6298
6299         * valprint.c (value_print_array_elements): New function.
6300         * valprint.h (value_print_array_elements): Declare.
6301
6302 2020-03-13  Tom Tromey  <tom@tromey.com>
6303
6304         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
6305         * mips-tdep.c (mips_print_register): Use
6306         value_print_scalar_formatted.
6307
6308 2020-03-13  Tom Tromey  <tom@tromey.com>
6309
6310         * valprint.h (value_print_scalar_formatted): Declare.
6311         * valprint.c (value_print_scalar_formatted): New function.
6312
6313 2020-03-13  Tom Tromey  <tom@tromey.com>
6314
6315         * valprint.h (generic_value_print): Declare.
6316         * valprint.c (generic_value_print): New function.
6317
6318 2020-03-13  Tom Tromey  <tom@tromey.com>
6319
6320         * valprint.c (do_val_print): Call la_value_print_inner, if
6321         available.
6322         * rust-lang.c (rust_language_defn): Update.
6323         * p-lang.c (pascal_language_defn): Update.
6324         * opencl-lang.c (opencl_language_defn): Update.
6325         * objc-lang.c (objc_language_defn): Update.
6326         * m2-lang.c (m2_language_defn): Update.
6327         * language.h (struct language_defn) <la_value_print_inner>: New
6328         member.
6329         * language.c (unknown_language_defn, auto_language_defn): Update.
6330         * go-lang.c (go_language_defn): Update.
6331         * f-lang.c (f_language_defn): Update.
6332         * d-lang.c (d_language_defn): Update.
6333         * c-lang.c (c_language_defn, cplus_language_defn)
6334         (asm_language_defn, minimal_language_defn): Update.
6335         * ada-lang.c (ada_language_defn): Update.
6336
6337 2020-03-13  Tom Tromey  <tom@tromey.com>
6338
6339         * c-valprint.c (c_value_print): Use common_val_print.
6340
6341 2020-03-13  Tom Tromey  <tom@tromey.com>
6342
6343         * cp-valprint.c (cp_print_static_field): Use common_val_print.
6344
6345 2020-03-13  Tom Tromey  <tom@tromey.com>
6346
6347         * f-valprint.c (f77_print_array_1, f_val_print): Use
6348         common_val_print.
6349
6350 2020-03-13  Tom Tromey  <tom@tromey.com>
6351
6352         * riscv-tdep.c (riscv_print_one_register_info): Use
6353         common_val_print.
6354
6355 2020-03-13  Tom Tromey  <tom@tromey.com>
6356
6357         * mi/mi-main.c (output_register): Use common_val_print.
6358
6359 2020-03-13  Tom Tromey  <tom@tromey.com>
6360
6361         * infcmd.c (default_print_one_register_info): Use
6362         common_val_print.
6363
6364 2020-03-13  Tom Tromey  <tom@tromey.com>
6365
6366         * valprint.h (common_val_print_checked): Declare.
6367         * valprint.c (common_val_print_checked): New function.
6368         * stack.c (print_frame_arg): Use common_val_print_checked.
6369
6370 2020-03-13  Tom Tromey  <tom@tromey.com>
6371
6372         * valprint.c (do_val_print): New function, from val_print.
6373         (val_print): Use do_val_print.
6374         (common_val_print): Use do_val_print.
6375
6376 2020-03-13  Tom Tromey  <tom@tromey.com>
6377
6378         * valprint.c (value_print): Use scoped_value_mark.
6379
6380 2020-03-13  Tom de Vries  <tdevries@suse.de>
6381
6382         PR symtab/25646
6383         * psymtab.c (partial_symtab::partial_symtab): Don't set
6384         globals_offset and statics_offset.  Push element onto
6385         current_global_psymbols and current_static_psymbols stacks.
6386         (concat): New function.
6387         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
6388         element from current_global_psymbols and current_static_psymbols
6389         stacks.  Concat popped elements to global_psymbols and
6390         static_symbols.
6391         (add_psymbol_to_list): Use current_global_psymbols and
6392         current_static_psymbols stacks.
6393         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
6394         current_static_psymbols fields.
6395
6396 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6397
6398         * corelow.c (sniff_core_bfd): Remove.
6399         (class core_target) <m_core_vec>: Remove.
6400         (core_target::core_target): Update.
6401         (core_file_fns): Remove.
6402         (deprecated_add_core_fns): Remove.
6403         (default_core_sniffer): Remove.
6404         (sniff_core_bfd): Remove.
6405         (default_check_format): Remove.
6406         (gdb_check_format): Remove.
6407         (core_target_open): Update.
6408         (core_target::get_core_register_section): Update.
6409         (get_core_registers_cb): Update.
6410         (core_target::fetch_registers): Update.
6411         * gdbcore.h (struct core_fns): Remove.
6412         (deprecated_add_core_fns): Remove.
6413         (default_core_sniffer): Remove.
6414         (default_check_format): Remove.
6415
6416 2020-03-12  Tom Tromey  <tom@tromey.com>
6417
6418         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
6419         CORE_ADDR.
6420         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
6421
6422 2020-03-12  Tom Tromey  <tom@tromey.com>
6423
6424         * remote.c (remote_target::download_tracepoint)
6425         (remote_target::enable_tracepoint)
6426         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
6427         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
6428         sprintf_vma.
6429
6430 2020-03-12  Tom Tromey  <tom@tromey.com>
6431
6432         * symfile-mem.c: Update CORE_ADDR size assert.
6433
6434 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6435
6436         * selftest.m4: Move to gdbsupport/.
6437         * acinclude.m4: Update path to selftest.m4.
6438
6439 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6440
6441         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
6442         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
6443         gdbarch-selfselftests.c and selftest-arch.c.
6444         (SUBDIR_UNITTESTS_OBS): Rename to...
6445         (SELFTESTS_OBS): ... this.
6446         (COMMON_SFILES): Remove disasm-selftests.c and
6447         gdbarch-selftests.c.
6448         * configure.ac: Don't add selftest-arch.{c,o} to
6449         CONFIG_{SRCS,OBS}.
6450         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
6451         preprocessor conditions.
6452
6453 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6454
6455         * configure.ac: Don't source bfd/development.sh.
6456         * selftest.m4: Modify comment.
6457         * configure: Re-generate.
6458
6459 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6460
6461         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
6462         not "true" or "false".
6463         * configure: Re-generate.
6464
6465 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6466
6467         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
6468         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
6469         renamed to arm_nbsd_supply_gregset.
6470         (fetch_register): Update to call arm_nbsd_supply_gregset.
6471         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
6472         (arm_netbsd_nat_target::fetch_registers): Update.
6473         (fetch_elfcore_registers): Removed.
6474         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
6475         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
6476         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
6477         not require NetBSD system headers.
6478         (arm_nbsd_regset): New struct.
6479         (arm_nbsd_iterate_over_regset_sections): New function.
6480         (arm_netbsd_init_abi_common): Updated to call
6481         set_gdbarch_iterate_over_regset_sections.
6482         * arm-nbsd-tdep.h: New file.
6483
6484 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
6485
6486         * symtab.c (find_pc_sect_line): Add check which prevents infinite
6487         recursion.
6488
6489 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
6490
6491         * configure: Re-generate.
6492
6493 2020-03-11  Tom Tromey  <tromey@adacore.com>
6494
6495         * ada-typeprint.c (print_choices): Fix comment.
6496
6497 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
6500         previous item in the list, when the list has no items.
6501
6502 2020-03-11  Tom de Vries  <tdevries@suse.de>
6503
6504         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
6505         PROP_LOCLIST handling code.
6506
6507 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6508
6509         * buildsym-legacy.c (record_line): Pass extra parameter to
6510         record_line.
6511         * buildsym.c (buildsym_compunit::record_line): Take an extra
6512         parameter, reduce duplication in the line table, and record the
6513         is_stmt flag in the line table.
6514         * buildsym.h (buildsym_compunit::record_line): Add extra
6515         parameter.
6516         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
6517         non-statement lines.
6518         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
6519         this to the symtab builder.
6520         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
6521         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
6522         through to dwarf_record_line_1.
6523         * infrun.c (process_event_stop_test): When stepping, don't stop at
6524         a non-statement instruction, and only refresh the step info when
6525         we land in the middle of a line's range.  Also add an extra
6526         comment.
6527         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6528         field.
6529         * record-btrace.c (btrace_find_line_range): Only record lines
6530         marked as is-statement.
6531         * stack.c (frame_show_address): Show the frame address if we are
6532         in a non-statement sal.
6533         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6534         (maintenance_print_one_line_table): Print a header for the is_stmt
6535         column, and include is_stmt information in the output.
6536         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6537         preference to non-statements.
6538         (find_pcs_for_symtab_line): Prefer is-statement entries.
6539         (find_line_common): Likewise.
6540         * symtab.h (struct linetable_entry): Add is_stmt field.
6541         (struct symtab_and_line): Likewise.
6542         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6543         arranging the line table.
6544
6545 2020-03-07  Tom de Vries  <tdevries@suse.de>
6546
6547         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6548         DIE.
6549
6550 2020-03-07  Tom Tromey  <tom@tromey.com>
6551
6552         * valops.c (value_literal_complex): Remove obsolete comment.
6553         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6554         comment.
6555
6556 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6557
6558         * infrun.h: Forward-declare thread_info.
6559         (set_step_info): Add thread_info parameter, add doc.
6560         * infrun.c (set_step_info): Add thread_info parameter, move doc
6561         to header.
6562         * infrun.c (process_event_stop_test): Pass thread to
6563         set_step_info call.
6564         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
6565         set_step_info.
6566         (prepare_one_step): Add thread_info parameter, pass it to
6567         set_step_frame and prepare_one_step (recursive) call.
6568         (step_1): Pass thread to prepare_one_step call.
6569         (step_command_fsm::should_stop): Pass thread to
6570         prepare_one_step.
6571         (until_next_fsm): Pass thread to set_step_frame call.
6572         (finish_command): Pass thread to set_step_info call.
6573
6574 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
6575
6576         * windows-tdep.c (windows_solib_create_inferior_hook):
6577         Check if inferior is running.
6578
6579 2020-03-06  Tom de Vries  <tdevries@suse.de>
6580
6581         * NEWS: Fix "the the".
6582         * ctfread.c: Same.
6583
6584 2020-03-06  Tom de Vries  <tdevries@suse.de>
6585
6586         * psymtab.c (psymtab_to_symtab): Don't print "done.".
6587
6588 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * .dir-locals.el: Add a comment referencing the other copies of
6591         this file.
6592
6593 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
6594
6595         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
6596         psargs.
6597
6598 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6599
6600         * .gitattributes: New file.
6601
6602 2020-03-04  Tom Tromey  <tom@tromey.com>
6603
6604         * symmisc.c (print_symbol_bcache_statistics)
6605         (print_objfile_statistics): Update.
6606         * symfile.c (allocate_symtab): Use intern.
6607         * psymtab.c (partial_symtab::partial_symtab): Use intern.
6608         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6609         macro_cache>: Remove.
6610         <string_cache>: New member.
6611         (struct objfile) <intern>: New methods.
6612         * elfread.c (elf_symtab_read): Use intern.
6613         * dwarf2/read.c (fixup_go_packaging): Intern package name.
6614         (dwarf2_compute_name, dwarf2_physname)
6615         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
6616         names.
6617         (guess_partial_die_structure_name): Update.
6618         (partial_die_info::fixup): Intern name.
6619         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
6620         name.
6621         (dwarf2_name): Intern name.  Update.
6622         * buildsym.c (buildsym_compunit::get_macro_table): Use
6623         string_cache.
6624
6625 2020-03-04  Tom Tromey  <tom@tromey.com>
6626
6627         * jit.c (bfd_open_from_target_memory): Make "target" const.
6628         * corefile.c (gnutarget): Now const.
6629         * gdbcore.h (gnutarget): Now const.
6630
6631 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
6632
6633         * NEWS: Mention support for WOW64 processes.
6634         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
6635         (amd64_windows_segment_register_p): Remove static.
6636         (_initialize_amd64_windows_nat): Update.
6637         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
6638         * i386-windows-nat.c (context_offset): Update.
6639         (i386_mappings): Rename and remove static.
6640         (i386_windows_segment_register_p): Remove static.
6641         (_initialize_i386_windows_nat): Update.
6642         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
6643         (STATUS_WX86_SINGLE_STEP): New macro.
6644         (EnumProcessModulesEx): New macro.
6645         (Wow64SuspendThread): New macro.
6646         (Wow64GetThreadContext): New macro.
6647         (Wow64SetThreadContext): New macro.
6648         (Wow64GetThreadSelectorEntry): New macro.
6649         (windows_set_context_register_offsets): Add static.
6650         (windows_set_segment_register_p): Likewise.
6651         (windows_add_thread): Adapt for WOW64 processes.
6652         (windows_fetch_one_register): Likewise.
6653         (windows_nat_target::fetch_registers): Likewise.
6654         (windows_store_one_register): Likewise.
6655         (display_selector): Likewise.
6656         (display_selectors): Likewise.
6657         (handle_exception): Likewise.
6658         (windows_continue): Likewise.
6659         (windows_nat_target::resume): Likewise.
6660         (windows_add_all_dlls): Likewise.
6661         (do_initial_windows_stuff): Likewise.
6662         (windows_nat_target::attach): Likewise.
6663         (windows_get_exec_module_filename): Likewise.
6664         (windows_nat_target::create_inferior): Likewise.
6665         (windows_xfer_siginfo): Likewise.
6666         (_initialize_loadable): Initialize Wow64SuspendThread,
6667         Wow64GetThreadContext, Wow64SetThreadContext,
6668         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
6669         * windows-nat.h (windows_set_context_register_offsets):
6670         Remove declaration.
6671         (windows_set_segment_register_p): Likewise.
6672         (i386_windows_segment_register_p): Add declaration.
6673         (amd64_windows_segment_register_p): Likewise.
6674
6675 2020-03-04  Luis Machado  <luis.machado@linaro.org>
6676
6677         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
6678         in "info registers" for AArch64/ARM.
6679
6680         The change caused "info registers" to not print GPR's.
6681
6682         gdb/ChangeLog:
6683
6684         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
6685
6686         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
6687         when reg->group is empty and reggroup is not.
6688
6689 2020-03-03  Tom Tromey  <tromey@adacore.com>
6690
6691         * dwarf2/frame.c (struct dwarf2_frame_cache)
6692         <checked_tailcall_bottom, entry_cfa_sp_offset,
6693         entry_cfa_sp_offset_p>: Remove members.
6694         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
6695         (dwarf2_frame_prev_register): Don't call
6696         dwarf2_tailcall_sniffer_first.
6697         (dwarf2_append_unwinders): Don't append tailcall unwinder.
6698         * frame-unwind.c (add_unwinder): New fuction.
6699         (frame_unwind_init): Use it.  Add tailcall unwinder.
6700
6701 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6702             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
6703
6704         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
6705         value should be printed as true.
6706
6707 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
6708
6709         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
6710         (windows_init_abi): Set and use windows_so_ops.
6711
6712 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
6713
6714         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
6715         when verifying if dealing with a convenience variable.
6716
6717 2020-03-03  Luis Machado  <luis.machado@linaro.org>
6718
6719         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
6720
6721 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
6722
6723         * infrun.c (gdbarch_supports_displaced_stepping): New.
6724         (use_displaced_stepping): Break up conditions in smaller pieces.
6725         Use gdbarch_supports_displaced_stepping.
6726         (displaced_step_prepare_throw): Use
6727         gdbarch_supports_displaced_stepping.
6728
6729 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6730
6731         * NEWS: Mention new behaviour of the history filename.
6732         * top.c (write_history_p): Add comment.
6733         (show_write_history_p): Add header comment, give a different
6734         message when history writing is on, but the history filename is
6735         empty.
6736         (history_filename): Add comment.
6737         (history_filename_empty): New function.
6738         (show_history_filename): Add header comment, give a different
6739         message when the filename is empty.
6740         (init_history): Compare history_filename against nullptr, and only
6741         read history if the filename is not empty.
6742         (set_history_filename): Add header comment, and only make
6743         non-empty filenames absolute.
6744         (init_main): Make the filename argument to 'set history filename'
6745         optional.
6746
6747 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
6748
6749         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
6750         (arm_supply_vfpregset): ...this, and update to use VFP registers.
6751         (fetch_fp_register): Update.
6752         (fetch_fp_regs): Update.
6753         (store_fp_register): Update.
6754         (store_fp_regs): Update.
6755         (arm_netbsd_nat_target::read_description): New function.
6756         (fetch_elfcore_registers): Update.
6757
6758 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6759
6760         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
6761         general_thread if the stop reply is missing a thread-id.
6762         (remote_target::process_stop_reply): Use the first non-exited
6763         thread if the target didn't pass a thread-id.
6764         * infrun.c (do_target_wait): Move call to
6765         switch_to_inferior_no_thread to ....
6766         (do_target_wait_1): ... here.
6767
6768 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
6769
6770         * debuginfod-support.c: Include defs.h first.
6771
6772 2020-02-28  Tom de Vries  <tdevries@suse.de>
6773
6774         * symfile.c (set_initial_language): Use default language for lookup.
6775
6776 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
6777
6778         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
6779         reader variable, pass `this` to read_cutu_die_from_dwo.
6780
6781 2020-02-27  Aaron Merey  <amerey@redhat.com>
6782
6783         * source.c (open_source_file): Check for nullptr when computing
6784         srcpath.
6785
6786 2020-02-27  Tom Tromey  <tromey@adacore.com>
6787
6788         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
6789         member.
6790         (dwarf2_add_field): Don't update nfields.
6791         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
6792
6793 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6794
6795         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
6796         abs.
6797
6798 2020-02-26  Tom Tromey  <tom@tromey.com>
6799
6800         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
6801         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
6802         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
6803         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
6804         per_cu_data.
6805
6806 2020-02-26  Tom Tromey  <tom@tromey.com>
6807
6808         * dwarf2/index-write.c (psym_index_map): Change type.
6809         (add_address_entry_worker, write_one_signatured_type)
6810         (recursively_count_psymbols, recursively_write_psymbols)
6811         (class debug_names, psyms_seen_size, write_gdbindex)
6812         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
6813
6814 2020-02-26  Aaron Merey  <amerey@redhat.com>
6815
6816         * Makefile.in: Handle optional debuginfod support.
6817         * NEWS: Update.
6818         * README: Add --with-debuginfod summary.
6819         * config.in: Regenerate.
6820         * configure: Regenerate.
6821         * configure.ac: Handle optional debuginfod support.
6822         * debuginfod-support.c: debuginfod helper functions.
6823         * debuginfod-support.h: Ditto.
6824         * doc/gdb.texinfo: Add --with-debuginfod to configure options
6825         summary.
6826         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
6827         when a dwz file cannot be found.
6828         * elfread.c (elf_symfile_read): Query debuginfod servers when a
6829         debuginfo file cannot be found.
6830         * source.c (open_source_file): Query debuginfod servers when a
6831         source file cannot be found.
6832         * top.c (print_gdb_configuration): Include
6833         --{with,without}-debuginfod in the output.
6834
6835 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
6836
6837         * thread.c (thr_try_catch_cmd): Print thread name.
6838
6839 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
6840
6841         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
6842         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6843         dwarf2_fetch_die_type_sect_off): Move to...
6844         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
6845         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6846         dwarf2_fetch_die_type_sect_off): ... here.
6847         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
6848         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
6849         dwarf2_fetch_die_type_sect_off): Move doc to header file.
6850
6851 2020-02-26  Tom de Vries  <tdevries@suse.de>
6852
6853         PR gdb/25603
6854         * symfile.c (set_initial_language): Exit-early if
6855         language_mode == language_mode_manual.
6856
6857 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6858
6859         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
6860         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
6861         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
6862
6863 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
6864
6865         * gdbtypes.c (create_array_type_with_stride): Handle negative
6866         array strides.
6867         * valarith.c (value_subscripted_rvalue): Likewise.
6868
6869 2020-02-25  Luis Machado  <luis.machado@linaro.org>
6870
6871         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
6872
6873 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
6874
6875         * loc.h (dwarf2_get_die_type): Move to...
6876         * read.h (dwarf2_get_die_type): ... here.
6877         * read.c (dwarf2_get_die_type): Move doc to header.
6878
6879 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
6880
6881         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
6882         'gnulib/Makefile.in' to the list.
6883
6884 2020-02-24  Tom Tromey  <tom@tromey.com>
6885
6886         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
6887         Remove.
6888         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
6889         XOBNEWVEC.
6890
6891 2020-02-24  Tom Tromey  <tom@tromey.com>
6892
6893         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
6894         New method.
6895         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
6896         (dw2_do_instantiate_symtab, dw2_get_file_names)
6897         (build_type_psymtab_dependencies, load_full_type_unit): Update.
6898
6899 2020-02-24  Tom Tromey  <tom@tromey.com>
6900
6901         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
6902         make_scoped_restore.
6903         (dwarf2_psymtab::read_symtab): Don't clear
6904         reading_partial_symbols.
6905
6906 2020-02-24  Tom de Vries  <tdevries@suse.de>
6907
6908         PR gdb/25592
6909         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
6910
6911 2020-02-24  Tom de Vries  <tdevries@suse.de>
6912
6913         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
6914         commands layout next/prev/regs.
6915
6916 2020-02-22  Tom Tromey  <tom@tromey.com>
6917
6918         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
6919         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
6920
6921 2020-02-22  Tom Tromey  <tom@tromey.com>
6922
6923         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
6924
6925 2020-02-22  Tom Tromey  <tom@tromey.com>
6926
6927         * tui/tui-win.c (_initialize_tui_win): Add usage text.
6928         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
6929         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
6930         * tui/tui.c (_initialize_tui): Add usage text.
6931
6932 2020-02-22  Tom Tromey  <tom@tromey.com>
6933
6934         * tui/tui-win.c (tui_set_focus_command)
6935         (tui_set_win_height_command): Use error_no_arg.
6936         (_initialize_tui_win): Update help text.
6937         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
6938
6939 2020-02-22  Tom Tromey  <tom@tromey.com>
6940
6941         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
6942         * tui/tui-disasm.h (struct tui_disasm_window)
6943         <display_start_addr>: Declare.
6944         * tui/tui-source.h (struct tui_source_window)
6945         <display_start_addr>: Declare.
6946         * tui/tui-winsource.h (struct tui_source_window_base)
6947         <show_source_line, display_start_addr>: New methods.
6948         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
6949         Rename and move to protected section.
6950         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
6951         (tui_source_window_base::do_erase_source_content): Update.
6952         (tui_source_window_base::show_source_line): Now a method.
6953         (tui_source_window_base::show_source_content)
6954         (tui_source_window_base::tui_source_window_base)
6955         (tui_source_window_base::rerender)
6956         (tui_source_window_base::refill)
6957         (tui_source_window_base::do_scroll_horizontal)
6958         (tui_source_window_base::set_is_exec_point_at)
6959         (tui_source_window_base::update_breakpoint_info)
6960         (tui_source_window_base::update_exec_info): Update.
6961         * tui/tui-source.c (tui_source_window::set_contents)
6962         (tui_source_window::showing_source_p)
6963         (tui_source_window::do_scroll_vertical)
6964         (tui_source_window::location_matches_p)
6965         (tui_source_window::line_is_displayed): Update.
6966         (tui_source_window::display_start_addr): New method.
6967         * tui/tui-disasm.c (tui_disasm_window::set_contents)
6968         (tui_disasm_window::do_scroll_vertical)
6969         (tui_disasm_window::location_matches_p): Update.
6970         (tui_disasm_window::display_start_addr): New method.
6971
6972 2020-02-22  Tom Tromey  <tom@tromey.com>
6973
6974         * NEWS: Add entry for gdb.register_window_type.
6975         * tui/tui-layout.h (window_factory): New typedef.
6976         (tui_register_window): Declare.
6977         * tui/tui-layout.c (saved_tui_windows): New global.
6978         (tui_apply_current_layout): Use it.
6979         (tui_register_window): New function.
6980         * python/python.c (do_start_initialization): Call
6981         gdbpy_initialize_tui.
6982         (python_GdbMethods): Add "register_window_type" function.
6983         * python/python-internal.h (gdbpy_register_tui_window)
6984         (gdbpy_initialize_tui): Declare.
6985         * python/py-tui.c: New file.
6986         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
6987
6988 2020-02-22  Tom Tromey  <tom@tromey.com>
6989
6990         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
6991
6992 2020-02-22  Tom Tromey  <tom@tromey.com>
6993
6994         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
6995         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
6996         * tui/tui-data.c (tui_set_win_with_focus): Remove.
6997         (tui_set_win_focus_to): Move from tui-win.c.
6998
6999 2020-02-22  Tom Tromey  <tom@tromey.com>
7000
7001         * tui/tui-layout.c (make_standard_window, get_locator_window): New
7002         functions.
7003         (known_window_types): New global.
7004         (tui_get_window_by_name): Reimplement.
7005         (initialize_known_windows): New function.
7006         (validate_window_name): Rewrite.
7007         (_initialize_tui_layout): Call initialize_known_windows.
7008
7009 2020-02-22  Tom Tromey  <tom@tromey.com>
7010
7011         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
7012         Remove constants.
7013         * tui/tui-winsource.h (struct tui_source_window_base)
7014         <tui_source_window_base>: Remove parameter.
7015         * tui/tui-winsource.c
7016         (tui_source_window_base::tui_source_window_base): Remove
7017         parameter.
7018         (tui_source_window_base::refill): Update.
7019         * tui/tui-stack.h (struct tui_locator_window)
7020         <tui_locator_window>: Update.
7021         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
7022         Default the constructor.
7023         * tui/tui-regs.h (struct tui_data_item_window)
7024         <tui_data_item_window>: Default the constructor.
7025         (struct tui_data_window) <tui_data_window>: Likewise.
7026         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
7027         Default the constructor.
7028         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
7029         Default the constructor.
7030         <type>: Remove.
7031         (struct tui_win_info) <tui_win_info>: Default the constructor.
7032         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
7033         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
7034         Default the constructor.
7035
7036 2020-02-22  Tom Tromey  <tom@tromey.com>
7037
7038         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
7039         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
7040         * tui/tui-win.c (tui_resize_all): Don't call
7041         tui_delete_invisible_windows.
7042         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
7043         done.
7044         (tui_set_layout): Update.
7045         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
7046         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
7047         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
7048
7049 2020-02-22  Tom Tromey  <tom@tromey.com>
7050
7051         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
7052         correctly.
7053
7054 2020-02-22  Tom Tromey  <tom@tromey.com>
7055
7056         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
7057
7058 2020-02-22  Tom Tromey  <tom@tromey.com>
7059
7060         * tui/tui-winsource.h (struct tui_source_window_iterator)
7061         <inner_iterator>: New etytypedef.
7062         <tui_source_window_iterator>: Take "end" parameter.
7063         <tui_source_window_iterator>: Take iterator.
7064         <operator*, advance>: Update.
7065         <m_iter>: Change type.
7066         <m_end>: New field.
7067         (struct tui_source_windows) <begin, end>: Update.
7068         * tui/tui-layout.c (tui_windows): New global.
7069         (tui_apply_current_layout): Clear tui_windows.
7070         (tui_layout_window::apply): Update tui_windows.
7071         * tui/tui-data.h (tui_windows): Declare.
7072         (all_tui_windows): Now inline function.
7073         (class tui_window_iterator, struct all_tui_windows): Remove.
7074
7075 2020-02-22  Tom Tromey  <tom@tromey.com>
7076
7077         PR tui/17850:
7078         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
7079         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
7080         "height" argument.
7081         (class tui_layout_window) <get_sizes>: Likewise.
7082         (class tui_layout_split) <tui_layout_split>: Add "vertical"
7083         argument.
7084         <get_sizes>: Add "height" argument.
7085         <m_vertical>: New field.
7086         * tui/tui-layout.c (tui_layout_split::clone): Update.
7087         (tui_layout_split::get_sizes): Add "height" argument.
7088         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
7089         (tui_new_layout_command): Parse "-horizontal".
7090         (_initialize_tui_layout): Update help string.
7091         (tui_layout_split::specification): Add "-horizontal" when needed.
7092         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
7093         argument.
7094         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
7095         New methods.
7096
7097 2020-02-22  Tom Tromey  <tom@tromey.com>
7098
7099         * tui/tui-layout.h (enum tui_adjust_result): New.
7100         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
7101         (class tui_layout_window) <adjust_size>: Return
7102         tui_adjust_result.  Rewrite.
7103         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
7104         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
7105
7106 2020-02-22  Tom Tromey  <tom@tromey.com>
7107
7108         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
7109         parameter and return types.
7110         (class tui_layout_base) <specification>: Add "depth".
7111         (class tui_layout_window) <specification>: Add "depth".
7112         (class tui_layout_split) <specification>: Add "depth".
7113         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
7114         and return types.
7115         (tui_new_layout_command): Parse sub-layouts.
7116         (_initialize_tui_layout): Update help string.
7117         (tui_layout_window::specification): Add "depth".
7118         (add_layout_command): Update.
7119
7120 2020-02-22  Tom Tromey  <tom@tromey.com>
7121
7122         * NEWS: Add "tui new-layout" item.
7123         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
7124         Add new-layout command to help text.
7125         (validate_window_name): New function.
7126         (tui_new_layout_command): New function.
7127         (_initialize_tui_layout): Register "new-layout".
7128         (tui_layout_window::specification): New method.
7129         (tui_layout_window::specification): New method.
7130         * tui/tui-layout.h (class tui_layout_base) <specification>: New
7131         method.
7132         (class tui_layout_window) <specification>: New method.
7133         (class tui_layout_split) <specification>: New method.
7134
7135 2020-02-22  Tom Tromey  <tom@tromey.com>
7136
7137         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
7138         * tui/tui-win.c (window_name_completer): Update comment.
7139         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
7140         Declare method.
7141         (class tui_layout_window) <replace_window>: Likewise.
7142         (class tui_layout_split) <replace_window>: Likewise.
7143         (tui_set_layout): Don't declare.
7144         (tui_set_initial_layout): Declare function.
7145         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
7146         (asm_regs_layout): New globals.
7147         (tui_current_layout, show_layout): Remove.
7148         (tui_set_layout, tui_add_win_to_layout): Rewrite.
7149         (find_layout, tui_apply_layout): New function.
7150         (layout_completer): Remove.
7151         (tui_next_layout): Reimplement.
7152         (tui_next_layout_command): New function.
7153         (tui_set_initial_layout, tui_prev_layout_command): New functions.
7154         (tui_regs_layout): Reimplement.
7155         (tui_regs_layout_command): New function.
7156         (extract_display_start_addr): Rewrite.
7157         (next_layout, prev_layout): Remove.
7158         (tui_layout_window::replace_window): New method.
7159         (tui_layout_split::replace_window): New method.
7160         (destroy_layout): New function.
7161         (layout_list): New global.
7162         (add_layout_command): New function.
7163         (initialize_layouts): Update.
7164         (tui_layout_command): New function.
7165         (_initialize_tui_layout): Install "layout" commands.
7166         * tui/tui-data.h (enum tui_layout_type): Remove.
7167         (tui_current_layout): Don't declare.
7168
7169 2020-02-22  Tom Tromey  <tom@tromey.com>
7170
7171         * tui/tui-regs.c (tui_reg_layout): Remove.
7172         (tui_reg_command): Use tui_regs_layout.
7173         * tui/tui-layout.h (tui_reg_command): Declare.
7174         * tui/tui-layout.c (tui_reg_command): New function.
7175
7176 2020-02-22  Tom Tromey  <tom@tromey.com>
7177
7178         * tui/tui.c (tui_rl_delete_other_windows): Call
7179         tui_remove_some_windows.
7180         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
7181         Declare method.
7182         (class tui_layout_window) <remove_windows>: New method.
7183         (class tui_layout_split) <remove_windows>: Declare.
7184         (tui_remove_some_windows): Declare.
7185         * tui/tui-layout.c (tui_remove_some_windows): New function.
7186         (tui_layout_split::remove_windows): New method.
7187
7188 2020-02-22  Tom Tromey  <tom@tromey.com>
7189
7190         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
7191         * tui/tui-layout.h (tui_next_layout): Declare.
7192         * tui/tui-layout.c (tui_next_layout): New function.
7193
7194 2020-02-22  Tom Tromey  <tom@tromey.com>
7195
7196         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
7197         correct coordinates.
7198
7199 2020-02-22  Tom Tromey  <tom@tromey.com>
7200
7201         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
7202         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
7203         DATA_WIN case.
7204
7205 2020-02-22  Tom Tromey  <tom@tromey.com>
7206
7207         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
7208         TUI_DISASM_WIN, not tui_win_list.
7209
7210 2020-02-22  Tom Tromey  <tom@tromey.com>
7211
7212         * valprint.c (generic_val_print_enum_1)
7213         (val_print_type_code_flags): Style member names.
7214         * rust-lang.c (val_print_struct, rust_print_enum)
7215         (rust_print_struct_def, rust_internal_print_type): Style member
7216         names.
7217         * p-valprint.c (pascal_object_print_value_fields): Style member
7218         names.  Only call fprintf_symbol_filtered for static members.
7219         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
7220         * f-valprint.c (f_val_print): Style member names.
7221         * f-typeprint.c (f_type_print_base): Style member names.
7222         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
7223         call fprintf_symbol_filtered for static members.
7224         (cp_print_class_member): Style member names.
7225         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
7226         member names.
7227         * ada-valprint.c (ada_print_scalar): Style enum names.
7228         (ada_val_print_enum): Likewise.
7229         * ada-typeprint.c (print_enum_type): Style enum names.
7230
7231 2020-02-21  Tom Tromey  <tom@tromey.com>
7232
7233         * psympriv.h (struct partial_symtab): Update comment.
7234
7235 2020-02-21  Tom Tromey  <tromey@adacore.com>
7236
7237         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
7238         type is CORE_ADDR.
7239
7240 2020-02-21  Tom de Vries  <tdevries@suse.de>
7241
7242         PR gdb/25534
7243         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
7244         if dependencies[i]->user != NULL.
7245
7246 2020-02-21  Ali Tamur  <tamur@google.com>
7247
7248         * dwarf2/read.c (dwarf2_name): Add null check.
7249
7250 2020-02-20  Tom Tromey  <tom@tromey.com>
7251
7252         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
7253         ">=", in binary search.
7254         (dwarf2_find_containing_comp_unit): New overload.
7255         (run_test): New self-test.
7256         (_initialize_dwarf2_read): Register new test.
7257
7258 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
7259
7260         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
7261         * riscv-tdep.h: Likewise.
7262         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
7263         rv32-only CSR.
7264         * features/riscv/64bit-csr.xml: Regenerated.
7265
7266 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
7267             Tom Tromey  <tom@tromey.com>
7268
7269         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
7270         of 'fputc_unfiltered'.
7271         (putchar_unfiltered): Call 'fputc_unfiltered'.
7272         (fputc_unfiltered): Call 'fputs_unfiltered'.
7273
7274 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
7275
7276         * config.in: Regenerate.
7277         * configure: Regenerate.
7278         * configure.ac: Add --with-python-libdir option.
7279         * main.c: Use WITH_PYTHON_LIBDIR.
7280
7281 2020-02-19  Tom Tromey  <tom@tromey.com>
7282
7283         * symtab.c (general_symbol_info::compute_and_set_names): Use
7284         obstack_strndup.  Simplify call to symbol_set_demangled_name.
7285
7286 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
7287
7288         * dwarf2/read.c (allocate_signatured_type_table,
7289         allocate_dwo_unit_table, allocate_type_unit_groups_table,
7290         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
7291         Remove objfile parameter, update all callers.
7292
7293 2020-02-19  Doug Evans  <dje@google.com>
7294
7295         PR rust/25535
7296         * rust-lang.c (rust_print_enum): Apply embedded_offset to
7297         rust_enum_variant calculation.
7298
7299 2020-02-19  Tom Tromey  <tromey@adacore.com>
7300
7301         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
7302
7303 2020-02-19  Tom Tromey  <tromey@adacore.com>
7304
7305         * ada-lang.c (cache_symbol): Use obstack_strdup.
7306
7307 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7308
7309         * configure: Regenerate.
7310
7311 2020-02-19  Tom Tromey  <tromey@adacore.com>
7312
7313         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
7314         NULL check.
7315
7316 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
7317
7318         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
7319
7320 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
7323         if GDBSERVER is not defined.
7324         (riscv_tdesc_cache): Likewise, also store const target_desc.
7325         (STATIC_IN_GDB): Define.
7326         (riscv_create_target_description): Update declaration with
7327         STATIC_IN_GDB.
7328         (riscv_lookup_target_description): New function, only define if
7329         GDBSERVER is not defined.
7330         * arch/riscv.h (riscv_create_target_description): Declare only
7331         when GDBSERVER is defined.
7332         (riscv_lookup_target_description): New declaration when GDBSERVER
7333         is not defined.
7334         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
7335         (riscv_linux_read_features): ...this, and return
7336         riscv_gdbarch_features instead of target_desc.
7337         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
7338         (riscv_linux_read_description): Rename to...
7339         (riscv_linux_read_features): ...this.
7340         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7341         Update to use riscv_gdbarch_features and
7342         riscv_lookup_target_description.
7343         * riscv-tdep.c (riscv_find_default_target_description): Use
7344         riscv_lookup_target_description instead of
7345         riscv_create_target_description.
7346
7347 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7348
7349         * valprint.c (generic_val_print_enum_1): When printing a flag
7350         enum with value 0 and there is no enumerator with value 0, print
7351         just "0" instead of "(unknown: 0x0)".
7352
7353 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7354
7355         * valprint.c (generic_val_print_enum_1): Print unknown part of
7356         flag enum in hex.
7357
7358 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7359
7360         * dwarf2/read.c (update_enumeration_type_from_children): Allow
7361         flag enums to contain duplicate enumerators.
7362         * valprint.c (generic_val_print_enum_1): Update comment.
7363
7364 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7365
7366         * dwarf2/read.c: Include "count-one-bits.h".
7367         (update_enumeration_type_from_children): If an enumerator has
7368         multiple bits set, don't treat the enumeration as a "flag enum".
7369         * valprint.c (generic_val_print_enum_1): Assert that enumerators
7370         of flag enums have 0 or 1 bit set.
7371
7372 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7373
7374         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
7375         conversion.
7376         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7377         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7378         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7379         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7380         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7381
7382 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7383
7384         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
7385
7386 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7387
7388         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
7389         displaced_step_closure_up.
7390         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7391         (struct displaced_step_closure_up):
7392         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7393         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7394         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
7395         Likewise.
7396         * gdbarch.sh (displaced_step_copy_insn): Likewise.
7397         * gdbarch.c, gdbarch.h: Re-generate.
7398         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
7399         displaced_step_closure_up.
7400         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7401         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7402         * infrun.h (displaced_step_closure_up): New type alias.
7403         (struct displaced_step_inferior_state) <step_closure>: Change
7404         type to displaced_step_closure_up.
7405         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
7406         displaced_step_closure_up.
7407         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7408
7409 2020-02-14  Tom Tromey  <tom@tromey.com>
7410
7411         * minidebug.c (gnu_debug_key): New global.
7412         (find_separate_debug_file_in_section): Use it.
7413
7414 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7415
7416         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
7417         std::unique_ptr.
7418         * gdbarch.c: Re-generate.
7419         * gdbarch.h: Re-generate.
7420         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
7421         change.
7422         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
7423         type to std::unique_ptr.
7424         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7425         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7426         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7427         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7428         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
7429         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7430         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7431         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7432         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7433
7434 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7435
7436         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
7437         std::unique_ptr.
7438         (displaced_step_clear): Rename to...
7439         (displaced_step_reset): ... this.  Just call displaced->reset ().
7440         (displaced_step_clear_cleanup): Rename to...
7441         (displaced_step_reset_cleanup): ... this.
7442         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
7443         (displaced_step_fixup): Likewise.
7444         (resume_1): Likewise.
7445         (handle_inferior_event): Restore child's memory before calling
7446         displaced_step_fixup on the parent.
7447         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
7448         to std::unique_ptr.
7449         <step_closure>: Change type to std::unique_ptr.
7450
7451 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7452
7453         * arm-tdep.c: Include count-one-bits.h.
7454         (cleanup_block_store_pc): Use count_one_bits.
7455         (cleanup_block_load_pc): Use count_one_bits.
7456         (arm_copy_block_xfer): Use count_one_bits.
7457         (thumb2_copy_block_xfer): Use count_one_bits.
7458         (thumb_copy_pop_pc_16bit): Use count_one_bits.
7459         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
7460         (thumb_get_next_pcs_raw): Use count_one_bits.
7461         (arm_get_next_pcs_raw): Use count_one_bits_l.
7462         * arch/arm.c (bitcount): Remove.
7463         * arch/arm.h (bitcount): Remove.
7464
7465 2020-02-14  Tom Tromey  <tromey@adacore.com>
7466
7467         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
7468         Update.
7469         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
7470         * dwarf2/loc.c (call_site_find_chain_1): Return
7471         unique_xmalloc_ptr.
7472         (call_site_find_chain): Likewise.
7473
7474 2020-02-14  Richard Biener  <rguenther@suse.de>
7475
7476         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
7477         on expression with division operators.
7478
7479 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7480
7481         * MAINTAINERS (Write After Approval): Adding myself.
7482
7483 2020-02-12  Tom Tromey  <tom@tromey.com>
7484
7485         * event-loop.c (event_data, gdb_event, event_handler_func):
7486         Remove.
7487
7488 2020-02-12  Tom Tromey  <tom@tromey.com>
7489
7490         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
7491         (dwarf2_frame_objfile_data): Add comment.
7492         (find_comp_unit, set_comp_unit): New functions.
7493         (dwarf2_frame_find_fde): Use find_comp_unit.
7494         (dwarf2_build_frame_info): Use set_comp_unit.
7495
7496 2020-02-12  Tom Tromey  <tom@tromey.com>
7497
7498         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
7499         (comp_unit): Don't initialize objfile.
7500         (execute_cfa_program): Add text_offset parameter.
7501         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
7502         (dwarf2_frame_cache): Update.
7503         (dwarf2_build_frame_info): Don't set "objfile" member.
7504
7505 2020-02-12  Tom Tromey  <tom@tromey.com>
7506
7507         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
7508         (decode_frame_entry): Likewise.
7509         (dwarf2_build_frame_info): Update.
7510
7511 2020-02-12  Tom Tromey  <tom@tromey.com>
7512
7513         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
7514         (decode_frame_entry_1): Use the comp_unit obstack.
7515
7516 2020-02-12  Tom Tromey  <tom@tromey.com>
7517
7518         * dwarf2/frame.c (struct comp_unit): Add initializers and
7519         constructor.
7520         (dwarf2_frame_objfile_data): Store a comp_unit.
7521         (dwarf2_frame_find_fde): Update.
7522         (dwarf2_build_frame_info): Use "new".
7523
7524 2020-02-12  Tom Tromey  <tom@tromey.com>
7525
7526         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7527         (dwarf2_fde_table): Typedef for std::vector.
7528         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7529         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7530         (decode_frame_entry): Update.
7531         (dwarf2_build_frame_info): Use "new".
7532
7533 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7534
7535         * arm-tdep.c (arm_gdbarch_init): Update.
7536         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7537         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7538         have_neon, is_m>: Change to bool.
7539
7540 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7541
7542         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7543
7544 2020-02-12  Tom Tromey  <tom@tromey.com>
7545
7546         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7547
7548 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7549
7550         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7551         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7552
7553 2020-02-11  Tom Tromey  <tom@tromey.com>
7554
7555         * psymtab.h: Update comment.
7556
7557 2020-02-11  Tom Tromey  <tom@tromey.com>
7558
7559         * gdb_obstack.h (struct auto_obstack): Use
7560         DISABLE_COPY_AND_ASSIGN.
7561
7562 2020-02-11  Tom Tromey  <tom@tromey.com>
7563
7564         * dwarf2/frame.h (struct objfile): Don't forward declare.
7565
7566 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7567
7568         * cris-tdep.c (cris_supply_gregset): Change signature to match
7569         what struct regset expects.
7570         (cris_regset): New struct.
7571         (fetch_core_registers): Remove.
7572         (cris_iterate_over_regset_sections): New function.
7573         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
7574         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
7575
7576 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7577
7578         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
7579         registers.
7580
7581 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
7582
7583         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
7584
7585 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7586
7587         * configure: Re-generate.
7588
7589 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7590
7591         * configure: Re-generate.
7592
7593 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
7594
7595         * acinclude: Update warning.m4 path.
7596         * warning.m4: Move to gdbsupport.
7597
7598 2020-02-11  Tom Tromey  <tromey@adacore.com>
7599
7600         * remote.c (remote_console_output): Update.
7601         * printcmd.c (printf_command): Update.
7602         * event-loop.c (gdb_wait_for_event): Update.
7603         * linux-nat.c (sigchld_handler): Update.
7604         * remote-sim.c (gdb_os_write_stdout): Update.
7605         (gdb_os_flush_stdout): Update.
7606         (gdb_os_flush_stderr): Update.
7607         (gdb_os_write_stderr): Update.
7608         * exceptions.c (print_exception): Update.
7609         * remote-fileio.c (remote_fileio_func_read): Update.
7610         (remote_fileio_func_write): Update.
7611         * tui/tui.c (tui_enable): Update.
7612         * tui/tui-interp.c (tui_interp::init): Update.
7613         * utils.c (init_page_info): Update.
7614         (putchar_unfiltered, fputc_unfiltered): Update.
7615         (gdb_flush): Update.
7616         (emit_style_escape): Update.
7617         (flush_wrap_buffer, fputs_maybe_filtered): Update.
7618         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
7619         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
7620         (stderr_file::write): Update.
7621         (stderr_file::puts): Update.
7622         * ui-file.h (ui_file_isatty, ui_file_write)
7623         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
7624         (ui_file_puts): Don't declare.
7625
7626 2020-02-10  Tom de Vries  <tdevries@suse.de>
7627
7628         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
7629         sentinel to char *.
7630
7631 2020-02-09  Tom de Vries  <tdevries@suse.de>
7632
7633         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
7634         filename if it matches "<artificial>".
7635
7636 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7637
7638         * windows-tdep.c (struct enum_value_name): New struct.
7639         (create_enum): New function.
7640         (windows_get_siginfo_type): Create and use enum types.
7641
7642 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
7643
7644         * NEWS: Mention $_siginfo support for Windows.
7645         * windows-nat.c (handle_exception): Set siginfo_er.
7646         (windows_nat_target::mourn_inferior): Reset siginfo_er.
7647         (windows_xfer_siginfo): New function.
7648         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
7649         * windows-tdep.c (struct windows_gdbarch_data): New struct.
7650         (init_windows_gdbarch_data): New function.
7651         (get_windows_gdbarch_data): New function.
7652         (windows_get_siginfo_type): New function.
7653         (windows_init_abi): Register windows_get_siginfo_type.
7654         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
7655
7656 2020-02-08  Tom Tromey  <tom@tromey.com>
7657
7658         * dwarf2/read.c (class cutu_reader) <cutu_reader,
7659         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
7660         <keep>: Declare method.
7661         <m_keep>: Remove member.
7662         <~cutu_reader>: Remove.
7663         (cutu_reader::init_tu_and_read_dwo_dies): Update.
7664         (cutu_reader::cutu_reader): Update.
7665         (cutu_reader::keep): Rename from ~cutu_reader.
7666         (process_psymtab_comp_unit, build_type_psymtabs_1)
7667         (process_skeletonless_type_unit, load_partial_comp_unit)
7668         (load_full_comp_unit, dwarf2_read_addr_index)
7669         (read_signatured_type): Update.
7670
7671 2020-02-08  Tom Tromey  <tom@tromey.com>
7672
7673         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
7674         "want_partial_unit" parameter.
7675         (process_psymtab_comp_unit): Change want_partial_unit to bool.
7676         Inline check for DW_TAG_partial_unit.
7677         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
7678
7679 2020-02-08  Tom Tromey  <tom@tromey.com>
7680
7681         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
7682         read.c.
7683         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
7684         read.c.
7685
7686 2020-02-08  Tom Tromey  <tom@tromey.com>
7687
7688         * dwarf2/read.c (read_address): Move to comp-unit.c.
7689         (dwarf2_rnglists_process, dwarf2_ranges_process)
7690         (read_attribute_value, dwarf_decode_lines_1)
7691         (var_decode_location, decode_locdesc): Update.
7692         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
7693         read.c.  Remove "cu" parameter.
7694         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
7695         method.
7696
7697 2020-02-08  Tom Tromey  <tom@tromey.com>
7698
7699         * dwarf2/read.c (read_attribute_value, read_indirect_string)
7700         (read_indirect_line_string): Update.
7701         * dwarf2/comp-unit.c (read_offset): Remove.
7702         (read_comp_unit_head): Update.
7703         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
7704         method.
7705         (read_offset): Don't declare.
7706
7707 2020-02-08  Tom Tromey  <tom@tromey.com>
7708
7709         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
7710         * dwarf2/read.c (struct comp_unit_head): Move to
7711         dwarf2/comp-unit.h.
7712         (enum class rcuh_kind): Move to comp-unit.h.
7713         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
7714         (read_comp_unit_head, error_check_comp_unit_head)
7715         (read_and_check_comp_unit_head): Move to comp-unit.c.
7716         (read_offset, dwarf_unit_type_name): Likewise.
7717         (create_debug_type_hash_table, read_cutu_die_from_dwo)
7718         (cutu_reader::cutu_reader, read_call_site_scope)
7719         (find_partial_die, follow_die_offset): Update.
7720         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
7721
7722 2020-02-08  Tom Tromey  <tom@tromey.com>
7723
7724         * dwarf2/read.c (read_offset_1): Move to leb.c.
7725         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
7726         (dwarf_decode_macro_bytes): Update.
7727         * dwarf2/leb.c (read_offset): Rename; move from read.c.
7728         * dwarf2/leb.h (read_offset): Declare.
7729
7730 2020-02-08  Tom Tromey  <tom@tromey.com>
7731
7732         * dwarf2/read.c (dwarf2_section_size): Remove.
7733         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
7734         Update.
7735         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
7736
7737 2020-02-08  Tom Tromey  <tom@tromey.com>
7738
7739         * dwarf2/read.c (read_initial_length): Move to leb.c.
7740         * dwarf2/leb.h (read_initial_length): Declare.
7741         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
7742         handle_nonstd parameter.
7743         * dwarf2/frame.c (read_initial_length): Remove.
7744         (decode_frame_entry_1): Update.
7745
7746 2020-02-08  Tom Tromey  <tom@tromey.com>
7747
7748         * dwarf2/loc.c (dwarf2_find_location_expression)
7749         (dwarf_evaluate_loc_desc::get_tls_address)
7750         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
7751         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
7752         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
7753         (dwarf2_compile_property_to_c)
7754         (dwarf2_loc_desc_get_symbol_read_needs)
7755         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
7756         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
7757         (loclist_describe_location, loclist_tracepoint_var_ref)
7758         (loclist_generate_c_location): Update.
7759         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
7760         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
7761         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
7762         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
7763         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
7764         (dwarf2_per_cu_data::addr_size)
7765         (dwarf2_per_cu_data::ref_addr_size)
7766         (dwarf2_per_cu_data::text_offset)
7767         (dwarf2_per_cu_data::addr_type): Now methods.
7768         (per_cu_header_read_in): Make per_cu "const".
7769         (dwarf2_version): Remove.
7770         (dwarf2_per_cu_data::int_type): Now a method.
7771         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
7772         (set_die_type, read_array_type, read_subrange_index_type)
7773         (read_tag_string_type, read_subrange_type): Update.
7774         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
7775         offset_size, ref_addr_size, text_offset, addr_type, version,
7776         objfile, int_type, addr_sized_int_type>: Declare methods.
7777
7778 2020-02-08  Tom Tromey  <tom@tromey.com>
7779
7780         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
7781         Move earlier.
7782
7783 2020-02-08  Tom Tromey  <tom@tromey.com>
7784
7785         * dwarf2/read.h (dwarf_line_debug): Declare.
7786         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
7787         * dwarf2/read.c: Move line_header code to new files.
7788         (dwarf_line_debug): No longer static.
7789         * dwarf2/line-header.c: New file.
7790         * dwarf2/line-header.h: New file.
7791
7792 2020-02-08  Tom Tromey  <tom@tromey.com>
7793
7794         * dwarf2/read.c (struct line_header) <file_full_name,
7795         file_file_name>: Return unique_xmalloc_ptr.
7796         (line_header::file_file_name): Update.
7797         (line_header::file_full_name): Update.
7798         (dw2_get_file_names_reader): Update.
7799         (macro_start_file): Update.
7800
7801 2020-02-08  Tom Tromey  <tom@tromey.com>
7802
7803         * dwarf2/read.c (struct line_header) <file_full_name,
7804         file_file_name>: Declare methods.
7805         (dw2_get_file_names_reader): Update.
7806         (file_file_name): Now a method.
7807         (file_full_name): Likewise.
7808         (macro_start_file): Update.
7809
7810 2020-02-08  Tom Tromey  <tom@tromey.com>
7811
7812         * dwarf2/read.c (dwarf_always_disassemble)
7813         (show_dwarf_always_disassemble): Move to loc.c.
7814         (_initialize_dwarf2_read): Move "always-disassemble" registration
7815         to loc.c.
7816         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
7817         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
7818         static.
7819         (show_dwarf_always_disassemble): Move from read.c.
7820         (_initialize_dwarf2loc): Move always-disassemble from read.c.
7821
7822 2020-02-08  Tom Tromey  <tom@tromey.com>
7823
7824         * dwarf2/read.c (~dwarf2_per_objfile): Update.
7825         (create_quick_file_names_table): Return htab_up.
7826         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
7827         Update.
7828         * dwarf2/read.h (struct dwarf2_per_objfile)
7829         <quick_file_names_table>: Now htab_up.
7830
7831 2020-02-08  Tom Tromey  <tom@tromey.com>
7832
7833         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
7834
7835 2020-02-08  Tom Tromey  <tom@tromey.com>
7836
7837         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
7838         Rewrite.
7839         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
7840         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
7841         (abbrev_table::abbrev_table): No longer inline.
7842         (ABBREV_HASH_SIZE): Remove.
7843         (abbrev_table::m_abbrevs): Now an htab_up.
7844
7845 2020-02-08  Tom Tromey  <tom@tromey.com>
7846
7847         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
7848         (cutu_reader): Update.
7849         (build_type_psymtabs_1): Update.
7850         * dwarf2/abbrev.c (abbrev_table::read): Rename.
7851         (abbrev_table::alloc_abbrev): Update.
7852         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
7853         (abbrev_table::read): New static method, renamed from
7854         abbrev_table_read_table.
7855         (abbrev_table::alloc_abbrev)
7856         (abbrev_table::add_abbrev): Now private.
7857         (abbrev_table::abbrev_table): Now private.
7858         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
7859
7860 2020-02-08  Tom Tromey  <tom@tromey.com>
7861
7862         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
7863         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
7864         htab_up.
7865
7866 2020-02-08  Tom Tromey  <tom@tromey.com>
7867
7868         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
7869         htab_up.
7870         (lookup_dwo_unit_in_dwp): Update.
7871         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
7872         on obstack.
7873
7874 2020-02-08  Tom Tromey  <tom@tromey.com>
7875
7876         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
7877         obstack.
7878
7879 2020-02-08  Tom Tromey  <tom@tromey.com>
7880
7881         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
7882         line_header_hash.
7883         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
7884         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
7885         Change type to htab_up.
7886
7887 2020-02-08  Tom Tromey  <tom@tromey.com>
7888
7889         * dwarf2/read.c (allocate_type_unit_groups_table): Return
7890         htab_up.  Don't allocate on obstack.
7891         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
7892         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
7893         Change type to htab_up.
7894
7895 2020-02-08  Tom Tromey  <tom@tromey.com>
7896
7897         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
7898         Change type to htab_up.
7899         * dwarf2/read.c (create_signatured_type_table_from_index)
7900         (create_signatured_type_table_from_debug_names)
7901         (create_all_type_units, add_type_unit)
7902         (lookup_dwo_signatured_type, lookup_signatured_type)
7903         (process_skeletonless_type_unit): Update.
7904         (create_debug_type_hash_table, create_debug_types_hash_table):
7905         Change type of types_htab.
7906         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
7907         htab_up.  Don't allocate on obstack.
7908         (create_cus_hash_table): Change type of cus_htab parameter.
7909         (struct dwo_file) <cus, tus>: Now htab_up.
7910         (lookup_dwo_signatured_type, lookup_dwo_cutu)
7911         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
7912         (queue_and_load_all_dwo_tus): Update.
7913         * dwarf2/index-write.c (write_gdbindex): Update.
7914         (write_debug_names): Update.
7915
7916 2020-02-08  Tom Tromey  <tom@tromey.com>
7917
7918         * dwarf2/read.h (struct dwarf2_queue_item): Move from
7919         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
7920         destructor.
7921         (struct dwarf2_per_objfile) <queue>: New member.
7922         * dwarf2/read.c (struct dwarf2_queue_item): Move to
7923         dwarf2/read.h.
7924         (dwarf2_queue, dwarf2_queue_tail): Remove.
7925         (class dwarf2_queue_guard): Add parameter to constructor.  Use
7926         DISABLE_COPY_AND_ASSIGN.
7927         <m_per_objfile>: New member.
7928         <~dwarf2_queue_guard>: Rewrite.
7929         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
7930         Update.
7931         (~dwarf2_queue_item): New.
7932
7933 2020-02-08  Tom Tromey  <tom@tromey.com>
7934
7935         * dwarf2/read.c (struct die_info) <has_children>: New member.
7936         (dw2_get_file_names_reader): Remove has_children.
7937         (dw2_get_file_names): Update.
7938         (read_cutu_die_from_dwo): Remove has_children.
7939         (cutu_reader::init_tu_and_read_dwo_dies)
7940         (cutu_reader::cutu_reader): Update.
7941         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
7942         Remove has_children.
7943         (build_type_psymtabs_1, process_skeletonless_type_unit)
7944         (load_partial_comp_unit, load_full_comp_unit): Update.
7945         (create_dwo_cu_reader): Remove has_children.
7946         (create_cus_hash_table, read_die_and_children): Update.
7947         (read_full_die_1,read_full_die): Remove has_children.
7948         (read_signatured_type): Update.
7949         (class cutu_reader) <has_children>: Remove.
7950
7951 2020-02-08  Tom Tromey  <tom@tromey.com>
7952
7953         * dwarf2/expr.c: Rename from dwarf2expr.c.
7954         * dwarf2/expr.h: Rename from dwarf2expr.h.
7955         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
7956         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
7957         * dwarf2/frame.c: Rename from dwarf2-frame.c.
7958         * dwarf2/frame.h: Rename from dwarf2-frame.h.
7959         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
7960         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
7961         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
7962         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
7963         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
7964         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
7965         * dwarf2/loc.c: Rename from dwarf2loc.c.
7966         * dwarf2/loc.h: Rename from dwarf2loc.h.
7967         * dwarf2/read.c: Rename from dwarf2read.c.
7968         * dwarf2/read.h: Rename from dwarf2read.h.
7969         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
7970         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
7971         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
7972         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
7973         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
7974         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
7975         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
7976         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
7977         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
7978         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
7979         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
7980         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
7981         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
7982         Update.
7983         * Makefile.in (COMMON_SFILES): Update.
7984         (HFILES_NO_SRCDIR): Update.
7985
7986 2020-02-08  Tom Tromey  <tom@tromey.com>
7987
7988         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
7989         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
7990
7991 2020-02-08  Tom Tromey  <tom@tromey.com>
7992
7993         * dwarf2read.h (struct die_info): Don't declare.
7994
7995 2020-02-08  Tom Tromey  <tom@tromey.com>
7996
7997         * dwarf2read.h (die_info_ptr): Remove typedef.
7998
7999 2020-02-08  Tom Tromey  <tom@tromey.com>
8000
8001         * dwarf2read.c (read_call_site_scope)
8002         (handle_data_member_location, dwarf2_add_member_fn)
8003         (mark_common_block_symbol_computed, read_common_block)
8004         (attr_to_dynamic_prop, partial_die_info::read)
8005         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
8006         (dwarf2_symbol_mark_computed, set_die_type): Update.
8007         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
8008         method.
8009         (attr_form_is_block): Don't declare.
8010         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
8011
8012 2020-02-08  Tom Tromey  <tom@tromey.com>
8013
8014         * dwarf2read.c (dwarf2_find_base_address, )
8015         (read_call_site_scope, rust_containing_type)
8016         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
8017         (handle_data_member_location, dwarf2_add_member_fn)
8018         (get_alignment, read_structure_type, process_structure_scope)
8019         (mark_common_block_symbol_computed, read_common_block)
8020         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
8021         (partial_die_info::read, read_attribute_value, new_symbol)
8022         (lookup_die_type, dwarf2_get_ref_die_offset)
8023         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
8024         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
8025         (dwarf2_symbol_mark_computed): Update.
8026         * dwarf2/attribute.h (struct attribute) <value_as_address,
8027         form_is_section_offset, form_is_constant, form_is_ref>: Declare
8028         methods.
8029         (value_as_address, attr_form_is_section_offset)
8030         (attr_form_is_constant, attr_form_is_ref): Don't declare.
8031         * dwarf2/attribute.c (attribute::value_as_address)
8032         (attribute::form_is_section_offset, attribute::form_is_constant)
8033         (attribute::form_is_ref): Now methods.
8034
8035 2020-02-08  Tom Tromey  <tom@tromey.com>
8036
8037         * dwarf2read.c (struct attribute, DW_STRING)
8038         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
8039         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
8040         (attr_form_is_block, attr_form_is_section_offset)
8041         (attr_form_is_constant, attr_form_is_ref): Move.
8042         * dwarf2/attribute.h: New file.
8043         * dwarf2/attribute.c: New file, from dwarf2read.c.
8044         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
8045
8046 2020-02-08  Tom Tromey  <tom@tromey.com>
8047
8048         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
8049         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
8050         Move.
8051         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
8052         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
8053         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
8054         abbrev.c.
8055         * dwarf2/abbrev.h: New file.
8056         * dwarf2/abbrev.c: New file, from dwarf2read.c.
8057         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
8058
8059 2020-02-08  Tom Tromey  <tom@tromey.com>
8060
8061         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
8062         (dwarf2_section_size, dwarf2_get_section_info)
8063         (create_signatured_type_table_from_debug_names)
8064         (create_addrmap_from_aranges, read_debug_names_from_section)
8065         (get_gdb_index_contents_from_section, read_comp_unit_head)
8066         (error_check_comp_unit_head, read_abbrev_offset)
8067         (create_debug_type_hash_table, init_cu_die_reader)
8068         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
8069         (read_comp_units_from_section, create_cus_hash_table)
8070         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
8071         (create_dwp_v2_section, dwarf2_rnglists_process)
8072         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
8073         (abbrev_table_read_table, read_indirect_string_at_offset_from)
8074         (read_indirect_string_from_dwz, read_addr_index_1)
8075         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
8076         (dwarf_decode_macro_bytes, dwarf_decode_macros)
8077         (fill_in_loclist_baton): Update.
8078         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
8079         get_containing_section, get_bfd_owner, get_bfd_section,
8080         get_file_name, get_id, get_flags, empty, read>: Declare methods.
8081         (dwarf2_read_section, get_section_name, get_section_file_name)
8082         (get_containing_section, get_section_bfd_owner)
8083         (get_section_bfd_section, get_section_name, get_section_file_name)
8084         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
8085         declare.
8086         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
8087         (dwarf2_section_info::get_bfd_owner)
8088         (dwarf2_section_info::get_bfd_section)
8089         (dwarf2_section_info::get_name)
8090         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
8091         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
8092         (dwarf2_section_info::read): Now methods.
8093         * dwarf-index-write.c (class debug_names): Update.
8094
8095 2020-02-08  Tom Tromey  <tom@tromey.com>
8096
8097         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
8098         Move to dwarf2/section.h.
8099         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
8100         (get_section_bfd_section, get_section_name)
8101         (get_section_file_name, get_section_id, get_section_flags)
8102         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
8103         dwarf2/section.c.
8104         * dwarf2/section.h: New file.
8105         * dwarf2/section.c: New file, from dwarf2read.c.
8106         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
8107
8108 2020-02-08  Tom Tromey  <tom@tromey.com>
8109
8110         * dwarf2read.h (read_unsigned_leb128): Don't declare.
8111         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
8112         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
8113         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
8114         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
8115         * dwarf2/leb.h: New file, from dwarf2read.c.
8116         * dwarf2/leb.c: New file, from dwarf2read.c.
8117         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
8118         Remove.
8119         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
8120         (COMMON_SFILES): Add dwarf2/leb.c.
8121
8122 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
8123
8124         GDB 9.1 released.
8125
8126 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8127
8128         PR gdb/25190:
8129         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
8130         * gdb/remote.c (remote_console_output): Update.
8131         * gdb/ui-file.c (fputs_unfiltered): Rename to...
8132         (ui_file_puts): ...this.
8133         * gdb/ui-file.h (ui_file_puts): Add declaration.
8134         * gdb/utils.c (emit_style_escape): Update.
8135         (flush_wrap_buffer): Update.
8136         (fputs_maybe_filtered): Update.
8137         (fputs_unfiltered): Add function.
8138
8139 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8140
8141         * gdb/event-loop.c (gdb_wait_for_event): Update.
8142         * gdb/printcmd.c (printf_command): Update.
8143         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
8144         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
8145         (gdb_os_flush_stderr): Update.
8146         * gdb/remote.c (remote_console_output): Update.
8147         * gdb/ui-file.c (gdb_flush): Rename to...
8148         (ui_file_flush): ...this.
8149         (stderr_file::write): Update.
8150         (stderr_file::puts): Update.
8151         * gdb/ui-file.h (gdb_flush): Rename to...
8152         (ui_file_flush): ...this.
8153         * gdb/utils.c (gdb_flush): Add function.
8154         * gdb/utils.h (gdb_flush): Add declaration.
8155
8156 2020-02-07  Tom Tromey  <tromey@adacore.com>
8157
8158         PR breakpoints/24915:
8159         * source.c (find_and_open_source): Do not check basenames_may_differ.
8160
8161 2020-02-07  Tom Tromey  <tom@tromey.com>
8162
8163         * README: Update gdbserver documentation.
8164         * gdbserver: Move to top level.
8165         * configure.tgt (build_gdbserver): Remove.
8166         * configure.ac: Remove --enable-gdbserver.
8167         * configure: Rebuild.
8168         * Makefile.in (distclean): Don't mention gdbserver.
8169
8170 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8171
8172         * source-cache.c (source_cache::ensure): Surround
8173         get_plain_source_lines with a try/catch.
8174         (source_cache::get_line_charpos): Get rid of try/catch
8175         and only check for the return value of "ensure".
8176         * tui/tui-source.c (tui_source_window::set_contents):
8177         Simplify "nlines" calculation.
8178
8179 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8180
8181         * MAINTAINERS (Write After Approval): Add myself.
8182
8183 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8184
8185         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
8186         function call.
8187
8188 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8189
8190         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
8191
8192 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
8193
8194         * nat/riscv-linux-tdesc.h: New file.
8195         * nat/riscv-linux-tdesc.c: New file, taking code from...
8196         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8197         ... here.
8198         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
8199         NATDEPFILES.
8200
8201 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
8204         we don't set the fake simulator ptid to the null_ptid.
8205
8206 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
8207
8208         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
8209         * gdbthread.h (class thread_info) <resumed>: Likewise.
8210         * infrun.c (resume_1): Likewise.
8211         (proceed): Likewise.
8212         (infrun_thread_stop_requested): Likewise.
8213         (stop_all_threads): Likewise.
8214         (handle_inferior_event): Likewise.
8215         (restart_threads): Likewise.
8216         (finish_step_over): Likewise.
8217         (keep_going_stepped_thread): Likewise.
8218         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
8219         (linux_handle_extended_wait): Likewise.
8220         * record-btrace.c (get_thread_current_frame_id): Likewise.
8221         * record-full.c (record_full_wait_1): Likewise.
8222         * remote.c (remote_target::process_initial_stop_replies): Likewise.
8223         * target.c (target_resume): Likewise.
8224         * thread.c (set_running_thread): Likewise.
8225
8226 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8227
8228         * f-valprint.c (f77_print_array_1): Changed datatype of index
8229         variable to LONGEST from int to enable it to contain bound
8230         values correctly.
8231
8232 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
8233
8234         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
8235         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
8236         offsets according to FLEN determined.
8237         (riscv_linux_nat_target::read_description): Determine FLEN
8238         dynamically.
8239         (riscv_linux_nat_target::fetch_registers): Size regset buffer
8240         according to FLEN determined.
8241         (riscv_linux_nat_target::store_registers): Likewise.
8242
8243 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8244
8245         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8246         when reg->group is empty and reggroup is not.
8247
8248 2020-01-31  Tom Tromey  <tromey@adacore.com>
8249
8250         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
8251         Call beneath target's mourn_inferior after unpushing.
8252
8253 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8254
8255         PR tui/9765
8256         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
8257         have enough lines to fill the screen, still return the lowest
8258         address we found.
8259
8260 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
8263         '-', '<', and '>' commands.
8264
8265 2020-01-29  Pedro Alves  <palves@redhat.com>
8266             Sergio Durigan Junior  <sergiodj@redhat.com>
8267
8268         * infcmd.c (construct_inferior_arguments): Assert that
8269         'argc' is greater than 0.
8270
8271 2020-01-29  Luis Machado  <luis.machado@linaro.org>
8272
8273         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
8274         (BRK_INSN_MASK): Define to 0xd4200000.
8275         (aarch64_program_breakpoint_here_p): New function.
8276         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
8277         * arch-utils.c (default_program_breakpoint_here_p): Moved from
8278         breakpoint.c.
8279         * arch-utils.h (default_program_breakpoint_here_p): Moved from
8280         breakpoint.h
8281         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
8282         call gdbarch_program_breakpoint_here_p.
8283         (program_breakpoint_here): Moved to arch-utils.c, renamed to
8284         default_program_breakpoint_here_p, changed return type to bool and
8285         simplified.
8286         * breakpoint.h (program_breakpoint_here): Moved prototype to
8287         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
8288         return type to bool.
8289         * gdbarch.c: Regenerate.
8290         * gdbarch.h: Regenerate.
8291         * gdbarch.sh (program_breakpoint_here_p): New method.
8292         * infrun.c (handle_signal_stop): Call
8293         gdbarch_program_breakpoint_here_p.
8294
8295 2020-01-26  Tom Tromey  <tom@tromey.com>
8296
8297         * ctfread.c (struct ctf_fp_info): Reindent.
8298         (_initialize_ctfread): Remove.
8299
8300 2020-01-26  Tom Tromey  <tom@tromey.com>
8301
8302         * psymtab.c (partial_map_expand_apply)
8303         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
8304         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
8305         (psym_print_stats, psym_expand_symtabs_for_function)
8306         (psym_map_symbol_filenames, psym_map_matching_symbols)
8307         (psym_expand_symtabs_matching)
8308         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
8309         (maintenance_check_psymtabs): Use new methods.
8310         * psympriv.h (struct partial_symtab) <readin_p,
8311         get_compunit_symtab>: New methods.
8312         <readin, compunit_symtab>: Remove members.
8313         (struct standard_psymtab): New.
8314         (struct legacy_psymtab): Derive from standard_psymtab.
8315         * dwarf2read.h (struct dwarf2_psymtab): Derive from
8316         standard_psymtab.
8317         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
8318
8319 2020-01-26  Tom Tromey  <tom@tromey.com>
8320
8321         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
8322         read_dependencies.  Add assert.
8323         * psymtab.c (partial_symtab::read_dependencies): New method.
8324         * psympriv.h (struct partial_symtab) <read_dependencies>: New
8325         method.
8326         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
8327         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
8328         read_dependencies.
8329         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
8330         Add assert.
8331
8332 2020-01-26  Tom Tromey  <tom@tromey.com>
8333
8334         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
8335         Call expand_psymtab.
8336         (xcoff_read_symtab): Call expand_psymtab.
8337         (xcoff_start_psymtab, xcoff_end_psymtab): Set
8338         legacy_expand_psymtab.
8339         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
8340         method.
8341         (struct legacy_psymtab) <expand_psymtab>: Implement.
8342         <legacy_expand_psymtab>: New member.
8343         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
8344         (parse_partial_symbols): Set legacy_expand_psymtab.
8345         (psymtab_to_symtab_1): Change argument order.  Call
8346         expand_psymtab.
8347         (new_psymtab): Set legacy_expand_psymtab.
8348         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
8349         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
8350         expand_psymtab.
8351         (dwarf2_psymtab::expand_psymtab): Rename from
8352         psymtab_to_symtab_1.  Call expand_psymtab.
8353         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
8354         (dbx_end_psymtab): Likewise.
8355         (dbx_psymtab_to_symtab_1): Change argument order. Call
8356         expand_psymtab.
8357         (dbx_read_symtab): Call expand_psymtab.
8358         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
8359         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
8360         (ctf_psymtab::read_symtab): Call expand_psymtab.
8361
8362 2020-01-26  Tom Tromey  <tom@tromey.com>
8363
8364         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
8365         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
8366         messages.
8367         * mdebugread.c (mdebug_read_symtab): Remove prints.
8368         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
8369         assert.
8370         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
8371
8372 2020-01-26  Tom Tromey  <tom@tromey.com>
8373
8374         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
8375         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
8376         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
8377         legacy_symtab.
8378         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
8379         * psymtab.c (psymtab_to_symtab): Call method.
8380         (dump_psymtab): Update.
8381         * psympriv.h (struct partial_symtab): Add virtual destructor.
8382         <read_symtab>: New method.
8383         (struct legacy_symtab): New.
8384         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
8385         (struct pst_map) <pst>: Now a legacy_psymtab.
8386         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
8387         (new_psymtab): Use legacy_psymtab.
8388         * dwarf2read.h (struct dwarf2_psymtab): New.
8389         (struct dwarf2_per_cu_data) <psymtab>: Use it.
8390         * dwarf2read.c (dwarf2_create_include_psymtab)
8391         (dwarf2_build_include_psymtabs, create_type_unit_group)
8392         (create_partial_symtab, process_psymtab_comp_unit_reader)
8393         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
8394         (set_partial_user): Use dwarf2_psymtab.
8395         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
8396         (psymtab_to_symtab_1, process_full_comp_unit)
8397         (process_full_type_unit, dwarf2_ranges_read)
8398         (dwarf2_get_pc_bounds, psymtab_include_file_name)
8399         (dwarf_decode_lines): Use dwarf2_psymtab.
8400         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
8401         (add_address_entry_worker, write_one_signatured_type)
8402         (recursively_count_psymbols, recursively_write_psymbols)
8403         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
8404         (write_debug_names): Likewise.
8405         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
8406         <pst>: Now a legacy_psymtab.
8407         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
8408         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
8409         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
8410         * ctfread.c (struct ctf_psymtab): New.
8411         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
8412         ctf_psymtab.
8413         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
8414         (create_partial_symtab): Return a ctf_psymtab.
8415         (scan_partial_symbols): Update.
8416
8417 2020-01-26  Tom Tromey  <tom@tromey.com>
8418
8419         * xcoffread.c (xcoff_start_psymtab): Use new.
8420         * psymtab.c (partial_symtab::partial_symtab): New constructor,
8421         renamed from start_psymtab_common.
8422         * psympriv.h (struct partial_symtab): Add new constructor.
8423         (start_psymtab_common): Don't declare.
8424         * mdebugread.c (parse_partial_symbols): Use new.
8425         * dwarf2read.c (create_partial_symtab): Use new.
8426         * dbxread.c (start_psymtab): Use new.
8427         * ctfread.c (create_partial_symtab): Use new.
8428
8429 2020-01-26  Tom Tromey  <tom@tromey.com>
8430
8431         * xcoffread.c (xcoff_end_psymtab): Use new.
8432         * psymtab.c (start_psymtab_common): Use new.
8433         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
8434         Update.
8435         * psympriv.h (struct partial_symtab): Add parameters to
8436         constructor.  Don't inline.
8437         (allocate_psymtab): Don't declare.
8438         * mdebugread.c (new_psymtab): Use new.
8439         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
8440         * dbxread.c (dbx_end_psymtab): Use new.
8441
8442 2020-01-26  Tom Tromey  <tom@tromey.com>
8443
8444         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
8445         allocate_psymtab.  Update documentation.
8446         * psymtab.c (psymtab_storage::install_psymtab): Rename from
8447         allocate_psymtab.  Do not use new.
8448         (allocate_psymtab): Use new.  Update.
8449
8450 2020-01-26  Tom Tromey  <tom@tromey.com>
8451
8452         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
8453         * psymtab.c (psym_print_stats): Update.
8454         * psympriv.h (struct partial_symtab) <readin,
8455         psymtabs_addrmap_supported, anonymous>: Now bool.
8456         * mdebugread.c (psymtab_to_symtab_1): Update.
8457         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
8458         (build_type_psymtabs_reader, psymtab_to_symtab_1)
8459         (process_full_comp_unit, process_full_type_unit): Update.
8460         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
8461         * ctfread.c (psymtab_to_symtab): Update.
8462
8463 2020-01-26  Tom Tromey  <tom@tromey.com>
8464
8465         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
8466         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
8467         * psymtab.c (psymtab_storage): Delete psymtabs.
8468         (psymtab_storage::allocate_psymtab): Use new.
8469         (psymtab_storage::discard_psymtab): Use delete.
8470         * psympriv.h (struct partial_symtab): Add constructor and
8471         initializers.
8472
8473 2020-01-26  Tom Tromey  <tom@tromey.com>
8474
8475         * machoread.c: Do not include psympriv.h.
8476
8477 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8478
8479         * NEWS: Mention the new option and the set/show commands.
8480
8481 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8482
8483         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
8484         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
8485         (validate_exec_file): New variables, enums, functions.
8486         (exec_file_locate_attach, print_section_info): Style the filenames.
8487         (_initialize_exec): Install show_exec_file_mismatch_command and
8488          set_exec_file_mismatch_command.
8489         * gdbcore.h (validate_exec_file): Declare.
8490         * infcmd.c (attach_command): Call validate_exec_file.
8491         * remote.c ( remote_target::remote_add_inferior): Likewise.
8492
8493 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8494
8495         * frame.c (find_frame_sal): Move call to get_next_frame into more
8496         inner scope.
8497         * inline-frame.c (inilne_state) <inline_state>: Update argument
8498         types.
8499         (inilne_state) <skipped_symbol>: Rename to...
8500         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
8501         (skip_inline_frames): Build vector of skipped symbols and use this
8502         to reate the inline_state.
8503         (inline_skipped_symbol): Add a comment and some assertions, fetch
8504         skipped symbol from the list.
8505
8506 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8507
8508         * buildsym.c (lte_is_less_than): Delete.
8509         (buildsym_compunit::end_symtab_with_blockvector): Create local
8510         lambda function to sort line table entries, and use
8511         std::stable_sort instead of std::sort.
8512         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
8513         markers when looking for a previous line.
8514
8515 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8516
8517         * dwarf2read.c (lnp_state_machine::record_line): Include
8518         end_sequence parameter in debug print out.  Record the line if we
8519         are at an end_sequence marker even if it's not the start of a
8520         statement.
8521         * symmisc.c (maintenance_print_one_line_table): Print end of
8522         sequence markers with 'END' not '0'.
8523
8524 2020-01-24  Pedro Alves  <palves@redhat.com>
8525
8526         PR gdb/25410
8527         * thread.c (scoped_restore_current_thread::restore): Use
8528         switch_to_inferior_no_thread.
8529         * exec.c: Include "progspace-and-thread.h".
8530         (add_target_sections, remove_target_sections):
8531         scoped_restore_current_pspace_and_thread instead of
8532         scoped_restore_current_thread.
8533         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8534         and aspace to the inferior before calling clone_program_space.
8535         Remove stale comment.
8536
8537 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8538
8539         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8540         (arm_netbsd_nat_target::fetch_registers): ...this.
8541         (arm_nbsd_nat_target::store_registers): Rename to...
8542         (arm_netbsd_nat_target::store_registers): ...this.
8543
8544 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8545
8546         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8547         register_t.
8548
8549 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8550
8551         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8552         Update comment.
8553         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8554         Likewise.
8555         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8556         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8557         the correct replacement (iterate_over_regset_sections).
8558         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8559         Update comment.
8560
8561 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
8562
8563         PR gdb/23718
8564         * gdb/python/python.c (execute_gdb_command): Call
8565         async_enable_stdin in catch block.
8566
8567 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8568
8569         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
8570         SWITCH_THRU_ALL_UIS.
8571
8572 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8573
8574         PR tui/9765
8575         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
8576         comment, add extra parameter, and update to store previous symbol
8577         when appropriate.
8578         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
8579         add extra parameter.
8580         * tui/tui-disasm.c (tui_disassemble): Update header comment,
8581         remove unneeded parameter, add try/catch around gdb_print_insn,
8582         rewrite to add items to asm_lines vector.
8583         (tui_find_backward_disassembly_start_address): New function.
8584         (tui_find_disassembly_address): Updated throughout.
8585         (tui_disasm_window::set_contents): Update for changes to
8586         tui_disassemble.
8587         (tui_disasm_window::do_scroll_vertical): No need to adjust the
8588         number of lines to scroll.
8589
8590 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
8591
8592         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
8593         (SECT_OFF_DATA): Likewise.
8594         (SECT_OFF_RODATA): Likewise.
8595         (SECT_OFF_TEXT): Likewise.
8596         (SECT_OFF_BSS): Likewise.
8597         (struct objfile) <text_section_offset, data_section_offset>: New
8598         methods.
8599         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
8600         objfile::text_section_offset.
8601         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
8602         * coffread.c (coff_symtab_read): Likewise.
8603         (enter_linenos): Likewise.
8604         (process_coff_symbol): Likewise.
8605         * ctfread.c (get_objfile_text_range): Likewise.
8606         * dtrace-probe.c (dtrace_probe::get_relocated_address):
8607         Use objfile::data_section_offset.
8608         * dwarf2-frame.c (execute_cfa_program): Use
8609         objfile::text_section_offset.
8610         (dwarf2_frame_find_fde): Likewise.
8611         * dwarf2read.c (create_addrmap_from_index): Likewise.
8612         (create_addrmap_from_aranges): Likewise.
8613         (dw2_find_pc_sect_compunit_symtab): Likewise.
8614         (process_psymtab_comp_unit_reader): Likewise.
8615         (add_partial_symbol): Likewise.
8616         (add_partial_subprogram): Likewise.
8617         (process_full_comp_unit): Likewise.
8618         (read_file_scope): Likewise.
8619         (read_func_scope): Likewise.
8620         (read_lexical_block_scope): Likewise.
8621         (read_call_site_scope): Likewise.
8622         (dwarf2_rnglists_process): Likewise.
8623         (dwarf2_ranges_process): Likewise.
8624         (dwarf2_ranges_read): Likewise.
8625         (dwarf_decode_lines_1): Likewise.
8626         (new_symbol): Likewise.
8627         (dwarf2_fetch_die_loc_sect_off): Likewise.
8628         (dwarf2_per_cu_text_offset): Likewise.
8629         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
8630         * hppa-tdep.c (read_unwind_info): Likewise.
8631         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
8632         * psympriv.h (struct partial_symtab): Likewise.
8633         * psymtab.c (find_pc_sect_psymtab): Likewise.
8634         * solib-svr4.c (enable_break): Likewise.
8635         * stap-probe.c (relocate_address): Use
8636         objfile::data_section_offset.
8637         * xcoffread.c (enter_line_range): Use
8638         objfile::text_section_offset.
8639         (read_xcoff_symtab): Likewise.
8640
8641 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8642
8643         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
8644         declaration to narrower scopes.
8645
8646 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
8647
8648         * darwin-nat.h (struct darwin_exception_msg, enum
8649         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
8650         Move up.
8651         (class darwin_nat_target) <wait_1, check_new_threads,
8652         decode_exception_message, decode_message, stop_inferior,
8653         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
8654         * darwin-nat.c (darwin_check_new_threads): Rename to...
8655         (darwin_nat_target::check_new_threads): ... this.
8656         (darwin_suspend_inferior_it): Remove.
8657         (darwin_decode_exception_message): Rename to...
8658         (darwin_nat_target::decode_exception_message): ... this.
8659         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
8660         (darwin_decode_message): Rename to...
8661         (darwin_nat_target::decode_message): ... this.
8662         (cancel_breakpoint): Rename to...
8663         (darwin_nat_target::cancel_breakpoint): ... this.
8664         (darwin_wait): Rename to...
8665         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
8666         instead of iterate_over_inferiors.
8667         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
8668         (darwin_stop_inferior): Rename to...
8669         (darwin_nat_target::stop_inferior): ... this.
8670         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
8671         (darwin_init_thread_list): Rename to...
8672         (darwin_nat_target::init_thread_list): ... this.
8673         (darwin_ptrace_him): Rename to...
8674         (darwin_nat_target::ptrace_him): ... this.
8675         (darwin_nat_target::create_inferior): Pass lambda function to
8676         fork_inferior.
8677         (darwin_nat_target::detach): Call stop_inferior instead of
8678         darwin_stop_inferior.
8679         * fork-inferior.h (fork_inferior): Change init_trace_fun
8680         parameter to gdb::function_view.
8681         * fork-inferior.c (fork_inferior): Likewise.
8682
8683 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
8684
8685         * i386-cygwin-tdep.c (core_process_module_section): Update.
8686         * windows-nat.c (struct lm_info_windows): Add text_offset.
8687         (windows_xfer_shared_libraries): Update.
8688         * windows-tdep.c (windows_xfer_shared_library):
8689         Add text_offset_cached argument.
8690         * windows-tdep.h (windows_xfer_shared_library): Update.
8691
8692 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8693
8694         * gdbarch.sh: Add declaration for _initialize_gdbarch.
8695
8696 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8697
8698         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
8699         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
8700         replace with range-based for.
8701         (gdbsim_interrupt_inferior): Remove.
8702         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
8703         with a range-based for.  Inline code from
8704         gdbsim_interrupt_inferior.
8705
8706 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
8707
8708         * infrun.c (proceed): Fix indentation.
8709
8710 2020-01-21  Tom Tromey  <tromey@adacore.com>
8711
8712         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
8713         * python/python.c (python_extension_ops): Update.
8714         (gdbpy_colorize): New function.
8715         * python/lib/gdb/__init__.py (colorize): New function.
8716         * extension.h (ext_lang_colorize): Declare.
8717         * extension.c (ext_lang_colorize): New function.
8718         * extension-priv.h (struct extension_language_ops) <colorize>: New
8719         member.
8720         * cli/cli-style.c (_initialize_cli_style): Update help text.
8721
8722 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8723
8724         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
8725         <cond>: Change type to bool.
8726         (aarch64_displaced_step_b_cond): Update cond to use bool type.
8727         (aarch64_displaced_step_cb): Likewise.
8728         (aarch64_displaced_step_tb): Likewise.
8729
8730 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8731
8732         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
8733         output.
8734
8735 2020-01-21  Luis Machado  <luis.machado@linaro.org>
8736
8737         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
8738         <pc_adjust>: Adjust the documentation.
8739         (aarch64_displaced_step_fixup): Check if PC really moved before
8740         adjusting it.
8741
8742 2020-01-19  Tom Tromey  <tom@tromey.com>
8743
8744         * disasm.c (~gdb_disassembler): New destructor.
8745         (gdb_buffered_insn_length): Call disassemble_free_target.
8746         * disasm.h (class gdb_disassembler): Declare destructor.  Use
8747         DISABLE_COPY_AND_ASSIGN.
8748
8749 2020-01-19  Tom Tromey  <tom@tromey.com>
8750
8751         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
8752         (die_reader_func_ftype): Remove.
8753         (cutu_reader): New class.
8754         (dw2_get_file_names_reader): Remove "data" parameter.
8755         (dw2_get_file_names): Use cutu_reader.
8756         (create_debug_type_hash_table): Update.
8757         (read_cutu_die_from_dwo): Update comment.
8758         (lookup_dwo_unit): Add dwo_name parameter.
8759         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
8760         die_reader_func_ftype and data parameters.
8761         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
8762         Remove die_reader_func_ftype and data parameters.
8763         (~cutu_reader): New; from init_cutu_and_read_dies.
8764         (cutu_reader::cutu_reader): Rename from
8765         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
8766         and data parameters.
8767         (init_cutu_and_read_dies_simple): Remove.
8768         (struct process_psymtab_comp_unit_data): Remove.
8769         (process_psymtab_comp_unit_reader): Remove data parameter; add
8770         want_partial_unit and pretend_language parameters.
8771         (process_psymtab_comp_unit): Use cutu_reader.
8772         (build_type_psymtabs_reader): Remove data parameter.
8773         (build_type_psymtabs_1): Use cutu_reader.
8774         (process_skeletonless_type_unit): Likewise.
8775         (load_partial_comp_unit_reader): Remove.
8776         (load_partial_comp_unit): Use cutu_reader.
8777         (load_full_comp_unit_reader): Remove.
8778         (load_full_comp_unit): Use cutu_reader.
8779         (struct create_dwo_cu_data): Remove.
8780         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
8781         dwo_unit parameters.
8782         (create_cus_hash_table): Use cutu_reader.
8783         (struct dwarf2_read_addr_index_data): Remove.
8784         (dwarf2_read_addr_index_reader): Remove.
8785         (dwarf2_read_addr_index): Use cutu_reader.
8786         (read_signatured_type_reader): Remove.
8787         (read_signatured_type): Use cutu_reader.
8788
8789 2020-01-19  Tom Tromey  <tom@tromey.com>
8790
8791         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
8792         * tui/tui-wingeneral.h (class tui_suppress_output): New.
8793         (tui_wrefresh): Declare.
8794         * tui/tui-wingeneral.c (suppress_output): New global.
8795         (tui_suppress_output, ~tui_suppress_output): New constructor and
8796         destructor.
8797         (tui_wrefresh): New function.
8798         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
8799         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
8800         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
8801         method.
8802         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
8803         tui_wrefresh.
8804         (tui_data_window::no_refresh): New method.
8805         (tui_data_item_window::refresh_window): Call tui_wrefresh.
8806         (tui_reg_command): Use tui_suppress_output
8807         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
8808         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
8809         method.
8810         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
8811
8812 2020-01-19  Tom Tromey  <tom@tromey.com>
8813
8814         * tui/tui-winsource.c (tui_update_source_windows_with_line):
8815         Handle case where symtab is null.
8816
8817 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
8818
8819         * linux-fork.c (one_fork_p): Simplify.
8820
8821 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8822
8823         * top.c (struct qt_args): Remove.
8824         (kill_or_detach): Change return type to void, replace `void *`
8825         parameter with a proper one.
8826         (print_inferior_quit_action):  Likewise.
8827         (quit_confirm): Use range-based for loop to iterate over inferiors.
8828         (quit_force): Likewise.
8829
8830 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8831
8832         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
8833         `void *` parameter with proper parameters.
8834         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
8835         (print_one_inferior): Change return type to void, replace `void *`
8836         parameter with proper parameters.
8837         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
8838         inferiors.
8839         (get_other_inferior): Remove.
8840         (mi_cmd_remove_inferior): Use range-based loop to iterate over
8841         inferiors.
8842
8843 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8844
8845         * mi/mi-interp.c (report_initial_inferior): Remove.
8846         (mi_interp::init): Use range-based for to iterate over inferiors.
8847
8848 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
8849
8850         * python/py-inferior.c (build_inferior_list): Remove.
8851         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
8852
8853 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
8854
8855         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
8856         (btrace_stitch_trace): Likewise.
8857         * charset.c (intermediate_encoding): Likewise (vaild).
8858         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
8859         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
8860         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
8861
8862 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
8863
8864         * windows-tdep.c (windows_get_tlb_type):
8865         Add rtl_user_process_parameters type.
8866
8867 2020-01-16  Pedro Alves  <palves@redhat.com>
8868             Norbert Lange  <nolange79@gmail.com>
8869
8870         PR build/24805
8871         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
8872         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
8873         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
8874         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
8875         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
8876         (ps_plog): Redeclare exported functions with default visibility.
8877
8878 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
8879
8880         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
8881         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
8882
8883 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
8884
8885         * infcmd.c (post_create_inferior): Use get_thread_regcache
8886         instead of get_current_regcache.
8887
8888 2020-01-14  Tom Tromey  <tom@tromey.com>
8889
8890         PR symtab/12535:
8891         * python/python.c (gdbpy_decode_line): Treat empty string the same
8892         as no argument.
8893
8894 2020-01-14  Tom Tromey  <tom@tromey.com>
8895
8896         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
8897
8898 2020-01-14  Tom Tromey  <tom@tromey.com>
8899
8900         * nat/linux-btrace.c: Don't include <config.h>.
8901         * nat/linux-ptrace.c: Don't include <config.h>.
8902         * nat/x86-linux-dregs.c: Don't include <config.h>.
8903
8904 2020-01-14  Tom Tromey  <tom@tromey.com>
8905
8906         * configure: Rebuild.
8907         * configure.ac: Move many checks to ../gdbsupport/common.m4.
8908
8909 2020-01-14  Tom Tromey  <tom@tromey.com>
8910
8911         * nat/x86-linux-dregs.c: Include configh.h.
8912         * nat/linux-ptrace.c: Include configh.h.
8913         * nat/linux-btrace.c: Include configh.h.
8914         * defs.h: Include config.h, bfd.h.
8915         * configure.ac: Don't source common.host.
8916         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
8917         * configure: Rebuild.
8918         * acinclude.m4: Update path.
8919         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
8920         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
8921         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
8922         (CLIBS): Add LIBSUPPORT.
8923         (CDEPS): Likewise.
8924         (COMMON_SFILES): Remove gdbsupport files.
8925         (HFILES_NO_SRCDIR): Likewise.
8926         (stamp-version): Update path to create-version.sh.
8927         (ALLDEPFILES): Remove gdbsupport files.
8928
8929 2020-01-14  Tom Tromey  <tom@tromey.com>
8930
8931         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
8932         USE_WIN32API when needed.
8933         * configure.ac (USE_WIN32API): Don't define.
8934         (WIN32LIBS): Use WIN32APILIBS.
8935         * configure: Rebuild.
8936
8937 2020-01-14  Tom Tromey  <tom@tromey.com>
8938
8939         * configure: Rebuild.
8940         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
8941
8942 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
8943
8944         * skip.c (skip_function_command): Make skip w/o arguments use the
8945         name of the inlined function if pc is inside any inlined function.
8946
8947 2020-01-14  Luis Machado  <luis.machado@linaro.org>
8948
8949         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
8950         * infrun.c (resume_1): Likewise.
8951         (handle_inferior_event): Remove stale comment.
8952         * linux-nat.c (linux_nat_target::resume): Update comments.
8953         (save_stop_reason): Likewise.
8954         (linux_nat_filter_event): Likewise.
8955         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
8956
8957 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8958
8959         * elfread.c (record_minimal_symbol): Set section index to 0 for
8960         non-allocatable sections.
8961
8962
8963 2020-01-13  Ali Tamur <tamur@google.com>
8964
8965         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
8966         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
8967         to gdb::optional.  Update comments.
8968         (dwo_file): Update comments.
8969         (read_attribute): Update API to take an additional out parameter,
8970         need_reprocess.  This is used to mark attributes that need other
8971         attributes (e.g. str_offsets_base) for correct computation which may not
8972         have been read yet.
8973         (read_attribute_reprocess): New function declaration.
8974         (read_addr_index): Likewise.
8975         (read_dwo_str_index): Likewise.
8976         (read_stub_str_index): Likewise.
8977         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
8978         (lookup_addr_base): New function definition.
8979         (lookup_ranges_base): Likewise.
8980         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
8981         lookup_ranges_base.
8982         (init_cutu_and_read_dies): Update comments.
8983         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
8984         unit.  This is used to inherit parent's str_offsets_base and addr_base.
8985         Update comments.
8986         (init_cutu_and_read_dies_simple): Reflect API changes.
8987         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
8988         (create_cus_hash_table): Change API to take parent compile unit.
8989         Reflect API changes.
8990         (open_and_init_dwo_file): Reflect API changes.
8991         (dwarf2_get_pc_bounds): Update comments.
8992         (dwarf2_record_block_ranges): Likewise.
8993         (read_full_die_1): Change implementation to reprocess attributes that
8994         need str_offsets_base and addr_base.
8995         (partial_die_info::read): Likewise.
8996         (read_attribute_reprocess): New function definition.
8997         (read_attribute_value): Change API to take an additional out parameter,
8998         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
8999         when a non-dwo compile unit has index based attributes.
9000         (read_attribute): Reflect API changes.
9001         (read_addr_index_1): Reflect API changes.  Update comments.
9002         (dwarf2_read_addr_index_data): Reflect API changes.
9003         (dwarf2_read_addr_index): Likewise.
9004         (read_str_index): Change API and implementation.  This becomes a helper
9005         to be used by the new string index related methods.  Update error
9006         message and comments.
9007         (read_dwo_str_index): New function definition.
9008         (read_stub_str_index): Likewise.
9009         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
9010         * symfile.h (dwarf2_debug_sections): Likewise.
9011         * xcoffread.c (dwarf2_debug_sections): Likewise.
9012
9013 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9014
9015         * gdbcore.h (struct core_fns) <core_read_registers>: Change
9016         core_reg_sect type to gdb_byte *.
9017         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
9018         * cris-tdep.c (fetch_core_registers): Likewise.
9019         * corelow.c (core_target::get_core_register_section): Change
9020         type of `contents` to gdb::byte_vector.
9021
9022 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9023
9024         * tui/tui-wingeneral.c (box_win): Position the title in the center
9025         of the border.
9026
9027 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9028
9029         * corelow.c (core_target::get_core_register_section): Use
9030           std::vector instead of alloca.
9031
9032 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9033
9034         * warning.m4: Add -Wmissing-declarations to build_warnings.
9035         * configure: Re-generate.
9036
9037 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9038
9039         * python/python.c (init__gdb_module): Add declaration.
9040
9041 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9042
9043         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
9044         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
9045         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
9046         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
9047         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
9048         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
9049         * ada-exp.y (_initialize_ada_exp): Add declaration.
9050         * ada-lang.c (_initialize_ada_language): Add declaration.
9051         * ada-tasks.c (_initialize_tasks): Add declaration.
9052         * agent.c (_initialize_agent): Add declaration.
9053         * aix-thread.c (_initialize_aix_thread): Add declaration.
9054         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
9055         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
9056         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
9057         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
9058         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
9059         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
9060         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
9061         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
9062         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
9063         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
9064         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
9065         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
9066         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
9067         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
9068         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
9069         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
9070         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
9071         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
9072         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
9073         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
9074         * annotate.c (_initialize_annotate): Add declaration.
9075         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
9076         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
9077         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
9078         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
9079         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
9080         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
9081         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
9082         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
9083         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
9084         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
9085         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
9086         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
9087         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
9088         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
9089         * auto-load.c (_initialize_auto_load): Add declaration.
9090         * auxv.c (_initialize_auxv): Add declaration.
9091         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
9092         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
9093         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
9094         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
9095         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
9096         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
9097         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
9098         * breakpoint.c (_initialize_breakpoint): Add declaration.
9099         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
9100         * btrace.c (_initialize_btrace): Add declaration.
9101         * charset.c (_initialize_charset): Add declaration.
9102         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
9103         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
9104         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
9105         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
9106         * cli/cli-script.c (_initialize_cli_script): Add declaration.
9107         * cli/cli-style.c (_initialize_cli_style): Add declaration.
9108         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
9109         * coffread.c (_initialize_coffread): Add declaration.
9110         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
9111         * compile/compile.c (_initialize_compile): Add declaration.
9112         * complaints.c (_initialize_complaints): Add declaration.
9113         * completer.c (_initialize_completer): Add declaration.
9114         * copying.c (_initialize_copying): Add declaration.
9115         * corefile.c (_initialize_core): Add declaration.
9116         * corelow.c (_initialize_corelow): Add declaration.
9117         * cp-abi.c (_initialize_cp_abi): Add declaration.
9118         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
9119         * cp-support.c (_initialize_cp_support): Add declaration.
9120         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
9121         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
9122         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
9123         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
9124         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
9125         * ctfread.c (_initialize_ctfread): Add declaration.
9126         * d-lang.c (_initialize_d_language): Add declaration.
9127         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
9128         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
9129         * dbxread.c (_initialize_dbxread): Add declaration.
9130         * dcache.c (_initialize_dcache): Add declaration.
9131         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
9132         * disasm.c (_initialize_disasm): Add declaration.
9133         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
9134         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
9135         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
9136         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
9137         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
9138         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
9139         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
9140         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
9141         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
9142         * elfread.c (_initialize_elfread): Add declaration.
9143         * exec.c (_initialize_exec): Add declaration.
9144         * extension.c (_initialize_extension): Add declaration.
9145         * f-lang.c (_initialize_f_language): Add declaration.
9146         * f-valprint.c (_initialize_f_valprint): Add declaration.
9147         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
9148         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
9149         * filesystem.c (_initialize_filesystem): Add declaration.
9150         * findcmd.c (_initialize_mem_search): Add declaration.
9151         * findvar.c (_initialize_findvar): Add declaration.
9152         * fork-child.c (_initialize_fork_child): Add declaration.
9153         * frame-base.c (_initialize_frame_base): Add declaration.
9154         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
9155         * frame.c (_initialize_frame): Add declaration.
9156         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
9157         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
9158         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
9159         * gcore.c (_initialize_gcore): Add declaration.
9160         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
9161         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
9162         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
9163         * gdbarch.c (_initialize_gdbarch): Add declaration.
9164         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
9165         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
9166         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
9167         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
9168         * go-lang.c (_initialize_go_language): Add declaration.
9169         * go32-nat.c (_initialize_go32_nat): Add declaration.
9170         * guile/guile.c (_initialize_guile): Add declaration.
9171         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
9172         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
9173         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
9174         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
9175         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
9176         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
9177         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
9178         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
9179         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
9180         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
9181         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
9182         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
9183         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
9184         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
9185         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
9186         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
9187         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
9188         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
9189         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
9190         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
9191         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
9192         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
9193         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
9194         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
9195         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
9196         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
9197         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
9198         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
9199         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
9200         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
9201         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
9202         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
9203         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
9204         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
9205         * infcall.c (_initialize_infcall): Add declaration.
9206         * infcmd.c (_initialize_infcmd): Add declaration.
9207         * inflow.c (_initialize_inflow): Add declaration.
9208         * infrun.c (_initialize_infrun): Add declaration.
9209         * interps.c (_initialize_interpreter): Add declaration.
9210         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
9211         * jit.c (_initialize_jit): Add declaration.
9212         * language.c (_initialize_language): Add declaration.
9213         * linux-fork.c (_initialize_linux_fork): Add declaration.
9214         * linux-nat.c (_initialize_linux_nat): Add declaration.
9215         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
9216         * linux-thread-db.c (_initialize_thread_db): Add declaration.
9217         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
9218         * m2-lang.c (_initialize_m2_language): Add declaration.
9219         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
9220         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
9221         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
9222         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
9223         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
9224         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
9225         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
9226         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
9227         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
9228         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
9229         * machoread.c (_initialize_machoread): Add declaration.
9230         * macrocmd.c (_initialize_macrocmd): Add declaration.
9231         * macroscope.c (_initialize_macroscope): Add declaration.
9232         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
9233         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
9234         * maint.c (_initialize_maint_cmds): Add declaration.
9235         * mdebugread.c (_initialize_mdebugread): Add declaration.
9236         * memattr.c (_initialize_mem): Add declaration.
9237         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
9238         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
9239         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
9240         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
9241         * mi/mi-main.c (_initialize_mi_main): Add declaration.
9242         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
9243         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
9244         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
9245         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
9246         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
9247         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
9248         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
9249         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
9250         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
9251         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
9252         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
9253         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
9254         * mipsread.c (_initialize_mipsread): Add declaration.
9255         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
9256         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
9257         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
9258         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
9259         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
9260         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
9261         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
9262         * nto-procfs.c (_initialize_procfs): Add declaration.
9263         * objc-lang.c (_initialize_objc_language): Add declaration.
9264         * observable.c (_initialize_observer): Add declaration.
9265         * opencl-lang.c (_initialize_opencl_language): Add declaration.
9266         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
9267         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
9268         * osabi.c (_initialize_gdb_osabi): Add declaration.
9269         * osdata.c (_initialize_osdata): Add declaration.
9270         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
9271         * parse.c (_initialize_parse): Add declaration.
9272         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
9273         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
9274         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
9275         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
9276         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
9277         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
9278         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
9279         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
9280         * printcmd.c (_initialize_printcmd): Add declaration.
9281         * probe.c (_initialize_probe): Add declaration.
9282         * proc-api.c (_initialize_proc_api): Add declaration.
9283         * proc-events.c (_initialize_proc_events): Add declaration.
9284         * proc-service.c (_initialize_proc_service): Add declaration.
9285         * procfs.c (_initialize_procfs): Add declaration.
9286         * producer.c (_initialize_producer): Add declaration.
9287         * psymtab.c (_initialize_psymtab): Add declaration.
9288         * python/python.c (_initialize_python): Add declaration.
9289         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
9290         * record-btrace.c (_initialize_record_btrace): Add declaration.
9291         * record-full.c (_initialize_record_full): Add declaration.
9292         * record.c (_initialize_record): Add declaration.
9293         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
9294         * regcache.c (_initialize_regcache): Add declaration.
9295         * reggroups.c (_initialize_reggroup): Add declaration.
9296         * remote-notif.c (_initialize_notif): Add declaration.
9297         * remote-sim.c (_initialize_remote_sim): Add declaration.
9298         * remote.c (_initialize_remote): Add declaration.
9299         * reverse.c (_initialize_reverse): Add declaration.
9300         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
9301         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
9302         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
9303         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
9304         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
9305         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
9306         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
9307         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
9308         Add declaration.
9309         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
9310         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
9311         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
9312         * rust-exp.y (_initialize_rust_exp): Add declaration.
9313         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
9314         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
9315         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
9316         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
9317         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
9318         * score-tdep.c (_initialize_score_tdep): Add declaration.
9319         * ser-go32.c (_initialize_ser_dos): Add declaration.
9320         * ser-mingw.c (_initialize_ser_windows): Add declaration.
9321         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
9322         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
9323         * ser-uds.c (_initialize_ser_socket): Add declaration.
9324         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
9325         * serial.c (_initialize_serial): Add declaration.
9326         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
9327         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
9328         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
9329         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
9330         * skip.c (_initialize_step_skip): Add declaration.
9331         * sol-thread.c (_initialize_sol_thread): Add declaration.
9332         * solib-aix.c (_initialize_solib_aix): Add declaration.
9333         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
9334         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
9335         * solib-frv.c (_initialize_frv_solib): Add declaration.
9336         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
9337         * solib-target.c (_initialize_solib_target): Add declaration.
9338         * solib.c (_initialize_solib): Add declaration.
9339         * source-cache.c (_initialize_source_cache): Add declaration.
9340         * source.c (_initialize_source): Add declaration.
9341         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
9342         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
9343         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
9344         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
9345         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
9346         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
9347         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
9348         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
9349         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
9350         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
9351         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
9352         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
9353         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
9354         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
9355         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
9356         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
9357         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
9358         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
9359         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
9360         * stabsread.c (_initialize_stabsread): Add declaration.
9361         * stack.c (_initialize_stack): Add declaration.
9362         * stap-probe.c (_initialize_stap_probe): Add declaration.
9363         * std-regs.c (_initialize_frame_reg): Add declaration.
9364         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
9365         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
9366         * symfile.c (_initialize_symfile): Add declaration.
9367         * symmisc.c (_initialize_symmisc): Add declaration.
9368         * symtab.c (_initialize_symtab): Add declaration.
9369         * target.c (_initialize_target): Add declaration.
9370         * target-connection.c (_initialize_target_connection): Add
9371         declaration.
9372         * target-dcache.c (_initialize_target_dcache): Add declaration.
9373         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
9374         * thread.c (_initialize_thread): Add declaration.
9375         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
9376         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
9377         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
9378         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
9379         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
9380         * tracectf.c (_initialize_ctf): Add declaration.
9381         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
9382         * tracefile.c (_initialize_tracefile): Add declaration.
9383         * tracepoint.c (_initialize_tracepoint): Add declaration.
9384         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
9385         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
9386         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
9387         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
9388         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
9389         * tui/tui-win.c (_initialize_tui_win): Add declaration.
9390         * tui/tui.c (_initialize_tui): Add declaration.
9391         * typeprint.c (_initialize_typeprint): Add declaration.
9392         * ui-style.c (_initialize_ui_style): Add declaration.
9393         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
9394         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
9395         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
9396         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
9397         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
9398         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
9399         * unittests/filtered_iterator-selftests.c
9400         (_initialize_filtered_iterator_selftests): Add declaration.
9401         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
9402         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
9403         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
9404         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
9405         * unittests/main-thread-selftests.c
9406         (_initialize_main_thread_selftests): Add declaration.
9407         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
9408         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
9409         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
9410         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
9411         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
9412         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
9413         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
9414         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
9415         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
9416         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
9417         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
9418         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
9419         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
9420         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
9421         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
9422         declaration.
9423         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
9424         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
9425         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
9426         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
9427         * user-regs.c (_initialize_user_regs): Add declaration.
9428         * utils.c (_initialize_utils): Add declaration.
9429         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
9430         * valops.c (_initialize_valops): Add declaration.
9431         * valprint.c (_initialize_valprint): Add declaration.
9432         * value.c (_initialize_values): Add declaration.
9433         * varobj.c (_initialize_varobj): Add declaration.
9434         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
9435         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
9436         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
9437         * windows-nat.c (_initialize_windows_nat): Add declaration.
9438         (_initialize_check_for_gdb_ini): Add declaration.
9439         (_initialize_loadable): Add declaration.
9440         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
9441         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
9442         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
9443         * xcoffread.c (_initialize_xcoffread): Add declaration.
9444         * xml-support.c (_initialize_xml_support): Add declaration.
9445         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
9446         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
9447         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
9448         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
9449
9450 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9451
9452         * regformats/regdat.sh: Generate declaration for init function.
9453
9454 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9455
9456         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
9457         up.
9458         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
9459         close_one_inferior>: New methods.
9460         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
9461         pass down target to find_inferior_pid.
9462         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
9463         Pass down target to find_inferior_ptid.
9464         (gdbsim_target::create_inferior): Pass down target to
9465         add_thread_silent.
9466         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
9467         target down to find_inferior_ptid and switch_to_thread.
9468         (gdbsim_target::close): Update to call close_one_inferior.
9469         (struct resume_data): Remove.
9470         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
9471         directly, rather than through a void pointer.
9472         (gdbsim_target::resume): Update to call resume_one_inferior.
9473
9474 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
9475
9476         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
9477
9478 2020-01-12  Pedro Alves  <palves@redhat.com>
9479
9480         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
9481         directly for the current inferior instead of
9482         discard_all_inferiors.
9483         (discard_all_inferiors): Delete.
9484
9485 2020-01-11  Tom Tromey  <tom@tromey.com>
9486
9487         * tui/tui-wingeneral.c (box_win): Check cli_styling.
9488         * tui/tui-winsource.c (tui_source_window_base::refill): Use
9489         deprecated_safe_get_selected_frame.
9490
9491 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9492
9493         * inferior.c (print_inferior): Switch inferior before printing it.
9494
9495 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
9496             Pedro Alves  <palves@redhat.com>
9497
9498         * progspace-and-thread.c (switch_to_program_space_and_thread):
9499         Assert there's an inferior for PSPACE.  Use
9500         switch_to_inferior_no_thread to switch the inferior too.
9501         * progspace.c (program_space::~program_space): Call
9502         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
9503         (program_space::free_all_objfiles): Don't call clear_symtab_users
9504         here.
9505         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
9506
9507 2020-01-10  Pedro Alves  <palves@redhat.com>
9508
9509         * NEWS: Mention multi-target debugging, "info connections", and
9510         "add-inferior -no-connection".
9511
9512 2020-01-10  Pedro Alves  <palves@redhat.com>
9513
9514         * infrun.c: Include "target-connection.h".
9515         (check_multi_target_resumption): New.
9516         (proceed): Call it.
9517         * target-connection.c (make_target_connection_string): Make
9518         extern.
9519         * target-connection.h (make_target_connection_string): Declare.
9520
9521 2020-01-10  Pedro Alves  <palves@redhat.com>
9522
9523         * Makefile.in (COMMON_SFILES): Add target-connection.c.
9524         * inferior.c (uiout_field_connection): New function.
9525         (print_inferior): Add new "connection-id" column.
9526         (add_inferior_command): Show connection number/string of added
9527         inferior.
9528         * process-stratum-target.h
9529         (process_stratum_target::connection_string): New virtual method.
9530         (process_stratum_target::connection_number): New field.
9531         * remote.c (remote_target::connection_string): New override.
9532         * target-connection.c: New file.
9533         * target-connection.h: New file.
9534         * target.c (decref_target): Remove process_stratum targets from
9535         the connection list.
9536         (target_stack::push): Add process_stratum targets to the
9537         connection list.
9538
9539 2020-01-10  Pedro Alves  <palves@redhat.com>
9540
9541         Revert:
9542         2016-04-12  Pedro Alves  <palves@redhat.com>
9543         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9544         Remove references to name.
9545         * serial.h (struct serial) <name>: Delete.
9546
9547 2020-01-10  Pedro Alves  <palves@redhat.com>
9548
9549         * gdbarch-selftests.c (register_to_value_test): Remove "target
9550         already pushed" check.
9551
9552 2020-01-10  Pedro Alves  <palves@redhat.com>
9553             John Baldwin  <jhb@FreeBSD.org>
9554
9555         * aarch64-linux-nat.c
9556         (aarch64_linux_nat_target::thread_architecture): Adjust.
9557         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9558         (task_command_1): Likewise.
9559         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9560         (aix_thread_target::wait, aix_thread_target::fetch_registers)
9561         (aix_thread_target::store_registers)
9562         (aix_thread_target::thread_alive): Adjust.
9563         * amd64-fbsd-tdep.c: Include "inferior.h".
9564         (amd64fbsd_get_thread_local_address): Pass down target.
9565         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
9566         thread's gdbarch instead of target_gdbarch.
9567         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
9568         get_last_target_status.
9569         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
9570         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
9571         inferiors.
9572         (update_inserted_breakpoint_locations): Skip if inferiors with no
9573         execution.
9574         (update_global_location_list): When handling moribund locations,
9575         find representative inferior for location's pspace, and use thread
9576         count of its process_stratum target.
9577         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
9578         * bsd-uthread.c (bsd_uthread_target::wait): Use
9579         as_process_stratum_target and adjust thread_change_ptid and
9580         add_thread calls.
9581         (bsd_uthread_target::update_thread_list): Use
9582         as_process_stratum_target and adjust find_thread_ptid,
9583         thread_change_ptid and add_thread calls.
9584         * btrace.c (maint_btrace_packet_history_cmd): Adjust
9585         find_thread_ptid call.
9586         * corelow.c (add_to_thread_list): Adjust add_thread call.
9587         (core_target_open): Adjust add_thread_silent and thread_count
9588         calls.
9589         (core_target::pid_to_str): Adjust find_inferior_ptid call.
9590         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
9591         * event-top.c (async_disconnect): Pop targets from all inferiors.
9592         * exec.c (add_target_sections): Push exec target on all inferiors
9593         sharing the program space.
9594         (remove_target_sections): Remove the exec target from all
9595         inferiors sharing the program space.
9596         (exec_on_vfork): New.
9597         * exec.h (exec_on_vfork): Declare.
9598         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
9599         Pass it down.
9600         (fbsd_nat_target::update_thread_list): Adjust.
9601         (fbsd_nat_target::resume): Adjust.
9602         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
9603         down.
9604         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
9605         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
9606         get_thread_arch_regcache call.
9607         * fork-child.c (gdb_startup_inferior): Pass target down to
9608         startup_inferior and set_executing.
9609         * gdbthread.h (struct process_stratum_target): Forward declare.
9610         (add_thread, add_thread_silent, add_thread_with_info)
9611         (in_thread_list): Add process_stratum_target parameter.
9612         (find_thread_ptid(inferior*, ptid_t)): New overload.
9613         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
9614         parameter.
9615         (all_threads()): Delete overload.
9616         (all_threads, all_non_exited_threads): Add process_stratum_target
9617         parameter.
9618         (all_threads_safe): Use brace initialization.
9619         (thread_count): Add process_stratum_target parameter.
9620         (set_resumed, set_running, set_stop_requested, set_executing)
9621         (threads_are_executing, finish_thread_state): Add
9622         process_stratum_target parameter.
9623         (switch_to_thread): Use is_current_thread.
9624         * i386-fbsd-tdep.c: Include "inferior.h".
9625         (i386fbsd_get_thread_local_address): Pass down target.
9626         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
9627         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
9628         have_inferiors check.
9629         * inf-ptrace.c (inf_ptrace_target::create_inferior)
9630         (inf_ptrace_target::attach): Adjust.
9631         * infcall.c (run_inferior_call): Adjust.
9632         * infcmd.c (run_command_1): Pass target to
9633         scoped_finish_thread_state.
9634         (proceed_thread_callback): Skip inferiors with no execution.
9635         (continue_command): Rename 'all_threads' local to avoid hiding
9636         'all_threads' function.  Adjust get_last_target_status call.
9637         (prepare_one_step): Adjust set_running call.
9638         (signal_command): Use user_visible_resume_target.  Compare thread
9639         pointers instead of inferior_ptid.
9640         (info_program_command): Adjust to pass down target.
9641         (attach_command): Mark target's 'thread_executing' flag.
9642         (stop_current_target_threads_ns): New, factored out from ...
9643         (interrupt_target_1): ... this.  Switch inferior before making
9644         target calls.
9645         * inferior-iter.h
9646         (struct all_inferiors_iterator, struct all_inferiors_range)
9647         (struct all_inferiors_safe_range)
9648         (struct all_non_exited_inferiors_range): Filter on
9649         process_stratum_target too.  Remove explicit.
9650         * inferior.c (inferior::inferior): Push dummy target on target
9651         stack.
9652         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
9653         Add process_stratum_target parameter, and pass it down.
9654         (have_live_inferiors): Adjust.
9655         (switch_to_inferior_and_push_target): New.
9656         (add_inferior_command, clone_inferior_command): Handle
9657         "-no-connection" parameter.  Use
9658         switch_to_inferior_and_push_target.
9659         (_initialize_inferior): Mention "-no-connection" option in
9660         the help of "add-inferior" and "clone-inferior" commands.
9661         * inferior.h: Include "process-stratum-target.h".
9662         (interrupt_target_1): Use bool.
9663         (struct inferior) <push_target, unpush_target, target_is_pushed,
9664         find_target_beneath, top_target, process_target, target_at,
9665         m_stack>: New.
9666         (discard_all_inferiors): Delete.
9667         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
9668         (all_inferiors, all_non_exited_inferiors): Add
9669         process_stratum_target parameter.
9670         * infrun.c: Include "gdb_select.h" and <unordered_map>.
9671         (target_last_proc_target): New global.
9672         (follow_fork_inferior): Push target on new inferior.  Pass target
9673         to add_thread_silent.  Call exec_on_vfork.  Handle target's
9674         reference count.
9675         (follow_fork): Adjust get_last_target_status call.  Also consider
9676         target.
9677         (follow_exec): Push target on new inferior.
9678         (struct execution_control_state) <target>: New field.
9679         (user_visible_resume_target): New.
9680         (do_target_resume): Call target_async.
9681         (resume_1): Set target's threads_executing flag.  Consider resume
9682         target.
9683         (commit_resume_all_targets): New.
9684         (proceed): Also consider resume target.  Skip threads of inferiors
9685         with no execution.  Commit resumtion in all targets.
9686         (start_remote): Pass current inferior to wait_for_inferior.
9687         (infrun_thread_stop_requested): Consider target as well.  Pass
9688         thread_info pointer to clear_inline_frame_state instead of ptid.
9689         (infrun_thread_thread_exit): Consider target as well.
9690         (random_pending_event_thread): New inferior parameter.  Use it.
9691         (do_target_wait): Rename to ...
9692         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
9693         down.
9694         (threads_are_resumed_pending_p, do_target_wait): New.
9695         (prepare_for_detach): Adjust calls.
9696         (wait_for_inferior): New inferior parameter.  Handle it.  Use
9697         do_target_wait_1 instead of do_target_wait.
9698         (fetch_inferior_event): Adjust.  Switch to representative
9699         inferior.  Pass target down.
9700         (set_last_target_status): Add process_stratum_target parameter.
9701         Save target in global.
9702         (get_last_target_status): Add process_stratum_target parameter and
9703         handle it.
9704         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
9705         (context_switch): Check inferior_ptid == null_ptid before calling
9706         inferior_thread().
9707         (get_inferior_stop_soon): Pass down target.
9708         (wait_one): Rename to ...
9709         (poll_one_curr_target): ... this.
9710         (struct wait_one_event): New.
9711         (wait_one): New.
9712         (stop_all_threads): Adjust.
9713         (handle_no_resumed, handle_inferior_event): Adjust to consider the
9714         event's target.
9715         (switch_back_to_stepped_thread): Also consider target.
9716         (print_stop_event): Update.
9717         (normal_stop): Update.  Also consider the resume target.
9718         * infrun.h (wait_for_inferior): Remove declaration.
9719         (user_visible_resume_target): New declaration.
9720         (get_last_target_status, set_last_target_status): New
9721         process_stratum_target parameter.
9722         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9723         process_stratum_target parameter, and use it.
9724         (clear_inline_frame_state (thread_info*)): New.
9725         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
9726         process_stratum_target parameter.
9727         (clear_inline_frame_state (thread_info*)): Declare.
9728         * linux-fork.c (delete_checkpoint_command): Pass target down to
9729         find_thread_ptid.
9730         (checkpoint_command): Adjust.
9731         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
9732         instead of just tweaking inferior_ptid.
9733         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
9734         (exit_lwp): Pass target down to find_thread_ptid.
9735         (attach_proc_task_lwp_callback): Pass target down to
9736         add_thread/set_running/set_executing.
9737         (linux_nat_target::attach): Pass target down to
9738         thread_change_ptid.
9739         (get_detach_signal): Pass target down to find_thread_ptid.
9740         Consider last target status's target.
9741         (linux_resume_one_lwp_throw, resume_lwp)
9742         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
9743         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
9744         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
9745         (linux_nat_target::async_wait_fd): New.
9746         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
9747         target down.
9748         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
9749         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
9750         * linux-thread-db.c (struct thread_db_info::process_target): New
9751         field.
9752         (add_thread_db_info): Save target.
9753         (get_thread_db_info): New process_stratum_target parameter.  Also
9754         match target.
9755         (delete_thread_db_info): New process_stratum_target parameter.
9756         Also match target.
9757         (thread_from_lwp): Adjust to pass down target.
9758         (thread_db_notice_clone): Pass down target.
9759         (check_thread_db_callback): Pass down target.
9760         (try_thread_db_load_1): Always push the thread_db target.
9761         (try_thread_db_load, record_thread): Pass target down.
9762         (thread_db_target::detach): Pass target down.  Always unpush the
9763         thread_db target.
9764         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
9765         target down.  Always unpush the thread_db target.
9766         (find_new_threads_callback, thread_db_find_new_threads_2)
9767         (thread_db_target::update_thread_list): Pass target down.
9768         (thread_db_target::pid_to_str): Pass current inferior down.
9769         (thread_db_target::get_thread_local_address): Pass target down.
9770         (thread_db_target::resume, maintenance_check_libthread_db): Pass
9771         target down.
9772         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
9773         * procfs.c (procfs_target::procfs_init_inferior): Declare.
9774         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
9775         (procfs_init_inferior): Rename to ...
9776         (procfs_target::procfs_init_inferior): ... this and adjust.
9777         (procfs_target::create_inferior, procfs_notice_thread)
9778         (procfs_do_thread_registers): Adjust.
9779         * ppc-fbsd-tdep.c: Include "inferior.h".
9780         (ppcfbsd_get_thread_local_address): Pass down target.
9781         * proc-service.c (ps_xfer_memory): Switch current inferior and
9782         program space as well.
9783         (get_ps_regcache): Pass target down.
9784         * process-stratum-target.c
9785         (process_stratum_target::thread_address_space)
9786         (process_stratum_target::thread_architecture): Pass target down.
9787         * process-stratum-target.h
9788         (process_stratum_target::threads_executing): New field.
9789         (as_process_stratum_target): New.
9790         * ravenscar-thread.c
9791         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
9792         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
9793         down.
9794         * record-btrace.c (record_btrace_target::info_record): Adjust.
9795         (record_btrace_target::record_method)
9796         (record_btrace_target::record_is_replaying)
9797         (record_btrace_target::fetch_registers)
9798         (get_thread_current_frame_id, record_btrace_target::resume)
9799         (record_btrace_target::wait, record_btrace_target::stop): Pass
9800         target down.
9801         * record-full.c (record_full_wait_1): Switch to event thread.
9802         Pass target down.
9803         * regcache.c (regcache::regcache)
9804         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
9805         process_stratum_target parameter and handle it.
9806         (current_thread_target): New global.
9807         (get_thread_regcache): Add process_stratum_target parameter and
9808         handle it.  Switch inferior before calling target method.
9809         (get_thread_regcache): Pass target down.
9810         (get_thread_regcache_for_ptid): Pass target down.
9811         (registers_changed_ptid): Add process_stratum_target parameter and
9812         handle it.
9813         (registers_changed_thread, registers_changed): Pass target down.
9814         (test_get_thread_arch_aspace_regcache): New.
9815         (current_regcache_test): Define a couple local test_target_ops
9816         instances and use them for testing.
9817         (readwrite_regcache): Pass process_stratum_target parameter.
9818         (cooked_read_test, cooked_write_test): Pass mock_target down.
9819         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
9820         (get_thread_arch_aspace_regcache): Add process_stratum_target
9821         parameter.
9822         (regcache::target): New method.
9823         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
9824         (regcache::registers_changed_ptid): Add process_stratum_target
9825         parameter.
9826         (regcache::m_target): New field.
9827         (registers_changed_ptid): Add process_stratum_target parameter.
9828         * remote.c (remote_state::supports_vCont_probed): New field.
9829         (remote_target::async_wait_fd): New method.
9830         (remote_unpush_and_throw): Add remote_target parameter.
9831         (get_current_remote_target): Adjust.
9832         (remote_target::remote_add_inferior): Push target.
9833         (remote_target::remote_add_thread)
9834         (remote_target::remote_notice_new_inferior)
9835         (get_remote_thread_info): Pass target down.
9836         (remote_target::update_thread_list): Skip threads of inferiors
9837         bound to other targets.  (remote_target::close): Don't discard
9838         inferiors.  (remote_target::add_current_inferior_and_thread)
9839         (remote_target::process_initial_stop_replies)
9840         (remote_target::start_remote)
9841         (remote_target::remote_serial_quit_handler): Pass down target.
9842         (remote_target::remote_unpush_target): New remote_target
9843         parameter.  Unpush the target from all inferiors.
9844         (remote_target::remote_unpush_and_throw): New remote_target
9845         parameter.  Pass it down.
9846         (remote_target::open_1): Check whether the current inferior has
9847         execution instead of checking whether any inferior is live.  Pass
9848         target down.
9849         (remote_target::remote_detach_1): Pass down target.  Use
9850         remote_unpush_target.
9851         (extended_remote_target::attach): Pass down target.
9852         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
9853         (remote_target::append_resumption): Pass down target.
9854         (remote_target::append_pending_thread_resumptions)
9855         (remote_target::remote_resume_with_hc, remote_target::resume)
9856         (remote_target::commit_resume): Pass down target.
9857         (remote_target::remote_stop_ns): Check supports_vCont_probed.
9858         (remote_target::interrupt_query)
9859         (remote_target::remove_new_fork_children)
9860         (remote_target::check_pending_events_prevent_wildcard_vcont)
9861         (remote_target::remote_parse_stop_reply)
9862         (remote_target::process_stop_reply): Pass down target.
9863         (first_remote_resumed_thread): New remote_target parameter.  Pass
9864         it down.
9865         (remote_target::wait_as): Pass down target.
9866         (unpush_and_perror): New remote_target parameter.  Pass it down.
9867         (remote_target::readchar, remote_target::remote_serial_write)
9868         (remote_target::getpkt_or_notif_sane_1)
9869         (remote_target::kill_new_fork_children, remote_target::kill): Pass
9870         down target.
9871         (remote_target::mourn_inferior): Pass down target.  Use
9872         remote_unpush_target.
9873         (remote_target::core_of_thread)
9874         (remote_target::remote_btrace_maybe_reopen): Pass down target.
9875         (remote_target::pid_to_exec_file)
9876         (remote_target::thread_handle_to_thread_info): Pass down target.
9877         (remote_target::async_wait_fd): New.
9878         * riscv-fbsd-tdep.c: Include "inferior.h".
9879         (riscv_fbsd_get_thread_local_address): Pass down target.
9880         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
9881         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
9882         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
9883         Adjust.
9884         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
9885         * solib-svr4.c (enable_break): Pass down target.
9886         * spu-multiarch.c (parse_spufs_run): Pass down target.
9887         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
9888         * target-delegates.c: Regenerate.
9889         * target.c (g_target_stack): Delete.
9890         (current_top_target): Return the current inferior's top target.
9891         (target_has_execution_1): Refer to the passed-in inferior's top
9892         target.
9893         (target_supports_terminal_ours): Check whether the initial
9894         inferior was already created.
9895         (decref_target): New.
9896         (target_stack::push): Incref/decref the target.
9897         (push_target, push_target, unpush_target): Adjust.
9898         (target_stack::unpush): Defref target.
9899         (target_is_pushed): Return bool.  Adjust to refer to the current
9900         inferior's target stack.
9901         (dispose_inferior): Delete, and inline parts ...
9902         (target_preopen): ... here.  Only dispose of the current inferior.
9903         (target_detach): Hold strong target reference while detaching.
9904         Pass target down.
9905         (target_thread_name): Add assertion.
9906         (target_resume): Pass down target.
9907         (target_ops::beneath, find_target_at): Adjust to refer to the
9908         current inferior's target stack.
9909         (get_dummy_target): New.
9910         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
9911         has a thread running.
9912         (initialize_targets): Rename to ...
9913         (_initialize_target): ... this.
9914         * target.h: Include "gdbsupport/refcounted-object.h".
9915         (struct target_ops): Inherit refcounted_object.
9916         (target_ops::shortname, target_ops::longname): Make const.
9917         (target_ops::async_wait_fd): New method.
9918         (decref_target): Declare.
9919         (struct target_ops_ref_policy): New.
9920         (target_ops_ref): New typedef.
9921         (get_dummy_target): Declare function.
9922         (target_is_pushed): Return bool.
9923         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
9924         (all_matching_threads_iterator::all_matching_threads_iterator):
9925         Handle filter target.
9926         * thread-iter.h (struct all_matching_threads_iterator, struct
9927         all_matching_threads_range, class all_non_exited_threads_range):
9928         Filter by target too.  Remove explicit.
9929         * thread.c (threads_executing): Delete.
9930         (inferior_thread): Pass down current inferior.
9931         (clear_thread_inferior_resources): Pass down thread pointer
9932         instead of ptid_t.
9933         (add_thread_silent, add_thread_with_info, add_thread): Add
9934         process_stratum_target parameter.  Use it for thread and inferior
9935         searches.
9936         (is_current_thread): New.
9937         (thread_info::deletable): Use it.
9938         (find_thread_ptid, thread_count, in_thread_list)
9939         (thread_change_ptid, set_resumed, set_running): New
9940         process_stratum_target parameter.  Pass it down.
9941         (set_executing): New process_stratum_target parameter.  Pass it
9942         down.  Adjust reference to 'threads_executing'.
9943         (threads_are_executing): New process_stratum_target parameter.
9944         Adjust reference to 'threads_executing'.
9945         (set_stop_requested, finish_thread_state): New
9946         process_stratum_target parameter.  Pass it down.
9947         (switch_to_thread): Also match inferior.
9948         (switch_to_thread): New process_stratum_target parameter.  Pass it
9949         down.
9950         (update_threads_executing): Reimplement.
9951         * top.c (quit_force): Pop targets from all inferior.
9952         (gdb_init): Don't call initialize_targets.
9953         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
9954         Declare.
9955         (windows_add_thread, windows_delete_thread): Adjust.
9956         (get_windows_debug_event): Rename to ...
9957         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
9958         * tracefile-tfile.c (tfile_target_open): Pass down target.
9959         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
9960         Forward declare.
9961         (switch_to_thread): Add process_stratum_target parameter.
9962         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
9963         parameter.  Use it.
9964         (mi_on_resume): Pass target down.
9965         * nat/fork-inferior.c (startup_inferior): Add
9966         process_stratum_target parameter.  Pass it down.
9967         * nat/fork-inferior.h (startup_inferior): Add
9968         process_stratum_target parameter.
9969         * python/py-threadevent.c (py_get_event_thread): Pass target down.
9970
9971 2020-01-10  Pedro Alves  <palves@redhat.com>
9972
9973         * remote.c (remote_target::start_remote): Don't set inferior_ptid
9974         directly.  Instead find the first thread in the thread list and
9975         use switch_to_thread.
9976
9977 2020-01-10  Pedro Alves  <palves@redhat.com>
9978
9979         * remote.c (remote_target::remote_add_inferior): Don't bind a
9980         process to the current inferior if the current inferior is already
9981         bound to a process.
9982
9983 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9984             Pedro Alves  <palves@redhat.com>
9985
9986         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
9987         If no process is specified, return null_ptid instead of
9988         inferior_ptid.
9989         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
9990         TARGET_WAITKIND_SIGNALLED with no pid.
9991
9992 2020-01-10  Pedro Alves  <palves@redhat.com>
9993
9994         * remote.c (first_remote_resumed_thread): New.
9995         (remote_target::wait_as): Use it as default event_ptid instead of
9996         inferior_ptid.
9997
9998 2020-01-10  Pedro Alves  <palves@redhat.com>
9999
10000         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
10001
10002 2020-01-10  Pedro Alves  <palves@redhat.com>
10003
10004         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
10005         not -1.
10006
10007 2020-01-10  Pedro Alves  <palves@redhat.com>
10008
10009         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
10010         ptid to get_last_target_status.
10011         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
10012         ptid to get_last_target_status.
10013         * infcmd.c (continue_command): Don't pass a target_waitstatus to
10014         get_last_target_status.
10015         (info_program_command): Don't pass a target_waitstatus to
10016         get_last_target_status.
10017         * infrun.c (init_wait_for_inferior): Use
10018         nullify_last_target_wait_ptid.
10019         (get_last_target_status): Handle nullptr arguments.
10020         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
10021         (print_stop_event): Don't pass a ptid to get_last_target_status.
10022         (normal_stop): Don't pass a ptid to get_last_target_status.
10023         * infrun.h (get_last_target_status, set_last_target_status): Move
10024         comments here and update.
10025         (nullify_last_target_wait_ptid): Declare.
10026         * linux-fork.c (fork_load_infrun_state): Remove local extern
10027         declaration of nullify_last_target_wait_ptid.
10028         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
10029         to get_last_target_status.
10030
10031 2020-01-10  Pedro Alves  <palves@redhat.com>
10032
10033         * gdbthread.h (scoped_restore_current_thread)
10034         <dont_restore, restore, m_dont_restore>: Declare.
10035         * thread.c (thread_alive): Add assertion.  Return bool.
10036         (switch_to_thread_if_alive): New.
10037         (prune_threads): Switch inferior/thread.
10038         (print_thread_info_1): Switch thread before calling target methods.
10039         (scoped_restore_current_thread::restore): New, factored out from
10040         ...
10041         (scoped_restore_current_thread::~scoped_restore_current_thread):
10042         ... this.
10043         (scoped_restore_current_thread::scoped_restore_current_thread):
10044         Add assertion.
10045         (thread_apply_all_command, thread_select): Use
10046         switch_to_thread_if_alive.
10047         * infrun.c (proceed, restart_threads, handle_signal_stop)
10048         (switch_back_to_stepped_thread): Switch current thread before
10049         calling target methods.
10050
10051 2020-01-10  Pedro Alves <palves@redhat.com>
10052
10053         * inferior.c (switch_to_inferior_no_thread): New function,
10054         factored out from ...
10055         (inferior_command): ... here.
10056         * inferior.h (switch_to_inferior_no_thread): Declare.
10057         * mi/mi-main.c (run_one_inferior): Use
10058         switch_to_inferior_no_thread.
10059
10060 2020-01-10  Pedro Alves  <palves@redhat.com>
10061
10062         * infcmd.c (kill_command): Remove dead code.
10063
10064 2020-01-10  Pedro Alves  <palves@redhat.com>
10065
10066         * remote.c (remote_target::mourn_inferior): No longer check
10067         whether the target is running.
10068
10069 2020-01-10  Pedro Alves  <palves@redhat.com>
10070
10071         * corelow.c (core_target::has_execution): Change parameter type to
10072         inferior pointer.
10073         * inferior.c (number_of_live_inferiors): Use
10074         inferior::has_execution instead of target_has_execution_1.
10075         * inferior.h (inferior::has_execution): New.
10076         * linux-thread-db.c (thread_db_target::update_thread_list): Use
10077         inferior::has_execution instead of target_has_execution_1.
10078         * process-stratum-target.c
10079         (process_stratum_target::has_execution): Change parameter type to
10080         inferior pointer.  Check the inferior's PID instead of
10081         inferior_ptid.
10082         * process-stratum-target.h
10083         (process_stratum_target::has_execution): Change parameter type to
10084         inferior pointer.
10085         * record-full.c (record_full_core_target::has_execution): Change
10086         parameter type to inferior pointer.
10087         * target.c (target_has_execution_1): Change parameter type to
10088         inferior pointer.
10089         (target_has_execution_current): Adjust.
10090         * target.h (target_ops::has_execution): Change parameter type to
10091         inferior pointer.
10092         (target_has_execution_1): Change parameter type to inferior
10093         pointer.  Change return type to bool.
10094         * tracefile.h (tracefile_target::has_execution): Change parameter
10095         type to inferior pointer.
10096
10097 2020-01-10  Pedro Alves  <palves@redhat.com>
10098
10099         * exceptions.c (print_flush): Remove current_top_target() check.
10100
10101 2020-01-10  Pedro Alves  <palves@redhat.com>
10102
10103         * remote.c (show_remote_exec_file): Show the current inferior's
10104         exec-file instead of the command variable's value.
10105
10106 2020-01-10  Pedro Alves  <palves@redhat.com>
10107
10108         * record-full.c (record_full_resume_ptid): New global.
10109         (record_full_target::resume): Set it.
10110         (record_full_wait_1): Use record_full_resume_ptid instead of
10111         inferior_ptid.
10112
10113 2020-01-10  Pedro Alves  <palves@redhat.com>
10114
10115         * gdbthread.h (scoped_restore_current_thread)
10116         <dont_restore, restore, m_dont_restore>: Declare.
10117         * thread.c (thread_alive): Add assertion.  Return bool.
10118         (switch_to_thread_if_alive): New.
10119         (prune_threads): Switch inferior/thread.
10120         (print_thread_info_1): Switch thread before calling target methods.
10121         (scoped_restore_current_thread::restore): New, factored out from
10122         ...
10123         (scoped_restore_current_thread::~scoped_restore_current_thread):
10124         ... this.
10125         (scoped_restore_current_thread::scoped_restore_current_thread):
10126         Add assertion.
10127         (thread_apply_all_command, thread_select): Use
10128         switch_to_thread_if_alive.
10129
10130 2020-01-10  George Barrett  <bob@bob131.so>
10131
10132         * stap-probe.c (stap_modify_semaphore): Don't check for null
10133         semaphores.
10134         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
10135         for null semaphores.
10136
10137 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10138
10139         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
10140         all source windows, and maintain horizontal scroll status while
10141         doing so.
10142
10143 2020-01-09  Tom Tromey  <tom@tromey.com>
10144
10145         PR tui/18932:
10146         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
10147         update_source_window, not print_source_lines.
10148
10149 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10150
10151         * tui/tui.c (tui_enable): Register tui hooks after calling
10152         tui_display_main.
10153
10154 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10155
10156         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
10157
10158 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
10159
10160         * thread.c (print_thread_info_1): Fix indentation.
10161
10162 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10163
10164         * symtab.c (general_symbol_info::compute_and_set_names): Move the
10165         unique_xmalloc_ptr outside the if to always free the demangled name.
10166
10167 2020-01-08  Tom Tromey  <tromey@adacore.com>
10168
10169         * xcoffread.c (enter_line_range, read_xcoff_symtab)
10170         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
10171         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
10172         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
10173         Remove.
10174         (section_offsets): New typedef.
10175         * symtab.c (fixup_section, get_msymbol_address): Update.
10176         * symmisc.c (dump_msymbols): Update.
10177         * symfile.h (relative_addr_info_to_section_offsets)
10178         (symfile_map_offsets_to_segments): Update.
10179         * symfile.c (build_section_addr_info_from_objfile)
10180         (init_objfile_sect_indices): Update.
10181         (struct place_section_arg): Change type of "offsets".
10182         (place_section): Update.
10183         (relative_addr_info_to_section_offsets): Change type of
10184         "section_offsets".  Remove "num_sections" parameter.
10185         (default_symfile_offsets, syms_from_objfile_1)
10186         (set_objfile_default_section_offset): Update.
10187         (reread_symbols): No need to preserve section offsets by hand.
10188         (symfile_map_offsets_to_segments): Change type of "offsets".
10189         * stap-probe.c (relocate_address): Update.
10190         * stabsread.h (process_one_symbol): Update.
10191         * solib-target.c (struct lm_info_target) <offsets>: Change type.
10192         (solib_target_relocate_section_addresses): Update.
10193         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
10194         Update.
10195         * solib-frv.c (frv_relocate_main_executable): Update.
10196         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
10197         * solib-aix.c (solib_aix_get_section_offsets): Change return
10198         type.
10199         (solib_aix_solib_create_inferior_hook): Update.
10200         * remote.c (remote_target::get_offsets): Update.
10201         * psymtab.c (find_pc_sect_psymtab): Update.
10202         * psympriv.h (struct partial_symbol) <address, text_low,
10203         text_high>: Update.
10204         * objfiles.h (obj_section_offset): Update.
10205         (struct objfile) <section_offsets>: Change type.
10206         <num_sections>: Remove.
10207         (objfile_relocate): Update.
10208         * objfiles.c (entry_point_address_query): Update
10209         (relocate_one_symbol): Change type of "section_offsets".
10210         (objfile_relocate1, objfile_relocate1): Change type of
10211         "new_offsets".
10212         (objfile_rebase1): Update.
10213         * mipsread.c (mipscoff_symfile_read): Update.
10214         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
10215         parameter.
10216         * mdebugread.c (parse_symbol): Change type of "section_offsets".
10217         (parse_external, psymtab_to_symtab_1): Update.
10218         * machoread.c (macho_symfile_offsets): Update.
10219         * ia64-tdep.c (ia64_find_unwind_table): Update.
10220         * hppa-tdep.c (read_unwind_info): Update.
10221         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
10222         * dwarf2read.c (create_addrmap_from_index)
10223         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10224         (process_psymtab_comp_unit_reader, add_partial_symbol)
10225         (add_partial_subprogram, process_full_comp_unit)
10226         (read_file_scope, read_func_scope, read_lexical_block_scope)
10227         (read_call_site_scope, dwarf2_rnglists_process)
10228         (dwarf2_ranges_process, dwarf2_ranges_read)
10229         (dwarf_decode_lines_1, var_decode_location, new_symbol)
10230         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
10231         Update.
10232         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
10233         Update.
10234         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
10235         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
10236         (process_one_symbol): Change type of "section_offsets".
10237         * ctfread.c (get_objfile_text_range): Update.
10238         * coffread.c (coff_symtab_read, enter_linenos)
10239         (process_coff_symbol): Update.
10240         * coff-pe-read.c (add_pe_forwarded_sym): Update.
10241         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
10242
10243 2020-01-08  Tom Tromey  <tromey@adacore.com>
10244
10245         * dwarf2read.c (parse_macro_definition): Use std::string.
10246         (parse_macro_definition): Likewise.
10247
10248 2020-01-08  Tom Tromey  <tromey@adacore.com>
10249
10250         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
10251         (ATTR_ALLOC_CHUNK): Remove.
10252
10253 2020-01-08  Tom Tromey  <tromey@adacore.com>
10254
10255         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
10256
10257 2020-01-08  Tom Tromey  <tromey@adacore.com>
10258
10259         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
10260         (dwarf2_compute_name, open_dwo_file): Likewise.
10261         (process_enumeration_scope): Use std::vector.
10262         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
10263         (partial_die_info::fixup, dwarf2_start_subfile)
10264         (guess_full_die_structure_name, dwarf2_name): Likewise.
10265         (determine_prefix): Update.
10266         (guess_full_die_structure_name): Make return type const.
10267         (partial_die_full_name): Return unique_xmalloc_ptr.
10268         (DW_FIELD_ALLOC_CHUNK): Remove.
10269
10270 2020-01-07  Tom Tromey  <tromey@adacore.com>
10271
10272         PR build/24937:
10273         * stap-probe.c (class stap_static_probe_ops): Add constructor.
10274
10275 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10276
10277         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
10278
10279 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10280
10281         * stack.c (print_frame_info): Move disassemble_next_line code
10282         inside source_print block.
10283
10284 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10285
10286         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
10287         gdb/signals.h, as we are now using native signal symbols.
10288
10289 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10290
10291         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
10292         overflow by an early check of content vs threshold.
10293         * tui/tui-source.c (tui_source_window::line_is_displayed):
10294         Likewise.
10295
10296 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10297
10298         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
10299
10300 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10301
10302         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
10303         export table if no section contains it's RVA.
10304
10305 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10306
10307         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
10308
10309 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
10310
10311         * source.c (print_source_lines_base): Set last_line_listed.
10312
10313 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10314
10315         * tui/tui-disasm.c: Remove trailing spaces.
10316
10317 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10318             Pedro Alves  <palves@redhat.com>
10319
10320         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
10321         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
10322         (windows_gdb_signal_to_target): New function, uses the above
10323         enumeration to convert GDB internal signal codes to equivalent
10324         Windows codes.
10325         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
10326         * windows-nat.c: Include "gdb_wait.h".
10327         (get_windows_debug_event): Extract the fatal exception from the
10328         exit status and convert to the equivalent Posix signal number.
10329         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
10330         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
10331         * gdbsupport/gdb_wait.c: New file, implements
10332         windows_status_to_termsig.
10333         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
10334         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
10335
10336 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10337
10338         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
10339         show_layout.
10340
10341 2020-01-05  Luis Machado  <luis.machado@linaro.org>
10342
10343         * aarch64-linux-nat.c
10344         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
10345         and bfd_mach_aarch64.
10346
10347 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10348
10349         * ui-file.c (stdio_file::can_emit_style_escape)
10350         (tee_file::can_emit_style_escape): Ensure style is used also on
10351         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
10352         to gdb_stdout.
10353         * main.c (set_gdb_data_directory): Use file style to output the
10354         warning that the given pathname is not a directory.
10355         * top.c (show_history_filename, gdb_safe_append_history)
10356         (show_gdb_datadir): Use file style.
10357
10358 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10359
10360         * solib-target.c (struct lm_info_target):
10361         Change offsets to be a unique_xmalloc_ptr.
10362         (solib_target_relocate_section_addresses): Update.
10363
10364 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10365
10366         * windows-nat.c (windows_clear_solib): Free so_list linked list.
10367
10368 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10369
10370         * MAINTAINERS (Write After Approval): Add myself.
10371
10372 2020-01-02  Luis Machado  <luis.machado@linaro.org>
10373
10374         * proc-service.c (get_ps_regcache): Remove reference to obsolete
10375         Cell BE architecture.
10376         * target.h (struct target_ops) <thread_architecture>: Likewise.
10377
10378 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10379
10380         * Makefile.in: Use INSTALL_PROGRAM_ENV.
10381
10382 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10383
10384         * MAINTAINERS (Write After Approval): Add myself.
10385
10386 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10387
10388         * gdbarch.sh: Update copyright year range of generated files.
10389
10390 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10391
10392         Update copyright year range in all GDB files.
10393
10394 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10395
10396         * copyright.py: Convert to Python 3.
10397
10398 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10399
10400         * copyright.py: Adapt after move of gnulib directory from gdb
10401         directory to toplevel directory.
10402
10403 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10404
10405         * copyright.py (main): Exit if run from the wrong directory.
10406
10407 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10408
10409         * top.c (print_gdb_version): Change copyright year to 2020.
10410
10411 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10412
10413         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
10414
10415 For older changes see ChangeLog-2019.
10416 \f
10417 Local Variables:
10418 mode: change-log
10419 left-margin: 8
10420 fill-column: 74
10421 version-control: never
10422 coding: utf-8
10423 End: